gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (tui_set_layout): Update.
   4         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
   5         * tui/tui-data.c (layout_def): Update.
   6
   7 2019-06-25  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-wingeneral.c (tui_refresh_all): Update.
  10         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  11         (tui_source_window_base::set_new_height): Update.
  12         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
  13         Update.
  14         (tui_set_locator_fullname, tui_set_locator_info)
  15         (tui_show_frame_info): Update.
  16         * tui/tui-source.c (tui_set_source_content)
  17         (tui_source_is_displayed): Update.
  18         * tui/tui-layout.c (show_source_disasm_command, show_data)
  19         (show_source_or_disasm_and_command): Update.
  20         * tui/tui-disasm.c (tui_set_disassem_content)
  21         (tui_get_begin_asm_address): Update.
  22         * tui/tui-data.h (struct tui_locator_element): Remove.
  23         (union tui_which_element) <locator>: Remove.
  24         (struct tui_locator_window): New.
  25         (tui_locator_win_info_ptr): Change return type.
  26         * tui/tui-data.c (_locator): Change type.
  27         (tui_locator_win_info_ptr): Change return type.
  28         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
  29         (tui_alloc_content): Add assert.
  30
  31 2019-06-25  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-winsource.c
  34         (tui_exec_info_window::maybe_allocate_content): New method.
  35         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
  36         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
  37         (make_source_or_disasm_window): Add cast.
  38         * tui/tui-data.h (union tui_which_element) <simple_string>:
  39         Remove.
  40         (struct tui_source_info): New.
  41         (struct tui_source_window_base) <execution_info>: Change type.
  42         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
  43         case, and add assert.
  44         (tui_alloc_content): Add assert.
  45
  46 2019-06-25  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
  49         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
  50         * tui/tui-data.c (tui_alloc_win_info): Remove.
  51
  52 2019-06-25  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
  55         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
  56         can_highlight.
  57
  58 2019-06-25  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
  61         make_visible_with_new_height method.
  62         (tui_win_info::make_visible_with_new_height): New method.
  63         (tui_source_window_base::do_make_visible_with_new_height)
  64         (tui_data_window::do_make_visible_with_new_height)
  65         (tui_cmd_window::do_make_visible_with_new_height): New methods.
  66         (make_visible_with_new_height): Remove.
  67         (tui_resize_all, tui_adjust_win_heights): Use
  68         make_visible_with_new_height method.
  69         * tui/tui-data.h (struct tui_win_info)
  70         <do_make_visible_with_new_height, make_visible_with_new_height>:
  71         New methods.
  72         (struct tui_source_window_base, struct tui_data_window)
  73         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
  74         methods.
  75
  76 2019-06-25  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
  79         method.
  80         (update_tab_width): Call update_tab_width method.
  81         * tui/tui-data.h (struct tui_win_info)
  82         (struct tui_source_window_base) <update_tab_width>: New methods.
  83
  84 2019-06-25  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
  87         parameter.
  88         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
  89         parameter.
  90         (tui_gen_win_info::make_visible): Update.
  91         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
  92         parameter.
  93         * tui/tui-data.h (enum tui_box): New enum.
  94         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
  95
  96 2019-06-25  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-layout.c (make_source_or_disasm_window): Always use
  99         init_and_make_win for EXEC_INFO_WIN.
 100         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 101         longer inline.
 102         (struct tui_win_info) <~tui_win_info>: Inline.
 103         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 104         Don't declare.
 105         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 106         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 107         Remove.
 108         (tui_initialize_static_data): Update.
 109         (~tui_gen_win_info): Handle more cleanup here.
 110         (~tui_source_window_base): Delete "execution_info".
 111         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 112
 113 2019-06-25  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-layout.c (make_command_window): Don't set
 116         can_highlight.
 117         (show_source_disasm_command): Call the reset method.
 118         (show_data): Don't set can_highlight.  Call the reset method.
 119         (tui_gen_win_info::reset): Rename from init_gen_win_info
 120         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 121         (show_source_or_disasm_and_command): Call the reset method.
 122         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 123         (struct tui_cmd_window): Set can_highlight.
 124
 125 2019-06-25  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 128         from make_visible.
 129         (tui_make_visible, tui_make_invisible): Rewrite.
 130         (tui_win_info::make_visible): Remove.
 131         (tui_source_window_base::make_visible): Update.
 132         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 133         method.  Moved from...
 134         (struct tui_win_info) <make_visible>: ...here.
 135
 136 2019-06-25  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-winsource.c
 139         (tui_source_window_base::do_scroll_horizontal): Remove direction
 140         parameter.
 141         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 142         direction parameter.
 143         * tui/tui-win.c (tui_win_info::forward_scroll)
 144         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 145         (tui_win_info::right_scroll): Update.
 146         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 147         direction parameter.
 148         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 149         direction parameter.
 150         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 151         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 152         Remove direction parameter.
 153         (struct tui_source_window_base, struct tui_source_window)
 154         (struct tui_disasm_window, struct tui_data_window)
 155         (struct tui_cmd_window): Update.
 156
 157 2019-06-25  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-winsource.h (tui_set_exec_info_content)
 160         (tui_show_exec_info_content, tui_erase_exec_info_content)
 161         (tui_clear_exec_info_content, tui_update_exec_info): Change
 162         argument to tui_source_window_base.
 163         * tui/tui-winsource.c (tui_set_exec_info_content)
 164         (tui_show_exec_info_content, tui_erase_exec_info_content)
 165         (tui_clear_exec_info_content, tui_update_exec_info): Change
 166         argument to tui_source_window_base.
 167
 168 2019-06-25  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 171         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 172
 173 2019-06-25  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 176         check.
 177
 178 2019-06-25  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 181         type to void.
 182         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 183         type to void.
 184         * tui/tui-source.c (tui_set_source_content): Update.
 185         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 186
 187 2019-06-25  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-win.c (window_name_completer, tui_set_focus)
 190         (tui_all_windows_info): Use name method.
 191         * tui/tui-data.h (struct tui_gen_win_info)
 192         (struct tui_source_window, struct tui_disasm_window)
 193         (struct tui_data_window, struct tui_cmd_window) <name>: New
 194         method.
 195         (tui_win_name): Don't declare.
 196         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 197         (tui_win_name): Remove.
 198
 199 2019-06-25  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-winsource.h (tui_update_source_window)
 202         (tui_update_source_window_as_is): Change parameter type.
 203         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 204         to be a tui_source_window_base.
 205         (tui_update_source_window_as_is): Likewise.
 206         * tui/tui-win.c (make_visible_with_new_height): Update.
 207
 208 2019-06-25  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-winsource.c (tui_erase_source_content)
 211         (tui_show_source_content, tui_show_exec_info_content)
 212         (tui_erase_exec_info_content): Use refresh_window method.
 213         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 214         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 215         from tui_refresh_win.
 216         (tui_data_window::refresh_window): New method.
 217         (tui_win_info::refresh, tui_source_window_base::refresh)
 218         (tui_refresh_all): Use refresh_window method.
 219         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 220         method.
 221         * tui/tui-regs.c (tui_display_register): Call refresh_window
 222         method.
 223         * tui/tui-layout.c (show_source_disasm_command)
 224         (show_source_or_disasm_and_command): Call refresh_window method.
 225         * tui/tui-data.h (struct tui_gen_win_info)
 226         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 227         New method.
 228
 229 2019-06-25  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui.c (tui_rl_other_window, tui_enable)
 232         (tui_is_window_visible, tui_get_command_dimension): Update.
 233         * tui/tui-winsource.c (tui_update_source_window_as_is)
 234         (tui_clear_source_content, tui_erase_source_content)
 235         (tui_show_source_line, tui_source_window_base::refill)
 236         (tui_source_window_base::do_scroll_horizontal)
 237         (tui_source_window_base::set_is_exec_point_at)
 238         (tui_update_breakpoint_info, tui_set_exec_info_content)
 239         (tui_alloc_source_buffer, tui_line_is_displayed)
 240         (tui_addr_is_displayed): Update.
 241         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 242         (tui_check_and_display_highlight_if_needed)
 243         (tui_win_info::make_visible, tui_win_info::refresh)
 244         (tui_refresh_all): Update.
 245         * tui/tui-windata.c (tui_first_data_item_displayed)
 246         (tui_delete_data_content_windows, tui_erase_data_content)
 247         (tui_display_all_data, tui_data_window::refresh_all)
 248         (tui_check_data_values): Update.
 249         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 250         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 251         (tui_win_info::backward_scroll, tui_refresh_all_win)
 252         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 253         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 254         (tui_source_window_base::set_new_height)
 255         (tui_data_window::set_new_height)
 256         (make_invisible_and_set_new_height)
 257         (make_visible_with_new_height, new_height_ok)
 258         (parse_scrolling_args): Update.
 259         * tui/tui-stack.c (tui_show_frame_info): Update.
 260         * tui/tui-source.c (tui_set_source_content)
 261         (tui_set_source_content_nil, tui_source_is_displayed)
 262         (tui_source_window::do_scroll_vertical): Update.
 263         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 264         (tui_display_registers_from, tui_display_reg_element_at_line)
 265         (tui_check_register_values, tui_reg_command): Update.
 266         * tui/tui-layout.c (tui_default_win_height)
 267         (show_source_disasm_command, show_data, init_and_make_win)
 268         (show_source_or_disasm_and_command): Update.
 269         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 270         (tui_redisplay_readline, tui_mld_flush)
 271         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 272         (tui_getc): Update.
 273         * tui/tui-disasm.c (tui_set_disassem_content)
 274         (tui_disasm_window::do_scroll_vertical): Update.
 275         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 276         Now virtual.
 277         (struct tui_win_info): Derive from tui_gen_win_info.
 278         <~tui_win_info>: Mark as override.
 279         <generic>: Remove member.
 280         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 281         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 282         (~tui_data_window, ~tui_win_info)
 283         (tui_free_all_source_wins_content): Update.
 284         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 285
 286 2019-06-25  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-layout.c (init_and_make_win): Use new.
 289         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 290         destructor, initializers.
 291         (tui_alloc_generic_win_info): Don't declare.
 292         * tui/tui-data.c (_locator): Add argument to constructor.
 293         (source_win, disasm_win): New globals.
 294         (exec_info): Remove.
 295         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 296         Update.
 297         (tui_alloc_generic_win_info): Remove.
 298         (init_content_element): Use new.
 299         (tui_win_info::tui_win_info): Update.
 300         (free_content_elements) <case DATA_WIN>: Use delete.
 301
 302 2019-06-25  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 305         * tui/tui-windata.c (tui_first_data_item_displayed)
 306         (tui_delete_data_content_windows): Update.
 307         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 308         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 309         (tui_display_registers_from, tui_check_register_values): Update.
 310         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 311         pointer.
 312         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 313         window.
 314         (tui_free_data_content): Update.
 315         (free_content_elements) <case DATA_WIN>: Free the window.
 316
 317 2019-06-25  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 320         Update.
 321         * tui/tui-layout.c (make_command_window)
 322         (show_source_disasm_command, show_data, init_and_make_win)
 323         (show_source_or_disasm_and_command): Update.
 324         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 325         method.
 326         <can_highight, is_highlighted>: Now bool.
 327         (tui_set_win_highlight): Don't declare.
 328         * tui/tui-data.c (tui_set_win_highlight): Remove.
 329
 330 2019-06-25  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-wingeneral.c (make_visible): Remove check of window
 333         type.
 334
 335 2019-06-25  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-win.c (tui_win_info::max_height)
 338         (tui_cmd_window::max_height): New methods.
 339         (new_height_ok): Call max_height.
 340         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 341         <max_height>: New method.
 342
 343 2019-06-25  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-win.c (tui_source_window_base::set_new_height)
 346         (tui_data_window::set_new_height): New methods.
 347         (make_invisible_and_set_new_height): Call set_new_height method.
 348         * tui/tui-data.h (struct tui_win_info)
 349         (struct tui_source_window_base, struct tui_data_window)
 350         <set_new_height>: New method.
 351
 352 2019-06-25  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 355         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 356         tui_refresh_data_win.
 357         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 358         method.
 359         (tui_refresh_all_win): Call the refresh_all method.
 360         (tui_set_focus): Likewise.
 361         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 362         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 363         Likewise.
 364
 365 2019-06-25  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-winsource.h (tui_refill_source_window)
 368         (tui_set_is_exec_point_at): Don't declare.
 369         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 370         (tui_source_window_base::refill): Rename from
 371         tui_refill_source_window.
 372         (tui_source_window_base::do_scroll_horizontal): Update.
 373         (tui_source_window_base::set_is_exec_point_at): Rename from
 374         tui_set_is_exec_point_at.
 375         (tui_update_all_breakpoint_info): Update.
 376         * tui/tui-stack.c (tui_show_frame_info): Update.
 377         * tui/tui-layout.c (show_data): Add cast.
 378         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 379         * tui/tui-data.h (struct tui_source_window_base) <refill,
 380         set_is_exec_point_at>: New methods.
 381         (tui_source_windows, tui_add_to_source_windows): Update types.
 382         (tui_add_to_source_windows): Remove redundant declaration.
 383         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 384         (tui_source_windows): Change return type.
 385         (tui_clear_source_windows_detail): Update.
 386         (tui_add_to_source_windows): Change type of parameter.
 387         (tui_free_all_source_wins_content): Update.
 388
 389 2019-06-25  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-wingeneral.c (tui_win_info::refresh)
 392         (tui_source_window_base::refresh): New methods.
 393         (tui_refresh_all): Call the refresh method.
 394         * tui/tui-data.h (struct tui_win_info)
 395         (struct tui_source_window_base) <refresh>: New method.
 396
 397 2019-06-25  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui.h (tui_is_window_visible): Return bool.
 400         * tui/tui.c (tui_is_window_visible): Return bool.
 401         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 402         (tui_make_visible, tui_make_invisible)
 403         (tui_win_info::make_visible)
 404         (tui_source_window_base::make_visible, make_all_visible)
 405         (tui_make_all_visible, tui_make_all_invisible): Update.
 406         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 407         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 408         bool.
 409         (struct tui_win_info, struct tui_source_window_base)
 410         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 411         * tui/tui-data.c (tui_init_generic_part): Update.
 412
 413 2019-06-25  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 416         (tui_source_window_base::make_visible): New methods.
 417         (make_all_visible): Make method call.
 418         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 419         (struct tui_source_window_base, struct tui_cmd_window): Override
 420         make_visible.
 421         (tui_win_is_source_type): Don't declare.
 422         * tui/tui-data.c (tui_win_is_source_type): Remove.
 423
 424 2019-06-25  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 427         NULL check.
 428
 429 2019-06-25  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 432         Inline constructor.  Add initializers for members.
 433         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 434         constructors; now inline in class.
 435
 436 2019-06-25  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-regs.c (tui_show_registers): Update.
 439         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 440         bool.
 441         * tui/tui-data.c (tui_data_window::clear_detail)
 442         (tui_data_window): Update.
 443
 444 2019-06-25  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-windata.c (tui_display_all_data)
 447         (tui_display_data_from_line, tui_display_data_from)
 448         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 449         Update.
 450         * tui/tui-regs.c (tui_last_regs_line_no)
 451         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 452         (tui_show_registers, tui_show_register_group)
 453         (tui_display_registers_from, tui_display_reg_element_at_line)
 454         (tui_display_registers_from_line, tui_check_register_values)
 455         (tui_reg_next, tui_reg_prev): Update.
 456         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 457         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 458         tui_data_window.
 459         (struct tui_win_info) <detail>: Remove.  Add new fields from
 460         tui_data_info.
 461         (TUI_DATA_WIN): Add cast.
 462         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 463         (~tui_data_window): Simplify.
 464
 465 2019-06-25  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-layout.c (show_source_disasm_command)
 468         (show_source_or_disasm_and_command): Update.
 469         * tui/tui-io.c (update_cmdwin_start_line)
 470         (tui_redisplay_readline): Update.
 471         * tui/tui-data.h (struct tui_command_info): Remove.
 472         (struct tui_win_info) <detail>: Remove command_info member.
 473         (struct tui_data_window) <start_line>: New member, from
 474         tui_command_info.
 475         (TUI_CMD_WIN): Add casts.
 476
 477 2019-06-25  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-winsource.c (tui_update_source_window)
 480         (tui_refill_source_window)
 481         (tui_source_window_base::do_scroll_horizontal)
 482         (tui_update_breakpoint_info, tui_set_exec_info_content)
 483         (tui_show_exec_info_content, tui_erase_exec_info_content)
 484         (tui_clear_exec_info_content): Update.
 485         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 486         Update.
 487         * tui/tui-win.c (make_invisible_and_set_new_height)
 488         (make_visible_with_new_height): Update.
 489         * tui/tui-source.c (tui_set_source_content)
 490         (tui_show_symtab_source): Update.
 491         * tui/tui-layout.c (extract_display_start_addr)
 492         (show_source_disasm_command, show_data)
 493         (make_source_or_disasm_window)
 494         (show_source_or_disasm_and_command): Update.
 495         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 496         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 497         "gdbarch".
 498         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 499         to tui_source_window_base.
 500         (struct tui_win_info) <detail>: Remove source_info member.
 501         (struct tui_source_window_base) <has_locator>: Inline.
 502         Move contents from tui_source_info; rename has_locator member to
 503         m_has_locator.
 504         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 505         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 506         header file.
 507         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 508         Simplify.
 509         (tui_free_all_source_wins_content): Cast to
 510         tui_source_window_base.
 511
 512 2019-06-25  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-win.c (make_invisible_and_set_new_height)
 515         (make_visible_with_new_height): Call has_locator method.
 516         * tui/tui-layout.c (show_source_disasm_command, show_data)
 517         (show_source_or_disasm_and_command): Update for bool change.
 518         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 519         (tui_win_info) <has_locator>: New method.
 520         (struct tui_source_window_base) <has_locator>: New method.
 521         (tui_win_has_locator): Don't declare.
 522         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 523         from tui_win_has_locator.
 524         (tui_source_window_base): Use false, not FALSE.
 525
 526 2019-06-25  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 529         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 530         clear_detail method directly.
 531         (tui_clear_win_detail): Remove.
 532
 533 2019-06-25  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 536         "this", not TUI_DISASM_WIN.
 537
 538 2019-06-25  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 541         declare.
 542         * tui/tui-winsource.c
 543         (tui_source_window_base::do_scroll_horizontal): Rename from
 544         tui_horizontal_source_scroll.
 545         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 546         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 547         from tui_vertical_data_scroll.
 548         * tui/tui-win.h (tui_scroll): Don't declare.
 549         * tui/tui-win.c (tui_win_info::forward_scroll)
 550         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 551         (tui_win_info::right_scroll): Rename and update.
 552         (tui_scroll_forward_command, tui_scroll_backward_command)
 553         (tui_scroll_left_command, tui_scroll_right_command): Update.
 554         (tui_scroll): Remove.
 555         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 556         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 557         from tui_vertical_source_scroll.
 558         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 559         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 560         from tui_vertical_disassem_scroll.
 561         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 562         do_scroll_horizontal>: New methods.
 563         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 564         Likewise.
 565         (struct tui_source_window_base): Add do_scroll_horizontal.
 566         (struct tui_source_window, struct tui_disasm_window): Add
 567         do_scroll_vertical.
 568         (struct tui_data_window, struct tui_cmd_window): Add
 569         do_scroll_horizontal and do_scroll_vertical.
 570         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 571
 572 2019-06-25  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-data.h (struct tui_source_window_base): New struct.
 575         (struct tui_source_window): Derive from tui_source_window_base.
 576         (struct tui_disasm_window): New struct.
 577         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 578         from tui_source_window::clear_detail.
 579         (tui_source_window_base): Rename from tui_source_window.
 580         (~tui_source_window_base): Rename from ~tui_source_window.
 581         (tui_alloc_win_info): Create a tui_disasm_window.
 582
 583 2019-06-25  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-data.h (struct tui_source_window)
 586         (struct tui_data_window): Declare destructors.
 587         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 588         destructors.
 589         (tui_win_info): Simplify.
 590
 591 2019-06-25  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-winsource.c (tui_display_main)
 594         (tui_update_source_windows_with_addr)
 595         (tui_update_all_breakpoint_info): Update.
 596         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 597         (new_height_ok, parse_scrolling_args): Update.
 598         * tui/tui-stack.c (tui_show_frame_info): Update.
 599         * tui/tui-data.h (struct tui_list): Remove.
 600         (tui_source_windows): Return a reference to a std::vector.
 601         * tui/tui-data.c (source_windows): Now a std::vector.
 602         (tui_source_windows): Change return type.
 603         (tui_clear_source_windows): Rewrite.
 604         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 605         (tui_free_all_source_wins_content): Rewrite.
 606
 607 2019-06-25  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 610         (struct tui_data_window, struct tui_cmd_window): Declare
 611         clear_detail method.
 612         * tui/tui-data.c (tui_source_window::clear_detail)
 613         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 614         methods.
 615         (tui_clear_win_detail): Simplify.
 616
 617 2019-06-25  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-layout.c (make_source_window, make_disasm_window)
 620         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 621         Return the new window.
 622         (show_source_disasm_command, show_data)
 623         (show_source_or_disasm_and_command): Update.
 624
 625 2019-06-25  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 628         parameter.  Return the new window.
 629         (show_source_disasm_command): Update and remove NULL check.
 630         (show_source_or_disasm_and_command): Update.
 631
 632 2019-06-25  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 635
 636 2019-06-25  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-data.h (struct tui_win_info): Make constructor
 639         protected.  Make destructor virtual.  Add initializers.
 640         (tui_source_window, tui_data_window, tui_cmd_window): New
 641         classes.
 642         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 643         constructor.  Add "type" parameter.
 644         (tui_source_window, tui_data_window, tui_cmd_window): New
 645         constructors.
 646         (tui_alloc_win_info): Instantiate the appropriate subclass.
 647
 648 2019-06-25  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-win.c (tui_resize_all): Use delete.
 651         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 652         destructor.
 653         (tui_free_window): Don't declare.
 654         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 655         Update.
 656
 657 2019-06-25  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-data.h (struct tui_win_info): Add constructor.
 660         * tui/tui-data.c (tui_alloc_win_info): Use new.
 661         (tui_free_window): Use delete.
 662
 663 2019-06-22  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 666         declare.
 667         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 668
 669 2019-06-22  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 672         declare.
 673         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 674
 675 2019-06-22  Tom de Vries  <tdevries@suse.de>
 676
 677         * dwarf2read.c (create_addrmap_from_aranges)
 678         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 679         instead of '%zu'.
 680
 681 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 682
 683         * dwarf2read.h (dwarf2_section_info_def): Remove.
 684         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 685         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 686         std::vector<dwarf2_section_info>.
 687         (struct dwo_file) <~dwo_file>: Remove.
 688         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 689         types field.
 690         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 691         (dwarf2_read_debug_names): Likewise.
 692         (create_debug_types_hash_table): Change parameter type to
 693         array_view, adjust code accordingly.
 694         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 695         (partial_die_info::fixup): Likewise.
 696         (determine_prefix): Likewise.
 697         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 698
 699 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 700
 701         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 702         gdb_bfd_ref_ptr.
 703         <~dwo_file>: Remove call to gdb_bfd_unref.
 704         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 705         gdb_bfd_ref_ptr::get.
 706
 707 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 708
 709         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 710         type to htab_up.
 711         * dwarf2read.c (struct dwo_file): Initialize fields.
 712         <~dwo_file>: New.
 713         (free_dwo_file): Remove, move content to ~dwo_file.
 714         (struct dwo_file_deleter): Remove.
 715         (dwo_file_up>: Remove custom deleter.
 716         (free_dwo_files): Remove.
 717         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 718         dwo_files.
 719         (process_skeletonless_type_units): Call unique_ptr::get.
 720         (allocate_dwo_file_hash_table): Add deleter to created hash
 721         table.  Change return type to htab_up.
 722         (lookup_dwo_file_slot): Don't memset dwo_file, call
 723         unique_ptr::get.
 724         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 725         (create_dwo_unit_in_dwp_v2): Likewise.
 726         (open_and_init_dwo_file): Likewise.
 727         (free_dwo_file_from_slot): Remove.
 728
 729 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 730
 731         * dwarf2read.h (struct dwarf2_section_info) <readin,
 732         is_virtual>: Change type to bool.
 733         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 734         true instead of 1.
 735
 736 2019-06-19  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-data.h (tui_init_content_element): Don't declare.
 739
 740 2019-06-19  Tom Tromey  <tom@tromey.com>
 741
 742         * tui/tui-data.h (tui_init_win_info): Don't declare.
 743
 744 2019-06-19  Tom de Vries  <tdevries@suse.de>
 745
 746         * dwarf2read.h (abstract_to_concrete): Change type to
 747         std::unordered_map<sect_offset, std::vector<sect_offset>,
 748         gdb::hash_enum<sect_offset>>.
 749
 750 2019-06-19  Tom Tromey  <tromey@adacore.com>
 751
 752         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 753         EVAL_AVOID_SIDE_EFFECTS specially.
 754
 755 2019-06-19  Tom Tromey  <tromey@adacore.com>
 756
 757         * source-cache.c (highlighter): New global.
 758         (source_cache::get_source_lines): Create a highlighter on demand.
 759
 760 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 761
 762         * defs.h (deprecated_interactive_hook): Delete declaration.
 763         * interps.c (clear_interpreter_hooks): Remove use of
 764         deprecated_interactive_hook.
 765         * top.c (deprecated_interactive_hook): Delete definition.
 766         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 767
 768 2019-06-18  Tom de Vries  <tdevries@suse.de>
 769
 770         PR gdb/24515
 771         * dwarf2read.h (abstract_to_concrete): Change type from
 772         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 773         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 774         * dwarf2read.c (read_variable): Update.
 775         (dwarf2_fetch_die_loc_sect_off): Update.
 776
 777 2019-06-17  Tom de Vries  <tdevries@suse.de>
 778
 779         PR gdb/24617
 780         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 781         accessing parent[parent_len - 1].
 782
 783 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 784
 785         PR gdb/24364
 786         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 787         call dtrace_process_dof with NULL dof.
 788
 789 2019-06-16  Tom de Vries  <tdevries@suse.de>
 790
 791         PR gdb/24445
 792         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 793
 794 2019-06-16  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 797         (make_all_visible): Use address of member.
 798
 799 2019-06-16  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 802         (tui_free_window, free_content, free_content_elements): Remove
 803         unnecessary cast.
 804         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 805         cast.
 806         * tui/tui-regs.c (tui_show_register_group)
 807         (tui_display_registers_from, tui_display_reg_element_at_line):
 808         Remove unnecessary cast.
 809
 810 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * linux-nat.c (normal_mask): Delete.
 813         (_initialize_linux_nat): Don't initialise normal_mask.
 814
 815 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 816
 817         PR gdb/24445
 818         * dwarf-index-write.h (write_psymtabs_to_index): Add
 819         dwz_basename parameter.
 820         * dwarf-index-write.c (write_gdbindex): Move file writing to
 821         write_gdbindex_1.  Change return type void.
 822         (assert_file_size): Move up, remove filename parameter.
 823         (write_gdbindex_1): New function.
 824         (write_debug_names): Change return type to void, call
 825         assert_file_size.
 826         (struct index_wip_file): New struct.
 827         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 828         file logic to index_wip_file.  Write index for dwz file if
 829         needed.
 830         (save_gdb_index_command): Pass basename of dwz file, if present.
 831         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 832         build-id of dwz file, if present.
 833         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 834         (dwarf2_get_dwz_file): Likewise.
 835         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 836         (dwarf2_get_dwz_file): Likewise.
 837
 838 2019-06-16  Tom Tromey  <tom@tromey.com>
 839
 840         * coffread.c (process_coff_symbol): Use xstrdup.
 841         * value.c (create_internalvar): Use xstrdup.
 842
 843 2019-06-16  Tom Tromey  <tom@tromey.com>
 844
 845         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 846         * breakpoint.c (stopin_command, stopat_command)
 847         (until_break_command, decode_location_default): Remove unnecessary
 848         cast.
 849         * utils.c (subset_compare): Remove unnecessary cast.
 850         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 851         cast.
 852         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 853         cast.
 854         * infcmd.c (path_command): Remove unnecessary cast.
 855         * coffread.c (decode_type): Remove unnecessary cast.
 856         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 857         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 858         * tui/tui-stack.c (tui_show_locator_content)
 859         (tui_show_frame_info): Remove unnecessary cast.
 860         * tui/tui-win.c (tui_scroll_forward_command)
 861         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 862         (parse_scrolling_args): Remove unnecessary cast.
 863         * tui/tui-data.c (init_win_info, tui_del_window)
 864         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 865         (free_content_elements): Remove unnecessary cast.
 866         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 867         unnecessary cast.
 868         * tui/tui-source.c (tui_set_source_content)
 869         (tui_vertical_source_scroll): Remove unnecessary cast.
 870         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 871         cast.
 872         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 873         * tui/tui-regs.c (tui_display_registers_from)
 874         (tui_display_register): Remove unnecessary cast.
 875         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 876         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 877         (make_visible): Remove unnecessary cast.
 878         * tui/tui-winsource.c (tui_erase_source_content)
 879         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 880         unnecessary cast.
 881         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 882         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 883         * stabsread.c (read_type, read_array_type, read_range_type):
 884         Remove unnecessary cast.
 885         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 886         (parse_symbol, parse_type, upgrade_type, parse_external)
 887         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 888         unnecessary cast.
 889         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 890
 891 2019-06-16  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-data.c (tui_alloc_generic_win_info)
 894         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 895         checks.
 896
 897 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 898             Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * f-typeprint.c (f_print_type): Don't return early for not
 901         associated or not allocated types.
 902         (f_type_print_varspec_suffix): Add print_rank parameter and print
 903         ranks of array types in case they dangling.
 904         (f_type_print_base): Add print_rank parameter.
 905
 906 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 907
 908         * NEWS: Mention new MI commands.
 909         * break-catch-throw.c (enum exception_event_kind): Move to
 910         breakpoint.h.
 911         (print_mention_exception_catchpoint): Output text as a single
 912         message.
 913         (catch_exception_command_1): Rename to...
 914         (catch_exception_event): ...this, make non-static, update header
 915         command, and change some parameter types.
 916         (catch_catch_command): Update for changes to
 917         catch_exception_command_1.
 918         (catch_throw_command): Likewise.
 919         (catch_rethrow_command): Likewise.
 920         * breakpoint.c (enum exception_event_kind): Delete.
 921         * breakpoint.h (enum exception_event_kind): Moved here from
 922         break-catch-throw.c.
 923         (catch_exception_event): Declare.
 924         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 925         (mi_cmd_catch_throw): New function.
 926         (mi_cmd_catch_rethrow): New function.
 927         (mi_cmd_catch_catch): New function.
 928         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 929         'catch-catch' entries.
 930         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 931         (mi_cmd_catch_rethrow): Declare.
 932         (mi_cmd_catch_catch): Declare.
 933
 934 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * annotate.c (annotate_source_line): Change return type to void,
 937         update implementation to match.
 938         * annotate.h (annotate_source_line): Change return type to void,
 939         update header comment.
 940         * stack.c (print_frame_info): Don't change what frame information
 941         is printed based on whether annotations are on or not.
 942
 943 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 946         (annotate_source): Make static.
 947         (annotate_source_line): Moved from source.c and renamed from
 948         identify_source_line.  Update the return type.
 949         * annotate.h (annotate_source): Delete declaration.
 950         (annotate_source_line): Declaration moved from source.h, and
 951         renamed from identify_source_line.  Return type updated.
 952         * source.c (identify_source_line): Moved to annotate.c and renamed
 953         to annotate_source_line.
 954         (info_line_command): Remove check of annotation_level.
 955         * source.h (identify_source_line): Move declaration to annotate.h
 956         and rename to annotate_source_line.
 957         * stack.c: Add 'annotate.h' include.
 958         (print_frame_info): Remove check of annotation_level before
 959         calling annotate_source_line.
 960
 961 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 962
 963         * source-cache.c (source_cache::get_plain_source_lines): Use
 964         open_source_file_with_line_charpos instead of just
 965         open_source_file, remove call to find_source_lines.
 966         (source_cache::get_source_lines): Likewise.
 967         * source.c (find_source_lines): Make static.
 968         (get_filename_and_charpos): Renamed into...
 969         (open_source_file_with_line_charpos): ..this along with changes to
 970         return a scoped_fd, and some other minor clean ups.
 971         (identify_source_line): Use open_source_file_with_line_charpos.
 972         (search_command_helper): Use open_source_file_with_line_charpos
 973         instead of just open_source_file, remove call to
 974         find_source_lines.
 975         * source.h (open_source_file_with_line_charpos): Declare new
 976         function.
 977         (find_source_lines): Delete declaration.
 978
 979 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * source.c (get_filename_and_charpos): Remove fullname
 982         parameter.
 983         (identify_source_line): Update call to get_filename_and_charpos.
 984
 985 2019-06-14  Tom Tromey  <tromey@adacore.com>
 986
 987         PR gdb/24502:
 988         * ui-style.h (skip_ansi_escape): Update comment.
 989         * ui-file.h (class no_terminal_escape_file): New class.
 990         * ui-file.c (no_terminal_escape_file::write)
 991         (no_terminal_escape_file::puts): New methods.
 992         * cli/cli-logging.c (handle_redirections): Use
 993         no_terminal_escape_file.
 994
 995 2019-06-14  Tom Tromey  <tromey@adacore.com>
 996
 997         * NEWS: Move convenience variable news above Python news.
 998
 999 2019-06-14  Tom Tromey  <tom@tromey.com>
1000
1001         * gnulib: Move directory to top-level.
1002         * configure.ac: Don't configure gnulib.
1003         * configure: Rebuild.
1004         * common/common-defs.h: Use new path to gnulib.
1005         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1006         (GNULIB_H): Remove.
1007         (INCGNU): Look in new gnulib location.
1008         (HFILES_NO_SRCDIR): Remove gnulib files.
1009         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1010         (generated_files): Remove GNULIB_H.
1011         ($(LIBGNU), all-lib): Remove targets.
1012         (distclean): Don't mention GNULIB_BUILDDIR.
1013         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1014
1015 2019-06-14  Tom Tromey  <tromey@adacore.com>
1016
1017         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1018         Warn if symbol file does not provide any symbols.
1019
1020 2019-06-14  Tom Tromey  <tromey@adacore.com>
1021
1022         * source.c (find_and_open_source): Respect basenames_may_differ.
1023
1024 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * annotate.c (annotate_breakpoints_invalid): Make use of
1027         scoped_restore_terminal_state.
1028         (annotate_frames_invalid): Likewise.
1029
1030 2019-06-14  Tom Tromey  <tromey@adacore.com>
1031
1032         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1033         allow assignment to an internalvar.
1034
1035 2019-06-14  Tom Tromey  <tromey@adacore.com>
1036
1037         * ada-lex.l: Allow "_" in attribute names.
1038
1039 2019-06-14  Tom Tromey  <tromey@adacore.com>
1040
1041         PR gdb/24653:
1042         * regcache.c (registers_changed): Don't call alloca.
1043         * top.c (execute_command): Don't call alloca.
1044
1045 2019-06-13  Pedro Alves  <palves@redhat.com>
1046
1047         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1048         'expression'.  When parsing an expression, error out if there's
1049         junk after "unlimited".
1050         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1051         (do_set_command): Adjust calls to is_unlimited_literal.
1052
1053 2019-06-13  Pedro Alves  <palves@redhat.com>
1054
1055         * compile/compile.c (make_compile_options_def_group): Add braces
1056         around array_view initializer.
1057         * thread.c (make_thread_apply_all_options_def_group)
1058         (make_thread_apply_all_options_def_group): Likewise.
1059
1060 2019-06-13  Pedro Alves  <palves@redhat.com>
1061
1062         * NEWS (New commands): Mention "maint test-options
1063         require-delimiter", "maint test-options unknown-is-error", "maint
1064         test-options unknown-is-operand" and "maint show
1065         test-options-completion-result".
1066         (New command options, command completion): New section.
1067         (Completion improvements): New section.
1068         Mention that you can abbreviate "unlimited".
1069
1070 2019-06-13  Pedro Alves  <palves@redhat.com>
1071
1072         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1073         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1074         * unittests/cli-utils-selftests.c (test_parse_flags)
1075         (test_parse_flags_qcs): Delete.
1076         (test_cli_utils): Don't call deleted functions.
1077
1078 2019-06-13  Pedro Alves  <palves@redhat.com>
1079
1080         * thread.c: Include "cli/cli-option.h".
1081         (tp_array_compar_ascending): Global.
1082         (tp_array_compar): Delete function.
1083         (tp_array_compar_ascending, tp_array_compar_descending): New
1084         functions.
1085         (ascending_option_def, qcs_flag_option_def)
1086         (thr_qcs_flags_option_defs)
1087         (make_thread_apply_all_options_def_group)
1088         (make_thread_apply_options_def_group): New.
1089         (thread_apply_all_command): Use gdb::option::process_options.
1090         (thread_apply_command_completer)
1091         (thread_apply_all_command_completer): New.
1092         (thread_apply_command): Use gdb::option::process_options.
1093         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1094         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1095         to generate help text of "thread apply".  Adjust "taas"'s help.
1096         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1097         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1098
1099 2019-06-13  Pedro Alves  <palves@redhat.com>
1100
1101         * thread.c (thread_apply_command): Check for invalid TID with
1102         isdigit instead of !isalpha.
1103
1104 2019-06-13  Pedro Alves  <palves@redhat.com>
1105
1106         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1107         (validate_flags_qcs): New.
1108         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1109         (validate_flags_qcs): Declare.
1110         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1111         (make_frame_apply_options_def_group): New.
1112         (frame_apply_command_count): Process options with
1113         gdb::option::process_options.
1114         (frame_apply_completer): New.
1115         (frame_apply_level_completer, frame_apply_all_completer)
1116         (frame_apply_completer): New.
1117         (_initialize_stack): Update help of "frame apply", "frame apply
1118         level", "frame apply all" and "faas" to mention supported options
1119         and install command completers.
1120         * stack.h (frame_apply_all_completer): Declare.
1121         * thread.c: Include "stack.h".
1122         (tfaas_command): Add "--".
1123         (_initialize_thread): Update help "tfaas" to mention supported
1124         options and install command completer.
1125
1126 2019-06-13  Pedro Alves  <palves@redhat.com>
1127
1128         * completer.c (complete_nested_command_line): New.
1129         (gdb_completion_word_break_characters_throw): Add assertion.
1130         * completer.h (complete_nested_command_line): Declare.
1131
1132 2019-06-13  Pedro Alves  <palves@redhat.com>
1133
1134         * stack.c (parse_backtrace_qualifiers): New.
1135         (backtrace_command): Use it.
1136         (backtrace_command_completer): Complete on qualifiers.
1137
1138 2019-06-13  Pedro Alves  <palves@redhat.com>
1139
1140         * frame.c: Include "cli/cli-option.h.
1141         (user_set_backtrace_options): New.
1142         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1143         Delete.
1144         (get_prev_frame): Adjust.
1145         (boolean_option_def, uinteger_option_def)
1146         (set_backtrace_option_defs): New.
1147         (_initialize_frame): Adjust and use
1148         gdb::option::add_setshow_cmds_for_options to install "set
1149         backtrace past-main" and "set backtrace past-entry".
1150         * frame.h: Include "cli/cli-option.h".
1151         (struct frame_print_options): Forward declare.
1152         (print_frame_arguments_all, print_frame_arguments_scalars)
1153         (print_frame_arguments_none): Declare.
1154         (print_entry_values): Delete declaration.
1155         (struct frame_print_options, user_frame_print_options): New.
1156         (struct set_backtrace_options): New.
1157         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1158         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1159         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1160         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1161         (list_args_or_locals): Add frame_print_options parameter.
1162         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1163         * python/py-framefilter.c (enumerate_args): Pass down
1164         USER_FRAME_PRINT_OPTIONS.
1165         * stack.c: Include "cli/cli-option.h".
1166         (print_frame_arguments_all, print_frame_arguments_scalars)
1167         (print_frame_arguments_none): Declare.
1168         (print_raw_frame_arguments, print_entry_values): Delete.
1169         (user_frame_print_options): New.
1170         (boolean_option_def, enum_option_def, frame_print_option_defs):
1171         New.
1172         (struct backtrace_cmd_options): New.
1173         (bt_flag_option_def): New.
1174         (backtrace_command_option_defs): New.
1175         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1176         (print_frame_arg, read_frame_arg, print_frame_args)
1177         (print_frame_info, print_frame): Add frame_print_options parameter
1178         and use it.
1179         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1180         (backtrace_command_1): Add frame_print_options and
1181         backtrace_cmd_options parameters and use them.
1182         (make_backtrace_options_def_group): New.
1183         (backtrace_command): Process command options with
1184         gdb::option::process_options.
1185         (backtrace_command_completer): New.
1186         (_initialize_stack): Extend "backtrace"'s help to mention
1187         supported options.  Install completer for "backtrace".
1188         Install some settings commands with add_setshow_cmds_for_options.
1189
1190 2019-06-13  Pedro Alves  <palves@redhat.com>
1191
1192         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1193         and that "set/show print raw frame-arguments" are now deprecated.
1194
1195         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1196         command.
1197         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1198         * stack.c (_initialize_stack): Install "set/show print
1199         raw-frame-arguments", and deprecate "set/show print raw
1200         frame-arguments".
1201         * valprint.c (_initialize_valprint): Deprecate "set/show print
1202         raw".
1203
1204 2019-06-13  Pedro Alves  <palves@redhat.com>
1205
1206         * compile/compile.c (struct compile_options): New.
1207         (compile_flag_option_def, compile_command_option_defs)
1208         (make_compile_options_def_group): New.
1209         (compile_file_command): Handle options with
1210         gdb::option::process_options.
1211         (compile_file_command_completer): New function.
1212         (compile_code_command): Handle options with
1213         gdb::option::process_options.
1214         (compile_code_command_completer): New function.
1215         (_initialize_compiler): Install completers for "compile code" and
1216         "compile file".  Mention available options in "compile code" and
1217         "compile code"'s help.
1218         * completer.c (advance_to_completion_word): New, factored out from
1219         ...
1220         (advance_to_expression_complete_word_point): ... this.
1221         (advance_to_filename_complete_word_point): New.
1222         * completer.h (advance_to_filename_complete_word_point): New
1223         declaration.
1224
1225 2019-06-13  Pedro Alves  <palves@redhat.com>
1226
1227         * compile/compile.c: Include "cli/cli-option.h".
1228         (compile_print_value): Scope data pointer is now a
1229         value_print_options pointer; adjust.
1230         (compile_print_command): Process options.  Scope data pointer is
1231         now a value_print_options pointer; adjust.
1232         (_initialize_compile): Update "compile print"'s help to include
1233         supported options.  Install a completer for "compile print".
1234         * cp-valprint.c (show_vtblprint, show_objectprint)
1235         (show_static_field_print): Delete.
1236         (_initialize_cp_valprint): Don't install "set print
1237         static-members", "set print vtbl", "set print object" here.
1238         * printcmd.c: Include "cli/cli-option.h" and
1239         "common/gdb_optional.h".
1240         (print_command_parse_format): Rework to fill in a
1241         value_print_options instead of a format_data.
1242         (print_value): Change parameter type from format_data pointer to
1243         value_print_options reference.  Adjust.
1244         (print_command_1): Process options.  Adjust to pass down a
1245         value_print_options.
1246         (print_command_completer): New.
1247         (_initialize_printcmd): Install print_command_completer as
1248         handle_brkchars completer for the "print" command.  Update
1249         "print"'s help to include supported options.
1250         * valprint.c: Include "cli/cli-option.h".
1251         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1252         here from cp-valprint.c.
1253         (boolean_option_def, uinteger_option_def)
1254         (value_print_option_defs, make_value_print_options_def_group):
1255         New.  Use gdb::option::add_setshow_cmds_for_options to install
1256         "set print elements", "set print null-stop", "set print repeats",
1257         "set print pretty", "set print union", "set print array", "set
1258         print address", "set print symbol", "set print array-indexes".
1259         * valprint.h: Include <string> and "cli/cli-option.h".
1260         (make_value_print_options_def_group): Declare.
1261         (print_value): Change parameter type from format_data pointer to
1262         value_print_options reference.
1263         (print_command_completer): Declare.
1264
1265 2019-06-13  Pedro Alves  <palves@redhat.com>
1266
1267         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1268         (COMMON_SFILES): Add maint-test-settings.c.
1269         * cli/cli-decode.c (boolean_enums): New global, factored out from
1270         ...
1271         (add_setshow_boolean_cmd): ... here.
1272         * cli/cli-decode.h (boolean_enums): Declare.
1273         * cli/cli-option.c: New file.
1274         * cli/cli-option.h: New file.
1275         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1276         factored out from ...
1277         (parse_cli_boolean_value(const char *)): ... this.
1278         (is_unlimited_literal): Change parameter type to pointer to
1279         pointer.  Adjust and advance ARG pointer.
1280         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1281         (parse_cli_var_enum): New, factored out from ...
1282         (do_set_command): ... this.  Adjust.
1283         * cli/cli-setshow.h (parse_cli_boolean_value)
1284         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1285         (parse_cli_var_enum): Declare.
1286         * cli/cli-utils.c: Include "cli/cli-option.h".
1287         (get_ulongest): New.
1288         * cli/cli-utils.h (get_ulongest): Declare.
1289         (check_for_argument): New overloads.
1290         * maint-test-options.c: New file.
1291
1292 2019-06-13  Pedro Alves  <palves@redhat.com>
1293
1294         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1295         parse a range if "-" is at the end of the string.
1296
1297 2019-06-13  Pedro Alves  <palves@redhat.com>
1298
1299         * cli/cli-setshow.c (parse_auto_binary_operation)
1300         (parse_cli_boolean_value): Don't allow "o".
1301
1302 2019-06-13  Pedro Alves  <palves@redhat.com>
1303
1304         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1305         * NEWS: Mention maint test-settings KIND.
1306         * maint-test-settings.c: New file.
1307
1308 2019-06-13  Pedro Alves  <palves@redhat.com>
1309
1310         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1311         completer.
1312         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1313         "set" completers.
1314
1315 2019-06-13  Pedro Alves  <palves@redhat.com>
1316
1317         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1318         after item.
1319
1320 2019-06-13  Pedro Alves  <palves@redhat.com>
1321
1322         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1323
1324 2019-06-13  Pedro Alves <palves@redhat.com>
1325
1326         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1327         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1328         call.
1329         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1330         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1331         calls.
1332         (check_for_argument): Skip spaces after argument.
1333
1334 2019-06-13  Pedro Alves  <palves@redhat.com>
1335
1336         * thread.c (thread_apply_command): Adjust TID parsing.
1337         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1338         detected before end of string.
1339         (tid_is_in_list): Error out if LIST is invalid.
1340
1341 2019-06-13  Pedro Alves  <palves@redhat.com>
1342
1343         * completer.c (complete_line_internal_1): Rewind completion word
1344         point.
1345         (completion_tracker::advance_custom_word_point_by): Change
1346         parameter type to int.
1347         * completer.h (completion_tracker::advance_custom_word_point_by):
1348         Likewise.
1349
1350 2019-06-13  Pedro Alves  <palves@redhat.com>
1351
1352         * completer.c (advance_to_completion_word): Handle delimiters.
1353
1354 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1355
1356         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1357
1358 2019-06-11  Tom Tromey  <tom@tromey.com>
1359
1360         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1361         (xmalloc_failed): Move to alloc.c.
1362         * alloc.c: New file.
1363         * Makefile.in (COMMON_SFILES): Add alloc.c.
1364
1365 2019-06-11  Tom Tromey  <tom@tromey.com>
1366
1367         * nat/linux-waitpid.c: Don't include server.h.
1368         (linux_debug): Remove.
1369         (my_waitpid): Update.
1370
1371 2019-06-11  Tom Tromey  <tromey@adacore.com>
1372
1373         * infcall.c (_initialize_infcall): Remove trailing newline from
1374         help.
1375         * user-regs.c (_initialize_user_regs): Remove trailing newline
1376         from help.
1377         * typeprint.c (_initialize_typeprint): Remove trailing newline
1378         from help.
1379         * reverse.c (_initialize_reverse): Remove trailing newlines from
1380         help.
1381         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1382         from help.
1383         * language.c (add_set_language_command): Remove trailing newline
1384         from help.
1385         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1386         help.
1387         * disasm.c (_initialize_disasm): Remove trailing newline from
1388         help.
1389         * top.c (init_main): Remove trailing newline from help.
1390         * interps.c (_initialize_interpreter): Remove trailing newline
1391         from help.
1392         * btrace.c (_initialize_btrace): Remove trailing newlines from
1393         help.
1394         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1395         from help.
1396         * python/python.c (_initialize_python): Remove trailing newline
1397         from help.
1398         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1399         help.
1400         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1401         from help.  Reformat some text.
1402         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1403         from help.
1404         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1405         newline from help.
1406
1407 2019-06-11  Tom Tromey  <tromey@adacore.com>
1408
1409         * darwin-nat.c (darwin_decode_exception_message)
1410         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1411
1412 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * valops.c (value_slice): Check for not allocated or not
1415         associated values.
1416
1417 2019-06-10  Tom de Vries  <tdevries@suse.de>
1418
1419         PR gdb/24618
1420         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1421         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1422         invalid.
1423
1424 2019-06-10  Tom de Vries  <tdevries@suse.de>
1425
1426         PR gdb/24611
1427         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1428         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1429
1430 2019-06-10  Tom de Vries  <tdevries@suse.de>
1431
1432         PR symtab/24545
1433         * symtab.c (struct demangled_name_entry): Add language field.
1434         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1435         static minimal symbol".  Set and use language field.
1436
1437 2019-06-10  Tom Tromey  <tromey@adacore.com>
1438
1439         * ada-lang.c (_initialize_ada_language): Update help text.
1440
1441 2019-06-10  Tom Tromey  <tromey@adacore.com>
1442
1443         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1444         with a newline.
1445         * guile/guile.c (handle_boot_error): Don't end warning with a
1446         newline.
1447         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1448         warning with a newline.
1449         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1450         newline.
1451         (s12z_frame_cache): Likewise.
1452         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1453         a newline.
1454         * solib-svr4.c (disable_probes_interface): Don't end warning with
1455         a newline.
1456         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1457         newline.
1458         * python/python.c (do_finish_initialization): Don't end warning
1459         with a newline.
1460
1461 2019-06-10  Tom Tromey  <tom@tromey.com>
1462
1463         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1464         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1465         gdbpy_enter.
1466
1467 2019-06-10  Tom Tromey  <tromey@adacore.com>
1468
1469         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1470         data.
1471         (elf_new_init): Don't call stabsread_new_init.
1472         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1473         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1474         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1475
1476 2019-06-10  Tom de Vries  <tdevries@suse.de>
1477
1478         PR symtab/16264
1479         PR symtab/24517
1480         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1481
1482 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1483
1484         * source.c (find_and_open_source): Also rewrite relative file
1485         names.
1486
1487 2019-04-26  Amos Bird  <amosbird@gmail.com>
1488
1489         * annotate.c (annotate_thread_exited): Add "thread-exited"
1490         annotation.
1491
1492 2019-06-06  Tom Tromey  <tromey@adacore.com>
1493
1494         * maint.h (class scoped_command_stats): Use
1495         DISABLE_COPY_AND_ASSIGN.
1496         <print_time>: New method.
1497         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1498         print_time.
1499         (scoped_command_stats::print_time): New method.
1500
1501 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1504         instructions of lengths 6 or 8 bytes.
1505
1506 2019-06-04  Pedro Alves  <palves@redhat.com>
1507
1508         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1509
1510         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1511         * breakpoint.c (condition_completer): Likewise.
1512         * cli/cli-dump.c (scan_expression): Likewise.
1513         * common/filestuff.c (mkdir_recursive): Likewise.
1514         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1515         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1516         (gdb_abspath): Likewise.
1517         * compile/compile-cplus-types.c
1518         (compile_cplus_instance::decl_name): Likewise.
1519         * completer.c (complete_explicit_location):
1520         (signal_completer, reg_or_group_completer_1): Likewise.
1521         * cp-support.c (cp_remove_params_if_any): Likewise.
1522         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1523         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1524         * infcmd.c (strip_bg_char): Likewise.
1525         * linespec.c (copy_token_string): Likewise.
1526         * mi/mi-main.c (output_cores): Likewise.
1527         * psymtab.c (psymtab_search_name):
1528         * symfile.c (test_set_ext_lang_command): Likewise.
1529         * target.c (target_fileio_read_stralloc): Likewise.
1530         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1531         * value.c (complete_internalvar): Likewise.
1532
1533 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1534
1535         Add objfile property to gdb.Type.
1536         * NEWS: Mention Python API addition.
1537         * python/py-type.c (typy_get_objfile): New method.
1538
1539 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1540
1541         * NEWS: Mention the new set|show style [title|highlight].
1542         Mention changes to "show style", "help" and "apropos".
1543
1544 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1545
1546         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1547         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1548         instead of print_help_for_command.
1549         (print_doc_of_command): New function.
1550         (help_list): Add 'apropos -v word' suggestion.
1551         (print_help_for_command): Style the command name using title style.
1552         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1553         (_initialize_cli_cmds): Describe -v in apropos_command help.
1554
1555 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1556
1557         * cli/cli-style.h (cli_style_option): Add name in constructor,
1558         add m_name class member, add constructor with intensity,
1559         add name class function.
1560         (cli_style_option::add_setshow_commands): Remove name argument.
1561         (highlight_style, title_style): New styles.
1562         * cli/cli-style.c (do_show): New function that shows a style
1563         characteristic styling the style name with itself.
1564         (set_style_name): New function.
1565         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1566         Update all callers according to the changes in cli/cli-style.h.
1567         * utils.h (fputs_highlighted): New function.
1568         * utils.c (fputs_highlighted): Likewise.
1569
1570 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1571
1572         * NEWS: Mention new pipe command and new convenience variables.
1573
1574 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1575
1576         * cli/cli-cmds.c (pipe_command): New function.
1577         (_initialize_cli_cmds): Call add_com for pipe_command.
1578         Define | as an alias for pipe.
1579         (exit_status_set_internal_vars): New function.
1580         (shell_escape): Call exit_status_set_internal_vars.
1581         cli/cli-decode.c (find_command_name_length): Recognize | as
1582         a single character command.
1583
1584 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1585
1586         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1587         top.c (execute_command_to_ui_file): New function, mostly a copy
1588         of execute_command_to_string.
1589         (execute_command_to_string): Implement by calling
1590         execute_command_to_ui_file.
1591
1592 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1593
1594         * top.h (saved_command_line): Remove declaration.
1595         * top.c (previous_saved_command_line, previous_repeat_arguments):
1596         New variables.
1597         (saved_command_line): Make static, define together with other
1598         'repeat variables'.
1599         (dont_repeat): Clear repeat_arguments.
1600         (repeat_previous, get_saved_command_line, save_command_line):
1601         New functions.
1602         (gdb_init): Initialize saved_command_line
1603         and previous_saved_command_line.
1604         * main.c (captured_main_1): Remove saved_command_line initialization.
1605         * event-top.c (handle_line_of_input): Update to use
1606         the new 'repeat' related functions instead of direct access to
1607         saved_command_line.
1608         * command.h (repeat_previous, get_saved_command_line,
1609         save_command_line): New declarations.
1610         (dont_repeat): Add comment.
1611
1612 2019-05-30  Tom Tromey  <tromey@adacore.com>
1613
1614         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1615         Fix comment.
1616         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1617
1618 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1619
1620         PR cli/24587
1621         * completer.c (complete): Initialize variable word.
1622
1623 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1624
1625         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1626         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1627         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1628         'body' is NULL to the outter 'if', protecting the '!is_define'
1629         situation as well.
1630
1631 2019-05-29  Tom Tromey  <tromey@adacore.com>
1632
1633         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1634         (dwarf_unknown): New function.
1635         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1636         (dwarf_type_encoding_name): Use dwarf_unknown.
1637
1638 2019-05-29  Tom Tromey  <tromey@adacore.com>
1639
1640         PR c++/20020:
1641         * cp-valprint.c (cp_print_value_fields): Call
1642         cp_print_static_field inside "try".
1643
1644 2019-05-29  Tom Tromey  <tromey@adacore.com>
1645
1646         * inflow.c (struct terminal_info): Add default operator=.
1647         * configure: Rebuild.
1648         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1649         -Wdeprecated-copy-dtor, -Wredundant-move.
1650
1651 2019-05-29  Tom Tromey  <tromey@adacore.com>
1652
1653         * NEWS: Add entry.
1654         * infcmd.c (print_return_value_1): Handle finish_print
1655         option.
1656         (show_print_finish): New function.
1657         (_initialize_infcmd): Add "set/show print finish" commands.
1658         * valprint.c (user_print_options): Initialize new member.
1659         * valprint.h (struct value_print_options) <finish_print>: New
1660         member.
1661
1662 2019-05-28  Tom Tromey  <tromey@adacore.com>
1663
1664         * ada-lang.c (ada_remove_Xbn_suffix)
1665         (find_old_style_renaming_symbol)
1666         (parse_old_style_renaming): Remove.
1667         (ada_find_renaming_symbol): Don't call
1668         find_old_style_renaming_symbol.
1669         (ada_is_renaming_symbol): Rename from
1670         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1671         bool.  Now static.
1672         (ada_read_var_value): Update and simplify.
1673         * ada-exp.y (write_var_or_type): Remove old code.
1674
1675 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1676
1677         * event-top.c: Remove include comment.
1678         * inflow.c (class scoped_ignore_sigttou): Move from here...
1679         * inflow.h (class scoped_ignore_sigttou): ...to here.
1680         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1681         * top.c:  Remove include comment.
1682
1683 2019-05-27  Tom Tromey  <tom@tromey.com>
1684
1685         * NEWS: Fix typo.
1686
1687 2019-05-22  Tom Tromey  <tromey@adacore.com>
1688
1689         * target.c (target_follow_exec): Constify parameter.
1690         * target-delegates.c: Rebuild.
1691         * remote.c (remote_target::follow_exec): Constify parameter.
1692         * infrun.c (follow_exec): Constify parameter.
1693         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1694         (target_follow_exec): Likewise.
1695
1696 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1697
1698         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1699         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1700
1701 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1702
1703         * NEWS: Add debugredirect and testsuite sections.
1704
1705 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1706
1707         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1708         target descriptions using exclusively floating point register name
1709         aliases.
1710
1711 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1712
1713         PR gdb/18644:
1714         * f-lang.c (build_fortran_types): Handle the case where
1715         gdbarch_floatformat_for_type returns a nullptr.
1716
1717 2019-05-21  Tom de Vries  <tdevries@suse.de>
1718
1719         PR cli/24587
1720         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1721
1722 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1723
1724         PR gdb/18644:
1725         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1726         16-byte floats.
1727         * i386-tdep.c (i386_floatformat_for_type): Use
1728         floatformats_ia64_quad for the 16-byte floating point component
1729         within a fortran 32-byte complex number.
1730
1731 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1734         delete default constructor.
1735         (find_partial_die): Update to return const struct.
1736         (partial_die_parent_scope): Move variable declaration into scope
1737         of its use and change its type to auto.
1738         (guess_partial_die_structure_name): Likewise.
1739         (partial_die_info::fixup): Likewise.
1740
1741 2019-05-17  Tom Tromey  <tromey@adacore.com>
1742
1743         * source.c (find_and_open_source): Remove cast.
1744
1745 2019-05-17  Tom Tromey  <tromey@adacore.com>
1746
1747         * annotate.c (annotate_source): Make "filename" const.
1748         * annotate.h (annotate_source): Use const.
1749
1750 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1751
1752         * disasm.c (set_disassembler_options): Send errors to stderr.
1753
1754 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1755
1756         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1757         (cli_interp_base::set_logging): Check debug_redirect.
1758         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1759         * cli/cli-logging.c (debug_redirect): Add static variable.
1760         (pop_output_files): Add default param.
1761         (handle_redirections): Print debug setting.
1762         (show_logging_command): Likewise.
1763         (_initialize_cli_logging): Add debugredirect command.
1764         * interps.c (current_interp_set_logging): Add debug_redirect
1765         parameter.
1766         * interps.h (set_logging): Add debug_redirect parameter.
1767         (current_interp_set_logging): Likewise.
1768         * mi/mi-common.h: Likewise.
1769         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1770
1771 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1772             Tom Tromey  <tromey@adacore.com>
1773
1774         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1775         directly.
1776         * cli/cli-interp.h (make_logging_output): Remove declaration.
1777         * cli/cli-logging.c (make_logging_output): Remove function.
1778         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1779         directly.
1780         * ui-file.c (tee_file::tee_file): Remove bools.
1781         (tee_file::~tee_file): Remove deletes.
1782         * ui-file.h (tee_file): Remove bools.
1783
1784 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1785
1786         * mi/mi-cmds.h (mi_cmd_complete): New function.
1787         * mi/mi-main.c (mi_cmd_complete): Likewise.
1788         * mi/mi-cmds.c: Define new MI command -complete.
1789         * NEWS: Mention new -complete command.
1790
1791 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1792
1793         * completer.h (complete): New function.
1794         * completer.c (complete): Likewise.
1795         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1796         function defined in completer.h.
1797
1798 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1799
1800         * MAINTAINERS (Write After Approval): Add myself.
1801
1802 2019-05-17  Tom de Vries  <tdevries@suse.de>
1803
1804         PR gdb/24094
1805         * dwarf2read.c (struct cu_partial_die_info): New struct.
1806         (find_partial_die): Return cu_partial_die_info.
1807         (partial_die_parent_scope, guess_partial_die_structure_name)
1808         (partial_die_info::fixup): Handle new return type of find_partial_die.
1809
1810 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1811
1812         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1813         "std::string", simplifying the algorithm.
1814
1815 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1816
1817         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1818         (stap_static_probe_ops::get_probes): Likewise.
1819
1820 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1821
1822         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1823         '-')" and "else if".
1824         (stap_parse_single_operand): Join checks for
1825         "gdbarch_stap_parse_special_token_p" and
1826         "gdbarch_stap_parse_special_token" in the same "if" statement.
1827         Invert check when verifying for operation on register
1828         displacement.
1829
1830 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1831
1832         * stap-probe.c (stap_get_opcode): Update comment.
1833         (stap_get_expected_argument_type): Likewise.
1834         (handle_stap_probe): Likewise.
1835
1836 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1837
1838         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1839         return type to 'bool'.  Adjust comment.  Use 'bool' when
1840         appropriate.
1841         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1842         * stap-probe.c (stap_parse_argument_1): Likewise.
1843         (stap_is_operator): Likewise.
1844         (stap_is_generic_prefix): Likewise.
1845         (stap_is_register_prefix): Likewise.
1846         (stap_is_register_indirection_prefix): Likewise.
1847         (stap_is_integer_prefix): Likewise.
1848         (stap_generic_check_suffix): Likewise.
1849         (stap_check_integer_suffix): Likewise.
1850         (stap_check_register_suffix): Likewise.
1851         (stap_check_register_indirection_suffix): Likewise.
1852         (stap_parse_register_operand): Likewise.
1853         (stap_parse_single_operand): Likewise.
1854         (stap_parse_argument_1): Likewise.
1855         (stap_probe::get_argument_count): Likewise.
1856         (stap_is_operator): Likewise.
1857
1858 2019-05-16  Tom Tromey  <tromey@adacore.com>
1859
1860         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1861         keyword to foreach.
1862
1863 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1864
1865         * linux-thread-db.c (try_thread_db_load_1): Change return type
1866         to bool.
1867         (try_thread_db_load): Likewise.
1868         (try_thread_db_load_from_pdir_1): Likewise.
1869         (try_thread_db_load_from_pdir): Likewise.
1870         (try_thread_db_load_from_sdir): Likewise.
1871         (try_thread_db_load_from_dir): Likewise.
1872         (thread_db_load_search): Likewise.
1873         (has_libpthread): Likewise.
1874         (thread_db_load): Likewise.
1875
1876 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1877
1878         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1879         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1880         NULL, and complain/return if that's the case.
1881
1882 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1883
1884         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1885         (advance, posn, abstract_read_memory): New functions.
1886         [struct mem_read_abstraction]: New struct.
1887         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1888
1889 2019-05-14  Tom Tromey  <tromey@adacore.com>
1890
1891         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1892         value is not lval_memory.
1893
1894 2019-05-14  Tom Tromey  <tromey@adacore.com>
1895
1896         * solib.c (info_sharedlibrary_command): Style the file name.
1897
1898 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1899
1900         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1901         (aarch64_vnv_type): Likewise.
1902         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1903         * common/tdesc.c: Likewise.
1904         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1905         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1906         * features/aarch64-fpu.xml: Add ieee half view.
1907         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1908         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1909         * gdbtypes.h (struct builtin_type): Likewise.
1910         (struct objfile_type): Likewise.
1911
1912 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1913
1914         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1915         typo.
1916         * location.h (string_to_event_location): Likewise.
1917
1918 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1919
1920         GDB 8.3 released.
1921
1922 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1923
1924         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1925         New variable declaration.
1926         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1927         New variable.
1928         (print_one_breakpoint): Use ui_out::test_flags and new global
1929         variable to compute use_fixed_output.
1930         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1931         Remove.
1932         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1933         (mi_multi_location_breakpoint_output_fixed): Remove.
1934         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1935         new variable.
1936         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1937         fix_multi_location_breakpoint_output flag if version >= 3.
1938         * ui-out.h (enum ui_out_flag)
1939         <fix_multi_location_breakpoint_output>: New enumerator.
1940
1941 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1942
1943         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1944
1945 2019-05-10  Tom Tromey  <tromey@adacore.com>
1946
1947         * ada-lang.c (catch_ada_completer): New function.
1948         (_initialize_ada_language): Use it.
1949
1950 2019-05-10  Tom Tromey  <tromey@adacore.com>
1951
1952         * thread.c (print_thread_info): Make "requested_threads" const.
1953         * gdbthread.h (print_thread_info): Make "requested_threads"
1954         const.
1955         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1956         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1957
1958 2019-05-08  Tom Tromey  <tom@tromey.com>
1959
1960         * gdbtypes.c (objfile_type_data): Change type.
1961         (objfile_type, _initialize_gdbtypes): Update.
1962
1963 2019-05-08  Tom Tromey  <tom@tromey.com>
1964
1965         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1966         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1967         (_initialize_dwarf2_frame): Update.
1968
1969 2019-05-08  Tom Tromey  <tom@tromey.com>
1970
1971         * objc-lang.c (objc_objfile_data): Change type.
1972         (find_methods): Update.
1973         (_initialize_objc_lang): Remove.
1974
1975 2019-05-08  Tom Tromey  <tom@tromey.com>
1976
1977         * stabsread.c (rs6000_builtin_type_data): Change type.
1978         (rs6000_builtin_type, _initialize_stabsread): Update.
1979
1980 2019-05-08  Tom Tromey  <tom@tromey.com>
1981
1982         * mips-tdep.c (mips_pdr_data): Remove.
1983         (_initialize_mips_tdep): Update.
1984
1985 2019-05-08  Tom Tromey  <tom@tromey.com>
1986
1987         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1988         (hppa_init_objfile_priv_data, read_unwind_info)
1989         (find_unwind_entry, _initialize_hppa_tdep): Update.
1990
1991 2019-05-08  Tom Tromey  <tom@tromey.com>
1992
1993         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1994         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1995         on obstack.
1996         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1997
1998 2019-05-08  Tom Tromey  <tom@tromey.com>
1999
2000         * mdebugread.c (basic_type_data): Change type.
2001         (basic_type, _initialize_mdebugread): Update.
2002
2003 2019-05-08  Tom Tromey  <tom@tromey.com>
2004
2005         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2006
2007 2019-05-08  Tom Tromey  <tom@tromey.com>
2008
2009         * nto-tdep.c (nto_inferior_data_reg): Change type.
2010         (nto_inferior_data): Update.
2011         (nto_inferior_data_cleanup, nto_new_inferior_data)
2012         (_initialize_nto_tdep): Remove.
2013         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2014
2015 2019-05-08  Tom Tromey  <tom@tromey.com>
2016
2017         * ada-lang.c (struct ada_inferior_data): Add initializers.
2018         (ada_inferior_data): Change type.
2019         (ada_inferior_data_cleanup): Remove.
2020         (get_ada_inferior_data, ada_inferior_exit)
2021         (struct ada_pspace_data): Add initializers, destructor.
2022         (ada_pspace_data_handle): Change type.
2023         (get_ada_pspace_data): Update.
2024         (ada_pspace_data_cleanup): Remove.
2025
2026 2019-05-08  Tom Tromey  <tom@tromey.com>
2027
2028         * coffread.c (struct coff_symfile_info): Add initializers.
2029         (coff_objfile_data_key): Move lower.  Change type.
2030         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2031         Update.
2032         (coff_free_info): Remove.
2033
2034 2019-05-08  Tom Tromey  <tom@tromey.com>
2035
2036         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2037         (fbsd_pspace_data_handle): Move lower.  Change type.
2038         (get_fbsd_pspace_data): Update.
2039         (fbsd_pspace_data_cleanup): Remove.
2040         (_initialize_fbsd_tdep): Update.
2041
2042 2019-05-08  Tom Tromey  <tom@tromey.com>
2043
2044         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2045         (get_ada_tasks_pspace_data): Update.
2046         (ada_tasks_pspace_data_cleanup): Remove.
2047         (_initialize_tasks): Update.
2048         (ada_tasks_inferior_data_handle): Change type.
2049         (get_ada_tasks_inferior_data): Update.
2050         (ada_tasks_inferior_data_cleanup): Remove.
2051         (struct ada_tasks_pspace_data): Add initializers.
2052
2053 2019-05-08  Tom Tromey  <tom@tromey.com>
2054
2055         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2056         * symfile-debug.c (debug_sym_get_probes): Change type.
2057         * stap-probe.c (handle_stap_probe):
2058         (stap_static_probe_ops::get_probes): Change type.
2059         * probe.h (class static_probe_ops) <get_probes>: Change type.
2060         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2061         (parse_probes_in_pspace): Update.
2062         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2063         Update.
2064         (any_static_probe_ops::get_probes): Change type.
2065         * elfread.c (elfread_data): New typedef.
2066         (probe_key): Change type.
2067         (elf_get_probes): Likewise.  Update.
2068         (probe_key_free): Remove.
2069         (_initialize_elfread): Update.
2070         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2071         Change type.
2072         (dtrace_process_dof_probe, dtrace_process_dof)
2073         (dtrace_static_probe_ops::get_probe): Change type.
2074
2075 2019-05-08  Tom Tromey  <tom@tromey.com>
2076
2077         * xcoffread.c (struct xcoff_symfile_info): Rename from
2078         coff_symfile_info.  Add initializers.
2079         (xcoff_objfile_data_key): Move lower.  Change type.
2080         (XCOFF_DATA): Rewrite.
2081         (xcoff_free_info): Remove.
2082         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2083         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2084         (xcoff_initial_scan): Update.
2085
2086 2019-05-08  Tom Tromey  <tom@tromey.com>
2087
2088         * solib-svr4.c (struct svr4_info): Add initializers and
2089         destructor.
2090         <probes_table>: Now an htab_up.
2091         (solib_svr4_pspace_data): Change type.
2092         (free_probes_table): Simplify.
2093         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2094         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2095         (probes_table_remove_objfile_probes, register_solib_event_probe)
2096         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2097         (_initialize_svr4_solib): Update.
2098
2099 2019-05-08  Tom Tromey  <tom@tromey.com>
2100
2101         * remote.c (remote_pspace_data): Change type.
2102         (remote_pspace_data_cleanup): Remove.
2103         (get_remote_exec_file, set_pspace_remote_exec_file)
2104         (_initialize_remote): Update.
2105
2106 2019-05-08  Tom Tromey  <tom@tromey.com>
2107
2108         * breakpoint.c (breakpoint_objfile_key): Change type.
2109         (get_breakpoint_objfile_data): Update.
2110         (free_breakpoint_objfile_data): Remove.
2111         (_initialize_breakpoint): Update.
2112
2113 2019-05-08  Tom Tromey  <tom@tromey.com>
2114
2115         * linux-tdep.c (struct linux_info): Add initializers.
2116         (linux_inferior_data): Move.  Change type.
2117         (invalidate_linux_cache_inf): Update.
2118         (linux_inferior_data_cleanup): Remove.
2119         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2120
2121 2019-05-08  Tom Tromey  <tom@tromey.com>
2122
2123         * auxv.c (auxv_inferior_data): Move.  Change type.
2124         (auxv_inferior_data_cleanup): Remove.
2125         (invalidate_auxv_cache_inf): Rewrite.
2126         (get_auxv_inferior_data, _initialize_auxv): Update.
2127
2128 2019-05-08  Tom Tromey  <tom@tromey.com>
2129
2130         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2131         (symfile_debug_objfile_data_key): Change type.
2132         (symfile_debug_installed, debug_qf_has_symbols)
2133         (debug_qf_find_last_source_symtab)
2134         (debug_qf_forget_cached_source_info)
2135         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2136         (debug_qf_print_stats, debug_qf_dump)
2137         (debug_qf_expand_symtabs_for_function)
2138         (debug_qf_expand_all_symtabs)
2139         (debug_qf_expand_symtabs_with_fullname)
2140         (debug_qf_map_matching_symbols)
2141         (debug_qf_expand_symtabs_matching)
2142         (debug_qf_find_pc_sect_compunit_symtab)
2143         (debug_qf_map_symbol_filenames)
2144         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2145         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2146         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2147         (debug_sym_read_linetable, debug_sym_relocate): Update.
2148         (symfile_debug_free_objfile): Remove.
2149         (install_symfile_debug_logging, _initialize_symfile_debug):
2150         Update.
2151
2152 2019-05-08  Tom Tromey  <tom@tromey.com>
2153
2154         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2155         allocate_on_obstack.
2156         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2157         (get_dwarf2_per_objfile): Update.
2158         (set_dwarf2_per_objfile): Remove.
2159         (dwarf2_has_info, dwarf2_get_section_info): Update.
2160         (dwarf2_free_objfile): Remove.
2161         (_initialize_dwarf2_read): Update.
2162
2163 2019-05-08  Tom Tromey  <tom@tromey.com>
2164
2165         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2166         initializers.
2167         <unsupported_script_warning_printed,
2168         script_not_found_warning_printed>: Now bool.
2169         (auto_load_pspace_data): Change type.
2170         (~auto_load_pspace_info): Rename from
2171         auto_load_pspace_data_cleanup.
2172         (get_auto_load_pspace_data, init_loaded_scripts_info)
2173         (clear_section_scripts, maybe_print_unsupported_script_warning)
2174         (maybe_print_script_not_found_warning, _initialize_auto_load):
2175         Update.
2176
2177 2019-05-08  Tom Tromey  <tom@tromey.com>
2178
2179         * objfiles.c (objfile_pspace_info): Add destructor and
2180         initializers.
2181         (objfiles_pspace_data): Change type.
2182         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2183         (get_objfile_pspace_data): Update.
2184         (objfiles_bfd_data): Change type.
2185         (get_objfile_bfd_data): Update.
2186         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2187
2188 2019-05-08  Tom Tromey  <tom@tromey.com>
2189
2190         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2191         Change type.
2192         (get_catch_syscall_inferior_data): Update.
2193         (catch_syscall_inferior_data_cleanup): Remove.
2194         (_initialize_break_catch_syscall): Update.
2195
2196 2019-05-08  Tom Tromey  <tom@tromey.com>
2197
2198         * inflow.c (struct terminal_info): Add destructor and
2199         initializers.
2200         (inflow_inferior_data): Change type.
2201         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2202         (get_inflow_inferior_data, inflow_inferior_exit)
2203         (swap_terminal_info, _initialize_inflow): Update.
2204
2205 2019-05-08  Tom Tromey  <tom@tromey.com>
2206
2207         * target-dcache.c (target_dcache_cleanup): Remove.
2208         (target_dcache_aspace_key): Change type.
2209         (target_dcache_init_p, target_dcache_invalidate)
2210         (target_dcache_get, target_dcache_get_or_init)
2211         (_initialize_target_dcache): Update.
2212         * dcache.h (struct dcache_deleter): New.
2213
2214 2019-05-08  Tom Tromey  <tom@tromey.com>
2215
2216         * symtab.c (struct symbol_cache): Add destructor and
2217         initializers.
2218         (symbol_cache_key): Move.  Change type.
2219         (make_symbol_cache, free_symbol_cache): Remove.
2220         (get_symbol_cache): Update.
2221         (symbol_cache_cleanup): Remove.
2222         (ALL_PSPACES, symbol_cache_flush)
2223         (maintenance_print_symbol_cache)
2224         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2225         Update.
2226
2227 2019-05-08  Tom Tromey  <tom@tromey.com>
2228
2229         * symtab.c (struct main_info): Add destructor and initializers.
2230         (main_progspace_key): Move.  Change type.
2231         (get_main_info): Update.
2232         (main_info_cleanup): Remove.
2233         (_initialize_symtab): Update.
2234
2235 2019-05-08  Tom Tromey  <tom@tromey.com>
2236
2237         * registry.h (DECLARE_REGISTRY): Define the _key class.
2238
2239 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2240
2241         * NEWS: Merge two 'New commands' sections.
2242
2243 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2244
2245         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2246         parameter and use Ada language definition instead.
2247         (ada_val_print_ptr): Remove unused language parameter.
2248         (ada_val_print_num): Remove language parameter and use Ada language
2249         definition instead.
2250         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2251         parameter.
2252         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2253         parameter and use Ada language definition instead.
2254         (ada_val_print_1): Update all ada_val_print_xxx calls.
2255         Remove language parameter.
2256         (ada_val_print): Update ada_val_print_1 call.
2257
2258 2019-05-08  Tom Tromey  <tromey@adacore.com>
2259
2260         * remote.c (remote_hw_watchpoint_limit)
2261         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2262         Now static.
2263
2264 2019-05-08  Tom Tromey  <tromey@adacore.com>
2265
2266         * maint.c (_initialize_maint_cmds): Move initialization code to
2267         remote.c.
2268         (watchdog, show_watchdog): Move to remote.c.
2269         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2270         "watchdog" static.
2271         (_initialize_remote): Move initialization code from maint.c.
2272         * defs.h (watchdog): Don't declare.
2273
2274 2019-05-08  Tom Tromey  <tromey@adacore.com>
2275
2276         * tui/tui-interp.c: Include main.h.
2277         * interps.c: Include main.h.
2278         * main.h (interpreter_p): Declare.
2279         * defs.h (interpreter_p): Don't declare.
2280
2281 2019-05-08  Tom Tromey  <tromey@adacore.com>
2282
2283         * dwarf2loc.c: Include dwarf2read.h.
2284         * defs.h (read_unsigned_leb128): Don't declare.
2285         * dwarf2read.h (read_unsigned_leb128): Declare.
2286
2287 2019-05-08  Tom Tromey  <tromey@adacore.com>
2288
2289         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2290         method.
2291
2292 2019-05-08  Tom Tromey  <tromey@adacore.com>
2293
2294         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2295         when no wrap column is set.
2296
2297 2019-05-08  Tom Tromey  <tromey@adacore.com>
2298
2299         * c-lang.c (c_get_string): Handle non-C-style arrays.
2300
2301 2019-05-08  Tom Tromey  <tromey@adacore.com>
2302
2303         * typeprint.c (print_offset_data::update): Print the bit offset,
2304         not the number of bits remaining.
2305
2306 2019-05-08  Tom Tromey  <tromey@adacore.com>
2307
2308         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2309         padding at end of comment.
2310
2311 2019-05-08  Tom Tromey  <tromey@adacore.com>
2312
2313         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2314         Compare main types.
2315
2316 2019-05-06  Tom Tromey  <tom@tromey.com>
2317
2318         * common/scoped_mmap.c: Include common-defs.h.
2319         * common/scoped_mmap.h: Don't include config.h.
2320
2321 2019-05-04  Tom Tromey  <tom@tromey.com>
2322
2323         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2324         (struct aarch64_call_info): Add initializers.
2325         <si>: Now a std::vector.
2326         (pass_on_stack, aarch64_push_dummy_call): Update.
2327
2328 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2329             Tom Tromey  <tom@tromey.com>
2330
2331         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2332         (ppc_threads): Now a std::vector.  Now static.
2333         (hwdebug_find_thread_points_by_tid)
2334         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2335         Update.
2336
2337 2019-05-04  Tom Tromey  <tom@tromey.com>
2338
2339         * arc-tdep.c (arc_tdesc_init): Return bool.
2340
2341 2019-05-04  Tom Tromey  <tom@tromey.com>
2342
2343         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2344         Use gdb_assert_not_reached.
2345
2346 2019-05-04  Tom Tromey  <tom@tromey.com>
2347
2348         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2349         "false".
2350
2351 2019-05-04  Tom Tromey  <tom@tromey.com>
2352
2353         * arc-tdep.c (arc_tdesc_init): Use bool.
2354
2355 2019-05-04  Tom Tromey  <tom@tromey.com>
2356
2357         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2358
2359 2019-05-04  Tom Tromey  <tom@tromey.com>
2360
2361         * cli/cli-cmds.c (valid_command_p): Return bool.
2362
2363 2019-05-04  Tom Tromey  <tom@tromey.com>
2364
2365         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2366         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2367
2368 2019-05-04  Raul Tambre  <raul@tambre.ee>
2369
2370         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2371         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2372         operator for comparison.
2373
2374 2019-05-04  Tom Tromey  <tom@tromey.com>
2375
2376         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2377         (lookup_partial_symbol, print_partial_symbols)
2378         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2379         (psymbol_compare): Update.
2380         (add_psymbol_to_bcache): Clear the entire psymbol.
2381         (maintenance_check_psymtabs): Update.
2382         * psympriv.h (struct partial_symbol): Don't derive from
2383         general_symbol_info.
2384         <obj_section, unrelocated_address, address,
2385         set_unrelocated_address>: Update.
2386         <ginfo>: New member.
2387         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2388         (debug_names::write_psymbols): Update.
2389
2390 2019-05-04  Tom de Vries  <tdevries@suse.de>
2391
2392         * contrib/cc-with-tweaks.sh: Support -n arg.
2393
2394 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2395
2396         * corelow.c (core_target::detach): Ensure frame cache and
2397         register caches are cleared.
2398         inferior.c (exit_inferior_1): Likewise.
2399
2400 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2401             Tom Tromey  <tom@tromey.com>
2402
2403         * dictionary.c (collate_pending_symbols_by_language): Remove
2404         "struct" from foreach.
2405         * symtab.c (lookup_global_symbol_from_objfile)
2406         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2407         foreach.
2408         * ser-tcp.c (net_open): Remove "struct" from foreach.
2409         * objfiles.c (objfile_relocate, objfile_rebase)
2410         (objfile_has_symbols): Remove "struct" from foreach.
2411         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2412         from foreach.
2413         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2414         foreach.
2415         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2416         "struct" from foreach.
2417         * ada-lang.c (create_excep_cond_exprs)
2418         (ada_exception_catchpoint_cond_string): Remove "struct" from
2419         foreach.
2420
2421 2019-05-03  Tom Tromey  <tromey@adacore.com>
2422
2423         * ada-exp.y (convert_char_literal): Check suffix of each
2424         enumerator.
2425
2426 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2427
2428         PR ada/21406:
2429         * ada-exp.y (yywrap): Don't define.
2430         * ada-lex.l (%option): Add noyywrap
2431         (yywrap): Remove.
2432
2433 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2434
2435         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2436         _WIN32_WINNT to the XP level, unless already defined to a higher
2437         level.
2438
2439         * unittests/parse-connection-spec-selftests.c:
2440         * ser-tcp.c:
2441         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2442         override.
2443
2444         * symfile.c (find_separate_debug_file): Remove colon from the
2445         drive spec of DOS/Windows file names of the target, so that the
2446         file name produced from DEBUGDIR and the target's directory will
2447         be valid on DOS/Windows systems.
2448
2449 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2450
2451         * rust-lang.c (val_print_struct): Handle printing structures
2452         containing strings.
2453
2454 2019-05-02  Tom Tromey  <tromey@adacore.com>
2455
2456         * valarith.c (_initialize_valarith): Remove.
2457
2458 2019-05-01  Tom Tromey  <tromey@adacore.com>
2459
2460         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2461         bitfields.
2462
2463 2019-05-01  Tom Tromey  <tromey@adacore.com>
2464
2465         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2466         for big-endian copies.
2467
2468 2019-04-30  Ali Tamur  <tamur@google.com>
2469         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2470         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2471         (read_3_bytes): New function.
2472
2473 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2474
2475         * windows-nat.c (main_thread_id): Delete.
2476         (handle_output_debug_string): Replace main_thread_id by
2477         current_event.dwThreadId.
2478         (fake_create_process): Likewise.
2479         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2480         Do not set main_thread_id.
2481         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2482         current_event.dwThreadId.
2483         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2484
2485 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2486
2487         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2488         Use current_event.dwThreadId instead of main_thread_id.
2489
2490 2019-04-30  Tom Tromey  <tromey@adacore.com>
2491
2492         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2493         (create_excep_cond_exprs): Iterate over program spaces.
2494         (ada_exception_catchpoint_cond_string): Examine all minimal
2495         symbols for exception types.
2496
2497 2019-04-30  Tom Tromey  <tromey@adacore.com>
2498
2499         PR c++/24470:
2500         * dwarf2read.c (process_structure_scope): Handle case where type
2501         has template parameters but no symbol was created.
2502
2503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2504             Chris January  <chris.january@arm.com>
2505
2506         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2507         qualifier.
2508         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2509
2510 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2511
2512         * f-typeprint.c (f_print_type): Update rules for printing
2513         whitespace.
2514         (f_type_print_varspec_suffix): Likewise.
2515
2516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2517             Chris January  <chris.january@arm.com>
2518
2519         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2520         function arguments.
2521
2522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2523
2524         * f-lang.c (build_fortran_types): Change name of void type to
2525         lower case.
2526         * f-typeprint.c (f_type_print_base): Print the name of the void
2527         type, rather than a fixed string.
2528         * f-valprint.c (f_decorations): Use lower case void string.
2529
2530 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2531             Chris January  <chris.january@arm.com>
2532
2533         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2534         types for Fortran.
2535
2536 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2537             Chris January  <chris.january@arm.com>
2538             David Lecomber  <david.lecomber@arm.com>
2539
2540         * f-exp.y (BINOP_INTRINSIC): New token.
2541         (exp): New parser rule handling BINOP_INTRINSIC.
2542         (f77_keywords): Add new builtin procedures.
2543         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2544         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2545         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2546         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2547         (print_unop_subexp_f): New function.
2548         (print_binop_subexp_f): New function.
2549         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2550         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2551         (dump_subexp_body_f): Likewise.
2552         (operator_check_f): Likewise.
2553         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2554         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2555
2556 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2557
2558         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2559         UNOP_KIND.
2560         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2561         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2562         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2563         (operator_length_f): New fuction.
2564         (print_subexp_f): New function.
2565         (op_name_f): New function.
2566         (dump_subexp_body_f): New function.
2567         (operator_check_f): New function.
2568         (exp_descriptor_f): Replace standard expression handling functions
2569         with new functions.
2570         * gdb/fortran-operator.def: New file.
2571         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2572         * gdb/std-operator.def: Remove UNOP_KIND.
2573
2574 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2575
2576         * std-operator.def: Remove unbalanced, stray double quote
2577         character.
2578
2579 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2580             Chris January  <chris.january@arm.com>
2581             Daniel Everett  <daniel.everett@arm.com>
2582             Nick Forrington  <nick.forrington@arm.com>
2583             Richard Bunt  <richard.bunt@arm.com>
2584
2585         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2586         of depth when printing anonymous structs or unions.
2587         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2588         Don't print either the top-level value, or the children if the
2589         max-depth is exceeded.
2590         (ppscm_print_children): When printing the key of a map, allow one
2591         extra level of depth.
2592         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2593         print either the top-level value, or the children if the max-depth
2594         is exceeded.
2595         (print_children): When printing the key of a map, allow one extra
2596         level of depth.
2597         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2598         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2599         (user_print_options): Initialise max_depth field.
2600         (val_print_scalar_or_string_type_p): New function.
2601         (val_print): Check to see if the max depth has been reached.
2602         (val_print_check_max_depth): Define new function.
2603         (show_print_max_depth): New function.
2604         (_initialize_valprint): Add 'print max-depth' option.
2605         * valprint.h (struct value_print_options) <max_depth>: New field.
2606         (val_print_check_max_depth): Declare new function.
2607         * NEWS: Document new feature.
2608
2609 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * ada-lang.c (ada_language_defn): Initialise new field.
2612         * c-lang.c (c_is_string_type_p): New function.
2613         (c_language_defn): Initialise new field.
2614         (cplus_language_defn): Initialise new field.
2615         (asm_language_defn): Initialise new field.
2616         (minimal_language_defn): Initialise new field.
2617         * c-lang.h (c_is_string_type_p): Declare new function.
2618         * d-lang.c (d_language_defn): Initialise new field.
2619         * f-lang.c (f_is_string_type_p): New function.
2620         (f_language_defn): Initialise new field.
2621         * go-lang.c (go_is_string_type_p): New function.
2622         (go_language_defn): Initialise new field.
2623         * language.c (default_is_string_type_p): New function.
2624         (unknown_language_defn): Initialise new field.
2625         (auto_language_defn): Initialise new field.
2626         * language.h (struct language_defn) <la_is_string_type_p>: New
2627         member variable.
2628         (default_is_string_type_p): Declare new function.
2629         * m2-lang.c (m2_language_defn): Initialise new field.
2630         * objc-lang.c (objc_language_defn): Initialise new field.
2631         * opencl-lang.c (opencl_language_defn): Initialise new field.
2632         * p-lang.c (pascal_is_string_type_p): New function.
2633         (pascal_language_defn): Initialise new field.
2634         * rust-lang.c (rust_is_string_type_p): New function.
2635         (rust_language_defn): Initialise new field.
2636
2637 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2638
2639         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2640         New field.
2641         * ada-lang.c (ada_language_defn): Initialise new field.
2642         * c-lang.c (c_language_defn): Likewise.
2643         (cplus_language_defn): Likewise.
2644         (asm_language_defn): Likewise.
2645         (minimal_language_defn): Likewise.
2646         * d-lang.c (d_language_defn): Likewise.
2647         * f-lang.c (f_language_defn): Likewise.
2648         * go-lang.c (go_language_defn): Likewise.
2649         * language.c (unknown_language_defn): Likewise.
2650         (auto_language_defn): Likewise.
2651         * m2-lang.c (m2_language_defn): Likewise.
2652         * objc-lang.c (objc_language_defn): Likewise.
2653         * opencl-lang.c (opencl_language_defn): Likewise.
2654         * p-lang.c (pascal_language_defn): Likewise.
2655         * rust-lang.c (rust_language_defn): Likewise.
2656
2657 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2658
2659         * ada-lang.c (ada_is_character_type): Change return type to bool.
2660         (ada_is_string_type): Likewise.
2661         * ada-lang.h (ada_is_character_type): Update declaration
2662         (ada_is_string_type): Likewise.
2663
2664 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2665
2666         Support style in 'frame|thread apply'
2667
2668         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2669         * record.c (record_start, record_stop): Update callers of
2670         execute_command_to_string with false.
2671         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2672         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2673         methods.
2674         (class string_file): New constructor with term_out parameter.
2675         Override methods term_out and can_emit_style_escape.  New member
2676         term_out.
2677         (class stdio_file): Override can_emit_style_escape.
2678         (class tee_file): Override term_out and can_emit_style_escape.
2679         * utils.h (can_emit_style_escape): Remove.
2680         * utils.c (can_emit_style_escape): Likewise.
2681         Update all callers of can_emit_style_escape (SOMESTREAM) to
2682         SOMESTREAM->can_emit_style_escape.
2683         * source-cache.c (source_cache::get_source_lines): Likewise.
2684         * stack.c (frame_apply_command_count): Call execute_command_to_string
2685         passing the term_out characteristic of the current gdb_stdout.
2686         * thread.c (thr_try_catch_cmd): Likewise.
2687         * top.c (execute_command_to_string): pass term_out parameter
2688         to construct the string_file for the command output.
2689         * ui-file.c (term_cli_styling): New function (most code moved
2690         from utils.c can_emit_style_escape).
2691         (string_file::string_file, string_file::can_emit_style_escape,
2692         stdio_file::can_emit_style_escape, tee_file::term_out,
2693         tee_file::can_emit_style_escape): New functions.
2694
2695 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2696
2697         * NEWS: Mention the new set|show may-call-functions.
2698         * infcall.c (may_call_functions_p): New variable.
2699         (show_may_call_functions_p): New function.
2700         (call_function_by_hand_dummy): Throws an error if not
2701         may-call-functions.
2702         (_initialize_infcall): Call add_setshow_boolean_cmd for
2703         may-call-functions.
2704
2705 2019-04-25  Keith Seitz  <keiths@redhat.com>
2706
2707         PR c++/24367
2708         * cp-support.c (inspect_type): Don't attempt substitutions
2709         of symbol with the same name.
2710
2711 2019-04-25  Tom Tromey  <tromey@adacore.com>
2712
2713         PR gdb/24475:
2714         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2715         static.
2716
2717 2019-04-25  Tom Tromey  <tromey@adacore.com>
2718
2719         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2720         rvalue reference.
2721         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2722         (gdb_xml_parser::parse): Use std::move.
2723         * python/python-internal.h (gdbpy_convert_exception): Take a const
2724         reference.
2725         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2726         std::move.
2727         * python/py-utils.c (gdbpy_convert_exception): Take a const
2728         reference.
2729         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2730         Use std::move.
2731         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2732         Use std::move.
2733         * mi/mi-main.c (mi_print_exception): Take a const reference.
2734         * main.c (handle_command_errors): Take a const reference.
2735         * linespec.c (parse_linespec): Use std::move.
2736         * infcall.c (run_inferior_call): Use std::move.
2737         (call_function_by_hand_dummy): Use std::move.
2738         * exec.c (try_open_exec_file): Use std::move.
2739         * exceptions.h (exception_print, exception_fprintf)
2740         (exception_print_same): Update.
2741         * exceptions.c (print_exception, exception_print)
2742         (exception_fprintf, exception_print_same): Change parameters to
2743         const reference.
2744         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2745         * common/new-op.c: Use std::move.
2746         * common/common-exceptions.h (struct gdb_exception): Add move
2747         constructor.
2748         (struct gdb_exception_error, struct gdb_exception_quit, struct
2749         gdb_quit_bad_alloc): Change constructor to move constructor.
2750         (throw_exception): Change parameter to rvalue reference.
2751         * common/common-exceptions.c (throw_exception): Take rvalue
2752         reference.
2753         * cli/cli-interp.c (safe_execute_command): Use std::move.
2754         * breakpoint.c (insert_bp_location, location_to_sals): Use
2755         std::move.
2756
2757 2019-04-25  Tom Tromey  <tromey@adacore.com>
2758
2759         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2760         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2761         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2762         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2763         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2764         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2765         guile/scm-value.c: Use unpack.
2766         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2767         gdbscm_gdb_exception.
2768         (gdbscm_throw_gdb_exception): Likewise.
2769         (struct gdbscm_gdb_exception): New.
2770         (unpack): New function.
2771         (gdbscm_wrap): Use unpack.
2772
2773 2019-04-25  Tom Tromey  <tromey@adacore.com>
2774
2775         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2776         (gdb_rl_callback_handler): Use std::move.
2777         * common/common-exceptions.h (struct gdb_exception): Add move
2778         assignment operator.
2779         (throw_exception_sjlj): Change "exception" to const reference.
2780         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2781         (throw_exception_sjlj): Change "exception" to const reference.
2782
2783 2019-04-25  Tom Tromey  <tromey@adacore.com>
2784
2785         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2786         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2787         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2788         Update.
2789         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2790         Update.
2791         * mi/mi-interp.c (mi_interp::exec): Update.
2792         * linespec.c (parse_linespec): Update.
2793         * infcall.c (run_inferior_call): Update.
2794         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2795         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2796         (gdbscm_lookup_global_symbol): Update.
2797         * guile/scm-param.c (gdbscm_parameter_value): Update.
2798         * guile/scm-frame.c (gdbscm_frame_read_register)
2799         (gdbscm_frame_read_var): Update.
2800         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2801         * exec.c (try_open_exec_file): Update.
2802         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2803         (gdb_rl_callback_handler): Update.
2804         * common/common-exceptions.h (exception_none): Don't declare.
2805         * common/common-exceptions.c (exception_none): Don't define.
2806         (struct catcher) <exception>: Update.
2807         * cli/cli-interp.c (safe_execute_command): Update.
2808         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2809
2810 2019-04-25  Ali Tamur  <tamur@google.com>
2811
2812         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2813         (read_attribute_value): Likewise.
2814         (dwarf2_read_addr_index): Update comment.
2815         (read_str_index): Add DW_FORM_strx.
2816         (dwarf2_string_attr): Likewise.
2817         (dwarf2_const_value_attr): Likewise.
2818         (dump_die_shallow): Likewise.
2819         (dwarf2_fetch_constant_bytes): Likewise.
2820         (skip_form_bytes): Likewise.
2821         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2822
2823 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2824
2825         PR corefiles/11608
2826         PR corefiles/18187
2827         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2828         OFFSET.  Verify if current mapping contains an ELF header.
2829         (linux_find_memory_regions_full): Adjust call to
2830         dump_mapping_p.
2831
2832 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2833             Kang Li <kanglictf@gmail.com>
2834
2835         PR gdb/21600
2836
2837         * dwarf2-frame.c (read_initial_length): Be consistent about using
2838         unsigned representation of length.
2839         (decode_frame_entry_1): Likewise.  Check for wraparound of
2840         end pointer as well as buffer overflow.
2841
2842 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2843
2844         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2845         "vq".
2846
2847 2019-04-24  Tom Tromey  <tromey@adacore.com>
2848
2849         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2850
2851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2852
2853         * s12z-tdep.c (s12z_unwind_pc): Delete.
2854         (s12z_unwind_sp): Delete.
2855         (s12z_gdbarch_init): Don't register deleted functions with
2856         gdbarch.
2857
2858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2859
2860         * rl78-tdep.c (rl78_unwind_sp): Delete.
2861         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2862
2863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2864
2865         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2866         (xstormy16_unwind_pc): Delete.
2867         (xstormy16_dummy_id): Delete.
2868         (xstormy16_gdbarch_init): Don't register deleted functions with
2869         gdbarch.
2870
2871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2872
2873         * vax-tdep.c (vax_unwind_pc): Delete.
2874         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2875
2876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * v850-tdep.c (v850_unwind_sp): Delete.
2879         (v850_unwind_pc): Delete.
2880         (v850_dummy_id): Delete.
2881         (v850_gdbarch_init): Don't register deleted functions with
2882         gdbarch.
2883
2884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2887         (tilegx_unwind_pc): Delete.
2888         (tilegx_unwind_dummy_id): Delete.
2889         (tilegx_gdbarch_init): Don't register deleted functions with
2890         gdbarch.
2891
2892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2893
2894         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2895         (tic6x_dummy_id): Delete.
2896         (tic6x_gdbarch_init): Don't register deleted functions with
2897         gdbarch.
2898
2899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * sparc-tdep.c (sparc_unwind_pc): Delete.
2902         (sparc32_gdbarch_init): Don't register deleted function with
2903         gdbarch.
2904
2905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2906
2907         * sh-tdep.c (sh_unwind_sp): Delete.
2908         (sh_unwind_pc): Delete.
2909         (sh_dummy_id): Delete.
2910         (sh_gdbarch_init): Don't register deleted functions with
2911         gdbarch.
2912
2913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2914
2915         * score-tdep.c (score_unwind_sp): Delete.
2916         (score_unwind_pc): Delete.
2917         (score_dummy_id): Delete.
2918         (score_gdbarch_init): Don't register deleted functions with
2919         gdbarch.
2920
2921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2922
2923         * rx-tdep.c (rx_unwind_pc): Delete.
2924         (rx_unwind_sp): Delete.
2925         (rx_dummy_id): Delete.
2926         (rx_gdbarch_init): Don't register deleted functions with
2927         gdbarch.  Update comment.
2928
2929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2930
2931         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2932         (rs6000_dummy_id): Delete.
2933         (rs6000_gdbarch_init): Don't register deleted functions with
2934         gdbarch.
2935
2936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2937
2938         * or1k-tdep.c (or1k_dummy_id): Delete.
2939         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2940
2941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2942
2943         * nios2-tdep.c (nios2_dummy_id): Delete.
2944         (nios2_unwind_sp): Delete.
2945         (nios2_gdbarch_init): Don't register deleted functions with
2946         gdbarch.
2947
2948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2949
2950         * nds32-tdep.c (nds32_dummy_id): Delete.
2951         (nds32_unwind_pc): Delete.
2952         (nds32_unwind_sp): Delete.
2953         (nds32_gdbarch_init): Don't register deleted functions with
2954         gdbarch.
2955
2956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2957
2958         * msp430-tdep.c (msp430_unwind_pc): Delete.
2959         (msp430_unwind_sp): Delete.
2960         (msp430_dummy_id): Delete.
2961         (msp430_gdbarch_init): Don't register deleted functions with
2962         gdbarch.
2963
2964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2965
2966         * moxie-tdep.c (moxie_unwind_sp): Delete.
2967         (moxie_unwind_pc): Delete.
2968         (moxie_dummy_id): Delete.
2969         (moxie_gdbarch_init): Don't register deleted functions with
2970         gdbarch.
2971
2972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2973
2974         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2975         (mn10300_unwind_pc): Delete.
2976         (mn10300_unwind_sp): Delete.
2977         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2978         mn10300_unwind_sp.
2979         (mn10300_frame_unwind_init): Don't register deleted functions with
2980         gdbarch.
2981
2982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * mep-tdep.c (mep_unwind_pc): Delete.
2985         (mep_unwind_sp): Delete.
2986         (mep_dummy_id): Delete.
2987         (mep_gdbarch_init): Don't register deleted functions with
2988         gdbarch.
2989
2990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2993         (m68hc11_unwind_sp): Delete.
2994         (m68hc11_gdbarch_init): Don't register deleted functions with
2995         gdbarch.
2996
2997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * m32r-tdep.c (m32r_unwind_sp): Delete.
3000         (m32r_unwind_pc): Delete.
3001         (m32r_dummy_id): Delete.
3002         (m32r_gdbarch_init): Don't register deleted functions with
3003         gdbarch.
3004
3005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3006
3007         * m32c-tdep.c (m32c_unwind_pc): Delete.
3008         (m32c_unwind_sp): Delete.
3009         (m32c_dummy_id): Delete.
3010         (m32c_gdbarch_init): Don't register deleted functions with
3011         gdbarch.
3012
3013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3014
3015         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3016         (lm32_unwind_pc): Delete.
3017         (lm32_dummy_id): Delete.
3018         (lm32_gdbarch_init): Don't register deleted functions with
3019         gdbarch.
3020
3021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3022
3023         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3024         (iq2000_unwind_pc): Delete.
3025         (iq2000_dummy_id): Delete.
3026         (iq2000_gdbarch_init): Don't register deleted functions with
3027         gdbarch.
3028
3029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3030
3031         * nds32-tdep.c (nds32_type_align): Delete.
3032         (nds32_push_dummy_call): Use type_align instead.
3033
3034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * arm-tdep.c (arm_type_align): Only handle vector override case.
3037         (arm_push_dummy_call): Use type_align.
3038         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3039
3040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3043         case.
3044         (pass_on_stack): Use type_align.
3045         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3046         function.
3047
3048 2019-04-23  Tom Tromey  <tromey@adacore.com>
3049
3050         * dwarf2read.c (line_header::file_name_at): Remove unused
3051         overload.
3052
3053 2019-04-23  Tom de Vries  <tdevries@suse.de>
3054
3055         PR gdb/24438
3056         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3057         invocation.
3058
3059
3060 2019-03-27  Ali Tamur  <tamur@google.com>
3061
3062         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3063         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3064         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3065         (dwarf_expr_context::get_addr_index): Likewise
3066         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3067         (symbol_needs_eval_context::get_addr_index): Likewise
3068         (disassemble_dwarf_expression): Add DW_OP_addrx
3069         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3070         (read_cutu_die_from_dwo): Update comment
3071         (skip_one_die): Add DW_FORM_addrx
3072         (read_attribute_value): Likewise
3073         (var_decode_location): Add DW_OP_addrx
3074         (dwarf2_const_value_attr): Add DW_FORM_addrx
3075         (dump_die_shallow): Likewise
3076         (dwarf2_fetch_constant_bytes): Likewise
3077         (decode_locdesc): Add DW_OP_addrx
3078         (skip_form_bytes): Add DW_FORM_addrx
3079
3080 2019-04-22  Ali Tamur  <tamur@google.com>
3081
3082         * MAINTAINERS (Write After Approval): Add self.
3083
3084 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3085
3086         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3087         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3088         (open_symbol_file_object): Likewise.
3089         (svr4_default_sos): Add info parameter.
3090         (svr4_read_so_list): Likewise.
3091         (svr4_current_sos_direct): Adjust functions calls to pass down
3092         info.
3093         (svr4_current_sos_1): Add info parameter.
3094         (svr4_current_sos): Call get_svr4_info, pass info down to
3095         svr4_current_sos_1.
3096         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3097         get_svr4_info.
3098         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3099         get_svr4_info.
3100         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3101         to get_svr4_info.
3102         (probes_table_remove_objfile_probes): Likewise.
3103         (register_solib_event_probe): Add info parameter.
3104         (solist_update_incremental): Pass info parameter down to
3105         svr4_read_so_list.
3106         (disable_probes_interface): Add info parameter.
3107         (svr4_handle_solib_event): Pass current_program_space to
3108         get_svr4_info.  Adjust disable_probes_interface cleanup.
3109         (svr4_create_probe_breakpoints): Add info parameter, pass it
3110         down to register_solib_event_probe.
3111         (svr4_create_solib_event_breakpoints): Add info parameter,
3112         pass it down to svr4_create_probe_breakpoints.
3113         (enable_break): Pass info down to
3114         svr4_create_solib_event_breakpoints.
3115         (svr4_solib_create_inferior_hook): Pass current_program_space to
3116         get_svr4_info.
3117         (svr4_clear_solib): Likewise.
3118
3119 2019-04-22  Pedro Alves  <palves@redhat.com>
3120
3121         * solib-svr4.c (svr4_free_objfile_observer): New.
3122         (probe_and_action::objfile): New field.
3123         (probes_table_htab_remove_objfile_probes)
3124         (probes_table_remove_objfile_probes): New functions.
3125         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3126         in the new probe_and_action.  Don't store the probe in 'lookup'.
3127         (svr4_create_probe_breakpoints): Pass objfile to
3128         register_solib_event_probe.
3129         (_initialize_svr4_solib): Register a free_objfile observer.
3130
3131 2019-04-19  Tom Tromey  <tom@tromey.com>
3132
3133         * common/queue.h: Remove.
3134
3135 2019-04-19  Tom Tromey  <tom@tromey.com>
3136
3137         * event-loop.c: Don't include "common/queue.h".
3138
3139 2019-04-19  Tom Tromey  <tom@tromey.com>
3140
3141         * remote.c (remote_target): Use delete.
3142         * remote-notif.h: Include <list>, not "common/queue.h".
3143         (notif_client_p): Remove typedef.
3144         (remote_notif_state): Add constructor, destructor, initializer.
3145         <notif_queue>: Now a std::list.
3146         (remote_notif_state_xfree): Don't declare.
3147         * remote-notif.c (remote_notif_process, handle_notification)
3148         (remote_notif_state_allocate): Update.
3149         (~remote_notif_state): Rename from remote_notif_state_xfree.
3150
3151 2019-04-19  Tom Tromey  <tom@tromey.com>
3152
3153         * symfile.c (reread_symbols): Update.
3154         * objfiles.c (objfile_register_static_link)
3155         (objfile_lookup_static_link): Update
3156         (~objfile) Don't delete static_links.
3157         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3158
3159 2019-04-19  Tom Tromey  <tom@tromey.com>
3160
3161         * type-stack.h (struct type_stack) <insert>: Constify string.
3162         * type-stack.c (type_stack::insert): Constify string.
3163         * gdbtypes.h (lookup_template_type): Update.
3164         (address_space_name_to_int): Update.
3165         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3166         const.
3167         (lookup_template_type): Make name const.
3168         * c-exp.y: Update rules.
3169         (lex_one_token, classify_name, classify_inner_name)
3170         (c_print_token): Update.
3171         * p-exp.y: Update rules.
3172         (yylex): Update.
3173         * f-exp.y: Update rules.
3174         (yylex): Update.
3175         * d-exp.y: Update rules.
3176         (lex_one_token, classify_name, classify_inner_name): Update.
3177         * parse.c (write_dollar_variable, copy_name): Return std::string.
3178         * parser-defs.h (copy_name): Change return type.
3179         * m2-exp.y: Update rules.
3180         (yylex): Update.
3181         * go-exp.y (lex_one_token): Update.
3182         Update rules.
3183         (classify_unsafe_function, classify_packaged_name)
3184         (classify_name, yylex): Update.
3185
3186 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3187
3188         * configure.ac: add --enable-source-highlight switch.
3189         * configure: Regenerate.
3190         * top.c (print_gdb_version): plumb --enable-source-highlight
3191         status to "show configuration".
3192
3193 2019-04-19  Tom Tromey  <tromey@adacore.com>
3194
3195         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3196         Check ADA_TYPE_P.
3197         (empty_record, ada_template_to_fixed_record_type_1)
3198         (template_to_static_fixed_type)
3199         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3200         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3201         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3202         macros.
3203
3204 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3205
3206         PR symtab/24423:
3207         * source.c (print_source_lines_base): Advance "iter" when a
3208         control character is seen.
3209
3210 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3211
3212         * inferior.h (struct infcall_suspend_state_deleter):
3213         Catch exception in destructor to avoid crash.
3214
3215 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3216
3217         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3218         close to the add_com "shell".
3219
3220 2019-04-18  Tom Tromey  <tromey@adacore.com>
3221
3222         * process-stratum-target.h (class process_stratum_target)
3223         <stratum>: Add "final".
3224
3225 2019-04-17  Tom Tromey  <tromey@adacore.com>
3226
3227         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3228         against nullptr before use.
3229
3230 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3231
3232         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3233
3234 2019-04-17  Jim Wilson  <jimw@sifive.com>
3235             Andrew Burgess  <andrew.burgess@embecosm.com>
3236
3237         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3238         code read might fail, assume 4-byte breakpoint in that case.
3239
3240 2019-04-15  Leszek Swirski  <leszeks@google.com>
3241
3242         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3243         rather than a hand-rolled POD check when checking for forced MEMORY
3244         classification.
3245
3246 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3247
3248         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3249         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3250         function.
3251         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3252         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3253         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3254         declaration.
3255
3256 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3257
3258         * aarch64-linux-nat.c
3259         (aarch64_linux_nat_target::thread_architecture): Add override.
3260         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3261         each VQ.
3262
3263 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3264
3265         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3266
3267 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3270         target types of size 96-bits, add some additional comments, and
3271         check that the builtin type we found was the correct size.
3272
3273 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3274
3275         * utils.c (prompt_for_continue): Don't restore the styling at the
3276         end, as applied_style has the wrong value.  This fixes styling in
3277         long lists of file names that are interrupted by the "Continue?"
3278         prompt.
3279
3280 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3281
3282         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3283         * c-lang.c (c_language_defn): Likewise.
3284         (cplus_language_defn): Likewise.
3285         (asm_language_defn): Likewise.
3286         (minimal_language_defn): Likewise.
3287         * d-lang.c (d_language_defn): Likewise.
3288         * f-lang.c (f_language_defn): Likewise.
3289         * go-lang.c (go_language_defn): Likewise.
3290         * language.c (unknown_language_defn): Likewise.
3291         (auto_language_defn): Likewise.
3292         * language.h (struct language_defn): Remove la_magic field.
3293         (LANG_MAGIC): Delete.
3294         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3295         * objc-lang.c (objc_language_defn): Likewise.
3296         * opencl-lang.c (opencl_language_defn): Likewise.
3297         * p-lang.c (pascal_language_defn): Likewise.
3298         * rust-lang.c (rust_language_defn): Likewise.
3299
3300 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * riscv-tdep.c (riscv_type_align): New function.
3303         (riscv_type_alignment): Delete.
3304         (riscv_arg_location): Use 'type_align'.
3305         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3306
3307 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         * gdbtypes.c (type_align): A struct with no non-static fields also
3310         has alignment of 1.
3311
3312 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3313
3314         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3315         component to 0.
3316         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3317         member.
3318         (riscv_struct_info::analyse): New implementation using new
3319         analyse_inner member function.
3320         (riscv_struct_info::field_offset): New member function.
3321         (riscv_struct_info::m_offsets): New member variable.
3322         (riscv_struct_info::analyse_inner): New private member function,
3323         takes the old implementation of riscv_struct_info::analyse but
3324         extended to track field offsets.
3325         (riscv_call_arg_struct): Update the struct folding special cases
3326         to handle cases where empty C++ structs, which are non-zero
3327         length, are found.
3328         (riscv_arg_location): Initialise the length of each location, a
3329         non-zero length now indicates the location is in use.
3330         (riscv_push_dummy_call): Allow for the first location having a
3331         non-zero offset when setting up arguments.
3332         (riscv_return_value): Likewise, but for return values.
3333
3334 2019-04-11  Tom Tromey  <tromey@adacore.com>
3335
3336         * utils.c (internal_vproblem): Make "msg" const.
3337
3338 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3339
3340         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3341         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3342         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3343         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3344
3345 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3346
3347         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3348         function.
3349         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3350         of amd64_collect_native_gregset.
3351         (amd64_linux_nat_target::store_registers): Likewise.
3352
3353 2019-04-10  Tom Tromey  <tom@tromey.com>
3354
3355         * symtab.c (lookup_global_symbol_from_objfile)
3356         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3357         * objfiles.h (class separate_debug_iterator): New.
3358         (class separate_debug_range): New.
3359         (struct objfile) <separate_debug_objfiles>: New method.
3360         (objfile_separate_debug_iterate): Don't declare.
3361         * objfiles.c (separate_debug_iterator::operator++): Rename from
3362         objfile_separate_debug_iterate.
3363         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3364         iterator.
3365         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3366         iterator.
3367
3368 2019-04-10  Tom Tromey  <tom@tromey.com>
3369
3370         * symfile.c (reread_symbols): Remove old comment.
3371         * objfiles.c (free_all_objfiles): Fix a typo.
3372
3373 2019-04-10  Tom Tromey  <tom@tromey.com>
3374
3375         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3376         * minsyms.c (lookup_minimal_symbol): Use foreach.
3377         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3378         (lookup_minimal_symbol_solib_trampoline): Likewise.
3379         * symfile.c (reread_symbols): Use foreach.
3380
3381 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3382             Tom Tromey  <tromey@adacore.com>
3383
3384         PR rust/24414:
3385         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3386         (rust_lex_int_test): Change "value" to be LONGEST.
3387         (rust_lex_tests): Add test for long integer literal.
3388
3389 2019-04-09  Tom Tromey  <tromey@adacore.com>
3390
3391         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3392         to bool.
3393         (extended_remote_target::attach): Update.
3394         (remote_target::remote_notice_new_inferior): Update.
3395         (remote_target::add_current_inferior_and_thread): Update.
3396         * inferior.c (exit_inferior_1): Use "false".
3397         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3398
3399 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3400
3401         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3402         the "start" command.
3403
3404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3405
3406         * python/py-inferior.c (infpy_thread_from_thread_handle):
3407         Adjust comments to reflect renaming of thread_from_thread_handle
3408         to thread_from_handle.  Adjust keywords.  Fix type error message.
3409         (inferior_object_methods): Add thread_from_handle.  Retain
3410         thread_from_thread_handle, but mark it as deprecated.
3411
3412 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3413
3414         * gdbthread.h (find_thread_by_handle): Revise declaration.
3415         * thread.c (find_thread_by_handle): Likewise.  Adjust
3416         implementation too.
3417         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3418         support for buffer objects as handles.
3419
3420 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3421
3422         * python/py-infthread.c (thpy_thread_handle): New function.
3423         (thread_object_methods): Register thpy_thread_handle.
3424
3425 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3426
3427         * gdbthread.h (thread_to_thread_handle): Declare.
3428         * thread.c (gdbtypes.h): Include.
3429         (thread_to_thread_handle): New function.
3430
3431         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3432         (target_thread_info_to_thread_handle): Declare.
3433         * target.c (target_thread_info_to_thread_handle): New function.
3434         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3435         * target-delegates.c: Regenerate.
3436
3437         * linux-thread-db.c (class thread_db_target): Add method
3438         thread_info_to_thread_handle.
3439         (thread_db_target::thread_info_to_thread_handle): Define.
3440         * remote.c (class remote_target): Add new method
3441         thread_info_to_thread_handle.
3442         (remote_target::thread_info_to_thread_handle): Define.
3443
3444 2019-04-08  Pedro Alves  <palves@redhat.com>
3445
3446         * common/common-exceptions.c (throw_exception): Don't create
3447         named object to throw; throw directly.
3448         (throw_it): Likewise.  Don't initialize gdb_exception::message
3449         here, with new; pass FMT and AP to the ctor instead.
3450         * common/common-exceptions.h: Include <string>.
3451         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3452         const char *, va_list)): New ctor.  Use std::make_shared.
3453         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3454         errors)): Delete.
3455         (gdb_exception_error::gdb_exception_error(enum errors, const char
3456         *, va_list)): New.
3457         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3458         Add assertion.
3459         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3460         errors)): Delete.
3461         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3462         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3463         Add assertion.
3464
3465 2019-04-08  Tom Tromey  <tom@tromey.com>
3466
3467         * valops.c (value_rtti_indirect_type): Replace throw_exception
3468         with throw.
3469         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3470         with throw.
3471         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3472         throw.
3473         * target.c (target_translate_tls_address): Replace throw_exception
3474         with throw.
3475         * stack.c (frame_apply_command_count): Replace throw_exception
3476         with throw.
3477         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3478         throw.
3479         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3480         with throw.
3481         * rs6000-tdep.c (rs6000_frame_cache)
3482         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3483         * remote.c: Replace throw_exception with throw.
3484         * record-full.c (record_full_message, record_full_wait_1)
3485         (record_full_restore): Replace throw_exception with throw.
3486         * record-btrace.c:
3487         (get_thread_current_frame_id, record_btrace_start_replaying)
3488         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3489         (cmd_record_btrace_start): Replace throw_exception with throw.
3490         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3491         throw.
3492         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3493         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3494         * linespec.c:
3495         (find_linespec_symbols): Replace throw_exception with throw.
3496         * infrun.c (displaced_step_prepare, resume): Replace
3497         throw_exception with throw.
3498         * infcmd.c (post_create_inferior): Replace throw_exception with
3499         throw.
3500         * inf-loop.c (inferior_event_handler): Replace throw_exception
3501         with throw.
3502         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3503         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3504         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3505         (get_prev_frame_always, get_frame_pc_if_available)
3506         (get_frame_address_in_block_if_available, get_frame_language):
3507         Replace throw_exception with throw.
3508         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3509         throw_exception with throw.
3510         * eval.c (fetch_subexp_value, evaluate_var_value)
3511         (evaluate_funcall, evaluate_subexp_standard): Replace
3512         throw_exception with throw.
3513         * dwarf2loc.c (call_site_find_chain)
3514         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3515         Replace throw_exception with throw.
3516         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3517         with throw.
3518         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3519         throw.
3520         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3521         * completer.c (complete_line_internal): Replace throw_exception
3522         with throw.
3523         * compile/compile-object-run.c (compile_object_run): Replace
3524         throw_exception with throw.
3525         * cli/cli-script.c (process_next_line): Replace throw_exception
3526         with throw.
3527         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3528         (btrace_enable, btrace_maint_update_pt_packets): Replace
3529         throw_exception with throw.
3530         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3531         throw_exception with throw.
3532         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3533         throw_exception with throw.
3534         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3535         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3536         * aarch64-tdep.c (aarch64_make_prologue_cache)
3537         (aarch64_make_stub_cache): Replace throw_exception with throw.
3538
3539 2019-04-08  Tom Tromey  <tom@tromey.com>
3540
3541         * common/common-exceptions.c (throw_exception): Rename from
3542         throw_exception_cxx.  Remove old copy.  Make argument const.
3543         (throw_it): Create and throw exception objects directly.
3544         * common/common-exceptions.h (throw_exception): Make argument
3545         const.
3546         (struct gdb_exception_error): Add constructor.
3547         (struct gdb_exception_quit): Add constructor.
3548
3549 2019-04-08  Tom Tromey  <tom@tromey.com>
3550
3551         * common/common-exceptions.h (exception_rethrow): Don't declare.
3552         (TRY_SJLJ): Update comment.
3553         (TRY, CATCH, END_CATCH): Remove.
3554         * common/common-exceptions.c (exception_rethrow): Remove.
3555
3556 2019-04-08  Tom Tromey  <tom@tromey.com>
3557
3558         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3559         Remove.
3560         (gdb_exception_error): Rename from
3561         gdb_exception_RETURN_MASK_ERROR.
3562         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3563         (gdb_quit_bad_alloc): Update.
3564         * aarch64-tdep.c: Update.
3565         * ada-lang.c: Update.
3566         * ada-typeprint.c: Update.
3567         * ada-valprint.c: Update.
3568         * amd64-tdep.c: Update.
3569         * arch-utils.c: Update.
3570         * break-catch-throw.c: Update.
3571         * breakpoint.c: Update.
3572         * btrace.c: Update.
3573         * c-varobj.c: Update.
3574         * cli/cli-cmds.c: Update.
3575         * cli/cli-interp.c: Update.
3576         * cli/cli-script.c: Update.
3577         * common/common-exceptions.c: Update.
3578         * common/new-op.c: Update.
3579         * common/selftest.c: Update.
3580         * compile/compile-c-symbols.c: Update.
3581         * compile/compile-cplus-symbols.c: Update.
3582         * compile/compile-object-load.c: Update.
3583         * compile/compile-object-run.c: Update.
3584         * completer.c: Update.
3585         * corelow.c: Update.
3586         * cp-abi.c: Update.
3587         * cp-support.c: Update.
3588         * cp-valprint.c: Update.
3589         * darwin-nat.c: Update.
3590         * disasm-selftests.c: Update.
3591         * dtrace-probe.c: Update.
3592         * dwarf-index-cache.c: Update.
3593         * dwarf-index-write.c: Update.
3594         * dwarf2-frame-tailcall.c: Update.
3595         * dwarf2-frame.c: Update.
3596         * dwarf2loc.c: Update.
3597         * dwarf2read.c: Update.
3598         * eval.c: Update.
3599         * event-loop.c: Update.
3600         * event-top.c: Update.
3601         * exec.c: Update.
3602         * f-valprint.c: Update.
3603         * fbsd-tdep.c: Update.
3604         * frame-unwind.c: Update.
3605         * frame.c: Update.
3606         * gdbtypes.c: Update.
3607         * gnu-v3-abi.c: Update.
3608         * guile/guile-internal.h: Update.
3609         * guile/scm-block.c: Update.
3610         * guile/scm-breakpoint.c: Update.
3611         * guile/scm-cmd.c: Update.
3612         * guile/scm-disasm.c: Update.
3613         * guile/scm-frame.c: Update.
3614         * guile/scm-lazy-string.c: Update.
3615         * guile/scm-math.c: Update.
3616         * guile/scm-param.c: Update.
3617         * guile/scm-ports.c: Update.
3618         * guile/scm-pretty-print.c: Update.
3619         * guile/scm-symbol.c: Update.
3620         * guile/scm-symtab.c: Update.
3621         * guile/scm-type.c: Update.
3622         * guile/scm-value.c: Update.
3623         * i386-linux-tdep.c: Update.
3624         * i386-tdep.c: Update.
3625         * inf-loop.c: Update.
3626         * infcall.c: Update.
3627         * infcmd.c: Update.
3628         * infrun.c: Update.
3629         * jit.c: Update.
3630         * language.c: Update.
3631         * linespec.c: Update.
3632         * linux-fork.c: Update.
3633         * linux-nat.c: Update.
3634         * linux-tdep.c: Update.
3635         * linux-thread-db.c: Update.
3636         * main.c: Update.
3637         * mi/mi-cmd-break.c: Update.
3638         * mi/mi-cmd-stack.c: Update.
3639         * mi/mi-interp.c: Update.
3640         * mi/mi-main.c: Update.
3641         * objc-lang.c: Update.
3642         * p-valprint.c: Update.
3643         * parse.c: Update.
3644         * ppc-linux-tdep.c: Update.
3645         * printcmd.c: Update.
3646         * python/py-arch.c: Update.
3647         * python/py-breakpoint.c: Update.
3648         * python/py-cmd.c: Update.
3649         * python/py-finishbreakpoint.c: Update.
3650         * python/py-frame.c: Update.
3651         * python/py-framefilter.c: Update.
3652         * python/py-gdb-readline.c: Update.
3653         * python/py-inferior.c: Update.
3654         * python/py-infthread.c: Update.
3655         * python/py-lazy-string.c: Update.
3656         * python/py-linetable.c: Update.
3657         * python/py-objfile.c: Update.
3658         * python/py-param.c: Update.
3659         * python/py-prettyprint.c: Update.
3660         * python/py-progspace.c: Update.
3661         * python/py-record-btrace.c: Update.
3662         * python/py-record.c: Update.
3663         * python/py-symbol.c: Update.
3664         * python/py-type.c: Update.
3665         * python/py-unwind.c: Update.
3666         * python/py-utils.c: Update.
3667         * python/py-value.c: Update.
3668         * python/python.c: Update.
3669         * record-btrace.c: Update.
3670         * record-full.c: Update.
3671         * remote-fileio.c: Update.
3672         * remote.c: Update.
3673         * riscv-tdep.c: Update.
3674         * rs6000-aix-tdep.c: Update.
3675         * rs6000-tdep.c: Update.
3676         * rust-exp.y: Update.
3677         * rust-lang.c: Update.
3678         * s390-tdep.c: Update.
3679         * selftest-arch.c: Update.
3680         * solib-dsbt.c: Update.
3681         * solib-frv.c: Update.
3682         * solib-spu.c: Update.
3683         * solib-svr4.c: Update.
3684         * solib.c: Update.
3685         * sparc64-linux-tdep.c: Update.
3686         * stack.c: Update.
3687         * symfile-mem.c: Update.
3688         * symmisc.c: Update.
3689         * target.c: Update.
3690         * thread.c: Update.
3691         * top.c: Update.
3692         * tracefile-tfile.c: Update.
3693         * tui/tui.c: Update.
3694         * typeprint.c: Update.
3695         * unittests/cli-utils-selftests.c: Update.
3696         * unittests/parse-connection-spec-selftests.c: Update.
3697         * valops.c: Update.
3698         * valprint.c: Update.
3699         * value.c: Update.
3700         * varobj.c: Update.
3701         * windows-nat.c: Update.
3702         * x86-linux-nat.c: Update.
3703         * xml-support.c: Update.
3704
3705 2019-04-08  Tom Tromey  <tom@tromey.com>
3706
3707         * xml-support.c: Use C++ exception handling.
3708         * x86-linux-nat.c: Use C++ exception handling.
3709         * windows-nat.c: Use C++ exception handling.
3710         * varobj.c: Use C++ exception handling.
3711         * value.c: Use C++ exception handling.
3712         * valprint.c: Use C++ exception handling.
3713         * valops.c: Use C++ exception handling.
3714         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3715         handling.
3716         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3717         * typeprint.c: Use C++ exception handling.
3718         * tui/tui.c: Use C++ exception handling.
3719         * tracefile-tfile.c: Use C++ exception handling.
3720         * top.c: Use C++ exception handling.
3721         * thread.c: Use C++ exception handling.
3722         * target.c: Use C++ exception handling.
3723         * symmisc.c: Use C++ exception handling.
3724         * symfile-mem.c: Use C++ exception handling.
3725         * stack.c: Use C++ exception handling.
3726         * sparc64-linux-tdep.c: Use C++ exception handling.
3727         * solib.c: Use C++ exception handling.
3728         * solib-svr4.c: Use C++ exception handling.
3729         * solib-spu.c: Use C++ exception handling.
3730         * solib-frv.c: Use C++ exception handling.
3731         * solib-dsbt.c: Use C++ exception handling.
3732         * selftest-arch.c: Use C++ exception handling.
3733         * s390-tdep.c: Use C++ exception handling.
3734         * rust-lang.c: Use C++ exception handling.
3735         * rust-exp.y: Use C++ exception handling.
3736         * rs6000-tdep.c: Use C++ exception handling.
3737         * rs6000-aix-tdep.c: Use C++ exception handling.
3738         * riscv-tdep.c: Use C++ exception handling.
3739         * remote.c: Use C++ exception handling.
3740         * remote-fileio.c: Use C++ exception handling.
3741         * record-full.c: Use C++ exception handling.
3742         * record-btrace.c: Use C++ exception handling.
3743         * python/python.c: Use C++ exception handling.
3744         * python/py-value.c: Use C++ exception handling.
3745         * python/py-utils.c: Use C++ exception handling.
3746         * python/py-unwind.c: Use C++ exception handling.
3747         * python/py-type.c: Use C++ exception handling.
3748         * python/py-symbol.c: Use C++ exception handling.
3749         * python/py-record.c: Use C++ exception handling.
3750         * python/py-record-btrace.c: Use C++ exception handling.
3751         * python/py-progspace.c: Use C++ exception handling.
3752         * python/py-prettyprint.c: Use C++ exception handling.
3753         * python/py-param.c: Use C++ exception handling.
3754         * python/py-objfile.c: Use C++ exception handling.
3755         * python/py-linetable.c: Use C++ exception handling.
3756         * python/py-lazy-string.c: Use C++ exception handling.
3757         * python/py-infthread.c: Use C++ exception handling.
3758         * python/py-inferior.c: Use C++ exception handling.
3759         * python/py-gdb-readline.c: Use C++ exception handling.
3760         * python/py-framefilter.c: Use C++ exception handling.
3761         * python/py-frame.c: Use C++ exception handling.
3762         * python/py-finishbreakpoint.c: Use C++ exception handling.
3763         * python/py-cmd.c: Use C++ exception handling.
3764         * python/py-breakpoint.c: Use C++ exception handling.
3765         * python/py-arch.c: Use C++ exception handling.
3766         * printcmd.c: Use C++ exception handling.
3767         * ppc-linux-tdep.c: Use C++ exception handling.
3768         * parse.c: Use C++ exception handling.
3769         * p-valprint.c: Use C++ exception handling.
3770         * objc-lang.c: Use C++ exception handling.
3771         * mi/mi-main.c: Use C++ exception handling.
3772         * mi/mi-interp.c: Use C++ exception handling.
3773         * mi/mi-cmd-stack.c: Use C++ exception handling.
3774         * mi/mi-cmd-break.c: Use C++ exception handling.
3775         * main.c: Use C++ exception handling.
3776         * linux-thread-db.c: Use C++ exception handling.
3777         * linux-tdep.c: Use C++ exception handling.
3778         * linux-nat.c: Use C++ exception handling.
3779         * linux-fork.c: Use C++ exception handling.
3780         * linespec.c: Use C++ exception handling.
3781         * language.c: Use C++ exception handling.
3782         * jit.c: Use C++ exception handling.
3783         * infrun.c: Use C++ exception handling.
3784         * infcmd.c: Use C++ exception handling.
3785         * infcall.c: Use C++ exception handling.
3786         * inf-loop.c: Use C++ exception handling.
3787         * i386-tdep.c: Use C++ exception handling.
3788         * i386-linux-tdep.c: Use C++ exception handling.
3789         * guile/scm-value.c: Use C++ exception handling.
3790         * guile/scm-type.c: Use C++ exception handling.
3791         * guile/scm-symtab.c: Use C++ exception handling.
3792         * guile/scm-symbol.c: Use C++ exception handling.
3793         * guile/scm-pretty-print.c: Use C++ exception handling.
3794         * guile/scm-ports.c: Use C++ exception handling.
3795         * guile/scm-param.c: Use C++ exception handling.
3796         * guile/scm-math.c: Use C++ exception handling.
3797         * guile/scm-lazy-string.c: Use C++ exception handling.
3798         * guile/scm-frame.c: Use C++ exception handling.
3799         * guile/scm-disasm.c: Use C++ exception handling.
3800         * guile/scm-cmd.c: Use C++ exception handling.
3801         * guile/scm-breakpoint.c: Use C++ exception handling.
3802         * guile/scm-block.c: Use C++ exception handling.
3803         * guile/guile-internal.h: Use C++ exception handling.
3804         * gnu-v3-abi.c: Use C++ exception handling.
3805         * gdbtypes.c: Use C++ exception handling.
3806         * frame.c: Use C++ exception handling.
3807         * frame-unwind.c: Use C++ exception handling.
3808         * fbsd-tdep.c: Use C++ exception handling.
3809         * f-valprint.c: Use C++ exception handling.
3810         * exec.c: Use C++ exception handling.
3811         * event-top.c: Use C++ exception handling.
3812         * event-loop.c: Use C++ exception handling.
3813         * eval.c: Use C++ exception handling.
3814         * dwarf2read.c: Use C++ exception handling.
3815         * dwarf2loc.c: Use C++ exception handling.
3816         * dwarf2-frame.c: Use C++ exception handling.
3817         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3818         * dwarf-index-write.c: Use C++ exception handling.
3819         * dwarf-index-cache.c: Use C++ exception handling.
3820         * dtrace-probe.c: Use C++ exception handling.
3821         * disasm-selftests.c: Use C++ exception handling.
3822         * darwin-nat.c: Use C++ exception handling.
3823         * cp-valprint.c: Use C++ exception handling.
3824         * cp-support.c: Use C++ exception handling.
3825         * cp-abi.c: Use C++ exception handling.
3826         * corelow.c: Use C++ exception handling.
3827         * completer.c: Use C++ exception handling.
3828         * compile/compile-object-run.c: Use C++ exception handling.
3829         * compile/compile-object-load.c: Use C++ exception handling.
3830         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3831         * compile/compile-c-symbols.c: Use C++ exception handling.
3832         * common/selftest.c: Use C++ exception handling.
3833         * common/new-op.c: Use C++ exception handling.
3834         * cli/cli-script.c: Use C++ exception handling.
3835         * cli/cli-interp.c: Use C++ exception handling.
3836         * cli/cli-cmds.c: Use C++ exception handling.
3837         * c-varobj.c: Use C++ exception handling.
3838         * btrace.c: Use C++ exception handling.
3839         * breakpoint.c: Use C++ exception handling.
3840         * break-catch-throw.c: Use C++ exception handling.
3841         * arch-utils.c: Use C++ exception handling.
3842         * amd64-tdep.c: Use C++ exception handling.
3843         * ada-valprint.c: Use C++ exception handling.
3844         * ada-typeprint.c: Use C++ exception handling.
3845         * ada-lang.c: Use C++ exception handling.
3846         * aarch64-tdep.c: Use C++ exception handling.
3847
3848 2019-04-08  Tom Tromey  <tom@tromey.com>
3849
3850         * xml-support.c (gdb_xml_parser::parse): Update.
3851         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3852         * value.c (show_convenience): Update.
3853         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3854         (test_parse_flags_qcs): Update.
3855         * thread.c (thr_try_catch_cmd): Update.
3856         * target.c (target_translate_tls_address): Update.
3857         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3858         (info_frame_command_core, frame_apply_command_count): Update.
3859         * rust-exp.y (rust_lex_exception_test): Update.
3860         * riscv-tdep.c (riscv_print_one_register_info): Update.
3861         * remote.c (remote_target::enable_btrace): Update.
3862         * record-btrace.c (record_btrace_enable_warn): Update.
3863         * python/py-utils.c (gdbpy_convert_exception): Update.
3864         * printcmd.c (do_one_display, print_variable_and_value): Update.
3865         * mi/mi-main.c (mi_print_exception): Update.
3866         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3867         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3868         * linux-nat.c (linux_nat_target::attach): Update.
3869         * linux-fork.c (class scoped_switch_fork_info): Update.
3870         * infrun.c (displaced_step_prepare): Update.
3871         * infcall.c (call_function_by_hand_dummy): Update.
3872         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3873         * gnu-v3-abi.c (print_one_vtable): Update.
3874         * frame.c (get_prev_frame_always): Update.
3875         * f-valprint.c (info_common_command_for_block): Update.
3876         * exec.c (try_open_exec_file): Update.
3877         * exceptions.c (print_exception, exception_print)
3878         (exception_fprintf, exception_print_same): Update.
3879         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3880         * dwarf-index-cache.c (index_cache::store)
3881         (index_cache::lookup_gdb_index): Update.
3882         * darwin-nat.c (maybe_cache_shell): Update.
3883         * cp-valprint.c (cp_print_value_fields): Update.
3884         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3885         (gcc_cplus_symbol_address): Update.
3886         * compile/compile-c-symbols.c (gcc_convert_symbol)
3887         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3888         * common/selftest.c: Update.
3889         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3890         a std::string.
3891         (exception_try_scope_entry, exception_try_scope_exit): Don't
3892         declare.
3893         (struct exception_try_scope): Remove.
3894         (TRY): Don't use exception_try_scope.
3895         (struct gdb_exception): Add constructor, operator=.
3896         <what>: New method.
3897         (struct gdb_exception_RETURN_MASK_ALL)
3898         (struct gdb_exception_RETURN_MASK_ERROR)
3899         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3900         (struct gdb_quit_bad_alloc): Update.
3901         * common/common-exceptions.c (exception_none): Change
3902         initializer.
3903         (struct catcher) <state, exception>: Initialize inline.
3904         <prev>: Remove member.
3905         (current_catcher): Remove.
3906         (catchers): New global.
3907         (exceptions_state_mc_init): Simplify.
3908         (catcher_pop): Remove.
3909         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3910         (try_scope_depth, exception_try_scope_entry)
3911         (exception_try_scope_exit): Remove.
3912         (throw_exception_sjlj): Update.
3913         (exception_messages, exception_messages_size): Remove.
3914         (throw_it): Simplify.
3915         (gdb_exception_sliced_copy): Remove.
3916         (throw_exception_cxx): Update.
3917         * cli/cli-script.c (script_from_file): Update.
3918         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3919         Update.
3920         * ada-valprint.c (ada_val_print): Update.
3921         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3922         (create_excep_cond_exprs): Update.
3923
3924 2019-04-08  Tom Tromey  <tom@tromey.com>
3925
3926         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3927         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3928         (TRY, CATCH, END_CATCH): Remove some definitions.
3929         * common/common-exceptions.c: Don't use GDB_XCPT.
3930         (catcher_list_size): Remove.
3931         (throw_exception, throw_it): Simplify.
3932
3933 2019-04-05  Tom Tromey  <tom@tromey.com>
3934
3935         Revert the header-sorting patch.
3936         * ft32-tdep.c: Revert.
3937         * frv-tdep.c: Revert.
3938         * frv-linux-tdep.c: Revert.
3939         * frame.c: Revert.
3940         * frame-unwind.c: Revert.
3941         * frame-base.c: Revert.
3942         * fork-child.c: Revert.
3943         * findvar.c: Revert.
3944         * findcmd.c: Revert.
3945         * filesystem.c: Revert.
3946         * filename-seen-cache.h: Revert.
3947         * filename-seen-cache.c: Revert.
3948         * fbsd-tdep.c: Revert.
3949         * fbsd-nat.h: Revert.
3950         * fbsd-nat.c: Revert.
3951         * f-valprint.c: Revert.
3952         * f-typeprint.c: Revert.
3953         * f-lang.c: Revert.
3954         * extension.h: Revert.
3955         * extension.c: Revert.
3956         * extension-priv.h: Revert.
3957         * expprint.c: Revert.
3958         * exec.h: Revert.
3959         * exec.c: Revert.
3960         * exceptions.c: Revert.
3961         * event-top.c: Revert.
3962         * event-loop.c: Revert.
3963         * eval.c: Revert.
3964         * elfread.c: Revert.
3965         * dwarf2read.h: Revert.
3966         * dwarf2read.c: Revert.
3967         * dwarf2loc.c: Revert.
3968         * dwarf2expr.h: Revert.
3969         * dwarf2expr.c: Revert.
3970         * dwarf2-frame.c: Revert.
3971         * dwarf2-frame-tailcall.c: Revert.
3972         * dwarf-index-write.h: Revert.
3973         * dwarf-index-write.c: Revert.
3974         * dwarf-index-common.c: Revert.
3975         * dwarf-index-cache.h: Revert.
3976         * dwarf-index-cache.c: Revert.
3977         * dummy-frame.c: Revert.
3978         * dtrace-probe.c: Revert.
3979         * disasm.h: Revert.
3980         * disasm.c: Revert.
3981         * disasm-selftests.c: Revert.
3982         * dictionary.c: Revert.
3983         * dicos-tdep.c: Revert.
3984         * demangle.c: Revert.
3985         * dcache.h: Revert.
3986         * dcache.c: Revert.
3987         * darwin-nat.h: Revert.
3988         * darwin-nat.c: Revert.
3989         * darwin-nat-info.c: Revert.
3990         * d-valprint.c: Revert.
3991         * d-namespace.c: Revert.
3992         * d-lang.c: Revert.
3993         * ctf.c: Revert.
3994         * csky-tdep.c: Revert.
3995         * csky-linux-tdep.c: Revert.
3996         * cris-tdep.c: Revert.
3997         * cris-linux-tdep.c: Revert.
3998         * cp-valprint.c: Revert.
3999         * cp-support.c: Revert.
4000         * cp-namespace.c: Revert.
4001         * cp-abi.c: Revert.
4002         * corelow.c: Revert.
4003         * corefile.c: Revert.
4004         * continuations.c: Revert.
4005         * completer.h: Revert.
4006         * completer.c: Revert.
4007         * complaints.c: Revert.
4008         * coffread.c: Revert.
4009         * coff-pe-read.c: Revert.
4010         * cli-out.h: Revert.
4011         * cli-out.c: Revert.
4012         * charset.c: Revert.
4013         * c-varobj.c: Revert.
4014         * c-valprint.c: Revert.
4015         * c-typeprint.c: Revert.
4016         * c-lang.c: Revert.
4017         * buildsym.c: Revert.
4018         * buildsym-legacy.c: Revert.
4019         * build-id.h: Revert.
4020         * build-id.c: Revert.
4021         * btrace.c: Revert.
4022         * bsd-uthread.c: Revert.
4023         * breakpoint.h: Revert.
4024         * breakpoint.c: Revert.
4025         * break-catch-throw.c: Revert.
4026         * break-catch-syscall.c: Revert.
4027         * break-catch-sig.c: Revert.
4028         * blockframe.c: Revert.
4029         * block.c: Revert.
4030         * bfin-tdep.c: Revert.
4031         * bfin-linux-tdep.c: Revert.
4032         * bfd-target.c: Revert.
4033         * bcache.c: Revert.
4034         * ax-general.c: Revert.
4035         * ax-gdb.h: Revert.
4036         * ax-gdb.c: Revert.
4037         * avr-tdep.c: Revert.
4038         * auxv.c: Revert.
4039         * auto-load.c: Revert.
4040         * arm-wince-tdep.c: Revert.
4041         * arm-tdep.c: Revert.
4042         * arm-symbian-tdep.c: Revert.
4043         * arm-pikeos-tdep.c: Revert.
4044         * arm-obsd-tdep.c: Revert.
4045         * arm-nbsd-tdep.c: Revert.
4046         * arm-nbsd-nat.c: Revert.
4047         * arm-linux-tdep.c: Revert.
4048         * arm-linux-nat.c: Revert.
4049         * arm-fbsd-tdep.c: Revert.
4050         * arm-fbsd-nat.c: Revert.
4051         * arm-bsd-tdep.c: Revert.
4052         * arch-utils.c: Revert.
4053         * arc-tdep.c: Revert.
4054         * arc-newlib-tdep.c: Revert.
4055         * annotate.h: Revert.
4056         * annotate.c: Revert.
4057         * amd64-windows-tdep.c: Revert.
4058         * amd64-windows-nat.c: Revert.
4059         * amd64-tdep.c: Revert.
4060         * amd64-sol2-tdep.c: Revert.
4061         * amd64-obsd-tdep.c: Revert.
4062         * amd64-obsd-nat.c: Revert.
4063         * amd64-nbsd-tdep.c: Revert.
4064         * amd64-nbsd-nat.c: Revert.
4065         * amd64-nat.c: Revert.
4066         * amd64-linux-tdep.c: Revert.
4067         * amd64-linux-nat.c: Revert.
4068         * amd64-fbsd-tdep.c: Revert.
4069         * amd64-fbsd-nat.c: Revert.
4070         * amd64-dicos-tdep.c: Revert.
4071         * amd64-darwin-tdep.c: Revert.
4072         * amd64-bsd-nat.c: Revert.
4073         * alpha-tdep.c: Revert.
4074         * alpha-obsd-tdep.c: Revert.
4075         * alpha-nbsd-tdep.c: Revert.
4076         * alpha-mdebug-tdep.c: Revert.
4077         * alpha-linux-tdep.c: Revert.
4078         * alpha-linux-nat.c: Revert.
4079         * alpha-bsd-tdep.c: Revert.
4080         * alpha-bsd-nat.c: Revert.
4081         * aix-thread.c: Revert.
4082         * agent.c: Revert.
4083         * addrmap.c: Revert.
4084         * ada-varobj.c: Revert.
4085         * ada-valprint.c: Revert.
4086         * ada-typeprint.c: Revert.
4087         * ada-tasks.c: Revert.
4088         * ada-lang.c: Revert.
4089         * aarch64-tdep.c: Revert.
4090         * aarch64-ravenscar-thread.c: Revert.
4091         * aarch64-newlib-tdep.c: Revert.
4092         * aarch64-linux-tdep.c: Revert.
4093         * aarch64-linux-nat.c: Revert.
4094         * aarch64-fbsd-tdep.c: Revert.
4095         * aarch64-fbsd-nat.c: Revert.
4096         * aarch32-linux-nat.c: Revert.
4097
4098 2019-04-05  Tom Tromey  <tom@tromey.com>
4099
4100         * ft32-tdep.c: Sort headers.
4101         * frv-tdep.c: Sort headers.
4102         * frv-linux-tdep.c: Sort headers.
4103         * frame.c: Sort headers.
4104         * frame-unwind.c: Sort headers.
4105         * frame-base.c: Sort headers.
4106         * fork-child.c: Sort headers.
4107         * findvar.c: Sort headers.
4108         * findcmd.c: Sort headers.
4109         * filesystem.c: Sort headers.
4110         * filename-seen-cache.h: Sort headers.
4111         * filename-seen-cache.c: Sort headers.
4112         * fbsd-tdep.c: Sort headers.
4113         * fbsd-nat.h: Sort headers.
4114         * fbsd-nat.c: Sort headers.
4115         * f-valprint.c: Sort headers.
4116         * f-typeprint.c: Sort headers.
4117         * f-lang.c: Sort headers.
4118         * extension.h: Sort headers.
4119         * extension.c: Sort headers.
4120         * extension-priv.h: Sort headers.
4121         * expprint.c: Sort headers.
4122         * exec.h: Sort headers.
4123         * exec.c: Sort headers.
4124         * exceptions.c: Sort headers.
4125         * event-top.c: Sort headers.
4126         * event-loop.c: Sort headers.
4127         * eval.c: Sort headers.
4128         * elfread.c: Sort headers.
4129         * dwarf2read.h: Sort headers.
4130         * dwarf2read.c: Sort headers.
4131         * dwarf2loc.c: Sort headers.
4132         * dwarf2expr.h: Sort headers.
4133         * dwarf2expr.c: Sort headers.
4134         * dwarf2-frame.c: Sort headers.
4135         * dwarf2-frame-tailcall.c: Sort headers.
4136         * dwarf-index-write.h: Sort headers.
4137         * dwarf-index-write.c: Sort headers.
4138         * dwarf-index-common.c: Sort headers.
4139         * dwarf-index-cache.h: Sort headers.
4140         * dwarf-index-cache.c: Sort headers.
4141         * dummy-frame.c: Sort headers.
4142         * dtrace-probe.c: Sort headers.
4143         * disasm.h: Sort headers.
4144         * disasm.c: Sort headers.
4145         * disasm-selftests.c: Sort headers.
4146         * dictionary.c: Sort headers.
4147         * dicos-tdep.c: Sort headers.
4148         * demangle.c: Sort headers.
4149         * dcache.h: Sort headers.
4150         * dcache.c: Sort headers.
4151         * darwin-nat.h: Sort headers.
4152         * darwin-nat.c: Sort headers.
4153         * darwin-nat-info.c: Sort headers.
4154         * d-valprint.c: Sort headers.
4155         * d-namespace.c: Sort headers.
4156         * d-lang.c: Sort headers.
4157         * ctf.c: Sort headers.
4158         * csky-tdep.c: Sort headers.
4159         * csky-linux-tdep.c: Sort headers.
4160         * cris-tdep.c: Sort headers.
4161         * cris-linux-tdep.c: Sort headers.
4162         * cp-valprint.c: Sort headers.
4163         * cp-support.c: Sort headers.
4164         * cp-namespace.c: Sort headers.
4165         * cp-abi.c: Sort headers.
4166         * corelow.c: Sort headers.
4167         * corefile.c: Sort headers.
4168         * continuations.c: Sort headers.
4169         * completer.h: Sort headers.
4170         * completer.c: Sort headers.
4171         * complaints.c: Sort headers.
4172         * coffread.c: Sort headers.
4173         * coff-pe-read.c: Sort headers.
4174         * cli-out.h: Sort headers.
4175         * cli-out.c: Sort headers.
4176         * charset.c: Sort headers.
4177         * c-varobj.c: Sort headers.
4178         * c-valprint.c: Sort headers.
4179         * c-typeprint.c: Sort headers.
4180         * c-lang.c: Sort headers.
4181         * buildsym.c: Sort headers.
4182         * buildsym-legacy.c: Sort headers.
4183         * build-id.h: Sort headers.
4184         * build-id.c: Sort headers.
4185         * btrace.c: Sort headers.
4186         * bsd-uthread.c: Sort headers.
4187         * breakpoint.h: Sort headers.
4188         * breakpoint.c: Sort headers.
4189         * break-catch-throw.c: Sort headers.
4190         * break-catch-syscall.c: Sort headers.
4191         * break-catch-sig.c: Sort headers.
4192         * blockframe.c: Sort headers.
4193         * block.c: Sort headers.
4194         * bfin-tdep.c: Sort headers.
4195         * bfin-linux-tdep.c: Sort headers.
4196         * bfd-target.c: Sort headers.
4197         * bcache.c: Sort headers.
4198         * ax-general.c: Sort headers.
4199         * ax-gdb.h: Sort headers.
4200         * ax-gdb.c: Sort headers.
4201         * avr-tdep.c: Sort headers.
4202         * auxv.c: Sort headers.
4203         * auto-load.c: Sort headers.
4204         * arm-wince-tdep.c: Sort headers.
4205         * arm-tdep.c: Sort headers.
4206         * arm-symbian-tdep.c: Sort headers.
4207         * arm-pikeos-tdep.c: Sort headers.
4208         * arm-obsd-tdep.c: Sort headers.
4209         * arm-nbsd-tdep.c: Sort headers.
4210         * arm-nbsd-nat.c: Sort headers.
4211         * arm-linux-tdep.c: Sort headers.
4212         * arm-linux-nat.c: Sort headers.
4213         * arm-fbsd-tdep.c: Sort headers.
4214         * arm-fbsd-nat.c: Sort headers.
4215         * arm-bsd-tdep.c: Sort headers.
4216         * arch-utils.c: Sort headers.
4217         * arc-tdep.c: Sort headers.
4218         * arc-newlib-tdep.c: Sort headers.
4219         * annotate.h: Sort headers.
4220         * annotate.c: Sort headers.
4221         * amd64-windows-tdep.c: Sort headers.
4222         * amd64-windows-nat.c: Sort headers.
4223         * amd64-tdep.c: Sort headers.
4224         * amd64-sol2-tdep.c: Sort headers.
4225         * amd64-obsd-tdep.c: Sort headers.
4226         * amd64-obsd-nat.c: Sort headers.
4227         * amd64-nbsd-tdep.c: Sort headers.
4228         * amd64-nbsd-nat.c: Sort headers.
4229         * amd64-nat.c: Sort headers.
4230         * amd64-linux-tdep.c: Sort headers.
4231         * amd64-linux-nat.c: Sort headers.
4232         * amd64-fbsd-tdep.c: Sort headers.
4233         * amd64-fbsd-nat.c: Sort headers.
4234         * amd64-dicos-tdep.c: Sort headers.
4235         * amd64-darwin-tdep.c: Sort headers.
4236         * amd64-bsd-nat.c: Sort headers.
4237         * alpha-tdep.c: Sort headers.
4238         * alpha-obsd-tdep.c: Sort headers.
4239         * alpha-nbsd-tdep.c: Sort headers.
4240         * alpha-mdebug-tdep.c: Sort headers.
4241         * alpha-linux-tdep.c: Sort headers.
4242         * alpha-linux-nat.c: Sort headers.
4243         * alpha-bsd-tdep.c: Sort headers.
4244         * alpha-bsd-nat.c: Sort headers.
4245         * aix-thread.c: Sort headers.
4246         * agent.c: Sort headers.
4247         * addrmap.c: Sort headers.
4248         * ada-varobj.c: Sort headers.
4249         * ada-valprint.c: Sort headers.
4250         * ada-typeprint.c: Sort headers.
4251         * ada-tasks.c: Sort headers.
4252         * ada-lang.c: Sort headers.
4253         * aarch64-tdep.c: Sort headers.
4254         * aarch64-ravenscar-thread.c: Sort headers.
4255         * aarch64-newlib-tdep.c: Sort headers.
4256         * aarch64-linux-tdep.c: Sort headers.
4257         * aarch64-linux-nat.c: Sort headers.
4258         * aarch64-fbsd-tdep.c: Sort headers.
4259         * aarch64-fbsd-nat.c: Sort headers.
4260         * aarch32-linux-nat.c: Sort headers.
4261
4262 2019-04-04  Tom Tromey  <tom@tromey.com>
4263
4264         * varobj.c (varobj_create): Update.
4265         * rust-exp.y (struct rust_parser) <update_innermost_block,
4266         lookup_symbol>: New methods.
4267         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4268         Rename.
4269         (rust_parser::rust_lookup_type)
4270         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4271         * printcmd.c (display_command, do_one_display): Update.
4272         * parser-defs.h (struct parser_state) <parser_state>: Add
4273         "tracker" parameter.
4274         (block_tracker): New member.
4275         (class innermost_block_tracker) <innermost_block_tracker>: Add
4276         "types" parameter.
4277         <reset>: Remove method.
4278         (innermost_block): Don't declare.
4279         (null_post_parser): Update.
4280         * parse.c (innermost_block): Remove global.
4281         (write_dollar_variable): Update.
4282         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4283         Remove "tracker_types" parameter.
4284         (parse_expression): Add "tracker" parameter.
4285         (parse_expression_for_completion): Update.
4286         (null_post_parser): Add "tracker" parameter.
4287         * p-exp.y: Update rules.
4288         * m2-exp.y: Update rules.
4289         * language.h (struct language_defn) <la_post_parser>: Add
4290         "tracker" parameter.
4291         * go-exp.y: Update rules.
4292         * f-exp.y: Update rules.
4293         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4294         parameter.
4295         * d-exp.y: Update rules.
4296         * c-exp.y: Update rules.
4297         * breakpoint.c (set_breakpoint_condition): Create an
4298         innermost_block_tracker.
4299         (watch_command_1): Likewise.
4300         * ada-lang.c (resolve): Add "tracker" parameter.
4301         (resolve_subexp): Likewise.
4302         * ada-exp.y (write_var_from_sym): Update.
4303
4304 2019-04-04  Tom Tromey  <tom@tromey.com>
4305
4306         * type-stack.h: New file.
4307         * type-stack.c: New file.
4308         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4309         type-stack.h.
4310         (insert_into_type_stack, insert_type, push_type, push_type_int)
4311         (insert_type_address_space, pop_type, pop_type_int)
4312         (pop_typelist, pop_type_stack, append_type_stack)
4313         (push_type_stack, get_type_stack, push_typelist)
4314         (follow_type_instance_flags, follow_types): Don't declare.
4315         * parse.c (type_stack): Remove global.
4316         (parse_exp_in_context): Update.
4317         (insert_into_type_stack, insert_type, push_type, push_type_int)
4318         (insert_type_address_space, pop_type, pop_type_int)
4319         (pop_typelist, pop_type_stack, append_type_stack)
4320         (push_type_stack, get_type_stack, push_typelist)
4321         (follow_type_instance_flags, follow_types): Remove (moved to
4322         type-stack.c).
4323         * f-exp.y (type_stack): New global.
4324         Update rules.
4325         (push_kind_type, f_parse): Update.
4326         * d-exp.y (type_stack): New global.
4327         Update rules.
4328         (d_parse): Update.
4329         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4330         Update rules.
4331         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4332         (HFILES_NO_SRCDIR): Add type-stack.h.
4333
4334 2019-04-04  Tom Tromey  <tom@tromey.com>
4335
4336         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4337         (rust_parser::convert_ast_to_expression, rust_parse)
4338         (rust_lex_test_completion, rust_lex_tests): Update.
4339         * parser-defs.h (struct expr_completion_state): New.
4340         (struct parser_state) <parser_state>: Add completion parameter.
4341         <mark_struct_expression, mark_completion_tag>: New methods.
4342         <parse_completion, m_completion_state>: New members.
4343         (prefixify_expression, null_post_parser): Update.
4344         (mark_struct_expression, mark_completion_tag): Don't declare.
4345         * parse.c (parse_completion, expout_last_struct)
4346         (expout_tag_completion_type, expout_completion_name): Remove
4347         globals.
4348         (parser_state::mark_struct_expression)
4349         (parser_state::mark_completion_tag): Now methods.
4350         (prefixify_expression): Add last_struct parameter.
4351         (prefixify_subexp): Likewise.
4352         (parse_exp_1): Update.
4353         (parse_exp_in_context): Add cstate parameter.  Update.
4354         (parse_expression_for_completion): Create an
4355         expr_completion_state.
4356         (null_post_parser): Add "completion" parameter.
4357         * p-exp.y: Update rules.
4358         (yylex): Update.
4359         * language.h (struct language_defn) <la_post_parser>: Add
4360         "completing" parameter.
4361         * go-exp.y: Update rules.
4362         (lex_one_token): Update.
4363         * expression.h (parse_completion): Don't declare.
4364         * d-exp.y: Update rules.
4365         (lex_one_token): Update rules.
4366         * c-exp.y: Update rules.
4367         (lex_one_token): Update.
4368         * ada-lang.c (resolve): Add "parse_completion" parameter.
4369         (resolve_subexp): Likewise.
4370         (ada_resolve_function): Likewise.
4371
4372 2019-04-04  Tom Tromey  <tom@tromey.com>
4373
4374         * parser-defs.h (struct parser_state) <start_arglist,
4375         end_arglist>: New methods.
4376         <arglist_len, m_funcall_chain>: New members.
4377         (arglist_len, start_arglist, end_arglist): Don't declare.
4378         * parse.c (arglist_len, funcall_chain): Remove global.
4379         (start_arglist, end_arglist): Remove functions.
4380         (parse_exp_in_context): Update.
4381         * p-exp.y: Update rules.
4382         * m2-exp.y: Update rules.
4383         * go-exp.y: Update rules.
4384         * f-exp.y: Update rules.
4385         * d-exp.y: Update rules.
4386         * c-exp.y: Update rules.
4387
4388 2019-04-04  Tom Tromey  <tom@tromey.com>
4389
4390         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4391         lex_operator, push_back>: New methods.
4392         Update all rules.
4393         (rust_parser::lex_hex, lex_escape): Rename and update.
4394         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4395         (rust_parser::lex_operator): Rename and update.
4396         (rust_parser::lex_number, rustyylex, rustyyerror)
4397         (rust_lex_test_init, rust_lex_test_sequence)
4398         (rust_lex_test_push_back, rust_lex_tests): Update.
4399         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4400         parameter.
4401         <lexptr, prev_lexptr>: New members.
4402         (lexptr, prev_lexptr): Don't declare.
4403         * parse.c (lexptr, prev_lexptr): Remove globals.
4404         (parse_exp_in_context): Update.
4405         * p-exp.y (yylex, yyerror): Update.
4406         * m2-exp.y (parse_number, yylex, yyerror): Update.
4407         * go-exp.y (lex_one_token, yyerror): Update.
4408         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4409         * d-exp.y (lex_one_token, yyerror): Update.
4410         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4411         (lex_one_token, yyerror): Update.
4412         * ada-lex.l (YY_INPUT): Update.
4413         (rewind_to_char): Update.
4414         * ada-exp.y (yyerror): Update.
4415
4416 2019-04-04  Tom Tromey  <tom@tromey.com>
4417
4418         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4419         * parser-defs.h (struct parser_state) <parser_state>: Add new
4420         parameter.
4421         <comma_terminates>: New member.
4422         (comma_terminates): Don't declare global.
4423         * parse.c (comma_terminates): Remove global.
4424         (parse_exp_in_context): Update.
4425         * p-exp.y (yylex): Update.
4426         * m2-exp.y (yylex): Update.
4427         * go-exp.y (lex_one_token): Update.
4428         * f-exp.y (yylex): Update.
4429         * d-exp.y (lex_one_token): Update.
4430         * c-exp.y (lex_one_token): Update.
4431         * ada-lex.l: Update.
4432
4433 2019-04-04  Tom Tromey  <tom@tromey.com>
4434
4435         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4436         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4437         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4438         * parser-defs.h (paren_depth): Don't declare.
4439         * parse.c (paren_depth): Remove global.
4440         (parse_exp_in_context): Update.
4441         * p-exp.y (paren_depth): New global.
4442         (pascal_parse): Initialize it.
4443         * m2-exp.y (paren_depth): New global.
4444         (m2_parse): Initialize it.
4445         * go-exp.y (paren_depth): New global.
4446         (go_parse): Initialize it.
4447         * f-exp.y (paren_depth): New global.
4448         (f_parse): Initialize it.
4449         * d-exp.y (paren_depth): New global.
4450         (d_parse): Initialize it.
4451         * c-exp.y (paren_depth): New global.
4452         (c_parse): Initialize it.
4453         * ada-lex.l (paren_depth): New global.
4454         (lexer_init): Initialize it.
4455
4456 2019-04-04  Tom Tromey  <tom@tromey.com>
4457
4458         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4459         (rust_parser::convert_ast_to_type)
4460         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4461         * parser-defs.h (struct parser_state) <parser_state>: Add
4462         parameters.  Initialize new members.
4463         <expression_context_block, expression_context_pc>: New members.
4464         * parse.c (expression_context_block, expression_context_pc):
4465         Remove globals.
4466         (parse_exp_in_context): Update.
4467         * p-exp.y: Update all rules.
4468         (yylex): Update.
4469         * m2-exp.y: Update all rules.
4470         (yylex): Update.
4471         * go-exp.y (yylex): Update.
4472         * f-exp.y (yylex): Update.
4473         * d-exp.y: Update all rules.
4474         (yylex): Update.
4475         * c-exp.y: Update all rules.
4476         (lex_one_token, classify_name, yylex, c_parse): Update.
4477         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4478
4479 2019-04-04  Tom Tromey  <tom@tromey.com>
4480
4481         * gdbarch.h, gdbarch.c: Rebuild.
4482         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4483         * stap-probe.h:
4484         (struct stap_parse_info): Replace "parser_state" with
4485         "expr_builder".
4486         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4487         (parser_state): New class.
4488         * parse.c (expr_builder): Rename.
4489         (expr_builder::release): Rename.
4490         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4491         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4492         (write_exp_elt_longcst, write_exp_elt_floatcst)
4493         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4494         (write_exp_string_vector, write_exp_bitstring)
4495         (write_exp_msymbol, mark_struct_expression)
4496         (write_dollar_variable)
4497         (insert_type_address_space, increase_expout_size): Replace
4498         "parser_state" with "expr_builder".
4499         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4500         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4501         "parser_state" with "expr_builder".
4502
4503 2019-04-04  Tom Tromey  <tom@tromey.com>
4504
4505         * rust-exp.y: Replace "parse_language" with method call.
4506         * p-exp.y:
4507         (yylex): Replace "parse_language" with method call.
4508         * m2-exp.y:
4509         (yylex): Replace "parse_language" with method call.
4510         * go-exp.y (classify_name): Replace "parse_language" with method
4511         call.
4512         * f-exp.y (yylex): Replace "parse_language" with method call.
4513         * d-exp.y (lex_one_token): Replace "parse_language" with method
4514         call.
4515         * c-exp.y:
4516         (lex_one_token, classify_name, yylex): Replace "parse_language"
4517         with method call.
4518         * ada-exp.y (find_primitive_type, type_char)
4519         (type_system_address): Replace "parse_language" with method call.
4520
4521 2019-04-04  Tom Tromey  <tom@tromey.com>
4522
4523         * rust-exp.y: Replace "parse_gdbarch" with method call.
4524         * parse.c (write_dollar_variable, insert_type_address_space):
4525         Replace "parse_gdbarch" with method call.
4526         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4527         call.
4528         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4529         call.
4530         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4531         "parse_gdbarch" with method call.
4532         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4533         with method call.
4534         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4535         "parse_gdbarch" with method call.
4536         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4537         "parse_gdbarch" with method call.
4538         * c-exp.y (parse_type, parse_number, classify_name): Replace
4539         "parse_gdbarch" with method call.
4540         * ada-lex.l: Replace "parse_gdbarch" with method call.
4541         * ada-exp.y (parse_type, find_primitive_type, type_char)
4542         (type_system_address): Replace "parse_gdbarch" with method call.
4543
4544 2019-04-04  Tom Tromey  <tom@tromey.com>
4545
4546         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4547         * stap-probe.c (stap_parse_argument): Update.
4548         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4549         initial_size parameter.
4550         * rust-exp.y (rust_lex_tests): Update.
4551         * parse.c (parser_state): Update.
4552         (parse_exp_in_context): Update.
4553         * parser-defs.h (struct parser_state) <parser_state>: Remove
4554         "initial_size" parameter.
4555
4556 2019-04-04  Tom Tromey  <tom@tromey.com>
4557
4558         * parser-defs.h (increase_expout_size): Don't declare.
4559         * parse.c (increase_expout_size): Now static.
4560
4561 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4562
4563         * gnu-nat.c (gnu_nat_target::wait): Fix
4564         target_waitstatus_to_string call.
4565
4566 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * eval.c (evaluate_subexp_standard): Handle internal functions
4569         during Fortran function call handling.
4570
4571 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * NEWS: Mention new internal functions.
4574         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4575         (read_base_type): Use dwarf2_init_complex_target_type.
4576         * value.c (creal_internal_fn): New function.
4577         (cimag_internal_fn): New function.
4578         (_initialize_values): Register new internal functions.
4579
4580 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4581
4582         * infrun.c (stop_all_threads): If debug_infrun, always
4583         trace the wait status after wait_one, using
4584         target_waitstatus_to_string and target_pid_to_str.
4585         (handle_inferior_event): Replace various trace of
4586         wait status kind by a single trace.
4587         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4588         wait status kind image by target_waitstatus_to_string.
4589         * target/waitstatus.c (target_waitstatus_to_string): Fix
4590         obsolete comment.
4591
4592 2019-04-01  Tom Tromey  <tromey@adacore.com>
4593
4594         PR symtab/23331:
4595         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4596
4597 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4598             Pedro Alves  <palves@redhat.com>
4599
4600         * top.c (quit_force): Call 'finalize_values'.
4601         * value.c (finalize_values): New function.
4602         * value.h (finalize_values): Declare.
4603
4604 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4605
4606         * NEWS: Announce $_gdb_major and $_gdb_minor.
4607
4608         * top.c (init_gdb_version_vars): New function.
4609         (gdb_init): Call init_gdb_version_vars.
4610
4611 2019-03-29  Tom Tromey  <tromey@adacore.com>
4612
4613         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4614         help text.  Remove dead code.
4615
4616 2019-03-29  Keith Seitz  <keiths@redhat.com>
4617
4618         From Siddhesh Poyarekar:
4619         * f-lang.h (f77_get_upperbound): Return LONGEST.
4620         (f77_get_lowerbound): Likewise.
4621         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4622         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4623         print them.
4624         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4625         plongest to format print it.
4626         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4627         (f77_get_upperbound): Likewise.
4628         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4629         LOWER_BOUND to LONGEST.
4630         (f77_create_arrayprint_offset_tbl): Likewise.
4631
4632 2019-03-29  Keith Seitz  <keiths@redhat.com>
4633
4634         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4635         %s/pulongest for TYPE_LENGTH instead of %d in format
4636         strings.
4637         * ada-typerint.c (ada_print_type): Likewise.
4638         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4639         * compile/compile-c-support.c (generate_register_struct): Likewise.
4640         * gdbtypes.c (recursive_dump_type): Likewise.
4641         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4642         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4643         instead of %d in format strings.
4644         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4645         to std::min to ULONGEST.
4646         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4647         instead of %d in format strings.
4648         * tracepoint.c (info_scope_command): Likewise.
4649         * typeprint.c (print_offset_data::update)
4650         (print_offset_data::finish): Likewise.
4651         * xtensa-tdep.c (xtensa_store_return_value)
4652         (xtensa_push_dummy_call): Likewise.
4653
4654 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4655
4656         * windows-nat.c (display_selector): Fixed format specifications
4657         for 64-bit Cygwin.
4658
4659 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4660
4661         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4662
4663 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4664
4665         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4666         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4667         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4668         (nios2_linux_init_abi): Install it.
4669
4670 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4671
4672         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4673
4674 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4675
4676         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4677
4678 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4679             Tom Tromey  <tromey@adacore.com>
4680
4681         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4682
4683 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4684
4685         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4686         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4687         method to compute the bounds of range types. Also print "[evaluated]"
4688         if the bounds' values come from a dynamic evaluation.
4689
4690 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4693         whitespace when pretty printing is on.
4694
4695 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4696
4697         * ppc-linux-nat.c: Add include.
4698
4699 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4700
4701         * NEWS: Mention AArch64 Pointer Authentication.
4702
4703 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4704
4705         * arm-linux-nat.c: Add include.
4706
4707 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4708
4709         * source-cache.c (source_cache::get_source_lines): Re-read
4710         fullname after calling open_source_file.
4711
4712 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4713
4714         * NEWS: Mention TLS support for FreeBSD.
4715
4716 2019-03-25  Tom Tromey  <tromey@adacore.com>
4717
4718         * minsyms.c (BUNCH_SIZE): Update comment.
4719         (~minimal_symbol_reader): Remove old comment.
4720         (compact_minimal_symbols): Update comment.
4721         (minimal_symbol_reader::install): Remove old comment.  Update
4722         other comments.
4723
4724 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4725
4726         * s390-linux-nat.c: Add include.
4727
4728 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4729
4730         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4731         Call linux_get_hwcap.
4732         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4733         Likewise.
4734         (aarch64_linux_get_hwcap): Remove function.
4735         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4736         declaration.
4737         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4738         linux_get_hwcap.
4739         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4740         * linux-tdep.c (linux_get_hwcap): Add function.
4741         (linux_get_hwcap2): Likewise.
4742         * linux-tdep.h (linux_get_hwcap): Add declaration.
4743         (linux_get_hwcap2): Likewise.
4744         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4745         (ppc_linux_get_hwcap2): Likewise.
4746         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4747         linux_get_hwcap.
4748         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4749         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4750         (ppc_linux_nat_target::read_description): Likewise.
4751         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4752         * s390-linux-nat.c: Likewise.
4753         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4754
4755 2019-03-24  Tom Tromey  <tom@tromey.com>
4756
4757         * ada-lang.c (standard_lookup): Simplify initialization.
4758         (ada_lookup_symbol_nonlocal): Simplify return.
4759         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4760         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4761         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4762         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4763         initialization.
4764         * solib.c (solib_global_lookup): Simplify.
4765         * symtab.c (null_block_symbol): Remove.
4766         (symbol_cache_lookup): Simplify returns.
4767         (lookup_language_this): Simplify returns.
4768         (lookup_symbol_aux): Simplify return.
4769         (lookup_local_symbol): Simplify returns.
4770         (lookup_global_symbol_from_objfile): Simplify return.
4771         (lookup_symbol_in_objfile_symtabs)
4772         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4773         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4774         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4775         * cp-namespace.c (cp_lookup_bare_symbol)
4776         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4777         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4778         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4779         (cp_lookup_symbol_via_imports): Simplify initialization.
4780         (find_symbol_in_baseclass): Likewise.
4781         * symtab.h (null_block_symbol): Remove.
4782         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4783         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4784         (d_lookup_symbol_module): Likewise.
4785         (find_symbol_in_baseclass): Simplify initialization.
4786
4787 2019-03-24  Tom Tromey  <tom@tromey.com>
4788
4789         * expression.h: Don't include symtab.h.
4790         (struct block): Forward declare.
4791
4792 2019-03-24  Tom Tromey  <tom@tromey.com>
4793
4794         * c-exp.y (typebase): Remove casts.
4795         * gdbtypes.c (lookup_unsigned_typename, )
4796         (lookup_signed_typename): Remove cast.
4797         * eval.c (parse_to_comma_and_eval): Remove cast.
4798         * parse.c (write_dollar_variable): Remove cast.
4799         * block.h (struct block) <superblock>: Now const.
4800         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4801         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4802         (map_block): Make "block" const.
4803         * symfile.h (struct quick_symbol_functions)
4804         <map_matching_symbols>: Constify block argument to "callback".
4805         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4806         const.
4807         (find_pc_sect_compunit_symtab): Make "b" const.
4808         (find_symbol_at_address): Likewise.
4809         (search_symbols): Likewise.
4810         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4811         (dw2_debug_names_lookup_symbol): Likewise.
4812         (dw2_map_matching_symbols): Update.
4813         * p-valprint.c (pascal_val_print): Remove "block".
4814         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4815         (aux_add_nonlocal_symbols): Make "block" const.
4816         (resolve_subexp): Remove cast.
4817         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4818         const.
4819         (iterate_over_file_blocks): Likewise.
4820         * f-exp.y (%union) <bval>: Remove.
4821         * coffread.c (patch_opaque_types): Make "b" const.
4822         * spu-tdep.c (spu_catch_start): Make "block" const.
4823         * c-valprint.c (print_unpacked_pointer): Remove "block".
4824         * symmisc.c (dump_symtab_1): Make "b" const.
4825         (block_depth): Make "block" const.
4826         * d-exp.y (%union) <bval>: Remove.
4827         * cp-support.h (cp_lookup_rtti_type): Update.
4828         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4829         * psymtab.c (psym_lookup_symbol): Make "block" const.
4830         (maintenance_check_psymtabs): Make "b" const.
4831         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4832         (enumerate_locals, enumerate_args): Update.
4833         * python/py-symtab.c (stpy_global_block): Make "block" const.
4834         (stpy_static_block): Likewise.
4835         * inline-frame.c (block_starting_point_at): Make "new_block"
4836         const.
4837         * block.c (find_block_in_blockvector): Make return type const.
4838         (blockvector_for_pc_sect): Make "b" const.
4839         (find_block_in_blockvector): Make "b" const.
4840
4841 2019-03-23  Tom Tromey  <tom@tromey.com>
4842
4843         * varobj.c (varobj_create): Update.
4844         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4845         * printcmd.c (display_command, do_one_display): Don't reset
4846         innermost_block.
4847         * parser-defs.h (enum innermost_block_tracker_type): Move to
4848         expression.h.
4849         (innermost_block): Update comment.
4850         * parse.c (parse_exp_1): Add tracker_types parameter.
4851         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4852         tracker_types parameter.  Reset innermost_block.
4853         (parse_exp_in_context): Remove.
4854         (parse_expression_for_completion): Update.
4855         * objfiles.c (~objfile): Don't reset expression_context_block or
4856         innermost_block.
4857         * expression.h (enum innermost_block_tracker_type): Move from
4858         parser-defs.h.
4859         (parse_exp_1): Add tracker_types parameter.
4860         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4861         reset innermost_block.
4862
4863 2019-03-23  Tom Tromey  <tom@tromey.com>
4864
4865         * objfiles.h: Include bcache.h.
4866
4867 2019-03-23  Tom Tromey  <tom@tromey.com>
4868
4869         * linespec.c (get_current_search_block): Use
4870         scoped_restore_current_language.
4871         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4872
4873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4874             Jiong Wang  <jiong.wang@arm.com>
4875
4876         * aarch64-linux-tdep.c
4877         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4878         section.
4879         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4880
4881 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4882             Jiong Wang  <jiong.wang@arm.com>
4883
4884         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4885         instructions.
4886         (aarch64_analyze_prologue_test): Add PACIASP test.
4887         (aarch64_prologue_prev_register): Unmask PC value.
4888
4889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4890             Jiong Wang  <jiong.wang@arm.com>
4891
4892         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4893         (aarch64_dwarf2_prev_register): Unmask PC value.
4894         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4895         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4896         DW_CFA_AARCH64_negate_ra_state.
4897         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4898
4899 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4900             Jiong Wang  <jiong.wang@arm.com>
4901
4902         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4903         registers.
4904         (aarch64_pseudo_register_name): Likewise.
4905         (aarch64_pseudo_register_type): Likewise.
4906         (aarch64_pseudo_register_reggroup_p): Likewise.
4907         (aarch64_gdbarch_init): Add pauth registers.
4908         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4909         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4910         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4911         (struct gdbarch_tdep): Add regnum for ra_state.
4912
4913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4914             Jiong Wang  <jiong.wang@arm.com>
4915
4916         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4917
4918 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4919             Jiong Wang  <jiong.wang@arm.com>
4920
4921         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4922         function.
4923         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4924         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4925         (aarch64_gdbarch_init): Add puth registers.
4926         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4927         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4928         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4929
4930 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4931             Jiong Wang  <jiong.wang@arm.com>
4932
4933         * aarch64-linux-nat.c
4934         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4935         * aarch64-linux-tdep.c
4936         (aarch64_linux_core_read_description): Likewise.
4937         (aarch64_linux_get_hwcap): New function.
4938         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4939         (aarch64_linux_get_hwcap): New declaration.
4940
4941 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4942             Jiong Wang  <jiong.wang@arm.com>
4943
4944         * aarch64-linux-nat.c
4945         (aarch64_linux_nat_target::read_description): Add pauth param.
4946         * aarch64-linux-tdep.c
4947         (aarch64_linux_core_read_description): Likewise.
4948         * aarch64-tdep.c (struct target_desc): Add in pauth.
4949         (aarch64_read_description): Add pauth param.
4950         (aarch64_gdbarch_init): Likewise.
4951         * aarch64-tdep.h (aarch64_read_description): Likewise.
4952         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4953         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4954         * features/Makefile: Add new files.
4955         * features/aarch64-pauth.c: New file.
4956         * features/aarch64-pauth.xml: New file.
4957
4958 2019-03-20  Tom Tromey  <tromey@adacore.com>
4959
4960         * infrun.c (handle_inferior_event): Rename from
4961         handle_inferior_event_1.  Create a scoped_value_mark.
4962         (handle_inferior_event): Remove.
4963
4964 2019-03-19  Tom Tromey  <tromey@adacore.com>
4965
4966         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4967         * infrun.h (print_stop_event): Add "displays" parameter.
4968         * infrun.c (print_stop_event): Add "displays" parameter.
4969
4970 2019-03-19  Pedro Alves  <palves@redhat.com>
4971
4972         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4973         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4974         to -1.  Fix TABs vs spaces.
4975         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4976         * tui/tui-out.h (tui_ui_out) Add intro comments.
4977         <m_line, m_start_of_line>: In-class initialize, and add describing
4978         comment.
4979
4980 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4981
4982         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4983         variable names.
4984         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4985
4986 2019-03-18  Pedro Alves  <palves@redhat.com>
4987             Eli Zaretskii <eliz@gnu.org>
4988
4989         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4990         m_line and m_start_of_line.
4991
4992 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4993
4994         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4995         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4996         it returns a newline.  This fixes a regression in TU mode, whereby
4997         the next line is output on the same screen line as the user input.
4998
4999 2019-03-18  Tom Tromey  <tromey@adacore.com>
5000
5001         * minsyms.c (minimal_symbol_reader::install): Remove call to
5002         obstack_blank.
5003
5004 2019-03-18  Pedro Alves  <palves@redhat.com>
5005
5006         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5007         New globals.
5008         (apply_style): New, factored out from ...
5009         (apply_ansi_escape): ... this.  Handle reverse video mode.
5010         (tui_set_reverse_mode): New function.
5011         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5012         * tui/tui-winsource.c (tui_show_source_line): Use
5013         tui_set_reverse_mode instead of setting A_STANDOUT.
5014         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5015         New setter methods.
5016
5017 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5018
5019         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5020         Handle tabs.
5021
5022 2019-03-18  Tom Tromey  <tromey@adacore.com>
5023
5024         * ada-lang.c (empty_array): Add "high" parameter.
5025         (ada_evaluate_subexp): Update.
5026
5027 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5028
5029         * unittests/string_view-selftests.c: Define
5030         _initialize_string_view_selftests unconditionally.
5031
5032 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5033
5034         PR gdb/24350
5035         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5036
5037 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5038
5039         PR gdb/24351
5040         * windows-nat.c (display_selector): Fix format specifiers.
5041
5042 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5043
5044         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5045         tui_refill_source_window instead of tui_refresh_win, to update the
5046         current execution line.  This fixes redisplay of the current line
5047         when stepping through the code with "next" or "step".
5048
5049 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5050
5051         * source-cache.c (source_cache::get_source_lines): Call
5052         find_source_lines to initialize s->nlines.  This fixes vertical
5053         scrolling of TUI source window when the DOWN arrow is pressed.
5054
5055 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5056
5057         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5058         linux-thread-db.c (_initialize_thread_db): Likewise.
5059
5060 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5061
5062         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5063         wclrtoeol in tui_show_source_line".  This reverts changes made in
5064         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5065
5066 2019-03-15  Tom Tromey  <tom@tromey.com>
5067
5068         * symtab.h (struct minimal_symbol): Derive from
5069         general_symbol_info.
5070         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5071         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5072         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5073         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5074         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5075         (MSYMBOL_SEARCH_NAME): Update.
5076         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5077         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5078         * minsyms.c (minimal_symbol_reader::record_full): Update.
5079
5080 2019-03-15  Tom Tromey  <tom@tromey.com>
5081
5082         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5083
5084 2019-03-15  Tom Tromey  <tom@tromey.com>
5085
5086         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5087         unique_xmalloc_ptr.
5088         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5089         Update.
5090         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5091         (build_minimal_symbol_hash_tables)
5092         (minimal_symbol_reader::install): Update.
5093
5094 2019-03-15  Tom Tromey  <tom@tromey.com>
5095
5096         * symtab.c (create_demangled_names_hash): Update.
5097         (symbol_set_names): Update.
5098         * objfiles.h (struct objfile_per_bfd_storage)
5099         <demangled_names_hash>: Now an htab_up.
5100         * objfiles.c (objfile_per_bfd_storage): Simplify.
5101
5102 2019-03-15  Tom Tromey  <tom@tromey.com>
5103
5104         * objfiles.h (struct objfile_per_bfd_storage): Declare
5105         destructor.
5106         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5107         New.
5108         (get_objfile_bfd_data): Use new.  Don't initialize
5109         language_of_main.
5110         (free_objfile_per_bfd_storage): Remove.
5111         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5112
5113 2019-03-15  Tom Tromey  <tom@tromey.com>
5114
5115         * symfile.c (reread_symbols): Update.
5116         * objfiles.c (objfile::objfile): Update.
5117         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5118         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5119         comment.
5120         (minimal_symbol_reader::install): Update.
5121         (terminate_minimal_symbol_table): Remove.
5122         * jit.c (jit_object_close_impl): Update.
5123
5124 2019-03-15  Tom Tromey  <tom@tromey.com>
5125
5126         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5127         initializations.
5128
5129 2019-03-15  Tom Tromey  <tom@tromey.com>
5130
5131         * objfiles.h (struct objfile_per_bfd_storage)
5132         <demangled_hash_languages>: Now a bitset.
5133         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5134         (lookup_minimal_symbol): Update.
5135
5136 2019-03-15  Tom Tromey  <tom@tromey.com>
5137
5138         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5139         Don't return the symbol.
5140         * coffread.c (record_minimal_symbol): Use record_full.
5141
5142 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5143
5144         The MS-Windows port of ncurses fails to switch to a color pair if
5145         one or both of the colors are the implicit default colors.  This
5146         change records the default colors when TUI is initialized, and
5147         then specifies them explicitly when a color pair uses the default
5148         colors.  This allows color styling in TUI mode on MS-Windows.
5149
5150         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5151         ncurses_norm_attr.
5152         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5153         colors in ncurses_norm_attr.
5154         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5155         "none", replace it with the default color recorded in
5156         ncurses_norm_attr.
5157
5158 2019-03-14  Tom Tromey  <tromey@adacore.com>
5159
5160         * source-cache.h (class source_cache) <get_source_lines>: Return
5161         std::string.
5162         * source-cache.c (source_cache::extract_lines): Handle case where
5163         first_pos==npos.  Return std::string.
5164         (source_cache::get_source_lines): Update.
5165
5166 2019-03-14  Tom Tromey  <tromey@adacore.com>
5167
5168         * NEWS: Add item for "style sources" commands.
5169         * source-cache.c (source_cache::get_source_lines): Check
5170         source_styling.
5171         * cli/cli-style.c (source_styling): New global.
5172         (_initialize_cli_style): Add "style sources" commands.
5173         (show_style_sources): New function.
5174         * cli/cli-style.h (source_styling): Declare.
5175
5176 2019-03-14  Pedro Alves  <palves@redhat.com>
5177             Tom Tromey  <tromey@adacore.com>
5178
5179         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5180         * tui/tui-winsource.c (tui_refill_source_window): New function,
5181         from...
5182         (tui_horizontal_source_scroll): ... here.  Move some logic.
5183         * cli/cli-style.c (set_style_enabled): Notify new observable.
5184         * tui/tui-hooks.c (tui_redisplay_source): New function.
5185         (tui_attach_detach_observers): Attach or detach
5186         tui_redisplay_source.
5187         * observable.h (source_styling_changed): New observable.
5188         * observable.c: Define source_styling_changed observable.
5189
5190 2019-03-13  Tom Tromey  <tromey@adacore.com>
5191
5192         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5193         (i386_gnu_nat_target::store_registers): Update.
5194         * target-debug.h (target_debug_print_std_string): New macro.
5195         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5196         * windows-tdep.c (display_one_tib): Update.
5197         * tui/tui-stack.c (tui_make_status_line): Update.
5198         * top.c (print_inferior_quit_action): Update.
5199         * thread.c (thr_try_catch_cmd): Update.
5200         (add_thread_with_info): Update.
5201         (thread_target_id_str): Update.
5202         (thr_try_catch_cmd): Update.
5203         (thread_command): Update.
5204         (thread_find_command): Update.
5205         * record-btrace.c (record_btrace_target::info_record)
5206         (record_btrace_resume_thread, record_btrace_target::resume)
5207         (record_btrace_cancel_resume, record_btrace_step_thread)
5208         (record_btrace_target::wait, record_btrace_target::wait)
5209         (record_btrace_target::wait, record_btrace_target::stop): Update.
5210         * progspace.c (print_program_space): Update.
5211         * process-stratum-target.c
5212         (process_stratum_target::thread_address_space): Update.
5213         * linux-fork.c (linux_fork_mourn_inferior)
5214         (detach_checkpoint_command, info_checkpoints_command)
5215         (linux_fork_context): Update.
5216         (linux_fork_detach): Update.
5217         (class scoped_switch_fork_info): Update.
5218         (delete_checkpoint_command): Update.
5219         * infrun.c (follow_fork_inferior): Update.
5220         (follow_fork_inferior): Update.
5221         (proceed_after_vfork_done): Update.
5222         (handle_vfork_child_exec_or_exit): Update.
5223         (follow_exec): Update.
5224         (displaced_step_prepare_throw): Update.
5225         (displaced_step_restore): Update.
5226         (start_step_over): Update.
5227         (resume_1): Update.
5228         (clear_proceed_status_thread): Update.
5229         (proceed): Update.
5230         (print_target_wait_results): Update.
5231         (do_target_wait): Update.
5232         (context_switch): Update.
5233         (stop_all_threads): Update.
5234         (restart_threads): Update.
5235         (finish_step_over): Update.
5236         (handle_signal_stop): Update.
5237         (switch_back_to_stepped_thread): Update.
5238         (keep_going_pass_signal): Update.
5239         (print_exited_reason): Update.
5240         (normal_stop): Update.
5241         * inferior.c (inferior_pid_to_str): Change return type.
5242         (print_selected_inferior): Update.
5243         (add_inferior): Update.
5244         (detach_inferior): Update.
5245         * dummy-frame.c (fprint_dummy_frames): Update.
5246         * dcache.c (dcache_info_1): Update.
5247         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5248         (btrace_fetch, btrace_clear): Update.
5249         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5250         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5251         type.
5252         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5253         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5254         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5255         * gdbarch.c, gdbarch.h: Rebuild.
5256         * gdbarch.sh (core_pid_to_str): Change return type.
5257         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5258         return type.
5259         (windows_nat_target::pid_to_str): Change return type.
5260         (windows_delete_thread): Update.
5261         (windows_nat_target::attach): Update.
5262         (windows_nat_target::files_info): Update.
5263         * target-delegates.c: Rebuild.
5264         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5265         return type.
5266         (sol_thread_target::pid_to_str): Change return type.
5267         * remote.c (class remote_target) <pid_to_str>: Change return
5268         type.
5269         (remote_target::pid_to_str): Change return type.
5270         (extended_remote_target::attach, remote_target::remote_stop_ns)
5271         (remote_target::remote_notif_remove_queued_reply)
5272         (remote_target::push_stop_reply, remote_target::disable_btrace):
5273         Update.
5274         (extended_remote_target::attach): Update.
5275         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5276         type.
5277         (gdbsim_target::pid_to_str): Change return type.
5278         * ravenscar-thread.c (struct ravenscar_thread_target)
5279         <pid_to_str>: Change return type.
5280         (ravenscar_thread_target::pid_to_str): Change return type.
5281         * procfs.c (class procfs_target) <pid_to_str>: Change return
5282         type.
5283         (procfs_target::pid_to_str): Change return type.
5284         (procfs_target::attach): Update.
5285         (procfs_target::detach): Update.
5286         (procfs_target::fetch_registers): Update.
5287         (procfs_target::store_registers): Update.
5288         (procfs_target::wait): Update.
5289         (procfs_target::files_info): Update.
5290         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5291         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5292         return type.
5293         (nto_procfs_target::pid_to_str): Change return type.
5294         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5295         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5296         return type.
5297         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5298         (exit_lwp): Update.
5299         (attach_proc_task_lwp_callback, get_detach_signal)
5300         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5301         (linux_nat_target::resume, wait_lwp, stop_callback)
5302         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5303         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5304         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5305         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5306         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5307         type.
5308         (inf_ptrace_target::attach): Update.
5309         (inf_ptrace_target::files_info): Update.
5310         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5311         type.
5312         (go32_nat_target::pid_to_str): Change return type.
5313         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5314         (gnu_nat_target::wait): Update.
5315         (gnu_nat_target::wait): Update.
5316         (gnu_nat_target::resume): Update.
5317         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5318         (fbsd_nat_target::wait): Update.
5319         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5320         type.
5321         (darwin_nat_target::attach): Update.
5322         * corelow.c (class core_target) <pid_to_str>: Change return type.
5323         (core_target::pid_to_str): Change return type.
5324         * target.c (normal_pid_to_str): Change return type.
5325         (default_pid_to_str): Likewise.
5326         (target_pid_to_str): Change return type.
5327         (target_translate_tls_address): Update.
5328         (target_announce_detach): Update.
5329         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5330         return type.
5331         (bsd_uthread_target::pid_to_str): Change return type.
5332         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5333         type.
5334         (bsd_kvm_target::pid_to_str): Change return type.
5335         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5336         return type.
5337         (aix_thread_target::pid_to_str): Change return type.
5338         * target.h (struct target_ops) <pid_to_str>: Change return type.
5339         (target_pid_to_str, normal_pid_to_str): Likewise.
5340         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5341         type.
5342         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5343         type.
5344         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5345         return type.
5346         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5347         type.
5348         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5349         type.
5350         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5351         return type.
5352
5353 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5354
5355         * NEWS: Mention that the new default MI version is 3.  Mention
5356         changes to the output of commands and events that deal with
5357         multi-location breakpoints.
5358         * breakpoint.c: Include "mi/mi-out.h".
5359         (print_one_breakpoint): Change output syntax if using MI version
5360         >= 3.
5361         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5362         New.
5363         (mi_multi_location_breakpoint_output_fixed): New.
5364         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5365         (mi_cmd_fix_multi_location_breakpoint_output): New.
5366         (mi_multi_location_breakpoint_output_fixed): New.
5367         * mi/mi-cmds.c (mi_cmds): Register command
5368         -fix-multi-location-breakpoint-output.
5369         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5370         interpreter "mi".
5371
5372 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5373
5374         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5375         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5376         instantiate mi_ui_out based on interpreter name.
5377         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5378         * mi/mi-main.c (mi_load_progress): Likewise.
5379
5380 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5381
5382         * NEWS: Combine separate "New targets" sections for 8.3.
5383
5384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5385
5386         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5387         (ppcfbsd_init_abi): Install gdbarch
5388         "fetch_tls_load_module_address" and "get_thread_local_address"
5389         methods.
5390
5391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5392
5393         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5394         (riscv_fbsd_init_abi): Install gdbarch
5395         "fetch_tls_load_module_address" and "get_thread_local_address"
5396         methods.
5397
5398 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5399
5400         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5401         (i386fbsd_init_abi): Install gdbarch
5402         "fetch_tls_load_module_address" and "get_thread_local_address"
5403         methods.
5404
5405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5406
5407         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5408         (amd64fbsd_init_abi): Install gdbarch
5409         "fetch_tls_load_module_address" and "get_thread_local_address"
5410         methods.
5411
5412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5413
5414         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5415         (struct fbsd_pspace_data): New type.
5416         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5417         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5418         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5419         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5420         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5421
5422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5423
5424         * gdbtypes.c (lookup_struct_elt): New function.
5425         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5426         * gdbtypes.h (struct struct_elt): New type.
5427         (lookup_struct_elt): New prototype.
5428
5429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5430
5431         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5432         remove disabled code block.
5433
5434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5435
5436         * gdbarch.sh (get_thread_local_address): New method.
5437         * gdbarch.h, gdbarch.c: Regenerate.
5438         * target.c (target_translate_tls_address): Use
5439         gdbarch_get_thread_local_address if present instead of
5440         target::get_thread_local_address.
5441
5442 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5443
5444         * target.h (target::get_thread_local_address): Update comment.
5445
5446 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5447
5448         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5449         objfile->separate_debug_objfile_backlink if not NULL.
5450
5451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5452
5453         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5454         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5455         (amd64bsd_store_inferior_registers): Likewise.
5456         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5457         Enable segment base registers.
5458         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5459         PT_GETFSBASE and PT_GETGSBASE.
5460         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5461         PT_SETGSBASE.
5462         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5463         segment base registers.
5464         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5465
5466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5467
5468         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5469         Update calls to i386_target_description to add 'segments'
5470         parameter.
5471         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5472         add segment base registers.
5473         * arch/i386.c (i386_create_target_description): Add 'segments'
5474         parameter to enable segment base registers.
5475         * arch/i386.h (i386_create_target_description): Likewise.
5476         * features/i386/32bit-segments.xml: New file.
5477         * features/i386/32bit-segments.c: Generate.
5478         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5479         call to i386_target_description to add 'segments' parameter.
5480         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5481         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5482         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5483         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5484         if feature is present.
5485         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5486         Add 'segments' parameter to call to i386_target_description.
5487         (i386_target_description): Add 'segments' parameter to enable
5488         segment base registers.
5489         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5490         to call to i386_target_description.
5491         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5492         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5493         Define I386_NUM_REGS.
5494         (i386_target_description): Add 'segments' parameter to enable
5495         segment base registers.
5496
5497 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5498
5499         PR/24325
5500         * source-cache.c: #undef open and close, to avoid unresolved
5501         externals during linking.
5502
5503 2019-03-12  Tom Tromey  <tromey@adacore.com>
5504
5505         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5506         const.  Add initializers.
5507         (_initialize_remote): Don't initialize ptid globals.
5508
5509 2019-03-12  Pedro Alves  <palves@redhat.com>
5510
5511         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5512
5513 2019-03-12  Pedro Alves  <palves@redhat.com>
5514
5515         * cp-name-parser.y (main): Remove unused 'len' variable.
5516
5517 2019-03-12  Tom Tromey  <tromey@adacore.com>
5518
5519         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5520         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5521
5522 2019-03-12  Tom Tromey  <tromey@adacore.com>
5523
5524         * linux-nat.c (iterate_over_lwps): Update.
5525         (stop_callback): Remove parameter.
5526         (stop_wait_callback, detach_callback, resume_set_callback)
5527         (select_singlestep_lwp_callback, set_ignore_sigint)
5528         (status_callback, resumed_callback, resume_clear_callback)
5529         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5530         data parameter.
5531         (linux_nat_target::detach, linux_nat_target::resume)
5532         (linux_stop_and_wait_all_lwps, select_event_lwp)
5533         (linux_nat_filter_event, linux_nat_wait_1)
5534         (linux_nat_target::kill, linux_nat_target::stop)
5535         (linux_nat_target::stop): Update.
5536         (linux_nat_resume_callback): Change type.
5537         (resume_stopped_resumed_lwps, count_events_callback)
5538         (select_event_lwp_callback): Likewise.
5539         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5540         * arm-linux-nat.c (struct update_registers_data): Remove.
5541         (update_registers_callback): Change type.
5542         (arm_linux_insert_hw_breakpoint1): Update.
5543         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5544         parameter.
5545         (x86_linux_dr_set_addr): Update.
5546         (x86_linux_dr_set_control): Update.
5547         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5548         (iterate_over_lwps): Use gdb::function_view.
5549         * nat/aarch64-linux-hw-point.c (struct
5550         aarch64_dr_update_callback_param): Remove.
5551         (debug_reg_change_callback): Change type.
5552         (aarch64_notify_debug_reg_change): Update.
5553         * s390-linux-nat.c (s390_refresh_per_info): Update.
5554
5555 2019-03-11  Tom Tromey  <tromey@adacore.com>
5556
5557         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5558         redundant assignment to "this_cu".
5559
5560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5561
5562         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5563
5564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5565
5566         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5567         from...
5568         (rank_one_type): ... this.
5569
5570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5571
5572         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5573         from...
5574         (rank_one_type): ... this.
5575
5576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5577
5578         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5579         from...
5580         (rank_one_type): ... this.
5581
5582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5583
5584         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5585         from...
5586         (rank_one_type): ... this.
5587
5588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5589
5590         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5591         from...
5592         (rank_one_type): ... this.
5593
5594 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5595
5596         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5597         from...
5598         (rank_one_type): ... this.
5599
5600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5601
5602         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5603         from...
5604         (rank_one_type): ... this.
5605
5606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5607
5608         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5609         from...
5610         (rank_one_type): ... this.
5611
5612 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5613
5614         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5615         from...
5616         (rank_one_type): ... this.
5617
5618 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5619
5620         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5621         from...
5622         (rank_one_type): ... this.
5623
5624 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5625
5626         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5627         from...
5628         (rank_one_type): ... this.
5629
5630 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5631
5632         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5633         from...
5634         (rank_one_type): ... this.
5635
5636 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5637
5638         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5639         inferior-events' shows the example events.
5640
5641 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5642
5643         Support styling on native MS-Windows console
5644
5645         PR/24315
5646         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5647         on MS-Windows if $TERM is not defined.
5648
5649         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5650
5651         * posix-hdep.c (gdb_console_fputs):
5652         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5653         functions.
5654         * ui-file.h (gdb_console_fputs): Add prototype.
5655
5656         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5657         back to fputs only if the former returns zero.
5658
5659 2019-03-07  Tom Tromey  <tom@tromey.com>
5660
5661         * symmisc.c (print_symbol_bcache_statistics): Update.
5662         (print_objfile_statistics): Update.
5663         * symfile.c (allocate_symtab): Update.
5664         * stabsread.c: Don't include bcache.h.
5665         * psymtab.h (struct psymbol_bcache): Don't declare.
5666         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5667         (psymbol_bcache_init, psymbol_bcache_free)
5668         (psymbol_bcache_get_bcache): Don't declare.
5669         * psymtab.c (struct psymbol_bcache): Remove.
5670         (psymtab_storage::psymtab_storage): Update.
5671         (psymtab_storage::~psymtab_storage): Update.
5672         (psymbol_bcache_init, psymbol_bcache_free)
5673         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5674         (add_psymbol_to_bcache): Update.
5675         (allocate_psymtab): Update.
5676         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5677         macro_cache>: No longer pointers.
5678         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5679         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5680         * macrotab.c (macro_bcache): Update.
5681         * macroexp.c: Don't include bcache.h.
5682         * gdbtypes.c (check_types_worklist): Update.
5683         (types_deeply_equal): Remove TRY/CATCH.  Update.
5684         * elfread.c (elf_symtab_read): Update.
5685         * dwarf2read.c: Don't include bcache.h.
5686         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5687         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5688         (print_bcache_statistics, bcache_memory_used): Don't declare.
5689         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5690         methods.  Rename all data members.
5691         * bcache.c (struct bcache): Move to bcache.h.
5692         (bcache::expand_hash_table): Rename from expand_hash_table.
5693         (bcache): Remove.
5694         (bcache::insert): Rename from bcache_full.
5695         (bcache::compare): Rename from bcache_compare.
5696         (bcache_xmalloc): Remove.
5697         (bcache::~bcache): Rename from bcache_xfree.
5698         (bcache::print_statistics): Rename from print_bcache_statistics.
5699         (bcache::memory_used): Rename from bcache_memory_used.
5700
5701 2019-03-07  Pedro Alves  <palves@redhat.com>
5702
5703         * infrun.c (normal_stop): Also check for
5704         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5705
5706 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         * f-lang.c (value_from_host_double): Moved to...
5709         * value.c (value_from_host_double): ...here.
5710         * value.h (value_from_host_double): Declare.
5711         * guile/scm-math.c (vlscm_convert_typed_number): Use
5712         value_from_host_double.
5713         (vlscm_convert_number): Likewise.
5714         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5715         * python/py-value.c (convert_value_from_python): Likewise.
5716
5717 2019-03-06  Tom Tromey  <tom@tromey.com>
5718
5719         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5720
5721 2019-03-06  Tom Tromey  <tom@tromey.com>
5722
5723         * utils.h (free_current_contents): Don't declare.
5724         * utils.c (free_current_contents): Remove.
5725
5726 2019-03-06  Tom Tromey  <tom@tromey.com>
5727
5728         * top.c (quit_force): Update.
5729         * main.c (captured_command_loop): Update.
5730         * common/new-op.c (operator new): Update.
5731         * common/common-exceptions.c (struct catcher)
5732         <save_cleanup_chain>: Remove member.
5733         (exceptions_state_mc_init): Update.
5734         (exception_try_scope_entry): Return nullptr.
5735         (exception_try_scope_exit, exception_rethrow)
5736         (throw_exception_sjlj, throw_exception_cxx): Update.
5737         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5738         (all_cleanups, do_cleanups, discard_cleanups)
5739         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5740         (restore_cleanups, restore_final_cleanups): Don't declare.
5741         (do_final_cleanups): Remove parameter.
5742         * common/cleanups.c (cleanup_chain, make_cleanup)
5743         (make_cleanup_dtor, all_cleanups, do_cleanups)
5744         (discard_my_cleanups, discard_cleanups)
5745         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5746         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5747         (null_cleanup): Remove.
5748         (do_final_cleanups): Remove parameter.
5749
5750 2019-03-06  Tom Tromey  <tom@tromey.com>
5751
5752         * remote.c (remote_target::remote_parse_stop_reply): Use
5753         unique_xmalloc_ptr.
5754
5755 2019-03-06  Tom Tromey  <tom@tromey.com>
5756
5757         * stabsread.c (struct stabs_field_info): Rename from field_info.
5758         <list, fnlist>: Add initializers.
5759         <obstack>: New member.
5760         (read_member_functions, read_struct_fields, read_baseclasses):
5761         Allocate on obstack.  Don't use cleanups.
5762         (read_one_struct_field, read_member_functions, read_struct_fields)
5763         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5764         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5765         (read_struct_type): Update.
5766
5767 2019-03-06  Tom Tromey  <tom@tromey.com>
5768
5769         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5770         * common/filestuff.h (make_cleanup_close): Don't declare.
5771         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5772         Remove.
5773
5774 2019-03-06  Tom Tromey  <tom@tromey.com>
5775
5776         * solib-aix.c: Use make_scope_exit.
5777
5778 2019-03-06  Tom Tromey  <tom@tromey.com>
5779
5780         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5781         Use make_scope_exit.
5782
5783 2019-03-06  Tom Tromey  <tom@tromey.com>
5784
5785         * solib-svr4.c (disable_probes_interface): Remove parameter.
5786         (svr4_handle_solib_event): Use make_scope_exit.
5787
5788 2019-03-06  Tom Tromey  <tom@tromey.com>
5789
5790         * remote.c (struct stop_reply_deleter): Remove.
5791         (stop_reply_up): Update.
5792         (struct stop_reply): Derive from notif_event.  Don't typedef.
5793         <regcache>: Now a std::vector.
5794         (stop_reply_xfree): Remove.
5795         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5796         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5797         (remote_target::discard_pending_stop_replies): Use delete.
5798         (remote_target::remote_parse_stop_reply): Update.
5799         (remote_target::process_stop_reply): Update.
5800         * remote-notif.h (struct notif_event): Add virtual destructor.
5801         Remove "dtr" member.
5802         (struct notif_client) <alloc_event>: Return a unique_ptr.
5803         (notif_event_xfree): Don't declare.
5804         (notif_event_up): New typedef.
5805         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5806         (notif_event_xfree, do_notif_event_xfree): Remove.
5807         (remote_notif_state_xfree): Update.
5808
5809 2019-03-06  Tom Tromey  <tom@tromey.com>
5810
5811         * infrun.c (displaced_step_clear_cleanup): Now a
5812         forward_scope_exit type.
5813         (displaced_step_prepare_throw): Update.
5814         (displaced_step_fixup): Update.
5815
5816 2019-03-06  Tom Tromey  <tom@tromey.com>
5817
5818         * inferior.h (class inferior): Update comment.
5819         * gdbthread.h (class thread_info): Update comment.
5820
5821 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5822             Tom Tromey  <tom@tromey.com>
5823
5824         * stabsread.h (struct stab_section_list): Remove.
5825         (coffstab_build_psymtabs): Update.
5826         * dbxread.c (symbuf_sections): Now a std::vector.
5827         (sect_idx): New global.
5828         (fill_symbuf): Update.
5829         (coffstab_build_psymtabs): Change type of stabsects parameter.
5830         Update.
5831         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5832         std::vector.
5833         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5834         (coff_locate_sections): Update.
5835         (coff_symfile_read): Remove cleanups.  Update.
5836         (init_stringtab): Add storage parameter.
5837         (free_stringtab, free_stringtab_cleanup): Remove.
5838         (init_lineno): Add storage parameter.
5839         (free_linetab, free_linetab_cleanup): Remove.
5840
5841 2019-03-06  Pedro Alves  <palves@redhat.com>
5842
5843         * linux-fork.c (fork_info::clobber_regs): Delete.
5844         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5845         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5846         comment.  Adjust.
5847         (scoped_switch_fork_info::scoped_switch_fork_info)
5848         (checkpoint_command, linux_fork_context): Adjust
5849         fork_save_infrun_state calls.
5850
5851 2019-03-06  Pedro Alves  <palves@redhat.com>
5852
5853         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5854         (inf_has_multiple_threads): Return 'bool' and rewrite using
5855         inferior_info::threads().
5856
5857 2019-03-06  Pedro Alves  <palves@redhat.com>
5858
5859         * linux-fork.c: Include <list>.
5860         (fork_list): Now a std::list instance.
5861         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5862         (forks_exist_p, find_last_fork): Adjust.
5863         (new_fork): Delete.
5864         (one_fork_p): New.
5865         (add_fork): Adjust.
5866         (free_fork): Delete, folded into fork_info::~fork_info().
5867         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5868         Adjust.
5869         (init_fork_list): Delete.
5870         (linux_fork_killall, linux_fork_mourn_inferior)
5871         (linux_fork_detach, info_checkpoints_command): Adjust.
5872         (_initialize_linux_fork): No longer call init_fork_list.
5873
5874 2019-03-06  Pedro Alves  <palves@redhat.com>
5875
5876         * linux-fork.c (new_fork): New, split out of ...
5877         (add_fork): ... this.  Return void.  Move "first fork" special
5878         case from here, to ...
5879         (checkpoint_command): ... here.
5880         * linux-linux.h (add_fork): Return void.
5881
5882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5885
5886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5887             Chris January  <chris.january@arm.com>
5888             David Lecomber  <david.lecomber@arm.com>
5889
5890         * f-exp.y: New token, UNOP_INTRINSIC.
5891         (exp): New pattern using UNOP_INTRINSIC token.
5892         (f77_keywords): Add 'abs' keyword.
5893         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5894         (value_from_host_double): New function.
5895         (evaluate_subexp_f): Support UNOP_ABS.
5896
5897 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5900         types.
5901
5902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5903
5904         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5905         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5906         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5907
5908 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5909
5910         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5911
5912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5913             Chris January  <chris.january@arm.com>
5914
5915         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5916         * f-exp.y: Define 'KIND' token.
5917         (exp): New pattern for KIND expressions.
5918         (ptype): Handle types with a kind extension.
5919         (direct_abs_decl): Extend to spot kind extensions.
5920         (f77_keywords): Add 'kind' to the list.
5921         (push_kind_type): New function.
5922         (convert_to_kind_type): New function.
5923         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5924         * parse.c (operator_length_standard): Likewise.
5925         * parser-defs.h (enum type_pieces): Add tp_kind.
5926         * std-operator.def: Add UNOP_KIND.
5927
5928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * f-exp.y (f_parse): Set yydebug.
5931
5932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         * f-lang.c (evaluate_subexp_f): New function.
5935         (exp_descriptor_f): New global.
5936         (f_language_defn): Use exp_descriptor_f instead of
5937         exp_descriptor_standard.
5938
5939 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * f-exp.y (struct token): Add comments.
5942         (dot_ops): Remove uppercase versions and the end marker.
5943         (f77_keywords): Likewise.
5944         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5945         entries in the dot_ops array are case insensitive, and use
5946         strncasecmp to compare strings.  Also some whitespace cleanup in
5947         this area.  Similar for the f77_keywords array, except entries in
5948         this list might be case sensitive.
5949
5950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * f-exp.y (struct f77_boolean_val): Add comments.
5953         (boolean_values): Remove uppercase versions, and end marker.
5954         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5955         and use strncasecmp to achieve case insensitivity.  Additionally,
5956         perform whitespace cleanup around this code.
5957
5958 2019-03-06  Tom Tromey  <tromey@adacore.com>
5959
5960         * remote-sim.c (gdbsim_target_open): Use result of
5961         gdb_argv::release.
5962
5963 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5964         Dirk Schubert  <dirk.schubert@arm.com>
5965         Chris January  <chris.january@arm.com>
5966
5967         * eval.c (evaluate_subexp_standard): Call Fortran argument
5968         wrapping logic.
5969         * f-lang.c (struct value): A value which can be passed into a
5970         Fortran function call.
5971         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5972         where appropriate.
5973         (struct type): Value ready for a Fortran function call.
5974         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5975         is needed.
5976         * f-lang.h (fortran_argument_convert): Declaration.
5977         (fortran_preserve_arg_pointer): Declaration.
5978         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5979
5980 2019-03-05  Tom Tromey  <tromey@adacore.com>
5981
5982         * python/py-prettyprint.c (print_string_repr): Remove #if.
5983         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5984
5985 2019-03-05  Tom Tromey  <tromey@adacore.com>
5986
5987         * target.c (the_dummy_target): Move later.  Change type to
5988         "dummy_target".
5989         (initialize_targets): Don't initialize the_dummy_target.
5990
5991 2019-03-05  Tom Tromey  <tromey@adacore.com>
5992
5993         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5994         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5995
5996 2019-03-05  Tom Tromey  <tromey@adacore.com>
5997
5998         * windows-nat.c (windows_nat_target::attach)
5999         (windows_nat_target::detach): Don't call gdb_flush.
6000         * valprint.c (generic_val_print, val_print, val_print_string):
6001         Don't call gdb_flush.
6002         * utils.c (defaulted_query): Don't call gdb_flush.
6003         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6004         * target.c (target_announce_detach): Don't call gdb_flush.
6005         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6006         * remote.c (extended_remote_target::attach): Don't call
6007         gdb_flush.
6008         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6009         * printcmd.c (do_examine): Don't call gdb_flush.
6010         (info_display_command): Don't call gdb_flush.
6011         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6012         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6013         * memattr.c (info_mem_command): Don't call gdb_flush.
6014         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6015         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6016         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6017         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6018         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6019         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6020         (gnu_nat_target::detach): Don't call gdb_flush.
6021         * f-valprint.c (f_val_print): Don't call gdb_flush.
6022         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6023         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6024         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6025         gdb_flush.
6026         * c-valprint.c (c_val_print): Don't call gdb_flush.
6027         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6028
6029 2019-03-05  Tom Tromey  <tromey@adacore.com>
6030
6031         * varobj.c (update_dynamic_varobj_children): Update.
6032         (install_default_visualizer): Use reset, not release.
6033         * value.c (set_internalvar): Update.
6034         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6035         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6036         ATTRIBUTE_UNUSED_RESULT.
6037
6038 2019-03-05  Tom Tromey  <tromey@adacore.com>
6039
6040         * remote.c (class scoped_remote_fd) <release>: Add
6041         ATTRIBUTE_UNUSED_RESULT.
6042
6043 2019-03-05  Tom Tromey  <tromey@adacore.com>
6044
6045         * macroexp.c (struct macro_buffer) <release>: Add
6046         ATTRIBUTE_UNUSED_RESULT.
6047
6048 2019-03-05  Tom Tromey  <tromey@adacore.com>
6049
6050         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6051         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6052         ATTRIBUTE_UNUSED_RESULT.
6053
6054 2019-03-05  Tom Tromey  <tromey@adacore.com>
6055
6056         * common/scoped_fd.h (class scoped_fd) <release>: Add
6057         ATTRIBUTE_UNUSED_RESULT.
6058
6059 2019-03-05  Tom Tromey  <tromey@adacore.com>
6060
6061         * parser-defs.h (struct parser_state) <release>: Add
6062         ATTRIBUTE_UNUSED_RESULT.
6063
6064 2019-03-05  Tom Tromey  <tromey@adacore.com>
6065
6066         * utils.h (class gdb_argv) <release>: Add
6067         ATTRIBUTE_UNUSED_RESULT.
6068         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6069
6070 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6071
6072         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6073         for-loop range, to avoid compiler warnings.
6074
6075         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6076         avoid compiler warnings about unused variables.
6077
6078         * NEWS: Mention end of support for native debugging on MS-Windows
6079         before XP.
6080
6081         PR gdb/24292
6082         * common/netstuff.c:
6083         * gdbserver/gdbreplay.c
6084         * gdbserver/remote-utils.c:
6085         * ser-tcp.c:
6086         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6087         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6088         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6089         'getaddrinfo' and 'freeaddrinfo' were not available before
6090         Windows XP, and mingw.org's MinGW headers by default define
6091         _WIN32_WINNT to 0x500.
6092
6093 2019-03-01  Gary Benson <gbenson@redhat.com>
6094
6095         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6096
6097 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6098             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6099
6100         PR gdb/8527
6101         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6102         set_sigint_trap, clear_sigint_trap.
6103
6104 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6105
6106         * target.c (target_detach): Clear the regcache and the
6107         frame cache.
6108
6109 2019-02-27  Pedro Alves  <palves@redhat.com>
6110
6111         * utils.c (set_screen_size): When we cap the height/width sizes,
6112         tweak the corresponding command variable to show "unlimited":
6113
6114 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6115             Pedro Alves  <palves@redhat.com>
6116
6117         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6118         before calling rl_set_screen_size.
6119
6120 2019-02-27  Tom Tromey  <tromey@adacore.com>
6121
6122         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6123         define.
6124         * python/py-value.c: Remove Python 2.4 workaround.
6125         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6126         workaround.
6127         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6128         Python 2.4 workaround.
6129         * python/python-internal.h: Remove Python 2.4 comment.
6130         (Py_ssize_t): Don't define.
6131         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6132         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6133         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6134         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6135         * python/python.c (do_start_initialization): Remove Python 2.4
6136         workaround.
6137         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6138         (print_children): Remove Python 2.4 workaround.
6139         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6140         workaround.
6141         (CHARBUFFERPROC_NAME): Remove.
6142         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6143         Python 2.4 workaround.
6144
6145 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6146
6147         * NEWS: Note minimum Python version.
6148
6149 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6150
6151         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6152         code from these functions.  Remove corresponding ifdefs.  Use
6153         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6154         Remove gotos and target of gotos.
6155         (infpy_search_memory): Likewise.
6156
6157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6158
6159         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6160         (hppa_gdbarch_init): Don't register deleted functions with
6161         gdbarch.
6162
6163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6164
6165         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6166         (h8300_unwind_sp): Delete.
6167         (h8300_dummy_id): Delete.
6168         (h8300_gdbarch_init): Don't register deleted functions with
6169         gdbarch.
6170
6171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6172
6173         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6174         (ft32_unwind_pc): Delete.
6175         (ft32_unwind_sp): Delete.
6176         (ft32_gdbarch_init): Don't register deleted functions with
6177         gdbarch.
6178
6179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6182         (frv_unwind_pc): Delete.
6183         (frv_unwind_sp): Delete.
6184         (frv_gdbarch_init): Don't register deleted functions with
6185         gdbarch.
6186
6187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6190         (riscv_unwind_pc): Delete.
6191         (riscv_unwind_sp): Delete.
6192         (riscv_gdbarch_init): Don't register deleted functions with
6193         gdbarch.
6194
6195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6196
6197         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6198         (csky_unwind_pc): Delete.
6199         (csky_unwind_sp): Delete.
6200         (csky_gdbarch_init): Don't register deleted functions with
6201         gdbarch.
6202
6203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6204
6205         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6206         (cris_unwind_pc): Delete.
6207         (cris_unwind_sp): Delete.
6208         (cris_gdbarch_init): Don't register deleted functions with
6209         gdbarch.
6210
6211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6214         (bfin_unwind_pc): Delete.
6215         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6216
6217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6218
6219         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6220         (arm_unwind_pc): Delete.
6221         (arm_unwind_sp): Delete.
6222         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6223
6224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6227         (arc_unwind_pc): Delete.
6228         (arc_unwind_sp): Delete.
6229         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6230
6231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6232
6233         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6234         (alpha_unwind_pc): Delete.
6235         (alpha_gdbarch_init): Don't register deleted functions with
6236         gdbarch.
6237
6238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6239
6240         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6241         (aarch64_unwind_pc): Delete.
6242         (aarch64_unwind_sp): Delete.
6243         (aarch64_gdbarch_init): Don't register deleted functions with
6244         gdbarch.
6245
6246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6247
6248         * gdbtypes.c (type_align): Don't consider static members when
6249         computing structure alignment.
6250
6251 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6252
6253         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6254         return 0 for other types.
6255         * arch-utils.c (default_type_align): Always return 0.
6256         * gdbarch.h: Regenerate.
6257         * gdbarch.sh (type_align): Extend comment.
6258         * gdbtypes.c (type_align): Add additional comments, always call
6259         gdbarch_type_align before applying the default rules.
6260         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6261         generic code will then apply a suitable default.
6262         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6263         types, return 0 for other types.
6264
6265 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6266
6267         * NEWS: Create a new section for the next release branch.
6268         Rename the section of the current branch, now that it has
6269         been cut.
6270
6271 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6272
6273         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6274         * version.in: Bump version to 8.3.50.DATE-git.
6275
6276 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6277
6278         * aix-thread.c (ptid_cmp): Remove unused variable.
6279         (get_signaled_thread): Likewise.
6280         (store_regs_user_thread): Likewise.
6281         (store_regs_kernel_thread): Likewise.
6282         (fetch_regs_kernel_thread): Remove shadowed variable.
6283
6284 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6285
6286         * features/riscv/32bit-cpu.xml: Add register numbers.
6287         * features/riscv/32bit-fpu.c: Regenerate.
6288         * features/riscv/32bit-fpu.xml: Add register numbers.
6289         * features/riscv/64bit-cpu.xml: Add register numbers.
6290         * features/riscv/64bit-fpu.c: Regenerate.
6291         * features/riscv/64bit-fpu.xml: Add register numbers.
6292
6293 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6294
6295         * NEWS: Mention two argument form of gdb.Value constructor.
6296         * python/py-value.c (convert_buffer_and_type_to_value): New
6297         function.
6298         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6299         Add support for handling an optional second argument.  Call
6300         convert_buffer_and_type_to_value as appropriate.
6301         * python/python-internal.h (Py_buffer_deleter): New struct.
6302         (Py_buffer_up): New typedef.
6303
6304 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6305
6306         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6307         instead of releasing ownership.
6308
6309 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6310
6311         * dwarf2read.c (open_and_init_dwp_file): Call
6312         elf_numsections instead of bfd_count_sections to initialize
6313         dwp_file->num_sections.
6314
6315 2019-02-25  Tom Tromey  <tromey@adacore.com>
6316
6317         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6318
6319 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6320
6321         * gcore.in: Add '--readnever' option when invoking GDB.
6322
6323 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6324
6325         * MAINTAINERS: Update my email address.
6326
6327 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6328
6329         * build-id.c (build_id_to_debug_bfd_1): New function.
6330         (build_id_to_debug_bfd): Look for separate debug file in
6331         sysroot.
6332
6333 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6334
6335         * gdbarch.sh: Update the copyright year range that is placed into
6336         generated files.
6337
6338 2019-02-22  Keith Seitz  <keiths@redhat.com>
6339
6340         PR symtab/23853
6341         * linespec.c (create_sals_line_offset): Search for the default
6342         symtab's filename instead of its fullname.
6343
6344 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6345
6346         * NEWS: Update style defaults.
6347
6348 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6349
6350         * main.c (captured_main_1): Disable styling in batch mode.
6351
6352 2019-02-20  Tom Tromey  <tom@tromey.com>
6353
6354         * symtab.c (symtab_symbol_info): Fix typos.
6355
6356 2019-02-20  Tom Tromey  <tromey@adacore.com>
6357
6358         * findcmd.c (_initialize_mem_search): Use upper case for
6359         metasyntactic variables.
6360
6361 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6362
6363         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6364         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6365
6366 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6367
6368         * top.h (source_file_name): Change to std::string.
6369         * top.c (source_file_name): Likewise.
6370         (command_line_input): Adjust.
6371         * cli/cli-script.c (script_from_file): Adjust.
6372
6373 2019-02-19  Tom Tromey  <tromey@adacore.com>
6374
6375         * ravenscar-thread.c
6376         (ravenscar_thread_target::update_thread_list): Don't call
6377         ada_build_task_list.
6378         * ada-lang.h (ada_build_task_list): Don't declare.
6379         * ada-tasks.c (struct ada_tasks_inferior_data)
6380         <task_list_valid_p>: Now bool.
6381         (read_known_tasks, ada_task_list_changed)
6382         (ada_tasks_invalidate_inferior_data): Update.
6383         (read_known_tasks_array): Return bool.
6384         (read_known_tasks_list): Likewise.
6385         (read_known_tasks): Return void.
6386         (ada_build_task_list): Now static.
6387
6388 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6391         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6392
6393 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6394
6395         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6396         variant for ada_tasks_pspace_data_handle and
6397         ada_tasks_inferior_data_handle.
6398         (ada_tasks_pspace_data_cleanup): New function.
6399         (ada_tasks_inferior_data_cleanup): New function.
6400
6401 2019-02-17  Tom Tromey  <tom@tromey.com>
6402
6403         * macrotab.h (macro_source_fullname): Return a std::string.
6404         * macrotab.c (macro_include, check_for_redefinition)
6405         (macro_undef, macro_lookup_definition, foreach_macro)
6406         (foreach_macro_in_scope): Update.
6407         (macro_source_fullname): Return a std::string.
6408         * macrocmd.c (show_pp_source_pos): Update.
6409
6410 2019-02-17  Tom Tromey  <tom@tromey.com>
6411
6412         * macrocmd.c (show_pp_source_pos): Style the file names.
6413
6414 2019-02-17  Tom Tromey  <tom@tromey.com>
6415
6416         PR tui/24197:
6417         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6418
6419 2019-02-17  Tom Tromey  <tom@tromey.com>
6420
6421         * ada-lang.c (user_select_syms): Use filtered printing.
6422         * utils.c (wrap_style): New global.
6423         (desired_style): Remove.
6424         (emit_style_escape): Add stream parameter.
6425         (set_output_style, reset_terminal_style, prompt_for_continue):
6426         Update.
6427         (flush_wrap_buffer): Only flush gdb_stdout.
6428         (wrap_here): Set wrap_style.
6429         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6430         treat escape sequences as a character.  Change when wrap buffer is
6431         flushed.
6432         (fputs_styled): Do not set the output style when the default is
6433         requested.
6434         * ui-style.h (struct ui_file_style) <is_default>: New method.
6435         * source.c (print_source_lines_base): Emit escape sequences in one
6436         piece.
6437
6438 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6439
6440         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6441         integers and enumeration types.
6442
6443 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6444
6445         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6446         instead of lookup_symbol_in_language
6447         (do_exact_match): New function.
6448         (ada_get_symbol_name_matcher): Return do_exact_match when
6449         doing a verbatim match.
6450
6451 2019-02-15  Tom Tromey  <tromey@adacore.com>
6452
6453         * ravenscar-thread.c (ravenscar_thread_target::resume)
6454         (ravenscar_thread_target::wait): Special case wildcard requests.
6455
6456 2019-02-15  Tom Tromey  <tromey@adacore.com>
6457
6458         * ravenscar-thread.c (base_ptid): Remove.
6459         (struct ravenscar_thread_target) <close>: New method.
6460         <m_base_ptid>: New member.
6461         <update_inferior_ptid, active_task, task_is_currently_active,
6462         runtime_initialized>: Declare methods.
6463         <ravenscar_thread_target>: Add constructor.
6464         (ravenscar_thread_target::task_is_currently_active)
6465         (ravenscar_thread_target::update_inferior_ptid)
6466         (ravenscar_runtime_initialized): Rename.  Now methods.
6467         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6468         (ravenscar_thread_target::update_thread_list): Update.
6469         (ravenscar_thread_target::active_task): Now method.
6470         (ravenscar_thread_target::store_registers)
6471         (ravenscar_thread_target::prepare_to_store)
6472         (ravenscar_thread_target::prepare_to_store)
6473         (ravenscar_thread_target::mourn_inferior): Update.
6474         (ravenscar_inferior_created): Use "new" to create target.
6475         (ravenscar_thread_target::get_ada_task_ptid): Update.
6476         (_initialize_ravenscar): Don't initialize base_ptid.
6477         (ravenscar_ops): Remove global.
6478
6479 2019-02-15  Tom Tromey  <tromey@adacore.com>
6480
6481         * target.h (push_target): Declare new overload.
6482         * target.c (push_target): New overload, taking an rvalue reference.
6483         * remote.c (remote_target::open_1): Use push_target overload.
6484         * corelow.c (core_target_open): Use push_target overload.
6485
6486 2019-02-15  Tom Tromey  <tromey@adacore.com>
6487
6488         * ravenscar-thread.c (is_ravenscar_task)
6489         (ravenscar_task_is_currently_active): Return bool.
6490         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6491         (_initialize_ravenscar): Remove "(void)".
6492         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6493         Return bool.
6494
6495 2019-02-15  Tom Tromey  <tromey@adacore.com>
6496
6497         * ravenscar-thread.c (ravenscar_runtime_initializer)
6498         (has_ravenscar_runtime, get_running_thread_id)
6499         (ravenscar_thread_target::resume): Fix indentation.
6500
6501 2019-02-15  Tom Tromey  <tromey@adacore.com>
6502
6503         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6504         from ravenscar_arch_ops.
6505         (sparc_ravenscar_ops::fetch_registers)
6506         (sparc_ravenscar_ops::store_registers): Now methods.
6507         (sparc_ravenscar_prepare_to_store): Remove.
6508         (sparc_ravenscar_ops): Redefine.
6509         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6510         methods and destructor.  Remove members.
6511         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6512         (ravenscar_thread_target::store_registers)
6513         (ravenscar_thread_target::prepare_to_store): Update.
6514         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6515         Remove.
6516         (struct ppc_ravenscar_powerpc_ops): Derive from
6517         ravenscar_arch_ops.
6518         (ppc_ravenscar_powerpc_ops::fetch_registers)
6519         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6520         (ppc_ravenscar_powerpc_ops): Redefine.
6521         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6522         (ppc_ravenscar_e500_ops::fetch_registers)
6523         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6524         (ppc_ravenscar_e500_ops): Redefine.
6525         * aarch64-ravenscar-thread.c
6526         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6527         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6528         (aarch64_ravenscar_fetch_registers)
6529         (aarch64_ravenscar_store_registers): Now methods.
6530         (aarch64_ravenscar_ops): Redefine.
6531
6532 2019-02-15  Tom Tromey  <tromey@adacore.com>
6533
6534         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6535         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6536         (ravenscar_thread_target::stopped_by_watchpoint)
6537         (ravenscar_thread_target::stopped_data_address)
6538         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6539
6540 2019-02-15  Tom Tromey  <tromey@adacore.com>
6541
6542         * ravenscar-thread.c: Fix some typos.
6543
6544 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6545             Tom Tromey  <tromey@adacore.com>
6546
6547         * ada-lang.c (ada_exception_sal): Change addr_string to a
6548         std::string.
6549         (create_ada_exception_catchpoint): Update.
6550
6551 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6552             Tom Tromey  <tromey@adacore.com>
6553
6554         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6555         (bp_location_ops): Remove.
6556         (base_breakpoint_allocate_location): Update.
6557         (free_bp_location): Update.
6558         * ada-lang.c (class ada_catchpoint_location)
6559         <ada_catchpoint_location>: Remove ops parameter.
6560         (ada_catchpoint_location_dtor): Remove.
6561         (ada_catchpoint_location_ops): Remove.
6562         (allocate_location_exception): Update.
6563         * breakpoint.h (struct bp_location_ops): Remove.
6564         (class bp_location) <bp_location>: Remove bp_location_ops
6565         parameter.
6566         <~bp_location>: Add destructor.
6567         <ops>: Remove.
6568
6569 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6570             Pedro Alves  <palves@redhat.com>
6571
6572         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6573         'PATH_MAX'.
6574
6575 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6576             Samuel Thibault  <samuel.thibault@gnu.org>
6577             Thomas Schwinge  <thomas@codesourcery.com>
6578
6579         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6580         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6581
6582 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6583
6584         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6585         (check_empty): Use "const char *".
6586
6587         * gnu-nat.c (gnu_nat_target::detach): Instead of
6588         'detach_inferior (pid)' call
6589         'detach_inferior (find_inferior_pid (pid))'.
6590
6591         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6592         'nat/fork-inferior.o'.
6593         * gnu-nat.c: #include "nat/fork-inferior.h".
6594
6595         * gnu-nat.c (gnu_nat_target::detach): Instead of
6596         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6597         * gnu-nat.h: #include "inf-child.h".
6598         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6599         'i386_gnu_nat_target::fetch_registers'.
6600         (gnu_store_registers): Rename/move to
6601         'i386_gnu_nat_target::store_registers'.
6602
6603         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6604         * gnu-nat.h (mach_thread_info): New function.
6605         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6606
6607         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6608
6609 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6610
6611         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6612
6613 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6614
6615         * windows-nat.c (windows_add_thread): Add new parameter
6616         "main_thread_p" with default value set to false.  Update
6617         function documentation as well as all callers.
6618         (windows_delete_thread): Likewise.
6619         (fake_create_process): Update call to windows_add_thread.
6620         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6621         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6622         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6623         call to windows_delete_thread.
6624
6625 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6626
6627         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6628
6629 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6630
6631         * symfile.c (find_separate_debug_file): Use canonical path of
6632         sysroot with child_path instead of gdb_sysroot if it is valid.
6633
6634 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6635
6636         * symfile.c (find_separate_debug_file): Use child_path to
6637         determine if an object file is under a sysroot.
6638
6639 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6640
6641         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6642         unittests/child-path-selftests.c.
6643         * common/pathstuff.c (child_path): New function.
6644         * common/pathstuff.h (child_path): New prototype.
6645         * unittests/child-path-selftests.c: New file.
6646
6647 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6648
6649         * symfile.c (find_separate_debug_file): Look for separate debug
6650         files in debug directories under the sysroot.
6651
6652 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6653
6654         * symtab.h (struct minimal_symbol data_p): New const method.
6655         (struct minimal_symbol text_p): Likewise.
6656         * symtab.c (output_source_filename): Use file name style
6657         to print file name.
6658         (print_symbol_info): Likewise.
6659         (print_msymbol_info): Use address style to print addresses.
6660         Use function name style to print executable text symbols.
6661         (expand_symtab_containing_pc): Use data_p.
6662         (find_pc_sect_compunit_symtab): Likewise.
6663
6664 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6665
6666         * breakpoint.c (describe_other_breakpoints): Use address style
6667         to print addresses.
6668         (say_where): Likewise.
6669
6670 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6671
6672         * ada-typeprint.c (print_func_type): Print function name
6673         style to print function name.
6674         * c-typeprint.c (c_print_type_1): Likewise.
6675
6676 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6677
6678         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6679         for execve.
6680
6681 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6682
6683         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6684         type_stack.
6685
6686 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6687
6688         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6689         TYPE_CODE_REF types.
6690
6691 2019-02-08  Jim Wilson  <jimw@sifive.com>
6692
6693         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6694         (riscv_linux_fregset): New.
6695         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6696
6697 2019-02-07  Tom Tromey  <tom@tromey.com>
6698
6699         * thread.c (thread_cancel_execution_command): Update.
6700         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6701         methods.
6702         (struct thread_fsm_ops): Remove.
6703         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6704         (thread_fsm_should_stop, thread_fsm_return_value)
6705         (thread_fsm_set_finished, thread_fsm_finished_p)
6706         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6707         Don't declare.
6708         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6709         * infrun.c (clear_proceed_status_thread)
6710         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6711         (print_stop_event): Update.
6712         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6713         Add constructor.
6714         (step_command_fsm_ops): Remove.
6715         (new_step_command_fsm): Remove.
6716         (step_1): Update.
6717         (step_command_fsm::should_stop): Rename from
6718         step_command_fsm_should_stop.
6719         (step_command_fsm::clean_up): Rename from
6720         step_command_fsm_clean_up.
6721         (step_command_fsm::do_async_reply_reason): Rename from
6722         step_command_fsm_async_reply_reason.
6723         (struct until_next_fsm): Inherit from thread_fsm.  Add
6724         constructor.
6725         (until_next_fsm_ops): Remove.
6726         (new_until_next_fsm): Remove.
6727         (until_next_fsm::should_stop): Rename from
6728         until_next_fsm_should_stop.
6729         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6730         (until_next_fsm::do_async_reply_reason): Rename from
6731         until_next_fsm_async_reply_reason.
6732         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6733         constructor.  Change type of breakpoint.
6734         (finish_command_fsm_ops): Remove.
6735         (new_finish_command_fsm): Remove.
6736         (finish_command_fsm::should_stop): Rename from
6737         finish_command_fsm_should_stop.
6738         (finish_command_fsm::clean_up): Rename from
6739         finish_command_fsm_clean_up.
6740         (finish_command_fsm::return_value): Rename from
6741         finish_command_fsm_return_value.
6742         (finish_command_fsm::do_async_reply_reason): Rename from
6743         finish_command_fsm_async_reply_reason.
6744         (finish_command): Update.
6745         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6746         Add constructor.
6747         (call_thread_fsm_ops): Remove.
6748         (call_thread_fsm::call_thread_fsm): Rename from
6749         new_call_thread_fsm.
6750         (call_thread_fsm::should_stop): Rename from
6751         call_thread_fsm_should_stop.
6752         (call_thread_fsm::should_notify_stop): Rename from
6753         call_thread_fsm_should_notify_stop.
6754         (run_inferior_call, call_function_by_hand_dummy): Update.
6755         * cli/cli-interp.c (should_print_stop_to_console): Update.
6756         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6757         Add constructor.  Change type of location_breakpoint,
6758         caller_breakpoint.
6759         (until_break_fsm_ops): Remove.
6760         (new_until_break_fsm): Remove.
6761         (until_break_fsm::should_stop): Rename from
6762         until_break_fsm_should_stop.
6763         (until_break_fsm::clean_up): Rename from
6764         until_break_fsm_clean_up.
6765         (until_break_fsm::do_async_reply_reason): Rename from
6766         until_break_fsm_async_reply_reason.
6767         (until_break_command): Update.
6768         * thread-fsm.c: Remove.
6769         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6770
6771 2019-02-07  Tom Tromey  <tom@tromey.com>
6772
6773         * yy-remap.h: Add include guard.
6774         * xtensa-tdep.h: Add include guard.
6775         * xcoffread.h: Rename include guard.
6776         * varobj-iter.h: Add include guard.
6777         * tui/tui.h: Rename include guard.
6778         * tui/tui-winsource.h: Rename include guard.
6779         * tui/tui-wingeneral.h: Rename include guard.
6780         * tui/tui-windata.h: Rename include guard.
6781         * tui/tui-win.h: Rename include guard.
6782         * tui/tui-stack.h: Rename include guard.
6783         * tui/tui-source.h: Rename include guard.
6784         * tui/tui-regs.h: Rename include guard.
6785         * tui/tui-out.h: Rename include guard.
6786         * tui/tui-layout.h: Rename include guard.
6787         * tui/tui-io.h: Rename include guard.
6788         * tui/tui-hooks.h: Rename include guard.
6789         * tui/tui-file.h: Rename include guard.
6790         * tui/tui-disasm.h: Rename include guard.
6791         * tui/tui-data.h: Rename include guard.
6792         * tui/tui-command.h: Rename include guard.
6793         * tic6x-tdep.h: Add include guard.
6794         * target/waitstatus.h: Rename include guard.
6795         * target/wait.h: Rename include guard.
6796         * target/target.h: Rename include guard.
6797         * target/resume.h: Rename include guard.
6798         * target-float.h: Rename include guard.
6799         * stabsread.h: Add include guard.
6800         * rs6000-tdep.h: Add include guard.
6801         * riscv-fbsd-tdep.h: Add include guard.
6802         * regformats/regdef.h: Rename include guard.
6803         * record.h: Rename include guard.
6804         * python/python.h: Rename include guard.
6805         * python/python-internal.h: Rename include guard.
6806         * python/py-stopevent.h: Rename include guard.
6807         * python/py-ref.h: Rename include guard.
6808         * python/py-record.h: Rename include guard.
6809         * python/py-record-full.h: Rename include guard.
6810         * python/py-record-btrace.h: Rename include guard.
6811         * python/py-instruction.h: Rename include guard.
6812         * python/py-events.h: Rename include guard.
6813         * python/py-event.h: Rename include guard.
6814         * procfs.h: Add include guard.
6815         * proc-utils.h: Add include guard.
6816         * p-lang.h: Add include guard.
6817         * or1k-tdep.h: Rename include guard.
6818         * observable.h: Rename include guard.
6819         * nto-tdep.h: Rename include guard.
6820         * nat/x86-linux.h: Rename include guard.
6821         * nat/x86-linux-dregs.h: Rename include guard.
6822         * nat/x86-gcc-cpuid.h: Add include guard.
6823         * nat/x86-dregs.h: Rename include guard.
6824         * nat/x86-cpuid.h: Rename include guard.
6825         * nat/ppc-linux.h: Rename include guard.
6826         * nat/mips-linux-watch.h: Rename include guard.
6827         * nat/linux-waitpid.h: Rename include guard.
6828         * nat/linux-ptrace.h: Rename include guard.
6829         * nat/linux-procfs.h: Rename include guard.
6830         * nat/linux-osdata.h: Rename include guard.
6831         * nat/linux-nat.h: Rename include guard.
6832         * nat/linux-namespaces.h: Rename include guard.
6833         * nat/linux-btrace.h: Rename include guard.
6834         * nat/glibc_thread_db.h: Rename include guard.
6835         * nat/gdb_thread_db.h: Rename include guard.
6836         * nat/gdb_ptrace.h: Rename include guard.
6837         * nat/fork-inferior.h: Rename include guard.
6838         * nat/amd64-linux-siginfo.h: Rename include guard.
6839         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6840         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6841         * nat/aarch64-linux.h: Rename include guard.
6842         * nat/aarch64-linux-hw-point.h: Rename include guard.
6843         * mn10300-tdep.h: Add include guard.
6844         * mips-linux-tdep.h: Add include guard.
6845         * mi/mi-parse.h: Rename include guard.
6846         * mi/mi-out.h: Rename include guard.
6847         * mi/mi-main.h: Rename include guard.
6848         * mi/mi-interp.h: Rename include guard.
6849         * mi/mi-getopt.h: Rename include guard.
6850         * mi/mi-console.h: Rename include guard.
6851         * mi/mi-common.h: Rename include guard.
6852         * mi/mi-cmds.h: Rename include guard.
6853         * mi/mi-cmd-break.h: Rename include guard.
6854         * m2-lang.h: Add include guard.
6855         * location.h: Rename include guard.
6856         * linux-record.h: Rename include guard.
6857         * linux-nat.h: Add include guard.
6858         * linux-fork.h: Add include guard.
6859         * i386-darwin-tdep.h: Rename include guard.
6860         * hppa-linux-offsets.h: Add include guard.
6861         * guile/guile.h: Rename include guard.
6862         * guile/guile-internal.h: Rename include guard.
6863         * gnu-nat.h: Rename include guard.
6864         * gdb-stabs.h: Rename include guard.
6865         * frv-tdep.h: Add include guard.
6866         * f-lang.h: Add include guard.
6867         * event-loop.h: Add include guard.
6868         * darwin-nat.h: Rename include guard.
6869         * cp-abi.h: Rename include guard.
6870         * config/sparc/nm-sol2.h: Rename include guard.
6871         * config/nm-nto.h: Rename include guard.
6872         * config/nm-linux.h: Add include guard.
6873         * config/i386/nm-i386gnu.h: Rename include guard.
6874         * config/djgpp/nl_types.h: Rename include guard.
6875         * config/djgpp/langinfo.h: Rename include guard.
6876         * compile/gcc-cp-plugin.h: Add include guard.
6877         * compile/gcc-c-plugin.h: Add include guard.
6878         * compile/compile.h: Rename include guard.
6879         * compile/compile-object-run.h: Rename include guard.
6880         * compile/compile-object-load.h: Rename include guard.
6881         * compile/compile-internal.h: Rename include guard.
6882         * compile/compile-cplus.h: Rename include guard.
6883         * compile/compile-c.h: Rename include guard.
6884         * common/xml-utils.h: Rename include guard.
6885         * common/x86-xstate.h: Rename include guard.
6886         * common/version.h: Rename include guard.
6887         * common/vec.h: Rename include guard.
6888         * common/tdesc.h: Rename include guard.
6889         * common/selftest.h: Rename include guard.
6890         * common/scoped_restore.h: Rename include guard.
6891         * common/scoped_mmap.h: Rename include guard.
6892         * common/scoped_fd.h: Rename include guard.
6893         * common/safe-iterator.h: Rename include guard.
6894         * common/run-time-clock.h: Rename include guard.
6895         * common/refcounted-object.h: Rename include guard.
6896         * common/queue.h: Rename include guard.
6897         * common/ptid.h: Rename include guard.
6898         * common/print-utils.h: Rename include guard.
6899         * common/preprocessor.h: Rename include guard.
6900         * common/pathstuff.h: Rename include guard.
6901         * common/observable.h: Rename include guard.
6902         * common/netstuff.h: Rename include guard.
6903         * common/job-control.h: Rename include guard.
6904         * common/host-defs.h: Rename include guard.
6905         * common/gdb_wait.h: Rename include guard.
6906         * common/gdb_vecs.h: Rename include guard.
6907         * common/gdb_unlinker.h: Rename include guard.
6908         * common/gdb_unique_ptr.h: Rename include guard.
6909         * common/gdb_tilde_expand.h: Rename include guard.
6910         * common/gdb_sys_time.h: Rename include guard.
6911         * common/gdb_string_view.h: Rename include guard.
6912         * common/gdb_splay_tree.h: Rename include guard.
6913         * common/gdb_setjmp.h: Rename include guard.
6914         * common/gdb_ref_ptr.h: Rename include guard.
6915         * common/gdb_optional.h: Rename include guard.
6916         * common/gdb_locale.h: Rename include guard.
6917         * common/gdb_assert.h: Rename include guard.
6918         * common/filtered-iterator.h: Rename include guard.
6919         * common/filestuff.h: Rename include guard.
6920         * common/fileio.h: Rename include guard.
6921         * common/environ.h: Rename include guard.
6922         * common/common-utils.h: Rename include guard.
6923         * common/common-types.h: Rename include guard.
6924         * common/common-regcache.h: Rename include guard.
6925         * common/common-inferior.h: Rename include guard.
6926         * common/common-gdbthread.h: Rename include guard.
6927         * common/common-exceptions.h: Rename include guard.
6928         * common/common-defs.h: Rename include guard.
6929         * common/common-debug.h: Rename include guard.
6930         * common/cleanups.h: Rename include guard.
6931         * common/buffer.h: Rename include guard.
6932         * common/btrace-common.h: Rename include guard.
6933         * common/break-common.h: Rename include guard.
6934         * cli/cli-utils.h: Rename include guard.
6935         * cli/cli-style.h: Rename include guard.
6936         * cli/cli-setshow.h: Rename include guard.
6937         * cli/cli-script.h: Rename include guard.
6938         * cli/cli-interp.h: Rename include guard.
6939         * cli/cli-decode.h: Rename include guard.
6940         * cli/cli-cmds.h: Rename include guard.
6941         * charset-list.h: Add include guard.
6942         * buildsym-legacy.h: Rename include guard.
6943         * bfin-tdep.h: Add include guard.
6944         * ax.h: Rename include guard.
6945         * arm-linux-tdep.h: Add include guard.
6946         * arm-fbsd-tdep.h: Add include guard.
6947         * arch/xtensa.h: Rename include guard.
6948         * arch/tic6x.h: Add include guard.
6949         * arch/i386.h: Add include guard.
6950         * arch/arm.h: Rename include guard.
6951         * arch/arm-linux.h: Rename include guard.
6952         * arch/arm-get-next-pcs.h: Rename include guard.
6953         * arch/amd64.h: Add include guard.
6954         * arch/aarch64-insn.h: Rename include guard.
6955         * arch-utils.h: Rename include guard.
6956         * annotate.h: Add include guard.
6957         * amd64-darwin-tdep.h: Rename include guard.
6958         * aarch64-linux-tdep.h: Add include guard.
6959         * aarch64-fbsd-tdep.h: Add include guard.
6960         * aarch32-linux-nat.h: Add include guard.
6961
6962 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6963
6964         * macrotab.c (macro_define_internal): New function that
6965         factorizes macro_define_object_internal and macro_define_function
6966         code.
6967         (macro_define_object_internal): Use macro_define_internal.
6968         (macro_define_function): Likewise.
6969
6970 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6971
6972         * macrocmd.c (extract_identifier): Return
6973         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6974         callers.
6975
6976 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6977
6978         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6979
6980 2019-02-05  Tom Tromey  <tom@tromey.com>
6981
6982         * target.c (target_stack::unpush): Move assertion earlier.
6983
6984 2019-01-30  Tom Tromey  <tom@tromey.com>
6985
6986         PR python/23615:
6987         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6988         (gdbpy_parse_and_eval): Likewise.
6989         * python/python-internal.h (gdbpy_allow_threads): New class.
6990
6991 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6992
6993         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6994         (aarch64_fbsd_fpregmap): Move earlier.
6995         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6996         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6997         instead of individual calls to trad_frame_set_reg_addr.
6998         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6999         earlier.
7000         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7001         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7002         instead of individual calls to trad_frame_set_reg_addr.
7003
7004 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7005
7006         * CONTRIBUTE: Replace contribution list with wiki link.
7007
7008 2019-01-25  Tom Tromey  <tom@tromey.com>
7009
7010         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7011
7012 2019-01-25  Tom Tromey  <tom@tromey.com>
7013
7014         * xtensa-linux-nat.c: Fix common/ includes.
7015         * xml-support.h: Fix common/ includes.
7016         * xml-support.c: Fix common/ includes.
7017         * x86-linux-nat.c: Fix common/ includes.
7018         * windows-nat.c: Fix common/ includes.
7019         * varobj.h: Fix common/ includes.
7020         * varobj.c: Fix common/ includes.
7021         * value.c: Fix common/ includes.
7022         * valops.c: Fix common/ includes.
7023         * utils.c: Fix common/ includes.
7024         * unittests/xml-utils-selftests.c: Fix common/ includes.
7025         * unittests/utils-selftests.c: Fix common/ includes.
7026         * unittests/unpack-selftests.c: Fix common/ includes.
7027         * unittests/tracepoint-selftests.c: Fix common/ includes.
7028         * unittests/style-selftests.c: Fix common/ includes.
7029         * unittests/string_view-selftests.c: Fix common/ includes.
7030         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7031         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7032         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7033         * unittests/rsp-low-selftests.c: Fix common/ includes.
7034         * unittests/parse-connection-spec-selftests.c: Fix common/
7035         includes.
7036         * unittests/optional-selftests.c: Fix common/ includes.
7037         * unittests/offset-type-selftests.c: Fix common/ includes.
7038         * unittests/observable-selftests.c: Fix common/ includes.
7039         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7040         * unittests/memrange-selftests.c: Fix common/ includes.
7041         * unittests/memory-map-selftests.c: Fix common/ includes.
7042         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7043         * unittests/function-view-selftests.c: Fix common/ includes.
7044         * unittests/environ-selftests.c: Fix common/ includes.
7045         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7046         * unittests/common-utils-selftests.c: Fix common/ includes.
7047         * unittests/cli-utils-selftests.c: Fix common/ includes.
7048         * unittests/array-view-selftests.c: Fix common/ includes.
7049         * ui-file.c: Fix common/ includes.
7050         * tui/tui-io.c: Fix common/ includes.
7051         * tracepoint.h: Fix common/ includes.
7052         * tracepoint.c: Fix common/ includes.
7053         * tracefile-tfile.c: Fix common/ includes.
7054         * top.h: Fix common/ includes.
7055         * top.c: Fix common/ includes.
7056         * thread.c: Fix common/ includes.
7057         * target/waitstatus.h: Fix common/ includes.
7058         * target/waitstatus.c: Fix common/ includes.
7059         * target.h: Fix common/ includes.
7060         * target.c: Fix common/ includes.
7061         * target-memory.c: Fix common/ includes.
7062         * target-descriptions.c: Fix common/ includes.
7063         * symtab.h: Fix common/ includes.
7064         * symfile.c: Fix common/ includes.
7065         * stap-probe.c: Fix common/ includes.
7066         * spu-linux-nat.c: Fix common/ includes.
7067         * sparc-nat.c: Fix common/ includes.
7068         * source.c: Fix common/ includes.
7069         * solib.c: Fix common/ includes.
7070         * solib-target.c: Fix common/ includes.
7071         * ser-unix.c: Fix common/ includes.
7072         * ser-tcp.c: Fix common/ includes.
7073         * ser-pipe.c: Fix common/ includes.
7074         * ser-base.c: Fix common/ includes.
7075         * selftest-arch.c: Fix common/ includes.
7076         * s12z-tdep.c: Fix common/ includes.
7077         * rust-exp.y: Fix common/ includes.
7078         * rs6000-aix-tdep.c: Fix common/ includes.
7079         * riscv-tdep.c: Fix common/ includes.
7080         * remote.c: Fix common/ includes.
7081         * remote-notif.h: Fix common/ includes.
7082         * remote-fileio.h: Fix common/ includes.
7083         * remote-fileio.c: Fix common/ includes.
7084         * regcache.h: Fix common/ includes.
7085         * regcache.c: Fix common/ includes.
7086         * record-btrace.c: Fix common/ includes.
7087         * python/python.c: Fix common/ includes.
7088         * python/py-type.c: Fix common/ includes.
7089         * python/py-inferior.c: Fix common/ includes.
7090         * progspace.h: Fix common/ includes.
7091         * producer.c: Fix common/ includes.
7092         * procfs.c: Fix common/ includes.
7093         * proc-api.c: Fix common/ includes.
7094         * printcmd.c: Fix common/ includes.
7095         * ppc-linux-nat.c: Fix common/ includes.
7096         * parser-defs.h: Fix common/ includes.
7097         * osdata.c: Fix common/ includes.
7098         * obsd-nat.c: Fix common/ includes.
7099         * nat/x86-linux.c: Fix common/ includes.
7100         * nat/x86-linux-dregs.c: Fix common/ includes.
7101         * nat/x86-dregs.h: Fix common/ includes.
7102         * nat/x86-dregs.c: Fix common/ includes.
7103         * nat/ppc-linux.c: Fix common/ includes.
7104         * nat/mips-linux-watch.h: Fix common/ includes.
7105         * nat/mips-linux-watch.c: Fix common/ includes.
7106         * nat/linux-waitpid.c: Fix common/ includes.
7107         * nat/linux-ptrace.h: Fix common/ includes.
7108         * nat/linux-ptrace.c: Fix common/ includes.
7109         * nat/linux-procfs.c: Fix common/ includes.
7110         * nat/linux-personality.c: Fix common/ includes.
7111         * nat/linux-osdata.c: Fix common/ includes.
7112         * nat/linux-namespaces.c: Fix common/ includes.
7113         * nat/linux-btrace.h: Fix common/ includes.
7114         * nat/linux-btrace.c: Fix common/ includes.
7115         * nat/fork-inferior.c: Fix common/ includes.
7116         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7117         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7118         * nat/aarch64-linux.c: Fix common/ includes.
7119         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7120         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7121         * namespace.h: Fix common/ includes.
7122         * mips-linux-tdep.c: Fix common/ includes.
7123         * minsyms.c: Fix common/ includes.
7124         * mi/mi-parse.h: Fix common/ includes.
7125         * mi/mi-main.c: Fix common/ includes.
7126         * mi/mi-cmd-env.c: Fix common/ includes.
7127         * memrange.h: Fix common/ includes.
7128         * memattr.c: Fix common/ includes.
7129         * maint.h: Fix common/ includes.
7130         * maint.c: Fix common/ includes.
7131         * main.c: Fix common/ includes.
7132         * machoread.c: Fix common/ includes.
7133         * location.c: Fix common/ includes.
7134         * linux-thread-db.c: Fix common/ includes.
7135         * linux-nat.c: Fix common/ includes.
7136         * linux-fork.c: Fix common/ includes.
7137         * inline-frame.c: Fix common/ includes.
7138         * infrun.c: Fix common/ includes.
7139         * inflow.c: Fix common/ includes.
7140         * inferior.h: Fix common/ includes.
7141         * inferior.c: Fix common/ includes.
7142         * infcmd.c: Fix common/ includes.
7143         * inf-ptrace.c: Fix common/ includes.
7144         * inf-child.c: Fix common/ includes.
7145         * ia64-linux-nat.c: Fix common/ includes.
7146         * i387-tdep.c: Fix common/ includes.
7147         * i386-tdep.c: Fix common/ includes.
7148         * i386-linux-tdep.c: Fix common/ includes.
7149         * i386-linux-nat.c: Fix common/ includes.
7150         * i386-go32-tdep.c: Fix common/ includes.
7151         * i386-fbsd-tdep.c: Fix common/ includes.
7152         * i386-fbsd-nat.c: Fix common/ includes.
7153         * guile/scm-type.c: Fix common/ includes.
7154         * guile/guile.c: Fix common/ includes.
7155         * go32-nat.c: Fix common/ includes.
7156         * gnu-nat.c: Fix common/ includes.
7157         * gdbthread.h: Fix common/ includes.
7158         * gdbarch-selftests.c: Fix common/ includes.
7159         * gdb_usleep.c: Fix common/ includes.
7160         * gdb_select.h: Fix common/ includes.
7161         * gdb_bfd.c: Fix common/ includes.
7162         * gcore.c: Fix common/ includes.
7163         * fork-child.c: Fix common/ includes.
7164         * findvar.c: Fix common/ includes.
7165         * fbsd-nat.c: Fix common/ includes.
7166         * event-top.c: Fix common/ includes.
7167         * event-loop.c: Fix common/ includes.
7168         * dwarf2read.c: Fix common/ includes.
7169         * dwarf2loc.c: Fix common/ includes.
7170         * dwarf2-frame.c: Fix common/ includes.
7171         * dwarf-index-cache.c: Fix common/ includes.
7172         * dtrace-probe.c: Fix common/ includes.
7173         * disasm-selftests.c: Fix common/ includes.
7174         * defs.h: Fix common/ includes.
7175         * csky-tdep.c: Fix common/ includes.
7176         * cp-valprint.c: Fix common/ includes.
7177         * cp-support.h: Fix common/ includes.
7178         * cp-support.c: Fix common/ includes.
7179         * corelow.c: Fix common/ includes.
7180         * completer.h: Fix common/ includes.
7181         * completer.c: Fix common/ includes.
7182         * compile/compile.c: Fix common/ includes.
7183         * compile/compile-loc2c.c: Fix common/ includes.
7184         * compile/compile-cplus-types.c: Fix common/ includes.
7185         * compile/compile-cplus-symbols.c: Fix common/ includes.
7186         * command.h: Fix common/ includes.
7187         * cli/cli-dump.c: Fix common/ includes.
7188         * cli/cli-cmds.c: Fix common/ includes.
7189         * charset.c: Fix common/ includes.
7190         * build-id.c: Fix common/ includes.
7191         * btrace.h: Fix common/ includes.
7192         * btrace.c: Fix common/ includes.
7193         * breakpoint.h: Fix common/ includes.
7194         * breakpoint.c: Fix common/ includes.
7195         * ax.h:
7196         (enum agent_op): Fix common/ includes.
7197         * ax-general.c (struct aop_map): Fix common/ includes.
7198         * ax-gdb.c: Fix common/ includes.
7199         * auxv.c: Fix common/ includes.
7200         * auto-load.c: Fix common/ includes.
7201         * arm-tdep.c: Fix common/ includes.
7202         * arch/riscv.c: Fix common/ includes.
7203         * arch/ppc-linux-common.c: Fix common/ includes.
7204         * arch/i386.c: Fix common/ includes.
7205         * arch/arm.c: Fix common/ includes.
7206         * arch/arm-linux.c: Fix common/ includes.
7207         * arch/arm-get-next-pcs.c: Fix common/ includes.
7208         * arch/amd64.c: Fix common/ includes.
7209         * arch/aarch64.c: Fix common/ includes.
7210         * arch/aarch64-insn.c: Fix common/ includes.
7211         * arch-utils.c: Fix common/ includes.
7212         * amd64-windows-tdep.c: Fix common/ includes.
7213         * amd64-tdep.c: Fix common/ includes.
7214         * amd64-sol2-tdep.c: Fix common/ includes.
7215         * amd64-obsd-tdep.c: Fix common/ includes.
7216         * amd64-nbsd-tdep.c: Fix common/ includes.
7217         * amd64-linux-tdep.c: Fix common/ includes.
7218         * amd64-linux-nat.c: Fix common/ includes.
7219         * amd64-fbsd-tdep.c: Fix common/ includes.
7220         * amd64-fbsd-nat.c: Fix common/ includes.
7221         * amd64-dicos-tdep.c: Fix common/ includes.
7222         * amd64-darwin-tdep.c: Fix common/ includes.
7223         * agent.c: Fix common/ includes.
7224         * ada-lang.h: Fix common/ includes.
7225         * ada-lang.c: Fix common/ includes.
7226         * aarch64-tdep.c: Fix common/ includes.
7227
7228 2019-01-25  Tom Tromey  <tom@tromey.com>
7229
7230         * common/create-version.sh: Use common/version.h.
7231
7232 2019-01-24  Pedro Alves  <palves@redhat.com>
7233
7234         * infrun.c (signal_stop, signal_print, signal_program)
7235         (signal_catch, signal_pass): Now arrays instead of pointers.
7236         (update_signals_program_target, do_target_resume)
7237         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7238         * linux-nat.c (linux_nat_target::pass_signals)
7239         (linux_nat_target::create_inferior, linux_nat_target::attach):
7240         Adjust.
7241         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7242         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7243         * procfs.c (procfs_target::pass_signals): Adjust.
7244         * record-full.c (record_full_target::resume): Adjust.
7245         * remote.c (remote_target::pass_signals)
7246         (remote_target::program_signals): Adjust.
7247         * target-debug.h (target_debug_print_signals): Now takes a
7248         gdb::array_view as parameter.  Adjust.
7249         * target.h (target_ops) <pass_signals, program_signals>: Replace
7250         pointer and length parameters with gdb::array_view.
7251         (target_pass_signals, target_program_signals): Likewise.
7252         * target-delegates.c: Regenerate.
7253
7254 2019-01-24  Pedro Alves  <palves@redhat.com>
7255
7256         * common/forward-scope-exit.h
7257         (forward_scope_exit::forward_scope_exit): Pass arguments to
7258         m_bind_function directly, instead of creating a std::bind and
7259         copying that.
7260
7261 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7262
7263         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7264         for static members.
7265         (pass_in_v_vfp_candidate): Likewise.
7266
7267 2019-01-23  Tom Tromey  <tom@tromey.com>
7268             Pedro Alves  <palves@redhat.com>
7269
7270         * regcache.c (class regcache_invalidator): Remove.
7271         (regcache::raw_write): Use make_scope_exit.
7272
7273 2019-01-23  Tom Tromey  <tom@tromey.com>
7274
7275         * ui-out.h (class ui_out_emit_type): Update comment.
7276
7277 2019-01-23  Tom Tromey  <tom@tromey.com>
7278
7279         * infrun.c (fetch_inferior_event): Update comment.
7280
7281 2019-01-23  Tom Tromey  <tom@tromey.com>
7282             Pedro Alves  <palves@redhat.com>
7283
7284         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7285         parameter.
7286         (fetch_inferior_event): Use SCOPE_EXIT.
7287
7288
7289 2019-01-23  Tom Tromey  <tom@tromey.com>
7290             Pedro Alves  <palves@redhat.com>
7291
7292         * infrun.c (disable_thread_events): Delete.
7293         (stop_all_threads): Use SCOPE_EXIT.
7294
7295 2019-01-23  Tom Tromey  <tom@tromey.com>
7296             Pedro Alves  <palves@redhat.com>
7297
7298         * symfile.c: Include forward-scope-exit.h.
7299         (clear_symtab_users_cleanup): Replace forward declaration with
7300         a FORWARD_SCOPE_EXIT.
7301         (syms_from_objfile_1): Use the forward_scope_exit and
7302         gdb::optional instead of cleanup_function.
7303         (reread_symbols): Use the forward_scope_exit instead of
7304         cleanup_function.
7305         (clear_symtab_users_cleanup): Remove function.
7306
7307 2019-01-23  Tom Tromey  <tom@tromey.com>
7308             Pedro Alves  <palves@redhat.com>
7309
7310         * linux-nat.c: Include scope-exit.h.
7311         (cleanup_target_stop): Remove.
7312         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7313         SCOPE_EXIT.
7314
7315 2019-01-23  Tom Tromey  <tom@tromey.com>
7316             Pedro Alves  <palves@redhat.com>
7317
7318         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7319         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7320
7321 2019-01-23  Tom Tromey  <tom@tromey.com>
7322             Andrew Burgess  <andrew.burgess@embecosm.com>
7323             Pedro Alves  <palves@redhat.com>
7324
7325         * infrun.c (fetch_inferior_event): Use scope_exit.
7326         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7327         * top.c (execute_command): Use scope_exit.
7328         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7329         * utils.c (do_bpstat_clear_actions_cleanup)
7330         (make_bpstat_clear_actions_cleanup): Remove.
7331
7332 2019-01-23  Tom Tromey  <tom@tromey.com>
7333             Pedro Alves  <palves@redhat.com>
7334
7335         * infrun.c: Include "common/scope-exit.h"
7336         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7337         (wait_for_inferior): Use SCOPE_EXIT.
7338         (fetch_inferior_event): Use scope_exit.
7339
7340 2019-01-23  Tom Tromey  <tom@tromey.com>
7341             Pedro Alves  <palves@redhat.com>
7342
7343         * breakpoint.c (create_breakpoint): Remove cleanup.
7344
7345 2019-01-23  Tom Tromey  <tom@tromey.com>
7346             Andrew Burgess  <andrew.burgess@embecosm.com>
7347             Pedro Alves  <palves@redhat.com>
7348
7349 2019-01-23  Pedro Alves  <palves@redhat.com>
7350
7351         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7352
7353 2019-01-23  Pedro Alves  <palves@redhat.com>
7354             Andrew Burgess  <andrew.burgess@embecosm.com>
7355
7356         * gdbthread.h: Include "common/forward-scope-exit.h".
7357         (scoped_finish_thread_state): Redefine custom class in terms of
7358         forward_scope_exit.
7359
7360 2019-01-23  Pedro Alves  <palves@redhat.com>
7361             Andrew Burgess  <andrew.burgess@embecosm.com>
7362
7363         * common/forward-scope-exit.h: New file.
7364
7365 2019-01-23  Pedro Alves  <palves@redhat.com>
7366             Andrew Burgess  <andrew.burgess@embecosm.com>
7367             Tom Tromey  <tom@tromey.com>
7368
7369         * common/scope-exit.h: New file.
7370
7371 2019-01-23  Pedro Alves  <palves@redhat.com>
7372
7373         * common/preprocessor.h (ESC): Rename to ...
7374         (ESC_PARENS): ... this.
7375         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7376         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7377
7378 2019-01-23  Tom Tromey  <tom@tromey.com>
7379
7380         * language.h (class scoped_switch_to_sym_language_if_auto):
7381         Initialize m_lang in both cases.
7382
7383 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7384
7385         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7386         with XCNEW.
7387
7388 2019-01-22  Tom Tromey  <tom@tromey.com>
7389
7390         * corelow.c: Do not include sys/file.h.
7391
7392 2019-01-22  Tom Tromey  <tom@tromey.com>
7393
7394         * tui/tui-wingeneral.h: Include gdb_curses.h.
7395
7396 2019-01-22  Tom Tromey  <tom@tromey.com>
7397
7398         * source-cache.h (class source_cache) <get_source_lines,
7399         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7400
7401 2019-01-22  Tom Tromey  <tom@tromey.com>
7402
7403         * remote-fileio.h (struct remote_target): Declare.
7404
7405 2019-01-22  Tom Tromey  <tom@tromey.com>
7406
7407         * python/py-arch.c: Do not include py-ref.h.
7408         * python/py-bpevent.c: Do not include py-ref.h.
7409         * python/py-cmd.c: Do not include py-ref.h.
7410         * python/py-continueevent.c: Do not include py-ref.h.
7411         * python/py-event.h: Do not include py-ref.h.
7412         * python/py-evtregistry.c: Do not include py-ref.h.
7413         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7414         * python/py-frame.c: Do not include py-ref.h.
7415         * python/py-framefilter.c: Do not include py-ref.h.
7416         * python/py-function.c: Do not include py-ref.h.
7417         * python/py-infevents.c: Do not include py-ref.h.
7418         * python/py-linetable.c: Do not include py-ref.h.
7419         * python/py-objfile.c: Do not include py-ref.h.
7420         * python/py-param.c: Do not include py-ref.h.
7421         * python/py-prettyprint.c: Do not include py-ref.h.
7422         * python/py-progspace.c: Do not include py-ref.h.
7423         * python/py-symbol.c: Do not include py-ref.h.
7424         * python/py-symtab.c: Do not include py-ref.h.
7425         * python/py-type.c: Do not include py-ref.h.
7426         * python/py-unwind.c: Do not include py-ref.h.
7427         * python/py-utils.c: Do not include py-ref.h.
7428         * python/py-value.c: Do not include py-ref.h.
7429         * python/py-varobj.c: Do not include py-ref.h.
7430         * python/py-xmethods.c: Do not include py-ref.h.
7431         * python/python.c: Do not include py-ref.h.
7432         * varobj.c: Do not include py-ref.h.
7433
7434 2019-01-22  Tom Tromey  <tom@tromey.com>
7435
7436         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7437         keyword for bcache.
7438
7439 2019-01-22  Tom Tromey  <tom@tromey.com>
7440
7441         * compile/compile-cplus-types.c: Remove a comment by #include.
7442
7443 2019-01-22  Tom Tromey  <tom@tromey.com>
7444
7445         * compile/gcc-c-plugin.h: Include compile-internal.h.
7446
7447 2019-01-22  Tom Tromey  <tom@tromey.com>
7448
7449         * stabsread.c (EXTERN): Do not define.
7450         (symnum, next_symbol_text_func, processing_gcc_compilation)
7451         (within_function, global_sym_chain, global_stabs)
7452         (previous_stab_code, this_object_header_files)
7453         (n_this_object_header_files)
7454         (n_allocated_this_object_header_files): Define.
7455         * stabsread.h (EXTERN): Never define.  Use "extern".
7456
7457 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7458
7459         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7460         history_value.
7461
7462 2019-01-21  Tom Tromey  <tom@tromey.com>
7463
7464         * ui-out.c: Fix includes.
7465         * tui/tui-source.c: Fix includes.
7466         * target.c: Fix includes.
7467         * remote.c: Fix includes.
7468         * regcache.c: Fix includes.
7469         * python/py-block.c: Fix includes.
7470         * printcmd.c: Fix includes.
7471         * or1k-tdep.c: Fix includes.
7472         * mi/mi-main.c: Fix includes.
7473         * m32r-tdep.c: Fix includes.
7474         * csky-tdep.c: Fix includes.
7475         * compile/compile-cplus-types.c: Fix includes.
7476         * cli/cli-interp.c: Fix includes.
7477
7478 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7479
7480         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7481         for padding.
7482
7483 2019-01-16  Tom Tromey  <tom@tromey.com>
7484
7485         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7486         earlier.
7487         (struct objfile) <msymbols_range>: Move from top level.
7488         <msymbols>: New method.
7489         (class objfile_msymbols): Remove.
7490         * symtab.c (default_collect_symbol_completion_matches_break_on):
7491         Update.
7492         * symmisc.c (dump_msymbols): Update.
7493         * stabsread.c (scan_file_globals): Update.
7494         * objc-lang.c (info_selectors_command, info_classes_command)
7495         (find_methods): Update.
7496         * minsyms.c (find_solib_trampoline_target): Update.
7497         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7498         * coffread.c (coff_symfile_read): Update.
7499         * ada-lang.c (ada_lookup_simple_minsym)
7500         (ada_collect_symbol_completion_matches): Update.
7501
7502 2019-01-16  Tom Tromey  <tom@tromey.com>
7503
7504         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7505         type.  Remove no-argument constructor.
7506         <iterator::operator++>: Simplify.
7507         <begin>: Update.
7508         <end>: Use minimal_symbol_count.
7509
7510 2019-01-16  Tom Tromey  <tom@tromey.com>
7511
7512         * objfiles.h (struct objfile) <psymtabs>: New method.
7513         (class objfile_psymtabs): Remove.
7514         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7515         typedef.
7516         <range>: New method.
7517         (require_partial_symbols): Change return type.
7518         * psymtab.c (require_partial_symbols)
7519         (psym_expand_symtabs_matching): Update.
7520         * mdebugread.c (parse_partial_symbols): Update.
7521         * dbxread.c (dbx_end_psymtab): Update.
7522
7523 2019-01-15  Tom Tromey  <tom@tromey.com>
7524
7525         * symtab.c (lookup_objfile_from_block)
7526         (lookup_symbol_in_objfile_symtabs)
7527         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7528         (find_line_symtab, info_sources_command)
7529         (default_collect_symbol_completion_matches_break_on)
7530         (make_source_files_completion_list): Update.
7531         * symmisc.c (print_objfile_statistics, dump_objfile)
7532         (maintenance_print_symbols, maintenance_info_symtabs)
7533         (maintenance_check_symtabs, maintenance_info_line_tables):
7534         Update.
7535         * source.c (select_source_symtab)
7536         (forget_cached_source_info_for_objfile): Update.
7537         * objfiles.h (class objfile_compunits): Remove.
7538         (struct objfile) <compunits_range>: New typedef.
7539         (compunits): New method.
7540         * objfiles.c (objfile_relocate1): Update.
7541         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7542         * maint.c (count_symtabs_and_blocks): Update.
7543         * linespec.c (iterate_over_all_matching_symtabs): Update.
7544         * cp-support.c (add_symbol_overload_list_qualified): Update.
7545         * coffread.c (coff_symtab_read): Update.
7546         * ada-lang.c (add_nonlocal_symbols)
7547         (ada_collect_symbol_completion_matches)
7548         (ada_add_global_exceptions): Update.
7549
7550 2019-01-15  Tom Tromey  <tom@tromey.com>
7551
7552         * progspace.h (program_space) <objfiles_safe_range>: New
7553         typedef.
7554         <objfiles_safe>: New method.
7555         * objfiles.h (class all_objfiles_safe): Remove.
7556         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7557         * jit.c (jit_inferior_exit_hook): Update.
7558
7559 2019-01-17  Tom Tromey  <tom@tromey.com>
7560
7561         * progspace.h (program_space) <objfiles_range>: New typedef.
7562         <objfiles>: New method.
7563         <objfiles_head>: Rename from objfiles.
7564         (object_files): Update.
7565         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7566         * guile/scm-pretty-print.c
7567         (ppscm_find_pretty_printer_from_objfiles): Update.
7568         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7569         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7570         Update.
7571         * python/py-progspace.c (pspy_get_objfiles): Update.
7572         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7573         Update.
7574         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7575         (objfpy_lookup_objfile_by_build_id): Update.
7576         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7577         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7578         Update.
7579         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7580         (expand_symtab_containing_pc, lookup_objfile_from_block)
7581         (lookup_static_symbol, basic_lookup_transparent_type)
7582         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7583         (find_line_symtab, info_sources_command)
7584         (default_collect_symbol_completion_matches_break_on)
7585         (make_source_files_completion_list, find_main_name): Update.
7586         * symmisc.c (print_symbol_bcache_statistics)
7587         (print_objfile_statistics, maintenance_print_symbols)
7588         (maintenance_print_msymbols, maintenance_print_objfiles)
7589         (maintenance_info_symtabs, maintenance_check_symtabs)
7590         (maintenance_expand_symtabs, maintenance_info_line_tables):
7591         Update.
7592         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7593         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7594         (map_overlay_command, unmap_overlay_command)
7595         (simple_overlay_update, expand_symtabs_matching)
7596         (map_symbol_filenames): Update.
7597         * symfile-debug.c (set_debug_symfile): Update.
7598         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7599         Update.
7600         * source.c (select_source_symtab, forget_cached_source_info):
7601         Update.
7602         * solib.c (solib_read_symbols): Update.
7603         * solib-spu.c (append_ocl_sos): Update.
7604         * psymtab.c (maintenance_print_psymbols)
7605         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7606         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7607         * printcmd.c (info_symbol_command): Update.
7608         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7609         Update.
7610         * objfiles.h (class all_objfiles): Remove.
7611         * objfiles.c (have_partial_symbols, have_full_symbols)
7612         (have_minimal_symbols, qsort_cmp, update_section_map)
7613         (shared_objfile_contains_address_p)
7614         (default_iterate_over_objfiles_in_search_order): Update.
7615         * objc-lang.c (info_selectors_command, info_classes_command)
7616         (find_methods): Update.
7617         * minsyms.c (find_solib_trampoline_target): Update.
7618         * maint.c (maintenance_info_sections)
7619         (maintenance_translate_address, count_symtabs_and_blocks):
7620         Update.
7621         * main.c (captured_main_1): Update.
7622         * linux-thread-db.c (try_thread_db_load_from_pdir)
7623         (has_libpthread): Update.
7624         * linespec.c (iterate_over_all_matching_symtabs)
7625         (search_minsyms_for_name): Update.
7626         * jit.c (jit_find_objf_with_entry_addr): Update.
7627         * hppa-tdep.c (find_unwind_entry)
7628         (hppa_lookup_stub_minimal_symbol): Update.
7629         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7630         Update.
7631         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7632         (elf_gnu_ifunc_resolve_by_got): Update.
7633         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7634         * dwarf-index-write.c (save_gdb_index_command): Update.
7635         * cp-support.c (add_symbol_overload_list_qualified): Update.
7636         * breakpoint.c (create_overlay_event_breakpoint)
7637         (create_longjmp_master_breakpoint)
7638         (create_std_terminate_master_breakpoint)
7639         (create_exception_master_breakpoint): Update.
7640         * blockframe.c (find_pc_partial_function): Update.
7641         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7642         (ada_collect_symbol_completion_matches)
7643         (ada_add_global_exceptions): Update.
7644
7645 2019-01-17  Tom Tromey  <tom@tromey.com>
7646
7647         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7648         declare VEC.
7649         (solib_target_parse_libraries): Change return type.
7650         (library_list_start_segment, library_list_start_section)
7651         (library_list_end_library, library_list_start_library); Update.
7652         (solib_target_free_library_list): Remove.
7653         (solib_target_parse_libraries): Remove cleanup.  Change return
7654         type.
7655         (solib_target_current_sos): Update.
7656
7657 2019-01-17  Tom Tromey  <tromey@bapiya>
7658
7659         * valprint.c: Replace "the the" with "the".
7660         * symtab.c: Replace "the the" with "the".
7661         * solib.c: Replace "the the" with "the".
7662         * solib-dsbt.c: Replace "the the" with "the".
7663         * linespec.c: Replace "the the" with "the".
7664         * dwarf2loc.h: Replace "the the" with "the".
7665         * amd64-windows-tdep.c: Replace "the the" with "the".
7666         * aarch64-tdep.c: Replace "the the" with "the".
7667
7668 2019-01-16  Keith Seitz  <keiths@redhat.com>
7669
7670         PR gdb/23773
7671         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7672         <builder>: Rename to ..
7673         <m_builder>: ... this and make private.
7674         (dwarf2_cu::get_builder): New method.  Change all users of
7675         `builder' to use this method.
7676         (dwarf2_start_symtab): Move to ...
7677         (dwarf2_cu::start_symtab): ... here.  Update all callers
7678         (setup_type_unit_groups): Move to ...
7679         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7680         callers.
7681         (dwarf2_cu::reset_builder): New method.
7682         (process_full_compunit, process_full_type_unit): Use
7683         dwarf2_cu::reset_builder.
7684         (follow_die_offset): Record the ancestor CU if it is different
7685         from the followed DIE's CU.
7686         (follow_die_sig_1): Likewise.
7687
7688 2019-01-15  Tom Tromey  <tom@tromey.com>
7689
7690         * remote.c (class remote_state) <buf>: Now a char_vector.
7691         <buf_size>: Remove.
7692         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7693         parameter.
7694         (remote_target::getpkt_or_notif_sane_1)
7695         (remote_target::getpkt_sane)
7696         (remote_target::getpkt_or_notif_sane): Likewise.
7697         (class remote_target) <putpkt>: New overload.
7698         (remote_target::read_frame): Change type of "buf_p".  Remove
7699         sizeof_p parameter.
7700         (packet_ok): New overload.
7701         (packet_check_result): New overload.
7702         Update all uses.
7703
7704 2019-01-14  Tom Tromey  <tom@tromey.com>
7705
7706         * remote-notif.c (handle_notification, remote_notif_ack)
7707         (remote_notif_parse): Make "buf" const.
7708         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7709         const.
7710         (remote_notif_parse, remote_notif_ack, handle_notification):
7711         Likewise.
7712         * remote.c (remote_notif_stop_parse): Make "buf" const.
7713         (remote_target::remote_parse_stop_reply): Make "buf" const.
7714         (remote_notif_stop_ack): Make "buf" const.
7715
7716 2019-01-14  Tom Tromey  <tom@tromey.com>
7717
7718         * remote.c (remote_console_output): Make parameter const.
7719
7720 2019-01-14  Tom Tromey  <tom@tromey.com>
7721
7722         * target-debug.h (target_debug_print_signals): Constify.
7723         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7724         * procfs.c (procfs_target::pass_signals): Update.
7725         * linux-nat.c (linux_nat_target::pass_signals): Update.
7726         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7727         * target-delegates.c: Rebuild.
7728         * remote.c (remote_target::program_signals): Update.
7729         (remote_target::pass_signals): Update.
7730         * target.c (target_pass_signals): Constify argument.
7731         (target_program_signals): Likewise.
7732         * target.h (struct target_ops) <pass_signals, program_signals>:
7733         Constify argument.
7734         (target_pass_signals, target_program_signals): Constify argument.
7735
7736 2019-01-14  Tom Tromey  <tom@tromey.com>
7737
7738         PR tui/28819:
7739         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7740
7741 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7742
7743         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7744         field.
7745         * rs6000-tdep.c: Include reggroups.h.
7746         (IS_V_ALIAS_PSEUDOREG): Define.
7747         (rs6000_register_name): Return names for the "vX" aliases.
7748         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7749         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7750         aliases.  Call default_register_reggroup_p for all other
7751         pseudo-registers.
7752         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7753         New functions.
7754         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7755         Handle "vX" aliases.
7756         (v_alias_pseudo_register_collect): New function.
7757         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7758         (rs6000_gdbarch_init): Initialize "vX" aliases as
7759         pseudo-registers.  Restore registration of
7760         rs6000_pseudo_register_reggroup_p with
7761         set_tdesc_pseudo_register_reggroup_p.
7762
7763 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7764
7765         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7766         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7767         set_gdbarch_num_pseudo_regs.
7768
7769 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7770
7771         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7772         Remove arg prefixname, add do_set and do_show.
7773         Add member functions set_list and show_list.
7774         * cli/cli-style.c (class cli_style_option): Update accordingly.
7775         (style_set_list): Move to file scope.
7776         (style_show_list): Likewise.
7777         (set_style): Call help_list.
7778         (show_style): Call cmd_show_list.
7779         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7780         Update to use the new macro.
7781
7782 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7783
7784         * ada-lang.c (_initialize_ada_language): Expand the help text
7785         for the "catch exception" command.
7786
7787 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7788
7789         * symtab.c (matching_obj_sections): Initialize obj,
7790         declare it closer to its usage.
7791
7792 2019-01-10  Tom Tromey  <tom@tromey.com>
7793
7794         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7795         (basic_inf_threads_range): Remove.
7796         (inf_threads_range, inf_non_exited_threads_range)
7797         (safe_inf_threads_range): Use next_adapter.
7798
7799 2019-01-10  Keith Seitz  <keiths@redhat.com>
7800
7801         PR gdb/23712
7802         PR symtab/23010
7803         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7804         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7805
7806 2019-01-10  Keith Seitz  <keiths@redhat.com>
7807
7808         PR gdb/23712
7809         PR symtab/23010
7810         * dictionary.c (pending_to_vector): Remove.
7811         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7812         Remove _1 suffix, replacing functions of the same name.  Update
7813         all callers.
7814         (dict_create_hashed, dict_create_hashed_expandable)
7815         (dict_create_linear, dict_create_linear_expandable, dict_free)
7816         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7817         Make functions static.
7818
7819 2019-01-10  Keith Seitz  <keiths@redhat.com>
7820
7821         PR gdb/23712
7822         PR symtab/23010
7823         * dictionary.h (struct dictionary): Replace declaration with
7824         multidictionary.
7825         (dict_create_hashed, dict_create_hashed_expandable)
7826         (dict_create_linear, dict_create_linear_expandable)
7827         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7828         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7829         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7830         taking multidictionary argument.
7831         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7832         * block.h (struct block) <dict>: Change to multidictionary
7833         and rename `multidict'.
7834         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7835         symmisc.c: Update all dictionary references to multidictionary.
7836
7837 2019-01-10  Keith Seitz  <keiths@redhat.com>
7838
7839         PR gdb/23712
7840         PR symtab/23010
7841         * dictionary.c: Include unordered_map.
7842         (pending_to_vector): New function.
7843         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7844         Rewrite the non-"_1" functions to take vector instead
7845         of linked list.
7846         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7847         "new" _1 versions of the same name.
7848         (multidictionary): Define.
7849         (std::hash<enum language): New definition.
7850         (collate_pending_symbols_by_language, mdict_create_hashed)
7851         (mdict_create_hashed_expandable, mdict_create_linear)
7852         (mdict_create_linear_expandable, mdict_free)
7853         (find_language_dictionary, create_new_language_dictionary)
7854         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7855         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7856         (mdict_size, mdict_empty): New functions.
7857         * dictionary.h (mdict_iterator): Define.
7858
7859 2019-01-10  Pedro Alves  <palves@redhat.com>
7860
7861         * breakpoint.c (read_uploaded_action)
7862         (create_tracepoint_from_upload): Adjust to use
7863         gdb::unique_xmalloc_ptr.
7864         * ctf.c (ctf_write_uploaded_tp):
7865         (SET_ARRAY_FIELD): Use emplace_back.
7866         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7867         * tracefile-tfile.c (tfile_write_uploaded_tp):
7868         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7869         gdb::unique_xmalloc_ptr.
7870         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7871         at_string, cond_string, cmd_strings>: Replace char pointers
7872         with gdb::unique_xmalloc_ptr.
7873
7874 2019-01-10  Pedro Alves  <palves@redhat.com>
7875
7876         * solib-target.c (library_list_start_library): Don't xstrdup name.
7877
7878 2019-01-10  Pedro Alves  <palves@redhat.com>
7879
7880         * mdebugread.c (parse_partial_symbols): Use
7881         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7882
7883 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7884
7885         * linux-fork.c (scoped_switch_fork_info)
7886         <~scoped_switch_fork_info>: Fix incorrect variable name.
7887
7888 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7889
7890         * linux-fork.c (scoped_switch_fork_info)
7891         <scoped_switch_fork_info>: Make explicit.
7892         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7893
7894 2019-01-10  Tom Tromey  <tom@tromey.com>
7895
7896         * objfiles.h (objfile::reset_psymtabs): Update.
7897         * objfiles.c (objfile::objfile): Update.
7898         * psymtab.h (psymtab_storage::obstack): Update.
7899         (psymtab_storage::m_obstack): Use gdb::optional.
7900         (class psymtab_storage): Update comment.  Remove objfile
7901         parameter.
7902         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7903
7904 2019-01-10  Tom Tromey  <tom@tromey.com>
7905
7906         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7907         <free_psymtabs>: Now private.
7908         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7909         (allocate_psymtab): Use new method.
7910
7911 2019-01-10  Tom Tromey  <tom@tromey.com>
7912
7913         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7914         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7915         * mdebugread.c (parse_partial_symbols): Use
7916         allocate_dependencies.
7917         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7918         allocate_dependencies.
7919         (process_psymtab_comp_unit_reader)
7920         (build_type_psymtab_dependencies): Likewise.
7921         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7922
7923 2019-01-10  Tom Tromey  <tom@tromey.com>
7924
7925         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7926         PSYMBOL_SET_LANGUAGE.
7927         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7928
7929 2019-01-10  Tom Tromey  <tom@tromey.com>
7930
7931         * psymtab.h (psymtab_storage::obstack): New method.
7932         <m_obstack>: Rename from obstack; now private.
7933         * psymtab.c (psymtab_storage): Update.
7934         * dwarf2read.c (create_addrmap_from_index)
7935         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7936         Update.
7937
7938 2019-01-10  Tom Tromey  <tom@tromey.com>
7939
7940         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7941         * objfiles.h (objfile::reset_psymtabs): New method.
7942
7943 2019-01-10  Tom Tromey  <tom@tromey.com>
7944
7945         * symmisc.c (print_symbol_bcache_statistics): Update.
7946         (print_objfile_statistics): Update.
7947         * symfile.c (reread_symbols): Update.
7948         * psymtab.h (class psymtab_storage): New.
7949         * psymtab.c (psymtab_storage): New constructor.
7950         (~psymtab_storage): New destructor.
7951         (require_partial_symbols): Update.
7952         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7953         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7954         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7955         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7956         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7957         (start_psymtab_common, end_psymtab_common)
7958         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7959         (allocate_psymtab): Update.
7960         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7961         Update.
7962         (dump_psymtab_addrmap, maintenance_print_psymbols)
7963         (maintenance_check_psymtabs): Update.
7964         (class objfile_psymtabs): Move to objfiles.h.
7965         * psympriv.h (discard_psymtab): Now inline.
7966         (psymtab_discarder::psymtab_discarder): Update.
7967         (psymtab_discarder::~psymtab_discarder): Update.
7968         (ALL_OBJFILE_PSYMTABS): Rewrite.
7969         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7970         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7971         Remove fields.
7972         <partial_symtabs>: New field.
7973         (class objfile_psymtabs): Move from psymtab.h.  Update.
7974         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7975         psymbol_cache.
7976         (objfile::~objfile): Don't destroy psymbol_cache.
7977         * mdebugread.c (parse_partial_symbols): Update.
7978         * dwarf2read.c (create_addrmap_from_index)
7979         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7980         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7981         (add_partial_subprogram, dwarf2_ranges_read): Update.
7982         * dwarf-index-write.c (write_address_map)
7983         (write_one_signatured_type, recursively_write_psymbols)
7984         (class debug_names, class debug_names, write_psymtabs_to_index):
7985         Update.
7986
7987 2019-01-10  Tom Tromey  <tom@tromey.com>
7988
7989         * symtab.h (SYMBOL_SET_NAMES): Update.
7990         (symbol_set_names): Update.
7991         (MSYMBOL_SET_NAMES): Update.
7992         * symtab.c (symbol_set_names): Change argument to be an
7993         objfile_per_bfd_storage.
7994         * psymtab.c (add_psymbol_to_bcache): Update.
7995         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7996
7997 2019-01-10  Tom Tromey  <tom@tromey.com>
7998
7999         * symtab.c (create_demangled_names_hash): Change argument to be an
8000         objfile_per_bfd_storage.
8001         (symbol_set_names): Update.
8002
8003 2019-01-10  Tom Tromey  <tom@tromey.com>
8004
8005         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8006         init_psymbol_list.
8007         * psymtab.c (init_psymbol_list): Do nothing if already called.
8008         * psympriv.h (init_psymbol_list): Add comment.
8009         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8010         init_psymbol_list.
8011         * dbxread.c (dbx_symfile_read): Unconditionally call
8012         init_psymbol_list.
8013
8014 2019-01-10  Tom Tromey  <tom@tromey.com>
8015
8016         * xcoffread.c (scan_xcoff_symtab): Update.
8017         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8018         "where".
8019         * mdebugread.c (parse_partial_symbols)
8020         (handle_psymbol_enumerators): Update.
8021         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8022         * dbxread.c (read_dbx_symtab): Update.
8023         * psympriv.h (psymbol_placement): New enum.
8024         (add_psymbol_to_list): Update.
8025
8026 2019-01-10  Tom Tromey  <tom@tromey.com>
8027
8028         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8029         static_psymbols parameters.
8030         (scan_xcoff_symtab): Update.
8031         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8032         static_psymbols parameters.
8033         * psympriv.h (start_psymtab_common): Update.
8034         * mdebugread.c (parse_partial_symbols): Update.
8035         * dwarf2read.c (create_partial_symtab): Update.
8036         * dbxread.c (read_dbx_symtab): Update.
8037         (start_psymtab): Remove global_psymbols and static_psymbols
8038         parameters.
8039
8040 2019-01-10  Tom Tromey  <tom@tromey.com>
8041
8042         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8043         * psymtab.c (allocate_psymtab): Add comment.
8044         * psympriv.h (allocate_psymtab): Add comment.
8045         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8046         initializations.
8047         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8048
8049 2019-01-10  Tom Tromey  <tom@tromey.com>
8050
8051         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8052         Don't declare.
8053         * mipsread.c: Include mdebugread.h.
8054         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8055         Declare.
8056         * elfread.c: Include mdebugread.h.
8057
8058 2019-01-09  Tom Tromey  <tom@tromey.com>
8059
8060         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8061         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8062         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8063         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8064         (psym_lookup_symbol, psym_find_last_source_symtab)
8065         (psym_forget_cached_source_info, psym_print_stats)
8066         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8067         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8068         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8069         (psym_find_compunit_symtab_by_address)
8070         (maintenance_print_psymbols, maintenance_info_psymtabs)
8071         (maintenance_check_psymtabs): Use ranged for.
8072         * psymtab.h (class objfile_psymtabs): New.
8073         (require_partial_symbols): Return objfile_psymtabs.
8074         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8075
8076 2019-01-09  Tom Tromey  <tom@tromey.com>
8077
8078         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8079         (find_pc_mapped_section, list_overlays_command)
8080         (map_overlay_command, unmap_overlay_command)
8081         (simple_overlay_update): Use all_objfiles.
8082         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8083         * printcmd.c (info_symbol_command): Use all_objfiles.
8084         * objfiles.h (ALL_OBJSECTIONS): Remove.
8085         * maint.c (maintenance_translate_address): Use all_objfiles.
8086         * gcore.c (gcore_create_callback): Use all_objfiles.
8087         (objfile_find_memory_regions): Likewise.
8088
8089 2019-01-09  Tom Tromey  <tom@tromey.com>
8090
8091         * symtab.c (find_line_symtab, info_sources_command)
8092         (make_source_files_completion_list): Use objfile_compunits.
8093         * source.c (select_source_symtab): Use objfile_compunits.
8094         * objfiles.h (struct objfile): Update comment.
8095         (ALL_OBJFILES): Remove.
8096         (ALL_FILETABS): Remove.
8097         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8098         objfile_compunits.
8099
8100 2019-01-09  Tom Tromey  <tom@tromey.com>
8101
8102         * symmisc.c (print_objfile_statistics, dump_objfile)
8103         (maintenance_print_symbols): Use compunit_filetabs.
8104         * source.c (forget_cached_source_info_for_objfile): Use
8105         compunit_filetabs.
8106         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8107         (ALL_FILETABS): Use compunit_filetabs.
8108         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8109         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8110
8111 2019-01-09  Tom Tromey  <tom@tromey.com>
8112
8113         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8114         (compunit_filetabs): New.
8115         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8116         compunit_filetabs.
8117         (info_sources_command, make_source_files_completion_list): Remove
8118         declaration.
8119         * symmisc.c (print_objfile_statistics, dump_objfile)
8120         (maintenance_print_symbols): Remove declaration.
8121         (maintenance_info_symtabs): Use compunit_filetabs.
8122         (maintenance_info_line_tables): Likewise.
8123         * source.c (select_source_symtab): Change local variable name.
8124         (forget_cached_source_info_for_objfile): Remove declaration.
8125         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8126         * objfiles.c (objfile_relocate1): Remove declaration.
8127         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8128         declaration.
8129         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8130         * coffread.c (coff_symtab_read): Remove declaration.
8131         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8132         compunit_filetabs.
8133
8134 2019-01-09  Tom Tromey  <tom@tromey.com>
8135
8136         * symtab.c (lookup_objfile_from_block)
8137         (find_pc_sect_compunit_symtab, search_symbols)
8138         (default_collect_symbol_completion_matches_break_on): Use
8139         objfile_compunits.
8140         * objfiles.h (ALL_COMPUNITS): Remove.
8141         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8142         * cp-support.c (add_symbol_overload_list_qualified): Use
8143         objfile_compunits.
8144         * ada-lang.c (ada_collect_symbol_completion_matches)
8145         (ada_add_global_exceptions): Use objfile_compunits.
8146
8147 2019-01-09  Tom Tromey  <tom@tromey.com>
8148
8149         * source.c (select_source_symtab)
8150         (forget_cached_source_info_for_objfile): Remove declaration.
8151         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8152         declaration.
8153         * maint.c (count_symtabs_and_blocks): Remove declaration.
8154         * cp-support.c (add_symbol_overload_list_qualified): Remove
8155         declaration.
8156         * coffread.c (coff_symtab_read): Remove declaration.
8157         * symtab.c (lookup_symbol_in_objfile_symtabs)
8158         (basic_lookup_transparent_type_1): Use objfile_compunits.
8159         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8160         (info_sources_command, search_symbols)
8161         (default_collect_symbol_completion_matches_break_on)
8162         (make_source_files_completion_list): Remove declaration.
8163         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8164         (ada_collect_symbol_completion_matches)
8165         (ada_add_global_exceptions): Remove declaration.
8166         * linespec.c (iterate_over_all_matching_symtabs): Use
8167         objfile_compunits.
8168         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8169         (class objfile_compunits): New.
8170         (ALL_COMPUNITS): Use objfile_compunits.
8171         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8172         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8173         objfile_compunits.
8174         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8175
8176 2019-01-09  Tom Tromey  <tom@tromey.com>
8177
8178         * symtab.c (search_symbols)
8179         (default_collect_symbol_completion_matches_break_on): Use
8180         objfile_msymbols.
8181         * ada-lang.c (ada_lookup_simple_minsym)
8182         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8183         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8184         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8185         objfile_msymbols.
8186         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8187         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8188         * objc-lang.c (find_methods): Use objfile_msymbols.
8189         (info_selectors_command, info_classes_command): Likewise.
8190         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8191         * objfiles.h (class objfile_msymbols): New.
8192         (ALL_OBJFILE_MSYMBOLS): Remove.
8193         (ALL_MSYMBOLS): Remove.
8194
8195 2019-01-09  Tom Tromey  <tom@tromey.com>
8196
8197         * common/next-iterator.h (next_adapter): Add Iterator template
8198         parameter.
8199         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8200         (class all_objfiles_safe): New.
8201         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8202         * objfiles.c (put_objfile_before): Update comment.
8203         (add_separate_debug_objfile): Likewise.
8204         (free_all_objfiles): Use all_objfiles_safe.
8205         (objfile_purge_solibs): Likewise.
8206
8207 2019-01-09  Tom Tromey  <tom@tromey.com>
8208
8209         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8210         (expand_symtab_containing_pc, lookup_static_symbol)
8211         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8212         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8213         all_objfiles.
8214         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8215         * breakpoint.c (create_overlay_event_breakpoint)
8216         (create_longjmp_master_breakpoint)
8217         (create_std_terminate_master_breakpoint)
8218         (create_exception_master_breakpoint): Use all_objfiles.
8219         * linux-thread-db.c (try_thread_db_load_from_pdir)
8220         (has_libpthread): Use all_objfiles.
8221         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8222         * linespec.c (iterate_over_all_matching_symtabs)
8223         (search_minsyms_for_name): Use all_objfiles.
8224         * maint.c (maintenance_info_sections): Use all_objfiles.
8225         * main.c (captured_main_1): Use all_objfiles.
8226         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8227         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8228         * guile/scm-pretty-print.c
8229         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8230         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8231         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8232         (maintenance_print_msymbols): Use all_objfiles.
8233         * source.c (select_source_symtab): Use all_objfiles.
8234         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8235         * symfile.c (remove_symbol_file_command)
8236         (expand_symtabs_matching, map_symbol_filenames): Use
8237         all_objfiles.
8238         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8239         all_objfiles.
8240         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8241         * objc-lang.c (find_methods): Use all_objfiles.
8242         * objfiles.c (have_partial_symbols, have_full_symbols)
8243         (have_minimal_symbols, qsort_cmp)
8244         (default_iterate_over_objfiles_in_search_order): Use
8245         all_objfiles.
8246         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8247         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8248         (maintenance_check_psymtabs): Use all_objfiles.
8249         (ALL_PSYMTABS): Remove.
8250         * compile/compile-object-run.c (do_module_cleanup): Use
8251         all_objfiles.
8252         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8253         * cp-support.c (add_symbol_overload_list_qualified): Use
8254         all_objfiles.
8255         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8256         Use all_objfiles.
8257         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8258         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8259         all_objfiles.
8260         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8261         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8262         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8263         Uses all_objfiles.
8264         * solib.c (solib_read_symbols): Use all_objfiles
8265
8266 2019-01-09  Tom Tromey  <tom@tromey.com>
8267
8268         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8269         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8270         all_objfiles.
8271         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8272         * symmisc.c (print_symbol_bcache_statistics)
8273         (print_objfile_statistics, maintenance_print_objfiles)
8274         (maintenance_info_symtabs, maintenance_check_symtabs)
8275         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8276         all_objfiles.
8277         * source.c (forget_cached_source_info): Use all_objfiles.
8278         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8279         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8280         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8281         * objfiles.c (update_section_map): Use all_objfiles.
8282         (shared_objfile_contains_address_p): Likewise.
8283         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8284         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8285
8286 2019-01-09  Tom Tromey  <tom@tromey.com>
8287
8288         * common/next-iterator.h: New file.
8289         * objfiles.h (class all_objfiles): New.
8290         (struct objfile_iterator): New.
8291
8292 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8293
8294         * NEWS: Move the description of the changed "frame", "select-frame",
8295          and "info frame" commands to the Changed commands section.
8296
8297 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8298
8299         * gdbtypes.c (check_stub_method_group): Remove handling of old
8300         mangling schemes.
8301         * linespec.c (find_methods): Likewise.
8302         * stabsread.c (read_member_functions): Likewise.
8303         * valops.c (search_struct_method): Likewise.
8304         (value_struct_elt_for_reference): Likewise.
8305         * NEWS: Mention this change.
8306
8307 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8308
8309         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8310         print_source_lines.
8311         * source.c (print_source_lines_base): Update line number check.
8312         (print_source_lines): New function.
8313         (source_lines_range::source_lines_range): New function.
8314         * source.h (class source_lines_range): New class.
8315         (print_source_lines): New declaration.
8316
8317 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8318
8319         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8320
8321 2019-01-08  Tom Tromey  <tom@tromey.com>
8322             Simon Marchi  <simon.marchi@ericsson.com>
8323
8324         PR gdb/24060
8325         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8326         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8327         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8328         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8329         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8330         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8331
8332 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8333
8334         * source.c (select_source_symtab): Move header comment to
8335         declaration in source.h.
8336         (forget_cached_source_info_for_objfile): Likewise.
8337         (forget_cached_source_info): Likewise.
8338         (identify_source_line): Likewise.
8339         * source.h (identify_source_line): Move declaration from symtab.h
8340         and add comment from source.c
8341         (print_source_lines): Likewise.
8342         (forget_cached_source_info_for_objfile): Likewise.
8343         (forget_cached_source_info): Likewise.
8344         (select_source_symtab): Likewise.
8345         (enum print_source_lines_flag): Move definition from symtab.h.
8346         * symtab.h (identify_source_line): Move declaration to source.h.
8347         (print_source_lines): Likewise.
8348         (forget_cached_source_info_for_objfile): Likewise.
8349         (forget_cached_source_info): Likewise.
8350         (select_source_symtab): Likewise.
8351         (enum print_source_lines_flag): Move definition to source.h.
8352         * tui/tui-hooks.c: Add 'source.h' include.
8353
8354 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8355
8356         * source.c (print_source_lines_base): Handle requests to print
8357         reverse line number sequences, and guard against empty lines
8358         string.
8359
8360 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * source.c (print_source_lines_base): Fix skip of '\r' if next
8363         character is '\n'.
8364
8365 2019-01-06  Tom Tromey  <tom@tromey.com>
8366
8367         * c-exp.y (struct c_parse_state) <macro_original_text,
8368         expansion_obstack>: New member.
8369         (macro_original_text, expansion_obstack): Remove globals.
8370         (scan_macro_expansion, scanning_macro_expansion)
8371         (finished_macro_expansion): Update.
8372         (scan_macro_cleanup): Remove.
8373         (yylex, c_parse): Update.
8374
8375 2019-01-06  Tom Tromey  <tom@tromey.com>
8376
8377         * c-exp.y (struct c_parse_state) <strings>: New member.
8378         (operator_stoken): Update.
8379
8380 2019-01-06  Tom Tromey  <tom@tromey.com>
8381
8382         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8383         (union type_stack_elt) <typelist_val>: Now a pointer to
8384         std::vector.
8385         (type_stack_cleanup): Don't declare.
8386         (push_typelist): Update.
8387         * parse.c (pop_typelist): Return a std::vector.
8388         (push_typelist): Take a std::vector.
8389         (follow_types): Update.  Do not free args.
8390         (type_stack_cleanup): Remove.
8391         * c-exp.y (struct c_parse_state): New.
8392         (cpstate): New global.
8393         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8394         (nonempty_typelist): Update.
8395         (func_mod): Create a new vector.
8396         (c_parse): Create a c_parse_state.
8397         (check_parameter_typelist): Do not delete params.
8398         (function_method): Update.  Do not delete type_list.
8399
8400 2019-01-06  Tom Tromey  <tom@tromey.com>
8401
8402         PR gdb/28155:
8403         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8404         check_typedef.
8405         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8406         (print_return_value): Likewise.
8407
8408 2019-01-05  Tom Tromey  <tom@tromey.com>
8409
8410         * contrib/cleanup_check.py: Remove.
8411         * contrib/gcc-with-excheck: Remove.
8412         * contrib/exsummary.py: Remove.
8413         * contrib/excheck.py: Remove.
8414
8415 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8416
8417         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8418         NULL. Initialize tpprev to NULL instead of assigning it
8419         to NULL on the next statement.
8420         * windows-nat.c (windows_delete_thread): Remove check for
8421         main_thread_id before printing thread exit notifications.
8422         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8423         Remove thread ID check against main_thread_id.
8424         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8425         windows_delete_thread.
8426         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8427
8428 2019-01-04  Tom Tromey  <tom@tromey.com>
8429
8430         * compile/compile.c (_initialize_compile): Use upper case for
8431         metasyntactic variables.
8432         * symmisc.c (_initialize_symmisc): Use upper case for
8433         metasyntactic variables.
8434         * psymtab.c (_initialize_psymtab): Use upper case for
8435         metasyntactic variables.
8436         * demangle.c (demangle_command): Use upper case for metasyntactic
8437         variables.
8438         (_initialize_demangler): Likewise.
8439         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8440         variables.
8441
8442 2019-01-03  Tom Tromey  <tom@tromey.com>
8443
8444         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8445
8446 2019-01-03  Tom Tromey  <tom@tromey.com>
8447
8448         * python/py-symtab.c (salpy_str): Update.
8449         (struct salpy_sal_object) <symtab>: Now a PyObject.
8450         (salpy_dealloc): Update.
8451         (del_objfile_sal): Use gdbpy_ref.
8452
8453 2019-01-03  Tom Tromey  <tom@tromey.com>
8454
8455         * python/py-type.c (convert_field): Use new_reference.  Return
8456         gdbpy_ref.
8457         (make_fielditem): Return gdbpy_ref.
8458         (typy_fields): Update.
8459         (typy_getitem): Update.
8460         (field_name): Return gdbpy_ref.  Use new_reference.
8461         (typy_iterator_iternext): Update.
8462
8463 2019-01-03  Tom Tromey  <tom@tromey.com>
8464
8465         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8466
8467 2019-01-03  Tom Tromey  <tom@tromey.com>
8468
8469         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8470         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8471         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8472         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8473         (pspy_set_type_printers): Likewise.
8474         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8475         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8476         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8477         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8478         (objfpy_set_type_printers): Likewise.
8479
8480 2019-01-03  Tom Tromey  <tom@tromey.com>
8481
8482         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8483         (gdbpy_print_stack): Use gdbpy_err_fetch.
8484         * python/python-internal.h (class gdbpy_err_fetch): New class.
8485         (class gdbpy_enter) <m_error_type, m_error_value,
8486         m_error_traceback>: Remove.
8487         <m_error>: New member.
8488         (gdbpy_exception_to_string): Don't declare.
8489         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8490         * python/py-value.c (convert_value_from_python): Use
8491         gdbpy_err_fetch.
8492         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8493         gdbpy_exception_to_string.
8494         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8495         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8496         gdbpy_err_fetch.
8497
8498 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8499
8500         * linux-nat.c (delete_lwp_cleanup): Delete.
8501         (struct lwp_deleter): New struct.
8502         (lwp_info_up): New typedef.
8503         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8504         lwp_info_up.
8505
8506 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8507
8508         * linux-fork.c (class scoped_switch_fork_info): New class.
8509         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8510
8511 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8512
8513         * valops.c (find_overload_match): Remove use of null_cleanup, and
8514         calls to do_cleanups.
8515
8516 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8517
8518         * compile/compile-cplus-types.c
8519         (compile_cplus_instance::decl_name): Handle changes to
8520         cp_func_name.
8521         * cp-support.c (cp_func_name): Update header comment, update
8522         return type.
8523         * cp-support.h (cp_func_name): Update return type in declaration.
8524         * valops.c (find_overload_match): Move temp_func local to top
8525         level of function and change its type.  Use temp_func to hold and
8526         delete temporary string obtained from cp_func_name.
8527
8528 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8529
8530         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8531         gdb::char_vector, remove cleanup, and update uses of `msg`.
8532
8533 2019-01-03  Jim Wilson  <jimw@sifive.com>
8534
8535         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8536
8537 2019-01-02  Tom Tromey  <tom@tromey.com>
8538
8539         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8540         (tdesc_parse_xml): Remove cleanups.
8541         * target-descriptions.h (make_cleanup_free_target_description):
8542         Don't declare.
8543         (target_desc_deleter): New struct.
8544         (target_desc_up): New typedef.
8545         * target-descriptions.c (target_desc_deleter::operator()): Rename
8546         from free_target_description.
8547         (make_cleanup_free_target_description): Remove.
8548
8549 2019-01-02  Tom Tromey  <tom@tromey.com>
8550
8551         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8552         constructor, destructor.
8553         (linespec_parser): Remove typedef.
8554         (~linespec_parser): Rename from linespec_parser_delete.
8555         (linespec_lex_to_end, linespec_complete_label)
8556         (linespec_complete): Update.
8557         (decode_line_full): Remove cleanups.
8558         (decode_line_1): Update.
8559
8560 2019-01-02  Tom Tromey  <tom@tromey.com>
8561
8562         * python/python-internal.h (inferior_to_inferior_object): Change
8563         return type.
8564         * python/py-exitedevent.c (create_exited_event_object): Update.
8565         * python/py-inferior.c (inferior_to_inferior_object): Return
8566         gdbpy_ref.
8567         (python_new_inferior, python_inferior_deleted)
8568         (thread_to_thread_object, delete_thread_object)
8569         (build_inferior_list, gdbpy_selected_inferior): Update.
8570         * python/py-infthread.c (create_thread_object): Update.  Also fail
8571         if inferior_to_inferior_object fails.
8572
8573 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8574
8575         * inferior.h (class inferior) <displaced_step_state>: New field.
8576         * infrun.h (struct displaced_step_state): Move here from
8577         infrun.c.  Initialize fields, add constructor.
8578         <inf>: Remove field.
8579         <reset>: New method.
8580         * infrun.c (struct displaced_step_inferior_state): Move to
8581         infrun.h.
8582         (displaced_step_inferior_states): Remove.
8583         (get_displaced_stepping_state): Adust.
8584         (displaced_step_in_progress_any_inferior): Adjust.
8585         (displaced_step_in_progress_thread): Adjust.
8586         (displaced_step_in_progress): Adjust.
8587         (add_displaced_stepping_state): Remove.
8588         (get_displaced_step_closure_by_addr): Adjust.
8589         (remove_displaced_stepping_state): Remove.
8590         (infrun_inferior_exit): Call displaced_step_state.reset.
8591         (use_displaced_stepping): Don't check for NULL.
8592         (displaced_step_prepare_throw): Call
8593         get_displaced_stepping_state.
8594         (displaced_step_fixup): Don't check for NULL.
8595         (prepare_for_detach): Don't check for NULL.
8596
8597 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8598
8599         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8600          in case of call that did not complete.
8601
8602 2019-01-02  Andrey Utkin  <autkin@undo.io>
8603
8604         * symfile.c (find_separate_debug_file): Fix search of debug files for
8605         remote debuggee.
8606
8607 2019-01-02  Tom Tromey  <tom@tromey.com>
8608
8609         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8610         indentation.
8611         * python/py-frame.c (frapy_older): Remove cast.
8612         (frapy_newer): Likewise.
8613         * python/py-breakpoint.c (local_setattro): Remove cast.
8614         * python/py-arch.c (archpy_name): Remove local variable.
8615         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8616
8617 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8618
8619         * unittests/basic_string_view/element_access/char/empty.cc:
8620         Fix year range in copyright header.
8621
8622 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8623
8624         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8625         Delete.
8626         <operator==>: Update with for removed field.
8627         <hash>: Likewise.
8628         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8629         <isa_features>: ...this.
8630         <abi_features>: New field.
8631         (riscv_isa_flen): Update comment.
8632         (riscv_abi_xlen): New declaration.
8633         (riscv_abi_flen): New declaration.
8634         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8635         isa_features.
8636         (riscv_abi_xlen): New function.
8637         (riscv_isa_flen): Update to get answer from isa_features.
8638         (riscv_abi_flen): New function.
8639         (riscv_has_fp_abi): Update to get answer from abi_features.
8640         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8641         xlen and flen.
8642         (riscv_call_info) <xlen, flen>: Update comment.
8643         (riscv_call_arg_struct): Remove invalid assertions
8644         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8645         is removed.
8646         (riscv_gdbarch_init): Gather isa features and abi features
8647         separately, ensure both match on the gdbarch when reusing an old
8648         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8649         a target with 64-bit float hardware.
8650
8651 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8652
8653         * source.c (search_command_helper): Stop reverse search
8654         when line 1 has been searched.
8655
8656 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8657
8658         * record-full.c (record_full_base_target::close): Rewrite
8659         record_full_core_buf_list free logic.
8660
8661 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8662
8663         * break-catch-syscall.c (print_one_catch_syscall): xfree
8664         the last text.
8665
8666 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8667
8668         * top.c (print_gdb_version): Update Copyright year in version
8669         message.
8670
8671 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8672
8673         Update copyright year range in all GDB files.
8674
8675 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8676
8677         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8678
8679 For older changes see ChangeLog-2018.
8680 \f
8681 Local Variables:
8682 mode: change-log
8683 left-margin: 8
8684 fill-column: 74
8685 version-control: never
8686 coding: utf-8
8687 End:
8688