gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * nto-tdep.c (nto_inferior_data_reg): Change type.
   4         (nto_inferior_data): Update.
   5         (nto_inferior_data_cleanup, nto_new_inferior_data)
   6         (_initialize_nto_tdep): Remove.
   7         * nto-tdep.h (struct nto_inferior_data): Add initializers.
   8
   9 2019-05-08  Tom Tromey  <tom@tromey.com>
  10
  11         * ada-lang.c (struct ada_inferior_data): Add initializers.
  12         (ada_inferior_data): Change type.
  13         (ada_inferior_data_cleanup): Remove.
  14         (get_ada_inferior_data, ada_inferior_exit)
  15         (struct ada_pspace_data): Add initializers, destructor.
  16         (ada_pspace_data_handle): Change type.
  17         (get_ada_pspace_data): Update.
  18         (ada_pspace_data_cleanup): Remove.
  19
  20 2019-05-08  Tom Tromey  <tom@tromey.com>
  21
  22         * coffread.c (struct coff_symfile_info): Add initializers.
  23         (coff_objfile_data_key): Move lower.  Change type.
  24         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  25         Update.
  26         (coff_free_info): Remove.
  27
  28 2019-05-08  Tom Tromey  <tom@tromey.com>
  29
  30         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  31         (fbsd_pspace_data_handle): Move lower.  Change type.
  32         (get_fbsd_pspace_data): Update.
  33         (fbsd_pspace_data_cleanup): Remove.
  34         (_initialize_fbsd_tdep): Update.
  35
  36 2019-05-08  Tom Tromey  <tom@tromey.com>
  37
  38         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  39         (get_ada_tasks_pspace_data): Update.
  40         (ada_tasks_pspace_data_cleanup): Remove.
  41         (_initialize_tasks): Update.
  42         (ada_tasks_inferior_data_handle): Change type.
  43         (get_ada_tasks_inferior_data): Update.
  44         (ada_tasks_inferior_data_cleanup): Remove.
  45         (struct ada_tasks_pspace_data): Add initializers.
  46
  47 2019-05-08  Tom Tromey  <tom@tromey.com>
  48
  49         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  50         * symfile-debug.c (debug_sym_get_probes): Change type.
  51         * stap-probe.c (handle_stap_probe):
  52         (stap_static_probe_ops::get_probes): Change type.
  53         * probe.h (class static_probe_ops) <get_probes>: Change type.
  54         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  55         (parse_probes_in_pspace): Update.
  56         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  57         Update.
  58         (any_static_probe_ops::get_probes): Change type.
  59         * elfread.c (elfread_data): New typedef.
  60         (probe_key): Change type.
  61         (elf_get_probes): Likewise.  Update.
  62         (probe_key_free): Remove.
  63         (_initialize_elfread): Update.
  64         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  65         Change type.
  66         (dtrace_process_dof_probe, dtrace_process_dof)
  67         (dtrace_static_probe_ops::get_probe): Change type.
  68
  69 2019-05-08  Tom Tromey  <tom@tromey.com>
  70
  71         * xcoffread.c (struct xcoff_symfile_info): Rename from
  72         coff_symfile_info.  Add initializers.
  73         (xcoff_objfile_data_key): Move lower.  Change type.
  74         (XCOFF_DATA): Rewrite.
  75         (xcoff_free_info): Remove.
  76         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  77         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  78         (xcoff_initial_scan): Update.
  79
  80 2019-05-08  Tom Tromey  <tom@tromey.com>
  81
  82         * solib-svr4.c (struct svr4_info): Add initializers and
  83         destructor.
  84         <probes_table>: Now an htab_up.
  85         (solib_svr4_pspace_data): Change type.
  86         (free_probes_table): Simplify.
  87         (~svr4_info): Rename from svr4_pspace_data_cleanup.
  88         (get_svr4_info, probes_table_htab_remove_objfile_probes)
  89         (probes_table_remove_objfile_probes, register_solib_event_probe)
  90         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
  91         (_initialize_svr4_solib): Update.
  92
  93 2019-05-08  Tom Tromey  <tom@tromey.com>
  94
  95         * remote.c (remote_pspace_data): Change type.
  96         (remote_pspace_data_cleanup): Remove.
  97         (get_remote_exec_file, set_pspace_remote_exec_file)
  98         (_initialize_remote): Update.
  99
 100 2019-05-08  Tom Tromey  <tom@tromey.com>
 101
 102         * breakpoint.c (breakpoint_objfile_key): Change type.
 103         (get_breakpoint_objfile_data): Update.
 104         (free_breakpoint_objfile_data): Remove.
 105         (_initialize_breakpoint): Update.
 106
 107 2019-05-08  Tom Tromey  <tom@tromey.com>
 108
 109         * linux-tdep.c (struct linux_info): Add initializers.
 110         (linux_inferior_data): Move.  Change type.
 111         (invalidate_linux_cache_inf): Update.
 112         (linux_inferior_data_cleanup): Remove.
 113         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 114
 115 2019-05-08  Tom Tromey  <tom@tromey.com>
 116
 117         * auxv.c (auxv_inferior_data): Move.  Change type.
 118         (auxv_inferior_data_cleanup): Remove.
 119         (invalidate_auxv_cache_inf): Rewrite.
 120         (get_auxv_inferior_data, _initialize_auxv): Update.
 121
 122 2019-05-08  Tom Tromey  <tom@tromey.com>
 123
 124         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 125         (symfile_debug_objfile_data_key): Change type.
 126         (symfile_debug_installed, debug_qf_has_symbols)
 127         (debug_qf_find_last_source_symtab)
 128         (debug_qf_forget_cached_source_info)
 129         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 130         (debug_qf_print_stats, debug_qf_dump)
 131         (debug_qf_expand_symtabs_for_function)
 132         (debug_qf_expand_all_symtabs)
 133         (debug_qf_expand_symtabs_with_fullname)
 134         (debug_qf_map_matching_symbols)
 135         (debug_qf_expand_symtabs_matching)
 136         (debug_qf_find_pc_sect_compunit_symtab)
 137         (debug_qf_map_symbol_filenames)
 138         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 139         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 140         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 141         (debug_sym_read_linetable, debug_sym_relocate): Update.
 142         (symfile_debug_free_objfile): Remove.
 143         (install_symfile_debug_logging, _initialize_symfile_debug):
 144         Update.
 145
 146 2019-05-08  Tom Tromey  <tom@tromey.com>
 147
 148         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 149         allocate_on_obstack.
 150         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 151         (get_dwarf2_per_objfile): Update.
 152         (set_dwarf2_per_objfile): Remove.
 153         (dwarf2_has_info, dwarf2_get_section_info): Update.
 154         (dwarf2_free_objfile): Remove.
 155         (_initialize_dwarf2_read): Update.
 156
 157 2019-05-08  Tom Tromey  <tom@tromey.com>
 158
 159         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 160         initializers.
 161         <unsupported_script_warning_printed,
 162         script_not_found_warning_printed>: Now bool.
 163         (auto_load_pspace_data): Change type.
 164         (~auto_load_pspace_info): Rename from
 165         auto_load_pspace_data_cleanup.
 166         (get_auto_load_pspace_data, init_loaded_scripts_info)
 167         (clear_section_scripts, maybe_print_unsupported_script_warning)
 168         (maybe_print_script_not_found_warning, _initialize_auto_load):
 169         Update.
 170
 171 2019-05-08  Tom Tromey  <tom@tromey.com>
 172
 173         * objfiles.c (objfile_pspace_info): Add destructor and
 174         initializers.
 175         (objfiles_pspace_data): Change type.
 176         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 177         (get_objfile_pspace_data): Update.
 178         (objfiles_bfd_data): Change type.
 179         (get_objfile_bfd_data): Update.
 180         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 181
 182 2019-05-08  Tom Tromey  <tom@tromey.com>
 183
 184         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 185         Change type.
 186         (get_catch_syscall_inferior_data): Update.
 187         (catch_syscall_inferior_data_cleanup): Remove.
 188         (_initialize_break_catch_syscall): Update.
 189
 190 2019-05-08  Tom Tromey  <tom@tromey.com>
 191
 192         * inflow.c (struct terminal_info): Add destructor and
 193         initializers.
 194         (inflow_inferior_data): Change type.
 195         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 196         (get_inflow_inferior_data, inflow_inferior_exit)
 197         (swap_terminal_info, _initialize_inflow): Update.
 198
 199 2019-05-08  Tom Tromey  <tom@tromey.com>
 200
 201         * target-dcache.c (target_dcache_cleanup): Remove.
 202         (target_dcache_aspace_key): Change type.
 203         (target_dcache_init_p, target_dcache_invalidate)
 204         (target_dcache_get, target_dcache_get_or_init)
 205         (_initialize_target_dcache): Update.
 206         * dcache.h (struct dcache_deleter): New.
 207
 208 2019-05-08  Tom Tromey  <tom@tromey.com>
 209
 210         * symtab.c (struct symbol_cache): Add destructor and
 211         initializers.
 212         (symbol_cache_key): Move.  Change type.
 213         (make_symbol_cache, free_symbol_cache): Remove.
 214         (get_symbol_cache): Update.
 215         (symbol_cache_cleanup): Remove.
 216         (ALL_PSPACES, symbol_cache_flush)
 217         (maintenance_print_symbol_cache)
 218         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 219         Update.
 220
 221 2019-05-08  Tom Tromey  <tom@tromey.com>
 222
 223         * symtab.c (struct main_info): Add destructor and initializers.
 224         (main_progspace_key): Move.  Change type.
 225         (get_main_info): Update.
 226         (main_info_cleanup): Remove.
 227         (_initialize_symtab): Update.
 228
 229 2019-05-08  Tom Tromey  <tom@tromey.com>
 230
 231         * registry.h (DECLARE_REGISTRY): Define the _key class.
 232
 233 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 234
 235         * NEWS: Merge two 'New commands' sections.
 236
 237 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 238
 239         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 240         parameter and use Ada language definition instead.
 241         (ada_val_print_ptr): Remove unused language parameter.
 242         (ada_val_print_num): Remove language parameter and use Ada language
 243         definition instead.
 244         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 245         parameter.
 246         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 247         parameter and use Ada language definition instead.
 248         (ada_val_print_1): Update all ada_val_print_xxx calls.
 249         Remove language parameter.
 250         (ada_val_print): Update ada_val_print_1 call.
 251
 252 2019-05-08  Tom Tromey  <tromey@adacore.com>
 253
 254         * remote.c (remote_hw_watchpoint_limit)
 255         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 256         Now static.
 257
 258 2019-05-08  Tom Tromey  <tromey@adacore.com>
 259
 260         * maint.c (_initialize_maint_cmds): Move initialization code to
 261         remote.c.
 262         (watchdog, show_watchdog): Move to remote.c.
 263         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 264         "watchdog" static.
 265         (_initialize_remote): Move initialization code from maint.c.
 266         * defs.h (watchdog): Don't declare.
 267
 268 2019-05-08  Tom Tromey  <tromey@adacore.com>
 269
 270         * tui/tui-interp.c: Include main.h.
 271         * interps.c: Include main.h.
 272         * main.h (interpreter_p): Declare.
 273         * defs.h (interpreter_p): Don't declare.
 274
 275 2019-05-08  Tom Tromey  <tromey@adacore.com>
 276
 277         * dwarf2loc.c: Include dwarf2read.h.
 278         * defs.h (read_unsigned_leb128): Don't declare.
 279         * dwarf2read.h (read_unsigned_leb128): Declare.
 280
 281 2019-05-08  Tom Tromey  <tromey@adacore.com>
 282
 283         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 284         method.
 285
 286 2019-05-08  Tom Tromey  <tromey@adacore.com>
 287
 288         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 289         when no wrap column is set.
 290
 291 2019-05-08  Tom Tromey  <tromey@adacore.com>
 292
 293         * c-lang.c (c_get_string): Handle non-C-style arrays.
 294
 295 2019-05-08  Tom Tromey  <tromey@adacore.com>
 296
 297         * typeprint.c (print_offset_data::update): Print the bit offset,
 298         not the number of bits remaining.
 299
 300 2019-05-08  Tom Tromey  <tromey@adacore.com>
 301
 302         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 303         padding at end of comment.
 304
 305 2019-05-08  Tom Tromey  <tromey@adacore.com>
 306
 307         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 308         Compare main types.
 309
 310 2019-05-06  Tom Tromey  <tom@tromey.com>
 311
 312         * common/scoped_mmap.c: Include common-defs.h.
 313         * common/scoped_mmap.h: Don't include config.h.
 314
 315 2019-05-04  Tom Tromey  <tom@tromey.com>
 316
 317         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 318         (struct aarch64_call_info): Add initializers.
 319         <si>: Now a std::vector.
 320         (pass_on_stack, aarch64_push_dummy_call): Update.
 321
 322 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 323             Tom Tromey  <tom@tromey.com>
 324
 325         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 326         (ppc_threads): Now a std::vector.  Now static.
 327         (hwdebug_find_thread_points_by_tid)
 328         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 329         Update.
 330
 331 2019-05-04  Tom Tromey  <tom@tromey.com>
 332
 333         * arc-tdep.c (arc_tdesc_init): Return bool.
 334
 335 2019-05-04  Tom Tromey  <tom@tromey.com>
 336
 337         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 338         Use gdb_assert_not_reached.
 339
 340 2019-05-04  Tom Tromey  <tom@tromey.com>
 341
 342         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 343         "false".
 344
 345 2019-05-04  Tom Tromey  <tom@tromey.com>
 346
 347         * arc-tdep.c (arc_tdesc_init): Use bool.
 348
 349 2019-05-04  Tom Tromey  <tom@tromey.com>
 350
 351         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 352
 353 2019-05-04  Tom Tromey  <tom@tromey.com>
 354
 355         * cli/cli-cmds.c (valid_command_p): Return bool.
 356
 357 2019-05-04  Tom Tromey  <tom@tromey.com>
 358
 359         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 360         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 361
 362 2019-05-04  Raul Tambre  <raul@tambre.ee>
 363
 364         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 365         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 366         operator for comparison.
 367
 368 2019-05-04  Tom Tromey  <tom@tromey.com>
 369
 370         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 371         (lookup_partial_symbol, print_partial_symbols)
 372         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 373         (psymbol_compare): Update.
 374         (add_psymbol_to_bcache): Clear the entire psymbol.
 375         (maintenance_check_psymtabs): Update.
 376         * psympriv.h (struct partial_symbol): Don't derive from
 377         general_symbol_info.
 378         <obj_section, unrelocated_address, address,
 379         set_unrelocated_address>: Update.
 380         <ginfo>: New member.
 381         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 382         (debug_names::write_psymbols): Update.
 383
 384 2019-05-04  Tom de Vries  <tdevries@suse.de>
 385
 386         * contrib/cc-with-tweaks.sh: Support -n arg.
 387
 388 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 389
 390         * corelow.c (core_target::detach): Ensure frame cache and
 391         register caches are cleared.
 392         inferior.c (exit_inferior_1): Likewise.
 393
 394 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 395             Tom Tromey  <tom@tromey.com>
 396
 397         * dictionary.c (collate_pending_symbols_by_language): Remove
 398         "struct" from foreach.
 399         * symtab.c (lookup_global_symbol_from_objfile)
 400         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 401         foreach.
 402         * ser-tcp.c (net_open): Remove "struct" from foreach.
 403         * objfiles.c (objfile_relocate, objfile_rebase)
 404         (objfile_has_symbols): Remove "struct" from foreach.
 405         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 406         from foreach.
 407         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 408         foreach.
 409         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 410         "struct" from foreach.
 411         * ada-lang.c (create_excep_cond_exprs)
 412         (ada_exception_catchpoint_cond_string): Remove "struct" from
 413         foreach.
 414
 415 2019-05-03  Tom Tromey  <tromey@adacore.com>
 416
 417         * ada-exp.y (convert_char_literal): Check suffix of each
 418         enumerator.
 419
 420 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 421
 422         PR ada/21406:
 423         * ada-exp.y (yywrap): Don't define.
 424         * ada-lex.l (%option): Add noyywrap
 425         (yywrap): Remove.
 426
 427 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 428
 429         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 430         _WIN32_WINNT to the XP level, unless already defined to a higher
 431         level.
 432
 433         * unittests/parse-connection-spec-selftests.c:
 434         * ser-tcp.c:
 435         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 436         override.
 437
 438         * symfile.c (find_separate_debug_file): Remove colon from the
 439         drive spec of DOS/Windows file names of the target, so that the
 440         file name produced from DEBUGDIR and the target's directory will
 441         be valid on DOS/Windows systems.
 442
 443 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 444
 445         * rust-lang.c (val_print_struct): Handle printing structures
 446         containing strings.
 447
 448 2019-05-02  Tom Tromey  <tromey@adacore.com>
 449
 450         * valarith.c (_initialize_valarith): Remove.
 451
 452 2019-05-01  Tom Tromey  <tromey@adacore.com>
 453
 454         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 455         bitfields.
 456
 457 2019-05-01  Tom Tromey  <tromey@adacore.com>
 458
 459         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 460         for big-endian copies.
 461
 462 2019-04-30  Ali Tamur  <tamur@google.com>
 463         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 464         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 465         (read_3_bytes): New function.
 466
 467 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 468
 469         * windows-nat.c (main_thread_id): Delete.
 470         (handle_output_debug_string): Replace main_thread_id by
 471         current_event.dwThreadId.
 472         (fake_create_process): Likewise.
 473         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 474         Do not set main_thread_id.
 475         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 476         current_event.dwThreadId.
 477         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 478
 479 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 480
 481         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 482         Use current_event.dwThreadId instead of main_thread_id.
 483
 484 2019-04-30  Tom Tromey  <tromey@adacore.com>
 485
 486         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 487         (create_excep_cond_exprs): Iterate over program spaces.
 488         (ada_exception_catchpoint_cond_string): Examine all minimal
 489         symbols for exception types.
 490
 491 2019-04-30  Tom Tromey  <tromey@adacore.com>
 492
 493         PR c++/24470:
 494         * dwarf2read.c (process_structure_scope): Handle case where type
 495         has template parameters but no symbol was created.
 496
 497 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 498             Chris January  <chris.january@arm.com>
 499
 500         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 501         qualifier.
 502         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 503
 504 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * f-typeprint.c (f_print_type): Update rules for printing
 507         whitespace.
 508         (f_type_print_varspec_suffix): Likewise.
 509
 510 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 511             Chris January  <chris.january@arm.com>
 512
 513         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 514         function arguments.
 515
 516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * f-lang.c (build_fortran_types): Change name of void type to
 519         lower case.
 520         * f-typeprint.c (f_type_print_base): Print the name of the void
 521         type, rather than a fixed string.
 522         * f-valprint.c (f_decorations): Use lower case void string.
 523
 524 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 525             Chris January  <chris.january@arm.com>
 526
 527         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 528         types for Fortran.
 529
 530 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 531             Chris January  <chris.january@arm.com>
 532             David Lecomber  <david.lecomber@arm.com>
 533
 534         * f-exp.y (BINOP_INTRINSIC): New token.
 535         (exp): New parser rule handling BINOP_INTRINSIC.
 536         (f77_keywords): Add new builtin procedures.
 537         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 538         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 539         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 540         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 541         (print_unop_subexp_f): New function.
 542         (print_binop_subexp_f): New function.
 543         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 544         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 545         (dump_subexp_body_f): Likewise.
 546         (operator_check_f): Likewise.
 547         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 548         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 549
 550 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 551
 552         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 553         UNOP_KIND.
 554         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 555         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 556         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 557         (operator_length_f): New fuction.
 558         (print_subexp_f): New function.
 559         (op_name_f): New function.
 560         (dump_subexp_body_f): New function.
 561         (operator_check_f): New function.
 562         (exp_descriptor_f): Replace standard expression handling functions
 563         with new functions.
 564         * gdb/fortran-operator.def: New file.
 565         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 566         * gdb/std-operator.def: Remove UNOP_KIND.
 567
 568 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * std-operator.def: Remove unbalanced, stray double quote
 571         character.
 572
 573 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 574             Chris January  <chris.january@arm.com>
 575             Daniel Everett  <daniel.everett@arm.com>
 576             Nick Forrington  <nick.forrington@arm.com>
 577             Richard Bunt  <richard.bunt@arm.com>
 578
 579         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 580         of depth when printing anonymous structs or unions.
 581         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 582         Don't print either the top-level value, or the children if the
 583         max-depth is exceeded.
 584         (ppscm_print_children): When printing the key of a map, allow one
 585         extra level of depth.
 586         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 587         print either the top-level value, or the children if the max-depth
 588         is exceeded.
 589         (print_children): When printing the key of a map, allow one extra
 590         level of depth.
 591         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 592         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 593         (user_print_options): Initialise max_depth field.
 594         (val_print_scalar_or_string_type_p): New function.
 595         (val_print): Check to see if the max depth has been reached.
 596         (val_print_check_max_depth): Define new function.
 597         (show_print_max_depth): New function.
 598         (_initialize_valprint): Add 'print max-depth' option.
 599         * valprint.h (struct value_print_options) <max_depth>: New field.
 600         (val_print_check_max_depth): Declare new function.
 601         * NEWS: Document new feature.
 602
 603 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 604
 605         * ada-lang.c (ada_language_defn): Initialise new field.
 606         * c-lang.c (c_is_string_type_p): New function.
 607         (c_language_defn): Initialise new field.
 608         (cplus_language_defn): Initialise new field.
 609         (asm_language_defn): Initialise new field.
 610         (minimal_language_defn): Initialise new field.
 611         * c-lang.h (c_is_string_type_p): Declare new function.
 612         * d-lang.c (d_language_defn): Initialise new field.
 613         * f-lang.c (f_is_string_type_p): New function.
 614         (f_language_defn): Initialise new field.
 615         * go-lang.c (go_is_string_type_p): New function.
 616         (go_language_defn): Initialise new field.
 617         * language.c (default_is_string_type_p): New function.
 618         (unknown_language_defn): Initialise new field.
 619         (auto_language_defn): Initialise new field.
 620         * language.h (struct language_defn) <la_is_string_type_p>: New
 621         member variable.
 622         (default_is_string_type_p): Declare new function.
 623         * m2-lang.c (m2_language_defn): Initialise new field.
 624         * objc-lang.c (objc_language_defn): Initialise new field.
 625         * opencl-lang.c (opencl_language_defn): Initialise new field.
 626         * p-lang.c (pascal_is_string_type_p): New function.
 627         (pascal_language_defn): Initialise new field.
 628         * rust-lang.c (rust_is_string_type_p): New function.
 629         (rust_language_defn): Initialise new field.
 630
 631 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 632
 633         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 634         New field.
 635         * ada-lang.c (ada_language_defn): Initialise new field.
 636         * c-lang.c (c_language_defn): Likewise.
 637         (cplus_language_defn): Likewise.
 638         (asm_language_defn): Likewise.
 639         (minimal_language_defn): Likewise.
 640         * d-lang.c (d_language_defn): Likewise.
 641         * f-lang.c (f_language_defn): Likewise.
 642         * go-lang.c (go_language_defn): Likewise.
 643         * language.c (unknown_language_defn): Likewise.
 644         (auto_language_defn): Likewise.
 645         * m2-lang.c (m2_language_defn): Likewise.
 646         * objc-lang.c (objc_language_defn): Likewise.
 647         * opencl-lang.c (opencl_language_defn): Likewise.
 648         * p-lang.c (pascal_language_defn): Likewise.
 649         * rust-lang.c (rust_language_defn): Likewise.
 650
 651 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 652
 653         * ada-lang.c (ada_is_character_type): Change return type to bool.
 654         (ada_is_string_type): Likewise.
 655         * ada-lang.h (ada_is_character_type): Update declaration
 656         (ada_is_string_type): Likewise.
 657
 658 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 659
 660         Support style in 'frame|thread apply'
 661
 662         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 663         * record.c (record_start, record_stop): Update callers of
 664         execute_command_to_string with false.
 665         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 666         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 667         methods.
 668         (class string_file): New constructor with term_out parameter.
 669         Override methods term_out and can_emit_style_escape.  New member
 670         term_out.
 671         (class stdio_file): Override can_emit_style_escape.
 672         (class tee_file): Override term_out and can_emit_style_escape.
 673         * utils.h (can_emit_style_escape): Remove.
 674         * utils.c (can_emit_style_escape): Likewise.
 675         Update all callers of can_emit_style_escape (SOMESTREAM) to
 676         SOMESTREAM->can_emit_style_escape.
 677         * source-cache.c (source_cache::get_source_lines): Likewise.
 678         * stack.c (frame_apply_command_count): Call execute_command_to_string
 679         passing the term_out characteristic of the current gdb_stdout.
 680         * thread.c (thr_try_catch_cmd): Likewise.
 681         * top.c (execute_command_to_string): pass term_out parameter
 682         to construct the string_file for the command output.
 683         * ui-file.c (term_cli_styling): New function (most code moved
 684         from utils.c can_emit_style_escape).
 685         (string_file::string_file, string_file::can_emit_style_escape,
 686         stdio_file::can_emit_style_escape, tee_file::term_out,
 687         tee_file::can_emit_style_escape): New functions.
 688
 689 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 690
 691         * NEWS: Mention the new set|show may-call-functions.
 692         * infcall.c (may_call_functions_p): New variable.
 693         (show_may_call_functions_p): New function.
 694         (call_function_by_hand_dummy): Throws an error if not
 695         may-call-functions.
 696         (_initialize_infcall): Call add_setshow_boolean_cmd for
 697         may-call-functions.
 698
 699 2019-04-25  Keith Seitz  <keiths@redhat.com>
 700
 701         PR c++/24367
 702         * cp-support.c (inspect_type): Don't attempt substitutions
 703         of symbol with the same name.
 704
 705 2019-04-25  Tom Tromey  <tromey@adacore.com>
 706
 707         PR gdb/24475:
 708         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 709         static.
 710
 711 2019-04-25  Tom Tromey  <tromey@adacore.com>
 712
 713         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 714         rvalue reference.
 715         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 716         (gdb_xml_parser::parse): Use std::move.
 717         * python/python-internal.h (gdbpy_convert_exception): Take a const
 718         reference.
 719         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 720         std::move.
 721         * python/py-utils.c (gdbpy_convert_exception): Take a const
 722         reference.
 723         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 724         Use std::move.
 725         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 726         Use std::move.
 727         * mi/mi-main.c (mi_print_exception): Take a const reference.
 728         * main.c (handle_command_errors): Take a const reference.
 729         * linespec.c (parse_linespec): Use std::move.
 730         * infcall.c (run_inferior_call): Use std::move.
 731         (call_function_by_hand_dummy): Use std::move.
 732         * exec.c (try_open_exec_file): Use std::move.
 733         * exceptions.h (exception_print, exception_fprintf)
 734         (exception_print_same): Update.
 735         * exceptions.c (print_exception, exception_print)
 736         (exception_fprintf, exception_print_same): Change parameters to
 737         const reference.
 738         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 739         * common/new-op.c: Use std::move.
 740         * common/common-exceptions.h (struct gdb_exception): Add move
 741         constructor.
 742         (struct gdb_exception_error, struct gdb_exception_quit, struct
 743         gdb_quit_bad_alloc): Change constructor to move constructor.
 744         (throw_exception): Change parameter to rvalue reference.
 745         * common/common-exceptions.c (throw_exception): Take rvalue
 746         reference.
 747         * cli/cli-interp.c (safe_execute_command): Use std::move.
 748         * breakpoint.c (insert_bp_location, location_to_sals): Use
 749         std::move.
 750
 751 2019-04-25  Tom Tromey  <tromey@adacore.com>
 752
 753         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 754         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 755         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 756         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 757         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 758         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 759         guile/scm-value.c: Use unpack.
 760         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 761         gdbscm_gdb_exception.
 762         (gdbscm_throw_gdb_exception): Likewise.
 763         (struct gdbscm_gdb_exception): New.
 764         (unpack): New function.
 765         (gdbscm_wrap): Use unpack.
 766
 767 2019-04-25  Tom Tromey  <tromey@adacore.com>
 768
 769         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 770         (gdb_rl_callback_handler): Use std::move.
 771         * common/common-exceptions.h (struct gdb_exception): Add move
 772         assignment operator.
 773         (throw_exception_sjlj): Change "exception" to const reference.
 774         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 775         (throw_exception_sjlj): Change "exception" to const reference.
 776
 777 2019-04-25  Tom Tromey  <tromey@adacore.com>
 778
 779         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 780         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 781         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 782         Update.
 783         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 784         Update.
 785         * mi/mi-interp.c (mi_interp::exec): Update.
 786         * linespec.c (parse_linespec): Update.
 787         * infcall.c (run_inferior_call): Update.
 788         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 789         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 790         (gdbscm_lookup_global_symbol): Update.
 791         * guile/scm-param.c (gdbscm_parameter_value): Update.
 792         * guile/scm-frame.c (gdbscm_frame_read_register)
 793         (gdbscm_frame_read_var): Update.
 794         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 795         * exec.c (try_open_exec_file): Update.
 796         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 797         (gdb_rl_callback_handler): Update.
 798         * common/common-exceptions.h (exception_none): Don't declare.
 799         * common/common-exceptions.c (exception_none): Don't define.
 800         (struct catcher) <exception>: Update.
 801         * cli/cli-interp.c (safe_execute_command): Update.
 802         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 803
 804 2019-04-25  Ali Tamur  <tamur@google.com>
 805
 806         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 807         (read_attribute_value): Likewise.
 808         (dwarf2_read_addr_index): Update comment.
 809         (read_str_index): Add DW_FORM_strx.
 810         (dwarf2_string_attr): Likewise.
 811         (dwarf2_const_value_attr): Likewise.
 812         (dump_die_shallow): Likewise.
 813         (dwarf2_fetch_constant_bytes): Likewise.
 814         (skip_form_bytes): Likewise.
 815         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 816
 817 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 818
 819         PR corefiles/11608
 820         PR corefiles/18187
 821         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 822         OFFSET.  Verify if current mapping contains an ELF header.
 823         (linux_find_memory_regions_full): Adjust call to
 824         dump_mapping_p.
 825
 826 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 827             Kang Li <kanglictf@gmail.com>
 828
 829         PR gdb/21600
 830
 831         * dwarf2-frame.c (read_initial_length): Be consistent about using
 832         unsigned representation of length.
 833         (decode_frame_entry_1): Likewise.  Check for wraparound of
 834         end pointer as well as buffer overflow.
 835
 836 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 837
 838         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 839         "vq".
 840
 841 2019-04-24  Tom Tromey  <tromey@adacore.com>
 842
 843         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 844
 845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * s12z-tdep.c (s12z_unwind_pc): Delete.
 848         (s12z_unwind_sp): Delete.
 849         (s12z_gdbarch_init): Don't register deleted functions with
 850         gdbarch.
 851
 852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * rl78-tdep.c (rl78_unwind_sp): Delete.
 855         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 856
 857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 860         (xstormy16_unwind_pc): Delete.
 861         (xstormy16_dummy_id): Delete.
 862         (xstormy16_gdbarch_init): Don't register deleted functions with
 863         gdbarch.
 864
 865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 866
 867         * vax-tdep.c (vax_unwind_pc): Delete.
 868         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 869
 870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * v850-tdep.c (v850_unwind_sp): Delete.
 873         (v850_unwind_pc): Delete.
 874         (v850_dummy_id): Delete.
 875         (v850_gdbarch_init): Don't register deleted functions with
 876         gdbarch.
 877
 878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 881         (tilegx_unwind_pc): Delete.
 882         (tilegx_unwind_dummy_id): Delete.
 883         (tilegx_gdbarch_init): Don't register deleted functions with
 884         gdbarch.
 885
 886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 889         (tic6x_dummy_id): Delete.
 890         (tic6x_gdbarch_init): Don't register deleted functions with
 891         gdbarch.
 892
 893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * sparc-tdep.c (sparc_unwind_pc): Delete.
 896         (sparc32_gdbarch_init): Don't register deleted function with
 897         gdbarch.
 898
 899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * sh-tdep.c (sh_unwind_sp): Delete.
 902         (sh_unwind_pc): Delete.
 903         (sh_dummy_id): Delete.
 904         (sh_gdbarch_init): Don't register deleted functions with
 905         gdbarch.
 906
 907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * score-tdep.c (score_unwind_sp): Delete.
 910         (score_unwind_pc): Delete.
 911         (score_dummy_id): Delete.
 912         (score_gdbarch_init): Don't register deleted functions with
 913         gdbarch.
 914
 915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * rx-tdep.c (rx_unwind_pc): Delete.
 918         (rx_unwind_sp): Delete.
 919         (rx_dummy_id): Delete.
 920         (rx_gdbarch_init): Don't register deleted functions with
 921         gdbarch.  Update comment.
 922
 923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 926         (rs6000_dummy_id): Delete.
 927         (rs6000_gdbarch_init): Don't register deleted functions with
 928         gdbarch.
 929
 930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * or1k-tdep.c (or1k_dummy_id): Delete.
 933         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 934
 935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * nios2-tdep.c (nios2_dummy_id): Delete.
 938         (nios2_unwind_sp): Delete.
 939         (nios2_gdbarch_init): Don't register deleted functions with
 940         gdbarch.
 941
 942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 943
 944         * nds32-tdep.c (nds32_dummy_id): Delete.
 945         (nds32_unwind_pc): Delete.
 946         (nds32_unwind_sp): Delete.
 947         (nds32_gdbarch_init): Don't register deleted functions with
 948         gdbarch.
 949
 950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * msp430-tdep.c (msp430_unwind_pc): Delete.
 953         (msp430_unwind_sp): Delete.
 954         (msp430_dummy_id): Delete.
 955         (msp430_gdbarch_init): Don't register deleted functions with
 956         gdbarch.
 957
 958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * moxie-tdep.c (moxie_unwind_sp): Delete.
 961         (moxie_unwind_pc): Delete.
 962         (moxie_dummy_id): Delete.
 963         (moxie_gdbarch_init): Don't register deleted functions with
 964         gdbarch.
 965
 966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 967
 968         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 969         (mn10300_unwind_pc): Delete.
 970         (mn10300_unwind_sp): Delete.
 971         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 972         mn10300_unwind_sp.
 973         (mn10300_frame_unwind_init): Don't register deleted functions with
 974         gdbarch.
 975
 976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         * mep-tdep.c (mep_unwind_pc): Delete.
 979         (mep_unwind_sp): Delete.
 980         (mep_dummy_id): Delete.
 981         (mep_gdbarch_init): Don't register deleted functions with
 982         gdbarch.
 983
 984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 987         (m68hc11_unwind_sp): Delete.
 988         (m68hc11_gdbarch_init): Don't register deleted functions with
 989         gdbarch.
 990
 991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 992
 993         * m32r-tdep.c (m32r_unwind_sp): Delete.
 994         (m32r_unwind_pc): Delete.
 995         (m32r_dummy_id): Delete.
 996         (m32r_gdbarch_init): Don't register deleted functions with
 997         gdbarch.
 998
 999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * m32c-tdep.c (m32c_unwind_pc): Delete.
1002         (m32c_unwind_sp): Delete.
1003         (m32c_dummy_id): Delete.
1004         (m32c_gdbarch_init): Don't register deleted functions with
1005         gdbarch.
1006
1007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1010         (lm32_unwind_pc): Delete.
1011         (lm32_dummy_id): Delete.
1012         (lm32_gdbarch_init): Don't register deleted functions with
1013         gdbarch.
1014
1015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1018         (iq2000_unwind_pc): Delete.
1019         (iq2000_dummy_id): Delete.
1020         (iq2000_gdbarch_init): Don't register deleted functions with
1021         gdbarch.
1022
1023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * nds32-tdep.c (nds32_type_align): Delete.
1026         (nds32_push_dummy_call): Use type_align instead.
1027
1028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * arm-tdep.c (arm_type_align): Only handle vector override case.
1031         (arm_push_dummy_call): Use type_align.
1032         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1033
1034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1037         case.
1038         (pass_on_stack): Use type_align.
1039         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1040         function.
1041
1042 2019-04-23  Tom Tromey  <tromey@adacore.com>
1043
1044         * dwarf2read.c (line_header::file_name_at): Remove unused
1045         overload.
1046
1047 2019-04-23  Tom de Vries  <tdevries@suse.de>
1048
1049         PR gdb/24438
1050         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1051         invocation.
1052
1053
1054 2019-03-27  Ali Tamur  <tamur@google.com>
1055
1056         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1057         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1058         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1059         (dwarf_expr_context::get_addr_index): Likewise
1060         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1061         (symbol_needs_eval_context::get_addr_index): Likewise
1062         (disassemble_dwarf_expression): Add DW_OP_addrx
1063         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1064         (read_cutu_die_from_dwo): Update comment
1065         (skip_one_die): Add DW_FORM_addrx
1066         (read_attribute_value): Likewise
1067         (var_decode_location): Add DW_OP_addrx
1068         (dwarf2_const_value_attr): Add DW_FORM_addrx
1069         (dump_die_shallow): Likewise
1070         (dwarf2_fetch_constant_bytes): Likewise
1071         (decode_locdesc): Add DW_OP_addrx
1072         (skip_form_bytes): Add DW_FORM_addrx
1073
1074 2019-04-22  Ali Tamur  <tamur@google.com>
1075
1076         * MAINTAINERS (Write After Approval): Add self.
1077
1078 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1079
1080         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1081         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1082         (open_symbol_file_object): Likewise.
1083         (svr4_default_sos): Add info parameter.
1084         (svr4_read_so_list): Likewise.
1085         (svr4_current_sos_direct): Adjust functions calls to pass down
1086         info.
1087         (svr4_current_sos_1): Add info parameter.
1088         (svr4_current_sos): Call get_svr4_info, pass info down to
1089         svr4_current_sos_1.
1090         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1091         get_svr4_info.
1092         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1093         get_svr4_info.
1094         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1095         to get_svr4_info.
1096         (probes_table_remove_objfile_probes): Likewise.
1097         (register_solib_event_probe): Add info parameter.
1098         (solist_update_incremental): Pass info parameter down to
1099         svr4_read_so_list.
1100         (disable_probes_interface): Add info parameter.
1101         (svr4_handle_solib_event): Pass current_program_space to
1102         get_svr4_info.  Adjust disable_probes_interface cleanup.
1103         (svr4_create_probe_breakpoints): Add info parameter, pass it
1104         down to register_solib_event_probe.
1105         (svr4_create_solib_event_breakpoints): Add info parameter,
1106         pass it down to svr4_create_probe_breakpoints.
1107         (enable_break): Pass info down to
1108         svr4_create_solib_event_breakpoints.
1109         (svr4_solib_create_inferior_hook): Pass current_program_space to
1110         get_svr4_info.
1111         (svr4_clear_solib): Likewise.
1112
1113 2019-04-22  Pedro Alves  <palves@redhat.com>
1114
1115         * solib-svr4.c (svr4_free_objfile_observer): New.
1116         (probe_and_action::objfile): New field.
1117         (probes_table_htab_remove_objfile_probes)
1118         (probes_table_remove_objfile_probes): New functions.
1119         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1120         in the new probe_and_action.  Don't store the probe in 'lookup'.
1121         (svr4_create_probe_breakpoints): Pass objfile to
1122         register_solib_event_probe.
1123         (_initialize_svr4_solib): Register a free_objfile observer.
1124
1125 2019-04-19  Tom Tromey  <tom@tromey.com>
1126
1127         * common/queue.h: Remove.
1128
1129 2019-04-19  Tom Tromey  <tom@tromey.com>
1130
1131         * event-loop.c: Don't include "common/queue.h".
1132
1133 2019-04-19  Tom Tromey  <tom@tromey.com>
1134
1135         * remote.c (remote_target): Use delete.
1136         * remote-notif.h: Include <list>, not "common/queue.h".
1137         (notif_client_p): Remove typedef.
1138         (remote_notif_state): Add constructor, destructor, initializer.
1139         <notif_queue>: Now a std::list.
1140         (remote_notif_state_xfree): Don't declare.
1141         * remote-notif.c (remote_notif_process, handle_notification)
1142         (remote_notif_state_allocate): Update.
1143         (~remote_notif_state): Rename from remote_notif_state_xfree.
1144
1145 2019-04-19  Tom Tromey  <tom@tromey.com>
1146
1147         * symfile.c (reread_symbols): Update.
1148         * objfiles.c (objfile_register_static_link)
1149         (objfile_lookup_static_link): Update
1150         (~objfile) Don't delete static_links.
1151         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1152
1153 2019-04-19  Tom Tromey  <tom@tromey.com>
1154
1155         * type-stack.h (struct type_stack) <insert>: Constify string.
1156         * type-stack.c (type_stack::insert): Constify string.
1157         * gdbtypes.h (lookup_template_type): Update.
1158         (address_space_name_to_int): Update.
1159         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1160         const.
1161         (lookup_template_type): Make name const.
1162         * c-exp.y: Update rules.
1163         (lex_one_token, classify_name, classify_inner_name)
1164         (c_print_token): Update.
1165         * p-exp.y: Update rules.
1166         (yylex): Update.
1167         * f-exp.y: Update rules.
1168         (yylex): Update.
1169         * d-exp.y: Update rules.
1170         (lex_one_token, classify_name, classify_inner_name): Update.
1171         * parse.c (write_dollar_variable, copy_name): Return std::string.
1172         * parser-defs.h (copy_name): Change return type.
1173         * m2-exp.y: Update rules.
1174         (yylex): Update.
1175         * go-exp.y (lex_one_token): Update.
1176         Update rules.
1177         (classify_unsafe_function, classify_packaged_name)
1178         (classify_name, yylex): Update.
1179
1180 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1181
1182         * configure.ac: add --enable-source-highlight switch.
1183         * configure: Regenerate.
1184         * top.c (print_gdb_version): plumb --enable-source-highlight
1185         status to "show configuration".
1186
1187 2019-04-19  Tom Tromey  <tromey@adacore.com>
1188
1189         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1190         Check ADA_TYPE_P.
1191         (empty_record, ada_template_to_fixed_record_type_1)
1192         (template_to_static_fixed_type)
1193         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1194         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1195         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1196         macros.
1197
1198 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1199
1200         PR symtab/24423:
1201         * source.c (print_source_lines_base): Advance "iter" when a
1202         control character is seen.
1203
1204 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1205
1206         * inferior.h (struct infcall_suspend_state_deleter):
1207         Catch exception in destructor to avoid crash.
1208
1209 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1210
1211         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1212         close to the add_com "shell".
1213
1214 2019-04-18  Tom Tromey  <tromey@adacore.com>
1215
1216         * process-stratum-target.h (class process_stratum_target)
1217         <stratum>: Add "final".
1218
1219 2019-04-17  Tom Tromey  <tromey@adacore.com>
1220
1221         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1222         against nullptr before use.
1223
1224 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1225
1226         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1227
1228 2019-04-17  Jim Wilson  <jimw@sifive.com>
1229             Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1232         code read might fail, assume 4-byte breakpoint in that case.
1233
1234 2019-04-15  Leszek Swirski  <leszeks@google.com>
1235
1236         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1237         rather than a hand-rolled POD check when checking for forced MEMORY
1238         classification.
1239
1240 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1241
1242         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1243         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1244         function.
1245         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1246         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1247         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1248         declaration.
1249
1250 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1251
1252         * aarch64-linux-nat.c
1253         (aarch64_linux_nat_target::thread_architecture): Add override.
1254         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1255         each VQ.
1256
1257 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1258
1259         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1260
1261 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1264         target types of size 96-bits, add some additional comments, and
1265         check that the builtin type we found was the correct size.
1266
1267 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1268
1269         * utils.c (prompt_for_continue): Don't restore the styling at the
1270         end, as applied_style has the wrong value.  This fixes styling in
1271         long lists of file names that are interrupted by the "Continue?"
1272         prompt.
1273
1274 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1277         * c-lang.c (c_language_defn): Likewise.
1278         (cplus_language_defn): Likewise.
1279         (asm_language_defn): Likewise.
1280         (minimal_language_defn): Likewise.
1281         * d-lang.c (d_language_defn): Likewise.
1282         * f-lang.c (f_language_defn): Likewise.
1283         * go-lang.c (go_language_defn): Likewise.
1284         * language.c (unknown_language_defn): Likewise.
1285         (auto_language_defn): Likewise.
1286         * language.h (struct language_defn): Remove la_magic field.
1287         (LANG_MAGIC): Delete.
1288         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1289         * objc-lang.c (objc_language_defn): Likewise.
1290         * opencl-lang.c (opencl_language_defn): Likewise.
1291         * p-lang.c (pascal_language_defn): Likewise.
1292         * rust-lang.c (rust_language_defn): Likewise.
1293
1294 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * riscv-tdep.c (riscv_type_align): New function.
1297         (riscv_type_alignment): Delete.
1298         (riscv_arg_location): Use 'type_align'.
1299         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1300
1301 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * gdbtypes.c (type_align): A struct with no non-static fields also
1304         has alignment of 1.
1305
1306 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1307
1308         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1309         component to 0.
1310         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1311         member.
1312         (riscv_struct_info::analyse): New implementation using new
1313         analyse_inner member function.
1314         (riscv_struct_info::field_offset): New member function.
1315         (riscv_struct_info::m_offsets): New member variable.
1316         (riscv_struct_info::analyse_inner): New private member function,
1317         takes the old implementation of riscv_struct_info::analyse but
1318         extended to track field offsets.
1319         (riscv_call_arg_struct): Update the struct folding special cases
1320         to handle cases where empty C++ structs, which are non-zero
1321         length, are found.
1322         (riscv_arg_location): Initialise the length of each location, a
1323         non-zero length now indicates the location is in use.
1324         (riscv_push_dummy_call): Allow for the first location having a
1325         non-zero offset when setting up arguments.
1326         (riscv_return_value): Likewise, but for return values.
1327
1328 2019-04-11  Tom Tromey  <tromey@adacore.com>
1329
1330         * utils.c (internal_vproblem): Make "msg" const.
1331
1332 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1333
1334         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1335         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1336         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1337         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1338
1339 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1340
1341         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1342         function.
1343         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1344         of amd64_collect_native_gregset.
1345         (amd64_linux_nat_target::store_registers): Likewise.
1346
1347 2019-04-10  Tom Tromey  <tom@tromey.com>
1348
1349         * symtab.c (lookup_global_symbol_from_objfile)
1350         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1351         * objfiles.h (class separate_debug_iterator): New.
1352         (class separate_debug_range): New.
1353         (struct objfile) <separate_debug_objfiles>: New method.
1354         (objfile_separate_debug_iterate): Don't declare.
1355         * objfiles.c (separate_debug_iterator::operator++): Rename from
1356         objfile_separate_debug_iterate.
1357         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1358         iterator.
1359         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1360         iterator.
1361
1362 2019-04-10  Tom Tromey  <tom@tromey.com>
1363
1364         * symfile.c (reread_symbols): Remove old comment.
1365         * objfiles.c (free_all_objfiles): Fix a typo.
1366
1367 2019-04-10  Tom Tromey  <tom@tromey.com>
1368
1369         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1370         * minsyms.c (lookup_minimal_symbol): Use foreach.
1371         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1372         (lookup_minimal_symbol_solib_trampoline): Likewise.
1373         * symfile.c (reread_symbols): Use foreach.
1374
1375 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1376             Tom Tromey  <tromey@adacore.com>
1377
1378         PR rust/24414:
1379         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1380         (rust_lex_int_test): Change "value" to be LONGEST.
1381         (rust_lex_tests): Add test for long integer literal.
1382
1383 2019-04-09  Tom Tromey  <tromey@adacore.com>
1384
1385         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1386         to bool.
1387         (extended_remote_target::attach): Update.
1388         (remote_target::remote_notice_new_inferior): Update.
1389         (remote_target::add_current_inferior_and_thread): Update.
1390         * inferior.c (exit_inferior_1): Use "false".
1391         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1392
1393 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1394
1395         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1396         the "start" command.
1397
1398 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1399
1400         * python/py-inferior.c (infpy_thread_from_thread_handle):
1401         Adjust comments to reflect renaming of thread_from_thread_handle
1402         to thread_from_handle.  Adjust keywords.  Fix type error message.
1403         (inferior_object_methods): Add thread_from_handle.  Retain
1404         thread_from_thread_handle, but mark it as deprecated.
1405
1406 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1407
1408         * gdbthread.h (find_thread_by_handle): Revise declaration.
1409         * thread.c (find_thread_by_handle): Likewise.  Adjust
1410         implementation too.
1411         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1412         support for buffer objects as handles.
1413
1414 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1415
1416         * python/py-infthread.c (thpy_thread_handle): New function.
1417         (thread_object_methods): Register thpy_thread_handle.
1418
1419 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1420
1421         * gdbthread.h (thread_to_thread_handle): Declare.
1422         * thread.c (gdbtypes.h): Include.
1423         (thread_to_thread_handle): New function.
1424
1425         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1426         (target_thread_info_to_thread_handle): Declare.
1427         * target.c (target_thread_info_to_thread_handle): New function.
1428         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1429         * target-delegates.c: Regenerate.
1430
1431         * linux-thread-db.c (class thread_db_target): Add method
1432         thread_info_to_thread_handle.
1433         (thread_db_target::thread_info_to_thread_handle): Define.
1434         * remote.c (class remote_target): Add new method
1435         thread_info_to_thread_handle.
1436         (remote_target::thread_info_to_thread_handle): Define.
1437
1438 2019-04-08  Pedro Alves  <palves@redhat.com>
1439
1440         * common/common-exceptions.c (throw_exception): Don't create
1441         named object to throw; throw directly.
1442         (throw_it): Likewise.  Don't initialize gdb_exception::message
1443         here, with new; pass FMT and AP to the ctor instead.
1444         * common/common-exceptions.h: Include <string>.
1445         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1446         const char *, va_list)): New ctor.  Use std::make_shared.
1447         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1448         errors)): Delete.
1449         (gdb_exception_error::gdb_exception_error(enum errors, const char
1450         *, va_list)): New.
1451         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1452         Add assertion.
1453         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1454         errors)): Delete.
1455         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1456         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1457         Add assertion.
1458
1459 2019-04-08  Tom Tromey  <tom@tromey.com>
1460
1461         * valops.c (value_rtti_indirect_type): Replace throw_exception
1462         with throw.
1463         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1464         with throw.
1465         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1466         throw.
1467         * target.c (target_translate_tls_address): Replace throw_exception
1468         with throw.
1469         * stack.c (frame_apply_command_count): Replace throw_exception
1470         with throw.
1471         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1472         throw.
1473         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1474         with throw.
1475         * rs6000-tdep.c (rs6000_frame_cache)
1476         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1477         * remote.c: Replace throw_exception with throw.
1478         * record-full.c (record_full_message, record_full_wait_1)
1479         (record_full_restore): Replace throw_exception with throw.
1480         * record-btrace.c:
1481         (get_thread_current_frame_id, record_btrace_start_replaying)
1482         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1483         (cmd_record_btrace_start): Replace throw_exception with throw.
1484         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1485         throw.
1486         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1487         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1488         * linespec.c:
1489         (find_linespec_symbols): Replace throw_exception with throw.
1490         * infrun.c (displaced_step_prepare, resume): Replace
1491         throw_exception with throw.
1492         * infcmd.c (post_create_inferior): Replace throw_exception with
1493         throw.
1494         * inf-loop.c (inferior_event_handler): Replace throw_exception
1495         with throw.
1496         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1497         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1498         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1499         (get_prev_frame_always, get_frame_pc_if_available)
1500         (get_frame_address_in_block_if_available, get_frame_language):
1501         Replace throw_exception with throw.
1502         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1503         throw_exception with throw.
1504         * eval.c (fetch_subexp_value, evaluate_var_value)
1505         (evaluate_funcall, evaluate_subexp_standard): Replace
1506         throw_exception with throw.
1507         * dwarf2loc.c (call_site_find_chain)
1508         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1509         Replace throw_exception with throw.
1510         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1511         with throw.
1512         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1513         throw.
1514         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1515         * completer.c (complete_line_internal): Replace throw_exception
1516         with throw.
1517         * compile/compile-object-run.c (compile_object_run): Replace
1518         throw_exception with throw.
1519         * cli/cli-script.c (process_next_line): Replace throw_exception
1520         with throw.
1521         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1522         (btrace_enable, btrace_maint_update_pt_packets): Replace
1523         throw_exception with throw.
1524         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1525         throw_exception with throw.
1526         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1527         throw_exception with throw.
1528         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1529         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1530         * aarch64-tdep.c (aarch64_make_prologue_cache)
1531         (aarch64_make_stub_cache): Replace throw_exception with throw.
1532
1533 2019-04-08  Tom Tromey  <tom@tromey.com>
1534
1535         * common/common-exceptions.c (throw_exception): Rename from
1536         throw_exception_cxx.  Remove old copy.  Make argument const.
1537         (throw_it): Create and throw exception objects directly.
1538         * common/common-exceptions.h (throw_exception): Make argument
1539         const.
1540         (struct gdb_exception_error): Add constructor.
1541         (struct gdb_exception_quit): Add constructor.
1542
1543 2019-04-08  Tom Tromey  <tom@tromey.com>
1544
1545         * common/common-exceptions.h (exception_rethrow): Don't declare.
1546         (TRY_SJLJ): Update comment.
1547         (TRY, CATCH, END_CATCH): Remove.
1548         * common/common-exceptions.c (exception_rethrow): Remove.
1549
1550 2019-04-08  Tom Tromey  <tom@tromey.com>
1551
1552         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1553         Remove.
1554         (gdb_exception_error): Rename from
1555         gdb_exception_RETURN_MASK_ERROR.
1556         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1557         (gdb_quit_bad_alloc): Update.
1558         * aarch64-tdep.c: Update.
1559         * ada-lang.c: Update.
1560         * ada-typeprint.c: Update.
1561         * ada-valprint.c: Update.
1562         * amd64-tdep.c: Update.
1563         * arch-utils.c: Update.
1564         * break-catch-throw.c: Update.
1565         * breakpoint.c: Update.
1566         * btrace.c: Update.
1567         * c-varobj.c: Update.
1568         * cli/cli-cmds.c: Update.
1569         * cli/cli-interp.c: Update.
1570         * cli/cli-script.c: Update.
1571         * common/common-exceptions.c: Update.
1572         * common/new-op.c: Update.
1573         * common/selftest.c: Update.
1574         * compile/compile-c-symbols.c: Update.
1575         * compile/compile-cplus-symbols.c: Update.
1576         * compile/compile-object-load.c: Update.
1577         * compile/compile-object-run.c: Update.
1578         * completer.c: Update.
1579         * corelow.c: Update.
1580         * cp-abi.c: Update.
1581         * cp-support.c: Update.
1582         * cp-valprint.c: Update.
1583         * darwin-nat.c: Update.
1584         * disasm-selftests.c: Update.
1585         * dtrace-probe.c: Update.
1586         * dwarf-index-cache.c: Update.
1587         * dwarf-index-write.c: Update.
1588         * dwarf2-frame-tailcall.c: Update.
1589         * dwarf2-frame.c: Update.
1590         * dwarf2loc.c: Update.
1591         * dwarf2read.c: Update.
1592         * eval.c: Update.
1593         * event-loop.c: Update.
1594         * event-top.c: Update.
1595         * exec.c: Update.
1596         * f-valprint.c: Update.
1597         * fbsd-tdep.c: Update.
1598         * frame-unwind.c: Update.
1599         * frame.c: Update.
1600         * gdbtypes.c: Update.
1601         * gnu-v3-abi.c: Update.
1602         * guile/guile-internal.h: Update.
1603         * guile/scm-block.c: Update.
1604         * guile/scm-breakpoint.c: Update.
1605         * guile/scm-cmd.c: Update.
1606         * guile/scm-disasm.c: Update.
1607         * guile/scm-frame.c: Update.
1608         * guile/scm-lazy-string.c: Update.
1609         * guile/scm-math.c: Update.
1610         * guile/scm-param.c: Update.
1611         * guile/scm-ports.c: Update.
1612         * guile/scm-pretty-print.c: Update.
1613         * guile/scm-symbol.c: Update.
1614         * guile/scm-symtab.c: Update.
1615         * guile/scm-type.c: Update.
1616         * guile/scm-value.c: Update.
1617         * i386-linux-tdep.c: Update.
1618         * i386-tdep.c: Update.
1619         * inf-loop.c: Update.
1620         * infcall.c: Update.
1621         * infcmd.c: Update.
1622         * infrun.c: Update.
1623         * jit.c: Update.
1624         * language.c: Update.
1625         * linespec.c: Update.
1626         * linux-fork.c: Update.
1627         * linux-nat.c: Update.
1628         * linux-tdep.c: Update.
1629         * linux-thread-db.c: Update.
1630         * main.c: Update.
1631         * mi/mi-cmd-break.c: Update.
1632         * mi/mi-cmd-stack.c: Update.
1633         * mi/mi-interp.c: Update.
1634         * mi/mi-main.c: Update.
1635         * objc-lang.c: Update.
1636         * p-valprint.c: Update.
1637         * parse.c: Update.
1638         * ppc-linux-tdep.c: Update.
1639         * printcmd.c: Update.
1640         * python/py-arch.c: Update.
1641         * python/py-breakpoint.c: Update.
1642         * python/py-cmd.c: Update.
1643         * python/py-finishbreakpoint.c: Update.
1644         * python/py-frame.c: Update.
1645         * python/py-framefilter.c: Update.
1646         * python/py-gdb-readline.c: Update.
1647         * python/py-inferior.c: Update.
1648         * python/py-infthread.c: Update.
1649         * python/py-lazy-string.c: Update.
1650         * python/py-linetable.c: Update.
1651         * python/py-objfile.c: Update.
1652         * python/py-param.c: Update.
1653         * python/py-prettyprint.c: Update.
1654         * python/py-progspace.c: Update.
1655         * python/py-record-btrace.c: Update.
1656         * python/py-record.c: Update.
1657         * python/py-symbol.c: Update.
1658         * python/py-type.c: Update.
1659         * python/py-unwind.c: Update.
1660         * python/py-utils.c: Update.
1661         * python/py-value.c: Update.
1662         * python/python.c: Update.
1663         * record-btrace.c: Update.
1664         * record-full.c: Update.
1665         * remote-fileio.c: Update.
1666         * remote.c: Update.
1667         * riscv-tdep.c: Update.
1668         * rs6000-aix-tdep.c: Update.
1669         * rs6000-tdep.c: Update.
1670         * rust-exp.y: Update.
1671         * rust-lang.c: Update.
1672         * s390-tdep.c: Update.
1673         * selftest-arch.c: Update.
1674         * solib-dsbt.c: Update.
1675         * solib-frv.c: Update.
1676         * solib-spu.c: Update.
1677         * solib-svr4.c: Update.
1678         * solib.c: Update.
1679         * sparc64-linux-tdep.c: Update.
1680         * stack.c: Update.
1681         * symfile-mem.c: Update.
1682         * symmisc.c: Update.
1683         * target.c: Update.
1684         * thread.c: Update.
1685         * top.c: Update.
1686         * tracefile-tfile.c: Update.
1687         * tui/tui.c: Update.
1688         * typeprint.c: Update.
1689         * unittests/cli-utils-selftests.c: Update.
1690         * unittests/parse-connection-spec-selftests.c: Update.
1691         * valops.c: Update.
1692         * valprint.c: Update.
1693         * value.c: Update.
1694         * varobj.c: Update.
1695         * windows-nat.c: Update.
1696         * x86-linux-nat.c: Update.
1697         * xml-support.c: Update.
1698
1699 2019-04-08  Tom Tromey  <tom@tromey.com>
1700
1701         * xml-support.c: Use C++ exception handling.
1702         * x86-linux-nat.c: Use C++ exception handling.
1703         * windows-nat.c: Use C++ exception handling.
1704         * varobj.c: Use C++ exception handling.
1705         * value.c: Use C++ exception handling.
1706         * valprint.c: Use C++ exception handling.
1707         * valops.c: Use C++ exception handling.
1708         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1709         handling.
1710         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1711         * typeprint.c: Use C++ exception handling.
1712         * tui/tui.c: Use C++ exception handling.
1713         * tracefile-tfile.c: Use C++ exception handling.
1714         * top.c: Use C++ exception handling.
1715         * thread.c: Use C++ exception handling.
1716         * target.c: Use C++ exception handling.
1717         * symmisc.c: Use C++ exception handling.
1718         * symfile-mem.c: Use C++ exception handling.
1719         * stack.c: Use C++ exception handling.
1720         * sparc64-linux-tdep.c: Use C++ exception handling.
1721         * solib.c: Use C++ exception handling.
1722         * solib-svr4.c: Use C++ exception handling.
1723         * solib-spu.c: Use C++ exception handling.
1724         * solib-frv.c: Use C++ exception handling.
1725         * solib-dsbt.c: Use C++ exception handling.
1726         * selftest-arch.c: Use C++ exception handling.
1727         * s390-tdep.c: Use C++ exception handling.
1728         * rust-lang.c: Use C++ exception handling.
1729         * rust-exp.y: Use C++ exception handling.
1730         * rs6000-tdep.c: Use C++ exception handling.
1731         * rs6000-aix-tdep.c: Use C++ exception handling.
1732         * riscv-tdep.c: Use C++ exception handling.
1733         * remote.c: Use C++ exception handling.
1734         * remote-fileio.c: Use C++ exception handling.
1735         * record-full.c: Use C++ exception handling.
1736         * record-btrace.c: Use C++ exception handling.
1737         * python/python.c: Use C++ exception handling.
1738         * python/py-value.c: Use C++ exception handling.
1739         * python/py-utils.c: Use C++ exception handling.
1740         * python/py-unwind.c: Use C++ exception handling.
1741         * python/py-type.c: Use C++ exception handling.
1742         * python/py-symbol.c: Use C++ exception handling.
1743         * python/py-record.c: Use C++ exception handling.
1744         * python/py-record-btrace.c: Use C++ exception handling.
1745         * python/py-progspace.c: Use C++ exception handling.
1746         * python/py-prettyprint.c: Use C++ exception handling.
1747         * python/py-param.c: Use C++ exception handling.
1748         * python/py-objfile.c: Use C++ exception handling.
1749         * python/py-linetable.c: Use C++ exception handling.
1750         * python/py-lazy-string.c: Use C++ exception handling.
1751         * python/py-infthread.c: Use C++ exception handling.
1752         * python/py-inferior.c: Use C++ exception handling.
1753         * python/py-gdb-readline.c: Use C++ exception handling.
1754         * python/py-framefilter.c: Use C++ exception handling.
1755         * python/py-frame.c: Use C++ exception handling.
1756         * python/py-finishbreakpoint.c: Use C++ exception handling.
1757         * python/py-cmd.c: Use C++ exception handling.
1758         * python/py-breakpoint.c: Use C++ exception handling.
1759         * python/py-arch.c: Use C++ exception handling.
1760         * printcmd.c: Use C++ exception handling.
1761         * ppc-linux-tdep.c: Use C++ exception handling.
1762         * parse.c: Use C++ exception handling.
1763         * p-valprint.c: Use C++ exception handling.
1764         * objc-lang.c: Use C++ exception handling.
1765         * mi/mi-main.c: Use C++ exception handling.
1766         * mi/mi-interp.c: Use C++ exception handling.
1767         * mi/mi-cmd-stack.c: Use C++ exception handling.
1768         * mi/mi-cmd-break.c: Use C++ exception handling.
1769         * main.c: Use C++ exception handling.
1770         * linux-thread-db.c: Use C++ exception handling.
1771         * linux-tdep.c: Use C++ exception handling.
1772         * linux-nat.c: Use C++ exception handling.
1773         * linux-fork.c: Use C++ exception handling.
1774         * linespec.c: Use C++ exception handling.
1775         * language.c: Use C++ exception handling.
1776         * jit.c: Use C++ exception handling.
1777         * infrun.c: Use C++ exception handling.
1778         * infcmd.c: Use C++ exception handling.
1779         * infcall.c: Use C++ exception handling.
1780         * inf-loop.c: Use C++ exception handling.
1781         * i386-tdep.c: Use C++ exception handling.
1782         * i386-linux-tdep.c: Use C++ exception handling.
1783         * guile/scm-value.c: Use C++ exception handling.
1784         * guile/scm-type.c: Use C++ exception handling.
1785         * guile/scm-symtab.c: Use C++ exception handling.
1786         * guile/scm-symbol.c: Use C++ exception handling.
1787         * guile/scm-pretty-print.c: Use C++ exception handling.
1788         * guile/scm-ports.c: Use C++ exception handling.
1789         * guile/scm-param.c: Use C++ exception handling.
1790         * guile/scm-math.c: Use C++ exception handling.
1791         * guile/scm-lazy-string.c: Use C++ exception handling.
1792         * guile/scm-frame.c: Use C++ exception handling.
1793         * guile/scm-disasm.c: Use C++ exception handling.
1794         * guile/scm-cmd.c: Use C++ exception handling.
1795         * guile/scm-breakpoint.c: Use C++ exception handling.
1796         * guile/scm-block.c: Use C++ exception handling.
1797         * guile/guile-internal.h: Use C++ exception handling.
1798         * gnu-v3-abi.c: Use C++ exception handling.
1799         * gdbtypes.c: Use C++ exception handling.
1800         * frame.c: Use C++ exception handling.
1801         * frame-unwind.c: Use C++ exception handling.
1802         * fbsd-tdep.c: Use C++ exception handling.
1803         * f-valprint.c: Use C++ exception handling.
1804         * exec.c: Use C++ exception handling.
1805         * event-top.c: Use C++ exception handling.
1806         * event-loop.c: Use C++ exception handling.
1807         * eval.c: Use C++ exception handling.
1808         * dwarf2read.c: Use C++ exception handling.
1809         * dwarf2loc.c: Use C++ exception handling.
1810         * dwarf2-frame.c: Use C++ exception handling.
1811         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1812         * dwarf-index-write.c: Use C++ exception handling.
1813         * dwarf-index-cache.c: Use C++ exception handling.
1814         * dtrace-probe.c: Use C++ exception handling.
1815         * disasm-selftests.c: Use C++ exception handling.
1816         * darwin-nat.c: Use C++ exception handling.
1817         * cp-valprint.c: Use C++ exception handling.
1818         * cp-support.c: Use C++ exception handling.
1819         * cp-abi.c: Use C++ exception handling.
1820         * corelow.c: Use C++ exception handling.
1821         * completer.c: Use C++ exception handling.
1822         * compile/compile-object-run.c: Use C++ exception handling.
1823         * compile/compile-object-load.c: Use C++ exception handling.
1824         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1825         * compile/compile-c-symbols.c: Use C++ exception handling.
1826         * common/selftest.c: Use C++ exception handling.
1827         * common/new-op.c: Use C++ exception handling.
1828         * cli/cli-script.c: Use C++ exception handling.
1829         * cli/cli-interp.c: Use C++ exception handling.
1830         * cli/cli-cmds.c: Use C++ exception handling.
1831         * c-varobj.c: Use C++ exception handling.
1832         * btrace.c: Use C++ exception handling.
1833         * breakpoint.c: Use C++ exception handling.
1834         * break-catch-throw.c: Use C++ exception handling.
1835         * arch-utils.c: Use C++ exception handling.
1836         * amd64-tdep.c: Use C++ exception handling.
1837         * ada-valprint.c: Use C++ exception handling.
1838         * ada-typeprint.c: Use C++ exception handling.
1839         * ada-lang.c: Use C++ exception handling.
1840         * aarch64-tdep.c: Use C++ exception handling.
1841
1842 2019-04-08  Tom Tromey  <tom@tromey.com>
1843
1844         * xml-support.c (gdb_xml_parser::parse): Update.
1845         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1846         * value.c (show_convenience): Update.
1847         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1848         (test_parse_flags_qcs): Update.
1849         * thread.c (thr_try_catch_cmd): Update.
1850         * target.c (target_translate_tls_address): Update.
1851         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1852         (info_frame_command_core, frame_apply_command_count): Update.
1853         * rust-exp.y (rust_lex_exception_test): Update.
1854         * riscv-tdep.c (riscv_print_one_register_info): Update.
1855         * remote.c (remote_target::enable_btrace): Update.
1856         * record-btrace.c (record_btrace_enable_warn): Update.
1857         * python/py-utils.c (gdbpy_convert_exception): Update.
1858         * printcmd.c (do_one_display, print_variable_and_value): Update.
1859         * mi/mi-main.c (mi_print_exception): Update.
1860         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1861         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1862         * linux-nat.c (linux_nat_target::attach): Update.
1863         * linux-fork.c (class scoped_switch_fork_info): Update.
1864         * infrun.c (displaced_step_prepare): Update.
1865         * infcall.c (call_function_by_hand_dummy): Update.
1866         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1867         * gnu-v3-abi.c (print_one_vtable): Update.
1868         * frame.c (get_prev_frame_always): Update.
1869         * f-valprint.c (info_common_command_for_block): Update.
1870         * exec.c (try_open_exec_file): Update.
1871         * exceptions.c (print_exception, exception_print)
1872         (exception_fprintf, exception_print_same): Update.
1873         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1874         * dwarf-index-cache.c (index_cache::store)
1875         (index_cache::lookup_gdb_index): Update.
1876         * darwin-nat.c (maybe_cache_shell): Update.
1877         * cp-valprint.c (cp_print_value_fields): Update.
1878         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1879         (gcc_cplus_symbol_address): Update.
1880         * compile/compile-c-symbols.c (gcc_convert_symbol)
1881         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1882         * common/selftest.c: Update.
1883         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1884         a std::string.
1885         (exception_try_scope_entry, exception_try_scope_exit): Don't
1886         declare.
1887         (struct exception_try_scope): Remove.
1888         (TRY): Don't use exception_try_scope.
1889         (struct gdb_exception): Add constructor, operator=.
1890         <what>: New method.
1891         (struct gdb_exception_RETURN_MASK_ALL)
1892         (struct gdb_exception_RETURN_MASK_ERROR)
1893         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1894         (struct gdb_quit_bad_alloc): Update.
1895         * common/common-exceptions.c (exception_none): Change
1896         initializer.
1897         (struct catcher) <state, exception>: Initialize inline.
1898         <prev>: Remove member.
1899         (current_catcher): Remove.
1900         (catchers): New global.
1901         (exceptions_state_mc_init): Simplify.
1902         (catcher_pop): Remove.
1903         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1904         (try_scope_depth, exception_try_scope_entry)
1905         (exception_try_scope_exit): Remove.
1906         (throw_exception_sjlj): Update.
1907         (exception_messages, exception_messages_size): Remove.
1908         (throw_it): Simplify.
1909         (gdb_exception_sliced_copy): Remove.
1910         (throw_exception_cxx): Update.
1911         * cli/cli-script.c (script_from_file): Update.
1912         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1913         Update.
1914         * ada-valprint.c (ada_val_print): Update.
1915         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1916         (create_excep_cond_exprs): Update.
1917
1918 2019-04-08  Tom Tromey  <tom@tromey.com>
1919
1920         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1921         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1922         (TRY, CATCH, END_CATCH): Remove some definitions.
1923         * common/common-exceptions.c: Don't use GDB_XCPT.
1924         (catcher_list_size): Remove.
1925         (throw_exception, throw_it): Simplify.
1926
1927 2019-04-05  Tom Tromey  <tom@tromey.com>
1928
1929         Revert the header-sorting patch.
1930         * ft32-tdep.c: Revert.
1931         * frv-tdep.c: Revert.
1932         * frv-linux-tdep.c: Revert.
1933         * frame.c: Revert.
1934         * frame-unwind.c: Revert.
1935         * frame-base.c: Revert.
1936         * fork-child.c: Revert.
1937         * findvar.c: Revert.
1938         * findcmd.c: Revert.
1939         * filesystem.c: Revert.
1940         * filename-seen-cache.h: Revert.
1941         * filename-seen-cache.c: Revert.
1942         * fbsd-tdep.c: Revert.
1943         * fbsd-nat.h: Revert.
1944         * fbsd-nat.c: Revert.
1945         * f-valprint.c: Revert.
1946         * f-typeprint.c: Revert.
1947         * f-lang.c: Revert.
1948         * extension.h: Revert.
1949         * extension.c: Revert.
1950         * extension-priv.h: Revert.
1951         * expprint.c: Revert.
1952         * exec.h: Revert.
1953         * exec.c: Revert.
1954         * exceptions.c: Revert.
1955         * event-top.c: Revert.
1956         * event-loop.c: Revert.
1957         * eval.c: Revert.
1958         * elfread.c: Revert.
1959         * dwarf2read.h: Revert.
1960         * dwarf2read.c: Revert.
1961         * dwarf2loc.c: Revert.
1962         * dwarf2expr.h: Revert.
1963         * dwarf2expr.c: Revert.
1964         * dwarf2-frame.c: Revert.
1965         * dwarf2-frame-tailcall.c: Revert.
1966         * dwarf-index-write.h: Revert.
1967         * dwarf-index-write.c: Revert.
1968         * dwarf-index-common.c: Revert.
1969         * dwarf-index-cache.h: Revert.
1970         * dwarf-index-cache.c: Revert.
1971         * dummy-frame.c: Revert.
1972         * dtrace-probe.c: Revert.
1973         * disasm.h: Revert.
1974         * disasm.c: Revert.
1975         * disasm-selftests.c: Revert.
1976         * dictionary.c: Revert.
1977         * dicos-tdep.c: Revert.
1978         * demangle.c: Revert.
1979         * dcache.h: Revert.
1980         * dcache.c: Revert.
1981         * darwin-nat.h: Revert.
1982         * darwin-nat.c: Revert.
1983         * darwin-nat-info.c: Revert.
1984         * d-valprint.c: Revert.
1985         * d-namespace.c: Revert.
1986         * d-lang.c: Revert.
1987         * ctf.c: Revert.
1988         * csky-tdep.c: Revert.
1989         * csky-linux-tdep.c: Revert.
1990         * cris-tdep.c: Revert.
1991         * cris-linux-tdep.c: Revert.
1992         * cp-valprint.c: Revert.
1993         * cp-support.c: Revert.
1994         * cp-namespace.c: Revert.
1995         * cp-abi.c: Revert.
1996         * corelow.c: Revert.
1997         * corefile.c: Revert.
1998         * continuations.c: Revert.
1999         * completer.h: Revert.
2000         * completer.c: Revert.
2001         * complaints.c: Revert.
2002         * coffread.c: Revert.
2003         * coff-pe-read.c: Revert.
2004         * cli-out.h: Revert.
2005         * cli-out.c: Revert.
2006         * charset.c: Revert.
2007         * c-varobj.c: Revert.
2008         * c-valprint.c: Revert.
2009         * c-typeprint.c: Revert.
2010         * c-lang.c: Revert.
2011         * buildsym.c: Revert.
2012         * buildsym-legacy.c: Revert.
2013         * build-id.h: Revert.
2014         * build-id.c: Revert.
2015         * btrace.c: Revert.
2016         * bsd-uthread.c: Revert.
2017         * breakpoint.h: Revert.
2018         * breakpoint.c: Revert.
2019         * break-catch-throw.c: Revert.
2020         * break-catch-syscall.c: Revert.
2021         * break-catch-sig.c: Revert.
2022         * blockframe.c: Revert.
2023         * block.c: Revert.
2024         * bfin-tdep.c: Revert.
2025         * bfin-linux-tdep.c: Revert.
2026         * bfd-target.c: Revert.
2027         * bcache.c: Revert.
2028         * ax-general.c: Revert.
2029         * ax-gdb.h: Revert.
2030         * ax-gdb.c: Revert.
2031         * avr-tdep.c: Revert.
2032         * auxv.c: Revert.
2033         * auto-load.c: Revert.
2034         * arm-wince-tdep.c: Revert.
2035         * arm-tdep.c: Revert.
2036         * arm-symbian-tdep.c: Revert.
2037         * arm-pikeos-tdep.c: Revert.
2038         * arm-obsd-tdep.c: Revert.
2039         * arm-nbsd-tdep.c: Revert.
2040         * arm-nbsd-nat.c: Revert.
2041         * arm-linux-tdep.c: Revert.
2042         * arm-linux-nat.c: Revert.
2043         * arm-fbsd-tdep.c: Revert.
2044         * arm-fbsd-nat.c: Revert.
2045         * arm-bsd-tdep.c: Revert.
2046         * arch-utils.c: Revert.
2047         * arc-tdep.c: Revert.
2048         * arc-newlib-tdep.c: Revert.
2049         * annotate.h: Revert.
2050         * annotate.c: Revert.
2051         * amd64-windows-tdep.c: Revert.
2052         * amd64-windows-nat.c: Revert.
2053         * amd64-tdep.c: Revert.
2054         * amd64-sol2-tdep.c: Revert.
2055         * amd64-obsd-tdep.c: Revert.
2056         * amd64-obsd-nat.c: Revert.
2057         * amd64-nbsd-tdep.c: Revert.
2058         * amd64-nbsd-nat.c: Revert.
2059         * amd64-nat.c: Revert.
2060         * amd64-linux-tdep.c: Revert.
2061         * amd64-linux-nat.c: Revert.
2062         * amd64-fbsd-tdep.c: Revert.
2063         * amd64-fbsd-nat.c: Revert.
2064         * amd64-dicos-tdep.c: Revert.
2065         * amd64-darwin-tdep.c: Revert.
2066         * amd64-bsd-nat.c: Revert.
2067         * alpha-tdep.c: Revert.
2068         * alpha-obsd-tdep.c: Revert.
2069         * alpha-nbsd-tdep.c: Revert.
2070         * alpha-mdebug-tdep.c: Revert.
2071         * alpha-linux-tdep.c: Revert.
2072         * alpha-linux-nat.c: Revert.
2073         * alpha-bsd-tdep.c: Revert.
2074         * alpha-bsd-nat.c: Revert.
2075         * aix-thread.c: Revert.
2076         * agent.c: Revert.
2077         * addrmap.c: Revert.
2078         * ada-varobj.c: Revert.
2079         * ada-valprint.c: Revert.
2080         * ada-typeprint.c: Revert.
2081         * ada-tasks.c: Revert.
2082         * ada-lang.c: Revert.
2083         * aarch64-tdep.c: Revert.
2084         * aarch64-ravenscar-thread.c: Revert.
2085         * aarch64-newlib-tdep.c: Revert.
2086         * aarch64-linux-tdep.c: Revert.
2087         * aarch64-linux-nat.c: Revert.
2088         * aarch64-fbsd-tdep.c: Revert.
2089         * aarch64-fbsd-nat.c: Revert.
2090         * aarch32-linux-nat.c: Revert.
2091
2092 2019-04-05  Tom Tromey  <tom@tromey.com>
2093
2094         * ft32-tdep.c: Sort headers.
2095         * frv-tdep.c: Sort headers.
2096         * frv-linux-tdep.c: Sort headers.
2097         * frame.c: Sort headers.
2098         * frame-unwind.c: Sort headers.
2099         * frame-base.c: Sort headers.
2100         * fork-child.c: Sort headers.
2101         * findvar.c: Sort headers.
2102         * findcmd.c: Sort headers.
2103         * filesystem.c: Sort headers.
2104         * filename-seen-cache.h: Sort headers.
2105         * filename-seen-cache.c: Sort headers.
2106         * fbsd-tdep.c: Sort headers.
2107         * fbsd-nat.h: Sort headers.
2108         * fbsd-nat.c: Sort headers.
2109         * f-valprint.c: Sort headers.
2110         * f-typeprint.c: Sort headers.
2111         * f-lang.c: Sort headers.
2112         * extension.h: Sort headers.
2113         * extension.c: Sort headers.
2114         * extension-priv.h: Sort headers.
2115         * expprint.c: Sort headers.
2116         * exec.h: Sort headers.
2117         * exec.c: Sort headers.
2118         * exceptions.c: Sort headers.
2119         * event-top.c: Sort headers.
2120         * event-loop.c: Sort headers.
2121         * eval.c: Sort headers.
2122         * elfread.c: Sort headers.
2123         * dwarf2read.h: Sort headers.
2124         * dwarf2read.c: Sort headers.
2125         * dwarf2loc.c: Sort headers.
2126         * dwarf2expr.h: Sort headers.
2127         * dwarf2expr.c: Sort headers.
2128         * dwarf2-frame.c: Sort headers.
2129         * dwarf2-frame-tailcall.c: Sort headers.
2130         * dwarf-index-write.h: Sort headers.
2131         * dwarf-index-write.c: Sort headers.
2132         * dwarf-index-common.c: Sort headers.
2133         * dwarf-index-cache.h: Sort headers.
2134         * dwarf-index-cache.c: Sort headers.
2135         * dummy-frame.c: Sort headers.
2136         * dtrace-probe.c: Sort headers.
2137         * disasm.h: Sort headers.
2138         * disasm.c: Sort headers.
2139         * disasm-selftests.c: Sort headers.
2140         * dictionary.c: Sort headers.
2141         * dicos-tdep.c: Sort headers.
2142         * demangle.c: Sort headers.
2143         * dcache.h: Sort headers.
2144         * dcache.c: Sort headers.
2145         * darwin-nat.h: Sort headers.
2146         * darwin-nat.c: Sort headers.
2147         * darwin-nat-info.c: Sort headers.
2148         * d-valprint.c: Sort headers.
2149         * d-namespace.c: Sort headers.
2150         * d-lang.c: Sort headers.
2151         * ctf.c: Sort headers.
2152         * csky-tdep.c: Sort headers.
2153         * csky-linux-tdep.c: Sort headers.
2154         * cris-tdep.c: Sort headers.
2155         * cris-linux-tdep.c: Sort headers.
2156         * cp-valprint.c: Sort headers.
2157         * cp-support.c: Sort headers.
2158         * cp-namespace.c: Sort headers.
2159         * cp-abi.c: Sort headers.
2160         * corelow.c: Sort headers.
2161         * corefile.c: Sort headers.
2162         * continuations.c: Sort headers.
2163         * completer.h: Sort headers.
2164         * completer.c: Sort headers.
2165         * complaints.c: Sort headers.
2166         * coffread.c: Sort headers.
2167         * coff-pe-read.c: Sort headers.
2168         * cli-out.h: Sort headers.
2169         * cli-out.c: Sort headers.
2170         * charset.c: Sort headers.
2171         * c-varobj.c: Sort headers.
2172         * c-valprint.c: Sort headers.
2173         * c-typeprint.c: Sort headers.
2174         * c-lang.c: Sort headers.
2175         * buildsym.c: Sort headers.
2176         * buildsym-legacy.c: Sort headers.
2177         * build-id.h: Sort headers.
2178         * build-id.c: Sort headers.
2179         * btrace.c: Sort headers.
2180         * bsd-uthread.c: Sort headers.
2181         * breakpoint.h: Sort headers.
2182         * breakpoint.c: Sort headers.
2183         * break-catch-throw.c: Sort headers.
2184         * break-catch-syscall.c: Sort headers.
2185         * break-catch-sig.c: Sort headers.
2186         * blockframe.c: Sort headers.
2187         * block.c: Sort headers.
2188         * bfin-tdep.c: Sort headers.
2189         * bfin-linux-tdep.c: Sort headers.
2190         * bfd-target.c: Sort headers.
2191         * bcache.c: Sort headers.
2192         * ax-general.c: Sort headers.
2193         * ax-gdb.h: Sort headers.
2194         * ax-gdb.c: Sort headers.
2195         * avr-tdep.c: Sort headers.
2196         * auxv.c: Sort headers.
2197         * auto-load.c: Sort headers.
2198         * arm-wince-tdep.c: Sort headers.
2199         * arm-tdep.c: Sort headers.
2200         * arm-symbian-tdep.c: Sort headers.
2201         * arm-pikeos-tdep.c: Sort headers.
2202         * arm-obsd-tdep.c: Sort headers.
2203         * arm-nbsd-tdep.c: Sort headers.
2204         * arm-nbsd-nat.c: Sort headers.
2205         * arm-linux-tdep.c: Sort headers.
2206         * arm-linux-nat.c: Sort headers.
2207         * arm-fbsd-tdep.c: Sort headers.
2208         * arm-fbsd-nat.c: Sort headers.
2209         * arm-bsd-tdep.c: Sort headers.
2210         * arch-utils.c: Sort headers.
2211         * arc-tdep.c: Sort headers.
2212         * arc-newlib-tdep.c: Sort headers.
2213         * annotate.h: Sort headers.
2214         * annotate.c: Sort headers.
2215         * amd64-windows-tdep.c: Sort headers.
2216         * amd64-windows-nat.c: Sort headers.
2217         * amd64-tdep.c: Sort headers.
2218         * amd64-sol2-tdep.c: Sort headers.
2219         * amd64-obsd-tdep.c: Sort headers.
2220         * amd64-obsd-nat.c: Sort headers.
2221         * amd64-nbsd-tdep.c: Sort headers.
2222         * amd64-nbsd-nat.c: Sort headers.
2223         * amd64-nat.c: Sort headers.
2224         * amd64-linux-tdep.c: Sort headers.
2225         * amd64-linux-nat.c: Sort headers.
2226         * amd64-fbsd-tdep.c: Sort headers.
2227         * amd64-fbsd-nat.c: Sort headers.
2228         * amd64-dicos-tdep.c: Sort headers.
2229         * amd64-darwin-tdep.c: Sort headers.
2230         * amd64-bsd-nat.c: Sort headers.
2231         * alpha-tdep.c: Sort headers.
2232         * alpha-obsd-tdep.c: Sort headers.
2233         * alpha-nbsd-tdep.c: Sort headers.
2234         * alpha-mdebug-tdep.c: Sort headers.
2235         * alpha-linux-tdep.c: Sort headers.
2236         * alpha-linux-nat.c: Sort headers.
2237         * alpha-bsd-tdep.c: Sort headers.
2238         * alpha-bsd-nat.c: Sort headers.
2239         * aix-thread.c: Sort headers.
2240         * agent.c: Sort headers.
2241         * addrmap.c: Sort headers.
2242         * ada-varobj.c: Sort headers.
2243         * ada-valprint.c: Sort headers.
2244         * ada-typeprint.c: Sort headers.
2245         * ada-tasks.c: Sort headers.
2246         * ada-lang.c: Sort headers.
2247         * aarch64-tdep.c: Sort headers.
2248         * aarch64-ravenscar-thread.c: Sort headers.
2249         * aarch64-newlib-tdep.c: Sort headers.
2250         * aarch64-linux-tdep.c: Sort headers.
2251         * aarch64-linux-nat.c: Sort headers.
2252         * aarch64-fbsd-tdep.c: Sort headers.
2253         * aarch64-fbsd-nat.c: Sort headers.
2254         * aarch32-linux-nat.c: Sort headers.
2255
2256 2019-04-04  Tom Tromey  <tom@tromey.com>
2257
2258         * varobj.c (varobj_create): Update.
2259         * rust-exp.y (struct rust_parser) <update_innermost_block,
2260         lookup_symbol>: New methods.
2261         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2262         Rename.
2263         (rust_parser::rust_lookup_type)
2264         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2265         * printcmd.c (display_command, do_one_display): Update.
2266         * parser-defs.h (struct parser_state) <parser_state>: Add
2267         "tracker" parameter.
2268         (block_tracker): New member.
2269         (class innermost_block_tracker) <innermost_block_tracker>: Add
2270         "types" parameter.
2271         <reset>: Remove method.
2272         (innermost_block): Don't declare.
2273         (null_post_parser): Update.
2274         * parse.c (innermost_block): Remove global.
2275         (write_dollar_variable): Update.
2276         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2277         Remove "tracker_types" parameter.
2278         (parse_expression): Add "tracker" parameter.
2279         (parse_expression_for_completion): Update.
2280         (null_post_parser): Add "tracker" parameter.
2281         * p-exp.y: Update rules.
2282         * m2-exp.y: Update rules.
2283         * language.h (struct language_defn) <la_post_parser>: Add
2284         "tracker" parameter.
2285         * go-exp.y: Update rules.
2286         * f-exp.y: Update rules.
2287         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2288         parameter.
2289         * d-exp.y: Update rules.
2290         * c-exp.y: Update rules.
2291         * breakpoint.c (set_breakpoint_condition): Create an
2292         innermost_block_tracker.
2293         (watch_command_1): Likewise.
2294         * ada-lang.c (resolve): Add "tracker" parameter.
2295         (resolve_subexp): Likewise.
2296         * ada-exp.y (write_var_from_sym): Update.
2297
2298 2019-04-04  Tom Tromey  <tom@tromey.com>
2299
2300         * type-stack.h: New file.
2301         * type-stack.c: New file.
2302         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2303         type-stack.h.
2304         (insert_into_type_stack, insert_type, push_type, push_type_int)
2305         (insert_type_address_space, pop_type, pop_type_int)
2306         (pop_typelist, pop_type_stack, append_type_stack)
2307         (push_type_stack, get_type_stack, push_typelist)
2308         (follow_type_instance_flags, follow_types): Don't declare.
2309         * parse.c (type_stack): Remove global.
2310         (parse_exp_in_context): Update.
2311         (insert_into_type_stack, insert_type, push_type, push_type_int)
2312         (insert_type_address_space, pop_type, pop_type_int)
2313         (pop_typelist, pop_type_stack, append_type_stack)
2314         (push_type_stack, get_type_stack, push_typelist)
2315         (follow_type_instance_flags, follow_types): Remove (moved to
2316         type-stack.c).
2317         * f-exp.y (type_stack): New global.
2318         Update rules.
2319         (push_kind_type, f_parse): Update.
2320         * d-exp.y (type_stack): New global.
2321         Update rules.
2322         (d_parse): Update.
2323         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2324         Update rules.
2325         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2326         (HFILES_NO_SRCDIR): Add type-stack.h.
2327
2328 2019-04-04  Tom Tromey  <tom@tromey.com>
2329
2330         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2331         (rust_parser::convert_ast_to_expression, rust_parse)
2332         (rust_lex_test_completion, rust_lex_tests): Update.
2333         * parser-defs.h (struct expr_completion_state): New.
2334         (struct parser_state) <parser_state>: Add completion parameter.
2335         <mark_struct_expression, mark_completion_tag>: New methods.
2336         <parse_completion, m_completion_state>: New members.
2337         (prefixify_expression, null_post_parser): Update.
2338         (mark_struct_expression, mark_completion_tag): Don't declare.
2339         * parse.c (parse_completion, expout_last_struct)
2340         (expout_tag_completion_type, expout_completion_name): Remove
2341         globals.
2342         (parser_state::mark_struct_expression)
2343         (parser_state::mark_completion_tag): Now methods.
2344         (prefixify_expression): Add last_struct parameter.
2345         (prefixify_subexp): Likewise.
2346         (parse_exp_1): Update.
2347         (parse_exp_in_context): Add cstate parameter.  Update.
2348         (parse_expression_for_completion): Create an
2349         expr_completion_state.
2350         (null_post_parser): Add "completion" parameter.
2351         * p-exp.y: Update rules.
2352         (yylex): Update.
2353         * language.h (struct language_defn) <la_post_parser>: Add
2354         "completing" parameter.
2355         * go-exp.y: Update rules.
2356         (lex_one_token): Update.
2357         * expression.h (parse_completion): Don't declare.
2358         * d-exp.y: Update rules.
2359         (lex_one_token): Update rules.
2360         * c-exp.y: Update rules.
2361         (lex_one_token): Update.
2362         * ada-lang.c (resolve): Add "parse_completion" parameter.
2363         (resolve_subexp): Likewise.
2364         (ada_resolve_function): Likewise.
2365
2366 2019-04-04  Tom Tromey  <tom@tromey.com>
2367
2368         * parser-defs.h (struct parser_state) <start_arglist,
2369         end_arglist>: New methods.
2370         <arglist_len, m_funcall_chain>: New members.
2371         (arglist_len, start_arglist, end_arglist): Don't declare.
2372         * parse.c (arglist_len, funcall_chain): Remove global.
2373         (start_arglist, end_arglist): Remove functions.
2374         (parse_exp_in_context): Update.
2375         * p-exp.y: Update rules.
2376         * m2-exp.y: Update rules.
2377         * go-exp.y: Update rules.
2378         * f-exp.y: Update rules.
2379         * d-exp.y: Update rules.
2380         * c-exp.y: Update rules.
2381
2382 2019-04-04  Tom Tromey  <tom@tromey.com>
2383
2384         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2385         lex_operator, push_back>: New methods.
2386         Update all rules.
2387         (rust_parser::lex_hex, lex_escape): Rename and update.
2388         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2389         (rust_parser::lex_operator): Rename and update.
2390         (rust_parser::lex_number, rustyylex, rustyyerror)
2391         (rust_lex_test_init, rust_lex_test_sequence)
2392         (rust_lex_test_push_back, rust_lex_tests): Update.
2393         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2394         parameter.
2395         <lexptr, prev_lexptr>: New members.
2396         (lexptr, prev_lexptr): Don't declare.
2397         * parse.c (lexptr, prev_lexptr): Remove globals.
2398         (parse_exp_in_context): Update.
2399         * p-exp.y (yylex, yyerror): Update.
2400         * m2-exp.y (parse_number, yylex, yyerror): Update.
2401         * go-exp.y (lex_one_token, yyerror): Update.
2402         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2403         * d-exp.y (lex_one_token, yyerror): Update.
2404         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2405         (lex_one_token, yyerror): Update.
2406         * ada-lex.l (YY_INPUT): Update.
2407         (rewind_to_char): Update.
2408         * ada-exp.y (yyerror): Update.
2409
2410 2019-04-04  Tom Tromey  <tom@tromey.com>
2411
2412         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2413         * parser-defs.h (struct parser_state) <parser_state>: Add new
2414         parameter.
2415         <comma_terminates>: New member.
2416         (comma_terminates): Don't declare global.
2417         * parse.c (comma_terminates): Remove global.
2418         (parse_exp_in_context): Update.
2419         * p-exp.y (yylex): Update.
2420         * m2-exp.y (yylex): Update.
2421         * go-exp.y (lex_one_token): Update.
2422         * f-exp.y (yylex): Update.
2423         * d-exp.y (lex_one_token): Update.
2424         * c-exp.y (lex_one_token): Update.
2425         * ada-lex.l: Update.
2426
2427 2019-04-04  Tom Tromey  <tom@tromey.com>
2428
2429         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2430         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2431         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2432         * parser-defs.h (paren_depth): Don't declare.
2433         * parse.c (paren_depth): Remove global.
2434         (parse_exp_in_context): Update.
2435         * p-exp.y (paren_depth): New global.
2436         (pascal_parse): Initialize it.
2437         * m2-exp.y (paren_depth): New global.
2438         (m2_parse): Initialize it.
2439         * go-exp.y (paren_depth): New global.
2440         (go_parse): Initialize it.
2441         * f-exp.y (paren_depth): New global.
2442         (f_parse): Initialize it.
2443         * d-exp.y (paren_depth): New global.
2444         (d_parse): Initialize it.
2445         * c-exp.y (paren_depth): New global.
2446         (c_parse): Initialize it.
2447         * ada-lex.l (paren_depth): New global.
2448         (lexer_init): Initialize it.
2449
2450 2019-04-04  Tom Tromey  <tom@tromey.com>
2451
2452         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2453         (rust_parser::convert_ast_to_type)
2454         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2455         * parser-defs.h (struct parser_state) <parser_state>: Add
2456         parameters.  Initialize new members.
2457         <expression_context_block, expression_context_pc>: New members.
2458         * parse.c (expression_context_block, expression_context_pc):
2459         Remove globals.
2460         (parse_exp_in_context): Update.
2461         * p-exp.y: Update all rules.
2462         (yylex): Update.
2463         * m2-exp.y: Update all rules.
2464         (yylex): Update.
2465         * go-exp.y (yylex): Update.
2466         * f-exp.y (yylex): Update.
2467         * d-exp.y: Update all rules.
2468         (yylex): Update.
2469         * c-exp.y: Update all rules.
2470         (lex_one_token, classify_name, yylex, c_parse): Update.
2471         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2472
2473 2019-04-04  Tom Tromey  <tom@tromey.com>
2474
2475         * gdbarch.h, gdbarch.c: Rebuild.
2476         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2477         * stap-probe.h:
2478         (struct stap_parse_info): Replace "parser_state" with
2479         "expr_builder".
2480         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2481         (parser_state): New class.
2482         * parse.c (expr_builder): Rename.
2483         (expr_builder::release): Rename.
2484         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2485         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2486         (write_exp_elt_longcst, write_exp_elt_floatcst)
2487         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2488         (write_exp_string_vector, write_exp_bitstring)
2489         (write_exp_msymbol, mark_struct_expression)
2490         (write_dollar_variable)
2491         (insert_type_address_space, increase_expout_size): Replace
2492         "parser_state" with "expr_builder".
2493         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2494         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2495         "parser_state" with "expr_builder".
2496
2497 2019-04-04  Tom Tromey  <tom@tromey.com>
2498
2499         * rust-exp.y: Replace "parse_language" with method call.
2500         * p-exp.y:
2501         (yylex): Replace "parse_language" with method call.
2502         * m2-exp.y:
2503         (yylex): Replace "parse_language" with method call.
2504         * go-exp.y (classify_name): Replace "parse_language" with method
2505         call.
2506         * f-exp.y (yylex): Replace "parse_language" with method call.
2507         * d-exp.y (lex_one_token): Replace "parse_language" with method
2508         call.
2509         * c-exp.y:
2510         (lex_one_token, classify_name, yylex): Replace "parse_language"
2511         with method call.
2512         * ada-exp.y (find_primitive_type, type_char)
2513         (type_system_address): Replace "parse_language" with method call.
2514
2515 2019-04-04  Tom Tromey  <tom@tromey.com>
2516
2517         * rust-exp.y: Replace "parse_gdbarch" with method call.
2518         * parse.c (write_dollar_variable, insert_type_address_space):
2519         Replace "parse_gdbarch" with method call.
2520         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2521         call.
2522         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2523         call.
2524         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2525         "parse_gdbarch" with method call.
2526         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2527         with method call.
2528         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2529         "parse_gdbarch" with method call.
2530         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2531         "parse_gdbarch" with method call.
2532         * c-exp.y (parse_type, parse_number, classify_name): Replace
2533         "parse_gdbarch" with method call.
2534         * ada-lex.l: Replace "parse_gdbarch" with method call.
2535         * ada-exp.y (parse_type, find_primitive_type, type_char)
2536         (type_system_address): Replace "parse_gdbarch" with method call.
2537
2538 2019-04-04  Tom Tromey  <tom@tromey.com>
2539
2540         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2541         * stap-probe.c (stap_parse_argument): Update.
2542         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2543         initial_size parameter.
2544         * rust-exp.y (rust_lex_tests): Update.
2545         * parse.c (parser_state): Update.
2546         (parse_exp_in_context): Update.
2547         * parser-defs.h (struct parser_state) <parser_state>: Remove
2548         "initial_size" parameter.
2549
2550 2019-04-04  Tom Tromey  <tom@tromey.com>
2551
2552         * parser-defs.h (increase_expout_size): Don't declare.
2553         * parse.c (increase_expout_size): Now static.
2554
2555 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2556
2557         * gnu-nat.c (gnu_nat_target::wait): Fix
2558         target_waitstatus_to_string call.
2559
2560 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * eval.c (evaluate_subexp_standard): Handle internal functions
2563         during Fortran function call handling.
2564
2565 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * NEWS: Mention new internal functions.
2568         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2569         (read_base_type): Use dwarf2_init_complex_target_type.
2570         * value.c (creal_internal_fn): New function.
2571         (cimag_internal_fn): New function.
2572         (_initialize_values): Register new internal functions.
2573
2574 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2575
2576         * infrun.c (stop_all_threads): If debug_infrun, always
2577         trace the wait status after wait_one, using
2578         target_waitstatus_to_string and target_pid_to_str.
2579         (handle_inferior_event): Replace various trace of
2580         wait status kind by a single trace.
2581         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2582         wait status kind image by target_waitstatus_to_string.
2583         * target/waitstatus.c (target_waitstatus_to_string): Fix
2584         obsolete comment.
2585
2586 2019-04-01  Tom Tromey  <tromey@adacore.com>
2587
2588         PR symtab/23331:
2589         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2590
2591 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2592             Pedro Alves  <palves@redhat.com>
2593
2594         * top.c (quit_force): Call 'finalize_values'.
2595         * value.c (finalize_values): New function.
2596         * value.h (finalize_values): Declare.
2597
2598 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2599
2600         * NEWS: Announce $_gdb_major and $_gdb_minor.
2601
2602         * top.c (init_gdb_version_vars): New function.
2603         (gdb_init): Call init_gdb_version_vars.
2604
2605 2019-03-29  Tom Tromey  <tromey@adacore.com>
2606
2607         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2608         help text.  Remove dead code.
2609
2610 2019-03-29  Keith Seitz  <keiths@redhat.com>
2611
2612         From Siddhesh Poyarekar:
2613         * f-lang.h (f77_get_upperbound): Return LONGEST.
2614         (f77_get_lowerbound): Likewise.
2615         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2616         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2617         print them.
2618         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2619         plongest to format print it.
2620         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2621         (f77_get_upperbound): Likewise.
2622         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2623         LOWER_BOUND to LONGEST.
2624         (f77_create_arrayprint_offset_tbl): Likewise.
2625
2626 2019-03-29  Keith Seitz  <keiths@redhat.com>
2627
2628         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2629         %s/pulongest for TYPE_LENGTH instead of %d in format
2630         strings.
2631         * ada-typerint.c (ada_print_type): Likewise.
2632         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2633         * compile/compile-c-support.c (generate_register_struct): Likewise.
2634         * gdbtypes.c (recursive_dump_type): Likewise.
2635         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2636         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2637         instead of %d in format strings.
2638         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2639         to std::min to ULONGEST.
2640         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2641         instead of %d in format strings.
2642         * tracepoint.c (info_scope_command): Likewise.
2643         * typeprint.c (print_offset_data::update)
2644         (print_offset_data::finish): Likewise.
2645         * xtensa-tdep.c (xtensa_store_return_value)
2646         (xtensa_push_dummy_call): Likewise.
2647
2648 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2649
2650         * windows-nat.c (display_selector): Fixed format specifications
2651         for 64-bit Cygwin.
2652
2653 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2654
2655         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2656
2657 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2658
2659         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2660         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2661         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2662         (nios2_linux_init_abi): Install it.
2663
2664 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2665
2666         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2667
2668 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2669
2670         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2671
2672 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2673             Tom Tromey  <tromey@adacore.com>
2674
2675         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2676
2677 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2678
2679         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2680         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2681         method to compute the bounds of range types. Also print "[evaluated]"
2682         if the bounds' values come from a dynamic evaluation.
2683
2684 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2687         whitespace when pretty printing is on.
2688
2689 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2690
2691         * ppc-linux-nat.c: Add include.
2692
2693 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2694
2695         * NEWS: Mention AArch64 Pointer Authentication.
2696
2697 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2698
2699         * arm-linux-nat.c: Add include.
2700
2701 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2702
2703         * source-cache.c (source_cache::get_source_lines): Re-read
2704         fullname after calling open_source_file.
2705
2706 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2707
2708         * NEWS: Mention TLS support for FreeBSD.
2709
2710 2019-03-25  Tom Tromey  <tromey@adacore.com>
2711
2712         * minsyms.c (BUNCH_SIZE): Update comment.
2713         (~minimal_symbol_reader): Remove old comment.
2714         (compact_minimal_symbols): Update comment.
2715         (minimal_symbol_reader::install): Remove old comment.  Update
2716         other comments.
2717
2718 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2719
2720         * s390-linux-nat.c: Add include.
2721
2722 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2723
2724         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2725         Call linux_get_hwcap.
2726         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2727         Likewise.
2728         (aarch64_linux_get_hwcap): Remove function.
2729         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2730         declaration.
2731         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2732         linux_get_hwcap.
2733         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2734         * linux-tdep.c (linux_get_hwcap): Add function.
2735         (linux_get_hwcap2): Likewise.
2736         * linux-tdep.h (linux_get_hwcap): Add declaration.
2737         (linux_get_hwcap2): Likewise.
2738         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2739         (ppc_linux_get_hwcap2): Likewise.
2740         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2741         linux_get_hwcap.
2742         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2743         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2744         (ppc_linux_nat_target::read_description): Likewise.
2745         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2746         * s390-linux-nat.c: Likewise.
2747         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2748
2749 2019-03-24  Tom Tromey  <tom@tromey.com>
2750
2751         * ada-lang.c (standard_lookup): Simplify initialization.
2752         (ada_lookup_symbol_nonlocal): Simplify return.
2753         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2754         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2755         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2756         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2757         initialization.
2758         * solib.c (solib_global_lookup): Simplify.
2759         * symtab.c (null_block_symbol): Remove.
2760         (symbol_cache_lookup): Simplify returns.
2761         (lookup_language_this): Simplify returns.
2762         (lookup_symbol_aux): Simplify return.
2763         (lookup_local_symbol): Simplify returns.
2764         (lookup_global_symbol_from_objfile): Simplify return.
2765         (lookup_symbol_in_objfile_symtabs)
2766         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2767         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2768         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2769         * cp-namespace.c (cp_lookup_bare_symbol)
2770         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2771         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2772         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2773         (cp_lookup_symbol_via_imports): Simplify initialization.
2774         (find_symbol_in_baseclass): Likewise.
2775         * symtab.h (null_block_symbol): Remove.
2776         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2777         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2778         (d_lookup_symbol_module): Likewise.
2779         (find_symbol_in_baseclass): Simplify initialization.
2780
2781 2019-03-24  Tom Tromey  <tom@tromey.com>
2782
2783         * expression.h: Don't include symtab.h.
2784         (struct block): Forward declare.
2785
2786 2019-03-24  Tom Tromey  <tom@tromey.com>
2787
2788         * c-exp.y (typebase): Remove casts.
2789         * gdbtypes.c (lookup_unsigned_typename, )
2790         (lookup_signed_typename): Remove cast.
2791         * eval.c (parse_to_comma_and_eval): Remove cast.
2792         * parse.c (write_dollar_variable): Remove cast.
2793         * block.h (struct block) <superblock>: Now const.
2794         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2795         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2796         (map_block): Make "block" const.
2797         * symfile.h (struct quick_symbol_functions)
2798         <map_matching_symbols>: Constify block argument to "callback".
2799         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2800         const.
2801         (find_pc_sect_compunit_symtab): Make "b" const.
2802         (find_symbol_at_address): Likewise.
2803         (search_symbols): Likewise.
2804         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2805         (dw2_debug_names_lookup_symbol): Likewise.
2806         (dw2_map_matching_symbols): Update.
2807         * p-valprint.c (pascal_val_print): Remove "block".
2808         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2809         (aux_add_nonlocal_symbols): Make "block" const.
2810         (resolve_subexp): Remove cast.
2811         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2812         const.
2813         (iterate_over_file_blocks): Likewise.
2814         * f-exp.y (%union) <bval>: Remove.
2815         * coffread.c (patch_opaque_types): Make "b" const.
2816         * spu-tdep.c (spu_catch_start): Make "block" const.
2817         * c-valprint.c (print_unpacked_pointer): Remove "block".
2818         * symmisc.c (dump_symtab_1): Make "b" const.
2819         (block_depth): Make "block" const.
2820         * d-exp.y (%union) <bval>: Remove.
2821         * cp-support.h (cp_lookup_rtti_type): Update.
2822         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2823         * psymtab.c (psym_lookup_symbol): Make "block" const.
2824         (maintenance_check_psymtabs): Make "b" const.
2825         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2826         (enumerate_locals, enumerate_args): Update.
2827         * python/py-symtab.c (stpy_global_block): Make "block" const.
2828         (stpy_static_block): Likewise.
2829         * inline-frame.c (block_starting_point_at): Make "new_block"
2830         const.
2831         * block.c (find_block_in_blockvector): Make return type const.
2832         (blockvector_for_pc_sect): Make "b" const.
2833         (find_block_in_blockvector): Make "b" const.
2834
2835 2019-03-23  Tom Tromey  <tom@tromey.com>
2836
2837         * varobj.c (varobj_create): Update.
2838         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2839         * printcmd.c (display_command, do_one_display): Don't reset
2840         innermost_block.
2841         * parser-defs.h (enum innermost_block_tracker_type): Move to
2842         expression.h.
2843         (innermost_block): Update comment.
2844         * parse.c (parse_exp_1): Add tracker_types parameter.
2845         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2846         tracker_types parameter.  Reset innermost_block.
2847         (parse_exp_in_context): Remove.
2848         (parse_expression_for_completion): Update.
2849         * objfiles.c (~objfile): Don't reset expression_context_block or
2850         innermost_block.
2851         * expression.h (enum innermost_block_tracker_type): Move from
2852         parser-defs.h.
2853         (parse_exp_1): Add tracker_types parameter.
2854         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2855         reset innermost_block.
2856
2857 2019-03-23  Tom Tromey  <tom@tromey.com>
2858
2859         * objfiles.h: Include bcache.h.
2860
2861 2019-03-23  Tom Tromey  <tom@tromey.com>
2862
2863         * linespec.c (get_current_search_block): Use
2864         scoped_restore_current_language.
2865         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2866
2867 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2868             Jiong Wang  <jiong.wang@arm.com>
2869
2870         * aarch64-linux-tdep.c
2871         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2872         section.
2873         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2874
2875 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2876             Jiong Wang  <jiong.wang@arm.com>
2877
2878         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2879         instructions.
2880         (aarch64_analyze_prologue_test): Add PACIASP test.
2881         (aarch64_prologue_prev_register): Unmask PC value.
2882
2883 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2884             Jiong Wang  <jiong.wang@arm.com>
2885
2886         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2887         (aarch64_dwarf2_prev_register): Unmask PC value.
2888         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2889         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2890         DW_CFA_AARCH64_negate_ra_state.
2891         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2892
2893 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2894             Jiong Wang  <jiong.wang@arm.com>
2895
2896         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2897         registers.
2898         (aarch64_pseudo_register_name): Likewise.
2899         (aarch64_pseudo_register_type): Likewise.
2900         (aarch64_pseudo_register_reggroup_p): Likewise.
2901         (aarch64_gdbarch_init): Add pauth registers.
2902         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2903         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2904         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2905         (struct gdbarch_tdep): Add regnum for ra_state.
2906
2907 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2908             Jiong Wang  <jiong.wang@arm.com>
2909
2910         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2911
2912 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2913             Jiong Wang  <jiong.wang@arm.com>
2914
2915         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2916         function.
2917         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2918         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2919         (aarch64_gdbarch_init): Add puth registers.
2920         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2921         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2922         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2923
2924 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2925             Jiong Wang  <jiong.wang@arm.com>
2926
2927         * aarch64-linux-nat.c
2928         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2929         * aarch64-linux-tdep.c
2930         (aarch64_linux_core_read_description): Likewise.
2931         (aarch64_linux_get_hwcap): New function.
2932         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2933         (aarch64_linux_get_hwcap): New declaration.
2934
2935 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2936             Jiong Wang  <jiong.wang@arm.com>
2937
2938         * aarch64-linux-nat.c
2939         (aarch64_linux_nat_target::read_description): Add pauth param.
2940         * aarch64-linux-tdep.c
2941         (aarch64_linux_core_read_description): Likewise.
2942         * aarch64-tdep.c (struct target_desc): Add in pauth.
2943         (aarch64_read_description): Add pauth param.
2944         (aarch64_gdbarch_init): Likewise.
2945         * aarch64-tdep.h (aarch64_read_description): Likewise.
2946         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2947         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2948         * features/Makefile: Add new files.
2949         * features/aarch64-pauth.c: New file.
2950         * features/aarch64-pauth.xml: New file.
2951
2952 2019-03-20  Tom Tromey  <tromey@adacore.com>
2953
2954         * infrun.c (handle_inferior_event): Rename from
2955         handle_inferior_event_1.  Create a scoped_value_mark.
2956         (handle_inferior_event): Remove.
2957
2958 2019-03-19  Tom Tromey  <tromey@adacore.com>
2959
2960         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2961         * infrun.h (print_stop_event): Add "displays" parameter.
2962         * infrun.c (print_stop_event): Add "displays" parameter.
2963
2964 2019-03-19  Pedro Alves  <palves@redhat.com>
2965
2966         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2967         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2968         to -1.  Fix TABs vs spaces.
2969         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2970         * tui/tui-out.h (tui_ui_out) Add intro comments.
2971         <m_line, m_start_of_line>: In-class initialize, and add describing
2972         comment.
2973
2974 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2975
2976         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2977         variable names.
2978         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2979
2980 2019-03-18  Pedro Alves  <palves@redhat.com>
2981             Eli Zaretskii <eliz@gnu.org>
2982
2983         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2984         m_line and m_start_of_line.
2985
2986 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2987
2988         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2989         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2990         it returns a newline.  This fixes a regression in TU mode, whereby
2991         the next line is output on the same screen line as the user input.
2992
2993 2019-03-18  Tom Tromey  <tromey@adacore.com>
2994
2995         * minsyms.c (minimal_symbol_reader::install): Remove call to
2996         obstack_blank.
2997
2998 2019-03-18  Pedro Alves  <palves@redhat.com>
2999
3000         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3001         New globals.
3002         (apply_style): New, factored out from ...
3003         (apply_ansi_escape): ... this.  Handle reverse video mode.
3004         (tui_set_reverse_mode): New function.
3005         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3006         * tui/tui-winsource.c (tui_show_source_line): Use
3007         tui_set_reverse_mode instead of setting A_STANDOUT.
3008         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3009         New setter methods.
3010
3011 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3012
3013         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3014         Handle tabs.
3015
3016 2019-03-18  Tom Tromey  <tromey@adacore.com>
3017
3018         * ada-lang.c (empty_array): Add "high" parameter.
3019         (ada_evaluate_subexp): Update.
3020
3021 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3022
3023         * unittests/string_view-selftests.c: Define
3024         _initialize_string_view_selftests unconditionally.
3025
3026 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3027
3028         PR gdb/24350
3029         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3030
3031 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3032
3033         PR gdb/24351
3034         * windows-nat.c (display_selector): Fix format specifiers.
3035
3036 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3037
3038         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3039         tui_refill_source_window instead of tui_refresh_win, to update the
3040         current execution line.  This fixes redisplay of the current line
3041         when stepping through the code with "next" or "step".
3042
3043 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3044
3045         * source-cache.c (source_cache::get_source_lines): Call
3046         find_source_lines to initialize s->nlines.  This fixes vertical
3047         scrolling of TUI source window when the DOWN arrow is pressed.
3048
3049 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3050
3051         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3052         linux-thread-db.c (_initialize_thread_db): Likewise.
3053
3054 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3055
3056         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3057         wclrtoeol in tui_show_source_line".  This reverts changes made in
3058         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3059
3060 2019-03-15  Tom Tromey  <tom@tromey.com>
3061
3062         * symtab.h (struct minimal_symbol): Derive from
3063         general_symbol_info.
3064         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3065         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3066         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3067         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3068         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3069         (MSYMBOL_SEARCH_NAME): Update.
3070         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3071         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3072         * minsyms.c (minimal_symbol_reader::record_full): Update.
3073
3074 2019-03-15  Tom Tromey  <tom@tromey.com>
3075
3076         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3077
3078 2019-03-15  Tom Tromey  <tom@tromey.com>
3079
3080         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3081         unique_xmalloc_ptr.
3082         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3083         Update.
3084         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3085         (build_minimal_symbol_hash_tables)
3086         (minimal_symbol_reader::install): Update.
3087
3088 2019-03-15  Tom Tromey  <tom@tromey.com>
3089
3090         * symtab.c (create_demangled_names_hash): Update.
3091         (symbol_set_names): Update.
3092         * objfiles.h (struct objfile_per_bfd_storage)
3093         <demangled_names_hash>: Now an htab_up.
3094         * objfiles.c (objfile_per_bfd_storage): Simplify.
3095
3096 2019-03-15  Tom Tromey  <tom@tromey.com>
3097
3098         * objfiles.h (struct objfile_per_bfd_storage): Declare
3099         destructor.
3100         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3101         New.
3102         (get_objfile_bfd_data): Use new.  Don't initialize
3103         language_of_main.
3104         (free_objfile_per_bfd_storage): Remove.
3105         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3106
3107 2019-03-15  Tom Tromey  <tom@tromey.com>
3108
3109         * symfile.c (reread_symbols): Update.
3110         * objfiles.c (objfile::objfile): Update.
3111         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3112         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3113         comment.
3114         (minimal_symbol_reader::install): Update.
3115         (terminate_minimal_symbol_table): Remove.
3116         * jit.c (jit_object_close_impl): Update.
3117
3118 2019-03-15  Tom Tromey  <tom@tromey.com>
3119
3120         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3121         initializations.
3122
3123 2019-03-15  Tom Tromey  <tom@tromey.com>
3124
3125         * objfiles.h (struct objfile_per_bfd_storage)
3126         <demangled_hash_languages>: Now a bitset.
3127         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3128         (lookup_minimal_symbol): Update.
3129
3130 2019-03-15  Tom Tromey  <tom@tromey.com>
3131
3132         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3133         Don't return the symbol.
3134         * coffread.c (record_minimal_symbol): Use record_full.
3135
3136 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3137
3138         The MS-Windows port of ncurses fails to switch to a color pair if
3139         one or both of the colors are the implicit default colors.  This
3140         change records the default colors when TUI is initialized, and
3141         then specifies them explicitly when a color pair uses the default
3142         colors.  This allows color styling in TUI mode on MS-Windows.
3143
3144         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3145         ncurses_norm_attr.
3146         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3147         colors in ncurses_norm_attr.
3148         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3149         "none", replace it with the default color recorded in
3150         ncurses_norm_attr.
3151
3152 2019-03-14  Tom Tromey  <tromey@adacore.com>
3153
3154         * source-cache.h (class source_cache) <get_source_lines>: Return
3155         std::string.
3156         * source-cache.c (source_cache::extract_lines): Handle case where
3157         first_pos==npos.  Return std::string.
3158         (source_cache::get_source_lines): Update.
3159
3160 2019-03-14  Tom Tromey  <tromey@adacore.com>
3161
3162         * NEWS: Add item for "style sources" commands.
3163         * source-cache.c (source_cache::get_source_lines): Check
3164         source_styling.
3165         * cli/cli-style.c (source_styling): New global.
3166         (_initialize_cli_style): Add "style sources" commands.
3167         (show_style_sources): New function.
3168         * cli/cli-style.h (source_styling): Declare.
3169
3170 2019-03-14  Pedro Alves  <palves@redhat.com>
3171             Tom Tromey  <tromey@adacore.com>
3172
3173         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3174         * tui/tui-winsource.c (tui_refill_source_window): New function,
3175         from...
3176         (tui_horizontal_source_scroll): ... here.  Move some logic.
3177         * cli/cli-style.c (set_style_enabled): Notify new observable.
3178         * tui/tui-hooks.c (tui_redisplay_source): New function.
3179         (tui_attach_detach_observers): Attach or detach
3180         tui_redisplay_source.
3181         * observable.h (source_styling_changed): New observable.
3182         * observable.c: Define source_styling_changed observable.
3183
3184 2019-03-13  Tom Tromey  <tromey@adacore.com>
3185
3186         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3187         (i386_gnu_nat_target::store_registers): Update.
3188         * target-debug.h (target_debug_print_std_string): New macro.
3189         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3190         * windows-tdep.c (display_one_tib): Update.
3191         * tui/tui-stack.c (tui_make_status_line): Update.
3192         * top.c (print_inferior_quit_action): Update.
3193         * thread.c (thr_try_catch_cmd): Update.
3194         (add_thread_with_info): Update.
3195         (thread_target_id_str): Update.
3196         (thr_try_catch_cmd): Update.
3197         (thread_command): Update.
3198         (thread_find_command): Update.
3199         * record-btrace.c (record_btrace_target::info_record)
3200         (record_btrace_resume_thread, record_btrace_target::resume)
3201         (record_btrace_cancel_resume, record_btrace_step_thread)
3202         (record_btrace_target::wait, record_btrace_target::wait)
3203         (record_btrace_target::wait, record_btrace_target::stop): Update.
3204         * progspace.c (print_program_space): Update.
3205         * process-stratum-target.c
3206         (process_stratum_target::thread_address_space): Update.
3207         * linux-fork.c (linux_fork_mourn_inferior)
3208         (detach_checkpoint_command, info_checkpoints_command)
3209         (linux_fork_context): Update.
3210         (linux_fork_detach): Update.
3211         (class scoped_switch_fork_info): Update.
3212         (delete_checkpoint_command): Update.
3213         * infrun.c (follow_fork_inferior): Update.
3214         (follow_fork_inferior): Update.
3215         (proceed_after_vfork_done): Update.
3216         (handle_vfork_child_exec_or_exit): Update.
3217         (follow_exec): Update.
3218         (displaced_step_prepare_throw): Update.
3219         (displaced_step_restore): Update.
3220         (start_step_over): Update.
3221         (resume_1): Update.
3222         (clear_proceed_status_thread): Update.
3223         (proceed): Update.
3224         (print_target_wait_results): Update.
3225         (do_target_wait): Update.
3226         (context_switch): Update.
3227         (stop_all_threads): Update.
3228         (restart_threads): Update.
3229         (finish_step_over): Update.
3230         (handle_signal_stop): Update.
3231         (switch_back_to_stepped_thread): Update.
3232         (keep_going_pass_signal): Update.
3233         (print_exited_reason): Update.
3234         (normal_stop): Update.
3235         * inferior.c (inferior_pid_to_str): Change return type.
3236         (print_selected_inferior): Update.
3237         (add_inferior): Update.
3238         (detach_inferior): Update.
3239         * dummy-frame.c (fprint_dummy_frames): Update.
3240         * dcache.c (dcache_info_1): Update.
3241         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3242         (btrace_fetch, btrace_clear): Update.
3243         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3244         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3245         type.
3246         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3247         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3248         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3249         * gdbarch.c, gdbarch.h: Rebuild.
3250         * gdbarch.sh (core_pid_to_str): Change return type.
3251         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3252         return type.
3253         (windows_nat_target::pid_to_str): Change return type.
3254         (windows_delete_thread): Update.
3255         (windows_nat_target::attach): Update.
3256         (windows_nat_target::files_info): Update.
3257         * target-delegates.c: Rebuild.
3258         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3259         return type.
3260         (sol_thread_target::pid_to_str): Change return type.
3261         * remote.c (class remote_target) <pid_to_str>: Change return
3262         type.
3263         (remote_target::pid_to_str): Change return type.
3264         (extended_remote_target::attach, remote_target::remote_stop_ns)
3265         (remote_target::remote_notif_remove_queued_reply)
3266         (remote_target::push_stop_reply, remote_target::disable_btrace):
3267         Update.
3268         (extended_remote_target::attach): Update.
3269         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3270         type.
3271         (gdbsim_target::pid_to_str): Change return type.
3272         * ravenscar-thread.c (struct ravenscar_thread_target)
3273         <pid_to_str>: Change return type.
3274         (ravenscar_thread_target::pid_to_str): Change return type.
3275         * procfs.c (class procfs_target) <pid_to_str>: Change return
3276         type.
3277         (procfs_target::pid_to_str): Change return type.
3278         (procfs_target::attach): Update.
3279         (procfs_target::detach): Update.
3280         (procfs_target::fetch_registers): Update.
3281         (procfs_target::store_registers): Update.
3282         (procfs_target::wait): Update.
3283         (procfs_target::files_info): Update.
3284         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3285         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3286         return type.
3287         (nto_procfs_target::pid_to_str): Change return type.
3288         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3289         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3290         return type.
3291         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3292         (exit_lwp): Update.
3293         (attach_proc_task_lwp_callback, get_detach_signal)
3294         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3295         (linux_nat_target::resume, wait_lwp, stop_callback)
3296         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3297         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3298         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3299         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3300         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3301         type.
3302         (inf_ptrace_target::attach): Update.
3303         (inf_ptrace_target::files_info): Update.
3304         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3305         type.
3306         (go32_nat_target::pid_to_str): Change return type.
3307         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3308         (gnu_nat_target::wait): Update.
3309         (gnu_nat_target::wait): Update.
3310         (gnu_nat_target::resume): Update.
3311         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3312         (fbsd_nat_target::wait): Update.
3313         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3314         type.
3315         (darwin_nat_target::attach): Update.
3316         * corelow.c (class core_target) <pid_to_str>: Change return type.
3317         (core_target::pid_to_str): Change return type.
3318         * target.c (normal_pid_to_str): Change return type.
3319         (default_pid_to_str): Likewise.
3320         (target_pid_to_str): Change return type.
3321         (target_translate_tls_address): Update.
3322         (target_announce_detach): Update.
3323         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3324         return type.
3325         (bsd_uthread_target::pid_to_str): Change return type.
3326         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3327         type.
3328         (bsd_kvm_target::pid_to_str): Change return type.
3329         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3330         return type.
3331         (aix_thread_target::pid_to_str): Change return type.
3332         * target.h (struct target_ops) <pid_to_str>: Change return type.
3333         (target_pid_to_str, normal_pid_to_str): Likewise.
3334         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3335         type.
3336         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3337         type.
3338         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3339         return type.
3340         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3341         type.
3342         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3343         type.
3344         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3345         return type.
3346
3347 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3348
3349         * NEWS: Mention that the new default MI version is 3.  Mention
3350         changes to the output of commands and events that deal with
3351         multi-location breakpoints.
3352         * breakpoint.c: Include "mi/mi-out.h".
3353         (print_one_breakpoint): Change output syntax if using MI version
3354         >= 3.
3355         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3356         New.
3357         (mi_multi_location_breakpoint_output_fixed): New.
3358         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3359         (mi_cmd_fix_multi_location_breakpoint_output): New.
3360         (mi_multi_location_breakpoint_output_fixed): New.
3361         * mi/mi-cmds.c (mi_cmds): Register command
3362         -fix-multi-location-breakpoint-output.
3363         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3364         interpreter "mi".
3365
3366 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3367
3368         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3369         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3370         instantiate mi_ui_out based on interpreter name.
3371         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3372         * mi/mi-main.c (mi_load_progress): Likewise.
3373
3374 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3375
3376         * NEWS: Combine separate "New targets" sections for 8.3.
3377
3378 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3379
3380         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3381         (ppcfbsd_init_abi): Install gdbarch
3382         "fetch_tls_load_module_address" and "get_thread_local_address"
3383         methods.
3384
3385 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3386
3387         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3388         (riscv_fbsd_init_abi): Install gdbarch
3389         "fetch_tls_load_module_address" and "get_thread_local_address"
3390         methods.
3391
3392 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3393
3394         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3395         (i386fbsd_init_abi): Install gdbarch
3396         "fetch_tls_load_module_address" and "get_thread_local_address"
3397         methods.
3398
3399 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3400
3401         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3402         (amd64fbsd_init_abi): Install gdbarch
3403         "fetch_tls_load_module_address" and "get_thread_local_address"
3404         methods.
3405
3406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3407
3408         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3409         (struct fbsd_pspace_data): New type.
3410         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3411         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3412         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3413         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3414         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3415
3416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3417
3418         * gdbtypes.c (lookup_struct_elt): New function.
3419         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3420         * gdbtypes.h (struct struct_elt): New type.
3421         (lookup_struct_elt): New prototype.
3422
3423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3424
3425         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3426         remove disabled code block.
3427
3428 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3429
3430         * gdbarch.sh (get_thread_local_address): New method.
3431         * gdbarch.h, gdbarch.c: Regenerate.
3432         * target.c (target_translate_tls_address): Use
3433         gdbarch_get_thread_local_address if present instead of
3434         target::get_thread_local_address.
3435
3436 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3437
3438         * target.h (target::get_thread_local_address): Update comment.
3439
3440 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3441
3442         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3443         objfile->separate_debug_objfile_backlink if not NULL.
3444
3445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3446
3447         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3448         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3449         (amd64bsd_store_inferior_registers): Likewise.
3450         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3451         Enable segment base registers.
3452         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3453         PT_GETFSBASE and PT_GETGSBASE.
3454         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3455         PT_SETGSBASE.
3456         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3457         segment base registers.
3458         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3459
3460 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3461
3462         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3463         Update calls to i386_target_description to add 'segments'
3464         parameter.
3465         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3466         add segment base registers.
3467         * arch/i386.c (i386_create_target_description): Add 'segments'
3468         parameter to enable segment base registers.
3469         * arch/i386.h (i386_create_target_description): Likewise.
3470         * features/i386/32bit-segments.xml: New file.
3471         * features/i386/32bit-segments.c: Generate.
3472         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3473         call to i386_target_description to add 'segments' parameter.
3474         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3475         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3476         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3477         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3478         if feature is present.
3479         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3480         Add 'segments' parameter to call to i386_target_description.
3481         (i386_target_description): Add 'segments' parameter to enable
3482         segment base registers.
3483         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3484         to call to i386_target_description.
3485         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3486         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3487         Define I386_NUM_REGS.
3488         (i386_target_description): Add 'segments' parameter to enable
3489         segment base registers.
3490
3491 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3492
3493         PR/24325
3494         * source-cache.c: #undef open and close, to avoid unresolved
3495         externals during linking.
3496
3497 2019-03-12  Tom Tromey  <tromey@adacore.com>
3498
3499         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3500         const.  Add initializers.
3501         (_initialize_remote): Don't initialize ptid globals.
3502
3503 2019-03-12  Pedro Alves  <palves@redhat.com>
3504
3505         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3506
3507 2019-03-12  Pedro Alves  <palves@redhat.com>
3508
3509         * cp-name-parser.y (main): Remove unused 'len' variable.
3510
3511 2019-03-12  Tom Tromey  <tromey@adacore.com>
3512
3513         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3514         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3515
3516 2019-03-12  Tom Tromey  <tromey@adacore.com>
3517
3518         * linux-nat.c (iterate_over_lwps): Update.
3519         (stop_callback): Remove parameter.
3520         (stop_wait_callback, detach_callback, resume_set_callback)
3521         (select_singlestep_lwp_callback, set_ignore_sigint)
3522         (status_callback, resumed_callback, resume_clear_callback)
3523         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3524         data parameter.
3525         (linux_nat_target::detach, linux_nat_target::resume)
3526         (linux_stop_and_wait_all_lwps, select_event_lwp)
3527         (linux_nat_filter_event, linux_nat_wait_1)
3528         (linux_nat_target::kill, linux_nat_target::stop)
3529         (linux_nat_target::stop): Update.
3530         (linux_nat_resume_callback): Change type.
3531         (resume_stopped_resumed_lwps, count_events_callback)
3532         (select_event_lwp_callback): Likewise.
3533         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3534         * arm-linux-nat.c (struct update_registers_data): Remove.
3535         (update_registers_callback): Change type.
3536         (arm_linux_insert_hw_breakpoint1): Update.
3537         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3538         parameter.
3539         (x86_linux_dr_set_addr): Update.
3540         (x86_linux_dr_set_control): Update.
3541         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3542         (iterate_over_lwps): Use gdb::function_view.
3543         * nat/aarch64-linux-hw-point.c (struct
3544         aarch64_dr_update_callback_param): Remove.
3545         (debug_reg_change_callback): Change type.
3546         (aarch64_notify_debug_reg_change): Update.
3547         * s390-linux-nat.c (s390_refresh_per_info): Update.
3548
3549 2019-03-11  Tom Tromey  <tromey@adacore.com>
3550
3551         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3552         redundant assignment to "this_cu".
3553
3554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3555
3556         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3557
3558 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3559
3560         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3561         from...
3562         (rank_one_type): ... this.
3563
3564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3565
3566         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3567         from...
3568         (rank_one_type): ... this.
3569
3570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3571
3572         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3573         from...
3574         (rank_one_type): ... this.
3575
3576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3577
3578         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3579         from...
3580         (rank_one_type): ... this.
3581
3582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3583
3584         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3585         from...
3586         (rank_one_type): ... this.
3587
3588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3589
3590         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3591         from...
3592         (rank_one_type): ... this.
3593
3594 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3595
3596         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3597         from...
3598         (rank_one_type): ... this.
3599
3600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3601
3602         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3603         from...
3604         (rank_one_type): ... this.
3605
3606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3607
3608         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3609         from...
3610         (rank_one_type): ... this.
3611
3612 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3613
3614         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3615         from...
3616         (rank_one_type): ... this.
3617
3618 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3619
3620         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3621         from...
3622         (rank_one_type): ... this.
3623
3624 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3625
3626         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3627         from...
3628         (rank_one_type): ... this.
3629
3630 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3631
3632         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3633         inferior-events' shows the example events.
3634
3635 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3636
3637         Support styling on native MS-Windows console
3638
3639         PR/24315
3640         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3641         on MS-Windows if $TERM is not defined.
3642
3643         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3644
3645         * posix-hdep.c (gdb_console_fputs):
3646         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3647         functions.
3648         * ui-file.h (gdb_console_fputs): Add prototype.
3649
3650         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3651         back to fputs only if the former returns zero.
3652
3653 2019-03-07  Tom Tromey  <tom@tromey.com>
3654
3655         * symmisc.c (print_symbol_bcache_statistics): Update.
3656         (print_objfile_statistics): Update.
3657         * symfile.c (allocate_symtab): Update.
3658         * stabsread.c: Don't include bcache.h.
3659         * psymtab.h (struct psymbol_bcache): Don't declare.
3660         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3661         (psymbol_bcache_init, psymbol_bcache_free)
3662         (psymbol_bcache_get_bcache): Don't declare.
3663         * psymtab.c (struct psymbol_bcache): Remove.
3664         (psymtab_storage::psymtab_storage): Update.
3665         (psymtab_storage::~psymtab_storage): Update.
3666         (psymbol_bcache_init, psymbol_bcache_free)
3667         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3668         (add_psymbol_to_bcache): Update.
3669         (allocate_psymtab): Update.
3670         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3671         macro_cache>: No longer pointers.
3672         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3673         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3674         * macrotab.c (macro_bcache): Update.
3675         * macroexp.c: Don't include bcache.h.
3676         * gdbtypes.c (check_types_worklist): Update.
3677         (types_deeply_equal): Remove TRY/CATCH.  Update.
3678         * elfread.c (elf_symtab_read): Update.
3679         * dwarf2read.c: Don't include bcache.h.
3680         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3681         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3682         (print_bcache_statistics, bcache_memory_used): Don't declare.
3683         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3684         methods.  Rename all data members.
3685         * bcache.c (struct bcache): Move to bcache.h.
3686         (bcache::expand_hash_table): Rename from expand_hash_table.
3687         (bcache): Remove.
3688         (bcache::insert): Rename from bcache_full.
3689         (bcache::compare): Rename from bcache_compare.
3690         (bcache_xmalloc): Remove.
3691         (bcache::~bcache): Rename from bcache_xfree.
3692         (bcache::print_statistics): Rename from print_bcache_statistics.
3693         (bcache::memory_used): Rename from bcache_memory_used.
3694
3695 2019-03-07  Pedro Alves  <palves@redhat.com>
3696
3697         * infrun.c (normal_stop): Also check for
3698         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3699
3700 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         * f-lang.c (value_from_host_double): Moved to...
3703         * value.c (value_from_host_double): ...here.
3704         * value.h (value_from_host_double): Declare.
3705         * guile/scm-math.c (vlscm_convert_typed_number): Use
3706         value_from_host_double.
3707         (vlscm_convert_number): Likewise.
3708         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3709         * python/py-value.c (convert_value_from_python): Likewise.
3710
3711 2019-03-06  Tom Tromey  <tom@tromey.com>
3712
3713         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3714
3715 2019-03-06  Tom Tromey  <tom@tromey.com>
3716
3717         * utils.h (free_current_contents): Don't declare.
3718         * utils.c (free_current_contents): Remove.
3719
3720 2019-03-06  Tom Tromey  <tom@tromey.com>
3721
3722         * top.c (quit_force): Update.
3723         * main.c (captured_command_loop): Update.
3724         * common/new-op.c (operator new): Update.
3725         * common/common-exceptions.c (struct catcher)
3726         <save_cleanup_chain>: Remove member.
3727         (exceptions_state_mc_init): Update.
3728         (exception_try_scope_entry): Return nullptr.
3729         (exception_try_scope_exit, exception_rethrow)
3730         (throw_exception_sjlj, throw_exception_cxx): Update.
3731         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3732         (all_cleanups, do_cleanups, discard_cleanups)
3733         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3734         (restore_cleanups, restore_final_cleanups): Don't declare.
3735         (do_final_cleanups): Remove parameter.
3736         * common/cleanups.c (cleanup_chain, make_cleanup)
3737         (make_cleanup_dtor, all_cleanups, do_cleanups)
3738         (discard_my_cleanups, discard_cleanups)
3739         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3740         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3741         (null_cleanup): Remove.
3742         (do_final_cleanups): Remove parameter.
3743
3744 2019-03-06  Tom Tromey  <tom@tromey.com>
3745
3746         * remote.c (remote_target::remote_parse_stop_reply): Use
3747         unique_xmalloc_ptr.
3748
3749 2019-03-06  Tom Tromey  <tom@tromey.com>
3750
3751         * stabsread.c (struct stabs_field_info): Rename from field_info.
3752         <list, fnlist>: Add initializers.
3753         <obstack>: New member.
3754         (read_member_functions, read_struct_fields, read_baseclasses):
3755         Allocate on obstack.  Don't use cleanups.
3756         (read_one_struct_field, read_member_functions, read_struct_fields)
3757         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3758         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3759         (read_struct_type): Update.
3760
3761 2019-03-06  Tom Tromey  <tom@tromey.com>
3762
3763         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3764         * common/filestuff.h (make_cleanup_close): Don't declare.
3765         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3766         Remove.
3767
3768 2019-03-06  Tom Tromey  <tom@tromey.com>
3769
3770         * solib-aix.c: Use make_scope_exit.
3771
3772 2019-03-06  Tom Tromey  <tom@tromey.com>
3773
3774         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3775         Use make_scope_exit.
3776
3777 2019-03-06  Tom Tromey  <tom@tromey.com>
3778
3779         * solib-svr4.c (disable_probes_interface): Remove parameter.
3780         (svr4_handle_solib_event): Use make_scope_exit.
3781
3782 2019-03-06  Tom Tromey  <tom@tromey.com>
3783
3784         * remote.c (struct stop_reply_deleter): Remove.
3785         (stop_reply_up): Update.
3786         (struct stop_reply): Derive from notif_event.  Don't typedef.
3787         <regcache>: Now a std::vector.
3788         (stop_reply_xfree): Remove.
3789         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3790         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3791         (remote_target::discard_pending_stop_replies): Use delete.
3792         (remote_target::remote_parse_stop_reply): Update.
3793         (remote_target::process_stop_reply): Update.
3794         * remote-notif.h (struct notif_event): Add virtual destructor.
3795         Remove "dtr" member.
3796         (struct notif_client) <alloc_event>: Return a unique_ptr.
3797         (notif_event_xfree): Don't declare.
3798         (notif_event_up): New typedef.
3799         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3800         (notif_event_xfree, do_notif_event_xfree): Remove.
3801         (remote_notif_state_xfree): Update.
3802
3803 2019-03-06  Tom Tromey  <tom@tromey.com>
3804
3805         * infrun.c (displaced_step_clear_cleanup): Now a
3806         forward_scope_exit type.
3807         (displaced_step_prepare_throw): Update.
3808         (displaced_step_fixup): Update.
3809
3810 2019-03-06  Tom Tromey  <tom@tromey.com>
3811
3812         * inferior.h (class inferior): Update comment.
3813         * gdbthread.h (class thread_info): Update comment.
3814
3815 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3816             Tom Tromey  <tom@tromey.com>
3817
3818         * stabsread.h (struct stab_section_list): Remove.
3819         (coffstab_build_psymtabs): Update.
3820         * dbxread.c (symbuf_sections): Now a std::vector.
3821         (sect_idx): New global.
3822         (fill_symbuf): Update.
3823         (coffstab_build_psymtabs): Change type of stabsects parameter.
3824         Update.
3825         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3826         std::vector.
3827         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3828         (coff_locate_sections): Update.
3829         (coff_symfile_read): Remove cleanups.  Update.
3830         (init_stringtab): Add storage parameter.
3831         (free_stringtab, free_stringtab_cleanup): Remove.
3832         (init_lineno): Add storage parameter.
3833         (free_linetab, free_linetab_cleanup): Remove.
3834
3835 2019-03-06  Pedro Alves  <palves@redhat.com>
3836
3837         * linux-fork.c (fork_info::clobber_regs): Delete.
3838         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3839         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3840         comment.  Adjust.
3841         (scoped_switch_fork_info::scoped_switch_fork_info)
3842         (checkpoint_command, linux_fork_context): Adjust
3843         fork_save_infrun_state calls.
3844
3845 2019-03-06  Pedro Alves  <palves@redhat.com>
3846
3847         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3848         (inf_has_multiple_threads): Return 'bool' and rewrite using
3849         inferior_info::threads().
3850
3851 2019-03-06  Pedro Alves  <palves@redhat.com>
3852
3853         * linux-fork.c: Include <list>.
3854         (fork_list): Now a std::list instance.
3855         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3856         (forks_exist_p, find_last_fork): Adjust.
3857         (new_fork): Delete.
3858         (one_fork_p): New.
3859         (add_fork): Adjust.
3860         (free_fork): Delete, folded into fork_info::~fork_info().
3861         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3862         Adjust.
3863         (init_fork_list): Delete.
3864         (linux_fork_killall, linux_fork_mourn_inferior)
3865         (linux_fork_detach, info_checkpoints_command): Adjust.
3866         (_initialize_linux_fork): No longer call init_fork_list.
3867
3868 2019-03-06  Pedro Alves  <palves@redhat.com>
3869
3870         * linux-fork.c (new_fork): New, split out of ...
3871         (add_fork): ... this.  Return void.  Move "first fork" special
3872         case from here, to ...
3873         (checkpoint_command): ... here.
3874         * linux-linux.h (add_fork): Return void.
3875
3876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3879
3880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3881             Chris January  <chris.january@arm.com>
3882             David Lecomber  <david.lecomber@arm.com>
3883
3884         * f-exp.y: New token, UNOP_INTRINSIC.
3885         (exp): New pattern using UNOP_INTRINSIC token.
3886         (f77_keywords): Add 'abs' keyword.
3887         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3888         (value_from_host_double): New function.
3889         (evaluate_subexp_f): Support UNOP_ABS.
3890
3891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3894         types.
3895
3896 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3899         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3900         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3901
3902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3903
3904         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3905
3906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3907             Chris January  <chris.january@arm.com>
3908
3909         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3910         * f-exp.y: Define 'KIND' token.
3911         (exp): New pattern for KIND expressions.
3912         (ptype): Handle types with a kind extension.
3913         (direct_abs_decl): Extend to spot kind extensions.
3914         (f77_keywords): Add 'kind' to the list.
3915         (push_kind_type): New function.
3916         (convert_to_kind_type): New function.
3917         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3918         * parse.c (operator_length_standard): Likewise.
3919         * parser-defs.h (enum type_pieces): Add tp_kind.
3920         * std-operator.def: Add UNOP_KIND.
3921
3922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3923
3924         * f-exp.y (f_parse): Set yydebug.
3925
3926 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * f-lang.c (evaluate_subexp_f): New function.
3929         (exp_descriptor_f): New global.
3930         (f_language_defn): Use exp_descriptor_f instead of
3931         exp_descriptor_standard.
3932
3933 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * f-exp.y (struct token): Add comments.
3936         (dot_ops): Remove uppercase versions and the end marker.
3937         (f77_keywords): Likewise.
3938         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3939         entries in the dot_ops array are case insensitive, and use
3940         strncasecmp to compare strings.  Also some whitespace cleanup in
3941         this area.  Similar for the f77_keywords array, except entries in
3942         this list might be case sensitive.
3943
3944 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3945
3946         * f-exp.y (struct f77_boolean_val): Add comments.
3947         (boolean_values): Remove uppercase versions, and end marker.
3948         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3949         and use strncasecmp to achieve case insensitivity.  Additionally,
3950         perform whitespace cleanup around this code.
3951
3952 2019-03-06  Tom Tromey  <tromey@adacore.com>
3953
3954         * remote-sim.c (gdbsim_target_open): Use result of
3955         gdb_argv::release.
3956
3957 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3958         Dirk Schubert  <dirk.schubert@arm.com>
3959         Chris January  <chris.january@arm.com>
3960
3961         * eval.c (evaluate_subexp_standard): Call Fortran argument
3962         wrapping logic.
3963         * f-lang.c (struct value): A value which can be passed into a
3964         Fortran function call.
3965         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3966         where appropriate.
3967         (struct type): Value ready for a Fortran function call.
3968         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3969         is needed.
3970         * f-lang.h (fortran_argument_convert): Declaration.
3971         (fortran_preserve_arg_pointer): Declaration.
3972         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3973
3974 2019-03-05  Tom Tromey  <tromey@adacore.com>
3975
3976         * python/py-prettyprint.c (print_string_repr): Remove #if.
3977         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3978
3979 2019-03-05  Tom Tromey  <tromey@adacore.com>
3980
3981         * target.c (the_dummy_target): Move later.  Change type to
3982         "dummy_target".
3983         (initialize_targets): Don't initialize the_dummy_target.
3984
3985 2019-03-05  Tom Tromey  <tromey@adacore.com>
3986
3987         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3988         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3989
3990 2019-03-05  Tom Tromey  <tromey@adacore.com>
3991
3992         * windows-nat.c (windows_nat_target::attach)
3993         (windows_nat_target::detach): Don't call gdb_flush.
3994         * valprint.c (generic_val_print, val_print, val_print_string):
3995         Don't call gdb_flush.
3996         * utils.c (defaulted_query): Don't call gdb_flush.
3997         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3998         * target.c (target_announce_detach): Don't call gdb_flush.
3999         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4000         * remote.c (extended_remote_target::attach): Don't call
4001         gdb_flush.
4002         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4003         * printcmd.c (do_examine): Don't call gdb_flush.
4004         (info_display_command): Don't call gdb_flush.
4005         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4006         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4007         * memattr.c (info_mem_command): Don't call gdb_flush.
4008         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4009         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4010         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4011         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4012         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4013         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4014         (gnu_nat_target::detach): Don't call gdb_flush.
4015         * f-valprint.c (f_val_print): Don't call gdb_flush.
4016         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4017         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4018         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4019         gdb_flush.
4020         * c-valprint.c (c_val_print): Don't call gdb_flush.
4021         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4022
4023 2019-03-05  Tom Tromey  <tromey@adacore.com>
4024
4025         * varobj.c (update_dynamic_varobj_children): Update.
4026         (install_default_visualizer): Use reset, not release.
4027         * value.c (set_internalvar): Update.
4028         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4029         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4030         ATTRIBUTE_UNUSED_RESULT.
4031
4032 2019-03-05  Tom Tromey  <tromey@adacore.com>
4033
4034         * remote.c (class scoped_remote_fd) <release>: Add
4035         ATTRIBUTE_UNUSED_RESULT.
4036
4037 2019-03-05  Tom Tromey  <tromey@adacore.com>
4038
4039         * macroexp.c (struct macro_buffer) <release>: Add
4040         ATTRIBUTE_UNUSED_RESULT.
4041
4042 2019-03-05  Tom Tromey  <tromey@adacore.com>
4043
4044         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4045         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4046         ATTRIBUTE_UNUSED_RESULT.
4047
4048 2019-03-05  Tom Tromey  <tromey@adacore.com>
4049
4050         * common/scoped_fd.h (class scoped_fd) <release>: Add
4051         ATTRIBUTE_UNUSED_RESULT.
4052
4053 2019-03-05  Tom Tromey  <tromey@adacore.com>
4054
4055         * parser-defs.h (struct parser_state) <release>: Add
4056         ATTRIBUTE_UNUSED_RESULT.
4057
4058 2019-03-05  Tom Tromey  <tromey@adacore.com>
4059
4060         * utils.h (class gdb_argv) <release>: Add
4061         ATTRIBUTE_UNUSED_RESULT.
4062         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4063
4064 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4065
4066         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4067         for-loop range, to avoid compiler warnings.
4068
4069         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4070         avoid compiler warnings about unused variables.
4071
4072         * NEWS: Mention end of support for native debugging on MS-Windows
4073         before XP.
4074
4075         PR gdb/24292
4076         * common/netstuff.c:
4077         * gdbserver/gdbreplay.c
4078         * gdbserver/remote-utils.c:
4079         * ser-tcp.c:
4080         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4081         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4082         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4083         'getaddrinfo' and 'freeaddrinfo' were not available before
4084         Windows XP, and mingw.org's MinGW headers by default define
4085         _WIN32_WINNT to 0x500.
4086
4087 2019-03-01  Gary Benson <gbenson@redhat.com>
4088
4089         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4090
4091 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4092             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4093
4094         PR gdb/8527
4095         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4096         set_sigint_trap, clear_sigint_trap.
4097
4098 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4099
4100         * target.c (target_detach): Clear the regcache and the
4101         frame cache.
4102
4103 2019-02-27  Pedro Alves  <palves@redhat.com>
4104
4105         * utils.c (set_screen_size): When we cap the height/width sizes,
4106         tweak the corresponding command variable to show "unlimited":
4107
4108 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4109             Pedro Alves  <palves@redhat.com>
4110
4111         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4112         before calling rl_set_screen_size.
4113
4114 2019-02-27  Tom Tromey  <tromey@adacore.com>
4115
4116         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4117         define.
4118         * python/py-value.c: Remove Python 2.4 workaround.
4119         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4120         workaround.
4121         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4122         Python 2.4 workaround.
4123         * python/python-internal.h: Remove Python 2.4 comment.
4124         (Py_ssize_t): Don't define.
4125         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4126         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4127         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4128         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4129         * python/python.c (do_start_initialization): Remove Python 2.4
4130         workaround.
4131         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4132         (print_children): Remove Python 2.4 workaround.
4133         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4134         workaround.
4135         (CHARBUFFERPROC_NAME): Remove.
4136         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4137         Python 2.4 workaround.
4138
4139 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4140
4141         * NEWS: Note minimum Python version.
4142
4143 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4144
4145         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4146         code from these functions.  Remove corresponding ifdefs.  Use
4147         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4148         Remove gotos and target of gotos.
4149         (infpy_search_memory): Likewise.
4150
4151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4152
4153         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4154         (hppa_gdbarch_init): Don't register deleted functions with
4155         gdbarch.
4156
4157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4160         (h8300_unwind_sp): Delete.
4161         (h8300_dummy_id): Delete.
4162         (h8300_gdbarch_init): Don't register deleted functions with
4163         gdbarch.
4164
4165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4166
4167         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4168         (ft32_unwind_pc): Delete.
4169         (ft32_unwind_sp): Delete.
4170         (ft32_gdbarch_init): Don't register deleted functions with
4171         gdbarch.
4172
4173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4176         (frv_unwind_pc): Delete.
4177         (frv_unwind_sp): Delete.
4178         (frv_gdbarch_init): Don't register deleted functions with
4179         gdbarch.
4180
4181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4184         (riscv_unwind_pc): Delete.
4185         (riscv_unwind_sp): Delete.
4186         (riscv_gdbarch_init): Don't register deleted functions with
4187         gdbarch.
4188
4189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4190
4191         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4192         (csky_unwind_pc): Delete.
4193         (csky_unwind_sp): Delete.
4194         (csky_gdbarch_init): Don't register deleted functions with
4195         gdbarch.
4196
4197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4200         (cris_unwind_pc): Delete.
4201         (cris_unwind_sp): Delete.
4202         (cris_gdbarch_init): Don't register deleted functions with
4203         gdbarch.
4204
4205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4206
4207         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4208         (bfin_unwind_pc): Delete.
4209         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4210
4211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4212
4213         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4214         (arm_unwind_pc): Delete.
4215         (arm_unwind_sp): Delete.
4216         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4217
4218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4219
4220         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4221         (arc_unwind_pc): Delete.
4222         (arc_unwind_sp): Delete.
4223         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4224
4225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4226
4227         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4228         (alpha_unwind_pc): Delete.
4229         (alpha_gdbarch_init): Don't register deleted functions with
4230         gdbarch.
4231
4232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4235         (aarch64_unwind_pc): Delete.
4236         (aarch64_unwind_sp): Delete.
4237         (aarch64_gdbarch_init): Don't register deleted functions with
4238         gdbarch.
4239
4240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * gdbtypes.c (type_align): Don't consider static members when
4243         computing structure alignment.
4244
4245 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4248         return 0 for other types.
4249         * arch-utils.c (default_type_align): Always return 0.
4250         * gdbarch.h: Regenerate.
4251         * gdbarch.sh (type_align): Extend comment.
4252         * gdbtypes.c (type_align): Add additional comments, always call
4253         gdbarch_type_align before applying the default rules.
4254         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4255         generic code will then apply a suitable default.
4256         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4257         types, return 0 for other types.
4258
4259 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4260
4261         * NEWS: Create a new section for the next release branch.
4262         Rename the section of the current branch, now that it has
4263         been cut.
4264
4265 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4266
4267         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4268         * version.in: Bump version to 8.3.50.DATE-git.
4269
4270 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4271
4272         * aix-thread.c (ptid_cmp): Remove unused variable.
4273         (get_signaled_thread): Likewise.
4274         (store_regs_user_thread): Likewise.
4275         (store_regs_kernel_thread): Likewise.
4276         (fetch_regs_kernel_thread): Remove shadowed variable.
4277
4278 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * features/riscv/32bit-cpu.xml: Add register numbers.
4281         * features/riscv/32bit-fpu.c: Regenerate.
4282         * features/riscv/32bit-fpu.xml: Add register numbers.
4283         * features/riscv/64bit-cpu.xml: Add register numbers.
4284         * features/riscv/64bit-fpu.c: Regenerate.
4285         * features/riscv/64bit-fpu.xml: Add register numbers.
4286
4287 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4288
4289         * NEWS: Mention two argument form of gdb.Value constructor.
4290         * python/py-value.c (convert_buffer_and_type_to_value): New
4291         function.
4292         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4293         Add support for handling an optional second argument.  Call
4294         convert_buffer_and_type_to_value as appropriate.
4295         * python/python-internal.h (Py_buffer_deleter): New struct.
4296         (Py_buffer_up): New typedef.
4297
4298 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4299
4300         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4301         instead of releasing ownership.
4302
4303 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4304
4305         * dwarf2read.c (open_and_init_dwp_file): Call
4306         elf_numsections instead of bfd_count_sections to initialize
4307         dwp_file->num_sections.
4308
4309 2019-02-25  Tom Tromey  <tromey@adacore.com>
4310
4311         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4312
4313 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4314
4315         * gcore.in: Add '--readnever' option when invoking GDB.
4316
4317 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4318
4319         * MAINTAINERS: Update my email address.
4320
4321 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4322
4323         * build-id.c (build_id_to_debug_bfd_1): New function.
4324         (build_id_to_debug_bfd): Look for separate debug file in
4325         sysroot.
4326
4327 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * gdbarch.sh: Update the copyright year range that is placed into
4330         generated files.
4331
4332 2019-02-22  Keith Seitz  <keiths@redhat.com>
4333
4334         PR symtab/23853
4335         * linespec.c (create_sals_line_offset): Search for the default
4336         symtab's filename instead of its fullname.
4337
4338 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4339
4340         * NEWS: Update style defaults.
4341
4342 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4343
4344         * main.c (captured_main_1): Disable styling in batch mode.
4345
4346 2019-02-20  Tom Tromey  <tom@tromey.com>
4347
4348         * symtab.c (symtab_symbol_info): Fix typos.
4349
4350 2019-02-20  Tom Tromey  <tromey@adacore.com>
4351
4352         * findcmd.c (_initialize_mem_search): Use upper case for
4353         metasyntactic variables.
4354
4355 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4356
4357         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4358         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4359
4360 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4361
4362         * top.h (source_file_name): Change to std::string.
4363         * top.c (source_file_name): Likewise.
4364         (command_line_input): Adjust.
4365         * cli/cli-script.c (script_from_file): Adjust.
4366
4367 2019-02-19  Tom Tromey  <tromey@adacore.com>
4368
4369         * ravenscar-thread.c
4370         (ravenscar_thread_target::update_thread_list): Don't call
4371         ada_build_task_list.
4372         * ada-lang.h (ada_build_task_list): Don't declare.
4373         * ada-tasks.c (struct ada_tasks_inferior_data)
4374         <task_list_valid_p>: Now bool.
4375         (read_known_tasks, ada_task_list_changed)
4376         (ada_tasks_invalidate_inferior_data): Update.
4377         (read_known_tasks_array): Return bool.
4378         (read_known_tasks_list): Likewise.
4379         (read_known_tasks): Return void.
4380         (ada_build_task_list): Now static.
4381
4382 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4383
4384         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4385         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4386
4387 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4388
4389         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4390         variant for ada_tasks_pspace_data_handle and
4391         ada_tasks_inferior_data_handle.
4392         (ada_tasks_pspace_data_cleanup): New function.
4393         (ada_tasks_inferior_data_cleanup): New function.
4394
4395 2019-02-17  Tom Tromey  <tom@tromey.com>
4396
4397         * macrotab.h (macro_source_fullname): Return a std::string.
4398         * macrotab.c (macro_include, check_for_redefinition)
4399         (macro_undef, macro_lookup_definition, foreach_macro)
4400         (foreach_macro_in_scope): Update.
4401         (macro_source_fullname): Return a std::string.
4402         * macrocmd.c (show_pp_source_pos): Update.
4403
4404 2019-02-17  Tom Tromey  <tom@tromey.com>
4405
4406         * macrocmd.c (show_pp_source_pos): Style the file names.
4407
4408 2019-02-17  Tom Tromey  <tom@tromey.com>
4409
4410         PR tui/24197:
4411         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4412
4413 2019-02-17  Tom Tromey  <tom@tromey.com>
4414
4415         * ada-lang.c (user_select_syms): Use filtered printing.
4416         * utils.c (wrap_style): New global.
4417         (desired_style): Remove.
4418         (emit_style_escape): Add stream parameter.
4419         (set_output_style, reset_terminal_style, prompt_for_continue):
4420         Update.
4421         (flush_wrap_buffer): Only flush gdb_stdout.
4422         (wrap_here): Set wrap_style.
4423         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4424         treat escape sequences as a character.  Change when wrap buffer is
4425         flushed.
4426         (fputs_styled): Do not set the output style when the default is
4427         requested.
4428         * ui-style.h (struct ui_file_style) <is_default>: New method.
4429         * source.c (print_source_lines_base): Emit escape sequences in one
4430         piece.
4431
4432 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4433
4434         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4435         integers and enumeration types.
4436
4437 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4438
4439         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4440         instead of lookup_symbol_in_language
4441         (do_exact_match): New function.
4442         (ada_get_symbol_name_matcher): Return do_exact_match when
4443         doing a verbatim match.
4444
4445 2019-02-15  Tom Tromey  <tromey@adacore.com>
4446
4447         * ravenscar-thread.c (ravenscar_thread_target::resume)
4448         (ravenscar_thread_target::wait): Special case wildcard requests.
4449
4450 2019-02-15  Tom Tromey  <tromey@adacore.com>
4451
4452         * ravenscar-thread.c (base_ptid): Remove.
4453         (struct ravenscar_thread_target) <close>: New method.
4454         <m_base_ptid>: New member.
4455         <update_inferior_ptid, active_task, task_is_currently_active,
4456         runtime_initialized>: Declare methods.
4457         <ravenscar_thread_target>: Add constructor.
4458         (ravenscar_thread_target::task_is_currently_active)
4459         (ravenscar_thread_target::update_inferior_ptid)
4460         (ravenscar_runtime_initialized): Rename.  Now methods.
4461         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4462         (ravenscar_thread_target::update_thread_list): Update.
4463         (ravenscar_thread_target::active_task): Now method.
4464         (ravenscar_thread_target::store_registers)
4465         (ravenscar_thread_target::prepare_to_store)
4466         (ravenscar_thread_target::prepare_to_store)
4467         (ravenscar_thread_target::mourn_inferior): Update.
4468         (ravenscar_inferior_created): Use "new" to create target.
4469         (ravenscar_thread_target::get_ada_task_ptid): Update.
4470         (_initialize_ravenscar): Don't initialize base_ptid.
4471         (ravenscar_ops): Remove global.
4472
4473 2019-02-15  Tom Tromey  <tromey@adacore.com>
4474
4475         * target.h (push_target): Declare new overload.
4476         * target.c (push_target): New overload, taking an rvalue reference.
4477         * remote.c (remote_target::open_1): Use push_target overload.
4478         * corelow.c (core_target_open): Use push_target overload.
4479
4480 2019-02-15  Tom Tromey  <tromey@adacore.com>
4481
4482         * ravenscar-thread.c (is_ravenscar_task)
4483         (ravenscar_task_is_currently_active): Return bool.
4484         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4485         (_initialize_ravenscar): Remove "(void)".
4486         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4487         Return bool.
4488
4489 2019-02-15  Tom Tromey  <tromey@adacore.com>
4490
4491         * ravenscar-thread.c (ravenscar_runtime_initializer)
4492         (has_ravenscar_runtime, get_running_thread_id)
4493         (ravenscar_thread_target::resume): Fix indentation.
4494
4495 2019-02-15  Tom Tromey  <tromey@adacore.com>
4496
4497         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4498         from ravenscar_arch_ops.
4499         (sparc_ravenscar_ops::fetch_registers)
4500         (sparc_ravenscar_ops::store_registers): Now methods.
4501         (sparc_ravenscar_prepare_to_store): Remove.
4502         (sparc_ravenscar_ops): Redefine.
4503         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4504         methods and destructor.  Remove members.
4505         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4506         (ravenscar_thread_target::store_registers)
4507         (ravenscar_thread_target::prepare_to_store): Update.
4508         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4509         Remove.
4510         (struct ppc_ravenscar_powerpc_ops): Derive from
4511         ravenscar_arch_ops.
4512         (ppc_ravenscar_powerpc_ops::fetch_registers)
4513         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4514         (ppc_ravenscar_powerpc_ops): Redefine.
4515         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4516         (ppc_ravenscar_e500_ops::fetch_registers)
4517         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4518         (ppc_ravenscar_e500_ops): Redefine.
4519         * aarch64-ravenscar-thread.c
4520         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4521         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4522         (aarch64_ravenscar_fetch_registers)
4523         (aarch64_ravenscar_store_registers): Now methods.
4524         (aarch64_ravenscar_ops): Redefine.
4525
4526 2019-02-15  Tom Tromey  <tromey@adacore.com>
4527
4528         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4529         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4530         (ravenscar_thread_target::stopped_by_watchpoint)
4531         (ravenscar_thread_target::stopped_data_address)
4532         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4533
4534 2019-02-15  Tom Tromey  <tromey@adacore.com>
4535
4536         * ravenscar-thread.c: Fix some typos.
4537
4538 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4539             Tom Tromey  <tromey@adacore.com>
4540
4541         * ada-lang.c (ada_exception_sal): Change addr_string to a
4542         std::string.
4543         (create_ada_exception_catchpoint): Update.
4544
4545 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4546             Tom Tromey  <tromey@adacore.com>
4547
4548         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4549         (bp_location_ops): Remove.
4550         (base_breakpoint_allocate_location): Update.
4551         (free_bp_location): Update.
4552         * ada-lang.c (class ada_catchpoint_location)
4553         <ada_catchpoint_location>: Remove ops parameter.
4554         (ada_catchpoint_location_dtor): Remove.
4555         (ada_catchpoint_location_ops): Remove.
4556         (allocate_location_exception): Update.
4557         * breakpoint.h (struct bp_location_ops): Remove.
4558         (class bp_location) <bp_location>: Remove bp_location_ops
4559         parameter.
4560         <~bp_location>: Add destructor.
4561         <ops>: Remove.
4562
4563 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4564             Pedro Alves  <palves@redhat.com>
4565
4566         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4567         'PATH_MAX'.
4568
4569 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4570             Samuel Thibault  <samuel.thibault@gnu.org>
4571             Thomas Schwinge  <thomas@codesourcery.com>
4572
4573         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4574         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4575
4576 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4577
4578         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4579         (check_empty): Use "const char *".
4580
4581         * gnu-nat.c (gnu_nat_target::detach): Instead of
4582         'detach_inferior (pid)' call
4583         'detach_inferior (find_inferior_pid (pid))'.
4584
4585         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4586         'nat/fork-inferior.o'.
4587         * gnu-nat.c: #include "nat/fork-inferior.h".
4588
4589         * gnu-nat.c (gnu_nat_target::detach): Instead of
4590         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4591         * gnu-nat.h: #include "inf-child.h".
4592         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4593         'i386_gnu_nat_target::fetch_registers'.
4594         (gnu_store_registers): Rename/move to
4595         'i386_gnu_nat_target::store_registers'.
4596
4597         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4598         * gnu-nat.h (mach_thread_info): New function.
4599         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4600
4601         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4602
4603 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4604
4605         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4606
4607 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4608
4609         * windows-nat.c (windows_add_thread): Add new parameter
4610         "main_thread_p" with default value set to false.  Update
4611         function documentation as well as all callers.
4612         (windows_delete_thread): Likewise.
4613         (fake_create_process): Update call to windows_add_thread.
4614         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4615         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4616         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4617         call to windows_delete_thread.
4618
4619 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4620
4621         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4622
4623 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4624
4625         * symfile.c (find_separate_debug_file): Use canonical path of
4626         sysroot with child_path instead of gdb_sysroot if it is valid.
4627
4628 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4629
4630         * symfile.c (find_separate_debug_file): Use child_path to
4631         determine if an object file is under a sysroot.
4632
4633 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4634
4635         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4636         unittests/child-path-selftests.c.
4637         * common/pathstuff.c (child_path): New function.
4638         * common/pathstuff.h (child_path): New prototype.
4639         * unittests/child-path-selftests.c: New file.
4640
4641 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4642
4643         * symfile.c (find_separate_debug_file): Look for separate debug
4644         files in debug directories under the sysroot.
4645
4646 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4647
4648         * symtab.h (struct minimal_symbol data_p): New const method.
4649         (struct minimal_symbol text_p): Likewise.
4650         * symtab.c (output_source_filename): Use file name style
4651         to print file name.
4652         (print_symbol_info): Likewise.
4653         (print_msymbol_info): Use address style to print addresses.
4654         Use function name style to print executable text symbols.
4655         (expand_symtab_containing_pc): Use data_p.
4656         (find_pc_sect_compunit_symtab): Likewise.
4657
4658 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4659
4660         * breakpoint.c (describe_other_breakpoints): Use address style
4661         to print addresses.
4662         (say_where): Likewise.
4663
4664 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4665
4666         * ada-typeprint.c (print_func_type): Print function name
4667         style to print function name.
4668         * c-typeprint.c (c_print_type_1): Likewise.
4669
4670 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4671
4672         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4673         for execve.
4674
4675 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4676
4677         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4678         type_stack.
4679
4680 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4681
4682         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4683         TYPE_CODE_REF types.
4684
4685 2019-02-08  Jim Wilson  <jimw@sifive.com>
4686
4687         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4688         (riscv_linux_fregset): New.
4689         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4690
4691 2019-02-07  Tom Tromey  <tom@tromey.com>
4692
4693         * thread.c (thread_cancel_execution_command): Update.
4694         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4695         methods.
4696         (struct thread_fsm_ops): Remove.
4697         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4698         (thread_fsm_should_stop, thread_fsm_return_value)
4699         (thread_fsm_set_finished, thread_fsm_finished_p)
4700         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4701         Don't declare.
4702         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4703         * infrun.c (clear_proceed_status_thread)
4704         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4705         (print_stop_event): Update.
4706         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4707         Add constructor.
4708         (step_command_fsm_ops): Remove.
4709         (new_step_command_fsm): Remove.
4710         (step_1): Update.
4711         (step_command_fsm::should_stop): Rename from
4712         step_command_fsm_should_stop.
4713         (step_command_fsm::clean_up): Rename from
4714         step_command_fsm_clean_up.
4715         (step_command_fsm::do_async_reply_reason): Rename from
4716         step_command_fsm_async_reply_reason.
4717         (struct until_next_fsm): Inherit from thread_fsm.  Add
4718         constructor.
4719         (until_next_fsm_ops): Remove.
4720         (new_until_next_fsm): Remove.
4721         (until_next_fsm::should_stop): Rename from
4722         until_next_fsm_should_stop.
4723         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4724         (until_next_fsm::do_async_reply_reason): Rename from
4725         until_next_fsm_async_reply_reason.
4726         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4727         constructor.  Change type of breakpoint.
4728         (finish_command_fsm_ops): Remove.
4729         (new_finish_command_fsm): Remove.
4730         (finish_command_fsm::should_stop): Rename from
4731         finish_command_fsm_should_stop.
4732         (finish_command_fsm::clean_up): Rename from
4733         finish_command_fsm_clean_up.
4734         (finish_command_fsm::return_value): Rename from
4735         finish_command_fsm_return_value.
4736         (finish_command_fsm::do_async_reply_reason): Rename from
4737         finish_command_fsm_async_reply_reason.
4738         (finish_command): Update.
4739         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4740         Add constructor.
4741         (call_thread_fsm_ops): Remove.
4742         (call_thread_fsm::call_thread_fsm): Rename from
4743         new_call_thread_fsm.
4744         (call_thread_fsm::should_stop): Rename from
4745         call_thread_fsm_should_stop.
4746         (call_thread_fsm::should_notify_stop): Rename from
4747         call_thread_fsm_should_notify_stop.
4748         (run_inferior_call, call_function_by_hand_dummy): Update.
4749         * cli/cli-interp.c (should_print_stop_to_console): Update.
4750         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4751         Add constructor.  Change type of location_breakpoint,
4752         caller_breakpoint.
4753         (until_break_fsm_ops): Remove.
4754         (new_until_break_fsm): Remove.
4755         (until_break_fsm::should_stop): Rename from
4756         until_break_fsm_should_stop.
4757         (until_break_fsm::clean_up): Rename from
4758         until_break_fsm_clean_up.
4759         (until_break_fsm::do_async_reply_reason): Rename from
4760         until_break_fsm_async_reply_reason.
4761         (until_break_command): Update.
4762         * thread-fsm.c: Remove.
4763         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4764
4765 2019-02-07  Tom Tromey  <tom@tromey.com>
4766
4767         * yy-remap.h: Add include guard.
4768         * xtensa-tdep.h: Add include guard.
4769         * xcoffread.h: Rename include guard.
4770         * varobj-iter.h: Add include guard.
4771         * tui/tui.h: Rename include guard.
4772         * tui/tui-winsource.h: Rename include guard.
4773         * tui/tui-wingeneral.h: Rename include guard.
4774         * tui/tui-windata.h: Rename include guard.
4775         * tui/tui-win.h: Rename include guard.
4776         * tui/tui-stack.h: Rename include guard.
4777         * tui/tui-source.h: Rename include guard.
4778         * tui/tui-regs.h: Rename include guard.
4779         * tui/tui-out.h: Rename include guard.
4780         * tui/tui-layout.h: Rename include guard.
4781         * tui/tui-io.h: Rename include guard.
4782         * tui/tui-hooks.h: Rename include guard.
4783         * tui/tui-file.h: Rename include guard.
4784         * tui/tui-disasm.h: Rename include guard.
4785         * tui/tui-data.h: Rename include guard.
4786         * tui/tui-command.h: Rename include guard.
4787         * tic6x-tdep.h: Add include guard.
4788         * target/waitstatus.h: Rename include guard.
4789         * target/wait.h: Rename include guard.
4790         * target/target.h: Rename include guard.
4791         * target/resume.h: Rename include guard.
4792         * target-float.h: Rename include guard.
4793         * stabsread.h: Add include guard.
4794         * rs6000-tdep.h: Add include guard.
4795         * riscv-fbsd-tdep.h: Add include guard.
4796         * regformats/regdef.h: Rename include guard.
4797         * record.h: Rename include guard.
4798         * python/python.h: Rename include guard.
4799         * python/python-internal.h: Rename include guard.
4800         * python/py-stopevent.h: Rename include guard.
4801         * python/py-ref.h: Rename include guard.
4802         * python/py-record.h: Rename include guard.
4803         * python/py-record-full.h: Rename include guard.
4804         * python/py-record-btrace.h: Rename include guard.
4805         * python/py-instruction.h: Rename include guard.
4806         * python/py-events.h: Rename include guard.
4807         * python/py-event.h: Rename include guard.
4808         * procfs.h: Add include guard.
4809         * proc-utils.h: Add include guard.
4810         * p-lang.h: Add include guard.
4811         * or1k-tdep.h: Rename include guard.
4812         * observable.h: Rename include guard.
4813         * nto-tdep.h: Rename include guard.
4814         * nat/x86-linux.h: Rename include guard.
4815         * nat/x86-linux-dregs.h: Rename include guard.
4816         * nat/x86-gcc-cpuid.h: Add include guard.
4817         * nat/x86-dregs.h: Rename include guard.
4818         * nat/x86-cpuid.h: Rename include guard.
4819         * nat/ppc-linux.h: Rename include guard.
4820         * nat/mips-linux-watch.h: Rename include guard.
4821         * nat/linux-waitpid.h: Rename include guard.
4822         * nat/linux-ptrace.h: Rename include guard.
4823         * nat/linux-procfs.h: Rename include guard.
4824         * nat/linux-osdata.h: Rename include guard.
4825         * nat/linux-nat.h: Rename include guard.
4826         * nat/linux-namespaces.h: Rename include guard.
4827         * nat/linux-btrace.h: Rename include guard.
4828         * nat/glibc_thread_db.h: Rename include guard.
4829         * nat/gdb_thread_db.h: Rename include guard.
4830         * nat/gdb_ptrace.h: Rename include guard.
4831         * nat/fork-inferior.h: Rename include guard.
4832         * nat/amd64-linux-siginfo.h: Rename include guard.
4833         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4834         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4835         * nat/aarch64-linux.h: Rename include guard.
4836         * nat/aarch64-linux-hw-point.h: Rename include guard.
4837         * mn10300-tdep.h: Add include guard.
4838         * mips-linux-tdep.h: Add include guard.
4839         * mi/mi-parse.h: Rename include guard.
4840         * mi/mi-out.h: Rename include guard.
4841         * mi/mi-main.h: Rename include guard.
4842         * mi/mi-interp.h: Rename include guard.
4843         * mi/mi-getopt.h: Rename include guard.
4844         * mi/mi-console.h: Rename include guard.
4845         * mi/mi-common.h: Rename include guard.
4846         * mi/mi-cmds.h: Rename include guard.
4847         * mi/mi-cmd-break.h: Rename include guard.
4848         * m2-lang.h: Add include guard.
4849         * location.h: Rename include guard.
4850         * linux-record.h: Rename include guard.
4851         * linux-nat.h: Add include guard.
4852         * linux-fork.h: Add include guard.
4853         * i386-darwin-tdep.h: Rename include guard.
4854         * hppa-linux-offsets.h: Add include guard.
4855         * guile/guile.h: Rename include guard.
4856         * guile/guile-internal.h: Rename include guard.
4857         * gnu-nat.h: Rename include guard.
4858         * gdb-stabs.h: Rename include guard.
4859         * frv-tdep.h: Add include guard.
4860         * f-lang.h: Add include guard.
4861         * event-loop.h: Add include guard.
4862         * darwin-nat.h: Rename include guard.
4863         * cp-abi.h: Rename include guard.
4864         * config/sparc/nm-sol2.h: Rename include guard.
4865         * config/nm-nto.h: Rename include guard.
4866         * config/nm-linux.h: Add include guard.
4867         * config/i386/nm-i386gnu.h: Rename include guard.
4868         * config/djgpp/nl_types.h: Rename include guard.
4869         * config/djgpp/langinfo.h: Rename include guard.
4870         * compile/gcc-cp-plugin.h: Add include guard.
4871         * compile/gcc-c-plugin.h: Add include guard.
4872         * compile/compile.h: Rename include guard.
4873         * compile/compile-object-run.h: Rename include guard.
4874         * compile/compile-object-load.h: Rename include guard.
4875         * compile/compile-internal.h: Rename include guard.
4876         * compile/compile-cplus.h: Rename include guard.
4877         * compile/compile-c.h: Rename include guard.
4878         * common/xml-utils.h: Rename include guard.
4879         * common/x86-xstate.h: Rename include guard.
4880         * common/version.h: Rename include guard.
4881         * common/vec.h: Rename include guard.
4882         * common/tdesc.h: Rename include guard.
4883         * common/selftest.h: Rename include guard.
4884         * common/scoped_restore.h: Rename include guard.
4885         * common/scoped_mmap.h: Rename include guard.
4886         * common/scoped_fd.h: Rename include guard.
4887         * common/safe-iterator.h: Rename include guard.
4888         * common/run-time-clock.h: Rename include guard.
4889         * common/refcounted-object.h: Rename include guard.
4890         * common/queue.h: Rename include guard.
4891         * common/ptid.h: Rename include guard.
4892         * common/print-utils.h: Rename include guard.
4893         * common/preprocessor.h: Rename include guard.
4894         * common/pathstuff.h: Rename include guard.
4895         * common/observable.h: Rename include guard.
4896         * common/netstuff.h: Rename include guard.
4897         * common/job-control.h: Rename include guard.
4898         * common/host-defs.h: Rename include guard.
4899         * common/gdb_wait.h: Rename include guard.
4900         * common/gdb_vecs.h: Rename include guard.
4901         * common/gdb_unlinker.h: Rename include guard.
4902         * common/gdb_unique_ptr.h: Rename include guard.
4903         * common/gdb_tilde_expand.h: Rename include guard.
4904         * common/gdb_sys_time.h: Rename include guard.
4905         * common/gdb_string_view.h: Rename include guard.
4906         * common/gdb_splay_tree.h: Rename include guard.
4907         * common/gdb_setjmp.h: Rename include guard.
4908         * common/gdb_ref_ptr.h: Rename include guard.
4909         * common/gdb_optional.h: Rename include guard.
4910         * common/gdb_locale.h: Rename include guard.
4911         * common/gdb_assert.h: Rename include guard.
4912         * common/filtered-iterator.h: Rename include guard.
4913         * common/filestuff.h: Rename include guard.
4914         * common/fileio.h: Rename include guard.
4915         * common/environ.h: Rename include guard.
4916         * common/common-utils.h: Rename include guard.
4917         * common/common-types.h: Rename include guard.
4918         * common/common-regcache.h: Rename include guard.
4919         * common/common-inferior.h: Rename include guard.
4920         * common/common-gdbthread.h: Rename include guard.
4921         * common/common-exceptions.h: Rename include guard.
4922         * common/common-defs.h: Rename include guard.
4923         * common/common-debug.h: Rename include guard.
4924         * common/cleanups.h: Rename include guard.
4925         * common/buffer.h: Rename include guard.
4926         * common/btrace-common.h: Rename include guard.
4927         * common/break-common.h: Rename include guard.
4928         * cli/cli-utils.h: Rename include guard.
4929         * cli/cli-style.h: Rename include guard.
4930         * cli/cli-setshow.h: Rename include guard.
4931         * cli/cli-script.h: Rename include guard.
4932         * cli/cli-interp.h: Rename include guard.
4933         * cli/cli-decode.h: Rename include guard.
4934         * cli/cli-cmds.h: Rename include guard.
4935         * charset-list.h: Add include guard.
4936         * buildsym-legacy.h: Rename include guard.
4937         * bfin-tdep.h: Add include guard.
4938         * ax.h: Rename include guard.
4939         * arm-linux-tdep.h: Add include guard.
4940         * arm-fbsd-tdep.h: Add include guard.
4941         * arch/xtensa.h: Rename include guard.
4942         * arch/tic6x.h: Add include guard.
4943         * arch/i386.h: Add include guard.
4944         * arch/arm.h: Rename include guard.
4945         * arch/arm-linux.h: Rename include guard.
4946         * arch/arm-get-next-pcs.h: Rename include guard.
4947         * arch/amd64.h: Add include guard.
4948         * arch/aarch64-insn.h: Rename include guard.
4949         * arch-utils.h: Rename include guard.
4950         * annotate.h: Add include guard.
4951         * amd64-darwin-tdep.h: Rename include guard.
4952         * aarch64-linux-tdep.h: Add include guard.
4953         * aarch64-fbsd-tdep.h: Add include guard.
4954         * aarch32-linux-nat.h: Add include guard.
4955
4956 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4957
4958         * macrotab.c (macro_define_internal): New function that
4959         factorizes macro_define_object_internal and macro_define_function
4960         code.
4961         (macro_define_object_internal): Use macro_define_internal.
4962         (macro_define_function): Likewise.
4963
4964 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4965
4966         * macrocmd.c (extract_identifier): Return
4967         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4968         callers.
4969
4970 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4971
4972         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4973
4974 2019-02-05  Tom Tromey  <tom@tromey.com>
4975
4976         * target.c (target_stack::unpush): Move assertion earlier.
4977
4978 2019-01-30  Tom Tromey  <tom@tromey.com>
4979
4980         PR python/23615:
4981         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4982         (gdbpy_parse_and_eval): Likewise.
4983         * python/python-internal.h (gdbpy_allow_threads): New class.
4984
4985 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4986
4987         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4988         (aarch64_fbsd_fpregmap): Move earlier.
4989         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4990         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4991         instead of individual calls to trad_frame_set_reg_addr.
4992         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4993         earlier.
4994         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4995         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4996         instead of individual calls to trad_frame_set_reg_addr.
4997
4998 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4999
5000         * CONTRIBUTE: Replace contribution list with wiki link.
5001
5002 2019-01-25  Tom Tromey  <tom@tromey.com>
5003
5004         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5005
5006 2019-01-25  Tom Tromey  <tom@tromey.com>
5007
5008         * xtensa-linux-nat.c: Fix common/ includes.
5009         * xml-support.h: Fix common/ includes.
5010         * xml-support.c: Fix common/ includes.
5011         * x86-linux-nat.c: Fix common/ includes.
5012         * windows-nat.c: Fix common/ includes.
5013         * varobj.h: Fix common/ includes.
5014         * varobj.c: Fix common/ includes.
5015         * value.c: Fix common/ includes.
5016         * valops.c: Fix common/ includes.
5017         * utils.c: Fix common/ includes.
5018         * unittests/xml-utils-selftests.c: Fix common/ includes.
5019         * unittests/utils-selftests.c: Fix common/ includes.
5020         * unittests/unpack-selftests.c: Fix common/ includes.
5021         * unittests/tracepoint-selftests.c: Fix common/ includes.
5022         * unittests/style-selftests.c: Fix common/ includes.
5023         * unittests/string_view-selftests.c: Fix common/ includes.
5024         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5025         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5026         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5027         * unittests/rsp-low-selftests.c: Fix common/ includes.
5028         * unittests/parse-connection-spec-selftests.c: Fix common/
5029         includes.
5030         * unittests/optional-selftests.c: Fix common/ includes.
5031         * unittests/offset-type-selftests.c: Fix common/ includes.
5032         * unittests/observable-selftests.c: Fix common/ includes.
5033         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5034         * unittests/memrange-selftests.c: Fix common/ includes.
5035         * unittests/memory-map-selftests.c: Fix common/ includes.
5036         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5037         * unittests/function-view-selftests.c: Fix common/ includes.
5038         * unittests/environ-selftests.c: Fix common/ includes.
5039         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5040         * unittests/common-utils-selftests.c: Fix common/ includes.
5041         * unittests/cli-utils-selftests.c: Fix common/ includes.
5042         * unittests/array-view-selftests.c: Fix common/ includes.
5043         * ui-file.c: Fix common/ includes.
5044         * tui/tui-io.c: Fix common/ includes.
5045         * tracepoint.h: Fix common/ includes.
5046         * tracepoint.c: Fix common/ includes.
5047         * tracefile-tfile.c: Fix common/ includes.
5048         * top.h: Fix common/ includes.
5049         * top.c: Fix common/ includes.
5050         * thread.c: Fix common/ includes.
5051         * target/waitstatus.h: Fix common/ includes.
5052         * target/waitstatus.c: Fix common/ includes.
5053         * target.h: Fix common/ includes.
5054         * target.c: Fix common/ includes.
5055         * target-memory.c: Fix common/ includes.
5056         * target-descriptions.c: Fix common/ includes.
5057         * symtab.h: Fix common/ includes.
5058         * symfile.c: Fix common/ includes.
5059         * stap-probe.c: Fix common/ includes.
5060         * spu-linux-nat.c: Fix common/ includes.
5061         * sparc-nat.c: Fix common/ includes.
5062         * source.c: Fix common/ includes.
5063         * solib.c: Fix common/ includes.
5064         * solib-target.c: Fix common/ includes.
5065         * ser-unix.c: Fix common/ includes.
5066         * ser-tcp.c: Fix common/ includes.
5067         * ser-pipe.c: Fix common/ includes.
5068         * ser-base.c: Fix common/ includes.
5069         * selftest-arch.c: Fix common/ includes.
5070         * s12z-tdep.c: Fix common/ includes.
5071         * rust-exp.y: Fix common/ includes.
5072         * rs6000-aix-tdep.c: Fix common/ includes.
5073         * riscv-tdep.c: Fix common/ includes.
5074         * remote.c: Fix common/ includes.
5075         * remote-notif.h: Fix common/ includes.
5076         * remote-fileio.h: Fix common/ includes.
5077         * remote-fileio.c: Fix common/ includes.
5078         * regcache.h: Fix common/ includes.
5079         * regcache.c: Fix common/ includes.
5080         * record-btrace.c: Fix common/ includes.
5081         * python/python.c: Fix common/ includes.
5082         * python/py-type.c: Fix common/ includes.
5083         * python/py-inferior.c: Fix common/ includes.
5084         * progspace.h: Fix common/ includes.
5085         * producer.c: Fix common/ includes.
5086         * procfs.c: Fix common/ includes.
5087         * proc-api.c: Fix common/ includes.
5088         * printcmd.c: Fix common/ includes.
5089         * ppc-linux-nat.c: Fix common/ includes.
5090         * parser-defs.h: Fix common/ includes.
5091         * osdata.c: Fix common/ includes.
5092         * obsd-nat.c: Fix common/ includes.
5093         * nat/x86-linux.c: Fix common/ includes.
5094         * nat/x86-linux-dregs.c: Fix common/ includes.
5095         * nat/x86-dregs.h: Fix common/ includes.
5096         * nat/x86-dregs.c: Fix common/ includes.
5097         * nat/ppc-linux.c: Fix common/ includes.
5098         * nat/mips-linux-watch.h: Fix common/ includes.
5099         * nat/mips-linux-watch.c: Fix common/ includes.
5100         * nat/linux-waitpid.c: Fix common/ includes.
5101         * nat/linux-ptrace.h: Fix common/ includes.
5102         * nat/linux-ptrace.c: Fix common/ includes.
5103         * nat/linux-procfs.c: Fix common/ includes.
5104         * nat/linux-personality.c: Fix common/ includes.
5105         * nat/linux-osdata.c: Fix common/ includes.
5106         * nat/linux-namespaces.c: Fix common/ includes.
5107         * nat/linux-btrace.h: Fix common/ includes.
5108         * nat/linux-btrace.c: Fix common/ includes.
5109         * nat/fork-inferior.c: Fix common/ includes.
5110         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5111         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5112         * nat/aarch64-linux.c: Fix common/ includes.
5113         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5114         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5115         * namespace.h: Fix common/ includes.
5116         * mips-linux-tdep.c: Fix common/ includes.
5117         * minsyms.c: Fix common/ includes.
5118         * mi/mi-parse.h: Fix common/ includes.
5119         * mi/mi-main.c: Fix common/ includes.
5120         * mi/mi-cmd-env.c: Fix common/ includes.
5121         * memrange.h: Fix common/ includes.
5122         * memattr.c: Fix common/ includes.
5123         * maint.h: Fix common/ includes.
5124         * maint.c: Fix common/ includes.
5125         * main.c: Fix common/ includes.
5126         * machoread.c: Fix common/ includes.
5127         * location.c: Fix common/ includes.
5128         * linux-thread-db.c: Fix common/ includes.
5129         * linux-nat.c: Fix common/ includes.
5130         * linux-fork.c: Fix common/ includes.
5131         * inline-frame.c: Fix common/ includes.
5132         * infrun.c: Fix common/ includes.
5133         * inflow.c: Fix common/ includes.
5134         * inferior.h: Fix common/ includes.
5135         * inferior.c: Fix common/ includes.
5136         * infcmd.c: Fix common/ includes.
5137         * inf-ptrace.c: Fix common/ includes.
5138         * inf-child.c: Fix common/ includes.
5139         * ia64-linux-nat.c: Fix common/ includes.
5140         * i387-tdep.c: Fix common/ includes.
5141         * i386-tdep.c: Fix common/ includes.
5142         * i386-linux-tdep.c: Fix common/ includes.
5143         * i386-linux-nat.c: Fix common/ includes.
5144         * i386-go32-tdep.c: Fix common/ includes.
5145         * i386-fbsd-tdep.c: Fix common/ includes.
5146         * i386-fbsd-nat.c: Fix common/ includes.
5147         * guile/scm-type.c: Fix common/ includes.
5148         * guile/guile.c: Fix common/ includes.
5149         * go32-nat.c: Fix common/ includes.
5150         * gnu-nat.c: Fix common/ includes.
5151         * gdbthread.h: Fix common/ includes.
5152         * gdbarch-selftests.c: Fix common/ includes.
5153         * gdb_usleep.c: Fix common/ includes.
5154         * gdb_select.h: Fix common/ includes.
5155         * gdb_bfd.c: Fix common/ includes.
5156         * gcore.c: Fix common/ includes.
5157         * fork-child.c: Fix common/ includes.
5158         * findvar.c: Fix common/ includes.
5159         * fbsd-nat.c: Fix common/ includes.
5160         * event-top.c: Fix common/ includes.
5161         * event-loop.c: Fix common/ includes.
5162         * dwarf2read.c: Fix common/ includes.
5163         * dwarf2loc.c: Fix common/ includes.
5164         * dwarf2-frame.c: Fix common/ includes.
5165         * dwarf-index-cache.c: Fix common/ includes.
5166         * dtrace-probe.c: Fix common/ includes.
5167         * disasm-selftests.c: Fix common/ includes.
5168         * defs.h: Fix common/ includes.
5169         * csky-tdep.c: Fix common/ includes.
5170         * cp-valprint.c: Fix common/ includes.
5171         * cp-support.h: Fix common/ includes.
5172         * cp-support.c: Fix common/ includes.
5173         * corelow.c: Fix common/ includes.
5174         * completer.h: Fix common/ includes.
5175         * completer.c: Fix common/ includes.
5176         * compile/compile.c: Fix common/ includes.
5177         * compile/compile-loc2c.c: Fix common/ includes.
5178         * compile/compile-cplus-types.c: Fix common/ includes.
5179         * compile/compile-cplus-symbols.c: Fix common/ includes.
5180         * command.h: Fix common/ includes.
5181         * cli/cli-dump.c: Fix common/ includes.
5182         * cli/cli-cmds.c: Fix common/ includes.
5183         * charset.c: Fix common/ includes.
5184         * build-id.c: Fix common/ includes.
5185         * btrace.h: Fix common/ includes.
5186         * btrace.c: Fix common/ includes.
5187         * breakpoint.h: Fix common/ includes.
5188         * breakpoint.c: Fix common/ includes.
5189         * ax.h:
5190         (enum agent_op): Fix common/ includes.
5191         * ax-general.c (struct aop_map): Fix common/ includes.
5192         * ax-gdb.c: Fix common/ includes.
5193         * auxv.c: Fix common/ includes.
5194         * auto-load.c: Fix common/ includes.
5195         * arm-tdep.c: Fix common/ includes.
5196         * arch/riscv.c: Fix common/ includes.
5197         * arch/ppc-linux-common.c: Fix common/ includes.
5198         * arch/i386.c: Fix common/ includes.
5199         * arch/arm.c: Fix common/ includes.
5200         * arch/arm-linux.c: Fix common/ includes.
5201         * arch/arm-get-next-pcs.c: Fix common/ includes.
5202         * arch/amd64.c: Fix common/ includes.
5203         * arch/aarch64.c: Fix common/ includes.
5204         * arch/aarch64-insn.c: Fix common/ includes.
5205         * arch-utils.c: Fix common/ includes.
5206         * amd64-windows-tdep.c: Fix common/ includes.
5207         * amd64-tdep.c: Fix common/ includes.
5208         * amd64-sol2-tdep.c: Fix common/ includes.
5209         * amd64-obsd-tdep.c: Fix common/ includes.
5210         * amd64-nbsd-tdep.c: Fix common/ includes.
5211         * amd64-linux-tdep.c: Fix common/ includes.
5212         * amd64-linux-nat.c: Fix common/ includes.
5213         * amd64-fbsd-tdep.c: Fix common/ includes.
5214         * amd64-fbsd-nat.c: Fix common/ includes.
5215         * amd64-dicos-tdep.c: Fix common/ includes.
5216         * amd64-darwin-tdep.c: Fix common/ includes.
5217         * agent.c: Fix common/ includes.
5218         * ada-lang.h: Fix common/ includes.
5219         * ada-lang.c: Fix common/ includes.
5220         * aarch64-tdep.c: Fix common/ includes.
5221
5222 2019-01-25  Tom Tromey  <tom@tromey.com>
5223
5224         * common/create-version.sh: Use common/version.h.
5225
5226 2019-01-24  Pedro Alves  <palves@redhat.com>
5227
5228         * infrun.c (signal_stop, signal_print, signal_program)
5229         (signal_catch, signal_pass): Now arrays instead of pointers.
5230         (update_signals_program_target, do_target_resume)
5231         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5232         * linux-nat.c (linux_nat_target::pass_signals)
5233         (linux_nat_target::create_inferior, linux_nat_target::attach):
5234         Adjust.
5235         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5236         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5237         * procfs.c (procfs_target::pass_signals): Adjust.
5238         * record-full.c (record_full_target::resume): Adjust.
5239         * remote.c (remote_target::pass_signals)
5240         (remote_target::program_signals): Adjust.
5241         * target-debug.h (target_debug_print_signals): Now takes a
5242         gdb::array_view as parameter.  Adjust.
5243         * target.h (target_ops) <pass_signals, program_signals>: Replace
5244         pointer and length parameters with gdb::array_view.
5245         (target_pass_signals, target_program_signals): Likewise.
5246         * target-delegates.c: Regenerate.
5247
5248 2019-01-24  Pedro Alves  <palves@redhat.com>
5249
5250         * common/forward-scope-exit.h
5251         (forward_scope_exit::forward_scope_exit): Pass arguments to
5252         m_bind_function directly, instead of creating a std::bind and
5253         copying that.
5254
5255 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5256
5257         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5258         for static members.
5259         (pass_in_v_vfp_candidate): Likewise.
5260
5261 2019-01-23  Tom Tromey  <tom@tromey.com>
5262             Pedro Alves  <palves@redhat.com>
5263
5264         * regcache.c (class regcache_invalidator): Remove.
5265         (regcache::raw_write): Use make_scope_exit.
5266
5267 2019-01-23  Tom Tromey  <tom@tromey.com>
5268
5269         * ui-out.h (class ui_out_emit_type): Update comment.
5270
5271 2019-01-23  Tom Tromey  <tom@tromey.com>
5272
5273         * infrun.c (fetch_inferior_event): Update comment.
5274
5275 2019-01-23  Tom Tromey  <tom@tromey.com>
5276             Pedro Alves  <palves@redhat.com>
5277
5278         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5279         parameter.
5280         (fetch_inferior_event): Use SCOPE_EXIT.
5281
5282
5283 2019-01-23  Tom Tromey  <tom@tromey.com>
5284             Pedro Alves  <palves@redhat.com>
5285
5286         * infrun.c (disable_thread_events): Delete.
5287         (stop_all_threads): Use SCOPE_EXIT.
5288
5289 2019-01-23  Tom Tromey  <tom@tromey.com>
5290             Pedro Alves  <palves@redhat.com>
5291
5292         * symfile.c: Include forward-scope-exit.h.
5293         (clear_symtab_users_cleanup): Replace forward declaration with
5294         a FORWARD_SCOPE_EXIT.
5295         (syms_from_objfile_1): Use the forward_scope_exit and
5296         gdb::optional instead of cleanup_function.
5297         (reread_symbols): Use the forward_scope_exit instead of
5298         cleanup_function.
5299         (clear_symtab_users_cleanup): Remove function.
5300
5301 2019-01-23  Tom Tromey  <tom@tromey.com>
5302             Pedro Alves  <palves@redhat.com>
5303
5304         * linux-nat.c: Include scope-exit.h.
5305         (cleanup_target_stop): Remove.
5306         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5307         SCOPE_EXIT.
5308
5309 2019-01-23  Tom Tromey  <tom@tromey.com>
5310             Pedro Alves  <palves@redhat.com>
5311
5312         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5313         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5314
5315 2019-01-23  Tom Tromey  <tom@tromey.com>
5316             Andrew Burgess  <andrew.burgess@embecosm.com>
5317             Pedro Alves  <palves@redhat.com>
5318
5319         * infrun.c (fetch_inferior_event): Use scope_exit.
5320         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5321         * top.c (execute_command): Use scope_exit.
5322         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5323         * utils.c (do_bpstat_clear_actions_cleanup)
5324         (make_bpstat_clear_actions_cleanup): Remove.
5325
5326 2019-01-23  Tom Tromey  <tom@tromey.com>
5327             Pedro Alves  <palves@redhat.com>
5328
5329         * infrun.c: Include "common/scope-exit.h"
5330         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5331         (wait_for_inferior): Use SCOPE_EXIT.
5332         (fetch_inferior_event): Use scope_exit.
5333
5334 2019-01-23  Tom Tromey  <tom@tromey.com>
5335             Pedro Alves  <palves@redhat.com>
5336
5337         * breakpoint.c (create_breakpoint): Remove cleanup.
5338
5339 2019-01-23  Tom Tromey  <tom@tromey.com>
5340             Andrew Burgess  <andrew.burgess@embecosm.com>
5341             Pedro Alves  <palves@redhat.com>
5342
5343 2019-01-23  Pedro Alves  <palves@redhat.com>
5344
5345         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5346
5347 2019-01-23  Pedro Alves  <palves@redhat.com>
5348             Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         * gdbthread.h: Include "common/forward-scope-exit.h".
5351         (scoped_finish_thread_state): Redefine custom class in terms of
5352         forward_scope_exit.
5353
5354 2019-01-23  Pedro Alves  <palves@redhat.com>
5355             Andrew Burgess  <andrew.burgess@embecosm.com>
5356
5357         * common/forward-scope-exit.h: New file.
5358
5359 2019-01-23  Pedro Alves  <palves@redhat.com>
5360             Andrew Burgess  <andrew.burgess@embecosm.com>
5361             Tom Tromey  <tom@tromey.com>
5362
5363         * common/scope-exit.h: New file.
5364
5365 2019-01-23  Pedro Alves  <palves@redhat.com>
5366
5367         * common/preprocessor.h (ESC): Rename to ...
5368         (ESC_PARENS): ... this.
5369         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5370         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5371
5372 2019-01-23  Tom Tromey  <tom@tromey.com>
5373
5374         * language.h (class scoped_switch_to_sym_language_if_auto):
5375         Initialize m_lang in both cases.
5376
5377 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5378
5379         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5380         with XCNEW.
5381
5382 2019-01-22  Tom Tromey  <tom@tromey.com>
5383
5384         * corelow.c: Do not include sys/file.h.
5385
5386 2019-01-22  Tom Tromey  <tom@tromey.com>
5387
5388         * tui/tui-wingeneral.h: Include gdb_curses.h.
5389
5390 2019-01-22  Tom Tromey  <tom@tromey.com>
5391
5392         * source-cache.h (class source_cache) <get_source_lines,
5393         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5394
5395 2019-01-22  Tom Tromey  <tom@tromey.com>
5396
5397         * remote-fileio.h (struct remote_target): Declare.
5398
5399 2019-01-22  Tom Tromey  <tom@tromey.com>
5400
5401         * python/py-arch.c: Do not include py-ref.h.
5402         * python/py-bpevent.c: Do not include py-ref.h.
5403         * python/py-cmd.c: Do not include py-ref.h.
5404         * python/py-continueevent.c: Do not include py-ref.h.
5405         * python/py-event.h: Do not include py-ref.h.
5406         * python/py-evtregistry.c: Do not include py-ref.h.
5407         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5408         * python/py-frame.c: Do not include py-ref.h.
5409         * python/py-framefilter.c: Do not include py-ref.h.
5410         * python/py-function.c: Do not include py-ref.h.
5411         * python/py-infevents.c: Do not include py-ref.h.
5412         * python/py-linetable.c: Do not include py-ref.h.
5413         * python/py-objfile.c: Do not include py-ref.h.
5414         * python/py-param.c: Do not include py-ref.h.
5415         * python/py-prettyprint.c: Do not include py-ref.h.
5416         * python/py-progspace.c: Do not include py-ref.h.
5417         * python/py-symbol.c: Do not include py-ref.h.
5418         * python/py-symtab.c: Do not include py-ref.h.
5419         * python/py-type.c: Do not include py-ref.h.
5420         * python/py-unwind.c: Do not include py-ref.h.
5421         * python/py-utils.c: Do not include py-ref.h.
5422         * python/py-value.c: Do not include py-ref.h.
5423         * python/py-varobj.c: Do not include py-ref.h.
5424         * python/py-xmethods.c: Do not include py-ref.h.
5425         * python/python.c: Do not include py-ref.h.
5426         * varobj.c: Do not include py-ref.h.
5427
5428 2019-01-22  Tom Tromey  <tom@tromey.com>
5429
5430         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5431         keyword for bcache.
5432
5433 2019-01-22  Tom Tromey  <tom@tromey.com>
5434
5435         * compile/compile-cplus-types.c: Remove a comment by #include.
5436
5437 2019-01-22  Tom Tromey  <tom@tromey.com>
5438
5439         * compile/gcc-c-plugin.h: Include compile-internal.h.
5440
5441 2019-01-22  Tom Tromey  <tom@tromey.com>
5442
5443         * stabsread.c (EXTERN): Do not define.
5444         (symnum, next_symbol_text_func, processing_gcc_compilation)
5445         (within_function, global_sym_chain, global_stabs)
5446         (previous_stab_code, this_object_header_files)
5447         (n_this_object_header_files)
5448         (n_allocated_this_object_header_files): Define.
5449         * stabsread.h (EXTERN): Never define.  Use "extern".
5450
5451 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5452
5453         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5454         history_value.
5455
5456 2019-01-21  Tom Tromey  <tom@tromey.com>
5457
5458         * ui-out.c: Fix includes.
5459         * tui/tui-source.c: Fix includes.
5460         * target.c: Fix includes.
5461         * remote.c: Fix includes.
5462         * regcache.c: Fix includes.
5463         * python/py-block.c: Fix includes.
5464         * printcmd.c: Fix includes.
5465         * or1k-tdep.c: Fix includes.
5466         * mi/mi-main.c: Fix includes.
5467         * m32r-tdep.c: Fix includes.
5468         * csky-tdep.c: Fix includes.
5469         * compile/compile-cplus-types.c: Fix includes.
5470         * cli/cli-interp.c: Fix includes.
5471
5472 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5473
5474         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5475         for padding.
5476
5477 2019-01-16  Tom Tromey  <tom@tromey.com>
5478
5479         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5480         earlier.
5481         (struct objfile) <msymbols_range>: Move from top level.
5482         <msymbols>: New method.
5483         (class objfile_msymbols): Remove.
5484         * symtab.c (default_collect_symbol_completion_matches_break_on):
5485         Update.
5486         * symmisc.c (dump_msymbols): Update.
5487         * stabsread.c (scan_file_globals): Update.
5488         * objc-lang.c (info_selectors_command, info_classes_command)
5489         (find_methods): Update.
5490         * minsyms.c (find_solib_trampoline_target): Update.
5491         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5492         * coffread.c (coff_symfile_read): Update.
5493         * ada-lang.c (ada_lookup_simple_minsym)
5494         (ada_collect_symbol_completion_matches): Update.
5495
5496 2019-01-16  Tom Tromey  <tom@tromey.com>
5497
5498         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5499         type.  Remove no-argument constructor.
5500         <iterator::operator++>: Simplify.
5501         <begin>: Update.
5502         <end>: Use minimal_symbol_count.
5503
5504 2019-01-16  Tom Tromey  <tom@tromey.com>
5505
5506         * objfiles.h (struct objfile) <psymtabs>: New method.
5507         (class objfile_psymtabs): Remove.
5508         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5509         typedef.
5510         <range>: New method.
5511         (require_partial_symbols): Change return type.
5512         * psymtab.c (require_partial_symbols)
5513         (psym_expand_symtabs_matching): Update.
5514         * mdebugread.c (parse_partial_symbols): Update.
5515         * dbxread.c (dbx_end_psymtab): Update.
5516
5517 2019-01-15  Tom Tromey  <tom@tromey.com>
5518
5519         * symtab.c (lookup_objfile_from_block)
5520         (lookup_symbol_in_objfile_symtabs)
5521         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5522         (find_line_symtab, info_sources_command)
5523         (default_collect_symbol_completion_matches_break_on)
5524         (make_source_files_completion_list): Update.
5525         * symmisc.c (print_objfile_statistics, dump_objfile)
5526         (maintenance_print_symbols, maintenance_info_symtabs)
5527         (maintenance_check_symtabs, maintenance_info_line_tables):
5528         Update.
5529         * source.c (select_source_symtab)
5530         (forget_cached_source_info_for_objfile): Update.
5531         * objfiles.h (class objfile_compunits): Remove.
5532         (struct objfile) <compunits_range>: New typedef.
5533         (compunits): New method.
5534         * objfiles.c (objfile_relocate1): Update.
5535         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5536         * maint.c (count_symtabs_and_blocks): Update.
5537         * linespec.c (iterate_over_all_matching_symtabs): Update.
5538         * cp-support.c (add_symbol_overload_list_qualified): Update.
5539         * coffread.c (coff_symtab_read): Update.
5540         * ada-lang.c (add_nonlocal_symbols)
5541         (ada_collect_symbol_completion_matches)
5542         (ada_add_global_exceptions): Update.
5543
5544 2019-01-15  Tom Tromey  <tom@tromey.com>
5545
5546         * progspace.h (program_space) <objfiles_safe_range>: New
5547         typedef.
5548         <objfiles_safe>: New method.
5549         * objfiles.h (class all_objfiles_safe): Remove.
5550         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5551         * jit.c (jit_inferior_exit_hook): Update.
5552
5553 2019-01-17  Tom Tromey  <tom@tromey.com>
5554
5555         * progspace.h (program_space) <objfiles_range>: New typedef.
5556         <objfiles>: New method.
5557         <objfiles_head>: Rename from objfiles.
5558         (object_files): Update.
5559         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5560         * guile/scm-pretty-print.c
5561         (ppscm_find_pretty_printer_from_objfiles): Update.
5562         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5563         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5564         Update.
5565         * python/py-progspace.c (pspy_get_objfiles): Update.
5566         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5567         Update.
5568         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5569         (objfpy_lookup_objfile_by_build_id): Update.
5570         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5571         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5572         Update.
5573         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5574         (expand_symtab_containing_pc, lookup_objfile_from_block)
5575         (lookup_static_symbol, basic_lookup_transparent_type)
5576         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5577         (find_line_symtab, info_sources_command)
5578         (default_collect_symbol_completion_matches_break_on)
5579         (make_source_files_completion_list, find_main_name): Update.
5580         * symmisc.c (print_symbol_bcache_statistics)
5581         (print_objfile_statistics, maintenance_print_symbols)
5582         (maintenance_print_msymbols, maintenance_print_objfiles)
5583         (maintenance_info_symtabs, maintenance_check_symtabs)
5584         (maintenance_expand_symtabs, maintenance_info_line_tables):
5585         Update.
5586         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5587         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5588         (map_overlay_command, unmap_overlay_command)
5589         (simple_overlay_update, expand_symtabs_matching)
5590         (map_symbol_filenames): Update.
5591         * symfile-debug.c (set_debug_symfile): Update.
5592         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5593         Update.
5594         * source.c (select_source_symtab, forget_cached_source_info):
5595         Update.
5596         * solib.c (solib_read_symbols): Update.
5597         * solib-spu.c (append_ocl_sos): Update.
5598         * psymtab.c (maintenance_print_psymbols)
5599         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5600         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5601         * printcmd.c (info_symbol_command): Update.
5602         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5603         Update.
5604         * objfiles.h (class all_objfiles): Remove.
5605         * objfiles.c (have_partial_symbols, have_full_symbols)
5606         (have_minimal_symbols, qsort_cmp, update_section_map)
5607         (shared_objfile_contains_address_p)
5608         (default_iterate_over_objfiles_in_search_order): Update.
5609         * objc-lang.c (info_selectors_command, info_classes_command)
5610         (find_methods): Update.
5611         * minsyms.c (find_solib_trampoline_target): Update.
5612         * maint.c (maintenance_info_sections)
5613         (maintenance_translate_address, count_symtabs_and_blocks):
5614         Update.
5615         * main.c (captured_main_1): Update.
5616         * linux-thread-db.c (try_thread_db_load_from_pdir)
5617         (has_libpthread): Update.
5618         * linespec.c (iterate_over_all_matching_symtabs)
5619         (search_minsyms_for_name): Update.
5620         * jit.c (jit_find_objf_with_entry_addr): Update.
5621         * hppa-tdep.c (find_unwind_entry)
5622         (hppa_lookup_stub_minimal_symbol): Update.
5623         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5624         Update.
5625         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5626         (elf_gnu_ifunc_resolve_by_got): Update.
5627         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5628         * dwarf-index-write.c (save_gdb_index_command): Update.
5629         * cp-support.c (add_symbol_overload_list_qualified): Update.
5630         * breakpoint.c (create_overlay_event_breakpoint)
5631         (create_longjmp_master_breakpoint)
5632         (create_std_terminate_master_breakpoint)
5633         (create_exception_master_breakpoint): Update.
5634         * blockframe.c (find_pc_partial_function): Update.
5635         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5636         (ada_collect_symbol_completion_matches)
5637         (ada_add_global_exceptions): Update.
5638
5639 2019-01-17  Tom Tromey  <tom@tromey.com>
5640
5641         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5642         declare VEC.
5643         (solib_target_parse_libraries): Change return type.
5644         (library_list_start_segment, library_list_start_section)
5645         (library_list_end_library, library_list_start_library); Update.
5646         (solib_target_free_library_list): Remove.
5647         (solib_target_parse_libraries): Remove cleanup.  Change return
5648         type.
5649         (solib_target_current_sos): Update.
5650
5651 2019-01-17  Tom Tromey  <tromey@bapiya>
5652
5653         * valprint.c: Replace "the the" with "the".
5654         * symtab.c: Replace "the the" with "the".
5655         * solib.c: Replace "the the" with "the".
5656         * solib-dsbt.c: Replace "the the" with "the".
5657         * linespec.c: Replace "the the" with "the".
5658         * dwarf2loc.h: Replace "the the" with "the".
5659         * amd64-windows-tdep.c: Replace "the the" with "the".
5660         * aarch64-tdep.c: Replace "the the" with "the".
5661
5662 2019-01-16  Keith Seitz  <keiths@redhat.com>
5663
5664         PR gdb/23773
5665         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5666         <builder>: Rename to ..
5667         <m_builder>: ... this and make private.
5668         (dwarf2_cu::get_builder): New method.  Change all users of
5669         `builder' to use this method.
5670         (dwarf2_start_symtab): Move to ...
5671         (dwarf2_cu::start_symtab): ... here.  Update all callers
5672         (setup_type_unit_groups): Move to ...
5673         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5674         callers.
5675         (dwarf2_cu::reset_builder): New method.
5676         (process_full_compunit, process_full_type_unit): Use
5677         dwarf2_cu::reset_builder.
5678         (follow_die_offset): Record the ancestor CU if it is different
5679         from the followed DIE's CU.
5680         (follow_die_sig_1): Likewise.
5681
5682 2019-01-15  Tom Tromey  <tom@tromey.com>
5683
5684         * remote.c (class remote_state) <buf>: Now a char_vector.
5685         <buf_size>: Remove.
5686         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5687         parameter.
5688         (remote_target::getpkt_or_notif_sane_1)
5689         (remote_target::getpkt_sane)
5690         (remote_target::getpkt_or_notif_sane): Likewise.
5691         (class remote_target) <putpkt>: New overload.
5692         (remote_target::read_frame): Change type of "buf_p".  Remove
5693         sizeof_p parameter.
5694         (packet_ok): New overload.
5695         (packet_check_result): New overload.
5696         Update all uses.
5697
5698 2019-01-14  Tom Tromey  <tom@tromey.com>
5699
5700         * remote-notif.c (handle_notification, remote_notif_ack)
5701         (remote_notif_parse): Make "buf" const.
5702         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5703         const.
5704         (remote_notif_parse, remote_notif_ack, handle_notification):
5705         Likewise.
5706         * remote.c (remote_notif_stop_parse): Make "buf" const.
5707         (remote_target::remote_parse_stop_reply): Make "buf" const.
5708         (remote_notif_stop_ack): Make "buf" const.
5709
5710 2019-01-14  Tom Tromey  <tom@tromey.com>
5711
5712         * remote.c (remote_console_output): Make parameter const.
5713
5714 2019-01-14  Tom Tromey  <tom@tromey.com>
5715
5716         * target-debug.h (target_debug_print_signals): Constify.
5717         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5718         * procfs.c (procfs_target::pass_signals): Update.
5719         * linux-nat.c (linux_nat_target::pass_signals): Update.
5720         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5721         * target-delegates.c: Rebuild.
5722         * remote.c (remote_target::program_signals): Update.
5723         (remote_target::pass_signals): Update.
5724         * target.c (target_pass_signals): Constify argument.
5725         (target_program_signals): Likewise.
5726         * target.h (struct target_ops) <pass_signals, program_signals>:
5727         Constify argument.
5728         (target_pass_signals, target_program_signals): Constify argument.
5729
5730 2019-01-14  Tom Tromey  <tom@tromey.com>
5731
5732         PR tui/28819:
5733         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5734
5735 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5736
5737         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5738         field.
5739         * rs6000-tdep.c: Include reggroups.h.
5740         (IS_V_ALIAS_PSEUDOREG): Define.
5741         (rs6000_register_name): Return names for the "vX" aliases.
5742         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5743         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5744         aliases.  Call default_register_reggroup_p for all other
5745         pseudo-registers.
5746         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5747         New functions.
5748         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5749         Handle "vX" aliases.
5750         (v_alias_pseudo_register_collect): New function.
5751         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5752         (rs6000_gdbarch_init): Initialize "vX" aliases as
5753         pseudo-registers.  Restore registration of
5754         rs6000_pseudo_register_reggroup_p with
5755         set_tdesc_pseudo_register_reggroup_p.
5756
5757 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5758
5759         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5760         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5761         set_gdbarch_num_pseudo_regs.
5762
5763 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5764
5765         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5766         Remove arg prefixname, add do_set and do_show.
5767         Add member functions set_list and show_list.
5768         * cli/cli-style.c (class cli_style_option): Update accordingly.
5769         (style_set_list): Move to file scope.
5770         (style_show_list): Likewise.
5771         (set_style): Call help_list.
5772         (show_style): Call cmd_show_list.
5773         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5774         Update to use the new macro.
5775
5776 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5777
5778         * ada-lang.c (_initialize_ada_language): Expand the help text
5779         for the "catch exception" command.
5780
5781 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5782
5783         * symtab.c (matching_obj_sections): Initialize obj,
5784         declare it closer to its usage.
5785
5786 2019-01-10  Tom Tromey  <tom@tromey.com>
5787
5788         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5789         (basic_inf_threads_range): Remove.
5790         (inf_threads_range, inf_non_exited_threads_range)
5791         (safe_inf_threads_range): Use next_adapter.
5792
5793 2019-01-10  Keith Seitz  <keiths@redhat.com>
5794
5795         PR gdb/23712
5796         PR symtab/23010
5797         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5798         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5799
5800 2019-01-10  Keith Seitz  <keiths@redhat.com>
5801
5802         PR gdb/23712
5803         PR symtab/23010
5804         * dictionary.c (pending_to_vector): Remove.
5805         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5806         Remove _1 suffix, replacing functions of the same name.  Update
5807         all callers.
5808         (dict_create_hashed, dict_create_hashed_expandable)
5809         (dict_create_linear, dict_create_linear_expandable, dict_free)
5810         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5811         Make functions static.
5812
5813 2019-01-10  Keith Seitz  <keiths@redhat.com>
5814
5815         PR gdb/23712
5816         PR symtab/23010
5817         * dictionary.h (struct dictionary): Replace declaration with
5818         multidictionary.
5819         (dict_create_hashed, dict_create_hashed_expandable)
5820         (dict_create_linear, dict_create_linear_expandable)
5821         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5822         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5823         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5824         taking multidictionary argument.
5825         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5826         * block.h (struct block) <dict>: Change to multidictionary
5827         and rename `multidict'.
5828         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5829         symmisc.c: Update all dictionary references to multidictionary.
5830
5831 2019-01-10  Keith Seitz  <keiths@redhat.com>
5832
5833         PR gdb/23712
5834         PR symtab/23010
5835         * dictionary.c: Include unordered_map.
5836         (pending_to_vector): New function.
5837         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5838         Rewrite the non-"_1" functions to take vector instead
5839         of linked list.
5840         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5841         "new" _1 versions of the same name.
5842         (multidictionary): Define.
5843         (std::hash<enum language): New definition.
5844         (collate_pending_symbols_by_language, mdict_create_hashed)
5845         (mdict_create_hashed_expandable, mdict_create_linear)
5846         (mdict_create_linear_expandable, mdict_free)
5847         (find_language_dictionary, create_new_language_dictionary)
5848         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5849         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5850         (mdict_size, mdict_empty): New functions.
5851         * dictionary.h (mdict_iterator): Define.
5852
5853 2019-01-10  Pedro Alves  <palves@redhat.com>
5854
5855         * breakpoint.c (read_uploaded_action)
5856         (create_tracepoint_from_upload): Adjust to use
5857         gdb::unique_xmalloc_ptr.
5858         * ctf.c (ctf_write_uploaded_tp):
5859         (SET_ARRAY_FIELD): Use emplace_back.
5860         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5861         * tracefile-tfile.c (tfile_write_uploaded_tp):
5862         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5863         gdb::unique_xmalloc_ptr.
5864         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5865         at_string, cond_string, cmd_strings>: Replace char pointers
5866         with gdb::unique_xmalloc_ptr.
5867
5868 2019-01-10  Pedro Alves  <palves@redhat.com>
5869
5870         * solib-target.c (library_list_start_library): Don't xstrdup name.
5871
5872 2019-01-10  Pedro Alves  <palves@redhat.com>
5873
5874         * mdebugread.c (parse_partial_symbols): Use
5875         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5876
5877 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5878
5879         * linux-fork.c (scoped_switch_fork_info)
5880         <~scoped_switch_fork_info>: Fix incorrect variable name.
5881
5882 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * linux-fork.c (scoped_switch_fork_info)
5885         <scoped_switch_fork_info>: Make explicit.
5886         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5887
5888 2019-01-10  Tom Tromey  <tom@tromey.com>
5889
5890         * objfiles.h (objfile::reset_psymtabs): Update.
5891         * objfiles.c (objfile::objfile): Update.
5892         * psymtab.h (psymtab_storage::obstack): Update.
5893         (psymtab_storage::m_obstack): Use gdb::optional.
5894         (class psymtab_storage): Update comment.  Remove objfile
5895         parameter.
5896         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5897
5898 2019-01-10  Tom Tromey  <tom@tromey.com>
5899
5900         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5901         <free_psymtabs>: Now private.
5902         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5903         (allocate_psymtab): Use new method.
5904
5905 2019-01-10  Tom Tromey  <tom@tromey.com>
5906
5907         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5908         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5909         * mdebugread.c (parse_partial_symbols): Use
5910         allocate_dependencies.
5911         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5912         allocate_dependencies.
5913         (process_psymtab_comp_unit_reader)
5914         (build_type_psymtab_dependencies): Likewise.
5915         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5916
5917 2019-01-10  Tom Tromey  <tom@tromey.com>
5918
5919         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5920         PSYMBOL_SET_LANGUAGE.
5921         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5922
5923 2019-01-10  Tom Tromey  <tom@tromey.com>
5924
5925         * psymtab.h (psymtab_storage::obstack): New method.
5926         <m_obstack>: Rename from obstack; now private.
5927         * psymtab.c (psymtab_storage): Update.
5928         * dwarf2read.c (create_addrmap_from_index)
5929         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5930         Update.
5931
5932 2019-01-10  Tom Tromey  <tom@tromey.com>
5933
5934         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5935         * objfiles.h (objfile::reset_psymtabs): New method.
5936
5937 2019-01-10  Tom Tromey  <tom@tromey.com>
5938
5939         * symmisc.c (print_symbol_bcache_statistics): Update.
5940         (print_objfile_statistics): Update.
5941         * symfile.c (reread_symbols): Update.
5942         * psymtab.h (class psymtab_storage): New.
5943         * psymtab.c (psymtab_storage): New constructor.
5944         (~psymtab_storage): New destructor.
5945         (require_partial_symbols): Update.
5946         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5947         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5948         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5949         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5950         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5951         (start_psymtab_common, end_psymtab_common)
5952         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5953         (allocate_psymtab): Update.
5954         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5955         Update.
5956         (dump_psymtab_addrmap, maintenance_print_psymbols)
5957         (maintenance_check_psymtabs): Update.
5958         (class objfile_psymtabs): Move to objfiles.h.
5959         * psympriv.h (discard_psymtab): Now inline.
5960         (psymtab_discarder::psymtab_discarder): Update.
5961         (psymtab_discarder::~psymtab_discarder): Update.
5962         (ALL_OBJFILE_PSYMTABS): Rewrite.
5963         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5964         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5965         Remove fields.
5966         <partial_symtabs>: New field.
5967         (class objfile_psymtabs): Move from psymtab.h.  Update.
5968         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5969         psymbol_cache.
5970         (objfile::~objfile): Don't destroy psymbol_cache.
5971         * mdebugread.c (parse_partial_symbols): Update.
5972         * dwarf2read.c (create_addrmap_from_index)
5973         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5974         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5975         (add_partial_subprogram, dwarf2_ranges_read): Update.
5976         * dwarf-index-write.c (write_address_map)
5977         (write_one_signatured_type, recursively_write_psymbols)
5978         (class debug_names, class debug_names, write_psymtabs_to_index):
5979         Update.
5980
5981 2019-01-10  Tom Tromey  <tom@tromey.com>
5982
5983         * symtab.h (SYMBOL_SET_NAMES): Update.
5984         (symbol_set_names): Update.
5985         (MSYMBOL_SET_NAMES): Update.
5986         * symtab.c (symbol_set_names): Change argument to be an
5987         objfile_per_bfd_storage.
5988         * psymtab.c (add_psymbol_to_bcache): Update.
5989         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5990
5991 2019-01-10  Tom Tromey  <tom@tromey.com>
5992
5993         * symtab.c (create_demangled_names_hash): Change argument to be an
5994         objfile_per_bfd_storage.
5995         (symbol_set_names): Update.
5996
5997 2019-01-10  Tom Tromey  <tom@tromey.com>
5998
5999         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6000         init_psymbol_list.
6001         * psymtab.c (init_psymbol_list): Do nothing if already called.
6002         * psympriv.h (init_psymbol_list): Add comment.
6003         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6004         init_psymbol_list.
6005         * dbxread.c (dbx_symfile_read): Unconditionally call
6006         init_psymbol_list.
6007
6008 2019-01-10  Tom Tromey  <tom@tromey.com>
6009
6010         * xcoffread.c (scan_xcoff_symtab): Update.
6011         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6012         "where".
6013         * mdebugread.c (parse_partial_symbols)
6014         (handle_psymbol_enumerators): Update.
6015         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6016         * dbxread.c (read_dbx_symtab): Update.
6017         * psympriv.h (psymbol_placement): New enum.
6018         (add_psymbol_to_list): Update.
6019
6020 2019-01-10  Tom Tromey  <tom@tromey.com>
6021
6022         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6023         static_psymbols parameters.
6024         (scan_xcoff_symtab): Update.
6025         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6026         static_psymbols parameters.
6027         * psympriv.h (start_psymtab_common): Update.
6028         * mdebugread.c (parse_partial_symbols): Update.
6029         * dwarf2read.c (create_partial_symtab): Update.
6030         * dbxread.c (read_dbx_symtab): Update.
6031         (start_psymtab): Remove global_psymbols and static_psymbols
6032         parameters.
6033
6034 2019-01-10  Tom Tromey  <tom@tromey.com>
6035
6036         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6037         * psymtab.c (allocate_psymtab): Add comment.
6038         * psympriv.h (allocate_psymtab): Add comment.
6039         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6040         initializations.
6041         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6042
6043 2019-01-10  Tom Tromey  <tom@tromey.com>
6044
6045         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6046         Don't declare.
6047         * mipsread.c: Include mdebugread.h.
6048         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6049         Declare.
6050         * elfread.c: Include mdebugread.h.
6051
6052 2019-01-09  Tom Tromey  <tom@tromey.com>
6053
6054         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6055         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6056         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6057         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6058         (psym_lookup_symbol, psym_find_last_source_symtab)
6059         (psym_forget_cached_source_info, psym_print_stats)
6060         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6061         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6062         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6063         (psym_find_compunit_symtab_by_address)
6064         (maintenance_print_psymbols, maintenance_info_psymtabs)
6065         (maintenance_check_psymtabs): Use ranged for.
6066         * psymtab.h (class objfile_psymtabs): New.
6067         (require_partial_symbols): Return objfile_psymtabs.
6068         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6069
6070 2019-01-09  Tom Tromey  <tom@tromey.com>
6071
6072         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6073         (find_pc_mapped_section, list_overlays_command)
6074         (map_overlay_command, unmap_overlay_command)
6075         (simple_overlay_update): Use all_objfiles.
6076         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6077         * printcmd.c (info_symbol_command): Use all_objfiles.
6078         * objfiles.h (ALL_OBJSECTIONS): Remove.
6079         * maint.c (maintenance_translate_address): Use all_objfiles.
6080         * gcore.c (gcore_create_callback): Use all_objfiles.
6081         (objfile_find_memory_regions): Likewise.
6082
6083 2019-01-09  Tom Tromey  <tom@tromey.com>
6084
6085         * symtab.c (find_line_symtab, info_sources_command)
6086         (make_source_files_completion_list): Use objfile_compunits.
6087         * source.c (select_source_symtab): Use objfile_compunits.
6088         * objfiles.h (struct objfile): Update comment.
6089         (ALL_OBJFILES): Remove.
6090         (ALL_FILETABS): Remove.
6091         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6092         objfile_compunits.
6093
6094 2019-01-09  Tom Tromey  <tom@tromey.com>
6095
6096         * symmisc.c (print_objfile_statistics, dump_objfile)
6097         (maintenance_print_symbols): Use compunit_filetabs.
6098         * source.c (forget_cached_source_info_for_objfile): Use
6099         compunit_filetabs.
6100         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6101         (ALL_FILETABS): Use compunit_filetabs.
6102         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6103         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6104
6105 2019-01-09  Tom Tromey  <tom@tromey.com>
6106
6107         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6108         (compunit_filetabs): New.
6109         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6110         compunit_filetabs.
6111         (info_sources_command, make_source_files_completion_list): Remove
6112         declaration.
6113         * symmisc.c (print_objfile_statistics, dump_objfile)
6114         (maintenance_print_symbols): Remove declaration.
6115         (maintenance_info_symtabs): Use compunit_filetabs.
6116         (maintenance_info_line_tables): Likewise.
6117         * source.c (select_source_symtab): Change local variable name.
6118         (forget_cached_source_info_for_objfile): Remove declaration.
6119         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6120         * objfiles.c (objfile_relocate1): Remove declaration.
6121         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6122         declaration.
6123         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6124         * coffread.c (coff_symtab_read): Remove declaration.
6125         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6126         compunit_filetabs.
6127
6128 2019-01-09  Tom Tromey  <tom@tromey.com>
6129
6130         * symtab.c (lookup_objfile_from_block)
6131         (find_pc_sect_compunit_symtab, search_symbols)
6132         (default_collect_symbol_completion_matches_break_on): Use
6133         objfile_compunits.
6134         * objfiles.h (ALL_COMPUNITS): Remove.
6135         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6136         * cp-support.c (add_symbol_overload_list_qualified): Use
6137         objfile_compunits.
6138         * ada-lang.c (ada_collect_symbol_completion_matches)
6139         (ada_add_global_exceptions): Use objfile_compunits.
6140
6141 2019-01-09  Tom Tromey  <tom@tromey.com>
6142
6143         * source.c (select_source_symtab)
6144         (forget_cached_source_info_for_objfile): Remove declaration.
6145         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6146         declaration.
6147         * maint.c (count_symtabs_and_blocks): Remove declaration.
6148         * cp-support.c (add_symbol_overload_list_qualified): Remove
6149         declaration.
6150         * coffread.c (coff_symtab_read): Remove declaration.
6151         * symtab.c (lookup_symbol_in_objfile_symtabs)
6152         (basic_lookup_transparent_type_1): Use objfile_compunits.
6153         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6154         (info_sources_command, search_symbols)
6155         (default_collect_symbol_completion_matches_break_on)
6156         (make_source_files_completion_list): Remove declaration.
6157         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6158         (ada_collect_symbol_completion_matches)
6159         (ada_add_global_exceptions): Remove declaration.
6160         * linespec.c (iterate_over_all_matching_symtabs): Use
6161         objfile_compunits.
6162         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6163         (class objfile_compunits): New.
6164         (ALL_COMPUNITS): Use objfile_compunits.
6165         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6166         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6167         objfile_compunits.
6168         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6169
6170 2019-01-09  Tom Tromey  <tom@tromey.com>
6171
6172         * symtab.c (search_symbols)
6173         (default_collect_symbol_completion_matches_break_on): Use
6174         objfile_msymbols.
6175         * ada-lang.c (ada_lookup_simple_minsym)
6176         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6177         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6178         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6179         objfile_msymbols.
6180         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6181         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6182         * objc-lang.c (find_methods): Use objfile_msymbols.
6183         (info_selectors_command, info_classes_command): Likewise.
6184         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6185         * objfiles.h (class objfile_msymbols): New.
6186         (ALL_OBJFILE_MSYMBOLS): Remove.
6187         (ALL_MSYMBOLS): Remove.
6188
6189 2019-01-09  Tom Tromey  <tom@tromey.com>
6190
6191         * common/next-iterator.h (next_adapter): Add Iterator template
6192         parameter.
6193         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6194         (class all_objfiles_safe): New.
6195         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6196         * objfiles.c (put_objfile_before): Update comment.
6197         (add_separate_debug_objfile): Likewise.
6198         (free_all_objfiles): Use all_objfiles_safe.
6199         (objfile_purge_solibs): Likewise.
6200
6201 2019-01-09  Tom Tromey  <tom@tromey.com>
6202
6203         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6204         (expand_symtab_containing_pc, lookup_static_symbol)
6205         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6206         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6207         all_objfiles.
6208         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6209         * breakpoint.c (create_overlay_event_breakpoint)
6210         (create_longjmp_master_breakpoint)
6211         (create_std_terminate_master_breakpoint)
6212         (create_exception_master_breakpoint): Use all_objfiles.
6213         * linux-thread-db.c (try_thread_db_load_from_pdir)
6214         (has_libpthread): Use all_objfiles.
6215         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6216         * linespec.c (iterate_over_all_matching_symtabs)
6217         (search_minsyms_for_name): Use all_objfiles.
6218         * maint.c (maintenance_info_sections): Use all_objfiles.
6219         * main.c (captured_main_1): Use all_objfiles.
6220         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6221         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6222         * guile/scm-pretty-print.c
6223         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6224         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6225         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6226         (maintenance_print_msymbols): Use all_objfiles.
6227         * source.c (select_source_symtab): Use all_objfiles.
6228         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6229         * symfile.c (remove_symbol_file_command)
6230         (expand_symtabs_matching, map_symbol_filenames): Use
6231         all_objfiles.
6232         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6233         all_objfiles.
6234         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6235         * objc-lang.c (find_methods): Use all_objfiles.
6236         * objfiles.c (have_partial_symbols, have_full_symbols)
6237         (have_minimal_symbols, qsort_cmp)
6238         (default_iterate_over_objfiles_in_search_order): Use
6239         all_objfiles.
6240         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6241         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6242         (maintenance_check_psymtabs): Use all_objfiles.
6243         (ALL_PSYMTABS): Remove.
6244         * compile/compile-object-run.c (do_module_cleanup): Use
6245         all_objfiles.
6246         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6247         * cp-support.c (add_symbol_overload_list_qualified): Use
6248         all_objfiles.
6249         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6250         Use all_objfiles.
6251         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6252         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6253         all_objfiles.
6254         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6255         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6256         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6257         Uses all_objfiles.
6258         * solib.c (solib_read_symbols): Use all_objfiles
6259
6260 2019-01-09  Tom Tromey  <tom@tromey.com>
6261
6262         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6263         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6264         all_objfiles.
6265         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6266         * symmisc.c (print_symbol_bcache_statistics)
6267         (print_objfile_statistics, maintenance_print_objfiles)
6268         (maintenance_info_symtabs, maintenance_check_symtabs)
6269         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6270         all_objfiles.
6271         * source.c (forget_cached_source_info): Use all_objfiles.
6272         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6273         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6274         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6275         * objfiles.c (update_section_map): Use all_objfiles.
6276         (shared_objfile_contains_address_p): Likewise.
6277         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6278         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6279
6280 2019-01-09  Tom Tromey  <tom@tromey.com>
6281
6282         * common/next-iterator.h: New file.
6283         * objfiles.h (class all_objfiles): New.
6284         (struct objfile_iterator): New.
6285
6286 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6287
6288         * NEWS: Move the description of the changed "frame", "select-frame",
6289          and "info frame" commands to the Changed commands section.
6290
6291 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6292
6293         * gdbtypes.c (check_stub_method_group): Remove handling of old
6294         mangling schemes.
6295         * linespec.c (find_methods): Likewise.
6296         * stabsread.c (read_member_functions): Likewise.
6297         * valops.c (search_struct_method): Likewise.
6298         (value_struct_elt_for_reference): Likewise.
6299         * NEWS: Mention this change.
6300
6301 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6302
6303         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6304         print_source_lines.
6305         * source.c (print_source_lines_base): Update line number check.
6306         (print_source_lines): New function.
6307         (source_lines_range::source_lines_range): New function.
6308         * source.h (class source_lines_range): New class.
6309         (print_source_lines): New declaration.
6310
6311 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6312
6313         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6314
6315 2019-01-08  Tom Tromey  <tom@tromey.com>
6316             Simon Marchi  <simon.marchi@ericsson.com>
6317
6318         PR gdb/24060
6319         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6320         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6321         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6322         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6323         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6324         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6325
6326 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6327
6328         * source.c (select_source_symtab): Move header comment to
6329         declaration in source.h.
6330         (forget_cached_source_info_for_objfile): Likewise.
6331         (forget_cached_source_info): Likewise.
6332         (identify_source_line): Likewise.
6333         * source.h (identify_source_line): Move declaration from symtab.h
6334         and add comment from source.c
6335         (print_source_lines): Likewise.
6336         (forget_cached_source_info_for_objfile): Likewise.
6337         (forget_cached_source_info): Likewise.
6338         (select_source_symtab): Likewise.
6339         (enum print_source_lines_flag): Move definition from symtab.h.
6340         * symtab.h (identify_source_line): Move declaration to source.h.
6341         (print_source_lines): Likewise.
6342         (forget_cached_source_info_for_objfile): Likewise.
6343         (forget_cached_source_info): Likewise.
6344         (select_source_symtab): Likewise.
6345         (enum print_source_lines_flag): Move definition to source.h.
6346         * tui/tui-hooks.c: Add 'source.h' include.
6347
6348 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * source.c (print_source_lines_base): Handle requests to print
6351         reverse line number sequences, and guard against empty lines
6352         string.
6353
6354 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * source.c (print_source_lines_base): Fix skip of '\r' if next
6357         character is '\n'.
6358
6359 2019-01-06  Tom Tromey  <tom@tromey.com>
6360
6361         * c-exp.y (struct c_parse_state) <macro_original_text,
6362         expansion_obstack>: New member.
6363         (macro_original_text, expansion_obstack): Remove globals.
6364         (scan_macro_expansion, scanning_macro_expansion)
6365         (finished_macro_expansion): Update.
6366         (scan_macro_cleanup): Remove.
6367         (yylex, c_parse): Update.
6368
6369 2019-01-06  Tom Tromey  <tom@tromey.com>
6370
6371         * c-exp.y (struct c_parse_state) <strings>: New member.
6372         (operator_stoken): Update.
6373
6374 2019-01-06  Tom Tromey  <tom@tromey.com>
6375
6376         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6377         (union type_stack_elt) <typelist_val>: Now a pointer to
6378         std::vector.
6379         (type_stack_cleanup): Don't declare.
6380         (push_typelist): Update.
6381         * parse.c (pop_typelist): Return a std::vector.
6382         (push_typelist): Take a std::vector.
6383         (follow_types): Update.  Do not free args.
6384         (type_stack_cleanup): Remove.
6385         * c-exp.y (struct c_parse_state): New.
6386         (cpstate): New global.
6387         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6388         (nonempty_typelist): Update.
6389         (func_mod): Create a new vector.
6390         (c_parse): Create a c_parse_state.
6391         (check_parameter_typelist): Do not delete params.
6392         (function_method): Update.  Do not delete type_list.
6393
6394 2019-01-06  Tom Tromey  <tom@tromey.com>
6395
6396         PR gdb/28155:
6397         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6398         check_typedef.
6399         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6400         (print_return_value): Likewise.
6401
6402 2019-01-05  Tom Tromey  <tom@tromey.com>
6403
6404         * contrib/cleanup_check.py: Remove.
6405         * contrib/gcc-with-excheck: Remove.
6406         * contrib/exsummary.py: Remove.
6407         * contrib/excheck.py: Remove.
6408
6409 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6410
6411         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6412         NULL. Initialize tpprev to NULL instead of assigning it
6413         to NULL on the next statement.
6414         * windows-nat.c (windows_delete_thread): Remove check for
6415         main_thread_id before printing thread exit notifications.
6416         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6417         Remove thread ID check against main_thread_id.
6418         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6419         windows_delete_thread.
6420         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6421
6422 2019-01-04  Tom Tromey  <tom@tromey.com>
6423
6424         * compile/compile.c (_initialize_compile): Use upper case for
6425         metasyntactic variables.
6426         * symmisc.c (_initialize_symmisc): Use upper case for
6427         metasyntactic variables.
6428         * psymtab.c (_initialize_psymtab): Use upper case for
6429         metasyntactic variables.
6430         * demangle.c (demangle_command): Use upper case for metasyntactic
6431         variables.
6432         (_initialize_demangler): Likewise.
6433         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6434         variables.
6435
6436 2019-01-03  Tom Tromey  <tom@tromey.com>
6437
6438         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6439
6440 2019-01-03  Tom Tromey  <tom@tromey.com>
6441
6442         * python/py-symtab.c (salpy_str): Update.
6443         (struct salpy_sal_object) <symtab>: Now a PyObject.
6444         (salpy_dealloc): Update.
6445         (del_objfile_sal): Use gdbpy_ref.
6446
6447 2019-01-03  Tom Tromey  <tom@tromey.com>
6448
6449         * python/py-type.c (convert_field): Use new_reference.  Return
6450         gdbpy_ref.
6451         (make_fielditem): Return gdbpy_ref.
6452         (typy_fields): Update.
6453         (typy_getitem): Update.
6454         (field_name): Return gdbpy_ref.  Use new_reference.
6455         (typy_iterator_iternext): Update.
6456
6457 2019-01-03  Tom Tromey  <tom@tromey.com>
6458
6459         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6460
6461 2019-01-03  Tom Tromey  <tom@tromey.com>
6462
6463         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6464         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6465         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6466         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6467         (pspy_set_type_printers): Likewise.
6468         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6469         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6470         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6471         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6472         (objfpy_set_type_printers): Likewise.
6473
6474 2019-01-03  Tom Tromey  <tom@tromey.com>
6475
6476         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6477         (gdbpy_print_stack): Use gdbpy_err_fetch.
6478         * python/python-internal.h (class gdbpy_err_fetch): New class.
6479         (class gdbpy_enter) <m_error_type, m_error_value,
6480         m_error_traceback>: Remove.
6481         <m_error>: New member.
6482         (gdbpy_exception_to_string): Don't declare.
6483         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6484         * python/py-value.c (convert_value_from_python): Use
6485         gdbpy_err_fetch.
6486         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6487         gdbpy_exception_to_string.
6488         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6489         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6490         gdbpy_err_fetch.
6491
6492 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6493
6494         * linux-nat.c (delete_lwp_cleanup): Delete.
6495         (struct lwp_deleter): New struct.
6496         (lwp_info_up): New typedef.
6497         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6498         lwp_info_up.
6499
6500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6501
6502         * linux-fork.c (class scoped_switch_fork_info): New class.
6503         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6504
6505 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6506
6507         * valops.c (find_overload_match): Remove use of null_cleanup, and
6508         calls to do_cleanups.
6509
6510 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         * compile/compile-cplus-types.c
6513         (compile_cplus_instance::decl_name): Handle changes to
6514         cp_func_name.
6515         * cp-support.c (cp_func_name): Update header comment, update
6516         return type.
6517         * cp-support.h (cp_func_name): Update return type in declaration.
6518         * valops.c (find_overload_match): Move temp_func local to top
6519         level of function and change its type.  Use temp_func to hold and
6520         delete temporary string obtained from cp_func_name.
6521
6522 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6523
6524         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6525         gdb::char_vector, remove cleanup, and update uses of `msg`.
6526
6527 2019-01-03  Jim Wilson  <jimw@sifive.com>
6528
6529         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6530
6531 2019-01-02  Tom Tromey  <tom@tromey.com>
6532
6533         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6534         (tdesc_parse_xml): Remove cleanups.
6535         * target-descriptions.h (make_cleanup_free_target_description):
6536         Don't declare.
6537         (target_desc_deleter): New struct.
6538         (target_desc_up): New typedef.
6539         * target-descriptions.c (target_desc_deleter::operator()): Rename
6540         from free_target_description.
6541         (make_cleanup_free_target_description): Remove.
6542
6543 2019-01-02  Tom Tromey  <tom@tromey.com>
6544
6545         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6546         constructor, destructor.
6547         (linespec_parser): Remove typedef.
6548         (~linespec_parser): Rename from linespec_parser_delete.
6549         (linespec_lex_to_end, linespec_complete_label)
6550         (linespec_complete): Update.
6551         (decode_line_full): Remove cleanups.
6552         (decode_line_1): Update.
6553
6554 2019-01-02  Tom Tromey  <tom@tromey.com>
6555
6556         * python/python-internal.h (inferior_to_inferior_object): Change
6557         return type.
6558         * python/py-exitedevent.c (create_exited_event_object): Update.
6559         * python/py-inferior.c (inferior_to_inferior_object): Return
6560         gdbpy_ref.
6561         (python_new_inferior, python_inferior_deleted)
6562         (thread_to_thread_object, delete_thread_object)
6563         (build_inferior_list, gdbpy_selected_inferior): Update.
6564         * python/py-infthread.c (create_thread_object): Update.  Also fail
6565         if inferior_to_inferior_object fails.
6566
6567 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6568
6569         * inferior.h (class inferior) <displaced_step_state>: New field.
6570         * infrun.h (struct displaced_step_state): Move here from
6571         infrun.c.  Initialize fields, add constructor.
6572         <inf>: Remove field.
6573         <reset>: New method.
6574         * infrun.c (struct displaced_step_inferior_state): Move to
6575         infrun.h.
6576         (displaced_step_inferior_states): Remove.
6577         (get_displaced_stepping_state): Adust.
6578         (displaced_step_in_progress_any_inferior): Adjust.
6579         (displaced_step_in_progress_thread): Adjust.
6580         (displaced_step_in_progress): Adjust.
6581         (add_displaced_stepping_state): Remove.
6582         (get_displaced_step_closure_by_addr): Adjust.
6583         (remove_displaced_stepping_state): Remove.
6584         (infrun_inferior_exit): Call displaced_step_state.reset.
6585         (use_displaced_stepping): Don't check for NULL.
6586         (displaced_step_prepare_throw): Call
6587         get_displaced_stepping_state.
6588         (displaced_step_fixup): Don't check for NULL.
6589         (prepare_for_detach): Don't check for NULL.
6590
6591 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6592
6593         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6594          in case of call that did not complete.
6595
6596 2019-01-02  Andrey Utkin  <autkin@undo.io>
6597
6598         * symfile.c (find_separate_debug_file): Fix search of debug files for
6599         remote debuggee.
6600
6601 2019-01-02  Tom Tromey  <tom@tromey.com>
6602
6603         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6604         indentation.
6605         * python/py-frame.c (frapy_older): Remove cast.
6606         (frapy_newer): Likewise.
6607         * python/py-breakpoint.c (local_setattro): Remove cast.
6608         * python/py-arch.c (archpy_name): Remove local variable.
6609         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6610
6611 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6612
6613         * unittests/basic_string_view/element_access/char/empty.cc:
6614         Fix year range in copyright header.
6615
6616 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6617
6618         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6619         Delete.
6620         <operator==>: Update with for removed field.
6621         <hash>: Likewise.
6622         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6623         <isa_features>: ...this.
6624         <abi_features>: New field.
6625         (riscv_isa_flen): Update comment.
6626         (riscv_abi_xlen): New declaration.
6627         (riscv_abi_flen): New declaration.
6628         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6629         isa_features.
6630         (riscv_abi_xlen): New function.
6631         (riscv_isa_flen): Update to get answer from isa_features.
6632         (riscv_abi_flen): New function.
6633         (riscv_has_fp_abi): Update to get answer from abi_features.
6634         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6635         xlen and flen.
6636         (riscv_call_info) <xlen, flen>: Update comment.
6637         (riscv_call_arg_struct): Remove invalid assertions
6638         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6639         is removed.
6640         (riscv_gdbarch_init): Gather isa features and abi features
6641         separately, ensure both match on the gdbarch when reusing an old
6642         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6643         a target with 64-bit float hardware.
6644
6645 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6646
6647         * source.c (search_command_helper): Stop reverse search
6648         when line 1 has been searched.
6649
6650 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6651
6652         * record-full.c (record_full_base_target::close): Rewrite
6653         record_full_core_buf_list free logic.
6654
6655 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6656
6657         * break-catch-syscall.c (print_one_catch_syscall): xfree
6658         the last text.
6659
6660 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6661
6662         * top.c (print_gdb_version): Update Copyright year in version
6663         message.
6664
6665 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6666
6667         Update copyright year range in all GDB files.
6668
6669 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6670
6671         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6672
6673 For older changes see ChangeLog-2018.
6674 \f
6675 Local Variables:
6676 mode: change-log
6677 left-margin: 8
6678 fill-column: 74
6679 version-control: never
6680 coding: utf-8
6681 End:
6682