gdb/ChangeLog

   1 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * infrun.c (stop_all_threads): If debug_infrun, always
   4         trace the wait status after wait_one, using
   5         target_waitstatus_to_string and target_pid_to_str.
   6         (handle_inferior_event): Replace various trace of
   7         wait status kind by a single trace.
   8         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
   9         wait status kind image by target_waitstatus_to_string.
  10         * target/waitstatus.c (target_waitstatus_to_string): Fix
  11         obsolete comment.
  12
  13 2019-04-01  Tom Tromey  <tromey@adacore.com>
  14
  15         PR symtab/23331:
  16         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
  17
  18 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
  19             Pedro Alves  <palves@redhat.com>
  20
  21         * top.c (quit_force): Call 'finalize_values'.
  22         * value.c (finalize_values): New function.
  23         * value.h (finalize_values): Declare.
  24
  25 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
  26
  27         * NEWS: Announce $_gdb_major and $_gdb_minor.
  28
  29         * top.c (init_gdb_version_vars): New function.
  30         (gdb_init): Call init_gdb_version_vars.
  31
  32 2019-03-29  Tom Tromey  <tromey@adacore.com>
  33
  34         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  35         help text.  Remove dead code.
  36
  37 2019-03-29  Keith Seitz  <keiths@redhat.com>
  38
  39         From Siddhesh Poyarekar:
  40         * f-lang.h (f77_get_upperbound): Return LONGEST.
  41         (f77_get_lowerbound): Likewise.
  42         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  43         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  44         print them.
  45         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  46         plongest to format print it.
  47         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  48         (f77_get_upperbound): Likewise.
  49         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  50         LOWER_BOUND to LONGEST.
  51         (f77_create_arrayprint_offset_tbl): Likewise.
  52
  53 2019-03-29  Keith Seitz  <keiths@redhat.com>
  54
  55         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  56         %s/pulongest for TYPE_LENGTH instead of %d in format
  57         strings.
  58         * ada-typerint.c (ada_print_type): Likewise.
  59         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  60         * compile/compile-c-support.c (generate_register_struct): Likewise.
  61         * gdbtypes.c (recursive_dump_type): Likewise.
  62         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  63         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  64         instead of %d in format strings.
  65         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  66         to std::min to ULONGEST.
  67         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  68         instead of %d in format strings.
  69         * tracepoint.c (info_scope_command): Likewise.
  70         * typeprint.c (print_offset_data::update)
  71         (print_offset_data::finish): Likewise.
  72         * xtensa-tdep.c (xtensa_store_return_value)
  73         (xtensa_push_dummy_call): Likewise.
  74
  75 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  76
  77         * windows-nat.c (display_selector): Fixed format specifications
  78         for 64-bit Cygwin.
  79
  80 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  81
  82         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
  83
  84 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  85
  86         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
  87         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
  88         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  89         (nios2_linux_init_abi): Install it.
  90
  91 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  92
  93         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  94
  95 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  96
  97         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  98
  99 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 100             Tom Tromey  <tromey@adacore.com>
 101
 102         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 103
 104 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 105
 106         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 107         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 108         method to compute the bounds of range types. Also print "[evaluated]"
 109         if the bounds' values come from a dynamic evaluation.
 110
 111 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 112
 113         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 114         whitespace when pretty printing is on.
 115
 116 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 117
 118         * ppc-linux-nat.c: Add include.
 119
 120 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 121
 122         * NEWS: Mention AArch64 Pointer Authentication.
 123
 124 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 125
 126         * arm-linux-nat.c: Add include.
 127
 128 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 129
 130         * source-cache.c (source_cache::get_source_lines): Re-read
 131         fullname after calling open_source_file.
 132
 133 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 134
 135         * NEWS: Mention TLS support for FreeBSD.
 136
 137 2019-03-25  Tom Tromey  <tromey@adacore.com>
 138
 139         * minsyms.c (BUNCH_SIZE): Update comment.
 140         (~minimal_symbol_reader): Remove old comment.
 141         (compact_minimal_symbols): Update comment.
 142         (minimal_symbol_reader::install): Remove old comment.  Update
 143         other comments.
 144
 145 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 146
 147         * s390-linux-nat.c: Add include.
 148
 149 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 150
 151         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 152         Call linux_get_hwcap.
 153         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 154         Likewise.
 155         (aarch64_linux_get_hwcap): Remove function.
 156         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 157         declaration.
 158         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 159         linux_get_hwcap.
 160         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 161         * linux-tdep.c (linux_get_hwcap): Add function.
 162         (linux_get_hwcap2): Likewise.
 163         * linux-tdep.h (linux_get_hwcap): Add declaration.
 164         (linux_get_hwcap2): Likewise.
 165         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 166         (ppc_linux_get_hwcap2): Likewise.
 167         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 168         linux_get_hwcap.
 169         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 170         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 171         (ppc_linux_nat_target::read_description): Likewise.
 172         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 173         * s390-linux-nat.c: Likewise.
 174         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 175
 176 2019-03-24  Tom Tromey  <tom@tromey.com>
 177
 178         * ada-lang.c (standard_lookup): Simplify initialization.
 179         (ada_lookup_symbol_nonlocal): Simplify return.
 180         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 181         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 182         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 183         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 184         initialization.
 185         * solib.c (solib_global_lookup): Simplify.
 186         * symtab.c (null_block_symbol): Remove.
 187         (symbol_cache_lookup): Simplify returns.
 188         (lookup_language_this): Simplify returns.
 189         (lookup_symbol_aux): Simplify return.
 190         (lookup_local_symbol): Simplify returns.
 191         (lookup_global_symbol_from_objfile): Simplify return.
 192         (lookup_symbol_in_objfile_symtabs)
 193         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 194         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 195         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 196         * cp-namespace.c (cp_lookup_bare_symbol)
 197         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 198         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 199         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 200         (cp_lookup_symbol_via_imports): Simplify initialization.
 201         (find_symbol_in_baseclass): Likewise.
 202         * symtab.h (null_block_symbol): Remove.
 203         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 204         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 205         (d_lookup_symbol_module): Likewise.
 206         (find_symbol_in_baseclass): Simplify initialization.
 207
 208 2019-03-24  Tom Tromey  <tom@tromey.com>
 209
 210         * expression.h: Don't include symtab.h.
 211         (struct block): Forward declare.
 212
 213 2019-03-24  Tom Tromey  <tom@tromey.com>
 214
 215         * c-exp.y (typebase): Remove casts.
 216         * gdbtypes.c (lookup_unsigned_typename, )
 217         (lookup_signed_typename): Remove cast.
 218         * eval.c (parse_to_comma_and_eval): Remove cast.
 219         * parse.c (write_dollar_variable): Remove cast.
 220         * block.h (struct block) <superblock>: Now const.
 221         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 222         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 223         (map_block): Make "block" const.
 224         * symfile.h (struct quick_symbol_functions)
 225         <map_matching_symbols>: Constify block argument to "callback".
 226         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 227         const.
 228         (find_pc_sect_compunit_symtab): Make "b" const.
 229         (find_symbol_at_address): Likewise.
 230         (search_symbols): Likewise.
 231         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 232         (dw2_debug_names_lookup_symbol): Likewise.
 233         (dw2_map_matching_symbols): Update.
 234         * p-valprint.c (pascal_val_print): Remove "block".
 235         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 236         (aux_add_nonlocal_symbols): Make "block" const.
 237         (resolve_subexp): Remove cast.
 238         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 239         const.
 240         (iterate_over_file_blocks): Likewise.
 241         * f-exp.y (%union) <bval>: Remove.
 242         * coffread.c (patch_opaque_types): Make "b" const.
 243         * spu-tdep.c (spu_catch_start): Make "block" const.
 244         * c-valprint.c (print_unpacked_pointer): Remove "block".
 245         * symmisc.c (dump_symtab_1): Make "b" const.
 246         (block_depth): Make "block" const.
 247         * d-exp.y (%union) <bval>: Remove.
 248         * cp-support.h (cp_lookup_rtti_type): Update.
 249         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 250         * psymtab.c (psym_lookup_symbol): Make "block" const.
 251         (maintenance_check_psymtabs): Make "b" const.
 252         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 253         (enumerate_locals, enumerate_args): Update.
 254         * python/py-symtab.c (stpy_global_block): Make "block" const.
 255         (stpy_static_block): Likewise.
 256         * inline-frame.c (block_starting_point_at): Make "new_block"
 257         const.
 258         * block.c (find_block_in_blockvector): Make return type const.
 259         (blockvector_for_pc_sect): Make "b" const.
 260         (find_block_in_blockvector): Make "b" const.
 261
 262 2019-03-23  Tom Tromey  <tom@tromey.com>
 263
 264         * varobj.c (varobj_create): Update.
 265         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 266         * printcmd.c (display_command, do_one_display): Don't reset
 267         innermost_block.
 268         * parser-defs.h (enum innermost_block_tracker_type): Move to
 269         expression.h.
 270         (innermost_block): Update comment.
 271         * parse.c (parse_exp_1): Add tracker_types parameter.
 272         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 273         tracker_types parameter.  Reset innermost_block.
 274         (parse_exp_in_context): Remove.
 275         (parse_expression_for_completion): Update.
 276         * objfiles.c (~objfile): Don't reset expression_context_block or
 277         innermost_block.
 278         * expression.h (enum innermost_block_tracker_type): Move from
 279         parser-defs.h.
 280         (parse_exp_1): Add tracker_types parameter.
 281         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 282         reset innermost_block.
 283
 284 2019-03-23  Tom Tromey  <tom@tromey.com>
 285
 286         * objfiles.h: Include bcache.h.
 287
 288 2019-03-23  Tom Tromey  <tom@tromey.com>
 289
 290         * linespec.c (get_current_search_block): Use
 291         scoped_restore_current_language.
 292         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 293
 294 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 295             Jiong Wang  <jiong.wang@arm.com>
 296
 297         * aarch64-linux-tdep.c
 298         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 299         section.
 300         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 301
 302 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 303             Jiong Wang  <jiong.wang@arm.com>
 304
 305         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 306         instructions.
 307         (aarch64_analyze_prologue_test): Add PACIASP test.
 308         (aarch64_prologue_prev_register): Unmask PC value.
 309
 310 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 311             Jiong Wang  <jiong.wang@arm.com>
 312
 313         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 314         (aarch64_dwarf2_prev_register): Unmask PC value.
 315         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 316         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 317         DW_CFA_AARCH64_negate_ra_state.
 318         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 319
 320 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 321             Jiong Wang  <jiong.wang@arm.com>
 322
 323         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 324         registers.
 325         (aarch64_pseudo_register_name): Likewise.
 326         (aarch64_pseudo_register_type): Likewise.
 327         (aarch64_pseudo_register_reggroup_p): Likewise.
 328         (aarch64_gdbarch_init): Add pauth registers.
 329         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 330         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 331         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 332         (struct gdbarch_tdep): Add regnum for ra_state.
 333
 334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 335             Jiong Wang  <jiong.wang@arm.com>
 336
 337         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 338
 339 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 340             Jiong Wang  <jiong.wang@arm.com>
 341
 342         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 343         function.
 344         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 345         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 346         (aarch64_gdbarch_init): Add puth registers.
 347         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 348         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 349         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 350
 351 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 352             Jiong Wang  <jiong.wang@arm.com>
 353
 354         * aarch64-linux-nat.c
 355         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 356         * aarch64-linux-tdep.c
 357         (aarch64_linux_core_read_description): Likewise.
 358         (aarch64_linux_get_hwcap): New function.
 359         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 360         (aarch64_linux_get_hwcap): New declaration.
 361
 362 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 363             Jiong Wang  <jiong.wang@arm.com>
 364
 365         * aarch64-linux-nat.c
 366         (aarch64_linux_nat_target::read_description): Add pauth param.
 367         * aarch64-linux-tdep.c
 368         (aarch64_linux_core_read_description): Likewise.
 369         * aarch64-tdep.c (struct target_desc): Add in pauth.
 370         (aarch64_read_description): Add pauth param.
 371         (aarch64_gdbarch_init): Likewise.
 372         * aarch64-tdep.h (aarch64_read_description): Likewise.
 373         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 374         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 375         * features/Makefile: Add new files.
 376         * features/aarch64-pauth.c: New file.
 377         * features/aarch64-pauth.xml: New file.
 378
 379 2019-03-20  Tom Tromey  <tromey@adacore.com>
 380
 381         * infrun.c (handle_inferior_event): Rename from
 382         handle_inferior_event_1.  Create a scoped_value_mark.
 383         (handle_inferior_event): Remove.
 384
 385 2019-03-19  Tom Tromey  <tromey@adacore.com>
 386
 387         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 388         * infrun.h (print_stop_event): Add "displays" parameter.
 389         * infrun.c (print_stop_event): Add "displays" parameter.
 390
 391 2019-03-19  Pedro Alves  <palves@redhat.com>
 392
 393         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 394         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 395         to -1.  Fix TABs vs spaces.
 396         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 397         * tui/tui-out.h (tui_ui_out) Add intro comments.
 398         <m_line, m_start_of_line>: In-class initialize, and add describing
 399         comment.
 400
 401 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 402
 403         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 404         variable names.
 405         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 406
 407 2019-03-18  Pedro Alves  <palves@redhat.com>
 408             Eli Zaretskii <eliz@gnu.org>
 409
 410         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 411         m_line and m_start_of_line.
 412
 413 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 414
 415         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 416         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 417         it returns a newline.  This fixes a regression in TU mode, whereby
 418         the next line is output on the same screen line as the user input.
 419
 420 2019-03-18  Tom Tromey  <tromey@adacore.com>
 421
 422         * minsyms.c (minimal_symbol_reader::install): Remove call to
 423         obstack_blank.
 424
 425 2019-03-18  Pedro Alves  <palves@redhat.com>
 426
 427         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 428         New globals.
 429         (apply_style): New, factored out from ...
 430         (apply_ansi_escape): ... this.  Handle reverse video mode.
 431         (tui_set_reverse_mode): New function.
 432         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 433         * tui/tui-winsource.c (tui_show_source_line): Use
 434         tui_set_reverse_mode instead of setting A_STANDOUT.
 435         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 436         New setter methods.
 437
 438 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 439
 440         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 441         Handle tabs.
 442
 443 2019-03-18  Tom Tromey  <tromey@adacore.com>
 444
 445         * ada-lang.c (empty_array): Add "high" parameter.
 446         (ada_evaluate_subexp): Update.
 447
 448 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 449
 450         * unittests/string_view-selftests.c: Define
 451         _initialize_string_view_selftests unconditionally.
 452
 453 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 454
 455         PR gdb/24350
 456         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 457
 458 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 459
 460         PR gdb/24351
 461         * windows-nat.c (display_selector): Fix format specifiers.
 462
 463 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 464
 465         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 466         tui_refill_source_window instead of tui_refresh_win, to update the
 467         current execution line.  This fixes redisplay of the current line
 468         when stepping through the code with "next" or "step".
 469
 470 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 471
 472         * source-cache.c (source_cache::get_source_lines): Call
 473         find_source_lines to initialize s->nlines.  This fixes vertical
 474         scrolling of TUI source window when the DOWN arrow is pressed.
 475
 476 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 477
 478         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 479         linux-thread-db.c (_initialize_thread_db): Likewise.
 480
 481 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 482
 483         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 484         wclrtoeol in tui_show_source_line".  This reverts changes made in
 485         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 486
 487 2019-03-15  Tom Tromey  <tom@tromey.com>
 488
 489         * symtab.h (struct minimal_symbol): Derive from
 490         general_symbol_info.
 491         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 492         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 493         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 494         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 495         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 496         (MSYMBOL_SEARCH_NAME): Update.
 497         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 498         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 499         * minsyms.c (minimal_symbol_reader::record_full): Update.
 500
 501 2019-03-15  Tom Tromey  <tom@tromey.com>
 502
 503         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 504
 505 2019-03-15  Tom Tromey  <tom@tromey.com>
 506
 507         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 508         unique_xmalloc_ptr.
 509         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 510         Update.
 511         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 512         (build_minimal_symbol_hash_tables)
 513         (minimal_symbol_reader::install): Update.
 514
 515 2019-03-15  Tom Tromey  <tom@tromey.com>
 516
 517         * symtab.c (create_demangled_names_hash): Update.
 518         (symbol_set_names): Update.
 519         * objfiles.h (struct objfile_per_bfd_storage)
 520         <demangled_names_hash>: Now an htab_up.
 521         * objfiles.c (objfile_per_bfd_storage): Simplify.
 522
 523 2019-03-15  Tom Tromey  <tom@tromey.com>
 524
 525         * objfiles.h (struct objfile_per_bfd_storage): Declare
 526         destructor.
 527         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 528         New.
 529         (get_objfile_bfd_data): Use new.  Don't initialize
 530         language_of_main.
 531         (free_objfile_per_bfd_storage): Remove.
 532         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 533
 534 2019-03-15  Tom Tromey  <tom@tromey.com>
 535
 536         * symfile.c (reread_symbols): Update.
 537         * objfiles.c (objfile::objfile): Update.
 538         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 539         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 540         comment.
 541         (minimal_symbol_reader::install): Update.
 542         (terminate_minimal_symbol_table): Remove.
 543         * jit.c (jit_object_close_impl): Update.
 544
 545 2019-03-15  Tom Tromey  <tom@tromey.com>
 546
 547         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 548         initializations.
 549
 550 2019-03-15  Tom Tromey  <tom@tromey.com>
 551
 552         * objfiles.h (struct objfile_per_bfd_storage)
 553         <demangled_hash_languages>: Now a bitset.
 554         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 555         (lookup_minimal_symbol): Update.
 556
 557 2019-03-15  Tom Tromey  <tom@tromey.com>
 558
 559         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 560         Don't return the symbol.
 561         * coffread.c (record_minimal_symbol): Use record_full.
 562
 563 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 564
 565         The MS-Windows port of ncurses fails to switch to a color pair if
 566         one or both of the colors are the implicit default colors.  This
 567         change records the default colors when TUI is initialized, and
 568         then specifies them explicitly when a color pair uses the default
 569         colors.  This allows color styling in TUI mode on MS-Windows.
 570
 571         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 572         ncurses_norm_attr.
 573         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 574         colors in ncurses_norm_attr.
 575         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 576         "none", replace it with the default color recorded in
 577         ncurses_norm_attr.
 578
 579 2019-03-14  Tom Tromey  <tromey@adacore.com>
 580
 581         * source-cache.h (class source_cache) <get_source_lines>: Return
 582         std::string.
 583         * source-cache.c (source_cache::extract_lines): Handle case where
 584         first_pos==npos.  Return std::string.
 585         (source_cache::get_source_lines): Update.
 586
 587 2019-03-14  Tom Tromey  <tromey@adacore.com>
 588
 589         * NEWS: Add item for "style sources" commands.
 590         * source-cache.c (source_cache::get_source_lines): Check
 591         source_styling.
 592         * cli/cli-style.c (source_styling): New global.
 593         (_initialize_cli_style): Add "style sources" commands.
 594         (show_style_sources): New function.
 595         * cli/cli-style.h (source_styling): Declare.
 596
 597 2019-03-14  Pedro Alves  <palves@redhat.com>
 598             Tom Tromey  <tromey@adacore.com>
 599
 600         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 601         * tui/tui-winsource.c (tui_refill_source_window): New function,
 602         from...
 603         (tui_horizontal_source_scroll): ... here.  Move some logic.
 604         * cli/cli-style.c (set_style_enabled): Notify new observable.
 605         * tui/tui-hooks.c (tui_redisplay_source): New function.
 606         (tui_attach_detach_observers): Attach or detach
 607         tui_redisplay_source.
 608         * observable.h (source_styling_changed): New observable.
 609         * observable.c: Define source_styling_changed observable.
 610
 611 2019-03-13  Tom Tromey  <tromey@adacore.com>
 612
 613         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 614         (i386_gnu_nat_target::store_registers): Update.
 615         * target-debug.h (target_debug_print_std_string): New macro.
 616         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 617         * windows-tdep.c (display_one_tib): Update.
 618         * tui/tui-stack.c (tui_make_status_line): Update.
 619         * top.c (print_inferior_quit_action): Update.
 620         * thread.c (thr_try_catch_cmd): Update.
 621         (add_thread_with_info): Update.
 622         (thread_target_id_str): Update.
 623         (thr_try_catch_cmd): Update.
 624         (thread_command): Update.
 625         (thread_find_command): Update.
 626         * record-btrace.c (record_btrace_target::info_record)
 627         (record_btrace_resume_thread, record_btrace_target::resume)
 628         (record_btrace_cancel_resume, record_btrace_step_thread)
 629         (record_btrace_target::wait, record_btrace_target::wait)
 630         (record_btrace_target::wait, record_btrace_target::stop): Update.
 631         * progspace.c (print_program_space): Update.
 632         * process-stratum-target.c
 633         (process_stratum_target::thread_address_space): Update.
 634         * linux-fork.c (linux_fork_mourn_inferior)
 635         (detach_checkpoint_command, info_checkpoints_command)
 636         (linux_fork_context): Update.
 637         (linux_fork_detach): Update.
 638         (class scoped_switch_fork_info): Update.
 639         (delete_checkpoint_command): Update.
 640         * infrun.c (follow_fork_inferior): Update.
 641         (follow_fork_inferior): Update.
 642         (proceed_after_vfork_done): Update.
 643         (handle_vfork_child_exec_or_exit): Update.
 644         (follow_exec): Update.
 645         (displaced_step_prepare_throw): Update.
 646         (displaced_step_restore): Update.
 647         (start_step_over): Update.
 648         (resume_1): Update.
 649         (clear_proceed_status_thread): Update.
 650         (proceed): Update.
 651         (print_target_wait_results): Update.
 652         (do_target_wait): Update.
 653         (context_switch): Update.
 654         (stop_all_threads): Update.
 655         (restart_threads): Update.
 656         (finish_step_over): Update.
 657         (handle_signal_stop): Update.
 658         (switch_back_to_stepped_thread): Update.
 659         (keep_going_pass_signal): Update.
 660         (print_exited_reason): Update.
 661         (normal_stop): Update.
 662         * inferior.c (inferior_pid_to_str): Change return type.
 663         (print_selected_inferior): Update.
 664         (add_inferior): Update.
 665         (detach_inferior): Update.
 666         * dummy-frame.c (fprint_dummy_frames): Update.
 667         * dcache.c (dcache_info_1): Update.
 668         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 669         (btrace_fetch, btrace_clear): Update.
 670         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 671         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 672         type.
 673         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 674         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 675         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 676         * gdbarch.c, gdbarch.h: Rebuild.
 677         * gdbarch.sh (core_pid_to_str): Change return type.
 678         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 679         return type.
 680         (windows_nat_target::pid_to_str): Change return type.
 681         (windows_delete_thread): Update.
 682         (windows_nat_target::attach): Update.
 683         (windows_nat_target::files_info): Update.
 684         * target-delegates.c: Rebuild.
 685         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 686         return type.
 687         (sol_thread_target::pid_to_str): Change return type.
 688         * remote.c (class remote_target) <pid_to_str>: Change return
 689         type.
 690         (remote_target::pid_to_str): Change return type.
 691         (extended_remote_target::attach, remote_target::remote_stop_ns)
 692         (remote_target::remote_notif_remove_queued_reply)
 693         (remote_target::push_stop_reply, remote_target::disable_btrace):
 694         Update.
 695         (extended_remote_target::attach): Update.
 696         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 697         type.
 698         (gdbsim_target::pid_to_str): Change return type.
 699         * ravenscar-thread.c (struct ravenscar_thread_target)
 700         <pid_to_str>: Change return type.
 701         (ravenscar_thread_target::pid_to_str): Change return type.
 702         * procfs.c (class procfs_target) <pid_to_str>: Change return
 703         type.
 704         (procfs_target::pid_to_str): Change return type.
 705         (procfs_target::attach): Update.
 706         (procfs_target::detach): Update.
 707         (procfs_target::fetch_registers): Update.
 708         (procfs_target::store_registers): Update.
 709         (procfs_target::wait): Update.
 710         (procfs_target::files_info): Update.
 711         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 712         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 713         return type.
 714         (nto_procfs_target::pid_to_str): Change return type.
 715         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 716         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 717         return type.
 718         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 719         (exit_lwp): Update.
 720         (attach_proc_task_lwp_callback, get_detach_signal)
 721         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 722         (linux_nat_target::resume, wait_lwp, stop_callback)
 723         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 724         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 725         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 726         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 727         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 728         type.
 729         (inf_ptrace_target::attach): Update.
 730         (inf_ptrace_target::files_info): Update.
 731         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 732         type.
 733         (go32_nat_target::pid_to_str): Change return type.
 734         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 735         (gnu_nat_target::wait): Update.
 736         (gnu_nat_target::wait): Update.
 737         (gnu_nat_target::resume): Update.
 738         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 739         (fbsd_nat_target::wait): Update.
 740         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 741         type.
 742         (darwin_nat_target::attach): Update.
 743         * corelow.c (class core_target) <pid_to_str>: Change return type.
 744         (core_target::pid_to_str): Change return type.
 745         * target.c (normal_pid_to_str): Change return type.
 746         (default_pid_to_str): Likewise.
 747         (target_pid_to_str): Change return type.
 748         (target_translate_tls_address): Update.
 749         (target_announce_detach): Update.
 750         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 751         return type.
 752         (bsd_uthread_target::pid_to_str): Change return type.
 753         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 754         type.
 755         (bsd_kvm_target::pid_to_str): Change return type.
 756         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 757         return type.
 758         (aix_thread_target::pid_to_str): Change return type.
 759         * target.h (struct target_ops) <pid_to_str>: Change return type.
 760         (target_pid_to_str, normal_pid_to_str): Likewise.
 761         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 762         type.
 763         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 764         type.
 765         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 766         return type.
 767         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 768         type.
 769         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 770         type.
 771         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 772         return type.
 773
 774 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 775
 776         * NEWS: Mention that the new default MI version is 3.  Mention
 777         changes to the output of commands and events that deal with
 778         multi-location breakpoints.
 779         * breakpoint.c: Include "mi/mi-out.h".
 780         (print_one_breakpoint): Change output syntax if using MI version
 781         >= 3.
 782         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 783         New.
 784         (mi_multi_location_breakpoint_output_fixed): New.
 785         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 786         (mi_cmd_fix_multi_location_breakpoint_output): New.
 787         (mi_multi_location_breakpoint_output_fixed): New.
 788         * mi/mi-cmds.c (mi_cmds): Register command
 789         -fix-multi-location-breakpoint-output.
 790         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 791         interpreter "mi".
 792
 793 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 794
 795         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 796         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 797         instantiate mi_ui_out based on interpreter name.
 798         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 799         * mi/mi-main.c (mi_load_progress): Likewise.
 800
 801 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 802
 803         * NEWS: Combine separate "New targets" sections for 8.3.
 804
 805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 806
 807         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 808         (ppcfbsd_init_abi): Install gdbarch
 809         "fetch_tls_load_module_address" and "get_thread_local_address"
 810         methods.
 811
 812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 813
 814         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 815         (riscv_fbsd_init_abi): Install gdbarch
 816         "fetch_tls_load_module_address" and "get_thread_local_address"
 817         methods.
 818
 819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 820
 821         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 822         (i386fbsd_init_abi): Install gdbarch
 823         "fetch_tls_load_module_address" and "get_thread_local_address"
 824         methods.
 825
 826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 827
 828         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 829         (amd64fbsd_init_abi): Install gdbarch
 830         "fetch_tls_load_module_address" and "get_thread_local_address"
 831         methods.
 832
 833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 834
 835         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 836         (struct fbsd_pspace_data): New type.
 837         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 838         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 839         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 840         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 841         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 842
 843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 844
 845         * gdbtypes.c (lookup_struct_elt): New function.
 846         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 847         * gdbtypes.h (struct struct_elt): New type.
 848         (lookup_struct_elt): New prototype.
 849
 850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 851
 852         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 853         remove disabled code block.
 854
 855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 856
 857         * gdbarch.sh (get_thread_local_address): New method.
 858         * gdbarch.h, gdbarch.c: Regenerate.
 859         * target.c (target_translate_tls_address): Use
 860         gdbarch_get_thread_local_address if present instead of
 861         target::get_thread_local_address.
 862
 863 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 864
 865         * target.h (target::get_thread_local_address): Update comment.
 866
 867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 868
 869         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 870         objfile->separate_debug_objfile_backlink if not NULL.
 871
 872 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 873
 874         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 875         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 876         (amd64bsd_store_inferior_registers): Likewise.
 877         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 878         Enable segment base registers.
 879         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 880         PT_GETFSBASE and PT_GETGSBASE.
 881         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 882         PT_SETGSBASE.
 883         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 884         segment base registers.
 885         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 886
 887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 888
 889         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 890         Update calls to i386_target_description to add 'segments'
 891         parameter.
 892         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 893         add segment base registers.
 894         * arch/i386.c (i386_create_target_description): Add 'segments'
 895         parameter to enable segment base registers.
 896         * arch/i386.h (i386_create_target_description): Likewise.
 897         * features/i386/32bit-segments.xml: New file.
 898         * features/i386/32bit-segments.c: Generate.
 899         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 900         call to i386_target_description to add 'segments' parameter.
 901         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 902         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 903         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 904         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 905         if feature is present.
 906         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 907         Add 'segments' parameter to call to i386_target_description.
 908         (i386_target_description): Add 'segments' parameter to enable
 909         segment base registers.
 910         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 911         to call to i386_target_description.
 912         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 913         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 914         Define I386_NUM_REGS.
 915         (i386_target_description): Add 'segments' parameter to enable
 916         segment base registers.
 917
 918 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 919
 920         PR/24325
 921         * source-cache.c: #undef open and close, to avoid unresolved
 922         externals during linking.
 923
 924 2019-03-12  Tom Tromey  <tromey@adacore.com>
 925
 926         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 927         const.  Add initializers.
 928         (_initialize_remote): Don't initialize ptid globals.
 929
 930 2019-03-12  Pedro Alves  <palves@redhat.com>
 931
 932         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 933
 934 2019-03-12  Pedro Alves  <palves@redhat.com>
 935
 936         * cp-name-parser.y (main): Remove unused 'len' variable.
 937
 938 2019-03-12  Tom Tromey  <tromey@adacore.com>
 939
 940         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 941         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 942
 943 2019-03-12  Tom Tromey  <tromey@adacore.com>
 944
 945         * linux-nat.c (iterate_over_lwps): Update.
 946         (stop_callback): Remove parameter.
 947         (stop_wait_callback, detach_callback, resume_set_callback)
 948         (select_singlestep_lwp_callback, set_ignore_sigint)
 949         (status_callback, resumed_callback, resume_clear_callback)
 950         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 951         data parameter.
 952         (linux_nat_target::detach, linux_nat_target::resume)
 953         (linux_stop_and_wait_all_lwps, select_event_lwp)
 954         (linux_nat_filter_event, linux_nat_wait_1)
 955         (linux_nat_target::kill, linux_nat_target::stop)
 956         (linux_nat_target::stop): Update.
 957         (linux_nat_resume_callback): Change type.
 958         (resume_stopped_resumed_lwps, count_events_callback)
 959         (select_event_lwp_callback): Likewise.
 960         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 961         * arm-linux-nat.c (struct update_registers_data): Remove.
 962         (update_registers_callback): Change type.
 963         (arm_linux_insert_hw_breakpoint1): Update.
 964         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 965         parameter.
 966         (x86_linux_dr_set_addr): Update.
 967         (x86_linux_dr_set_control): Update.
 968         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 969         (iterate_over_lwps): Use gdb::function_view.
 970         * nat/aarch64-linux-hw-point.c (struct
 971         aarch64_dr_update_callback_param): Remove.
 972         (debug_reg_change_callback): Change type.
 973         (aarch64_notify_debug_reg_change): Update.
 974         * s390-linux-nat.c (s390_refresh_per_info): Update.
 975
 976 2019-03-11  Tom Tromey  <tromey@adacore.com>
 977
 978         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 979         redundant assignment to "this_cu".
 980
 981 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 982
 983         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 984
 985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 986
 987         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 988         from...
 989         (rank_one_type): ... this.
 990
 991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 992
 993         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 994         from...
 995         (rank_one_type): ... this.
 996
 997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 998
 999         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1000         from...
1001         (rank_one_type): ... this.
1002
1003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1004
1005         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1006         from...
1007         (rank_one_type): ... this.
1008
1009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1010
1011         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1012         from...
1013         (rank_one_type): ... this.
1014
1015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1016
1017         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1018         from...
1019         (rank_one_type): ... this.
1020
1021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1022
1023         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1024         from...
1025         (rank_one_type): ... this.
1026
1027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1028
1029         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1030         from...
1031         (rank_one_type): ... this.
1032
1033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1034
1035         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1036         from...
1037         (rank_one_type): ... this.
1038
1039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1040
1041         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1042         from...
1043         (rank_one_type): ... this.
1044
1045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1046
1047         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1048         from...
1049         (rank_one_type): ... this.
1050
1051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1052
1053         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1054         from...
1055         (rank_one_type): ... this.
1056
1057 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1060         inferior-events' shows the example events.
1061
1062 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1063
1064         Support styling on native MS-Windows console
1065
1066         PR/24315
1067         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1068         on MS-Windows if $TERM is not defined.
1069
1070         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1071
1072         * posix-hdep.c (gdb_console_fputs):
1073         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1074         functions.
1075         * ui-file.h (gdb_console_fputs): Add prototype.
1076
1077         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1078         back to fputs only if the former returns zero.
1079
1080 2019-03-07  Tom Tromey  <tom@tromey.com>
1081
1082         * symmisc.c (print_symbol_bcache_statistics): Update.
1083         (print_objfile_statistics): Update.
1084         * symfile.c (allocate_symtab): Update.
1085         * stabsread.c: Don't include bcache.h.
1086         * psymtab.h (struct psymbol_bcache): Don't declare.
1087         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1088         (psymbol_bcache_init, psymbol_bcache_free)
1089         (psymbol_bcache_get_bcache): Don't declare.
1090         * psymtab.c (struct psymbol_bcache): Remove.
1091         (psymtab_storage::psymtab_storage): Update.
1092         (psymtab_storage::~psymtab_storage): Update.
1093         (psymbol_bcache_init, psymbol_bcache_free)
1094         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1095         (add_psymbol_to_bcache): Update.
1096         (allocate_psymtab): Update.
1097         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1098         macro_cache>: No longer pointers.
1099         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1100         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1101         * macrotab.c (macro_bcache): Update.
1102         * macroexp.c: Don't include bcache.h.
1103         * gdbtypes.c (check_types_worklist): Update.
1104         (types_deeply_equal): Remove TRY/CATCH.  Update.
1105         * elfread.c (elf_symtab_read): Update.
1106         * dwarf2read.c: Don't include bcache.h.
1107         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1108         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1109         (print_bcache_statistics, bcache_memory_used): Don't declare.
1110         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1111         methods.  Rename all data members.
1112         * bcache.c (struct bcache): Move to bcache.h.
1113         (bcache::expand_hash_table): Rename from expand_hash_table.
1114         (bcache): Remove.
1115         (bcache::insert): Rename from bcache_full.
1116         (bcache::compare): Rename from bcache_compare.
1117         (bcache_xmalloc): Remove.
1118         (bcache::~bcache): Rename from bcache_xfree.
1119         (bcache::print_statistics): Rename from print_bcache_statistics.
1120         (bcache::memory_used): Rename from bcache_memory_used.
1121
1122 2019-03-07  Pedro Alves  <palves@redhat.com>
1123
1124         * infrun.c (normal_stop): Also check for
1125         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1126
1127 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1128
1129         * f-lang.c (value_from_host_double): Moved to...
1130         * value.c (value_from_host_double): ...here.
1131         * value.h (value_from_host_double): Declare.
1132         * guile/scm-math.c (vlscm_convert_typed_number): Use
1133         value_from_host_double.
1134         (vlscm_convert_number): Likewise.
1135         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1136         * python/py-value.c (convert_value_from_python): Likewise.
1137
1138 2019-03-06  Tom Tromey  <tom@tromey.com>
1139
1140         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1141
1142 2019-03-06  Tom Tromey  <tom@tromey.com>
1143
1144         * utils.h (free_current_contents): Don't declare.
1145         * utils.c (free_current_contents): Remove.
1146
1147 2019-03-06  Tom Tromey  <tom@tromey.com>
1148
1149         * top.c (quit_force): Update.
1150         * main.c (captured_command_loop): Update.
1151         * common/new-op.c (operator new): Update.
1152         * common/common-exceptions.c (struct catcher)
1153         <save_cleanup_chain>: Remove member.
1154         (exceptions_state_mc_init): Update.
1155         (exception_try_scope_entry): Return nullptr.
1156         (exception_try_scope_exit, exception_rethrow)
1157         (throw_exception_sjlj, throw_exception_cxx): Update.
1158         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1159         (all_cleanups, do_cleanups, discard_cleanups)
1160         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1161         (restore_cleanups, restore_final_cleanups): Don't declare.
1162         (do_final_cleanups): Remove parameter.
1163         * common/cleanups.c (cleanup_chain, make_cleanup)
1164         (make_cleanup_dtor, all_cleanups, do_cleanups)
1165         (discard_my_cleanups, discard_cleanups)
1166         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1167         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1168         (null_cleanup): Remove.
1169         (do_final_cleanups): Remove parameter.
1170
1171 2019-03-06  Tom Tromey  <tom@tromey.com>
1172
1173         * remote.c (remote_target::remote_parse_stop_reply): Use
1174         unique_xmalloc_ptr.
1175
1176 2019-03-06  Tom Tromey  <tom@tromey.com>
1177
1178         * stabsread.c (struct stabs_field_info): Rename from field_info.
1179         <list, fnlist>: Add initializers.
1180         <obstack>: New member.
1181         (read_member_functions, read_struct_fields, read_baseclasses):
1182         Allocate on obstack.  Don't use cleanups.
1183         (read_one_struct_field, read_member_functions, read_struct_fields)
1184         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1185         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1186         (read_struct_type): Update.
1187
1188 2019-03-06  Tom Tromey  <tom@tromey.com>
1189
1190         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1191         * common/filestuff.h (make_cleanup_close): Don't declare.
1192         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1193         Remove.
1194
1195 2019-03-06  Tom Tromey  <tom@tromey.com>
1196
1197         * solib-aix.c: Use make_scope_exit.
1198
1199 2019-03-06  Tom Tromey  <tom@tromey.com>
1200
1201         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1202         Use make_scope_exit.
1203
1204 2019-03-06  Tom Tromey  <tom@tromey.com>
1205
1206         * solib-svr4.c (disable_probes_interface): Remove parameter.
1207         (svr4_handle_solib_event): Use make_scope_exit.
1208
1209 2019-03-06  Tom Tromey  <tom@tromey.com>
1210
1211         * remote.c (struct stop_reply_deleter): Remove.
1212         (stop_reply_up): Update.
1213         (struct stop_reply): Derive from notif_event.  Don't typedef.
1214         <regcache>: Now a std::vector.
1215         (stop_reply_xfree): Remove.
1216         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1217         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1218         (remote_target::discard_pending_stop_replies): Use delete.
1219         (remote_target::remote_parse_stop_reply): Update.
1220         (remote_target::process_stop_reply): Update.
1221         * remote-notif.h (struct notif_event): Add virtual destructor.
1222         Remove "dtr" member.
1223         (struct notif_client) <alloc_event>: Return a unique_ptr.
1224         (notif_event_xfree): Don't declare.
1225         (notif_event_up): New typedef.
1226         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1227         (notif_event_xfree, do_notif_event_xfree): Remove.
1228         (remote_notif_state_xfree): Update.
1229
1230 2019-03-06  Tom Tromey  <tom@tromey.com>
1231
1232         * infrun.c (displaced_step_clear_cleanup): Now a
1233         forward_scope_exit type.
1234         (displaced_step_prepare_throw): Update.
1235         (displaced_step_fixup): Update.
1236
1237 2019-03-06  Tom Tromey  <tom@tromey.com>
1238
1239         * inferior.h (class inferior): Update comment.
1240         * gdbthread.h (class thread_info): Update comment.
1241
1242 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1243             Tom Tromey  <tom@tromey.com>
1244
1245         * stabsread.h (struct stab_section_list): Remove.
1246         (coffstab_build_psymtabs): Update.
1247         * dbxread.c (symbuf_sections): Now a std::vector.
1248         (sect_idx): New global.
1249         (fill_symbuf): Update.
1250         (coffstab_build_psymtabs): Change type of stabsects parameter.
1251         Update.
1252         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1253         std::vector.
1254         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1255         (coff_locate_sections): Update.
1256         (coff_symfile_read): Remove cleanups.  Update.
1257         (init_stringtab): Add storage parameter.
1258         (free_stringtab, free_stringtab_cleanup): Remove.
1259         (init_lineno): Add storage parameter.
1260         (free_linetab, free_linetab_cleanup): Remove.
1261
1262 2019-03-06  Pedro Alves  <palves@redhat.com>
1263
1264         * linux-fork.c (fork_info::clobber_regs): Delete.
1265         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1266         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1267         comment.  Adjust.
1268         (scoped_switch_fork_info::scoped_switch_fork_info)
1269         (checkpoint_command, linux_fork_context): Adjust
1270         fork_save_infrun_state calls.
1271
1272 2019-03-06  Pedro Alves  <palves@redhat.com>
1273
1274         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1275         (inf_has_multiple_threads): Return 'bool' and rewrite using
1276         inferior_info::threads().
1277
1278 2019-03-06  Pedro Alves  <palves@redhat.com>
1279
1280         * linux-fork.c: Include <list>.
1281         (fork_list): Now a std::list instance.
1282         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1283         (forks_exist_p, find_last_fork): Adjust.
1284         (new_fork): Delete.
1285         (one_fork_p): New.
1286         (add_fork): Adjust.
1287         (free_fork): Delete, folded into fork_info::~fork_info().
1288         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1289         Adjust.
1290         (init_fork_list): Delete.
1291         (linux_fork_killall, linux_fork_mourn_inferior)
1292         (linux_fork_detach, info_checkpoints_command): Adjust.
1293         (_initialize_linux_fork): No longer call init_fork_list.
1294
1295 2019-03-06  Pedro Alves  <palves@redhat.com>
1296
1297         * linux-fork.c (new_fork): New, split out of ...
1298         (add_fork): ... this.  Return void.  Move "first fork" special
1299         case from here, to ...
1300         (checkpoint_command): ... here.
1301         * linux-linux.h (add_fork): Return void.
1302
1303 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1306
1307 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1308             Chris January  <chris.january@arm.com>
1309             David Lecomber  <david.lecomber@arm.com>
1310
1311         * f-exp.y: New token, UNOP_INTRINSIC.
1312         (exp): New pattern using UNOP_INTRINSIC token.
1313         (f77_keywords): Add 'abs' keyword.
1314         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1315         (value_from_host_double): New function.
1316         (evaluate_subexp_f): Support UNOP_ABS.
1317
1318 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1321         types.
1322
1323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1326         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1327         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1328
1329 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1332
1333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1334             Chris January  <chris.january@arm.com>
1335
1336         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1337         * f-exp.y: Define 'KIND' token.
1338         (exp): New pattern for KIND expressions.
1339         (ptype): Handle types with a kind extension.
1340         (direct_abs_decl): Extend to spot kind extensions.
1341         (f77_keywords): Add 'kind' to the list.
1342         (push_kind_type): New function.
1343         (convert_to_kind_type): New function.
1344         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1345         * parse.c (operator_length_standard): Likewise.
1346         * parser-defs.h (enum type_pieces): Add tp_kind.
1347         * std-operator.def: Add UNOP_KIND.
1348
1349 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1350
1351         * f-exp.y (f_parse): Set yydebug.
1352
1353 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * f-lang.c (evaluate_subexp_f): New function.
1356         (exp_descriptor_f): New global.
1357         (f_language_defn): Use exp_descriptor_f instead of
1358         exp_descriptor_standard.
1359
1360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * f-exp.y (struct token): Add comments.
1363         (dot_ops): Remove uppercase versions and the end marker.
1364         (f77_keywords): Likewise.
1365         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1366         entries in the dot_ops array are case insensitive, and use
1367         strncasecmp to compare strings.  Also some whitespace cleanup in
1368         this area.  Similar for the f77_keywords array, except entries in
1369         this list might be case sensitive.
1370
1371 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * f-exp.y (struct f77_boolean_val): Add comments.
1374         (boolean_values): Remove uppercase versions, and end marker.
1375         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1376         and use strncasecmp to achieve case insensitivity.  Additionally,
1377         perform whitespace cleanup around this code.
1378
1379 2019-03-06  Tom Tromey  <tromey@adacore.com>
1380
1381         * remote-sim.c (gdbsim_target_open): Use result of
1382         gdb_argv::release.
1383
1384 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1385         Dirk Schubert  <dirk.schubert@arm.com>
1386         Chris January  <chris.january@arm.com>
1387
1388         * eval.c (evaluate_subexp_standard): Call Fortran argument
1389         wrapping logic.
1390         * f-lang.c (struct value): A value which can be passed into a
1391         Fortran function call.
1392         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1393         where appropriate.
1394         (struct type): Value ready for a Fortran function call.
1395         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1396         is needed.
1397         * f-lang.h (fortran_argument_convert): Declaration.
1398         (fortran_preserve_arg_pointer): Declaration.
1399         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1400
1401 2019-03-05  Tom Tromey  <tromey@adacore.com>
1402
1403         * python/py-prettyprint.c (print_string_repr): Remove #if.
1404         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1405
1406 2019-03-05  Tom Tromey  <tromey@adacore.com>
1407
1408         * target.c (the_dummy_target): Move later.  Change type to
1409         "dummy_target".
1410         (initialize_targets): Don't initialize the_dummy_target.
1411
1412 2019-03-05  Tom Tromey  <tromey@adacore.com>
1413
1414         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1415         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1416
1417 2019-03-05  Tom Tromey  <tromey@adacore.com>
1418
1419         * windows-nat.c (windows_nat_target::attach)
1420         (windows_nat_target::detach): Don't call gdb_flush.
1421         * valprint.c (generic_val_print, val_print, val_print_string):
1422         Don't call gdb_flush.
1423         * utils.c (defaulted_query): Don't call gdb_flush.
1424         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1425         * target.c (target_announce_detach): Don't call gdb_flush.
1426         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1427         * remote.c (extended_remote_target::attach): Don't call
1428         gdb_flush.
1429         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1430         * printcmd.c (do_examine): Don't call gdb_flush.
1431         (info_display_command): Don't call gdb_flush.
1432         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1433         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1434         * memattr.c (info_mem_command): Don't call gdb_flush.
1435         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1436         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1437         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1438         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1439         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1440         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1441         (gnu_nat_target::detach): Don't call gdb_flush.
1442         * f-valprint.c (f_val_print): Don't call gdb_flush.
1443         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1444         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1445         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1446         gdb_flush.
1447         * c-valprint.c (c_val_print): Don't call gdb_flush.
1448         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1449
1450 2019-03-05  Tom Tromey  <tromey@adacore.com>
1451
1452         * varobj.c (update_dynamic_varobj_children): Update.
1453         (install_default_visualizer): Use reset, not release.
1454         * value.c (set_internalvar): Update.
1455         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1456         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1457         ATTRIBUTE_UNUSED_RESULT.
1458
1459 2019-03-05  Tom Tromey  <tromey@adacore.com>
1460
1461         * remote.c (class scoped_remote_fd) <release>: Add
1462         ATTRIBUTE_UNUSED_RESULT.
1463
1464 2019-03-05  Tom Tromey  <tromey@adacore.com>
1465
1466         * macroexp.c (struct macro_buffer) <release>: Add
1467         ATTRIBUTE_UNUSED_RESULT.
1468
1469 2019-03-05  Tom Tromey  <tromey@adacore.com>
1470
1471         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1472         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1473         ATTRIBUTE_UNUSED_RESULT.
1474
1475 2019-03-05  Tom Tromey  <tromey@adacore.com>
1476
1477         * common/scoped_fd.h (class scoped_fd) <release>: Add
1478         ATTRIBUTE_UNUSED_RESULT.
1479
1480 2019-03-05  Tom Tromey  <tromey@adacore.com>
1481
1482         * parser-defs.h (struct parser_state) <release>: Add
1483         ATTRIBUTE_UNUSED_RESULT.
1484
1485 2019-03-05  Tom Tromey  <tromey@adacore.com>
1486
1487         * utils.h (class gdb_argv) <release>: Add
1488         ATTRIBUTE_UNUSED_RESULT.
1489         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1490
1491 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1492
1493         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1494         for-loop range, to avoid compiler warnings.
1495
1496         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1497         avoid compiler warnings about unused variables.
1498
1499         * NEWS: Mention end of support for native debugging on MS-Windows
1500         before XP.
1501
1502         PR gdb/24292
1503         * common/netstuff.c:
1504         * gdbserver/gdbreplay.c
1505         * gdbserver/remote-utils.c:
1506         * ser-tcp.c:
1507         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1508         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1509         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1510         'getaddrinfo' and 'freeaddrinfo' were not available before
1511         Windows XP, and mingw.org's MinGW headers by default define
1512         _WIN32_WINNT to 0x500.
1513
1514 2019-03-01  Gary Benson <gbenson@redhat.com>
1515
1516         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1517
1518 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1519             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1520
1521         PR gdb/8527
1522         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1523         set_sigint_trap, clear_sigint_trap.
1524
1525 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1526
1527         * target.c (target_detach): Clear the regcache and the
1528         frame cache.
1529
1530 2019-02-27  Pedro Alves  <palves@redhat.com>
1531
1532         * utils.c (set_screen_size): When we cap the height/width sizes,
1533         tweak the corresponding command variable to show "unlimited":
1534
1535 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1536             Pedro Alves  <palves@redhat.com>
1537
1538         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1539         before calling rl_set_screen_size.
1540
1541 2019-02-27  Tom Tromey  <tromey@adacore.com>
1542
1543         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1544         define.
1545         * python/py-value.c: Remove Python 2.4 workaround.
1546         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1547         workaround.
1548         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1549         Python 2.4 workaround.
1550         * python/python-internal.h: Remove Python 2.4 comment.
1551         (Py_ssize_t): Don't define.
1552         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1553         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1554         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1555         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1556         * python/python.c (do_start_initialization): Remove Python 2.4
1557         workaround.
1558         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1559         (print_children): Remove Python 2.4 workaround.
1560         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1561         workaround.
1562         (CHARBUFFERPROC_NAME): Remove.
1563         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1564         Python 2.4 workaround.
1565
1566 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1567
1568         * NEWS: Note minimum Python version.
1569
1570 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1571
1572         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1573         code from these functions.  Remove corresponding ifdefs.  Use
1574         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1575         Remove gotos and target of gotos.
1576         (infpy_search_memory): Likewise.
1577
1578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1579
1580         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1581         (hppa_gdbarch_init): Don't register deleted functions with
1582         gdbarch.
1583
1584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1587         (h8300_unwind_sp): Delete.
1588         (h8300_dummy_id): Delete.
1589         (h8300_gdbarch_init): Don't register deleted functions with
1590         gdbarch.
1591
1592 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1593
1594         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1595         (ft32_unwind_pc): Delete.
1596         (ft32_unwind_sp): Delete.
1597         (ft32_gdbarch_init): Don't register deleted functions with
1598         gdbarch.
1599
1600 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1603         (frv_unwind_pc): Delete.
1604         (frv_unwind_sp): Delete.
1605         (frv_gdbarch_init): Don't register deleted functions with
1606         gdbarch.
1607
1608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1611         (riscv_unwind_pc): Delete.
1612         (riscv_unwind_sp): Delete.
1613         (riscv_gdbarch_init): Don't register deleted functions with
1614         gdbarch.
1615
1616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1617
1618         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1619         (csky_unwind_pc): Delete.
1620         (csky_unwind_sp): Delete.
1621         (csky_gdbarch_init): Don't register deleted functions with
1622         gdbarch.
1623
1624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1625
1626         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1627         (cris_unwind_pc): Delete.
1628         (cris_unwind_sp): Delete.
1629         (cris_gdbarch_init): Don't register deleted functions with
1630         gdbarch.
1631
1632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1633
1634         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1635         (bfin_unwind_pc): Delete.
1636         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1637
1638 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1639
1640         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1641         (arm_unwind_pc): Delete.
1642         (arm_unwind_sp): Delete.
1643         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1644
1645 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1646
1647         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1648         (arc_unwind_pc): Delete.
1649         (arc_unwind_sp): Delete.
1650         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1651
1652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1655         (alpha_unwind_pc): Delete.
1656         (alpha_gdbarch_init): Don't register deleted functions with
1657         gdbarch.
1658
1659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1662         (aarch64_unwind_pc): Delete.
1663         (aarch64_unwind_sp): Delete.
1664         (aarch64_gdbarch_init): Don't register deleted functions with
1665         gdbarch.
1666
1667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1668
1669         * gdbtypes.c (type_align): Don't consider static members when
1670         computing structure alignment.
1671
1672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1673
1674         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1675         return 0 for other types.
1676         * arch-utils.c (default_type_align): Always return 0.
1677         * gdbarch.h: Regenerate.
1678         * gdbarch.sh (type_align): Extend comment.
1679         * gdbtypes.c (type_align): Add additional comments, always call
1680         gdbarch_type_align before applying the default rules.
1681         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1682         generic code will then apply a suitable default.
1683         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1684         types, return 0 for other types.
1685
1686 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1687
1688         * NEWS: Create a new section for the next release branch.
1689         Rename the section of the current branch, now that it has
1690         been cut.
1691
1692 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1693
1694         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1695         * version.in: Bump version to 8.3.50.DATE-git.
1696
1697 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1698
1699         * aix-thread.c (ptid_cmp): Remove unused variable.
1700         (get_signaled_thread): Likewise.
1701         (store_regs_user_thread): Likewise.
1702         (store_regs_kernel_thread): Likewise.
1703         (fetch_regs_kernel_thread): Remove shadowed variable.
1704
1705 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1706
1707         * features/riscv/32bit-cpu.xml: Add register numbers.
1708         * features/riscv/32bit-fpu.c: Regenerate.
1709         * features/riscv/32bit-fpu.xml: Add register numbers.
1710         * features/riscv/64bit-cpu.xml: Add register numbers.
1711         * features/riscv/64bit-fpu.c: Regenerate.
1712         * features/riscv/64bit-fpu.xml: Add register numbers.
1713
1714 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1715
1716         * NEWS: Mention two argument form of gdb.Value constructor.
1717         * python/py-value.c (convert_buffer_and_type_to_value): New
1718         function.
1719         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1720         Add support for handling an optional second argument.  Call
1721         convert_buffer_and_type_to_value as appropriate.
1722         * python/python-internal.h (Py_buffer_deleter): New struct.
1723         (Py_buffer_up): New typedef.
1724
1725 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1726
1727         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1728         instead of releasing ownership.
1729
1730 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1731
1732         * dwarf2read.c (open_and_init_dwp_file): Call
1733         elf_numsections instead of bfd_count_sections to initialize
1734         dwp_file->num_sections.
1735
1736 2019-02-25  Tom Tromey  <tromey@adacore.com>
1737
1738         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1739
1740 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1741
1742         * gcore.in: Add '--readnever' option when invoking GDB.
1743
1744 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1745
1746         * MAINTAINERS: Update my email address.
1747
1748 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1749
1750         * build-id.c (build_id_to_debug_bfd_1): New function.
1751         (build_id_to_debug_bfd): Look for separate debug file in
1752         sysroot.
1753
1754 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1755
1756         * gdbarch.sh: Update the copyright year range that is placed into
1757         generated files.
1758
1759 2019-02-22  Keith Seitz  <keiths@redhat.com>
1760
1761         PR symtab/23853
1762         * linespec.c (create_sals_line_offset): Search for the default
1763         symtab's filename instead of its fullname.
1764
1765 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1766
1767         * NEWS: Update style defaults.
1768
1769 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1770
1771         * main.c (captured_main_1): Disable styling in batch mode.
1772
1773 2019-02-20  Tom Tromey  <tom@tromey.com>
1774
1775         * symtab.c (symtab_symbol_info): Fix typos.
1776
1777 2019-02-20  Tom Tromey  <tromey@adacore.com>
1778
1779         * findcmd.c (_initialize_mem_search): Use upper case for
1780         metasyntactic variables.
1781
1782 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1783
1784         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1785         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1786
1787 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1788
1789         * top.h (source_file_name): Change to std::string.
1790         * top.c (source_file_name): Likewise.
1791         (command_line_input): Adjust.
1792         * cli/cli-script.c (script_from_file): Adjust.
1793
1794 2019-02-19  Tom Tromey  <tromey@adacore.com>
1795
1796         * ravenscar-thread.c
1797         (ravenscar_thread_target::update_thread_list): Don't call
1798         ada_build_task_list.
1799         * ada-lang.h (ada_build_task_list): Don't declare.
1800         * ada-tasks.c (struct ada_tasks_inferior_data)
1801         <task_list_valid_p>: Now bool.
1802         (read_known_tasks, ada_task_list_changed)
1803         (ada_tasks_invalidate_inferior_data): Update.
1804         (read_known_tasks_array): Return bool.
1805         (read_known_tasks_list): Likewise.
1806         (read_known_tasks): Return void.
1807         (ada_build_task_list): Now static.
1808
1809 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1810
1811         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1812         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1813
1814 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1815
1816         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1817         variant for ada_tasks_pspace_data_handle and
1818         ada_tasks_inferior_data_handle.
1819         (ada_tasks_pspace_data_cleanup): New function.
1820         (ada_tasks_inferior_data_cleanup): New function.
1821
1822 2019-02-17  Tom Tromey  <tom@tromey.com>
1823
1824         * macrotab.h (macro_source_fullname): Return a std::string.
1825         * macrotab.c (macro_include, check_for_redefinition)
1826         (macro_undef, macro_lookup_definition, foreach_macro)
1827         (foreach_macro_in_scope): Update.
1828         (macro_source_fullname): Return a std::string.
1829         * macrocmd.c (show_pp_source_pos): Update.
1830
1831 2019-02-17  Tom Tromey  <tom@tromey.com>
1832
1833         * macrocmd.c (show_pp_source_pos): Style the file names.
1834
1835 2019-02-17  Tom Tromey  <tom@tromey.com>
1836
1837         PR tui/24197:
1838         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1839
1840 2019-02-17  Tom Tromey  <tom@tromey.com>
1841
1842         * ada-lang.c (user_select_syms): Use filtered printing.
1843         * utils.c (wrap_style): New global.
1844         (desired_style): Remove.
1845         (emit_style_escape): Add stream parameter.
1846         (set_output_style, reset_terminal_style, prompt_for_continue):
1847         Update.
1848         (flush_wrap_buffer): Only flush gdb_stdout.
1849         (wrap_here): Set wrap_style.
1850         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1851         treat escape sequences as a character.  Change when wrap buffer is
1852         flushed.
1853         (fputs_styled): Do not set the output style when the default is
1854         requested.
1855         * ui-style.h (struct ui_file_style) <is_default>: New method.
1856         * source.c (print_source_lines_base): Emit escape sequences in one
1857         piece.
1858
1859 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1860
1861         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1862         integers and enumeration types.
1863
1864 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1865
1866         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1867         instead of lookup_symbol_in_language
1868         (do_exact_match): New function.
1869         (ada_get_symbol_name_matcher): Return do_exact_match when
1870         doing a verbatim match.
1871
1872 2019-02-15  Tom Tromey  <tromey@adacore.com>
1873
1874         * ravenscar-thread.c (ravenscar_thread_target::resume)
1875         (ravenscar_thread_target::wait): Special case wildcard requests.
1876
1877 2019-02-15  Tom Tromey  <tromey@adacore.com>
1878
1879         * ravenscar-thread.c (base_ptid): Remove.
1880         (struct ravenscar_thread_target) <close>: New method.
1881         <m_base_ptid>: New member.
1882         <update_inferior_ptid, active_task, task_is_currently_active,
1883         runtime_initialized>: Declare methods.
1884         <ravenscar_thread_target>: Add constructor.
1885         (ravenscar_thread_target::task_is_currently_active)
1886         (ravenscar_thread_target::update_inferior_ptid)
1887         (ravenscar_runtime_initialized): Rename.  Now methods.
1888         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1889         (ravenscar_thread_target::update_thread_list): Update.
1890         (ravenscar_thread_target::active_task): Now method.
1891         (ravenscar_thread_target::store_registers)
1892         (ravenscar_thread_target::prepare_to_store)
1893         (ravenscar_thread_target::prepare_to_store)
1894         (ravenscar_thread_target::mourn_inferior): Update.
1895         (ravenscar_inferior_created): Use "new" to create target.
1896         (ravenscar_thread_target::get_ada_task_ptid): Update.
1897         (_initialize_ravenscar): Don't initialize base_ptid.
1898         (ravenscar_ops): Remove global.
1899
1900 2019-02-15  Tom Tromey  <tromey@adacore.com>
1901
1902         * target.h (push_target): Declare new overload.
1903         * target.c (push_target): New overload, taking an rvalue reference.
1904         * remote.c (remote_target::open_1): Use push_target overload.
1905         * corelow.c (core_target_open): Use push_target overload.
1906
1907 2019-02-15  Tom Tromey  <tromey@adacore.com>
1908
1909         * ravenscar-thread.c (is_ravenscar_task)
1910         (ravenscar_task_is_currently_active): Return bool.
1911         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1912         (_initialize_ravenscar): Remove "(void)".
1913         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1914         Return bool.
1915
1916 2019-02-15  Tom Tromey  <tromey@adacore.com>
1917
1918         * ravenscar-thread.c (ravenscar_runtime_initializer)
1919         (has_ravenscar_runtime, get_running_thread_id)
1920         (ravenscar_thread_target::resume): Fix indentation.
1921
1922 2019-02-15  Tom Tromey  <tromey@adacore.com>
1923
1924         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1925         from ravenscar_arch_ops.
1926         (sparc_ravenscar_ops::fetch_registers)
1927         (sparc_ravenscar_ops::store_registers): Now methods.
1928         (sparc_ravenscar_prepare_to_store): Remove.
1929         (sparc_ravenscar_ops): Redefine.
1930         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1931         methods and destructor.  Remove members.
1932         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1933         (ravenscar_thread_target::store_registers)
1934         (ravenscar_thread_target::prepare_to_store): Update.
1935         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1936         Remove.
1937         (struct ppc_ravenscar_powerpc_ops): Derive from
1938         ravenscar_arch_ops.
1939         (ppc_ravenscar_powerpc_ops::fetch_registers)
1940         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1941         (ppc_ravenscar_powerpc_ops): Redefine.
1942         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1943         (ppc_ravenscar_e500_ops::fetch_registers)
1944         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1945         (ppc_ravenscar_e500_ops): Redefine.
1946         * aarch64-ravenscar-thread.c
1947         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1948         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1949         (aarch64_ravenscar_fetch_registers)
1950         (aarch64_ravenscar_store_registers): Now methods.
1951         (aarch64_ravenscar_ops): Redefine.
1952
1953 2019-02-15  Tom Tromey  <tromey@adacore.com>
1954
1955         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1956         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1957         (ravenscar_thread_target::stopped_by_watchpoint)
1958         (ravenscar_thread_target::stopped_data_address)
1959         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1960
1961 2019-02-15  Tom Tromey  <tromey@adacore.com>
1962
1963         * ravenscar-thread.c: Fix some typos.
1964
1965 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1966             Tom Tromey  <tromey@adacore.com>
1967
1968         * ada-lang.c (ada_exception_sal): Change addr_string to a
1969         std::string.
1970         (create_ada_exception_catchpoint): Update.
1971
1972 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1973             Tom Tromey  <tromey@adacore.com>
1974
1975         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1976         (bp_location_ops): Remove.
1977         (base_breakpoint_allocate_location): Update.
1978         (free_bp_location): Update.
1979         * ada-lang.c (class ada_catchpoint_location)
1980         <ada_catchpoint_location>: Remove ops parameter.
1981         (ada_catchpoint_location_dtor): Remove.
1982         (ada_catchpoint_location_ops): Remove.
1983         (allocate_location_exception): Update.
1984         * breakpoint.h (struct bp_location_ops): Remove.
1985         (class bp_location) <bp_location>: Remove bp_location_ops
1986         parameter.
1987         <~bp_location>: Add destructor.
1988         <ops>: Remove.
1989
1990 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1991             Pedro Alves  <palves@redhat.com>
1992
1993         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1994         'PATH_MAX'.
1995
1996 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1997             Samuel Thibault  <samuel.thibault@gnu.org>
1998             Thomas Schwinge  <thomas@codesourcery.com>
1999
2000         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2001         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2002
2003 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2004
2005         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2006         (check_empty): Use "const char *".
2007
2008         * gnu-nat.c (gnu_nat_target::detach): Instead of
2009         'detach_inferior (pid)' call
2010         'detach_inferior (find_inferior_pid (pid))'.
2011
2012         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2013         'nat/fork-inferior.o'.
2014         * gnu-nat.c: #include "nat/fork-inferior.h".
2015
2016         * gnu-nat.c (gnu_nat_target::detach): Instead of
2017         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2018         * gnu-nat.h: #include "inf-child.h".
2019         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2020         'i386_gnu_nat_target::fetch_registers'.
2021         (gnu_store_registers): Rename/move to
2022         'i386_gnu_nat_target::store_registers'.
2023
2024         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2025         * gnu-nat.h (mach_thread_info): New function.
2026         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2027
2028         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2029
2030 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2031
2032         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2033
2034 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2035
2036         * windows-nat.c (windows_add_thread): Add new parameter
2037         "main_thread_p" with default value set to false.  Update
2038         function documentation as well as all callers.
2039         (windows_delete_thread): Likewise.
2040         (fake_create_process): Update call to windows_add_thread.
2041         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2042         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2043         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2044         call to windows_delete_thread.
2045
2046 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2047
2048         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2049
2050 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2051
2052         * symfile.c (find_separate_debug_file): Use canonical path of
2053         sysroot with child_path instead of gdb_sysroot if it is valid.
2054
2055 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2056
2057         * symfile.c (find_separate_debug_file): Use child_path to
2058         determine if an object file is under a sysroot.
2059
2060 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2061
2062         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2063         unittests/child-path-selftests.c.
2064         * common/pathstuff.c (child_path): New function.
2065         * common/pathstuff.h (child_path): New prototype.
2066         * unittests/child-path-selftests.c: New file.
2067
2068 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2069
2070         * symfile.c (find_separate_debug_file): Look for separate debug
2071         files in debug directories under the sysroot.
2072
2073 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2074
2075         * symtab.h (struct minimal_symbol data_p): New const method.
2076         (struct minimal_symbol text_p): Likewise.
2077         * symtab.c (output_source_filename): Use file name style
2078         to print file name.
2079         (print_symbol_info): Likewise.
2080         (print_msymbol_info): Use address style to print addresses.
2081         Use function name style to print executable text symbols.
2082         (expand_symtab_containing_pc): Use data_p.
2083         (find_pc_sect_compunit_symtab): Likewise.
2084
2085 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2086
2087         * breakpoint.c (describe_other_breakpoints): Use address style
2088         to print addresses.
2089         (say_where): Likewise.
2090
2091 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2092
2093         * ada-typeprint.c (print_func_type): Print function name
2094         style to print function name.
2095         * c-typeprint.c (c_print_type_1): Likewise.
2096
2097 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2098
2099         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2100         for execve.
2101
2102 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2103
2104         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2105         type_stack.
2106
2107 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2108
2109         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2110         TYPE_CODE_REF types.
2111
2112 2019-02-08  Jim Wilson  <jimw@sifive.com>
2113
2114         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2115         (riscv_linux_fregset): New.
2116         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2117
2118 2019-02-07  Tom Tromey  <tom@tromey.com>
2119
2120         * thread.c (thread_cancel_execution_command): Update.
2121         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2122         methods.
2123         (struct thread_fsm_ops): Remove.
2124         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2125         (thread_fsm_should_stop, thread_fsm_return_value)
2126         (thread_fsm_set_finished, thread_fsm_finished_p)
2127         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2128         Don't declare.
2129         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2130         * infrun.c (clear_proceed_status_thread)
2131         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2132         (print_stop_event): Update.
2133         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2134         Add constructor.
2135         (step_command_fsm_ops): Remove.
2136         (new_step_command_fsm): Remove.
2137         (step_1): Update.
2138         (step_command_fsm::should_stop): Rename from
2139         step_command_fsm_should_stop.
2140         (step_command_fsm::clean_up): Rename from
2141         step_command_fsm_clean_up.
2142         (step_command_fsm::do_async_reply_reason): Rename from
2143         step_command_fsm_async_reply_reason.
2144         (struct until_next_fsm): Inherit from thread_fsm.  Add
2145         constructor.
2146         (until_next_fsm_ops): Remove.
2147         (new_until_next_fsm): Remove.
2148         (until_next_fsm::should_stop): Rename from
2149         until_next_fsm_should_stop.
2150         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2151         (until_next_fsm::do_async_reply_reason): Rename from
2152         until_next_fsm_async_reply_reason.
2153         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2154         constructor.  Change type of breakpoint.
2155         (finish_command_fsm_ops): Remove.
2156         (new_finish_command_fsm): Remove.
2157         (finish_command_fsm::should_stop): Rename from
2158         finish_command_fsm_should_stop.
2159         (finish_command_fsm::clean_up): Rename from
2160         finish_command_fsm_clean_up.
2161         (finish_command_fsm::return_value): Rename from
2162         finish_command_fsm_return_value.
2163         (finish_command_fsm::do_async_reply_reason): Rename from
2164         finish_command_fsm_async_reply_reason.
2165         (finish_command): Update.
2166         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2167         Add constructor.
2168         (call_thread_fsm_ops): Remove.
2169         (call_thread_fsm::call_thread_fsm): Rename from
2170         new_call_thread_fsm.
2171         (call_thread_fsm::should_stop): Rename from
2172         call_thread_fsm_should_stop.
2173         (call_thread_fsm::should_notify_stop): Rename from
2174         call_thread_fsm_should_notify_stop.
2175         (run_inferior_call, call_function_by_hand_dummy): Update.
2176         * cli/cli-interp.c (should_print_stop_to_console): Update.
2177         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2178         Add constructor.  Change type of location_breakpoint,
2179         caller_breakpoint.
2180         (until_break_fsm_ops): Remove.
2181         (new_until_break_fsm): Remove.
2182         (until_break_fsm::should_stop): Rename from
2183         until_break_fsm_should_stop.
2184         (until_break_fsm::clean_up): Rename from
2185         until_break_fsm_clean_up.
2186         (until_break_fsm::do_async_reply_reason): Rename from
2187         until_break_fsm_async_reply_reason.
2188         (until_break_command): Update.
2189         * thread-fsm.c: Remove.
2190         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2191
2192 2019-02-07  Tom Tromey  <tom@tromey.com>
2193
2194         * yy-remap.h: Add include guard.
2195         * xtensa-tdep.h: Add include guard.
2196         * xcoffread.h: Rename include guard.
2197         * varobj-iter.h: Add include guard.
2198         * tui/tui.h: Rename include guard.
2199         * tui/tui-winsource.h: Rename include guard.
2200         * tui/tui-wingeneral.h: Rename include guard.
2201         * tui/tui-windata.h: Rename include guard.
2202         * tui/tui-win.h: Rename include guard.
2203         * tui/tui-stack.h: Rename include guard.
2204         * tui/tui-source.h: Rename include guard.
2205         * tui/tui-regs.h: Rename include guard.
2206         * tui/tui-out.h: Rename include guard.
2207         * tui/tui-layout.h: Rename include guard.
2208         * tui/tui-io.h: Rename include guard.
2209         * tui/tui-hooks.h: Rename include guard.
2210         * tui/tui-file.h: Rename include guard.
2211         * tui/tui-disasm.h: Rename include guard.
2212         * tui/tui-data.h: Rename include guard.
2213         * tui/tui-command.h: Rename include guard.
2214         * tic6x-tdep.h: Add include guard.
2215         * target/waitstatus.h: Rename include guard.
2216         * target/wait.h: Rename include guard.
2217         * target/target.h: Rename include guard.
2218         * target/resume.h: Rename include guard.
2219         * target-float.h: Rename include guard.
2220         * stabsread.h: Add include guard.
2221         * rs6000-tdep.h: Add include guard.
2222         * riscv-fbsd-tdep.h: Add include guard.
2223         * regformats/regdef.h: Rename include guard.
2224         * record.h: Rename include guard.
2225         * python/python.h: Rename include guard.
2226         * python/python-internal.h: Rename include guard.
2227         * python/py-stopevent.h: Rename include guard.
2228         * python/py-ref.h: Rename include guard.
2229         * python/py-record.h: Rename include guard.
2230         * python/py-record-full.h: Rename include guard.
2231         * python/py-record-btrace.h: Rename include guard.
2232         * python/py-instruction.h: Rename include guard.
2233         * python/py-events.h: Rename include guard.
2234         * python/py-event.h: Rename include guard.
2235         * procfs.h: Add include guard.
2236         * proc-utils.h: Add include guard.
2237         * p-lang.h: Add include guard.
2238         * or1k-tdep.h: Rename include guard.
2239         * observable.h: Rename include guard.
2240         * nto-tdep.h: Rename include guard.
2241         * nat/x86-linux.h: Rename include guard.
2242         * nat/x86-linux-dregs.h: Rename include guard.
2243         * nat/x86-gcc-cpuid.h: Add include guard.
2244         * nat/x86-dregs.h: Rename include guard.
2245         * nat/x86-cpuid.h: Rename include guard.
2246         * nat/ppc-linux.h: Rename include guard.
2247         * nat/mips-linux-watch.h: Rename include guard.
2248         * nat/linux-waitpid.h: Rename include guard.
2249         * nat/linux-ptrace.h: Rename include guard.
2250         * nat/linux-procfs.h: Rename include guard.
2251         * nat/linux-osdata.h: Rename include guard.
2252         * nat/linux-nat.h: Rename include guard.
2253         * nat/linux-namespaces.h: Rename include guard.
2254         * nat/linux-btrace.h: Rename include guard.
2255         * nat/glibc_thread_db.h: Rename include guard.
2256         * nat/gdb_thread_db.h: Rename include guard.
2257         * nat/gdb_ptrace.h: Rename include guard.
2258         * nat/fork-inferior.h: Rename include guard.
2259         * nat/amd64-linux-siginfo.h: Rename include guard.
2260         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2261         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2262         * nat/aarch64-linux.h: Rename include guard.
2263         * nat/aarch64-linux-hw-point.h: Rename include guard.
2264         * mn10300-tdep.h: Add include guard.
2265         * mips-linux-tdep.h: Add include guard.
2266         * mi/mi-parse.h: Rename include guard.
2267         * mi/mi-out.h: Rename include guard.
2268         * mi/mi-main.h: Rename include guard.
2269         * mi/mi-interp.h: Rename include guard.
2270         * mi/mi-getopt.h: Rename include guard.
2271         * mi/mi-console.h: Rename include guard.
2272         * mi/mi-common.h: Rename include guard.
2273         * mi/mi-cmds.h: Rename include guard.
2274         * mi/mi-cmd-break.h: Rename include guard.
2275         * m2-lang.h: Add include guard.
2276         * location.h: Rename include guard.
2277         * linux-record.h: Rename include guard.
2278         * linux-nat.h: Add include guard.
2279         * linux-fork.h: Add include guard.
2280         * i386-darwin-tdep.h: Rename include guard.
2281         * hppa-linux-offsets.h: Add include guard.
2282         * guile/guile.h: Rename include guard.
2283         * guile/guile-internal.h: Rename include guard.
2284         * gnu-nat.h: Rename include guard.
2285         * gdb-stabs.h: Rename include guard.
2286         * frv-tdep.h: Add include guard.
2287         * f-lang.h: Add include guard.
2288         * event-loop.h: Add include guard.
2289         * darwin-nat.h: Rename include guard.
2290         * cp-abi.h: Rename include guard.
2291         * config/sparc/nm-sol2.h: Rename include guard.
2292         * config/nm-nto.h: Rename include guard.
2293         * config/nm-linux.h: Add include guard.
2294         * config/i386/nm-i386gnu.h: Rename include guard.
2295         * config/djgpp/nl_types.h: Rename include guard.
2296         * config/djgpp/langinfo.h: Rename include guard.
2297         * compile/gcc-cp-plugin.h: Add include guard.
2298         * compile/gcc-c-plugin.h: Add include guard.
2299         * compile/compile.h: Rename include guard.
2300         * compile/compile-object-run.h: Rename include guard.
2301         * compile/compile-object-load.h: Rename include guard.
2302         * compile/compile-internal.h: Rename include guard.
2303         * compile/compile-cplus.h: Rename include guard.
2304         * compile/compile-c.h: Rename include guard.
2305         * common/xml-utils.h: Rename include guard.
2306         * common/x86-xstate.h: Rename include guard.
2307         * common/version.h: Rename include guard.
2308         * common/vec.h: Rename include guard.
2309         * common/tdesc.h: Rename include guard.
2310         * common/selftest.h: Rename include guard.
2311         * common/scoped_restore.h: Rename include guard.
2312         * common/scoped_mmap.h: Rename include guard.
2313         * common/scoped_fd.h: Rename include guard.
2314         * common/safe-iterator.h: Rename include guard.
2315         * common/run-time-clock.h: Rename include guard.
2316         * common/refcounted-object.h: Rename include guard.
2317         * common/queue.h: Rename include guard.
2318         * common/ptid.h: Rename include guard.
2319         * common/print-utils.h: Rename include guard.
2320         * common/preprocessor.h: Rename include guard.
2321         * common/pathstuff.h: Rename include guard.
2322         * common/observable.h: Rename include guard.
2323         * common/netstuff.h: Rename include guard.
2324         * common/job-control.h: Rename include guard.
2325         * common/host-defs.h: Rename include guard.
2326         * common/gdb_wait.h: Rename include guard.
2327         * common/gdb_vecs.h: Rename include guard.
2328         * common/gdb_unlinker.h: Rename include guard.
2329         * common/gdb_unique_ptr.h: Rename include guard.
2330         * common/gdb_tilde_expand.h: Rename include guard.
2331         * common/gdb_sys_time.h: Rename include guard.
2332         * common/gdb_string_view.h: Rename include guard.
2333         * common/gdb_splay_tree.h: Rename include guard.
2334         * common/gdb_setjmp.h: Rename include guard.
2335         * common/gdb_ref_ptr.h: Rename include guard.
2336         * common/gdb_optional.h: Rename include guard.
2337         * common/gdb_locale.h: Rename include guard.
2338         * common/gdb_assert.h: Rename include guard.
2339         * common/filtered-iterator.h: Rename include guard.
2340         * common/filestuff.h: Rename include guard.
2341         * common/fileio.h: Rename include guard.
2342         * common/environ.h: Rename include guard.
2343         * common/common-utils.h: Rename include guard.
2344         * common/common-types.h: Rename include guard.
2345         * common/common-regcache.h: Rename include guard.
2346         * common/common-inferior.h: Rename include guard.
2347         * common/common-gdbthread.h: Rename include guard.
2348         * common/common-exceptions.h: Rename include guard.
2349         * common/common-defs.h: Rename include guard.
2350         * common/common-debug.h: Rename include guard.
2351         * common/cleanups.h: Rename include guard.
2352         * common/buffer.h: Rename include guard.
2353         * common/btrace-common.h: Rename include guard.
2354         * common/break-common.h: Rename include guard.
2355         * cli/cli-utils.h: Rename include guard.
2356         * cli/cli-style.h: Rename include guard.
2357         * cli/cli-setshow.h: Rename include guard.
2358         * cli/cli-script.h: Rename include guard.
2359         * cli/cli-interp.h: Rename include guard.
2360         * cli/cli-decode.h: Rename include guard.
2361         * cli/cli-cmds.h: Rename include guard.
2362         * charset-list.h: Add include guard.
2363         * buildsym-legacy.h: Rename include guard.
2364         * bfin-tdep.h: Add include guard.
2365         * ax.h: Rename include guard.
2366         * arm-linux-tdep.h: Add include guard.
2367         * arm-fbsd-tdep.h: Add include guard.
2368         * arch/xtensa.h: Rename include guard.
2369         * arch/tic6x.h: Add include guard.
2370         * arch/i386.h: Add include guard.
2371         * arch/arm.h: Rename include guard.
2372         * arch/arm-linux.h: Rename include guard.
2373         * arch/arm-get-next-pcs.h: Rename include guard.
2374         * arch/amd64.h: Add include guard.
2375         * arch/aarch64-insn.h: Rename include guard.
2376         * arch-utils.h: Rename include guard.
2377         * annotate.h: Add include guard.
2378         * amd64-darwin-tdep.h: Rename include guard.
2379         * aarch64-linux-tdep.h: Add include guard.
2380         * aarch64-fbsd-tdep.h: Add include guard.
2381         * aarch32-linux-nat.h: Add include guard.
2382
2383 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2384
2385         * macrotab.c (macro_define_internal): New function that
2386         factorizes macro_define_object_internal and macro_define_function
2387         code.
2388         (macro_define_object_internal): Use macro_define_internal.
2389         (macro_define_function): Likewise.
2390
2391 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2392
2393         * macrocmd.c (extract_identifier): Return
2394         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2395         callers.
2396
2397 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2398
2399         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2400
2401 2019-02-05  Tom Tromey  <tom@tromey.com>
2402
2403         * target.c (target_stack::unpush): Move assertion earlier.
2404
2405 2019-01-30  Tom Tromey  <tom@tromey.com>
2406
2407         PR python/23615:
2408         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2409         (gdbpy_parse_and_eval): Likewise.
2410         * python/python-internal.h (gdbpy_allow_threads): New class.
2411
2412 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2413
2414         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2415         (aarch64_fbsd_fpregmap): Move earlier.
2416         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2417         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2418         instead of individual calls to trad_frame_set_reg_addr.
2419         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2420         earlier.
2421         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2422         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2423         instead of individual calls to trad_frame_set_reg_addr.
2424
2425 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2426
2427         * CONTRIBUTE: Replace contribution list with wiki link.
2428
2429 2019-01-25  Tom Tromey  <tom@tromey.com>
2430
2431         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2432
2433 2019-01-25  Tom Tromey  <tom@tromey.com>
2434
2435         * xtensa-linux-nat.c: Fix common/ includes.
2436         * xml-support.h: Fix common/ includes.
2437         * xml-support.c: Fix common/ includes.
2438         * x86-linux-nat.c: Fix common/ includes.
2439         * windows-nat.c: Fix common/ includes.
2440         * varobj.h: Fix common/ includes.
2441         * varobj.c: Fix common/ includes.
2442         * value.c: Fix common/ includes.
2443         * valops.c: Fix common/ includes.
2444         * utils.c: Fix common/ includes.
2445         * unittests/xml-utils-selftests.c: Fix common/ includes.
2446         * unittests/utils-selftests.c: Fix common/ includes.
2447         * unittests/unpack-selftests.c: Fix common/ includes.
2448         * unittests/tracepoint-selftests.c: Fix common/ includes.
2449         * unittests/style-selftests.c: Fix common/ includes.
2450         * unittests/string_view-selftests.c: Fix common/ includes.
2451         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2452         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2453         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2454         * unittests/rsp-low-selftests.c: Fix common/ includes.
2455         * unittests/parse-connection-spec-selftests.c: Fix common/
2456         includes.
2457         * unittests/optional-selftests.c: Fix common/ includes.
2458         * unittests/offset-type-selftests.c: Fix common/ includes.
2459         * unittests/observable-selftests.c: Fix common/ includes.
2460         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2461         * unittests/memrange-selftests.c: Fix common/ includes.
2462         * unittests/memory-map-selftests.c: Fix common/ includes.
2463         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2464         * unittests/function-view-selftests.c: Fix common/ includes.
2465         * unittests/environ-selftests.c: Fix common/ includes.
2466         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2467         * unittests/common-utils-selftests.c: Fix common/ includes.
2468         * unittests/cli-utils-selftests.c: Fix common/ includes.
2469         * unittests/array-view-selftests.c: Fix common/ includes.
2470         * ui-file.c: Fix common/ includes.
2471         * tui/tui-io.c: Fix common/ includes.
2472         * tracepoint.h: Fix common/ includes.
2473         * tracepoint.c: Fix common/ includes.
2474         * tracefile-tfile.c: Fix common/ includes.
2475         * top.h: Fix common/ includes.
2476         * top.c: Fix common/ includes.
2477         * thread.c: Fix common/ includes.
2478         * target/waitstatus.h: Fix common/ includes.
2479         * target/waitstatus.c: Fix common/ includes.
2480         * target.h: Fix common/ includes.
2481         * target.c: Fix common/ includes.
2482         * target-memory.c: Fix common/ includes.
2483         * target-descriptions.c: Fix common/ includes.
2484         * symtab.h: Fix common/ includes.
2485         * symfile.c: Fix common/ includes.
2486         * stap-probe.c: Fix common/ includes.
2487         * spu-linux-nat.c: Fix common/ includes.
2488         * sparc-nat.c: Fix common/ includes.
2489         * source.c: Fix common/ includes.
2490         * solib.c: Fix common/ includes.
2491         * solib-target.c: Fix common/ includes.
2492         * ser-unix.c: Fix common/ includes.
2493         * ser-tcp.c: Fix common/ includes.
2494         * ser-pipe.c: Fix common/ includes.
2495         * ser-base.c: Fix common/ includes.
2496         * selftest-arch.c: Fix common/ includes.
2497         * s12z-tdep.c: Fix common/ includes.
2498         * rust-exp.y: Fix common/ includes.
2499         * rs6000-aix-tdep.c: Fix common/ includes.
2500         * riscv-tdep.c: Fix common/ includes.
2501         * remote.c: Fix common/ includes.
2502         * remote-notif.h: Fix common/ includes.
2503         * remote-fileio.h: Fix common/ includes.
2504         * remote-fileio.c: Fix common/ includes.
2505         * regcache.h: Fix common/ includes.
2506         * regcache.c: Fix common/ includes.
2507         * record-btrace.c: Fix common/ includes.
2508         * python/python.c: Fix common/ includes.
2509         * python/py-type.c: Fix common/ includes.
2510         * python/py-inferior.c: Fix common/ includes.
2511         * progspace.h: Fix common/ includes.
2512         * producer.c: Fix common/ includes.
2513         * procfs.c: Fix common/ includes.
2514         * proc-api.c: Fix common/ includes.
2515         * printcmd.c: Fix common/ includes.
2516         * ppc-linux-nat.c: Fix common/ includes.
2517         * parser-defs.h: Fix common/ includes.
2518         * osdata.c: Fix common/ includes.
2519         * obsd-nat.c: Fix common/ includes.
2520         * nat/x86-linux.c: Fix common/ includes.
2521         * nat/x86-linux-dregs.c: Fix common/ includes.
2522         * nat/x86-dregs.h: Fix common/ includes.
2523         * nat/x86-dregs.c: Fix common/ includes.
2524         * nat/ppc-linux.c: Fix common/ includes.
2525         * nat/mips-linux-watch.h: Fix common/ includes.
2526         * nat/mips-linux-watch.c: Fix common/ includes.
2527         * nat/linux-waitpid.c: Fix common/ includes.
2528         * nat/linux-ptrace.h: Fix common/ includes.
2529         * nat/linux-ptrace.c: Fix common/ includes.
2530         * nat/linux-procfs.c: Fix common/ includes.
2531         * nat/linux-personality.c: Fix common/ includes.
2532         * nat/linux-osdata.c: Fix common/ includes.
2533         * nat/linux-namespaces.c: Fix common/ includes.
2534         * nat/linux-btrace.h: Fix common/ includes.
2535         * nat/linux-btrace.c: Fix common/ includes.
2536         * nat/fork-inferior.c: Fix common/ includes.
2537         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2538         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2539         * nat/aarch64-linux.c: Fix common/ includes.
2540         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2541         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2542         * namespace.h: Fix common/ includes.
2543         * mips-linux-tdep.c: Fix common/ includes.
2544         * minsyms.c: Fix common/ includes.
2545         * mi/mi-parse.h: Fix common/ includes.
2546         * mi/mi-main.c: Fix common/ includes.
2547         * mi/mi-cmd-env.c: Fix common/ includes.
2548         * memrange.h: Fix common/ includes.
2549         * memattr.c: Fix common/ includes.
2550         * maint.h: Fix common/ includes.
2551         * maint.c: Fix common/ includes.
2552         * main.c: Fix common/ includes.
2553         * machoread.c: Fix common/ includes.
2554         * location.c: Fix common/ includes.
2555         * linux-thread-db.c: Fix common/ includes.
2556         * linux-nat.c: Fix common/ includes.
2557         * linux-fork.c: Fix common/ includes.
2558         * inline-frame.c: Fix common/ includes.
2559         * infrun.c: Fix common/ includes.
2560         * inflow.c: Fix common/ includes.
2561         * inferior.h: Fix common/ includes.
2562         * inferior.c: Fix common/ includes.
2563         * infcmd.c: Fix common/ includes.
2564         * inf-ptrace.c: Fix common/ includes.
2565         * inf-child.c: Fix common/ includes.
2566         * ia64-linux-nat.c: Fix common/ includes.
2567         * i387-tdep.c: Fix common/ includes.
2568         * i386-tdep.c: Fix common/ includes.
2569         * i386-linux-tdep.c: Fix common/ includes.
2570         * i386-linux-nat.c: Fix common/ includes.
2571         * i386-go32-tdep.c: Fix common/ includes.
2572         * i386-fbsd-tdep.c: Fix common/ includes.
2573         * i386-fbsd-nat.c: Fix common/ includes.
2574         * guile/scm-type.c: Fix common/ includes.
2575         * guile/guile.c: Fix common/ includes.
2576         * go32-nat.c: Fix common/ includes.
2577         * gnu-nat.c: Fix common/ includes.
2578         * gdbthread.h: Fix common/ includes.
2579         * gdbarch-selftests.c: Fix common/ includes.
2580         * gdb_usleep.c: Fix common/ includes.
2581         * gdb_select.h: Fix common/ includes.
2582         * gdb_bfd.c: Fix common/ includes.
2583         * gcore.c: Fix common/ includes.
2584         * fork-child.c: Fix common/ includes.
2585         * findvar.c: Fix common/ includes.
2586         * fbsd-nat.c: Fix common/ includes.
2587         * event-top.c: Fix common/ includes.
2588         * event-loop.c: Fix common/ includes.
2589         * dwarf2read.c: Fix common/ includes.
2590         * dwarf2loc.c: Fix common/ includes.
2591         * dwarf2-frame.c: Fix common/ includes.
2592         * dwarf-index-cache.c: Fix common/ includes.
2593         * dtrace-probe.c: Fix common/ includes.
2594         * disasm-selftests.c: Fix common/ includes.
2595         * defs.h: Fix common/ includes.
2596         * csky-tdep.c: Fix common/ includes.
2597         * cp-valprint.c: Fix common/ includes.
2598         * cp-support.h: Fix common/ includes.
2599         * cp-support.c: Fix common/ includes.
2600         * corelow.c: Fix common/ includes.
2601         * completer.h: Fix common/ includes.
2602         * completer.c: Fix common/ includes.
2603         * compile/compile.c: Fix common/ includes.
2604         * compile/compile-loc2c.c: Fix common/ includes.
2605         * compile/compile-cplus-types.c: Fix common/ includes.
2606         * compile/compile-cplus-symbols.c: Fix common/ includes.
2607         * command.h: Fix common/ includes.
2608         * cli/cli-dump.c: Fix common/ includes.
2609         * cli/cli-cmds.c: Fix common/ includes.
2610         * charset.c: Fix common/ includes.
2611         * build-id.c: Fix common/ includes.
2612         * btrace.h: Fix common/ includes.
2613         * btrace.c: Fix common/ includes.
2614         * breakpoint.h: Fix common/ includes.
2615         * breakpoint.c: Fix common/ includes.
2616         * ax.h:
2617         (enum agent_op): Fix common/ includes.
2618         * ax-general.c (struct aop_map): Fix common/ includes.
2619         * ax-gdb.c: Fix common/ includes.
2620         * auxv.c: Fix common/ includes.
2621         * auto-load.c: Fix common/ includes.
2622         * arm-tdep.c: Fix common/ includes.
2623         * arch/riscv.c: Fix common/ includes.
2624         * arch/ppc-linux-common.c: Fix common/ includes.
2625         * arch/i386.c: Fix common/ includes.
2626         * arch/arm.c: Fix common/ includes.
2627         * arch/arm-linux.c: Fix common/ includes.
2628         * arch/arm-get-next-pcs.c: Fix common/ includes.
2629         * arch/amd64.c: Fix common/ includes.
2630         * arch/aarch64.c: Fix common/ includes.
2631         * arch/aarch64-insn.c: Fix common/ includes.
2632         * arch-utils.c: Fix common/ includes.
2633         * amd64-windows-tdep.c: Fix common/ includes.
2634         * amd64-tdep.c: Fix common/ includes.
2635         * amd64-sol2-tdep.c: Fix common/ includes.
2636         * amd64-obsd-tdep.c: Fix common/ includes.
2637         * amd64-nbsd-tdep.c: Fix common/ includes.
2638         * amd64-linux-tdep.c: Fix common/ includes.
2639         * amd64-linux-nat.c: Fix common/ includes.
2640         * amd64-fbsd-tdep.c: Fix common/ includes.
2641         * amd64-fbsd-nat.c: Fix common/ includes.
2642         * amd64-dicos-tdep.c: Fix common/ includes.
2643         * amd64-darwin-tdep.c: Fix common/ includes.
2644         * agent.c: Fix common/ includes.
2645         * ada-lang.h: Fix common/ includes.
2646         * ada-lang.c: Fix common/ includes.
2647         * aarch64-tdep.c: Fix common/ includes.
2648
2649 2019-01-25  Tom Tromey  <tom@tromey.com>
2650
2651         * common/create-version.sh: Use common/version.h.
2652
2653 2019-01-24  Pedro Alves  <palves@redhat.com>
2654
2655         * infrun.c (signal_stop, signal_print, signal_program)
2656         (signal_catch, signal_pass): Now arrays instead of pointers.
2657         (update_signals_program_target, do_target_resume)
2658         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2659         * linux-nat.c (linux_nat_target::pass_signals)
2660         (linux_nat_target::create_inferior, linux_nat_target::attach):
2661         Adjust.
2662         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2663         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2664         * procfs.c (procfs_target::pass_signals): Adjust.
2665         * record-full.c (record_full_target::resume): Adjust.
2666         * remote.c (remote_target::pass_signals)
2667         (remote_target::program_signals): Adjust.
2668         * target-debug.h (target_debug_print_signals): Now takes a
2669         gdb::array_view as parameter.  Adjust.
2670         * target.h (target_ops) <pass_signals, program_signals>: Replace
2671         pointer and length parameters with gdb::array_view.
2672         (target_pass_signals, target_program_signals): Likewise.
2673         * target-delegates.c: Regenerate.
2674
2675 2019-01-24  Pedro Alves  <palves@redhat.com>
2676
2677         * common/forward-scope-exit.h
2678         (forward_scope_exit::forward_scope_exit): Pass arguments to
2679         m_bind_function directly, instead of creating a std::bind and
2680         copying that.
2681
2682 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2683
2684         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2685         for static members.
2686         (pass_in_v_vfp_candidate): Likewise.
2687
2688 2019-01-23  Tom Tromey  <tom@tromey.com>
2689             Pedro Alves  <palves@redhat.com>
2690
2691         * regcache.c (class regcache_invalidator): Remove.
2692         (regcache::raw_write): Use make_scope_exit.
2693
2694 2019-01-23  Tom Tromey  <tom@tromey.com>
2695
2696         * ui-out.h (class ui_out_emit_type): Update comment.
2697
2698 2019-01-23  Tom Tromey  <tom@tromey.com>
2699
2700         * infrun.c (fetch_inferior_event): Update comment.
2701
2702 2019-01-23  Tom Tromey  <tom@tromey.com>
2703             Pedro Alves  <palves@redhat.com>
2704
2705         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2706         parameter.
2707         (fetch_inferior_event): Use SCOPE_EXIT.
2708
2709
2710 2019-01-23  Tom Tromey  <tom@tromey.com>
2711             Pedro Alves  <palves@redhat.com>
2712
2713         * infrun.c (disable_thread_events): Delete.
2714         (stop_all_threads): Use SCOPE_EXIT.
2715
2716 2019-01-23  Tom Tromey  <tom@tromey.com>
2717             Pedro Alves  <palves@redhat.com>
2718
2719         * symfile.c: Include forward-scope-exit.h.
2720         (clear_symtab_users_cleanup): Replace forward declaration with
2721         a FORWARD_SCOPE_EXIT.
2722         (syms_from_objfile_1): Use the forward_scope_exit and
2723         gdb::optional instead of cleanup_function.
2724         (reread_symbols): Use the forward_scope_exit instead of
2725         cleanup_function.
2726         (clear_symtab_users_cleanup): Remove function.
2727
2728 2019-01-23  Tom Tromey  <tom@tromey.com>
2729             Pedro Alves  <palves@redhat.com>
2730
2731         * linux-nat.c: Include scope-exit.h.
2732         (cleanup_target_stop): Remove.
2733         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2734         SCOPE_EXIT.
2735
2736 2019-01-23  Tom Tromey  <tom@tromey.com>
2737             Pedro Alves  <palves@redhat.com>
2738
2739         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2740         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2741
2742 2019-01-23  Tom Tromey  <tom@tromey.com>
2743             Andrew Burgess  <andrew.burgess@embecosm.com>
2744             Pedro Alves  <palves@redhat.com>
2745
2746         * infrun.c (fetch_inferior_event): Use scope_exit.
2747         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2748         * top.c (execute_command): Use scope_exit.
2749         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2750         * utils.c (do_bpstat_clear_actions_cleanup)
2751         (make_bpstat_clear_actions_cleanup): Remove.
2752
2753 2019-01-23  Tom Tromey  <tom@tromey.com>
2754             Pedro Alves  <palves@redhat.com>
2755
2756         * infrun.c: Include "common/scope-exit.h"
2757         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2758         (wait_for_inferior): Use SCOPE_EXIT.
2759         (fetch_inferior_event): Use scope_exit.
2760
2761 2019-01-23  Tom Tromey  <tom@tromey.com>
2762             Pedro Alves  <palves@redhat.com>
2763
2764         * breakpoint.c (create_breakpoint): Remove cleanup.
2765
2766 2019-01-23  Tom Tromey  <tom@tromey.com>
2767             Andrew Burgess  <andrew.burgess@embecosm.com>
2768             Pedro Alves  <palves@redhat.com>
2769
2770 2019-01-23  Pedro Alves  <palves@redhat.com>
2771
2772         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2773
2774 2019-01-23  Pedro Alves  <palves@redhat.com>
2775             Andrew Burgess  <andrew.burgess@embecosm.com>
2776
2777         * gdbthread.h: Include "common/forward-scope-exit.h".
2778         (scoped_finish_thread_state): Redefine custom class in terms of
2779         forward_scope_exit.
2780
2781 2019-01-23  Pedro Alves  <palves@redhat.com>
2782             Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * common/forward-scope-exit.h: New file.
2785
2786 2019-01-23  Pedro Alves  <palves@redhat.com>
2787             Andrew Burgess  <andrew.burgess@embecosm.com>
2788             Tom Tromey  <tom@tromey.com>
2789
2790         * common/scope-exit.h: New file.
2791
2792 2019-01-23  Pedro Alves  <palves@redhat.com>
2793
2794         * common/preprocessor.h (ESC): Rename to ...
2795         (ESC_PARENS): ... this.
2796         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2797         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2798
2799 2019-01-23  Tom Tromey  <tom@tromey.com>
2800
2801         * language.h (class scoped_switch_to_sym_language_if_auto):
2802         Initialize m_lang in both cases.
2803
2804 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2805
2806         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2807         with XCNEW.
2808
2809 2019-01-22  Tom Tromey  <tom@tromey.com>
2810
2811         * corelow.c: Do not include sys/file.h.
2812
2813 2019-01-22  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-wingeneral.h: Include gdb_curses.h.
2816
2817 2019-01-22  Tom Tromey  <tom@tromey.com>
2818
2819         * source-cache.h (class source_cache) <get_source_lines,
2820         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2821
2822 2019-01-22  Tom Tromey  <tom@tromey.com>
2823
2824         * remote-fileio.h (struct remote_target): Declare.
2825
2826 2019-01-22  Tom Tromey  <tom@tromey.com>
2827
2828         * python/py-arch.c: Do not include py-ref.h.
2829         * python/py-bpevent.c: Do not include py-ref.h.
2830         * python/py-cmd.c: Do not include py-ref.h.
2831         * python/py-continueevent.c: Do not include py-ref.h.
2832         * python/py-event.h: Do not include py-ref.h.
2833         * python/py-evtregistry.c: Do not include py-ref.h.
2834         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2835         * python/py-frame.c: Do not include py-ref.h.
2836         * python/py-framefilter.c: Do not include py-ref.h.
2837         * python/py-function.c: Do not include py-ref.h.
2838         * python/py-infevents.c: Do not include py-ref.h.
2839         * python/py-linetable.c: Do not include py-ref.h.
2840         * python/py-objfile.c: Do not include py-ref.h.
2841         * python/py-param.c: Do not include py-ref.h.
2842         * python/py-prettyprint.c: Do not include py-ref.h.
2843         * python/py-progspace.c: Do not include py-ref.h.
2844         * python/py-symbol.c: Do not include py-ref.h.
2845         * python/py-symtab.c: Do not include py-ref.h.
2846         * python/py-type.c: Do not include py-ref.h.
2847         * python/py-unwind.c: Do not include py-ref.h.
2848         * python/py-utils.c: Do not include py-ref.h.
2849         * python/py-value.c: Do not include py-ref.h.
2850         * python/py-varobj.c: Do not include py-ref.h.
2851         * python/py-xmethods.c: Do not include py-ref.h.
2852         * python/python.c: Do not include py-ref.h.
2853         * varobj.c: Do not include py-ref.h.
2854
2855 2019-01-22  Tom Tromey  <tom@tromey.com>
2856
2857         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2858         keyword for bcache.
2859
2860 2019-01-22  Tom Tromey  <tom@tromey.com>
2861
2862         * compile/compile-cplus-types.c: Remove a comment by #include.
2863
2864 2019-01-22  Tom Tromey  <tom@tromey.com>
2865
2866         * compile/gcc-c-plugin.h: Include compile-internal.h.
2867
2868 2019-01-22  Tom Tromey  <tom@tromey.com>
2869
2870         * stabsread.c (EXTERN): Do not define.
2871         (symnum, next_symbol_text_func, processing_gcc_compilation)
2872         (within_function, global_sym_chain, global_stabs)
2873         (previous_stab_code, this_object_header_files)
2874         (n_this_object_header_files)
2875         (n_allocated_this_object_header_files): Define.
2876         * stabsread.h (EXTERN): Never define.  Use "extern".
2877
2878 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2879
2880         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2881         history_value.
2882
2883 2019-01-21  Tom Tromey  <tom@tromey.com>
2884
2885         * ui-out.c: Fix includes.
2886         * tui/tui-source.c: Fix includes.
2887         * target.c: Fix includes.
2888         * remote.c: Fix includes.
2889         * regcache.c: Fix includes.
2890         * python/py-block.c: Fix includes.
2891         * printcmd.c: Fix includes.
2892         * or1k-tdep.c: Fix includes.
2893         * mi/mi-main.c: Fix includes.
2894         * m32r-tdep.c: Fix includes.
2895         * csky-tdep.c: Fix includes.
2896         * compile/compile-cplus-types.c: Fix includes.
2897         * cli/cli-interp.c: Fix includes.
2898
2899 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2900
2901         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2902         for padding.
2903
2904 2019-01-16  Tom Tromey  <tom@tromey.com>
2905
2906         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2907         earlier.
2908         (struct objfile) <msymbols_range>: Move from top level.
2909         <msymbols>: New method.
2910         (class objfile_msymbols): Remove.
2911         * symtab.c (default_collect_symbol_completion_matches_break_on):
2912         Update.
2913         * symmisc.c (dump_msymbols): Update.
2914         * stabsread.c (scan_file_globals): Update.
2915         * objc-lang.c (info_selectors_command, info_classes_command)
2916         (find_methods): Update.
2917         * minsyms.c (find_solib_trampoline_target): Update.
2918         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2919         * coffread.c (coff_symfile_read): Update.
2920         * ada-lang.c (ada_lookup_simple_minsym)
2921         (ada_collect_symbol_completion_matches): Update.
2922
2923 2019-01-16  Tom Tromey  <tom@tromey.com>
2924
2925         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2926         type.  Remove no-argument constructor.
2927         <iterator::operator++>: Simplify.
2928         <begin>: Update.
2929         <end>: Use minimal_symbol_count.
2930
2931 2019-01-16  Tom Tromey  <tom@tromey.com>
2932
2933         * objfiles.h (struct objfile) <psymtabs>: New method.
2934         (class objfile_psymtabs): Remove.
2935         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2936         typedef.
2937         <range>: New method.
2938         (require_partial_symbols): Change return type.
2939         * psymtab.c (require_partial_symbols)
2940         (psym_expand_symtabs_matching): Update.
2941         * mdebugread.c (parse_partial_symbols): Update.
2942         * dbxread.c (dbx_end_psymtab): Update.
2943
2944 2019-01-15  Tom Tromey  <tom@tromey.com>
2945
2946         * symtab.c (lookup_objfile_from_block)
2947         (lookup_symbol_in_objfile_symtabs)
2948         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2949         (find_line_symtab, info_sources_command)
2950         (default_collect_symbol_completion_matches_break_on)
2951         (make_source_files_completion_list): Update.
2952         * symmisc.c (print_objfile_statistics, dump_objfile)
2953         (maintenance_print_symbols, maintenance_info_symtabs)
2954         (maintenance_check_symtabs, maintenance_info_line_tables):
2955         Update.
2956         * source.c (select_source_symtab)
2957         (forget_cached_source_info_for_objfile): Update.
2958         * objfiles.h (class objfile_compunits): Remove.
2959         (struct objfile) <compunits_range>: New typedef.
2960         (compunits): New method.
2961         * objfiles.c (objfile_relocate1): Update.
2962         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2963         * maint.c (count_symtabs_and_blocks): Update.
2964         * linespec.c (iterate_over_all_matching_symtabs): Update.
2965         * cp-support.c (add_symbol_overload_list_qualified): Update.
2966         * coffread.c (coff_symtab_read): Update.
2967         * ada-lang.c (add_nonlocal_symbols)
2968         (ada_collect_symbol_completion_matches)
2969         (ada_add_global_exceptions): Update.
2970
2971 2019-01-15  Tom Tromey  <tom@tromey.com>
2972
2973         * progspace.h (program_space) <objfiles_safe_range>: New
2974         typedef.
2975         <objfiles_safe>: New method.
2976         * objfiles.h (class all_objfiles_safe): Remove.
2977         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2978         * jit.c (jit_inferior_exit_hook): Update.
2979
2980 2019-01-17  Tom Tromey  <tom@tromey.com>
2981
2982         * progspace.h (program_space) <objfiles_range>: New typedef.
2983         <objfiles>: New method.
2984         <objfiles_head>: Rename from objfiles.
2985         (object_files): Update.
2986         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2987         * guile/scm-pretty-print.c
2988         (ppscm_find_pretty_printer_from_objfiles): Update.
2989         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2990         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2991         Update.
2992         * python/py-progspace.c (pspy_get_objfiles): Update.
2993         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2994         Update.
2995         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2996         (objfpy_lookup_objfile_by_build_id): Update.
2997         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2998         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2999         Update.
3000         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3001         (expand_symtab_containing_pc, lookup_objfile_from_block)
3002         (lookup_static_symbol, basic_lookup_transparent_type)
3003         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3004         (find_line_symtab, info_sources_command)
3005         (default_collect_symbol_completion_matches_break_on)
3006         (make_source_files_completion_list, find_main_name): Update.
3007         * symmisc.c (print_symbol_bcache_statistics)
3008         (print_objfile_statistics, maintenance_print_symbols)
3009         (maintenance_print_msymbols, maintenance_print_objfiles)
3010         (maintenance_info_symtabs, maintenance_check_symtabs)
3011         (maintenance_expand_symtabs, maintenance_info_line_tables):
3012         Update.
3013         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3014         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3015         (map_overlay_command, unmap_overlay_command)
3016         (simple_overlay_update, expand_symtabs_matching)
3017         (map_symbol_filenames): Update.
3018         * symfile-debug.c (set_debug_symfile): Update.
3019         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3020         Update.
3021         * source.c (select_source_symtab, forget_cached_source_info):
3022         Update.
3023         * solib.c (solib_read_symbols): Update.
3024         * solib-spu.c (append_ocl_sos): Update.
3025         * psymtab.c (maintenance_print_psymbols)
3026         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3027         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3028         * printcmd.c (info_symbol_command): Update.
3029         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3030         Update.
3031         * objfiles.h (class all_objfiles): Remove.
3032         * objfiles.c (have_partial_symbols, have_full_symbols)
3033         (have_minimal_symbols, qsort_cmp, update_section_map)
3034         (shared_objfile_contains_address_p)
3035         (default_iterate_over_objfiles_in_search_order): Update.
3036         * objc-lang.c (info_selectors_command, info_classes_command)
3037         (find_methods): Update.
3038         * minsyms.c (find_solib_trampoline_target): Update.
3039         * maint.c (maintenance_info_sections)
3040         (maintenance_translate_address, count_symtabs_and_blocks):
3041         Update.
3042         * main.c (captured_main_1): Update.
3043         * linux-thread-db.c (try_thread_db_load_from_pdir)
3044         (has_libpthread): Update.
3045         * linespec.c (iterate_over_all_matching_symtabs)
3046         (search_minsyms_for_name): Update.
3047         * jit.c (jit_find_objf_with_entry_addr): Update.
3048         * hppa-tdep.c (find_unwind_entry)
3049         (hppa_lookup_stub_minimal_symbol): Update.
3050         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3051         Update.
3052         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3053         (elf_gnu_ifunc_resolve_by_got): Update.
3054         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3055         * dwarf-index-write.c (save_gdb_index_command): Update.
3056         * cp-support.c (add_symbol_overload_list_qualified): Update.
3057         * breakpoint.c (create_overlay_event_breakpoint)
3058         (create_longjmp_master_breakpoint)
3059         (create_std_terminate_master_breakpoint)
3060         (create_exception_master_breakpoint): Update.
3061         * blockframe.c (find_pc_partial_function): Update.
3062         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3063         (ada_collect_symbol_completion_matches)
3064         (ada_add_global_exceptions): Update.
3065
3066 2019-01-17  Tom Tromey  <tom@tromey.com>
3067
3068         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3069         declare VEC.
3070         (solib_target_parse_libraries): Change return type.
3071         (library_list_start_segment, library_list_start_section)
3072         (library_list_end_library, library_list_start_library); Update.
3073         (solib_target_free_library_list): Remove.
3074         (solib_target_parse_libraries): Remove cleanup.  Change return
3075         type.
3076         (solib_target_current_sos): Update.
3077
3078 2019-01-17  Tom Tromey  <tromey@bapiya>
3079
3080         * valprint.c: Replace "the the" with "the".
3081         * symtab.c: Replace "the the" with "the".
3082         * solib.c: Replace "the the" with "the".
3083         * solib-dsbt.c: Replace "the the" with "the".
3084         * linespec.c: Replace "the the" with "the".
3085         * dwarf2loc.h: Replace "the the" with "the".
3086         * amd64-windows-tdep.c: Replace "the the" with "the".
3087         * aarch64-tdep.c: Replace "the the" with "the".
3088
3089 2019-01-16  Keith Seitz  <keiths@redhat.com>
3090
3091         PR gdb/23773
3092         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3093         <builder>: Rename to ..
3094         <m_builder>: ... this and make private.
3095         (dwarf2_cu::get_builder): New method.  Change all users of
3096         `builder' to use this method.
3097         (dwarf2_start_symtab): Move to ...
3098         (dwarf2_cu::start_symtab): ... here.  Update all callers
3099         (setup_type_unit_groups): Move to ...
3100         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3101         callers.
3102         (dwarf2_cu::reset_builder): New method.
3103         (process_full_compunit, process_full_type_unit): Use
3104         dwarf2_cu::reset_builder.
3105         (follow_die_offset): Record the ancestor CU if it is different
3106         from the followed DIE's CU.
3107         (follow_die_sig_1): Likewise.
3108
3109 2019-01-15  Tom Tromey  <tom@tromey.com>
3110
3111         * remote.c (class remote_state) <buf>: Now a char_vector.
3112         <buf_size>: Remove.
3113         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3114         parameter.
3115         (remote_target::getpkt_or_notif_sane_1)
3116         (remote_target::getpkt_sane)
3117         (remote_target::getpkt_or_notif_sane): Likewise.
3118         (class remote_target) <putpkt>: New overload.
3119         (remote_target::read_frame): Change type of "buf_p".  Remove
3120         sizeof_p parameter.
3121         (packet_ok): New overload.
3122         (packet_check_result): New overload.
3123         Update all uses.
3124
3125 2019-01-14  Tom Tromey  <tom@tromey.com>
3126
3127         * remote-notif.c (handle_notification, remote_notif_ack)
3128         (remote_notif_parse): Make "buf" const.
3129         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3130         const.
3131         (remote_notif_parse, remote_notif_ack, handle_notification):
3132         Likewise.
3133         * remote.c (remote_notif_stop_parse): Make "buf" const.
3134         (remote_target::remote_parse_stop_reply): Make "buf" const.
3135         (remote_notif_stop_ack): Make "buf" const.
3136
3137 2019-01-14  Tom Tromey  <tom@tromey.com>
3138
3139         * remote.c (remote_console_output): Make parameter const.
3140
3141 2019-01-14  Tom Tromey  <tom@tromey.com>
3142
3143         * target-debug.h (target_debug_print_signals): Constify.
3144         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3145         * procfs.c (procfs_target::pass_signals): Update.
3146         * linux-nat.c (linux_nat_target::pass_signals): Update.
3147         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3148         * target-delegates.c: Rebuild.
3149         * remote.c (remote_target::program_signals): Update.
3150         (remote_target::pass_signals): Update.
3151         * target.c (target_pass_signals): Constify argument.
3152         (target_program_signals): Likewise.
3153         * target.h (struct target_ops) <pass_signals, program_signals>:
3154         Constify argument.
3155         (target_pass_signals, target_program_signals): Constify argument.
3156
3157 2019-01-14  Tom Tromey  <tom@tromey.com>
3158
3159         PR tui/28819:
3160         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3161
3162 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3163
3164         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3165         field.
3166         * rs6000-tdep.c: Include reggroups.h.
3167         (IS_V_ALIAS_PSEUDOREG): Define.
3168         (rs6000_register_name): Return names for the "vX" aliases.
3169         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3170         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3171         aliases.  Call default_register_reggroup_p for all other
3172         pseudo-registers.
3173         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3174         New functions.
3175         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3176         Handle "vX" aliases.
3177         (v_alias_pseudo_register_collect): New function.
3178         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3179         (rs6000_gdbarch_init): Initialize "vX" aliases as
3180         pseudo-registers.  Restore registration of
3181         rs6000_pseudo_register_reggroup_p with
3182         set_tdesc_pseudo_register_reggroup_p.
3183
3184 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3185
3186         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3187         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3188         set_gdbarch_num_pseudo_regs.
3189
3190 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3191
3192         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3193         Remove arg prefixname, add do_set and do_show.
3194         Add member functions set_list and show_list.
3195         * cli/cli-style.c (class cli_style_option): Update accordingly.
3196         (style_set_list): Move to file scope.
3197         (style_show_list): Likewise.
3198         (set_style): Call help_list.
3199         (show_style): Call cmd_show_list.
3200         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3201         Update to use the new macro.
3202
3203 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3204
3205         * ada-lang.c (_initialize_ada_language): Expand the help text
3206         for the "catch exception" command.
3207
3208 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3209
3210         * symtab.c (matching_obj_sections): Initialize obj,
3211         declare it closer to its usage.
3212
3213 2019-01-10  Tom Tromey  <tom@tromey.com>
3214
3215         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3216         (basic_inf_threads_range): Remove.
3217         (inf_threads_range, inf_non_exited_threads_range)
3218         (safe_inf_threads_range): Use next_adapter.
3219
3220 2019-01-10  Keith Seitz  <keiths@redhat.com>
3221
3222         PR gdb/23712
3223         PR symtab/23010
3224         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3225         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3226
3227 2019-01-10  Keith Seitz  <keiths@redhat.com>
3228
3229         PR gdb/23712
3230         PR symtab/23010
3231         * dictionary.c (pending_to_vector): Remove.
3232         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3233         Remove _1 suffix, replacing functions of the same name.  Update
3234         all callers.
3235         (dict_create_hashed, dict_create_hashed_expandable)
3236         (dict_create_linear, dict_create_linear_expandable, dict_free)
3237         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3238         Make functions static.
3239
3240 2019-01-10  Keith Seitz  <keiths@redhat.com>
3241
3242         PR gdb/23712
3243         PR symtab/23010
3244         * dictionary.h (struct dictionary): Replace declaration with
3245         multidictionary.
3246         (dict_create_hashed, dict_create_hashed_expandable)
3247         (dict_create_linear, dict_create_linear_expandable)
3248         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3249         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3250         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3251         taking multidictionary argument.
3252         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3253         * block.h (struct block) <dict>: Change to multidictionary
3254         and rename `multidict'.
3255         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3256         symmisc.c: Update all dictionary references to multidictionary.
3257
3258 2019-01-10  Keith Seitz  <keiths@redhat.com>
3259
3260         PR gdb/23712
3261         PR symtab/23010
3262         * dictionary.c: Include unordered_map.
3263         (pending_to_vector): New function.
3264         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3265         Rewrite the non-"_1" functions to take vector instead
3266         of linked list.
3267         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3268         "new" _1 versions of the same name.
3269         (multidictionary): Define.
3270         (std::hash<enum language): New definition.
3271         (collate_pending_symbols_by_language, mdict_create_hashed)
3272         (mdict_create_hashed_expandable, mdict_create_linear)
3273         (mdict_create_linear_expandable, mdict_free)
3274         (find_language_dictionary, create_new_language_dictionary)
3275         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3276         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3277         (mdict_size, mdict_empty): New functions.
3278         * dictionary.h (mdict_iterator): Define.
3279
3280 2019-01-10  Pedro Alves  <palves@redhat.com>
3281
3282         * breakpoint.c (read_uploaded_action)
3283         (create_tracepoint_from_upload): Adjust to use
3284         gdb::unique_xmalloc_ptr.
3285         * ctf.c (ctf_write_uploaded_tp):
3286         (SET_ARRAY_FIELD): Use emplace_back.
3287         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3288         * tracefile-tfile.c (tfile_write_uploaded_tp):
3289         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3290         gdb::unique_xmalloc_ptr.
3291         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3292         at_string, cond_string, cmd_strings>: Replace char pointers
3293         with gdb::unique_xmalloc_ptr.
3294
3295 2019-01-10  Pedro Alves  <palves@redhat.com>
3296
3297         * solib-target.c (library_list_start_library): Don't xstrdup name.
3298
3299 2019-01-10  Pedro Alves  <palves@redhat.com>
3300
3301         * mdebugread.c (parse_partial_symbols): Use
3302         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3303
3304 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3305
3306         * linux-fork.c (scoped_switch_fork_info)
3307         <~scoped_switch_fork_info>: Fix incorrect variable name.
3308
3309 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3310
3311         * linux-fork.c (scoped_switch_fork_info)
3312         <scoped_switch_fork_info>: Make explicit.
3313         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3314
3315 2019-01-10  Tom Tromey  <tom@tromey.com>
3316
3317         * objfiles.h (objfile::reset_psymtabs): Update.
3318         * objfiles.c (objfile::objfile): Update.
3319         * psymtab.h (psymtab_storage::obstack): Update.
3320         (psymtab_storage::m_obstack): Use gdb::optional.
3321         (class psymtab_storage): Update comment.  Remove objfile
3322         parameter.
3323         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3324
3325 2019-01-10  Tom Tromey  <tom@tromey.com>
3326
3327         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3328         <free_psymtabs>: Now private.
3329         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3330         (allocate_psymtab): Use new method.
3331
3332 2019-01-10  Tom Tromey  <tom@tromey.com>
3333
3334         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3335         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3336         * mdebugread.c (parse_partial_symbols): Use
3337         allocate_dependencies.
3338         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3339         allocate_dependencies.
3340         (process_psymtab_comp_unit_reader)
3341         (build_type_psymtab_dependencies): Likewise.
3342         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3343
3344 2019-01-10  Tom Tromey  <tom@tromey.com>
3345
3346         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3347         PSYMBOL_SET_LANGUAGE.
3348         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3349
3350 2019-01-10  Tom Tromey  <tom@tromey.com>
3351
3352         * psymtab.h (psymtab_storage::obstack): New method.
3353         <m_obstack>: Rename from obstack; now private.
3354         * psymtab.c (psymtab_storage): Update.
3355         * dwarf2read.c (create_addrmap_from_index)
3356         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3357         Update.
3358
3359 2019-01-10  Tom Tromey  <tom@tromey.com>
3360
3361         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3362         * objfiles.h (objfile::reset_psymtabs): New method.
3363
3364 2019-01-10  Tom Tromey  <tom@tromey.com>
3365
3366         * symmisc.c (print_symbol_bcache_statistics): Update.
3367         (print_objfile_statistics): Update.
3368         * symfile.c (reread_symbols): Update.
3369         * psymtab.h (class psymtab_storage): New.
3370         * psymtab.c (psymtab_storage): New constructor.
3371         (~psymtab_storage): New destructor.
3372         (require_partial_symbols): Update.
3373         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3374         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3375         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3376         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3377         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3378         (start_psymtab_common, end_psymtab_common)
3379         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3380         (allocate_psymtab): Update.
3381         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3382         Update.
3383         (dump_psymtab_addrmap, maintenance_print_psymbols)
3384         (maintenance_check_psymtabs): Update.
3385         (class objfile_psymtabs): Move to objfiles.h.
3386         * psympriv.h (discard_psymtab): Now inline.
3387         (psymtab_discarder::psymtab_discarder): Update.
3388         (psymtab_discarder::~psymtab_discarder): Update.
3389         (ALL_OBJFILE_PSYMTABS): Rewrite.
3390         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3391         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3392         Remove fields.
3393         <partial_symtabs>: New field.
3394         (class objfile_psymtabs): Move from psymtab.h.  Update.
3395         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3396         psymbol_cache.
3397         (objfile::~objfile): Don't destroy psymbol_cache.
3398         * mdebugread.c (parse_partial_symbols): Update.
3399         * dwarf2read.c (create_addrmap_from_index)
3400         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3401         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3402         (add_partial_subprogram, dwarf2_ranges_read): Update.
3403         * dwarf-index-write.c (write_address_map)
3404         (write_one_signatured_type, recursively_write_psymbols)
3405         (class debug_names, class debug_names, write_psymtabs_to_index):
3406         Update.
3407
3408 2019-01-10  Tom Tromey  <tom@tromey.com>
3409
3410         * symtab.h (SYMBOL_SET_NAMES): Update.
3411         (symbol_set_names): Update.
3412         (MSYMBOL_SET_NAMES): Update.
3413         * symtab.c (symbol_set_names): Change argument to be an
3414         objfile_per_bfd_storage.
3415         * psymtab.c (add_psymbol_to_bcache): Update.
3416         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3417
3418 2019-01-10  Tom Tromey  <tom@tromey.com>
3419
3420         * symtab.c (create_demangled_names_hash): Change argument to be an
3421         objfile_per_bfd_storage.
3422         (symbol_set_names): Update.
3423
3424 2019-01-10  Tom Tromey  <tom@tromey.com>
3425
3426         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3427         init_psymbol_list.
3428         * psymtab.c (init_psymbol_list): Do nothing if already called.
3429         * psympriv.h (init_psymbol_list): Add comment.
3430         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3431         init_psymbol_list.
3432         * dbxread.c (dbx_symfile_read): Unconditionally call
3433         init_psymbol_list.
3434
3435 2019-01-10  Tom Tromey  <tom@tromey.com>
3436
3437         * xcoffread.c (scan_xcoff_symtab): Update.
3438         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3439         "where".
3440         * mdebugread.c (parse_partial_symbols)
3441         (handle_psymbol_enumerators): Update.
3442         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3443         * dbxread.c (read_dbx_symtab): Update.
3444         * psympriv.h (psymbol_placement): New enum.
3445         (add_psymbol_to_list): Update.
3446
3447 2019-01-10  Tom Tromey  <tom@tromey.com>
3448
3449         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3450         static_psymbols parameters.
3451         (scan_xcoff_symtab): Update.
3452         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3453         static_psymbols parameters.
3454         * psympriv.h (start_psymtab_common): Update.
3455         * mdebugread.c (parse_partial_symbols): Update.
3456         * dwarf2read.c (create_partial_symtab): Update.
3457         * dbxread.c (read_dbx_symtab): Update.
3458         (start_psymtab): Remove global_psymbols and static_psymbols
3459         parameters.
3460
3461 2019-01-10  Tom Tromey  <tom@tromey.com>
3462
3463         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3464         * psymtab.c (allocate_psymtab): Add comment.
3465         * psympriv.h (allocate_psymtab): Add comment.
3466         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3467         initializations.
3468         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3469
3470 2019-01-10  Tom Tromey  <tom@tromey.com>
3471
3472         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3473         Don't declare.
3474         * mipsread.c: Include mdebugread.h.
3475         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3476         Declare.
3477         * elfread.c: Include mdebugread.h.
3478
3479 2019-01-09  Tom Tromey  <tom@tromey.com>
3480
3481         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3482         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3483         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3484         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3485         (psym_lookup_symbol, psym_find_last_source_symtab)
3486         (psym_forget_cached_source_info, psym_print_stats)
3487         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3488         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3489         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3490         (psym_find_compunit_symtab_by_address)
3491         (maintenance_print_psymbols, maintenance_info_psymtabs)
3492         (maintenance_check_psymtabs): Use ranged for.
3493         * psymtab.h (class objfile_psymtabs): New.
3494         (require_partial_symbols): Return objfile_psymtabs.
3495         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3496
3497 2019-01-09  Tom Tromey  <tom@tromey.com>
3498
3499         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3500         (find_pc_mapped_section, list_overlays_command)
3501         (map_overlay_command, unmap_overlay_command)
3502         (simple_overlay_update): Use all_objfiles.
3503         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3504         * printcmd.c (info_symbol_command): Use all_objfiles.
3505         * objfiles.h (ALL_OBJSECTIONS): Remove.
3506         * maint.c (maintenance_translate_address): Use all_objfiles.
3507         * gcore.c (gcore_create_callback): Use all_objfiles.
3508         (objfile_find_memory_regions): Likewise.
3509
3510 2019-01-09  Tom Tromey  <tom@tromey.com>
3511
3512         * symtab.c (find_line_symtab, info_sources_command)
3513         (make_source_files_completion_list): Use objfile_compunits.
3514         * source.c (select_source_symtab): Use objfile_compunits.
3515         * objfiles.h (struct objfile): Update comment.
3516         (ALL_OBJFILES): Remove.
3517         (ALL_FILETABS): Remove.
3518         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3519         objfile_compunits.
3520
3521 2019-01-09  Tom Tromey  <tom@tromey.com>
3522
3523         * symmisc.c (print_objfile_statistics, dump_objfile)
3524         (maintenance_print_symbols): Use compunit_filetabs.
3525         * source.c (forget_cached_source_info_for_objfile): Use
3526         compunit_filetabs.
3527         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3528         (ALL_FILETABS): Use compunit_filetabs.
3529         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3530         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3531
3532 2019-01-09  Tom Tromey  <tom@tromey.com>
3533
3534         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3535         (compunit_filetabs): New.
3536         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3537         compunit_filetabs.
3538         (info_sources_command, make_source_files_completion_list): Remove
3539         declaration.
3540         * symmisc.c (print_objfile_statistics, dump_objfile)
3541         (maintenance_print_symbols): Remove declaration.
3542         (maintenance_info_symtabs): Use compunit_filetabs.
3543         (maintenance_info_line_tables): Likewise.
3544         * source.c (select_source_symtab): Change local variable name.
3545         (forget_cached_source_info_for_objfile): Remove declaration.
3546         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3547         * objfiles.c (objfile_relocate1): Remove declaration.
3548         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3549         declaration.
3550         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3551         * coffread.c (coff_symtab_read): Remove declaration.
3552         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3553         compunit_filetabs.
3554
3555 2019-01-09  Tom Tromey  <tom@tromey.com>
3556
3557         * symtab.c (lookup_objfile_from_block)
3558         (find_pc_sect_compunit_symtab, search_symbols)
3559         (default_collect_symbol_completion_matches_break_on): Use
3560         objfile_compunits.
3561         * objfiles.h (ALL_COMPUNITS): Remove.
3562         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3563         * cp-support.c (add_symbol_overload_list_qualified): Use
3564         objfile_compunits.
3565         * ada-lang.c (ada_collect_symbol_completion_matches)
3566         (ada_add_global_exceptions): Use objfile_compunits.
3567
3568 2019-01-09  Tom Tromey  <tom@tromey.com>
3569
3570         * source.c (select_source_symtab)
3571         (forget_cached_source_info_for_objfile): Remove declaration.
3572         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3573         declaration.
3574         * maint.c (count_symtabs_and_blocks): Remove declaration.
3575         * cp-support.c (add_symbol_overload_list_qualified): Remove
3576         declaration.
3577         * coffread.c (coff_symtab_read): Remove declaration.
3578         * symtab.c (lookup_symbol_in_objfile_symtabs)
3579         (basic_lookup_transparent_type_1): Use objfile_compunits.
3580         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3581         (info_sources_command, search_symbols)
3582         (default_collect_symbol_completion_matches_break_on)
3583         (make_source_files_completion_list): Remove declaration.
3584         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3585         (ada_collect_symbol_completion_matches)
3586         (ada_add_global_exceptions): Remove declaration.
3587         * linespec.c (iterate_over_all_matching_symtabs): Use
3588         objfile_compunits.
3589         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3590         (class objfile_compunits): New.
3591         (ALL_COMPUNITS): Use objfile_compunits.
3592         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3593         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3594         objfile_compunits.
3595         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3596
3597 2019-01-09  Tom Tromey  <tom@tromey.com>
3598
3599         * symtab.c (search_symbols)
3600         (default_collect_symbol_completion_matches_break_on): Use
3601         objfile_msymbols.
3602         * ada-lang.c (ada_lookup_simple_minsym)
3603         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3604         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3605         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3606         objfile_msymbols.
3607         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3608         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3609         * objc-lang.c (find_methods): Use objfile_msymbols.
3610         (info_selectors_command, info_classes_command): Likewise.
3611         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3612         * objfiles.h (class objfile_msymbols): New.
3613         (ALL_OBJFILE_MSYMBOLS): Remove.
3614         (ALL_MSYMBOLS): Remove.
3615
3616 2019-01-09  Tom Tromey  <tom@tromey.com>
3617
3618         * common/next-iterator.h (next_adapter): Add Iterator template
3619         parameter.
3620         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3621         (class all_objfiles_safe): New.
3622         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3623         * objfiles.c (put_objfile_before): Update comment.
3624         (add_separate_debug_objfile): Likewise.
3625         (free_all_objfiles): Use all_objfiles_safe.
3626         (objfile_purge_solibs): Likewise.
3627
3628 2019-01-09  Tom Tromey  <tom@tromey.com>
3629
3630         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3631         (expand_symtab_containing_pc, lookup_static_symbol)
3632         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3633         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3634         all_objfiles.
3635         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3636         * breakpoint.c (create_overlay_event_breakpoint)
3637         (create_longjmp_master_breakpoint)
3638         (create_std_terminate_master_breakpoint)
3639         (create_exception_master_breakpoint): Use all_objfiles.
3640         * linux-thread-db.c (try_thread_db_load_from_pdir)
3641         (has_libpthread): Use all_objfiles.
3642         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3643         * linespec.c (iterate_over_all_matching_symtabs)
3644         (search_minsyms_for_name): Use all_objfiles.
3645         * maint.c (maintenance_info_sections): Use all_objfiles.
3646         * main.c (captured_main_1): Use all_objfiles.
3647         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3648         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3649         * guile/scm-pretty-print.c
3650         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3651         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3652         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3653         (maintenance_print_msymbols): Use all_objfiles.
3654         * source.c (select_source_symtab): Use all_objfiles.
3655         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3656         * symfile.c (remove_symbol_file_command)
3657         (expand_symtabs_matching, map_symbol_filenames): Use
3658         all_objfiles.
3659         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3660         all_objfiles.
3661         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3662         * objc-lang.c (find_methods): Use all_objfiles.
3663         * objfiles.c (have_partial_symbols, have_full_symbols)
3664         (have_minimal_symbols, qsort_cmp)
3665         (default_iterate_over_objfiles_in_search_order): Use
3666         all_objfiles.
3667         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3668         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3669         (maintenance_check_psymtabs): Use all_objfiles.
3670         (ALL_PSYMTABS): Remove.
3671         * compile/compile-object-run.c (do_module_cleanup): Use
3672         all_objfiles.
3673         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3674         * cp-support.c (add_symbol_overload_list_qualified): Use
3675         all_objfiles.
3676         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3677         Use all_objfiles.
3678         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3679         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3680         all_objfiles.
3681         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3682         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3683         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3684         Uses all_objfiles.
3685         * solib.c (solib_read_symbols): Use all_objfiles
3686
3687 2019-01-09  Tom Tromey  <tom@tromey.com>
3688
3689         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3690         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3691         all_objfiles.
3692         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3693         * symmisc.c (print_symbol_bcache_statistics)
3694         (print_objfile_statistics, maintenance_print_objfiles)
3695         (maintenance_info_symtabs, maintenance_check_symtabs)
3696         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3697         all_objfiles.
3698         * source.c (forget_cached_source_info): Use all_objfiles.
3699         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3700         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3701         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3702         * objfiles.c (update_section_map): Use all_objfiles.
3703         (shared_objfile_contains_address_p): Likewise.
3704         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3705         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3706
3707 2019-01-09  Tom Tromey  <tom@tromey.com>
3708
3709         * common/next-iterator.h: New file.
3710         * objfiles.h (class all_objfiles): New.
3711         (struct objfile_iterator): New.
3712
3713 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3714
3715         * NEWS: Move the description of the changed "frame", "select-frame",
3716          and "info frame" commands to the Changed commands section.
3717
3718 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3719
3720         * gdbtypes.c (check_stub_method_group): Remove handling of old
3721         mangling schemes.
3722         * linespec.c (find_methods): Likewise.
3723         * stabsread.c (read_member_functions): Likewise.
3724         * valops.c (search_struct_method): Likewise.
3725         (value_struct_elt_for_reference): Likewise.
3726         * NEWS: Mention this change.
3727
3728 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3731         print_source_lines.
3732         * source.c (print_source_lines_base): Update line number check.
3733         (print_source_lines): New function.
3734         (source_lines_range::source_lines_range): New function.
3735         * source.h (class source_lines_range): New class.
3736         (print_source_lines): New declaration.
3737
3738 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3739
3740         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3741
3742 2019-01-08  Tom Tromey  <tom@tromey.com>
3743             Simon Marchi  <simon.marchi@ericsson.com>
3744
3745         PR gdb/24060
3746         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3747         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3748         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3749         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3750         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3751         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3752
3753 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3754
3755         * source.c (select_source_symtab): Move header comment to
3756         declaration in source.h.
3757         (forget_cached_source_info_for_objfile): Likewise.
3758         (forget_cached_source_info): Likewise.
3759         (identify_source_line): Likewise.
3760         * source.h (identify_source_line): Move declaration from symtab.h
3761         and add comment from source.c
3762         (print_source_lines): Likewise.
3763         (forget_cached_source_info_for_objfile): Likewise.
3764         (forget_cached_source_info): Likewise.
3765         (select_source_symtab): Likewise.
3766         (enum print_source_lines_flag): Move definition from symtab.h.
3767         * symtab.h (identify_source_line): Move declaration to source.h.
3768         (print_source_lines): Likewise.
3769         (forget_cached_source_info_for_objfile): Likewise.
3770         (forget_cached_source_info): Likewise.
3771         (select_source_symtab): Likewise.
3772         (enum print_source_lines_flag): Move definition to source.h.
3773         * tui/tui-hooks.c: Add 'source.h' include.
3774
3775 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * source.c (print_source_lines_base): Handle requests to print
3778         reverse line number sequences, and guard against empty lines
3779         string.
3780
3781 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * source.c (print_source_lines_base): Fix skip of '\r' if next
3784         character is '\n'.
3785
3786 2019-01-06  Tom Tromey  <tom@tromey.com>
3787
3788         * c-exp.y (struct c_parse_state) <macro_original_text,
3789         expansion_obstack>: New member.
3790         (macro_original_text, expansion_obstack): Remove globals.
3791         (scan_macro_expansion, scanning_macro_expansion)
3792         (finished_macro_expansion): Update.
3793         (scan_macro_cleanup): Remove.
3794         (yylex, c_parse): Update.
3795
3796 2019-01-06  Tom Tromey  <tom@tromey.com>
3797
3798         * c-exp.y (struct c_parse_state) <strings>: New member.
3799         (operator_stoken): Update.
3800
3801 2019-01-06  Tom Tromey  <tom@tromey.com>
3802
3803         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3804         (union type_stack_elt) <typelist_val>: Now a pointer to
3805         std::vector.
3806         (type_stack_cleanup): Don't declare.
3807         (push_typelist): Update.
3808         * parse.c (pop_typelist): Return a std::vector.
3809         (push_typelist): Take a std::vector.
3810         (follow_types): Update.  Do not free args.
3811         (type_stack_cleanup): Remove.
3812         * c-exp.y (struct c_parse_state): New.
3813         (cpstate): New global.
3814         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3815         (nonempty_typelist): Update.
3816         (func_mod): Create a new vector.
3817         (c_parse): Create a c_parse_state.
3818         (check_parameter_typelist): Do not delete params.
3819         (function_method): Update.  Do not delete type_list.
3820
3821 2019-01-06  Tom Tromey  <tom@tromey.com>
3822
3823         PR gdb/28155:
3824         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3825         check_typedef.
3826         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3827         (print_return_value): Likewise.
3828
3829 2019-01-05  Tom Tromey  <tom@tromey.com>
3830
3831         * contrib/cleanup_check.py: Remove.
3832         * contrib/gcc-with-excheck: Remove.
3833         * contrib/exsummary.py: Remove.
3834         * contrib/excheck.py: Remove.
3835
3836 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3837
3838         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3839         NULL. Initialize tpprev to NULL instead of assigning it
3840         to NULL on the next statement.
3841         * windows-nat.c (windows_delete_thread): Remove check for
3842         main_thread_id before printing thread exit notifications.
3843         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3844         Remove thread ID check against main_thread_id.
3845         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3846         windows_delete_thread.
3847         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3848
3849 2019-01-04  Tom Tromey  <tom@tromey.com>
3850
3851         * compile/compile.c (_initialize_compile): Use upper case for
3852         metasyntactic variables.
3853         * symmisc.c (_initialize_symmisc): Use upper case for
3854         metasyntactic variables.
3855         * psymtab.c (_initialize_psymtab): Use upper case for
3856         metasyntactic variables.
3857         * demangle.c (demangle_command): Use upper case for metasyntactic
3858         variables.
3859         (_initialize_demangler): Likewise.
3860         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3861         variables.
3862
3863 2019-01-03  Tom Tromey  <tom@tromey.com>
3864
3865         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3866
3867 2019-01-03  Tom Tromey  <tom@tromey.com>
3868
3869         * python/py-symtab.c (salpy_str): Update.
3870         (struct salpy_sal_object) <symtab>: Now a PyObject.
3871         (salpy_dealloc): Update.
3872         (del_objfile_sal): Use gdbpy_ref.
3873
3874 2019-01-03  Tom Tromey  <tom@tromey.com>
3875
3876         * python/py-type.c (convert_field): Use new_reference.  Return
3877         gdbpy_ref.
3878         (make_fielditem): Return gdbpy_ref.
3879         (typy_fields): Update.
3880         (typy_getitem): Update.
3881         (field_name): Return gdbpy_ref.  Use new_reference.
3882         (typy_iterator_iternext): Update.
3883
3884 2019-01-03  Tom Tromey  <tom@tromey.com>
3885
3886         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3887
3888 2019-01-03  Tom Tromey  <tom@tromey.com>
3889
3890         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3891         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3892         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3893         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3894         (pspy_set_type_printers): Likewise.
3895         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3896         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3897         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3898         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3899         (objfpy_set_type_printers): Likewise.
3900
3901 2019-01-03  Tom Tromey  <tom@tromey.com>
3902
3903         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3904         (gdbpy_print_stack): Use gdbpy_err_fetch.
3905         * python/python-internal.h (class gdbpy_err_fetch): New class.
3906         (class gdbpy_enter) <m_error_type, m_error_value,
3907         m_error_traceback>: Remove.
3908         <m_error>: New member.
3909         (gdbpy_exception_to_string): Don't declare.
3910         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3911         * python/py-value.c (convert_value_from_python): Use
3912         gdbpy_err_fetch.
3913         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3914         gdbpy_exception_to_string.
3915         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3916         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3917         gdbpy_err_fetch.
3918
3919 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3920
3921         * linux-nat.c (delete_lwp_cleanup): Delete.
3922         (struct lwp_deleter): New struct.
3923         (lwp_info_up): New typedef.
3924         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3925         lwp_info_up.
3926
3927 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3928
3929         * linux-fork.c (class scoped_switch_fork_info): New class.
3930         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3931
3932 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3933
3934         * valops.c (find_overload_match): Remove use of null_cleanup, and
3935         calls to do_cleanups.
3936
3937 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3938
3939         * compile/compile-cplus-types.c
3940         (compile_cplus_instance::decl_name): Handle changes to
3941         cp_func_name.
3942         * cp-support.c (cp_func_name): Update header comment, update
3943         return type.
3944         * cp-support.h (cp_func_name): Update return type in declaration.
3945         * valops.c (find_overload_match): Move temp_func local to top
3946         level of function and change its type.  Use temp_func to hold and
3947         delete temporary string obtained from cp_func_name.
3948
3949 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3950
3951         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3952         gdb::char_vector, remove cleanup, and update uses of `msg`.
3953
3954 2019-01-03  Jim Wilson  <jimw@sifive.com>
3955
3956         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3957
3958 2019-01-02  Tom Tromey  <tom@tromey.com>
3959
3960         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3961         (tdesc_parse_xml): Remove cleanups.
3962         * target-descriptions.h (make_cleanup_free_target_description):
3963         Don't declare.
3964         (target_desc_deleter): New struct.
3965         (target_desc_up): New typedef.
3966         * target-descriptions.c (target_desc_deleter::operator()): Rename
3967         from free_target_description.
3968         (make_cleanup_free_target_description): Remove.
3969
3970 2019-01-02  Tom Tromey  <tom@tromey.com>
3971
3972         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3973         constructor, destructor.
3974         (linespec_parser): Remove typedef.
3975         (~linespec_parser): Rename from linespec_parser_delete.
3976         (linespec_lex_to_end, linespec_complete_label)
3977         (linespec_complete): Update.
3978         (decode_line_full): Remove cleanups.
3979         (decode_line_1): Update.
3980
3981 2019-01-02  Tom Tromey  <tom@tromey.com>
3982
3983         * python/python-internal.h (inferior_to_inferior_object): Change
3984         return type.
3985         * python/py-exitedevent.c (create_exited_event_object): Update.
3986         * python/py-inferior.c (inferior_to_inferior_object): Return
3987         gdbpy_ref.
3988         (python_new_inferior, python_inferior_deleted)
3989         (thread_to_thread_object, delete_thread_object)
3990         (build_inferior_list, gdbpy_selected_inferior): Update.
3991         * python/py-infthread.c (create_thread_object): Update.  Also fail
3992         if inferior_to_inferior_object fails.
3993
3994 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3995
3996         * inferior.h (class inferior) <displaced_step_state>: New field.
3997         * infrun.h (struct displaced_step_state): Move here from
3998         infrun.c.  Initialize fields, add constructor.
3999         <inf>: Remove field.
4000         <reset>: New method.
4001         * infrun.c (struct displaced_step_inferior_state): Move to
4002         infrun.h.
4003         (displaced_step_inferior_states): Remove.
4004         (get_displaced_stepping_state): Adust.
4005         (displaced_step_in_progress_any_inferior): Adjust.
4006         (displaced_step_in_progress_thread): Adjust.
4007         (displaced_step_in_progress): Adjust.
4008         (add_displaced_stepping_state): Remove.
4009         (get_displaced_step_closure_by_addr): Adjust.
4010         (remove_displaced_stepping_state): Remove.
4011         (infrun_inferior_exit): Call displaced_step_state.reset.
4012         (use_displaced_stepping): Don't check for NULL.
4013         (displaced_step_prepare_throw): Call
4014         get_displaced_stepping_state.
4015         (displaced_step_fixup): Don't check for NULL.
4016         (prepare_for_detach): Don't check for NULL.
4017
4018 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4019
4020         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4021          in case of call that did not complete.
4022
4023 2019-01-02  Andrey Utkin  <autkin@undo.io>
4024
4025         * symfile.c (find_separate_debug_file): Fix search of debug files for
4026         remote debuggee.
4027
4028 2019-01-02  Tom Tromey  <tom@tromey.com>
4029
4030         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4031         indentation.
4032         * python/py-frame.c (frapy_older): Remove cast.
4033         (frapy_newer): Likewise.
4034         * python/py-breakpoint.c (local_setattro): Remove cast.
4035         * python/py-arch.c (archpy_name): Remove local variable.
4036         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4037
4038 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4039
4040         * unittests/basic_string_view/element_access/char/empty.cc:
4041         Fix year range in copyright header.
4042
4043 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4046         Delete.
4047         <operator==>: Update with for removed field.
4048         <hash>: Likewise.
4049         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4050         <isa_features>: ...this.
4051         <abi_features>: New field.
4052         (riscv_isa_flen): Update comment.
4053         (riscv_abi_xlen): New declaration.
4054         (riscv_abi_flen): New declaration.
4055         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4056         isa_features.
4057         (riscv_abi_xlen): New function.
4058         (riscv_isa_flen): Update to get answer from isa_features.
4059         (riscv_abi_flen): New function.
4060         (riscv_has_fp_abi): Update to get answer from abi_features.
4061         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4062         xlen and flen.
4063         (riscv_call_info) <xlen, flen>: Update comment.
4064         (riscv_call_arg_struct): Remove invalid assertions
4065         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4066         is removed.
4067         (riscv_gdbarch_init): Gather isa features and abi features
4068         separately, ensure both match on the gdbarch when reusing an old
4069         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4070         a target with 64-bit float hardware.
4071
4072 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4073
4074         * source.c (search_command_helper): Stop reverse search
4075         when line 1 has been searched.
4076
4077 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078
4079         * record-full.c (record_full_base_target::close): Rewrite
4080         record_full_core_buf_list free logic.
4081
4082 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4083
4084         * break-catch-syscall.c (print_one_catch_syscall): xfree
4085         the last text.
4086
4087 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4088
4089         * top.c (print_gdb_version): Update Copyright year in version
4090         message.
4091
4092 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4093
4094         Update copyright year range in all GDB files.
4095
4096 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4097
4098         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4099
4100 For older changes see ChangeLog-2018.
4101 \f
4102 Local Variables:
4103 mode: change-log
4104 left-margin: 8
4105 fill-column: 74
4106 version-control: never
4107 coding: utf-8
4108 End:
4109