gdb/ChangeLog

   1 2019-10-17  Tom Tromey  <tromey@adacore.com>
   2
   3         * configure: Rebuild.
   4         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
   5         in AC_CONFIG_FILES invocation.
   6         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
   7         new-style config.status invocation.
   8
   9 2019-10-17  Tom de Vries  <tdevries@suse.de>
  10
  11         * arm-nbsd-nat.c: Fix typos in comments.
  12         * arm-tdep.c: Same.
  13         * darwin-nat-info.c: Same.
  14         * dwarf2read.c: Same.
  15         * elfread.c: Same.
  16         * event-top.c: Same.
  17         * findvar.c: Same.
  18         * gdbtypes.c: Same.
  19         * hppa-tdep.c: Same.
  20         * i386-tdep.c: Same.
  21         * jit.c: Same.
  22         * main.c: Same.
  23         * mdebugread.c: Same.
  24         * moxie-tdep.c: Same.
  25         * nto-procfs.c: Same.
  26         * osabi.c: Same.
  27         * ppc-linux-tdep.c: Same.
  28         * remote.c: Same.
  29         * riscv-tdep.c: Same.
  30         * s390-tdep.c: Same.
  31         * sh-tdep.c: Same.
  32         * sparc-linux-tdep.c: Same.
  33         * sparc-nat.c: Same.
  34         * stack.c: Same.
  35         * target-descriptions.c: Same.
  36         * top.c: Same.
  37         * varobj.c: Same.
  38
  39 2019-10-16  Tom Tromey  <tom@tromey.com>
  40
  41         * objfiles.h (struct objfile) <original_name>: Now const.
  42
  43 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
  44
  45         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
  46         pass on to sigsetjmp's second argument.
  47         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
  48
  49 2019-10-16  Keith Seitz  <keiths@redhat.com>
  50
  51         PR gdb/23567
  52         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
  53         sections whose size is greater than the file size.
  54
  55 2019-10-16  Jim Wilson  <jimw@sifive.com>
  56
  57         * riscv-tdep.c (riscv_gcc_target_options): New.
  58         (riscv_gnu_triplet_regexp): New.
  59         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
  60         set_gdbarch_gnu_triplet_regexp.
  61
  62 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
  63
  64         * Makefile.in: Add xml-builtin.h.
  65         * features/feature_to_c.sh: Add an include for xml-builtin.h
  66         to ensure that the compiler checks that the types match.
  67         * xml-builtin.h: New file.
  68         * xml-support.c (fetch_xml_builtin): Add missing const.
  69         * xml-support.h: Remove declaration of xml_builtins.
  70
  71 2019-10-16  Tom de Vries  <tdevries@suse.de>
  72
  73         PR tdep/25096
  74         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
  75         (amd64_classify_aggregate): ... here.
  76         (amd64_classify_aggregate_field): Handled fiels of nested structs
  77         recursively.
  78
  79 2019-10-16  Tom de Vries  <tdevries@suse.de>
  80
  81         PR tdep/24104
  82         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
  83         that handles 'theclass'.
  84
  85 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  86
  87         * linespec.c (decode_digits_ordinary): Update comment.
  88         * make-target-delegates: No longer need to handle VEC case.
  89         * memrange.c (normalize_mem_ranges): Update comment.
  90         * namespace.c (add_using_directive): Update comment.
  91         * objc-lang.c (uniquify_strings): Update comment.
  92         * ppc-linux-nat.c (struct thread_points): Update comment.
  93         * probe.h (find_probes_in_objfile): Update comment.
  94         * target.h (enum flash_preserve_mode): Update comment.
  95         * varobj.c (varobj_restrict_range): Update comment.
  96         * varobj.h (varobj_list_children): Update comment.
  97
  98 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  99
 100         * Makefile.in: Remove references to vec.h and vec.c.
 101         * aarch64-tdep.c: No longer include vec.h.
 102         * ada-lang.c: Likewise.
 103         * ada-lang.h: Likewise.
 104         * arm-tdep.c: Likewise.
 105         * ax.h: Likewise.
 106         * breakpoint.h: Likewise.
 107         * charset.c: Likewise.
 108         * cp-support.h: Likewise.
 109         * dtrace-probe.c: Likewise.
 110         * dwarf2read.c: Likewise.
 111         * extension.h: Likewise.
 112         * gdb_bfd.c: Likewise.
 113         * gdbsupport/gdb_vecs.h: Likewise.
 114         * gdbsupport/vec.c: Remove.
 115         * gdbsupport/vec.h: Remove.
 116         * gdbthread.h: Likewise.
 117         * guile/scm-type.c: Likewise.
 118         * inline-frame.c: Likewise.
 119         * machoread.c: Likewise.
 120         * memattr.c: Likewise.
 121         * memrange.h: Likewise.
 122         * namespace.h: Likewise.
 123         * nat/linux-btrace.h: Likewise.
 124         * osdata.c: Likewise.
 125         * parser-defs.h: Likewise.
 126         * progspace.h: Likewise.
 127         * python/py-type.c: Likewise.
 128         * record-btrace.c: Likewise.
 129         * rust-exp.y: Likewise.
 130         * solib-target.c: Likewise.
 131         * stap-probe.c: Likewise.
 132         * target-descriptions.c: Likewise.
 133         * target-memory.c: Likewise.
 134         * target.h: Likewise.
 135         * varobj.c: Likewise.
 136         * varobj.h: Likewise.
 137         * xml-support.h: Likewise.
 138
 139 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 142         Update for new std::vector based implementation.
 143         (process_psymtab_comp_unit_reader): Likewise.
 144         (scan_partial_symbols): Likewise.
 145         (recursively_compute_inclusions): Likewise.
 146         (compute_compunit_symtab_includes): Likewise.
 147         (process_imported_unit_die): Likewise.
 148         (queue_and_load_dwo_tu): Likewise.
 149         (follow_die_sig_1): Likewise.
 150         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 151         (typedef dwarf2_per_cu_ptr): Remove.
 152         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 153         function.
 154         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 155         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 156         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 157         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 158         std::vector.
 159
 160 2019-10-15  Tom Tromey  <tromey@adacore.com>
 161
 162         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 163         TID.
 164
 165 2019-10-15  Tom Tromey  <tromey@adacore.com>
 166
 167         * windows-nat.c (windows_nat_target::fetch_registers)
 168         (windows_nat_target::store_registers): Rename "pid" to "tid".
 169
 170 2019-10-15  Tom Tromey  <tromey@adacore.com>
 171
 172         * gdbarch.h, gdbarch.c: Rebuild.
 173         * gdbarch.sh (gcc_target_options): Change return type to
 174         std::string.
 175         * compile/compile.c (get_args): Update.
 176         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 177         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 178         std::string.
 179         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 180         std::string.
 181         * arch-utils.c (default_gcc_target_options): Return std::string.
 182         * arch-utils.h (default_gcc_target_options): Return std::string.
 183         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 184
 185 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 186
 187         * breakpoint.c (breakpoint_chain): Make static.
 188         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 189         of accessing breakpoint_chain.
 190
 191 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 192
 193         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 194         to a gdb::function_view and return value to bool.
 195         * breakpoint.h (iterate_over_breakpoints): Likewise.
 196         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 197         (pop_dummy_frame): Update.
 198         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 199         (gdbscm_breakpoints): Update.
 200         * python/py-breakpoint.c (build_bp_list): Update.
 201         (gdbpy_breakpoints): Update.
 202         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 203         Update.
 204         (bpfinishpy_handle_stop): Update.
 205         (bpfinishpy_handle_exit): Update.
 206         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 207         (svr4_update_solib_event_breakpoints): Update.
 208
 209 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 210
 211         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 212         when unwrapping single-field structs.
 213
 214 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 215
 216         * dwarf2read.c: Remove includes.
 217
 218 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 219
 220         * ui-out.c (ui_out::call_do_message): Silence
 221         -Wformat-nonliteral warning.
 222
 223 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 224
 225         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 226         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 227         include: readline/tilde.h.
 228
 229 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 230
 231         * remote.c (remote_target::get_trace_status): Remove declaration of
 232         trace_regblock_size.
 233
 234 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 235
 236         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 237         (show_user): Remove declaration of cmdlist.
 238         * cli/cli-cmds.h (max_user_call_depth): Declare.
 239         * cli/cli-script.c (execute_user_command): Remove declaration
 240         of max_user_call_depth.
 241
 242 2019-10-11  Jim Wilson  <jimw@sifive.com>
 243
 244         * gdbsupport/print-utils.h (pulongest): Fix comment.
 245         (plongest): Likewise.
 246         (phex): Add missing comment, mention leading zeros.
 247         (phex_nz): Add mention of no leading zeros to comment.
 248
 249         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 250         plongest instead of unsigned long long cast.
 251
 252 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 253
 254         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 255         for external_editor_command and gdbtk_test.
 256
 257 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 258
 259         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 260         * varobj.c (varobjdebug): Move comment to...
 261         * varobj.h (varobjdebug): ...here, and declare.
 262
 263 2019-10-09  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 266         erase_data_content.
 267
 268 2019-10-09  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 271         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 272         * tui/tui-command.c (tui_cmd_window::resize)
 273         (tui_refresh_cmd_win): Update.
 274         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 275         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 276         * tui/tui-data.c (~tui_gen_win_info): Remove.
 277         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 278         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 279         (tui_redisplay_readline, tui_mld_flush)
 280         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 281         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 282         (tui_data_window::erase_data_content)
 283         (tui_data_item_window::rerender)
 284         (tui_data_item_window::refresh_window): Update.
 285         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 286         (box_win, tui_gen_win_info::make_window)
 287         (tui_gen_win_info::make_visible): Update.
 288         (tui_delete_win): Remove.
 289         * tui/tui-winsource.c
 290         (tui_source_window_base::do_erase_source_content): Update.
 291         (tui_show_source_line, tui_source_window_base::update_tab_width)
 292         (tui_source_window_base::update_exec_info): Update.
 293         * tui/tui-data.h (struct curses_deleter): New.
 294         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 295         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 296
 297 2019-10-09  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 300
 301 2019-10-09  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 304         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 305
 306 2019-10-09  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 309         window height directly.
 310         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 311         declare.
 312         * tui/tui-layout.c (tui_default_win_height): Remove.
 313         (tui_default_win_viewport_height): Remove.
 314
 315 2019-10-09  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui.h: Remove comments.
 318
 319 2019-10-09  Tom de Vries  <tdevries@suse.de>
 320
 321         * python/lib/gdb/printer/bound_registers.py: Use
 322         '^builtin_type_bound128' as regexp argument for
 323         add_builtin_pretty_printer.
 324
 325 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 326
 327         * guile/guile.c (guile_extension_script_ops): Remove forward
 328         declaration and mark as static.
 329         (guile_script_ops): Likewise.
 330         (extension_language_guile): Move further down in the file so
 331         it can reference the definitions for guile_{extension_,}script_ops.
 332
 333 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 334
 335         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 336         except SORTL, DFLTCC, and KDSA.
 337
 338 2019-10-08  Tom Tromey  <tromey@adacore.com>
 339
 340         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 341         (struct safe_symbol_file_add_args): Remove.
 342
 343 2019-10-08  Tom Tromey  <tromey@adacore.com>
 344
 345         * windows-nat.c: Don't include buildsym-legacy.h.
 346
 347 2019-10-08  Tom Tromey  <tromey@adacore.com>
 348
 349         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 350
 351 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 352
 353         * gdbtypes.c (overload_debug): Move comment to header.
 354         * gdbtypes.h (overload_debug): Declare.
 355         * valops.c: Remove declaration of overload_debug, instead
 356         include gdbtypes.h.
 357
 358 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 359
 360         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 361         through _().
 362         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 363         move comment...
 364         * language.h (lang_frame_mismatch_warn): ... here. Also add
 365         declaration.
 366         * top.c (lang_frame_mismatch_warn): Remove declaration.
 367         (check_frame_language_change): Pass lang_frame_mismatch_warn
 368         through _().
 369
 370 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 371
 372         * c-lang.h (vtbl_ptr_name): Declare.
 373         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 374         it from the header.
 375         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 376
 377 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 378
 379         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 380         gdb_static_assert.
 381
 382 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 383
 384         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 385         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 386         * ctfread.c: New file.
 387         * ctfread.h: New file.
 388         * elfread.c: Include ctfread.h.
 389         (struct elfinfo text_p): New member ctfsect.
 390         (elf_locate_sections): Mark CTF section.
 391         (elf_symfile_read): Call elfctf_build_psymtabs.
 392         * Makefile.in (LIBCTF): Add.
 393         (CLIBS): Use it.
 394         (CDEPS): Likewise.
 395         (DIST): Add ctfread.c.
 396
 397 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 398
 399         * ctfread.c (struct nextfield): Renamed to ...
 400         (struct ctf_nextfield): ... this.
 401         (struct field_info): Renamed to ...
 402         (strut ctf_field_info): ... this.
 403         (attach_fields_to_type): Update for renamed structures.
 404         (ctf_add_member_cb): Likewise.
 405         (ctf_add_enum_member_cb): Likewise.
 406         (process_struct_members): Likewise.
 407         (process_enum_type): Likewise.
 408
 409 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 410
 411         * tracectf.h: Rename, was ctf.h.
 412         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 413         * tracefile.c: Likewise.
 414         * tracepoint.c: Remove unused include ctf.h.
 415         * mi/mi-main.c: Likewise.
 416         * Makefile.in Replace ctf.c with tracectf.c.
 417
 418 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 419
 420         * version.in: Change version number to "9.0.50.DATE-git".
 421
 422 2019-10-03  Tom Tromey  <tom@tromey.com>
 423
 424         PR rust/24976:
 425         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 426
 427 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 430         cp_search_name_hash.
 431         * NEWS: Add entry about nested function support.
 432
 433 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 434             Andrew Burgess  <andrew.burgess@embecosm.com>
 435
 436         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 437         for nested static variables when searchin VAR_DOMAIN.
 438         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 439         global scope, update comment.
 440         (add_partial_subprogram): Call add_partial_subprogram recursively
 441         for nested subroutines when processinng Fortran.
 442         (load_partial_dies): Process the child entities of a subprogram
 443         when processing Fortran.
 444         (partial_die_parent_scope): Handle building scope
 445         for Fortran nested functions.
 446         (process_die): Record that nested functions have a scope.
 447         (new_symbol): Always record Fortran subprograms on the global
 448         symbol list.
 449         (determine_prefix): How to build the prefix for Fortran
 450         subprograms.
 451
 452 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 455         have just sent the thread a SIGSTOP and are waiting for it to
 456         arrive.
 457
 458 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         * btrace.c (btrace_add_pc): Remove whitespace before the template
 461         parameter in 'std::vector <...>'.
 462         (parse_xml_btrace_block): Likewise.
 463         (btrace_maint_decode_pt): Likewise.
 464         (btrace_maint_update_packets): Likewise.
 465         (btrace_maint_print_packets): Likewise.
 466         * btrace.h (struct btrace_maint_info): Likewise.
 467         * dwarf2read.c (struct type_unit_group): Likewise.
 468         (build_type_psymtabs_reader): Likewise.
 469         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 470         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 471         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 472
 473 2019-10-03  Tom de Vries  <tdevries@suse.de>
 474
 475         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 476         the first line of the help text for set/show style metadata.
 477
 478 2019-10-02  Tom Tromey  <tromey@adacore.com>
 479
 480         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 481         * gdbsupport/common-inferior.c: New file.
 482         * infcmd.c (startup_with_shell): Don't define.
 483         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 484         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 485         * inferior.h (startup_with_shell): Don't declare.
 486
 487 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 488
 489         * gdbsupport/gdb_assert.h: Include errors.h.
 490         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 491
 492 2019-10-02  Tom Tromey  <tromey@adacore.com>
 493
 494         * NEWS: Add $_ada_exception entry.
 495         * ada-lang.c (struct ada_catchpoint): Add constructor.
 496         <m_kind>: New member.
 497         (allocate_location_exception, re_set_exception): Remove
 498         "ex" parameter.
 499         (should_stop_exception): Compute $_ada_exception.
 500         (check_status_exception, print_it_exception)
 501         (print_one_exception, print_mention_exception): Remove
 502         "ex" parameter.
 503         (allocate_location_catch_exception, re_set_catch_exception)
 504         (check_status_exception, print_it_catch_exception)
 505         (print_one_catch_exception, print_mention_catch_exception)
 506         (print_recreate_catch_exception)
 507         (allocate_location_catch_exception_unhandled)
 508         (re_set_catch_exception_unhandled)
 509         (check_status_exception, print_it_catch_exception_unhandled)
 510         (print_one_catch_exception_unhandled)
 511         (print_mention_catch_exception_unhandled)
 512         (print_recreate_catch_exception_unhandled)
 513         (allocate_location_catch_assert, re_set_catch_assert)
 514         (check_status_assert, print_it_catch_assert)
 515         (print_one_catch_assert, print_mention_catch_assert)
 516         (print_recreate_catch_assert)
 517         (allocate_location_catch_handlers, re_set_catch_handlers)
 518         (check_status_handlers, print_it_catch_handlers)
 519         (print_one_catch_handlers, print_mention_catch_handlers)
 520         (print_recreate_catch_handlers): Remove.
 521         (create_ada_exception_catchpoint): Update.
 522         (initialize_ada_catchpoint_ops): Update.
 523
 524 2019-10-02  Tom Tromey  <tromey@adacore.com>
 525
 526         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 527         (create_excep_cond_exprs): Simplify exception string computation.
 528         (ada_exception_catchpoint_cond_string): Likewise.
 529
 530 2019-10-02  Tom Tromey  <tromey@adacore.com>
 531
 532         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 533         * ada-lang.c (lesseq_defined_than): Handle
 534         LOC_STATIC.
 535         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 536         parameter.
 537         (dwarf2_has_info): Likewise.
 538         (new_symbol): Set maybe_copied on symbol when
 539         appropriate.
 540         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 541         parameter.
 542         <can_copy>: New member.
 543         * elfread.c (record_minimal_symbol): Set maybe_copied
 544         on symbol when appropriate.
 545         (elf_symfile_read): Update call to dwarf2_has_info.
 546         * minsyms.c (lookup_minimal_symbol_linkage): New
 547         function.
 548         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 549         * symtab.c (get_symbol_address, get_msymbol_address):
 550         New functions.
 551         * symtab.h (get_symbol_address, get_msymbol_address):
 552         Declare.
 553         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 554         maybe_copied.
 555         (struct symbol, struct minimal_symbol) <maybe_copied>:
 556         New member.
 557
 558 2019-10-02  Tom Tromey  <tromey@adacore.com>
 559
 560         * source.c (struct current_source_location): New.
 561         (current_source_key): New global.
 562         (current_source_symtab, current_source_line)
 563         (current_source_pspace): Remove.
 564         (get_source_location): New function.
 565         (get_current_source_symtab_and_line)
 566         (set_default_source_symtab_and_line)
 567         (set_current_source_symtab_and_line)
 568         (clear_current_source_symtab_and_line, select_source_symtab)
 569         (info_source_command, print_source_lines_base)
 570         (info_line_command, search_command_helper, _initialize_source):
 571         Update.
 572
 573 2019-10-02  Tom Tromey  <tromey@adacore.com>
 574
 575         * source.c (select_source_symtab): Don't call
 576         decode_line_with_current_source.
 577
 578 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 579
 580         * symtab.c (lookup_global_symbol): Search global block.
 581
 582 2019-10-02  Tom Tromey  <tromey@adacore.com>
 583
 584         * coffread.c (process_coff_symbol): Update.
 585         * dwarf2read.c (var_decode_location, new_symbol): Update.
 586         * mdebugread.c (parse_symbol): Update.
 587         * objfiles.c (relocate_one_symbol): Update.
 588         * stabsread.c (define_symbol, fix_common_block)
 589         (scan_file_globals): Update.
 590         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 591         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 592         * xcoffread.c (process_xcoff_symbol): Update.
 593
 594 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 595
 596         * MAINTAINERS: Update my email address.
 597
 598 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 601         std::vector.
 602         (build_type_psymtabs_reader): Update for std::vector.
 603         (build_type_psymtab_dependencies): Likewise.
 604         * dwarf2read.h: Remove use of DEF_VEC_P.
 605         (typedef sig_type_ptr): Delete.
 606
 607 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 610         to std::vector.
 611         (btrace_maint_decode_pt): Likewise, and move allocation of the
 612         vector outside of the loop.
 613         (btrace_maint_update_packets): Update to handle change from VEC to
 614         std::vector.
 615         (btrace_maint_print_packets): Likewise.
 616         (maint_info_btrace_cmd): Likewise.
 617         * btrace.h: Remove use of DEF_VEC_O.
 618         (typedef btrace_pt_packet_s): Delete.
 619         (struct btrace_maint_info) <packets>: Change fromm VEC to
 620         std::vector.
 621         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 622
 623 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 624
 625         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 626         make accesses into the vector constant references.
 627         (btrace_add_pc): Update for std::vector.
 628         (btrace_stitch_bts): Likewise.
 629         (parse_xml_btrace_block): Likewise.
 630         (btrace_maint_update_packets): Likewise.
 631         (btrace_maint_print_packets): Likewise.
 632         (maint_info_btrace_cmd): Likewise.
 633         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 634         std::vector.
 635         (btrace_data::empty): Likewise.
 636         (btrace_data_append): Likewise.
 637         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 638         (typedef btrace_block_s): Delete.
 639         (struct btrace_block): Add constructor.
 640         (struct btrace_data_bts) <blocks>: Change to std::vector.
 641         * nat/linux-btrace.c (perf_event_read_bts): Update for
 642         std::vector.
 643         (linux_read_bts): Likewise.
 644
 645 2019-10-01  Tom Tromey  <tom@tromey.com>
 646
 647         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 648
 649 2019-10-01  Tom Tromey  <tom@tromey.com>
 650
 651         * stack.c (print_frame, info_frame_command_core): Use
 652         styled_string.
 653         * linux-thread-db.c (try_thread_db_load_1)
 654         (try_thread_db_load_from_pdir_1): Use styled_string.
 655         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 656         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 657         (maybe_print_unsupported_script_warning)
 658         (maybe_print_script_not_found_warning): Use styled_string.
 659         * ada-lang.c (user_select_syms): Use styled_string.
 660
 661 2019-10-01  Tom Tromey  <tom@tromey.com>
 662
 663         * p-lang.c (pascal_printstr): Use metadata style.
 664         * value.c (show_convenience): Use metadata style.
 665         * valprint.c (valprint_check_validity, val_print_optimized_out)
 666         (val_print_not_saved, val_print_unavailable)
 667         (val_print_invalid_address, generic_val_print, val_print)
 668         (value_check_printable, val_print_array_elements): Use metadata
 669         style.
 670         * ui-out.h (class ui_out) <field_fmt>: New overload.
 671         <do_field_fmt>: Add style parameter.
 672         * ui-out.c (ui_out::field_fmt): New overload.
 673         * typeprint.c (type_print_unknown_return_type)
 674         (val_print_not_allocated, val_print_not_associated): Use metadata
 675         style.
 676         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 677         parameter.
 678         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 679         * tracepoint.c (tvariables_info_1): Use metadata style.
 680         * stack.c (print_frame_arg, print_frame_info, print_frame)
 681         (info_frame_command_core): Use metadata style.
 682         * skip.c (info_skip_command): Use metadata style.
 683         * rust-lang.c (rust_print_enum): Use metadata style.
 684         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 685         metadata style.
 686         * python/py-framefilter.c (py_print_single_arg): Use metadata
 687         style.
 688         * printcmd.c (do_one_display, print_variable_and_value): Use
 689         metadata style.
 690         * p-valprint.c (pascal_val_print)
 691         (pascal_object_print_value_fields): Use metadata style.
 692         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 693         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 694         parameter.
 695         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 696         * m2-valprint.c (m2_print_long_set): Use metadata style.
 697         * m2-typeprint.c (m2_print_type): Use metadata style.
 698         * infcmd.c (print_return_value_1): Use metadata style.
 699         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 700         * f-valprint.c (info_common_command_for_block): Use metadata
 701         style.
 702         * f-typeprint.c (f_type_print_base): Use metadata style.
 703         * expprint.c (print_subexp_standard): Use metadata style.
 704         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 705         * cli/cli-style.h (class cli_style_option): Add constructor.
 706         (metadata_style): Declare.
 707         * cli/cli-style.c (metadata_style): New global.
 708         (_initialize_cli_style): Register metadata style.
 709         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 710         parameter.
 711         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 712         * c-typeprint.c (c_type_print_base_struct_union)
 713         (c_type_print_base_1): Use metadata style.
 714         * breakpoint.c (watchpoint_value_print)
 715         (print_one_breakpoint_location): Use metadata style.
 716         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 717         style.
 718         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 719         style.
 720         * ada-valprint.c (val_print_packed_array_elements, printstr)
 721         (print_field_values, ada_val_print_ref, ada_val_print): Use
 722         metadata style.
 723         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 724         style.
 725         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 726         style.
 727         * ada-lang.c (user_select_syms): Use metadata style.
 728
 729 2019-10-01  Tom Tromey  <tom@tromey.com>
 730
 731         * cli/cli-cmds.c (pwd_command): Style output.
 732
 733 2019-10-01  Pedro Alves  <palves@redhat.com>
 734             Tom Tromey  <tom@tromey.com>
 735
 736         * symtab.c (print_symbol_info): Use %ps.
 737         (print_msymbol_info): Use %ps.
 738         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 739         * printcmd.c (print_variable_and_value): Use %ps.
 740         * macrocmd.c (show_pp_source_pos): Use %ps.
 741         * infrun.c (print_exited_reason): Use ui_out::message.
 742         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 743         (describe_other_breakpoints): Use ui_out::message and new
 744         formats.
 745         (say_where): Use new formats.
 746         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 747         and new formats.
 748
 749 2019-10-01  Pedro Alves  <palves@redhat.com>
 750             Tom Tromey  <tom@tromey.com>
 751
 752         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 753         (test_gdb_formats): New function.
 754         (run_tests): Call it.
 755         (test_format_specifier): Update.
 756         * utils.h (fputs_filtered): Update comment.
 757         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 758         (fputs_styled_unfiltered): Declare.
 759         * utils.c (fputs_styled_unfiltered): New function.
 760         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 761         (vfprintf_filtered): Update.
 762         (vfprintf_unfiltered, vprintf_filtered): Update.
 763         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 764         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 765         disallow_ui_out_field>: New constants.
 766         (enum class field_kind): New.
 767         (struct base_field_s, struct signed_field_s): New.
 768         (signed_field): New function.
 769         (struct string_field_s): New.
 770         (string_field): New function.
 771         (struct styled_string_s): New.
 772         (styled_string): New function.
 773         (class ui_out) <message>: Add comment.
 774         <vmessage, call_do_message>: New methods.
 775         <do_message>: Add style parameter.
 776         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 777         methods.
 778         (ui_out::message): Rewrite.
 779         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 780         parameter.
 781         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 782         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 783         gdb_extensions parameter.
 784         (class format_piece): Add parameter to constructor.
 785         (n_int_args): New field.
 786         * gdbsupport/format.c (format_pieces::format_pieces): Add
 787         gdb_extensions parameter.  Handle '*'.
 788         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 789         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 790         vfprintf_styled_no_gdbfmt.
 791         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 792         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 793         unfiltered output.
 794         * ui-style.h (struct ui_file_style) <ptr>: New method.
 795
 796 2019-10-01  Tom Tromey  <tom@tromey.com>
 797
 798         * unittests/format_pieces-selftests.c: Update.  Add final format.
 799         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 800         empty literal pieces.
 801
 802 2019-10-01  Tom Tromey  <tom@tromey.com>
 803
 804         * ui-out.h (enum class ui_out_style_kind): Remove.
 805         (class ui_out) <field_string, field_stsream, do_field_string>:
 806         Change type of "style".
 807         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 808         (ui_out::field_string): Update.
 809         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 810         of "style".
 811         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 812         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 813         * stack.c (print_frame_arg, print_frame_info, print_frame):
 814         Update.
 815         * source.c (print_source_lines_base): Update.
 816         * solib.c (info_sharedlibrary_command): Update.
 817         * skip.c (info_skip_command): Update.
 818         * record-btrace.c (btrace_call_history_src_line)
 819         (btrace_call_history): Update.
 820         * python/py-framefilter.c (py_print_frame): Update.
 821         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 822         "style".
 823         * mi/mi-out.c (mi_ui_out::do_table_header)
 824         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 825         (mi_ui_out::do_field_string): Update.
 826         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 827         Update.
 828         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 829         "style".
 830         * cli-out.c (cli_ui_out::do_table_header)
 831         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 832         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 833         (cli_ui_out::do_field_fmt): Update.
 834         * breakpoint.c (print_breakpoint_location): Update.
 835         (update_static_tracepoint): Update.
 836
 837 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 838
 839         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 840         conversion of gdb_datadir.
 841         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 842         remove not needed c_str ().
 843
 844 2019-09-30  Ali Tamur <tamur@google.com>
 845
 846         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 847         (dwarf2_string_attr): Likewise.
 848
 849 2019-09-30  Ali Tamur <tamur@google.com>
 850
 851         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 852         (process_full_type_unit): Likewise.
 853         (dump_die_shallow): Likewise.
 854         (cu_debug_loc_section): Likewise.
 855
 856 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 857
 858         * minsyms.c (compare_minimal_symbols): Rename to...
 859         (minimal_symbol_is_less_than): ...this, and adjust to STL
 860         conventions (return bool, take arguments as references)
 861         (minimal_symbol_reader::install): Call std::sort instead
 862         of qsort.
 863
 864 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 865
 866         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 867         hash and why.
 868         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 869         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 870
 871 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 872
 873         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 874         * psympriv.h (add_psymbol_to_list): Move comment here and update
 875         it.
 876
 877 2019-09-29  Tom de Vries  <tdevries@suse.de>
 878
 879         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 880         Use $tmpdir/$(basename "$output_file").dwz instead of
 881         "${output_file}.dwz".
 882
 883 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 884
 885         PR gdb/25045
 886         * hppa-linux-nat.c: Include gdbarch.h.
 887
 888 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 889
 890         * blockframe.c (find_pc_partial_function): Change return type to bool.
 891         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 892         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 893         (stub_gnu_ifunc_resolve_name): Likewise.
 894         * symtab.c (compare_filenames_for_search): Likewise.
 895         (compare_glob_filenames_for_search): Likewise.
 896         (matching_obj_sections): Likewise.
 897         (symbol_matches_domain): Likewise.
 898         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 899         (find_line_pc): Change return type to bool.
 900         (find_line_pc_range): Likewise.
 901         (producer_is_realview): Likewise.
 902         * symtab.h (symbol_matches_domain): Likewise.
 903         (find_pc_partial_function): Likewise.
 904         (find_pc_line_pc_range): Likewise.
 905         (in_gnu_ifunc_stub): Likewise.
 906         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 907         (find_line_pc): Likewise.
 908         (find_line_pc_range): Likewise.
 909         (matching_obj_sections): Likewise.
 910         (find_line_symtab): Change out parameter to bool.
 911         (producer_is_realview): Change return type to bool.
 912         (compare_filenames_for_search): Likewise.
 913         (compare_glob_filenames_for_search): Likewise.
 914
 915 2019-09-26  Tom Tromey  <tom@tromey.com>
 916
 917         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 918         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 919         * gdb_usleep.h: Remove.
 920         * gdb_usleep.c: Remove.
 921         * utils.c: Don't include gdb_usleep.h.
 922
 923 2019-09-26  Tom Tromey  <tromey@adacore.com>
 924
 925         * python/py-type.c (type_to_type_object): Call check_typedef
 926         for stub types.
 927
 928 2019-09-26  Tom Tromey  <tom@tromey.com>
 929
 930         * utils.h (initialize_utils): Don't declare.
 931         * top.c (gdb_init): Don't call initialize_utils.
 932         * utils.c (initialize_utils): Remove.  Move contents...
 933         (_initialize_utils): ... here.
 934
 935 2019-09-25  Tom Tromey  <tom@tromey.com>
 936
 937         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 938         * utils.h (make_hex_string): Don't declare.
 939         * utils.c (make_hex_string): Remove.
 940
 941 2019-09-24  Tom de Vries  <tdevries@suse.de>
 942
 943         PR gdb/23815
 944         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 945         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 946
 947 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 948
 949         * NEWS: Mention new simulator port for PRU.
 950
 951 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 952
 953         * ada-exp.y (write_object_remaining): Update.
 954         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 955         and eliminate the static buffer.
 956         (ada_decode_symbol): Update.
 957         (ada_la_decode): Update.
 958         (ada_sniff_from_mangled_name): Update.
 959         (is_valid_name_for_wild_match): Update.
 960         (ada_lookup_name_info::matches): Update and simplify.
 961         (name_matches_regex): Update.
 962         (ada_add_global_exceptions): Update.
 963         * ada-lang.h (ada_decode): Update signature.
 964         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 965         * dwarf-index-write.c (debug_names::insert): Update.
 966
 967 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 968
 969         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 970         formatting.
 971
 972 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 973
 974         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 975         Change "nonzero" to "true" in documentation.
 976
 977 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 978
 979         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 980         (_initialize_darwin_solib): Don't set
 981         darwin_so_ops.lookup_lib_global_symbol.
 982         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 983         set_gdbarch_iterate_over_objfiles_in_search_order.
 984         (elf_lookup_lib_symbol): Rename to...
 985         (svr4_iterate_over_objfiles_in_search_order): this, and update
 986         to iterate semantics.
 987         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 988         * solib.c (solib_global_lookup): Remove.
 989         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 990         (solib_global_lookup): Remove.
 991         * symtab.c (lookup_global_or_static_symbol): Remove call to
 992         solib_global_lookup.
 993
 994 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 995
 996         * NEWS: Move entries about default MI version now being
 997         version 3, and about the GDB/MI fix for multi-location
 998         breakpoints to the "since GDB 8.3" section.
 999
1000 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1001
1002         GDB 8.3.1 released.
1003
1004 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1005
1006         * NEWS: Mention that Cell/B.E. debugging support was removed.
1007         * MAINTAINERS: Remove spu target.
1008
1009         * config/djgpp/fnchange.lst: Remove entries for removed files.
1010
1011         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1012         spu-multiarch.o, and spu-tdep.o.
1013         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1014         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1015         spu-multiarch.c, and spu-tdep.c.
1016         * spu-linux-nat.c: Remove file.
1017         * spu-multiarch.c: Remove file.
1018         * spu-tdep.c: Remove file.
1019         * spu-tdep.h: Remove file.
1020         * solib-spu.c: Remove file.
1021         * solib-spu.h: Remove file.
1022
1023         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1024         * configure.nat (spu-linux): Remove.
1025         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1026         solib-multiarch.o from gdb_target_obs.
1027         (spu*-*-*): Remove.
1028
1029         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1030         feature flag.
1031         (ppc_linux_no_features): Update.
1032         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1033         Cell/B.E. support.
1034         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1035         (tdesc_powerpc_cell64l): Likewise.
1036         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1037         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1038         Cell/B.E. support.
1039         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1040         Do not include "features/rs6000/powerpc-cell32l.c" or
1041         "features/rs6000/powerpc-cell64l.c".
1042         (ppc_linux_spu_section): Remove.
1043         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1044         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1045         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1046         (ppc_linux_spe_context_lookup): Remove.
1047         (ppc_linux_spe_context_inferior_created): Remove.
1048         (ppc_linux_spe_context_solib_loaded): Remove.
1049         (ppc_linux_spe_context_solib_unloaded): Remove.
1050         (ppc_linux_spe_context): Remove.
1051         (struct ppu2spu_cache): Remove.
1052         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1053         (struct ppu2spu_data): Remove.
1054         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1055         ppu2spu_unwind): Remove.
1056         (ppc_linux_init_abi): Remove Cell/B.E. support.
1057         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1058
1059         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1060         (rs6000/powerpc-cell64l-expedite): Likewise
1061         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1062         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1063         rs6000/powerpc-cell64l.xml.
1064         * features/rs6000/powerpc-cell32l.xml: Remove.
1065         * features/rs6000/powerpc-cell64l.xml: Likewise.
1066         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1067         * features/rs6000/powerpc-cell64l.c: Likewise.
1068         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1069         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1070         * regformats/reg-spu.dat: Remove.
1071
1072         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1073         * corelow.c (struct spuid_list): Remove.
1074         (add_to_spuid_list): Remove.
1075         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1076         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1077         (remote_protocol_features): Remove associated entries.
1078         (_initialize_remote): No longer initialize them.
1079         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1080         * linux-nat.c (SPUFS_MAGIC): Remove.
1081         (linux_proc_xfer_spu): Remove.
1082         (spu_enumerate_spu_ids): Remove.
1083         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1084         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1085         (linux_make_corefile_notes): No longer call it.
1086
1087         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1088         (cooked_write_test): Likewise.
1089
1090 2019-09-20  Tom Tromey  <tom@tromey.com>
1091
1092         * NEWS: Mention case-sensitivity of TUI commands.
1093         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1094         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1095         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1096
1097 2019-09-20  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-source.c (tui_source_window::set_contents): Use
1100         make_unique_xstrdup.
1101         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1102         make_unique_xstrdup.
1103
1104 2019-09-20  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-data.c: Remove separator comments.
1107         * tui/tui-layout.c: Remove separator comments.
1108         * tui/tui-win.c: Remove separator comments.
1109         * tui/tui-wingeneral.c: Remove separator comments.
1110
1111 2019-09-20  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui.h (strcat_to_buf): Don't declare.
1114         * tui/tui.c (strcat_to_buf): Remove.
1115
1116 2019-09-20  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1119         from "fullname".
1120         * tui/tui-source.c (tui_source_window::set_contents)
1121         (tui_source_window::location_matches_p)
1122         (tui_source_window::maybe_update): Update.
1123
1124 2019-09-20  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1127         Update.
1128         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1129         prefix.
1130         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1131         (tui_data_window::line_from_reg_element_no)
1132         (tui_data_window::first_reg_element_no_inline)
1133         (tui_data_window::show_registers)
1134         (tui_data_window::show_register_group)
1135         (tui_data_window::display_registers_from)
1136         (tui_data_window::display_registers_from_line)
1137         (tui_data_window::first_data_item_displayed)
1138         (tui_data_window::delete_data_content_windows)
1139         (tui_data_window::erase_data_content)
1140         (tui_data_window::do_scroll_vertical)
1141         (tui_data_window::refresh_window)
1142         (tui_data_window::check_register_values): Update.
1143
1144 2019-09-20  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1147         (struct tui_locator_window) <full_name, proc_name>: Now
1148         std::string.
1149         * tui/tui-stack.c (tui_locator_window::make_status_line)
1150         (tui_locator_window::set_locator_fullname)
1151         (tui_locator_window::set_locator_info): Update.
1152         * tui/tui-source.c (tui_source_window::set_contents)
1153         (tui_source_window::showing_source_p): Update.
1154
1155 2019-09-20  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1158         Don't call tui_locator_win_info_ptr.
1159
1160 2019-09-20  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1163
1164 2019-09-20  Tom Tromey  <tom@tromey.com>
1165
1166         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1167         height for locator.
1168         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1169         * tui/tui-layout.c (show_source_disasm_command, show_data)
1170         (show_source_or_disasm_and_command): Use 1 as height for locator.
1171
1172 2019-09-20  Tom Tromey  <tom@tromey.com>
1173
1174         * tui/tui.c (tui_enable): Update.
1175         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1176         Update.
1177         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1178         Update.
1179         * tui/tui-data.c (win_resized): Now bool.
1180         (tui_win_resized): Return bool.
1181         (tui_set_win_resized_to): Accept a bool.
1182
1183 2019-09-20  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1186         Change type of "refresh_values_only".
1187         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1188         type of "refresh_values_only".
1189
1190 2019-09-20  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1193         std::string.
1194         (tui_disassemble): Add "pos" parameter.
1195         (tui_disasm_window::set_contents): Simplify.
1196
1197 2019-09-20  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-winsource.h (struct tui_source_window_base)
1200         <show_source_content>: Now private.
1201         * tui/tui-winsource.c
1202         (tui_source_window_base::show_source_content): Don't handle empty
1203         content case.
1204
1205 2019-09-20  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-layout.c (show_source_disasm_command)
1208         (show_source_or_disasm_and_command): Don't call
1209         show_source_content.
1210
1211 2019-09-20  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1214         Declare.
1215         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1216         from tui_make_status_line.
1217         (tui_locator_window::rerender): Update.
1218
1219 2019-09-20  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1222         (tui_locator_window::rerender): Update.
1223
1224 2019-09-20  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-winsource.h (struct tui_source_window_base)
1227         <~tui_source_window_base>: Don't declare.
1228         <fullname>: Remove.
1229         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1230         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1231         member.
1232         * tui/tui-source.c (tui_source_window::set_contents): Update.
1233         (tui_source_window::location_matches_p)
1234         (tui_source_window::maybe_update): Update.
1235
1236 2019-09-20  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-winsource.h (~tui_source_element): Remove.
1239         (tui_source_element): Update.
1240         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1241         * tui/tui-winsource.c (tui_show_source_line): Update.
1242         * tui/tui-source.c (tui_source_window::set_contents): Update.
1243         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1244
1245 2019-09-20  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1248         declare.
1249         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1250         tui_clear_source_windows_detail.
1251         * tui/tui-winsource.h (struct tui_source_window_base)
1252         <clear_detail>: Don't declare.
1253         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1254         Remove.
1255         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1256
1257 2019-09-20  Tom Tromey  <tromey@adacore.com>
1258
1259         PR ada/24919:
1260         * block.c (contained_in): Fix final return value.
1261
1262 2019-09-20  Alan Modra  <amodra@gmail.com>
1263
1264         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1265         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1266         (read_indirect_string_from_dwz): Use bfd accessor.
1267         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1268         * machoread.c (macho_symfile_read_all_oso): Likewise.
1269         * solib.c (solib_bfd_open): Likewise.
1270
1271 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1272
1273         * eval.c: Move declaration of overload_resolution to...
1274         * value.h: ...here.
1275
1276 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1277
1278         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1279         * arm-linux-tdep.c: Likewise.
1280         * arm-nbsd-nat.c: Likewise.
1281         * arm-tdep.h: Declare arm_apcs_32.
1282         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1283
1284 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1285
1286         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1287         * dwarf2read.h: Declare dwarf_always_disassemble.
1288
1289 2019-09-19  Tom de Vries  <tdevries@suse.de>
1290
1291         PR gdb/25009
1292         * source-cache.c (source_cache::ensure): Catch exception thrown during
1293         construction of the highlighter.
1294
1295 2019-09-18  Alan Modra  <amodra@gmail.com>
1296
1297         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1298         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1299         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1300         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1301         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1302         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1303         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1304         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1305         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1306         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1307         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1308         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1309         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1310         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1311         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1312         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1313         * mi/mi-interp.c: Update throughout for bfd section macro and
1314         function changes.
1315         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1316         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1317
1318 2019-09-18  Tom Tromey  <tom@tromey.com>
1319
1320         * NEWS: Add entry.
1321         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1322         call rl_initialize.
1323         (tui_enable): Do not call rl_initialize.
1324
1325 2019-09-18  Christian Groessler  <chris@groessler.org>
1326
1327         * alpha-linux-nat.c: Include gdbarch.h.
1328
1329 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1330
1331         * ui-file.c: Include cli/cli-style.h.
1332         (term_cli_styling): Remove cli_styling declaration.
1333
1334 2019-09-18  Alan Modra  <amodra@gmail.com>
1335
1336         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1337         to bfd_asymbol_section.
1338
1339 2019-09-18  Alan Modra  <amodra@gmail.com>
1340
1341         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1342         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1343         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1344
1345 2019-09-18  Alan Modra  <amodra@gmail.com>
1346
1347         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1348         * spu-linux-nat.c (spu_bfd_open): Likewise.
1349
1350 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1351
1352         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1353         to bool to match definition in dwarf2read.c.
1354
1355 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1356
1357         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1358         (print_signatures): Likewise.
1359         (trust_pad_over_xvs): Likewise.
1360         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1361         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1362         * arm-linux-nat.c (arm_apcs_32): Likewise.
1363         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1364         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1365         * arm-tdep.c (arm_debug): Likewise.
1366         (arm_apcs_32): Likewise.
1367         * auto-load.c (debug_auto_load): Likewise.
1368         (auto_load_gdb_scripts): Likewise.
1369         (global_auto_load): Likewise.
1370         (auto_load_local_gdbinit): Likewise.
1371         (auto_load_local_gdbinit_loaded): Likewise.
1372         * auto-load.h (global_auto_load): Likewise.
1373         (auto_load_local_gdbinit): Likewise.
1374         (auto_load_local_gdbinit_loaded): Likewise.
1375         * breakpoint.c (disconnected_dprintf): Likewise.
1376         (breakpoint_proceeded): Likewise.
1377         (automatic_hardware_breakpoints): Likewise.
1378         (always_inserted_mode): Likewise.
1379         (target_exact_watchpoints): Likewise.
1380         (_initialize_breakpoint): Update.
1381         * breakpoint.h (target_exact_watchpoints): Change to bool.
1382         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1383         * cli/cli-cmds.c (trace_commands): Likewise.
1384         * cli/cli-cmds.h (trace_commands): Likewise.
1385         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1386         to bool*.
1387         * cli/cli-logging.c (logging_overwrite): Change to bool.
1388         (logging_redirect): Likewise.
1389         (debug_redirect): Likewise.
1390         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1391         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1392         to bool.
1393         <boolean_option_def>: Update.
1394         (struct flag_option_def): Change default type of Context to bool
1395         from int.
1396         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1397         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1398         (get_setshow_command_value_string): Likewise.
1399         * cli/cli-style.c (cli_styling): Change to bool.
1400         (source_styling): Likewise.
1401         * cli/cli-style.h (source_styling): Likewise.
1402         (cli_styling): Likewise.
1403         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1404         to bool.
1405         * command.h (var_types): Update comment.
1406         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1407         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1408         bool.
1409         (debug_compile_cplus_scopes): Likewise.
1410         * compile/compile-internal.h (compile_debug): Likewise.
1411         * compile/compile.c (compile_debug): Likewise.
1412         (struct compile_options) <raw>: Likewise.
1413         * cp-support.c (catch_demangler_crashes): Likewise.
1414         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1415         (usr_cmd_cris_dwarf2_cfi): Likewise.
1416         * csky-tdep.c (csky_debug): Likewise.
1417         * darwin-nat.c (enable_mach_exceptions): Likewise.
1418         * dcache.c (dcache_enabled_p): Likewise.
1419         * defs.h (info_verbose): Likewise.
1420         * demangle.c (demangle): Likewise.
1421         (asm_demangle): Likewise.
1422         * dwarf-index-cache.c (debug_index_cache): Likewise.
1423         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1424         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1425         * dwarf2read.c (check_physname): Likewise.
1426         (use_deprecated_index_sections): Likewise.
1427         (dwarf_always_disassemble): Likewise.
1428         * eval.c (overload_resolution): Likewise.
1429         * event-top.c (set_editing_cmd_var): Likewise.
1430         (exec_done_display_p): Likewise.
1431         * event-top.h (set_editing_cmd_var): Likewise.
1432         (exec_done_display_p): Likewise.
1433         * exec.c (write_files): Likewise.
1434         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1435         (debug_fbsd_nat): Likewise.
1436         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1437         Likewise.
1438         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1439         <backtrace_past_entry> Likewise.
1440         * gdb-demangle.h (demangle): Likewise.
1441         (asm_demangle): Likewise.
1442         * gdb_bfd.c (bfd_sharing): Likewise.
1443         * gdbcore.h (write_files): Likewise.
1444         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1445         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1446         * gdbthread.h (print_thread_events): Likewise.
1447         * gdbtypes.c (opaque_type_resolution): Likewise.
1448         (strict_type_checking): Likewise.
1449         * gnu-nat.c (gnu_debug_flag): Likewise.
1450         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1451         * guile/scm-param.c (pascm_variable): Add boolval.
1452         (add_setshow_generic): Update.
1453         (pascm_param_value): Update.
1454         (pascm_set_param_value_x): Update.
1455         * hppa-tdep.c (hppa_debug): Change to bool..
1456         * infcall.c (may_call_functions_p): Likewise.
1457         (coerce_float_to_double_p): Likewise.
1458         (unwind_on_signal_p): Likewise.
1459         (unwind_on_terminating_exception_p): Likewise.
1460         * infcmd.c (startup_with_shell): Likewise.
1461         * inferior.c (print_inferior_events): Likewise.
1462         * inferior.h (startup_with_shell): Likewise.
1463         (print_inferior_events): Likewise.
1464         * infrun.c (step_stop_if_no_debug): Likewise.
1465         (detach_fork): Likewise.
1466         (debug_displaced): Likewise.
1467         (disable_randomization): Likewise.
1468         (non_stop): Likewise.
1469         (non_stop_1): Likewise.
1470         (observer_mode): Likewise.
1471         (observer_mode_1): Likewise.
1472         (set_observer_mode): Update.
1473         (sched_multi): Change to bool.
1474         * infrun.h (debug_displaced): Likewise.
1475         (sched_multi): Likewise.
1476         (step_stop_if_no_debug): Likewise.
1477         (non_stop): Likewise.
1478         (disable_randomization): Likewise.
1479         * linux-tdep.c (use_coredump_filter): Likewise.
1480         (dump_excluded_mappings): Likewise.
1481         * linux-thread-db.c (auto_load_thread_db): Likewise.
1482         (check_thread_db_on_load): Likewise.
1483         * main.c (captured_main_1): Update.
1484         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1485         xx2_opt, boolean_opt>: Change to bool.
1486         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1487         * maint.c (maintenance_profile_p): Likewise.
1488         (per_command_time): Likewise.
1489         (per_command_space): Likewise.
1490         (per_command_symtab): Likewise.
1491         * memattr.c (inaccessible_by_default): Likewise.
1492         * mi/mi-main.c (mi_async): Likewise.
1493         (mi_async_1): Likewise.
1494         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1495         * nat/fork-inferior.h (startup_with_shell): Likewise.
1496         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1497         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1498         * nios2-tdep.c (nios2_debug): Likewise.
1499         * or1k-tdep.c (or1k_debug): Likewise.
1500         * parse.c (parser_debug): Likewise.
1501         * parser-defs.h (parser_debug): Likewise.
1502         * printcmd.c (print_symbol_filename): Likewise.
1503         * proc-api.c (procfs_trace): Likewise.
1504         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1505         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1506         (set_parameter_value): Update.
1507         (add_setshow_generic): Update.
1508         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1509         to bool*.
1510         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1511         int*.
1512         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1513         * record-btrace.c (record_btrace_target::store_registers): Update.
1514         * record-full.c (record_full_memory_query): Change to bool.
1515         (record_full_stop_at_limit): Likewise.
1516         * record-full.h (record_full_memory_query): Likewise.
1517         * remote-notif.c (notif_debug): Likewise.
1518         * remote-notif.h (notif_debug): Likewise.
1519         * remote.c (use_range_stepping): Likewise.
1520         (interrupt_on_connect): Likewise.
1521         (remote_break): Likewise.
1522         * ser-tcp.c (tcp_auto_retry): Likewise.
1523         * ser-unix.c (serial_hwflow): Likewise.
1524         * skip.c (debug_skip): Likewise.
1525         * solib-aix.c (solib_aix_debug): Likewise.
1526         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1527         (spu_auto_flush_cache_p): Likewise.
1528         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1529         Likewise.
1530         (struct info_print_options) <quiet>: Likewise.
1531         * symfile-debug.c (debug_symfile): Likewise.
1532         * symfile.c (auto_solib_add): Likewise.
1533         (separate_debug_file_debug): Likewise.
1534         * symfile.h (auto_solib_add): Likewise.
1535         (separate_debug_file_debug): Likewise.
1536         * symtab.c (basenames_may_differ): Likewise.
1537         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1538         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1539         (struct info_types_options) <quiet>: Likewise.
1540         * symtab.h (demangle): Likewise.
1541         (basenames_may_differ): Likewise.
1542         * target-dcache.c (stack_cache_enabled_1): Likewise.
1543         (code_cache_enabled_1): Likewise.
1544         * target.c (trust_readonly): Likewise.
1545         (may_write_registers): Likewise.
1546         (may_write_memory): Likewise.
1547         (may_insert_breakpoints): Likewise.
1548         (may_insert_tracepoints): Likewise.
1549         (may_insert_fast_tracepoints): Likewise.
1550         (may_stop): Likewise.
1551         (auto_connect_native_target): Likewise.
1552         (target_stop_and_wait): Update.
1553         (target_async_permitted): Change to bool.
1554         (target_async_permitted_1): Likewise.
1555         (may_write_registers_1): Likewise.
1556         (may_write_memory_1): Likewise.
1557         (may_insert_breakpoints_1): Likewise.
1558         (may_insert_tracepoints_1): Likewise.
1559         (may_insert_fast_tracepoints_1): Likewise.
1560         (may_stop_1): Likewise.
1561         * target.h (target_async_permitted): Likewise.
1562         (may_write_registers): Likewise.
1563         (may_write_memory): Likewise.
1564         (may_insert_breakpoints): Likewise.
1565         (may_insert_tracepoints): Likewise.
1566         (may_insert_fast_tracepoints): Likewise.
1567         (may_stop): Likewise.
1568         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1569         (make_thread_apply_all_options_def_group): Change argument from int*
1570         to bool*.
1571         (thread_apply_all_command): Update.
1572         (print_thread_events): Change to bool.
1573         * top.c (confirm): Likewise.
1574         (command_editing_p): Likewise.
1575         (history_expansion_p): Likewise.
1576         (write_history_p): Likewise.
1577         (info_verbose): Likewise.
1578         * top.h (confirm): Likewise.
1579         (history_expansion_p): Likewise.
1580         * tracepoint.c (disconnected_tracing): Likewise.
1581         (circular_trace_buffer): Likewise.
1582         * typeprint.c (print_methods): Likewise.
1583         (print_typedefs): Likewise.
1584         * utils.c (debug_timestamp): Likewise.
1585         (sevenbit_strings): Likewise.
1586         (pagination_enabled): Likewise.
1587         * utils.h (sevenbit_strings): Likewise.
1588         (pagination_enabled): Likewise.
1589         * valops.c (overload_resolution): Likewise.
1590         * valprint.h (struct value_print_options) <prettyformat_arrays,
1591         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1592         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1593         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1594         Likewise.
1595         * windows-nat.c (new_console): Likewise.
1596         (cygwin_exceptions): Likewise.
1597         (new_group): Likewise.
1598         (debug_exec): Likewise.
1599         (debug_events): Likewise.
1600         (debug_memory): Likewise.
1601         (debug_exceptions): Likewise.
1602         (useshell): Likewise.
1603         * windows-tdep.c (maint_display_all_tib): Likewise.
1604         * xml-support.c (debug_xml): Likewise.
1605
1606 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1607
1608         * source.c (prepare_path_for_appending): New function.
1609         (openp): Make use of new function.
1610         (find_and_open_source): Search for the compilation directory and
1611         source file as a relative path beneath the directory search path.
1612
1613 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1614
1615         * source-cache.c (source_cache::get_line_charpos): Catch
1616         exceptions and return false, this matches the behaviour documented
1617         in the header file.
1618
1619 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1620
1621         * ada-tasks.c (info_task): Remove quoting of the task's name.
1622
1623 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1624
1625         * symfile.c (auto_solib_add): Replace comment with a reference
1626         to the header file.
1627
1628 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1629
1630         * NEWS: Mention that gdb can now be compiled with Python 3
1631         on Windows.
1632
1633 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * maint.c (maint_print_section_data::maint_print_section_data):
1636         Force use of 'float log10 (float)' by casting the argument to
1637         float.
1638
1639 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * maint.c: Add 'cmath' include.
1642         (struct maint_print_section_data): New structure.
1643         (print_section_index): New function.
1644         (print_bfd_section_info): Add header comment, small whitespace
1645         cleanup, and update to call new print_section_index function.
1646         (print_objfile_section_info): Likewise.
1647         (maint_obj_section_from_bfd_section): New function.
1648         (print_bfd_section_info_maybe_relocated): New function.
1649         (maintenance_info_sections): Add header comment, always use
1650         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1651
1652 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1655         inner scope, add check that the objfile has psymtabs before
1656         checking psymtabs_addrmap.
1657         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1658
1659 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1660
1661         * NEWS: Announce that Ada task names are now shown at more places,
1662         and between quotes (except in info task output).
1663         * gdb/ada-tasks.c (task_to_str): New function.
1664         (display_current_task_id): Call task_to_str.
1665         (task_command_1): Likewise.
1666         (print_ada_task_info): In non-mi mode, Properly align headers and data
1667         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1668
1669 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1670
1671         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1672         prstatus.pr_lwp.pr_info instead of making it up.
1673
1674 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1675
1676         * auto-load.c (auto_load_expand_dir_vars): Update.
1677         * defs.h (gdb_datadir): Change to std::string.
1678         (python_libdir): Likewise.
1679         (relocate_gdb_directory): Change return type to std::string.
1680         * guile/guile.c (gdbscm_data_directory): Update.
1681         (initialize_scheme_side): Update.
1682         * jit.c (jit_reader_dir): Change to std::string.
1683         (jit_reader_load_command): Update.
1684         * main.c (gdb_datadir): Change to std::string.
1685         (python_libdir): Likewise.
1686         (set_gdb_data_directory): Update.
1687         (relocate_path): Change to return std::string.
1688         (relocate_gdb_directory): Change to return std::string.
1689         (relocate_gdbinit_path_maybe_in_datadir): Update.
1690         (captured_main_1): Update.
1691         * python/python.c (do_start_initialization): Update.
1692         * top.c (show_gdb_datadir): Update.
1693         * xml-syscall.c (xml_init_syscalls_info): Update.
1694         (init_syscalls_info): Update.
1695
1696 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1697
1698         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1699         out of get_init_files.
1700         (get_init_files): Update.
1701
1702 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1703
1704         * main.c (get_init_files): Change to use std::string.
1705         (captured_main_1): Update.
1706         (print_gdb_help): Update.
1707
1708 2019-09-11  Ali Tamur  <tamur@google.com>
1709
1710         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1711         implementation.
1712
1713 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1714
1715         * dbxread.c (read_dbx_symtab): Update.
1716         * dwarf2read.c (load_partial_dies): Update.
1717         * mdebugread.c (parse_partial_symbols): Update.
1718         (handle_psymbol_enumerators): Update.
1719         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1720         * psymtab.c (add_psymbol_to_bcache): Likewise.
1721         (add_psymbol_to_list): Likewise.
1722         * symtab.c (symbol_set_names): Likewise.
1723         * symtab.h (symbol_set_names): Likewise.
1724         * xcoffread.c (scan_xcoff_symtab): Update.
1725
1726 2019-09-11  Tom Tromey  <tom@tromey.com>
1727
1728         * symfile-mem.c (symbol_file_add_from_memory): Use
1729         bfd_set_filename.
1730         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1731         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1732
1733 2019-09-10  Tom Tromey  <tromey@adacore.com>
1734
1735         * dwarf-index-write.c (write_psymbols): Extend error message.
1736         (debug_names::insert): Add Ada code.
1737         (debug_names::write_psymbols): Remove Ada check.
1738         (debug_names) <m_string_obstack>: New member.
1739         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1740         (gdb_index_symbol_name_matcher::matches): Remove.
1741         (mapped_index_base::find_name_components_bounds): Add "lang"
1742         parameter.
1743         (mapped_index_base::build_name_components): Also split names
1744         according to Ada syntax.
1745         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1746         type of "match_callback".
1747         (check_match, check_find_bounds_finds)
1748         (dw2_expand_symtabs_matching): Update.
1749         (dw2_debug_names_iterator): Add new constructor.
1750         (dw2_debug_names_map_matching_symbols): New function.
1751         (dw2_debug_names_expand_symtabs_matching): Update.
1752         (dwarf2_debug_names_functions): Use
1753         dw2_debug_names_map_matching_symbols.
1754
1755 2019-09-10  Tom Tromey  <tromey@adacore.com>
1756
1757         * dwarf2read.c (dw2_get_file_names_reader): Add the
1758         CU's file name to the results.
1759
1760 2019-09-10  Tom Tromey  <tromey@adacore.com>
1761
1762         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1763         map_matching_symbols.  Update.
1764         * dwarf2read.c (dw2_map_matching_symbols): Update.
1765         * psymtab.c (match_partial_symbol): Change type; update.
1766         (psym_map_matching_symbols): Likewise.
1767         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1768         type; update.
1769         * symfile.h (struct quick_symbol_functions)
1770         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1771         Remove "match".
1772
1773 2019-09-10  Tom Tromey  <tromey@adacore.com>
1774
1775         * psymtab.c (map_block): Remove.
1776         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1777         * symtab.c (iterate_over_symbols_terminated): New function.
1778         * symtab.c (iterate_over_symbols_terminated): Declare.
1779
1780 2019-09-10  Tom Tromey  <tromey@adacore.com>
1781
1782         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1783         * language.h (struct language_defn) <la_iterate_over_symbols>:
1784         Return bool.
1785         * symtab.c (iterate_over_symbols): Return bool.
1786         * symtab.h (iterate_over_symbols): Return bool.
1787
1788 2019-09-10  Tom Tromey  <tromey@adacore.com>
1789
1790         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1791         (add_nonlocal_symbols): Update.
1792         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1793         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1794         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1795         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1796         Change type of "callback".  Remove "data".
1797
1798
1799 2019-09-09  Ali Tamur  <tamur@google.com>
1800
1801         * dwarf2read.c (comp_unit_head): Update comment.
1802         (dwarf2_dwo_name): New function declaration.
1803         (dwarf_unit_type_name): New function declaration.
1804         (read_comp_unit_head): Add support for new compilation units,
1805         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1806         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1807         (currently named as "signature") in their header. Also clarify error
1808         messages.
1809         (lookup_dwo_id): New function. Returns the dwo id of the given
1810         compile unit.
1811         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1812         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1813         functions.
1814         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1815         (dwarf2_dwo_name): Get the dwo name if present.
1816         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1817         purposes.
1818
1819 2019-09-09  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1822
1823 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1824
1825         * python/python.c (do_start_initialization): Make progname_copy static,
1826         to avoid a leak report.
1827
1828 2019-09-08  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1831
1832 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1833
1834         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1835         Change type to gdb::optional<block_enum>.
1836         (dw2_symtab_iter_init): Change block_index parameter type
1837         to gdb::optional<block_enum>.
1838         (dw2_lookup_symbol): Change block_index parameter
1839         type to block_enum.c
1840         (dw2_debug_names_lookup_symbol): Likewise.
1841         * psymtab.c (psym_lookup_symbol): Likewise.
1842         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1843         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1844         Likewise.
1845
1846 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1847
1848         * defs.h (relocate_gdb_directory): Change int to bool in
1849         signature and rename flag to relocatable.
1850         * main.c (relocate_path): Likewise.
1851         (relocate_gdb_directory): Likewise.
1852
1853 2019-09-06  Alan Modra  <amodra@gmail.com>
1854
1855         * coffread.c (coff_symfile_read): Constify filename variable.
1856         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1857         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1858         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1859         * solib.c (reload_shared_libraries_1): Likewise.
1860         * symfile.c (reread_symbols): Likewise.
1861         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1862         * solib-darwin.c (darwin_bfd_open): Likewise.
1863         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1864
1865 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1868         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1869
1870 2019-09-03  Tom Tromey  <tromey@adacore.com>
1871
1872         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1873         types.
1874         (has_negatives): Unbias a range type bound.
1875         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1876         * gdbtypes.c (operator==): Handle new field.
1877         (create_range_type): Add "bias" parameter.
1878         (create_static_range_type, resolve_dynamic_range): Update.
1879         * gdbtypes.h (struct range_bounds) <bias>: New member.
1880         (create_range_type): Add bias parameter.
1881         * printcmd.c (print_scalar_formatted): Unbias range types.
1882         * value.c (unpack_long): Unbias range types.
1883         (pack_long): Bias range types.
1884
1885 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1886
1887         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1888         probe arguments.
1889
1890 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1891
1892         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1893         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1894         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1895         (compile_probe_arg): Likewise.
1896         * probe.h (get_argument_count): Likewise.
1897         * solib-svr4.c (solib_event_probe_action): Likewise.
1898         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1899
1900 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1901
1902         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1903         code to here...
1904         (svr4_create_solib_event_breakpoints): ...from here.
1905
1906 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1907
1908         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1909         suffix from warning message.
1910
1911 2019-08-30  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-winsource.h (struct tui_source_window_base)
1914         <refresh_all>: Don't declare.
1915         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1916         Remove.
1917         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1918         tui_show_locator_content.
1919         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1920         declare.
1921         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1922         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1923         declare.
1924
1925 2019-08-30  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1928
1929 2019-08-30  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1932         Remove unnecessary forward declarations.
1933
1934 2019-08-30  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1937         rerender.
1938         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1939         tui_show_locator_content.
1940
1941 2019-08-30  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1944         (tui_locator_window::rerender): Rewrite using body of previous
1945         tui_show_locator_content.
1946
1947 2019-08-30  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1950         set_locator_fullname>: New methods.
1951         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1952         Rename from tui_set_locator_fullname.
1953         (tui_locator_window::set_locator_info): Rename from
1954         tui_set_locator_info.  Return bool.
1955         (tui_update_locator_fullname, tui_show_frame_info): Update.
1956
1957 2019-08-30  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1960
1961 2019-08-30  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1964         call touchwin.
1965
1966 2019-08-30  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-wingeneral.c (box_win): Assume win_info and
1969         win_info->handle cannot be NULL.
1970
1971 2019-08-30  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1974         refresh_window>: Declare.
1975         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1976         resize.
1977         (tui_data_item_window::rerender): Rename from
1978         tui_display_register.
1979         (tui_data_item_window::refresh_window): New method.
1980         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1981         no-op.
1982
1983 2019-08-30  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1986         regs_column_count, current_group>: Move later.  Now private.
1987         <get_current_group>: New method.
1988         * tui/tui-regs.c (tui_reg_command): Update.
1989         * tui/tui-layout.c (tui_set_layout): Update.
1990
1991 2019-08-30  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1994         (tui_data_window::rerender): Don't call
1995         check_and_display_highlight_if_needed.
1996         (tui_data_window::refresh_all): Remove call to
1997         erase_data_content.
1998
1999 2019-08-30  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2002         (tui_data_window::display_registers_from)
2003         (tui_data_window::display_reg_element_at_line)
2004         (tui_data_window::display_registers_from_line): Remove checks of
2005         "empty".
2006
2007 2019-08-30  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2010         Don't declare.
2011         * tui/tui-regs.c (tui_data_window::show_registers): Call
2012         rerender.
2013         (tui_data_window::rerender): Rename from display_all_data.
2014         (tui_data_window::rerender): Remove old implementation.
2015
2016 2019-08-30  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2019         text.
2020         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2021
2022 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2023             Sergio Durigan Junior  <sergiodj@redhat.com>
2024
2025         PR win32/24284
2026         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2027
2028 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2029
2030         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2031         when searching for types.
2032
2033 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2034
2035         * f-lang.c (f_language_defn): Use f_print_typedef.
2036         * f-lang.h (f_print_typedef): Declare.
2037         * f-typeprint.c (f_print_typedef): Define.
2038
2039 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2040
2041         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2042
2043 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * cli/cli-utils.c (info_print_options_defs): Delete.
2046         (make_info_print_options_def_group): Delete.
2047         (extract_info_print_options): Delete.
2048         (info_print_command_completer): Delete.
2049         (info_print_args_help): Add extra parameter, and optionally
2050         include text about -n flag.
2051         * cli/cli-utils.h (struct info_print_options): Delete.
2052         (extract_info_print_options): Delete declaration.
2053         (info_print_command_completer): Delete declaration.
2054         (info_print_args_help): Add extra parameter, extend header
2055         comment.
2056         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2057         search_symbols.
2058         * stack.c (struct info_print_options): New type.
2059         (info_print_options_defs): New file scoped variable.
2060         (make_info_print_options_def_group): New static function.
2061         (info_print_command_completer): New static function.
2062         (info_locals_command): Update to use new local functions.
2063         (info_args_command): Likewise.
2064         (_initialize_stack): Add extra parameter to calls to
2065         info_print_args_help.
2066         * symtab.c (search_symbols): Add extra parameter, use this to
2067         possibly excluse non-debug symbols.
2068         (symtab_symbol_info): Add extra parameter, which is passed on to
2069         search_symbols.
2070         (struct info_print_options): New type.
2071         (info_print_options_defs): New file scoped variable.
2072         (make_info_print_options_def_group): New static function.
2073         (info_print_command_completer): New static function.
2074         (info_variables_command): Update to use local functions, and pass
2075         extra parameter through to symtab_symbol_info.
2076         (info_functions_command): Likewise.
2077         (info_types_command): Pass additional argument through to
2078         symtab_symbol_info.
2079         (rbreak_command): Pass extra argument to search_symbols.
2080         (_initialize_symtab): Add extra arguments for calls to
2081         info_print_args_help, and update help text for 'info variables',
2082         'whereis', and 'info functions' commands.
2083         * symtab.h (search_symbols): Add extra argument to declaration.
2084         * NEWS: Mention new flags.
2085
2086 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2087
2088         * symtab.c (lookup_static_symbol): Call the new function (and move
2089         it down to be next to lookup_global_symbol).
2090         (struct global_sym_lookup_data): Add block_enum member and rename to...
2091         (struct global_or_static_sym_lookup_data): ...this.
2092         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2093         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2094         (lookup_symbol_global_or_static_iterator_cb): ...this.
2095         (lookup_global_or_static_symbol): New function.
2096         (lookup_global_symbol): Call new function.
2097
2098 2019-08-26  Tom de Vries  <tdevries@suse.de>
2099
2100         PR c++/24852
2101         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2102         when pc_probe.prob == NULL.
2103
2104 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2105
2106         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2107         variable symbol_linkage to symbol_linkage_.
2108
2109 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2110
2111         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2112         represent whether the symbol is static, dynamic, or we don't
2113         know.
2114
2115 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2116
2117         * gdb/rx-tdep.c (rx_register_names): New.
2118         (rx_register_name): Delete.
2119         (rx_psw_type): Delete.
2120         (rx_fpsw_type): Delete.
2121         (rx_register_type): Delete.
2122         (rx_gdbarch_init): Convert target-descriptions.
2123         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2124         * gdb/features/Makefile: Add rx.xml.
2125         * gdb/features/rx.xml: New.
2126         * gdb/features/rx.c: Generated.
2127         * gdb/NEWS: Mention target description support.
2128
2129 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2130
2131         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2132         *slot_ptr.
2133
2134 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2135
2136         * configure.ac: Don't check for 'dlfcn.h' (moved to
2137         gdbsupport/common.m4).
2138         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2139         'gdbsupport/'.
2140         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2141         * compile/compile-c-support.c: Include
2142         'gdbsupport/gdb-dlfcn.h'.
2143         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2144         * gdb-dlfcn.c: Move to...
2145         * gdbsupport/gdb-dlfcn.c: ... here.
2146         * gdb-dlfcn.h: Move to...
2147         * gdbsupport/gdb-dlfcn.h: ... here.
2148
2149 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2150
2151         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2152         the offset field signed.
2153
2154 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2155
2156         * python/lib/gdb/__init__.py (_execute_file): New function.
2157         * python/python.c (python_run_simple_file): Call gdb._execute_file
2158         on Windows.
2159
2160 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2163         all uses as this was never set to anything but a zero value.
2164
2165 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2166
2167         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2168
2169 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2170
2171         * tui/tui-data.h (tui_gen_win_info): Add an =default
2172         move constructor, required by some GCC versions.
2173
2174 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2175
2176         * go32-nat.c (go32_sysinfo): Add hygon_p.
2177
2178 2019-08-20  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2181         line_from_reg_element_no, first_reg_element_no_inline,
2182         display_all_data, delete_data_content_windows,
2183         erase_data_content>: Now private.
2184
2185 2019-08-20  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2188         (tui_unhighlight_win, tui_highlight_win)
2189         (tui_win_info::make_window): Update.
2190         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2191
2192 2019-08-20  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2195         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2196         (MAX_PID_WIDTH): Move to tui-stack.c.
2197         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2198         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2199         (MAX_PID_WIDTH): Move from tui-data.h.
2200
2201 2019-08-20  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2204         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2205         (box_win): Update.
2206         (tui_gen_win_info::make_window): Rename from tui_make_window.
2207         (tui_win_info::make_window): New method.
2208         (tui_gen_win_info::make_visible): Update.
2209         * tui/tui-source.c (tui_source_window::set_contents): Update.
2210         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2211         (tui_data_window::display_registers_from): Update.
2212         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2213         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2214         Declare.
2215         <can_box>: Remove.
2216         <title>: Remove.
2217         (struct tui_win_info) <make_window>: Declare.
2218         <can_box>: Now virtual.
2219         <title>: New member.
2220         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2221         * tui/tui-command.c (tui_cmd_window::resize): Update.
2222
2223 2019-08-20  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2226         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2227         (tui_data_window::check_register_values): Update.
2228
2229 2019-08-20  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-regs.h (struct tui_data_window): Use
2232         DISABLE_COPY_AND_ASSIGN.
2233         <regs_content>: Change type, removing unique_ptr.
2234         <tui_data_window>: Add move constructor.
2235         * tui/tui-regs.c (tui_data_window::show_registers)
2236         (tui_data_window::show_register_group)
2237         (tui_data_window::display_registers_from)
2238         (tui_data_window::display_registers_from)
2239         (tui_data_window::first_data_item_displayed)
2240         (tui_data_window::delete_data_content_windows)
2241         (tui_data_window::rerender, tui_data_window::refresh_window)
2242         (tui_data_window::check_register_values): Update.
2243
2244 2019-08-20  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2247         show_register_group>: Declare.
2248         (tui_show_register_group): Don't declare.
2249         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2250         tui_show_registers.
2251         (tui_data_window::show_register_group): Rename from
2252         tui_show_register_group.
2253         (tui_data_window::check_register_values, tui_reg_command):
2254         Update.
2255         * tui/tui-layout.c (tui_set_layout): Update.
2256
2257 2019-08-20  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2260         Declare.
2261         (tui_check_register_values): Don't declare.
2262         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2263         from tui_check_register_values.
2264         * tui/tui-hooks.c (tui_register_changed): Update.
2265
2266 2019-08-20  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-regs.c (tui_reg_layout): Move later.
2269         (tui_show_registers): Don't enable TUI mode or change layout.
2270
2271 2019-08-20  Tom Tromey  <tom@tromey.com>
2272
2273         * tui/tui-regs.h (struct tui_data_item_window)
2274         <~tui_data_item_window>: Remove.
2275         <content>: Now a unique_xmalloc_ptr.
2276         * tui/tui-regs.c (tui_register_format): Return a
2277         unique_xmalloc_ptr.
2278         (tui_get_register): Update.
2279         (~tui_data_item_window): Remove.
2280         (tui_data_window::display_registers_from, tui_display_register):
2281         Update.
2282         * tui/tui-io.h (tui_expand_tabs): Update.
2283         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2284         Remove "col" parameter.
2285
2286 2019-08-20  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2289         field.
2290         * tui/tui-regs.c (~tui_data_item_window): Update.
2291
2292 2019-08-20  Tom Tromey  <tom@tromey.com>
2293
2294         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2295         earlier.
2296
2297 2019-08-20  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2300
2301 2019-08-20  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-source.h (struct tui_source_window): Update.
2304         * tui/tui-regs.c (tui_show_registers): Update.
2305         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2306         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2307         (NO_REGS_STRING): Remove defines.
2308
2309 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2310
2311         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2312         unnecessary thread walk if remote doesn't support the packet.
2313
2314 2019-08-19  Tom Tromey  <tromey@adacore.com>
2315
2316         * python/py-value.c (value_has_field): Fix indentation.
2317
2318 2019-08-19  Tom Tromey  <tromey@adacore.com>
2319
2320         * printcmd.c (do_one_display, info_display_command): Update.
2321         * block.h (contained_in): Return bool.  Add allow_nested
2322         parameter.
2323         * block.c (contained_in): Return bool.  Add allow_nested
2324         parameter.
2325
2326 2019-08-19  Tom Tromey  <tom@tromey.com>
2327
2328         * configure: Rebuild.
2329         * configure.ac: Disallow the combination of -static-libstdc++ and
2330         source highlight.
2331         * source-cache.c (get_language_name): Handle rust.
2332         (source_cache::get_source_lines): Ignore highlighting exceptions.
2333
2334 2019-08-16  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2337         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2338         (struct tui_source_window_base) <make_visible, refresh_window,
2339         resize>: Remove methods.
2340         <execution_info>: Remove field.
2341         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2342         (tui_show_source_line, tui_source_window_base)
2343         (~tui_source_window_base): Update.
2344         (tui_source_window_base::resize)
2345         (tui_source_window_base::make_visible)
2346         (tui_source_window_base::refresh_window): Remove.
2347         (tui_source_window_base::update_exec_info): Update.
2348         * tui/tui-source.c (tui_source_window::set_contents): Update.
2349         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2350
2351 2019-08-16  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2354         deprecated_query_hook.
2355
2356 2019-08-16  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2359         (tui_update_source_windows_with_line): Update.
2360         * tui/tui-source.h (struct tui_source_window)
2361         <show_symtab_source>: Declare.
2362         (tui_show_symtab_source): Don't declare.
2363         * tui/tui-source.c (tui_show_symtab_source): Rename from
2364         tui_show_symtab_source.
2365
2366 2019-08-16  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-winsource.h (struct tui_source_window_base)
2369         <set_contents>: Declare.
2370         * tui/tui-winsource.c
2371         (tui_source_window_base::update_source_window_as_is): Update.
2372         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2373         Declare.
2374         (tui_set_source_content): Don't declare.
2375         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2376         tui_set_source_content.
2377         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2378         Declare.
2379         (tui_set_disassem_content): Don't declare.
2380         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2381         tui_set_disassem_content.
2382
2383 2019-08-16  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-winsource.h (struct tui_source_window_base)
2386         <update_breakpoint_info>: Declare.
2387         (tui_update_breakpoint_info): Don't declare.
2388         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2389         (tui_update_all_breakpoint_info): Update.
2390         (tui_source_window_base::update_breakpoint_info): Rename from
2391         tui_update_breakpoint_info.
2392         (tui_source_window_base::update_exec_info): Update.
2393
2394 2019-08-16  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-winsource.h (struct tui_source_window_base)
2397         <update_source_window>: Declare.
2398         (tui_update_source_window): Don't declare.
2399         * tui/tui-winsource.c
2400         (tui_source_window_base::update_source_window): Rename from
2401         tui_update_source_window.
2402         (tui_source_window_base::rerender): Update.
2403         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2404         * tui/tui-disasm.c (tui_show_disassem)
2405         (tui_show_disassem_and_update_source)
2406         (tui_disasm_window::maybe_update): Update.
2407
2408 2019-08-16  Tom Tromey  <tom@tromey.com>
2409
2410         * tui/tui-winsource.h (struct tui_source_window_base)
2411         <update_source_window_as_is>: Declare.
2412         (tui_update_source_window_as_is): Don't declare.
2413         * tui/tui-winsource.c (tui_update_source_window): Update
2414         (tui_source_window_base::update_source_window_as_is): Rename from
2415         tui_update_source_window_as_is.
2416         (tui_source_window_base::refill): Update.
2417         * tui/tui-source.c (tui_show_symtab_source): Update.
2418         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2419         Update.
2420
2421 2019-08-16  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-winsource.h (tui_update_source_window)
2424         (tui_update_source_window_as_is): Remove "noerror" parameter.
2425         * tui/tui-winsource.c (tui_update_source_window)
2426         (tui_update_source_window_as_is): Remove "noerror" parameter.
2427         (tui_update_source_windows_with_addr)
2428         (tui_update_source_windows_with_line)
2429         (tui_source_window_base::rerender)
2430         (tui_source_window_base::refill): Update.
2431         * tui/tui-source.h (tui_set_source_content)
2432         (tui_show_symtab_source): Remove "noerror" parameter.
2433         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2434         parameter.
2435         (tui_show_symtab_source): Likewise.
2436         (tui_source_window::maybe_update): Update.
2437         * tui/tui-disasm.c (tui_show_disassem)
2438         (tui_show_disassem_and_update_source)
2439         (tui_disasm_window::do_scroll_vertical)
2440         (tui_disasm_window::maybe_update): Update.
2441
2442 2019-08-16  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui.c (tui_is_window_visible): Update.
2445         * tui/tui-wingeneral.c (tui_make_window)
2446         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2447         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2448         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2449         (tui_set_win_height_command, parse_scrolling_args): Update.
2450         * tui/tui-source.c (tui_source_window::style_changed): Update.
2451         * tui/tui-regs.c (tui_show_registers)
2452         (tui_data_window::first_data_item_displayed)
2453         (tui_data_window::delete_data_content_windows)
2454         (tui_check_register_values, tui_reg_command): Update.
2455         * tui/tui-disasm.c (tui_show_disassem): Update.
2456         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2457         method.
2458         <is_visible>: Remove field.
2459         * tui/tui-data.c (tui_next_win, tui_prev_win)
2460         (tui_delete_invisible_windows): Update.
2461
2462 2019-08-16  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-winsource.h (struct tui_source_window_base)
2465         <m_has_locator>: Remove.
2466         * tui/tui-layout.c (show_source_disasm_command, show_data)
2467         (show_source_or_disasm_and_command): Update.
2468
2469 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2470
2471         * NEWS (Other MI changes): New subsection.
2472         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2473         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2474         * arch-utils.c (default_get_pc_address_flags): New function.
2475         * arch-utils.h (default_get_pc_address_flags): New declaration.
2476         * gdbarch.sh: Add get_pc_address_flags.
2477         * gdbarch.c: Regenerate.
2478         * gdbarch.h: Likewise.
2479         * stack.c (print_pc): New function.
2480         (print_frame_info) (print_frame): Call print_pc.
2481
2482 2019-08-16  Tom de Vries  <tdevries@suse.de>
2483
2484         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2485         print_objfile_section_info.
2486
2487 2019-08-15  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2490         calling update_cmdwin_start_line.
2491         * tui/tui-winsource.h (struct tui_source_window_base)
2492         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2493         <rerender>: Declare.
2494         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2495         Call rerender.
2496         (tui_source_window_base::set_new_height): Remove.
2497         (tui_source_window_base::rerender): Rename from
2498         do_make_visible_with_new_height.
2499         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2500         resize method.
2501         (tui_win_info::make_invisible_and_set_new_height)
2502         (tui_win_info::make_visible_with_new_height): Remove.
2503         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2504         Declare.
2505         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2506         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2507         do_make_visible_with_new_height>: Don't declare.
2508         <rerender>: Declare.
2509         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2510         set_new_height.
2511         (tui_data_window::do_make_visible_with_new_height): Remove.
2512         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2513         call tui_show_locator_content.
2514         (tui_gen_win_info::resize): Call rerender.
2515         (show_source_or_disasm_and_command): Don't call
2516         tui_show_locator_content.
2517         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2518         method.
2519         (struct tui_win_info) <rerender>: Declare.
2520         <set_new_height, make_invisible_and_set_new_height,
2521         make_visible_with_new_height>: Don't declare.
2522         * tui/tui-data.c (tui_win_list::rerender): New method.
2523         * tui/tui-command.h (struct tui_cmd_window)
2524         <do_make_visible_with_new_height>: Don't declare.
2525         * tui/tui-command.c
2526         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2527
2528 2019-08-15  Tom Tromey  <tromey@adacore.com>
2529
2530         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2531         * ada-lang.c (ada_enum_name): Likewise.
2532
2533 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2534
2535         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2536         leading underscore.
2537         (GdbOutputErrorFile): Likewise.
2538         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2539         accordingly.
2540         (execute_unwinders): Rename to have a leading underscore.
2541         (auto_load_packages): Likewise.
2542         (global scope): Adjust call to auto_load_packages accordingly.
2543         (GdbSetPythonDirectory): Likewise.
2544         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2545         instead of execute_unwinders.
2546
2547 2019-08-15  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2550         (show_data): Don't change window visibility.
2551         (tui_gen_win_info::resize): Remove special case for command
2552         window.  Use wresize, when available.
2553         (show_source_or_disasm_and_command): Don't change window
2554         visibility.
2555         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2556         <make_visible>: New method.
2557         * tui/tui-command.c (tui_cmd_window::resize): New method.
2558
2559 2019-08-15  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2562         (struct tui_source_windows): New.
2563         * tui/tui-winsource.c (tui_display_main): Update.
2564         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2565         (new_height_ok, parse_scrolling_args): Update.
2566         * tui/tui-layout.c (show_layout, show_data): Update.
2567         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2568         (tui_add_to_source_windows): Don't declare.
2569         * tui/tui-data.c (source_windows, tui_source_windows)
2570         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2571
2572 2019-08-15  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2575         Rename from reset.
2576         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2577         * tui/tui-layout.c (show_source_disasm_command, show_data):
2578         Update.
2579         (tui_gen_win_info::resize): Rename.
2580         (show_source_or_disasm_and_command): Update.
2581         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2582         reset.
2583
2584 2019-08-15  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2587         * tui/tui-interp.c (tui_interp::init): Don't call
2588         tui_initialize_static_data.
2589         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2590
2591 2019-08-15  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2594         examine tui_win_list.
2595
2596 2019-08-15  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2599         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2600         tui_clear_source_content.
2601         (tui_clear_source_content): Remove.
2602         (tui_source_window_base::do_erase_source_content): Hoist call to
2603         content.clear().
2604         * tui/tui-stack.c (tui_show_frame_info): Don't call
2605         tui_clear_source_content.
2606
2607 2019-08-15  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-winsource.h (struct tui_source_window_base)
2610         <do_erase_source_content>: New method.
2611         <erase_source_content>: New method.
2612         (tui_erase_source_content): Don't declare.
2613         * tui/tui-winsource.c (tui_clear_source_content): Update.
2614         (tui_source_window_base::do_erase_source_content): Rename from
2615         tui_erase_source_content.
2616         (tui_source_window_base::show_source_content): Update.
2617         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2618         * tui/tui-source.h (struct tui_source_window)
2619         <erase_source_content>: New method.
2620         * tui/tui-disasm.h (struct tui_disasm_window)
2621         <erase_source_content>: New method.
2622
2623 2019-08-15  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2626         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2627         constructor.
2628         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2629         * tui/tui-source.c (tui_set_source_content): Update.
2630         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2631
2632 2019-08-15  Tom Tromey  <tom@tromey.com>
2633
2634         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2635         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2636         tui-source.c.
2637         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2638         Declare.
2639         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2640         method.
2641         (tui_source_window::maybe_update): Update.
2642
2643 2019-08-15  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2646         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2647         tui-disasm.c.
2648         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2649         Declare.
2650         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2651         method.
2652         (tui_disasm_window::maybe_update): Update.
2653
2654 2019-08-15  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-winsource.h (struct tui_source_window_base)
2657         <maybe_update>: Declare.
2658         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2659         method.
2660         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2661         Declare.
2662         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2663         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2664         Declare.
2665         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2666
2667 2019-08-15  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2670
2671 2019-08-15  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-wingeneral.c: Include tui-stack.h.
2674         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2675         (struct tui_locator_window): Move from tui-data.h.
2676         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2677         (tui_initialize_static_data): Move from tui-data.c.
2678         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2679         (struct tui_locator_window): Move to tui-stack.c.
2680         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2681         (tui_initialize_static_data): Move to tui-stack.c.
2682
2683 2019-08-15  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-layout.c (show_source_disasm_command)
2686         (show_source_or_disasm_and_command): Use make_visible method, not
2687         tui_make_window.
2688         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2689         Remove.
2690
2691 2019-08-15  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-wingeneral.h (tui_make_window): Update.
2694         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2695         parameter.
2696         (tui_gen_win_info::make_visible): Update.
2697         * tui/tui-regs.c (tui_data_window::display_registers_from):
2698         Update.
2699         * tui/tui-layout.c (show_source_disasm_command)
2700         (show_source_or_disasm_and_command): Update.
2701         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2702         (enum tui_box): Remove.
2703         (struct tui_win_info) <can_box>: New method.
2704         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2705         method.
2706
2707 2019-08-15  Tom de Vries  <tdevries@suse.de>
2708
2709         * linux-nat-trad.c: Include gdbarch.h.
2710
2711 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2712
2713         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2714         register sizes.
2715
2716 2019-08-14  Tom Tromey  <tromey@adacore.com>
2717
2718         * darwin-nat.c: Include gdbarch.h.
2719         * darwin-nat-info.c: Include gdbarch.h.
2720
2721 2019-08-13  Tom Tromey  <tom@tromey.com>
2722
2723         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2724         Remove.
2725         * tui/tui-data.c (tui_initialize_static_data): Update.
2726
2727 2019-08-13  Tom Tromey  <tom@tromey.com>
2728
2729         * tui/tui-winsource.h (struct tui_exec_info_window)
2730         <~tui_exec_info_window, maybe_allocate_content, get_content,
2731         m_content>: Remove.
2732         (struct tui_source_window_base) <set_exec_info_content,
2733         show_exec_info_content>: Don't declare.
2734         * tui/tui-winsource.c
2735         (tui_exec_info_window::maybe_allocate_content): Remove.
2736         (tui_source_window_base::update_exec_info): Rename from
2737         set_exec_info_content.
2738         (tui_source_window_base::show_exec_info_content)
2739         (tui_source_window_base::update_exec_info): Remove.
2740
2741 2019-08-13  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2744         declare.
2745         * tui/tui-winsource.c (tui_update_source_window_as_is)
2746         (tui_update_source_windows_with_addr, tui_erase_source_content):
2747         Update.
2748         (tui_clear_exec_info_content): Remove.
2749
2750 2019-08-13  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2753         declare.
2754         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2755         call tui_erase_exec_info_content.
2756         (tui_clear_exec_info_content): Rename from
2757         tui_erase_exec_info_content.
2758         (tui_clear_exec_info_content): Delete.
2759
2760 2019-08-13  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-winsource.h (struct tui_source_window_base)
2763         <show_exec_info_content>: Declare.
2764         (tui_show_exec_info_content): Don't declare.
2765         * tui/tui-winsource.c
2766         (tui_source_window_base::show_exec_info_content): Rename from
2767         tui_show_exec_info_content.
2768         (tui_source_window_base::update_exec_info): Update.
2769
2770 2019-08-13  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2773         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2774         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2775         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2776         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2777         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2778         ... here.
2779
2780 2019-08-13  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-winsource.h (struct tui_source_window_base)
2783         <update_exec_info>: Declare.
2784         (tui_update_exec_info): Don't declare.
2785         * tui/tui-winsource.c (tui_update_source_window_as_is)
2786         (tui_source_window_base::refresh_all)
2787         (tui_update_all_breakpoint_info): Update.
2788         (tui_source_window_base::update_exec_info): Rename from
2789         tui_update_exec_info.
2790         * tui/tui-stack.c (tui_show_frame_info): Update.
2791
2792 2019-08-13  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-winsource.h (struct tui_source_window_base)
2795         <set_exec_info_content>: Declare.
2796         (tui_set_exec_info_content): Don't declare.
2797         * tui/tui-winsource.c
2798         (tui_source_window_base::set_exec_info_content): Rename from
2799         tui_set_exec_info_content.
2800         (tui_update_exec_info): Update.
2801
2802 2019-08-13  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-winsource.h (struct tui_source_window_base)
2805         <show_source_content>: Declare.
2806         (tui_show_source_content): Don't declare.
2807         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2808         (tui_source_window_base::show_source_content): Rename from
2809         tui_show_source_content.
2810         (tui_source_window_base::refresh_all): Update.
2811         * tui/tui-layout.c (show_source_disasm_command)
2812         (show_source_or_disasm_and_command): Update.
2813
2814 2019-08-13  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-winsource.c (tui_erase_source_content)
2817         (tui_show_source_content, tui_source_window_base::refresh_all):
2818         Update.
2819         * tui/tui-wingeneral.h
2820         (tui_check_and_display_highlight_if_needed): Don't declare.
2821         * tui/tui-wingeneral.c
2822         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2823         check_and_display_highlight_if_needed.
2824         * tui/tui-win.c (tui_rehighlight_all)
2825         (tui_win_info::make_visible_with_new_height): Update.
2826         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2827         (tui_data_window::erase_data_content)
2828         (tui_data_window::display_all_data): Update.
2829         * tui/tui-data.h (struct tui_win_info)
2830         <check_and_display_highlight_if_needed>: Declare.
2831
2832 2019-08-13  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-win.c (tui_resize_all): Call
2835         tui_delete_invisible_windows.
2836         * tui/tui-layout.c (show_layout): Call
2837         tui_delete_invisible_windows.
2838         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2839         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2840
2841 2019-08-13  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2844         tui_add_win_to_layout.
2845
2846 2019-08-13  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2849         * tui/tui-layout.c (tui_default_win_height): Now static.
2850
2851 2019-08-13  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2854         single switch.
2855         (show_source_disasm_command, show_source_or_disasm_and_command):
2856         Don't check current layout.
2857
2858 2019-08-13  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-wingeneral.c (make_all_visible): Remove.
2861         (tui_make_all_invisible): Simplify.
2862         * tui/tui-layout.c (tui_make_all_invisible): Move from
2863         tui-wingeneral.c; simplify.
2864         (show_layout): Hoist call to tui_make_all_invisible.
2865         (show_data): Don't call tui_make_all_invisible.
2866
2867 2019-08-13  Tom Tromey  <tom@tromey.com>
2868
2869         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2870         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2871
2872 2019-08-13  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2875         tui-data.c.
2876         (show_source_disasm_command, show_data)
2877         (show_source_or_disasm_and_command): Don't use
2878         tui_set_current_layout_to.
2879         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2880         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2881         tui-layout.c.
2882         (tui_set_current_layout_to): Remove.
2883
2884 2019-08-13  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-layout.c (tui_set_layout): Update.
2887         * tui/tui-data.h (struct tui_layout_def): Remove.
2888         (tui_layout_def): Don't declare.
2889         * tui/tui-data.c (layout_def): Remove.
2890         (tui_layout_def): Remove.
2891
2892 2019-08-13  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-winsource.h (struct tui_source_window_base)
2895         <clear_detail>: No longer "override".
2896         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2897         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2898         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2899         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2900         Remove.
2901         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2902
2903 2019-08-13  Tom Tromey  <tromey@adacore.com>
2904
2905         * tracepoint.c: Don't include readline.h or history.h.
2906
2907 2019-08-12  Tom Tromey  <tom@tromey.com>
2908
2909         * configure: Rebuild.
2910         * configure.ac: Check for readline 7.
2911         * NEWS: Mention readline 7 requirement.
2912         * README: Update.
2913
2914 2019-08-12  Tom Tromey  <tom@tromey.com>
2915
2916         * mingw-hdep.c (gdb_select): Remove readline hack.
2917
2918 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2919
2920         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2921         when the function fails.
2922
2923 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2924
2925         * s390-tdep.c (s390_type_align): New function.
2926         (s390_gdbarch_init): Set it as type_align gdbarch method.
2927
2928 2019-08-09  Tom de Vries  <tdevries@suse.de>
2929
2930         PR gdb/24591
2931         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2932         pc_low with relocation offset.
2933
2934 2019-08-07  Tom Tromey  <tromey@adacore.com>
2935
2936         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2937         (print_frame_args): Update.
2938         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2939         Update.
2940         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2941         * frame.h (struct frame_arg): Add initializers.
2942         <error>: Now a unique_xmalloc_ptr.
2943
2944 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2945
2946         * NEWS: Expand the Pointer Authentication entry.
2947         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2948         (aarch64_frame_unmask_lr): ... to this.
2949         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2950         Call aarch64_frame_unmask_lr.
2951         * frame.c (struct frame_info): Add "masked" variable.
2952         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2953         (fprint_frame): Check for masked pc.
2954         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2955         declarations.
2956         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2957         * stack.c (print_frame): Check for masked pc.
2958
2959 2019-08-06  Tom Tromey  <tom@tromey.com>
2960
2961         * stabsread.c (patch_block_stabs, read_one_struct_field)
2962         (read_enum_type): Use obstack_strndup.
2963         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2964         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2965         * dwarf2read.c (guess_full_die_structure_name)
2966         (anonymous_struct_prefix): Use obstack_strndup.
2967         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2968         * c-exp.y (yylex): Use obstack_strndup.
2969         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2970         (write_var_or_type): Use obstack_strndup.
2971
2972 2019-08-06  Tom Tromey  <tom@tromey.com>
2973
2974         * symfile.c (reread_symbols): Use obstack_strdup.
2975         * stabsread.c (read_type): Use obstack_strdup.
2976         * gdb_obstack.h (obstack_strdup): New overload.
2977         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2978         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2979         (dwarf2_canonicalize_name): Use obstack_strdup.
2980         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2981         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2982         Use obstack_strdup.
2983
2984 2019-08-06  Tom Tromey  <tom@tromey.com>
2985
2986         * gdb_obstack.h (obstack_strdup): Define.
2987         * gdb_obstack.c (obstack_strdup): Don't define.
2988
2989 2019-08-06  Tom Tromey  <tom@tromey.com>
2990
2991         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2992         obstack_strdup.
2993         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2994         obstack_strdup.
2995         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2996         * stabsread.c (common_block_start): Use obstack_strdup.
2997         * objfiles.c (set_objfile_main_name, objfile): Use
2998         obstack_strdup.
2999         * namespace.c (add_using_directive): Use obstack_strdup.
3000         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3001         * jit.c (finalize_symtab): Use obstack_strdup.
3002         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3003         (guess_partial_die_structure_name, partial_die_info::fixup)
3004         (dwarf2_name): Use obstack_strdup.
3005         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3006         obstack_strdup.
3007         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3008         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3009         obstack_strdup.
3010         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3011
3012 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3013
3014         * unittests/help-doc-selftests.c: New file.
3015         * Makefile.in: Add the new file.
3016
3017 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3018
3019         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3020         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3021         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3022         the trailing '.' is not output, and the first character is uppercased.
3023         (print_help_for_command): Update call to print_doc_line.
3024         (print_doc_of_command): Likewise.
3025         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3026         * cli/cli-option.c (append_indented_doc): Do not append newline.
3027         (build_help_option): Append newline after first appended_indented_doc
3028         only if a second call is done.
3029         (build_help): Append 2 new lines before each option, except the first
3030         one.
3031         * compile/compile.c (_initialize_compile): Add new lines after
3032         %OPTIONS%, when not at the end of the help.
3033         Change help doc or code
3034         producing the help doc to respect the invariants.
3035         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3036         Also removed the new line after 'Options:', as all other commands
3037         do not put an empty line between 'Options:' and the first option.
3038         * printcmd.c (_initialize_printcmd): Likewise.
3039         * stack.c (_initialize_stack): Likewise.
3040         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3041         incorrectly telling COMMAND is optional.
3042         * ada-lang.c (_initialize_ada_language): Change help doc or code
3043         producing the help doc to respect the invariants.
3044         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3045         * breakpoint.c (_initialize_breakpoint): Likewise.
3046         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3047         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3048         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3049         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3050         _initialize_cli_style): Likewise.
3051         * corelow.c (core_target_info): Likewise.
3052         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3053         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3054         * filesystem.c (_initialize_filesystem): Likewise.
3055         * frame.c (_initialize_frame): Likewise.
3056         * gnu-nat.c (add_task_commands): Likewise.
3057         * infcall.c (_initialize_infcall): Likewise.
3058         * infcmd.c (_initialize_infcmd): Likewise.
3059         * interps.c (_initialize_interpreter): Likewise.
3060         * language.c (_initialize_language): Likewise.
3061         * linux-fork.c (_initialize_linux_fork): Likewise.
3062         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3063         * maint.c (_initialize_maint_cmds): Likewise.
3064         * memattr.c (_initialize_mem): Likewise.
3065         * printcmd.c (_initialize_printcmd): Likewise.
3066         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3067         _RegEx): Likewise.
3068         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3069         * record-btrace.c (_initialize_record_btrace): Likewise.
3070         * record-full.c (_initialize_record_full): Likewise.
3071         * record.c (_initialize_record): Likewise.
3072         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3073         * regcache.c (_initialize_regcache): Likewise.
3074         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3075         _initialize_remote): Likewise.
3076         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3077         * serial.c (_initialize_serial): Likewise.
3078         * skip.c (_initialize_step_skip): Likewise.
3079         * source.c (_initialize_source): Likewise.
3080         * stack.c (_initialize_stack): Likewise.
3081         * symfile.c (_initialize_symfile): Likewise.
3082         * symtab.c (_initialize_symtab): Likewise.
3083         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3084         * top.c (init_main): Likewise.
3085         * tracefile-tfile.c (tfile_target_info): Likewise.
3086         * tracepoint.c (_initialize_tracepoint): Likewise.
3087         * tui/tui-win.c (_initialize_tui_win): Likewise.
3088         * utils.c (add_internal_problem_command): Likewise.
3089         * valprint.c (value_print_option_defs): Likewise.
3090
3091 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3092
3093         PR build/24886
3094         * configure.ac: Drop enable-libmcheck support.
3095         * configure, config.in: Rebuild.
3096         * libmcheck.m4: Remove.
3097         * acinclude.m4: Don't include it.
3098         * Makefile.in: Don't distribute it.
3099         * top.c (print_gdb_configuration): Don't mention it.
3100
3101 2019-08-06  Tom Tromey  <tom@tromey.com>
3102
3103         * utils.c (set_output_style): Sometimes pass stream to
3104         emit_style_escape.
3105         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3106         * record-btrace.c (btrace_insn_history): Update.
3107         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3108         method.
3109         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3110         Update initializers.
3111         <m_uiout>: New field.
3112         <m_di>: Move lower.
3113         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3114         Remove "uiout" parameter.
3115         (dump_insns): Update.
3116         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3117         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3118
3119 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3120
3121         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3122         (error_in_psymtab_expansion): Likewise.
3123         (lookup_symbol_via_quick_fns): Likewise.
3124         (basic_lookup_transparent_type_quick): Likewise.
3125         (basic_lookup_transparent_type_1): Likewise.
3126
3127 2019-08-06  Tom Tromey  <tromey@adacore.com>
3128
3129         * source.c (last_source_error): Now bool.
3130         (print_source_lines_base): Make "noprint" bool.  Only open
3131         source file when last_source_visited changes.
3132
3133 2019-08-06  Tom Tromey  <tromey@adacore.com>
3134
3135         * annotate.c (annotate_source_line): Use g_source_cache.
3136         * source-cache.c (source_cache::get_plain_source_lines): Change
3137         parameters.  Populate m_offset_cache.
3138         (source_cache::ensure): New method.
3139         (source_cache::get_line_charpos): New method.
3140         (extract_lines): Move lower.  Change parameters.
3141         (source_cache::get_source_lines): Move lower.
3142         * source-cache.h (class source_cache): Update comment.
3143         <get_line_charpos>: New method.
3144         <get_source_lines>: Update comment.
3145         <clear>: Clear m_offset_cache.
3146         <get_plain_source_lines>: Change parameters.
3147         <ensure>: New method
3148         <m_offset_cache>: New member.
3149         * source.c (forget_cached_source_info_for_objfile): Update.
3150         (info_source_command): Use g_source_cache.
3151         (find_source_lines, open_source_file_with_line_charpos): Remove.
3152         (print_source_lines_base, search_command_helper): Use g_source_cache.
3153         * source.h (open_source_file_with_line_charpos): Don't declare.
3154         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3155         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3156         Use g_source_cache.
3157
3158 2019-08-06  Tom Tromey  <tromey@adacore.com>
3159
3160         * source-cache.c (source_cache::get_plain_source_lines):
3161         Remove "first_line" and "last_line" parameters.
3162         (source_cache::get_source_lines): Cache plain text.
3163         * source-cache.h (class source_cache)
3164         <get_plain_source_lines>: Update.
3165
3166 2019-08-06  Tom Tromey  <tromey@adacore.com>
3167
3168         * source-cache.c (extract_lines): No longer a method.
3169         Changed type of parameter.  Include final newline.
3170         (selftests::extract_lines_test): New function.
3171         (_initialize_source_cache): Likewise.
3172         * source-cache.h (class source_cache)
3173         <extract_lines>: Don't declare.
3174
3175 2019-08-06  Tom Tromey  <tromey@adacore.com>
3176
3177         * breakpoint.c (init_breakpoint_sal): Update.
3178         (breakpoint): Update.
3179         * breakpoint.h (struct breakpoint) <filter>: Now a
3180         unique_xmalloc_ptr.
3181
3182 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3183
3184         * NEWS: Mention dictionary access on blocks.
3185         * python/py-block.c (blpy_getitem): New function.
3186         (block_object_as_mapping): New struct.
3187         (block_object_type): Use new struct for tp_as_mapping field.
3188
3189 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3190
3191         * objfiles.h (objfile): Add a comment describing partial symbols.
3192
3193 2019-08-05  Tom Tromey  <tromey@adacore.com>
3194
3195         * compile/compile.c (_initialize_compile): Use _(), not N_().
3196         * thread.c (_initialize_thread): Use _(), not N_().
3197         * stack.c (_initialize_stack): Use _(), not N_().
3198         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3199
3200 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3201
3202         * dwarf2read.c (struct dw2_symtab_iterator):
3203         <want_specific_block>: Remove.
3204         <block_index>: Change type to gdb::optional.
3205         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3206         change type of BLOCK_INDEX parameter to gdb::optional.
3207         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3208         (dw2_lookup_symbol): Don't pass argument for
3209         WANT_SPECIFIC_BLOCK.
3210         (dw2_expand_symtabs_for_function): Don't pass argument for
3211         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3212         (class dw2_debug_names_iterator)
3213         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3214         parameter, change BLOCK_INDEX type to gdb::optional.
3215         <m_want_specific_block>: Remove.
3216         <m_block_index>: Change type to gdb::optional.
3217         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3218         gdb::optional.  Re-write in function of gdb::optional.
3219         (dw2_debug_names_lookup_symbol): Don't pass argument for
3220         WANT_SPECIFIC_BLOCK.
3221         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3222         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3223         BLOCK_INDEX.
3224
3225 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3226
3227         * NEWS: Mention changes to "info sources" command.
3228
3229 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3230
3231         * symtab.c (filename_partial_match_opts): New struct type.
3232         (struct output_source_filename_data): New members
3233         regexp, c_regexp, partial_match.
3234         (output_source_filename): Use new members to decide to print file.
3235         (info_sources_option_defs): New variable.
3236         (make_info_sources_options_def_group, print_info_sources_header,
3237         info_sources_command_completer):
3238         New functions.
3239         (info_sources_command): Read new optional arguments.
3240         (_initialize_symtab): Update info sources help.
3241
3242 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3243
3244         * ada-lang.c (exception_support_info_v0): Renamed from...
3245         (default_exception_support_info): ... this.  Create new
3246         definition for v1.
3247         (ada_has_this_exception_support): Look up catch_handlers_sym.
3248         (ada_exception_support_info_sniffer): Try v0 after default.
3249
3250 2019-08-01  Tom Tromey  <tromey@adacore.com>
3251
3252         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3253         gdbarch.h.
3254
3255 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3256
3257         * s12z-tdep.c: Fix include path for s12z-opc.h.
3258
3259 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3260
3261         * NEWS: Require GNU make 3.82.
3262
3263 2019-07-16  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3266         declare.
3267
3268 2019-07-30  Tom Tromey  <tromey@adacore.com>
3269
3270         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3271
3272 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3273
3274         * printcmd.c (print_address_symbolic): Print negative offsets.
3275         (build_address_symbolic): Force signed arithmetic when computing
3276         offset.
3277
3278 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3279
3280         PR/24474: Add a function to lookup static variables.
3281         * NEWS: Mention this new function.
3282         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3283         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3284         * python/python.c (python_GdbMethods): Add new function.
3285
3286 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3287
3288         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3289         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3290         (objfpy_lookup_static_symbol): New function.
3291         (objfile_object_methods): Add new functions.
3292
3293 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3294
3295         * NEWS: Mention 'set|show print frame-info'.  Mention new
3296         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3297         backtrace argument.  Mention that python frame filtering code
3298         is now consistent with what 'backtrace' command prints.
3299
3300 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3301
3302         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3303         comments.
3304         (print_frame_info_auto, print_frame_info_source_line,
3305         print_frame_info_location, print_frame_info_source_and_location,
3306         print_frame_info_location_and_address, print_frame_info_short_location):
3307         New declarations.
3308         (struct frame_print_options): New member print_frame_info.
3309         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3310         * stack.h (get_user_print_what_frame_info): New declaration.
3311         (frame_show_address): New declaration.
3312         * stack.c (print_frame_arguments_choices): New value 'presence'.
3313         (print_frame_info_auto, print_frame_info_source_line,
3314         print_frame_info_location, print_frame_info_source_and_location,
3315         print_frame_info_location_and_address, print_frame_info_short_location,
3316         print_frame_info_choices, print_frame_info_print_what): New definitions.
3317         (print_frame_args): Only print dots for args if print frame-arguments
3318         is 'presence'.
3319         (frame_print_option_defs): New element for "frame-info".
3320         (get_user_print_what_frame_info): New function.
3321         (frame_show_address): Make non static.  Move comment to stack.h.
3322         (print_frame_info_to_print_what): New function.
3323         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3324         to decide what to print.
3325         (backtrace_command_1): Handle the new print_frame_arguments_presence
3326         value.
3327         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3328         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3329         (py_print_frame): In non-mi mode, use LOCATION as default for
3330         print_what, similarly to frame information printed directly by
3331         backtrace command. Handle frame-info user option in non MI mode.
3332
3333 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3334
3335         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3336         Add case for debugging 32-bit target on 64-bit host.  Revise
3337         comment.
3338
3339 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3340
3341         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3342         instead of find_function_entry_range_from_pc.
3343
3344 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3345
3346         * stack.c (find_frame_funname): Remove code which preferred
3347         minsym over symtab sym in "certain pathological cases".
3348
3349         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3350         parameter.  Change type of "do_demangle" to bool.
3351         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3352         Pass suitable "prefer_sym_over_minsym" flag to
3353         build_address_symbolic().  Don't output "+" for negative offsets.
3354         * printcmd.c (print_address_symbolic): Update invocation of
3355         build_address_symbolic to include a "prefer_sym_over_minsym"
3356         flag.
3357         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3358         Restrict cases in which use of minimal symbol is preferred to that
3359         of a found symbol.  Update comments.
3360
3361         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3362         for entry pc when entry pc is out of range for that FDE.
3363
3364 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3365
3366         PR gdb/24839:
3367         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3368         type.
3369
3370 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3371
3372         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3373         this function's Python signature.
3374
3375
3376 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3377
3378         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3379         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3380         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3381         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3382         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3383
3384
3385 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3386
3387         * h8300-tdep.c (h8300_register_name_common): New.
3388         h8300_register_name): Use h8300_register_name_common.
3389         (h8300s_register_name): Likewise.
3390         (h8300sx_register_name): Likewise.
3391         (h8300h_register_nam): New.
3392         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3393
3394
3395 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3396
3397         * arm-tdep.c (arm_skip_cmse_entry): New function.
3398         (arm_is_sgstubs_section): New function.
3399         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3400
3401 2019-07-22  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3404         Don't self-assign.
3405
3406 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3407
3408         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3409         type_print.
3410
3411 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3414         so that GDB doesn't match any msymbols when searching in the
3415         TYPES_DOMAIN.
3416         (print_symbol_info): Print using typedef_print or type_print based
3417         on the type of the symbol.  Add updated FIXME comment moved from...
3418         (_initialize_symtab): ... move and update FIXME comment to above.
3419
3420 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3421
3422         * NEWS: Mention adding -q option to "info types".
3423         * symtab.c (struct info_types_options): New struct.
3424         (info_types_options_defs): New variable.
3425         (make_info_types_options_def_group): New function.
3426         (info_types_command): Use gdb::option framework to parse options.
3427         (info_types_command_completer): New function.
3428         (_initialize_symtab): Extend the help text on "info types" and
3429         register command completer.
3430
3431 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3432
3433         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3434         (lookup_symbol_in_objfile): Change int to block_enum and add a
3435         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3436
3437 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3438
3439         * MAINTAINERS (Write After Approval): Add self.
3440
3441 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3444         instruction to the dummy code region.
3445
3446 2019-07-19  Tom Tromey  <tromey@adacore.com>
3447
3448         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3449         (ARGSUSED, PARAMS, __func__): Remove rules.
3450
3451 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3452
3453         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3454         * features/arm/arm-with-iwmmxt.c: Remove.
3455         * features/arm/arm-with-iwmmxt.xml: Remove.
3456         * features/arm/arm-with-m-fpa-layout.c: Remove.
3457         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3458         * features/arm/arm-with-m-vfp-d16.c: Remove.
3459         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3460         * features/arm/arm-with-m.c: Remove.
3461         * features/arm/arm-with-m.xml: Remove.
3462         * features/arm/arm-with-neon.c: Remove.
3463         * features/arm/arm-with-neon.xml: Remove.
3464         * features/arm/arm-with-vfpv2.c: Remove.
3465         * features/arm/arm-with-vfpv2.xml: Remove.
3466         * features/arm/arm-with-vfpv3.c: Remove.
3467         * features/arm/arm-with-vfpv3.xml: Remove.
3468
3469 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3470
3471         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3472
3473 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3474
3475         * arch/aarch32.c (aarch32_create_target_description): Create
3476         target descriptions using features.
3477         * arch/arm.c (arm_create_target_description)
3478         (arm_create_mprofile_target_description): Likewise.
3479         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3480
3481 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3482
3483         * Makefile.in: Add new files.
3484         * aarch32-tdep.c: New file.
3485         * aarch32-tdep.h: New file.
3486         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3487         Call aarch32_read_description.
3488         * arch/aarch32.c: New file.
3489         * arch/aarch32.h: New file.
3490         * arch/arm.c (arm_create_target_description)
3491         (arm_create_mprofile_target_description): New function.
3492         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3493         (arm_create_target_description)
3494         (arm_create_mprofile_target_description): New declaration.
3495         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3496         read_description functions.
3497         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3498         Likewise.
3499         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3500         * arm-tdep.c (tdesc_arm_list): New variable.
3501         (arm_register_g_packet_guesses): Call create description functions.
3502         (arm_read_description) (arm_read_mprofile_description): New
3503         function.
3504         * arm-tdep.h (arm_read_description)
3505         (arm_read_mprofile_description): Add declaration.
3506         * configure.tgt: Add new files.
3507
3508 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3509
3510         * top.c (new_ui_command): Open specified terminal just once.
3511
3512 2019-07-18  Tom Tromey  <tromey@adacore.com>
3513
3514         * symtab.c (main_name): Constify return type.
3515         * symfile.c (set_initial_language): Update.
3516         * symtab.h (main_name): Constify return type.
3517
3518 2019-07-17  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-winsource.c (tui_update_source_window)
3521         (tui_update_source_window_as_is)
3522         (tui_update_source_windows_with_line): Remove return.
3523         * tui/tui-disasm.c (tui_show_disassem)
3524         (tui_show_disassem_and_update_source): Remove return.
3525         * tui/tui.c (tui_reset): Remove return.
3526         * tui/tui-wingeneral.c
3527         (tui_check_and_display_highlight_if_needed): Remove return.
3528
3529 2019-07-17  Tom Tromey  <tom@tromey.com>
3530
3531         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3532
3533 2019-07-17  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-winsource.h (struct tui_exec_info_window)
3536         (struct tui_source_window_base): Move from tui-data.h.
3537         * tui/tui-winsource.c: Move many method definitions from
3538         elsewhere.  Remove "structuring" comments.
3539         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3540         (tui_source_window_base::refresh_window): Move to
3541         tui-winsource.c.
3542         * tui/tui-win.c (tui_source_window_base::refresh_all)
3543         (tui_source_window_base::update_tab_width)
3544         (tui_source_window_base::set_new_height)
3545         (tui_source_window_base::do_make_visible_with_new_height): Move to
3546         tui-winsource.c.
3547         * tui/tui-source.h: Update.
3548         * tui/tui-source.c (tui_source_window_base::reset): Move to
3549         tui-winsource.c.
3550         * tui/tui-disasm.h: Update.
3551         * tui/tui-data.h (struct tui_exec_info_window): Move to
3552         tui-winsource.h.
3553         (struct tui_source_window_base): Likewise.
3554         * tui/tui-data.c (tui_source_window_base::clear_detail)
3555         (tui_source_window_base, ~tui_source_window_base): Move to
3556         tui-winsource.c.
3557
3558 2019-07-17  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-win.c (tui_resize_all)
3561         (tui_source_window_base::update_tab_width)
3562         (tui_adjust_win_heights): Update.
3563         (tui_win_info::make_invisible_and_set_new_height): Rename from
3564         make_invisible_and_set_new_height.
3565         * tui/tui-data.h (struct tui_win_info)
3566         <make_invisible_and_set_new_height>: New method.
3567
3568 2019-07-17  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui.c: Update.
3571         * tui/tui-source.h (struct tui_source_window): Move from
3572         tui-data.h.
3573         * tui/tui-layout.c: Update.
3574         * tui/tui-disasm.c: Update.
3575         * tui/tui-data.h (struct tui_source_window): Move to
3576         tui-source.h.
3577
3578 2019-07-17  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3581         tui-data.h.
3582         * tui/tui-data.h (struct tui_disasm_window): Move to
3583         tui-disasm.h.
3584
3585 2019-07-17  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-regs.h (struct tui_data_item_window): Move from
3588         tui-data.h.
3589         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3590         * tui/tui-data.h (struct tui_data_item_window): Move to
3591         tui-regs.h.
3592         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3593
3594 2019-07-17  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui.c: Update.
3597         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3598         (tui_cmd_window::max_height): Move to tui-command.c.
3599         * tui/tui-layout.c: Update.
3600         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3601         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3602         tui-command.c.
3603         * tui/tui-command.h (struct tui_cmd_window): Move from
3604         tui-data.h.
3605         * tui/tui-command.c: Remove "structuring" comments.
3606         (tui_cmd_window::clear_detail)
3607         (tui_cmd_window::do_make_visible_with_new_height)
3608         (tui_cmd_window::max_height): Move from elsewhere.
3609
3610 2019-07-17  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3613         Now static.
3614         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3615         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3616
3617 2019-07-17  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui.c: Update.
3620         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3621         tui-regs.c.
3622         * tui/tui-windata.h: Remove file.
3623         * tui/tui-windata.c: Remove file.
3624         * tui/tui-win.c (tui_data_window::set_new_height)
3625         (tui_data_window::do_make_visible_with_new_height): Move to
3626         tui-regs.c.
3627         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3628         * tui/tui-regs.c: Remove "structuring" comments.
3629         (tui_data_window::first_data_item_displayed)
3630         (tui_data_window::delete_data_content_windows)
3631         (tui_data_window::erase_data_content)
3632         (tui_data_window::display_all_data)
3633         (tui_data_window::refresh_all)
3634         (tui_data_window::do_scroll_vertical)
3635         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3636         (tui_data_window::do_make_visible_with_new_height)
3637         (tui_data_window::refresh_window): Move from elsewhere.
3638         (_initialize_tui_regs): Move to end of file.
3639         * tui/tui-layout.c: Update.
3640         * tui/tui-hooks.c: Update.
3641         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3642         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3643         tui-regs.c.
3644         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3645
3646 2019-07-17  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3649         seen.
3650
3651 2019-07-17  Tom Tromey  <tom@tromey.com>
3652
3653         * tui/tui-win.c (tui_source_window_base::set_new_height)
3654         (tui_source_window_base::do_make_visible_with_new_height): Use
3655         m_has_locator field directly.
3656         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3657         method.
3658         (struct tui_source_window_base) <has_locator>: Likewise.
3659
3660 2019-07-17  Tom Tromey  <tom@tromey.com>
3661
3662         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3663         Don't declare.
3664         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3665         Remove.
3666         * tui/tui-win.c (tui_source_window_base::set_new_height)
3667         (tui_source_window_base::set_new_height)
3668         (make_invisible_and_set_new_height)
3669         (tui_source_window_base::do_make_visible_with_new_height)
3670         (tui_source_window_base::do_make_visible_with_new_height):
3671         Update.
3672         * tui/tui-layout.c (show_source_disasm_command, show_data)
3673         (show_source_or_disasm_and_command): Update.
3674         * tui/tui-layout.c (show_layout): Update.
3675
3676 2019-07-17  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-layout.c (make_data_window): Remove.
3679         (show_data): Unify creation and re-initialization cases.
3680
3681 2019-07-17  Tom Tromey  <tom@tromey.com>
3682
3683         * tui/tui-layout.c (make_source_window, make_disasm_window):
3684         Remove.
3685         (show_data): Unify creation and re-initialization cases.
3686
3687 2019-07-17  Tom Tromey  <tom@tromey.com>
3688
3689         * tui/tui-layout.c (make_command_window): Remove.
3690         (show_source_disasm_command, show_source_or_disasm_and_command):
3691         Unify creation and re-initialization cases.
3692
3693 2019-07-17  Tom Tromey  <tom@tromey.com>
3694
3695         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3696         creation and re-initialization cases.
3697
3698 2019-07-17  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-regs.c (tui_get_register): Return void.
3701
3702 2019-07-17  Tom Tromey  <tom@tromey.com>
3703
3704         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3705         Simplify.
3706
3707 2019-07-17  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3710         resetting.
3711
3712 2019-07-17  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3715         * tui/tui-regs.c (tui_reg_layout): New function.
3716         (tui_show_registers, tui_reg_command): Use it.
3717         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3718         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3719         parameters.
3720         (tui_layout_command): Remove.
3721
3722 2019-07-17  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-layout.h (tui/tui-layout): Return void.
3725         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3726
3727 2019-07-17  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-layout.c (show_source_disasm_command, show_data):
3730         Update.
3731         (reset_locator): Remove.
3732         (show_source_or_disasm_and_command): Update.
3733
3734 2019-07-17  Tom Tromey  <tom@tromey.com>
3735
3736         * tui/tui-source.c (tui_source_window_base::reset): Remove
3737         win_type parameter.
3738         * tui/tui-layout.c (make_command_window, make_source_window)
3739         (make_disasm_window, make_data_window)
3740         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3741         (reset_locator, show_source_or_disasm_and_command): Update.
3742         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3743         win_type parameter.
3744         (struct tui_source_window_base) <reset>: Likewise.
3745
3746 2019-07-17  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-layout.c (show_source_disasm_command): Use
3749         reset_locator.
3750         (reset_locator): New function.
3751         (init_and_make_win): Remove.
3752         (show_source_or_disasm_and_command): Use reset_locator.
3753
3754 2019-07-17  Tom Tromey  <tom@tromey.com>
3755
3756         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3757         condition.
3758         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3759         Remove condition.
3760         * tui/tui-source.c (tui_source_window_base::reset): New method.
3761         * tui/tui-layout.c (make_command_window): Don't call
3762         init_and_make_win.
3763         (make_source_window, make_disasm_window): Don't call
3764         make_source_or_disasm_window.
3765         (make_data_window): Don't call init_and_make_win.  Change calling
3766         convention.
3767         (show_source_disasm_command, show_data): Simplify.
3768         (make_source_or_disasm_window): Remove.
3769         (show_source_or_disasm_and_command): Simplify.
3770         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3771         (struct tui_source_window_base) <reset>: Likewise.
3772         <execution_info>: Remove initializer.
3773         * tui/tui-data.c (tui_source_window_base): Initialize
3774         execution_info.
3775
3776 2019-07-17  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3779         variable.
3780
3781 2019-07-17  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui.c (tui_rl_other_window): Update.
3784         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3785         superclass method first.  Always iterate over regs_content.
3786         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3787         method.
3788         * tui/tui-win.c (tui_set_focus_command): Update.
3789
3790 2019-07-17  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-win.c (tui_set_focus_command): Rename from
3793         tui_set_focus.  Call tui_enable.
3794         (tui_set_focus_command): Remove.
3795
3796 2019-07-17  Tom Tromey  <tom@tromey.com>
3797
3798         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3799         refresh_window.
3800         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3801         touchwin.
3802         (tui_data_window::refresh_window): Call refresh_window on data
3803         items.  Always call superclass refresh_window.
3804         (tui_win_info::refresh): Remove.
3805         (tui_source_window_base::refresh_window): Update.
3806         (tui_refresh_all): Update.
3807         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3808         refresh_window.
3809         (show_source_or_disasm_and_command): Likewise.
3810         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3811         (struct tui_source_window_base) <refresh>: Likewise.
3812
3813 2019-07-17  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-winsource.c (tui_clear_source_content)
3816         (tui_show_source_content): Update.
3817         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3818         whether content is empty.
3819         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3820         Remove.
3821
3822 2019-07-17  Tom Tromey  <tom@tromey.com>
3823
3824         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3825         window's contents.
3826         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3827         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3828
3829 2019-07-17  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3832         (struct tui_data_item_window): Update.
3833
3834 2019-07-17  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3837         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3838         defines.
3839
3840 2019-07-17  Tom Tromey  <tom@tromey.com>
3841
3842         * tui/tui-winsource.h (tui_erase_source_content)
3843         (tui_clear_source_content): Remove "display_prompt" parameter.
3844         * tui/tui-winsource.c (tui_update_source_window_as_is)
3845         (tui_update_source_windows_with_addr): Update.
3846         (tui_clear_source_content): Remove "display_prompt" parameter.
3847         (tui_erase_source_content): Likewise.  Simplify.
3848         (tui_show_source_content): Update.
3849         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3850         * tui/tui-stack.c (tui_show_frame_info): Update.
3851         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3852         Remove defines.
3853
3854 2019-07-17  Tom Tromey  <tom@tromey.com>
3855
3856         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3857         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3858         parameter.
3859         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3860         parameter.
3861
3862 2019-07-17  Tom Tromey  <tom@tromey.com>
3863
3864         * tui/tui-winsource.c (tui_clear_source_content)
3865         (tui_show_source_content, tui_show_exec_info_content)
3866         (tui_clear_exec_info_content): Update.
3867         * tui/tui-stack.c (tui_show_locator_content): Update.
3868         (tui_show_frame_info): Update.
3869         * tui/tui-source.h (tui_source_window): Don't declare.
3870         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3871         from tui_source_is_displayed.
3872         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3873         Remove field.
3874         (struct tui_source_window_base) <content_in_use>: New field.  Now
3875         bool.
3876         (struct tui_source_window) <showing_source_p>: New method.
3877         (TUI_SRC_WIN): Change cast.
3878         * tui/tui-data.c (tui_initialize_static_data): Update.
3879
3880 2019-07-17  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3883         location_matches_p.
3884         * tui/tui-source.c (tui_source_window::location_matches_p): New
3885         method.
3886         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3887         method.
3888         * tui/tui-data.h (struct tui_source_window_base)
3889         <location_matches_p>: New method.
3890         (struct tui_source_window, struct tui_disasm_window)
3891         <location_matches_p>: Likewise.
3892
3893 2019-07-17  Tom Tromey  <tom@tromey.com>
3894
3895         * tui/tui-win.c (tui_set_win_height_command): Rename from
3896         tui_set_win_height.
3897         (tui_set_win_height_command): Remove.
3898
3899 2019-07-17  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-source.c (tui_source_window): New constructor.  Add
3902         observer.
3903         (~tui_source_window): New destructor.
3904         (tui_source_window::style_changed): New method.
3905         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3906         (tui_attach_detach_observers): Update.
3907         * tui/tui-data.h (struct tui_source_window): Make constructor not
3908         inline.  Add destructor.
3909         (struct tui_source_window) <style_changed>: New method.
3910         <m_observable>: New member.
3911
3912 2019-07-17  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3915         * tui/tui-win.c (tui_resize_all): Fix typo.
3916
3917 2019-07-17  Tom Tromey  <tom@tromey.com>
3918
3919         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3920         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3921         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3922         * tui/tui-win.c (window_name_completer): Use foreach.
3923         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3924         (update_tab_width): Likewise.
3925         * tui/tui-layout.c (show_layout): Update.
3926         * tui/tui-data.h (class tui_window_iterator): New.
3927         (struct all_tui_windows): New.
3928         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3929
3930 2019-07-17  Tom Tromey  <tom@tromey.com>
3931
3932         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3933         parameter.  Don't reference globals.
3934         (tui_reg_command): Update.
3935
3936 2019-07-17  Tom Tromey  <tom@tromey.com>
3937
3938         * tui/tui-regs.c (tui_show_registers): Simplify.
3939
3940 2019-07-17  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-regs.c (tui_show_registers): Update.
3943         (tui_show_register_group): Add win_info parameter.
3944
3945 2019-07-17  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3948         Rename from tui_display_reg_element_at_line.
3949         (tui_data_window::display_registers_from_line): Update.
3950         * tui/tui-data.h (struct tui_data_window)
3951         <display_reg_element_at_line>: New method.
3952
3953 2019-07-17  Tom Tromey  <tom@tromey.com>
3954
3955         * tui/tui-regs.h (tui_display_registers_from)
3956         (tui_display_registers_from_line): Don't declare.
3957         * tui/tui-windata.c (tui_data_window::display_all_data)
3958         (tui_data_window::refresh_all)
3959         (tui_data_window::do_scroll_vertical): Update.
3960         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3961         from tui_display_registers_from.
3962         (tui_display_reg_element_at_line): Update.
3963         (tui_data_window::display_registers_from_line): Rename from
3964         tui_display_registers_from_line.
3965         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3966         display_registers_from_line>: New methods.
3967
3968 2019-07-17  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3971         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3972         from tui_erase_data_content.
3973         (tui_data_window::display_all_data)
3974         (tui_data_window::refresh_all)
3975         (tui_data_window::do_scroll_vertical): Update.
3976         * tui/tui-regs.c (tui_show_registers): Update.
3977         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3978         New method.
3979
3980 2019-07-17  Tom Tromey  <tom@tromey.com>
3981
3982         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3983         declare.
3984         * tui/tui-windata.c
3985         (tui_data_window::delete_data_content_windows): Rename from
3986         tui_delete_data_content_windows.
3987         (tui_data_window::display_all_data)
3988         (tui_data_window::do_scroll_vertical): Update.
3989         * tui/tui-data.h (struct tui_data_window)
3990         <delete_data_content_windows>: New method.
3991
3992 2019-07-17  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3995         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3996
3997 2019-07-17  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4000         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4001         from tui_display_all_data.
4002         * tui/tui-win.c
4003         (tui_data_window::do_make_visible_with_new_height): Update.
4004         * tui/tui-regs.c (tui_show_registers): Update.
4005         * tui/tui-layout.c (tui_set_layout): Update.
4006         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4007         method.
4008
4009 2019-07-17  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4012         * tui/tui-windata.c (tui_display_data_from): Remove.
4013         (tui_data_window::refresh_all): Update.
4014
4015 2019-07-17  Tom Tromey  <tom@tromey.com>
4016
4017         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4018         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4019         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4020         tui_display_registers_from_line.
4021         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4022         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4023         "force_display" parameter.
4024
4025 2019-07-17  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4028         declare.
4029         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4030         Rename from tui_first_reg_element_no_inline.
4031         (tui_display_reg_element_at_line)
4032         (tui_display_registers_from_line): Update.
4033         * tui/tui-data.h (struct tui_data_window)
4034         <first_reg_element_no_inline>: New method.
4035
4036 2019-07-17  Tom Tromey  <tom@tromey.com>
4037
4038         * tui/tui-windata.c (tui_display_data_from)
4039         (tui_data_window::do_scroll_vertical): Update.
4040         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4041         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4042         Rename from tui_line_from_reg_element_no.
4043         (tui_display_registers_from_line): Update.
4044         * tui/tui-data.h (struct tui_data_window)
4045         <line_from_reg_element_no>: New method.
4046
4047 2019-07-17  Tom Tromey  <tom@tromey.com>
4048
4049         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4050         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4051         tui_last_regs_line_no.
4052         (tui_display_reg_element_at_line)
4053         (tui_display_registers_from_line): Update.
4054         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4055         method.
4056
4057 2019-07-17  Tom Tromey  <tom@tromey.com>
4058
4059         PR tui/24722:
4060         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4061         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4062         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4063         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4064         (tui_update_breakpoint_info): Likewise.
4065         * tui/tui-hooks.c (tui_event_create_breakpoint)
4066         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4067         Update.
4068
4069 2019-07-17  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4072
4073 2019-07-17  Tom Tromey  <tom@tromey.com>
4074
4075         * tui/tui-winsource.c (tui_update_source_window_as_is)
4076         (tui_update_source_windows_with_addr): Update.
4077         * tui/tui-source.h (tui_set_source_content)
4078         (tui_show_symtab_source): Add "win_info" parameter.
4079         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4080         parameter.
4081         (tui_show_symtab_source): Likewise.
4082
4083 2019-07-17  Tom Tromey  <tom@tromey.com>
4084
4085         * tui/tui-wingeneral.c
4086         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4087
4088 2019-07-17  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4091         (struct tui_cmd_window) <can_scroll>: New method.
4092         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4093         method.
4094
4095 2019-07-17  Tom Tromey  <tromey@adacore.com>
4096
4097         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4098         do_field_signed>: Rename.  Change type of "value".
4099         * ui-out.c (ui_out::field_signed): Rename from field_int.
4100         Change type of "value".
4101         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4102         type of "value".
4103         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4104         do_field_int.  Change type of "value".
4105         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4106         do_field_int.  Change type of "value".
4107         * tracepoint.c (trace_status_mi, tfind_1)
4108         (print_one_static_tracepoint_marker): Update.
4109         * thread.c (print_thread_info_1, print_selected_thread_frame):
4110         Update.
4111         * stack.c (print_frame, print_frame_info): Update.
4112         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4113         Update.
4114         * source.c (print_source_lines_base): Update.
4115         * skip.c (info_skip_command): Update.
4116         * record-btrace.c (btrace_ui_out_decode_error)
4117         (btrace_call_history_src_line): Update.
4118         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4119         Update.
4120         * progspace.c (print_program_space): Update.
4121         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4122         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4123         do_field_int.  Change type of "value".
4124         * mi/mi-out.c (mi_ui_out::do_table_begin)
4125         (mi_ui_out::do_table_header): Update.
4126         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4127         type of "value".
4128         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4129         (mi_cmd_data_list_changed_registers, output_register)
4130         (mi_cmd_data_read_memory, mi_load_progress)
4131         (mi_cmd_trace_frame_collected): Update.
4132         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4133         Update.
4134         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4135         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4136         (mi_cmd_var_list_children, varobj_update_one): Update.
4137         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4138         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4139         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4140         * inferior.c (print_inferior): Update.
4141         * gdb_bfd.c (print_one_bfd): Update.
4142         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4143         Update.
4144         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4145         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4146         do_field_int.  Change type of "value".
4147         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4148         do_field_int.  Change type of "value".
4149         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4150         (print_one_breakpoint_location, print_it_catch_fork)
4151         (print_one_catch_fork, print_it_catch_vfork)
4152         (print_one_catch_vfork, print_it_catch_solib)
4153         (print_it_catch_exec, print_it_ranged_breakpoint)
4154         (print_mention_watchpoint, print_mention_masked_watchpoint)
4155         (bkpt_print_it, update_static_tracepoint): Update.
4156         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4157         * break-catch-syscall.c (print_it_catch_syscall): Update.
4158         * ada-tasks.c (print_ada_task_info): Update.
4159         * ada-lang.c (print_it_exception, print_mention_exception):
4160         Update.
4161
4162 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         PR breakpoints/24541
4165         * gdbarch.c: Regenerate.
4166         * gdbarch.h: Regenerate.
4167         * gdbarch.sh: Adjust return type and parameter types for
4168         'stap_adjust_register'.
4169         (i386_stap_adjust_register): Adjust signature and return new
4170         register name.
4171         * stap-probe.c (stap_parse_register_operand): Adjust use of
4172         'gdbarch_stap_adjust_register'.
4173
4174 2019-07-17  Tom Tromey  <tromey@adacore.com>
4175
4176         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4177         declare VEC.
4178         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4179         std::vector.
4180         (struct s390_process_info): Add initializers.
4181         (s390_add_process): Use new.
4182         (s390_linux_nat_target::low_forget_process): Use delete.
4183         (s390_linux_nat_target::low_new_fork)
4184         (s390_linux_nat_target::stopped_by_watchpoint)
4185         (s390_linux_nat_target::low_prepare_to_resume)
4186         (s390_linux_nat_target::insert_watchpoint)
4187         (s390_linux_nat_target::insert_hw_breakpoint)
4188         (s390_linux_nat_target::remove_watchpoint)
4189         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4190
4191 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4192
4193         * aarch64-fbsd-nat.c: Include regcache.h.
4194         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4195         argument.
4196         (aarch64_fbsd_nat_target::fetch_registers)
4197         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4198         variable.
4199         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4200
4201 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4202
4203         * fbsd-nat.c: Include gdbarch.h.
4204
4205 2019-07-15  Tom Tromey  <tromey@adacore.com>
4206
4207         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4208
4209 2019-07-15  Tom Tromey  <tromey@adacore.com>
4210
4211         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4212         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4213         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4214         * cli-out.c (cli_ui_out::do_field_int): New method.
4215         * ui-out.c (ui_out::field_unsigned): New method.
4216         * symfile.c (generic_load): Use field_unsigned.
4217         (print_transfer_performance): Likewise.
4218         * record-btrace.c (ui_out_field_uint): Remove.
4219         (btrace_call_history_insn_range, btrace_call_history): Use
4220         field_unsigned.
4221         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4222         field_unsigned.
4223         * ui-out.h (class ui_out) <field_unsigned>: New method.
4224         <do_field_unsigned>: Likewise.
4225
4226 2019-07-15  Tom Tromey  <tromey@adacore.com>
4227
4228         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4229         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4230         * target.c (flash_erase_command): Use field_string.
4231         * infrun.c (print_signal_received_reason): Use field_string.
4232         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4233         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4234         field_string.
4235         * ada-tasks.c (print_ada_task_info): Use field_string.
4236
4237 2019-07-15  Tom Tromey  <tromey@adacore.com>
4238
4239         * target.c (flash_erase_command): Use field_core_addr.
4240         * symfile.c (generic_load): Use field_core_addr.
4241         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4242         Use field_core_addr.
4243         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4244         field_core_addr.
4245
4246 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4249         value if its desired type is smaller than a CORE_ADDR and signed.
4250
4251 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4254         of changes to field names, and use new is_reference field to
4255         decide if a property is a reference or not.
4256         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4257         field.
4258         (struct dwarf2_property_baton): Update header comment, rename
4259         'referenced_type' to 'property_type' and update comments.
4260         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4261         default property type, store in property baton, update to take
4262         accound of renamed field.
4263         (read_func_scope): Update call to attr_to_dynamic_prop.
4264         (read_array_type): Likewise.
4265         (dwarf2_per_cu_addr_sized_int_type): New function.
4266         (read_subrange_index_type): Move type finding code to
4267         dwarf2_per_cu_addr_sized_int_type.
4268         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4269         (dwarf2_per_cu_addr_type): New function.
4270         (set_die_type): Update calls to attr_to_dynamic_prop.
4271
4272 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4273
4274         * dwarf2read.c (read_subrange_index_type): New function.
4275         (read_subrange_type): Move code into new function and call it.
4276         * gdbtypes.c (create_range_type): Add some asserts.
4277
4278 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4281         update return statements.
4282         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4283         declaration, and update comment to match.
4284         * gdbtypes.c (resolve_dynamic_array): Update call to
4285         dwarf2_evaluate_property to match new return type.
4286
4287 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4288
4289         * valarith.c (value_subscripted_rvalue): Change lowerbound
4290         parameter type from int to LONGEST.
4291         * value.h (value_subscripted_rvalue): Likewise in declaration.
4292
4293 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4294
4295         * cli/cli-utils.c (info_print_command_completer): New function.
4296         * cli/cli-utils.h: Add 'completer.h' include, and forward
4297         declaration for 'struct cmd_list_element'.
4298         (info_print_command_completer): Declare.
4299         * stack.c (_initialize_stack): Add completer for 'info locals' and
4300         'info args'.
4301         * symtab.c (_initialize_symtab): Add completer for 'info
4302         variables' and 'info functions'.
4303         * NEWS: Mention completion for additional info commands.
4304
4305 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4306
4307         * cli/cli-utils.c (extract_info_print_args): Delete.
4308         (extract_arg_maybe_quoted): Delete.
4309         (info_print_options_defs): New variable.
4310         (make_info_print_options_def_group): New function.
4311         (extract_info_print_options): Define new function.
4312         * cli/cli-utils.h (extract_info_print_args): Delete.
4313         (struct info_print_options): New structure.
4314         (extract_info_print_options): Declare new function.
4315         * stack.c (info_locals_command): Update to use new
4316         extract_info_print_options, also add a header comment.
4317         (info_args_command): Likewise.
4318         * symtab.c (info_variables_command): Likewise.
4319         (info_functions_command): Likewise.
4320
4321 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4322
4323         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4324         to extract string arguments.
4325         * common/common-utils.c (extract_string_maybe_quoted): New function.
4326         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4327
4328 2019-07-11  Tom Tromey  <tromey@adacore.com>
4329
4330         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4331         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4332         * top.h (gdbinit): Don't declare.
4333         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4334         into...
4335         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4336         * top.c (gdb_init): Don't call init_cli_cmds.
4337         (gdbinit): Remove.
4338         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4339
4340 2019-07-11  Tom Tromey  <tromey@adacore.com>
4341
4342         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4343         after it has been moved.
4344
4345 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4346
4347         * valops.c (value_must_coerce_to_target): Change return type to
4348         bool.
4349         * value.h (value_must_coerce_to_target): Likewise.
4350
4351 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4352
4353         * breakpoint.c (is_hardware_watchpoint): Remove
4354         forward-declaration.
4355         (is_masked_watchpoint): Change return type to bool.
4356         (is_tracepoint): Likewise.
4357         (is_breakpoint): Likewise.
4358         (is_hardware_watchpoint): Likewise.
4359         (is_watchpoint): Likewise.
4360         (is_no_memory_software_watchpoint): Likewise.
4361         (is_catchpoint): Likewise.
4362         (breakpoint_1): Make FILTER parameter's return type bool.
4363         is_masked_watchpoint): Change return type to bool.
4364         (save_breakpoints): Make FILTER parameter's return type bool.
4365         * breakpoint.h (is_breakpoint): Change return type to bool.
4366         (is_watchpoint): Likewise.
4367         (is_catchpoint): Likewise.
4368         (is_tracepoint): Likewise.
4369
4370 2019-07-10  Tom Tromey  <tom@tromey.com>
4371
4372         * defs.h: Don't include gdbarch.h.
4373         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4374         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4375         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4376         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4377         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4378         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4379         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4380         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4381         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4382         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4383         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4384         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4385         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4386         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4387         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4388         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4389         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4390         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4391         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4392         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4393         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4394         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4395         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4396         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4397         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4398         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4399         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4400
4401 2019-07-10  Tom Tromey  <tromey@adacore.com>
4402
4403         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4404         * breakpoint.c (init_ada_exception_breakpoint): Register as
4405         bp_catchpoint.
4406         (print_one_breakpoint_location, print_one_breakpoint): Use
4407         is_ada_exception_catchpoint.
4408         * ada-lang.c (class ada_catchpoint_location): Pass
4409         bp_loc_software_breakpoint to bp_location constructor.
4410         (is_ada_exception_catchpoint): New function.
4411
4412 2019-07-10  Tom Tromey  <tromey@adacore.com>
4413
4414         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4415         VEC.
4416         (struct arm_exidx_entry): New method operator<.
4417         (struct arm_exidx_data) <section_maps>: Change type.
4418         (arm_exidx_data_free): Remove.
4419         (arm_exidx_data_key): Change type.  Move lower.
4420         (arm_exidx_new_objfile): Update.
4421         (arm_compare_exidx_entries): Remove.
4422         (arm_find_exidx_entry, _initialize_arm_tdep)
4423
4424 2019-07-10  Tom Tromey  <tromey@adacore.com>
4425
4426         * solib-spu.c (ocl_program_data_key): Change type.
4427         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4428         Update.
4429
4430 2019-07-10  Tom Tromey  <tromey@adacore.com>
4431
4432         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4433         (struct solib_aix_inferior_data) <library_list>: Change type.
4434         (solib_aix_inferior_data_handle): Change type.
4435         (get_solib_aix_inferior_data): Update.
4436         (solib_aix_free_library_list): Remove.
4437         (library_list_start_library): Update.
4438         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4439         return type.
4440         (solib_aix_get_library_list)
4441         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4442         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4443
4444 2019-07-10  Tom Tromey  <tromey@adacore.com>
4445
4446         * solib-dsbt.c (struct dsbt_info): Add initializers.
4447         (solib_dsbt_pspace_data): Change type.
4448         (dsbt_pspace_data_cleanup): Remove.
4449         (get_dsbt_info, _initialize_dsbt_solib): Update.
4450
4451 2019-07-10  Tom Tromey  <tromey@adacore.com>
4452
4453         * spu-tdep.c (spu_overlay_data): Change type.
4454         (spu_get_overlay_table, spu_overlay_new_objfile)
4455         (_initialize_spu_tdep): Update.
4456
4457 2019-07-10  Tom Tromey  <tromey@adacore.com>
4458
4459         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4460         destructor.
4461         (dbx_objfile_data_key): Change type and declare later.
4462         (DBX_SYMFILE_INFO): Rewrite.
4463         * dbxread.c (dbx_objfile_data_key): Change type.
4464         (dbx_symfile_init): Update.
4465         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4466         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4467         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4468
4469 2019-07-10  Tom Tromey  <tromey@adacore.com>
4470
4471         * jit.c (jit_program_space_key): Change type.  Move lower.
4472         (get_jit_program_space_data): Update.
4473         (jit_program_space_data_cleanup): Remove.
4474         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4475         Update.
4476         (struct jit_program_space_data): Add initializers.
4477
4478 2019-07-10  Tom Tromey  <tromey@adacore.com>
4479
4480         * solib-darwin.c (struct darwin_info): Add initializers.
4481         (solib_darwin_pspace_data): Change type.
4482         (darwin_pspace_data_cleanup): Remove.
4483         (get_darwin_info, _initialize_darwin_solib): Update.
4484
4485 2019-07-10  Tom Tromey  <tromey@adacore.com>
4486
4487         * remote-sim.c (struct sim_inferior_data): Add initializers,
4488         constructor, and destructor.
4489         (sim_inferior_data_key): Change type.  Move lower.
4490         (check_for_duplicate_sim_descriptor): Update.
4491         (get_sim_inferior_data): Use new.  Update.
4492         (~sim_inferior_data_cleanup): Rename from
4493         sim_inferior_data_cleanup.  Simplify.
4494         (gdbsim_close_inferior, simulator_command)
4495         (sim_command_completer, _initialize_remote_sim): Update.
4496         (next_pid, INITIAL_PID): Move earlier.
4497
4498 2019-07-10  Tom Tromey  <tromey@adacore.com>
4499
4500         * python/python-internal.h (create_thread_object): Return
4501         gdbpy_ref.
4502         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4503         * python/py-inferior.c (struct threadlist_entry): Add
4504         constructor.
4505         <thread_obj>: Now a gdbpy_ref.
4506         (thread_to_thread_object): Update.
4507         (add_thread_object): Use new.
4508         (delete_thread_object): Use delete.
4509         (infpy_threads): Update.
4510         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4511         GIL.
4512
4513 2019-07-10  Tom Tromey  <tromey@adacore.com>
4514
4515         * valops.c (value_cast): Specialize error message for Ada.
4516
4517 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4518
4519         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4520
4521 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4522
4523         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4524         bpstat_should_step): Return bool, adjust comments.
4525         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4526         bpstat_should_step): Likewise.
4527
4528 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4529
4530         * features/Makefile: Use feature target descriptions for Arm.
4531         * features/arm/arm-core.c: Generate new file.
4532         * features/arm/arm-fpa.c: Likewise.
4533         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4534         * features/arm/arm-m-profile.c: Likewise.
4535         * features/arm/arm-vfpv2.c: Likewise.
4536         * features/arm/arm-vfpv3.c: Likewise.
4537         * features/arm/xscale-iwmmxt.c: Likewise.
4538         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4539
4540 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4541
4542         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4543         ptrace earlier.
4544
4545 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4546
4547         * features/aarch64-pauth.c: Regenerate.
4548
4549 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4550
4551         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4552         bool.
4553         (bpstat_what): Use false instead of 0.
4554
4555 2019-07-09  Pedro Alves  <palves@redhat.com>
4556
4557         * break-catch-throw.c (is_exception_catchpoint): New.
4558         * breakpoint.c (print_one_breakpoint_location): New parameter
4559         'raw_loc'.  Handle it.  Use
4560         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4561         looking at the breakpoint's type.
4562         (print_one_breakpoint): If handling "maint info breakpoints", also
4563         print locations of exception catchpoints.
4564         * breakpoint.h (is_exception_catchpoint): Declare.
4565
4566 2019-07-09  Pedro Alves  <palves@redhat.com>
4567
4568         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4569         "addr" field.
4570         (allocate_location_exception_catchpoint): New.
4571         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4572         (initialize_throw_catchpoint_ops): Install
4573         allocate_location_exception_catchpoint as allocate_location
4574         method.
4575         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4576         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4577         bp_loc_other.
4578         (breakpoint_address_is_meaningful): Delete.
4579         (bl_address_is_meaningful): New.
4580         (breakpoint_locations_match): Adjust comment.
4581         (bp_location_from_bp_type): New, factored out of...
4582         (bp_location::bp_location(breakpoint *)): ... this.
4583         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4584         factored out of...
4585         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4586         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4587         breakpoint_address_is_meaningful.
4588         (bp_locations_compare): Adjust comment.
4589         (update_global_location_list): Use bl_address_is_meaningful
4590         instead of breakpoint_address_is_meaningful.
4591         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4592         explicit.
4593         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4594         * python/py-breakpoint.c (bppy_get_location): No longer check
4595         whether location is null.
4596
4597 2019-07-09  Pedro Alves  <palves@redhat.com>
4598
4599         PR c++/15468
4600         * breakpoint.c (print_one_breakpoint_location): Remove
4601         single-location assert.
4602
4603 2019-07-09  Tom Tromey  <tom@tromey.com>
4604
4605         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4606         * configure: Rebuild.
4607         * configure.ac: Change common to gdbsupport.
4608         * gdbsupport: Rename from common.
4609         * acinclude.m4: Change common to gdbsupport.
4610         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4611         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4612         gdbsupport.
4613         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4614         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4615         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4616         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4617         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4618         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4619         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4620         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4621         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4622         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4623         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4624         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4625         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4626         coff-pe-read.c, command.h, compile/compile-c-support.c,
4627         compile/compile-c.h, compile/compile-cplus-symbols.c,
4628         compile/compile-cplus-types.c, compile/compile-cplus.h,
4629         compile/compile-loc2c.c, compile/compile.c, completer.c,
4630         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4631         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4632         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4633         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4634         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4635         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4636         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4637         features/aarch64-core.c, features/aarch64-fpu.c,
4638         features/aarch64-pauth.c, features/aarch64-sve.c,
4639         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4640         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4641         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4642         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4643         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4644         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4645         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4646         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4647         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4648         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4649         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4650         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4651         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4652         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4653         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4654         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4655         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4656         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4657         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4658         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4659         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4660         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4661         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4662         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4663         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4664         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4665         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4666         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4667         minsyms.c, mips-linux-tdep.c, namespace.h,
4668         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4669         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4670         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4671         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4672         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4673         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4674         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4675         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4676         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4677         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4678         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4679         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4680         procfs.c, producer.c, progspace.h, psymtab.h,
4681         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4682         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4683         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4684         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4685         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4686         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4687         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4688         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4689         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4690         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4691         target-memory.c, target.c, target.h, target/waitstatus.c,
4692         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4693         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4694         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4695         unittests/array-view-selftests.c,
4696         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4697         unittests/common-utils-selftests.c,
4698         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4699         unittests/format_pieces-selftests.c,
4700         unittests/function-view-selftests.c,
4701         unittests/lookup_name_info-selftests.c,
4702         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4703         unittests/mkdir-recursive-selftests.c,
4704         unittests/observable-selftests.c,
4705         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4706         unittests/parse-connection-spec-selftests.c,
4707         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4708         unittests/scoped_fd-selftests.c,
4709         unittests/scoped_mmap-selftests.c,
4710         unittests/scoped_restore-selftests.c,
4711         unittests/string_view-selftests.c, unittests/style-selftests.c,
4712         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4713         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4714         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4715         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4716         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4717         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4718
4719 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4720
4721         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4722         bool value.
4723         (decode_digits_ordinary): Set explicit_line field in sal.
4724         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4725         symtab_and_line that was set on an explicit line number in
4726         assembler code.  Do always update the recorded symtab and line if
4727         we do skip the prologue.
4728
4729 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * breakpoint.c (set_breakpoint_location_function): Remove
4732         explicit_loc parameter.
4733         (momentary_breakpoint_from_master): Update call to
4734         set_breakpoint_location_function.
4735         (add_location_to_breakpoint): Likewise.
4736
4737 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4740         required features based on default bfd type when no specific bfd
4741         is present.
4742
4743 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4744
4745         * NEWS: Mention that GDB printf and eval commands can now print
4746         C-style and Ada-style convenience var strings without
4747         calling the inferior.
4748         * printcmd.c (printf_c_string): Locally print GDB internal var
4749         instead of transiting via the inferior.
4750         (printf_wide_c_string): Likewise.
4751
4752 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4753
4754         PR breakpoints/25011
4755         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4756
4757 2019-07-04  Tom Tromey  <tom@tromey.com>
4758
4759         PR tui/24724:
4760         * tui/tui-winsource.c (tui_clear_source_content): Update.
4761         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4762         (tui_update_breakpoint_info): Update.
4763         (tui_set_exec_info_content): Update.
4764         * tui/tui-source.c (tui_set_source_content_nil): Update.
4765         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4766         has_break.
4767         * tui/tui-data.h (enum tui_bp_flag): New.
4768         (tui_bp_flags): New enum flags type.
4769         (struct tui_source_element) <break_mode>: Change type.  Rename
4770         from has_break.
4771         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4772         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4773         constants.
4774         * tui/tui-winsource.h: Fix comment.
4775
4776 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4777
4778         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4779         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4780         (store_fpregs_to_thread)
4781         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4782         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4783         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4784         (IWMMXT_REGS_SIZE): Add define.
4785         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4786         (fetch_vfp_regs, store_vfp_regs)
4787         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4788         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4789
4790 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4791
4792         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4793         defines.
4794         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4795         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4796         (ARM_INT_REGISTER_SIZE): ...to this.
4797         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4798         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4799         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4800         (arm_linux_collect_gregset, supply_nwfpe_register)
4801         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4802         defines.
4803         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4804         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4805         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4806         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4807         (arm_return_in_memory, arm_store_return_value)
4808         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4809         (arm_record_ld_st_multiple): Likewise.
4810         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4811         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4812
4813 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4814
4815         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4816         AARCH64_DISPLACED_MODIFIED_INSNS.
4817         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4818         (aarch64_displaced_step_copy_insn): Likewise.
4819         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4820         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4821         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4822         ARM_DISPLACED_MODIFIED_INSNS.
4823         * arm-tdep.c (arm_gdbarch_init): Likewise.
4824         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4825         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4826         (struct arm_displaced_step_closure): Use
4827         ARM_DISPLACED_MODIFIED_INSNS.
4828
4829 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4830
4831         * features/Makefile: Remove unused xml files.
4832         * features/aarch64.xml: Remove.
4833         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4834         * features/i386/amd64-avx-avx512.xml: Remove.
4835         * features/i386/amd64-avx-linux.xml: Remove.
4836         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4837         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4838         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4839         * features/i386/amd64-avx-mpx.xml: Remove.
4840         * features/i386/amd64-avx.xml: Remove.
4841         * features/i386/amd64-linux.xml: Remove.
4842         * features/i386/amd64-mpx-linux.xml: Remove.
4843         * features/i386/amd64-mpx.xml: Remove.
4844         * features/i386/amd64.xml: Remove.
4845         * features/i386/i386-avx-avx512-linux.xml: Remove.
4846         * features/i386/i386-avx-avx512.xml: Remove.
4847         * features/i386/i386-avx-linux.xml: Remove.
4848         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4849         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4850         * features/i386/i386-avx-mpx-linux.xml: Remove.
4851         * features/i386/i386-avx-mpx.xml: Remove.
4852         * features/i386/i386-avx.xml: Remove.
4853         * features/i386/i386-linux.xml: Remove.
4854         * features/i386/i386-mmx-linux.xml: Remove.
4855         * features/i386/i386-mmx.xml: Remove.
4856         * features/i386/i386-mpx-linux.xml: Remove.
4857         * features/i386/i386-mpx.xml: Remove.
4858         * features/i386/i386.xml: Remove.
4859         * features/i386/x32-avx-avx512-linux.xml: Remove.
4860         * features/i386/x32-avx-linux.xml: Remove.
4861         * features/i386/x32-linux.xml: Remove.
4862
4863 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4864
4865         * regformats/aarch64.dat: Remove.
4866         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4867         * regformats/i386/amd64-avx-linux.dat: Remove.
4868         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4869         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4870         * regformats/i386/amd64-linux.dat: Remove.
4871         * regformats/i386/amd64-mpx-linux.dat: Remove.
4872         * regformats/i386/amd64.dat: Remove.
4873         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4874         * regformats/i386/i386-avx-linux.dat: Remove.
4875         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4876         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4877         * regformats/i386/i386-linux.dat: Remove.
4878         * regformats/i386/i386-mmx-linux.dat: Remove.
4879         * regformats/i386/i386-mpx-linux.dat: Remove.
4880         * regformats/i386/i386.dat: Remove.
4881         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4882         * regformats/i386/x32-avx-linux.dat: Remove.
4883         * regformats/i386/x32-linux.dat: Remove.
4884
4885 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4886
4887         * aarch64-tdep.c: Remove xml self tests.
4888         * amd64-linux-tdep.c: Likewise.
4889         * amd64-tdep.c: Likewise.
4890         * i386-linux-tdep.c: Likewise.
4891         * i386-tdep.c: Likewise.
4892
4893 2019-07-03  Pedro Alves  <palves@redhat.com>
4894
4895         PR cli/24732
4896         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4897         (pipe_cmd_option_defs): New.
4898         (make_pipe_cmd_options_def_group): New.
4899         (pipe_command): Use gdb::option::process_options.
4900         (pipe_command_completer): New function.
4901         (_initialize_cli_cmds): Install completer for "pipe" command.
4902
4903 2019-07-03  Pedro Alves  <palves@redhat.com>
4904
4905         * cli/cli-option.c (union option_value) <string>: New field.
4906         (struct option_def_and_value): Add ctor, move ctor, dtor and
4907         use DISABLE_COPY_AND_ASSIGN.
4908         (option_def_and_value::clear_value): New.
4909         (parse_option, save_option_value_in_ctx, get_val_type_str)
4910         (add_setshow_cmds_for_options): Handle var_string.
4911         * cli-option.h (union option_def::var_address) <string>: New
4912         field.
4913         (struct string_option_def): New.
4914         * maint-test-options.c (struct test_options_opts): Add default
4915         ctor and use DISABLE_COPY_AND_ASSIGN.
4916         <string_opt>: New field.
4917         (test_options_opts::~test_options_opts): New.
4918         (test_options_opts::dump): Also dump "-string".
4919         (test_options_option_defs): Install "string.
4920
4921 2019-07-03  Pedro Alves  <palves@redhat.com>
4922
4923         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4924         option_value with a null enumeration.
4925         (complete_options): Save the option values in the context.
4926         (save_option_value_in_ctx): New, factored out from ...
4927         (process_options): ... here.
4928         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4929         of the function.
4930         * maint-test-options.c (test_options_opts::dump): New, factored
4931         out from ...
4932         (maintenance_test_options_command_mode): ... here.
4933         (maintenance_test_options_command_completion_result): Delete.
4934         (maintenance_test_options_command_completion_text): Update
4935         comment.
4936         (maintenance_show_test_options_completion_result): Change
4937         prototype.  Just print
4938         maintenance_test_options_command_completion_text.
4939         (save_completion_result): New.
4940         (maintenance_test_options_completer_mode): Pass options context to
4941         complete_options, and then save a dump.
4942         (_initialize_maint_test_options): Use add_cmd to install "maint
4943         show test-options-completion-result".
4944
4945 2019-07-03  Pedro Alves  <palves@redhat.com>
4946
4947         * NEWS (New commands): Mention "with" and "maint with".
4948         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4949         (with_command, with_command_completer): New.
4950         (pipe_command): Adjust to new repeat_previous
4951         interface.
4952         (_initialize_cli_cmds): Install the "with" command and its "w"
4953         alias.
4954         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4955         declarations.
4956         * cli/cli-setshow.c (parse_cli_var_uinteger)
4957         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4958         argument strings for all var_types.
4959         (get_setshow_command_value_string): New, factored out from ...
4960         (do_show_command): ... this.
4961         * cli/cli-setshow.h: Include <string>.
4962         (get_setshow_command_value_string): Declare.
4963         * command.h (repeat_previous): Now returns const char *.  Adjust
4964         comment.
4965         * maint.c: Include "cli/cli-cmds.h".
4966         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4967         (_initialize_maint_cmds): Register the "maintenance with" command.
4968         * top.c (repeat_previous): Move bits from pipe_command here:
4969         Return the saved command line, if any; error out if there's no
4970         command to relaunch.
4971
4972 2019-07-03  Pedro Alves  <palves@redhat.com>
4973
4974         * NEWS (New commands): Mention "maint set/show test-settings"
4975         instead of "maint test-settings".
4976         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4977         (maintenance_test_settings_set_list): Rename to ...
4978         (maintenance_set_test_settings_list): ... this.
4979         (maintenance_test_settings_show_list): Rename to  ...
4980         (maintenance_show_test_settings_list): ... this.
4981         (maintenance_test_settings_cmd): Delete.
4982         (maintenance_test_settings_set_cmd): ...
4983         (maintenance_set_test_settings_cmd): ... this.
4984         (maintenance_test_settings_show_cmd): ...
4985         (maintenance_show_test_settings_cmd): ... this.
4986         (maintenance_test_settings_show_value_cmd):
4987         (maintenance_show_test_settings_value_cmd): ... this.
4988         (_initialize_maint_test_settings): No longer install the "maint
4989         test-settings" prefix command.  Rename "maint test-settings set"
4990         to "maint set test-settings", and "maint test-settings show" to
4991         "maint show test-settings".  Adjust all subcommands.
4992
4993 2019-07-03  Pedro Alves  <palves@redhat.com>
4994
4995         * maint-test-settings.c: Fix file's intro comment.  Replace all
4996         references to "test-options" with references to "test-settings",
4997         in comments.
4998
4999 2019-07-03  Pedro Alves  <palves@redhat.com>
5000
5001         * maint-test-settings.c (maintenance_test_settings_xxx)
5002         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5003         New.
5004         (maintenance_test_settings_enums): Use them.
5005         (maintenance_test_settings_enum): Default to
5006         maintenance_test_settings_xxx.
5007         (_initialize_maint_test_settings): Initialize
5008         MAINTENANCE_TEST_SETTINGS_FILENAME.
5009
5010 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5011
5012         * breakpoint.h (remove_breakpoints_inf): Change return type to
5013         void, move function documentation here.
5014         * breakpoint.c (remove_breakpoints_inf): Change return type to
5015         void, move function documentation to header.
5016
5017 2019-07-02  Pedro Alves  <palves@redhat.com>
5018
5019         * NEWS (Completion improvements): Mention "info threads".
5020         * thread.c (struct info_threads_opts, info_threads_option_defs)
5021         (make_info_threads_options_def_group): New.
5022         (info_threads_command): Use gdb::option::process_options.
5023         (info_threads_command_completer): New.
5024         (_initialize_thread): Use gdb::option::build_help to build the
5025         help text for "info threads".
5026
5027 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5028
5029         * defs.h (generic_load): Move from here...
5030         * symfile.h (generic_load): ... to here.  Rename name parameter
5031         to args.
5032         * symfile.c (generic_load): Add comment.
5033
5034 2019-07-01  Tom Tromey  <tromey@adacore.com>
5035
5036         * dwarf2read.c
5037         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5038         declaration of without_params.  Fix formatting.
5039
5040 2019-07-01  Tom Tromey  <tromey@adacore.com>
5041
5042         * ada-exp.y (find_primitive_type): Update.
5043         * ada-lang.h (ada_lookup_symbol): Update.
5044         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5045         parameter.
5046         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5047
5048 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5049
5050         PR breakpoints/24541
5051         * gdbarch.c: Regenerate.
5052         * gdbarch.h: Regenerate.
5053         * gdbarch.sh: Add 'stap_adjust_register'.
5054         * i386-tdep.c: Include '<unordered_set>'.
5055         (i386_stap_adjust_register): New function.
5056         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5057         * stap-probe.c (stap_parse_register_operand): Call
5058         'gdbarch_stap_adjust_register'.
5059
5060 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5061
5062         PR python/24742
5063         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5064         * python/python.c (do_start_initialization): Use 'xmalloc'
5065         instead of 'PyMem_Malloc'.
5066
5067 2019-06-28  Tom Tromey  <tromey@adacore.com>
5068
5069         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5070         for Ada.
5071
5072 2019-06-27  Tom Tromey  <tromey@adacore.com>
5073
5074         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5075         objfile_key.
5076         (arm_find_mapping_symbol, arm_record_special_symbol)
5077         (_initialize_arm_tdep): Update.
5078         (arm_objfile_data_free): Remove.
5079
5080 2019-06-27  Tom Tromey  <tromey@adacore.com>
5081
5082         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5083         to cp_print_static_field.
5084
5085 2019-06-26  Tom Tromey  <tromey@adacore.com>
5086
5087         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5088         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5089         declare.
5090
5091 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5092
5093         * features/aarch64-core.c (create_feature_aarch64_core):
5094         Regenerate.
5095         * features/aarch64-core.xml: Add cpsr flags.
5096
5097 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5098
5099         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5100         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5101
5102 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5103
5104         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5105         field.
5106         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5107         use.
5108         (arm_record_special_symbol): Don't insert new symbol in sorted
5109         position, push it at the end.
5110
5111 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5112
5113         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5114         (arm_mapping_symbol_s): Remove.
5115         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5116         (arm_mapping_symbol_vec): New typedef.
5117         (struct arm_per_objfile): Add constructor.
5118         <section_maps>: Change type to
5119         std::unique_ptr<arm_mapping_symbol_vec[]>.
5120         (arm_compare_mapping_symbols): Remove.
5121         (arm_find_mapping_symbol): Adjust to section_maps type change.
5122         (arm_objfile_data_free): Call delete on arm_per_objfile.
5123         (arm_record_special_symbol): Adjust to section_maps type change.
5124         Allocate arm_per_objfile with new.
5125
5126 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5127
5128         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5129         with the command prefix.
5130
5131 2019-06-25  Tom Tromey  <tom@tromey.com>
5132
5133         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5134         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5135
5136 2019-06-25  Tom Tromey  <tom@tromey.com>
5137
5138         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5139         type.
5140         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5141         protected.
5142
5143 2019-06-25  Tom Tromey  <tom@tromey.com>
5144
5145         * tui/tui-winsource.c
5146         (tui_source_window_base::set_is_exec_point_at): Add check against
5147         LOA_ADDRESS.
5148
5149 2019-06-25  Tom Tromey  <tom@tromey.com>
5150
5151         * tui/tui-source.c (tui_set_source_content): Don't check before
5152         xfree.
5153         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5154
5155 2019-06-25  Tom Tromey  <tom@tromey.com>
5156
5157         * tui/tui-winsource.h (tui_update_source_window_as_is)
5158         (tui_alloc_source_buffer, tui_line_is_displayed)
5159         (tui_addr_is_displayed): Change type of win_info.
5160         * tui/tui-winsource.c (tui_update_source_window_as_is)
5161         (tui_clear_source_content, tui_show_source_line)
5162         (tui_show_source_content, tui_source_window_base::refill)
5163         (tui_source_window_base::set_is_exec_point_at)
5164         (tui_source_window_base::set_is_exec_point_at)
5165         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5166         (tui_alloc_source_buffer, tui_line_is_displayed)
5167         (tui_addr_is_displayed): Change type of win_info.  Update.
5168         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5169         (tui_source_window_base::do_make_visible_with_new_height):
5170         Update.
5171         * tui/tui-source.c (tui_set_source_content)
5172         (tui_set_source_content_nil)
5173         (tui_source_window::do_scroll_vertical): Update.
5174         * tui/tui-layout.c (show_layout): Update.
5175         * tui/tui-disasm.c (tui_set_disassem_content)
5176         (tui_disasm_window::do_scroll_vertical): Update.
5177         * tui/tui-data.h (tui_win_content): Remove.
5178         (struct tui_gen_win_info) <content, content_size>: Remove.
5179         (struct tui_source_element): Add initializers and destructor.
5180         (union tui_which_element, struct tui_win_element): Remove.
5181         (struct tui_source_window_base) <content>: New field.
5182         (struct tui_data_window): Remove destructor.
5183         (tui_alloc_content, tui_free_win_content)
5184         (tui_free_all_source_wins_content): Don't declare.
5185         * tui/tui-data.c (tui_initialize_static_data): Update.
5186         (init_content_element, tui_alloc_content): Remove.
5187         (~tui_gen_win_info): Update.
5188         (~tui_data_window, tui_free_all_source_wins_content)
5189         (tui_free_win_content, free_content, free_content_elements):
5190         Remove.
5191
5192 2019-06-25  Tom Tromey  <tom@tromey.com>
5193
5194         * tui/tui-winsource.h (tui_clear_source_content)
5195         (tui_erase_source_content, tui_show_source_content): Change type
5196         of win_info.
5197         * tui/tui-winsource.c (tui_clear_source_content)
5198         (tui_erase_source_content, tui_show_source_content): Change type
5199         of win_info.
5200         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5201         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5202         win_info.
5203         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5204         win_info.
5205         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5206
5207 2019-06-25  Tom Tromey  <tom@tromey.com>
5208
5209         * tui/tui-winsource.c (tui_clear_source_content)
5210         (tui_source_window_base::set_is_exec_point_at): Update.
5211         * tui/tui-source.c (tui_set_source_content_nil): Update.
5212         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5213         a bool.
5214         * tui/tui-data.c (init_content_element): Update.
5215
5216 2019-06-25  Tom Tromey  <tom@tromey.com>
5217
5218         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5219         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5220         * tui/tui-layout.c (init_and_make_win): Update.
5221         * tui/tui.h (enum tui_win_type): Update.
5222         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5223         tui_win_is_auxillary.
5224         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5225         tui_win_is_auxillary.
5226
5227 2019-06-25  Tom Tromey  <tom@tromey.com>
5228
5229         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5230         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5231         (tui_delete_data_content_windows, tui_display_all_data)
5232         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5233         Update.
5234         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5235         * tui/tui-regs.c (tui_last_regs_line_no)
5236         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5237         (tui_show_registers): Update.
5238         (tui_show_register_group): Return void.  Update.
5239         (tui_display_registers_from, tui_display_reg_element_at_line)
5240         (tui_display_registers_from_line, tui_check_register_values):
5241         Update.
5242         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5243         member.
5244         (struct tui_data_window) <regs_content>: Now a std::vector.
5245         <regs_content_count>: Remove.
5246         (tui_add_content_elements, tui_free_data_content): Don't declare.
5247         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5248         (init_content_element): Remove DATA_WIN case.  Add assert.
5249         (tui_add_content_elements): Remove.
5250         (tui_data_window): Update.
5251         (tui_free_data_content): Remove.
5252         (free_content_elements): Remove DATA_WIN case.
5253
5254 2019-06-25  Tom Tromey  <tom@tromey.com>
5255
5256         * tui/tui-data.c (tui_data_item_window): Update.
5257         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5258         * tui/tui-windata.c (tui_display_all_data)
5259         (tui_display_data_from_line): Update.
5260         (tui_check_data_values): Remove.
5261         * tui/tui-regs.c (tui_show_register_group)
5262         (tui_display_reg_element_at_line): Update.
5263         * tui/tui-hooks.c (tui_register_changed)
5264         (tui_refresh_frame_and_register_information): Call
5265         tui_check_register_values.
5266         * tui/tui-data.h (struct tui_data_window) <data_content,
5267         data_content_count, data_type>: Remove.
5268         (enum tui_data_type): Remove.
5269
5270         * tui/tui-data.c (tui_data_window::clear_detail)
5271         (~tui_data_window): Update.
5272
5273 2019-06-25  Tom Tromey  <tom@tromey.com>
5274
5275         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5276         declare.
5277         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5278         Rename from tui_first_data_item_displayed.  Update.
5279         (tui_data_window::refresh_all)
5280         (tui_data_window::do_scroll_vertical): Update.
5281         * tui/tui-data.h (struct tui_data_window)
5282         <first_data_item_displayed>: Declare new method.
5283
5284 2019-06-25  Tom Tromey  <tom@tromey.com>
5285
5286         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5287         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5288         contents...
5289         (tui_initialize_static_data): ...here.
5290
5291 2019-06-25  Tom Tromey  <tom@tromey.com>
5292
5293         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5294         (tui_display_registers_from, tui_check_register_values): Update.
5295         (tui_display_register): Remove win_info parameter; update.
5296         (tui_get_register): Change type of parameters.
5297         * tui/tui-data.h (struct tui_data_element): Remove.
5298         (union tui_which_element) <data>: Remove.
5299         <data_window>: Change type.
5300         (struct tui_data_item_window): New.
5301         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5302         case.  Add assert.
5303         (~tui_data_item_window): New destructor.
5304         (free_content_elements): Remove DATA_ITEM_WIN case.
5305
5306 2019-06-25  Tom Tromey  <tom@tromey.com>
5307
5308         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5309         Remove.
5310
5311 2019-06-25  Tom Tromey  <tom@tromey.com>
5312
5313         * tui/tui-data.h (struct tui_command_element): Remove.
5314         (union tui_which_element) <command>: Remove.
5315         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5316         assert.
5317         (free_content_elements): Remove CMD_WIN case.
5318
5319 2019-06-25  Tom Tromey  <tom@tromey.com>
5320
5321         * tui/tui-layout.c (tui_set_layout): Update.
5322         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5323         * tui/tui-data.c (layout_def): Update.
5324
5325 2019-06-25  Tom Tromey  <tom@tromey.com>
5326
5327         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5328         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5329         (tui_source_window_base::set_new_height): Update.
5330         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5331         Update.
5332         (tui_set_locator_fullname, tui_set_locator_info)
5333         (tui_show_frame_info): Update.
5334         * tui/tui-source.c (tui_set_source_content)
5335         (tui_source_is_displayed): Update.
5336         * tui/tui-layout.c (show_source_disasm_command, show_data)
5337         (show_source_or_disasm_and_command): Update.
5338         * tui/tui-disasm.c (tui_set_disassem_content)
5339         (tui_get_begin_asm_address): Update.
5340         * tui/tui-data.h (struct tui_locator_element): Remove.
5341         (union tui_which_element) <locator>: Remove.
5342         (struct tui_locator_window): New.
5343         (tui_locator_win_info_ptr): Change return type.
5344         * tui/tui-data.c (_locator): Change type.
5345         (tui_locator_win_info_ptr): Change return type.
5346         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5347         (tui_alloc_content): Add assert.
5348
5349 2019-06-25  Tom Tromey  <tom@tromey.com>
5350
5351         * tui/tui-winsource.c
5352         (tui_exec_info_window::maybe_allocate_content): New method.
5353         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5354         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5355         (make_source_or_disasm_window): Add cast.
5356         * tui/tui-data.h (union tui_which_element) <simple_string>:
5357         Remove.
5358         (struct tui_source_info): New.
5359         (struct tui_source_window_base) <execution_info>: Change type.
5360         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5361         case, and add assert.
5362         (tui_alloc_content): Add assert.
5363
5364 2019-06-25  Tom Tromey  <tom@tromey.com>
5365
5366         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5367         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5368         * tui/tui-data.c (tui_alloc_win_info): Remove.
5369
5370 2019-06-25  Tom Tromey  <tom@tromey.com>
5371
5372         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5373         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5374         can_highlight.
5375
5376 2019-06-25  Tom Tromey  <tom@tromey.com>
5377
5378         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5379         make_visible_with_new_height method.
5380         (tui_win_info::make_visible_with_new_height): New method.
5381         (tui_source_window_base::do_make_visible_with_new_height)
5382         (tui_data_window::do_make_visible_with_new_height)
5383         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5384         (make_visible_with_new_height): Remove.
5385         (tui_resize_all, tui_adjust_win_heights): Use
5386         make_visible_with_new_height method.
5387         * tui/tui-data.h (struct tui_win_info)
5388         <do_make_visible_with_new_height, make_visible_with_new_height>:
5389         New methods.
5390         (struct tui_source_window_base, struct tui_data_window)
5391         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5392         methods.
5393
5394 2019-06-25  Tom Tromey  <tom@tromey.com>
5395
5396         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5397         method.
5398         (update_tab_width): Call update_tab_width method.
5399         * tui/tui-data.h (struct tui_win_info)
5400         (struct tui_source_window_base) <update_tab_width>: New methods.
5401
5402 2019-06-25  Tom Tromey  <tom@tromey.com>
5403
5404         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5405         parameter.
5406         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5407         parameter.
5408         (tui_gen_win_info::make_visible): Update.
5409         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5410         parameter.
5411         * tui/tui-data.h (enum tui_box): New enum.
5412         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5413
5414 2019-06-25  Tom Tromey  <tom@tromey.com>
5415
5416         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5417         init_and_make_win for EXEC_INFO_WIN.
5418         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5419         longer inline.
5420         (struct tui_win_info) <~tui_win_info>: Inline.
5421         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5422         Don't declare.
5423         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5424         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5425         Remove.
5426         (tui_initialize_static_data): Update.
5427         (~tui_gen_win_info): Handle more cleanup here.
5428         (~tui_source_window_base): Delete "execution_info".
5429         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5430
5431 2019-06-25  Tom Tromey  <tom@tromey.com>
5432
5433         * tui/tui-layout.c (make_command_window): Don't set
5434         can_highlight.
5435         (show_source_disasm_command): Call the reset method.
5436         (show_data): Don't set can_highlight.  Call the reset method.
5437         (tui_gen_win_info::reset): Rename from init_gen_win_info
5438         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5439         (show_source_or_disasm_and_command): Call the reset method.
5440         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5441         (struct tui_cmd_window): Set can_highlight.
5442
5443 2019-06-25  Tom Tromey  <tom@tromey.com>
5444
5445         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5446         from make_visible.
5447         (tui_make_visible, tui_make_invisible): Rewrite.
5448         (tui_win_info::make_visible): Remove.
5449         (tui_source_window_base::make_visible): Update.
5450         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5451         method.  Moved from...
5452         (struct tui_win_info) <make_visible>: ...here.
5453
5454 2019-06-25  Tom Tromey  <tom@tromey.com>
5455
5456         * tui/tui-winsource.c
5457         (tui_source_window_base::do_scroll_horizontal): Remove direction
5458         parameter.
5459         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5460         direction parameter.
5461         * tui/tui-win.c (tui_win_info::forward_scroll)
5462         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5463         (tui_win_info::right_scroll): Update.
5464         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5465         direction parameter.
5466         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5467         direction parameter.
5468         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5469         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5470         Remove direction parameter.
5471         (struct tui_source_window_base, struct tui_source_window)
5472         (struct tui_disasm_window, struct tui_data_window)
5473         (struct tui_cmd_window): Update.
5474
5475 2019-06-25  Tom Tromey  <tom@tromey.com>
5476
5477         * tui/tui-winsource.h (tui_set_exec_info_content)
5478         (tui_show_exec_info_content, tui_erase_exec_info_content)
5479         (tui_clear_exec_info_content, tui_update_exec_info): Change
5480         argument to tui_source_window_base.
5481         * tui/tui-winsource.c (tui_set_exec_info_content)
5482         (tui_show_exec_info_content, tui_erase_exec_info_content)
5483         (tui_clear_exec_info_content, tui_update_exec_info): Change
5484         argument to tui_source_window_base.
5485
5486 2019-06-25  Tom Tromey  <tom@tromey.com>
5487
5488         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5489         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5490
5491 2019-06-25  Tom Tromey  <tom@tromey.com>
5492
5493         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5494         check.
5495
5496 2019-06-25  Tom Tromey  <tom@tromey.com>
5497
5498         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5499         type to void.
5500         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5501         type to void.
5502         * tui/tui-source.c (tui_set_source_content): Update.
5503         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5504
5505 2019-06-25  Tom Tromey  <tom@tromey.com>
5506
5507         * tui/tui-win.c (window_name_completer, tui_set_focus)
5508         (tui_all_windows_info): Use name method.
5509         * tui/tui-data.h (struct tui_gen_win_info)
5510         (struct tui_source_window, struct tui_disasm_window)
5511         (struct tui_data_window, struct tui_cmd_window) <name>: New
5512         method.
5513         (tui_win_name): Don't declare.
5514         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5515         (tui_win_name): Remove.
5516
5517 2019-06-25  Tom Tromey  <tom@tromey.com>
5518
5519         * tui/tui-winsource.h (tui_update_source_window)
5520         (tui_update_source_window_as_is): Change parameter type.
5521         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5522         to be a tui_source_window_base.
5523         (tui_update_source_window_as_is): Likewise.
5524         * tui/tui-win.c (make_visible_with_new_height): Update.
5525
5526 2019-06-25  Tom Tromey  <tom@tromey.com>
5527
5528         * tui/tui-winsource.c (tui_erase_source_content)
5529         (tui_show_source_content, tui_show_exec_info_content)
5530         (tui_erase_exec_info_content): Use refresh_window method.
5531         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5532         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5533         from tui_refresh_win.
5534         (tui_data_window::refresh_window): New method.
5535         (tui_win_info::refresh, tui_source_window_base::refresh)
5536         (tui_refresh_all): Use refresh_window method.
5537         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5538         method.
5539         * tui/tui-regs.c (tui_display_register): Call refresh_window
5540         method.
5541         * tui/tui-layout.c (show_source_disasm_command)
5542         (show_source_or_disasm_and_command): Call refresh_window method.
5543         * tui/tui-data.h (struct tui_gen_win_info)
5544         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5545         New method.
5546
5547 2019-06-25  Tom Tromey  <tom@tromey.com>
5548
5549         * tui/tui.c (tui_rl_other_window, tui_enable)
5550         (tui_is_window_visible, tui_get_command_dimension): Update.
5551         * tui/tui-winsource.c (tui_update_source_window_as_is)
5552         (tui_clear_source_content, tui_erase_source_content)
5553         (tui_show_source_line, tui_source_window_base::refill)
5554         (tui_source_window_base::do_scroll_horizontal)
5555         (tui_source_window_base::set_is_exec_point_at)
5556         (tui_update_breakpoint_info, tui_set_exec_info_content)
5557         (tui_alloc_source_buffer, tui_line_is_displayed)
5558         (tui_addr_is_displayed): Update.
5559         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5560         (tui_check_and_display_highlight_if_needed)
5561         (tui_win_info::make_visible, tui_win_info::refresh)
5562         (tui_refresh_all): Update.
5563         * tui/tui-windata.c (tui_first_data_item_displayed)
5564         (tui_delete_data_content_windows, tui_erase_data_content)
5565         (tui_display_all_data, tui_data_window::refresh_all)
5566         (tui_check_data_values): Update.
5567         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5568         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5569         (tui_win_info::backward_scroll, tui_refresh_all_win)
5570         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5571         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5572         (tui_source_window_base::set_new_height)
5573         (tui_data_window::set_new_height)
5574         (make_invisible_and_set_new_height)
5575         (make_visible_with_new_height, new_height_ok)
5576         (parse_scrolling_args): Update.
5577         * tui/tui-stack.c (tui_show_frame_info): Update.
5578         * tui/tui-source.c (tui_set_source_content)
5579         (tui_set_source_content_nil, tui_source_is_displayed)
5580         (tui_source_window::do_scroll_vertical): Update.
5581         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5582         (tui_display_registers_from, tui_display_reg_element_at_line)
5583         (tui_check_register_values, tui_reg_command): Update.
5584         * tui/tui-layout.c (tui_default_win_height)
5585         (show_source_disasm_command, show_data, init_and_make_win)
5586         (show_source_or_disasm_and_command): Update.
5587         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5588         (tui_redisplay_readline, tui_mld_flush)
5589         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5590         (tui_getc): Update.
5591         * tui/tui-disasm.c (tui_set_disassem_content)
5592         (tui_disasm_window::do_scroll_vertical): Update.
5593         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5594         Now virtual.
5595         (struct tui_win_info): Derive from tui_gen_win_info.
5596         <~tui_win_info>: Mark as override.
5597         <generic>: Remove member.
5598         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5599         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5600         (~tui_data_window, ~tui_win_info)
5601         (tui_free_all_source_wins_content): Update.
5602         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5603
5604 2019-06-25  Tom Tromey  <tom@tromey.com>
5605
5606         * tui/tui-layout.c (init_and_make_win): Use new.
5607         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5608         destructor, initializers.
5609         (tui_alloc_generic_win_info): Don't declare.
5610         * tui/tui-data.c (_locator): Add argument to constructor.
5611         (source_win, disasm_win): New globals.
5612         (exec_info): Remove.
5613         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5614         Update.
5615         (tui_alloc_generic_win_info): Remove.
5616         (init_content_element): Use new.
5617         (tui_win_info::tui_win_info): Update.
5618         (free_content_elements) <case DATA_WIN>: Use delete.
5619
5620 2019-06-25  Tom Tromey  <tom@tromey.com>
5621
5622         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5623         * tui/tui-windata.c (tui_first_data_item_displayed)
5624         (tui_delete_data_content_windows): Update.
5625         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5626         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5627         (tui_display_registers_from, tui_check_register_values): Update.
5628         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5629         pointer.
5630         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5631         window.
5632         (tui_free_data_content): Update.
5633         (free_content_elements) <case DATA_WIN>: Free the window.
5634
5635 2019-06-25  Tom Tromey  <tom@tromey.com>
5636
5637         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5638         Update.
5639         * tui/tui-layout.c (make_command_window)
5640         (show_source_disasm_command, show_data, init_and_make_win)
5641         (show_source_or_disasm_and_command): Update.
5642         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5643         method.
5644         <can_highight, is_highlighted>: Now bool.
5645         (tui_set_win_highlight): Don't declare.
5646         * tui/tui-data.c (tui_set_win_highlight): Remove.
5647
5648 2019-06-25  Tom Tromey  <tom@tromey.com>
5649
5650         * tui/tui-wingeneral.c (make_visible): Remove check of window
5651         type.
5652
5653 2019-06-25  Tom Tromey  <tom@tromey.com>
5654
5655         * tui/tui-win.c (tui_win_info::max_height)
5656         (tui_cmd_window::max_height): New methods.
5657         (new_height_ok): Call max_height.
5658         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5659         <max_height>: New method.
5660
5661 2019-06-25  Tom Tromey  <tom@tromey.com>
5662
5663         * tui/tui-win.c (tui_source_window_base::set_new_height)
5664         (tui_data_window::set_new_height): New methods.
5665         (make_invisible_and_set_new_height): Call set_new_height method.
5666         * tui/tui-data.h (struct tui_win_info)
5667         (struct tui_source_window_base, struct tui_data_window)
5668         <set_new_height>: New method.
5669
5670 2019-06-25  Tom Tromey  <tom@tromey.com>
5671
5672         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5673         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5674         tui_refresh_data_win.
5675         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5676         method.
5677         (tui_refresh_all_win): Call the refresh_all method.
5678         (tui_set_focus): Likewise.
5679         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5680         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5681         Likewise.
5682
5683 2019-06-25  Tom Tromey  <tom@tromey.com>
5684
5685         * tui/tui-winsource.h (tui_refill_source_window)
5686         (tui_set_is_exec_point_at): Don't declare.
5687         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5688         (tui_source_window_base::refill): Rename from
5689         tui_refill_source_window.
5690         (tui_source_window_base::do_scroll_horizontal): Update.
5691         (tui_source_window_base::set_is_exec_point_at): Rename from
5692         tui_set_is_exec_point_at.
5693         (tui_update_all_breakpoint_info): Update.
5694         * tui/tui-stack.c (tui_show_frame_info): Update.
5695         * tui/tui-layout.c (show_data): Add cast.
5696         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5697         * tui/tui-data.h (struct tui_source_window_base) <refill,
5698         set_is_exec_point_at>: New methods.
5699         (tui_source_windows, tui_add_to_source_windows): Update types.
5700         (tui_add_to_source_windows): Remove redundant declaration.
5701         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5702         (tui_source_windows): Change return type.
5703         (tui_clear_source_windows_detail): Update.
5704         (tui_add_to_source_windows): Change type of parameter.
5705         (tui_free_all_source_wins_content): Update.
5706
5707 2019-06-25  Tom Tromey  <tom@tromey.com>
5708
5709         * tui/tui-wingeneral.c (tui_win_info::refresh)
5710         (tui_source_window_base::refresh): New methods.
5711         (tui_refresh_all): Call the refresh method.
5712         * tui/tui-data.h (struct tui_win_info)
5713         (struct tui_source_window_base) <refresh>: New method.
5714
5715 2019-06-25  Tom Tromey  <tom@tromey.com>
5716
5717         * tui/tui.h (tui_is_window_visible): Return bool.
5718         * tui/tui.c (tui_is_window_visible): Return bool.
5719         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5720         (tui_make_visible, tui_make_invisible)
5721         (tui_win_info::make_visible)
5722         (tui_source_window_base::make_visible, make_all_visible)
5723         (tui_make_all_visible, tui_make_all_invisible): Update.
5724         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5725         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5726         bool.
5727         (struct tui_win_info, struct tui_source_window_base)
5728         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5729         * tui/tui-data.c (tui_init_generic_part): Update.
5730
5731 2019-06-25  Tom Tromey  <tom@tromey.com>
5732
5733         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5734         (tui_source_window_base::make_visible): New methods.
5735         (make_all_visible): Make method call.
5736         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5737         (struct tui_source_window_base, struct tui_cmd_window): Override
5738         make_visible.
5739         (tui_win_is_source_type): Don't declare.
5740         * tui/tui-data.c (tui_win_is_source_type): Remove.
5741
5742 2019-06-25  Tom Tromey  <tom@tromey.com>
5743
5744         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5745         NULL check.
5746
5747 2019-06-25  Tom Tromey  <tom@tromey.com>
5748
5749         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5750         Inline constructor.  Add initializers for members.
5751         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5752         constructors; now inline in class.
5753
5754 2019-06-25  Tom Tromey  <tom@tromey.com>
5755
5756         * tui/tui-regs.c (tui_show_registers): Update.
5757         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5758         bool.
5759         * tui/tui-data.c (tui_data_window::clear_detail)
5760         (tui_data_window): Update.
5761
5762 2019-06-25  Tom Tromey  <tom@tromey.com>
5763
5764         * tui/tui-windata.c (tui_display_all_data)
5765         (tui_display_data_from_line, tui_display_data_from)
5766         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5767         Update.
5768         * tui/tui-regs.c (tui_last_regs_line_no)
5769         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5770         (tui_show_registers, tui_show_register_group)
5771         (tui_display_registers_from, tui_display_reg_element_at_line)
5772         (tui_display_registers_from_line, tui_check_register_values)
5773         (tui_reg_next, tui_reg_prev): Update.
5774         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5775         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5776         tui_data_window.
5777         (struct tui_win_info) <detail>: Remove.  Add new fields from
5778         tui_data_info.
5779         (TUI_DATA_WIN): Add cast.
5780         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5781         (~tui_data_window): Simplify.
5782
5783 2019-06-25  Tom Tromey  <tom@tromey.com>
5784
5785         * tui/tui-layout.c (show_source_disasm_command)
5786         (show_source_or_disasm_and_command): Update.
5787         * tui/tui-io.c (update_cmdwin_start_line)
5788         (tui_redisplay_readline): Update.
5789         * tui/tui-data.h (struct tui_command_info): Remove.
5790         (struct tui_win_info) <detail>: Remove command_info member.
5791         (struct tui_data_window) <start_line>: New member, from
5792         tui_command_info.
5793         (TUI_CMD_WIN): Add casts.
5794
5795 2019-06-25  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-winsource.c (tui_update_source_window)
5798         (tui_refill_source_window)
5799         (tui_source_window_base::do_scroll_horizontal)
5800         (tui_update_breakpoint_info, tui_set_exec_info_content)
5801         (tui_show_exec_info_content, tui_erase_exec_info_content)
5802         (tui_clear_exec_info_content): Update.
5803         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5804         Update.
5805         * tui/tui-win.c (make_invisible_and_set_new_height)
5806         (make_visible_with_new_height): Update.
5807         * tui/tui-source.c (tui_set_source_content)
5808         (tui_show_symtab_source): Update.
5809         * tui/tui-layout.c (extract_display_start_addr)
5810         (show_source_disasm_command, show_data)
5811         (make_source_or_disasm_window)
5812         (show_source_or_disasm_and_command): Update.
5813         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5814         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5815         "gdbarch".
5816         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5817         to tui_source_window_base.
5818         (struct tui_win_info) <detail>: Remove source_info member.
5819         (struct tui_source_window_base) <has_locator>: Inline.
5820         Move contents from tui_source_info; rename has_locator member to
5821         m_has_locator.
5822         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5823         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5824         header file.
5825         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5826         Simplify.
5827         (tui_free_all_source_wins_content): Cast to
5828         tui_source_window_base.
5829
5830 2019-06-25  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-win.c (make_invisible_and_set_new_height)
5833         (make_visible_with_new_height): Call has_locator method.
5834         * tui/tui-layout.c (show_source_disasm_command, show_data)
5835         (show_source_or_disasm_and_command): Update for bool change.
5836         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5837         (tui_win_info) <has_locator>: New method.
5838         (struct tui_source_window_base) <has_locator>: New method.
5839         (tui_win_has_locator): Don't declare.
5840         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5841         from tui_win_has_locator.
5842         (tui_source_window_base): Use false, not FALSE.
5843
5844 2019-06-25  Tom Tromey  <tom@tromey.com>
5845
5846         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5847         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5848         clear_detail method directly.
5849         (tui_clear_win_detail): Remove.
5850
5851 2019-06-25  Tom Tromey  <tom@tromey.com>
5852
5853         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5854         "this", not TUI_DISASM_WIN.
5855
5856 2019-06-25  Tom Tromey  <tom@tromey.com>
5857
5858         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5859         declare.
5860         * tui/tui-winsource.c
5861         (tui_source_window_base::do_scroll_horizontal): Rename from
5862         tui_horizontal_source_scroll.
5863         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5864         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5865         from tui_vertical_data_scroll.
5866         * tui/tui-win.h (tui_scroll): Don't declare.
5867         * tui/tui-win.c (tui_win_info::forward_scroll)
5868         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5869         (tui_win_info::right_scroll): Rename and update.
5870         (tui_scroll_forward_command, tui_scroll_backward_command)
5871         (tui_scroll_left_command, tui_scroll_right_command): Update.
5872         (tui_scroll): Remove.
5873         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5874         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5875         from tui_vertical_source_scroll.
5876         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5877         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5878         from tui_vertical_disassem_scroll.
5879         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5880         do_scroll_horizontal>: New methods.
5881         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5882         Likewise.
5883         (struct tui_source_window_base): Add do_scroll_horizontal.
5884         (struct tui_source_window, struct tui_disasm_window): Add
5885         do_scroll_vertical.
5886         (struct tui_data_window, struct tui_cmd_window): Add
5887         do_scroll_horizontal and do_scroll_vertical.
5888         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5889
5890 2019-06-25  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-data.h (struct tui_source_window_base): New struct.
5893         (struct tui_source_window): Derive from tui_source_window_base.
5894         (struct tui_disasm_window): New struct.
5895         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5896         from tui_source_window::clear_detail.
5897         (tui_source_window_base): Rename from tui_source_window.
5898         (~tui_source_window_base): Rename from ~tui_source_window.
5899         (tui_alloc_win_info): Create a tui_disasm_window.
5900
5901 2019-06-25  Tom Tromey  <tom@tromey.com>
5902
5903         * tui/tui-data.h (struct tui_source_window)
5904         (struct tui_data_window): Declare destructors.
5905         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5906         destructors.
5907         (tui_win_info): Simplify.
5908
5909 2019-06-25  Tom Tromey  <tom@tromey.com>
5910
5911         * tui/tui-winsource.c (tui_display_main)
5912         (tui_update_source_windows_with_addr)
5913         (tui_update_all_breakpoint_info): Update.
5914         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5915         (new_height_ok, parse_scrolling_args): Update.
5916         * tui/tui-stack.c (tui_show_frame_info): Update.
5917         * tui/tui-data.h (struct tui_list): Remove.
5918         (tui_source_windows): Return a reference to a std::vector.
5919         * tui/tui-data.c (source_windows): Now a std::vector.
5920         (tui_source_windows): Change return type.
5921         (tui_clear_source_windows): Rewrite.
5922         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5923         (tui_free_all_source_wins_content): Rewrite.
5924
5925 2019-06-25  Tom Tromey  <tom@tromey.com>
5926
5927         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5928         (struct tui_data_window, struct tui_cmd_window): Declare
5929         clear_detail method.
5930         * tui/tui-data.c (tui_source_window::clear_detail)
5931         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5932         methods.
5933         (tui_clear_win_detail): Simplify.
5934
5935 2019-06-25  Tom Tromey  <tom@tromey.com>
5936
5937         * tui/tui-layout.c (make_source_window, make_disasm_window)
5938         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5939         Return the new window.
5940         (show_source_disasm_command, show_data)
5941         (show_source_or_disasm_and_command): Update.
5942
5943 2019-06-25  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5946         parameter.  Return the new window.
5947         (show_source_disasm_command): Update and remove NULL check.
5948         (show_source_or_disasm_and_command): Update.
5949
5950 2019-06-25  Tom Tromey  <tom@tromey.com>
5951
5952         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5953
5954 2019-06-25  Tom Tromey  <tom@tromey.com>
5955
5956         * tui/tui-data.h (struct tui_win_info): Make constructor
5957         protected.  Make destructor virtual.  Add initializers.
5958         (tui_source_window, tui_data_window, tui_cmd_window): New
5959         classes.
5960         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5961         constructor.  Add "type" parameter.
5962         (tui_source_window, tui_data_window, tui_cmd_window): New
5963         constructors.
5964         (tui_alloc_win_info): Instantiate the appropriate subclass.
5965
5966 2019-06-25  Tom Tromey  <tom@tromey.com>
5967
5968         * tui/tui-win.c (tui_resize_all): Use delete.
5969         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5970         destructor.
5971         (tui_free_window): Don't declare.
5972         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5973         Update.
5974
5975 2019-06-25  Tom Tromey  <tom@tromey.com>
5976
5977         * tui/tui-data.h (struct tui_win_info): Add constructor.
5978         * tui/tui-data.c (tui_alloc_win_info): Use new.
5979         (tui_free_window): Use delete.
5980
5981 2019-06-22  Tom Tromey  <tom@tromey.com>
5982
5983         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5984         declare.
5985         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5986
5987 2019-06-22  Tom Tromey  <tom@tromey.com>
5988
5989         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5990         declare.
5991         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5992
5993 2019-06-22  Tom de Vries  <tdevries@suse.de>
5994
5995         * dwarf2read.c (create_addrmap_from_aranges)
5996         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5997         instead of '%zu'.
5998
5999 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6000
6001         * dwarf2read.h (dwarf2_section_info_def): Remove.
6002         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6003         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6004         std::vector<dwarf2_section_info>.
6005         (struct dwo_file) <~dwo_file>: Remove.
6006         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6007         types field.
6008         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6009         (dwarf2_read_debug_names): Likewise.
6010         (create_debug_types_hash_table): Change parameter type to
6011         array_view, adjust code accordingly.
6012         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6013         (partial_die_info::fixup): Likewise.
6014         (determine_prefix): Likewise.
6015         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6016
6017 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6018
6019         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6020         gdb_bfd_ref_ptr.
6021         <~dwo_file>: Remove call to gdb_bfd_unref.
6022         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6023         gdb_bfd_ref_ptr::get.
6024
6025 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6026
6027         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6028         type to htab_up.
6029         * dwarf2read.c (struct dwo_file): Initialize fields.
6030         <~dwo_file>: New.
6031         (free_dwo_file): Remove, move content to ~dwo_file.
6032         (struct dwo_file_deleter): Remove.
6033         (dwo_file_up>: Remove custom deleter.
6034         (free_dwo_files): Remove.
6035         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6036         dwo_files.
6037         (process_skeletonless_type_units): Call unique_ptr::get.
6038         (allocate_dwo_file_hash_table): Add deleter to created hash
6039         table.  Change return type to htab_up.
6040         (lookup_dwo_file_slot): Don't memset dwo_file, call
6041         unique_ptr::get.
6042         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6043         (create_dwo_unit_in_dwp_v2): Likewise.
6044         (open_and_init_dwo_file): Likewise.
6045         (free_dwo_file_from_slot): Remove.
6046
6047 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6048
6049         * dwarf2read.h (struct dwarf2_section_info) <readin,
6050         is_virtual>: Change type to bool.
6051         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6052         true instead of 1.
6053
6054 2019-06-19  Tom Tromey  <tom@tromey.com>
6055
6056         * tui/tui-data.h (tui_init_content_element): Don't declare.
6057
6058 2019-06-19  Tom Tromey  <tom@tromey.com>
6059
6060         * tui/tui-data.h (tui_init_win_info): Don't declare.
6061
6062 2019-06-19  Tom de Vries  <tdevries@suse.de>
6063
6064         * dwarf2read.h (abstract_to_concrete): Change type to
6065         std::unordered_map<sect_offset, std::vector<sect_offset>,
6066         gdb::hash_enum<sect_offset>>.
6067
6068 2019-06-19  Tom Tromey  <tromey@adacore.com>
6069
6070         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6071         EVAL_AVOID_SIDE_EFFECTS specially.
6072
6073 2019-06-19  Tom Tromey  <tromey@adacore.com>
6074
6075         * source-cache.c (highlighter): New global.
6076         (source_cache::get_source_lines): Create a highlighter on demand.
6077
6078 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6079
6080         * defs.h (deprecated_interactive_hook): Delete declaration.
6081         * interps.c (clear_interpreter_hooks): Remove use of
6082         deprecated_interactive_hook.
6083         * top.c (deprecated_interactive_hook): Delete definition.
6084         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6085
6086 2019-06-18  Tom de Vries  <tdevries@suse.de>
6087
6088         PR gdb/24515
6089         * dwarf2read.h (abstract_to_concrete): Change type from
6090         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6091         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6092         * dwarf2read.c (read_variable): Update.
6093         (dwarf2_fetch_die_loc_sect_off): Update.
6094
6095 2019-06-17  Tom de Vries  <tdevries@suse.de>
6096
6097         PR gdb/24617
6098         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6099         accessing parent[parent_len - 1].
6100
6101 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6102
6103         PR gdb/24364
6104         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6105         call dtrace_process_dof with NULL dof.
6106
6107 2019-06-16  Tom de Vries  <tdevries@suse.de>
6108
6109         PR gdb/24445
6110         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6111
6112 2019-06-16  Tom Tromey  <tom@tromey.com>
6113
6114         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6115         (make_all_visible): Use address of member.
6116
6117 2019-06-16  Tom Tromey  <tom@tromey.com>
6118
6119         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6120         (tui_free_window, free_content, free_content_elements): Remove
6121         unnecessary cast.
6122         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6123         cast.
6124         * tui/tui-regs.c (tui_show_register_group)
6125         (tui_display_registers_from, tui_display_reg_element_at_line):
6126         Remove unnecessary cast.
6127
6128 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6129
6130         * linux-nat.c (normal_mask): Delete.
6131         (_initialize_linux_nat): Don't initialise normal_mask.
6132
6133 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6134
6135         PR gdb/24445
6136         * dwarf-index-write.h (write_psymtabs_to_index): Add
6137         dwz_basename parameter.
6138         * dwarf-index-write.c (write_gdbindex): Move file writing to
6139         write_gdbindex_1.  Change return type void.
6140         (assert_file_size): Move up, remove filename parameter.
6141         (write_gdbindex_1): New function.
6142         (write_debug_names): Change return type to void, call
6143         assert_file_size.
6144         (struct index_wip_file): New struct.
6145         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6146         file logic to index_wip_file.  Write index for dwz file if
6147         needed.
6148         (save_gdb_index_command): Pass basename of dwz file, if present.
6149         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6150         build-id of dwz file, if present.
6151         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6152         (dwarf2_get_dwz_file): Likewise.
6153         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6154         (dwarf2_get_dwz_file): Likewise.
6155
6156 2019-06-16  Tom Tromey  <tom@tromey.com>
6157
6158         * coffread.c (process_coff_symbol): Use xstrdup.
6159         * value.c (create_internalvar): Use xstrdup.
6160
6161 2019-06-16  Tom Tromey  <tom@tromey.com>
6162
6163         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6164         * breakpoint.c (stopin_command, stopat_command)
6165         (until_break_command, decode_location_default): Remove unnecessary
6166         cast.
6167         * utils.c (subset_compare): Remove unnecessary cast.
6168         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6169         cast.
6170         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6171         cast.
6172         * infcmd.c (path_command): Remove unnecessary cast.
6173         * coffread.c (decode_type): Remove unnecessary cast.
6174         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6175         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6176         * tui/tui-stack.c (tui_show_locator_content)
6177         (tui_show_frame_info): Remove unnecessary cast.
6178         * tui/tui-win.c (tui_scroll_forward_command)
6179         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6180         (parse_scrolling_args): Remove unnecessary cast.
6181         * tui/tui-data.c (init_win_info, tui_del_window)
6182         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6183         (free_content_elements): Remove unnecessary cast.
6184         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6185         unnecessary cast.
6186         * tui/tui-source.c (tui_set_source_content)
6187         (tui_vertical_source_scroll): Remove unnecessary cast.
6188         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6189         cast.
6190         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6191         * tui/tui-regs.c (tui_display_registers_from)
6192         (tui_display_register): Remove unnecessary cast.
6193         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6194         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6195         (make_visible): Remove unnecessary cast.
6196         * tui/tui-winsource.c (tui_erase_source_content)
6197         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6198         unnecessary cast.
6199         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6200         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6201         * stabsread.c (read_type, read_array_type, read_range_type):
6202         Remove unnecessary cast.
6203         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6204         (parse_symbol, parse_type, upgrade_type, parse_external)
6205         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6206         unnecessary cast.
6207         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6208
6209 2019-06-16  Tom Tromey  <tom@tromey.com>
6210
6211         * tui/tui-data.c (tui_alloc_generic_win_info)
6212         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6213         checks.
6214
6215 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6216             Andrew Burgess  <andrew.burgess@embecosm.com>
6217
6218         * f-typeprint.c (f_print_type): Don't return early for not
6219         associated or not allocated types.
6220         (f_type_print_varspec_suffix): Add print_rank parameter and print
6221         ranks of array types in case they dangling.
6222         (f_type_print_base): Add print_rank parameter.
6223
6224 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * NEWS: Mention new MI commands.
6227         * break-catch-throw.c (enum exception_event_kind): Move to
6228         breakpoint.h.
6229         (print_mention_exception_catchpoint): Output text as a single
6230         message.
6231         (catch_exception_command_1): Rename to...
6232         (catch_exception_event): ...this, make non-static, update header
6233         command, and change some parameter types.
6234         (catch_catch_command): Update for changes to
6235         catch_exception_command_1.
6236         (catch_throw_command): Likewise.
6237         (catch_rethrow_command): Likewise.
6238         * breakpoint.c (enum exception_event_kind): Delete.
6239         * breakpoint.h (enum exception_event_kind): Moved here from
6240         break-catch-throw.c.
6241         (catch_exception_event): Declare.
6242         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6243         (mi_cmd_catch_throw): New function.
6244         (mi_cmd_catch_rethrow): New function.
6245         (mi_cmd_catch_catch): New function.
6246         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6247         'catch-catch' entries.
6248         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6249         (mi_cmd_catch_rethrow): Declare.
6250         (mi_cmd_catch_catch): Declare.
6251
6252 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * annotate.c (annotate_source_line): Change return type to void,
6255         update implementation to match.
6256         * annotate.h (annotate_source_line): Change return type to void,
6257         update header comment.
6258         * stack.c (print_frame_info): Don't change what frame information
6259         is printed based on whether annotations are on or not.
6260
6261 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6262
6263         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6264         (annotate_source): Make static.
6265         (annotate_source_line): Moved from source.c and renamed from
6266         identify_source_line.  Update the return type.
6267         * annotate.h (annotate_source): Delete declaration.
6268         (annotate_source_line): Declaration moved from source.h, and
6269         renamed from identify_source_line.  Return type updated.
6270         * source.c (identify_source_line): Moved to annotate.c and renamed
6271         to annotate_source_line.
6272         (info_line_command): Remove check of annotation_level.
6273         * source.h (identify_source_line): Move declaration to annotate.h
6274         and rename to annotate_source_line.
6275         * stack.c: Add 'annotate.h' include.
6276         (print_frame_info): Remove check of annotation_level before
6277         calling annotate_source_line.
6278
6279 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6280
6281         * source-cache.c (source_cache::get_plain_source_lines): Use
6282         open_source_file_with_line_charpos instead of just
6283         open_source_file, remove call to find_source_lines.
6284         (source_cache::get_source_lines): Likewise.
6285         * source.c (find_source_lines): Make static.
6286         (get_filename_and_charpos): Renamed into...
6287         (open_source_file_with_line_charpos): ..this along with changes to
6288         return a scoped_fd, and some other minor clean ups.
6289         (identify_source_line): Use open_source_file_with_line_charpos.
6290         (search_command_helper): Use open_source_file_with_line_charpos
6291         instead of just open_source_file, remove call to
6292         find_source_lines.
6293         * source.h (open_source_file_with_line_charpos): Declare new
6294         function.
6295         (find_source_lines): Delete declaration.
6296
6297 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6298
6299         * source.c (get_filename_and_charpos): Remove fullname
6300         parameter.
6301         (identify_source_line): Update call to get_filename_and_charpos.
6302
6303 2019-06-14  Tom Tromey  <tromey@adacore.com>
6304
6305         PR gdb/24502:
6306         * ui-style.h (skip_ansi_escape): Update comment.
6307         * ui-file.h (class no_terminal_escape_file): New class.
6308         * ui-file.c (no_terminal_escape_file::write)
6309         (no_terminal_escape_file::puts): New methods.
6310         * cli/cli-logging.c (handle_redirections): Use
6311         no_terminal_escape_file.
6312
6313 2019-06-14  Tom Tromey  <tromey@adacore.com>
6314
6315         * NEWS: Move convenience variable news above Python news.
6316
6317 2019-06-14  Tom Tromey  <tom@tromey.com>
6318
6319         * gnulib: Move directory to top-level.
6320         * configure.ac: Don't configure gnulib.
6321         * configure: Rebuild.
6322         * common/common-defs.h: Use new path to gnulib.
6323         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6324         (GNULIB_H): Remove.
6325         (INCGNU): Look in new gnulib location.
6326         (HFILES_NO_SRCDIR): Remove gnulib files.
6327         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6328         (generated_files): Remove GNULIB_H.
6329         ($(LIBGNU), all-lib): Remove targets.
6330         (distclean): Don't mention GNULIB_BUILDDIR.
6331         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6332
6333 2019-06-14  Tom Tromey  <tromey@adacore.com>
6334
6335         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6336         Warn if symbol file does not provide any symbols.
6337
6338 2019-06-14  Tom Tromey  <tromey@adacore.com>
6339
6340         * source.c (find_and_open_source): Respect basenames_may_differ.
6341
6342 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6343
6344         * annotate.c (annotate_breakpoints_invalid): Make use of
6345         scoped_restore_terminal_state.
6346         (annotate_frames_invalid): Likewise.
6347
6348 2019-06-14  Tom Tromey  <tromey@adacore.com>
6349
6350         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6351         allow assignment to an internalvar.
6352
6353 2019-06-14  Tom Tromey  <tromey@adacore.com>
6354
6355         * ada-lex.l: Allow "_" in attribute names.
6356
6357 2019-06-14  Tom Tromey  <tromey@adacore.com>
6358
6359         PR gdb/24653:
6360         * regcache.c (registers_changed): Don't call alloca.
6361         * top.c (execute_command): Don't call alloca.
6362
6363 2019-06-13  Pedro Alves  <palves@redhat.com>
6364
6365         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6366         'expression'.  When parsing an expression, error out if there's
6367         junk after "unlimited".
6368         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6369         (do_set_command): Adjust calls to is_unlimited_literal.
6370
6371 2019-06-13  Pedro Alves  <palves@redhat.com>
6372
6373         * compile/compile.c (make_compile_options_def_group): Add braces
6374         around array_view initializer.
6375         * thread.c (make_thread_apply_all_options_def_group)
6376         (make_thread_apply_all_options_def_group): Likewise.
6377
6378 2019-06-13  Pedro Alves  <palves@redhat.com>
6379
6380         * NEWS (New commands): Mention "maint test-options
6381         require-delimiter", "maint test-options unknown-is-error", "maint
6382         test-options unknown-is-operand" and "maint show
6383         test-options-completion-result".
6384         (New command options, command completion): New section.
6385         (Completion improvements): New section.
6386         Mention that you can abbreviate "unlimited".
6387
6388 2019-06-13  Pedro Alves  <palves@redhat.com>
6389
6390         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6391         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6392         * unittests/cli-utils-selftests.c (test_parse_flags)
6393         (test_parse_flags_qcs): Delete.
6394         (test_cli_utils): Don't call deleted functions.
6395
6396 2019-06-13  Pedro Alves  <palves@redhat.com>
6397
6398         * thread.c: Include "cli/cli-option.h".
6399         (tp_array_compar_ascending): Global.
6400         (tp_array_compar): Delete function.
6401         (tp_array_compar_ascending, tp_array_compar_descending): New
6402         functions.
6403         (ascending_option_def, qcs_flag_option_def)
6404         (thr_qcs_flags_option_defs)
6405         (make_thread_apply_all_options_def_group)
6406         (make_thread_apply_options_def_group): New.
6407         (thread_apply_all_command): Use gdb::option::process_options.
6408         (thread_apply_command_completer)
6409         (thread_apply_all_command_completer): New.
6410         (thread_apply_command): Use gdb::option::process_options.
6411         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6412         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6413         to generate help text of "thread apply".  Adjust "taas"'s help.
6414         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6415         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6416
6417 2019-06-13  Pedro Alves  <palves@redhat.com>
6418
6419         * thread.c (thread_apply_command): Check for invalid TID with
6420         isdigit instead of !isalpha.
6421
6422 2019-06-13  Pedro Alves  <palves@redhat.com>
6423
6424         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6425         (validate_flags_qcs): New.
6426         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6427         (validate_flags_qcs): Declare.
6428         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6429         (make_frame_apply_options_def_group): New.
6430         (frame_apply_command_count): Process options with
6431         gdb::option::process_options.
6432         (frame_apply_completer): New.
6433         (frame_apply_level_completer, frame_apply_all_completer)
6434         (frame_apply_completer): New.
6435         (_initialize_stack): Update help of "frame apply", "frame apply
6436         level", "frame apply all" and "faas" to mention supported options
6437         and install command completers.
6438         * stack.h (frame_apply_all_completer): Declare.
6439         * thread.c: Include "stack.h".
6440         (tfaas_command): Add "--".
6441         (_initialize_thread): Update help "tfaas" to mention supported
6442         options and install command completer.
6443
6444 2019-06-13  Pedro Alves  <palves@redhat.com>
6445
6446         * completer.c (complete_nested_command_line): New.
6447         (gdb_completion_word_break_characters_throw): Add assertion.
6448         * completer.h (complete_nested_command_line): Declare.
6449
6450 2019-06-13  Pedro Alves  <palves@redhat.com>
6451
6452         * stack.c (parse_backtrace_qualifiers): New.
6453         (backtrace_command): Use it.
6454         (backtrace_command_completer): Complete on qualifiers.
6455
6456 2019-06-13  Pedro Alves  <palves@redhat.com>
6457
6458         * frame.c: Include "cli/cli-option.h.
6459         (user_set_backtrace_options): New.
6460         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6461         Delete.
6462         (get_prev_frame): Adjust.
6463         (boolean_option_def, uinteger_option_def)
6464         (set_backtrace_option_defs): New.
6465         (_initialize_frame): Adjust and use
6466         gdb::option::add_setshow_cmds_for_options to install "set
6467         backtrace past-main" and "set backtrace past-entry".
6468         * frame.h: Include "cli/cli-option.h".
6469         (struct frame_print_options): Forward declare.
6470         (print_frame_arguments_all, print_frame_arguments_scalars)
6471         (print_frame_arguments_none): Declare.
6472         (print_entry_values): Delete declaration.
6473         (struct frame_print_options, user_frame_print_options): New.
6474         (struct set_backtrace_options): New.
6475         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6476         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6477         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6478         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6479         (list_args_or_locals): Add frame_print_options parameter.
6480         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6481         * python/py-framefilter.c (enumerate_args): Pass down
6482         USER_FRAME_PRINT_OPTIONS.
6483         * stack.c: Include "cli/cli-option.h".
6484         (print_frame_arguments_all, print_frame_arguments_scalars)
6485         (print_frame_arguments_none): Declare.
6486         (print_raw_frame_arguments, print_entry_values): Delete.
6487         (user_frame_print_options): New.
6488         (boolean_option_def, enum_option_def, frame_print_option_defs):
6489         New.
6490         (struct backtrace_cmd_options): New.
6491         (bt_flag_option_def): New.
6492         (backtrace_command_option_defs): New.
6493         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6494         (print_frame_arg, read_frame_arg, print_frame_args)
6495         (print_frame_info, print_frame): Add frame_print_options parameter
6496         and use it.
6497         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6498         (backtrace_command_1): Add frame_print_options and
6499         backtrace_cmd_options parameters and use them.
6500         (make_backtrace_options_def_group): New.
6501         (backtrace_command): Process command options with
6502         gdb::option::process_options.
6503         (backtrace_command_completer): New.
6504         (_initialize_stack): Extend "backtrace"'s help to mention
6505         supported options.  Install completer for "backtrace".
6506         Install some settings commands with add_setshow_cmds_for_options.
6507
6508 2019-06-13  Pedro Alves  <palves@redhat.com>
6509
6510         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6511         and that "set/show print raw frame-arguments" are now deprecated.
6512
6513         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6514         command.
6515         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6516         * stack.c (_initialize_stack): Install "set/show print
6517         raw-frame-arguments", and deprecate "set/show print raw
6518         frame-arguments".
6519         * valprint.c (_initialize_valprint): Deprecate "set/show print
6520         raw".
6521
6522 2019-06-13  Pedro Alves  <palves@redhat.com>
6523
6524         * compile/compile.c (struct compile_options): New.
6525         (compile_flag_option_def, compile_command_option_defs)
6526         (make_compile_options_def_group): New.
6527         (compile_file_command): Handle options with
6528         gdb::option::process_options.
6529         (compile_file_command_completer): New function.
6530         (compile_code_command): Handle options with
6531         gdb::option::process_options.
6532         (compile_code_command_completer): New function.
6533         (_initialize_compiler): Install completers for "compile code" and
6534         "compile file".  Mention available options in "compile code" and
6535         "compile code"'s help.
6536         * completer.c (advance_to_completion_word): New, factored out from
6537         ...
6538         (advance_to_expression_complete_word_point): ... this.
6539         (advance_to_filename_complete_word_point): New.
6540         * completer.h (advance_to_filename_complete_word_point): New
6541         declaration.
6542
6543 2019-06-13  Pedro Alves  <palves@redhat.com>
6544
6545         * compile/compile.c: Include "cli/cli-option.h".
6546         (compile_print_value): Scope data pointer is now a
6547         value_print_options pointer; adjust.
6548         (compile_print_command): Process options.  Scope data pointer is
6549         now a value_print_options pointer; adjust.
6550         (_initialize_compile): Update "compile print"'s help to include
6551         supported options.  Install a completer for "compile print".
6552         * cp-valprint.c (show_vtblprint, show_objectprint)
6553         (show_static_field_print): Delete.
6554         (_initialize_cp_valprint): Don't install "set print
6555         static-members", "set print vtbl", "set print object" here.
6556         * printcmd.c: Include "cli/cli-option.h" and
6557         "common/gdb_optional.h".
6558         (print_command_parse_format): Rework to fill in a
6559         value_print_options instead of a format_data.
6560         (print_value): Change parameter type from format_data pointer to
6561         value_print_options reference.  Adjust.
6562         (print_command_1): Process options.  Adjust to pass down a
6563         value_print_options.
6564         (print_command_completer): New.
6565         (_initialize_printcmd): Install print_command_completer as
6566         handle_brkchars completer for the "print" command.  Update
6567         "print"'s help to include supported options.
6568         * valprint.c: Include "cli/cli-option.h".
6569         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6570         here from cp-valprint.c.
6571         (boolean_option_def, uinteger_option_def)
6572         (value_print_option_defs, make_value_print_options_def_group):
6573         New.  Use gdb::option::add_setshow_cmds_for_options to install
6574         "set print elements", "set print null-stop", "set print repeats",
6575         "set print pretty", "set print union", "set print array", "set
6576         print address", "set print symbol", "set print array-indexes".
6577         * valprint.h: Include <string> and "cli/cli-option.h".
6578         (make_value_print_options_def_group): Declare.
6579         (print_value): Change parameter type from format_data pointer to
6580         value_print_options reference.
6581         (print_command_completer): Declare.
6582
6583 2019-06-13  Pedro Alves  <palves@redhat.com>
6584
6585         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6586         (COMMON_SFILES): Add maint-test-settings.c.
6587         * cli/cli-decode.c (boolean_enums): New global, factored out from
6588         ...
6589         (add_setshow_boolean_cmd): ... here.
6590         * cli/cli-decode.h (boolean_enums): Declare.
6591         * cli/cli-option.c: New file.
6592         * cli/cli-option.h: New file.
6593         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6594         factored out from ...
6595         (parse_cli_boolean_value(const char *)): ... this.
6596         (is_unlimited_literal): Change parameter type to pointer to
6597         pointer.  Adjust and advance ARG pointer.
6598         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6599         (parse_cli_var_enum): New, factored out from ...
6600         (do_set_command): ... this.  Adjust.
6601         * cli/cli-setshow.h (parse_cli_boolean_value)
6602         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6603         (parse_cli_var_enum): Declare.
6604         * cli/cli-utils.c: Include "cli/cli-option.h".
6605         (get_ulongest): New.
6606         * cli/cli-utils.h (get_ulongest): Declare.
6607         (check_for_argument): New overloads.
6608         * maint-test-options.c: New file.
6609
6610 2019-06-13  Pedro Alves  <palves@redhat.com>
6611
6612         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6613         parse a range if "-" is at the end of the string.
6614
6615 2019-06-13  Pedro Alves  <palves@redhat.com>
6616
6617         * cli/cli-setshow.c (parse_auto_binary_operation)
6618         (parse_cli_boolean_value): Don't allow "o".
6619
6620 2019-06-13  Pedro Alves  <palves@redhat.com>
6621
6622         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6623         * NEWS: Mention maint test-settings KIND.
6624         * maint-test-settings.c: New file.
6625
6626 2019-06-13  Pedro Alves  <palves@redhat.com>
6627
6628         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6629         completer.
6630         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6631         "set" completers.
6632
6633 2019-06-13  Pedro Alves  <palves@redhat.com>
6634
6635         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6636         after item.
6637
6638 2019-06-13  Pedro Alves  <palves@redhat.com>
6639
6640         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6641
6642 2019-06-13  Pedro Alves <palves@redhat.com>
6643
6644         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6645         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6646         call.
6647         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6648         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6649         calls.
6650         (check_for_argument): Skip spaces after argument.
6651
6652 2019-06-13  Pedro Alves  <palves@redhat.com>
6653
6654         * thread.c (thread_apply_command): Adjust TID parsing.
6655         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6656         detected before end of string.
6657         (tid_is_in_list): Error out if LIST is invalid.
6658
6659 2019-06-13  Pedro Alves  <palves@redhat.com>
6660
6661         * completer.c (complete_line_internal_1): Rewind completion word
6662         point.
6663         (completion_tracker::advance_custom_word_point_by): Change
6664         parameter type to int.
6665         * completer.h (completion_tracker::advance_custom_word_point_by):
6666         Likewise.
6667
6668 2019-06-13  Pedro Alves  <palves@redhat.com>
6669
6670         * completer.c (advance_to_completion_word): Handle delimiters.
6671
6672 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6673
6674         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6675
6676 2019-06-11  Tom Tromey  <tom@tromey.com>
6677
6678         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6679         (xmalloc_failed): Move to alloc.c.
6680         * alloc.c: New file.
6681         * Makefile.in (COMMON_SFILES): Add alloc.c.
6682
6683 2019-06-11  Tom Tromey  <tom@tromey.com>
6684
6685         * nat/linux-waitpid.c: Don't include server.h.
6686         (linux_debug): Remove.
6687         (my_waitpid): Update.
6688
6689 2019-06-11  Tom Tromey  <tromey@adacore.com>
6690
6691         * infcall.c (_initialize_infcall): Remove trailing newline from
6692         help.
6693         * user-regs.c (_initialize_user_regs): Remove trailing newline
6694         from help.
6695         * typeprint.c (_initialize_typeprint): Remove trailing newline
6696         from help.
6697         * reverse.c (_initialize_reverse): Remove trailing newlines from
6698         help.
6699         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6700         from help.
6701         * language.c (add_set_language_command): Remove trailing newline
6702         from help.
6703         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6704         help.
6705         * disasm.c (_initialize_disasm): Remove trailing newline from
6706         help.
6707         * top.c (init_main): Remove trailing newline from help.
6708         * interps.c (_initialize_interpreter): Remove trailing newline
6709         from help.
6710         * btrace.c (_initialize_btrace): Remove trailing newlines from
6711         help.
6712         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6713         from help.
6714         * python/python.c (_initialize_python): Remove trailing newline
6715         from help.
6716         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6717         help.
6718         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6719         from help.  Reformat some text.
6720         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6721         from help.
6722         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6723         newline from help.
6724
6725 2019-06-11  Tom Tromey  <tromey@adacore.com>
6726
6727         * darwin-nat.c (darwin_decode_exception_message)
6728         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6729
6730 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * valops.c (value_slice): Check for not allocated or not
6733         associated values.
6734
6735 2019-06-10  Tom de Vries  <tdevries@suse.de>
6736
6737         PR gdb/24618
6738         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6739         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6740         invalid.
6741
6742 2019-06-10  Tom de Vries  <tdevries@suse.de>
6743
6744         PR gdb/24611
6745         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6746         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6747
6748 2019-06-10  Tom de Vries  <tdevries@suse.de>
6749
6750         PR symtab/24545
6751         * symtab.c (struct demangled_name_entry): Add language field.
6752         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6753         static minimal symbol".  Set and use language field.
6754
6755 2019-06-10  Tom Tromey  <tromey@adacore.com>
6756
6757         * ada-lang.c (_initialize_ada_language): Update help text.
6758
6759 2019-06-10  Tom Tromey  <tromey@adacore.com>
6760
6761         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6762         with a newline.
6763         * guile/guile.c (handle_boot_error): Don't end warning with a
6764         newline.
6765         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6766         warning with a newline.
6767         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6768         newline.
6769         (s12z_frame_cache): Likewise.
6770         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6771         a newline.
6772         * solib-svr4.c (disable_probes_interface): Don't end warning with
6773         a newline.
6774         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6775         newline.
6776         * python/python.c (do_finish_initialization): Don't end warning
6777         with a newline.
6778
6779 2019-06-10  Tom Tromey  <tom@tromey.com>
6780
6781         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6782         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6783         gdbpy_enter.
6784
6785 2019-06-10  Tom Tromey  <tromey@adacore.com>
6786
6787         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6788         data.
6789         (elf_new_init): Don't call stabsread_new_init.
6790         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6791         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6792         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6793
6794 2019-06-10  Tom de Vries  <tdevries@suse.de>
6795
6796         PR symtab/16264
6797         PR symtab/24517
6798         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6799
6800 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6801
6802         * source.c (find_and_open_source): Also rewrite relative file
6803         names.
6804
6805 2019-04-26  Amos Bird  <amosbird@gmail.com>
6806
6807         * annotate.c (annotate_thread_exited): Add "thread-exited"
6808         annotation.
6809
6810 2019-06-06  Tom Tromey  <tromey@adacore.com>
6811
6812         * maint.h (class scoped_command_stats): Use
6813         DISABLE_COPY_AND_ASSIGN.
6814         <print_time>: New method.
6815         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6816         print_time.
6817         (scoped_command_stats::print_time): New method.
6818
6819 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6820
6821         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6822         instructions of lengths 6 or 8 bytes.
6823
6824 2019-06-04  Pedro Alves  <palves@redhat.com>
6825
6826         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6827
6828         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6829         * breakpoint.c (condition_completer): Likewise.
6830         * cli/cli-dump.c (scan_expression): Likewise.
6831         * common/filestuff.c (mkdir_recursive): Likewise.
6832         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6833         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6834         (gdb_abspath): Likewise.
6835         * compile/compile-cplus-types.c
6836         (compile_cplus_instance::decl_name): Likewise.
6837         * completer.c (complete_explicit_location):
6838         (signal_completer, reg_or_group_completer_1): Likewise.
6839         * cp-support.c (cp_remove_params_if_any): Likewise.
6840         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6841         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6842         * infcmd.c (strip_bg_char): Likewise.
6843         * linespec.c (copy_token_string): Likewise.
6844         * mi/mi-main.c (output_cores): Likewise.
6845         * psymtab.c (psymtab_search_name):
6846         * symfile.c (test_set_ext_lang_command): Likewise.
6847         * target.c (target_fileio_read_stralloc): Likewise.
6848         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6849         * value.c (complete_internalvar): Likewise.
6850
6851 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6852
6853         Add objfile property to gdb.Type.
6854         * NEWS: Mention Python API addition.
6855         * python/py-type.c (typy_get_objfile): New method.
6856
6857 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6858
6859         * NEWS: Mention the new set|show style [title|highlight].
6860         Mention changes to "show style", "help" and "apropos".
6861
6862 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6863
6864         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6865         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6866         instead of print_help_for_command.
6867         (print_doc_of_command): New function.
6868         (help_list): Add 'apropos -v word' suggestion.
6869         (print_help_for_command): Style the command name using title style.
6870         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6871         (_initialize_cli_cmds): Describe -v in apropos_command help.
6872
6873 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6874
6875         * cli/cli-style.h (cli_style_option): Add name in constructor,
6876         add m_name class member, add constructor with intensity,
6877         add name class function.
6878         (cli_style_option::add_setshow_commands): Remove name argument.
6879         (highlight_style, title_style): New styles.
6880         * cli/cli-style.c (do_show): New function that shows a style
6881         characteristic styling the style name with itself.
6882         (set_style_name): New function.
6883         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6884         Update all callers according to the changes in cli/cli-style.h.
6885         * utils.h (fputs_highlighted): New function.
6886         * utils.c (fputs_highlighted): Likewise.
6887
6888 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6889
6890         * NEWS: Mention new pipe command and new convenience variables.
6891
6892 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6893
6894         * cli/cli-cmds.c (pipe_command): New function.
6895         (_initialize_cli_cmds): Call add_com for pipe_command.
6896         Define | as an alias for pipe.
6897         (exit_status_set_internal_vars): New function.
6898         (shell_escape): Call exit_status_set_internal_vars.
6899         cli/cli-decode.c (find_command_name_length): Recognize | as
6900         a single character command.
6901
6902 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6903
6904         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6905         top.c (execute_command_to_ui_file): New function, mostly a copy
6906         of execute_command_to_string.
6907         (execute_command_to_string): Implement by calling
6908         execute_command_to_ui_file.
6909
6910 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6911
6912         * top.h (saved_command_line): Remove declaration.
6913         * top.c (previous_saved_command_line, previous_repeat_arguments):
6914         New variables.
6915         (saved_command_line): Make static, define together with other
6916         'repeat variables'.
6917         (dont_repeat): Clear repeat_arguments.
6918         (repeat_previous, get_saved_command_line, save_command_line):
6919         New functions.
6920         (gdb_init): Initialize saved_command_line
6921         and previous_saved_command_line.
6922         * main.c (captured_main_1): Remove saved_command_line initialization.
6923         * event-top.c (handle_line_of_input): Update to use
6924         the new 'repeat' related functions instead of direct access to
6925         saved_command_line.
6926         * command.h (repeat_previous, get_saved_command_line,
6927         save_command_line): New declarations.
6928         (dont_repeat): Add comment.
6929
6930 2019-05-30  Tom Tromey  <tromey@adacore.com>
6931
6932         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6933         Fix comment.
6934         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6935
6936 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6937
6938         PR cli/24587
6939         * completer.c (complete): Initialize variable word.
6940
6941 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6942
6943         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6944         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6945         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6946         'body' is NULL to the outter 'if', protecting the '!is_define'
6947         situation as well.
6948
6949 2019-05-29  Tom Tromey  <tromey@adacore.com>
6950
6951         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6952         (dwarf_unknown): New function.
6953         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6954         (dwarf_type_encoding_name): Use dwarf_unknown.
6955
6956 2019-05-29  Tom Tromey  <tromey@adacore.com>
6957
6958         PR c++/20020:
6959         * cp-valprint.c (cp_print_value_fields): Call
6960         cp_print_static_field inside "try".
6961
6962 2019-05-29  Tom Tromey  <tromey@adacore.com>
6963
6964         * inflow.c (struct terminal_info): Add default operator=.
6965         * configure: Rebuild.
6966         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6967         -Wdeprecated-copy-dtor, -Wredundant-move.
6968
6969 2019-05-29  Tom Tromey  <tromey@adacore.com>
6970
6971         * NEWS: Add entry.
6972         * infcmd.c (print_return_value_1): Handle finish_print
6973         option.
6974         (show_print_finish): New function.
6975         (_initialize_infcmd): Add "set/show print finish" commands.
6976         * valprint.c (user_print_options): Initialize new member.
6977         * valprint.h (struct value_print_options) <finish_print>: New
6978         member.
6979
6980 2019-05-28  Tom Tromey  <tromey@adacore.com>
6981
6982         * ada-lang.c (ada_remove_Xbn_suffix)
6983         (find_old_style_renaming_symbol)
6984         (parse_old_style_renaming): Remove.
6985         (ada_find_renaming_symbol): Don't call
6986         find_old_style_renaming_symbol.
6987         (ada_is_renaming_symbol): Rename from
6988         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6989         bool.  Now static.
6990         (ada_read_var_value): Update and simplify.
6991         * ada-exp.y (write_var_or_type): Remove old code.
6992
6993 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6994
6995         PR gdb/25010
6996         * event-top.c: Remove include comment.
6997         * inflow.c (class scoped_ignore_sigttou): Move from here...
6998         * inflow.h (class scoped_ignore_sigttou): ...to here.
6999         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7000         * top.c:  Remove include comment.
7001
7002 2019-05-27  Tom Tromey  <tom@tromey.com>
7003
7004         * NEWS: Fix typo.
7005
7006 2019-05-22  Tom Tromey  <tromey@adacore.com>
7007
7008         * target.c (target_follow_exec): Constify parameter.
7009         * target-delegates.c: Rebuild.
7010         * remote.c (remote_target::follow_exec): Constify parameter.
7011         * infrun.c (follow_exec): Constify parameter.
7012         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7013         (target_follow_exec): Likewise.
7014
7015 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7016
7017         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7018         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7019
7020 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7021
7022         * NEWS: Add debugredirect and testsuite sections.
7023
7024 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7025
7026         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7027         target descriptions using exclusively floating point register name
7028         aliases.
7029
7030 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7031
7032         PR gdb/18644:
7033         * f-lang.c (build_fortran_types): Handle the case where
7034         gdbarch_floatformat_for_type returns a nullptr.
7035
7036 2019-05-21  Tom de Vries  <tdevries@suse.de>
7037
7038         PR cli/24587
7039         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7040
7041 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7042
7043         PR gdb/18644:
7044         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7045         16-byte floats.
7046         * i386-tdep.c (i386_floatformat_for_type): Use
7047         floatformats_ia64_quad for the 16-byte floating point component
7048         within a fortran 32-byte complex number.
7049
7050 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7051
7052         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7053         delete default constructor.
7054         (find_partial_die): Update to return const struct.
7055         (partial_die_parent_scope): Move variable declaration into scope
7056         of its use and change its type to auto.
7057         (guess_partial_die_structure_name): Likewise.
7058         (partial_die_info::fixup): Likewise.
7059
7060 2019-05-17  Tom Tromey  <tromey@adacore.com>
7061
7062         * source.c (find_and_open_source): Remove cast.
7063
7064 2019-05-17  Tom Tromey  <tromey@adacore.com>
7065
7066         * annotate.c (annotate_source): Make "filename" const.
7067         * annotate.h (annotate_source): Use const.
7068
7069 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7070
7071         * disasm.c (set_disassembler_options): Send errors to stderr.
7072
7073 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7074
7075         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7076         (cli_interp_base::set_logging): Check debug_redirect.
7077         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7078         * cli/cli-logging.c (debug_redirect): Add static variable.
7079         (pop_output_files): Add default param.
7080         (handle_redirections): Print debug setting.
7081         (show_logging_command): Likewise.
7082         (_initialize_cli_logging): Add debugredirect command.
7083         * interps.c (current_interp_set_logging): Add debug_redirect
7084         parameter.
7085         * interps.h (set_logging): Add debug_redirect parameter.
7086         (current_interp_set_logging): Likewise.
7087         * mi/mi-common.h: Likewise.
7088         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7089
7090 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7091             Tom Tromey  <tromey@adacore.com>
7092
7093         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7094         directly.
7095         * cli/cli-interp.h (make_logging_output): Remove declaration.
7096         * cli/cli-logging.c (make_logging_output): Remove function.
7097         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7098         directly.
7099         * ui-file.c (tee_file::tee_file): Remove bools.
7100         (tee_file::~tee_file): Remove deletes.
7101         * ui-file.h (tee_file): Remove bools.
7102
7103 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7104
7105         * mi/mi-cmds.h (mi_cmd_complete): New function.
7106         * mi/mi-main.c (mi_cmd_complete): Likewise.
7107         * mi/mi-cmds.c: Define new MI command -complete.
7108         * NEWS: Mention new -complete command.
7109
7110 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7111
7112         * completer.h (complete): New function.
7113         * completer.c (complete): Likewise.
7114         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7115         function defined in completer.h.
7116
7117 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7118
7119         * MAINTAINERS (Write After Approval): Add myself.
7120
7121 2019-05-17  Tom de Vries  <tdevries@suse.de>
7122
7123         PR gdb/24094
7124         * dwarf2read.c (struct cu_partial_die_info): New struct.
7125         (find_partial_die): Return cu_partial_die_info.
7126         (partial_die_parent_scope, guess_partial_die_structure_name)
7127         (partial_die_info::fixup): Handle new return type of find_partial_die.
7128
7129 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7130
7131         PR breakpoints/24541
7132         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7133         "std::string", simplifying the algorithm.
7134
7135 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7136
7137         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7138         (stap_static_probe_ops::get_probes): Likewise.
7139
7140 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7141
7142         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7143         '-')" and "else if".
7144         (stap_parse_single_operand): Join checks for
7145         "gdbarch_stap_parse_special_token_p" and
7146         "gdbarch_stap_parse_special_token" in the same "if" statement.
7147         Invert check when verifying for operation on register
7148         displacement.
7149
7150 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7151
7152         * stap-probe.c (stap_get_opcode): Update comment.
7153         (stap_get_expected_argument_type): Likewise.
7154         (handle_stap_probe): Likewise.
7155
7156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7157
7158         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7159         return type to 'bool'.  Adjust comment.  Use 'bool' when
7160         appropriate.
7161         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7162         * stap-probe.c (stap_parse_argument_1): Likewise.
7163         (stap_is_operator): Likewise.
7164         (stap_is_generic_prefix): Likewise.
7165         (stap_is_register_prefix): Likewise.
7166         (stap_is_register_indirection_prefix): Likewise.
7167         (stap_is_integer_prefix): Likewise.
7168         (stap_generic_check_suffix): Likewise.
7169         (stap_check_integer_suffix): Likewise.
7170         (stap_check_register_suffix): Likewise.
7171         (stap_check_register_indirection_suffix): Likewise.
7172         (stap_parse_register_operand): Likewise.
7173         (stap_parse_single_operand): Likewise.
7174         (stap_parse_argument_1): Likewise.
7175         (stap_probe::get_argument_count): Likewise.
7176         (stap_is_operator): Likewise.
7177
7178 2019-05-16  Tom Tromey  <tromey@adacore.com>
7179
7180         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7181         keyword to foreach.
7182
7183 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7184
7185         * linux-thread-db.c (try_thread_db_load_1): Change return type
7186         to bool.
7187         (try_thread_db_load): Likewise.
7188         (try_thread_db_load_from_pdir_1): Likewise.
7189         (try_thread_db_load_from_pdir): Likewise.
7190         (try_thread_db_load_from_sdir): Likewise.
7191         (try_thread_db_load_from_dir): Likewise.
7192         (thread_db_load_search): Likewise.
7193         (has_libpthread): Likewise.
7194         (thread_db_load): Likewise.
7195
7196 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7197
7198         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7199         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7200         NULL, and complain/return if that's the case.
7201
7202 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7203
7204         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7205         (advance, posn, abstract_read_memory): New functions.
7206         [struct mem_read_abstraction]: New struct.
7207         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7208
7209 2019-05-14  Tom Tromey  <tromey@adacore.com>
7210
7211         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7212         value is not lval_memory.
7213
7214 2019-05-14  Tom Tromey  <tromey@adacore.com>
7215
7216         * solib.c (info_sharedlibrary_command): Style the file name.
7217
7218 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7219
7220         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7221         (aarch64_vnv_type): Likewise.
7222         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7223         * common/tdesc.c: Likewise.
7224         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7225         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7226         * features/aarch64-fpu.xml: Add ieee half view.
7227         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7228         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7229         * gdbtypes.h (struct builtin_type): Likewise.
7230         (struct objfile_type): Likewise.
7231
7232 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7233
7234         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7235         typo.
7236         * location.h (string_to_event_location): Likewise.
7237
7238 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7239
7240         GDB 8.3 released.
7241
7242 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7243
7244         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7245         New variable declaration.
7246         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7247         New variable.
7248         (print_one_breakpoint): Use ui_out::test_flags and new global
7249         variable to compute use_fixed_output.
7250         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7251         Remove.
7252         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7253         (mi_multi_location_breakpoint_output_fixed): Remove.
7254         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7255         new variable.
7256         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7257         fix_multi_location_breakpoint_output flag if version >= 3.
7258         * ui-out.h (enum ui_out_flag)
7259         <fix_multi_location_breakpoint_output>: New enumerator.
7260
7261 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7262
7263         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7264
7265 2019-05-10  Tom Tromey  <tromey@adacore.com>
7266
7267         * ada-lang.c (catch_ada_completer): New function.
7268         (_initialize_ada_language): Use it.
7269
7270 2019-05-10  Tom Tromey  <tromey@adacore.com>
7271
7272         * thread.c (print_thread_info): Make "requested_threads" const.
7273         * gdbthread.h (print_thread_info): Make "requested_threads"
7274         const.
7275         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7276         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7277
7278 2019-05-08  Tom Tromey  <tom@tromey.com>
7279
7280         * gdbtypes.c (objfile_type_data): Change type.
7281         (objfile_type, _initialize_gdbtypes): Update.
7282
7283 2019-05-08  Tom Tromey  <tom@tromey.com>
7284
7285         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7286         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7287         (_initialize_dwarf2_frame): Update.
7288
7289 2019-05-08  Tom Tromey  <tom@tromey.com>
7290
7291         * objc-lang.c (objc_objfile_data): Change type.
7292         (find_methods): Update.
7293         (_initialize_objc_lang): Remove.
7294
7295 2019-05-08  Tom Tromey  <tom@tromey.com>
7296
7297         * stabsread.c (rs6000_builtin_type_data): Change type.
7298         (rs6000_builtin_type, _initialize_stabsread): Update.
7299
7300 2019-05-08  Tom Tromey  <tom@tromey.com>
7301
7302         * mips-tdep.c (mips_pdr_data): Remove.
7303         (_initialize_mips_tdep): Update.
7304
7305 2019-05-08  Tom Tromey  <tom@tromey.com>
7306
7307         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7308         (hppa_init_objfile_priv_data, read_unwind_info)
7309         (find_unwind_entry, _initialize_hppa_tdep): Update.
7310
7311 2019-05-08  Tom Tromey  <tom@tromey.com>
7312
7313         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7314         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7315         on obstack.
7316         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7317
7318 2019-05-08  Tom Tromey  <tom@tromey.com>
7319
7320         * mdebugread.c (basic_type_data): Change type.
7321         (basic_type, _initialize_mdebugread): Update.
7322
7323 2019-05-08  Tom Tromey  <tom@tromey.com>
7324
7325         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7326
7327 2019-05-08  Tom Tromey  <tom@tromey.com>
7328
7329         * nto-tdep.c (nto_inferior_data_reg): Change type.
7330         (nto_inferior_data): Update.
7331         (nto_inferior_data_cleanup, nto_new_inferior_data)
7332         (_initialize_nto_tdep): Remove.
7333         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7334
7335 2019-05-08  Tom Tromey  <tom@tromey.com>
7336
7337         * ada-lang.c (struct ada_inferior_data): Add initializers.
7338         (ada_inferior_data): Change type.
7339         (ada_inferior_data_cleanup): Remove.
7340         (get_ada_inferior_data, ada_inferior_exit)
7341         (struct ada_pspace_data): Add initializers, destructor.
7342         (ada_pspace_data_handle): Change type.
7343         (get_ada_pspace_data): Update.
7344         (ada_pspace_data_cleanup): Remove.
7345
7346 2019-05-08  Tom Tromey  <tom@tromey.com>
7347
7348         * coffread.c (struct coff_symfile_info): Add initializers.
7349         (coff_objfile_data_key): Move lower.  Change type.
7350         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7351         Update.
7352         (coff_free_info): Remove.
7353
7354 2019-05-08  Tom Tromey  <tom@tromey.com>
7355
7356         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7357         (fbsd_pspace_data_handle): Move lower.  Change type.
7358         (get_fbsd_pspace_data): Update.
7359         (fbsd_pspace_data_cleanup): Remove.
7360         (_initialize_fbsd_tdep): Update.
7361
7362 2019-05-08  Tom Tromey  <tom@tromey.com>
7363
7364         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7365         (get_ada_tasks_pspace_data): Update.
7366         (ada_tasks_pspace_data_cleanup): Remove.
7367         (_initialize_tasks): Update.
7368         (ada_tasks_inferior_data_handle): Change type.
7369         (get_ada_tasks_inferior_data): Update.
7370         (ada_tasks_inferior_data_cleanup): Remove.
7371         (struct ada_tasks_pspace_data): Add initializers.
7372
7373 2019-05-08  Tom Tromey  <tom@tromey.com>
7374
7375         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7376         * symfile-debug.c (debug_sym_get_probes): Change type.
7377         * stap-probe.c (handle_stap_probe):
7378         (stap_static_probe_ops::get_probes): Change type.
7379         * probe.h (class static_probe_ops) <get_probes>: Change type.
7380         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7381         (parse_probes_in_pspace): Update.
7382         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7383         Update.
7384         (any_static_probe_ops::get_probes): Change type.
7385         * elfread.c (elfread_data): New typedef.
7386         (probe_key): Change type.
7387         (elf_get_probes): Likewise.  Update.
7388         (probe_key_free): Remove.
7389         (_initialize_elfread): Update.
7390         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7391         Change type.
7392         (dtrace_process_dof_probe, dtrace_process_dof)
7393         (dtrace_static_probe_ops::get_probe): Change type.
7394
7395 2019-05-08  Tom Tromey  <tom@tromey.com>
7396
7397         * xcoffread.c (struct xcoff_symfile_info): Rename from
7398         coff_symfile_info.  Add initializers.
7399         (xcoff_objfile_data_key): Move lower.  Change type.
7400         (XCOFF_DATA): Rewrite.
7401         (xcoff_free_info): Remove.
7402         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7403         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7404         (xcoff_initial_scan): Update.
7405
7406 2019-05-08  Tom Tromey  <tom@tromey.com>
7407
7408         * solib-svr4.c (struct svr4_info): Add initializers and
7409         destructor.
7410         <probes_table>: Now an htab_up.
7411         (solib_svr4_pspace_data): Change type.
7412         (free_probes_table): Simplify.
7413         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7414         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7415         (probes_table_remove_objfile_probes, register_solib_event_probe)
7416         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7417         (_initialize_svr4_solib): Update.
7418
7419 2019-05-08  Tom Tromey  <tom@tromey.com>
7420
7421         * remote.c (remote_pspace_data): Change type.
7422         (remote_pspace_data_cleanup): Remove.
7423         (get_remote_exec_file, set_pspace_remote_exec_file)
7424         (_initialize_remote): Update.
7425
7426 2019-05-08  Tom Tromey  <tom@tromey.com>
7427
7428         * breakpoint.c (breakpoint_objfile_key): Change type.
7429         (get_breakpoint_objfile_data): Update.
7430         (free_breakpoint_objfile_data): Remove.
7431         (_initialize_breakpoint): Update.
7432
7433 2019-05-08  Tom Tromey  <tom@tromey.com>
7434
7435         * linux-tdep.c (struct linux_info): Add initializers.
7436         (linux_inferior_data): Move.  Change type.
7437         (invalidate_linux_cache_inf): Update.
7438         (linux_inferior_data_cleanup): Remove.
7439         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7440
7441 2019-05-08  Tom Tromey  <tom@tromey.com>
7442
7443         * auxv.c (auxv_inferior_data): Move.  Change type.
7444         (auxv_inferior_data_cleanup): Remove.
7445         (invalidate_auxv_cache_inf): Rewrite.
7446         (get_auxv_inferior_data, _initialize_auxv): Update.
7447
7448 2019-05-08  Tom Tromey  <tom@tromey.com>
7449
7450         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7451         (symfile_debug_objfile_data_key): Change type.
7452         (symfile_debug_installed, debug_qf_has_symbols)
7453         (debug_qf_find_last_source_symtab)
7454         (debug_qf_forget_cached_source_info)
7455         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7456         (debug_qf_print_stats, debug_qf_dump)
7457         (debug_qf_expand_symtabs_for_function)
7458         (debug_qf_expand_all_symtabs)
7459         (debug_qf_expand_symtabs_with_fullname)
7460         (debug_qf_map_matching_symbols)
7461         (debug_qf_expand_symtabs_matching)
7462         (debug_qf_find_pc_sect_compunit_symtab)
7463         (debug_qf_map_symbol_filenames)
7464         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7465         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7466         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7467         (debug_sym_read_linetable, debug_sym_relocate): Update.
7468         (symfile_debug_free_objfile): Remove.
7469         (install_symfile_debug_logging, _initialize_symfile_debug):
7470         Update.
7471
7472 2019-05-08  Tom Tromey  <tom@tromey.com>
7473
7474         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7475         allocate_on_obstack.
7476         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7477         (get_dwarf2_per_objfile): Update.
7478         (set_dwarf2_per_objfile): Remove.
7479         (dwarf2_has_info, dwarf2_get_section_info): Update.
7480         (dwarf2_free_objfile): Remove.
7481         (_initialize_dwarf2_read): Update.
7482
7483 2019-05-08  Tom Tromey  <tom@tromey.com>
7484
7485         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7486         initializers.
7487         <unsupported_script_warning_printed,
7488         script_not_found_warning_printed>: Now bool.
7489         (auto_load_pspace_data): Change type.
7490         (~auto_load_pspace_info): Rename from
7491         auto_load_pspace_data_cleanup.
7492         (get_auto_load_pspace_data, init_loaded_scripts_info)
7493         (clear_section_scripts, maybe_print_unsupported_script_warning)
7494         (maybe_print_script_not_found_warning, _initialize_auto_load):
7495         Update.
7496
7497 2019-05-08  Tom Tromey  <tom@tromey.com>
7498
7499         * objfiles.c (objfile_pspace_info): Add destructor and
7500         initializers.
7501         (objfiles_pspace_data): Change type.
7502         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7503         (get_objfile_pspace_data): Update.
7504         (objfiles_bfd_data): Change type.
7505         (get_objfile_bfd_data): Update.
7506         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7507
7508 2019-05-08  Tom Tromey  <tom@tromey.com>
7509
7510         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7511         Change type.
7512         (get_catch_syscall_inferior_data): Update.
7513         (catch_syscall_inferior_data_cleanup): Remove.
7514         (_initialize_break_catch_syscall): Update.
7515
7516 2019-05-08  Tom Tromey  <tom@tromey.com>
7517
7518         * inflow.c (struct terminal_info): Add destructor and
7519         initializers.
7520         (inflow_inferior_data): Change type.
7521         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7522         (get_inflow_inferior_data, inflow_inferior_exit)
7523         (swap_terminal_info, _initialize_inflow): Update.
7524
7525 2019-05-08  Tom Tromey  <tom@tromey.com>
7526
7527         * target-dcache.c (target_dcache_cleanup): Remove.
7528         (target_dcache_aspace_key): Change type.
7529         (target_dcache_init_p, target_dcache_invalidate)
7530         (target_dcache_get, target_dcache_get_or_init)
7531         (_initialize_target_dcache): Update.
7532         * dcache.h (struct dcache_deleter): New.
7533
7534 2019-05-08  Tom Tromey  <tom@tromey.com>
7535
7536         * symtab.c (struct symbol_cache): Add destructor and
7537         initializers.
7538         (symbol_cache_key): Move.  Change type.
7539         (make_symbol_cache, free_symbol_cache): Remove.
7540         (get_symbol_cache): Update.
7541         (symbol_cache_cleanup): Remove.
7542         (ALL_PSPACES, symbol_cache_flush)
7543         (maintenance_print_symbol_cache)
7544         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7545         Update.
7546
7547 2019-05-08  Tom Tromey  <tom@tromey.com>
7548
7549         * symtab.c (struct main_info): Add destructor and initializers.
7550         (main_progspace_key): Move.  Change type.
7551         (get_main_info): Update.
7552         (main_info_cleanup): Remove.
7553         (_initialize_symtab): Update.
7554
7555 2019-05-08  Tom Tromey  <tom@tromey.com>
7556
7557         * registry.h (DECLARE_REGISTRY): Define the _key class.
7558
7559 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7560
7561         * NEWS: Merge two 'New commands' sections.
7562
7563 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7564
7565         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7566         parameter and use Ada language definition instead.
7567         (ada_val_print_ptr): Remove unused language parameter.
7568         (ada_val_print_num): Remove language parameter and use Ada language
7569         definition instead.
7570         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7571         parameter.
7572         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7573         parameter and use Ada language definition instead.
7574         (ada_val_print_1): Update all ada_val_print_xxx calls.
7575         Remove language parameter.
7576         (ada_val_print): Update ada_val_print_1 call.
7577
7578 2019-05-08  Tom Tromey  <tromey@adacore.com>
7579
7580         * remote.c (remote_hw_watchpoint_limit)
7581         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7582         Now static.
7583
7584 2019-05-08  Tom Tromey  <tromey@adacore.com>
7585
7586         * maint.c (_initialize_maint_cmds): Move initialization code to
7587         remote.c.
7588         (watchdog, show_watchdog): Move to remote.c.
7589         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7590         "watchdog" static.
7591         (_initialize_remote): Move initialization code from maint.c.
7592         * defs.h (watchdog): Don't declare.
7593
7594 2019-05-08  Tom Tromey  <tromey@adacore.com>
7595
7596         * tui/tui-interp.c: Include main.h.
7597         * interps.c: Include main.h.
7598         * main.h (interpreter_p): Declare.
7599         * defs.h (interpreter_p): Don't declare.
7600
7601 2019-05-08  Tom Tromey  <tromey@adacore.com>
7602
7603         * dwarf2loc.c: Include dwarf2read.h.
7604         * defs.h (read_unsigned_leb128): Don't declare.
7605         * dwarf2read.h (read_unsigned_leb128): Declare.
7606
7607 2019-05-08  Tom Tromey  <tromey@adacore.com>
7608
7609         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7610         method.
7611
7612 2019-05-08  Tom Tromey  <tromey@adacore.com>
7613
7614         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7615         when no wrap column is set.
7616
7617 2019-05-08  Tom Tromey  <tromey@adacore.com>
7618
7619         * c-lang.c (c_get_string): Handle non-C-style arrays.
7620
7621 2019-05-08  Tom Tromey  <tromey@adacore.com>
7622
7623         * typeprint.c (print_offset_data::update): Print the bit offset,
7624         not the number of bits remaining.
7625
7626 2019-05-08  Tom Tromey  <tromey@adacore.com>
7627
7628         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7629         padding at end of comment.
7630
7631 2019-05-08  Tom Tromey  <tromey@adacore.com>
7632
7633         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7634         Compare main types.
7635
7636 2019-05-06  Tom Tromey  <tom@tromey.com>
7637
7638         * common/scoped_mmap.c: Include common-defs.h.
7639         * common/scoped_mmap.h: Don't include config.h.
7640
7641 2019-05-04  Tom Tromey  <tom@tromey.com>
7642
7643         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7644         (struct aarch64_call_info): Add initializers.
7645         <si>: Now a std::vector.
7646         (pass_on_stack, aarch64_push_dummy_call): Update.
7647
7648 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7649             Tom Tromey  <tom@tromey.com>
7650
7651         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7652         (ppc_threads): Now a std::vector.  Now static.
7653         (hwdebug_find_thread_points_by_tid)
7654         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7655         Update.
7656
7657 2019-05-04  Tom Tromey  <tom@tromey.com>
7658
7659         * arc-tdep.c (arc_tdesc_init): Return bool.
7660
7661 2019-05-04  Tom Tromey  <tom@tromey.com>
7662
7663         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7664         Use gdb_assert_not_reached.
7665
7666 2019-05-04  Tom Tromey  <tom@tromey.com>
7667
7668         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7669         "false".
7670
7671 2019-05-04  Tom Tromey  <tom@tromey.com>
7672
7673         * arc-tdep.c (arc_tdesc_init): Use bool.
7674
7675 2019-05-04  Tom Tromey  <tom@tromey.com>
7676
7677         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7678
7679 2019-05-04  Tom Tromey  <tom@tromey.com>
7680
7681         * cli/cli-cmds.c (valid_command_p): Return bool.
7682
7683 2019-05-04  Tom Tromey  <tom@tromey.com>
7684
7685         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7686         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7687
7688 2019-05-04  Raul Tambre  <raul@tambre.ee>
7689
7690         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7691         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7692         operator for comparison.
7693
7694 2019-05-04  Tom Tromey  <tom@tromey.com>
7695
7696         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7697         (lookup_partial_symbol, print_partial_symbols)
7698         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7699         (psymbol_compare): Update.
7700         (add_psymbol_to_bcache): Clear the entire psymbol.
7701         (maintenance_check_psymtabs): Update.
7702         * psympriv.h (struct partial_symbol): Don't derive from
7703         general_symbol_info.
7704         <obj_section, unrelocated_address, address,
7705         set_unrelocated_address>: Update.
7706         <ginfo>: New member.
7707         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7708         (debug_names::write_psymbols): Update.
7709
7710 2019-05-04  Tom de Vries  <tdevries@suse.de>
7711
7712         * contrib/cc-with-tweaks.sh: Support -n arg.
7713
7714 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7715
7716         * corelow.c (core_target::detach): Ensure frame cache and
7717         register caches are cleared.
7718         inferior.c (exit_inferior_1): Likewise.
7719
7720 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7721             Tom Tromey  <tom@tromey.com>
7722
7723         * dictionary.c (collate_pending_symbols_by_language): Remove
7724         "struct" from foreach.
7725         * symtab.c (lookup_global_symbol_from_objfile)
7726         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7727         foreach.
7728         * ser-tcp.c (net_open): Remove "struct" from foreach.
7729         * objfiles.c (objfile_relocate, objfile_rebase)
7730         (objfile_has_symbols): Remove "struct" from foreach.
7731         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7732         from foreach.
7733         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7734         foreach.
7735         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7736         "struct" from foreach.
7737         * ada-lang.c (create_excep_cond_exprs)
7738         (ada_exception_catchpoint_cond_string): Remove "struct" from
7739         foreach.
7740
7741 2019-05-03  Tom Tromey  <tromey@adacore.com>
7742
7743         * ada-exp.y (convert_char_literal): Check suffix of each
7744         enumerator.
7745
7746 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7747
7748         PR ada/21406:
7749         * ada-exp.y (yywrap): Don't define.
7750         * ada-lex.l (%option): Add noyywrap
7751         (yywrap): Remove.
7752
7753 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7754
7755         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7756         _WIN32_WINNT to the XP level, unless already defined to a higher
7757         level.
7758
7759         * unittests/parse-connection-spec-selftests.c:
7760         * ser-tcp.c:
7761         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7762         override.
7763
7764         * symfile.c (find_separate_debug_file): Remove colon from the
7765         drive spec of DOS/Windows file names of the target, so that the
7766         file name produced from DEBUGDIR and the target's directory will
7767         be valid on DOS/Windows systems.
7768
7769 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * rust-lang.c (val_print_struct): Handle printing structures
7772         containing strings.
7773
7774 2019-05-02  Tom Tromey  <tromey@adacore.com>
7775
7776         * valarith.c (_initialize_valarith): Remove.
7777
7778 2019-05-01  Tom Tromey  <tromey@adacore.com>
7779
7780         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7781         bitfields.
7782
7783 2019-05-01  Tom Tromey  <tromey@adacore.com>
7784
7785         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7786         for big-endian copies.
7787
7788 2019-04-30  Ali Tamur  <tamur@google.com>
7789         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7790         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7791         (read_3_bytes): New function.
7792
7793 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7794
7795         * windows-nat.c (main_thread_id): Delete.
7796         (handle_output_debug_string): Replace main_thread_id by
7797         current_event.dwThreadId.
7798         (fake_create_process): Likewise.
7799         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7800         Do not set main_thread_id.
7801         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7802         current_event.dwThreadId.
7803         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7804
7805 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7806
7807         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7808         Use current_event.dwThreadId instead of main_thread_id.
7809
7810 2019-04-30  Tom Tromey  <tromey@adacore.com>
7811
7812         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7813         (create_excep_cond_exprs): Iterate over program spaces.
7814         (ada_exception_catchpoint_cond_string): Examine all minimal
7815         symbols for exception types.
7816
7817 2019-04-30  Tom Tromey  <tromey@adacore.com>
7818
7819         PR c++/24470:
7820         * dwarf2read.c (process_structure_scope): Handle case where type
7821         has template parameters but no symbol was created.
7822
7823 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7824             Chris January  <chris.january@arm.com>
7825
7826         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7827         qualifier.
7828         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7829
7830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * f-typeprint.c (f_print_type): Update rules for printing
7833         whitespace.
7834         (f_type_print_varspec_suffix): Likewise.
7835
7836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7837             Chris January  <chris.january@arm.com>
7838
7839         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7840         function arguments.
7841
7842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * f-lang.c (build_fortran_types): Change name of void type to
7845         lower case.
7846         * f-typeprint.c (f_type_print_base): Print the name of the void
7847         type, rather than a fixed string.
7848         * f-valprint.c (f_decorations): Use lower case void string.
7849
7850 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7851             Chris January  <chris.january@arm.com>
7852
7853         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7854         types for Fortran.
7855
7856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7857             Chris January  <chris.january@arm.com>
7858             David Lecomber  <david.lecomber@arm.com>
7859
7860         * f-exp.y (BINOP_INTRINSIC): New token.
7861         (exp): New parser rule handling BINOP_INTRINSIC.
7862         (f77_keywords): Add new builtin procedures.
7863         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7864         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7865         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7866         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7867         (print_unop_subexp_f): New function.
7868         (print_binop_subexp_f): New function.
7869         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7870         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7871         (dump_subexp_body_f): Likewise.
7872         (operator_check_f): Likewise.
7873         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7874         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7875
7876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7877
7878         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7879         UNOP_KIND.
7880         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7881         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7882         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7883         (operator_length_f): New fuction.
7884         (print_subexp_f): New function.
7885         (op_name_f): New function.
7886         (dump_subexp_body_f): New function.
7887         (operator_check_f): New function.
7888         (exp_descriptor_f): Replace standard expression handling functions
7889         with new functions.
7890         * gdb/fortran-operator.def: New file.
7891         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7892         * gdb/std-operator.def: Remove UNOP_KIND.
7893
7894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7895
7896         * std-operator.def: Remove unbalanced, stray double quote
7897         character.
7898
7899 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7900             Chris January  <chris.january@arm.com>
7901             Daniel Everett  <daniel.everett@arm.com>
7902             Nick Forrington  <nick.forrington@arm.com>
7903             Richard Bunt  <richard.bunt@arm.com>
7904
7905         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7906         of depth when printing anonymous structs or unions.
7907         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7908         Don't print either the top-level value, or the children if the
7909         max-depth is exceeded.
7910         (ppscm_print_children): When printing the key of a map, allow one
7911         extra level of depth.
7912         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7913         print either the top-level value, or the children if the max-depth
7914         is exceeded.
7915         (print_children): When printing the key of a map, allow one extra
7916         level of depth.
7917         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7918         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7919         (user_print_options): Initialise max_depth field.
7920         (val_print_scalar_or_string_type_p): New function.
7921         (val_print): Check to see if the max depth has been reached.
7922         (val_print_check_max_depth): Define new function.
7923         (show_print_max_depth): New function.
7924         (_initialize_valprint): Add 'print max-depth' option.
7925         * valprint.h (struct value_print_options) <max_depth>: New field.
7926         (val_print_check_max_depth): Declare new function.
7927         * NEWS: Document new feature.
7928
7929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7930
7931         * ada-lang.c (ada_language_defn): Initialise new field.
7932         * c-lang.c (c_is_string_type_p): New function.
7933         (c_language_defn): Initialise new field.
7934         (cplus_language_defn): Initialise new field.
7935         (asm_language_defn): Initialise new field.
7936         (minimal_language_defn): Initialise new field.
7937         * c-lang.h (c_is_string_type_p): Declare new function.
7938         * d-lang.c (d_language_defn): Initialise new field.
7939         * f-lang.c (f_is_string_type_p): New function.
7940         (f_language_defn): Initialise new field.
7941         * go-lang.c (go_is_string_type_p): New function.
7942         (go_language_defn): Initialise new field.
7943         * language.c (default_is_string_type_p): New function.
7944         (unknown_language_defn): Initialise new field.
7945         (auto_language_defn): Initialise new field.
7946         * language.h (struct language_defn) <la_is_string_type_p>: New
7947         member variable.
7948         (default_is_string_type_p): Declare new function.
7949         * m2-lang.c (m2_language_defn): Initialise new field.
7950         * objc-lang.c (objc_language_defn): Initialise new field.
7951         * opencl-lang.c (opencl_language_defn): Initialise new field.
7952         * p-lang.c (pascal_is_string_type_p): New function.
7953         (pascal_language_defn): Initialise new field.
7954         * rust-lang.c (rust_is_string_type_p): New function.
7955         (rust_language_defn): Initialise new field.
7956
7957 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7958
7959         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7960         New field.
7961         * ada-lang.c (ada_language_defn): Initialise new field.
7962         * c-lang.c (c_language_defn): Likewise.
7963         (cplus_language_defn): Likewise.
7964         (asm_language_defn): Likewise.
7965         (minimal_language_defn): Likewise.
7966         * d-lang.c (d_language_defn): Likewise.
7967         * f-lang.c (f_language_defn): Likewise.
7968         * go-lang.c (go_language_defn): Likewise.
7969         * language.c (unknown_language_defn): Likewise.
7970         (auto_language_defn): Likewise.
7971         * m2-lang.c (m2_language_defn): Likewise.
7972         * objc-lang.c (objc_language_defn): Likewise.
7973         * opencl-lang.c (opencl_language_defn): Likewise.
7974         * p-lang.c (pascal_language_defn): Likewise.
7975         * rust-lang.c (rust_language_defn): Likewise.
7976
7977 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7978
7979         * ada-lang.c (ada_is_character_type): Change return type to bool.
7980         (ada_is_string_type): Likewise.
7981         * ada-lang.h (ada_is_character_type): Update declaration
7982         (ada_is_string_type): Likewise.
7983
7984 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7985
7986         Support style in 'frame|thread apply'
7987
7988         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7989         * record.c (record_start, record_stop): Update callers of
7990         execute_command_to_string with false.
7991         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7992         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7993         methods.
7994         (class string_file): New constructor with term_out parameter.
7995         Override methods term_out and can_emit_style_escape.  New member
7996         term_out.
7997         (class stdio_file): Override can_emit_style_escape.
7998         (class tee_file): Override term_out and can_emit_style_escape.
7999         * utils.h (can_emit_style_escape): Remove.
8000         * utils.c (can_emit_style_escape): Likewise.
8001         Update all callers of can_emit_style_escape (SOMESTREAM) to
8002         SOMESTREAM->can_emit_style_escape.
8003         * source-cache.c (source_cache::get_source_lines): Likewise.
8004         * stack.c (frame_apply_command_count): Call execute_command_to_string
8005         passing the term_out characteristic of the current gdb_stdout.
8006         * thread.c (thr_try_catch_cmd): Likewise.
8007         * top.c (execute_command_to_string): pass term_out parameter
8008         to construct the string_file for the command output.
8009         * ui-file.c (term_cli_styling): New function (most code moved
8010         from utils.c can_emit_style_escape).
8011         (string_file::string_file, string_file::can_emit_style_escape,
8012         stdio_file::can_emit_style_escape, tee_file::term_out,
8013         tee_file::can_emit_style_escape): New functions.
8014
8015 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8016
8017         * NEWS: Mention the new set|show may-call-functions.
8018         * infcall.c (may_call_functions_p): New variable.
8019         (show_may_call_functions_p): New function.
8020         (call_function_by_hand_dummy): Throws an error if not
8021         may-call-functions.
8022         (_initialize_infcall): Call add_setshow_boolean_cmd for
8023         may-call-functions.
8024
8025 2019-04-25  Keith Seitz  <keiths@redhat.com>
8026
8027         PR c++/24367
8028         * cp-support.c (inspect_type): Don't attempt substitutions
8029         of symbol with the same name.
8030
8031 2019-04-25  Tom Tromey  <tromey@adacore.com>
8032
8033         PR gdb/24475:
8034         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8035         static.
8036
8037 2019-04-25  Tom Tromey  <tromey@adacore.com>
8038
8039         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8040         rvalue reference.
8041         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8042         (gdb_xml_parser::parse): Use std::move.
8043         * python/python-internal.h (gdbpy_convert_exception): Take a const
8044         reference.
8045         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8046         std::move.
8047         * python/py-utils.c (gdbpy_convert_exception): Take a const
8048         reference.
8049         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8050         Use std::move.
8051         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8052         Use std::move.
8053         * mi/mi-main.c (mi_print_exception): Take a const reference.
8054         * main.c (handle_command_errors): Take a const reference.
8055         * linespec.c (parse_linespec): Use std::move.
8056         * infcall.c (run_inferior_call): Use std::move.
8057         (call_function_by_hand_dummy): Use std::move.
8058         * exec.c (try_open_exec_file): Use std::move.
8059         * exceptions.h (exception_print, exception_fprintf)
8060         (exception_print_same): Update.
8061         * exceptions.c (print_exception, exception_print)
8062         (exception_fprintf, exception_print_same): Change parameters to
8063         const reference.
8064         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8065         * common/new-op.c: Use std::move.
8066         * common/common-exceptions.h (struct gdb_exception): Add move
8067         constructor.
8068         (struct gdb_exception_error, struct gdb_exception_quit, struct
8069         gdb_quit_bad_alloc): Change constructor to move constructor.
8070         (throw_exception): Change parameter to rvalue reference.
8071         * common/common-exceptions.c (throw_exception): Take rvalue
8072         reference.
8073         * cli/cli-interp.c (safe_execute_command): Use std::move.
8074         * breakpoint.c (insert_bp_location, location_to_sals): Use
8075         std::move.
8076
8077 2019-04-25  Tom Tromey  <tromey@adacore.com>
8078
8079         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8080         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8081         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8082         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8083         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8084         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8085         guile/scm-value.c: Use unpack.
8086         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8087         gdbscm_gdb_exception.
8088         (gdbscm_throw_gdb_exception): Likewise.
8089         (struct gdbscm_gdb_exception): New.
8090         (unpack): New function.
8091         (gdbscm_wrap): Use unpack.
8092
8093 2019-04-25  Tom Tromey  <tromey@adacore.com>
8094
8095         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8096         (gdb_rl_callback_handler): Use std::move.
8097         * common/common-exceptions.h (struct gdb_exception): Add move
8098         assignment operator.
8099         (throw_exception_sjlj): Change "exception" to const reference.
8100         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8101         (throw_exception_sjlj): Change "exception" to const reference.
8102
8103 2019-04-25  Tom Tromey  <tromey@adacore.com>
8104
8105         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8106         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8107         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8108         Update.
8109         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8110         Update.
8111         * mi/mi-interp.c (mi_interp::exec): Update.
8112         * linespec.c (parse_linespec): Update.
8113         * infcall.c (run_inferior_call): Update.
8114         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8115         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8116         (gdbscm_lookup_global_symbol): Update.
8117         * guile/scm-param.c (gdbscm_parameter_value): Update.
8118         * guile/scm-frame.c (gdbscm_frame_read_register)
8119         (gdbscm_frame_read_var): Update.
8120         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8121         * exec.c (try_open_exec_file): Update.
8122         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8123         (gdb_rl_callback_handler): Update.
8124         * common/common-exceptions.h (exception_none): Don't declare.
8125         * common/common-exceptions.c (exception_none): Don't define.
8126         (struct catcher) <exception>: Update.
8127         * cli/cli-interp.c (safe_execute_command): Update.
8128         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8129
8130 2019-04-25  Ali Tamur  <tamur@google.com>
8131
8132         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8133         (read_attribute_value): Likewise.
8134         (dwarf2_read_addr_index): Update comment.
8135         (read_str_index): Add DW_FORM_strx.
8136         (dwarf2_string_attr): Likewise.
8137         (dwarf2_const_value_attr): Likewise.
8138         (dump_die_shallow): Likewise.
8139         (dwarf2_fetch_constant_bytes): Likewise.
8140         (skip_form_bytes): Likewise.
8141         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8142
8143 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8144
8145         PR corefiles/11608
8146         PR corefiles/18187
8147         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8148         OFFSET.  Verify if current mapping contains an ELF header.
8149         (linux_find_memory_regions_full): Adjust call to
8150         dump_mapping_p.
8151
8152 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8153             Kang Li <kanglictf@gmail.com>
8154
8155         PR gdb/21600
8156
8157         * dwarf2-frame.c (read_initial_length): Be consistent about using
8158         unsigned representation of length.
8159         (decode_frame_entry_1): Likewise.  Check for wraparound of
8160         end pointer as well as buffer overflow.
8161
8162 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8163
8164         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8165         "vq".
8166
8167 2019-04-24  Tom Tromey  <tromey@adacore.com>
8168
8169         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8170
8171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * s12z-tdep.c (s12z_unwind_pc): Delete.
8174         (s12z_unwind_sp): Delete.
8175         (s12z_gdbarch_init): Don't register deleted functions with
8176         gdbarch.
8177
8178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8179
8180         * rl78-tdep.c (rl78_unwind_sp): Delete.
8181         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8182
8183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8184
8185         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8186         (xstormy16_unwind_pc): Delete.
8187         (xstormy16_dummy_id): Delete.
8188         (xstormy16_gdbarch_init): Don't register deleted functions with
8189         gdbarch.
8190
8191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8192
8193         * vax-tdep.c (vax_unwind_pc): Delete.
8194         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8195
8196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8197
8198         * v850-tdep.c (v850_unwind_sp): Delete.
8199         (v850_unwind_pc): Delete.
8200         (v850_dummy_id): Delete.
8201         (v850_gdbarch_init): Don't register deleted functions with
8202         gdbarch.
8203
8204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8205
8206         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8207         (tilegx_unwind_pc): Delete.
8208         (tilegx_unwind_dummy_id): Delete.
8209         (tilegx_gdbarch_init): Don't register deleted functions with
8210         gdbarch.
8211
8212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8213
8214         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8215         (tic6x_dummy_id): Delete.
8216         (tic6x_gdbarch_init): Don't register deleted functions with
8217         gdbarch.
8218
8219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8220
8221         * sparc-tdep.c (sparc_unwind_pc): Delete.
8222         (sparc32_gdbarch_init): Don't register deleted function with
8223         gdbarch.
8224
8225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8226
8227         * sh-tdep.c (sh_unwind_sp): Delete.
8228         (sh_unwind_pc): Delete.
8229         (sh_dummy_id): Delete.
8230         (sh_gdbarch_init): Don't register deleted functions with
8231         gdbarch.
8232
8233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8234
8235         * score-tdep.c (score_unwind_sp): Delete.
8236         (score_unwind_pc): Delete.
8237         (score_dummy_id): Delete.
8238         (score_gdbarch_init): Don't register deleted functions with
8239         gdbarch.
8240
8241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8242
8243         * rx-tdep.c (rx_unwind_pc): Delete.
8244         (rx_unwind_sp): Delete.
8245         (rx_dummy_id): Delete.
8246         (rx_gdbarch_init): Don't register deleted functions with
8247         gdbarch.  Update comment.
8248
8249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8250
8251         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8252         (rs6000_dummy_id): Delete.
8253         (rs6000_gdbarch_init): Don't register deleted functions with
8254         gdbarch.
8255
8256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8257
8258         * or1k-tdep.c (or1k_dummy_id): Delete.
8259         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8260
8261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8262
8263         * nios2-tdep.c (nios2_dummy_id): Delete.
8264         (nios2_unwind_sp): Delete.
8265         (nios2_gdbarch_init): Don't register deleted functions with
8266         gdbarch.
8267
8268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8269
8270         * nds32-tdep.c (nds32_dummy_id): Delete.
8271         (nds32_unwind_pc): Delete.
8272         (nds32_unwind_sp): Delete.
8273         (nds32_gdbarch_init): Don't register deleted functions with
8274         gdbarch.
8275
8276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8277
8278         * msp430-tdep.c (msp430_unwind_pc): Delete.
8279         (msp430_unwind_sp): Delete.
8280         (msp430_dummy_id): Delete.
8281         (msp430_gdbarch_init): Don't register deleted functions with
8282         gdbarch.
8283
8284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8285
8286         * moxie-tdep.c (moxie_unwind_sp): Delete.
8287         (moxie_unwind_pc): Delete.
8288         (moxie_dummy_id): Delete.
8289         (moxie_gdbarch_init): Don't register deleted functions with
8290         gdbarch.
8291
8292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8293
8294         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8295         (mn10300_unwind_pc): Delete.
8296         (mn10300_unwind_sp): Delete.
8297         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8298         mn10300_unwind_sp.
8299         (mn10300_frame_unwind_init): Don't register deleted functions with
8300         gdbarch.
8301
8302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8303
8304         * mep-tdep.c (mep_unwind_pc): Delete.
8305         (mep_unwind_sp): Delete.
8306         (mep_dummy_id): Delete.
8307         (mep_gdbarch_init): Don't register deleted functions with
8308         gdbarch.
8309
8310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8311
8312         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8313         (m68hc11_unwind_sp): Delete.
8314         (m68hc11_gdbarch_init): Don't register deleted functions with
8315         gdbarch.
8316
8317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8318
8319         * m32r-tdep.c (m32r_unwind_sp): Delete.
8320         (m32r_unwind_pc): Delete.
8321         (m32r_dummy_id): Delete.
8322         (m32r_gdbarch_init): Don't register deleted functions with
8323         gdbarch.
8324
8325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8326
8327         * m32c-tdep.c (m32c_unwind_pc): Delete.
8328         (m32c_unwind_sp): Delete.
8329         (m32c_dummy_id): Delete.
8330         (m32c_gdbarch_init): Don't register deleted functions with
8331         gdbarch.
8332
8333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8334
8335         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8336         (lm32_unwind_pc): Delete.
8337         (lm32_dummy_id): Delete.
8338         (lm32_gdbarch_init): Don't register deleted functions with
8339         gdbarch.
8340
8341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8342
8343         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8344         (iq2000_unwind_pc): Delete.
8345         (iq2000_dummy_id): Delete.
8346         (iq2000_gdbarch_init): Don't register deleted functions with
8347         gdbarch.
8348
8349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8350
8351         * nds32-tdep.c (nds32_type_align): Delete.
8352         (nds32_push_dummy_call): Use type_align instead.
8353
8354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8355
8356         * arm-tdep.c (arm_type_align): Only handle vector override case.
8357         (arm_push_dummy_call): Use type_align.
8358         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8359
8360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8363         case.
8364         (pass_on_stack): Use type_align.
8365         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8366         function.
8367
8368 2019-04-23  Tom Tromey  <tromey@adacore.com>
8369
8370         * dwarf2read.c (line_header::file_name_at): Remove unused
8371         overload.
8372
8373 2019-04-23  Tom de Vries  <tdevries@suse.de>
8374
8375         PR gdb/24438
8376         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8377         invocation.
8378
8379
8380 2019-03-27  Ali Tamur  <tamur@google.com>
8381
8382         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8383         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8384         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8385         (dwarf_expr_context::get_addr_index): Likewise
8386         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8387         (symbol_needs_eval_context::get_addr_index): Likewise
8388         (disassemble_dwarf_expression): Add DW_OP_addrx
8389         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8390         (read_cutu_die_from_dwo): Update comment
8391         (skip_one_die): Add DW_FORM_addrx
8392         (read_attribute_value): Likewise
8393         (var_decode_location): Add DW_OP_addrx
8394         (dwarf2_const_value_attr): Add DW_FORM_addrx
8395         (dump_die_shallow): Likewise
8396         (dwarf2_fetch_constant_bytes): Likewise
8397         (decode_locdesc): Add DW_OP_addrx
8398         (skip_form_bytes): Add DW_FORM_addrx
8399
8400 2019-04-22  Ali Tamur  <tamur@google.com>
8401
8402         * MAINTAINERS (Write After Approval): Add self.
8403
8404 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8405
8406         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8407         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8408         (open_symbol_file_object): Likewise.
8409         (svr4_default_sos): Add info parameter.
8410         (svr4_read_so_list): Likewise.
8411         (svr4_current_sos_direct): Adjust functions calls to pass down
8412         info.
8413         (svr4_current_sos_1): Add info parameter.
8414         (svr4_current_sos): Call get_svr4_info, pass info down to
8415         svr4_current_sos_1.
8416         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8417         get_svr4_info.
8418         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8419         get_svr4_info.
8420         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8421         to get_svr4_info.
8422         (probes_table_remove_objfile_probes): Likewise.
8423         (register_solib_event_probe): Add info parameter.
8424         (solist_update_incremental): Pass info parameter down to
8425         svr4_read_so_list.
8426         (disable_probes_interface): Add info parameter.
8427         (svr4_handle_solib_event): Pass current_program_space to
8428         get_svr4_info.  Adjust disable_probes_interface cleanup.
8429         (svr4_create_probe_breakpoints): Add info parameter, pass it
8430         down to register_solib_event_probe.
8431         (svr4_create_solib_event_breakpoints): Add info parameter,
8432         pass it down to svr4_create_probe_breakpoints.
8433         (enable_break): Pass info down to
8434         svr4_create_solib_event_breakpoints.
8435         (svr4_solib_create_inferior_hook): Pass current_program_space to
8436         get_svr4_info.
8437         (svr4_clear_solib): Likewise.
8438
8439 2019-04-22  Pedro Alves  <palves@redhat.com>
8440
8441         * solib-svr4.c (svr4_free_objfile_observer): New.
8442         (probe_and_action::objfile): New field.
8443         (probes_table_htab_remove_objfile_probes)
8444         (probes_table_remove_objfile_probes): New functions.
8445         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8446         in the new probe_and_action.  Don't store the probe in 'lookup'.
8447         (svr4_create_probe_breakpoints): Pass objfile to
8448         register_solib_event_probe.
8449         (_initialize_svr4_solib): Register a free_objfile observer.
8450
8451 2019-04-19  Tom Tromey  <tom@tromey.com>
8452
8453         * common/queue.h: Remove.
8454
8455 2019-04-19  Tom Tromey  <tom@tromey.com>
8456
8457         * event-loop.c: Don't include "common/queue.h".
8458
8459 2019-04-19  Tom Tromey  <tom@tromey.com>
8460
8461         * remote.c (remote_target): Use delete.
8462         * remote-notif.h: Include <list>, not "common/queue.h".
8463         (notif_client_p): Remove typedef.
8464         (remote_notif_state): Add constructor, destructor, initializer.
8465         <notif_queue>: Now a std::list.
8466         (remote_notif_state_xfree): Don't declare.
8467         * remote-notif.c (remote_notif_process, handle_notification)
8468         (remote_notif_state_allocate): Update.
8469         (~remote_notif_state): Rename from remote_notif_state_xfree.
8470
8471 2019-04-19  Tom Tromey  <tom@tromey.com>
8472
8473         * symfile.c (reread_symbols): Update.
8474         * objfiles.c (objfile_register_static_link)
8475         (objfile_lookup_static_link): Update
8476         (~objfile) Don't delete static_links.
8477         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8478
8479 2019-04-19  Tom Tromey  <tom@tromey.com>
8480
8481         * type-stack.h (struct type_stack) <insert>: Constify string.
8482         * type-stack.c (type_stack::insert): Constify string.
8483         * gdbtypes.h (lookup_template_type): Update.
8484         (address_space_name_to_int): Update.
8485         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8486         const.
8487         (lookup_template_type): Make name const.
8488         * c-exp.y: Update rules.
8489         (lex_one_token, classify_name, classify_inner_name)
8490         (c_print_token): Update.
8491         * p-exp.y: Update rules.
8492         (yylex): Update.
8493         * f-exp.y: Update rules.
8494         (yylex): Update.
8495         * d-exp.y: Update rules.
8496         (lex_one_token, classify_name, classify_inner_name): Update.
8497         * parse.c (write_dollar_variable, copy_name): Return std::string.
8498         * parser-defs.h (copy_name): Change return type.
8499         * m2-exp.y: Update rules.
8500         (yylex): Update.
8501         * go-exp.y (lex_one_token): Update.
8502         Update rules.
8503         (classify_unsafe_function, classify_packaged_name)
8504         (classify_name, yylex): Update.
8505
8506 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8507
8508         * configure.ac: add --enable-source-highlight switch.
8509         * configure: Regenerate.
8510         * top.c (print_gdb_version): plumb --enable-source-highlight
8511         status to "show configuration".
8512
8513 2019-04-19  Tom Tromey  <tromey@adacore.com>
8514
8515         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8516         Check ADA_TYPE_P.
8517         (empty_record, ada_template_to_fixed_record_type_1)
8518         (template_to_static_fixed_type)
8519         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8520         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8521         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8522         macros.
8523
8524 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8525
8526         PR symtab/24423:
8527         * source.c (print_source_lines_base): Advance "iter" when a
8528         control character is seen.
8529
8530 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8531
8532         * inferior.h (struct infcall_suspend_state_deleter):
8533         Catch exception in destructor to avoid crash.
8534
8535 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8536
8537         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8538         close to the add_com "shell".
8539
8540 2019-04-18  Tom Tromey  <tromey@adacore.com>
8541
8542         * process-stratum-target.h (class process_stratum_target)
8543         <stratum>: Add "final".
8544
8545 2019-04-17  Tom Tromey  <tromey@adacore.com>
8546
8547         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8548         against nullptr before use.
8549
8550 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8551
8552         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8553
8554 2019-04-17  Jim Wilson  <jimw@sifive.com>
8555             Andrew Burgess  <andrew.burgess@embecosm.com>
8556
8557         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8558         code read might fail, assume 4-byte breakpoint in that case.
8559
8560 2019-04-15  Leszek Swirski  <leszeks@google.com>
8561
8562         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8563         rather than a hand-rolled POD check when checking for forced MEMORY
8564         classification.
8565
8566 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8567
8568         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8569         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8570         function.
8571         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8572         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8573         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8574         declaration.
8575
8576 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8577
8578         * aarch64-linux-nat.c
8579         (aarch64_linux_nat_target::thread_architecture): Add override.
8580         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8581         each VQ.
8582
8583 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8584
8585         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8586
8587 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8588
8589         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8590         target types of size 96-bits, add some additional comments, and
8591         check that the builtin type we found was the correct size.
8592
8593 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8594
8595         * utils.c (prompt_for_continue): Don't restore the styling at the
8596         end, as applied_style has the wrong value.  This fixes styling in
8597         long lists of file names that are interrupted by the "Continue?"
8598         prompt.
8599
8600 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8601
8602         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8603         * c-lang.c (c_language_defn): Likewise.
8604         (cplus_language_defn): Likewise.
8605         (asm_language_defn): Likewise.
8606         (minimal_language_defn): Likewise.
8607         * d-lang.c (d_language_defn): Likewise.
8608         * f-lang.c (f_language_defn): Likewise.
8609         * go-lang.c (go_language_defn): Likewise.
8610         * language.c (unknown_language_defn): Likewise.
8611         (auto_language_defn): Likewise.
8612         * language.h (struct language_defn): Remove la_magic field.
8613         (LANG_MAGIC): Delete.
8614         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8615         * objc-lang.c (objc_language_defn): Likewise.
8616         * opencl-lang.c (opencl_language_defn): Likewise.
8617         * p-lang.c (pascal_language_defn): Likewise.
8618         * rust-lang.c (rust_language_defn): Likewise.
8619
8620 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8621
8622         * riscv-tdep.c (riscv_type_align): New function.
8623         (riscv_type_alignment): Delete.
8624         (riscv_arg_location): Use 'type_align'.
8625         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8626
8627 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8628
8629         * gdbtypes.c (type_align): A struct with no non-static fields also
8630         has alignment of 1.
8631
8632 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8633
8634         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8635         component to 0.
8636         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8637         member.
8638         (riscv_struct_info::analyse): New implementation using new
8639         analyse_inner member function.
8640         (riscv_struct_info::field_offset): New member function.
8641         (riscv_struct_info::m_offsets): New member variable.
8642         (riscv_struct_info::analyse_inner): New private member function,
8643         takes the old implementation of riscv_struct_info::analyse but
8644         extended to track field offsets.
8645         (riscv_call_arg_struct): Update the struct folding special cases
8646         to handle cases where empty C++ structs, which are non-zero
8647         length, are found.
8648         (riscv_arg_location): Initialise the length of each location, a
8649         non-zero length now indicates the location is in use.
8650         (riscv_push_dummy_call): Allow for the first location having a
8651         non-zero offset when setting up arguments.
8652         (riscv_return_value): Likewise, but for return values.
8653
8654 2019-04-11  Tom Tromey  <tromey@adacore.com>
8655
8656         * utils.c (internal_vproblem): Make "msg" const.
8657
8658 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8659
8660         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8661         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8662         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8663         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8664
8665 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8666
8667         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8668         function.
8669         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8670         of amd64_collect_native_gregset.
8671         (amd64_linux_nat_target::store_registers): Likewise.
8672
8673 2019-04-10  Tom Tromey  <tom@tromey.com>
8674
8675         * symtab.c (lookup_global_symbol_from_objfile)
8676         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8677         * objfiles.h (class separate_debug_iterator): New.
8678         (class separate_debug_range): New.
8679         (struct objfile) <separate_debug_objfiles>: New method.
8680         (objfile_separate_debug_iterate): Don't declare.
8681         * objfiles.c (separate_debug_iterator::operator++): Rename from
8682         objfile_separate_debug_iterate.
8683         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8684         iterator.
8685         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8686         iterator.
8687
8688 2019-04-10  Tom Tromey  <tom@tromey.com>
8689
8690         * symfile.c (reread_symbols): Remove old comment.
8691         * objfiles.c (free_all_objfiles): Fix a typo.
8692
8693 2019-04-10  Tom Tromey  <tom@tromey.com>
8694
8695         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8696         * minsyms.c (lookup_minimal_symbol): Use foreach.
8697         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8698         (lookup_minimal_symbol_solib_trampoline): Likewise.
8699         * symfile.c (reread_symbols): Use foreach.
8700
8701 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8702             Tom Tromey  <tromey@adacore.com>
8703
8704         PR rust/24414:
8705         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8706         (rust_lex_int_test): Change "value" to be LONGEST.
8707         (rust_lex_tests): Add test for long integer literal.
8708
8709 2019-04-09  Tom Tromey  <tromey@adacore.com>
8710
8711         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8712         to bool.
8713         (extended_remote_target::attach): Update.
8714         (remote_target::remote_notice_new_inferior): Update.
8715         (remote_target::add_current_inferior_and_thread): Update.
8716         * inferior.c (exit_inferior_1): Use "false".
8717         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8718
8719 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8720
8721         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8722         the "start" command.
8723
8724 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8725
8726         * python/py-inferior.c (infpy_thread_from_thread_handle):
8727         Adjust comments to reflect renaming of thread_from_thread_handle
8728         to thread_from_handle.  Adjust keywords.  Fix type error message.
8729         (inferior_object_methods): Add thread_from_handle.  Retain
8730         thread_from_thread_handle, but mark it as deprecated.
8731
8732 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8733
8734         * gdbthread.h (find_thread_by_handle): Revise declaration.
8735         * thread.c (find_thread_by_handle): Likewise.  Adjust
8736         implementation too.
8737         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8738         support for buffer objects as handles.
8739
8740 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8741
8742         * python/py-infthread.c (thpy_thread_handle): New function.
8743         (thread_object_methods): Register thpy_thread_handle.
8744
8745 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8746
8747         * gdbthread.h (thread_to_thread_handle): Declare.
8748         * thread.c (gdbtypes.h): Include.
8749         (thread_to_thread_handle): New function.
8750
8751         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8752         (target_thread_info_to_thread_handle): Declare.
8753         * target.c (target_thread_info_to_thread_handle): New function.
8754         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8755         * target-delegates.c: Regenerate.
8756
8757         * linux-thread-db.c (class thread_db_target): Add method
8758         thread_info_to_thread_handle.
8759         (thread_db_target::thread_info_to_thread_handle): Define.
8760         * remote.c (class remote_target): Add new method
8761         thread_info_to_thread_handle.
8762         (remote_target::thread_info_to_thread_handle): Define.
8763
8764 2019-04-08  Pedro Alves  <palves@redhat.com>
8765
8766         * common/common-exceptions.c (throw_exception): Don't create
8767         named object to throw; throw directly.
8768         (throw_it): Likewise.  Don't initialize gdb_exception::message
8769         here, with new; pass FMT and AP to the ctor instead.
8770         * common/common-exceptions.h: Include <string>.
8771         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8772         const char *, va_list)): New ctor.  Use std::make_shared.
8773         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8774         errors)): Delete.
8775         (gdb_exception_error::gdb_exception_error(enum errors, const char
8776         *, va_list)): New.
8777         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8778         Add assertion.
8779         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8780         errors)): Delete.
8781         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8782         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8783         Add assertion.
8784
8785 2019-04-08  Tom Tromey  <tom@tromey.com>
8786
8787         * valops.c (value_rtti_indirect_type): Replace throw_exception
8788         with throw.
8789         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8790         with throw.
8791         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8792         throw.
8793         * target.c (target_translate_tls_address): Replace throw_exception
8794         with throw.
8795         * stack.c (frame_apply_command_count): Replace throw_exception
8796         with throw.
8797         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8798         throw.
8799         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8800         with throw.
8801         * rs6000-tdep.c (rs6000_frame_cache)
8802         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8803         * remote.c: Replace throw_exception with throw.
8804         * record-full.c (record_full_message, record_full_wait_1)
8805         (record_full_restore): Replace throw_exception with throw.
8806         * record-btrace.c:
8807         (get_thread_current_frame_id, record_btrace_start_replaying)
8808         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8809         (cmd_record_btrace_start): Replace throw_exception with throw.
8810         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8811         throw.
8812         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8813         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8814         * linespec.c:
8815         (find_linespec_symbols): Replace throw_exception with throw.
8816         * infrun.c (displaced_step_prepare, resume): Replace
8817         throw_exception with throw.
8818         * infcmd.c (post_create_inferior): Replace throw_exception with
8819         throw.
8820         * inf-loop.c (inferior_event_handler): Replace throw_exception
8821         with throw.
8822         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8823         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8824         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8825         (get_prev_frame_always, get_frame_pc_if_available)
8826         (get_frame_address_in_block_if_available, get_frame_language):
8827         Replace throw_exception with throw.
8828         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8829         throw_exception with throw.
8830         * eval.c (fetch_subexp_value, evaluate_var_value)
8831         (evaluate_funcall, evaluate_subexp_standard): Replace
8832         throw_exception with throw.
8833         * dwarf2loc.c (call_site_find_chain)
8834         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8835         Replace throw_exception with throw.
8836         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8837         with throw.
8838         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8839         throw.
8840         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8841         * completer.c (complete_line_internal): Replace throw_exception
8842         with throw.
8843         * compile/compile-object-run.c (compile_object_run): Replace
8844         throw_exception with throw.
8845         * cli/cli-script.c (process_next_line): Replace throw_exception
8846         with throw.
8847         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8848         (btrace_enable, btrace_maint_update_pt_packets): Replace
8849         throw_exception with throw.
8850         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8851         throw_exception with throw.
8852         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8853         throw_exception with throw.
8854         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8855         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8856         * aarch64-tdep.c (aarch64_make_prologue_cache)
8857         (aarch64_make_stub_cache): Replace throw_exception with throw.
8858
8859 2019-04-08  Tom Tromey  <tom@tromey.com>
8860
8861         * common/common-exceptions.c (throw_exception): Rename from
8862         throw_exception_cxx.  Remove old copy.  Make argument const.
8863         (throw_it): Create and throw exception objects directly.
8864         * common/common-exceptions.h (throw_exception): Make argument
8865         const.
8866         (struct gdb_exception_error): Add constructor.
8867         (struct gdb_exception_quit): Add constructor.
8868
8869 2019-04-08  Tom Tromey  <tom@tromey.com>
8870
8871         * common/common-exceptions.h (exception_rethrow): Don't declare.
8872         (TRY_SJLJ): Update comment.
8873         (TRY, CATCH, END_CATCH): Remove.
8874         * common/common-exceptions.c (exception_rethrow): Remove.
8875
8876 2019-04-08  Tom Tromey  <tom@tromey.com>
8877
8878         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8879         Remove.
8880         (gdb_exception_error): Rename from
8881         gdb_exception_RETURN_MASK_ERROR.
8882         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8883         (gdb_quit_bad_alloc): Update.
8884         * aarch64-tdep.c: Update.
8885         * ada-lang.c: Update.
8886         * ada-typeprint.c: Update.
8887         * ada-valprint.c: Update.
8888         * amd64-tdep.c: Update.
8889         * arch-utils.c: Update.
8890         * break-catch-throw.c: Update.
8891         * breakpoint.c: Update.
8892         * btrace.c: Update.
8893         * c-varobj.c: Update.
8894         * cli/cli-cmds.c: Update.
8895         * cli/cli-interp.c: Update.
8896         * cli/cli-script.c: Update.
8897         * common/common-exceptions.c: Update.
8898         * common/new-op.c: Update.
8899         * common/selftest.c: Update.
8900         * compile/compile-c-symbols.c: Update.
8901         * compile/compile-cplus-symbols.c: Update.
8902         * compile/compile-object-load.c: Update.
8903         * compile/compile-object-run.c: Update.
8904         * completer.c: Update.
8905         * corelow.c: Update.
8906         * cp-abi.c: Update.
8907         * cp-support.c: Update.
8908         * cp-valprint.c: Update.
8909         * darwin-nat.c: Update.
8910         * disasm-selftests.c: Update.
8911         * dtrace-probe.c: Update.
8912         * dwarf-index-cache.c: Update.
8913         * dwarf-index-write.c: Update.
8914         * dwarf2-frame-tailcall.c: Update.
8915         * dwarf2-frame.c: Update.
8916         * dwarf2loc.c: Update.
8917         * dwarf2read.c: Update.
8918         * eval.c: Update.
8919         * event-loop.c: Update.
8920         * event-top.c: Update.
8921         * exec.c: Update.
8922         * f-valprint.c: Update.
8923         * fbsd-tdep.c: Update.
8924         * frame-unwind.c: Update.
8925         * frame.c: Update.
8926         * gdbtypes.c: Update.
8927         * gnu-v3-abi.c: Update.
8928         * guile/guile-internal.h: Update.
8929         * guile/scm-block.c: Update.
8930         * guile/scm-breakpoint.c: Update.
8931         * guile/scm-cmd.c: Update.
8932         * guile/scm-disasm.c: Update.
8933         * guile/scm-frame.c: Update.
8934         * guile/scm-lazy-string.c: Update.
8935         * guile/scm-math.c: Update.
8936         * guile/scm-param.c: Update.
8937         * guile/scm-ports.c: Update.
8938         * guile/scm-pretty-print.c: Update.
8939         * guile/scm-symbol.c: Update.
8940         * guile/scm-symtab.c: Update.
8941         * guile/scm-type.c: Update.
8942         * guile/scm-value.c: Update.
8943         * i386-linux-tdep.c: Update.
8944         * i386-tdep.c: Update.
8945         * inf-loop.c: Update.
8946         * infcall.c: Update.
8947         * infcmd.c: Update.
8948         * infrun.c: Update.
8949         * jit.c: Update.
8950         * language.c: Update.
8951         * linespec.c: Update.
8952         * linux-fork.c: Update.
8953         * linux-nat.c: Update.
8954         * linux-tdep.c: Update.
8955         * linux-thread-db.c: Update.
8956         * main.c: Update.
8957         * mi/mi-cmd-break.c: Update.
8958         * mi/mi-cmd-stack.c: Update.
8959         * mi/mi-interp.c: Update.
8960         * mi/mi-main.c: Update.
8961         * objc-lang.c: Update.
8962         * p-valprint.c: Update.
8963         * parse.c: Update.
8964         * ppc-linux-tdep.c: Update.
8965         * printcmd.c: Update.
8966         * python/py-arch.c: Update.
8967         * python/py-breakpoint.c: Update.
8968         * python/py-cmd.c: Update.
8969         * python/py-finishbreakpoint.c: Update.
8970         * python/py-frame.c: Update.
8971         * python/py-framefilter.c: Update.
8972         * python/py-gdb-readline.c: Update.
8973         * python/py-inferior.c: Update.
8974         * python/py-infthread.c: Update.
8975         * python/py-lazy-string.c: Update.
8976         * python/py-linetable.c: Update.
8977         * python/py-objfile.c: Update.
8978         * python/py-param.c: Update.
8979         * python/py-prettyprint.c: Update.
8980         * python/py-progspace.c: Update.
8981         * python/py-record-btrace.c: Update.
8982         * python/py-record.c: Update.
8983         * python/py-symbol.c: Update.
8984         * python/py-type.c: Update.
8985         * python/py-unwind.c: Update.
8986         * python/py-utils.c: Update.
8987         * python/py-value.c: Update.
8988         * python/python.c: Update.
8989         * record-btrace.c: Update.
8990         * record-full.c: Update.
8991         * remote-fileio.c: Update.
8992         * remote.c: Update.
8993         * riscv-tdep.c: Update.
8994         * rs6000-aix-tdep.c: Update.
8995         * rs6000-tdep.c: Update.
8996         * rust-exp.y: Update.
8997         * rust-lang.c: Update.
8998         * s390-tdep.c: Update.
8999         * selftest-arch.c: Update.
9000         * solib-dsbt.c: Update.
9001         * solib-frv.c: Update.
9002         * solib-spu.c: Update.
9003         * solib-svr4.c: Update.
9004         * solib.c: Update.
9005         * sparc64-linux-tdep.c: Update.
9006         * stack.c: Update.
9007         * symfile-mem.c: Update.
9008         * symmisc.c: Update.
9009         * target.c: Update.
9010         * thread.c: Update.
9011         * top.c: Update.
9012         * tracefile-tfile.c: Update.
9013         * tui/tui.c: Update.
9014         * typeprint.c: Update.
9015         * unittests/cli-utils-selftests.c: Update.
9016         * unittests/parse-connection-spec-selftests.c: Update.
9017         * valops.c: Update.
9018         * valprint.c: Update.
9019         * value.c: Update.
9020         * varobj.c: Update.
9021         * windows-nat.c: Update.
9022         * x86-linux-nat.c: Update.
9023         * xml-support.c: Update.
9024
9025 2019-04-08  Tom Tromey  <tom@tromey.com>
9026
9027         * xml-support.c: Use C++ exception handling.
9028         * x86-linux-nat.c: Use C++ exception handling.
9029         * windows-nat.c: Use C++ exception handling.
9030         * varobj.c: Use C++ exception handling.
9031         * value.c: Use C++ exception handling.
9032         * valprint.c: Use C++ exception handling.
9033         * valops.c: Use C++ exception handling.
9034         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9035         handling.
9036         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9037         * typeprint.c: Use C++ exception handling.
9038         * tui/tui.c: Use C++ exception handling.
9039         * tracefile-tfile.c: Use C++ exception handling.
9040         * top.c: Use C++ exception handling.
9041         * thread.c: Use C++ exception handling.
9042         * target.c: Use C++ exception handling.
9043         * symmisc.c: Use C++ exception handling.
9044         * symfile-mem.c: Use C++ exception handling.
9045         * stack.c: Use C++ exception handling.
9046         * sparc64-linux-tdep.c: Use C++ exception handling.
9047         * solib.c: Use C++ exception handling.
9048         * solib-svr4.c: Use C++ exception handling.
9049         * solib-spu.c: Use C++ exception handling.
9050         * solib-frv.c: Use C++ exception handling.
9051         * solib-dsbt.c: Use C++ exception handling.
9052         * selftest-arch.c: Use C++ exception handling.
9053         * s390-tdep.c: Use C++ exception handling.
9054         * rust-lang.c: Use C++ exception handling.
9055         * rust-exp.y: Use C++ exception handling.
9056         * rs6000-tdep.c: Use C++ exception handling.
9057         * rs6000-aix-tdep.c: Use C++ exception handling.
9058         * riscv-tdep.c: Use C++ exception handling.
9059         * remote.c: Use C++ exception handling.
9060         * remote-fileio.c: Use C++ exception handling.
9061         * record-full.c: Use C++ exception handling.
9062         * record-btrace.c: Use C++ exception handling.
9063         * python/python.c: Use C++ exception handling.
9064         * python/py-value.c: Use C++ exception handling.
9065         * python/py-utils.c: Use C++ exception handling.
9066         * python/py-unwind.c: Use C++ exception handling.
9067         * python/py-type.c: Use C++ exception handling.
9068         * python/py-symbol.c: Use C++ exception handling.
9069         * python/py-record.c: Use C++ exception handling.
9070         * python/py-record-btrace.c: Use C++ exception handling.
9071         * python/py-progspace.c: Use C++ exception handling.
9072         * python/py-prettyprint.c: Use C++ exception handling.
9073         * python/py-param.c: Use C++ exception handling.
9074         * python/py-objfile.c: Use C++ exception handling.
9075         * python/py-linetable.c: Use C++ exception handling.
9076         * python/py-lazy-string.c: Use C++ exception handling.
9077         * python/py-infthread.c: Use C++ exception handling.
9078         * python/py-inferior.c: Use C++ exception handling.
9079         * python/py-gdb-readline.c: Use C++ exception handling.
9080         * python/py-framefilter.c: Use C++ exception handling.
9081         * python/py-frame.c: Use C++ exception handling.
9082         * python/py-finishbreakpoint.c: Use C++ exception handling.
9083         * python/py-cmd.c: Use C++ exception handling.
9084         * python/py-breakpoint.c: Use C++ exception handling.
9085         * python/py-arch.c: Use C++ exception handling.
9086         * printcmd.c: Use C++ exception handling.
9087         * ppc-linux-tdep.c: Use C++ exception handling.
9088         * parse.c: Use C++ exception handling.
9089         * p-valprint.c: Use C++ exception handling.
9090         * objc-lang.c: Use C++ exception handling.
9091         * mi/mi-main.c: Use C++ exception handling.
9092         * mi/mi-interp.c: Use C++ exception handling.
9093         * mi/mi-cmd-stack.c: Use C++ exception handling.
9094         * mi/mi-cmd-break.c: Use C++ exception handling.
9095         * main.c: Use C++ exception handling.
9096         * linux-thread-db.c: Use C++ exception handling.
9097         * linux-tdep.c: Use C++ exception handling.
9098         * linux-nat.c: Use C++ exception handling.
9099         * linux-fork.c: Use C++ exception handling.
9100         * linespec.c: Use C++ exception handling.
9101         * language.c: Use C++ exception handling.
9102         * jit.c: Use C++ exception handling.
9103         * infrun.c: Use C++ exception handling.
9104         * infcmd.c: Use C++ exception handling.
9105         * infcall.c: Use C++ exception handling.
9106         * inf-loop.c: Use C++ exception handling.
9107         * i386-tdep.c: Use C++ exception handling.
9108         * i386-linux-tdep.c: Use C++ exception handling.
9109         * guile/scm-value.c: Use C++ exception handling.
9110         * guile/scm-type.c: Use C++ exception handling.
9111         * guile/scm-symtab.c: Use C++ exception handling.
9112         * guile/scm-symbol.c: Use C++ exception handling.
9113         * guile/scm-pretty-print.c: Use C++ exception handling.
9114         * guile/scm-ports.c: Use C++ exception handling.
9115         * guile/scm-param.c: Use C++ exception handling.
9116         * guile/scm-math.c: Use C++ exception handling.
9117         * guile/scm-lazy-string.c: Use C++ exception handling.
9118         * guile/scm-frame.c: Use C++ exception handling.
9119         * guile/scm-disasm.c: Use C++ exception handling.
9120         * guile/scm-cmd.c: Use C++ exception handling.
9121         * guile/scm-breakpoint.c: Use C++ exception handling.
9122         * guile/scm-block.c: Use C++ exception handling.
9123         * guile/guile-internal.h: Use C++ exception handling.
9124         * gnu-v3-abi.c: Use C++ exception handling.
9125         * gdbtypes.c: Use C++ exception handling.
9126         * frame.c: Use C++ exception handling.
9127         * frame-unwind.c: Use C++ exception handling.
9128         * fbsd-tdep.c: Use C++ exception handling.
9129         * f-valprint.c: Use C++ exception handling.
9130         * exec.c: Use C++ exception handling.
9131         * event-top.c: Use C++ exception handling.
9132         * event-loop.c: Use C++ exception handling.
9133         * eval.c: Use C++ exception handling.
9134         * dwarf2read.c: Use C++ exception handling.
9135         * dwarf2loc.c: Use C++ exception handling.
9136         * dwarf2-frame.c: Use C++ exception handling.
9137         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9138         * dwarf-index-write.c: Use C++ exception handling.
9139         * dwarf-index-cache.c: Use C++ exception handling.
9140         * dtrace-probe.c: Use C++ exception handling.
9141         * disasm-selftests.c: Use C++ exception handling.
9142         * darwin-nat.c: Use C++ exception handling.
9143         * cp-valprint.c: Use C++ exception handling.
9144         * cp-support.c: Use C++ exception handling.
9145         * cp-abi.c: Use C++ exception handling.
9146         * corelow.c: Use C++ exception handling.
9147         * completer.c: Use C++ exception handling.
9148         * compile/compile-object-run.c: Use C++ exception handling.
9149         * compile/compile-object-load.c: Use C++ exception handling.
9150         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9151         * compile/compile-c-symbols.c: Use C++ exception handling.
9152         * common/selftest.c: Use C++ exception handling.
9153         * common/new-op.c: Use C++ exception handling.
9154         * cli/cli-script.c: Use C++ exception handling.
9155         * cli/cli-interp.c: Use C++ exception handling.
9156         * cli/cli-cmds.c: Use C++ exception handling.
9157         * c-varobj.c: Use C++ exception handling.
9158         * btrace.c: Use C++ exception handling.
9159         * breakpoint.c: Use C++ exception handling.
9160         * break-catch-throw.c: Use C++ exception handling.
9161         * arch-utils.c: Use C++ exception handling.
9162         * amd64-tdep.c: Use C++ exception handling.
9163         * ada-valprint.c: Use C++ exception handling.
9164         * ada-typeprint.c: Use C++ exception handling.
9165         * ada-lang.c: Use C++ exception handling.
9166         * aarch64-tdep.c: Use C++ exception handling.
9167
9168 2019-04-08  Tom Tromey  <tom@tromey.com>
9169
9170         * xml-support.c (gdb_xml_parser::parse): Update.
9171         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9172         * value.c (show_convenience): Update.
9173         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9174         (test_parse_flags_qcs): Update.
9175         * thread.c (thr_try_catch_cmd): Update.
9176         * target.c (target_translate_tls_address): Update.
9177         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9178         (info_frame_command_core, frame_apply_command_count): Update.
9179         * rust-exp.y (rust_lex_exception_test): Update.
9180         * riscv-tdep.c (riscv_print_one_register_info): Update.
9181         * remote.c (remote_target::enable_btrace): Update.
9182         * record-btrace.c (record_btrace_enable_warn): Update.
9183         * python/py-utils.c (gdbpy_convert_exception): Update.
9184         * printcmd.c (do_one_display, print_variable_and_value): Update.
9185         * mi/mi-main.c (mi_print_exception): Update.
9186         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9187         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9188         * linux-nat.c (linux_nat_target::attach): Update.
9189         * linux-fork.c (class scoped_switch_fork_info): Update.
9190         * infrun.c (displaced_step_prepare): Update.
9191         * infcall.c (call_function_by_hand_dummy): Update.
9192         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9193         * gnu-v3-abi.c (print_one_vtable): Update.
9194         * frame.c (get_prev_frame_always): Update.
9195         * f-valprint.c (info_common_command_for_block): Update.
9196         * exec.c (try_open_exec_file): Update.
9197         * exceptions.c (print_exception, exception_print)
9198         (exception_fprintf, exception_print_same): Update.
9199         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9200         * dwarf-index-cache.c (index_cache::store)
9201         (index_cache::lookup_gdb_index): Update.
9202         * darwin-nat.c (maybe_cache_shell): Update.
9203         * cp-valprint.c (cp_print_value_fields): Update.
9204         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9205         (gcc_cplus_symbol_address): Update.
9206         * compile/compile-c-symbols.c (gcc_convert_symbol)
9207         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9208         * common/selftest.c: Update.
9209         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9210         a std::string.
9211         (exception_try_scope_entry, exception_try_scope_exit): Don't
9212         declare.
9213         (struct exception_try_scope): Remove.
9214         (TRY): Don't use exception_try_scope.
9215         (struct gdb_exception): Add constructor, operator=.
9216         <what>: New method.
9217         (struct gdb_exception_RETURN_MASK_ALL)
9218         (struct gdb_exception_RETURN_MASK_ERROR)
9219         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9220         (struct gdb_quit_bad_alloc): Update.
9221         * common/common-exceptions.c (exception_none): Change
9222         initializer.
9223         (struct catcher) <state, exception>: Initialize inline.
9224         <prev>: Remove member.
9225         (current_catcher): Remove.
9226         (catchers): New global.
9227         (exceptions_state_mc_init): Simplify.
9228         (catcher_pop): Remove.
9229         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9230         (try_scope_depth, exception_try_scope_entry)
9231         (exception_try_scope_exit): Remove.
9232         (throw_exception_sjlj): Update.
9233         (exception_messages, exception_messages_size): Remove.
9234         (throw_it): Simplify.
9235         (gdb_exception_sliced_copy): Remove.
9236         (throw_exception_cxx): Update.
9237         * cli/cli-script.c (script_from_file): Update.
9238         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9239         Update.
9240         * ada-valprint.c (ada_val_print): Update.
9241         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9242         (create_excep_cond_exprs): Update.
9243
9244 2019-04-08  Tom Tromey  <tom@tromey.com>
9245
9246         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9247         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9248         (TRY, CATCH, END_CATCH): Remove some definitions.
9249         * common/common-exceptions.c: Don't use GDB_XCPT.
9250         (catcher_list_size): Remove.
9251         (throw_exception, throw_it): Simplify.
9252
9253 2019-04-05  Tom Tromey  <tom@tromey.com>
9254
9255         Revert the header-sorting patch.
9256         * ft32-tdep.c: Revert.
9257         * frv-tdep.c: Revert.
9258         * frv-linux-tdep.c: Revert.
9259         * frame.c: Revert.
9260         * frame-unwind.c: Revert.
9261         * frame-base.c: Revert.
9262         * fork-child.c: Revert.
9263         * findvar.c: Revert.
9264         * findcmd.c: Revert.
9265         * filesystem.c: Revert.
9266         * filename-seen-cache.h: Revert.
9267         * filename-seen-cache.c: Revert.
9268         * fbsd-tdep.c: Revert.
9269         * fbsd-nat.h: Revert.
9270         * fbsd-nat.c: Revert.
9271         * f-valprint.c: Revert.
9272         * f-typeprint.c: Revert.
9273         * f-lang.c: Revert.
9274         * extension.h: Revert.
9275         * extension.c: Revert.
9276         * extension-priv.h: Revert.
9277         * expprint.c: Revert.
9278         * exec.h: Revert.
9279         * exec.c: Revert.
9280         * exceptions.c: Revert.
9281         * event-top.c: Revert.
9282         * event-loop.c: Revert.
9283         * eval.c: Revert.
9284         * elfread.c: Revert.
9285         * dwarf2read.h: Revert.
9286         * dwarf2read.c: Revert.
9287         * dwarf2loc.c: Revert.
9288         * dwarf2expr.h: Revert.
9289         * dwarf2expr.c: Revert.
9290         * dwarf2-frame.c: Revert.
9291         * dwarf2-frame-tailcall.c: Revert.
9292         * dwarf-index-write.h: Revert.
9293         * dwarf-index-write.c: Revert.
9294         * dwarf-index-common.c: Revert.
9295         * dwarf-index-cache.h: Revert.
9296         * dwarf-index-cache.c: Revert.
9297         * dummy-frame.c: Revert.
9298         * dtrace-probe.c: Revert.
9299         * disasm.h: Revert.
9300         * disasm.c: Revert.
9301         * disasm-selftests.c: Revert.
9302         * dictionary.c: Revert.
9303         * dicos-tdep.c: Revert.
9304         * demangle.c: Revert.
9305         * dcache.h: Revert.
9306         * dcache.c: Revert.
9307         * darwin-nat.h: Revert.
9308         * darwin-nat.c: Revert.
9309         * darwin-nat-info.c: Revert.
9310         * d-valprint.c: Revert.
9311         * d-namespace.c: Revert.
9312         * d-lang.c: Revert.
9313         * ctf.c: Revert.
9314         * csky-tdep.c: Revert.
9315         * csky-linux-tdep.c: Revert.
9316         * cris-tdep.c: Revert.
9317         * cris-linux-tdep.c: Revert.
9318         * cp-valprint.c: Revert.
9319         * cp-support.c: Revert.
9320         * cp-namespace.c: Revert.
9321         * cp-abi.c: Revert.
9322         * corelow.c: Revert.
9323         * corefile.c: Revert.
9324         * continuations.c: Revert.
9325         * completer.h: Revert.
9326         * completer.c: Revert.
9327         * complaints.c: Revert.
9328         * coffread.c: Revert.
9329         * coff-pe-read.c: Revert.
9330         * cli-out.h: Revert.
9331         * cli-out.c: Revert.
9332         * charset.c: Revert.
9333         * c-varobj.c: Revert.
9334         * c-valprint.c: Revert.
9335         * c-typeprint.c: Revert.
9336         * c-lang.c: Revert.
9337         * buildsym.c: Revert.
9338         * buildsym-legacy.c: Revert.
9339         * build-id.h: Revert.
9340         * build-id.c: Revert.
9341         * btrace.c: Revert.
9342         * bsd-uthread.c: Revert.
9343         * breakpoint.h: Revert.
9344         * breakpoint.c: Revert.
9345         * break-catch-throw.c: Revert.
9346         * break-catch-syscall.c: Revert.
9347         * break-catch-sig.c: Revert.
9348         * blockframe.c: Revert.
9349         * block.c: Revert.
9350         * bfin-tdep.c: Revert.
9351         * bfin-linux-tdep.c: Revert.
9352         * bfd-target.c: Revert.
9353         * bcache.c: Revert.
9354         * ax-general.c: Revert.
9355         * ax-gdb.h: Revert.
9356         * ax-gdb.c: Revert.
9357         * avr-tdep.c: Revert.
9358         * auxv.c: Revert.
9359         * auto-load.c: Revert.
9360         * arm-wince-tdep.c: Revert.
9361         * arm-tdep.c: Revert.
9362         * arm-symbian-tdep.c: Revert.
9363         * arm-pikeos-tdep.c: Revert.
9364         * arm-obsd-tdep.c: Revert.
9365         * arm-nbsd-tdep.c: Revert.
9366         * arm-nbsd-nat.c: Revert.
9367         * arm-linux-tdep.c: Revert.
9368         * arm-linux-nat.c: Revert.
9369         * arm-fbsd-tdep.c: Revert.
9370         * arm-fbsd-nat.c: Revert.
9371         * arm-bsd-tdep.c: Revert.
9372         * arch-utils.c: Revert.
9373         * arc-tdep.c: Revert.
9374         * arc-newlib-tdep.c: Revert.
9375         * annotate.h: Revert.
9376         * annotate.c: Revert.
9377         * amd64-windows-tdep.c: Revert.
9378         * amd64-windows-nat.c: Revert.
9379         * amd64-tdep.c: Revert.
9380         * amd64-sol2-tdep.c: Revert.
9381         * amd64-obsd-tdep.c: Revert.
9382         * amd64-obsd-nat.c: Revert.
9383         * amd64-nbsd-tdep.c: Revert.
9384         * amd64-nbsd-nat.c: Revert.
9385         * amd64-nat.c: Revert.
9386         * amd64-linux-tdep.c: Revert.
9387         * amd64-linux-nat.c: Revert.
9388         * amd64-fbsd-tdep.c: Revert.
9389         * amd64-fbsd-nat.c: Revert.
9390         * amd64-dicos-tdep.c: Revert.
9391         * amd64-darwin-tdep.c: Revert.
9392         * amd64-bsd-nat.c: Revert.
9393         * alpha-tdep.c: Revert.
9394         * alpha-obsd-tdep.c: Revert.
9395         * alpha-nbsd-tdep.c: Revert.
9396         * alpha-mdebug-tdep.c: Revert.
9397         * alpha-linux-tdep.c: Revert.
9398         * alpha-linux-nat.c: Revert.
9399         * alpha-bsd-tdep.c: Revert.
9400         * alpha-bsd-nat.c: Revert.
9401         * aix-thread.c: Revert.
9402         * agent.c: Revert.
9403         * addrmap.c: Revert.
9404         * ada-varobj.c: Revert.
9405         * ada-valprint.c: Revert.
9406         * ada-typeprint.c: Revert.
9407         * ada-tasks.c: Revert.
9408         * ada-lang.c: Revert.
9409         * aarch64-tdep.c: Revert.
9410         * aarch64-ravenscar-thread.c: Revert.
9411         * aarch64-newlib-tdep.c: Revert.
9412         * aarch64-linux-tdep.c: Revert.
9413         * aarch64-linux-nat.c: Revert.
9414         * aarch64-fbsd-tdep.c: Revert.
9415         * aarch64-fbsd-nat.c: Revert.
9416         * aarch32-linux-nat.c: Revert.
9417
9418 2019-04-05  Tom Tromey  <tom@tromey.com>
9419
9420         * ft32-tdep.c: Sort headers.
9421         * frv-tdep.c: Sort headers.
9422         * frv-linux-tdep.c: Sort headers.
9423         * frame.c: Sort headers.
9424         * frame-unwind.c: Sort headers.
9425         * frame-base.c: Sort headers.
9426         * fork-child.c: Sort headers.
9427         * findvar.c: Sort headers.
9428         * findcmd.c: Sort headers.
9429         * filesystem.c: Sort headers.
9430         * filename-seen-cache.h: Sort headers.
9431         * filename-seen-cache.c: Sort headers.
9432         * fbsd-tdep.c: Sort headers.
9433         * fbsd-nat.h: Sort headers.
9434         * fbsd-nat.c: Sort headers.
9435         * f-valprint.c: Sort headers.
9436         * f-typeprint.c: Sort headers.
9437         * f-lang.c: Sort headers.
9438         * extension.h: Sort headers.
9439         * extension.c: Sort headers.
9440         * extension-priv.h: Sort headers.
9441         * expprint.c: Sort headers.
9442         * exec.h: Sort headers.
9443         * exec.c: Sort headers.
9444         * exceptions.c: Sort headers.
9445         * event-top.c: Sort headers.
9446         * event-loop.c: Sort headers.
9447         * eval.c: Sort headers.
9448         * elfread.c: Sort headers.
9449         * dwarf2read.h: Sort headers.
9450         * dwarf2read.c: Sort headers.
9451         * dwarf2loc.c: Sort headers.
9452         * dwarf2expr.h: Sort headers.
9453         * dwarf2expr.c: Sort headers.
9454         * dwarf2-frame.c: Sort headers.
9455         * dwarf2-frame-tailcall.c: Sort headers.
9456         * dwarf-index-write.h: Sort headers.
9457         * dwarf-index-write.c: Sort headers.
9458         * dwarf-index-common.c: Sort headers.
9459         * dwarf-index-cache.h: Sort headers.
9460         * dwarf-index-cache.c: Sort headers.
9461         * dummy-frame.c: Sort headers.
9462         * dtrace-probe.c: Sort headers.
9463         * disasm.h: Sort headers.
9464         * disasm.c: Sort headers.
9465         * disasm-selftests.c: Sort headers.
9466         * dictionary.c: Sort headers.
9467         * dicos-tdep.c: Sort headers.
9468         * demangle.c: Sort headers.
9469         * dcache.h: Sort headers.
9470         * dcache.c: Sort headers.
9471         * darwin-nat.h: Sort headers.
9472         * darwin-nat.c: Sort headers.
9473         * darwin-nat-info.c: Sort headers.
9474         * d-valprint.c: Sort headers.
9475         * d-namespace.c: Sort headers.
9476         * d-lang.c: Sort headers.
9477         * ctf.c: Sort headers.
9478         * csky-tdep.c: Sort headers.
9479         * csky-linux-tdep.c: Sort headers.
9480         * cris-tdep.c: Sort headers.
9481         * cris-linux-tdep.c: Sort headers.
9482         * cp-valprint.c: Sort headers.
9483         * cp-support.c: Sort headers.
9484         * cp-namespace.c: Sort headers.
9485         * cp-abi.c: Sort headers.
9486         * corelow.c: Sort headers.
9487         * corefile.c: Sort headers.
9488         * continuations.c: Sort headers.
9489         * completer.h: Sort headers.
9490         * completer.c: Sort headers.
9491         * complaints.c: Sort headers.
9492         * coffread.c: Sort headers.
9493         * coff-pe-read.c: Sort headers.
9494         * cli-out.h: Sort headers.
9495         * cli-out.c: Sort headers.
9496         * charset.c: Sort headers.
9497         * c-varobj.c: Sort headers.
9498         * c-valprint.c: Sort headers.
9499         * c-typeprint.c: Sort headers.
9500         * c-lang.c: Sort headers.
9501         * buildsym.c: Sort headers.
9502         * buildsym-legacy.c: Sort headers.
9503         * build-id.h: Sort headers.
9504         * build-id.c: Sort headers.
9505         * btrace.c: Sort headers.
9506         * bsd-uthread.c: Sort headers.
9507         * breakpoint.h: Sort headers.
9508         * breakpoint.c: Sort headers.
9509         * break-catch-throw.c: Sort headers.
9510         * break-catch-syscall.c: Sort headers.
9511         * break-catch-sig.c: Sort headers.
9512         * blockframe.c: Sort headers.
9513         * block.c: Sort headers.
9514         * bfin-tdep.c: Sort headers.
9515         * bfin-linux-tdep.c: Sort headers.
9516         * bfd-target.c: Sort headers.
9517         * bcache.c: Sort headers.
9518         * ax-general.c: Sort headers.
9519         * ax-gdb.h: Sort headers.
9520         * ax-gdb.c: Sort headers.
9521         * avr-tdep.c: Sort headers.
9522         * auxv.c: Sort headers.
9523         * auto-load.c: Sort headers.
9524         * arm-wince-tdep.c: Sort headers.
9525         * arm-tdep.c: Sort headers.
9526         * arm-symbian-tdep.c: Sort headers.
9527         * arm-pikeos-tdep.c: Sort headers.
9528         * arm-obsd-tdep.c: Sort headers.
9529         * arm-nbsd-tdep.c: Sort headers.
9530         * arm-nbsd-nat.c: Sort headers.
9531         * arm-linux-tdep.c: Sort headers.
9532         * arm-linux-nat.c: Sort headers.
9533         * arm-fbsd-tdep.c: Sort headers.
9534         * arm-fbsd-nat.c: Sort headers.
9535         * arm-bsd-tdep.c: Sort headers.
9536         * arch-utils.c: Sort headers.
9537         * arc-tdep.c: Sort headers.
9538         * arc-newlib-tdep.c: Sort headers.
9539         * annotate.h: Sort headers.
9540         * annotate.c: Sort headers.
9541         * amd64-windows-tdep.c: Sort headers.
9542         * amd64-windows-nat.c: Sort headers.
9543         * amd64-tdep.c: Sort headers.
9544         * amd64-sol2-tdep.c: Sort headers.
9545         * amd64-obsd-tdep.c: Sort headers.
9546         * amd64-obsd-nat.c: Sort headers.
9547         * amd64-nbsd-tdep.c: Sort headers.
9548         * amd64-nbsd-nat.c: Sort headers.
9549         * amd64-nat.c: Sort headers.
9550         * amd64-linux-tdep.c: Sort headers.
9551         * amd64-linux-nat.c: Sort headers.
9552         * amd64-fbsd-tdep.c: Sort headers.
9553         * amd64-fbsd-nat.c: Sort headers.
9554         * amd64-dicos-tdep.c: Sort headers.
9555         * amd64-darwin-tdep.c: Sort headers.
9556         * amd64-bsd-nat.c: Sort headers.
9557         * alpha-tdep.c: Sort headers.
9558         * alpha-obsd-tdep.c: Sort headers.
9559         * alpha-nbsd-tdep.c: Sort headers.
9560         * alpha-mdebug-tdep.c: Sort headers.
9561         * alpha-linux-tdep.c: Sort headers.
9562         * alpha-linux-nat.c: Sort headers.
9563         * alpha-bsd-tdep.c: Sort headers.
9564         * alpha-bsd-nat.c: Sort headers.
9565         * aix-thread.c: Sort headers.
9566         * agent.c: Sort headers.
9567         * addrmap.c: Sort headers.
9568         * ada-varobj.c: Sort headers.
9569         * ada-valprint.c: Sort headers.
9570         * ada-typeprint.c: Sort headers.
9571         * ada-tasks.c: Sort headers.
9572         * ada-lang.c: Sort headers.
9573         * aarch64-tdep.c: Sort headers.
9574         * aarch64-ravenscar-thread.c: Sort headers.
9575         * aarch64-newlib-tdep.c: Sort headers.
9576         * aarch64-linux-tdep.c: Sort headers.
9577         * aarch64-linux-nat.c: Sort headers.
9578         * aarch64-fbsd-tdep.c: Sort headers.
9579         * aarch64-fbsd-nat.c: Sort headers.
9580         * aarch32-linux-nat.c: Sort headers.
9581
9582 2019-04-04  Tom Tromey  <tom@tromey.com>
9583
9584         * varobj.c (varobj_create): Update.
9585         * rust-exp.y (struct rust_parser) <update_innermost_block,
9586         lookup_symbol>: New methods.
9587         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9588         Rename.
9589         (rust_parser::rust_lookup_type)
9590         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9591         * printcmd.c (display_command, do_one_display): Update.
9592         * parser-defs.h (struct parser_state) <parser_state>: Add
9593         "tracker" parameter.
9594         (block_tracker): New member.
9595         (class innermost_block_tracker) <innermost_block_tracker>: Add
9596         "types" parameter.
9597         <reset>: Remove method.
9598         (innermost_block): Don't declare.
9599         (null_post_parser): Update.
9600         * parse.c (innermost_block): Remove global.
9601         (write_dollar_variable): Update.
9602         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9603         Remove "tracker_types" parameter.
9604         (parse_expression): Add "tracker" parameter.
9605         (parse_expression_for_completion): Update.
9606         (null_post_parser): Add "tracker" parameter.
9607         * p-exp.y: Update rules.
9608         * m2-exp.y: Update rules.
9609         * language.h (struct language_defn) <la_post_parser>: Add
9610         "tracker" parameter.
9611         * go-exp.y: Update rules.
9612         * f-exp.y: Update rules.
9613         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9614         parameter.
9615         * d-exp.y: Update rules.
9616         * c-exp.y: Update rules.
9617         * breakpoint.c (set_breakpoint_condition): Create an
9618         innermost_block_tracker.
9619         (watch_command_1): Likewise.
9620         * ada-lang.c (resolve): Add "tracker" parameter.
9621         (resolve_subexp): Likewise.
9622         * ada-exp.y (write_var_from_sym): Update.
9623
9624 2019-04-04  Tom Tromey  <tom@tromey.com>
9625
9626         * type-stack.h: New file.
9627         * type-stack.c: New file.
9628         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9629         type-stack.h.
9630         (insert_into_type_stack, insert_type, push_type, push_type_int)
9631         (insert_type_address_space, pop_type, pop_type_int)
9632         (pop_typelist, pop_type_stack, append_type_stack)
9633         (push_type_stack, get_type_stack, push_typelist)
9634         (follow_type_instance_flags, follow_types): Don't declare.
9635         * parse.c (type_stack): Remove global.
9636         (parse_exp_in_context): Update.
9637         (insert_into_type_stack, insert_type, push_type, push_type_int)
9638         (insert_type_address_space, pop_type, pop_type_int)
9639         (pop_typelist, pop_type_stack, append_type_stack)
9640         (push_type_stack, get_type_stack, push_typelist)
9641         (follow_type_instance_flags, follow_types): Remove (moved to
9642         type-stack.c).
9643         * f-exp.y (type_stack): New global.
9644         Update rules.
9645         (push_kind_type, f_parse): Update.
9646         * d-exp.y (type_stack): New global.
9647         Update rules.
9648         (d_parse): Update.
9649         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9650         Update rules.
9651         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9652         (HFILES_NO_SRCDIR): Add type-stack.h.
9653
9654 2019-04-04  Tom Tromey  <tom@tromey.com>
9655
9656         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9657         (rust_parser::convert_ast_to_expression, rust_parse)
9658         (rust_lex_test_completion, rust_lex_tests): Update.
9659         * parser-defs.h (struct expr_completion_state): New.
9660         (struct parser_state) <parser_state>: Add completion parameter.
9661         <mark_struct_expression, mark_completion_tag>: New methods.
9662         <parse_completion, m_completion_state>: New members.
9663         (prefixify_expression, null_post_parser): Update.
9664         (mark_struct_expression, mark_completion_tag): Don't declare.
9665         * parse.c (parse_completion, expout_last_struct)
9666         (expout_tag_completion_type, expout_completion_name): Remove
9667         globals.
9668         (parser_state::mark_struct_expression)
9669         (parser_state::mark_completion_tag): Now methods.
9670         (prefixify_expression): Add last_struct parameter.
9671         (prefixify_subexp): Likewise.
9672         (parse_exp_1): Update.
9673         (parse_exp_in_context): Add cstate parameter.  Update.
9674         (parse_expression_for_completion): Create an
9675         expr_completion_state.
9676         (null_post_parser): Add "completion" parameter.
9677         * p-exp.y: Update rules.
9678         (yylex): Update.
9679         * language.h (struct language_defn) <la_post_parser>: Add
9680         "completing" parameter.
9681         * go-exp.y: Update rules.
9682         (lex_one_token): Update.
9683         * expression.h (parse_completion): Don't declare.
9684         * d-exp.y: Update rules.
9685         (lex_one_token): Update rules.
9686         * c-exp.y: Update rules.
9687         (lex_one_token): Update.
9688         * ada-lang.c (resolve): Add "parse_completion" parameter.
9689         (resolve_subexp): Likewise.
9690         (ada_resolve_function): Likewise.
9691
9692 2019-04-04  Tom Tromey  <tom@tromey.com>
9693
9694         * parser-defs.h (struct parser_state) <start_arglist,
9695         end_arglist>: New methods.
9696         <arglist_len, m_funcall_chain>: New members.
9697         (arglist_len, start_arglist, end_arglist): Don't declare.
9698         * parse.c (arglist_len, funcall_chain): Remove global.
9699         (start_arglist, end_arglist): Remove functions.
9700         (parse_exp_in_context): Update.
9701         * p-exp.y: Update rules.
9702         * m2-exp.y: Update rules.
9703         * go-exp.y: Update rules.
9704         * f-exp.y: Update rules.
9705         * d-exp.y: Update rules.
9706         * c-exp.y: Update rules.
9707
9708 2019-04-04  Tom Tromey  <tom@tromey.com>
9709
9710         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9711         lex_operator, push_back>: New methods.
9712         Update all rules.
9713         (rust_parser::lex_hex, lex_escape): Rename and update.
9714         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9715         (rust_parser::lex_operator): Rename and update.
9716         (rust_parser::lex_number, rustyylex, rustyyerror)
9717         (rust_lex_test_init, rust_lex_test_sequence)
9718         (rust_lex_test_push_back, rust_lex_tests): Update.
9719         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9720         parameter.
9721         <lexptr, prev_lexptr>: New members.
9722         (lexptr, prev_lexptr): Don't declare.
9723         * parse.c (lexptr, prev_lexptr): Remove globals.
9724         (parse_exp_in_context): Update.
9725         * p-exp.y (yylex, yyerror): Update.
9726         * m2-exp.y (parse_number, yylex, yyerror): Update.
9727         * go-exp.y (lex_one_token, yyerror): Update.
9728         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9729         * d-exp.y (lex_one_token, yyerror): Update.
9730         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9731         (lex_one_token, yyerror): Update.
9732         * ada-lex.l (YY_INPUT): Update.
9733         (rewind_to_char): Update.
9734         * ada-exp.y (yyerror): Update.
9735
9736 2019-04-04  Tom Tromey  <tom@tromey.com>
9737
9738         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9739         * parser-defs.h (struct parser_state) <parser_state>: Add new
9740         parameter.
9741         <comma_terminates>: New member.
9742         (comma_terminates): Don't declare global.
9743         * parse.c (comma_terminates): Remove global.
9744         (parse_exp_in_context): Update.
9745         * p-exp.y (yylex): Update.
9746         * m2-exp.y (yylex): Update.
9747         * go-exp.y (lex_one_token): Update.
9748         * f-exp.y (yylex): Update.
9749         * d-exp.y (lex_one_token): Update.
9750         * c-exp.y (lex_one_token): Update.
9751         * ada-lex.l: Update.
9752
9753 2019-04-04  Tom Tromey  <tom@tromey.com>
9754
9755         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9756         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9757         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9758         * parser-defs.h (paren_depth): Don't declare.
9759         * parse.c (paren_depth): Remove global.
9760         (parse_exp_in_context): Update.
9761         * p-exp.y (paren_depth): New global.
9762         (pascal_parse): Initialize it.
9763         * m2-exp.y (paren_depth): New global.
9764         (m2_parse): Initialize it.
9765         * go-exp.y (paren_depth): New global.
9766         (go_parse): Initialize it.
9767         * f-exp.y (paren_depth): New global.
9768         (f_parse): Initialize it.
9769         * d-exp.y (paren_depth): New global.
9770         (d_parse): Initialize it.
9771         * c-exp.y (paren_depth): New global.
9772         (c_parse): Initialize it.
9773         * ada-lex.l (paren_depth): New global.
9774         (lexer_init): Initialize it.
9775
9776 2019-04-04  Tom Tromey  <tom@tromey.com>
9777
9778         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9779         (rust_parser::convert_ast_to_type)
9780         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9781         * parser-defs.h (struct parser_state) <parser_state>: Add
9782         parameters.  Initialize new members.
9783         <expression_context_block, expression_context_pc>: New members.
9784         * parse.c (expression_context_block, expression_context_pc):
9785         Remove globals.
9786         (parse_exp_in_context): Update.
9787         * p-exp.y: Update all rules.
9788         (yylex): Update.
9789         * m2-exp.y: Update all rules.
9790         (yylex): Update.
9791         * go-exp.y (yylex): Update.
9792         * f-exp.y (yylex): Update.
9793         * d-exp.y: Update all rules.
9794         (yylex): Update.
9795         * c-exp.y: Update all rules.
9796         (lex_one_token, classify_name, yylex, c_parse): Update.
9797         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9798
9799 2019-04-04  Tom Tromey  <tom@tromey.com>
9800
9801         * gdbarch.h, gdbarch.c: Rebuild.
9802         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9803         * stap-probe.h:
9804         (struct stap_parse_info): Replace "parser_state" with
9805         "expr_builder".
9806         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9807         (parser_state): New class.
9808         * parse.c (expr_builder): Rename.
9809         (expr_builder::release): Rename.
9810         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9811         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9812         (write_exp_elt_longcst, write_exp_elt_floatcst)
9813         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9814         (write_exp_string_vector, write_exp_bitstring)
9815         (write_exp_msymbol, mark_struct_expression)
9816         (write_dollar_variable)
9817         (insert_type_address_space, increase_expout_size): Replace
9818         "parser_state" with "expr_builder".
9819         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9820         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9821         "parser_state" with "expr_builder".
9822
9823 2019-04-04  Tom Tromey  <tom@tromey.com>
9824
9825         * rust-exp.y: Replace "parse_language" with method call.
9826         * p-exp.y:
9827         (yylex): Replace "parse_language" with method call.
9828         * m2-exp.y:
9829         (yylex): Replace "parse_language" with method call.
9830         * go-exp.y (classify_name): Replace "parse_language" with method
9831         call.
9832         * f-exp.y (yylex): Replace "parse_language" with method call.
9833         * d-exp.y (lex_one_token): Replace "parse_language" with method
9834         call.
9835         * c-exp.y:
9836         (lex_one_token, classify_name, yylex): Replace "parse_language"
9837         with method call.
9838         * ada-exp.y (find_primitive_type, type_char)
9839         (type_system_address): Replace "parse_language" with method call.
9840
9841 2019-04-04  Tom Tromey  <tom@tromey.com>
9842
9843         * rust-exp.y: Replace "parse_gdbarch" with method call.
9844         * parse.c (write_dollar_variable, insert_type_address_space):
9845         Replace "parse_gdbarch" with method call.
9846         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9847         call.
9848         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9849         call.
9850         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9851         "parse_gdbarch" with method call.
9852         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9853         with method call.
9854         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9855         "parse_gdbarch" with method call.
9856         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9857         "parse_gdbarch" with method call.
9858         * c-exp.y (parse_type, parse_number, classify_name): Replace
9859         "parse_gdbarch" with method call.
9860         * ada-lex.l: Replace "parse_gdbarch" with method call.
9861         * ada-exp.y (parse_type, find_primitive_type, type_char)
9862         (type_system_address): Replace "parse_gdbarch" with method call.
9863
9864 2019-04-04  Tom Tromey  <tom@tromey.com>
9865
9866         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9867         * stap-probe.c (stap_parse_argument): Update.
9868         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9869         initial_size parameter.
9870         * rust-exp.y (rust_lex_tests): Update.
9871         * parse.c (parser_state): Update.
9872         (parse_exp_in_context): Update.
9873         * parser-defs.h (struct parser_state) <parser_state>: Remove
9874         "initial_size" parameter.
9875
9876 2019-04-04  Tom Tromey  <tom@tromey.com>
9877
9878         * parser-defs.h (increase_expout_size): Don't declare.
9879         * parse.c (increase_expout_size): Now static.
9880
9881 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9882
9883         * gnu-nat.c (gnu_nat_target::wait): Fix
9884         target_waitstatus_to_string call.
9885
9886 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9887
9888         * eval.c (evaluate_subexp_standard): Handle internal functions
9889         during Fortran function call handling.
9890
9891 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9892
9893         * NEWS: Mention new internal functions.
9894         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9895         (read_base_type): Use dwarf2_init_complex_target_type.
9896         * value.c (creal_internal_fn): New function.
9897         (cimag_internal_fn): New function.
9898         (_initialize_values): Register new internal functions.
9899
9900 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9901
9902         * infrun.c (stop_all_threads): If debug_infrun, always
9903         trace the wait status after wait_one, using
9904         target_waitstatus_to_string and target_pid_to_str.
9905         (handle_inferior_event): Replace various trace of
9906         wait status kind by a single trace.
9907         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9908         wait status kind image by target_waitstatus_to_string.
9909         * target/waitstatus.c (target_waitstatus_to_string): Fix
9910         obsolete comment.
9911
9912 2019-04-01  Tom Tromey  <tromey@adacore.com>
9913
9914         PR symtab/23331:
9915         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9916
9917 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9918             Pedro Alves  <palves@redhat.com>
9919
9920         * top.c (quit_force): Call 'finalize_values'.
9921         * value.c (finalize_values): New function.
9922         * value.h (finalize_values): Declare.
9923
9924 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9925
9926         * NEWS: Announce $_gdb_major and $_gdb_minor.
9927
9928         * top.c (init_gdb_version_vars): New function.
9929         (gdb_init): Call init_gdb_version_vars.
9930
9931 2019-03-29  Tom Tromey  <tromey@adacore.com>
9932
9933         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9934         help text.  Remove dead code.
9935
9936 2019-03-29  Keith Seitz  <keiths@redhat.com>
9937
9938         From Siddhesh Poyarekar:
9939         * f-lang.h (f77_get_upperbound): Return LONGEST.
9940         (f77_get_lowerbound): Likewise.
9941         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9942         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9943         print them.
9944         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9945         plongest to format print it.
9946         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9947         (f77_get_upperbound): Likewise.
9948         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9949         LOWER_BOUND to LONGEST.
9950         (f77_create_arrayprint_offset_tbl): Likewise.
9951
9952 2019-03-29  Keith Seitz  <keiths@redhat.com>
9953
9954         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9955         %s/pulongest for TYPE_LENGTH instead of %d in format
9956         strings.
9957         * ada-typerint.c (ada_print_type): Likewise.
9958         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9959         * compile/compile-c-support.c (generate_register_struct): Likewise.
9960         * gdbtypes.c (recursive_dump_type): Likewise.
9961         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9962         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9963         instead of %d in format strings.
9964         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9965         to std::min to ULONGEST.
9966         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9967         instead of %d in format strings.
9968         * tracepoint.c (info_scope_command): Likewise.
9969         * typeprint.c (print_offset_data::update)
9970         (print_offset_data::finish): Likewise.
9971         * xtensa-tdep.c (xtensa_store_return_value)
9972         (xtensa_push_dummy_call): Likewise.
9973
9974 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9975
9976         * windows-nat.c (display_selector): Fixed format specifications
9977         for 64-bit Cygwin.
9978
9979 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9980
9981         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9982
9983 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9984
9985         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9986         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9987         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9988         (nios2_linux_init_abi): Install it.
9989
9990 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9991
9992         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9993
9994 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9995
9996         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9997
9998 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9999             Tom Tromey  <tromey@adacore.com>
10000
10001         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10002
10003 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10004
10005         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10006         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10007         method to compute the bounds of range types. Also print "[evaluated]"
10008         if the bounds' values come from a dynamic evaluation.
10009
10010 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10011
10012         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10013         whitespace when pretty printing is on.
10014
10015 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10016
10017         * ppc-linux-nat.c: Add include.
10018
10019 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10020
10021         * NEWS: Mention AArch64 Pointer Authentication.
10022
10023 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10024
10025         * arm-linux-nat.c: Add include.
10026
10027 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10028
10029         * source-cache.c (source_cache::get_source_lines): Re-read
10030         fullname after calling open_source_file.
10031
10032 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10033
10034         * NEWS: Mention TLS support for FreeBSD.
10035
10036 2019-03-25  Tom Tromey  <tromey@adacore.com>
10037
10038         * minsyms.c (BUNCH_SIZE): Update comment.
10039         (~minimal_symbol_reader): Remove old comment.
10040         (compact_minimal_symbols): Update comment.
10041         (minimal_symbol_reader::install): Remove old comment.  Update
10042         other comments.
10043
10044 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10045
10046         * s390-linux-nat.c: Add include.
10047
10048 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10049
10050         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10051         Call linux_get_hwcap.
10052         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10053         Likewise.
10054         (aarch64_linux_get_hwcap): Remove function.
10055         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10056         declaration.
10057         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10058         linux_get_hwcap.
10059         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10060         * linux-tdep.c (linux_get_hwcap): Add function.
10061         (linux_get_hwcap2): Likewise.
10062         * linux-tdep.h (linux_get_hwcap): Add declaration.
10063         (linux_get_hwcap2): Likewise.
10064         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10065         (ppc_linux_get_hwcap2): Likewise.
10066         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10067         linux_get_hwcap.
10068         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10069         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10070         (ppc_linux_nat_target::read_description): Likewise.
10071         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10072         * s390-linux-nat.c: Likewise.
10073         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10074
10075 2019-03-24  Tom Tromey  <tom@tromey.com>
10076
10077         * ada-lang.c (standard_lookup): Simplify initialization.
10078         (ada_lookup_symbol_nonlocal): Simplify return.
10079         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10080         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10081         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10082         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10083         initialization.
10084         * solib.c (solib_global_lookup): Simplify.
10085         * symtab.c (null_block_symbol): Remove.
10086         (symbol_cache_lookup): Simplify returns.
10087         (lookup_language_this): Simplify returns.
10088         (lookup_symbol_aux): Simplify return.
10089         (lookup_local_symbol): Simplify returns.
10090         (lookup_global_symbol_from_objfile): Simplify return.
10091         (lookup_symbol_in_objfile_symtabs)
10092         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10093         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10094         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10095         * cp-namespace.c (cp_lookup_bare_symbol)
10096         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10097         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10098         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10099         (cp_lookup_symbol_via_imports): Simplify initialization.
10100         (find_symbol_in_baseclass): Likewise.
10101         * symtab.h (null_block_symbol): Remove.
10102         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10103         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10104         (d_lookup_symbol_module): Likewise.
10105         (find_symbol_in_baseclass): Simplify initialization.
10106
10107 2019-03-24  Tom Tromey  <tom@tromey.com>
10108
10109         * expression.h: Don't include symtab.h.
10110         (struct block): Forward declare.
10111
10112 2019-03-24  Tom Tromey  <tom@tromey.com>
10113
10114         * c-exp.y (typebase): Remove casts.
10115         * gdbtypes.c (lookup_unsigned_typename, )
10116         (lookup_signed_typename): Remove cast.
10117         * eval.c (parse_to_comma_and_eval): Remove cast.
10118         * parse.c (write_dollar_variable): Remove cast.
10119         * block.h (struct block) <superblock>: Now const.
10120         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10121         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10122         (map_block): Make "block" const.
10123         * symfile.h (struct quick_symbol_functions)
10124         <map_matching_symbols>: Constify block argument to "callback".
10125         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10126         const.
10127         (find_pc_sect_compunit_symtab): Make "b" const.
10128         (find_symbol_at_address): Likewise.
10129         (search_symbols): Likewise.
10130         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10131         (dw2_debug_names_lookup_symbol): Likewise.
10132         (dw2_map_matching_symbols): Update.
10133         * p-valprint.c (pascal_val_print): Remove "block".
10134         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10135         (aux_add_nonlocal_symbols): Make "block" const.
10136         (resolve_subexp): Remove cast.
10137         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10138         const.
10139         (iterate_over_file_blocks): Likewise.
10140         * f-exp.y (%union) <bval>: Remove.
10141         * coffread.c (patch_opaque_types): Make "b" const.
10142         * spu-tdep.c (spu_catch_start): Make "block" const.
10143         * c-valprint.c (print_unpacked_pointer): Remove "block".
10144         * symmisc.c (dump_symtab_1): Make "b" const.
10145         (block_depth): Make "block" const.
10146         * d-exp.y (%union) <bval>: Remove.
10147         * cp-support.h (cp_lookup_rtti_type): Update.
10148         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10149         * psymtab.c (psym_lookup_symbol): Make "block" const.
10150         (maintenance_check_psymtabs): Make "b" const.
10151         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10152         (enumerate_locals, enumerate_args): Update.
10153         * python/py-symtab.c (stpy_global_block): Make "block" const.
10154         (stpy_static_block): Likewise.
10155         * inline-frame.c (block_starting_point_at): Make "new_block"
10156         const.
10157         * block.c (find_block_in_blockvector): Make return type const.
10158         (blockvector_for_pc_sect): Make "b" const.
10159         (find_block_in_blockvector): Make "b" const.
10160
10161 2019-03-23  Tom Tromey  <tom@tromey.com>
10162
10163         * varobj.c (varobj_create): Update.
10164         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10165         * printcmd.c (display_command, do_one_display): Don't reset
10166         innermost_block.
10167         * parser-defs.h (enum innermost_block_tracker_type): Move to
10168         expression.h.
10169         (innermost_block): Update comment.
10170         * parse.c (parse_exp_1): Add tracker_types parameter.
10171         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10172         tracker_types parameter.  Reset innermost_block.
10173         (parse_exp_in_context): Remove.
10174         (parse_expression_for_completion): Update.
10175         * objfiles.c (~objfile): Don't reset expression_context_block or
10176         innermost_block.
10177         * expression.h (enum innermost_block_tracker_type): Move from
10178         parser-defs.h.
10179         (parse_exp_1): Add tracker_types parameter.
10180         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10181         reset innermost_block.
10182
10183 2019-03-23  Tom Tromey  <tom@tromey.com>
10184
10185         * objfiles.h: Include bcache.h.
10186
10187 2019-03-23  Tom Tromey  <tom@tromey.com>
10188
10189         * linespec.c (get_current_search_block): Use
10190         scoped_restore_current_language.
10191         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10192
10193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10194             Jiong Wang  <jiong.wang@arm.com>
10195
10196         * aarch64-linux-tdep.c
10197         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10198         section.
10199         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10200
10201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10202             Jiong Wang  <jiong.wang@arm.com>
10203
10204         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10205         instructions.
10206         (aarch64_analyze_prologue_test): Add PACIASP test.
10207         (aarch64_prologue_prev_register): Unmask PC value.
10208
10209 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10210             Jiong Wang  <jiong.wang@arm.com>
10211
10212         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10213         (aarch64_dwarf2_prev_register): Unmask PC value.
10214         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10215         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10216         DW_CFA_AARCH64_negate_ra_state.
10217         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10218
10219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10220             Jiong Wang  <jiong.wang@arm.com>
10221
10222         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10223         registers.
10224         (aarch64_pseudo_register_name): Likewise.
10225         (aarch64_pseudo_register_type): Likewise.
10226         (aarch64_pseudo_register_reggroup_p): Likewise.
10227         (aarch64_gdbarch_init): Add pauth registers.
10228         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10229         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10230         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10231         (struct gdbarch_tdep): Add regnum for ra_state.
10232
10233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10234             Jiong Wang  <jiong.wang@arm.com>
10235
10236         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10237
10238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10239             Jiong Wang  <jiong.wang@arm.com>
10240
10241         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10242         function.
10243         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10244         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10245         (aarch64_gdbarch_init): Add puth registers.
10246         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10247         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10248         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10249
10250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10251             Jiong Wang  <jiong.wang@arm.com>
10252
10253         * aarch64-linux-nat.c
10254         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10255         * aarch64-linux-tdep.c
10256         (aarch64_linux_core_read_description): Likewise.
10257         (aarch64_linux_get_hwcap): New function.
10258         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10259         (aarch64_linux_get_hwcap): New declaration.
10260
10261 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10262             Jiong Wang  <jiong.wang@arm.com>
10263
10264         * aarch64-linux-nat.c
10265         (aarch64_linux_nat_target::read_description): Add pauth param.
10266         * aarch64-linux-tdep.c
10267         (aarch64_linux_core_read_description): Likewise.
10268         * aarch64-tdep.c (struct target_desc): Add in pauth.
10269         (aarch64_read_description): Add pauth param.
10270         (aarch64_gdbarch_init): Likewise.
10271         * aarch64-tdep.h (aarch64_read_description): Likewise.
10272         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10273         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10274         * features/Makefile: Add new files.
10275         * features/aarch64-pauth.c: New file.
10276         * features/aarch64-pauth.xml: New file.
10277
10278 2019-03-20  Tom Tromey  <tromey@adacore.com>
10279
10280         * infrun.c (handle_inferior_event): Rename from
10281         handle_inferior_event_1.  Create a scoped_value_mark.
10282         (handle_inferior_event): Remove.
10283
10284 2019-03-19  Tom Tromey  <tromey@adacore.com>
10285
10286         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10287         * infrun.h (print_stop_event): Add "displays" parameter.
10288         * infrun.c (print_stop_event): Add "displays" parameter.
10289
10290 2019-03-19  Pedro Alves  <palves@redhat.com>
10291
10292         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10293         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10294         to -1.  Fix TABs vs spaces.
10295         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10296         * tui/tui-out.h (tui_ui_out) Add intro comments.
10297         <m_line, m_start_of_line>: In-class initialize, and add describing
10298         comment.
10299
10300 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10301
10302         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10303         variable names.
10304         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10305
10306 2019-03-18  Pedro Alves  <palves@redhat.com>
10307             Eli Zaretskii <eliz@gnu.org>
10308
10309         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10310         m_line and m_start_of_line.
10311
10312 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10313
10314         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10315         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10316         it returns a newline.  This fixes a regression in TU mode, whereby
10317         the next line is output on the same screen line as the user input.
10318
10319 2019-03-18  Tom Tromey  <tromey@adacore.com>
10320
10321         * minsyms.c (minimal_symbol_reader::install): Remove call to
10322         obstack_blank.
10323
10324 2019-03-18  Pedro Alves  <palves@redhat.com>
10325
10326         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10327         New globals.
10328         (apply_style): New, factored out from ...
10329         (apply_ansi_escape): ... this.  Handle reverse video mode.
10330         (tui_set_reverse_mode): New function.
10331         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10332         * tui/tui-winsource.c (tui_show_source_line): Use
10333         tui_set_reverse_mode instead of setting A_STANDOUT.
10334         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10335         New setter methods.
10336
10337 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10338
10339         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10340         Handle tabs.
10341
10342 2019-03-18  Tom Tromey  <tromey@adacore.com>
10343
10344         * ada-lang.c (empty_array): Add "high" parameter.
10345         (ada_evaluate_subexp): Update.
10346
10347 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10348
10349         * unittests/string_view-selftests.c: Define
10350         _initialize_string_view_selftests unconditionally.
10351
10352 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10353
10354         PR gdb/24350
10355         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10356
10357 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10358
10359         PR gdb/24351
10360         * windows-nat.c (display_selector): Fix format specifiers.
10361
10362 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10363
10364         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10365         tui_refill_source_window instead of tui_refresh_win, to update the
10366         current execution line.  This fixes redisplay of the current line
10367         when stepping through the code with "next" or "step".
10368
10369 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10370
10371         * source-cache.c (source_cache::get_source_lines): Call
10372         find_source_lines to initialize s->nlines.  This fixes vertical
10373         scrolling of TUI source window when the DOWN arrow is pressed.
10374
10375 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10376
10377         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10378         linux-thread-db.c (_initialize_thread_db): Likewise.
10379
10380 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10381
10382         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10383         wclrtoeol in tui_show_source_line".  This reverts changes made in
10384         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10385
10386 2019-03-15  Tom Tromey  <tom@tromey.com>
10387
10388         * symtab.h (struct minimal_symbol): Derive from
10389         general_symbol_info.
10390         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10391         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10392         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10393         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10394         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10395         (MSYMBOL_SEARCH_NAME): Update.
10396         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10397         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10398         * minsyms.c (minimal_symbol_reader::record_full): Update.
10399
10400 2019-03-15  Tom Tromey  <tom@tromey.com>
10401
10402         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10403
10404 2019-03-15  Tom Tromey  <tom@tromey.com>
10405
10406         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10407         unique_xmalloc_ptr.
10408         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10409         Update.
10410         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10411         (build_minimal_symbol_hash_tables)
10412         (minimal_symbol_reader::install): Update.
10413
10414 2019-03-15  Tom Tromey  <tom@tromey.com>
10415
10416         * symtab.c (create_demangled_names_hash): Update.
10417         (symbol_set_names): Update.
10418         * objfiles.h (struct objfile_per_bfd_storage)
10419         <demangled_names_hash>: Now an htab_up.
10420         * objfiles.c (objfile_per_bfd_storage): Simplify.
10421
10422 2019-03-15  Tom Tromey  <tom@tromey.com>
10423
10424         * objfiles.h (struct objfile_per_bfd_storage): Declare
10425         destructor.
10426         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10427         New.
10428         (get_objfile_bfd_data): Use new.  Don't initialize
10429         language_of_main.
10430         (free_objfile_per_bfd_storage): Remove.
10431         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10432
10433 2019-03-15  Tom Tromey  <tom@tromey.com>
10434
10435         * symfile.c (reread_symbols): Update.
10436         * objfiles.c (objfile::objfile): Update.
10437         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10438         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10439         comment.
10440         (minimal_symbol_reader::install): Update.
10441         (terminate_minimal_symbol_table): Remove.
10442         * jit.c (jit_object_close_impl): Update.
10443
10444 2019-03-15  Tom Tromey  <tom@tromey.com>
10445
10446         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10447         initializations.
10448
10449 2019-03-15  Tom Tromey  <tom@tromey.com>
10450
10451         * objfiles.h (struct objfile_per_bfd_storage)
10452         <demangled_hash_languages>: Now a bitset.
10453         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10454         (lookup_minimal_symbol): Update.
10455
10456 2019-03-15  Tom Tromey  <tom@tromey.com>
10457
10458         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10459         Don't return the symbol.
10460         * coffread.c (record_minimal_symbol): Use record_full.
10461
10462 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10463
10464         The MS-Windows port of ncurses fails to switch to a color pair if
10465         one or both of the colors are the implicit default colors.  This
10466         change records the default colors when TUI is initialized, and
10467         then specifies them explicitly when a color pair uses the default
10468         colors.  This allows color styling in TUI mode on MS-Windows.
10469
10470         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10471         ncurses_norm_attr.
10472         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10473         colors in ncurses_norm_attr.
10474         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10475         "none", replace it with the default color recorded in
10476         ncurses_norm_attr.
10477
10478 2019-03-14  Tom Tromey  <tromey@adacore.com>
10479
10480         * source-cache.h (class source_cache) <get_source_lines>: Return
10481         std::string.
10482         * source-cache.c (source_cache::extract_lines): Handle case where
10483         first_pos==npos.  Return std::string.
10484         (source_cache::get_source_lines): Update.
10485
10486 2019-03-14  Tom Tromey  <tromey@adacore.com>
10487
10488         * NEWS: Add item for "style sources" commands.
10489         * source-cache.c (source_cache::get_source_lines): Check
10490         source_styling.
10491         * cli/cli-style.c (source_styling): New global.
10492         (_initialize_cli_style): Add "style sources" commands.
10493         (show_style_sources): New function.
10494         * cli/cli-style.h (source_styling): Declare.
10495
10496 2019-03-14  Pedro Alves  <palves@redhat.com>
10497             Tom Tromey  <tromey@adacore.com>
10498
10499         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10500         * tui/tui-winsource.c (tui_refill_source_window): New function,
10501         from...
10502         (tui_horizontal_source_scroll): ... here.  Move some logic.
10503         * cli/cli-style.c (set_style_enabled): Notify new observable.
10504         * tui/tui-hooks.c (tui_redisplay_source): New function.
10505         (tui_attach_detach_observers): Attach or detach
10506         tui_redisplay_source.
10507         * observable.h (source_styling_changed): New observable.
10508         * observable.c: Define source_styling_changed observable.
10509
10510 2019-03-13  Tom Tromey  <tromey@adacore.com>
10511
10512         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10513         (i386_gnu_nat_target::store_registers): Update.
10514         * target-debug.h (target_debug_print_std_string): New macro.
10515         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10516         * windows-tdep.c (display_one_tib): Update.
10517         * tui/tui-stack.c (tui_make_status_line): Update.
10518         * top.c (print_inferior_quit_action): Update.
10519         * thread.c (thr_try_catch_cmd): Update.
10520         (add_thread_with_info): Update.
10521         (thread_target_id_str): Update.
10522         (thr_try_catch_cmd): Update.
10523         (thread_command): Update.
10524         (thread_find_command): Update.
10525         * record-btrace.c (record_btrace_target::info_record)
10526         (record_btrace_resume_thread, record_btrace_target::resume)
10527         (record_btrace_cancel_resume, record_btrace_step_thread)
10528         (record_btrace_target::wait, record_btrace_target::wait)
10529         (record_btrace_target::wait, record_btrace_target::stop): Update.
10530         * progspace.c (print_program_space): Update.
10531         * process-stratum-target.c
10532         (process_stratum_target::thread_address_space): Update.
10533         * linux-fork.c (linux_fork_mourn_inferior)
10534         (detach_checkpoint_command, info_checkpoints_command)
10535         (linux_fork_context): Update.
10536         (linux_fork_detach): Update.
10537         (class scoped_switch_fork_info): Update.
10538         (delete_checkpoint_command): Update.
10539         * infrun.c (follow_fork_inferior): Update.
10540         (follow_fork_inferior): Update.
10541         (proceed_after_vfork_done): Update.
10542         (handle_vfork_child_exec_or_exit): Update.
10543         (follow_exec): Update.
10544         (displaced_step_prepare_throw): Update.
10545         (displaced_step_restore): Update.
10546         (start_step_over): Update.
10547         (resume_1): Update.
10548         (clear_proceed_status_thread): Update.
10549         (proceed): Update.
10550         (print_target_wait_results): Update.
10551         (do_target_wait): Update.
10552         (context_switch): Update.
10553         (stop_all_threads): Update.
10554         (restart_threads): Update.
10555         (finish_step_over): Update.
10556         (handle_signal_stop): Update.
10557         (switch_back_to_stepped_thread): Update.
10558         (keep_going_pass_signal): Update.
10559         (print_exited_reason): Update.
10560         (normal_stop): Update.
10561         * inferior.c (inferior_pid_to_str): Change return type.
10562         (print_selected_inferior): Update.
10563         (add_inferior): Update.
10564         (detach_inferior): Update.
10565         * dummy-frame.c (fprint_dummy_frames): Update.
10566         * dcache.c (dcache_info_1): Update.
10567         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10568         (btrace_fetch, btrace_clear): Update.
10569         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10570         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10571         type.
10572         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10573         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10574         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10575         * gdbarch.c, gdbarch.h: Rebuild.
10576         * gdbarch.sh (core_pid_to_str): Change return type.
10577         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10578         return type.
10579         (windows_nat_target::pid_to_str): Change return type.
10580         (windows_delete_thread): Update.
10581         (windows_nat_target::attach): Update.
10582         (windows_nat_target::files_info): Update.
10583         * target-delegates.c: Rebuild.
10584         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10585         return type.
10586         (sol_thread_target::pid_to_str): Change return type.
10587         * remote.c (class remote_target) <pid_to_str>: Change return
10588         type.
10589         (remote_target::pid_to_str): Change return type.
10590         (extended_remote_target::attach, remote_target::remote_stop_ns)
10591         (remote_target::remote_notif_remove_queued_reply)
10592         (remote_target::push_stop_reply, remote_target::disable_btrace):
10593         Update.
10594         (extended_remote_target::attach): Update.
10595         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10596         type.
10597         (gdbsim_target::pid_to_str): Change return type.
10598         * ravenscar-thread.c (struct ravenscar_thread_target)
10599         <pid_to_str>: Change return type.
10600         (ravenscar_thread_target::pid_to_str): Change return type.
10601         * procfs.c (class procfs_target) <pid_to_str>: Change return
10602         type.
10603         (procfs_target::pid_to_str): Change return type.
10604         (procfs_target::attach): Update.
10605         (procfs_target::detach): Update.
10606         (procfs_target::fetch_registers): Update.
10607         (procfs_target::store_registers): Update.
10608         (procfs_target::wait): Update.
10609         (procfs_target::files_info): Update.
10610         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10611         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10612         return type.
10613         (nto_procfs_target::pid_to_str): Change return type.
10614         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10615         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10616         return type.
10617         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10618         (exit_lwp): Update.
10619         (attach_proc_task_lwp_callback, get_detach_signal)
10620         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10621         (linux_nat_target::resume, wait_lwp, stop_callback)
10622         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10623         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10624         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10625         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10626         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10627         type.
10628         (inf_ptrace_target::attach): Update.
10629         (inf_ptrace_target::files_info): Update.
10630         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10631         type.
10632         (go32_nat_target::pid_to_str): Change return type.
10633         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10634         (gnu_nat_target::wait): Update.
10635         (gnu_nat_target::wait): Update.
10636         (gnu_nat_target::resume): Update.
10637         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10638         (fbsd_nat_target::wait): Update.
10639         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10640         type.
10641         (darwin_nat_target::attach): Update.
10642         * corelow.c (class core_target) <pid_to_str>: Change return type.
10643         (core_target::pid_to_str): Change return type.
10644         * target.c (normal_pid_to_str): Change return type.
10645         (default_pid_to_str): Likewise.
10646         (target_pid_to_str): Change return type.
10647         (target_translate_tls_address): Update.
10648         (target_announce_detach): Update.
10649         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10650         return type.
10651         (bsd_uthread_target::pid_to_str): Change return type.
10652         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10653         type.
10654         (bsd_kvm_target::pid_to_str): Change return type.
10655         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10656         return type.
10657         (aix_thread_target::pid_to_str): Change return type.
10658         * target.h (struct target_ops) <pid_to_str>: Change return type.
10659         (target_pid_to_str, normal_pid_to_str): Likewise.
10660         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10661         type.
10662         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10663         type.
10664         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10665         return type.
10666         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10667         type.
10668         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10669         type.
10670         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10671         return type.
10672
10673 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10674
10675         * NEWS: Mention that the new default MI version is 3.  Mention
10676         changes to the output of commands and events that deal with
10677         multi-location breakpoints.
10678         * breakpoint.c: Include "mi/mi-out.h".
10679         (print_one_breakpoint): Change output syntax if using MI version
10680         >= 3.
10681         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10682         New.
10683         (mi_multi_location_breakpoint_output_fixed): New.
10684         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10685         (mi_cmd_fix_multi_location_breakpoint_output): New.
10686         (mi_multi_location_breakpoint_output_fixed): New.
10687         * mi/mi-cmds.c (mi_cmds): Register command
10688         -fix-multi-location-breakpoint-output.
10689         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10690         interpreter "mi".
10691
10692 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10693
10694         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10695         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10696         instantiate mi_ui_out based on interpreter name.
10697         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10698         * mi/mi-main.c (mi_load_progress): Likewise.
10699
10700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10701
10702         * NEWS: Combine separate "New targets" sections for 8.3.
10703
10704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10705
10706         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10707         (ppcfbsd_init_abi): Install gdbarch
10708         "fetch_tls_load_module_address" and "get_thread_local_address"
10709         methods.
10710
10711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10712
10713         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10714         (riscv_fbsd_init_abi): Install gdbarch
10715         "fetch_tls_load_module_address" and "get_thread_local_address"
10716         methods.
10717
10718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10719
10720         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10721         (i386fbsd_init_abi): Install gdbarch
10722         "fetch_tls_load_module_address" and "get_thread_local_address"
10723         methods.
10724
10725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10726
10727         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10728         (amd64fbsd_init_abi): Install gdbarch
10729         "fetch_tls_load_module_address" and "get_thread_local_address"
10730         methods.
10731
10732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10733
10734         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10735         (struct fbsd_pspace_data): New type.
10736         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10737         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10738         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10739         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10740         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10741
10742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10743
10744         * gdbtypes.c (lookup_struct_elt): New function.
10745         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10746         * gdbtypes.h (struct struct_elt): New type.
10747         (lookup_struct_elt): New prototype.
10748
10749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10750
10751         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10752         remove disabled code block.
10753
10754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10755
10756         * gdbarch.sh (get_thread_local_address): New method.
10757         * gdbarch.h, gdbarch.c: Regenerate.
10758         * target.c (target_translate_tls_address): Use
10759         gdbarch_get_thread_local_address if present instead of
10760         target::get_thread_local_address.
10761
10762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10763
10764         * target.h (target::get_thread_local_address): Update comment.
10765
10766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10767
10768         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10769         objfile->separate_debug_objfile_backlink if not NULL.
10770
10771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10772
10773         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10774         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10775         (amd64bsd_store_inferior_registers): Likewise.
10776         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10777         Enable segment base registers.
10778         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10779         PT_GETFSBASE and PT_GETGSBASE.
10780         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10781         PT_SETGSBASE.
10782         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10783         segment base registers.
10784         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10785
10786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10787
10788         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10789         Update calls to i386_target_description to add 'segments'
10790         parameter.
10791         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10792         add segment base registers.
10793         * arch/i386.c (i386_create_target_description): Add 'segments'
10794         parameter to enable segment base registers.
10795         * arch/i386.h (i386_create_target_description): Likewise.
10796         * features/i386/32bit-segments.xml: New file.
10797         * features/i386/32bit-segments.c: Generate.
10798         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10799         call to i386_target_description to add 'segments' parameter.
10800         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10801         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10802         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10803         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10804         if feature is present.
10805         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10806         Add 'segments' parameter to call to i386_target_description.
10807         (i386_target_description): Add 'segments' parameter to enable
10808         segment base registers.
10809         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10810         to call to i386_target_description.
10811         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10812         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10813         Define I386_NUM_REGS.
10814         (i386_target_description): Add 'segments' parameter to enable
10815         segment base registers.
10816
10817 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10818
10819         PR/24325
10820         * source-cache.c: #undef open and close, to avoid unresolved
10821         externals during linking.
10822
10823 2019-03-12  Tom Tromey  <tromey@adacore.com>
10824
10825         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10826         const.  Add initializers.
10827         (_initialize_remote): Don't initialize ptid globals.
10828
10829 2019-03-12  Pedro Alves  <palves@redhat.com>
10830
10831         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10832
10833 2019-03-12  Pedro Alves  <palves@redhat.com>
10834
10835         * cp-name-parser.y (main): Remove unused 'len' variable.
10836
10837 2019-03-12  Tom Tromey  <tromey@adacore.com>
10838
10839         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10840         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10841
10842 2019-03-12  Tom Tromey  <tromey@adacore.com>
10843
10844         * linux-nat.c (iterate_over_lwps): Update.
10845         (stop_callback): Remove parameter.
10846         (stop_wait_callback, detach_callback, resume_set_callback)
10847         (select_singlestep_lwp_callback, set_ignore_sigint)
10848         (status_callback, resumed_callback, resume_clear_callback)
10849         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10850         data parameter.
10851         (linux_nat_target::detach, linux_nat_target::resume)
10852         (linux_stop_and_wait_all_lwps, select_event_lwp)
10853         (linux_nat_filter_event, linux_nat_wait_1)
10854         (linux_nat_target::kill, linux_nat_target::stop)
10855         (linux_nat_target::stop): Update.
10856         (linux_nat_resume_callback): Change type.
10857         (resume_stopped_resumed_lwps, count_events_callback)
10858         (select_event_lwp_callback): Likewise.
10859         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10860         * arm-linux-nat.c (struct update_registers_data): Remove.
10861         (update_registers_callback): Change type.
10862         (arm_linux_insert_hw_breakpoint1): Update.
10863         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10864         parameter.
10865         (x86_linux_dr_set_addr): Update.
10866         (x86_linux_dr_set_control): Update.
10867         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10868         (iterate_over_lwps): Use gdb::function_view.
10869         * nat/aarch64-linux-hw-point.c (struct
10870         aarch64_dr_update_callback_param): Remove.
10871         (debug_reg_change_callback): Change type.
10872         (aarch64_notify_debug_reg_change): Update.
10873         * s390-linux-nat.c (s390_refresh_per_info): Update.
10874
10875 2019-03-11  Tom Tromey  <tromey@adacore.com>
10876
10877         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10878         redundant assignment to "this_cu".
10879
10880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10881
10882         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10883
10884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10885
10886         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10887         from...
10888         (rank_one_type): ... this.
10889
10890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10891
10892         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10893         from...
10894         (rank_one_type): ... this.
10895
10896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10897
10898         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10899         from...
10900         (rank_one_type): ... this.
10901
10902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10903
10904         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10905         from...
10906         (rank_one_type): ... this.
10907
10908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10909
10910         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10911         from...
10912         (rank_one_type): ... this.
10913
10914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10915
10916         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10917         from...
10918         (rank_one_type): ... this.
10919
10920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10921
10922         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10923         from...
10924         (rank_one_type): ... this.
10925
10926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10927
10928         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10929         from...
10930         (rank_one_type): ... this.
10931
10932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10933
10934         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10935         from...
10936         (rank_one_type): ... this.
10937
10938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10939
10940         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10941         from...
10942         (rank_one_type): ... this.
10943
10944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10945
10946         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10947         from...
10948         (rank_one_type): ... this.
10949
10950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10951
10952         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10953         from...
10954         (rank_one_type): ... this.
10955
10956 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10957
10958         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10959         inferior-events' shows the example events.
10960
10961 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10962
10963         Support styling on native MS-Windows console
10964
10965         PR/24315
10966         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10967         on MS-Windows if $TERM is not defined.
10968
10969         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10970
10971         * posix-hdep.c (gdb_console_fputs):
10972         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10973         functions.
10974         * ui-file.h (gdb_console_fputs): Add prototype.
10975
10976         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10977         back to fputs only if the former returns zero.
10978
10979 2019-03-07  Tom Tromey  <tom@tromey.com>
10980
10981         * symmisc.c (print_symbol_bcache_statistics): Update.
10982         (print_objfile_statistics): Update.
10983         * symfile.c (allocate_symtab): Update.
10984         * stabsread.c: Don't include bcache.h.
10985         * psymtab.h (struct psymbol_bcache): Don't declare.
10986         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10987         (psymbol_bcache_init, psymbol_bcache_free)
10988         (psymbol_bcache_get_bcache): Don't declare.
10989         * psymtab.c (struct psymbol_bcache): Remove.
10990         (psymtab_storage::psymtab_storage): Update.
10991         (psymtab_storage::~psymtab_storage): Update.
10992         (psymbol_bcache_init, psymbol_bcache_free)
10993         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10994         (add_psymbol_to_bcache): Update.
10995         (allocate_psymtab): Update.
10996         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10997         macro_cache>: No longer pointers.
10998         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10999         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11000         * macrotab.c (macro_bcache): Update.
11001         * macroexp.c: Don't include bcache.h.
11002         * gdbtypes.c (check_types_worklist): Update.
11003         (types_deeply_equal): Remove TRY/CATCH.  Update.
11004         * elfread.c (elf_symtab_read): Update.
11005         * dwarf2read.c: Don't include bcache.h.
11006         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11007         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11008         (print_bcache_statistics, bcache_memory_used): Don't declare.
11009         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11010         methods.  Rename all data members.
11011         * bcache.c (struct bcache): Move to bcache.h.
11012         (bcache::expand_hash_table): Rename from expand_hash_table.
11013         (bcache): Remove.
11014         (bcache::insert): Rename from bcache_full.
11015         (bcache::compare): Rename from bcache_compare.
11016         (bcache_xmalloc): Remove.
11017         (bcache::~bcache): Rename from bcache_xfree.
11018         (bcache::print_statistics): Rename from print_bcache_statistics.
11019         (bcache::memory_used): Rename from bcache_memory_used.
11020
11021 2019-03-07  Pedro Alves  <palves@redhat.com>
11022
11023         * infrun.c (normal_stop): Also check for
11024         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11025
11026 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11027
11028         * f-lang.c (value_from_host_double): Moved to...
11029         * value.c (value_from_host_double): ...here.
11030         * value.h (value_from_host_double): Declare.
11031         * guile/scm-math.c (vlscm_convert_typed_number): Use
11032         value_from_host_double.
11033         (vlscm_convert_number): Likewise.
11034         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11035         * python/py-value.c (convert_value_from_python): Likewise.
11036
11037 2019-03-06  Tom Tromey  <tom@tromey.com>
11038
11039         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11040
11041 2019-03-06  Tom Tromey  <tom@tromey.com>
11042
11043         * utils.h (free_current_contents): Don't declare.
11044         * utils.c (free_current_contents): Remove.
11045
11046 2019-03-06  Tom Tromey  <tom@tromey.com>
11047
11048         * top.c (quit_force): Update.
11049         * main.c (captured_command_loop): Update.
11050         * common/new-op.c (operator new): Update.
11051         * common/common-exceptions.c (struct catcher)
11052         <save_cleanup_chain>: Remove member.
11053         (exceptions_state_mc_init): Update.
11054         (exception_try_scope_entry): Return nullptr.
11055         (exception_try_scope_exit, exception_rethrow)
11056         (throw_exception_sjlj, throw_exception_cxx): Update.
11057         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11058         (all_cleanups, do_cleanups, discard_cleanups)
11059         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11060         (restore_cleanups, restore_final_cleanups): Don't declare.
11061         (do_final_cleanups): Remove parameter.
11062         * common/cleanups.c (cleanup_chain, make_cleanup)
11063         (make_cleanup_dtor, all_cleanups, do_cleanups)
11064         (discard_my_cleanups, discard_cleanups)
11065         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11066         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11067         (null_cleanup): Remove.
11068         (do_final_cleanups): Remove parameter.
11069
11070 2019-03-06  Tom Tromey  <tom@tromey.com>
11071
11072         * remote.c (remote_target::remote_parse_stop_reply): Use
11073         unique_xmalloc_ptr.
11074
11075 2019-03-06  Tom Tromey  <tom@tromey.com>
11076
11077         * stabsread.c (struct stabs_field_info): Rename from field_info.
11078         <list, fnlist>: Add initializers.
11079         <obstack>: New member.
11080         (read_member_functions, read_struct_fields, read_baseclasses):
11081         Allocate on obstack.  Don't use cleanups.
11082         (read_one_struct_field, read_member_functions, read_struct_fields)
11083         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11084         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11085         (read_struct_type): Update.
11086
11087 2019-03-06  Tom Tromey  <tom@tromey.com>
11088
11089         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11090         * common/filestuff.h (make_cleanup_close): Don't declare.
11091         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11092         Remove.
11093
11094 2019-03-06  Tom Tromey  <tom@tromey.com>
11095
11096         * solib-aix.c: Use make_scope_exit.
11097
11098 2019-03-06  Tom Tromey  <tom@tromey.com>
11099
11100         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11101         Use make_scope_exit.
11102
11103 2019-03-06  Tom Tromey  <tom@tromey.com>
11104
11105         * solib-svr4.c (disable_probes_interface): Remove parameter.
11106         (svr4_handle_solib_event): Use make_scope_exit.
11107
11108 2019-03-06  Tom Tromey  <tom@tromey.com>
11109
11110         * remote.c (struct stop_reply_deleter): Remove.
11111         (stop_reply_up): Update.
11112         (struct stop_reply): Derive from notif_event.  Don't typedef.
11113         <regcache>: Now a std::vector.
11114         (stop_reply_xfree): Remove.
11115         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11116         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11117         (remote_target::discard_pending_stop_replies): Use delete.
11118         (remote_target::remote_parse_stop_reply): Update.
11119         (remote_target::process_stop_reply): Update.
11120         * remote-notif.h (struct notif_event): Add virtual destructor.
11121         Remove "dtr" member.
11122         (struct notif_client) <alloc_event>: Return a unique_ptr.
11123         (notif_event_xfree): Don't declare.
11124         (notif_event_up): New typedef.
11125         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11126         (notif_event_xfree, do_notif_event_xfree): Remove.
11127         (remote_notif_state_xfree): Update.
11128
11129 2019-03-06  Tom Tromey  <tom@tromey.com>
11130
11131         * infrun.c (displaced_step_clear_cleanup): Now a
11132         forward_scope_exit type.
11133         (displaced_step_prepare_throw): Update.
11134         (displaced_step_fixup): Update.
11135
11136 2019-03-06  Tom Tromey  <tom@tromey.com>
11137
11138         * inferior.h (class inferior): Update comment.
11139         * gdbthread.h (class thread_info): Update comment.
11140
11141 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11142             Tom Tromey  <tom@tromey.com>
11143
11144         * stabsread.h (struct stab_section_list): Remove.
11145         (coffstab_build_psymtabs): Update.
11146         * dbxread.c (symbuf_sections): Now a std::vector.
11147         (sect_idx): New global.
11148         (fill_symbuf): Update.
11149         (coffstab_build_psymtabs): Change type of stabsects parameter.
11150         Update.
11151         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11152         std::vector.
11153         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11154         (coff_locate_sections): Update.
11155         (coff_symfile_read): Remove cleanups.  Update.
11156         (init_stringtab): Add storage parameter.
11157         (free_stringtab, free_stringtab_cleanup): Remove.
11158         (init_lineno): Add storage parameter.
11159         (free_linetab, free_linetab_cleanup): Remove.
11160
11161 2019-03-06  Pedro Alves  <palves@redhat.com>
11162
11163         * linux-fork.c (fork_info::clobber_regs): Delete.
11164         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11165         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11166         comment.  Adjust.
11167         (scoped_switch_fork_info::scoped_switch_fork_info)
11168         (checkpoint_command, linux_fork_context): Adjust
11169         fork_save_infrun_state calls.
11170
11171 2019-03-06  Pedro Alves  <palves@redhat.com>
11172
11173         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11174         (inf_has_multiple_threads): Return 'bool' and rewrite using
11175         inferior_info::threads().
11176
11177 2019-03-06  Pedro Alves  <palves@redhat.com>
11178
11179         * linux-fork.c: Include <list>.
11180         (fork_list): Now a std::list instance.
11181         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11182         (forks_exist_p, find_last_fork): Adjust.
11183         (new_fork): Delete.
11184         (one_fork_p): New.
11185         (add_fork): Adjust.
11186         (free_fork): Delete, folded into fork_info::~fork_info().
11187         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11188         Adjust.
11189         (init_fork_list): Delete.
11190         (linux_fork_killall, linux_fork_mourn_inferior)
11191         (linux_fork_detach, info_checkpoints_command): Adjust.
11192         (_initialize_linux_fork): No longer call init_fork_list.
11193
11194 2019-03-06  Pedro Alves  <palves@redhat.com>
11195
11196         * linux-fork.c (new_fork): New, split out of ...
11197         (add_fork): ... this.  Return void.  Move "first fork" special
11198         case from here, to ...
11199         (checkpoint_command): ... here.
11200         * linux-linux.h (add_fork): Return void.
11201
11202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11203
11204         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11205
11206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11207             Chris January  <chris.january@arm.com>
11208             David Lecomber  <david.lecomber@arm.com>
11209
11210         * f-exp.y: New token, UNOP_INTRINSIC.
11211         (exp): New pattern using UNOP_INTRINSIC token.
11212         (f77_keywords): Add 'abs' keyword.
11213         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11214         (value_from_host_double): New function.
11215         (evaluate_subexp_f): Support UNOP_ABS.
11216
11217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11218
11219         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11220         types.
11221
11222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11223
11224         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11225         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11226         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11227
11228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11229
11230         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11231
11232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11233             Chris January  <chris.january@arm.com>
11234
11235         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11236         * f-exp.y: Define 'KIND' token.
11237         (exp): New pattern for KIND expressions.
11238         (ptype): Handle types with a kind extension.
11239         (direct_abs_decl): Extend to spot kind extensions.
11240         (f77_keywords): Add 'kind' to the list.
11241         (push_kind_type): New function.
11242         (convert_to_kind_type): New function.
11243         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11244         * parse.c (operator_length_standard): Likewise.
11245         * parser-defs.h (enum type_pieces): Add tp_kind.
11246         * std-operator.def: Add UNOP_KIND.
11247
11248 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11249
11250         * f-exp.y (f_parse): Set yydebug.
11251
11252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11253
11254         * f-lang.c (evaluate_subexp_f): New function.
11255         (exp_descriptor_f): New global.
11256         (f_language_defn): Use exp_descriptor_f instead of
11257         exp_descriptor_standard.
11258
11259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11260
11261         * f-exp.y (struct token): Add comments.
11262         (dot_ops): Remove uppercase versions and the end marker.
11263         (f77_keywords): Likewise.
11264         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11265         entries in the dot_ops array are case insensitive, and use
11266         strncasecmp to compare strings.  Also some whitespace cleanup in
11267         this area.  Similar for the f77_keywords array, except entries in
11268         this list might be case sensitive.
11269
11270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11271
11272         * f-exp.y (struct f77_boolean_val): Add comments.
11273         (boolean_values): Remove uppercase versions, and end marker.
11274         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11275         and use strncasecmp to achieve case insensitivity.  Additionally,
11276         perform whitespace cleanup around this code.
11277
11278 2019-03-06  Tom Tromey  <tromey@adacore.com>
11279
11280         * remote-sim.c (gdbsim_target_open): Use result of
11281         gdb_argv::release.
11282
11283 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11284         Dirk Schubert  <dirk.schubert@arm.com>
11285         Chris January  <chris.january@arm.com>
11286
11287         * eval.c (evaluate_subexp_standard): Call Fortran argument
11288         wrapping logic.
11289         * f-lang.c (struct value): A value which can be passed into a
11290         Fortran function call.
11291         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11292         where appropriate.
11293         (struct type): Value ready for a Fortran function call.
11294         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11295         is needed.
11296         * f-lang.h (fortran_argument_convert): Declaration.
11297         (fortran_preserve_arg_pointer): Declaration.
11298         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11299
11300 2019-03-05  Tom Tromey  <tromey@adacore.com>
11301
11302         * python/py-prettyprint.c (print_string_repr): Remove #if.
11303         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11304
11305 2019-03-05  Tom Tromey  <tromey@adacore.com>
11306
11307         * target.c (the_dummy_target): Move later.  Change type to
11308         "dummy_target".
11309         (initialize_targets): Don't initialize the_dummy_target.
11310
11311 2019-03-05  Tom Tromey  <tromey@adacore.com>
11312
11313         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11314         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11315
11316 2019-03-05  Tom Tromey  <tromey@adacore.com>
11317
11318         * windows-nat.c (windows_nat_target::attach)
11319         (windows_nat_target::detach): Don't call gdb_flush.
11320         * valprint.c (generic_val_print, val_print, val_print_string):
11321         Don't call gdb_flush.
11322         * utils.c (defaulted_query): Don't call gdb_flush.
11323         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11324         * target.c (target_announce_detach): Don't call gdb_flush.
11325         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11326         * remote.c (extended_remote_target::attach): Don't call
11327         gdb_flush.
11328         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11329         * printcmd.c (do_examine): Don't call gdb_flush.
11330         (info_display_command): Don't call gdb_flush.
11331         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11332         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11333         * memattr.c (info_mem_command): Don't call gdb_flush.
11334         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11335         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11336         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11337         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11338         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11339         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11340         (gnu_nat_target::detach): Don't call gdb_flush.
11341         * f-valprint.c (f_val_print): Don't call gdb_flush.
11342         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11343         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11344         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11345         gdb_flush.
11346         * c-valprint.c (c_val_print): Don't call gdb_flush.
11347         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11348
11349 2019-03-05  Tom Tromey  <tromey@adacore.com>
11350
11351         * varobj.c (update_dynamic_varobj_children): Update.
11352         (install_default_visualizer): Use reset, not release.
11353         * value.c (set_internalvar): Update.
11354         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11355         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11356         ATTRIBUTE_UNUSED_RESULT.
11357
11358 2019-03-05  Tom Tromey  <tromey@adacore.com>
11359
11360         * remote.c (class scoped_remote_fd) <release>: Add
11361         ATTRIBUTE_UNUSED_RESULT.
11362
11363 2019-03-05  Tom Tromey  <tromey@adacore.com>
11364
11365         * macroexp.c (struct macro_buffer) <release>: Add
11366         ATTRIBUTE_UNUSED_RESULT.
11367
11368 2019-03-05  Tom Tromey  <tromey@adacore.com>
11369
11370         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11371         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11372         ATTRIBUTE_UNUSED_RESULT.
11373
11374 2019-03-05  Tom Tromey  <tromey@adacore.com>
11375
11376         * common/scoped_fd.h (class scoped_fd) <release>: Add
11377         ATTRIBUTE_UNUSED_RESULT.
11378
11379 2019-03-05  Tom Tromey  <tromey@adacore.com>
11380
11381         * parser-defs.h (struct parser_state) <release>: Add
11382         ATTRIBUTE_UNUSED_RESULT.
11383
11384 2019-03-05  Tom Tromey  <tromey@adacore.com>
11385
11386         * utils.h (class gdb_argv) <release>: Add
11387         ATTRIBUTE_UNUSED_RESULT.
11388         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11389
11390 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11391
11392         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11393         for-loop range, to avoid compiler warnings.
11394
11395         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11396         avoid compiler warnings about unused variables.
11397
11398         * NEWS: Mention end of support for native debugging on MS-Windows
11399         before XP.
11400
11401         PR gdb/24292
11402         * common/netstuff.c:
11403         * gdbserver/gdbreplay.c
11404         * gdbserver/remote-utils.c:
11405         * ser-tcp.c:
11406         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11407         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11408         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11409         'getaddrinfo' and 'freeaddrinfo' were not available before
11410         Windows XP, and mingw.org's MinGW headers by default define
11411         _WIN32_WINNT to 0x500.
11412
11413 2019-03-01  Gary Benson <gbenson@redhat.com>
11414
11415         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11416
11417 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11418             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11419
11420         PR gdb/8527
11421         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11422         set_sigint_trap, clear_sigint_trap.
11423
11424 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11425
11426         * target.c (target_detach): Clear the regcache and the
11427         frame cache.
11428
11429 2019-02-27  Pedro Alves  <palves@redhat.com>
11430
11431         * utils.c (set_screen_size): When we cap the height/width sizes,
11432         tweak the corresponding command variable to show "unlimited":
11433
11434 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11435             Pedro Alves  <palves@redhat.com>
11436
11437         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11438         before calling rl_set_screen_size.
11439
11440 2019-02-27  Tom Tromey  <tromey@adacore.com>
11441
11442         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11443         define.
11444         * python/py-value.c: Remove Python 2.4 workaround.
11445         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11446         workaround.
11447         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11448         Python 2.4 workaround.
11449         * python/python-internal.h: Remove Python 2.4 comment.
11450         (Py_ssize_t): Don't define.
11451         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11452         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11453         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11454         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11455         * python/python.c (do_start_initialization): Remove Python 2.4
11456         workaround.
11457         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11458         (print_children): Remove Python 2.4 workaround.
11459         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11460         workaround.
11461         (CHARBUFFERPROC_NAME): Remove.
11462         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11463         Python 2.4 workaround.
11464
11465 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11466
11467         * NEWS: Note minimum Python version.
11468
11469 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11470
11471         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11472         code from these functions.  Remove corresponding ifdefs.  Use
11473         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11474         Remove gotos and target of gotos.
11475         (infpy_search_memory): Likewise.
11476
11477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11478
11479         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11480         (hppa_gdbarch_init): Don't register deleted functions with
11481         gdbarch.
11482
11483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11484
11485         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11486         (h8300_unwind_sp): Delete.
11487         (h8300_dummy_id): Delete.
11488         (h8300_gdbarch_init): Don't register deleted functions with
11489         gdbarch.
11490
11491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11492
11493         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11494         (ft32_unwind_pc): Delete.
11495         (ft32_unwind_sp): Delete.
11496         (ft32_gdbarch_init): Don't register deleted functions with
11497         gdbarch.
11498
11499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11500
11501         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11502         (frv_unwind_pc): Delete.
11503         (frv_unwind_sp): Delete.
11504         (frv_gdbarch_init): Don't register deleted functions with
11505         gdbarch.
11506
11507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11508
11509         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11510         (riscv_unwind_pc): Delete.
11511         (riscv_unwind_sp): Delete.
11512         (riscv_gdbarch_init): Don't register deleted functions with
11513         gdbarch.
11514
11515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11516
11517         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11518         (csky_unwind_pc): Delete.
11519         (csky_unwind_sp): Delete.
11520         (csky_gdbarch_init): Don't register deleted functions with
11521         gdbarch.
11522
11523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11524
11525         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11526         (cris_unwind_pc): Delete.
11527         (cris_unwind_sp): Delete.
11528         (cris_gdbarch_init): Don't register deleted functions with
11529         gdbarch.
11530
11531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11532
11533         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11534         (bfin_unwind_pc): Delete.
11535         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11536
11537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11538
11539         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11540         (arm_unwind_pc): Delete.
11541         (arm_unwind_sp): Delete.
11542         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11543
11544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11545
11546         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11547         (arc_unwind_pc): Delete.
11548         (arc_unwind_sp): Delete.
11549         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11550
11551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11552
11553         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11554         (alpha_unwind_pc): Delete.
11555         (alpha_gdbarch_init): Don't register deleted functions with
11556         gdbarch.
11557
11558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11559
11560         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11561         (aarch64_unwind_pc): Delete.
11562         (aarch64_unwind_sp): Delete.
11563         (aarch64_gdbarch_init): Don't register deleted functions with
11564         gdbarch.
11565
11566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11567
11568         * gdbtypes.c (type_align): Don't consider static members when
11569         computing structure alignment.
11570
11571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11572
11573         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11574         return 0 for other types.
11575         * arch-utils.c (default_type_align): Always return 0.
11576         * gdbarch.h: Regenerate.
11577         * gdbarch.sh (type_align): Extend comment.
11578         * gdbtypes.c (type_align): Add additional comments, always call
11579         gdbarch_type_align before applying the default rules.
11580         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11581         generic code will then apply a suitable default.
11582         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11583         types, return 0 for other types.
11584
11585 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11586
11587         * NEWS: Create a new section for the next release branch.
11588         Rename the section of the current branch, now that it has
11589         been cut.
11590
11591 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11592
11593         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11594         * version.in: Bump version to 8.3.50.DATE-git.
11595
11596 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11597
11598         * aix-thread.c (ptid_cmp): Remove unused variable.
11599         (get_signaled_thread): Likewise.
11600         (store_regs_user_thread): Likewise.
11601         (store_regs_kernel_thread): Likewise.
11602         (fetch_regs_kernel_thread): Remove shadowed variable.
11603
11604 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11605
11606         * features/riscv/32bit-cpu.xml: Add register numbers.
11607         * features/riscv/32bit-fpu.c: Regenerate.
11608         * features/riscv/32bit-fpu.xml: Add register numbers.
11609         * features/riscv/64bit-cpu.xml: Add register numbers.
11610         * features/riscv/64bit-fpu.c: Regenerate.
11611         * features/riscv/64bit-fpu.xml: Add register numbers.
11612
11613 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11614
11615         * NEWS: Mention two argument form of gdb.Value constructor.
11616         * python/py-value.c (convert_buffer_and_type_to_value): New
11617         function.
11618         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11619         Add support for handling an optional second argument.  Call
11620         convert_buffer_and_type_to_value as appropriate.
11621         * python/python-internal.h (Py_buffer_deleter): New struct.
11622         (Py_buffer_up): New typedef.
11623
11624 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11625
11626         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11627         instead of releasing ownership.
11628
11629 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11630
11631         * dwarf2read.c (open_and_init_dwp_file): Call
11632         elf_numsections instead of bfd_count_sections to initialize
11633         dwp_file->num_sections.
11634
11635 2019-02-25  Tom Tromey  <tromey@adacore.com>
11636
11637         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11638
11639 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11640
11641         * gcore.in: Add '--readnever' option when invoking GDB.
11642
11643 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11644
11645         * MAINTAINERS: Update my email address.
11646
11647 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11648
11649         * build-id.c (build_id_to_debug_bfd_1): New function.
11650         (build_id_to_debug_bfd): Look for separate debug file in
11651         sysroot.
11652
11653 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11654
11655         * gdbarch.sh: Update the copyright year range that is placed into
11656         generated files.
11657
11658 2019-02-22  Keith Seitz  <keiths@redhat.com>
11659
11660         PR symtab/23853
11661         * linespec.c (create_sals_line_offset): Search for the default
11662         symtab's filename instead of its fullname.
11663
11664 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11665
11666         * NEWS: Update style defaults.
11667
11668 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11669
11670         * main.c (captured_main_1): Disable styling in batch mode.
11671
11672 2019-02-20  Tom Tromey  <tom@tromey.com>
11673
11674         * symtab.c (symtab_symbol_info): Fix typos.
11675
11676 2019-02-20  Tom Tromey  <tromey@adacore.com>
11677
11678         * findcmd.c (_initialize_mem_search): Use upper case for
11679         metasyntactic variables.
11680
11681 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11682
11683         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11684         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11685
11686 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11687
11688         * top.h (source_file_name): Change to std::string.
11689         * top.c (source_file_name): Likewise.
11690         (command_line_input): Adjust.
11691         * cli/cli-script.c (script_from_file): Adjust.
11692
11693 2019-02-19  Tom Tromey  <tromey@adacore.com>
11694
11695         * ravenscar-thread.c
11696         (ravenscar_thread_target::update_thread_list): Don't call
11697         ada_build_task_list.
11698         * ada-lang.h (ada_build_task_list): Don't declare.
11699         * ada-tasks.c (struct ada_tasks_inferior_data)
11700         <task_list_valid_p>: Now bool.
11701         (read_known_tasks, ada_task_list_changed)
11702         (ada_tasks_invalidate_inferior_data): Update.
11703         (read_known_tasks_array): Return bool.
11704         (read_known_tasks_list): Likewise.
11705         (read_known_tasks): Return void.
11706         (ada_build_task_list): Now static.
11707
11708 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11709
11710         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11711         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11712
11713 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11714
11715         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11716         variant for ada_tasks_pspace_data_handle and
11717         ada_tasks_inferior_data_handle.
11718         (ada_tasks_pspace_data_cleanup): New function.
11719         (ada_tasks_inferior_data_cleanup): New function.
11720
11721 2019-02-17  Tom Tromey  <tom@tromey.com>
11722
11723         * macrotab.h (macro_source_fullname): Return a std::string.
11724         * macrotab.c (macro_include, check_for_redefinition)
11725         (macro_undef, macro_lookup_definition, foreach_macro)
11726         (foreach_macro_in_scope): Update.
11727         (macro_source_fullname): Return a std::string.
11728         * macrocmd.c (show_pp_source_pos): Update.
11729
11730 2019-02-17  Tom Tromey  <tom@tromey.com>
11731
11732         * macrocmd.c (show_pp_source_pos): Style the file names.
11733
11734 2019-02-17  Tom Tromey  <tom@tromey.com>
11735
11736         PR tui/24197:
11737         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11738
11739 2019-02-17  Tom Tromey  <tom@tromey.com>
11740
11741         * ada-lang.c (user_select_syms): Use filtered printing.
11742         * utils.c (wrap_style): New global.
11743         (desired_style): Remove.
11744         (emit_style_escape): Add stream parameter.
11745         (set_output_style, reset_terminal_style, prompt_for_continue):
11746         Update.
11747         (flush_wrap_buffer): Only flush gdb_stdout.
11748         (wrap_here): Set wrap_style.
11749         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11750         treat escape sequences as a character.  Change when wrap buffer is
11751         flushed.
11752         (fputs_styled): Do not set the output style when the default is
11753         requested.
11754         * ui-style.h (struct ui_file_style) <is_default>: New method.
11755         * source.c (print_source_lines_base): Emit escape sequences in one
11756         piece.
11757
11758 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11759
11760         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11761         integers and enumeration types.
11762
11763 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11764
11765         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11766         instead of lookup_symbol_in_language
11767         (do_exact_match): New function.
11768         (ada_get_symbol_name_matcher): Return do_exact_match when
11769         doing a verbatim match.
11770
11771 2019-02-15  Tom Tromey  <tromey@adacore.com>
11772
11773         * ravenscar-thread.c (ravenscar_thread_target::resume)
11774         (ravenscar_thread_target::wait): Special case wildcard requests.
11775
11776 2019-02-15  Tom Tromey  <tromey@adacore.com>
11777
11778         * ravenscar-thread.c (base_ptid): Remove.
11779         (struct ravenscar_thread_target) <close>: New method.
11780         <m_base_ptid>: New member.
11781         <update_inferior_ptid, active_task, task_is_currently_active,
11782         runtime_initialized>: Declare methods.
11783         <ravenscar_thread_target>: Add constructor.
11784         (ravenscar_thread_target::task_is_currently_active)
11785         (ravenscar_thread_target::update_inferior_ptid)
11786         (ravenscar_runtime_initialized): Rename.  Now methods.
11787         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11788         (ravenscar_thread_target::update_thread_list): Update.
11789         (ravenscar_thread_target::active_task): Now method.
11790         (ravenscar_thread_target::store_registers)
11791         (ravenscar_thread_target::prepare_to_store)
11792         (ravenscar_thread_target::prepare_to_store)
11793         (ravenscar_thread_target::mourn_inferior): Update.
11794         (ravenscar_inferior_created): Use "new" to create target.
11795         (ravenscar_thread_target::get_ada_task_ptid): Update.
11796         (_initialize_ravenscar): Don't initialize base_ptid.
11797         (ravenscar_ops): Remove global.
11798
11799 2019-02-15  Tom Tromey  <tromey@adacore.com>
11800
11801         * target.h (push_target): Declare new overload.
11802         * target.c (push_target): New overload, taking an rvalue reference.
11803         * remote.c (remote_target::open_1): Use push_target overload.
11804         * corelow.c (core_target_open): Use push_target overload.
11805
11806 2019-02-15  Tom Tromey  <tromey@adacore.com>
11807
11808         * ravenscar-thread.c (is_ravenscar_task)
11809         (ravenscar_task_is_currently_active): Return bool.
11810         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11811         (_initialize_ravenscar): Remove "(void)".
11812         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11813         Return bool.
11814
11815 2019-02-15  Tom Tromey  <tromey@adacore.com>
11816
11817         * ravenscar-thread.c (ravenscar_runtime_initializer)
11818         (has_ravenscar_runtime, get_running_thread_id)
11819         (ravenscar_thread_target::resume): Fix indentation.
11820
11821 2019-02-15  Tom Tromey  <tromey@adacore.com>
11822
11823         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11824         from ravenscar_arch_ops.
11825         (sparc_ravenscar_ops::fetch_registers)
11826         (sparc_ravenscar_ops::store_registers): Now methods.
11827         (sparc_ravenscar_prepare_to_store): Remove.
11828         (sparc_ravenscar_ops): Redefine.
11829         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11830         methods and destructor.  Remove members.
11831         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11832         (ravenscar_thread_target::store_registers)
11833         (ravenscar_thread_target::prepare_to_store): Update.
11834         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11835         Remove.
11836         (struct ppc_ravenscar_powerpc_ops): Derive from
11837         ravenscar_arch_ops.
11838         (ppc_ravenscar_powerpc_ops::fetch_registers)
11839         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11840         (ppc_ravenscar_powerpc_ops): Redefine.
11841         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11842         (ppc_ravenscar_e500_ops::fetch_registers)
11843         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11844         (ppc_ravenscar_e500_ops): Redefine.
11845         * aarch64-ravenscar-thread.c
11846         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11847         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11848         (aarch64_ravenscar_fetch_registers)
11849         (aarch64_ravenscar_store_registers): Now methods.
11850         (aarch64_ravenscar_ops): Redefine.
11851
11852 2019-02-15  Tom Tromey  <tromey@adacore.com>
11853
11854         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11855         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11856         (ravenscar_thread_target::stopped_by_watchpoint)
11857         (ravenscar_thread_target::stopped_data_address)
11858         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11859
11860 2019-02-15  Tom Tromey  <tromey@adacore.com>
11861
11862         * ravenscar-thread.c: Fix some typos.
11863
11864 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11865             Tom Tromey  <tromey@adacore.com>
11866
11867         * ada-lang.c (ada_exception_sal): Change addr_string to a
11868         std::string.
11869         (create_ada_exception_catchpoint): Update.
11870
11871 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11872             Tom Tromey  <tromey@adacore.com>
11873
11874         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11875         (bp_location_ops): Remove.
11876         (base_breakpoint_allocate_location): Update.
11877         (free_bp_location): Update.
11878         * ada-lang.c (class ada_catchpoint_location)
11879         <ada_catchpoint_location>: Remove ops parameter.
11880         (ada_catchpoint_location_dtor): Remove.
11881         (ada_catchpoint_location_ops): Remove.
11882         (allocate_location_exception): Update.
11883         * breakpoint.h (struct bp_location_ops): Remove.
11884         (class bp_location) <bp_location>: Remove bp_location_ops
11885         parameter.
11886         <~bp_location>: Add destructor.
11887         <ops>: Remove.
11888
11889 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11890             Pedro Alves  <palves@redhat.com>
11891
11892         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11893         'PATH_MAX'.
11894
11895 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11896             Samuel Thibault  <samuel.thibault@gnu.org>
11897             Thomas Schwinge  <thomas@codesourcery.com>
11898
11899         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11900         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11901
11902 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11903
11904         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11905         (check_empty): Use "const char *".
11906
11907         * gnu-nat.c (gnu_nat_target::detach): Instead of
11908         'detach_inferior (pid)' call
11909         'detach_inferior (find_inferior_pid (pid))'.
11910
11911         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11912         'nat/fork-inferior.o'.
11913         * gnu-nat.c: #include "nat/fork-inferior.h".
11914
11915         * gnu-nat.c (gnu_nat_target::detach): Instead of
11916         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11917         * gnu-nat.h: #include "inf-child.h".
11918         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11919         'i386_gnu_nat_target::fetch_registers'.
11920         (gnu_store_registers): Rename/move to
11921         'i386_gnu_nat_target::store_registers'.
11922
11923         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11924         * gnu-nat.h (mach_thread_info): New function.
11925         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11926
11927         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11928
11929 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11930
11931         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11932
11933 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11934
11935         * windows-nat.c (windows_add_thread): Add new parameter
11936         "main_thread_p" with default value set to false.  Update
11937         function documentation as well as all callers.
11938         (windows_delete_thread): Likewise.
11939         (fake_create_process): Update call to windows_add_thread.
11940         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11941         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11942         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11943         call to windows_delete_thread.
11944
11945 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11946
11947         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11948
11949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11950
11951         * symfile.c (find_separate_debug_file): Use canonical path of
11952         sysroot with child_path instead of gdb_sysroot if it is valid.
11953
11954 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11955
11956         * symfile.c (find_separate_debug_file): Use child_path to
11957         determine if an object file is under a sysroot.
11958
11959 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11960
11961         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11962         unittests/child-path-selftests.c.
11963         * common/pathstuff.c (child_path): New function.
11964         * common/pathstuff.h (child_path): New prototype.
11965         * unittests/child-path-selftests.c: New file.
11966
11967 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11968
11969         * symfile.c (find_separate_debug_file): Look for separate debug
11970         files in debug directories under the sysroot.
11971
11972 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11973
11974         * symtab.h (struct minimal_symbol data_p): New const method.
11975         (struct minimal_symbol text_p): Likewise.
11976         * symtab.c (output_source_filename): Use file name style
11977         to print file name.
11978         (print_symbol_info): Likewise.
11979         (print_msymbol_info): Use address style to print addresses.
11980         Use function name style to print executable text symbols.
11981         (expand_symtab_containing_pc): Use data_p.
11982         (find_pc_sect_compunit_symtab): Likewise.
11983
11984 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11985
11986         * breakpoint.c (describe_other_breakpoints): Use address style
11987         to print addresses.
11988         (say_where): Likewise.
11989
11990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11991
11992         * ada-typeprint.c (print_func_type): Print function name
11993         style to print function name.
11994         * c-typeprint.c (c_print_type_1): Likewise.
11995
11996 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11997
11998         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11999         for execve.
12000
12001 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12002
12003         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12004         type_stack.
12005
12006 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12007
12008         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12009         TYPE_CODE_REF types.
12010
12011 2019-02-08  Jim Wilson  <jimw@sifive.com>
12012
12013         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12014         (riscv_linux_fregset): New.
12015         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12016
12017 2019-02-07  Tom Tromey  <tom@tromey.com>
12018
12019         * thread.c (thread_cancel_execution_command): Update.
12020         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12021         methods.
12022         (struct thread_fsm_ops): Remove.
12023         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12024         (thread_fsm_should_stop, thread_fsm_return_value)
12025         (thread_fsm_set_finished, thread_fsm_finished_p)
12026         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12027         Don't declare.
12028         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12029         * infrun.c (clear_proceed_status_thread)
12030         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12031         (print_stop_event): Update.
12032         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12033         Add constructor.
12034         (step_command_fsm_ops): Remove.
12035         (new_step_command_fsm): Remove.
12036         (step_1): Update.
12037         (step_command_fsm::should_stop): Rename from
12038         step_command_fsm_should_stop.
12039         (step_command_fsm::clean_up): Rename from
12040         step_command_fsm_clean_up.
12041         (step_command_fsm::do_async_reply_reason): Rename from
12042         step_command_fsm_async_reply_reason.
12043         (struct until_next_fsm): Inherit from thread_fsm.  Add
12044         constructor.
12045         (until_next_fsm_ops): Remove.
12046         (new_until_next_fsm): Remove.
12047         (until_next_fsm::should_stop): Rename from
12048         until_next_fsm_should_stop.
12049         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12050         (until_next_fsm::do_async_reply_reason): Rename from
12051         until_next_fsm_async_reply_reason.
12052         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12053         constructor.  Change type of breakpoint.
12054         (finish_command_fsm_ops): Remove.
12055         (new_finish_command_fsm): Remove.
12056         (finish_command_fsm::should_stop): Rename from
12057         finish_command_fsm_should_stop.
12058         (finish_command_fsm::clean_up): Rename from
12059         finish_command_fsm_clean_up.
12060         (finish_command_fsm::return_value): Rename from
12061         finish_command_fsm_return_value.
12062         (finish_command_fsm::do_async_reply_reason): Rename from
12063         finish_command_fsm_async_reply_reason.
12064         (finish_command): Update.
12065         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12066         Add constructor.
12067         (call_thread_fsm_ops): Remove.
12068         (call_thread_fsm::call_thread_fsm): Rename from
12069         new_call_thread_fsm.
12070         (call_thread_fsm::should_stop): Rename from
12071         call_thread_fsm_should_stop.
12072         (call_thread_fsm::should_notify_stop): Rename from
12073         call_thread_fsm_should_notify_stop.
12074         (run_inferior_call, call_function_by_hand_dummy): Update.
12075         * cli/cli-interp.c (should_print_stop_to_console): Update.
12076         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12077         Add constructor.  Change type of location_breakpoint,
12078         caller_breakpoint.
12079         (until_break_fsm_ops): Remove.
12080         (new_until_break_fsm): Remove.
12081         (until_break_fsm::should_stop): Rename from
12082         until_break_fsm_should_stop.
12083         (until_break_fsm::clean_up): Rename from
12084         until_break_fsm_clean_up.
12085         (until_break_fsm::do_async_reply_reason): Rename from
12086         until_break_fsm_async_reply_reason.
12087         (until_break_command): Update.
12088         * thread-fsm.c: Remove.
12089         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12090
12091 2019-02-07  Tom Tromey  <tom@tromey.com>
12092
12093         * yy-remap.h: Add include guard.
12094         * xtensa-tdep.h: Add include guard.
12095         * xcoffread.h: Rename include guard.
12096         * varobj-iter.h: Add include guard.
12097         * tui/tui.h: Rename include guard.
12098         * tui/tui-winsource.h: Rename include guard.
12099         * tui/tui-wingeneral.h: Rename include guard.
12100         * tui/tui-windata.h: Rename include guard.
12101         * tui/tui-win.h: Rename include guard.
12102         * tui/tui-stack.h: Rename include guard.
12103         * tui/tui-source.h: Rename include guard.
12104         * tui/tui-regs.h: Rename include guard.
12105         * tui/tui-out.h: Rename include guard.
12106         * tui/tui-layout.h: Rename include guard.
12107         * tui/tui-io.h: Rename include guard.
12108         * tui/tui-hooks.h: Rename include guard.
12109         * tui/tui-file.h: Rename include guard.
12110         * tui/tui-disasm.h: Rename include guard.
12111         * tui/tui-data.h: Rename include guard.
12112         * tui/tui-command.h: Rename include guard.
12113         * tic6x-tdep.h: Add include guard.
12114         * target/waitstatus.h: Rename include guard.
12115         * target/wait.h: Rename include guard.
12116         * target/target.h: Rename include guard.
12117         * target/resume.h: Rename include guard.
12118         * target-float.h: Rename include guard.
12119         * stabsread.h: Add include guard.
12120         * rs6000-tdep.h: Add include guard.
12121         * riscv-fbsd-tdep.h: Add include guard.
12122         * regformats/regdef.h: Rename include guard.
12123         * record.h: Rename include guard.
12124         * python/python.h: Rename include guard.
12125         * python/python-internal.h: Rename include guard.
12126         * python/py-stopevent.h: Rename include guard.
12127         * python/py-ref.h: Rename include guard.
12128         * python/py-record.h: Rename include guard.
12129         * python/py-record-full.h: Rename include guard.
12130         * python/py-record-btrace.h: Rename include guard.
12131         * python/py-instruction.h: Rename include guard.
12132         * python/py-events.h: Rename include guard.
12133         * python/py-event.h: Rename include guard.
12134         * procfs.h: Add include guard.
12135         * proc-utils.h: Add include guard.
12136         * p-lang.h: Add include guard.
12137         * or1k-tdep.h: Rename include guard.
12138         * observable.h: Rename include guard.
12139         * nto-tdep.h: Rename include guard.
12140         * nat/x86-linux.h: Rename include guard.
12141         * nat/x86-linux-dregs.h: Rename include guard.
12142         * nat/x86-gcc-cpuid.h: Add include guard.
12143         * nat/x86-dregs.h: Rename include guard.
12144         * nat/x86-cpuid.h: Rename include guard.
12145         * nat/ppc-linux.h: Rename include guard.
12146         * nat/mips-linux-watch.h: Rename include guard.
12147         * nat/linux-waitpid.h: Rename include guard.
12148         * nat/linux-ptrace.h: Rename include guard.
12149         * nat/linux-procfs.h: Rename include guard.
12150         * nat/linux-osdata.h: Rename include guard.
12151         * nat/linux-nat.h: Rename include guard.
12152         * nat/linux-namespaces.h: Rename include guard.
12153         * nat/linux-btrace.h: Rename include guard.
12154         * nat/glibc_thread_db.h: Rename include guard.
12155         * nat/gdb_thread_db.h: Rename include guard.
12156         * nat/gdb_ptrace.h: Rename include guard.
12157         * nat/fork-inferior.h: Rename include guard.
12158         * nat/amd64-linux-siginfo.h: Rename include guard.
12159         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12160         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12161         * nat/aarch64-linux.h: Rename include guard.
12162         * nat/aarch64-linux-hw-point.h: Rename include guard.
12163         * mn10300-tdep.h: Add include guard.
12164         * mips-linux-tdep.h: Add include guard.
12165         * mi/mi-parse.h: Rename include guard.
12166         * mi/mi-out.h: Rename include guard.
12167         * mi/mi-main.h: Rename include guard.
12168         * mi/mi-interp.h: Rename include guard.
12169         * mi/mi-getopt.h: Rename include guard.
12170         * mi/mi-console.h: Rename include guard.
12171         * mi/mi-common.h: Rename include guard.
12172         * mi/mi-cmds.h: Rename include guard.
12173         * mi/mi-cmd-break.h: Rename include guard.
12174         * m2-lang.h: Add include guard.
12175         * location.h: Rename include guard.
12176         * linux-record.h: Rename include guard.
12177         * linux-nat.h: Add include guard.
12178         * linux-fork.h: Add include guard.
12179         * i386-darwin-tdep.h: Rename include guard.
12180         * hppa-linux-offsets.h: Add include guard.
12181         * guile/guile.h: Rename include guard.
12182         * guile/guile-internal.h: Rename include guard.
12183         * gnu-nat.h: Rename include guard.
12184         * gdb-stabs.h: Rename include guard.
12185         * frv-tdep.h: Add include guard.
12186         * f-lang.h: Add include guard.
12187         * event-loop.h: Add include guard.
12188         * darwin-nat.h: Rename include guard.
12189         * cp-abi.h: Rename include guard.
12190         * config/sparc/nm-sol2.h: Rename include guard.
12191         * config/nm-nto.h: Rename include guard.
12192         * config/nm-linux.h: Add include guard.
12193         * config/i386/nm-i386gnu.h: Rename include guard.
12194         * config/djgpp/nl_types.h: Rename include guard.
12195         * config/djgpp/langinfo.h: Rename include guard.
12196         * compile/gcc-cp-plugin.h: Add include guard.
12197         * compile/gcc-c-plugin.h: Add include guard.
12198         * compile/compile.h: Rename include guard.
12199         * compile/compile-object-run.h: Rename include guard.
12200         * compile/compile-object-load.h: Rename include guard.
12201         * compile/compile-internal.h: Rename include guard.
12202         * compile/compile-cplus.h: Rename include guard.
12203         * compile/compile-c.h: Rename include guard.
12204         * common/xml-utils.h: Rename include guard.
12205         * common/x86-xstate.h: Rename include guard.
12206         * common/version.h: Rename include guard.
12207         * common/vec.h: Rename include guard.
12208         * common/tdesc.h: Rename include guard.
12209         * common/selftest.h: Rename include guard.
12210         * common/scoped_restore.h: Rename include guard.
12211         * common/scoped_mmap.h: Rename include guard.
12212         * common/scoped_fd.h: Rename include guard.
12213         * common/safe-iterator.h: Rename include guard.
12214         * common/run-time-clock.h: Rename include guard.
12215         * common/refcounted-object.h: Rename include guard.
12216         * common/queue.h: Rename include guard.
12217         * common/ptid.h: Rename include guard.
12218         * common/print-utils.h: Rename include guard.
12219         * common/preprocessor.h: Rename include guard.
12220         * common/pathstuff.h: Rename include guard.
12221         * common/observable.h: Rename include guard.
12222         * common/netstuff.h: Rename include guard.
12223         * common/job-control.h: Rename include guard.
12224         * common/host-defs.h: Rename include guard.
12225         * common/gdb_wait.h: Rename include guard.
12226         * common/gdb_vecs.h: Rename include guard.
12227         * common/gdb_unlinker.h: Rename include guard.
12228         * common/gdb_unique_ptr.h: Rename include guard.
12229         * common/gdb_tilde_expand.h: Rename include guard.
12230         * common/gdb_sys_time.h: Rename include guard.
12231         * common/gdb_string_view.h: Rename include guard.
12232         * common/gdb_splay_tree.h: Rename include guard.
12233         * common/gdb_setjmp.h: Rename include guard.
12234         * common/gdb_ref_ptr.h: Rename include guard.
12235         * common/gdb_optional.h: Rename include guard.
12236         * common/gdb_locale.h: Rename include guard.
12237         * common/gdb_assert.h: Rename include guard.
12238         * common/filtered-iterator.h: Rename include guard.
12239         * common/filestuff.h: Rename include guard.
12240         * common/fileio.h: Rename include guard.
12241         * common/environ.h: Rename include guard.
12242         * common/common-utils.h: Rename include guard.
12243         * common/common-types.h: Rename include guard.
12244         * common/common-regcache.h: Rename include guard.
12245         * common/common-inferior.h: Rename include guard.
12246         * common/common-gdbthread.h: Rename include guard.
12247         * common/common-exceptions.h: Rename include guard.
12248         * common/common-defs.h: Rename include guard.
12249         * common/common-debug.h: Rename include guard.
12250         * common/cleanups.h: Rename include guard.
12251         * common/buffer.h: Rename include guard.
12252         * common/btrace-common.h: Rename include guard.
12253         * common/break-common.h: Rename include guard.
12254         * cli/cli-utils.h: Rename include guard.
12255         * cli/cli-style.h: Rename include guard.
12256         * cli/cli-setshow.h: Rename include guard.
12257         * cli/cli-script.h: Rename include guard.
12258         * cli/cli-interp.h: Rename include guard.
12259         * cli/cli-decode.h: Rename include guard.
12260         * cli/cli-cmds.h: Rename include guard.
12261         * charset-list.h: Add include guard.
12262         * buildsym-legacy.h: Rename include guard.
12263         * bfin-tdep.h: Add include guard.
12264         * ax.h: Rename include guard.
12265         * arm-linux-tdep.h: Add include guard.
12266         * arm-fbsd-tdep.h: Add include guard.
12267         * arch/xtensa.h: Rename include guard.
12268         * arch/tic6x.h: Add include guard.
12269         * arch/i386.h: Add include guard.
12270         * arch/arm.h: Rename include guard.
12271         * arch/arm-linux.h: Rename include guard.
12272         * arch/arm-get-next-pcs.h: Rename include guard.
12273         * arch/amd64.h: Add include guard.
12274         * arch/aarch64-insn.h: Rename include guard.
12275         * arch-utils.h: Rename include guard.
12276         * annotate.h: Add include guard.
12277         * amd64-darwin-tdep.h: Rename include guard.
12278         * aarch64-linux-tdep.h: Add include guard.
12279         * aarch64-fbsd-tdep.h: Add include guard.
12280         * aarch32-linux-nat.h: Add include guard.
12281
12282 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12283
12284         * macrotab.c (macro_define_internal): New function that
12285         factorizes macro_define_object_internal and macro_define_function
12286         code.
12287         (macro_define_object_internal): Use macro_define_internal.
12288         (macro_define_function): Likewise.
12289
12290 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12291
12292         * macrocmd.c (extract_identifier): Return
12293         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12294         callers.
12295
12296 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12297
12298         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12299
12300 2019-02-05  Tom Tromey  <tom@tromey.com>
12301
12302         * target.c (target_stack::unpush): Move assertion earlier.
12303
12304 2019-01-30  Tom Tromey  <tom@tromey.com>
12305
12306         PR python/23615:
12307         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12308         (gdbpy_parse_and_eval): Likewise.
12309         * python/python-internal.h (gdbpy_allow_threads): New class.
12310
12311 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12312
12313         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12314         (aarch64_fbsd_fpregmap): Move earlier.
12315         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12316         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12317         instead of individual calls to trad_frame_set_reg_addr.
12318         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12319         earlier.
12320         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12321         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12322         instead of individual calls to trad_frame_set_reg_addr.
12323
12324 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12325
12326         * CONTRIBUTE: Replace contribution list with wiki link.
12327
12328 2019-01-25  Tom Tromey  <tom@tromey.com>
12329
12330         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12331
12332 2019-01-25  Tom Tromey  <tom@tromey.com>
12333
12334         * xtensa-linux-nat.c: Fix common/ includes.
12335         * xml-support.h: Fix common/ includes.
12336         * xml-support.c: Fix common/ includes.
12337         * x86-linux-nat.c: Fix common/ includes.
12338         * windows-nat.c: Fix common/ includes.
12339         * varobj.h: Fix common/ includes.
12340         * varobj.c: Fix common/ includes.
12341         * value.c: Fix common/ includes.
12342         * valops.c: Fix common/ includes.
12343         * utils.c: Fix common/ includes.
12344         * unittests/xml-utils-selftests.c: Fix common/ includes.
12345         * unittests/utils-selftests.c: Fix common/ includes.
12346         * unittests/unpack-selftests.c: Fix common/ includes.
12347         * unittests/tracepoint-selftests.c: Fix common/ includes.
12348         * unittests/style-selftests.c: Fix common/ includes.
12349         * unittests/string_view-selftests.c: Fix common/ includes.
12350         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12351         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12352         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12353         * unittests/rsp-low-selftests.c: Fix common/ includes.
12354         * unittests/parse-connection-spec-selftests.c: Fix common/
12355         includes.
12356         * unittests/optional-selftests.c: Fix common/ includes.
12357         * unittests/offset-type-selftests.c: Fix common/ includes.
12358         * unittests/observable-selftests.c: Fix common/ includes.
12359         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12360         * unittests/memrange-selftests.c: Fix common/ includes.
12361         * unittests/memory-map-selftests.c: Fix common/ includes.
12362         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12363         * unittests/function-view-selftests.c: Fix common/ includes.
12364         * unittests/environ-selftests.c: Fix common/ includes.
12365         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12366         * unittests/common-utils-selftests.c: Fix common/ includes.
12367         * unittests/cli-utils-selftests.c: Fix common/ includes.
12368         * unittests/array-view-selftests.c: Fix common/ includes.
12369         * ui-file.c: Fix common/ includes.
12370         * tui/tui-io.c: Fix common/ includes.
12371         * tracepoint.h: Fix common/ includes.
12372         * tracepoint.c: Fix common/ includes.
12373         * tracefile-tfile.c: Fix common/ includes.
12374         * top.h: Fix common/ includes.
12375         * top.c: Fix common/ includes.
12376         * thread.c: Fix common/ includes.
12377         * target/waitstatus.h: Fix common/ includes.
12378         * target/waitstatus.c: Fix common/ includes.
12379         * target.h: Fix common/ includes.
12380         * target.c: Fix common/ includes.
12381         * target-memory.c: Fix common/ includes.
12382         * target-descriptions.c: Fix common/ includes.
12383         * symtab.h: Fix common/ includes.
12384         * symfile.c: Fix common/ includes.
12385         * stap-probe.c: Fix common/ includes.
12386         * spu-linux-nat.c: Fix common/ includes.
12387         * sparc-nat.c: Fix common/ includes.
12388         * source.c: Fix common/ includes.
12389         * solib.c: Fix common/ includes.
12390         * solib-target.c: Fix common/ includes.
12391         * ser-unix.c: Fix common/ includes.
12392         * ser-tcp.c: Fix common/ includes.
12393         * ser-pipe.c: Fix common/ includes.
12394         * ser-base.c: Fix common/ includes.
12395         * selftest-arch.c: Fix common/ includes.
12396         * s12z-tdep.c: Fix common/ includes.
12397         * rust-exp.y: Fix common/ includes.
12398         * rs6000-aix-tdep.c: Fix common/ includes.
12399         * riscv-tdep.c: Fix common/ includes.
12400         * remote.c: Fix common/ includes.
12401         * remote-notif.h: Fix common/ includes.
12402         * remote-fileio.h: Fix common/ includes.
12403         * remote-fileio.c: Fix common/ includes.
12404         * regcache.h: Fix common/ includes.
12405         * regcache.c: Fix common/ includes.
12406         * record-btrace.c: Fix common/ includes.
12407         * python/python.c: Fix common/ includes.
12408         * python/py-type.c: Fix common/ includes.
12409         * python/py-inferior.c: Fix common/ includes.
12410         * progspace.h: Fix common/ includes.
12411         * producer.c: Fix common/ includes.
12412         * procfs.c: Fix common/ includes.
12413         * proc-api.c: Fix common/ includes.
12414         * printcmd.c: Fix common/ includes.
12415         * ppc-linux-nat.c: Fix common/ includes.
12416         * parser-defs.h: Fix common/ includes.
12417         * osdata.c: Fix common/ includes.
12418         * obsd-nat.c: Fix common/ includes.
12419         * nat/x86-linux.c: Fix common/ includes.
12420         * nat/x86-linux-dregs.c: Fix common/ includes.
12421         * nat/x86-dregs.h: Fix common/ includes.
12422         * nat/x86-dregs.c: Fix common/ includes.
12423         * nat/ppc-linux.c: Fix common/ includes.
12424         * nat/mips-linux-watch.h: Fix common/ includes.
12425         * nat/mips-linux-watch.c: Fix common/ includes.
12426         * nat/linux-waitpid.c: Fix common/ includes.
12427         * nat/linux-ptrace.h: Fix common/ includes.
12428         * nat/linux-ptrace.c: Fix common/ includes.
12429         * nat/linux-procfs.c: Fix common/ includes.
12430         * nat/linux-personality.c: Fix common/ includes.
12431         * nat/linux-osdata.c: Fix common/ includes.
12432         * nat/linux-namespaces.c: Fix common/ includes.
12433         * nat/linux-btrace.h: Fix common/ includes.
12434         * nat/linux-btrace.c: Fix common/ includes.
12435         * nat/fork-inferior.c: Fix common/ includes.
12436         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12437         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12438         * nat/aarch64-linux.c: Fix common/ includes.
12439         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12440         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12441         * namespace.h: Fix common/ includes.
12442         * mips-linux-tdep.c: Fix common/ includes.
12443         * minsyms.c: Fix common/ includes.
12444         * mi/mi-parse.h: Fix common/ includes.
12445         * mi/mi-main.c: Fix common/ includes.
12446         * mi/mi-cmd-env.c: Fix common/ includes.
12447         * memrange.h: Fix common/ includes.
12448         * memattr.c: Fix common/ includes.
12449         * maint.h: Fix common/ includes.
12450         * maint.c: Fix common/ includes.
12451         * main.c: Fix common/ includes.
12452         * machoread.c: Fix common/ includes.
12453         * location.c: Fix common/ includes.
12454         * linux-thread-db.c: Fix common/ includes.
12455         * linux-nat.c: Fix common/ includes.
12456         * linux-fork.c: Fix common/ includes.
12457         * inline-frame.c: Fix common/ includes.
12458         * infrun.c: Fix common/ includes.
12459         * inflow.c: Fix common/ includes.
12460         * inferior.h: Fix common/ includes.
12461         * inferior.c: Fix common/ includes.
12462         * infcmd.c: Fix common/ includes.
12463         * inf-ptrace.c: Fix common/ includes.
12464         * inf-child.c: Fix common/ includes.
12465         * ia64-linux-nat.c: Fix common/ includes.
12466         * i387-tdep.c: Fix common/ includes.
12467         * i386-tdep.c: Fix common/ includes.
12468         * i386-linux-tdep.c: Fix common/ includes.
12469         * i386-linux-nat.c: Fix common/ includes.
12470         * i386-go32-tdep.c: Fix common/ includes.
12471         * i386-fbsd-tdep.c: Fix common/ includes.
12472         * i386-fbsd-nat.c: Fix common/ includes.
12473         * guile/scm-type.c: Fix common/ includes.
12474         * guile/guile.c: Fix common/ includes.
12475         * go32-nat.c: Fix common/ includes.
12476         * gnu-nat.c: Fix common/ includes.
12477         * gdbthread.h: Fix common/ includes.
12478         * gdbarch-selftests.c: Fix common/ includes.
12479         * gdb_usleep.c: Fix common/ includes.
12480         * gdb_select.h: Fix common/ includes.
12481         * gdb_bfd.c: Fix common/ includes.
12482         * gcore.c: Fix common/ includes.
12483         * fork-child.c: Fix common/ includes.
12484         * findvar.c: Fix common/ includes.
12485         * fbsd-nat.c: Fix common/ includes.
12486         * event-top.c: Fix common/ includes.
12487         * event-loop.c: Fix common/ includes.
12488         * dwarf2read.c: Fix common/ includes.
12489         * dwarf2loc.c: Fix common/ includes.
12490         * dwarf2-frame.c: Fix common/ includes.
12491         * dwarf-index-cache.c: Fix common/ includes.
12492         * dtrace-probe.c: Fix common/ includes.
12493         * disasm-selftests.c: Fix common/ includes.
12494         * defs.h: Fix common/ includes.
12495         * csky-tdep.c: Fix common/ includes.
12496         * cp-valprint.c: Fix common/ includes.
12497         * cp-support.h: Fix common/ includes.
12498         * cp-support.c: Fix common/ includes.
12499         * corelow.c: Fix common/ includes.
12500         * completer.h: Fix common/ includes.
12501         * completer.c: Fix common/ includes.
12502         * compile/compile.c: Fix common/ includes.
12503         * compile/compile-loc2c.c: Fix common/ includes.
12504         * compile/compile-cplus-types.c: Fix common/ includes.
12505         * compile/compile-cplus-symbols.c: Fix common/ includes.
12506         * command.h: Fix common/ includes.
12507         * cli/cli-dump.c: Fix common/ includes.
12508         * cli/cli-cmds.c: Fix common/ includes.
12509         * charset.c: Fix common/ includes.
12510         * build-id.c: Fix common/ includes.
12511         * btrace.h: Fix common/ includes.
12512         * btrace.c: Fix common/ includes.
12513         * breakpoint.h: Fix common/ includes.
12514         * breakpoint.c: Fix common/ includes.
12515         * ax.h:
12516         (enum agent_op): Fix common/ includes.
12517         * ax-general.c (struct aop_map): Fix common/ includes.
12518         * ax-gdb.c: Fix common/ includes.
12519         * auxv.c: Fix common/ includes.
12520         * auto-load.c: Fix common/ includes.
12521         * arm-tdep.c: Fix common/ includes.
12522         * arch/riscv.c: Fix common/ includes.
12523         * arch/ppc-linux-common.c: Fix common/ includes.
12524         * arch/i386.c: Fix common/ includes.
12525         * arch/arm.c: Fix common/ includes.
12526         * arch/arm-linux.c: Fix common/ includes.
12527         * arch/arm-get-next-pcs.c: Fix common/ includes.
12528         * arch/amd64.c: Fix common/ includes.
12529         * arch/aarch64.c: Fix common/ includes.
12530         * arch/aarch64-insn.c: Fix common/ includes.
12531         * arch-utils.c: Fix common/ includes.
12532         * amd64-windows-tdep.c: Fix common/ includes.
12533         * amd64-tdep.c: Fix common/ includes.
12534         * amd64-sol2-tdep.c: Fix common/ includes.
12535         * amd64-obsd-tdep.c: Fix common/ includes.
12536         * amd64-nbsd-tdep.c: Fix common/ includes.
12537         * amd64-linux-tdep.c: Fix common/ includes.
12538         * amd64-linux-nat.c: Fix common/ includes.
12539         * amd64-fbsd-tdep.c: Fix common/ includes.
12540         * amd64-fbsd-nat.c: Fix common/ includes.
12541         * amd64-dicos-tdep.c: Fix common/ includes.
12542         * amd64-darwin-tdep.c: Fix common/ includes.
12543         * agent.c: Fix common/ includes.
12544         * ada-lang.h: Fix common/ includes.
12545         * ada-lang.c: Fix common/ includes.
12546         * aarch64-tdep.c: Fix common/ includes.
12547
12548 2019-01-25  Tom Tromey  <tom@tromey.com>
12549
12550         * common/create-version.sh: Use common/version.h.
12551
12552 2019-01-24  Pedro Alves  <palves@redhat.com>
12553
12554         * infrun.c (signal_stop, signal_print, signal_program)
12555         (signal_catch, signal_pass): Now arrays instead of pointers.
12556         (update_signals_program_target, do_target_resume)
12557         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12558         * linux-nat.c (linux_nat_target::pass_signals)
12559         (linux_nat_target::create_inferior, linux_nat_target::attach):
12560         Adjust.
12561         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12562         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12563         * procfs.c (procfs_target::pass_signals): Adjust.
12564         * record-full.c (record_full_target::resume): Adjust.
12565         * remote.c (remote_target::pass_signals)
12566         (remote_target::program_signals): Adjust.
12567         * target-debug.h (target_debug_print_signals): Now takes a
12568         gdb::array_view as parameter.  Adjust.
12569         * target.h (target_ops) <pass_signals, program_signals>: Replace
12570         pointer and length parameters with gdb::array_view.
12571         (target_pass_signals, target_program_signals): Likewise.
12572         * target-delegates.c: Regenerate.
12573
12574 2019-01-24  Pedro Alves  <palves@redhat.com>
12575
12576         * common/forward-scope-exit.h
12577         (forward_scope_exit::forward_scope_exit): Pass arguments to
12578         m_bind_function directly, instead of creating a std::bind and
12579         copying that.
12580
12581 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12582
12583         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12584         for static members.
12585         (pass_in_v_vfp_candidate): Likewise.
12586
12587 2019-01-23  Tom Tromey  <tom@tromey.com>
12588             Pedro Alves  <palves@redhat.com>
12589
12590         * regcache.c (class regcache_invalidator): Remove.
12591         (regcache::raw_write): Use make_scope_exit.
12592
12593 2019-01-23  Tom Tromey  <tom@tromey.com>
12594
12595         * ui-out.h (class ui_out_emit_type): Update comment.
12596
12597 2019-01-23  Tom Tromey  <tom@tromey.com>
12598
12599         * infrun.c (fetch_inferior_event): Update comment.
12600
12601 2019-01-23  Tom Tromey  <tom@tromey.com>
12602             Pedro Alves  <palves@redhat.com>
12603
12604         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12605         parameter.
12606         (fetch_inferior_event): Use SCOPE_EXIT.
12607
12608
12609 2019-01-23  Tom Tromey  <tom@tromey.com>
12610             Pedro Alves  <palves@redhat.com>
12611
12612         * infrun.c (disable_thread_events): Delete.
12613         (stop_all_threads): Use SCOPE_EXIT.
12614
12615 2019-01-23  Tom Tromey  <tom@tromey.com>
12616             Pedro Alves  <palves@redhat.com>
12617
12618         * symfile.c: Include forward-scope-exit.h.
12619         (clear_symtab_users_cleanup): Replace forward declaration with
12620         a FORWARD_SCOPE_EXIT.
12621         (syms_from_objfile_1): Use the forward_scope_exit and
12622         gdb::optional instead of cleanup_function.
12623         (reread_symbols): Use the forward_scope_exit instead of
12624         cleanup_function.
12625         (clear_symtab_users_cleanup): Remove function.
12626
12627 2019-01-23  Tom Tromey  <tom@tromey.com>
12628             Pedro Alves  <palves@redhat.com>
12629
12630         * linux-nat.c: Include scope-exit.h.
12631         (cleanup_target_stop): Remove.
12632         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12633         SCOPE_EXIT.
12634
12635 2019-01-23  Tom Tromey  <tom@tromey.com>
12636             Pedro Alves  <palves@redhat.com>
12637
12638         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12639         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12640
12641 2019-01-23  Tom Tromey  <tom@tromey.com>
12642             Andrew Burgess  <andrew.burgess@embecosm.com>
12643             Pedro Alves  <palves@redhat.com>
12644
12645         * infrun.c (fetch_inferior_event): Use scope_exit.
12646         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12647         * top.c (execute_command): Use scope_exit.
12648         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12649         * utils.c (do_bpstat_clear_actions_cleanup)
12650         (make_bpstat_clear_actions_cleanup): Remove.
12651
12652 2019-01-23  Tom Tromey  <tom@tromey.com>
12653             Pedro Alves  <palves@redhat.com>
12654
12655         * infrun.c: Include "common/scope-exit.h"
12656         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12657         (wait_for_inferior): Use SCOPE_EXIT.
12658         (fetch_inferior_event): Use scope_exit.
12659
12660 2019-01-23  Tom Tromey  <tom@tromey.com>
12661             Pedro Alves  <palves@redhat.com>
12662
12663         * breakpoint.c (create_breakpoint): Remove cleanup.
12664
12665 2019-01-23  Tom Tromey  <tom@tromey.com>
12666             Andrew Burgess  <andrew.burgess@embecosm.com>
12667             Pedro Alves  <palves@redhat.com>
12668
12669 2019-01-23  Pedro Alves  <palves@redhat.com>
12670
12671         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12672
12673 2019-01-23  Pedro Alves  <palves@redhat.com>
12674             Andrew Burgess  <andrew.burgess@embecosm.com>
12675
12676         * gdbthread.h: Include "common/forward-scope-exit.h".
12677         (scoped_finish_thread_state): Redefine custom class in terms of
12678         forward_scope_exit.
12679
12680 2019-01-23  Pedro Alves  <palves@redhat.com>
12681             Andrew Burgess  <andrew.burgess@embecosm.com>
12682
12683         * common/forward-scope-exit.h: New file.
12684
12685 2019-01-23  Pedro Alves  <palves@redhat.com>
12686             Andrew Burgess  <andrew.burgess@embecosm.com>
12687             Tom Tromey  <tom@tromey.com>
12688
12689         * common/scope-exit.h: New file.
12690
12691 2019-01-23  Pedro Alves  <palves@redhat.com>
12692
12693         * common/preprocessor.h (ESC): Rename to ...
12694         (ESC_PARENS): ... this.
12695         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12696         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12697
12698 2019-01-23  Tom Tromey  <tom@tromey.com>
12699
12700         * language.h (class scoped_switch_to_sym_language_if_auto):
12701         Initialize m_lang in both cases.
12702
12703 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12704
12705         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12706         with XCNEW.
12707
12708 2019-01-22  Tom Tromey  <tom@tromey.com>
12709
12710         * corelow.c: Do not include sys/file.h.
12711
12712 2019-01-22  Tom Tromey  <tom@tromey.com>
12713
12714         * tui/tui-wingeneral.h: Include gdb_curses.h.
12715
12716 2019-01-22  Tom Tromey  <tom@tromey.com>
12717
12718         * source-cache.h (class source_cache) <get_source_lines,
12719         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12720
12721 2019-01-22  Tom Tromey  <tom@tromey.com>
12722
12723         * remote-fileio.h (struct remote_target): Declare.
12724
12725 2019-01-22  Tom Tromey  <tom@tromey.com>
12726
12727         * python/py-arch.c: Do not include py-ref.h.
12728         * python/py-bpevent.c: Do not include py-ref.h.
12729         * python/py-cmd.c: Do not include py-ref.h.
12730         * python/py-continueevent.c: Do not include py-ref.h.
12731         * python/py-event.h: Do not include py-ref.h.
12732         * python/py-evtregistry.c: Do not include py-ref.h.
12733         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12734         * python/py-frame.c: Do not include py-ref.h.
12735         * python/py-framefilter.c: Do not include py-ref.h.
12736         * python/py-function.c: Do not include py-ref.h.
12737         * python/py-infevents.c: Do not include py-ref.h.
12738         * python/py-linetable.c: Do not include py-ref.h.
12739         * python/py-objfile.c: Do not include py-ref.h.
12740         * python/py-param.c: Do not include py-ref.h.
12741         * python/py-prettyprint.c: Do not include py-ref.h.
12742         * python/py-progspace.c: Do not include py-ref.h.
12743         * python/py-symbol.c: Do not include py-ref.h.
12744         * python/py-symtab.c: Do not include py-ref.h.
12745         * python/py-type.c: Do not include py-ref.h.
12746         * python/py-unwind.c: Do not include py-ref.h.
12747         * python/py-utils.c: Do not include py-ref.h.
12748         * python/py-value.c: Do not include py-ref.h.
12749         * python/py-varobj.c: Do not include py-ref.h.
12750         * python/py-xmethods.c: Do not include py-ref.h.
12751         * python/python.c: Do not include py-ref.h.
12752         * varobj.c: Do not include py-ref.h.
12753
12754 2019-01-22  Tom Tromey  <tom@tromey.com>
12755
12756         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12757         keyword for bcache.
12758
12759 2019-01-22  Tom Tromey  <tom@tromey.com>
12760
12761         * compile/compile-cplus-types.c: Remove a comment by #include.
12762
12763 2019-01-22  Tom Tromey  <tom@tromey.com>
12764
12765         * compile/gcc-c-plugin.h: Include compile-internal.h.
12766
12767 2019-01-22  Tom Tromey  <tom@tromey.com>
12768
12769         * stabsread.c (EXTERN): Do not define.
12770         (symnum, next_symbol_text_func, processing_gcc_compilation)
12771         (within_function, global_sym_chain, global_stabs)
12772         (previous_stab_code, this_object_header_files)
12773         (n_this_object_header_files)
12774         (n_allocated_this_object_header_files): Define.
12775         * stabsread.h (EXTERN): Never define.  Use "extern".
12776
12777 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12778
12779         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12780         history_value.
12781
12782 2019-01-21  Tom Tromey  <tom@tromey.com>
12783
12784         * ui-out.c: Fix includes.
12785         * tui/tui-source.c: Fix includes.
12786         * target.c: Fix includes.
12787         * remote.c: Fix includes.
12788         * regcache.c: Fix includes.
12789         * python/py-block.c: Fix includes.
12790         * printcmd.c: Fix includes.
12791         * or1k-tdep.c: Fix includes.
12792         * mi/mi-main.c: Fix includes.
12793         * m32r-tdep.c: Fix includes.
12794         * csky-tdep.c: Fix includes.
12795         * compile/compile-cplus-types.c: Fix includes.
12796         * cli/cli-interp.c: Fix includes.
12797
12798 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12799
12800         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12801         for padding.
12802
12803 2019-01-16  Tom Tromey  <tom@tromey.com>
12804
12805         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12806         earlier.
12807         (struct objfile) <msymbols_range>: Move from top level.
12808         <msymbols>: New method.
12809         (class objfile_msymbols): Remove.
12810         * symtab.c (default_collect_symbol_completion_matches_break_on):
12811         Update.
12812         * symmisc.c (dump_msymbols): Update.
12813         * stabsread.c (scan_file_globals): Update.
12814         * objc-lang.c (info_selectors_command, info_classes_command)
12815         (find_methods): Update.
12816         * minsyms.c (find_solib_trampoline_target): Update.
12817         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12818         * coffread.c (coff_symfile_read): Update.
12819         * ada-lang.c (ada_lookup_simple_minsym)
12820         (ada_collect_symbol_completion_matches): Update.
12821
12822 2019-01-16  Tom Tromey  <tom@tromey.com>
12823
12824         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12825         type.  Remove no-argument constructor.
12826         <iterator::operator++>: Simplify.
12827         <begin>: Update.
12828         <end>: Use minimal_symbol_count.
12829
12830 2019-01-16  Tom Tromey  <tom@tromey.com>
12831
12832         * objfiles.h (struct objfile) <psymtabs>: New method.
12833         (class objfile_psymtabs): Remove.
12834         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12835         typedef.
12836         <range>: New method.
12837         (require_partial_symbols): Change return type.
12838         * psymtab.c (require_partial_symbols)
12839         (psym_expand_symtabs_matching): Update.
12840         * mdebugread.c (parse_partial_symbols): Update.
12841         * dbxread.c (dbx_end_psymtab): Update.
12842
12843 2019-01-15  Tom Tromey  <tom@tromey.com>
12844
12845         * symtab.c (lookup_objfile_from_block)
12846         (lookup_symbol_in_objfile_symtabs)
12847         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12848         (find_line_symtab, info_sources_command)
12849         (default_collect_symbol_completion_matches_break_on)
12850         (make_source_files_completion_list): Update.
12851         * symmisc.c (print_objfile_statistics, dump_objfile)
12852         (maintenance_print_symbols, maintenance_info_symtabs)
12853         (maintenance_check_symtabs, maintenance_info_line_tables):
12854         Update.
12855         * source.c (select_source_symtab)
12856         (forget_cached_source_info_for_objfile): Update.
12857         * objfiles.h (class objfile_compunits): Remove.
12858         (struct objfile) <compunits_range>: New typedef.
12859         (compunits): New method.
12860         * objfiles.c (objfile_relocate1): Update.
12861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12862         * maint.c (count_symtabs_and_blocks): Update.
12863         * linespec.c (iterate_over_all_matching_symtabs): Update.
12864         * cp-support.c (add_symbol_overload_list_qualified): Update.
12865         * coffread.c (coff_symtab_read): Update.
12866         * ada-lang.c (add_nonlocal_symbols)
12867         (ada_collect_symbol_completion_matches)
12868         (ada_add_global_exceptions): Update.
12869
12870 2019-01-15  Tom Tromey  <tom@tromey.com>
12871
12872         * progspace.h (program_space) <objfiles_safe_range>: New
12873         typedef.
12874         <objfiles_safe>: New method.
12875         * objfiles.h (class all_objfiles_safe): Remove.
12876         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12877         * jit.c (jit_inferior_exit_hook): Update.
12878
12879 2019-01-17  Tom Tromey  <tom@tromey.com>
12880
12881         * progspace.h (program_space) <objfiles_range>: New typedef.
12882         <objfiles>: New method.
12883         <objfiles_head>: Rename from objfiles.
12884         (object_files): Update.
12885         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12886         * guile/scm-pretty-print.c
12887         (ppscm_find_pretty_printer_from_objfiles): Update.
12888         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12889         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12890         Update.
12891         * python/py-progspace.c (pspy_get_objfiles): Update.
12892         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12893         Update.
12894         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12895         (objfpy_lookup_objfile_by_build_id): Update.
12896         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12897         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12898         Update.
12899         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12900         (expand_symtab_containing_pc, lookup_objfile_from_block)
12901         (lookup_static_symbol, basic_lookup_transparent_type)
12902         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12903         (find_line_symtab, info_sources_command)
12904         (default_collect_symbol_completion_matches_break_on)
12905         (make_source_files_completion_list, find_main_name): Update.
12906         * symmisc.c (print_symbol_bcache_statistics)
12907         (print_objfile_statistics, maintenance_print_symbols)
12908         (maintenance_print_msymbols, maintenance_print_objfiles)
12909         (maintenance_info_symtabs, maintenance_check_symtabs)
12910         (maintenance_expand_symtabs, maintenance_info_line_tables):
12911         Update.
12912         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12913         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12914         (map_overlay_command, unmap_overlay_command)
12915         (simple_overlay_update, expand_symtabs_matching)
12916         (map_symbol_filenames): Update.
12917         * symfile-debug.c (set_debug_symfile): Update.
12918         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12919         Update.
12920         * source.c (select_source_symtab, forget_cached_source_info):
12921         Update.
12922         * solib.c (solib_read_symbols): Update.
12923         * solib-spu.c (append_ocl_sos): Update.
12924         * psymtab.c (maintenance_print_psymbols)
12925         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12926         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12927         * printcmd.c (info_symbol_command): Update.
12928         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12929         Update.
12930         * objfiles.h (class all_objfiles): Remove.
12931         * objfiles.c (have_partial_symbols, have_full_symbols)
12932         (have_minimal_symbols, qsort_cmp, update_section_map)
12933         (shared_objfile_contains_address_p)
12934         (default_iterate_over_objfiles_in_search_order): Update.
12935         * objc-lang.c (info_selectors_command, info_classes_command)
12936         (find_methods): Update.
12937         * minsyms.c (find_solib_trampoline_target): Update.
12938         * maint.c (maintenance_info_sections)
12939         (maintenance_translate_address, count_symtabs_and_blocks):
12940         Update.
12941         * main.c (captured_main_1): Update.
12942         * linux-thread-db.c (try_thread_db_load_from_pdir)
12943         (has_libpthread): Update.
12944         * linespec.c (iterate_over_all_matching_symtabs)
12945         (search_minsyms_for_name): Update.
12946         * jit.c (jit_find_objf_with_entry_addr): Update.
12947         * hppa-tdep.c (find_unwind_entry)
12948         (hppa_lookup_stub_minimal_symbol): Update.
12949         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12950         Update.
12951         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12952         (elf_gnu_ifunc_resolve_by_got): Update.
12953         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12954         * dwarf-index-write.c (save_gdb_index_command): Update.
12955         * cp-support.c (add_symbol_overload_list_qualified): Update.
12956         * breakpoint.c (create_overlay_event_breakpoint)
12957         (create_longjmp_master_breakpoint)
12958         (create_std_terminate_master_breakpoint)
12959         (create_exception_master_breakpoint): Update.
12960         * blockframe.c (find_pc_partial_function): Update.
12961         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12962         (ada_collect_symbol_completion_matches)
12963         (ada_add_global_exceptions): Update.
12964
12965 2019-01-17  Tom Tromey  <tom@tromey.com>
12966
12967         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12968         declare VEC.
12969         (solib_target_parse_libraries): Change return type.
12970         (library_list_start_segment, library_list_start_section)
12971         (library_list_end_library, library_list_start_library); Update.
12972         (solib_target_free_library_list): Remove.
12973         (solib_target_parse_libraries): Remove cleanup.  Change return
12974         type.
12975         (solib_target_current_sos): Update.
12976
12977 2019-01-17  Tom Tromey  <tromey@bapiya>
12978
12979         * valprint.c: Replace "the the" with "the".
12980         * symtab.c: Replace "the the" with "the".
12981         * solib.c: Replace "the the" with "the".
12982         * solib-dsbt.c: Replace "the the" with "the".
12983         * linespec.c: Replace "the the" with "the".
12984         * dwarf2loc.h: Replace "the the" with "the".
12985         * amd64-windows-tdep.c: Replace "the the" with "the".
12986         * aarch64-tdep.c: Replace "the the" with "the".
12987
12988 2019-01-16  Keith Seitz  <keiths@redhat.com>
12989
12990         PR gdb/23773
12991         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12992         <builder>: Rename to ..
12993         <m_builder>: ... this and make private.
12994         (dwarf2_cu::get_builder): New method.  Change all users of
12995         `builder' to use this method.
12996         (dwarf2_start_symtab): Move to ...
12997         (dwarf2_cu::start_symtab): ... here.  Update all callers
12998         (setup_type_unit_groups): Move to ...
12999         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13000         callers.
13001         (dwarf2_cu::reset_builder): New method.
13002         (process_full_compunit, process_full_type_unit): Use
13003         dwarf2_cu::reset_builder.
13004         (follow_die_offset): Record the ancestor CU if it is different
13005         from the followed DIE's CU.
13006         (follow_die_sig_1): Likewise.
13007
13008 2019-01-15  Tom Tromey  <tom@tromey.com>
13009
13010         * remote.c (class remote_state) <buf>: Now a char_vector.
13011         <buf_size>: Remove.
13012         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13013         parameter.
13014         (remote_target::getpkt_or_notif_sane_1)
13015         (remote_target::getpkt_sane)
13016         (remote_target::getpkt_or_notif_sane): Likewise.
13017         (class remote_target) <putpkt>: New overload.
13018         (remote_target::read_frame): Change type of "buf_p".  Remove
13019         sizeof_p parameter.
13020         (packet_ok): New overload.
13021         (packet_check_result): New overload.
13022         Update all uses.
13023
13024 2019-01-14  Tom Tromey  <tom@tromey.com>
13025
13026         * remote-notif.c (handle_notification, remote_notif_ack)
13027         (remote_notif_parse): Make "buf" const.
13028         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13029         const.
13030         (remote_notif_parse, remote_notif_ack, handle_notification):
13031         Likewise.
13032         * remote.c (remote_notif_stop_parse): Make "buf" const.
13033         (remote_target::remote_parse_stop_reply): Make "buf" const.
13034         (remote_notif_stop_ack): Make "buf" const.
13035
13036 2019-01-14  Tom Tromey  <tom@tromey.com>
13037
13038         * remote.c (remote_console_output): Make parameter const.
13039
13040 2019-01-14  Tom Tromey  <tom@tromey.com>
13041
13042         * target-debug.h (target_debug_print_signals): Constify.
13043         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13044         * procfs.c (procfs_target::pass_signals): Update.
13045         * linux-nat.c (linux_nat_target::pass_signals): Update.
13046         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13047         * target-delegates.c: Rebuild.
13048         * remote.c (remote_target::program_signals): Update.
13049         (remote_target::pass_signals): Update.
13050         * target.c (target_pass_signals): Constify argument.
13051         (target_program_signals): Likewise.
13052         * target.h (struct target_ops) <pass_signals, program_signals>:
13053         Constify argument.
13054         (target_pass_signals, target_program_signals): Constify argument.
13055
13056 2019-01-14  Tom Tromey  <tom@tromey.com>
13057
13058         PR tui/28819:
13059         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13060
13061 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13062
13063         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13064         field.
13065         * rs6000-tdep.c: Include reggroups.h.
13066         (IS_V_ALIAS_PSEUDOREG): Define.
13067         (rs6000_register_name): Return names for the "vX" aliases.
13068         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13069         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13070         aliases.  Call default_register_reggroup_p for all other
13071         pseudo-registers.
13072         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13073         New functions.
13074         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13075         Handle "vX" aliases.
13076         (v_alias_pseudo_register_collect): New function.
13077         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13078         (rs6000_gdbarch_init): Initialize "vX" aliases as
13079         pseudo-registers.  Restore registration of
13080         rs6000_pseudo_register_reggroup_p with
13081         set_tdesc_pseudo_register_reggroup_p.
13082
13083 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13084
13085         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13086         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13087         set_gdbarch_num_pseudo_regs.
13088
13089 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13090
13091         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13092         Remove arg prefixname, add do_set and do_show.
13093         Add member functions set_list and show_list.
13094         * cli/cli-style.c (class cli_style_option): Update accordingly.
13095         (style_set_list): Move to file scope.
13096         (style_show_list): Likewise.
13097         (set_style): Call help_list.
13098         (show_style): Call cmd_show_list.
13099         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13100         Update to use the new macro.
13101
13102 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13103
13104         * ada-lang.c (_initialize_ada_language): Expand the help text
13105         for the "catch exception" command.
13106
13107 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13108
13109         * symtab.c (matching_obj_sections): Initialize obj,
13110         declare it closer to its usage.
13111
13112 2019-01-10  Tom Tromey  <tom@tromey.com>
13113
13114         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13115         (basic_inf_threads_range): Remove.
13116         (inf_threads_range, inf_non_exited_threads_range)
13117         (safe_inf_threads_range): Use next_adapter.
13118
13119 2019-01-10  Keith Seitz  <keiths@redhat.com>
13120
13121         PR gdb/23712
13122         PR symtab/23010
13123         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13124         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13125
13126 2019-01-10  Keith Seitz  <keiths@redhat.com>
13127
13128         PR gdb/23712
13129         PR symtab/23010
13130         * dictionary.c (pending_to_vector): Remove.
13131         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13132         Remove _1 suffix, replacing functions of the same name.  Update
13133         all callers.
13134         (dict_create_hashed, dict_create_hashed_expandable)
13135         (dict_create_linear, dict_create_linear_expandable, dict_free)
13136         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13137         Make functions static.
13138
13139 2019-01-10  Keith Seitz  <keiths@redhat.com>
13140
13141         PR gdb/23712
13142         PR symtab/23010
13143         * dictionary.h (struct dictionary): Replace declaration with
13144         multidictionary.
13145         (dict_create_hashed, dict_create_hashed_expandable)
13146         (dict_create_linear, dict_create_linear_expandable)
13147         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13148         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13149         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13150         taking multidictionary argument.
13151         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13152         * block.h (struct block) <dict>: Change to multidictionary
13153         and rename `multidict'.
13154         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13155         symmisc.c: Update all dictionary references to multidictionary.
13156
13157 2019-01-10  Keith Seitz  <keiths@redhat.com>
13158
13159         PR gdb/23712
13160         PR symtab/23010
13161         * dictionary.c: Include unordered_map.
13162         (pending_to_vector): New function.
13163         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13164         Rewrite the non-"_1" functions to take vector instead
13165         of linked list.
13166         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13167         "new" _1 versions of the same name.
13168         (multidictionary): Define.
13169         (std::hash<enum language): New definition.
13170         (collate_pending_symbols_by_language, mdict_create_hashed)
13171         (mdict_create_hashed_expandable, mdict_create_linear)
13172         (mdict_create_linear_expandable, mdict_free)
13173         (find_language_dictionary, create_new_language_dictionary)
13174         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13175         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13176         (mdict_size, mdict_empty): New functions.
13177         * dictionary.h (mdict_iterator): Define.
13178
13179 2019-01-10  Pedro Alves  <palves@redhat.com>
13180
13181         * breakpoint.c (read_uploaded_action)
13182         (create_tracepoint_from_upload): Adjust to use
13183         gdb::unique_xmalloc_ptr.
13184         * ctf.c (ctf_write_uploaded_tp):
13185         (SET_ARRAY_FIELD): Use emplace_back.
13186         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13187         * tracefile-tfile.c (tfile_write_uploaded_tp):
13188         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13189         gdb::unique_xmalloc_ptr.
13190         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13191         at_string, cond_string, cmd_strings>: Replace char pointers
13192         with gdb::unique_xmalloc_ptr.
13193
13194 2019-01-10  Pedro Alves  <palves@redhat.com>
13195
13196         * solib-target.c (library_list_start_library): Don't xstrdup name.
13197
13198 2019-01-10  Pedro Alves  <palves@redhat.com>
13199
13200         * mdebugread.c (parse_partial_symbols): Use
13201         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13202
13203 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13204
13205         * linux-fork.c (scoped_switch_fork_info)
13206         <~scoped_switch_fork_info>: Fix incorrect variable name.
13207
13208 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13209
13210         * linux-fork.c (scoped_switch_fork_info)
13211         <scoped_switch_fork_info>: Make explicit.
13212         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13213
13214 2019-01-10  Tom Tromey  <tom@tromey.com>
13215
13216         * objfiles.h (objfile::reset_psymtabs): Update.
13217         * objfiles.c (objfile::objfile): Update.
13218         * psymtab.h (psymtab_storage::obstack): Update.
13219         (psymtab_storage::m_obstack): Use gdb::optional.
13220         (class psymtab_storage): Update comment.  Remove objfile
13221         parameter.
13222         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13223
13224 2019-01-10  Tom Tromey  <tom@tromey.com>
13225
13226         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13227         <free_psymtabs>: Now private.
13228         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13229         (allocate_psymtab): Use new method.
13230
13231 2019-01-10  Tom Tromey  <tom@tromey.com>
13232
13233         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13234         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13235         * mdebugread.c (parse_partial_symbols): Use
13236         allocate_dependencies.
13237         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13238         allocate_dependencies.
13239         (process_psymtab_comp_unit_reader)
13240         (build_type_psymtab_dependencies): Likewise.
13241         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13242
13243 2019-01-10  Tom Tromey  <tom@tromey.com>
13244
13245         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13246         PSYMBOL_SET_LANGUAGE.
13247         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13248
13249 2019-01-10  Tom Tromey  <tom@tromey.com>
13250
13251         * psymtab.h (psymtab_storage::obstack): New method.
13252         <m_obstack>: Rename from obstack; now private.
13253         * psymtab.c (psymtab_storage): Update.
13254         * dwarf2read.c (create_addrmap_from_index)
13255         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13256         Update.
13257
13258 2019-01-10  Tom Tromey  <tom@tromey.com>
13259
13260         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13261         * objfiles.h (objfile::reset_psymtabs): New method.
13262
13263 2019-01-10  Tom Tromey  <tom@tromey.com>
13264
13265         * symmisc.c (print_symbol_bcache_statistics): Update.
13266         (print_objfile_statistics): Update.
13267         * symfile.c (reread_symbols): Update.
13268         * psymtab.h (class psymtab_storage): New.
13269         * psymtab.c (psymtab_storage): New constructor.
13270         (~psymtab_storage): New destructor.
13271         (require_partial_symbols): Update.
13272         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13273         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13274         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13275         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13276         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13277         (start_psymtab_common, end_psymtab_common)
13278         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13279         (allocate_psymtab): Update.
13280         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13281         Update.
13282         (dump_psymtab_addrmap, maintenance_print_psymbols)
13283         (maintenance_check_psymtabs): Update.
13284         (class objfile_psymtabs): Move to objfiles.h.
13285         * psympriv.h (discard_psymtab): Now inline.
13286         (psymtab_discarder::psymtab_discarder): Update.
13287         (psymtab_discarder::~psymtab_discarder): Update.
13288         (ALL_OBJFILE_PSYMTABS): Rewrite.
13289         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13290         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13291         Remove fields.
13292         <partial_symtabs>: New field.
13293         (class objfile_psymtabs): Move from psymtab.h.  Update.
13294         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13295         psymbol_cache.
13296         (objfile::~objfile): Don't destroy psymbol_cache.
13297         * mdebugread.c (parse_partial_symbols): Update.
13298         * dwarf2read.c (create_addrmap_from_index)
13299         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13300         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13301         (add_partial_subprogram, dwarf2_ranges_read): Update.
13302         * dwarf-index-write.c (write_address_map)
13303         (write_one_signatured_type, recursively_write_psymbols)
13304         (class debug_names, class debug_names, write_psymtabs_to_index):
13305         Update.
13306
13307 2019-01-10  Tom Tromey  <tom@tromey.com>
13308
13309         * symtab.h (SYMBOL_SET_NAMES): Update.
13310         (symbol_set_names): Update.
13311         (MSYMBOL_SET_NAMES): Update.
13312         * symtab.c (symbol_set_names): Change argument to be an
13313         objfile_per_bfd_storage.
13314         * psymtab.c (add_psymbol_to_bcache): Update.
13315         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13316
13317 2019-01-10  Tom Tromey  <tom@tromey.com>
13318
13319         * symtab.c (create_demangled_names_hash): Change argument to be an
13320         objfile_per_bfd_storage.
13321         (symbol_set_names): Update.
13322
13323 2019-01-10  Tom Tromey  <tom@tromey.com>
13324
13325         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13326         init_psymbol_list.
13327         * psymtab.c (init_psymbol_list): Do nothing if already called.
13328         * psympriv.h (init_psymbol_list): Add comment.
13329         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13330         init_psymbol_list.
13331         * dbxread.c (dbx_symfile_read): Unconditionally call
13332         init_psymbol_list.
13333
13334 2019-01-10  Tom Tromey  <tom@tromey.com>
13335
13336         * xcoffread.c (scan_xcoff_symtab): Update.
13337         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13338         "where".
13339         * mdebugread.c (parse_partial_symbols)
13340         (handle_psymbol_enumerators): Update.
13341         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13342         * dbxread.c (read_dbx_symtab): Update.
13343         * psympriv.h (psymbol_placement): New enum.
13344         (add_psymbol_to_list): Update.
13345
13346 2019-01-10  Tom Tromey  <tom@tromey.com>
13347
13348         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13349         static_psymbols parameters.
13350         (scan_xcoff_symtab): Update.
13351         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13352         static_psymbols parameters.
13353         * psympriv.h (start_psymtab_common): Update.
13354         * mdebugread.c (parse_partial_symbols): Update.
13355         * dwarf2read.c (create_partial_symtab): Update.
13356         * dbxread.c (read_dbx_symtab): Update.
13357         (start_psymtab): Remove global_psymbols and static_psymbols
13358         parameters.
13359
13360 2019-01-10  Tom Tromey  <tom@tromey.com>
13361
13362         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13363         * psymtab.c (allocate_psymtab): Add comment.
13364         * psympriv.h (allocate_psymtab): Add comment.
13365         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13366         initializations.
13367         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13368
13369 2019-01-10  Tom Tromey  <tom@tromey.com>
13370
13371         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13372         Don't declare.
13373         * mipsread.c: Include mdebugread.h.
13374         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13375         Declare.
13376         * elfread.c: Include mdebugread.h.
13377
13378 2019-01-09  Tom Tromey  <tom@tromey.com>
13379
13380         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13381         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13382         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13383         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13384         (psym_lookup_symbol, psym_find_last_source_symtab)
13385         (psym_forget_cached_source_info, psym_print_stats)
13386         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13387         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13388         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13389         (psym_find_compunit_symtab_by_address)
13390         (maintenance_print_psymbols, maintenance_info_psymtabs)
13391         (maintenance_check_psymtabs): Use ranged for.
13392         * psymtab.h (class objfile_psymtabs): New.
13393         (require_partial_symbols): Return objfile_psymtabs.
13394         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13395
13396 2019-01-09  Tom Tromey  <tom@tromey.com>
13397
13398         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13399         (find_pc_mapped_section, list_overlays_command)
13400         (map_overlay_command, unmap_overlay_command)
13401         (simple_overlay_update): Use all_objfiles.
13402         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13403         * printcmd.c (info_symbol_command): Use all_objfiles.
13404         * objfiles.h (ALL_OBJSECTIONS): Remove.
13405         * maint.c (maintenance_translate_address): Use all_objfiles.
13406         * gcore.c (gcore_create_callback): Use all_objfiles.
13407         (objfile_find_memory_regions): Likewise.
13408
13409 2019-01-09  Tom Tromey  <tom@tromey.com>
13410
13411         * symtab.c (find_line_symtab, info_sources_command)
13412         (make_source_files_completion_list): Use objfile_compunits.
13413         * source.c (select_source_symtab): Use objfile_compunits.
13414         * objfiles.h (struct objfile): Update comment.
13415         (ALL_OBJFILES): Remove.
13416         (ALL_FILETABS): Remove.
13417         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13418         objfile_compunits.
13419
13420 2019-01-09  Tom Tromey  <tom@tromey.com>
13421
13422         * symmisc.c (print_objfile_statistics, dump_objfile)
13423         (maintenance_print_symbols): Use compunit_filetabs.
13424         * source.c (forget_cached_source_info_for_objfile): Use
13425         compunit_filetabs.
13426         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13427         (ALL_FILETABS): Use compunit_filetabs.
13428         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13429         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13430
13431 2019-01-09  Tom Tromey  <tom@tromey.com>
13432
13433         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13434         (compunit_filetabs): New.
13435         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13436         compunit_filetabs.
13437         (info_sources_command, make_source_files_completion_list): Remove
13438         declaration.
13439         * symmisc.c (print_objfile_statistics, dump_objfile)
13440         (maintenance_print_symbols): Remove declaration.
13441         (maintenance_info_symtabs): Use compunit_filetabs.
13442         (maintenance_info_line_tables): Likewise.
13443         * source.c (select_source_symtab): Change local variable name.
13444         (forget_cached_source_info_for_objfile): Remove declaration.
13445         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13446         * objfiles.c (objfile_relocate1): Remove declaration.
13447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13448         declaration.
13449         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13450         * coffread.c (coff_symtab_read): Remove declaration.
13451         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13452         compunit_filetabs.
13453
13454 2019-01-09  Tom Tromey  <tom@tromey.com>
13455
13456         * symtab.c (lookup_objfile_from_block)
13457         (find_pc_sect_compunit_symtab, search_symbols)
13458         (default_collect_symbol_completion_matches_break_on): Use
13459         objfile_compunits.
13460         * objfiles.h (ALL_COMPUNITS): Remove.
13461         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13462         * cp-support.c (add_symbol_overload_list_qualified): Use
13463         objfile_compunits.
13464         * ada-lang.c (ada_collect_symbol_completion_matches)
13465         (ada_add_global_exceptions): Use objfile_compunits.
13466
13467 2019-01-09  Tom Tromey  <tom@tromey.com>
13468
13469         * source.c (select_source_symtab)
13470         (forget_cached_source_info_for_objfile): Remove declaration.
13471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13472         declaration.
13473         * maint.c (count_symtabs_and_blocks): Remove declaration.
13474         * cp-support.c (add_symbol_overload_list_qualified): Remove
13475         declaration.
13476         * coffread.c (coff_symtab_read): Remove declaration.
13477         * symtab.c (lookup_symbol_in_objfile_symtabs)
13478         (basic_lookup_transparent_type_1): Use objfile_compunits.
13479         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13480         (info_sources_command, search_symbols)
13481         (default_collect_symbol_completion_matches_break_on)
13482         (make_source_files_completion_list): Remove declaration.
13483         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13484         (ada_collect_symbol_completion_matches)
13485         (ada_add_global_exceptions): Remove declaration.
13486         * linespec.c (iterate_over_all_matching_symtabs): Use
13487         objfile_compunits.
13488         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13489         (class objfile_compunits): New.
13490         (ALL_COMPUNITS): Use objfile_compunits.
13491         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13492         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13493         objfile_compunits.
13494         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13495
13496 2019-01-09  Tom Tromey  <tom@tromey.com>
13497
13498         * symtab.c (search_symbols)
13499         (default_collect_symbol_completion_matches_break_on): Use
13500         objfile_msymbols.
13501         * ada-lang.c (ada_lookup_simple_minsym)
13502         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13503         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13504         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13505         objfile_msymbols.
13506         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13507         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13508         * objc-lang.c (find_methods): Use objfile_msymbols.
13509         (info_selectors_command, info_classes_command): Likewise.
13510         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13511         * objfiles.h (class objfile_msymbols): New.
13512         (ALL_OBJFILE_MSYMBOLS): Remove.
13513         (ALL_MSYMBOLS): Remove.
13514
13515 2019-01-09  Tom Tromey  <tom@tromey.com>
13516
13517         * common/next-iterator.h (next_adapter): Add Iterator template
13518         parameter.
13519         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13520         (class all_objfiles_safe): New.
13521         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13522         * objfiles.c (put_objfile_before): Update comment.
13523         (add_separate_debug_objfile): Likewise.
13524         (free_all_objfiles): Use all_objfiles_safe.
13525         (objfile_purge_solibs): Likewise.
13526
13527 2019-01-09  Tom Tromey  <tom@tromey.com>
13528
13529         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13530         (expand_symtab_containing_pc, lookup_static_symbol)
13531         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13532         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13533         all_objfiles.
13534         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13535         * breakpoint.c (create_overlay_event_breakpoint)
13536         (create_longjmp_master_breakpoint)
13537         (create_std_terminate_master_breakpoint)
13538         (create_exception_master_breakpoint): Use all_objfiles.
13539         * linux-thread-db.c (try_thread_db_load_from_pdir)
13540         (has_libpthread): Use all_objfiles.
13541         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13542         * linespec.c (iterate_over_all_matching_symtabs)
13543         (search_minsyms_for_name): Use all_objfiles.
13544         * maint.c (maintenance_info_sections): Use all_objfiles.
13545         * main.c (captured_main_1): Use all_objfiles.
13546         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13547         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13548         * guile/scm-pretty-print.c
13549         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13550         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13551         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13552         (maintenance_print_msymbols): Use all_objfiles.
13553         * source.c (select_source_symtab): Use all_objfiles.
13554         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13555         * symfile.c (remove_symbol_file_command)
13556         (expand_symtabs_matching, map_symbol_filenames): Use
13557         all_objfiles.
13558         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13559         all_objfiles.
13560         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13561         * objc-lang.c (find_methods): Use all_objfiles.
13562         * objfiles.c (have_partial_symbols, have_full_symbols)
13563         (have_minimal_symbols, qsort_cmp)
13564         (default_iterate_over_objfiles_in_search_order): Use
13565         all_objfiles.
13566         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13567         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13568         (maintenance_check_psymtabs): Use all_objfiles.
13569         (ALL_PSYMTABS): Remove.
13570         * compile/compile-object-run.c (do_module_cleanup): Use
13571         all_objfiles.
13572         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13573         * cp-support.c (add_symbol_overload_list_qualified): Use
13574         all_objfiles.
13575         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13576         Use all_objfiles.
13577         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13578         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13579         all_objfiles.
13580         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13581         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13582         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13583         Uses all_objfiles.
13584         * solib.c (solib_read_symbols): Use all_objfiles
13585
13586 2019-01-09  Tom Tromey  <tom@tromey.com>
13587
13588         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13589         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13590         all_objfiles.
13591         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13592         * symmisc.c (print_symbol_bcache_statistics)
13593         (print_objfile_statistics, maintenance_print_objfiles)
13594         (maintenance_info_symtabs, maintenance_check_symtabs)
13595         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13596         all_objfiles.
13597         * source.c (forget_cached_source_info): Use all_objfiles.
13598         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13599         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13600         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13601         * objfiles.c (update_section_map): Use all_objfiles.
13602         (shared_objfile_contains_address_p): Likewise.
13603         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13604         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13605
13606 2019-01-09  Tom Tromey  <tom@tromey.com>
13607
13608         * common/next-iterator.h: New file.
13609         * objfiles.h (class all_objfiles): New.
13610         (struct objfile_iterator): New.
13611
13612 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13613
13614         * NEWS: Move the description of the changed "frame", "select-frame",
13615          and "info frame" commands to the Changed commands section.
13616
13617 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13618
13619         * gdbtypes.c (check_stub_method_group): Remove handling of old
13620         mangling schemes.
13621         * linespec.c (find_methods): Likewise.
13622         * stabsread.c (read_member_functions): Likewise.
13623         * valops.c (search_struct_method): Likewise.
13624         (value_struct_elt_for_reference): Likewise.
13625         * NEWS: Mention this change.
13626
13627 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13628
13629         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13630         print_source_lines.
13631         * source.c (print_source_lines_base): Update line number check.
13632         (print_source_lines): New function.
13633         (source_lines_range::source_lines_range): New function.
13634         * source.h (class source_lines_range): New class.
13635         (print_source_lines): New declaration.
13636
13637 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13638
13639         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13640
13641 2019-01-08  Tom Tromey  <tom@tromey.com>
13642             Simon Marchi  <simon.marchi@ericsson.com>
13643
13644         PR gdb/24060
13645         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13646         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13647         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13648         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13649         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13650         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13651
13652 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13653
13654         * source.c (select_source_symtab): Move header comment to
13655         declaration in source.h.
13656         (forget_cached_source_info_for_objfile): Likewise.
13657         (forget_cached_source_info): Likewise.
13658         (identify_source_line): Likewise.
13659         * source.h (identify_source_line): Move declaration from symtab.h
13660         and add comment from source.c
13661         (print_source_lines): Likewise.
13662         (forget_cached_source_info_for_objfile): Likewise.
13663         (forget_cached_source_info): Likewise.
13664         (select_source_symtab): Likewise.
13665         (enum print_source_lines_flag): Move definition from symtab.h.
13666         * symtab.h (identify_source_line): Move declaration to source.h.
13667         (print_source_lines): Likewise.
13668         (forget_cached_source_info_for_objfile): Likewise.
13669         (forget_cached_source_info): Likewise.
13670         (select_source_symtab): Likewise.
13671         (enum print_source_lines_flag): Move definition to source.h.
13672         * tui/tui-hooks.c: Add 'source.h' include.
13673
13674 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13675
13676         * source.c (print_source_lines_base): Handle requests to print
13677         reverse line number sequences, and guard against empty lines
13678         string.
13679
13680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13681
13682         * source.c (print_source_lines_base): Fix skip of '\r' if next
13683         character is '\n'.
13684
13685 2019-01-06  Tom Tromey  <tom@tromey.com>
13686
13687         * c-exp.y (struct c_parse_state) <macro_original_text,
13688         expansion_obstack>: New member.
13689         (macro_original_text, expansion_obstack): Remove globals.
13690         (scan_macro_expansion, scanning_macro_expansion)
13691         (finished_macro_expansion): Update.
13692         (scan_macro_cleanup): Remove.
13693         (yylex, c_parse): Update.
13694
13695 2019-01-06  Tom Tromey  <tom@tromey.com>
13696
13697         * c-exp.y (struct c_parse_state) <strings>: New member.
13698         (operator_stoken): Update.
13699
13700 2019-01-06  Tom Tromey  <tom@tromey.com>
13701
13702         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13703         (union type_stack_elt) <typelist_val>: Now a pointer to
13704         std::vector.
13705         (type_stack_cleanup): Don't declare.
13706         (push_typelist): Update.
13707         * parse.c (pop_typelist): Return a std::vector.
13708         (push_typelist): Take a std::vector.
13709         (follow_types): Update.  Do not free args.
13710         (type_stack_cleanup): Remove.
13711         * c-exp.y (struct c_parse_state): New.
13712         (cpstate): New global.
13713         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13714         (nonempty_typelist): Update.
13715         (func_mod): Create a new vector.
13716         (c_parse): Create a c_parse_state.
13717         (check_parameter_typelist): Do not delete params.
13718         (function_method): Update.  Do not delete type_list.
13719
13720 2019-01-06  Tom Tromey  <tom@tromey.com>
13721
13722         PR gdb/28155:
13723         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13724         check_typedef.
13725         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13726         (print_return_value): Likewise.
13727
13728 2019-01-05  Tom Tromey  <tom@tromey.com>
13729
13730         * contrib/cleanup_check.py: Remove.
13731         * contrib/gcc-with-excheck: Remove.
13732         * contrib/exsummary.py: Remove.
13733         * contrib/excheck.py: Remove.
13734
13735 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13736
13737         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13738         NULL. Initialize tpprev to NULL instead of assigning it
13739         to NULL on the next statement.
13740         * windows-nat.c (windows_delete_thread): Remove check for
13741         main_thread_id before printing thread exit notifications.
13742         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13743         Remove thread ID check against main_thread_id.
13744         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13745         windows_delete_thread.
13746         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13747
13748 2019-01-04  Tom Tromey  <tom@tromey.com>
13749
13750         * compile/compile.c (_initialize_compile): Use upper case for
13751         metasyntactic variables.
13752         * symmisc.c (_initialize_symmisc): Use upper case for
13753         metasyntactic variables.
13754         * psymtab.c (_initialize_psymtab): Use upper case for
13755         metasyntactic variables.
13756         * demangle.c (demangle_command): Use upper case for metasyntactic
13757         variables.
13758         (_initialize_demangler): Likewise.
13759         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13760         variables.
13761
13762 2019-01-03  Tom Tromey  <tom@tromey.com>
13763
13764         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13765
13766 2019-01-03  Tom Tromey  <tom@tromey.com>
13767
13768         * python/py-symtab.c (salpy_str): Update.
13769         (struct salpy_sal_object) <symtab>: Now a PyObject.
13770         (salpy_dealloc): Update.
13771         (del_objfile_sal): Use gdbpy_ref.
13772
13773 2019-01-03  Tom Tromey  <tom@tromey.com>
13774
13775         * python/py-type.c (convert_field): Use new_reference.  Return
13776         gdbpy_ref.
13777         (make_fielditem): Return gdbpy_ref.
13778         (typy_fields): Update.
13779         (typy_getitem): Update.
13780         (field_name): Return gdbpy_ref.  Use new_reference.
13781         (typy_iterator_iternext): Update.
13782
13783 2019-01-03  Tom Tromey  <tom@tromey.com>
13784
13785         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13786
13787 2019-01-03  Tom Tromey  <tom@tromey.com>
13788
13789         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13790         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13791         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13792         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13793         (pspy_set_type_printers): Likewise.
13794         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13795         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13796         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13797         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13798         (objfpy_set_type_printers): Likewise.
13799
13800 2019-01-03  Tom Tromey  <tom@tromey.com>
13801
13802         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13803         (gdbpy_print_stack): Use gdbpy_err_fetch.
13804         * python/python-internal.h (class gdbpy_err_fetch): New class.
13805         (class gdbpy_enter) <m_error_type, m_error_value,
13806         m_error_traceback>: Remove.
13807         <m_error>: New member.
13808         (gdbpy_exception_to_string): Don't declare.
13809         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13810         * python/py-value.c (convert_value_from_python): Use
13811         gdbpy_err_fetch.
13812         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13813         gdbpy_exception_to_string.
13814         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13815         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13816         gdbpy_err_fetch.
13817
13818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13819
13820         * linux-nat.c (delete_lwp_cleanup): Delete.
13821         (struct lwp_deleter): New struct.
13822         (lwp_info_up): New typedef.
13823         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13824         lwp_info_up.
13825
13826 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13827
13828         * linux-fork.c (class scoped_switch_fork_info): New class.
13829         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13830
13831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13832
13833         * valops.c (find_overload_match): Remove use of null_cleanup, and
13834         calls to do_cleanups.
13835
13836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13837
13838         * compile/compile-cplus-types.c
13839         (compile_cplus_instance::decl_name): Handle changes to
13840         cp_func_name.
13841         * cp-support.c (cp_func_name): Update header comment, update
13842         return type.
13843         * cp-support.h (cp_func_name): Update return type in declaration.
13844         * valops.c (find_overload_match): Move temp_func local to top
13845         level of function and change its type.  Use temp_func to hold and
13846         delete temporary string obtained from cp_func_name.
13847
13848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13849
13850         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13851         gdb::char_vector, remove cleanup, and update uses of `msg`.
13852
13853 2019-01-03  Jim Wilson  <jimw@sifive.com>
13854
13855         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13856
13857 2019-01-02  Tom Tromey  <tom@tromey.com>
13858
13859         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13860         (tdesc_parse_xml): Remove cleanups.
13861         * target-descriptions.h (make_cleanup_free_target_description):
13862         Don't declare.
13863         (target_desc_deleter): New struct.
13864         (target_desc_up): New typedef.
13865         * target-descriptions.c (target_desc_deleter::operator()): Rename
13866         from free_target_description.
13867         (make_cleanup_free_target_description): Remove.
13868
13869 2019-01-02  Tom Tromey  <tom@tromey.com>
13870
13871         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13872         constructor, destructor.
13873         (linespec_parser): Remove typedef.
13874         (~linespec_parser): Rename from linespec_parser_delete.
13875         (linespec_lex_to_end, linespec_complete_label)
13876         (linespec_complete): Update.
13877         (decode_line_full): Remove cleanups.
13878         (decode_line_1): Update.
13879
13880 2019-01-02  Tom Tromey  <tom@tromey.com>
13881
13882         * python/python-internal.h (inferior_to_inferior_object): Change
13883         return type.
13884         * python/py-exitedevent.c (create_exited_event_object): Update.
13885         * python/py-inferior.c (inferior_to_inferior_object): Return
13886         gdbpy_ref.
13887         (python_new_inferior, python_inferior_deleted)
13888         (thread_to_thread_object, delete_thread_object)
13889         (build_inferior_list, gdbpy_selected_inferior): Update.
13890         * python/py-infthread.c (create_thread_object): Update.  Also fail
13891         if inferior_to_inferior_object fails.
13892
13893 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13894
13895         * inferior.h (class inferior) <displaced_step_state>: New field.
13896         * infrun.h (struct displaced_step_state): Move here from
13897         infrun.c.  Initialize fields, add constructor.
13898         <inf>: Remove field.
13899         <reset>: New method.
13900         * infrun.c (struct displaced_step_inferior_state): Move to
13901         infrun.h.
13902         (displaced_step_inferior_states): Remove.
13903         (get_displaced_stepping_state): Adust.
13904         (displaced_step_in_progress_any_inferior): Adjust.
13905         (displaced_step_in_progress_thread): Adjust.
13906         (displaced_step_in_progress): Adjust.
13907         (add_displaced_stepping_state): Remove.
13908         (get_displaced_step_closure_by_addr): Adjust.
13909         (remove_displaced_stepping_state): Remove.
13910         (infrun_inferior_exit): Call displaced_step_state.reset.
13911         (use_displaced_stepping): Don't check for NULL.
13912         (displaced_step_prepare_throw): Call
13913         get_displaced_stepping_state.
13914         (displaced_step_fixup): Don't check for NULL.
13915         (prepare_for_detach): Don't check for NULL.
13916
13917 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13918
13919         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13920          in case of call that did not complete.
13921
13922 2019-01-02  Andrey Utkin  <autkin@undo.io>
13923
13924         * symfile.c (find_separate_debug_file): Fix search of debug files for
13925         remote debuggee.
13926
13927 2019-01-02  Tom Tromey  <tom@tromey.com>
13928
13929         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13930         indentation.
13931         * python/py-frame.c (frapy_older): Remove cast.
13932         (frapy_newer): Likewise.
13933         * python/py-breakpoint.c (local_setattro): Remove cast.
13934         * python/py-arch.c (archpy_name): Remove local variable.
13935         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13936
13937 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13938
13939         * unittests/basic_string_view/element_access/char/empty.cc:
13940         Fix year range in copyright header.
13941
13942 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13943
13944         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13945         Delete.
13946         <operator==>: Update with for removed field.
13947         <hash>: Likewise.
13948         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13949         <isa_features>: ...this.
13950         <abi_features>: New field.
13951         (riscv_isa_flen): Update comment.
13952         (riscv_abi_xlen): New declaration.
13953         (riscv_abi_flen): New declaration.
13954         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13955         isa_features.
13956         (riscv_abi_xlen): New function.
13957         (riscv_isa_flen): Update to get answer from isa_features.
13958         (riscv_abi_flen): New function.
13959         (riscv_has_fp_abi): Update to get answer from abi_features.
13960         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13961         xlen and flen.
13962         (riscv_call_info) <xlen, flen>: Update comment.
13963         (riscv_call_arg_struct): Remove invalid assertions
13964         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13965         is removed.
13966         (riscv_gdbarch_init): Gather isa features and abi features
13967         separately, ensure both match on the gdbarch when reusing an old
13968         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13969         a target with 64-bit float hardware.
13970
13971 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13972
13973         * source.c (search_command_helper): Stop reverse search
13974         when line 1 has been searched.
13975
13976 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13977
13978         * record-full.c (record_full_base_target::close): Rewrite
13979         record_full_core_buf_list free logic.
13980
13981 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13982
13983         * break-catch-syscall.c (print_one_catch_syscall): xfree
13984         the last text.
13985
13986 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13987
13988         * top.c (print_gdb_version): Update Copyright year in version
13989         message.
13990
13991 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13992
13993         Update copyright year range in all GDB files.
13994
13995 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13996
13997         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13998
13999 For older changes see ChangeLog-2018.
14000 \f
14001 Local Variables:
14002 mode: change-log
14003 left-margin: 8
14004 fill-column: 74
14005 version-control: never
14006 coding: utf-8
14007 End:
14008