gdb/ChangeLog

   1 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
   4         hash and why.
   5         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
   6         msymbol_hash, msymbol_demangled_hash>: Improve comments.
   7
   8 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
   9
  10         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
  11         * psympriv.h (add_psymbol_to_list): Move comment here and update
  12         it.
  13
  14 2019-09-29  Tom de Vries  <tdevries@suse.de>
  15
  16         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
  17         Use $tmpdir/$(basename "$output_file").dwz instead of
  18         "${output_file}.dwz".
  19
  20 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
  21
  22         PR gdb/25045
  23         * hppa-linux-nat.c: Include gdbarch.h.
  24
  25 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
  26
  27         * blockframe.c (find_pc_partial_function): Change return type to bool.
  28         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
  29         * minsyms.c (in_gnu_ifunc_stub): Likewise.
  30         (stub_gnu_ifunc_resolve_name): Likewise.
  31         * symtab.c (compare_filenames_for_search): Likewise.
  32         (compare_glob_filenames_for_search): Likewise.
  33         (matching_obj_sections): Likewise.
  34         (symbol_matches_domain): Likewise.
  35         (find_line_symtab): Change out param EXACT_MATCH to bool *.
  36         (find_line_pc): Change return type to bool.
  37         (find_line_pc_range): Likewise.
  38         (producer_is_realview): Likewise.
  39         * symtab.h (symbol_matches_domain): Likewise.
  40         (find_pc_partial_function): Likewise.
  41         (find_pc_line_pc_range): Likewise.
  42         (in_gnu_ifunc_stub): Likewise.
  43         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
  44         (find_line_pc): Likewise.
  45         (find_line_pc_range): Likewise.
  46         (matching_obj_sections): Likewise.
  47         (find_line_symtab): Change out parameter to bool.
  48         (producer_is_realview): Change return type to bool.
  49         (compare_filenames_for_search): Likewise.
  50         (compare_glob_filenames_for_search): Likewise.
  51
  52 2019-09-26  Tom Tromey  <tom@tromey.com>
  53
  54         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
  55         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
  56         * gdb_usleep.h: Remove.
  57         * gdb_usleep.c: Remove.
  58         * utils.c: Don't include gdb_usleep.h.
  59
  60 2019-09-26  Tom Tromey  <tromey@adacore.com>
  61
  62         * python/py-type.c (type_to_type_object): Call check_typedef
  63         for stub types.
  64
  65 2019-09-26  Tom Tromey  <tom@tromey.com>
  66
  67         * utils.h (initialize_utils): Don't declare.
  68         * top.c (gdb_init): Don't call initialize_utils.
  69         * utils.c (initialize_utils): Remove.  Move contents...
  70         (_initialize_utils): ... here.
  71
  72 2019-09-25  Tom Tromey  <tom@tromey.com>
  73
  74         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
  75         * utils.h (make_hex_string): Don't declare.
  76         * utils.c (make_hex_string): Remove.
  77
  78 2019-09-24  Tom de Vries  <tdevries@suse.de>
  79
  80         PR gdb/23815
  81         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
  82         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
  83
  84 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
  85
  86         * NEWS: Mention new simulator port for PRU.
  87
  88 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
  89
  90         * ada-exp.y (write_object_remaining): Update.
  91         * ada-lang.c (ada_decode): Return a std::string instead of a char*
  92         and eliminate the static buffer.
  93         (ada_decode_symbol): Update.
  94         (ada_la_decode): Update.
  95         (ada_sniff_from_mangled_name): Update.
  96         (is_valid_name_for_wild_match): Update.
  97         (ada_lookup_name_info::matches): Update and simplify.
  98         (name_matches_regex): Update.
  99         (ada_add_global_exceptions): Update.
 100         * ada-lang.h (ada_decode): Update signature.
 101         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 102         * dwarf-index-write.c (debug_names::insert): Update.
 103
 104 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 105
 106         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 107         formatting.
 108
 109 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 110
 111         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 112         Change "nonzero" to "true" in documentation.
 113
 114 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 115
 116         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 117         (_initialize_darwin_solib): Don't set
 118         darwin_so_ops.lookup_lib_global_symbol.
 119         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 120         set_gdbarch_iterate_over_objfiles_in_search_order.
 121         (elf_lookup_lib_symbol): Rename to...
 122         (svr4_iterate_over_objfiles_in_search_order): this, and update
 123         to iterate semantics.
 124         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 125         * solib.c (solib_global_lookup): Remove.
 126         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 127         (solib_global_lookup): Remove.
 128         * symtab.c (lookup_global_or_static_symbol): Remove call to
 129         solib_global_lookup.
 130
 131 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 132
 133         * NEWS: Move entries about default MI version now being
 134         version 3, and about the GDB/MI fix for multi-location
 135         breakpoints to the "since GDB 8.3" section.
 136
 137 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 138
 139         GDB 8.3.1 released.
 140
 141 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 142
 143         * NEWS: Mention that Cell/B.E. debugging support was removed.
 144         * MAINTAINERS: Remove spu target.
 145
 146         * config/djgpp/fnchange.lst: Remove entries for removed files.
 147
 148         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 149         spu-multiarch.o, and spu-tdep.o.
 150         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 151         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 152         spu-multiarch.c, and spu-tdep.c.
 153         * spu-linux-nat.c: Remove file.
 154         * spu-multiarch.c: Remove file.
 155         * spu-tdep.c: Remove file.
 156         * spu-tdep.h: Remove file.
 157         * solib-spu.c: Remove file.
 158         * solib-spu.h: Remove file.
 159
 160         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 161         * configure.nat (spu-linux): Remove.
 162         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 163         solib-multiarch.o from gdb_target_obs.
 164         (spu*-*-*): Remove.
 165
 166         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 167         feature flag.
 168         (ppc_linux_no_features): Update.
 169         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 170         Cell/B.E. support.
 171         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 172         (tdesc_powerpc_cell64l): Likewise.
 173         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 174         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 175         Cell/B.E. support.
 176         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 177         Do not include "features/rs6000/powerpc-cell32l.c" or
 178         "features/rs6000/powerpc-cell64l.c".
 179         (ppc_linux_spu_section): Remove.
 180         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 181         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 182         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 183         (ppc_linux_spe_context_lookup): Remove.
 184         (ppc_linux_spe_context_inferior_created): Remove.
 185         (ppc_linux_spe_context_solib_loaded): Remove.
 186         (ppc_linux_spe_context_solib_unloaded): Remove.
 187         (ppc_linux_spe_context): Remove.
 188         (struct ppu2spu_cache): Remove.
 189         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 190         (struct ppu2spu_data): Remove.
 191         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 192         ppu2spu_unwind): Remove.
 193         (ppc_linux_init_abi): Remove Cell/B.E. support.
 194         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 195
 196         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 197         (rs6000/powerpc-cell64l-expedite): Likewise
 198         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 199         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 200         rs6000/powerpc-cell64l.xml.
 201         * features/rs6000/powerpc-cell32l.xml: Remove.
 202         * features/rs6000/powerpc-cell64l.xml: Likewise.
 203         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 204         * features/rs6000/powerpc-cell64l.c: Likewise.
 205         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 206         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 207         * regformats/reg-spu.dat: Remove.
 208
 209         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 210         * corelow.c (struct spuid_list): Remove.
 211         (add_to_spuid_list): Remove.
 212         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 213         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 214         (remote_protocol_features): Remove associated entries.
 215         (_initialize_remote): No longer initialize them.
 216         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 217         * linux-nat.c (SPUFS_MAGIC): Remove.
 218         (linux_proc_xfer_spu): Remove.
 219         (spu_enumerate_spu_ids): Remove.
 220         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 221         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 222         (linux_make_corefile_notes): No longer call it.
 223
 224         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 225         (cooked_write_test): Likewise.
 226
 227 2019-09-20  Tom Tromey  <tom@tromey.com>
 228
 229         * NEWS: Mention case-sensitivity of TUI commands.
 230         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 231         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 232         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 233
 234 2019-09-20  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-source.c (tui_source_window::set_contents): Use
 237         make_unique_xstrdup.
 238         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 239         make_unique_xstrdup.
 240
 241 2019-09-20  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-data.c: Remove separator comments.
 244         * tui/tui-layout.c: Remove separator comments.
 245         * tui/tui-win.c: Remove separator comments.
 246         * tui/tui-wingeneral.c: Remove separator comments.
 247
 248 2019-09-20  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui.h (strcat_to_buf): Don't declare.
 251         * tui/tui.c (strcat_to_buf): Remove.
 252
 253 2019-09-20  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 256         from "fullname".
 257         * tui/tui-source.c (tui_source_window::set_contents)
 258         (tui_source_window::location_matches_p)
 259         (tui_source_window::maybe_update): Update.
 260
 261 2019-09-20  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 264         Update.
 265         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 266         prefix.
 267         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 268         (tui_data_window::line_from_reg_element_no)
 269         (tui_data_window::first_reg_element_no_inline)
 270         (tui_data_window::show_registers)
 271         (tui_data_window::show_register_group)
 272         (tui_data_window::display_registers_from)
 273         (tui_data_window::display_registers_from_line)
 274         (tui_data_window::first_data_item_displayed)
 275         (tui_data_window::delete_data_content_windows)
 276         (tui_data_window::erase_data_content)
 277         (tui_data_window::do_scroll_vertical)
 278         (tui_data_window::refresh_window)
 279         (tui_data_window::check_register_values): Update.
 280
 281 2019-09-20  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 284         (struct tui_locator_window) <full_name, proc_name>: Now
 285         std::string.
 286         * tui/tui-stack.c (tui_locator_window::make_status_line)
 287         (tui_locator_window::set_locator_fullname)
 288         (tui_locator_window::set_locator_info): Update.
 289         * tui/tui-source.c (tui_source_window::set_contents)
 290         (tui_source_window::showing_source_p): Update.
 291
 292 2019-09-20  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 295         Don't call tui_locator_win_info_ptr.
 296
 297 2019-09-20  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 300
 301 2019-09-20  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 304         height for locator.
 305         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 306         * tui/tui-layout.c (show_source_disasm_command, show_data)
 307         (show_source_or_disasm_and_command): Use 1 as height for locator.
 308
 309 2019-09-20  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui.c (tui_enable): Update.
 312         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 313         Update.
 314         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 315         Update.
 316         * tui/tui-data.c (win_resized): Now bool.
 317         (tui_win_resized): Return bool.
 318         (tui_set_win_resized_to): Accept a bool.
 319
 320 2019-09-20  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 323         Change type of "refresh_values_only".
 324         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 325         type of "refresh_values_only".
 326
 327 2019-09-20  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 330         std::string.
 331         (tui_disassemble): Add "pos" parameter.
 332         (tui_disasm_window::set_contents): Simplify.
 333
 334 2019-09-20  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-winsource.h (struct tui_source_window_base)
 337         <show_source_content>: Now private.
 338         * tui/tui-winsource.c
 339         (tui_source_window_base::show_source_content): Don't handle empty
 340         content case.
 341
 342 2019-09-20  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-layout.c (show_source_disasm_command)
 345         (show_source_or_disasm_and_command): Don't call
 346         show_source_content.
 347
 348 2019-09-20  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 351         Declare.
 352         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 353         from tui_make_status_line.
 354         (tui_locator_window::rerender): Update.
 355
 356 2019-09-20  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 359         (tui_locator_window::rerender): Update.
 360
 361 2019-09-20  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-winsource.h (struct tui_source_window_base)
 364         <~tui_source_window_base>: Don't declare.
 365         <fullname>: Remove.
 366         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 367         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 368         member.
 369         * tui/tui-source.c (tui_source_window::set_contents): Update.
 370         (tui_source_window::location_matches_p)
 371         (tui_source_window::maybe_update): Update.
 372
 373 2019-09-20  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-winsource.h (~tui_source_element): Remove.
 376         (tui_source_element): Update.
 377         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 378         * tui/tui-winsource.c (tui_show_source_line): Update.
 379         * tui/tui-source.c (tui_source_window::set_contents): Update.
 380         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 381
 382 2019-09-20  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 385         declare.
 386         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 387         tui_clear_source_windows_detail.
 388         * tui/tui-winsource.h (struct tui_source_window_base)
 389         <clear_detail>: Don't declare.
 390         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 391         Remove.
 392         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 393
 394 2019-09-20  Tom Tromey  <tromey@adacore.com>
 395
 396         PR ada/24919:
 397         * block.c (contained_in): Fix final return value.
 398
 399 2019-09-20  Alan Modra  <amodra@gmail.com>
 400
 401         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 402         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 403         (read_indirect_string_from_dwz): Use bfd accessor.
 404         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 405         * machoread.c (macho_symfile_read_all_oso): Likewise.
 406         * solib.c (solib_bfd_open): Likewise.
 407
 408 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 409
 410         * eval.c: Move declaration of overload_resolution to...
 411         * value.h: ...here.
 412
 413 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 414
 415         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 416         * arm-linux-tdep.c: Likewise.
 417         * arm-nbsd-nat.c: Likewise.
 418         * arm-tdep.h: Declare arm_apcs_32.
 419         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 420
 421 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 422
 423         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 424         * dwarf2read.h: Declare dwarf_always_disassemble.
 425
 426 2019-09-19  Tom de Vries  <tdevries@suse.de>
 427
 428         PR gdb/25009
 429         * source-cache.c (source_cache::ensure): Catch exception thrown during
 430         construction of the highlighter.
 431
 432 2019-09-18  Alan Modra  <amodra@gmail.com>
 433
 434         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 435         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 436         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 437         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 438         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 439         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 440         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 441         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 442         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 443         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 444         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 445         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 446         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 447         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 448         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 449         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 450         * mi/mi-interp.c: Update throughout for bfd section macro and
 451         function changes.
 452         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 453         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 454
 455 2019-09-18  Tom Tromey  <tom@tromey.com>
 456
 457         * NEWS: Add entry.
 458         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 459         call rl_initialize.
 460         (tui_enable): Do not call rl_initialize.
 461
 462 2019-09-18  Christian Groessler  <chris@groessler.org>
 463
 464         * alpha-linux-nat.c: Include gdbarch.h.
 465
 466 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 467
 468         * ui-file.c: Include cli/cli-style.h.
 469         (term_cli_styling): Remove cli_styling declaration.
 470
 471 2019-09-18  Alan Modra  <amodra@gmail.com>
 472
 473         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 474         to bfd_asymbol_section.
 475
 476 2019-09-18  Alan Modra  <amodra@gmail.com>
 477
 478         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 479         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 480         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 481
 482 2019-09-18  Alan Modra  <amodra@gmail.com>
 483
 484         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 485         * spu-linux-nat.c (spu_bfd_open): Likewise.
 486
 487 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 488
 489         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 490         to bool to match definition in dwarf2read.c.
 491
 492 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 493
 494         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 495         (print_signatures): Likewise.
 496         (trust_pad_over_xvs): Likewise.
 497         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 498         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 499         * arm-linux-nat.c (arm_apcs_32): Likewise.
 500         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 501         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 502         * arm-tdep.c (arm_debug): Likewise.
 503         (arm_apcs_32): Likewise.
 504         * auto-load.c (debug_auto_load): Likewise.
 505         (auto_load_gdb_scripts): Likewise.
 506         (global_auto_load): Likewise.
 507         (auto_load_local_gdbinit): Likewise.
 508         (auto_load_local_gdbinit_loaded): Likewise.
 509         * auto-load.h (global_auto_load): Likewise.
 510         (auto_load_local_gdbinit): Likewise.
 511         (auto_load_local_gdbinit_loaded): Likewise.
 512         * breakpoint.c (disconnected_dprintf): Likewise.
 513         (breakpoint_proceeded): Likewise.
 514         (automatic_hardware_breakpoints): Likewise.
 515         (always_inserted_mode): Likewise.
 516         (target_exact_watchpoints): Likewise.
 517         (_initialize_breakpoint): Update.
 518         * breakpoint.h (target_exact_watchpoints): Change to bool.
 519         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 520         * cli/cli-cmds.c (trace_commands): Likewise.
 521         * cli/cli-cmds.h (trace_commands): Likewise.
 522         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 523         to bool*.
 524         * cli/cli-logging.c (logging_overwrite): Change to bool.
 525         (logging_redirect): Likewise.
 526         (debug_redirect): Likewise.
 527         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 528         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 529         to bool.
 530         <boolean_option_def>: Update.
 531         (struct flag_option_def): Change default type of Context to bool
 532         from int.
 533         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 534         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 535         (get_setshow_command_value_string): Likewise.
 536         * cli/cli-style.c (cli_styling): Change to bool.
 537         (source_styling): Likewise.
 538         * cli/cli-style.h (source_styling): Likewise.
 539         (cli_styling): Likewise.
 540         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 541         to bool.
 542         * command.h (var_types): Update comment.
 543         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 544         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 545         bool.
 546         (debug_compile_cplus_scopes): Likewise.
 547         * compile/compile-internal.h (compile_debug): Likewise.
 548         * compile/compile.c (compile_debug): Likewise.
 549         (struct compile_options) <raw>: Likewise.
 550         * cp-support.c (catch_demangler_crashes): Likewise.
 551         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 552         (usr_cmd_cris_dwarf2_cfi): Likewise.
 553         * csky-tdep.c (csky_debug): Likewise.
 554         * darwin-nat.c (enable_mach_exceptions): Likewise.
 555         * dcache.c (dcache_enabled_p): Likewise.
 556         * defs.h (info_verbose): Likewise.
 557         * demangle.c (demangle): Likewise.
 558         (asm_demangle): Likewise.
 559         * dwarf-index-cache.c (debug_index_cache): Likewise.
 560         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 561         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 562         * dwarf2read.c (check_physname): Likewise.
 563         (use_deprecated_index_sections): Likewise.
 564         (dwarf_always_disassemble): Likewise.
 565         * eval.c (overload_resolution): Likewise.
 566         * event-top.c (set_editing_cmd_var): Likewise.
 567         (exec_done_display_p): Likewise.
 568         * event-top.h (set_editing_cmd_var): Likewise.
 569         (exec_done_display_p): Likewise.
 570         * exec.c (write_files): Likewise.
 571         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 572         (debug_fbsd_nat): Likewise.
 573         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 574         Likewise.
 575         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 576         <backtrace_past_entry> Likewise.
 577         * gdb-demangle.h (demangle): Likewise.
 578         (asm_demangle): Likewise.
 579         * gdb_bfd.c (bfd_sharing): Likewise.
 580         * gdbcore.h (write_files): Likewise.
 581         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 582         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 583         * gdbthread.h (print_thread_events): Likewise.
 584         * gdbtypes.c (opaque_type_resolution): Likewise.
 585         (strict_type_checking): Likewise.
 586         * gnu-nat.c (gnu_debug_flag): Likewise.
 587         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 588         * guile/scm-param.c (pascm_variable): Add boolval.
 589         (add_setshow_generic): Update.
 590         (pascm_param_value): Update.
 591         (pascm_set_param_value_x): Update.
 592         * hppa-tdep.c (hppa_debug): Change to bool..
 593         * infcall.c (may_call_functions_p): Likewise.
 594         (coerce_float_to_double_p): Likewise.
 595         (unwind_on_signal_p): Likewise.
 596         (unwind_on_terminating_exception_p): Likewise.
 597         * infcmd.c (startup_with_shell): Likewise.
 598         * inferior.c (print_inferior_events): Likewise.
 599         * inferior.h (startup_with_shell): Likewise.
 600         (print_inferior_events): Likewise.
 601         * infrun.c (step_stop_if_no_debug): Likewise.
 602         (detach_fork): Likewise.
 603         (debug_displaced): Likewise.
 604         (disable_randomization): Likewise.
 605         (non_stop): Likewise.
 606         (non_stop_1): Likewise.
 607         (observer_mode): Likewise.
 608         (observer_mode_1): Likewise.
 609         (set_observer_mode): Update.
 610         (sched_multi): Change to bool.
 611         * infrun.h (debug_displaced): Likewise.
 612         (sched_multi): Likewise.
 613         (step_stop_if_no_debug): Likewise.
 614         (non_stop): Likewise.
 615         (disable_randomization): Likewise.
 616         * linux-tdep.c (use_coredump_filter): Likewise.
 617         (dump_excluded_mappings): Likewise.
 618         * linux-thread-db.c (auto_load_thread_db): Likewise.
 619         (check_thread_db_on_load): Likewise.
 620         * main.c (captured_main_1): Update.
 621         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 622         xx2_opt, boolean_opt>: Change to bool.
 623         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 624         * maint.c (maintenance_profile_p): Likewise.
 625         (per_command_time): Likewise.
 626         (per_command_space): Likewise.
 627         (per_command_symtab): Likewise.
 628         * memattr.c (inaccessible_by_default): Likewise.
 629         * mi/mi-main.c (mi_async): Likewise.
 630         (mi_async_1): Likewise.
 631         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 632         * nat/fork-inferior.h (startup_with_shell): Likewise.
 633         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 634         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 635         * nios2-tdep.c (nios2_debug): Likewise.
 636         * or1k-tdep.c (or1k_debug): Likewise.
 637         * parse.c (parser_debug): Likewise.
 638         * parser-defs.h (parser_debug): Likewise.
 639         * printcmd.c (print_symbol_filename): Likewise.
 640         * proc-api.c (procfs_trace): Likewise.
 641         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 642         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 643         (set_parameter_value): Update.
 644         (add_setshow_generic): Update.
 645         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 646         to bool*.
 647         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 648         int*.
 649         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 650         * record-btrace.c (record_btrace_target::store_registers): Update.
 651         * record-full.c (record_full_memory_query): Change to bool.
 652         (record_full_stop_at_limit): Likewise.
 653         * record-full.h (record_full_memory_query): Likewise.
 654         * remote-notif.c (notif_debug): Likewise.
 655         * remote-notif.h (notif_debug): Likewise.
 656         * remote.c (use_range_stepping): Likewise.
 657         (interrupt_on_connect): Likewise.
 658         (remote_break): Likewise.
 659         * ser-tcp.c (tcp_auto_retry): Likewise.
 660         * ser-unix.c (serial_hwflow): Likewise.
 661         * skip.c (debug_skip): Likewise.
 662         * solib-aix.c (solib_aix_debug): Likewise.
 663         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 664         (spu_auto_flush_cache_p): Likewise.
 665         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 666         Likewise.
 667         (struct info_print_options) <quiet>: Likewise.
 668         * symfile-debug.c (debug_symfile): Likewise.
 669         * symfile.c (auto_solib_add): Likewise.
 670         (separate_debug_file_debug): Likewise.
 671         * symfile.h (auto_solib_add): Likewise.
 672         (separate_debug_file_debug): Likewise.
 673         * symtab.c (basenames_may_differ): Likewise.
 674         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 675         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 676         (struct info_types_options) <quiet>: Likewise.
 677         * symtab.h (demangle): Likewise.
 678         (basenames_may_differ): Likewise.
 679         * target-dcache.c (stack_cache_enabled_1): Likewise.
 680         (code_cache_enabled_1): Likewise.
 681         * target.c (trust_readonly): Likewise.
 682         (may_write_registers): Likewise.
 683         (may_write_memory): Likewise.
 684         (may_insert_breakpoints): Likewise.
 685         (may_insert_tracepoints): Likewise.
 686         (may_insert_fast_tracepoints): Likewise.
 687         (may_stop): Likewise.
 688         (auto_connect_native_target): Likewise.
 689         (target_stop_and_wait): Update.
 690         (target_async_permitted): Change to bool.
 691         (target_async_permitted_1): Likewise.
 692         (may_write_registers_1): Likewise.
 693         (may_write_memory_1): Likewise.
 694         (may_insert_breakpoints_1): Likewise.
 695         (may_insert_tracepoints_1): Likewise.
 696         (may_insert_fast_tracepoints_1): Likewise.
 697         (may_stop_1): Likewise.
 698         * target.h (target_async_permitted): Likewise.
 699         (may_write_registers): Likewise.
 700         (may_write_memory): Likewise.
 701         (may_insert_breakpoints): Likewise.
 702         (may_insert_tracepoints): Likewise.
 703         (may_insert_fast_tracepoints): Likewise.
 704         (may_stop): Likewise.
 705         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 706         (make_thread_apply_all_options_def_group): Change argument from int*
 707         to bool*.
 708         (thread_apply_all_command): Update.
 709         (print_thread_events): Change to bool.
 710         * top.c (confirm): Likewise.
 711         (command_editing_p): Likewise.
 712         (history_expansion_p): Likewise.
 713         (write_history_p): Likewise.
 714         (info_verbose): Likewise.
 715         * top.h (confirm): Likewise.
 716         (history_expansion_p): Likewise.
 717         * tracepoint.c (disconnected_tracing): Likewise.
 718         (circular_trace_buffer): Likewise.
 719         * typeprint.c (print_methods): Likewise.
 720         (print_typedefs): Likewise.
 721         * utils.c (debug_timestamp): Likewise.
 722         (sevenbit_strings): Likewise.
 723         (pagination_enabled): Likewise.
 724         * utils.h (sevenbit_strings): Likewise.
 725         (pagination_enabled): Likewise.
 726         * valops.c (overload_resolution): Likewise.
 727         * valprint.h (struct value_print_options) <prettyformat_arrays,
 728         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 729         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 730         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 731         Likewise.
 732         * windows-nat.c (new_console): Likewise.
 733         (cygwin_exceptions): Likewise.
 734         (new_group): Likewise.
 735         (debug_exec): Likewise.
 736         (debug_events): Likewise.
 737         (debug_memory): Likewise.
 738         (debug_exceptions): Likewise.
 739         (useshell): Likewise.
 740         * windows-tdep.c (maint_display_all_tib): Likewise.
 741         * xml-support.c (debug_xml): Likewise.
 742
 743 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 744
 745         * source.c (prepare_path_for_appending): New function.
 746         (openp): Make use of new function.
 747         (find_and_open_source): Search for the compilation directory and
 748         source file as a relative path beneath the directory search path.
 749
 750 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * source-cache.c (source_cache::get_line_charpos): Catch
 753         exceptions and return false, this matches the behaviour documented
 754         in the header file.
 755
 756 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 757
 758         * ada-tasks.c (info_task): Remove quoting of the task's name.
 759
 760 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 761
 762         * symfile.c (auto_solib_add): Replace comment with a reference
 763         to the header file.
 764
 765 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 766
 767         * NEWS: Mention that gdb can now be compiled with Python 3
 768         on Windows.
 769
 770 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * maint.c (maint_print_section_data::maint_print_section_data):
 773         Force use of 'float log10 (float)' by casting the argument to
 774         float.
 775
 776 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * maint.c: Add 'cmath' include.
 779         (struct maint_print_section_data): New structure.
 780         (print_section_index): New function.
 781         (print_bfd_section_info): Add header comment, small whitespace
 782         cleanup, and update to call new print_section_index function.
 783         (print_objfile_section_info): Likewise.
 784         (maint_obj_section_from_bfd_section): New function.
 785         (print_bfd_section_info_maybe_relocated): New function.
 786         (maintenance_info_sections): Add header comment, always use
 787         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 788
 789 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 792         inner scope, add check that the objfile has psymtabs before
 793         checking psymtabs_addrmap.
 794         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 795
 796 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 797
 798         * NEWS: Announce that Ada task names are now shown at more places,
 799         and between quotes (except in info task output).
 800         * gdb/ada-tasks.c (task_to_str): New function.
 801         (display_current_task_id): Call task_to_str.
 802         (task_command_1): Likewise.
 803         (print_ada_task_info): In non-mi mode, Properly align headers and data
 804         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 805
 806 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 807
 808         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 809         prstatus.pr_lwp.pr_info instead of making it up.
 810
 811 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 812
 813         * auto-load.c (auto_load_expand_dir_vars): Update.
 814         * defs.h (gdb_datadir): Change to std::string.
 815         (python_libdir): Likewise.
 816         (relocate_gdb_directory): Change return type to std::string.
 817         * guile/guile.c (gdbscm_data_directory): Update.
 818         (initialize_scheme_side): Update.
 819         * jit.c (jit_reader_dir): Change to std::string.
 820         (jit_reader_load_command): Update.
 821         * main.c (gdb_datadir): Change to std::string.
 822         (python_libdir): Likewise.
 823         (set_gdb_data_directory): Update.
 824         (relocate_path): Change to return std::string.
 825         (relocate_gdb_directory): Change to return std::string.
 826         (relocate_gdbinit_path_maybe_in_datadir): Update.
 827         (captured_main_1): Update.
 828         * python/python.c (do_start_initialization): Update.
 829         * top.c (show_gdb_datadir): Update.
 830         * xml-syscall.c (xml_init_syscalls_info): Update.
 831         (init_syscalls_info): Update.
 832
 833 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 834
 835         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 836         out of get_init_files.
 837         (get_init_files): Update.
 838
 839 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 840
 841         * main.c (get_init_files): Change to use std::string.
 842         (captured_main_1): Update.
 843         (print_gdb_help): Update.
 844
 845 2019-09-11  Ali Tamur  <tamur@google.com>
 846
 847         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 848         implementation.
 849
 850 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 851
 852         * dbxread.c (read_dbx_symtab): Update.
 853         * dwarf2read.c (load_partial_dies): Update.
 854         * mdebugread.c (parse_partial_symbols): Update.
 855         (handle_psymbol_enumerators): Update.
 856         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 857         * psymtab.c (add_psymbol_to_bcache): Likewise.
 858         (add_psymbol_to_list): Likewise.
 859         * symtab.c (symbol_set_names): Likewise.
 860         * symtab.h (symbol_set_names): Likewise.
 861         * xcoffread.c (scan_xcoff_symtab): Update.
 862
 863 2019-09-11  Tom Tromey  <tom@tromey.com>
 864
 865         * symfile-mem.c (symbol_file_add_from_memory): Use
 866         bfd_set_filename.
 867         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 868         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 869
 870 2019-09-10  Tom Tromey  <tromey@adacore.com>
 871
 872         * dwarf-index-write.c (write_psymbols): Extend error message.
 873         (debug_names::insert): Add Ada code.
 874         (debug_names::write_psymbols): Remove Ada check.
 875         (debug_names) <m_string_obstack>: New member.
 876         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 877         (gdb_index_symbol_name_matcher::matches): Remove.
 878         (mapped_index_base::find_name_components_bounds): Add "lang"
 879         parameter.
 880         (mapped_index_base::build_name_components): Also split names
 881         according to Ada syntax.
 882         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 883         type of "match_callback".
 884         (check_match, check_find_bounds_finds)
 885         (dw2_expand_symtabs_matching): Update.
 886         (dw2_debug_names_iterator): Add new constructor.
 887         (dw2_debug_names_map_matching_symbols): New function.
 888         (dw2_debug_names_expand_symtabs_matching): Update.
 889         (dwarf2_debug_names_functions): Use
 890         dw2_debug_names_map_matching_symbols.
 891
 892 2019-09-10  Tom Tromey  <tromey@adacore.com>
 893
 894         * dwarf2read.c (dw2_get_file_names_reader): Add the
 895         CU's file name to the results.
 896
 897 2019-09-10  Tom Tromey  <tromey@adacore.com>
 898
 899         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 900         map_matching_symbols.  Update.
 901         * dwarf2read.c (dw2_map_matching_symbols): Update.
 902         * psymtab.c (match_partial_symbol): Change type; update.
 903         (psym_map_matching_symbols): Likewise.
 904         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 905         type; update.
 906         * symfile.h (struct quick_symbol_functions)
 907         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 908         Remove "match".
 909
 910 2019-09-10  Tom Tromey  <tromey@adacore.com>
 911
 912         * psymtab.c (map_block): Remove.
 913         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 914         * symtab.c (iterate_over_symbols_terminated): New function.
 915         * symtab.c (iterate_over_symbols_terminated): Declare.
 916
 917 2019-09-10  Tom Tromey  <tromey@adacore.com>
 918
 919         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 920         * language.h (struct language_defn) <la_iterate_over_symbols>:
 921         Return bool.
 922         * symtab.c (iterate_over_symbols): Return bool.
 923         * symtab.h (iterate_over_symbols): Return bool.
 924
 925 2019-09-10  Tom Tromey  <tromey@adacore.com>
 926
 927         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 928         (add_nonlocal_symbols): Update.
 929         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 930         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 931         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 932         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 933         Change type of "callback".  Remove "data".
 934
 935
 936 2019-09-09  Ali Tamur  <tamur@google.com>
 937
 938         * dwarf2read.c (comp_unit_head): Update comment.
 939         (dwarf2_dwo_name): New function declaration.
 940         (dwarf_unit_type_name): New function declaration.
 941         (read_comp_unit_head): Add support for new compilation units,
 942         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 943         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 944         (currently named as "signature") in their header. Also clarify error
 945         messages.
 946         (lookup_dwo_id): New function. Returns the dwo id of the given
 947         compile unit.
 948         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 949         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 950         functions.
 951         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 952         (dwarf2_dwo_name): Get the dwo name if present.
 953         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 954         purposes.
 955
 956 2019-09-09  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 959
 960 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 961
 962         * python/python.c (do_start_initialization): Make progname_copy static,
 963         to avoid a leak report.
 964
 965 2019-09-08  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 968
 969 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 970
 971         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 972         Change type to gdb::optional<block_enum>.
 973         (dw2_symtab_iter_init): Change block_index parameter type
 974         to gdb::optional<block_enum>.
 975         (dw2_lookup_symbol): Change block_index parameter
 976         type to block_enum.c
 977         (dw2_debug_names_lookup_symbol): Likewise.
 978         * psymtab.c (psym_lookup_symbol): Likewise.
 979         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 980         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 981         Likewise.
 982
 983 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 984
 985         * defs.h (relocate_gdb_directory): Change int to bool in
 986         signature and rename flag to relocatable.
 987         * main.c (relocate_path): Likewise.
 988         (relocate_gdb_directory): Likewise.
 989
 990 2019-09-06  Alan Modra  <amodra@gmail.com>
 991
 992         * coffread.c (coff_symfile_read): Constify filename variable.
 993         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 994         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 995         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 996         * solib.c (reload_shared_libraries_1): Likewise.
 997         * symfile.c (reread_symbols): Likewise.
 998         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 999         * solib-darwin.c (darwin_bfd_open): Likewise.
1000         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1001
1002 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1005         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1006
1007 2019-09-03  Tom Tromey  <tromey@adacore.com>
1008
1009         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1010         types.
1011         (has_negatives): Unbias a range type bound.
1012         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1013         * gdbtypes.c (operator==): Handle new field.
1014         (create_range_type): Add "bias" parameter.
1015         (create_static_range_type, resolve_dynamic_range): Update.
1016         * gdbtypes.h (struct range_bounds) <bias>: New member.
1017         (create_range_type): Add bias parameter.
1018         * printcmd.c (print_scalar_formatted): Unbias range types.
1019         * value.c (unpack_long): Unbias range types.
1020         (pack_long): Bias range types.
1021
1022 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1023
1024         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1025         probe arguments.
1026
1027 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1028
1029         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1030         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1031         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1032         (compile_probe_arg): Likewise.
1033         * probe.h (get_argument_count): Likewise.
1034         * solib-svr4.c (solib_event_probe_action): Likewise.
1035         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1036
1037 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1038
1039         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1040         code to here...
1041         (svr4_create_solib_event_breakpoints): ...from here.
1042
1043 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1044
1045         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1046         suffix from warning message.
1047
1048 2019-08-30  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-winsource.h (struct tui_source_window_base)
1051         <refresh_all>: Don't declare.
1052         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1053         Remove.
1054         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1055         tui_show_locator_content.
1056         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1057         declare.
1058         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1059         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1060         declare.
1061
1062 2019-08-30  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1065
1066 2019-08-30  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1069         Remove unnecessary forward declarations.
1070
1071 2019-08-30  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1074         rerender.
1075         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1076         tui_show_locator_content.
1077
1078 2019-08-30  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1081         (tui_locator_window::rerender): Rewrite using body of previous
1082         tui_show_locator_content.
1083
1084 2019-08-30  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1087         set_locator_fullname>: New methods.
1088         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1089         Rename from tui_set_locator_fullname.
1090         (tui_locator_window::set_locator_info): Rename from
1091         tui_set_locator_info.  Return bool.
1092         (tui_update_locator_fullname, tui_show_frame_info): Update.
1093
1094 2019-08-30  Tom Tromey  <tom@tromey.com>
1095
1096         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1097
1098 2019-08-30  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1101         call touchwin.
1102
1103 2019-08-30  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-wingeneral.c (box_win): Assume win_info and
1106         win_info->handle cannot be NULL.
1107
1108 2019-08-30  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1111         refresh_window>: Declare.
1112         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1113         resize.
1114         (tui_data_item_window::rerender): Rename from
1115         tui_display_register.
1116         (tui_data_item_window::refresh_window): New method.
1117         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1118         no-op.
1119
1120 2019-08-30  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1123         regs_column_count, current_group>: Move later.  Now private.
1124         <get_current_group>: New method.
1125         * tui/tui-regs.c (tui_reg_command): Update.
1126         * tui/tui-layout.c (tui_set_layout): Update.
1127
1128 2019-08-30  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1131         (tui_data_window::rerender): Don't call
1132         check_and_display_highlight_if_needed.
1133         (tui_data_window::refresh_all): Remove call to
1134         erase_data_content.
1135
1136 2019-08-30  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1139         (tui_data_window::display_registers_from)
1140         (tui_data_window::display_reg_element_at_line)
1141         (tui_data_window::display_registers_from_line): Remove checks of
1142         "empty".
1143
1144 2019-08-30  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1147         Don't declare.
1148         * tui/tui-regs.c (tui_data_window::show_registers): Call
1149         rerender.
1150         (tui_data_window::rerender): Rename from display_all_data.
1151         (tui_data_window::rerender): Remove old implementation.
1152
1153 2019-08-30  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1156         text.
1157         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1158
1159 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1160             Sergio Durigan Junior  <sergiodj@redhat.com>
1161
1162         PR win32/24284
1163         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1164
1165 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1166
1167         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1168         when searching for types.
1169
1170 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1171
1172         * f-lang.c (f_language_defn): Use f_print_typedef.
1173         * f-lang.h (f_print_typedef): Declare.
1174         * f-typeprint.c (f_print_typedef): Define.
1175
1176 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1177
1178         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1179
1180 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * cli/cli-utils.c (info_print_options_defs): Delete.
1183         (make_info_print_options_def_group): Delete.
1184         (extract_info_print_options): Delete.
1185         (info_print_command_completer): Delete.
1186         (info_print_args_help): Add extra parameter, and optionally
1187         include text about -n flag.
1188         * cli/cli-utils.h (struct info_print_options): Delete.
1189         (extract_info_print_options): Delete declaration.
1190         (info_print_command_completer): Delete declaration.
1191         (info_print_args_help): Add extra parameter, extend header
1192         comment.
1193         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1194         search_symbols.
1195         * stack.c (struct info_print_options): New type.
1196         (info_print_options_defs): New file scoped variable.
1197         (make_info_print_options_def_group): New static function.
1198         (info_print_command_completer): New static function.
1199         (info_locals_command): Update to use new local functions.
1200         (info_args_command): Likewise.
1201         (_initialize_stack): Add extra parameter to calls to
1202         info_print_args_help.
1203         * symtab.c (search_symbols): Add extra parameter, use this to
1204         possibly excluse non-debug symbols.
1205         (symtab_symbol_info): Add extra parameter, which is passed on to
1206         search_symbols.
1207         (struct info_print_options): New type.
1208         (info_print_options_defs): New file scoped variable.
1209         (make_info_print_options_def_group): New static function.
1210         (info_print_command_completer): New static function.
1211         (info_variables_command): Update to use local functions, and pass
1212         extra parameter through to symtab_symbol_info.
1213         (info_functions_command): Likewise.
1214         (info_types_command): Pass additional argument through to
1215         symtab_symbol_info.
1216         (rbreak_command): Pass extra argument to search_symbols.
1217         (_initialize_symtab): Add extra arguments for calls to
1218         info_print_args_help, and update help text for 'info variables',
1219         'whereis', and 'info functions' commands.
1220         * symtab.h (search_symbols): Add extra argument to declaration.
1221         * NEWS: Mention new flags.
1222
1223 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1224
1225         * symtab.c (lookup_static_symbol): Call the new function (and move
1226         it down to be next to lookup_global_symbol).
1227         (struct global_sym_lookup_data): Add block_enum member and rename to...
1228         (struct global_or_static_sym_lookup_data): ...this.
1229         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1230         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1231         (lookup_symbol_global_or_static_iterator_cb): ...this.
1232         (lookup_global_or_static_symbol): New function.
1233         (lookup_global_symbol): Call new function.
1234
1235 2019-08-26  Tom de Vries  <tdevries@suse.de>
1236
1237         PR c++/24852
1238         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1239         when pc_probe.prob == NULL.
1240
1241 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1242
1243         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1244         variable symbol_linkage to symbol_linkage_.
1245
1246 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1247
1248         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1249         represent whether the symbol is static, dynamic, or we don't
1250         know.
1251
1252 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1253
1254         * gdb/rx-tdep.c (rx_register_names): New.
1255         (rx_register_name): Delete.
1256         (rx_psw_type): Delete.
1257         (rx_fpsw_type): Delete.
1258         (rx_register_type): Delete.
1259         (rx_gdbarch_init): Convert target-descriptions.
1260         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1261         * gdb/features/Makefile: Add rx.xml.
1262         * gdb/features/rx.xml: New.
1263         * gdb/features/rx.c: Generated.
1264         * gdb/NEWS: Mention target description support.
1265
1266 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1267
1268         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1269         *slot_ptr.
1270
1271 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1272
1273         * configure.ac: Don't check for 'dlfcn.h' (moved to
1274         gdbsupport/common.m4).
1275         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1276         'gdbsupport/'.
1277         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1278         * compile/compile-c-support.c: Include
1279         'gdbsupport/gdb-dlfcn.h'.
1280         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1281         * gdb-dlfcn.c: Move to...
1282         * gdbsupport/gdb-dlfcn.c: ... here.
1283         * gdb-dlfcn.h: Move to...
1284         * gdbsupport/gdb-dlfcn.h: ... here.
1285
1286 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1287
1288         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1289         the offset field signed.
1290
1291 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1292
1293         * python/lib/gdb/__init__.py (_execute_file): New function.
1294         * python/python.c (python_run_simple_file): Call gdb._execute_file
1295         on Windows.
1296
1297 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1300         all uses as this was never set to anything but a zero value.
1301
1302 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1303
1304         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1305
1306 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1307
1308         * tui/tui-data.h (tui_gen_win_info): Add an =default
1309         move constructor, required by some GCC versions.
1310
1311 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1312
1313         * go32-nat.c (go32_sysinfo): Add hygon_p.
1314
1315 2019-08-20  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1318         line_from_reg_element_no, first_reg_element_no_inline,
1319         display_all_data, delete_data_content_windows,
1320         erase_data_content>: Now private.
1321
1322 2019-08-20  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1325         (tui_unhighlight_win, tui_highlight_win)
1326         (tui_win_info::make_window): Update.
1327         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1328
1329 2019-08-20  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1332         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1333         (MAX_PID_WIDTH): Move to tui-stack.c.
1334         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1335         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1336         (MAX_PID_WIDTH): Move from tui-data.h.
1337
1338 2019-08-20  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1341         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1342         (box_win): Update.
1343         (tui_gen_win_info::make_window): Rename from tui_make_window.
1344         (tui_win_info::make_window): New method.
1345         (tui_gen_win_info::make_visible): Update.
1346         * tui/tui-source.c (tui_source_window::set_contents): Update.
1347         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1348         (tui_data_window::display_registers_from): Update.
1349         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1350         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1351         Declare.
1352         <can_box>: Remove.
1353         <title>: Remove.
1354         (struct tui_win_info) <make_window>: Declare.
1355         <can_box>: Now virtual.
1356         <title>: New member.
1357         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1358         * tui/tui-command.c (tui_cmd_window::resize): Update.
1359
1360 2019-08-20  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1363         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1364         (tui_data_window::check_register_values): Update.
1365
1366 2019-08-20  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-regs.h (struct tui_data_window): Use
1369         DISABLE_COPY_AND_ASSIGN.
1370         <regs_content>: Change type, removing unique_ptr.
1371         <tui_data_window>: Add move constructor.
1372         * tui/tui-regs.c (tui_data_window::show_registers)
1373         (tui_data_window::show_register_group)
1374         (tui_data_window::display_registers_from)
1375         (tui_data_window::display_registers_from)
1376         (tui_data_window::first_data_item_displayed)
1377         (tui_data_window::delete_data_content_windows)
1378         (tui_data_window::rerender, tui_data_window::refresh_window)
1379         (tui_data_window::check_register_values): Update.
1380
1381 2019-08-20  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1384         show_register_group>: Declare.
1385         (tui_show_register_group): Don't declare.
1386         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1387         tui_show_registers.
1388         (tui_data_window::show_register_group): Rename from
1389         tui_show_register_group.
1390         (tui_data_window::check_register_values, tui_reg_command):
1391         Update.
1392         * tui/tui-layout.c (tui_set_layout): Update.
1393
1394 2019-08-20  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1397         Declare.
1398         (tui_check_register_values): Don't declare.
1399         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1400         from tui_check_register_values.
1401         * tui/tui-hooks.c (tui_register_changed): Update.
1402
1403 2019-08-20  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-regs.c (tui_reg_layout): Move later.
1406         (tui_show_registers): Don't enable TUI mode or change layout.
1407
1408 2019-08-20  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-regs.h (struct tui_data_item_window)
1411         <~tui_data_item_window>: Remove.
1412         <content>: Now a unique_xmalloc_ptr.
1413         * tui/tui-regs.c (tui_register_format): Return a
1414         unique_xmalloc_ptr.
1415         (tui_get_register): Update.
1416         (~tui_data_item_window): Remove.
1417         (tui_data_window::display_registers_from, tui_display_register):
1418         Update.
1419         * tui/tui-io.h (tui_expand_tabs): Update.
1420         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1421         Remove "col" parameter.
1422
1423 2019-08-20  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1426         field.
1427         * tui/tui-regs.c (~tui_data_item_window): Update.
1428
1429 2019-08-20  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1432         earlier.
1433
1434 2019-08-20  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1437
1438 2019-08-20  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-source.h (struct tui_source_window): Update.
1441         * tui/tui-regs.c (tui_show_registers): Update.
1442         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1443         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1444         (NO_REGS_STRING): Remove defines.
1445
1446 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1447
1448         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1449         unnecessary thread walk if remote doesn't support the packet.
1450
1451 2019-08-19  Tom Tromey  <tromey@adacore.com>
1452
1453         * python/py-value.c (value_has_field): Fix indentation.
1454
1455 2019-08-19  Tom Tromey  <tromey@adacore.com>
1456
1457         * printcmd.c (do_one_display, info_display_command): Update.
1458         * block.h (contained_in): Return bool.  Add allow_nested
1459         parameter.
1460         * block.c (contained_in): Return bool.  Add allow_nested
1461         parameter.
1462
1463 2019-08-19  Tom Tromey  <tom@tromey.com>
1464
1465         * configure: Rebuild.
1466         * configure.ac: Disallow the combination of -static-libstdc++ and
1467         source highlight.
1468         * source-cache.c (get_language_name): Handle rust.
1469         (source_cache::get_source_lines): Ignore highlighting exceptions.
1470
1471 2019-08-16  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1474         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1475         (struct tui_source_window_base) <make_visible, refresh_window,
1476         resize>: Remove methods.
1477         <execution_info>: Remove field.
1478         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1479         (tui_show_source_line, tui_source_window_base)
1480         (~tui_source_window_base): Update.
1481         (tui_source_window_base::resize)
1482         (tui_source_window_base::make_visible)
1483         (tui_source_window_base::refresh_window): Remove.
1484         (tui_source_window_base::update_exec_info): Update.
1485         * tui/tui-source.c (tui_source_window::set_contents): Update.
1486         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1487
1488 2019-08-16  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1491         deprecated_query_hook.
1492
1493 2019-08-16  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1496         (tui_update_source_windows_with_line): Update.
1497         * tui/tui-source.h (struct tui_source_window)
1498         <show_symtab_source>: Declare.
1499         (tui_show_symtab_source): Don't declare.
1500         * tui/tui-source.c (tui_show_symtab_source): Rename from
1501         tui_show_symtab_source.
1502
1503 2019-08-16  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-winsource.h (struct tui_source_window_base)
1506         <set_contents>: Declare.
1507         * tui/tui-winsource.c
1508         (tui_source_window_base::update_source_window_as_is): Update.
1509         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1510         Declare.
1511         (tui_set_source_content): Don't declare.
1512         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1513         tui_set_source_content.
1514         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1515         Declare.
1516         (tui_set_disassem_content): Don't declare.
1517         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1518         tui_set_disassem_content.
1519
1520 2019-08-16  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-winsource.h (struct tui_source_window_base)
1523         <update_breakpoint_info>: Declare.
1524         (tui_update_breakpoint_info): Don't declare.
1525         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1526         (tui_update_all_breakpoint_info): Update.
1527         (tui_source_window_base::update_breakpoint_info): Rename from
1528         tui_update_breakpoint_info.
1529         (tui_source_window_base::update_exec_info): Update.
1530
1531 2019-08-16  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-winsource.h (struct tui_source_window_base)
1534         <update_source_window>: Declare.
1535         (tui_update_source_window): Don't declare.
1536         * tui/tui-winsource.c
1537         (tui_source_window_base::update_source_window): Rename from
1538         tui_update_source_window.
1539         (tui_source_window_base::rerender): Update.
1540         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1541         * tui/tui-disasm.c (tui_show_disassem)
1542         (tui_show_disassem_and_update_source)
1543         (tui_disasm_window::maybe_update): Update.
1544
1545 2019-08-16  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-winsource.h (struct tui_source_window_base)
1548         <update_source_window_as_is>: Declare.
1549         (tui_update_source_window_as_is): Don't declare.
1550         * tui/tui-winsource.c (tui_update_source_window): Update
1551         (tui_source_window_base::update_source_window_as_is): Rename from
1552         tui_update_source_window_as_is.
1553         (tui_source_window_base::refill): Update.
1554         * tui/tui-source.c (tui_show_symtab_source): Update.
1555         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1556         Update.
1557
1558 2019-08-16  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.h (tui_update_source_window)
1561         (tui_update_source_window_as_is): Remove "noerror" parameter.
1562         * tui/tui-winsource.c (tui_update_source_window)
1563         (tui_update_source_window_as_is): Remove "noerror" parameter.
1564         (tui_update_source_windows_with_addr)
1565         (tui_update_source_windows_with_line)
1566         (tui_source_window_base::rerender)
1567         (tui_source_window_base::refill): Update.
1568         * tui/tui-source.h (tui_set_source_content)
1569         (tui_show_symtab_source): Remove "noerror" parameter.
1570         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1571         parameter.
1572         (tui_show_symtab_source): Likewise.
1573         (tui_source_window::maybe_update): Update.
1574         * tui/tui-disasm.c (tui_show_disassem)
1575         (tui_show_disassem_and_update_source)
1576         (tui_disasm_window::do_scroll_vertical)
1577         (tui_disasm_window::maybe_update): Update.
1578
1579 2019-08-16  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui.c (tui_is_window_visible): Update.
1582         * tui/tui-wingeneral.c (tui_make_window)
1583         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1584         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1585         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1586         (tui_set_win_height_command, parse_scrolling_args): Update.
1587         * tui/tui-source.c (tui_source_window::style_changed): Update.
1588         * tui/tui-regs.c (tui_show_registers)
1589         (tui_data_window::first_data_item_displayed)
1590         (tui_data_window::delete_data_content_windows)
1591         (tui_check_register_values, tui_reg_command): Update.
1592         * tui/tui-disasm.c (tui_show_disassem): Update.
1593         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1594         method.
1595         <is_visible>: Remove field.
1596         * tui/tui-data.c (tui_next_win, tui_prev_win)
1597         (tui_delete_invisible_windows): Update.
1598
1599 2019-08-16  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-winsource.h (struct tui_source_window_base)
1602         <m_has_locator>: Remove.
1603         * tui/tui-layout.c (show_source_disasm_command, show_data)
1604         (show_source_or_disasm_and_command): Update.
1605
1606 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1607
1608         * NEWS (Other MI changes): New subsection.
1609         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1610         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1611         * arch-utils.c (default_get_pc_address_flags): New function.
1612         * arch-utils.h (default_get_pc_address_flags): New declaration.
1613         * gdbarch.sh: Add get_pc_address_flags.
1614         * gdbarch.c: Regenerate.
1615         * gdbarch.h: Likewise.
1616         * stack.c (print_pc): New function.
1617         (print_frame_info) (print_frame): Call print_pc.
1618
1619 2019-08-16  Tom de Vries  <tdevries@suse.de>
1620
1621         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1622         print_objfile_section_info.
1623
1624 2019-08-15  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1627         calling update_cmdwin_start_line.
1628         * tui/tui-winsource.h (struct tui_source_window_base)
1629         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1630         <rerender>: Declare.
1631         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1632         Call rerender.
1633         (tui_source_window_base::set_new_height): Remove.
1634         (tui_source_window_base::rerender): Rename from
1635         do_make_visible_with_new_height.
1636         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1637         resize method.
1638         (tui_win_info::make_invisible_and_set_new_height)
1639         (tui_win_info::make_visible_with_new_height): Remove.
1640         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1641         Declare.
1642         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1643         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1644         do_make_visible_with_new_height>: Don't declare.
1645         <rerender>: Declare.
1646         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1647         set_new_height.
1648         (tui_data_window::do_make_visible_with_new_height): Remove.
1649         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1650         call tui_show_locator_content.
1651         (tui_gen_win_info::resize): Call rerender.
1652         (show_source_or_disasm_and_command): Don't call
1653         tui_show_locator_content.
1654         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1655         method.
1656         (struct tui_win_info) <rerender>: Declare.
1657         <set_new_height, make_invisible_and_set_new_height,
1658         make_visible_with_new_height>: Don't declare.
1659         * tui/tui-data.c (tui_win_list::rerender): New method.
1660         * tui/tui-command.h (struct tui_cmd_window)
1661         <do_make_visible_with_new_height>: Don't declare.
1662         * tui/tui-command.c
1663         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1664
1665 2019-08-15  Tom Tromey  <tromey@adacore.com>
1666
1667         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1668         * ada-lang.c (ada_enum_name): Likewise.
1669
1670 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1671
1672         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1673         leading underscore.
1674         (GdbOutputErrorFile): Likewise.
1675         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1676         accordingly.
1677         (execute_unwinders): Rename to have a leading underscore.
1678         (auto_load_packages): Likewise.
1679         (global scope): Adjust call to auto_load_packages accordingly.
1680         (GdbSetPythonDirectory): Likewise.
1681         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1682         instead of execute_unwinders.
1683
1684 2019-08-15  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1687         (show_data): Don't change window visibility.
1688         (tui_gen_win_info::resize): Remove special case for command
1689         window.  Use wresize, when available.
1690         (show_source_or_disasm_and_command): Don't change window
1691         visibility.
1692         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1693         <make_visible>: New method.
1694         * tui/tui-command.c (tui_cmd_window::resize): New method.
1695
1696 2019-08-15  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1699         (struct tui_source_windows): New.
1700         * tui/tui-winsource.c (tui_display_main): Update.
1701         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1702         (new_height_ok, parse_scrolling_args): Update.
1703         * tui/tui-layout.c (show_layout, show_data): Update.
1704         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1705         (tui_add_to_source_windows): Don't declare.
1706         * tui/tui-data.c (source_windows, tui_source_windows)
1707         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1708
1709 2019-08-15  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1712         Rename from reset.
1713         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1714         * tui/tui-layout.c (show_source_disasm_command, show_data):
1715         Update.
1716         (tui_gen_win_info::resize): Rename.
1717         (show_source_or_disasm_and_command): Update.
1718         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1719         reset.
1720
1721 2019-08-15  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1724         * tui/tui-interp.c (tui_interp::init): Don't call
1725         tui_initialize_static_data.
1726         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1727
1728 2019-08-15  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1731         examine tui_win_list.
1732
1733 2019-08-15  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1736         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1737         tui_clear_source_content.
1738         (tui_clear_source_content): Remove.
1739         (tui_source_window_base::do_erase_source_content): Hoist call to
1740         content.clear().
1741         * tui/tui-stack.c (tui_show_frame_info): Don't call
1742         tui_clear_source_content.
1743
1744 2019-08-15  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-winsource.h (struct tui_source_window_base)
1747         <do_erase_source_content>: New method.
1748         <erase_source_content>: New method.
1749         (tui_erase_source_content): Don't declare.
1750         * tui/tui-winsource.c (tui_clear_source_content): Update.
1751         (tui_source_window_base::do_erase_source_content): Rename from
1752         tui_erase_source_content.
1753         (tui_source_window_base::show_source_content): Update.
1754         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1755         * tui/tui-source.h (struct tui_source_window)
1756         <erase_source_content>: New method.
1757         * tui/tui-disasm.h (struct tui_disasm_window)
1758         <erase_source_content>: New method.
1759
1760 2019-08-15  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1763         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1764         constructor.
1765         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1766         * tui/tui-source.c (tui_set_source_content): Update.
1767         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1768
1769 2019-08-15  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1772         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1773         tui-source.c.
1774         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1775         Declare.
1776         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1777         method.
1778         (tui_source_window::maybe_update): Update.
1779
1780 2019-08-15  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1783         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1784         tui-disasm.c.
1785         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1786         Declare.
1787         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1788         method.
1789         (tui_disasm_window::maybe_update): Update.
1790
1791 2019-08-15  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-winsource.h (struct tui_source_window_base)
1794         <maybe_update>: Declare.
1795         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1796         method.
1797         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1798         Declare.
1799         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1800         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1801         Declare.
1802         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1803
1804 2019-08-15  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1807
1808 2019-08-15  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-wingeneral.c: Include tui-stack.h.
1811         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1812         (struct tui_locator_window): Move from tui-data.h.
1813         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1814         (tui_initialize_static_data): Move from tui-data.c.
1815         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1816         (struct tui_locator_window): Move to tui-stack.c.
1817         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1818         (tui_initialize_static_data): Move to tui-stack.c.
1819
1820 2019-08-15  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-layout.c (show_source_disasm_command)
1823         (show_source_or_disasm_and_command): Use make_visible method, not
1824         tui_make_window.
1825         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1826         Remove.
1827
1828 2019-08-15  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-wingeneral.h (tui_make_window): Update.
1831         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1832         parameter.
1833         (tui_gen_win_info::make_visible): Update.
1834         * tui/tui-regs.c (tui_data_window::display_registers_from):
1835         Update.
1836         * tui/tui-layout.c (show_source_disasm_command)
1837         (show_source_or_disasm_and_command): Update.
1838         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1839         (enum tui_box): Remove.
1840         (struct tui_win_info) <can_box>: New method.
1841         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1842         method.
1843
1844 2019-08-15  Tom de Vries  <tdevries@suse.de>
1845
1846         * linux-nat-trad.c: Include gdbarch.h.
1847
1848 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1849
1850         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1851         register sizes.
1852
1853 2019-08-14  Tom Tromey  <tromey@adacore.com>
1854
1855         * darwin-nat.c: Include gdbarch.h.
1856         * darwin-nat-info.c: Include gdbarch.h.
1857
1858 2019-08-13  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1861         Remove.
1862         * tui/tui-data.c (tui_initialize_static_data): Update.
1863
1864 2019-08-13  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-winsource.h (struct tui_exec_info_window)
1867         <~tui_exec_info_window, maybe_allocate_content, get_content,
1868         m_content>: Remove.
1869         (struct tui_source_window_base) <set_exec_info_content,
1870         show_exec_info_content>: Don't declare.
1871         * tui/tui-winsource.c
1872         (tui_exec_info_window::maybe_allocate_content): Remove.
1873         (tui_source_window_base::update_exec_info): Rename from
1874         set_exec_info_content.
1875         (tui_source_window_base::show_exec_info_content)
1876         (tui_source_window_base::update_exec_info): Remove.
1877
1878 2019-08-13  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1881         declare.
1882         * tui/tui-winsource.c (tui_update_source_window_as_is)
1883         (tui_update_source_windows_with_addr, tui_erase_source_content):
1884         Update.
1885         (tui_clear_exec_info_content): Remove.
1886
1887 2019-08-13  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1890         declare.
1891         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1892         call tui_erase_exec_info_content.
1893         (tui_clear_exec_info_content): Rename from
1894         tui_erase_exec_info_content.
1895         (tui_clear_exec_info_content): Delete.
1896
1897 2019-08-13  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-winsource.h (struct tui_source_window_base)
1900         <show_exec_info_content>: Declare.
1901         (tui_show_exec_info_content): Don't declare.
1902         * tui/tui-winsource.c
1903         (tui_source_window_base::show_exec_info_content): Rename from
1904         tui_show_exec_info_content.
1905         (tui_source_window_base::update_exec_info): Update.
1906
1907 2019-08-13  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1910         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1911         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1912         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1913         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1914         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1915         ... here.
1916
1917 2019-08-13  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-winsource.h (struct tui_source_window_base)
1920         <update_exec_info>: Declare.
1921         (tui_update_exec_info): Don't declare.
1922         * tui/tui-winsource.c (tui_update_source_window_as_is)
1923         (tui_source_window_base::refresh_all)
1924         (tui_update_all_breakpoint_info): Update.
1925         (tui_source_window_base::update_exec_info): Rename from
1926         tui_update_exec_info.
1927         * tui/tui-stack.c (tui_show_frame_info): Update.
1928
1929 2019-08-13  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-winsource.h (struct tui_source_window_base)
1932         <set_exec_info_content>: Declare.
1933         (tui_set_exec_info_content): Don't declare.
1934         * tui/tui-winsource.c
1935         (tui_source_window_base::set_exec_info_content): Rename from
1936         tui_set_exec_info_content.
1937         (tui_update_exec_info): Update.
1938
1939 2019-08-13  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-winsource.h (struct tui_source_window_base)
1942         <show_source_content>: Declare.
1943         (tui_show_source_content): Don't declare.
1944         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1945         (tui_source_window_base::show_source_content): Rename from
1946         tui_show_source_content.
1947         (tui_source_window_base::refresh_all): Update.
1948         * tui/tui-layout.c (show_source_disasm_command)
1949         (show_source_or_disasm_and_command): Update.
1950
1951 2019-08-13  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-winsource.c (tui_erase_source_content)
1954         (tui_show_source_content, tui_source_window_base::refresh_all):
1955         Update.
1956         * tui/tui-wingeneral.h
1957         (tui_check_and_display_highlight_if_needed): Don't declare.
1958         * tui/tui-wingeneral.c
1959         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1960         check_and_display_highlight_if_needed.
1961         * tui/tui-win.c (tui_rehighlight_all)
1962         (tui_win_info::make_visible_with_new_height): Update.
1963         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1964         (tui_data_window::erase_data_content)
1965         (tui_data_window::display_all_data): Update.
1966         * tui/tui-data.h (struct tui_win_info)
1967         <check_and_display_highlight_if_needed>: Declare.
1968
1969 2019-08-13  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-win.c (tui_resize_all): Call
1972         tui_delete_invisible_windows.
1973         * tui/tui-layout.c (show_layout): Call
1974         tui_delete_invisible_windows.
1975         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1976         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1977
1978 2019-08-13  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1981         tui_add_win_to_layout.
1982
1983 2019-08-13  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1986         * tui/tui-layout.c (tui_default_win_height): Now static.
1987
1988 2019-08-13  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1991         single switch.
1992         (show_source_disasm_command, show_source_or_disasm_and_command):
1993         Don't check current layout.
1994
1995 2019-08-13  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-wingeneral.c (make_all_visible): Remove.
1998         (tui_make_all_invisible): Simplify.
1999         * tui/tui-layout.c (tui_make_all_invisible): Move from
2000         tui-wingeneral.c; simplify.
2001         (show_layout): Hoist call to tui_make_all_invisible.
2002         (show_data): Don't call tui_make_all_invisible.
2003
2004 2019-08-13  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2007         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2008
2009 2019-08-13  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2012         tui-data.c.
2013         (show_source_disasm_command, show_data)
2014         (show_source_or_disasm_and_command): Don't use
2015         tui_set_current_layout_to.
2016         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2017         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2018         tui-layout.c.
2019         (tui_set_current_layout_to): Remove.
2020
2021 2019-08-13  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-layout.c (tui_set_layout): Update.
2024         * tui/tui-data.h (struct tui_layout_def): Remove.
2025         (tui_layout_def): Don't declare.
2026         * tui/tui-data.c (layout_def): Remove.
2027         (tui_layout_def): Remove.
2028
2029 2019-08-13  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-winsource.h (struct tui_source_window_base)
2032         <clear_detail>: No longer "override".
2033         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2034         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2035         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2036         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2037         Remove.
2038         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2039
2040 2019-08-13  Tom Tromey  <tromey@adacore.com>
2041
2042         * tracepoint.c: Don't include readline.h or history.h.
2043
2044 2019-08-12  Tom Tromey  <tom@tromey.com>
2045
2046         * configure: Rebuild.
2047         * configure.ac: Check for readline 7.
2048         * NEWS: Mention readline 7 requirement.
2049         * README: Update.
2050
2051 2019-08-12  Tom Tromey  <tom@tromey.com>
2052
2053         * mingw-hdep.c (gdb_select): Remove readline hack.
2054
2055 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2056
2057         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2058         when the function fails.
2059
2060 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2061
2062         * s390-tdep.c (s390_type_align): New function.
2063         (s390_gdbarch_init): Set it as type_align gdbarch method.
2064
2065 2019-08-09  Tom de Vries  <tdevries@suse.de>
2066
2067         PR gdb/24591
2068         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2069         pc_low with relocation offset.
2070
2071 2019-08-07  Tom Tromey  <tromey@adacore.com>
2072
2073         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2074         (print_frame_args): Update.
2075         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2076         Update.
2077         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2078         * frame.h (struct frame_arg): Add initializers.
2079         <error>: Now a unique_xmalloc_ptr.
2080
2081 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2082
2083         * NEWS: Expand the Pointer Authentication entry.
2084         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2085         (aarch64_frame_unmask_lr): ... to this.
2086         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2087         Call aarch64_frame_unmask_lr.
2088         * frame.c (struct frame_info): Add "masked" variable.
2089         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2090         (fprint_frame): Check for masked pc.
2091         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2092         declarations.
2093         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2094         * stack.c (print_frame): Check for masked pc.
2095
2096 2019-08-06  Tom Tromey  <tom@tromey.com>
2097
2098         * stabsread.c (patch_block_stabs, read_one_struct_field)
2099         (read_enum_type): Use obstack_strndup.
2100         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2101         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2102         * dwarf2read.c (guess_full_die_structure_name)
2103         (anonymous_struct_prefix): Use obstack_strndup.
2104         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2105         * c-exp.y (yylex): Use obstack_strndup.
2106         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2107         (write_var_or_type): Use obstack_strndup.
2108
2109 2019-08-06  Tom Tromey  <tom@tromey.com>
2110
2111         * symfile.c (reread_symbols): Use obstack_strdup.
2112         * stabsread.c (read_type): Use obstack_strdup.
2113         * gdb_obstack.h (obstack_strdup): New overload.
2114         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2115         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2116         (dwarf2_canonicalize_name): Use obstack_strdup.
2117         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2118         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2119         Use obstack_strdup.
2120
2121 2019-08-06  Tom Tromey  <tom@tromey.com>
2122
2123         * gdb_obstack.h (obstack_strdup): Define.
2124         * gdb_obstack.c (obstack_strdup): Don't define.
2125
2126 2019-08-06  Tom Tromey  <tom@tromey.com>
2127
2128         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2129         obstack_strdup.
2130         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2131         obstack_strdup.
2132         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2133         * stabsread.c (common_block_start): Use obstack_strdup.
2134         * objfiles.c (set_objfile_main_name, objfile): Use
2135         obstack_strdup.
2136         * namespace.c (add_using_directive): Use obstack_strdup.
2137         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2138         * jit.c (finalize_symtab): Use obstack_strdup.
2139         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2140         (guess_partial_die_structure_name, partial_die_info::fixup)
2141         (dwarf2_name): Use obstack_strdup.
2142         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2143         obstack_strdup.
2144         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2145         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2146         obstack_strdup.
2147         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2148
2149 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2150
2151         * unittests/help-doc-selftests.c: New file.
2152         * Makefile.in: Add the new file.
2153
2154 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2155
2156         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2157         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2158         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2159         the trailing '.' is not output, and the first character is uppercased.
2160         (print_help_for_command): Update call to print_doc_line.
2161         (print_doc_of_command): Likewise.
2162         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2163         * cli/cli-option.c (append_indented_doc): Do not append newline.
2164         (build_help_option): Append newline after first appended_indented_doc
2165         only if a second call is done.
2166         (build_help): Append 2 new lines before each option, except the first
2167         one.
2168         * compile/compile.c (_initialize_compile): Add new lines after
2169         %OPTIONS%, when not at the end of the help.
2170         Change help doc or code
2171         producing the help doc to respect the invariants.
2172         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2173         Also removed the new line after 'Options:', as all other commands
2174         do not put an empty line between 'Options:' and the first option.
2175         * printcmd.c (_initialize_printcmd): Likewise.
2176         * stack.c (_initialize_stack): Likewise.
2177         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2178         incorrectly telling COMMAND is optional.
2179         * ada-lang.c (_initialize_ada_language): Change help doc or code
2180         producing the help doc to respect the invariants.
2181         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2182         * breakpoint.c (_initialize_breakpoint): Likewise.
2183         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2184         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2185         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2186         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2187         _initialize_cli_style): Likewise.
2188         * corelow.c (core_target_info): Likewise.
2189         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2190         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2191         * filesystem.c (_initialize_filesystem): Likewise.
2192         * frame.c (_initialize_frame): Likewise.
2193         * gnu-nat.c (add_task_commands): Likewise.
2194         * infcall.c (_initialize_infcall): Likewise.
2195         * infcmd.c (_initialize_infcmd): Likewise.
2196         * interps.c (_initialize_interpreter): Likewise.
2197         * language.c (_initialize_language): Likewise.
2198         * linux-fork.c (_initialize_linux_fork): Likewise.
2199         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2200         * maint.c (_initialize_maint_cmds): Likewise.
2201         * memattr.c (_initialize_mem): Likewise.
2202         * printcmd.c (_initialize_printcmd): Likewise.
2203         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2204         _RegEx): Likewise.
2205         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2206         * record-btrace.c (_initialize_record_btrace): Likewise.
2207         * record-full.c (_initialize_record_full): Likewise.
2208         * record.c (_initialize_record): Likewise.
2209         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2210         * regcache.c (_initialize_regcache): Likewise.
2211         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2212         _initialize_remote): Likewise.
2213         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2214         * serial.c (_initialize_serial): Likewise.
2215         * skip.c (_initialize_step_skip): Likewise.
2216         * source.c (_initialize_source): Likewise.
2217         * stack.c (_initialize_stack): Likewise.
2218         * symfile.c (_initialize_symfile): Likewise.
2219         * symtab.c (_initialize_symtab): Likewise.
2220         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2221         * top.c (init_main): Likewise.
2222         * tracefile-tfile.c (tfile_target_info): Likewise.
2223         * tracepoint.c (_initialize_tracepoint): Likewise.
2224         * tui/tui-win.c (_initialize_tui_win): Likewise.
2225         * utils.c (add_internal_problem_command): Likewise.
2226         * valprint.c (value_print_option_defs): Likewise.
2227
2228 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2229
2230         PR build/24886
2231         * configure.ac: Drop enable-libmcheck support.
2232         * configure, config.in: Rebuild.
2233         * libmcheck.m4: Remove.
2234         * acinclude.m4: Don't include it.
2235         * Makefile.in: Don't distribute it.
2236         * top.c (print_gdb_configuration): Don't mention it.
2237
2238 2019-08-06  Tom Tromey  <tom@tromey.com>
2239
2240         * utils.c (set_output_style): Sometimes pass stream to
2241         emit_style_escape.
2242         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2243         * record-btrace.c (btrace_insn_history): Update.
2244         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2245         method.
2246         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2247         Update initializers.
2248         <m_uiout>: New field.
2249         <m_di>: Move lower.
2250         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2251         Remove "uiout" parameter.
2252         (dump_insns): Update.
2253         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2254         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2255
2256 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2257
2258         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2259         (error_in_psymtab_expansion): Likewise.
2260         (lookup_symbol_via_quick_fns): Likewise.
2261         (basic_lookup_transparent_type_quick): Likewise.
2262         (basic_lookup_transparent_type_1): Likewise.
2263
2264 2019-08-06  Tom Tromey  <tromey@adacore.com>
2265
2266         * source.c (last_source_error): Now bool.
2267         (print_source_lines_base): Make "noprint" bool.  Only open
2268         source file when last_source_visited changes.
2269
2270 2019-08-06  Tom Tromey  <tromey@adacore.com>
2271
2272         * annotate.c (annotate_source_line): Use g_source_cache.
2273         * source-cache.c (source_cache::get_plain_source_lines): Change
2274         parameters.  Populate m_offset_cache.
2275         (source_cache::ensure): New method.
2276         (source_cache::get_line_charpos): New method.
2277         (extract_lines): Move lower.  Change parameters.
2278         (source_cache::get_source_lines): Move lower.
2279         * source-cache.h (class source_cache): Update comment.
2280         <get_line_charpos>: New method.
2281         <get_source_lines>: Update comment.
2282         <clear>: Clear m_offset_cache.
2283         <get_plain_source_lines>: Change parameters.
2284         <ensure>: New method
2285         <m_offset_cache>: New member.
2286         * source.c (forget_cached_source_info_for_objfile): Update.
2287         (info_source_command): Use g_source_cache.
2288         (find_source_lines, open_source_file_with_line_charpos): Remove.
2289         (print_source_lines_base, search_command_helper): Use g_source_cache.
2290         * source.h (open_source_file_with_line_charpos): Don't declare.
2291         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2292         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2293         Use g_source_cache.
2294
2295 2019-08-06  Tom Tromey  <tromey@adacore.com>
2296
2297         * source-cache.c (source_cache::get_plain_source_lines):
2298         Remove "first_line" and "last_line" parameters.
2299         (source_cache::get_source_lines): Cache plain text.
2300         * source-cache.h (class source_cache)
2301         <get_plain_source_lines>: Update.
2302
2303 2019-08-06  Tom Tromey  <tromey@adacore.com>
2304
2305         * source-cache.c (extract_lines): No longer a method.
2306         Changed type of parameter.  Include final newline.
2307         (selftests::extract_lines_test): New function.
2308         (_initialize_source_cache): Likewise.
2309         * source-cache.h (class source_cache)
2310         <extract_lines>: Don't declare.
2311
2312 2019-08-06  Tom Tromey  <tromey@adacore.com>
2313
2314         * breakpoint.c (init_breakpoint_sal): Update.
2315         (breakpoint): Update.
2316         * breakpoint.h (struct breakpoint) <filter>: Now a
2317         unique_xmalloc_ptr.
2318
2319 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2320
2321         * NEWS: Mention dictionary access on blocks.
2322         * python/py-block.c (blpy_getitem): New function.
2323         (block_object_as_mapping): New struct.
2324         (block_object_type): Use new struct for tp_as_mapping field.
2325
2326 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2327
2328         * objfiles.h (objfile): Add a comment describing partial symbols.
2329
2330 2019-08-05  Tom Tromey  <tromey@adacore.com>
2331
2332         * compile/compile.c (_initialize_compile): Use _(), not N_().
2333         * thread.c (_initialize_thread): Use _(), not N_().
2334         * stack.c (_initialize_stack): Use _(), not N_().
2335         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2336
2337 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2338
2339         * dwarf2read.c (struct dw2_symtab_iterator):
2340         <want_specific_block>: Remove.
2341         <block_index>: Change type to gdb::optional.
2342         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2343         change type of BLOCK_INDEX parameter to gdb::optional.
2344         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2345         (dw2_lookup_symbol): Don't pass argument for
2346         WANT_SPECIFIC_BLOCK.
2347         (dw2_expand_symtabs_for_function): Don't pass argument for
2348         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2349         (class dw2_debug_names_iterator)
2350         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2351         parameter, change BLOCK_INDEX type to gdb::optional.
2352         <m_want_specific_block>: Remove.
2353         <m_block_index>: Change type to gdb::optional.
2354         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2355         gdb::optional.  Re-write in function of gdb::optional.
2356         (dw2_debug_names_lookup_symbol): Don't pass argument for
2357         WANT_SPECIFIC_BLOCK.
2358         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2359         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2360         BLOCK_INDEX.
2361
2362 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2363
2364         * NEWS: Mention changes to "info sources" command.
2365
2366 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2367
2368         * symtab.c (filename_partial_match_opts): New struct type.
2369         (struct output_source_filename_data): New members
2370         regexp, c_regexp, partial_match.
2371         (output_source_filename): Use new members to decide to print file.
2372         (info_sources_option_defs): New variable.
2373         (make_info_sources_options_def_group, print_info_sources_header,
2374         info_sources_command_completer):
2375         New functions.
2376         (info_sources_command): Read new optional arguments.
2377         (_initialize_symtab): Update info sources help.
2378
2379 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2380
2381         * ada-lang.c (exception_support_info_v0): Renamed from...
2382         (default_exception_support_info): ... this.  Create new
2383         definition for v1.
2384         (ada_has_this_exception_support): Look up catch_handlers_sym.
2385         (ada_exception_support_info_sniffer): Try v0 after default.
2386
2387 2019-08-01  Tom Tromey  <tromey@adacore.com>
2388
2389         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2390         gdbarch.h.
2391
2392 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2393
2394         * s12z-tdep.c: Fix include path for s12z-opc.h.
2395
2396 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2397
2398         * NEWS: Require GNU make 3.82.
2399
2400 2019-07-16  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2403         declare.
2404
2405 2019-07-30  Tom Tromey  <tromey@adacore.com>
2406
2407         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2408
2409 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2410
2411         * printcmd.c (print_address_symbolic): Print negative offsets.
2412         (build_address_symbolic): Force signed arithmetic when computing
2413         offset.
2414
2415 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2416
2417         PR/24474: Add a function to lookup static variables.
2418         * NEWS: Mention this new function.
2419         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2420         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2421         * python/python.c (python_GdbMethods): Add new function.
2422
2423 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2424
2425         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2426         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2427         (objfpy_lookup_static_symbol): New function.
2428         (objfile_object_methods): Add new functions.
2429
2430 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2431
2432         * NEWS: Mention 'set|show print frame-info'.  Mention new
2433         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2434         backtrace argument.  Mention that python frame filtering code
2435         is now consistent with what 'backtrace' command prints.
2436
2437 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2438
2439         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2440         comments.
2441         (print_frame_info_auto, print_frame_info_source_line,
2442         print_frame_info_location, print_frame_info_source_and_location,
2443         print_frame_info_location_and_address, print_frame_info_short_location):
2444         New declarations.
2445         (struct frame_print_options): New member print_frame_info.
2446         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2447         * stack.h (get_user_print_what_frame_info): New declaration.
2448         (frame_show_address): New declaration.
2449         * stack.c (print_frame_arguments_choices): New value 'presence'.
2450         (print_frame_info_auto, print_frame_info_source_line,
2451         print_frame_info_location, print_frame_info_source_and_location,
2452         print_frame_info_location_and_address, print_frame_info_short_location,
2453         print_frame_info_choices, print_frame_info_print_what): New definitions.
2454         (print_frame_args): Only print dots for args if print frame-arguments
2455         is 'presence'.
2456         (frame_print_option_defs): New element for "frame-info".
2457         (get_user_print_what_frame_info): New function.
2458         (frame_show_address): Make non static.  Move comment to stack.h.
2459         (print_frame_info_to_print_what): New function.
2460         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2461         to decide what to print.
2462         (backtrace_command_1): Handle the new print_frame_arguments_presence
2463         value.
2464         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2465         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2466         (py_print_frame): In non-mi mode, use LOCATION as default for
2467         print_what, similarly to frame information printed directly by
2468         backtrace command. Handle frame-info user option in non MI mode.
2469
2470 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2471
2472         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2473         Add case for debugging 32-bit target on 64-bit host.  Revise
2474         comment.
2475
2476 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2477
2478         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2479         instead of find_function_entry_range_from_pc.
2480
2481 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2482
2483         * stack.c (find_frame_funname): Remove code which preferred
2484         minsym over symtab sym in "certain pathological cases".
2485
2486         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2487         parameter.  Change type of "do_demangle" to bool.
2488         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2489         Pass suitable "prefer_sym_over_minsym" flag to
2490         build_address_symbolic().  Don't output "+" for negative offsets.
2491         * printcmd.c (print_address_symbolic): Update invocation of
2492         build_address_symbolic to include a "prefer_sym_over_minsym"
2493         flag.
2494         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2495         Restrict cases in which use of minimal symbol is preferred to that
2496         of a found symbol.  Update comments.
2497
2498         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2499         for entry pc when entry pc is out of range for that FDE.
2500
2501 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2502
2503         PR gdb/24839:
2504         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2505         type.
2506
2507 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2508
2509         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2510         this function's Python signature.
2511
2512
2513 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2514
2515         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2516         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2517         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2518         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2519         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2520
2521
2522 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2523
2524         * h8300-tdep.c (h8300_register_name_common): New.
2525         h8300_register_name): Use h8300_register_name_common.
2526         (h8300s_register_name): Likewise.
2527         (h8300sx_register_name): Likewise.
2528         (h8300h_register_nam): New.
2529         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2530
2531
2532 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2533
2534         * arm-tdep.c (arm_skip_cmse_entry): New function.
2535         (arm_is_sgstubs_section): New function.
2536         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2537
2538 2019-07-22  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2541         Don't self-assign.
2542
2543 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2544
2545         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2546         type_print.
2547
2548 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2549
2550         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2551         so that GDB doesn't match any msymbols when searching in the
2552         TYPES_DOMAIN.
2553         (print_symbol_info): Print using typedef_print or type_print based
2554         on the type of the symbol.  Add updated FIXME comment moved from...
2555         (_initialize_symtab): ... move and update FIXME comment to above.
2556
2557 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         * NEWS: Mention adding -q option to "info types".
2560         * symtab.c (struct info_types_options): New struct.
2561         (info_types_options_defs): New variable.
2562         (make_info_types_options_def_group): New function.
2563         (info_types_command): Use gdb::option framework to parse options.
2564         (info_types_command_completer): New function.
2565         (_initialize_symtab): Extend the help text on "info types" and
2566         register command completer.
2567
2568 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2569
2570         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2571         (lookup_symbol_in_objfile): Change int to block_enum and add a
2572         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2573
2574 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2575
2576         * MAINTAINERS (Write After Approval): Add self.
2577
2578 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2581         instruction to the dummy code region.
2582
2583 2019-07-19  Tom Tromey  <tromey@adacore.com>
2584
2585         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2586         (ARGSUSED, PARAMS, __func__): Remove rules.
2587
2588 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2589
2590         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2591         * features/arm/arm-with-iwmmxt.c: Remove.
2592         * features/arm/arm-with-iwmmxt.xml: Remove.
2593         * features/arm/arm-with-m-fpa-layout.c: Remove.
2594         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2595         * features/arm/arm-with-m-vfp-d16.c: Remove.
2596         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2597         * features/arm/arm-with-m.c: Remove.
2598         * features/arm/arm-with-m.xml: Remove.
2599         * features/arm/arm-with-neon.c: Remove.
2600         * features/arm/arm-with-neon.xml: Remove.
2601         * features/arm/arm-with-vfpv2.c: Remove.
2602         * features/arm/arm-with-vfpv2.xml: Remove.
2603         * features/arm/arm-with-vfpv3.c: Remove.
2604         * features/arm/arm-with-vfpv3.xml: Remove.
2605
2606 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2607
2608         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2609
2610 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2611
2612         * arch/aarch32.c (aarch32_create_target_description): Create
2613         target descriptions using features.
2614         * arch/arm.c (arm_create_target_description)
2615         (arm_create_mprofile_target_description): Likewise.
2616         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2617
2618 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2619
2620         * Makefile.in: Add new files.
2621         * aarch32-tdep.c: New file.
2622         * aarch32-tdep.h: New file.
2623         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2624         Call aarch32_read_description.
2625         * arch/aarch32.c: New file.
2626         * arch/aarch32.h: New file.
2627         * arch/arm.c (arm_create_target_description)
2628         (arm_create_mprofile_target_description): New function.
2629         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2630         (arm_create_target_description)
2631         (arm_create_mprofile_target_description): New declaration.
2632         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2633         read_description functions.
2634         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2635         Likewise.
2636         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2637         * arm-tdep.c (tdesc_arm_list): New variable.
2638         (arm_register_g_packet_guesses): Call create description functions.
2639         (arm_read_description) (arm_read_mprofile_description): New
2640         function.
2641         * arm-tdep.h (arm_read_description)
2642         (arm_read_mprofile_description): Add declaration.
2643         * configure.tgt: Add new files.
2644
2645 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2646
2647         * top.c (new_ui_command): Open specified terminal just once.
2648
2649 2019-07-18  Tom Tromey  <tromey@adacore.com>
2650
2651         * symtab.c (main_name): Constify return type.
2652         * symfile.c (set_initial_language): Update.
2653         * symtab.h (main_name): Constify return type.
2654
2655 2019-07-17  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-winsource.c (tui_update_source_window)
2658         (tui_update_source_window_as_is)
2659         (tui_update_source_windows_with_line): Remove return.
2660         * tui/tui-disasm.c (tui_show_disassem)
2661         (tui_show_disassem_and_update_source): Remove return.
2662         * tui/tui.c (tui_reset): Remove return.
2663         * tui/tui-wingeneral.c
2664         (tui_check_and_display_highlight_if_needed): Remove return.
2665
2666 2019-07-17  Tom Tromey  <tom@tromey.com>
2667
2668         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2669
2670 2019-07-17  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-winsource.h (struct tui_exec_info_window)
2673         (struct tui_source_window_base): Move from tui-data.h.
2674         * tui/tui-winsource.c: Move many method definitions from
2675         elsewhere.  Remove "structuring" comments.
2676         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2677         (tui_source_window_base::refresh_window): Move to
2678         tui-winsource.c.
2679         * tui/tui-win.c (tui_source_window_base::refresh_all)
2680         (tui_source_window_base::update_tab_width)
2681         (tui_source_window_base::set_new_height)
2682         (tui_source_window_base::do_make_visible_with_new_height): Move to
2683         tui-winsource.c.
2684         * tui/tui-source.h: Update.
2685         * tui/tui-source.c (tui_source_window_base::reset): Move to
2686         tui-winsource.c.
2687         * tui/tui-disasm.h: Update.
2688         * tui/tui-data.h (struct tui_exec_info_window): Move to
2689         tui-winsource.h.
2690         (struct tui_source_window_base): Likewise.
2691         * tui/tui-data.c (tui_source_window_base::clear_detail)
2692         (tui_source_window_base, ~tui_source_window_base): Move to
2693         tui-winsource.c.
2694
2695 2019-07-17  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-win.c (tui_resize_all)
2698         (tui_source_window_base::update_tab_width)
2699         (tui_adjust_win_heights): Update.
2700         (tui_win_info::make_invisible_and_set_new_height): Rename from
2701         make_invisible_and_set_new_height.
2702         * tui/tui-data.h (struct tui_win_info)
2703         <make_invisible_and_set_new_height>: New method.
2704
2705 2019-07-17  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui.c: Update.
2708         * tui/tui-source.h (struct tui_source_window): Move from
2709         tui-data.h.
2710         * tui/tui-layout.c: Update.
2711         * tui/tui-disasm.c: Update.
2712         * tui/tui-data.h (struct tui_source_window): Move to
2713         tui-source.h.
2714
2715 2019-07-17  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2718         tui-data.h.
2719         * tui/tui-data.h (struct tui_disasm_window): Move to
2720         tui-disasm.h.
2721
2722 2019-07-17  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-regs.h (struct tui_data_item_window): Move from
2725         tui-data.h.
2726         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2727         * tui/tui-data.h (struct tui_data_item_window): Move to
2728         tui-regs.h.
2729         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2730
2731 2019-07-17  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui.c: Update.
2734         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2735         (tui_cmd_window::max_height): Move to tui-command.c.
2736         * tui/tui-layout.c: Update.
2737         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2738         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2739         tui-command.c.
2740         * tui/tui-command.h (struct tui_cmd_window): Move from
2741         tui-data.h.
2742         * tui/tui-command.c: Remove "structuring" comments.
2743         (tui_cmd_window::clear_detail)
2744         (tui_cmd_window::do_make_visible_with_new_height)
2745         (tui_cmd_window::max_height): Move from elsewhere.
2746
2747 2019-07-17  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2750         Now static.
2751         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2752         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2753
2754 2019-07-17  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui.c: Update.
2757         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2758         tui-regs.c.
2759         * tui/tui-windata.h: Remove file.
2760         * tui/tui-windata.c: Remove file.
2761         * tui/tui-win.c (tui_data_window::set_new_height)
2762         (tui_data_window::do_make_visible_with_new_height): Move to
2763         tui-regs.c.
2764         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2765         * tui/tui-regs.c: Remove "structuring" comments.
2766         (tui_data_window::first_data_item_displayed)
2767         (tui_data_window::delete_data_content_windows)
2768         (tui_data_window::erase_data_content)
2769         (tui_data_window::display_all_data)
2770         (tui_data_window::refresh_all)
2771         (tui_data_window::do_scroll_vertical)
2772         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2773         (tui_data_window::do_make_visible_with_new_height)
2774         (tui_data_window::refresh_window): Move from elsewhere.
2775         (_initialize_tui_regs): Move to end of file.
2776         * tui/tui-layout.c: Update.
2777         * tui/tui-hooks.c: Update.
2778         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2779         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2780         tui-regs.c.
2781         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2782
2783 2019-07-17  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2786         seen.
2787
2788 2019-07-17  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-win.c (tui_source_window_base::set_new_height)
2791         (tui_source_window_base::do_make_visible_with_new_height): Use
2792         m_has_locator field directly.
2793         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2794         method.
2795         (struct tui_source_window_base) <has_locator>: Likewise.
2796
2797 2019-07-17  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2800         Don't declare.
2801         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2802         Remove.
2803         * tui/tui-win.c (tui_source_window_base::set_new_height)
2804         (tui_source_window_base::set_new_height)
2805         (make_invisible_and_set_new_height)
2806         (tui_source_window_base::do_make_visible_with_new_height)
2807         (tui_source_window_base::do_make_visible_with_new_height):
2808         Update.
2809         * tui/tui-layout.c (show_source_disasm_command, show_data)
2810         (show_source_or_disasm_and_command): Update.
2811         * tui/tui-layout.c (show_layout): Update.
2812
2813 2019-07-17  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-layout.c (make_data_window): Remove.
2816         (show_data): Unify creation and re-initialization cases.
2817
2818 2019-07-17  Tom Tromey  <tom@tromey.com>
2819
2820         * tui/tui-layout.c (make_source_window, make_disasm_window):
2821         Remove.
2822         (show_data): Unify creation and re-initialization cases.
2823
2824 2019-07-17  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-layout.c (make_command_window): Remove.
2827         (show_source_disasm_command, show_source_or_disasm_and_command):
2828         Unify creation and re-initialization cases.
2829
2830 2019-07-17  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2833         creation and re-initialization cases.
2834
2835 2019-07-17  Tom Tromey  <tom@tromey.com>
2836
2837         * tui/tui-regs.c (tui_get_register): Return void.
2838
2839 2019-07-17  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2842         Simplify.
2843
2844 2019-07-17  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2847         resetting.
2848
2849 2019-07-17  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2852         * tui/tui-regs.c (tui_reg_layout): New function.
2853         (tui_show_registers, tui_reg_command): Use it.
2854         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2855         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2856         parameters.
2857         (tui_layout_command): Remove.
2858
2859 2019-07-17  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-layout.h (tui/tui-layout): Return void.
2862         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2863
2864 2019-07-17  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-layout.c (show_source_disasm_command, show_data):
2867         Update.
2868         (reset_locator): Remove.
2869         (show_source_or_disasm_and_command): Update.
2870
2871 2019-07-17  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-source.c (tui_source_window_base::reset): Remove
2874         win_type parameter.
2875         * tui/tui-layout.c (make_command_window, make_source_window)
2876         (make_disasm_window, make_data_window)
2877         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2878         (reset_locator, show_source_or_disasm_and_command): Update.
2879         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2880         win_type parameter.
2881         (struct tui_source_window_base) <reset>: Likewise.
2882
2883 2019-07-17  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-layout.c (show_source_disasm_command): Use
2886         reset_locator.
2887         (reset_locator): New function.
2888         (init_and_make_win): Remove.
2889         (show_source_or_disasm_and_command): Use reset_locator.
2890
2891 2019-07-17  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2894         condition.
2895         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2896         Remove condition.
2897         * tui/tui-source.c (tui_source_window_base::reset): New method.
2898         * tui/tui-layout.c (make_command_window): Don't call
2899         init_and_make_win.
2900         (make_source_window, make_disasm_window): Don't call
2901         make_source_or_disasm_window.
2902         (make_data_window): Don't call init_and_make_win.  Change calling
2903         convention.
2904         (show_source_disasm_command, show_data): Simplify.
2905         (make_source_or_disasm_window): Remove.
2906         (show_source_or_disasm_and_command): Simplify.
2907         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2908         (struct tui_source_window_base) <reset>: Likewise.
2909         <execution_info>: Remove initializer.
2910         * tui/tui-data.c (tui_source_window_base): Initialize
2911         execution_info.
2912
2913 2019-07-17  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2916         variable.
2917
2918 2019-07-17  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui.c (tui_rl_other_window): Update.
2921         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2922         superclass method first.  Always iterate over regs_content.
2923         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2924         method.
2925         * tui/tui-win.c (tui_set_focus_command): Update.
2926
2927 2019-07-17  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-win.c (tui_set_focus_command): Rename from
2930         tui_set_focus.  Call tui_enable.
2931         (tui_set_focus_command): Remove.
2932
2933 2019-07-17  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2936         refresh_window.
2937         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2938         touchwin.
2939         (tui_data_window::refresh_window): Call refresh_window on data
2940         items.  Always call superclass refresh_window.
2941         (tui_win_info::refresh): Remove.
2942         (tui_source_window_base::refresh_window): Update.
2943         (tui_refresh_all): Update.
2944         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2945         refresh_window.
2946         (show_source_or_disasm_and_command): Likewise.
2947         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2948         (struct tui_source_window_base) <refresh>: Likewise.
2949
2950 2019-07-17  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-winsource.c (tui_clear_source_content)
2953         (tui_show_source_content): Update.
2954         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2955         whether content is empty.
2956         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2957         Remove.
2958
2959 2019-07-17  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2962         window's contents.
2963         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2964         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2965
2966 2019-07-17  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2969         (struct tui_data_item_window): Update.
2970
2971 2019-07-17  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2974         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2975         defines.
2976
2977 2019-07-17  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-winsource.h (tui_erase_source_content)
2980         (tui_clear_source_content): Remove "display_prompt" parameter.
2981         * tui/tui-winsource.c (tui_update_source_window_as_is)
2982         (tui_update_source_windows_with_addr): Update.
2983         (tui_clear_source_content): Remove "display_prompt" parameter.
2984         (tui_erase_source_content): Likewise.  Simplify.
2985         (tui_show_source_content): Update.
2986         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2987         * tui/tui-stack.c (tui_show_frame_info): Update.
2988         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2989         Remove defines.
2990
2991 2019-07-17  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2994         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2995         parameter.
2996         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2997         parameter.
2998
2999 2019-07-17  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui-winsource.c (tui_clear_source_content)
3002         (tui_show_source_content, tui_show_exec_info_content)
3003         (tui_clear_exec_info_content): Update.
3004         * tui/tui-stack.c (tui_show_locator_content): Update.
3005         (tui_show_frame_info): Update.
3006         * tui/tui-source.h (tui_source_window): Don't declare.
3007         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3008         from tui_source_is_displayed.
3009         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3010         Remove field.
3011         (struct tui_source_window_base) <content_in_use>: New field.  Now
3012         bool.
3013         (struct tui_source_window) <showing_source_p>: New method.
3014         (TUI_SRC_WIN): Change cast.
3015         * tui/tui-data.c (tui_initialize_static_data): Update.
3016
3017 2019-07-17  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3020         location_matches_p.
3021         * tui/tui-source.c (tui_source_window::location_matches_p): New
3022         method.
3023         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3024         method.
3025         * tui/tui-data.h (struct tui_source_window_base)
3026         <location_matches_p>: New method.
3027         (struct tui_source_window, struct tui_disasm_window)
3028         <location_matches_p>: Likewise.
3029
3030 2019-07-17  Tom Tromey  <tom@tromey.com>
3031
3032         * tui/tui-win.c (tui_set_win_height_command): Rename from
3033         tui_set_win_height.
3034         (tui_set_win_height_command): Remove.
3035
3036 2019-07-17  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-source.c (tui_source_window): New constructor.  Add
3039         observer.
3040         (~tui_source_window): New destructor.
3041         (tui_source_window::style_changed): New method.
3042         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3043         (tui_attach_detach_observers): Update.
3044         * tui/tui-data.h (struct tui_source_window): Make constructor not
3045         inline.  Add destructor.
3046         (struct tui_source_window) <style_changed>: New method.
3047         <m_observable>: New member.
3048
3049 2019-07-17  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3052         * tui/tui-win.c (tui_resize_all): Fix typo.
3053
3054 2019-07-17  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3057         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3058         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3059         * tui/tui-win.c (window_name_completer): Use foreach.
3060         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3061         (update_tab_width): Likewise.
3062         * tui/tui-layout.c (show_layout): Update.
3063         * tui/tui-data.h (class tui_window_iterator): New.
3064         (struct all_tui_windows): New.
3065         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3066
3067 2019-07-17  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3070         parameter.  Don't reference globals.
3071         (tui_reg_command): Update.
3072
3073 2019-07-17  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-regs.c (tui_show_registers): Simplify.
3076
3077 2019-07-17  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-regs.c (tui_show_registers): Update.
3080         (tui_show_register_group): Add win_info parameter.
3081
3082 2019-07-17  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3085         Rename from tui_display_reg_element_at_line.
3086         (tui_data_window::display_registers_from_line): Update.
3087         * tui/tui-data.h (struct tui_data_window)
3088         <display_reg_element_at_line>: New method.
3089
3090 2019-07-17  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-regs.h (tui_display_registers_from)
3093         (tui_display_registers_from_line): Don't declare.
3094         * tui/tui-windata.c (tui_data_window::display_all_data)
3095         (tui_data_window::refresh_all)
3096         (tui_data_window::do_scroll_vertical): Update.
3097         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3098         from tui_display_registers_from.
3099         (tui_display_reg_element_at_line): Update.
3100         (tui_data_window::display_registers_from_line): Rename from
3101         tui_display_registers_from_line.
3102         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3103         display_registers_from_line>: New methods.
3104
3105 2019-07-17  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3108         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3109         from tui_erase_data_content.
3110         (tui_data_window::display_all_data)
3111         (tui_data_window::refresh_all)
3112         (tui_data_window::do_scroll_vertical): Update.
3113         * tui/tui-regs.c (tui_show_registers): Update.
3114         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3115         New method.
3116
3117 2019-07-17  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3120         declare.
3121         * tui/tui-windata.c
3122         (tui_data_window::delete_data_content_windows): Rename from
3123         tui_delete_data_content_windows.
3124         (tui_data_window::display_all_data)
3125         (tui_data_window::do_scroll_vertical): Update.
3126         * tui/tui-data.h (struct tui_data_window)
3127         <delete_data_content_windows>: New method.
3128
3129 2019-07-17  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3132         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3133
3134 2019-07-17  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3137         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3138         from tui_display_all_data.
3139         * tui/tui-win.c
3140         (tui_data_window::do_make_visible_with_new_height): Update.
3141         * tui/tui-regs.c (tui_show_registers): Update.
3142         * tui/tui-layout.c (tui_set_layout): Update.
3143         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3144         method.
3145
3146 2019-07-17  Tom Tromey  <tom@tromey.com>
3147
3148         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3149         * tui/tui-windata.c (tui_display_data_from): Remove.
3150         (tui_data_window::refresh_all): Update.
3151
3152 2019-07-17  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3155         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3156         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3157         tui_display_registers_from_line.
3158         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3159         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3160         "force_display" parameter.
3161
3162 2019-07-17  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3165         declare.
3166         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3167         Rename from tui_first_reg_element_no_inline.
3168         (tui_display_reg_element_at_line)
3169         (tui_display_registers_from_line): Update.
3170         * tui/tui-data.h (struct tui_data_window)
3171         <first_reg_element_no_inline>: New method.
3172
3173 2019-07-17  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-windata.c (tui_display_data_from)
3176         (tui_data_window::do_scroll_vertical): Update.
3177         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3178         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3179         Rename from tui_line_from_reg_element_no.
3180         (tui_display_registers_from_line): Update.
3181         * tui/tui-data.h (struct tui_data_window)
3182         <line_from_reg_element_no>: New method.
3183
3184 2019-07-17  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3187         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3188         tui_last_regs_line_no.
3189         (tui_display_reg_element_at_line)
3190         (tui_display_registers_from_line): Update.
3191         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3192         method.
3193
3194 2019-07-17  Tom Tromey  <tom@tromey.com>
3195
3196         PR tui/24722:
3197         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3198         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3199         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3200         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3201         (tui_update_breakpoint_info): Likewise.
3202         * tui/tui-hooks.c (tui_event_create_breakpoint)
3203         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3204         Update.
3205
3206 2019-07-17  Tom Tromey  <tom@tromey.com>
3207
3208         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3209
3210 2019-07-17  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-winsource.c (tui_update_source_window_as_is)
3213         (tui_update_source_windows_with_addr): Update.
3214         * tui/tui-source.h (tui_set_source_content)
3215         (tui_show_symtab_source): Add "win_info" parameter.
3216         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3217         parameter.
3218         (tui_show_symtab_source): Likewise.
3219
3220 2019-07-17  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-wingeneral.c
3223         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3224
3225 2019-07-17  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3228         (struct tui_cmd_window) <can_scroll>: New method.
3229         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3230         method.
3231
3232 2019-07-17  Tom Tromey  <tromey@adacore.com>
3233
3234         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3235         do_field_signed>: Rename.  Change type of "value".
3236         * ui-out.c (ui_out::field_signed): Rename from field_int.
3237         Change type of "value".
3238         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3239         type of "value".
3240         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3241         do_field_int.  Change type of "value".
3242         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3243         do_field_int.  Change type of "value".
3244         * tracepoint.c (trace_status_mi, tfind_1)
3245         (print_one_static_tracepoint_marker): Update.
3246         * thread.c (print_thread_info_1, print_selected_thread_frame):
3247         Update.
3248         * stack.c (print_frame, print_frame_info): Update.
3249         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3250         Update.
3251         * source.c (print_source_lines_base): Update.
3252         * skip.c (info_skip_command): Update.
3253         * record-btrace.c (btrace_ui_out_decode_error)
3254         (btrace_call_history_src_line): Update.
3255         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3256         Update.
3257         * progspace.c (print_program_space): Update.
3258         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3259         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3260         do_field_int.  Change type of "value".
3261         * mi/mi-out.c (mi_ui_out::do_table_begin)
3262         (mi_ui_out::do_table_header): Update.
3263         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3264         type of "value".
3265         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3266         (mi_cmd_data_list_changed_registers, output_register)
3267         (mi_cmd_data_read_memory, mi_load_progress)
3268         (mi_cmd_trace_frame_collected): Update.
3269         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3270         Update.
3271         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3272         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3273         (mi_cmd_var_list_children, varobj_update_one): Update.
3274         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3275         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3276         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3277         * inferior.c (print_inferior): Update.
3278         * gdb_bfd.c (print_one_bfd): Update.
3279         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3280         Update.
3281         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3282         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3283         do_field_int.  Change type of "value".
3284         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3285         do_field_int.  Change type of "value".
3286         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3287         (print_one_breakpoint_location, print_it_catch_fork)
3288         (print_one_catch_fork, print_it_catch_vfork)
3289         (print_one_catch_vfork, print_it_catch_solib)
3290         (print_it_catch_exec, print_it_ranged_breakpoint)
3291         (print_mention_watchpoint, print_mention_masked_watchpoint)
3292         (bkpt_print_it, update_static_tracepoint): Update.
3293         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3294         * break-catch-syscall.c (print_it_catch_syscall): Update.
3295         * ada-tasks.c (print_ada_task_info): Update.
3296         * ada-lang.c (print_it_exception, print_mention_exception):
3297         Update.
3298
3299 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3300
3301         PR breakpoints/24541
3302         * gdbarch.c: Regenerate.
3303         * gdbarch.h: Regenerate.
3304         * gdbarch.sh: Adjust return type and parameter types for
3305         'stap_adjust_register'.
3306         (i386_stap_adjust_register): Adjust signature and return new
3307         register name.
3308         * stap-probe.c (stap_parse_register_operand): Adjust use of
3309         'gdbarch_stap_adjust_register'.
3310
3311 2019-07-17  Tom Tromey  <tromey@adacore.com>
3312
3313         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3314         declare VEC.
3315         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3316         std::vector.
3317         (struct s390_process_info): Add initializers.
3318         (s390_add_process): Use new.
3319         (s390_linux_nat_target::low_forget_process): Use delete.
3320         (s390_linux_nat_target::low_new_fork)
3321         (s390_linux_nat_target::stopped_by_watchpoint)
3322         (s390_linux_nat_target::low_prepare_to_resume)
3323         (s390_linux_nat_target::insert_watchpoint)
3324         (s390_linux_nat_target::insert_hw_breakpoint)
3325         (s390_linux_nat_target::remove_watchpoint)
3326         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3327
3328 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3329
3330         * aarch64-fbsd-nat.c: Include regcache.h.
3331         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3332         argument.
3333         (aarch64_fbsd_nat_target::fetch_registers)
3334         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3335         variable.
3336         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3337
3338 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3339
3340         * fbsd-nat.c: Include gdbarch.h.
3341
3342 2019-07-15  Tom Tromey  <tromey@adacore.com>
3343
3344         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3345
3346 2019-07-15  Tom Tromey  <tromey@adacore.com>
3347
3348         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3349         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3350         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3351         * cli-out.c (cli_ui_out::do_field_int): New method.
3352         * ui-out.c (ui_out::field_unsigned): New method.
3353         * symfile.c (generic_load): Use field_unsigned.
3354         (print_transfer_performance): Likewise.
3355         * record-btrace.c (ui_out_field_uint): Remove.
3356         (btrace_call_history_insn_range, btrace_call_history): Use
3357         field_unsigned.
3358         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3359         field_unsigned.
3360         * ui-out.h (class ui_out) <field_unsigned>: New method.
3361         <do_field_unsigned>: Likewise.
3362
3363 2019-07-15  Tom Tromey  <tromey@adacore.com>
3364
3365         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3366         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3367         * target.c (flash_erase_command): Use field_string.
3368         * infrun.c (print_signal_received_reason): Use field_string.
3369         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3370         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3371         field_string.
3372         * ada-tasks.c (print_ada_task_info): Use field_string.
3373
3374 2019-07-15  Tom Tromey  <tromey@adacore.com>
3375
3376         * target.c (flash_erase_command): Use field_core_addr.
3377         * symfile.c (generic_load): Use field_core_addr.
3378         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3379         Use field_core_addr.
3380         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3381         field_core_addr.
3382
3383 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3386         value if its desired type is smaller than a CORE_ADDR and signed.
3387
3388 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3389
3390         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3391         of changes to field names, and use new is_reference field to
3392         decide if a property is a reference or not.
3393         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3394         field.
3395         (struct dwarf2_property_baton): Update header comment, rename
3396         'referenced_type' to 'property_type' and update comments.
3397         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3398         default property type, store in property baton, update to take
3399         accound of renamed field.
3400         (read_func_scope): Update call to attr_to_dynamic_prop.
3401         (read_array_type): Likewise.
3402         (dwarf2_per_cu_addr_sized_int_type): New function.
3403         (read_subrange_index_type): Move type finding code to
3404         dwarf2_per_cu_addr_sized_int_type.
3405         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3406         (dwarf2_per_cu_addr_type): New function.
3407         (set_die_type): Update calls to attr_to_dynamic_prop.
3408
3409 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3410
3411         * dwarf2read.c (read_subrange_index_type): New function.
3412         (read_subrange_type): Move code into new function and call it.
3413         * gdbtypes.c (create_range_type): Add some asserts.
3414
3415 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3416
3417         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3418         update return statements.
3419         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3420         declaration, and update comment to match.
3421         * gdbtypes.c (resolve_dynamic_array): Update call to
3422         dwarf2_evaluate_property to match new return type.
3423
3424 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3425
3426         * valarith.c (value_subscripted_rvalue): Change lowerbound
3427         parameter type from int to LONGEST.
3428         * value.h (value_subscripted_rvalue): Likewise in declaration.
3429
3430 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * cli/cli-utils.c (info_print_command_completer): New function.
3433         * cli/cli-utils.h: Add 'completer.h' include, and forward
3434         declaration for 'struct cmd_list_element'.
3435         (info_print_command_completer): Declare.
3436         * stack.c (_initialize_stack): Add completer for 'info locals' and
3437         'info args'.
3438         * symtab.c (_initialize_symtab): Add completer for 'info
3439         variables' and 'info functions'.
3440         * NEWS: Mention completion for additional info commands.
3441
3442 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * cli/cli-utils.c (extract_info_print_args): Delete.
3445         (extract_arg_maybe_quoted): Delete.
3446         (info_print_options_defs): New variable.
3447         (make_info_print_options_def_group): New function.
3448         (extract_info_print_options): Define new function.
3449         * cli/cli-utils.h (extract_info_print_args): Delete.
3450         (struct info_print_options): New structure.
3451         (extract_info_print_options): Declare new function.
3452         * stack.c (info_locals_command): Update to use new
3453         extract_info_print_options, also add a header comment.
3454         (info_args_command): Likewise.
3455         * symtab.c (info_variables_command): Likewise.
3456         (info_functions_command): Likewise.
3457
3458 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3459
3460         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3461         to extract string arguments.
3462         * common/common-utils.c (extract_string_maybe_quoted): New function.
3463         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3464
3465 2019-07-11  Tom Tromey  <tromey@adacore.com>
3466
3467         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3468         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3469         * top.h (gdbinit): Don't declare.
3470         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3471         into...
3472         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3473         * top.c (gdb_init): Don't call init_cli_cmds.
3474         (gdbinit): Remove.
3475         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3476
3477 2019-07-11  Tom Tromey  <tromey@adacore.com>
3478
3479         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3480         after it has been moved.
3481
3482 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3483
3484         * valops.c (value_must_coerce_to_target): Change return type to
3485         bool.
3486         * value.h (value_must_coerce_to_target): Likewise.
3487
3488 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3489
3490         * breakpoint.c (is_hardware_watchpoint): Remove
3491         forward-declaration.
3492         (is_masked_watchpoint): Change return type to bool.
3493         (is_tracepoint): Likewise.
3494         (is_breakpoint): Likewise.
3495         (is_hardware_watchpoint): Likewise.
3496         (is_watchpoint): Likewise.
3497         (is_no_memory_software_watchpoint): Likewise.
3498         (is_catchpoint): Likewise.
3499         (breakpoint_1): Make FILTER parameter's return type bool.
3500         is_masked_watchpoint): Change return type to bool.
3501         (save_breakpoints): Make FILTER parameter's return type bool.
3502         * breakpoint.h (is_breakpoint): Change return type to bool.
3503         (is_watchpoint): Likewise.
3504         (is_catchpoint): Likewise.
3505         (is_tracepoint): Likewise.
3506
3507 2019-07-10  Tom Tromey  <tom@tromey.com>
3508
3509         * defs.h: Don't include gdbarch.h.
3510         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3511         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3512         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3513         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3514         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3515         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3516         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3517         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3518         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3519         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3520         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3521         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3522         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3523         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3524         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3525         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3526         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3527         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3528         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3529         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3530         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3531         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3532         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3533         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3534         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3535         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3536         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3537
3538 2019-07-10  Tom Tromey  <tromey@adacore.com>
3539
3540         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3541         * breakpoint.c (init_ada_exception_breakpoint): Register as
3542         bp_catchpoint.
3543         (print_one_breakpoint_location, print_one_breakpoint): Use
3544         is_ada_exception_catchpoint.
3545         * ada-lang.c (class ada_catchpoint_location): Pass
3546         bp_loc_software_breakpoint to bp_location constructor.
3547         (is_ada_exception_catchpoint): New function.
3548
3549 2019-07-10  Tom Tromey  <tromey@adacore.com>
3550
3551         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3552         VEC.
3553         (struct arm_exidx_entry): New method operator<.
3554         (struct arm_exidx_data) <section_maps>: Change type.
3555         (arm_exidx_data_free): Remove.
3556         (arm_exidx_data_key): Change type.  Move lower.
3557         (arm_exidx_new_objfile): Update.
3558         (arm_compare_exidx_entries): Remove.
3559         (arm_find_exidx_entry, _initialize_arm_tdep)
3560
3561 2019-07-10  Tom Tromey  <tromey@adacore.com>
3562
3563         * solib-spu.c (ocl_program_data_key): Change type.
3564         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3565         Update.
3566
3567 2019-07-10  Tom Tromey  <tromey@adacore.com>
3568
3569         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3570         (struct solib_aix_inferior_data) <library_list>: Change type.
3571         (solib_aix_inferior_data_handle): Change type.
3572         (get_solib_aix_inferior_data): Update.
3573         (solib_aix_free_library_list): Remove.
3574         (library_list_start_library): Update.
3575         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3576         return type.
3577         (solib_aix_get_library_list)
3578         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3579         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3580
3581 2019-07-10  Tom Tromey  <tromey@adacore.com>
3582
3583         * solib-dsbt.c (struct dsbt_info): Add initializers.
3584         (solib_dsbt_pspace_data): Change type.
3585         (dsbt_pspace_data_cleanup): Remove.
3586         (get_dsbt_info, _initialize_dsbt_solib): Update.
3587
3588 2019-07-10  Tom Tromey  <tromey@adacore.com>
3589
3590         * spu-tdep.c (spu_overlay_data): Change type.
3591         (spu_get_overlay_table, spu_overlay_new_objfile)
3592         (_initialize_spu_tdep): Update.
3593
3594 2019-07-10  Tom Tromey  <tromey@adacore.com>
3595
3596         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3597         destructor.
3598         (dbx_objfile_data_key): Change type and declare later.
3599         (DBX_SYMFILE_INFO): Rewrite.
3600         * dbxread.c (dbx_objfile_data_key): Change type.
3601         (dbx_symfile_init): Update.
3602         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3603         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3604         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3605
3606 2019-07-10  Tom Tromey  <tromey@adacore.com>
3607
3608         * jit.c (jit_program_space_key): Change type.  Move lower.
3609         (get_jit_program_space_data): Update.
3610         (jit_program_space_data_cleanup): Remove.
3611         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3612         Update.
3613         (struct jit_program_space_data): Add initializers.
3614
3615 2019-07-10  Tom Tromey  <tromey@adacore.com>
3616
3617         * solib-darwin.c (struct darwin_info): Add initializers.
3618         (solib_darwin_pspace_data): Change type.
3619         (darwin_pspace_data_cleanup): Remove.
3620         (get_darwin_info, _initialize_darwin_solib): Update.
3621
3622 2019-07-10  Tom Tromey  <tromey@adacore.com>
3623
3624         * remote-sim.c (struct sim_inferior_data): Add initializers,
3625         constructor, and destructor.
3626         (sim_inferior_data_key): Change type.  Move lower.
3627         (check_for_duplicate_sim_descriptor): Update.
3628         (get_sim_inferior_data): Use new.  Update.
3629         (~sim_inferior_data_cleanup): Rename from
3630         sim_inferior_data_cleanup.  Simplify.
3631         (gdbsim_close_inferior, simulator_command)
3632         (sim_command_completer, _initialize_remote_sim): Update.
3633         (next_pid, INITIAL_PID): Move earlier.
3634
3635 2019-07-10  Tom Tromey  <tromey@adacore.com>
3636
3637         * python/python-internal.h (create_thread_object): Return
3638         gdbpy_ref.
3639         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3640         * python/py-inferior.c (struct threadlist_entry): Add
3641         constructor.
3642         <thread_obj>: Now a gdbpy_ref.
3643         (thread_to_thread_object): Update.
3644         (add_thread_object): Use new.
3645         (delete_thread_object): Use delete.
3646         (infpy_threads): Update.
3647         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3648         GIL.
3649
3650 2019-07-10  Tom Tromey  <tromey@adacore.com>
3651
3652         * valops.c (value_cast): Specialize error message for Ada.
3653
3654 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3655
3656         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3657
3658 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3659
3660         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3661         bpstat_should_step): Return bool, adjust comments.
3662         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3663         bpstat_should_step): Likewise.
3664
3665 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3666
3667         * features/Makefile: Use feature target descriptions for Arm.
3668         * features/arm/arm-core.c: Generate new file.
3669         * features/arm/arm-fpa.c: Likewise.
3670         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3671         * features/arm/arm-m-profile.c: Likewise.
3672         * features/arm/arm-vfpv2.c: Likewise.
3673         * features/arm/arm-vfpv3.c: Likewise.
3674         * features/arm/xscale-iwmmxt.c: Likewise.
3675         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3676
3677 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3678
3679         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3680         ptrace earlier.
3681
3682 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3683
3684         * features/aarch64-pauth.c: Regenerate.
3685
3686 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3687
3688         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3689         bool.
3690         (bpstat_what): Use false instead of 0.
3691
3692 2019-07-09  Pedro Alves  <palves@redhat.com>
3693
3694         * break-catch-throw.c (is_exception_catchpoint): New.
3695         * breakpoint.c (print_one_breakpoint_location): New parameter
3696         'raw_loc'.  Handle it.  Use
3697         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3698         looking at the breakpoint's type.
3699         (print_one_breakpoint): If handling "maint info breakpoints", also
3700         print locations of exception catchpoints.
3701         * breakpoint.h (is_exception_catchpoint): Declare.
3702
3703 2019-07-09  Pedro Alves  <palves@redhat.com>
3704
3705         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3706         "addr" field.
3707         (allocate_location_exception_catchpoint): New.
3708         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3709         (initialize_throw_catchpoint_ops): Install
3710         allocate_location_exception_catchpoint as allocate_location
3711         method.
3712         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3713         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3714         bp_loc_other.
3715         (breakpoint_address_is_meaningful): Delete.
3716         (bl_address_is_meaningful): New.
3717         (breakpoint_locations_match): Adjust comment.
3718         (bp_location_from_bp_type): New, factored out of...
3719         (bp_location::bp_location(breakpoint *)): ... this.
3720         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3721         factored out of...
3722         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3723         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3724         breakpoint_address_is_meaningful.
3725         (bp_locations_compare): Adjust comment.
3726         (update_global_location_list): Use bl_address_is_meaningful
3727         instead of breakpoint_address_is_meaningful.
3728         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3729         explicit.
3730         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3731         * python/py-breakpoint.c (bppy_get_location): No longer check
3732         whether location is null.
3733
3734 2019-07-09  Pedro Alves  <palves@redhat.com>
3735
3736         PR c++/15468
3737         * breakpoint.c (print_one_breakpoint_location): Remove
3738         single-location assert.
3739
3740 2019-07-09  Tom Tromey  <tom@tromey.com>
3741
3742         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3743         * configure: Rebuild.
3744         * configure.ac: Change common to gdbsupport.
3745         * gdbsupport: Rename from common.
3746         * acinclude.m4: Change common to gdbsupport.
3747         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3748         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3749         gdbsupport.
3750         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3751         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3752         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3753         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3754         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3755         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3756         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3757         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3758         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3759         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3760         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3761         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3762         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3763         coff-pe-read.c, command.h, compile/compile-c-support.c,
3764         compile/compile-c.h, compile/compile-cplus-symbols.c,
3765         compile/compile-cplus-types.c, compile/compile-cplus.h,
3766         compile/compile-loc2c.c, compile/compile.c, completer.c,
3767         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3768         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3769         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3770         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3771         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3772         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3773         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3774         features/aarch64-core.c, features/aarch64-fpu.c,
3775         features/aarch64-pauth.c, features/aarch64-sve.c,
3776         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3777         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3778         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3779         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3780         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3781         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3782         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3783         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3784         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3785         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3786         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3787         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3788         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3789         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3790         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3791         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3792         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3793         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3794         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3795         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3796         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3797         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3798         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3799         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3800         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3801         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3802         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3803         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3804         minsyms.c, mips-linux-tdep.c, namespace.h,
3805         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3806         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3807         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3808         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3809         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3810         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3811         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3812         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3813         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3814         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3815         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3816         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3817         procfs.c, producer.c, progspace.h, psymtab.h,
3818         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3819         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3820         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3821         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3822         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3823         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3824         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3825         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3826         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3827         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3828         target-memory.c, target.c, target.h, target/waitstatus.c,
3829         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3830         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3831         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3832         unittests/array-view-selftests.c,
3833         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3834         unittests/common-utils-selftests.c,
3835         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3836         unittests/format_pieces-selftests.c,
3837         unittests/function-view-selftests.c,
3838         unittests/lookup_name_info-selftests.c,
3839         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3840         unittests/mkdir-recursive-selftests.c,
3841         unittests/observable-selftests.c,
3842         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3843         unittests/parse-connection-spec-selftests.c,
3844         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3845         unittests/scoped_fd-selftests.c,
3846         unittests/scoped_mmap-selftests.c,
3847         unittests/scoped_restore-selftests.c,
3848         unittests/string_view-selftests.c, unittests/style-selftests.c,
3849         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3850         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3851         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3852         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3853         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3854         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3855
3856 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3857
3858         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3859         bool value.
3860         (decode_digits_ordinary): Set explicit_line field in sal.
3861         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3862         symtab_and_line that was set on an explicit line number in
3863         assembler code.  Do always update the recorded symtab and line if
3864         we do skip the prologue.
3865
3866 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * breakpoint.c (set_breakpoint_location_function): Remove
3869         explicit_loc parameter.
3870         (momentary_breakpoint_from_master): Update call to
3871         set_breakpoint_location_function.
3872         (add_location_to_breakpoint): Likewise.
3873
3874 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3877         required features based on default bfd type when no specific bfd
3878         is present.
3879
3880 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3881
3882         * NEWS: Mention that GDB printf and eval commands can now print
3883         C-style and Ada-style convenience var strings without
3884         calling the inferior.
3885         * printcmd.c (printf_c_string): Locally print GDB internal var
3886         instead of transiting via the inferior.
3887         (printf_wide_c_string): Likewise.
3888
3889 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3890
3891         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3892
3893 2019-07-04  Tom Tromey  <tom@tromey.com>
3894
3895         PR tui/24724:
3896         * tui/tui-winsource.c (tui_clear_source_content): Update.
3897         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3898         (tui_update_breakpoint_info): Update.
3899         (tui_set_exec_info_content): Update.
3900         * tui/tui-source.c (tui_set_source_content_nil): Update.
3901         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3902         has_break.
3903         * tui/tui-data.h (enum tui_bp_flag): New.
3904         (tui_bp_flags): New enum flags type.
3905         (struct tui_source_element) <break_mode>: Change type.  Rename
3906         from has_break.
3907         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3908         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3909         constants.
3910         * tui/tui-winsource.h: Fix comment.
3911
3912 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3913
3914         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3915         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3916         (store_fpregs_to_thread)
3917         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3918         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3919         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3920         (IWMMXT_REGS_SIZE): Add define.
3921         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3922         (fetch_vfp_regs, store_vfp_regs)
3923         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3924         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3925
3926 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3927
3928         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3929         defines.
3930         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3931         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3932         (ARM_INT_REGISTER_SIZE): ...to this.
3933         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3934         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3935         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3936         (arm_linux_collect_gregset, supply_nwfpe_register)
3937         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3938         defines.
3939         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3940         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3941         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3942         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3943         (arm_return_in_memory, arm_store_return_value)
3944         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3945         (arm_record_ld_st_multiple): Likewise.
3946         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3947         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3948
3949 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3950
3951         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3952         AARCH64_DISPLACED_MODIFIED_INSNS.
3953         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3954         (aarch64_displaced_step_copy_insn): Likewise.
3955         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3956         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3957         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3958         ARM_DISPLACED_MODIFIED_INSNS.
3959         * arm-tdep.c (arm_gdbarch_init): Likewise.
3960         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3961         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3962         (struct arm_displaced_step_closure): Use
3963         ARM_DISPLACED_MODIFIED_INSNS.
3964
3965 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3966
3967         * features/Makefile: Remove unused xml files.
3968         * features/aarch64.xml: Remove.
3969         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3970         * features/i386/amd64-avx-avx512.xml: Remove.
3971         * features/i386/amd64-avx-linux.xml: Remove.
3972         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3973         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3974         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3975         * features/i386/amd64-avx-mpx.xml: Remove.
3976         * features/i386/amd64-avx.xml: Remove.
3977         * features/i386/amd64-linux.xml: Remove.
3978         * features/i386/amd64-mpx-linux.xml: Remove.
3979         * features/i386/amd64-mpx.xml: Remove.
3980         * features/i386/amd64.xml: Remove.
3981         * features/i386/i386-avx-avx512-linux.xml: Remove.
3982         * features/i386/i386-avx-avx512.xml: Remove.
3983         * features/i386/i386-avx-linux.xml: Remove.
3984         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3985         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3986         * features/i386/i386-avx-mpx-linux.xml: Remove.
3987         * features/i386/i386-avx-mpx.xml: Remove.
3988         * features/i386/i386-avx.xml: Remove.
3989         * features/i386/i386-linux.xml: Remove.
3990         * features/i386/i386-mmx-linux.xml: Remove.
3991         * features/i386/i386-mmx.xml: Remove.
3992         * features/i386/i386-mpx-linux.xml: Remove.
3993         * features/i386/i386-mpx.xml: Remove.
3994         * features/i386/i386.xml: Remove.
3995         * features/i386/x32-avx-avx512-linux.xml: Remove.
3996         * features/i386/x32-avx-linux.xml: Remove.
3997         * features/i386/x32-linux.xml: Remove.
3998
3999 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4000
4001         * regformats/aarch64.dat: Remove.
4002         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4003         * regformats/i386/amd64-avx-linux.dat: Remove.
4004         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4005         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4006         * regformats/i386/amd64-linux.dat: Remove.
4007         * regformats/i386/amd64-mpx-linux.dat: Remove.
4008         * regformats/i386/amd64.dat: Remove.
4009         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4010         * regformats/i386/i386-avx-linux.dat: Remove.
4011         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4012         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4013         * regformats/i386/i386-linux.dat: Remove.
4014         * regformats/i386/i386-mmx-linux.dat: Remove.
4015         * regformats/i386/i386-mpx-linux.dat: Remove.
4016         * regformats/i386/i386.dat: Remove.
4017         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4018         * regformats/i386/x32-avx-linux.dat: Remove.
4019         * regformats/i386/x32-linux.dat: Remove.
4020
4021 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4022
4023         * aarch64-tdep.c: Remove xml self tests.
4024         * amd64-linux-tdep.c: Likewise.
4025         * amd64-tdep.c: Likewise.
4026         * i386-linux-tdep.c: Likewise.
4027         * i386-tdep.c: Likewise.
4028
4029 2019-07-03  Pedro Alves  <palves@redhat.com>
4030
4031         PR cli/24732
4032         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4033         (pipe_cmd_option_defs): New.
4034         (make_pipe_cmd_options_def_group): New.
4035         (pipe_command): Use gdb::option::process_options.
4036         (pipe_command_completer): New function.
4037         (_initialize_cli_cmds): Install completer for "pipe" command.
4038
4039 2019-07-03  Pedro Alves  <palves@redhat.com>
4040
4041         * cli/cli-option.c (union option_value) <string>: New field.
4042         (struct option_def_and_value): Add ctor, move ctor, dtor and
4043         use DISABLE_COPY_AND_ASSIGN.
4044         (option_def_and_value::clear_value): New.
4045         (parse_option, save_option_value_in_ctx, get_val_type_str)
4046         (add_setshow_cmds_for_options): Handle var_string.
4047         * cli-option.h (union option_def::var_address) <string>: New
4048         field.
4049         (struct string_option_def): New.
4050         * maint-test-options.c (struct test_options_opts): Add default
4051         ctor and use DISABLE_COPY_AND_ASSIGN.
4052         <string_opt>: New field.
4053         (test_options_opts::~test_options_opts): New.
4054         (test_options_opts::dump): Also dump "-string".
4055         (test_options_option_defs): Install "string.
4056
4057 2019-07-03  Pedro Alves  <palves@redhat.com>
4058
4059         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4060         option_value with a null enumeration.
4061         (complete_options): Save the option values in the context.
4062         (save_option_value_in_ctx): New, factored out from ...
4063         (process_options): ... here.
4064         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4065         of the function.
4066         * maint-test-options.c (test_options_opts::dump): New, factored
4067         out from ...
4068         (maintenance_test_options_command_mode): ... here.
4069         (maintenance_test_options_command_completion_result): Delete.
4070         (maintenance_test_options_command_completion_text): Update
4071         comment.
4072         (maintenance_show_test_options_completion_result): Change
4073         prototype.  Just print
4074         maintenance_test_options_command_completion_text.
4075         (save_completion_result): New.
4076         (maintenance_test_options_completer_mode): Pass options context to
4077         complete_options, and then save a dump.
4078         (_initialize_maint_test_options): Use add_cmd to install "maint
4079         show test-options-completion-result".
4080
4081 2019-07-03  Pedro Alves  <palves@redhat.com>
4082
4083         * NEWS (New commands): Mention "with" and "maint with".
4084         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4085         (with_command, with_command_completer): New.
4086         (pipe_command): Adjust to new repeat_previous
4087         interface.
4088         (_initialize_cli_cmds): Install the "with" command and its "w"
4089         alias.
4090         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4091         declarations.
4092         * cli/cli-setshow.c (parse_cli_var_uinteger)
4093         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4094         argument strings for all var_types.
4095         (get_setshow_command_value_string): New, factored out from ...
4096         (do_show_command): ... this.
4097         * cli/cli-setshow.h: Include <string>.
4098         (get_setshow_command_value_string): Declare.
4099         * command.h (repeat_previous): Now returns const char *.  Adjust
4100         comment.
4101         * maint.c: Include "cli/cli-cmds.h".
4102         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4103         (_initialize_maint_cmds): Register the "maintenance with" command.
4104         * top.c (repeat_previous): Move bits from pipe_command here:
4105         Return the saved command line, if any; error out if there's no
4106         command to relaunch.
4107
4108 2019-07-03  Pedro Alves  <palves@redhat.com>
4109
4110         * NEWS (New commands): Mention "maint set/show test-settings"
4111         instead of "maint test-settings".
4112         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4113         (maintenance_test_settings_set_list): Rename to ...
4114         (maintenance_set_test_settings_list): ... this.
4115         (maintenance_test_settings_show_list): Rename to  ...
4116         (maintenance_show_test_settings_list): ... this.
4117         (maintenance_test_settings_cmd): Delete.
4118         (maintenance_test_settings_set_cmd): ...
4119         (maintenance_set_test_settings_cmd): ... this.
4120         (maintenance_test_settings_show_cmd): ...
4121         (maintenance_show_test_settings_cmd): ... this.
4122         (maintenance_test_settings_show_value_cmd):
4123         (maintenance_show_test_settings_value_cmd): ... this.
4124         (_initialize_maint_test_settings): No longer install the "maint
4125         test-settings" prefix command.  Rename "maint test-settings set"
4126         to "maint set test-settings", and "maint test-settings show" to
4127         "maint show test-settings".  Adjust all subcommands.
4128
4129 2019-07-03  Pedro Alves  <palves@redhat.com>
4130
4131         * maint-test-settings.c: Fix file's intro comment.  Replace all
4132         references to "test-options" with references to "test-settings",
4133         in comments.
4134
4135 2019-07-03  Pedro Alves  <palves@redhat.com>
4136
4137         * maint-test-settings.c (maintenance_test_settings_xxx)
4138         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4139         New.
4140         (maintenance_test_settings_enums): Use them.
4141         (maintenance_test_settings_enum): Default to
4142         maintenance_test_settings_xxx.
4143         (_initialize_maint_test_settings): Initialize
4144         MAINTENANCE_TEST_SETTINGS_FILENAME.
4145
4146 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4147
4148         * breakpoint.h (remove_breakpoints_inf): Change return type to
4149         void, move function documentation here.
4150         * breakpoint.c (remove_breakpoints_inf): Change return type to
4151         void, move function documentation to header.
4152
4153 2019-07-02  Pedro Alves  <palves@redhat.com>
4154
4155         * NEWS (Completion improvements): Mention "info threads".
4156         * thread.c (struct info_threads_opts, info_threads_option_defs)
4157         (make_info_threads_options_def_group): New.
4158         (info_threads_command): Use gdb::option::process_options.
4159         (info_threads_command_completer): New.
4160         (_initialize_thread): Use gdb::option::build_help to build the
4161         help text for "info threads".
4162
4163 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4164
4165         * defs.h (generic_load): Move from here...
4166         * symfile.h (generic_load): ... to here.  Rename name parameter
4167         to args.
4168         * symfile.c (generic_load): Add comment.
4169
4170 2019-07-01  Tom Tromey  <tromey@adacore.com>
4171
4172         * dwarf2read.c
4173         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4174         declaration of without_params.  Fix formatting.
4175
4176 2019-07-01  Tom Tromey  <tromey@adacore.com>
4177
4178         * ada-exp.y (find_primitive_type): Update.
4179         * ada-lang.h (ada_lookup_symbol): Update.
4180         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4181         parameter.
4182         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4183
4184 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4185
4186         PR breakpoints/24541
4187         * gdbarch.c: Regenerate.
4188         * gdbarch.h: Regenerate.
4189         * gdbarch.sh: Add 'stap_adjust_register'.
4190         * i386-tdep.c: Include '<unordered_set>'.
4191         (i386_stap_adjust_register): New function.
4192         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4193         * stap-probe.c (stap_parse_register_operand): Call
4194         'gdbarch_stap_adjust_register'.
4195
4196 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4197
4198         PR python/24742
4199         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4200         * python/python.c (do_start_initialization): Use 'xmalloc'
4201         instead of 'PyMem_Malloc'.
4202
4203 2019-06-28  Tom Tromey  <tromey@adacore.com>
4204
4205         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4206         for Ada.
4207
4208 2019-06-27  Tom Tromey  <tromey@adacore.com>
4209
4210         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4211         objfile_key.
4212         (arm_find_mapping_symbol, arm_record_special_symbol)
4213         (_initialize_arm_tdep): Update.
4214         (arm_objfile_data_free): Remove.
4215
4216 2019-06-27  Tom Tromey  <tromey@adacore.com>
4217
4218         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4219         to cp_print_static_field.
4220
4221 2019-06-26  Tom Tromey  <tromey@adacore.com>
4222
4223         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4224         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4225         declare.
4226
4227 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4228
4229         * features/aarch64-core.c (create_feature_aarch64_core):
4230         Regenerate.
4231         * features/aarch64-core.xml: Add cpsr flags.
4232
4233 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4234
4235         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4236         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4237
4238 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4239
4240         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4241         field.
4242         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4243         use.
4244         (arm_record_special_symbol): Don't insert new symbol in sorted
4245         position, push it at the end.
4246
4247 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4248
4249         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4250         (arm_mapping_symbol_s): Remove.
4251         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4252         (arm_mapping_symbol_vec): New typedef.
4253         (struct arm_per_objfile): Add constructor.
4254         <section_maps>: Change type to
4255         std::unique_ptr<arm_mapping_symbol_vec[]>.
4256         (arm_compare_mapping_symbols): Remove.
4257         (arm_find_mapping_symbol): Adjust to section_maps type change.
4258         (arm_objfile_data_free): Call delete on arm_per_objfile.
4259         (arm_record_special_symbol): Adjust to section_maps type change.
4260         Allocate arm_per_objfile with new.
4261
4262 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4263
4264         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4265         with the command prefix.
4266
4267 2019-06-25  Tom Tromey  <tom@tromey.com>
4268
4269         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4270         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4271
4272 2019-06-25  Tom Tromey  <tom@tromey.com>
4273
4274         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4275         type.
4276         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4277         protected.
4278
4279 2019-06-25  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-winsource.c
4282         (tui_source_window_base::set_is_exec_point_at): Add check against
4283         LOA_ADDRESS.
4284
4285 2019-06-25  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-source.c (tui_set_source_content): Don't check before
4288         xfree.
4289         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4290
4291 2019-06-25  Tom Tromey  <tom@tromey.com>
4292
4293         * tui/tui-winsource.h (tui_update_source_window_as_is)
4294         (tui_alloc_source_buffer, tui_line_is_displayed)
4295         (tui_addr_is_displayed): Change type of win_info.
4296         * tui/tui-winsource.c (tui_update_source_window_as_is)
4297         (tui_clear_source_content, tui_show_source_line)
4298         (tui_show_source_content, tui_source_window_base::refill)
4299         (tui_source_window_base::set_is_exec_point_at)
4300         (tui_source_window_base::set_is_exec_point_at)
4301         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4302         (tui_alloc_source_buffer, tui_line_is_displayed)
4303         (tui_addr_is_displayed): Change type of win_info.  Update.
4304         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4305         (tui_source_window_base::do_make_visible_with_new_height):
4306         Update.
4307         * tui/tui-source.c (tui_set_source_content)
4308         (tui_set_source_content_nil)
4309         (tui_source_window::do_scroll_vertical): Update.
4310         * tui/tui-layout.c (show_layout): Update.
4311         * tui/tui-disasm.c (tui_set_disassem_content)
4312         (tui_disasm_window::do_scroll_vertical): Update.
4313         * tui/tui-data.h (tui_win_content): Remove.
4314         (struct tui_gen_win_info) <content, content_size>: Remove.
4315         (struct tui_source_element): Add initializers and destructor.
4316         (union tui_which_element, struct tui_win_element): Remove.
4317         (struct tui_source_window_base) <content>: New field.
4318         (struct tui_data_window): Remove destructor.
4319         (tui_alloc_content, tui_free_win_content)
4320         (tui_free_all_source_wins_content): Don't declare.
4321         * tui/tui-data.c (tui_initialize_static_data): Update.
4322         (init_content_element, tui_alloc_content): Remove.
4323         (~tui_gen_win_info): Update.
4324         (~tui_data_window, tui_free_all_source_wins_content)
4325         (tui_free_win_content, free_content, free_content_elements):
4326         Remove.
4327
4328 2019-06-25  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-winsource.h (tui_clear_source_content)
4331         (tui_erase_source_content, tui_show_source_content): Change type
4332         of win_info.
4333         * tui/tui-winsource.c (tui_clear_source_content)
4334         (tui_erase_source_content, tui_show_source_content): Change type
4335         of win_info.
4336         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4337         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4338         win_info.
4339         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4340         win_info.
4341         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4342
4343 2019-06-25  Tom Tromey  <tom@tromey.com>
4344
4345         * tui/tui-winsource.c (tui_clear_source_content)
4346         (tui_source_window_base::set_is_exec_point_at): Update.
4347         * tui/tui-source.c (tui_set_source_content_nil): Update.
4348         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4349         a bool.
4350         * tui/tui-data.c (init_content_element): Update.
4351
4352 2019-06-25  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4355         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4356         * tui/tui-layout.c (init_and_make_win): Update.
4357         * tui/tui.h (enum tui_win_type): Update.
4358         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4359         tui_win_is_auxillary.
4360         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4361         tui_win_is_auxillary.
4362
4363 2019-06-25  Tom Tromey  <tom@tromey.com>
4364
4365         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4366         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4367         (tui_delete_data_content_windows, tui_display_all_data)
4368         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4369         Update.
4370         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4371         * tui/tui-regs.c (tui_last_regs_line_no)
4372         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4373         (tui_show_registers): Update.
4374         (tui_show_register_group): Return void.  Update.
4375         (tui_display_registers_from, tui_display_reg_element_at_line)
4376         (tui_display_registers_from_line, tui_check_register_values):
4377         Update.
4378         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4379         member.
4380         (struct tui_data_window) <regs_content>: Now a std::vector.
4381         <regs_content_count>: Remove.
4382         (tui_add_content_elements, tui_free_data_content): Don't declare.
4383         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4384         (init_content_element): Remove DATA_WIN case.  Add assert.
4385         (tui_add_content_elements): Remove.
4386         (tui_data_window): Update.
4387         (tui_free_data_content): Remove.
4388         (free_content_elements): Remove DATA_WIN case.
4389
4390 2019-06-25  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-data.c (tui_data_item_window): Update.
4393         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4394         * tui/tui-windata.c (tui_display_all_data)
4395         (tui_display_data_from_line): Update.
4396         (tui_check_data_values): Remove.
4397         * tui/tui-regs.c (tui_show_register_group)
4398         (tui_display_reg_element_at_line): Update.
4399         * tui/tui-hooks.c (tui_register_changed)
4400         (tui_refresh_frame_and_register_information): Call
4401         tui_check_register_values.
4402         * tui/tui-data.h (struct tui_data_window) <data_content,
4403         data_content_count, data_type>: Remove.
4404         (enum tui_data_type): Remove.
4405
4406         * tui/tui-data.c (tui_data_window::clear_detail)
4407         (~tui_data_window): Update.
4408
4409 2019-06-25  Tom Tromey  <tom@tromey.com>
4410
4411         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4412         declare.
4413         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4414         Rename from tui_first_data_item_displayed.  Update.
4415         (tui_data_window::refresh_all)
4416         (tui_data_window::do_scroll_vertical): Update.
4417         * tui/tui-data.h (struct tui_data_window)
4418         <first_data_item_displayed>: Declare new method.
4419
4420 2019-06-25  Tom Tromey  <tom@tromey.com>
4421
4422         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4423         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4424         contents...
4425         (tui_initialize_static_data): ...here.
4426
4427 2019-06-25  Tom Tromey  <tom@tromey.com>
4428
4429         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4430         (tui_display_registers_from, tui_check_register_values): Update.
4431         (tui_display_register): Remove win_info parameter; update.
4432         (tui_get_register): Change type of parameters.
4433         * tui/tui-data.h (struct tui_data_element): Remove.
4434         (union tui_which_element) <data>: Remove.
4435         <data_window>: Change type.
4436         (struct tui_data_item_window): New.
4437         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4438         case.  Add assert.
4439         (~tui_data_item_window): New destructor.
4440         (free_content_elements): Remove DATA_ITEM_WIN case.
4441
4442 2019-06-25  Tom Tromey  <tom@tromey.com>
4443
4444         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4445         Remove.
4446
4447 2019-06-25  Tom Tromey  <tom@tromey.com>
4448
4449         * tui/tui-data.h (struct tui_command_element): Remove.
4450         (union tui_which_element) <command>: Remove.
4451         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4452         assert.
4453         (free_content_elements): Remove CMD_WIN case.
4454
4455 2019-06-25  Tom Tromey  <tom@tromey.com>
4456
4457         * tui/tui-layout.c (tui_set_layout): Update.
4458         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4459         * tui/tui-data.c (layout_def): Update.
4460
4461 2019-06-25  Tom Tromey  <tom@tromey.com>
4462
4463         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4464         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4465         (tui_source_window_base::set_new_height): Update.
4466         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4467         Update.
4468         (tui_set_locator_fullname, tui_set_locator_info)
4469         (tui_show_frame_info): Update.
4470         * tui/tui-source.c (tui_set_source_content)
4471         (tui_source_is_displayed): Update.
4472         * tui/tui-layout.c (show_source_disasm_command, show_data)
4473         (show_source_or_disasm_and_command): Update.
4474         * tui/tui-disasm.c (tui_set_disassem_content)
4475         (tui_get_begin_asm_address): Update.
4476         * tui/tui-data.h (struct tui_locator_element): Remove.
4477         (union tui_which_element) <locator>: Remove.
4478         (struct tui_locator_window): New.
4479         (tui_locator_win_info_ptr): Change return type.
4480         * tui/tui-data.c (_locator): Change type.
4481         (tui_locator_win_info_ptr): Change return type.
4482         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4483         (tui_alloc_content): Add assert.
4484
4485 2019-06-25  Tom Tromey  <tom@tromey.com>
4486
4487         * tui/tui-winsource.c
4488         (tui_exec_info_window::maybe_allocate_content): New method.
4489         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4490         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4491         (make_source_or_disasm_window): Add cast.
4492         * tui/tui-data.h (union tui_which_element) <simple_string>:
4493         Remove.
4494         (struct tui_source_info): New.
4495         (struct tui_source_window_base) <execution_info>: Change type.
4496         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4497         case, and add assert.
4498         (tui_alloc_content): Add assert.
4499
4500 2019-06-25  Tom Tromey  <tom@tromey.com>
4501
4502         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4503         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4504         * tui/tui-data.c (tui_alloc_win_info): Remove.
4505
4506 2019-06-25  Tom Tromey  <tom@tromey.com>
4507
4508         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4509         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4510         can_highlight.
4511
4512 2019-06-25  Tom Tromey  <tom@tromey.com>
4513
4514         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4515         make_visible_with_new_height method.
4516         (tui_win_info::make_visible_with_new_height): New method.
4517         (tui_source_window_base::do_make_visible_with_new_height)
4518         (tui_data_window::do_make_visible_with_new_height)
4519         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4520         (make_visible_with_new_height): Remove.
4521         (tui_resize_all, tui_adjust_win_heights): Use
4522         make_visible_with_new_height method.
4523         * tui/tui-data.h (struct tui_win_info)
4524         <do_make_visible_with_new_height, make_visible_with_new_height>:
4525         New methods.
4526         (struct tui_source_window_base, struct tui_data_window)
4527         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4528         methods.
4529
4530 2019-06-25  Tom Tromey  <tom@tromey.com>
4531
4532         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4533         method.
4534         (update_tab_width): Call update_tab_width method.
4535         * tui/tui-data.h (struct tui_win_info)
4536         (struct tui_source_window_base) <update_tab_width>: New methods.
4537
4538 2019-06-25  Tom Tromey  <tom@tromey.com>
4539
4540         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4541         parameter.
4542         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4543         parameter.
4544         (tui_gen_win_info::make_visible): Update.
4545         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4546         parameter.
4547         * tui/tui-data.h (enum tui_box): New enum.
4548         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4549
4550 2019-06-25  Tom Tromey  <tom@tromey.com>
4551
4552         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4553         init_and_make_win for EXEC_INFO_WIN.
4554         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4555         longer inline.
4556         (struct tui_win_info) <~tui_win_info>: Inline.
4557         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4558         Don't declare.
4559         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4560         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4561         Remove.
4562         (tui_initialize_static_data): Update.
4563         (~tui_gen_win_info): Handle more cleanup here.
4564         (~tui_source_window_base): Delete "execution_info".
4565         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4566
4567 2019-06-25  Tom Tromey  <tom@tromey.com>
4568
4569         * tui/tui-layout.c (make_command_window): Don't set
4570         can_highlight.
4571         (show_source_disasm_command): Call the reset method.
4572         (show_data): Don't set can_highlight.  Call the reset method.
4573         (tui_gen_win_info::reset): Rename from init_gen_win_info
4574         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4575         (show_source_or_disasm_and_command): Call the reset method.
4576         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4577         (struct tui_cmd_window): Set can_highlight.
4578
4579 2019-06-25  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4582         from make_visible.
4583         (tui_make_visible, tui_make_invisible): Rewrite.
4584         (tui_win_info::make_visible): Remove.
4585         (tui_source_window_base::make_visible): Update.
4586         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4587         method.  Moved from...
4588         (struct tui_win_info) <make_visible>: ...here.
4589
4590 2019-06-25  Tom Tromey  <tom@tromey.com>
4591
4592         * tui/tui-winsource.c
4593         (tui_source_window_base::do_scroll_horizontal): Remove direction
4594         parameter.
4595         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4596         direction parameter.
4597         * tui/tui-win.c (tui_win_info::forward_scroll)
4598         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4599         (tui_win_info::right_scroll): Update.
4600         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4601         direction parameter.
4602         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4603         direction parameter.
4604         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4605         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4606         Remove direction parameter.
4607         (struct tui_source_window_base, struct tui_source_window)
4608         (struct tui_disasm_window, struct tui_data_window)
4609         (struct tui_cmd_window): Update.
4610
4611 2019-06-25  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui-winsource.h (tui_set_exec_info_content)
4614         (tui_show_exec_info_content, tui_erase_exec_info_content)
4615         (tui_clear_exec_info_content, tui_update_exec_info): Change
4616         argument to tui_source_window_base.
4617         * tui/tui-winsource.c (tui_set_exec_info_content)
4618         (tui_show_exec_info_content, tui_erase_exec_info_content)
4619         (tui_clear_exec_info_content, tui_update_exec_info): Change
4620         argument to tui_source_window_base.
4621
4622 2019-06-25  Tom Tromey  <tom@tromey.com>
4623
4624         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4625         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4626
4627 2019-06-25  Tom Tromey  <tom@tromey.com>
4628
4629         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4630         check.
4631
4632 2019-06-25  Tom Tromey  <tom@tromey.com>
4633
4634         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4635         type to void.
4636         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4637         type to void.
4638         * tui/tui-source.c (tui_set_source_content): Update.
4639         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4640
4641 2019-06-25  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-win.c (window_name_completer, tui_set_focus)
4644         (tui_all_windows_info): Use name method.
4645         * tui/tui-data.h (struct tui_gen_win_info)
4646         (struct tui_source_window, struct tui_disasm_window)
4647         (struct tui_data_window, struct tui_cmd_window) <name>: New
4648         method.
4649         (tui_win_name): Don't declare.
4650         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4651         (tui_win_name): Remove.
4652
4653 2019-06-25  Tom Tromey  <tom@tromey.com>
4654
4655         * tui/tui-winsource.h (tui_update_source_window)
4656         (tui_update_source_window_as_is): Change parameter type.
4657         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4658         to be a tui_source_window_base.
4659         (tui_update_source_window_as_is): Likewise.
4660         * tui/tui-win.c (make_visible_with_new_height): Update.
4661
4662 2019-06-25  Tom Tromey  <tom@tromey.com>
4663
4664         * tui/tui-winsource.c (tui_erase_source_content)
4665         (tui_show_source_content, tui_show_exec_info_content)
4666         (tui_erase_exec_info_content): Use refresh_window method.
4667         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4668         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4669         from tui_refresh_win.
4670         (tui_data_window::refresh_window): New method.
4671         (tui_win_info::refresh, tui_source_window_base::refresh)
4672         (tui_refresh_all): Use refresh_window method.
4673         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4674         method.
4675         * tui/tui-regs.c (tui_display_register): Call refresh_window
4676         method.
4677         * tui/tui-layout.c (show_source_disasm_command)
4678         (show_source_or_disasm_and_command): Call refresh_window method.
4679         * tui/tui-data.h (struct tui_gen_win_info)
4680         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4681         New method.
4682
4683 2019-06-25  Tom Tromey  <tom@tromey.com>
4684
4685         * tui/tui.c (tui_rl_other_window, tui_enable)
4686         (tui_is_window_visible, tui_get_command_dimension): Update.
4687         * tui/tui-winsource.c (tui_update_source_window_as_is)
4688         (tui_clear_source_content, tui_erase_source_content)
4689         (tui_show_source_line, tui_source_window_base::refill)
4690         (tui_source_window_base::do_scroll_horizontal)
4691         (tui_source_window_base::set_is_exec_point_at)
4692         (tui_update_breakpoint_info, tui_set_exec_info_content)
4693         (tui_alloc_source_buffer, tui_line_is_displayed)
4694         (tui_addr_is_displayed): Update.
4695         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4696         (tui_check_and_display_highlight_if_needed)
4697         (tui_win_info::make_visible, tui_win_info::refresh)
4698         (tui_refresh_all): Update.
4699         * tui/tui-windata.c (tui_first_data_item_displayed)
4700         (tui_delete_data_content_windows, tui_erase_data_content)
4701         (tui_display_all_data, tui_data_window::refresh_all)
4702         (tui_check_data_values): Update.
4703         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4704         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4705         (tui_win_info::backward_scroll, tui_refresh_all_win)
4706         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4707         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4708         (tui_source_window_base::set_new_height)
4709         (tui_data_window::set_new_height)
4710         (make_invisible_and_set_new_height)
4711         (make_visible_with_new_height, new_height_ok)
4712         (parse_scrolling_args): Update.
4713         * tui/tui-stack.c (tui_show_frame_info): Update.
4714         * tui/tui-source.c (tui_set_source_content)
4715         (tui_set_source_content_nil, tui_source_is_displayed)
4716         (tui_source_window::do_scroll_vertical): Update.
4717         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4718         (tui_display_registers_from, tui_display_reg_element_at_line)
4719         (tui_check_register_values, tui_reg_command): Update.
4720         * tui/tui-layout.c (tui_default_win_height)
4721         (show_source_disasm_command, show_data, init_and_make_win)
4722         (show_source_or_disasm_and_command): Update.
4723         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4724         (tui_redisplay_readline, tui_mld_flush)
4725         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4726         (tui_getc): Update.
4727         * tui/tui-disasm.c (tui_set_disassem_content)
4728         (tui_disasm_window::do_scroll_vertical): Update.
4729         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4730         Now virtual.
4731         (struct tui_win_info): Derive from tui_gen_win_info.
4732         <~tui_win_info>: Mark as override.
4733         <generic>: Remove member.
4734         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4735         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4736         (~tui_data_window, ~tui_win_info)
4737         (tui_free_all_source_wins_content): Update.
4738         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4739
4740 2019-06-25  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-layout.c (init_and_make_win): Use new.
4743         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4744         destructor, initializers.
4745         (tui_alloc_generic_win_info): Don't declare.
4746         * tui/tui-data.c (_locator): Add argument to constructor.
4747         (source_win, disasm_win): New globals.
4748         (exec_info): Remove.
4749         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4750         Update.
4751         (tui_alloc_generic_win_info): Remove.
4752         (init_content_element): Use new.
4753         (tui_win_info::tui_win_info): Update.
4754         (free_content_elements) <case DATA_WIN>: Use delete.
4755
4756 2019-06-25  Tom Tromey  <tom@tromey.com>
4757
4758         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4759         * tui/tui-windata.c (tui_first_data_item_displayed)
4760         (tui_delete_data_content_windows): Update.
4761         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4762         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4763         (tui_display_registers_from, tui_check_register_values): Update.
4764         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4765         pointer.
4766         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4767         window.
4768         (tui_free_data_content): Update.
4769         (free_content_elements) <case DATA_WIN>: Free the window.
4770
4771 2019-06-25  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4774         Update.
4775         * tui/tui-layout.c (make_command_window)
4776         (show_source_disasm_command, show_data, init_and_make_win)
4777         (show_source_or_disasm_and_command): Update.
4778         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4779         method.
4780         <can_highight, is_highlighted>: Now bool.
4781         (tui_set_win_highlight): Don't declare.
4782         * tui/tui-data.c (tui_set_win_highlight): Remove.
4783
4784 2019-06-25  Tom Tromey  <tom@tromey.com>
4785
4786         * tui/tui-wingeneral.c (make_visible): Remove check of window
4787         type.
4788
4789 2019-06-25  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-win.c (tui_win_info::max_height)
4792         (tui_cmd_window::max_height): New methods.
4793         (new_height_ok): Call max_height.
4794         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4795         <max_height>: New method.
4796
4797 2019-06-25  Tom Tromey  <tom@tromey.com>
4798
4799         * tui/tui-win.c (tui_source_window_base::set_new_height)
4800         (tui_data_window::set_new_height): New methods.
4801         (make_invisible_and_set_new_height): Call set_new_height method.
4802         * tui/tui-data.h (struct tui_win_info)
4803         (struct tui_source_window_base, struct tui_data_window)
4804         <set_new_height>: New method.
4805
4806 2019-06-25  Tom Tromey  <tom@tromey.com>
4807
4808         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4809         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4810         tui_refresh_data_win.
4811         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4812         method.
4813         (tui_refresh_all_win): Call the refresh_all method.
4814         (tui_set_focus): Likewise.
4815         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4816         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4817         Likewise.
4818
4819 2019-06-25  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-winsource.h (tui_refill_source_window)
4822         (tui_set_is_exec_point_at): Don't declare.
4823         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4824         (tui_source_window_base::refill): Rename from
4825         tui_refill_source_window.
4826         (tui_source_window_base::do_scroll_horizontal): Update.
4827         (tui_source_window_base::set_is_exec_point_at): Rename from
4828         tui_set_is_exec_point_at.
4829         (tui_update_all_breakpoint_info): Update.
4830         * tui/tui-stack.c (tui_show_frame_info): Update.
4831         * tui/tui-layout.c (show_data): Add cast.
4832         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4833         * tui/tui-data.h (struct tui_source_window_base) <refill,
4834         set_is_exec_point_at>: New methods.
4835         (tui_source_windows, tui_add_to_source_windows): Update types.
4836         (tui_add_to_source_windows): Remove redundant declaration.
4837         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4838         (tui_source_windows): Change return type.
4839         (tui_clear_source_windows_detail): Update.
4840         (tui_add_to_source_windows): Change type of parameter.
4841         (tui_free_all_source_wins_content): Update.
4842
4843 2019-06-25  Tom Tromey  <tom@tromey.com>
4844
4845         * tui/tui-wingeneral.c (tui_win_info::refresh)
4846         (tui_source_window_base::refresh): New methods.
4847         (tui_refresh_all): Call the refresh method.
4848         * tui/tui-data.h (struct tui_win_info)
4849         (struct tui_source_window_base) <refresh>: New method.
4850
4851 2019-06-25  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui.h (tui_is_window_visible): Return bool.
4854         * tui/tui.c (tui_is_window_visible): Return bool.
4855         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4856         (tui_make_visible, tui_make_invisible)
4857         (tui_win_info::make_visible)
4858         (tui_source_window_base::make_visible, make_all_visible)
4859         (tui_make_all_visible, tui_make_all_invisible): Update.
4860         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4861         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4862         bool.
4863         (struct tui_win_info, struct tui_source_window_base)
4864         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4865         * tui/tui-data.c (tui_init_generic_part): Update.
4866
4867 2019-06-25  Tom Tromey  <tom@tromey.com>
4868
4869         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4870         (tui_source_window_base::make_visible): New methods.
4871         (make_all_visible): Make method call.
4872         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4873         (struct tui_source_window_base, struct tui_cmd_window): Override
4874         make_visible.
4875         (tui_win_is_source_type): Don't declare.
4876         * tui/tui-data.c (tui_win_is_source_type): Remove.
4877
4878 2019-06-25  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4881         NULL check.
4882
4883 2019-06-25  Tom Tromey  <tom@tromey.com>
4884
4885         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4886         Inline constructor.  Add initializers for members.
4887         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4888         constructors; now inline in class.
4889
4890 2019-06-25  Tom Tromey  <tom@tromey.com>
4891
4892         * tui/tui-regs.c (tui_show_registers): Update.
4893         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4894         bool.
4895         * tui/tui-data.c (tui_data_window::clear_detail)
4896         (tui_data_window): Update.
4897
4898 2019-06-25  Tom Tromey  <tom@tromey.com>
4899
4900         * tui/tui-windata.c (tui_display_all_data)
4901         (tui_display_data_from_line, tui_display_data_from)
4902         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4903         Update.
4904         * tui/tui-regs.c (tui_last_regs_line_no)
4905         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4906         (tui_show_registers, tui_show_register_group)
4907         (tui_display_registers_from, tui_display_reg_element_at_line)
4908         (tui_display_registers_from_line, tui_check_register_values)
4909         (tui_reg_next, tui_reg_prev): Update.
4910         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4911         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4912         tui_data_window.
4913         (struct tui_win_info) <detail>: Remove.  Add new fields from
4914         tui_data_info.
4915         (TUI_DATA_WIN): Add cast.
4916         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4917         (~tui_data_window): Simplify.
4918
4919 2019-06-25  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-layout.c (show_source_disasm_command)
4922         (show_source_or_disasm_and_command): Update.
4923         * tui/tui-io.c (update_cmdwin_start_line)
4924         (tui_redisplay_readline): Update.
4925         * tui/tui-data.h (struct tui_command_info): Remove.
4926         (struct tui_win_info) <detail>: Remove command_info member.
4927         (struct tui_data_window) <start_line>: New member, from
4928         tui_command_info.
4929         (TUI_CMD_WIN): Add casts.
4930
4931 2019-06-25  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-winsource.c (tui_update_source_window)
4934         (tui_refill_source_window)
4935         (tui_source_window_base::do_scroll_horizontal)
4936         (tui_update_breakpoint_info, tui_set_exec_info_content)
4937         (tui_show_exec_info_content, tui_erase_exec_info_content)
4938         (tui_clear_exec_info_content): Update.
4939         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4940         Update.
4941         * tui/tui-win.c (make_invisible_and_set_new_height)
4942         (make_visible_with_new_height): Update.
4943         * tui/tui-source.c (tui_set_source_content)
4944         (tui_show_symtab_source): Update.
4945         * tui/tui-layout.c (extract_display_start_addr)
4946         (show_source_disasm_command, show_data)
4947         (make_source_or_disasm_window)
4948         (show_source_or_disasm_and_command): Update.
4949         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4950         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4951         "gdbarch".
4952         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4953         to tui_source_window_base.
4954         (struct tui_win_info) <detail>: Remove source_info member.
4955         (struct tui_source_window_base) <has_locator>: Inline.
4956         Move contents from tui_source_info; rename has_locator member to
4957         m_has_locator.
4958         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4959         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4960         header file.
4961         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4962         Simplify.
4963         (tui_free_all_source_wins_content): Cast to
4964         tui_source_window_base.
4965
4966 2019-06-25  Tom Tromey  <tom@tromey.com>
4967
4968         * tui/tui-win.c (make_invisible_and_set_new_height)
4969         (make_visible_with_new_height): Call has_locator method.
4970         * tui/tui-layout.c (show_source_disasm_command, show_data)
4971         (show_source_or_disasm_and_command): Update for bool change.
4972         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4973         (tui_win_info) <has_locator>: New method.
4974         (struct tui_source_window_base) <has_locator>: New method.
4975         (tui_win_has_locator): Don't declare.
4976         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4977         from tui_win_has_locator.
4978         (tui_source_window_base): Use false, not FALSE.
4979
4980 2019-06-25  Tom Tromey  <tom@tromey.com>
4981
4982         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4983         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4984         clear_detail method directly.
4985         (tui_clear_win_detail): Remove.
4986
4987 2019-06-25  Tom Tromey  <tom@tromey.com>
4988
4989         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4990         "this", not TUI_DISASM_WIN.
4991
4992 2019-06-25  Tom Tromey  <tom@tromey.com>
4993
4994         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4995         declare.
4996         * tui/tui-winsource.c
4997         (tui_source_window_base::do_scroll_horizontal): Rename from
4998         tui_horizontal_source_scroll.
4999         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5000         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5001         from tui_vertical_data_scroll.
5002         * tui/tui-win.h (tui_scroll): Don't declare.
5003         * tui/tui-win.c (tui_win_info::forward_scroll)
5004         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5005         (tui_win_info::right_scroll): Rename and update.
5006         (tui_scroll_forward_command, tui_scroll_backward_command)
5007         (tui_scroll_left_command, tui_scroll_right_command): Update.
5008         (tui_scroll): Remove.
5009         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5010         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5011         from tui_vertical_source_scroll.
5012         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5013         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5014         from tui_vertical_disassem_scroll.
5015         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5016         do_scroll_horizontal>: New methods.
5017         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5018         Likewise.
5019         (struct tui_source_window_base): Add do_scroll_horizontal.
5020         (struct tui_source_window, struct tui_disasm_window): Add
5021         do_scroll_vertical.
5022         (struct tui_data_window, struct tui_cmd_window): Add
5023         do_scroll_horizontal and do_scroll_vertical.
5024         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5025
5026 2019-06-25  Tom Tromey  <tom@tromey.com>
5027
5028         * tui/tui-data.h (struct tui_source_window_base): New struct.
5029         (struct tui_source_window): Derive from tui_source_window_base.
5030         (struct tui_disasm_window): New struct.
5031         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5032         from tui_source_window::clear_detail.
5033         (tui_source_window_base): Rename from tui_source_window.
5034         (~tui_source_window_base): Rename from ~tui_source_window.
5035         (tui_alloc_win_info): Create a tui_disasm_window.
5036
5037 2019-06-25  Tom Tromey  <tom@tromey.com>
5038
5039         * tui/tui-data.h (struct tui_source_window)
5040         (struct tui_data_window): Declare destructors.
5041         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5042         destructors.
5043         (tui_win_info): Simplify.
5044
5045 2019-06-25  Tom Tromey  <tom@tromey.com>
5046
5047         * tui/tui-winsource.c (tui_display_main)
5048         (tui_update_source_windows_with_addr)
5049         (tui_update_all_breakpoint_info): Update.
5050         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5051         (new_height_ok, parse_scrolling_args): Update.
5052         * tui/tui-stack.c (tui_show_frame_info): Update.
5053         * tui/tui-data.h (struct tui_list): Remove.
5054         (tui_source_windows): Return a reference to a std::vector.
5055         * tui/tui-data.c (source_windows): Now a std::vector.
5056         (tui_source_windows): Change return type.
5057         (tui_clear_source_windows): Rewrite.
5058         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5059         (tui_free_all_source_wins_content): Rewrite.
5060
5061 2019-06-25  Tom Tromey  <tom@tromey.com>
5062
5063         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5064         (struct tui_data_window, struct tui_cmd_window): Declare
5065         clear_detail method.
5066         * tui/tui-data.c (tui_source_window::clear_detail)
5067         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5068         methods.
5069         (tui_clear_win_detail): Simplify.
5070
5071 2019-06-25  Tom Tromey  <tom@tromey.com>
5072
5073         * tui/tui-layout.c (make_source_window, make_disasm_window)
5074         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5075         Return the new window.
5076         (show_source_disasm_command, show_data)
5077         (show_source_or_disasm_and_command): Update.
5078
5079 2019-06-25  Tom Tromey  <tom@tromey.com>
5080
5081         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5082         parameter.  Return the new window.
5083         (show_source_disasm_command): Update and remove NULL check.
5084         (show_source_or_disasm_and_command): Update.
5085
5086 2019-06-25  Tom Tromey  <tom@tromey.com>
5087
5088         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5089
5090 2019-06-25  Tom Tromey  <tom@tromey.com>
5091
5092         * tui/tui-data.h (struct tui_win_info): Make constructor
5093         protected.  Make destructor virtual.  Add initializers.
5094         (tui_source_window, tui_data_window, tui_cmd_window): New
5095         classes.
5096         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5097         constructor.  Add "type" parameter.
5098         (tui_source_window, tui_data_window, tui_cmd_window): New
5099         constructors.
5100         (tui_alloc_win_info): Instantiate the appropriate subclass.
5101
5102 2019-06-25  Tom Tromey  <tom@tromey.com>
5103
5104         * tui/tui-win.c (tui_resize_all): Use delete.
5105         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5106         destructor.
5107         (tui_free_window): Don't declare.
5108         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5109         Update.
5110
5111 2019-06-25  Tom Tromey  <tom@tromey.com>
5112
5113         * tui/tui-data.h (struct tui_win_info): Add constructor.
5114         * tui/tui-data.c (tui_alloc_win_info): Use new.
5115         (tui_free_window): Use delete.
5116
5117 2019-06-22  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5120         declare.
5121         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5122
5123 2019-06-22  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5126         declare.
5127         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5128
5129 2019-06-22  Tom de Vries  <tdevries@suse.de>
5130
5131         * dwarf2read.c (create_addrmap_from_aranges)
5132         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5133         instead of '%zu'.
5134
5135 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5136
5137         * dwarf2read.h (dwarf2_section_info_def): Remove.
5138         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5139         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5140         std::vector<dwarf2_section_info>.
5141         (struct dwo_file) <~dwo_file>: Remove.
5142         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5143         types field.
5144         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5145         (dwarf2_read_debug_names): Likewise.
5146         (create_debug_types_hash_table): Change parameter type to
5147         array_view, adjust code accordingly.
5148         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5149         (partial_die_info::fixup): Likewise.
5150         (determine_prefix): Likewise.
5151         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5152
5153 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5154
5155         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5156         gdb_bfd_ref_ptr.
5157         <~dwo_file>: Remove call to gdb_bfd_unref.
5158         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5159         gdb_bfd_ref_ptr::get.
5160
5161 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5162
5163         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5164         type to htab_up.
5165         * dwarf2read.c (struct dwo_file): Initialize fields.
5166         <~dwo_file>: New.
5167         (free_dwo_file): Remove, move content to ~dwo_file.
5168         (struct dwo_file_deleter): Remove.
5169         (dwo_file_up>: Remove custom deleter.
5170         (free_dwo_files): Remove.
5171         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5172         dwo_files.
5173         (process_skeletonless_type_units): Call unique_ptr::get.
5174         (allocate_dwo_file_hash_table): Add deleter to created hash
5175         table.  Change return type to htab_up.
5176         (lookup_dwo_file_slot): Don't memset dwo_file, call
5177         unique_ptr::get.
5178         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5179         (create_dwo_unit_in_dwp_v2): Likewise.
5180         (open_and_init_dwo_file): Likewise.
5181         (free_dwo_file_from_slot): Remove.
5182
5183 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5184
5185         * dwarf2read.h (struct dwarf2_section_info) <readin,
5186         is_virtual>: Change type to bool.
5187         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5188         true instead of 1.
5189
5190 2019-06-19  Tom Tromey  <tom@tromey.com>
5191
5192         * tui/tui-data.h (tui_init_content_element): Don't declare.
5193
5194 2019-06-19  Tom Tromey  <tom@tromey.com>
5195
5196         * tui/tui-data.h (tui_init_win_info): Don't declare.
5197
5198 2019-06-19  Tom de Vries  <tdevries@suse.de>
5199
5200         * dwarf2read.h (abstract_to_concrete): Change type to
5201         std::unordered_map<sect_offset, std::vector<sect_offset>,
5202         gdb::hash_enum<sect_offset>>.
5203
5204 2019-06-19  Tom Tromey  <tromey@adacore.com>
5205
5206         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5207         EVAL_AVOID_SIDE_EFFECTS specially.
5208
5209 2019-06-19  Tom Tromey  <tromey@adacore.com>
5210
5211         * source-cache.c (highlighter): New global.
5212         (source_cache::get_source_lines): Create a highlighter on demand.
5213
5214 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5215
5216         * defs.h (deprecated_interactive_hook): Delete declaration.
5217         * interps.c (clear_interpreter_hooks): Remove use of
5218         deprecated_interactive_hook.
5219         * top.c (deprecated_interactive_hook): Delete definition.
5220         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5221
5222 2019-06-18  Tom de Vries  <tdevries@suse.de>
5223
5224         PR gdb/24515
5225         * dwarf2read.h (abstract_to_concrete): Change type from
5226         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5227         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5228         * dwarf2read.c (read_variable): Update.
5229         (dwarf2_fetch_die_loc_sect_off): Update.
5230
5231 2019-06-17  Tom de Vries  <tdevries@suse.de>
5232
5233         PR gdb/24617
5234         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5235         accessing parent[parent_len - 1].
5236
5237 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5238
5239         PR gdb/24364
5240         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5241         call dtrace_process_dof with NULL dof.
5242
5243 2019-06-16  Tom de Vries  <tdevries@suse.de>
5244
5245         PR gdb/24445
5246         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5247
5248 2019-06-16  Tom Tromey  <tom@tromey.com>
5249
5250         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5251         (make_all_visible): Use address of member.
5252
5253 2019-06-16  Tom Tromey  <tom@tromey.com>
5254
5255         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5256         (tui_free_window, free_content, free_content_elements): Remove
5257         unnecessary cast.
5258         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5259         cast.
5260         * tui/tui-regs.c (tui_show_register_group)
5261         (tui_display_registers_from, tui_display_reg_element_at_line):
5262         Remove unnecessary cast.
5263
5264 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * linux-nat.c (normal_mask): Delete.
5267         (_initialize_linux_nat): Don't initialise normal_mask.
5268
5269 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5270
5271         PR gdb/24445
5272         * dwarf-index-write.h (write_psymtabs_to_index): Add
5273         dwz_basename parameter.
5274         * dwarf-index-write.c (write_gdbindex): Move file writing to
5275         write_gdbindex_1.  Change return type void.
5276         (assert_file_size): Move up, remove filename parameter.
5277         (write_gdbindex_1): New function.
5278         (write_debug_names): Change return type to void, call
5279         assert_file_size.
5280         (struct index_wip_file): New struct.
5281         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5282         file logic to index_wip_file.  Write index for dwz file if
5283         needed.
5284         (save_gdb_index_command): Pass basename of dwz file, if present.
5285         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5286         build-id of dwz file, if present.
5287         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5288         (dwarf2_get_dwz_file): Likewise.
5289         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5290         (dwarf2_get_dwz_file): Likewise.
5291
5292 2019-06-16  Tom Tromey  <tom@tromey.com>
5293
5294         * coffread.c (process_coff_symbol): Use xstrdup.
5295         * value.c (create_internalvar): Use xstrdup.
5296
5297 2019-06-16  Tom Tromey  <tom@tromey.com>
5298
5299         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5300         * breakpoint.c (stopin_command, stopat_command)
5301         (until_break_command, decode_location_default): Remove unnecessary
5302         cast.
5303         * utils.c (subset_compare): Remove unnecessary cast.
5304         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5305         cast.
5306         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5307         cast.
5308         * infcmd.c (path_command): Remove unnecessary cast.
5309         * coffread.c (decode_type): Remove unnecessary cast.
5310         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5311         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5312         * tui/tui-stack.c (tui_show_locator_content)
5313         (tui_show_frame_info): Remove unnecessary cast.
5314         * tui/tui-win.c (tui_scroll_forward_command)
5315         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5316         (parse_scrolling_args): Remove unnecessary cast.
5317         * tui/tui-data.c (init_win_info, tui_del_window)
5318         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5319         (free_content_elements): Remove unnecessary cast.
5320         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5321         unnecessary cast.
5322         * tui/tui-source.c (tui_set_source_content)
5323         (tui_vertical_source_scroll): Remove unnecessary cast.
5324         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5325         cast.
5326         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5327         * tui/tui-regs.c (tui_display_registers_from)
5328         (tui_display_register): Remove unnecessary cast.
5329         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5330         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5331         (make_visible): Remove unnecessary cast.
5332         * tui/tui-winsource.c (tui_erase_source_content)
5333         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5334         unnecessary cast.
5335         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5336         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5337         * stabsread.c (read_type, read_array_type, read_range_type):
5338         Remove unnecessary cast.
5339         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5340         (parse_symbol, parse_type, upgrade_type, parse_external)
5341         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5342         unnecessary cast.
5343         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5344
5345 2019-06-16  Tom Tromey  <tom@tromey.com>
5346
5347         * tui/tui-data.c (tui_alloc_generic_win_info)
5348         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5349         checks.
5350
5351 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5352             Andrew Burgess  <andrew.burgess@embecosm.com>
5353
5354         * f-typeprint.c (f_print_type): Don't return early for not
5355         associated or not allocated types.
5356         (f_type_print_varspec_suffix): Add print_rank parameter and print
5357         ranks of array types in case they dangling.
5358         (f_type_print_base): Add print_rank parameter.
5359
5360 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5361
5362         * NEWS: Mention new MI commands.
5363         * break-catch-throw.c (enum exception_event_kind): Move to
5364         breakpoint.h.
5365         (print_mention_exception_catchpoint): Output text as a single
5366         message.
5367         (catch_exception_command_1): Rename to...
5368         (catch_exception_event): ...this, make non-static, update header
5369         command, and change some parameter types.
5370         (catch_catch_command): Update for changes to
5371         catch_exception_command_1.
5372         (catch_throw_command): Likewise.
5373         (catch_rethrow_command): Likewise.
5374         * breakpoint.c (enum exception_event_kind): Delete.
5375         * breakpoint.h (enum exception_event_kind): Moved here from
5376         break-catch-throw.c.
5377         (catch_exception_event): Declare.
5378         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5379         (mi_cmd_catch_throw): New function.
5380         (mi_cmd_catch_rethrow): New function.
5381         (mi_cmd_catch_catch): New function.
5382         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5383         'catch-catch' entries.
5384         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5385         (mi_cmd_catch_rethrow): Declare.
5386         (mi_cmd_catch_catch): Declare.
5387
5388 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5389
5390         * annotate.c (annotate_source_line): Change return type to void,
5391         update implementation to match.
5392         * annotate.h (annotate_source_line): Change return type to void,
5393         update header comment.
5394         * stack.c (print_frame_info): Don't change what frame information
5395         is printed based on whether annotations are on or not.
5396
5397 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5398
5399         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5400         (annotate_source): Make static.
5401         (annotate_source_line): Moved from source.c and renamed from
5402         identify_source_line.  Update the return type.
5403         * annotate.h (annotate_source): Delete declaration.
5404         (annotate_source_line): Declaration moved from source.h, and
5405         renamed from identify_source_line.  Return type updated.
5406         * source.c (identify_source_line): Moved to annotate.c and renamed
5407         to annotate_source_line.
5408         (info_line_command): Remove check of annotation_level.
5409         * source.h (identify_source_line): Move declaration to annotate.h
5410         and rename to annotate_source_line.
5411         * stack.c: Add 'annotate.h' include.
5412         (print_frame_info): Remove check of annotation_level before
5413         calling annotate_source_line.
5414
5415 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5416
5417         * source-cache.c (source_cache::get_plain_source_lines): Use
5418         open_source_file_with_line_charpos instead of just
5419         open_source_file, remove call to find_source_lines.
5420         (source_cache::get_source_lines): Likewise.
5421         * source.c (find_source_lines): Make static.
5422         (get_filename_and_charpos): Renamed into...
5423         (open_source_file_with_line_charpos): ..this along with changes to
5424         return a scoped_fd, and some other minor clean ups.
5425         (identify_source_line): Use open_source_file_with_line_charpos.
5426         (search_command_helper): Use open_source_file_with_line_charpos
5427         instead of just open_source_file, remove call to
5428         find_source_lines.
5429         * source.h (open_source_file_with_line_charpos): Declare new
5430         function.
5431         (find_source_lines): Delete declaration.
5432
5433 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * source.c (get_filename_and_charpos): Remove fullname
5436         parameter.
5437         (identify_source_line): Update call to get_filename_and_charpos.
5438
5439 2019-06-14  Tom Tromey  <tromey@adacore.com>
5440
5441         PR gdb/24502:
5442         * ui-style.h (skip_ansi_escape): Update comment.
5443         * ui-file.h (class no_terminal_escape_file): New class.
5444         * ui-file.c (no_terminal_escape_file::write)
5445         (no_terminal_escape_file::puts): New methods.
5446         * cli/cli-logging.c (handle_redirections): Use
5447         no_terminal_escape_file.
5448
5449 2019-06-14  Tom Tromey  <tromey@adacore.com>
5450
5451         * NEWS: Move convenience variable news above Python news.
5452
5453 2019-06-14  Tom Tromey  <tom@tromey.com>
5454
5455         * gnulib: Move directory to top-level.
5456         * configure.ac: Don't configure gnulib.
5457         * configure: Rebuild.
5458         * common/common-defs.h: Use new path to gnulib.
5459         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5460         (GNULIB_H): Remove.
5461         (INCGNU): Look in new gnulib location.
5462         (HFILES_NO_SRCDIR): Remove gnulib files.
5463         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5464         (generated_files): Remove GNULIB_H.
5465         ($(LIBGNU), all-lib): Remove targets.
5466         (distclean): Don't mention GNULIB_BUILDDIR.
5467         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5468
5469 2019-06-14  Tom Tromey  <tromey@adacore.com>
5470
5471         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5472         Warn if symbol file does not provide any symbols.
5473
5474 2019-06-14  Tom Tromey  <tromey@adacore.com>
5475
5476         * source.c (find_and_open_source): Respect basenames_may_differ.
5477
5478 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5479
5480         * annotate.c (annotate_breakpoints_invalid): Make use of
5481         scoped_restore_terminal_state.
5482         (annotate_frames_invalid): Likewise.
5483
5484 2019-06-14  Tom Tromey  <tromey@adacore.com>
5485
5486         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5487         allow assignment to an internalvar.
5488
5489 2019-06-14  Tom Tromey  <tromey@adacore.com>
5490
5491         * ada-lex.l: Allow "_" in attribute names.
5492
5493 2019-06-14  Tom Tromey  <tromey@adacore.com>
5494
5495         PR gdb/24653:
5496         * regcache.c (registers_changed): Don't call alloca.
5497         * top.c (execute_command): Don't call alloca.
5498
5499 2019-06-13  Pedro Alves  <palves@redhat.com>
5500
5501         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5502         'expression'.  When parsing an expression, error out if there's
5503         junk after "unlimited".
5504         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5505         (do_set_command): Adjust calls to is_unlimited_literal.
5506
5507 2019-06-13  Pedro Alves  <palves@redhat.com>
5508
5509         * compile/compile.c (make_compile_options_def_group): Add braces
5510         around array_view initializer.
5511         * thread.c (make_thread_apply_all_options_def_group)
5512         (make_thread_apply_all_options_def_group): Likewise.
5513
5514 2019-06-13  Pedro Alves  <palves@redhat.com>
5515
5516         * NEWS (New commands): Mention "maint test-options
5517         require-delimiter", "maint test-options unknown-is-error", "maint
5518         test-options unknown-is-operand" and "maint show
5519         test-options-completion-result".
5520         (New command options, command completion): New section.
5521         (Completion improvements): New section.
5522         Mention that you can abbreviate "unlimited".
5523
5524 2019-06-13  Pedro Alves  <palves@redhat.com>
5525
5526         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5527         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5528         * unittests/cli-utils-selftests.c (test_parse_flags)
5529         (test_parse_flags_qcs): Delete.
5530         (test_cli_utils): Don't call deleted functions.
5531
5532 2019-06-13  Pedro Alves  <palves@redhat.com>
5533
5534         * thread.c: Include "cli/cli-option.h".
5535         (tp_array_compar_ascending): Global.
5536         (tp_array_compar): Delete function.
5537         (tp_array_compar_ascending, tp_array_compar_descending): New
5538         functions.
5539         (ascending_option_def, qcs_flag_option_def)
5540         (thr_qcs_flags_option_defs)
5541         (make_thread_apply_all_options_def_group)
5542         (make_thread_apply_options_def_group): New.
5543         (thread_apply_all_command): Use gdb::option::process_options.
5544         (thread_apply_command_completer)
5545         (thread_apply_all_command_completer): New.
5546         (thread_apply_command): Use gdb::option::process_options.
5547         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5548         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5549         to generate help text of "thread apply".  Adjust "taas"'s help.
5550         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5551         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5552
5553 2019-06-13  Pedro Alves  <palves@redhat.com>
5554
5555         * thread.c (thread_apply_command): Check for invalid TID with
5556         isdigit instead of !isalpha.
5557
5558 2019-06-13  Pedro Alves  <palves@redhat.com>
5559
5560         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5561         (validate_flags_qcs): New.
5562         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5563         (validate_flags_qcs): Declare.
5564         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5565         (make_frame_apply_options_def_group): New.
5566         (frame_apply_command_count): Process options with
5567         gdb::option::process_options.
5568         (frame_apply_completer): New.
5569         (frame_apply_level_completer, frame_apply_all_completer)
5570         (frame_apply_completer): New.
5571         (_initialize_stack): Update help of "frame apply", "frame apply
5572         level", "frame apply all" and "faas" to mention supported options
5573         and install command completers.
5574         * stack.h (frame_apply_all_completer): Declare.
5575         * thread.c: Include "stack.h".
5576         (tfaas_command): Add "--".
5577         (_initialize_thread): Update help "tfaas" to mention supported
5578         options and install command completer.
5579
5580 2019-06-13  Pedro Alves  <palves@redhat.com>
5581
5582         * completer.c (complete_nested_command_line): New.
5583         (gdb_completion_word_break_characters_throw): Add assertion.
5584         * completer.h (complete_nested_command_line): Declare.
5585
5586 2019-06-13  Pedro Alves  <palves@redhat.com>
5587
5588         * stack.c (parse_backtrace_qualifiers): New.
5589         (backtrace_command): Use it.
5590         (backtrace_command_completer): Complete on qualifiers.
5591
5592 2019-06-13  Pedro Alves  <palves@redhat.com>
5593
5594         * frame.c: Include "cli/cli-option.h.
5595         (user_set_backtrace_options): New.
5596         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5597         Delete.
5598         (get_prev_frame): Adjust.
5599         (boolean_option_def, uinteger_option_def)
5600         (set_backtrace_option_defs): New.
5601         (_initialize_frame): Adjust and use
5602         gdb::option::add_setshow_cmds_for_options to install "set
5603         backtrace past-main" and "set backtrace past-entry".
5604         * frame.h: Include "cli/cli-option.h".
5605         (struct frame_print_options): Forward declare.
5606         (print_frame_arguments_all, print_frame_arguments_scalars)
5607         (print_frame_arguments_none): Declare.
5608         (print_entry_values): Delete declaration.
5609         (struct frame_print_options, user_frame_print_options): New.
5610         (struct set_backtrace_options): New.
5611         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5612         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5613         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5614         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5615         (list_args_or_locals): Add frame_print_options parameter.
5616         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5617         * python/py-framefilter.c (enumerate_args): Pass down
5618         USER_FRAME_PRINT_OPTIONS.
5619         * stack.c: Include "cli/cli-option.h".
5620         (print_frame_arguments_all, print_frame_arguments_scalars)
5621         (print_frame_arguments_none): Declare.
5622         (print_raw_frame_arguments, print_entry_values): Delete.
5623         (user_frame_print_options): New.
5624         (boolean_option_def, enum_option_def, frame_print_option_defs):
5625         New.
5626         (struct backtrace_cmd_options): New.
5627         (bt_flag_option_def): New.
5628         (backtrace_command_option_defs): New.
5629         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5630         (print_frame_arg, read_frame_arg, print_frame_args)
5631         (print_frame_info, print_frame): Add frame_print_options parameter
5632         and use it.
5633         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5634         (backtrace_command_1): Add frame_print_options and
5635         backtrace_cmd_options parameters and use them.
5636         (make_backtrace_options_def_group): New.
5637         (backtrace_command): Process command options with
5638         gdb::option::process_options.
5639         (backtrace_command_completer): New.
5640         (_initialize_stack): Extend "backtrace"'s help to mention
5641         supported options.  Install completer for "backtrace".
5642         Install some settings commands with add_setshow_cmds_for_options.
5643
5644 2019-06-13  Pedro Alves  <palves@redhat.com>
5645
5646         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5647         and that "set/show print raw frame-arguments" are now deprecated.
5648
5649         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5650         command.
5651         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5652         * stack.c (_initialize_stack): Install "set/show print
5653         raw-frame-arguments", and deprecate "set/show print raw
5654         frame-arguments".
5655         * valprint.c (_initialize_valprint): Deprecate "set/show print
5656         raw".
5657
5658 2019-06-13  Pedro Alves  <palves@redhat.com>
5659
5660         * compile/compile.c (struct compile_options): New.
5661         (compile_flag_option_def, compile_command_option_defs)
5662         (make_compile_options_def_group): New.
5663         (compile_file_command): Handle options with
5664         gdb::option::process_options.
5665         (compile_file_command_completer): New function.
5666         (compile_code_command): Handle options with
5667         gdb::option::process_options.
5668         (compile_code_command_completer): New function.
5669         (_initialize_compiler): Install completers for "compile code" and
5670         "compile file".  Mention available options in "compile code" and
5671         "compile code"'s help.
5672         * completer.c (advance_to_completion_word): New, factored out from
5673         ...
5674         (advance_to_expression_complete_word_point): ... this.
5675         (advance_to_filename_complete_word_point): New.
5676         * completer.h (advance_to_filename_complete_word_point): New
5677         declaration.
5678
5679 2019-06-13  Pedro Alves  <palves@redhat.com>
5680
5681         * compile/compile.c: Include "cli/cli-option.h".
5682         (compile_print_value): Scope data pointer is now a
5683         value_print_options pointer; adjust.
5684         (compile_print_command): Process options.  Scope data pointer is
5685         now a value_print_options pointer; adjust.
5686         (_initialize_compile): Update "compile print"'s help to include
5687         supported options.  Install a completer for "compile print".
5688         * cp-valprint.c (show_vtblprint, show_objectprint)
5689         (show_static_field_print): Delete.
5690         (_initialize_cp_valprint): Don't install "set print
5691         static-members", "set print vtbl", "set print object" here.
5692         * printcmd.c: Include "cli/cli-option.h" and
5693         "common/gdb_optional.h".
5694         (print_command_parse_format): Rework to fill in a
5695         value_print_options instead of a format_data.
5696         (print_value): Change parameter type from format_data pointer to
5697         value_print_options reference.  Adjust.
5698         (print_command_1): Process options.  Adjust to pass down a
5699         value_print_options.
5700         (print_command_completer): New.
5701         (_initialize_printcmd): Install print_command_completer as
5702         handle_brkchars completer for the "print" command.  Update
5703         "print"'s help to include supported options.
5704         * valprint.c: Include "cli/cli-option.h".
5705         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5706         here from cp-valprint.c.
5707         (boolean_option_def, uinteger_option_def)
5708         (value_print_option_defs, make_value_print_options_def_group):
5709         New.  Use gdb::option::add_setshow_cmds_for_options to install
5710         "set print elements", "set print null-stop", "set print repeats",
5711         "set print pretty", "set print union", "set print array", "set
5712         print address", "set print symbol", "set print array-indexes".
5713         * valprint.h: Include <string> and "cli/cli-option.h".
5714         (make_value_print_options_def_group): Declare.
5715         (print_value): Change parameter type from format_data pointer to
5716         value_print_options reference.
5717         (print_command_completer): Declare.
5718
5719 2019-06-13  Pedro Alves  <palves@redhat.com>
5720
5721         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5722         (COMMON_SFILES): Add maint-test-settings.c.
5723         * cli/cli-decode.c (boolean_enums): New global, factored out from
5724         ...
5725         (add_setshow_boolean_cmd): ... here.
5726         * cli/cli-decode.h (boolean_enums): Declare.
5727         * cli/cli-option.c: New file.
5728         * cli/cli-option.h: New file.
5729         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5730         factored out from ...
5731         (parse_cli_boolean_value(const char *)): ... this.
5732         (is_unlimited_literal): Change parameter type to pointer to
5733         pointer.  Adjust and advance ARG pointer.
5734         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5735         (parse_cli_var_enum): New, factored out from ...
5736         (do_set_command): ... this.  Adjust.
5737         * cli/cli-setshow.h (parse_cli_boolean_value)
5738         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5739         (parse_cli_var_enum): Declare.
5740         * cli/cli-utils.c: Include "cli/cli-option.h".
5741         (get_ulongest): New.
5742         * cli/cli-utils.h (get_ulongest): Declare.
5743         (check_for_argument): New overloads.
5744         * maint-test-options.c: New file.
5745
5746 2019-06-13  Pedro Alves  <palves@redhat.com>
5747
5748         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5749         parse a range if "-" is at the end of the string.
5750
5751 2019-06-13  Pedro Alves  <palves@redhat.com>
5752
5753         * cli/cli-setshow.c (parse_auto_binary_operation)
5754         (parse_cli_boolean_value): Don't allow "o".
5755
5756 2019-06-13  Pedro Alves  <palves@redhat.com>
5757
5758         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5759         * NEWS: Mention maint test-settings KIND.
5760         * maint-test-settings.c: New file.
5761
5762 2019-06-13  Pedro Alves  <palves@redhat.com>
5763
5764         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5765         completer.
5766         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5767         "set" completers.
5768
5769 2019-06-13  Pedro Alves  <palves@redhat.com>
5770
5771         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5772         after item.
5773
5774 2019-06-13  Pedro Alves  <palves@redhat.com>
5775
5776         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5777
5778 2019-06-13  Pedro Alves <palves@redhat.com>
5779
5780         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5781         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5782         call.
5783         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5784         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5785         calls.
5786         (check_for_argument): Skip spaces after argument.
5787
5788 2019-06-13  Pedro Alves  <palves@redhat.com>
5789
5790         * thread.c (thread_apply_command): Adjust TID parsing.
5791         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5792         detected before end of string.
5793         (tid_is_in_list): Error out if LIST is invalid.
5794
5795 2019-06-13  Pedro Alves  <palves@redhat.com>
5796
5797         * completer.c (complete_line_internal_1): Rewind completion word
5798         point.
5799         (completion_tracker::advance_custom_word_point_by): Change
5800         parameter type to int.
5801         * completer.h (completion_tracker::advance_custom_word_point_by):
5802         Likewise.
5803
5804 2019-06-13  Pedro Alves  <palves@redhat.com>
5805
5806         * completer.c (advance_to_completion_word): Handle delimiters.
5807
5808 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5809
5810         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5811
5812 2019-06-11  Tom Tromey  <tom@tromey.com>
5813
5814         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5815         (xmalloc_failed): Move to alloc.c.
5816         * alloc.c: New file.
5817         * Makefile.in (COMMON_SFILES): Add alloc.c.
5818
5819 2019-06-11  Tom Tromey  <tom@tromey.com>
5820
5821         * nat/linux-waitpid.c: Don't include server.h.
5822         (linux_debug): Remove.
5823         (my_waitpid): Update.
5824
5825 2019-06-11  Tom Tromey  <tromey@adacore.com>
5826
5827         * infcall.c (_initialize_infcall): Remove trailing newline from
5828         help.
5829         * user-regs.c (_initialize_user_regs): Remove trailing newline
5830         from help.
5831         * typeprint.c (_initialize_typeprint): Remove trailing newline
5832         from help.
5833         * reverse.c (_initialize_reverse): Remove trailing newlines from
5834         help.
5835         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5836         from help.
5837         * language.c (add_set_language_command): Remove trailing newline
5838         from help.
5839         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5840         help.
5841         * disasm.c (_initialize_disasm): Remove trailing newline from
5842         help.
5843         * top.c (init_main): Remove trailing newline from help.
5844         * interps.c (_initialize_interpreter): Remove trailing newline
5845         from help.
5846         * btrace.c (_initialize_btrace): Remove trailing newlines from
5847         help.
5848         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5849         from help.
5850         * python/python.c (_initialize_python): Remove trailing newline
5851         from help.
5852         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5853         help.
5854         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5855         from help.  Reformat some text.
5856         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5857         from help.
5858         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5859         newline from help.
5860
5861 2019-06-11  Tom Tromey  <tromey@adacore.com>
5862
5863         * darwin-nat.c (darwin_decode_exception_message)
5864         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5865
5866 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5867
5868         * valops.c (value_slice): Check for not allocated or not
5869         associated values.
5870
5871 2019-06-10  Tom de Vries  <tdevries@suse.de>
5872
5873         PR gdb/24618
5874         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5875         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5876         invalid.
5877
5878 2019-06-10  Tom de Vries  <tdevries@suse.de>
5879
5880         PR gdb/24611
5881         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5882         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5883
5884 2019-06-10  Tom de Vries  <tdevries@suse.de>
5885
5886         PR symtab/24545
5887         * symtab.c (struct demangled_name_entry): Add language field.
5888         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5889         static minimal symbol".  Set and use language field.
5890
5891 2019-06-10  Tom Tromey  <tromey@adacore.com>
5892
5893         * ada-lang.c (_initialize_ada_language): Update help text.
5894
5895 2019-06-10  Tom Tromey  <tromey@adacore.com>
5896
5897         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5898         with a newline.
5899         * guile/guile.c (handle_boot_error): Don't end warning with a
5900         newline.
5901         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5902         warning with a newline.
5903         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5904         newline.
5905         (s12z_frame_cache): Likewise.
5906         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5907         a newline.
5908         * solib-svr4.c (disable_probes_interface): Don't end warning with
5909         a newline.
5910         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5911         newline.
5912         * python/python.c (do_finish_initialization): Don't end warning
5913         with a newline.
5914
5915 2019-06-10  Tom Tromey  <tom@tromey.com>
5916
5917         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5918         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5919         gdbpy_enter.
5920
5921 2019-06-10  Tom Tromey  <tromey@adacore.com>
5922
5923         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5924         data.
5925         (elf_new_init): Don't call stabsread_new_init.
5926         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5927         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5928         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5929
5930 2019-06-10  Tom de Vries  <tdevries@suse.de>
5931
5932         PR symtab/16264
5933         PR symtab/24517
5934         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5935
5936 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5937
5938         * source.c (find_and_open_source): Also rewrite relative file
5939         names.
5940
5941 2019-04-26  Amos Bird  <amosbird@gmail.com>
5942
5943         * annotate.c (annotate_thread_exited): Add "thread-exited"
5944         annotation.
5945
5946 2019-06-06  Tom Tromey  <tromey@adacore.com>
5947
5948         * maint.h (class scoped_command_stats): Use
5949         DISABLE_COPY_AND_ASSIGN.
5950         <print_time>: New method.
5951         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5952         print_time.
5953         (scoped_command_stats::print_time): New method.
5954
5955 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5956
5957         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5958         instructions of lengths 6 or 8 bytes.
5959
5960 2019-06-04  Pedro Alves  <palves@redhat.com>
5961
5962         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5963
5964         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5965         * breakpoint.c (condition_completer): Likewise.
5966         * cli/cli-dump.c (scan_expression): Likewise.
5967         * common/filestuff.c (mkdir_recursive): Likewise.
5968         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5969         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5970         (gdb_abspath): Likewise.
5971         * compile/compile-cplus-types.c
5972         (compile_cplus_instance::decl_name): Likewise.
5973         * completer.c (complete_explicit_location):
5974         (signal_completer, reg_or_group_completer_1): Likewise.
5975         * cp-support.c (cp_remove_params_if_any): Likewise.
5976         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5977         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5978         * infcmd.c (strip_bg_char): Likewise.
5979         * linespec.c (copy_token_string): Likewise.
5980         * mi/mi-main.c (output_cores): Likewise.
5981         * psymtab.c (psymtab_search_name):
5982         * symfile.c (test_set_ext_lang_command): Likewise.
5983         * target.c (target_fileio_read_stralloc): Likewise.
5984         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5985         * value.c (complete_internalvar): Likewise.
5986
5987 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5988
5989         Add objfile property to gdb.Type.
5990         * NEWS: Mention Python API addition.
5991         * python/py-type.c (typy_get_objfile): New method.
5992
5993 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5994
5995         * NEWS: Mention the new set|show style [title|highlight].
5996         Mention changes to "show style", "help" and "apropos".
5997
5998 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5999
6000         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6001         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6002         instead of print_help_for_command.
6003         (print_doc_of_command): New function.
6004         (help_list): Add 'apropos -v word' suggestion.
6005         (print_help_for_command): Style the command name using title style.
6006         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6007         (_initialize_cli_cmds): Describe -v in apropos_command help.
6008
6009 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6010
6011         * cli/cli-style.h (cli_style_option): Add name in constructor,
6012         add m_name class member, add constructor with intensity,
6013         add name class function.
6014         (cli_style_option::add_setshow_commands): Remove name argument.
6015         (highlight_style, title_style): New styles.
6016         * cli/cli-style.c (do_show): New function that shows a style
6017         characteristic styling the style name with itself.
6018         (set_style_name): New function.
6019         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6020         Update all callers according to the changes in cli/cli-style.h.
6021         * utils.h (fputs_highlighted): New function.
6022         * utils.c (fputs_highlighted): Likewise.
6023
6024 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6025
6026         * NEWS: Mention new pipe command and new convenience variables.
6027
6028 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6029
6030         * cli/cli-cmds.c (pipe_command): New function.
6031         (_initialize_cli_cmds): Call add_com for pipe_command.
6032         Define | as an alias for pipe.
6033         (exit_status_set_internal_vars): New function.
6034         (shell_escape): Call exit_status_set_internal_vars.
6035         cli/cli-decode.c (find_command_name_length): Recognize | as
6036         a single character command.
6037
6038 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6039
6040         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6041         top.c (execute_command_to_ui_file): New function, mostly a copy
6042         of execute_command_to_string.
6043         (execute_command_to_string): Implement by calling
6044         execute_command_to_ui_file.
6045
6046 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6047
6048         * top.h (saved_command_line): Remove declaration.
6049         * top.c (previous_saved_command_line, previous_repeat_arguments):
6050         New variables.
6051         (saved_command_line): Make static, define together with other
6052         'repeat variables'.
6053         (dont_repeat): Clear repeat_arguments.
6054         (repeat_previous, get_saved_command_line, save_command_line):
6055         New functions.
6056         (gdb_init): Initialize saved_command_line
6057         and previous_saved_command_line.
6058         * main.c (captured_main_1): Remove saved_command_line initialization.
6059         * event-top.c (handle_line_of_input): Update to use
6060         the new 'repeat' related functions instead of direct access to
6061         saved_command_line.
6062         * command.h (repeat_previous, get_saved_command_line,
6063         save_command_line): New declarations.
6064         (dont_repeat): Add comment.
6065
6066 2019-05-30  Tom Tromey  <tromey@adacore.com>
6067
6068         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6069         Fix comment.
6070         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6071
6072 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6073
6074         PR cli/24587
6075         * completer.c (complete): Initialize variable word.
6076
6077 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6078
6079         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6080         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6081         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6082         'body' is NULL to the outter 'if', protecting the '!is_define'
6083         situation as well.
6084
6085 2019-05-29  Tom Tromey  <tromey@adacore.com>
6086
6087         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6088         (dwarf_unknown): New function.
6089         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6090         (dwarf_type_encoding_name): Use dwarf_unknown.
6091
6092 2019-05-29  Tom Tromey  <tromey@adacore.com>
6093
6094         PR c++/20020:
6095         * cp-valprint.c (cp_print_value_fields): Call
6096         cp_print_static_field inside "try".
6097
6098 2019-05-29  Tom Tromey  <tromey@adacore.com>
6099
6100         * inflow.c (struct terminal_info): Add default operator=.
6101         * configure: Rebuild.
6102         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6103         -Wdeprecated-copy-dtor, -Wredundant-move.
6104
6105 2019-05-29  Tom Tromey  <tromey@adacore.com>
6106
6107         * NEWS: Add entry.
6108         * infcmd.c (print_return_value_1): Handle finish_print
6109         option.
6110         (show_print_finish): New function.
6111         (_initialize_infcmd): Add "set/show print finish" commands.
6112         * valprint.c (user_print_options): Initialize new member.
6113         * valprint.h (struct value_print_options) <finish_print>: New
6114         member.
6115
6116 2019-05-28  Tom Tromey  <tromey@adacore.com>
6117
6118         * ada-lang.c (ada_remove_Xbn_suffix)
6119         (find_old_style_renaming_symbol)
6120         (parse_old_style_renaming): Remove.
6121         (ada_find_renaming_symbol): Don't call
6122         find_old_style_renaming_symbol.
6123         (ada_is_renaming_symbol): Rename from
6124         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6125         bool.  Now static.
6126         (ada_read_var_value): Update and simplify.
6127         * ada-exp.y (write_var_or_type): Remove old code.
6128
6129 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6130
6131         * event-top.c: Remove include comment.
6132         * inflow.c (class scoped_ignore_sigttou): Move from here...
6133         * inflow.h (class scoped_ignore_sigttou): ...to here.
6134         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6135         * top.c:  Remove include comment.
6136
6137 2019-05-27  Tom Tromey  <tom@tromey.com>
6138
6139         * NEWS: Fix typo.
6140
6141 2019-05-22  Tom Tromey  <tromey@adacore.com>
6142
6143         * target.c (target_follow_exec): Constify parameter.
6144         * target-delegates.c: Rebuild.
6145         * remote.c (remote_target::follow_exec): Constify parameter.
6146         * infrun.c (follow_exec): Constify parameter.
6147         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6148         (target_follow_exec): Likewise.
6149
6150 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6151
6152         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6153         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6154
6155 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6156
6157         * NEWS: Add debugredirect and testsuite sections.
6158
6159 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6160
6161         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6162         target descriptions using exclusively floating point register name
6163         aliases.
6164
6165 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6166
6167         PR gdb/18644:
6168         * f-lang.c (build_fortran_types): Handle the case where
6169         gdbarch_floatformat_for_type returns a nullptr.
6170
6171 2019-05-21  Tom de Vries  <tdevries@suse.de>
6172
6173         PR cli/24587
6174         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6175
6176 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6177
6178         PR gdb/18644:
6179         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6180         16-byte floats.
6181         * i386-tdep.c (i386_floatformat_for_type): Use
6182         floatformats_ia64_quad for the 16-byte floating point component
6183         within a fortran 32-byte complex number.
6184
6185 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6186
6187         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6188         delete default constructor.
6189         (find_partial_die): Update to return const struct.
6190         (partial_die_parent_scope): Move variable declaration into scope
6191         of its use and change its type to auto.
6192         (guess_partial_die_structure_name): Likewise.
6193         (partial_die_info::fixup): Likewise.
6194
6195 2019-05-17  Tom Tromey  <tromey@adacore.com>
6196
6197         * source.c (find_and_open_source): Remove cast.
6198
6199 2019-05-17  Tom Tromey  <tromey@adacore.com>
6200
6201         * annotate.c (annotate_source): Make "filename" const.
6202         * annotate.h (annotate_source): Use const.
6203
6204 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6205
6206         * disasm.c (set_disassembler_options): Send errors to stderr.
6207
6208 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6209
6210         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6211         (cli_interp_base::set_logging): Check debug_redirect.
6212         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6213         * cli/cli-logging.c (debug_redirect): Add static variable.
6214         (pop_output_files): Add default param.
6215         (handle_redirections): Print debug setting.
6216         (show_logging_command): Likewise.
6217         (_initialize_cli_logging): Add debugredirect command.
6218         * interps.c (current_interp_set_logging): Add debug_redirect
6219         parameter.
6220         * interps.h (set_logging): Add debug_redirect parameter.
6221         (current_interp_set_logging): Likewise.
6222         * mi/mi-common.h: Likewise.
6223         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6224
6225 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6226             Tom Tromey  <tromey@adacore.com>
6227
6228         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6229         directly.
6230         * cli/cli-interp.h (make_logging_output): Remove declaration.
6231         * cli/cli-logging.c (make_logging_output): Remove function.
6232         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6233         directly.
6234         * ui-file.c (tee_file::tee_file): Remove bools.
6235         (tee_file::~tee_file): Remove deletes.
6236         * ui-file.h (tee_file): Remove bools.
6237
6238 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6239
6240         * mi/mi-cmds.h (mi_cmd_complete): New function.
6241         * mi/mi-main.c (mi_cmd_complete): Likewise.
6242         * mi/mi-cmds.c: Define new MI command -complete.
6243         * NEWS: Mention new -complete command.
6244
6245 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6246
6247         * completer.h (complete): New function.
6248         * completer.c (complete): Likewise.
6249         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6250         function defined in completer.h.
6251
6252 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6253
6254         * MAINTAINERS (Write After Approval): Add myself.
6255
6256 2019-05-17  Tom de Vries  <tdevries@suse.de>
6257
6258         PR gdb/24094
6259         * dwarf2read.c (struct cu_partial_die_info): New struct.
6260         (find_partial_die): Return cu_partial_die_info.
6261         (partial_die_parent_scope, guess_partial_die_structure_name)
6262         (partial_die_info::fixup): Handle new return type of find_partial_die.
6263
6264 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6265
6266         PR breakpoints/24541
6267         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6268         "std::string", simplifying the algorithm.
6269
6270 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6271
6272         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6273         (stap_static_probe_ops::get_probes): Likewise.
6274
6275 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6276
6277         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6278         '-')" and "else if".
6279         (stap_parse_single_operand): Join checks for
6280         "gdbarch_stap_parse_special_token_p" and
6281         "gdbarch_stap_parse_special_token" in the same "if" statement.
6282         Invert check when verifying for operation on register
6283         displacement.
6284
6285 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6286
6287         * stap-probe.c (stap_get_opcode): Update comment.
6288         (stap_get_expected_argument_type): Likewise.
6289         (handle_stap_probe): Likewise.
6290
6291 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6292
6293         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6294         return type to 'bool'.  Adjust comment.  Use 'bool' when
6295         appropriate.
6296         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6297         * stap-probe.c (stap_parse_argument_1): Likewise.
6298         (stap_is_operator): Likewise.
6299         (stap_is_generic_prefix): Likewise.
6300         (stap_is_register_prefix): Likewise.
6301         (stap_is_register_indirection_prefix): Likewise.
6302         (stap_is_integer_prefix): Likewise.
6303         (stap_generic_check_suffix): Likewise.
6304         (stap_check_integer_suffix): Likewise.
6305         (stap_check_register_suffix): Likewise.
6306         (stap_check_register_indirection_suffix): Likewise.
6307         (stap_parse_register_operand): Likewise.
6308         (stap_parse_single_operand): Likewise.
6309         (stap_parse_argument_1): Likewise.
6310         (stap_probe::get_argument_count): Likewise.
6311         (stap_is_operator): Likewise.
6312
6313 2019-05-16  Tom Tromey  <tromey@adacore.com>
6314
6315         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6316         keyword to foreach.
6317
6318 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6319
6320         * linux-thread-db.c (try_thread_db_load_1): Change return type
6321         to bool.
6322         (try_thread_db_load): Likewise.
6323         (try_thread_db_load_from_pdir_1): Likewise.
6324         (try_thread_db_load_from_pdir): Likewise.
6325         (try_thread_db_load_from_sdir): Likewise.
6326         (try_thread_db_load_from_dir): Likewise.
6327         (thread_db_load_search): Likewise.
6328         (has_libpthread): Likewise.
6329         (thread_db_load): Likewise.
6330
6331 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6332
6333         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6334         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6335         NULL, and complain/return if that's the case.
6336
6337 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6338
6339         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6340         (advance, posn, abstract_read_memory): New functions.
6341         [struct mem_read_abstraction]: New struct.
6342         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6343
6344 2019-05-14  Tom Tromey  <tromey@adacore.com>
6345
6346         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6347         value is not lval_memory.
6348
6349 2019-05-14  Tom Tromey  <tromey@adacore.com>
6350
6351         * solib.c (info_sharedlibrary_command): Style the file name.
6352
6353 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6354
6355         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6356         (aarch64_vnv_type): Likewise.
6357         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6358         * common/tdesc.c: Likewise.
6359         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6360         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6361         * features/aarch64-fpu.xml: Add ieee half view.
6362         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6363         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6364         * gdbtypes.h (struct builtin_type): Likewise.
6365         (struct objfile_type): Likewise.
6366
6367 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6368
6369         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6370         typo.
6371         * location.h (string_to_event_location): Likewise.
6372
6373 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6374
6375         GDB 8.3 released.
6376
6377 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6378
6379         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6380         New variable declaration.
6381         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6382         New variable.
6383         (print_one_breakpoint): Use ui_out::test_flags and new global
6384         variable to compute use_fixed_output.
6385         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6386         Remove.
6387         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6388         (mi_multi_location_breakpoint_output_fixed): Remove.
6389         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6390         new variable.
6391         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6392         fix_multi_location_breakpoint_output flag if version >= 3.
6393         * ui-out.h (enum ui_out_flag)
6394         <fix_multi_location_breakpoint_output>: New enumerator.
6395
6396 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6397
6398         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6399
6400 2019-05-10  Tom Tromey  <tromey@adacore.com>
6401
6402         * ada-lang.c (catch_ada_completer): New function.
6403         (_initialize_ada_language): Use it.
6404
6405 2019-05-10  Tom Tromey  <tromey@adacore.com>
6406
6407         * thread.c (print_thread_info): Make "requested_threads" const.
6408         * gdbthread.h (print_thread_info): Make "requested_threads"
6409         const.
6410         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6411         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6412
6413 2019-05-08  Tom Tromey  <tom@tromey.com>
6414
6415         * gdbtypes.c (objfile_type_data): Change type.
6416         (objfile_type, _initialize_gdbtypes): Update.
6417
6418 2019-05-08  Tom Tromey  <tom@tromey.com>
6419
6420         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6421         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6422         (_initialize_dwarf2_frame): Update.
6423
6424 2019-05-08  Tom Tromey  <tom@tromey.com>
6425
6426         * objc-lang.c (objc_objfile_data): Change type.
6427         (find_methods): Update.
6428         (_initialize_objc_lang): Remove.
6429
6430 2019-05-08  Tom Tromey  <tom@tromey.com>
6431
6432         * stabsread.c (rs6000_builtin_type_data): Change type.
6433         (rs6000_builtin_type, _initialize_stabsread): Update.
6434
6435 2019-05-08  Tom Tromey  <tom@tromey.com>
6436
6437         * mips-tdep.c (mips_pdr_data): Remove.
6438         (_initialize_mips_tdep): Update.
6439
6440 2019-05-08  Tom Tromey  <tom@tromey.com>
6441
6442         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6443         (hppa_init_objfile_priv_data, read_unwind_info)
6444         (find_unwind_entry, _initialize_hppa_tdep): Update.
6445
6446 2019-05-08  Tom Tromey  <tom@tromey.com>
6447
6448         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6449         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6450         on obstack.
6451         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6452
6453 2019-05-08  Tom Tromey  <tom@tromey.com>
6454
6455         * mdebugread.c (basic_type_data): Change type.
6456         (basic_type, _initialize_mdebugread): Update.
6457
6458 2019-05-08  Tom Tromey  <tom@tromey.com>
6459
6460         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6461
6462 2019-05-08  Tom Tromey  <tom@tromey.com>
6463
6464         * nto-tdep.c (nto_inferior_data_reg): Change type.
6465         (nto_inferior_data): Update.
6466         (nto_inferior_data_cleanup, nto_new_inferior_data)
6467         (_initialize_nto_tdep): Remove.
6468         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6469
6470 2019-05-08  Tom Tromey  <tom@tromey.com>
6471
6472         * ada-lang.c (struct ada_inferior_data): Add initializers.
6473         (ada_inferior_data): Change type.
6474         (ada_inferior_data_cleanup): Remove.
6475         (get_ada_inferior_data, ada_inferior_exit)
6476         (struct ada_pspace_data): Add initializers, destructor.
6477         (ada_pspace_data_handle): Change type.
6478         (get_ada_pspace_data): Update.
6479         (ada_pspace_data_cleanup): Remove.
6480
6481 2019-05-08  Tom Tromey  <tom@tromey.com>
6482
6483         * coffread.c (struct coff_symfile_info): Add initializers.
6484         (coff_objfile_data_key): Move lower.  Change type.
6485         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6486         Update.
6487         (coff_free_info): Remove.
6488
6489 2019-05-08  Tom Tromey  <tom@tromey.com>
6490
6491         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6492         (fbsd_pspace_data_handle): Move lower.  Change type.
6493         (get_fbsd_pspace_data): Update.
6494         (fbsd_pspace_data_cleanup): Remove.
6495         (_initialize_fbsd_tdep): Update.
6496
6497 2019-05-08  Tom Tromey  <tom@tromey.com>
6498
6499         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6500         (get_ada_tasks_pspace_data): Update.
6501         (ada_tasks_pspace_data_cleanup): Remove.
6502         (_initialize_tasks): Update.
6503         (ada_tasks_inferior_data_handle): Change type.
6504         (get_ada_tasks_inferior_data): Update.
6505         (ada_tasks_inferior_data_cleanup): Remove.
6506         (struct ada_tasks_pspace_data): Add initializers.
6507
6508 2019-05-08  Tom Tromey  <tom@tromey.com>
6509
6510         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6511         * symfile-debug.c (debug_sym_get_probes): Change type.
6512         * stap-probe.c (handle_stap_probe):
6513         (stap_static_probe_ops::get_probes): Change type.
6514         * probe.h (class static_probe_ops) <get_probes>: Change type.
6515         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6516         (parse_probes_in_pspace): Update.
6517         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6518         Update.
6519         (any_static_probe_ops::get_probes): Change type.
6520         * elfread.c (elfread_data): New typedef.
6521         (probe_key): Change type.
6522         (elf_get_probes): Likewise.  Update.
6523         (probe_key_free): Remove.
6524         (_initialize_elfread): Update.
6525         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6526         Change type.
6527         (dtrace_process_dof_probe, dtrace_process_dof)
6528         (dtrace_static_probe_ops::get_probe): Change type.
6529
6530 2019-05-08  Tom Tromey  <tom@tromey.com>
6531
6532         * xcoffread.c (struct xcoff_symfile_info): Rename from
6533         coff_symfile_info.  Add initializers.
6534         (xcoff_objfile_data_key): Move lower.  Change type.
6535         (XCOFF_DATA): Rewrite.
6536         (xcoff_free_info): Remove.
6537         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6538         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6539         (xcoff_initial_scan): Update.
6540
6541 2019-05-08  Tom Tromey  <tom@tromey.com>
6542
6543         * solib-svr4.c (struct svr4_info): Add initializers and
6544         destructor.
6545         <probes_table>: Now an htab_up.
6546         (solib_svr4_pspace_data): Change type.
6547         (free_probes_table): Simplify.
6548         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6549         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6550         (probes_table_remove_objfile_probes, register_solib_event_probe)
6551         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6552         (_initialize_svr4_solib): Update.
6553
6554 2019-05-08  Tom Tromey  <tom@tromey.com>
6555
6556         * remote.c (remote_pspace_data): Change type.
6557         (remote_pspace_data_cleanup): Remove.
6558         (get_remote_exec_file, set_pspace_remote_exec_file)
6559         (_initialize_remote): Update.
6560
6561 2019-05-08  Tom Tromey  <tom@tromey.com>
6562
6563         * breakpoint.c (breakpoint_objfile_key): Change type.
6564         (get_breakpoint_objfile_data): Update.
6565         (free_breakpoint_objfile_data): Remove.
6566         (_initialize_breakpoint): Update.
6567
6568 2019-05-08  Tom Tromey  <tom@tromey.com>
6569
6570         * linux-tdep.c (struct linux_info): Add initializers.
6571         (linux_inferior_data): Move.  Change type.
6572         (invalidate_linux_cache_inf): Update.
6573         (linux_inferior_data_cleanup): Remove.
6574         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6575
6576 2019-05-08  Tom Tromey  <tom@tromey.com>
6577
6578         * auxv.c (auxv_inferior_data): Move.  Change type.
6579         (auxv_inferior_data_cleanup): Remove.
6580         (invalidate_auxv_cache_inf): Rewrite.
6581         (get_auxv_inferior_data, _initialize_auxv): Update.
6582
6583 2019-05-08  Tom Tromey  <tom@tromey.com>
6584
6585         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6586         (symfile_debug_objfile_data_key): Change type.
6587         (symfile_debug_installed, debug_qf_has_symbols)
6588         (debug_qf_find_last_source_symtab)
6589         (debug_qf_forget_cached_source_info)
6590         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6591         (debug_qf_print_stats, debug_qf_dump)
6592         (debug_qf_expand_symtabs_for_function)
6593         (debug_qf_expand_all_symtabs)
6594         (debug_qf_expand_symtabs_with_fullname)
6595         (debug_qf_map_matching_symbols)
6596         (debug_qf_expand_symtabs_matching)
6597         (debug_qf_find_pc_sect_compunit_symtab)
6598         (debug_qf_map_symbol_filenames)
6599         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6600         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6601         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6602         (debug_sym_read_linetable, debug_sym_relocate): Update.
6603         (symfile_debug_free_objfile): Remove.
6604         (install_symfile_debug_logging, _initialize_symfile_debug):
6605         Update.
6606
6607 2019-05-08  Tom Tromey  <tom@tromey.com>
6608
6609         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6610         allocate_on_obstack.
6611         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6612         (get_dwarf2_per_objfile): Update.
6613         (set_dwarf2_per_objfile): Remove.
6614         (dwarf2_has_info, dwarf2_get_section_info): Update.
6615         (dwarf2_free_objfile): Remove.
6616         (_initialize_dwarf2_read): Update.
6617
6618 2019-05-08  Tom Tromey  <tom@tromey.com>
6619
6620         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6621         initializers.
6622         <unsupported_script_warning_printed,
6623         script_not_found_warning_printed>: Now bool.
6624         (auto_load_pspace_data): Change type.
6625         (~auto_load_pspace_info): Rename from
6626         auto_load_pspace_data_cleanup.
6627         (get_auto_load_pspace_data, init_loaded_scripts_info)
6628         (clear_section_scripts, maybe_print_unsupported_script_warning)
6629         (maybe_print_script_not_found_warning, _initialize_auto_load):
6630         Update.
6631
6632 2019-05-08  Tom Tromey  <tom@tromey.com>
6633
6634         * objfiles.c (objfile_pspace_info): Add destructor and
6635         initializers.
6636         (objfiles_pspace_data): Change type.
6637         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6638         (get_objfile_pspace_data): Update.
6639         (objfiles_bfd_data): Change type.
6640         (get_objfile_bfd_data): Update.
6641         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6642
6643 2019-05-08  Tom Tromey  <tom@tromey.com>
6644
6645         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6646         Change type.
6647         (get_catch_syscall_inferior_data): Update.
6648         (catch_syscall_inferior_data_cleanup): Remove.
6649         (_initialize_break_catch_syscall): Update.
6650
6651 2019-05-08  Tom Tromey  <tom@tromey.com>
6652
6653         * inflow.c (struct terminal_info): Add destructor and
6654         initializers.
6655         (inflow_inferior_data): Change type.
6656         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6657         (get_inflow_inferior_data, inflow_inferior_exit)
6658         (swap_terminal_info, _initialize_inflow): Update.
6659
6660 2019-05-08  Tom Tromey  <tom@tromey.com>
6661
6662         * target-dcache.c (target_dcache_cleanup): Remove.
6663         (target_dcache_aspace_key): Change type.
6664         (target_dcache_init_p, target_dcache_invalidate)
6665         (target_dcache_get, target_dcache_get_or_init)
6666         (_initialize_target_dcache): Update.
6667         * dcache.h (struct dcache_deleter): New.
6668
6669 2019-05-08  Tom Tromey  <tom@tromey.com>
6670
6671         * symtab.c (struct symbol_cache): Add destructor and
6672         initializers.
6673         (symbol_cache_key): Move.  Change type.
6674         (make_symbol_cache, free_symbol_cache): Remove.
6675         (get_symbol_cache): Update.
6676         (symbol_cache_cleanup): Remove.
6677         (ALL_PSPACES, symbol_cache_flush)
6678         (maintenance_print_symbol_cache)
6679         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6680         Update.
6681
6682 2019-05-08  Tom Tromey  <tom@tromey.com>
6683
6684         * symtab.c (struct main_info): Add destructor and initializers.
6685         (main_progspace_key): Move.  Change type.
6686         (get_main_info): Update.
6687         (main_info_cleanup): Remove.
6688         (_initialize_symtab): Update.
6689
6690 2019-05-08  Tom Tromey  <tom@tromey.com>
6691
6692         * registry.h (DECLARE_REGISTRY): Define the _key class.
6693
6694 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6695
6696         * NEWS: Merge two 'New commands' sections.
6697
6698 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6699
6700         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6701         parameter and use Ada language definition instead.
6702         (ada_val_print_ptr): Remove unused language parameter.
6703         (ada_val_print_num): Remove language parameter and use Ada language
6704         definition instead.
6705         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6706         parameter.
6707         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6708         parameter and use Ada language definition instead.
6709         (ada_val_print_1): Update all ada_val_print_xxx calls.
6710         Remove language parameter.
6711         (ada_val_print): Update ada_val_print_1 call.
6712
6713 2019-05-08  Tom Tromey  <tromey@adacore.com>
6714
6715         * remote.c (remote_hw_watchpoint_limit)
6716         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6717         Now static.
6718
6719 2019-05-08  Tom Tromey  <tromey@adacore.com>
6720
6721         * maint.c (_initialize_maint_cmds): Move initialization code to
6722         remote.c.
6723         (watchdog, show_watchdog): Move to remote.c.
6724         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6725         "watchdog" static.
6726         (_initialize_remote): Move initialization code from maint.c.
6727         * defs.h (watchdog): Don't declare.
6728
6729 2019-05-08  Tom Tromey  <tromey@adacore.com>
6730
6731         * tui/tui-interp.c: Include main.h.
6732         * interps.c: Include main.h.
6733         * main.h (interpreter_p): Declare.
6734         * defs.h (interpreter_p): Don't declare.
6735
6736 2019-05-08  Tom Tromey  <tromey@adacore.com>
6737
6738         * dwarf2loc.c: Include dwarf2read.h.
6739         * defs.h (read_unsigned_leb128): Don't declare.
6740         * dwarf2read.h (read_unsigned_leb128): Declare.
6741
6742 2019-05-08  Tom Tromey  <tromey@adacore.com>
6743
6744         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6745         method.
6746
6747 2019-05-08  Tom Tromey  <tromey@adacore.com>
6748
6749         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6750         when no wrap column is set.
6751
6752 2019-05-08  Tom Tromey  <tromey@adacore.com>
6753
6754         * c-lang.c (c_get_string): Handle non-C-style arrays.
6755
6756 2019-05-08  Tom Tromey  <tromey@adacore.com>
6757
6758         * typeprint.c (print_offset_data::update): Print the bit offset,
6759         not the number of bits remaining.
6760
6761 2019-05-08  Tom Tromey  <tromey@adacore.com>
6762
6763         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6764         padding at end of comment.
6765
6766 2019-05-08  Tom Tromey  <tromey@adacore.com>
6767
6768         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6769         Compare main types.
6770
6771 2019-05-06  Tom Tromey  <tom@tromey.com>
6772
6773         * common/scoped_mmap.c: Include common-defs.h.
6774         * common/scoped_mmap.h: Don't include config.h.
6775
6776 2019-05-04  Tom Tromey  <tom@tromey.com>
6777
6778         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6779         (struct aarch64_call_info): Add initializers.
6780         <si>: Now a std::vector.
6781         (pass_on_stack, aarch64_push_dummy_call): Update.
6782
6783 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6784             Tom Tromey  <tom@tromey.com>
6785
6786         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6787         (ppc_threads): Now a std::vector.  Now static.
6788         (hwdebug_find_thread_points_by_tid)
6789         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6790         Update.
6791
6792 2019-05-04  Tom Tromey  <tom@tromey.com>
6793
6794         * arc-tdep.c (arc_tdesc_init): Return bool.
6795
6796 2019-05-04  Tom Tromey  <tom@tromey.com>
6797
6798         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6799         Use gdb_assert_not_reached.
6800
6801 2019-05-04  Tom Tromey  <tom@tromey.com>
6802
6803         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6804         "false".
6805
6806 2019-05-04  Tom Tromey  <tom@tromey.com>
6807
6808         * arc-tdep.c (arc_tdesc_init): Use bool.
6809
6810 2019-05-04  Tom Tromey  <tom@tromey.com>
6811
6812         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6813
6814 2019-05-04  Tom Tromey  <tom@tromey.com>
6815
6816         * cli/cli-cmds.c (valid_command_p): Return bool.
6817
6818 2019-05-04  Tom Tromey  <tom@tromey.com>
6819
6820         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6821         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6822
6823 2019-05-04  Raul Tambre  <raul@tambre.ee>
6824
6825         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6826         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6827         operator for comparison.
6828
6829 2019-05-04  Tom Tromey  <tom@tromey.com>
6830
6831         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6832         (lookup_partial_symbol, print_partial_symbols)
6833         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6834         (psymbol_compare): Update.
6835         (add_psymbol_to_bcache): Clear the entire psymbol.
6836         (maintenance_check_psymtabs): Update.
6837         * psympriv.h (struct partial_symbol): Don't derive from
6838         general_symbol_info.
6839         <obj_section, unrelocated_address, address,
6840         set_unrelocated_address>: Update.
6841         <ginfo>: New member.
6842         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6843         (debug_names::write_psymbols): Update.
6844
6845 2019-05-04  Tom de Vries  <tdevries@suse.de>
6846
6847         * contrib/cc-with-tweaks.sh: Support -n arg.
6848
6849 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6850
6851         * corelow.c (core_target::detach): Ensure frame cache and
6852         register caches are cleared.
6853         inferior.c (exit_inferior_1): Likewise.
6854
6855 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6856             Tom Tromey  <tom@tromey.com>
6857
6858         * dictionary.c (collate_pending_symbols_by_language): Remove
6859         "struct" from foreach.
6860         * symtab.c (lookup_global_symbol_from_objfile)
6861         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6862         foreach.
6863         * ser-tcp.c (net_open): Remove "struct" from foreach.
6864         * objfiles.c (objfile_relocate, objfile_rebase)
6865         (objfile_has_symbols): Remove "struct" from foreach.
6866         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6867         from foreach.
6868         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6869         foreach.
6870         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6871         "struct" from foreach.
6872         * ada-lang.c (create_excep_cond_exprs)
6873         (ada_exception_catchpoint_cond_string): Remove "struct" from
6874         foreach.
6875
6876 2019-05-03  Tom Tromey  <tromey@adacore.com>
6877
6878         * ada-exp.y (convert_char_literal): Check suffix of each
6879         enumerator.
6880
6881 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6882
6883         PR ada/21406:
6884         * ada-exp.y (yywrap): Don't define.
6885         * ada-lex.l (%option): Add noyywrap
6886         (yywrap): Remove.
6887
6888 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6889
6890         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6891         _WIN32_WINNT to the XP level, unless already defined to a higher
6892         level.
6893
6894         * unittests/parse-connection-spec-selftests.c:
6895         * ser-tcp.c:
6896         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6897         override.
6898
6899         * symfile.c (find_separate_debug_file): Remove colon from the
6900         drive spec of DOS/Windows file names of the target, so that the
6901         file name produced from DEBUGDIR and the target's directory will
6902         be valid on DOS/Windows systems.
6903
6904 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6905
6906         * rust-lang.c (val_print_struct): Handle printing structures
6907         containing strings.
6908
6909 2019-05-02  Tom Tromey  <tromey@adacore.com>
6910
6911         * valarith.c (_initialize_valarith): Remove.
6912
6913 2019-05-01  Tom Tromey  <tromey@adacore.com>
6914
6915         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6916         bitfields.
6917
6918 2019-05-01  Tom Tromey  <tromey@adacore.com>
6919
6920         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6921         for big-endian copies.
6922
6923 2019-04-30  Ali Tamur  <tamur@google.com>
6924         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6925         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6926         (read_3_bytes): New function.
6927
6928 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6929
6930         * windows-nat.c (main_thread_id): Delete.
6931         (handle_output_debug_string): Replace main_thread_id by
6932         current_event.dwThreadId.
6933         (fake_create_process): Likewise.
6934         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6935         Do not set main_thread_id.
6936         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6937         current_event.dwThreadId.
6938         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6939
6940 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6941
6942         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6943         Use current_event.dwThreadId instead of main_thread_id.
6944
6945 2019-04-30  Tom Tromey  <tromey@adacore.com>
6946
6947         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6948         (create_excep_cond_exprs): Iterate over program spaces.
6949         (ada_exception_catchpoint_cond_string): Examine all minimal
6950         symbols for exception types.
6951
6952 2019-04-30  Tom Tromey  <tromey@adacore.com>
6953
6954         PR c++/24470:
6955         * dwarf2read.c (process_structure_scope): Handle case where type
6956         has template parameters but no symbol was created.
6957
6958 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6959             Chris January  <chris.january@arm.com>
6960
6961         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6962         qualifier.
6963         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6964
6965 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6966
6967         * f-typeprint.c (f_print_type): Update rules for printing
6968         whitespace.
6969         (f_type_print_varspec_suffix): Likewise.
6970
6971 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6972             Chris January  <chris.january@arm.com>
6973
6974         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6975         function arguments.
6976
6977 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6978
6979         * f-lang.c (build_fortran_types): Change name of void type to
6980         lower case.
6981         * f-typeprint.c (f_type_print_base): Print the name of the void
6982         type, rather than a fixed string.
6983         * f-valprint.c (f_decorations): Use lower case void string.
6984
6985 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6986             Chris January  <chris.january@arm.com>
6987
6988         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6989         types for Fortran.
6990
6991 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6992             Chris January  <chris.january@arm.com>
6993             David Lecomber  <david.lecomber@arm.com>
6994
6995         * f-exp.y (BINOP_INTRINSIC): New token.
6996         (exp): New parser rule handling BINOP_INTRINSIC.
6997         (f77_keywords): Add new builtin procedures.
6998         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6999         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7000         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7001         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7002         (print_unop_subexp_f): New function.
7003         (print_binop_subexp_f): New function.
7004         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7005         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7006         (dump_subexp_body_f): Likewise.
7007         (operator_check_f): Likewise.
7008         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7009         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7010
7011 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7012
7013         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7014         UNOP_KIND.
7015         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7016         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7017         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7018         (operator_length_f): New fuction.
7019         (print_subexp_f): New function.
7020         (op_name_f): New function.
7021         (dump_subexp_body_f): New function.
7022         (operator_check_f): New function.
7023         (exp_descriptor_f): Replace standard expression handling functions
7024         with new functions.
7025         * gdb/fortran-operator.def: New file.
7026         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7027         * gdb/std-operator.def: Remove UNOP_KIND.
7028
7029 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * std-operator.def: Remove unbalanced, stray double quote
7032         character.
7033
7034 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7035             Chris January  <chris.january@arm.com>
7036             Daniel Everett  <daniel.everett@arm.com>
7037             Nick Forrington  <nick.forrington@arm.com>
7038             Richard Bunt  <richard.bunt@arm.com>
7039
7040         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7041         of depth when printing anonymous structs or unions.
7042         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7043         Don't print either the top-level value, or the children if the
7044         max-depth is exceeded.
7045         (ppscm_print_children): When printing the key of a map, allow one
7046         extra level of depth.
7047         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7048         print either the top-level value, or the children if the max-depth
7049         is exceeded.
7050         (print_children): When printing the key of a map, allow one extra
7051         level of depth.
7052         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7053         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7054         (user_print_options): Initialise max_depth field.
7055         (val_print_scalar_or_string_type_p): New function.
7056         (val_print): Check to see if the max depth has been reached.
7057         (val_print_check_max_depth): Define new function.
7058         (show_print_max_depth): New function.
7059         (_initialize_valprint): Add 'print max-depth' option.
7060         * valprint.h (struct value_print_options) <max_depth>: New field.
7061         (val_print_check_max_depth): Declare new function.
7062         * NEWS: Document new feature.
7063
7064 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * ada-lang.c (ada_language_defn): Initialise new field.
7067         * c-lang.c (c_is_string_type_p): New function.
7068         (c_language_defn): Initialise new field.
7069         (cplus_language_defn): Initialise new field.
7070         (asm_language_defn): Initialise new field.
7071         (minimal_language_defn): Initialise new field.
7072         * c-lang.h (c_is_string_type_p): Declare new function.
7073         * d-lang.c (d_language_defn): Initialise new field.
7074         * f-lang.c (f_is_string_type_p): New function.
7075         (f_language_defn): Initialise new field.
7076         * go-lang.c (go_is_string_type_p): New function.
7077         (go_language_defn): Initialise new field.
7078         * language.c (default_is_string_type_p): New function.
7079         (unknown_language_defn): Initialise new field.
7080         (auto_language_defn): Initialise new field.
7081         * language.h (struct language_defn) <la_is_string_type_p>: New
7082         member variable.
7083         (default_is_string_type_p): Declare new function.
7084         * m2-lang.c (m2_language_defn): Initialise new field.
7085         * objc-lang.c (objc_language_defn): Initialise new field.
7086         * opencl-lang.c (opencl_language_defn): Initialise new field.
7087         * p-lang.c (pascal_is_string_type_p): New function.
7088         (pascal_language_defn): Initialise new field.
7089         * rust-lang.c (rust_is_string_type_p): New function.
7090         (rust_language_defn): Initialise new field.
7091
7092 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7093
7094         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7095         New field.
7096         * ada-lang.c (ada_language_defn): Initialise new field.
7097         * c-lang.c (c_language_defn): Likewise.
7098         (cplus_language_defn): Likewise.
7099         (asm_language_defn): Likewise.
7100         (minimal_language_defn): Likewise.
7101         * d-lang.c (d_language_defn): Likewise.
7102         * f-lang.c (f_language_defn): Likewise.
7103         * go-lang.c (go_language_defn): Likewise.
7104         * language.c (unknown_language_defn): Likewise.
7105         (auto_language_defn): Likewise.
7106         * m2-lang.c (m2_language_defn): Likewise.
7107         * objc-lang.c (objc_language_defn): Likewise.
7108         * opencl-lang.c (opencl_language_defn): Likewise.
7109         * p-lang.c (pascal_language_defn): Likewise.
7110         * rust-lang.c (rust_language_defn): Likewise.
7111
7112 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * ada-lang.c (ada_is_character_type): Change return type to bool.
7115         (ada_is_string_type): Likewise.
7116         * ada-lang.h (ada_is_character_type): Update declaration
7117         (ada_is_string_type): Likewise.
7118
7119 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7120
7121         Support style in 'frame|thread apply'
7122
7123         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7124         * record.c (record_start, record_stop): Update callers of
7125         execute_command_to_string with false.
7126         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7127         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7128         methods.
7129         (class string_file): New constructor with term_out parameter.
7130         Override methods term_out and can_emit_style_escape.  New member
7131         term_out.
7132         (class stdio_file): Override can_emit_style_escape.
7133         (class tee_file): Override term_out and can_emit_style_escape.
7134         * utils.h (can_emit_style_escape): Remove.
7135         * utils.c (can_emit_style_escape): Likewise.
7136         Update all callers of can_emit_style_escape (SOMESTREAM) to
7137         SOMESTREAM->can_emit_style_escape.
7138         * source-cache.c (source_cache::get_source_lines): Likewise.
7139         * stack.c (frame_apply_command_count): Call execute_command_to_string
7140         passing the term_out characteristic of the current gdb_stdout.
7141         * thread.c (thr_try_catch_cmd): Likewise.
7142         * top.c (execute_command_to_string): pass term_out parameter
7143         to construct the string_file for the command output.
7144         * ui-file.c (term_cli_styling): New function (most code moved
7145         from utils.c can_emit_style_escape).
7146         (string_file::string_file, string_file::can_emit_style_escape,
7147         stdio_file::can_emit_style_escape, tee_file::term_out,
7148         tee_file::can_emit_style_escape): New functions.
7149
7150 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7151
7152         * NEWS: Mention the new set|show may-call-functions.
7153         * infcall.c (may_call_functions_p): New variable.
7154         (show_may_call_functions_p): New function.
7155         (call_function_by_hand_dummy): Throws an error if not
7156         may-call-functions.
7157         (_initialize_infcall): Call add_setshow_boolean_cmd for
7158         may-call-functions.
7159
7160 2019-04-25  Keith Seitz  <keiths@redhat.com>
7161
7162         PR c++/24367
7163         * cp-support.c (inspect_type): Don't attempt substitutions
7164         of symbol with the same name.
7165
7166 2019-04-25  Tom Tromey  <tromey@adacore.com>
7167
7168         PR gdb/24475:
7169         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7170         static.
7171
7172 2019-04-25  Tom Tromey  <tromey@adacore.com>
7173
7174         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7175         rvalue reference.
7176         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7177         (gdb_xml_parser::parse): Use std::move.
7178         * python/python-internal.h (gdbpy_convert_exception): Take a const
7179         reference.
7180         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7181         std::move.
7182         * python/py-utils.c (gdbpy_convert_exception): Take a const
7183         reference.
7184         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7185         Use std::move.
7186         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7187         Use std::move.
7188         * mi/mi-main.c (mi_print_exception): Take a const reference.
7189         * main.c (handle_command_errors): Take a const reference.
7190         * linespec.c (parse_linespec): Use std::move.
7191         * infcall.c (run_inferior_call): Use std::move.
7192         (call_function_by_hand_dummy): Use std::move.
7193         * exec.c (try_open_exec_file): Use std::move.
7194         * exceptions.h (exception_print, exception_fprintf)
7195         (exception_print_same): Update.
7196         * exceptions.c (print_exception, exception_print)
7197         (exception_fprintf, exception_print_same): Change parameters to
7198         const reference.
7199         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7200         * common/new-op.c: Use std::move.
7201         * common/common-exceptions.h (struct gdb_exception): Add move
7202         constructor.
7203         (struct gdb_exception_error, struct gdb_exception_quit, struct
7204         gdb_quit_bad_alloc): Change constructor to move constructor.
7205         (throw_exception): Change parameter to rvalue reference.
7206         * common/common-exceptions.c (throw_exception): Take rvalue
7207         reference.
7208         * cli/cli-interp.c (safe_execute_command): Use std::move.
7209         * breakpoint.c (insert_bp_location, location_to_sals): Use
7210         std::move.
7211
7212 2019-04-25  Tom Tromey  <tromey@adacore.com>
7213
7214         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7215         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7216         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7217         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7218         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7219         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7220         guile/scm-value.c: Use unpack.
7221         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7222         gdbscm_gdb_exception.
7223         (gdbscm_throw_gdb_exception): Likewise.
7224         (struct gdbscm_gdb_exception): New.
7225         (unpack): New function.
7226         (gdbscm_wrap): Use unpack.
7227
7228 2019-04-25  Tom Tromey  <tromey@adacore.com>
7229
7230         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7231         (gdb_rl_callback_handler): Use std::move.
7232         * common/common-exceptions.h (struct gdb_exception): Add move
7233         assignment operator.
7234         (throw_exception_sjlj): Change "exception" to const reference.
7235         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7236         (throw_exception_sjlj): Change "exception" to const reference.
7237
7238 2019-04-25  Tom Tromey  <tromey@adacore.com>
7239
7240         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7241         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7242         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7243         Update.
7244         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7245         Update.
7246         * mi/mi-interp.c (mi_interp::exec): Update.
7247         * linespec.c (parse_linespec): Update.
7248         * infcall.c (run_inferior_call): Update.
7249         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7250         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7251         (gdbscm_lookup_global_symbol): Update.
7252         * guile/scm-param.c (gdbscm_parameter_value): Update.
7253         * guile/scm-frame.c (gdbscm_frame_read_register)
7254         (gdbscm_frame_read_var): Update.
7255         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7256         * exec.c (try_open_exec_file): Update.
7257         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7258         (gdb_rl_callback_handler): Update.
7259         * common/common-exceptions.h (exception_none): Don't declare.
7260         * common/common-exceptions.c (exception_none): Don't define.
7261         (struct catcher) <exception>: Update.
7262         * cli/cli-interp.c (safe_execute_command): Update.
7263         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7264
7265 2019-04-25  Ali Tamur  <tamur@google.com>
7266
7267         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7268         (read_attribute_value): Likewise.
7269         (dwarf2_read_addr_index): Update comment.
7270         (read_str_index): Add DW_FORM_strx.
7271         (dwarf2_string_attr): Likewise.
7272         (dwarf2_const_value_attr): Likewise.
7273         (dump_die_shallow): Likewise.
7274         (dwarf2_fetch_constant_bytes): Likewise.
7275         (skip_form_bytes): Likewise.
7276         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7277
7278 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7279
7280         PR corefiles/11608
7281         PR corefiles/18187
7282         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7283         OFFSET.  Verify if current mapping contains an ELF header.
7284         (linux_find_memory_regions_full): Adjust call to
7285         dump_mapping_p.
7286
7287 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7288             Kang Li <kanglictf@gmail.com>
7289
7290         PR gdb/21600
7291
7292         * dwarf2-frame.c (read_initial_length): Be consistent about using
7293         unsigned representation of length.
7294         (decode_frame_entry_1): Likewise.  Check for wraparound of
7295         end pointer as well as buffer overflow.
7296
7297 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7298
7299         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7300         "vq".
7301
7302 2019-04-24  Tom Tromey  <tromey@adacore.com>
7303
7304         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7305
7306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7307
7308         * s12z-tdep.c (s12z_unwind_pc): Delete.
7309         (s12z_unwind_sp): Delete.
7310         (s12z_gdbarch_init): Don't register deleted functions with
7311         gdbarch.
7312
7313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7314
7315         * rl78-tdep.c (rl78_unwind_sp): Delete.
7316         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7317
7318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7319
7320         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7321         (xstormy16_unwind_pc): Delete.
7322         (xstormy16_dummy_id): Delete.
7323         (xstormy16_gdbarch_init): Don't register deleted functions with
7324         gdbarch.
7325
7326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7327
7328         * vax-tdep.c (vax_unwind_pc): Delete.
7329         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7330
7331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7332
7333         * v850-tdep.c (v850_unwind_sp): Delete.
7334         (v850_unwind_pc): Delete.
7335         (v850_dummy_id): Delete.
7336         (v850_gdbarch_init): Don't register deleted functions with
7337         gdbarch.
7338
7339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7340
7341         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7342         (tilegx_unwind_pc): Delete.
7343         (tilegx_unwind_dummy_id): Delete.
7344         (tilegx_gdbarch_init): Don't register deleted functions with
7345         gdbarch.
7346
7347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7348
7349         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7350         (tic6x_dummy_id): Delete.
7351         (tic6x_gdbarch_init): Don't register deleted functions with
7352         gdbarch.
7353
7354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7355
7356         * sparc-tdep.c (sparc_unwind_pc): Delete.
7357         (sparc32_gdbarch_init): Don't register deleted function with
7358         gdbarch.
7359
7360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7361
7362         * sh-tdep.c (sh_unwind_sp): Delete.
7363         (sh_unwind_pc): Delete.
7364         (sh_dummy_id): Delete.
7365         (sh_gdbarch_init): Don't register deleted functions with
7366         gdbarch.
7367
7368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7369
7370         * score-tdep.c (score_unwind_sp): Delete.
7371         (score_unwind_pc): Delete.
7372         (score_dummy_id): Delete.
7373         (score_gdbarch_init): Don't register deleted functions with
7374         gdbarch.
7375
7376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7377
7378         * rx-tdep.c (rx_unwind_pc): Delete.
7379         (rx_unwind_sp): Delete.
7380         (rx_dummy_id): Delete.
7381         (rx_gdbarch_init): Don't register deleted functions with
7382         gdbarch.  Update comment.
7383
7384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7385
7386         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7387         (rs6000_dummy_id): Delete.
7388         (rs6000_gdbarch_init): Don't register deleted functions with
7389         gdbarch.
7390
7391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7392
7393         * or1k-tdep.c (or1k_dummy_id): Delete.
7394         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7395
7396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7397
7398         * nios2-tdep.c (nios2_dummy_id): Delete.
7399         (nios2_unwind_sp): Delete.
7400         (nios2_gdbarch_init): Don't register deleted functions with
7401         gdbarch.
7402
7403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7404
7405         * nds32-tdep.c (nds32_dummy_id): Delete.
7406         (nds32_unwind_pc): Delete.
7407         (nds32_unwind_sp): Delete.
7408         (nds32_gdbarch_init): Don't register deleted functions with
7409         gdbarch.
7410
7411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7412
7413         * msp430-tdep.c (msp430_unwind_pc): Delete.
7414         (msp430_unwind_sp): Delete.
7415         (msp430_dummy_id): Delete.
7416         (msp430_gdbarch_init): Don't register deleted functions with
7417         gdbarch.
7418
7419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7420
7421         * moxie-tdep.c (moxie_unwind_sp): Delete.
7422         (moxie_unwind_pc): Delete.
7423         (moxie_dummy_id): Delete.
7424         (moxie_gdbarch_init): Don't register deleted functions with
7425         gdbarch.
7426
7427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7428
7429         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7430         (mn10300_unwind_pc): Delete.
7431         (mn10300_unwind_sp): Delete.
7432         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7433         mn10300_unwind_sp.
7434         (mn10300_frame_unwind_init): Don't register deleted functions with
7435         gdbarch.
7436
7437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7438
7439         * mep-tdep.c (mep_unwind_pc): Delete.
7440         (mep_unwind_sp): Delete.
7441         (mep_dummy_id): Delete.
7442         (mep_gdbarch_init): Don't register deleted functions with
7443         gdbarch.
7444
7445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7446
7447         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7448         (m68hc11_unwind_sp): Delete.
7449         (m68hc11_gdbarch_init): Don't register deleted functions with
7450         gdbarch.
7451
7452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7453
7454         * m32r-tdep.c (m32r_unwind_sp): Delete.
7455         (m32r_unwind_pc): Delete.
7456         (m32r_dummy_id): Delete.
7457         (m32r_gdbarch_init): Don't register deleted functions with
7458         gdbarch.
7459
7460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * m32c-tdep.c (m32c_unwind_pc): Delete.
7463         (m32c_unwind_sp): Delete.
7464         (m32c_dummy_id): Delete.
7465         (m32c_gdbarch_init): Don't register deleted functions with
7466         gdbarch.
7467
7468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7469
7470         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7471         (lm32_unwind_pc): Delete.
7472         (lm32_dummy_id): Delete.
7473         (lm32_gdbarch_init): Don't register deleted functions with
7474         gdbarch.
7475
7476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7479         (iq2000_unwind_pc): Delete.
7480         (iq2000_dummy_id): Delete.
7481         (iq2000_gdbarch_init): Don't register deleted functions with
7482         gdbarch.
7483
7484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7485
7486         * nds32-tdep.c (nds32_type_align): Delete.
7487         (nds32_push_dummy_call): Use type_align instead.
7488
7489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7490
7491         * arm-tdep.c (arm_type_align): Only handle vector override case.
7492         (arm_push_dummy_call): Use type_align.
7493         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7494
7495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7498         case.
7499         (pass_on_stack): Use type_align.
7500         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7501         function.
7502
7503 2019-04-23  Tom Tromey  <tromey@adacore.com>
7504
7505         * dwarf2read.c (line_header::file_name_at): Remove unused
7506         overload.
7507
7508 2019-04-23  Tom de Vries  <tdevries@suse.de>
7509
7510         PR gdb/24438
7511         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7512         invocation.
7513
7514
7515 2019-03-27  Ali Tamur  <tamur@google.com>
7516
7517         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7518         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7519         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7520         (dwarf_expr_context::get_addr_index): Likewise
7521         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7522         (symbol_needs_eval_context::get_addr_index): Likewise
7523         (disassemble_dwarf_expression): Add DW_OP_addrx
7524         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7525         (read_cutu_die_from_dwo): Update comment
7526         (skip_one_die): Add DW_FORM_addrx
7527         (read_attribute_value): Likewise
7528         (var_decode_location): Add DW_OP_addrx
7529         (dwarf2_const_value_attr): Add DW_FORM_addrx
7530         (dump_die_shallow): Likewise
7531         (dwarf2_fetch_constant_bytes): Likewise
7532         (decode_locdesc): Add DW_OP_addrx
7533         (skip_form_bytes): Add DW_FORM_addrx
7534
7535 2019-04-22  Ali Tamur  <tamur@google.com>
7536
7537         * MAINTAINERS (Write After Approval): Add self.
7538
7539 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7540
7541         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7542         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7543         (open_symbol_file_object): Likewise.
7544         (svr4_default_sos): Add info parameter.
7545         (svr4_read_so_list): Likewise.
7546         (svr4_current_sos_direct): Adjust functions calls to pass down
7547         info.
7548         (svr4_current_sos_1): Add info parameter.
7549         (svr4_current_sos): Call get_svr4_info, pass info down to
7550         svr4_current_sos_1.
7551         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7552         get_svr4_info.
7553         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7554         get_svr4_info.
7555         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7556         to get_svr4_info.
7557         (probes_table_remove_objfile_probes): Likewise.
7558         (register_solib_event_probe): Add info parameter.
7559         (solist_update_incremental): Pass info parameter down to
7560         svr4_read_so_list.
7561         (disable_probes_interface): Add info parameter.
7562         (svr4_handle_solib_event): Pass current_program_space to
7563         get_svr4_info.  Adjust disable_probes_interface cleanup.
7564         (svr4_create_probe_breakpoints): Add info parameter, pass it
7565         down to register_solib_event_probe.
7566         (svr4_create_solib_event_breakpoints): Add info parameter,
7567         pass it down to svr4_create_probe_breakpoints.
7568         (enable_break): Pass info down to
7569         svr4_create_solib_event_breakpoints.
7570         (svr4_solib_create_inferior_hook): Pass current_program_space to
7571         get_svr4_info.
7572         (svr4_clear_solib): Likewise.
7573
7574 2019-04-22  Pedro Alves  <palves@redhat.com>
7575
7576         * solib-svr4.c (svr4_free_objfile_observer): New.
7577         (probe_and_action::objfile): New field.
7578         (probes_table_htab_remove_objfile_probes)
7579         (probes_table_remove_objfile_probes): New functions.
7580         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7581         in the new probe_and_action.  Don't store the probe in 'lookup'.
7582         (svr4_create_probe_breakpoints): Pass objfile to
7583         register_solib_event_probe.
7584         (_initialize_svr4_solib): Register a free_objfile observer.
7585
7586 2019-04-19  Tom Tromey  <tom@tromey.com>
7587
7588         * common/queue.h: Remove.
7589
7590 2019-04-19  Tom Tromey  <tom@tromey.com>
7591
7592         * event-loop.c: Don't include "common/queue.h".
7593
7594 2019-04-19  Tom Tromey  <tom@tromey.com>
7595
7596         * remote.c (remote_target): Use delete.
7597         * remote-notif.h: Include <list>, not "common/queue.h".
7598         (notif_client_p): Remove typedef.
7599         (remote_notif_state): Add constructor, destructor, initializer.
7600         <notif_queue>: Now a std::list.
7601         (remote_notif_state_xfree): Don't declare.
7602         * remote-notif.c (remote_notif_process, handle_notification)
7603         (remote_notif_state_allocate): Update.
7604         (~remote_notif_state): Rename from remote_notif_state_xfree.
7605
7606 2019-04-19  Tom Tromey  <tom@tromey.com>
7607
7608         * symfile.c (reread_symbols): Update.
7609         * objfiles.c (objfile_register_static_link)
7610         (objfile_lookup_static_link): Update
7611         (~objfile) Don't delete static_links.
7612         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7613
7614 2019-04-19  Tom Tromey  <tom@tromey.com>
7615
7616         * type-stack.h (struct type_stack) <insert>: Constify string.
7617         * type-stack.c (type_stack::insert): Constify string.
7618         * gdbtypes.h (lookup_template_type): Update.
7619         (address_space_name_to_int): Update.
7620         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7621         const.
7622         (lookup_template_type): Make name const.
7623         * c-exp.y: Update rules.
7624         (lex_one_token, classify_name, classify_inner_name)
7625         (c_print_token): Update.
7626         * p-exp.y: Update rules.
7627         (yylex): Update.
7628         * f-exp.y: Update rules.
7629         (yylex): Update.
7630         * d-exp.y: Update rules.
7631         (lex_one_token, classify_name, classify_inner_name): Update.
7632         * parse.c (write_dollar_variable, copy_name): Return std::string.
7633         * parser-defs.h (copy_name): Change return type.
7634         * m2-exp.y: Update rules.
7635         (yylex): Update.
7636         * go-exp.y (lex_one_token): Update.
7637         Update rules.
7638         (classify_unsafe_function, classify_packaged_name)
7639         (classify_name, yylex): Update.
7640
7641 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7642
7643         * configure.ac: add --enable-source-highlight switch.
7644         * configure: Regenerate.
7645         * top.c (print_gdb_version): plumb --enable-source-highlight
7646         status to "show configuration".
7647
7648 2019-04-19  Tom Tromey  <tromey@adacore.com>
7649
7650         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7651         Check ADA_TYPE_P.
7652         (empty_record, ada_template_to_fixed_record_type_1)
7653         (template_to_static_fixed_type)
7654         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7655         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7656         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7657         macros.
7658
7659 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7660
7661         PR symtab/24423:
7662         * source.c (print_source_lines_base): Advance "iter" when a
7663         control character is seen.
7664
7665 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7666
7667         * inferior.h (struct infcall_suspend_state_deleter):
7668         Catch exception in destructor to avoid crash.
7669
7670 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7671
7672         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7673         close to the add_com "shell".
7674
7675 2019-04-18  Tom Tromey  <tromey@adacore.com>
7676
7677         * process-stratum-target.h (class process_stratum_target)
7678         <stratum>: Add "final".
7679
7680 2019-04-17  Tom Tromey  <tromey@adacore.com>
7681
7682         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7683         against nullptr before use.
7684
7685 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7686
7687         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7688
7689 2019-04-17  Jim Wilson  <jimw@sifive.com>
7690             Andrew Burgess  <andrew.burgess@embecosm.com>
7691
7692         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7693         code read might fail, assume 4-byte breakpoint in that case.
7694
7695 2019-04-15  Leszek Swirski  <leszeks@google.com>
7696
7697         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7698         rather than a hand-rolled POD check when checking for forced MEMORY
7699         classification.
7700
7701 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7702
7703         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7704         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7705         function.
7706         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7707         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7708         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7709         declaration.
7710
7711 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7712
7713         * aarch64-linux-nat.c
7714         (aarch64_linux_nat_target::thread_architecture): Add override.
7715         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7716         each VQ.
7717
7718 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7719
7720         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7721
7722 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7723
7724         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7725         target types of size 96-bits, add some additional comments, and
7726         check that the builtin type we found was the correct size.
7727
7728 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7729
7730         * utils.c (prompt_for_continue): Don't restore the styling at the
7731         end, as applied_style has the wrong value.  This fixes styling in
7732         long lists of file names that are interrupted by the "Continue?"
7733         prompt.
7734
7735 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7738         * c-lang.c (c_language_defn): Likewise.
7739         (cplus_language_defn): Likewise.
7740         (asm_language_defn): Likewise.
7741         (minimal_language_defn): Likewise.
7742         * d-lang.c (d_language_defn): Likewise.
7743         * f-lang.c (f_language_defn): Likewise.
7744         * go-lang.c (go_language_defn): Likewise.
7745         * language.c (unknown_language_defn): Likewise.
7746         (auto_language_defn): Likewise.
7747         * language.h (struct language_defn): Remove la_magic field.
7748         (LANG_MAGIC): Delete.
7749         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7750         * objc-lang.c (objc_language_defn): Likewise.
7751         * opencl-lang.c (opencl_language_defn): Likewise.
7752         * p-lang.c (pascal_language_defn): Likewise.
7753         * rust-lang.c (rust_language_defn): Likewise.
7754
7755 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7756
7757         * riscv-tdep.c (riscv_type_align): New function.
7758         (riscv_type_alignment): Delete.
7759         (riscv_arg_location): Use 'type_align'.
7760         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7761
7762 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7763
7764         * gdbtypes.c (type_align): A struct with no non-static fields also
7765         has alignment of 1.
7766
7767 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7770         component to 0.
7771         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7772         member.
7773         (riscv_struct_info::analyse): New implementation using new
7774         analyse_inner member function.
7775         (riscv_struct_info::field_offset): New member function.
7776         (riscv_struct_info::m_offsets): New member variable.
7777         (riscv_struct_info::analyse_inner): New private member function,
7778         takes the old implementation of riscv_struct_info::analyse but
7779         extended to track field offsets.
7780         (riscv_call_arg_struct): Update the struct folding special cases
7781         to handle cases where empty C++ structs, which are non-zero
7782         length, are found.
7783         (riscv_arg_location): Initialise the length of each location, a
7784         non-zero length now indicates the location is in use.
7785         (riscv_push_dummy_call): Allow for the first location having a
7786         non-zero offset when setting up arguments.
7787         (riscv_return_value): Likewise, but for return values.
7788
7789 2019-04-11  Tom Tromey  <tromey@adacore.com>
7790
7791         * utils.c (internal_vproblem): Make "msg" const.
7792
7793 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7794
7795         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7796         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7797         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7798         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7799
7800 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7801
7802         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7803         function.
7804         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7805         of amd64_collect_native_gregset.
7806         (amd64_linux_nat_target::store_registers): Likewise.
7807
7808 2019-04-10  Tom Tromey  <tom@tromey.com>
7809
7810         * symtab.c (lookup_global_symbol_from_objfile)
7811         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7812         * objfiles.h (class separate_debug_iterator): New.
7813         (class separate_debug_range): New.
7814         (struct objfile) <separate_debug_objfiles>: New method.
7815         (objfile_separate_debug_iterate): Don't declare.
7816         * objfiles.c (separate_debug_iterator::operator++): Rename from
7817         objfile_separate_debug_iterate.
7818         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7819         iterator.
7820         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7821         iterator.
7822
7823 2019-04-10  Tom Tromey  <tom@tromey.com>
7824
7825         * symfile.c (reread_symbols): Remove old comment.
7826         * objfiles.c (free_all_objfiles): Fix a typo.
7827
7828 2019-04-10  Tom Tromey  <tom@tromey.com>
7829
7830         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7831         * minsyms.c (lookup_minimal_symbol): Use foreach.
7832         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7833         (lookup_minimal_symbol_solib_trampoline): Likewise.
7834         * symfile.c (reread_symbols): Use foreach.
7835
7836 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7837             Tom Tromey  <tromey@adacore.com>
7838
7839         PR rust/24414:
7840         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7841         (rust_lex_int_test): Change "value" to be LONGEST.
7842         (rust_lex_tests): Add test for long integer literal.
7843
7844 2019-04-09  Tom Tromey  <tromey@adacore.com>
7845
7846         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7847         to bool.
7848         (extended_remote_target::attach): Update.
7849         (remote_target::remote_notice_new_inferior): Update.
7850         (remote_target::add_current_inferior_and_thread): Update.
7851         * inferior.c (exit_inferior_1): Use "false".
7852         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7853
7854 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7855
7856         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7857         the "start" command.
7858
7859 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7860
7861         * python/py-inferior.c (infpy_thread_from_thread_handle):
7862         Adjust comments to reflect renaming of thread_from_thread_handle
7863         to thread_from_handle.  Adjust keywords.  Fix type error message.
7864         (inferior_object_methods): Add thread_from_handle.  Retain
7865         thread_from_thread_handle, but mark it as deprecated.
7866
7867 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7868
7869         * gdbthread.h (find_thread_by_handle): Revise declaration.
7870         * thread.c (find_thread_by_handle): Likewise.  Adjust
7871         implementation too.
7872         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7873         support for buffer objects as handles.
7874
7875 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7876
7877         * python/py-infthread.c (thpy_thread_handle): New function.
7878         (thread_object_methods): Register thpy_thread_handle.
7879
7880 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7881
7882         * gdbthread.h (thread_to_thread_handle): Declare.
7883         * thread.c (gdbtypes.h): Include.
7884         (thread_to_thread_handle): New function.
7885
7886         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7887         (target_thread_info_to_thread_handle): Declare.
7888         * target.c (target_thread_info_to_thread_handle): New function.
7889         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7890         * target-delegates.c: Regenerate.
7891
7892         * linux-thread-db.c (class thread_db_target): Add method
7893         thread_info_to_thread_handle.
7894         (thread_db_target::thread_info_to_thread_handle): Define.
7895         * remote.c (class remote_target): Add new method
7896         thread_info_to_thread_handle.
7897         (remote_target::thread_info_to_thread_handle): Define.
7898
7899 2019-04-08  Pedro Alves  <palves@redhat.com>
7900
7901         * common/common-exceptions.c (throw_exception): Don't create
7902         named object to throw; throw directly.
7903         (throw_it): Likewise.  Don't initialize gdb_exception::message
7904         here, with new; pass FMT and AP to the ctor instead.
7905         * common/common-exceptions.h: Include <string>.
7906         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7907         const char *, va_list)): New ctor.  Use std::make_shared.
7908         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7909         errors)): Delete.
7910         (gdb_exception_error::gdb_exception_error(enum errors, const char
7911         *, va_list)): New.
7912         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7913         Add assertion.
7914         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7915         errors)): Delete.
7916         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7917         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7918         Add assertion.
7919
7920 2019-04-08  Tom Tromey  <tom@tromey.com>
7921
7922         * valops.c (value_rtti_indirect_type): Replace throw_exception
7923         with throw.
7924         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7925         with throw.
7926         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7927         throw.
7928         * target.c (target_translate_tls_address): Replace throw_exception
7929         with throw.
7930         * stack.c (frame_apply_command_count): Replace throw_exception
7931         with throw.
7932         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7933         throw.
7934         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7935         with throw.
7936         * rs6000-tdep.c (rs6000_frame_cache)
7937         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7938         * remote.c: Replace throw_exception with throw.
7939         * record-full.c (record_full_message, record_full_wait_1)
7940         (record_full_restore): Replace throw_exception with throw.
7941         * record-btrace.c:
7942         (get_thread_current_frame_id, record_btrace_start_replaying)
7943         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7944         (cmd_record_btrace_start): Replace throw_exception with throw.
7945         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7946         throw.
7947         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7948         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7949         * linespec.c:
7950         (find_linespec_symbols): Replace throw_exception with throw.
7951         * infrun.c (displaced_step_prepare, resume): Replace
7952         throw_exception with throw.
7953         * infcmd.c (post_create_inferior): Replace throw_exception with
7954         throw.
7955         * inf-loop.c (inferior_event_handler): Replace throw_exception
7956         with throw.
7957         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7958         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7959         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7960         (get_prev_frame_always, get_frame_pc_if_available)
7961         (get_frame_address_in_block_if_available, get_frame_language):
7962         Replace throw_exception with throw.
7963         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7964         throw_exception with throw.
7965         * eval.c (fetch_subexp_value, evaluate_var_value)
7966         (evaluate_funcall, evaluate_subexp_standard): Replace
7967         throw_exception with throw.
7968         * dwarf2loc.c (call_site_find_chain)
7969         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7970         Replace throw_exception with throw.
7971         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7972         with throw.
7973         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7974         throw.
7975         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7976         * completer.c (complete_line_internal): Replace throw_exception
7977         with throw.
7978         * compile/compile-object-run.c (compile_object_run): Replace
7979         throw_exception with throw.
7980         * cli/cli-script.c (process_next_line): Replace throw_exception
7981         with throw.
7982         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7983         (btrace_enable, btrace_maint_update_pt_packets): Replace
7984         throw_exception with throw.
7985         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7986         throw_exception with throw.
7987         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7988         throw_exception with throw.
7989         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7990         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7991         * aarch64-tdep.c (aarch64_make_prologue_cache)
7992         (aarch64_make_stub_cache): Replace throw_exception with throw.
7993
7994 2019-04-08  Tom Tromey  <tom@tromey.com>
7995
7996         * common/common-exceptions.c (throw_exception): Rename from
7997         throw_exception_cxx.  Remove old copy.  Make argument const.
7998         (throw_it): Create and throw exception objects directly.
7999         * common/common-exceptions.h (throw_exception): Make argument
8000         const.
8001         (struct gdb_exception_error): Add constructor.
8002         (struct gdb_exception_quit): Add constructor.
8003
8004 2019-04-08  Tom Tromey  <tom@tromey.com>
8005
8006         * common/common-exceptions.h (exception_rethrow): Don't declare.
8007         (TRY_SJLJ): Update comment.
8008         (TRY, CATCH, END_CATCH): Remove.
8009         * common/common-exceptions.c (exception_rethrow): Remove.
8010
8011 2019-04-08  Tom Tromey  <tom@tromey.com>
8012
8013         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8014         Remove.
8015         (gdb_exception_error): Rename from
8016         gdb_exception_RETURN_MASK_ERROR.
8017         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8018         (gdb_quit_bad_alloc): Update.
8019         * aarch64-tdep.c: Update.
8020         * ada-lang.c: Update.
8021         * ada-typeprint.c: Update.
8022         * ada-valprint.c: Update.
8023         * amd64-tdep.c: Update.
8024         * arch-utils.c: Update.
8025         * break-catch-throw.c: Update.
8026         * breakpoint.c: Update.
8027         * btrace.c: Update.
8028         * c-varobj.c: Update.
8029         * cli/cli-cmds.c: Update.
8030         * cli/cli-interp.c: Update.
8031         * cli/cli-script.c: Update.
8032         * common/common-exceptions.c: Update.
8033         * common/new-op.c: Update.
8034         * common/selftest.c: Update.
8035         * compile/compile-c-symbols.c: Update.
8036         * compile/compile-cplus-symbols.c: Update.
8037         * compile/compile-object-load.c: Update.
8038         * compile/compile-object-run.c: Update.
8039         * completer.c: Update.
8040         * corelow.c: Update.
8041         * cp-abi.c: Update.
8042         * cp-support.c: Update.
8043         * cp-valprint.c: Update.
8044         * darwin-nat.c: Update.
8045         * disasm-selftests.c: Update.
8046         * dtrace-probe.c: Update.
8047         * dwarf-index-cache.c: Update.
8048         * dwarf-index-write.c: Update.
8049         * dwarf2-frame-tailcall.c: Update.
8050         * dwarf2-frame.c: Update.
8051         * dwarf2loc.c: Update.
8052         * dwarf2read.c: Update.
8053         * eval.c: Update.
8054         * event-loop.c: Update.
8055         * event-top.c: Update.
8056         * exec.c: Update.
8057         * f-valprint.c: Update.
8058         * fbsd-tdep.c: Update.
8059         * frame-unwind.c: Update.
8060         * frame.c: Update.
8061         * gdbtypes.c: Update.
8062         * gnu-v3-abi.c: Update.
8063         * guile/guile-internal.h: Update.
8064         * guile/scm-block.c: Update.
8065         * guile/scm-breakpoint.c: Update.
8066         * guile/scm-cmd.c: Update.
8067         * guile/scm-disasm.c: Update.
8068         * guile/scm-frame.c: Update.
8069         * guile/scm-lazy-string.c: Update.
8070         * guile/scm-math.c: Update.
8071         * guile/scm-param.c: Update.
8072         * guile/scm-ports.c: Update.
8073         * guile/scm-pretty-print.c: Update.
8074         * guile/scm-symbol.c: Update.
8075         * guile/scm-symtab.c: Update.
8076         * guile/scm-type.c: Update.
8077         * guile/scm-value.c: Update.
8078         * i386-linux-tdep.c: Update.
8079         * i386-tdep.c: Update.
8080         * inf-loop.c: Update.
8081         * infcall.c: Update.
8082         * infcmd.c: Update.
8083         * infrun.c: Update.
8084         * jit.c: Update.
8085         * language.c: Update.
8086         * linespec.c: Update.
8087         * linux-fork.c: Update.
8088         * linux-nat.c: Update.
8089         * linux-tdep.c: Update.
8090         * linux-thread-db.c: Update.
8091         * main.c: Update.
8092         * mi/mi-cmd-break.c: Update.
8093         * mi/mi-cmd-stack.c: Update.
8094         * mi/mi-interp.c: Update.
8095         * mi/mi-main.c: Update.
8096         * objc-lang.c: Update.
8097         * p-valprint.c: Update.
8098         * parse.c: Update.
8099         * ppc-linux-tdep.c: Update.
8100         * printcmd.c: Update.
8101         * python/py-arch.c: Update.
8102         * python/py-breakpoint.c: Update.
8103         * python/py-cmd.c: Update.
8104         * python/py-finishbreakpoint.c: Update.
8105         * python/py-frame.c: Update.
8106         * python/py-framefilter.c: Update.
8107         * python/py-gdb-readline.c: Update.
8108         * python/py-inferior.c: Update.
8109         * python/py-infthread.c: Update.
8110         * python/py-lazy-string.c: Update.
8111         * python/py-linetable.c: Update.
8112         * python/py-objfile.c: Update.
8113         * python/py-param.c: Update.
8114         * python/py-prettyprint.c: Update.
8115         * python/py-progspace.c: Update.
8116         * python/py-record-btrace.c: Update.
8117         * python/py-record.c: Update.
8118         * python/py-symbol.c: Update.
8119         * python/py-type.c: Update.
8120         * python/py-unwind.c: Update.
8121         * python/py-utils.c: Update.
8122         * python/py-value.c: Update.
8123         * python/python.c: Update.
8124         * record-btrace.c: Update.
8125         * record-full.c: Update.
8126         * remote-fileio.c: Update.
8127         * remote.c: Update.
8128         * riscv-tdep.c: Update.
8129         * rs6000-aix-tdep.c: Update.
8130         * rs6000-tdep.c: Update.
8131         * rust-exp.y: Update.
8132         * rust-lang.c: Update.
8133         * s390-tdep.c: Update.
8134         * selftest-arch.c: Update.
8135         * solib-dsbt.c: Update.
8136         * solib-frv.c: Update.
8137         * solib-spu.c: Update.
8138         * solib-svr4.c: Update.
8139         * solib.c: Update.
8140         * sparc64-linux-tdep.c: Update.
8141         * stack.c: Update.
8142         * symfile-mem.c: Update.
8143         * symmisc.c: Update.
8144         * target.c: Update.
8145         * thread.c: Update.
8146         * top.c: Update.
8147         * tracefile-tfile.c: Update.
8148         * tui/tui.c: Update.
8149         * typeprint.c: Update.
8150         * unittests/cli-utils-selftests.c: Update.
8151         * unittests/parse-connection-spec-selftests.c: Update.
8152         * valops.c: Update.
8153         * valprint.c: Update.
8154         * value.c: Update.
8155         * varobj.c: Update.
8156         * windows-nat.c: Update.
8157         * x86-linux-nat.c: Update.
8158         * xml-support.c: Update.
8159
8160 2019-04-08  Tom Tromey  <tom@tromey.com>
8161
8162         * xml-support.c: Use C++ exception handling.
8163         * x86-linux-nat.c: Use C++ exception handling.
8164         * windows-nat.c: Use C++ exception handling.
8165         * varobj.c: Use C++ exception handling.
8166         * value.c: Use C++ exception handling.
8167         * valprint.c: Use C++ exception handling.
8168         * valops.c: Use C++ exception handling.
8169         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8170         handling.
8171         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8172         * typeprint.c: Use C++ exception handling.
8173         * tui/tui.c: Use C++ exception handling.
8174         * tracefile-tfile.c: Use C++ exception handling.
8175         * top.c: Use C++ exception handling.
8176         * thread.c: Use C++ exception handling.
8177         * target.c: Use C++ exception handling.
8178         * symmisc.c: Use C++ exception handling.
8179         * symfile-mem.c: Use C++ exception handling.
8180         * stack.c: Use C++ exception handling.
8181         * sparc64-linux-tdep.c: Use C++ exception handling.
8182         * solib.c: Use C++ exception handling.
8183         * solib-svr4.c: Use C++ exception handling.
8184         * solib-spu.c: Use C++ exception handling.
8185         * solib-frv.c: Use C++ exception handling.
8186         * solib-dsbt.c: Use C++ exception handling.
8187         * selftest-arch.c: Use C++ exception handling.
8188         * s390-tdep.c: Use C++ exception handling.
8189         * rust-lang.c: Use C++ exception handling.
8190         * rust-exp.y: Use C++ exception handling.
8191         * rs6000-tdep.c: Use C++ exception handling.
8192         * rs6000-aix-tdep.c: Use C++ exception handling.
8193         * riscv-tdep.c: Use C++ exception handling.
8194         * remote.c: Use C++ exception handling.
8195         * remote-fileio.c: Use C++ exception handling.
8196         * record-full.c: Use C++ exception handling.
8197         * record-btrace.c: Use C++ exception handling.
8198         * python/python.c: Use C++ exception handling.
8199         * python/py-value.c: Use C++ exception handling.
8200         * python/py-utils.c: Use C++ exception handling.
8201         * python/py-unwind.c: Use C++ exception handling.
8202         * python/py-type.c: Use C++ exception handling.
8203         * python/py-symbol.c: Use C++ exception handling.
8204         * python/py-record.c: Use C++ exception handling.
8205         * python/py-record-btrace.c: Use C++ exception handling.
8206         * python/py-progspace.c: Use C++ exception handling.
8207         * python/py-prettyprint.c: Use C++ exception handling.
8208         * python/py-param.c: Use C++ exception handling.
8209         * python/py-objfile.c: Use C++ exception handling.
8210         * python/py-linetable.c: Use C++ exception handling.
8211         * python/py-lazy-string.c: Use C++ exception handling.
8212         * python/py-infthread.c: Use C++ exception handling.
8213         * python/py-inferior.c: Use C++ exception handling.
8214         * python/py-gdb-readline.c: Use C++ exception handling.
8215         * python/py-framefilter.c: Use C++ exception handling.
8216         * python/py-frame.c: Use C++ exception handling.
8217         * python/py-finishbreakpoint.c: Use C++ exception handling.
8218         * python/py-cmd.c: Use C++ exception handling.
8219         * python/py-breakpoint.c: Use C++ exception handling.
8220         * python/py-arch.c: Use C++ exception handling.
8221         * printcmd.c: Use C++ exception handling.
8222         * ppc-linux-tdep.c: Use C++ exception handling.
8223         * parse.c: Use C++ exception handling.
8224         * p-valprint.c: Use C++ exception handling.
8225         * objc-lang.c: Use C++ exception handling.
8226         * mi/mi-main.c: Use C++ exception handling.
8227         * mi/mi-interp.c: Use C++ exception handling.
8228         * mi/mi-cmd-stack.c: Use C++ exception handling.
8229         * mi/mi-cmd-break.c: Use C++ exception handling.
8230         * main.c: Use C++ exception handling.
8231         * linux-thread-db.c: Use C++ exception handling.
8232         * linux-tdep.c: Use C++ exception handling.
8233         * linux-nat.c: Use C++ exception handling.
8234         * linux-fork.c: Use C++ exception handling.
8235         * linespec.c: Use C++ exception handling.
8236         * language.c: Use C++ exception handling.
8237         * jit.c: Use C++ exception handling.
8238         * infrun.c: Use C++ exception handling.
8239         * infcmd.c: Use C++ exception handling.
8240         * infcall.c: Use C++ exception handling.
8241         * inf-loop.c: Use C++ exception handling.
8242         * i386-tdep.c: Use C++ exception handling.
8243         * i386-linux-tdep.c: Use C++ exception handling.
8244         * guile/scm-value.c: Use C++ exception handling.
8245         * guile/scm-type.c: Use C++ exception handling.
8246         * guile/scm-symtab.c: Use C++ exception handling.
8247         * guile/scm-symbol.c: Use C++ exception handling.
8248         * guile/scm-pretty-print.c: Use C++ exception handling.
8249         * guile/scm-ports.c: Use C++ exception handling.
8250         * guile/scm-param.c: Use C++ exception handling.
8251         * guile/scm-math.c: Use C++ exception handling.
8252         * guile/scm-lazy-string.c: Use C++ exception handling.
8253         * guile/scm-frame.c: Use C++ exception handling.
8254         * guile/scm-disasm.c: Use C++ exception handling.
8255         * guile/scm-cmd.c: Use C++ exception handling.
8256         * guile/scm-breakpoint.c: Use C++ exception handling.
8257         * guile/scm-block.c: Use C++ exception handling.
8258         * guile/guile-internal.h: Use C++ exception handling.
8259         * gnu-v3-abi.c: Use C++ exception handling.
8260         * gdbtypes.c: Use C++ exception handling.
8261         * frame.c: Use C++ exception handling.
8262         * frame-unwind.c: Use C++ exception handling.
8263         * fbsd-tdep.c: Use C++ exception handling.
8264         * f-valprint.c: Use C++ exception handling.
8265         * exec.c: Use C++ exception handling.
8266         * event-top.c: Use C++ exception handling.
8267         * event-loop.c: Use C++ exception handling.
8268         * eval.c: Use C++ exception handling.
8269         * dwarf2read.c: Use C++ exception handling.
8270         * dwarf2loc.c: Use C++ exception handling.
8271         * dwarf2-frame.c: Use C++ exception handling.
8272         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8273         * dwarf-index-write.c: Use C++ exception handling.
8274         * dwarf-index-cache.c: Use C++ exception handling.
8275         * dtrace-probe.c: Use C++ exception handling.
8276         * disasm-selftests.c: Use C++ exception handling.
8277         * darwin-nat.c: Use C++ exception handling.
8278         * cp-valprint.c: Use C++ exception handling.
8279         * cp-support.c: Use C++ exception handling.
8280         * cp-abi.c: Use C++ exception handling.
8281         * corelow.c: Use C++ exception handling.
8282         * completer.c: Use C++ exception handling.
8283         * compile/compile-object-run.c: Use C++ exception handling.
8284         * compile/compile-object-load.c: Use C++ exception handling.
8285         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8286         * compile/compile-c-symbols.c: Use C++ exception handling.
8287         * common/selftest.c: Use C++ exception handling.
8288         * common/new-op.c: Use C++ exception handling.
8289         * cli/cli-script.c: Use C++ exception handling.
8290         * cli/cli-interp.c: Use C++ exception handling.
8291         * cli/cli-cmds.c: Use C++ exception handling.
8292         * c-varobj.c: Use C++ exception handling.
8293         * btrace.c: Use C++ exception handling.
8294         * breakpoint.c: Use C++ exception handling.
8295         * break-catch-throw.c: Use C++ exception handling.
8296         * arch-utils.c: Use C++ exception handling.
8297         * amd64-tdep.c: Use C++ exception handling.
8298         * ada-valprint.c: Use C++ exception handling.
8299         * ada-typeprint.c: Use C++ exception handling.
8300         * ada-lang.c: Use C++ exception handling.
8301         * aarch64-tdep.c: Use C++ exception handling.
8302
8303 2019-04-08  Tom Tromey  <tom@tromey.com>
8304
8305         * xml-support.c (gdb_xml_parser::parse): Update.
8306         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8307         * value.c (show_convenience): Update.
8308         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8309         (test_parse_flags_qcs): Update.
8310         * thread.c (thr_try_catch_cmd): Update.
8311         * target.c (target_translate_tls_address): Update.
8312         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8313         (info_frame_command_core, frame_apply_command_count): Update.
8314         * rust-exp.y (rust_lex_exception_test): Update.
8315         * riscv-tdep.c (riscv_print_one_register_info): Update.
8316         * remote.c (remote_target::enable_btrace): Update.
8317         * record-btrace.c (record_btrace_enable_warn): Update.
8318         * python/py-utils.c (gdbpy_convert_exception): Update.
8319         * printcmd.c (do_one_display, print_variable_and_value): Update.
8320         * mi/mi-main.c (mi_print_exception): Update.
8321         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8322         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8323         * linux-nat.c (linux_nat_target::attach): Update.
8324         * linux-fork.c (class scoped_switch_fork_info): Update.
8325         * infrun.c (displaced_step_prepare): Update.
8326         * infcall.c (call_function_by_hand_dummy): Update.
8327         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8328         * gnu-v3-abi.c (print_one_vtable): Update.
8329         * frame.c (get_prev_frame_always): Update.
8330         * f-valprint.c (info_common_command_for_block): Update.
8331         * exec.c (try_open_exec_file): Update.
8332         * exceptions.c (print_exception, exception_print)
8333         (exception_fprintf, exception_print_same): Update.
8334         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8335         * dwarf-index-cache.c (index_cache::store)
8336         (index_cache::lookup_gdb_index): Update.
8337         * darwin-nat.c (maybe_cache_shell): Update.
8338         * cp-valprint.c (cp_print_value_fields): Update.
8339         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8340         (gcc_cplus_symbol_address): Update.
8341         * compile/compile-c-symbols.c (gcc_convert_symbol)
8342         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8343         * common/selftest.c: Update.
8344         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8345         a std::string.
8346         (exception_try_scope_entry, exception_try_scope_exit): Don't
8347         declare.
8348         (struct exception_try_scope): Remove.
8349         (TRY): Don't use exception_try_scope.
8350         (struct gdb_exception): Add constructor, operator=.
8351         <what>: New method.
8352         (struct gdb_exception_RETURN_MASK_ALL)
8353         (struct gdb_exception_RETURN_MASK_ERROR)
8354         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8355         (struct gdb_quit_bad_alloc): Update.
8356         * common/common-exceptions.c (exception_none): Change
8357         initializer.
8358         (struct catcher) <state, exception>: Initialize inline.
8359         <prev>: Remove member.
8360         (current_catcher): Remove.
8361         (catchers): New global.
8362         (exceptions_state_mc_init): Simplify.
8363         (catcher_pop): Remove.
8364         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8365         (try_scope_depth, exception_try_scope_entry)
8366         (exception_try_scope_exit): Remove.
8367         (throw_exception_sjlj): Update.
8368         (exception_messages, exception_messages_size): Remove.
8369         (throw_it): Simplify.
8370         (gdb_exception_sliced_copy): Remove.
8371         (throw_exception_cxx): Update.
8372         * cli/cli-script.c (script_from_file): Update.
8373         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8374         Update.
8375         * ada-valprint.c (ada_val_print): Update.
8376         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8377         (create_excep_cond_exprs): Update.
8378
8379 2019-04-08  Tom Tromey  <tom@tromey.com>
8380
8381         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8382         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8383         (TRY, CATCH, END_CATCH): Remove some definitions.
8384         * common/common-exceptions.c: Don't use GDB_XCPT.
8385         (catcher_list_size): Remove.
8386         (throw_exception, throw_it): Simplify.
8387
8388 2019-04-05  Tom Tromey  <tom@tromey.com>
8389
8390         Revert the header-sorting patch.
8391         * ft32-tdep.c: Revert.
8392         * frv-tdep.c: Revert.
8393         * frv-linux-tdep.c: Revert.
8394         * frame.c: Revert.
8395         * frame-unwind.c: Revert.
8396         * frame-base.c: Revert.
8397         * fork-child.c: Revert.
8398         * findvar.c: Revert.
8399         * findcmd.c: Revert.
8400         * filesystem.c: Revert.
8401         * filename-seen-cache.h: Revert.
8402         * filename-seen-cache.c: Revert.
8403         * fbsd-tdep.c: Revert.
8404         * fbsd-nat.h: Revert.
8405         * fbsd-nat.c: Revert.
8406         * f-valprint.c: Revert.
8407         * f-typeprint.c: Revert.
8408         * f-lang.c: Revert.
8409         * extension.h: Revert.
8410         * extension.c: Revert.
8411         * extension-priv.h: Revert.
8412         * expprint.c: Revert.
8413         * exec.h: Revert.
8414         * exec.c: Revert.
8415         * exceptions.c: Revert.
8416         * event-top.c: Revert.
8417         * event-loop.c: Revert.
8418         * eval.c: Revert.
8419         * elfread.c: Revert.
8420         * dwarf2read.h: Revert.
8421         * dwarf2read.c: Revert.
8422         * dwarf2loc.c: Revert.
8423         * dwarf2expr.h: Revert.
8424         * dwarf2expr.c: Revert.
8425         * dwarf2-frame.c: Revert.
8426         * dwarf2-frame-tailcall.c: Revert.
8427         * dwarf-index-write.h: Revert.
8428         * dwarf-index-write.c: Revert.
8429         * dwarf-index-common.c: Revert.
8430         * dwarf-index-cache.h: Revert.
8431         * dwarf-index-cache.c: Revert.
8432         * dummy-frame.c: Revert.
8433         * dtrace-probe.c: Revert.
8434         * disasm.h: Revert.
8435         * disasm.c: Revert.
8436         * disasm-selftests.c: Revert.
8437         * dictionary.c: Revert.
8438         * dicos-tdep.c: Revert.
8439         * demangle.c: Revert.
8440         * dcache.h: Revert.
8441         * dcache.c: Revert.
8442         * darwin-nat.h: Revert.
8443         * darwin-nat.c: Revert.
8444         * darwin-nat-info.c: Revert.
8445         * d-valprint.c: Revert.
8446         * d-namespace.c: Revert.
8447         * d-lang.c: Revert.
8448         * ctf.c: Revert.
8449         * csky-tdep.c: Revert.
8450         * csky-linux-tdep.c: Revert.
8451         * cris-tdep.c: Revert.
8452         * cris-linux-tdep.c: Revert.
8453         * cp-valprint.c: Revert.
8454         * cp-support.c: Revert.
8455         * cp-namespace.c: Revert.
8456         * cp-abi.c: Revert.
8457         * corelow.c: Revert.
8458         * corefile.c: Revert.
8459         * continuations.c: Revert.
8460         * completer.h: Revert.
8461         * completer.c: Revert.
8462         * complaints.c: Revert.
8463         * coffread.c: Revert.
8464         * coff-pe-read.c: Revert.
8465         * cli-out.h: Revert.
8466         * cli-out.c: Revert.
8467         * charset.c: Revert.
8468         * c-varobj.c: Revert.
8469         * c-valprint.c: Revert.
8470         * c-typeprint.c: Revert.
8471         * c-lang.c: Revert.
8472         * buildsym.c: Revert.
8473         * buildsym-legacy.c: Revert.
8474         * build-id.h: Revert.
8475         * build-id.c: Revert.
8476         * btrace.c: Revert.
8477         * bsd-uthread.c: Revert.
8478         * breakpoint.h: Revert.
8479         * breakpoint.c: Revert.
8480         * break-catch-throw.c: Revert.
8481         * break-catch-syscall.c: Revert.
8482         * break-catch-sig.c: Revert.
8483         * blockframe.c: Revert.
8484         * block.c: Revert.
8485         * bfin-tdep.c: Revert.
8486         * bfin-linux-tdep.c: Revert.
8487         * bfd-target.c: Revert.
8488         * bcache.c: Revert.
8489         * ax-general.c: Revert.
8490         * ax-gdb.h: Revert.
8491         * ax-gdb.c: Revert.
8492         * avr-tdep.c: Revert.
8493         * auxv.c: Revert.
8494         * auto-load.c: Revert.
8495         * arm-wince-tdep.c: Revert.
8496         * arm-tdep.c: Revert.
8497         * arm-symbian-tdep.c: Revert.
8498         * arm-pikeos-tdep.c: Revert.
8499         * arm-obsd-tdep.c: Revert.
8500         * arm-nbsd-tdep.c: Revert.
8501         * arm-nbsd-nat.c: Revert.
8502         * arm-linux-tdep.c: Revert.
8503         * arm-linux-nat.c: Revert.
8504         * arm-fbsd-tdep.c: Revert.
8505         * arm-fbsd-nat.c: Revert.
8506         * arm-bsd-tdep.c: Revert.
8507         * arch-utils.c: Revert.
8508         * arc-tdep.c: Revert.
8509         * arc-newlib-tdep.c: Revert.
8510         * annotate.h: Revert.
8511         * annotate.c: Revert.
8512         * amd64-windows-tdep.c: Revert.
8513         * amd64-windows-nat.c: Revert.
8514         * amd64-tdep.c: Revert.
8515         * amd64-sol2-tdep.c: Revert.
8516         * amd64-obsd-tdep.c: Revert.
8517         * amd64-obsd-nat.c: Revert.
8518         * amd64-nbsd-tdep.c: Revert.
8519         * amd64-nbsd-nat.c: Revert.
8520         * amd64-nat.c: Revert.
8521         * amd64-linux-tdep.c: Revert.
8522         * amd64-linux-nat.c: Revert.
8523         * amd64-fbsd-tdep.c: Revert.
8524         * amd64-fbsd-nat.c: Revert.
8525         * amd64-dicos-tdep.c: Revert.
8526         * amd64-darwin-tdep.c: Revert.
8527         * amd64-bsd-nat.c: Revert.
8528         * alpha-tdep.c: Revert.
8529         * alpha-obsd-tdep.c: Revert.
8530         * alpha-nbsd-tdep.c: Revert.
8531         * alpha-mdebug-tdep.c: Revert.
8532         * alpha-linux-tdep.c: Revert.
8533         * alpha-linux-nat.c: Revert.
8534         * alpha-bsd-tdep.c: Revert.
8535         * alpha-bsd-nat.c: Revert.
8536         * aix-thread.c: Revert.
8537         * agent.c: Revert.
8538         * addrmap.c: Revert.
8539         * ada-varobj.c: Revert.
8540         * ada-valprint.c: Revert.
8541         * ada-typeprint.c: Revert.
8542         * ada-tasks.c: Revert.
8543         * ada-lang.c: Revert.
8544         * aarch64-tdep.c: Revert.
8545         * aarch64-ravenscar-thread.c: Revert.
8546         * aarch64-newlib-tdep.c: Revert.
8547         * aarch64-linux-tdep.c: Revert.
8548         * aarch64-linux-nat.c: Revert.
8549         * aarch64-fbsd-tdep.c: Revert.
8550         * aarch64-fbsd-nat.c: Revert.
8551         * aarch32-linux-nat.c: Revert.
8552
8553 2019-04-05  Tom Tromey  <tom@tromey.com>
8554
8555         * ft32-tdep.c: Sort headers.
8556         * frv-tdep.c: Sort headers.
8557         * frv-linux-tdep.c: Sort headers.
8558         * frame.c: Sort headers.
8559         * frame-unwind.c: Sort headers.
8560         * frame-base.c: Sort headers.
8561         * fork-child.c: Sort headers.
8562         * findvar.c: Sort headers.
8563         * findcmd.c: Sort headers.
8564         * filesystem.c: Sort headers.
8565         * filename-seen-cache.h: Sort headers.
8566         * filename-seen-cache.c: Sort headers.
8567         * fbsd-tdep.c: Sort headers.
8568         * fbsd-nat.h: Sort headers.
8569         * fbsd-nat.c: Sort headers.
8570         * f-valprint.c: Sort headers.
8571         * f-typeprint.c: Sort headers.
8572         * f-lang.c: Sort headers.
8573         * extension.h: Sort headers.
8574         * extension.c: Sort headers.
8575         * extension-priv.h: Sort headers.
8576         * expprint.c: Sort headers.
8577         * exec.h: Sort headers.
8578         * exec.c: Sort headers.
8579         * exceptions.c: Sort headers.
8580         * event-top.c: Sort headers.
8581         * event-loop.c: Sort headers.
8582         * eval.c: Sort headers.
8583         * elfread.c: Sort headers.
8584         * dwarf2read.h: Sort headers.
8585         * dwarf2read.c: Sort headers.
8586         * dwarf2loc.c: Sort headers.
8587         * dwarf2expr.h: Sort headers.
8588         * dwarf2expr.c: Sort headers.
8589         * dwarf2-frame.c: Sort headers.
8590         * dwarf2-frame-tailcall.c: Sort headers.
8591         * dwarf-index-write.h: Sort headers.
8592         * dwarf-index-write.c: Sort headers.
8593         * dwarf-index-common.c: Sort headers.
8594         * dwarf-index-cache.h: Sort headers.
8595         * dwarf-index-cache.c: Sort headers.
8596         * dummy-frame.c: Sort headers.
8597         * dtrace-probe.c: Sort headers.
8598         * disasm.h: Sort headers.
8599         * disasm.c: Sort headers.
8600         * disasm-selftests.c: Sort headers.
8601         * dictionary.c: Sort headers.
8602         * dicos-tdep.c: Sort headers.
8603         * demangle.c: Sort headers.
8604         * dcache.h: Sort headers.
8605         * dcache.c: Sort headers.
8606         * darwin-nat.h: Sort headers.
8607         * darwin-nat.c: Sort headers.
8608         * darwin-nat-info.c: Sort headers.
8609         * d-valprint.c: Sort headers.
8610         * d-namespace.c: Sort headers.
8611         * d-lang.c: Sort headers.
8612         * ctf.c: Sort headers.
8613         * csky-tdep.c: Sort headers.
8614         * csky-linux-tdep.c: Sort headers.
8615         * cris-tdep.c: Sort headers.
8616         * cris-linux-tdep.c: Sort headers.
8617         * cp-valprint.c: Sort headers.
8618         * cp-support.c: Sort headers.
8619         * cp-namespace.c: Sort headers.
8620         * cp-abi.c: Sort headers.
8621         * corelow.c: Sort headers.
8622         * corefile.c: Sort headers.
8623         * continuations.c: Sort headers.
8624         * completer.h: Sort headers.
8625         * completer.c: Sort headers.
8626         * complaints.c: Sort headers.
8627         * coffread.c: Sort headers.
8628         * coff-pe-read.c: Sort headers.
8629         * cli-out.h: Sort headers.
8630         * cli-out.c: Sort headers.
8631         * charset.c: Sort headers.
8632         * c-varobj.c: Sort headers.
8633         * c-valprint.c: Sort headers.
8634         * c-typeprint.c: Sort headers.
8635         * c-lang.c: Sort headers.
8636         * buildsym.c: Sort headers.
8637         * buildsym-legacy.c: Sort headers.
8638         * build-id.h: Sort headers.
8639         * build-id.c: Sort headers.
8640         * btrace.c: Sort headers.
8641         * bsd-uthread.c: Sort headers.
8642         * breakpoint.h: Sort headers.
8643         * breakpoint.c: Sort headers.
8644         * break-catch-throw.c: Sort headers.
8645         * break-catch-syscall.c: Sort headers.
8646         * break-catch-sig.c: Sort headers.
8647         * blockframe.c: Sort headers.
8648         * block.c: Sort headers.
8649         * bfin-tdep.c: Sort headers.
8650         * bfin-linux-tdep.c: Sort headers.
8651         * bfd-target.c: Sort headers.
8652         * bcache.c: Sort headers.
8653         * ax-general.c: Sort headers.
8654         * ax-gdb.h: Sort headers.
8655         * ax-gdb.c: Sort headers.
8656         * avr-tdep.c: Sort headers.
8657         * auxv.c: Sort headers.
8658         * auto-load.c: Sort headers.
8659         * arm-wince-tdep.c: Sort headers.
8660         * arm-tdep.c: Sort headers.
8661         * arm-symbian-tdep.c: Sort headers.
8662         * arm-pikeos-tdep.c: Sort headers.
8663         * arm-obsd-tdep.c: Sort headers.
8664         * arm-nbsd-tdep.c: Sort headers.
8665         * arm-nbsd-nat.c: Sort headers.
8666         * arm-linux-tdep.c: Sort headers.
8667         * arm-linux-nat.c: Sort headers.
8668         * arm-fbsd-tdep.c: Sort headers.
8669         * arm-fbsd-nat.c: Sort headers.
8670         * arm-bsd-tdep.c: Sort headers.
8671         * arch-utils.c: Sort headers.
8672         * arc-tdep.c: Sort headers.
8673         * arc-newlib-tdep.c: Sort headers.
8674         * annotate.h: Sort headers.
8675         * annotate.c: Sort headers.
8676         * amd64-windows-tdep.c: Sort headers.
8677         * amd64-windows-nat.c: Sort headers.
8678         * amd64-tdep.c: Sort headers.
8679         * amd64-sol2-tdep.c: Sort headers.
8680         * amd64-obsd-tdep.c: Sort headers.
8681         * amd64-obsd-nat.c: Sort headers.
8682         * amd64-nbsd-tdep.c: Sort headers.
8683         * amd64-nbsd-nat.c: Sort headers.
8684         * amd64-nat.c: Sort headers.
8685         * amd64-linux-tdep.c: Sort headers.
8686         * amd64-linux-nat.c: Sort headers.
8687         * amd64-fbsd-tdep.c: Sort headers.
8688         * amd64-fbsd-nat.c: Sort headers.
8689         * amd64-dicos-tdep.c: Sort headers.
8690         * amd64-darwin-tdep.c: Sort headers.
8691         * amd64-bsd-nat.c: Sort headers.
8692         * alpha-tdep.c: Sort headers.
8693         * alpha-obsd-tdep.c: Sort headers.
8694         * alpha-nbsd-tdep.c: Sort headers.
8695         * alpha-mdebug-tdep.c: Sort headers.
8696         * alpha-linux-tdep.c: Sort headers.
8697         * alpha-linux-nat.c: Sort headers.
8698         * alpha-bsd-tdep.c: Sort headers.
8699         * alpha-bsd-nat.c: Sort headers.
8700         * aix-thread.c: Sort headers.
8701         * agent.c: Sort headers.
8702         * addrmap.c: Sort headers.
8703         * ada-varobj.c: Sort headers.
8704         * ada-valprint.c: Sort headers.
8705         * ada-typeprint.c: Sort headers.
8706         * ada-tasks.c: Sort headers.
8707         * ada-lang.c: Sort headers.
8708         * aarch64-tdep.c: Sort headers.
8709         * aarch64-ravenscar-thread.c: Sort headers.
8710         * aarch64-newlib-tdep.c: Sort headers.
8711         * aarch64-linux-tdep.c: Sort headers.
8712         * aarch64-linux-nat.c: Sort headers.
8713         * aarch64-fbsd-tdep.c: Sort headers.
8714         * aarch64-fbsd-nat.c: Sort headers.
8715         * aarch32-linux-nat.c: Sort headers.
8716
8717 2019-04-04  Tom Tromey  <tom@tromey.com>
8718
8719         * varobj.c (varobj_create): Update.
8720         * rust-exp.y (struct rust_parser) <update_innermost_block,
8721         lookup_symbol>: New methods.
8722         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8723         Rename.
8724         (rust_parser::rust_lookup_type)
8725         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8726         * printcmd.c (display_command, do_one_display): Update.
8727         * parser-defs.h (struct parser_state) <parser_state>: Add
8728         "tracker" parameter.
8729         (block_tracker): New member.
8730         (class innermost_block_tracker) <innermost_block_tracker>: Add
8731         "types" parameter.
8732         <reset>: Remove method.
8733         (innermost_block): Don't declare.
8734         (null_post_parser): Update.
8735         * parse.c (innermost_block): Remove global.
8736         (write_dollar_variable): Update.
8737         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8738         Remove "tracker_types" parameter.
8739         (parse_expression): Add "tracker" parameter.
8740         (parse_expression_for_completion): Update.
8741         (null_post_parser): Add "tracker" parameter.
8742         * p-exp.y: Update rules.
8743         * m2-exp.y: Update rules.
8744         * language.h (struct language_defn) <la_post_parser>: Add
8745         "tracker" parameter.
8746         * go-exp.y: Update rules.
8747         * f-exp.y: Update rules.
8748         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8749         parameter.
8750         * d-exp.y: Update rules.
8751         * c-exp.y: Update rules.
8752         * breakpoint.c (set_breakpoint_condition): Create an
8753         innermost_block_tracker.
8754         (watch_command_1): Likewise.
8755         * ada-lang.c (resolve): Add "tracker" parameter.
8756         (resolve_subexp): Likewise.
8757         * ada-exp.y (write_var_from_sym): Update.
8758
8759 2019-04-04  Tom Tromey  <tom@tromey.com>
8760
8761         * type-stack.h: New file.
8762         * type-stack.c: New file.
8763         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8764         type-stack.h.
8765         (insert_into_type_stack, insert_type, push_type, push_type_int)
8766         (insert_type_address_space, pop_type, pop_type_int)
8767         (pop_typelist, pop_type_stack, append_type_stack)
8768         (push_type_stack, get_type_stack, push_typelist)
8769         (follow_type_instance_flags, follow_types): Don't declare.
8770         * parse.c (type_stack): Remove global.
8771         (parse_exp_in_context): Update.
8772         (insert_into_type_stack, insert_type, push_type, push_type_int)
8773         (insert_type_address_space, pop_type, pop_type_int)
8774         (pop_typelist, pop_type_stack, append_type_stack)
8775         (push_type_stack, get_type_stack, push_typelist)
8776         (follow_type_instance_flags, follow_types): Remove (moved to
8777         type-stack.c).
8778         * f-exp.y (type_stack): New global.
8779         Update rules.
8780         (push_kind_type, f_parse): Update.
8781         * d-exp.y (type_stack): New global.
8782         Update rules.
8783         (d_parse): Update.
8784         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8785         Update rules.
8786         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8787         (HFILES_NO_SRCDIR): Add type-stack.h.
8788
8789 2019-04-04  Tom Tromey  <tom@tromey.com>
8790
8791         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8792         (rust_parser::convert_ast_to_expression, rust_parse)
8793         (rust_lex_test_completion, rust_lex_tests): Update.
8794         * parser-defs.h (struct expr_completion_state): New.
8795         (struct parser_state) <parser_state>: Add completion parameter.
8796         <mark_struct_expression, mark_completion_tag>: New methods.
8797         <parse_completion, m_completion_state>: New members.
8798         (prefixify_expression, null_post_parser): Update.
8799         (mark_struct_expression, mark_completion_tag): Don't declare.
8800         * parse.c (parse_completion, expout_last_struct)
8801         (expout_tag_completion_type, expout_completion_name): Remove
8802         globals.
8803         (parser_state::mark_struct_expression)
8804         (parser_state::mark_completion_tag): Now methods.
8805         (prefixify_expression): Add last_struct parameter.
8806         (prefixify_subexp): Likewise.
8807         (parse_exp_1): Update.
8808         (parse_exp_in_context): Add cstate parameter.  Update.
8809         (parse_expression_for_completion): Create an
8810         expr_completion_state.
8811         (null_post_parser): Add "completion" parameter.
8812         * p-exp.y: Update rules.
8813         (yylex): Update.
8814         * language.h (struct language_defn) <la_post_parser>: Add
8815         "completing" parameter.
8816         * go-exp.y: Update rules.
8817         (lex_one_token): Update.
8818         * expression.h (parse_completion): Don't declare.
8819         * d-exp.y: Update rules.
8820         (lex_one_token): Update rules.
8821         * c-exp.y: Update rules.
8822         (lex_one_token): Update.
8823         * ada-lang.c (resolve): Add "parse_completion" parameter.
8824         (resolve_subexp): Likewise.
8825         (ada_resolve_function): Likewise.
8826
8827 2019-04-04  Tom Tromey  <tom@tromey.com>
8828
8829         * parser-defs.h (struct parser_state) <start_arglist,
8830         end_arglist>: New methods.
8831         <arglist_len, m_funcall_chain>: New members.
8832         (arglist_len, start_arglist, end_arglist): Don't declare.
8833         * parse.c (arglist_len, funcall_chain): Remove global.
8834         (start_arglist, end_arglist): Remove functions.
8835         (parse_exp_in_context): Update.
8836         * p-exp.y: Update rules.
8837         * m2-exp.y: Update rules.
8838         * go-exp.y: Update rules.
8839         * f-exp.y: Update rules.
8840         * d-exp.y: Update rules.
8841         * c-exp.y: Update rules.
8842
8843 2019-04-04  Tom Tromey  <tom@tromey.com>
8844
8845         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8846         lex_operator, push_back>: New methods.
8847         Update all rules.
8848         (rust_parser::lex_hex, lex_escape): Rename and update.
8849         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8850         (rust_parser::lex_operator): Rename and update.
8851         (rust_parser::lex_number, rustyylex, rustyyerror)
8852         (rust_lex_test_init, rust_lex_test_sequence)
8853         (rust_lex_test_push_back, rust_lex_tests): Update.
8854         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8855         parameter.
8856         <lexptr, prev_lexptr>: New members.
8857         (lexptr, prev_lexptr): Don't declare.
8858         * parse.c (lexptr, prev_lexptr): Remove globals.
8859         (parse_exp_in_context): Update.
8860         * p-exp.y (yylex, yyerror): Update.
8861         * m2-exp.y (parse_number, yylex, yyerror): Update.
8862         * go-exp.y (lex_one_token, yyerror): Update.
8863         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8864         * d-exp.y (lex_one_token, yyerror): Update.
8865         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8866         (lex_one_token, yyerror): Update.
8867         * ada-lex.l (YY_INPUT): Update.
8868         (rewind_to_char): Update.
8869         * ada-exp.y (yyerror): Update.
8870
8871 2019-04-04  Tom Tromey  <tom@tromey.com>
8872
8873         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8874         * parser-defs.h (struct parser_state) <parser_state>: Add new
8875         parameter.
8876         <comma_terminates>: New member.
8877         (comma_terminates): Don't declare global.
8878         * parse.c (comma_terminates): Remove global.
8879         (parse_exp_in_context): Update.
8880         * p-exp.y (yylex): Update.
8881         * m2-exp.y (yylex): Update.
8882         * go-exp.y (lex_one_token): Update.
8883         * f-exp.y (yylex): Update.
8884         * d-exp.y (lex_one_token): Update.
8885         * c-exp.y (lex_one_token): Update.
8886         * ada-lex.l: Update.
8887
8888 2019-04-04  Tom Tromey  <tom@tromey.com>
8889
8890         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8891         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8892         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8893         * parser-defs.h (paren_depth): Don't declare.
8894         * parse.c (paren_depth): Remove global.
8895         (parse_exp_in_context): Update.
8896         * p-exp.y (paren_depth): New global.
8897         (pascal_parse): Initialize it.
8898         * m2-exp.y (paren_depth): New global.
8899         (m2_parse): Initialize it.
8900         * go-exp.y (paren_depth): New global.
8901         (go_parse): Initialize it.
8902         * f-exp.y (paren_depth): New global.
8903         (f_parse): Initialize it.
8904         * d-exp.y (paren_depth): New global.
8905         (d_parse): Initialize it.
8906         * c-exp.y (paren_depth): New global.
8907         (c_parse): Initialize it.
8908         * ada-lex.l (paren_depth): New global.
8909         (lexer_init): Initialize it.
8910
8911 2019-04-04  Tom Tromey  <tom@tromey.com>
8912
8913         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8914         (rust_parser::convert_ast_to_type)
8915         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8916         * parser-defs.h (struct parser_state) <parser_state>: Add
8917         parameters.  Initialize new members.
8918         <expression_context_block, expression_context_pc>: New members.
8919         * parse.c (expression_context_block, expression_context_pc):
8920         Remove globals.
8921         (parse_exp_in_context): Update.
8922         * p-exp.y: Update all rules.
8923         (yylex): Update.
8924         * m2-exp.y: Update all rules.
8925         (yylex): Update.
8926         * go-exp.y (yylex): Update.
8927         * f-exp.y (yylex): Update.
8928         * d-exp.y: Update all rules.
8929         (yylex): Update.
8930         * c-exp.y: Update all rules.
8931         (lex_one_token, classify_name, yylex, c_parse): Update.
8932         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8933
8934 2019-04-04  Tom Tromey  <tom@tromey.com>
8935
8936         * gdbarch.h, gdbarch.c: Rebuild.
8937         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8938         * stap-probe.h:
8939         (struct stap_parse_info): Replace "parser_state" with
8940         "expr_builder".
8941         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8942         (parser_state): New class.
8943         * parse.c (expr_builder): Rename.
8944         (expr_builder::release): Rename.
8945         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8946         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8947         (write_exp_elt_longcst, write_exp_elt_floatcst)
8948         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8949         (write_exp_string_vector, write_exp_bitstring)
8950         (write_exp_msymbol, mark_struct_expression)
8951         (write_dollar_variable)
8952         (insert_type_address_space, increase_expout_size): Replace
8953         "parser_state" with "expr_builder".
8954         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8955         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8956         "parser_state" with "expr_builder".
8957
8958 2019-04-04  Tom Tromey  <tom@tromey.com>
8959
8960         * rust-exp.y: Replace "parse_language" with method call.
8961         * p-exp.y:
8962         (yylex): Replace "parse_language" with method call.
8963         * m2-exp.y:
8964         (yylex): Replace "parse_language" with method call.
8965         * go-exp.y (classify_name): Replace "parse_language" with method
8966         call.
8967         * f-exp.y (yylex): Replace "parse_language" with method call.
8968         * d-exp.y (lex_one_token): Replace "parse_language" with method
8969         call.
8970         * c-exp.y:
8971         (lex_one_token, classify_name, yylex): Replace "parse_language"
8972         with method call.
8973         * ada-exp.y (find_primitive_type, type_char)
8974         (type_system_address): Replace "parse_language" with method call.
8975
8976 2019-04-04  Tom Tromey  <tom@tromey.com>
8977
8978         * rust-exp.y: Replace "parse_gdbarch" with method call.
8979         * parse.c (write_dollar_variable, insert_type_address_space):
8980         Replace "parse_gdbarch" with method call.
8981         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8982         call.
8983         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8984         call.
8985         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8986         "parse_gdbarch" with method call.
8987         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8988         with method call.
8989         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8990         "parse_gdbarch" with method call.
8991         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8992         "parse_gdbarch" with method call.
8993         * c-exp.y (parse_type, parse_number, classify_name): Replace
8994         "parse_gdbarch" with method call.
8995         * ada-lex.l: Replace "parse_gdbarch" with method call.
8996         * ada-exp.y (parse_type, find_primitive_type, type_char)
8997         (type_system_address): Replace "parse_gdbarch" with method call.
8998
8999 2019-04-04  Tom Tromey  <tom@tromey.com>
9000
9001         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9002         * stap-probe.c (stap_parse_argument): Update.
9003         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9004         initial_size parameter.
9005         * rust-exp.y (rust_lex_tests): Update.
9006         * parse.c (parser_state): Update.
9007         (parse_exp_in_context): Update.
9008         * parser-defs.h (struct parser_state) <parser_state>: Remove
9009         "initial_size" parameter.
9010
9011 2019-04-04  Tom Tromey  <tom@tromey.com>
9012
9013         * parser-defs.h (increase_expout_size): Don't declare.
9014         * parse.c (increase_expout_size): Now static.
9015
9016 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9017
9018         * gnu-nat.c (gnu_nat_target::wait): Fix
9019         target_waitstatus_to_string call.
9020
9021 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9022
9023         * eval.c (evaluate_subexp_standard): Handle internal functions
9024         during Fortran function call handling.
9025
9026 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9027
9028         * NEWS: Mention new internal functions.
9029         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9030         (read_base_type): Use dwarf2_init_complex_target_type.
9031         * value.c (creal_internal_fn): New function.
9032         (cimag_internal_fn): New function.
9033         (_initialize_values): Register new internal functions.
9034
9035 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9036
9037         * infrun.c (stop_all_threads): If debug_infrun, always
9038         trace the wait status after wait_one, using
9039         target_waitstatus_to_string and target_pid_to_str.
9040         (handle_inferior_event): Replace various trace of
9041         wait status kind by a single trace.
9042         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9043         wait status kind image by target_waitstatus_to_string.
9044         * target/waitstatus.c (target_waitstatus_to_string): Fix
9045         obsolete comment.
9046
9047 2019-04-01  Tom Tromey  <tromey@adacore.com>
9048
9049         PR symtab/23331:
9050         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9051
9052 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9053             Pedro Alves  <palves@redhat.com>
9054
9055         * top.c (quit_force): Call 'finalize_values'.
9056         * value.c (finalize_values): New function.
9057         * value.h (finalize_values): Declare.
9058
9059 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9060
9061         * NEWS: Announce $_gdb_major and $_gdb_minor.
9062
9063         * top.c (init_gdb_version_vars): New function.
9064         (gdb_init): Call init_gdb_version_vars.
9065
9066 2019-03-29  Tom Tromey  <tromey@adacore.com>
9067
9068         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9069         help text.  Remove dead code.
9070
9071 2019-03-29  Keith Seitz  <keiths@redhat.com>
9072
9073         From Siddhesh Poyarekar:
9074         * f-lang.h (f77_get_upperbound): Return LONGEST.
9075         (f77_get_lowerbound): Likewise.
9076         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9077         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9078         print them.
9079         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9080         plongest to format print it.
9081         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9082         (f77_get_upperbound): Likewise.
9083         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9084         LOWER_BOUND to LONGEST.
9085         (f77_create_arrayprint_offset_tbl): Likewise.
9086
9087 2019-03-29  Keith Seitz  <keiths@redhat.com>
9088
9089         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9090         %s/pulongest for TYPE_LENGTH instead of %d in format
9091         strings.
9092         * ada-typerint.c (ada_print_type): Likewise.
9093         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9094         * compile/compile-c-support.c (generate_register_struct): Likewise.
9095         * gdbtypes.c (recursive_dump_type): Likewise.
9096         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9097         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9098         instead of %d in format strings.
9099         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9100         to std::min to ULONGEST.
9101         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9102         instead of %d in format strings.
9103         * tracepoint.c (info_scope_command): Likewise.
9104         * typeprint.c (print_offset_data::update)
9105         (print_offset_data::finish): Likewise.
9106         * xtensa-tdep.c (xtensa_store_return_value)
9107         (xtensa_push_dummy_call): Likewise.
9108
9109 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9110
9111         * windows-nat.c (display_selector): Fixed format specifications
9112         for 64-bit Cygwin.
9113
9114 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9115
9116         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9117
9118 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9119
9120         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9121         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9122         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9123         (nios2_linux_init_abi): Install it.
9124
9125 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9126
9127         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9128
9129 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9130
9131         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9132
9133 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9134             Tom Tromey  <tromey@adacore.com>
9135
9136         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9137
9138 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9139
9140         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9141         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9142         method to compute the bounds of range types. Also print "[evaluated]"
9143         if the bounds' values come from a dynamic evaluation.
9144
9145 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9146
9147         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9148         whitespace when pretty printing is on.
9149
9150 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9151
9152         * ppc-linux-nat.c: Add include.
9153
9154 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9155
9156         * NEWS: Mention AArch64 Pointer Authentication.
9157
9158 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9159
9160         * arm-linux-nat.c: Add include.
9161
9162 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9163
9164         * source-cache.c (source_cache::get_source_lines): Re-read
9165         fullname after calling open_source_file.
9166
9167 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9168
9169         * NEWS: Mention TLS support for FreeBSD.
9170
9171 2019-03-25  Tom Tromey  <tromey@adacore.com>
9172
9173         * minsyms.c (BUNCH_SIZE): Update comment.
9174         (~minimal_symbol_reader): Remove old comment.
9175         (compact_minimal_symbols): Update comment.
9176         (minimal_symbol_reader::install): Remove old comment.  Update
9177         other comments.
9178
9179 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9180
9181         * s390-linux-nat.c: Add include.
9182
9183 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9184
9185         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9186         Call linux_get_hwcap.
9187         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9188         Likewise.
9189         (aarch64_linux_get_hwcap): Remove function.
9190         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9191         declaration.
9192         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9193         linux_get_hwcap.
9194         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9195         * linux-tdep.c (linux_get_hwcap): Add function.
9196         (linux_get_hwcap2): Likewise.
9197         * linux-tdep.h (linux_get_hwcap): Add declaration.
9198         (linux_get_hwcap2): Likewise.
9199         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9200         (ppc_linux_get_hwcap2): Likewise.
9201         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9202         linux_get_hwcap.
9203         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9204         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9205         (ppc_linux_nat_target::read_description): Likewise.
9206         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9207         * s390-linux-nat.c: Likewise.
9208         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9209
9210 2019-03-24  Tom Tromey  <tom@tromey.com>
9211
9212         * ada-lang.c (standard_lookup): Simplify initialization.
9213         (ada_lookup_symbol_nonlocal): Simplify return.
9214         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9215         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9216         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9217         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9218         initialization.
9219         * solib.c (solib_global_lookup): Simplify.
9220         * symtab.c (null_block_symbol): Remove.
9221         (symbol_cache_lookup): Simplify returns.
9222         (lookup_language_this): Simplify returns.
9223         (lookup_symbol_aux): Simplify return.
9224         (lookup_local_symbol): Simplify returns.
9225         (lookup_global_symbol_from_objfile): Simplify return.
9226         (lookup_symbol_in_objfile_symtabs)
9227         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9228         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9229         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9230         * cp-namespace.c (cp_lookup_bare_symbol)
9231         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9232         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9233         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9234         (cp_lookup_symbol_via_imports): Simplify initialization.
9235         (find_symbol_in_baseclass): Likewise.
9236         * symtab.h (null_block_symbol): Remove.
9237         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9238         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9239         (d_lookup_symbol_module): Likewise.
9240         (find_symbol_in_baseclass): Simplify initialization.
9241
9242 2019-03-24  Tom Tromey  <tom@tromey.com>
9243
9244         * expression.h: Don't include symtab.h.
9245         (struct block): Forward declare.
9246
9247 2019-03-24  Tom Tromey  <tom@tromey.com>
9248
9249         * c-exp.y (typebase): Remove casts.
9250         * gdbtypes.c (lookup_unsigned_typename, )
9251         (lookup_signed_typename): Remove cast.
9252         * eval.c (parse_to_comma_and_eval): Remove cast.
9253         * parse.c (write_dollar_variable): Remove cast.
9254         * block.h (struct block) <superblock>: Now const.
9255         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9256         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9257         (map_block): Make "block" const.
9258         * symfile.h (struct quick_symbol_functions)
9259         <map_matching_symbols>: Constify block argument to "callback".
9260         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9261         const.
9262         (find_pc_sect_compunit_symtab): Make "b" const.
9263         (find_symbol_at_address): Likewise.
9264         (search_symbols): Likewise.
9265         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9266         (dw2_debug_names_lookup_symbol): Likewise.
9267         (dw2_map_matching_symbols): Update.
9268         * p-valprint.c (pascal_val_print): Remove "block".
9269         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9270         (aux_add_nonlocal_symbols): Make "block" const.
9271         (resolve_subexp): Remove cast.
9272         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9273         const.
9274         (iterate_over_file_blocks): Likewise.
9275         * f-exp.y (%union) <bval>: Remove.
9276         * coffread.c (patch_opaque_types): Make "b" const.
9277         * spu-tdep.c (spu_catch_start): Make "block" const.
9278         * c-valprint.c (print_unpacked_pointer): Remove "block".
9279         * symmisc.c (dump_symtab_1): Make "b" const.
9280         (block_depth): Make "block" const.
9281         * d-exp.y (%union) <bval>: Remove.
9282         * cp-support.h (cp_lookup_rtti_type): Update.
9283         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9284         * psymtab.c (psym_lookup_symbol): Make "block" const.
9285         (maintenance_check_psymtabs): Make "b" const.
9286         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9287         (enumerate_locals, enumerate_args): Update.
9288         * python/py-symtab.c (stpy_global_block): Make "block" const.
9289         (stpy_static_block): Likewise.
9290         * inline-frame.c (block_starting_point_at): Make "new_block"
9291         const.
9292         * block.c (find_block_in_blockvector): Make return type const.
9293         (blockvector_for_pc_sect): Make "b" const.
9294         (find_block_in_blockvector): Make "b" const.
9295
9296 2019-03-23  Tom Tromey  <tom@tromey.com>
9297
9298         * varobj.c (varobj_create): Update.
9299         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9300         * printcmd.c (display_command, do_one_display): Don't reset
9301         innermost_block.
9302         * parser-defs.h (enum innermost_block_tracker_type): Move to
9303         expression.h.
9304         (innermost_block): Update comment.
9305         * parse.c (parse_exp_1): Add tracker_types parameter.
9306         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9307         tracker_types parameter.  Reset innermost_block.
9308         (parse_exp_in_context): Remove.
9309         (parse_expression_for_completion): Update.
9310         * objfiles.c (~objfile): Don't reset expression_context_block or
9311         innermost_block.
9312         * expression.h (enum innermost_block_tracker_type): Move from
9313         parser-defs.h.
9314         (parse_exp_1): Add tracker_types parameter.
9315         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9316         reset innermost_block.
9317
9318 2019-03-23  Tom Tromey  <tom@tromey.com>
9319
9320         * objfiles.h: Include bcache.h.
9321
9322 2019-03-23  Tom Tromey  <tom@tromey.com>
9323
9324         * linespec.c (get_current_search_block): Use
9325         scoped_restore_current_language.
9326         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9327
9328 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9329             Jiong Wang  <jiong.wang@arm.com>
9330
9331         * aarch64-linux-tdep.c
9332         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9333         section.
9334         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9335
9336 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9337             Jiong Wang  <jiong.wang@arm.com>
9338
9339         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9340         instructions.
9341         (aarch64_analyze_prologue_test): Add PACIASP test.
9342         (aarch64_prologue_prev_register): Unmask PC value.
9343
9344 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9345             Jiong Wang  <jiong.wang@arm.com>
9346
9347         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9348         (aarch64_dwarf2_prev_register): Unmask PC value.
9349         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9350         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9351         DW_CFA_AARCH64_negate_ra_state.
9352         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9353
9354 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9355             Jiong Wang  <jiong.wang@arm.com>
9356
9357         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9358         registers.
9359         (aarch64_pseudo_register_name): Likewise.
9360         (aarch64_pseudo_register_type): Likewise.
9361         (aarch64_pseudo_register_reggroup_p): Likewise.
9362         (aarch64_gdbarch_init): Add pauth registers.
9363         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9364         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9365         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9366         (struct gdbarch_tdep): Add regnum for ra_state.
9367
9368 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9369             Jiong Wang  <jiong.wang@arm.com>
9370
9371         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9372
9373 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9374             Jiong Wang  <jiong.wang@arm.com>
9375
9376         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9377         function.
9378         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9379         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9380         (aarch64_gdbarch_init): Add puth registers.
9381         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9382         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9383         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9384
9385 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9386             Jiong Wang  <jiong.wang@arm.com>
9387
9388         * aarch64-linux-nat.c
9389         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9390         * aarch64-linux-tdep.c
9391         (aarch64_linux_core_read_description): Likewise.
9392         (aarch64_linux_get_hwcap): New function.
9393         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9394         (aarch64_linux_get_hwcap): New declaration.
9395
9396 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9397             Jiong Wang  <jiong.wang@arm.com>
9398
9399         * aarch64-linux-nat.c
9400         (aarch64_linux_nat_target::read_description): Add pauth param.
9401         * aarch64-linux-tdep.c
9402         (aarch64_linux_core_read_description): Likewise.
9403         * aarch64-tdep.c (struct target_desc): Add in pauth.
9404         (aarch64_read_description): Add pauth param.
9405         (aarch64_gdbarch_init): Likewise.
9406         * aarch64-tdep.h (aarch64_read_description): Likewise.
9407         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9408         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9409         * features/Makefile: Add new files.
9410         * features/aarch64-pauth.c: New file.
9411         * features/aarch64-pauth.xml: New file.
9412
9413 2019-03-20  Tom Tromey  <tromey@adacore.com>
9414
9415         * infrun.c (handle_inferior_event): Rename from
9416         handle_inferior_event_1.  Create a scoped_value_mark.
9417         (handle_inferior_event): Remove.
9418
9419 2019-03-19  Tom Tromey  <tromey@adacore.com>
9420
9421         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9422         * infrun.h (print_stop_event): Add "displays" parameter.
9423         * infrun.c (print_stop_event): Add "displays" parameter.
9424
9425 2019-03-19  Pedro Alves  <palves@redhat.com>
9426
9427         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9428         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9429         to -1.  Fix TABs vs spaces.
9430         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9431         * tui/tui-out.h (tui_ui_out) Add intro comments.
9432         <m_line, m_start_of_line>: In-class initialize, and add describing
9433         comment.
9434
9435 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9436
9437         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9438         variable names.
9439         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9440
9441 2019-03-18  Pedro Alves  <palves@redhat.com>
9442             Eli Zaretskii <eliz@gnu.org>
9443
9444         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9445         m_line and m_start_of_line.
9446
9447 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9448
9449         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9450         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9451         it returns a newline.  This fixes a regression in TU mode, whereby
9452         the next line is output on the same screen line as the user input.
9453
9454 2019-03-18  Tom Tromey  <tromey@adacore.com>
9455
9456         * minsyms.c (minimal_symbol_reader::install): Remove call to
9457         obstack_blank.
9458
9459 2019-03-18  Pedro Alves  <palves@redhat.com>
9460
9461         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9462         New globals.
9463         (apply_style): New, factored out from ...
9464         (apply_ansi_escape): ... this.  Handle reverse video mode.
9465         (tui_set_reverse_mode): New function.
9466         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9467         * tui/tui-winsource.c (tui_show_source_line): Use
9468         tui_set_reverse_mode instead of setting A_STANDOUT.
9469         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9470         New setter methods.
9471
9472 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9473
9474         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9475         Handle tabs.
9476
9477 2019-03-18  Tom Tromey  <tromey@adacore.com>
9478
9479         * ada-lang.c (empty_array): Add "high" parameter.
9480         (ada_evaluate_subexp): Update.
9481
9482 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9483
9484         * unittests/string_view-selftests.c: Define
9485         _initialize_string_view_selftests unconditionally.
9486
9487 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9488
9489         PR gdb/24350
9490         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9491
9492 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9493
9494         PR gdb/24351
9495         * windows-nat.c (display_selector): Fix format specifiers.
9496
9497 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9498
9499         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9500         tui_refill_source_window instead of tui_refresh_win, to update the
9501         current execution line.  This fixes redisplay of the current line
9502         when stepping through the code with "next" or "step".
9503
9504 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9505
9506         * source-cache.c (source_cache::get_source_lines): Call
9507         find_source_lines to initialize s->nlines.  This fixes vertical
9508         scrolling of TUI source window when the DOWN arrow is pressed.
9509
9510 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9511
9512         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9513         linux-thread-db.c (_initialize_thread_db): Likewise.
9514
9515 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9516
9517         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9518         wclrtoeol in tui_show_source_line".  This reverts changes made in
9519         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9520
9521 2019-03-15  Tom Tromey  <tom@tromey.com>
9522
9523         * symtab.h (struct minimal_symbol): Derive from
9524         general_symbol_info.
9525         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9526         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9527         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9528         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9529         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9530         (MSYMBOL_SEARCH_NAME): Update.
9531         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9532         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9533         * minsyms.c (minimal_symbol_reader::record_full): Update.
9534
9535 2019-03-15  Tom Tromey  <tom@tromey.com>
9536
9537         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9538
9539 2019-03-15  Tom Tromey  <tom@tromey.com>
9540
9541         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9542         unique_xmalloc_ptr.
9543         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9544         Update.
9545         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9546         (build_minimal_symbol_hash_tables)
9547         (minimal_symbol_reader::install): Update.
9548
9549 2019-03-15  Tom Tromey  <tom@tromey.com>
9550
9551         * symtab.c (create_demangled_names_hash): Update.
9552         (symbol_set_names): Update.
9553         * objfiles.h (struct objfile_per_bfd_storage)
9554         <demangled_names_hash>: Now an htab_up.
9555         * objfiles.c (objfile_per_bfd_storage): Simplify.
9556
9557 2019-03-15  Tom Tromey  <tom@tromey.com>
9558
9559         * objfiles.h (struct objfile_per_bfd_storage): Declare
9560         destructor.
9561         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9562         New.
9563         (get_objfile_bfd_data): Use new.  Don't initialize
9564         language_of_main.
9565         (free_objfile_per_bfd_storage): Remove.
9566         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9567
9568 2019-03-15  Tom Tromey  <tom@tromey.com>
9569
9570         * symfile.c (reread_symbols): Update.
9571         * objfiles.c (objfile::objfile): Update.
9572         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9573         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9574         comment.
9575         (minimal_symbol_reader::install): Update.
9576         (terminate_minimal_symbol_table): Remove.
9577         * jit.c (jit_object_close_impl): Update.
9578
9579 2019-03-15  Tom Tromey  <tom@tromey.com>
9580
9581         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9582         initializations.
9583
9584 2019-03-15  Tom Tromey  <tom@tromey.com>
9585
9586         * objfiles.h (struct objfile_per_bfd_storage)
9587         <demangled_hash_languages>: Now a bitset.
9588         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9589         (lookup_minimal_symbol): Update.
9590
9591 2019-03-15  Tom Tromey  <tom@tromey.com>
9592
9593         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9594         Don't return the symbol.
9595         * coffread.c (record_minimal_symbol): Use record_full.
9596
9597 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9598
9599         The MS-Windows port of ncurses fails to switch to a color pair if
9600         one or both of the colors are the implicit default colors.  This
9601         change records the default colors when TUI is initialized, and
9602         then specifies them explicitly when a color pair uses the default
9603         colors.  This allows color styling in TUI mode on MS-Windows.
9604
9605         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9606         ncurses_norm_attr.
9607         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9608         colors in ncurses_norm_attr.
9609         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9610         "none", replace it with the default color recorded in
9611         ncurses_norm_attr.
9612
9613 2019-03-14  Tom Tromey  <tromey@adacore.com>
9614
9615         * source-cache.h (class source_cache) <get_source_lines>: Return
9616         std::string.
9617         * source-cache.c (source_cache::extract_lines): Handle case where
9618         first_pos==npos.  Return std::string.
9619         (source_cache::get_source_lines): Update.
9620
9621 2019-03-14  Tom Tromey  <tromey@adacore.com>
9622
9623         * NEWS: Add item for "style sources" commands.
9624         * source-cache.c (source_cache::get_source_lines): Check
9625         source_styling.
9626         * cli/cli-style.c (source_styling): New global.
9627         (_initialize_cli_style): Add "style sources" commands.
9628         (show_style_sources): New function.
9629         * cli/cli-style.h (source_styling): Declare.
9630
9631 2019-03-14  Pedro Alves  <palves@redhat.com>
9632             Tom Tromey  <tromey@adacore.com>
9633
9634         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9635         * tui/tui-winsource.c (tui_refill_source_window): New function,
9636         from...
9637         (tui_horizontal_source_scroll): ... here.  Move some logic.
9638         * cli/cli-style.c (set_style_enabled): Notify new observable.
9639         * tui/tui-hooks.c (tui_redisplay_source): New function.
9640         (tui_attach_detach_observers): Attach or detach
9641         tui_redisplay_source.
9642         * observable.h (source_styling_changed): New observable.
9643         * observable.c: Define source_styling_changed observable.
9644
9645 2019-03-13  Tom Tromey  <tromey@adacore.com>
9646
9647         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9648         (i386_gnu_nat_target::store_registers): Update.
9649         * target-debug.h (target_debug_print_std_string): New macro.
9650         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9651         * windows-tdep.c (display_one_tib): Update.
9652         * tui/tui-stack.c (tui_make_status_line): Update.
9653         * top.c (print_inferior_quit_action): Update.
9654         * thread.c (thr_try_catch_cmd): Update.
9655         (add_thread_with_info): Update.
9656         (thread_target_id_str): Update.
9657         (thr_try_catch_cmd): Update.
9658         (thread_command): Update.
9659         (thread_find_command): Update.
9660         * record-btrace.c (record_btrace_target::info_record)
9661         (record_btrace_resume_thread, record_btrace_target::resume)
9662         (record_btrace_cancel_resume, record_btrace_step_thread)
9663         (record_btrace_target::wait, record_btrace_target::wait)
9664         (record_btrace_target::wait, record_btrace_target::stop): Update.
9665         * progspace.c (print_program_space): Update.
9666         * process-stratum-target.c
9667         (process_stratum_target::thread_address_space): Update.
9668         * linux-fork.c (linux_fork_mourn_inferior)
9669         (detach_checkpoint_command, info_checkpoints_command)
9670         (linux_fork_context): Update.
9671         (linux_fork_detach): Update.
9672         (class scoped_switch_fork_info): Update.
9673         (delete_checkpoint_command): Update.
9674         * infrun.c (follow_fork_inferior): Update.
9675         (follow_fork_inferior): Update.
9676         (proceed_after_vfork_done): Update.
9677         (handle_vfork_child_exec_or_exit): Update.
9678         (follow_exec): Update.
9679         (displaced_step_prepare_throw): Update.
9680         (displaced_step_restore): Update.
9681         (start_step_over): Update.
9682         (resume_1): Update.
9683         (clear_proceed_status_thread): Update.
9684         (proceed): Update.
9685         (print_target_wait_results): Update.
9686         (do_target_wait): Update.
9687         (context_switch): Update.
9688         (stop_all_threads): Update.
9689         (restart_threads): Update.
9690         (finish_step_over): Update.
9691         (handle_signal_stop): Update.
9692         (switch_back_to_stepped_thread): Update.
9693         (keep_going_pass_signal): Update.
9694         (print_exited_reason): Update.
9695         (normal_stop): Update.
9696         * inferior.c (inferior_pid_to_str): Change return type.
9697         (print_selected_inferior): Update.
9698         (add_inferior): Update.
9699         (detach_inferior): Update.
9700         * dummy-frame.c (fprint_dummy_frames): Update.
9701         * dcache.c (dcache_info_1): Update.
9702         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9703         (btrace_fetch, btrace_clear): Update.
9704         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9705         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9706         type.
9707         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9708         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9709         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9710         * gdbarch.c, gdbarch.h: Rebuild.
9711         * gdbarch.sh (core_pid_to_str): Change return type.
9712         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9713         return type.
9714         (windows_nat_target::pid_to_str): Change return type.
9715         (windows_delete_thread): Update.
9716         (windows_nat_target::attach): Update.
9717         (windows_nat_target::files_info): Update.
9718         * target-delegates.c: Rebuild.
9719         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9720         return type.
9721         (sol_thread_target::pid_to_str): Change return type.
9722         * remote.c (class remote_target) <pid_to_str>: Change return
9723         type.
9724         (remote_target::pid_to_str): Change return type.
9725         (extended_remote_target::attach, remote_target::remote_stop_ns)
9726         (remote_target::remote_notif_remove_queued_reply)
9727         (remote_target::push_stop_reply, remote_target::disable_btrace):
9728         Update.
9729         (extended_remote_target::attach): Update.
9730         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9731         type.
9732         (gdbsim_target::pid_to_str): Change return type.
9733         * ravenscar-thread.c (struct ravenscar_thread_target)
9734         <pid_to_str>: Change return type.
9735         (ravenscar_thread_target::pid_to_str): Change return type.
9736         * procfs.c (class procfs_target) <pid_to_str>: Change return
9737         type.
9738         (procfs_target::pid_to_str): Change return type.
9739         (procfs_target::attach): Update.
9740         (procfs_target::detach): Update.
9741         (procfs_target::fetch_registers): Update.
9742         (procfs_target::store_registers): Update.
9743         (procfs_target::wait): Update.
9744         (procfs_target::files_info): Update.
9745         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9746         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9747         return type.
9748         (nto_procfs_target::pid_to_str): Change return type.
9749         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9750         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9751         return type.
9752         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9753         (exit_lwp): Update.
9754         (attach_proc_task_lwp_callback, get_detach_signal)
9755         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9756         (linux_nat_target::resume, wait_lwp, stop_callback)
9757         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9758         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9759         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9760         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9761         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9762         type.
9763         (inf_ptrace_target::attach): Update.
9764         (inf_ptrace_target::files_info): Update.
9765         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9766         type.
9767         (go32_nat_target::pid_to_str): Change return type.
9768         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9769         (gnu_nat_target::wait): Update.
9770         (gnu_nat_target::wait): Update.
9771         (gnu_nat_target::resume): Update.
9772         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9773         (fbsd_nat_target::wait): Update.
9774         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9775         type.
9776         (darwin_nat_target::attach): Update.
9777         * corelow.c (class core_target) <pid_to_str>: Change return type.
9778         (core_target::pid_to_str): Change return type.
9779         * target.c (normal_pid_to_str): Change return type.
9780         (default_pid_to_str): Likewise.
9781         (target_pid_to_str): Change return type.
9782         (target_translate_tls_address): Update.
9783         (target_announce_detach): Update.
9784         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9785         return type.
9786         (bsd_uthread_target::pid_to_str): Change return type.
9787         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9788         type.
9789         (bsd_kvm_target::pid_to_str): Change return type.
9790         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9791         return type.
9792         (aix_thread_target::pid_to_str): Change return type.
9793         * target.h (struct target_ops) <pid_to_str>: Change return type.
9794         (target_pid_to_str, normal_pid_to_str): Likewise.
9795         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9796         type.
9797         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9798         type.
9799         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9800         return type.
9801         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9802         type.
9803         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9804         type.
9805         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9806         return type.
9807
9808 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9809
9810         * NEWS: Mention that the new default MI version is 3.  Mention
9811         changes to the output of commands and events that deal with
9812         multi-location breakpoints.
9813         * breakpoint.c: Include "mi/mi-out.h".
9814         (print_one_breakpoint): Change output syntax if using MI version
9815         >= 3.
9816         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9817         New.
9818         (mi_multi_location_breakpoint_output_fixed): New.
9819         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9820         (mi_cmd_fix_multi_location_breakpoint_output): New.
9821         (mi_multi_location_breakpoint_output_fixed): New.
9822         * mi/mi-cmds.c (mi_cmds): Register command
9823         -fix-multi-location-breakpoint-output.
9824         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9825         interpreter "mi".
9826
9827 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9828
9829         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9830         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9831         instantiate mi_ui_out based on interpreter name.
9832         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9833         * mi/mi-main.c (mi_load_progress): Likewise.
9834
9835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9836
9837         * NEWS: Combine separate "New targets" sections for 8.3.
9838
9839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9840
9841         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9842         (ppcfbsd_init_abi): Install gdbarch
9843         "fetch_tls_load_module_address" and "get_thread_local_address"
9844         methods.
9845
9846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9847
9848         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9849         (riscv_fbsd_init_abi): Install gdbarch
9850         "fetch_tls_load_module_address" and "get_thread_local_address"
9851         methods.
9852
9853 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9854
9855         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9856         (i386fbsd_init_abi): Install gdbarch
9857         "fetch_tls_load_module_address" and "get_thread_local_address"
9858         methods.
9859
9860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9861
9862         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9863         (amd64fbsd_init_abi): Install gdbarch
9864         "fetch_tls_load_module_address" and "get_thread_local_address"
9865         methods.
9866
9867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9868
9869         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9870         (struct fbsd_pspace_data): New type.
9871         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9872         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9873         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9874         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9875         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9876
9877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9878
9879         * gdbtypes.c (lookup_struct_elt): New function.
9880         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9881         * gdbtypes.h (struct struct_elt): New type.
9882         (lookup_struct_elt): New prototype.
9883
9884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9885
9886         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9887         remove disabled code block.
9888
9889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9890
9891         * gdbarch.sh (get_thread_local_address): New method.
9892         * gdbarch.h, gdbarch.c: Regenerate.
9893         * target.c (target_translate_tls_address): Use
9894         gdbarch_get_thread_local_address if present instead of
9895         target::get_thread_local_address.
9896
9897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9898
9899         * target.h (target::get_thread_local_address): Update comment.
9900
9901 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9902
9903         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9904         objfile->separate_debug_objfile_backlink if not NULL.
9905
9906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9907
9908         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9909         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9910         (amd64bsd_store_inferior_registers): Likewise.
9911         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9912         Enable segment base registers.
9913         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9914         PT_GETFSBASE and PT_GETGSBASE.
9915         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9916         PT_SETGSBASE.
9917         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9918         segment base registers.
9919         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9920
9921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9922
9923         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9924         Update calls to i386_target_description to add 'segments'
9925         parameter.
9926         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9927         add segment base registers.
9928         * arch/i386.c (i386_create_target_description): Add 'segments'
9929         parameter to enable segment base registers.
9930         * arch/i386.h (i386_create_target_description): Likewise.
9931         * features/i386/32bit-segments.xml: New file.
9932         * features/i386/32bit-segments.c: Generate.
9933         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9934         call to i386_target_description to add 'segments' parameter.
9935         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9936         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9937         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9938         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9939         if feature is present.
9940         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9941         Add 'segments' parameter to call to i386_target_description.
9942         (i386_target_description): Add 'segments' parameter to enable
9943         segment base registers.
9944         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9945         to call to i386_target_description.
9946         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9947         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9948         Define I386_NUM_REGS.
9949         (i386_target_description): Add 'segments' parameter to enable
9950         segment base registers.
9951
9952 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9953
9954         PR/24325
9955         * source-cache.c: #undef open and close, to avoid unresolved
9956         externals during linking.
9957
9958 2019-03-12  Tom Tromey  <tromey@adacore.com>
9959
9960         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9961         const.  Add initializers.
9962         (_initialize_remote): Don't initialize ptid globals.
9963
9964 2019-03-12  Pedro Alves  <palves@redhat.com>
9965
9966         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9967
9968 2019-03-12  Pedro Alves  <palves@redhat.com>
9969
9970         * cp-name-parser.y (main): Remove unused 'len' variable.
9971
9972 2019-03-12  Tom Tromey  <tromey@adacore.com>
9973
9974         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9975         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9976
9977 2019-03-12  Tom Tromey  <tromey@adacore.com>
9978
9979         * linux-nat.c (iterate_over_lwps): Update.
9980         (stop_callback): Remove parameter.
9981         (stop_wait_callback, detach_callback, resume_set_callback)
9982         (select_singlestep_lwp_callback, set_ignore_sigint)
9983         (status_callback, resumed_callback, resume_clear_callback)
9984         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9985         data parameter.
9986         (linux_nat_target::detach, linux_nat_target::resume)
9987         (linux_stop_and_wait_all_lwps, select_event_lwp)
9988         (linux_nat_filter_event, linux_nat_wait_1)
9989         (linux_nat_target::kill, linux_nat_target::stop)
9990         (linux_nat_target::stop): Update.
9991         (linux_nat_resume_callback): Change type.
9992         (resume_stopped_resumed_lwps, count_events_callback)
9993         (select_event_lwp_callback): Likewise.
9994         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9995         * arm-linux-nat.c (struct update_registers_data): Remove.
9996         (update_registers_callback): Change type.
9997         (arm_linux_insert_hw_breakpoint1): Update.
9998         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9999         parameter.
10000         (x86_linux_dr_set_addr): Update.
10001         (x86_linux_dr_set_control): Update.
10002         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10003         (iterate_over_lwps): Use gdb::function_view.
10004         * nat/aarch64-linux-hw-point.c (struct
10005         aarch64_dr_update_callback_param): Remove.
10006         (debug_reg_change_callback): Change type.
10007         (aarch64_notify_debug_reg_change): Update.
10008         * s390-linux-nat.c (s390_refresh_per_info): Update.
10009
10010 2019-03-11  Tom Tromey  <tromey@adacore.com>
10011
10012         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10013         redundant assignment to "this_cu".
10014
10015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10016
10017         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10018
10019 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10020
10021         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10022         from...
10023         (rank_one_type): ... this.
10024
10025 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10026
10027         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10028         from...
10029         (rank_one_type): ... this.
10030
10031 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10032
10033         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10034         from...
10035         (rank_one_type): ... this.
10036
10037 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10038
10039         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10040         from...
10041         (rank_one_type): ... this.
10042
10043 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10044
10045         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10046         from...
10047         (rank_one_type): ... this.
10048
10049 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10050
10051         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10052         from...
10053         (rank_one_type): ... this.
10054
10055 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10056
10057         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10058         from...
10059         (rank_one_type): ... this.
10060
10061 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10062
10063         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10064         from...
10065         (rank_one_type): ... this.
10066
10067 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10068
10069         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10070         from...
10071         (rank_one_type): ... this.
10072
10073 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10074
10075         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10076         from...
10077         (rank_one_type): ... this.
10078
10079 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10080
10081         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10082         from...
10083         (rank_one_type): ... this.
10084
10085 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10086
10087         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10088         from...
10089         (rank_one_type): ... this.
10090
10091 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10092
10093         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10094         inferior-events' shows the example events.
10095
10096 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10097
10098         Support styling on native MS-Windows console
10099
10100         PR/24315
10101         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10102         on MS-Windows if $TERM is not defined.
10103
10104         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10105
10106         * posix-hdep.c (gdb_console_fputs):
10107         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10108         functions.
10109         * ui-file.h (gdb_console_fputs): Add prototype.
10110
10111         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10112         back to fputs only if the former returns zero.
10113
10114 2019-03-07  Tom Tromey  <tom@tromey.com>
10115
10116         * symmisc.c (print_symbol_bcache_statistics): Update.
10117         (print_objfile_statistics): Update.
10118         * symfile.c (allocate_symtab): Update.
10119         * stabsread.c: Don't include bcache.h.
10120         * psymtab.h (struct psymbol_bcache): Don't declare.
10121         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10122         (psymbol_bcache_init, psymbol_bcache_free)
10123         (psymbol_bcache_get_bcache): Don't declare.
10124         * psymtab.c (struct psymbol_bcache): Remove.
10125         (psymtab_storage::psymtab_storage): Update.
10126         (psymtab_storage::~psymtab_storage): Update.
10127         (psymbol_bcache_init, psymbol_bcache_free)
10128         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10129         (add_psymbol_to_bcache): Update.
10130         (allocate_psymtab): Update.
10131         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10132         macro_cache>: No longer pointers.
10133         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10134         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10135         * macrotab.c (macro_bcache): Update.
10136         * macroexp.c: Don't include bcache.h.
10137         * gdbtypes.c (check_types_worklist): Update.
10138         (types_deeply_equal): Remove TRY/CATCH.  Update.
10139         * elfread.c (elf_symtab_read): Update.
10140         * dwarf2read.c: Don't include bcache.h.
10141         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10142         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10143         (print_bcache_statistics, bcache_memory_used): Don't declare.
10144         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10145         methods.  Rename all data members.
10146         * bcache.c (struct bcache): Move to bcache.h.
10147         (bcache::expand_hash_table): Rename from expand_hash_table.
10148         (bcache): Remove.
10149         (bcache::insert): Rename from bcache_full.
10150         (bcache::compare): Rename from bcache_compare.
10151         (bcache_xmalloc): Remove.
10152         (bcache::~bcache): Rename from bcache_xfree.
10153         (bcache::print_statistics): Rename from print_bcache_statistics.
10154         (bcache::memory_used): Rename from bcache_memory_used.
10155
10156 2019-03-07  Pedro Alves  <palves@redhat.com>
10157
10158         * infrun.c (normal_stop): Also check for
10159         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10160
10161 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10162
10163         * f-lang.c (value_from_host_double): Moved to...
10164         * value.c (value_from_host_double): ...here.
10165         * value.h (value_from_host_double): Declare.
10166         * guile/scm-math.c (vlscm_convert_typed_number): Use
10167         value_from_host_double.
10168         (vlscm_convert_number): Likewise.
10169         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10170         * python/py-value.c (convert_value_from_python): Likewise.
10171
10172 2019-03-06  Tom Tromey  <tom@tromey.com>
10173
10174         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10175
10176 2019-03-06  Tom Tromey  <tom@tromey.com>
10177
10178         * utils.h (free_current_contents): Don't declare.
10179         * utils.c (free_current_contents): Remove.
10180
10181 2019-03-06  Tom Tromey  <tom@tromey.com>
10182
10183         * top.c (quit_force): Update.
10184         * main.c (captured_command_loop): Update.
10185         * common/new-op.c (operator new): Update.
10186         * common/common-exceptions.c (struct catcher)
10187         <save_cleanup_chain>: Remove member.
10188         (exceptions_state_mc_init): Update.
10189         (exception_try_scope_entry): Return nullptr.
10190         (exception_try_scope_exit, exception_rethrow)
10191         (throw_exception_sjlj, throw_exception_cxx): Update.
10192         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10193         (all_cleanups, do_cleanups, discard_cleanups)
10194         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10195         (restore_cleanups, restore_final_cleanups): Don't declare.
10196         (do_final_cleanups): Remove parameter.
10197         * common/cleanups.c (cleanup_chain, make_cleanup)
10198         (make_cleanup_dtor, all_cleanups, do_cleanups)
10199         (discard_my_cleanups, discard_cleanups)
10200         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10201         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10202         (null_cleanup): Remove.
10203         (do_final_cleanups): Remove parameter.
10204
10205 2019-03-06  Tom Tromey  <tom@tromey.com>
10206
10207         * remote.c (remote_target::remote_parse_stop_reply): Use
10208         unique_xmalloc_ptr.
10209
10210 2019-03-06  Tom Tromey  <tom@tromey.com>
10211
10212         * stabsread.c (struct stabs_field_info): Rename from field_info.
10213         <list, fnlist>: Add initializers.
10214         <obstack>: New member.
10215         (read_member_functions, read_struct_fields, read_baseclasses):
10216         Allocate on obstack.  Don't use cleanups.
10217         (read_one_struct_field, read_member_functions, read_struct_fields)
10218         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10219         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10220         (read_struct_type): Update.
10221
10222 2019-03-06  Tom Tromey  <tom@tromey.com>
10223
10224         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10225         * common/filestuff.h (make_cleanup_close): Don't declare.
10226         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10227         Remove.
10228
10229 2019-03-06  Tom Tromey  <tom@tromey.com>
10230
10231         * solib-aix.c: Use make_scope_exit.
10232
10233 2019-03-06  Tom Tromey  <tom@tromey.com>
10234
10235         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10236         Use make_scope_exit.
10237
10238 2019-03-06  Tom Tromey  <tom@tromey.com>
10239
10240         * solib-svr4.c (disable_probes_interface): Remove parameter.
10241         (svr4_handle_solib_event): Use make_scope_exit.
10242
10243 2019-03-06  Tom Tromey  <tom@tromey.com>
10244
10245         * remote.c (struct stop_reply_deleter): Remove.
10246         (stop_reply_up): Update.
10247         (struct stop_reply): Derive from notif_event.  Don't typedef.
10248         <regcache>: Now a std::vector.
10249         (stop_reply_xfree): Remove.
10250         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10251         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10252         (remote_target::discard_pending_stop_replies): Use delete.
10253         (remote_target::remote_parse_stop_reply): Update.
10254         (remote_target::process_stop_reply): Update.
10255         * remote-notif.h (struct notif_event): Add virtual destructor.
10256         Remove "dtr" member.
10257         (struct notif_client) <alloc_event>: Return a unique_ptr.
10258         (notif_event_xfree): Don't declare.
10259         (notif_event_up): New typedef.
10260         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10261         (notif_event_xfree, do_notif_event_xfree): Remove.
10262         (remote_notif_state_xfree): Update.
10263
10264 2019-03-06  Tom Tromey  <tom@tromey.com>
10265
10266         * infrun.c (displaced_step_clear_cleanup): Now a
10267         forward_scope_exit type.
10268         (displaced_step_prepare_throw): Update.
10269         (displaced_step_fixup): Update.
10270
10271 2019-03-06  Tom Tromey  <tom@tromey.com>
10272
10273         * inferior.h (class inferior): Update comment.
10274         * gdbthread.h (class thread_info): Update comment.
10275
10276 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10277             Tom Tromey  <tom@tromey.com>
10278
10279         * stabsread.h (struct stab_section_list): Remove.
10280         (coffstab_build_psymtabs): Update.
10281         * dbxread.c (symbuf_sections): Now a std::vector.
10282         (sect_idx): New global.
10283         (fill_symbuf): Update.
10284         (coffstab_build_psymtabs): Change type of stabsects parameter.
10285         Update.
10286         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10287         std::vector.
10288         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10289         (coff_locate_sections): Update.
10290         (coff_symfile_read): Remove cleanups.  Update.
10291         (init_stringtab): Add storage parameter.
10292         (free_stringtab, free_stringtab_cleanup): Remove.
10293         (init_lineno): Add storage parameter.
10294         (free_linetab, free_linetab_cleanup): Remove.
10295
10296 2019-03-06  Pedro Alves  <palves@redhat.com>
10297
10298         * linux-fork.c (fork_info::clobber_regs): Delete.
10299         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10300         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10301         comment.  Adjust.
10302         (scoped_switch_fork_info::scoped_switch_fork_info)
10303         (checkpoint_command, linux_fork_context): Adjust
10304         fork_save_infrun_state calls.
10305
10306 2019-03-06  Pedro Alves  <palves@redhat.com>
10307
10308         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10309         (inf_has_multiple_threads): Return 'bool' and rewrite using
10310         inferior_info::threads().
10311
10312 2019-03-06  Pedro Alves  <palves@redhat.com>
10313
10314         * linux-fork.c: Include <list>.
10315         (fork_list): Now a std::list instance.
10316         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10317         (forks_exist_p, find_last_fork): Adjust.
10318         (new_fork): Delete.
10319         (one_fork_p): New.
10320         (add_fork): Adjust.
10321         (free_fork): Delete, folded into fork_info::~fork_info().
10322         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10323         Adjust.
10324         (init_fork_list): Delete.
10325         (linux_fork_killall, linux_fork_mourn_inferior)
10326         (linux_fork_detach, info_checkpoints_command): Adjust.
10327         (_initialize_linux_fork): No longer call init_fork_list.
10328
10329 2019-03-06  Pedro Alves  <palves@redhat.com>
10330
10331         * linux-fork.c (new_fork): New, split out of ...
10332         (add_fork): ... this.  Return void.  Move "first fork" special
10333         case from here, to ...
10334         (checkpoint_command): ... here.
10335         * linux-linux.h (add_fork): Return void.
10336
10337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10338
10339         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10340
10341 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10342             Chris January  <chris.january@arm.com>
10343             David Lecomber  <david.lecomber@arm.com>
10344
10345         * f-exp.y: New token, UNOP_INTRINSIC.
10346         (exp): New pattern using UNOP_INTRINSIC token.
10347         (f77_keywords): Add 'abs' keyword.
10348         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10349         (value_from_host_double): New function.
10350         (evaluate_subexp_f): Support UNOP_ABS.
10351
10352 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10353
10354         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10355         types.
10356
10357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10358
10359         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10360         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10361         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10362
10363 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10364
10365         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10366
10367 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10368             Chris January  <chris.january@arm.com>
10369
10370         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10371         * f-exp.y: Define 'KIND' token.
10372         (exp): New pattern for KIND expressions.
10373         (ptype): Handle types with a kind extension.
10374         (direct_abs_decl): Extend to spot kind extensions.
10375         (f77_keywords): Add 'kind' to the list.
10376         (push_kind_type): New function.
10377         (convert_to_kind_type): New function.
10378         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10379         * parse.c (operator_length_standard): Likewise.
10380         * parser-defs.h (enum type_pieces): Add tp_kind.
10381         * std-operator.def: Add UNOP_KIND.
10382
10383 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10384
10385         * f-exp.y (f_parse): Set yydebug.
10386
10387 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10388
10389         * f-lang.c (evaluate_subexp_f): New function.
10390         (exp_descriptor_f): New global.
10391         (f_language_defn): Use exp_descriptor_f instead of
10392         exp_descriptor_standard.
10393
10394 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10395
10396         * f-exp.y (struct token): Add comments.
10397         (dot_ops): Remove uppercase versions and the end marker.
10398         (f77_keywords): Likewise.
10399         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10400         entries in the dot_ops array are case insensitive, and use
10401         strncasecmp to compare strings.  Also some whitespace cleanup in
10402         this area.  Similar for the f77_keywords array, except entries in
10403         this list might be case sensitive.
10404
10405 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10406
10407         * f-exp.y (struct f77_boolean_val): Add comments.
10408         (boolean_values): Remove uppercase versions, and end marker.
10409         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10410         and use strncasecmp to achieve case insensitivity.  Additionally,
10411         perform whitespace cleanup around this code.
10412
10413 2019-03-06  Tom Tromey  <tromey@adacore.com>
10414
10415         * remote-sim.c (gdbsim_target_open): Use result of
10416         gdb_argv::release.
10417
10418 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10419         Dirk Schubert  <dirk.schubert@arm.com>
10420         Chris January  <chris.january@arm.com>
10421
10422         * eval.c (evaluate_subexp_standard): Call Fortran argument
10423         wrapping logic.
10424         * f-lang.c (struct value): A value which can be passed into a
10425         Fortran function call.
10426         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10427         where appropriate.
10428         (struct type): Value ready for a Fortran function call.
10429         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10430         is needed.
10431         * f-lang.h (fortran_argument_convert): Declaration.
10432         (fortran_preserve_arg_pointer): Declaration.
10433         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10434
10435 2019-03-05  Tom Tromey  <tromey@adacore.com>
10436
10437         * python/py-prettyprint.c (print_string_repr): Remove #if.
10438         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10439
10440 2019-03-05  Tom Tromey  <tromey@adacore.com>
10441
10442         * target.c (the_dummy_target): Move later.  Change type to
10443         "dummy_target".
10444         (initialize_targets): Don't initialize the_dummy_target.
10445
10446 2019-03-05  Tom Tromey  <tromey@adacore.com>
10447
10448         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10449         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10450
10451 2019-03-05  Tom Tromey  <tromey@adacore.com>
10452
10453         * windows-nat.c (windows_nat_target::attach)
10454         (windows_nat_target::detach): Don't call gdb_flush.
10455         * valprint.c (generic_val_print, val_print, val_print_string):
10456         Don't call gdb_flush.
10457         * utils.c (defaulted_query): Don't call gdb_flush.
10458         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10459         * target.c (target_announce_detach): Don't call gdb_flush.
10460         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10461         * remote.c (extended_remote_target::attach): Don't call
10462         gdb_flush.
10463         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10464         * printcmd.c (do_examine): Don't call gdb_flush.
10465         (info_display_command): Don't call gdb_flush.
10466         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10467         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10468         * memattr.c (info_mem_command): Don't call gdb_flush.
10469         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10470         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10471         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10472         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10473         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10474         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10475         (gnu_nat_target::detach): Don't call gdb_flush.
10476         * f-valprint.c (f_val_print): Don't call gdb_flush.
10477         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10478         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10479         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10480         gdb_flush.
10481         * c-valprint.c (c_val_print): Don't call gdb_flush.
10482         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10483
10484 2019-03-05  Tom Tromey  <tromey@adacore.com>
10485
10486         * varobj.c (update_dynamic_varobj_children): Update.
10487         (install_default_visualizer): Use reset, not release.
10488         * value.c (set_internalvar): Update.
10489         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10490         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10491         ATTRIBUTE_UNUSED_RESULT.
10492
10493 2019-03-05  Tom Tromey  <tromey@adacore.com>
10494
10495         * remote.c (class scoped_remote_fd) <release>: Add
10496         ATTRIBUTE_UNUSED_RESULT.
10497
10498 2019-03-05  Tom Tromey  <tromey@adacore.com>
10499
10500         * macroexp.c (struct macro_buffer) <release>: Add
10501         ATTRIBUTE_UNUSED_RESULT.
10502
10503 2019-03-05  Tom Tromey  <tromey@adacore.com>
10504
10505         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10506         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10507         ATTRIBUTE_UNUSED_RESULT.
10508
10509 2019-03-05  Tom Tromey  <tromey@adacore.com>
10510
10511         * common/scoped_fd.h (class scoped_fd) <release>: Add
10512         ATTRIBUTE_UNUSED_RESULT.
10513
10514 2019-03-05  Tom Tromey  <tromey@adacore.com>
10515
10516         * parser-defs.h (struct parser_state) <release>: Add
10517         ATTRIBUTE_UNUSED_RESULT.
10518
10519 2019-03-05  Tom Tromey  <tromey@adacore.com>
10520
10521         * utils.h (class gdb_argv) <release>: Add
10522         ATTRIBUTE_UNUSED_RESULT.
10523         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10524
10525 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10526
10527         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10528         for-loop range, to avoid compiler warnings.
10529
10530         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10531         avoid compiler warnings about unused variables.
10532
10533         * NEWS: Mention end of support for native debugging on MS-Windows
10534         before XP.
10535
10536         PR gdb/24292
10537         * common/netstuff.c:
10538         * gdbserver/gdbreplay.c
10539         * gdbserver/remote-utils.c:
10540         * ser-tcp.c:
10541         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10542         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10543         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10544         'getaddrinfo' and 'freeaddrinfo' were not available before
10545         Windows XP, and mingw.org's MinGW headers by default define
10546         _WIN32_WINNT to 0x500.
10547
10548 2019-03-01  Gary Benson <gbenson@redhat.com>
10549
10550         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10551
10552 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10553             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10554
10555         PR gdb/8527
10556         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10557         set_sigint_trap, clear_sigint_trap.
10558
10559 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10560
10561         * target.c (target_detach): Clear the regcache and the
10562         frame cache.
10563
10564 2019-02-27  Pedro Alves  <palves@redhat.com>
10565
10566         * utils.c (set_screen_size): When we cap the height/width sizes,
10567         tweak the corresponding command variable to show "unlimited":
10568
10569 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10570             Pedro Alves  <palves@redhat.com>
10571
10572         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10573         before calling rl_set_screen_size.
10574
10575 2019-02-27  Tom Tromey  <tromey@adacore.com>
10576
10577         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10578         define.
10579         * python/py-value.c: Remove Python 2.4 workaround.
10580         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10581         workaround.
10582         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10583         Python 2.4 workaround.
10584         * python/python-internal.h: Remove Python 2.4 comment.
10585         (Py_ssize_t): Don't define.
10586         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10587         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10588         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10589         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10590         * python/python.c (do_start_initialization): Remove Python 2.4
10591         workaround.
10592         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10593         (print_children): Remove Python 2.4 workaround.
10594         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10595         workaround.
10596         (CHARBUFFERPROC_NAME): Remove.
10597         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10598         Python 2.4 workaround.
10599
10600 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10601
10602         * NEWS: Note minimum Python version.
10603
10604 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10605
10606         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10607         code from these functions.  Remove corresponding ifdefs.  Use
10608         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10609         Remove gotos and target of gotos.
10610         (infpy_search_memory): Likewise.
10611
10612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10613
10614         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10615         (hppa_gdbarch_init): Don't register deleted functions with
10616         gdbarch.
10617
10618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10619
10620         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10621         (h8300_unwind_sp): Delete.
10622         (h8300_dummy_id): Delete.
10623         (h8300_gdbarch_init): Don't register deleted functions with
10624         gdbarch.
10625
10626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10627
10628         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10629         (ft32_unwind_pc): Delete.
10630         (ft32_unwind_sp): Delete.
10631         (ft32_gdbarch_init): Don't register deleted functions with
10632         gdbarch.
10633
10634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10635
10636         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10637         (frv_unwind_pc): Delete.
10638         (frv_unwind_sp): Delete.
10639         (frv_gdbarch_init): Don't register deleted functions with
10640         gdbarch.
10641
10642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10643
10644         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10645         (riscv_unwind_pc): Delete.
10646         (riscv_unwind_sp): Delete.
10647         (riscv_gdbarch_init): Don't register deleted functions with
10648         gdbarch.
10649
10650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10651
10652         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10653         (csky_unwind_pc): Delete.
10654         (csky_unwind_sp): Delete.
10655         (csky_gdbarch_init): Don't register deleted functions with
10656         gdbarch.
10657
10658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10659
10660         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10661         (cris_unwind_pc): Delete.
10662         (cris_unwind_sp): Delete.
10663         (cris_gdbarch_init): Don't register deleted functions with
10664         gdbarch.
10665
10666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10667
10668         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10669         (bfin_unwind_pc): Delete.
10670         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10671
10672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10673
10674         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10675         (arm_unwind_pc): Delete.
10676         (arm_unwind_sp): Delete.
10677         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10678
10679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10680
10681         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10682         (arc_unwind_pc): Delete.
10683         (arc_unwind_sp): Delete.
10684         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10685
10686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10687
10688         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10689         (alpha_unwind_pc): Delete.
10690         (alpha_gdbarch_init): Don't register deleted functions with
10691         gdbarch.
10692
10693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10694
10695         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10696         (aarch64_unwind_pc): Delete.
10697         (aarch64_unwind_sp): Delete.
10698         (aarch64_gdbarch_init): Don't register deleted functions with
10699         gdbarch.
10700
10701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10702
10703         * gdbtypes.c (type_align): Don't consider static members when
10704         computing structure alignment.
10705
10706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10707
10708         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10709         return 0 for other types.
10710         * arch-utils.c (default_type_align): Always return 0.
10711         * gdbarch.h: Regenerate.
10712         * gdbarch.sh (type_align): Extend comment.
10713         * gdbtypes.c (type_align): Add additional comments, always call
10714         gdbarch_type_align before applying the default rules.
10715         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10716         generic code will then apply a suitable default.
10717         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10718         types, return 0 for other types.
10719
10720 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10721
10722         * NEWS: Create a new section for the next release branch.
10723         Rename the section of the current branch, now that it has
10724         been cut.
10725
10726 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10727
10728         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10729         * version.in: Bump version to 8.3.50.DATE-git.
10730
10731 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10732
10733         * aix-thread.c (ptid_cmp): Remove unused variable.
10734         (get_signaled_thread): Likewise.
10735         (store_regs_user_thread): Likewise.
10736         (store_regs_kernel_thread): Likewise.
10737         (fetch_regs_kernel_thread): Remove shadowed variable.
10738
10739 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10740
10741         * features/riscv/32bit-cpu.xml: Add register numbers.
10742         * features/riscv/32bit-fpu.c: Regenerate.
10743         * features/riscv/32bit-fpu.xml: Add register numbers.
10744         * features/riscv/64bit-cpu.xml: Add register numbers.
10745         * features/riscv/64bit-fpu.c: Regenerate.
10746         * features/riscv/64bit-fpu.xml: Add register numbers.
10747
10748 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10749
10750         * NEWS: Mention two argument form of gdb.Value constructor.
10751         * python/py-value.c (convert_buffer_and_type_to_value): New
10752         function.
10753         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10754         Add support for handling an optional second argument.  Call
10755         convert_buffer_and_type_to_value as appropriate.
10756         * python/python-internal.h (Py_buffer_deleter): New struct.
10757         (Py_buffer_up): New typedef.
10758
10759 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10760
10761         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10762         instead of releasing ownership.
10763
10764 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10765
10766         * dwarf2read.c (open_and_init_dwp_file): Call
10767         elf_numsections instead of bfd_count_sections to initialize
10768         dwp_file->num_sections.
10769
10770 2019-02-25  Tom Tromey  <tromey@adacore.com>
10771
10772         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10773
10774 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10775
10776         * gcore.in: Add '--readnever' option when invoking GDB.
10777
10778 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10779
10780         * MAINTAINERS: Update my email address.
10781
10782 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10783
10784         * build-id.c (build_id_to_debug_bfd_1): New function.
10785         (build_id_to_debug_bfd): Look for separate debug file in
10786         sysroot.
10787
10788 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10789
10790         * gdbarch.sh: Update the copyright year range that is placed into
10791         generated files.
10792
10793 2019-02-22  Keith Seitz  <keiths@redhat.com>
10794
10795         PR symtab/23853
10796         * linespec.c (create_sals_line_offset): Search for the default
10797         symtab's filename instead of its fullname.
10798
10799 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10800
10801         * NEWS: Update style defaults.
10802
10803 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10804
10805         * main.c (captured_main_1): Disable styling in batch mode.
10806
10807 2019-02-20  Tom Tromey  <tom@tromey.com>
10808
10809         * symtab.c (symtab_symbol_info): Fix typos.
10810
10811 2019-02-20  Tom Tromey  <tromey@adacore.com>
10812
10813         * findcmd.c (_initialize_mem_search): Use upper case for
10814         metasyntactic variables.
10815
10816 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10817
10818         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10819         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10820
10821 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10822
10823         * top.h (source_file_name): Change to std::string.
10824         * top.c (source_file_name): Likewise.
10825         (command_line_input): Adjust.
10826         * cli/cli-script.c (script_from_file): Adjust.
10827
10828 2019-02-19  Tom Tromey  <tromey@adacore.com>
10829
10830         * ravenscar-thread.c
10831         (ravenscar_thread_target::update_thread_list): Don't call
10832         ada_build_task_list.
10833         * ada-lang.h (ada_build_task_list): Don't declare.
10834         * ada-tasks.c (struct ada_tasks_inferior_data)
10835         <task_list_valid_p>: Now bool.
10836         (read_known_tasks, ada_task_list_changed)
10837         (ada_tasks_invalidate_inferior_data): Update.
10838         (read_known_tasks_array): Return bool.
10839         (read_known_tasks_list): Likewise.
10840         (read_known_tasks): Return void.
10841         (ada_build_task_list): Now static.
10842
10843 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10844
10845         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10846         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10847
10848 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10849
10850         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10851         variant for ada_tasks_pspace_data_handle and
10852         ada_tasks_inferior_data_handle.
10853         (ada_tasks_pspace_data_cleanup): New function.
10854         (ada_tasks_inferior_data_cleanup): New function.
10855
10856 2019-02-17  Tom Tromey  <tom@tromey.com>
10857
10858         * macrotab.h (macro_source_fullname): Return a std::string.
10859         * macrotab.c (macro_include, check_for_redefinition)
10860         (macro_undef, macro_lookup_definition, foreach_macro)
10861         (foreach_macro_in_scope): Update.
10862         (macro_source_fullname): Return a std::string.
10863         * macrocmd.c (show_pp_source_pos): Update.
10864
10865 2019-02-17  Tom Tromey  <tom@tromey.com>
10866
10867         * macrocmd.c (show_pp_source_pos): Style the file names.
10868
10869 2019-02-17  Tom Tromey  <tom@tromey.com>
10870
10871         PR tui/24197:
10872         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10873
10874 2019-02-17  Tom Tromey  <tom@tromey.com>
10875
10876         * ada-lang.c (user_select_syms): Use filtered printing.
10877         * utils.c (wrap_style): New global.
10878         (desired_style): Remove.
10879         (emit_style_escape): Add stream parameter.
10880         (set_output_style, reset_terminal_style, prompt_for_continue):
10881         Update.
10882         (flush_wrap_buffer): Only flush gdb_stdout.
10883         (wrap_here): Set wrap_style.
10884         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10885         treat escape sequences as a character.  Change when wrap buffer is
10886         flushed.
10887         (fputs_styled): Do not set the output style when the default is
10888         requested.
10889         * ui-style.h (struct ui_file_style) <is_default>: New method.
10890         * source.c (print_source_lines_base): Emit escape sequences in one
10891         piece.
10892
10893 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10894
10895         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10896         integers and enumeration types.
10897
10898 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10899
10900         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10901         instead of lookup_symbol_in_language
10902         (do_exact_match): New function.
10903         (ada_get_symbol_name_matcher): Return do_exact_match when
10904         doing a verbatim match.
10905
10906 2019-02-15  Tom Tromey  <tromey@adacore.com>
10907
10908         * ravenscar-thread.c (ravenscar_thread_target::resume)
10909         (ravenscar_thread_target::wait): Special case wildcard requests.
10910
10911 2019-02-15  Tom Tromey  <tromey@adacore.com>
10912
10913         * ravenscar-thread.c (base_ptid): Remove.
10914         (struct ravenscar_thread_target) <close>: New method.
10915         <m_base_ptid>: New member.
10916         <update_inferior_ptid, active_task, task_is_currently_active,
10917         runtime_initialized>: Declare methods.
10918         <ravenscar_thread_target>: Add constructor.
10919         (ravenscar_thread_target::task_is_currently_active)
10920         (ravenscar_thread_target::update_inferior_ptid)
10921         (ravenscar_runtime_initialized): Rename.  Now methods.
10922         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10923         (ravenscar_thread_target::update_thread_list): Update.
10924         (ravenscar_thread_target::active_task): Now method.
10925         (ravenscar_thread_target::store_registers)
10926         (ravenscar_thread_target::prepare_to_store)
10927         (ravenscar_thread_target::prepare_to_store)
10928         (ravenscar_thread_target::mourn_inferior): Update.
10929         (ravenscar_inferior_created): Use "new" to create target.
10930         (ravenscar_thread_target::get_ada_task_ptid): Update.
10931         (_initialize_ravenscar): Don't initialize base_ptid.
10932         (ravenscar_ops): Remove global.
10933
10934 2019-02-15  Tom Tromey  <tromey@adacore.com>
10935
10936         * target.h (push_target): Declare new overload.
10937         * target.c (push_target): New overload, taking an rvalue reference.
10938         * remote.c (remote_target::open_1): Use push_target overload.
10939         * corelow.c (core_target_open): Use push_target overload.
10940
10941 2019-02-15  Tom Tromey  <tromey@adacore.com>
10942
10943         * ravenscar-thread.c (is_ravenscar_task)
10944         (ravenscar_task_is_currently_active): Return bool.
10945         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10946         (_initialize_ravenscar): Remove "(void)".
10947         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10948         Return bool.
10949
10950 2019-02-15  Tom Tromey  <tromey@adacore.com>
10951
10952         * ravenscar-thread.c (ravenscar_runtime_initializer)
10953         (has_ravenscar_runtime, get_running_thread_id)
10954         (ravenscar_thread_target::resume): Fix indentation.
10955
10956 2019-02-15  Tom Tromey  <tromey@adacore.com>
10957
10958         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10959         from ravenscar_arch_ops.
10960         (sparc_ravenscar_ops::fetch_registers)
10961         (sparc_ravenscar_ops::store_registers): Now methods.
10962         (sparc_ravenscar_prepare_to_store): Remove.
10963         (sparc_ravenscar_ops): Redefine.
10964         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10965         methods and destructor.  Remove members.
10966         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10967         (ravenscar_thread_target::store_registers)
10968         (ravenscar_thread_target::prepare_to_store): Update.
10969         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10970         Remove.
10971         (struct ppc_ravenscar_powerpc_ops): Derive from
10972         ravenscar_arch_ops.
10973         (ppc_ravenscar_powerpc_ops::fetch_registers)
10974         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10975         (ppc_ravenscar_powerpc_ops): Redefine.
10976         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10977         (ppc_ravenscar_e500_ops::fetch_registers)
10978         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10979         (ppc_ravenscar_e500_ops): Redefine.
10980         * aarch64-ravenscar-thread.c
10981         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10982         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10983         (aarch64_ravenscar_fetch_registers)
10984         (aarch64_ravenscar_store_registers): Now methods.
10985         (aarch64_ravenscar_ops): Redefine.
10986
10987 2019-02-15  Tom Tromey  <tromey@adacore.com>
10988
10989         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10990         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10991         (ravenscar_thread_target::stopped_by_watchpoint)
10992         (ravenscar_thread_target::stopped_data_address)
10993         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10994
10995 2019-02-15  Tom Tromey  <tromey@adacore.com>
10996
10997         * ravenscar-thread.c: Fix some typos.
10998
10999 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11000             Tom Tromey  <tromey@adacore.com>
11001
11002         * ada-lang.c (ada_exception_sal): Change addr_string to a
11003         std::string.
11004         (create_ada_exception_catchpoint): Update.
11005
11006 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11007             Tom Tromey  <tromey@adacore.com>
11008
11009         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11010         (bp_location_ops): Remove.
11011         (base_breakpoint_allocate_location): Update.
11012         (free_bp_location): Update.
11013         * ada-lang.c (class ada_catchpoint_location)
11014         <ada_catchpoint_location>: Remove ops parameter.
11015         (ada_catchpoint_location_dtor): Remove.
11016         (ada_catchpoint_location_ops): Remove.
11017         (allocate_location_exception): Update.
11018         * breakpoint.h (struct bp_location_ops): Remove.
11019         (class bp_location) <bp_location>: Remove bp_location_ops
11020         parameter.
11021         <~bp_location>: Add destructor.
11022         <ops>: Remove.
11023
11024 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11025             Pedro Alves  <palves@redhat.com>
11026
11027         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11028         'PATH_MAX'.
11029
11030 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11031             Samuel Thibault  <samuel.thibault@gnu.org>
11032             Thomas Schwinge  <thomas@codesourcery.com>
11033
11034         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11035         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11036
11037 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11038
11039         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11040         (check_empty): Use "const char *".
11041
11042         * gnu-nat.c (gnu_nat_target::detach): Instead of
11043         'detach_inferior (pid)' call
11044         'detach_inferior (find_inferior_pid (pid))'.
11045
11046         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11047         'nat/fork-inferior.o'.
11048         * gnu-nat.c: #include "nat/fork-inferior.h".
11049
11050         * gnu-nat.c (gnu_nat_target::detach): Instead of
11051         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11052         * gnu-nat.h: #include "inf-child.h".
11053         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11054         'i386_gnu_nat_target::fetch_registers'.
11055         (gnu_store_registers): Rename/move to
11056         'i386_gnu_nat_target::store_registers'.
11057
11058         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11059         * gnu-nat.h (mach_thread_info): New function.
11060         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11061
11062         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11063
11064 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11065
11066         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11067
11068 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11069
11070         * windows-nat.c (windows_add_thread): Add new parameter
11071         "main_thread_p" with default value set to false.  Update
11072         function documentation as well as all callers.
11073         (windows_delete_thread): Likewise.
11074         (fake_create_process): Update call to windows_add_thread.
11075         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11076         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11077         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11078         call to windows_delete_thread.
11079
11080 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11081
11082         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11083
11084 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11085
11086         * symfile.c (find_separate_debug_file): Use canonical path of
11087         sysroot with child_path instead of gdb_sysroot if it is valid.
11088
11089 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11090
11091         * symfile.c (find_separate_debug_file): Use child_path to
11092         determine if an object file is under a sysroot.
11093
11094 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11095
11096         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11097         unittests/child-path-selftests.c.
11098         * common/pathstuff.c (child_path): New function.
11099         * common/pathstuff.h (child_path): New prototype.
11100         * unittests/child-path-selftests.c: New file.
11101
11102 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11103
11104         * symfile.c (find_separate_debug_file): Look for separate debug
11105         files in debug directories under the sysroot.
11106
11107 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11108
11109         * symtab.h (struct minimal_symbol data_p): New const method.
11110         (struct minimal_symbol text_p): Likewise.
11111         * symtab.c (output_source_filename): Use file name style
11112         to print file name.
11113         (print_symbol_info): Likewise.
11114         (print_msymbol_info): Use address style to print addresses.
11115         Use function name style to print executable text symbols.
11116         (expand_symtab_containing_pc): Use data_p.
11117         (find_pc_sect_compunit_symtab): Likewise.
11118
11119 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11120
11121         * breakpoint.c (describe_other_breakpoints): Use address style
11122         to print addresses.
11123         (say_where): Likewise.
11124
11125 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11126
11127         * ada-typeprint.c (print_func_type): Print function name
11128         style to print function name.
11129         * c-typeprint.c (c_print_type_1): Likewise.
11130
11131 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11132
11133         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11134         for execve.
11135
11136 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11137
11138         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11139         type_stack.
11140
11141 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11142
11143         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11144         TYPE_CODE_REF types.
11145
11146 2019-02-08  Jim Wilson  <jimw@sifive.com>
11147
11148         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11149         (riscv_linux_fregset): New.
11150         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11151
11152 2019-02-07  Tom Tromey  <tom@tromey.com>
11153
11154         * thread.c (thread_cancel_execution_command): Update.
11155         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11156         methods.
11157         (struct thread_fsm_ops): Remove.
11158         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11159         (thread_fsm_should_stop, thread_fsm_return_value)
11160         (thread_fsm_set_finished, thread_fsm_finished_p)
11161         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11162         Don't declare.
11163         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11164         * infrun.c (clear_proceed_status_thread)
11165         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11166         (print_stop_event): Update.
11167         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11168         Add constructor.
11169         (step_command_fsm_ops): Remove.
11170         (new_step_command_fsm): Remove.
11171         (step_1): Update.
11172         (step_command_fsm::should_stop): Rename from
11173         step_command_fsm_should_stop.
11174         (step_command_fsm::clean_up): Rename from
11175         step_command_fsm_clean_up.
11176         (step_command_fsm::do_async_reply_reason): Rename from
11177         step_command_fsm_async_reply_reason.
11178         (struct until_next_fsm): Inherit from thread_fsm.  Add
11179         constructor.
11180         (until_next_fsm_ops): Remove.
11181         (new_until_next_fsm): Remove.
11182         (until_next_fsm::should_stop): Rename from
11183         until_next_fsm_should_stop.
11184         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11185         (until_next_fsm::do_async_reply_reason): Rename from
11186         until_next_fsm_async_reply_reason.
11187         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11188         constructor.  Change type of breakpoint.
11189         (finish_command_fsm_ops): Remove.
11190         (new_finish_command_fsm): Remove.
11191         (finish_command_fsm::should_stop): Rename from
11192         finish_command_fsm_should_stop.
11193         (finish_command_fsm::clean_up): Rename from
11194         finish_command_fsm_clean_up.
11195         (finish_command_fsm::return_value): Rename from
11196         finish_command_fsm_return_value.
11197         (finish_command_fsm::do_async_reply_reason): Rename from
11198         finish_command_fsm_async_reply_reason.
11199         (finish_command): Update.
11200         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11201         Add constructor.
11202         (call_thread_fsm_ops): Remove.
11203         (call_thread_fsm::call_thread_fsm): Rename from
11204         new_call_thread_fsm.
11205         (call_thread_fsm::should_stop): Rename from
11206         call_thread_fsm_should_stop.
11207         (call_thread_fsm::should_notify_stop): Rename from
11208         call_thread_fsm_should_notify_stop.
11209         (run_inferior_call, call_function_by_hand_dummy): Update.
11210         * cli/cli-interp.c (should_print_stop_to_console): Update.
11211         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11212         Add constructor.  Change type of location_breakpoint,
11213         caller_breakpoint.
11214         (until_break_fsm_ops): Remove.
11215         (new_until_break_fsm): Remove.
11216         (until_break_fsm::should_stop): Rename from
11217         until_break_fsm_should_stop.
11218         (until_break_fsm::clean_up): Rename from
11219         until_break_fsm_clean_up.
11220         (until_break_fsm::do_async_reply_reason): Rename from
11221         until_break_fsm_async_reply_reason.
11222         (until_break_command): Update.
11223         * thread-fsm.c: Remove.
11224         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11225
11226 2019-02-07  Tom Tromey  <tom@tromey.com>
11227
11228         * yy-remap.h: Add include guard.
11229         * xtensa-tdep.h: Add include guard.
11230         * xcoffread.h: Rename include guard.
11231         * varobj-iter.h: Add include guard.
11232         * tui/tui.h: Rename include guard.
11233         * tui/tui-winsource.h: Rename include guard.
11234         * tui/tui-wingeneral.h: Rename include guard.
11235         * tui/tui-windata.h: Rename include guard.
11236         * tui/tui-win.h: Rename include guard.
11237         * tui/tui-stack.h: Rename include guard.
11238         * tui/tui-source.h: Rename include guard.
11239         * tui/tui-regs.h: Rename include guard.
11240         * tui/tui-out.h: Rename include guard.
11241         * tui/tui-layout.h: Rename include guard.
11242         * tui/tui-io.h: Rename include guard.
11243         * tui/tui-hooks.h: Rename include guard.
11244         * tui/tui-file.h: Rename include guard.
11245         * tui/tui-disasm.h: Rename include guard.
11246         * tui/tui-data.h: Rename include guard.
11247         * tui/tui-command.h: Rename include guard.
11248         * tic6x-tdep.h: Add include guard.
11249         * target/waitstatus.h: Rename include guard.
11250         * target/wait.h: Rename include guard.
11251         * target/target.h: Rename include guard.
11252         * target/resume.h: Rename include guard.
11253         * target-float.h: Rename include guard.
11254         * stabsread.h: Add include guard.
11255         * rs6000-tdep.h: Add include guard.
11256         * riscv-fbsd-tdep.h: Add include guard.
11257         * regformats/regdef.h: Rename include guard.
11258         * record.h: Rename include guard.
11259         * python/python.h: Rename include guard.
11260         * python/python-internal.h: Rename include guard.
11261         * python/py-stopevent.h: Rename include guard.
11262         * python/py-ref.h: Rename include guard.
11263         * python/py-record.h: Rename include guard.
11264         * python/py-record-full.h: Rename include guard.
11265         * python/py-record-btrace.h: Rename include guard.
11266         * python/py-instruction.h: Rename include guard.
11267         * python/py-events.h: Rename include guard.
11268         * python/py-event.h: Rename include guard.
11269         * procfs.h: Add include guard.
11270         * proc-utils.h: Add include guard.
11271         * p-lang.h: Add include guard.
11272         * or1k-tdep.h: Rename include guard.
11273         * observable.h: Rename include guard.
11274         * nto-tdep.h: Rename include guard.
11275         * nat/x86-linux.h: Rename include guard.
11276         * nat/x86-linux-dregs.h: Rename include guard.
11277         * nat/x86-gcc-cpuid.h: Add include guard.
11278         * nat/x86-dregs.h: Rename include guard.
11279         * nat/x86-cpuid.h: Rename include guard.
11280         * nat/ppc-linux.h: Rename include guard.
11281         * nat/mips-linux-watch.h: Rename include guard.
11282         * nat/linux-waitpid.h: Rename include guard.
11283         * nat/linux-ptrace.h: Rename include guard.
11284         * nat/linux-procfs.h: Rename include guard.
11285         * nat/linux-osdata.h: Rename include guard.
11286         * nat/linux-nat.h: Rename include guard.
11287         * nat/linux-namespaces.h: Rename include guard.
11288         * nat/linux-btrace.h: Rename include guard.
11289         * nat/glibc_thread_db.h: Rename include guard.
11290         * nat/gdb_thread_db.h: Rename include guard.
11291         * nat/gdb_ptrace.h: Rename include guard.
11292         * nat/fork-inferior.h: Rename include guard.
11293         * nat/amd64-linux-siginfo.h: Rename include guard.
11294         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11295         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11296         * nat/aarch64-linux.h: Rename include guard.
11297         * nat/aarch64-linux-hw-point.h: Rename include guard.
11298         * mn10300-tdep.h: Add include guard.
11299         * mips-linux-tdep.h: Add include guard.
11300         * mi/mi-parse.h: Rename include guard.
11301         * mi/mi-out.h: Rename include guard.
11302         * mi/mi-main.h: Rename include guard.
11303         * mi/mi-interp.h: Rename include guard.
11304         * mi/mi-getopt.h: Rename include guard.
11305         * mi/mi-console.h: Rename include guard.
11306         * mi/mi-common.h: Rename include guard.
11307         * mi/mi-cmds.h: Rename include guard.
11308         * mi/mi-cmd-break.h: Rename include guard.
11309         * m2-lang.h: Add include guard.
11310         * location.h: Rename include guard.
11311         * linux-record.h: Rename include guard.
11312         * linux-nat.h: Add include guard.
11313         * linux-fork.h: Add include guard.
11314         * i386-darwin-tdep.h: Rename include guard.
11315         * hppa-linux-offsets.h: Add include guard.
11316         * guile/guile.h: Rename include guard.
11317         * guile/guile-internal.h: Rename include guard.
11318         * gnu-nat.h: Rename include guard.
11319         * gdb-stabs.h: Rename include guard.
11320         * frv-tdep.h: Add include guard.
11321         * f-lang.h: Add include guard.
11322         * event-loop.h: Add include guard.
11323         * darwin-nat.h: Rename include guard.
11324         * cp-abi.h: Rename include guard.
11325         * config/sparc/nm-sol2.h: Rename include guard.
11326         * config/nm-nto.h: Rename include guard.
11327         * config/nm-linux.h: Add include guard.
11328         * config/i386/nm-i386gnu.h: Rename include guard.
11329         * config/djgpp/nl_types.h: Rename include guard.
11330         * config/djgpp/langinfo.h: Rename include guard.
11331         * compile/gcc-cp-plugin.h: Add include guard.
11332         * compile/gcc-c-plugin.h: Add include guard.
11333         * compile/compile.h: Rename include guard.
11334         * compile/compile-object-run.h: Rename include guard.
11335         * compile/compile-object-load.h: Rename include guard.
11336         * compile/compile-internal.h: Rename include guard.
11337         * compile/compile-cplus.h: Rename include guard.
11338         * compile/compile-c.h: Rename include guard.
11339         * common/xml-utils.h: Rename include guard.
11340         * common/x86-xstate.h: Rename include guard.
11341         * common/version.h: Rename include guard.
11342         * common/vec.h: Rename include guard.
11343         * common/tdesc.h: Rename include guard.
11344         * common/selftest.h: Rename include guard.
11345         * common/scoped_restore.h: Rename include guard.
11346         * common/scoped_mmap.h: Rename include guard.
11347         * common/scoped_fd.h: Rename include guard.
11348         * common/safe-iterator.h: Rename include guard.
11349         * common/run-time-clock.h: Rename include guard.
11350         * common/refcounted-object.h: Rename include guard.
11351         * common/queue.h: Rename include guard.
11352         * common/ptid.h: Rename include guard.
11353         * common/print-utils.h: Rename include guard.
11354         * common/preprocessor.h: Rename include guard.
11355         * common/pathstuff.h: Rename include guard.
11356         * common/observable.h: Rename include guard.
11357         * common/netstuff.h: Rename include guard.
11358         * common/job-control.h: Rename include guard.
11359         * common/host-defs.h: Rename include guard.
11360         * common/gdb_wait.h: Rename include guard.
11361         * common/gdb_vecs.h: Rename include guard.
11362         * common/gdb_unlinker.h: Rename include guard.
11363         * common/gdb_unique_ptr.h: Rename include guard.
11364         * common/gdb_tilde_expand.h: Rename include guard.
11365         * common/gdb_sys_time.h: Rename include guard.
11366         * common/gdb_string_view.h: Rename include guard.
11367         * common/gdb_splay_tree.h: Rename include guard.
11368         * common/gdb_setjmp.h: Rename include guard.
11369         * common/gdb_ref_ptr.h: Rename include guard.
11370         * common/gdb_optional.h: Rename include guard.
11371         * common/gdb_locale.h: Rename include guard.
11372         * common/gdb_assert.h: Rename include guard.
11373         * common/filtered-iterator.h: Rename include guard.
11374         * common/filestuff.h: Rename include guard.
11375         * common/fileio.h: Rename include guard.
11376         * common/environ.h: Rename include guard.
11377         * common/common-utils.h: Rename include guard.
11378         * common/common-types.h: Rename include guard.
11379         * common/common-regcache.h: Rename include guard.
11380         * common/common-inferior.h: Rename include guard.
11381         * common/common-gdbthread.h: Rename include guard.
11382         * common/common-exceptions.h: Rename include guard.
11383         * common/common-defs.h: Rename include guard.
11384         * common/common-debug.h: Rename include guard.
11385         * common/cleanups.h: Rename include guard.
11386         * common/buffer.h: Rename include guard.
11387         * common/btrace-common.h: Rename include guard.
11388         * common/break-common.h: Rename include guard.
11389         * cli/cli-utils.h: Rename include guard.
11390         * cli/cli-style.h: Rename include guard.
11391         * cli/cli-setshow.h: Rename include guard.
11392         * cli/cli-script.h: Rename include guard.
11393         * cli/cli-interp.h: Rename include guard.
11394         * cli/cli-decode.h: Rename include guard.
11395         * cli/cli-cmds.h: Rename include guard.
11396         * charset-list.h: Add include guard.
11397         * buildsym-legacy.h: Rename include guard.
11398         * bfin-tdep.h: Add include guard.
11399         * ax.h: Rename include guard.
11400         * arm-linux-tdep.h: Add include guard.
11401         * arm-fbsd-tdep.h: Add include guard.
11402         * arch/xtensa.h: Rename include guard.
11403         * arch/tic6x.h: Add include guard.
11404         * arch/i386.h: Add include guard.
11405         * arch/arm.h: Rename include guard.
11406         * arch/arm-linux.h: Rename include guard.
11407         * arch/arm-get-next-pcs.h: Rename include guard.
11408         * arch/amd64.h: Add include guard.
11409         * arch/aarch64-insn.h: Rename include guard.
11410         * arch-utils.h: Rename include guard.
11411         * annotate.h: Add include guard.
11412         * amd64-darwin-tdep.h: Rename include guard.
11413         * aarch64-linux-tdep.h: Add include guard.
11414         * aarch64-fbsd-tdep.h: Add include guard.
11415         * aarch32-linux-nat.h: Add include guard.
11416
11417 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11418
11419         * macrotab.c (macro_define_internal): New function that
11420         factorizes macro_define_object_internal and macro_define_function
11421         code.
11422         (macro_define_object_internal): Use macro_define_internal.
11423         (macro_define_function): Likewise.
11424
11425 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11426
11427         * macrocmd.c (extract_identifier): Return
11428         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11429         callers.
11430
11431 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11432
11433         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11434
11435 2019-02-05  Tom Tromey  <tom@tromey.com>
11436
11437         * target.c (target_stack::unpush): Move assertion earlier.
11438
11439 2019-01-30  Tom Tromey  <tom@tromey.com>
11440
11441         PR python/23615:
11442         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11443         (gdbpy_parse_and_eval): Likewise.
11444         * python/python-internal.h (gdbpy_allow_threads): New class.
11445
11446 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11447
11448         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11449         (aarch64_fbsd_fpregmap): Move earlier.
11450         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11451         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11452         instead of individual calls to trad_frame_set_reg_addr.
11453         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11454         earlier.
11455         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11456         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11457         instead of individual calls to trad_frame_set_reg_addr.
11458
11459 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11460
11461         * CONTRIBUTE: Replace contribution list with wiki link.
11462
11463 2019-01-25  Tom Tromey  <tom@tromey.com>
11464
11465         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11466
11467 2019-01-25  Tom Tromey  <tom@tromey.com>
11468
11469         * xtensa-linux-nat.c: Fix common/ includes.
11470         * xml-support.h: Fix common/ includes.
11471         * xml-support.c: Fix common/ includes.
11472         * x86-linux-nat.c: Fix common/ includes.
11473         * windows-nat.c: Fix common/ includes.
11474         * varobj.h: Fix common/ includes.
11475         * varobj.c: Fix common/ includes.
11476         * value.c: Fix common/ includes.
11477         * valops.c: Fix common/ includes.
11478         * utils.c: Fix common/ includes.
11479         * unittests/xml-utils-selftests.c: Fix common/ includes.
11480         * unittests/utils-selftests.c: Fix common/ includes.
11481         * unittests/unpack-selftests.c: Fix common/ includes.
11482         * unittests/tracepoint-selftests.c: Fix common/ includes.
11483         * unittests/style-selftests.c: Fix common/ includes.
11484         * unittests/string_view-selftests.c: Fix common/ includes.
11485         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11486         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11487         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11488         * unittests/rsp-low-selftests.c: Fix common/ includes.
11489         * unittests/parse-connection-spec-selftests.c: Fix common/
11490         includes.
11491         * unittests/optional-selftests.c: Fix common/ includes.
11492         * unittests/offset-type-selftests.c: Fix common/ includes.
11493         * unittests/observable-selftests.c: Fix common/ includes.
11494         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11495         * unittests/memrange-selftests.c: Fix common/ includes.
11496         * unittests/memory-map-selftests.c: Fix common/ includes.
11497         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11498         * unittests/function-view-selftests.c: Fix common/ includes.
11499         * unittests/environ-selftests.c: Fix common/ includes.
11500         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11501         * unittests/common-utils-selftests.c: Fix common/ includes.
11502         * unittests/cli-utils-selftests.c: Fix common/ includes.
11503         * unittests/array-view-selftests.c: Fix common/ includes.
11504         * ui-file.c: Fix common/ includes.
11505         * tui/tui-io.c: Fix common/ includes.
11506         * tracepoint.h: Fix common/ includes.
11507         * tracepoint.c: Fix common/ includes.
11508         * tracefile-tfile.c: Fix common/ includes.
11509         * top.h: Fix common/ includes.
11510         * top.c: Fix common/ includes.
11511         * thread.c: Fix common/ includes.
11512         * target/waitstatus.h: Fix common/ includes.
11513         * target/waitstatus.c: Fix common/ includes.
11514         * target.h: Fix common/ includes.
11515         * target.c: Fix common/ includes.
11516         * target-memory.c: Fix common/ includes.
11517         * target-descriptions.c: Fix common/ includes.
11518         * symtab.h: Fix common/ includes.
11519         * symfile.c: Fix common/ includes.
11520         * stap-probe.c: Fix common/ includes.
11521         * spu-linux-nat.c: Fix common/ includes.
11522         * sparc-nat.c: Fix common/ includes.
11523         * source.c: Fix common/ includes.
11524         * solib.c: Fix common/ includes.
11525         * solib-target.c: Fix common/ includes.
11526         * ser-unix.c: Fix common/ includes.
11527         * ser-tcp.c: Fix common/ includes.
11528         * ser-pipe.c: Fix common/ includes.
11529         * ser-base.c: Fix common/ includes.
11530         * selftest-arch.c: Fix common/ includes.
11531         * s12z-tdep.c: Fix common/ includes.
11532         * rust-exp.y: Fix common/ includes.
11533         * rs6000-aix-tdep.c: Fix common/ includes.
11534         * riscv-tdep.c: Fix common/ includes.
11535         * remote.c: Fix common/ includes.
11536         * remote-notif.h: Fix common/ includes.
11537         * remote-fileio.h: Fix common/ includes.
11538         * remote-fileio.c: Fix common/ includes.
11539         * regcache.h: Fix common/ includes.
11540         * regcache.c: Fix common/ includes.
11541         * record-btrace.c: Fix common/ includes.
11542         * python/python.c: Fix common/ includes.
11543         * python/py-type.c: Fix common/ includes.
11544         * python/py-inferior.c: Fix common/ includes.
11545         * progspace.h: Fix common/ includes.
11546         * producer.c: Fix common/ includes.
11547         * procfs.c: Fix common/ includes.
11548         * proc-api.c: Fix common/ includes.
11549         * printcmd.c: Fix common/ includes.
11550         * ppc-linux-nat.c: Fix common/ includes.
11551         * parser-defs.h: Fix common/ includes.
11552         * osdata.c: Fix common/ includes.
11553         * obsd-nat.c: Fix common/ includes.
11554         * nat/x86-linux.c: Fix common/ includes.
11555         * nat/x86-linux-dregs.c: Fix common/ includes.
11556         * nat/x86-dregs.h: Fix common/ includes.
11557         * nat/x86-dregs.c: Fix common/ includes.
11558         * nat/ppc-linux.c: Fix common/ includes.
11559         * nat/mips-linux-watch.h: Fix common/ includes.
11560         * nat/mips-linux-watch.c: Fix common/ includes.
11561         * nat/linux-waitpid.c: Fix common/ includes.
11562         * nat/linux-ptrace.h: Fix common/ includes.
11563         * nat/linux-ptrace.c: Fix common/ includes.
11564         * nat/linux-procfs.c: Fix common/ includes.
11565         * nat/linux-personality.c: Fix common/ includes.
11566         * nat/linux-osdata.c: Fix common/ includes.
11567         * nat/linux-namespaces.c: Fix common/ includes.
11568         * nat/linux-btrace.h: Fix common/ includes.
11569         * nat/linux-btrace.c: Fix common/ includes.
11570         * nat/fork-inferior.c: Fix common/ includes.
11571         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11572         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11573         * nat/aarch64-linux.c: Fix common/ includes.
11574         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11575         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11576         * namespace.h: Fix common/ includes.
11577         * mips-linux-tdep.c: Fix common/ includes.
11578         * minsyms.c: Fix common/ includes.
11579         * mi/mi-parse.h: Fix common/ includes.
11580         * mi/mi-main.c: Fix common/ includes.
11581         * mi/mi-cmd-env.c: Fix common/ includes.
11582         * memrange.h: Fix common/ includes.
11583         * memattr.c: Fix common/ includes.
11584         * maint.h: Fix common/ includes.
11585         * maint.c: Fix common/ includes.
11586         * main.c: Fix common/ includes.
11587         * machoread.c: Fix common/ includes.
11588         * location.c: Fix common/ includes.
11589         * linux-thread-db.c: Fix common/ includes.
11590         * linux-nat.c: Fix common/ includes.
11591         * linux-fork.c: Fix common/ includes.
11592         * inline-frame.c: Fix common/ includes.
11593         * infrun.c: Fix common/ includes.
11594         * inflow.c: Fix common/ includes.
11595         * inferior.h: Fix common/ includes.
11596         * inferior.c: Fix common/ includes.
11597         * infcmd.c: Fix common/ includes.
11598         * inf-ptrace.c: Fix common/ includes.
11599         * inf-child.c: Fix common/ includes.
11600         * ia64-linux-nat.c: Fix common/ includes.
11601         * i387-tdep.c: Fix common/ includes.
11602         * i386-tdep.c: Fix common/ includes.
11603         * i386-linux-tdep.c: Fix common/ includes.
11604         * i386-linux-nat.c: Fix common/ includes.
11605         * i386-go32-tdep.c: Fix common/ includes.
11606         * i386-fbsd-tdep.c: Fix common/ includes.
11607         * i386-fbsd-nat.c: Fix common/ includes.
11608         * guile/scm-type.c: Fix common/ includes.
11609         * guile/guile.c: Fix common/ includes.
11610         * go32-nat.c: Fix common/ includes.
11611         * gnu-nat.c: Fix common/ includes.
11612         * gdbthread.h: Fix common/ includes.
11613         * gdbarch-selftests.c: Fix common/ includes.
11614         * gdb_usleep.c: Fix common/ includes.
11615         * gdb_select.h: Fix common/ includes.
11616         * gdb_bfd.c: Fix common/ includes.
11617         * gcore.c: Fix common/ includes.
11618         * fork-child.c: Fix common/ includes.
11619         * findvar.c: Fix common/ includes.
11620         * fbsd-nat.c: Fix common/ includes.
11621         * event-top.c: Fix common/ includes.
11622         * event-loop.c: Fix common/ includes.
11623         * dwarf2read.c: Fix common/ includes.
11624         * dwarf2loc.c: Fix common/ includes.
11625         * dwarf2-frame.c: Fix common/ includes.
11626         * dwarf-index-cache.c: Fix common/ includes.
11627         * dtrace-probe.c: Fix common/ includes.
11628         * disasm-selftests.c: Fix common/ includes.
11629         * defs.h: Fix common/ includes.
11630         * csky-tdep.c: Fix common/ includes.
11631         * cp-valprint.c: Fix common/ includes.
11632         * cp-support.h: Fix common/ includes.
11633         * cp-support.c: Fix common/ includes.
11634         * corelow.c: Fix common/ includes.
11635         * completer.h: Fix common/ includes.
11636         * completer.c: Fix common/ includes.
11637         * compile/compile.c: Fix common/ includes.
11638         * compile/compile-loc2c.c: Fix common/ includes.
11639         * compile/compile-cplus-types.c: Fix common/ includes.
11640         * compile/compile-cplus-symbols.c: Fix common/ includes.
11641         * command.h: Fix common/ includes.
11642         * cli/cli-dump.c: Fix common/ includes.
11643         * cli/cli-cmds.c: Fix common/ includes.
11644         * charset.c: Fix common/ includes.
11645         * build-id.c: Fix common/ includes.
11646         * btrace.h: Fix common/ includes.
11647         * btrace.c: Fix common/ includes.
11648         * breakpoint.h: Fix common/ includes.
11649         * breakpoint.c: Fix common/ includes.
11650         * ax.h:
11651         (enum agent_op): Fix common/ includes.
11652         * ax-general.c (struct aop_map): Fix common/ includes.
11653         * ax-gdb.c: Fix common/ includes.
11654         * auxv.c: Fix common/ includes.
11655         * auto-load.c: Fix common/ includes.
11656         * arm-tdep.c: Fix common/ includes.
11657         * arch/riscv.c: Fix common/ includes.
11658         * arch/ppc-linux-common.c: Fix common/ includes.
11659         * arch/i386.c: Fix common/ includes.
11660         * arch/arm.c: Fix common/ includes.
11661         * arch/arm-linux.c: Fix common/ includes.
11662         * arch/arm-get-next-pcs.c: Fix common/ includes.
11663         * arch/amd64.c: Fix common/ includes.
11664         * arch/aarch64.c: Fix common/ includes.
11665         * arch/aarch64-insn.c: Fix common/ includes.
11666         * arch-utils.c: Fix common/ includes.
11667         * amd64-windows-tdep.c: Fix common/ includes.
11668         * amd64-tdep.c: Fix common/ includes.
11669         * amd64-sol2-tdep.c: Fix common/ includes.
11670         * amd64-obsd-tdep.c: Fix common/ includes.
11671         * amd64-nbsd-tdep.c: Fix common/ includes.
11672         * amd64-linux-tdep.c: Fix common/ includes.
11673         * amd64-linux-nat.c: Fix common/ includes.
11674         * amd64-fbsd-tdep.c: Fix common/ includes.
11675         * amd64-fbsd-nat.c: Fix common/ includes.
11676         * amd64-dicos-tdep.c: Fix common/ includes.
11677         * amd64-darwin-tdep.c: Fix common/ includes.
11678         * agent.c: Fix common/ includes.
11679         * ada-lang.h: Fix common/ includes.
11680         * ada-lang.c: Fix common/ includes.
11681         * aarch64-tdep.c: Fix common/ includes.
11682
11683 2019-01-25  Tom Tromey  <tom@tromey.com>
11684
11685         * common/create-version.sh: Use common/version.h.
11686
11687 2019-01-24  Pedro Alves  <palves@redhat.com>
11688
11689         * infrun.c (signal_stop, signal_print, signal_program)
11690         (signal_catch, signal_pass): Now arrays instead of pointers.
11691         (update_signals_program_target, do_target_resume)
11692         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11693         * linux-nat.c (linux_nat_target::pass_signals)
11694         (linux_nat_target::create_inferior, linux_nat_target::attach):
11695         Adjust.
11696         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11697         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11698         * procfs.c (procfs_target::pass_signals): Adjust.
11699         * record-full.c (record_full_target::resume): Adjust.
11700         * remote.c (remote_target::pass_signals)
11701         (remote_target::program_signals): Adjust.
11702         * target-debug.h (target_debug_print_signals): Now takes a
11703         gdb::array_view as parameter.  Adjust.
11704         * target.h (target_ops) <pass_signals, program_signals>: Replace
11705         pointer and length parameters with gdb::array_view.
11706         (target_pass_signals, target_program_signals): Likewise.
11707         * target-delegates.c: Regenerate.
11708
11709 2019-01-24  Pedro Alves  <palves@redhat.com>
11710
11711         * common/forward-scope-exit.h
11712         (forward_scope_exit::forward_scope_exit): Pass arguments to
11713         m_bind_function directly, instead of creating a std::bind and
11714         copying that.
11715
11716 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11717
11718         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11719         for static members.
11720         (pass_in_v_vfp_candidate): Likewise.
11721
11722 2019-01-23  Tom Tromey  <tom@tromey.com>
11723             Pedro Alves  <palves@redhat.com>
11724
11725         * regcache.c (class regcache_invalidator): Remove.
11726         (regcache::raw_write): Use make_scope_exit.
11727
11728 2019-01-23  Tom Tromey  <tom@tromey.com>
11729
11730         * ui-out.h (class ui_out_emit_type): Update comment.
11731
11732 2019-01-23  Tom Tromey  <tom@tromey.com>
11733
11734         * infrun.c (fetch_inferior_event): Update comment.
11735
11736 2019-01-23  Tom Tromey  <tom@tromey.com>
11737             Pedro Alves  <palves@redhat.com>
11738
11739         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11740         parameter.
11741         (fetch_inferior_event): Use SCOPE_EXIT.
11742
11743
11744 2019-01-23  Tom Tromey  <tom@tromey.com>
11745             Pedro Alves  <palves@redhat.com>
11746
11747         * infrun.c (disable_thread_events): Delete.
11748         (stop_all_threads): Use SCOPE_EXIT.
11749
11750 2019-01-23  Tom Tromey  <tom@tromey.com>
11751             Pedro Alves  <palves@redhat.com>
11752
11753         * symfile.c: Include forward-scope-exit.h.
11754         (clear_symtab_users_cleanup): Replace forward declaration with
11755         a FORWARD_SCOPE_EXIT.
11756         (syms_from_objfile_1): Use the forward_scope_exit and
11757         gdb::optional instead of cleanup_function.
11758         (reread_symbols): Use the forward_scope_exit instead of
11759         cleanup_function.
11760         (clear_symtab_users_cleanup): Remove function.
11761
11762 2019-01-23  Tom Tromey  <tom@tromey.com>
11763             Pedro Alves  <palves@redhat.com>
11764
11765         * linux-nat.c: Include scope-exit.h.
11766         (cleanup_target_stop): Remove.
11767         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11768         SCOPE_EXIT.
11769
11770 2019-01-23  Tom Tromey  <tom@tromey.com>
11771             Pedro Alves  <palves@redhat.com>
11772
11773         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11774         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11775
11776 2019-01-23  Tom Tromey  <tom@tromey.com>
11777             Andrew Burgess  <andrew.burgess@embecosm.com>
11778             Pedro Alves  <palves@redhat.com>
11779
11780         * infrun.c (fetch_inferior_event): Use scope_exit.
11781         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11782         * top.c (execute_command): Use scope_exit.
11783         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11784         * utils.c (do_bpstat_clear_actions_cleanup)
11785         (make_bpstat_clear_actions_cleanup): Remove.
11786
11787 2019-01-23  Tom Tromey  <tom@tromey.com>
11788             Pedro Alves  <palves@redhat.com>
11789
11790         * infrun.c: Include "common/scope-exit.h"
11791         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11792         (wait_for_inferior): Use SCOPE_EXIT.
11793         (fetch_inferior_event): Use scope_exit.
11794
11795 2019-01-23  Tom Tromey  <tom@tromey.com>
11796             Pedro Alves  <palves@redhat.com>
11797
11798         * breakpoint.c (create_breakpoint): Remove cleanup.
11799
11800 2019-01-23  Tom Tromey  <tom@tromey.com>
11801             Andrew Burgess  <andrew.burgess@embecosm.com>
11802             Pedro Alves  <palves@redhat.com>
11803
11804 2019-01-23  Pedro Alves  <palves@redhat.com>
11805
11806         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11807
11808 2019-01-23  Pedro Alves  <palves@redhat.com>
11809             Andrew Burgess  <andrew.burgess@embecosm.com>
11810
11811         * gdbthread.h: Include "common/forward-scope-exit.h".
11812         (scoped_finish_thread_state): Redefine custom class in terms of
11813         forward_scope_exit.
11814
11815 2019-01-23  Pedro Alves  <palves@redhat.com>
11816             Andrew Burgess  <andrew.burgess@embecosm.com>
11817
11818         * common/forward-scope-exit.h: New file.
11819
11820 2019-01-23  Pedro Alves  <palves@redhat.com>
11821             Andrew Burgess  <andrew.burgess@embecosm.com>
11822             Tom Tromey  <tom@tromey.com>
11823
11824         * common/scope-exit.h: New file.
11825
11826 2019-01-23  Pedro Alves  <palves@redhat.com>
11827
11828         * common/preprocessor.h (ESC): Rename to ...
11829         (ESC_PARENS): ... this.
11830         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11831         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11832
11833 2019-01-23  Tom Tromey  <tom@tromey.com>
11834
11835         * language.h (class scoped_switch_to_sym_language_if_auto):
11836         Initialize m_lang in both cases.
11837
11838 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11839
11840         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11841         with XCNEW.
11842
11843 2019-01-22  Tom Tromey  <tom@tromey.com>
11844
11845         * corelow.c: Do not include sys/file.h.
11846
11847 2019-01-22  Tom Tromey  <tom@tromey.com>
11848
11849         * tui/tui-wingeneral.h: Include gdb_curses.h.
11850
11851 2019-01-22  Tom Tromey  <tom@tromey.com>
11852
11853         * source-cache.h (class source_cache) <get_source_lines,
11854         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11855
11856 2019-01-22  Tom Tromey  <tom@tromey.com>
11857
11858         * remote-fileio.h (struct remote_target): Declare.
11859
11860 2019-01-22  Tom Tromey  <tom@tromey.com>
11861
11862         * python/py-arch.c: Do not include py-ref.h.
11863         * python/py-bpevent.c: Do not include py-ref.h.
11864         * python/py-cmd.c: Do not include py-ref.h.
11865         * python/py-continueevent.c: Do not include py-ref.h.
11866         * python/py-event.h: Do not include py-ref.h.
11867         * python/py-evtregistry.c: Do not include py-ref.h.
11868         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11869         * python/py-frame.c: Do not include py-ref.h.
11870         * python/py-framefilter.c: Do not include py-ref.h.
11871         * python/py-function.c: Do not include py-ref.h.
11872         * python/py-infevents.c: Do not include py-ref.h.
11873         * python/py-linetable.c: Do not include py-ref.h.
11874         * python/py-objfile.c: Do not include py-ref.h.
11875         * python/py-param.c: Do not include py-ref.h.
11876         * python/py-prettyprint.c: Do not include py-ref.h.
11877         * python/py-progspace.c: Do not include py-ref.h.
11878         * python/py-symbol.c: Do not include py-ref.h.
11879         * python/py-symtab.c: Do not include py-ref.h.
11880         * python/py-type.c: Do not include py-ref.h.
11881         * python/py-unwind.c: Do not include py-ref.h.
11882         * python/py-utils.c: Do not include py-ref.h.
11883         * python/py-value.c: Do not include py-ref.h.
11884         * python/py-varobj.c: Do not include py-ref.h.
11885         * python/py-xmethods.c: Do not include py-ref.h.
11886         * python/python.c: Do not include py-ref.h.
11887         * varobj.c: Do not include py-ref.h.
11888
11889 2019-01-22  Tom Tromey  <tom@tromey.com>
11890
11891         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11892         keyword for bcache.
11893
11894 2019-01-22  Tom Tromey  <tom@tromey.com>
11895
11896         * compile/compile-cplus-types.c: Remove a comment by #include.
11897
11898 2019-01-22  Tom Tromey  <tom@tromey.com>
11899
11900         * compile/gcc-c-plugin.h: Include compile-internal.h.
11901
11902 2019-01-22  Tom Tromey  <tom@tromey.com>
11903
11904         * stabsread.c (EXTERN): Do not define.
11905         (symnum, next_symbol_text_func, processing_gcc_compilation)
11906         (within_function, global_sym_chain, global_stabs)
11907         (previous_stab_code, this_object_header_files)
11908         (n_this_object_header_files)
11909         (n_allocated_this_object_header_files): Define.
11910         * stabsread.h (EXTERN): Never define.  Use "extern".
11911
11912 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11913
11914         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11915         history_value.
11916
11917 2019-01-21  Tom Tromey  <tom@tromey.com>
11918
11919         * ui-out.c: Fix includes.
11920         * tui/tui-source.c: Fix includes.
11921         * target.c: Fix includes.
11922         * remote.c: Fix includes.
11923         * regcache.c: Fix includes.
11924         * python/py-block.c: Fix includes.
11925         * printcmd.c: Fix includes.
11926         * or1k-tdep.c: Fix includes.
11927         * mi/mi-main.c: Fix includes.
11928         * m32r-tdep.c: Fix includes.
11929         * csky-tdep.c: Fix includes.
11930         * compile/compile-cplus-types.c: Fix includes.
11931         * cli/cli-interp.c: Fix includes.
11932
11933 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11934
11935         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11936         for padding.
11937
11938 2019-01-16  Tom Tromey  <tom@tromey.com>
11939
11940         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11941         earlier.
11942         (struct objfile) <msymbols_range>: Move from top level.
11943         <msymbols>: New method.
11944         (class objfile_msymbols): Remove.
11945         * symtab.c (default_collect_symbol_completion_matches_break_on):
11946         Update.
11947         * symmisc.c (dump_msymbols): Update.
11948         * stabsread.c (scan_file_globals): Update.
11949         * objc-lang.c (info_selectors_command, info_classes_command)
11950         (find_methods): Update.
11951         * minsyms.c (find_solib_trampoline_target): Update.
11952         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11953         * coffread.c (coff_symfile_read): Update.
11954         * ada-lang.c (ada_lookup_simple_minsym)
11955         (ada_collect_symbol_completion_matches): Update.
11956
11957 2019-01-16  Tom Tromey  <tom@tromey.com>
11958
11959         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11960         type.  Remove no-argument constructor.
11961         <iterator::operator++>: Simplify.
11962         <begin>: Update.
11963         <end>: Use minimal_symbol_count.
11964
11965 2019-01-16  Tom Tromey  <tom@tromey.com>
11966
11967         * objfiles.h (struct objfile) <psymtabs>: New method.
11968         (class objfile_psymtabs): Remove.
11969         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11970         typedef.
11971         <range>: New method.
11972         (require_partial_symbols): Change return type.
11973         * psymtab.c (require_partial_symbols)
11974         (psym_expand_symtabs_matching): Update.
11975         * mdebugread.c (parse_partial_symbols): Update.
11976         * dbxread.c (dbx_end_psymtab): Update.
11977
11978 2019-01-15  Tom Tromey  <tom@tromey.com>
11979
11980         * symtab.c (lookup_objfile_from_block)
11981         (lookup_symbol_in_objfile_symtabs)
11982         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11983         (find_line_symtab, info_sources_command)
11984         (default_collect_symbol_completion_matches_break_on)
11985         (make_source_files_completion_list): Update.
11986         * symmisc.c (print_objfile_statistics, dump_objfile)
11987         (maintenance_print_symbols, maintenance_info_symtabs)
11988         (maintenance_check_symtabs, maintenance_info_line_tables):
11989         Update.
11990         * source.c (select_source_symtab)
11991         (forget_cached_source_info_for_objfile): Update.
11992         * objfiles.h (class objfile_compunits): Remove.
11993         (struct objfile) <compunits_range>: New typedef.
11994         (compunits): New method.
11995         * objfiles.c (objfile_relocate1): Update.
11996         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11997         * maint.c (count_symtabs_and_blocks): Update.
11998         * linespec.c (iterate_over_all_matching_symtabs): Update.
11999         * cp-support.c (add_symbol_overload_list_qualified): Update.
12000         * coffread.c (coff_symtab_read): Update.
12001         * ada-lang.c (add_nonlocal_symbols)
12002         (ada_collect_symbol_completion_matches)
12003         (ada_add_global_exceptions): Update.
12004
12005 2019-01-15  Tom Tromey  <tom@tromey.com>
12006
12007         * progspace.h (program_space) <objfiles_safe_range>: New
12008         typedef.
12009         <objfiles_safe>: New method.
12010         * objfiles.h (class all_objfiles_safe): Remove.
12011         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12012         * jit.c (jit_inferior_exit_hook): Update.
12013
12014 2019-01-17  Tom Tromey  <tom@tromey.com>
12015
12016         * progspace.h (program_space) <objfiles_range>: New typedef.
12017         <objfiles>: New method.
12018         <objfiles_head>: Rename from objfiles.
12019         (object_files): Update.
12020         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12021         * guile/scm-pretty-print.c
12022         (ppscm_find_pretty_printer_from_objfiles): Update.
12023         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12024         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12025         Update.
12026         * python/py-progspace.c (pspy_get_objfiles): Update.
12027         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12028         Update.
12029         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12030         (objfpy_lookup_objfile_by_build_id): Update.
12031         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12032         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12033         Update.
12034         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12035         (expand_symtab_containing_pc, lookup_objfile_from_block)
12036         (lookup_static_symbol, basic_lookup_transparent_type)
12037         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12038         (find_line_symtab, info_sources_command)
12039         (default_collect_symbol_completion_matches_break_on)
12040         (make_source_files_completion_list, find_main_name): Update.
12041         * symmisc.c (print_symbol_bcache_statistics)
12042         (print_objfile_statistics, maintenance_print_symbols)
12043         (maintenance_print_msymbols, maintenance_print_objfiles)
12044         (maintenance_info_symtabs, maintenance_check_symtabs)
12045         (maintenance_expand_symtabs, maintenance_info_line_tables):
12046         Update.
12047         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12048         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12049         (map_overlay_command, unmap_overlay_command)
12050         (simple_overlay_update, expand_symtabs_matching)
12051         (map_symbol_filenames): Update.
12052         * symfile-debug.c (set_debug_symfile): Update.
12053         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12054         Update.
12055         * source.c (select_source_symtab, forget_cached_source_info):
12056         Update.
12057         * solib.c (solib_read_symbols): Update.
12058         * solib-spu.c (append_ocl_sos): Update.
12059         * psymtab.c (maintenance_print_psymbols)
12060         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12061         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12062         * printcmd.c (info_symbol_command): Update.
12063         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12064         Update.
12065         * objfiles.h (class all_objfiles): Remove.
12066         * objfiles.c (have_partial_symbols, have_full_symbols)
12067         (have_minimal_symbols, qsort_cmp, update_section_map)
12068         (shared_objfile_contains_address_p)
12069         (default_iterate_over_objfiles_in_search_order): Update.
12070         * objc-lang.c (info_selectors_command, info_classes_command)
12071         (find_methods): Update.
12072         * minsyms.c (find_solib_trampoline_target): Update.
12073         * maint.c (maintenance_info_sections)
12074         (maintenance_translate_address, count_symtabs_and_blocks):
12075         Update.
12076         * main.c (captured_main_1): Update.
12077         * linux-thread-db.c (try_thread_db_load_from_pdir)
12078         (has_libpthread): Update.
12079         * linespec.c (iterate_over_all_matching_symtabs)
12080         (search_minsyms_for_name): Update.
12081         * jit.c (jit_find_objf_with_entry_addr): Update.
12082         * hppa-tdep.c (find_unwind_entry)
12083         (hppa_lookup_stub_minimal_symbol): Update.
12084         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12085         Update.
12086         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12087         (elf_gnu_ifunc_resolve_by_got): Update.
12088         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12089         * dwarf-index-write.c (save_gdb_index_command): Update.
12090         * cp-support.c (add_symbol_overload_list_qualified): Update.
12091         * breakpoint.c (create_overlay_event_breakpoint)
12092         (create_longjmp_master_breakpoint)
12093         (create_std_terminate_master_breakpoint)
12094         (create_exception_master_breakpoint): Update.
12095         * blockframe.c (find_pc_partial_function): Update.
12096         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12097         (ada_collect_symbol_completion_matches)
12098         (ada_add_global_exceptions): Update.
12099
12100 2019-01-17  Tom Tromey  <tom@tromey.com>
12101
12102         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12103         declare VEC.
12104         (solib_target_parse_libraries): Change return type.
12105         (library_list_start_segment, library_list_start_section)
12106         (library_list_end_library, library_list_start_library); Update.
12107         (solib_target_free_library_list): Remove.
12108         (solib_target_parse_libraries): Remove cleanup.  Change return
12109         type.
12110         (solib_target_current_sos): Update.
12111
12112 2019-01-17  Tom Tromey  <tromey@bapiya>
12113
12114         * valprint.c: Replace "the the" with "the".
12115         * symtab.c: Replace "the the" with "the".
12116         * solib.c: Replace "the the" with "the".
12117         * solib-dsbt.c: Replace "the the" with "the".
12118         * linespec.c: Replace "the the" with "the".
12119         * dwarf2loc.h: Replace "the the" with "the".
12120         * amd64-windows-tdep.c: Replace "the the" with "the".
12121         * aarch64-tdep.c: Replace "the the" with "the".
12122
12123 2019-01-16  Keith Seitz  <keiths@redhat.com>
12124
12125         PR gdb/23773
12126         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12127         <builder>: Rename to ..
12128         <m_builder>: ... this and make private.
12129         (dwarf2_cu::get_builder): New method.  Change all users of
12130         `builder' to use this method.
12131         (dwarf2_start_symtab): Move to ...
12132         (dwarf2_cu::start_symtab): ... here.  Update all callers
12133         (setup_type_unit_groups): Move to ...
12134         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12135         callers.
12136         (dwarf2_cu::reset_builder): New method.
12137         (process_full_compunit, process_full_type_unit): Use
12138         dwarf2_cu::reset_builder.
12139         (follow_die_offset): Record the ancestor CU if it is different
12140         from the followed DIE's CU.
12141         (follow_die_sig_1): Likewise.
12142
12143 2019-01-15  Tom Tromey  <tom@tromey.com>
12144
12145         * remote.c (class remote_state) <buf>: Now a char_vector.
12146         <buf_size>: Remove.
12147         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12148         parameter.
12149         (remote_target::getpkt_or_notif_sane_1)
12150         (remote_target::getpkt_sane)
12151         (remote_target::getpkt_or_notif_sane): Likewise.
12152         (class remote_target) <putpkt>: New overload.
12153         (remote_target::read_frame): Change type of "buf_p".  Remove
12154         sizeof_p parameter.
12155         (packet_ok): New overload.
12156         (packet_check_result): New overload.
12157         Update all uses.
12158
12159 2019-01-14  Tom Tromey  <tom@tromey.com>
12160
12161         * remote-notif.c (handle_notification, remote_notif_ack)
12162         (remote_notif_parse): Make "buf" const.
12163         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12164         const.
12165         (remote_notif_parse, remote_notif_ack, handle_notification):
12166         Likewise.
12167         * remote.c (remote_notif_stop_parse): Make "buf" const.
12168         (remote_target::remote_parse_stop_reply): Make "buf" const.
12169         (remote_notif_stop_ack): Make "buf" const.
12170
12171 2019-01-14  Tom Tromey  <tom@tromey.com>
12172
12173         * remote.c (remote_console_output): Make parameter const.
12174
12175 2019-01-14  Tom Tromey  <tom@tromey.com>
12176
12177         * target-debug.h (target_debug_print_signals): Constify.
12178         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12179         * procfs.c (procfs_target::pass_signals): Update.
12180         * linux-nat.c (linux_nat_target::pass_signals): Update.
12181         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12182         * target-delegates.c: Rebuild.
12183         * remote.c (remote_target::program_signals): Update.
12184         (remote_target::pass_signals): Update.
12185         * target.c (target_pass_signals): Constify argument.
12186         (target_program_signals): Likewise.
12187         * target.h (struct target_ops) <pass_signals, program_signals>:
12188         Constify argument.
12189         (target_pass_signals, target_program_signals): Constify argument.
12190
12191 2019-01-14  Tom Tromey  <tom@tromey.com>
12192
12193         PR tui/28819:
12194         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12195
12196 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12197
12198         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12199         field.
12200         * rs6000-tdep.c: Include reggroups.h.
12201         (IS_V_ALIAS_PSEUDOREG): Define.
12202         (rs6000_register_name): Return names for the "vX" aliases.
12203         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12204         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12205         aliases.  Call default_register_reggroup_p for all other
12206         pseudo-registers.
12207         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12208         New functions.
12209         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12210         Handle "vX" aliases.
12211         (v_alias_pseudo_register_collect): New function.
12212         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12213         (rs6000_gdbarch_init): Initialize "vX" aliases as
12214         pseudo-registers.  Restore registration of
12215         rs6000_pseudo_register_reggroup_p with
12216         set_tdesc_pseudo_register_reggroup_p.
12217
12218 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12219
12220         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12221         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12222         set_gdbarch_num_pseudo_regs.
12223
12224 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12225
12226         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12227         Remove arg prefixname, add do_set and do_show.
12228         Add member functions set_list and show_list.
12229         * cli/cli-style.c (class cli_style_option): Update accordingly.
12230         (style_set_list): Move to file scope.
12231         (style_show_list): Likewise.
12232         (set_style): Call help_list.
12233         (show_style): Call cmd_show_list.
12234         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12235         Update to use the new macro.
12236
12237 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12238
12239         * ada-lang.c (_initialize_ada_language): Expand the help text
12240         for the "catch exception" command.
12241
12242 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12243
12244         * symtab.c (matching_obj_sections): Initialize obj,
12245         declare it closer to its usage.
12246
12247 2019-01-10  Tom Tromey  <tom@tromey.com>
12248
12249         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12250         (basic_inf_threads_range): Remove.
12251         (inf_threads_range, inf_non_exited_threads_range)
12252         (safe_inf_threads_range): Use next_adapter.
12253
12254 2019-01-10  Keith Seitz  <keiths@redhat.com>
12255
12256         PR gdb/23712
12257         PR symtab/23010
12258         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12259         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12260
12261 2019-01-10  Keith Seitz  <keiths@redhat.com>
12262
12263         PR gdb/23712
12264         PR symtab/23010
12265         * dictionary.c (pending_to_vector): Remove.
12266         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12267         Remove _1 suffix, replacing functions of the same name.  Update
12268         all callers.
12269         (dict_create_hashed, dict_create_hashed_expandable)
12270         (dict_create_linear, dict_create_linear_expandable, dict_free)
12271         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12272         Make functions static.
12273
12274 2019-01-10  Keith Seitz  <keiths@redhat.com>
12275
12276         PR gdb/23712
12277         PR symtab/23010
12278         * dictionary.h (struct dictionary): Replace declaration with
12279         multidictionary.
12280         (dict_create_hashed, dict_create_hashed_expandable)
12281         (dict_create_linear, dict_create_linear_expandable)
12282         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12283         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12284         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12285         taking multidictionary argument.
12286         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12287         * block.h (struct block) <dict>: Change to multidictionary
12288         and rename `multidict'.
12289         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12290         symmisc.c: Update all dictionary references to multidictionary.
12291
12292 2019-01-10  Keith Seitz  <keiths@redhat.com>
12293
12294         PR gdb/23712
12295         PR symtab/23010
12296         * dictionary.c: Include unordered_map.
12297         (pending_to_vector): New function.
12298         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12299         Rewrite the non-"_1" functions to take vector instead
12300         of linked list.
12301         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12302         "new" _1 versions of the same name.
12303         (multidictionary): Define.
12304         (std::hash<enum language): New definition.
12305         (collate_pending_symbols_by_language, mdict_create_hashed)
12306         (mdict_create_hashed_expandable, mdict_create_linear)
12307         (mdict_create_linear_expandable, mdict_free)
12308         (find_language_dictionary, create_new_language_dictionary)
12309         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12310         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12311         (mdict_size, mdict_empty): New functions.
12312         * dictionary.h (mdict_iterator): Define.
12313
12314 2019-01-10  Pedro Alves  <palves@redhat.com>
12315
12316         * breakpoint.c (read_uploaded_action)
12317         (create_tracepoint_from_upload): Adjust to use
12318         gdb::unique_xmalloc_ptr.
12319         * ctf.c (ctf_write_uploaded_tp):
12320         (SET_ARRAY_FIELD): Use emplace_back.
12321         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12322         * tracefile-tfile.c (tfile_write_uploaded_tp):
12323         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12324         gdb::unique_xmalloc_ptr.
12325         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12326         at_string, cond_string, cmd_strings>: Replace char pointers
12327         with gdb::unique_xmalloc_ptr.
12328
12329 2019-01-10  Pedro Alves  <palves@redhat.com>
12330
12331         * solib-target.c (library_list_start_library): Don't xstrdup name.
12332
12333 2019-01-10  Pedro Alves  <palves@redhat.com>
12334
12335         * mdebugread.c (parse_partial_symbols): Use
12336         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12337
12338 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12339
12340         * linux-fork.c (scoped_switch_fork_info)
12341         <~scoped_switch_fork_info>: Fix incorrect variable name.
12342
12343 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12344
12345         * linux-fork.c (scoped_switch_fork_info)
12346         <scoped_switch_fork_info>: Make explicit.
12347         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12348
12349 2019-01-10  Tom Tromey  <tom@tromey.com>
12350
12351         * objfiles.h (objfile::reset_psymtabs): Update.
12352         * objfiles.c (objfile::objfile): Update.
12353         * psymtab.h (psymtab_storage::obstack): Update.
12354         (psymtab_storage::m_obstack): Use gdb::optional.
12355         (class psymtab_storage): Update comment.  Remove objfile
12356         parameter.
12357         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12358
12359 2019-01-10  Tom Tromey  <tom@tromey.com>
12360
12361         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12362         <free_psymtabs>: Now private.
12363         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12364         (allocate_psymtab): Use new method.
12365
12366 2019-01-10  Tom Tromey  <tom@tromey.com>
12367
12368         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12369         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12370         * mdebugread.c (parse_partial_symbols): Use
12371         allocate_dependencies.
12372         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12373         allocate_dependencies.
12374         (process_psymtab_comp_unit_reader)
12375         (build_type_psymtab_dependencies): Likewise.
12376         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12377
12378 2019-01-10  Tom Tromey  <tom@tromey.com>
12379
12380         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12381         PSYMBOL_SET_LANGUAGE.
12382         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12383
12384 2019-01-10  Tom Tromey  <tom@tromey.com>
12385
12386         * psymtab.h (psymtab_storage::obstack): New method.
12387         <m_obstack>: Rename from obstack; now private.
12388         * psymtab.c (psymtab_storage): Update.
12389         * dwarf2read.c (create_addrmap_from_index)
12390         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12391         Update.
12392
12393 2019-01-10  Tom Tromey  <tom@tromey.com>
12394
12395         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12396         * objfiles.h (objfile::reset_psymtabs): New method.
12397
12398 2019-01-10  Tom Tromey  <tom@tromey.com>
12399
12400         * symmisc.c (print_symbol_bcache_statistics): Update.
12401         (print_objfile_statistics): Update.
12402         * symfile.c (reread_symbols): Update.
12403         * psymtab.h (class psymtab_storage): New.
12404         * psymtab.c (psymtab_storage): New constructor.
12405         (~psymtab_storage): New destructor.
12406         (require_partial_symbols): Update.
12407         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12408         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12409         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12410         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12411         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12412         (start_psymtab_common, end_psymtab_common)
12413         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12414         (allocate_psymtab): Update.
12415         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12416         Update.
12417         (dump_psymtab_addrmap, maintenance_print_psymbols)
12418         (maintenance_check_psymtabs): Update.
12419         (class objfile_psymtabs): Move to objfiles.h.
12420         * psympriv.h (discard_psymtab): Now inline.
12421         (psymtab_discarder::psymtab_discarder): Update.
12422         (psymtab_discarder::~psymtab_discarder): Update.
12423         (ALL_OBJFILE_PSYMTABS): Rewrite.
12424         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12425         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12426         Remove fields.
12427         <partial_symtabs>: New field.
12428         (class objfile_psymtabs): Move from psymtab.h.  Update.
12429         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12430         psymbol_cache.
12431         (objfile::~objfile): Don't destroy psymbol_cache.
12432         * mdebugread.c (parse_partial_symbols): Update.
12433         * dwarf2read.c (create_addrmap_from_index)
12434         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12435         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12436         (add_partial_subprogram, dwarf2_ranges_read): Update.
12437         * dwarf-index-write.c (write_address_map)
12438         (write_one_signatured_type, recursively_write_psymbols)
12439         (class debug_names, class debug_names, write_psymtabs_to_index):
12440         Update.
12441
12442 2019-01-10  Tom Tromey  <tom@tromey.com>
12443
12444         * symtab.h (SYMBOL_SET_NAMES): Update.
12445         (symbol_set_names): Update.
12446         (MSYMBOL_SET_NAMES): Update.
12447         * symtab.c (symbol_set_names): Change argument to be an
12448         objfile_per_bfd_storage.
12449         * psymtab.c (add_psymbol_to_bcache): Update.
12450         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12451
12452 2019-01-10  Tom Tromey  <tom@tromey.com>
12453
12454         * symtab.c (create_demangled_names_hash): Change argument to be an
12455         objfile_per_bfd_storage.
12456         (symbol_set_names): Update.
12457
12458 2019-01-10  Tom Tromey  <tom@tromey.com>
12459
12460         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12461         init_psymbol_list.
12462         * psymtab.c (init_psymbol_list): Do nothing if already called.
12463         * psympriv.h (init_psymbol_list): Add comment.
12464         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12465         init_psymbol_list.
12466         * dbxread.c (dbx_symfile_read): Unconditionally call
12467         init_psymbol_list.
12468
12469 2019-01-10  Tom Tromey  <tom@tromey.com>
12470
12471         * xcoffread.c (scan_xcoff_symtab): Update.
12472         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12473         "where".
12474         * mdebugread.c (parse_partial_symbols)
12475         (handle_psymbol_enumerators): Update.
12476         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12477         * dbxread.c (read_dbx_symtab): Update.
12478         * psympriv.h (psymbol_placement): New enum.
12479         (add_psymbol_to_list): Update.
12480
12481 2019-01-10  Tom Tromey  <tom@tromey.com>
12482
12483         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12484         static_psymbols parameters.
12485         (scan_xcoff_symtab): Update.
12486         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12487         static_psymbols parameters.
12488         * psympriv.h (start_psymtab_common): Update.
12489         * mdebugread.c (parse_partial_symbols): Update.
12490         * dwarf2read.c (create_partial_symtab): Update.
12491         * dbxread.c (read_dbx_symtab): Update.
12492         (start_psymtab): Remove global_psymbols and static_psymbols
12493         parameters.
12494
12495 2019-01-10  Tom Tromey  <tom@tromey.com>
12496
12497         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12498         * psymtab.c (allocate_psymtab): Add comment.
12499         * psympriv.h (allocate_psymtab): Add comment.
12500         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12501         initializations.
12502         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12503
12504 2019-01-10  Tom Tromey  <tom@tromey.com>
12505
12506         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12507         Don't declare.
12508         * mipsread.c: Include mdebugread.h.
12509         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12510         Declare.
12511         * elfread.c: Include mdebugread.h.
12512
12513 2019-01-09  Tom Tromey  <tom@tromey.com>
12514
12515         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12516         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12517         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12518         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12519         (psym_lookup_symbol, psym_find_last_source_symtab)
12520         (psym_forget_cached_source_info, psym_print_stats)
12521         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12522         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12523         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12524         (psym_find_compunit_symtab_by_address)
12525         (maintenance_print_psymbols, maintenance_info_psymtabs)
12526         (maintenance_check_psymtabs): Use ranged for.
12527         * psymtab.h (class objfile_psymtabs): New.
12528         (require_partial_symbols): Return objfile_psymtabs.
12529         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12530
12531 2019-01-09  Tom Tromey  <tom@tromey.com>
12532
12533         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12534         (find_pc_mapped_section, list_overlays_command)
12535         (map_overlay_command, unmap_overlay_command)
12536         (simple_overlay_update): Use all_objfiles.
12537         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12538         * printcmd.c (info_symbol_command): Use all_objfiles.
12539         * objfiles.h (ALL_OBJSECTIONS): Remove.
12540         * maint.c (maintenance_translate_address): Use all_objfiles.
12541         * gcore.c (gcore_create_callback): Use all_objfiles.
12542         (objfile_find_memory_regions): Likewise.
12543
12544 2019-01-09  Tom Tromey  <tom@tromey.com>
12545
12546         * symtab.c (find_line_symtab, info_sources_command)
12547         (make_source_files_completion_list): Use objfile_compunits.
12548         * source.c (select_source_symtab): Use objfile_compunits.
12549         * objfiles.h (struct objfile): Update comment.
12550         (ALL_OBJFILES): Remove.
12551         (ALL_FILETABS): Remove.
12552         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12553         objfile_compunits.
12554
12555 2019-01-09  Tom Tromey  <tom@tromey.com>
12556
12557         * symmisc.c (print_objfile_statistics, dump_objfile)
12558         (maintenance_print_symbols): Use compunit_filetabs.
12559         * source.c (forget_cached_source_info_for_objfile): Use
12560         compunit_filetabs.
12561         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12562         (ALL_FILETABS): Use compunit_filetabs.
12563         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12564         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12565
12566 2019-01-09  Tom Tromey  <tom@tromey.com>
12567
12568         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12569         (compunit_filetabs): New.
12570         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12571         compunit_filetabs.
12572         (info_sources_command, make_source_files_completion_list): Remove
12573         declaration.
12574         * symmisc.c (print_objfile_statistics, dump_objfile)
12575         (maintenance_print_symbols): Remove declaration.
12576         (maintenance_info_symtabs): Use compunit_filetabs.
12577         (maintenance_info_line_tables): Likewise.
12578         * source.c (select_source_symtab): Change local variable name.
12579         (forget_cached_source_info_for_objfile): Remove declaration.
12580         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12581         * objfiles.c (objfile_relocate1): Remove declaration.
12582         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12583         declaration.
12584         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12585         * coffread.c (coff_symtab_read): Remove declaration.
12586         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12587         compunit_filetabs.
12588
12589 2019-01-09  Tom Tromey  <tom@tromey.com>
12590
12591         * symtab.c (lookup_objfile_from_block)
12592         (find_pc_sect_compunit_symtab, search_symbols)
12593         (default_collect_symbol_completion_matches_break_on): Use
12594         objfile_compunits.
12595         * objfiles.h (ALL_COMPUNITS): Remove.
12596         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12597         * cp-support.c (add_symbol_overload_list_qualified): Use
12598         objfile_compunits.
12599         * ada-lang.c (ada_collect_symbol_completion_matches)
12600         (ada_add_global_exceptions): Use objfile_compunits.
12601
12602 2019-01-09  Tom Tromey  <tom@tromey.com>
12603
12604         * source.c (select_source_symtab)
12605         (forget_cached_source_info_for_objfile): Remove declaration.
12606         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12607         declaration.
12608         * maint.c (count_symtabs_and_blocks): Remove declaration.
12609         * cp-support.c (add_symbol_overload_list_qualified): Remove
12610         declaration.
12611         * coffread.c (coff_symtab_read): Remove declaration.
12612         * symtab.c (lookup_symbol_in_objfile_symtabs)
12613         (basic_lookup_transparent_type_1): Use objfile_compunits.
12614         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12615         (info_sources_command, search_symbols)
12616         (default_collect_symbol_completion_matches_break_on)
12617         (make_source_files_completion_list): Remove declaration.
12618         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12619         (ada_collect_symbol_completion_matches)
12620         (ada_add_global_exceptions): Remove declaration.
12621         * linespec.c (iterate_over_all_matching_symtabs): Use
12622         objfile_compunits.
12623         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12624         (class objfile_compunits): New.
12625         (ALL_COMPUNITS): Use objfile_compunits.
12626         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12627         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12628         objfile_compunits.
12629         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12630
12631 2019-01-09  Tom Tromey  <tom@tromey.com>
12632
12633         * symtab.c (search_symbols)
12634         (default_collect_symbol_completion_matches_break_on): Use
12635         objfile_msymbols.
12636         * ada-lang.c (ada_lookup_simple_minsym)
12637         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12638         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12639         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12640         objfile_msymbols.
12641         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12642         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12643         * objc-lang.c (find_methods): Use objfile_msymbols.
12644         (info_selectors_command, info_classes_command): Likewise.
12645         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12646         * objfiles.h (class objfile_msymbols): New.
12647         (ALL_OBJFILE_MSYMBOLS): Remove.
12648         (ALL_MSYMBOLS): Remove.
12649
12650 2019-01-09  Tom Tromey  <tom@tromey.com>
12651
12652         * common/next-iterator.h (next_adapter): Add Iterator template
12653         parameter.
12654         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12655         (class all_objfiles_safe): New.
12656         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12657         * objfiles.c (put_objfile_before): Update comment.
12658         (add_separate_debug_objfile): Likewise.
12659         (free_all_objfiles): Use all_objfiles_safe.
12660         (objfile_purge_solibs): Likewise.
12661
12662 2019-01-09  Tom Tromey  <tom@tromey.com>
12663
12664         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12665         (expand_symtab_containing_pc, lookup_static_symbol)
12666         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12667         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12668         all_objfiles.
12669         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12670         * breakpoint.c (create_overlay_event_breakpoint)
12671         (create_longjmp_master_breakpoint)
12672         (create_std_terminate_master_breakpoint)
12673         (create_exception_master_breakpoint): Use all_objfiles.
12674         * linux-thread-db.c (try_thread_db_load_from_pdir)
12675         (has_libpthread): Use all_objfiles.
12676         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12677         * linespec.c (iterate_over_all_matching_symtabs)
12678         (search_minsyms_for_name): Use all_objfiles.
12679         * maint.c (maintenance_info_sections): Use all_objfiles.
12680         * main.c (captured_main_1): Use all_objfiles.
12681         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12682         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12683         * guile/scm-pretty-print.c
12684         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12685         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12686         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12687         (maintenance_print_msymbols): Use all_objfiles.
12688         * source.c (select_source_symtab): Use all_objfiles.
12689         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12690         * symfile.c (remove_symbol_file_command)
12691         (expand_symtabs_matching, map_symbol_filenames): Use
12692         all_objfiles.
12693         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12694         all_objfiles.
12695         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12696         * objc-lang.c (find_methods): Use all_objfiles.
12697         * objfiles.c (have_partial_symbols, have_full_symbols)
12698         (have_minimal_symbols, qsort_cmp)
12699         (default_iterate_over_objfiles_in_search_order): Use
12700         all_objfiles.
12701         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12702         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12703         (maintenance_check_psymtabs): Use all_objfiles.
12704         (ALL_PSYMTABS): Remove.
12705         * compile/compile-object-run.c (do_module_cleanup): Use
12706         all_objfiles.
12707         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12708         * cp-support.c (add_symbol_overload_list_qualified): Use
12709         all_objfiles.
12710         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12711         Use all_objfiles.
12712         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12713         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12714         all_objfiles.
12715         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12716         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12717         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12718         Uses all_objfiles.
12719         * solib.c (solib_read_symbols): Use all_objfiles
12720
12721 2019-01-09  Tom Tromey  <tom@tromey.com>
12722
12723         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12724         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12725         all_objfiles.
12726         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12727         * symmisc.c (print_symbol_bcache_statistics)
12728         (print_objfile_statistics, maintenance_print_objfiles)
12729         (maintenance_info_symtabs, maintenance_check_symtabs)
12730         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12731         all_objfiles.
12732         * source.c (forget_cached_source_info): Use all_objfiles.
12733         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12734         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12735         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12736         * objfiles.c (update_section_map): Use all_objfiles.
12737         (shared_objfile_contains_address_p): Likewise.
12738         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12739         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12740
12741 2019-01-09  Tom Tromey  <tom@tromey.com>
12742
12743         * common/next-iterator.h: New file.
12744         * objfiles.h (class all_objfiles): New.
12745         (struct objfile_iterator): New.
12746
12747 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12748
12749         * NEWS: Move the description of the changed "frame", "select-frame",
12750          and "info frame" commands to the Changed commands section.
12751
12752 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12753
12754         * gdbtypes.c (check_stub_method_group): Remove handling of old
12755         mangling schemes.
12756         * linespec.c (find_methods): Likewise.
12757         * stabsread.c (read_member_functions): Likewise.
12758         * valops.c (search_struct_method): Likewise.
12759         (value_struct_elt_for_reference): Likewise.
12760         * NEWS: Mention this change.
12761
12762 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12763
12764         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12765         print_source_lines.
12766         * source.c (print_source_lines_base): Update line number check.
12767         (print_source_lines): New function.
12768         (source_lines_range::source_lines_range): New function.
12769         * source.h (class source_lines_range): New class.
12770         (print_source_lines): New declaration.
12771
12772 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12773
12774         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12775
12776 2019-01-08  Tom Tromey  <tom@tromey.com>
12777             Simon Marchi  <simon.marchi@ericsson.com>
12778
12779         PR gdb/24060
12780         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12781         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12782         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12783         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12784         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12785         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12786
12787 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12788
12789         * source.c (select_source_symtab): Move header comment to
12790         declaration in source.h.
12791         (forget_cached_source_info_for_objfile): Likewise.
12792         (forget_cached_source_info): Likewise.
12793         (identify_source_line): Likewise.
12794         * source.h (identify_source_line): Move declaration from symtab.h
12795         and add comment from source.c
12796         (print_source_lines): Likewise.
12797         (forget_cached_source_info_for_objfile): Likewise.
12798         (forget_cached_source_info): Likewise.
12799         (select_source_symtab): Likewise.
12800         (enum print_source_lines_flag): Move definition from symtab.h.
12801         * symtab.h (identify_source_line): Move declaration to source.h.
12802         (print_source_lines): Likewise.
12803         (forget_cached_source_info_for_objfile): Likewise.
12804         (forget_cached_source_info): Likewise.
12805         (select_source_symtab): Likewise.
12806         (enum print_source_lines_flag): Move definition to source.h.
12807         * tui/tui-hooks.c: Add 'source.h' include.
12808
12809 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12810
12811         * source.c (print_source_lines_base): Handle requests to print
12812         reverse line number sequences, and guard against empty lines
12813         string.
12814
12815 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12816
12817         * source.c (print_source_lines_base): Fix skip of '\r' if next
12818         character is '\n'.
12819
12820 2019-01-06  Tom Tromey  <tom@tromey.com>
12821
12822         * c-exp.y (struct c_parse_state) <macro_original_text,
12823         expansion_obstack>: New member.
12824         (macro_original_text, expansion_obstack): Remove globals.
12825         (scan_macro_expansion, scanning_macro_expansion)
12826         (finished_macro_expansion): Update.
12827         (scan_macro_cleanup): Remove.
12828         (yylex, c_parse): Update.
12829
12830 2019-01-06  Tom Tromey  <tom@tromey.com>
12831
12832         * c-exp.y (struct c_parse_state) <strings>: New member.
12833         (operator_stoken): Update.
12834
12835 2019-01-06  Tom Tromey  <tom@tromey.com>
12836
12837         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12838         (union type_stack_elt) <typelist_val>: Now a pointer to
12839         std::vector.
12840         (type_stack_cleanup): Don't declare.
12841         (push_typelist): Update.
12842         * parse.c (pop_typelist): Return a std::vector.
12843         (push_typelist): Take a std::vector.
12844         (follow_types): Update.  Do not free args.
12845         (type_stack_cleanup): Remove.
12846         * c-exp.y (struct c_parse_state): New.
12847         (cpstate): New global.
12848         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12849         (nonempty_typelist): Update.
12850         (func_mod): Create a new vector.
12851         (c_parse): Create a c_parse_state.
12852         (check_parameter_typelist): Do not delete params.
12853         (function_method): Update.  Do not delete type_list.
12854
12855 2019-01-06  Tom Tromey  <tom@tromey.com>
12856
12857         PR gdb/28155:
12858         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12859         check_typedef.
12860         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12861         (print_return_value): Likewise.
12862
12863 2019-01-05  Tom Tromey  <tom@tromey.com>
12864
12865         * contrib/cleanup_check.py: Remove.
12866         * contrib/gcc-with-excheck: Remove.
12867         * contrib/exsummary.py: Remove.
12868         * contrib/excheck.py: Remove.
12869
12870 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12871
12872         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12873         NULL. Initialize tpprev to NULL instead of assigning it
12874         to NULL on the next statement.
12875         * windows-nat.c (windows_delete_thread): Remove check for
12876         main_thread_id before printing thread exit notifications.
12877         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12878         Remove thread ID check against main_thread_id.
12879         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12880         windows_delete_thread.
12881         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12882
12883 2019-01-04  Tom Tromey  <tom@tromey.com>
12884
12885         * compile/compile.c (_initialize_compile): Use upper case for
12886         metasyntactic variables.
12887         * symmisc.c (_initialize_symmisc): Use upper case for
12888         metasyntactic variables.
12889         * psymtab.c (_initialize_psymtab): Use upper case for
12890         metasyntactic variables.
12891         * demangle.c (demangle_command): Use upper case for metasyntactic
12892         variables.
12893         (_initialize_demangler): Likewise.
12894         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12895         variables.
12896
12897 2019-01-03  Tom Tromey  <tom@tromey.com>
12898
12899         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12900
12901 2019-01-03  Tom Tromey  <tom@tromey.com>
12902
12903         * python/py-symtab.c (salpy_str): Update.
12904         (struct salpy_sal_object) <symtab>: Now a PyObject.
12905         (salpy_dealloc): Update.
12906         (del_objfile_sal): Use gdbpy_ref.
12907
12908 2019-01-03  Tom Tromey  <tom@tromey.com>
12909
12910         * python/py-type.c (convert_field): Use new_reference.  Return
12911         gdbpy_ref.
12912         (make_fielditem): Return gdbpy_ref.
12913         (typy_fields): Update.
12914         (typy_getitem): Update.
12915         (field_name): Return gdbpy_ref.  Use new_reference.
12916         (typy_iterator_iternext): Update.
12917
12918 2019-01-03  Tom Tromey  <tom@tromey.com>
12919
12920         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12921
12922 2019-01-03  Tom Tromey  <tom@tromey.com>
12923
12924         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12925         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12926         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12927         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12928         (pspy_set_type_printers): Likewise.
12929         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12930         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12931         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12932         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12933         (objfpy_set_type_printers): Likewise.
12934
12935 2019-01-03  Tom Tromey  <tom@tromey.com>
12936
12937         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12938         (gdbpy_print_stack): Use gdbpy_err_fetch.
12939         * python/python-internal.h (class gdbpy_err_fetch): New class.
12940         (class gdbpy_enter) <m_error_type, m_error_value,
12941         m_error_traceback>: Remove.
12942         <m_error>: New member.
12943         (gdbpy_exception_to_string): Don't declare.
12944         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12945         * python/py-value.c (convert_value_from_python): Use
12946         gdbpy_err_fetch.
12947         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12948         gdbpy_exception_to_string.
12949         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12950         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12951         gdbpy_err_fetch.
12952
12953 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12954
12955         * linux-nat.c (delete_lwp_cleanup): Delete.
12956         (struct lwp_deleter): New struct.
12957         (lwp_info_up): New typedef.
12958         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12959         lwp_info_up.
12960
12961 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12962
12963         * linux-fork.c (class scoped_switch_fork_info): New class.
12964         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12965
12966 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12967
12968         * valops.c (find_overload_match): Remove use of null_cleanup, and
12969         calls to do_cleanups.
12970
12971 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12972
12973         * compile/compile-cplus-types.c
12974         (compile_cplus_instance::decl_name): Handle changes to
12975         cp_func_name.
12976         * cp-support.c (cp_func_name): Update header comment, update
12977         return type.
12978         * cp-support.h (cp_func_name): Update return type in declaration.
12979         * valops.c (find_overload_match): Move temp_func local to top
12980         level of function and change its type.  Use temp_func to hold and
12981         delete temporary string obtained from cp_func_name.
12982
12983 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12984
12985         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12986         gdb::char_vector, remove cleanup, and update uses of `msg`.
12987
12988 2019-01-03  Jim Wilson  <jimw@sifive.com>
12989
12990         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12991
12992 2019-01-02  Tom Tromey  <tom@tromey.com>
12993
12994         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12995         (tdesc_parse_xml): Remove cleanups.
12996         * target-descriptions.h (make_cleanup_free_target_description):
12997         Don't declare.
12998         (target_desc_deleter): New struct.
12999         (target_desc_up): New typedef.
13000         * target-descriptions.c (target_desc_deleter::operator()): Rename
13001         from free_target_description.
13002         (make_cleanup_free_target_description): Remove.
13003
13004 2019-01-02  Tom Tromey  <tom@tromey.com>
13005
13006         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13007         constructor, destructor.
13008         (linespec_parser): Remove typedef.
13009         (~linespec_parser): Rename from linespec_parser_delete.
13010         (linespec_lex_to_end, linespec_complete_label)
13011         (linespec_complete): Update.
13012         (decode_line_full): Remove cleanups.
13013         (decode_line_1): Update.
13014
13015 2019-01-02  Tom Tromey  <tom@tromey.com>
13016
13017         * python/python-internal.h (inferior_to_inferior_object): Change
13018         return type.
13019         * python/py-exitedevent.c (create_exited_event_object): Update.
13020         * python/py-inferior.c (inferior_to_inferior_object): Return
13021         gdbpy_ref.
13022         (python_new_inferior, python_inferior_deleted)
13023         (thread_to_thread_object, delete_thread_object)
13024         (build_inferior_list, gdbpy_selected_inferior): Update.
13025         * python/py-infthread.c (create_thread_object): Update.  Also fail
13026         if inferior_to_inferior_object fails.
13027
13028 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13029
13030         * inferior.h (class inferior) <displaced_step_state>: New field.
13031         * infrun.h (struct displaced_step_state): Move here from
13032         infrun.c.  Initialize fields, add constructor.
13033         <inf>: Remove field.
13034         <reset>: New method.
13035         * infrun.c (struct displaced_step_inferior_state): Move to
13036         infrun.h.
13037         (displaced_step_inferior_states): Remove.
13038         (get_displaced_stepping_state): Adust.
13039         (displaced_step_in_progress_any_inferior): Adjust.
13040         (displaced_step_in_progress_thread): Adjust.
13041         (displaced_step_in_progress): Adjust.
13042         (add_displaced_stepping_state): Remove.
13043         (get_displaced_step_closure_by_addr): Adjust.
13044         (remove_displaced_stepping_state): Remove.
13045         (infrun_inferior_exit): Call displaced_step_state.reset.
13046         (use_displaced_stepping): Don't check for NULL.
13047         (displaced_step_prepare_throw): Call
13048         get_displaced_stepping_state.
13049         (displaced_step_fixup): Don't check for NULL.
13050         (prepare_for_detach): Don't check for NULL.
13051
13052 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13053
13054         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13055          in case of call that did not complete.
13056
13057 2019-01-02  Andrey Utkin  <autkin@undo.io>
13058
13059         * symfile.c (find_separate_debug_file): Fix search of debug files for
13060         remote debuggee.
13061
13062 2019-01-02  Tom Tromey  <tom@tromey.com>
13063
13064         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13065         indentation.
13066         * python/py-frame.c (frapy_older): Remove cast.
13067         (frapy_newer): Likewise.
13068         * python/py-breakpoint.c (local_setattro): Remove cast.
13069         * python/py-arch.c (archpy_name): Remove local variable.
13070         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13071
13072 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13073
13074         * unittests/basic_string_view/element_access/char/empty.cc:
13075         Fix year range in copyright header.
13076
13077 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13078
13079         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13080         Delete.
13081         <operator==>: Update with for removed field.
13082         <hash>: Likewise.
13083         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13084         <isa_features>: ...this.
13085         <abi_features>: New field.
13086         (riscv_isa_flen): Update comment.
13087         (riscv_abi_xlen): New declaration.
13088         (riscv_abi_flen): New declaration.
13089         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13090         isa_features.
13091         (riscv_abi_xlen): New function.
13092         (riscv_isa_flen): Update to get answer from isa_features.
13093         (riscv_abi_flen): New function.
13094         (riscv_has_fp_abi): Update to get answer from abi_features.
13095         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13096         xlen and flen.
13097         (riscv_call_info) <xlen, flen>: Update comment.
13098         (riscv_call_arg_struct): Remove invalid assertions
13099         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13100         is removed.
13101         (riscv_gdbarch_init): Gather isa features and abi features
13102         separately, ensure both match on the gdbarch when reusing an old
13103         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13104         a target with 64-bit float hardware.
13105
13106 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13107
13108         * source.c (search_command_helper): Stop reverse search
13109         when line 1 has been searched.
13110
13111 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13112
13113         * record-full.c (record_full_base_target::close): Rewrite
13114         record_full_core_buf_list free logic.
13115
13116 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13117
13118         * break-catch-syscall.c (print_one_catch_syscall): xfree
13119         the last text.
13120
13121 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13122
13123         * top.c (print_gdb_version): Update Copyright year in version
13124         message.
13125
13126 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13127
13128         Update copyright year range in all GDB files.
13129
13130 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13131
13132         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13133
13134 For older changes see ChangeLog-2018.
13135 \f
13136 Local Variables:
13137 mode: change-log
13138 left-margin: 8
13139 fill-column: 74
13140 version-control: never
13141 coding: utf-8
13142 End:
13143