gdb/ChangeLog

   1 2019-08-15  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
   4         * tui/tui-winsource.c (tui_line_is_displayed): Move to
   5         tui-source.c.
   6         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
   7         Declare.
   8         * tui/tui-source.c (tui_source_window::line_is_displayed): New
   9         method.
  10         (tui_source_window::maybe_update): Update.
  11
  12 2019-08-15  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
  15         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
  16         tui-disasm.c.
  17         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
  18         Declare.
  19         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
  20         method.
  21         (tui_disasm_window::maybe_update): Update.
  22
  23 2019-08-15  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-winsource.h (struct tui_source_window_base)
  26         <maybe_update>: Declare.
  27         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
  28         method.
  29         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
  30         Declare.
  31         * tui/tui-source.c (tui_source_window::maybe_update): New method.
  32         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
  33         Declare.
  34         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
  35
  36 2019-08-15  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
  39
  40 2019-08-15  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-wingeneral.c: Include tui-stack.h.
  43         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
  44         (struct tui_locator_window): Move from tui-data.h.
  45         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
  46         (tui_initialize_static_data): Move from tui-data.c.
  47         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
  48         (struct tui_locator_window): Move to tui-stack.c.
  49         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
  50         (tui_initialize_static_data): Move to tui-stack.c.
  51
  52 2019-08-15  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-layout.c (show_source_disasm_command)
  55         (show_source_or_disasm_and_command): Use make_visible method, not
  56         tui_make_window.
  57         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
  58         Remove.
  59
  60 2019-08-15  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-wingeneral.h (tui_make_window): Update.
  63         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
  64         parameter.
  65         (tui_gen_win_info::make_visible): Update.
  66         * tui/tui-regs.c (tui_data_window::display_registers_from):
  67         Update.
  68         * tui/tui-layout.c (show_source_disasm_command)
  69         (show_source_or_disasm_and_command): Update.
  70         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
  71         (enum tui_box): Remove.
  72         (struct tui_win_info) <can_box>: New method.
  73         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
  74         method.
  75
  76 2019-08-15  Tom de Vries  <tdevries@suse.de>
  77
  78         * linux-nat-trad.c: Include gdbarch.h.
  79
  80 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
  81
  82         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
  83         register sizes.
  84
  85 2019-08-14  Tom Tromey  <tromey@adacore.com>
  86
  87         * darwin-nat.c: Include gdbarch.h.
  88         * darwin-nat-info.c: Include gdbarch.h.
  89
  90 2019-08-13  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
  93         Remove.
  94         * tui/tui-data.c (tui_initialize_static_data): Update.
  95
  96 2019-08-13  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.h (struct tui_exec_info_window)
  99         <~tui_exec_info_window, maybe_allocate_content, get_content,
 100         m_content>: Remove.
 101         (struct tui_source_window_base) <set_exec_info_content,
 102         show_exec_info_content>: Don't declare.
 103         * tui/tui-winsource.c
 104         (tui_exec_info_window::maybe_allocate_content): Remove.
 105         (tui_source_window_base::update_exec_info): Rename from
 106         set_exec_info_content.
 107         (tui_source_window_base::show_exec_info_content)
 108         (tui_source_window_base::update_exec_info): Remove.
 109
 110 2019-08-13  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 113         declare.
 114         * tui/tui-winsource.c (tui_update_source_window_as_is)
 115         (tui_update_source_windows_with_addr, tui_erase_source_content):
 116         Update.
 117         (tui_clear_exec_info_content): Remove.
 118
 119 2019-08-13  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 122         declare.
 123         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 124         call tui_erase_exec_info_content.
 125         (tui_clear_exec_info_content): Rename from
 126         tui_erase_exec_info_content.
 127         (tui_clear_exec_info_content): Delete.
 128
 129 2019-08-13  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-winsource.h (struct tui_source_window_base)
 132         <show_exec_info_content>: Declare.
 133         (tui_show_exec_info_content): Don't declare.
 134         * tui/tui-winsource.c
 135         (tui_source_window_base::show_exec_info_content): Rename from
 136         tui_show_exec_info_content.
 137         (tui_source_window_base::update_exec_info): Update.
 138
 139 2019-08-13  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 142         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 143         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 144         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 145         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 146         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 147         ... here.
 148
 149 2019-08-13  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-winsource.h (struct tui_source_window_base)
 152         <update_exec_info>: Declare.
 153         (tui_update_exec_info): Don't declare.
 154         * tui/tui-winsource.c (tui_update_source_window_as_is)
 155         (tui_source_window_base::refresh_all)
 156         (tui_update_all_breakpoint_info): Update.
 157         (tui_source_window_base::update_exec_info): Rename from
 158         tui_update_exec_info.
 159         * tui/tui-stack.c (tui_show_frame_info): Update.
 160
 161 2019-08-13  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-winsource.h (struct tui_source_window_base)
 164         <set_exec_info_content>: Declare.
 165         (tui_set_exec_info_content): Don't declare.
 166         * tui/tui-winsource.c
 167         (tui_source_window_base::set_exec_info_content): Rename from
 168         tui_set_exec_info_content.
 169         (tui_update_exec_info): Update.
 170
 171 2019-08-13  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-winsource.h (struct tui_source_window_base)
 174         <show_source_content>: Declare.
 175         (tui_show_source_content): Don't declare.
 176         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 177         (tui_source_window_base::show_source_content): Rename from
 178         tui_show_source_content.
 179         (tui_source_window_base::refresh_all): Update.
 180         * tui/tui-layout.c (show_source_disasm_command)
 181         (show_source_or_disasm_and_command): Update.
 182
 183 2019-08-13  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-winsource.c (tui_erase_source_content)
 186         (tui_show_source_content, tui_source_window_base::refresh_all):
 187         Update.
 188         * tui/tui-wingeneral.h
 189         (tui_check_and_display_highlight_if_needed): Don't declare.
 190         * tui/tui-wingeneral.c
 191         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 192         check_and_display_highlight_if_needed.
 193         * tui/tui-win.c (tui_rehighlight_all)
 194         (tui_win_info::make_visible_with_new_height): Update.
 195         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 196         (tui_data_window::erase_data_content)
 197         (tui_data_window::display_all_data): Update.
 198         * tui/tui-data.h (struct tui_win_info)
 199         <check_and_display_highlight_if_needed>: Declare.
 200
 201 2019-08-13  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-win.c (tui_resize_all): Call
 204         tui_delete_invisible_windows.
 205         * tui/tui-layout.c (show_layout): Call
 206         tui_delete_invisible_windows.
 207         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 208         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 209
 210 2019-08-13  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 213         tui_add_win_to_layout.
 214
 215 2019-08-13  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 218         * tui/tui-layout.c (tui_default_win_height): Now static.
 219
 220 2019-08-13  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 223         single switch.
 224         (show_source_disasm_command, show_source_or_disasm_and_command):
 225         Don't check current layout.
 226
 227 2019-08-13  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-wingeneral.c (make_all_visible): Remove.
 230         (tui_make_all_invisible): Simplify.
 231         * tui/tui-layout.c (tui_make_all_invisible): Move from
 232         tui-wingeneral.c; simplify.
 233         (show_layout): Hoist call to tui_make_all_invisible.
 234         (show_data): Don't call tui_make_all_invisible.
 235
 236 2019-08-13  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 239         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 240
 241 2019-08-13  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 244         tui-data.c.
 245         (show_source_disasm_command, show_data)
 246         (show_source_or_disasm_and_command): Don't use
 247         tui_set_current_layout_to.
 248         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 249         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 250         tui-layout.c.
 251         (tui_set_current_layout_to): Remove.
 252
 253 2019-08-13  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-layout.c (tui_set_layout): Update.
 256         * tui/tui-data.h (struct tui_layout_def): Remove.
 257         (tui_layout_def): Don't declare.
 258         * tui/tui-data.c (layout_def): Remove.
 259         (tui_layout_def): Remove.
 260
 261 2019-08-13  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-winsource.h (struct tui_source_window_base)
 264         <clear_detail>: No longer "override".
 265         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 266         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 267         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 268         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 269         Remove.
 270         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 271
 272 2019-08-13  Tom Tromey  <tromey@adacore.com>
 273
 274         * tracepoint.c: Don't include readline.h or history.h.
 275
 276 2019-08-12  Tom Tromey  <tom@tromey.com>
 277
 278         * configure: Rebuild.
 279         * configure.ac: Check for readline 7.
 280         * NEWS: Mention readline 7 requirement.
 281         * README: Update.
 282
 283 2019-08-12  Tom Tromey  <tom@tromey.com>
 284
 285         * mingw-hdep.c (gdb_select): Remove readline hack.
 286
 287 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 288
 289         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 290         when the function fails.
 291
 292 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 293
 294         * s390-tdep.c (s390_type_align): New function.
 295         (s390_gdbarch_init): Set it as type_align gdbarch method.
 296
 297 2019-08-09  Tom de Vries  <tdevries@suse.de>
 298
 299         PR gdb/24591
 300         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 301         pc_low with relocation offset.
 302
 303 2019-08-07  Tom Tromey  <tromey@adacore.com>
 304
 305         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 306         (print_frame_args): Update.
 307         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 308         Update.
 309         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 310         * frame.h (struct frame_arg): Add initializers.
 311         <error>: Now a unique_xmalloc_ptr.
 312
 313 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 314
 315         * NEWS: Expand the Pointer Authentication entry.
 316         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 317         (aarch64_frame_unmask_lr): ... to this.
 318         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 319         Call aarch64_frame_unmask_lr.
 320         * frame.c (struct frame_info): Add "masked" variable.
 321         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 322         (fprint_frame): Check for masked pc.
 323         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 324         declarations.
 325         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 326         * stack.c (print_frame): Check for masked pc.
 327
 328 2019-08-06  Tom Tromey  <tom@tromey.com>
 329
 330         * stabsread.c (patch_block_stabs, read_one_struct_field)
 331         (read_enum_type): Use obstack_strndup.
 332         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 333         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 334         * dwarf2read.c (guess_full_die_structure_name)
 335         (anonymous_struct_prefix): Use obstack_strndup.
 336         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 337         * c-exp.y (yylex): Use obstack_strndup.
 338         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 339         (write_var_or_type): Use obstack_strndup.
 340
 341 2019-08-06  Tom Tromey  <tom@tromey.com>
 342
 343         * symfile.c (reread_symbols): Use obstack_strdup.
 344         * stabsread.c (read_type): Use obstack_strdup.
 345         * gdb_obstack.h (obstack_strdup): New overload.
 346         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 347         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 348         (dwarf2_canonicalize_name): Use obstack_strdup.
 349         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 350         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 351         Use obstack_strdup.
 352
 353 2019-08-06  Tom Tromey  <tom@tromey.com>
 354
 355         * gdb_obstack.h (obstack_strdup): Define.
 356         * gdb_obstack.c (obstack_strdup): Don't define.
 357
 358 2019-08-06  Tom Tromey  <tom@tromey.com>
 359
 360         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 361         obstack_strdup.
 362         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 363         obstack_strdup.
 364         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 365         * stabsread.c (common_block_start): Use obstack_strdup.
 366         * objfiles.c (set_objfile_main_name, objfile): Use
 367         obstack_strdup.
 368         * namespace.c (add_using_directive): Use obstack_strdup.
 369         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 370         * jit.c (finalize_symtab): Use obstack_strdup.
 371         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 372         (guess_partial_die_structure_name, partial_die_info::fixup)
 373         (dwarf2_name): Use obstack_strdup.
 374         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 375         obstack_strdup.
 376         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 377         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 378         obstack_strdup.
 379         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 380
 381 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 382
 383         * unittests/help-doc-selftests.c: New file.
 384         * Makefile.in: Add the new file.
 385
 386 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 387
 388         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 389         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 390         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 391         the trailing '.' is not output, and the first character is uppercased.
 392         (print_help_for_command): Update call to print_doc_line.
 393         (print_doc_of_command): Likewise.
 394         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 395         * cli/cli-option.c (append_indented_doc): Do not append newline.
 396         (build_help_option): Append newline after first appended_indented_doc
 397         only if a second call is done.
 398         (build_help): Append 2 new lines before each option, except the first
 399         one.
 400         * compile/compile.c (_initialize_compile): Add new lines after
 401         %OPTIONS%, when not at the end of the help.
 402         Change help doc or code
 403         producing the help doc to respect the invariants.
 404         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 405         Also removed the new line after 'Options:', as all other commands
 406         do not put an empty line between 'Options:' and the first option.
 407         * printcmd.c (_initialize_printcmd): Likewise.
 408         * stack.c (_initialize_stack): Likewise.
 409         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 410         incorrectly telling COMMAND is optional.
 411         * ada-lang.c (_initialize_ada_language): Change help doc or code
 412         producing the help doc to respect the invariants.
 413         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 414         * breakpoint.c (_initialize_breakpoint): Likewise.
 415         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 416         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 417         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 418         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 419         _initialize_cli_style): Likewise.
 420         * corelow.c (core_target_info): Likewise.
 421         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 422         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 423         * filesystem.c (_initialize_filesystem): Likewise.
 424         * frame.c (_initialize_frame): Likewise.
 425         * gnu-nat.c (add_task_commands): Likewise.
 426         * infcall.c (_initialize_infcall): Likewise.
 427         * infcmd.c (_initialize_infcmd): Likewise.
 428         * interps.c (_initialize_interpreter): Likewise.
 429         * language.c (_initialize_language): Likewise.
 430         * linux-fork.c (_initialize_linux_fork): Likewise.
 431         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 432         * maint.c (_initialize_maint_cmds): Likewise.
 433         * memattr.c (_initialize_mem): Likewise.
 434         * printcmd.c (_initialize_printcmd): Likewise.
 435         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 436         _RegEx): Likewise.
 437         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 438         * record-btrace.c (_initialize_record_btrace): Likewise.
 439         * record-full.c (_initialize_record_full): Likewise.
 440         * record.c (_initialize_record): Likewise.
 441         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 442         * regcache.c (_initialize_regcache): Likewise.
 443         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 444         _initialize_remote): Likewise.
 445         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 446         * serial.c (_initialize_serial): Likewise.
 447         * skip.c (_initialize_step_skip): Likewise.
 448         * source.c (_initialize_source): Likewise.
 449         * stack.c (_initialize_stack): Likewise.
 450         * symfile.c (_initialize_symfile): Likewise.
 451         * symtab.c (_initialize_symtab): Likewise.
 452         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 453         * top.c (init_main): Likewise.
 454         * tracefile-tfile.c (tfile_target_info): Likewise.
 455         * tracepoint.c (_initialize_tracepoint): Likewise.
 456         * tui/tui-win.c (_initialize_tui_win): Likewise.
 457         * utils.c (add_internal_problem_command): Likewise.
 458         * valprint.c (value_print_option_defs): Likewise.
 459
 460 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 461
 462         PR build/24886
 463         * configure.ac: Drop enable-libmcheck support.
 464         * configure, config.in: Rebuild.
 465         * libmcheck.m4: Remove.
 466         * acinclude.m4: Don't include it.
 467         * Makefile.in: Don't distribute it.
 468         * top.c (print_gdb_configuration): Don't mention it.
 469
 470 2019-08-06  Tom Tromey  <tom@tromey.com>
 471
 472         * utils.c (set_output_style): Sometimes pass stream to
 473         emit_style_escape.
 474         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 475         * record-btrace.c (btrace_insn_history): Update.
 476         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 477         method.
 478         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 479         Update initializers.
 480         <m_uiout>: New field.
 481         <m_di>: Move lower.
 482         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 483         Remove "uiout" parameter.
 484         (dump_insns): Update.
 485         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 486         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 487
 488 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 489
 490         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 491         (error_in_psymtab_expansion): Likewise.
 492         (lookup_symbol_via_quick_fns): Likewise.
 493         (basic_lookup_transparent_type_quick): Likewise.
 494         (basic_lookup_transparent_type_1): Likewise.
 495
 496 2019-08-06  Tom Tromey  <tromey@adacore.com>
 497
 498         * source.c (last_source_error): Now bool.
 499         (print_source_lines_base): Make "noprint" bool.  Only open
 500         source file when last_source_visited changes.
 501
 502 2019-08-06  Tom Tromey  <tromey@adacore.com>
 503
 504         * annotate.c (annotate_source_line): Use g_source_cache.
 505         * source-cache.c (source_cache::get_plain_source_lines): Change
 506         parameters.  Populate m_offset_cache.
 507         (source_cache::ensure): New method.
 508         (source_cache::get_line_charpos): New method.
 509         (extract_lines): Move lower.  Change parameters.
 510         (source_cache::get_source_lines): Move lower.
 511         * source-cache.h (class source_cache): Update comment.
 512         <get_line_charpos>: New method.
 513         <get_source_lines>: Update comment.
 514         <clear>: Clear m_offset_cache.
 515         <get_plain_source_lines>: Change parameters.
 516         <ensure>: New method
 517         <m_offset_cache>: New member.
 518         * source.c (forget_cached_source_info_for_objfile): Update.
 519         (info_source_command): Use g_source_cache.
 520         (find_source_lines, open_source_file_with_line_charpos): Remove.
 521         (print_source_lines_base, search_command_helper): Use g_source_cache.
 522         * source.h (open_source_file_with_line_charpos): Don't declare.
 523         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 524         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 525         Use g_source_cache.
 526
 527 2019-08-06  Tom Tromey  <tromey@adacore.com>
 528
 529         * source-cache.c (source_cache::get_plain_source_lines):
 530         Remove "first_line" and "last_line" parameters.
 531         (source_cache::get_source_lines): Cache plain text.
 532         * source-cache.h (class source_cache)
 533         <get_plain_source_lines>: Update.
 534
 535 2019-08-06  Tom Tromey  <tromey@adacore.com>
 536
 537         * source-cache.c (extract_lines): No longer a method.
 538         Changed type of parameter.  Include final newline.
 539         (selftests::extract_lines_test): New function.
 540         (_initialize_source_cache): Likewise.
 541         * source-cache.h (class source_cache)
 542         <extract_lines>: Don't declare.
 543
 544 2019-08-06  Tom Tromey  <tromey@adacore.com>
 545
 546         * breakpoint.c (init_breakpoint_sal): Update.
 547         (breakpoint): Update.
 548         * breakpoint.h (struct breakpoint) <filter>: Now a
 549         unique_xmalloc_ptr.
 550
 551 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 552
 553         * NEWS: Mention dictionary access on blocks.
 554         * python/py-block.c (blpy_getitem): New function.
 555         (block_object_as_mapping): New struct.
 556         (block_object_type): Use new struct for tp_as_mapping field.
 557
 558 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 559
 560         * objfiles.h (objfile): Add a comment describing partial symbols.
 561
 562 2019-08-05  Tom Tromey  <tromey@adacore.com>
 563
 564         * compile/compile.c (_initialize_compile): Use _(), not N_().
 565         * thread.c (_initialize_thread): Use _(), not N_().
 566         * stack.c (_initialize_stack): Use _(), not N_().
 567         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 568
 569 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 570
 571         * dwarf2read.c (struct dw2_symtab_iterator):
 572         <want_specific_block>: Remove.
 573         <block_index>: Change type to gdb::optional.
 574         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 575         change type of BLOCK_INDEX parameter to gdb::optional.
 576         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 577         (dw2_lookup_symbol): Don't pass argument for
 578         WANT_SPECIFIC_BLOCK.
 579         (dw2_expand_symtabs_for_function): Don't pass argument for
 580         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 581         (class dw2_debug_names_iterator)
 582         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 583         parameter, change BLOCK_INDEX type to gdb::optional.
 584         <m_want_specific_block>: Remove.
 585         <m_block_index>: Change type to gdb::optional.
 586         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 587         gdb::optional.  Re-write in function of gdb::optional.
 588         (dw2_debug_names_lookup_symbol): Don't pass argument for
 589         WANT_SPECIFIC_BLOCK.
 590         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 591         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 592         BLOCK_INDEX.
 593
 594 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 595
 596         * NEWS: Mention changes to "info sources" command.
 597
 598 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 599
 600         * symtab.c (filename_partial_match_opts): New struct type.
 601         (struct output_source_filename_data): New members
 602         regexp, c_regexp, partial_match.
 603         (output_source_filename): Use new members to decide to print file.
 604         (info_sources_option_defs): New variable.
 605         (make_info_sources_options_def_group, print_info_sources_header,
 606         info_sources_command_completer):
 607         New functions.
 608         (info_sources_command): Read new optional arguments.
 609         (_initialize_symtab): Update info sources help.
 610
 611 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 612
 613         * ada-lang.c (exception_support_info_v0): Renamed from...
 614         (default_exception_support_info): ... this.  Create new
 615         definition for v1.
 616         (ada_has_this_exception_support): Look up catch_handlers_sym.
 617         (ada_exception_support_info_sniffer): Try v0 after default.
 618
 619 2019-08-01  Tom Tromey  <tromey@adacore.com>
 620
 621         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 622         gdbarch.h.
 623
 624 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 625
 626         * s12z-tdep.c: Fix include path for s12z-opc.h.
 627
 628 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 629
 630         * NEWS: Require GNU make 3.82.
 631
 632 2019-07-16  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 635         declare.
 636
 637 2019-07-30  Tom Tromey  <tromey@adacore.com>
 638
 639         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 640
 641 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 642
 643         * printcmd.c (print_address_symbolic): Print negative offsets.
 644         (build_address_symbolic): Force signed arithmetic when computing
 645         offset.
 646
 647 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 648
 649         PR/24474: Add a function to lookup static variables.
 650         * NEWS: Mention this new function.
 651         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 652         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 653         * python/python.c (python_GdbMethods): Add new function.
 654
 655 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 656
 657         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 658         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 659         (objfpy_lookup_static_symbol): New function.
 660         (objfile_object_methods): Add new functions.
 661
 662 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 663
 664         * NEWS: Mention 'set|show print frame-info'.  Mention new
 665         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 666         backtrace argument.  Mention that python frame filtering code
 667         is now consistent with what 'backtrace' command prints.
 668
 669 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 670
 671         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 672         comments.
 673         (print_frame_info_auto, print_frame_info_source_line,
 674         print_frame_info_location, print_frame_info_source_and_location,
 675         print_frame_info_location_and_address, print_frame_info_short_location):
 676         New declarations.
 677         (struct frame_print_options): New member print_frame_info.
 678         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 679         * stack.h (get_user_print_what_frame_info): New declaration.
 680         (frame_show_address): New declaration.
 681         * stack.c (print_frame_arguments_choices): New value 'presence'.
 682         (print_frame_info_auto, print_frame_info_source_line,
 683         print_frame_info_location, print_frame_info_source_and_location,
 684         print_frame_info_location_and_address, print_frame_info_short_location,
 685         print_frame_info_choices, print_frame_info_print_what): New definitions.
 686         (print_frame_args): Only print dots for args if print frame-arguments
 687         is 'presence'.
 688         (frame_print_option_defs): New element for "frame-info".
 689         (get_user_print_what_frame_info): New function.
 690         (frame_show_address): Make non static.  Move comment to stack.h.
 691         (print_frame_info_to_print_what): New function.
 692         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 693         to decide what to print.
 694         (backtrace_command_1): Handle the new print_frame_arguments_presence
 695         value.
 696         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 697         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 698         (py_print_frame): In non-mi mode, use LOCATION as default for
 699         print_what, similarly to frame information printed directly by
 700         backtrace command. Handle frame-info user option in non MI mode.
 701
 702 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 703
 704         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 705         Add case for debugging 32-bit target on 64-bit host.  Revise
 706         comment.
 707
 708 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 709
 710         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 711         instead of find_function_entry_range_from_pc.
 712
 713 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 714
 715         * stack.c (find_frame_funname): Remove code which preferred
 716         minsym over symtab sym in "certain pathological cases".
 717
 718         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 719         parameter.  Change type of "do_demangle" to bool.
 720         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 721         Pass suitable "prefer_sym_over_minsym" flag to
 722         build_address_symbolic().  Don't output "+" for negative offsets.
 723         * printcmd.c (print_address_symbolic): Update invocation of
 724         build_address_symbolic to include a "prefer_sym_over_minsym"
 725         flag.
 726         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 727         Restrict cases in which use of minimal symbol is preferred to that
 728         of a found symbol.  Update comments.
 729
 730         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 731         for entry pc when entry pc is out of range for that FDE.
 732
 733 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 734
 735         PR gdb/24839:
 736         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 737         type.
 738
 739 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 740
 741         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 742         this function's Python signature.
 743
 744
 745 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 746
 747         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 748         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 749         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 750         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 751         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 752
 753
 754 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 755
 756         * h8300-tdep.c (h8300_register_name_common): New.
 757         h8300_register_name): Use h8300_register_name_common.
 758         (h8300s_register_name): Likewise.
 759         (h8300sx_register_name): Likewise.
 760         (h8300h_register_nam): New.
 761         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 762
 763
 764 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 765
 766         * arm-tdep.c (arm_skip_cmse_entry): New function.
 767         (arm_is_sgstubs_section): New function.
 768         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 769
 770 2019-07-22  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 773         Don't self-assign.
 774
 775 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 776
 777         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 778         type_print.
 779
 780 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 783         so that GDB doesn't match any msymbols when searching in the
 784         TYPES_DOMAIN.
 785         (print_symbol_info): Print using typedef_print or type_print based
 786         on the type of the symbol.  Add updated FIXME comment moved from...
 787         (_initialize_symtab): ... move and update FIXME comment to above.
 788
 789 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * NEWS: Mention adding -q option to "info types".
 792         * symtab.c (struct info_types_options): New struct.
 793         (info_types_options_defs): New variable.
 794         (make_info_types_options_def_group): New function.
 795         (info_types_command): Use gdb::option framework to parse options.
 796         (info_types_command_completer): New function.
 797         (_initialize_symtab): Extend the help text on "info types" and
 798         register command completer.
 799
 800 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 801
 802         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 803         (lookup_symbol_in_objfile): Change int to block_enum and add a
 804         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 805
 806 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 807
 808         * MAINTAINERS (Write After Approval): Add self.
 809
 810 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 813         instruction to the dummy code region.
 814
 815 2019-07-19  Tom Tromey  <tromey@adacore.com>
 816
 817         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 818         (ARGSUSED, PARAMS, __func__): Remove rules.
 819
 820 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 821
 822         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 823         * features/arm/arm-with-iwmmxt.c: Remove.
 824         * features/arm/arm-with-iwmmxt.xml: Remove.
 825         * features/arm/arm-with-m-fpa-layout.c: Remove.
 826         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 827         * features/arm/arm-with-m-vfp-d16.c: Remove.
 828         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 829         * features/arm/arm-with-m.c: Remove.
 830         * features/arm/arm-with-m.xml: Remove.
 831         * features/arm/arm-with-neon.c: Remove.
 832         * features/arm/arm-with-neon.xml: Remove.
 833         * features/arm/arm-with-vfpv2.c: Remove.
 834         * features/arm/arm-with-vfpv2.xml: Remove.
 835         * features/arm/arm-with-vfpv3.c: Remove.
 836         * features/arm/arm-with-vfpv3.xml: Remove.
 837
 838 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 839
 840         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 841
 842 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 843
 844         * arch/aarch32.c (aarch32_create_target_description): Create
 845         target descriptions using features.
 846         * arch/arm.c (arm_create_target_description)
 847         (arm_create_mprofile_target_description): Likewise.
 848         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 849
 850 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 851
 852         * Makefile.in: Add new files.
 853         * aarch32-tdep.c: New file.
 854         * aarch32-tdep.h: New file.
 855         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 856         Call aarch32_read_description.
 857         * arch/aarch32.c: New file.
 858         * arch/aarch32.h: New file.
 859         * arch/arm.c (arm_create_target_description)
 860         (arm_create_mprofile_target_description): New function.
 861         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 862         (arm_create_target_description)
 863         (arm_create_mprofile_target_description): New declaration.
 864         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 865         read_description functions.
 866         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 867         Likewise.
 868         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 869         * arm-tdep.c (tdesc_arm_list): New variable.
 870         (arm_register_g_packet_guesses): Call create description functions.
 871         (arm_read_description) (arm_read_mprofile_description): New
 872         function.
 873         * arm-tdep.h (arm_read_description)
 874         (arm_read_mprofile_description): Add declaration.
 875         * configure.tgt: Add new files.
 876
 877 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 878
 879         * top.c (new_ui_command): Open specified terminal just once.
 880
 881 2019-07-18  Tom Tromey  <tromey@adacore.com>
 882
 883         * symtab.c (main_name): Constify return type.
 884         * symfile.c (set_initial_language): Update.
 885         * symtab.h (main_name): Constify return type.
 886
 887 2019-07-17  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-winsource.c (tui_update_source_window)
 890         (tui_update_source_window_as_is)
 891         (tui_update_source_windows_with_line): Remove return.
 892         * tui/tui-disasm.c (tui_show_disassem)
 893         (tui_show_disassem_and_update_source): Remove return.
 894         * tui/tui.c (tui_reset): Remove return.
 895         * tui/tui-wingeneral.c
 896         (tui_check_and_display_highlight_if_needed): Remove return.
 897
 898 2019-07-17  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 901
 902 2019-07-17  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-winsource.h (struct tui_exec_info_window)
 905         (struct tui_source_window_base): Move from tui-data.h.
 906         * tui/tui-winsource.c: Move many method definitions from
 907         elsewhere.  Remove "structuring" comments.
 908         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 909         (tui_source_window_base::refresh_window): Move to
 910         tui-winsource.c.
 911         * tui/tui-win.c (tui_source_window_base::refresh_all)
 912         (tui_source_window_base::update_tab_width)
 913         (tui_source_window_base::set_new_height)
 914         (tui_source_window_base::do_make_visible_with_new_height): Move to
 915         tui-winsource.c.
 916         * tui/tui-source.h: Update.
 917         * tui/tui-source.c (tui_source_window_base::reset): Move to
 918         tui-winsource.c.
 919         * tui/tui-disasm.h: Update.
 920         * tui/tui-data.h (struct tui_exec_info_window): Move to
 921         tui-winsource.h.
 922         (struct tui_source_window_base): Likewise.
 923         * tui/tui-data.c (tui_source_window_base::clear_detail)
 924         (tui_source_window_base, ~tui_source_window_base): Move to
 925         tui-winsource.c.
 926
 927 2019-07-17  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-win.c (tui_resize_all)
 930         (tui_source_window_base::update_tab_width)
 931         (tui_adjust_win_heights): Update.
 932         (tui_win_info::make_invisible_and_set_new_height): Rename from
 933         make_invisible_and_set_new_height.
 934         * tui/tui-data.h (struct tui_win_info)
 935         <make_invisible_and_set_new_height>: New method.
 936
 937 2019-07-17  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui.c: Update.
 940         * tui/tui-source.h (struct tui_source_window): Move from
 941         tui-data.h.
 942         * tui/tui-layout.c: Update.
 943         * tui/tui-disasm.c: Update.
 944         * tui/tui-data.h (struct tui_source_window): Move to
 945         tui-source.h.
 946
 947 2019-07-17  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 950         tui-data.h.
 951         * tui/tui-data.h (struct tui_disasm_window): Move to
 952         tui-disasm.h.
 953
 954 2019-07-17  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-regs.h (struct tui_data_item_window): Move from
 957         tui-data.h.
 958         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 959         * tui/tui-data.h (struct tui_data_item_window): Move to
 960         tui-regs.h.
 961         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 962
 963 2019-07-17  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui.c: Update.
 966         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 967         (tui_cmd_window::max_height): Move to tui-command.c.
 968         * tui/tui-layout.c: Update.
 969         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 970         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 971         tui-command.c.
 972         * tui/tui-command.h (struct tui_cmd_window): Move from
 973         tui-data.h.
 974         * tui/tui-command.c: Remove "structuring" comments.
 975         (tui_cmd_window::clear_detail)
 976         (tui_cmd_window::do_make_visible_with_new_height)
 977         (tui_cmd_window::max_height): Move from elsewhere.
 978
 979 2019-07-17  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 982         Now static.
 983         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 984         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 985
 986 2019-07-17  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui.c: Update.
 989         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 990         tui-regs.c.
 991         * tui/tui-windata.h: Remove file.
 992         * tui/tui-windata.c: Remove file.
 993         * tui/tui-win.c (tui_data_window::set_new_height)
 994         (tui_data_window::do_make_visible_with_new_height): Move to
 995         tui-regs.c.
 996         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 997         * tui/tui-regs.c: Remove "structuring" comments.
 998         (tui_data_window::first_data_item_displayed)
 999         (tui_data_window::delete_data_content_windows)
1000         (tui_data_window::erase_data_content)
1001         (tui_data_window::display_all_data)
1002         (tui_data_window::refresh_all)
1003         (tui_data_window::do_scroll_vertical)
1004         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1005         (tui_data_window::do_make_visible_with_new_height)
1006         (tui_data_window::refresh_window): Move from elsewhere.
1007         (_initialize_tui_regs): Move to end of file.
1008         * tui/tui-layout.c: Update.
1009         * tui/tui-hooks.c: Update.
1010         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1011         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1012         tui-regs.c.
1013         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1014
1015 2019-07-17  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1018         seen.
1019
1020 2019-07-17  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-win.c (tui_source_window_base::set_new_height)
1023         (tui_source_window_base::do_make_visible_with_new_height): Use
1024         m_has_locator field directly.
1025         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1026         method.
1027         (struct tui_source_window_base) <has_locator>: Likewise.
1028
1029 2019-07-17  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1032         Don't declare.
1033         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1034         Remove.
1035         * tui/tui-win.c (tui_source_window_base::set_new_height)
1036         (tui_source_window_base::set_new_height)
1037         (make_invisible_and_set_new_height)
1038         (tui_source_window_base::do_make_visible_with_new_height)
1039         (tui_source_window_base::do_make_visible_with_new_height):
1040         Update.
1041         * tui/tui-layout.c (show_source_disasm_command, show_data)
1042         (show_source_or_disasm_and_command): Update.
1043         * tui/tui-layout.c (show_layout): Update.
1044
1045 2019-07-17  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-layout.c (make_data_window): Remove.
1048         (show_data): Unify creation and re-initialization cases.
1049
1050 2019-07-17  Tom Tromey  <tom@tromey.com>
1051
1052         * tui/tui-layout.c (make_source_window, make_disasm_window):
1053         Remove.
1054         (show_data): Unify creation and re-initialization cases.
1055
1056 2019-07-17  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-layout.c (make_command_window): Remove.
1059         (show_source_disasm_command, show_source_or_disasm_and_command):
1060         Unify creation and re-initialization cases.
1061
1062 2019-07-17  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1065         creation and re-initialization cases.
1066
1067 2019-07-17  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-regs.c (tui_get_register): Return void.
1070
1071 2019-07-17  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1074         Simplify.
1075
1076 2019-07-17  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1079         resetting.
1080
1081 2019-07-17  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1084         * tui/tui-regs.c (tui_reg_layout): New function.
1085         (tui_show_registers, tui_reg_command): Use it.
1086         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1087         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1088         parameters.
1089         (tui_layout_command): Remove.
1090
1091 2019-07-17  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-layout.h (tui/tui-layout): Return void.
1094         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1095
1096 2019-07-17  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-layout.c (show_source_disasm_command, show_data):
1099         Update.
1100         (reset_locator): Remove.
1101         (show_source_or_disasm_and_command): Update.
1102
1103 2019-07-17  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-source.c (tui_source_window_base::reset): Remove
1106         win_type parameter.
1107         * tui/tui-layout.c (make_command_window, make_source_window)
1108         (make_disasm_window, make_data_window)
1109         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1110         (reset_locator, show_source_or_disasm_and_command): Update.
1111         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1112         win_type parameter.
1113         (struct tui_source_window_base) <reset>: Likewise.
1114
1115 2019-07-17  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-layout.c (show_source_disasm_command): Use
1118         reset_locator.
1119         (reset_locator): New function.
1120         (init_and_make_win): Remove.
1121         (show_source_or_disasm_and_command): Use reset_locator.
1122
1123 2019-07-17  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1126         condition.
1127         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1128         Remove condition.
1129         * tui/tui-source.c (tui_source_window_base::reset): New method.
1130         * tui/tui-layout.c (make_command_window): Don't call
1131         init_and_make_win.
1132         (make_source_window, make_disasm_window): Don't call
1133         make_source_or_disasm_window.
1134         (make_data_window): Don't call init_and_make_win.  Change calling
1135         convention.
1136         (show_source_disasm_command, show_data): Simplify.
1137         (make_source_or_disasm_window): Remove.
1138         (show_source_or_disasm_and_command): Simplify.
1139         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1140         (struct tui_source_window_base) <reset>: Likewise.
1141         <execution_info>: Remove initializer.
1142         * tui/tui-data.c (tui_source_window_base): Initialize
1143         execution_info.
1144
1145 2019-07-17  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1148         variable.
1149
1150 2019-07-17  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui.c (tui_rl_other_window): Update.
1153         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1154         superclass method first.  Always iterate over regs_content.
1155         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1156         method.
1157         * tui/tui-win.c (tui_set_focus_command): Update.
1158
1159 2019-07-17  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui-win.c (tui_set_focus_command): Rename from
1162         tui_set_focus.  Call tui_enable.
1163         (tui_set_focus_command): Remove.
1164
1165 2019-07-17  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1168         refresh_window.
1169         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1170         touchwin.
1171         (tui_data_window::refresh_window): Call refresh_window on data
1172         items.  Always call superclass refresh_window.
1173         (tui_win_info::refresh): Remove.
1174         (tui_source_window_base::refresh_window): Update.
1175         (tui_refresh_all): Update.
1176         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1177         refresh_window.
1178         (show_source_or_disasm_and_command): Likewise.
1179         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1180         (struct tui_source_window_base) <refresh>: Likewise.
1181
1182 2019-07-17  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-winsource.c (tui_clear_source_content)
1185         (tui_show_source_content): Update.
1186         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1187         whether content is empty.
1188         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1189         Remove.
1190
1191 2019-07-17  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1194         window's contents.
1195         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1196         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1197
1198 2019-07-17  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1201         (struct tui_data_item_window): Update.
1202
1203 2019-07-17  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1206         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1207         defines.
1208
1209 2019-07-17  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-winsource.h (tui_erase_source_content)
1212         (tui_clear_source_content): Remove "display_prompt" parameter.
1213         * tui/tui-winsource.c (tui_update_source_window_as_is)
1214         (tui_update_source_windows_with_addr): Update.
1215         (tui_clear_source_content): Remove "display_prompt" parameter.
1216         (tui_erase_source_content): Likewise.  Simplify.
1217         (tui_show_source_content): Update.
1218         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1219         * tui/tui-stack.c (tui_show_frame_info): Update.
1220         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1221         Remove defines.
1222
1223 2019-07-17  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1226         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1227         parameter.
1228         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1229         parameter.
1230
1231 2019-07-17  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-winsource.c (tui_clear_source_content)
1234         (tui_show_source_content, tui_show_exec_info_content)
1235         (tui_clear_exec_info_content): Update.
1236         * tui/tui-stack.c (tui_show_locator_content): Update.
1237         (tui_show_frame_info): Update.
1238         * tui/tui-source.h (tui_source_window): Don't declare.
1239         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1240         from tui_source_is_displayed.
1241         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1242         Remove field.
1243         (struct tui_source_window_base) <content_in_use>: New field.  Now
1244         bool.
1245         (struct tui_source_window) <showing_source_p>: New method.
1246         (TUI_SRC_WIN): Change cast.
1247         * tui/tui-data.c (tui_initialize_static_data): Update.
1248
1249 2019-07-17  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1252         location_matches_p.
1253         * tui/tui-source.c (tui_source_window::location_matches_p): New
1254         method.
1255         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1256         method.
1257         * tui/tui-data.h (struct tui_source_window_base)
1258         <location_matches_p>: New method.
1259         (struct tui_source_window, struct tui_disasm_window)
1260         <location_matches_p>: Likewise.
1261
1262 2019-07-17  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-win.c (tui_set_win_height_command): Rename from
1265         tui_set_win_height.
1266         (tui_set_win_height_command): Remove.
1267
1268 2019-07-17  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-source.c (tui_source_window): New constructor.  Add
1271         observer.
1272         (~tui_source_window): New destructor.
1273         (tui_source_window::style_changed): New method.
1274         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1275         (tui_attach_detach_observers): Update.
1276         * tui/tui-data.h (struct tui_source_window): Make constructor not
1277         inline.  Add destructor.
1278         (struct tui_source_window) <style_changed>: New method.
1279         <m_observable>: New member.
1280
1281 2019-07-17  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1284         * tui/tui-win.c (tui_resize_all): Fix typo.
1285
1286 2019-07-17  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1289         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1290         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1291         * tui/tui-win.c (window_name_completer): Use foreach.
1292         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1293         (update_tab_width): Likewise.
1294         * tui/tui-layout.c (show_layout): Update.
1295         * tui/tui-data.h (class tui_window_iterator): New.
1296         (struct all_tui_windows): New.
1297         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1298
1299 2019-07-17  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1302         parameter.  Don't reference globals.
1303         (tui_reg_command): Update.
1304
1305 2019-07-17  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-regs.c (tui_show_registers): Simplify.
1308
1309 2019-07-17  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-regs.c (tui_show_registers): Update.
1312         (tui_show_register_group): Add win_info parameter.
1313
1314 2019-07-17  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1317         Rename from tui_display_reg_element_at_line.
1318         (tui_data_window::display_registers_from_line): Update.
1319         * tui/tui-data.h (struct tui_data_window)
1320         <display_reg_element_at_line>: New method.
1321
1322 2019-07-17  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-regs.h (tui_display_registers_from)
1325         (tui_display_registers_from_line): Don't declare.
1326         * tui/tui-windata.c (tui_data_window::display_all_data)
1327         (tui_data_window::refresh_all)
1328         (tui_data_window::do_scroll_vertical): Update.
1329         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1330         from tui_display_registers_from.
1331         (tui_display_reg_element_at_line): Update.
1332         (tui_data_window::display_registers_from_line): Rename from
1333         tui_display_registers_from_line.
1334         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1335         display_registers_from_line>: New methods.
1336
1337 2019-07-17  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1340         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1341         from tui_erase_data_content.
1342         (tui_data_window::display_all_data)
1343         (tui_data_window::refresh_all)
1344         (tui_data_window::do_scroll_vertical): Update.
1345         * tui/tui-regs.c (tui_show_registers): Update.
1346         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1347         New method.
1348
1349 2019-07-17  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1352         declare.
1353         * tui/tui-windata.c
1354         (tui_data_window::delete_data_content_windows): Rename from
1355         tui_delete_data_content_windows.
1356         (tui_data_window::display_all_data)
1357         (tui_data_window::do_scroll_vertical): Update.
1358         * tui/tui-data.h (struct tui_data_window)
1359         <delete_data_content_windows>: New method.
1360
1361 2019-07-17  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1364         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1365
1366 2019-07-17  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1369         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1370         from tui_display_all_data.
1371         * tui/tui-win.c
1372         (tui_data_window::do_make_visible_with_new_height): Update.
1373         * tui/tui-regs.c (tui_show_registers): Update.
1374         * tui/tui-layout.c (tui_set_layout): Update.
1375         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1376         method.
1377
1378 2019-07-17  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1381         * tui/tui-windata.c (tui_display_data_from): Remove.
1382         (tui_data_window::refresh_all): Update.
1383
1384 2019-07-17  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1387         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1388         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1389         tui_display_registers_from_line.
1390         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1391         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1392         "force_display" parameter.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1397         declare.
1398         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1399         Rename from tui_first_reg_element_no_inline.
1400         (tui_display_reg_element_at_line)
1401         (tui_display_registers_from_line): Update.
1402         * tui/tui-data.h (struct tui_data_window)
1403         <first_reg_element_no_inline>: New method.
1404
1405 2019-07-17  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-windata.c (tui_display_data_from)
1408         (tui_data_window::do_scroll_vertical): Update.
1409         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1410         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1411         Rename from tui_line_from_reg_element_no.
1412         (tui_display_registers_from_line): Update.
1413         * tui/tui-data.h (struct tui_data_window)
1414         <line_from_reg_element_no>: New method.
1415
1416 2019-07-17  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1419         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1420         tui_last_regs_line_no.
1421         (tui_display_reg_element_at_line)
1422         (tui_display_registers_from_line): Update.
1423         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1424         method.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         PR tui/24722:
1429         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1430         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1431         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1432         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1433         (tui_update_breakpoint_info): Likewise.
1434         * tui/tui-hooks.c (tui_event_create_breakpoint)
1435         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1436         Update.
1437
1438 2019-07-17  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1441
1442 2019-07-17  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-winsource.c (tui_update_source_window_as_is)
1445         (tui_update_source_windows_with_addr): Update.
1446         * tui/tui-source.h (tui_set_source_content)
1447         (tui_show_symtab_source): Add "win_info" parameter.
1448         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1449         parameter.
1450         (tui_show_symtab_source): Likewise.
1451
1452 2019-07-17  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-wingeneral.c
1455         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1456
1457 2019-07-17  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1460         (struct tui_cmd_window) <can_scroll>: New method.
1461         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1462         method.
1463
1464 2019-07-17  Tom Tromey  <tromey@adacore.com>
1465
1466         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1467         do_field_signed>: Rename.  Change type of "value".
1468         * ui-out.c (ui_out::field_signed): Rename from field_int.
1469         Change type of "value".
1470         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1471         type of "value".
1472         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1473         do_field_int.  Change type of "value".
1474         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1475         do_field_int.  Change type of "value".
1476         * tracepoint.c (trace_status_mi, tfind_1)
1477         (print_one_static_tracepoint_marker): Update.
1478         * thread.c (print_thread_info_1, print_selected_thread_frame):
1479         Update.
1480         * stack.c (print_frame, print_frame_info): Update.
1481         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1482         Update.
1483         * source.c (print_source_lines_base): Update.
1484         * skip.c (info_skip_command): Update.
1485         * record-btrace.c (btrace_ui_out_decode_error)
1486         (btrace_call_history_src_line): Update.
1487         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1488         Update.
1489         * progspace.c (print_program_space): Update.
1490         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1491         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1492         do_field_int.  Change type of "value".
1493         * mi/mi-out.c (mi_ui_out::do_table_begin)
1494         (mi_ui_out::do_table_header): Update.
1495         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1496         type of "value".
1497         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1498         (mi_cmd_data_list_changed_registers, output_register)
1499         (mi_cmd_data_read_memory, mi_load_progress)
1500         (mi_cmd_trace_frame_collected): Update.
1501         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1502         Update.
1503         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1504         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1505         (mi_cmd_var_list_children, varobj_update_one): Update.
1506         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1507         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1508         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1509         * inferior.c (print_inferior): Update.
1510         * gdb_bfd.c (print_one_bfd): Update.
1511         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1512         Update.
1513         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1514         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1515         do_field_int.  Change type of "value".
1516         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1517         do_field_int.  Change type of "value".
1518         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1519         (print_one_breakpoint_location, print_it_catch_fork)
1520         (print_one_catch_fork, print_it_catch_vfork)
1521         (print_one_catch_vfork, print_it_catch_solib)
1522         (print_it_catch_exec, print_it_ranged_breakpoint)
1523         (print_mention_watchpoint, print_mention_masked_watchpoint)
1524         (bkpt_print_it, update_static_tracepoint): Update.
1525         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1526         * break-catch-syscall.c (print_it_catch_syscall): Update.
1527         * ada-tasks.c (print_ada_task_info): Update.
1528         * ada-lang.c (print_it_exception, print_mention_exception):
1529         Update.
1530
1531 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1532
1533         PR breakpoints/24541
1534         * gdbarch.c: Regenerate.
1535         * gdbarch.h: Regenerate.
1536         * gdbarch.sh: Adjust return type and parameter types for
1537         'stap_adjust_register'.
1538         (i386_stap_adjust_register): Adjust signature and return new
1539         register name.
1540         * stap-probe.c (stap_parse_register_operand): Adjust use of
1541         'gdbarch_stap_adjust_register'.
1542
1543 2019-07-17  Tom Tromey  <tromey@adacore.com>
1544
1545         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1546         declare VEC.
1547         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1548         std::vector.
1549         (struct s390_process_info): Add initializers.
1550         (s390_add_process): Use new.
1551         (s390_linux_nat_target::low_forget_process): Use delete.
1552         (s390_linux_nat_target::low_new_fork)
1553         (s390_linux_nat_target::stopped_by_watchpoint)
1554         (s390_linux_nat_target::low_prepare_to_resume)
1555         (s390_linux_nat_target::insert_watchpoint)
1556         (s390_linux_nat_target::insert_hw_breakpoint)
1557         (s390_linux_nat_target::remove_watchpoint)
1558         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1559
1560 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1561
1562         * aarch64-fbsd-nat.c: Include regcache.h.
1563         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1564         argument.
1565         (aarch64_fbsd_nat_target::fetch_registers)
1566         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1567         variable.
1568         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1569
1570 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1571
1572         * fbsd-nat.c: Include gdbarch.h.
1573
1574 2019-07-15  Tom Tromey  <tromey@adacore.com>
1575
1576         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1577
1578 2019-07-15  Tom Tromey  <tromey@adacore.com>
1579
1580         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1581         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1582         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1583         * cli-out.c (cli_ui_out::do_field_int): New method.
1584         * ui-out.c (ui_out::field_unsigned): New method.
1585         * symfile.c (generic_load): Use field_unsigned.
1586         (print_transfer_performance): Likewise.
1587         * record-btrace.c (ui_out_field_uint): Remove.
1588         (btrace_call_history_insn_range, btrace_call_history): Use
1589         field_unsigned.
1590         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1591         field_unsigned.
1592         * ui-out.h (class ui_out) <field_unsigned>: New method.
1593         <do_field_unsigned>: Likewise.
1594
1595 2019-07-15  Tom Tromey  <tromey@adacore.com>
1596
1597         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1598         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1599         * target.c (flash_erase_command): Use field_string.
1600         * infrun.c (print_signal_received_reason): Use field_string.
1601         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1602         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1603         field_string.
1604         * ada-tasks.c (print_ada_task_info): Use field_string.
1605
1606 2019-07-15  Tom Tromey  <tromey@adacore.com>
1607
1608         * target.c (flash_erase_command): Use field_core_addr.
1609         * symfile.c (generic_load): Use field_core_addr.
1610         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1611         Use field_core_addr.
1612         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1613         field_core_addr.
1614
1615 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1618         value if its desired type is smaller than a CORE_ADDR and signed.
1619
1620 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1621
1622         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1623         of changes to field names, and use new is_reference field to
1624         decide if a property is a reference or not.
1625         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1626         field.
1627         (struct dwarf2_property_baton): Update header comment, rename
1628         'referenced_type' to 'property_type' and update comments.
1629         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1630         default property type, store in property baton, update to take
1631         accound of renamed field.
1632         (read_func_scope): Update call to attr_to_dynamic_prop.
1633         (read_array_type): Likewise.
1634         (dwarf2_per_cu_addr_sized_int_type): New function.
1635         (read_subrange_index_type): Move type finding code to
1636         dwarf2_per_cu_addr_sized_int_type.
1637         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1638         (dwarf2_per_cu_addr_type): New function.
1639         (set_die_type): Update calls to attr_to_dynamic_prop.
1640
1641 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * dwarf2read.c (read_subrange_index_type): New function.
1644         (read_subrange_type): Move code into new function and call it.
1645         * gdbtypes.c (create_range_type): Add some asserts.
1646
1647 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1650         update return statements.
1651         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1652         declaration, and update comment to match.
1653         * gdbtypes.c (resolve_dynamic_array): Update call to
1654         dwarf2_evaluate_property to match new return type.
1655
1656 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1657
1658         * valarith.c (value_subscripted_rvalue): Change lowerbound
1659         parameter type from int to LONGEST.
1660         * value.h (value_subscripted_rvalue): Likewise in declaration.
1661
1662 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * cli/cli-utils.c (info_print_command_completer): New function.
1665         * cli/cli-utils.h: Add 'completer.h' include, and forward
1666         declaration for 'struct cmd_list_element'.
1667         (info_print_command_completer): Declare.
1668         * stack.c (_initialize_stack): Add completer for 'info locals' and
1669         'info args'.
1670         * symtab.c (_initialize_symtab): Add completer for 'info
1671         variables' and 'info functions'.
1672         * NEWS: Mention completion for additional info commands.
1673
1674 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * cli/cli-utils.c (extract_info_print_args): Delete.
1677         (extract_arg_maybe_quoted): Delete.
1678         (info_print_options_defs): New variable.
1679         (make_info_print_options_def_group): New function.
1680         (extract_info_print_options): Define new function.
1681         * cli/cli-utils.h (extract_info_print_args): Delete.
1682         (struct info_print_options): New structure.
1683         (extract_info_print_options): Declare new function.
1684         * stack.c (info_locals_command): Update to use new
1685         extract_info_print_options, also add a header comment.
1686         (info_args_command): Likewise.
1687         * symtab.c (info_variables_command): Likewise.
1688         (info_functions_command): Likewise.
1689
1690 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1691
1692         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1693         to extract string arguments.
1694         * common/common-utils.c (extract_string_maybe_quoted): New function.
1695         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1696
1697 2019-07-11  Tom Tromey  <tromey@adacore.com>
1698
1699         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1700         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1701         * top.h (gdbinit): Don't declare.
1702         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1703         into...
1704         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1705         * top.c (gdb_init): Don't call init_cli_cmds.
1706         (gdbinit): Remove.
1707         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1708
1709 2019-07-11  Tom Tromey  <tromey@adacore.com>
1710
1711         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1712         after it has been moved.
1713
1714 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1715
1716         * valops.c (value_must_coerce_to_target): Change return type to
1717         bool.
1718         * value.h (value_must_coerce_to_target): Likewise.
1719
1720 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1721
1722         * breakpoint.c (is_hardware_watchpoint): Remove
1723         forward-declaration.
1724         (is_masked_watchpoint): Change return type to bool.
1725         (is_tracepoint): Likewise.
1726         (is_breakpoint): Likewise.
1727         (is_hardware_watchpoint): Likewise.
1728         (is_watchpoint): Likewise.
1729         (is_no_memory_software_watchpoint): Likewise.
1730         (is_catchpoint): Likewise.
1731         (breakpoint_1): Make FILTER parameter's return type bool.
1732         is_masked_watchpoint): Change return type to bool.
1733         (save_breakpoints): Make FILTER parameter's return type bool.
1734         * breakpoint.h (is_breakpoint): Change return type to bool.
1735         (is_watchpoint): Likewise.
1736         (is_catchpoint): Likewise.
1737         (is_tracepoint): Likewise.
1738
1739 2019-07-10  Tom Tromey  <tom@tromey.com>
1740
1741         * defs.h: Don't include gdbarch.h.
1742         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1743         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1744         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1745         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1746         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1747         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1748         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1749         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1750         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1751         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1752         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1753         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1754         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1755         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1756         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1757         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1758         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1759         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1760         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1761         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1762         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1763         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1764         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1765         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1766         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1767         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1768         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1769
1770 2019-07-10  Tom Tromey  <tromey@adacore.com>
1771
1772         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1773         * breakpoint.c (init_ada_exception_breakpoint): Register as
1774         bp_catchpoint.
1775         (print_one_breakpoint_location, print_one_breakpoint): Use
1776         is_ada_exception_catchpoint.
1777         * ada-lang.c (class ada_catchpoint_location): Pass
1778         bp_loc_software_breakpoint to bp_location constructor.
1779         (is_ada_exception_catchpoint): New function.
1780
1781 2019-07-10  Tom Tromey  <tromey@adacore.com>
1782
1783         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1784         VEC.
1785         (struct arm_exidx_entry): New method operator<.
1786         (struct arm_exidx_data) <section_maps>: Change type.
1787         (arm_exidx_data_free): Remove.
1788         (arm_exidx_data_key): Change type.  Move lower.
1789         (arm_exidx_new_objfile): Update.
1790         (arm_compare_exidx_entries): Remove.
1791         (arm_find_exidx_entry, _initialize_arm_tdep)
1792
1793 2019-07-10  Tom Tromey  <tromey@adacore.com>
1794
1795         * solib-spu.c (ocl_program_data_key): Change type.
1796         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1797         Update.
1798
1799 2019-07-10  Tom Tromey  <tromey@adacore.com>
1800
1801         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1802         (struct solib_aix_inferior_data) <library_list>: Change type.
1803         (solib_aix_inferior_data_handle): Change type.
1804         (get_solib_aix_inferior_data): Update.
1805         (solib_aix_free_library_list): Remove.
1806         (library_list_start_library): Update.
1807         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1808         return type.
1809         (solib_aix_get_library_list)
1810         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1811         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1812
1813 2019-07-10  Tom Tromey  <tromey@adacore.com>
1814
1815         * solib-dsbt.c (struct dsbt_info): Add initializers.
1816         (solib_dsbt_pspace_data): Change type.
1817         (dsbt_pspace_data_cleanup): Remove.
1818         (get_dsbt_info, _initialize_dsbt_solib): Update.
1819
1820 2019-07-10  Tom Tromey  <tromey@adacore.com>
1821
1822         * spu-tdep.c (spu_overlay_data): Change type.
1823         (spu_get_overlay_table, spu_overlay_new_objfile)
1824         (_initialize_spu_tdep): Update.
1825
1826 2019-07-10  Tom Tromey  <tromey@adacore.com>
1827
1828         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1829         destructor.
1830         (dbx_objfile_data_key): Change type and declare later.
1831         (DBX_SYMFILE_INFO): Rewrite.
1832         * dbxread.c (dbx_objfile_data_key): Change type.
1833         (dbx_symfile_init): Update.
1834         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1835         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1836         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1837
1838 2019-07-10  Tom Tromey  <tromey@adacore.com>
1839
1840         * jit.c (jit_program_space_key): Change type.  Move lower.
1841         (get_jit_program_space_data): Update.
1842         (jit_program_space_data_cleanup): Remove.
1843         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1844         Update.
1845         (struct jit_program_space_data): Add initializers.
1846
1847 2019-07-10  Tom Tromey  <tromey@adacore.com>
1848
1849         * solib-darwin.c (struct darwin_info): Add initializers.
1850         (solib_darwin_pspace_data): Change type.
1851         (darwin_pspace_data_cleanup): Remove.
1852         (get_darwin_info, _initialize_darwin_solib): Update.
1853
1854 2019-07-10  Tom Tromey  <tromey@adacore.com>
1855
1856         * remote-sim.c (struct sim_inferior_data): Add initializers,
1857         constructor, and destructor.
1858         (sim_inferior_data_key): Change type.  Move lower.
1859         (check_for_duplicate_sim_descriptor): Update.
1860         (get_sim_inferior_data): Use new.  Update.
1861         (~sim_inferior_data_cleanup): Rename from
1862         sim_inferior_data_cleanup.  Simplify.
1863         (gdbsim_close_inferior, simulator_command)
1864         (sim_command_completer, _initialize_remote_sim): Update.
1865         (next_pid, INITIAL_PID): Move earlier.
1866
1867 2019-07-10  Tom Tromey  <tromey@adacore.com>
1868
1869         * python/python-internal.h (create_thread_object): Return
1870         gdbpy_ref.
1871         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1872         * python/py-inferior.c (struct threadlist_entry): Add
1873         constructor.
1874         <thread_obj>: Now a gdbpy_ref.
1875         (thread_to_thread_object): Update.
1876         (add_thread_object): Use new.
1877         (delete_thread_object): Use delete.
1878         (infpy_threads): Update.
1879         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1880         GIL.
1881
1882 2019-07-10  Tom Tromey  <tromey@adacore.com>
1883
1884         * valops.c (value_cast): Specialize error message for Ada.
1885
1886 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1887
1888         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1889
1890 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1891
1892         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1893         bpstat_should_step): Return bool, adjust comments.
1894         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1895         bpstat_should_step): Likewise.
1896
1897 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1898
1899         * features/Makefile: Use feature target descriptions for Arm.
1900         * features/arm/arm-core.c: Generate new file.
1901         * features/arm/arm-fpa.c: Likewise.
1902         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1903         * features/arm/arm-m-profile.c: Likewise.
1904         * features/arm/arm-vfpv2.c: Likewise.
1905         * features/arm/arm-vfpv3.c: Likewise.
1906         * features/arm/xscale-iwmmxt.c: Likewise.
1907         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1908
1909 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1910
1911         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1912         ptrace earlier.
1913
1914 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1915
1916         * features/aarch64-pauth.c: Regenerate.
1917
1918 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1919
1920         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1921         bool.
1922         (bpstat_what): Use false instead of 0.
1923
1924 2019-07-09  Pedro Alves  <palves@redhat.com>
1925
1926         * break-catch-throw.c (is_exception_catchpoint): New.
1927         * breakpoint.c (print_one_breakpoint_location): New parameter
1928         'raw_loc'.  Handle it.  Use
1929         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1930         looking at the breakpoint's type.
1931         (print_one_breakpoint): If handling "maint info breakpoints", also
1932         print locations of exception catchpoints.
1933         * breakpoint.h (is_exception_catchpoint): Declare.
1934
1935 2019-07-09  Pedro Alves  <palves@redhat.com>
1936
1937         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1938         "addr" field.
1939         (allocate_location_exception_catchpoint): New.
1940         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1941         (initialize_throw_catchpoint_ops): Install
1942         allocate_location_exception_catchpoint as allocate_location
1943         method.
1944         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1945         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1946         bp_loc_other.
1947         (breakpoint_address_is_meaningful): Delete.
1948         (bl_address_is_meaningful): New.
1949         (breakpoint_locations_match): Adjust comment.
1950         (bp_location_from_bp_type): New, factored out of...
1951         (bp_location::bp_location(breakpoint *)): ... this.
1952         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1953         factored out of...
1954         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1955         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1956         breakpoint_address_is_meaningful.
1957         (bp_locations_compare): Adjust comment.
1958         (update_global_location_list): Use bl_address_is_meaningful
1959         instead of breakpoint_address_is_meaningful.
1960         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1961         explicit.
1962         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1963         * python/py-breakpoint.c (bppy_get_location): No longer check
1964         whether location is null.
1965
1966 2019-07-09  Pedro Alves  <palves@redhat.com>
1967
1968         PR c++/15468
1969         * breakpoint.c (print_one_breakpoint_location): Remove
1970         single-location assert.
1971
1972 2019-07-09  Tom Tromey  <tom@tromey.com>
1973
1974         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1975         * configure: Rebuild.
1976         * configure.ac: Change common to gdbsupport.
1977         * gdbsupport: Rename from common.
1978         * acinclude.m4: Change common to gdbsupport.
1979         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1980         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1981         gdbsupport.
1982         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1983         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1984         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1985         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1986         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1987         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1988         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1989         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1990         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1991         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1992         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1993         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1994         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1995         coff-pe-read.c, command.h, compile/compile-c-support.c,
1996         compile/compile-c.h, compile/compile-cplus-symbols.c,
1997         compile/compile-cplus-types.c, compile/compile-cplus.h,
1998         compile/compile-loc2c.c, compile/compile.c, completer.c,
1999         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2000         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2001         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2002         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2003         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2004         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2005         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2006         features/aarch64-core.c, features/aarch64-fpu.c,
2007         features/aarch64-pauth.c, features/aarch64-sve.c,
2008         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2009         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2010         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2011         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2012         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2013         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2014         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2015         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2016         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2017         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2018         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2019         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2020         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2021         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2022         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2023         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2024         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2025         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2026         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2027         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2028         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2029         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2030         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2031         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2032         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2033         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2034         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2035         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2036         minsyms.c, mips-linux-tdep.c, namespace.h,
2037         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2038         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2039         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2040         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2041         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2042         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2043         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2044         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2045         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2046         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2047         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2048         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2049         procfs.c, producer.c, progspace.h, psymtab.h,
2050         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2051         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2052         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2053         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2054         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2055         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2056         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2057         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2058         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2059         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2060         target-memory.c, target.c, target.h, target/waitstatus.c,
2061         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2062         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2063         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2064         unittests/array-view-selftests.c,
2065         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2066         unittests/common-utils-selftests.c,
2067         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2068         unittests/format_pieces-selftests.c,
2069         unittests/function-view-selftests.c,
2070         unittests/lookup_name_info-selftests.c,
2071         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2072         unittests/mkdir-recursive-selftests.c,
2073         unittests/observable-selftests.c,
2074         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2075         unittests/parse-connection-spec-selftests.c,
2076         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2077         unittests/scoped_fd-selftests.c,
2078         unittests/scoped_mmap-selftests.c,
2079         unittests/scoped_restore-selftests.c,
2080         unittests/string_view-selftests.c, unittests/style-selftests.c,
2081         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2082         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2083         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2084         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2085         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2086         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2087
2088 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2091         bool value.
2092         (decode_digits_ordinary): Set explicit_line field in sal.
2093         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2094         symtab_and_line that was set on an explicit line number in
2095         assembler code.  Do always update the recorded symtab and line if
2096         we do skip the prologue.
2097
2098 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * breakpoint.c (set_breakpoint_location_function): Remove
2101         explicit_loc parameter.
2102         (momentary_breakpoint_from_master): Update call to
2103         set_breakpoint_location_function.
2104         (add_location_to_breakpoint): Likewise.
2105
2106 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2107
2108         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2109         required features based on default bfd type when no specific bfd
2110         is present.
2111
2112 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2113
2114         * NEWS: Mention that GDB printf and eval commands can now print
2115         C-style and Ada-style convenience var strings without
2116         calling the inferior.
2117         * printcmd.c (printf_c_string): Locally print GDB internal var
2118         instead of transiting via the inferior.
2119         (printf_wide_c_string): Likewise.
2120
2121 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2122
2123         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2124
2125 2019-07-04  Tom Tromey  <tom@tromey.com>
2126
2127         PR tui/24724:
2128         * tui/tui-winsource.c (tui_clear_source_content): Update.
2129         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2130         (tui_update_breakpoint_info): Update.
2131         (tui_set_exec_info_content): Update.
2132         * tui/tui-source.c (tui_set_source_content_nil): Update.
2133         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2134         has_break.
2135         * tui/tui-data.h (enum tui_bp_flag): New.
2136         (tui_bp_flags): New enum flags type.
2137         (struct tui_source_element) <break_mode>: Change type.  Rename
2138         from has_break.
2139         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2140         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2141         constants.
2142         * tui/tui-winsource.h: Fix comment.
2143
2144 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2145
2146         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2147         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2148         (store_fpregs_to_thread)
2149         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2150         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2151         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2152         (IWMMXT_REGS_SIZE): Add define.
2153         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2154         (fetch_vfp_regs, store_vfp_regs)
2155         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2156         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2157
2158 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2159
2160         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2161         defines.
2162         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2163         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2164         (ARM_INT_REGISTER_SIZE): ...to this.
2165         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2166         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2167         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2168         (arm_linux_collect_gregset, supply_nwfpe_register)
2169         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2170         defines.
2171         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2172         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2173         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2174         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2175         (arm_return_in_memory, arm_store_return_value)
2176         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2177         (arm_record_ld_st_multiple): Likewise.
2178         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2179         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2180
2181 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2182
2183         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2184         AARCH64_DISPLACED_MODIFIED_INSNS.
2185         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2186         (aarch64_displaced_step_copy_insn): Likewise.
2187         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2188         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2189         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2190         ARM_DISPLACED_MODIFIED_INSNS.
2191         * arm-tdep.c (arm_gdbarch_init): Likewise.
2192         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2193         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2194         (struct arm_displaced_step_closure): Use
2195         ARM_DISPLACED_MODIFIED_INSNS.
2196
2197 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2198
2199         * features/Makefile: Remove unused xml files.
2200         * features/aarch64.xml: Remove.
2201         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2202         * features/i386/amd64-avx-avx512.xml: Remove.
2203         * features/i386/amd64-avx-linux.xml: Remove.
2204         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2205         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2206         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2207         * features/i386/amd64-avx-mpx.xml: Remove.
2208         * features/i386/amd64-avx.xml: Remove.
2209         * features/i386/amd64-linux.xml: Remove.
2210         * features/i386/amd64-mpx-linux.xml: Remove.
2211         * features/i386/amd64-mpx.xml: Remove.
2212         * features/i386/amd64.xml: Remove.
2213         * features/i386/i386-avx-avx512-linux.xml: Remove.
2214         * features/i386/i386-avx-avx512.xml: Remove.
2215         * features/i386/i386-avx-linux.xml: Remove.
2216         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2217         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2218         * features/i386/i386-avx-mpx-linux.xml: Remove.
2219         * features/i386/i386-avx-mpx.xml: Remove.
2220         * features/i386/i386-avx.xml: Remove.
2221         * features/i386/i386-linux.xml: Remove.
2222         * features/i386/i386-mmx-linux.xml: Remove.
2223         * features/i386/i386-mmx.xml: Remove.
2224         * features/i386/i386-mpx-linux.xml: Remove.
2225         * features/i386/i386-mpx.xml: Remove.
2226         * features/i386/i386.xml: Remove.
2227         * features/i386/x32-avx-avx512-linux.xml: Remove.
2228         * features/i386/x32-avx-linux.xml: Remove.
2229         * features/i386/x32-linux.xml: Remove.
2230
2231 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2232
2233         * regformats/aarch64.dat: Remove.
2234         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2235         * regformats/i386/amd64-avx-linux.dat: Remove.
2236         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2237         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2238         * regformats/i386/amd64-linux.dat: Remove.
2239         * regformats/i386/amd64-mpx-linux.dat: Remove.
2240         * regformats/i386/amd64.dat: Remove.
2241         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2242         * regformats/i386/i386-avx-linux.dat: Remove.
2243         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2244         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2245         * regformats/i386/i386-linux.dat: Remove.
2246         * regformats/i386/i386-mmx-linux.dat: Remove.
2247         * regformats/i386/i386-mpx-linux.dat: Remove.
2248         * regformats/i386/i386.dat: Remove.
2249         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2250         * regformats/i386/x32-avx-linux.dat: Remove.
2251         * regformats/i386/x32-linux.dat: Remove.
2252
2253 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2254
2255         * aarch64-tdep.c: Remove xml self tests.
2256         * amd64-linux-tdep.c: Likewise.
2257         * amd64-tdep.c: Likewise.
2258         * i386-linux-tdep.c: Likewise.
2259         * i386-tdep.c: Likewise.
2260
2261 2019-07-03  Pedro Alves  <palves@redhat.com>
2262
2263         PR cli/24732
2264         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2265         (pipe_cmd_option_defs): New.
2266         (make_pipe_cmd_options_def_group): New.
2267         (pipe_command): Use gdb::option::process_options.
2268         (pipe_command_completer): New function.
2269         (_initialize_cli_cmds): Install completer for "pipe" command.
2270
2271 2019-07-03  Pedro Alves  <palves@redhat.com>
2272
2273         * cli/cli-option.c (union option_value) <string>: New field.
2274         (struct option_def_and_value): Add ctor, move ctor, dtor and
2275         use DISABLE_COPY_AND_ASSIGN.
2276         (option_def_and_value::clear_value): New.
2277         (parse_option, save_option_value_in_ctx, get_val_type_str)
2278         (add_setshow_cmds_for_options): Handle var_string.
2279         * cli-option.h (union option_def::var_address) <string>: New
2280         field.
2281         (struct string_option_def): New.
2282         * maint-test-options.c (struct test_options_opts): Add default
2283         ctor and use DISABLE_COPY_AND_ASSIGN.
2284         <string_opt>: New field.
2285         (test_options_opts::~test_options_opts): New.
2286         (test_options_opts::dump): Also dump "-string".
2287         (test_options_option_defs): Install "string.
2288
2289 2019-07-03  Pedro Alves  <palves@redhat.com>
2290
2291         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2292         option_value with a null enumeration.
2293         (complete_options): Save the option values in the context.
2294         (save_option_value_in_ctx): New, factored out from ...
2295         (process_options): ... here.
2296         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2297         of the function.
2298         * maint-test-options.c (test_options_opts::dump): New, factored
2299         out from ...
2300         (maintenance_test_options_command_mode): ... here.
2301         (maintenance_test_options_command_completion_result): Delete.
2302         (maintenance_test_options_command_completion_text): Update
2303         comment.
2304         (maintenance_show_test_options_completion_result): Change
2305         prototype.  Just print
2306         maintenance_test_options_command_completion_text.
2307         (save_completion_result): New.
2308         (maintenance_test_options_completer_mode): Pass options context to
2309         complete_options, and then save a dump.
2310         (_initialize_maint_test_options): Use add_cmd to install "maint
2311         show test-options-completion-result".
2312
2313 2019-07-03  Pedro Alves  <palves@redhat.com>
2314
2315         * NEWS (New commands): Mention "with" and "maint with".
2316         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2317         (with_command, with_command_completer): New.
2318         (pipe_command): Adjust to new repeat_previous
2319         interface.
2320         (_initialize_cli_cmds): Install the "with" command and its "w"
2321         alias.
2322         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2323         declarations.
2324         * cli/cli-setshow.c (parse_cli_var_uinteger)
2325         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2326         argument strings for all var_types.
2327         (get_setshow_command_value_string): New, factored out from ...
2328         (do_show_command): ... this.
2329         * cli/cli-setshow.h: Include <string>.
2330         (get_setshow_command_value_string): Declare.
2331         * command.h (repeat_previous): Now returns const char *.  Adjust
2332         comment.
2333         * maint.c: Include "cli/cli-cmds.h".
2334         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2335         (_initialize_maint_cmds): Register the "maintenance with" command.
2336         * top.c (repeat_previous): Move bits from pipe_command here:
2337         Return the saved command line, if any; error out if there's no
2338         command to relaunch.
2339
2340 2019-07-03  Pedro Alves  <palves@redhat.com>
2341
2342         * NEWS (New commands): Mention "maint set/show test-settings"
2343         instead of "maint test-settings".
2344         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2345         (maintenance_test_settings_set_list): Rename to ...
2346         (maintenance_set_test_settings_list): ... this.
2347         (maintenance_test_settings_show_list): Rename to  ...
2348         (maintenance_show_test_settings_list): ... this.
2349         (maintenance_test_settings_cmd): Delete.
2350         (maintenance_test_settings_set_cmd): ...
2351         (maintenance_set_test_settings_cmd): ... this.
2352         (maintenance_test_settings_show_cmd): ...
2353         (maintenance_show_test_settings_cmd): ... this.
2354         (maintenance_test_settings_show_value_cmd):
2355         (maintenance_show_test_settings_value_cmd): ... this.
2356         (_initialize_maint_test_settings): No longer install the "maint
2357         test-settings" prefix command.  Rename "maint test-settings set"
2358         to "maint set test-settings", and "maint test-settings show" to
2359         "maint show test-settings".  Adjust all subcommands.
2360
2361 2019-07-03  Pedro Alves  <palves@redhat.com>
2362
2363         * maint-test-settings.c: Fix file's intro comment.  Replace all
2364         references to "test-options" with references to "test-settings",
2365         in comments.
2366
2367 2019-07-03  Pedro Alves  <palves@redhat.com>
2368
2369         * maint-test-settings.c (maintenance_test_settings_xxx)
2370         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2371         New.
2372         (maintenance_test_settings_enums): Use them.
2373         (maintenance_test_settings_enum): Default to
2374         maintenance_test_settings_xxx.
2375         (_initialize_maint_test_settings): Initialize
2376         MAINTENANCE_TEST_SETTINGS_FILENAME.
2377
2378 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2379
2380         * breakpoint.h (remove_breakpoints_inf): Change return type to
2381         void, move function documentation here.
2382         * breakpoint.c (remove_breakpoints_inf): Change return type to
2383         void, move function documentation to header.
2384
2385 2019-07-02  Pedro Alves  <palves@redhat.com>
2386
2387         * NEWS (Completion improvements): Mention "info threads".
2388         * thread.c (struct info_threads_opts, info_threads_option_defs)
2389         (make_info_threads_options_def_group): New.
2390         (info_threads_command): Use gdb::option::process_options.
2391         (info_threads_command_completer): New.
2392         (_initialize_thread): Use gdb::option::build_help to build the
2393         help text for "info threads".
2394
2395 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2396
2397         * defs.h (generic_load): Move from here...
2398         * symfile.h (generic_load): ... to here.  Rename name parameter
2399         to args.
2400         * symfile.c (generic_load): Add comment.
2401
2402 2019-07-01  Tom Tromey  <tromey@adacore.com>
2403
2404         * dwarf2read.c
2405         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2406         declaration of without_params.  Fix formatting.
2407
2408 2019-07-01  Tom Tromey  <tromey@adacore.com>
2409
2410         * ada-exp.y (find_primitive_type): Update.
2411         * ada-lang.h (ada_lookup_symbol): Update.
2412         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2413         parameter.
2414         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2415
2416 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2417
2418         PR breakpoints/24541
2419         * gdbarch.c: Regenerate.
2420         * gdbarch.h: Regenerate.
2421         * gdbarch.sh: Add 'stap_adjust_register'.
2422         * i386-tdep.c: Include '<unordered_set>'.
2423         (i386_stap_adjust_register): New function.
2424         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2425         * stap-probe.c (stap_parse_register_operand): Call
2426         'gdbarch_stap_adjust_register'.
2427
2428 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2429
2430         PR python/24742
2431         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2432         * python/python.c (do_start_initialization): Use 'xmalloc'
2433         instead of 'PyMem_Malloc'.
2434
2435 2019-06-28  Tom Tromey  <tromey@adacore.com>
2436
2437         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2438         for Ada.
2439
2440 2019-06-27  Tom Tromey  <tromey@adacore.com>
2441
2442         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2443         objfile_key.
2444         (arm_find_mapping_symbol, arm_record_special_symbol)
2445         (_initialize_arm_tdep): Update.
2446         (arm_objfile_data_free): Remove.
2447
2448 2019-06-27  Tom Tromey  <tromey@adacore.com>
2449
2450         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2451         to cp_print_static_field.
2452
2453 2019-06-26  Tom Tromey  <tromey@adacore.com>
2454
2455         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2456         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2457         declare.
2458
2459 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2460
2461         * features/aarch64-core.c (create_feature_aarch64_core):
2462         Regenerate.
2463         * features/aarch64-core.xml: Add cpsr flags.
2464
2465 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2466
2467         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2468         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2469
2470 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2471
2472         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2473         field.
2474         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2475         use.
2476         (arm_record_special_symbol): Don't insert new symbol in sorted
2477         position, push it at the end.
2478
2479 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2480
2481         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2482         (arm_mapping_symbol_s): Remove.
2483         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2484         (arm_mapping_symbol_vec): New typedef.
2485         (struct arm_per_objfile): Add constructor.
2486         <section_maps>: Change type to
2487         std::unique_ptr<arm_mapping_symbol_vec[]>.
2488         (arm_compare_mapping_symbols): Remove.
2489         (arm_find_mapping_symbol): Adjust to section_maps type change.
2490         (arm_objfile_data_free): Call delete on arm_per_objfile.
2491         (arm_record_special_symbol): Adjust to section_maps type change.
2492         Allocate arm_per_objfile with new.
2493
2494 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2495
2496         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2497         with the command prefix.
2498
2499 2019-06-25  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2502         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2507         type.
2508         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2509         protected.
2510
2511 2019-06-25  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-winsource.c
2514         (tui_source_window_base::set_is_exec_point_at): Add check against
2515         LOA_ADDRESS.
2516
2517 2019-06-25  Tom Tromey  <tom@tromey.com>
2518
2519         * tui/tui-source.c (tui_set_source_content): Don't check before
2520         xfree.
2521         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2522
2523 2019-06-25  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-winsource.h (tui_update_source_window_as_is)
2526         (tui_alloc_source_buffer, tui_line_is_displayed)
2527         (tui_addr_is_displayed): Change type of win_info.
2528         * tui/tui-winsource.c (tui_update_source_window_as_is)
2529         (tui_clear_source_content, tui_show_source_line)
2530         (tui_show_source_content, tui_source_window_base::refill)
2531         (tui_source_window_base::set_is_exec_point_at)
2532         (tui_source_window_base::set_is_exec_point_at)
2533         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2534         (tui_alloc_source_buffer, tui_line_is_displayed)
2535         (tui_addr_is_displayed): Change type of win_info.  Update.
2536         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2537         (tui_source_window_base::do_make_visible_with_new_height):
2538         Update.
2539         * tui/tui-source.c (tui_set_source_content)
2540         (tui_set_source_content_nil)
2541         (tui_source_window::do_scroll_vertical): Update.
2542         * tui/tui-layout.c (show_layout): Update.
2543         * tui/tui-disasm.c (tui_set_disassem_content)
2544         (tui_disasm_window::do_scroll_vertical): Update.
2545         * tui/tui-data.h (tui_win_content): Remove.
2546         (struct tui_gen_win_info) <content, content_size>: Remove.
2547         (struct tui_source_element): Add initializers and destructor.
2548         (union tui_which_element, struct tui_win_element): Remove.
2549         (struct tui_source_window_base) <content>: New field.
2550         (struct tui_data_window): Remove destructor.
2551         (tui_alloc_content, tui_free_win_content)
2552         (tui_free_all_source_wins_content): Don't declare.
2553         * tui/tui-data.c (tui_initialize_static_data): Update.
2554         (init_content_element, tui_alloc_content): Remove.
2555         (~tui_gen_win_info): Update.
2556         (~tui_data_window, tui_free_all_source_wins_content)
2557         (tui_free_win_content, free_content, free_content_elements):
2558         Remove.
2559
2560 2019-06-25  Tom Tromey  <tom@tromey.com>
2561
2562         * tui/tui-winsource.h (tui_clear_source_content)
2563         (tui_erase_source_content, tui_show_source_content): Change type
2564         of win_info.
2565         * tui/tui-winsource.c (tui_clear_source_content)
2566         (tui_erase_source_content, tui_show_source_content): Change type
2567         of win_info.
2568         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2569         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2570         win_info.
2571         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2572         win_info.
2573         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2574
2575 2019-06-25  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-winsource.c (tui_clear_source_content)
2578         (tui_source_window_base::set_is_exec_point_at): Update.
2579         * tui/tui-source.c (tui_set_source_content_nil): Update.
2580         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2581         a bool.
2582         * tui/tui-data.c (init_content_element): Update.
2583
2584 2019-06-25  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2587         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2588         * tui/tui-layout.c (init_and_make_win): Update.
2589         * tui/tui.h (enum tui_win_type): Update.
2590         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2591         tui_win_is_auxillary.
2592         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2593         tui_win_is_auxillary.
2594
2595 2019-06-25  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2598         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2599         (tui_delete_data_content_windows, tui_display_all_data)
2600         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2601         Update.
2602         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2603         * tui/tui-regs.c (tui_last_regs_line_no)
2604         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2605         (tui_show_registers): Update.
2606         (tui_show_register_group): Return void.  Update.
2607         (tui_display_registers_from, tui_display_reg_element_at_line)
2608         (tui_display_registers_from_line, tui_check_register_values):
2609         Update.
2610         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2611         member.
2612         (struct tui_data_window) <regs_content>: Now a std::vector.
2613         <regs_content_count>: Remove.
2614         (tui_add_content_elements, tui_free_data_content): Don't declare.
2615         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2616         (init_content_element): Remove DATA_WIN case.  Add assert.
2617         (tui_add_content_elements): Remove.
2618         (tui_data_window): Update.
2619         (tui_free_data_content): Remove.
2620         (free_content_elements): Remove DATA_WIN case.
2621
2622 2019-06-25  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-data.c (tui_data_item_window): Update.
2625         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2626         * tui/tui-windata.c (tui_display_all_data)
2627         (tui_display_data_from_line): Update.
2628         (tui_check_data_values): Remove.
2629         * tui/tui-regs.c (tui_show_register_group)
2630         (tui_display_reg_element_at_line): Update.
2631         * tui/tui-hooks.c (tui_register_changed)
2632         (tui_refresh_frame_and_register_information): Call
2633         tui_check_register_values.
2634         * tui/tui-data.h (struct tui_data_window) <data_content,
2635         data_content_count, data_type>: Remove.
2636         (enum tui_data_type): Remove.
2637
2638         * tui/tui-data.c (tui_data_window::clear_detail)
2639         (~tui_data_window): Update.
2640
2641 2019-06-25  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2644         declare.
2645         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2646         Rename from tui_first_data_item_displayed.  Update.
2647         (tui_data_window::refresh_all)
2648         (tui_data_window::do_scroll_vertical): Update.
2649         * tui/tui-data.h (struct tui_data_window)
2650         <first_data_item_displayed>: Declare new method.
2651
2652 2019-06-25  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2655         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2656         contents...
2657         (tui_initialize_static_data): ...here.
2658
2659 2019-06-25  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2662         (tui_display_registers_from, tui_check_register_values): Update.
2663         (tui_display_register): Remove win_info parameter; update.
2664         (tui_get_register): Change type of parameters.
2665         * tui/tui-data.h (struct tui_data_element): Remove.
2666         (union tui_which_element) <data>: Remove.
2667         <data_window>: Change type.
2668         (struct tui_data_item_window): New.
2669         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2670         case.  Add assert.
2671         (~tui_data_item_window): New destructor.
2672         (free_content_elements): Remove DATA_ITEM_WIN case.
2673
2674 2019-06-25  Tom Tromey  <tom@tromey.com>
2675
2676         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2677         Remove.
2678
2679 2019-06-25  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-data.h (struct tui_command_element): Remove.
2682         (union tui_which_element) <command>: Remove.
2683         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2684         assert.
2685         (free_content_elements): Remove CMD_WIN case.
2686
2687 2019-06-25  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-layout.c (tui_set_layout): Update.
2690         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2691         * tui/tui-data.c (layout_def): Update.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2696         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2697         (tui_source_window_base::set_new_height): Update.
2698         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2699         Update.
2700         (tui_set_locator_fullname, tui_set_locator_info)
2701         (tui_show_frame_info): Update.
2702         * tui/tui-source.c (tui_set_source_content)
2703         (tui_source_is_displayed): Update.
2704         * tui/tui-layout.c (show_source_disasm_command, show_data)
2705         (show_source_or_disasm_and_command): Update.
2706         * tui/tui-disasm.c (tui_set_disassem_content)
2707         (tui_get_begin_asm_address): Update.
2708         * tui/tui-data.h (struct tui_locator_element): Remove.
2709         (union tui_which_element) <locator>: Remove.
2710         (struct tui_locator_window): New.
2711         (tui_locator_win_info_ptr): Change return type.
2712         * tui/tui-data.c (_locator): Change type.
2713         (tui_locator_win_info_ptr): Change return type.
2714         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2715         (tui_alloc_content): Add assert.
2716
2717 2019-06-25  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-winsource.c
2720         (tui_exec_info_window::maybe_allocate_content): New method.
2721         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2722         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2723         (make_source_or_disasm_window): Add cast.
2724         * tui/tui-data.h (union tui_which_element) <simple_string>:
2725         Remove.
2726         (struct tui_source_info): New.
2727         (struct tui_source_window_base) <execution_info>: Change type.
2728         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2729         case, and add assert.
2730         (tui_alloc_content): Add assert.
2731
2732 2019-06-25  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2735         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2736         * tui/tui-data.c (tui_alloc_win_info): Remove.
2737
2738 2019-06-25  Tom Tromey  <tom@tromey.com>
2739
2740         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2741         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2742         can_highlight.
2743
2744 2019-06-25  Tom Tromey  <tom@tromey.com>
2745
2746         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2747         make_visible_with_new_height method.
2748         (tui_win_info::make_visible_with_new_height): New method.
2749         (tui_source_window_base::do_make_visible_with_new_height)
2750         (tui_data_window::do_make_visible_with_new_height)
2751         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2752         (make_visible_with_new_height): Remove.
2753         (tui_resize_all, tui_adjust_win_heights): Use
2754         make_visible_with_new_height method.
2755         * tui/tui-data.h (struct tui_win_info)
2756         <do_make_visible_with_new_height, make_visible_with_new_height>:
2757         New methods.
2758         (struct tui_source_window_base, struct tui_data_window)
2759         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2760         methods.
2761
2762 2019-06-25  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2765         method.
2766         (update_tab_width): Call update_tab_width method.
2767         * tui/tui-data.h (struct tui_win_info)
2768         (struct tui_source_window_base) <update_tab_width>: New methods.
2769
2770 2019-06-25  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2773         parameter.
2774         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2775         parameter.
2776         (tui_gen_win_info::make_visible): Update.
2777         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2778         parameter.
2779         * tui/tui-data.h (enum tui_box): New enum.
2780         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2781
2782 2019-06-25  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2785         init_and_make_win for EXEC_INFO_WIN.
2786         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2787         longer inline.
2788         (struct tui_win_info) <~tui_win_info>: Inline.
2789         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2790         Don't declare.
2791         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2792         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2793         Remove.
2794         (tui_initialize_static_data): Update.
2795         (~tui_gen_win_info): Handle more cleanup here.
2796         (~tui_source_window_base): Delete "execution_info".
2797         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2798
2799 2019-06-25  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-layout.c (make_command_window): Don't set
2802         can_highlight.
2803         (show_source_disasm_command): Call the reset method.
2804         (show_data): Don't set can_highlight.  Call the reset method.
2805         (tui_gen_win_info::reset): Rename from init_gen_win_info
2806         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2807         (show_source_or_disasm_and_command): Call the reset method.
2808         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2809         (struct tui_cmd_window): Set can_highlight.
2810
2811 2019-06-25  Tom Tromey  <tom@tromey.com>
2812
2813         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2814         from make_visible.
2815         (tui_make_visible, tui_make_invisible): Rewrite.
2816         (tui_win_info::make_visible): Remove.
2817         (tui_source_window_base::make_visible): Update.
2818         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2819         method.  Moved from...
2820         (struct tui_win_info) <make_visible>: ...here.
2821
2822 2019-06-25  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-winsource.c
2825         (tui_source_window_base::do_scroll_horizontal): Remove direction
2826         parameter.
2827         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2828         direction parameter.
2829         * tui/tui-win.c (tui_win_info::forward_scroll)
2830         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2831         (tui_win_info::right_scroll): Update.
2832         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2833         direction parameter.
2834         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2835         direction parameter.
2836         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2837         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2838         Remove direction parameter.
2839         (struct tui_source_window_base, struct tui_source_window)
2840         (struct tui_disasm_window, struct tui_data_window)
2841         (struct tui_cmd_window): Update.
2842
2843 2019-06-25  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-winsource.h (tui_set_exec_info_content)
2846         (tui_show_exec_info_content, tui_erase_exec_info_content)
2847         (tui_clear_exec_info_content, tui_update_exec_info): Change
2848         argument to tui_source_window_base.
2849         * tui/tui-winsource.c (tui_set_exec_info_content)
2850         (tui_show_exec_info_content, tui_erase_exec_info_content)
2851         (tui_clear_exec_info_content, tui_update_exec_info): Change
2852         argument to tui_source_window_base.
2853
2854 2019-06-25  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2857         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2858
2859 2019-06-25  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2862         check.
2863
2864 2019-06-25  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2867         type to void.
2868         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2869         type to void.
2870         * tui/tui-source.c (tui_set_source_content): Update.
2871         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2872
2873 2019-06-25  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-win.c (window_name_completer, tui_set_focus)
2876         (tui_all_windows_info): Use name method.
2877         * tui/tui-data.h (struct tui_gen_win_info)
2878         (struct tui_source_window, struct tui_disasm_window)
2879         (struct tui_data_window, struct tui_cmd_window) <name>: New
2880         method.
2881         (tui_win_name): Don't declare.
2882         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2883         (tui_win_name): Remove.
2884
2885 2019-06-25  Tom Tromey  <tom@tromey.com>
2886
2887         * tui/tui-winsource.h (tui_update_source_window)
2888         (tui_update_source_window_as_is): Change parameter type.
2889         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2890         to be a tui_source_window_base.
2891         (tui_update_source_window_as_is): Likewise.
2892         * tui/tui-win.c (make_visible_with_new_height): Update.
2893
2894 2019-06-25  Tom Tromey  <tom@tromey.com>
2895
2896         * tui/tui-winsource.c (tui_erase_source_content)
2897         (tui_show_source_content, tui_show_exec_info_content)
2898         (tui_erase_exec_info_content): Use refresh_window method.
2899         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2900         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2901         from tui_refresh_win.
2902         (tui_data_window::refresh_window): New method.
2903         (tui_win_info::refresh, tui_source_window_base::refresh)
2904         (tui_refresh_all): Use refresh_window method.
2905         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2906         method.
2907         * tui/tui-regs.c (tui_display_register): Call refresh_window
2908         method.
2909         * tui/tui-layout.c (show_source_disasm_command)
2910         (show_source_or_disasm_and_command): Call refresh_window method.
2911         * tui/tui-data.h (struct tui_gen_win_info)
2912         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2913         New method.
2914
2915 2019-06-25  Tom Tromey  <tom@tromey.com>
2916
2917         * tui/tui.c (tui_rl_other_window, tui_enable)
2918         (tui_is_window_visible, tui_get_command_dimension): Update.
2919         * tui/tui-winsource.c (tui_update_source_window_as_is)
2920         (tui_clear_source_content, tui_erase_source_content)
2921         (tui_show_source_line, tui_source_window_base::refill)
2922         (tui_source_window_base::do_scroll_horizontal)
2923         (tui_source_window_base::set_is_exec_point_at)
2924         (tui_update_breakpoint_info, tui_set_exec_info_content)
2925         (tui_alloc_source_buffer, tui_line_is_displayed)
2926         (tui_addr_is_displayed): Update.
2927         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2928         (tui_check_and_display_highlight_if_needed)
2929         (tui_win_info::make_visible, tui_win_info::refresh)
2930         (tui_refresh_all): Update.
2931         * tui/tui-windata.c (tui_first_data_item_displayed)
2932         (tui_delete_data_content_windows, tui_erase_data_content)
2933         (tui_display_all_data, tui_data_window::refresh_all)
2934         (tui_check_data_values): Update.
2935         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2936         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2937         (tui_win_info::backward_scroll, tui_refresh_all_win)
2938         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2939         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2940         (tui_source_window_base::set_new_height)
2941         (tui_data_window::set_new_height)
2942         (make_invisible_and_set_new_height)
2943         (make_visible_with_new_height, new_height_ok)
2944         (parse_scrolling_args): Update.
2945         * tui/tui-stack.c (tui_show_frame_info): Update.
2946         * tui/tui-source.c (tui_set_source_content)
2947         (tui_set_source_content_nil, tui_source_is_displayed)
2948         (tui_source_window::do_scroll_vertical): Update.
2949         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2950         (tui_display_registers_from, tui_display_reg_element_at_line)
2951         (tui_check_register_values, tui_reg_command): Update.
2952         * tui/tui-layout.c (tui_default_win_height)
2953         (show_source_disasm_command, show_data, init_and_make_win)
2954         (show_source_or_disasm_and_command): Update.
2955         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2956         (tui_redisplay_readline, tui_mld_flush)
2957         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2958         (tui_getc): Update.
2959         * tui/tui-disasm.c (tui_set_disassem_content)
2960         (tui_disasm_window::do_scroll_vertical): Update.
2961         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2962         Now virtual.
2963         (struct tui_win_info): Derive from tui_gen_win_info.
2964         <~tui_win_info>: Mark as override.
2965         <generic>: Remove member.
2966         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2967         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2968         (~tui_data_window, ~tui_win_info)
2969         (tui_free_all_source_wins_content): Update.
2970         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-layout.c (init_and_make_win): Use new.
2975         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2976         destructor, initializers.
2977         (tui_alloc_generic_win_info): Don't declare.
2978         * tui/tui-data.c (_locator): Add argument to constructor.
2979         (source_win, disasm_win): New globals.
2980         (exec_info): Remove.
2981         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2982         Update.
2983         (tui_alloc_generic_win_info): Remove.
2984         (init_content_element): Use new.
2985         (tui_win_info::tui_win_info): Update.
2986         (free_content_elements) <case DATA_WIN>: Use delete.
2987
2988 2019-06-25  Tom Tromey  <tom@tromey.com>
2989
2990         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2991         * tui/tui-windata.c (tui_first_data_item_displayed)
2992         (tui_delete_data_content_windows): Update.
2993         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2994         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2995         (tui_display_registers_from, tui_check_register_values): Update.
2996         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2997         pointer.
2998         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2999         window.
3000         (tui_free_data_content): Update.
3001         (free_content_elements) <case DATA_WIN>: Free the window.
3002
3003 2019-06-25  Tom Tromey  <tom@tromey.com>
3004
3005         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3006         Update.
3007         * tui/tui-layout.c (make_command_window)
3008         (show_source_disasm_command, show_data, init_and_make_win)
3009         (show_source_or_disasm_and_command): Update.
3010         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3011         method.
3012         <can_highight, is_highlighted>: Now bool.
3013         (tui_set_win_highlight): Don't declare.
3014         * tui/tui-data.c (tui_set_win_highlight): Remove.
3015
3016 2019-06-25  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-wingeneral.c (make_visible): Remove check of window
3019         type.
3020
3021 2019-06-25  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-win.c (tui_win_info::max_height)
3024         (tui_cmd_window::max_height): New methods.
3025         (new_height_ok): Call max_height.
3026         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3027         <max_height>: New method.
3028
3029 2019-06-25  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-win.c (tui_source_window_base::set_new_height)
3032         (tui_data_window::set_new_height): New methods.
3033         (make_invisible_and_set_new_height): Call set_new_height method.
3034         * tui/tui-data.h (struct tui_win_info)
3035         (struct tui_source_window_base, struct tui_data_window)
3036         <set_new_height>: New method.
3037
3038 2019-06-25  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3041         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3042         tui_refresh_data_win.
3043         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3044         method.
3045         (tui_refresh_all_win): Call the refresh_all method.
3046         (tui_set_focus): Likewise.
3047         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3048         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3049         Likewise.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-winsource.h (tui_refill_source_window)
3054         (tui_set_is_exec_point_at): Don't declare.
3055         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3056         (tui_source_window_base::refill): Rename from
3057         tui_refill_source_window.
3058         (tui_source_window_base::do_scroll_horizontal): Update.
3059         (tui_source_window_base::set_is_exec_point_at): Rename from
3060         tui_set_is_exec_point_at.
3061         (tui_update_all_breakpoint_info): Update.
3062         * tui/tui-stack.c (tui_show_frame_info): Update.
3063         * tui/tui-layout.c (show_data): Add cast.
3064         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3065         * tui/tui-data.h (struct tui_source_window_base) <refill,
3066         set_is_exec_point_at>: New methods.
3067         (tui_source_windows, tui_add_to_source_windows): Update types.
3068         (tui_add_to_source_windows): Remove redundant declaration.
3069         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3070         (tui_source_windows): Change return type.
3071         (tui_clear_source_windows_detail): Update.
3072         (tui_add_to_source_windows): Change type of parameter.
3073         (tui_free_all_source_wins_content): Update.
3074
3075 2019-06-25  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-wingeneral.c (tui_win_info::refresh)
3078         (tui_source_window_base::refresh): New methods.
3079         (tui_refresh_all): Call the refresh method.
3080         * tui/tui-data.h (struct tui_win_info)
3081         (struct tui_source_window_base) <refresh>: New method.
3082
3083 2019-06-25  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui.h (tui_is_window_visible): Return bool.
3086         * tui/tui.c (tui_is_window_visible): Return bool.
3087         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3088         (tui_make_visible, tui_make_invisible)
3089         (tui_win_info::make_visible)
3090         (tui_source_window_base::make_visible, make_all_visible)
3091         (tui_make_all_visible, tui_make_all_invisible): Update.
3092         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3093         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3094         bool.
3095         (struct tui_win_info, struct tui_source_window_base)
3096         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3097         * tui/tui-data.c (tui_init_generic_part): Update.
3098
3099 2019-06-25  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3102         (tui_source_window_base::make_visible): New methods.
3103         (make_all_visible): Make method call.
3104         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3105         (struct tui_source_window_base, struct tui_cmd_window): Override
3106         make_visible.
3107         (tui_win_is_source_type): Don't declare.
3108         * tui/tui-data.c (tui_win_is_source_type): Remove.
3109
3110 2019-06-25  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3113         NULL check.
3114
3115 2019-06-25  Tom Tromey  <tom@tromey.com>
3116
3117         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3118         Inline constructor.  Add initializers for members.
3119         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3120         constructors; now inline in class.
3121
3122 2019-06-25  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-regs.c (tui_show_registers): Update.
3125         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3126         bool.
3127         * tui/tui-data.c (tui_data_window::clear_detail)
3128         (tui_data_window): Update.
3129
3130 2019-06-25  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-windata.c (tui_display_all_data)
3133         (tui_display_data_from_line, tui_display_data_from)
3134         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3135         Update.
3136         * tui/tui-regs.c (tui_last_regs_line_no)
3137         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3138         (tui_show_registers, tui_show_register_group)
3139         (tui_display_registers_from, tui_display_reg_element_at_line)
3140         (tui_display_registers_from_line, tui_check_register_values)
3141         (tui_reg_next, tui_reg_prev): Update.
3142         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3143         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3144         tui_data_window.
3145         (struct tui_win_info) <detail>: Remove.  Add new fields from
3146         tui_data_info.
3147         (TUI_DATA_WIN): Add cast.
3148         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3149         (~tui_data_window): Simplify.
3150
3151 2019-06-25  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-layout.c (show_source_disasm_command)
3154         (show_source_or_disasm_and_command): Update.
3155         * tui/tui-io.c (update_cmdwin_start_line)
3156         (tui_redisplay_readline): Update.
3157         * tui/tui-data.h (struct tui_command_info): Remove.
3158         (struct tui_win_info) <detail>: Remove command_info member.
3159         (struct tui_data_window) <start_line>: New member, from
3160         tui_command_info.
3161         (TUI_CMD_WIN): Add casts.
3162
3163 2019-06-25  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-winsource.c (tui_update_source_window)
3166         (tui_refill_source_window)
3167         (tui_source_window_base::do_scroll_horizontal)
3168         (tui_update_breakpoint_info, tui_set_exec_info_content)
3169         (tui_show_exec_info_content, tui_erase_exec_info_content)
3170         (tui_clear_exec_info_content): Update.
3171         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3172         Update.
3173         * tui/tui-win.c (make_invisible_and_set_new_height)
3174         (make_visible_with_new_height): Update.
3175         * tui/tui-source.c (tui_set_source_content)
3176         (tui_show_symtab_source): Update.
3177         * tui/tui-layout.c (extract_display_start_addr)
3178         (show_source_disasm_command, show_data)
3179         (make_source_or_disasm_window)
3180         (show_source_or_disasm_and_command): Update.
3181         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3182         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3183         "gdbarch".
3184         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3185         to tui_source_window_base.
3186         (struct tui_win_info) <detail>: Remove source_info member.
3187         (struct tui_source_window_base) <has_locator>: Inline.
3188         Move contents from tui_source_info; rename has_locator member to
3189         m_has_locator.
3190         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3191         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3192         header file.
3193         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3194         Simplify.
3195         (tui_free_all_source_wins_content): Cast to
3196         tui_source_window_base.
3197
3198 2019-06-25  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-win.c (make_invisible_and_set_new_height)
3201         (make_visible_with_new_height): Call has_locator method.
3202         * tui/tui-layout.c (show_source_disasm_command, show_data)
3203         (show_source_or_disasm_and_command): Update for bool change.
3204         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3205         (tui_win_info) <has_locator>: New method.
3206         (struct tui_source_window_base) <has_locator>: New method.
3207         (tui_win_has_locator): Don't declare.
3208         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3209         from tui_win_has_locator.
3210         (tui_source_window_base): Use false, not FALSE.
3211
3212 2019-06-25  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3215         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3216         clear_detail method directly.
3217         (tui_clear_win_detail): Remove.
3218
3219 2019-06-25  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3222         "this", not TUI_DISASM_WIN.
3223
3224 2019-06-25  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3227         declare.
3228         * tui/tui-winsource.c
3229         (tui_source_window_base::do_scroll_horizontal): Rename from
3230         tui_horizontal_source_scroll.
3231         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3232         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3233         from tui_vertical_data_scroll.
3234         * tui/tui-win.h (tui_scroll): Don't declare.
3235         * tui/tui-win.c (tui_win_info::forward_scroll)
3236         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3237         (tui_win_info::right_scroll): Rename and update.
3238         (tui_scroll_forward_command, tui_scroll_backward_command)
3239         (tui_scroll_left_command, tui_scroll_right_command): Update.
3240         (tui_scroll): Remove.
3241         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3242         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3243         from tui_vertical_source_scroll.
3244         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3245         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3246         from tui_vertical_disassem_scroll.
3247         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3248         do_scroll_horizontal>: New methods.
3249         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3250         Likewise.
3251         (struct tui_source_window_base): Add do_scroll_horizontal.
3252         (struct tui_source_window, struct tui_disasm_window): Add
3253         do_scroll_vertical.
3254         (struct tui_data_window, struct tui_cmd_window): Add
3255         do_scroll_horizontal and do_scroll_vertical.
3256         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3257
3258 2019-06-25  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-data.h (struct tui_source_window_base): New struct.
3261         (struct tui_source_window): Derive from tui_source_window_base.
3262         (struct tui_disasm_window): New struct.
3263         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3264         from tui_source_window::clear_detail.
3265         (tui_source_window_base): Rename from tui_source_window.
3266         (~tui_source_window_base): Rename from ~tui_source_window.
3267         (tui_alloc_win_info): Create a tui_disasm_window.
3268
3269 2019-06-25  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-data.h (struct tui_source_window)
3272         (struct tui_data_window): Declare destructors.
3273         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3274         destructors.
3275         (tui_win_info): Simplify.
3276
3277 2019-06-25  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-winsource.c (tui_display_main)
3280         (tui_update_source_windows_with_addr)
3281         (tui_update_all_breakpoint_info): Update.
3282         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3283         (new_height_ok, parse_scrolling_args): Update.
3284         * tui/tui-stack.c (tui_show_frame_info): Update.
3285         * tui/tui-data.h (struct tui_list): Remove.
3286         (tui_source_windows): Return a reference to a std::vector.
3287         * tui/tui-data.c (source_windows): Now a std::vector.
3288         (tui_source_windows): Change return type.
3289         (tui_clear_source_windows): Rewrite.
3290         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3291         (tui_free_all_source_wins_content): Rewrite.
3292
3293 2019-06-25  Tom Tromey  <tom@tromey.com>
3294
3295         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3296         (struct tui_data_window, struct tui_cmd_window): Declare
3297         clear_detail method.
3298         * tui/tui-data.c (tui_source_window::clear_detail)
3299         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3300         methods.
3301         (tui_clear_win_detail): Simplify.
3302
3303 2019-06-25  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-layout.c (make_source_window, make_disasm_window)
3306         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3307         Return the new window.
3308         (show_source_disasm_command, show_data)
3309         (show_source_or_disasm_and_command): Update.
3310
3311 2019-06-25  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3314         parameter.  Return the new window.
3315         (show_source_disasm_command): Update and remove NULL check.
3316         (show_source_or_disasm_and_command): Update.
3317
3318 2019-06-25  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3321
3322 2019-06-25  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-data.h (struct tui_win_info): Make constructor
3325         protected.  Make destructor virtual.  Add initializers.
3326         (tui_source_window, tui_data_window, tui_cmd_window): New
3327         classes.
3328         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3329         constructor.  Add "type" parameter.
3330         (tui_source_window, tui_data_window, tui_cmd_window): New
3331         constructors.
3332         (tui_alloc_win_info): Instantiate the appropriate subclass.
3333
3334 2019-06-25  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-win.c (tui_resize_all): Use delete.
3337         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3338         destructor.
3339         (tui_free_window): Don't declare.
3340         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3341         Update.
3342
3343 2019-06-25  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-data.h (struct tui_win_info): Add constructor.
3346         * tui/tui-data.c (tui_alloc_win_info): Use new.
3347         (tui_free_window): Use delete.
3348
3349 2019-06-22  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3352         declare.
3353         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3354
3355 2019-06-22  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3358         declare.
3359         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3360
3361 2019-06-22  Tom de Vries  <tdevries@suse.de>
3362
3363         * dwarf2read.c (create_addrmap_from_aranges)
3364         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3365         instead of '%zu'.
3366
3367 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3368
3369         * dwarf2read.h (dwarf2_section_info_def): Remove.
3370         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3371         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3372         std::vector<dwarf2_section_info>.
3373         (struct dwo_file) <~dwo_file>: Remove.
3374         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3375         types field.
3376         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3377         (dwarf2_read_debug_names): Likewise.
3378         (create_debug_types_hash_table): Change parameter type to
3379         array_view, adjust code accordingly.
3380         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3381         (partial_die_info::fixup): Likewise.
3382         (determine_prefix): Likewise.
3383         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3384
3385 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3386
3387         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3388         gdb_bfd_ref_ptr.
3389         <~dwo_file>: Remove call to gdb_bfd_unref.
3390         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3391         gdb_bfd_ref_ptr::get.
3392
3393 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3394
3395         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3396         type to htab_up.
3397         * dwarf2read.c (struct dwo_file): Initialize fields.
3398         <~dwo_file>: New.
3399         (free_dwo_file): Remove, move content to ~dwo_file.
3400         (struct dwo_file_deleter): Remove.
3401         (dwo_file_up>: Remove custom deleter.
3402         (free_dwo_files): Remove.
3403         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3404         dwo_files.
3405         (process_skeletonless_type_units): Call unique_ptr::get.
3406         (allocate_dwo_file_hash_table): Add deleter to created hash
3407         table.  Change return type to htab_up.
3408         (lookup_dwo_file_slot): Don't memset dwo_file, call
3409         unique_ptr::get.
3410         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3411         (create_dwo_unit_in_dwp_v2): Likewise.
3412         (open_and_init_dwo_file): Likewise.
3413         (free_dwo_file_from_slot): Remove.
3414
3415 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3416
3417         * dwarf2read.h (struct dwarf2_section_info) <readin,
3418         is_virtual>: Change type to bool.
3419         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3420         true instead of 1.
3421
3422 2019-06-19  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-data.h (tui_init_content_element): Don't declare.
3425
3426 2019-06-19  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-data.h (tui_init_win_info): Don't declare.
3429
3430 2019-06-19  Tom de Vries  <tdevries@suse.de>
3431
3432         * dwarf2read.h (abstract_to_concrete): Change type to
3433         std::unordered_map<sect_offset, std::vector<sect_offset>,
3434         gdb::hash_enum<sect_offset>>.
3435
3436 2019-06-19  Tom Tromey  <tromey@adacore.com>
3437
3438         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3439         EVAL_AVOID_SIDE_EFFECTS specially.
3440
3441 2019-06-19  Tom Tromey  <tromey@adacore.com>
3442
3443         * source-cache.c (highlighter): New global.
3444         (source_cache::get_source_lines): Create a highlighter on demand.
3445
3446 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * defs.h (deprecated_interactive_hook): Delete declaration.
3449         * interps.c (clear_interpreter_hooks): Remove use of
3450         deprecated_interactive_hook.
3451         * top.c (deprecated_interactive_hook): Delete definition.
3452         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3453
3454 2019-06-18  Tom de Vries  <tdevries@suse.de>
3455
3456         PR gdb/24515
3457         * dwarf2read.h (abstract_to_concrete): Change type from
3458         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3459         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3460         * dwarf2read.c (read_variable): Update.
3461         (dwarf2_fetch_die_loc_sect_off): Update.
3462
3463 2019-06-17  Tom de Vries  <tdevries@suse.de>
3464
3465         PR gdb/24617
3466         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3467         accessing parent[parent_len - 1].
3468
3469 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3470
3471         PR gdb/24364
3472         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3473         call dtrace_process_dof with NULL dof.
3474
3475 2019-06-16  Tom de Vries  <tdevries@suse.de>
3476
3477         PR gdb/24445
3478         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3479
3480 2019-06-16  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3483         (make_all_visible): Use address of member.
3484
3485 2019-06-16  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3488         (tui_free_window, free_content, free_content_elements): Remove
3489         unnecessary cast.
3490         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3491         cast.
3492         * tui/tui-regs.c (tui_show_register_group)
3493         (tui_display_registers_from, tui_display_reg_element_at_line):
3494         Remove unnecessary cast.
3495
3496 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3497
3498         * linux-nat.c (normal_mask): Delete.
3499         (_initialize_linux_nat): Don't initialise normal_mask.
3500
3501 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3502
3503         PR gdb/24445
3504         * dwarf-index-write.h (write_psymtabs_to_index): Add
3505         dwz_basename parameter.
3506         * dwarf-index-write.c (write_gdbindex): Move file writing to
3507         write_gdbindex_1.  Change return type void.
3508         (assert_file_size): Move up, remove filename parameter.
3509         (write_gdbindex_1): New function.
3510         (write_debug_names): Change return type to void, call
3511         assert_file_size.
3512         (struct index_wip_file): New struct.
3513         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3514         file logic to index_wip_file.  Write index for dwz file if
3515         needed.
3516         (save_gdb_index_command): Pass basename of dwz file, if present.
3517         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3518         build-id of dwz file, if present.
3519         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3520         (dwarf2_get_dwz_file): Likewise.
3521         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3522         (dwarf2_get_dwz_file): Likewise.
3523
3524 2019-06-16  Tom Tromey  <tom@tromey.com>
3525
3526         * coffread.c (process_coff_symbol): Use xstrdup.
3527         * value.c (create_internalvar): Use xstrdup.
3528
3529 2019-06-16  Tom Tromey  <tom@tromey.com>
3530
3531         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3532         * breakpoint.c (stopin_command, stopat_command)
3533         (until_break_command, decode_location_default): Remove unnecessary
3534         cast.
3535         * utils.c (subset_compare): Remove unnecessary cast.
3536         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3537         cast.
3538         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3539         cast.
3540         * infcmd.c (path_command): Remove unnecessary cast.
3541         * coffread.c (decode_type): Remove unnecessary cast.
3542         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3543         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3544         * tui/tui-stack.c (tui_show_locator_content)
3545         (tui_show_frame_info): Remove unnecessary cast.
3546         * tui/tui-win.c (tui_scroll_forward_command)
3547         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3548         (parse_scrolling_args): Remove unnecessary cast.
3549         * tui/tui-data.c (init_win_info, tui_del_window)
3550         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3551         (free_content_elements): Remove unnecessary cast.
3552         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3553         unnecessary cast.
3554         * tui/tui-source.c (tui_set_source_content)
3555         (tui_vertical_source_scroll): Remove unnecessary cast.
3556         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3557         cast.
3558         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3559         * tui/tui-regs.c (tui_display_registers_from)
3560         (tui_display_register): Remove unnecessary cast.
3561         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3562         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3563         (make_visible): Remove unnecessary cast.
3564         * tui/tui-winsource.c (tui_erase_source_content)
3565         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3566         unnecessary cast.
3567         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3568         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3569         * stabsread.c (read_type, read_array_type, read_range_type):
3570         Remove unnecessary cast.
3571         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3572         (parse_symbol, parse_type, upgrade_type, parse_external)
3573         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3574         unnecessary cast.
3575         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3576
3577 2019-06-16  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-data.c (tui_alloc_generic_win_info)
3580         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3581         checks.
3582
3583 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3584             Andrew Burgess  <andrew.burgess@embecosm.com>
3585
3586         * f-typeprint.c (f_print_type): Don't return early for not
3587         associated or not allocated types.
3588         (f_type_print_varspec_suffix): Add print_rank parameter and print
3589         ranks of array types in case they dangling.
3590         (f_type_print_base): Add print_rank parameter.
3591
3592 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         * NEWS: Mention new MI commands.
3595         * break-catch-throw.c (enum exception_event_kind): Move to
3596         breakpoint.h.
3597         (print_mention_exception_catchpoint): Output text as a single
3598         message.
3599         (catch_exception_command_1): Rename to...
3600         (catch_exception_event): ...this, make non-static, update header
3601         command, and change some parameter types.
3602         (catch_catch_command): Update for changes to
3603         catch_exception_command_1.
3604         (catch_throw_command): Likewise.
3605         (catch_rethrow_command): Likewise.
3606         * breakpoint.c (enum exception_event_kind): Delete.
3607         * breakpoint.h (enum exception_event_kind): Moved here from
3608         break-catch-throw.c.
3609         (catch_exception_event): Declare.
3610         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3611         (mi_cmd_catch_throw): New function.
3612         (mi_cmd_catch_rethrow): New function.
3613         (mi_cmd_catch_catch): New function.
3614         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3615         'catch-catch' entries.
3616         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3617         (mi_cmd_catch_rethrow): Declare.
3618         (mi_cmd_catch_catch): Declare.
3619
3620 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3621
3622         * annotate.c (annotate_source_line): Change return type to void,
3623         update implementation to match.
3624         * annotate.h (annotate_source_line): Change return type to void,
3625         update header comment.
3626         * stack.c (print_frame_info): Don't change what frame information
3627         is printed based on whether annotations are on or not.
3628
3629 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3630
3631         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3632         (annotate_source): Make static.
3633         (annotate_source_line): Moved from source.c and renamed from
3634         identify_source_line.  Update the return type.
3635         * annotate.h (annotate_source): Delete declaration.
3636         (annotate_source_line): Declaration moved from source.h, and
3637         renamed from identify_source_line.  Return type updated.
3638         * source.c (identify_source_line): Moved to annotate.c and renamed
3639         to annotate_source_line.
3640         (info_line_command): Remove check of annotation_level.
3641         * source.h (identify_source_line): Move declaration to annotate.h
3642         and rename to annotate_source_line.
3643         * stack.c: Add 'annotate.h' include.
3644         (print_frame_info): Remove check of annotation_level before
3645         calling annotate_source_line.
3646
3647 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3648
3649         * source-cache.c (source_cache::get_plain_source_lines): Use
3650         open_source_file_with_line_charpos instead of just
3651         open_source_file, remove call to find_source_lines.
3652         (source_cache::get_source_lines): Likewise.
3653         * source.c (find_source_lines): Make static.
3654         (get_filename_and_charpos): Renamed into...
3655         (open_source_file_with_line_charpos): ..this along with changes to
3656         return a scoped_fd, and some other minor clean ups.
3657         (identify_source_line): Use open_source_file_with_line_charpos.
3658         (search_command_helper): Use open_source_file_with_line_charpos
3659         instead of just open_source_file, remove call to
3660         find_source_lines.
3661         * source.h (open_source_file_with_line_charpos): Declare new
3662         function.
3663         (find_source_lines): Delete declaration.
3664
3665 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * source.c (get_filename_and_charpos): Remove fullname
3668         parameter.
3669         (identify_source_line): Update call to get_filename_and_charpos.
3670
3671 2019-06-14  Tom Tromey  <tromey@adacore.com>
3672
3673         PR gdb/24502:
3674         * ui-style.h (skip_ansi_escape): Update comment.
3675         * ui-file.h (class no_terminal_escape_file): New class.
3676         * ui-file.c (no_terminal_escape_file::write)
3677         (no_terminal_escape_file::puts): New methods.
3678         * cli/cli-logging.c (handle_redirections): Use
3679         no_terminal_escape_file.
3680
3681 2019-06-14  Tom Tromey  <tromey@adacore.com>
3682
3683         * NEWS: Move convenience variable news above Python news.
3684
3685 2019-06-14  Tom Tromey  <tom@tromey.com>
3686
3687         * gnulib: Move directory to top-level.
3688         * configure.ac: Don't configure gnulib.
3689         * configure: Rebuild.
3690         * common/common-defs.h: Use new path to gnulib.
3691         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3692         (GNULIB_H): Remove.
3693         (INCGNU): Look in new gnulib location.
3694         (HFILES_NO_SRCDIR): Remove gnulib files.
3695         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3696         (generated_files): Remove GNULIB_H.
3697         ($(LIBGNU), all-lib): Remove targets.
3698         (distclean): Don't mention GNULIB_BUILDDIR.
3699         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3700
3701 2019-06-14  Tom Tromey  <tromey@adacore.com>
3702
3703         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3704         Warn if symbol file does not provide any symbols.
3705
3706 2019-06-14  Tom Tromey  <tromey@adacore.com>
3707
3708         * source.c (find_and_open_source): Respect basenames_may_differ.
3709
3710 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3711
3712         * annotate.c (annotate_breakpoints_invalid): Make use of
3713         scoped_restore_terminal_state.
3714         (annotate_frames_invalid): Likewise.
3715
3716 2019-06-14  Tom Tromey  <tromey@adacore.com>
3717
3718         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3719         allow assignment to an internalvar.
3720
3721 2019-06-14  Tom Tromey  <tromey@adacore.com>
3722
3723         * ada-lex.l: Allow "_" in attribute names.
3724
3725 2019-06-14  Tom Tromey  <tromey@adacore.com>
3726
3727         PR gdb/24653:
3728         * regcache.c (registers_changed): Don't call alloca.
3729         * top.c (execute_command): Don't call alloca.
3730
3731 2019-06-13  Pedro Alves  <palves@redhat.com>
3732
3733         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3734         'expression'.  When parsing an expression, error out if there's
3735         junk after "unlimited".
3736         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3737         (do_set_command): Adjust calls to is_unlimited_literal.
3738
3739 2019-06-13  Pedro Alves  <palves@redhat.com>
3740
3741         * compile/compile.c (make_compile_options_def_group): Add braces
3742         around array_view initializer.
3743         * thread.c (make_thread_apply_all_options_def_group)
3744         (make_thread_apply_all_options_def_group): Likewise.
3745
3746 2019-06-13  Pedro Alves  <palves@redhat.com>
3747
3748         * NEWS (New commands): Mention "maint test-options
3749         require-delimiter", "maint test-options unknown-is-error", "maint
3750         test-options unknown-is-operand" and "maint show
3751         test-options-completion-result".
3752         (New command options, command completion): New section.
3753         (Completion improvements): New section.
3754         Mention that you can abbreviate "unlimited".
3755
3756 2019-06-13  Pedro Alves  <palves@redhat.com>
3757
3758         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3759         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3760         * unittests/cli-utils-selftests.c (test_parse_flags)
3761         (test_parse_flags_qcs): Delete.
3762         (test_cli_utils): Don't call deleted functions.
3763
3764 2019-06-13  Pedro Alves  <palves@redhat.com>
3765
3766         * thread.c: Include "cli/cli-option.h".
3767         (tp_array_compar_ascending): Global.
3768         (tp_array_compar): Delete function.
3769         (tp_array_compar_ascending, tp_array_compar_descending): New
3770         functions.
3771         (ascending_option_def, qcs_flag_option_def)
3772         (thr_qcs_flags_option_defs)
3773         (make_thread_apply_all_options_def_group)
3774         (make_thread_apply_options_def_group): New.
3775         (thread_apply_all_command): Use gdb::option::process_options.
3776         (thread_apply_command_completer)
3777         (thread_apply_all_command_completer): New.
3778         (thread_apply_command): Use gdb::option::process_options.
3779         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3780         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3781         to generate help text of "thread apply".  Adjust "taas"'s help.
3782         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3783         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3784
3785 2019-06-13  Pedro Alves  <palves@redhat.com>
3786
3787         * thread.c (thread_apply_command): Check for invalid TID with
3788         isdigit instead of !isalpha.
3789
3790 2019-06-13  Pedro Alves  <palves@redhat.com>
3791
3792         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3793         (validate_flags_qcs): New.
3794         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3795         (validate_flags_qcs): Declare.
3796         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3797         (make_frame_apply_options_def_group): New.
3798         (frame_apply_command_count): Process options with
3799         gdb::option::process_options.
3800         (frame_apply_completer): New.
3801         (frame_apply_level_completer, frame_apply_all_completer)
3802         (frame_apply_completer): New.
3803         (_initialize_stack): Update help of "frame apply", "frame apply
3804         level", "frame apply all" and "faas" to mention supported options
3805         and install command completers.
3806         * stack.h (frame_apply_all_completer): Declare.
3807         * thread.c: Include "stack.h".
3808         (tfaas_command): Add "--".
3809         (_initialize_thread): Update help "tfaas" to mention supported
3810         options and install command completer.
3811
3812 2019-06-13  Pedro Alves  <palves@redhat.com>
3813
3814         * completer.c (complete_nested_command_line): New.
3815         (gdb_completion_word_break_characters_throw): Add assertion.
3816         * completer.h (complete_nested_command_line): Declare.
3817
3818 2019-06-13  Pedro Alves  <palves@redhat.com>
3819
3820         * stack.c (parse_backtrace_qualifiers): New.
3821         (backtrace_command): Use it.
3822         (backtrace_command_completer): Complete on qualifiers.
3823
3824 2019-06-13  Pedro Alves  <palves@redhat.com>
3825
3826         * frame.c: Include "cli/cli-option.h.
3827         (user_set_backtrace_options): New.
3828         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3829         Delete.
3830         (get_prev_frame): Adjust.
3831         (boolean_option_def, uinteger_option_def)
3832         (set_backtrace_option_defs): New.
3833         (_initialize_frame): Adjust and use
3834         gdb::option::add_setshow_cmds_for_options to install "set
3835         backtrace past-main" and "set backtrace past-entry".
3836         * frame.h: Include "cli/cli-option.h".
3837         (struct frame_print_options): Forward declare.
3838         (print_frame_arguments_all, print_frame_arguments_scalars)
3839         (print_frame_arguments_none): Declare.
3840         (print_entry_values): Delete declaration.
3841         (struct frame_print_options, user_frame_print_options): New.
3842         (struct set_backtrace_options): New.
3843         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3844         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3845         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3846         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3847         (list_args_or_locals): Add frame_print_options parameter.
3848         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3849         * python/py-framefilter.c (enumerate_args): Pass down
3850         USER_FRAME_PRINT_OPTIONS.
3851         * stack.c: Include "cli/cli-option.h".
3852         (print_frame_arguments_all, print_frame_arguments_scalars)
3853         (print_frame_arguments_none): Declare.
3854         (print_raw_frame_arguments, print_entry_values): Delete.
3855         (user_frame_print_options): New.
3856         (boolean_option_def, enum_option_def, frame_print_option_defs):
3857         New.
3858         (struct backtrace_cmd_options): New.
3859         (bt_flag_option_def): New.
3860         (backtrace_command_option_defs): New.
3861         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3862         (print_frame_arg, read_frame_arg, print_frame_args)
3863         (print_frame_info, print_frame): Add frame_print_options parameter
3864         and use it.
3865         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3866         (backtrace_command_1): Add frame_print_options and
3867         backtrace_cmd_options parameters and use them.
3868         (make_backtrace_options_def_group): New.
3869         (backtrace_command): Process command options with
3870         gdb::option::process_options.
3871         (backtrace_command_completer): New.
3872         (_initialize_stack): Extend "backtrace"'s help to mention
3873         supported options.  Install completer for "backtrace".
3874         Install some settings commands with add_setshow_cmds_for_options.
3875
3876 2019-06-13  Pedro Alves  <palves@redhat.com>
3877
3878         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3879         and that "set/show print raw frame-arguments" are now deprecated.
3880
3881         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3882         command.
3883         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3884         * stack.c (_initialize_stack): Install "set/show print
3885         raw-frame-arguments", and deprecate "set/show print raw
3886         frame-arguments".
3887         * valprint.c (_initialize_valprint): Deprecate "set/show print
3888         raw".
3889
3890 2019-06-13  Pedro Alves  <palves@redhat.com>
3891
3892         * compile/compile.c (struct compile_options): New.
3893         (compile_flag_option_def, compile_command_option_defs)
3894         (make_compile_options_def_group): New.
3895         (compile_file_command): Handle options with
3896         gdb::option::process_options.
3897         (compile_file_command_completer): New function.
3898         (compile_code_command): Handle options with
3899         gdb::option::process_options.
3900         (compile_code_command_completer): New function.
3901         (_initialize_compiler): Install completers for "compile code" and
3902         "compile file".  Mention available options in "compile code" and
3903         "compile code"'s help.
3904         * completer.c (advance_to_completion_word): New, factored out from
3905         ...
3906         (advance_to_expression_complete_word_point): ... this.
3907         (advance_to_filename_complete_word_point): New.
3908         * completer.h (advance_to_filename_complete_word_point): New
3909         declaration.
3910
3911 2019-06-13  Pedro Alves  <palves@redhat.com>
3912
3913         * compile/compile.c: Include "cli/cli-option.h".
3914         (compile_print_value): Scope data pointer is now a
3915         value_print_options pointer; adjust.
3916         (compile_print_command): Process options.  Scope data pointer is
3917         now a value_print_options pointer; adjust.
3918         (_initialize_compile): Update "compile print"'s help to include
3919         supported options.  Install a completer for "compile print".
3920         * cp-valprint.c (show_vtblprint, show_objectprint)
3921         (show_static_field_print): Delete.
3922         (_initialize_cp_valprint): Don't install "set print
3923         static-members", "set print vtbl", "set print object" here.
3924         * printcmd.c: Include "cli/cli-option.h" and
3925         "common/gdb_optional.h".
3926         (print_command_parse_format): Rework to fill in a
3927         value_print_options instead of a format_data.
3928         (print_value): Change parameter type from format_data pointer to
3929         value_print_options reference.  Adjust.
3930         (print_command_1): Process options.  Adjust to pass down a
3931         value_print_options.
3932         (print_command_completer): New.
3933         (_initialize_printcmd): Install print_command_completer as
3934         handle_brkchars completer for the "print" command.  Update
3935         "print"'s help to include supported options.
3936         * valprint.c: Include "cli/cli-option.h".
3937         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3938         here from cp-valprint.c.
3939         (boolean_option_def, uinteger_option_def)
3940         (value_print_option_defs, make_value_print_options_def_group):
3941         New.  Use gdb::option::add_setshow_cmds_for_options to install
3942         "set print elements", "set print null-stop", "set print repeats",
3943         "set print pretty", "set print union", "set print array", "set
3944         print address", "set print symbol", "set print array-indexes".
3945         * valprint.h: Include <string> and "cli/cli-option.h".
3946         (make_value_print_options_def_group): Declare.
3947         (print_value): Change parameter type from format_data pointer to
3948         value_print_options reference.
3949         (print_command_completer): Declare.
3950
3951 2019-06-13  Pedro Alves  <palves@redhat.com>
3952
3953         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3954         (COMMON_SFILES): Add maint-test-settings.c.
3955         * cli/cli-decode.c (boolean_enums): New global, factored out from
3956         ...
3957         (add_setshow_boolean_cmd): ... here.
3958         * cli/cli-decode.h (boolean_enums): Declare.
3959         * cli/cli-option.c: New file.
3960         * cli/cli-option.h: New file.
3961         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3962         factored out from ...
3963         (parse_cli_boolean_value(const char *)): ... this.
3964         (is_unlimited_literal): Change parameter type to pointer to
3965         pointer.  Adjust and advance ARG pointer.
3966         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3967         (parse_cli_var_enum): New, factored out from ...
3968         (do_set_command): ... this.  Adjust.
3969         * cli/cli-setshow.h (parse_cli_boolean_value)
3970         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3971         (parse_cli_var_enum): Declare.
3972         * cli/cli-utils.c: Include "cli/cli-option.h".
3973         (get_ulongest): New.
3974         * cli/cli-utils.h (get_ulongest): Declare.
3975         (check_for_argument): New overloads.
3976         * maint-test-options.c: New file.
3977
3978 2019-06-13  Pedro Alves  <palves@redhat.com>
3979
3980         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3981         parse a range if "-" is at the end of the string.
3982
3983 2019-06-13  Pedro Alves  <palves@redhat.com>
3984
3985         * cli/cli-setshow.c (parse_auto_binary_operation)
3986         (parse_cli_boolean_value): Don't allow "o".
3987
3988 2019-06-13  Pedro Alves  <palves@redhat.com>
3989
3990         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3991         * NEWS: Mention maint test-settings KIND.
3992         * maint-test-settings.c: New file.
3993
3994 2019-06-13  Pedro Alves  <palves@redhat.com>
3995
3996         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3997         completer.
3998         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3999         "set" completers.
4000
4001 2019-06-13  Pedro Alves  <palves@redhat.com>
4002
4003         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4004         after item.
4005
4006 2019-06-13  Pedro Alves  <palves@redhat.com>
4007
4008         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4009
4010 2019-06-13  Pedro Alves <palves@redhat.com>
4011
4012         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4013         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4014         call.
4015         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4016         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4017         calls.
4018         (check_for_argument): Skip spaces after argument.
4019
4020 2019-06-13  Pedro Alves  <palves@redhat.com>
4021
4022         * thread.c (thread_apply_command): Adjust TID parsing.
4023         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4024         detected before end of string.
4025         (tid_is_in_list): Error out if LIST is invalid.
4026
4027 2019-06-13  Pedro Alves  <palves@redhat.com>
4028
4029         * completer.c (complete_line_internal_1): Rewind completion word
4030         point.
4031         (completion_tracker::advance_custom_word_point_by): Change
4032         parameter type to int.
4033         * completer.h (completion_tracker::advance_custom_word_point_by):
4034         Likewise.
4035
4036 2019-06-13  Pedro Alves  <palves@redhat.com>
4037
4038         * completer.c (advance_to_completion_word): Handle delimiters.
4039
4040 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4041
4042         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4043
4044 2019-06-11  Tom Tromey  <tom@tromey.com>
4045
4046         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4047         (xmalloc_failed): Move to alloc.c.
4048         * alloc.c: New file.
4049         * Makefile.in (COMMON_SFILES): Add alloc.c.
4050
4051 2019-06-11  Tom Tromey  <tom@tromey.com>
4052
4053         * nat/linux-waitpid.c: Don't include server.h.
4054         (linux_debug): Remove.
4055         (my_waitpid): Update.
4056
4057 2019-06-11  Tom Tromey  <tromey@adacore.com>
4058
4059         * infcall.c (_initialize_infcall): Remove trailing newline from
4060         help.
4061         * user-regs.c (_initialize_user_regs): Remove trailing newline
4062         from help.
4063         * typeprint.c (_initialize_typeprint): Remove trailing newline
4064         from help.
4065         * reverse.c (_initialize_reverse): Remove trailing newlines from
4066         help.
4067         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4068         from help.
4069         * language.c (add_set_language_command): Remove trailing newline
4070         from help.
4071         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4072         help.
4073         * disasm.c (_initialize_disasm): Remove trailing newline from
4074         help.
4075         * top.c (init_main): Remove trailing newline from help.
4076         * interps.c (_initialize_interpreter): Remove trailing newline
4077         from help.
4078         * btrace.c (_initialize_btrace): Remove trailing newlines from
4079         help.
4080         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4081         from help.
4082         * python/python.c (_initialize_python): Remove trailing newline
4083         from help.
4084         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4085         help.
4086         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4087         from help.  Reformat some text.
4088         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4089         from help.
4090         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4091         newline from help.
4092
4093 2019-06-11  Tom Tromey  <tromey@adacore.com>
4094
4095         * darwin-nat.c (darwin_decode_exception_message)
4096         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4097
4098 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4099
4100         * valops.c (value_slice): Check for not allocated or not
4101         associated values.
4102
4103 2019-06-10  Tom de Vries  <tdevries@suse.de>
4104
4105         PR gdb/24618
4106         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4107         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4108         invalid.
4109
4110 2019-06-10  Tom de Vries  <tdevries@suse.de>
4111
4112         PR gdb/24611
4113         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4114         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4115
4116 2019-06-10  Tom de Vries  <tdevries@suse.de>
4117
4118         PR symtab/24545
4119         * symtab.c (struct demangled_name_entry): Add language field.
4120         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4121         static minimal symbol".  Set and use language field.
4122
4123 2019-06-10  Tom Tromey  <tromey@adacore.com>
4124
4125         * ada-lang.c (_initialize_ada_language): Update help text.
4126
4127 2019-06-10  Tom Tromey  <tromey@adacore.com>
4128
4129         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4130         with a newline.
4131         * guile/guile.c (handle_boot_error): Don't end warning with a
4132         newline.
4133         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4134         warning with a newline.
4135         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4136         newline.
4137         (s12z_frame_cache): Likewise.
4138         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4139         a newline.
4140         * solib-svr4.c (disable_probes_interface): Don't end warning with
4141         a newline.
4142         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4143         newline.
4144         * python/python.c (do_finish_initialization): Don't end warning
4145         with a newline.
4146
4147 2019-06-10  Tom Tromey  <tom@tromey.com>
4148
4149         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4150         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4151         gdbpy_enter.
4152
4153 2019-06-10  Tom Tromey  <tromey@adacore.com>
4154
4155         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4156         data.
4157         (elf_new_init): Don't call stabsread_new_init.
4158         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4159         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4160         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4161
4162 2019-06-10  Tom de Vries  <tdevries@suse.de>
4163
4164         PR symtab/16264
4165         PR symtab/24517
4166         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4167
4168 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4169
4170         * source.c (find_and_open_source): Also rewrite relative file
4171         names.
4172
4173 2019-04-26  Amos Bird  <amosbird@gmail.com>
4174
4175         * annotate.c (annotate_thread_exited): Add "thread-exited"
4176         annotation.
4177
4178 2019-06-06  Tom Tromey  <tromey@adacore.com>
4179
4180         * maint.h (class scoped_command_stats): Use
4181         DISABLE_COPY_AND_ASSIGN.
4182         <print_time>: New method.
4183         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4184         print_time.
4185         (scoped_command_stats::print_time): New method.
4186
4187 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4190         instructions of lengths 6 or 8 bytes.
4191
4192 2019-06-04  Pedro Alves  <palves@redhat.com>
4193
4194         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4195
4196         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4197         * breakpoint.c (condition_completer): Likewise.
4198         * cli/cli-dump.c (scan_expression): Likewise.
4199         * common/filestuff.c (mkdir_recursive): Likewise.
4200         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4201         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4202         (gdb_abspath): Likewise.
4203         * compile/compile-cplus-types.c
4204         (compile_cplus_instance::decl_name): Likewise.
4205         * completer.c (complete_explicit_location):
4206         (signal_completer, reg_or_group_completer_1): Likewise.
4207         * cp-support.c (cp_remove_params_if_any): Likewise.
4208         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4209         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4210         * infcmd.c (strip_bg_char): Likewise.
4211         * linespec.c (copy_token_string): Likewise.
4212         * mi/mi-main.c (output_cores): Likewise.
4213         * psymtab.c (psymtab_search_name):
4214         * symfile.c (test_set_ext_lang_command): Likewise.
4215         * target.c (target_fileio_read_stralloc): Likewise.
4216         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4217         * value.c (complete_internalvar): Likewise.
4218
4219 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4220
4221         Add objfile property to gdb.Type.
4222         * NEWS: Mention Python API addition.
4223         * python/py-type.c (typy_get_objfile): New method.
4224
4225 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4226
4227         * NEWS: Mention the new set|show style [title|highlight].
4228         Mention changes to "show style", "help" and "apropos".
4229
4230 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4231
4232         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4233         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4234         instead of print_help_for_command.
4235         (print_doc_of_command): New function.
4236         (help_list): Add 'apropos -v word' suggestion.
4237         (print_help_for_command): Style the command name using title style.
4238         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4239         (_initialize_cli_cmds): Describe -v in apropos_command help.
4240
4241 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4242
4243         * cli/cli-style.h (cli_style_option): Add name in constructor,
4244         add m_name class member, add constructor with intensity,
4245         add name class function.
4246         (cli_style_option::add_setshow_commands): Remove name argument.
4247         (highlight_style, title_style): New styles.
4248         * cli/cli-style.c (do_show): New function that shows a style
4249         characteristic styling the style name with itself.
4250         (set_style_name): New function.
4251         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4252         Update all callers according to the changes in cli/cli-style.h.
4253         * utils.h (fputs_highlighted): New function.
4254         * utils.c (fputs_highlighted): Likewise.
4255
4256 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4257
4258         * NEWS: Mention new pipe command and new convenience variables.
4259
4260 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4261
4262         * cli/cli-cmds.c (pipe_command): New function.
4263         (_initialize_cli_cmds): Call add_com for pipe_command.
4264         Define | as an alias for pipe.
4265         (exit_status_set_internal_vars): New function.
4266         (shell_escape): Call exit_status_set_internal_vars.
4267         cli/cli-decode.c (find_command_name_length): Recognize | as
4268         a single character command.
4269
4270 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4271
4272         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4273         top.c (execute_command_to_ui_file): New function, mostly a copy
4274         of execute_command_to_string.
4275         (execute_command_to_string): Implement by calling
4276         execute_command_to_ui_file.
4277
4278 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4279
4280         * top.h (saved_command_line): Remove declaration.
4281         * top.c (previous_saved_command_line, previous_repeat_arguments):
4282         New variables.
4283         (saved_command_line): Make static, define together with other
4284         'repeat variables'.
4285         (dont_repeat): Clear repeat_arguments.
4286         (repeat_previous, get_saved_command_line, save_command_line):
4287         New functions.
4288         (gdb_init): Initialize saved_command_line
4289         and previous_saved_command_line.
4290         * main.c (captured_main_1): Remove saved_command_line initialization.
4291         * event-top.c (handle_line_of_input): Update to use
4292         the new 'repeat' related functions instead of direct access to
4293         saved_command_line.
4294         * command.h (repeat_previous, get_saved_command_line,
4295         save_command_line): New declarations.
4296         (dont_repeat): Add comment.
4297
4298 2019-05-30  Tom Tromey  <tromey@adacore.com>
4299
4300         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4301         Fix comment.
4302         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4303
4304 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4305
4306         PR cli/24587
4307         * completer.c (complete): Initialize variable word.
4308
4309 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4310
4311         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4312         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4313         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4314         'body' is NULL to the outter 'if', protecting the '!is_define'
4315         situation as well.
4316
4317 2019-05-29  Tom Tromey  <tromey@adacore.com>
4318
4319         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4320         (dwarf_unknown): New function.
4321         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4322         (dwarf_type_encoding_name): Use dwarf_unknown.
4323
4324 2019-05-29  Tom Tromey  <tromey@adacore.com>
4325
4326         PR c++/20020:
4327         * cp-valprint.c (cp_print_value_fields): Call
4328         cp_print_static_field inside "try".
4329
4330 2019-05-29  Tom Tromey  <tromey@adacore.com>
4331
4332         * inflow.c (struct terminal_info): Add default operator=.
4333         * configure: Rebuild.
4334         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4335         -Wdeprecated-copy-dtor, -Wredundant-move.
4336
4337 2019-05-29  Tom Tromey  <tromey@adacore.com>
4338
4339         * NEWS: Add entry.
4340         * infcmd.c (print_return_value_1): Handle finish_print
4341         option.
4342         (show_print_finish): New function.
4343         (_initialize_infcmd): Add "set/show print finish" commands.
4344         * valprint.c (user_print_options): Initialize new member.
4345         * valprint.h (struct value_print_options) <finish_print>: New
4346         member.
4347
4348 2019-05-28  Tom Tromey  <tromey@adacore.com>
4349
4350         * ada-lang.c (ada_remove_Xbn_suffix)
4351         (find_old_style_renaming_symbol)
4352         (parse_old_style_renaming): Remove.
4353         (ada_find_renaming_symbol): Don't call
4354         find_old_style_renaming_symbol.
4355         (ada_is_renaming_symbol): Rename from
4356         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4357         bool.  Now static.
4358         (ada_read_var_value): Update and simplify.
4359         * ada-exp.y (write_var_or_type): Remove old code.
4360
4361 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4362
4363         * event-top.c: Remove include comment.
4364         * inflow.c (class scoped_ignore_sigttou): Move from here...
4365         * inflow.h (class scoped_ignore_sigttou): ...to here.
4366         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4367         * top.c:  Remove include comment.
4368
4369 2019-05-27  Tom Tromey  <tom@tromey.com>
4370
4371         * NEWS: Fix typo.
4372
4373 2019-05-22  Tom Tromey  <tromey@adacore.com>
4374
4375         * target.c (target_follow_exec): Constify parameter.
4376         * target-delegates.c: Rebuild.
4377         * remote.c (remote_target::follow_exec): Constify parameter.
4378         * infrun.c (follow_exec): Constify parameter.
4379         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4380         (target_follow_exec): Likewise.
4381
4382 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4383
4384         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4385         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4386
4387 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4388
4389         * NEWS: Add debugredirect and testsuite sections.
4390
4391 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4392
4393         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4394         target descriptions using exclusively floating point register name
4395         aliases.
4396
4397 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         PR gdb/18644:
4400         * f-lang.c (build_fortran_types): Handle the case where
4401         gdbarch_floatformat_for_type returns a nullptr.
4402
4403 2019-05-21  Tom de Vries  <tdevries@suse.de>
4404
4405         PR cli/24587
4406         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4407
4408 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4409
4410         PR gdb/18644:
4411         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4412         16-byte floats.
4413         * i386-tdep.c (i386_floatformat_for_type): Use
4414         floatformats_ia64_quad for the 16-byte floating point component
4415         within a fortran 32-byte complex number.
4416
4417 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4420         delete default constructor.
4421         (find_partial_die): Update to return const struct.
4422         (partial_die_parent_scope): Move variable declaration into scope
4423         of its use and change its type to auto.
4424         (guess_partial_die_structure_name): Likewise.
4425         (partial_die_info::fixup): Likewise.
4426
4427 2019-05-17  Tom Tromey  <tromey@adacore.com>
4428
4429         * source.c (find_and_open_source): Remove cast.
4430
4431 2019-05-17  Tom Tromey  <tromey@adacore.com>
4432
4433         * annotate.c (annotate_source): Make "filename" const.
4434         * annotate.h (annotate_source): Use const.
4435
4436 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4437
4438         * disasm.c (set_disassembler_options): Send errors to stderr.
4439
4440 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4441
4442         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4443         (cli_interp_base::set_logging): Check debug_redirect.
4444         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4445         * cli/cli-logging.c (debug_redirect): Add static variable.
4446         (pop_output_files): Add default param.
4447         (handle_redirections): Print debug setting.
4448         (show_logging_command): Likewise.
4449         (_initialize_cli_logging): Add debugredirect command.
4450         * interps.c (current_interp_set_logging): Add debug_redirect
4451         parameter.
4452         * interps.h (set_logging): Add debug_redirect parameter.
4453         (current_interp_set_logging): Likewise.
4454         * mi/mi-common.h: Likewise.
4455         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4456
4457 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4458             Tom Tromey  <tromey@adacore.com>
4459
4460         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4461         directly.
4462         * cli/cli-interp.h (make_logging_output): Remove declaration.
4463         * cli/cli-logging.c (make_logging_output): Remove function.
4464         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4465         directly.
4466         * ui-file.c (tee_file::tee_file): Remove bools.
4467         (tee_file::~tee_file): Remove deletes.
4468         * ui-file.h (tee_file): Remove bools.
4469
4470 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4471
4472         * mi/mi-cmds.h (mi_cmd_complete): New function.
4473         * mi/mi-main.c (mi_cmd_complete): Likewise.
4474         * mi/mi-cmds.c: Define new MI command -complete.
4475         * NEWS: Mention new -complete command.
4476
4477 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4478
4479         * completer.h (complete): New function.
4480         * completer.c (complete): Likewise.
4481         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4482         function defined in completer.h.
4483
4484 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4485
4486         * MAINTAINERS (Write After Approval): Add myself.
4487
4488 2019-05-17  Tom de Vries  <tdevries@suse.de>
4489
4490         PR gdb/24094
4491         * dwarf2read.c (struct cu_partial_die_info): New struct.
4492         (find_partial_die): Return cu_partial_die_info.
4493         (partial_die_parent_scope, guess_partial_die_structure_name)
4494         (partial_die_info::fixup): Handle new return type of find_partial_die.
4495
4496 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4497
4498         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4499         "std::string", simplifying the algorithm.
4500
4501 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4502
4503         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4504         (stap_static_probe_ops::get_probes): Likewise.
4505
4506 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4507
4508         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4509         '-')" and "else if".
4510         (stap_parse_single_operand): Join checks for
4511         "gdbarch_stap_parse_special_token_p" and
4512         "gdbarch_stap_parse_special_token" in the same "if" statement.
4513         Invert check when verifying for operation on register
4514         displacement.
4515
4516 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4517
4518         * stap-probe.c (stap_get_opcode): Update comment.
4519         (stap_get_expected_argument_type): Likewise.
4520         (handle_stap_probe): Likewise.
4521
4522 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4523
4524         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4525         return type to 'bool'.  Adjust comment.  Use 'bool' when
4526         appropriate.
4527         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4528         * stap-probe.c (stap_parse_argument_1): Likewise.
4529         (stap_is_operator): Likewise.
4530         (stap_is_generic_prefix): Likewise.
4531         (stap_is_register_prefix): Likewise.
4532         (stap_is_register_indirection_prefix): Likewise.
4533         (stap_is_integer_prefix): Likewise.
4534         (stap_generic_check_suffix): Likewise.
4535         (stap_check_integer_suffix): Likewise.
4536         (stap_check_register_suffix): Likewise.
4537         (stap_check_register_indirection_suffix): Likewise.
4538         (stap_parse_register_operand): Likewise.
4539         (stap_parse_single_operand): Likewise.
4540         (stap_parse_argument_1): Likewise.
4541         (stap_probe::get_argument_count): Likewise.
4542         (stap_is_operator): Likewise.
4543
4544 2019-05-16  Tom Tromey  <tromey@adacore.com>
4545
4546         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4547         keyword to foreach.
4548
4549 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4550
4551         * linux-thread-db.c (try_thread_db_load_1): Change return type
4552         to bool.
4553         (try_thread_db_load): Likewise.
4554         (try_thread_db_load_from_pdir_1): Likewise.
4555         (try_thread_db_load_from_pdir): Likewise.
4556         (try_thread_db_load_from_sdir): Likewise.
4557         (try_thread_db_load_from_dir): Likewise.
4558         (thread_db_load_search): Likewise.
4559         (has_libpthread): Likewise.
4560         (thread_db_load): Likewise.
4561
4562 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4563
4564         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4565         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4566         NULL, and complain/return if that's the case.
4567
4568 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4569
4570         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4571         (advance, posn, abstract_read_memory): New functions.
4572         [struct mem_read_abstraction]: New struct.
4573         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4574
4575 2019-05-14  Tom Tromey  <tromey@adacore.com>
4576
4577         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4578         value is not lval_memory.
4579
4580 2019-05-14  Tom Tromey  <tromey@adacore.com>
4581
4582         * solib.c (info_sharedlibrary_command): Style the file name.
4583
4584 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4585
4586         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4587         (aarch64_vnv_type): Likewise.
4588         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4589         * common/tdesc.c: Likewise.
4590         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4591         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4592         * features/aarch64-fpu.xml: Add ieee half view.
4593         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4594         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4595         * gdbtypes.h (struct builtin_type): Likewise.
4596         (struct objfile_type): Likewise.
4597
4598 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4599
4600         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4601         typo.
4602         * location.h (string_to_event_location): Likewise.
4603
4604 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4605
4606         GDB 8.3 released.
4607
4608 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4609
4610         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4611         New variable declaration.
4612         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4613         New variable.
4614         (print_one_breakpoint): Use ui_out::test_flags and new global
4615         variable to compute use_fixed_output.
4616         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4617         Remove.
4618         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4619         (mi_multi_location_breakpoint_output_fixed): Remove.
4620         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4621         new variable.
4622         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4623         fix_multi_location_breakpoint_output flag if version >= 3.
4624         * ui-out.h (enum ui_out_flag)
4625         <fix_multi_location_breakpoint_output>: New enumerator.
4626
4627 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4628
4629         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4630
4631 2019-05-10  Tom Tromey  <tromey@adacore.com>
4632
4633         * ada-lang.c (catch_ada_completer): New function.
4634         (_initialize_ada_language): Use it.
4635
4636 2019-05-10  Tom Tromey  <tromey@adacore.com>
4637
4638         * thread.c (print_thread_info): Make "requested_threads" const.
4639         * gdbthread.h (print_thread_info): Make "requested_threads"
4640         const.
4641         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4642         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4643
4644 2019-05-08  Tom Tromey  <tom@tromey.com>
4645
4646         * gdbtypes.c (objfile_type_data): Change type.
4647         (objfile_type, _initialize_gdbtypes): Update.
4648
4649 2019-05-08  Tom Tromey  <tom@tromey.com>
4650
4651         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4652         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4653         (_initialize_dwarf2_frame): Update.
4654
4655 2019-05-08  Tom Tromey  <tom@tromey.com>
4656
4657         * objc-lang.c (objc_objfile_data): Change type.
4658         (find_methods): Update.
4659         (_initialize_objc_lang): Remove.
4660
4661 2019-05-08  Tom Tromey  <tom@tromey.com>
4662
4663         * stabsread.c (rs6000_builtin_type_data): Change type.
4664         (rs6000_builtin_type, _initialize_stabsread): Update.
4665
4666 2019-05-08  Tom Tromey  <tom@tromey.com>
4667
4668         * mips-tdep.c (mips_pdr_data): Remove.
4669         (_initialize_mips_tdep): Update.
4670
4671 2019-05-08  Tom Tromey  <tom@tromey.com>
4672
4673         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4674         (hppa_init_objfile_priv_data, read_unwind_info)
4675         (find_unwind_entry, _initialize_hppa_tdep): Update.
4676
4677 2019-05-08  Tom Tromey  <tom@tromey.com>
4678
4679         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4680         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4681         on obstack.
4682         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4683
4684 2019-05-08  Tom Tromey  <tom@tromey.com>
4685
4686         * mdebugread.c (basic_type_data): Change type.
4687         (basic_type, _initialize_mdebugread): Update.
4688
4689 2019-05-08  Tom Tromey  <tom@tromey.com>
4690
4691         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4692
4693 2019-05-08  Tom Tromey  <tom@tromey.com>
4694
4695         * nto-tdep.c (nto_inferior_data_reg): Change type.
4696         (nto_inferior_data): Update.
4697         (nto_inferior_data_cleanup, nto_new_inferior_data)
4698         (_initialize_nto_tdep): Remove.
4699         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4700
4701 2019-05-08  Tom Tromey  <tom@tromey.com>
4702
4703         * ada-lang.c (struct ada_inferior_data): Add initializers.
4704         (ada_inferior_data): Change type.
4705         (ada_inferior_data_cleanup): Remove.
4706         (get_ada_inferior_data, ada_inferior_exit)
4707         (struct ada_pspace_data): Add initializers, destructor.
4708         (ada_pspace_data_handle): Change type.
4709         (get_ada_pspace_data): Update.
4710         (ada_pspace_data_cleanup): Remove.
4711
4712 2019-05-08  Tom Tromey  <tom@tromey.com>
4713
4714         * coffread.c (struct coff_symfile_info): Add initializers.
4715         (coff_objfile_data_key): Move lower.  Change type.
4716         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4717         Update.
4718         (coff_free_info): Remove.
4719
4720 2019-05-08  Tom Tromey  <tom@tromey.com>
4721
4722         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4723         (fbsd_pspace_data_handle): Move lower.  Change type.
4724         (get_fbsd_pspace_data): Update.
4725         (fbsd_pspace_data_cleanup): Remove.
4726         (_initialize_fbsd_tdep): Update.
4727
4728 2019-05-08  Tom Tromey  <tom@tromey.com>
4729
4730         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4731         (get_ada_tasks_pspace_data): Update.
4732         (ada_tasks_pspace_data_cleanup): Remove.
4733         (_initialize_tasks): Update.
4734         (ada_tasks_inferior_data_handle): Change type.
4735         (get_ada_tasks_inferior_data): Update.
4736         (ada_tasks_inferior_data_cleanup): Remove.
4737         (struct ada_tasks_pspace_data): Add initializers.
4738
4739 2019-05-08  Tom Tromey  <tom@tromey.com>
4740
4741         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4742         * symfile-debug.c (debug_sym_get_probes): Change type.
4743         * stap-probe.c (handle_stap_probe):
4744         (stap_static_probe_ops::get_probes): Change type.
4745         * probe.h (class static_probe_ops) <get_probes>: Change type.
4746         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4747         (parse_probes_in_pspace): Update.
4748         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4749         Update.
4750         (any_static_probe_ops::get_probes): Change type.
4751         * elfread.c (elfread_data): New typedef.
4752         (probe_key): Change type.
4753         (elf_get_probes): Likewise.  Update.
4754         (probe_key_free): Remove.
4755         (_initialize_elfread): Update.
4756         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4757         Change type.
4758         (dtrace_process_dof_probe, dtrace_process_dof)
4759         (dtrace_static_probe_ops::get_probe): Change type.
4760
4761 2019-05-08  Tom Tromey  <tom@tromey.com>
4762
4763         * xcoffread.c (struct xcoff_symfile_info): Rename from
4764         coff_symfile_info.  Add initializers.
4765         (xcoff_objfile_data_key): Move lower.  Change type.
4766         (XCOFF_DATA): Rewrite.
4767         (xcoff_free_info): Remove.
4768         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4769         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4770         (xcoff_initial_scan): Update.
4771
4772 2019-05-08  Tom Tromey  <tom@tromey.com>
4773
4774         * solib-svr4.c (struct svr4_info): Add initializers and
4775         destructor.
4776         <probes_table>: Now an htab_up.
4777         (solib_svr4_pspace_data): Change type.
4778         (free_probes_table): Simplify.
4779         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4780         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4781         (probes_table_remove_objfile_probes, register_solib_event_probe)
4782         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4783         (_initialize_svr4_solib): Update.
4784
4785 2019-05-08  Tom Tromey  <tom@tromey.com>
4786
4787         * remote.c (remote_pspace_data): Change type.
4788         (remote_pspace_data_cleanup): Remove.
4789         (get_remote_exec_file, set_pspace_remote_exec_file)
4790         (_initialize_remote): Update.
4791
4792 2019-05-08  Tom Tromey  <tom@tromey.com>
4793
4794         * breakpoint.c (breakpoint_objfile_key): Change type.
4795         (get_breakpoint_objfile_data): Update.
4796         (free_breakpoint_objfile_data): Remove.
4797         (_initialize_breakpoint): Update.
4798
4799 2019-05-08  Tom Tromey  <tom@tromey.com>
4800
4801         * linux-tdep.c (struct linux_info): Add initializers.
4802         (linux_inferior_data): Move.  Change type.
4803         (invalidate_linux_cache_inf): Update.
4804         (linux_inferior_data_cleanup): Remove.
4805         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4806
4807 2019-05-08  Tom Tromey  <tom@tromey.com>
4808
4809         * auxv.c (auxv_inferior_data): Move.  Change type.
4810         (auxv_inferior_data_cleanup): Remove.
4811         (invalidate_auxv_cache_inf): Rewrite.
4812         (get_auxv_inferior_data, _initialize_auxv): Update.
4813
4814 2019-05-08  Tom Tromey  <tom@tromey.com>
4815
4816         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4817         (symfile_debug_objfile_data_key): Change type.
4818         (symfile_debug_installed, debug_qf_has_symbols)
4819         (debug_qf_find_last_source_symtab)
4820         (debug_qf_forget_cached_source_info)
4821         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4822         (debug_qf_print_stats, debug_qf_dump)
4823         (debug_qf_expand_symtabs_for_function)
4824         (debug_qf_expand_all_symtabs)
4825         (debug_qf_expand_symtabs_with_fullname)
4826         (debug_qf_map_matching_symbols)
4827         (debug_qf_expand_symtabs_matching)
4828         (debug_qf_find_pc_sect_compunit_symtab)
4829         (debug_qf_map_symbol_filenames)
4830         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4831         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4832         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4833         (debug_sym_read_linetable, debug_sym_relocate): Update.
4834         (symfile_debug_free_objfile): Remove.
4835         (install_symfile_debug_logging, _initialize_symfile_debug):
4836         Update.
4837
4838 2019-05-08  Tom Tromey  <tom@tromey.com>
4839
4840         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4841         allocate_on_obstack.
4842         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4843         (get_dwarf2_per_objfile): Update.
4844         (set_dwarf2_per_objfile): Remove.
4845         (dwarf2_has_info, dwarf2_get_section_info): Update.
4846         (dwarf2_free_objfile): Remove.
4847         (_initialize_dwarf2_read): Update.
4848
4849 2019-05-08  Tom Tromey  <tom@tromey.com>
4850
4851         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4852         initializers.
4853         <unsupported_script_warning_printed,
4854         script_not_found_warning_printed>: Now bool.
4855         (auto_load_pspace_data): Change type.
4856         (~auto_load_pspace_info): Rename from
4857         auto_load_pspace_data_cleanup.
4858         (get_auto_load_pspace_data, init_loaded_scripts_info)
4859         (clear_section_scripts, maybe_print_unsupported_script_warning)
4860         (maybe_print_script_not_found_warning, _initialize_auto_load):
4861         Update.
4862
4863 2019-05-08  Tom Tromey  <tom@tromey.com>
4864
4865         * objfiles.c (objfile_pspace_info): Add destructor and
4866         initializers.
4867         (objfiles_pspace_data): Change type.
4868         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4869         (get_objfile_pspace_data): Update.
4870         (objfiles_bfd_data): Change type.
4871         (get_objfile_bfd_data): Update.
4872         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4873
4874 2019-05-08  Tom Tromey  <tom@tromey.com>
4875
4876         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4877         Change type.
4878         (get_catch_syscall_inferior_data): Update.
4879         (catch_syscall_inferior_data_cleanup): Remove.
4880         (_initialize_break_catch_syscall): Update.
4881
4882 2019-05-08  Tom Tromey  <tom@tromey.com>
4883
4884         * inflow.c (struct terminal_info): Add destructor and
4885         initializers.
4886         (inflow_inferior_data): Change type.
4887         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4888         (get_inflow_inferior_data, inflow_inferior_exit)
4889         (swap_terminal_info, _initialize_inflow): Update.
4890
4891 2019-05-08  Tom Tromey  <tom@tromey.com>
4892
4893         * target-dcache.c (target_dcache_cleanup): Remove.
4894         (target_dcache_aspace_key): Change type.
4895         (target_dcache_init_p, target_dcache_invalidate)
4896         (target_dcache_get, target_dcache_get_or_init)
4897         (_initialize_target_dcache): Update.
4898         * dcache.h (struct dcache_deleter): New.
4899
4900 2019-05-08  Tom Tromey  <tom@tromey.com>
4901
4902         * symtab.c (struct symbol_cache): Add destructor and
4903         initializers.
4904         (symbol_cache_key): Move.  Change type.
4905         (make_symbol_cache, free_symbol_cache): Remove.
4906         (get_symbol_cache): Update.
4907         (symbol_cache_cleanup): Remove.
4908         (ALL_PSPACES, symbol_cache_flush)
4909         (maintenance_print_symbol_cache)
4910         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4911         Update.
4912
4913 2019-05-08  Tom Tromey  <tom@tromey.com>
4914
4915         * symtab.c (struct main_info): Add destructor and initializers.
4916         (main_progspace_key): Move.  Change type.
4917         (get_main_info): Update.
4918         (main_info_cleanup): Remove.
4919         (_initialize_symtab): Update.
4920
4921 2019-05-08  Tom Tromey  <tom@tromey.com>
4922
4923         * registry.h (DECLARE_REGISTRY): Define the _key class.
4924
4925 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4926
4927         * NEWS: Merge two 'New commands' sections.
4928
4929 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4930
4931         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4932         parameter and use Ada language definition instead.
4933         (ada_val_print_ptr): Remove unused language parameter.
4934         (ada_val_print_num): Remove language parameter and use Ada language
4935         definition instead.
4936         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4937         parameter.
4938         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4939         parameter and use Ada language definition instead.
4940         (ada_val_print_1): Update all ada_val_print_xxx calls.
4941         Remove language parameter.
4942         (ada_val_print): Update ada_val_print_1 call.
4943
4944 2019-05-08  Tom Tromey  <tromey@adacore.com>
4945
4946         * remote.c (remote_hw_watchpoint_limit)
4947         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4948         Now static.
4949
4950 2019-05-08  Tom Tromey  <tromey@adacore.com>
4951
4952         * maint.c (_initialize_maint_cmds): Move initialization code to
4953         remote.c.
4954         (watchdog, show_watchdog): Move to remote.c.
4955         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4956         "watchdog" static.
4957         (_initialize_remote): Move initialization code from maint.c.
4958         * defs.h (watchdog): Don't declare.
4959
4960 2019-05-08  Tom Tromey  <tromey@adacore.com>
4961
4962         * tui/tui-interp.c: Include main.h.
4963         * interps.c: Include main.h.
4964         * main.h (interpreter_p): Declare.
4965         * defs.h (interpreter_p): Don't declare.
4966
4967 2019-05-08  Tom Tromey  <tromey@adacore.com>
4968
4969         * dwarf2loc.c: Include dwarf2read.h.
4970         * defs.h (read_unsigned_leb128): Don't declare.
4971         * dwarf2read.h (read_unsigned_leb128): Declare.
4972
4973 2019-05-08  Tom Tromey  <tromey@adacore.com>
4974
4975         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4976         method.
4977
4978 2019-05-08  Tom Tromey  <tromey@adacore.com>
4979
4980         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4981         when no wrap column is set.
4982
4983 2019-05-08  Tom Tromey  <tromey@adacore.com>
4984
4985         * c-lang.c (c_get_string): Handle non-C-style arrays.
4986
4987 2019-05-08  Tom Tromey  <tromey@adacore.com>
4988
4989         * typeprint.c (print_offset_data::update): Print the bit offset,
4990         not the number of bits remaining.
4991
4992 2019-05-08  Tom Tromey  <tromey@adacore.com>
4993
4994         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4995         padding at end of comment.
4996
4997 2019-05-08  Tom Tromey  <tromey@adacore.com>
4998
4999         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5000         Compare main types.
5001
5002 2019-05-06  Tom Tromey  <tom@tromey.com>
5003
5004         * common/scoped_mmap.c: Include common-defs.h.
5005         * common/scoped_mmap.h: Don't include config.h.
5006
5007 2019-05-04  Tom Tromey  <tom@tromey.com>
5008
5009         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5010         (struct aarch64_call_info): Add initializers.
5011         <si>: Now a std::vector.
5012         (pass_on_stack, aarch64_push_dummy_call): Update.
5013
5014 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5015             Tom Tromey  <tom@tromey.com>
5016
5017         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5018         (ppc_threads): Now a std::vector.  Now static.
5019         (hwdebug_find_thread_points_by_tid)
5020         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5021         Update.
5022
5023 2019-05-04  Tom Tromey  <tom@tromey.com>
5024
5025         * arc-tdep.c (arc_tdesc_init): Return bool.
5026
5027 2019-05-04  Tom Tromey  <tom@tromey.com>
5028
5029         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5030         Use gdb_assert_not_reached.
5031
5032 2019-05-04  Tom Tromey  <tom@tromey.com>
5033
5034         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5035         "false".
5036
5037 2019-05-04  Tom Tromey  <tom@tromey.com>
5038
5039         * arc-tdep.c (arc_tdesc_init): Use bool.
5040
5041 2019-05-04  Tom Tromey  <tom@tromey.com>
5042
5043         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5044
5045 2019-05-04  Tom Tromey  <tom@tromey.com>
5046
5047         * cli/cli-cmds.c (valid_command_p): Return bool.
5048
5049 2019-05-04  Tom Tromey  <tom@tromey.com>
5050
5051         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5052         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5053
5054 2019-05-04  Raul Tambre  <raul@tambre.ee>
5055
5056         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5057         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5058         operator for comparison.
5059
5060 2019-05-04  Tom Tromey  <tom@tromey.com>
5061
5062         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5063         (lookup_partial_symbol, print_partial_symbols)
5064         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5065         (psymbol_compare): Update.
5066         (add_psymbol_to_bcache): Clear the entire psymbol.
5067         (maintenance_check_psymtabs): Update.
5068         * psympriv.h (struct partial_symbol): Don't derive from
5069         general_symbol_info.
5070         <obj_section, unrelocated_address, address,
5071         set_unrelocated_address>: Update.
5072         <ginfo>: New member.
5073         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5074         (debug_names::write_psymbols): Update.
5075
5076 2019-05-04  Tom de Vries  <tdevries@suse.de>
5077
5078         * contrib/cc-with-tweaks.sh: Support -n arg.
5079
5080 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5081
5082         * corelow.c (core_target::detach): Ensure frame cache and
5083         register caches are cleared.
5084         inferior.c (exit_inferior_1): Likewise.
5085
5086 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5087             Tom Tromey  <tom@tromey.com>
5088
5089         * dictionary.c (collate_pending_symbols_by_language): Remove
5090         "struct" from foreach.
5091         * symtab.c (lookup_global_symbol_from_objfile)
5092         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5093         foreach.
5094         * ser-tcp.c (net_open): Remove "struct" from foreach.
5095         * objfiles.c (objfile_relocate, objfile_rebase)
5096         (objfile_has_symbols): Remove "struct" from foreach.
5097         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5098         from foreach.
5099         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5100         foreach.
5101         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5102         "struct" from foreach.
5103         * ada-lang.c (create_excep_cond_exprs)
5104         (ada_exception_catchpoint_cond_string): Remove "struct" from
5105         foreach.
5106
5107 2019-05-03  Tom Tromey  <tromey@adacore.com>
5108
5109         * ada-exp.y (convert_char_literal): Check suffix of each
5110         enumerator.
5111
5112 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5113
5114         PR ada/21406:
5115         * ada-exp.y (yywrap): Don't define.
5116         * ada-lex.l (%option): Add noyywrap
5117         (yywrap): Remove.
5118
5119 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5120
5121         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5122         _WIN32_WINNT to the XP level, unless already defined to a higher
5123         level.
5124
5125         * unittests/parse-connection-spec-selftests.c:
5126         * ser-tcp.c:
5127         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5128         override.
5129
5130         * symfile.c (find_separate_debug_file): Remove colon from the
5131         drive spec of DOS/Windows file names of the target, so that the
5132         file name produced from DEBUGDIR and the target's directory will
5133         be valid on DOS/Windows systems.
5134
5135 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * rust-lang.c (val_print_struct): Handle printing structures
5138         containing strings.
5139
5140 2019-05-02  Tom Tromey  <tromey@adacore.com>
5141
5142         * valarith.c (_initialize_valarith): Remove.
5143
5144 2019-05-01  Tom Tromey  <tromey@adacore.com>
5145
5146         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5147         bitfields.
5148
5149 2019-05-01  Tom Tromey  <tromey@adacore.com>
5150
5151         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5152         for big-endian copies.
5153
5154 2019-04-30  Ali Tamur  <tamur@google.com>
5155         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5156         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5157         (read_3_bytes): New function.
5158
5159 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5160
5161         * windows-nat.c (main_thread_id): Delete.
5162         (handle_output_debug_string): Replace main_thread_id by
5163         current_event.dwThreadId.
5164         (fake_create_process): Likewise.
5165         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5166         Do not set main_thread_id.
5167         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5168         current_event.dwThreadId.
5169         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5170
5171 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5172
5173         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5174         Use current_event.dwThreadId instead of main_thread_id.
5175
5176 2019-04-30  Tom Tromey  <tromey@adacore.com>
5177
5178         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5179         (create_excep_cond_exprs): Iterate over program spaces.
5180         (ada_exception_catchpoint_cond_string): Examine all minimal
5181         symbols for exception types.
5182
5183 2019-04-30  Tom Tromey  <tromey@adacore.com>
5184
5185         PR c++/24470:
5186         * dwarf2read.c (process_structure_scope): Handle case where type
5187         has template parameters but no symbol was created.
5188
5189 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5190             Chris January  <chris.january@arm.com>
5191
5192         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5193         qualifier.
5194         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5195
5196 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5197
5198         * f-typeprint.c (f_print_type): Update rules for printing
5199         whitespace.
5200         (f_type_print_varspec_suffix): Likewise.
5201
5202 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5203             Chris January  <chris.january@arm.com>
5204
5205         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5206         function arguments.
5207
5208 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5209
5210         * f-lang.c (build_fortran_types): Change name of void type to
5211         lower case.
5212         * f-typeprint.c (f_type_print_base): Print the name of the void
5213         type, rather than a fixed string.
5214         * f-valprint.c (f_decorations): Use lower case void string.
5215
5216 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5217             Chris January  <chris.january@arm.com>
5218
5219         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5220         types for Fortran.
5221
5222 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5223             Chris January  <chris.january@arm.com>
5224             David Lecomber  <david.lecomber@arm.com>
5225
5226         * f-exp.y (BINOP_INTRINSIC): New token.
5227         (exp): New parser rule handling BINOP_INTRINSIC.
5228         (f77_keywords): Add new builtin procedures.
5229         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5230         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5231         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5232         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5233         (print_unop_subexp_f): New function.
5234         (print_binop_subexp_f): New function.
5235         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5236         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5237         (dump_subexp_body_f): Likewise.
5238         (operator_check_f): Likewise.
5239         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5240         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5241
5242 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5243
5244         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5245         UNOP_KIND.
5246         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5247         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5248         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5249         (operator_length_f): New fuction.
5250         (print_subexp_f): New function.
5251         (op_name_f): New function.
5252         (dump_subexp_body_f): New function.
5253         (operator_check_f): New function.
5254         (exp_descriptor_f): Replace standard expression handling functions
5255         with new functions.
5256         * gdb/fortran-operator.def: New file.
5257         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5258         * gdb/std-operator.def: Remove UNOP_KIND.
5259
5260 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * std-operator.def: Remove unbalanced, stray double quote
5263         character.
5264
5265 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5266             Chris January  <chris.january@arm.com>
5267             Daniel Everett  <daniel.everett@arm.com>
5268             Nick Forrington  <nick.forrington@arm.com>
5269             Richard Bunt  <richard.bunt@arm.com>
5270
5271         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5272         of depth when printing anonymous structs or unions.
5273         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5274         Don't print either the top-level value, or the children if the
5275         max-depth is exceeded.
5276         (ppscm_print_children): When printing the key of a map, allow one
5277         extra level of depth.
5278         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5279         print either the top-level value, or the children if the max-depth
5280         is exceeded.
5281         (print_children): When printing the key of a map, allow one extra
5282         level of depth.
5283         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5284         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5285         (user_print_options): Initialise max_depth field.
5286         (val_print_scalar_or_string_type_p): New function.
5287         (val_print): Check to see if the max depth has been reached.
5288         (val_print_check_max_depth): Define new function.
5289         (show_print_max_depth): New function.
5290         (_initialize_valprint): Add 'print max-depth' option.
5291         * valprint.h (struct value_print_options) <max_depth>: New field.
5292         (val_print_check_max_depth): Declare new function.
5293         * NEWS: Document new feature.
5294
5295 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5296
5297         * ada-lang.c (ada_language_defn): Initialise new field.
5298         * c-lang.c (c_is_string_type_p): New function.
5299         (c_language_defn): Initialise new field.
5300         (cplus_language_defn): Initialise new field.
5301         (asm_language_defn): Initialise new field.
5302         (minimal_language_defn): Initialise new field.
5303         * c-lang.h (c_is_string_type_p): Declare new function.
5304         * d-lang.c (d_language_defn): Initialise new field.
5305         * f-lang.c (f_is_string_type_p): New function.
5306         (f_language_defn): Initialise new field.
5307         * go-lang.c (go_is_string_type_p): New function.
5308         (go_language_defn): Initialise new field.
5309         * language.c (default_is_string_type_p): New function.
5310         (unknown_language_defn): Initialise new field.
5311         (auto_language_defn): Initialise new field.
5312         * language.h (struct language_defn) <la_is_string_type_p>: New
5313         member variable.
5314         (default_is_string_type_p): Declare new function.
5315         * m2-lang.c (m2_language_defn): Initialise new field.
5316         * objc-lang.c (objc_language_defn): Initialise new field.
5317         * opencl-lang.c (opencl_language_defn): Initialise new field.
5318         * p-lang.c (pascal_is_string_type_p): New function.
5319         (pascal_language_defn): Initialise new field.
5320         * rust-lang.c (rust_is_string_type_p): New function.
5321         (rust_language_defn): Initialise new field.
5322
5323 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5324
5325         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5326         New field.
5327         * ada-lang.c (ada_language_defn): Initialise new field.
5328         * c-lang.c (c_language_defn): Likewise.
5329         (cplus_language_defn): Likewise.
5330         (asm_language_defn): Likewise.
5331         (minimal_language_defn): Likewise.
5332         * d-lang.c (d_language_defn): Likewise.
5333         * f-lang.c (f_language_defn): Likewise.
5334         * go-lang.c (go_language_defn): Likewise.
5335         * language.c (unknown_language_defn): Likewise.
5336         (auto_language_defn): Likewise.
5337         * m2-lang.c (m2_language_defn): Likewise.
5338         * objc-lang.c (objc_language_defn): Likewise.
5339         * opencl-lang.c (opencl_language_defn): Likewise.
5340         * p-lang.c (pascal_language_defn): Likewise.
5341         * rust-lang.c (rust_language_defn): Likewise.
5342
5343 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * ada-lang.c (ada_is_character_type): Change return type to bool.
5346         (ada_is_string_type): Likewise.
5347         * ada-lang.h (ada_is_character_type): Update declaration
5348         (ada_is_string_type): Likewise.
5349
5350 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5351
5352         Support style in 'frame|thread apply'
5353
5354         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5355         * record.c (record_start, record_stop): Update callers of
5356         execute_command_to_string with false.
5357         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5358         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5359         methods.
5360         (class string_file): New constructor with term_out parameter.
5361         Override methods term_out and can_emit_style_escape.  New member
5362         term_out.
5363         (class stdio_file): Override can_emit_style_escape.
5364         (class tee_file): Override term_out and can_emit_style_escape.
5365         * utils.h (can_emit_style_escape): Remove.
5366         * utils.c (can_emit_style_escape): Likewise.
5367         Update all callers of can_emit_style_escape (SOMESTREAM) to
5368         SOMESTREAM->can_emit_style_escape.
5369         * source-cache.c (source_cache::get_source_lines): Likewise.
5370         * stack.c (frame_apply_command_count): Call execute_command_to_string
5371         passing the term_out characteristic of the current gdb_stdout.
5372         * thread.c (thr_try_catch_cmd): Likewise.
5373         * top.c (execute_command_to_string): pass term_out parameter
5374         to construct the string_file for the command output.
5375         * ui-file.c (term_cli_styling): New function (most code moved
5376         from utils.c can_emit_style_escape).
5377         (string_file::string_file, string_file::can_emit_style_escape,
5378         stdio_file::can_emit_style_escape, tee_file::term_out,
5379         tee_file::can_emit_style_escape): New functions.
5380
5381 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5382
5383         * NEWS: Mention the new set|show may-call-functions.
5384         * infcall.c (may_call_functions_p): New variable.
5385         (show_may_call_functions_p): New function.
5386         (call_function_by_hand_dummy): Throws an error if not
5387         may-call-functions.
5388         (_initialize_infcall): Call add_setshow_boolean_cmd for
5389         may-call-functions.
5390
5391 2019-04-25  Keith Seitz  <keiths@redhat.com>
5392
5393         PR c++/24367
5394         * cp-support.c (inspect_type): Don't attempt substitutions
5395         of symbol with the same name.
5396
5397 2019-04-25  Tom Tromey  <tromey@adacore.com>
5398
5399         PR gdb/24475:
5400         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5401         static.
5402
5403 2019-04-25  Tom Tromey  <tromey@adacore.com>
5404
5405         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5406         rvalue reference.
5407         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5408         (gdb_xml_parser::parse): Use std::move.
5409         * python/python-internal.h (gdbpy_convert_exception): Take a const
5410         reference.
5411         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5412         std::move.
5413         * python/py-utils.c (gdbpy_convert_exception): Take a const
5414         reference.
5415         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5416         Use std::move.
5417         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5418         Use std::move.
5419         * mi/mi-main.c (mi_print_exception): Take a const reference.
5420         * main.c (handle_command_errors): Take a const reference.
5421         * linespec.c (parse_linespec): Use std::move.
5422         * infcall.c (run_inferior_call): Use std::move.
5423         (call_function_by_hand_dummy): Use std::move.
5424         * exec.c (try_open_exec_file): Use std::move.
5425         * exceptions.h (exception_print, exception_fprintf)
5426         (exception_print_same): Update.
5427         * exceptions.c (print_exception, exception_print)
5428         (exception_fprintf, exception_print_same): Change parameters to
5429         const reference.
5430         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5431         * common/new-op.c: Use std::move.
5432         * common/common-exceptions.h (struct gdb_exception): Add move
5433         constructor.
5434         (struct gdb_exception_error, struct gdb_exception_quit, struct
5435         gdb_quit_bad_alloc): Change constructor to move constructor.
5436         (throw_exception): Change parameter to rvalue reference.
5437         * common/common-exceptions.c (throw_exception): Take rvalue
5438         reference.
5439         * cli/cli-interp.c (safe_execute_command): Use std::move.
5440         * breakpoint.c (insert_bp_location, location_to_sals): Use
5441         std::move.
5442
5443 2019-04-25  Tom Tromey  <tromey@adacore.com>
5444
5445         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5446         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5447         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5448         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5449         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5450         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5451         guile/scm-value.c: Use unpack.
5452         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5453         gdbscm_gdb_exception.
5454         (gdbscm_throw_gdb_exception): Likewise.
5455         (struct gdbscm_gdb_exception): New.
5456         (unpack): New function.
5457         (gdbscm_wrap): Use unpack.
5458
5459 2019-04-25  Tom Tromey  <tromey@adacore.com>
5460
5461         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5462         (gdb_rl_callback_handler): Use std::move.
5463         * common/common-exceptions.h (struct gdb_exception): Add move
5464         assignment operator.
5465         (throw_exception_sjlj): Change "exception" to const reference.
5466         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5467         (throw_exception_sjlj): Change "exception" to const reference.
5468
5469 2019-04-25  Tom Tromey  <tromey@adacore.com>
5470
5471         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5472         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5473         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5474         Update.
5475         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5476         Update.
5477         * mi/mi-interp.c (mi_interp::exec): Update.
5478         * linespec.c (parse_linespec): Update.
5479         * infcall.c (run_inferior_call): Update.
5480         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5481         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5482         (gdbscm_lookup_global_symbol): Update.
5483         * guile/scm-param.c (gdbscm_parameter_value): Update.
5484         * guile/scm-frame.c (gdbscm_frame_read_register)
5485         (gdbscm_frame_read_var): Update.
5486         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5487         * exec.c (try_open_exec_file): Update.
5488         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5489         (gdb_rl_callback_handler): Update.
5490         * common/common-exceptions.h (exception_none): Don't declare.
5491         * common/common-exceptions.c (exception_none): Don't define.
5492         (struct catcher) <exception>: Update.
5493         * cli/cli-interp.c (safe_execute_command): Update.
5494         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5495
5496 2019-04-25  Ali Tamur  <tamur@google.com>
5497
5498         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5499         (read_attribute_value): Likewise.
5500         (dwarf2_read_addr_index): Update comment.
5501         (read_str_index): Add DW_FORM_strx.
5502         (dwarf2_string_attr): Likewise.
5503         (dwarf2_const_value_attr): Likewise.
5504         (dump_die_shallow): Likewise.
5505         (dwarf2_fetch_constant_bytes): Likewise.
5506         (skip_form_bytes): Likewise.
5507         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5508
5509 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5510
5511         PR corefiles/11608
5512         PR corefiles/18187
5513         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5514         OFFSET.  Verify if current mapping contains an ELF header.
5515         (linux_find_memory_regions_full): Adjust call to
5516         dump_mapping_p.
5517
5518 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5519             Kang Li <kanglictf@gmail.com>
5520
5521         PR gdb/21600
5522
5523         * dwarf2-frame.c (read_initial_length): Be consistent about using
5524         unsigned representation of length.
5525         (decode_frame_entry_1): Likewise.  Check for wraparound of
5526         end pointer as well as buffer overflow.
5527
5528 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5529
5530         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5531         "vq".
5532
5533 2019-04-24  Tom Tromey  <tromey@adacore.com>
5534
5535         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5536
5537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5538
5539         * s12z-tdep.c (s12z_unwind_pc): Delete.
5540         (s12z_unwind_sp): Delete.
5541         (s12z_gdbarch_init): Don't register deleted functions with
5542         gdbarch.
5543
5544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5545
5546         * rl78-tdep.c (rl78_unwind_sp): Delete.
5547         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5548
5549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5550
5551         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5552         (xstormy16_unwind_pc): Delete.
5553         (xstormy16_dummy_id): Delete.
5554         (xstormy16_gdbarch_init): Don't register deleted functions with
5555         gdbarch.
5556
5557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5558
5559         * vax-tdep.c (vax_unwind_pc): Delete.
5560         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5561
5562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5563
5564         * v850-tdep.c (v850_unwind_sp): Delete.
5565         (v850_unwind_pc): Delete.
5566         (v850_dummy_id): Delete.
5567         (v850_gdbarch_init): Don't register deleted functions with
5568         gdbarch.
5569
5570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5571
5572         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5573         (tilegx_unwind_pc): Delete.
5574         (tilegx_unwind_dummy_id): Delete.
5575         (tilegx_gdbarch_init): Don't register deleted functions with
5576         gdbarch.
5577
5578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5581         (tic6x_dummy_id): Delete.
5582         (tic6x_gdbarch_init): Don't register deleted functions with
5583         gdbarch.
5584
5585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5586
5587         * sparc-tdep.c (sparc_unwind_pc): Delete.
5588         (sparc32_gdbarch_init): Don't register deleted function with
5589         gdbarch.
5590
5591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5592
5593         * sh-tdep.c (sh_unwind_sp): Delete.
5594         (sh_unwind_pc): Delete.
5595         (sh_dummy_id): Delete.
5596         (sh_gdbarch_init): Don't register deleted functions with
5597         gdbarch.
5598
5599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5600
5601         * score-tdep.c (score_unwind_sp): Delete.
5602         (score_unwind_pc): Delete.
5603         (score_dummy_id): Delete.
5604         (score_gdbarch_init): Don't register deleted functions with
5605         gdbarch.
5606
5607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5608
5609         * rx-tdep.c (rx_unwind_pc): Delete.
5610         (rx_unwind_sp): Delete.
5611         (rx_dummy_id): Delete.
5612         (rx_gdbarch_init): Don't register deleted functions with
5613         gdbarch.  Update comment.
5614
5615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5616
5617         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5618         (rs6000_dummy_id): Delete.
5619         (rs6000_gdbarch_init): Don't register deleted functions with
5620         gdbarch.
5621
5622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5623
5624         * or1k-tdep.c (or1k_dummy_id): Delete.
5625         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5626
5627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5628
5629         * nios2-tdep.c (nios2_dummy_id): Delete.
5630         (nios2_unwind_sp): Delete.
5631         (nios2_gdbarch_init): Don't register deleted functions with
5632         gdbarch.
5633
5634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5635
5636         * nds32-tdep.c (nds32_dummy_id): Delete.
5637         (nds32_unwind_pc): Delete.
5638         (nds32_unwind_sp): Delete.
5639         (nds32_gdbarch_init): Don't register deleted functions with
5640         gdbarch.
5641
5642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5643
5644         * msp430-tdep.c (msp430_unwind_pc): Delete.
5645         (msp430_unwind_sp): Delete.
5646         (msp430_dummy_id): Delete.
5647         (msp430_gdbarch_init): Don't register deleted functions with
5648         gdbarch.
5649
5650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5651
5652         * moxie-tdep.c (moxie_unwind_sp): Delete.
5653         (moxie_unwind_pc): Delete.
5654         (moxie_dummy_id): Delete.
5655         (moxie_gdbarch_init): Don't register deleted functions with
5656         gdbarch.
5657
5658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5659
5660         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5661         (mn10300_unwind_pc): Delete.
5662         (mn10300_unwind_sp): Delete.
5663         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5664         mn10300_unwind_sp.
5665         (mn10300_frame_unwind_init): Don't register deleted functions with
5666         gdbarch.
5667
5668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * mep-tdep.c (mep_unwind_pc): Delete.
5671         (mep_unwind_sp): Delete.
5672         (mep_dummy_id): Delete.
5673         (mep_gdbarch_init): Don't register deleted functions with
5674         gdbarch.
5675
5676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5677
5678         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5679         (m68hc11_unwind_sp): Delete.
5680         (m68hc11_gdbarch_init): Don't register deleted functions with
5681         gdbarch.
5682
5683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5684
5685         * m32r-tdep.c (m32r_unwind_sp): Delete.
5686         (m32r_unwind_pc): Delete.
5687         (m32r_dummy_id): Delete.
5688         (m32r_gdbarch_init): Don't register deleted functions with
5689         gdbarch.
5690
5691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5692
5693         * m32c-tdep.c (m32c_unwind_pc): Delete.
5694         (m32c_unwind_sp): Delete.
5695         (m32c_dummy_id): Delete.
5696         (m32c_gdbarch_init): Don't register deleted functions with
5697         gdbarch.
5698
5699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5700
5701         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5702         (lm32_unwind_pc): Delete.
5703         (lm32_dummy_id): Delete.
5704         (lm32_gdbarch_init): Don't register deleted functions with
5705         gdbarch.
5706
5707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5708
5709         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5710         (iq2000_unwind_pc): Delete.
5711         (iq2000_dummy_id): Delete.
5712         (iq2000_gdbarch_init): Don't register deleted functions with
5713         gdbarch.
5714
5715 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         * nds32-tdep.c (nds32_type_align): Delete.
5718         (nds32_push_dummy_call): Use type_align instead.
5719
5720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5721
5722         * arm-tdep.c (arm_type_align): Only handle vector override case.
5723         (arm_push_dummy_call): Use type_align.
5724         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5725
5726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5729         case.
5730         (pass_on_stack): Use type_align.
5731         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5732         function.
5733
5734 2019-04-23  Tom Tromey  <tromey@adacore.com>
5735
5736         * dwarf2read.c (line_header::file_name_at): Remove unused
5737         overload.
5738
5739 2019-04-23  Tom de Vries  <tdevries@suse.de>
5740
5741         PR gdb/24438
5742         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5743         invocation.
5744
5745
5746 2019-03-27  Ali Tamur  <tamur@google.com>
5747
5748         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5749         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5750         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5751         (dwarf_expr_context::get_addr_index): Likewise
5752         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5753         (symbol_needs_eval_context::get_addr_index): Likewise
5754         (disassemble_dwarf_expression): Add DW_OP_addrx
5755         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5756         (read_cutu_die_from_dwo): Update comment
5757         (skip_one_die): Add DW_FORM_addrx
5758         (read_attribute_value): Likewise
5759         (var_decode_location): Add DW_OP_addrx
5760         (dwarf2_const_value_attr): Add DW_FORM_addrx
5761         (dump_die_shallow): Likewise
5762         (dwarf2_fetch_constant_bytes): Likewise
5763         (decode_locdesc): Add DW_OP_addrx
5764         (skip_form_bytes): Add DW_FORM_addrx
5765
5766 2019-04-22  Ali Tamur  <tamur@google.com>
5767
5768         * MAINTAINERS (Write After Approval): Add self.
5769
5770 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5771
5772         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5773         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5774         (open_symbol_file_object): Likewise.
5775         (svr4_default_sos): Add info parameter.
5776         (svr4_read_so_list): Likewise.
5777         (svr4_current_sos_direct): Adjust functions calls to pass down
5778         info.
5779         (svr4_current_sos_1): Add info parameter.
5780         (svr4_current_sos): Call get_svr4_info, pass info down to
5781         svr4_current_sos_1.
5782         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5783         get_svr4_info.
5784         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5785         get_svr4_info.
5786         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5787         to get_svr4_info.
5788         (probes_table_remove_objfile_probes): Likewise.
5789         (register_solib_event_probe): Add info parameter.
5790         (solist_update_incremental): Pass info parameter down to
5791         svr4_read_so_list.
5792         (disable_probes_interface): Add info parameter.
5793         (svr4_handle_solib_event): Pass current_program_space to
5794         get_svr4_info.  Adjust disable_probes_interface cleanup.
5795         (svr4_create_probe_breakpoints): Add info parameter, pass it
5796         down to register_solib_event_probe.
5797         (svr4_create_solib_event_breakpoints): Add info parameter,
5798         pass it down to svr4_create_probe_breakpoints.
5799         (enable_break): Pass info down to
5800         svr4_create_solib_event_breakpoints.
5801         (svr4_solib_create_inferior_hook): Pass current_program_space to
5802         get_svr4_info.
5803         (svr4_clear_solib): Likewise.
5804
5805 2019-04-22  Pedro Alves  <palves@redhat.com>
5806
5807         * solib-svr4.c (svr4_free_objfile_observer): New.
5808         (probe_and_action::objfile): New field.
5809         (probes_table_htab_remove_objfile_probes)
5810         (probes_table_remove_objfile_probes): New functions.
5811         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5812         in the new probe_and_action.  Don't store the probe in 'lookup'.
5813         (svr4_create_probe_breakpoints): Pass objfile to
5814         register_solib_event_probe.
5815         (_initialize_svr4_solib): Register a free_objfile observer.
5816
5817 2019-04-19  Tom Tromey  <tom@tromey.com>
5818
5819         * common/queue.h: Remove.
5820
5821 2019-04-19  Tom Tromey  <tom@tromey.com>
5822
5823         * event-loop.c: Don't include "common/queue.h".
5824
5825 2019-04-19  Tom Tromey  <tom@tromey.com>
5826
5827         * remote.c (remote_target): Use delete.
5828         * remote-notif.h: Include <list>, not "common/queue.h".
5829         (notif_client_p): Remove typedef.
5830         (remote_notif_state): Add constructor, destructor, initializer.
5831         <notif_queue>: Now a std::list.
5832         (remote_notif_state_xfree): Don't declare.
5833         * remote-notif.c (remote_notif_process, handle_notification)
5834         (remote_notif_state_allocate): Update.
5835         (~remote_notif_state): Rename from remote_notif_state_xfree.
5836
5837 2019-04-19  Tom Tromey  <tom@tromey.com>
5838
5839         * symfile.c (reread_symbols): Update.
5840         * objfiles.c (objfile_register_static_link)
5841         (objfile_lookup_static_link): Update
5842         (~objfile) Don't delete static_links.
5843         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5844
5845 2019-04-19  Tom Tromey  <tom@tromey.com>
5846
5847         * type-stack.h (struct type_stack) <insert>: Constify string.
5848         * type-stack.c (type_stack::insert): Constify string.
5849         * gdbtypes.h (lookup_template_type): Update.
5850         (address_space_name_to_int): Update.
5851         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5852         const.
5853         (lookup_template_type): Make name const.
5854         * c-exp.y: Update rules.
5855         (lex_one_token, classify_name, classify_inner_name)
5856         (c_print_token): Update.
5857         * p-exp.y: Update rules.
5858         (yylex): Update.
5859         * f-exp.y: Update rules.
5860         (yylex): Update.
5861         * d-exp.y: Update rules.
5862         (lex_one_token, classify_name, classify_inner_name): Update.
5863         * parse.c (write_dollar_variable, copy_name): Return std::string.
5864         * parser-defs.h (copy_name): Change return type.
5865         * m2-exp.y: Update rules.
5866         (yylex): Update.
5867         * go-exp.y (lex_one_token): Update.
5868         Update rules.
5869         (classify_unsafe_function, classify_packaged_name)
5870         (classify_name, yylex): Update.
5871
5872 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5873
5874         * configure.ac: add --enable-source-highlight switch.
5875         * configure: Regenerate.
5876         * top.c (print_gdb_version): plumb --enable-source-highlight
5877         status to "show configuration".
5878
5879 2019-04-19  Tom Tromey  <tromey@adacore.com>
5880
5881         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5882         Check ADA_TYPE_P.
5883         (empty_record, ada_template_to_fixed_record_type_1)
5884         (template_to_static_fixed_type)
5885         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5886         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5887         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5888         macros.
5889
5890 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5891
5892         PR symtab/24423:
5893         * source.c (print_source_lines_base): Advance "iter" when a
5894         control character is seen.
5895
5896 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5897
5898         * inferior.h (struct infcall_suspend_state_deleter):
5899         Catch exception in destructor to avoid crash.
5900
5901 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5902
5903         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5904         close to the add_com "shell".
5905
5906 2019-04-18  Tom Tromey  <tromey@adacore.com>
5907
5908         * process-stratum-target.h (class process_stratum_target)
5909         <stratum>: Add "final".
5910
5911 2019-04-17  Tom Tromey  <tromey@adacore.com>
5912
5913         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5914         against nullptr before use.
5915
5916 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5917
5918         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5919
5920 2019-04-17  Jim Wilson  <jimw@sifive.com>
5921             Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5924         code read might fail, assume 4-byte breakpoint in that case.
5925
5926 2019-04-15  Leszek Swirski  <leszeks@google.com>
5927
5928         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5929         rather than a hand-rolled POD check when checking for forced MEMORY
5930         classification.
5931
5932 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5933
5934         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5935         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5936         function.
5937         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5938         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5939         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5940         declaration.
5941
5942 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5943
5944         * aarch64-linux-nat.c
5945         (aarch64_linux_nat_target::thread_architecture): Add override.
5946         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5947         each VQ.
5948
5949 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5950
5951         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5952
5953 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5956         target types of size 96-bits, add some additional comments, and
5957         check that the builtin type we found was the correct size.
5958
5959 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5960
5961         * utils.c (prompt_for_continue): Don't restore the styling at the
5962         end, as applied_style has the wrong value.  This fixes styling in
5963         long lists of file names that are interrupted by the "Continue?"
5964         prompt.
5965
5966 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5967
5968         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5969         * c-lang.c (c_language_defn): Likewise.
5970         (cplus_language_defn): Likewise.
5971         (asm_language_defn): Likewise.
5972         (minimal_language_defn): Likewise.
5973         * d-lang.c (d_language_defn): Likewise.
5974         * f-lang.c (f_language_defn): Likewise.
5975         * go-lang.c (go_language_defn): Likewise.
5976         * language.c (unknown_language_defn): Likewise.
5977         (auto_language_defn): Likewise.
5978         * language.h (struct language_defn): Remove la_magic field.
5979         (LANG_MAGIC): Delete.
5980         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5981         * objc-lang.c (objc_language_defn): Likewise.
5982         * opencl-lang.c (opencl_language_defn): Likewise.
5983         * p-lang.c (pascal_language_defn): Likewise.
5984         * rust-lang.c (rust_language_defn): Likewise.
5985
5986 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5987
5988         * riscv-tdep.c (riscv_type_align): New function.
5989         (riscv_type_alignment): Delete.
5990         (riscv_arg_location): Use 'type_align'.
5991         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5992
5993 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5994
5995         * gdbtypes.c (type_align): A struct with no non-static fields also
5996         has alignment of 1.
5997
5998 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5999
6000         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6001         component to 0.
6002         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6003         member.
6004         (riscv_struct_info::analyse): New implementation using new
6005         analyse_inner member function.
6006         (riscv_struct_info::field_offset): New member function.
6007         (riscv_struct_info::m_offsets): New member variable.
6008         (riscv_struct_info::analyse_inner): New private member function,
6009         takes the old implementation of riscv_struct_info::analyse but
6010         extended to track field offsets.
6011         (riscv_call_arg_struct): Update the struct folding special cases
6012         to handle cases where empty C++ structs, which are non-zero
6013         length, are found.
6014         (riscv_arg_location): Initialise the length of each location, a
6015         non-zero length now indicates the location is in use.
6016         (riscv_push_dummy_call): Allow for the first location having a
6017         non-zero offset when setting up arguments.
6018         (riscv_return_value): Likewise, but for return values.
6019
6020 2019-04-11  Tom Tromey  <tromey@adacore.com>
6021
6022         * utils.c (internal_vproblem): Make "msg" const.
6023
6024 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6025
6026         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6027         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6028         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6029         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6030
6031 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6032
6033         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6034         function.
6035         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6036         of amd64_collect_native_gregset.
6037         (amd64_linux_nat_target::store_registers): Likewise.
6038
6039 2019-04-10  Tom Tromey  <tom@tromey.com>
6040
6041         * symtab.c (lookup_global_symbol_from_objfile)
6042         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6043         * objfiles.h (class separate_debug_iterator): New.
6044         (class separate_debug_range): New.
6045         (struct objfile) <separate_debug_objfiles>: New method.
6046         (objfile_separate_debug_iterate): Don't declare.
6047         * objfiles.c (separate_debug_iterator::operator++): Rename from
6048         objfile_separate_debug_iterate.
6049         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6050         iterator.
6051         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6052         iterator.
6053
6054 2019-04-10  Tom Tromey  <tom@tromey.com>
6055
6056         * symfile.c (reread_symbols): Remove old comment.
6057         * objfiles.c (free_all_objfiles): Fix a typo.
6058
6059 2019-04-10  Tom Tromey  <tom@tromey.com>
6060
6061         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6062         * minsyms.c (lookup_minimal_symbol): Use foreach.
6063         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6064         (lookup_minimal_symbol_solib_trampoline): Likewise.
6065         * symfile.c (reread_symbols): Use foreach.
6066
6067 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6068             Tom Tromey  <tromey@adacore.com>
6069
6070         PR rust/24414:
6071         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6072         (rust_lex_int_test): Change "value" to be LONGEST.
6073         (rust_lex_tests): Add test for long integer literal.
6074
6075 2019-04-09  Tom Tromey  <tromey@adacore.com>
6076
6077         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6078         to bool.
6079         (extended_remote_target::attach): Update.
6080         (remote_target::remote_notice_new_inferior): Update.
6081         (remote_target::add_current_inferior_and_thread): Update.
6082         * inferior.c (exit_inferior_1): Use "false".
6083         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6084
6085 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6086
6087         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6088         the "start" command.
6089
6090 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6091
6092         * python/py-inferior.c (infpy_thread_from_thread_handle):
6093         Adjust comments to reflect renaming of thread_from_thread_handle
6094         to thread_from_handle.  Adjust keywords.  Fix type error message.
6095         (inferior_object_methods): Add thread_from_handle.  Retain
6096         thread_from_thread_handle, but mark it as deprecated.
6097
6098 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6099
6100         * gdbthread.h (find_thread_by_handle): Revise declaration.
6101         * thread.c (find_thread_by_handle): Likewise.  Adjust
6102         implementation too.
6103         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6104         support for buffer objects as handles.
6105
6106 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6107
6108         * python/py-infthread.c (thpy_thread_handle): New function.
6109         (thread_object_methods): Register thpy_thread_handle.
6110
6111 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6112
6113         * gdbthread.h (thread_to_thread_handle): Declare.
6114         * thread.c (gdbtypes.h): Include.
6115         (thread_to_thread_handle): New function.
6116
6117         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6118         (target_thread_info_to_thread_handle): Declare.
6119         * target.c (target_thread_info_to_thread_handle): New function.
6120         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6121         * target-delegates.c: Regenerate.
6122
6123         * linux-thread-db.c (class thread_db_target): Add method
6124         thread_info_to_thread_handle.
6125         (thread_db_target::thread_info_to_thread_handle): Define.
6126         * remote.c (class remote_target): Add new method
6127         thread_info_to_thread_handle.
6128         (remote_target::thread_info_to_thread_handle): Define.
6129
6130 2019-04-08  Pedro Alves  <palves@redhat.com>
6131
6132         * common/common-exceptions.c (throw_exception): Don't create
6133         named object to throw; throw directly.
6134         (throw_it): Likewise.  Don't initialize gdb_exception::message
6135         here, with new; pass FMT and AP to the ctor instead.
6136         * common/common-exceptions.h: Include <string>.
6137         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6138         const char *, va_list)): New ctor.  Use std::make_shared.
6139         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6140         errors)): Delete.
6141         (gdb_exception_error::gdb_exception_error(enum errors, const char
6142         *, va_list)): New.
6143         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6144         Add assertion.
6145         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6146         errors)): Delete.
6147         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6148         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6149         Add assertion.
6150
6151 2019-04-08  Tom Tromey  <tom@tromey.com>
6152
6153         * valops.c (value_rtti_indirect_type): Replace throw_exception
6154         with throw.
6155         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6156         with throw.
6157         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6158         throw.
6159         * target.c (target_translate_tls_address): Replace throw_exception
6160         with throw.
6161         * stack.c (frame_apply_command_count): Replace throw_exception
6162         with throw.
6163         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6164         throw.
6165         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6166         with throw.
6167         * rs6000-tdep.c (rs6000_frame_cache)
6168         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6169         * remote.c: Replace throw_exception with throw.
6170         * record-full.c (record_full_message, record_full_wait_1)
6171         (record_full_restore): Replace throw_exception with throw.
6172         * record-btrace.c:
6173         (get_thread_current_frame_id, record_btrace_start_replaying)
6174         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6175         (cmd_record_btrace_start): Replace throw_exception with throw.
6176         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6177         throw.
6178         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6179         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6180         * linespec.c:
6181         (find_linespec_symbols): Replace throw_exception with throw.
6182         * infrun.c (displaced_step_prepare, resume): Replace
6183         throw_exception with throw.
6184         * infcmd.c (post_create_inferior): Replace throw_exception with
6185         throw.
6186         * inf-loop.c (inferior_event_handler): Replace throw_exception
6187         with throw.
6188         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6189         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6190         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6191         (get_prev_frame_always, get_frame_pc_if_available)
6192         (get_frame_address_in_block_if_available, get_frame_language):
6193         Replace throw_exception with throw.
6194         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6195         throw_exception with throw.
6196         * eval.c (fetch_subexp_value, evaluate_var_value)
6197         (evaluate_funcall, evaluate_subexp_standard): Replace
6198         throw_exception with throw.
6199         * dwarf2loc.c (call_site_find_chain)
6200         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6201         Replace throw_exception with throw.
6202         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6203         with throw.
6204         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6205         throw.
6206         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6207         * completer.c (complete_line_internal): Replace throw_exception
6208         with throw.
6209         * compile/compile-object-run.c (compile_object_run): Replace
6210         throw_exception with throw.
6211         * cli/cli-script.c (process_next_line): Replace throw_exception
6212         with throw.
6213         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6214         (btrace_enable, btrace_maint_update_pt_packets): Replace
6215         throw_exception with throw.
6216         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6217         throw_exception with throw.
6218         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6219         throw_exception with throw.
6220         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6221         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6222         * aarch64-tdep.c (aarch64_make_prologue_cache)
6223         (aarch64_make_stub_cache): Replace throw_exception with throw.
6224
6225 2019-04-08  Tom Tromey  <tom@tromey.com>
6226
6227         * common/common-exceptions.c (throw_exception): Rename from
6228         throw_exception_cxx.  Remove old copy.  Make argument const.
6229         (throw_it): Create and throw exception objects directly.
6230         * common/common-exceptions.h (throw_exception): Make argument
6231         const.
6232         (struct gdb_exception_error): Add constructor.
6233         (struct gdb_exception_quit): Add constructor.
6234
6235 2019-04-08  Tom Tromey  <tom@tromey.com>
6236
6237         * common/common-exceptions.h (exception_rethrow): Don't declare.
6238         (TRY_SJLJ): Update comment.
6239         (TRY, CATCH, END_CATCH): Remove.
6240         * common/common-exceptions.c (exception_rethrow): Remove.
6241
6242 2019-04-08  Tom Tromey  <tom@tromey.com>
6243
6244         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6245         Remove.
6246         (gdb_exception_error): Rename from
6247         gdb_exception_RETURN_MASK_ERROR.
6248         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6249         (gdb_quit_bad_alloc): Update.
6250         * aarch64-tdep.c: Update.
6251         * ada-lang.c: Update.
6252         * ada-typeprint.c: Update.
6253         * ada-valprint.c: Update.
6254         * amd64-tdep.c: Update.
6255         * arch-utils.c: Update.
6256         * break-catch-throw.c: Update.
6257         * breakpoint.c: Update.
6258         * btrace.c: Update.
6259         * c-varobj.c: Update.
6260         * cli/cli-cmds.c: Update.
6261         * cli/cli-interp.c: Update.
6262         * cli/cli-script.c: Update.
6263         * common/common-exceptions.c: Update.
6264         * common/new-op.c: Update.
6265         * common/selftest.c: Update.
6266         * compile/compile-c-symbols.c: Update.
6267         * compile/compile-cplus-symbols.c: Update.
6268         * compile/compile-object-load.c: Update.
6269         * compile/compile-object-run.c: Update.
6270         * completer.c: Update.
6271         * corelow.c: Update.
6272         * cp-abi.c: Update.
6273         * cp-support.c: Update.
6274         * cp-valprint.c: Update.
6275         * darwin-nat.c: Update.
6276         * disasm-selftests.c: Update.
6277         * dtrace-probe.c: Update.
6278         * dwarf-index-cache.c: Update.
6279         * dwarf-index-write.c: Update.
6280         * dwarf2-frame-tailcall.c: Update.
6281         * dwarf2-frame.c: Update.
6282         * dwarf2loc.c: Update.
6283         * dwarf2read.c: Update.
6284         * eval.c: Update.
6285         * event-loop.c: Update.
6286         * event-top.c: Update.
6287         * exec.c: Update.
6288         * f-valprint.c: Update.
6289         * fbsd-tdep.c: Update.
6290         * frame-unwind.c: Update.
6291         * frame.c: Update.
6292         * gdbtypes.c: Update.
6293         * gnu-v3-abi.c: Update.
6294         * guile/guile-internal.h: Update.
6295         * guile/scm-block.c: Update.
6296         * guile/scm-breakpoint.c: Update.
6297         * guile/scm-cmd.c: Update.
6298         * guile/scm-disasm.c: Update.
6299         * guile/scm-frame.c: Update.
6300         * guile/scm-lazy-string.c: Update.
6301         * guile/scm-math.c: Update.
6302         * guile/scm-param.c: Update.
6303         * guile/scm-ports.c: Update.
6304         * guile/scm-pretty-print.c: Update.
6305         * guile/scm-symbol.c: Update.
6306         * guile/scm-symtab.c: Update.
6307         * guile/scm-type.c: Update.
6308         * guile/scm-value.c: Update.
6309         * i386-linux-tdep.c: Update.
6310         * i386-tdep.c: Update.
6311         * inf-loop.c: Update.
6312         * infcall.c: Update.
6313         * infcmd.c: Update.
6314         * infrun.c: Update.
6315         * jit.c: Update.
6316         * language.c: Update.
6317         * linespec.c: Update.
6318         * linux-fork.c: Update.
6319         * linux-nat.c: Update.
6320         * linux-tdep.c: Update.
6321         * linux-thread-db.c: Update.
6322         * main.c: Update.
6323         * mi/mi-cmd-break.c: Update.
6324         * mi/mi-cmd-stack.c: Update.
6325         * mi/mi-interp.c: Update.
6326         * mi/mi-main.c: Update.
6327         * objc-lang.c: Update.
6328         * p-valprint.c: Update.
6329         * parse.c: Update.
6330         * ppc-linux-tdep.c: Update.
6331         * printcmd.c: Update.
6332         * python/py-arch.c: Update.
6333         * python/py-breakpoint.c: Update.
6334         * python/py-cmd.c: Update.
6335         * python/py-finishbreakpoint.c: Update.
6336         * python/py-frame.c: Update.
6337         * python/py-framefilter.c: Update.
6338         * python/py-gdb-readline.c: Update.
6339         * python/py-inferior.c: Update.
6340         * python/py-infthread.c: Update.
6341         * python/py-lazy-string.c: Update.
6342         * python/py-linetable.c: Update.
6343         * python/py-objfile.c: Update.
6344         * python/py-param.c: Update.
6345         * python/py-prettyprint.c: Update.
6346         * python/py-progspace.c: Update.
6347         * python/py-record-btrace.c: Update.
6348         * python/py-record.c: Update.
6349         * python/py-symbol.c: Update.
6350         * python/py-type.c: Update.
6351         * python/py-unwind.c: Update.
6352         * python/py-utils.c: Update.
6353         * python/py-value.c: Update.
6354         * python/python.c: Update.
6355         * record-btrace.c: Update.
6356         * record-full.c: Update.
6357         * remote-fileio.c: Update.
6358         * remote.c: Update.
6359         * riscv-tdep.c: Update.
6360         * rs6000-aix-tdep.c: Update.
6361         * rs6000-tdep.c: Update.
6362         * rust-exp.y: Update.
6363         * rust-lang.c: Update.
6364         * s390-tdep.c: Update.
6365         * selftest-arch.c: Update.
6366         * solib-dsbt.c: Update.
6367         * solib-frv.c: Update.
6368         * solib-spu.c: Update.
6369         * solib-svr4.c: Update.
6370         * solib.c: Update.
6371         * sparc64-linux-tdep.c: Update.
6372         * stack.c: Update.
6373         * symfile-mem.c: Update.
6374         * symmisc.c: Update.
6375         * target.c: Update.
6376         * thread.c: Update.
6377         * top.c: Update.
6378         * tracefile-tfile.c: Update.
6379         * tui/tui.c: Update.
6380         * typeprint.c: Update.
6381         * unittests/cli-utils-selftests.c: Update.
6382         * unittests/parse-connection-spec-selftests.c: Update.
6383         * valops.c: Update.
6384         * valprint.c: Update.
6385         * value.c: Update.
6386         * varobj.c: Update.
6387         * windows-nat.c: Update.
6388         * x86-linux-nat.c: Update.
6389         * xml-support.c: Update.
6390
6391 2019-04-08  Tom Tromey  <tom@tromey.com>
6392
6393         * xml-support.c: Use C++ exception handling.
6394         * x86-linux-nat.c: Use C++ exception handling.
6395         * windows-nat.c: Use C++ exception handling.
6396         * varobj.c: Use C++ exception handling.
6397         * value.c: Use C++ exception handling.
6398         * valprint.c: Use C++ exception handling.
6399         * valops.c: Use C++ exception handling.
6400         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6401         handling.
6402         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6403         * typeprint.c: Use C++ exception handling.
6404         * tui/tui.c: Use C++ exception handling.
6405         * tracefile-tfile.c: Use C++ exception handling.
6406         * top.c: Use C++ exception handling.
6407         * thread.c: Use C++ exception handling.
6408         * target.c: Use C++ exception handling.
6409         * symmisc.c: Use C++ exception handling.
6410         * symfile-mem.c: Use C++ exception handling.
6411         * stack.c: Use C++ exception handling.
6412         * sparc64-linux-tdep.c: Use C++ exception handling.
6413         * solib.c: Use C++ exception handling.
6414         * solib-svr4.c: Use C++ exception handling.
6415         * solib-spu.c: Use C++ exception handling.
6416         * solib-frv.c: Use C++ exception handling.
6417         * solib-dsbt.c: Use C++ exception handling.
6418         * selftest-arch.c: Use C++ exception handling.
6419         * s390-tdep.c: Use C++ exception handling.
6420         * rust-lang.c: Use C++ exception handling.
6421         * rust-exp.y: Use C++ exception handling.
6422         * rs6000-tdep.c: Use C++ exception handling.
6423         * rs6000-aix-tdep.c: Use C++ exception handling.
6424         * riscv-tdep.c: Use C++ exception handling.
6425         * remote.c: Use C++ exception handling.
6426         * remote-fileio.c: Use C++ exception handling.
6427         * record-full.c: Use C++ exception handling.
6428         * record-btrace.c: Use C++ exception handling.
6429         * python/python.c: Use C++ exception handling.
6430         * python/py-value.c: Use C++ exception handling.
6431         * python/py-utils.c: Use C++ exception handling.
6432         * python/py-unwind.c: Use C++ exception handling.
6433         * python/py-type.c: Use C++ exception handling.
6434         * python/py-symbol.c: Use C++ exception handling.
6435         * python/py-record.c: Use C++ exception handling.
6436         * python/py-record-btrace.c: Use C++ exception handling.
6437         * python/py-progspace.c: Use C++ exception handling.
6438         * python/py-prettyprint.c: Use C++ exception handling.
6439         * python/py-param.c: Use C++ exception handling.
6440         * python/py-objfile.c: Use C++ exception handling.
6441         * python/py-linetable.c: Use C++ exception handling.
6442         * python/py-lazy-string.c: Use C++ exception handling.
6443         * python/py-infthread.c: Use C++ exception handling.
6444         * python/py-inferior.c: Use C++ exception handling.
6445         * python/py-gdb-readline.c: Use C++ exception handling.
6446         * python/py-framefilter.c: Use C++ exception handling.
6447         * python/py-frame.c: Use C++ exception handling.
6448         * python/py-finishbreakpoint.c: Use C++ exception handling.
6449         * python/py-cmd.c: Use C++ exception handling.
6450         * python/py-breakpoint.c: Use C++ exception handling.
6451         * python/py-arch.c: Use C++ exception handling.
6452         * printcmd.c: Use C++ exception handling.
6453         * ppc-linux-tdep.c: Use C++ exception handling.
6454         * parse.c: Use C++ exception handling.
6455         * p-valprint.c: Use C++ exception handling.
6456         * objc-lang.c: Use C++ exception handling.
6457         * mi/mi-main.c: Use C++ exception handling.
6458         * mi/mi-interp.c: Use C++ exception handling.
6459         * mi/mi-cmd-stack.c: Use C++ exception handling.
6460         * mi/mi-cmd-break.c: Use C++ exception handling.
6461         * main.c: Use C++ exception handling.
6462         * linux-thread-db.c: Use C++ exception handling.
6463         * linux-tdep.c: Use C++ exception handling.
6464         * linux-nat.c: Use C++ exception handling.
6465         * linux-fork.c: Use C++ exception handling.
6466         * linespec.c: Use C++ exception handling.
6467         * language.c: Use C++ exception handling.
6468         * jit.c: Use C++ exception handling.
6469         * infrun.c: Use C++ exception handling.
6470         * infcmd.c: Use C++ exception handling.
6471         * infcall.c: Use C++ exception handling.
6472         * inf-loop.c: Use C++ exception handling.
6473         * i386-tdep.c: Use C++ exception handling.
6474         * i386-linux-tdep.c: Use C++ exception handling.
6475         * guile/scm-value.c: Use C++ exception handling.
6476         * guile/scm-type.c: Use C++ exception handling.
6477         * guile/scm-symtab.c: Use C++ exception handling.
6478         * guile/scm-symbol.c: Use C++ exception handling.
6479         * guile/scm-pretty-print.c: Use C++ exception handling.
6480         * guile/scm-ports.c: Use C++ exception handling.
6481         * guile/scm-param.c: Use C++ exception handling.
6482         * guile/scm-math.c: Use C++ exception handling.
6483         * guile/scm-lazy-string.c: Use C++ exception handling.
6484         * guile/scm-frame.c: Use C++ exception handling.
6485         * guile/scm-disasm.c: Use C++ exception handling.
6486         * guile/scm-cmd.c: Use C++ exception handling.
6487         * guile/scm-breakpoint.c: Use C++ exception handling.
6488         * guile/scm-block.c: Use C++ exception handling.
6489         * guile/guile-internal.h: Use C++ exception handling.
6490         * gnu-v3-abi.c: Use C++ exception handling.
6491         * gdbtypes.c: Use C++ exception handling.
6492         * frame.c: Use C++ exception handling.
6493         * frame-unwind.c: Use C++ exception handling.
6494         * fbsd-tdep.c: Use C++ exception handling.
6495         * f-valprint.c: Use C++ exception handling.
6496         * exec.c: Use C++ exception handling.
6497         * event-top.c: Use C++ exception handling.
6498         * event-loop.c: Use C++ exception handling.
6499         * eval.c: Use C++ exception handling.
6500         * dwarf2read.c: Use C++ exception handling.
6501         * dwarf2loc.c: Use C++ exception handling.
6502         * dwarf2-frame.c: Use C++ exception handling.
6503         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6504         * dwarf-index-write.c: Use C++ exception handling.
6505         * dwarf-index-cache.c: Use C++ exception handling.
6506         * dtrace-probe.c: Use C++ exception handling.
6507         * disasm-selftests.c: Use C++ exception handling.
6508         * darwin-nat.c: Use C++ exception handling.
6509         * cp-valprint.c: Use C++ exception handling.
6510         * cp-support.c: Use C++ exception handling.
6511         * cp-abi.c: Use C++ exception handling.
6512         * corelow.c: Use C++ exception handling.
6513         * completer.c: Use C++ exception handling.
6514         * compile/compile-object-run.c: Use C++ exception handling.
6515         * compile/compile-object-load.c: Use C++ exception handling.
6516         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6517         * compile/compile-c-symbols.c: Use C++ exception handling.
6518         * common/selftest.c: Use C++ exception handling.
6519         * common/new-op.c: Use C++ exception handling.
6520         * cli/cli-script.c: Use C++ exception handling.
6521         * cli/cli-interp.c: Use C++ exception handling.
6522         * cli/cli-cmds.c: Use C++ exception handling.
6523         * c-varobj.c: Use C++ exception handling.
6524         * btrace.c: Use C++ exception handling.
6525         * breakpoint.c: Use C++ exception handling.
6526         * break-catch-throw.c: Use C++ exception handling.
6527         * arch-utils.c: Use C++ exception handling.
6528         * amd64-tdep.c: Use C++ exception handling.
6529         * ada-valprint.c: Use C++ exception handling.
6530         * ada-typeprint.c: Use C++ exception handling.
6531         * ada-lang.c: Use C++ exception handling.
6532         * aarch64-tdep.c: Use C++ exception handling.
6533
6534 2019-04-08  Tom Tromey  <tom@tromey.com>
6535
6536         * xml-support.c (gdb_xml_parser::parse): Update.
6537         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6538         * value.c (show_convenience): Update.
6539         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6540         (test_parse_flags_qcs): Update.
6541         * thread.c (thr_try_catch_cmd): Update.
6542         * target.c (target_translate_tls_address): Update.
6543         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6544         (info_frame_command_core, frame_apply_command_count): Update.
6545         * rust-exp.y (rust_lex_exception_test): Update.
6546         * riscv-tdep.c (riscv_print_one_register_info): Update.
6547         * remote.c (remote_target::enable_btrace): Update.
6548         * record-btrace.c (record_btrace_enable_warn): Update.
6549         * python/py-utils.c (gdbpy_convert_exception): Update.
6550         * printcmd.c (do_one_display, print_variable_and_value): Update.
6551         * mi/mi-main.c (mi_print_exception): Update.
6552         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6553         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6554         * linux-nat.c (linux_nat_target::attach): Update.
6555         * linux-fork.c (class scoped_switch_fork_info): Update.
6556         * infrun.c (displaced_step_prepare): Update.
6557         * infcall.c (call_function_by_hand_dummy): Update.
6558         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6559         * gnu-v3-abi.c (print_one_vtable): Update.
6560         * frame.c (get_prev_frame_always): Update.
6561         * f-valprint.c (info_common_command_for_block): Update.
6562         * exec.c (try_open_exec_file): Update.
6563         * exceptions.c (print_exception, exception_print)
6564         (exception_fprintf, exception_print_same): Update.
6565         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6566         * dwarf-index-cache.c (index_cache::store)
6567         (index_cache::lookup_gdb_index): Update.
6568         * darwin-nat.c (maybe_cache_shell): Update.
6569         * cp-valprint.c (cp_print_value_fields): Update.
6570         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6571         (gcc_cplus_symbol_address): Update.
6572         * compile/compile-c-symbols.c (gcc_convert_symbol)
6573         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6574         * common/selftest.c: Update.
6575         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6576         a std::string.
6577         (exception_try_scope_entry, exception_try_scope_exit): Don't
6578         declare.
6579         (struct exception_try_scope): Remove.
6580         (TRY): Don't use exception_try_scope.
6581         (struct gdb_exception): Add constructor, operator=.
6582         <what>: New method.
6583         (struct gdb_exception_RETURN_MASK_ALL)
6584         (struct gdb_exception_RETURN_MASK_ERROR)
6585         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6586         (struct gdb_quit_bad_alloc): Update.
6587         * common/common-exceptions.c (exception_none): Change
6588         initializer.
6589         (struct catcher) <state, exception>: Initialize inline.
6590         <prev>: Remove member.
6591         (current_catcher): Remove.
6592         (catchers): New global.
6593         (exceptions_state_mc_init): Simplify.
6594         (catcher_pop): Remove.
6595         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6596         (try_scope_depth, exception_try_scope_entry)
6597         (exception_try_scope_exit): Remove.
6598         (throw_exception_sjlj): Update.
6599         (exception_messages, exception_messages_size): Remove.
6600         (throw_it): Simplify.
6601         (gdb_exception_sliced_copy): Remove.
6602         (throw_exception_cxx): Update.
6603         * cli/cli-script.c (script_from_file): Update.
6604         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6605         Update.
6606         * ada-valprint.c (ada_val_print): Update.
6607         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6608         (create_excep_cond_exprs): Update.
6609
6610 2019-04-08  Tom Tromey  <tom@tromey.com>
6611
6612         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6613         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6614         (TRY, CATCH, END_CATCH): Remove some definitions.
6615         * common/common-exceptions.c: Don't use GDB_XCPT.
6616         (catcher_list_size): Remove.
6617         (throw_exception, throw_it): Simplify.
6618
6619 2019-04-05  Tom Tromey  <tom@tromey.com>
6620
6621         Revert the header-sorting patch.
6622         * ft32-tdep.c: Revert.
6623         * frv-tdep.c: Revert.
6624         * frv-linux-tdep.c: Revert.
6625         * frame.c: Revert.
6626         * frame-unwind.c: Revert.
6627         * frame-base.c: Revert.
6628         * fork-child.c: Revert.
6629         * findvar.c: Revert.
6630         * findcmd.c: Revert.
6631         * filesystem.c: Revert.
6632         * filename-seen-cache.h: Revert.
6633         * filename-seen-cache.c: Revert.
6634         * fbsd-tdep.c: Revert.
6635         * fbsd-nat.h: Revert.
6636         * fbsd-nat.c: Revert.
6637         * f-valprint.c: Revert.
6638         * f-typeprint.c: Revert.
6639         * f-lang.c: Revert.
6640         * extension.h: Revert.
6641         * extension.c: Revert.
6642         * extension-priv.h: Revert.
6643         * expprint.c: Revert.
6644         * exec.h: Revert.
6645         * exec.c: Revert.
6646         * exceptions.c: Revert.
6647         * event-top.c: Revert.
6648         * event-loop.c: Revert.
6649         * eval.c: Revert.
6650         * elfread.c: Revert.
6651         * dwarf2read.h: Revert.
6652         * dwarf2read.c: Revert.
6653         * dwarf2loc.c: Revert.
6654         * dwarf2expr.h: Revert.
6655         * dwarf2expr.c: Revert.
6656         * dwarf2-frame.c: Revert.
6657         * dwarf2-frame-tailcall.c: Revert.
6658         * dwarf-index-write.h: Revert.
6659         * dwarf-index-write.c: Revert.
6660         * dwarf-index-common.c: Revert.
6661         * dwarf-index-cache.h: Revert.
6662         * dwarf-index-cache.c: Revert.
6663         * dummy-frame.c: Revert.
6664         * dtrace-probe.c: Revert.
6665         * disasm.h: Revert.
6666         * disasm.c: Revert.
6667         * disasm-selftests.c: Revert.
6668         * dictionary.c: Revert.
6669         * dicos-tdep.c: Revert.
6670         * demangle.c: Revert.
6671         * dcache.h: Revert.
6672         * dcache.c: Revert.
6673         * darwin-nat.h: Revert.
6674         * darwin-nat.c: Revert.
6675         * darwin-nat-info.c: Revert.
6676         * d-valprint.c: Revert.
6677         * d-namespace.c: Revert.
6678         * d-lang.c: Revert.
6679         * ctf.c: Revert.
6680         * csky-tdep.c: Revert.
6681         * csky-linux-tdep.c: Revert.
6682         * cris-tdep.c: Revert.
6683         * cris-linux-tdep.c: Revert.
6684         * cp-valprint.c: Revert.
6685         * cp-support.c: Revert.
6686         * cp-namespace.c: Revert.
6687         * cp-abi.c: Revert.
6688         * corelow.c: Revert.
6689         * corefile.c: Revert.
6690         * continuations.c: Revert.
6691         * completer.h: Revert.
6692         * completer.c: Revert.
6693         * complaints.c: Revert.
6694         * coffread.c: Revert.
6695         * coff-pe-read.c: Revert.
6696         * cli-out.h: Revert.
6697         * cli-out.c: Revert.
6698         * charset.c: Revert.
6699         * c-varobj.c: Revert.
6700         * c-valprint.c: Revert.
6701         * c-typeprint.c: Revert.
6702         * c-lang.c: Revert.
6703         * buildsym.c: Revert.
6704         * buildsym-legacy.c: Revert.
6705         * build-id.h: Revert.
6706         * build-id.c: Revert.
6707         * btrace.c: Revert.
6708         * bsd-uthread.c: Revert.
6709         * breakpoint.h: Revert.
6710         * breakpoint.c: Revert.
6711         * break-catch-throw.c: Revert.
6712         * break-catch-syscall.c: Revert.
6713         * break-catch-sig.c: Revert.
6714         * blockframe.c: Revert.
6715         * block.c: Revert.
6716         * bfin-tdep.c: Revert.
6717         * bfin-linux-tdep.c: Revert.
6718         * bfd-target.c: Revert.
6719         * bcache.c: Revert.
6720         * ax-general.c: Revert.
6721         * ax-gdb.h: Revert.
6722         * ax-gdb.c: Revert.
6723         * avr-tdep.c: Revert.
6724         * auxv.c: Revert.
6725         * auto-load.c: Revert.
6726         * arm-wince-tdep.c: Revert.
6727         * arm-tdep.c: Revert.
6728         * arm-symbian-tdep.c: Revert.
6729         * arm-pikeos-tdep.c: Revert.
6730         * arm-obsd-tdep.c: Revert.
6731         * arm-nbsd-tdep.c: Revert.
6732         * arm-nbsd-nat.c: Revert.
6733         * arm-linux-tdep.c: Revert.
6734         * arm-linux-nat.c: Revert.
6735         * arm-fbsd-tdep.c: Revert.
6736         * arm-fbsd-nat.c: Revert.
6737         * arm-bsd-tdep.c: Revert.
6738         * arch-utils.c: Revert.
6739         * arc-tdep.c: Revert.
6740         * arc-newlib-tdep.c: Revert.
6741         * annotate.h: Revert.
6742         * annotate.c: Revert.
6743         * amd64-windows-tdep.c: Revert.
6744         * amd64-windows-nat.c: Revert.
6745         * amd64-tdep.c: Revert.
6746         * amd64-sol2-tdep.c: Revert.
6747         * amd64-obsd-tdep.c: Revert.
6748         * amd64-obsd-nat.c: Revert.
6749         * amd64-nbsd-tdep.c: Revert.
6750         * amd64-nbsd-nat.c: Revert.
6751         * amd64-nat.c: Revert.
6752         * amd64-linux-tdep.c: Revert.
6753         * amd64-linux-nat.c: Revert.
6754         * amd64-fbsd-tdep.c: Revert.
6755         * amd64-fbsd-nat.c: Revert.
6756         * amd64-dicos-tdep.c: Revert.
6757         * amd64-darwin-tdep.c: Revert.
6758         * amd64-bsd-nat.c: Revert.
6759         * alpha-tdep.c: Revert.
6760         * alpha-obsd-tdep.c: Revert.
6761         * alpha-nbsd-tdep.c: Revert.
6762         * alpha-mdebug-tdep.c: Revert.
6763         * alpha-linux-tdep.c: Revert.
6764         * alpha-linux-nat.c: Revert.
6765         * alpha-bsd-tdep.c: Revert.
6766         * alpha-bsd-nat.c: Revert.
6767         * aix-thread.c: Revert.
6768         * agent.c: Revert.
6769         * addrmap.c: Revert.
6770         * ada-varobj.c: Revert.
6771         * ada-valprint.c: Revert.
6772         * ada-typeprint.c: Revert.
6773         * ada-tasks.c: Revert.
6774         * ada-lang.c: Revert.
6775         * aarch64-tdep.c: Revert.
6776         * aarch64-ravenscar-thread.c: Revert.
6777         * aarch64-newlib-tdep.c: Revert.
6778         * aarch64-linux-tdep.c: Revert.
6779         * aarch64-linux-nat.c: Revert.
6780         * aarch64-fbsd-tdep.c: Revert.
6781         * aarch64-fbsd-nat.c: Revert.
6782         * aarch32-linux-nat.c: Revert.
6783
6784 2019-04-05  Tom Tromey  <tom@tromey.com>
6785
6786         * ft32-tdep.c: Sort headers.
6787         * frv-tdep.c: Sort headers.
6788         * frv-linux-tdep.c: Sort headers.
6789         * frame.c: Sort headers.
6790         * frame-unwind.c: Sort headers.
6791         * frame-base.c: Sort headers.
6792         * fork-child.c: Sort headers.
6793         * findvar.c: Sort headers.
6794         * findcmd.c: Sort headers.
6795         * filesystem.c: Sort headers.
6796         * filename-seen-cache.h: Sort headers.
6797         * filename-seen-cache.c: Sort headers.
6798         * fbsd-tdep.c: Sort headers.
6799         * fbsd-nat.h: Sort headers.
6800         * fbsd-nat.c: Sort headers.
6801         * f-valprint.c: Sort headers.
6802         * f-typeprint.c: Sort headers.
6803         * f-lang.c: Sort headers.
6804         * extension.h: Sort headers.
6805         * extension.c: Sort headers.
6806         * extension-priv.h: Sort headers.
6807         * expprint.c: Sort headers.
6808         * exec.h: Sort headers.
6809         * exec.c: Sort headers.
6810         * exceptions.c: Sort headers.
6811         * event-top.c: Sort headers.
6812         * event-loop.c: Sort headers.
6813         * eval.c: Sort headers.
6814         * elfread.c: Sort headers.
6815         * dwarf2read.h: Sort headers.
6816         * dwarf2read.c: Sort headers.
6817         * dwarf2loc.c: Sort headers.
6818         * dwarf2expr.h: Sort headers.
6819         * dwarf2expr.c: Sort headers.
6820         * dwarf2-frame.c: Sort headers.
6821         * dwarf2-frame-tailcall.c: Sort headers.
6822         * dwarf-index-write.h: Sort headers.
6823         * dwarf-index-write.c: Sort headers.
6824         * dwarf-index-common.c: Sort headers.
6825         * dwarf-index-cache.h: Sort headers.
6826         * dwarf-index-cache.c: Sort headers.
6827         * dummy-frame.c: Sort headers.
6828         * dtrace-probe.c: Sort headers.
6829         * disasm.h: Sort headers.
6830         * disasm.c: Sort headers.
6831         * disasm-selftests.c: Sort headers.
6832         * dictionary.c: Sort headers.
6833         * dicos-tdep.c: Sort headers.
6834         * demangle.c: Sort headers.
6835         * dcache.h: Sort headers.
6836         * dcache.c: Sort headers.
6837         * darwin-nat.h: Sort headers.
6838         * darwin-nat.c: Sort headers.
6839         * darwin-nat-info.c: Sort headers.
6840         * d-valprint.c: Sort headers.
6841         * d-namespace.c: Sort headers.
6842         * d-lang.c: Sort headers.
6843         * ctf.c: Sort headers.
6844         * csky-tdep.c: Sort headers.
6845         * csky-linux-tdep.c: Sort headers.
6846         * cris-tdep.c: Sort headers.
6847         * cris-linux-tdep.c: Sort headers.
6848         * cp-valprint.c: Sort headers.
6849         * cp-support.c: Sort headers.
6850         * cp-namespace.c: Sort headers.
6851         * cp-abi.c: Sort headers.
6852         * corelow.c: Sort headers.
6853         * corefile.c: Sort headers.
6854         * continuations.c: Sort headers.
6855         * completer.h: Sort headers.
6856         * completer.c: Sort headers.
6857         * complaints.c: Sort headers.
6858         * coffread.c: Sort headers.
6859         * coff-pe-read.c: Sort headers.
6860         * cli-out.h: Sort headers.
6861         * cli-out.c: Sort headers.
6862         * charset.c: Sort headers.
6863         * c-varobj.c: Sort headers.
6864         * c-valprint.c: Sort headers.
6865         * c-typeprint.c: Sort headers.
6866         * c-lang.c: Sort headers.
6867         * buildsym.c: Sort headers.
6868         * buildsym-legacy.c: Sort headers.
6869         * build-id.h: Sort headers.
6870         * build-id.c: Sort headers.
6871         * btrace.c: Sort headers.
6872         * bsd-uthread.c: Sort headers.
6873         * breakpoint.h: Sort headers.
6874         * breakpoint.c: Sort headers.
6875         * break-catch-throw.c: Sort headers.
6876         * break-catch-syscall.c: Sort headers.
6877         * break-catch-sig.c: Sort headers.
6878         * blockframe.c: Sort headers.
6879         * block.c: Sort headers.
6880         * bfin-tdep.c: Sort headers.
6881         * bfin-linux-tdep.c: Sort headers.
6882         * bfd-target.c: Sort headers.
6883         * bcache.c: Sort headers.
6884         * ax-general.c: Sort headers.
6885         * ax-gdb.h: Sort headers.
6886         * ax-gdb.c: Sort headers.
6887         * avr-tdep.c: Sort headers.
6888         * auxv.c: Sort headers.
6889         * auto-load.c: Sort headers.
6890         * arm-wince-tdep.c: Sort headers.
6891         * arm-tdep.c: Sort headers.
6892         * arm-symbian-tdep.c: Sort headers.
6893         * arm-pikeos-tdep.c: Sort headers.
6894         * arm-obsd-tdep.c: Sort headers.
6895         * arm-nbsd-tdep.c: Sort headers.
6896         * arm-nbsd-nat.c: Sort headers.
6897         * arm-linux-tdep.c: Sort headers.
6898         * arm-linux-nat.c: Sort headers.
6899         * arm-fbsd-tdep.c: Sort headers.
6900         * arm-fbsd-nat.c: Sort headers.
6901         * arm-bsd-tdep.c: Sort headers.
6902         * arch-utils.c: Sort headers.
6903         * arc-tdep.c: Sort headers.
6904         * arc-newlib-tdep.c: Sort headers.
6905         * annotate.h: Sort headers.
6906         * annotate.c: Sort headers.
6907         * amd64-windows-tdep.c: Sort headers.
6908         * amd64-windows-nat.c: Sort headers.
6909         * amd64-tdep.c: Sort headers.
6910         * amd64-sol2-tdep.c: Sort headers.
6911         * amd64-obsd-tdep.c: Sort headers.
6912         * amd64-obsd-nat.c: Sort headers.
6913         * amd64-nbsd-tdep.c: Sort headers.
6914         * amd64-nbsd-nat.c: Sort headers.
6915         * amd64-nat.c: Sort headers.
6916         * amd64-linux-tdep.c: Sort headers.
6917         * amd64-linux-nat.c: Sort headers.
6918         * amd64-fbsd-tdep.c: Sort headers.
6919         * amd64-fbsd-nat.c: Sort headers.
6920         * amd64-dicos-tdep.c: Sort headers.
6921         * amd64-darwin-tdep.c: Sort headers.
6922         * amd64-bsd-nat.c: Sort headers.
6923         * alpha-tdep.c: Sort headers.
6924         * alpha-obsd-tdep.c: Sort headers.
6925         * alpha-nbsd-tdep.c: Sort headers.
6926         * alpha-mdebug-tdep.c: Sort headers.
6927         * alpha-linux-tdep.c: Sort headers.
6928         * alpha-linux-nat.c: Sort headers.
6929         * alpha-bsd-tdep.c: Sort headers.
6930         * alpha-bsd-nat.c: Sort headers.
6931         * aix-thread.c: Sort headers.
6932         * agent.c: Sort headers.
6933         * addrmap.c: Sort headers.
6934         * ada-varobj.c: Sort headers.
6935         * ada-valprint.c: Sort headers.
6936         * ada-typeprint.c: Sort headers.
6937         * ada-tasks.c: Sort headers.
6938         * ada-lang.c: Sort headers.
6939         * aarch64-tdep.c: Sort headers.
6940         * aarch64-ravenscar-thread.c: Sort headers.
6941         * aarch64-newlib-tdep.c: Sort headers.
6942         * aarch64-linux-tdep.c: Sort headers.
6943         * aarch64-linux-nat.c: Sort headers.
6944         * aarch64-fbsd-tdep.c: Sort headers.
6945         * aarch64-fbsd-nat.c: Sort headers.
6946         * aarch32-linux-nat.c: Sort headers.
6947
6948 2019-04-04  Tom Tromey  <tom@tromey.com>
6949
6950         * varobj.c (varobj_create): Update.
6951         * rust-exp.y (struct rust_parser) <update_innermost_block,
6952         lookup_symbol>: New methods.
6953         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6954         Rename.
6955         (rust_parser::rust_lookup_type)
6956         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6957         * printcmd.c (display_command, do_one_display): Update.
6958         * parser-defs.h (struct parser_state) <parser_state>: Add
6959         "tracker" parameter.
6960         (block_tracker): New member.
6961         (class innermost_block_tracker) <innermost_block_tracker>: Add
6962         "types" parameter.
6963         <reset>: Remove method.
6964         (innermost_block): Don't declare.
6965         (null_post_parser): Update.
6966         * parse.c (innermost_block): Remove global.
6967         (write_dollar_variable): Update.
6968         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6969         Remove "tracker_types" parameter.
6970         (parse_expression): Add "tracker" parameter.
6971         (parse_expression_for_completion): Update.
6972         (null_post_parser): Add "tracker" parameter.
6973         * p-exp.y: Update rules.
6974         * m2-exp.y: Update rules.
6975         * language.h (struct language_defn) <la_post_parser>: Add
6976         "tracker" parameter.
6977         * go-exp.y: Update rules.
6978         * f-exp.y: Update rules.
6979         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6980         parameter.
6981         * d-exp.y: Update rules.
6982         * c-exp.y: Update rules.
6983         * breakpoint.c (set_breakpoint_condition): Create an
6984         innermost_block_tracker.
6985         (watch_command_1): Likewise.
6986         * ada-lang.c (resolve): Add "tracker" parameter.
6987         (resolve_subexp): Likewise.
6988         * ada-exp.y (write_var_from_sym): Update.
6989
6990 2019-04-04  Tom Tromey  <tom@tromey.com>
6991
6992         * type-stack.h: New file.
6993         * type-stack.c: New file.
6994         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6995         type-stack.h.
6996         (insert_into_type_stack, insert_type, push_type, push_type_int)
6997         (insert_type_address_space, pop_type, pop_type_int)
6998         (pop_typelist, pop_type_stack, append_type_stack)
6999         (push_type_stack, get_type_stack, push_typelist)
7000         (follow_type_instance_flags, follow_types): Don't declare.
7001         * parse.c (type_stack): Remove global.
7002         (parse_exp_in_context): Update.
7003         (insert_into_type_stack, insert_type, push_type, push_type_int)
7004         (insert_type_address_space, pop_type, pop_type_int)
7005         (pop_typelist, pop_type_stack, append_type_stack)
7006         (push_type_stack, get_type_stack, push_typelist)
7007         (follow_type_instance_flags, follow_types): Remove (moved to
7008         type-stack.c).
7009         * f-exp.y (type_stack): New global.
7010         Update rules.
7011         (push_kind_type, f_parse): Update.
7012         * d-exp.y (type_stack): New global.
7013         Update rules.
7014         (d_parse): Update.
7015         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7016         Update rules.
7017         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7018         (HFILES_NO_SRCDIR): Add type-stack.h.
7019
7020 2019-04-04  Tom Tromey  <tom@tromey.com>
7021
7022         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7023         (rust_parser::convert_ast_to_expression, rust_parse)
7024         (rust_lex_test_completion, rust_lex_tests): Update.
7025         * parser-defs.h (struct expr_completion_state): New.
7026         (struct parser_state) <parser_state>: Add completion parameter.
7027         <mark_struct_expression, mark_completion_tag>: New methods.
7028         <parse_completion, m_completion_state>: New members.
7029         (prefixify_expression, null_post_parser): Update.
7030         (mark_struct_expression, mark_completion_tag): Don't declare.
7031         * parse.c (parse_completion, expout_last_struct)
7032         (expout_tag_completion_type, expout_completion_name): Remove
7033         globals.
7034         (parser_state::mark_struct_expression)
7035         (parser_state::mark_completion_tag): Now methods.
7036         (prefixify_expression): Add last_struct parameter.
7037         (prefixify_subexp): Likewise.
7038         (parse_exp_1): Update.
7039         (parse_exp_in_context): Add cstate parameter.  Update.
7040         (parse_expression_for_completion): Create an
7041         expr_completion_state.
7042         (null_post_parser): Add "completion" parameter.
7043         * p-exp.y: Update rules.
7044         (yylex): Update.
7045         * language.h (struct language_defn) <la_post_parser>: Add
7046         "completing" parameter.
7047         * go-exp.y: Update rules.
7048         (lex_one_token): Update.
7049         * expression.h (parse_completion): Don't declare.
7050         * d-exp.y: Update rules.
7051         (lex_one_token): Update rules.
7052         * c-exp.y: Update rules.
7053         (lex_one_token): Update.
7054         * ada-lang.c (resolve): Add "parse_completion" parameter.
7055         (resolve_subexp): Likewise.
7056         (ada_resolve_function): Likewise.
7057
7058 2019-04-04  Tom Tromey  <tom@tromey.com>
7059
7060         * parser-defs.h (struct parser_state) <start_arglist,
7061         end_arglist>: New methods.
7062         <arglist_len, m_funcall_chain>: New members.
7063         (arglist_len, start_arglist, end_arglist): Don't declare.
7064         * parse.c (arglist_len, funcall_chain): Remove global.
7065         (start_arglist, end_arglist): Remove functions.
7066         (parse_exp_in_context): Update.
7067         * p-exp.y: Update rules.
7068         * m2-exp.y: Update rules.
7069         * go-exp.y: Update rules.
7070         * f-exp.y: Update rules.
7071         * d-exp.y: Update rules.
7072         * c-exp.y: Update rules.
7073
7074 2019-04-04  Tom Tromey  <tom@tromey.com>
7075
7076         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7077         lex_operator, push_back>: New methods.
7078         Update all rules.
7079         (rust_parser::lex_hex, lex_escape): Rename and update.
7080         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7081         (rust_parser::lex_operator): Rename and update.
7082         (rust_parser::lex_number, rustyylex, rustyyerror)
7083         (rust_lex_test_init, rust_lex_test_sequence)
7084         (rust_lex_test_push_back, rust_lex_tests): Update.
7085         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7086         parameter.
7087         <lexptr, prev_lexptr>: New members.
7088         (lexptr, prev_lexptr): Don't declare.
7089         * parse.c (lexptr, prev_lexptr): Remove globals.
7090         (parse_exp_in_context): Update.
7091         * p-exp.y (yylex, yyerror): Update.
7092         * m2-exp.y (parse_number, yylex, yyerror): Update.
7093         * go-exp.y (lex_one_token, yyerror): Update.
7094         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7095         * d-exp.y (lex_one_token, yyerror): Update.
7096         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7097         (lex_one_token, yyerror): Update.
7098         * ada-lex.l (YY_INPUT): Update.
7099         (rewind_to_char): Update.
7100         * ada-exp.y (yyerror): Update.
7101
7102 2019-04-04  Tom Tromey  <tom@tromey.com>
7103
7104         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7105         * parser-defs.h (struct parser_state) <parser_state>: Add new
7106         parameter.
7107         <comma_terminates>: New member.
7108         (comma_terminates): Don't declare global.
7109         * parse.c (comma_terminates): Remove global.
7110         (parse_exp_in_context): Update.
7111         * p-exp.y (yylex): Update.
7112         * m2-exp.y (yylex): Update.
7113         * go-exp.y (lex_one_token): Update.
7114         * f-exp.y (yylex): Update.
7115         * d-exp.y (lex_one_token): Update.
7116         * c-exp.y (lex_one_token): Update.
7117         * ada-lex.l: Update.
7118
7119 2019-04-04  Tom Tromey  <tom@tromey.com>
7120
7121         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7122         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7123         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7124         * parser-defs.h (paren_depth): Don't declare.
7125         * parse.c (paren_depth): Remove global.
7126         (parse_exp_in_context): Update.
7127         * p-exp.y (paren_depth): New global.
7128         (pascal_parse): Initialize it.
7129         * m2-exp.y (paren_depth): New global.
7130         (m2_parse): Initialize it.
7131         * go-exp.y (paren_depth): New global.
7132         (go_parse): Initialize it.
7133         * f-exp.y (paren_depth): New global.
7134         (f_parse): Initialize it.
7135         * d-exp.y (paren_depth): New global.
7136         (d_parse): Initialize it.
7137         * c-exp.y (paren_depth): New global.
7138         (c_parse): Initialize it.
7139         * ada-lex.l (paren_depth): New global.
7140         (lexer_init): Initialize it.
7141
7142 2019-04-04  Tom Tromey  <tom@tromey.com>
7143
7144         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7145         (rust_parser::convert_ast_to_type)
7146         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7147         * parser-defs.h (struct parser_state) <parser_state>: Add
7148         parameters.  Initialize new members.
7149         <expression_context_block, expression_context_pc>: New members.
7150         * parse.c (expression_context_block, expression_context_pc):
7151         Remove globals.
7152         (parse_exp_in_context): Update.
7153         * p-exp.y: Update all rules.
7154         (yylex): Update.
7155         * m2-exp.y: Update all rules.
7156         (yylex): Update.
7157         * go-exp.y (yylex): Update.
7158         * f-exp.y (yylex): Update.
7159         * d-exp.y: Update all rules.
7160         (yylex): Update.
7161         * c-exp.y: Update all rules.
7162         (lex_one_token, classify_name, yylex, c_parse): Update.
7163         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7164
7165 2019-04-04  Tom Tromey  <tom@tromey.com>
7166
7167         * gdbarch.h, gdbarch.c: Rebuild.
7168         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7169         * stap-probe.h:
7170         (struct stap_parse_info): Replace "parser_state" with
7171         "expr_builder".
7172         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7173         (parser_state): New class.
7174         * parse.c (expr_builder): Rename.
7175         (expr_builder::release): Rename.
7176         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7177         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7178         (write_exp_elt_longcst, write_exp_elt_floatcst)
7179         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7180         (write_exp_string_vector, write_exp_bitstring)
7181         (write_exp_msymbol, mark_struct_expression)
7182         (write_dollar_variable)
7183         (insert_type_address_space, increase_expout_size): Replace
7184         "parser_state" with "expr_builder".
7185         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7186         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7187         "parser_state" with "expr_builder".
7188
7189 2019-04-04  Tom Tromey  <tom@tromey.com>
7190
7191         * rust-exp.y: Replace "parse_language" with method call.
7192         * p-exp.y:
7193         (yylex): Replace "parse_language" with method call.
7194         * m2-exp.y:
7195         (yylex): Replace "parse_language" with method call.
7196         * go-exp.y (classify_name): Replace "parse_language" with method
7197         call.
7198         * f-exp.y (yylex): Replace "parse_language" with method call.
7199         * d-exp.y (lex_one_token): Replace "parse_language" with method
7200         call.
7201         * c-exp.y:
7202         (lex_one_token, classify_name, yylex): Replace "parse_language"
7203         with method call.
7204         * ada-exp.y (find_primitive_type, type_char)
7205         (type_system_address): Replace "parse_language" with method call.
7206
7207 2019-04-04  Tom Tromey  <tom@tromey.com>
7208
7209         * rust-exp.y: Replace "parse_gdbarch" with method call.
7210         * parse.c (write_dollar_variable, insert_type_address_space):
7211         Replace "parse_gdbarch" with method call.
7212         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7213         call.
7214         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7215         call.
7216         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7217         "parse_gdbarch" with method call.
7218         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7219         with method call.
7220         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7221         "parse_gdbarch" with method call.
7222         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7223         "parse_gdbarch" with method call.
7224         * c-exp.y (parse_type, parse_number, classify_name): Replace
7225         "parse_gdbarch" with method call.
7226         * ada-lex.l: Replace "parse_gdbarch" with method call.
7227         * ada-exp.y (parse_type, find_primitive_type, type_char)
7228         (type_system_address): Replace "parse_gdbarch" with method call.
7229
7230 2019-04-04  Tom Tromey  <tom@tromey.com>
7231
7232         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7233         * stap-probe.c (stap_parse_argument): Update.
7234         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7235         initial_size parameter.
7236         * rust-exp.y (rust_lex_tests): Update.
7237         * parse.c (parser_state): Update.
7238         (parse_exp_in_context): Update.
7239         * parser-defs.h (struct parser_state) <parser_state>: Remove
7240         "initial_size" parameter.
7241
7242 2019-04-04  Tom Tromey  <tom@tromey.com>
7243
7244         * parser-defs.h (increase_expout_size): Don't declare.
7245         * parse.c (increase_expout_size): Now static.
7246
7247 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7248
7249         * gnu-nat.c (gnu_nat_target::wait): Fix
7250         target_waitstatus_to_string call.
7251
7252 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7253
7254         * eval.c (evaluate_subexp_standard): Handle internal functions
7255         during Fortran function call handling.
7256
7257 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7258
7259         * NEWS: Mention new internal functions.
7260         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7261         (read_base_type): Use dwarf2_init_complex_target_type.
7262         * value.c (creal_internal_fn): New function.
7263         (cimag_internal_fn): New function.
7264         (_initialize_values): Register new internal functions.
7265
7266 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7267
7268         * infrun.c (stop_all_threads): If debug_infrun, always
7269         trace the wait status after wait_one, using
7270         target_waitstatus_to_string and target_pid_to_str.
7271         (handle_inferior_event): Replace various trace of
7272         wait status kind by a single trace.
7273         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7274         wait status kind image by target_waitstatus_to_string.
7275         * target/waitstatus.c (target_waitstatus_to_string): Fix
7276         obsolete comment.
7277
7278 2019-04-01  Tom Tromey  <tromey@adacore.com>
7279
7280         PR symtab/23331:
7281         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7282
7283 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7284             Pedro Alves  <palves@redhat.com>
7285
7286         * top.c (quit_force): Call 'finalize_values'.
7287         * value.c (finalize_values): New function.
7288         * value.h (finalize_values): Declare.
7289
7290 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7291
7292         * NEWS: Announce $_gdb_major and $_gdb_minor.
7293
7294         * top.c (init_gdb_version_vars): New function.
7295         (gdb_init): Call init_gdb_version_vars.
7296
7297 2019-03-29  Tom Tromey  <tromey@adacore.com>
7298
7299         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7300         help text.  Remove dead code.
7301
7302 2019-03-29  Keith Seitz  <keiths@redhat.com>
7303
7304         From Siddhesh Poyarekar:
7305         * f-lang.h (f77_get_upperbound): Return LONGEST.
7306         (f77_get_lowerbound): Likewise.
7307         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7308         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7309         print them.
7310         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7311         plongest to format print it.
7312         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7313         (f77_get_upperbound): Likewise.
7314         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7315         LOWER_BOUND to LONGEST.
7316         (f77_create_arrayprint_offset_tbl): Likewise.
7317
7318 2019-03-29  Keith Seitz  <keiths@redhat.com>
7319
7320         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7321         %s/pulongest for TYPE_LENGTH instead of %d in format
7322         strings.
7323         * ada-typerint.c (ada_print_type): Likewise.
7324         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7325         * compile/compile-c-support.c (generate_register_struct): Likewise.
7326         * gdbtypes.c (recursive_dump_type): Likewise.
7327         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7328         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7329         instead of %d in format strings.
7330         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7331         to std::min to ULONGEST.
7332         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7333         instead of %d in format strings.
7334         * tracepoint.c (info_scope_command): Likewise.
7335         * typeprint.c (print_offset_data::update)
7336         (print_offset_data::finish): Likewise.
7337         * xtensa-tdep.c (xtensa_store_return_value)
7338         (xtensa_push_dummy_call): Likewise.
7339
7340 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7341
7342         * windows-nat.c (display_selector): Fixed format specifications
7343         for 64-bit Cygwin.
7344
7345 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7346
7347         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7348
7349 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7350
7351         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7352         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7353         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7354         (nios2_linux_init_abi): Install it.
7355
7356 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7357
7358         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7359
7360 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7361
7362         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7363
7364 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7365             Tom Tromey  <tromey@adacore.com>
7366
7367         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7368
7369 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7370
7371         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7372         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7373         method to compute the bounds of range types. Also print "[evaluated]"
7374         if the bounds' values come from a dynamic evaluation.
7375
7376 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7377
7378         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7379         whitespace when pretty printing is on.
7380
7381 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7382
7383         * ppc-linux-nat.c: Add include.
7384
7385 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7386
7387         * NEWS: Mention AArch64 Pointer Authentication.
7388
7389 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7390
7391         * arm-linux-nat.c: Add include.
7392
7393 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7394
7395         * source-cache.c (source_cache::get_source_lines): Re-read
7396         fullname after calling open_source_file.
7397
7398 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7399
7400         * NEWS: Mention TLS support for FreeBSD.
7401
7402 2019-03-25  Tom Tromey  <tromey@adacore.com>
7403
7404         * minsyms.c (BUNCH_SIZE): Update comment.
7405         (~minimal_symbol_reader): Remove old comment.
7406         (compact_minimal_symbols): Update comment.
7407         (minimal_symbol_reader::install): Remove old comment.  Update
7408         other comments.
7409
7410 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7411
7412         * s390-linux-nat.c: Add include.
7413
7414 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7415
7416         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7417         Call linux_get_hwcap.
7418         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7419         Likewise.
7420         (aarch64_linux_get_hwcap): Remove function.
7421         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7422         declaration.
7423         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7424         linux_get_hwcap.
7425         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7426         * linux-tdep.c (linux_get_hwcap): Add function.
7427         (linux_get_hwcap2): Likewise.
7428         * linux-tdep.h (linux_get_hwcap): Add declaration.
7429         (linux_get_hwcap2): Likewise.
7430         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7431         (ppc_linux_get_hwcap2): Likewise.
7432         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7433         linux_get_hwcap.
7434         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7435         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7436         (ppc_linux_nat_target::read_description): Likewise.
7437         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7438         * s390-linux-nat.c: Likewise.
7439         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7440
7441 2019-03-24  Tom Tromey  <tom@tromey.com>
7442
7443         * ada-lang.c (standard_lookup): Simplify initialization.
7444         (ada_lookup_symbol_nonlocal): Simplify return.
7445         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7446         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7447         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7448         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7449         initialization.
7450         * solib.c (solib_global_lookup): Simplify.
7451         * symtab.c (null_block_symbol): Remove.
7452         (symbol_cache_lookup): Simplify returns.
7453         (lookup_language_this): Simplify returns.
7454         (lookup_symbol_aux): Simplify return.
7455         (lookup_local_symbol): Simplify returns.
7456         (lookup_global_symbol_from_objfile): Simplify return.
7457         (lookup_symbol_in_objfile_symtabs)
7458         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7459         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7460         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7461         * cp-namespace.c (cp_lookup_bare_symbol)
7462         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7463         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7464         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7465         (cp_lookup_symbol_via_imports): Simplify initialization.
7466         (find_symbol_in_baseclass): Likewise.
7467         * symtab.h (null_block_symbol): Remove.
7468         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7469         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7470         (d_lookup_symbol_module): Likewise.
7471         (find_symbol_in_baseclass): Simplify initialization.
7472
7473 2019-03-24  Tom Tromey  <tom@tromey.com>
7474
7475         * expression.h: Don't include symtab.h.
7476         (struct block): Forward declare.
7477
7478 2019-03-24  Tom Tromey  <tom@tromey.com>
7479
7480         * c-exp.y (typebase): Remove casts.
7481         * gdbtypes.c (lookup_unsigned_typename, )
7482         (lookup_signed_typename): Remove cast.
7483         * eval.c (parse_to_comma_and_eval): Remove cast.
7484         * parse.c (write_dollar_variable): Remove cast.
7485         * block.h (struct block) <superblock>: Now const.
7486         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7487         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7488         (map_block): Make "block" const.
7489         * symfile.h (struct quick_symbol_functions)
7490         <map_matching_symbols>: Constify block argument to "callback".
7491         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7492         const.
7493         (find_pc_sect_compunit_symtab): Make "b" const.
7494         (find_symbol_at_address): Likewise.
7495         (search_symbols): Likewise.
7496         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7497         (dw2_debug_names_lookup_symbol): Likewise.
7498         (dw2_map_matching_symbols): Update.
7499         * p-valprint.c (pascal_val_print): Remove "block".
7500         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7501         (aux_add_nonlocal_symbols): Make "block" const.
7502         (resolve_subexp): Remove cast.
7503         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7504         const.
7505         (iterate_over_file_blocks): Likewise.
7506         * f-exp.y (%union) <bval>: Remove.
7507         * coffread.c (patch_opaque_types): Make "b" const.
7508         * spu-tdep.c (spu_catch_start): Make "block" const.
7509         * c-valprint.c (print_unpacked_pointer): Remove "block".
7510         * symmisc.c (dump_symtab_1): Make "b" const.
7511         (block_depth): Make "block" const.
7512         * d-exp.y (%union) <bval>: Remove.
7513         * cp-support.h (cp_lookup_rtti_type): Update.
7514         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7515         * psymtab.c (psym_lookup_symbol): Make "block" const.
7516         (maintenance_check_psymtabs): Make "b" const.
7517         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7518         (enumerate_locals, enumerate_args): Update.
7519         * python/py-symtab.c (stpy_global_block): Make "block" const.
7520         (stpy_static_block): Likewise.
7521         * inline-frame.c (block_starting_point_at): Make "new_block"
7522         const.
7523         * block.c (find_block_in_blockvector): Make return type const.
7524         (blockvector_for_pc_sect): Make "b" const.
7525         (find_block_in_blockvector): Make "b" const.
7526
7527 2019-03-23  Tom Tromey  <tom@tromey.com>
7528
7529         * varobj.c (varobj_create): Update.
7530         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7531         * printcmd.c (display_command, do_one_display): Don't reset
7532         innermost_block.
7533         * parser-defs.h (enum innermost_block_tracker_type): Move to
7534         expression.h.
7535         (innermost_block): Update comment.
7536         * parse.c (parse_exp_1): Add tracker_types parameter.
7537         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7538         tracker_types parameter.  Reset innermost_block.
7539         (parse_exp_in_context): Remove.
7540         (parse_expression_for_completion): Update.
7541         * objfiles.c (~objfile): Don't reset expression_context_block or
7542         innermost_block.
7543         * expression.h (enum innermost_block_tracker_type): Move from
7544         parser-defs.h.
7545         (parse_exp_1): Add tracker_types parameter.
7546         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7547         reset innermost_block.
7548
7549 2019-03-23  Tom Tromey  <tom@tromey.com>
7550
7551         * objfiles.h: Include bcache.h.
7552
7553 2019-03-23  Tom Tromey  <tom@tromey.com>
7554
7555         * linespec.c (get_current_search_block): Use
7556         scoped_restore_current_language.
7557         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7558
7559 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7560             Jiong Wang  <jiong.wang@arm.com>
7561
7562         * aarch64-linux-tdep.c
7563         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7564         section.
7565         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7566
7567 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7568             Jiong Wang  <jiong.wang@arm.com>
7569
7570         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7571         instructions.
7572         (aarch64_analyze_prologue_test): Add PACIASP test.
7573         (aarch64_prologue_prev_register): Unmask PC value.
7574
7575 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7576             Jiong Wang  <jiong.wang@arm.com>
7577
7578         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7579         (aarch64_dwarf2_prev_register): Unmask PC value.
7580         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7581         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7582         DW_CFA_AARCH64_negate_ra_state.
7583         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7584
7585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7586             Jiong Wang  <jiong.wang@arm.com>
7587
7588         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7589         registers.
7590         (aarch64_pseudo_register_name): Likewise.
7591         (aarch64_pseudo_register_type): Likewise.
7592         (aarch64_pseudo_register_reggroup_p): Likewise.
7593         (aarch64_gdbarch_init): Add pauth registers.
7594         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7595         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7596         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7597         (struct gdbarch_tdep): Add regnum for ra_state.
7598
7599 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7600             Jiong Wang  <jiong.wang@arm.com>
7601
7602         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7603
7604 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7605             Jiong Wang  <jiong.wang@arm.com>
7606
7607         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7608         function.
7609         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7610         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7611         (aarch64_gdbarch_init): Add puth registers.
7612         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7613         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7614         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7615
7616 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7617             Jiong Wang  <jiong.wang@arm.com>
7618
7619         * aarch64-linux-nat.c
7620         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7621         * aarch64-linux-tdep.c
7622         (aarch64_linux_core_read_description): Likewise.
7623         (aarch64_linux_get_hwcap): New function.
7624         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7625         (aarch64_linux_get_hwcap): New declaration.
7626
7627 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7628             Jiong Wang  <jiong.wang@arm.com>
7629
7630         * aarch64-linux-nat.c
7631         (aarch64_linux_nat_target::read_description): Add pauth param.
7632         * aarch64-linux-tdep.c
7633         (aarch64_linux_core_read_description): Likewise.
7634         * aarch64-tdep.c (struct target_desc): Add in pauth.
7635         (aarch64_read_description): Add pauth param.
7636         (aarch64_gdbarch_init): Likewise.
7637         * aarch64-tdep.h (aarch64_read_description): Likewise.
7638         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7639         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7640         * features/Makefile: Add new files.
7641         * features/aarch64-pauth.c: New file.
7642         * features/aarch64-pauth.xml: New file.
7643
7644 2019-03-20  Tom Tromey  <tromey@adacore.com>
7645
7646         * infrun.c (handle_inferior_event): Rename from
7647         handle_inferior_event_1.  Create a scoped_value_mark.
7648         (handle_inferior_event): Remove.
7649
7650 2019-03-19  Tom Tromey  <tromey@adacore.com>
7651
7652         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7653         * infrun.h (print_stop_event): Add "displays" parameter.
7654         * infrun.c (print_stop_event): Add "displays" parameter.
7655
7656 2019-03-19  Pedro Alves  <palves@redhat.com>
7657
7658         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7659         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7660         to -1.  Fix TABs vs spaces.
7661         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7662         * tui/tui-out.h (tui_ui_out) Add intro comments.
7663         <m_line, m_start_of_line>: In-class initialize, and add describing
7664         comment.
7665
7666 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7667
7668         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7669         variable names.
7670         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7671
7672 2019-03-18  Pedro Alves  <palves@redhat.com>
7673             Eli Zaretskii <eliz@gnu.org>
7674
7675         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7676         m_line and m_start_of_line.
7677
7678 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7679
7680         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7681         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7682         it returns a newline.  This fixes a regression in TU mode, whereby
7683         the next line is output on the same screen line as the user input.
7684
7685 2019-03-18  Tom Tromey  <tromey@adacore.com>
7686
7687         * minsyms.c (minimal_symbol_reader::install): Remove call to
7688         obstack_blank.
7689
7690 2019-03-18  Pedro Alves  <palves@redhat.com>
7691
7692         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7693         New globals.
7694         (apply_style): New, factored out from ...
7695         (apply_ansi_escape): ... this.  Handle reverse video mode.
7696         (tui_set_reverse_mode): New function.
7697         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7698         * tui/tui-winsource.c (tui_show_source_line): Use
7699         tui_set_reverse_mode instead of setting A_STANDOUT.
7700         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7701         New setter methods.
7702
7703 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7704
7705         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7706         Handle tabs.
7707
7708 2019-03-18  Tom Tromey  <tromey@adacore.com>
7709
7710         * ada-lang.c (empty_array): Add "high" parameter.
7711         (ada_evaluate_subexp): Update.
7712
7713 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7714
7715         * unittests/string_view-selftests.c: Define
7716         _initialize_string_view_selftests unconditionally.
7717
7718 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7719
7720         PR gdb/24350
7721         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7722
7723 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7724
7725         PR gdb/24351
7726         * windows-nat.c (display_selector): Fix format specifiers.
7727
7728 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7729
7730         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7731         tui_refill_source_window instead of tui_refresh_win, to update the
7732         current execution line.  This fixes redisplay of the current line
7733         when stepping through the code with "next" or "step".
7734
7735 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7736
7737         * source-cache.c (source_cache::get_source_lines): Call
7738         find_source_lines to initialize s->nlines.  This fixes vertical
7739         scrolling of TUI source window when the DOWN arrow is pressed.
7740
7741 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7742
7743         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7744         linux-thread-db.c (_initialize_thread_db): Likewise.
7745
7746 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7747
7748         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7749         wclrtoeol in tui_show_source_line".  This reverts changes made in
7750         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7751
7752 2019-03-15  Tom Tromey  <tom@tromey.com>
7753
7754         * symtab.h (struct minimal_symbol): Derive from
7755         general_symbol_info.
7756         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7757         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7758         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7759         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7760         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7761         (MSYMBOL_SEARCH_NAME): Update.
7762         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7763         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7764         * minsyms.c (minimal_symbol_reader::record_full): Update.
7765
7766 2019-03-15  Tom Tromey  <tom@tromey.com>
7767
7768         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7769
7770 2019-03-15  Tom Tromey  <tom@tromey.com>
7771
7772         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7773         unique_xmalloc_ptr.
7774         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7775         Update.
7776         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7777         (build_minimal_symbol_hash_tables)
7778         (minimal_symbol_reader::install): Update.
7779
7780 2019-03-15  Tom Tromey  <tom@tromey.com>
7781
7782         * symtab.c (create_demangled_names_hash): Update.
7783         (symbol_set_names): Update.
7784         * objfiles.h (struct objfile_per_bfd_storage)
7785         <demangled_names_hash>: Now an htab_up.
7786         * objfiles.c (objfile_per_bfd_storage): Simplify.
7787
7788 2019-03-15  Tom Tromey  <tom@tromey.com>
7789
7790         * objfiles.h (struct objfile_per_bfd_storage): Declare
7791         destructor.
7792         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7793         New.
7794         (get_objfile_bfd_data): Use new.  Don't initialize
7795         language_of_main.
7796         (free_objfile_per_bfd_storage): Remove.
7797         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7798
7799 2019-03-15  Tom Tromey  <tom@tromey.com>
7800
7801         * symfile.c (reread_symbols): Update.
7802         * objfiles.c (objfile::objfile): Update.
7803         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7804         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7805         comment.
7806         (minimal_symbol_reader::install): Update.
7807         (terminate_minimal_symbol_table): Remove.
7808         * jit.c (jit_object_close_impl): Update.
7809
7810 2019-03-15  Tom Tromey  <tom@tromey.com>
7811
7812         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7813         initializations.
7814
7815 2019-03-15  Tom Tromey  <tom@tromey.com>
7816
7817         * objfiles.h (struct objfile_per_bfd_storage)
7818         <demangled_hash_languages>: Now a bitset.
7819         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7820         (lookup_minimal_symbol): Update.
7821
7822 2019-03-15  Tom Tromey  <tom@tromey.com>
7823
7824         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7825         Don't return the symbol.
7826         * coffread.c (record_minimal_symbol): Use record_full.
7827
7828 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7829
7830         The MS-Windows port of ncurses fails to switch to a color pair if
7831         one or both of the colors are the implicit default colors.  This
7832         change records the default colors when TUI is initialized, and
7833         then specifies them explicitly when a color pair uses the default
7834         colors.  This allows color styling in TUI mode on MS-Windows.
7835
7836         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7837         ncurses_norm_attr.
7838         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7839         colors in ncurses_norm_attr.
7840         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7841         "none", replace it with the default color recorded in
7842         ncurses_norm_attr.
7843
7844 2019-03-14  Tom Tromey  <tromey@adacore.com>
7845
7846         * source-cache.h (class source_cache) <get_source_lines>: Return
7847         std::string.
7848         * source-cache.c (source_cache::extract_lines): Handle case where
7849         first_pos==npos.  Return std::string.
7850         (source_cache::get_source_lines): Update.
7851
7852 2019-03-14  Tom Tromey  <tromey@adacore.com>
7853
7854         * NEWS: Add item for "style sources" commands.
7855         * source-cache.c (source_cache::get_source_lines): Check
7856         source_styling.
7857         * cli/cli-style.c (source_styling): New global.
7858         (_initialize_cli_style): Add "style sources" commands.
7859         (show_style_sources): New function.
7860         * cli/cli-style.h (source_styling): Declare.
7861
7862 2019-03-14  Pedro Alves  <palves@redhat.com>
7863             Tom Tromey  <tromey@adacore.com>
7864
7865         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7866         * tui/tui-winsource.c (tui_refill_source_window): New function,
7867         from...
7868         (tui_horizontal_source_scroll): ... here.  Move some logic.
7869         * cli/cli-style.c (set_style_enabled): Notify new observable.
7870         * tui/tui-hooks.c (tui_redisplay_source): New function.
7871         (tui_attach_detach_observers): Attach or detach
7872         tui_redisplay_source.
7873         * observable.h (source_styling_changed): New observable.
7874         * observable.c: Define source_styling_changed observable.
7875
7876 2019-03-13  Tom Tromey  <tromey@adacore.com>
7877
7878         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7879         (i386_gnu_nat_target::store_registers): Update.
7880         * target-debug.h (target_debug_print_std_string): New macro.
7881         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7882         * windows-tdep.c (display_one_tib): Update.
7883         * tui/tui-stack.c (tui_make_status_line): Update.
7884         * top.c (print_inferior_quit_action): Update.
7885         * thread.c (thr_try_catch_cmd): Update.
7886         (add_thread_with_info): Update.
7887         (thread_target_id_str): Update.
7888         (thr_try_catch_cmd): Update.
7889         (thread_command): Update.
7890         (thread_find_command): Update.
7891         * record-btrace.c (record_btrace_target::info_record)
7892         (record_btrace_resume_thread, record_btrace_target::resume)
7893         (record_btrace_cancel_resume, record_btrace_step_thread)
7894         (record_btrace_target::wait, record_btrace_target::wait)
7895         (record_btrace_target::wait, record_btrace_target::stop): Update.
7896         * progspace.c (print_program_space): Update.
7897         * process-stratum-target.c
7898         (process_stratum_target::thread_address_space): Update.
7899         * linux-fork.c (linux_fork_mourn_inferior)
7900         (detach_checkpoint_command, info_checkpoints_command)
7901         (linux_fork_context): Update.
7902         (linux_fork_detach): Update.
7903         (class scoped_switch_fork_info): Update.
7904         (delete_checkpoint_command): Update.
7905         * infrun.c (follow_fork_inferior): Update.
7906         (follow_fork_inferior): Update.
7907         (proceed_after_vfork_done): Update.
7908         (handle_vfork_child_exec_or_exit): Update.
7909         (follow_exec): Update.
7910         (displaced_step_prepare_throw): Update.
7911         (displaced_step_restore): Update.
7912         (start_step_over): Update.
7913         (resume_1): Update.
7914         (clear_proceed_status_thread): Update.
7915         (proceed): Update.
7916         (print_target_wait_results): Update.
7917         (do_target_wait): Update.
7918         (context_switch): Update.
7919         (stop_all_threads): Update.
7920         (restart_threads): Update.
7921         (finish_step_over): Update.
7922         (handle_signal_stop): Update.
7923         (switch_back_to_stepped_thread): Update.
7924         (keep_going_pass_signal): Update.
7925         (print_exited_reason): Update.
7926         (normal_stop): Update.
7927         * inferior.c (inferior_pid_to_str): Change return type.
7928         (print_selected_inferior): Update.
7929         (add_inferior): Update.
7930         (detach_inferior): Update.
7931         * dummy-frame.c (fprint_dummy_frames): Update.
7932         * dcache.c (dcache_info_1): Update.
7933         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7934         (btrace_fetch, btrace_clear): Update.
7935         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7936         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7937         type.
7938         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7939         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7940         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7941         * gdbarch.c, gdbarch.h: Rebuild.
7942         * gdbarch.sh (core_pid_to_str): Change return type.
7943         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7944         return type.
7945         (windows_nat_target::pid_to_str): Change return type.
7946         (windows_delete_thread): Update.
7947         (windows_nat_target::attach): Update.
7948         (windows_nat_target::files_info): Update.
7949         * target-delegates.c: Rebuild.
7950         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7951         return type.
7952         (sol_thread_target::pid_to_str): Change return type.
7953         * remote.c (class remote_target) <pid_to_str>: Change return
7954         type.
7955         (remote_target::pid_to_str): Change return type.
7956         (extended_remote_target::attach, remote_target::remote_stop_ns)
7957         (remote_target::remote_notif_remove_queued_reply)
7958         (remote_target::push_stop_reply, remote_target::disable_btrace):
7959         Update.
7960         (extended_remote_target::attach): Update.
7961         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7962         type.
7963         (gdbsim_target::pid_to_str): Change return type.
7964         * ravenscar-thread.c (struct ravenscar_thread_target)
7965         <pid_to_str>: Change return type.
7966         (ravenscar_thread_target::pid_to_str): Change return type.
7967         * procfs.c (class procfs_target) <pid_to_str>: Change return
7968         type.
7969         (procfs_target::pid_to_str): Change return type.
7970         (procfs_target::attach): Update.
7971         (procfs_target::detach): Update.
7972         (procfs_target::fetch_registers): Update.
7973         (procfs_target::store_registers): Update.
7974         (procfs_target::wait): Update.
7975         (procfs_target::files_info): Update.
7976         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7977         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7978         return type.
7979         (nto_procfs_target::pid_to_str): Change return type.
7980         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7981         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7982         return type.
7983         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7984         (exit_lwp): Update.
7985         (attach_proc_task_lwp_callback, get_detach_signal)
7986         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7987         (linux_nat_target::resume, wait_lwp, stop_callback)
7988         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7989         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7990         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7991         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7992         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7993         type.
7994         (inf_ptrace_target::attach): Update.
7995         (inf_ptrace_target::files_info): Update.
7996         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7997         type.
7998         (go32_nat_target::pid_to_str): Change return type.
7999         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8000         (gnu_nat_target::wait): Update.
8001         (gnu_nat_target::wait): Update.
8002         (gnu_nat_target::resume): Update.
8003         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8004         (fbsd_nat_target::wait): Update.
8005         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8006         type.
8007         (darwin_nat_target::attach): Update.
8008         * corelow.c (class core_target) <pid_to_str>: Change return type.
8009         (core_target::pid_to_str): Change return type.
8010         * target.c (normal_pid_to_str): Change return type.
8011         (default_pid_to_str): Likewise.
8012         (target_pid_to_str): Change return type.
8013         (target_translate_tls_address): Update.
8014         (target_announce_detach): Update.
8015         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8016         return type.
8017         (bsd_uthread_target::pid_to_str): Change return type.
8018         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8019         type.
8020         (bsd_kvm_target::pid_to_str): Change return type.
8021         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8022         return type.
8023         (aix_thread_target::pid_to_str): Change return type.
8024         * target.h (struct target_ops) <pid_to_str>: Change return type.
8025         (target_pid_to_str, normal_pid_to_str): Likewise.
8026         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8027         type.
8028         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8029         type.
8030         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8031         return type.
8032         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8033         type.
8034         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8035         type.
8036         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8037         return type.
8038
8039 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8040
8041         * NEWS: Mention that the new default MI version is 3.  Mention
8042         changes to the output of commands and events that deal with
8043         multi-location breakpoints.
8044         * breakpoint.c: Include "mi/mi-out.h".
8045         (print_one_breakpoint): Change output syntax if using MI version
8046         >= 3.
8047         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8048         New.
8049         (mi_multi_location_breakpoint_output_fixed): New.
8050         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8051         (mi_cmd_fix_multi_location_breakpoint_output): New.
8052         (mi_multi_location_breakpoint_output_fixed): New.
8053         * mi/mi-cmds.c (mi_cmds): Register command
8054         -fix-multi-location-breakpoint-output.
8055         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8056         interpreter "mi".
8057
8058 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8059
8060         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8061         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8062         instantiate mi_ui_out based on interpreter name.
8063         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8064         * mi/mi-main.c (mi_load_progress): Likewise.
8065
8066 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8067
8068         * NEWS: Combine separate "New targets" sections for 8.3.
8069
8070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8071
8072         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8073         (ppcfbsd_init_abi): Install gdbarch
8074         "fetch_tls_load_module_address" and "get_thread_local_address"
8075         methods.
8076
8077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8078
8079         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8080         (riscv_fbsd_init_abi): Install gdbarch
8081         "fetch_tls_load_module_address" and "get_thread_local_address"
8082         methods.
8083
8084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8085
8086         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8087         (i386fbsd_init_abi): Install gdbarch
8088         "fetch_tls_load_module_address" and "get_thread_local_address"
8089         methods.
8090
8091 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8092
8093         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8094         (amd64fbsd_init_abi): Install gdbarch
8095         "fetch_tls_load_module_address" and "get_thread_local_address"
8096         methods.
8097
8098 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8099
8100         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8101         (struct fbsd_pspace_data): New type.
8102         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8103         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8104         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8105         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8106         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8107
8108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8109
8110         * gdbtypes.c (lookup_struct_elt): New function.
8111         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8112         * gdbtypes.h (struct struct_elt): New type.
8113         (lookup_struct_elt): New prototype.
8114
8115 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8116
8117         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8118         remove disabled code block.
8119
8120 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8121
8122         * gdbarch.sh (get_thread_local_address): New method.
8123         * gdbarch.h, gdbarch.c: Regenerate.
8124         * target.c (target_translate_tls_address): Use
8125         gdbarch_get_thread_local_address if present instead of
8126         target::get_thread_local_address.
8127
8128 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8129
8130         * target.h (target::get_thread_local_address): Update comment.
8131
8132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8133
8134         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8135         objfile->separate_debug_objfile_backlink if not NULL.
8136
8137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8138
8139         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8140         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8141         (amd64bsd_store_inferior_registers): Likewise.
8142         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8143         Enable segment base registers.
8144         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8145         PT_GETFSBASE and PT_GETGSBASE.
8146         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8147         PT_SETGSBASE.
8148         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8149         segment base registers.
8150         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8151
8152 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8153
8154         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8155         Update calls to i386_target_description to add 'segments'
8156         parameter.
8157         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8158         add segment base registers.
8159         * arch/i386.c (i386_create_target_description): Add 'segments'
8160         parameter to enable segment base registers.
8161         * arch/i386.h (i386_create_target_description): Likewise.
8162         * features/i386/32bit-segments.xml: New file.
8163         * features/i386/32bit-segments.c: Generate.
8164         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8165         call to i386_target_description to add 'segments' parameter.
8166         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8167         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8168         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8169         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8170         if feature is present.
8171         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8172         Add 'segments' parameter to call to i386_target_description.
8173         (i386_target_description): Add 'segments' parameter to enable
8174         segment base registers.
8175         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8176         to call to i386_target_description.
8177         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8178         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8179         Define I386_NUM_REGS.
8180         (i386_target_description): Add 'segments' parameter to enable
8181         segment base registers.
8182
8183 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8184
8185         PR/24325
8186         * source-cache.c: #undef open and close, to avoid unresolved
8187         externals during linking.
8188
8189 2019-03-12  Tom Tromey  <tromey@adacore.com>
8190
8191         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8192         const.  Add initializers.
8193         (_initialize_remote): Don't initialize ptid globals.
8194
8195 2019-03-12  Pedro Alves  <palves@redhat.com>
8196
8197         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8198
8199 2019-03-12  Pedro Alves  <palves@redhat.com>
8200
8201         * cp-name-parser.y (main): Remove unused 'len' variable.
8202
8203 2019-03-12  Tom Tromey  <tromey@adacore.com>
8204
8205         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8206         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8207
8208 2019-03-12  Tom Tromey  <tromey@adacore.com>
8209
8210         * linux-nat.c (iterate_over_lwps): Update.
8211         (stop_callback): Remove parameter.
8212         (stop_wait_callback, detach_callback, resume_set_callback)
8213         (select_singlestep_lwp_callback, set_ignore_sigint)
8214         (status_callback, resumed_callback, resume_clear_callback)
8215         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8216         data parameter.
8217         (linux_nat_target::detach, linux_nat_target::resume)
8218         (linux_stop_and_wait_all_lwps, select_event_lwp)
8219         (linux_nat_filter_event, linux_nat_wait_1)
8220         (linux_nat_target::kill, linux_nat_target::stop)
8221         (linux_nat_target::stop): Update.
8222         (linux_nat_resume_callback): Change type.
8223         (resume_stopped_resumed_lwps, count_events_callback)
8224         (select_event_lwp_callback): Likewise.
8225         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8226         * arm-linux-nat.c (struct update_registers_data): Remove.
8227         (update_registers_callback): Change type.
8228         (arm_linux_insert_hw_breakpoint1): Update.
8229         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8230         parameter.
8231         (x86_linux_dr_set_addr): Update.
8232         (x86_linux_dr_set_control): Update.
8233         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8234         (iterate_over_lwps): Use gdb::function_view.
8235         * nat/aarch64-linux-hw-point.c (struct
8236         aarch64_dr_update_callback_param): Remove.
8237         (debug_reg_change_callback): Change type.
8238         (aarch64_notify_debug_reg_change): Update.
8239         * s390-linux-nat.c (s390_refresh_per_info): Update.
8240
8241 2019-03-11  Tom Tromey  <tromey@adacore.com>
8242
8243         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8244         redundant assignment to "this_cu".
8245
8246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8247
8248         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8249
8250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8251
8252         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8253         from...
8254         (rank_one_type): ... this.
8255
8256 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8257
8258         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8259         from...
8260         (rank_one_type): ... this.
8261
8262 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8263
8264         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8265         from...
8266         (rank_one_type): ... this.
8267
8268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8269
8270         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8271         from...
8272         (rank_one_type): ... this.
8273
8274 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8275
8276         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8277         from...
8278         (rank_one_type): ... this.
8279
8280 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8281
8282         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8283         from...
8284         (rank_one_type): ... this.
8285
8286 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8287
8288         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8289         from...
8290         (rank_one_type): ... this.
8291
8292 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8293
8294         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8295         from...
8296         (rank_one_type): ... this.
8297
8298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8299
8300         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8301         from...
8302         (rank_one_type): ... this.
8303
8304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8305
8306         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8307         from...
8308         (rank_one_type): ... this.
8309
8310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8311
8312         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8313         from...
8314         (rank_one_type): ... this.
8315
8316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8317
8318         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8319         from...
8320         (rank_one_type): ... this.
8321
8322 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8323
8324         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8325         inferior-events' shows the example events.
8326
8327 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8328
8329         Support styling on native MS-Windows console
8330
8331         PR/24315
8332         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8333         on MS-Windows if $TERM is not defined.
8334
8335         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8336
8337         * posix-hdep.c (gdb_console_fputs):
8338         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8339         functions.
8340         * ui-file.h (gdb_console_fputs): Add prototype.
8341
8342         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8343         back to fputs only if the former returns zero.
8344
8345 2019-03-07  Tom Tromey  <tom@tromey.com>
8346
8347         * symmisc.c (print_symbol_bcache_statistics): Update.
8348         (print_objfile_statistics): Update.
8349         * symfile.c (allocate_symtab): Update.
8350         * stabsread.c: Don't include bcache.h.
8351         * psymtab.h (struct psymbol_bcache): Don't declare.
8352         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8353         (psymbol_bcache_init, psymbol_bcache_free)
8354         (psymbol_bcache_get_bcache): Don't declare.
8355         * psymtab.c (struct psymbol_bcache): Remove.
8356         (psymtab_storage::psymtab_storage): Update.
8357         (psymtab_storage::~psymtab_storage): Update.
8358         (psymbol_bcache_init, psymbol_bcache_free)
8359         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8360         (add_psymbol_to_bcache): Update.
8361         (allocate_psymtab): Update.
8362         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8363         macro_cache>: No longer pointers.
8364         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8365         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8366         * macrotab.c (macro_bcache): Update.
8367         * macroexp.c: Don't include bcache.h.
8368         * gdbtypes.c (check_types_worklist): Update.
8369         (types_deeply_equal): Remove TRY/CATCH.  Update.
8370         * elfread.c (elf_symtab_read): Update.
8371         * dwarf2read.c: Don't include bcache.h.
8372         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8373         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8374         (print_bcache_statistics, bcache_memory_used): Don't declare.
8375         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8376         methods.  Rename all data members.
8377         * bcache.c (struct bcache): Move to bcache.h.
8378         (bcache::expand_hash_table): Rename from expand_hash_table.
8379         (bcache): Remove.
8380         (bcache::insert): Rename from bcache_full.
8381         (bcache::compare): Rename from bcache_compare.
8382         (bcache_xmalloc): Remove.
8383         (bcache::~bcache): Rename from bcache_xfree.
8384         (bcache::print_statistics): Rename from print_bcache_statistics.
8385         (bcache::memory_used): Rename from bcache_memory_used.
8386
8387 2019-03-07  Pedro Alves  <palves@redhat.com>
8388
8389         * infrun.c (normal_stop): Also check for
8390         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8391
8392 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8393
8394         * f-lang.c (value_from_host_double): Moved to...
8395         * value.c (value_from_host_double): ...here.
8396         * value.h (value_from_host_double): Declare.
8397         * guile/scm-math.c (vlscm_convert_typed_number): Use
8398         value_from_host_double.
8399         (vlscm_convert_number): Likewise.
8400         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8401         * python/py-value.c (convert_value_from_python): Likewise.
8402
8403 2019-03-06  Tom Tromey  <tom@tromey.com>
8404
8405         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8406
8407 2019-03-06  Tom Tromey  <tom@tromey.com>
8408
8409         * utils.h (free_current_contents): Don't declare.
8410         * utils.c (free_current_contents): Remove.
8411
8412 2019-03-06  Tom Tromey  <tom@tromey.com>
8413
8414         * top.c (quit_force): Update.
8415         * main.c (captured_command_loop): Update.
8416         * common/new-op.c (operator new): Update.
8417         * common/common-exceptions.c (struct catcher)
8418         <save_cleanup_chain>: Remove member.
8419         (exceptions_state_mc_init): Update.
8420         (exception_try_scope_entry): Return nullptr.
8421         (exception_try_scope_exit, exception_rethrow)
8422         (throw_exception_sjlj, throw_exception_cxx): Update.
8423         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8424         (all_cleanups, do_cleanups, discard_cleanups)
8425         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8426         (restore_cleanups, restore_final_cleanups): Don't declare.
8427         (do_final_cleanups): Remove parameter.
8428         * common/cleanups.c (cleanup_chain, make_cleanup)
8429         (make_cleanup_dtor, all_cleanups, do_cleanups)
8430         (discard_my_cleanups, discard_cleanups)
8431         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8432         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8433         (null_cleanup): Remove.
8434         (do_final_cleanups): Remove parameter.
8435
8436 2019-03-06  Tom Tromey  <tom@tromey.com>
8437
8438         * remote.c (remote_target::remote_parse_stop_reply): Use
8439         unique_xmalloc_ptr.
8440
8441 2019-03-06  Tom Tromey  <tom@tromey.com>
8442
8443         * stabsread.c (struct stabs_field_info): Rename from field_info.
8444         <list, fnlist>: Add initializers.
8445         <obstack>: New member.
8446         (read_member_functions, read_struct_fields, read_baseclasses):
8447         Allocate on obstack.  Don't use cleanups.
8448         (read_one_struct_field, read_member_functions, read_struct_fields)
8449         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8450         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8451         (read_struct_type): Update.
8452
8453 2019-03-06  Tom Tromey  <tom@tromey.com>
8454
8455         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8456         * common/filestuff.h (make_cleanup_close): Don't declare.
8457         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8458         Remove.
8459
8460 2019-03-06  Tom Tromey  <tom@tromey.com>
8461
8462         * solib-aix.c: Use make_scope_exit.
8463
8464 2019-03-06  Tom Tromey  <tom@tromey.com>
8465
8466         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8467         Use make_scope_exit.
8468
8469 2019-03-06  Tom Tromey  <tom@tromey.com>
8470
8471         * solib-svr4.c (disable_probes_interface): Remove parameter.
8472         (svr4_handle_solib_event): Use make_scope_exit.
8473
8474 2019-03-06  Tom Tromey  <tom@tromey.com>
8475
8476         * remote.c (struct stop_reply_deleter): Remove.
8477         (stop_reply_up): Update.
8478         (struct stop_reply): Derive from notif_event.  Don't typedef.
8479         <regcache>: Now a std::vector.
8480         (stop_reply_xfree): Remove.
8481         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8482         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8483         (remote_target::discard_pending_stop_replies): Use delete.
8484         (remote_target::remote_parse_stop_reply): Update.
8485         (remote_target::process_stop_reply): Update.
8486         * remote-notif.h (struct notif_event): Add virtual destructor.
8487         Remove "dtr" member.
8488         (struct notif_client) <alloc_event>: Return a unique_ptr.
8489         (notif_event_xfree): Don't declare.
8490         (notif_event_up): New typedef.
8491         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8492         (notif_event_xfree, do_notif_event_xfree): Remove.
8493         (remote_notif_state_xfree): Update.
8494
8495 2019-03-06  Tom Tromey  <tom@tromey.com>
8496
8497         * infrun.c (displaced_step_clear_cleanup): Now a
8498         forward_scope_exit type.
8499         (displaced_step_prepare_throw): Update.
8500         (displaced_step_fixup): Update.
8501
8502 2019-03-06  Tom Tromey  <tom@tromey.com>
8503
8504         * inferior.h (class inferior): Update comment.
8505         * gdbthread.h (class thread_info): Update comment.
8506
8507 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8508             Tom Tromey  <tom@tromey.com>
8509
8510         * stabsread.h (struct stab_section_list): Remove.
8511         (coffstab_build_psymtabs): Update.
8512         * dbxread.c (symbuf_sections): Now a std::vector.
8513         (sect_idx): New global.
8514         (fill_symbuf): Update.
8515         (coffstab_build_psymtabs): Change type of stabsects parameter.
8516         Update.
8517         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8518         std::vector.
8519         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8520         (coff_locate_sections): Update.
8521         (coff_symfile_read): Remove cleanups.  Update.
8522         (init_stringtab): Add storage parameter.
8523         (free_stringtab, free_stringtab_cleanup): Remove.
8524         (init_lineno): Add storage parameter.
8525         (free_linetab, free_linetab_cleanup): Remove.
8526
8527 2019-03-06  Pedro Alves  <palves@redhat.com>
8528
8529         * linux-fork.c (fork_info::clobber_regs): Delete.
8530         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8531         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8532         comment.  Adjust.
8533         (scoped_switch_fork_info::scoped_switch_fork_info)
8534         (checkpoint_command, linux_fork_context): Adjust
8535         fork_save_infrun_state calls.
8536
8537 2019-03-06  Pedro Alves  <palves@redhat.com>
8538
8539         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8540         (inf_has_multiple_threads): Return 'bool' and rewrite using
8541         inferior_info::threads().
8542
8543 2019-03-06  Pedro Alves  <palves@redhat.com>
8544
8545         * linux-fork.c: Include <list>.
8546         (fork_list): Now a std::list instance.
8547         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8548         (forks_exist_p, find_last_fork): Adjust.
8549         (new_fork): Delete.
8550         (one_fork_p): New.
8551         (add_fork): Adjust.
8552         (free_fork): Delete, folded into fork_info::~fork_info().
8553         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8554         Adjust.
8555         (init_fork_list): Delete.
8556         (linux_fork_killall, linux_fork_mourn_inferior)
8557         (linux_fork_detach, info_checkpoints_command): Adjust.
8558         (_initialize_linux_fork): No longer call init_fork_list.
8559
8560 2019-03-06  Pedro Alves  <palves@redhat.com>
8561
8562         * linux-fork.c (new_fork): New, split out of ...
8563         (add_fork): ... this.  Return void.  Move "first fork" special
8564         case from here, to ...
8565         (checkpoint_command): ... here.
8566         * linux-linux.h (add_fork): Return void.
8567
8568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8569
8570         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8571
8572 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8573             Chris January  <chris.january@arm.com>
8574             David Lecomber  <david.lecomber@arm.com>
8575
8576         * f-exp.y: New token, UNOP_INTRINSIC.
8577         (exp): New pattern using UNOP_INTRINSIC token.
8578         (f77_keywords): Add 'abs' keyword.
8579         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8580         (value_from_host_double): New function.
8581         (evaluate_subexp_f): Support UNOP_ABS.
8582
8583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8584
8585         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8586         types.
8587
8588 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8589
8590         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8591         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8592         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8593
8594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8595
8596         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8597
8598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8599             Chris January  <chris.january@arm.com>
8600
8601         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8602         * f-exp.y: Define 'KIND' token.
8603         (exp): New pattern for KIND expressions.
8604         (ptype): Handle types with a kind extension.
8605         (direct_abs_decl): Extend to spot kind extensions.
8606         (f77_keywords): Add 'kind' to the list.
8607         (push_kind_type): New function.
8608         (convert_to_kind_type): New function.
8609         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8610         * parse.c (operator_length_standard): Likewise.
8611         * parser-defs.h (enum type_pieces): Add tp_kind.
8612         * std-operator.def: Add UNOP_KIND.
8613
8614 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8615
8616         * f-exp.y (f_parse): Set yydebug.
8617
8618 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8619
8620         * f-lang.c (evaluate_subexp_f): New function.
8621         (exp_descriptor_f): New global.
8622         (f_language_defn): Use exp_descriptor_f instead of
8623         exp_descriptor_standard.
8624
8625 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8626
8627         * f-exp.y (struct token): Add comments.
8628         (dot_ops): Remove uppercase versions and the end marker.
8629         (f77_keywords): Likewise.
8630         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8631         entries in the dot_ops array are case insensitive, and use
8632         strncasecmp to compare strings.  Also some whitespace cleanup in
8633         this area.  Similar for the f77_keywords array, except entries in
8634         this list might be case sensitive.
8635
8636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8637
8638         * f-exp.y (struct f77_boolean_val): Add comments.
8639         (boolean_values): Remove uppercase versions, and end marker.
8640         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8641         and use strncasecmp to achieve case insensitivity.  Additionally,
8642         perform whitespace cleanup around this code.
8643
8644 2019-03-06  Tom Tromey  <tromey@adacore.com>
8645
8646         * remote-sim.c (gdbsim_target_open): Use result of
8647         gdb_argv::release.
8648
8649 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8650         Dirk Schubert  <dirk.schubert@arm.com>
8651         Chris January  <chris.january@arm.com>
8652
8653         * eval.c (evaluate_subexp_standard): Call Fortran argument
8654         wrapping logic.
8655         * f-lang.c (struct value): A value which can be passed into a
8656         Fortran function call.
8657         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8658         where appropriate.
8659         (struct type): Value ready for a Fortran function call.
8660         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8661         is needed.
8662         * f-lang.h (fortran_argument_convert): Declaration.
8663         (fortran_preserve_arg_pointer): Declaration.
8664         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8665
8666 2019-03-05  Tom Tromey  <tromey@adacore.com>
8667
8668         * python/py-prettyprint.c (print_string_repr): Remove #if.
8669         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8670
8671 2019-03-05  Tom Tromey  <tromey@adacore.com>
8672
8673         * target.c (the_dummy_target): Move later.  Change type to
8674         "dummy_target".
8675         (initialize_targets): Don't initialize the_dummy_target.
8676
8677 2019-03-05  Tom Tromey  <tromey@adacore.com>
8678
8679         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8680         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8681
8682 2019-03-05  Tom Tromey  <tromey@adacore.com>
8683
8684         * windows-nat.c (windows_nat_target::attach)
8685         (windows_nat_target::detach): Don't call gdb_flush.
8686         * valprint.c (generic_val_print, val_print, val_print_string):
8687         Don't call gdb_flush.
8688         * utils.c (defaulted_query): Don't call gdb_flush.
8689         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8690         * target.c (target_announce_detach): Don't call gdb_flush.
8691         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8692         * remote.c (extended_remote_target::attach): Don't call
8693         gdb_flush.
8694         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8695         * printcmd.c (do_examine): Don't call gdb_flush.
8696         (info_display_command): Don't call gdb_flush.
8697         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8698         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8699         * memattr.c (info_mem_command): Don't call gdb_flush.
8700         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8701         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8702         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8703         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8704         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8705         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8706         (gnu_nat_target::detach): Don't call gdb_flush.
8707         * f-valprint.c (f_val_print): Don't call gdb_flush.
8708         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8709         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8710         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8711         gdb_flush.
8712         * c-valprint.c (c_val_print): Don't call gdb_flush.
8713         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8714
8715 2019-03-05  Tom Tromey  <tromey@adacore.com>
8716
8717         * varobj.c (update_dynamic_varobj_children): Update.
8718         (install_default_visualizer): Use reset, not release.
8719         * value.c (set_internalvar): Update.
8720         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8721         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8722         ATTRIBUTE_UNUSED_RESULT.
8723
8724 2019-03-05  Tom Tromey  <tromey@adacore.com>
8725
8726         * remote.c (class scoped_remote_fd) <release>: Add
8727         ATTRIBUTE_UNUSED_RESULT.
8728
8729 2019-03-05  Tom Tromey  <tromey@adacore.com>
8730
8731         * macroexp.c (struct macro_buffer) <release>: Add
8732         ATTRIBUTE_UNUSED_RESULT.
8733
8734 2019-03-05  Tom Tromey  <tromey@adacore.com>
8735
8736         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8737         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8738         ATTRIBUTE_UNUSED_RESULT.
8739
8740 2019-03-05  Tom Tromey  <tromey@adacore.com>
8741
8742         * common/scoped_fd.h (class scoped_fd) <release>: Add
8743         ATTRIBUTE_UNUSED_RESULT.
8744
8745 2019-03-05  Tom Tromey  <tromey@adacore.com>
8746
8747         * parser-defs.h (struct parser_state) <release>: Add
8748         ATTRIBUTE_UNUSED_RESULT.
8749
8750 2019-03-05  Tom Tromey  <tromey@adacore.com>
8751
8752         * utils.h (class gdb_argv) <release>: Add
8753         ATTRIBUTE_UNUSED_RESULT.
8754         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8755
8756 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8757
8758         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8759         for-loop range, to avoid compiler warnings.
8760
8761         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8762         avoid compiler warnings about unused variables.
8763
8764         * NEWS: Mention end of support for native debugging on MS-Windows
8765         before XP.
8766
8767         PR gdb/24292
8768         * common/netstuff.c:
8769         * gdbserver/gdbreplay.c
8770         * gdbserver/remote-utils.c:
8771         * ser-tcp.c:
8772         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8773         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8774         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8775         'getaddrinfo' and 'freeaddrinfo' were not available before
8776         Windows XP, and mingw.org's MinGW headers by default define
8777         _WIN32_WINNT to 0x500.
8778
8779 2019-03-01  Gary Benson <gbenson@redhat.com>
8780
8781         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8782
8783 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8784             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8785
8786         PR gdb/8527
8787         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8788         set_sigint_trap, clear_sigint_trap.
8789
8790 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8791
8792         * target.c (target_detach): Clear the regcache and the
8793         frame cache.
8794
8795 2019-02-27  Pedro Alves  <palves@redhat.com>
8796
8797         * utils.c (set_screen_size): When we cap the height/width sizes,
8798         tweak the corresponding command variable to show "unlimited":
8799
8800 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8801             Pedro Alves  <palves@redhat.com>
8802
8803         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8804         before calling rl_set_screen_size.
8805
8806 2019-02-27  Tom Tromey  <tromey@adacore.com>
8807
8808         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8809         define.
8810         * python/py-value.c: Remove Python 2.4 workaround.
8811         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8812         workaround.
8813         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8814         Python 2.4 workaround.
8815         * python/python-internal.h: Remove Python 2.4 comment.
8816         (Py_ssize_t): Don't define.
8817         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8818         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8819         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8820         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8821         * python/python.c (do_start_initialization): Remove Python 2.4
8822         workaround.
8823         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8824         (print_children): Remove Python 2.4 workaround.
8825         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8826         workaround.
8827         (CHARBUFFERPROC_NAME): Remove.
8828         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8829         Python 2.4 workaround.
8830
8831 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8832
8833         * NEWS: Note minimum Python version.
8834
8835 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8836
8837         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8838         code from these functions.  Remove corresponding ifdefs.  Use
8839         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8840         Remove gotos and target of gotos.
8841         (infpy_search_memory): Likewise.
8842
8843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8846         (hppa_gdbarch_init): Don't register deleted functions with
8847         gdbarch.
8848
8849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8850
8851         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8852         (h8300_unwind_sp): Delete.
8853         (h8300_dummy_id): Delete.
8854         (h8300_gdbarch_init): Don't register deleted functions with
8855         gdbarch.
8856
8857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8858
8859         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8860         (ft32_unwind_pc): Delete.
8861         (ft32_unwind_sp): Delete.
8862         (ft32_gdbarch_init): Don't register deleted functions with
8863         gdbarch.
8864
8865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8866
8867         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8868         (frv_unwind_pc): Delete.
8869         (frv_unwind_sp): Delete.
8870         (frv_gdbarch_init): Don't register deleted functions with
8871         gdbarch.
8872
8873 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8874
8875         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8876         (riscv_unwind_pc): Delete.
8877         (riscv_unwind_sp): Delete.
8878         (riscv_gdbarch_init): Don't register deleted functions with
8879         gdbarch.
8880
8881 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8884         (csky_unwind_pc): Delete.
8885         (csky_unwind_sp): Delete.
8886         (csky_gdbarch_init): Don't register deleted functions with
8887         gdbarch.
8888
8889 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8890
8891         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8892         (cris_unwind_pc): Delete.
8893         (cris_unwind_sp): Delete.
8894         (cris_gdbarch_init): Don't register deleted functions with
8895         gdbarch.
8896
8897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8898
8899         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8900         (bfin_unwind_pc): Delete.
8901         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8902
8903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8904
8905         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8906         (arm_unwind_pc): Delete.
8907         (arm_unwind_sp): Delete.
8908         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8909
8910 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8911
8912         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8913         (arc_unwind_pc): Delete.
8914         (arc_unwind_sp): Delete.
8915         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8916
8917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8918
8919         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8920         (alpha_unwind_pc): Delete.
8921         (alpha_gdbarch_init): Don't register deleted functions with
8922         gdbarch.
8923
8924 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8927         (aarch64_unwind_pc): Delete.
8928         (aarch64_unwind_sp): Delete.
8929         (aarch64_gdbarch_init): Don't register deleted functions with
8930         gdbarch.
8931
8932 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8933
8934         * gdbtypes.c (type_align): Don't consider static members when
8935         computing structure alignment.
8936
8937 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8938
8939         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8940         return 0 for other types.
8941         * arch-utils.c (default_type_align): Always return 0.
8942         * gdbarch.h: Regenerate.
8943         * gdbarch.sh (type_align): Extend comment.
8944         * gdbtypes.c (type_align): Add additional comments, always call
8945         gdbarch_type_align before applying the default rules.
8946         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8947         generic code will then apply a suitable default.
8948         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8949         types, return 0 for other types.
8950
8951 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8952
8953         * NEWS: Create a new section for the next release branch.
8954         Rename the section of the current branch, now that it has
8955         been cut.
8956
8957 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8958
8959         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8960         * version.in: Bump version to 8.3.50.DATE-git.
8961
8962 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8963
8964         * aix-thread.c (ptid_cmp): Remove unused variable.
8965         (get_signaled_thread): Likewise.
8966         (store_regs_user_thread): Likewise.
8967         (store_regs_kernel_thread): Likewise.
8968         (fetch_regs_kernel_thread): Remove shadowed variable.
8969
8970 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8971
8972         * features/riscv/32bit-cpu.xml: Add register numbers.
8973         * features/riscv/32bit-fpu.c: Regenerate.
8974         * features/riscv/32bit-fpu.xml: Add register numbers.
8975         * features/riscv/64bit-cpu.xml: Add register numbers.
8976         * features/riscv/64bit-fpu.c: Regenerate.
8977         * features/riscv/64bit-fpu.xml: Add register numbers.
8978
8979 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8980
8981         * NEWS: Mention two argument form of gdb.Value constructor.
8982         * python/py-value.c (convert_buffer_and_type_to_value): New
8983         function.
8984         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8985         Add support for handling an optional second argument.  Call
8986         convert_buffer_and_type_to_value as appropriate.
8987         * python/python-internal.h (Py_buffer_deleter): New struct.
8988         (Py_buffer_up): New typedef.
8989
8990 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8991
8992         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8993         instead of releasing ownership.
8994
8995 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8996
8997         * dwarf2read.c (open_and_init_dwp_file): Call
8998         elf_numsections instead of bfd_count_sections to initialize
8999         dwp_file->num_sections.
9000
9001 2019-02-25  Tom Tromey  <tromey@adacore.com>
9002
9003         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9004
9005 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9006
9007         * gcore.in: Add '--readnever' option when invoking GDB.
9008
9009 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9010
9011         * MAINTAINERS: Update my email address.
9012
9013 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9014
9015         * build-id.c (build_id_to_debug_bfd_1): New function.
9016         (build_id_to_debug_bfd): Look for separate debug file in
9017         sysroot.
9018
9019 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9020
9021         * gdbarch.sh: Update the copyright year range that is placed into
9022         generated files.
9023
9024 2019-02-22  Keith Seitz  <keiths@redhat.com>
9025
9026         PR symtab/23853
9027         * linespec.c (create_sals_line_offset): Search for the default
9028         symtab's filename instead of its fullname.
9029
9030 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9031
9032         * NEWS: Update style defaults.
9033
9034 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9035
9036         * main.c (captured_main_1): Disable styling in batch mode.
9037
9038 2019-02-20  Tom Tromey  <tom@tromey.com>
9039
9040         * symtab.c (symtab_symbol_info): Fix typos.
9041
9042 2019-02-20  Tom Tromey  <tromey@adacore.com>
9043
9044         * findcmd.c (_initialize_mem_search): Use upper case for
9045         metasyntactic variables.
9046
9047 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9048
9049         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9050         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9051
9052 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9053
9054         * top.h (source_file_name): Change to std::string.
9055         * top.c (source_file_name): Likewise.
9056         (command_line_input): Adjust.
9057         * cli/cli-script.c (script_from_file): Adjust.
9058
9059 2019-02-19  Tom Tromey  <tromey@adacore.com>
9060
9061         * ravenscar-thread.c
9062         (ravenscar_thread_target::update_thread_list): Don't call
9063         ada_build_task_list.
9064         * ada-lang.h (ada_build_task_list): Don't declare.
9065         * ada-tasks.c (struct ada_tasks_inferior_data)
9066         <task_list_valid_p>: Now bool.
9067         (read_known_tasks, ada_task_list_changed)
9068         (ada_tasks_invalidate_inferior_data): Update.
9069         (read_known_tasks_array): Return bool.
9070         (read_known_tasks_list): Likewise.
9071         (read_known_tasks): Return void.
9072         (ada_build_task_list): Now static.
9073
9074 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9075
9076         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9077         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9078
9079 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9080
9081         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9082         variant for ada_tasks_pspace_data_handle and
9083         ada_tasks_inferior_data_handle.
9084         (ada_tasks_pspace_data_cleanup): New function.
9085         (ada_tasks_inferior_data_cleanup): New function.
9086
9087 2019-02-17  Tom Tromey  <tom@tromey.com>
9088
9089         * macrotab.h (macro_source_fullname): Return a std::string.
9090         * macrotab.c (macro_include, check_for_redefinition)
9091         (macro_undef, macro_lookup_definition, foreach_macro)
9092         (foreach_macro_in_scope): Update.
9093         (macro_source_fullname): Return a std::string.
9094         * macrocmd.c (show_pp_source_pos): Update.
9095
9096 2019-02-17  Tom Tromey  <tom@tromey.com>
9097
9098         * macrocmd.c (show_pp_source_pos): Style the file names.
9099
9100 2019-02-17  Tom Tromey  <tom@tromey.com>
9101
9102         PR tui/24197:
9103         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9104
9105 2019-02-17  Tom Tromey  <tom@tromey.com>
9106
9107         * ada-lang.c (user_select_syms): Use filtered printing.
9108         * utils.c (wrap_style): New global.
9109         (desired_style): Remove.
9110         (emit_style_escape): Add stream parameter.
9111         (set_output_style, reset_terminal_style, prompt_for_continue):
9112         Update.
9113         (flush_wrap_buffer): Only flush gdb_stdout.
9114         (wrap_here): Set wrap_style.
9115         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9116         treat escape sequences as a character.  Change when wrap buffer is
9117         flushed.
9118         (fputs_styled): Do not set the output style when the default is
9119         requested.
9120         * ui-style.h (struct ui_file_style) <is_default>: New method.
9121         * source.c (print_source_lines_base): Emit escape sequences in one
9122         piece.
9123
9124 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9125
9126         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9127         integers and enumeration types.
9128
9129 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9130
9131         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9132         instead of lookup_symbol_in_language
9133         (do_exact_match): New function.
9134         (ada_get_symbol_name_matcher): Return do_exact_match when
9135         doing a verbatim match.
9136
9137 2019-02-15  Tom Tromey  <tromey@adacore.com>
9138
9139         * ravenscar-thread.c (ravenscar_thread_target::resume)
9140         (ravenscar_thread_target::wait): Special case wildcard requests.
9141
9142 2019-02-15  Tom Tromey  <tromey@adacore.com>
9143
9144         * ravenscar-thread.c (base_ptid): Remove.
9145         (struct ravenscar_thread_target) <close>: New method.
9146         <m_base_ptid>: New member.
9147         <update_inferior_ptid, active_task, task_is_currently_active,
9148         runtime_initialized>: Declare methods.
9149         <ravenscar_thread_target>: Add constructor.
9150         (ravenscar_thread_target::task_is_currently_active)
9151         (ravenscar_thread_target::update_inferior_ptid)
9152         (ravenscar_runtime_initialized): Rename.  Now methods.
9153         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9154         (ravenscar_thread_target::update_thread_list): Update.
9155         (ravenscar_thread_target::active_task): Now method.
9156         (ravenscar_thread_target::store_registers)
9157         (ravenscar_thread_target::prepare_to_store)
9158         (ravenscar_thread_target::prepare_to_store)
9159         (ravenscar_thread_target::mourn_inferior): Update.
9160         (ravenscar_inferior_created): Use "new" to create target.
9161         (ravenscar_thread_target::get_ada_task_ptid): Update.
9162         (_initialize_ravenscar): Don't initialize base_ptid.
9163         (ravenscar_ops): Remove global.
9164
9165 2019-02-15  Tom Tromey  <tromey@adacore.com>
9166
9167         * target.h (push_target): Declare new overload.
9168         * target.c (push_target): New overload, taking an rvalue reference.
9169         * remote.c (remote_target::open_1): Use push_target overload.
9170         * corelow.c (core_target_open): Use push_target overload.
9171
9172 2019-02-15  Tom Tromey  <tromey@adacore.com>
9173
9174         * ravenscar-thread.c (is_ravenscar_task)
9175         (ravenscar_task_is_currently_active): Return bool.
9176         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9177         (_initialize_ravenscar): Remove "(void)".
9178         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9179         Return bool.
9180
9181 2019-02-15  Tom Tromey  <tromey@adacore.com>
9182
9183         * ravenscar-thread.c (ravenscar_runtime_initializer)
9184         (has_ravenscar_runtime, get_running_thread_id)
9185         (ravenscar_thread_target::resume): Fix indentation.
9186
9187 2019-02-15  Tom Tromey  <tromey@adacore.com>
9188
9189         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9190         from ravenscar_arch_ops.
9191         (sparc_ravenscar_ops::fetch_registers)
9192         (sparc_ravenscar_ops::store_registers): Now methods.
9193         (sparc_ravenscar_prepare_to_store): Remove.
9194         (sparc_ravenscar_ops): Redefine.
9195         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9196         methods and destructor.  Remove members.
9197         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9198         (ravenscar_thread_target::store_registers)
9199         (ravenscar_thread_target::prepare_to_store): Update.
9200         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9201         Remove.
9202         (struct ppc_ravenscar_powerpc_ops): Derive from
9203         ravenscar_arch_ops.
9204         (ppc_ravenscar_powerpc_ops::fetch_registers)
9205         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9206         (ppc_ravenscar_powerpc_ops): Redefine.
9207         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9208         (ppc_ravenscar_e500_ops::fetch_registers)
9209         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9210         (ppc_ravenscar_e500_ops): Redefine.
9211         * aarch64-ravenscar-thread.c
9212         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9213         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9214         (aarch64_ravenscar_fetch_registers)
9215         (aarch64_ravenscar_store_registers): Now methods.
9216         (aarch64_ravenscar_ops): Redefine.
9217
9218 2019-02-15  Tom Tromey  <tromey@adacore.com>
9219
9220         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9221         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9222         (ravenscar_thread_target::stopped_by_watchpoint)
9223         (ravenscar_thread_target::stopped_data_address)
9224         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9225
9226 2019-02-15  Tom Tromey  <tromey@adacore.com>
9227
9228         * ravenscar-thread.c: Fix some typos.
9229
9230 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9231             Tom Tromey  <tromey@adacore.com>
9232
9233         * ada-lang.c (ada_exception_sal): Change addr_string to a
9234         std::string.
9235         (create_ada_exception_catchpoint): Update.
9236
9237 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9238             Tom Tromey  <tromey@adacore.com>
9239
9240         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9241         (bp_location_ops): Remove.
9242         (base_breakpoint_allocate_location): Update.
9243         (free_bp_location): Update.
9244         * ada-lang.c (class ada_catchpoint_location)
9245         <ada_catchpoint_location>: Remove ops parameter.
9246         (ada_catchpoint_location_dtor): Remove.
9247         (ada_catchpoint_location_ops): Remove.
9248         (allocate_location_exception): Update.
9249         * breakpoint.h (struct bp_location_ops): Remove.
9250         (class bp_location) <bp_location>: Remove bp_location_ops
9251         parameter.
9252         <~bp_location>: Add destructor.
9253         <ops>: Remove.
9254
9255 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9256             Pedro Alves  <palves@redhat.com>
9257
9258         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9259         'PATH_MAX'.
9260
9261 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9262             Samuel Thibault  <samuel.thibault@gnu.org>
9263             Thomas Schwinge  <thomas@codesourcery.com>
9264
9265         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9266         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9267
9268 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9269
9270         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9271         (check_empty): Use "const char *".
9272
9273         * gnu-nat.c (gnu_nat_target::detach): Instead of
9274         'detach_inferior (pid)' call
9275         'detach_inferior (find_inferior_pid (pid))'.
9276
9277         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9278         'nat/fork-inferior.o'.
9279         * gnu-nat.c: #include "nat/fork-inferior.h".
9280
9281         * gnu-nat.c (gnu_nat_target::detach): Instead of
9282         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9283         * gnu-nat.h: #include "inf-child.h".
9284         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9285         'i386_gnu_nat_target::fetch_registers'.
9286         (gnu_store_registers): Rename/move to
9287         'i386_gnu_nat_target::store_registers'.
9288
9289         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9290         * gnu-nat.h (mach_thread_info): New function.
9291         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9292
9293         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9294
9295 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9296
9297         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9298
9299 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9300
9301         * windows-nat.c (windows_add_thread): Add new parameter
9302         "main_thread_p" with default value set to false.  Update
9303         function documentation as well as all callers.
9304         (windows_delete_thread): Likewise.
9305         (fake_create_process): Update call to windows_add_thread.
9306         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9307         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9308         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9309         call to windows_delete_thread.
9310
9311 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9312
9313         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9314
9315 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9316
9317         * symfile.c (find_separate_debug_file): Use canonical path of
9318         sysroot with child_path instead of gdb_sysroot if it is valid.
9319
9320 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9321
9322         * symfile.c (find_separate_debug_file): Use child_path to
9323         determine if an object file is under a sysroot.
9324
9325 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9326
9327         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9328         unittests/child-path-selftests.c.
9329         * common/pathstuff.c (child_path): New function.
9330         * common/pathstuff.h (child_path): New prototype.
9331         * unittests/child-path-selftests.c: New file.
9332
9333 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9334
9335         * symfile.c (find_separate_debug_file): Look for separate debug
9336         files in debug directories under the sysroot.
9337
9338 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9339
9340         * symtab.h (struct minimal_symbol data_p): New const method.
9341         (struct minimal_symbol text_p): Likewise.
9342         * symtab.c (output_source_filename): Use file name style
9343         to print file name.
9344         (print_symbol_info): Likewise.
9345         (print_msymbol_info): Use address style to print addresses.
9346         Use function name style to print executable text symbols.
9347         (expand_symtab_containing_pc): Use data_p.
9348         (find_pc_sect_compunit_symtab): Likewise.
9349
9350 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9351
9352         * breakpoint.c (describe_other_breakpoints): Use address style
9353         to print addresses.
9354         (say_where): Likewise.
9355
9356 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9357
9358         * ada-typeprint.c (print_func_type): Print function name
9359         style to print function name.
9360         * c-typeprint.c (c_print_type_1): Likewise.
9361
9362 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9363
9364         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9365         for execve.
9366
9367 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9368
9369         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9370         type_stack.
9371
9372 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9373
9374         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9375         TYPE_CODE_REF types.
9376
9377 2019-02-08  Jim Wilson  <jimw@sifive.com>
9378
9379         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9380         (riscv_linux_fregset): New.
9381         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9382
9383 2019-02-07  Tom Tromey  <tom@tromey.com>
9384
9385         * thread.c (thread_cancel_execution_command): Update.
9386         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9387         methods.
9388         (struct thread_fsm_ops): Remove.
9389         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9390         (thread_fsm_should_stop, thread_fsm_return_value)
9391         (thread_fsm_set_finished, thread_fsm_finished_p)
9392         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9393         Don't declare.
9394         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9395         * infrun.c (clear_proceed_status_thread)
9396         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9397         (print_stop_event): Update.
9398         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9399         Add constructor.
9400         (step_command_fsm_ops): Remove.
9401         (new_step_command_fsm): Remove.
9402         (step_1): Update.
9403         (step_command_fsm::should_stop): Rename from
9404         step_command_fsm_should_stop.
9405         (step_command_fsm::clean_up): Rename from
9406         step_command_fsm_clean_up.
9407         (step_command_fsm::do_async_reply_reason): Rename from
9408         step_command_fsm_async_reply_reason.
9409         (struct until_next_fsm): Inherit from thread_fsm.  Add
9410         constructor.
9411         (until_next_fsm_ops): Remove.
9412         (new_until_next_fsm): Remove.
9413         (until_next_fsm::should_stop): Rename from
9414         until_next_fsm_should_stop.
9415         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9416         (until_next_fsm::do_async_reply_reason): Rename from
9417         until_next_fsm_async_reply_reason.
9418         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9419         constructor.  Change type of breakpoint.
9420         (finish_command_fsm_ops): Remove.
9421         (new_finish_command_fsm): Remove.
9422         (finish_command_fsm::should_stop): Rename from
9423         finish_command_fsm_should_stop.
9424         (finish_command_fsm::clean_up): Rename from
9425         finish_command_fsm_clean_up.
9426         (finish_command_fsm::return_value): Rename from
9427         finish_command_fsm_return_value.
9428         (finish_command_fsm::do_async_reply_reason): Rename from
9429         finish_command_fsm_async_reply_reason.
9430         (finish_command): Update.
9431         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9432         Add constructor.
9433         (call_thread_fsm_ops): Remove.
9434         (call_thread_fsm::call_thread_fsm): Rename from
9435         new_call_thread_fsm.
9436         (call_thread_fsm::should_stop): Rename from
9437         call_thread_fsm_should_stop.
9438         (call_thread_fsm::should_notify_stop): Rename from
9439         call_thread_fsm_should_notify_stop.
9440         (run_inferior_call, call_function_by_hand_dummy): Update.
9441         * cli/cli-interp.c (should_print_stop_to_console): Update.
9442         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9443         Add constructor.  Change type of location_breakpoint,
9444         caller_breakpoint.
9445         (until_break_fsm_ops): Remove.
9446         (new_until_break_fsm): Remove.
9447         (until_break_fsm::should_stop): Rename from
9448         until_break_fsm_should_stop.
9449         (until_break_fsm::clean_up): Rename from
9450         until_break_fsm_clean_up.
9451         (until_break_fsm::do_async_reply_reason): Rename from
9452         until_break_fsm_async_reply_reason.
9453         (until_break_command): Update.
9454         * thread-fsm.c: Remove.
9455         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9456
9457 2019-02-07  Tom Tromey  <tom@tromey.com>
9458
9459         * yy-remap.h: Add include guard.
9460         * xtensa-tdep.h: Add include guard.
9461         * xcoffread.h: Rename include guard.
9462         * varobj-iter.h: Add include guard.
9463         * tui/tui.h: Rename include guard.
9464         * tui/tui-winsource.h: Rename include guard.
9465         * tui/tui-wingeneral.h: Rename include guard.
9466         * tui/tui-windata.h: Rename include guard.
9467         * tui/tui-win.h: Rename include guard.
9468         * tui/tui-stack.h: Rename include guard.
9469         * tui/tui-source.h: Rename include guard.
9470         * tui/tui-regs.h: Rename include guard.
9471         * tui/tui-out.h: Rename include guard.
9472         * tui/tui-layout.h: Rename include guard.
9473         * tui/tui-io.h: Rename include guard.
9474         * tui/tui-hooks.h: Rename include guard.
9475         * tui/tui-file.h: Rename include guard.
9476         * tui/tui-disasm.h: Rename include guard.
9477         * tui/tui-data.h: Rename include guard.
9478         * tui/tui-command.h: Rename include guard.
9479         * tic6x-tdep.h: Add include guard.
9480         * target/waitstatus.h: Rename include guard.
9481         * target/wait.h: Rename include guard.
9482         * target/target.h: Rename include guard.
9483         * target/resume.h: Rename include guard.
9484         * target-float.h: Rename include guard.
9485         * stabsread.h: Add include guard.
9486         * rs6000-tdep.h: Add include guard.
9487         * riscv-fbsd-tdep.h: Add include guard.
9488         * regformats/regdef.h: Rename include guard.
9489         * record.h: Rename include guard.
9490         * python/python.h: Rename include guard.
9491         * python/python-internal.h: Rename include guard.
9492         * python/py-stopevent.h: Rename include guard.
9493         * python/py-ref.h: Rename include guard.
9494         * python/py-record.h: Rename include guard.
9495         * python/py-record-full.h: Rename include guard.
9496         * python/py-record-btrace.h: Rename include guard.
9497         * python/py-instruction.h: Rename include guard.
9498         * python/py-events.h: Rename include guard.
9499         * python/py-event.h: Rename include guard.
9500         * procfs.h: Add include guard.
9501         * proc-utils.h: Add include guard.
9502         * p-lang.h: Add include guard.
9503         * or1k-tdep.h: Rename include guard.
9504         * observable.h: Rename include guard.
9505         * nto-tdep.h: Rename include guard.
9506         * nat/x86-linux.h: Rename include guard.
9507         * nat/x86-linux-dregs.h: Rename include guard.
9508         * nat/x86-gcc-cpuid.h: Add include guard.
9509         * nat/x86-dregs.h: Rename include guard.
9510         * nat/x86-cpuid.h: Rename include guard.
9511         * nat/ppc-linux.h: Rename include guard.
9512         * nat/mips-linux-watch.h: Rename include guard.
9513         * nat/linux-waitpid.h: Rename include guard.
9514         * nat/linux-ptrace.h: Rename include guard.
9515         * nat/linux-procfs.h: Rename include guard.
9516         * nat/linux-osdata.h: Rename include guard.
9517         * nat/linux-nat.h: Rename include guard.
9518         * nat/linux-namespaces.h: Rename include guard.
9519         * nat/linux-btrace.h: Rename include guard.
9520         * nat/glibc_thread_db.h: Rename include guard.
9521         * nat/gdb_thread_db.h: Rename include guard.
9522         * nat/gdb_ptrace.h: Rename include guard.
9523         * nat/fork-inferior.h: Rename include guard.
9524         * nat/amd64-linux-siginfo.h: Rename include guard.
9525         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9526         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9527         * nat/aarch64-linux.h: Rename include guard.
9528         * nat/aarch64-linux-hw-point.h: Rename include guard.
9529         * mn10300-tdep.h: Add include guard.
9530         * mips-linux-tdep.h: Add include guard.
9531         * mi/mi-parse.h: Rename include guard.
9532         * mi/mi-out.h: Rename include guard.
9533         * mi/mi-main.h: Rename include guard.
9534         * mi/mi-interp.h: Rename include guard.
9535         * mi/mi-getopt.h: Rename include guard.
9536         * mi/mi-console.h: Rename include guard.
9537         * mi/mi-common.h: Rename include guard.
9538         * mi/mi-cmds.h: Rename include guard.
9539         * mi/mi-cmd-break.h: Rename include guard.
9540         * m2-lang.h: Add include guard.
9541         * location.h: Rename include guard.
9542         * linux-record.h: Rename include guard.
9543         * linux-nat.h: Add include guard.
9544         * linux-fork.h: Add include guard.
9545         * i386-darwin-tdep.h: Rename include guard.
9546         * hppa-linux-offsets.h: Add include guard.
9547         * guile/guile.h: Rename include guard.
9548         * guile/guile-internal.h: Rename include guard.
9549         * gnu-nat.h: Rename include guard.
9550         * gdb-stabs.h: Rename include guard.
9551         * frv-tdep.h: Add include guard.
9552         * f-lang.h: Add include guard.
9553         * event-loop.h: Add include guard.
9554         * darwin-nat.h: Rename include guard.
9555         * cp-abi.h: Rename include guard.
9556         * config/sparc/nm-sol2.h: Rename include guard.
9557         * config/nm-nto.h: Rename include guard.
9558         * config/nm-linux.h: Add include guard.
9559         * config/i386/nm-i386gnu.h: Rename include guard.
9560         * config/djgpp/nl_types.h: Rename include guard.
9561         * config/djgpp/langinfo.h: Rename include guard.
9562         * compile/gcc-cp-plugin.h: Add include guard.
9563         * compile/gcc-c-plugin.h: Add include guard.
9564         * compile/compile.h: Rename include guard.
9565         * compile/compile-object-run.h: Rename include guard.
9566         * compile/compile-object-load.h: Rename include guard.
9567         * compile/compile-internal.h: Rename include guard.
9568         * compile/compile-cplus.h: Rename include guard.
9569         * compile/compile-c.h: Rename include guard.
9570         * common/xml-utils.h: Rename include guard.
9571         * common/x86-xstate.h: Rename include guard.
9572         * common/version.h: Rename include guard.
9573         * common/vec.h: Rename include guard.
9574         * common/tdesc.h: Rename include guard.
9575         * common/selftest.h: Rename include guard.
9576         * common/scoped_restore.h: Rename include guard.
9577         * common/scoped_mmap.h: Rename include guard.
9578         * common/scoped_fd.h: Rename include guard.
9579         * common/safe-iterator.h: Rename include guard.
9580         * common/run-time-clock.h: Rename include guard.
9581         * common/refcounted-object.h: Rename include guard.
9582         * common/queue.h: Rename include guard.
9583         * common/ptid.h: Rename include guard.
9584         * common/print-utils.h: Rename include guard.
9585         * common/preprocessor.h: Rename include guard.
9586         * common/pathstuff.h: Rename include guard.
9587         * common/observable.h: Rename include guard.
9588         * common/netstuff.h: Rename include guard.
9589         * common/job-control.h: Rename include guard.
9590         * common/host-defs.h: Rename include guard.
9591         * common/gdb_wait.h: Rename include guard.
9592         * common/gdb_vecs.h: Rename include guard.
9593         * common/gdb_unlinker.h: Rename include guard.
9594         * common/gdb_unique_ptr.h: Rename include guard.
9595         * common/gdb_tilde_expand.h: Rename include guard.
9596         * common/gdb_sys_time.h: Rename include guard.
9597         * common/gdb_string_view.h: Rename include guard.
9598         * common/gdb_splay_tree.h: Rename include guard.
9599         * common/gdb_setjmp.h: Rename include guard.
9600         * common/gdb_ref_ptr.h: Rename include guard.
9601         * common/gdb_optional.h: Rename include guard.
9602         * common/gdb_locale.h: Rename include guard.
9603         * common/gdb_assert.h: Rename include guard.
9604         * common/filtered-iterator.h: Rename include guard.
9605         * common/filestuff.h: Rename include guard.
9606         * common/fileio.h: Rename include guard.
9607         * common/environ.h: Rename include guard.
9608         * common/common-utils.h: Rename include guard.
9609         * common/common-types.h: Rename include guard.
9610         * common/common-regcache.h: Rename include guard.
9611         * common/common-inferior.h: Rename include guard.
9612         * common/common-gdbthread.h: Rename include guard.
9613         * common/common-exceptions.h: Rename include guard.
9614         * common/common-defs.h: Rename include guard.
9615         * common/common-debug.h: Rename include guard.
9616         * common/cleanups.h: Rename include guard.
9617         * common/buffer.h: Rename include guard.
9618         * common/btrace-common.h: Rename include guard.
9619         * common/break-common.h: Rename include guard.
9620         * cli/cli-utils.h: Rename include guard.
9621         * cli/cli-style.h: Rename include guard.
9622         * cli/cli-setshow.h: Rename include guard.
9623         * cli/cli-script.h: Rename include guard.
9624         * cli/cli-interp.h: Rename include guard.
9625         * cli/cli-decode.h: Rename include guard.
9626         * cli/cli-cmds.h: Rename include guard.
9627         * charset-list.h: Add include guard.
9628         * buildsym-legacy.h: Rename include guard.
9629         * bfin-tdep.h: Add include guard.
9630         * ax.h: Rename include guard.
9631         * arm-linux-tdep.h: Add include guard.
9632         * arm-fbsd-tdep.h: Add include guard.
9633         * arch/xtensa.h: Rename include guard.
9634         * arch/tic6x.h: Add include guard.
9635         * arch/i386.h: Add include guard.
9636         * arch/arm.h: Rename include guard.
9637         * arch/arm-linux.h: Rename include guard.
9638         * arch/arm-get-next-pcs.h: Rename include guard.
9639         * arch/amd64.h: Add include guard.
9640         * arch/aarch64-insn.h: Rename include guard.
9641         * arch-utils.h: Rename include guard.
9642         * annotate.h: Add include guard.
9643         * amd64-darwin-tdep.h: Rename include guard.
9644         * aarch64-linux-tdep.h: Add include guard.
9645         * aarch64-fbsd-tdep.h: Add include guard.
9646         * aarch32-linux-nat.h: Add include guard.
9647
9648 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9649
9650         * macrotab.c (macro_define_internal): New function that
9651         factorizes macro_define_object_internal and macro_define_function
9652         code.
9653         (macro_define_object_internal): Use macro_define_internal.
9654         (macro_define_function): Likewise.
9655
9656 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9657
9658         * macrocmd.c (extract_identifier): Return
9659         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9660         callers.
9661
9662 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9663
9664         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9665
9666 2019-02-05  Tom Tromey  <tom@tromey.com>
9667
9668         * target.c (target_stack::unpush): Move assertion earlier.
9669
9670 2019-01-30  Tom Tromey  <tom@tromey.com>
9671
9672         PR python/23615:
9673         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9674         (gdbpy_parse_and_eval): Likewise.
9675         * python/python-internal.h (gdbpy_allow_threads): New class.
9676
9677 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9678
9679         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9680         (aarch64_fbsd_fpregmap): Move earlier.
9681         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9682         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9683         instead of individual calls to trad_frame_set_reg_addr.
9684         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9685         earlier.
9686         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9687         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9688         instead of individual calls to trad_frame_set_reg_addr.
9689
9690 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9691
9692         * CONTRIBUTE: Replace contribution list with wiki link.
9693
9694 2019-01-25  Tom Tromey  <tom@tromey.com>
9695
9696         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9697
9698 2019-01-25  Tom Tromey  <tom@tromey.com>
9699
9700         * xtensa-linux-nat.c: Fix common/ includes.
9701         * xml-support.h: Fix common/ includes.
9702         * xml-support.c: Fix common/ includes.
9703         * x86-linux-nat.c: Fix common/ includes.
9704         * windows-nat.c: Fix common/ includes.
9705         * varobj.h: Fix common/ includes.
9706         * varobj.c: Fix common/ includes.
9707         * value.c: Fix common/ includes.
9708         * valops.c: Fix common/ includes.
9709         * utils.c: Fix common/ includes.
9710         * unittests/xml-utils-selftests.c: Fix common/ includes.
9711         * unittests/utils-selftests.c: Fix common/ includes.
9712         * unittests/unpack-selftests.c: Fix common/ includes.
9713         * unittests/tracepoint-selftests.c: Fix common/ includes.
9714         * unittests/style-selftests.c: Fix common/ includes.
9715         * unittests/string_view-selftests.c: Fix common/ includes.
9716         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9717         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9718         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9719         * unittests/rsp-low-selftests.c: Fix common/ includes.
9720         * unittests/parse-connection-spec-selftests.c: Fix common/
9721         includes.
9722         * unittests/optional-selftests.c: Fix common/ includes.
9723         * unittests/offset-type-selftests.c: Fix common/ includes.
9724         * unittests/observable-selftests.c: Fix common/ includes.
9725         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9726         * unittests/memrange-selftests.c: Fix common/ includes.
9727         * unittests/memory-map-selftests.c: Fix common/ includes.
9728         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9729         * unittests/function-view-selftests.c: Fix common/ includes.
9730         * unittests/environ-selftests.c: Fix common/ includes.
9731         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9732         * unittests/common-utils-selftests.c: Fix common/ includes.
9733         * unittests/cli-utils-selftests.c: Fix common/ includes.
9734         * unittests/array-view-selftests.c: Fix common/ includes.
9735         * ui-file.c: Fix common/ includes.
9736         * tui/tui-io.c: Fix common/ includes.
9737         * tracepoint.h: Fix common/ includes.
9738         * tracepoint.c: Fix common/ includes.
9739         * tracefile-tfile.c: Fix common/ includes.
9740         * top.h: Fix common/ includes.
9741         * top.c: Fix common/ includes.
9742         * thread.c: Fix common/ includes.
9743         * target/waitstatus.h: Fix common/ includes.
9744         * target/waitstatus.c: Fix common/ includes.
9745         * target.h: Fix common/ includes.
9746         * target.c: Fix common/ includes.
9747         * target-memory.c: Fix common/ includes.
9748         * target-descriptions.c: Fix common/ includes.
9749         * symtab.h: Fix common/ includes.
9750         * symfile.c: Fix common/ includes.
9751         * stap-probe.c: Fix common/ includes.
9752         * spu-linux-nat.c: Fix common/ includes.
9753         * sparc-nat.c: Fix common/ includes.
9754         * source.c: Fix common/ includes.
9755         * solib.c: Fix common/ includes.
9756         * solib-target.c: Fix common/ includes.
9757         * ser-unix.c: Fix common/ includes.
9758         * ser-tcp.c: Fix common/ includes.
9759         * ser-pipe.c: Fix common/ includes.
9760         * ser-base.c: Fix common/ includes.
9761         * selftest-arch.c: Fix common/ includes.
9762         * s12z-tdep.c: Fix common/ includes.
9763         * rust-exp.y: Fix common/ includes.
9764         * rs6000-aix-tdep.c: Fix common/ includes.
9765         * riscv-tdep.c: Fix common/ includes.
9766         * remote.c: Fix common/ includes.
9767         * remote-notif.h: Fix common/ includes.
9768         * remote-fileio.h: Fix common/ includes.
9769         * remote-fileio.c: Fix common/ includes.
9770         * regcache.h: Fix common/ includes.
9771         * regcache.c: Fix common/ includes.
9772         * record-btrace.c: Fix common/ includes.
9773         * python/python.c: Fix common/ includes.
9774         * python/py-type.c: Fix common/ includes.
9775         * python/py-inferior.c: Fix common/ includes.
9776         * progspace.h: Fix common/ includes.
9777         * producer.c: Fix common/ includes.
9778         * procfs.c: Fix common/ includes.
9779         * proc-api.c: Fix common/ includes.
9780         * printcmd.c: Fix common/ includes.
9781         * ppc-linux-nat.c: Fix common/ includes.
9782         * parser-defs.h: Fix common/ includes.
9783         * osdata.c: Fix common/ includes.
9784         * obsd-nat.c: Fix common/ includes.
9785         * nat/x86-linux.c: Fix common/ includes.
9786         * nat/x86-linux-dregs.c: Fix common/ includes.
9787         * nat/x86-dregs.h: Fix common/ includes.
9788         * nat/x86-dregs.c: Fix common/ includes.
9789         * nat/ppc-linux.c: Fix common/ includes.
9790         * nat/mips-linux-watch.h: Fix common/ includes.
9791         * nat/mips-linux-watch.c: Fix common/ includes.
9792         * nat/linux-waitpid.c: Fix common/ includes.
9793         * nat/linux-ptrace.h: Fix common/ includes.
9794         * nat/linux-ptrace.c: Fix common/ includes.
9795         * nat/linux-procfs.c: Fix common/ includes.
9796         * nat/linux-personality.c: Fix common/ includes.
9797         * nat/linux-osdata.c: Fix common/ includes.
9798         * nat/linux-namespaces.c: Fix common/ includes.
9799         * nat/linux-btrace.h: Fix common/ includes.
9800         * nat/linux-btrace.c: Fix common/ includes.
9801         * nat/fork-inferior.c: Fix common/ includes.
9802         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9803         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9804         * nat/aarch64-linux.c: Fix common/ includes.
9805         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9806         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9807         * namespace.h: Fix common/ includes.
9808         * mips-linux-tdep.c: Fix common/ includes.
9809         * minsyms.c: Fix common/ includes.
9810         * mi/mi-parse.h: Fix common/ includes.
9811         * mi/mi-main.c: Fix common/ includes.
9812         * mi/mi-cmd-env.c: Fix common/ includes.
9813         * memrange.h: Fix common/ includes.
9814         * memattr.c: Fix common/ includes.
9815         * maint.h: Fix common/ includes.
9816         * maint.c: Fix common/ includes.
9817         * main.c: Fix common/ includes.
9818         * machoread.c: Fix common/ includes.
9819         * location.c: Fix common/ includes.
9820         * linux-thread-db.c: Fix common/ includes.
9821         * linux-nat.c: Fix common/ includes.
9822         * linux-fork.c: Fix common/ includes.
9823         * inline-frame.c: Fix common/ includes.
9824         * infrun.c: Fix common/ includes.
9825         * inflow.c: Fix common/ includes.
9826         * inferior.h: Fix common/ includes.
9827         * inferior.c: Fix common/ includes.
9828         * infcmd.c: Fix common/ includes.
9829         * inf-ptrace.c: Fix common/ includes.
9830         * inf-child.c: Fix common/ includes.
9831         * ia64-linux-nat.c: Fix common/ includes.
9832         * i387-tdep.c: Fix common/ includes.
9833         * i386-tdep.c: Fix common/ includes.
9834         * i386-linux-tdep.c: Fix common/ includes.
9835         * i386-linux-nat.c: Fix common/ includes.
9836         * i386-go32-tdep.c: Fix common/ includes.
9837         * i386-fbsd-tdep.c: Fix common/ includes.
9838         * i386-fbsd-nat.c: Fix common/ includes.
9839         * guile/scm-type.c: Fix common/ includes.
9840         * guile/guile.c: Fix common/ includes.
9841         * go32-nat.c: Fix common/ includes.
9842         * gnu-nat.c: Fix common/ includes.
9843         * gdbthread.h: Fix common/ includes.
9844         * gdbarch-selftests.c: Fix common/ includes.
9845         * gdb_usleep.c: Fix common/ includes.
9846         * gdb_select.h: Fix common/ includes.
9847         * gdb_bfd.c: Fix common/ includes.
9848         * gcore.c: Fix common/ includes.
9849         * fork-child.c: Fix common/ includes.
9850         * findvar.c: Fix common/ includes.
9851         * fbsd-nat.c: Fix common/ includes.
9852         * event-top.c: Fix common/ includes.
9853         * event-loop.c: Fix common/ includes.
9854         * dwarf2read.c: Fix common/ includes.
9855         * dwarf2loc.c: Fix common/ includes.
9856         * dwarf2-frame.c: Fix common/ includes.
9857         * dwarf-index-cache.c: Fix common/ includes.
9858         * dtrace-probe.c: Fix common/ includes.
9859         * disasm-selftests.c: Fix common/ includes.
9860         * defs.h: Fix common/ includes.
9861         * csky-tdep.c: Fix common/ includes.
9862         * cp-valprint.c: Fix common/ includes.
9863         * cp-support.h: Fix common/ includes.
9864         * cp-support.c: Fix common/ includes.
9865         * corelow.c: Fix common/ includes.
9866         * completer.h: Fix common/ includes.
9867         * completer.c: Fix common/ includes.
9868         * compile/compile.c: Fix common/ includes.
9869         * compile/compile-loc2c.c: Fix common/ includes.
9870         * compile/compile-cplus-types.c: Fix common/ includes.
9871         * compile/compile-cplus-symbols.c: Fix common/ includes.
9872         * command.h: Fix common/ includes.
9873         * cli/cli-dump.c: Fix common/ includes.
9874         * cli/cli-cmds.c: Fix common/ includes.
9875         * charset.c: Fix common/ includes.
9876         * build-id.c: Fix common/ includes.
9877         * btrace.h: Fix common/ includes.
9878         * btrace.c: Fix common/ includes.
9879         * breakpoint.h: Fix common/ includes.
9880         * breakpoint.c: Fix common/ includes.
9881         * ax.h:
9882         (enum agent_op): Fix common/ includes.
9883         * ax-general.c (struct aop_map): Fix common/ includes.
9884         * ax-gdb.c: Fix common/ includes.
9885         * auxv.c: Fix common/ includes.
9886         * auto-load.c: Fix common/ includes.
9887         * arm-tdep.c: Fix common/ includes.
9888         * arch/riscv.c: Fix common/ includes.
9889         * arch/ppc-linux-common.c: Fix common/ includes.
9890         * arch/i386.c: Fix common/ includes.
9891         * arch/arm.c: Fix common/ includes.
9892         * arch/arm-linux.c: Fix common/ includes.
9893         * arch/arm-get-next-pcs.c: Fix common/ includes.
9894         * arch/amd64.c: Fix common/ includes.
9895         * arch/aarch64.c: Fix common/ includes.
9896         * arch/aarch64-insn.c: Fix common/ includes.
9897         * arch-utils.c: Fix common/ includes.
9898         * amd64-windows-tdep.c: Fix common/ includes.
9899         * amd64-tdep.c: Fix common/ includes.
9900         * amd64-sol2-tdep.c: Fix common/ includes.
9901         * amd64-obsd-tdep.c: Fix common/ includes.
9902         * amd64-nbsd-tdep.c: Fix common/ includes.
9903         * amd64-linux-tdep.c: Fix common/ includes.
9904         * amd64-linux-nat.c: Fix common/ includes.
9905         * amd64-fbsd-tdep.c: Fix common/ includes.
9906         * amd64-fbsd-nat.c: Fix common/ includes.
9907         * amd64-dicos-tdep.c: Fix common/ includes.
9908         * amd64-darwin-tdep.c: Fix common/ includes.
9909         * agent.c: Fix common/ includes.
9910         * ada-lang.h: Fix common/ includes.
9911         * ada-lang.c: Fix common/ includes.
9912         * aarch64-tdep.c: Fix common/ includes.
9913
9914 2019-01-25  Tom Tromey  <tom@tromey.com>
9915
9916         * common/create-version.sh: Use common/version.h.
9917
9918 2019-01-24  Pedro Alves  <palves@redhat.com>
9919
9920         * infrun.c (signal_stop, signal_print, signal_program)
9921         (signal_catch, signal_pass): Now arrays instead of pointers.
9922         (update_signals_program_target, do_target_resume)
9923         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9924         * linux-nat.c (linux_nat_target::pass_signals)
9925         (linux_nat_target::create_inferior, linux_nat_target::attach):
9926         Adjust.
9927         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9928         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9929         * procfs.c (procfs_target::pass_signals): Adjust.
9930         * record-full.c (record_full_target::resume): Adjust.
9931         * remote.c (remote_target::pass_signals)
9932         (remote_target::program_signals): Adjust.
9933         * target-debug.h (target_debug_print_signals): Now takes a
9934         gdb::array_view as parameter.  Adjust.
9935         * target.h (target_ops) <pass_signals, program_signals>: Replace
9936         pointer and length parameters with gdb::array_view.
9937         (target_pass_signals, target_program_signals): Likewise.
9938         * target-delegates.c: Regenerate.
9939
9940 2019-01-24  Pedro Alves  <palves@redhat.com>
9941
9942         * common/forward-scope-exit.h
9943         (forward_scope_exit::forward_scope_exit): Pass arguments to
9944         m_bind_function directly, instead of creating a std::bind and
9945         copying that.
9946
9947 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9948
9949         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9950         for static members.
9951         (pass_in_v_vfp_candidate): Likewise.
9952
9953 2019-01-23  Tom Tromey  <tom@tromey.com>
9954             Pedro Alves  <palves@redhat.com>
9955
9956         * regcache.c (class regcache_invalidator): Remove.
9957         (regcache::raw_write): Use make_scope_exit.
9958
9959 2019-01-23  Tom Tromey  <tom@tromey.com>
9960
9961         * ui-out.h (class ui_out_emit_type): Update comment.
9962
9963 2019-01-23  Tom Tromey  <tom@tromey.com>
9964
9965         * infrun.c (fetch_inferior_event): Update comment.
9966
9967 2019-01-23  Tom Tromey  <tom@tromey.com>
9968             Pedro Alves  <palves@redhat.com>
9969
9970         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9971         parameter.
9972         (fetch_inferior_event): Use SCOPE_EXIT.
9973
9974
9975 2019-01-23  Tom Tromey  <tom@tromey.com>
9976             Pedro Alves  <palves@redhat.com>
9977
9978         * infrun.c (disable_thread_events): Delete.
9979         (stop_all_threads): Use SCOPE_EXIT.
9980
9981 2019-01-23  Tom Tromey  <tom@tromey.com>
9982             Pedro Alves  <palves@redhat.com>
9983
9984         * symfile.c: Include forward-scope-exit.h.
9985         (clear_symtab_users_cleanup): Replace forward declaration with
9986         a FORWARD_SCOPE_EXIT.
9987         (syms_from_objfile_1): Use the forward_scope_exit and
9988         gdb::optional instead of cleanup_function.
9989         (reread_symbols): Use the forward_scope_exit instead of
9990         cleanup_function.
9991         (clear_symtab_users_cleanup): Remove function.
9992
9993 2019-01-23  Tom Tromey  <tom@tromey.com>
9994             Pedro Alves  <palves@redhat.com>
9995
9996         * linux-nat.c: Include scope-exit.h.
9997         (cleanup_target_stop): Remove.
9998         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9999         SCOPE_EXIT.
10000
10001 2019-01-23  Tom Tromey  <tom@tromey.com>
10002             Pedro Alves  <palves@redhat.com>
10003
10004         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10005         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10006
10007 2019-01-23  Tom Tromey  <tom@tromey.com>
10008             Andrew Burgess  <andrew.burgess@embecosm.com>
10009             Pedro Alves  <palves@redhat.com>
10010
10011         * infrun.c (fetch_inferior_event): Use scope_exit.
10012         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10013         * top.c (execute_command): Use scope_exit.
10014         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10015         * utils.c (do_bpstat_clear_actions_cleanup)
10016         (make_bpstat_clear_actions_cleanup): Remove.
10017
10018 2019-01-23  Tom Tromey  <tom@tromey.com>
10019             Pedro Alves  <palves@redhat.com>
10020
10021         * infrun.c: Include "common/scope-exit.h"
10022         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10023         (wait_for_inferior): Use SCOPE_EXIT.
10024         (fetch_inferior_event): Use scope_exit.
10025
10026 2019-01-23  Tom Tromey  <tom@tromey.com>
10027             Pedro Alves  <palves@redhat.com>
10028
10029         * breakpoint.c (create_breakpoint): Remove cleanup.
10030
10031 2019-01-23  Tom Tromey  <tom@tromey.com>
10032             Andrew Burgess  <andrew.burgess@embecosm.com>
10033             Pedro Alves  <palves@redhat.com>
10034
10035 2019-01-23  Pedro Alves  <palves@redhat.com>
10036
10037         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10038
10039 2019-01-23  Pedro Alves  <palves@redhat.com>
10040             Andrew Burgess  <andrew.burgess@embecosm.com>
10041
10042         * gdbthread.h: Include "common/forward-scope-exit.h".
10043         (scoped_finish_thread_state): Redefine custom class in terms of
10044         forward_scope_exit.
10045
10046 2019-01-23  Pedro Alves  <palves@redhat.com>
10047             Andrew Burgess  <andrew.burgess@embecosm.com>
10048
10049         * common/forward-scope-exit.h: New file.
10050
10051 2019-01-23  Pedro Alves  <palves@redhat.com>
10052             Andrew Burgess  <andrew.burgess@embecosm.com>
10053             Tom Tromey  <tom@tromey.com>
10054
10055         * common/scope-exit.h: New file.
10056
10057 2019-01-23  Pedro Alves  <palves@redhat.com>
10058
10059         * common/preprocessor.h (ESC): Rename to ...
10060         (ESC_PARENS): ... this.
10061         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10062         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10063
10064 2019-01-23  Tom Tromey  <tom@tromey.com>
10065
10066         * language.h (class scoped_switch_to_sym_language_if_auto):
10067         Initialize m_lang in both cases.
10068
10069 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10070
10071         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10072         with XCNEW.
10073
10074 2019-01-22  Tom Tromey  <tom@tromey.com>
10075
10076         * corelow.c: Do not include sys/file.h.
10077
10078 2019-01-22  Tom Tromey  <tom@tromey.com>
10079
10080         * tui/tui-wingeneral.h: Include gdb_curses.h.
10081
10082 2019-01-22  Tom Tromey  <tom@tromey.com>
10083
10084         * source-cache.h (class source_cache) <get_source_lines,
10085         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10086
10087 2019-01-22  Tom Tromey  <tom@tromey.com>
10088
10089         * remote-fileio.h (struct remote_target): Declare.
10090
10091 2019-01-22  Tom Tromey  <tom@tromey.com>
10092
10093         * python/py-arch.c: Do not include py-ref.h.
10094         * python/py-bpevent.c: Do not include py-ref.h.
10095         * python/py-cmd.c: Do not include py-ref.h.
10096         * python/py-continueevent.c: Do not include py-ref.h.
10097         * python/py-event.h: Do not include py-ref.h.
10098         * python/py-evtregistry.c: Do not include py-ref.h.
10099         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10100         * python/py-frame.c: Do not include py-ref.h.
10101         * python/py-framefilter.c: Do not include py-ref.h.
10102         * python/py-function.c: Do not include py-ref.h.
10103         * python/py-infevents.c: Do not include py-ref.h.
10104         * python/py-linetable.c: Do not include py-ref.h.
10105         * python/py-objfile.c: Do not include py-ref.h.
10106         * python/py-param.c: Do not include py-ref.h.
10107         * python/py-prettyprint.c: Do not include py-ref.h.
10108         * python/py-progspace.c: Do not include py-ref.h.
10109         * python/py-symbol.c: Do not include py-ref.h.
10110         * python/py-symtab.c: Do not include py-ref.h.
10111         * python/py-type.c: Do not include py-ref.h.
10112         * python/py-unwind.c: Do not include py-ref.h.
10113         * python/py-utils.c: Do not include py-ref.h.
10114         * python/py-value.c: Do not include py-ref.h.
10115         * python/py-varobj.c: Do not include py-ref.h.
10116         * python/py-xmethods.c: Do not include py-ref.h.
10117         * python/python.c: Do not include py-ref.h.
10118         * varobj.c: Do not include py-ref.h.
10119
10120 2019-01-22  Tom Tromey  <tom@tromey.com>
10121
10122         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10123         keyword for bcache.
10124
10125 2019-01-22  Tom Tromey  <tom@tromey.com>
10126
10127         * compile/compile-cplus-types.c: Remove a comment by #include.
10128
10129 2019-01-22  Tom Tromey  <tom@tromey.com>
10130
10131         * compile/gcc-c-plugin.h: Include compile-internal.h.
10132
10133 2019-01-22  Tom Tromey  <tom@tromey.com>
10134
10135         * stabsread.c (EXTERN): Do not define.
10136         (symnum, next_symbol_text_func, processing_gcc_compilation)
10137         (within_function, global_sym_chain, global_stabs)
10138         (previous_stab_code, this_object_header_files)
10139         (n_this_object_header_files)
10140         (n_allocated_this_object_header_files): Define.
10141         * stabsread.h (EXTERN): Never define.  Use "extern".
10142
10143 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10144
10145         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10146         history_value.
10147
10148 2019-01-21  Tom Tromey  <tom@tromey.com>
10149
10150         * ui-out.c: Fix includes.
10151         * tui/tui-source.c: Fix includes.
10152         * target.c: Fix includes.
10153         * remote.c: Fix includes.
10154         * regcache.c: Fix includes.
10155         * python/py-block.c: Fix includes.
10156         * printcmd.c: Fix includes.
10157         * or1k-tdep.c: Fix includes.
10158         * mi/mi-main.c: Fix includes.
10159         * m32r-tdep.c: Fix includes.
10160         * csky-tdep.c: Fix includes.
10161         * compile/compile-cplus-types.c: Fix includes.
10162         * cli/cli-interp.c: Fix includes.
10163
10164 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10165
10166         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10167         for padding.
10168
10169 2019-01-16  Tom Tromey  <tom@tromey.com>
10170
10171         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10172         earlier.
10173         (struct objfile) <msymbols_range>: Move from top level.
10174         <msymbols>: New method.
10175         (class objfile_msymbols): Remove.
10176         * symtab.c (default_collect_symbol_completion_matches_break_on):
10177         Update.
10178         * symmisc.c (dump_msymbols): Update.
10179         * stabsread.c (scan_file_globals): Update.
10180         * objc-lang.c (info_selectors_command, info_classes_command)
10181         (find_methods): Update.
10182         * minsyms.c (find_solib_trampoline_target): Update.
10183         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10184         * coffread.c (coff_symfile_read): Update.
10185         * ada-lang.c (ada_lookup_simple_minsym)
10186         (ada_collect_symbol_completion_matches): Update.
10187
10188 2019-01-16  Tom Tromey  <tom@tromey.com>
10189
10190         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10191         type.  Remove no-argument constructor.
10192         <iterator::operator++>: Simplify.
10193         <begin>: Update.
10194         <end>: Use minimal_symbol_count.
10195
10196 2019-01-16  Tom Tromey  <tom@tromey.com>
10197
10198         * objfiles.h (struct objfile) <psymtabs>: New method.
10199         (class objfile_psymtabs): Remove.
10200         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10201         typedef.
10202         <range>: New method.
10203         (require_partial_symbols): Change return type.
10204         * psymtab.c (require_partial_symbols)
10205         (psym_expand_symtabs_matching): Update.
10206         * mdebugread.c (parse_partial_symbols): Update.
10207         * dbxread.c (dbx_end_psymtab): Update.
10208
10209 2019-01-15  Tom Tromey  <tom@tromey.com>
10210
10211         * symtab.c (lookup_objfile_from_block)
10212         (lookup_symbol_in_objfile_symtabs)
10213         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10214         (find_line_symtab, info_sources_command)
10215         (default_collect_symbol_completion_matches_break_on)
10216         (make_source_files_completion_list): Update.
10217         * symmisc.c (print_objfile_statistics, dump_objfile)
10218         (maintenance_print_symbols, maintenance_info_symtabs)
10219         (maintenance_check_symtabs, maintenance_info_line_tables):
10220         Update.
10221         * source.c (select_source_symtab)
10222         (forget_cached_source_info_for_objfile): Update.
10223         * objfiles.h (class objfile_compunits): Remove.
10224         (struct objfile) <compunits_range>: New typedef.
10225         (compunits): New method.
10226         * objfiles.c (objfile_relocate1): Update.
10227         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10228         * maint.c (count_symtabs_and_blocks): Update.
10229         * linespec.c (iterate_over_all_matching_symtabs): Update.
10230         * cp-support.c (add_symbol_overload_list_qualified): Update.
10231         * coffread.c (coff_symtab_read): Update.
10232         * ada-lang.c (add_nonlocal_symbols)
10233         (ada_collect_symbol_completion_matches)
10234         (ada_add_global_exceptions): Update.
10235
10236 2019-01-15  Tom Tromey  <tom@tromey.com>
10237
10238         * progspace.h (program_space) <objfiles_safe_range>: New
10239         typedef.
10240         <objfiles_safe>: New method.
10241         * objfiles.h (class all_objfiles_safe): Remove.
10242         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10243         * jit.c (jit_inferior_exit_hook): Update.
10244
10245 2019-01-17  Tom Tromey  <tom@tromey.com>
10246
10247         * progspace.h (program_space) <objfiles_range>: New typedef.
10248         <objfiles>: New method.
10249         <objfiles_head>: Rename from objfiles.
10250         (object_files): Update.
10251         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10252         * guile/scm-pretty-print.c
10253         (ppscm_find_pretty_printer_from_objfiles): Update.
10254         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10255         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10256         Update.
10257         * python/py-progspace.c (pspy_get_objfiles): Update.
10258         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10259         Update.
10260         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10261         (objfpy_lookup_objfile_by_build_id): Update.
10262         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10263         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10264         Update.
10265         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10266         (expand_symtab_containing_pc, lookup_objfile_from_block)
10267         (lookup_static_symbol, basic_lookup_transparent_type)
10268         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10269         (find_line_symtab, info_sources_command)
10270         (default_collect_symbol_completion_matches_break_on)
10271         (make_source_files_completion_list, find_main_name): Update.
10272         * symmisc.c (print_symbol_bcache_statistics)
10273         (print_objfile_statistics, maintenance_print_symbols)
10274         (maintenance_print_msymbols, maintenance_print_objfiles)
10275         (maintenance_info_symtabs, maintenance_check_symtabs)
10276         (maintenance_expand_symtabs, maintenance_info_line_tables):
10277         Update.
10278         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10279         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10280         (map_overlay_command, unmap_overlay_command)
10281         (simple_overlay_update, expand_symtabs_matching)
10282         (map_symbol_filenames): Update.
10283         * symfile-debug.c (set_debug_symfile): Update.
10284         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10285         Update.
10286         * source.c (select_source_symtab, forget_cached_source_info):
10287         Update.
10288         * solib.c (solib_read_symbols): Update.
10289         * solib-spu.c (append_ocl_sos): Update.
10290         * psymtab.c (maintenance_print_psymbols)
10291         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10292         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10293         * printcmd.c (info_symbol_command): Update.
10294         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10295         Update.
10296         * objfiles.h (class all_objfiles): Remove.
10297         * objfiles.c (have_partial_symbols, have_full_symbols)
10298         (have_minimal_symbols, qsort_cmp, update_section_map)
10299         (shared_objfile_contains_address_p)
10300         (default_iterate_over_objfiles_in_search_order): Update.
10301         * objc-lang.c (info_selectors_command, info_classes_command)
10302         (find_methods): Update.
10303         * minsyms.c (find_solib_trampoline_target): Update.
10304         * maint.c (maintenance_info_sections)
10305         (maintenance_translate_address, count_symtabs_and_blocks):
10306         Update.
10307         * main.c (captured_main_1): Update.
10308         * linux-thread-db.c (try_thread_db_load_from_pdir)
10309         (has_libpthread): Update.
10310         * linespec.c (iterate_over_all_matching_symtabs)
10311         (search_minsyms_for_name): Update.
10312         * jit.c (jit_find_objf_with_entry_addr): Update.
10313         * hppa-tdep.c (find_unwind_entry)
10314         (hppa_lookup_stub_minimal_symbol): Update.
10315         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10316         Update.
10317         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10318         (elf_gnu_ifunc_resolve_by_got): Update.
10319         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10320         * dwarf-index-write.c (save_gdb_index_command): Update.
10321         * cp-support.c (add_symbol_overload_list_qualified): Update.
10322         * breakpoint.c (create_overlay_event_breakpoint)
10323         (create_longjmp_master_breakpoint)
10324         (create_std_terminate_master_breakpoint)
10325         (create_exception_master_breakpoint): Update.
10326         * blockframe.c (find_pc_partial_function): Update.
10327         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10328         (ada_collect_symbol_completion_matches)
10329         (ada_add_global_exceptions): Update.
10330
10331 2019-01-17  Tom Tromey  <tom@tromey.com>
10332
10333         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10334         declare VEC.
10335         (solib_target_parse_libraries): Change return type.
10336         (library_list_start_segment, library_list_start_section)
10337         (library_list_end_library, library_list_start_library); Update.
10338         (solib_target_free_library_list): Remove.
10339         (solib_target_parse_libraries): Remove cleanup.  Change return
10340         type.
10341         (solib_target_current_sos): Update.
10342
10343 2019-01-17  Tom Tromey  <tromey@bapiya>
10344
10345         * valprint.c: Replace "the the" with "the".
10346         * symtab.c: Replace "the the" with "the".
10347         * solib.c: Replace "the the" with "the".
10348         * solib-dsbt.c: Replace "the the" with "the".
10349         * linespec.c: Replace "the the" with "the".
10350         * dwarf2loc.h: Replace "the the" with "the".
10351         * amd64-windows-tdep.c: Replace "the the" with "the".
10352         * aarch64-tdep.c: Replace "the the" with "the".
10353
10354 2019-01-16  Keith Seitz  <keiths@redhat.com>
10355
10356         PR gdb/23773
10357         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10358         <builder>: Rename to ..
10359         <m_builder>: ... this and make private.
10360         (dwarf2_cu::get_builder): New method.  Change all users of
10361         `builder' to use this method.
10362         (dwarf2_start_symtab): Move to ...
10363         (dwarf2_cu::start_symtab): ... here.  Update all callers
10364         (setup_type_unit_groups): Move to ...
10365         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10366         callers.
10367         (dwarf2_cu::reset_builder): New method.
10368         (process_full_compunit, process_full_type_unit): Use
10369         dwarf2_cu::reset_builder.
10370         (follow_die_offset): Record the ancestor CU if it is different
10371         from the followed DIE's CU.
10372         (follow_die_sig_1): Likewise.
10373
10374 2019-01-15  Tom Tromey  <tom@tromey.com>
10375
10376         * remote.c (class remote_state) <buf>: Now a char_vector.
10377         <buf_size>: Remove.
10378         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10379         parameter.
10380         (remote_target::getpkt_or_notif_sane_1)
10381         (remote_target::getpkt_sane)
10382         (remote_target::getpkt_or_notif_sane): Likewise.
10383         (class remote_target) <putpkt>: New overload.
10384         (remote_target::read_frame): Change type of "buf_p".  Remove
10385         sizeof_p parameter.
10386         (packet_ok): New overload.
10387         (packet_check_result): New overload.
10388         Update all uses.
10389
10390 2019-01-14  Tom Tromey  <tom@tromey.com>
10391
10392         * remote-notif.c (handle_notification, remote_notif_ack)
10393         (remote_notif_parse): Make "buf" const.
10394         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10395         const.
10396         (remote_notif_parse, remote_notif_ack, handle_notification):
10397         Likewise.
10398         * remote.c (remote_notif_stop_parse): Make "buf" const.
10399         (remote_target::remote_parse_stop_reply): Make "buf" const.
10400         (remote_notif_stop_ack): Make "buf" const.
10401
10402 2019-01-14  Tom Tromey  <tom@tromey.com>
10403
10404         * remote.c (remote_console_output): Make parameter const.
10405
10406 2019-01-14  Tom Tromey  <tom@tromey.com>
10407
10408         * target-debug.h (target_debug_print_signals): Constify.
10409         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10410         * procfs.c (procfs_target::pass_signals): Update.
10411         * linux-nat.c (linux_nat_target::pass_signals): Update.
10412         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10413         * target-delegates.c: Rebuild.
10414         * remote.c (remote_target::program_signals): Update.
10415         (remote_target::pass_signals): Update.
10416         * target.c (target_pass_signals): Constify argument.
10417         (target_program_signals): Likewise.
10418         * target.h (struct target_ops) <pass_signals, program_signals>:
10419         Constify argument.
10420         (target_pass_signals, target_program_signals): Constify argument.
10421
10422 2019-01-14  Tom Tromey  <tom@tromey.com>
10423
10424         PR tui/28819:
10425         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10426
10427 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10428
10429         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10430         field.
10431         * rs6000-tdep.c: Include reggroups.h.
10432         (IS_V_ALIAS_PSEUDOREG): Define.
10433         (rs6000_register_name): Return names for the "vX" aliases.
10434         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10435         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10436         aliases.  Call default_register_reggroup_p for all other
10437         pseudo-registers.
10438         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10439         New functions.
10440         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10441         Handle "vX" aliases.
10442         (v_alias_pseudo_register_collect): New function.
10443         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10444         (rs6000_gdbarch_init): Initialize "vX" aliases as
10445         pseudo-registers.  Restore registration of
10446         rs6000_pseudo_register_reggroup_p with
10447         set_tdesc_pseudo_register_reggroup_p.
10448
10449 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10450
10451         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10452         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10453         set_gdbarch_num_pseudo_regs.
10454
10455 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10456
10457         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10458         Remove arg prefixname, add do_set and do_show.
10459         Add member functions set_list and show_list.
10460         * cli/cli-style.c (class cli_style_option): Update accordingly.
10461         (style_set_list): Move to file scope.
10462         (style_show_list): Likewise.
10463         (set_style): Call help_list.
10464         (show_style): Call cmd_show_list.
10465         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10466         Update to use the new macro.
10467
10468 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10469
10470         * ada-lang.c (_initialize_ada_language): Expand the help text
10471         for the "catch exception" command.
10472
10473 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10474
10475         * symtab.c (matching_obj_sections): Initialize obj,
10476         declare it closer to its usage.
10477
10478 2019-01-10  Tom Tromey  <tom@tromey.com>
10479
10480         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10481         (basic_inf_threads_range): Remove.
10482         (inf_threads_range, inf_non_exited_threads_range)
10483         (safe_inf_threads_range): Use next_adapter.
10484
10485 2019-01-10  Keith Seitz  <keiths@redhat.com>
10486
10487         PR gdb/23712
10488         PR symtab/23010
10489         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10490         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10491
10492 2019-01-10  Keith Seitz  <keiths@redhat.com>
10493
10494         PR gdb/23712
10495         PR symtab/23010
10496         * dictionary.c (pending_to_vector): Remove.
10497         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10498         Remove _1 suffix, replacing functions of the same name.  Update
10499         all callers.
10500         (dict_create_hashed, dict_create_hashed_expandable)
10501         (dict_create_linear, dict_create_linear_expandable, dict_free)
10502         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10503         Make functions static.
10504
10505 2019-01-10  Keith Seitz  <keiths@redhat.com>
10506
10507         PR gdb/23712
10508         PR symtab/23010
10509         * dictionary.h (struct dictionary): Replace declaration with
10510         multidictionary.
10511         (dict_create_hashed, dict_create_hashed_expandable)
10512         (dict_create_linear, dict_create_linear_expandable)
10513         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10514         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10515         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10516         taking multidictionary argument.
10517         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10518         * block.h (struct block) <dict>: Change to multidictionary
10519         and rename `multidict'.
10520         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10521         symmisc.c: Update all dictionary references to multidictionary.
10522
10523 2019-01-10  Keith Seitz  <keiths@redhat.com>
10524
10525         PR gdb/23712
10526         PR symtab/23010
10527         * dictionary.c: Include unordered_map.
10528         (pending_to_vector): New function.
10529         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10530         Rewrite the non-"_1" functions to take vector instead
10531         of linked list.
10532         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10533         "new" _1 versions of the same name.
10534         (multidictionary): Define.
10535         (std::hash<enum language): New definition.
10536         (collate_pending_symbols_by_language, mdict_create_hashed)
10537         (mdict_create_hashed_expandable, mdict_create_linear)
10538         (mdict_create_linear_expandable, mdict_free)
10539         (find_language_dictionary, create_new_language_dictionary)
10540         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10541         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10542         (mdict_size, mdict_empty): New functions.
10543         * dictionary.h (mdict_iterator): Define.
10544
10545 2019-01-10  Pedro Alves  <palves@redhat.com>
10546
10547         * breakpoint.c (read_uploaded_action)
10548         (create_tracepoint_from_upload): Adjust to use
10549         gdb::unique_xmalloc_ptr.
10550         * ctf.c (ctf_write_uploaded_tp):
10551         (SET_ARRAY_FIELD): Use emplace_back.
10552         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10553         * tracefile-tfile.c (tfile_write_uploaded_tp):
10554         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10555         gdb::unique_xmalloc_ptr.
10556         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10557         at_string, cond_string, cmd_strings>: Replace char pointers
10558         with gdb::unique_xmalloc_ptr.
10559
10560 2019-01-10  Pedro Alves  <palves@redhat.com>
10561
10562         * solib-target.c (library_list_start_library): Don't xstrdup name.
10563
10564 2019-01-10  Pedro Alves  <palves@redhat.com>
10565
10566         * mdebugread.c (parse_partial_symbols): Use
10567         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10568
10569 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10570
10571         * linux-fork.c (scoped_switch_fork_info)
10572         <~scoped_switch_fork_info>: Fix incorrect variable name.
10573
10574 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10575
10576         * linux-fork.c (scoped_switch_fork_info)
10577         <scoped_switch_fork_info>: Make explicit.
10578         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10579
10580 2019-01-10  Tom Tromey  <tom@tromey.com>
10581
10582         * objfiles.h (objfile::reset_psymtabs): Update.
10583         * objfiles.c (objfile::objfile): Update.
10584         * psymtab.h (psymtab_storage::obstack): Update.
10585         (psymtab_storage::m_obstack): Use gdb::optional.
10586         (class psymtab_storage): Update comment.  Remove objfile
10587         parameter.
10588         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10589
10590 2019-01-10  Tom Tromey  <tom@tromey.com>
10591
10592         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10593         <free_psymtabs>: Now private.
10594         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10595         (allocate_psymtab): Use new method.
10596
10597 2019-01-10  Tom Tromey  <tom@tromey.com>
10598
10599         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10600         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10601         * mdebugread.c (parse_partial_symbols): Use
10602         allocate_dependencies.
10603         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10604         allocate_dependencies.
10605         (process_psymtab_comp_unit_reader)
10606         (build_type_psymtab_dependencies): Likewise.
10607         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10608
10609 2019-01-10  Tom Tromey  <tom@tromey.com>
10610
10611         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10612         PSYMBOL_SET_LANGUAGE.
10613         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10614
10615 2019-01-10  Tom Tromey  <tom@tromey.com>
10616
10617         * psymtab.h (psymtab_storage::obstack): New method.
10618         <m_obstack>: Rename from obstack; now private.
10619         * psymtab.c (psymtab_storage): Update.
10620         * dwarf2read.c (create_addrmap_from_index)
10621         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10622         Update.
10623
10624 2019-01-10  Tom Tromey  <tom@tromey.com>
10625
10626         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10627         * objfiles.h (objfile::reset_psymtabs): New method.
10628
10629 2019-01-10  Tom Tromey  <tom@tromey.com>
10630
10631         * symmisc.c (print_symbol_bcache_statistics): Update.
10632         (print_objfile_statistics): Update.
10633         * symfile.c (reread_symbols): Update.
10634         * psymtab.h (class psymtab_storage): New.
10635         * psymtab.c (psymtab_storage): New constructor.
10636         (~psymtab_storage): New destructor.
10637         (require_partial_symbols): Update.
10638         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10639         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10640         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10641         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10642         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10643         (start_psymtab_common, end_psymtab_common)
10644         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10645         (allocate_psymtab): Update.
10646         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10647         Update.
10648         (dump_psymtab_addrmap, maintenance_print_psymbols)
10649         (maintenance_check_psymtabs): Update.
10650         (class objfile_psymtabs): Move to objfiles.h.
10651         * psympriv.h (discard_psymtab): Now inline.
10652         (psymtab_discarder::psymtab_discarder): Update.
10653         (psymtab_discarder::~psymtab_discarder): Update.
10654         (ALL_OBJFILE_PSYMTABS): Rewrite.
10655         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10656         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10657         Remove fields.
10658         <partial_symtabs>: New field.
10659         (class objfile_psymtabs): Move from psymtab.h.  Update.
10660         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10661         psymbol_cache.
10662         (objfile::~objfile): Don't destroy psymbol_cache.
10663         * mdebugread.c (parse_partial_symbols): Update.
10664         * dwarf2read.c (create_addrmap_from_index)
10665         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10666         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10667         (add_partial_subprogram, dwarf2_ranges_read): Update.
10668         * dwarf-index-write.c (write_address_map)
10669         (write_one_signatured_type, recursively_write_psymbols)
10670         (class debug_names, class debug_names, write_psymtabs_to_index):
10671         Update.
10672
10673 2019-01-10  Tom Tromey  <tom@tromey.com>
10674
10675         * symtab.h (SYMBOL_SET_NAMES): Update.
10676         (symbol_set_names): Update.
10677         (MSYMBOL_SET_NAMES): Update.
10678         * symtab.c (symbol_set_names): Change argument to be an
10679         objfile_per_bfd_storage.
10680         * psymtab.c (add_psymbol_to_bcache): Update.
10681         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10682
10683 2019-01-10  Tom Tromey  <tom@tromey.com>
10684
10685         * symtab.c (create_demangled_names_hash): Change argument to be an
10686         objfile_per_bfd_storage.
10687         (symbol_set_names): Update.
10688
10689 2019-01-10  Tom Tromey  <tom@tromey.com>
10690
10691         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10692         init_psymbol_list.
10693         * psymtab.c (init_psymbol_list): Do nothing if already called.
10694         * psympriv.h (init_psymbol_list): Add comment.
10695         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10696         init_psymbol_list.
10697         * dbxread.c (dbx_symfile_read): Unconditionally call
10698         init_psymbol_list.
10699
10700 2019-01-10  Tom Tromey  <tom@tromey.com>
10701
10702         * xcoffread.c (scan_xcoff_symtab): Update.
10703         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10704         "where".
10705         * mdebugread.c (parse_partial_symbols)
10706         (handle_psymbol_enumerators): Update.
10707         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10708         * dbxread.c (read_dbx_symtab): Update.
10709         * psympriv.h (psymbol_placement): New enum.
10710         (add_psymbol_to_list): Update.
10711
10712 2019-01-10  Tom Tromey  <tom@tromey.com>
10713
10714         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10715         static_psymbols parameters.
10716         (scan_xcoff_symtab): Update.
10717         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10718         static_psymbols parameters.
10719         * psympriv.h (start_psymtab_common): Update.
10720         * mdebugread.c (parse_partial_symbols): Update.
10721         * dwarf2read.c (create_partial_symtab): Update.
10722         * dbxread.c (read_dbx_symtab): Update.
10723         (start_psymtab): Remove global_psymbols and static_psymbols
10724         parameters.
10725
10726 2019-01-10  Tom Tromey  <tom@tromey.com>
10727
10728         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10729         * psymtab.c (allocate_psymtab): Add comment.
10730         * psympriv.h (allocate_psymtab): Add comment.
10731         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10732         initializations.
10733         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10734
10735 2019-01-10  Tom Tromey  <tom@tromey.com>
10736
10737         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10738         Don't declare.
10739         * mipsread.c: Include mdebugread.h.
10740         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10741         Declare.
10742         * elfread.c: Include mdebugread.h.
10743
10744 2019-01-09  Tom Tromey  <tom@tromey.com>
10745
10746         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10747         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10748         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10749         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10750         (psym_lookup_symbol, psym_find_last_source_symtab)
10751         (psym_forget_cached_source_info, psym_print_stats)
10752         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10753         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10754         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10755         (psym_find_compunit_symtab_by_address)
10756         (maintenance_print_psymbols, maintenance_info_psymtabs)
10757         (maintenance_check_psymtabs): Use ranged for.
10758         * psymtab.h (class objfile_psymtabs): New.
10759         (require_partial_symbols): Return objfile_psymtabs.
10760         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10761
10762 2019-01-09  Tom Tromey  <tom@tromey.com>
10763
10764         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10765         (find_pc_mapped_section, list_overlays_command)
10766         (map_overlay_command, unmap_overlay_command)
10767         (simple_overlay_update): Use all_objfiles.
10768         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10769         * printcmd.c (info_symbol_command): Use all_objfiles.
10770         * objfiles.h (ALL_OBJSECTIONS): Remove.
10771         * maint.c (maintenance_translate_address): Use all_objfiles.
10772         * gcore.c (gcore_create_callback): Use all_objfiles.
10773         (objfile_find_memory_regions): Likewise.
10774
10775 2019-01-09  Tom Tromey  <tom@tromey.com>
10776
10777         * symtab.c (find_line_symtab, info_sources_command)
10778         (make_source_files_completion_list): Use objfile_compunits.
10779         * source.c (select_source_symtab): Use objfile_compunits.
10780         * objfiles.h (struct objfile): Update comment.
10781         (ALL_OBJFILES): Remove.
10782         (ALL_FILETABS): Remove.
10783         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10784         objfile_compunits.
10785
10786 2019-01-09  Tom Tromey  <tom@tromey.com>
10787
10788         * symmisc.c (print_objfile_statistics, dump_objfile)
10789         (maintenance_print_symbols): Use compunit_filetabs.
10790         * source.c (forget_cached_source_info_for_objfile): Use
10791         compunit_filetabs.
10792         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10793         (ALL_FILETABS): Use compunit_filetabs.
10794         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10795         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10796
10797 2019-01-09  Tom Tromey  <tom@tromey.com>
10798
10799         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10800         (compunit_filetabs): New.
10801         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10802         compunit_filetabs.
10803         (info_sources_command, make_source_files_completion_list): Remove
10804         declaration.
10805         * symmisc.c (print_objfile_statistics, dump_objfile)
10806         (maintenance_print_symbols): Remove declaration.
10807         (maintenance_info_symtabs): Use compunit_filetabs.
10808         (maintenance_info_line_tables): Likewise.
10809         * source.c (select_source_symtab): Change local variable name.
10810         (forget_cached_source_info_for_objfile): Remove declaration.
10811         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10812         * objfiles.c (objfile_relocate1): Remove declaration.
10813         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10814         declaration.
10815         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10816         * coffread.c (coff_symtab_read): Remove declaration.
10817         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10818         compunit_filetabs.
10819
10820 2019-01-09  Tom Tromey  <tom@tromey.com>
10821
10822         * symtab.c (lookup_objfile_from_block)
10823         (find_pc_sect_compunit_symtab, search_symbols)
10824         (default_collect_symbol_completion_matches_break_on): Use
10825         objfile_compunits.
10826         * objfiles.h (ALL_COMPUNITS): Remove.
10827         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10828         * cp-support.c (add_symbol_overload_list_qualified): Use
10829         objfile_compunits.
10830         * ada-lang.c (ada_collect_symbol_completion_matches)
10831         (ada_add_global_exceptions): Use objfile_compunits.
10832
10833 2019-01-09  Tom Tromey  <tom@tromey.com>
10834
10835         * source.c (select_source_symtab)
10836         (forget_cached_source_info_for_objfile): Remove declaration.
10837         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10838         declaration.
10839         * maint.c (count_symtabs_and_blocks): Remove declaration.
10840         * cp-support.c (add_symbol_overload_list_qualified): Remove
10841         declaration.
10842         * coffread.c (coff_symtab_read): Remove declaration.
10843         * symtab.c (lookup_symbol_in_objfile_symtabs)
10844         (basic_lookup_transparent_type_1): Use objfile_compunits.
10845         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10846         (info_sources_command, search_symbols)
10847         (default_collect_symbol_completion_matches_break_on)
10848         (make_source_files_completion_list): Remove declaration.
10849         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10850         (ada_collect_symbol_completion_matches)
10851         (ada_add_global_exceptions): Remove declaration.
10852         * linespec.c (iterate_over_all_matching_symtabs): Use
10853         objfile_compunits.
10854         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10855         (class objfile_compunits): New.
10856         (ALL_COMPUNITS): Use objfile_compunits.
10857         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10858         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10859         objfile_compunits.
10860         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10861
10862 2019-01-09  Tom Tromey  <tom@tromey.com>
10863
10864         * symtab.c (search_symbols)
10865         (default_collect_symbol_completion_matches_break_on): Use
10866         objfile_msymbols.
10867         * ada-lang.c (ada_lookup_simple_minsym)
10868         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10869         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10870         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10871         objfile_msymbols.
10872         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10873         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10874         * objc-lang.c (find_methods): Use objfile_msymbols.
10875         (info_selectors_command, info_classes_command): Likewise.
10876         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10877         * objfiles.h (class objfile_msymbols): New.
10878         (ALL_OBJFILE_MSYMBOLS): Remove.
10879         (ALL_MSYMBOLS): Remove.
10880
10881 2019-01-09  Tom Tromey  <tom@tromey.com>
10882
10883         * common/next-iterator.h (next_adapter): Add Iterator template
10884         parameter.
10885         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10886         (class all_objfiles_safe): New.
10887         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10888         * objfiles.c (put_objfile_before): Update comment.
10889         (add_separate_debug_objfile): Likewise.
10890         (free_all_objfiles): Use all_objfiles_safe.
10891         (objfile_purge_solibs): Likewise.
10892
10893 2019-01-09  Tom Tromey  <tom@tromey.com>
10894
10895         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10896         (expand_symtab_containing_pc, lookup_static_symbol)
10897         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10898         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10899         all_objfiles.
10900         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10901         * breakpoint.c (create_overlay_event_breakpoint)
10902         (create_longjmp_master_breakpoint)
10903         (create_std_terminate_master_breakpoint)
10904         (create_exception_master_breakpoint): Use all_objfiles.
10905         * linux-thread-db.c (try_thread_db_load_from_pdir)
10906         (has_libpthread): Use all_objfiles.
10907         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10908         * linespec.c (iterate_over_all_matching_symtabs)
10909         (search_minsyms_for_name): Use all_objfiles.
10910         * maint.c (maintenance_info_sections): Use all_objfiles.
10911         * main.c (captured_main_1): Use all_objfiles.
10912         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10913         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10914         * guile/scm-pretty-print.c
10915         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10916         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10917         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10918         (maintenance_print_msymbols): Use all_objfiles.
10919         * source.c (select_source_symtab): Use all_objfiles.
10920         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10921         * symfile.c (remove_symbol_file_command)
10922         (expand_symtabs_matching, map_symbol_filenames): Use
10923         all_objfiles.
10924         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10925         all_objfiles.
10926         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10927         * objc-lang.c (find_methods): Use all_objfiles.
10928         * objfiles.c (have_partial_symbols, have_full_symbols)
10929         (have_minimal_symbols, qsort_cmp)
10930         (default_iterate_over_objfiles_in_search_order): Use
10931         all_objfiles.
10932         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10933         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10934         (maintenance_check_psymtabs): Use all_objfiles.
10935         (ALL_PSYMTABS): Remove.
10936         * compile/compile-object-run.c (do_module_cleanup): Use
10937         all_objfiles.
10938         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10939         * cp-support.c (add_symbol_overload_list_qualified): Use
10940         all_objfiles.
10941         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10942         Use all_objfiles.
10943         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10944         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10945         all_objfiles.
10946         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10947         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10948         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10949         Uses all_objfiles.
10950         * solib.c (solib_read_symbols): Use all_objfiles
10951
10952 2019-01-09  Tom Tromey  <tom@tromey.com>
10953
10954         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10955         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10956         all_objfiles.
10957         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10958         * symmisc.c (print_symbol_bcache_statistics)
10959         (print_objfile_statistics, maintenance_print_objfiles)
10960         (maintenance_info_symtabs, maintenance_check_symtabs)
10961         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10962         all_objfiles.
10963         * source.c (forget_cached_source_info): Use all_objfiles.
10964         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10965         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10966         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10967         * objfiles.c (update_section_map): Use all_objfiles.
10968         (shared_objfile_contains_address_p): Likewise.
10969         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10970         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10971
10972 2019-01-09  Tom Tromey  <tom@tromey.com>
10973
10974         * common/next-iterator.h: New file.
10975         * objfiles.h (class all_objfiles): New.
10976         (struct objfile_iterator): New.
10977
10978 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10979
10980         * NEWS: Move the description of the changed "frame", "select-frame",
10981          and "info frame" commands to the Changed commands section.
10982
10983 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10984
10985         * gdbtypes.c (check_stub_method_group): Remove handling of old
10986         mangling schemes.
10987         * linespec.c (find_methods): Likewise.
10988         * stabsread.c (read_member_functions): Likewise.
10989         * valops.c (search_struct_method): Likewise.
10990         (value_struct_elt_for_reference): Likewise.
10991         * NEWS: Mention this change.
10992
10993 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10994
10995         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10996         print_source_lines.
10997         * source.c (print_source_lines_base): Update line number check.
10998         (print_source_lines): New function.
10999         (source_lines_range::source_lines_range): New function.
11000         * source.h (class source_lines_range): New class.
11001         (print_source_lines): New declaration.
11002
11003 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11004
11005         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11006
11007 2019-01-08  Tom Tromey  <tom@tromey.com>
11008             Simon Marchi  <simon.marchi@ericsson.com>
11009
11010         PR gdb/24060
11011         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11012         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11013         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11014         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11015         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11016         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11017
11018 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11019
11020         * source.c (select_source_symtab): Move header comment to
11021         declaration in source.h.
11022         (forget_cached_source_info_for_objfile): Likewise.
11023         (forget_cached_source_info): Likewise.
11024         (identify_source_line): Likewise.
11025         * source.h (identify_source_line): Move declaration from symtab.h
11026         and add comment from source.c
11027         (print_source_lines): Likewise.
11028         (forget_cached_source_info_for_objfile): Likewise.
11029         (forget_cached_source_info): Likewise.
11030         (select_source_symtab): Likewise.
11031         (enum print_source_lines_flag): Move definition from symtab.h.
11032         * symtab.h (identify_source_line): Move declaration to source.h.
11033         (print_source_lines): Likewise.
11034         (forget_cached_source_info_for_objfile): Likewise.
11035         (forget_cached_source_info): Likewise.
11036         (select_source_symtab): Likewise.
11037         (enum print_source_lines_flag): Move definition to source.h.
11038         * tui/tui-hooks.c: Add 'source.h' include.
11039
11040 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11041
11042         * source.c (print_source_lines_base): Handle requests to print
11043         reverse line number sequences, and guard against empty lines
11044         string.
11045
11046 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11047
11048         * source.c (print_source_lines_base): Fix skip of '\r' if next
11049         character is '\n'.
11050
11051 2019-01-06  Tom Tromey  <tom@tromey.com>
11052
11053         * c-exp.y (struct c_parse_state) <macro_original_text,
11054         expansion_obstack>: New member.
11055         (macro_original_text, expansion_obstack): Remove globals.
11056         (scan_macro_expansion, scanning_macro_expansion)
11057         (finished_macro_expansion): Update.
11058         (scan_macro_cleanup): Remove.
11059         (yylex, c_parse): Update.
11060
11061 2019-01-06  Tom Tromey  <tom@tromey.com>
11062
11063         * c-exp.y (struct c_parse_state) <strings>: New member.
11064         (operator_stoken): Update.
11065
11066 2019-01-06  Tom Tromey  <tom@tromey.com>
11067
11068         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11069         (union type_stack_elt) <typelist_val>: Now a pointer to
11070         std::vector.
11071         (type_stack_cleanup): Don't declare.
11072         (push_typelist): Update.
11073         * parse.c (pop_typelist): Return a std::vector.
11074         (push_typelist): Take a std::vector.
11075         (follow_types): Update.  Do not free args.
11076         (type_stack_cleanup): Remove.
11077         * c-exp.y (struct c_parse_state): New.
11078         (cpstate): New global.
11079         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11080         (nonempty_typelist): Update.
11081         (func_mod): Create a new vector.
11082         (c_parse): Create a c_parse_state.
11083         (check_parameter_typelist): Do not delete params.
11084         (function_method): Update.  Do not delete type_list.
11085
11086 2019-01-06  Tom Tromey  <tom@tromey.com>
11087
11088         PR gdb/28155:
11089         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11090         check_typedef.
11091         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11092         (print_return_value): Likewise.
11093
11094 2019-01-05  Tom Tromey  <tom@tromey.com>
11095
11096         * contrib/cleanup_check.py: Remove.
11097         * contrib/gcc-with-excheck: Remove.
11098         * contrib/exsummary.py: Remove.
11099         * contrib/excheck.py: Remove.
11100
11101 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11102
11103         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11104         NULL. Initialize tpprev to NULL instead of assigning it
11105         to NULL on the next statement.
11106         * windows-nat.c (windows_delete_thread): Remove check for
11107         main_thread_id before printing thread exit notifications.
11108         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11109         Remove thread ID check against main_thread_id.
11110         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11111         windows_delete_thread.
11112         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11113
11114 2019-01-04  Tom Tromey  <tom@tromey.com>
11115
11116         * compile/compile.c (_initialize_compile): Use upper case for
11117         metasyntactic variables.
11118         * symmisc.c (_initialize_symmisc): Use upper case for
11119         metasyntactic variables.
11120         * psymtab.c (_initialize_psymtab): Use upper case for
11121         metasyntactic variables.
11122         * demangle.c (demangle_command): Use upper case for metasyntactic
11123         variables.
11124         (_initialize_demangler): Likewise.
11125         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11126         variables.
11127
11128 2019-01-03  Tom Tromey  <tom@tromey.com>
11129
11130         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11131
11132 2019-01-03  Tom Tromey  <tom@tromey.com>
11133
11134         * python/py-symtab.c (salpy_str): Update.
11135         (struct salpy_sal_object) <symtab>: Now a PyObject.
11136         (salpy_dealloc): Update.
11137         (del_objfile_sal): Use gdbpy_ref.
11138
11139 2019-01-03  Tom Tromey  <tom@tromey.com>
11140
11141         * python/py-type.c (convert_field): Use new_reference.  Return
11142         gdbpy_ref.
11143         (make_fielditem): Return gdbpy_ref.
11144         (typy_fields): Update.
11145         (typy_getitem): Update.
11146         (field_name): Return gdbpy_ref.  Use new_reference.
11147         (typy_iterator_iternext): Update.
11148
11149 2019-01-03  Tom Tromey  <tom@tromey.com>
11150
11151         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11152
11153 2019-01-03  Tom Tromey  <tom@tromey.com>
11154
11155         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11156         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11157         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11158         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11159         (pspy_set_type_printers): Likewise.
11160         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11161         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11162         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11163         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11164         (objfpy_set_type_printers): Likewise.
11165
11166 2019-01-03  Tom Tromey  <tom@tromey.com>
11167
11168         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11169         (gdbpy_print_stack): Use gdbpy_err_fetch.
11170         * python/python-internal.h (class gdbpy_err_fetch): New class.
11171         (class gdbpy_enter) <m_error_type, m_error_value,
11172         m_error_traceback>: Remove.
11173         <m_error>: New member.
11174         (gdbpy_exception_to_string): Don't declare.
11175         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11176         * python/py-value.c (convert_value_from_python): Use
11177         gdbpy_err_fetch.
11178         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11179         gdbpy_exception_to_string.
11180         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11181         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11182         gdbpy_err_fetch.
11183
11184 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11185
11186         * linux-nat.c (delete_lwp_cleanup): Delete.
11187         (struct lwp_deleter): New struct.
11188         (lwp_info_up): New typedef.
11189         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11190         lwp_info_up.
11191
11192 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11193
11194         * linux-fork.c (class scoped_switch_fork_info): New class.
11195         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11196
11197 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11198
11199         * valops.c (find_overload_match): Remove use of null_cleanup, and
11200         calls to do_cleanups.
11201
11202 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11203
11204         * compile/compile-cplus-types.c
11205         (compile_cplus_instance::decl_name): Handle changes to
11206         cp_func_name.
11207         * cp-support.c (cp_func_name): Update header comment, update
11208         return type.
11209         * cp-support.h (cp_func_name): Update return type in declaration.
11210         * valops.c (find_overload_match): Move temp_func local to top
11211         level of function and change its type.  Use temp_func to hold and
11212         delete temporary string obtained from cp_func_name.
11213
11214 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11215
11216         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11217         gdb::char_vector, remove cleanup, and update uses of `msg`.
11218
11219 2019-01-03  Jim Wilson  <jimw@sifive.com>
11220
11221         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11222
11223 2019-01-02  Tom Tromey  <tom@tromey.com>
11224
11225         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11226         (tdesc_parse_xml): Remove cleanups.
11227         * target-descriptions.h (make_cleanup_free_target_description):
11228         Don't declare.
11229         (target_desc_deleter): New struct.
11230         (target_desc_up): New typedef.
11231         * target-descriptions.c (target_desc_deleter::operator()): Rename
11232         from free_target_description.
11233         (make_cleanup_free_target_description): Remove.
11234
11235 2019-01-02  Tom Tromey  <tom@tromey.com>
11236
11237         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11238         constructor, destructor.
11239         (linespec_parser): Remove typedef.
11240         (~linespec_parser): Rename from linespec_parser_delete.
11241         (linespec_lex_to_end, linespec_complete_label)
11242         (linespec_complete): Update.
11243         (decode_line_full): Remove cleanups.
11244         (decode_line_1): Update.
11245
11246 2019-01-02  Tom Tromey  <tom@tromey.com>
11247
11248         * python/python-internal.h (inferior_to_inferior_object): Change
11249         return type.
11250         * python/py-exitedevent.c (create_exited_event_object): Update.
11251         * python/py-inferior.c (inferior_to_inferior_object): Return
11252         gdbpy_ref.
11253         (python_new_inferior, python_inferior_deleted)
11254         (thread_to_thread_object, delete_thread_object)
11255         (build_inferior_list, gdbpy_selected_inferior): Update.
11256         * python/py-infthread.c (create_thread_object): Update.  Also fail
11257         if inferior_to_inferior_object fails.
11258
11259 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11260
11261         * inferior.h (class inferior) <displaced_step_state>: New field.
11262         * infrun.h (struct displaced_step_state): Move here from
11263         infrun.c.  Initialize fields, add constructor.
11264         <inf>: Remove field.
11265         <reset>: New method.
11266         * infrun.c (struct displaced_step_inferior_state): Move to
11267         infrun.h.
11268         (displaced_step_inferior_states): Remove.
11269         (get_displaced_stepping_state): Adust.
11270         (displaced_step_in_progress_any_inferior): Adjust.
11271         (displaced_step_in_progress_thread): Adjust.
11272         (displaced_step_in_progress): Adjust.
11273         (add_displaced_stepping_state): Remove.
11274         (get_displaced_step_closure_by_addr): Adjust.
11275         (remove_displaced_stepping_state): Remove.
11276         (infrun_inferior_exit): Call displaced_step_state.reset.
11277         (use_displaced_stepping): Don't check for NULL.
11278         (displaced_step_prepare_throw): Call
11279         get_displaced_stepping_state.
11280         (displaced_step_fixup): Don't check for NULL.
11281         (prepare_for_detach): Don't check for NULL.
11282
11283 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11284
11285         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11286          in case of call that did not complete.
11287
11288 2019-01-02  Andrey Utkin  <autkin@undo.io>
11289
11290         * symfile.c (find_separate_debug_file): Fix search of debug files for
11291         remote debuggee.
11292
11293 2019-01-02  Tom Tromey  <tom@tromey.com>
11294
11295         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11296         indentation.
11297         * python/py-frame.c (frapy_older): Remove cast.
11298         (frapy_newer): Likewise.
11299         * python/py-breakpoint.c (local_setattro): Remove cast.
11300         * python/py-arch.c (archpy_name): Remove local variable.
11301         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11302
11303 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11304
11305         * unittests/basic_string_view/element_access/char/empty.cc:
11306         Fix year range in copyright header.
11307
11308 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11309
11310         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11311         Delete.
11312         <operator==>: Update with for removed field.
11313         <hash>: Likewise.
11314         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11315         <isa_features>: ...this.
11316         <abi_features>: New field.
11317         (riscv_isa_flen): Update comment.
11318         (riscv_abi_xlen): New declaration.
11319         (riscv_abi_flen): New declaration.
11320         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11321         isa_features.
11322         (riscv_abi_xlen): New function.
11323         (riscv_isa_flen): Update to get answer from isa_features.
11324         (riscv_abi_flen): New function.
11325         (riscv_has_fp_abi): Update to get answer from abi_features.
11326         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11327         xlen and flen.
11328         (riscv_call_info) <xlen, flen>: Update comment.
11329         (riscv_call_arg_struct): Remove invalid assertions
11330         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11331         is removed.
11332         (riscv_gdbarch_init): Gather isa features and abi features
11333         separately, ensure both match on the gdbarch when reusing an old
11334         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11335         a target with 64-bit float hardware.
11336
11337 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11338
11339         * source.c (search_command_helper): Stop reverse search
11340         when line 1 has been searched.
11341
11342 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11343
11344         * record-full.c (record_full_base_target::close): Rewrite
11345         record_full_core_buf_list free logic.
11346
11347 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11348
11349         * break-catch-syscall.c (print_one_catch_syscall): xfree
11350         the last text.
11351
11352 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11353
11354         * top.c (print_gdb_version): Update Copyright year in version
11355         message.
11356
11357 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11358
11359         Update copyright year range in all GDB files.
11360
11361 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11362
11363         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11364
11365 For older changes see ChangeLog-2018.
11366 \f
11367 Local Variables:
11368 mode: change-log
11369 left-margin: 8
11370 fill-column: 74
11371 version-control: never
11372 coding: utf-8
11373 End:
11374