gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
   4         refresh_window>: Declare.
   5         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
   6         resize.
   7         (tui_data_item_window::rerender): Rename from
   8         tui_display_register.
   9         (tui_data_item_window::refresh_window): New method.
  10         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  11         no-op.
  12
  13 2019-08-30  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  16         regs_column_count, current_group>: Move later.  Now private.
  17         <get_current_group>: New method.
  18         * tui/tui-regs.c (tui_reg_command): Update.
  19         * tui/tui-layout.c (tui_set_layout): Update.
  20
  21 2019-08-30  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  24         (tui_data_window::rerender): Don't call
  25         check_and_display_highlight_if_needed.
  26         (tui_data_window::refresh_all): Remove call to
  27         erase_data_content.
  28
  29 2019-08-30  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  32         (tui_data_window::display_registers_from)
  33         (tui_data_window::display_reg_element_at_line)
  34         (tui_data_window::display_registers_from_line): Remove checks of
  35         "empty".
  36
  37 2019-08-30  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  40         Don't declare.
  41         * tui/tui-regs.c (tui_data_window::show_registers): Call
  42         rerender.
  43         (tui_data_window::rerender): Rename from display_all_data.
  44         (tui_data_window::rerender): Remove old implementation.
  45
  46 2019-08-30  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  49         text.
  50         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  51
  52 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  53             Sergio Durigan Junior  <sergiodj@redhat.com>
  54
  55         PR win32/24284
  56         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  57
  58 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  59
  60         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  61         when searching for types.
  62
  63 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  64
  65         * f-lang.c (f_language_defn): Use f_print_typedef.
  66         * f-lang.h (f_print_typedef): Declare.
  67         * f-typeprint.c (f_print_typedef): Define.
  68
  69 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  70
  71         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  72
  73 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  74
  75         * cli/cli-utils.c (info_print_options_defs): Delete.
  76         (make_info_print_options_def_group): Delete.
  77         (extract_info_print_options): Delete.
  78         (info_print_command_completer): Delete.
  79         (info_print_args_help): Add extra parameter, and optionally
  80         include text about -n flag.
  81         * cli/cli-utils.h (struct info_print_options): Delete.
  82         (extract_info_print_options): Delete declaration.
  83         (info_print_command_completer): Delete declaration.
  84         (info_print_args_help): Add extra parameter, extend header
  85         comment.
  86         * python/python.c (gdbpy_rbreak): Pass additional parameter to
  87         search_symbols.
  88         * stack.c (struct info_print_options): New type.
  89         (info_print_options_defs): New file scoped variable.
  90         (make_info_print_options_def_group): New static function.
  91         (info_print_command_completer): New static function.
  92         (info_locals_command): Update to use new local functions.
  93         (info_args_command): Likewise.
  94         (_initialize_stack): Add extra parameter to calls to
  95         info_print_args_help.
  96         * symtab.c (search_symbols): Add extra parameter, use this to
  97         possibly excluse non-debug symbols.
  98         (symtab_symbol_info): Add extra parameter, which is passed on to
  99         search_symbols.
 100         (struct info_print_options): New type.
 101         (info_print_options_defs): New file scoped variable.
 102         (make_info_print_options_def_group): New static function.
 103         (info_print_command_completer): New static function.
 104         (info_variables_command): Update to use local functions, and pass
 105         extra parameter through to symtab_symbol_info.
 106         (info_functions_command): Likewise.
 107         (info_types_command): Pass additional argument through to
 108         symtab_symbol_info.
 109         (rbreak_command): Pass extra argument to search_symbols.
 110         (_initialize_symtab): Add extra arguments for calls to
 111         info_print_args_help, and update help text for 'info variables',
 112         'whereis', and 'info functions' commands.
 113         * symtab.h (search_symbols): Add extra argument to declaration.
 114         * NEWS: Mention new flags.
 115
 116 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 117
 118         * symtab.c (lookup_static_symbol): Call the new function (and move
 119         it down to be next to lookup_global_symbol).
 120         (struct global_sym_lookup_data): Add block_enum member and rename to...
 121         (struct global_or_static_sym_lookup_data): ...this.
 122         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 123         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 124         (lookup_symbol_global_or_static_iterator_cb): ...this.
 125         (lookup_global_or_static_symbol): New function.
 126         (lookup_global_symbol): Call new function.
 127
 128 2019-08-26  Tom de Vries  <tdevries@suse.de>
 129
 130         PR c++/24852
 131         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 132         when pc_probe.prob == NULL.
 133
 134 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 135
 136         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 137         variable symbol_linkage to symbol_linkage_.
 138
 139 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 140
 141         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 142         represent whether the symbol is static, dynamic, or we don't
 143         know.
 144
 145 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 146
 147         * gdb/rx-tdep.c (rx_register_names): New.
 148         (rx_register_name): Delete.
 149         (rx_psw_type): Delete.
 150         (rx_fpsw_type): Delete.
 151         (rx_register_type): Delete.
 152         (rx_gdbarch_init): Convert target-descriptions.
 153         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 154         * gdb/features/Makefile: Add rx.xml.
 155         * gdb/features/rx.xml: New.
 156         * gdb/features/rx.c: Generated.
 157         * gdb/NEWS: Mention target description support.
 158
 159 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 160
 161         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 162         *slot_ptr.
 163
 164 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 165
 166         * configure.ac: Don't check for 'dlfcn.h' (moved to
 167         gdbsupport/common.m4).
 168         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 169         'gdbsupport/'.
 170         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 171         * compile/compile-c-support.c: Include
 172         'gdbsupport/gdb-dlfcn.h'.
 173         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 174         * gdb-dlfcn.c: Move to...
 175         * gdbsupport/gdb-dlfcn.c: ... here.
 176         * gdb-dlfcn.h: Move to...
 177         * gdbsupport/gdb-dlfcn.h: ... here.
 178
 179 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 180
 181         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 182         the offset field signed.
 183
 184 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 185
 186         * python/lib/gdb/__init__.py (_execute_file): New function.
 187         * python/python.c (python_run_simple_file): Call gdb._execute_file
 188         on Windows.
 189
 190 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 193         all uses as this was never set to anything but a zero value.
 194
 195 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 196
 197         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 198
 199 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 200
 201         * tui/tui-data.h (tui_gen_win_info): Add an =default
 202         move constructor, required by some GCC versions.
 203
 204 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 205
 206         * go32-nat.c (go32_sysinfo): Add hygon_p.
 207
 208 2019-08-20  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 211         line_from_reg_element_no, first_reg_element_no_inline,
 212         display_all_data, delete_data_content_windows,
 213         erase_data_content>: Now private.
 214
 215 2019-08-20  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 218         (tui_unhighlight_win, tui_highlight_win)
 219         (tui_win_info::make_window): Update.
 220         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 221
 222 2019-08-20  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 225         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 226         (MAX_PID_WIDTH): Move to tui-stack.c.
 227         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 228         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 229         (MAX_PID_WIDTH): Move from tui-data.h.
 230
 231 2019-08-20  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 234         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 235         (box_win): Update.
 236         (tui_gen_win_info::make_window): Rename from tui_make_window.
 237         (tui_win_info::make_window): New method.
 238         (tui_gen_win_info::make_visible): Update.
 239         * tui/tui-source.c (tui_source_window::set_contents): Update.
 240         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 241         (tui_data_window::display_registers_from): Update.
 242         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 243         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 244         Declare.
 245         <can_box>: Remove.
 246         <title>: Remove.
 247         (struct tui_win_info) <make_window>: Declare.
 248         <can_box>: Now virtual.
 249         <title>: New member.
 250         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 251         * tui/tui-command.c (tui_cmd_window::resize): Update.
 252
 253 2019-08-20  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 256         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 257         (tui_data_window::check_register_values): Update.
 258
 259 2019-08-20  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-regs.h (struct tui_data_window): Use
 262         DISABLE_COPY_AND_ASSIGN.
 263         <regs_content>: Change type, removing unique_ptr.
 264         <tui_data_window>: Add move constructor.
 265         * tui/tui-regs.c (tui_data_window::show_registers)
 266         (tui_data_window::show_register_group)
 267         (tui_data_window::display_registers_from)
 268         (tui_data_window::display_registers_from)
 269         (tui_data_window::first_data_item_displayed)
 270         (tui_data_window::delete_data_content_windows)
 271         (tui_data_window::rerender, tui_data_window::refresh_window)
 272         (tui_data_window::check_register_values): Update.
 273
 274 2019-08-20  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 277         show_register_group>: Declare.
 278         (tui_show_register_group): Don't declare.
 279         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 280         tui_show_registers.
 281         (tui_data_window::show_register_group): Rename from
 282         tui_show_register_group.
 283         (tui_data_window::check_register_values, tui_reg_command):
 284         Update.
 285         * tui/tui-layout.c (tui_set_layout): Update.
 286
 287 2019-08-20  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 290         Declare.
 291         (tui_check_register_values): Don't declare.
 292         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 293         from tui_check_register_values.
 294         * tui/tui-hooks.c (tui_register_changed): Update.
 295
 296 2019-08-20  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-regs.c (tui_reg_layout): Move later.
 299         (tui_show_registers): Don't enable TUI mode or change layout.
 300
 301 2019-08-20  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-regs.h (struct tui_data_item_window)
 304         <~tui_data_item_window>: Remove.
 305         <content>: Now a unique_xmalloc_ptr.
 306         * tui/tui-regs.c (tui_register_format): Return a
 307         unique_xmalloc_ptr.
 308         (tui_get_register): Update.
 309         (~tui_data_item_window): Remove.
 310         (tui_data_window::display_registers_from, tui_display_register):
 311         Update.
 312         * tui/tui-io.h (tui_expand_tabs): Update.
 313         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 314         Remove "col" parameter.
 315
 316 2019-08-20  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 319         field.
 320         * tui/tui-regs.c (~tui_data_item_window): Update.
 321
 322 2019-08-20  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 325         earlier.
 326
 327 2019-08-20  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 330
 331 2019-08-20  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-source.h (struct tui_source_window): Update.
 334         * tui/tui-regs.c (tui_show_registers): Update.
 335         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 336         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 337         (NO_REGS_STRING): Remove defines.
 338
 339 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 340
 341         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 342         unnecessary thread walk if remote doesn't support the packet.
 343
 344 2019-08-19  Tom Tromey  <tromey@adacore.com>
 345
 346         * python/py-value.c (value_has_field): Fix indentation.
 347
 348 2019-08-19  Tom Tromey  <tromey@adacore.com>
 349
 350         * printcmd.c (do_one_display, info_display_command): Update.
 351         * block.h (contained_in): Return bool.  Add allow_nested
 352         parameter.
 353         * block.c (contained_in): Return bool.  Add allow_nested
 354         parameter.
 355
 356 2019-08-19  Tom Tromey  <tom@tromey.com>
 357
 358         * configure: Rebuild.
 359         * configure.ac: Disallow the combination of -static-libstdc++ and
 360         source highlight.
 361         * source-cache.c (get_language_name): Handle rust.
 362         (source_cache::get_source_lines): Ignore highlighting exceptions.
 363
 364 2019-08-16  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 367         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 368         (struct tui_source_window_base) <make_visible, refresh_window,
 369         resize>: Remove methods.
 370         <execution_info>: Remove field.
 371         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 372         (tui_show_source_line, tui_source_window_base)
 373         (~tui_source_window_base): Update.
 374         (tui_source_window_base::resize)
 375         (tui_source_window_base::make_visible)
 376         (tui_source_window_base::refresh_window): Remove.
 377         (tui_source_window_base::update_exec_info): Update.
 378         * tui/tui-source.c (tui_source_window::set_contents): Update.
 379         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 380
 381 2019-08-16  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 384         deprecated_query_hook.
 385
 386 2019-08-16  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 389         (tui_update_source_windows_with_line): Update.
 390         * tui/tui-source.h (struct tui_source_window)
 391         <show_symtab_source>: Declare.
 392         (tui_show_symtab_source): Don't declare.
 393         * tui/tui-source.c (tui_show_symtab_source): Rename from
 394         tui_show_symtab_source.
 395
 396 2019-08-16  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.h (struct tui_source_window_base)
 399         <set_contents>: Declare.
 400         * tui/tui-winsource.c
 401         (tui_source_window_base::update_source_window_as_is): Update.
 402         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 403         Declare.
 404         (tui_set_source_content): Don't declare.
 405         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 406         tui_set_source_content.
 407         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 408         Declare.
 409         (tui_set_disassem_content): Don't declare.
 410         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 411         tui_set_disassem_content.
 412
 413 2019-08-16  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-winsource.h (struct tui_source_window_base)
 416         <update_breakpoint_info>: Declare.
 417         (tui_update_breakpoint_info): Don't declare.
 418         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 419         (tui_update_all_breakpoint_info): Update.
 420         (tui_source_window_base::update_breakpoint_info): Rename from
 421         tui_update_breakpoint_info.
 422         (tui_source_window_base::update_exec_info): Update.
 423
 424 2019-08-16  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-winsource.h (struct tui_source_window_base)
 427         <update_source_window>: Declare.
 428         (tui_update_source_window): Don't declare.
 429         * tui/tui-winsource.c
 430         (tui_source_window_base::update_source_window): Rename from
 431         tui_update_source_window.
 432         (tui_source_window_base::rerender): Update.
 433         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 434         * tui/tui-disasm.c (tui_show_disassem)
 435         (tui_show_disassem_and_update_source)
 436         (tui_disasm_window::maybe_update): Update.
 437
 438 2019-08-16  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-winsource.h (struct tui_source_window_base)
 441         <update_source_window_as_is>: Declare.
 442         (tui_update_source_window_as_is): Don't declare.
 443         * tui/tui-winsource.c (tui_update_source_window): Update
 444         (tui_source_window_base::update_source_window_as_is): Rename from
 445         tui_update_source_window_as_is.
 446         (tui_source_window_base::refill): Update.
 447         * tui/tui-source.c (tui_show_symtab_source): Update.
 448         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 449         Update.
 450
 451 2019-08-16  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-winsource.h (tui_update_source_window)
 454         (tui_update_source_window_as_is): Remove "noerror" parameter.
 455         * tui/tui-winsource.c (tui_update_source_window)
 456         (tui_update_source_window_as_is): Remove "noerror" parameter.
 457         (tui_update_source_windows_with_addr)
 458         (tui_update_source_windows_with_line)
 459         (tui_source_window_base::rerender)
 460         (tui_source_window_base::refill): Update.
 461         * tui/tui-source.h (tui_set_source_content)
 462         (tui_show_symtab_source): Remove "noerror" parameter.
 463         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 464         parameter.
 465         (tui_show_symtab_source): Likewise.
 466         (tui_source_window::maybe_update): Update.
 467         * tui/tui-disasm.c (tui_show_disassem)
 468         (tui_show_disassem_and_update_source)
 469         (tui_disasm_window::do_scroll_vertical)
 470         (tui_disasm_window::maybe_update): Update.
 471
 472 2019-08-16  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui.c (tui_is_window_visible): Update.
 475         * tui/tui-wingeneral.c (tui_make_window)
 476         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 477         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 478         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 479         (tui_set_win_height_command, parse_scrolling_args): Update.
 480         * tui/tui-source.c (tui_source_window::style_changed): Update.
 481         * tui/tui-regs.c (tui_show_registers)
 482         (tui_data_window::first_data_item_displayed)
 483         (tui_data_window::delete_data_content_windows)
 484         (tui_check_register_values, tui_reg_command): Update.
 485         * tui/tui-disasm.c (tui_show_disassem): Update.
 486         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 487         method.
 488         <is_visible>: Remove field.
 489         * tui/tui-data.c (tui_next_win, tui_prev_win)
 490         (tui_delete_invisible_windows): Update.
 491
 492 2019-08-16  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-winsource.h (struct tui_source_window_base)
 495         <m_has_locator>: Remove.
 496         * tui/tui-layout.c (show_source_disasm_command, show_data)
 497         (show_source_or_disasm_and_command): Update.
 498
 499 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 500
 501         * NEWS (Other MI changes): New subsection.
 502         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 503         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 504         * arch-utils.c (default_get_pc_address_flags): New function.
 505         * arch-utils.h (default_get_pc_address_flags): New declaration.
 506         * gdbarch.sh: Add get_pc_address_flags.
 507         * gdbarch.c: Regenerate.
 508         * gdbarch.h: Likewise.
 509         * stack.c (print_pc): New function.
 510         (print_frame_info) (print_frame): Call print_pc.
 511
 512 2019-08-16  Tom de Vries  <tdevries@suse.de>
 513
 514         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 515         print_objfile_section_info.
 516
 517 2019-08-15  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 520         calling update_cmdwin_start_line.
 521         * tui/tui-winsource.h (struct tui_source_window_base)
 522         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 523         <rerender>: Declare.
 524         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 525         Call rerender.
 526         (tui_source_window_base::set_new_height): Remove.
 527         (tui_source_window_base::rerender): Rename from
 528         do_make_visible_with_new_height.
 529         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 530         resize method.
 531         (tui_win_info::make_invisible_and_set_new_height)
 532         (tui_win_info::make_visible_with_new_height): Remove.
 533         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 534         Declare.
 535         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 536         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 537         do_make_visible_with_new_height>: Don't declare.
 538         <rerender>: Declare.
 539         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 540         set_new_height.
 541         (tui_data_window::do_make_visible_with_new_height): Remove.
 542         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 543         call tui_show_locator_content.
 544         (tui_gen_win_info::resize): Call rerender.
 545         (show_source_or_disasm_and_command): Don't call
 546         tui_show_locator_content.
 547         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 548         method.
 549         (struct tui_win_info) <rerender>: Declare.
 550         <set_new_height, make_invisible_and_set_new_height,
 551         make_visible_with_new_height>: Don't declare.
 552         * tui/tui-data.c (tui_win_list::rerender): New method.
 553         * tui/tui-command.h (struct tui_cmd_window)
 554         <do_make_visible_with_new_height>: Don't declare.
 555         * tui/tui-command.c
 556         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 557
 558 2019-08-15  Tom Tromey  <tromey@adacore.com>
 559
 560         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 561         * ada-lang.c (ada_enum_name): Likewise.
 562
 563 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 564
 565         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 566         leading underscore.
 567         (GdbOutputErrorFile): Likewise.
 568         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 569         accordingly.
 570         (execute_unwinders): Rename to have a leading underscore.
 571         (auto_load_packages): Likewise.
 572         (global scope): Adjust call to auto_load_packages accordingly.
 573         (GdbSetPythonDirectory): Likewise.
 574         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 575         instead of execute_unwinders.
 576
 577 2019-08-15  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 580         (show_data): Don't change window visibility.
 581         (tui_gen_win_info::resize): Remove special case for command
 582         window.  Use wresize, when available.
 583         (show_source_or_disasm_and_command): Don't change window
 584         visibility.
 585         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 586         <make_visible>: New method.
 587         * tui/tui-command.c (tui_cmd_window::resize): New method.
 588
 589 2019-08-15  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 592         (struct tui_source_windows): New.
 593         * tui/tui-winsource.c (tui_display_main): Update.
 594         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 595         (new_height_ok, parse_scrolling_args): Update.
 596         * tui/tui-layout.c (show_layout, show_data): Update.
 597         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 598         (tui_add_to_source_windows): Don't declare.
 599         * tui/tui-data.c (source_windows, tui_source_windows)
 600         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 601
 602 2019-08-15  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 605         Rename from reset.
 606         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 607         * tui/tui-layout.c (show_source_disasm_command, show_data):
 608         Update.
 609         (tui_gen_win_info::resize): Rename.
 610         (show_source_or_disasm_and_command): Update.
 611         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 612         reset.
 613
 614 2019-08-15  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 617         * tui/tui-interp.c (tui_interp::init): Don't call
 618         tui_initialize_static_data.
 619         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 620
 621 2019-08-15  Tom Tromey  <tom@tromey.com>
 622
 623         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 624         examine tui_win_list.
 625
 626 2019-08-15  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 629         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 630         tui_clear_source_content.
 631         (tui_clear_source_content): Remove.
 632         (tui_source_window_base::do_erase_source_content): Hoist call to
 633         content.clear().
 634         * tui/tui-stack.c (tui_show_frame_info): Don't call
 635         tui_clear_source_content.
 636
 637 2019-08-15  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-winsource.h (struct tui_source_window_base)
 640         <do_erase_source_content>: New method.
 641         <erase_source_content>: New method.
 642         (tui_erase_source_content): Don't declare.
 643         * tui/tui-winsource.c (tui_clear_source_content): Update.
 644         (tui_source_window_base::do_erase_source_content): Rename from
 645         tui_erase_source_content.
 646         (tui_source_window_base::show_source_content): Update.
 647         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 648         * tui/tui-source.h (struct tui_source_window)
 649         <erase_source_content>: New method.
 650         * tui/tui-disasm.h (struct tui_disasm_window)
 651         <erase_source_content>: New method.
 652
 653 2019-08-15  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 656         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 657         constructor.
 658         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 659         * tui/tui-source.c (tui_set_source_content): Update.
 660         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 661
 662 2019-08-15  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 665         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 666         tui-source.c.
 667         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 668         Declare.
 669         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 670         method.
 671         (tui_source_window::maybe_update): Update.
 672
 673 2019-08-15  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 676         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 677         tui-disasm.c.
 678         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 679         Declare.
 680         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 681         method.
 682         (tui_disasm_window::maybe_update): Update.
 683
 684 2019-08-15  Tom Tromey  <tom@tromey.com>
 685
 686         * tui/tui-winsource.h (struct tui_source_window_base)
 687         <maybe_update>: Declare.
 688         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 689         method.
 690         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 691         Declare.
 692         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 693         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 694         Declare.
 695         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 696
 697 2019-08-15  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 700
 701 2019-08-15  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-wingeneral.c: Include tui-stack.h.
 704         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 705         (struct tui_locator_window): Move from tui-data.h.
 706         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 707         (tui_initialize_static_data): Move from tui-data.c.
 708         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 709         (struct tui_locator_window): Move to tui-stack.c.
 710         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 711         (tui_initialize_static_data): Move to tui-stack.c.
 712
 713 2019-08-15  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-layout.c (show_source_disasm_command)
 716         (show_source_or_disasm_and_command): Use make_visible method, not
 717         tui_make_window.
 718         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 719         Remove.
 720
 721 2019-08-15  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-wingeneral.h (tui_make_window): Update.
 724         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 725         parameter.
 726         (tui_gen_win_info::make_visible): Update.
 727         * tui/tui-regs.c (tui_data_window::display_registers_from):
 728         Update.
 729         * tui/tui-layout.c (show_source_disasm_command)
 730         (show_source_or_disasm_and_command): Update.
 731         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 732         (enum tui_box): Remove.
 733         (struct tui_win_info) <can_box>: New method.
 734         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 735         method.
 736
 737 2019-08-15  Tom de Vries  <tdevries@suse.de>
 738
 739         * linux-nat-trad.c: Include gdbarch.h.
 740
 741 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 742
 743         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 744         register sizes.
 745
 746 2019-08-14  Tom Tromey  <tromey@adacore.com>
 747
 748         * darwin-nat.c: Include gdbarch.h.
 749         * darwin-nat-info.c: Include gdbarch.h.
 750
 751 2019-08-13  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 754         Remove.
 755         * tui/tui-data.c (tui_initialize_static_data): Update.
 756
 757 2019-08-13  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-winsource.h (struct tui_exec_info_window)
 760         <~tui_exec_info_window, maybe_allocate_content, get_content,
 761         m_content>: Remove.
 762         (struct tui_source_window_base) <set_exec_info_content,
 763         show_exec_info_content>: Don't declare.
 764         * tui/tui-winsource.c
 765         (tui_exec_info_window::maybe_allocate_content): Remove.
 766         (tui_source_window_base::update_exec_info): Rename from
 767         set_exec_info_content.
 768         (tui_source_window_base::show_exec_info_content)
 769         (tui_source_window_base::update_exec_info): Remove.
 770
 771 2019-08-13  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 774         declare.
 775         * tui/tui-winsource.c (tui_update_source_window_as_is)
 776         (tui_update_source_windows_with_addr, tui_erase_source_content):
 777         Update.
 778         (tui_clear_exec_info_content): Remove.
 779
 780 2019-08-13  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 783         declare.
 784         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 785         call tui_erase_exec_info_content.
 786         (tui_clear_exec_info_content): Rename from
 787         tui_erase_exec_info_content.
 788         (tui_clear_exec_info_content): Delete.
 789
 790 2019-08-13  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-winsource.h (struct tui_source_window_base)
 793         <show_exec_info_content>: Declare.
 794         (tui_show_exec_info_content): Don't declare.
 795         * tui/tui-winsource.c
 796         (tui_source_window_base::show_exec_info_content): Rename from
 797         tui_show_exec_info_content.
 798         (tui_source_window_base::update_exec_info): Update.
 799
 800 2019-08-13  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 803         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 804         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 805         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 806         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 807         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 808         ... here.
 809
 810 2019-08-13  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-winsource.h (struct tui_source_window_base)
 813         <update_exec_info>: Declare.
 814         (tui_update_exec_info): Don't declare.
 815         * tui/tui-winsource.c (tui_update_source_window_as_is)
 816         (tui_source_window_base::refresh_all)
 817         (tui_update_all_breakpoint_info): Update.
 818         (tui_source_window_base::update_exec_info): Rename from
 819         tui_update_exec_info.
 820         * tui/tui-stack.c (tui_show_frame_info): Update.
 821
 822 2019-08-13  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-winsource.h (struct tui_source_window_base)
 825         <set_exec_info_content>: Declare.
 826         (tui_set_exec_info_content): Don't declare.
 827         * tui/tui-winsource.c
 828         (tui_source_window_base::set_exec_info_content): Rename from
 829         tui_set_exec_info_content.
 830         (tui_update_exec_info): Update.
 831
 832 2019-08-13  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-winsource.h (struct tui_source_window_base)
 835         <show_source_content>: Declare.
 836         (tui_show_source_content): Don't declare.
 837         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 838         (tui_source_window_base::show_source_content): Rename from
 839         tui_show_source_content.
 840         (tui_source_window_base::refresh_all): Update.
 841         * tui/tui-layout.c (show_source_disasm_command)
 842         (show_source_or_disasm_and_command): Update.
 843
 844 2019-08-13  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-winsource.c (tui_erase_source_content)
 847         (tui_show_source_content, tui_source_window_base::refresh_all):
 848         Update.
 849         * tui/tui-wingeneral.h
 850         (tui_check_and_display_highlight_if_needed): Don't declare.
 851         * tui/tui-wingeneral.c
 852         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 853         check_and_display_highlight_if_needed.
 854         * tui/tui-win.c (tui_rehighlight_all)
 855         (tui_win_info::make_visible_with_new_height): Update.
 856         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 857         (tui_data_window::erase_data_content)
 858         (tui_data_window::display_all_data): Update.
 859         * tui/tui-data.h (struct tui_win_info)
 860         <check_and_display_highlight_if_needed>: Declare.
 861
 862 2019-08-13  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-win.c (tui_resize_all): Call
 865         tui_delete_invisible_windows.
 866         * tui/tui-layout.c (show_layout): Call
 867         tui_delete_invisible_windows.
 868         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 869         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 870
 871 2019-08-13  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 874         tui_add_win_to_layout.
 875
 876 2019-08-13  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 879         * tui/tui-layout.c (tui_default_win_height): Now static.
 880
 881 2019-08-13  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 884         single switch.
 885         (show_source_disasm_command, show_source_or_disasm_and_command):
 886         Don't check current layout.
 887
 888 2019-08-13  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-wingeneral.c (make_all_visible): Remove.
 891         (tui_make_all_invisible): Simplify.
 892         * tui/tui-layout.c (tui_make_all_invisible): Move from
 893         tui-wingeneral.c; simplify.
 894         (show_layout): Hoist call to tui_make_all_invisible.
 895         (show_data): Don't call tui_make_all_invisible.
 896
 897 2019-08-13  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 900         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 901
 902 2019-08-13  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 905         tui-data.c.
 906         (show_source_disasm_command, show_data)
 907         (show_source_or_disasm_and_command): Don't use
 908         tui_set_current_layout_to.
 909         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 910         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 911         tui-layout.c.
 912         (tui_set_current_layout_to): Remove.
 913
 914 2019-08-13  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-layout.c (tui_set_layout): Update.
 917         * tui/tui-data.h (struct tui_layout_def): Remove.
 918         (tui_layout_def): Don't declare.
 919         * tui/tui-data.c (layout_def): Remove.
 920         (tui_layout_def): Remove.
 921
 922 2019-08-13  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-winsource.h (struct tui_source_window_base)
 925         <clear_detail>: No longer "override".
 926         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 927         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 928         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 929         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 930         Remove.
 931         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 932
 933 2019-08-13  Tom Tromey  <tromey@adacore.com>
 934
 935         * tracepoint.c: Don't include readline.h or history.h.
 936
 937 2019-08-12  Tom Tromey  <tom@tromey.com>
 938
 939         * configure: Rebuild.
 940         * configure.ac: Check for readline 7.
 941         * NEWS: Mention readline 7 requirement.
 942         * README: Update.
 943
 944 2019-08-12  Tom Tromey  <tom@tromey.com>
 945
 946         * mingw-hdep.c (gdb_select): Remove readline hack.
 947
 948 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 949
 950         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 951         when the function fails.
 952
 953 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 954
 955         * s390-tdep.c (s390_type_align): New function.
 956         (s390_gdbarch_init): Set it as type_align gdbarch method.
 957
 958 2019-08-09  Tom de Vries  <tdevries@suse.de>
 959
 960         PR gdb/24591
 961         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 962         pc_low with relocation offset.
 963
 964 2019-08-07  Tom Tromey  <tromey@adacore.com>
 965
 966         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 967         (print_frame_args): Update.
 968         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 969         Update.
 970         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 971         * frame.h (struct frame_arg): Add initializers.
 972         <error>: Now a unique_xmalloc_ptr.
 973
 974 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 975
 976         * NEWS: Expand the Pointer Authentication entry.
 977         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 978         (aarch64_frame_unmask_lr): ... to this.
 979         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 980         Call aarch64_frame_unmask_lr.
 981         * frame.c (struct frame_info): Add "masked" variable.
 982         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 983         (fprint_frame): Check for masked pc.
 984         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 985         declarations.
 986         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 987         * stack.c (print_frame): Check for masked pc.
 988
 989 2019-08-06  Tom Tromey  <tom@tromey.com>
 990
 991         * stabsread.c (patch_block_stabs, read_one_struct_field)
 992         (read_enum_type): Use obstack_strndup.
 993         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 994         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 995         * dwarf2read.c (guess_full_die_structure_name)
 996         (anonymous_struct_prefix): Use obstack_strndup.
 997         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 998         * c-exp.y (yylex): Use obstack_strndup.
 999         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1000         (write_var_or_type): Use obstack_strndup.
1001
1002 2019-08-06  Tom Tromey  <tom@tromey.com>
1003
1004         * symfile.c (reread_symbols): Use obstack_strdup.
1005         * stabsread.c (read_type): Use obstack_strdup.
1006         * gdb_obstack.h (obstack_strdup): New overload.
1007         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1008         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1009         (dwarf2_canonicalize_name): Use obstack_strdup.
1010         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1011         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1012         Use obstack_strdup.
1013
1014 2019-08-06  Tom Tromey  <tom@tromey.com>
1015
1016         * gdb_obstack.h (obstack_strdup): Define.
1017         * gdb_obstack.c (obstack_strdup): Don't define.
1018
1019 2019-08-06  Tom Tromey  <tom@tromey.com>
1020
1021         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1022         obstack_strdup.
1023         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1024         obstack_strdup.
1025         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1026         * stabsread.c (common_block_start): Use obstack_strdup.
1027         * objfiles.c (set_objfile_main_name, objfile): Use
1028         obstack_strdup.
1029         * namespace.c (add_using_directive): Use obstack_strdup.
1030         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1031         * jit.c (finalize_symtab): Use obstack_strdup.
1032         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1033         (guess_partial_die_structure_name, partial_die_info::fixup)
1034         (dwarf2_name): Use obstack_strdup.
1035         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1036         obstack_strdup.
1037         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1038         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1039         obstack_strdup.
1040         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1041
1042 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1043
1044         * unittests/help-doc-selftests.c: New file.
1045         * Makefile.in: Add the new file.
1046
1047 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1048
1049         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1050         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1051         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1052         the trailing '.' is not output, and the first character is uppercased.
1053         (print_help_for_command): Update call to print_doc_line.
1054         (print_doc_of_command): Likewise.
1055         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1056         * cli/cli-option.c (append_indented_doc): Do not append newline.
1057         (build_help_option): Append newline after first appended_indented_doc
1058         only if a second call is done.
1059         (build_help): Append 2 new lines before each option, except the first
1060         one.
1061         * compile/compile.c (_initialize_compile): Add new lines after
1062         %OPTIONS%, when not at the end of the help.
1063         Change help doc or code
1064         producing the help doc to respect the invariants.
1065         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1066         Also removed the new line after 'Options:', as all other commands
1067         do not put an empty line between 'Options:' and the first option.
1068         * printcmd.c (_initialize_printcmd): Likewise.
1069         * stack.c (_initialize_stack): Likewise.
1070         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1071         incorrectly telling COMMAND is optional.
1072         * ada-lang.c (_initialize_ada_language): Change help doc or code
1073         producing the help doc to respect the invariants.
1074         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1075         * breakpoint.c (_initialize_breakpoint): Likewise.
1076         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1077         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1078         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1079         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1080         _initialize_cli_style): Likewise.
1081         * corelow.c (core_target_info): Likewise.
1082         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1083         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1084         * filesystem.c (_initialize_filesystem): Likewise.
1085         * frame.c (_initialize_frame): Likewise.
1086         * gnu-nat.c (add_task_commands): Likewise.
1087         * infcall.c (_initialize_infcall): Likewise.
1088         * infcmd.c (_initialize_infcmd): Likewise.
1089         * interps.c (_initialize_interpreter): Likewise.
1090         * language.c (_initialize_language): Likewise.
1091         * linux-fork.c (_initialize_linux_fork): Likewise.
1092         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1093         * maint.c (_initialize_maint_cmds): Likewise.
1094         * memattr.c (_initialize_mem): Likewise.
1095         * printcmd.c (_initialize_printcmd): Likewise.
1096         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1097         _RegEx): Likewise.
1098         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1099         * record-btrace.c (_initialize_record_btrace): Likewise.
1100         * record-full.c (_initialize_record_full): Likewise.
1101         * record.c (_initialize_record): Likewise.
1102         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1103         * regcache.c (_initialize_regcache): Likewise.
1104         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1105         _initialize_remote): Likewise.
1106         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1107         * serial.c (_initialize_serial): Likewise.
1108         * skip.c (_initialize_step_skip): Likewise.
1109         * source.c (_initialize_source): Likewise.
1110         * stack.c (_initialize_stack): Likewise.
1111         * symfile.c (_initialize_symfile): Likewise.
1112         * symtab.c (_initialize_symtab): Likewise.
1113         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1114         * top.c (init_main): Likewise.
1115         * tracefile-tfile.c (tfile_target_info): Likewise.
1116         * tracepoint.c (_initialize_tracepoint): Likewise.
1117         * tui/tui-win.c (_initialize_tui_win): Likewise.
1118         * utils.c (add_internal_problem_command): Likewise.
1119         * valprint.c (value_print_option_defs): Likewise.
1120
1121 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1122
1123         PR build/24886
1124         * configure.ac: Drop enable-libmcheck support.
1125         * configure, config.in: Rebuild.
1126         * libmcheck.m4: Remove.
1127         * acinclude.m4: Don't include it.
1128         * Makefile.in: Don't distribute it.
1129         * top.c (print_gdb_configuration): Don't mention it.
1130
1131 2019-08-06  Tom Tromey  <tom@tromey.com>
1132
1133         * utils.c (set_output_style): Sometimes pass stream to
1134         emit_style_escape.
1135         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1136         * record-btrace.c (btrace_insn_history): Update.
1137         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1138         method.
1139         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1140         Update initializers.
1141         <m_uiout>: New field.
1142         <m_di>: Move lower.
1143         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1144         Remove "uiout" parameter.
1145         (dump_insns): Update.
1146         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1147         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1148
1149 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1150
1151         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1152         (error_in_psymtab_expansion): Likewise.
1153         (lookup_symbol_via_quick_fns): Likewise.
1154         (basic_lookup_transparent_type_quick): Likewise.
1155         (basic_lookup_transparent_type_1): Likewise.
1156
1157 2019-08-06  Tom Tromey  <tromey@adacore.com>
1158
1159         * source.c (last_source_error): Now bool.
1160         (print_source_lines_base): Make "noprint" bool.  Only open
1161         source file when last_source_visited changes.
1162
1163 2019-08-06  Tom Tromey  <tromey@adacore.com>
1164
1165         * annotate.c (annotate_source_line): Use g_source_cache.
1166         * source-cache.c (source_cache::get_plain_source_lines): Change
1167         parameters.  Populate m_offset_cache.
1168         (source_cache::ensure): New method.
1169         (source_cache::get_line_charpos): New method.
1170         (extract_lines): Move lower.  Change parameters.
1171         (source_cache::get_source_lines): Move lower.
1172         * source-cache.h (class source_cache): Update comment.
1173         <get_line_charpos>: New method.
1174         <get_source_lines>: Update comment.
1175         <clear>: Clear m_offset_cache.
1176         <get_plain_source_lines>: Change parameters.
1177         <ensure>: New method
1178         <m_offset_cache>: New member.
1179         * source.c (forget_cached_source_info_for_objfile): Update.
1180         (info_source_command): Use g_source_cache.
1181         (find_source_lines, open_source_file_with_line_charpos): Remove.
1182         (print_source_lines_base, search_command_helper): Use g_source_cache.
1183         * source.h (open_source_file_with_line_charpos): Don't declare.
1184         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1185         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1186         Use g_source_cache.
1187
1188 2019-08-06  Tom Tromey  <tromey@adacore.com>
1189
1190         * source-cache.c (source_cache::get_plain_source_lines):
1191         Remove "first_line" and "last_line" parameters.
1192         (source_cache::get_source_lines): Cache plain text.
1193         * source-cache.h (class source_cache)
1194         <get_plain_source_lines>: Update.
1195
1196 2019-08-06  Tom Tromey  <tromey@adacore.com>
1197
1198         * source-cache.c (extract_lines): No longer a method.
1199         Changed type of parameter.  Include final newline.
1200         (selftests::extract_lines_test): New function.
1201         (_initialize_source_cache): Likewise.
1202         * source-cache.h (class source_cache)
1203         <extract_lines>: Don't declare.
1204
1205 2019-08-06  Tom Tromey  <tromey@adacore.com>
1206
1207         * breakpoint.c (init_breakpoint_sal): Update.
1208         (breakpoint): Update.
1209         * breakpoint.h (struct breakpoint) <filter>: Now a
1210         unique_xmalloc_ptr.
1211
1212 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1213
1214         * NEWS: Mention dictionary access on blocks.
1215         * python/py-block.c (blpy_getitem): New function.
1216         (block_object_as_mapping): New struct.
1217         (block_object_type): Use new struct for tp_as_mapping field.
1218
1219 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1220
1221         * objfiles.h (objfile): Add a comment describing partial symbols.
1222
1223 2019-08-05  Tom Tromey  <tromey@adacore.com>
1224
1225         * compile/compile.c (_initialize_compile): Use _(), not N_().
1226         * thread.c (_initialize_thread): Use _(), not N_().
1227         * stack.c (_initialize_stack): Use _(), not N_().
1228         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1229
1230 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1231
1232         * dwarf2read.c (struct dw2_symtab_iterator):
1233         <want_specific_block>: Remove.
1234         <block_index>: Change type to gdb::optional.
1235         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1236         change type of BLOCK_INDEX parameter to gdb::optional.
1237         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1238         (dw2_lookup_symbol): Don't pass argument for
1239         WANT_SPECIFIC_BLOCK.
1240         (dw2_expand_symtabs_for_function): Don't pass argument for
1241         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1242         (class dw2_debug_names_iterator)
1243         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1244         parameter, change BLOCK_INDEX type to gdb::optional.
1245         <m_want_specific_block>: Remove.
1246         <m_block_index>: Change type to gdb::optional.
1247         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1248         gdb::optional.  Re-write in function of gdb::optional.
1249         (dw2_debug_names_lookup_symbol): Don't pass argument for
1250         WANT_SPECIFIC_BLOCK.
1251         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1252         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1253         BLOCK_INDEX.
1254
1255 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1256
1257         * NEWS: Mention changes to "info sources" command.
1258
1259 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1260
1261         * symtab.c (filename_partial_match_opts): New struct type.
1262         (struct output_source_filename_data): New members
1263         regexp, c_regexp, partial_match.
1264         (output_source_filename): Use new members to decide to print file.
1265         (info_sources_option_defs): New variable.
1266         (make_info_sources_options_def_group, print_info_sources_header,
1267         info_sources_command_completer):
1268         New functions.
1269         (info_sources_command): Read new optional arguments.
1270         (_initialize_symtab): Update info sources help.
1271
1272 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1273
1274         * ada-lang.c (exception_support_info_v0): Renamed from...
1275         (default_exception_support_info): ... this.  Create new
1276         definition for v1.
1277         (ada_has_this_exception_support): Look up catch_handlers_sym.
1278         (ada_exception_support_info_sniffer): Try v0 after default.
1279
1280 2019-08-01  Tom Tromey  <tromey@adacore.com>
1281
1282         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1283         gdbarch.h.
1284
1285 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1286
1287         * s12z-tdep.c: Fix include path for s12z-opc.h.
1288
1289 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1290
1291         * NEWS: Require GNU make 3.82.
1292
1293 2019-07-16  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1296         declare.
1297
1298 2019-07-30  Tom Tromey  <tromey@adacore.com>
1299
1300         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1301
1302 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1303
1304         * printcmd.c (print_address_symbolic): Print negative offsets.
1305         (build_address_symbolic): Force signed arithmetic when computing
1306         offset.
1307
1308 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1309
1310         PR/24474: Add a function to lookup static variables.
1311         * NEWS: Mention this new function.
1312         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1313         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1314         * python/python.c (python_GdbMethods): Add new function.
1315
1316 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1317
1318         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1319         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1320         (objfpy_lookup_static_symbol): New function.
1321         (objfile_object_methods): Add new functions.
1322
1323 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1324
1325         * NEWS: Mention 'set|show print frame-info'.  Mention new
1326         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1327         backtrace argument.  Mention that python frame filtering code
1328         is now consistent with what 'backtrace' command prints.
1329
1330 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1331
1332         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1333         comments.
1334         (print_frame_info_auto, print_frame_info_source_line,
1335         print_frame_info_location, print_frame_info_source_and_location,
1336         print_frame_info_location_and_address, print_frame_info_short_location):
1337         New declarations.
1338         (struct frame_print_options): New member print_frame_info.
1339         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1340         * stack.h (get_user_print_what_frame_info): New declaration.
1341         (frame_show_address): New declaration.
1342         * stack.c (print_frame_arguments_choices): New value 'presence'.
1343         (print_frame_info_auto, print_frame_info_source_line,
1344         print_frame_info_location, print_frame_info_source_and_location,
1345         print_frame_info_location_and_address, print_frame_info_short_location,
1346         print_frame_info_choices, print_frame_info_print_what): New definitions.
1347         (print_frame_args): Only print dots for args if print frame-arguments
1348         is 'presence'.
1349         (frame_print_option_defs): New element for "frame-info".
1350         (get_user_print_what_frame_info): New function.
1351         (frame_show_address): Make non static.  Move comment to stack.h.
1352         (print_frame_info_to_print_what): New function.
1353         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1354         to decide what to print.
1355         (backtrace_command_1): Handle the new print_frame_arguments_presence
1356         value.
1357         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1358         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1359         (py_print_frame): In non-mi mode, use LOCATION as default for
1360         print_what, similarly to frame information printed directly by
1361         backtrace command. Handle frame-info user option in non MI mode.
1362
1363 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1364
1365         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1366         Add case for debugging 32-bit target on 64-bit host.  Revise
1367         comment.
1368
1369 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1370
1371         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1372         instead of find_function_entry_range_from_pc.
1373
1374 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1375
1376         * stack.c (find_frame_funname): Remove code which preferred
1377         minsym over symtab sym in "certain pathological cases".
1378
1379         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1380         parameter.  Change type of "do_demangle" to bool.
1381         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1382         Pass suitable "prefer_sym_over_minsym" flag to
1383         build_address_symbolic().  Don't output "+" for negative offsets.
1384         * printcmd.c (print_address_symbolic): Update invocation of
1385         build_address_symbolic to include a "prefer_sym_over_minsym"
1386         flag.
1387         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1388         Restrict cases in which use of minimal symbol is preferred to that
1389         of a found symbol.  Update comments.
1390
1391         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1392         for entry pc when entry pc is out of range for that FDE.
1393
1394 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1395
1396         PR gdb/24839:
1397         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1398         type.
1399
1400 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1401
1402         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1403         this function's Python signature.
1404
1405
1406 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1407
1408         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1409         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1410         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1411         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1412         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1413
1414
1415 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1416
1417         * h8300-tdep.c (h8300_register_name_common): New.
1418         h8300_register_name): Use h8300_register_name_common.
1419         (h8300s_register_name): Likewise.
1420         (h8300sx_register_name): Likewise.
1421         (h8300h_register_nam): New.
1422         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1423
1424
1425 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1426
1427         * arm-tdep.c (arm_skip_cmse_entry): New function.
1428         (arm_is_sgstubs_section): New function.
1429         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1430
1431 2019-07-22  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1434         Don't self-assign.
1435
1436 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1437
1438         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1439         type_print.
1440
1441 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1442
1443         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1444         so that GDB doesn't match any msymbols when searching in the
1445         TYPES_DOMAIN.
1446         (print_symbol_info): Print using typedef_print or type_print based
1447         on the type of the symbol.  Add updated FIXME comment moved from...
1448         (_initialize_symtab): ... move and update FIXME comment to above.
1449
1450 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * NEWS: Mention adding -q option to "info types".
1453         * symtab.c (struct info_types_options): New struct.
1454         (info_types_options_defs): New variable.
1455         (make_info_types_options_def_group): New function.
1456         (info_types_command): Use gdb::option framework to parse options.
1457         (info_types_command_completer): New function.
1458         (_initialize_symtab): Extend the help text on "info types" and
1459         register command completer.
1460
1461 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1462
1463         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1464         (lookup_symbol_in_objfile): Change int to block_enum and add a
1465         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1466
1467 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1468
1469         * MAINTAINERS (Write After Approval): Add self.
1470
1471 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1474         instruction to the dummy code region.
1475
1476 2019-07-19  Tom Tromey  <tromey@adacore.com>
1477
1478         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1479         (ARGSUSED, PARAMS, __func__): Remove rules.
1480
1481 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1482
1483         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1484         * features/arm/arm-with-iwmmxt.c: Remove.
1485         * features/arm/arm-with-iwmmxt.xml: Remove.
1486         * features/arm/arm-with-m-fpa-layout.c: Remove.
1487         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1488         * features/arm/arm-with-m-vfp-d16.c: Remove.
1489         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1490         * features/arm/arm-with-m.c: Remove.
1491         * features/arm/arm-with-m.xml: Remove.
1492         * features/arm/arm-with-neon.c: Remove.
1493         * features/arm/arm-with-neon.xml: Remove.
1494         * features/arm/arm-with-vfpv2.c: Remove.
1495         * features/arm/arm-with-vfpv2.xml: Remove.
1496         * features/arm/arm-with-vfpv3.c: Remove.
1497         * features/arm/arm-with-vfpv3.xml: Remove.
1498
1499 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1500
1501         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1502
1503 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1504
1505         * arch/aarch32.c (aarch32_create_target_description): Create
1506         target descriptions using features.
1507         * arch/arm.c (arm_create_target_description)
1508         (arm_create_mprofile_target_description): Likewise.
1509         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1510
1511 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1512
1513         * Makefile.in: Add new files.
1514         * aarch32-tdep.c: New file.
1515         * aarch32-tdep.h: New file.
1516         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1517         Call aarch32_read_description.
1518         * arch/aarch32.c: New file.
1519         * arch/aarch32.h: New file.
1520         * arch/arm.c (arm_create_target_description)
1521         (arm_create_mprofile_target_description): New function.
1522         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1523         (arm_create_target_description)
1524         (arm_create_mprofile_target_description): New declaration.
1525         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1526         read_description functions.
1527         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1528         Likewise.
1529         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1530         * arm-tdep.c (tdesc_arm_list): New variable.
1531         (arm_register_g_packet_guesses): Call create description functions.
1532         (arm_read_description) (arm_read_mprofile_description): New
1533         function.
1534         * arm-tdep.h (arm_read_description)
1535         (arm_read_mprofile_description): Add declaration.
1536         * configure.tgt: Add new files.
1537
1538 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1539
1540         * top.c (new_ui_command): Open specified terminal just once.
1541
1542 2019-07-18  Tom Tromey  <tromey@adacore.com>
1543
1544         * symtab.c (main_name): Constify return type.
1545         * symfile.c (set_initial_language): Update.
1546         * symtab.h (main_name): Constify return type.
1547
1548 2019-07-17  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-winsource.c (tui_update_source_window)
1551         (tui_update_source_window_as_is)
1552         (tui_update_source_windows_with_line): Remove return.
1553         * tui/tui-disasm.c (tui_show_disassem)
1554         (tui_show_disassem_and_update_source): Remove return.
1555         * tui/tui.c (tui_reset): Remove return.
1556         * tui/tui-wingeneral.c
1557         (tui_check_and_display_highlight_if_needed): Remove return.
1558
1559 2019-07-17  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1562
1563 2019-07-17  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-winsource.h (struct tui_exec_info_window)
1566         (struct tui_source_window_base): Move from tui-data.h.
1567         * tui/tui-winsource.c: Move many method definitions from
1568         elsewhere.  Remove "structuring" comments.
1569         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1570         (tui_source_window_base::refresh_window): Move to
1571         tui-winsource.c.
1572         * tui/tui-win.c (tui_source_window_base::refresh_all)
1573         (tui_source_window_base::update_tab_width)
1574         (tui_source_window_base::set_new_height)
1575         (tui_source_window_base::do_make_visible_with_new_height): Move to
1576         tui-winsource.c.
1577         * tui/tui-source.h: Update.
1578         * tui/tui-source.c (tui_source_window_base::reset): Move to
1579         tui-winsource.c.
1580         * tui/tui-disasm.h: Update.
1581         * tui/tui-data.h (struct tui_exec_info_window): Move to
1582         tui-winsource.h.
1583         (struct tui_source_window_base): Likewise.
1584         * tui/tui-data.c (tui_source_window_base::clear_detail)
1585         (tui_source_window_base, ~tui_source_window_base): Move to
1586         tui-winsource.c.
1587
1588 2019-07-17  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-win.c (tui_resize_all)
1591         (tui_source_window_base::update_tab_width)
1592         (tui_adjust_win_heights): Update.
1593         (tui_win_info::make_invisible_and_set_new_height): Rename from
1594         make_invisible_and_set_new_height.
1595         * tui/tui-data.h (struct tui_win_info)
1596         <make_invisible_and_set_new_height>: New method.
1597
1598 2019-07-17  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui.c: Update.
1601         * tui/tui-source.h (struct tui_source_window): Move from
1602         tui-data.h.
1603         * tui/tui-layout.c: Update.
1604         * tui/tui-disasm.c: Update.
1605         * tui/tui-data.h (struct tui_source_window): Move to
1606         tui-source.h.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1611         tui-data.h.
1612         * tui/tui-data.h (struct tui_disasm_window): Move to
1613         tui-disasm.h.
1614
1615 2019-07-17  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-regs.h (struct tui_data_item_window): Move from
1618         tui-data.h.
1619         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1620         * tui/tui-data.h (struct tui_data_item_window): Move to
1621         tui-regs.h.
1622         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1623
1624 2019-07-17  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui.c: Update.
1627         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1628         (tui_cmd_window::max_height): Move to tui-command.c.
1629         * tui/tui-layout.c: Update.
1630         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1631         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1632         tui-command.c.
1633         * tui/tui-command.h (struct tui_cmd_window): Move from
1634         tui-data.h.
1635         * tui/tui-command.c: Remove "structuring" comments.
1636         (tui_cmd_window::clear_detail)
1637         (tui_cmd_window::do_make_visible_with_new_height)
1638         (tui_cmd_window::max_height): Move from elsewhere.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1643         Now static.
1644         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1645         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1646
1647 2019-07-17  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui.c: Update.
1650         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1651         tui-regs.c.
1652         * tui/tui-windata.h: Remove file.
1653         * tui/tui-windata.c: Remove file.
1654         * tui/tui-win.c (tui_data_window::set_new_height)
1655         (tui_data_window::do_make_visible_with_new_height): Move to
1656         tui-regs.c.
1657         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1658         * tui/tui-regs.c: Remove "structuring" comments.
1659         (tui_data_window::first_data_item_displayed)
1660         (tui_data_window::delete_data_content_windows)
1661         (tui_data_window::erase_data_content)
1662         (tui_data_window::display_all_data)
1663         (tui_data_window::refresh_all)
1664         (tui_data_window::do_scroll_vertical)
1665         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1666         (tui_data_window::do_make_visible_with_new_height)
1667         (tui_data_window::refresh_window): Move from elsewhere.
1668         (_initialize_tui_regs): Move to end of file.
1669         * tui/tui-layout.c: Update.
1670         * tui/tui-hooks.c: Update.
1671         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1672         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1673         tui-regs.c.
1674         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1675
1676 2019-07-17  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1679         seen.
1680
1681 2019-07-17  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-win.c (tui_source_window_base::set_new_height)
1684         (tui_source_window_base::do_make_visible_with_new_height): Use
1685         m_has_locator field directly.
1686         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1687         method.
1688         (struct tui_source_window_base) <has_locator>: Likewise.
1689
1690 2019-07-17  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1693         Don't declare.
1694         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1695         Remove.
1696         * tui/tui-win.c (tui_source_window_base::set_new_height)
1697         (tui_source_window_base::set_new_height)
1698         (make_invisible_and_set_new_height)
1699         (tui_source_window_base::do_make_visible_with_new_height)
1700         (tui_source_window_base::do_make_visible_with_new_height):
1701         Update.
1702         * tui/tui-layout.c (show_source_disasm_command, show_data)
1703         (show_source_or_disasm_and_command): Update.
1704         * tui/tui-layout.c (show_layout): Update.
1705
1706 2019-07-17  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-layout.c (make_data_window): Remove.
1709         (show_data): Unify creation and re-initialization cases.
1710
1711 2019-07-17  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-layout.c (make_source_window, make_disasm_window):
1714         Remove.
1715         (show_data): Unify creation and re-initialization cases.
1716
1717 2019-07-17  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-layout.c (make_command_window): Remove.
1720         (show_source_disasm_command, show_source_or_disasm_and_command):
1721         Unify creation and re-initialization cases.
1722
1723 2019-07-17  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1726         creation and re-initialization cases.
1727
1728 2019-07-17  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-regs.c (tui_get_register): Return void.
1731
1732 2019-07-17  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1735         Simplify.
1736
1737 2019-07-17  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1740         resetting.
1741
1742 2019-07-17  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1745         * tui/tui-regs.c (tui_reg_layout): New function.
1746         (tui_show_registers, tui_reg_command): Use it.
1747         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1748         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1749         parameters.
1750         (tui_layout_command): Remove.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-layout.h (tui/tui-layout): Return void.
1755         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1756
1757 2019-07-17  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-layout.c (show_source_disasm_command, show_data):
1760         Update.
1761         (reset_locator): Remove.
1762         (show_source_or_disasm_and_command): Update.
1763
1764 2019-07-17  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-source.c (tui_source_window_base::reset): Remove
1767         win_type parameter.
1768         * tui/tui-layout.c (make_command_window, make_source_window)
1769         (make_disasm_window, make_data_window)
1770         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1771         (reset_locator, show_source_or_disasm_and_command): Update.
1772         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1773         win_type parameter.
1774         (struct tui_source_window_base) <reset>: Likewise.
1775
1776 2019-07-17  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-layout.c (show_source_disasm_command): Use
1779         reset_locator.
1780         (reset_locator): New function.
1781         (init_and_make_win): Remove.
1782         (show_source_or_disasm_and_command): Use reset_locator.
1783
1784 2019-07-17  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1787         condition.
1788         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1789         Remove condition.
1790         * tui/tui-source.c (tui_source_window_base::reset): New method.
1791         * tui/tui-layout.c (make_command_window): Don't call
1792         init_and_make_win.
1793         (make_source_window, make_disasm_window): Don't call
1794         make_source_or_disasm_window.
1795         (make_data_window): Don't call init_and_make_win.  Change calling
1796         convention.
1797         (show_source_disasm_command, show_data): Simplify.
1798         (make_source_or_disasm_window): Remove.
1799         (show_source_or_disasm_and_command): Simplify.
1800         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1801         (struct tui_source_window_base) <reset>: Likewise.
1802         <execution_info>: Remove initializer.
1803         * tui/tui-data.c (tui_source_window_base): Initialize
1804         execution_info.
1805
1806 2019-07-17  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1809         variable.
1810
1811 2019-07-17  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui.c (tui_rl_other_window): Update.
1814         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1815         superclass method first.  Always iterate over regs_content.
1816         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1817         method.
1818         * tui/tui-win.c (tui_set_focus_command): Update.
1819
1820 2019-07-17  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-win.c (tui_set_focus_command): Rename from
1823         tui_set_focus.  Call tui_enable.
1824         (tui_set_focus_command): Remove.
1825
1826 2019-07-17  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1829         refresh_window.
1830         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1831         touchwin.
1832         (tui_data_window::refresh_window): Call refresh_window on data
1833         items.  Always call superclass refresh_window.
1834         (tui_win_info::refresh): Remove.
1835         (tui_source_window_base::refresh_window): Update.
1836         (tui_refresh_all): Update.
1837         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1838         refresh_window.
1839         (show_source_or_disasm_and_command): Likewise.
1840         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1841         (struct tui_source_window_base) <refresh>: Likewise.
1842
1843 2019-07-17  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-winsource.c (tui_clear_source_content)
1846         (tui_show_source_content): Update.
1847         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1848         whether content is empty.
1849         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1850         Remove.
1851
1852 2019-07-17  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1855         window's contents.
1856         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1857         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1858
1859 2019-07-17  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1862         (struct tui_data_item_window): Update.
1863
1864 2019-07-17  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1867         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1868         defines.
1869
1870 2019-07-17  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-winsource.h (tui_erase_source_content)
1873         (tui_clear_source_content): Remove "display_prompt" parameter.
1874         * tui/tui-winsource.c (tui_update_source_window_as_is)
1875         (tui_update_source_windows_with_addr): Update.
1876         (tui_clear_source_content): Remove "display_prompt" parameter.
1877         (tui_erase_source_content): Likewise.  Simplify.
1878         (tui_show_source_content): Update.
1879         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1880         * tui/tui-stack.c (tui_show_frame_info): Update.
1881         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1882         Remove defines.
1883
1884 2019-07-17  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1887         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1888         parameter.
1889         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1890         parameter.
1891
1892 2019-07-17  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-winsource.c (tui_clear_source_content)
1895         (tui_show_source_content, tui_show_exec_info_content)
1896         (tui_clear_exec_info_content): Update.
1897         * tui/tui-stack.c (tui_show_locator_content): Update.
1898         (tui_show_frame_info): Update.
1899         * tui/tui-source.h (tui_source_window): Don't declare.
1900         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1901         from tui_source_is_displayed.
1902         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1903         Remove field.
1904         (struct tui_source_window_base) <content_in_use>: New field.  Now
1905         bool.
1906         (struct tui_source_window) <showing_source_p>: New method.
1907         (TUI_SRC_WIN): Change cast.
1908         * tui/tui-data.c (tui_initialize_static_data): Update.
1909
1910 2019-07-17  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1913         location_matches_p.
1914         * tui/tui-source.c (tui_source_window::location_matches_p): New
1915         method.
1916         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1917         method.
1918         * tui/tui-data.h (struct tui_source_window_base)
1919         <location_matches_p>: New method.
1920         (struct tui_source_window, struct tui_disasm_window)
1921         <location_matches_p>: Likewise.
1922
1923 2019-07-17  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-win.c (tui_set_win_height_command): Rename from
1926         tui_set_win_height.
1927         (tui_set_win_height_command): Remove.
1928
1929 2019-07-17  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-source.c (tui_source_window): New constructor.  Add
1932         observer.
1933         (~tui_source_window): New destructor.
1934         (tui_source_window::style_changed): New method.
1935         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1936         (tui_attach_detach_observers): Update.
1937         * tui/tui-data.h (struct tui_source_window): Make constructor not
1938         inline.  Add destructor.
1939         (struct tui_source_window) <style_changed>: New method.
1940         <m_observable>: New member.
1941
1942 2019-07-17  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1945         * tui/tui-win.c (tui_resize_all): Fix typo.
1946
1947 2019-07-17  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1950         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1951         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1952         * tui/tui-win.c (window_name_completer): Use foreach.
1953         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1954         (update_tab_width): Likewise.
1955         * tui/tui-layout.c (show_layout): Update.
1956         * tui/tui-data.h (class tui_window_iterator): New.
1957         (struct all_tui_windows): New.
1958         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1959
1960 2019-07-17  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1963         parameter.  Don't reference globals.
1964         (tui_reg_command): Update.
1965
1966 2019-07-17  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-regs.c (tui_show_registers): Simplify.
1969
1970 2019-07-17  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-regs.c (tui_show_registers): Update.
1973         (tui_show_register_group): Add win_info parameter.
1974
1975 2019-07-17  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1978         Rename from tui_display_reg_element_at_line.
1979         (tui_data_window::display_registers_from_line): Update.
1980         * tui/tui-data.h (struct tui_data_window)
1981         <display_reg_element_at_line>: New method.
1982
1983 2019-07-17  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-regs.h (tui_display_registers_from)
1986         (tui_display_registers_from_line): Don't declare.
1987         * tui/tui-windata.c (tui_data_window::display_all_data)
1988         (tui_data_window::refresh_all)
1989         (tui_data_window::do_scroll_vertical): Update.
1990         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1991         from tui_display_registers_from.
1992         (tui_display_reg_element_at_line): Update.
1993         (tui_data_window::display_registers_from_line): Rename from
1994         tui_display_registers_from_line.
1995         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1996         display_registers_from_line>: New methods.
1997
1998 2019-07-17  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2001         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2002         from tui_erase_data_content.
2003         (tui_data_window::display_all_data)
2004         (tui_data_window::refresh_all)
2005         (tui_data_window::do_scroll_vertical): Update.
2006         * tui/tui-regs.c (tui_show_registers): Update.
2007         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2008         New method.
2009
2010 2019-07-17  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2013         declare.
2014         * tui/tui-windata.c
2015         (tui_data_window::delete_data_content_windows): Rename from
2016         tui_delete_data_content_windows.
2017         (tui_data_window::display_all_data)
2018         (tui_data_window::do_scroll_vertical): Update.
2019         * tui/tui-data.h (struct tui_data_window)
2020         <delete_data_content_windows>: New method.
2021
2022 2019-07-17  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2025         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2026
2027 2019-07-17  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2030         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2031         from tui_display_all_data.
2032         * tui/tui-win.c
2033         (tui_data_window::do_make_visible_with_new_height): Update.
2034         * tui/tui-regs.c (tui_show_registers): Update.
2035         * tui/tui-layout.c (tui_set_layout): Update.
2036         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2037         method.
2038
2039 2019-07-17  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2042         * tui/tui-windata.c (tui_display_data_from): Remove.
2043         (tui_data_window::refresh_all): Update.
2044
2045 2019-07-17  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2048         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2049         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2050         tui_display_registers_from_line.
2051         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2052         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2053         "force_display" parameter.
2054
2055 2019-07-17  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2058         declare.
2059         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2060         Rename from tui_first_reg_element_no_inline.
2061         (tui_display_reg_element_at_line)
2062         (tui_display_registers_from_line): Update.
2063         * tui/tui-data.h (struct tui_data_window)
2064         <first_reg_element_no_inline>: New method.
2065
2066 2019-07-17  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-windata.c (tui_display_data_from)
2069         (tui_data_window::do_scroll_vertical): Update.
2070         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2071         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2072         Rename from tui_line_from_reg_element_no.
2073         (tui_display_registers_from_line): Update.
2074         * tui/tui-data.h (struct tui_data_window)
2075         <line_from_reg_element_no>: New method.
2076
2077 2019-07-17  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2080         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2081         tui_last_regs_line_no.
2082         (tui_display_reg_element_at_line)
2083         (tui_display_registers_from_line): Update.
2084         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2085         method.
2086
2087 2019-07-17  Tom Tromey  <tom@tromey.com>
2088
2089         PR tui/24722:
2090         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2091         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2092         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2093         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2094         (tui_update_breakpoint_info): Likewise.
2095         * tui/tui-hooks.c (tui_event_create_breakpoint)
2096         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2097         Update.
2098
2099 2019-07-17  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2102
2103 2019-07-17  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-winsource.c (tui_update_source_window_as_is)
2106         (tui_update_source_windows_with_addr): Update.
2107         * tui/tui-source.h (tui_set_source_content)
2108         (tui_show_symtab_source): Add "win_info" parameter.
2109         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2110         parameter.
2111         (tui_show_symtab_source): Likewise.
2112
2113 2019-07-17  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-wingeneral.c
2116         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2117
2118 2019-07-17  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2121         (struct tui_cmd_window) <can_scroll>: New method.
2122         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2123         method.
2124
2125 2019-07-17  Tom Tromey  <tromey@adacore.com>
2126
2127         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2128         do_field_signed>: Rename.  Change type of "value".
2129         * ui-out.c (ui_out::field_signed): Rename from field_int.
2130         Change type of "value".
2131         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2132         type of "value".
2133         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2134         do_field_int.  Change type of "value".
2135         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2136         do_field_int.  Change type of "value".
2137         * tracepoint.c (trace_status_mi, tfind_1)
2138         (print_one_static_tracepoint_marker): Update.
2139         * thread.c (print_thread_info_1, print_selected_thread_frame):
2140         Update.
2141         * stack.c (print_frame, print_frame_info): Update.
2142         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2143         Update.
2144         * source.c (print_source_lines_base): Update.
2145         * skip.c (info_skip_command): Update.
2146         * record-btrace.c (btrace_ui_out_decode_error)
2147         (btrace_call_history_src_line): Update.
2148         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2149         Update.
2150         * progspace.c (print_program_space): Update.
2151         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2152         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2153         do_field_int.  Change type of "value".
2154         * mi/mi-out.c (mi_ui_out::do_table_begin)
2155         (mi_ui_out::do_table_header): Update.
2156         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2157         type of "value".
2158         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2159         (mi_cmd_data_list_changed_registers, output_register)
2160         (mi_cmd_data_read_memory, mi_load_progress)
2161         (mi_cmd_trace_frame_collected): Update.
2162         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2163         Update.
2164         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2165         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2166         (mi_cmd_var_list_children, varobj_update_one): Update.
2167         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2168         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2169         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2170         * inferior.c (print_inferior): Update.
2171         * gdb_bfd.c (print_one_bfd): Update.
2172         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2173         Update.
2174         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2175         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2176         do_field_int.  Change type of "value".
2177         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2178         do_field_int.  Change type of "value".
2179         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2180         (print_one_breakpoint_location, print_it_catch_fork)
2181         (print_one_catch_fork, print_it_catch_vfork)
2182         (print_one_catch_vfork, print_it_catch_solib)
2183         (print_it_catch_exec, print_it_ranged_breakpoint)
2184         (print_mention_watchpoint, print_mention_masked_watchpoint)
2185         (bkpt_print_it, update_static_tracepoint): Update.
2186         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2187         * break-catch-syscall.c (print_it_catch_syscall): Update.
2188         * ada-tasks.c (print_ada_task_info): Update.
2189         * ada-lang.c (print_it_exception, print_mention_exception):
2190         Update.
2191
2192 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         PR breakpoints/24541
2195         * gdbarch.c: Regenerate.
2196         * gdbarch.h: Regenerate.
2197         * gdbarch.sh: Adjust return type and parameter types for
2198         'stap_adjust_register'.
2199         (i386_stap_adjust_register): Adjust signature and return new
2200         register name.
2201         * stap-probe.c (stap_parse_register_operand): Adjust use of
2202         'gdbarch_stap_adjust_register'.
2203
2204 2019-07-17  Tom Tromey  <tromey@adacore.com>
2205
2206         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2207         declare VEC.
2208         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2209         std::vector.
2210         (struct s390_process_info): Add initializers.
2211         (s390_add_process): Use new.
2212         (s390_linux_nat_target::low_forget_process): Use delete.
2213         (s390_linux_nat_target::low_new_fork)
2214         (s390_linux_nat_target::stopped_by_watchpoint)
2215         (s390_linux_nat_target::low_prepare_to_resume)
2216         (s390_linux_nat_target::insert_watchpoint)
2217         (s390_linux_nat_target::insert_hw_breakpoint)
2218         (s390_linux_nat_target::remove_watchpoint)
2219         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2220
2221 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2222
2223         * aarch64-fbsd-nat.c: Include regcache.h.
2224         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2225         argument.
2226         (aarch64_fbsd_nat_target::fetch_registers)
2227         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2228         variable.
2229         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2230
2231 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2232
2233         * fbsd-nat.c: Include gdbarch.h.
2234
2235 2019-07-15  Tom Tromey  <tromey@adacore.com>
2236
2237         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2238
2239 2019-07-15  Tom Tromey  <tromey@adacore.com>
2240
2241         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2242         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2243         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2244         * cli-out.c (cli_ui_out::do_field_int): New method.
2245         * ui-out.c (ui_out::field_unsigned): New method.
2246         * symfile.c (generic_load): Use field_unsigned.
2247         (print_transfer_performance): Likewise.
2248         * record-btrace.c (ui_out_field_uint): Remove.
2249         (btrace_call_history_insn_range, btrace_call_history): Use
2250         field_unsigned.
2251         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2252         field_unsigned.
2253         * ui-out.h (class ui_out) <field_unsigned>: New method.
2254         <do_field_unsigned>: Likewise.
2255
2256 2019-07-15  Tom Tromey  <tromey@adacore.com>
2257
2258         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2259         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2260         * target.c (flash_erase_command): Use field_string.
2261         * infrun.c (print_signal_received_reason): Use field_string.
2262         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2263         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2264         field_string.
2265         * ada-tasks.c (print_ada_task_info): Use field_string.
2266
2267 2019-07-15  Tom Tromey  <tromey@adacore.com>
2268
2269         * target.c (flash_erase_command): Use field_core_addr.
2270         * symfile.c (generic_load): Use field_core_addr.
2271         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2272         Use field_core_addr.
2273         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2274         field_core_addr.
2275
2276 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2279         value if its desired type is smaller than a CORE_ADDR and signed.
2280
2281 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2284         of changes to field names, and use new is_reference field to
2285         decide if a property is a reference or not.
2286         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2287         field.
2288         (struct dwarf2_property_baton): Update header comment, rename
2289         'referenced_type' to 'property_type' and update comments.
2290         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2291         default property type, store in property baton, update to take
2292         accound of renamed field.
2293         (read_func_scope): Update call to attr_to_dynamic_prop.
2294         (read_array_type): Likewise.
2295         (dwarf2_per_cu_addr_sized_int_type): New function.
2296         (read_subrange_index_type): Move type finding code to
2297         dwarf2_per_cu_addr_sized_int_type.
2298         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2299         (dwarf2_per_cu_addr_type): New function.
2300         (set_die_type): Update calls to attr_to_dynamic_prop.
2301
2302 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * dwarf2read.c (read_subrange_index_type): New function.
2305         (read_subrange_type): Move code into new function and call it.
2306         * gdbtypes.c (create_range_type): Add some asserts.
2307
2308 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2311         update return statements.
2312         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2313         declaration, and update comment to match.
2314         * gdbtypes.c (resolve_dynamic_array): Update call to
2315         dwarf2_evaluate_property to match new return type.
2316
2317 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * valarith.c (value_subscripted_rvalue): Change lowerbound
2320         parameter type from int to LONGEST.
2321         * value.h (value_subscripted_rvalue): Likewise in declaration.
2322
2323 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * cli/cli-utils.c (info_print_command_completer): New function.
2326         * cli/cli-utils.h: Add 'completer.h' include, and forward
2327         declaration for 'struct cmd_list_element'.
2328         (info_print_command_completer): Declare.
2329         * stack.c (_initialize_stack): Add completer for 'info locals' and
2330         'info args'.
2331         * symtab.c (_initialize_symtab): Add completer for 'info
2332         variables' and 'info functions'.
2333         * NEWS: Mention completion for additional info commands.
2334
2335 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         * cli/cli-utils.c (extract_info_print_args): Delete.
2338         (extract_arg_maybe_quoted): Delete.
2339         (info_print_options_defs): New variable.
2340         (make_info_print_options_def_group): New function.
2341         (extract_info_print_options): Define new function.
2342         * cli/cli-utils.h (extract_info_print_args): Delete.
2343         (struct info_print_options): New structure.
2344         (extract_info_print_options): Declare new function.
2345         * stack.c (info_locals_command): Update to use new
2346         extract_info_print_options, also add a header comment.
2347         (info_args_command): Likewise.
2348         * symtab.c (info_variables_command): Likewise.
2349         (info_functions_command): Likewise.
2350
2351 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2354         to extract string arguments.
2355         * common/common-utils.c (extract_string_maybe_quoted): New function.
2356         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2357
2358 2019-07-11  Tom Tromey  <tromey@adacore.com>
2359
2360         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2361         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2362         * top.h (gdbinit): Don't declare.
2363         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2364         into...
2365         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2366         * top.c (gdb_init): Don't call init_cli_cmds.
2367         (gdbinit): Remove.
2368         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2369
2370 2019-07-11  Tom Tromey  <tromey@adacore.com>
2371
2372         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2373         after it has been moved.
2374
2375 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2376
2377         * valops.c (value_must_coerce_to_target): Change return type to
2378         bool.
2379         * value.h (value_must_coerce_to_target): Likewise.
2380
2381 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2382
2383         * breakpoint.c (is_hardware_watchpoint): Remove
2384         forward-declaration.
2385         (is_masked_watchpoint): Change return type to bool.
2386         (is_tracepoint): Likewise.
2387         (is_breakpoint): Likewise.
2388         (is_hardware_watchpoint): Likewise.
2389         (is_watchpoint): Likewise.
2390         (is_no_memory_software_watchpoint): Likewise.
2391         (is_catchpoint): Likewise.
2392         (breakpoint_1): Make FILTER parameter's return type bool.
2393         is_masked_watchpoint): Change return type to bool.
2394         (save_breakpoints): Make FILTER parameter's return type bool.
2395         * breakpoint.h (is_breakpoint): Change return type to bool.
2396         (is_watchpoint): Likewise.
2397         (is_catchpoint): Likewise.
2398         (is_tracepoint): Likewise.
2399
2400 2019-07-10  Tom Tromey  <tom@tromey.com>
2401
2402         * defs.h: Don't include gdbarch.h.
2403         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2404         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2405         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2406         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2407         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2408         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2409         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2410         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2411         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2412         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2413         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2414         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2415         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2416         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2417         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2418         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2419         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2420         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2421         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2422         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2423         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2424         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2425         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2426         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2427         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2428         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2429         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2430
2431 2019-07-10  Tom Tromey  <tromey@adacore.com>
2432
2433         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2434         * breakpoint.c (init_ada_exception_breakpoint): Register as
2435         bp_catchpoint.
2436         (print_one_breakpoint_location, print_one_breakpoint): Use
2437         is_ada_exception_catchpoint.
2438         * ada-lang.c (class ada_catchpoint_location): Pass
2439         bp_loc_software_breakpoint to bp_location constructor.
2440         (is_ada_exception_catchpoint): New function.
2441
2442 2019-07-10  Tom Tromey  <tromey@adacore.com>
2443
2444         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2445         VEC.
2446         (struct arm_exidx_entry): New method operator<.
2447         (struct arm_exidx_data) <section_maps>: Change type.
2448         (arm_exidx_data_free): Remove.
2449         (arm_exidx_data_key): Change type.  Move lower.
2450         (arm_exidx_new_objfile): Update.
2451         (arm_compare_exidx_entries): Remove.
2452         (arm_find_exidx_entry, _initialize_arm_tdep)
2453
2454 2019-07-10  Tom Tromey  <tromey@adacore.com>
2455
2456         * solib-spu.c (ocl_program_data_key): Change type.
2457         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2458         Update.
2459
2460 2019-07-10  Tom Tromey  <tromey@adacore.com>
2461
2462         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2463         (struct solib_aix_inferior_data) <library_list>: Change type.
2464         (solib_aix_inferior_data_handle): Change type.
2465         (get_solib_aix_inferior_data): Update.
2466         (solib_aix_free_library_list): Remove.
2467         (library_list_start_library): Update.
2468         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2469         return type.
2470         (solib_aix_get_library_list)
2471         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2472         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2473
2474 2019-07-10  Tom Tromey  <tromey@adacore.com>
2475
2476         * solib-dsbt.c (struct dsbt_info): Add initializers.
2477         (solib_dsbt_pspace_data): Change type.
2478         (dsbt_pspace_data_cleanup): Remove.
2479         (get_dsbt_info, _initialize_dsbt_solib): Update.
2480
2481 2019-07-10  Tom Tromey  <tromey@adacore.com>
2482
2483         * spu-tdep.c (spu_overlay_data): Change type.
2484         (spu_get_overlay_table, spu_overlay_new_objfile)
2485         (_initialize_spu_tdep): Update.
2486
2487 2019-07-10  Tom Tromey  <tromey@adacore.com>
2488
2489         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2490         destructor.
2491         (dbx_objfile_data_key): Change type and declare later.
2492         (DBX_SYMFILE_INFO): Rewrite.
2493         * dbxread.c (dbx_objfile_data_key): Change type.
2494         (dbx_symfile_init): Update.
2495         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2496         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2497         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2498
2499 2019-07-10  Tom Tromey  <tromey@adacore.com>
2500
2501         * jit.c (jit_program_space_key): Change type.  Move lower.
2502         (get_jit_program_space_data): Update.
2503         (jit_program_space_data_cleanup): Remove.
2504         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2505         Update.
2506         (struct jit_program_space_data): Add initializers.
2507
2508 2019-07-10  Tom Tromey  <tromey@adacore.com>
2509
2510         * solib-darwin.c (struct darwin_info): Add initializers.
2511         (solib_darwin_pspace_data): Change type.
2512         (darwin_pspace_data_cleanup): Remove.
2513         (get_darwin_info, _initialize_darwin_solib): Update.
2514
2515 2019-07-10  Tom Tromey  <tromey@adacore.com>
2516
2517         * remote-sim.c (struct sim_inferior_data): Add initializers,
2518         constructor, and destructor.
2519         (sim_inferior_data_key): Change type.  Move lower.
2520         (check_for_duplicate_sim_descriptor): Update.
2521         (get_sim_inferior_data): Use new.  Update.
2522         (~sim_inferior_data_cleanup): Rename from
2523         sim_inferior_data_cleanup.  Simplify.
2524         (gdbsim_close_inferior, simulator_command)
2525         (sim_command_completer, _initialize_remote_sim): Update.
2526         (next_pid, INITIAL_PID): Move earlier.
2527
2528 2019-07-10  Tom Tromey  <tromey@adacore.com>
2529
2530         * python/python-internal.h (create_thread_object): Return
2531         gdbpy_ref.
2532         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2533         * python/py-inferior.c (struct threadlist_entry): Add
2534         constructor.
2535         <thread_obj>: Now a gdbpy_ref.
2536         (thread_to_thread_object): Update.
2537         (add_thread_object): Use new.
2538         (delete_thread_object): Use delete.
2539         (infpy_threads): Update.
2540         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2541         GIL.
2542
2543 2019-07-10  Tom Tromey  <tromey@adacore.com>
2544
2545         * valops.c (value_cast): Specialize error message for Ada.
2546
2547 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2548
2549         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2550
2551 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2552
2553         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2554         bpstat_should_step): Return bool, adjust comments.
2555         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2556         bpstat_should_step): Likewise.
2557
2558 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2559
2560         * features/Makefile: Use feature target descriptions for Arm.
2561         * features/arm/arm-core.c: Generate new file.
2562         * features/arm/arm-fpa.c: Likewise.
2563         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2564         * features/arm/arm-m-profile.c: Likewise.
2565         * features/arm/arm-vfpv2.c: Likewise.
2566         * features/arm/arm-vfpv3.c: Likewise.
2567         * features/arm/xscale-iwmmxt.c: Likewise.
2568         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2569
2570 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2571
2572         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2573         ptrace earlier.
2574
2575 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2576
2577         * features/aarch64-pauth.c: Regenerate.
2578
2579 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2580
2581         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2582         bool.
2583         (bpstat_what): Use false instead of 0.
2584
2585 2019-07-09  Pedro Alves  <palves@redhat.com>
2586
2587         * break-catch-throw.c (is_exception_catchpoint): New.
2588         * breakpoint.c (print_one_breakpoint_location): New parameter
2589         'raw_loc'.  Handle it.  Use
2590         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2591         looking at the breakpoint's type.
2592         (print_one_breakpoint): If handling "maint info breakpoints", also
2593         print locations of exception catchpoints.
2594         * breakpoint.h (is_exception_catchpoint): Declare.
2595
2596 2019-07-09  Pedro Alves  <palves@redhat.com>
2597
2598         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2599         "addr" field.
2600         (allocate_location_exception_catchpoint): New.
2601         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2602         (initialize_throw_catchpoint_ops): Install
2603         allocate_location_exception_catchpoint as allocate_location
2604         method.
2605         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2606         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2607         bp_loc_other.
2608         (breakpoint_address_is_meaningful): Delete.
2609         (bl_address_is_meaningful): New.
2610         (breakpoint_locations_match): Adjust comment.
2611         (bp_location_from_bp_type): New, factored out of...
2612         (bp_location::bp_location(breakpoint *)): ... this.
2613         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2614         factored out of...
2615         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2616         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2617         breakpoint_address_is_meaningful.
2618         (bp_locations_compare): Adjust comment.
2619         (update_global_location_list): Use bl_address_is_meaningful
2620         instead of breakpoint_address_is_meaningful.
2621         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2622         explicit.
2623         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2624         * python/py-breakpoint.c (bppy_get_location): No longer check
2625         whether location is null.
2626
2627 2019-07-09  Pedro Alves  <palves@redhat.com>
2628
2629         PR c++/15468
2630         * breakpoint.c (print_one_breakpoint_location): Remove
2631         single-location assert.
2632
2633 2019-07-09  Tom Tromey  <tom@tromey.com>
2634
2635         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2636         * configure: Rebuild.
2637         * configure.ac: Change common to gdbsupport.
2638         * gdbsupport: Rename from common.
2639         * acinclude.m4: Change common to gdbsupport.
2640         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2641         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2642         gdbsupport.
2643         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2644         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2645         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2646         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2647         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2648         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2649         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2650         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2651         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2652         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2653         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2654         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2655         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2656         coff-pe-read.c, command.h, compile/compile-c-support.c,
2657         compile/compile-c.h, compile/compile-cplus-symbols.c,
2658         compile/compile-cplus-types.c, compile/compile-cplus.h,
2659         compile/compile-loc2c.c, compile/compile.c, completer.c,
2660         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2661         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2662         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2663         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2664         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2665         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2666         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2667         features/aarch64-core.c, features/aarch64-fpu.c,
2668         features/aarch64-pauth.c, features/aarch64-sve.c,
2669         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2670         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2671         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2672         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2673         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2674         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2675         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2676         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2677         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2678         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2679         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2680         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2681         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2682         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2683         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2684         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2685         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2686         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2687         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2688         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2689         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2690         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2691         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2692         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2693         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2694         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2695         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2696         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2697         minsyms.c, mips-linux-tdep.c, namespace.h,
2698         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2699         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2700         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2701         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2702         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2703         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2704         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2705         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2706         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2707         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2708         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2709         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2710         procfs.c, producer.c, progspace.h, psymtab.h,
2711         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2712         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2713         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2714         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2715         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2716         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2717         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2718         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2719         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2720         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2721         target-memory.c, target.c, target.h, target/waitstatus.c,
2722         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2723         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2724         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2725         unittests/array-view-selftests.c,
2726         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2727         unittests/common-utils-selftests.c,
2728         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2729         unittests/format_pieces-selftests.c,
2730         unittests/function-view-selftests.c,
2731         unittests/lookup_name_info-selftests.c,
2732         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2733         unittests/mkdir-recursive-selftests.c,
2734         unittests/observable-selftests.c,
2735         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2736         unittests/parse-connection-spec-selftests.c,
2737         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2738         unittests/scoped_fd-selftests.c,
2739         unittests/scoped_mmap-selftests.c,
2740         unittests/scoped_restore-selftests.c,
2741         unittests/string_view-selftests.c, unittests/style-selftests.c,
2742         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2743         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2744         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2745         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2746         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2747         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2748
2749 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2752         bool value.
2753         (decode_digits_ordinary): Set explicit_line field in sal.
2754         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2755         symtab_and_line that was set on an explicit line number in
2756         assembler code.  Do always update the recorded symtab and line if
2757         we do skip the prologue.
2758
2759 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2760
2761         * breakpoint.c (set_breakpoint_location_function): Remove
2762         explicit_loc parameter.
2763         (momentary_breakpoint_from_master): Update call to
2764         set_breakpoint_location_function.
2765         (add_location_to_breakpoint): Likewise.
2766
2767 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2768
2769         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2770         required features based on default bfd type when no specific bfd
2771         is present.
2772
2773 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2774
2775         * NEWS: Mention that GDB printf and eval commands can now print
2776         C-style and Ada-style convenience var strings without
2777         calling the inferior.
2778         * printcmd.c (printf_c_string): Locally print GDB internal var
2779         instead of transiting via the inferior.
2780         (printf_wide_c_string): Likewise.
2781
2782 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2783
2784         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2785
2786 2019-07-04  Tom Tromey  <tom@tromey.com>
2787
2788         PR tui/24724:
2789         * tui/tui-winsource.c (tui_clear_source_content): Update.
2790         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2791         (tui_update_breakpoint_info): Update.
2792         (tui_set_exec_info_content): Update.
2793         * tui/tui-source.c (tui_set_source_content_nil): Update.
2794         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2795         has_break.
2796         * tui/tui-data.h (enum tui_bp_flag): New.
2797         (tui_bp_flags): New enum flags type.
2798         (struct tui_source_element) <break_mode>: Change type.  Rename
2799         from has_break.
2800         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2801         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2802         constants.
2803         * tui/tui-winsource.h: Fix comment.
2804
2805 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2806
2807         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2808         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2809         (store_fpregs_to_thread)
2810         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2811         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2812         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2813         (IWMMXT_REGS_SIZE): Add define.
2814         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2815         (fetch_vfp_regs, store_vfp_regs)
2816         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2817         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2818
2819 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2820
2821         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2822         defines.
2823         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2824         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2825         (ARM_INT_REGISTER_SIZE): ...to this.
2826         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2827         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2828         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2829         (arm_linux_collect_gregset, supply_nwfpe_register)
2830         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2831         defines.
2832         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2833         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2834         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2835         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2836         (arm_return_in_memory, arm_store_return_value)
2837         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2838         (arm_record_ld_st_multiple): Likewise.
2839         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2840         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2841
2842 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2843
2844         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2845         AARCH64_DISPLACED_MODIFIED_INSNS.
2846         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2847         (aarch64_displaced_step_copy_insn): Likewise.
2848         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2849         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2850         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2851         ARM_DISPLACED_MODIFIED_INSNS.
2852         * arm-tdep.c (arm_gdbarch_init): Likewise.
2853         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2854         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2855         (struct arm_displaced_step_closure): Use
2856         ARM_DISPLACED_MODIFIED_INSNS.
2857
2858 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2859
2860         * features/Makefile: Remove unused xml files.
2861         * features/aarch64.xml: Remove.
2862         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2863         * features/i386/amd64-avx-avx512.xml: Remove.
2864         * features/i386/amd64-avx-linux.xml: Remove.
2865         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2866         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2867         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2868         * features/i386/amd64-avx-mpx.xml: Remove.
2869         * features/i386/amd64-avx.xml: Remove.
2870         * features/i386/amd64-linux.xml: Remove.
2871         * features/i386/amd64-mpx-linux.xml: Remove.
2872         * features/i386/amd64-mpx.xml: Remove.
2873         * features/i386/amd64.xml: Remove.
2874         * features/i386/i386-avx-avx512-linux.xml: Remove.
2875         * features/i386/i386-avx-avx512.xml: Remove.
2876         * features/i386/i386-avx-linux.xml: Remove.
2877         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2878         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2879         * features/i386/i386-avx-mpx-linux.xml: Remove.
2880         * features/i386/i386-avx-mpx.xml: Remove.
2881         * features/i386/i386-avx.xml: Remove.
2882         * features/i386/i386-linux.xml: Remove.
2883         * features/i386/i386-mmx-linux.xml: Remove.
2884         * features/i386/i386-mmx.xml: Remove.
2885         * features/i386/i386-mpx-linux.xml: Remove.
2886         * features/i386/i386-mpx.xml: Remove.
2887         * features/i386/i386.xml: Remove.
2888         * features/i386/x32-avx-avx512-linux.xml: Remove.
2889         * features/i386/x32-avx-linux.xml: Remove.
2890         * features/i386/x32-linux.xml: Remove.
2891
2892 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2893
2894         * regformats/aarch64.dat: Remove.
2895         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2896         * regformats/i386/amd64-avx-linux.dat: Remove.
2897         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2898         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2899         * regformats/i386/amd64-linux.dat: Remove.
2900         * regformats/i386/amd64-mpx-linux.dat: Remove.
2901         * regformats/i386/amd64.dat: Remove.
2902         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2903         * regformats/i386/i386-avx-linux.dat: Remove.
2904         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2905         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2906         * regformats/i386/i386-linux.dat: Remove.
2907         * regformats/i386/i386-mmx-linux.dat: Remove.
2908         * regformats/i386/i386-mpx-linux.dat: Remove.
2909         * regformats/i386/i386.dat: Remove.
2910         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2911         * regformats/i386/x32-avx-linux.dat: Remove.
2912         * regformats/i386/x32-linux.dat: Remove.
2913
2914 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2915
2916         * aarch64-tdep.c: Remove xml self tests.
2917         * amd64-linux-tdep.c: Likewise.
2918         * amd64-tdep.c: Likewise.
2919         * i386-linux-tdep.c: Likewise.
2920         * i386-tdep.c: Likewise.
2921
2922 2019-07-03  Pedro Alves  <palves@redhat.com>
2923
2924         PR cli/24732
2925         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2926         (pipe_cmd_option_defs): New.
2927         (make_pipe_cmd_options_def_group): New.
2928         (pipe_command): Use gdb::option::process_options.
2929         (pipe_command_completer): New function.
2930         (_initialize_cli_cmds): Install completer for "pipe" command.
2931
2932 2019-07-03  Pedro Alves  <palves@redhat.com>
2933
2934         * cli/cli-option.c (union option_value) <string>: New field.
2935         (struct option_def_and_value): Add ctor, move ctor, dtor and
2936         use DISABLE_COPY_AND_ASSIGN.
2937         (option_def_and_value::clear_value): New.
2938         (parse_option, save_option_value_in_ctx, get_val_type_str)
2939         (add_setshow_cmds_for_options): Handle var_string.
2940         * cli-option.h (union option_def::var_address) <string>: New
2941         field.
2942         (struct string_option_def): New.
2943         * maint-test-options.c (struct test_options_opts): Add default
2944         ctor and use DISABLE_COPY_AND_ASSIGN.
2945         <string_opt>: New field.
2946         (test_options_opts::~test_options_opts): New.
2947         (test_options_opts::dump): Also dump "-string".
2948         (test_options_option_defs): Install "string.
2949
2950 2019-07-03  Pedro Alves  <palves@redhat.com>
2951
2952         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2953         option_value with a null enumeration.
2954         (complete_options): Save the option values in the context.
2955         (save_option_value_in_ctx): New, factored out from ...
2956         (process_options): ... here.
2957         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2958         of the function.
2959         * maint-test-options.c (test_options_opts::dump): New, factored
2960         out from ...
2961         (maintenance_test_options_command_mode): ... here.
2962         (maintenance_test_options_command_completion_result): Delete.
2963         (maintenance_test_options_command_completion_text): Update
2964         comment.
2965         (maintenance_show_test_options_completion_result): Change
2966         prototype.  Just print
2967         maintenance_test_options_command_completion_text.
2968         (save_completion_result): New.
2969         (maintenance_test_options_completer_mode): Pass options context to
2970         complete_options, and then save a dump.
2971         (_initialize_maint_test_options): Use add_cmd to install "maint
2972         show test-options-completion-result".
2973
2974 2019-07-03  Pedro Alves  <palves@redhat.com>
2975
2976         * NEWS (New commands): Mention "with" and "maint with".
2977         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2978         (with_command, with_command_completer): New.
2979         (pipe_command): Adjust to new repeat_previous
2980         interface.
2981         (_initialize_cli_cmds): Install the "with" command and its "w"
2982         alias.
2983         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2984         declarations.
2985         * cli/cli-setshow.c (parse_cli_var_uinteger)
2986         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2987         argument strings for all var_types.
2988         (get_setshow_command_value_string): New, factored out from ...
2989         (do_show_command): ... this.
2990         * cli/cli-setshow.h: Include <string>.
2991         (get_setshow_command_value_string): Declare.
2992         * command.h (repeat_previous): Now returns const char *.  Adjust
2993         comment.
2994         * maint.c: Include "cli/cli-cmds.h".
2995         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2996         (_initialize_maint_cmds): Register the "maintenance with" command.
2997         * top.c (repeat_previous): Move bits from pipe_command here:
2998         Return the saved command line, if any; error out if there's no
2999         command to relaunch.
3000
3001 2019-07-03  Pedro Alves  <palves@redhat.com>
3002
3003         * NEWS (New commands): Mention "maint set/show test-settings"
3004         instead of "maint test-settings".
3005         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3006         (maintenance_test_settings_set_list): Rename to ...
3007         (maintenance_set_test_settings_list): ... this.
3008         (maintenance_test_settings_show_list): Rename to  ...
3009         (maintenance_show_test_settings_list): ... this.
3010         (maintenance_test_settings_cmd): Delete.
3011         (maintenance_test_settings_set_cmd): ...
3012         (maintenance_set_test_settings_cmd): ... this.
3013         (maintenance_test_settings_show_cmd): ...
3014         (maintenance_show_test_settings_cmd): ... this.
3015         (maintenance_test_settings_show_value_cmd):
3016         (maintenance_show_test_settings_value_cmd): ... this.
3017         (_initialize_maint_test_settings): No longer install the "maint
3018         test-settings" prefix command.  Rename "maint test-settings set"
3019         to "maint set test-settings", and "maint test-settings show" to
3020         "maint show test-settings".  Adjust all subcommands.
3021
3022 2019-07-03  Pedro Alves  <palves@redhat.com>
3023
3024         * maint-test-settings.c: Fix file's intro comment.  Replace all
3025         references to "test-options" with references to "test-settings",
3026         in comments.
3027
3028 2019-07-03  Pedro Alves  <palves@redhat.com>
3029
3030         * maint-test-settings.c (maintenance_test_settings_xxx)
3031         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3032         New.
3033         (maintenance_test_settings_enums): Use them.
3034         (maintenance_test_settings_enum): Default to
3035         maintenance_test_settings_xxx.
3036         (_initialize_maint_test_settings): Initialize
3037         MAINTENANCE_TEST_SETTINGS_FILENAME.
3038
3039 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3040
3041         * breakpoint.h (remove_breakpoints_inf): Change return type to
3042         void, move function documentation here.
3043         * breakpoint.c (remove_breakpoints_inf): Change return type to
3044         void, move function documentation to header.
3045
3046 2019-07-02  Pedro Alves  <palves@redhat.com>
3047
3048         * NEWS (Completion improvements): Mention "info threads".
3049         * thread.c (struct info_threads_opts, info_threads_option_defs)
3050         (make_info_threads_options_def_group): New.
3051         (info_threads_command): Use gdb::option::process_options.
3052         (info_threads_command_completer): New.
3053         (_initialize_thread): Use gdb::option::build_help to build the
3054         help text for "info threads".
3055
3056 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3057
3058         * defs.h (generic_load): Move from here...
3059         * symfile.h (generic_load): ... to here.  Rename name parameter
3060         to args.
3061         * symfile.c (generic_load): Add comment.
3062
3063 2019-07-01  Tom Tromey  <tromey@adacore.com>
3064
3065         * dwarf2read.c
3066         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3067         declaration of without_params.  Fix formatting.
3068
3069 2019-07-01  Tom Tromey  <tromey@adacore.com>
3070
3071         * ada-exp.y (find_primitive_type): Update.
3072         * ada-lang.h (ada_lookup_symbol): Update.
3073         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3074         parameter.
3075         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3076
3077 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3078
3079         PR breakpoints/24541
3080         * gdbarch.c: Regenerate.
3081         * gdbarch.h: Regenerate.
3082         * gdbarch.sh: Add 'stap_adjust_register'.
3083         * i386-tdep.c: Include '<unordered_set>'.
3084         (i386_stap_adjust_register): New function.
3085         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3086         * stap-probe.c (stap_parse_register_operand): Call
3087         'gdbarch_stap_adjust_register'.
3088
3089 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3090
3091         PR python/24742
3092         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3093         * python/python.c (do_start_initialization): Use 'xmalloc'
3094         instead of 'PyMem_Malloc'.
3095
3096 2019-06-28  Tom Tromey  <tromey@adacore.com>
3097
3098         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3099         for Ada.
3100
3101 2019-06-27  Tom Tromey  <tromey@adacore.com>
3102
3103         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3104         objfile_key.
3105         (arm_find_mapping_symbol, arm_record_special_symbol)
3106         (_initialize_arm_tdep): Update.
3107         (arm_objfile_data_free): Remove.
3108
3109 2019-06-27  Tom Tromey  <tromey@adacore.com>
3110
3111         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3112         to cp_print_static_field.
3113
3114 2019-06-26  Tom Tromey  <tromey@adacore.com>
3115
3116         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3117         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3118         declare.
3119
3120 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3121
3122         * features/aarch64-core.c (create_feature_aarch64_core):
3123         Regenerate.
3124         * features/aarch64-core.xml: Add cpsr flags.
3125
3126 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3127
3128         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3129         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3130
3131 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3132
3133         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3134         field.
3135         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3136         use.
3137         (arm_record_special_symbol): Don't insert new symbol in sorted
3138         position, push it at the end.
3139
3140 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3141
3142         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3143         (arm_mapping_symbol_s): Remove.
3144         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3145         (arm_mapping_symbol_vec): New typedef.
3146         (struct arm_per_objfile): Add constructor.
3147         <section_maps>: Change type to
3148         std::unique_ptr<arm_mapping_symbol_vec[]>.
3149         (arm_compare_mapping_symbols): Remove.
3150         (arm_find_mapping_symbol): Adjust to section_maps type change.
3151         (arm_objfile_data_free): Call delete on arm_per_objfile.
3152         (arm_record_special_symbol): Adjust to section_maps type change.
3153         Allocate arm_per_objfile with new.
3154
3155 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3156
3157         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3158         with the command prefix.
3159
3160 2019-06-25  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3163         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3164
3165 2019-06-25  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3168         type.
3169         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3170         protected.
3171
3172 2019-06-25  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-winsource.c
3175         (tui_source_window_base::set_is_exec_point_at): Add check against
3176         LOA_ADDRESS.
3177
3178 2019-06-25  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-source.c (tui_set_source_content): Don't check before
3181         xfree.
3182         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3183
3184 2019-06-25  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-winsource.h (tui_update_source_window_as_is)
3187         (tui_alloc_source_buffer, tui_line_is_displayed)
3188         (tui_addr_is_displayed): Change type of win_info.
3189         * tui/tui-winsource.c (tui_update_source_window_as_is)
3190         (tui_clear_source_content, tui_show_source_line)
3191         (tui_show_source_content, tui_source_window_base::refill)
3192         (tui_source_window_base::set_is_exec_point_at)
3193         (tui_source_window_base::set_is_exec_point_at)
3194         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3195         (tui_alloc_source_buffer, tui_line_is_displayed)
3196         (tui_addr_is_displayed): Change type of win_info.  Update.
3197         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3198         (tui_source_window_base::do_make_visible_with_new_height):
3199         Update.
3200         * tui/tui-source.c (tui_set_source_content)
3201         (tui_set_source_content_nil)
3202         (tui_source_window::do_scroll_vertical): Update.
3203         * tui/tui-layout.c (show_layout): Update.
3204         * tui/tui-disasm.c (tui_set_disassem_content)
3205         (tui_disasm_window::do_scroll_vertical): Update.
3206         * tui/tui-data.h (tui_win_content): Remove.
3207         (struct tui_gen_win_info) <content, content_size>: Remove.
3208         (struct tui_source_element): Add initializers and destructor.
3209         (union tui_which_element, struct tui_win_element): Remove.
3210         (struct tui_source_window_base) <content>: New field.
3211         (struct tui_data_window): Remove destructor.
3212         (tui_alloc_content, tui_free_win_content)
3213         (tui_free_all_source_wins_content): Don't declare.
3214         * tui/tui-data.c (tui_initialize_static_data): Update.
3215         (init_content_element, tui_alloc_content): Remove.
3216         (~tui_gen_win_info): Update.
3217         (~tui_data_window, tui_free_all_source_wins_content)
3218         (tui_free_win_content, free_content, free_content_elements):
3219         Remove.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-winsource.h (tui_clear_source_content)
3224         (tui_erase_source_content, tui_show_source_content): Change type
3225         of win_info.
3226         * tui/tui-winsource.c (tui_clear_source_content)
3227         (tui_erase_source_content, tui_show_source_content): Change type
3228         of win_info.
3229         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3230         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3231         win_info.
3232         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3233         win_info.
3234         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3235
3236 2019-06-25  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-winsource.c (tui_clear_source_content)
3239         (tui_source_window_base::set_is_exec_point_at): Update.
3240         * tui/tui-source.c (tui_set_source_content_nil): Update.
3241         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3242         a bool.
3243         * tui/tui-data.c (init_content_element): Update.
3244
3245 2019-06-25  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3248         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3249         * tui/tui-layout.c (init_and_make_win): Update.
3250         * tui/tui.h (enum tui_win_type): Update.
3251         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3252         tui_win_is_auxillary.
3253         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3254         tui_win_is_auxillary.
3255
3256 2019-06-25  Tom Tromey  <tom@tromey.com>
3257
3258         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3259         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3260         (tui_delete_data_content_windows, tui_display_all_data)
3261         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3262         Update.
3263         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3264         * tui/tui-regs.c (tui_last_regs_line_no)
3265         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3266         (tui_show_registers): Update.
3267         (tui_show_register_group): Return void.  Update.
3268         (tui_display_registers_from, tui_display_reg_element_at_line)
3269         (tui_display_registers_from_line, tui_check_register_values):
3270         Update.
3271         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3272         member.
3273         (struct tui_data_window) <regs_content>: Now a std::vector.
3274         <regs_content_count>: Remove.
3275         (tui_add_content_elements, tui_free_data_content): Don't declare.
3276         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3277         (init_content_element): Remove DATA_WIN case.  Add assert.
3278         (tui_add_content_elements): Remove.
3279         (tui_data_window): Update.
3280         (tui_free_data_content): Remove.
3281         (free_content_elements): Remove DATA_WIN case.
3282
3283 2019-06-25  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui-data.c (tui_data_item_window): Update.
3286         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3287         * tui/tui-windata.c (tui_display_all_data)
3288         (tui_display_data_from_line): Update.
3289         (tui_check_data_values): Remove.
3290         * tui/tui-regs.c (tui_show_register_group)
3291         (tui_display_reg_element_at_line): Update.
3292         * tui/tui-hooks.c (tui_register_changed)
3293         (tui_refresh_frame_and_register_information): Call
3294         tui_check_register_values.
3295         * tui/tui-data.h (struct tui_data_window) <data_content,
3296         data_content_count, data_type>: Remove.
3297         (enum tui_data_type): Remove.
3298
3299         * tui/tui-data.c (tui_data_window::clear_detail)
3300         (~tui_data_window): Update.
3301
3302 2019-06-25  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3305         declare.
3306         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3307         Rename from tui_first_data_item_displayed.  Update.
3308         (tui_data_window::refresh_all)
3309         (tui_data_window::do_scroll_vertical): Update.
3310         * tui/tui-data.h (struct tui_data_window)
3311         <first_data_item_displayed>: Declare new method.
3312
3313 2019-06-25  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3316         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3317         contents...
3318         (tui_initialize_static_data): ...here.
3319
3320 2019-06-25  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3323         (tui_display_registers_from, tui_check_register_values): Update.
3324         (tui_display_register): Remove win_info parameter; update.
3325         (tui_get_register): Change type of parameters.
3326         * tui/tui-data.h (struct tui_data_element): Remove.
3327         (union tui_which_element) <data>: Remove.
3328         <data_window>: Change type.
3329         (struct tui_data_item_window): New.
3330         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3331         case.  Add assert.
3332         (~tui_data_item_window): New destructor.
3333         (free_content_elements): Remove DATA_ITEM_WIN case.
3334
3335 2019-06-25  Tom Tromey  <tom@tromey.com>
3336
3337         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3338         Remove.
3339
3340 2019-06-25  Tom Tromey  <tom@tromey.com>
3341
3342         * tui/tui-data.h (struct tui_command_element): Remove.
3343         (union tui_which_element) <command>: Remove.
3344         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3345         assert.
3346         (free_content_elements): Remove CMD_WIN case.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-layout.c (tui_set_layout): Update.
3351         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3352         * tui/tui-data.c (layout_def): Update.
3353
3354 2019-06-25  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3357         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3358         (tui_source_window_base::set_new_height): Update.
3359         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3360         Update.
3361         (tui_set_locator_fullname, tui_set_locator_info)
3362         (tui_show_frame_info): Update.
3363         * tui/tui-source.c (tui_set_source_content)
3364         (tui_source_is_displayed): Update.
3365         * tui/tui-layout.c (show_source_disasm_command, show_data)
3366         (show_source_or_disasm_and_command): Update.
3367         * tui/tui-disasm.c (tui_set_disassem_content)
3368         (tui_get_begin_asm_address): Update.
3369         * tui/tui-data.h (struct tui_locator_element): Remove.
3370         (union tui_which_element) <locator>: Remove.
3371         (struct tui_locator_window): New.
3372         (tui_locator_win_info_ptr): Change return type.
3373         * tui/tui-data.c (_locator): Change type.
3374         (tui_locator_win_info_ptr): Change return type.
3375         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3376         (tui_alloc_content): Add assert.
3377
3378 2019-06-25  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui-winsource.c
3381         (tui_exec_info_window::maybe_allocate_content): New method.
3382         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3383         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3384         (make_source_or_disasm_window): Add cast.
3385         * tui/tui-data.h (union tui_which_element) <simple_string>:
3386         Remove.
3387         (struct tui_source_info): New.
3388         (struct tui_source_window_base) <execution_info>: Change type.
3389         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3390         case, and add assert.
3391         (tui_alloc_content): Add assert.
3392
3393 2019-06-25  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3396         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3397         * tui/tui-data.c (tui_alloc_win_info): Remove.
3398
3399 2019-06-25  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3402         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3403         can_highlight.
3404
3405 2019-06-25  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3408         make_visible_with_new_height method.
3409         (tui_win_info::make_visible_with_new_height): New method.
3410         (tui_source_window_base::do_make_visible_with_new_height)
3411         (tui_data_window::do_make_visible_with_new_height)
3412         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3413         (make_visible_with_new_height): Remove.
3414         (tui_resize_all, tui_adjust_win_heights): Use
3415         make_visible_with_new_height method.
3416         * tui/tui-data.h (struct tui_win_info)
3417         <do_make_visible_with_new_height, make_visible_with_new_height>:
3418         New methods.
3419         (struct tui_source_window_base, struct tui_data_window)
3420         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3421         methods.
3422
3423 2019-06-25  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3426         method.
3427         (update_tab_width): Call update_tab_width method.
3428         * tui/tui-data.h (struct tui_win_info)
3429         (struct tui_source_window_base) <update_tab_width>: New methods.
3430
3431 2019-06-25  Tom Tromey  <tom@tromey.com>
3432
3433         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3434         parameter.
3435         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3436         parameter.
3437         (tui_gen_win_info::make_visible): Update.
3438         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3439         parameter.
3440         * tui/tui-data.h (enum tui_box): New enum.
3441         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3442
3443 2019-06-25  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3446         init_and_make_win for EXEC_INFO_WIN.
3447         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3448         longer inline.
3449         (struct tui_win_info) <~tui_win_info>: Inline.
3450         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3451         Don't declare.
3452         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3453         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3454         Remove.
3455         (tui_initialize_static_data): Update.
3456         (~tui_gen_win_info): Handle more cleanup here.
3457         (~tui_source_window_base): Delete "execution_info".
3458         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3459
3460 2019-06-25  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-layout.c (make_command_window): Don't set
3463         can_highlight.
3464         (show_source_disasm_command): Call the reset method.
3465         (show_data): Don't set can_highlight.  Call the reset method.
3466         (tui_gen_win_info::reset): Rename from init_gen_win_info
3467         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3468         (show_source_or_disasm_and_command): Call the reset method.
3469         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3470         (struct tui_cmd_window): Set can_highlight.
3471
3472 2019-06-25  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3475         from make_visible.
3476         (tui_make_visible, tui_make_invisible): Rewrite.
3477         (tui_win_info::make_visible): Remove.
3478         (tui_source_window_base::make_visible): Update.
3479         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3480         method.  Moved from...
3481         (struct tui_win_info) <make_visible>: ...here.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-winsource.c
3486         (tui_source_window_base::do_scroll_horizontal): Remove direction
3487         parameter.
3488         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3489         direction parameter.
3490         * tui/tui-win.c (tui_win_info::forward_scroll)
3491         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3492         (tui_win_info::right_scroll): Update.
3493         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3494         direction parameter.
3495         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3496         direction parameter.
3497         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3498         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3499         Remove direction parameter.
3500         (struct tui_source_window_base, struct tui_source_window)
3501         (struct tui_disasm_window, struct tui_data_window)
3502         (struct tui_cmd_window): Update.
3503
3504 2019-06-25  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-winsource.h (tui_set_exec_info_content)
3507         (tui_show_exec_info_content, tui_erase_exec_info_content)
3508         (tui_clear_exec_info_content, tui_update_exec_info): Change
3509         argument to tui_source_window_base.
3510         * tui/tui-winsource.c (tui_set_exec_info_content)
3511         (tui_show_exec_info_content, tui_erase_exec_info_content)
3512         (tui_clear_exec_info_content, tui_update_exec_info): Change
3513         argument to tui_source_window_base.
3514
3515 2019-06-25  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3518         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3519
3520 2019-06-25  Tom Tromey  <tom@tromey.com>
3521
3522         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3523         check.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3528         type to void.
3529         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3530         type to void.
3531         * tui/tui-source.c (tui_set_source_content): Update.
3532         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3533
3534 2019-06-25  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-win.c (window_name_completer, tui_set_focus)
3537         (tui_all_windows_info): Use name method.
3538         * tui/tui-data.h (struct tui_gen_win_info)
3539         (struct tui_source_window, struct tui_disasm_window)
3540         (struct tui_data_window, struct tui_cmd_window) <name>: New
3541         method.
3542         (tui_win_name): Don't declare.
3543         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3544         (tui_win_name): Remove.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-winsource.h (tui_update_source_window)
3549         (tui_update_source_window_as_is): Change parameter type.
3550         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3551         to be a tui_source_window_base.
3552         (tui_update_source_window_as_is): Likewise.
3553         * tui/tui-win.c (make_visible_with_new_height): Update.
3554
3555 2019-06-25  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui-winsource.c (tui_erase_source_content)
3558         (tui_show_source_content, tui_show_exec_info_content)
3559         (tui_erase_exec_info_content): Use refresh_window method.
3560         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3561         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3562         from tui_refresh_win.
3563         (tui_data_window::refresh_window): New method.
3564         (tui_win_info::refresh, tui_source_window_base::refresh)
3565         (tui_refresh_all): Use refresh_window method.
3566         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3567         method.
3568         * tui/tui-regs.c (tui_display_register): Call refresh_window
3569         method.
3570         * tui/tui-layout.c (show_source_disasm_command)
3571         (show_source_or_disasm_and_command): Call refresh_window method.
3572         * tui/tui-data.h (struct tui_gen_win_info)
3573         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3574         New method.
3575
3576 2019-06-25  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui.c (tui_rl_other_window, tui_enable)
3579         (tui_is_window_visible, tui_get_command_dimension): Update.
3580         * tui/tui-winsource.c (tui_update_source_window_as_is)
3581         (tui_clear_source_content, tui_erase_source_content)
3582         (tui_show_source_line, tui_source_window_base::refill)
3583         (tui_source_window_base::do_scroll_horizontal)
3584         (tui_source_window_base::set_is_exec_point_at)
3585         (tui_update_breakpoint_info, tui_set_exec_info_content)
3586         (tui_alloc_source_buffer, tui_line_is_displayed)
3587         (tui_addr_is_displayed): Update.
3588         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3589         (tui_check_and_display_highlight_if_needed)
3590         (tui_win_info::make_visible, tui_win_info::refresh)
3591         (tui_refresh_all): Update.
3592         * tui/tui-windata.c (tui_first_data_item_displayed)
3593         (tui_delete_data_content_windows, tui_erase_data_content)
3594         (tui_display_all_data, tui_data_window::refresh_all)
3595         (tui_check_data_values): Update.
3596         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3597         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3598         (tui_win_info::backward_scroll, tui_refresh_all_win)
3599         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3600         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3601         (tui_source_window_base::set_new_height)
3602         (tui_data_window::set_new_height)
3603         (make_invisible_and_set_new_height)
3604         (make_visible_with_new_height, new_height_ok)
3605         (parse_scrolling_args): Update.
3606         * tui/tui-stack.c (tui_show_frame_info): Update.
3607         * tui/tui-source.c (tui_set_source_content)
3608         (tui_set_source_content_nil, tui_source_is_displayed)
3609         (tui_source_window::do_scroll_vertical): Update.
3610         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3611         (tui_display_registers_from, tui_display_reg_element_at_line)
3612         (tui_check_register_values, tui_reg_command): Update.
3613         * tui/tui-layout.c (tui_default_win_height)
3614         (show_source_disasm_command, show_data, init_and_make_win)
3615         (show_source_or_disasm_and_command): Update.
3616         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3617         (tui_redisplay_readline, tui_mld_flush)
3618         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3619         (tui_getc): Update.
3620         * tui/tui-disasm.c (tui_set_disassem_content)
3621         (tui_disasm_window::do_scroll_vertical): Update.
3622         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3623         Now virtual.
3624         (struct tui_win_info): Derive from tui_gen_win_info.
3625         <~tui_win_info>: Mark as override.
3626         <generic>: Remove member.
3627         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3628         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3629         (~tui_data_window, ~tui_win_info)
3630         (tui_free_all_source_wins_content): Update.
3631         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3632
3633 2019-06-25  Tom Tromey  <tom@tromey.com>
3634
3635         * tui/tui-layout.c (init_and_make_win): Use new.
3636         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3637         destructor, initializers.
3638         (tui_alloc_generic_win_info): Don't declare.
3639         * tui/tui-data.c (_locator): Add argument to constructor.
3640         (source_win, disasm_win): New globals.
3641         (exec_info): Remove.
3642         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3643         Update.
3644         (tui_alloc_generic_win_info): Remove.
3645         (init_content_element): Use new.
3646         (tui_win_info::tui_win_info): Update.
3647         (free_content_elements) <case DATA_WIN>: Use delete.
3648
3649 2019-06-25  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3652         * tui/tui-windata.c (tui_first_data_item_displayed)
3653         (tui_delete_data_content_windows): Update.
3654         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3655         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3656         (tui_display_registers_from, tui_check_register_values): Update.
3657         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3658         pointer.
3659         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3660         window.
3661         (tui_free_data_content): Update.
3662         (free_content_elements) <case DATA_WIN>: Free the window.
3663
3664 2019-06-25  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3667         Update.
3668         * tui/tui-layout.c (make_command_window)
3669         (show_source_disasm_command, show_data, init_and_make_win)
3670         (show_source_or_disasm_and_command): Update.
3671         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3672         method.
3673         <can_highight, is_highlighted>: Now bool.
3674         (tui_set_win_highlight): Don't declare.
3675         * tui/tui-data.c (tui_set_win_highlight): Remove.
3676
3677 2019-06-25  Tom Tromey  <tom@tromey.com>
3678
3679         * tui/tui-wingeneral.c (make_visible): Remove check of window
3680         type.
3681
3682 2019-06-25  Tom Tromey  <tom@tromey.com>
3683
3684         * tui/tui-win.c (tui_win_info::max_height)
3685         (tui_cmd_window::max_height): New methods.
3686         (new_height_ok): Call max_height.
3687         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3688         <max_height>: New method.
3689
3690 2019-06-25  Tom Tromey  <tom@tromey.com>
3691
3692         * tui/tui-win.c (tui_source_window_base::set_new_height)
3693         (tui_data_window::set_new_height): New methods.
3694         (make_invisible_and_set_new_height): Call set_new_height method.
3695         * tui/tui-data.h (struct tui_win_info)
3696         (struct tui_source_window_base, struct tui_data_window)
3697         <set_new_height>: New method.
3698
3699 2019-06-25  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3702         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3703         tui_refresh_data_win.
3704         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3705         method.
3706         (tui_refresh_all_win): Call the refresh_all method.
3707         (tui_set_focus): Likewise.
3708         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3709         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3710         Likewise.
3711
3712 2019-06-25  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui-winsource.h (tui_refill_source_window)
3715         (tui_set_is_exec_point_at): Don't declare.
3716         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3717         (tui_source_window_base::refill): Rename from
3718         tui_refill_source_window.
3719         (tui_source_window_base::do_scroll_horizontal): Update.
3720         (tui_source_window_base::set_is_exec_point_at): Rename from
3721         tui_set_is_exec_point_at.
3722         (tui_update_all_breakpoint_info): Update.
3723         * tui/tui-stack.c (tui_show_frame_info): Update.
3724         * tui/tui-layout.c (show_data): Add cast.
3725         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3726         * tui/tui-data.h (struct tui_source_window_base) <refill,
3727         set_is_exec_point_at>: New methods.
3728         (tui_source_windows, tui_add_to_source_windows): Update types.
3729         (tui_add_to_source_windows): Remove redundant declaration.
3730         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3731         (tui_source_windows): Change return type.
3732         (tui_clear_source_windows_detail): Update.
3733         (tui_add_to_source_windows): Change type of parameter.
3734         (tui_free_all_source_wins_content): Update.
3735
3736 2019-06-25  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-wingeneral.c (tui_win_info::refresh)
3739         (tui_source_window_base::refresh): New methods.
3740         (tui_refresh_all): Call the refresh method.
3741         * tui/tui-data.h (struct tui_win_info)
3742         (struct tui_source_window_base) <refresh>: New method.
3743
3744 2019-06-25  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui.h (tui_is_window_visible): Return bool.
3747         * tui/tui.c (tui_is_window_visible): Return bool.
3748         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3749         (tui_make_visible, tui_make_invisible)
3750         (tui_win_info::make_visible)
3751         (tui_source_window_base::make_visible, make_all_visible)
3752         (tui_make_all_visible, tui_make_all_invisible): Update.
3753         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3754         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3755         bool.
3756         (struct tui_win_info, struct tui_source_window_base)
3757         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3758         * tui/tui-data.c (tui_init_generic_part): Update.
3759
3760 2019-06-25  Tom Tromey  <tom@tromey.com>
3761
3762         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3763         (tui_source_window_base::make_visible): New methods.
3764         (make_all_visible): Make method call.
3765         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3766         (struct tui_source_window_base, struct tui_cmd_window): Override
3767         make_visible.
3768         (tui_win_is_source_type): Don't declare.
3769         * tui/tui-data.c (tui_win_is_source_type): Remove.
3770
3771 2019-06-25  Tom Tromey  <tom@tromey.com>
3772
3773         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3774         NULL check.
3775
3776 2019-06-25  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3779         Inline constructor.  Add initializers for members.
3780         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3781         constructors; now inline in class.
3782
3783 2019-06-25  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-regs.c (tui_show_registers): Update.
3786         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3787         bool.
3788         * tui/tui-data.c (tui_data_window::clear_detail)
3789         (tui_data_window): Update.
3790
3791 2019-06-25  Tom Tromey  <tom@tromey.com>
3792
3793         * tui/tui-windata.c (tui_display_all_data)
3794         (tui_display_data_from_line, tui_display_data_from)
3795         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3796         Update.
3797         * tui/tui-regs.c (tui_last_regs_line_no)
3798         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3799         (tui_show_registers, tui_show_register_group)
3800         (tui_display_registers_from, tui_display_reg_element_at_line)
3801         (tui_display_registers_from_line, tui_check_register_values)
3802         (tui_reg_next, tui_reg_prev): Update.
3803         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3804         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3805         tui_data_window.
3806         (struct tui_win_info) <detail>: Remove.  Add new fields from
3807         tui_data_info.
3808         (TUI_DATA_WIN): Add cast.
3809         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3810         (~tui_data_window): Simplify.
3811
3812 2019-06-25  Tom Tromey  <tom@tromey.com>
3813
3814         * tui/tui-layout.c (show_source_disasm_command)
3815         (show_source_or_disasm_and_command): Update.
3816         * tui/tui-io.c (update_cmdwin_start_line)
3817         (tui_redisplay_readline): Update.
3818         * tui/tui-data.h (struct tui_command_info): Remove.
3819         (struct tui_win_info) <detail>: Remove command_info member.
3820         (struct tui_data_window) <start_line>: New member, from
3821         tui_command_info.
3822         (TUI_CMD_WIN): Add casts.
3823
3824 2019-06-25  Tom Tromey  <tom@tromey.com>
3825
3826         * tui/tui-winsource.c (tui_update_source_window)
3827         (tui_refill_source_window)
3828         (tui_source_window_base::do_scroll_horizontal)
3829         (tui_update_breakpoint_info, tui_set_exec_info_content)
3830         (tui_show_exec_info_content, tui_erase_exec_info_content)
3831         (tui_clear_exec_info_content): Update.
3832         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3833         Update.
3834         * tui/tui-win.c (make_invisible_and_set_new_height)
3835         (make_visible_with_new_height): Update.
3836         * tui/tui-source.c (tui_set_source_content)
3837         (tui_show_symtab_source): Update.
3838         * tui/tui-layout.c (extract_display_start_addr)
3839         (show_source_disasm_command, show_data)
3840         (make_source_or_disasm_window)
3841         (show_source_or_disasm_and_command): Update.
3842         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3843         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3844         "gdbarch".
3845         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3846         to tui_source_window_base.
3847         (struct tui_win_info) <detail>: Remove source_info member.
3848         (struct tui_source_window_base) <has_locator>: Inline.
3849         Move contents from tui_source_info; rename has_locator member to
3850         m_has_locator.
3851         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3852         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3853         header file.
3854         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3855         Simplify.
3856         (tui_free_all_source_wins_content): Cast to
3857         tui_source_window_base.
3858
3859 2019-06-25  Tom Tromey  <tom@tromey.com>
3860
3861         * tui/tui-win.c (make_invisible_and_set_new_height)
3862         (make_visible_with_new_height): Call has_locator method.
3863         * tui/tui-layout.c (show_source_disasm_command, show_data)
3864         (show_source_or_disasm_and_command): Update for bool change.
3865         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3866         (tui_win_info) <has_locator>: New method.
3867         (struct tui_source_window_base) <has_locator>: New method.
3868         (tui_win_has_locator): Don't declare.
3869         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3870         from tui_win_has_locator.
3871         (tui_source_window_base): Use false, not FALSE.
3872
3873 2019-06-25  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3876         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3877         clear_detail method directly.
3878         (tui_clear_win_detail): Remove.
3879
3880 2019-06-25  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3883         "this", not TUI_DISASM_WIN.
3884
3885 2019-06-25  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3888         declare.
3889         * tui/tui-winsource.c
3890         (tui_source_window_base::do_scroll_horizontal): Rename from
3891         tui_horizontal_source_scroll.
3892         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3893         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3894         from tui_vertical_data_scroll.
3895         * tui/tui-win.h (tui_scroll): Don't declare.
3896         * tui/tui-win.c (tui_win_info::forward_scroll)
3897         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3898         (tui_win_info::right_scroll): Rename and update.
3899         (tui_scroll_forward_command, tui_scroll_backward_command)
3900         (tui_scroll_left_command, tui_scroll_right_command): Update.
3901         (tui_scroll): Remove.
3902         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3903         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3904         from tui_vertical_source_scroll.
3905         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3906         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3907         from tui_vertical_disassem_scroll.
3908         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3909         do_scroll_horizontal>: New methods.
3910         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3911         Likewise.
3912         (struct tui_source_window_base): Add do_scroll_horizontal.
3913         (struct tui_source_window, struct tui_disasm_window): Add
3914         do_scroll_vertical.
3915         (struct tui_data_window, struct tui_cmd_window): Add
3916         do_scroll_horizontal and do_scroll_vertical.
3917         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-data.h (struct tui_source_window_base): New struct.
3922         (struct tui_source_window): Derive from tui_source_window_base.
3923         (struct tui_disasm_window): New struct.
3924         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3925         from tui_source_window::clear_detail.
3926         (tui_source_window_base): Rename from tui_source_window.
3927         (~tui_source_window_base): Rename from ~tui_source_window.
3928         (tui_alloc_win_info): Create a tui_disasm_window.
3929
3930 2019-06-25  Tom Tromey  <tom@tromey.com>
3931
3932         * tui/tui-data.h (struct tui_source_window)
3933         (struct tui_data_window): Declare destructors.
3934         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3935         destructors.
3936         (tui_win_info): Simplify.
3937
3938 2019-06-25  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-winsource.c (tui_display_main)
3941         (tui_update_source_windows_with_addr)
3942         (tui_update_all_breakpoint_info): Update.
3943         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3944         (new_height_ok, parse_scrolling_args): Update.
3945         * tui/tui-stack.c (tui_show_frame_info): Update.
3946         * tui/tui-data.h (struct tui_list): Remove.
3947         (tui_source_windows): Return a reference to a std::vector.
3948         * tui/tui-data.c (source_windows): Now a std::vector.
3949         (tui_source_windows): Change return type.
3950         (tui_clear_source_windows): Rewrite.
3951         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3952         (tui_free_all_source_wins_content): Rewrite.
3953
3954 2019-06-25  Tom Tromey  <tom@tromey.com>
3955
3956         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3957         (struct tui_data_window, struct tui_cmd_window): Declare
3958         clear_detail method.
3959         * tui/tui-data.c (tui_source_window::clear_detail)
3960         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3961         methods.
3962         (tui_clear_win_detail): Simplify.
3963
3964 2019-06-25  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-layout.c (make_source_window, make_disasm_window)
3967         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3968         Return the new window.
3969         (show_source_disasm_command, show_data)
3970         (show_source_or_disasm_and_command): Update.
3971
3972 2019-06-25  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3975         parameter.  Return the new window.
3976         (show_source_disasm_command): Update and remove NULL check.
3977         (show_source_or_disasm_and_command): Update.
3978
3979 2019-06-25  Tom Tromey  <tom@tromey.com>
3980
3981         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3982
3983 2019-06-25  Tom Tromey  <tom@tromey.com>
3984
3985         * tui/tui-data.h (struct tui_win_info): Make constructor
3986         protected.  Make destructor virtual.  Add initializers.
3987         (tui_source_window, tui_data_window, tui_cmd_window): New
3988         classes.
3989         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3990         constructor.  Add "type" parameter.
3991         (tui_source_window, tui_data_window, tui_cmd_window): New
3992         constructors.
3993         (tui_alloc_win_info): Instantiate the appropriate subclass.
3994
3995 2019-06-25  Tom Tromey  <tom@tromey.com>
3996
3997         * tui/tui-win.c (tui_resize_all): Use delete.
3998         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3999         destructor.
4000         (tui_free_window): Don't declare.
4001         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4002         Update.
4003
4004 2019-06-25  Tom Tromey  <tom@tromey.com>
4005
4006         * tui/tui-data.h (struct tui_win_info): Add constructor.
4007         * tui/tui-data.c (tui_alloc_win_info): Use new.
4008         (tui_free_window): Use delete.
4009
4010 2019-06-22  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4013         declare.
4014         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4015
4016 2019-06-22  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4019         declare.
4020         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4021
4022 2019-06-22  Tom de Vries  <tdevries@suse.de>
4023
4024         * dwarf2read.c (create_addrmap_from_aranges)
4025         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4026         instead of '%zu'.
4027
4028 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4029
4030         * dwarf2read.h (dwarf2_section_info_def): Remove.
4031         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4032         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4033         std::vector<dwarf2_section_info>.
4034         (struct dwo_file) <~dwo_file>: Remove.
4035         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4036         types field.
4037         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4038         (dwarf2_read_debug_names): Likewise.
4039         (create_debug_types_hash_table): Change parameter type to
4040         array_view, adjust code accordingly.
4041         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4042         (partial_die_info::fixup): Likewise.
4043         (determine_prefix): Likewise.
4044         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4045
4046 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4047
4048         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4049         gdb_bfd_ref_ptr.
4050         <~dwo_file>: Remove call to gdb_bfd_unref.
4051         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4052         gdb_bfd_ref_ptr::get.
4053
4054 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4055
4056         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4057         type to htab_up.
4058         * dwarf2read.c (struct dwo_file): Initialize fields.
4059         <~dwo_file>: New.
4060         (free_dwo_file): Remove, move content to ~dwo_file.
4061         (struct dwo_file_deleter): Remove.
4062         (dwo_file_up>: Remove custom deleter.
4063         (free_dwo_files): Remove.
4064         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4065         dwo_files.
4066         (process_skeletonless_type_units): Call unique_ptr::get.
4067         (allocate_dwo_file_hash_table): Add deleter to created hash
4068         table.  Change return type to htab_up.
4069         (lookup_dwo_file_slot): Don't memset dwo_file, call
4070         unique_ptr::get.
4071         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4072         (create_dwo_unit_in_dwp_v2): Likewise.
4073         (open_and_init_dwo_file): Likewise.
4074         (free_dwo_file_from_slot): Remove.
4075
4076 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4077
4078         * dwarf2read.h (struct dwarf2_section_info) <readin,
4079         is_virtual>: Change type to bool.
4080         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4081         true instead of 1.
4082
4083 2019-06-19  Tom Tromey  <tom@tromey.com>
4084
4085         * tui/tui-data.h (tui_init_content_element): Don't declare.
4086
4087 2019-06-19  Tom Tromey  <tom@tromey.com>
4088
4089         * tui/tui-data.h (tui_init_win_info): Don't declare.
4090
4091 2019-06-19  Tom de Vries  <tdevries@suse.de>
4092
4093         * dwarf2read.h (abstract_to_concrete): Change type to
4094         std::unordered_map<sect_offset, std::vector<sect_offset>,
4095         gdb::hash_enum<sect_offset>>.
4096
4097 2019-06-19  Tom Tromey  <tromey@adacore.com>
4098
4099         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4100         EVAL_AVOID_SIDE_EFFECTS specially.
4101
4102 2019-06-19  Tom Tromey  <tromey@adacore.com>
4103
4104         * source-cache.c (highlighter): New global.
4105         (source_cache::get_source_lines): Create a highlighter on demand.
4106
4107 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * defs.h (deprecated_interactive_hook): Delete declaration.
4110         * interps.c (clear_interpreter_hooks): Remove use of
4111         deprecated_interactive_hook.
4112         * top.c (deprecated_interactive_hook): Delete definition.
4113         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4114
4115 2019-06-18  Tom de Vries  <tdevries@suse.de>
4116
4117         PR gdb/24515
4118         * dwarf2read.h (abstract_to_concrete): Change type from
4119         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4120         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4121         * dwarf2read.c (read_variable): Update.
4122         (dwarf2_fetch_die_loc_sect_off): Update.
4123
4124 2019-06-17  Tom de Vries  <tdevries@suse.de>
4125
4126         PR gdb/24617
4127         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4128         accessing parent[parent_len - 1].
4129
4130 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4131
4132         PR gdb/24364
4133         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4134         call dtrace_process_dof with NULL dof.
4135
4136 2019-06-16  Tom de Vries  <tdevries@suse.de>
4137
4138         PR gdb/24445
4139         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4140
4141 2019-06-16  Tom Tromey  <tom@tromey.com>
4142
4143         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4144         (make_all_visible): Use address of member.
4145
4146 2019-06-16  Tom Tromey  <tom@tromey.com>
4147
4148         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4149         (tui_free_window, free_content, free_content_elements): Remove
4150         unnecessary cast.
4151         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4152         cast.
4153         * tui/tui-regs.c (tui_show_register_group)
4154         (tui_display_registers_from, tui_display_reg_element_at_line):
4155         Remove unnecessary cast.
4156
4157 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * linux-nat.c (normal_mask): Delete.
4160         (_initialize_linux_nat): Don't initialise normal_mask.
4161
4162 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4163
4164         PR gdb/24445
4165         * dwarf-index-write.h (write_psymtabs_to_index): Add
4166         dwz_basename parameter.
4167         * dwarf-index-write.c (write_gdbindex): Move file writing to
4168         write_gdbindex_1.  Change return type void.
4169         (assert_file_size): Move up, remove filename parameter.
4170         (write_gdbindex_1): New function.
4171         (write_debug_names): Change return type to void, call
4172         assert_file_size.
4173         (struct index_wip_file): New struct.
4174         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4175         file logic to index_wip_file.  Write index for dwz file if
4176         needed.
4177         (save_gdb_index_command): Pass basename of dwz file, if present.
4178         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4179         build-id of dwz file, if present.
4180         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4181         (dwarf2_get_dwz_file): Likewise.
4182         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4183         (dwarf2_get_dwz_file): Likewise.
4184
4185 2019-06-16  Tom Tromey  <tom@tromey.com>
4186
4187         * coffread.c (process_coff_symbol): Use xstrdup.
4188         * value.c (create_internalvar): Use xstrdup.
4189
4190 2019-06-16  Tom Tromey  <tom@tromey.com>
4191
4192         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4193         * breakpoint.c (stopin_command, stopat_command)
4194         (until_break_command, decode_location_default): Remove unnecessary
4195         cast.
4196         * utils.c (subset_compare): Remove unnecessary cast.
4197         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4198         cast.
4199         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4200         cast.
4201         * infcmd.c (path_command): Remove unnecessary cast.
4202         * coffread.c (decode_type): Remove unnecessary cast.
4203         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4204         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4205         * tui/tui-stack.c (tui_show_locator_content)
4206         (tui_show_frame_info): Remove unnecessary cast.
4207         * tui/tui-win.c (tui_scroll_forward_command)
4208         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4209         (parse_scrolling_args): Remove unnecessary cast.
4210         * tui/tui-data.c (init_win_info, tui_del_window)
4211         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4212         (free_content_elements): Remove unnecessary cast.
4213         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4214         unnecessary cast.
4215         * tui/tui-source.c (tui_set_source_content)
4216         (tui_vertical_source_scroll): Remove unnecessary cast.
4217         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4218         cast.
4219         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4220         * tui/tui-regs.c (tui_display_registers_from)
4221         (tui_display_register): Remove unnecessary cast.
4222         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4223         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4224         (make_visible): Remove unnecessary cast.
4225         * tui/tui-winsource.c (tui_erase_source_content)
4226         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4227         unnecessary cast.
4228         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4229         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4230         * stabsread.c (read_type, read_array_type, read_range_type):
4231         Remove unnecessary cast.
4232         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4233         (parse_symbol, parse_type, upgrade_type, parse_external)
4234         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4235         unnecessary cast.
4236         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4237
4238 2019-06-16  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-data.c (tui_alloc_generic_win_info)
4241         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4242         checks.
4243
4244 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4245             Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * f-typeprint.c (f_print_type): Don't return early for not
4248         associated or not allocated types.
4249         (f_type_print_varspec_suffix): Add print_rank parameter and print
4250         ranks of array types in case they dangling.
4251         (f_type_print_base): Add print_rank parameter.
4252
4253 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4254
4255         * NEWS: Mention new MI commands.
4256         * break-catch-throw.c (enum exception_event_kind): Move to
4257         breakpoint.h.
4258         (print_mention_exception_catchpoint): Output text as a single
4259         message.
4260         (catch_exception_command_1): Rename to...
4261         (catch_exception_event): ...this, make non-static, update header
4262         command, and change some parameter types.
4263         (catch_catch_command): Update for changes to
4264         catch_exception_command_1.
4265         (catch_throw_command): Likewise.
4266         (catch_rethrow_command): Likewise.
4267         * breakpoint.c (enum exception_event_kind): Delete.
4268         * breakpoint.h (enum exception_event_kind): Moved here from
4269         break-catch-throw.c.
4270         (catch_exception_event): Declare.
4271         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4272         (mi_cmd_catch_throw): New function.
4273         (mi_cmd_catch_rethrow): New function.
4274         (mi_cmd_catch_catch): New function.
4275         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4276         'catch-catch' entries.
4277         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4278         (mi_cmd_catch_rethrow): Declare.
4279         (mi_cmd_catch_catch): Declare.
4280
4281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4282
4283         * annotate.c (annotate_source_line): Change return type to void,
4284         update implementation to match.
4285         * annotate.h (annotate_source_line): Change return type to void,
4286         update header comment.
4287         * stack.c (print_frame_info): Don't change what frame information
4288         is printed based on whether annotations are on or not.
4289
4290 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4293         (annotate_source): Make static.
4294         (annotate_source_line): Moved from source.c and renamed from
4295         identify_source_line.  Update the return type.
4296         * annotate.h (annotate_source): Delete declaration.
4297         (annotate_source_line): Declaration moved from source.h, and
4298         renamed from identify_source_line.  Return type updated.
4299         * source.c (identify_source_line): Moved to annotate.c and renamed
4300         to annotate_source_line.
4301         (info_line_command): Remove check of annotation_level.
4302         * source.h (identify_source_line): Move declaration to annotate.h
4303         and rename to annotate_source_line.
4304         * stack.c: Add 'annotate.h' include.
4305         (print_frame_info): Remove check of annotation_level before
4306         calling annotate_source_line.
4307
4308 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4309
4310         * source-cache.c (source_cache::get_plain_source_lines): Use
4311         open_source_file_with_line_charpos instead of just
4312         open_source_file, remove call to find_source_lines.
4313         (source_cache::get_source_lines): Likewise.
4314         * source.c (find_source_lines): Make static.
4315         (get_filename_and_charpos): Renamed into...
4316         (open_source_file_with_line_charpos): ..this along with changes to
4317         return a scoped_fd, and some other minor clean ups.
4318         (identify_source_line): Use open_source_file_with_line_charpos.
4319         (search_command_helper): Use open_source_file_with_line_charpos
4320         instead of just open_source_file, remove call to
4321         find_source_lines.
4322         * source.h (open_source_file_with_line_charpos): Declare new
4323         function.
4324         (find_source_lines): Delete declaration.
4325
4326 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4327
4328         * source.c (get_filename_and_charpos): Remove fullname
4329         parameter.
4330         (identify_source_line): Update call to get_filename_and_charpos.
4331
4332 2019-06-14  Tom Tromey  <tromey@adacore.com>
4333
4334         PR gdb/24502:
4335         * ui-style.h (skip_ansi_escape): Update comment.
4336         * ui-file.h (class no_terminal_escape_file): New class.
4337         * ui-file.c (no_terminal_escape_file::write)
4338         (no_terminal_escape_file::puts): New methods.
4339         * cli/cli-logging.c (handle_redirections): Use
4340         no_terminal_escape_file.
4341
4342 2019-06-14  Tom Tromey  <tromey@adacore.com>
4343
4344         * NEWS: Move convenience variable news above Python news.
4345
4346 2019-06-14  Tom Tromey  <tom@tromey.com>
4347
4348         * gnulib: Move directory to top-level.
4349         * configure.ac: Don't configure gnulib.
4350         * configure: Rebuild.
4351         * common/common-defs.h: Use new path to gnulib.
4352         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4353         (GNULIB_H): Remove.
4354         (INCGNU): Look in new gnulib location.
4355         (HFILES_NO_SRCDIR): Remove gnulib files.
4356         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4357         (generated_files): Remove GNULIB_H.
4358         ($(LIBGNU), all-lib): Remove targets.
4359         (distclean): Don't mention GNULIB_BUILDDIR.
4360         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4361
4362 2019-06-14  Tom Tromey  <tromey@adacore.com>
4363
4364         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4365         Warn if symbol file does not provide any symbols.
4366
4367 2019-06-14  Tom Tromey  <tromey@adacore.com>
4368
4369         * source.c (find_and_open_source): Respect basenames_may_differ.
4370
4371 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4372
4373         * annotate.c (annotate_breakpoints_invalid): Make use of
4374         scoped_restore_terminal_state.
4375         (annotate_frames_invalid): Likewise.
4376
4377 2019-06-14  Tom Tromey  <tromey@adacore.com>
4378
4379         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4380         allow assignment to an internalvar.
4381
4382 2019-06-14  Tom Tromey  <tromey@adacore.com>
4383
4384         * ada-lex.l: Allow "_" in attribute names.
4385
4386 2019-06-14  Tom Tromey  <tromey@adacore.com>
4387
4388         PR gdb/24653:
4389         * regcache.c (registers_changed): Don't call alloca.
4390         * top.c (execute_command): Don't call alloca.
4391
4392 2019-06-13  Pedro Alves  <palves@redhat.com>
4393
4394         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4395         'expression'.  When parsing an expression, error out if there's
4396         junk after "unlimited".
4397         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4398         (do_set_command): Adjust calls to is_unlimited_literal.
4399
4400 2019-06-13  Pedro Alves  <palves@redhat.com>
4401
4402         * compile/compile.c (make_compile_options_def_group): Add braces
4403         around array_view initializer.
4404         * thread.c (make_thread_apply_all_options_def_group)
4405         (make_thread_apply_all_options_def_group): Likewise.
4406
4407 2019-06-13  Pedro Alves  <palves@redhat.com>
4408
4409         * NEWS (New commands): Mention "maint test-options
4410         require-delimiter", "maint test-options unknown-is-error", "maint
4411         test-options unknown-is-operand" and "maint show
4412         test-options-completion-result".
4413         (New command options, command completion): New section.
4414         (Completion improvements): New section.
4415         Mention that you can abbreviate "unlimited".
4416
4417 2019-06-13  Pedro Alves  <palves@redhat.com>
4418
4419         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4420         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4421         * unittests/cli-utils-selftests.c (test_parse_flags)
4422         (test_parse_flags_qcs): Delete.
4423         (test_cli_utils): Don't call deleted functions.
4424
4425 2019-06-13  Pedro Alves  <palves@redhat.com>
4426
4427         * thread.c: Include "cli/cli-option.h".
4428         (tp_array_compar_ascending): Global.
4429         (tp_array_compar): Delete function.
4430         (tp_array_compar_ascending, tp_array_compar_descending): New
4431         functions.
4432         (ascending_option_def, qcs_flag_option_def)
4433         (thr_qcs_flags_option_defs)
4434         (make_thread_apply_all_options_def_group)
4435         (make_thread_apply_options_def_group): New.
4436         (thread_apply_all_command): Use gdb::option::process_options.
4437         (thread_apply_command_completer)
4438         (thread_apply_all_command_completer): New.
4439         (thread_apply_command): Use gdb::option::process_options.
4440         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4441         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4442         to generate help text of "thread apply".  Adjust "taas"'s help.
4443         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4444         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4445
4446 2019-06-13  Pedro Alves  <palves@redhat.com>
4447
4448         * thread.c (thread_apply_command): Check for invalid TID with
4449         isdigit instead of !isalpha.
4450
4451 2019-06-13  Pedro Alves  <palves@redhat.com>
4452
4453         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4454         (validate_flags_qcs): New.
4455         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4456         (validate_flags_qcs): Declare.
4457         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4458         (make_frame_apply_options_def_group): New.
4459         (frame_apply_command_count): Process options with
4460         gdb::option::process_options.
4461         (frame_apply_completer): New.
4462         (frame_apply_level_completer, frame_apply_all_completer)
4463         (frame_apply_completer): New.
4464         (_initialize_stack): Update help of "frame apply", "frame apply
4465         level", "frame apply all" and "faas" to mention supported options
4466         and install command completers.
4467         * stack.h (frame_apply_all_completer): Declare.
4468         * thread.c: Include "stack.h".
4469         (tfaas_command): Add "--".
4470         (_initialize_thread): Update help "tfaas" to mention supported
4471         options and install command completer.
4472
4473 2019-06-13  Pedro Alves  <palves@redhat.com>
4474
4475         * completer.c (complete_nested_command_line): New.
4476         (gdb_completion_word_break_characters_throw): Add assertion.
4477         * completer.h (complete_nested_command_line): Declare.
4478
4479 2019-06-13  Pedro Alves  <palves@redhat.com>
4480
4481         * stack.c (parse_backtrace_qualifiers): New.
4482         (backtrace_command): Use it.
4483         (backtrace_command_completer): Complete on qualifiers.
4484
4485 2019-06-13  Pedro Alves  <palves@redhat.com>
4486
4487         * frame.c: Include "cli/cli-option.h.
4488         (user_set_backtrace_options): New.
4489         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4490         Delete.
4491         (get_prev_frame): Adjust.
4492         (boolean_option_def, uinteger_option_def)
4493         (set_backtrace_option_defs): New.
4494         (_initialize_frame): Adjust and use
4495         gdb::option::add_setshow_cmds_for_options to install "set
4496         backtrace past-main" and "set backtrace past-entry".
4497         * frame.h: Include "cli/cli-option.h".
4498         (struct frame_print_options): Forward declare.
4499         (print_frame_arguments_all, print_frame_arguments_scalars)
4500         (print_frame_arguments_none): Declare.
4501         (print_entry_values): Delete declaration.
4502         (struct frame_print_options, user_frame_print_options): New.
4503         (struct set_backtrace_options): New.
4504         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4505         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4506         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4507         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4508         (list_args_or_locals): Add frame_print_options parameter.
4509         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4510         * python/py-framefilter.c (enumerate_args): Pass down
4511         USER_FRAME_PRINT_OPTIONS.
4512         * stack.c: Include "cli/cli-option.h".
4513         (print_frame_arguments_all, print_frame_arguments_scalars)
4514         (print_frame_arguments_none): Declare.
4515         (print_raw_frame_arguments, print_entry_values): Delete.
4516         (user_frame_print_options): New.
4517         (boolean_option_def, enum_option_def, frame_print_option_defs):
4518         New.
4519         (struct backtrace_cmd_options): New.
4520         (bt_flag_option_def): New.
4521         (backtrace_command_option_defs): New.
4522         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4523         (print_frame_arg, read_frame_arg, print_frame_args)
4524         (print_frame_info, print_frame): Add frame_print_options parameter
4525         and use it.
4526         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4527         (backtrace_command_1): Add frame_print_options and
4528         backtrace_cmd_options parameters and use them.
4529         (make_backtrace_options_def_group): New.
4530         (backtrace_command): Process command options with
4531         gdb::option::process_options.
4532         (backtrace_command_completer): New.
4533         (_initialize_stack): Extend "backtrace"'s help to mention
4534         supported options.  Install completer for "backtrace".
4535         Install some settings commands with add_setshow_cmds_for_options.
4536
4537 2019-06-13  Pedro Alves  <palves@redhat.com>
4538
4539         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4540         and that "set/show print raw frame-arguments" are now deprecated.
4541
4542         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4543         command.
4544         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4545         * stack.c (_initialize_stack): Install "set/show print
4546         raw-frame-arguments", and deprecate "set/show print raw
4547         frame-arguments".
4548         * valprint.c (_initialize_valprint): Deprecate "set/show print
4549         raw".
4550
4551 2019-06-13  Pedro Alves  <palves@redhat.com>
4552
4553         * compile/compile.c (struct compile_options): New.
4554         (compile_flag_option_def, compile_command_option_defs)
4555         (make_compile_options_def_group): New.
4556         (compile_file_command): Handle options with
4557         gdb::option::process_options.
4558         (compile_file_command_completer): New function.
4559         (compile_code_command): Handle options with
4560         gdb::option::process_options.
4561         (compile_code_command_completer): New function.
4562         (_initialize_compiler): Install completers for "compile code" and
4563         "compile file".  Mention available options in "compile code" and
4564         "compile code"'s help.
4565         * completer.c (advance_to_completion_word): New, factored out from
4566         ...
4567         (advance_to_expression_complete_word_point): ... this.
4568         (advance_to_filename_complete_word_point): New.
4569         * completer.h (advance_to_filename_complete_word_point): New
4570         declaration.
4571
4572 2019-06-13  Pedro Alves  <palves@redhat.com>
4573
4574         * compile/compile.c: Include "cli/cli-option.h".
4575         (compile_print_value): Scope data pointer is now a
4576         value_print_options pointer; adjust.
4577         (compile_print_command): Process options.  Scope data pointer is
4578         now a value_print_options pointer; adjust.
4579         (_initialize_compile): Update "compile print"'s help to include
4580         supported options.  Install a completer for "compile print".
4581         * cp-valprint.c (show_vtblprint, show_objectprint)
4582         (show_static_field_print): Delete.
4583         (_initialize_cp_valprint): Don't install "set print
4584         static-members", "set print vtbl", "set print object" here.
4585         * printcmd.c: Include "cli/cli-option.h" and
4586         "common/gdb_optional.h".
4587         (print_command_parse_format): Rework to fill in a
4588         value_print_options instead of a format_data.
4589         (print_value): Change parameter type from format_data pointer to
4590         value_print_options reference.  Adjust.
4591         (print_command_1): Process options.  Adjust to pass down a
4592         value_print_options.
4593         (print_command_completer): New.
4594         (_initialize_printcmd): Install print_command_completer as
4595         handle_brkchars completer for the "print" command.  Update
4596         "print"'s help to include supported options.
4597         * valprint.c: Include "cli/cli-option.h".
4598         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4599         here from cp-valprint.c.
4600         (boolean_option_def, uinteger_option_def)
4601         (value_print_option_defs, make_value_print_options_def_group):
4602         New.  Use gdb::option::add_setshow_cmds_for_options to install
4603         "set print elements", "set print null-stop", "set print repeats",
4604         "set print pretty", "set print union", "set print array", "set
4605         print address", "set print symbol", "set print array-indexes".
4606         * valprint.h: Include <string> and "cli/cli-option.h".
4607         (make_value_print_options_def_group): Declare.
4608         (print_value): Change parameter type from format_data pointer to
4609         value_print_options reference.
4610         (print_command_completer): Declare.
4611
4612 2019-06-13  Pedro Alves  <palves@redhat.com>
4613
4614         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4615         (COMMON_SFILES): Add maint-test-settings.c.
4616         * cli/cli-decode.c (boolean_enums): New global, factored out from
4617         ...
4618         (add_setshow_boolean_cmd): ... here.
4619         * cli/cli-decode.h (boolean_enums): Declare.
4620         * cli/cli-option.c: New file.
4621         * cli/cli-option.h: New file.
4622         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4623         factored out from ...
4624         (parse_cli_boolean_value(const char *)): ... this.
4625         (is_unlimited_literal): Change parameter type to pointer to
4626         pointer.  Adjust and advance ARG pointer.
4627         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4628         (parse_cli_var_enum): New, factored out from ...
4629         (do_set_command): ... this.  Adjust.
4630         * cli/cli-setshow.h (parse_cli_boolean_value)
4631         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4632         (parse_cli_var_enum): Declare.
4633         * cli/cli-utils.c: Include "cli/cli-option.h".
4634         (get_ulongest): New.
4635         * cli/cli-utils.h (get_ulongest): Declare.
4636         (check_for_argument): New overloads.
4637         * maint-test-options.c: New file.
4638
4639 2019-06-13  Pedro Alves  <palves@redhat.com>
4640
4641         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4642         parse a range if "-" is at the end of the string.
4643
4644 2019-06-13  Pedro Alves  <palves@redhat.com>
4645
4646         * cli/cli-setshow.c (parse_auto_binary_operation)
4647         (parse_cli_boolean_value): Don't allow "o".
4648
4649 2019-06-13  Pedro Alves  <palves@redhat.com>
4650
4651         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4652         * NEWS: Mention maint test-settings KIND.
4653         * maint-test-settings.c: New file.
4654
4655 2019-06-13  Pedro Alves  <palves@redhat.com>
4656
4657         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4658         completer.
4659         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4660         "set" completers.
4661
4662 2019-06-13  Pedro Alves  <palves@redhat.com>
4663
4664         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4665         after item.
4666
4667 2019-06-13  Pedro Alves  <palves@redhat.com>
4668
4669         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4670
4671 2019-06-13  Pedro Alves <palves@redhat.com>
4672
4673         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4674         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4675         call.
4676         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4677         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4678         calls.
4679         (check_for_argument): Skip spaces after argument.
4680
4681 2019-06-13  Pedro Alves  <palves@redhat.com>
4682
4683         * thread.c (thread_apply_command): Adjust TID parsing.
4684         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4685         detected before end of string.
4686         (tid_is_in_list): Error out if LIST is invalid.
4687
4688 2019-06-13  Pedro Alves  <palves@redhat.com>
4689
4690         * completer.c (complete_line_internal_1): Rewind completion word
4691         point.
4692         (completion_tracker::advance_custom_word_point_by): Change
4693         parameter type to int.
4694         * completer.h (completion_tracker::advance_custom_word_point_by):
4695         Likewise.
4696
4697 2019-06-13  Pedro Alves  <palves@redhat.com>
4698
4699         * completer.c (advance_to_completion_word): Handle delimiters.
4700
4701 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4702
4703         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4704
4705 2019-06-11  Tom Tromey  <tom@tromey.com>
4706
4707         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4708         (xmalloc_failed): Move to alloc.c.
4709         * alloc.c: New file.
4710         * Makefile.in (COMMON_SFILES): Add alloc.c.
4711
4712 2019-06-11  Tom Tromey  <tom@tromey.com>
4713
4714         * nat/linux-waitpid.c: Don't include server.h.
4715         (linux_debug): Remove.
4716         (my_waitpid): Update.
4717
4718 2019-06-11  Tom Tromey  <tromey@adacore.com>
4719
4720         * infcall.c (_initialize_infcall): Remove trailing newline from
4721         help.
4722         * user-regs.c (_initialize_user_regs): Remove trailing newline
4723         from help.
4724         * typeprint.c (_initialize_typeprint): Remove trailing newline
4725         from help.
4726         * reverse.c (_initialize_reverse): Remove trailing newlines from
4727         help.
4728         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4729         from help.
4730         * language.c (add_set_language_command): Remove trailing newline
4731         from help.
4732         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4733         help.
4734         * disasm.c (_initialize_disasm): Remove trailing newline from
4735         help.
4736         * top.c (init_main): Remove trailing newline from help.
4737         * interps.c (_initialize_interpreter): Remove trailing newline
4738         from help.
4739         * btrace.c (_initialize_btrace): Remove trailing newlines from
4740         help.
4741         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4742         from help.
4743         * python/python.c (_initialize_python): Remove trailing newline
4744         from help.
4745         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4746         help.
4747         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4748         from help.  Reformat some text.
4749         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4750         from help.
4751         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4752         newline from help.
4753
4754 2019-06-11  Tom Tromey  <tromey@adacore.com>
4755
4756         * darwin-nat.c (darwin_decode_exception_message)
4757         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4758
4759 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4760
4761         * valops.c (value_slice): Check for not allocated or not
4762         associated values.
4763
4764 2019-06-10  Tom de Vries  <tdevries@suse.de>
4765
4766         PR gdb/24618
4767         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4768         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4769         invalid.
4770
4771 2019-06-10  Tom de Vries  <tdevries@suse.de>
4772
4773         PR gdb/24611
4774         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4775         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4776
4777 2019-06-10  Tom de Vries  <tdevries@suse.de>
4778
4779         PR symtab/24545
4780         * symtab.c (struct demangled_name_entry): Add language field.
4781         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4782         static minimal symbol".  Set and use language field.
4783
4784 2019-06-10  Tom Tromey  <tromey@adacore.com>
4785
4786         * ada-lang.c (_initialize_ada_language): Update help text.
4787
4788 2019-06-10  Tom Tromey  <tromey@adacore.com>
4789
4790         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4791         with a newline.
4792         * guile/guile.c (handle_boot_error): Don't end warning with a
4793         newline.
4794         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4795         warning with a newline.
4796         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4797         newline.
4798         (s12z_frame_cache): Likewise.
4799         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4800         a newline.
4801         * solib-svr4.c (disable_probes_interface): Don't end warning with
4802         a newline.
4803         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4804         newline.
4805         * python/python.c (do_finish_initialization): Don't end warning
4806         with a newline.
4807
4808 2019-06-10  Tom Tromey  <tom@tromey.com>
4809
4810         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4811         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4812         gdbpy_enter.
4813
4814 2019-06-10  Tom Tromey  <tromey@adacore.com>
4815
4816         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4817         data.
4818         (elf_new_init): Don't call stabsread_new_init.
4819         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4820         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4821         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4822
4823 2019-06-10  Tom de Vries  <tdevries@suse.de>
4824
4825         PR symtab/16264
4826         PR symtab/24517
4827         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4828
4829 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4830
4831         * source.c (find_and_open_source): Also rewrite relative file
4832         names.
4833
4834 2019-04-26  Amos Bird  <amosbird@gmail.com>
4835
4836         * annotate.c (annotate_thread_exited): Add "thread-exited"
4837         annotation.
4838
4839 2019-06-06  Tom Tromey  <tromey@adacore.com>
4840
4841         * maint.h (class scoped_command_stats): Use
4842         DISABLE_COPY_AND_ASSIGN.
4843         <print_time>: New method.
4844         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4845         print_time.
4846         (scoped_command_stats::print_time): New method.
4847
4848 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4849
4850         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4851         instructions of lengths 6 or 8 bytes.
4852
4853 2019-06-04  Pedro Alves  <palves@redhat.com>
4854
4855         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4856
4857         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4858         * breakpoint.c (condition_completer): Likewise.
4859         * cli/cli-dump.c (scan_expression): Likewise.
4860         * common/filestuff.c (mkdir_recursive): Likewise.
4861         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4862         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4863         (gdb_abspath): Likewise.
4864         * compile/compile-cplus-types.c
4865         (compile_cplus_instance::decl_name): Likewise.
4866         * completer.c (complete_explicit_location):
4867         (signal_completer, reg_or_group_completer_1): Likewise.
4868         * cp-support.c (cp_remove_params_if_any): Likewise.
4869         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4870         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4871         * infcmd.c (strip_bg_char): Likewise.
4872         * linespec.c (copy_token_string): Likewise.
4873         * mi/mi-main.c (output_cores): Likewise.
4874         * psymtab.c (psymtab_search_name):
4875         * symfile.c (test_set_ext_lang_command): Likewise.
4876         * target.c (target_fileio_read_stralloc): Likewise.
4877         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4878         * value.c (complete_internalvar): Likewise.
4879
4880 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4881
4882         Add objfile property to gdb.Type.
4883         * NEWS: Mention Python API addition.
4884         * python/py-type.c (typy_get_objfile): New method.
4885
4886 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4887
4888         * NEWS: Mention the new set|show style [title|highlight].
4889         Mention changes to "show style", "help" and "apropos".
4890
4891 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4892
4893         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4894         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4895         instead of print_help_for_command.
4896         (print_doc_of_command): New function.
4897         (help_list): Add 'apropos -v word' suggestion.
4898         (print_help_for_command): Style the command name using title style.
4899         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4900         (_initialize_cli_cmds): Describe -v in apropos_command help.
4901
4902 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4903
4904         * cli/cli-style.h (cli_style_option): Add name in constructor,
4905         add m_name class member, add constructor with intensity,
4906         add name class function.
4907         (cli_style_option::add_setshow_commands): Remove name argument.
4908         (highlight_style, title_style): New styles.
4909         * cli/cli-style.c (do_show): New function that shows a style
4910         characteristic styling the style name with itself.
4911         (set_style_name): New function.
4912         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4913         Update all callers according to the changes in cli/cli-style.h.
4914         * utils.h (fputs_highlighted): New function.
4915         * utils.c (fputs_highlighted): Likewise.
4916
4917 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4918
4919         * NEWS: Mention new pipe command and new convenience variables.
4920
4921 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4922
4923         * cli/cli-cmds.c (pipe_command): New function.
4924         (_initialize_cli_cmds): Call add_com for pipe_command.
4925         Define | as an alias for pipe.
4926         (exit_status_set_internal_vars): New function.
4927         (shell_escape): Call exit_status_set_internal_vars.
4928         cli/cli-decode.c (find_command_name_length): Recognize | as
4929         a single character command.
4930
4931 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4932
4933         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4934         top.c (execute_command_to_ui_file): New function, mostly a copy
4935         of execute_command_to_string.
4936         (execute_command_to_string): Implement by calling
4937         execute_command_to_ui_file.
4938
4939 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4940
4941         * top.h (saved_command_line): Remove declaration.
4942         * top.c (previous_saved_command_line, previous_repeat_arguments):
4943         New variables.
4944         (saved_command_line): Make static, define together with other
4945         'repeat variables'.
4946         (dont_repeat): Clear repeat_arguments.
4947         (repeat_previous, get_saved_command_line, save_command_line):
4948         New functions.
4949         (gdb_init): Initialize saved_command_line
4950         and previous_saved_command_line.
4951         * main.c (captured_main_1): Remove saved_command_line initialization.
4952         * event-top.c (handle_line_of_input): Update to use
4953         the new 'repeat' related functions instead of direct access to
4954         saved_command_line.
4955         * command.h (repeat_previous, get_saved_command_line,
4956         save_command_line): New declarations.
4957         (dont_repeat): Add comment.
4958
4959 2019-05-30  Tom Tromey  <tromey@adacore.com>
4960
4961         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4962         Fix comment.
4963         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4964
4965 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4966
4967         PR cli/24587
4968         * completer.c (complete): Initialize variable word.
4969
4970 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4971
4972         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4973         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4974         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4975         'body' is NULL to the outter 'if', protecting the '!is_define'
4976         situation as well.
4977
4978 2019-05-29  Tom Tromey  <tromey@adacore.com>
4979
4980         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4981         (dwarf_unknown): New function.
4982         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4983         (dwarf_type_encoding_name): Use dwarf_unknown.
4984
4985 2019-05-29  Tom Tromey  <tromey@adacore.com>
4986
4987         PR c++/20020:
4988         * cp-valprint.c (cp_print_value_fields): Call
4989         cp_print_static_field inside "try".
4990
4991 2019-05-29  Tom Tromey  <tromey@adacore.com>
4992
4993         * inflow.c (struct terminal_info): Add default operator=.
4994         * configure: Rebuild.
4995         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4996         -Wdeprecated-copy-dtor, -Wredundant-move.
4997
4998 2019-05-29  Tom Tromey  <tromey@adacore.com>
4999
5000         * NEWS: Add entry.
5001         * infcmd.c (print_return_value_1): Handle finish_print
5002         option.
5003         (show_print_finish): New function.
5004         (_initialize_infcmd): Add "set/show print finish" commands.
5005         * valprint.c (user_print_options): Initialize new member.
5006         * valprint.h (struct value_print_options) <finish_print>: New
5007         member.
5008
5009 2019-05-28  Tom Tromey  <tromey@adacore.com>
5010
5011         * ada-lang.c (ada_remove_Xbn_suffix)
5012         (find_old_style_renaming_symbol)
5013         (parse_old_style_renaming): Remove.
5014         (ada_find_renaming_symbol): Don't call
5015         find_old_style_renaming_symbol.
5016         (ada_is_renaming_symbol): Rename from
5017         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5018         bool.  Now static.
5019         (ada_read_var_value): Update and simplify.
5020         * ada-exp.y (write_var_or_type): Remove old code.
5021
5022 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5023
5024         * event-top.c: Remove include comment.
5025         * inflow.c (class scoped_ignore_sigttou): Move from here...
5026         * inflow.h (class scoped_ignore_sigttou): ...to here.
5027         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5028         * top.c:  Remove include comment.
5029
5030 2019-05-27  Tom Tromey  <tom@tromey.com>
5031
5032         * NEWS: Fix typo.
5033
5034 2019-05-22  Tom Tromey  <tromey@adacore.com>
5035
5036         * target.c (target_follow_exec): Constify parameter.
5037         * target-delegates.c: Rebuild.
5038         * remote.c (remote_target::follow_exec): Constify parameter.
5039         * infrun.c (follow_exec): Constify parameter.
5040         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5041         (target_follow_exec): Likewise.
5042
5043 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5044
5045         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5046         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5047
5048 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5049
5050         * NEWS: Add debugredirect and testsuite sections.
5051
5052 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5053
5054         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5055         target descriptions using exclusively floating point register name
5056         aliases.
5057
5058 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         PR gdb/18644:
5061         * f-lang.c (build_fortran_types): Handle the case where
5062         gdbarch_floatformat_for_type returns a nullptr.
5063
5064 2019-05-21  Tom de Vries  <tdevries@suse.de>
5065
5066         PR cli/24587
5067         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5068
5069 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5070
5071         PR gdb/18644:
5072         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5073         16-byte floats.
5074         * i386-tdep.c (i386_floatformat_for_type): Use
5075         floatformats_ia64_quad for the 16-byte floating point component
5076         within a fortran 32-byte complex number.
5077
5078 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5079
5080         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5081         delete default constructor.
5082         (find_partial_die): Update to return const struct.
5083         (partial_die_parent_scope): Move variable declaration into scope
5084         of its use and change its type to auto.
5085         (guess_partial_die_structure_name): Likewise.
5086         (partial_die_info::fixup): Likewise.
5087
5088 2019-05-17  Tom Tromey  <tromey@adacore.com>
5089
5090         * source.c (find_and_open_source): Remove cast.
5091
5092 2019-05-17  Tom Tromey  <tromey@adacore.com>
5093
5094         * annotate.c (annotate_source): Make "filename" const.
5095         * annotate.h (annotate_source): Use const.
5096
5097 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5098
5099         * disasm.c (set_disassembler_options): Send errors to stderr.
5100
5101 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5102
5103         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5104         (cli_interp_base::set_logging): Check debug_redirect.
5105         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5106         * cli/cli-logging.c (debug_redirect): Add static variable.
5107         (pop_output_files): Add default param.
5108         (handle_redirections): Print debug setting.
5109         (show_logging_command): Likewise.
5110         (_initialize_cli_logging): Add debugredirect command.
5111         * interps.c (current_interp_set_logging): Add debug_redirect
5112         parameter.
5113         * interps.h (set_logging): Add debug_redirect parameter.
5114         (current_interp_set_logging): Likewise.
5115         * mi/mi-common.h: Likewise.
5116         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5117
5118 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5119             Tom Tromey  <tromey@adacore.com>
5120
5121         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5122         directly.
5123         * cli/cli-interp.h (make_logging_output): Remove declaration.
5124         * cli/cli-logging.c (make_logging_output): Remove function.
5125         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5126         directly.
5127         * ui-file.c (tee_file::tee_file): Remove bools.
5128         (tee_file::~tee_file): Remove deletes.
5129         * ui-file.h (tee_file): Remove bools.
5130
5131 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5132
5133         * mi/mi-cmds.h (mi_cmd_complete): New function.
5134         * mi/mi-main.c (mi_cmd_complete): Likewise.
5135         * mi/mi-cmds.c: Define new MI command -complete.
5136         * NEWS: Mention new -complete command.
5137
5138 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5139
5140         * completer.h (complete): New function.
5141         * completer.c (complete): Likewise.
5142         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5143         function defined in completer.h.
5144
5145 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5146
5147         * MAINTAINERS (Write After Approval): Add myself.
5148
5149 2019-05-17  Tom de Vries  <tdevries@suse.de>
5150
5151         PR gdb/24094
5152         * dwarf2read.c (struct cu_partial_die_info): New struct.
5153         (find_partial_die): Return cu_partial_die_info.
5154         (partial_die_parent_scope, guess_partial_die_structure_name)
5155         (partial_die_info::fixup): Handle new return type of find_partial_die.
5156
5157 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5158
5159         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5160         "std::string", simplifying the algorithm.
5161
5162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5163
5164         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5165         (stap_static_probe_ops::get_probes): Likewise.
5166
5167 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5168
5169         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5170         '-')" and "else if".
5171         (stap_parse_single_operand): Join checks for
5172         "gdbarch_stap_parse_special_token_p" and
5173         "gdbarch_stap_parse_special_token" in the same "if" statement.
5174         Invert check when verifying for operation on register
5175         displacement.
5176
5177 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5178
5179         * stap-probe.c (stap_get_opcode): Update comment.
5180         (stap_get_expected_argument_type): Likewise.
5181         (handle_stap_probe): Likewise.
5182
5183 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5184
5185         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5186         return type to 'bool'.  Adjust comment.  Use 'bool' when
5187         appropriate.
5188         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5189         * stap-probe.c (stap_parse_argument_1): Likewise.
5190         (stap_is_operator): Likewise.
5191         (stap_is_generic_prefix): Likewise.
5192         (stap_is_register_prefix): Likewise.
5193         (stap_is_register_indirection_prefix): Likewise.
5194         (stap_is_integer_prefix): Likewise.
5195         (stap_generic_check_suffix): Likewise.
5196         (stap_check_integer_suffix): Likewise.
5197         (stap_check_register_suffix): Likewise.
5198         (stap_check_register_indirection_suffix): Likewise.
5199         (stap_parse_register_operand): Likewise.
5200         (stap_parse_single_operand): Likewise.
5201         (stap_parse_argument_1): Likewise.
5202         (stap_probe::get_argument_count): Likewise.
5203         (stap_is_operator): Likewise.
5204
5205 2019-05-16  Tom Tromey  <tromey@adacore.com>
5206
5207         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5208         keyword to foreach.
5209
5210 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5211
5212         * linux-thread-db.c (try_thread_db_load_1): Change return type
5213         to bool.
5214         (try_thread_db_load): Likewise.
5215         (try_thread_db_load_from_pdir_1): Likewise.
5216         (try_thread_db_load_from_pdir): Likewise.
5217         (try_thread_db_load_from_sdir): Likewise.
5218         (try_thread_db_load_from_dir): Likewise.
5219         (thread_db_load_search): Likewise.
5220         (has_libpthread): Likewise.
5221         (thread_db_load): Likewise.
5222
5223 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5224
5225         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5226         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5227         NULL, and complain/return if that's the case.
5228
5229 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5230
5231         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5232         (advance, posn, abstract_read_memory): New functions.
5233         [struct mem_read_abstraction]: New struct.
5234         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5235
5236 2019-05-14  Tom Tromey  <tromey@adacore.com>
5237
5238         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5239         value is not lval_memory.
5240
5241 2019-05-14  Tom Tromey  <tromey@adacore.com>
5242
5243         * solib.c (info_sharedlibrary_command): Style the file name.
5244
5245 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5246
5247         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5248         (aarch64_vnv_type): Likewise.
5249         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5250         * common/tdesc.c: Likewise.
5251         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5252         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5253         * features/aarch64-fpu.xml: Add ieee half view.
5254         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5255         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5256         * gdbtypes.h (struct builtin_type): Likewise.
5257         (struct objfile_type): Likewise.
5258
5259 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5260
5261         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5262         typo.
5263         * location.h (string_to_event_location): Likewise.
5264
5265 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5266
5267         GDB 8.3 released.
5268
5269 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5270
5271         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5272         New variable declaration.
5273         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5274         New variable.
5275         (print_one_breakpoint): Use ui_out::test_flags and new global
5276         variable to compute use_fixed_output.
5277         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5278         Remove.
5279         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5280         (mi_multi_location_breakpoint_output_fixed): Remove.
5281         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5282         new variable.
5283         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5284         fix_multi_location_breakpoint_output flag if version >= 3.
5285         * ui-out.h (enum ui_out_flag)
5286         <fix_multi_location_breakpoint_output>: New enumerator.
5287
5288 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5289
5290         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5291
5292 2019-05-10  Tom Tromey  <tromey@adacore.com>
5293
5294         * ada-lang.c (catch_ada_completer): New function.
5295         (_initialize_ada_language): Use it.
5296
5297 2019-05-10  Tom Tromey  <tromey@adacore.com>
5298
5299         * thread.c (print_thread_info): Make "requested_threads" const.
5300         * gdbthread.h (print_thread_info): Make "requested_threads"
5301         const.
5302         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5303         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5304
5305 2019-05-08  Tom Tromey  <tom@tromey.com>
5306
5307         * gdbtypes.c (objfile_type_data): Change type.
5308         (objfile_type, _initialize_gdbtypes): Update.
5309
5310 2019-05-08  Tom Tromey  <tom@tromey.com>
5311
5312         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5313         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5314         (_initialize_dwarf2_frame): Update.
5315
5316 2019-05-08  Tom Tromey  <tom@tromey.com>
5317
5318         * objc-lang.c (objc_objfile_data): Change type.
5319         (find_methods): Update.
5320         (_initialize_objc_lang): Remove.
5321
5322 2019-05-08  Tom Tromey  <tom@tromey.com>
5323
5324         * stabsread.c (rs6000_builtin_type_data): Change type.
5325         (rs6000_builtin_type, _initialize_stabsread): Update.
5326
5327 2019-05-08  Tom Tromey  <tom@tromey.com>
5328
5329         * mips-tdep.c (mips_pdr_data): Remove.
5330         (_initialize_mips_tdep): Update.
5331
5332 2019-05-08  Tom Tromey  <tom@tromey.com>
5333
5334         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5335         (hppa_init_objfile_priv_data, read_unwind_info)
5336         (find_unwind_entry, _initialize_hppa_tdep): Update.
5337
5338 2019-05-08  Tom Tromey  <tom@tromey.com>
5339
5340         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5341         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5342         on obstack.
5343         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5344
5345 2019-05-08  Tom Tromey  <tom@tromey.com>
5346
5347         * mdebugread.c (basic_type_data): Change type.
5348         (basic_type, _initialize_mdebugread): Update.
5349
5350 2019-05-08  Tom Tromey  <tom@tromey.com>
5351
5352         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5353
5354 2019-05-08  Tom Tromey  <tom@tromey.com>
5355
5356         * nto-tdep.c (nto_inferior_data_reg): Change type.
5357         (nto_inferior_data): Update.
5358         (nto_inferior_data_cleanup, nto_new_inferior_data)
5359         (_initialize_nto_tdep): Remove.
5360         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5361
5362 2019-05-08  Tom Tromey  <tom@tromey.com>
5363
5364         * ada-lang.c (struct ada_inferior_data): Add initializers.
5365         (ada_inferior_data): Change type.
5366         (ada_inferior_data_cleanup): Remove.
5367         (get_ada_inferior_data, ada_inferior_exit)
5368         (struct ada_pspace_data): Add initializers, destructor.
5369         (ada_pspace_data_handle): Change type.
5370         (get_ada_pspace_data): Update.
5371         (ada_pspace_data_cleanup): Remove.
5372
5373 2019-05-08  Tom Tromey  <tom@tromey.com>
5374
5375         * coffread.c (struct coff_symfile_info): Add initializers.
5376         (coff_objfile_data_key): Move lower.  Change type.
5377         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5378         Update.
5379         (coff_free_info): Remove.
5380
5381 2019-05-08  Tom Tromey  <tom@tromey.com>
5382
5383         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5384         (fbsd_pspace_data_handle): Move lower.  Change type.
5385         (get_fbsd_pspace_data): Update.
5386         (fbsd_pspace_data_cleanup): Remove.
5387         (_initialize_fbsd_tdep): Update.
5388
5389 2019-05-08  Tom Tromey  <tom@tromey.com>
5390
5391         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5392         (get_ada_tasks_pspace_data): Update.
5393         (ada_tasks_pspace_data_cleanup): Remove.
5394         (_initialize_tasks): Update.
5395         (ada_tasks_inferior_data_handle): Change type.
5396         (get_ada_tasks_inferior_data): Update.
5397         (ada_tasks_inferior_data_cleanup): Remove.
5398         (struct ada_tasks_pspace_data): Add initializers.
5399
5400 2019-05-08  Tom Tromey  <tom@tromey.com>
5401
5402         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5403         * symfile-debug.c (debug_sym_get_probes): Change type.
5404         * stap-probe.c (handle_stap_probe):
5405         (stap_static_probe_ops::get_probes): Change type.
5406         * probe.h (class static_probe_ops) <get_probes>: Change type.
5407         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5408         (parse_probes_in_pspace): Update.
5409         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5410         Update.
5411         (any_static_probe_ops::get_probes): Change type.
5412         * elfread.c (elfread_data): New typedef.
5413         (probe_key): Change type.
5414         (elf_get_probes): Likewise.  Update.
5415         (probe_key_free): Remove.
5416         (_initialize_elfread): Update.
5417         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5418         Change type.
5419         (dtrace_process_dof_probe, dtrace_process_dof)
5420         (dtrace_static_probe_ops::get_probe): Change type.
5421
5422 2019-05-08  Tom Tromey  <tom@tromey.com>
5423
5424         * xcoffread.c (struct xcoff_symfile_info): Rename from
5425         coff_symfile_info.  Add initializers.
5426         (xcoff_objfile_data_key): Move lower.  Change type.
5427         (XCOFF_DATA): Rewrite.
5428         (xcoff_free_info): Remove.
5429         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5430         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5431         (xcoff_initial_scan): Update.
5432
5433 2019-05-08  Tom Tromey  <tom@tromey.com>
5434
5435         * solib-svr4.c (struct svr4_info): Add initializers and
5436         destructor.
5437         <probes_table>: Now an htab_up.
5438         (solib_svr4_pspace_data): Change type.
5439         (free_probes_table): Simplify.
5440         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5441         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5442         (probes_table_remove_objfile_probes, register_solib_event_probe)
5443         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5444         (_initialize_svr4_solib): Update.
5445
5446 2019-05-08  Tom Tromey  <tom@tromey.com>
5447
5448         * remote.c (remote_pspace_data): Change type.
5449         (remote_pspace_data_cleanup): Remove.
5450         (get_remote_exec_file, set_pspace_remote_exec_file)
5451         (_initialize_remote): Update.
5452
5453 2019-05-08  Tom Tromey  <tom@tromey.com>
5454
5455         * breakpoint.c (breakpoint_objfile_key): Change type.
5456         (get_breakpoint_objfile_data): Update.
5457         (free_breakpoint_objfile_data): Remove.
5458         (_initialize_breakpoint): Update.
5459
5460 2019-05-08  Tom Tromey  <tom@tromey.com>
5461
5462         * linux-tdep.c (struct linux_info): Add initializers.
5463         (linux_inferior_data): Move.  Change type.
5464         (invalidate_linux_cache_inf): Update.
5465         (linux_inferior_data_cleanup): Remove.
5466         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5467
5468 2019-05-08  Tom Tromey  <tom@tromey.com>
5469
5470         * auxv.c (auxv_inferior_data): Move.  Change type.
5471         (auxv_inferior_data_cleanup): Remove.
5472         (invalidate_auxv_cache_inf): Rewrite.
5473         (get_auxv_inferior_data, _initialize_auxv): Update.
5474
5475 2019-05-08  Tom Tromey  <tom@tromey.com>
5476
5477         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5478         (symfile_debug_objfile_data_key): Change type.
5479         (symfile_debug_installed, debug_qf_has_symbols)
5480         (debug_qf_find_last_source_symtab)
5481         (debug_qf_forget_cached_source_info)
5482         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5483         (debug_qf_print_stats, debug_qf_dump)
5484         (debug_qf_expand_symtabs_for_function)
5485         (debug_qf_expand_all_symtabs)
5486         (debug_qf_expand_symtabs_with_fullname)
5487         (debug_qf_map_matching_symbols)
5488         (debug_qf_expand_symtabs_matching)
5489         (debug_qf_find_pc_sect_compunit_symtab)
5490         (debug_qf_map_symbol_filenames)
5491         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5492         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5493         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5494         (debug_sym_read_linetable, debug_sym_relocate): Update.
5495         (symfile_debug_free_objfile): Remove.
5496         (install_symfile_debug_logging, _initialize_symfile_debug):
5497         Update.
5498
5499 2019-05-08  Tom Tromey  <tom@tromey.com>
5500
5501         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5502         allocate_on_obstack.
5503         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5504         (get_dwarf2_per_objfile): Update.
5505         (set_dwarf2_per_objfile): Remove.
5506         (dwarf2_has_info, dwarf2_get_section_info): Update.
5507         (dwarf2_free_objfile): Remove.
5508         (_initialize_dwarf2_read): Update.
5509
5510 2019-05-08  Tom Tromey  <tom@tromey.com>
5511
5512         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5513         initializers.
5514         <unsupported_script_warning_printed,
5515         script_not_found_warning_printed>: Now bool.
5516         (auto_load_pspace_data): Change type.
5517         (~auto_load_pspace_info): Rename from
5518         auto_load_pspace_data_cleanup.
5519         (get_auto_load_pspace_data, init_loaded_scripts_info)
5520         (clear_section_scripts, maybe_print_unsupported_script_warning)
5521         (maybe_print_script_not_found_warning, _initialize_auto_load):
5522         Update.
5523
5524 2019-05-08  Tom Tromey  <tom@tromey.com>
5525
5526         * objfiles.c (objfile_pspace_info): Add destructor and
5527         initializers.
5528         (objfiles_pspace_data): Change type.
5529         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5530         (get_objfile_pspace_data): Update.
5531         (objfiles_bfd_data): Change type.
5532         (get_objfile_bfd_data): Update.
5533         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5534
5535 2019-05-08  Tom Tromey  <tom@tromey.com>
5536
5537         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5538         Change type.
5539         (get_catch_syscall_inferior_data): Update.
5540         (catch_syscall_inferior_data_cleanup): Remove.
5541         (_initialize_break_catch_syscall): Update.
5542
5543 2019-05-08  Tom Tromey  <tom@tromey.com>
5544
5545         * inflow.c (struct terminal_info): Add destructor and
5546         initializers.
5547         (inflow_inferior_data): Change type.
5548         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5549         (get_inflow_inferior_data, inflow_inferior_exit)
5550         (swap_terminal_info, _initialize_inflow): Update.
5551
5552 2019-05-08  Tom Tromey  <tom@tromey.com>
5553
5554         * target-dcache.c (target_dcache_cleanup): Remove.
5555         (target_dcache_aspace_key): Change type.
5556         (target_dcache_init_p, target_dcache_invalidate)
5557         (target_dcache_get, target_dcache_get_or_init)
5558         (_initialize_target_dcache): Update.
5559         * dcache.h (struct dcache_deleter): New.
5560
5561 2019-05-08  Tom Tromey  <tom@tromey.com>
5562
5563         * symtab.c (struct symbol_cache): Add destructor and
5564         initializers.
5565         (symbol_cache_key): Move.  Change type.
5566         (make_symbol_cache, free_symbol_cache): Remove.
5567         (get_symbol_cache): Update.
5568         (symbol_cache_cleanup): Remove.
5569         (ALL_PSPACES, symbol_cache_flush)
5570         (maintenance_print_symbol_cache)
5571         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5572         Update.
5573
5574 2019-05-08  Tom Tromey  <tom@tromey.com>
5575
5576         * symtab.c (struct main_info): Add destructor and initializers.
5577         (main_progspace_key): Move.  Change type.
5578         (get_main_info): Update.
5579         (main_info_cleanup): Remove.
5580         (_initialize_symtab): Update.
5581
5582 2019-05-08  Tom Tromey  <tom@tromey.com>
5583
5584         * registry.h (DECLARE_REGISTRY): Define the _key class.
5585
5586 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * NEWS: Merge two 'New commands' sections.
5589
5590 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5591
5592         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5593         parameter and use Ada language definition instead.
5594         (ada_val_print_ptr): Remove unused language parameter.
5595         (ada_val_print_num): Remove language parameter and use Ada language
5596         definition instead.
5597         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5598         parameter.
5599         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5600         parameter and use Ada language definition instead.
5601         (ada_val_print_1): Update all ada_val_print_xxx calls.
5602         Remove language parameter.
5603         (ada_val_print): Update ada_val_print_1 call.
5604
5605 2019-05-08  Tom Tromey  <tromey@adacore.com>
5606
5607         * remote.c (remote_hw_watchpoint_limit)
5608         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5609         Now static.
5610
5611 2019-05-08  Tom Tromey  <tromey@adacore.com>
5612
5613         * maint.c (_initialize_maint_cmds): Move initialization code to
5614         remote.c.
5615         (watchdog, show_watchdog): Move to remote.c.
5616         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5617         "watchdog" static.
5618         (_initialize_remote): Move initialization code from maint.c.
5619         * defs.h (watchdog): Don't declare.
5620
5621 2019-05-08  Tom Tromey  <tromey@adacore.com>
5622
5623         * tui/tui-interp.c: Include main.h.
5624         * interps.c: Include main.h.
5625         * main.h (interpreter_p): Declare.
5626         * defs.h (interpreter_p): Don't declare.
5627
5628 2019-05-08  Tom Tromey  <tromey@adacore.com>
5629
5630         * dwarf2loc.c: Include dwarf2read.h.
5631         * defs.h (read_unsigned_leb128): Don't declare.
5632         * dwarf2read.h (read_unsigned_leb128): Declare.
5633
5634 2019-05-08  Tom Tromey  <tromey@adacore.com>
5635
5636         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5637         method.
5638
5639 2019-05-08  Tom Tromey  <tromey@adacore.com>
5640
5641         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5642         when no wrap column is set.
5643
5644 2019-05-08  Tom Tromey  <tromey@adacore.com>
5645
5646         * c-lang.c (c_get_string): Handle non-C-style arrays.
5647
5648 2019-05-08  Tom Tromey  <tromey@adacore.com>
5649
5650         * typeprint.c (print_offset_data::update): Print the bit offset,
5651         not the number of bits remaining.
5652
5653 2019-05-08  Tom Tromey  <tromey@adacore.com>
5654
5655         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5656         padding at end of comment.
5657
5658 2019-05-08  Tom Tromey  <tromey@adacore.com>
5659
5660         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5661         Compare main types.
5662
5663 2019-05-06  Tom Tromey  <tom@tromey.com>
5664
5665         * common/scoped_mmap.c: Include common-defs.h.
5666         * common/scoped_mmap.h: Don't include config.h.
5667
5668 2019-05-04  Tom Tromey  <tom@tromey.com>
5669
5670         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5671         (struct aarch64_call_info): Add initializers.
5672         <si>: Now a std::vector.
5673         (pass_on_stack, aarch64_push_dummy_call): Update.
5674
5675 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5676             Tom Tromey  <tom@tromey.com>
5677
5678         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5679         (ppc_threads): Now a std::vector.  Now static.
5680         (hwdebug_find_thread_points_by_tid)
5681         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5682         Update.
5683
5684 2019-05-04  Tom Tromey  <tom@tromey.com>
5685
5686         * arc-tdep.c (arc_tdesc_init): Return bool.
5687
5688 2019-05-04  Tom Tromey  <tom@tromey.com>
5689
5690         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5691         Use gdb_assert_not_reached.
5692
5693 2019-05-04  Tom Tromey  <tom@tromey.com>
5694
5695         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5696         "false".
5697
5698 2019-05-04  Tom Tromey  <tom@tromey.com>
5699
5700         * arc-tdep.c (arc_tdesc_init): Use bool.
5701
5702 2019-05-04  Tom Tromey  <tom@tromey.com>
5703
5704         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5705
5706 2019-05-04  Tom Tromey  <tom@tromey.com>
5707
5708         * cli/cli-cmds.c (valid_command_p): Return bool.
5709
5710 2019-05-04  Tom Tromey  <tom@tromey.com>
5711
5712         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5713         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5714
5715 2019-05-04  Raul Tambre  <raul@tambre.ee>
5716
5717         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5718         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5719         operator for comparison.
5720
5721 2019-05-04  Tom Tromey  <tom@tromey.com>
5722
5723         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5724         (lookup_partial_symbol, print_partial_symbols)
5725         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5726         (psymbol_compare): Update.
5727         (add_psymbol_to_bcache): Clear the entire psymbol.
5728         (maintenance_check_psymtabs): Update.
5729         * psympriv.h (struct partial_symbol): Don't derive from
5730         general_symbol_info.
5731         <obj_section, unrelocated_address, address,
5732         set_unrelocated_address>: Update.
5733         <ginfo>: New member.
5734         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5735         (debug_names::write_psymbols): Update.
5736
5737 2019-05-04  Tom de Vries  <tdevries@suse.de>
5738
5739         * contrib/cc-with-tweaks.sh: Support -n arg.
5740
5741 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5742
5743         * corelow.c (core_target::detach): Ensure frame cache and
5744         register caches are cleared.
5745         inferior.c (exit_inferior_1): Likewise.
5746
5747 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5748             Tom Tromey  <tom@tromey.com>
5749
5750         * dictionary.c (collate_pending_symbols_by_language): Remove
5751         "struct" from foreach.
5752         * symtab.c (lookup_global_symbol_from_objfile)
5753         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5754         foreach.
5755         * ser-tcp.c (net_open): Remove "struct" from foreach.
5756         * objfiles.c (objfile_relocate, objfile_rebase)
5757         (objfile_has_symbols): Remove "struct" from foreach.
5758         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5759         from foreach.
5760         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5761         foreach.
5762         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5763         "struct" from foreach.
5764         * ada-lang.c (create_excep_cond_exprs)
5765         (ada_exception_catchpoint_cond_string): Remove "struct" from
5766         foreach.
5767
5768 2019-05-03  Tom Tromey  <tromey@adacore.com>
5769
5770         * ada-exp.y (convert_char_literal): Check suffix of each
5771         enumerator.
5772
5773 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5774
5775         PR ada/21406:
5776         * ada-exp.y (yywrap): Don't define.
5777         * ada-lex.l (%option): Add noyywrap
5778         (yywrap): Remove.
5779
5780 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5781
5782         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5783         _WIN32_WINNT to the XP level, unless already defined to a higher
5784         level.
5785
5786         * unittests/parse-connection-spec-selftests.c:
5787         * ser-tcp.c:
5788         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5789         override.
5790
5791         * symfile.c (find_separate_debug_file): Remove colon from the
5792         drive spec of DOS/Windows file names of the target, so that the
5793         file name produced from DEBUGDIR and the target's directory will
5794         be valid on DOS/Windows systems.
5795
5796 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5797
5798         * rust-lang.c (val_print_struct): Handle printing structures
5799         containing strings.
5800
5801 2019-05-02  Tom Tromey  <tromey@adacore.com>
5802
5803         * valarith.c (_initialize_valarith): Remove.
5804
5805 2019-05-01  Tom Tromey  <tromey@adacore.com>
5806
5807         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5808         bitfields.
5809
5810 2019-05-01  Tom Tromey  <tromey@adacore.com>
5811
5812         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5813         for big-endian copies.
5814
5815 2019-04-30  Ali Tamur  <tamur@google.com>
5816         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5817         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5818         (read_3_bytes): New function.
5819
5820 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5821
5822         * windows-nat.c (main_thread_id): Delete.
5823         (handle_output_debug_string): Replace main_thread_id by
5824         current_event.dwThreadId.
5825         (fake_create_process): Likewise.
5826         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5827         Do not set main_thread_id.
5828         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5829         current_event.dwThreadId.
5830         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5831
5832 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5833
5834         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5835         Use current_event.dwThreadId instead of main_thread_id.
5836
5837 2019-04-30  Tom Tromey  <tromey@adacore.com>
5838
5839         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5840         (create_excep_cond_exprs): Iterate over program spaces.
5841         (ada_exception_catchpoint_cond_string): Examine all minimal
5842         symbols for exception types.
5843
5844 2019-04-30  Tom Tromey  <tromey@adacore.com>
5845
5846         PR c++/24470:
5847         * dwarf2read.c (process_structure_scope): Handle case where type
5848         has template parameters but no symbol was created.
5849
5850 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5851             Chris January  <chris.january@arm.com>
5852
5853         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5854         qualifier.
5855         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5856
5857 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5858
5859         * f-typeprint.c (f_print_type): Update rules for printing
5860         whitespace.
5861         (f_type_print_varspec_suffix): Likewise.
5862
5863 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5864             Chris January  <chris.january@arm.com>
5865
5866         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5867         function arguments.
5868
5869 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * f-lang.c (build_fortran_types): Change name of void type to
5872         lower case.
5873         * f-typeprint.c (f_type_print_base): Print the name of the void
5874         type, rather than a fixed string.
5875         * f-valprint.c (f_decorations): Use lower case void string.
5876
5877 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5878             Chris January  <chris.january@arm.com>
5879
5880         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5881         types for Fortran.
5882
5883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5884             Chris January  <chris.january@arm.com>
5885             David Lecomber  <david.lecomber@arm.com>
5886
5887         * f-exp.y (BINOP_INTRINSIC): New token.
5888         (exp): New parser rule handling BINOP_INTRINSIC.
5889         (f77_keywords): Add new builtin procedures.
5890         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5891         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5892         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5893         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5894         (print_unop_subexp_f): New function.
5895         (print_binop_subexp_f): New function.
5896         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5897         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5898         (dump_subexp_body_f): Likewise.
5899         (operator_check_f): Likewise.
5900         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5901         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5902
5903 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5906         UNOP_KIND.
5907         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5908         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5909         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5910         (operator_length_f): New fuction.
5911         (print_subexp_f): New function.
5912         (op_name_f): New function.
5913         (dump_subexp_body_f): New function.
5914         (operator_check_f): New function.
5915         (exp_descriptor_f): Replace standard expression handling functions
5916         with new functions.
5917         * gdb/fortran-operator.def: New file.
5918         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5919         * gdb/std-operator.def: Remove UNOP_KIND.
5920
5921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * std-operator.def: Remove unbalanced, stray double quote
5924         character.
5925
5926 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5927             Chris January  <chris.january@arm.com>
5928             Daniel Everett  <daniel.everett@arm.com>
5929             Nick Forrington  <nick.forrington@arm.com>
5930             Richard Bunt  <richard.bunt@arm.com>
5931
5932         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5933         of depth when printing anonymous structs or unions.
5934         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5935         Don't print either the top-level value, or the children if the
5936         max-depth is exceeded.
5937         (ppscm_print_children): When printing the key of a map, allow one
5938         extra level of depth.
5939         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5940         print either the top-level value, or the children if the max-depth
5941         is exceeded.
5942         (print_children): When printing the key of a map, allow one extra
5943         level of depth.
5944         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5945         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5946         (user_print_options): Initialise max_depth field.
5947         (val_print_scalar_or_string_type_p): New function.
5948         (val_print): Check to see if the max depth has been reached.
5949         (val_print_check_max_depth): Define new function.
5950         (show_print_max_depth): New function.
5951         (_initialize_valprint): Add 'print max-depth' option.
5952         * valprint.h (struct value_print_options) <max_depth>: New field.
5953         (val_print_check_max_depth): Declare new function.
5954         * NEWS: Document new feature.
5955
5956 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5957
5958         * ada-lang.c (ada_language_defn): Initialise new field.
5959         * c-lang.c (c_is_string_type_p): New function.
5960         (c_language_defn): Initialise new field.
5961         (cplus_language_defn): Initialise new field.
5962         (asm_language_defn): Initialise new field.
5963         (minimal_language_defn): Initialise new field.
5964         * c-lang.h (c_is_string_type_p): Declare new function.
5965         * d-lang.c (d_language_defn): Initialise new field.
5966         * f-lang.c (f_is_string_type_p): New function.
5967         (f_language_defn): Initialise new field.
5968         * go-lang.c (go_is_string_type_p): New function.
5969         (go_language_defn): Initialise new field.
5970         * language.c (default_is_string_type_p): New function.
5971         (unknown_language_defn): Initialise new field.
5972         (auto_language_defn): Initialise new field.
5973         * language.h (struct language_defn) <la_is_string_type_p>: New
5974         member variable.
5975         (default_is_string_type_p): Declare new function.
5976         * m2-lang.c (m2_language_defn): Initialise new field.
5977         * objc-lang.c (objc_language_defn): Initialise new field.
5978         * opencl-lang.c (opencl_language_defn): Initialise new field.
5979         * p-lang.c (pascal_is_string_type_p): New function.
5980         (pascal_language_defn): Initialise new field.
5981         * rust-lang.c (rust_is_string_type_p): New function.
5982         (rust_language_defn): Initialise new field.
5983
5984 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5985
5986         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5987         New field.
5988         * ada-lang.c (ada_language_defn): Initialise new field.
5989         * c-lang.c (c_language_defn): Likewise.
5990         (cplus_language_defn): Likewise.
5991         (asm_language_defn): Likewise.
5992         (minimal_language_defn): Likewise.
5993         * d-lang.c (d_language_defn): Likewise.
5994         * f-lang.c (f_language_defn): Likewise.
5995         * go-lang.c (go_language_defn): Likewise.
5996         * language.c (unknown_language_defn): Likewise.
5997         (auto_language_defn): Likewise.
5998         * m2-lang.c (m2_language_defn): Likewise.
5999         * objc-lang.c (objc_language_defn): Likewise.
6000         * opencl-lang.c (opencl_language_defn): Likewise.
6001         * p-lang.c (pascal_language_defn): Likewise.
6002         * rust-lang.c (rust_language_defn): Likewise.
6003
6004 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * ada-lang.c (ada_is_character_type): Change return type to bool.
6007         (ada_is_string_type): Likewise.
6008         * ada-lang.h (ada_is_character_type): Update declaration
6009         (ada_is_string_type): Likewise.
6010
6011 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6012
6013         Support style in 'frame|thread apply'
6014
6015         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6016         * record.c (record_start, record_stop): Update callers of
6017         execute_command_to_string with false.
6018         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6019         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6020         methods.
6021         (class string_file): New constructor with term_out parameter.
6022         Override methods term_out and can_emit_style_escape.  New member
6023         term_out.
6024         (class stdio_file): Override can_emit_style_escape.
6025         (class tee_file): Override term_out and can_emit_style_escape.
6026         * utils.h (can_emit_style_escape): Remove.
6027         * utils.c (can_emit_style_escape): Likewise.
6028         Update all callers of can_emit_style_escape (SOMESTREAM) to
6029         SOMESTREAM->can_emit_style_escape.
6030         * source-cache.c (source_cache::get_source_lines): Likewise.
6031         * stack.c (frame_apply_command_count): Call execute_command_to_string
6032         passing the term_out characteristic of the current gdb_stdout.
6033         * thread.c (thr_try_catch_cmd): Likewise.
6034         * top.c (execute_command_to_string): pass term_out parameter
6035         to construct the string_file for the command output.
6036         * ui-file.c (term_cli_styling): New function (most code moved
6037         from utils.c can_emit_style_escape).
6038         (string_file::string_file, string_file::can_emit_style_escape,
6039         stdio_file::can_emit_style_escape, tee_file::term_out,
6040         tee_file::can_emit_style_escape): New functions.
6041
6042 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6043
6044         * NEWS: Mention the new set|show may-call-functions.
6045         * infcall.c (may_call_functions_p): New variable.
6046         (show_may_call_functions_p): New function.
6047         (call_function_by_hand_dummy): Throws an error if not
6048         may-call-functions.
6049         (_initialize_infcall): Call add_setshow_boolean_cmd for
6050         may-call-functions.
6051
6052 2019-04-25  Keith Seitz  <keiths@redhat.com>
6053
6054         PR c++/24367
6055         * cp-support.c (inspect_type): Don't attempt substitutions
6056         of symbol with the same name.
6057
6058 2019-04-25  Tom Tromey  <tromey@adacore.com>
6059
6060         PR gdb/24475:
6061         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6062         static.
6063
6064 2019-04-25  Tom Tromey  <tromey@adacore.com>
6065
6066         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6067         rvalue reference.
6068         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6069         (gdb_xml_parser::parse): Use std::move.
6070         * python/python-internal.h (gdbpy_convert_exception): Take a const
6071         reference.
6072         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6073         std::move.
6074         * python/py-utils.c (gdbpy_convert_exception): Take a const
6075         reference.
6076         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6077         Use std::move.
6078         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6079         Use std::move.
6080         * mi/mi-main.c (mi_print_exception): Take a const reference.
6081         * main.c (handle_command_errors): Take a const reference.
6082         * linespec.c (parse_linespec): Use std::move.
6083         * infcall.c (run_inferior_call): Use std::move.
6084         (call_function_by_hand_dummy): Use std::move.
6085         * exec.c (try_open_exec_file): Use std::move.
6086         * exceptions.h (exception_print, exception_fprintf)
6087         (exception_print_same): Update.
6088         * exceptions.c (print_exception, exception_print)
6089         (exception_fprintf, exception_print_same): Change parameters to
6090         const reference.
6091         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6092         * common/new-op.c: Use std::move.
6093         * common/common-exceptions.h (struct gdb_exception): Add move
6094         constructor.
6095         (struct gdb_exception_error, struct gdb_exception_quit, struct
6096         gdb_quit_bad_alloc): Change constructor to move constructor.
6097         (throw_exception): Change parameter to rvalue reference.
6098         * common/common-exceptions.c (throw_exception): Take rvalue
6099         reference.
6100         * cli/cli-interp.c (safe_execute_command): Use std::move.
6101         * breakpoint.c (insert_bp_location, location_to_sals): Use
6102         std::move.
6103
6104 2019-04-25  Tom Tromey  <tromey@adacore.com>
6105
6106         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6107         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6108         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6109         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6110         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6111         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6112         guile/scm-value.c: Use unpack.
6113         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6114         gdbscm_gdb_exception.
6115         (gdbscm_throw_gdb_exception): Likewise.
6116         (struct gdbscm_gdb_exception): New.
6117         (unpack): New function.
6118         (gdbscm_wrap): Use unpack.
6119
6120 2019-04-25  Tom Tromey  <tromey@adacore.com>
6121
6122         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6123         (gdb_rl_callback_handler): Use std::move.
6124         * common/common-exceptions.h (struct gdb_exception): Add move
6125         assignment operator.
6126         (throw_exception_sjlj): Change "exception" to const reference.
6127         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6128         (throw_exception_sjlj): Change "exception" to const reference.
6129
6130 2019-04-25  Tom Tromey  <tromey@adacore.com>
6131
6132         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6133         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6134         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6135         Update.
6136         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6137         Update.
6138         * mi/mi-interp.c (mi_interp::exec): Update.
6139         * linespec.c (parse_linespec): Update.
6140         * infcall.c (run_inferior_call): Update.
6141         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6142         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6143         (gdbscm_lookup_global_symbol): Update.
6144         * guile/scm-param.c (gdbscm_parameter_value): Update.
6145         * guile/scm-frame.c (gdbscm_frame_read_register)
6146         (gdbscm_frame_read_var): Update.
6147         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6148         * exec.c (try_open_exec_file): Update.
6149         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6150         (gdb_rl_callback_handler): Update.
6151         * common/common-exceptions.h (exception_none): Don't declare.
6152         * common/common-exceptions.c (exception_none): Don't define.
6153         (struct catcher) <exception>: Update.
6154         * cli/cli-interp.c (safe_execute_command): Update.
6155         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6156
6157 2019-04-25  Ali Tamur  <tamur@google.com>
6158
6159         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6160         (read_attribute_value): Likewise.
6161         (dwarf2_read_addr_index): Update comment.
6162         (read_str_index): Add DW_FORM_strx.
6163         (dwarf2_string_attr): Likewise.
6164         (dwarf2_const_value_attr): Likewise.
6165         (dump_die_shallow): Likewise.
6166         (dwarf2_fetch_constant_bytes): Likewise.
6167         (skip_form_bytes): Likewise.
6168         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6169
6170 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6171
6172         PR corefiles/11608
6173         PR corefiles/18187
6174         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6175         OFFSET.  Verify if current mapping contains an ELF header.
6176         (linux_find_memory_regions_full): Adjust call to
6177         dump_mapping_p.
6178
6179 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6180             Kang Li <kanglictf@gmail.com>
6181
6182         PR gdb/21600
6183
6184         * dwarf2-frame.c (read_initial_length): Be consistent about using
6185         unsigned representation of length.
6186         (decode_frame_entry_1): Likewise.  Check for wraparound of
6187         end pointer as well as buffer overflow.
6188
6189 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6190
6191         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6192         "vq".
6193
6194 2019-04-24  Tom Tromey  <tromey@adacore.com>
6195
6196         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6197
6198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6199
6200         * s12z-tdep.c (s12z_unwind_pc): Delete.
6201         (s12z_unwind_sp): Delete.
6202         (s12z_gdbarch_init): Don't register deleted functions with
6203         gdbarch.
6204
6205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6206
6207         * rl78-tdep.c (rl78_unwind_sp): Delete.
6208         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6209
6210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6211
6212         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6213         (xstormy16_unwind_pc): Delete.
6214         (xstormy16_dummy_id): Delete.
6215         (xstormy16_gdbarch_init): Don't register deleted functions with
6216         gdbarch.
6217
6218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6219
6220         * vax-tdep.c (vax_unwind_pc): Delete.
6221         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6222
6223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * v850-tdep.c (v850_unwind_sp): Delete.
6226         (v850_unwind_pc): Delete.
6227         (v850_dummy_id): Delete.
6228         (v850_gdbarch_init): Don't register deleted functions with
6229         gdbarch.
6230
6231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6232
6233         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6234         (tilegx_unwind_pc): Delete.
6235         (tilegx_unwind_dummy_id): Delete.
6236         (tilegx_gdbarch_init): Don't register deleted functions with
6237         gdbarch.
6238
6239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6240
6241         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6242         (tic6x_dummy_id): Delete.
6243         (tic6x_gdbarch_init): Don't register deleted functions with
6244         gdbarch.
6245
6246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6247
6248         * sparc-tdep.c (sparc_unwind_pc): Delete.
6249         (sparc32_gdbarch_init): Don't register deleted function with
6250         gdbarch.
6251
6252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * sh-tdep.c (sh_unwind_sp): Delete.
6255         (sh_unwind_pc): Delete.
6256         (sh_dummy_id): Delete.
6257         (sh_gdbarch_init): Don't register deleted functions with
6258         gdbarch.
6259
6260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6261
6262         * score-tdep.c (score_unwind_sp): Delete.
6263         (score_unwind_pc): Delete.
6264         (score_dummy_id): Delete.
6265         (score_gdbarch_init): Don't register deleted functions with
6266         gdbarch.
6267
6268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * rx-tdep.c (rx_unwind_pc): Delete.
6271         (rx_unwind_sp): Delete.
6272         (rx_dummy_id): Delete.
6273         (rx_gdbarch_init): Don't register deleted functions with
6274         gdbarch.  Update comment.
6275
6276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6279         (rs6000_dummy_id): Delete.
6280         (rs6000_gdbarch_init): Don't register deleted functions with
6281         gdbarch.
6282
6283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6284
6285         * or1k-tdep.c (or1k_dummy_id): Delete.
6286         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6287
6288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6289
6290         * nios2-tdep.c (nios2_dummy_id): Delete.
6291         (nios2_unwind_sp): Delete.
6292         (nios2_gdbarch_init): Don't register deleted functions with
6293         gdbarch.
6294
6295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6296
6297         * nds32-tdep.c (nds32_dummy_id): Delete.
6298         (nds32_unwind_pc): Delete.
6299         (nds32_unwind_sp): Delete.
6300         (nds32_gdbarch_init): Don't register deleted functions with
6301         gdbarch.
6302
6303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6304
6305         * msp430-tdep.c (msp430_unwind_pc): Delete.
6306         (msp430_unwind_sp): Delete.
6307         (msp430_dummy_id): Delete.
6308         (msp430_gdbarch_init): Don't register deleted functions with
6309         gdbarch.
6310
6311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * moxie-tdep.c (moxie_unwind_sp): Delete.
6314         (moxie_unwind_pc): Delete.
6315         (moxie_dummy_id): Delete.
6316         (moxie_gdbarch_init): Don't register deleted functions with
6317         gdbarch.
6318
6319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6320
6321         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6322         (mn10300_unwind_pc): Delete.
6323         (mn10300_unwind_sp): Delete.
6324         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6325         mn10300_unwind_sp.
6326         (mn10300_frame_unwind_init): Don't register deleted functions with
6327         gdbarch.
6328
6329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6330
6331         * mep-tdep.c (mep_unwind_pc): Delete.
6332         (mep_unwind_sp): Delete.
6333         (mep_dummy_id): Delete.
6334         (mep_gdbarch_init): Don't register deleted functions with
6335         gdbarch.
6336
6337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6338
6339         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6340         (m68hc11_unwind_sp): Delete.
6341         (m68hc11_gdbarch_init): Don't register deleted functions with
6342         gdbarch.
6343
6344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6345
6346         * m32r-tdep.c (m32r_unwind_sp): Delete.
6347         (m32r_unwind_pc): Delete.
6348         (m32r_dummy_id): Delete.
6349         (m32r_gdbarch_init): Don't register deleted functions with
6350         gdbarch.
6351
6352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6353
6354         * m32c-tdep.c (m32c_unwind_pc): Delete.
6355         (m32c_unwind_sp): Delete.
6356         (m32c_dummy_id): Delete.
6357         (m32c_gdbarch_init): Don't register deleted functions with
6358         gdbarch.
6359
6360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6361
6362         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6363         (lm32_unwind_pc): Delete.
6364         (lm32_dummy_id): Delete.
6365         (lm32_gdbarch_init): Don't register deleted functions with
6366         gdbarch.
6367
6368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6369
6370         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6371         (iq2000_unwind_pc): Delete.
6372         (iq2000_dummy_id): Delete.
6373         (iq2000_gdbarch_init): Don't register deleted functions with
6374         gdbarch.
6375
6376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6377
6378         * nds32-tdep.c (nds32_type_align): Delete.
6379         (nds32_push_dummy_call): Use type_align instead.
6380
6381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6382
6383         * arm-tdep.c (arm_type_align): Only handle vector override case.
6384         (arm_push_dummy_call): Use type_align.
6385         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6386
6387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6388
6389         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6390         case.
6391         (pass_on_stack): Use type_align.
6392         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6393         function.
6394
6395 2019-04-23  Tom Tromey  <tromey@adacore.com>
6396
6397         * dwarf2read.c (line_header::file_name_at): Remove unused
6398         overload.
6399
6400 2019-04-23  Tom de Vries  <tdevries@suse.de>
6401
6402         PR gdb/24438
6403         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6404         invocation.
6405
6406
6407 2019-03-27  Ali Tamur  <tamur@google.com>
6408
6409         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6410         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6411         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6412         (dwarf_expr_context::get_addr_index): Likewise
6413         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6414         (symbol_needs_eval_context::get_addr_index): Likewise
6415         (disassemble_dwarf_expression): Add DW_OP_addrx
6416         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6417         (read_cutu_die_from_dwo): Update comment
6418         (skip_one_die): Add DW_FORM_addrx
6419         (read_attribute_value): Likewise
6420         (var_decode_location): Add DW_OP_addrx
6421         (dwarf2_const_value_attr): Add DW_FORM_addrx
6422         (dump_die_shallow): Likewise
6423         (dwarf2_fetch_constant_bytes): Likewise
6424         (decode_locdesc): Add DW_OP_addrx
6425         (skip_form_bytes): Add DW_FORM_addrx
6426
6427 2019-04-22  Ali Tamur  <tamur@google.com>
6428
6429         * MAINTAINERS (Write After Approval): Add self.
6430
6431 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6432
6433         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6434         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6435         (open_symbol_file_object): Likewise.
6436         (svr4_default_sos): Add info parameter.
6437         (svr4_read_so_list): Likewise.
6438         (svr4_current_sos_direct): Adjust functions calls to pass down
6439         info.
6440         (svr4_current_sos_1): Add info parameter.
6441         (svr4_current_sos): Call get_svr4_info, pass info down to
6442         svr4_current_sos_1.
6443         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6444         get_svr4_info.
6445         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6446         get_svr4_info.
6447         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6448         to get_svr4_info.
6449         (probes_table_remove_objfile_probes): Likewise.
6450         (register_solib_event_probe): Add info parameter.
6451         (solist_update_incremental): Pass info parameter down to
6452         svr4_read_so_list.
6453         (disable_probes_interface): Add info parameter.
6454         (svr4_handle_solib_event): Pass current_program_space to
6455         get_svr4_info.  Adjust disable_probes_interface cleanup.
6456         (svr4_create_probe_breakpoints): Add info parameter, pass it
6457         down to register_solib_event_probe.
6458         (svr4_create_solib_event_breakpoints): Add info parameter,
6459         pass it down to svr4_create_probe_breakpoints.
6460         (enable_break): Pass info down to
6461         svr4_create_solib_event_breakpoints.
6462         (svr4_solib_create_inferior_hook): Pass current_program_space to
6463         get_svr4_info.
6464         (svr4_clear_solib): Likewise.
6465
6466 2019-04-22  Pedro Alves  <palves@redhat.com>
6467
6468         * solib-svr4.c (svr4_free_objfile_observer): New.
6469         (probe_and_action::objfile): New field.
6470         (probes_table_htab_remove_objfile_probes)
6471         (probes_table_remove_objfile_probes): New functions.
6472         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6473         in the new probe_and_action.  Don't store the probe in 'lookup'.
6474         (svr4_create_probe_breakpoints): Pass objfile to
6475         register_solib_event_probe.
6476         (_initialize_svr4_solib): Register a free_objfile observer.
6477
6478 2019-04-19  Tom Tromey  <tom@tromey.com>
6479
6480         * common/queue.h: Remove.
6481
6482 2019-04-19  Tom Tromey  <tom@tromey.com>
6483
6484         * event-loop.c: Don't include "common/queue.h".
6485
6486 2019-04-19  Tom Tromey  <tom@tromey.com>
6487
6488         * remote.c (remote_target): Use delete.
6489         * remote-notif.h: Include <list>, not "common/queue.h".
6490         (notif_client_p): Remove typedef.
6491         (remote_notif_state): Add constructor, destructor, initializer.
6492         <notif_queue>: Now a std::list.
6493         (remote_notif_state_xfree): Don't declare.
6494         * remote-notif.c (remote_notif_process, handle_notification)
6495         (remote_notif_state_allocate): Update.
6496         (~remote_notif_state): Rename from remote_notif_state_xfree.
6497
6498 2019-04-19  Tom Tromey  <tom@tromey.com>
6499
6500         * symfile.c (reread_symbols): Update.
6501         * objfiles.c (objfile_register_static_link)
6502         (objfile_lookup_static_link): Update
6503         (~objfile) Don't delete static_links.
6504         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6505
6506 2019-04-19  Tom Tromey  <tom@tromey.com>
6507
6508         * type-stack.h (struct type_stack) <insert>: Constify string.
6509         * type-stack.c (type_stack::insert): Constify string.
6510         * gdbtypes.h (lookup_template_type): Update.
6511         (address_space_name_to_int): Update.
6512         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6513         const.
6514         (lookup_template_type): Make name const.
6515         * c-exp.y: Update rules.
6516         (lex_one_token, classify_name, classify_inner_name)
6517         (c_print_token): Update.
6518         * p-exp.y: Update rules.
6519         (yylex): Update.
6520         * f-exp.y: Update rules.
6521         (yylex): Update.
6522         * d-exp.y: Update rules.
6523         (lex_one_token, classify_name, classify_inner_name): Update.
6524         * parse.c (write_dollar_variable, copy_name): Return std::string.
6525         * parser-defs.h (copy_name): Change return type.
6526         * m2-exp.y: Update rules.
6527         (yylex): Update.
6528         * go-exp.y (lex_one_token): Update.
6529         Update rules.
6530         (classify_unsafe_function, classify_packaged_name)
6531         (classify_name, yylex): Update.
6532
6533 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6534
6535         * configure.ac: add --enable-source-highlight switch.
6536         * configure: Regenerate.
6537         * top.c (print_gdb_version): plumb --enable-source-highlight
6538         status to "show configuration".
6539
6540 2019-04-19  Tom Tromey  <tromey@adacore.com>
6541
6542         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6543         Check ADA_TYPE_P.
6544         (empty_record, ada_template_to_fixed_record_type_1)
6545         (template_to_static_fixed_type)
6546         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6547         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6548         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6549         macros.
6550
6551 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6552
6553         PR symtab/24423:
6554         * source.c (print_source_lines_base): Advance "iter" when a
6555         control character is seen.
6556
6557 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6558
6559         * inferior.h (struct infcall_suspend_state_deleter):
6560         Catch exception in destructor to avoid crash.
6561
6562 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6563
6564         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6565         close to the add_com "shell".
6566
6567 2019-04-18  Tom Tromey  <tromey@adacore.com>
6568
6569         * process-stratum-target.h (class process_stratum_target)
6570         <stratum>: Add "final".
6571
6572 2019-04-17  Tom Tromey  <tromey@adacore.com>
6573
6574         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6575         against nullptr before use.
6576
6577 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6578
6579         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6580
6581 2019-04-17  Jim Wilson  <jimw@sifive.com>
6582             Andrew Burgess  <andrew.burgess@embecosm.com>
6583
6584         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6585         code read might fail, assume 4-byte breakpoint in that case.
6586
6587 2019-04-15  Leszek Swirski  <leszeks@google.com>
6588
6589         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6590         rather than a hand-rolled POD check when checking for forced MEMORY
6591         classification.
6592
6593 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6594
6595         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6596         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6597         function.
6598         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6599         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6600         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6601         declaration.
6602
6603 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6604
6605         * aarch64-linux-nat.c
6606         (aarch64_linux_nat_target::thread_architecture): Add override.
6607         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6608         each VQ.
6609
6610 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6611
6612         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6613
6614 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6615
6616         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6617         target types of size 96-bits, add some additional comments, and
6618         check that the builtin type we found was the correct size.
6619
6620 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6621
6622         * utils.c (prompt_for_continue): Don't restore the styling at the
6623         end, as applied_style has the wrong value.  This fixes styling in
6624         long lists of file names that are interrupted by the "Continue?"
6625         prompt.
6626
6627 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6628
6629         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6630         * c-lang.c (c_language_defn): Likewise.
6631         (cplus_language_defn): Likewise.
6632         (asm_language_defn): Likewise.
6633         (minimal_language_defn): Likewise.
6634         * d-lang.c (d_language_defn): Likewise.
6635         * f-lang.c (f_language_defn): Likewise.
6636         * go-lang.c (go_language_defn): Likewise.
6637         * language.c (unknown_language_defn): Likewise.
6638         (auto_language_defn): Likewise.
6639         * language.h (struct language_defn): Remove la_magic field.
6640         (LANG_MAGIC): Delete.
6641         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6642         * objc-lang.c (objc_language_defn): Likewise.
6643         * opencl-lang.c (opencl_language_defn): Likewise.
6644         * p-lang.c (pascal_language_defn): Likewise.
6645         * rust-lang.c (rust_language_defn): Likewise.
6646
6647 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         * riscv-tdep.c (riscv_type_align): New function.
6650         (riscv_type_alignment): Delete.
6651         (riscv_arg_location): Use 'type_align'.
6652         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6653
6654 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * gdbtypes.c (type_align): A struct with no non-static fields also
6657         has alignment of 1.
6658
6659 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6660
6661         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6662         component to 0.
6663         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6664         member.
6665         (riscv_struct_info::analyse): New implementation using new
6666         analyse_inner member function.
6667         (riscv_struct_info::field_offset): New member function.
6668         (riscv_struct_info::m_offsets): New member variable.
6669         (riscv_struct_info::analyse_inner): New private member function,
6670         takes the old implementation of riscv_struct_info::analyse but
6671         extended to track field offsets.
6672         (riscv_call_arg_struct): Update the struct folding special cases
6673         to handle cases where empty C++ structs, which are non-zero
6674         length, are found.
6675         (riscv_arg_location): Initialise the length of each location, a
6676         non-zero length now indicates the location is in use.
6677         (riscv_push_dummy_call): Allow for the first location having a
6678         non-zero offset when setting up arguments.
6679         (riscv_return_value): Likewise, but for return values.
6680
6681 2019-04-11  Tom Tromey  <tromey@adacore.com>
6682
6683         * utils.c (internal_vproblem): Make "msg" const.
6684
6685 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6686
6687         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6688         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6689         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6690         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6691
6692 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6693
6694         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6695         function.
6696         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6697         of amd64_collect_native_gregset.
6698         (amd64_linux_nat_target::store_registers): Likewise.
6699
6700 2019-04-10  Tom Tromey  <tom@tromey.com>
6701
6702         * symtab.c (lookup_global_symbol_from_objfile)
6703         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6704         * objfiles.h (class separate_debug_iterator): New.
6705         (class separate_debug_range): New.
6706         (struct objfile) <separate_debug_objfiles>: New method.
6707         (objfile_separate_debug_iterate): Don't declare.
6708         * objfiles.c (separate_debug_iterator::operator++): Rename from
6709         objfile_separate_debug_iterate.
6710         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6711         iterator.
6712         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6713         iterator.
6714
6715 2019-04-10  Tom Tromey  <tom@tromey.com>
6716
6717         * symfile.c (reread_symbols): Remove old comment.
6718         * objfiles.c (free_all_objfiles): Fix a typo.
6719
6720 2019-04-10  Tom Tromey  <tom@tromey.com>
6721
6722         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6723         * minsyms.c (lookup_minimal_symbol): Use foreach.
6724         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6725         (lookup_minimal_symbol_solib_trampoline): Likewise.
6726         * symfile.c (reread_symbols): Use foreach.
6727
6728 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6729             Tom Tromey  <tromey@adacore.com>
6730
6731         PR rust/24414:
6732         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6733         (rust_lex_int_test): Change "value" to be LONGEST.
6734         (rust_lex_tests): Add test for long integer literal.
6735
6736 2019-04-09  Tom Tromey  <tromey@adacore.com>
6737
6738         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6739         to bool.
6740         (extended_remote_target::attach): Update.
6741         (remote_target::remote_notice_new_inferior): Update.
6742         (remote_target::add_current_inferior_and_thread): Update.
6743         * inferior.c (exit_inferior_1): Use "false".
6744         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6745
6746 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6747
6748         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6749         the "start" command.
6750
6751 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6752
6753         * python/py-inferior.c (infpy_thread_from_thread_handle):
6754         Adjust comments to reflect renaming of thread_from_thread_handle
6755         to thread_from_handle.  Adjust keywords.  Fix type error message.
6756         (inferior_object_methods): Add thread_from_handle.  Retain
6757         thread_from_thread_handle, but mark it as deprecated.
6758
6759 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6760
6761         * gdbthread.h (find_thread_by_handle): Revise declaration.
6762         * thread.c (find_thread_by_handle): Likewise.  Adjust
6763         implementation too.
6764         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6765         support for buffer objects as handles.
6766
6767 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6768
6769         * python/py-infthread.c (thpy_thread_handle): New function.
6770         (thread_object_methods): Register thpy_thread_handle.
6771
6772 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6773
6774         * gdbthread.h (thread_to_thread_handle): Declare.
6775         * thread.c (gdbtypes.h): Include.
6776         (thread_to_thread_handle): New function.
6777
6778         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6779         (target_thread_info_to_thread_handle): Declare.
6780         * target.c (target_thread_info_to_thread_handle): New function.
6781         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6782         * target-delegates.c: Regenerate.
6783
6784         * linux-thread-db.c (class thread_db_target): Add method
6785         thread_info_to_thread_handle.
6786         (thread_db_target::thread_info_to_thread_handle): Define.
6787         * remote.c (class remote_target): Add new method
6788         thread_info_to_thread_handle.
6789         (remote_target::thread_info_to_thread_handle): Define.
6790
6791 2019-04-08  Pedro Alves  <palves@redhat.com>
6792
6793         * common/common-exceptions.c (throw_exception): Don't create
6794         named object to throw; throw directly.
6795         (throw_it): Likewise.  Don't initialize gdb_exception::message
6796         here, with new; pass FMT and AP to the ctor instead.
6797         * common/common-exceptions.h: Include <string>.
6798         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6799         const char *, va_list)): New ctor.  Use std::make_shared.
6800         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6801         errors)): Delete.
6802         (gdb_exception_error::gdb_exception_error(enum errors, const char
6803         *, va_list)): New.
6804         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6805         Add assertion.
6806         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6807         errors)): Delete.
6808         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6809         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6810         Add assertion.
6811
6812 2019-04-08  Tom Tromey  <tom@tromey.com>
6813
6814         * valops.c (value_rtti_indirect_type): Replace throw_exception
6815         with throw.
6816         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6817         with throw.
6818         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6819         throw.
6820         * target.c (target_translate_tls_address): Replace throw_exception
6821         with throw.
6822         * stack.c (frame_apply_command_count): Replace throw_exception
6823         with throw.
6824         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6825         throw.
6826         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6827         with throw.
6828         * rs6000-tdep.c (rs6000_frame_cache)
6829         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6830         * remote.c: Replace throw_exception with throw.
6831         * record-full.c (record_full_message, record_full_wait_1)
6832         (record_full_restore): Replace throw_exception with throw.
6833         * record-btrace.c:
6834         (get_thread_current_frame_id, record_btrace_start_replaying)
6835         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6836         (cmd_record_btrace_start): Replace throw_exception with throw.
6837         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6838         throw.
6839         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6840         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6841         * linespec.c:
6842         (find_linespec_symbols): Replace throw_exception with throw.
6843         * infrun.c (displaced_step_prepare, resume): Replace
6844         throw_exception with throw.
6845         * infcmd.c (post_create_inferior): Replace throw_exception with
6846         throw.
6847         * inf-loop.c (inferior_event_handler): Replace throw_exception
6848         with throw.
6849         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6850         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6851         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6852         (get_prev_frame_always, get_frame_pc_if_available)
6853         (get_frame_address_in_block_if_available, get_frame_language):
6854         Replace throw_exception with throw.
6855         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6856         throw_exception with throw.
6857         * eval.c (fetch_subexp_value, evaluate_var_value)
6858         (evaluate_funcall, evaluate_subexp_standard): Replace
6859         throw_exception with throw.
6860         * dwarf2loc.c (call_site_find_chain)
6861         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6862         Replace throw_exception with throw.
6863         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6864         with throw.
6865         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6866         throw.
6867         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6868         * completer.c (complete_line_internal): Replace throw_exception
6869         with throw.
6870         * compile/compile-object-run.c (compile_object_run): Replace
6871         throw_exception with throw.
6872         * cli/cli-script.c (process_next_line): Replace throw_exception
6873         with throw.
6874         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6875         (btrace_enable, btrace_maint_update_pt_packets): Replace
6876         throw_exception with throw.
6877         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6878         throw_exception with throw.
6879         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6880         throw_exception with throw.
6881         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6882         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6883         * aarch64-tdep.c (aarch64_make_prologue_cache)
6884         (aarch64_make_stub_cache): Replace throw_exception with throw.
6885
6886 2019-04-08  Tom Tromey  <tom@tromey.com>
6887
6888         * common/common-exceptions.c (throw_exception): Rename from
6889         throw_exception_cxx.  Remove old copy.  Make argument const.
6890         (throw_it): Create and throw exception objects directly.
6891         * common/common-exceptions.h (throw_exception): Make argument
6892         const.
6893         (struct gdb_exception_error): Add constructor.
6894         (struct gdb_exception_quit): Add constructor.
6895
6896 2019-04-08  Tom Tromey  <tom@tromey.com>
6897
6898         * common/common-exceptions.h (exception_rethrow): Don't declare.
6899         (TRY_SJLJ): Update comment.
6900         (TRY, CATCH, END_CATCH): Remove.
6901         * common/common-exceptions.c (exception_rethrow): Remove.
6902
6903 2019-04-08  Tom Tromey  <tom@tromey.com>
6904
6905         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6906         Remove.
6907         (gdb_exception_error): Rename from
6908         gdb_exception_RETURN_MASK_ERROR.
6909         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6910         (gdb_quit_bad_alloc): Update.
6911         * aarch64-tdep.c: Update.
6912         * ada-lang.c: Update.
6913         * ada-typeprint.c: Update.
6914         * ada-valprint.c: Update.
6915         * amd64-tdep.c: Update.
6916         * arch-utils.c: Update.
6917         * break-catch-throw.c: Update.
6918         * breakpoint.c: Update.
6919         * btrace.c: Update.
6920         * c-varobj.c: Update.
6921         * cli/cli-cmds.c: Update.
6922         * cli/cli-interp.c: Update.
6923         * cli/cli-script.c: Update.
6924         * common/common-exceptions.c: Update.
6925         * common/new-op.c: Update.
6926         * common/selftest.c: Update.
6927         * compile/compile-c-symbols.c: Update.
6928         * compile/compile-cplus-symbols.c: Update.
6929         * compile/compile-object-load.c: Update.
6930         * compile/compile-object-run.c: Update.
6931         * completer.c: Update.
6932         * corelow.c: Update.
6933         * cp-abi.c: Update.
6934         * cp-support.c: Update.
6935         * cp-valprint.c: Update.
6936         * darwin-nat.c: Update.
6937         * disasm-selftests.c: Update.
6938         * dtrace-probe.c: Update.
6939         * dwarf-index-cache.c: Update.
6940         * dwarf-index-write.c: Update.
6941         * dwarf2-frame-tailcall.c: Update.
6942         * dwarf2-frame.c: Update.
6943         * dwarf2loc.c: Update.
6944         * dwarf2read.c: Update.
6945         * eval.c: Update.
6946         * event-loop.c: Update.
6947         * event-top.c: Update.
6948         * exec.c: Update.
6949         * f-valprint.c: Update.
6950         * fbsd-tdep.c: Update.
6951         * frame-unwind.c: Update.
6952         * frame.c: Update.
6953         * gdbtypes.c: Update.
6954         * gnu-v3-abi.c: Update.
6955         * guile/guile-internal.h: Update.
6956         * guile/scm-block.c: Update.
6957         * guile/scm-breakpoint.c: Update.
6958         * guile/scm-cmd.c: Update.
6959         * guile/scm-disasm.c: Update.
6960         * guile/scm-frame.c: Update.
6961         * guile/scm-lazy-string.c: Update.
6962         * guile/scm-math.c: Update.
6963         * guile/scm-param.c: Update.
6964         * guile/scm-ports.c: Update.
6965         * guile/scm-pretty-print.c: Update.
6966         * guile/scm-symbol.c: Update.
6967         * guile/scm-symtab.c: Update.
6968         * guile/scm-type.c: Update.
6969         * guile/scm-value.c: Update.
6970         * i386-linux-tdep.c: Update.
6971         * i386-tdep.c: Update.
6972         * inf-loop.c: Update.
6973         * infcall.c: Update.
6974         * infcmd.c: Update.
6975         * infrun.c: Update.
6976         * jit.c: Update.
6977         * language.c: Update.
6978         * linespec.c: Update.
6979         * linux-fork.c: Update.
6980         * linux-nat.c: Update.
6981         * linux-tdep.c: Update.
6982         * linux-thread-db.c: Update.
6983         * main.c: Update.
6984         * mi/mi-cmd-break.c: Update.
6985         * mi/mi-cmd-stack.c: Update.
6986         * mi/mi-interp.c: Update.
6987         * mi/mi-main.c: Update.
6988         * objc-lang.c: Update.
6989         * p-valprint.c: Update.
6990         * parse.c: Update.
6991         * ppc-linux-tdep.c: Update.
6992         * printcmd.c: Update.
6993         * python/py-arch.c: Update.
6994         * python/py-breakpoint.c: Update.
6995         * python/py-cmd.c: Update.
6996         * python/py-finishbreakpoint.c: Update.
6997         * python/py-frame.c: Update.
6998         * python/py-framefilter.c: Update.
6999         * python/py-gdb-readline.c: Update.
7000         * python/py-inferior.c: Update.
7001         * python/py-infthread.c: Update.
7002         * python/py-lazy-string.c: Update.
7003         * python/py-linetable.c: Update.
7004         * python/py-objfile.c: Update.
7005         * python/py-param.c: Update.
7006         * python/py-prettyprint.c: Update.
7007         * python/py-progspace.c: Update.
7008         * python/py-record-btrace.c: Update.
7009         * python/py-record.c: Update.
7010         * python/py-symbol.c: Update.
7011         * python/py-type.c: Update.
7012         * python/py-unwind.c: Update.
7013         * python/py-utils.c: Update.
7014         * python/py-value.c: Update.
7015         * python/python.c: Update.
7016         * record-btrace.c: Update.
7017         * record-full.c: Update.
7018         * remote-fileio.c: Update.
7019         * remote.c: Update.
7020         * riscv-tdep.c: Update.
7021         * rs6000-aix-tdep.c: Update.
7022         * rs6000-tdep.c: Update.
7023         * rust-exp.y: Update.
7024         * rust-lang.c: Update.
7025         * s390-tdep.c: Update.
7026         * selftest-arch.c: Update.
7027         * solib-dsbt.c: Update.
7028         * solib-frv.c: Update.
7029         * solib-spu.c: Update.
7030         * solib-svr4.c: Update.
7031         * solib.c: Update.
7032         * sparc64-linux-tdep.c: Update.
7033         * stack.c: Update.
7034         * symfile-mem.c: Update.
7035         * symmisc.c: Update.
7036         * target.c: Update.
7037         * thread.c: Update.
7038         * top.c: Update.
7039         * tracefile-tfile.c: Update.
7040         * tui/tui.c: Update.
7041         * typeprint.c: Update.
7042         * unittests/cli-utils-selftests.c: Update.
7043         * unittests/parse-connection-spec-selftests.c: Update.
7044         * valops.c: Update.
7045         * valprint.c: Update.
7046         * value.c: Update.
7047         * varobj.c: Update.
7048         * windows-nat.c: Update.
7049         * x86-linux-nat.c: Update.
7050         * xml-support.c: Update.
7051
7052 2019-04-08  Tom Tromey  <tom@tromey.com>
7053
7054         * xml-support.c: Use C++ exception handling.
7055         * x86-linux-nat.c: Use C++ exception handling.
7056         * windows-nat.c: Use C++ exception handling.
7057         * varobj.c: Use C++ exception handling.
7058         * value.c: Use C++ exception handling.
7059         * valprint.c: Use C++ exception handling.
7060         * valops.c: Use C++ exception handling.
7061         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7062         handling.
7063         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7064         * typeprint.c: Use C++ exception handling.
7065         * tui/tui.c: Use C++ exception handling.
7066         * tracefile-tfile.c: Use C++ exception handling.
7067         * top.c: Use C++ exception handling.
7068         * thread.c: Use C++ exception handling.
7069         * target.c: Use C++ exception handling.
7070         * symmisc.c: Use C++ exception handling.
7071         * symfile-mem.c: Use C++ exception handling.
7072         * stack.c: Use C++ exception handling.
7073         * sparc64-linux-tdep.c: Use C++ exception handling.
7074         * solib.c: Use C++ exception handling.
7075         * solib-svr4.c: Use C++ exception handling.
7076         * solib-spu.c: Use C++ exception handling.
7077         * solib-frv.c: Use C++ exception handling.
7078         * solib-dsbt.c: Use C++ exception handling.
7079         * selftest-arch.c: Use C++ exception handling.
7080         * s390-tdep.c: Use C++ exception handling.
7081         * rust-lang.c: Use C++ exception handling.
7082         * rust-exp.y: Use C++ exception handling.
7083         * rs6000-tdep.c: Use C++ exception handling.
7084         * rs6000-aix-tdep.c: Use C++ exception handling.
7085         * riscv-tdep.c: Use C++ exception handling.
7086         * remote.c: Use C++ exception handling.
7087         * remote-fileio.c: Use C++ exception handling.
7088         * record-full.c: Use C++ exception handling.
7089         * record-btrace.c: Use C++ exception handling.
7090         * python/python.c: Use C++ exception handling.
7091         * python/py-value.c: Use C++ exception handling.
7092         * python/py-utils.c: Use C++ exception handling.
7093         * python/py-unwind.c: Use C++ exception handling.
7094         * python/py-type.c: Use C++ exception handling.
7095         * python/py-symbol.c: Use C++ exception handling.
7096         * python/py-record.c: Use C++ exception handling.
7097         * python/py-record-btrace.c: Use C++ exception handling.
7098         * python/py-progspace.c: Use C++ exception handling.
7099         * python/py-prettyprint.c: Use C++ exception handling.
7100         * python/py-param.c: Use C++ exception handling.
7101         * python/py-objfile.c: Use C++ exception handling.
7102         * python/py-linetable.c: Use C++ exception handling.
7103         * python/py-lazy-string.c: Use C++ exception handling.
7104         * python/py-infthread.c: Use C++ exception handling.
7105         * python/py-inferior.c: Use C++ exception handling.
7106         * python/py-gdb-readline.c: Use C++ exception handling.
7107         * python/py-framefilter.c: Use C++ exception handling.
7108         * python/py-frame.c: Use C++ exception handling.
7109         * python/py-finishbreakpoint.c: Use C++ exception handling.
7110         * python/py-cmd.c: Use C++ exception handling.
7111         * python/py-breakpoint.c: Use C++ exception handling.
7112         * python/py-arch.c: Use C++ exception handling.
7113         * printcmd.c: Use C++ exception handling.
7114         * ppc-linux-tdep.c: Use C++ exception handling.
7115         * parse.c: Use C++ exception handling.
7116         * p-valprint.c: Use C++ exception handling.
7117         * objc-lang.c: Use C++ exception handling.
7118         * mi/mi-main.c: Use C++ exception handling.
7119         * mi/mi-interp.c: Use C++ exception handling.
7120         * mi/mi-cmd-stack.c: Use C++ exception handling.
7121         * mi/mi-cmd-break.c: Use C++ exception handling.
7122         * main.c: Use C++ exception handling.
7123         * linux-thread-db.c: Use C++ exception handling.
7124         * linux-tdep.c: Use C++ exception handling.
7125         * linux-nat.c: Use C++ exception handling.
7126         * linux-fork.c: Use C++ exception handling.
7127         * linespec.c: Use C++ exception handling.
7128         * language.c: Use C++ exception handling.
7129         * jit.c: Use C++ exception handling.
7130         * infrun.c: Use C++ exception handling.
7131         * infcmd.c: Use C++ exception handling.
7132         * infcall.c: Use C++ exception handling.
7133         * inf-loop.c: Use C++ exception handling.
7134         * i386-tdep.c: Use C++ exception handling.
7135         * i386-linux-tdep.c: Use C++ exception handling.
7136         * guile/scm-value.c: Use C++ exception handling.
7137         * guile/scm-type.c: Use C++ exception handling.
7138         * guile/scm-symtab.c: Use C++ exception handling.
7139         * guile/scm-symbol.c: Use C++ exception handling.
7140         * guile/scm-pretty-print.c: Use C++ exception handling.
7141         * guile/scm-ports.c: Use C++ exception handling.
7142         * guile/scm-param.c: Use C++ exception handling.
7143         * guile/scm-math.c: Use C++ exception handling.
7144         * guile/scm-lazy-string.c: Use C++ exception handling.
7145         * guile/scm-frame.c: Use C++ exception handling.
7146         * guile/scm-disasm.c: Use C++ exception handling.
7147         * guile/scm-cmd.c: Use C++ exception handling.
7148         * guile/scm-breakpoint.c: Use C++ exception handling.
7149         * guile/scm-block.c: Use C++ exception handling.
7150         * guile/guile-internal.h: Use C++ exception handling.
7151         * gnu-v3-abi.c: Use C++ exception handling.
7152         * gdbtypes.c: Use C++ exception handling.
7153         * frame.c: Use C++ exception handling.
7154         * frame-unwind.c: Use C++ exception handling.
7155         * fbsd-tdep.c: Use C++ exception handling.
7156         * f-valprint.c: Use C++ exception handling.
7157         * exec.c: Use C++ exception handling.
7158         * event-top.c: Use C++ exception handling.
7159         * event-loop.c: Use C++ exception handling.
7160         * eval.c: Use C++ exception handling.
7161         * dwarf2read.c: Use C++ exception handling.
7162         * dwarf2loc.c: Use C++ exception handling.
7163         * dwarf2-frame.c: Use C++ exception handling.
7164         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7165         * dwarf-index-write.c: Use C++ exception handling.
7166         * dwarf-index-cache.c: Use C++ exception handling.
7167         * dtrace-probe.c: Use C++ exception handling.
7168         * disasm-selftests.c: Use C++ exception handling.
7169         * darwin-nat.c: Use C++ exception handling.
7170         * cp-valprint.c: Use C++ exception handling.
7171         * cp-support.c: Use C++ exception handling.
7172         * cp-abi.c: Use C++ exception handling.
7173         * corelow.c: Use C++ exception handling.
7174         * completer.c: Use C++ exception handling.
7175         * compile/compile-object-run.c: Use C++ exception handling.
7176         * compile/compile-object-load.c: Use C++ exception handling.
7177         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7178         * compile/compile-c-symbols.c: Use C++ exception handling.
7179         * common/selftest.c: Use C++ exception handling.
7180         * common/new-op.c: Use C++ exception handling.
7181         * cli/cli-script.c: Use C++ exception handling.
7182         * cli/cli-interp.c: Use C++ exception handling.
7183         * cli/cli-cmds.c: Use C++ exception handling.
7184         * c-varobj.c: Use C++ exception handling.
7185         * btrace.c: Use C++ exception handling.
7186         * breakpoint.c: Use C++ exception handling.
7187         * break-catch-throw.c: Use C++ exception handling.
7188         * arch-utils.c: Use C++ exception handling.
7189         * amd64-tdep.c: Use C++ exception handling.
7190         * ada-valprint.c: Use C++ exception handling.
7191         * ada-typeprint.c: Use C++ exception handling.
7192         * ada-lang.c: Use C++ exception handling.
7193         * aarch64-tdep.c: Use C++ exception handling.
7194
7195 2019-04-08  Tom Tromey  <tom@tromey.com>
7196
7197         * xml-support.c (gdb_xml_parser::parse): Update.
7198         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7199         * value.c (show_convenience): Update.
7200         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7201         (test_parse_flags_qcs): Update.
7202         * thread.c (thr_try_catch_cmd): Update.
7203         * target.c (target_translate_tls_address): Update.
7204         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7205         (info_frame_command_core, frame_apply_command_count): Update.
7206         * rust-exp.y (rust_lex_exception_test): Update.
7207         * riscv-tdep.c (riscv_print_one_register_info): Update.
7208         * remote.c (remote_target::enable_btrace): Update.
7209         * record-btrace.c (record_btrace_enable_warn): Update.
7210         * python/py-utils.c (gdbpy_convert_exception): Update.
7211         * printcmd.c (do_one_display, print_variable_and_value): Update.
7212         * mi/mi-main.c (mi_print_exception): Update.
7213         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7214         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7215         * linux-nat.c (linux_nat_target::attach): Update.
7216         * linux-fork.c (class scoped_switch_fork_info): Update.
7217         * infrun.c (displaced_step_prepare): Update.
7218         * infcall.c (call_function_by_hand_dummy): Update.
7219         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7220         * gnu-v3-abi.c (print_one_vtable): Update.
7221         * frame.c (get_prev_frame_always): Update.
7222         * f-valprint.c (info_common_command_for_block): Update.
7223         * exec.c (try_open_exec_file): Update.
7224         * exceptions.c (print_exception, exception_print)
7225         (exception_fprintf, exception_print_same): Update.
7226         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7227         * dwarf-index-cache.c (index_cache::store)
7228         (index_cache::lookup_gdb_index): Update.
7229         * darwin-nat.c (maybe_cache_shell): Update.
7230         * cp-valprint.c (cp_print_value_fields): Update.
7231         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7232         (gcc_cplus_symbol_address): Update.
7233         * compile/compile-c-symbols.c (gcc_convert_symbol)
7234         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7235         * common/selftest.c: Update.
7236         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7237         a std::string.
7238         (exception_try_scope_entry, exception_try_scope_exit): Don't
7239         declare.
7240         (struct exception_try_scope): Remove.
7241         (TRY): Don't use exception_try_scope.
7242         (struct gdb_exception): Add constructor, operator=.
7243         <what>: New method.
7244         (struct gdb_exception_RETURN_MASK_ALL)
7245         (struct gdb_exception_RETURN_MASK_ERROR)
7246         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7247         (struct gdb_quit_bad_alloc): Update.
7248         * common/common-exceptions.c (exception_none): Change
7249         initializer.
7250         (struct catcher) <state, exception>: Initialize inline.
7251         <prev>: Remove member.
7252         (current_catcher): Remove.
7253         (catchers): New global.
7254         (exceptions_state_mc_init): Simplify.
7255         (catcher_pop): Remove.
7256         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7257         (try_scope_depth, exception_try_scope_entry)
7258         (exception_try_scope_exit): Remove.
7259         (throw_exception_sjlj): Update.
7260         (exception_messages, exception_messages_size): Remove.
7261         (throw_it): Simplify.
7262         (gdb_exception_sliced_copy): Remove.
7263         (throw_exception_cxx): Update.
7264         * cli/cli-script.c (script_from_file): Update.
7265         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7266         Update.
7267         * ada-valprint.c (ada_val_print): Update.
7268         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7269         (create_excep_cond_exprs): Update.
7270
7271 2019-04-08  Tom Tromey  <tom@tromey.com>
7272
7273         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7274         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7275         (TRY, CATCH, END_CATCH): Remove some definitions.
7276         * common/common-exceptions.c: Don't use GDB_XCPT.
7277         (catcher_list_size): Remove.
7278         (throw_exception, throw_it): Simplify.
7279
7280 2019-04-05  Tom Tromey  <tom@tromey.com>
7281
7282         Revert the header-sorting patch.
7283         * ft32-tdep.c: Revert.
7284         * frv-tdep.c: Revert.
7285         * frv-linux-tdep.c: Revert.
7286         * frame.c: Revert.
7287         * frame-unwind.c: Revert.
7288         * frame-base.c: Revert.
7289         * fork-child.c: Revert.
7290         * findvar.c: Revert.
7291         * findcmd.c: Revert.
7292         * filesystem.c: Revert.
7293         * filename-seen-cache.h: Revert.
7294         * filename-seen-cache.c: Revert.
7295         * fbsd-tdep.c: Revert.
7296         * fbsd-nat.h: Revert.
7297         * fbsd-nat.c: Revert.
7298         * f-valprint.c: Revert.
7299         * f-typeprint.c: Revert.
7300         * f-lang.c: Revert.
7301         * extension.h: Revert.
7302         * extension.c: Revert.
7303         * extension-priv.h: Revert.
7304         * expprint.c: Revert.
7305         * exec.h: Revert.
7306         * exec.c: Revert.
7307         * exceptions.c: Revert.
7308         * event-top.c: Revert.
7309         * event-loop.c: Revert.
7310         * eval.c: Revert.
7311         * elfread.c: Revert.
7312         * dwarf2read.h: Revert.
7313         * dwarf2read.c: Revert.
7314         * dwarf2loc.c: Revert.
7315         * dwarf2expr.h: Revert.
7316         * dwarf2expr.c: Revert.
7317         * dwarf2-frame.c: Revert.
7318         * dwarf2-frame-tailcall.c: Revert.
7319         * dwarf-index-write.h: Revert.
7320         * dwarf-index-write.c: Revert.
7321         * dwarf-index-common.c: Revert.
7322         * dwarf-index-cache.h: Revert.
7323         * dwarf-index-cache.c: Revert.
7324         * dummy-frame.c: Revert.
7325         * dtrace-probe.c: Revert.
7326         * disasm.h: Revert.
7327         * disasm.c: Revert.
7328         * disasm-selftests.c: Revert.
7329         * dictionary.c: Revert.
7330         * dicos-tdep.c: Revert.
7331         * demangle.c: Revert.
7332         * dcache.h: Revert.
7333         * dcache.c: Revert.
7334         * darwin-nat.h: Revert.
7335         * darwin-nat.c: Revert.
7336         * darwin-nat-info.c: Revert.
7337         * d-valprint.c: Revert.
7338         * d-namespace.c: Revert.
7339         * d-lang.c: Revert.
7340         * ctf.c: Revert.
7341         * csky-tdep.c: Revert.
7342         * csky-linux-tdep.c: Revert.
7343         * cris-tdep.c: Revert.
7344         * cris-linux-tdep.c: Revert.
7345         * cp-valprint.c: Revert.
7346         * cp-support.c: Revert.
7347         * cp-namespace.c: Revert.
7348         * cp-abi.c: Revert.
7349         * corelow.c: Revert.
7350         * corefile.c: Revert.
7351         * continuations.c: Revert.
7352         * completer.h: Revert.
7353         * completer.c: Revert.
7354         * complaints.c: Revert.
7355         * coffread.c: Revert.
7356         * coff-pe-read.c: Revert.
7357         * cli-out.h: Revert.
7358         * cli-out.c: Revert.
7359         * charset.c: Revert.
7360         * c-varobj.c: Revert.
7361         * c-valprint.c: Revert.
7362         * c-typeprint.c: Revert.
7363         * c-lang.c: Revert.
7364         * buildsym.c: Revert.
7365         * buildsym-legacy.c: Revert.
7366         * build-id.h: Revert.
7367         * build-id.c: Revert.
7368         * btrace.c: Revert.
7369         * bsd-uthread.c: Revert.
7370         * breakpoint.h: Revert.
7371         * breakpoint.c: Revert.
7372         * break-catch-throw.c: Revert.
7373         * break-catch-syscall.c: Revert.
7374         * break-catch-sig.c: Revert.
7375         * blockframe.c: Revert.
7376         * block.c: Revert.
7377         * bfin-tdep.c: Revert.
7378         * bfin-linux-tdep.c: Revert.
7379         * bfd-target.c: Revert.
7380         * bcache.c: Revert.
7381         * ax-general.c: Revert.
7382         * ax-gdb.h: Revert.
7383         * ax-gdb.c: Revert.
7384         * avr-tdep.c: Revert.
7385         * auxv.c: Revert.
7386         * auto-load.c: Revert.
7387         * arm-wince-tdep.c: Revert.
7388         * arm-tdep.c: Revert.
7389         * arm-symbian-tdep.c: Revert.
7390         * arm-pikeos-tdep.c: Revert.
7391         * arm-obsd-tdep.c: Revert.
7392         * arm-nbsd-tdep.c: Revert.
7393         * arm-nbsd-nat.c: Revert.
7394         * arm-linux-tdep.c: Revert.
7395         * arm-linux-nat.c: Revert.
7396         * arm-fbsd-tdep.c: Revert.
7397         * arm-fbsd-nat.c: Revert.
7398         * arm-bsd-tdep.c: Revert.
7399         * arch-utils.c: Revert.
7400         * arc-tdep.c: Revert.
7401         * arc-newlib-tdep.c: Revert.
7402         * annotate.h: Revert.
7403         * annotate.c: Revert.
7404         * amd64-windows-tdep.c: Revert.
7405         * amd64-windows-nat.c: Revert.
7406         * amd64-tdep.c: Revert.
7407         * amd64-sol2-tdep.c: Revert.
7408         * amd64-obsd-tdep.c: Revert.
7409         * amd64-obsd-nat.c: Revert.
7410         * amd64-nbsd-tdep.c: Revert.
7411         * amd64-nbsd-nat.c: Revert.
7412         * amd64-nat.c: Revert.
7413         * amd64-linux-tdep.c: Revert.
7414         * amd64-linux-nat.c: Revert.
7415         * amd64-fbsd-tdep.c: Revert.
7416         * amd64-fbsd-nat.c: Revert.
7417         * amd64-dicos-tdep.c: Revert.
7418         * amd64-darwin-tdep.c: Revert.
7419         * amd64-bsd-nat.c: Revert.
7420         * alpha-tdep.c: Revert.
7421         * alpha-obsd-tdep.c: Revert.
7422         * alpha-nbsd-tdep.c: Revert.
7423         * alpha-mdebug-tdep.c: Revert.
7424         * alpha-linux-tdep.c: Revert.
7425         * alpha-linux-nat.c: Revert.
7426         * alpha-bsd-tdep.c: Revert.
7427         * alpha-bsd-nat.c: Revert.
7428         * aix-thread.c: Revert.
7429         * agent.c: Revert.
7430         * addrmap.c: Revert.
7431         * ada-varobj.c: Revert.
7432         * ada-valprint.c: Revert.
7433         * ada-typeprint.c: Revert.
7434         * ada-tasks.c: Revert.
7435         * ada-lang.c: Revert.
7436         * aarch64-tdep.c: Revert.
7437         * aarch64-ravenscar-thread.c: Revert.
7438         * aarch64-newlib-tdep.c: Revert.
7439         * aarch64-linux-tdep.c: Revert.
7440         * aarch64-linux-nat.c: Revert.
7441         * aarch64-fbsd-tdep.c: Revert.
7442         * aarch64-fbsd-nat.c: Revert.
7443         * aarch32-linux-nat.c: Revert.
7444
7445 2019-04-05  Tom Tromey  <tom@tromey.com>
7446
7447         * ft32-tdep.c: Sort headers.
7448         * frv-tdep.c: Sort headers.
7449         * frv-linux-tdep.c: Sort headers.
7450         * frame.c: Sort headers.
7451         * frame-unwind.c: Sort headers.
7452         * frame-base.c: Sort headers.
7453         * fork-child.c: Sort headers.
7454         * findvar.c: Sort headers.
7455         * findcmd.c: Sort headers.
7456         * filesystem.c: Sort headers.
7457         * filename-seen-cache.h: Sort headers.
7458         * filename-seen-cache.c: Sort headers.
7459         * fbsd-tdep.c: Sort headers.
7460         * fbsd-nat.h: Sort headers.
7461         * fbsd-nat.c: Sort headers.
7462         * f-valprint.c: Sort headers.
7463         * f-typeprint.c: Sort headers.
7464         * f-lang.c: Sort headers.
7465         * extension.h: Sort headers.
7466         * extension.c: Sort headers.
7467         * extension-priv.h: Sort headers.
7468         * expprint.c: Sort headers.
7469         * exec.h: Sort headers.
7470         * exec.c: Sort headers.
7471         * exceptions.c: Sort headers.
7472         * event-top.c: Sort headers.
7473         * event-loop.c: Sort headers.
7474         * eval.c: Sort headers.
7475         * elfread.c: Sort headers.
7476         * dwarf2read.h: Sort headers.
7477         * dwarf2read.c: Sort headers.
7478         * dwarf2loc.c: Sort headers.
7479         * dwarf2expr.h: Sort headers.
7480         * dwarf2expr.c: Sort headers.
7481         * dwarf2-frame.c: Sort headers.
7482         * dwarf2-frame-tailcall.c: Sort headers.
7483         * dwarf-index-write.h: Sort headers.
7484         * dwarf-index-write.c: Sort headers.
7485         * dwarf-index-common.c: Sort headers.
7486         * dwarf-index-cache.h: Sort headers.
7487         * dwarf-index-cache.c: Sort headers.
7488         * dummy-frame.c: Sort headers.
7489         * dtrace-probe.c: Sort headers.
7490         * disasm.h: Sort headers.
7491         * disasm.c: Sort headers.
7492         * disasm-selftests.c: Sort headers.
7493         * dictionary.c: Sort headers.
7494         * dicos-tdep.c: Sort headers.
7495         * demangle.c: Sort headers.
7496         * dcache.h: Sort headers.
7497         * dcache.c: Sort headers.
7498         * darwin-nat.h: Sort headers.
7499         * darwin-nat.c: Sort headers.
7500         * darwin-nat-info.c: Sort headers.
7501         * d-valprint.c: Sort headers.
7502         * d-namespace.c: Sort headers.
7503         * d-lang.c: Sort headers.
7504         * ctf.c: Sort headers.
7505         * csky-tdep.c: Sort headers.
7506         * csky-linux-tdep.c: Sort headers.
7507         * cris-tdep.c: Sort headers.
7508         * cris-linux-tdep.c: Sort headers.
7509         * cp-valprint.c: Sort headers.
7510         * cp-support.c: Sort headers.
7511         * cp-namespace.c: Sort headers.
7512         * cp-abi.c: Sort headers.
7513         * corelow.c: Sort headers.
7514         * corefile.c: Sort headers.
7515         * continuations.c: Sort headers.
7516         * completer.h: Sort headers.
7517         * completer.c: Sort headers.
7518         * complaints.c: Sort headers.
7519         * coffread.c: Sort headers.
7520         * coff-pe-read.c: Sort headers.
7521         * cli-out.h: Sort headers.
7522         * cli-out.c: Sort headers.
7523         * charset.c: Sort headers.
7524         * c-varobj.c: Sort headers.
7525         * c-valprint.c: Sort headers.
7526         * c-typeprint.c: Sort headers.
7527         * c-lang.c: Sort headers.
7528         * buildsym.c: Sort headers.
7529         * buildsym-legacy.c: Sort headers.
7530         * build-id.h: Sort headers.
7531         * build-id.c: Sort headers.
7532         * btrace.c: Sort headers.
7533         * bsd-uthread.c: Sort headers.
7534         * breakpoint.h: Sort headers.
7535         * breakpoint.c: Sort headers.
7536         * break-catch-throw.c: Sort headers.
7537         * break-catch-syscall.c: Sort headers.
7538         * break-catch-sig.c: Sort headers.
7539         * blockframe.c: Sort headers.
7540         * block.c: Sort headers.
7541         * bfin-tdep.c: Sort headers.
7542         * bfin-linux-tdep.c: Sort headers.
7543         * bfd-target.c: Sort headers.
7544         * bcache.c: Sort headers.
7545         * ax-general.c: Sort headers.
7546         * ax-gdb.h: Sort headers.
7547         * ax-gdb.c: Sort headers.
7548         * avr-tdep.c: Sort headers.
7549         * auxv.c: Sort headers.
7550         * auto-load.c: Sort headers.
7551         * arm-wince-tdep.c: Sort headers.
7552         * arm-tdep.c: Sort headers.
7553         * arm-symbian-tdep.c: Sort headers.
7554         * arm-pikeos-tdep.c: Sort headers.
7555         * arm-obsd-tdep.c: Sort headers.
7556         * arm-nbsd-tdep.c: Sort headers.
7557         * arm-nbsd-nat.c: Sort headers.
7558         * arm-linux-tdep.c: Sort headers.
7559         * arm-linux-nat.c: Sort headers.
7560         * arm-fbsd-tdep.c: Sort headers.
7561         * arm-fbsd-nat.c: Sort headers.
7562         * arm-bsd-tdep.c: Sort headers.
7563         * arch-utils.c: Sort headers.
7564         * arc-tdep.c: Sort headers.
7565         * arc-newlib-tdep.c: Sort headers.
7566         * annotate.h: Sort headers.
7567         * annotate.c: Sort headers.
7568         * amd64-windows-tdep.c: Sort headers.
7569         * amd64-windows-nat.c: Sort headers.
7570         * amd64-tdep.c: Sort headers.
7571         * amd64-sol2-tdep.c: Sort headers.
7572         * amd64-obsd-tdep.c: Sort headers.
7573         * amd64-obsd-nat.c: Sort headers.
7574         * amd64-nbsd-tdep.c: Sort headers.
7575         * amd64-nbsd-nat.c: Sort headers.
7576         * amd64-nat.c: Sort headers.
7577         * amd64-linux-tdep.c: Sort headers.
7578         * amd64-linux-nat.c: Sort headers.
7579         * amd64-fbsd-tdep.c: Sort headers.
7580         * amd64-fbsd-nat.c: Sort headers.
7581         * amd64-dicos-tdep.c: Sort headers.
7582         * amd64-darwin-tdep.c: Sort headers.
7583         * amd64-bsd-nat.c: Sort headers.
7584         * alpha-tdep.c: Sort headers.
7585         * alpha-obsd-tdep.c: Sort headers.
7586         * alpha-nbsd-tdep.c: Sort headers.
7587         * alpha-mdebug-tdep.c: Sort headers.
7588         * alpha-linux-tdep.c: Sort headers.
7589         * alpha-linux-nat.c: Sort headers.
7590         * alpha-bsd-tdep.c: Sort headers.
7591         * alpha-bsd-nat.c: Sort headers.
7592         * aix-thread.c: Sort headers.
7593         * agent.c: Sort headers.
7594         * addrmap.c: Sort headers.
7595         * ada-varobj.c: Sort headers.
7596         * ada-valprint.c: Sort headers.
7597         * ada-typeprint.c: Sort headers.
7598         * ada-tasks.c: Sort headers.
7599         * ada-lang.c: Sort headers.
7600         * aarch64-tdep.c: Sort headers.
7601         * aarch64-ravenscar-thread.c: Sort headers.
7602         * aarch64-newlib-tdep.c: Sort headers.
7603         * aarch64-linux-tdep.c: Sort headers.
7604         * aarch64-linux-nat.c: Sort headers.
7605         * aarch64-fbsd-tdep.c: Sort headers.
7606         * aarch64-fbsd-nat.c: Sort headers.
7607         * aarch32-linux-nat.c: Sort headers.
7608
7609 2019-04-04  Tom Tromey  <tom@tromey.com>
7610
7611         * varobj.c (varobj_create): Update.
7612         * rust-exp.y (struct rust_parser) <update_innermost_block,
7613         lookup_symbol>: New methods.
7614         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7615         Rename.
7616         (rust_parser::rust_lookup_type)
7617         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7618         * printcmd.c (display_command, do_one_display): Update.
7619         * parser-defs.h (struct parser_state) <parser_state>: Add
7620         "tracker" parameter.
7621         (block_tracker): New member.
7622         (class innermost_block_tracker) <innermost_block_tracker>: Add
7623         "types" parameter.
7624         <reset>: Remove method.
7625         (innermost_block): Don't declare.
7626         (null_post_parser): Update.
7627         * parse.c (innermost_block): Remove global.
7628         (write_dollar_variable): Update.
7629         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7630         Remove "tracker_types" parameter.
7631         (parse_expression): Add "tracker" parameter.
7632         (parse_expression_for_completion): Update.
7633         (null_post_parser): Add "tracker" parameter.
7634         * p-exp.y: Update rules.
7635         * m2-exp.y: Update rules.
7636         * language.h (struct language_defn) <la_post_parser>: Add
7637         "tracker" parameter.
7638         * go-exp.y: Update rules.
7639         * f-exp.y: Update rules.
7640         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7641         parameter.
7642         * d-exp.y: Update rules.
7643         * c-exp.y: Update rules.
7644         * breakpoint.c (set_breakpoint_condition): Create an
7645         innermost_block_tracker.
7646         (watch_command_1): Likewise.
7647         * ada-lang.c (resolve): Add "tracker" parameter.
7648         (resolve_subexp): Likewise.
7649         * ada-exp.y (write_var_from_sym): Update.
7650
7651 2019-04-04  Tom Tromey  <tom@tromey.com>
7652
7653         * type-stack.h: New file.
7654         * type-stack.c: New file.
7655         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7656         type-stack.h.
7657         (insert_into_type_stack, insert_type, push_type, push_type_int)
7658         (insert_type_address_space, pop_type, pop_type_int)
7659         (pop_typelist, pop_type_stack, append_type_stack)
7660         (push_type_stack, get_type_stack, push_typelist)
7661         (follow_type_instance_flags, follow_types): Don't declare.
7662         * parse.c (type_stack): Remove global.
7663         (parse_exp_in_context): Update.
7664         (insert_into_type_stack, insert_type, push_type, push_type_int)
7665         (insert_type_address_space, pop_type, pop_type_int)
7666         (pop_typelist, pop_type_stack, append_type_stack)
7667         (push_type_stack, get_type_stack, push_typelist)
7668         (follow_type_instance_flags, follow_types): Remove (moved to
7669         type-stack.c).
7670         * f-exp.y (type_stack): New global.
7671         Update rules.
7672         (push_kind_type, f_parse): Update.
7673         * d-exp.y (type_stack): New global.
7674         Update rules.
7675         (d_parse): Update.
7676         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7677         Update rules.
7678         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7679         (HFILES_NO_SRCDIR): Add type-stack.h.
7680
7681 2019-04-04  Tom Tromey  <tom@tromey.com>
7682
7683         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7684         (rust_parser::convert_ast_to_expression, rust_parse)
7685         (rust_lex_test_completion, rust_lex_tests): Update.
7686         * parser-defs.h (struct expr_completion_state): New.
7687         (struct parser_state) <parser_state>: Add completion parameter.
7688         <mark_struct_expression, mark_completion_tag>: New methods.
7689         <parse_completion, m_completion_state>: New members.
7690         (prefixify_expression, null_post_parser): Update.
7691         (mark_struct_expression, mark_completion_tag): Don't declare.
7692         * parse.c (parse_completion, expout_last_struct)
7693         (expout_tag_completion_type, expout_completion_name): Remove
7694         globals.
7695         (parser_state::mark_struct_expression)
7696         (parser_state::mark_completion_tag): Now methods.
7697         (prefixify_expression): Add last_struct parameter.
7698         (prefixify_subexp): Likewise.
7699         (parse_exp_1): Update.
7700         (parse_exp_in_context): Add cstate parameter.  Update.
7701         (parse_expression_for_completion): Create an
7702         expr_completion_state.
7703         (null_post_parser): Add "completion" parameter.
7704         * p-exp.y: Update rules.
7705         (yylex): Update.
7706         * language.h (struct language_defn) <la_post_parser>: Add
7707         "completing" parameter.
7708         * go-exp.y: Update rules.
7709         (lex_one_token): Update.
7710         * expression.h (parse_completion): Don't declare.
7711         * d-exp.y: Update rules.
7712         (lex_one_token): Update rules.
7713         * c-exp.y: Update rules.
7714         (lex_one_token): Update.
7715         * ada-lang.c (resolve): Add "parse_completion" parameter.
7716         (resolve_subexp): Likewise.
7717         (ada_resolve_function): Likewise.
7718
7719 2019-04-04  Tom Tromey  <tom@tromey.com>
7720
7721         * parser-defs.h (struct parser_state) <start_arglist,
7722         end_arglist>: New methods.
7723         <arglist_len, m_funcall_chain>: New members.
7724         (arglist_len, start_arglist, end_arglist): Don't declare.
7725         * parse.c (arglist_len, funcall_chain): Remove global.
7726         (start_arglist, end_arglist): Remove functions.
7727         (parse_exp_in_context): Update.
7728         * p-exp.y: Update rules.
7729         * m2-exp.y: Update rules.
7730         * go-exp.y: Update rules.
7731         * f-exp.y: Update rules.
7732         * d-exp.y: Update rules.
7733         * c-exp.y: Update rules.
7734
7735 2019-04-04  Tom Tromey  <tom@tromey.com>
7736
7737         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7738         lex_operator, push_back>: New methods.
7739         Update all rules.
7740         (rust_parser::lex_hex, lex_escape): Rename and update.
7741         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7742         (rust_parser::lex_operator): Rename and update.
7743         (rust_parser::lex_number, rustyylex, rustyyerror)
7744         (rust_lex_test_init, rust_lex_test_sequence)
7745         (rust_lex_test_push_back, rust_lex_tests): Update.
7746         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7747         parameter.
7748         <lexptr, prev_lexptr>: New members.
7749         (lexptr, prev_lexptr): Don't declare.
7750         * parse.c (lexptr, prev_lexptr): Remove globals.
7751         (parse_exp_in_context): Update.
7752         * p-exp.y (yylex, yyerror): Update.
7753         * m2-exp.y (parse_number, yylex, yyerror): Update.
7754         * go-exp.y (lex_one_token, yyerror): Update.
7755         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7756         * d-exp.y (lex_one_token, yyerror): Update.
7757         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7758         (lex_one_token, yyerror): Update.
7759         * ada-lex.l (YY_INPUT): Update.
7760         (rewind_to_char): Update.
7761         * ada-exp.y (yyerror): Update.
7762
7763 2019-04-04  Tom Tromey  <tom@tromey.com>
7764
7765         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7766         * parser-defs.h (struct parser_state) <parser_state>: Add new
7767         parameter.
7768         <comma_terminates>: New member.
7769         (comma_terminates): Don't declare global.
7770         * parse.c (comma_terminates): Remove global.
7771         (parse_exp_in_context): Update.
7772         * p-exp.y (yylex): Update.
7773         * m2-exp.y (yylex): Update.
7774         * go-exp.y (lex_one_token): Update.
7775         * f-exp.y (yylex): Update.
7776         * d-exp.y (lex_one_token): Update.
7777         * c-exp.y (lex_one_token): Update.
7778         * ada-lex.l: Update.
7779
7780 2019-04-04  Tom Tromey  <tom@tromey.com>
7781
7782         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7783         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7784         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7785         * parser-defs.h (paren_depth): Don't declare.
7786         * parse.c (paren_depth): Remove global.
7787         (parse_exp_in_context): Update.
7788         * p-exp.y (paren_depth): New global.
7789         (pascal_parse): Initialize it.
7790         * m2-exp.y (paren_depth): New global.
7791         (m2_parse): Initialize it.
7792         * go-exp.y (paren_depth): New global.
7793         (go_parse): Initialize it.
7794         * f-exp.y (paren_depth): New global.
7795         (f_parse): Initialize it.
7796         * d-exp.y (paren_depth): New global.
7797         (d_parse): Initialize it.
7798         * c-exp.y (paren_depth): New global.
7799         (c_parse): Initialize it.
7800         * ada-lex.l (paren_depth): New global.
7801         (lexer_init): Initialize it.
7802
7803 2019-04-04  Tom Tromey  <tom@tromey.com>
7804
7805         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7806         (rust_parser::convert_ast_to_type)
7807         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7808         * parser-defs.h (struct parser_state) <parser_state>: Add
7809         parameters.  Initialize new members.
7810         <expression_context_block, expression_context_pc>: New members.
7811         * parse.c (expression_context_block, expression_context_pc):
7812         Remove globals.
7813         (parse_exp_in_context): Update.
7814         * p-exp.y: Update all rules.
7815         (yylex): Update.
7816         * m2-exp.y: Update all rules.
7817         (yylex): Update.
7818         * go-exp.y (yylex): Update.
7819         * f-exp.y (yylex): Update.
7820         * d-exp.y: Update all rules.
7821         (yylex): Update.
7822         * c-exp.y: Update all rules.
7823         (lex_one_token, classify_name, yylex, c_parse): Update.
7824         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7825
7826 2019-04-04  Tom Tromey  <tom@tromey.com>
7827
7828         * gdbarch.h, gdbarch.c: Rebuild.
7829         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7830         * stap-probe.h:
7831         (struct stap_parse_info): Replace "parser_state" with
7832         "expr_builder".
7833         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7834         (parser_state): New class.
7835         * parse.c (expr_builder): Rename.
7836         (expr_builder::release): Rename.
7837         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7838         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7839         (write_exp_elt_longcst, write_exp_elt_floatcst)
7840         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7841         (write_exp_string_vector, write_exp_bitstring)
7842         (write_exp_msymbol, mark_struct_expression)
7843         (write_dollar_variable)
7844         (insert_type_address_space, increase_expout_size): Replace
7845         "parser_state" with "expr_builder".
7846         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7847         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7848         "parser_state" with "expr_builder".
7849
7850 2019-04-04  Tom Tromey  <tom@tromey.com>
7851
7852         * rust-exp.y: Replace "parse_language" with method call.
7853         * p-exp.y:
7854         (yylex): Replace "parse_language" with method call.
7855         * m2-exp.y:
7856         (yylex): Replace "parse_language" with method call.
7857         * go-exp.y (classify_name): Replace "parse_language" with method
7858         call.
7859         * f-exp.y (yylex): Replace "parse_language" with method call.
7860         * d-exp.y (lex_one_token): Replace "parse_language" with method
7861         call.
7862         * c-exp.y:
7863         (lex_one_token, classify_name, yylex): Replace "parse_language"
7864         with method call.
7865         * ada-exp.y (find_primitive_type, type_char)
7866         (type_system_address): Replace "parse_language" with method call.
7867
7868 2019-04-04  Tom Tromey  <tom@tromey.com>
7869
7870         * rust-exp.y: Replace "parse_gdbarch" with method call.
7871         * parse.c (write_dollar_variable, insert_type_address_space):
7872         Replace "parse_gdbarch" with method call.
7873         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7874         call.
7875         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7876         call.
7877         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7878         "parse_gdbarch" with method call.
7879         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7880         with method call.
7881         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7882         "parse_gdbarch" with method call.
7883         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7884         "parse_gdbarch" with method call.
7885         * c-exp.y (parse_type, parse_number, classify_name): Replace
7886         "parse_gdbarch" with method call.
7887         * ada-lex.l: Replace "parse_gdbarch" with method call.
7888         * ada-exp.y (parse_type, find_primitive_type, type_char)
7889         (type_system_address): Replace "parse_gdbarch" with method call.
7890
7891 2019-04-04  Tom Tromey  <tom@tromey.com>
7892
7893         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7894         * stap-probe.c (stap_parse_argument): Update.
7895         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7896         initial_size parameter.
7897         * rust-exp.y (rust_lex_tests): Update.
7898         * parse.c (parser_state): Update.
7899         (parse_exp_in_context): Update.
7900         * parser-defs.h (struct parser_state) <parser_state>: Remove
7901         "initial_size" parameter.
7902
7903 2019-04-04  Tom Tromey  <tom@tromey.com>
7904
7905         * parser-defs.h (increase_expout_size): Don't declare.
7906         * parse.c (increase_expout_size): Now static.
7907
7908 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7909
7910         * gnu-nat.c (gnu_nat_target::wait): Fix
7911         target_waitstatus_to_string call.
7912
7913 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7914
7915         * eval.c (evaluate_subexp_standard): Handle internal functions
7916         during Fortran function call handling.
7917
7918 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7919
7920         * NEWS: Mention new internal functions.
7921         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7922         (read_base_type): Use dwarf2_init_complex_target_type.
7923         * value.c (creal_internal_fn): New function.
7924         (cimag_internal_fn): New function.
7925         (_initialize_values): Register new internal functions.
7926
7927 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7928
7929         * infrun.c (stop_all_threads): If debug_infrun, always
7930         trace the wait status after wait_one, using
7931         target_waitstatus_to_string and target_pid_to_str.
7932         (handle_inferior_event): Replace various trace of
7933         wait status kind by a single trace.
7934         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7935         wait status kind image by target_waitstatus_to_string.
7936         * target/waitstatus.c (target_waitstatus_to_string): Fix
7937         obsolete comment.
7938
7939 2019-04-01  Tom Tromey  <tromey@adacore.com>
7940
7941         PR symtab/23331:
7942         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7943
7944 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7945             Pedro Alves  <palves@redhat.com>
7946
7947         * top.c (quit_force): Call 'finalize_values'.
7948         * value.c (finalize_values): New function.
7949         * value.h (finalize_values): Declare.
7950
7951 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7952
7953         * NEWS: Announce $_gdb_major and $_gdb_minor.
7954
7955         * top.c (init_gdb_version_vars): New function.
7956         (gdb_init): Call init_gdb_version_vars.
7957
7958 2019-03-29  Tom Tromey  <tromey@adacore.com>
7959
7960         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7961         help text.  Remove dead code.
7962
7963 2019-03-29  Keith Seitz  <keiths@redhat.com>
7964
7965         From Siddhesh Poyarekar:
7966         * f-lang.h (f77_get_upperbound): Return LONGEST.
7967         (f77_get_lowerbound): Likewise.
7968         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7969         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7970         print them.
7971         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7972         plongest to format print it.
7973         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7974         (f77_get_upperbound): Likewise.
7975         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7976         LOWER_BOUND to LONGEST.
7977         (f77_create_arrayprint_offset_tbl): Likewise.
7978
7979 2019-03-29  Keith Seitz  <keiths@redhat.com>
7980
7981         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7982         %s/pulongest for TYPE_LENGTH instead of %d in format
7983         strings.
7984         * ada-typerint.c (ada_print_type): Likewise.
7985         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7986         * compile/compile-c-support.c (generate_register_struct): Likewise.
7987         * gdbtypes.c (recursive_dump_type): Likewise.
7988         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7989         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7990         instead of %d in format strings.
7991         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7992         to std::min to ULONGEST.
7993         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7994         instead of %d in format strings.
7995         * tracepoint.c (info_scope_command): Likewise.
7996         * typeprint.c (print_offset_data::update)
7997         (print_offset_data::finish): Likewise.
7998         * xtensa-tdep.c (xtensa_store_return_value)
7999         (xtensa_push_dummy_call): Likewise.
8000
8001 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8002
8003         * windows-nat.c (display_selector): Fixed format specifications
8004         for 64-bit Cygwin.
8005
8006 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8007
8008         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8009
8010 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8011
8012         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8013         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8014         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8015         (nios2_linux_init_abi): Install it.
8016
8017 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8018
8019         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8020
8021 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8022
8023         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8024
8025 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8026             Tom Tromey  <tromey@adacore.com>
8027
8028         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8029
8030 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8031
8032         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8033         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8034         method to compute the bounds of range types. Also print "[evaluated]"
8035         if the bounds' values come from a dynamic evaluation.
8036
8037 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8038
8039         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8040         whitespace when pretty printing is on.
8041
8042 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8043
8044         * ppc-linux-nat.c: Add include.
8045
8046 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8047
8048         * NEWS: Mention AArch64 Pointer Authentication.
8049
8050 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8051
8052         * arm-linux-nat.c: Add include.
8053
8054 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8055
8056         * source-cache.c (source_cache::get_source_lines): Re-read
8057         fullname after calling open_source_file.
8058
8059 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8060
8061         * NEWS: Mention TLS support for FreeBSD.
8062
8063 2019-03-25  Tom Tromey  <tromey@adacore.com>
8064
8065         * minsyms.c (BUNCH_SIZE): Update comment.
8066         (~minimal_symbol_reader): Remove old comment.
8067         (compact_minimal_symbols): Update comment.
8068         (minimal_symbol_reader::install): Remove old comment.  Update
8069         other comments.
8070
8071 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8072
8073         * s390-linux-nat.c: Add include.
8074
8075 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8076
8077         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8078         Call linux_get_hwcap.
8079         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8080         Likewise.
8081         (aarch64_linux_get_hwcap): Remove function.
8082         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8083         declaration.
8084         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8085         linux_get_hwcap.
8086         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8087         * linux-tdep.c (linux_get_hwcap): Add function.
8088         (linux_get_hwcap2): Likewise.
8089         * linux-tdep.h (linux_get_hwcap): Add declaration.
8090         (linux_get_hwcap2): Likewise.
8091         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8092         (ppc_linux_get_hwcap2): Likewise.
8093         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8094         linux_get_hwcap.
8095         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8096         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8097         (ppc_linux_nat_target::read_description): Likewise.
8098         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8099         * s390-linux-nat.c: Likewise.
8100         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8101
8102 2019-03-24  Tom Tromey  <tom@tromey.com>
8103
8104         * ada-lang.c (standard_lookup): Simplify initialization.
8105         (ada_lookup_symbol_nonlocal): Simplify return.
8106         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8107         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8108         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8109         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8110         initialization.
8111         * solib.c (solib_global_lookup): Simplify.
8112         * symtab.c (null_block_symbol): Remove.
8113         (symbol_cache_lookup): Simplify returns.
8114         (lookup_language_this): Simplify returns.
8115         (lookup_symbol_aux): Simplify return.
8116         (lookup_local_symbol): Simplify returns.
8117         (lookup_global_symbol_from_objfile): Simplify return.
8118         (lookup_symbol_in_objfile_symtabs)
8119         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8120         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8121         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8122         * cp-namespace.c (cp_lookup_bare_symbol)
8123         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8124         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8125         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8126         (cp_lookup_symbol_via_imports): Simplify initialization.
8127         (find_symbol_in_baseclass): Likewise.
8128         * symtab.h (null_block_symbol): Remove.
8129         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8130         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8131         (d_lookup_symbol_module): Likewise.
8132         (find_symbol_in_baseclass): Simplify initialization.
8133
8134 2019-03-24  Tom Tromey  <tom@tromey.com>
8135
8136         * expression.h: Don't include symtab.h.
8137         (struct block): Forward declare.
8138
8139 2019-03-24  Tom Tromey  <tom@tromey.com>
8140
8141         * c-exp.y (typebase): Remove casts.
8142         * gdbtypes.c (lookup_unsigned_typename, )
8143         (lookup_signed_typename): Remove cast.
8144         * eval.c (parse_to_comma_and_eval): Remove cast.
8145         * parse.c (write_dollar_variable): Remove cast.
8146         * block.h (struct block) <superblock>: Now const.
8147         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8148         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8149         (map_block): Make "block" const.
8150         * symfile.h (struct quick_symbol_functions)
8151         <map_matching_symbols>: Constify block argument to "callback".
8152         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8153         const.
8154         (find_pc_sect_compunit_symtab): Make "b" const.
8155         (find_symbol_at_address): Likewise.
8156         (search_symbols): Likewise.
8157         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8158         (dw2_debug_names_lookup_symbol): Likewise.
8159         (dw2_map_matching_symbols): Update.
8160         * p-valprint.c (pascal_val_print): Remove "block".
8161         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8162         (aux_add_nonlocal_symbols): Make "block" const.
8163         (resolve_subexp): Remove cast.
8164         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8165         const.
8166         (iterate_over_file_blocks): Likewise.
8167         * f-exp.y (%union) <bval>: Remove.
8168         * coffread.c (patch_opaque_types): Make "b" const.
8169         * spu-tdep.c (spu_catch_start): Make "block" const.
8170         * c-valprint.c (print_unpacked_pointer): Remove "block".
8171         * symmisc.c (dump_symtab_1): Make "b" const.
8172         (block_depth): Make "block" const.
8173         * d-exp.y (%union) <bval>: Remove.
8174         * cp-support.h (cp_lookup_rtti_type): Update.
8175         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8176         * psymtab.c (psym_lookup_symbol): Make "block" const.
8177         (maintenance_check_psymtabs): Make "b" const.
8178         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8179         (enumerate_locals, enumerate_args): Update.
8180         * python/py-symtab.c (stpy_global_block): Make "block" const.
8181         (stpy_static_block): Likewise.
8182         * inline-frame.c (block_starting_point_at): Make "new_block"
8183         const.
8184         * block.c (find_block_in_blockvector): Make return type const.
8185         (blockvector_for_pc_sect): Make "b" const.
8186         (find_block_in_blockvector): Make "b" const.
8187
8188 2019-03-23  Tom Tromey  <tom@tromey.com>
8189
8190         * varobj.c (varobj_create): Update.
8191         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8192         * printcmd.c (display_command, do_one_display): Don't reset
8193         innermost_block.
8194         * parser-defs.h (enum innermost_block_tracker_type): Move to
8195         expression.h.
8196         (innermost_block): Update comment.
8197         * parse.c (parse_exp_1): Add tracker_types parameter.
8198         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8199         tracker_types parameter.  Reset innermost_block.
8200         (parse_exp_in_context): Remove.
8201         (parse_expression_for_completion): Update.
8202         * objfiles.c (~objfile): Don't reset expression_context_block or
8203         innermost_block.
8204         * expression.h (enum innermost_block_tracker_type): Move from
8205         parser-defs.h.
8206         (parse_exp_1): Add tracker_types parameter.
8207         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8208         reset innermost_block.
8209
8210 2019-03-23  Tom Tromey  <tom@tromey.com>
8211
8212         * objfiles.h: Include bcache.h.
8213
8214 2019-03-23  Tom Tromey  <tom@tromey.com>
8215
8216         * linespec.c (get_current_search_block): Use
8217         scoped_restore_current_language.
8218         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8219
8220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8221             Jiong Wang  <jiong.wang@arm.com>
8222
8223         * aarch64-linux-tdep.c
8224         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8225         section.
8226         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8227
8228 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8229             Jiong Wang  <jiong.wang@arm.com>
8230
8231         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8232         instructions.
8233         (aarch64_analyze_prologue_test): Add PACIASP test.
8234         (aarch64_prologue_prev_register): Unmask PC value.
8235
8236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8237             Jiong Wang  <jiong.wang@arm.com>
8238
8239         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8240         (aarch64_dwarf2_prev_register): Unmask PC value.
8241         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8242         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8243         DW_CFA_AARCH64_negate_ra_state.
8244         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8245
8246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8247             Jiong Wang  <jiong.wang@arm.com>
8248
8249         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8250         registers.
8251         (aarch64_pseudo_register_name): Likewise.
8252         (aarch64_pseudo_register_type): Likewise.
8253         (aarch64_pseudo_register_reggroup_p): Likewise.
8254         (aarch64_gdbarch_init): Add pauth registers.
8255         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8256         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8257         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8258         (struct gdbarch_tdep): Add regnum for ra_state.
8259
8260 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8261             Jiong Wang  <jiong.wang@arm.com>
8262
8263         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8264
8265 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8266             Jiong Wang  <jiong.wang@arm.com>
8267
8268         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8269         function.
8270         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8271         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8272         (aarch64_gdbarch_init): Add puth registers.
8273         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8274         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8275         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8276
8277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8278             Jiong Wang  <jiong.wang@arm.com>
8279
8280         * aarch64-linux-nat.c
8281         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8282         * aarch64-linux-tdep.c
8283         (aarch64_linux_core_read_description): Likewise.
8284         (aarch64_linux_get_hwcap): New function.
8285         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8286         (aarch64_linux_get_hwcap): New declaration.
8287
8288 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8289             Jiong Wang  <jiong.wang@arm.com>
8290
8291         * aarch64-linux-nat.c
8292         (aarch64_linux_nat_target::read_description): Add pauth param.
8293         * aarch64-linux-tdep.c
8294         (aarch64_linux_core_read_description): Likewise.
8295         * aarch64-tdep.c (struct target_desc): Add in pauth.
8296         (aarch64_read_description): Add pauth param.
8297         (aarch64_gdbarch_init): Likewise.
8298         * aarch64-tdep.h (aarch64_read_description): Likewise.
8299         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8300         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8301         * features/Makefile: Add new files.
8302         * features/aarch64-pauth.c: New file.
8303         * features/aarch64-pauth.xml: New file.
8304
8305 2019-03-20  Tom Tromey  <tromey@adacore.com>
8306
8307         * infrun.c (handle_inferior_event): Rename from
8308         handle_inferior_event_1.  Create a scoped_value_mark.
8309         (handle_inferior_event): Remove.
8310
8311 2019-03-19  Tom Tromey  <tromey@adacore.com>
8312
8313         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8314         * infrun.h (print_stop_event): Add "displays" parameter.
8315         * infrun.c (print_stop_event): Add "displays" parameter.
8316
8317 2019-03-19  Pedro Alves  <palves@redhat.com>
8318
8319         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8320         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8321         to -1.  Fix TABs vs spaces.
8322         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8323         * tui/tui-out.h (tui_ui_out) Add intro comments.
8324         <m_line, m_start_of_line>: In-class initialize, and add describing
8325         comment.
8326
8327 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8328
8329         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8330         variable names.
8331         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8332
8333 2019-03-18  Pedro Alves  <palves@redhat.com>
8334             Eli Zaretskii <eliz@gnu.org>
8335
8336         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8337         m_line and m_start_of_line.
8338
8339 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8340
8341         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8342         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8343         it returns a newline.  This fixes a regression in TU mode, whereby
8344         the next line is output on the same screen line as the user input.
8345
8346 2019-03-18  Tom Tromey  <tromey@adacore.com>
8347
8348         * minsyms.c (minimal_symbol_reader::install): Remove call to
8349         obstack_blank.
8350
8351 2019-03-18  Pedro Alves  <palves@redhat.com>
8352
8353         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8354         New globals.
8355         (apply_style): New, factored out from ...
8356         (apply_ansi_escape): ... this.  Handle reverse video mode.
8357         (tui_set_reverse_mode): New function.
8358         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8359         * tui/tui-winsource.c (tui_show_source_line): Use
8360         tui_set_reverse_mode instead of setting A_STANDOUT.
8361         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8362         New setter methods.
8363
8364 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8365
8366         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8367         Handle tabs.
8368
8369 2019-03-18  Tom Tromey  <tromey@adacore.com>
8370
8371         * ada-lang.c (empty_array): Add "high" parameter.
8372         (ada_evaluate_subexp): Update.
8373
8374 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8375
8376         * unittests/string_view-selftests.c: Define
8377         _initialize_string_view_selftests unconditionally.
8378
8379 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8380
8381         PR gdb/24350
8382         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8383
8384 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8385
8386         PR gdb/24351
8387         * windows-nat.c (display_selector): Fix format specifiers.
8388
8389 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8390
8391         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8392         tui_refill_source_window instead of tui_refresh_win, to update the
8393         current execution line.  This fixes redisplay of the current line
8394         when stepping through the code with "next" or "step".
8395
8396 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8397
8398         * source-cache.c (source_cache::get_source_lines): Call
8399         find_source_lines to initialize s->nlines.  This fixes vertical
8400         scrolling of TUI source window when the DOWN arrow is pressed.
8401
8402 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8403
8404         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8405         linux-thread-db.c (_initialize_thread_db): Likewise.
8406
8407 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8408
8409         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8410         wclrtoeol in tui_show_source_line".  This reverts changes made in
8411         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8412
8413 2019-03-15  Tom Tromey  <tom@tromey.com>
8414
8415         * symtab.h (struct minimal_symbol): Derive from
8416         general_symbol_info.
8417         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8418         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8419         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8420         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8421         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8422         (MSYMBOL_SEARCH_NAME): Update.
8423         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8424         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8425         * minsyms.c (minimal_symbol_reader::record_full): Update.
8426
8427 2019-03-15  Tom Tromey  <tom@tromey.com>
8428
8429         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8430
8431 2019-03-15  Tom Tromey  <tom@tromey.com>
8432
8433         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8434         unique_xmalloc_ptr.
8435         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8436         Update.
8437         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8438         (build_minimal_symbol_hash_tables)
8439         (minimal_symbol_reader::install): Update.
8440
8441 2019-03-15  Tom Tromey  <tom@tromey.com>
8442
8443         * symtab.c (create_demangled_names_hash): Update.
8444         (symbol_set_names): Update.
8445         * objfiles.h (struct objfile_per_bfd_storage)
8446         <demangled_names_hash>: Now an htab_up.
8447         * objfiles.c (objfile_per_bfd_storage): Simplify.
8448
8449 2019-03-15  Tom Tromey  <tom@tromey.com>
8450
8451         * objfiles.h (struct objfile_per_bfd_storage): Declare
8452         destructor.
8453         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8454         New.
8455         (get_objfile_bfd_data): Use new.  Don't initialize
8456         language_of_main.
8457         (free_objfile_per_bfd_storage): Remove.
8458         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8459
8460 2019-03-15  Tom Tromey  <tom@tromey.com>
8461
8462         * symfile.c (reread_symbols): Update.
8463         * objfiles.c (objfile::objfile): Update.
8464         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8465         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8466         comment.
8467         (minimal_symbol_reader::install): Update.
8468         (terminate_minimal_symbol_table): Remove.
8469         * jit.c (jit_object_close_impl): Update.
8470
8471 2019-03-15  Tom Tromey  <tom@tromey.com>
8472
8473         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8474         initializations.
8475
8476 2019-03-15  Tom Tromey  <tom@tromey.com>
8477
8478         * objfiles.h (struct objfile_per_bfd_storage)
8479         <demangled_hash_languages>: Now a bitset.
8480         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8481         (lookup_minimal_symbol): Update.
8482
8483 2019-03-15  Tom Tromey  <tom@tromey.com>
8484
8485         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8486         Don't return the symbol.
8487         * coffread.c (record_minimal_symbol): Use record_full.
8488
8489 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8490
8491         The MS-Windows port of ncurses fails to switch to a color pair if
8492         one or both of the colors are the implicit default colors.  This
8493         change records the default colors when TUI is initialized, and
8494         then specifies them explicitly when a color pair uses the default
8495         colors.  This allows color styling in TUI mode on MS-Windows.
8496
8497         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8498         ncurses_norm_attr.
8499         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8500         colors in ncurses_norm_attr.
8501         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8502         "none", replace it with the default color recorded in
8503         ncurses_norm_attr.
8504
8505 2019-03-14  Tom Tromey  <tromey@adacore.com>
8506
8507         * source-cache.h (class source_cache) <get_source_lines>: Return
8508         std::string.
8509         * source-cache.c (source_cache::extract_lines): Handle case where
8510         first_pos==npos.  Return std::string.
8511         (source_cache::get_source_lines): Update.
8512
8513 2019-03-14  Tom Tromey  <tromey@adacore.com>
8514
8515         * NEWS: Add item for "style sources" commands.
8516         * source-cache.c (source_cache::get_source_lines): Check
8517         source_styling.
8518         * cli/cli-style.c (source_styling): New global.
8519         (_initialize_cli_style): Add "style sources" commands.
8520         (show_style_sources): New function.
8521         * cli/cli-style.h (source_styling): Declare.
8522
8523 2019-03-14  Pedro Alves  <palves@redhat.com>
8524             Tom Tromey  <tromey@adacore.com>
8525
8526         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8527         * tui/tui-winsource.c (tui_refill_source_window): New function,
8528         from...
8529         (tui_horizontal_source_scroll): ... here.  Move some logic.
8530         * cli/cli-style.c (set_style_enabled): Notify new observable.
8531         * tui/tui-hooks.c (tui_redisplay_source): New function.
8532         (tui_attach_detach_observers): Attach or detach
8533         tui_redisplay_source.
8534         * observable.h (source_styling_changed): New observable.
8535         * observable.c: Define source_styling_changed observable.
8536
8537 2019-03-13  Tom Tromey  <tromey@adacore.com>
8538
8539         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8540         (i386_gnu_nat_target::store_registers): Update.
8541         * target-debug.h (target_debug_print_std_string): New macro.
8542         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8543         * windows-tdep.c (display_one_tib): Update.
8544         * tui/tui-stack.c (tui_make_status_line): Update.
8545         * top.c (print_inferior_quit_action): Update.
8546         * thread.c (thr_try_catch_cmd): Update.
8547         (add_thread_with_info): Update.
8548         (thread_target_id_str): Update.
8549         (thr_try_catch_cmd): Update.
8550         (thread_command): Update.
8551         (thread_find_command): Update.
8552         * record-btrace.c (record_btrace_target::info_record)
8553         (record_btrace_resume_thread, record_btrace_target::resume)
8554         (record_btrace_cancel_resume, record_btrace_step_thread)
8555         (record_btrace_target::wait, record_btrace_target::wait)
8556         (record_btrace_target::wait, record_btrace_target::stop): Update.
8557         * progspace.c (print_program_space): Update.
8558         * process-stratum-target.c
8559         (process_stratum_target::thread_address_space): Update.
8560         * linux-fork.c (linux_fork_mourn_inferior)
8561         (detach_checkpoint_command, info_checkpoints_command)
8562         (linux_fork_context): Update.
8563         (linux_fork_detach): Update.
8564         (class scoped_switch_fork_info): Update.
8565         (delete_checkpoint_command): Update.
8566         * infrun.c (follow_fork_inferior): Update.
8567         (follow_fork_inferior): Update.
8568         (proceed_after_vfork_done): Update.
8569         (handle_vfork_child_exec_or_exit): Update.
8570         (follow_exec): Update.
8571         (displaced_step_prepare_throw): Update.
8572         (displaced_step_restore): Update.
8573         (start_step_over): Update.
8574         (resume_1): Update.
8575         (clear_proceed_status_thread): Update.
8576         (proceed): Update.
8577         (print_target_wait_results): Update.
8578         (do_target_wait): Update.
8579         (context_switch): Update.
8580         (stop_all_threads): Update.
8581         (restart_threads): Update.
8582         (finish_step_over): Update.
8583         (handle_signal_stop): Update.
8584         (switch_back_to_stepped_thread): Update.
8585         (keep_going_pass_signal): Update.
8586         (print_exited_reason): Update.
8587         (normal_stop): Update.
8588         * inferior.c (inferior_pid_to_str): Change return type.
8589         (print_selected_inferior): Update.
8590         (add_inferior): Update.
8591         (detach_inferior): Update.
8592         * dummy-frame.c (fprint_dummy_frames): Update.
8593         * dcache.c (dcache_info_1): Update.
8594         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8595         (btrace_fetch, btrace_clear): Update.
8596         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8597         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8598         type.
8599         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8600         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8601         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8602         * gdbarch.c, gdbarch.h: Rebuild.
8603         * gdbarch.sh (core_pid_to_str): Change return type.
8604         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8605         return type.
8606         (windows_nat_target::pid_to_str): Change return type.
8607         (windows_delete_thread): Update.
8608         (windows_nat_target::attach): Update.
8609         (windows_nat_target::files_info): Update.
8610         * target-delegates.c: Rebuild.
8611         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8612         return type.
8613         (sol_thread_target::pid_to_str): Change return type.
8614         * remote.c (class remote_target) <pid_to_str>: Change return
8615         type.
8616         (remote_target::pid_to_str): Change return type.
8617         (extended_remote_target::attach, remote_target::remote_stop_ns)
8618         (remote_target::remote_notif_remove_queued_reply)
8619         (remote_target::push_stop_reply, remote_target::disable_btrace):
8620         Update.
8621         (extended_remote_target::attach): Update.
8622         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8623         type.
8624         (gdbsim_target::pid_to_str): Change return type.
8625         * ravenscar-thread.c (struct ravenscar_thread_target)
8626         <pid_to_str>: Change return type.
8627         (ravenscar_thread_target::pid_to_str): Change return type.
8628         * procfs.c (class procfs_target) <pid_to_str>: Change return
8629         type.
8630         (procfs_target::pid_to_str): Change return type.
8631         (procfs_target::attach): Update.
8632         (procfs_target::detach): Update.
8633         (procfs_target::fetch_registers): Update.
8634         (procfs_target::store_registers): Update.
8635         (procfs_target::wait): Update.
8636         (procfs_target::files_info): Update.
8637         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8638         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8639         return type.
8640         (nto_procfs_target::pid_to_str): Change return type.
8641         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8642         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8643         return type.
8644         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8645         (exit_lwp): Update.
8646         (attach_proc_task_lwp_callback, get_detach_signal)
8647         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8648         (linux_nat_target::resume, wait_lwp, stop_callback)
8649         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8650         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8651         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8652         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8653         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8654         type.
8655         (inf_ptrace_target::attach): Update.
8656         (inf_ptrace_target::files_info): Update.
8657         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8658         type.
8659         (go32_nat_target::pid_to_str): Change return type.
8660         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8661         (gnu_nat_target::wait): Update.
8662         (gnu_nat_target::wait): Update.
8663         (gnu_nat_target::resume): Update.
8664         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8665         (fbsd_nat_target::wait): Update.
8666         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8667         type.
8668         (darwin_nat_target::attach): Update.
8669         * corelow.c (class core_target) <pid_to_str>: Change return type.
8670         (core_target::pid_to_str): Change return type.
8671         * target.c (normal_pid_to_str): Change return type.
8672         (default_pid_to_str): Likewise.
8673         (target_pid_to_str): Change return type.
8674         (target_translate_tls_address): Update.
8675         (target_announce_detach): Update.
8676         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8677         return type.
8678         (bsd_uthread_target::pid_to_str): Change return type.
8679         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8680         type.
8681         (bsd_kvm_target::pid_to_str): Change return type.
8682         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8683         return type.
8684         (aix_thread_target::pid_to_str): Change return type.
8685         * target.h (struct target_ops) <pid_to_str>: Change return type.
8686         (target_pid_to_str, normal_pid_to_str): Likewise.
8687         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8688         type.
8689         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8690         type.
8691         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8692         return type.
8693         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8694         type.
8695         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8696         type.
8697         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8698         return type.
8699
8700 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8701
8702         * NEWS: Mention that the new default MI version is 3.  Mention
8703         changes to the output of commands and events that deal with
8704         multi-location breakpoints.
8705         * breakpoint.c: Include "mi/mi-out.h".
8706         (print_one_breakpoint): Change output syntax if using MI version
8707         >= 3.
8708         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8709         New.
8710         (mi_multi_location_breakpoint_output_fixed): New.
8711         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8712         (mi_cmd_fix_multi_location_breakpoint_output): New.
8713         (mi_multi_location_breakpoint_output_fixed): New.
8714         * mi/mi-cmds.c (mi_cmds): Register command
8715         -fix-multi-location-breakpoint-output.
8716         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8717         interpreter "mi".
8718
8719 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8720
8721         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8722         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8723         instantiate mi_ui_out based on interpreter name.
8724         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8725         * mi/mi-main.c (mi_load_progress): Likewise.
8726
8727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8728
8729         * NEWS: Combine separate "New targets" sections for 8.3.
8730
8731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8732
8733         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8734         (ppcfbsd_init_abi): Install gdbarch
8735         "fetch_tls_load_module_address" and "get_thread_local_address"
8736         methods.
8737
8738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8739
8740         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8741         (riscv_fbsd_init_abi): Install gdbarch
8742         "fetch_tls_load_module_address" and "get_thread_local_address"
8743         methods.
8744
8745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8746
8747         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8748         (i386fbsd_init_abi): Install gdbarch
8749         "fetch_tls_load_module_address" and "get_thread_local_address"
8750         methods.
8751
8752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8753
8754         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8755         (amd64fbsd_init_abi): Install gdbarch
8756         "fetch_tls_load_module_address" and "get_thread_local_address"
8757         methods.
8758
8759 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8760
8761         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8762         (struct fbsd_pspace_data): New type.
8763         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8764         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8765         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8766         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8767         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8768
8769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8770
8771         * gdbtypes.c (lookup_struct_elt): New function.
8772         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8773         * gdbtypes.h (struct struct_elt): New type.
8774         (lookup_struct_elt): New prototype.
8775
8776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8777
8778         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8779         remove disabled code block.
8780
8781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8782
8783         * gdbarch.sh (get_thread_local_address): New method.
8784         * gdbarch.h, gdbarch.c: Regenerate.
8785         * target.c (target_translate_tls_address): Use
8786         gdbarch_get_thread_local_address if present instead of
8787         target::get_thread_local_address.
8788
8789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8790
8791         * target.h (target::get_thread_local_address): Update comment.
8792
8793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8794
8795         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8796         objfile->separate_debug_objfile_backlink if not NULL.
8797
8798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8799
8800         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8801         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8802         (amd64bsd_store_inferior_registers): Likewise.
8803         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8804         Enable segment base registers.
8805         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8806         PT_GETFSBASE and PT_GETGSBASE.
8807         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8808         PT_SETGSBASE.
8809         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8810         segment base registers.
8811         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8812
8813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8814
8815         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8816         Update calls to i386_target_description to add 'segments'
8817         parameter.
8818         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8819         add segment base registers.
8820         * arch/i386.c (i386_create_target_description): Add 'segments'
8821         parameter to enable segment base registers.
8822         * arch/i386.h (i386_create_target_description): Likewise.
8823         * features/i386/32bit-segments.xml: New file.
8824         * features/i386/32bit-segments.c: Generate.
8825         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8826         call to i386_target_description to add 'segments' parameter.
8827         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8828         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8829         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8830         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8831         if feature is present.
8832         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8833         Add 'segments' parameter to call to i386_target_description.
8834         (i386_target_description): Add 'segments' parameter to enable
8835         segment base registers.
8836         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8837         to call to i386_target_description.
8838         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8839         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8840         Define I386_NUM_REGS.
8841         (i386_target_description): Add 'segments' parameter to enable
8842         segment base registers.
8843
8844 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8845
8846         PR/24325
8847         * source-cache.c: #undef open and close, to avoid unresolved
8848         externals during linking.
8849
8850 2019-03-12  Tom Tromey  <tromey@adacore.com>
8851
8852         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8853         const.  Add initializers.
8854         (_initialize_remote): Don't initialize ptid globals.
8855
8856 2019-03-12  Pedro Alves  <palves@redhat.com>
8857
8858         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8859
8860 2019-03-12  Pedro Alves  <palves@redhat.com>
8861
8862         * cp-name-parser.y (main): Remove unused 'len' variable.
8863
8864 2019-03-12  Tom Tromey  <tromey@adacore.com>
8865
8866         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8867         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8868
8869 2019-03-12  Tom Tromey  <tromey@adacore.com>
8870
8871         * linux-nat.c (iterate_over_lwps): Update.
8872         (stop_callback): Remove parameter.
8873         (stop_wait_callback, detach_callback, resume_set_callback)
8874         (select_singlestep_lwp_callback, set_ignore_sigint)
8875         (status_callback, resumed_callback, resume_clear_callback)
8876         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8877         data parameter.
8878         (linux_nat_target::detach, linux_nat_target::resume)
8879         (linux_stop_and_wait_all_lwps, select_event_lwp)
8880         (linux_nat_filter_event, linux_nat_wait_1)
8881         (linux_nat_target::kill, linux_nat_target::stop)
8882         (linux_nat_target::stop): Update.
8883         (linux_nat_resume_callback): Change type.
8884         (resume_stopped_resumed_lwps, count_events_callback)
8885         (select_event_lwp_callback): Likewise.
8886         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8887         * arm-linux-nat.c (struct update_registers_data): Remove.
8888         (update_registers_callback): Change type.
8889         (arm_linux_insert_hw_breakpoint1): Update.
8890         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8891         parameter.
8892         (x86_linux_dr_set_addr): Update.
8893         (x86_linux_dr_set_control): Update.
8894         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8895         (iterate_over_lwps): Use gdb::function_view.
8896         * nat/aarch64-linux-hw-point.c (struct
8897         aarch64_dr_update_callback_param): Remove.
8898         (debug_reg_change_callback): Change type.
8899         (aarch64_notify_debug_reg_change): Update.
8900         * s390-linux-nat.c (s390_refresh_per_info): Update.
8901
8902 2019-03-11  Tom Tromey  <tromey@adacore.com>
8903
8904         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8905         redundant assignment to "this_cu".
8906
8907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8908
8909         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8910
8911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8912
8913         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8914         from...
8915         (rank_one_type): ... this.
8916
8917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8918
8919         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8920         from...
8921         (rank_one_type): ... this.
8922
8923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8924
8925         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8926         from...
8927         (rank_one_type): ... this.
8928
8929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8930
8931         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8932         from...
8933         (rank_one_type): ... this.
8934
8935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8936
8937         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8938         from...
8939         (rank_one_type): ... this.
8940
8941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8942
8943         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8944         from...
8945         (rank_one_type): ... this.
8946
8947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8948
8949         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8950         from...
8951         (rank_one_type): ... this.
8952
8953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8954
8955         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8956         from...
8957         (rank_one_type): ... this.
8958
8959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8960
8961         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8962         from...
8963         (rank_one_type): ... this.
8964
8965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8966
8967         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8968         from...
8969         (rank_one_type): ... this.
8970
8971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8972
8973         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8974         from...
8975         (rank_one_type): ... this.
8976
8977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8978
8979         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8980         from...
8981         (rank_one_type): ... this.
8982
8983 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8984
8985         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8986         inferior-events' shows the example events.
8987
8988 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8989
8990         Support styling on native MS-Windows console
8991
8992         PR/24315
8993         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8994         on MS-Windows if $TERM is not defined.
8995
8996         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8997
8998         * posix-hdep.c (gdb_console_fputs):
8999         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9000         functions.
9001         * ui-file.h (gdb_console_fputs): Add prototype.
9002
9003         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9004         back to fputs only if the former returns zero.
9005
9006 2019-03-07  Tom Tromey  <tom@tromey.com>
9007
9008         * symmisc.c (print_symbol_bcache_statistics): Update.
9009         (print_objfile_statistics): Update.
9010         * symfile.c (allocate_symtab): Update.
9011         * stabsread.c: Don't include bcache.h.
9012         * psymtab.h (struct psymbol_bcache): Don't declare.
9013         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9014         (psymbol_bcache_init, psymbol_bcache_free)
9015         (psymbol_bcache_get_bcache): Don't declare.
9016         * psymtab.c (struct psymbol_bcache): Remove.
9017         (psymtab_storage::psymtab_storage): Update.
9018         (psymtab_storage::~psymtab_storage): Update.
9019         (psymbol_bcache_init, psymbol_bcache_free)
9020         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9021         (add_psymbol_to_bcache): Update.
9022         (allocate_psymtab): Update.
9023         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9024         macro_cache>: No longer pointers.
9025         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9026         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9027         * macrotab.c (macro_bcache): Update.
9028         * macroexp.c: Don't include bcache.h.
9029         * gdbtypes.c (check_types_worklist): Update.
9030         (types_deeply_equal): Remove TRY/CATCH.  Update.
9031         * elfread.c (elf_symtab_read): Update.
9032         * dwarf2read.c: Don't include bcache.h.
9033         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9034         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9035         (print_bcache_statistics, bcache_memory_used): Don't declare.
9036         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9037         methods.  Rename all data members.
9038         * bcache.c (struct bcache): Move to bcache.h.
9039         (bcache::expand_hash_table): Rename from expand_hash_table.
9040         (bcache): Remove.
9041         (bcache::insert): Rename from bcache_full.
9042         (bcache::compare): Rename from bcache_compare.
9043         (bcache_xmalloc): Remove.
9044         (bcache::~bcache): Rename from bcache_xfree.
9045         (bcache::print_statistics): Rename from print_bcache_statistics.
9046         (bcache::memory_used): Rename from bcache_memory_used.
9047
9048 2019-03-07  Pedro Alves  <palves@redhat.com>
9049
9050         * infrun.c (normal_stop): Also check for
9051         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9052
9053 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9054
9055         * f-lang.c (value_from_host_double): Moved to...
9056         * value.c (value_from_host_double): ...here.
9057         * value.h (value_from_host_double): Declare.
9058         * guile/scm-math.c (vlscm_convert_typed_number): Use
9059         value_from_host_double.
9060         (vlscm_convert_number): Likewise.
9061         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9062         * python/py-value.c (convert_value_from_python): Likewise.
9063
9064 2019-03-06  Tom Tromey  <tom@tromey.com>
9065
9066         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9067
9068 2019-03-06  Tom Tromey  <tom@tromey.com>
9069
9070         * utils.h (free_current_contents): Don't declare.
9071         * utils.c (free_current_contents): Remove.
9072
9073 2019-03-06  Tom Tromey  <tom@tromey.com>
9074
9075         * top.c (quit_force): Update.
9076         * main.c (captured_command_loop): Update.
9077         * common/new-op.c (operator new): Update.
9078         * common/common-exceptions.c (struct catcher)
9079         <save_cleanup_chain>: Remove member.
9080         (exceptions_state_mc_init): Update.
9081         (exception_try_scope_entry): Return nullptr.
9082         (exception_try_scope_exit, exception_rethrow)
9083         (throw_exception_sjlj, throw_exception_cxx): Update.
9084         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9085         (all_cleanups, do_cleanups, discard_cleanups)
9086         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9087         (restore_cleanups, restore_final_cleanups): Don't declare.
9088         (do_final_cleanups): Remove parameter.
9089         * common/cleanups.c (cleanup_chain, make_cleanup)
9090         (make_cleanup_dtor, all_cleanups, do_cleanups)
9091         (discard_my_cleanups, discard_cleanups)
9092         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9093         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9094         (null_cleanup): Remove.
9095         (do_final_cleanups): Remove parameter.
9096
9097 2019-03-06  Tom Tromey  <tom@tromey.com>
9098
9099         * remote.c (remote_target::remote_parse_stop_reply): Use
9100         unique_xmalloc_ptr.
9101
9102 2019-03-06  Tom Tromey  <tom@tromey.com>
9103
9104         * stabsread.c (struct stabs_field_info): Rename from field_info.
9105         <list, fnlist>: Add initializers.
9106         <obstack>: New member.
9107         (read_member_functions, read_struct_fields, read_baseclasses):
9108         Allocate on obstack.  Don't use cleanups.
9109         (read_one_struct_field, read_member_functions, read_struct_fields)
9110         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9111         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9112         (read_struct_type): Update.
9113
9114 2019-03-06  Tom Tromey  <tom@tromey.com>
9115
9116         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9117         * common/filestuff.h (make_cleanup_close): Don't declare.
9118         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9119         Remove.
9120
9121 2019-03-06  Tom Tromey  <tom@tromey.com>
9122
9123         * solib-aix.c: Use make_scope_exit.
9124
9125 2019-03-06  Tom Tromey  <tom@tromey.com>
9126
9127         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9128         Use make_scope_exit.
9129
9130 2019-03-06  Tom Tromey  <tom@tromey.com>
9131
9132         * solib-svr4.c (disable_probes_interface): Remove parameter.
9133         (svr4_handle_solib_event): Use make_scope_exit.
9134
9135 2019-03-06  Tom Tromey  <tom@tromey.com>
9136
9137         * remote.c (struct stop_reply_deleter): Remove.
9138         (stop_reply_up): Update.
9139         (struct stop_reply): Derive from notif_event.  Don't typedef.
9140         <regcache>: Now a std::vector.
9141         (stop_reply_xfree): Remove.
9142         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9143         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9144         (remote_target::discard_pending_stop_replies): Use delete.
9145         (remote_target::remote_parse_stop_reply): Update.
9146         (remote_target::process_stop_reply): Update.
9147         * remote-notif.h (struct notif_event): Add virtual destructor.
9148         Remove "dtr" member.
9149         (struct notif_client) <alloc_event>: Return a unique_ptr.
9150         (notif_event_xfree): Don't declare.
9151         (notif_event_up): New typedef.
9152         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9153         (notif_event_xfree, do_notif_event_xfree): Remove.
9154         (remote_notif_state_xfree): Update.
9155
9156 2019-03-06  Tom Tromey  <tom@tromey.com>
9157
9158         * infrun.c (displaced_step_clear_cleanup): Now a
9159         forward_scope_exit type.
9160         (displaced_step_prepare_throw): Update.
9161         (displaced_step_fixup): Update.
9162
9163 2019-03-06  Tom Tromey  <tom@tromey.com>
9164
9165         * inferior.h (class inferior): Update comment.
9166         * gdbthread.h (class thread_info): Update comment.
9167
9168 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9169             Tom Tromey  <tom@tromey.com>
9170
9171         * stabsread.h (struct stab_section_list): Remove.
9172         (coffstab_build_psymtabs): Update.
9173         * dbxread.c (symbuf_sections): Now a std::vector.
9174         (sect_idx): New global.
9175         (fill_symbuf): Update.
9176         (coffstab_build_psymtabs): Change type of stabsects parameter.
9177         Update.
9178         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9179         std::vector.
9180         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9181         (coff_locate_sections): Update.
9182         (coff_symfile_read): Remove cleanups.  Update.
9183         (init_stringtab): Add storage parameter.
9184         (free_stringtab, free_stringtab_cleanup): Remove.
9185         (init_lineno): Add storage parameter.
9186         (free_linetab, free_linetab_cleanup): Remove.
9187
9188 2019-03-06  Pedro Alves  <palves@redhat.com>
9189
9190         * linux-fork.c (fork_info::clobber_regs): Delete.
9191         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9192         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9193         comment.  Adjust.
9194         (scoped_switch_fork_info::scoped_switch_fork_info)
9195         (checkpoint_command, linux_fork_context): Adjust
9196         fork_save_infrun_state calls.
9197
9198 2019-03-06  Pedro Alves  <palves@redhat.com>
9199
9200         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9201         (inf_has_multiple_threads): Return 'bool' and rewrite using
9202         inferior_info::threads().
9203
9204 2019-03-06  Pedro Alves  <palves@redhat.com>
9205
9206         * linux-fork.c: Include <list>.
9207         (fork_list): Now a std::list instance.
9208         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9209         (forks_exist_p, find_last_fork): Adjust.
9210         (new_fork): Delete.
9211         (one_fork_p): New.
9212         (add_fork): Adjust.
9213         (free_fork): Delete, folded into fork_info::~fork_info().
9214         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9215         Adjust.
9216         (init_fork_list): Delete.
9217         (linux_fork_killall, linux_fork_mourn_inferior)
9218         (linux_fork_detach, info_checkpoints_command): Adjust.
9219         (_initialize_linux_fork): No longer call init_fork_list.
9220
9221 2019-03-06  Pedro Alves  <palves@redhat.com>
9222
9223         * linux-fork.c (new_fork): New, split out of ...
9224         (add_fork): ... this.  Return void.  Move "first fork" special
9225         case from here, to ...
9226         (checkpoint_command): ... here.
9227         * linux-linux.h (add_fork): Return void.
9228
9229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9230
9231         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9232
9233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9234             Chris January  <chris.january@arm.com>
9235             David Lecomber  <david.lecomber@arm.com>
9236
9237         * f-exp.y: New token, UNOP_INTRINSIC.
9238         (exp): New pattern using UNOP_INTRINSIC token.
9239         (f77_keywords): Add 'abs' keyword.
9240         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9241         (value_from_host_double): New function.
9242         (evaluate_subexp_f): Support UNOP_ABS.
9243
9244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9245
9246         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9247         types.
9248
9249 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9250
9251         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9252         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9253         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9254
9255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9256
9257         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9258
9259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9260             Chris January  <chris.january@arm.com>
9261
9262         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9263         * f-exp.y: Define 'KIND' token.
9264         (exp): New pattern for KIND expressions.
9265         (ptype): Handle types with a kind extension.
9266         (direct_abs_decl): Extend to spot kind extensions.
9267         (f77_keywords): Add 'kind' to the list.
9268         (push_kind_type): New function.
9269         (convert_to_kind_type): New function.
9270         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9271         * parse.c (operator_length_standard): Likewise.
9272         * parser-defs.h (enum type_pieces): Add tp_kind.
9273         * std-operator.def: Add UNOP_KIND.
9274
9275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9276
9277         * f-exp.y (f_parse): Set yydebug.
9278
9279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9280
9281         * f-lang.c (evaluate_subexp_f): New function.
9282         (exp_descriptor_f): New global.
9283         (f_language_defn): Use exp_descriptor_f instead of
9284         exp_descriptor_standard.
9285
9286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9287
9288         * f-exp.y (struct token): Add comments.
9289         (dot_ops): Remove uppercase versions and the end marker.
9290         (f77_keywords): Likewise.
9291         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9292         entries in the dot_ops array are case insensitive, and use
9293         strncasecmp to compare strings.  Also some whitespace cleanup in
9294         this area.  Similar for the f77_keywords array, except entries in
9295         this list might be case sensitive.
9296
9297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * f-exp.y (struct f77_boolean_val): Add comments.
9300         (boolean_values): Remove uppercase versions, and end marker.
9301         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9302         and use strncasecmp to achieve case insensitivity.  Additionally,
9303         perform whitespace cleanup around this code.
9304
9305 2019-03-06  Tom Tromey  <tromey@adacore.com>
9306
9307         * remote-sim.c (gdbsim_target_open): Use result of
9308         gdb_argv::release.
9309
9310 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9311         Dirk Schubert  <dirk.schubert@arm.com>
9312         Chris January  <chris.january@arm.com>
9313
9314         * eval.c (evaluate_subexp_standard): Call Fortran argument
9315         wrapping logic.
9316         * f-lang.c (struct value): A value which can be passed into a
9317         Fortran function call.
9318         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9319         where appropriate.
9320         (struct type): Value ready for a Fortran function call.
9321         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9322         is needed.
9323         * f-lang.h (fortran_argument_convert): Declaration.
9324         (fortran_preserve_arg_pointer): Declaration.
9325         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9326
9327 2019-03-05  Tom Tromey  <tromey@adacore.com>
9328
9329         * python/py-prettyprint.c (print_string_repr): Remove #if.
9330         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9331
9332 2019-03-05  Tom Tromey  <tromey@adacore.com>
9333
9334         * target.c (the_dummy_target): Move later.  Change type to
9335         "dummy_target".
9336         (initialize_targets): Don't initialize the_dummy_target.
9337
9338 2019-03-05  Tom Tromey  <tromey@adacore.com>
9339
9340         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9341         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9342
9343 2019-03-05  Tom Tromey  <tromey@adacore.com>
9344
9345         * windows-nat.c (windows_nat_target::attach)
9346         (windows_nat_target::detach): Don't call gdb_flush.
9347         * valprint.c (generic_val_print, val_print, val_print_string):
9348         Don't call gdb_flush.
9349         * utils.c (defaulted_query): Don't call gdb_flush.
9350         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9351         * target.c (target_announce_detach): Don't call gdb_flush.
9352         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9353         * remote.c (extended_remote_target::attach): Don't call
9354         gdb_flush.
9355         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9356         * printcmd.c (do_examine): Don't call gdb_flush.
9357         (info_display_command): Don't call gdb_flush.
9358         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9359         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9360         * memattr.c (info_mem_command): Don't call gdb_flush.
9361         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9362         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9363         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9364         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9365         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9366         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9367         (gnu_nat_target::detach): Don't call gdb_flush.
9368         * f-valprint.c (f_val_print): Don't call gdb_flush.
9369         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9370         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9371         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9372         gdb_flush.
9373         * c-valprint.c (c_val_print): Don't call gdb_flush.
9374         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9375
9376 2019-03-05  Tom Tromey  <tromey@adacore.com>
9377
9378         * varobj.c (update_dynamic_varobj_children): Update.
9379         (install_default_visualizer): Use reset, not release.
9380         * value.c (set_internalvar): Update.
9381         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9382         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9383         ATTRIBUTE_UNUSED_RESULT.
9384
9385 2019-03-05  Tom Tromey  <tromey@adacore.com>
9386
9387         * remote.c (class scoped_remote_fd) <release>: Add
9388         ATTRIBUTE_UNUSED_RESULT.
9389
9390 2019-03-05  Tom Tromey  <tromey@adacore.com>
9391
9392         * macroexp.c (struct macro_buffer) <release>: Add
9393         ATTRIBUTE_UNUSED_RESULT.
9394
9395 2019-03-05  Tom Tromey  <tromey@adacore.com>
9396
9397         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9398         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9399         ATTRIBUTE_UNUSED_RESULT.
9400
9401 2019-03-05  Tom Tromey  <tromey@adacore.com>
9402
9403         * common/scoped_fd.h (class scoped_fd) <release>: Add
9404         ATTRIBUTE_UNUSED_RESULT.
9405
9406 2019-03-05  Tom Tromey  <tromey@adacore.com>
9407
9408         * parser-defs.h (struct parser_state) <release>: Add
9409         ATTRIBUTE_UNUSED_RESULT.
9410
9411 2019-03-05  Tom Tromey  <tromey@adacore.com>
9412
9413         * utils.h (class gdb_argv) <release>: Add
9414         ATTRIBUTE_UNUSED_RESULT.
9415         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9416
9417 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9418
9419         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9420         for-loop range, to avoid compiler warnings.
9421
9422         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9423         avoid compiler warnings about unused variables.
9424
9425         * NEWS: Mention end of support for native debugging on MS-Windows
9426         before XP.
9427
9428         PR gdb/24292
9429         * common/netstuff.c:
9430         * gdbserver/gdbreplay.c
9431         * gdbserver/remote-utils.c:
9432         * ser-tcp.c:
9433         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9434         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9435         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9436         'getaddrinfo' and 'freeaddrinfo' were not available before
9437         Windows XP, and mingw.org's MinGW headers by default define
9438         _WIN32_WINNT to 0x500.
9439
9440 2019-03-01  Gary Benson <gbenson@redhat.com>
9441
9442         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9443
9444 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9445             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9446
9447         PR gdb/8527
9448         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9449         set_sigint_trap, clear_sigint_trap.
9450
9451 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9452
9453         * target.c (target_detach): Clear the regcache and the
9454         frame cache.
9455
9456 2019-02-27  Pedro Alves  <palves@redhat.com>
9457
9458         * utils.c (set_screen_size): When we cap the height/width sizes,
9459         tweak the corresponding command variable to show "unlimited":
9460
9461 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9462             Pedro Alves  <palves@redhat.com>
9463
9464         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9465         before calling rl_set_screen_size.
9466
9467 2019-02-27  Tom Tromey  <tromey@adacore.com>
9468
9469         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9470         define.
9471         * python/py-value.c: Remove Python 2.4 workaround.
9472         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9473         workaround.
9474         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9475         Python 2.4 workaround.
9476         * python/python-internal.h: Remove Python 2.4 comment.
9477         (Py_ssize_t): Don't define.
9478         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9479         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9480         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9481         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9482         * python/python.c (do_start_initialization): Remove Python 2.4
9483         workaround.
9484         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9485         (print_children): Remove Python 2.4 workaround.
9486         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9487         workaround.
9488         (CHARBUFFERPROC_NAME): Remove.
9489         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9490         Python 2.4 workaround.
9491
9492 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9493
9494         * NEWS: Note minimum Python version.
9495
9496 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9497
9498         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9499         code from these functions.  Remove corresponding ifdefs.  Use
9500         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9501         Remove gotos and target of gotos.
9502         (infpy_search_memory): Likewise.
9503
9504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9505
9506         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9507         (hppa_gdbarch_init): Don't register deleted functions with
9508         gdbarch.
9509
9510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9511
9512         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9513         (h8300_unwind_sp): Delete.
9514         (h8300_dummy_id): Delete.
9515         (h8300_gdbarch_init): Don't register deleted functions with
9516         gdbarch.
9517
9518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9519
9520         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9521         (ft32_unwind_pc): Delete.
9522         (ft32_unwind_sp): Delete.
9523         (ft32_gdbarch_init): Don't register deleted functions with
9524         gdbarch.
9525
9526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9527
9528         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9529         (frv_unwind_pc): Delete.
9530         (frv_unwind_sp): Delete.
9531         (frv_gdbarch_init): Don't register deleted functions with
9532         gdbarch.
9533
9534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9535
9536         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9537         (riscv_unwind_pc): Delete.
9538         (riscv_unwind_sp): Delete.
9539         (riscv_gdbarch_init): Don't register deleted functions with
9540         gdbarch.
9541
9542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9543
9544         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9545         (csky_unwind_pc): Delete.
9546         (csky_unwind_sp): Delete.
9547         (csky_gdbarch_init): Don't register deleted functions with
9548         gdbarch.
9549
9550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9551
9552         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9553         (cris_unwind_pc): Delete.
9554         (cris_unwind_sp): Delete.
9555         (cris_gdbarch_init): Don't register deleted functions with
9556         gdbarch.
9557
9558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9559
9560         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9561         (bfin_unwind_pc): Delete.
9562         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9563
9564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9565
9566         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9567         (arm_unwind_pc): Delete.
9568         (arm_unwind_sp): Delete.
9569         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9570
9571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9572
9573         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9574         (arc_unwind_pc): Delete.
9575         (arc_unwind_sp): Delete.
9576         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9577
9578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9579
9580         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9581         (alpha_unwind_pc): Delete.
9582         (alpha_gdbarch_init): Don't register deleted functions with
9583         gdbarch.
9584
9585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9586
9587         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9588         (aarch64_unwind_pc): Delete.
9589         (aarch64_unwind_sp): Delete.
9590         (aarch64_gdbarch_init): Don't register deleted functions with
9591         gdbarch.
9592
9593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9594
9595         * gdbtypes.c (type_align): Don't consider static members when
9596         computing structure alignment.
9597
9598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9599
9600         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9601         return 0 for other types.
9602         * arch-utils.c (default_type_align): Always return 0.
9603         * gdbarch.h: Regenerate.
9604         * gdbarch.sh (type_align): Extend comment.
9605         * gdbtypes.c (type_align): Add additional comments, always call
9606         gdbarch_type_align before applying the default rules.
9607         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9608         generic code will then apply a suitable default.
9609         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9610         types, return 0 for other types.
9611
9612 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9613
9614         * NEWS: Create a new section for the next release branch.
9615         Rename the section of the current branch, now that it has
9616         been cut.
9617
9618 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9619
9620         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9621         * version.in: Bump version to 8.3.50.DATE-git.
9622
9623 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9624
9625         * aix-thread.c (ptid_cmp): Remove unused variable.
9626         (get_signaled_thread): Likewise.
9627         (store_regs_user_thread): Likewise.
9628         (store_regs_kernel_thread): Likewise.
9629         (fetch_regs_kernel_thread): Remove shadowed variable.
9630
9631 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9632
9633         * features/riscv/32bit-cpu.xml: Add register numbers.
9634         * features/riscv/32bit-fpu.c: Regenerate.
9635         * features/riscv/32bit-fpu.xml: Add register numbers.
9636         * features/riscv/64bit-cpu.xml: Add register numbers.
9637         * features/riscv/64bit-fpu.c: Regenerate.
9638         * features/riscv/64bit-fpu.xml: Add register numbers.
9639
9640 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9641
9642         * NEWS: Mention two argument form of gdb.Value constructor.
9643         * python/py-value.c (convert_buffer_and_type_to_value): New
9644         function.
9645         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9646         Add support for handling an optional second argument.  Call
9647         convert_buffer_and_type_to_value as appropriate.
9648         * python/python-internal.h (Py_buffer_deleter): New struct.
9649         (Py_buffer_up): New typedef.
9650
9651 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9652
9653         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9654         instead of releasing ownership.
9655
9656 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9657
9658         * dwarf2read.c (open_and_init_dwp_file): Call
9659         elf_numsections instead of bfd_count_sections to initialize
9660         dwp_file->num_sections.
9661
9662 2019-02-25  Tom Tromey  <tromey@adacore.com>
9663
9664         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9665
9666 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9667
9668         * gcore.in: Add '--readnever' option when invoking GDB.
9669
9670 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9671
9672         * MAINTAINERS: Update my email address.
9673
9674 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9675
9676         * build-id.c (build_id_to_debug_bfd_1): New function.
9677         (build_id_to_debug_bfd): Look for separate debug file in
9678         sysroot.
9679
9680 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9681
9682         * gdbarch.sh: Update the copyright year range that is placed into
9683         generated files.
9684
9685 2019-02-22  Keith Seitz  <keiths@redhat.com>
9686
9687         PR symtab/23853
9688         * linespec.c (create_sals_line_offset): Search for the default
9689         symtab's filename instead of its fullname.
9690
9691 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9692
9693         * NEWS: Update style defaults.
9694
9695 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9696
9697         * main.c (captured_main_1): Disable styling in batch mode.
9698
9699 2019-02-20  Tom Tromey  <tom@tromey.com>
9700
9701         * symtab.c (symtab_symbol_info): Fix typos.
9702
9703 2019-02-20  Tom Tromey  <tromey@adacore.com>
9704
9705         * findcmd.c (_initialize_mem_search): Use upper case for
9706         metasyntactic variables.
9707
9708 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9709
9710         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9711         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9712
9713 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9714
9715         * top.h (source_file_name): Change to std::string.
9716         * top.c (source_file_name): Likewise.
9717         (command_line_input): Adjust.
9718         * cli/cli-script.c (script_from_file): Adjust.
9719
9720 2019-02-19  Tom Tromey  <tromey@adacore.com>
9721
9722         * ravenscar-thread.c
9723         (ravenscar_thread_target::update_thread_list): Don't call
9724         ada_build_task_list.
9725         * ada-lang.h (ada_build_task_list): Don't declare.
9726         * ada-tasks.c (struct ada_tasks_inferior_data)
9727         <task_list_valid_p>: Now bool.
9728         (read_known_tasks, ada_task_list_changed)
9729         (ada_tasks_invalidate_inferior_data): Update.
9730         (read_known_tasks_array): Return bool.
9731         (read_known_tasks_list): Likewise.
9732         (read_known_tasks): Return void.
9733         (ada_build_task_list): Now static.
9734
9735 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9736
9737         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9738         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9739
9740 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9741
9742         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9743         variant for ada_tasks_pspace_data_handle and
9744         ada_tasks_inferior_data_handle.
9745         (ada_tasks_pspace_data_cleanup): New function.
9746         (ada_tasks_inferior_data_cleanup): New function.
9747
9748 2019-02-17  Tom Tromey  <tom@tromey.com>
9749
9750         * macrotab.h (macro_source_fullname): Return a std::string.
9751         * macrotab.c (macro_include, check_for_redefinition)
9752         (macro_undef, macro_lookup_definition, foreach_macro)
9753         (foreach_macro_in_scope): Update.
9754         (macro_source_fullname): Return a std::string.
9755         * macrocmd.c (show_pp_source_pos): Update.
9756
9757 2019-02-17  Tom Tromey  <tom@tromey.com>
9758
9759         * macrocmd.c (show_pp_source_pos): Style the file names.
9760
9761 2019-02-17  Tom Tromey  <tom@tromey.com>
9762
9763         PR tui/24197:
9764         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9765
9766 2019-02-17  Tom Tromey  <tom@tromey.com>
9767
9768         * ada-lang.c (user_select_syms): Use filtered printing.
9769         * utils.c (wrap_style): New global.
9770         (desired_style): Remove.
9771         (emit_style_escape): Add stream parameter.
9772         (set_output_style, reset_terminal_style, prompt_for_continue):
9773         Update.
9774         (flush_wrap_buffer): Only flush gdb_stdout.
9775         (wrap_here): Set wrap_style.
9776         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9777         treat escape sequences as a character.  Change when wrap buffer is
9778         flushed.
9779         (fputs_styled): Do not set the output style when the default is
9780         requested.
9781         * ui-style.h (struct ui_file_style) <is_default>: New method.
9782         * source.c (print_source_lines_base): Emit escape sequences in one
9783         piece.
9784
9785 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9786
9787         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9788         integers and enumeration types.
9789
9790 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9791
9792         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9793         instead of lookup_symbol_in_language
9794         (do_exact_match): New function.
9795         (ada_get_symbol_name_matcher): Return do_exact_match when
9796         doing a verbatim match.
9797
9798 2019-02-15  Tom Tromey  <tromey@adacore.com>
9799
9800         * ravenscar-thread.c (ravenscar_thread_target::resume)
9801         (ravenscar_thread_target::wait): Special case wildcard requests.
9802
9803 2019-02-15  Tom Tromey  <tromey@adacore.com>
9804
9805         * ravenscar-thread.c (base_ptid): Remove.
9806         (struct ravenscar_thread_target) <close>: New method.
9807         <m_base_ptid>: New member.
9808         <update_inferior_ptid, active_task, task_is_currently_active,
9809         runtime_initialized>: Declare methods.
9810         <ravenscar_thread_target>: Add constructor.
9811         (ravenscar_thread_target::task_is_currently_active)
9812         (ravenscar_thread_target::update_inferior_ptid)
9813         (ravenscar_runtime_initialized): Rename.  Now methods.
9814         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9815         (ravenscar_thread_target::update_thread_list): Update.
9816         (ravenscar_thread_target::active_task): Now method.
9817         (ravenscar_thread_target::store_registers)
9818         (ravenscar_thread_target::prepare_to_store)
9819         (ravenscar_thread_target::prepare_to_store)
9820         (ravenscar_thread_target::mourn_inferior): Update.
9821         (ravenscar_inferior_created): Use "new" to create target.
9822         (ravenscar_thread_target::get_ada_task_ptid): Update.
9823         (_initialize_ravenscar): Don't initialize base_ptid.
9824         (ravenscar_ops): Remove global.
9825
9826 2019-02-15  Tom Tromey  <tromey@adacore.com>
9827
9828         * target.h (push_target): Declare new overload.
9829         * target.c (push_target): New overload, taking an rvalue reference.
9830         * remote.c (remote_target::open_1): Use push_target overload.
9831         * corelow.c (core_target_open): Use push_target overload.
9832
9833 2019-02-15  Tom Tromey  <tromey@adacore.com>
9834
9835         * ravenscar-thread.c (is_ravenscar_task)
9836         (ravenscar_task_is_currently_active): Return bool.
9837         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9838         (_initialize_ravenscar): Remove "(void)".
9839         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9840         Return bool.
9841
9842 2019-02-15  Tom Tromey  <tromey@adacore.com>
9843
9844         * ravenscar-thread.c (ravenscar_runtime_initializer)
9845         (has_ravenscar_runtime, get_running_thread_id)
9846         (ravenscar_thread_target::resume): Fix indentation.
9847
9848 2019-02-15  Tom Tromey  <tromey@adacore.com>
9849
9850         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9851         from ravenscar_arch_ops.
9852         (sparc_ravenscar_ops::fetch_registers)
9853         (sparc_ravenscar_ops::store_registers): Now methods.
9854         (sparc_ravenscar_prepare_to_store): Remove.
9855         (sparc_ravenscar_ops): Redefine.
9856         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9857         methods and destructor.  Remove members.
9858         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9859         (ravenscar_thread_target::store_registers)
9860         (ravenscar_thread_target::prepare_to_store): Update.
9861         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9862         Remove.
9863         (struct ppc_ravenscar_powerpc_ops): Derive from
9864         ravenscar_arch_ops.
9865         (ppc_ravenscar_powerpc_ops::fetch_registers)
9866         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9867         (ppc_ravenscar_powerpc_ops): Redefine.
9868         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9869         (ppc_ravenscar_e500_ops::fetch_registers)
9870         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9871         (ppc_ravenscar_e500_ops): Redefine.
9872         * aarch64-ravenscar-thread.c
9873         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9874         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9875         (aarch64_ravenscar_fetch_registers)
9876         (aarch64_ravenscar_store_registers): Now methods.
9877         (aarch64_ravenscar_ops): Redefine.
9878
9879 2019-02-15  Tom Tromey  <tromey@adacore.com>
9880
9881         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9882         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9883         (ravenscar_thread_target::stopped_by_watchpoint)
9884         (ravenscar_thread_target::stopped_data_address)
9885         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9886
9887 2019-02-15  Tom Tromey  <tromey@adacore.com>
9888
9889         * ravenscar-thread.c: Fix some typos.
9890
9891 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9892             Tom Tromey  <tromey@adacore.com>
9893
9894         * ada-lang.c (ada_exception_sal): Change addr_string to a
9895         std::string.
9896         (create_ada_exception_catchpoint): Update.
9897
9898 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9899             Tom Tromey  <tromey@adacore.com>
9900
9901         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9902         (bp_location_ops): Remove.
9903         (base_breakpoint_allocate_location): Update.
9904         (free_bp_location): Update.
9905         * ada-lang.c (class ada_catchpoint_location)
9906         <ada_catchpoint_location>: Remove ops parameter.
9907         (ada_catchpoint_location_dtor): Remove.
9908         (ada_catchpoint_location_ops): Remove.
9909         (allocate_location_exception): Update.
9910         * breakpoint.h (struct bp_location_ops): Remove.
9911         (class bp_location) <bp_location>: Remove bp_location_ops
9912         parameter.
9913         <~bp_location>: Add destructor.
9914         <ops>: Remove.
9915
9916 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9917             Pedro Alves  <palves@redhat.com>
9918
9919         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9920         'PATH_MAX'.
9921
9922 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9923             Samuel Thibault  <samuel.thibault@gnu.org>
9924             Thomas Schwinge  <thomas@codesourcery.com>
9925
9926         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9927         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9928
9929 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9930
9931         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9932         (check_empty): Use "const char *".
9933
9934         * gnu-nat.c (gnu_nat_target::detach): Instead of
9935         'detach_inferior (pid)' call
9936         'detach_inferior (find_inferior_pid (pid))'.
9937
9938         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9939         'nat/fork-inferior.o'.
9940         * gnu-nat.c: #include "nat/fork-inferior.h".
9941
9942         * gnu-nat.c (gnu_nat_target::detach): Instead of
9943         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9944         * gnu-nat.h: #include "inf-child.h".
9945         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9946         'i386_gnu_nat_target::fetch_registers'.
9947         (gnu_store_registers): Rename/move to
9948         'i386_gnu_nat_target::store_registers'.
9949
9950         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9951         * gnu-nat.h (mach_thread_info): New function.
9952         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9953
9954         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9955
9956 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9957
9958         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9959
9960 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9961
9962         * windows-nat.c (windows_add_thread): Add new parameter
9963         "main_thread_p" with default value set to false.  Update
9964         function documentation as well as all callers.
9965         (windows_delete_thread): Likewise.
9966         (fake_create_process): Update call to windows_add_thread.
9967         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9968         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9969         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9970         call to windows_delete_thread.
9971
9972 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9973
9974         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9975
9976 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9977
9978         * symfile.c (find_separate_debug_file): Use canonical path of
9979         sysroot with child_path instead of gdb_sysroot if it is valid.
9980
9981 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9982
9983         * symfile.c (find_separate_debug_file): Use child_path to
9984         determine if an object file is under a sysroot.
9985
9986 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9987
9988         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9989         unittests/child-path-selftests.c.
9990         * common/pathstuff.c (child_path): New function.
9991         * common/pathstuff.h (child_path): New prototype.
9992         * unittests/child-path-selftests.c: New file.
9993
9994 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9995
9996         * symfile.c (find_separate_debug_file): Look for separate debug
9997         files in debug directories under the sysroot.
9998
9999 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10000
10001         * symtab.h (struct minimal_symbol data_p): New const method.
10002         (struct minimal_symbol text_p): Likewise.
10003         * symtab.c (output_source_filename): Use file name style
10004         to print file name.
10005         (print_symbol_info): Likewise.
10006         (print_msymbol_info): Use address style to print addresses.
10007         Use function name style to print executable text symbols.
10008         (expand_symtab_containing_pc): Use data_p.
10009         (find_pc_sect_compunit_symtab): Likewise.
10010
10011 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10012
10013         * breakpoint.c (describe_other_breakpoints): Use address style
10014         to print addresses.
10015         (say_where): Likewise.
10016
10017 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10018
10019         * ada-typeprint.c (print_func_type): Print function name
10020         style to print function name.
10021         * c-typeprint.c (c_print_type_1): Likewise.
10022
10023 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10024
10025         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10026         for execve.
10027
10028 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10029
10030         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10031         type_stack.
10032
10033 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10034
10035         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10036         TYPE_CODE_REF types.
10037
10038 2019-02-08  Jim Wilson  <jimw@sifive.com>
10039
10040         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10041         (riscv_linux_fregset): New.
10042         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10043
10044 2019-02-07  Tom Tromey  <tom@tromey.com>
10045
10046         * thread.c (thread_cancel_execution_command): Update.
10047         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10048         methods.
10049         (struct thread_fsm_ops): Remove.
10050         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10051         (thread_fsm_should_stop, thread_fsm_return_value)
10052         (thread_fsm_set_finished, thread_fsm_finished_p)
10053         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10054         Don't declare.
10055         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10056         * infrun.c (clear_proceed_status_thread)
10057         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10058         (print_stop_event): Update.
10059         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10060         Add constructor.
10061         (step_command_fsm_ops): Remove.
10062         (new_step_command_fsm): Remove.
10063         (step_1): Update.
10064         (step_command_fsm::should_stop): Rename from
10065         step_command_fsm_should_stop.
10066         (step_command_fsm::clean_up): Rename from
10067         step_command_fsm_clean_up.
10068         (step_command_fsm::do_async_reply_reason): Rename from
10069         step_command_fsm_async_reply_reason.
10070         (struct until_next_fsm): Inherit from thread_fsm.  Add
10071         constructor.
10072         (until_next_fsm_ops): Remove.
10073         (new_until_next_fsm): Remove.
10074         (until_next_fsm::should_stop): Rename from
10075         until_next_fsm_should_stop.
10076         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10077         (until_next_fsm::do_async_reply_reason): Rename from
10078         until_next_fsm_async_reply_reason.
10079         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10080         constructor.  Change type of breakpoint.
10081         (finish_command_fsm_ops): Remove.
10082         (new_finish_command_fsm): Remove.
10083         (finish_command_fsm::should_stop): Rename from
10084         finish_command_fsm_should_stop.
10085         (finish_command_fsm::clean_up): Rename from
10086         finish_command_fsm_clean_up.
10087         (finish_command_fsm::return_value): Rename from
10088         finish_command_fsm_return_value.
10089         (finish_command_fsm::do_async_reply_reason): Rename from
10090         finish_command_fsm_async_reply_reason.
10091         (finish_command): Update.
10092         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10093         Add constructor.
10094         (call_thread_fsm_ops): Remove.
10095         (call_thread_fsm::call_thread_fsm): Rename from
10096         new_call_thread_fsm.
10097         (call_thread_fsm::should_stop): Rename from
10098         call_thread_fsm_should_stop.
10099         (call_thread_fsm::should_notify_stop): Rename from
10100         call_thread_fsm_should_notify_stop.
10101         (run_inferior_call, call_function_by_hand_dummy): Update.
10102         * cli/cli-interp.c (should_print_stop_to_console): Update.
10103         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10104         Add constructor.  Change type of location_breakpoint,
10105         caller_breakpoint.
10106         (until_break_fsm_ops): Remove.
10107         (new_until_break_fsm): Remove.
10108         (until_break_fsm::should_stop): Rename from
10109         until_break_fsm_should_stop.
10110         (until_break_fsm::clean_up): Rename from
10111         until_break_fsm_clean_up.
10112         (until_break_fsm::do_async_reply_reason): Rename from
10113         until_break_fsm_async_reply_reason.
10114         (until_break_command): Update.
10115         * thread-fsm.c: Remove.
10116         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10117
10118 2019-02-07  Tom Tromey  <tom@tromey.com>
10119
10120         * yy-remap.h: Add include guard.
10121         * xtensa-tdep.h: Add include guard.
10122         * xcoffread.h: Rename include guard.
10123         * varobj-iter.h: Add include guard.
10124         * tui/tui.h: Rename include guard.
10125         * tui/tui-winsource.h: Rename include guard.
10126         * tui/tui-wingeneral.h: Rename include guard.
10127         * tui/tui-windata.h: Rename include guard.
10128         * tui/tui-win.h: Rename include guard.
10129         * tui/tui-stack.h: Rename include guard.
10130         * tui/tui-source.h: Rename include guard.
10131         * tui/tui-regs.h: Rename include guard.
10132         * tui/tui-out.h: Rename include guard.
10133         * tui/tui-layout.h: Rename include guard.
10134         * tui/tui-io.h: Rename include guard.
10135         * tui/tui-hooks.h: Rename include guard.
10136         * tui/tui-file.h: Rename include guard.
10137         * tui/tui-disasm.h: Rename include guard.
10138         * tui/tui-data.h: Rename include guard.
10139         * tui/tui-command.h: Rename include guard.
10140         * tic6x-tdep.h: Add include guard.
10141         * target/waitstatus.h: Rename include guard.
10142         * target/wait.h: Rename include guard.
10143         * target/target.h: Rename include guard.
10144         * target/resume.h: Rename include guard.
10145         * target-float.h: Rename include guard.
10146         * stabsread.h: Add include guard.
10147         * rs6000-tdep.h: Add include guard.
10148         * riscv-fbsd-tdep.h: Add include guard.
10149         * regformats/regdef.h: Rename include guard.
10150         * record.h: Rename include guard.
10151         * python/python.h: Rename include guard.
10152         * python/python-internal.h: Rename include guard.
10153         * python/py-stopevent.h: Rename include guard.
10154         * python/py-ref.h: Rename include guard.
10155         * python/py-record.h: Rename include guard.
10156         * python/py-record-full.h: Rename include guard.
10157         * python/py-record-btrace.h: Rename include guard.
10158         * python/py-instruction.h: Rename include guard.
10159         * python/py-events.h: Rename include guard.
10160         * python/py-event.h: Rename include guard.
10161         * procfs.h: Add include guard.
10162         * proc-utils.h: Add include guard.
10163         * p-lang.h: Add include guard.
10164         * or1k-tdep.h: Rename include guard.
10165         * observable.h: Rename include guard.
10166         * nto-tdep.h: Rename include guard.
10167         * nat/x86-linux.h: Rename include guard.
10168         * nat/x86-linux-dregs.h: Rename include guard.
10169         * nat/x86-gcc-cpuid.h: Add include guard.
10170         * nat/x86-dregs.h: Rename include guard.
10171         * nat/x86-cpuid.h: Rename include guard.
10172         * nat/ppc-linux.h: Rename include guard.
10173         * nat/mips-linux-watch.h: Rename include guard.
10174         * nat/linux-waitpid.h: Rename include guard.
10175         * nat/linux-ptrace.h: Rename include guard.
10176         * nat/linux-procfs.h: Rename include guard.
10177         * nat/linux-osdata.h: Rename include guard.
10178         * nat/linux-nat.h: Rename include guard.
10179         * nat/linux-namespaces.h: Rename include guard.
10180         * nat/linux-btrace.h: Rename include guard.
10181         * nat/glibc_thread_db.h: Rename include guard.
10182         * nat/gdb_thread_db.h: Rename include guard.
10183         * nat/gdb_ptrace.h: Rename include guard.
10184         * nat/fork-inferior.h: Rename include guard.
10185         * nat/amd64-linux-siginfo.h: Rename include guard.
10186         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10187         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10188         * nat/aarch64-linux.h: Rename include guard.
10189         * nat/aarch64-linux-hw-point.h: Rename include guard.
10190         * mn10300-tdep.h: Add include guard.
10191         * mips-linux-tdep.h: Add include guard.
10192         * mi/mi-parse.h: Rename include guard.
10193         * mi/mi-out.h: Rename include guard.
10194         * mi/mi-main.h: Rename include guard.
10195         * mi/mi-interp.h: Rename include guard.
10196         * mi/mi-getopt.h: Rename include guard.
10197         * mi/mi-console.h: Rename include guard.
10198         * mi/mi-common.h: Rename include guard.
10199         * mi/mi-cmds.h: Rename include guard.
10200         * mi/mi-cmd-break.h: Rename include guard.
10201         * m2-lang.h: Add include guard.
10202         * location.h: Rename include guard.
10203         * linux-record.h: Rename include guard.
10204         * linux-nat.h: Add include guard.
10205         * linux-fork.h: Add include guard.
10206         * i386-darwin-tdep.h: Rename include guard.
10207         * hppa-linux-offsets.h: Add include guard.
10208         * guile/guile.h: Rename include guard.
10209         * guile/guile-internal.h: Rename include guard.
10210         * gnu-nat.h: Rename include guard.
10211         * gdb-stabs.h: Rename include guard.
10212         * frv-tdep.h: Add include guard.
10213         * f-lang.h: Add include guard.
10214         * event-loop.h: Add include guard.
10215         * darwin-nat.h: Rename include guard.
10216         * cp-abi.h: Rename include guard.
10217         * config/sparc/nm-sol2.h: Rename include guard.
10218         * config/nm-nto.h: Rename include guard.
10219         * config/nm-linux.h: Add include guard.
10220         * config/i386/nm-i386gnu.h: Rename include guard.
10221         * config/djgpp/nl_types.h: Rename include guard.
10222         * config/djgpp/langinfo.h: Rename include guard.
10223         * compile/gcc-cp-plugin.h: Add include guard.
10224         * compile/gcc-c-plugin.h: Add include guard.
10225         * compile/compile.h: Rename include guard.
10226         * compile/compile-object-run.h: Rename include guard.
10227         * compile/compile-object-load.h: Rename include guard.
10228         * compile/compile-internal.h: Rename include guard.
10229         * compile/compile-cplus.h: Rename include guard.
10230         * compile/compile-c.h: Rename include guard.
10231         * common/xml-utils.h: Rename include guard.
10232         * common/x86-xstate.h: Rename include guard.
10233         * common/version.h: Rename include guard.
10234         * common/vec.h: Rename include guard.
10235         * common/tdesc.h: Rename include guard.
10236         * common/selftest.h: Rename include guard.
10237         * common/scoped_restore.h: Rename include guard.
10238         * common/scoped_mmap.h: Rename include guard.
10239         * common/scoped_fd.h: Rename include guard.
10240         * common/safe-iterator.h: Rename include guard.
10241         * common/run-time-clock.h: Rename include guard.
10242         * common/refcounted-object.h: Rename include guard.
10243         * common/queue.h: Rename include guard.
10244         * common/ptid.h: Rename include guard.
10245         * common/print-utils.h: Rename include guard.
10246         * common/preprocessor.h: Rename include guard.
10247         * common/pathstuff.h: Rename include guard.
10248         * common/observable.h: Rename include guard.
10249         * common/netstuff.h: Rename include guard.
10250         * common/job-control.h: Rename include guard.
10251         * common/host-defs.h: Rename include guard.
10252         * common/gdb_wait.h: Rename include guard.
10253         * common/gdb_vecs.h: Rename include guard.
10254         * common/gdb_unlinker.h: Rename include guard.
10255         * common/gdb_unique_ptr.h: Rename include guard.
10256         * common/gdb_tilde_expand.h: Rename include guard.
10257         * common/gdb_sys_time.h: Rename include guard.
10258         * common/gdb_string_view.h: Rename include guard.
10259         * common/gdb_splay_tree.h: Rename include guard.
10260         * common/gdb_setjmp.h: Rename include guard.
10261         * common/gdb_ref_ptr.h: Rename include guard.
10262         * common/gdb_optional.h: Rename include guard.
10263         * common/gdb_locale.h: Rename include guard.
10264         * common/gdb_assert.h: Rename include guard.
10265         * common/filtered-iterator.h: Rename include guard.
10266         * common/filestuff.h: Rename include guard.
10267         * common/fileio.h: Rename include guard.
10268         * common/environ.h: Rename include guard.
10269         * common/common-utils.h: Rename include guard.
10270         * common/common-types.h: Rename include guard.
10271         * common/common-regcache.h: Rename include guard.
10272         * common/common-inferior.h: Rename include guard.
10273         * common/common-gdbthread.h: Rename include guard.
10274         * common/common-exceptions.h: Rename include guard.
10275         * common/common-defs.h: Rename include guard.
10276         * common/common-debug.h: Rename include guard.
10277         * common/cleanups.h: Rename include guard.
10278         * common/buffer.h: Rename include guard.
10279         * common/btrace-common.h: Rename include guard.
10280         * common/break-common.h: Rename include guard.
10281         * cli/cli-utils.h: Rename include guard.
10282         * cli/cli-style.h: Rename include guard.
10283         * cli/cli-setshow.h: Rename include guard.
10284         * cli/cli-script.h: Rename include guard.
10285         * cli/cli-interp.h: Rename include guard.
10286         * cli/cli-decode.h: Rename include guard.
10287         * cli/cli-cmds.h: Rename include guard.
10288         * charset-list.h: Add include guard.
10289         * buildsym-legacy.h: Rename include guard.
10290         * bfin-tdep.h: Add include guard.
10291         * ax.h: Rename include guard.
10292         * arm-linux-tdep.h: Add include guard.
10293         * arm-fbsd-tdep.h: Add include guard.
10294         * arch/xtensa.h: Rename include guard.
10295         * arch/tic6x.h: Add include guard.
10296         * arch/i386.h: Add include guard.
10297         * arch/arm.h: Rename include guard.
10298         * arch/arm-linux.h: Rename include guard.
10299         * arch/arm-get-next-pcs.h: Rename include guard.
10300         * arch/amd64.h: Add include guard.
10301         * arch/aarch64-insn.h: Rename include guard.
10302         * arch-utils.h: Rename include guard.
10303         * annotate.h: Add include guard.
10304         * amd64-darwin-tdep.h: Rename include guard.
10305         * aarch64-linux-tdep.h: Add include guard.
10306         * aarch64-fbsd-tdep.h: Add include guard.
10307         * aarch32-linux-nat.h: Add include guard.
10308
10309 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10310
10311         * macrotab.c (macro_define_internal): New function that
10312         factorizes macro_define_object_internal and macro_define_function
10313         code.
10314         (macro_define_object_internal): Use macro_define_internal.
10315         (macro_define_function): Likewise.
10316
10317 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10318
10319         * macrocmd.c (extract_identifier): Return
10320         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10321         callers.
10322
10323 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10324
10325         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10326
10327 2019-02-05  Tom Tromey  <tom@tromey.com>
10328
10329         * target.c (target_stack::unpush): Move assertion earlier.
10330
10331 2019-01-30  Tom Tromey  <tom@tromey.com>
10332
10333         PR python/23615:
10334         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10335         (gdbpy_parse_and_eval): Likewise.
10336         * python/python-internal.h (gdbpy_allow_threads): New class.
10337
10338 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10339
10340         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10341         (aarch64_fbsd_fpregmap): Move earlier.
10342         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10343         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10344         instead of individual calls to trad_frame_set_reg_addr.
10345         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10346         earlier.
10347         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10348         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10349         instead of individual calls to trad_frame_set_reg_addr.
10350
10351 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10352
10353         * CONTRIBUTE: Replace contribution list with wiki link.
10354
10355 2019-01-25  Tom Tromey  <tom@tromey.com>
10356
10357         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10358
10359 2019-01-25  Tom Tromey  <tom@tromey.com>
10360
10361         * xtensa-linux-nat.c: Fix common/ includes.
10362         * xml-support.h: Fix common/ includes.
10363         * xml-support.c: Fix common/ includes.
10364         * x86-linux-nat.c: Fix common/ includes.
10365         * windows-nat.c: Fix common/ includes.
10366         * varobj.h: Fix common/ includes.
10367         * varobj.c: Fix common/ includes.
10368         * value.c: Fix common/ includes.
10369         * valops.c: Fix common/ includes.
10370         * utils.c: Fix common/ includes.
10371         * unittests/xml-utils-selftests.c: Fix common/ includes.
10372         * unittests/utils-selftests.c: Fix common/ includes.
10373         * unittests/unpack-selftests.c: Fix common/ includes.
10374         * unittests/tracepoint-selftests.c: Fix common/ includes.
10375         * unittests/style-selftests.c: Fix common/ includes.
10376         * unittests/string_view-selftests.c: Fix common/ includes.
10377         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10378         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10379         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10380         * unittests/rsp-low-selftests.c: Fix common/ includes.
10381         * unittests/parse-connection-spec-selftests.c: Fix common/
10382         includes.
10383         * unittests/optional-selftests.c: Fix common/ includes.
10384         * unittests/offset-type-selftests.c: Fix common/ includes.
10385         * unittests/observable-selftests.c: Fix common/ includes.
10386         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10387         * unittests/memrange-selftests.c: Fix common/ includes.
10388         * unittests/memory-map-selftests.c: Fix common/ includes.
10389         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10390         * unittests/function-view-selftests.c: Fix common/ includes.
10391         * unittests/environ-selftests.c: Fix common/ includes.
10392         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10393         * unittests/common-utils-selftests.c: Fix common/ includes.
10394         * unittests/cli-utils-selftests.c: Fix common/ includes.
10395         * unittests/array-view-selftests.c: Fix common/ includes.
10396         * ui-file.c: Fix common/ includes.
10397         * tui/tui-io.c: Fix common/ includes.
10398         * tracepoint.h: Fix common/ includes.
10399         * tracepoint.c: Fix common/ includes.
10400         * tracefile-tfile.c: Fix common/ includes.
10401         * top.h: Fix common/ includes.
10402         * top.c: Fix common/ includes.
10403         * thread.c: Fix common/ includes.
10404         * target/waitstatus.h: Fix common/ includes.
10405         * target/waitstatus.c: Fix common/ includes.
10406         * target.h: Fix common/ includes.
10407         * target.c: Fix common/ includes.
10408         * target-memory.c: Fix common/ includes.
10409         * target-descriptions.c: Fix common/ includes.
10410         * symtab.h: Fix common/ includes.
10411         * symfile.c: Fix common/ includes.
10412         * stap-probe.c: Fix common/ includes.
10413         * spu-linux-nat.c: Fix common/ includes.
10414         * sparc-nat.c: Fix common/ includes.
10415         * source.c: Fix common/ includes.
10416         * solib.c: Fix common/ includes.
10417         * solib-target.c: Fix common/ includes.
10418         * ser-unix.c: Fix common/ includes.
10419         * ser-tcp.c: Fix common/ includes.
10420         * ser-pipe.c: Fix common/ includes.
10421         * ser-base.c: Fix common/ includes.
10422         * selftest-arch.c: Fix common/ includes.
10423         * s12z-tdep.c: Fix common/ includes.
10424         * rust-exp.y: Fix common/ includes.
10425         * rs6000-aix-tdep.c: Fix common/ includes.
10426         * riscv-tdep.c: Fix common/ includes.
10427         * remote.c: Fix common/ includes.
10428         * remote-notif.h: Fix common/ includes.
10429         * remote-fileio.h: Fix common/ includes.
10430         * remote-fileio.c: Fix common/ includes.
10431         * regcache.h: Fix common/ includes.
10432         * regcache.c: Fix common/ includes.
10433         * record-btrace.c: Fix common/ includes.
10434         * python/python.c: Fix common/ includes.
10435         * python/py-type.c: Fix common/ includes.
10436         * python/py-inferior.c: Fix common/ includes.
10437         * progspace.h: Fix common/ includes.
10438         * producer.c: Fix common/ includes.
10439         * procfs.c: Fix common/ includes.
10440         * proc-api.c: Fix common/ includes.
10441         * printcmd.c: Fix common/ includes.
10442         * ppc-linux-nat.c: Fix common/ includes.
10443         * parser-defs.h: Fix common/ includes.
10444         * osdata.c: Fix common/ includes.
10445         * obsd-nat.c: Fix common/ includes.
10446         * nat/x86-linux.c: Fix common/ includes.
10447         * nat/x86-linux-dregs.c: Fix common/ includes.
10448         * nat/x86-dregs.h: Fix common/ includes.
10449         * nat/x86-dregs.c: Fix common/ includes.
10450         * nat/ppc-linux.c: Fix common/ includes.
10451         * nat/mips-linux-watch.h: Fix common/ includes.
10452         * nat/mips-linux-watch.c: Fix common/ includes.
10453         * nat/linux-waitpid.c: Fix common/ includes.
10454         * nat/linux-ptrace.h: Fix common/ includes.
10455         * nat/linux-ptrace.c: Fix common/ includes.
10456         * nat/linux-procfs.c: Fix common/ includes.
10457         * nat/linux-personality.c: Fix common/ includes.
10458         * nat/linux-osdata.c: Fix common/ includes.
10459         * nat/linux-namespaces.c: Fix common/ includes.
10460         * nat/linux-btrace.h: Fix common/ includes.
10461         * nat/linux-btrace.c: Fix common/ includes.
10462         * nat/fork-inferior.c: Fix common/ includes.
10463         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10464         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10465         * nat/aarch64-linux.c: Fix common/ includes.
10466         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10467         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10468         * namespace.h: Fix common/ includes.
10469         * mips-linux-tdep.c: Fix common/ includes.
10470         * minsyms.c: Fix common/ includes.
10471         * mi/mi-parse.h: Fix common/ includes.
10472         * mi/mi-main.c: Fix common/ includes.
10473         * mi/mi-cmd-env.c: Fix common/ includes.
10474         * memrange.h: Fix common/ includes.
10475         * memattr.c: Fix common/ includes.
10476         * maint.h: Fix common/ includes.
10477         * maint.c: Fix common/ includes.
10478         * main.c: Fix common/ includes.
10479         * machoread.c: Fix common/ includes.
10480         * location.c: Fix common/ includes.
10481         * linux-thread-db.c: Fix common/ includes.
10482         * linux-nat.c: Fix common/ includes.
10483         * linux-fork.c: Fix common/ includes.
10484         * inline-frame.c: Fix common/ includes.
10485         * infrun.c: Fix common/ includes.
10486         * inflow.c: Fix common/ includes.
10487         * inferior.h: Fix common/ includes.
10488         * inferior.c: Fix common/ includes.
10489         * infcmd.c: Fix common/ includes.
10490         * inf-ptrace.c: Fix common/ includes.
10491         * inf-child.c: Fix common/ includes.
10492         * ia64-linux-nat.c: Fix common/ includes.
10493         * i387-tdep.c: Fix common/ includes.
10494         * i386-tdep.c: Fix common/ includes.
10495         * i386-linux-tdep.c: Fix common/ includes.
10496         * i386-linux-nat.c: Fix common/ includes.
10497         * i386-go32-tdep.c: Fix common/ includes.
10498         * i386-fbsd-tdep.c: Fix common/ includes.
10499         * i386-fbsd-nat.c: Fix common/ includes.
10500         * guile/scm-type.c: Fix common/ includes.
10501         * guile/guile.c: Fix common/ includes.
10502         * go32-nat.c: Fix common/ includes.
10503         * gnu-nat.c: Fix common/ includes.
10504         * gdbthread.h: Fix common/ includes.
10505         * gdbarch-selftests.c: Fix common/ includes.
10506         * gdb_usleep.c: Fix common/ includes.
10507         * gdb_select.h: Fix common/ includes.
10508         * gdb_bfd.c: Fix common/ includes.
10509         * gcore.c: Fix common/ includes.
10510         * fork-child.c: Fix common/ includes.
10511         * findvar.c: Fix common/ includes.
10512         * fbsd-nat.c: Fix common/ includes.
10513         * event-top.c: Fix common/ includes.
10514         * event-loop.c: Fix common/ includes.
10515         * dwarf2read.c: Fix common/ includes.
10516         * dwarf2loc.c: Fix common/ includes.
10517         * dwarf2-frame.c: Fix common/ includes.
10518         * dwarf-index-cache.c: Fix common/ includes.
10519         * dtrace-probe.c: Fix common/ includes.
10520         * disasm-selftests.c: Fix common/ includes.
10521         * defs.h: Fix common/ includes.
10522         * csky-tdep.c: Fix common/ includes.
10523         * cp-valprint.c: Fix common/ includes.
10524         * cp-support.h: Fix common/ includes.
10525         * cp-support.c: Fix common/ includes.
10526         * corelow.c: Fix common/ includes.
10527         * completer.h: Fix common/ includes.
10528         * completer.c: Fix common/ includes.
10529         * compile/compile.c: Fix common/ includes.
10530         * compile/compile-loc2c.c: Fix common/ includes.
10531         * compile/compile-cplus-types.c: Fix common/ includes.
10532         * compile/compile-cplus-symbols.c: Fix common/ includes.
10533         * command.h: Fix common/ includes.
10534         * cli/cli-dump.c: Fix common/ includes.
10535         * cli/cli-cmds.c: Fix common/ includes.
10536         * charset.c: Fix common/ includes.
10537         * build-id.c: Fix common/ includes.
10538         * btrace.h: Fix common/ includes.
10539         * btrace.c: Fix common/ includes.
10540         * breakpoint.h: Fix common/ includes.
10541         * breakpoint.c: Fix common/ includes.
10542         * ax.h:
10543         (enum agent_op): Fix common/ includes.
10544         * ax-general.c (struct aop_map): Fix common/ includes.
10545         * ax-gdb.c: Fix common/ includes.
10546         * auxv.c: Fix common/ includes.
10547         * auto-load.c: Fix common/ includes.
10548         * arm-tdep.c: Fix common/ includes.
10549         * arch/riscv.c: Fix common/ includes.
10550         * arch/ppc-linux-common.c: Fix common/ includes.
10551         * arch/i386.c: Fix common/ includes.
10552         * arch/arm.c: Fix common/ includes.
10553         * arch/arm-linux.c: Fix common/ includes.
10554         * arch/arm-get-next-pcs.c: Fix common/ includes.
10555         * arch/amd64.c: Fix common/ includes.
10556         * arch/aarch64.c: Fix common/ includes.
10557         * arch/aarch64-insn.c: Fix common/ includes.
10558         * arch-utils.c: Fix common/ includes.
10559         * amd64-windows-tdep.c: Fix common/ includes.
10560         * amd64-tdep.c: Fix common/ includes.
10561         * amd64-sol2-tdep.c: Fix common/ includes.
10562         * amd64-obsd-tdep.c: Fix common/ includes.
10563         * amd64-nbsd-tdep.c: Fix common/ includes.
10564         * amd64-linux-tdep.c: Fix common/ includes.
10565         * amd64-linux-nat.c: Fix common/ includes.
10566         * amd64-fbsd-tdep.c: Fix common/ includes.
10567         * amd64-fbsd-nat.c: Fix common/ includes.
10568         * amd64-dicos-tdep.c: Fix common/ includes.
10569         * amd64-darwin-tdep.c: Fix common/ includes.
10570         * agent.c: Fix common/ includes.
10571         * ada-lang.h: Fix common/ includes.
10572         * ada-lang.c: Fix common/ includes.
10573         * aarch64-tdep.c: Fix common/ includes.
10574
10575 2019-01-25  Tom Tromey  <tom@tromey.com>
10576
10577         * common/create-version.sh: Use common/version.h.
10578
10579 2019-01-24  Pedro Alves  <palves@redhat.com>
10580
10581         * infrun.c (signal_stop, signal_print, signal_program)
10582         (signal_catch, signal_pass): Now arrays instead of pointers.
10583         (update_signals_program_target, do_target_resume)
10584         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10585         * linux-nat.c (linux_nat_target::pass_signals)
10586         (linux_nat_target::create_inferior, linux_nat_target::attach):
10587         Adjust.
10588         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10589         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10590         * procfs.c (procfs_target::pass_signals): Adjust.
10591         * record-full.c (record_full_target::resume): Adjust.
10592         * remote.c (remote_target::pass_signals)
10593         (remote_target::program_signals): Adjust.
10594         * target-debug.h (target_debug_print_signals): Now takes a
10595         gdb::array_view as parameter.  Adjust.
10596         * target.h (target_ops) <pass_signals, program_signals>: Replace
10597         pointer and length parameters with gdb::array_view.
10598         (target_pass_signals, target_program_signals): Likewise.
10599         * target-delegates.c: Regenerate.
10600
10601 2019-01-24  Pedro Alves  <palves@redhat.com>
10602
10603         * common/forward-scope-exit.h
10604         (forward_scope_exit::forward_scope_exit): Pass arguments to
10605         m_bind_function directly, instead of creating a std::bind and
10606         copying that.
10607
10608 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10609
10610         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10611         for static members.
10612         (pass_in_v_vfp_candidate): Likewise.
10613
10614 2019-01-23  Tom Tromey  <tom@tromey.com>
10615             Pedro Alves  <palves@redhat.com>
10616
10617         * regcache.c (class regcache_invalidator): Remove.
10618         (regcache::raw_write): Use make_scope_exit.
10619
10620 2019-01-23  Tom Tromey  <tom@tromey.com>
10621
10622         * ui-out.h (class ui_out_emit_type): Update comment.
10623
10624 2019-01-23  Tom Tromey  <tom@tromey.com>
10625
10626         * infrun.c (fetch_inferior_event): Update comment.
10627
10628 2019-01-23  Tom Tromey  <tom@tromey.com>
10629             Pedro Alves  <palves@redhat.com>
10630
10631         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10632         parameter.
10633         (fetch_inferior_event): Use SCOPE_EXIT.
10634
10635
10636 2019-01-23  Tom Tromey  <tom@tromey.com>
10637             Pedro Alves  <palves@redhat.com>
10638
10639         * infrun.c (disable_thread_events): Delete.
10640         (stop_all_threads): Use SCOPE_EXIT.
10641
10642 2019-01-23  Tom Tromey  <tom@tromey.com>
10643             Pedro Alves  <palves@redhat.com>
10644
10645         * symfile.c: Include forward-scope-exit.h.
10646         (clear_symtab_users_cleanup): Replace forward declaration with
10647         a FORWARD_SCOPE_EXIT.
10648         (syms_from_objfile_1): Use the forward_scope_exit and
10649         gdb::optional instead of cleanup_function.
10650         (reread_symbols): Use the forward_scope_exit instead of
10651         cleanup_function.
10652         (clear_symtab_users_cleanup): Remove function.
10653
10654 2019-01-23  Tom Tromey  <tom@tromey.com>
10655             Pedro Alves  <palves@redhat.com>
10656
10657         * linux-nat.c: Include scope-exit.h.
10658         (cleanup_target_stop): Remove.
10659         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10660         SCOPE_EXIT.
10661
10662 2019-01-23  Tom Tromey  <tom@tromey.com>
10663             Pedro Alves  <palves@redhat.com>
10664
10665         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10666         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10667
10668 2019-01-23  Tom Tromey  <tom@tromey.com>
10669             Andrew Burgess  <andrew.burgess@embecosm.com>
10670             Pedro Alves  <palves@redhat.com>
10671
10672         * infrun.c (fetch_inferior_event): Use scope_exit.
10673         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10674         * top.c (execute_command): Use scope_exit.
10675         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10676         * utils.c (do_bpstat_clear_actions_cleanup)
10677         (make_bpstat_clear_actions_cleanup): Remove.
10678
10679 2019-01-23  Tom Tromey  <tom@tromey.com>
10680             Pedro Alves  <palves@redhat.com>
10681
10682         * infrun.c: Include "common/scope-exit.h"
10683         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10684         (wait_for_inferior): Use SCOPE_EXIT.
10685         (fetch_inferior_event): Use scope_exit.
10686
10687 2019-01-23  Tom Tromey  <tom@tromey.com>
10688             Pedro Alves  <palves@redhat.com>
10689
10690         * breakpoint.c (create_breakpoint): Remove cleanup.
10691
10692 2019-01-23  Tom Tromey  <tom@tromey.com>
10693             Andrew Burgess  <andrew.burgess@embecosm.com>
10694             Pedro Alves  <palves@redhat.com>
10695
10696 2019-01-23  Pedro Alves  <palves@redhat.com>
10697
10698         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10699
10700 2019-01-23  Pedro Alves  <palves@redhat.com>
10701             Andrew Burgess  <andrew.burgess@embecosm.com>
10702
10703         * gdbthread.h: Include "common/forward-scope-exit.h".
10704         (scoped_finish_thread_state): Redefine custom class in terms of
10705         forward_scope_exit.
10706
10707 2019-01-23  Pedro Alves  <palves@redhat.com>
10708             Andrew Burgess  <andrew.burgess@embecosm.com>
10709
10710         * common/forward-scope-exit.h: New file.
10711
10712 2019-01-23  Pedro Alves  <palves@redhat.com>
10713             Andrew Burgess  <andrew.burgess@embecosm.com>
10714             Tom Tromey  <tom@tromey.com>
10715
10716         * common/scope-exit.h: New file.
10717
10718 2019-01-23  Pedro Alves  <palves@redhat.com>
10719
10720         * common/preprocessor.h (ESC): Rename to ...
10721         (ESC_PARENS): ... this.
10722         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10723         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10724
10725 2019-01-23  Tom Tromey  <tom@tromey.com>
10726
10727         * language.h (class scoped_switch_to_sym_language_if_auto):
10728         Initialize m_lang in both cases.
10729
10730 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10731
10732         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10733         with XCNEW.
10734
10735 2019-01-22  Tom Tromey  <tom@tromey.com>
10736
10737         * corelow.c: Do not include sys/file.h.
10738
10739 2019-01-22  Tom Tromey  <tom@tromey.com>
10740
10741         * tui/tui-wingeneral.h: Include gdb_curses.h.
10742
10743 2019-01-22  Tom Tromey  <tom@tromey.com>
10744
10745         * source-cache.h (class source_cache) <get_source_lines,
10746         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10747
10748 2019-01-22  Tom Tromey  <tom@tromey.com>
10749
10750         * remote-fileio.h (struct remote_target): Declare.
10751
10752 2019-01-22  Tom Tromey  <tom@tromey.com>
10753
10754         * python/py-arch.c: Do not include py-ref.h.
10755         * python/py-bpevent.c: Do not include py-ref.h.
10756         * python/py-cmd.c: Do not include py-ref.h.
10757         * python/py-continueevent.c: Do not include py-ref.h.
10758         * python/py-event.h: Do not include py-ref.h.
10759         * python/py-evtregistry.c: Do not include py-ref.h.
10760         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10761         * python/py-frame.c: Do not include py-ref.h.
10762         * python/py-framefilter.c: Do not include py-ref.h.
10763         * python/py-function.c: Do not include py-ref.h.
10764         * python/py-infevents.c: Do not include py-ref.h.
10765         * python/py-linetable.c: Do not include py-ref.h.
10766         * python/py-objfile.c: Do not include py-ref.h.
10767         * python/py-param.c: Do not include py-ref.h.
10768         * python/py-prettyprint.c: Do not include py-ref.h.
10769         * python/py-progspace.c: Do not include py-ref.h.
10770         * python/py-symbol.c: Do not include py-ref.h.
10771         * python/py-symtab.c: Do not include py-ref.h.
10772         * python/py-type.c: Do not include py-ref.h.
10773         * python/py-unwind.c: Do not include py-ref.h.
10774         * python/py-utils.c: Do not include py-ref.h.
10775         * python/py-value.c: Do not include py-ref.h.
10776         * python/py-varobj.c: Do not include py-ref.h.
10777         * python/py-xmethods.c: Do not include py-ref.h.
10778         * python/python.c: Do not include py-ref.h.
10779         * varobj.c: Do not include py-ref.h.
10780
10781 2019-01-22  Tom Tromey  <tom@tromey.com>
10782
10783         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10784         keyword for bcache.
10785
10786 2019-01-22  Tom Tromey  <tom@tromey.com>
10787
10788         * compile/compile-cplus-types.c: Remove a comment by #include.
10789
10790 2019-01-22  Tom Tromey  <tom@tromey.com>
10791
10792         * compile/gcc-c-plugin.h: Include compile-internal.h.
10793
10794 2019-01-22  Tom Tromey  <tom@tromey.com>
10795
10796         * stabsread.c (EXTERN): Do not define.
10797         (symnum, next_symbol_text_func, processing_gcc_compilation)
10798         (within_function, global_sym_chain, global_stabs)
10799         (previous_stab_code, this_object_header_files)
10800         (n_this_object_header_files)
10801         (n_allocated_this_object_header_files): Define.
10802         * stabsread.h (EXTERN): Never define.  Use "extern".
10803
10804 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10805
10806         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10807         history_value.
10808
10809 2019-01-21  Tom Tromey  <tom@tromey.com>
10810
10811         * ui-out.c: Fix includes.
10812         * tui/tui-source.c: Fix includes.
10813         * target.c: Fix includes.
10814         * remote.c: Fix includes.
10815         * regcache.c: Fix includes.
10816         * python/py-block.c: Fix includes.
10817         * printcmd.c: Fix includes.
10818         * or1k-tdep.c: Fix includes.
10819         * mi/mi-main.c: Fix includes.
10820         * m32r-tdep.c: Fix includes.
10821         * csky-tdep.c: Fix includes.
10822         * compile/compile-cplus-types.c: Fix includes.
10823         * cli/cli-interp.c: Fix includes.
10824
10825 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10826
10827         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10828         for padding.
10829
10830 2019-01-16  Tom Tromey  <tom@tromey.com>
10831
10832         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10833         earlier.
10834         (struct objfile) <msymbols_range>: Move from top level.
10835         <msymbols>: New method.
10836         (class objfile_msymbols): Remove.
10837         * symtab.c (default_collect_symbol_completion_matches_break_on):
10838         Update.
10839         * symmisc.c (dump_msymbols): Update.
10840         * stabsread.c (scan_file_globals): Update.
10841         * objc-lang.c (info_selectors_command, info_classes_command)
10842         (find_methods): Update.
10843         * minsyms.c (find_solib_trampoline_target): Update.
10844         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10845         * coffread.c (coff_symfile_read): Update.
10846         * ada-lang.c (ada_lookup_simple_minsym)
10847         (ada_collect_symbol_completion_matches): Update.
10848
10849 2019-01-16  Tom Tromey  <tom@tromey.com>
10850
10851         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10852         type.  Remove no-argument constructor.
10853         <iterator::operator++>: Simplify.
10854         <begin>: Update.
10855         <end>: Use minimal_symbol_count.
10856
10857 2019-01-16  Tom Tromey  <tom@tromey.com>
10858
10859         * objfiles.h (struct objfile) <psymtabs>: New method.
10860         (class objfile_psymtabs): Remove.
10861         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10862         typedef.
10863         <range>: New method.
10864         (require_partial_symbols): Change return type.
10865         * psymtab.c (require_partial_symbols)
10866         (psym_expand_symtabs_matching): Update.
10867         * mdebugread.c (parse_partial_symbols): Update.
10868         * dbxread.c (dbx_end_psymtab): Update.
10869
10870 2019-01-15  Tom Tromey  <tom@tromey.com>
10871
10872         * symtab.c (lookup_objfile_from_block)
10873         (lookup_symbol_in_objfile_symtabs)
10874         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10875         (find_line_symtab, info_sources_command)
10876         (default_collect_symbol_completion_matches_break_on)
10877         (make_source_files_completion_list): Update.
10878         * symmisc.c (print_objfile_statistics, dump_objfile)
10879         (maintenance_print_symbols, maintenance_info_symtabs)
10880         (maintenance_check_symtabs, maintenance_info_line_tables):
10881         Update.
10882         * source.c (select_source_symtab)
10883         (forget_cached_source_info_for_objfile): Update.
10884         * objfiles.h (class objfile_compunits): Remove.
10885         (struct objfile) <compunits_range>: New typedef.
10886         (compunits): New method.
10887         * objfiles.c (objfile_relocate1): Update.
10888         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10889         * maint.c (count_symtabs_and_blocks): Update.
10890         * linespec.c (iterate_over_all_matching_symtabs): Update.
10891         * cp-support.c (add_symbol_overload_list_qualified): Update.
10892         * coffread.c (coff_symtab_read): Update.
10893         * ada-lang.c (add_nonlocal_symbols)
10894         (ada_collect_symbol_completion_matches)
10895         (ada_add_global_exceptions): Update.
10896
10897 2019-01-15  Tom Tromey  <tom@tromey.com>
10898
10899         * progspace.h (program_space) <objfiles_safe_range>: New
10900         typedef.
10901         <objfiles_safe>: New method.
10902         * objfiles.h (class all_objfiles_safe): Remove.
10903         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10904         * jit.c (jit_inferior_exit_hook): Update.
10905
10906 2019-01-17  Tom Tromey  <tom@tromey.com>
10907
10908         * progspace.h (program_space) <objfiles_range>: New typedef.
10909         <objfiles>: New method.
10910         <objfiles_head>: Rename from objfiles.
10911         (object_files): Update.
10912         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10913         * guile/scm-pretty-print.c
10914         (ppscm_find_pretty_printer_from_objfiles): Update.
10915         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10916         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10917         Update.
10918         * python/py-progspace.c (pspy_get_objfiles): Update.
10919         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10920         Update.
10921         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10922         (objfpy_lookup_objfile_by_build_id): Update.
10923         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10924         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10925         Update.
10926         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10927         (expand_symtab_containing_pc, lookup_objfile_from_block)
10928         (lookup_static_symbol, basic_lookup_transparent_type)
10929         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10930         (find_line_symtab, info_sources_command)
10931         (default_collect_symbol_completion_matches_break_on)
10932         (make_source_files_completion_list, find_main_name): Update.
10933         * symmisc.c (print_symbol_bcache_statistics)
10934         (print_objfile_statistics, maintenance_print_symbols)
10935         (maintenance_print_msymbols, maintenance_print_objfiles)
10936         (maintenance_info_symtabs, maintenance_check_symtabs)
10937         (maintenance_expand_symtabs, maintenance_info_line_tables):
10938         Update.
10939         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10940         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10941         (map_overlay_command, unmap_overlay_command)
10942         (simple_overlay_update, expand_symtabs_matching)
10943         (map_symbol_filenames): Update.
10944         * symfile-debug.c (set_debug_symfile): Update.
10945         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10946         Update.
10947         * source.c (select_source_symtab, forget_cached_source_info):
10948         Update.
10949         * solib.c (solib_read_symbols): Update.
10950         * solib-spu.c (append_ocl_sos): Update.
10951         * psymtab.c (maintenance_print_psymbols)
10952         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10953         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10954         * printcmd.c (info_symbol_command): Update.
10955         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10956         Update.
10957         * objfiles.h (class all_objfiles): Remove.
10958         * objfiles.c (have_partial_symbols, have_full_symbols)
10959         (have_minimal_symbols, qsort_cmp, update_section_map)
10960         (shared_objfile_contains_address_p)
10961         (default_iterate_over_objfiles_in_search_order): Update.
10962         * objc-lang.c (info_selectors_command, info_classes_command)
10963         (find_methods): Update.
10964         * minsyms.c (find_solib_trampoline_target): Update.
10965         * maint.c (maintenance_info_sections)
10966         (maintenance_translate_address, count_symtabs_and_blocks):
10967         Update.
10968         * main.c (captured_main_1): Update.
10969         * linux-thread-db.c (try_thread_db_load_from_pdir)
10970         (has_libpthread): Update.
10971         * linespec.c (iterate_over_all_matching_symtabs)
10972         (search_minsyms_for_name): Update.
10973         * jit.c (jit_find_objf_with_entry_addr): Update.
10974         * hppa-tdep.c (find_unwind_entry)
10975         (hppa_lookup_stub_minimal_symbol): Update.
10976         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10977         Update.
10978         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10979         (elf_gnu_ifunc_resolve_by_got): Update.
10980         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10981         * dwarf-index-write.c (save_gdb_index_command): Update.
10982         * cp-support.c (add_symbol_overload_list_qualified): Update.
10983         * breakpoint.c (create_overlay_event_breakpoint)
10984         (create_longjmp_master_breakpoint)
10985         (create_std_terminate_master_breakpoint)
10986         (create_exception_master_breakpoint): Update.
10987         * blockframe.c (find_pc_partial_function): Update.
10988         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10989         (ada_collect_symbol_completion_matches)
10990         (ada_add_global_exceptions): Update.
10991
10992 2019-01-17  Tom Tromey  <tom@tromey.com>
10993
10994         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10995         declare VEC.
10996         (solib_target_parse_libraries): Change return type.
10997         (library_list_start_segment, library_list_start_section)
10998         (library_list_end_library, library_list_start_library); Update.
10999         (solib_target_free_library_list): Remove.
11000         (solib_target_parse_libraries): Remove cleanup.  Change return
11001         type.
11002         (solib_target_current_sos): Update.
11003
11004 2019-01-17  Tom Tromey  <tromey@bapiya>
11005
11006         * valprint.c: Replace "the the" with "the".
11007         * symtab.c: Replace "the the" with "the".
11008         * solib.c: Replace "the the" with "the".
11009         * solib-dsbt.c: Replace "the the" with "the".
11010         * linespec.c: Replace "the the" with "the".
11011         * dwarf2loc.h: Replace "the the" with "the".
11012         * amd64-windows-tdep.c: Replace "the the" with "the".
11013         * aarch64-tdep.c: Replace "the the" with "the".
11014
11015 2019-01-16  Keith Seitz  <keiths@redhat.com>
11016
11017         PR gdb/23773
11018         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11019         <builder>: Rename to ..
11020         <m_builder>: ... this and make private.
11021         (dwarf2_cu::get_builder): New method.  Change all users of
11022         `builder' to use this method.
11023         (dwarf2_start_symtab): Move to ...
11024         (dwarf2_cu::start_symtab): ... here.  Update all callers
11025         (setup_type_unit_groups): Move to ...
11026         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11027         callers.
11028         (dwarf2_cu::reset_builder): New method.
11029         (process_full_compunit, process_full_type_unit): Use
11030         dwarf2_cu::reset_builder.
11031         (follow_die_offset): Record the ancestor CU if it is different
11032         from the followed DIE's CU.
11033         (follow_die_sig_1): Likewise.
11034
11035 2019-01-15  Tom Tromey  <tom@tromey.com>
11036
11037         * remote.c (class remote_state) <buf>: Now a char_vector.
11038         <buf_size>: Remove.
11039         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11040         parameter.
11041         (remote_target::getpkt_or_notif_sane_1)
11042         (remote_target::getpkt_sane)
11043         (remote_target::getpkt_or_notif_sane): Likewise.
11044         (class remote_target) <putpkt>: New overload.
11045         (remote_target::read_frame): Change type of "buf_p".  Remove
11046         sizeof_p parameter.
11047         (packet_ok): New overload.
11048         (packet_check_result): New overload.
11049         Update all uses.
11050
11051 2019-01-14  Tom Tromey  <tom@tromey.com>
11052
11053         * remote-notif.c (handle_notification, remote_notif_ack)
11054         (remote_notif_parse): Make "buf" const.
11055         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11056         const.
11057         (remote_notif_parse, remote_notif_ack, handle_notification):
11058         Likewise.
11059         * remote.c (remote_notif_stop_parse): Make "buf" const.
11060         (remote_target::remote_parse_stop_reply): Make "buf" const.
11061         (remote_notif_stop_ack): Make "buf" const.
11062
11063 2019-01-14  Tom Tromey  <tom@tromey.com>
11064
11065         * remote.c (remote_console_output): Make parameter const.
11066
11067 2019-01-14  Tom Tromey  <tom@tromey.com>
11068
11069         * target-debug.h (target_debug_print_signals): Constify.
11070         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11071         * procfs.c (procfs_target::pass_signals): Update.
11072         * linux-nat.c (linux_nat_target::pass_signals): Update.
11073         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11074         * target-delegates.c: Rebuild.
11075         * remote.c (remote_target::program_signals): Update.
11076         (remote_target::pass_signals): Update.
11077         * target.c (target_pass_signals): Constify argument.
11078         (target_program_signals): Likewise.
11079         * target.h (struct target_ops) <pass_signals, program_signals>:
11080         Constify argument.
11081         (target_pass_signals, target_program_signals): Constify argument.
11082
11083 2019-01-14  Tom Tromey  <tom@tromey.com>
11084
11085         PR tui/28819:
11086         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11087
11088 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11089
11090         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11091         field.
11092         * rs6000-tdep.c: Include reggroups.h.
11093         (IS_V_ALIAS_PSEUDOREG): Define.
11094         (rs6000_register_name): Return names for the "vX" aliases.
11095         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11096         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11097         aliases.  Call default_register_reggroup_p for all other
11098         pseudo-registers.
11099         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11100         New functions.
11101         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11102         Handle "vX" aliases.
11103         (v_alias_pseudo_register_collect): New function.
11104         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11105         (rs6000_gdbarch_init): Initialize "vX" aliases as
11106         pseudo-registers.  Restore registration of
11107         rs6000_pseudo_register_reggroup_p with
11108         set_tdesc_pseudo_register_reggroup_p.
11109
11110 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11111
11112         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11113         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11114         set_gdbarch_num_pseudo_regs.
11115
11116 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11117
11118         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11119         Remove arg prefixname, add do_set and do_show.
11120         Add member functions set_list and show_list.
11121         * cli/cli-style.c (class cli_style_option): Update accordingly.
11122         (style_set_list): Move to file scope.
11123         (style_show_list): Likewise.
11124         (set_style): Call help_list.
11125         (show_style): Call cmd_show_list.
11126         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11127         Update to use the new macro.
11128
11129 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11130
11131         * ada-lang.c (_initialize_ada_language): Expand the help text
11132         for the "catch exception" command.
11133
11134 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11135
11136         * symtab.c (matching_obj_sections): Initialize obj,
11137         declare it closer to its usage.
11138
11139 2019-01-10  Tom Tromey  <tom@tromey.com>
11140
11141         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11142         (basic_inf_threads_range): Remove.
11143         (inf_threads_range, inf_non_exited_threads_range)
11144         (safe_inf_threads_range): Use next_adapter.
11145
11146 2019-01-10  Keith Seitz  <keiths@redhat.com>
11147
11148         PR gdb/23712
11149         PR symtab/23010
11150         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11151         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11152
11153 2019-01-10  Keith Seitz  <keiths@redhat.com>
11154
11155         PR gdb/23712
11156         PR symtab/23010
11157         * dictionary.c (pending_to_vector): Remove.
11158         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11159         Remove _1 suffix, replacing functions of the same name.  Update
11160         all callers.
11161         (dict_create_hashed, dict_create_hashed_expandable)
11162         (dict_create_linear, dict_create_linear_expandable, dict_free)
11163         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11164         Make functions static.
11165
11166 2019-01-10  Keith Seitz  <keiths@redhat.com>
11167
11168         PR gdb/23712
11169         PR symtab/23010
11170         * dictionary.h (struct dictionary): Replace declaration with
11171         multidictionary.
11172         (dict_create_hashed, dict_create_hashed_expandable)
11173         (dict_create_linear, dict_create_linear_expandable)
11174         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11175         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11176         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11177         taking multidictionary argument.
11178         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11179         * block.h (struct block) <dict>: Change to multidictionary
11180         and rename `multidict'.
11181         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11182         symmisc.c: Update all dictionary references to multidictionary.
11183
11184 2019-01-10  Keith Seitz  <keiths@redhat.com>
11185
11186         PR gdb/23712
11187         PR symtab/23010
11188         * dictionary.c: Include unordered_map.
11189         (pending_to_vector): New function.
11190         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11191         Rewrite the non-"_1" functions to take vector instead
11192         of linked list.
11193         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11194         "new" _1 versions of the same name.
11195         (multidictionary): Define.
11196         (std::hash<enum language): New definition.
11197         (collate_pending_symbols_by_language, mdict_create_hashed)
11198         (mdict_create_hashed_expandable, mdict_create_linear)
11199         (mdict_create_linear_expandable, mdict_free)
11200         (find_language_dictionary, create_new_language_dictionary)
11201         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11202         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11203         (mdict_size, mdict_empty): New functions.
11204         * dictionary.h (mdict_iterator): Define.
11205
11206 2019-01-10  Pedro Alves  <palves@redhat.com>
11207
11208         * breakpoint.c (read_uploaded_action)
11209         (create_tracepoint_from_upload): Adjust to use
11210         gdb::unique_xmalloc_ptr.
11211         * ctf.c (ctf_write_uploaded_tp):
11212         (SET_ARRAY_FIELD): Use emplace_back.
11213         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11214         * tracefile-tfile.c (tfile_write_uploaded_tp):
11215         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11216         gdb::unique_xmalloc_ptr.
11217         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11218         at_string, cond_string, cmd_strings>: Replace char pointers
11219         with gdb::unique_xmalloc_ptr.
11220
11221 2019-01-10  Pedro Alves  <palves@redhat.com>
11222
11223         * solib-target.c (library_list_start_library): Don't xstrdup name.
11224
11225 2019-01-10  Pedro Alves  <palves@redhat.com>
11226
11227         * mdebugread.c (parse_partial_symbols): Use
11228         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11229
11230 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11231
11232         * linux-fork.c (scoped_switch_fork_info)
11233         <~scoped_switch_fork_info>: Fix incorrect variable name.
11234
11235 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11236
11237         * linux-fork.c (scoped_switch_fork_info)
11238         <scoped_switch_fork_info>: Make explicit.
11239         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11240
11241 2019-01-10  Tom Tromey  <tom@tromey.com>
11242
11243         * objfiles.h (objfile::reset_psymtabs): Update.
11244         * objfiles.c (objfile::objfile): Update.
11245         * psymtab.h (psymtab_storage::obstack): Update.
11246         (psymtab_storage::m_obstack): Use gdb::optional.
11247         (class psymtab_storage): Update comment.  Remove objfile
11248         parameter.
11249         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11250
11251 2019-01-10  Tom Tromey  <tom@tromey.com>
11252
11253         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11254         <free_psymtabs>: Now private.
11255         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11256         (allocate_psymtab): Use new method.
11257
11258 2019-01-10  Tom Tromey  <tom@tromey.com>
11259
11260         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11261         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11262         * mdebugread.c (parse_partial_symbols): Use
11263         allocate_dependencies.
11264         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11265         allocate_dependencies.
11266         (process_psymtab_comp_unit_reader)
11267         (build_type_psymtab_dependencies): Likewise.
11268         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11269
11270 2019-01-10  Tom Tromey  <tom@tromey.com>
11271
11272         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11273         PSYMBOL_SET_LANGUAGE.
11274         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11275
11276 2019-01-10  Tom Tromey  <tom@tromey.com>
11277
11278         * psymtab.h (psymtab_storage::obstack): New method.
11279         <m_obstack>: Rename from obstack; now private.
11280         * psymtab.c (psymtab_storage): Update.
11281         * dwarf2read.c (create_addrmap_from_index)
11282         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11283         Update.
11284
11285 2019-01-10  Tom Tromey  <tom@tromey.com>
11286
11287         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11288         * objfiles.h (objfile::reset_psymtabs): New method.
11289
11290 2019-01-10  Tom Tromey  <tom@tromey.com>
11291
11292         * symmisc.c (print_symbol_bcache_statistics): Update.
11293         (print_objfile_statistics): Update.
11294         * symfile.c (reread_symbols): Update.
11295         * psymtab.h (class psymtab_storage): New.
11296         * psymtab.c (psymtab_storage): New constructor.
11297         (~psymtab_storage): New destructor.
11298         (require_partial_symbols): Update.
11299         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11300         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11301         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11302         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11303         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11304         (start_psymtab_common, end_psymtab_common)
11305         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11306         (allocate_psymtab): Update.
11307         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11308         Update.
11309         (dump_psymtab_addrmap, maintenance_print_psymbols)
11310         (maintenance_check_psymtabs): Update.
11311         (class objfile_psymtabs): Move to objfiles.h.
11312         * psympriv.h (discard_psymtab): Now inline.
11313         (psymtab_discarder::psymtab_discarder): Update.
11314         (psymtab_discarder::~psymtab_discarder): Update.
11315         (ALL_OBJFILE_PSYMTABS): Rewrite.
11316         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11317         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11318         Remove fields.
11319         <partial_symtabs>: New field.
11320         (class objfile_psymtabs): Move from psymtab.h.  Update.
11321         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11322         psymbol_cache.
11323         (objfile::~objfile): Don't destroy psymbol_cache.
11324         * mdebugread.c (parse_partial_symbols): Update.
11325         * dwarf2read.c (create_addrmap_from_index)
11326         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11327         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11328         (add_partial_subprogram, dwarf2_ranges_read): Update.
11329         * dwarf-index-write.c (write_address_map)
11330         (write_one_signatured_type, recursively_write_psymbols)
11331         (class debug_names, class debug_names, write_psymtabs_to_index):
11332         Update.
11333
11334 2019-01-10  Tom Tromey  <tom@tromey.com>
11335
11336         * symtab.h (SYMBOL_SET_NAMES): Update.
11337         (symbol_set_names): Update.
11338         (MSYMBOL_SET_NAMES): Update.
11339         * symtab.c (symbol_set_names): Change argument to be an
11340         objfile_per_bfd_storage.
11341         * psymtab.c (add_psymbol_to_bcache): Update.
11342         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11343
11344 2019-01-10  Tom Tromey  <tom@tromey.com>
11345
11346         * symtab.c (create_demangled_names_hash): Change argument to be an
11347         objfile_per_bfd_storage.
11348         (symbol_set_names): Update.
11349
11350 2019-01-10  Tom Tromey  <tom@tromey.com>
11351
11352         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11353         init_psymbol_list.
11354         * psymtab.c (init_psymbol_list): Do nothing if already called.
11355         * psympriv.h (init_psymbol_list): Add comment.
11356         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11357         init_psymbol_list.
11358         * dbxread.c (dbx_symfile_read): Unconditionally call
11359         init_psymbol_list.
11360
11361 2019-01-10  Tom Tromey  <tom@tromey.com>
11362
11363         * xcoffread.c (scan_xcoff_symtab): Update.
11364         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11365         "where".
11366         * mdebugread.c (parse_partial_symbols)
11367         (handle_psymbol_enumerators): Update.
11368         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11369         * dbxread.c (read_dbx_symtab): Update.
11370         * psympriv.h (psymbol_placement): New enum.
11371         (add_psymbol_to_list): Update.
11372
11373 2019-01-10  Tom Tromey  <tom@tromey.com>
11374
11375         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11376         static_psymbols parameters.
11377         (scan_xcoff_symtab): Update.
11378         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11379         static_psymbols parameters.
11380         * psympriv.h (start_psymtab_common): Update.
11381         * mdebugread.c (parse_partial_symbols): Update.
11382         * dwarf2read.c (create_partial_symtab): Update.
11383         * dbxread.c (read_dbx_symtab): Update.
11384         (start_psymtab): Remove global_psymbols and static_psymbols
11385         parameters.
11386
11387 2019-01-10  Tom Tromey  <tom@tromey.com>
11388
11389         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11390         * psymtab.c (allocate_psymtab): Add comment.
11391         * psympriv.h (allocate_psymtab): Add comment.
11392         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11393         initializations.
11394         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11395
11396 2019-01-10  Tom Tromey  <tom@tromey.com>
11397
11398         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11399         Don't declare.
11400         * mipsread.c: Include mdebugread.h.
11401         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11402         Declare.
11403         * elfread.c: Include mdebugread.h.
11404
11405 2019-01-09  Tom Tromey  <tom@tromey.com>
11406
11407         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11408         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11409         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11410         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11411         (psym_lookup_symbol, psym_find_last_source_symtab)
11412         (psym_forget_cached_source_info, psym_print_stats)
11413         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11414         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11415         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11416         (psym_find_compunit_symtab_by_address)
11417         (maintenance_print_psymbols, maintenance_info_psymtabs)
11418         (maintenance_check_psymtabs): Use ranged for.
11419         * psymtab.h (class objfile_psymtabs): New.
11420         (require_partial_symbols): Return objfile_psymtabs.
11421         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11422
11423 2019-01-09  Tom Tromey  <tom@tromey.com>
11424
11425         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11426         (find_pc_mapped_section, list_overlays_command)
11427         (map_overlay_command, unmap_overlay_command)
11428         (simple_overlay_update): Use all_objfiles.
11429         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11430         * printcmd.c (info_symbol_command): Use all_objfiles.
11431         * objfiles.h (ALL_OBJSECTIONS): Remove.
11432         * maint.c (maintenance_translate_address): Use all_objfiles.
11433         * gcore.c (gcore_create_callback): Use all_objfiles.
11434         (objfile_find_memory_regions): Likewise.
11435
11436 2019-01-09  Tom Tromey  <tom@tromey.com>
11437
11438         * symtab.c (find_line_symtab, info_sources_command)
11439         (make_source_files_completion_list): Use objfile_compunits.
11440         * source.c (select_source_symtab): Use objfile_compunits.
11441         * objfiles.h (struct objfile): Update comment.
11442         (ALL_OBJFILES): Remove.
11443         (ALL_FILETABS): Remove.
11444         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11445         objfile_compunits.
11446
11447 2019-01-09  Tom Tromey  <tom@tromey.com>
11448
11449         * symmisc.c (print_objfile_statistics, dump_objfile)
11450         (maintenance_print_symbols): Use compunit_filetabs.
11451         * source.c (forget_cached_source_info_for_objfile): Use
11452         compunit_filetabs.
11453         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11454         (ALL_FILETABS): Use compunit_filetabs.
11455         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11456         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11457
11458 2019-01-09  Tom Tromey  <tom@tromey.com>
11459
11460         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11461         (compunit_filetabs): New.
11462         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11463         compunit_filetabs.
11464         (info_sources_command, make_source_files_completion_list): Remove
11465         declaration.
11466         * symmisc.c (print_objfile_statistics, dump_objfile)
11467         (maintenance_print_symbols): Remove declaration.
11468         (maintenance_info_symtabs): Use compunit_filetabs.
11469         (maintenance_info_line_tables): Likewise.
11470         * source.c (select_source_symtab): Change local variable name.
11471         (forget_cached_source_info_for_objfile): Remove declaration.
11472         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11473         * objfiles.c (objfile_relocate1): Remove declaration.
11474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11475         declaration.
11476         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11477         * coffread.c (coff_symtab_read): Remove declaration.
11478         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11479         compunit_filetabs.
11480
11481 2019-01-09  Tom Tromey  <tom@tromey.com>
11482
11483         * symtab.c (lookup_objfile_from_block)
11484         (find_pc_sect_compunit_symtab, search_symbols)
11485         (default_collect_symbol_completion_matches_break_on): Use
11486         objfile_compunits.
11487         * objfiles.h (ALL_COMPUNITS): Remove.
11488         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11489         * cp-support.c (add_symbol_overload_list_qualified): Use
11490         objfile_compunits.
11491         * ada-lang.c (ada_collect_symbol_completion_matches)
11492         (ada_add_global_exceptions): Use objfile_compunits.
11493
11494 2019-01-09  Tom Tromey  <tom@tromey.com>
11495
11496         * source.c (select_source_symtab)
11497         (forget_cached_source_info_for_objfile): Remove declaration.
11498         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11499         declaration.
11500         * maint.c (count_symtabs_and_blocks): Remove declaration.
11501         * cp-support.c (add_symbol_overload_list_qualified): Remove
11502         declaration.
11503         * coffread.c (coff_symtab_read): Remove declaration.
11504         * symtab.c (lookup_symbol_in_objfile_symtabs)
11505         (basic_lookup_transparent_type_1): Use objfile_compunits.
11506         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11507         (info_sources_command, search_symbols)
11508         (default_collect_symbol_completion_matches_break_on)
11509         (make_source_files_completion_list): Remove declaration.
11510         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11511         (ada_collect_symbol_completion_matches)
11512         (ada_add_global_exceptions): Remove declaration.
11513         * linespec.c (iterate_over_all_matching_symtabs): Use
11514         objfile_compunits.
11515         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11516         (class objfile_compunits): New.
11517         (ALL_COMPUNITS): Use objfile_compunits.
11518         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11519         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11520         objfile_compunits.
11521         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11522
11523 2019-01-09  Tom Tromey  <tom@tromey.com>
11524
11525         * symtab.c (search_symbols)
11526         (default_collect_symbol_completion_matches_break_on): Use
11527         objfile_msymbols.
11528         * ada-lang.c (ada_lookup_simple_minsym)
11529         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11530         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11531         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11532         objfile_msymbols.
11533         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11534         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11535         * objc-lang.c (find_methods): Use objfile_msymbols.
11536         (info_selectors_command, info_classes_command): Likewise.
11537         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11538         * objfiles.h (class objfile_msymbols): New.
11539         (ALL_OBJFILE_MSYMBOLS): Remove.
11540         (ALL_MSYMBOLS): Remove.
11541
11542 2019-01-09  Tom Tromey  <tom@tromey.com>
11543
11544         * common/next-iterator.h (next_adapter): Add Iterator template
11545         parameter.
11546         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11547         (class all_objfiles_safe): New.
11548         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11549         * objfiles.c (put_objfile_before): Update comment.
11550         (add_separate_debug_objfile): Likewise.
11551         (free_all_objfiles): Use all_objfiles_safe.
11552         (objfile_purge_solibs): Likewise.
11553
11554 2019-01-09  Tom Tromey  <tom@tromey.com>
11555
11556         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11557         (expand_symtab_containing_pc, lookup_static_symbol)
11558         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11559         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11560         all_objfiles.
11561         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11562         * breakpoint.c (create_overlay_event_breakpoint)
11563         (create_longjmp_master_breakpoint)
11564         (create_std_terminate_master_breakpoint)
11565         (create_exception_master_breakpoint): Use all_objfiles.
11566         * linux-thread-db.c (try_thread_db_load_from_pdir)
11567         (has_libpthread): Use all_objfiles.
11568         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11569         * linespec.c (iterate_over_all_matching_symtabs)
11570         (search_minsyms_for_name): Use all_objfiles.
11571         * maint.c (maintenance_info_sections): Use all_objfiles.
11572         * main.c (captured_main_1): Use all_objfiles.
11573         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11574         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11575         * guile/scm-pretty-print.c
11576         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11577         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11578         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11579         (maintenance_print_msymbols): Use all_objfiles.
11580         * source.c (select_source_symtab): Use all_objfiles.
11581         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11582         * symfile.c (remove_symbol_file_command)
11583         (expand_symtabs_matching, map_symbol_filenames): Use
11584         all_objfiles.
11585         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11586         all_objfiles.
11587         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11588         * objc-lang.c (find_methods): Use all_objfiles.
11589         * objfiles.c (have_partial_symbols, have_full_symbols)
11590         (have_minimal_symbols, qsort_cmp)
11591         (default_iterate_over_objfiles_in_search_order): Use
11592         all_objfiles.
11593         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11594         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11595         (maintenance_check_psymtabs): Use all_objfiles.
11596         (ALL_PSYMTABS): Remove.
11597         * compile/compile-object-run.c (do_module_cleanup): Use
11598         all_objfiles.
11599         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11600         * cp-support.c (add_symbol_overload_list_qualified): Use
11601         all_objfiles.
11602         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11603         Use all_objfiles.
11604         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11605         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11606         all_objfiles.
11607         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11608         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11609         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11610         Uses all_objfiles.
11611         * solib.c (solib_read_symbols): Use all_objfiles
11612
11613 2019-01-09  Tom Tromey  <tom@tromey.com>
11614
11615         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11616         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11617         all_objfiles.
11618         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11619         * symmisc.c (print_symbol_bcache_statistics)
11620         (print_objfile_statistics, maintenance_print_objfiles)
11621         (maintenance_info_symtabs, maintenance_check_symtabs)
11622         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11623         all_objfiles.
11624         * source.c (forget_cached_source_info): Use all_objfiles.
11625         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11626         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11627         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11628         * objfiles.c (update_section_map): Use all_objfiles.
11629         (shared_objfile_contains_address_p): Likewise.
11630         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11631         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11632
11633 2019-01-09  Tom Tromey  <tom@tromey.com>
11634
11635         * common/next-iterator.h: New file.
11636         * objfiles.h (class all_objfiles): New.
11637         (struct objfile_iterator): New.
11638
11639 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11640
11641         * NEWS: Move the description of the changed "frame", "select-frame",
11642          and "info frame" commands to the Changed commands section.
11643
11644 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11645
11646         * gdbtypes.c (check_stub_method_group): Remove handling of old
11647         mangling schemes.
11648         * linespec.c (find_methods): Likewise.
11649         * stabsread.c (read_member_functions): Likewise.
11650         * valops.c (search_struct_method): Likewise.
11651         (value_struct_elt_for_reference): Likewise.
11652         * NEWS: Mention this change.
11653
11654 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11655
11656         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11657         print_source_lines.
11658         * source.c (print_source_lines_base): Update line number check.
11659         (print_source_lines): New function.
11660         (source_lines_range::source_lines_range): New function.
11661         * source.h (class source_lines_range): New class.
11662         (print_source_lines): New declaration.
11663
11664 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11665
11666         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11667
11668 2019-01-08  Tom Tromey  <tom@tromey.com>
11669             Simon Marchi  <simon.marchi@ericsson.com>
11670
11671         PR gdb/24060
11672         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11673         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11674         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11675         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11676         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11677         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11678
11679 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11680
11681         * source.c (select_source_symtab): Move header comment to
11682         declaration in source.h.
11683         (forget_cached_source_info_for_objfile): Likewise.
11684         (forget_cached_source_info): Likewise.
11685         (identify_source_line): Likewise.
11686         * source.h (identify_source_line): Move declaration from symtab.h
11687         and add comment from source.c
11688         (print_source_lines): Likewise.
11689         (forget_cached_source_info_for_objfile): Likewise.
11690         (forget_cached_source_info): Likewise.
11691         (select_source_symtab): Likewise.
11692         (enum print_source_lines_flag): Move definition from symtab.h.
11693         * symtab.h (identify_source_line): Move declaration to source.h.
11694         (print_source_lines): Likewise.
11695         (forget_cached_source_info_for_objfile): Likewise.
11696         (forget_cached_source_info): Likewise.
11697         (select_source_symtab): Likewise.
11698         (enum print_source_lines_flag): Move definition to source.h.
11699         * tui/tui-hooks.c: Add 'source.h' include.
11700
11701 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11702
11703         * source.c (print_source_lines_base): Handle requests to print
11704         reverse line number sequences, and guard against empty lines
11705         string.
11706
11707 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11708
11709         * source.c (print_source_lines_base): Fix skip of '\r' if next
11710         character is '\n'.
11711
11712 2019-01-06  Tom Tromey  <tom@tromey.com>
11713
11714         * c-exp.y (struct c_parse_state) <macro_original_text,
11715         expansion_obstack>: New member.
11716         (macro_original_text, expansion_obstack): Remove globals.
11717         (scan_macro_expansion, scanning_macro_expansion)
11718         (finished_macro_expansion): Update.
11719         (scan_macro_cleanup): Remove.
11720         (yylex, c_parse): Update.
11721
11722 2019-01-06  Tom Tromey  <tom@tromey.com>
11723
11724         * c-exp.y (struct c_parse_state) <strings>: New member.
11725         (operator_stoken): Update.
11726
11727 2019-01-06  Tom Tromey  <tom@tromey.com>
11728
11729         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11730         (union type_stack_elt) <typelist_val>: Now a pointer to
11731         std::vector.
11732         (type_stack_cleanup): Don't declare.
11733         (push_typelist): Update.
11734         * parse.c (pop_typelist): Return a std::vector.
11735         (push_typelist): Take a std::vector.
11736         (follow_types): Update.  Do not free args.
11737         (type_stack_cleanup): Remove.
11738         * c-exp.y (struct c_parse_state): New.
11739         (cpstate): New global.
11740         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11741         (nonempty_typelist): Update.
11742         (func_mod): Create a new vector.
11743         (c_parse): Create a c_parse_state.
11744         (check_parameter_typelist): Do not delete params.
11745         (function_method): Update.  Do not delete type_list.
11746
11747 2019-01-06  Tom Tromey  <tom@tromey.com>
11748
11749         PR gdb/28155:
11750         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11751         check_typedef.
11752         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11753         (print_return_value): Likewise.
11754
11755 2019-01-05  Tom Tromey  <tom@tromey.com>
11756
11757         * contrib/cleanup_check.py: Remove.
11758         * contrib/gcc-with-excheck: Remove.
11759         * contrib/exsummary.py: Remove.
11760         * contrib/excheck.py: Remove.
11761
11762 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11763
11764         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11765         NULL. Initialize tpprev to NULL instead of assigning it
11766         to NULL on the next statement.
11767         * windows-nat.c (windows_delete_thread): Remove check for
11768         main_thread_id before printing thread exit notifications.
11769         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11770         Remove thread ID check against main_thread_id.
11771         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11772         windows_delete_thread.
11773         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11774
11775 2019-01-04  Tom Tromey  <tom@tromey.com>
11776
11777         * compile/compile.c (_initialize_compile): Use upper case for
11778         metasyntactic variables.
11779         * symmisc.c (_initialize_symmisc): Use upper case for
11780         metasyntactic variables.
11781         * psymtab.c (_initialize_psymtab): Use upper case for
11782         metasyntactic variables.
11783         * demangle.c (demangle_command): Use upper case for metasyntactic
11784         variables.
11785         (_initialize_demangler): Likewise.
11786         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11787         variables.
11788
11789 2019-01-03  Tom Tromey  <tom@tromey.com>
11790
11791         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11792
11793 2019-01-03  Tom Tromey  <tom@tromey.com>
11794
11795         * python/py-symtab.c (salpy_str): Update.
11796         (struct salpy_sal_object) <symtab>: Now a PyObject.
11797         (salpy_dealloc): Update.
11798         (del_objfile_sal): Use gdbpy_ref.
11799
11800 2019-01-03  Tom Tromey  <tom@tromey.com>
11801
11802         * python/py-type.c (convert_field): Use new_reference.  Return
11803         gdbpy_ref.
11804         (make_fielditem): Return gdbpy_ref.
11805         (typy_fields): Update.
11806         (typy_getitem): Update.
11807         (field_name): Return gdbpy_ref.  Use new_reference.
11808         (typy_iterator_iternext): Update.
11809
11810 2019-01-03  Tom Tromey  <tom@tromey.com>
11811
11812         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11813
11814 2019-01-03  Tom Tromey  <tom@tromey.com>
11815
11816         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11817         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11818         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11819         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11820         (pspy_set_type_printers): Likewise.
11821         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11822         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11823         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11824         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11825         (objfpy_set_type_printers): Likewise.
11826
11827 2019-01-03  Tom Tromey  <tom@tromey.com>
11828
11829         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11830         (gdbpy_print_stack): Use gdbpy_err_fetch.
11831         * python/python-internal.h (class gdbpy_err_fetch): New class.
11832         (class gdbpy_enter) <m_error_type, m_error_value,
11833         m_error_traceback>: Remove.
11834         <m_error>: New member.
11835         (gdbpy_exception_to_string): Don't declare.
11836         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11837         * python/py-value.c (convert_value_from_python): Use
11838         gdbpy_err_fetch.
11839         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11840         gdbpy_exception_to_string.
11841         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11842         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11843         gdbpy_err_fetch.
11844
11845 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11846
11847         * linux-nat.c (delete_lwp_cleanup): Delete.
11848         (struct lwp_deleter): New struct.
11849         (lwp_info_up): New typedef.
11850         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11851         lwp_info_up.
11852
11853 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11854
11855         * linux-fork.c (class scoped_switch_fork_info): New class.
11856         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11857
11858 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11859
11860         * valops.c (find_overload_match): Remove use of null_cleanup, and
11861         calls to do_cleanups.
11862
11863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11864
11865         * compile/compile-cplus-types.c
11866         (compile_cplus_instance::decl_name): Handle changes to
11867         cp_func_name.
11868         * cp-support.c (cp_func_name): Update header comment, update
11869         return type.
11870         * cp-support.h (cp_func_name): Update return type in declaration.
11871         * valops.c (find_overload_match): Move temp_func local to top
11872         level of function and change its type.  Use temp_func to hold and
11873         delete temporary string obtained from cp_func_name.
11874
11875 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11876
11877         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11878         gdb::char_vector, remove cleanup, and update uses of `msg`.
11879
11880 2019-01-03  Jim Wilson  <jimw@sifive.com>
11881
11882         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11883
11884 2019-01-02  Tom Tromey  <tom@tromey.com>
11885
11886         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11887         (tdesc_parse_xml): Remove cleanups.
11888         * target-descriptions.h (make_cleanup_free_target_description):
11889         Don't declare.
11890         (target_desc_deleter): New struct.
11891         (target_desc_up): New typedef.
11892         * target-descriptions.c (target_desc_deleter::operator()): Rename
11893         from free_target_description.
11894         (make_cleanup_free_target_description): Remove.
11895
11896 2019-01-02  Tom Tromey  <tom@tromey.com>
11897
11898         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11899         constructor, destructor.
11900         (linespec_parser): Remove typedef.
11901         (~linespec_parser): Rename from linespec_parser_delete.
11902         (linespec_lex_to_end, linespec_complete_label)
11903         (linespec_complete): Update.
11904         (decode_line_full): Remove cleanups.
11905         (decode_line_1): Update.
11906
11907 2019-01-02  Tom Tromey  <tom@tromey.com>
11908
11909         * python/python-internal.h (inferior_to_inferior_object): Change
11910         return type.
11911         * python/py-exitedevent.c (create_exited_event_object): Update.
11912         * python/py-inferior.c (inferior_to_inferior_object): Return
11913         gdbpy_ref.
11914         (python_new_inferior, python_inferior_deleted)
11915         (thread_to_thread_object, delete_thread_object)
11916         (build_inferior_list, gdbpy_selected_inferior): Update.
11917         * python/py-infthread.c (create_thread_object): Update.  Also fail
11918         if inferior_to_inferior_object fails.
11919
11920 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11921
11922         * inferior.h (class inferior) <displaced_step_state>: New field.
11923         * infrun.h (struct displaced_step_state): Move here from
11924         infrun.c.  Initialize fields, add constructor.
11925         <inf>: Remove field.
11926         <reset>: New method.
11927         * infrun.c (struct displaced_step_inferior_state): Move to
11928         infrun.h.
11929         (displaced_step_inferior_states): Remove.
11930         (get_displaced_stepping_state): Adust.
11931         (displaced_step_in_progress_any_inferior): Adjust.
11932         (displaced_step_in_progress_thread): Adjust.
11933         (displaced_step_in_progress): Adjust.
11934         (add_displaced_stepping_state): Remove.
11935         (get_displaced_step_closure_by_addr): Adjust.
11936         (remove_displaced_stepping_state): Remove.
11937         (infrun_inferior_exit): Call displaced_step_state.reset.
11938         (use_displaced_stepping): Don't check for NULL.
11939         (displaced_step_prepare_throw): Call
11940         get_displaced_stepping_state.
11941         (displaced_step_fixup): Don't check for NULL.
11942         (prepare_for_detach): Don't check for NULL.
11943
11944 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11945
11946         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11947          in case of call that did not complete.
11948
11949 2019-01-02  Andrey Utkin  <autkin@undo.io>
11950
11951         * symfile.c (find_separate_debug_file): Fix search of debug files for
11952         remote debuggee.
11953
11954 2019-01-02  Tom Tromey  <tom@tromey.com>
11955
11956         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11957         indentation.
11958         * python/py-frame.c (frapy_older): Remove cast.
11959         (frapy_newer): Likewise.
11960         * python/py-breakpoint.c (local_setattro): Remove cast.
11961         * python/py-arch.c (archpy_name): Remove local variable.
11962         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11963
11964 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11965
11966         * unittests/basic_string_view/element_access/char/empty.cc:
11967         Fix year range in copyright header.
11968
11969 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11970
11971         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11972         Delete.
11973         <operator==>: Update with for removed field.
11974         <hash>: Likewise.
11975         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11976         <isa_features>: ...this.
11977         <abi_features>: New field.
11978         (riscv_isa_flen): Update comment.
11979         (riscv_abi_xlen): New declaration.
11980         (riscv_abi_flen): New declaration.
11981         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11982         isa_features.
11983         (riscv_abi_xlen): New function.
11984         (riscv_isa_flen): Update to get answer from isa_features.
11985         (riscv_abi_flen): New function.
11986         (riscv_has_fp_abi): Update to get answer from abi_features.
11987         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11988         xlen and flen.
11989         (riscv_call_info) <xlen, flen>: Update comment.
11990         (riscv_call_arg_struct): Remove invalid assertions
11991         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11992         is removed.
11993         (riscv_gdbarch_init): Gather isa features and abi features
11994         separately, ensure both match on the gdbarch when reusing an old
11995         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11996         a target with 64-bit float hardware.
11997
11998 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11999
12000         * source.c (search_command_helper): Stop reverse search
12001         when line 1 has been searched.
12002
12003 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12004
12005         * record-full.c (record_full_base_target::close): Rewrite
12006         record_full_core_buf_list free logic.
12007
12008 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12009
12010         * break-catch-syscall.c (print_one_catch_syscall): xfree
12011         the last text.
12012
12013 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12014
12015         * top.c (print_gdb_version): Update Copyright year in version
12016         message.
12017
12018 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12019
12020         Update copyright year range in all GDB files.
12021
12022 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12023
12024         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12025
12026 For older changes see ChangeLog-2018.
12027 \f
12028 Local Variables:
12029 mode: change-log
12030 left-margin: 8
12031 fill-column: 74
12032 version-control: never
12033 coding: utf-8
12034 End:
12035