gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_show_registers): Update.
   4         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
   5         bool.
   6         * tui/tui-data.c (tui_data_window::clear_detail)
   7         (tui_data_window): Update.
   8
   9 2019-06-25  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-windata.c (tui_display_all_data)
  12         (tui_display_data_from_line, tui_display_data_from)
  13         (tui_check_data_values, tui_data_window::do_scroll_vertical):
  14         Update.
  15         * tui/tui-regs.c (tui_last_regs_line_no)
  16         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  17         (tui_show_registers, tui_show_register_group)
  18         (tui_display_registers_from, tui_display_reg_element_at_line)
  19         (tui_display_registers_from_line, tui_check_register_values)
  20         (tui_reg_next, tui_reg_prev): Update.
  21         * tui/tui-layout.c (tui_set_layout, show_data): Update.
  22         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
  23         tui_data_window.
  24         (struct tui_win_info) <detail>: Remove.  Add new fields from
  25         tui_data_info.
  26         (TUI_DATA_WIN): Add cast.
  27         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
  28         (~tui_data_window): Simplify.
  29
  30 2019-06-25  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-layout.c (show_source_disasm_command)
  33         (show_source_or_disasm_and_command): Update.
  34         * tui/tui-io.c (update_cmdwin_start_line)
  35         (tui_redisplay_readline): Update.
  36         * tui/tui-data.h (struct tui_command_info): Remove.
  37         (struct tui_win_info) <detail>: Remove command_info member.
  38         (struct tui_data_window) <start_line>: New member, from
  39         tui_command_info.
  40         (TUI_CMD_WIN): Add casts.
  41
  42 2019-06-25  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-winsource.c (tui_update_source_window)
  45         (tui_refill_source_window)
  46         (tui_source_window_base::do_scroll_horizontal)
  47         (tui_update_breakpoint_info, tui_set_exec_info_content)
  48         (tui_show_exec_info_content, tui_erase_exec_info_content)
  49         (tui_clear_exec_info_content): Update.
  50         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
  51         Update.
  52         * tui/tui-win.c (make_invisible_and_set_new_height)
  53         (make_visible_with_new_height): Update.
  54         * tui/tui-source.c (tui_set_source_content)
  55         (tui_show_symtab_source): Update.
  56         * tui/tui-layout.c (extract_display_start_addr)
  57         (show_source_disasm_command, show_data)
  58         (make_source_or_disasm_window)
  59         (show_source_or_disasm_and_command): Update.
  60         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
  61         (tui_disasm_window::do_scroll_vertical): Remove shadowing
  62         "gdbarch".
  63         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
  64         to tui_source_window_base.
  65         (struct tui_win_info) <detail>: Remove source_info member.
  66         (struct tui_source_window_base) <has_locator>: Inline.
  67         Move contents from tui_source_info; rename has_locator member to
  68         m_has_locator.
  69         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
  70         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
  71         header file.
  72         (tui_source_window_base::clear_detail, ~tui_source_window_base):
  73         Simplify.
  74         (tui_free_all_source_wins_content): Cast to
  75         tui_source_window_base.
  76
  77 2019-06-25  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-win.c (make_invisible_and_set_new_height)
  80         (make_visible_with_new_height): Call has_locator method.
  81         * tui/tui-layout.c (show_source_disasm_command, show_data)
  82         (show_source_or_disasm_and_command): Update for bool change.
  83         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
  84         (tui_win_info) <has_locator>: New method.
  85         (struct tui_source_window_base) <has_locator>: New method.
  86         (tui_win_has_locator): Don't declare.
  87         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
  88         from tui_win_has_locator.
  89         (tui_source_window_base): Use false, not FALSE.
  90
  91 2019-06-25  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
  94         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
  95         clear_detail method directly.
  96         (tui_clear_win_detail): Remove.
  97
  98 2019-06-25  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 101         "this", not TUI_DISASM_WIN.
 102
 103 2019-06-25  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 106         declare.
 107         * tui/tui-winsource.c
 108         (tui_source_window_base::do_scroll_horizontal): Rename from
 109         tui_horizontal_source_scroll.
 110         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 111         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 112         from tui_vertical_data_scroll.
 113         * tui/tui-win.h (tui_scroll): Don't declare.
 114         * tui/tui-win.c (tui_win_info::forward_scroll)
 115         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 116         (tui_win_info::right_scroll): Rename and update.
 117         (tui_scroll_forward_command, tui_scroll_backward_command)
 118         (tui_scroll_left_command, tui_scroll_right_command): Update.
 119         (tui_scroll): Remove.
 120         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 121         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 122         from tui_vertical_source_scroll.
 123         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 124         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 125         from tui_vertical_disassem_scroll.
 126         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 127         do_scroll_horizontal>: New methods.
 128         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 129         Likewise.
 130         (struct tui_source_window_base): Add do_scroll_horizontal.
 131         (struct tui_source_window, struct tui_disasm_window): Add
 132         do_scroll_vertical.
 133         (struct tui_data_window, struct tui_cmd_window): Add
 134         do_scroll_horizontal and do_scroll_vertical.
 135         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 136
 137 2019-06-25  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-data.h (struct tui_source_window_base): New struct.
 140         (struct tui_source_window): Derive from tui_source_window_base.
 141         (struct tui_disasm_window): New struct.
 142         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 143         from tui_source_window::clear_detail.
 144         (tui_source_window_base): Rename from tui_source_window.
 145         (~tui_source_window_base): Rename from ~tui_source_window.
 146         (tui_alloc_win_info): Create a tui_disasm_window.
 147
 148 2019-06-25  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-data.h (struct tui_source_window)
 151         (struct tui_data_window): Declare destructors.
 152         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 153         destructors.
 154         (tui_win_info): Simplify.
 155
 156 2019-06-25  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-winsource.c (tui_display_main)
 159         (tui_update_source_windows_with_addr)
 160         (tui_update_all_breakpoint_info): Update.
 161         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 162         (new_height_ok, parse_scrolling_args): Update.
 163         * tui/tui-stack.c (tui_show_frame_info): Update.
 164         * tui/tui-data.h (struct tui_list): Remove.
 165         (tui_source_windows): Return a reference to a std::vector.
 166         * tui/tui-data.c (source_windows): Now a std::vector.
 167         (tui_source_windows): Change return type.
 168         (tui_clear_source_windows): Rewrite.
 169         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 170         (tui_free_all_source_wins_content): Rewrite.
 171
 172 2019-06-25  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 175         (struct tui_data_window, struct tui_cmd_window): Declare
 176         clear_detail method.
 177         * tui/tui-data.c (tui_source_window::clear_detail)
 178         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 179         methods.
 180         (tui_clear_win_detail): Simplify.
 181
 182 2019-06-25  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-layout.c (make_source_window, make_disasm_window)
 185         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 186         Return the new window.
 187         (show_source_disasm_command, show_data)
 188         (show_source_or_disasm_and_command): Update.
 189
 190 2019-06-25  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 193         parameter.  Return the new window.
 194         (show_source_disasm_command): Update and remove NULL check.
 195         (show_source_or_disasm_and_command): Update.
 196
 197 2019-06-25  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 200
 201 2019-06-25  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-data.h (struct tui_win_info): Make constructor
 204         protected.  Make destructor virtual.  Add initializers.
 205         (tui_source_window, tui_data_window, tui_cmd_window): New
 206         classes.
 207         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 208         constructor.  Add "type" parameter.
 209         (tui_source_window, tui_data_window, tui_cmd_window): New
 210         constructors.
 211         (tui_alloc_win_info): Instantiate the appropriate subclass.
 212
 213 2019-06-25  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-win.c (tui_resize_all): Use delete.
 216         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 217         destructor.
 218         (tui_free_window): Don't declare.
 219         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 220         Update.
 221
 222 2019-06-25  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-data.h (struct tui_win_info): Add constructor.
 225         * tui/tui-data.c (tui_alloc_win_info): Use new.
 226         (tui_free_window): Use delete.
 227
 228 2019-06-22  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 231         declare.
 232         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 233
 234 2019-06-22  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 237         declare.
 238         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 239
 240 2019-06-22  Tom de Vries  <tdevries@suse.de>
 241
 242         * dwarf2read.c (create_addrmap_from_aranges)
 243         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 244         instead of '%zu'.
 245
 246 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 247
 248         * dwarf2read.h (dwarf2_section_info_def): Remove.
 249         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 250         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 251         std::vector<dwarf2_section_info>.
 252         (struct dwo_file) <~dwo_file>: Remove.
 253         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 254         types field.
 255         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 256         (dwarf2_read_debug_names): Likewise.
 257         (create_debug_types_hash_table): Change parameter type to
 258         array_view, adjust code accordingly.
 259         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 260         (partial_die_info::fixup): Likewise.
 261         (determine_prefix): Likewise.
 262         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 263
 264 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 265
 266         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 267         gdb_bfd_ref_ptr.
 268         <~dwo_file>: Remove call to gdb_bfd_unref.
 269         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 270         gdb_bfd_ref_ptr::get.
 271
 272 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 273
 274         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 275         type to htab_up.
 276         * dwarf2read.c (struct dwo_file): Initialize fields.
 277         <~dwo_file>: New.
 278         (free_dwo_file): Remove, move content to ~dwo_file.
 279         (struct dwo_file_deleter): Remove.
 280         (dwo_file_up>: Remove custom deleter.
 281         (free_dwo_files): Remove.
 282         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 283         dwo_files.
 284         (process_skeletonless_type_units): Call unique_ptr::get.
 285         (allocate_dwo_file_hash_table): Add deleter to created hash
 286         table.  Change return type to htab_up.
 287         (lookup_dwo_file_slot): Don't memset dwo_file, call
 288         unique_ptr::get.
 289         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 290         (create_dwo_unit_in_dwp_v2): Likewise.
 291         (open_and_init_dwo_file): Likewise.
 292         (free_dwo_file_from_slot): Remove.
 293
 294 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 295
 296         * dwarf2read.h (struct dwarf2_section_info) <readin,
 297         is_virtual>: Change type to bool.
 298         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 299         true instead of 1.
 300
 301 2019-06-19  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-data.h (tui_init_content_element): Don't declare.
 304
 305 2019-06-19  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-data.h (tui_init_win_info): Don't declare.
 308
 309 2019-06-19  Tom de Vries  <tdevries@suse.de>
 310
 311         * dwarf2read.h (abstract_to_concrete): Change type to
 312         std::unordered_map<sect_offset, std::vector<sect_offset>,
 313         gdb::hash_enum<sect_offset>>.
 314
 315 2019-06-19  Tom Tromey  <tromey@adacore.com>
 316
 317         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 318         EVAL_AVOID_SIDE_EFFECTS specially.
 319
 320 2019-06-19  Tom Tromey  <tromey@adacore.com>
 321
 322         * source-cache.c (highlighter): New global.
 323         (source_cache::get_source_lines): Create a highlighter on demand.
 324
 325 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 326
 327         * defs.h (deprecated_interactive_hook): Delete declaration.
 328         * interps.c (clear_interpreter_hooks): Remove use of
 329         deprecated_interactive_hook.
 330         * top.c (deprecated_interactive_hook): Delete definition.
 331         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 332
 333 2019-06-18  Tom de Vries  <tdevries@suse.de>
 334
 335         PR gdb/24515
 336         * dwarf2read.h (abstract_to_concrete): Change type from
 337         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 338         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 339         * dwarf2read.c (read_variable): Update.
 340         (dwarf2_fetch_die_loc_sect_off): Update.
 341
 342 2019-06-17  Tom de Vries  <tdevries@suse.de>
 343
 344         PR gdb/24617
 345         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 346         accessing parent[parent_len - 1].
 347
 348 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 349
 350         PR gdb/24364
 351         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 352         call dtrace_process_dof with NULL dof.
 353
 354 2019-06-16  Tom de Vries  <tdevries@suse.de>
 355
 356         PR gdb/24445
 357         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 358
 359 2019-06-16  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 362         (make_all_visible): Use address of member.
 363
 364 2019-06-16  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 367         (tui_free_window, free_content, free_content_elements): Remove
 368         unnecessary cast.
 369         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 370         cast.
 371         * tui/tui-regs.c (tui_show_register_group)
 372         (tui_display_registers_from, tui_display_reg_element_at_line):
 373         Remove unnecessary cast.
 374
 375 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 376
 377         * linux-nat.c (normal_mask): Delete.
 378         (_initialize_linux_nat): Don't initialise normal_mask.
 379
 380 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 381
 382         PR gdb/24445
 383         * dwarf-index-write.h (write_psymtabs_to_index): Add
 384         dwz_basename parameter.
 385         * dwarf-index-write.c (write_gdbindex): Move file writing to
 386         write_gdbindex_1.  Change return type void.
 387         (assert_file_size): Move up, remove filename parameter.
 388         (write_gdbindex_1): New function.
 389         (write_debug_names): Change return type to void, call
 390         assert_file_size.
 391         (struct index_wip_file): New struct.
 392         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 393         file logic to index_wip_file.  Write index for dwz file if
 394         needed.
 395         (save_gdb_index_command): Pass basename of dwz file, if present.
 396         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 397         build-id of dwz file, if present.
 398         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 399         (dwarf2_get_dwz_file): Likewise.
 400         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 401         (dwarf2_get_dwz_file): Likewise.
 402
 403 2019-06-16  Tom Tromey  <tom@tromey.com>
 404
 405         * coffread.c (process_coff_symbol): Use xstrdup.
 406         * value.c (create_internalvar): Use xstrdup.
 407
 408 2019-06-16  Tom Tromey  <tom@tromey.com>
 409
 410         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 411         * breakpoint.c (stopin_command, stopat_command)
 412         (until_break_command, decode_location_default): Remove unnecessary
 413         cast.
 414         * utils.c (subset_compare): Remove unnecessary cast.
 415         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 416         cast.
 417         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 418         cast.
 419         * infcmd.c (path_command): Remove unnecessary cast.
 420         * coffread.c (decode_type): Remove unnecessary cast.
 421         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 422         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 423         * tui/tui-stack.c (tui_show_locator_content)
 424         (tui_show_frame_info): Remove unnecessary cast.
 425         * tui/tui-win.c (tui_scroll_forward_command)
 426         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 427         (parse_scrolling_args): Remove unnecessary cast.
 428         * tui/tui-data.c (init_win_info, tui_del_window)
 429         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 430         (free_content_elements): Remove unnecessary cast.
 431         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 432         unnecessary cast.
 433         * tui/tui-source.c (tui_set_source_content)
 434         (tui_vertical_source_scroll): Remove unnecessary cast.
 435         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 436         cast.
 437         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 438         * tui/tui-regs.c (tui_display_registers_from)
 439         (tui_display_register): Remove unnecessary cast.
 440         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 441         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 442         (make_visible): Remove unnecessary cast.
 443         * tui/tui-winsource.c (tui_erase_source_content)
 444         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 445         unnecessary cast.
 446         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 447         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 448         * stabsread.c (read_type, read_array_type, read_range_type):
 449         Remove unnecessary cast.
 450         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 451         (parse_symbol, parse_type, upgrade_type, parse_external)
 452         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 453         unnecessary cast.
 454         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 455
 456 2019-06-16  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-data.c (tui_alloc_generic_win_info)
 459         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 460         checks.
 461
 462 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 463             Andrew Burgess  <andrew.burgess@embecosm.com>
 464
 465         * f-typeprint.c (f_print_type): Don't return early for not
 466         associated or not allocated types.
 467         (f_type_print_varspec_suffix): Add print_rank parameter and print
 468         ranks of array types in case they dangling.
 469         (f_type_print_base): Add print_rank parameter.
 470
 471 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 472
 473         * NEWS: Mention new MI commands.
 474         * break-catch-throw.c (enum exception_event_kind): Move to
 475         breakpoint.h.
 476         (print_mention_exception_catchpoint): Output text as a single
 477         message.
 478         (catch_exception_command_1): Rename to...
 479         (catch_exception_event): ...this, make non-static, update header
 480         command, and change some parameter types.
 481         (catch_catch_command): Update for changes to
 482         catch_exception_command_1.
 483         (catch_throw_command): Likewise.
 484         (catch_rethrow_command): Likewise.
 485         * breakpoint.c (enum exception_event_kind): Delete.
 486         * breakpoint.h (enum exception_event_kind): Moved here from
 487         break-catch-throw.c.
 488         (catch_exception_event): Declare.
 489         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 490         (mi_cmd_catch_throw): New function.
 491         (mi_cmd_catch_rethrow): New function.
 492         (mi_cmd_catch_catch): New function.
 493         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 494         'catch-catch' entries.
 495         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 496         (mi_cmd_catch_rethrow): Declare.
 497         (mi_cmd_catch_catch): Declare.
 498
 499 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 500
 501         * annotate.c (annotate_source_line): Change return type to void,
 502         update implementation to match.
 503         * annotate.h (annotate_source_line): Change return type to void,
 504         update header comment.
 505         * stack.c (print_frame_info): Don't change what frame information
 506         is printed based on whether annotations are on or not.
 507
 508 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 511         (annotate_source): Make static.
 512         (annotate_source_line): Moved from source.c and renamed from
 513         identify_source_line.  Update the return type.
 514         * annotate.h (annotate_source): Delete declaration.
 515         (annotate_source_line): Declaration moved from source.h, and
 516         renamed from identify_source_line.  Return type updated.
 517         * source.c (identify_source_line): Moved to annotate.c and renamed
 518         to annotate_source_line.
 519         (info_line_command): Remove check of annotation_level.
 520         * source.h (identify_source_line): Move declaration to annotate.h
 521         and rename to annotate_source_line.
 522         * stack.c: Add 'annotate.h' include.
 523         (print_frame_info): Remove check of annotation_level before
 524         calling annotate_source_line.
 525
 526 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * source-cache.c (source_cache::get_plain_source_lines): Use
 529         open_source_file_with_line_charpos instead of just
 530         open_source_file, remove call to find_source_lines.
 531         (source_cache::get_source_lines): Likewise.
 532         * source.c (find_source_lines): Make static.
 533         (get_filename_and_charpos): Renamed into...
 534         (open_source_file_with_line_charpos): ..this along with changes to
 535         return a scoped_fd, and some other minor clean ups.
 536         (identify_source_line): Use open_source_file_with_line_charpos.
 537         (search_command_helper): Use open_source_file_with_line_charpos
 538         instead of just open_source_file, remove call to
 539         find_source_lines.
 540         * source.h (open_source_file_with_line_charpos): Declare new
 541         function.
 542         (find_source_lines): Delete declaration.
 543
 544 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 545
 546         * source.c (get_filename_and_charpos): Remove fullname
 547         parameter.
 548         (identify_source_line): Update call to get_filename_and_charpos.
 549
 550 2019-06-14  Tom Tromey  <tromey@adacore.com>
 551
 552         PR gdb/24502:
 553         * ui-style.h (skip_ansi_escape): Update comment.
 554         * ui-file.h (class no_terminal_escape_file): New class.
 555         * ui-file.c (no_terminal_escape_file::write)
 556         (no_terminal_escape_file::puts): New methods.
 557         * cli/cli-logging.c (handle_redirections): Use
 558         no_terminal_escape_file.
 559
 560 2019-06-14  Tom Tromey  <tromey@adacore.com>
 561
 562         * NEWS: Move convenience variable news above Python news.
 563
 564 2019-06-14  Tom Tromey  <tom@tromey.com>
 565
 566         * gnulib: Move directory to top-level.
 567         * configure.ac: Don't configure gnulib.
 568         * configure: Rebuild.
 569         * common/common-defs.h: Use new path to gnulib.
 570         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 571         (GNULIB_H): Remove.
 572         (INCGNU): Look in new gnulib location.
 573         (HFILES_NO_SRCDIR): Remove gnulib files.
 574         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 575         (generated_files): Remove GNULIB_H.
 576         ($(LIBGNU), all-lib): Remove targets.
 577         (distclean): Don't mention GNULIB_BUILDDIR.
 578         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 579
 580 2019-06-14  Tom Tromey  <tromey@adacore.com>
 581
 582         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 583         Warn if symbol file does not provide any symbols.
 584
 585 2019-06-14  Tom Tromey  <tromey@adacore.com>
 586
 587         * source.c (find_and_open_source): Respect basenames_may_differ.
 588
 589 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 590
 591         * annotate.c (annotate_breakpoints_invalid): Make use of
 592         scoped_restore_terminal_state.
 593         (annotate_frames_invalid): Likewise.
 594
 595 2019-06-14  Tom Tromey  <tromey@adacore.com>
 596
 597         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 598         allow assignment to an internalvar.
 599
 600 2019-06-14  Tom Tromey  <tromey@adacore.com>
 601
 602         * ada-lex.l: Allow "_" in attribute names.
 603
 604 2019-06-14  Tom Tromey  <tromey@adacore.com>
 605
 606         PR gdb/24653:
 607         * regcache.c (registers_changed): Don't call alloca.
 608         * top.c (execute_command): Don't call alloca.
 609
 610 2019-06-13  Pedro Alves  <palves@redhat.com>
 611
 612         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 613         'expression'.  When parsing an expression, error out if there's
 614         junk after "unlimited".
 615         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 616         (do_set_command): Adjust calls to is_unlimited_literal.
 617
 618 2019-06-13  Pedro Alves  <palves@redhat.com>
 619
 620         * compile/compile.c (make_compile_options_def_group): Add braces
 621         around array_view initializer.
 622         * thread.c (make_thread_apply_all_options_def_group)
 623         (make_thread_apply_all_options_def_group): Likewise.
 624
 625 2019-06-13  Pedro Alves  <palves@redhat.com>
 626
 627         * NEWS (New commands): Mention "maint test-options
 628         require-delimiter", "maint test-options unknown-is-error", "maint
 629         test-options unknown-is-operand" and "maint show
 630         test-options-completion-result".
 631         (New command options, command completion): New section.
 632         (Completion improvements): New section.
 633         Mention that you can abbreviate "unlimited".
 634
 635 2019-06-13  Pedro Alves  <palves@redhat.com>
 636
 637         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 638         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 639         * unittests/cli-utils-selftests.c (test_parse_flags)
 640         (test_parse_flags_qcs): Delete.
 641         (test_cli_utils): Don't call deleted functions.
 642
 643 2019-06-13  Pedro Alves  <palves@redhat.com>
 644
 645         * thread.c: Include "cli/cli-option.h".
 646         (tp_array_compar_ascending): Global.
 647         (tp_array_compar): Delete function.
 648         (tp_array_compar_ascending, tp_array_compar_descending): New
 649         functions.
 650         (ascending_option_def, qcs_flag_option_def)
 651         (thr_qcs_flags_option_defs)
 652         (make_thread_apply_all_options_def_group)
 653         (make_thread_apply_options_def_group): New.
 654         (thread_apply_all_command): Use gdb::option::process_options.
 655         (thread_apply_command_completer)
 656         (thread_apply_all_command_completer): New.
 657         (thread_apply_command): Use gdb::option::process_options.
 658         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 659         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 660         to generate help text of "thread apply".  Adjust "taas"'s help.
 661         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 662         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 663
 664 2019-06-13  Pedro Alves  <palves@redhat.com>
 665
 666         * thread.c (thread_apply_command): Check for invalid TID with
 667         isdigit instead of !isalpha.
 668
 669 2019-06-13  Pedro Alves  <palves@redhat.com>
 670
 671         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 672         (validate_flags_qcs): New.
 673         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 674         (validate_flags_qcs): Declare.
 675         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 676         (make_frame_apply_options_def_group): New.
 677         (frame_apply_command_count): Process options with
 678         gdb::option::process_options.
 679         (frame_apply_completer): New.
 680         (frame_apply_level_completer, frame_apply_all_completer)
 681         (frame_apply_completer): New.
 682         (_initialize_stack): Update help of "frame apply", "frame apply
 683         level", "frame apply all" and "faas" to mention supported options
 684         and install command completers.
 685         * stack.h (frame_apply_all_completer): Declare.
 686         * thread.c: Include "stack.h".
 687         (tfaas_command): Add "--".
 688         (_initialize_thread): Update help "tfaas" to mention supported
 689         options and install command completer.
 690
 691 2019-06-13  Pedro Alves  <palves@redhat.com>
 692
 693         * completer.c (complete_nested_command_line): New.
 694         (gdb_completion_word_break_characters_throw): Add assertion.
 695         * completer.h (complete_nested_command_line): Declare.
 696
 697 2019-06-13  Pedro Alves  <palves@redhat.com>
 698
 699         * stack.c (parse_backtrace_qualifiers): New.
 700         (backtrace_command): Use it.
 701         (backtrace_command_completer): Complete on qualifiers.
 702
 703 2019-06-13  Pedro Alves  <palves@redhat.com>
 704
 705         * frame.c: Include "cli/cli-option.h.
 706         (user_set_backtrace_options): New.
 707         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 708         Delete.
 709         (get_prev_frame): Adjust.
 710         (boolean_option_def, uinteger_option_def)
 711         (set_backtrace_option_defs): New.
 712         (_initialize_frame): Adjust and use
 713         gdb::option::add_setshow_cmds_for_options to install "set
 714         backtrace past-main" and "set backtrace past-entry".
 715         * frame.h: Include "cli/cli-option.h".
 716         (struct frame_print_options): Forward declare.
 717         (print_frame_arguments_all, print_frame_arguments_scalars)
 718         (print_frame_arguments_none): Declare.
 719         (print_entry_values): Delete declaration.
 720         (struct frame_print_options, user_frame_print_options): New.
 721         (struct set_backtrace_options): New.
 722         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 723         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 724         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 725         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 726         (list_args_or_locals): Add frame_print_options parameter.
 727         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 728         * python/py-framefilter.c (enumerate_args): Pass down
 729         USER_FRAME_PRINT_OPTIONS.
 730         * stack.c: Include "cli/cli-option.h".
 731         (print_frame_arguments_all, print_frame_arguments_scalars)
 732         (print_frame_arguments_none): Declare.
 733         (print_raw_frame_arguments, print_entry_values): Delete.
 734         (user_frame_print_options): New.
 735         (boolean_option_def, enum_option_def, frame_print_option_defs):
 736         New.
 737         (struct backtrace_cmd_options): New.
 738         (bt_flag_option_def): New.
 739         (backtrace_command_option_defs): New.
 740         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 741         (print_frame_arg, read_frame_arg, print_frame_args)
 742         (print_frame_info, print_frame): Add frame_print_options parameter
 743         and use it.
 744         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 745         (backtrace_command_1): Add frame_print_options and
 746         backtrace_cmd_options parameters and use them.
 747         (make_backtrace_options_def_group): New.
 748         (backtrace_command): Process command options with
 749         gdb::option::process_options.
 750         (backtrace_command_completer): New.
 751         (_initialize_stack): Extend "backtrace"'s help to mention
 752         supported options.  Install completer for "backtrace".
 753         Install some settings commands with add_setshow_cmds_for_options.
 754
 755 2019-06-13  Pedro Alves  <palves@redhat.com>
 756
 757         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 758         and that "set/show print raw frame-arguments" are now deprecated.
 759
 760         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 761         command.
 762         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 763         * stack.c (_initialize_stack): Install "set/show print
 764         raw-frame-arguments", and deprecate "set/show print raw
 765         frame-arguments".
 766         * valprint.c (_initialize_valprint): Deprecate "set/show print
 767         raw".
 768
 769 2019-06-13  Pedro Alves  <palves@redhat.com>
 770
 771         * compile/compile.c (struct compile_options): New.
 772         (compile_flag_option_def, compile_command_option_defs)
 773         (make_compile_options_def_group): New.
 774         (compile_file_command): Handle options with
 775         gdb::option::process_options.
 776         (compile_file_command_completer): New function.
 777         (compile_code_command): Handle options with
 778         gdb::option::process_options.
 779         (compile_code_command_completer): New function.
 780         (_initialize_compiler): Install completers for "compile code" and
 781         "compile file".  Mention available options in "compile code" and
 782         "compile code"'s help.
 783         * completer.c (advance_to_completion_word): New, factored out from
 784         ...
 785         (advance_to_expression_complete_word_point): ... this.
 786         (advance_to_filename_complete_word_point): New.
 787         * completer.h (advance_to_filename_complete_word_point): New
 788         declaration.
 789
 790 2019-06-13  Pedro Alves  <palves@redhat.com>
 791
 792         * compile/compile.c: Include "cli/cli-option.h".
 793         (compile_print_value): Scope data pointer is now a
 794         value_print_options pointer; adjust.
 795         (compile_print_command): Process options.  Scope data pointer is
 796         now a value_print_options pointer; adjust.
 797         (_initialize_compile): Update "compile print"'s help to include
 798         supported options.  Install a completer for "compile print".
 799         * cp-valprint.c (show_vtblprint, show_objectprint)
 800         (show_static_field_print): Delete.
 801         (_initialize_cp_valprint): Don't install "set print
 802         static-members", "set print vtbl", "set print object" here.
 803         * printcmd.c: Include "cli/cli-option.h" and
 804         "common/gdb_optional.h".
 805         (print_command_parse_format): Rework to fill in a
 806         value_print_options instead of a format_data.
 807         (print_value): Change parameter type from format_data pointer to
 808         value_print_options reference.  Adjust.
 809         (print_command_1): Process options.  Adjust to pass down a
 810         value_print_options.
 811         (print_command_completer): New.
 812         (_initialize_printcmd): Install print_command_completer as
 813         handle_brkchars completer for the "print" command.  Update
 814         "print"'s help to include supported options.
 815         * valprint.c: Include "cli/cli-option.h".
 816         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 817         here from cp-valprint.c.
 818         (boolean_option_def, uinteger_option_def)
 819         (value_print_option_defs, make_value_print_options_def_group):
 820         New.  Use gdb::option::add_setshow_cmds_for_options to install
 821         "set print elements", "set print null-stop", "set print repeats",
 822         "set print pretty", "set print union", "set print array", "set
 823         print address", "set print symbol", "set print array-indexes".
 824         * valprint.h: Include <string> and "cli/cli-option.h".
 825         (make_value_print_options_def_group): Declare.
 826         (print_value): Change parameter type from format_data pointer to
 827         value_print_options reference.
 828         (print_command_completer): Declare.
 829
 830 2019-06-13  Pedro Alves  <palves@redhat.com>
 831
 832         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 833         (COMMON_SFILES): Add maint-test-settings.c.
 834         * cli/cli-decode.c (boolean_enums): New global, factored out from
 835         ...
 836         (add_setshow_boolean_cmd): ... here.
 837         * cli/cli-decode.h (boolean_enums): Declare.
 838         * cli/cli-option.c: New file.
 839         * cli/cli-option.h: New file.
 840         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 841         factored out from ...
 842         (parse_cli_boolean_value(const char *)): ... this.
 843         (is_unlimited_literal): Change parameter type to pointer to
 844         pointer.  Adjust and advance ARG pointer.
 845         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 846         (parse_cli_var_enum): New, factored out from ...
 847         (do_set_command): ... this.  Adjust.
 848         * cli/cli-setshow.h (parse_cli_boolean_value)
 849         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 850         (parse_cli_var_enum): Declare.
 851         * cli/cli-utils.c: Include "cli/cli-option.h".
 852         (get_ulongest): New.
 853         * cli/cli-utils.h (get_ulongest): Declare.
 854         (check_for_argument): New overloads.
 855         * maint-test-options.c: New file.
 856
 857 2019-06-13  Pedro Alves  <palves@redhat.com>
 858
 859         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 860         parse a range if "-" is at the end of the string.
 861
 862 2019-06-13  Pedro Alves  <palves@redhat.com>
 863
 864         * cli/cli-setshow.c (parse_auto_binary_operation)
 865         (parse_cli_boolean_value): Don't allow "o".
 866
 867 2019-06-13  Pedro Alves  <palves@redhat.com>
 868
 869         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 870         * NEWS: Mention maint test-settings KIND.
 871         * maint-test-settings.c: New file.
 872
 873 2019-06-13  Pedro Alves  <palves@redhat.com>
 874
 875         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 876         completer.
 877         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 878         "set" completers.
 879
 880 2019-06-13  Pedro Alves  <palves@redhat.com>
 881
 882         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 883         after item.
 884
 885 2019-06-13  Pedro Alves  <palves@redhat.com>
 886
 887         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 888
 889 2019-06-13  Pedro Alves <palves@redhat.com>
 890
 891         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 892         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 893         call.
 894         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 895         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 896         calls.
 897         (check_for_argument): Skip spaces after argument.
 898
 899 2019-06-13  Pedro Alves  <palves@redhat.com>
 900
 901         * thread.c (thread_apply_command): Adjust TID parsing.
 902         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 903         detected before end of string.
 904         (tid_is_in_list): Error out if LIST is invalid.
 905
 906 2019-06-13  Pedro Alves  <palves@redhat.com>
 907
 908         * completer.c (complete_line_internal_1): Rewind completion word
 909         point.
 910         (completion_tracker::advance_custom_word_point_by): Change
 911         parameter type to int.
 912         * completer.h (completion_tracker::advance_custom_word_point_by):
 913         Likewise.
 914
 915 2019-06-13  Pedro Alves  <palves@redhat.com>
 916
 917         * completer.c (advance_to_completion_word): Handle delimiters.
 918
 919 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 920
 921         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 922
 923 2019-06-11  Tom Tromey  <tom@tromey.com>
 924
 925         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 926         (xmalloc_failed): Move to alloc.c.
 927         * alloc.c: New file.
 928         * Makefile.in (COMMON_SFILES): Add alloc.c.
 929
 930 2019-06-11  Tom Tromey  <tom@tromey.com>
 931
 932         * nat/linux-waitpid.c: Don't include server.h.
 933         (linux_debug): Remove.
 934         (my_waitpid): Update.
 935
 936 2019-06-11  Tom Tromey  <tromey@adacore.com>
 937
 938         * infcall.c (_initialize_infcall): Remove trailing newline from
 939         help.
 940         * user-regs.c (_initialize_user_regs): Remove trailing newline
 941         from help.
 942         * typeprint.c (_initialize_typeprint): Remove trailing newline
 943         from help.
 944         * reverse.c (_initialize_reverse): Remove trailing newlines from
 945         help.
 946         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 947         from help.
 948         * language.c (add_set_language_command): Remove trailing newline
 949         from help.
 950         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 951         help.
 952         * disasm.c (_initialize_disasm): Remove trailing newline from
 953         help.
 954         * top.c (init_main): Remove trailing newline from help.
 955         * interps.c (_initialize_interpreter): Remove trailing newline
 956         from help.
 957         * btrace.c (_initialize_btrace): Remove trailing newlines from
 958         help.
 959         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 960         from help.
 961         * python/python.c (_initialize_python): Remove trailing newline
 962         from help.
 963         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 964         help.
 965         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 966         from help.  Reformat some text.
 967         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 968         from help.
 969         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 970         newline from help.
 971
 972 2019-06-11  Tom Tromey  <tromey@adacore.com>
 973
 974         * darwin-nat.c (darwin_decode_exception_message)
 975         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 976
 977 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * valops.c (value_slice): Check for not allocated or not
 980         associated values.
 981
 982 2019-06-10  Tom de Vries  <tdevries@suse.de>
 983
 984         PR gdb/24618
 985         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 986         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 987         invalid.
 988
 989 2019-06-10  Tom de Vries  <tdevries@suse.de>
 990
 991         PR gdb/24611
 992         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 993         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 994
 995 2019-06-10  Tom de Vries  <tdevries@suse.de>
 996
 997         PR symtab/24545
 998         * symtab.c (struct demangled_name_entry): Add language field.
 999         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1000         static minimal symbol".  Set and use language field.
1001
1002 2019-06-10  Tom Tromey  <tromey@adacore.com>
1003
1004         * ada-lang.c (_initialize_ada_language): Update help text.
1005
1006 2019-06-10  Tom Tromey  <tromey@adacore.com>
1007
1008         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1009         with a newline.
1010         * guile/guile.c (handle_boot_error): Don't end warning with a
1011         newline.
1012         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1013         warning with a newline.
1014         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1015         newline.
1016         (s12z_frame_cache): Likewise.
1017         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1018         a newline.
1019         * solib-svr4.c (disable_probes_interface): Don't end warning with
1020         a newline.
1021         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1022         newline.
1023         * python/python.c (do_finish_initialization): Don't end warning
1024         with a newline.
1025
1026 2019-06-10  Tom Tromey  <tom@tromey.com>
1027
1028         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1029         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1030         gdbpy_enter.
1031
1032 2019-06-10  Tom Tromey  <tromey@adacore.com>
1033
1034         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1035         data.
1036         (elf_new_init): Don't call stabsread_new_init.
1037         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1038         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1039         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1040
1041 2019-06-10  Tom de Vries  <tdevries@suse.de>
1042
1043         PR symtab/16264
1044         PR symtab/24517
1045         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1046
1047 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1048
1049         * source.c (find_and_open_source): Also rewrite relative file
1050         names.
1051
1052 2019-04-26  Amos Bird  <amosbird@gmail.com>
1053
1054         * annotate.c (annotate_thread_exited): Add "thread-exited"
1055         annotation.
1056
1057 2019-06-06  Tom Tromey  <tromey@adacore.com>
1058
1059         * maint.h (class scoped_command_stats): Use
1060         DISABLE_COPY_AND_ASSIGN.
1061         <print_time>: New method.
1062         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1063         print_time.
1064         (scoped_command_stats::print_time): New method.
1065
1066 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1069         instructions of lengths 6 or 8 bytes.
1070
1071 2019-06-04  Pedro Alves  <palves@redhat.com>
1072
1073         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1074
1075         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1076         * breakpoint.c (condition_completer): Likewise.
1077         * cli/cli-dump.c (scan_expression): Likewise.
1078         * common/filestuff.c (mkdir_recursive): Likewise.
1079         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1080         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1081         (gdb_abspath): Likewise.
1082         * compile/compile-cplus-types.c
1083         (compile_cplus_instance::decl_name): Likewise.
1084         * completer.c (complete_explicit_location):
1085         (signal_completer, reg_or_group_completer_1): Likewise.
1086         * cp-support.c (cp_remove_params_if_any): Likewise.
1087         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1088         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1089         * infcmd.c (strip_bg_char): Likewise.
1090         * linespec.c (copy_token_string): Likewise.
1091         * mi/mi-main.c (output_cores): Likewise.
1092         * psymtab.c (psymtab_search_name):
1093         * symfile.c (test_set_ext_lang_command): Likewise.
1094         * target.c (target_fileio_read_stralloc): Likewise.
1095         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1096         * value.c (complete_internalvar): Likewise.
1097
1098 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1099
1100         Add objfile property to gdb.Type.
1101         * NEWS: Mention Python API addition.
1102         * python/py-type.c (typy_get_objfile): New method.
1103
1104 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1105
1106         * NEWS: Mention the new set|show style [title|highlight].
1107         Mention changes to "show style", "help" and "apropos".
1108
1109 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1110
1111         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1112         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1113         instead of print_help_for_command.
1114         (print_doc_of_command): New function.
1115         (help_list): Add 'apropos -v word' suggestion.
1116         (print_help_for_command): Style the command name using title style.
1117         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1118         (_initialize_cli_cmds): Describe -v in apropos_command help.
1119
1120 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1121
1122         * cli/cli-style.h (cli_style_option): Add name in constructor,
1123         add m_name class member, add constructor with intensity,
1124         add name class function.
1125         (cli_style_option::add_setshow_commands): Remove name argument.
1126         (highlight_style, title_style): New styles.
1127         * cli/cli-style.c (do_show): New function that shows a style
1128         characteristic styling the style name with itself.
1129         (set_style_name): New function.
1130         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1131         Update all callers according to the changes in cli/cli-style.h.
1132         * utils.h (fputs_highlighted): New function.
1133         * utils.c (fputs_highlighted): Likewise.
1134
1135 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1136
1137         * NEWS: Mention new pipe command and new convenience variables.
1138
1139 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1140
1141         * cli/cli-cmds.c (pipe_command): New function.
1142         (_initialize_cli_cmds): Call add_com for pipe_command.
1143         Define | as an alias for pipe.
1144         (exit_status_set_internal_vars): New function.
1145         (shell_escape): Call exit_status_set_internal_vars.
1146         cli/cli-decode.c (find_command_name_length): Recognize | as
1147         a single character command.
1148
1149 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1150
1151         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1152         top.c (execute_command_to_ui_file): New function, mostly a copy
1153         of execute_command_to_string.
1154         (execute_command_to_string): Implement by calling
1155         execute_command_to_ui_file.
1156
1157 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1158
1159         * top.h (saved_command_line): Remove declaration.
1160         * top.c (previous_saved_command_line, previous_repeat_arguments):
1161         New variables.
1162         (saved_command_line): Make static, define together with other
1163         'repeat variables'.
1164         (dont_repeat): Clear repeat_arguments.
1165         (repeat_previous, get_saved_command_line, save_command_line):
1166         New functions.
1167         (gdb_init): Initialize saved_command_line
1168         and previous_saved_command_line.
1169         * main.c (captured_main_1): Remove saved_command_line initialization.
1170         * event-top.c (handle_line_of_input): Update to use
1171         the new 'repeat' related functions instead of direct access to
1172         saved_command_line.
1173         * command.h (repeat_previous, get_saved_command_line,
1174         save_command_line): New declarations.
1175         (dont_repeat): Add comment.
1176
1177 2019-05-30  Tom Tromey  <tromey@adacore.com>
1178
1179         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1180         Fix comment.
1181         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1182
1183 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1184
1185         PR cli/24587
1186         * completer.c (complete): Initialize variable word.
1187
1188 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1189
1190         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1191         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1192         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1193         'body' is NULL to the outter 'if', protecting the '!is_define'
1194         situation as well.
1195
1196 2019-05-29  Tom Tromey  <tromey@adacore.com>
1197
1198         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1199         (dwarf_unknown): New function.
1200         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1201         (dwarf_type_encoding_name): Use dwarf_unknown.
1202
1203 2019-05-29  Tom Tromey  <tromey@adacore.com>
1204
1205         PR c++/20020:
1206         * cp-valprint.c (cp_print_value_fields): Call
1207         cp_print_static_field inside "try".
1208
1209 2019-05-29  Tom Tromey  <tromey@adacore.com>
1210
1211         * inflow.c (struct terminal_info): Add default operator=.
1212         * configure: Rebuild.
1213         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1214         -Wdeprecated-copy-dtor, -Wredundant-move.
1215
1216 2019-05-29  Tom Tromey  <tromey@adacore.com>
1217
1218         * NEWS: Add entry.
1219         * infcmd.c (print_return_value_1): Handle finish_print
1220         option.
1221         (show_print_finish): New function.
1222         (_initialize_infcmd): Add "set/show print finish" commands.
1223         * valprint.c (user_print_options): Initialize new member.
1224         * valprint.h (struct value_print_options) <finish_print>: New
1225         member.
1226
1227 2019-05-28  Tom Tromey  <tromey@adacore.com>
1228
1229         * ada-lang.c (ada_remove_Xbn_suffix)
1230         (find_old_style_renaming_symbol)
1231         (parse_old_style_renaming): Remove.
1232         (ada_find_renaming_symbol): Don't call
1233         find_old_style_renaming_symbol.
1234         (ada_is_renaming_symbol): Rename from
1235         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1236         bool.  Now static.
1237         (ada_read_var_value): Update and simplify.
1238         * ada-exp.y (write_var_or_type): Remove old code.
1239
1240 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1241
1242         * event-top.c: Remove include comment.
1243         * inflow.c (class scoped_ignore_sigttou): Move from here...
1244         * inflow.h (class scoped_ignore_sigttou): ...to here.
1245         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1246         * top.c:  Remove include comment.
1247
1248 2019-05-27  Tom Tromey  <tom@tromey.com>
1249
1250         * NEWS: Fix typo.
1251
1252 2019-05-22  Tom Tromey  <tromey@adacore.com>
1253
1254         * target.c (target_follow_exec): Constify parameter.
1255         * target-delegates.c: Rebuild.
1256         * remote.c (remote_target::follow_exec): Constify parameter.
1257         * infrun.c (follow_exec): Constify parameter.
1258         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1259         (target_follow_exec): Likewise.
1260
1261 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1262
1263         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1264         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1265
1266 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1267
1268         * NEWS: Add debugredirect and testsuite sections.
1269
1270 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1271
1272         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1273         target descriptions using exclusively floating point register name
1274         aliases.
1275
1276 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1277
1278         PR gdb/18644:
1279         * f-lang.c (build_fortran_types): Handle the case where
1280         gdbarch_floatformat_for_type returns a nullptr.
1281
1282 2019-05-21  Tom de Vries  <tdevries@suse.de>
1283
1284         PR cli/24587
1285         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1286
1287 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         PR gdb/18644:
1290         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1291         16-byte floats.
1292         * i386-tdep.c (i386_floatformat_for_type): Use
1293         floatformats_ia64_quad for the 16-byte floating point component
1294         within a fortran 32-byte complex number.
1295
1296 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1297
1298         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1299         delete default constructor.
1300         (find_partial_die): Update to return const struct.
1301         (partial_die_parent_scope): Move variable declaration into scope
1302         of its use and change its type to auto.
1303         (guess_partial_die_structure_name): Likewise.
1304         (partial_die_info::fixup): Likewise.
1305
1306 2019-05-17  Tom Tromey  <tromey@adacore.com>
1307
1308         * source.c (find_and_open_source): Remove cast.
1309
1310 2019-05-17  Tom Tromey  <tromey@adacore.com>
1311
1312         * annotate.c (annotate_source): Make "filename" const.
1313         * annotate.h (annotate_source): Use const.
1314
1315 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1316
1317         * disasm.c (set_disassembler_options): Send errors to stderr.
1318
1319 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1320
1321         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1322         (cli_interp_base::set_logging): Check debug_redirect.
1323         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1324         * cli/cli-logging.c (debug_redirect): Add static variable.
1325         (pop_output_files): Add default param.
1326         (handle_redirections): Print debug setting.
1327         (show_logging_command): Likewise.
1328         (_initialize_cli_logging): Add debugredirect command.
1329         * interps.c (current_interp_set_logging): Add debug_redirect
1330         parameter.
1331         * interps.h (set_logging): Add debug_redirect parameter.
1332         (current_interp_set_logging): Likewise.
1333         * mi/mi-common.h: Likewise.
1334         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1335
1336 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1337             Tom Tromey  <tromey@adacore.com>
1338
1339         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1340         directly.
1341         * cli/cli-interp.h (make_logging_output): Remove declaration.
1342         * cli/cli-logging.c (make_logging_output): Remove function.
1343         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1344         directly.
1345         * ui-file.c (tee_file::tee_file): Remove bools.
1346         (tee_file::~tee_file): Remove deletes.
1347         * ui-file.h (tee_file): Remove bools.
1348
1349 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1350
1351         * mi/mi-cmds.h (mi_cmd_complete): New function.
1352         * mi/mi-main.c (mi_cmd_complete): Likewise.
1353         * mi/mi-cmds.c: Define new MI command -complete.
1354         * NEWS: Mention new -complete command.
1355
1356 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1357
1358         * completer.h (complete): New function.
1359         * completer.c (complete): Likewise.
1360         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1361         function defined in completer.h.
1362
1363 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1364
1365         * MAINTAINERS (Write After Approval): Add myself.
1366
1367 2019-05-17  Tom de Vries  <tdevries@suse.de>
1368
1369         PR gdb/24094
1370         * dwarf2read.c (struct cu_partial_die_info): New struct.
1371         (find_partial_die): Return cu_partial_die_info.
1372         (partial_die_parent_scope, guess_partial_die_structure_name)
1373         (partial_die_info::fixup): Handle new return type of find_partial_die.
1374
1375 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1376
1377         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1378         "std::string", simplifying the algorithm.
1379
1380 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1381
1382         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1383         (stap_static_probe_ops::get_probes): Likewise.
1384
1385 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1386
1387         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1388         '-')" and "else if".
1389         (stap_parse_single_operand): Join checks for
1390         "gdbarch_stap_parse_special_token_p" and
1391         "gdbarch_stap_parse_special_token" in the same "if" statement.
1392         Invert check when verifying for operation on register
1393         displacement.
1394
1395 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1396
1397         * stap-probe.c (stap_get_opcode): Update comment.
1398         (stap_get_expected_argument_type): Likewise.
1399         (handle_stap_probe): Likewise.
1400
1401 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1402
1403         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1404         return type to 'bool'.  Adjust comment.  Use 'bool' when
1405         appropriate.
1406         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1407         * stap-probe.c (stap_parse_argument_1): Likewise.
1408         (stap_is_operator): Likewise.
1409         (stap_is_generic_prefix): Likewise.
1410         (stap_is_register_prefix): Likewise.
1411         (stap_is_register_indirection_prefix): Likewise.
1412         (stap_is_integer_prefix): Likewise.
1413         (stap_generic_check_suffix): Likewise.
1414         (stap_check_integer_suffix): Likewise.
1415         (stap_check_register_suffix): Likewise.
1416         (stap_check_register_indirection_suffix): Likewise.
1417         (stap_parse_register_operand): Likewise.
1418         (stap_parse_single_operand): Likewise.
1419         (stap_parse_argument_1): Likewise.
1420         (stap_probe::get_argument_count): Likewise.
1421         (stap_is_operator): Likewise.
1422
1423 2019-05-16  Tom Tromey  <tromey@adacore.com>
1424
1425         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1426         keyword to foreach.
1427
1428 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1429
1430         * linux-thread-db.c (try_thread_db_load_1): Change return type
1431         to bool.
1432         (try_thread_db_load): Likewise.
1433         (try_thread_db_load_from_pdir_1): Likewise.
1434         (try_thread_db_load_from_pdir): Likewise.
1435         (try_thread_db_load_from_sdir): Likewise.
1436         (try_thread_db_load_from_dir): Likewise.
1437         (thread_db_load_search): Likewise.
1438         (has_libpthread): Likewise.
1439         (thread_db_load): Likewise.
1440
1441 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1442
1443         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1444         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1445         NULL, and complain/return if that's the case.
1446
1447 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1448
1449         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1450         (advance, posn, abstract_read_memory): New functions.
1451         [struct mem_read_abstraction]: New struct.
1452         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1453
1454 2019-05-14  Tom Tromey  <tromey@adacore.com>
1455
1456         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1457         value is not lval_memory.
1458
1459 2019-05-14  Tom Tromey  <tromey@adacore.com>
1460
1461         * solib.c (info_sharedlibrary_command): Style the file name.
1462
1463 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1464
1465         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1466         (aarch64_vnv_type): Likewise.
1467         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1468         * common/tdesc.c: Likewise.
1469         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1470         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1471         * features/aarch64-fpu.xml: Add ieee half view.
1472         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1473         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1474         * gdbtypes.h (struct builtin_type): Likewise.
1475         (struct objfile_type): Likewise.
1476
1477 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1478
1479         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1480         typo.
1481         * location.h (string_to_event_location): Likewise.
1482
1483 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1484
1485         GDB 8.3 released.
1486
1487 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1488
1489         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1490         New variable declaration.
1491         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1492         New variable.
1493         (print_one_breakpoint): Use ui_out::test_flags and new global
1494         variable to compute use_fixed_output.
1495         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1496         Remove.
1497         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1498         (mi_multi_location_breakpoint_output_fixed): Remove.
1499         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1500         new variable.
1501         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1502         fix_multi_location_breakpoint_output flag if version >= 3.
1503         * ui-out.h (enum ui_out_flag)
1504         <fix_multi_location_breakpoint_output>: New enumerator.
1505
1506 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1507
1508         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1509
1510 2019-05-10  Tom Tromey  <tromey@adacore.com>
1511
1512         * ada-lang.c (catch_ada_completer): New function.
1513         (_initialize_ada_language): Use it.
1514
1515 2019-05-10  Tom Tromey  <tromey@adacore.com>
1516
1517         * thread.c (print_thread_info): Make "requested_threads" const.
1518         * gdbthread.h (print_thread_info): Make "requested_threads"
1519         const.
1520         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1521         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1522
1523 2019-05-08  Tom Tromey  <tom@tromey.com>
1524
1525         * gdbtypes.c (objfile_type_data): Change type.
1526         (objfile_type, _initialize_gdbtypes): Update.
1527
1528 2019-05-08  Tom Tromey  <tom@tromey.com>
1529
1530         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1531         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1532         (_initialize_dwarf2_frame): Update.
1533
1534 2019-05-08  Tom Tromey  <tom@tromey.com>
1535
1536         * objc-lang.c (objc_objfile_data): Change type.
1537         (find_methods): Update.
1538         (_initialize_objc_lang): Remove.
1539
1540 2019-05-08  Tom Tromey  <tom@tromey.com>
1541
1542         * stabsread.c (rs6000_builtin_type_data): Change type.
1543         (rs6000_builtin_type, _initialize_stabsread): Update.
1544
1545 2019-05-08  Tom Tromey  <tom@tromey.com>
1546
1547         * mips-tdep.c (mips_pdr_data): Remove.
1548         (_initialize_mips_tdep): Update.
1549
1550 2019-05-08  Tom Tromey  <tom@tromey.com>
1551
1552         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1553         (hppa_init_objfile_priv_data, read_unwind_info)
1554         (find_unwind_entry, _initialize_hppa_tdep): Update.
1555
1556 2019-05-08  Tom Tromey  <tom@tromey.com>
1557
1558         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1559         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1560         on obstack.
1561         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1562
1563 2019-05-08  Tom Tromey  <tom@tromey.com>
1564
1565         * mdebugread.c (basic_type_data): Change type.
1566         (basic_type, _initialize_mdebugread): Update.
1567
1568 2019-05-08  Tom Tromey  <tom@tromey.com>
1569
1570         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1571
1572 2019-05-08  Tom Tromey  <tom@tromey.com>
1573
1574         * nto-tdep.c (nto_inferior_data_reg): Change type.
1575         (nto_inferior_data): Update.
1576         (nto_inferior_data_cleanup, nto_new_inferior_data)
1577         (_initialize_nto_tdep): Remove.
1578         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1579
1580 2019-05-08  Tom Tromey  <tom@tromey.com>
1581
1582         * ada-lang.c (struct ada_inferior_data): Add initializers.
1583         (ada_inferior_data): Change type.
1584         (ada_inferior_data_cleanup): Remove.
1585         (get_ada_inferior_data, ada_inferior_exit)
1586         (struct ada_pspace_data): Add initializers, destructor.
1587         (ada_pspace_data_handle): Change type.
1588         (get_ada_pspace_data): Update.
1589         (ada_pspace_data_cleanup): Remove.
1590
1591 2019-05-08  Tom Tromey  <tom@tromey.com>
1592
1593         * coffread.c (struct coff_symfile_info): Add initializers.
1594         (coff_objfile_data_key): Move lower.  Change type.
1595         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1596         Update.
1597         (coff_free_info): Remove.
1598
1599 2019-05-08  Tom Tromey  <tom@tromey.com>
1600
1601         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1602         (fbsd_pspace_data_handle): Move lower.  Change type.
1603         (get_fbsd_pspace_data): Update.
1604         (fbsd_pspace_data_cleanup): Remove.
1605         (_initialize_fbsd_tdep): Update.
1606
1607 2019-05-08  Tom Tromey  <tom@tromey.com>
1608
1609         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1610         (get_ada_tasks_pspace_data): Update.
1611         (ada_tasks_pspace_data_cleanup): Remove.
1612         (_initialize_tasks): Update.
1613         (ada_tasks_inferior_data_handle): Change type.
1614         (get_ada_tasks_inferior_data): Update.
1615         (ada_tasks_inferior_data_cleanup): Remove.
1616         (struct ada_tasks_pspace_data): Add initializers.
1617
1618 2019-05-08  Tom Tromey  <tom@tromey.com>
1619
1620         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1621         * symfile-debug.c (debug_sym_get_probes): Change type.
1622         * stap-probe.c (handle_stap_probe):
1623         (stap_static_probe_ops::get_probes): Change type.
1624         * probe.h (class static_probe_ops) <get_probes>: Change type.
1625         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1626         (parse_probes_in_pspace): Update.
1627         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1628         Update.
1629         (any_static_probe_ops::get_probes): Change type.
1630         * elfread.c (elfread_data): New typedef.
1631         (probe_key): Change type.
1632         (elf_get_probes): Likewise.  Update.
1633         (probe_key_free): Remove.
1634         (_initialize_elfread): Update.
1635         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1636         Change type.
1637         (dtrace_process_dof_probe, dtrace_process_dof)
1638         (dtrace_static_probe_ops::get_probe): Change type.
1639
1640 2019-05-08  Tom Tromey  <tom@tromey.com>
1641
1642         * xcoffread.c (struct xcoff_symfile_info): Rename from
1643         coff_symfile_info.  Add initializers.
1644         (xcoff_objfile_data_key): Move lower.  Change type.
1645         (XCOFF_DATA): Rewrite.
1646         (xcoff_free_info): Remove.
1647         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1648         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1649         (xcoff_initial_scan): Update.
1650
1651 2019-05-08  Tom Tromey  <tom@tromey.com>
1652
1653         * solib-svr4.c (struct svr4_info): Add initializers and
1654         destructor.
1655         <probes_table>: Now an htab_up.
1656         (solib_svr4_pspace_data): Change type.
1657         (free_probes_table): Simplify.
1658         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1659         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1660         (probes_table_remove_objfile_probes, register_solib_event_probe)
1661         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1662         (_initialize_svr4_solib): Update.
1663
1664 2019-05-08  Tom Tromey  <tom@tromey.com>
1665
1666         * remote.c (remote_pspace_data): Change type.
1667         (remote_pspace_data_cleanup): Remove.
1668         (get_remote_exec_file, set_pspace_remote_exec_file)
1669         (_initialize_remote): Update.
1670
1671 2019-05-08  Tom Tromey  <tom@tromey.com>
1672
1673         * breakpoint.c (breakpoint_objfile_key): Change type.
1674         (get_breakpoint_objfile_data): Update.
1675         (free_breakpoint_objfile_data): Remove.
1676         (_initialize_breakpoint): Update.
1677
1678 2019-05-08  Tom Tromey  <tom@tromey.com>
1679
1680         * linux-tdep.c (struct linux_info): Add initializers.
1681         (linux_inferior_data): Move.  Change type.
1682         (invalidate_linux_cache_inf): Update.
1683         (linux_inferior_data_cleanup): Remove.
1684         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1685
1686 2019-05-08  Tom Tromey  <tom@tromey.com>
1687
1688         * auxv.c (auxv_inferior_data): Move.  Change type.
1689         (auxv_inferior_data_cleanup): Remove.
1690         (invalidate_auxv_cache_inf): Rewrite.
1691         (get_auxv_inferior_data, _initialize_auxv): Update.
1692
1693 2019-05-08  Tom Tromey  <tom@tromey.com>
1694
1695         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1696         (symfile_debug_objfile_data_key): Change type.
1697         (symfile_debug_installed, debug_qf_has_symbols)
1698         (debug_qf_find_last_source_symtab)
1699         (debug_qf_forget_cached_source_info)
1700         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1701         (debug_qf_print_stats, debug_qf_dump)
1702         (debug_qf_expand_symtabs_for_function)
1703         (debug_qf_expand_all_symtabs)
1704         (debug_qf_expand_symtabs_with_fullname)
1705         (debug_qf_map_matching_symbols)
1706         (debug_qf_expand_symtabs_matching)
1707         (debug_qf_find_pc_sect_compunit_symtab)
1708         (debug_qf_map_symbol_filenames)
1709         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1710         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1711         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1712         (debug_sym_read_linetable, debug_sym_relocate): Update.
1713         (symfile_debug_free_objfile): Remove.
1714         (install_symfile_debug_logging, _initialize_symfile_debug):
1715         Update.
1716
1717 2019-05-08  Tom Tromey  <tom@tromey.com>
1718
1719         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1720         allocate_on_obstack.
1721         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1722         (get_dwarf2_per_objfile): Update.
1723         (set_dwarf2_per_objfile): Remove.
1724         (dwarf2_has_info, dwarf2_get_section_info): Update.
1725         (dwarf2_free_objfile): Remove.
1726         (_initialize_dwarf2_read): Update.
1727
1728 2019-05-08  Tom Tromey  <tom@tromey.com>
1729
1730         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1731         initializers.
1732         <unsupported_script_warning_printed,
1733         script_not_found_warning_printed>: Now bool.
1734         (auto_load_pspace_data): Change type.
1735         (~auto_load_pspace_info): Rename from
1736         auto_load_pspace_data_cleanup.
1737         (get_auto_load_pspace_data, init_loaded_scripts_info)
1738         (clear_section_scripts, maybe_print_unsupported_script_warning)
1739         (maybe_print_script_not_found_warning, _initialize_auto_load):
1740         Update.
1741
1742 2019-05-08  Tom Tromey  <tom@tromey.com>
1743
1744         * objfiles.c (objfile_pspace_info): Add destructor and
1745         initializers.
1746         (objfiles_pspace_data): Change type.
1747         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1748         (get_objfile_pspace_data): Update.
1749         (objfiles_bfd_data): Change type.
1750         (get_objfile_bfd_data): Update.
1751         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1752
1753 2019-05-08  Tom Tromey  <tom@tromey.com>
1754
1755         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1756         Change type.
1757         (get_catch_syscall_inferior_data): Update.
1758         (catch_syscall_inferior_data_cleanup): Remove.
1759         (_initialize_break_catch_syscall): Update.
1760
1761 2019-05-08  Tom Tromey  <tom@tromey.com>
1762
1763         * inflow.c (struct terminal_info): Add destructor and
1764         initializers.
1765         (inflow_inferior_data): Change type.
1766         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1767         (get_inflow_inferior_data, inflow_inferior_exit)
1768         (swap_terminal_info, _initialize_inflow): Update.
1769
1770 2019-05-08  Tom Tromey  <tom@tromey.com>
1771
1772         * target-dcache.c (target_dcache_cleanup): Remove.
1773         (target_dcache_aspace_key): Change type.
1774         (target_dcache_init_p, target_dcache_invalidate)
1775         (target_dcache_get, target_dcache_get_or_init)
1776         (_initialize_target_dcache): Update.
1777         * dcache.h (struct dcache_deleter): New.
1778
1779 2019-05-08  Tom Tromey  <tom@tromey.com>
1780
1781         * symtab.c (struct symbol_cache): Add destructor and
1782         initializers.
1783         (symbol_cache_key): Move.  Change type.
1784         (make_symbol_cache, free_symbol_cache): Remove.
1785         (get_symbol_cache): Update.
1786         (symbol_cache_cleanup): Remove.
1787         (ALL_PSPACES, symbol_cache_flush)
1788         (maintenance_print_symbol_cache)
1789         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1790         Update.
1791
1792 2019-05-08  Tom Tromey  <tom@tromey.com>
1793
1794         * symtab.c (struct main_info): Add destructor and initializers.
1795         (main_progspace_key): Move.  Change type.
1796         (get_main_info): Update.
1797         (main_info_cleanup): Remove.
1798         (_initialize_symtab): Update.
1799
1800 2019-05-08  Tom Tromey  <tom@tromey.com>
1801
1802         * registry.h (DECLARE_REGISTRY): Define the _key class.
1803
1804 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * NEWS: Merge two 'New commands' sections.
1807
1808 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1809
1810         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1811         parameter and use Ada language definition instead.
1812         (ada_val_print_ptr): Remove unused language parameter.
1813         (ada_val_print_num): Remove language parameter and use Ada language
1814         definition instead.
1815         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1816         parameter.
1817         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1818         parameter and use Ada language definition instead.
1819         (ada_val_print_1): Update all ada_val_print_xxx calls.
1820         Remove language parameter.
1821         (ada_val_print): Update ada_val_print_1 call.
1822
1823 2019-05-08  Tom Tromey  <tromey@adacore.com>
1824
1825         * remote.c (remote_hw_watchpoint_limit)
1826         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1827         Now static.
1828
1829 2019-05-08  Tom Tromey  <tromey@adacore.com>
1830
1831         * maint.c (_initialize_maint_cmds): Move initialization code to
1832         remote.c.
1833         (watchdog, show_watchdog): Move to remote.c.
1834         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1835         "watchdog" static.
1836         (_initialize_remote): Move initialization code from maint.c.
1837         * defs.h (watchdog): Don't declare.
1838
1839 2019-05-08  Tom Tromey  <tromey@adacore.com>
1840
1841         * tui/tui-interp.c: Include main.h.
1842         * interps.c: Include main.h.
1843         * main.h (interpreter_p): Declare.
1844         * defs.h (interpreter_p): Don't declare.
1845
1846 2019-05-08  Tom Tromey  <tromey@adacore.com>
1847
1848         * dwarf2loc.c: Include dwarf2read.h.
1849         * defs.h (read_unsigned_leb128): Don't declare.
1850         * dwarf2read.h (read_unsigned_leb128): Declare.
1851
1852 2019-05-08  Tom Tromey  <tromey@adacore.com>
1853
1854         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1855         method.
1856
1857 2019-05-08  Tom Tromey  <tromey@adacore.com>
1858
1859         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1860         when no wrap column is set.
1861
1862 2019-05-08  Tom Tromey  <tromey@adacore.com>
1863
1864         * c-lang.c (c_get_string): Handle non-C-style arrays.
1865
1866 2019-05-08  Tom Tromey  <tromey@adacore.com>
1867
1868         * typeprint.c (print_offset_data::update): Print the bit offset,
1869         not the number of bits remaining.
1870
1871 2019-05-08  Tom Tromey  <tromey@adacore.com>
1872
1873         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1874         padding at end of comment.
1875
1876 2019-05-08  Tom Tromey  <tromey@adacore.com>
1877
1878         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1879         Compare main types.
1880
1881 2019-05-06  Tom Tromey  <tom@tromey.com>
1882
1883         * common/scoped_mmap.c: Include common-defs.h.
1884         * common/scoped_mmap.h: Don't include config.h.
1885
1886 2019-05-04  Tom Tromey  <tom@tromey.com>
1887
1888         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1889         (struct aarch64_call_info): Add initializers.
1890         <si>: Now a std::vector.
1891         (pass_on_stack, aarch64_push_dummy_call): Update.
1892
1893 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1894             Tom Tromey  <tom@tromey.com>
1895
1896         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1897         (ppc_threads): Now a std::vector.  Now static.
1898         (hwdebug_find_thread_points_by_tid)
1899         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1900         Update.
1901
1902 2019-05-04  Tom Tromey  <tom@tromey.com>
1903
1904         * arc-tdep.c (arc_tdesc_init): Return bool.
1905
1906 2019-05-04  Tom Tromey  <tom@tromey.com>
1907
1908         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1909         Use gdb_assert_not_reached.
1910
1911 2019-05-04  Tom Tromey  <tom@tromey.com>
1912
1913         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1914         "false".
1915
1916 2019-05-04  Tom Tromey  <tom@tromey.com>
1917
1918         * arc-tdep.c (arc_tdesc_init): Use bool.
1919
1920 2019-05-04  Tom Tromey  <tom@tromey.com>
1921
1922         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1923
1924 2019-05-04  Tom Tromey  <tom@tromey.com>
1925
1926         * cli/cli-cmds.c (valid_command_p): Return bool.
1927
1928 2019-05-04  Tom Tromey  <tom@tromey.com>
1929
1930         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1931         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1932
1933 2019-05-04  Raul Tambre  <raul@tambre.ee>
1934
1935         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1936         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1937         operator for comparison.
1938
1939 2019-05-04  Tom Tromey  <tom@tromey.com>
1940
1941         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1942         (lookup_partial_symbol, print_partial_symbols)
1943         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1944         (psymbol_compare): Update.
1945         (add_psymbol_to_bcache): Clear the entire psymbol.
1946         (maintenance_check_psymtabs): Update.
1947         * psympriv.h (struct partial_symbol): Don't derive from
1948         general_symbol_info.
1949         <obj_section, unrelocated_address, address,
1950         set_unrelocated_address>: Update.
1951         <ginfo>: New member.
1952         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1953         (debug_names::write_psymbols): Update.
1954
1955 2019-05-04  Tom de Vries  <tdevries@suse.de>
1956
1957         * contrib/cc-with-tweaks.sh: Support -n arg.
1958
1959 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1960
1961         * corelow.c (core_target::detach): Ensure frame cache and
1962         register caches are cleared.
1963         inferior.c (exit_inferior_1): Likewise.
1964
1965 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1966             Tom Tromey  <tom@tromey.com>
1967
1968         * dictionary.c (collate_pending_symbols_by_language): Remove
1969         "struct" from foreach.
1970         * symtab.c (lookup_global_symbol_from_objfile)
1971         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1972         foreach.
1973         * ser-tcp.c (net_open): Remove "struct" from foreach.
1974         * objfiles.c (objfile_relocate, objfile_rebase)
1975         (objfile_has_symbols): Remove "struct" from foreach.
1976         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1977         from foreach.
1978         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1979         foreach.
1980         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1981         "struct" from foreach.
1982         * ada-lang.c (create_excep_cond_exprs)
1983         (ada_exception_catchpoint_cond_string): Remove "struct" from
1984         foreach.
1985
1986 2019-05-03  Tom Tromey  <tromey@adacore.com>
1987
1988         * ada-exp.y (convert_char_literal): Check suffix of each
1989         enumerator.
1990
1991 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1992
1993         PR ada/21406:
1994         * ada-exp.y (yywrap): Don't define.
1995         * ada-lex.l (%option): Add noyywrap
1996         (yywrap): Remove.
1997
1998 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1999
2000         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2001         _WIN32_WINNT to the XP level, unless already defined to a higher
2002         level.
2003
2004         * unittests/parse-connection-spec-selftests.c:
2005         * ser-tcp.c:
2006         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2007         override.
2008
2009         * symfile.c (find_separate_debug_file): Remove colon from the
2010         drive spec of DOS/Windows file names of the target, so that the
2011         file name produced from DEBUGDIR and the target's directory will
2012         be valid on DOS/Windows systems.
2013
2014 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2015
2016         * rust-lang.c (val_print_struct): Handle printing structures
2017         containing strings.
2018
2019 2019-05-02  Tom Tromey  <tromey@adacore.com>
2020
2021         * valarith.c (_initialize_valarith): Remove.
2022
2023 2019-05-01  Tom Tromey  <tromey@adacore.com>
2024
2025         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2026         bitfields.
2027
2028 2019-05-01  Tom Tromey  <tromey@adacore.com>
2029
2030         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2031         for big-endian copies.
2032
2033 2019-04-30  Ali Tamur  <tamur@google.com>
2034         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2035         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2036         (read_3_bytes): New function.
2037
2038 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2039
2040         * windows-nat.c (main_thread_id): Delete.
2041         (handle_output_debug_string): Replace main_thread_id by
2042         current_event.dwThreadId.
2043         (fake_create_process): Likewise.
2044         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2045         Do not set main_thread_id.
2046         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2047         current_event.dwThreadId.
2048         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2049
2050 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2051
2052         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2053         Use current_event.dwThreadId instead of main_thread_id.
2054
2055 2019-04-30  Tom Tromey  <tromey@adacore.com>
2056
2057         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2058         (create_excep_cond_exprs): Iterate over program spaces.
2059         (ada_exception_catchpoint_cond_string): Examine all minimal
2060         symbols for exception types.
2061
2062 2019-04-30  Tom Tromey  <tromey@adacore.com>
2063
2064         PR c++/24470:
2065         * dwarf2read.c (process_structure_scope): Handle case where type
2066         has template parameters but no symbol was created.
2067
2068 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2069             Chris January  <chris.january@arm.com>
2070
2071         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2072         qualifier.
2073         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2074
2075 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2076
2077         * f-typeprint.c (f_print_type): Update rules for printing
2078         whitespace.
2079         (f_type_print_varspec_suffix): Likewise.
2080
2081 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2082             Chris January  <chris.january@arm.com>
2083
2084         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2085         function arguments.
2086
2087 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * f-lang.c (build_fortran_types): Change name of void type to
2090         lower case.
2091         * f-typeprint.c (f_type_print_base): Print the name of the void
2092         type, rather than a fixed string.
2093         * f-valprint.c (f_decorations): Use lower case void string.
2094
2095 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2096             Chris January  <chris.january@arm.com>
2097
2098         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2099         types for Fortran.
2100
2101 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2102             Chris January  <chris.january@arm.com>
2103             David Lecomber  <david.lecomber@arm.com>
2104
2105         * f-exp.y (BINOP_INTRINSIC): New token.
2106         (exp): New parser rule handling BINOP_INTRINSIC.
2107         (f77_keywords): Add new builtin procedures.
2108         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2109         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2110         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2111         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2112         (print_unop_subexp_f): New function.
2113         (print_binop_subexp_f): New function.
2114         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2115         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2116         (dump_subexp_body_f): Likewise.
2117         (operator_check_f): Likewise.
2118         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2119         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2120
2121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2122
2123         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2124         UNOP_KIND.
2125         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2126         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2127         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2128         (operator_length_f): New fuction.
2129         (print_subexp_f): New function.
2130         (op_name_f): New function.
2131         (dump_subexp_body_f): New function.
2132         (operator_check_f): New function.
2133         (exp_descriptor_f): Replace standard expression handling functions
2134         with new functions.
2135         * gdb/fortran-operator.def: New file.
2136         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2137         * gdb/std-operator.def: Remove UNOP_KIND.
2138
2139 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * std-operator.def: Remove unbalanced, stray double quote
2142         character.
2143
2144 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2145             Chris January  <chris.january@arm.com>
2146             Daniel Everett  <daniel.everett@arm.com>
2147             Nick Forrington  <nick.forrington@arm.com>
2148             Richard Bunt  <richard.bunt@arm.com>
2149
2150         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2151         of depth when printing anonymous structs or unions.
2152         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2153         Don't print either the top-level value, or the children if the
2154         max-depth is exceeded.
2155         (ppscm_print_children): When printing the key of a map, allow one
2156         extra level of depth.
2157         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2158         print either the top-level value, or the children if the max-depth
2159         is exceeded.
2160         (print_children): When printing the key of a map, allow one extra
2161         level of depth.
2162         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2163         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2164         (user_print_options): Initialise max_depth field.
2165         (val_print_scalar_or_string_type_p): New function.
2166         (val_print): Check to see if the max depth has been reached.
2167         (val_print_check_max_depth): Define new function.
2168         (show_print_max_depth): New function.
2169         (_initialize_valprint): Add 'print max-depth' option.
2170         * valprint.h (struct value_print_options) <max_depth>: New field.
2171         (val_print_check_max_depth): Declare new function.
2172         * NEWS: Document new feature.
2173
2174 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2175
2176         * ada-lang.c (ada_language_defn): Initialise new field.
2177         * c-lang.c (c_is_string_type_p): New function.
2178         (c_language_defn): Initialise new field.
2179         (cplus_language_defn): Initialise new field.
2180         (asm_language_defn): Initialise new field.
2181         (minimal_language_defn): Initialise new field.
2182         * c-lang.h (c_is_string_type_p): Declare new function.
2183         * d-lang.c (d_language_defn): Initialise new field.
2184         * f-lang.c (f_is_string_type_p): New function.
2185         (f_language_defn): Initialise new field.
2186         * go-lang.c (go_is_string_type_p): New function.
2187         (go_language_defn): Initialise new field.
2188         * language.c (default_is_string_type_p): New function.
2189         (unknown_language_defn): Initialise new field.
2190         (auto_language_defn): Initialise new field.
2191         * language.h (struct language_defn) <la_is_string_type_p>: New
2192         member variable.
2193         (default_is_string_type_p): Declare new function.
2194         * m2-lang.c (m2_language_defn): Initialise new field.
2195         * objc-lang.c (objc_language_defn): Initialise new field.
2196         * opencl-lang.c (opencl_language_defn): Initialise new field.
2197         * p-lang.c (pascal_is_string_type_p): New function.
2198         (pascal_language_defn): Initialise new field.
2199         * rust-lang.c (rust_is_string_type_p): New function.
2200         (rust_language_defn): Initialise new field.
2201
2202 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2205         New field.
2206         * ada-lang.c (ada_language_defn): Initialise new field.
2207         * c-lang.c (c_language_defn): Likewise.
2208         (cplus_language_defn): Likewise.
2209         (asm_language_defn): Likewise.
2210         (minimal_language_defn): Likewise.
2211         * d-lang.c (d_language_defn): Likewise.
2212         * f-lang.c (f_language_defn): Likewise.
2213         * go-lang.c (go_language_defn): Likewise.
2214         * language.c (unknown_language_defn): Likewise.
2215         (auto_language_defn): Likewise.
2216         * m2-lang.c (m2_language_defn): Likewise.
2217         * objc-lang.c (objc_language_defn): Likewise.
2218         * opencl-lang.c (opencl_language_defn): Likewise.
2219         * p-lang.c (pascal_language_defn): Likewise.
2220         * rust-lang.c (rust_language_defn): Likewise.
2221
2222 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         * ada-lang.c (ada_is_character_type): Change return type to bool.
2225         (ada_is_string_type): Likewise.
2226         * ada-lang.h (ada_is_character_type): Update declaration
2227         (ada_is_string_type): Likewise.
2228
2229 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2230
2231         Support style in 'frame|thread apply'
2232
2233         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2234         * record.c (record_start, record_stop): Update callers of
2235         execute_command_to_string with false.
2236         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2237         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2238         methods.
2239         (class string_file): New constructor with term_out parameter.
2240         Override methods term_out and can_emit_style_escape.  New member
2241         term_out.
2242         (class stdio_file): Override can_emit_style_escape.
2243         (class tee_file): Override term_out and can_emit_style_escape.
2244         * utils.h (can_emit_style_escape): Remove.
2245         * utils.c (can_emit_style_escape): Likewise.
2246         Update all callers of can_emit_style_escape (SOMESTREAM) to
2247         SOMESTREAM->can_emit_style_escape.
2248         * source-cache.c (source_cache::get_source_lines): Likewise.
2249         * stack.c (frame_apply_command_count): Call execute_command_to_string
2250         passing the term_out characteristic of the current gdb_stdout.
2251         * thread.c (thr_try_catch_cmd): Likewise.
2252         * top.c (execute_command_to_string): pass term_out parameter
2253         to construct the string_file for the command output.
2254         * ui-file.c (term_cli_styling): New function (most code moved
2255         from utils.c can_emit_style_escape).
2256         (string_file::string_file, string_file::can_emit_style_escape,
2257         stdio_file::can_emit_style_escape, tee_file::term_out,
2258         tee_file::can_emit_style_escape): New functions.
2259
2260 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2261
2262         * NEWS: Mention the new set|show may-call-functions.
2263         * infcall.c (may_call_functions_p): New variable.
2264         (show_may_call_functions_p): New function.
2265         (call_function_by_hand_dummy): Throws an error if not
2266         may-call-functions.
2267         (_initialize_infcall): Call add_setshow_boolean_cmd for
2268         may-call-functions.
2269
2270 2019-04-25  Keith Seitz  <keiths@redhat.com>
2271
2272         PR c++/24367
2273         * cp-support.c (inspect_type): Don't attempt substitutions
2274         of symbol with the same name.
2275
2276 2019-04-25  Tom Tromey  <tromey@adacore.com>
2277
2278         PR gdb/24475:
2279         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2280         static.
2281
2282 2019-04-25  Tom Tromey  <tromey@adacore.com>
2283
2284         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2285         rvalue reference.
2286         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2287         (gdb_xml_parser::parse): Use std::move.
2288         * python/python-internal.h (gdbpy_convert_exception): Take a const
2289         reference.
2290         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2291         std::move.
2292         * python/py-utils.c (gdbpy_convert_exception): Take a const
2293         reference.
2294         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2295         Use std::move.
2296         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2297         Use std::move.
2298         * mi/mi-main.c (mi_print_exception): Take a const reference.
2299         * main.c (handle_command_errors): Take a const reference.
2300         * linespec.c (parse_linespec): Use std::move.
2301         * infcall.c (run_inferior_call): Use std::move.
2302         (call_function_by_hand_dummy): Use std::move.
2303         * exec.c (try_open_exec_file): Use std::move.
2304         * exceptions.h (exception_print, exception_fprintf)
2305         (exception_print_same): Update.
2306         * exceptions.c (print_exception, exception_print)
2307         (exception_fprintf, exception_print_same): Change parameters to
2308         const reference.
2309         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2310         * common/new-op.c: Use std::move.
2311         * common/common-exceptions.h (struct gdb_exception): Add move
2312         constructor.
2313         (struct gdb_exception_error, struct gdb_exception_quit, struct
2314         gdb_quit_bad_alloc): Change constructor to move constructor.
2315         (throw_exception): Change parameter to rvalue reference.
2316         * common/common-exceptions.c (throw_exception): Take rvalue
2317         reference.
2318         * cli/cli-interp.c (safe_execute_command): Use std::move.
2319         * breakpoint.c (insert_bp_location, location_to_sals): Use
2320         std::move.
2321
2322 2019-04-25  Tom Tromey  <tromey@adacore.com>
2323
2324         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2325         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2326         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2327         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2328         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2329         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2330         guile/scm-value.c: Use unpack.
2331         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2332         gdbscm_gdb_exception.
2333         (gdbscm_throw_gdb_exception): Likewise.
2334         (struct gdbscm_gdb_exception): New.
2335         (unpack): New function.
2336         (gdbscm_wrap): Use unpack.
2337
2338 2019-04-25  Tom Tromey  <tromey@adacore.com>
2339
2340         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2341         (gdb_rl_callback_handler): Use std::move.
2342         * common/common-exceptions.h (struct gdb_exception): Add move
2343         assignment operator.
2344         (throw_exception_sjlj): Change "exception" to const reference.
2345         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2346         (throw_exception_sjlj): Change "exception" to const reference.
2347
2348 2019-04-25  Tom Tromey  <tromey@adacore.com>
2349
2350         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2351         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2352         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2353         Update.
2354         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2355         Update.
2356         * mi/mi-interp.c (mi_interp::exec): Update.
2357         * linespec.c (parse_linespec): Update.
2358         * infcall.c (run_inferior_call): Update.
2359         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2360         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2361         (gdbscm_lookup_global_symbol): Update.
2362         * guile/scm-param.c (gdbscm_parameter_value): Update.
2363         * guile/scm-frame.c (gdbscm_frame_read_register)
2364         (gdbscm_frame_read_var): Update.
2365         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2366         * exec.c (try_open_exec_file): Update.
2367         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2368         (gdb_rl_callback_handler): Update.
2369         * common/common-exceptions.h (exception_none): Don't declare.
2370         * common/common-exceptions.c (exception_none): Don't define.
2371         (struct catcher) <exception>: Update.
2372         * cli/cli-interp.c (safe_execute_command): Update.
2373         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2374
2375 2019-04-25  Ali Tamur  <tamur@google.com>
2376
2377         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2378         (read_attribute_value): Likewise.
2379         (dwarf2_read_addr_index): Update comment.
2380         (read_str_index): Add DW_FORM_strx.
2381         (dwarf2_string_attr): Likewise.
2382         (dwarf2_const_value_attr): Likewise.
2383         (dump_die_shallow): Likewise.
2384         (dwarf2_fetch_constant_bytes): Likewise.
2385         (skip_form_bytes): Likewise.
2386         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2387
2388 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2389
2390         PR corefiles/11608
2391         PR corefiles/18187
2392         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2393         OFFSET.  Verify if current mapping contains an ELF header.
2394         (linux_find_memory_regions_full): Adjust call to
2395         dump_mapping_p.
2396
2397 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2398             Kang Li <kanglictf@gmail.com>
2399
2400         PR gdb/21600
2401
2402         * dwarf2-frame.c (read_initial_length): Be consistent about using
2403         unsigned representation of length.
2404         (decode_frame_entry_1): Likewise.  Check for wraparound of
2405         end pointer as well as buffer overflow.
2406
2407 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2408
2409         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2410         "vq".
2411
2412 2019-04-24  Tom Tromey  <tromey@adacore.com>
2413
2414         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2415
2416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * s12z-tdep.c (s12z_unwind_pc): Delete.
2419         (s12z_unwind_sp): Delete.
2420         (s12z_gdbarch_init): Don't register deleted functions with
2421         gdbarch.
2422
2423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * rl78-tdep.c (rl78_unwind_sp): Delete.
2426         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2427
2428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2429
2430         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2431         (xstormy16_unwind_pc): Delete.
2432         (xstormy16_dummy_id): Delete.
2433         (xstormy16_gdbarch_init): Don't register deleted functions with
2434         gdbarch.
2435
2436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2437
2438         * vax-tdep.c (vax_unwind_pc): Delete.
2439         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2440
2441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * v850-tdep.c (v850_unwind_sp): Delete.
2444         (v850_unwind_pc): Delete.
2445         (v850_dummy_id): Delete.
2446         (v850_gdbarch_init): Don't register deleted functions with
2447         gdbarch.
2448
2449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2450
2451         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2452         (tilegx_unwind_pc): Delete.
2453         (tilegx_unwind_dummy_id): Delete.
2454         (tilegx_gdbarch_init): Don't register deleted functions with
2455         gdbarch.
2456
2457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2460         (tic6x_dummy_id): Delete.
2461         (tic6x_gdbarch_init): Don't register deleted functions with
2462         gdbarch.
2463
2464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2465
2466         * sparc-tdep.c (sparc_unwind_pc): Delete.
2467         (sparc32_gdbarch_init): Don't register deleted function with
2468         gdbarch.
2469
2470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2471
2472         * sh-tdep.c (sh_unwind_sp): Delete.
2473         (sh_unwind_pc): Delete.
2474         (sh_dummy_id): Delete.
2475         (sh_gdbarch_init): Don't register deleted functions with
2476         gdbarch.
2477
2478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2479
2480         * score-tdep.c (score_unwind_sp): Delete.
2481         (score_unwind_pc): Delete.
2482         (score_dummy_id): Delete.
2483         (score_gdbarch_init): Don't register deleted functions with
2484         gdbarch.
2485
2486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * rx-tdep.c (rx_unwind_pc): Delete.
2489         (rx_unwind_sp): Delete.
2490         (rx_dummy_id): Delete.
2491         (rx_gdbarch_init): Don't register deleted functions with
2492         gdbarch.  Update comment.
2493
2494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2497         (rs6000_dummy_id): Delete.
2498         (rs6000_gdbarch_init): Don't register deleted functions with
2499         gdbarch.
2500
2501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2502
2503         * or1k-tdep.c (or1k_dummy_id): Delete.
2504         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2505
2506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2507
2508         * nios2-tdep.c (nios2_dummy_id): Delete.
2509         (nios2_unwind_sp): Delete.
2510         (nios2_gdbarch_init): Don't register deleted functions with
2511         gdbarch.
2512
2513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * nds32-tdep.c (nds32_dummy_id): Delete.
2516         (nds32_unwind_pc): Delete.
2517         (nds32_unwind_sp): Delete.
2518         (nds32_gdbarch_init): Don't register deleted functions with
2519         gdbarch.
2520
2521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * msp430-tdep.c (msp430_unwind_pc): Delete.
2524         (msp430_unwind_sp): Delete.
2525         (msp430_dummy_id): Delete.
2526         (msp430_gdbarch_init): Don't register deleted functions with
2527         gdbarch.
2528
2529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * moxie-tdep.c (moxie_unwind_sp): Delete.
2532         (moxie_unwind_pc): Delete.
2533         (moxie_dummy_id): Delete.
2534         (moxie_gdbarch_init): Don't register deleted functions with
2535         gdbarch.
2536
2537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2540         (mn10300_unwind_pc): Delete.
2541         (mn10300_unwind_sp): Delete.
2542         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2543         mn10300_unwind_sp.
2544         (mn10300_frame_unwind_init): Don't register deleted functions with
2545         gdbarch.
2546
2547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2548
2549         * mep-tdep.c (mep_unwind_pc): Delete.
2550         (mep_unwind_sp): Delete.
2551         (mep_dummy_id): Delete.
2552         (mep_gdbarch_init): Don't register deleted functions with
2553         gdbarch.
2554
2555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2556
2557         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2558         (m68hc11_unwind_sp): Delete.
2559         (m68hc11_gdbarch_init): Don't register deleted functions with
2560         gdbarch.
2561
2562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * m32r-tdep.c (m32r_unwind_sp): Delete.
2565         (m32r_unwind_pc): Delete.
2566         (m32r_dummy_id): Delete.
2567         (m32r_gdbarch_init): Don't register deleted functions with
2568         gdbarch.
2569
2570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * m32c-tdep.c (m32c_unwind_pc): Delete.
2573         (m32c_unwind_sp): Delete.
2574         (m32c_dummy_id): Delete.
2575         (m32c_gdbarch_init): Don't register deleted functions with
2576         gdbarch.
2577
2578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2581         (lm32_unwind_pc): Delete.
2582         (lm32_dummy_id): Delete.
2583         (lm32_gdbarch_init): Don't register deleted functions with
2584         gdbarch.
2585
2586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2589         (iq2000_unwind_pc): Delete.
2590         (iq2000_dummy_id): Delete.
2591         (iq2000_gdbarch_init): Don't register deleted functions with
2592         gdbarch.
2593
2594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2595
2596         * nds32-tdep.c (nds32_type_align): Delete.
2597         (nds32_push_dummy_call): Use type_align instead.
2598
2599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * arm-tdep.c (arm_type_align): Only handle vector override case.
2602         (arm_push_dummy_call): Use type_align.
2603         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2604
2605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2608         case.
2609         (pass_on_stack): Use type_align.
2610         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2611         function.
2612
2613 2019-04-23  Tom Tromey  <tromey@adacore.com>
2614
2615         * dwarf2read.c (line_header::file_name_at): Remove unused
2616         overload.
2617
2618 2019-04-23  Tom de Vries  <tdevries@suse.de>
2619
2620         PR gdb/24438
2621         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2622         invocation.
2623
2624
2625 2019-03-27  Ali Tamur  <tamur@google.com>
2626
2627         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2628         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2629         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2630         (dwarf_expr_context::get_addr_index): Likewise
2631         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2632         (symbol_needs_eval_context::get_addr_index): Likewise
2633         (disassemble_dwarf_expression): Add DW_OP_addrx
2634         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2635         (read_cutu_die_from_dwo): Update comment
2636         (skip_one_die): Add DW_FORM_addrx
2637         (read_attribute_value): Likewise
2638         (var_decode_location): Add DW_OP_addrx
2639         (dwarf2_const_value_attr): Add DW_FORM_addrx
2640         (dump_die_shallow): Likewise
2641         (dwarf2_fetch_constant_bytes): Likewise
2642         (decode_locdesc): Add DW_OP_addrx
2643         (skip_form_bytes): Add DW_FORM_addrx
2644
2645 2019-04-22  Ali Tamur  <tamur@google.com>
2646
2647         * MAINTAINERS (Write After Approval): Add self.
2648
2649 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2650
2651         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2652         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2653         (open_symbol_file_object): Likewise.
2654         (svr4_default_sos): Add info parameter.
2655         (svr4_read_so_list): Likewise.
2656         (svr4_current_sos_direct): Adjust functions calls to pass down
2657         info.
2658         (svr4_current_sos_1): Add info parameter.
2659         (svr4_current_sos): Call get_svr4_info, pass info down to
2660         svr4_current_sos_1.
2661         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2662         get_svr4_info.
2663         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2664         get_svr4_info.
2665         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2666         to get_svr4_info.
2667         (probes_table_remove_objfile_probes): Likewise.
2668         (register_solib_event_probe): Add info parameter.
2669         (solist_update_incremental): Pass info parameter down to
2670         svr4_read_so_list.
2671         (disable_probes_interface): Add info parameter.
2672         (svr4_handle_solib_event): Pass current_program_space to
2673         get_svr4_info.  Adjust disable_probes_interface cleanup.
2674         (svr4_create_probe_breakpoints): Add info parameter, pass it
2675         down to register_solib_event_probe.
2676         (svr4_create_solib_event_breakpoints): Add info parameter,
2677         pass it down to svr4_create_probe_breakpoints.
2678         (enable_break): Pass info down to
2679         svr4_create_solib_event_breakpoints.
2680         (svr4_solib_create_inferior_hook): Pass current_program_space to
2681         get_svr4_info.
2682         (svr4_clear_solib): Likewise.
2683
2684 2019-04-22  Pedro Alves  <palves@redhat.com>
2685
2686         * solib-svr4.c (svr4_free_objfile_observer): New.
2687         (probe_and_action::objfile): New field.
2688         (probes_table_htab_remove_objfile_probes)
2689         (probes_table_remove_objfile_probes): New functions.
2690         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2691         in the new probe_and_action.  Don't store the probe in 'lookup'.
2692         (svr4_create_probe_breakpoints): Pass objfile to
2693         register_solib_event_probe.
2694         (_initialize_svr4_solib): Register a free_objfile observer.
2695
2696 2019-04-19  Tom Tromey  <tom@tromey.com>
2697
2698         * common/queue.h: Remove.
2699
2700 2019-04-19  Tom Tromey  <tom@tromey.com>
2701
2702         * event-loop.c: Don't include "common/queue.h".
2703
2704 2019-04-19  Tom Tromey  <tom@tromey.com>
2705
2706         * remote.c (remote_target): Use delete.
2707         * remote-notif.h: Include <list>, not "common/queue.h".
2708         (notif_client_p): Remove typedef.
2709         (remote_notif_state): Add constructor, destructor, initializer.
2710         <notif_queue>: Now a std::list.
2711         (remote_notif_state_xfree): Don't declare.
2712         * remote-notif.c (remote_notif_process, handle_notification)
2713         (remote_notif_state_allocate): Update.
2714         (~remote_notif_state): Rename from remote_notif_state_xfree.
2715
2716 2019-04-19  Tom Tromey  <tom@tromey.com>
2717
2718         * symfile.c (reread_symbols): Update.
2719         * objfiles.c (objfile_register_static_link)
2720         (objfile_lookup_static_link): Update
2721         (~objfile) Don't delete static_links.
2722         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2723
2724 2019-04-19  Tom Tromey  <tom@tromey.com>
2725
2726         * type-stack.h (struct type_stack) <insert>: Constify string.
2727         * type-stack.c (type_stack::insert): Constify string.
2728         * gdbtypes.h (lookup_template_type): Update.
2729         (address_space_name_to_int): Update.
2730         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2731         const.
2732         (lookup_template_type): Make name const.
2733         * c-exp.y: Update rules.
2734         (lex_one_token, classify_name, classify_inner_name)
2735         (c_print_token): Update.
2736         * p-exp.y: Update rules.
2737         (yylex): Update.
2738         * f-exp.y: Update rules.
2739         (yylex): Update.
2740         * d-exp.y: Update rules.
2741         (lex_one_token, classify_name, classify_inner_name): Update.
2742         * parse.c (write_dollar_variable, copy_name): Return std::string.
2743         * parser-defs.h (copy_name): Change return type.
2744         * m2-exp.y: Update rules.
2745         (yylex): Update.
2746         * go-exp.y (lex_one_token): Update.
2747         Update rules.
2748         (classify_unsafe_function, classify_packaged_name)
2749         (classify_name, yylex): Update.
2750
2751 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2752
2753         * configure.ac: add --enable-source-highlight switch.
2754         * configure: Regenerate.
2755         * top.c (print_gdb_version): plumb --enable-source-highlight
2756         status to "show configuration".
2757
2758 2019-04-19  Tom Tromey  <tromey@adacore.com>
2759
2760         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2761         Check ADA_TYPE_P.
2762         (empty_record, ada_template_to_fixed_record_type_1)
2763         (template_to_static_fixed_type)
2764         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2765         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2766         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2767         macros.
2768
2769 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2770
2771         PR symtab/24423:
2772         * source.c (print_source_lines_base): Advance "iter" when a
2773         control character is seen.
2774
2775 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2776
2777         * inferior.h (struct infcall_suspend_state_deleter):
2778         Catch exception in destructor to avoid crash.
2779
2780 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2781
2782         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2783         close to the add_com "shell".
2784
2785 2019-04-18  Tom Tromey  <tromey@adacore.com>
2786
2787         * process-stratum-target.h (class process_stratum_target)
2788         <stratum>: Add "final".
2789
2790 2019-04-17  Tom Tromey  <tromey@adacore.com>
2791
2792         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2793         against nullptr before use.
2794
2795 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2796
2797         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2798
2799 2019-04-17  Jim Wilson  <jimw@sifive.com>
2800             Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2803         code read might fail, assume 4-byte breakpoint in that case.
2804
2805 2019-04-15  Leszek Swirski  <leszeks@google.com>
2806
2807         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2808         rather than a hand-rolled POD check when checking for forced MEMORY
2809         classification.
2810
2811 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2812
2813         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2814         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2815         function.
2816         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2817         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2818         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2819         declaration.
2820
2821 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2822
2823         * aarch64-linux-nat.c
2824         (aarch64_linux_nat_target::thread_architecture): Add override.
2825         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2826         each VQ.
2827
2828 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2829
2830         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2831
2832 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2835         target types of size 96-bits, add some additional comments, and
2836         check that the builtin type we found was the correct size.
2837
2838 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2839
2840         * utils.c (prompt_for_continue): Don't restore the styling at the
2841         end, as applied_style has the wrong value.  This fixes styling in
2842         long lists of file names that are interrupted by the "Continue?"
2843         prompt.
2844
2845 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2846
2847         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2848         * c-lang.c (c_language_defn): Likewise.
2849         (cplus_language_defn): Likewise.
2850         (asm_language_defn): Likewise.
2851         (minimal_language_defn): Likewise.
2852         * d-lang.c (d_language_defn): Likewise.
2853         * f-lang.c (f_language_defn): Likewise.
2854         * go-lang.c (go_language_defn): Likewise.
2855         * language.c (unknown_language_defn): Likewise.
2856         (auto_language_defn): Likewise.
2857         * language.h (struct language_defn): Remove la_magic field.
2858         (LANG_MAGIC): Delete.
2859         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2860         * objc-lang.c (objc_language_defn): Likewise.
2861         * opencl-lang.c (opencl_language_defn): Likewise.
2862         * p-lang.c (pascal_language_defn): Likewise.
2863         * rust-lang.c (rust_language_defn): Likewise.
2864
2865 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * riscv-tdep.c (riscv_type_align): New function.
2868         (riscv_type_alignment): Delete.
2869         (riscv_arg_location): Use 'type_align'.
2870         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2871
2872 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2873
2874         * gdbtypes.c (type_align): A struct with no non-static fields also
2875         has alignment of 1.
2876
2877 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2880         component to 0.
2881         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2882         member.
2883         (riscv_struct_info::analyse): New implementation using new
2884         analyse_inner member function.
2885         (riscv_struct_info::field_offset): New member function.
2886         (riscv_struct_info::m_offsets): New member variable.
2887         (riscv_struct_info::analyse_inner): New private member function,
2888         takes the old implementation of riscv_struct_info::analyse but
2889         extended to track field offsets.
2890         (riscv_call_arg_struct): Update the struct folding special cases
2891         to handle cases where empty C++ structs, which are non-zero
2892         length, are found.
2893         (riscv_arg_location): Initialise the length of each location, a
2894         non-zero length now indicates the location is in use.
2895         (riscv_push_dummy_call): Allow for the first location having a
2896         non-zero offset when setting up arguments.
2897         (riscv_return_value): Likewise, but for return values.
2898
2899 2019-04-11  Tom Tromey  <tromey@adacore.com>
2900
2901         * utils.c (internal_vproblem): Make "msg" const.
2902
2903 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2904
2905         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2906         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2907         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2908         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2909
2910 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2911
2912         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2913         function.
2914         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2915         of amd64_collect_native_gregset.
2916         (amd64_linux_nat_target::store_registers): Likewise.
2917
2918 2019-04-10  Tom Tromey  <tom@tromey.com>
2919
2920         * symtab.c (lookup_global_symbol_from_objfile)
2921         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2922         * objfiles.h (class separate_debug_iterator): New.
2923         (class separate_debug_range): New.
2924         (struct objfile) <separate_debug_objfiles>: New method.
2925         (objfile_separate_debug_iterate): Don't declare.
2926         * objfiles.c (separate_debug_iterator::operator++): Rename from
2927         objfile_separate_debug_iterate.
2928         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2929         iterator.
2930         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2931         iterator.
2932
2933 2019-04-10  Tom Tromey  <tom@tromey.com>
2934
2935         * symfile.c (reread_symbols): Remove old comment.
2936         * objfiles.c (free_all_objfiles): Fix a typo.
2937
2938 2019-04-10  Tom Tromey  <tom@tromey.com>
2939
2940         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2941         * minsyms.c (lookup_minimal_symbol): Use foreach.
2942         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2943         (lookup_minimal_symbol_solib_trampoline): Likewise.
2944         * symfile.c (reread_symbols): Use foreach.
2945
2946 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2947             Tom Tromey  <tromey@adacore.com>
2948
2949         PR rust/24414:
2950         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2951         (rust_lex_int_test): Change "value" to be LONGEST.
2952         (rust_lex_tests): Add test for long integer literal.
2953
2954 2019-04-09  Tom Tromey  <tromey@adacore.com>
2955
2956         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2957         to bool.
2958         (extended_remote_target::attach): Update.
2959         (remote_target::remote_notice_new_inferior): Update.
2960         (remote_target::add_current_inferior_and_thread): Update.
2961         * inferior.c (exit_inferior_1): Use "false".
2962         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2963
2964 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2965
2966         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2967         the "start" command.
2968
2969 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2970
2971         * python/py-inferior.c (infpy_thread_from_thread_handle):
2972         Adjust comments to reflect renaming of thread_from_thread_handle
2973         to thread_from_handle.  Adjust keywords.  Fix type error message.
2974         (inferior_object_methods): Add thread_from_handle.  Retain
2975         thread_from_thread_handle, but mark it as deprecated.
2976
2977 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2978
2979         * gdbthread.h (find_thread_by_handle): Revise declaration.
2980         * thread.c (find_thread_by_handle): Likewise.  Adjust
2981         implementation too.
2982         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2983         support for buffer objects as handles.
2984
2985 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2986
2987         * python/py-infthread.c (thpy_thread_handle): New function.
2988         (thread_object_methods): Register thpy_thread_handle.
2989
2990 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2991
2992         * gdbthread.h (thread_to_thread_handle): Declare.
2993         * thread.c (gdbtypes.h): Include.
2994         (thread_to_thread_handle): New function.
2995
2996         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2997         (target_thread_info_to_thread_handle): Declare.
2998         * target.c (target_thread_info_to_thread_handle): New function.
2999         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3000         * target-delegates.c: Regenerate.
3001
3002         * linux-thread-db.c (class thread_db_target): Add method
3003         thread_info_to_thread_handle.
3004         (thread_db_target::thread_info_to_thread_handle): Define.
3005         * remote.c (class remote_target): Add new method
3006         thread_info_to_thread_handle.
3007         (remote_target::thread_info_to_thread_handle): Define.
3008
3009 2019-04-08  Pedro Alves  <palves@redhat.com>
3010
3011         * common/common-exceptions.c (throw_exception): Don't create
3012         named object to throw; throw directly.
3013         (throw_it): Likewise.  Don't initialize gdb_exception::message
3014         here, with new; pass FMT and AP to the ctor instead.
3015         * common/common-exceptions.h: Include <string>.
3016         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3017         const char *, va_list)): New ctor.  Use std::make_shared.
3018         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3019         errors)): Delete.
3020         (gdb_exception_error::gdb_exception_error(enum errors, const char
3021         *, va_list)): New.
3022         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3023         Add assertion.
3024         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3025         errors)): Delete.
3026         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3027         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3028         Add assertion.
3029
3030 2019-04-08  Tom Tromey  <tom@tromey.com>
3031
3032         * valops.c (value_rtti_indirect_type): Replace throw_exception
3033         with throw.
3034         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3035         with throw.
3036         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3037         throw.
3038         * target.c (target_translate_tls_address): Replace throw_exception
3039         with throw.
3040         * stack.c (frame_apply_command_count): Replace throw_exception
3041         with throw.
3042         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3043         throw.
3044         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3045         with throw.
3046         * rs6000-tdep.c (rs6000_frame_cache)
3047         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3048         * remote.c: Replace throw_exception with throw.
3049         * record-full.c (record_full_message, record_full_wait_1)
3050         (record_full_restore): Replace throw_exception with throw.
3051         * record-btrace.c:
3052         (get_thread_current_frame_id, record_btrace_start_replaying)
3053         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3054         (cmd_record_btrace_start): Replace throw_exception with throw.
3055         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3056         throw.
3057         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3058         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3059         * linespec.c:
3060         (find_linespec_symbols): Replace throw_exception with throw.
3061         * infrun.c (displaced_step_prepare, resume): Replace
3062         throw_exception with throw.
3063         * infcmd.c (post_create_inferior): Replace throw_exception with
3064         throw.
3065         * inf-loop.c (inferior_event_handler): Replace throw_exception
3066         with throw.
3067         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3068         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3069         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3070         (get_prev_frame_always, get_frame_pc_if_available)
3071         (get_frame_address_in_block_if_available, get_frame_language):
3072         Replace throw_exception with throw.
3073         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3074         throw_exception with throw.
3075         * eval.c (fetch_subexp_value, evaluate_var_value)
3076         (evaluate_funcall, evaluate_subexp_standard): Replace
3077         throw_exception with throw.
3078         * dwarf2loc.c (call_site_find_chain)
3079         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3080         Replace throw_exception with throw.
3081         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3082         with throw.
3083         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3084         throw.
3085         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3086         * completer.c (complete_line_internal): Replace throw_exception
3087         with throw.
3088         * compile/compile-object-run.c (compile_object_run): Replace
3089         throw_exception with throw.
3090         * cli/cli-script.c (process_next_line): Replace throw_exception
3091         with throw.
3092         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3093         (btrace_enable, btrace_maint_update_pt_packets): Replace
3094         throw_exception with throw.
3095         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3096         throw_exception with throw.
3097         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3098         throw_exception with throw.
3099         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3100         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3101         * aarch64-tdep.c (aarch64_make_prologue_cache)
3102         (aarch64_make_stub_cache): Replace throw_exception with throw.
3103
3104 2019-04-08  Tom Tromey  <tom@tromey.com>
3105
3106         * common/common-exceptions.c (throw_exception): Rename from
3107         throw_exception_cxx.  Remove old copy.  Make argument const.
3108         (throw_it): Create and throw exception objects directly.
3109         * common/common-exceptions.h (throw_exception): Make argument
3110         const.
3111         (struct gdb_exception_error): Add constructor.
3112         (struct gdb_exception_quit): Add constructor.
3113
3114 2019-04-08  Tom Tromey  <tom@tromey.com>
3115
3116         * common/common-exceptions.h (exception_rethrow): Don't declare.
3117         (TRY_SJLJ): Update comment.
3118         (TRY, CATCH, END_CATCH): Remove.
3119         * common/common-exceptions.c (exception_rethrow): Remove.
3120
3121 2019-04-08  Tom Tromey  <tom@tromey.com>
3122
3123         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3124         Remove.
3125         (gdb_exception_error): Rename from
3126         gdb_exception_RETURN_MASK_ERROR.
3127         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3128         (gdb_quit_bad_alloc): Update.
3129         * aarch64-tdep.c: Update.
3130         * ada-lang.c: Update.
3131         * ada-typeprint.c: Update.
3132         * ada-valprint.c: Update.
3133         * amd64-tdep.c: Update.
3134         * arch-utils.c: Update.
3135         * break-catch-throw.c: Update.
3136         * breakpoint.c: Update.
3137         * btrace.c: Update.
3138         * c-varobj.c: Update.
3139         * cli/cli-cmds.c: Update.
3140         * cli/cli-interp.c: Update.
3141         * cli/cli-script.c: Update.
3142         * common/common-exceptions.c: Update.
3143         * common/new-op.c: Update.
3144         * common/selftest.c: Update.
3145         * compile/compile-c-symbols.c: Update.
3146         * compile/compile-cplus-symbols.c: Update.
3147         * compile/compile-object-load.c: Update.
3148         * compile/compile-object-run.c: Update.
3149         * completer.c: Update.
3150         * corelow.c: Update.
3151         * cp-abi.c: Update.
3152         * cp-support.c: Update.
3153         * cp-valprint.c: Update.
3154         * darwin-nat.c: Update.
3155         * disasm-selftests.c: Update.
3156         * dtrace-probe.c: Update.
3157         * dwarf-index-cache.c: Update.
3158         * dwarf-index-write.c: Update.
3159         * dwarf2-frame-tailcall.c: Update.
3160         * dwarf2-frame.c: Update.
3161         * dwarf2loc.c: Update.
3162         * dwarf2read.c: Update.
3163         * eval.c: Update.
3164         * event-loop.c: Update.
3165         * event-top.c: Update.
3166         * exec.c: Update.
3167         * f-valprint.c: Update.
3168         * fbsd-tdep.c: Update.
3169         * frame-unwind.c: Update.
3170         * frame.c: Update.
3171         * gdbtypes.c: Update.
3172         * gnu-v3-abi.c: Update.
3173         * guile/guile-internal.h: Update.
3174         * guile/scm-block.c: Update.
3175         * guile/scm-breakpoint.c: Update.
3176         * guile/scm-cmd.c: Update.
3177         * guile/scm-disasm.c: Update.
3178         * guile/scm-frame.c: Update.
3179         * guile/scm-lazy-string.c: Update.
3180         * guile/scm-math.c: Update.
3181         * guile/scm-param.c: Update.
3182         * guile/scm-ports.c: Update.
3183         * guile/scm-pretty-print.c: Update.
3184         * guile/scm-symbol.c: Update.
3185         * guile/scm-symtab.c: Update.
3186         * guile/scm-type.c: Update.
3187         * guile/scm-value.c: Update.
3188         * i386-linux-tdep.c: Update.
3189         * i386-tdep.c: Update.
3190         * inf-loop.c: Update.
3191         * infcall.c: Update.
3192         * infcmd.c: Update.
3193         * infrun.c: Update.
3194         * jit.c: Update.
3195         * language.c: Update.
3196         * linespec.c: Update.
3197         * linux-fork.c: Update.
3198         * linux-nat.c: Update.
3199         * linux-tdep.c: Update.
3200         * linux-thread-db.c: Update.
3201         * main.c: Update.
3202         * mi/mi-cmd-break.c: Update.
3203         * mi/mi-cmd-stack.c: Update.
3204         * mi/mi-interp.c: Update.
3205         * mi/mi-main.c: Update.
3206         * objc-lang.c: Update.
3207         * p-valprint.c: Update.
3208         * parse.c: Update.
3209         * ppc-linux-tdep.c: Update.
3210         * printcmd.c: Update.
3211         * python/py-arch.c: Update.
3212         * python/py-breakpoint.c: Update.
3213         * python/py-cmd.c: Update.
3214         * python/py-finishbreakpoint.c: Update.
3215         * python/py-frame.c: Update.
3216         * python/py-framefilter.c: Update.
3217         * python/py-gdb-readline.c: Update.
3218         * python/py-inferior.c: Update.
3219         * python/py-infthread.c: Update.
3220         * python/py-lazy-string.c: Update.
3221         * python/py-linetable.c: Update.
3222         * python/py-objfile.c: Update.
3223         * python/py-param.c: Update.
3224         * python/py-prettyprint.c: Update.
3225         * python/py-progspace.c: Update.
3226         * python/py-record-btrace.c: Update.
3227         * python/py-record.c: Update.
3228         * python/py-symbol.c: Update.
3229         * python/py-type.c: Update.
3230         * python/py-unwind.c: Update.
3231         * python/py-utils.c: Update.
3232         * python/py-value.c: Update.
3233         * python/python.c: Update.
3234         * record-btrace.c: Update.
3235         * record-full.c: Update.
3236         * remote-fileio.c: Update.
3237         * remote.c: Update.
3238         * riscv-tdep.c: Update.
3239         * rs6000-aix-tdep.c: Update.
3240         * rs6000-tdep.c: Update.
3241         * rust-exp.y: Update.
3242         * rust-lang.c: Update.
3243         * s390-tdep.c: Update.
3244         * selftest-arch.c: Update.
3245         * solib-dsbt.c: Update.
3246         * solib-frv.c: Update.
3247         * solib-spu.c: Update.
3248         * solib-svr4.c: Update.
3249         * solib.c: Update.
3250         * sparc64-linux-tdep.c: Update.
3251         * stack.c: Update.
3252         * symfile-mem.c: Update.
3253         * symmisc.c: Update.
3254         * target.c: Update.
3255         * thread.c: Update.
3256         * top.c: Update.
3257         * tracefile-tfile.c: Update.
3258         * tui/tui.c: Update.
3259         * typeprint.c: Update.
3260         * unittests/cli-utils-selftests.c: Update.
3261         * unittests/parse-connection-spec-selftests.c: Update.
3262         * valops.c: Update.
3263         * valprint.c: Update.
3264         * value.c: Update.
3265         * varobj.c: Update.
3266         * windows-nat.c: Update.
3267         * x86-linux-nat.c: Update.
3268         * xml-support.c: Update.
3269
3270 2019-04-08  Tom Tromey  <tom@tromey.com>
3271
3272         * xml-support.c: Use C++ exception handling.
3273         * x86-linux-nat.c: Use C++ exception handling.
3274         * windows-nat.c: Use C++ exception handling.
3275         * varobj.c: Use C++ exception handling.
3276         * value.c: Use C++ exception handling.
3277         * valprint.c: Use C++ exception handling.
3278         * valops.c: Use C++ exception handling.
3279         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3280         handling.
3281         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3282         * typeprint.c: Use C++ exception handling.
3283         * tui/tui.c: Use C++ exception handling.
3284         * tracefile-tfile.c: Use C++ exception handling.
3285         * top.c: Use C++ exception handling.
3286         * thread.c: Use C++ exception handling.
3287         * target.c: Use C++ exception handling.
3288         * symmisc.c: Use C++ exception handling.
3289         * symfile-mem.c: Use C++ exception handling.
3290         * stack.c: Use C++ exception handling.
3291         * sparc64-linux-tdep.c: Use C++ exception handling.
3292         * solib.c: Use C++ exception handling.
3293         * solib-svr4.c: Use C++ exception handling.
3294         * solib-spu.c: Use C++ exception handling.
3295         * solib-frv.c: Use C++ exception handling.
3296         * solib-dsbt.c: Use C++ exception handling.
3297         * selftest-arch.c: Use C++ exception handling.
3298         * s390-tdep.c: Use C++ exception handling.
3299         * rust-lang.c: Use C++ exception handling.
3300         * rust-exp.y: Use C++ exception handling.
3301         * rs6000-tdep.c: Use C++ exception handling.
3302         * rs6000-aix-tdep.c: Use C++ exception handling.
3303         * riscv-tdep.c: Use C++ exception handling.
3304         * remote.c: Use C++ exception handling.
3305         * remote-fileio.c: Use C++ exception handling.
3306         * record-full.c: Use C++ exception handling.
3307         * record-btrace.c: Use C++ exception handling.
3308         * python/python.c: Use C++ exception handling.
3309         * python/py-value.c: Use C++ exception handling.
3310         * python/py-utils.c: Use C++ exception handling.
3311         * python/py-unwind.c: Use C++ exception handling.
3312         * python/py-type.c: Use C++ exception handling.
3313         * python/py-symbol.c: Use C++ exception handling.
3314         * python/py-record.c: Use C++ exception handling.
3315         * python/py-record-btrace.c: Use C++ exception handling.
3316         * python/py-progspace.c: Use C++ exception handling.
3317         * python/py-prettyprint.c: Use C++ exception handling.
3318         * python/py-param.c: Use C++ exception handling.
3319         * python/py-objfile.c: Use C++ exception handling.
3320         * python/py-linetable.c: Use C++ exception handling.
3321         * python/py-lazy-string.c: Use C++ exception handling.
3322         * python/py-infthread.c: Use C++ exception handling.
3323         * python/py-inferior.c: Use C++ exception handling.
3324         * python/py-gdb-readline.c: Use C++ exception handling.
3325         * python/py-framefilter.c: Use C++ exception handling.
3326         * python/py-frame.c: Use C++ exception handling.
3327         * python/py-finishbreakpoint.c: Use C++ exception handling.
3328         * python/py-cmd.c: Use C++ exception handling.
3329         * python/py-breakpoint.c: Use C++ exception handling.
3330         * python/py-arch.c: Use C++ exception handling.
3331         * printcmd.c: Use C++ exception handling.
3332         * ppc-linux-tdep.c: Use C++ exception handling.
3333         * parse.c: Use C++ exception handling.
3334         * p-valprint.c: Use C++ exception handling.
3335         * objc-lang.c: Use C++ exception handling.
3336         * mi/mi-main.c: Use C++ exception handling.
3337         * mi/mi-interp.c: Use C++ exception handling.
3338         * mi/mi-cmd-stack.c: Use C++ exception handling.
3339         * mi/mi-cmd-break.c: Use C++ exception handling.
3340         * main.c: Use C++ exception handling.
3341         * linux-thread-db.c: Use C++ exception handling.
3342         * linux-tdep.c: Use C++ exception handling.
3343         * linux-nat.c: Use C++ exception handling.
3344         * linux-fork.c: Use C++ exception handling.
3345         * linespec.c: Use C++ exception handling.
3346         * language.c: Use C++ exception handling.
3347         * jit.c: Use C++ exception handling.
3348         * infrun.c: Use C++ exception handling.
3349         * infcmd.c: Use C++ exception handling.
3350         * infcall.c: Use C++ exception handling.
3351         * inf-loop.c: Use C++ exception handling.
3352         * i386-tdep.c: Use C++ exception handling.
3353         * i386-linux-tdep.c: Use C++ exception handling.
3354         * guile/scm-value.c: Use C++ exception handling.
3355         * guile/scm-type.c: Use C++ exception handling.
3356         * guile/scm-symtab.c: Use C++ exception handling.
3357         * guile/scm-symbol.c: Use C++ exception handling.
3358         * guile/scm-pretty-print.c: Use C++ exception handling.
3359         * guile/scm-ports.c: Use C++ exception handling.
3360         * guile/scm-param.c: Use C++ exception handling.
3361         * guile/scm-math.c: Use C++ exception handling.
3362         * guile/scm-lazy-string.c: Use C++ exception handling.
3363         * guile/scm-frame.c: Use C++ exception handling.
3364         * guile/scm-disasm.c: Use C++ exception handling.
3365         * guile/scm-cmd.c: Use C++ exception handling.
3366         * guile/scm-breakpoint.c: Use C++ exception handling.
3367         * guile/scm-block.c: Use C++ exception handling.
3368         * guile/guile-internal.h: Use C++ exception handling.
3369         * gnu-v3-abi.c: Use C++ exception handling.
3370         * gdbtypes.c: Use C++ exception handling.
3371         * frame.c: Use C++ exception handling.
3372         * frame-unwind.c: Use C++ exception handling.
3373         * fbsd-tdep.c: Use C++ exception handling.
3374         * f-valprint.c: Use C++ exception handling.
3375         * exec.c: Use C++ exception handling.
3376         * event-top.c: Use C++ exception handling.
3377         * event-loop.c: Use C++ exception handling.
3378         * eval.c: Use C++ exception handling.
3379         * dwarf2read.c: Use C++ exception handling.
3380         * dwarf2loc.c: Use C++ exception handling.
3381         * dwarf2-frame.c: Use C++ exception handling.
3382         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3383         * dwarf-index-write.c: Use C++ exception handling.
3384         * dwarf-index-cache.c: Use C++ exception handling.
3385         * dtrace-probe.c: Use C++ exception handling.
3386         * disasm-selftests.c: Use C++ exception handling.
3387         * darwin-nat.c: Use C++ exception handling.
3388         * cp-valprint.c: Use C++ exception handling.
3389         * cp-support.c: Use C++ exception handling.
3390         * cp-abi.c: Use C++ exception handling.
3391         * corelow.c: Use C++ exception handling.
3392         * completer.c: Use C++ exception handling.
3393         * compile/compile-object-run.c: Use C++ exception handling.
3394         * compile/compile-object-load.c: Use C++ exception handling.
3395         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3396         * compile/compile-c-symbols.c: Use C++ exception handling.
3397         * common/selftest.c: Use C++ exception handling.
3398         * common/new-op.c: Use C++ exception handling.
3399         * cli/cli-script.c: Use C++ exception handling.
3400         * cli/cli-interp.c: Use C++ exception handling.
3401         * cli/cli-cmds.c: Use C++ exception handling.
3402         * c-varobj.c: Use C++ exception handling.
3403         * btrace.c: Use C++ exception handling.
3404         * breakpoint.c: Use C++ exception handling.
3405         * break-catch-throw.c: Use C++ exception handling.
3406         * arch-utils.c: Use C++ exception handling.
3407         * amd64-tdep.c: Use C++ exception handling.
3408         * ada-valprint.c: Use C++ exception handling.
3409         * ada-typeprint.c: Use C++ exception handling.
3410         * ada-lang.c: Use C++ exception handling.
3411         * aarch64-tdep.c: Use C++ exception handling.
3412
3413 2019-04-08  Tom Tromey  <tom@tromey.com>
3414
3415         * xml-support.c (gdb_xml_parser::parse): Update.
3416         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3417         * value.c (show_convenience): Update.
3418         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3419         (test_parse_flags_qcs): Update.
3420         * thread.c (thr_try_catch_cmd): Update.
3421         * target.c (target_translate_tls_address): Update.
3422         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3423         (info_frame_command_core, frame_apply_command_count): Update.
3424         * rust-exp.y (rust_lex_exception_test): Update.
3425         * riscv-tdep.c (riscv_print_one_register_info): Update.
3426         * remote.c (remote_target::enable_btrace): Update.
3427         * record-btrace.c (record_btrace_enable_warn): Update.
3428         * python/py-utils.c (gdbpy_convert_exception): Update.
3429         * printcmd.c (do_one_display, print_variable_and_value): Update.
3430         * mi/mi-main.c (mi_print_exception): Update.
3431         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3432         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3433         * linux-nat.c (linux_nat_target::attach): Update.
3434         * linux-fork.c (class scoped_switch_fork_info): Update.
3435         * infrun.c (displaced_step_prepare): Update.
3436         * infcall.c (call_function_by_hand_dummy): Update.
3437         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3438         * gnu-v3-abi.c (print_one_vtable): Update.
3439         * frame.c (get_prev_frame_always): Update.
3440         * f-valprint.c (info_common_command_for_block): Update.
3441         * exec.c (try_open_exec_file): Update.
3442         * exceptions.c (print_exception, exception_print)
3443         (exception_fprintf, exception_print_same): Update.
3444         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3445         * dwarf-index-cache.c (index_cache::store)
3446         (index_cache::lookup_gdb_index): Update.
3447         * darwin-nat.c (maybe_cache_shell): Update.
3448         * cp-valprint.c (cp_print_value_fields): Update.
3449         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3450         (gcc_cplus_symbol_address): Update.
3451         * compile/compile-c-symbols.c (gcc_convert_symbol)
3452         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3453         * common/selftest.c: Update.
3454         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3455         a std::string.
3456         (exception_try_scope_entry, exception_try_scope_exit): Don't
3457         declare.
3458         (struct exception_try_scope): Remove.
3459         (TRY): Don't use exception_try_scope.
3460         (struct gdb_exception): Add constructor, operator=.
3461         <what>: New method.
3462         (struct gdb_exception_RETURN_MASK_ALL)
3463         (struct gdb_exception_RETURN_MASK_ERROR)
3464         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3465         (struct gdb_quit_bad_alloc): Update.
3466         * common/common-exceptions.c (exception_none): Change
3467         initializer.
3468         (struct catcher) <state, exception>: Initialize inline.
3469         <prev>: Remove member.
3470         (current_catcher): Remove.
3471         (catchers): New global.
3472         (exceptions_state_mc_init): Simplify.
3473         (catcher_pop): Remove.
3474         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3475         (try_scope_depth, exception_try_scope_entry)
3476         (exception_try_scope_exit): Remove.
3477         (throw_exception_sjlj): Update.
3478         (exception_messages, exception_messages_size): Remove.
3479         (throw_it): Simplify.
3480         (gdb_exception_sliced_copy): Remove.
3481         (throw_exception_cxx): Update.
3482         * cli/cli-script.c (script_from_file): Update.
3483         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3484         Update.
3485         * ada-valprint.c (ada_val_print): Update.
3486         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3487         (create_excep_cond_exprs): Update.
3488
3489 2019-04-08  Tom Tromey  <tom@tromey.com>
3490
3491         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3492         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3493         (TRY, CATCH, END_CATCH): Remove some definitions.
3494         * common/common-exceptions.c: Don't use GDB_XCPT.
3495         (catcher_list_size): Remove.
3496         (throw_exception, throw_it): Simplify.
3497
3498 2019-04-05  Tom Tromey  <tom@tromey.com>
3499
3500         Revert the header-sorting patch.
3501         * ft32-tdep.c: Revert.
3502         * frv-tdep.c: Revert.
3503         * frv-linux-tdep.c: Revert.
3504         * frame.c: Revert.
3505         * frame-unwind.c: Revert.
3506         * frame-base.c: Revert.
3507         * fork-child.c: Revert.
3508         * findvar.c: Revert.
3509         * findcmd.c: Revert.
3510         * filesystem.c: Revert.
3511         * filename-seen-cache.h: Revert.
3512         * filename-seen-cache.c: Revert.
3513         * fbsd-tdep.c: Revert.
3514         * fbsd-nat.h: Revert.
3515         * fbsd-nat.c: Revert.
3516         * f-valprint.c: Revert.
3517         * f-typeprint.c: Revert.
3518         * f-lang.c: Revert.
3519         * extension.h: Revert.
3520         * extension.c: Revert.
3521         * extension-priv.h: Revert.
3522         * expprint.c: Revert.
3523         * exec.h: Revert.
3524         * exec.c: Revert.
3525         * exceptions.c: Revert.
3526         * event-top.c: Revert.
3527         * event-loop.c: Revert.
3528         * eval.c: Revert.
3529         * elfread.c: Revert.
3530         * dwarf2read.h: Revert.
3531         * dwarf2read.c: Revert.
3532         * dwarf2loc.c: Revert.
3533         * dwarf2expr.h: Revert.
3534         * dwarf2expr.c: Revert.
3535         * dwarf2-frame.c: Revert.
3536         * dwarf2-frame-tailcall.c: Revert.
3537         * dwarf-index-write.h: Revert.
3538         * dwarf-index-write.c: Revert.
3539         * dwarf-index-common.c: Revert.
3540         * dwarf-index-cache.h: Revert.
3541         * dwarf-index-cache.c: Revert.
3542         * dummy-frame.c: Revert.
3543         * dtrace-probe.c: Revert.
3544         * disasm.h: Revert.
3545         * disasm.c: Revert.
3546         * disasm-selftests.c: Revert.
3547         * dictionary.c: Revert.
3548         * dicos-tdep.c: Revert.
3549         * demangle.c: Revert.
3550         * dcache.h: Revert.
3551         * dcache.c: Revert.
3552         * darwin-nat.h: Revert.
3553         * darwin-nat.c: Revert.
3554         * darwin-nat-info.c: Revert.
3555         * d-valprint.c: Revert.
3556         * d-namespace.c: Revert.
3557         * d-lang.c: Revert.
3558         * ctf.c: Revert.
3559         * csky-tdep.c: Revert.
3560         * csky-linux-tdep.c: Revert.
3561         * cris-tdep.c: Revert.
3562         * cris-linux-tdep.c: Revert.
3563         * cp-valprint.c: Revert.
3564         * cp-support.c: Revert.
3565         * cp-namespace.c: Revert.
3566         * cp-abi.c: Revert.
3567         * corelow.c: Revert.
3568         * corefile.c: Revert.
3569         * continuations.c: Revert.
3570         * completer.h: Revert.
3571         * completer.c: Revert.
3572         * complaints.c: Revert.
3573         * coffread.c: Revert.
3574         * coff-pe-read.c: Revert.
3575         * cli-out.h: Revert.
3576         * cli-out.c: Revert.
3577         * charset.c: Revert.
3578         * c-varobj.c: Revert.
3579         * c-valprint.c: Revert.
3580         * c-typeprint.c: Revert.
3581         * c-lang.c: Revert.
3582         * buildsym.c: Revert.
3583         * buildsym-legacy.c: Revert.
3584         * build-id.h: Revert.
3585         * build-id.c: Revert.
3586         * btrace.c: Revert.
3587         * bsd-uthread.c: Revert.
3588         * breakpoint.h: Revert.
3589         * breakpoint.c: Revert.
3590         * break-catch-throw.c: Revert.
3591         * break-catch-syscall.c: Revert.
3592         * break-catch-sig.c: Revert.
3593         * blockframe.c: Revert.
3594         * block.c: Revert.
3595         * bfin-tdep.c: Revert.
3596         * bfin-linux-tdep.c: Revert.
3597         * bfd-target.c: Revert.
3598         * bcache.c: Revert.
3599         * ax-general.c: Revert.
3600         * ax-gdb.h: Revert.
3601         * ax-gdb.c: Revert.
3602         * avr-tdep.c: Revert.
3603         * auxv.c: Revert.
3604         * auto-load.c: Revert.
3605         * arm-wince-tdep.c: Revert.
3606         * arm-tdep.c: Revert.
3607         * arm-symbian-tdep.c: Revert.
3608         * arm-pikeos-tdep.c: Revert.
3609         * arm-obsd-tdep.c: Revert.
3610         * arm-nbsd-tdep.c: Revert.
3611         * arm-nbsd-nat.c: Revert.
3612         * arm-linux-tdep.c: Revert.
3613         * arm-linux-nat.c: Revert.
3614         * arm-fbsd-tdep.c: Revert.
3615         * arm-fbsd-nat.c: Revert.
3616         * arm-bsd-tdep.c: Revert.
3617         * arch-utils.c: Revert.
3618         * arc-tdep.c: Revert.
3619         * arc-newlib-tdep.c: Revert.
3620         * annotate.h: Revert.
3621         * annotate.c: Revert.
3622         * amd64-windows-tdep.c: Revert.
3623         * amd64-windows-nat.c: Revert.
3624         * amd64-tdep.c: Revert.
3625         * amd64-sol2-tdep.c: Revert.
3626         * amd64-obsd-tdep.c: Revert.
3627         * amd64-obsd-nat.c: Revert.
3628         * amd64-nbsd-tdep.c: Revert.
3629         * amd64-nbsd-nat.c: Revert.
3630         * amd64-nat.c: Revert.
3631         * amd64-linux-tdep.c: Revert.
3632         * amd64-linux-nat.c: Revert.
3633         * amd64-fbsd-tdep.c: Revert.
3634         * amd64-fbsd-nat.c: Revert.
3635         * amd64-dicos-tdep.c: Revert.
3636         * amd64-darwin-tdep.c: Revert.
3637         * amd64-bsd-nat.c: Revert.
3638         * alpha-tdep.c: Revert.
3639         * alpha-obsd-tdep.c: Revert.
3640         * alpha-nbsd-tdep.c: Revert.
3641         * alpha-mdebug-tdep.c: Revert.
3642         * alpha-linux-tdep.c: Revert.
3643         * alpha-linux-nat.c: Revert.
3644         * alpha-bsd-tdep.c: Revert.
3645         * alpha-bsd-nat.c: Revert.
3646         * aix-thread.c: Revert.
3647         * agent.c: Revert.
3648         * addrmap.c: Revert.
3649         * ada-varobj.c: Revert.
3650         * ada-valprint.c: Revert.
3651         * ada-typeprint.c: Revert.
3652         * ada-tasks.c: Revert.
3653         * ada-lang.c: Revert.
3654         * aarch64-tdep.c: Revert.
3655         * aarch64-ravenscar-thread.c: Revert.
3656         * aarch64-newlib-tdep.c: Revert.
3657         * aarch64-linux-tdep.c: Revert.
3658         * aarch64-linux-nat.c: Revert.
3659         * aarch64-fbsd-tdep.c: Revert.
3660         * aarch64-fbsd-nat.c: Revert.
3661         * aarch32-linux-nat.c: Revert.
3662
3663 2019-04-05  Tom Tromey  <tom@tromey.com>
3664
3665         * ft32-tdep.c: Sort headers.
3666         * frv-tdep.c: Sort headers.
3667         * frv-linux-tdep.c: Sort headers.
3668         * frame.c: Sort headers.
3669         * frame-unwind.c: Sort headers.
3670         * frame-base.c: Sort headers.
3671         * fork-child.c: Sort headers.
3672         * findvar.c: Sort headers.
3673         * findcmd.c: Sort headers.
3674         * filesystem.c: Sort headers.
3675         * filename-seen-cache.h: Sort headers.
3676         * filename-seen-cache.c: Sort headers.
3677         * fbsd-tdep.c: Sort headers.
3678         * fbsd-nat.h: Sort headers.
3679         * fbsd-nat.c: Sort headers.
3680         * f-valprint.c: Sort headers.
3681         * f-typeprint.c: Sort headers.
3682         * f-lang.c: Sort headers.
3683         * extension.h: Sort headers.
3684         * extension.c: Sort headers.
3685         * extension-priv.h: Sort headers.
3686         * expprint.c: Sort headers.
3687         * exec.h: Sort headers.
3688         * exec.c: Sort headers.
3689         * exceptions.c: Sort headers.
3690         * event-top.c: Sort headers.
3691         * event-loop.c: Sort headers.
3692         * eval.c: Sort headers.
3693         * elfread.c: Sort headers.
3694         * dwarf2read.h: Sort headers.
3695         * dwarf2read.c: Sort headers.
3696         * dwarf2loc.c: Sort headers.
3697         * dwarf2expr.h: Sort headers.
3698         * dwarf2expr.c: Sort headers.
3699         * dwarf2-frame.c: Sort headers.
3700         * dwarf2-frame-tailcall.c: Sort headers.
3701         * dwarf-index-write.h: Sort headers.
3702         * dwarf-index-write.c: Sort headers.
3703         * dwarf-index-common.c: Sort headers.
3704         * dwarf-index-cache.h: Sort headers.
3705         * dwarf-index-cache.c: Sort headers.
3706         * dummy-frame.c: Sort headers.
3707         * dtrace-probe.c: Sort headers.
3708         * disasm.h: Sort headers.
3709         * disasm.c: Sort headers.
3710         * disasm-selftests.c: Sort headers.
3711         * dictionary.c: Sort headers.
3712         * dicos-tdep.c: Sort headers.
3713         * demangle.c: Sort headers.
3714         * dcache.h: Sort headers.
3715         * dcache.c: Sort headers.
3716         * darwin-nat.h: Sort headers.
3717         * darwin-nat.c: Sort headers.
3718         * darwin-nat-info.c: Sort headers.
3719         * d-valprint.c: Sort headers.
3720         * d-namespace.c: Sort headers.
3721         * d-lang.c: Sort headers.
3722         * ctf.c: Sort headers.
3723         * csky-tdep.c: Sort headers.
3724         * csky-linux-tdep.c: Sort headers.
3725         * cris-tdep.c: Sort headers.
3726         * cris-linux-tdep.c: Sort headers.
3727         * cp-valprint.c: Sort headers.
3728         * cp-support.c: Sort headers.
3729         * cp-namespace.c: Sort headers.
3730         * cp-abi.c: Sort headers.
3731         * corelow.c: Sort headers.
3732         * corefile.c: Sort headers.
3733         * continuations.c: Sort headers.
3734         * completer.h: Sort headers.
3735         * completer.c: Sort headers.
3736         * complaints.c: Sort headers.
3737         * coffread.c: Sort headers.
3738         * coff-pe-read.c: Sort headers.
3739         * cli-out.h: Sort headers.
3740         * cli-out.c: Sort headers.
3741         * charset.c: Sort headers.
3742         * c-varobj.c: Sort headers.
3743         * c-valprint.c: Sort headers.
3744         * c-typeprint.c: Sort headers.
3745         * c-lang.c: Sort headers.
3746         * buildsym.c: Sort headers.
3747         * buildsym-legacy.c: Sort headers.
3748         * build-id.h: Sort headers.
3749         * build-id.c: Sort headers.
3750         * btrace.c: Sort headers.
3751         * bsd-uthread.c: Sort headers.
3752         * breakpoint.h: Sort headers.
3753         * breakpoint.c: Sort headers.
3754         * break-catch-throw.c: Sort headers.
3755         * break-catch-syscall.c: Sort headers.
3756         * break-catch-sig.c: Sort headers.
3757         * blockframe.c: Sort headers.
3758         * block.c: Sort headers.
3759         * bfin-tdep.c: Sort headers.
3760         * bfin-linux-tdep.c: Sort headers.
3761         * bfd-target.c: Sort headers.
3762         * bcache.c: Sort headers.
3763         * ax-general.c: Sort headers.
3764         * ax-gdb.h: Sort headers.
3765         * ax-gdb.c: Sort headers.
3766         * avr-tdep.c: Sort headers.
3767         * auxv.c: Sort headers.
3768         * auto-load.c: Sort headers.
3769         * arm-wince-tdep.c: Sort headers.
3770         * arm-tdep.c: Sort headers.
3771         * arm-symbian-tdep.c: Sort headers.
3772         * arm-pikeos-tdep.c: Sort headers.
3773         * arm-obsd-tdep.c: Sort headers.
3774         * arm-nbsd-tdep.c: Sort headers.
3775         * arm-nbsd-nat.c: Sort headers.
3776         * arm-linux-tdep.c: Sort headers.
3777         * arm-linux-nat.c: Sort headers.
3778         * arm-fbsd-tdep.c: Sort headers.
3779         * arm-fbsd-nat.c: Sort headers.
3780         * arm-bsd-tdep.c: Sort headers.
3781         * arch-utils.c: Sort headers.
3782         * arc-tdep.c: Sort headers.
3783         * arc-newlib-tdep.c: Sort headers.
3784         * annotate.h: Sort headers.
3785         * annotate.c: Sort headers.
3786         * amd64-windows-tdep.c: Sort headers.
3787         * amd64-windows-nat.c: Sort headers.
3788         * amd64-tdep.c: Sort headers.
3789         * amd64-sol2-tdep.c: Sort headers.
3790         * amd64-obsd-tdep.c: Sort headers.
3791         * amd64-obsd-nat.c: Sort headers.
3792         * amd64-nbsd-tdep.c: Sort headers.
3793         * amd64-nbsd-nat.c: Sort headers.
3794         * amd64-nat.c: Sort headers.
3795         * amd64-linux-tdep.c: Sort headers.
3796         * amd64-linux-nat.c: Sort headers.
3797         * amd64-fbsd-tdep.c: Sort headers.
3798         * amd64-fbsd-nat.c: Sort headers.
3799         * amd64-dicos-tdep.c: Sort headers.
3800         * amd64-darwin-tdep.c: Sort headers.
3801         * amd64-bsd-nat.c: Sort headers.
3802         * alpha-tdep.c: Sort headers.
3803         * alpha-obsd-tdep.c: Sort headers.
3804         * alpha-nbsd-tdep.c: Sort headers.
3805         * alpha-mdebug-tdep.c: Sort headers.
3806         * alpha-linux-tdep.c: Sort headers.
3807         * alpha-linux-nat.c: Sort headers.
3808         * alpha-bsd-tdep.c: Sort headers.
3809         * alpha-bsd-nat.c: Sort headers.
3810         * aix-thread.c: Sort headers.
3811         * agent.c: Sort headers.
3812         * addrmap.c: Sort headers.
3813         * ada-varobj.c: Sort headers.
3814         * ada-valprint.c: Sort headers.
3815         * ada-typeprint.c: Sort headers.
3816         * ada-tasks.c: Sort headers.
3817         * ada-lang.c: Sort headers.
3818         * aarch64-tdep.c: Sort headers.
3819         * aarch64-ravenscar-thread.c: Sort headers.
3820         * aarch64-newlib-tdep.c: Sort headers.
3821         * aarch64-linux-tdep.c: Sort headers.
3822         * aarch64-linux-nat.c: Sort headers.
3823         * aarch64-fbsd-tdep.c: Sort headers.
3824         * aarch64-fbsd-nat.c: Sort headers.
3825         * aarch32-linux-nat.c: Sort headers.
3826
3827 2019-04-04  Tom Tromey  <tom@tromey.com>
3828
3829         * varobj.c (varobj_create): Update.
3830         * rust-exp.y (struct rust_parser) <update_innermost_block,
3831         lookup_symbol>: New methods.
3832         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3833         Rename.
3834         (rust_parser::rust_lookup_type)
3835         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3836         * printcmd.c (display_command, do_one_display): Update.
3837         * parser-defs.h (struct parser_state) <parser_state>: Add
3838         "tracker" parameter.
3839         (block_tracker): New member.
3840         (class innermost_block_tracker) <innermost_block_tracker>: Add
3841         "types" parameter.
3842         <reset>: Remove method.
3843         (innermost_block): Don't declare.
3844         (null_post_parser): Update.
3845         * parse.c (innermost_block): Remove global.
3846         (write_dollar_variable): Update.
3847         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3848         Remove "tracker_types" parameter.
3849         (parse_expression): Add "tracker" parameter.
3850         (parse_expression_for_completion): Update.
3851         (null_post_parser): Add "tracker" parameter.
3852         * p-exp.y: Update rules.
3853         * m2-exp.y: Update rules.
3854         * language.h (struct language_defn) <la_post_parser>: Add
3855         "tracker" parameter.
3856         * go-exp.y: Update rules.
3857         * f-exp.y: Update rules.
3858         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3859         parameter.
3860         * d-exp.y: Update rules.
3861         * c-exp.y: Update rules.
3862         * breakpoint.c (set_breakpoint_condition): Create an
3863         innermost_block_tracker.
3864         (watch_command_1): Likewise.
3865         * ada-lang.c (resolve): Add "tracker" parameter.
3866         (resolve_subexp): Likewise.
3867         * ada-exp.y (write_var_from_sym): Update.
3868
3869 2019-04-04  Tom Tromey  <tom@tromey.com>
3870
3871         * type-stack.h: New file.
3872         * type-stack.c: New file.
3873         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3874         type-stack.h.
3875         (insert_into_type_stack, insert_type, push_type, push_type_int)
3876         (insert_type_address_space, pop_type, pop_type_int)
3877         (pop_typelist, pop_type_stack, append_type_stack)
3878         (push_type_stack, get_type_stack, push_typelist)
3879         (follow_type_instance_flags, follow_types): Don't declare.
3880         * parse.c (type_stack): Remove global.
3881         (parse_exp_in_context): Update.
3882         (insert_into_type_stack, insert_type, push_type, push_type_int)
3883         (insert_type_address_space, pop_type, pop_type_int)
3884         (pop_typelist, pop_type_stack, append_type_stack)
3885         (push_type_stack, get_type_stack, push_typelist)
3886         (follow_type_instance_flags, follow_types): Remove (moved to
3887         type-stack.c).
3888         * f-exp.y (type_stack): New global.
3889         Update rules.
3890         (push_kind_type, f_parse): Update.
3891         * d-exp.y (type_stack): New global.
3892         Update rules.
3893         (d_parse): Update.
3894         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3895         Update rules.
3896         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3897         (HFILES_NO_SRCDIR): Add type-stack.h.
3898
3899 2019-04-04  Tom Tromey  <tom@tromey.com>
3900
3901         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3902         (rust_parser::convert_ast_to_expression, rust_parse)
3903         (rust_lex_test_completion, rust_lex_tests): Update.
3904         * parser-defs.h (struct expr_completion_state): New.
3905         (struct parser_state) <parser_state>: Add completion parameter.
3906         <mark_struct_expression, mark_completion_tag>: New methods.
3907         <parse_completion, m_completion_state>: New members.
3908         (prefixify_expression, null_post_parser): Update.
3909         (mark_struct_expression, mark_completion_tag): Don't declare.
3910         * parse.c (parse_completion, expout_last_struct)
3911         (expout_tag_completion_type, expout_completion_name): Remove
3912         globals.
3913         (parser_state::mark_struct_expression)
3914         (parser_state::mark_completion_tag): Now methods.
3915         (prefixify_expression): Add last_struct parameter.
3916         (prefixify_subexp): Likewise.
3917         (parse_exp_1): Update.
3918         (parse_exp_in_context): Add cstate parameter.  Update.
3919         (parse_expression_for_completion): Create an
3920         expr_completion_state.
3921         (null_post_parser): Add "completion" parameter.
3922         * p-exp.y: Update rules.
3923         (yylex): Update.
3924         * language.h (struct language_defn) <la_post_parser>: Add
3925         "completing" parameter.
3926         * go-exp.y: Update rules.
3927         (lex_one_token): Update.
3928         * expression.h (parse_completion): Don't declare.
3929         * d-exp.y: Update rules.
3930         (lex_one_token): Update rules.
3931         * c-exp.y: Update rules.
3932         (lex_one_token): Update.
3933         * ada-lang.c (resolve): Add "parse_completion" parameter.
3934         (resolve_subexp): Likewise.
3935         (ada_resolve_function): Likewise.
3936
3937 2019-04-04  Tom Tromey  <tom@tromey.com>
3938
3939         * parser-defs.h (struct parser_state) <start_arglist,
3940         end_arglist>: New methods.
3941         <arglist_len, m_funcall_chain>: New members.
3942         (arglist_len, start_arglist, end_arglist): Don't declare.
3943         * parse.c (arglist_len, funcall_chain): Remove global.
3944         (start_arglist, end_arglist): Remove functions.
3945         (parse_exp_in_context): Update.
3946         * p-exp.y: Update rules.
3947         * m2-exp.y: Update rules.
3948         * go-exp.y: Update rules.
3949         * f-exp.y: Update rules.
3950         * d-exp.y: Update rules.
3951         * c-exp.y: Update rules.
3952
3953 2019-04-04  Tom Tromey  <tom@tromey.com>
3954
3955         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3956         lex_operator, push_back>: New methods.
3957         Update all rules.
3958         (rust_parser::lex_hex, lex_escape): Rename and update.
3959         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3960         (rust_parser::lex_operator): Rename and update.
3961         (rust_parser::lex_number, rustyylex, rustyyerror)
3962         (rust_lex_test_init, rust_lex_test_sequence)
3963         (rust_lex_test_push_back, rust_lex_tests): Update.
3964         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3965         parameter.
3966         <lexptr, prev_lexptr>: New members.
3967         (lexptr, prev_lexptr): Don't declare.
3968         * parse.c (lexptr, prev_lexptr): Remove globals.
3969         (parse_exp_in_context): Update.
3970         * p-exp.y (yylex, yyerror): Update.
3971         * m2-exp.y (parse_number, yylex, yyerror): Update.
3972         * go-exp.y (lex_one_token, yyerror): Update.
3973         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3974         * d-exp.y (lex_one_token, yyerror): Update.
3975         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3976         (lex_one_token, yyerror): Update.
3977         * ada-lex.l (YY_INPUT): Update.
3978         (rewind_to_char): Update.
3979         * ada-exp.y (yyerror): Update.
3980
3981 2019-04-04  Tom Tromey  <tom@tromey.com>
3982
3983         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3984         * parser-defs.h (struct parser_state) <parser_state>: Add new
3985         parameter.
3986         <comma_terminates>: New member.
3987         (comma_terminates): Don't declare global.
3988         * parse.c (comma_terminates): Remove global.
3989         (parse_exp_in_context): Update.
3990         * p-exp.y (yylex): Update.
3991         * m2-exp.y (yylex): Update.
3992         * go-exp.y (lex_one_token): Update.
3993         * f-exp.y (yylex): Update.
3994         * d-exp.y (lex_one_token): Update.
3995         * c-exp.y (lex_one_token): Update.
3996         * ada-lex.l: Update.
3997
3998 2019-04-04  Tom Tromey  <tom@tromey.com>
3999
4000         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4001         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4002         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4003         * parser-defs.h (paren_depth): Don't declare.
4004         * parse.c (paren_depth): Remove global.
4005         (parse_exp_in_context): Update.
4006         * p-exp.y (paren_depth): New global.
4007         (pascal_parse): Initialize it.
4008         * m2-exp.y (paren_depth): New global.
4009         (m2_parse): Initialize it.
4010         * go-exp.y (paren_depth): New global.
4011         (go_parse): Initialize it.
4012         * f-exp.y (paren_depth): New global.
4013         (f_parse): Initialize it.
4014         * d-exp.y (paren_depth): New global.
4015         (d_parse): Initialize it.
4016         * c-exp.y (paren_depth): New global.
4017         (c_parse): Initialize it.
4018         * ada-lex.l (paren_depth): New global.
4019         (lexer_init): Initialize it.
4020
4021 2019-04-04  Tom Tromey  <tom@tromey.com>
4022
4023         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4024         (rust_parser::convert_ast_to_type)
4025         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4026         * parser-defs.h (struct parser_state) <parser_state>: Add
4027         parameters.  Initialize new members.
4028         <expression_context_block, expression_context_pc>: New members.
4029         * parse.c (expression_context_block, expression_context_pc):
4030         Remove globals.
4031         (parse_exp_in_context): Update.
4032         * p-exp.y: Update all rules.
4033         (yylex): Update.
4034         * m2-exp.y: Update all rules.
4035         (yylex): Update.
4036         * go-exp.y (yylex): Update.
4037         * f-exp.y (yylex): Update.
4038         * d-exp.y: Update all rules.
4039         (yylex): Update.
4040         * c-exp.y: Update all rules.
4041         (lex_one_token, classify_name, yylex, c_parse): Update.
4042         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4043
4044 2019-04-04  Tom Tromey  <tom@tromey.com>
4045
4046         * gdbarch.h, gdbarch.c: Rebuild.
4047         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4048         * stap-probe.h:
4049         (struct stap_parse_info): Replace "parser_state" with
4050         "expr_builder".
4051         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4052         (parser_state): New class.
4053         * parse.c (expr_builder): Rename.
4054         (expr_builder::release): Rename.
4055         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4056         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4057         (write_exp_elt_longcst, write_exp_elt_floatcst)
4058         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4059         (write_exp_string_vector, write_exp_bitstring)
4060         (write_exp_msymbol, mark_struct_expression)
4061         (write_dollar_variable)
4062         (insert_type_address_space, increase_expout_size): Replace
4063         "parser_state" with "expr_builder".
4064         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4065         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4066         "parser_state" with "expr_builder".
4067
4068 2019-04-04  Tom Tromey  <tom@tromey.com>
4069
4070         * rust-exp.y: Replace "parse_language" with method call.
4071         * p-exp.y:
4072         (yylex): Replace "parse_language" with method call.
4073         * m2-exp.y:
4074         (yylex): Replace "parse_language" with method call.
4075         * go-exp.y (classify_name): Replace "parse_language" with method
4076         call.
4077         * f-exp.y (yylex): Replace "parse_language" with method call.
4078         * d-exp.y (lex_one_token): Replace "parse_language" with method
4079         call.
4080         * c-exp.y:
4081         (lex_one_token, classify_name, yylex): Replace "parse_language"
4082         with method call.
4083         * ada-exp.y (find_primitive_type, type_char)
4084         (type_system_address): Replace "parse_language" with method call.
4085
4086 2019-04-04  Tom Tromey  <tom@tromey.com>
4087
4088         * rust-exp.y: Replace "parse_gdbarch" with method call.
4089         * parse.c (write_dollar_variable, insert_type_address_space):
4090         Replace "parse_gdbarch" with method call.
4091         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4092         call.
4093         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4094         call.
4095         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4096         "parse_gdbarch" with method call.
4097         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4098         with method call.
4099         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4100         "parse_gdbarch" with method call.
4101         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4102         "parse_gdbarch" with method call.
4103         * c-exp.y (parse_type, parse_number, classify_name): Replace
4104         "parse_gdbarch" with method call.
4105         * ada-lex.l: Replace "parse_gdbarch" with method call.
4106         * ada-exp.y (parse_type, find_primitive_type, type_char)
4107         (type_system_address): Replace "parse_gdbarch" with method call.
4108
4109 2019-04-04  Tom Tromey  <tom@tromey.com>
4110
4111         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4112         * stap-probe.c (stap_parse_argument): Update.
4113         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4114         initial_size parameter.
4115         * rust-exp.y (rust_lex_tests): Update.
4116         * parse.c (parser_state): Update.
4117         (parse_exp_in_context): Update.
4118         * parser-defs.h (struct parser_state) <parser_state>: Remove
4119         "initial_size" parameter.
4120
4121 2019-04-04  Tom Tromey  <tom@tromey.com>
4122
4123         * parser-defs.h (increase_expout_size): Don't declare.
4124         * parse.c (increase_expout_size): Now static.
4125
4126 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4127
4128         * gnu-nat.c (gnu_nat_target::wait): Fix
4129         target_waitstatus_to_string call.
4130
4131 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4132
4133         * eval.c (evaluate_subexp_standard): Handle internal functions
4134         during Fortran function call handling.
4135
4136 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4137
4138         * NEWS: Mention new internal functions.
4139         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4140         (read_base_type): Use dwarf2_init_complex_target_type.
4141         * value.c (creal_internal_fn): New function.
4142         (cimag_internal_fn): New function.
4143         (_initialize_values): Register new internal functions.
4144
4145 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4146
4147         * infrun.c (stop_all_threads): If debug_infrun, always
4148         trace the wait status after wait_one, using
4149         target_waitstatus_to_string and target_pid_to_str.
4150         (handle_inferior_event): Replace various trace of
4151         wait status kind by a single trace.
4152         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4153         wait status kind image by target_waitstatus_to_string.
4154         * target/waitstatus.c (target_waitstatus_to_string): Fix
4155         obsolete comment.
4156
4157 2019-04-01  Tom Tromey  <tromey@adacore.com>
4158
4159         PR symtab/23331:
4160         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4161
4162 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4163             Pedro Alves  <palves@redhat.com>
4164
4165         * top.c (quit_force): Call 'finalize_values'.
4166         * value.c (finalize_values): New function.
4167         * value.h (finalize_values): Declare.
4168
4169 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4170
4171         * NEWS: Announce $_gdb_major and $_gdb_minor.
4172
4173         * top.c (init_gdb_version_vars): New function.
4174         (gdb_init): Call init_gdb_version_vars.
4175
4176 2019-03-29  Tom Tromey  <tromey@adacore.com>
4177
4178         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4179         help text.  Remove dead code.
4180
4181 2019-03-29  Keith Seitz  <keiths@redhat.com>
4182
4183         From Siddhesh Poyarekar:
4184         * f-lang.h (f77_get_upperbound): Return LONGEST.
4185         (f77_get_lowerbound): Likewise.
4186         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4187         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4188         print them.
4189         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4190         plongest to format print it.
4191         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4192         (f77_get_upperbound): Likewise.
4193         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4194         LOWER_BOUND to LONGEST.
4195         (f77_create_arrayprint_offset_tbl): Likewise.
4196
4197 2019-03-29  Keith Seitz  <keiths@redhat.com>
4198
4199         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4200         %s/pulongest for TYPE_LENGTH instead of %d in format
4201         strings.
4202         * ada-typerint.c (ada_print_type): Likewise.
4203         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4204         * compile/compile-c-support.c (generate_register_struct): Likewise.
4205         * gdbtypes.c (recursive_dump_type): Likewise.
4206         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4207         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4208         instead of %d in format strings.
4209         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4210         to std::min to ULONGEST.
4211         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4212         instead of %d in format strings.
4213         * tracepoint.c (info_scope_command): Likewise.
4214         * typeprint.c (print_offset_data::update)
4215         (print_offset_data::finish): Likewise.
4216         * xtensa-tdep.c (xtensa_store_return_value)
4217         (xtensa_push_dummy_call): Likewise.
4218
4219 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4220
4221         * windows-nat.c (display_selector): Fixed format specifications
4222         for 64-bit Cygwin.
4223
4224 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4225
4226         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4227
4228 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4229
4230         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4231         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4232         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4233         (nios2_linux_init_abi): Install it.
4234
4235 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4236
4237         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4238
4239 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4240
4241         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4242
4243 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4244             Tom Tromey  <tromey@adacore.com>
4245
4246         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4247
4248 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4249
4250         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4251         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4252         method to compute the bounds of range types. Also print "[evaluated]"
4253         if the bounds' values come from a dynamic evaluation.
4254
4255 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4258         whitespace when pretty printing is on.
4259
4260 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4261
4262         * ppc-linux-nat.c: Add include.
4263
4264 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4265
4266         * NEWS: Mention AArch64 Pointer Authentication.
4267
4268 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4269
4270         * arm-linux-nat.c: Add include.
4271
4272 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4273
4274         * source-cache.c (source_cache::get_source_lines): Re-read
4275         fullname after calling open_source_file.
4276
4277 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4278
4279         * NEWS: Mention TLS support for FreeBSD.
4280
4281 2019-03-25  Tom Tromey  <tromey@adacore.com>
4282
4283         * minsyms.c (BUNCH_SIZE): Update comment.
4284         (~minimal_symbol_reader): Remove old comment.
4285         (compact_minimal_symbols): Update comment.
4286         (minimal_symbol_reader::install): Remove old comment.  Update
4287         other comments.
4288
4289 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4290
4291         * s390-linux-nat.c: Add include.
4292
4293 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4294
4295         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4296         Call linux_get_hwcap.
4297         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4298         Likewise.
4299         (aarch64_linux_get_hwcap): Remove function.
4300         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4301         declaration.
4302         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4303         linux_get_hwcap.
4304         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4305         * linux-tdep.c (linux_get_hwcap): Add function.
4306         (linux_get_hwcap2): Likewise.
4307         * linux-tdep.h (linux_get_hwcap): Add declaration.
4308         (linux_get_hwcap2): Likewise.
4309         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4310         (ppc_linux_get_hwcap2): Likewise.
4311         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4312         linux_get_hwcap.
4313         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4314         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4315         (ppc_linux_nat_target::read_description): Likewise.
4316         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4317         * s390-linux-nat.c: Likewise.
4318         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4319
4320 2019-03-24  Tom Tromey  <tom@tromey.com>
4321
4322         * ada-lang.c (standard_lookup): Simplify initialization.
4323         (ada_lookup_symbol_nonlocal): Simplify return.
4324         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4325         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4326         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4327         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4328         initialization.
4329         * solib.c (solib_global_lookup): Simplify.
4330         * symtab.c (null_block_symbol): Remove.
4331         (symbol_cache_lookup): Simplify returns.
4332         (lookup_language_this): Simplify returns.
4333         (lookup_symbol_aux): Simplify return.
4334         (lookup_local_symbol): Simplify returns.
4335         (lookup_global_symbol_from_objfile): Simplify return.
4336         (lookup_symbol_in_objfile_symtabs)
4337         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4338         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4339         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4340         * cp-namespace.c (cp_lookup_bare_symbol)
4341         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4342         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4343         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4344         (cp_lookup_symbol_via_imports): Simplify initialization.
4345         (find_symbol_in_baseclass): Likewise.
4346         * symtab.h (null_block_symbol): Remove.
4347         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4348         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4349         (d_lookup_symbol_module): Likewise.
4350         (find_symbol_in_baseclass): Simplify initialization.
4351
4352 2019-03-24  Tom Tromey  <tom@tromey.com>
4353
4354         * expression.h: Don't include symtab.h.
4355         (struct block): Forward declare.
4356
4357 2019-03-24  Tom Tromey  <tom@tromey.com>
4358
4359         * c-exp.y (typebase): Remove casts.
4360         * gdbtypes.c (lookup_unsigned_typename, )
4361         (lookup_signed_typename): Remove cast.
4362         * eval.c (parse_to_comma_and_eval): Remove cast.
4363         * parse.c (write_dollar_variable): Remove cast.
4364         * block.h (struct block) <superblock>: Now const.
4365         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4366         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4367         (map_block): Make "block" const.
4368         * symfile.h (struct quick_symbol_functions)
4369         <map_matching_symbols>: Constify block argument to "callback".
4370         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4371         const.
4372         (find_pc_sect_compunit_symtab): Make "b" const.
4373         (find_symbol_at_address): Likewise.
4374         (search_symbols): Likewise.
4375         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4376         (dw2_debug_names_lookup_symbol): Likewise.
4377         (dw2_map_matching_symbols): Update.
4378         * p-valprint.c (pascal_val_print): Remove "block".
4379         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4380         (aux_add_nonlocal_symbols): Make "block" const.
4381         (resolve_subexp): Remove cast.
4382         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4383         const.
4384         (iterate_over_file_blocks): Likewise.
4385         * f-exp.y (%union) <bval>: Remove.
4386         * coffread.c (patch_opaque_types): Make "b" const.
4387         * spu-tdep.c (spu_catch_start): Make "block" const.
4388         * c-valprint.c (print_unpacked_pointer): Remove "block".
4389         * symmisc.c (dump_symtab_1): Make "b" const.
4390         (block_depth): Make "block" const.
4391         * d-exp.y (%union) <bval>: Remove.
4392         * cp-support.h (cp_lookup_rtti_type): Update.
4393         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4394         * psymtab.c (psym_lookup_symbol): Make "block" const.
4395         (maintenance_check_psymtabs): Make "b" const.
4396         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4397         (enumerate_locals, enumerate_args): Update.
4398         * python/py-symtab.c (stpy_global_block): Make "block" const.
4399         (stpy_static_block): Likewise.
4400         * inline-frame.c (block_starting_point_at): Make "new_block"
4401         const.
4402         * block.c (find_block_in_blockvector): Make return type const.
4403         (blockvector_for_pc_sect): Make "b" const.
4404         (find_block_in_blockvector): Make "b" const.
4405
4406 2019-03-23  Tom Tromey  <tom@tromey.com>
4407
4408         * varobj.c (varobj_create): Update.
4409         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4410         * printcmd.c (display_command, do_one_display): Don't reset
4411         innermost_block.
4412         * parser-defs.h (enum innermost_block_tracker_type): Move to
4413         expression.h.
4414         (innermost_block): Update comment.
4415         * parse.c (parse_exp_1): Add tracker_types parameter.
4416         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4417         tracker_types parameter.  Reset innermost_block.
4418         (parse_exp_in_context): Remove.
4419         (parse_expression_for_completion): Update.
4420         * objfiles.c (~objfile): Don't reset expression_context_block or
4421         innermost_block.
4422         * expression.h (enum innermost_block_tracker_type): Move from
4423         parser-defs.h.
4424         (parse_exp_1): Add tracker_types parameter.
4425         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4426         reset innermost_block.
4427
4428 2019-03-23  Tom Tromey  <tom@tromey.com>
4429
4430         * objfiles.h: Include bcache.h.
4431
4432 2019-03-23  Tom Tromey  <tom@tromey.com>
4433
4434         * linespec.c (get_current_search_block): Use
4435         scoped_restore_current_language.
4436         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4437
4438 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4439             Jiong Wang  <jiong.wang@arm.com>
4440
4441         * aarch64-linux-tdep.c
4442         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4443         section.
4444         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4445
4446 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4447             Jiong Wang  <jiong.wang@arm.com>
4448
4449         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4450         instructions.
4451         (aarch64_analyze_prologue_test): Add PACIASP test.
4452         (aarch64_prologue_prev_register): Unmask PC value.
4453
4454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4455             Jiong Wang  <jiong.wang@arm.com>
4456
4457         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4458         (aarch64_dwarf2_prev_register): Unmask PC value.
4459         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4460         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4461         DW_CFA_AARCH64_negate_ra_state.
4462         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4463
4464 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4465             Jiong Wang  <jiong.wang@arm.com>
4466
4467         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4468         registers.
4469         (aarch64_pseudo_register_name): Likewise.
4470         (aarch64_pseudo_register_type): Likewise.
4471         (aarch64_pseudo_register_reggroup_p): Likewise.
4472         (aarch64_gdbarch_init): Add pauth registers.
4473         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4474         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4475         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4476         (struct gdbarch_tdep): Add regnum for ra_state.
4477
4478 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4479             Jiong Wang  <jiong.wang@arm.com>
4480
4481         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4482
4483 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4484             Jiong Wang  <jiong.wang@arm.com>
4485
4486         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4487         function.
4488         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4489         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4490         (aarch64_gdbarch_init): Add puth registers.
4491         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4492         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4493         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4494
4495 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4496             Jiong Wang  <jiong.wang@arm.com>
4497
4498         * aarch64-linux-nat.c
4499         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4500         * aarch64-linux-tdep.c
4501         (aarch64_linux_core_read_description): Likewise.
4502         (aarch64_linux_get_hwcap): New function.
4503         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4504         (aarch64_linux_get_hwcap): New declaration.
4505
4506 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4507             Jiong Wang  <jiong.wang@arm.com>
4508
4509         * aarch64-linux-nat.c
4510         (aarch64_linux_nat_target::read_description): Add pauth param.
4511         * aarch64-linux-tdep.c
4512         (aarch64_linux_core_read_description): Likewise.
4513         * aarch64-tdep.c (struct target_desc): Add in pauth.
4514         (aarch64_read_description): Add pauth param.
4515         (aarch64_gdbarch_init): Likewise.
4516         * aarch64-tdep.h (aarch64_read_description): Likewise.
4517         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4518         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4519         * features/Makefile: Add new files.
4520         * features/aarch64-pauth.c: New file.
4521         * features/aarch64-pauth.xml: New file.
4522
4523 2019-03-20  Tom Tromey  <tromey@adacore.com>
4524
4525         * infrun.c (handle_inferior_event): Rename from
4526         handle_inferior_event_1.  Create a scoped_value_mark.
4527         (handle_inferior_event): Remove.
4528
4529 2019-03-19  Tom Tromey  <tromey@adacore.com>
4530
4531         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4532         * infrun.h (print_stop_event): Add "displays" parameter.
4533         * infrun.c (print_stop_event): Add "displays" parameter.
4534
4535 2019-03-19  Pedro Alves  <palves@redhat.com>
4536
4537         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4538         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4539         to -1.  Fix TABs vs spaces.
4540         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4541         * tui/tui-out.h (tui_ui_out) Add intro comments.
4542         <m_line, m_start_of_line>: In-class initialize, and add describing
4543         comment.
4544
4545 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4546
4547         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4548         variable names.
4549         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4550
4551 2019-03-18  Pedro Alves  <palves@redhat.com>
4552             Eli Zaretskii <eliz@gnu.org>
4553
4554         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4555         m_line and m_start_of_line.
4556
4557 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4558
4559         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4560         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4561         it returns a newline.  This fixes a regression in TU mode, whereby
4562         the next line is output on the same screen line as the user input.
4563
4564 2019-03-18  Tom Tromey  <tromey@adacore.com>
4565
4566         * minsyms.c (minimal_symbol_reader::install): Remove call to
4567         obstack_blank.
4568
4569 2019-03-18  Pedro Alves  <palves@redhat.com>
4570
4571         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4572         New globals.
4573         (apply_style): New, factored out from ...
4574         (apply_ansi_escape): ... this.  Handle reverse video mode.
4575         (tui_set_reverse_mode): New function.
4576         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4577         * tui/tui-winsource.c (tui_show_source_line): Use
4578         tui_set_reverse_mode instead of setting A_STANDOUT.
4579         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4580         New setter methods.
4581
4582 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4583
4584         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4585         Handle tabs.
4586
4587 2019-03-18  Tom Tromey  <tromey@adacore.com>
4588
4589         * ada-lang.c (empty_array): Add "high" parameter.
4590         (ada_evaluate_subexp): Update.
4591
4592 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4593
4594         * unittests/string_view-selftests.c: Define
4595         _initialize_string_view_selftests unconditionally.
4596
4597 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4598
4599         PR gdb/24350
4600         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4601
4602 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4603
4604         PR gdb/24351
4605         * windows-nat.c (display_selector): Fix format specifiers.
4606
4607 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4608
4609         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4610         tui_refill_source_window instead of tui_refresh_win, to update the
4611         current execution line.  This fixes redisplay of the current line
4612         when stepping through the code with "next" or "step".
4613
4614 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4615
4616         * source-cache.c (source_cache::get_source_lines): Call
4617         find_source_lines to initialize s->nlines.  This fixes vertical
4618         scrolling of TUI source window when the DOWN arrow is pressed.
4619
4620 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4621
4622         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4623         linux-thread-db.c (_initialize_thread_db): Likewise.
4624
4625 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4626
4627         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4628         wclrtoeol in tui_show_source_line".  This reverts changes made in
4629         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4630
4631 2019-03-15  Tom Tromey  <tom@tromey.com>
4632
4633         * symtab.h (struct minimal_symbol): Derive from
4634         general_symbol_info.
4635         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4636         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4637         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4638         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4639         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4640         (MSYMBOL_SEARCH_NAME): Update.
4641         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4642         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4643         * minsyms.c (minimal_symbol_reader::record_full): Update.
4644
4645 2019-03-15  Tom Tromey  <tom@tromey.com>
4646
4647         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4648
4649 2019-03-15  Tom Tromey  <tom@tromey.com>
4650
4651         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4652         unique_xmalloc_ptr.
4653         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4654         Update.
4655         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4656         (build_minimal_symbol_hash_tables)
4657         (minimal_symbol_reader::install): Update.
4658
4659 2019-03-15  Tom Tromey  <tom@tromey.com>
4660
4661         * symtab.c (create_demangled_names_hash): Update.
4662         (symbol_set_names): Update.
4663         * objfiles.h (struct objfile_per_bfd_storage)
4664         <demangled_names_hash>: Now an htab_up.
4665         * objfiles.c (objfile_per_bfd_storage): Simplify.
4666
4667 2019-03-15  Tom Tromey  <tom@tromey.com>
4668
4669         * objfiles.h (struct objfile_per_bfd_storage): Declare
4670         destructor.
4671         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4672         New.
4673         (get_objfile_bfd_data): Use new.  Don't initialize
4674         language_of_main.
4675         (free_objfile_per_bfd_storage): Remove.
4676         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4677
4678 2019-03-15  Tom Tromey  <tom@tromey.com>
4679
4680         * symfile.c (reread_symbols): Update.
4681         * objfiles.c (objfile::objfile): Update.
4682         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4683         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4684         comment.
4685         (minimal_symbol_reader::install): Update.
4686         (terminate_minimal_symbol_table): Remove.
4687         * jit.c (jit_object_close_impl): Update.
4688
4689 2019-03-15  Tom Tromey  <tom@tromey.com>
4690
4691         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4692         initializations.
4693
4694 2019-03-15  Tom Tromey  <tom@tromey.com>
4695
4696         * objfiles.h (struct objfile_per_bfd_storage)
4697         <demangled_hash_languages>: Now a bitset.
4698         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4699         (lookup_minimal_symbol): Update.
4700
4701 2019-03-15  Tom Tromey  <tom@tromey.com>
4702
4703         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4704         Don't return the symbol.
4705         * coffread.c (record_minimal_symbol): Use record_full.
4706
4707 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4708
4709         The MS-Windows port of ncurses fails to switch to a color pair if
4710         one or both of the colors are the implicit default colors.  This
4711         change records the default colors when TUI is initialized, and
4712         then specifies them explicitly when a color pair uses the default
4713         colors.  This allows color styling in TUI mode on MS-Windows.
4714
4715         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4716         ncurses_norm_attr.
4717         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4718         colors in ncurses_norm_attr.
4719         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4720         "none", replace it with the default color recorded in
4721         ncurses_norm_attr.
4722
4723 2019-03-14  Tom Tromey  <tromey@adacore.com>
4724
4725         * source-cache.h (class source_cache) <get_source_lines>: Return
4726         std::string.
4727         * source-cache.c (source_cache::extract_lines): Handle case where
4728         first_pos==npos.  Return std::string.
4729         (source_cache::get_source_lines): Update.
4730
4731 2019-03-14  Tom Tromey  <tromey@adacore.com>
4732
4733         * NEWS: Add item for "style sources" commands.
4734         * source-cache.c (source_cache::get_source_lines): Check
4735         source_styling.
4736         * cli/cli-style.c (source_styling): New global.
4737         (_initialize_cli_style): Add "style sources" commands.
4738         (show_style_sources): New function.
4739         * cli/cli-style.h (source_styling): Declare.
4740
4741 2019-03-14  Pedro Alves  <palves@redhat.com>
4742             Tom Tromey  <tromey@adacore.com>
4743
4744         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4745         * tui/tui-winsource.c (tui_refill_source_window): New function,
4746         from...
4747         (tui_horizontal_source_scroll): ... here.  Move some logic.
4748         * cli/cli-style.c (set_style_enabled): Notify new observable.
4749         * tui/tui-hooks.c (tui_redisplay_source): New function.
4750         (tui_attach_detach_observers): Attach or detach
4751         tui_redisplay_source.
4752         * observable.h (source_styling_changed): New observable.
4753         * observable.c: Define source_styling_changed observable.
4754
4755 2019-03-13  Tom Tromey  <tromey@adacore.com>
4756
4757         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4758         (i386_gnu_nat_target::store_registers): Update.
4759         * target-debug.h (target_debug_print_std_string): New macro.
4760         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4761         * windows-tdep.c (display_one_tib): Update.
4762         * tui/tui-stack.c (tui_make_status_line): Update.
4763         * top.c (print_inferior_quit_action): Update.
4764         * thread.c (thr_try_catch_cmd): Update.
4765         (add_thread_with_info): Update.
4766         (thread_target_id_str): Update.
4767         (thr_try_catch_cmd): Update.
4768         (thread_command): Update.
4769         (thread_find_command): Update.
4770         * record-btrace.c (record_btrace_target::info_record)
4771         (record_btrace_resume_thread, record_btrace_target::resume)
4772         (record_btrace_cancel_resume, record_btrace_step_thread)
4773         (record_btrace_target::wait, record_btrace_target::wait)
4774         (record_btrace_target::wait, record_btrace_target::stop): Update.
4775         * progspace.c (print_program_space): Update.
4776         * process-stratum-target.c
4777         (process_stratum_target::thread_address_space): Update.
4778         * linux-fork.c (linux_fork_mourn_inferior)
4779         (detach_checkpoint_command, info_checkpoints_command)
4780         (linux_fork_context): Update.
4781         (linux_fork_detach): Update.
4782         (class scoped_switch_fork_info): Update.
4783         (delete_checkpoint_command): Update.
4784         * infrun.c (follow_fork_inferior): Update.
4785         (follow_fork_inferior): Update.
4786         (proceed_after_vfork_done): Update.
4787         (handle_vfork_child_exec_or_exit): Update.
4788         (follow_exec): Update.
4789         (displaced_step_prepare_throw): Update.
4790         (displaced_step_restore): Update.
4791         (start_step_over): Update.
4792         (resume_1): Update.
4793         (clear_proceed_status_thread): Update.
4794         (proceed): Update.
4795         (print_target_wait_results): Update.
4796         (do_target_wait): Update.
4797         (context_switch): Update.
4798         (stop_all_threads): Update.
4799         (restart_threads): Update.
4800         (finish_step_over): Update.
4801         (handle_signal_stop): Update.
4802         (switch_back_to_stepped_thread): Update.
4803         (keep_going_pass_signal): Update.
4804         (print_exited_reason): Update.
4805         (normal_stop): Update.
4806         * inferior.c (inferior_pid_to_str): Change return type.
4807         (print_selected_inferior): Update.
4808         (add_inferior): Update.
4809         (detach_inferior): Update.
4810         * dummy-frame.c (fprint_dummy_frames): Update.
4811         * dcache.c (dcache_info_1): Update.
4812         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4813         (btrace_fetch, btrace_clear): Update.
4814         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4815         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4816         type.
4817         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4818         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4819         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4820         * gdbarch.c, gdbarch.h: Rebuild.
4821         * gdbarch.sh (core_pid_to_str): Change return type.
4822         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4823         return type.
4824         (windows_nat_target::pid_to_str): Change return type.
4825         (windows_delete_thread): Update.
4826         (windows_nat_target::attach): Update.
4827         (windows_nat_target::files_info): Update.
4828         * target-delegates.c: Rebuild.
4829         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4830         return type.
4831         (sol_thread_target::pid_to_str): Change return type.
4832         * remote.c (class remote_target) <pid_to_str>: Change return
4833         type.
4834         (remote_target::pid_to_str): Change return type.
4835         (extended_remote_target::attach, remote_target::remote_stop_ns)
4836         (remote_target::remote_notif_remove_queued_reply)
4837         (remote_target::push_stop_reply, remote_target::disable_btrace):
4838         Update.
4839         (extended_remote_target::attach): Update.
4840         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4841         type.
4842         (gdbsim_target::pid_to_str): Change return type.
4843         * ravenscar-thread.c (struct ravenscar_thread_target)
4844         <pid_to_str>: Change return type.
4845         (ravenscar_thread_target::pid_to_str): Change return type.
4846         * procfs.c (class procfs_target) <pid_to_str>: Change return
4847         type.
4848         (procfs_target::pid_to_str): Change return type.
4849         (procfs_target::attach): Update.
4850         (procfs_target::detach): Update.
4851         (procfs_target::fetch_registers): Update.
4852         (procfs_target::store_registers): Update.
4853         (procfs_target::wait): Update.
4854         (procfs_target::files_info): Update.
4855         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4856         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4857         return type.
4858         (nto_procfs_target::pid_to_str): Change return type.
4859         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4860         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4861         return type.
4862         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4863         (exit_lwp): Update.
4864         (attach_proc_task_lwp_callback, get_detach_signal)
4865         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4866         (linux_nat_target::resume, wait_lwp, stop_callback)
4867         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4868         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4869         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4870         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4871         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4872         type.
4873         (inf_ptrace_target::attach): Update.
4874         (inf_ptrace_target::files_info): Update.
4875         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4876         type.
4877         (go32_nat_target::pid_to_str): Change return type.
4878         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4879         (gnu_nat_target::wait): Update.
4880         (gnu_nat_target::wait): Update.
4881         (gnu_nat_target::resume): Update.
4882         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4883         (fbsd_nat_target::wait): Update.
4884         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4885         type.
4886         (darwin_nat_target::attach): Update.
4887         * corelow.c (class core_target) <pid_to_str>: Change return type.
4888         (core_target::pid_to_str): Change return type.
4889         * target.c (normal_pid_to_str): Change return type.
4890         (default_pid_to_str): Likewise.
4891         (target_pid_to_str): Change return type.
4892         (target_translate_tls_address): Update.
4893         (target_announce_detach): Update.
4894         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4895         return type.
4896         (bsd_uthread_target::pid_to_str): Change return type.
4897         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4898         type.
4899         (bsd_kvm_target::pid_to_str): Change return type.
4900         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4901         return type.
4902         (aix_thread_target::pid_to_str): Change return type.
4903         * target.h (struct target_ops) <pid_to_str>: Change return type.
4904         (target_pid_to_str, normal_pid_to_str): Likewise.
4905         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4906         type.
4907         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4908         type.
4909         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4910         return type.
4911         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4912         type.
4913         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4914         type.
4915         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4916         return type.
4917
4918 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4919
4920         * NEWS: Mention that the new default MI version is 3.  Mention
4921         changes to the output of commands and events that deal with
4922         multi-location breakpoints.
4923         * breakpoint.c: Include "mi/mi-out.h".
4924         (print_one_breakpoint): Change output syntax if using MI version
4925         >= 3.
4926         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4927         New.
4928         (mi_multi_location_breakpoint_output_fixed): New.
4929         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4930         (mi_cmd_fix_multi_location_breakpoint_output): New.
4931         (mi_multi_location_breakpoint_output_fixed): New.
4932         * mi/mi-cmds.c (mi_cmds): Register command
4933         -fix-multi-location-breakpoint-output.
4934         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4935         interpreter "mi".
4936
4937 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4938
4939         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4940         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4941         instantiate mi_ui_out based on interpreter name.
4942         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4943         * mi/mi-main.c (mi_load_progress): Likewise.
4944
4945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4946
4947         * NEWS: Combine separate "New targets" sections for 8.3.
4948
4949 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4950
4951         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4952         (ppcfbsd_init_abi): Install gdbarch
4953         "fetch_tls_load_module_address" and "get_thread_local_address"
4954         methods.
4955
4956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4957
4958         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4959         (riscv_fbsd_init_abi): Install gdbarch
4960         "fetch_tls_load_module_address" and "get_thread_local_address"
4961         methods.
4962
4963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4964
4965         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4966         (i386fbsd_init_abi): Install gdbarch
4967         "fetch_tls_load_module_address" and "get_thread_local_address"
4968         methods.
4969
4970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4971
4972         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4973         (amd64fbsd_init_abi): Install gdbarch
4974         "fetch_tls_load_module_address" and "get_thread_local_address"
4975         methods.
4976
4977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4978
4979         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4980         (struct fbsd_pspace_data): New type.
4981         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4982         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4983         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4984         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4985         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4986
4987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4988
4989         * gdbtypes.c (lookup_struct_elt): New function.
4990         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4991         * gdbtypes.h (struct struct_elt): New type.
4992         (lookup_struct_elt): New prototype.
4993
4994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4995
4996         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4997         remove disabled code block.
4998
4999 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5000
5001         * gdbarch.sh (get_thread_local_address): New method.
5002         * gdbarch.h, gdbarch.c: Regenerate.
5003         * target.c (target_translate_tls_address): Use
5004         gdbarch_get_thread_local_address if present instead of
5005         target::get_thread_local_address.
5006
5007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5008
5009         * target.h (target::get_thread_local_address): Update comment.
5010
5011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5012
5013         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5014         objfile->separate_debug_objfile_backlink if not NULL.
5015
5016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5017
5018         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5019         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5020         (amd64bsd_store_inferior_registers): Likewise.
5021         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5022         Enable segment base registers.
5023         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5024         PT_GETFSBASE and PT_GETGSBASE.
5025         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5026         PT_SETGSBASE.
5027         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5028         segment base registers.
5029         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5030
5031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5032
5033         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5034         Update calls to i386_target_description to add 'segments'
5035         parameter.
5036         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5037         add segment base registers.
5038         * arch/i386.c (i386_create_target_description): Add 'segments'
5039         parameter to enable segment base registers.
5040         * arch/i386.h (i386_create_target_description): Likewise.
5041         * features/i386/32bit-segments.xml: New file.
5042         * features/i386/32bit-segments.c: Generate.
5043         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5044         call to i386_target_description to add 'segments' parameter.
5045         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5046         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5047         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5048         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5049         if feature is present.
5050         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5051         Add 'segments' parameter to call to i386_target_description.
5052         (i386_target_description): Add 'segments' parameter to enable
5053         segment base registers.
5054         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5055         to call to i386_target_description.
5056         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5057         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5058         Define I386_NUM_REGS.
5059         (i386_target_description): Add 'segments' parameter to enable
5060         segment base registers.
5061
5062 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5063
5064         PR/24325
5065         * source-cache.c: #undef open and close, to avoid unresolved
5066         externals during linking.
5067
5068 2019-03-12  Tom Tromey  <tromey@adacore.com>
5069
5070         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5071         const.  Add initializers.
5072         (_initialize_remote): Don't initialize ptid globals.
5073
5074 2019-03-12  Pedro Alves  <palves@redhat.com>
5075
5076         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5077
5078 2019-03-12  Pedro Alves  <palves@redhat.com>
5079
5080         * cp-name-parser.y (main): Remove unused 'len' variable.
5081
5082 2019-03-12  Tom Tromey  <tromey@adacore.com>
5083
5084         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5085         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5086
5087 2019-03-12  Tom Tromey  <tromey@adacore.com>
5088
5089         * linux-nat.c (iterate_over_lwps): Update.
5090         (stop_callback): Remove parameter.
5091         (stop_wait_callback, detach_callback, resume_set_callback)
5092         (select_singlestep_lwp_callback, set_ignore_sigint)
5093         (status_callback, resumed_callback, resume_clear_callback)
5094         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5095         data parameter.
5096         (linux_nat_target::detach, linux_nat_target::resume)
5097         (linux_stop_and_wait_all_lwps, select_event_lwp)
5098         (linux_nat_filter_event, linux_nat_wait_1)
5099         (linux_nat_target::kill, linux_nat_target::stop)
5100         (linux_nat_target::stop): Update.
5101         (linux_nat_resume_callback): Change type.
5102         (resume_stopped_resumed_lwps, count_events_callback)
5103         (select_event_lwp_callback): Likewise.
5104         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5105         * arm-linux-nat.c (struct update_registers_data): Remove.
5106         (update_registers_callback): Change type.
5107         (arm_linux_insert_hw_breakpoint1): Update.
5108         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5109         parameter.
5110         (x86_linux_dr_set_addr): Update.
5111         (x86_linux_dr_set_control): Update.
5112         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5113         (iterate_over_lwps): Use gdb::function_view.
5114         * nat/aarch64-linux-hw-point.c (struct
5115         aarch64_dr_update_callback_param): Remove.
5116         (debug_reg_change_callback): Change type.
5117         (aarch64_notify_debug_reg_change): Update.
5118         * s390-linux-nat.c (s390_refresh_per_info): Update.
5119
5120 2019-03-11  Tom Tromey  <tromey@adacore.com>
5121
5122         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5123         redundant assignment to "this_cu".
5124
5125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5126
5127         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5128
5129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5130
5131         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5132         from...
5133         (rank_one_type): ... this.
5134
5135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5136
5137         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5138         from...
5139         (rank_one_type): ... this.
5140
5141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5142
5143         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5144         from...
5145         (rank_one_type): ... this.
5146
5147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5148
5149         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5150         from...
5151         (rank_one_type): ... this.
5152
5153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5154
5155         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5156         from...
5157         (rank_one_type): ... this.
5158
5159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5160
5161         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5162         from...
5163         (rank_one_type): ... this.
5164
5165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5166
5167         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5168         from...
5169         (rank_one_type): ... this.
5170
5171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5172
5173         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5174         from...
5175         (rank_one_type): ... this.
5176
5177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5178
5179         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5180         from...
5181         (rank_one_type): ... this.
5182
5183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5184
5185         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5186         from...
5187         (rank_one_type): ... this.
5188
5189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5190
5191         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5192         from...
5193         (rank_one_type): ... this.
5194
5195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5196
5197         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5198         from...
5199         (rank_one_type): ... this.
5200
5201 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5202
5203         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5204         inferior-events' shows the example events.
5205
5206 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5207
5208         Support styling on native MS-Windows console
5209
5210         PR/24315
5211         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5212         on MS-Windows if $TERM is not defined.
5213
5214         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5215
5216         * posix-hdep.c (gdb_console_fputs):
5217         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5218         functions.
5219         * ui-file.h (gdb_console_fputs): Add prototype.
5220
5221         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5222         back to fputs only if the former returns zero.
5223
5224 2019-03-07  Tom Tromey  <tom@tromey.com>
5225
5226         * symmisc.c (print_symbol_bcache_statistics): Update.
5227         (print_objfile_statistics): Update.
5228         * symfile.c (allocate_symtab): Update.
5229         * stabsread.c: Don't include bcache.h.
5230         * psymtab.h (struct psymbol_bcache): Don't declare.
5231         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5232         (psymbol_bcache_init, psymbol_bcache_free)
5233         (psymbol_bcache_get_bcache): Don't declare.
5234         * psymtab.c (struct psymbol_bcache): Remove.
5235         (psymtab_storage::psymtab_storage): Update.
5236         (psymtab_storage::~psymtab_storage): Update.
5237         (psymbol_bcache_init, psymbol_bcache_free)
5238         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5239         (add_psymbol_to_bcache): Update.
5240         (allocate_psymtab): Update.
5241         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5242         macro_cache>: No longer pointers.
5243         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5244         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5245         * macrotab.c (macro_bcache): Update.
5246         * macroexp.c: Don't include bcache.h.
5247         * gdbtypes.c (check_types_worklist): Update.
5248         (types_deeply_equal): Remove TRY/CATCH.  Update.
5249         * elfread.c (elf_symtab_read): Update.
5250         * dwarf2read.c: Don't include bcache.h.
5251         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5252         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5253         (print_bcache_statistics, bcache_memory_used): Don't declare.
5254         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5255         methods.  Rename all data members.
5256         * bcache.c (struct bcache): Move to bcache.h.
5257         (bcache::expand_hash_table): Rename from expand_hash_table.
5258         (bcache): Remove.
5259         (bcache::insert): Rename from bcache_full.
5260         (bcache::compare): Rename from bcache_compare.
5261         (bcache_xmalloc): Remove.
5262         (bcache::~bcache): Rename from bcache_xfree.
5263         (bcache::print_statistics): Rename from print_bcache_statistics.
5264         (bcache::memory_used): Rename from bcache_memory_used.
5265
5266 2019-03-07  Pedro Alves  <palves@redhat.com>
5267
5268         * infrun.c (normal_stop): Also check for
5269         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5270
5271 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * f-lang.c (value_from_host_double): Moved to...
5274         * value.c (value_from_host_double): ...here.
5275         * value.h (value_from_host_double): Declare.
5276         * guile/scm-math.c (vlscm_convert_typed_number): Use
5277         value_from_host_double.
5278         (vlscm_convert_number): Likewise.
5279         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5280         * python/py-value.c (convert_value_from_python): Likewise.
5281
5282 2019-03-06  Tom Tromey  <tom@tromey.com>
5283
5284         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5285
5286 2019-03-06  Tom Tromey  <tom@tromey.com>
5287
5288         * utils.h (free_current_contents): Don't declare.
5289         * utils.c (free_current_contents): Remove.
5290
5291 2019-03-06  Tom Tromey  <tom@tromey.com>
5292
5293         * top.c (quit_force): Update.
5294         * main.c (captured_command_loop): Update.
5295         * common/new-op.c (operator new): Update.
5296         * common/common-exceptions.c (struct catcher)
5297         <save_cleanup_chain>: Remove member.
5298         (exceptions_state_mc_init): Update.
5299         (exception_try_scope_entry): Return nullptr.
5300         (exception_try_scope_exit, exception_rethrow)
5301         (throw_exception_sjlj, throw_exception_cxx): Update.
5302         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5303         (all_cleanups, do_cleanups, discard_cleanups)
5304         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5305         (restore_cleanups, restore_final_cleanups): Don't declare.
5306         (do_final_cleanups): Remove parameter.
5307         * common/cleanups.c (cleanup_chain, make_cleanup)
5308         (make_cleanup_dtor, all_cleanups, do_cleanups)
5309         (discard_my_cleanups, discard_cleanups)
5310         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5311         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5312         (null_cleanup): Remove.
5313         (do_final_cleanups): Remove parameter.
5314
5315 2019-03-06  Tom Tromey  <tom@tromey.com>
5316
5317         * remote.c (remote_target::remote_parse_stop_reply): Use
5318         unique_xmalloc_ptr.
5319
5320 2019-03-06  Tom Tromey  <tom@tromey.com>
5321
5322         * stabsread.c (struct stabs_field_info): Rename from field_info.
5323         <list, fnlist>: Add initializers.
5324         <obstack>: New member.
5325         (read_member_functions, read_struct_fields, read_baseclasses):
5326         Allocate on obstack.  Don't use cleanups.
5327         (read_one_struct_field, read_member_functions, read_struct_fields)
5328         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5329         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5330         (read_struct_type): Update.
5331
5332 2019-03-06  Tom Tromey  <tom@tromey.com>
5333
5334         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5335         * common/filestuff.h (make_cleanup_close): Don't declare.
5336         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5337         Remove.
5338
5339 2019-03-06  Tom Tromey  <tom@tromey.com>
5340
5341         * solib-aix.c: Use make_scope_exit.
5342
5343 2019-03-06  Tom Tromey  <tom@tromey.com>
5344
5345         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5346         Use make_scope_exit.
5347
5348 2019-03-06  Tom Tromey  <tom@tromey.com>
5349
5350         * solib-svr4.c (disable_probes_interface): Remove parameter.
5351         (svr4_handle_solib_event): Use make_scope_exit.
5352
5353 2019-03-06  Tom Tromey  <tom@tromey.com>
5354
5355         * remote.c (struct stop_reply_deleter): Remove.
5356         (stop_reply_up): Update.
5357         (struct stop_reply): Derive from notif_event.  Don't typedef.
5358         <regcache>: Now a std::vector.
5359         (stop_reply_xfree): Remove.
5360         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5361         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5362         (remote_target::discard_pending_stop_replies): Use delete.
5363         (remote_target::remote_parse_stop_reply): Update.
5364         (remote_target::process_stop_reply): Update.
5365         * remote-notif.h (struct notif_event): Add virtual destructor.
5366         Remove "dtr" member.
5367         (struct notif_client) <alloc_event>: Return a unique_ptr.
5368         (notif_event_xfree): Don't declare.
5369         (notif_event_up): New typedef.
5370         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5371         (notif_event_xfree, do_notif_event_xfree): Remove.
5372         (remote_notif_state_xfree): Update.
5373
5374 2019-03-06  Tom Tromey  <tom@tromey.com>
5375
5376         * infrun.c (displaced_step_clear_cleanup): Now a
5377         forward_scope_exit type.
5378         (displaced_step_prepare_throw): Update.
5379         (displaced_step_fixup): Update.
5380
5381 2019-03-06  Tom Tromey  <tom@tromey.com>
5382
5383         * inferior.h (class inferior): Update comment.
5384         * gdbthread.h (class thread_info): Update comment.
5385
5386 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5387             Tom Tromey  <tom@tromey.com>
5388
5389         * stabsread.h (struct stab_section_list): Remove.
5390         (coffstab_build_psymtabs): Update.
5391         * dbxread.c (symbuf_sections): Now a std::vector.
5392         (sect_idx): New global.
5393         (fill_symbuf): Update.
5394         (coffstab_build_psymtabs): Change type of stabsects parameter.
5395         Update.
5396         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5397         std::vector.
5398         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5399         (coff_locate_sections): Update.
5400         (coff_symfile_read): Remove cleanups.  Update.
5401         (init_stringtab): Add storage parameter.
5402         (free_stringtab, free_stringtab_cleanup): Remove.
5403         (init_lineno): Add storage parameter.
5404         (free_linetab, free_linetab_cleanup): Remove.
5405
5406 2019-03-06  Pedro Alves  <palves@redhat.com>
5407
5408         * linux-fork.c (fork_info::clobber_regs): Delete.
5409         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5410         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5411         comment.  Adjust.
5412         (scoped_switch_fork_info::scoped_switch_fork_info)
5413         (checkpoint_command, linux_fork_context): Adjust
5414         fork_save_infrun_state calls.
5415
5416 2019-03-06  Pedro Alves  <palves@redhat.com>
5417
5418         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5419         (inf_has_multiple_threads): Return 'bool' and rewrite using
5420         inferior_info::threads().
5421
5422 2019-03-06  Pedro Alves  <palves@redhat.com>
5423
5424         * linux-fork.c: Include <list>.
5425         (fork_list): Now a std::list instance.
5426         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5427         (forks_exist_p, find_last_fork): Adjust.
5428         (new_fork): Delete.
5429         (one_fork_p): New.
5430         (add_fork): Adjust.
5431         (free_fork): Delete, folded into fork_info::~fork_info().
5432         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5433         Adjust.
5434         (init_fork_list): Delete.
5435         (linux_fork_killall, linux_fork_mourn_inferior)
5436         (linux_fork_detach, info_checkpoints_command): Adjust.
5437         (_initialize_linux_fork): No longer call init_fork_list.
5438
5439 2019-03-06  Pedro Alves  <palves@redhat.com>
5440
5441         * linux-fork.c (new_fork): New, split out of ...
5442         (add_fork): ... this.  Return void.  Move "first fork" special
5443         case from here, to ...
5444         (checkpoint_command): ... here.
5445         * linux-linux.h (add_fork): Return void.
5446
5447 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5448
5449         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5450
5451 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5452             Chris January  <chris.january@arm.com>
5453             David Lecomber  <david.lecomber@arm.com>
5454
5455         * f-exp.y: New token, UNOP_INTRINSIC.
5456         (exp): New pattern using UNOP_INTRINSIC token.
5457         (f77_keywords): Add 'abs' keyword.
5458         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5459         (value_from_host_double): New function.
5460         (evaluate_subexp_f): Support UNOP_ABS.
5461
5462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5463
5464         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5465         types.
5466
5467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5468
5469         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5470         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5471         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5472
5473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5474
5475         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5476
5477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5478             Chris January  <chris.january@arm.com>
5479
5480         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5481         * f-exp.y: Define 'KIND' token.
5482         (exp): New pattern for KIND expressions.
5483         (ptype): Handle types with a kind extension.
5484         (direct_abs_decl): Extend to spot kind extensions.
5485         (f77_keywords): Add 'kind' to the list.
5486         (push_kind_type): New function.
5487         (convert_to_kind_type): New function.
5488         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5489         * parse.c (operator_length_standard): Likewise.
5490         * parser-defs.h (enum type_pieces): Add tp_kind.
5491         * std-operator.def: Add UNOP_KIND.
5492
5493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5494
5495         * f-exp.y (f_parse): Set yydebug.
5496
5497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5498
5499         * f-lang.c (evaluate_subexp_f): New function.
5500         (exp_descriptor_f): New global.
5501         (f_language_defn): Use exp_descriptor_f instead of
5502         exp_descriptor_standard.
5503
5504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5505
5506         * f-exp.y (struct token): Add comments.
5507         (dot_ops): Remove uppercase versions and the end marker.
5508         (f77_keywords): Likewise.
5509         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5510         entries in the dot_ops array are case insensitive, and use
5511         strncasecmp to compare strings.  Also some whitespace cleanup in
5512         this area.  Similar for the f77_keywords array, except entries in
5513         this list might be case sensitive.
5514
5515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5516
5517         * f-exp.y (struct f77_boolean_val): Add comments.
5518         (boolean_values): Remove uppercase versions, and end marker.
5519         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5520         and use strncasecmp to achieve case insensitivity.  Additionally,
5521         perform whitespace cleanup around this code.
5522
5523 2019-03-06  Tom Tromey  <tromey@adacore.com>
5524
5525         * remote-sim.c (gdbsim_target_open): Use result of
5526         gdb_argv::release.
5527
5528 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5529         Dirk Schubert  <dirk.schubert@arm.com>
5530         Chris January  <chris.january@arm.com>
5531
5532         * eval.c (evaluate_subexp_standard): Call Fortran argument
5533         wrapping logic.
5534         * f-lang.c (struct value): A value which can be passed into a
5535         Fortran function call.
5536         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5537         where appropriate.
5538         (struct type): Value ready for a Fortran function call.
5539         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5540         is needed.
5541         * f-lang.h (fortran_argument_convert): Declaration.
5542         (fortran_preserve_arg_pointer): Declaration.
5543         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5544
5545 2019-03-05  Tom Tromey  <tromey@adacore.com>
5546
5547         * python/py-prettyprint.c (print_string_repr): Remove #if.
5548         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5549
5550 2019-03-05  Tom Tromey  <tromey@adacore.com>
5551
5552         * target.c (the_dummy_target): Move later.  Change type to
5553         "dummy_target".
5554         (initialize_targets): Don't initialize the_dummy_target.
5555
5556 2019-03-05  Tom Tromey  <tromey@adacore.com>
5557
5558         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5559         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5560
5561 2019-03-05  Tom Tromey  <tromey@adacore.com>
5562
5563         * windows-nat.c (windows_nat_target::attach)
5564         (windows_nat_target::detach): Don't call gdb_flush.
5565         * valprint.c (generic_val_print, val_print, val_print_string):
5566         Don't call gdb_flush.
5567         * utils.c (defaulted_query): Don't call gdb_flush.
5568         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5569         * target.c (target_announce_detach): Don't call gdb_flush.
5570         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5571         * remote.c (extended_remote_target::attach): Don't call
5572         gdb_flush.
5573         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5574         * printcmd.c (do_examine): Don't call gdb_flush.
5575         (info_display_command): Don't call gdb_flush.
5576         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5577         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5578         * memattr.c (info_mem_command): Don't call gdb_flush.
5579         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5580         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5581         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5582         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5583         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5584         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5585         (gnu_nat_target::detach): Don't call gdb_flush.
5586         * f-valprint.c (f_val_print): Don't call gdb_flush.
5587         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5588         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5589         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5590         gdb_flush.
5591         * c-valprint.c (c_val_print): Don't call gdb_flush.
5592         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5593
5594 2019-03-05  Tom Tromey  <tromey@adacore.com>
5595
5596         * varobj.c (update_dynamic_varobj_children): Update.
5597         (install_default_visualizer): Use reset, not release.
5598         * value.c (set_internalvar): Update.
5599         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5600         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5601         ATTRIBUTE_UNUSED_RESULT.
5602
5603 2019-03-05  Tom Tromey  <tromey@adacore.com>
5604
5605         * remote.c (class scoped_remote_fd) <release>: Add
5606         ATTRIBUTE_UNUSED_RESULT.
5607
5608 2019-03-05  Tom Tromey  <tromey@adacore.com>
5609
5610         * macroexp.c (struct macro_buffer) <release>: Add
5611         ATTRIBUTE_UNUSED_RESULT.
5612
5613 2019-03-05  Tom Tromey  <tromey@adacore.com>
5614
5615         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5616         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5617         ATTRIBUTE_UNUSED_RESULT.
5618
5619 2019-03-05  Tom Tromey  <tromey@adacore.com>
5620
5621         * common/scoped_fd.h (class scoped_fd) <release>: Add
5622         ATTRIBUTE_UNUSED_RESULT.
5623
5624 2019-03-05  Tom Tromey  <tromey@adacore.com>
5625
5626         * parser-defs.h (struct parser_state) <release>: Add
5627         ATTRIBUTE_UNUSED_RESULT.
5628
5629 2019-03-05  Tom Tromey  <tromey@adacore.com>
5630
5631         * utils.h (class gdb_argv) <release>: Add
5632         ATTRIBUTE_UNUSED_RESULT.
5633         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5634
5635 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5636
5637         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5638         for-loop range, to avoid compiler warnings.
5639
5640         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5641         avoid compiler warnings about unused variables.
5642
5643         * NEWS: Mention end of support for native debugging on MS-Windows
5644         before XP.
5645
5646         PR gdb/24292
5647         * common/netstuff.c:
5648         * gdbserver/gdbreplay.c
5649         * gdbserver/remote-utils.c:
5650         * ser-tcp.c:
5651         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5652         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5653         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5654         'getaddrinfo' and 'freeaddrinfo' were not available before
5655         Windows XP, and mingw.org's MinGW headers by default define
5656         _WIN32_WINNT to 0x500.
5657
5658 2019-03-01  Gary Benson <gbenson@redhat.com>
5659
5660         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5661
5662 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5663             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5664
5665         PR gdb/8527
5666         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5667         set_sigint_trap, clear_sigint_trap.
5668
5669 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5670
5671         * target.c (target_detach): Clear the regcache and the
5672         frame cache.
5673
5674 2019-02-27  Pedro Alves  <palves@redhat.com>
5675
5676         * utils.c (set_screen_size): When we cap the height/width sizes,
5677         tweak the corresponding command variable to show "unlimited":
5678
5679 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5680             Pedro Alves  <palves@redhat.com>
5681
5682         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5683         before calling rl_set_screen_size.
5684
5685 2019-02-27  Tom Tromey  <tromey@adacore.com>
5686
5687         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5688         define.
5689         * python/py-value.c: Remove Python 2.4 workaround.
5690         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5691         workaround.
5692         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5693         Python 2.4 workaround.
5694         * python/python-internal.h: Remove Python 2.4 comment.
5695         (Py_ssize_t): Don't define.
5696         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5697         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5698         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5699         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5700         * python/python.c (do_start_initialization): Remove Python 2.4
5701         workaround.
5702         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5703         (print_children): Remove Python 2.4 workaround.
5704         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5705         workaround.
5706         (CHARBUFFERPROC_NAME): Remove.
5707         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5708         Python 2.4 workaround.
5709
5710 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5711
5712         * NEWS: Note minimum Python version.
5713
5714 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5715
5716         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5717         code from these functions.  Remove corresponding ifdefs.  Use
5718         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5719         Remove gotos and target of gotos.
5720         (infpy_search_memory): Likewise.
5721
5722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5723
5724         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5725         (hppa_gdbarch_init): Don't register deleted functions with
5726         gdbarch.
5727
5728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5729
5730         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5731         (h8300_unwind_sp): Delete.
5732         (h8300_dummy_id): Delete.
5733         (h8300_gdbarch_init): Don't register deleted functions with
5734         gdbarch.
5735
5736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5737
5738         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5739         (ft32_unwind_pc): Delete.
5740         (ft32_unwind_sp): Delete.
5741         (ft32_gdbarch_init): Don't register deleted functions with
5742         gdbarch.
5743
5744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5745
5746         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5747         (frv_unwind_pc): Delete.
5748         (frv_unwind_sp): Delete.
5749         (frv_gdbarch_init): Don't register deleted functions with
5750         gdbarch.
5751
5752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5753
5754         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5755         (riscv_unwind_pc): Delete.
5756         (riscv_unwind_sp): Delete.
5757         (riscv_gdbarch_init): Don't register deleted functions with
5758         gdbarch.
5759
5760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5761
5762         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5763         (csky_unwind_pc): Delete.
5764         (csky_unwind_sp): Delete.
5765         (csky_gdbarch_init): Don't register deleted functions with
5766         gdbarch.
5767
5768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5769
5770         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5771         (cris_unwind_pc): Delete.
5772         (cris_unwind_sp): Delete.
5773         (cris_gdbarch_init): Don't register deleted functions with
5774         gdbarch.
5775
5776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5777
5778         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5779         (bfin_unwind_pc): Delete.
5780         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5781
5782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5785         (arm_unwind_pc): Delete.
5786         (arm_unwind_sp): Delete.
5787         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5788
5789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5790
5791         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5792         (arc_unwind_pc): Delete.
5793         (arc_unwind_sp): Delete.
5794         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5795
5796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5797
5798         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5799         (alpha_unwind_pc): Delete.
5800         (alpha_gdbarch_init): Don't register deleted functions with
5801         gdbarch.
5802
5803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5804
5805         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5806         (aarch64_unwind_pc): Delete.
5807         (aarch64_unwind_sp): Delete.
5808         (aarch64_gdbarch_init): Don't register deleted functions with
5809         gdbarch.
5810
5811 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5812
5813         * gdbtypes.c (type_align): Don't consider static members when
5814         computing structure alignment.
5815
5816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5817
5818         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5819         return 0 for other types.
5820         * arch-utils.c (default_type_align): Always return 0.
5821         * gdbarch.h: Regenerate.
5822         * gdbarch.sh (type_align): Extend comment.
5823         * gdbtypes.c (type_align): Add additional comments, always call
5824         gdbarch_type_align before applying the default rules.
5825         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5826         generic code will then apply a suitable default.
5827         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5828         types, return 0 for other types.
5829
5830 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5831
5832         * NEWS: Create a new section for the next release branch.
5833         Rename the section of the current branch, now that it has
5834         been cut.
5835
5836 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5837
5838         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5839         * version.in: Bump version to 8.3.50.DATE-git.
5840
5841 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5842
5843         * aix-thread.c (ptid_cmp): Remove unused variable.
5844         (get_signaled_thread): Likewise.
5845         (store_regs_user_thread): Likewise.
5846         (store_regs_kernel_thread): Likewise.
5847         (fetch_regs_kernel_thread): Remove shadowed variable.
5848
5849 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5850
5851         * features/riscv/32bit-cpu.xml: Add register numbers.
5852         * features/riscv/32bit-fpu.c: Regenerate.
5853         * features/riscv/32bit-fpu.xml: Add register numbers.
5854         * features/riscv/64bit-cpu.xml: Add register numbers.
5855         * features/riscv/64bit-fpu.c: Regenerate.
5856         * features/riscv/64bit-fpu.xml: Add register numbers.
5857
5858 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5859
5860         * NEWS: Mention two argument form of gdb.Value constructor.
5861         * python/py-value.c (convert_buffer_and_type_to_value): New
5862         function.
5863         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5864         Add support for handling an optional second argument.  Call
5865         convert_buffer_and_type_to_value as appropriate.
5866         * python/python-internal.h (Py_buffer_deleter): New struct.
5867         (Py_buffer_up): New typedef.
5868
5869 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5870
5871         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5872         instead of releasing ownership.
5873
5874 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5875
5876         * dwarf2read.c (open_and_init_dwp_file): Call
5877         elf_numsections instead of bfd_count_sections to initialize
5878         dwp_file->num_sections.
5879
5880 2019-02-25  Tom Tromey  <tromey@adacore.com>
5881
5882         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5883
5884 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5885
5886         * gcore.in: Add '--readnever' option when invoking GDB.
5887
5888 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5889
5890         * MAINTAINERS: Update my email address.
5891
5892 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5893
5894         * build-id.c (build_id_to_debug_bfd_1): New function.
5895         (build_id_to_debug_bfd): Look for separate debug file in
5896         sysroot.
5897
5898 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5899
5900         * gdbarch.sh: Update the copyright year range that is placed into
5901         generated files.
5902
5903 2019-02-22  Keith Seitz  <keiths@redhat.com>
5904
5905         PR symtab/23853
5906         * linespec.c (create_sals_line_offset): Search for the default
5907         symtab's filename instead of its fullname.
5908
5909 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5910
5911         * NEWS: Update style defaults.
5912
5913 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5914
5915         * main.c (captured_main_1): Disable styling in batch mode.
5916
5917 2019-02-20  Tom Tromey  <tom@tromey.com>
5918
5919         * symtab.c (symtab_symbol_info): Fix typos.
5920
5921 2019-02-20  Tom Tromey  <tromey@adacore.com>
5922
5923         * findcmd.c (_initialize_mem_search): Use upper case for
5924         metasyntactic variables.
5925
5926 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5927
5928         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5929         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5930
5931 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5932
5933         * top.h (source_file_name): Change to std::string.
5934         * top.c (source_file_name): Likewise.
5935         (command_line_input): Adjust.
5936         * cli/cli-script.c (script_from_file): Adjust.
5937
5938 2019-02-19  Tom Tromey  <tromey@adacore.com>
5939
5940         * ravenscar-thread.c
5941         (ravenscar_thread_target::update_thread_list): Don't call
5942         ada_build_task_list.
5943         * ada-lang.h (ada_build_task_list): Don't declare.
5944         * ada-tasks.c (struct ada_tasks_inferior_data)
5945         <task_list_valid_p>: Now bool.
5946         (read_known_tasks, ada_task_list_changed)
5947         (ada_tasks_invalidate_inferior_data): Update.
5948         (read_known_tasks_array): Return bool.
5949         (read_known_tasks_list): Likewise.
5950         (read_known_tasks): Return void.
5951         (ada_build_task_list): Now static.
5952
5953 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5956         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5957
5958 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5959
5960         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5961         variant for ada_tasks_pspace_data_handle and
5962         ada_tasks_inferior_data_handle.
5963         (ada_tasks_pspace_data_cleanup): New function.
5964         (ada_tasks_inferior_data_cleanup): New function.
5965
5966 2019-02-17  Tom Tromey  <tom@tromey.com>
5967
5968         * macrotab.h (macro_source_fullname): Return a std::string.
5969         * macrotab.c (macro_include, check_for_redefinition)
5970         (macro_undef, macro_lookup_definition, foreach_macro)
5971         (foreach_macro_in_scope): Update.
5972         (macro_source_fullname): Return a std::string.
5973         * macrocmd.c (show_pp_source_pos): Update.
5974
5975 2019-02-17  Tom Tromey  <tom@tromey.com>
5976
5977         * macrocmd.c (show_pp_source_pos): Style the file names.
5978
5979 2019-02-17  Tom Tromey  <tom@tromey.com>
5980
5981         PR tui/24197:
5982         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5983
5984 2019-02-17  Tom Tromey  <tom@tromey.com>
5985
5986         * ada-lang.c (user_select_syms): Use filtered printing.
5987         * utils.c (wrap_style): New global.
5988         (desired_style): Remove.
5989         (emit_style_escape): Add stream parameter.
5990         (set_output_style, reset_terminal_style, prompt_for_continue):
5991         Update.
5992         (flush_wrap_buffer): Only flush gdb_stdout.
5993         (wrap_here): Set wrap_style.
5994         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5995         treat escape sequences as a character.  Change when wrap buffer is
5996         flushed.
5997         (fputs_styled): Do not set the output style when the default is
5998         requested.
5999         * ui-style.h (struct ui_file_style) <is_default>: New method.
6000         * source.c (print_source_lines_base): Emit escape sequences in one
6001         piece.
6002
6003 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6004
6005         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6006         integers and enumeration types.
6007
6008 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6009
6010         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6011         instead of lookup_symbol_in_language
6012         (do_exact_match): New function.
6013         (ada_get_symbol_name_matcher): Return do_exact_match when
6014         doing a verbatim match.
6015
6016 2019-02-15  Tom Tromey  <tromey@adacore.com>
6017
6018         * ravenscar-thread.c (ravenscar_thread_target::resume)
6019         (ravenscar_thread_target::wait): Special case wildcard requests.
6020
6021 2019-02-15  Tom Tromey  <tromey@adacore.com>
6022
6023         * ravenscar-thread.c (base_ptid): Remove.
6024         (struct ravenscar_thread_target) <close>: New method.
6025         <m_base_ptid>: New member.
6026         <update_inferior_ptid, active_task, task_is_currently_active,
6027         runtime_initialized>: Declare methods.
6028         <ravenscar_thread_target>: Add constructor.
6029         (ravenscar_thread_target::task_is_currently_active)
6030         (ravenscar_thread_target::update_inferior_ptid)
6031         (ravenscar_runtime_initialized): Rename.  Now methods.
6032         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6033         (ravenscar_thread_target::update_thread_list): Update.
6034         (ravenscar_thread_target::active_task): Now method.
6035         (ravenscar_thread_target::store_registers)
6036         (ravenscar_thread_target::prepare_to_store)
6037         (ravenscar_thread_target::prepare_to_store)
6038         (ravenscar_thread_target::mourn_inferior): Update.
6039         (ravenscar_inferior_created): Use "new" to create target.
6040         (ravenscar_thread_target::get_ada_task_ptid): Update.
6041         (_initialize_ravenscar): Don't initialize base_ptid.
6042         (ravenscar_ops): Remove global.
6043
6044 2019-02-15  Tom Tromey  <tromey@adacore.com>
6045
6046         * target.h (push_target): Declare new overload.
6047         * target.c (push_target): New overload, taking an rvalue reference.
6048         * remote.c (remote_target::open_1): Use push_target overload.
6049         * corelow.c (core_target_open): Use push_target overload.
6050
6051 2019-02-15  Tom Tromey  <tromey@adacore.com>
6052
6053         * ravenscar-thread.c (is_ravenscar_task)
6054         (ravenscar_task_is_currently_active): Return bool.
6055         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6056         (_initialize_ravenscar): Remove "(void)".
6057         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6058         Return bool.
6059
6060 2019-02-15  Tom Tromey  <tromey@adacore.com>
6061
6062         * ravenscar-thread.c (ravenscar_runtime_initializer)
6063         (has_ravenscar_runtime, get_running_thread_id)
6064         (ravenscar_thread_target::resume): Fix indentation.
6065
6066 2019-02-15  Tom Tromey  <tromey@adacore.com>
6067
6068         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6069         from ravenscar_arch_ops.
6070         (sparc_ravenscar_ops::fetch_registers)
6071         (sparc_ravenscar_ops::store_registers): Now methods.
6072         (sparc_ravenscar_prepare_to_store): Remove.
6073         (sparc_ravenscar_ops): Redefine.
6074         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6075         methods and destructor.  Remove members.
6076         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6077         (ravenscar_thread_target::store_registers)
6078         (ravenscar_thread_target::prepare_to_store): Update.
6079         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6080         Remove.
6081         (struct ppc_ravenscar_powerpc_ops): Derive from
6082         ravenscar_arch_ops.
6083         (ppc_ravenscar_powerpc_ops::fetch_registers)
6084         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6085         (ppc_ravenscar_powerpc_ops): Redefine.
6086         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6087         (ppc_ravenscar_e500_ops::fetch_registers)
6088         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6089         (ppc_ravenscar_e500_ops): Redefine.
6090         * aarch64-ravenscar-thread.c
6091         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6092         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6093         (aarch64_ravenscar_fetch_registers)
6094         (aarch64_ravenscar_store_registers): Now methods.
6095         (aarch64_ravenscar_ops): Redefine.
6096
6097 2019-02-15  Tom Tromey  <tromey@adacore.com>
6098
6099         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6100         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6101         (ravenscar_thread_target::stopped_by_watchpoint)
6102         (ravenscar_thread_target::stopped_data_address)
6103         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6104
6105 2019-02-15  Tom Tromey  <tromey@adacore.com>
6106
6107         * ravenscar-thread.c: Fix some typos.
6108
6109 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6110             Tom Tromey  <tromey@adacore.com>
6111
6112         * ada-lang.c (ada_exception_sal): Change addr_string to a
6113         std::string.
6114         (create_ada_exception_catchpoint): Update.
6115
6116 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6117             Tom Tromey  <tromey@adacore.com>
6118
6119         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6120         (bp_location_ops): Remove.
6121         (base_breakpoint_allocate_location): Update.
6122         (free_bp_location): Update.
6123         * ada-lang.c (class ada_catchpoint_location)
6124         <ada_catchpoint_location>: Remove ops parameter.
6125         (ada_catchpoint_location_dtor): Remove.
6126         (ada_catchpoint_location_ops): Remove.
6127         (allocate_location_exception): Update.
6128         * breakpoint.h (struct bp_location_ops): Remove.
6129         (class bp_location) <bp_location>: Remove bp_location_ops
6130         parameter.
6131         <~bp_location>: Add destructor.
6132         <ops>: Remove.
6133
6134 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6135             Pedro Alves  <palves@redhat.com>
6136
6137         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6138         'PATH_MAX'.
6139
6140 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6141             Samuel Thibault  <samuel.thibault@gnu.org>
6142             Thomas Schwinge  <thomas@codesourcery.com>
6143
6144         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6145         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6146
6147 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6148
6149         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6150         (check_empty): Use "const char *".
6151
6152         * gnu-nat.c (gnu_nat_target::detach): Instead of
6153         'detach_inferior (pid)' call
6154         'detach_inferior (find_inferior_pid (pid))'.
6155
6156         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6157         'nat/fork-inferior.o'.
6158         * gnu-nat.c: #include "nat/fork-inferior.h".
6159
6160         * gnu-nat.c (gnu_nat_target::detach): Instead of
6161         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6162         * gnu-nat.h: #include "inf-child.h".
6163         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6164         'i386_gnu_nat_target::fetch_registers'.
6165         (gnu_store_registers): Rename/move to
6166         'i386_gnu_nat_target::store_registers'.
6167
6168         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6169         * gnu-nat.h (mach_thread_info): New function.
6170         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6171
6172         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6173
6174 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6175
6176         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6177
6178 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6179
6180         * windows-nat.c (windows_add_thread): Add new parameter
6181         "main_thread_p" with default value set to false.  Update
6182         function documentation as well as all callers.
6183         (windows_delete_thread): Likewise.
6184         (fake_create_process): Update call to windows_add_thread.
6185         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6186         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6187         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6188         call to windows_delete_thread.
6189
6190 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6191
6192         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6193
6194 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6195
6196         * symfile.c (find_separate_debug_file): Use canonical path of
6197         sysroot with child_path instead of gdb_sysroot if it is valid.
6198
6199 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6200
6201         * symfile.c (find_separate_debug_file): Use child_path to
6202         determine if an object file is under a sysroot.
6203
6204 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6205
6206         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6207         unittests/child-path-selftests.c.
6208         * common/pathstuff.c (child_path): New function.
6209         * common/pathstuff.h (child_path): New prototype.
6210         * unittests/child-path-selftests.c: New file.
6211
6212 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6213
6214         * symfile.c (find_separate_debug_file): Look for separate debug
6215         files in debug directories under the sysroot.
6216
6217 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6218
6219         * symtab.h (struct minimal_symbol data_p): New const method.
6220         (struct minimal_symbol text_p): Likewise.
6221         * symtab.c (output_source_filename): Use file name style
6222         to print file name.
6223         (print_symbol_info): Likewise.
6224         (print_msymbol_info): Use address style to print addresses.
6225         Use function name style to print executable text symbols.
6226         (expand_symtab_containing_pc): Use data_p.
6227         (find_pc_sect_compunit_symtab): Likewise.
6228
6229 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6230
6231         * breakpoint.c (describe_other_breakpoints): Use address style
6232         to print addresses.
6233         (say_where): Likewise.
6234
6235 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6236
6237         * ada-typeprint.c (print_func_type): Print function name
6238         style to print function name.
6239         * c-typeprint.c (c_print_type_1): Likewise.
6240
6241 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6242
6243         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6244         for execve.
6245
6246 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6247
6248         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6249         type_stack.
6250
6251 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6252
6253         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6254         TYPE_CODE_REF types.
6255
6256 2019-02-08  Jim Wilson  <jimw@sifive.com>
6257
6258         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6259         (riscv_linux_fregset): New.
6260         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6261
6262 2019-02-07  Tom Tromey  <tom@tromey.com>
6263
6264         * thread.c (thread_cancel_execution_command): Update.
6265         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6266         methods.
6267         (struct thread_fsm_ops): Remove.
6268         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6269         (thread_fsm_should_stop, thread_fsm_return_value)
6270         (thread_fsm_set_finished, thread_fsm_finished_p)
6271         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6272         Don't declare.
6273         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6274         * infrun.c (clear_proceed_status_thread)
6275         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6276         (print_stop_event): Update.
6277         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6278         Add constructor.
6279         (step_command_fsm_ops): Remove.
6280         (new_step_command_fsm): Remove.
6281         (step_1): Update.
6282         (step_command_fsm::should_stop): Rename from
6283         step_command_fsm_should_stop.
6284         (step_command_fsm::clean_up): Rename from
6285         step_command_fsm_clean_up.
6286         (step_command_fsm::do_async_reply_reason): Rename from
6287         step_command_fsm_async_reply_reason.
6288         (struct until_next_fsm): Inherit from thread_fsm.  Add
6289         constructor.
6290         (until_next_fsm_ops): Remove.
6291         (new_until_next_fsm): Remove.
6292         (until_next_fsm::should_stop): Rename from
6293         until_next_fsm_should_stop.
6294         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6295         (until_next_fsm::do_async_reply_reason): Rename from
6296         until_next_fsm_async_reply_reason.
6297         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6298         constructor.  Change type of breakpoint.
6299         (finish_command_fsm_ops): Remove.
6300         (new_finish_command_fsm): Remove.
6301         (finish_command_fsm::should_stop): Rename from
6302         finish_command_fsm_should_stop.
6303         (finish_command_fsm::clean_up): Rename from
6304         finish_command_fsm_clean_up.
6305         (finish_command_fsm::return_value): Rename from
6306         finish_command_fsm_return_value.
6307         (finish_command_fsm::do_async_reply_reason): Rename from
6308         finish_command_fsm_async_reply_reason.
6309         (finish_command): Update.
6310         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6311         Add constructor.
6312         (call_thread_fsm_ops): Remove.
6313         (call_thread_fsm::call_thread_fsm): Rename from
6314         new_call_thread_fsm.
6315         (call_thread_fsm::should_stop): Rename from
6316         call_thread_fsm_should_stop.
6317         (call_thread_fsm::should_notify_stop): Rename from
6318         call_thread_fsm_should_notify_stop.
6319         (run_inferior_call, call_function_by_hand_dummy): Update.
6320         * cli/cli-interp.c (should_print_stop_to_console): Update.
6321         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6322         Add constructor.  Change type of location_breakpoint,
6323         caller_breakpoint.
6324         (until_break_fsm_ops): Remove.
6325         (new_until_break_fsm): Remove.
6326         (until_break_fsm::should_stop): Rename from
6327         until_break_fsm_should_stop.
6328         (until_break_fsm::clean_up): Rename from
6329         until_break_fsm_clean_up.
6330         (until_break_fsm::do_async_reply_reason): Rename from
6331         until_break_fsm_async_reply_reason.
6332         (until_break_command): Update.
6333         * thread-fsm.c: Remove.
6334         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6335
6336 2019-02-07  Tom Tromey  <tom@tromey.com>
6337
6338         * yy-remap.h: Add include guard.
6339         * xtensa-tdep.h: Add include guard.
6340         * xcoffread.h: Rename include guard.
6341         * varobj-iter.h: Add include guard.
6342         * tui/tui.h: Rename include guard.
6343         * tui/tui-winsource.h: Rename include guard.
6344         * tui/tui-wingeneral.h: Rename include guard.
6345         * tui/tui-windata.h: Rename include guard.
6346         * tui/tui-win.h: Rename include guard.
6347         * tui/tui-stack.h: Rename include guard.
6348         * tui/tui-source.h: Rename include guard.
6349         * tui/tui-regs.h: Rename include guard.
6350         * tui/tui-out.h: Rename include guard.
6351         * tui/tui-layout.h: Rename include guard.
6352         * tui/tui-io.h: Rename include guard.
6353         * tui/tui-hooks.h: Rename include guard.
6354         * tui/tui-file.h: Rename include guard.
6355         * tui/tui-disasm.h: Rename include guard.
6356         * tui/tui-data.h: Rename include guard.
6357         * tui/tui-command.h: Rename include guard.
6358         * tic6x-tdep.h: Add include guard.
6359         * target/waitstatus.h: Rename include guard.
6360         * target/wait.h: Rename include guard.
6361         * target/target.h: Rename include guard.
6362         * target/resume.h: Rename include guard.
6363         * target-float.h: Rename include guard.
6364         * stabsread.h: Add include guard.
6365         * rs6000-tdep.h: Add include guard.
6366         * riscv-fbsd-tdep.h: Add include guard.
6367         * regformats/regdef.h: Rename include guard.
6368         * record.h: Rename include guard.
6369         * python/python.h: Rename include guard.
6370         * python/python-internal.h: Rename include guard.
6371         * python/py-stopevent.h: Rename include guard.
6372         * python/py-ref.h: Rename include guard.
6373         * python/py-record.h: Rename include guard.
6374         * python/py-record-full.h: Rename include guard.
6375         * python/py-record-btrace.h: Rename include guard.
6376         * python/py-instruction.h: Rename include guard.
6377         * python/py-events.h: Rename include guard.
6378         * python/py-event.h: Rename include guard.
6379         * procfs.h: Add include guard.
6380         * proc-utils.h: Add include guard.
6381         * p-lang.h: Add include guard.
6382         * or1k-tdep.h: Rename include guard.
6383         * observable.h: Rename include guard.
6384         * nto-tdep.h: Rename include guard.
6385         * nat/x86-linux.h: Rename include guard.
6386         * nat/x86-linux-dregs.h: Rename include guard.
6387         * nat/x86-gcc-cpuid.h: Add include guard.
6388         * nat/x86-dregs.h: Rename include guard.
6389         * nat/x86-cpuid.h: Rename include guard.
6390         * nat/ppc-linux.h: Rename include guard.
6391         * nat/mips-linux-watch.h: Rename include guard.
6392         * nat/linux-waitpid.h: Rename include guard.
6393         * nat/linux-ptrace.h: Rename include guard.
6394         * nat/linux-procfs.h: Rename include guard.
6395         * nat/linux-osdata.h: Rename include guard.
6396         * nat/linux-nat.h: Rename include guard.
6397         * nat/linux-namespaces.h: Rename include guard.
6398         * nat/linux-btrace.h: Rename include guard.
6399         * nat/glibc_thread_db.h: Rename include guard.
6400         * nat/gdb_thread_db.h: Rename include guard.
6401         * nat/gdb_ptrace.h: Rename include guard.
6402         * nat/fork-inferior.h: Rename include guard.
6403         * nat/amd64-linux-siginfo.h: Rename include guard.
6404         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6405         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6406         * nat/aarch64-linux.h: Rename include guard.
6407         * nat/aarch64-linux-hw-point.h: Rename include guard.
6408         * mn10300-tdep.h: Add include guard.
6409         * mips-linux-tdep.h: Add include guard.
6410         * mi/mi-parse.h: Rename include guard.
6411         * mi/mi-out.h: Rename include guard.
6412         * mi/mi-main.h: Rename include guard.
6413         * mi/mi-interp.h: Rename include guard.
6414         * mi/mi-getopt.h: Rename include guard.
6415         * mi/mi-console.h: Rename include guard.
6416         * mi/mi-common.h: Rename include guard.
6417         * mi/mi-cmds.h: Rename include guard.
6418         * mi/mi-cmd-break.h: Rename include guard.
6419         * m2-lang.h: Add include guard.
6420         * location.h: Rename include guard.
6421         * linux-record.h: Rename include guard.
6422         * linux-nat.h: Add include guard.
6423         * linux-fork.h: Add include guard.
6424         * i386-darwin-tdep.h: Rename include guard.
6425         * hppa-linux-offsets.h: Add include guard.
6426         * guile/guile.h: Rename include guard.
6427         * guile/guile-internal.h: Rename include guard.
6428         * gnu-nat.h: Rename include guard.
6429         * gdb-stabs.h: Rename include guard.
6430         * frv-tdep.h: Add include guard.
6431         * f-lang.h: Add include guard.
6432         * event-loop.h: Add include guard.
6433         * darwin-nat.h: Rename include guard.
6434         * cp-abi.h: Rename include guard.
6435         * config/sparc/nm-sol2.h: Rename include guard.
6436         * config/nm-nto.h: Rename include guard.
6437         * config/nm-linux.h: Add include guard.
6438         * config/i386/nm-i386gnu.h: Rename include guard.
6439         * config/djgpp/nl_types.h: Rename include guard.
6440         * config/djgpp/langinfo.h: Rename include guard.
6441         * compile/gcc-cp-plugin.h: Add include guard.
6442         * compile/gcc-c-plugin.h: Add include guard.
6443         * compile/compile.h: Rename include guard.
6444         * compile/compile-object-run.h: Rename include guard.
6445         * compile/compile-object-load.h: Rename include guard.
6446         * compile/compile-internal.h: Rename include guard.
6447         * compile/compile-cplus.h: Rename include guard.
6448         * compile/compile-c.h: Rename include guard.
6449         * common/xml-utils.h: Rename include guard.
6450         * common/x86-xstate.h: Rename include guard.
6451         * common/version.h: Rename include guard.
6452         * common/vec.h: Rename include guard.
6453         * common/tdesc.h: Rename include guard.
6454         * common/selftest.h: Rename include guard.
6455         * common/scoped_restore.h: Rename include guard.
6456         * common/scoped_mmap.h: Rename include guard.
6457         * common/scoped_fd.h: Rename include guard.
6458         * common/safe-iterator.h: Rename include guard.
6459         * common/run-time-clock.h: Rename include guard.
6460         * common/refcounted-object.h: Rename include guard.
6461         * common/queue.h: Rename include guard.
6462         * common/ptid.h: Rename include guard.
6463         * common/print-utils.h: Rename include guard.
6464         * common/preprocessor.h: Rename include guard.
6465         * common/pathstuff.h: Rename include guard.
6466         * common/observable.h: Rename include guard.
6467         * common/netstuff.h: Rename include guard.
6468         * common/job-control.h: Rename include guard.
6469         * common/host-defs.h: Rename include guard.
6470         * common/gdb_wait.h: Rename include guard.
6471         * common/gdb_vecs.h: Rename include guard.
6472         * common/gdb_unlinker.h: Rename include guard.
6473         * common/gdb_unique_ptr.h: Rename include guard.
6474         * common/gdb_tilde_expand.h: Rename include guard.
6475         * common/gdb_sys_time.h: Rename include guard.
6476         * common/gdb_string_view.h: Rename include guard.
6477         * common/gdb_splay_tree.h: Rename include guard.
6478         * common/gdb_setjmp.h: Rename include guard.
6479         * common/gdb_ref_ptr.h: Rename include guard.
6480         * common/gdb_optional.h: Rename include guard.
6481         * common/gdb_locale.h: Rename include guard.
6482         * common/gdb_assert.h: Rename include guard.
6483         * common/filtered-iterator.h: Rename include guard.
6484         * common/filestuff.h: Rename include guard.
6485         * common/fileio.h: Rename include guard.
6486         * common/environ.h: Rename include guard.
6487         * common/common-utils.h: Rename include guard.
6488         * common/common-types.h: Rename include guard.
6489         * common/common-regcache.h: Rename include guard.
6490         * common/common-inferior.h: Rename include guard.
6491         * common/common-gdbthread.h: Rename include guard.
6492         * common/common-exceptions.h: Rename include guard.
6493         * common/common-defs.h: Rename include guard.
6494         * common/common-debug.h: Rename include guard.
6495         * common/cleanups.h: Rename include guard.
6496         * common/buffer.h: Rename include guard.
6497         * common/btrace-common.h: Rename include guard.
6498         * common/break-common.h: Rename include guard.
6499         * cli/cli-utils.h: Rename include guard.
6500         * cli/cli-style.h: Rename include guard.
6501         * cli/cli-setshow.h: Rename include guard.
6502         * cli/cli-script.h: Rename include guard.
6503         * cli/cli-interp.h: Rename include guard.
6504         * cli/cli-decode.h: Rename include guard.
6505         * cli/cli-cmds.h: Rename include guard.
6506         * charset-list.h: Add include guard.
6507         * buildsym-legacy.h: Rename include guard.
6508         * bfin-tdep.h: Add include guard.
6509         * ax.h: Rename include guard.
6510         * arm-linux-tdep.h: Add include guard.
6511         * arm-fbsd-tdep.h: Add include guard.
6512         * arch/xtensa.h: Rename include guard.
6513         * arch/tic6x.h: Add include guard.
6514         * arch/i386.h: Add include guard.
6515         * arch/arm.h: Rename include guard.
6516         * arch/arm-linux.h: Rename include guard.
6517         * arch/arm-get-next-pcs.h: Rename include guard.
6518         * arch/amd64.h: Add include guard.
6519         * arch/aarch64-insn.h: Rename include guard.
6520         * arch-utils.h: Rename include guard.
6521         * annotate.h: Add include guard.
6522         * amd64-darwin-tdep.h: Rename include guard.
6523         * aarch64-linux-tdep.h: Add include guard.
6524         * aarch64-fbsd-tdep.h: Add include guard.
6525         * aarch32-linux-nat.h: Add include guard.
6526
6527 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6528
6529         * macrotab.c (macro_define_internal): New function that
6530         factorizes macro_define_object_internal and macro_define_function
6531         code.
6532         (macro_define_object_internal): Use macro_define_internal.
6533         (macro_define_function): Likewise.
6534
6535 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6536
6537         * macrocmd.c (extract_identifier): Return
6538         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6539         callers.
6540
6541 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6542
6543         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6544
6545 2019-02-05  Tom Tromey  <tom@tromey.com>
6546
6547         * target.c (target_stack::unpush): Move assertion earlier.
6548
6549 2019-01-30  Tom Tromey  <tom@tromey.com>
6550
6551         PR python/23615:
6552         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6553         (gdbpy_parse_and_eval): Likewise.
6554         * python/python-internal.h (gdbpy_allow_threads): New class.
6555
6556 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6557
6558         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6559         (aarch64_fbsd_fpregmap): Move earlier.
6560         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6561         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6562         instead of individual calls to trad_frame_set_reg_addr.
6563         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6564         earlier.
6565         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6566         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6567         instead of individual calls to trad_frame_set_reg_addr.
6568
6569 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6570
6571         * CONTRIBUTE: Replace contribution list with wiki link.
6572
6573 2019-01-25  Tom Tromey  <tom@tromey.com>
6574
6575         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6576
6577 2019-01-25  Tom Tromey  <tom@tromey.com>
6578
6579         * xtensa-linux-nat.c: Fix common/ includes.
6580         * xml-support.h: Fix common/ includes.
6581         * xml-support.c: Fix common/ includes.
6582         * x86-linux-nat.c: Fix common/ includes.
6583         * windows-nat.c: Fix common/ includes.
6584         * varobj.h: Fix common/ includes.
6585         * varobj.c: Fix common/ includes.
6586         * value.c: Fix common/ includes.
6587         * valops.c: Fix common/ includes.
6588         * utils.c: Fix common/ includes.
6589         * unittests/xml-utils-selftests.c: Fix common/ includes.
6590         * unittests/utils-selftests.c: Fix common/ includes.
6591         * unittests/unpack-selftests.c: Fix common/ includes.
6592         * unittests/tracepoint-selftests.c: Fix common/ includes.
6593         * unittests/style-selftests.c: Fix common/ includes.
6594         * unittests/string_view-selftests.c: Fix common/ includes.
6595         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6596         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6597         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6598         * unittests/rsp-low-selftests.c: Fix common/ includes.
6599         * unittests/parse-connection-spec-selftests.c: Fix common/
6600         includes.
6601         * unittests/optional-selftests.c: Fix common/ includes.
6602         * unittests/offset-type-selftests.c: Fix common/ includes.
6603         * unittests/observable-selftests.c: Fix common/ includes.
6604         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6605         * unittests/memrange-selftests.c: Fix common/ includes.
6606         * unittests/memory-map-selftests.c: Fix common/ includes.
6607         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6608         * unittests/function-view-selftests.c: Fix common/ includes.
6609         * unittests/environ-selftests.c: Fix common/ includes.
6610         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6611         * unittests/common-utils-selftests.c: Fix common/ includes.
6612         * unittests/cli-utils-selftests.c: Fix common/ includes.
6613         * unittests/array-view-selftests.c: Fix common/ includes.
6614         * ui-file.c: Fix common/ includes.
6615         * tui/tui-io.c: Fix common/ includes.
6616         * tracepoint.h: Fix common/ includes.
6617         * tracepoint.c: Fix common/ includes.
6618         * tracefile-tfile.c: Fix common/ includes.
6619         * top.h: Fix common/ includes.
6620         * top.c: Fix common/ includes.
6621         * thread.c: Fix common/ includes.
6622         * target/waitstatus.h: Fix common/ includes.
6623         * target/waitstatus.c: Fix common/ includes.
6624         * target.h: Fix common/ includes.
6625         * target.c: Fix common/ includes.
6626         * target-memory.c: Fix common/ includes.
6627         * target-descriptions.c: Fix common/ includes.
6628         * symtab.h: Fix common/ includes.
6629         * symfile.c: Fix common/ includes.
6630         * stap-probe.c: Fix common/ includes.
6631         * spu-linux-nat.c: Fix common/ includes.
6632         * sparc-nat.c: Fix common/ includes.
6633         * source.c: Fix common/ includes.
6634         * solib.c: Fix common/ includes.
6635         * solib-target.c: Fix common/ includes.
6636         * ser-unix.c: Fix common/ includes.
6637         * ser-tcp.c: Fix common/ includes.
6638         * ser-pipe.c: Fix common/ includes.
6639         * ser-base.c: Fix common/ includes.
6640         * selftest-arch.c: Fix common/ includes.
6641         * s12z-tdep.c: Fix common/ includes.
6642         * rust-exp.y: Fix common/ includes.
6643         * rs6000-aix-tdep.c: Fix common/ includes.
6644         * riscv-tdep.c: Fix common/ includes.
6645         * remote.c: Fix common/ includes.
6646         * remote-notif.h: Fix common/ includes.
6647         * remote-fileio.h: Fix common/ includes.
6648         * remote-fileio.c: Fix common/ includes.
6649         * regcache.h: Fix common/ includes.
6650         * regcache.c: Fix common/ includes.
6651         * record-btrace.c: Fix common/ includes.
6652         * python/python.c: Fix common/ includes.
6653         * python/py-type.c: Fix common/ includes.
6654         * python/py-inferior.c: Fix common/ includes.
6655         * progspace.h: Fix common/ includes.
6656         * producer.c: Fix common/ includes.
6657         * procfs.c: Fix common/ includes.
6658         * proc-api.c: Fix common/ includes.
6659         * printcmd.c: Fix common/ includes.
6660         * ppc-linux-nat.c: Fix common/ includes.
6661         * parser-defs.h: Fix common/ includes.
6662         * osdata.c: Fix common/ includes.
6663         * obsd-nat.c: Fix common/ includes.
6664         * nat/x86-linux.c: Fix common/ includes.
6665         * nat/x86-linux-dregs.c: Fix common/ includes.
6666         * nat/x86-dregs.h: Fix common/ includes.
6667         * nat/x86-dregs.c: Fix common/ includes.
6668         * nat/ppc-linux.c: Fix common/ includes.
6669         * nat/mips-linux-watch.h: Fix common/ includes.
6670         * nat/mips-linux-watch.c: Fix common/ includes.
6671         * nat/linux-waitpid.c: Fix common/ includes.
6672         * nat/linux-ptrace.h: Fix common/ includes.
6673         * nat/linux-ptrace.c: Fix common/ includes.
6674         * nat/linux-procfs.c: Fix common/ includes.
6675         * nat/linux-personality.c: Fix common/ includes.
6676         * nat/linux-osdata.c: Fix common/ includes.
6677         * nat/linux-namespaces.c: Fix common/ includes.
6678         * nat/linux-btrace.h: Fix common/ includes.
6679         * nat/linux-btrace.c: Fix common/ includes.
6680         * nat/fork-inferior.c: Fix common/ includes.
6681         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6682         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6683         * nat/aarch64-linux.c: Fix common/ includes.
6684         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6685         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6686         * namespace.h: Fix common/ includes.
6687         * mips-linux-tdep.c: Fix common/ includes.
6688         * minsyms.c: Fix common/ includes.
6689         * mi/mi-parse.h: Fix common/ includes.
6690         * mi/mi-main.c: Fix common/ includes.
6691         * mi/mi-cmd-env.c: Fix common/ includes.
6692         * memrange.h: Fix common/ includes.
6693         * memattr.c: Fix common/ includes.
6694         * maint.h: Fix common/ includes.
6695         * maint.c: Fix common/ includes.
6696         * main.c: Fix common/ includes.
6697         * machoread.c: Fix common/ includes.
6698         * location.c: Fix common/ includes.
6699         * linux-thread-db.c: Fix common/ includes.
6700         * linux-nat.c: Fix common/ includes.
6701         * linux-fork.c: Fix common/ includes.
6702         * inline-frame.c: Fix common/ includes.
6703         * infrun.c: Fix common/ includes.
6704         * inflow.c: Fix common/ includes.
6705         * inferior.h: Fix common/ includes.
6706         * inferior.c: Fix common/ includes.
6707         * infcmd.c: Fix common/ includes.
6708         * inf-ptrace.c: Fix common/ includes.
6709         * inf-child.c: Fix common/ includes.
6710         * ia64-linux-nat.c: Fix common/ includes.
6711         * i387-tdep.c: Fix common/ includes.
6712         * i386-tdep.c: Fix common/ includes.
6713         * i386-linux-tdep.c: Fix common/ includes.
6714         * i386-linux-nat.c: Fix common/ includes.
6715         * i386-go32-tdep.c: Fix common/ includes.
6716         * i386-fbsd-tdep.c: Fix common/ includes.
6717         * i386-fbsd-nat.c: Fix common/ includes.
6718         * guile/scm-type.c: Fix common/ includes.
6719         * guile/guile.c: Fix common/ includes.
6720         * go32-nat.c: Fix common/ includes.
6721         * gnu-nat.c: Fix common/ includes.
6722         * gdbthread.h: Fix common/ includes.
6723         * gdbarch-selftests.c: Fix common/ includes.
6724         * gdb_usleep.c: Fix common/ includes.
6725         * gdb_select.h: Fix common/ includes.
6726         * gdb_bfd.c: Fix common/ includes.
6727         * gcore.c: Fix common/ includes.
6728         * fork-child.c: Fix common/ includes.
6729         * findvar.c: Fix common/ includes.
6730         * fbsd-nat.c: Fix common/ includes.
6731         * event-top.c: Fix common/ includes.
6732         * event-loop.c: Fix common/ includes.
6733         * dwarf2read.c: Fix common/ includes.
6734         * dwarf2loc.c: Fix common/ includes.
6735         * dwarf2-frame.c: Fix common/ includes.
6736         * dwarf-index-cache.c: Fix common/ includes.
6737         * dtrace-probe.c: Fix common/ includes.
6738         * disasm-selftests.c: Fix common/ includes.
6739         * defs.h: Fix common/ includes.
6740         * csky-tdep.c: Fix common/ includes.
6741         * cp-valprint.c: Fix common/ includes.
6742         * cp-support.h: Fix common/ includes.
6743         * cp-support.c: Fix common/ includes.
6744         * corelow.c: Fix common/ includes.
6745         * completer.h: Fix common/ includes.
6746         * completer.c: Fix common/ includes.
6747         * compile/compile.c: Fix common/ includes.
6748         * compile/compile-loc2c.c: Fix common/ includes.
6749         * compile/compile-cplus-types.c: Fix common/ includes.
6750         * compile/compile-cplus-symbols.c: Fix common/ includes.
6751         * command.h: Fix common/ includes.
6752         * cli/cli-dump.c: Fix common/ includes.
6753         * cli/cli-cmds.c: Fix common/ includes.
6754         * charset.c: Fix common/ includes.
6755         * build-id.c: Fix common/ includes.
6756         * btrace.h: Fix common/ includes.
6757         * btrace.c: Fix common/ includes.
6758         * breakpoint.h: Fix common/ includes.
6759         * breakpoint.c: Fix common/ includes.
6760         * ax.h:
6761         (enum agent_op): Fix common/ includes.
6762         * ax-general.c (struct aop_map): Fix common/ includes.
6763         * ax-gdb.c: Fix common/ includes.
6764         * auxv.c: Fix common/ includes.
6765         * auto-load.c: Fix common/ includes.
6766         * arm-tdep.c: Fix common/ includes.
6767         * arch/riscv.c: Fix common/ includes.
6768         * arch/ppc-linux-common.c: Fix common/ includes.
6769         * arch/i386.c: Fix common/ includes.
6770         * arch/arm.c: Fix common/ includes.
6771         * arch/arm-linux.c: Fix common/ includes.
6772         * arch/arm-get-next-pcs.c: Fix common/ includes.
6773         * arch/amd64.c: Fix common/ includes.
6774         * arch/aarch64.c: Fix common/ includes.
6775         * arch/aarch64-insn.c: Fix common/ includes.
6776         * arch-utils.c: Fix common/ includes.
6777         * amd64-windows-tdep.c: Fix common/ includes.
6778         * amd64-tdep.c: Fix common/ includes.
6779         * amd64-sol2-tdep.c: Fix common/ includes.
6780         * amd64-obsd-tdep.c: Fix common/ includes.
6781         * amd64-nbsd-tdep.c: Fix common/ includes.
6782         * amd64-linux-tdep.c: Fix common/ includes.
6783         * amd64-linux-nat.c: Fix common/ includes.
6784         * amd64-fbsd-tdep.c: Fix common/ includes.
6785         * amd64-fbsd-nat.c: Fix common/ includes.
6786         * amd64-dicos-tdep.c: Fix common/ includes.
6787         * amd64-darwin-tdep.c: Fix common/ includes.
6788         * agent.c: Fix common/ includes.
6789         * ada-lang.h: Fix common/ includes.
6790         * ada-lang.c: Fix common/ includes.
6791         * aarch64-tdep.c: Fix common/ includes.
6792
6793 2019-01-25  Tom Tromey  <tom@tromey.com>
6794
6795         * common/create-version.sh: Use common/version.h.
6796
6797 2019-01-24  Pedro Alves  <palves@redhat.com>
6798
6799         * infrun.c (signal_stop, signal_print, signal_program)
6800         (signal_catch, signal_pass): Now arrays instead of pointers.
6801         (update_signals_program_target, do_target_resume)
6802         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6803         * linux-nat.c (linux_nat_target::pass_signals)
6804         (linux_nat_target::create_inferior, linux_nat_target::attach):
6805         Adjust.
6806         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6807         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6808         * procfs.c (procfs_target::pass_signals): Adjust.
6809         * record-full.c (record_full_target::resume): Adjust.
6810         * remote.c (remote_target::pass_signals)
6811         (remote_target::program_signals): Adjust.
6812         * target-debug.h (target_debug_print_signals): Now takes a
6813         gdb::array_view as parameter.  Adjust.
6814         * target.h (target_ops) <pass_signals, program_signals>: Replace
6815         pointer and length parameters with gdb::array_view.
6816         (target_pass_signals, target_program_signals): Likewise.
6817         * target-delegates.c: Regenerate.
6818
6819 2019-01-24  Pedro Alves  <palves@redhat.com>
6820
6821         * common/forward-scope-exit.h
6822         (forward_scope_exit::forward_scope_exit): Pass arguments to
6823         m_bind_function directly, instead of creating a std::bind and
6824         copying that.
6825
6826 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6827
6828         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6829         for static members.
6830         (pass_in_v_vfp_candidate): Likewise.
6831
6832 2019-01-23  Tom Tromey  <tom@tromey.com>
6833             Pedro Alves  <palves@redhat.com>
6834
6835         * regcache.c (class regcache_invalidator): Remove.
6836         (regcache::raw_write): Use make_scope_exit.
6837
6838 2019-01-23  Tom Tromey  <tom@tromey.com>
6839
6840         * ui-out.h (class ui_out_emit_type): Update comment.
6841
6842 2019-01-23  Tom Tromey  <tom@tromey.com>
6843
6844         * infrun.c (fetch_inferior_event): Update comment.
6845
6846 2019-01-23  Tom Tromey  <tom@tromey.com>
6847             Pedro Alves  <palves@redhat.com>
6848
6849         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6850         parameter.
6851         (fetch_inferior_event): Use SCOPE_EXIT.
6852
6853
6854 2019-01-23  Tom Tromey  <tom@tromey.com>
6855             Pedro Alves  <palves@redhat.com>
6856
6857         * infrun.c (disable_thread_events): Delete.
6858         (stop_all_threads): Use SCOPE_EXIT.
6859
6860 2019-01-23  Tom Tromey  <tom@tromey.com>
6861             Pedro Alves  <palves@redhat.com>
6862
6863         * symfile.c: Include forward-scope-exit.h.
6864         (clear_symtab_users_cleanup): Replace forward declaration with
6865         a FORWARD_SCOPE_EXIT.
6866         (syms_from_objfile_1): Use the forward_scope_exit and
6867         gdb::optional instead of cleanup_function.
6868         (reread_symbols): Use the forward_scope_exit instead of
6869         cleanup_function.
6870         (clear_symtab_users_cleanup): Remove function.
6871
6872 2019-01-23  Tom Tromey  <tom@tromey.com>
6873             Pedro Alves  <palves@redhat.com>
6874
6875         * linux-nat.c: Include scope-exit.h.
6876         (cleanup_target_stop): Remove.
6877         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6878         SCOPE_EXIT.
6879
6880 2019-01-23  Tom Tromey  <tom@tromey.com>
6881             Pedro Alves  <palves@redhat.com>
6882
6883         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6884         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6885
6886 2019-01-23  Tom Tromey  <tom@tromey.com>
6887             Andrew Burgess  <andrew.burgess@embecosm.com>
6888             Pedro Alves  <palves@redhat.com>
6889
6890         * infrun.c (fetch_inferior_event): Use scope_exit.
6891         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6892         * top.c (execute_command): Use scope_exit.
6893         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6894         * utils.c (do_bpstat_clear_actions_cleanup)
6895         (make_bpstat_clear_actions_cleanup): Remove.
6896
6897 2019-01-23  Tom Tromey  <tom@tromey.com>
6898             Pedro Alves  <palves@redhat.com>
6899
6900         * infrun.c: Include "common/scope-exit.h"
6901         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6902         (wait_for_inferior): Use SCOPE_EXIT.
6903         (fetch_inferior_event): Use scope_exit.
6904
6905 2019-01-23  Tom Tromey  <tom@tromey.com>
6906             Pedro Alves  <palves@redhat.com>
6907
6908         * breakpoint.c (create_breakpoint): Remove cleanup.
6909
6910 2019-01-23  Tom Tromey  <tom@tromey.com>
6911             Andrew Burgess  <andrew.burgess@embecosm.com>
6912             Pedro Alves  <palves@redhat.com>
6913
6914 2019-01-23  Pedro Alves  <palves@redhat.com>
6915
6916         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6917
6918 2019-01-23  Pedro Alves  <palves@redhat.com>
6919             Andrew Burgess  <andrew.burgess@embecosm.com>
6920
6921         * gdbthread.h: Include "common/forward-scope-exit.h".
6922         (scoped_finish_thread_state): Redefine custom class in terms of
6923         forward_scope_exit.
6924
6925 2019-01-23  Pedro Alves  <palves@redhat.com>
6926             Andrew Burgess  <andrew.burgess@embecosm.com>
6927
6928         * common/forward-scope-exit.h: New file.
6929
6930 2019-01-23  Pedro Alves  <palves@redhat.com>
6931             Andrew Burgess  <andrew.burgess@embecosm.com>
6932             Tom Tromey  <tom@tromey.com>
6933
6934         * common/scope-exit.h: New file.
6935
6936 2019-01-23  Pedro Alves  <palves@redhat.com>
6937
6938         * common/preprocessor.h (ESC): Rename to ...
6939         (ESC_PARENS): ... this.
6940         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6941         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6942
6943 2019-01-23  Tom Tromey  <tom@tromey.com>
6944
6945         * language.h (class scoped_switch_to_sym_language_if_auto):
6946         Initialize m_lang in both cases.
6947
6948 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6949
6950         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6951         with XCNEW.
6952
6953 2019-01-22  Tom Tromey  <tom@tromey.com>
6954
6955         * corelow.c: Do not include sys/file.h.
6956
6957 2019-01-22  Tom Tromey  <tom@tromey.com>
6958
6959         * tui/tui-wingeneral.h: Include gdb_curses.h.
6960
6961 2019-01-22  Tom Tromey  <tom@tromey.com>
6962
6963         * source-cache.h (class source_cache) <get_source_lines,
6964         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6965
6966 2019-01-22  Tom Tromey  <tom@tromey.com>
6967
6968         * remote-fileio.h (struct remote_target): Declare.
6969
6970 2019-01-22  Tom Tromey  <tom@tromey.com>
6971
6972         * python/py-arch.c: Do not include py-ref.h.
6973         * python/py-bpevent.c: Do not include py-ref.h.
6974         * python/py-cmd.c: Do not include py-ref.h.
6975         * python/py-continueevent.c: Do not include py-ref.h.
6976         * python/py-event.h: Do not include py-ref.h.
6977         * python/py-evtregistry.c: Do not include py-ref.h.
6978         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6979         * python/py-frame.c: Do not include py-ref.h.
6980         * python/py-framefilter.c: Do not include py-ref.h.
6981         * python/py-function.c: Do not include py-ref.h.
6982         * python/py-infevents.c: Do not include py-ref.h.
6983         * python/py-linetable.c: Do not include py-ref.h.
6984         * python/py-objfile.c: Do not include py-ref.h.
6985         * python/py-param.c: Do not include py-ref.h.
6986         * python/py-prettyprint.c: Do not include py-ref.h.
6987         * python/py-progspace.c: Do not include py-ref.h.
6988         * python/py-symbol.c: Do not include py-ref.h.
6989         * python/py-symtab.c: Do not include py-ref.h.
6990         * python/py-type.c: Do not include py-ref.h.
6991         * python/py-unwind.c: Do not include py-ref.h.
6992         * python/py-utils.c: Do not include py-ref.h.
6993         * python/py-value.c: Do not include py-ref.h.
6994         * python/py-varobj.c: Do not include py-ref.h.
6995         * python/py-xmethods.c: Do not include py-ref.h.
6996         * python/python.c: Do not include py-ref.h.
6997         * varobj.c: Do not include py-ref.h.
6998
6999 2019-01-22  Tom Tromey  <tom@tromey.com>
7000
7001         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7002         keyword for bcache.
7003
7004 2019-01-22  Tom Tromey  <tom@tromey.com>
7005
7006         * compile/compile-cplus-types.c: Remove a comment by #include.
7007
7008 2019-01-22  Tom Tromey  <tom@tromey.com>
7009
7010         * compile/gcc-c-plugin.h: Include compile-internal.h.
7011
7012 2019-01-22  Tom Tromey  <tom@tromey.com>
7013
7014         * stabsread.c (EXTERN): Do not define.
7015         (symnum, next_symbol_text_func, processing_gcc_compilation)
7016         (within_function, global_sym_chain, global_stabs)
7017         (previous_stab_code, this_object_header_files)
7018         (n_this_object_header_files)
7019         (n_allocated_this_object_header_files): Define.
7020         * stabsread.h (EXTERN): Never define.  Use "extern".
7021
7022 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7023
7024         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7025         history_value.
7026
7027 2019-01-21  Tom Tromey  <tom@tromey.com>
7028
7029         * ui-out.c: Fix includes.
7030         * tui/tui-source.c: Fix includes.
7031         * target.c: Fix includes.
7032         * remote.c: Fix includes.
7033         * regcache.c: Fix includes.
7034         * python/py-block.c: Fix includes.
7035         * printcmd.c: Fix includes.
7036         * or1k-tdep.c: Fix includes.
7037         * mi/mi-main.c: Fix includes.
7038         * m32r-tdep.c: Fix includes.
7039         * csky-tdep.c: Fix includes.
7040         * compile/compile-cplus-types.c: Fix includes.
7041         * cli/cli-interp.c: Fix includes.
7042
7043 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7044
7045         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7046         for padding.
7047
7048 2019-01-16  Tom Tromey  <tom@tromey.com>
7049
7050         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7051         earlier.
7052         (struct objfile) <msymbols_range>: Move from top level.
7053         <msymbols>: New method.
7054         (class objfile_msymbols): Remove.
7055         * symtab.c (default_collect_symbol_completion_matches_break_on):
7056         Update.
7057         * symmisc.c (dump_msymbols): Update.
7058         * stabsread.c (scan_file_globals): Update.
7059         * objc-lang.c (info_selectors_command, info_classes_command)
7060         (find_methods): Update.
7061         * minsyms.c (find_solib_trampoline_target): Update.
7062         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7063         * coffread.c (coff_symfile_read): Update.
7064         * ada-lang.c (ada_lookup_simple_minsym)
7065         (ada_collect_symbol_completion_matches): Update.
7066
7067 2019-01-16  Tom Tromey  <tom@tromey.com>
7068
7069         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7070         type.  Remove no-argument constructor.
7071         <iterator::operator++>: Simplify.
7072         <begin>: Update.
7073         <end>: Use minimal_symbol_count.
7074
7075 2019-01-16  Tom Tromey  <tom@tromey.com>
7076
7077         * objfiles.h (struct objfile) <psymtabs>: New method.
7078         (class objfile_psymtabs): Remove.
7079         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7080         typedef.
7081         <range>: New method.
7082         (require_partial_symbols): Change return type.
7083         * psymtab.c (require_partial_symbols)
7084         (psym_expand_symtabs_matching): Update.
7085         * mdebugread.c (parse_partial_symbols): Update.
7086         * dbxread.c (dbx_end_psymtab): Update.
7087
7088 2019-01-15  Tom Tromey  <tom@tromey.com>
7089
7090         * symtab.c (lookup_objfile_from_block)
7091         (lookup_symbol_in_objfile_symtabs)
7092         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7093         (find_line_symtab, info_sources_command)
7094         (default_collect_symbol_completion_matches_break_on)
7095         (make_source_files_completion_list): Update.
7096         * symmisc.c (print_objfile_statistics, dump_objfile)
7097         (maintenance_print_symbols, maintenance_info_symtabs)
7098         (maintenance_check_symtabs, maintenance_info_line_tables):
7099         Update.
7100         * source.c (select_source_symtab)
7101         (forget_cached_source_info_for_objfile): Update.
7102         * objfiles.h (class objfile_compunits): Remove.
7103         (struct objfile) <compunits_range>: New typedef.
7104         (compunits): New method.
7105         * objfiles.c (objfile_relocate1): Update.
7106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7107         * maint.c (count_symtabs_and_blocks): Update.
7108         * linespec.c (iterate_over_all_matching_symtabs): Update.
7109         * cp-support.c (add_symbol_overload_list_qualified): Update.
7110         * coffread.c (coff_symtab_read): Update.
7111         * ada-lang.c (add_nonlocal_symbols)
7112         (ada_collect_symbol_completion_matches)
7113         (ada_add_global_exceptions): Update.
7114
7115 2019-01-15  Tom Tromey  <tom@tromey.com>
7116
7117         * progspace.h (program_space) <objfiles_safe_range>: New
7118         typedef.
7119         <objfiles_safe>: New method.
7120         * objfiles.h (class all_objfiles_safe): Remove.
7121         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7122         * jit.c (jit_inferior_exit_hook): Update.
7123
7124 2019-01-17  Tom Tromey  <tom@tromey.com>
7125
7126         * progspace.h (program_space) <objfiles_range>: New typedef.
7127         <objfiles>: New method.
7128         <objfiles_head>: Rename from objfiles.
7129         (object_files): Update.
7130         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7131         * guile/scm-pretty-print.c
7132         (ppscm_find_pretty_printer_from_objfiles): Update.
7133         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7134         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7135         Update.
7136         * python/py-progspace.c (pspy_get_objfiles): Update.
7137         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7138         Update.
7139         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7140         (objfpy_lookup_objfile_by_build_id): Update.
7141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7142         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7143         Update.
7144         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7145         (expand_symtab_containing_pc, lookup_objfile_from_block)
7146         (lookup_static_symbol, basic_lookup_transparent_type)
7147         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7148         (find_line_symtab, info_sources_command)
7149         (default_collect_symbol_completion_matches_break_on)
7150         (make_source_files_completion_list, find_main_name): Update.
7151         * symmisc.c (print_symbol_bcache_statistics)
7152         (print_objfile_statistics, maintenance_print_symbols)
7153         (maintenance_print_msymbols, maintenance_print_objfiles)
7154         (maintenance_info_symtabs, maintenance_check_symtabs)
7155         (maintenance_expand_symtabs, maintenance_info_line_tables):
7156         Update.
7157         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7158         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7159         (map_overlay_command, unmap_overlay_command)
7160         (simple_overlay_update, expand_symtabs_matching)
7161         (map_symbol_filenames): Update.
7162         * symfile-debug.c (set_debug_symfile): Update.
7163         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7164         Update.
7165         * source.c (select_source_symtab, forget_cached_source_info):
7166         Update.
7167         * solib.c (solib_read_symbols): Update.
7168         * solib-spu.c (append_ocl_sos): Update.
7169         * psymtab.c (maintenance_print_psymbols)
7170         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7171         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7172         * printcmd.c (info_symbol_command): Update.
7173         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7174         Update.
7175         * objfiles.h (class all_objfiles): Remove.
7176         * objfiles.c (have_partial_symbols, have_full_symbols)
7177         (have_minimal_symbols, qsort_cmp, update_section_map)
7178         (shared_objfile_contains_address_p)
7179         (default_iterate_over_objfiles_in_search_order): Update.
7180         * objc-lang.c (info_selectors_command, info_classes_command)
7181         (find_methods): Update.
7182         * minsyms.c (find_solib_trampoline_target): Update.
7183         * maint.c (maintenance_info_sections)
7184         (maintenance_translate_address, count_symtabs_and_blocks):
7185         Update.
7186         * main.c (captured_main_1): Update.
7187         * linux-thread-db.c (try_thread_db_load_from_pdir)
7188         (has_libpthread): Update.
7189         * linespec.c (iterate_over_all_matching_symtabs)
7190         (search_minsyms_for_name): Update.
7191         * jit.c (jit_find_objf_with_entry_addr): Update.
7192         * hppa-tdep.c (find_unwind_entry)
7193         (hppa_lookup_stub_minimal_symbol): Update.
7194         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7195         Update.
7196         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7197         (elf_gnu_ifunc_resolve_by_got): Update.
7198         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7199         * dwarf-index-write.c (save_gdb_index_command): Update.
7200         * cp-support.c (add_symbol_overload_list_qualified): Update.
7201         * breakpoint.c (create_overlay_event_breakpoint)
7202         (create_longjmp_master_breakpoint)
7203         (create_std_terminate_master_breakpoint)
7204         (create_exception_master_breakpoint): Update.
7205         * blockframe.c (find_pc_partial_function): Update.
7206         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7207         (ada_collect_symbol_completion_matches)
7208         (ada_add_global_exceptions): Update.
7209
7210 2019-01-17  Tom Tromey  <tom@tromey.com>
7211
7212         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7213         declare VEC.
7214         (solib_target_parse_libraries): Change return type.
7215         (library_list_start_segment, library_list_start_section)
7216         (library_list_end_library, library_list_start_library); Update.
7217         (solib_target_free_library_list): Remove.
7218         (solib_target_parse_libraries): Remove cleanup.  Change return
7219         type.
7220         (solib_target_current_sos): Update.
7221
7222 2019-01-17  Tom Tromey  <tromey@bapiya>
7223
7224         * valprint.c: Replace "the the" with "the".
7225         * symtab.c: Replace "the the" with "the".
7226         * solib.c: Replace "the the" with "the".
7227         * solib-dsbt.c: Replace "the the" with "the".
7228         * linespec.c: Replace "the the" with "the".
7229         * dwarf2loc.h: Replace "the the" with "the".
7230         * amd64-windows-tdep.c: Replace "the the" with "the".
7231         * aarch64-tdep.c: Replace "the the" with "the".
7232
7233 2019-01-16  Keith Seitz  <keiths@redhat.com>
7234
7235         PR gdb/23773
7236         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7237         <builder>: Rename to ..
7238         <m_builder>: ... this and make private.
7239         (dwarf2_cu::get_builder): New method.  Change all users of
7240         `builder' to use this method.
7241         (dwarf2_start_symtab): Move to ...
7242         (dwarf2_cu::start_symtab): ... here.  Update all callers
7243         (setup_type_unit_groups): Move to ...
7244         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7245         callers.
7246         (dwarf2_cu::reset_builder): New method.
7247         (process_full_compunit, process_full_type_unit): Use
7248         dwarf2_cu::reset_builder.
7249         (follow_die_offset): Record the ancestor CU if it is different
7250         from the followed DIE's CU.
7251         (follow_die_sig_1): Likewise.
7252
7253 2019-01-15  Tom Tromey  <tom@tromey.com>
7254
7255         * remote.c (class remote_state) <buf>: Now a char_vector.
7256         <buf_size>: Remove.
7257         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7258         parameter.
7259         (remote_target::getpkt_or_notif_sane_1)
7260         (remote_target::getpkt_sane)
7261         (remote_target::getpkt_or_notif_sane): Likewise.
7262         (class remote_target) <putpkt>: New overload.
7263         (remote_target::read_frame): Change type of "buf_p".  Remove
7264         sizeof_p parameter.
7265         (packet_ok): New overload.
7266         (packet_check_result): New overload.
7267         Update all uses.
7268
7269 2019-01-14  Tom Tromey  <tom@tromey.com>
7270
7271         * remote-notif.c (handle_notification, remote_notif_ack)
7272         (remote_notif_parse): Make "buf" const.
7273         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7274         const.
7275         (remote_notif_parse, remote_notif_ack, handle_notification):
7276         Likewise.
7277         * remote.c (remote_notif_stop_parse): Make "buf" const.
7278         (remote_target::remote_parse_stop_reply): Make "buf" const.
7279         (remote_notif_stop_ack): Make "buf" const.
7280
7281 2019-01-14  Tom Tromey  <tom@tromey.com>
7282
7283         * remote.c (remote_console_output): Make parameter const.
7284
7285 2019-01-14  Tom Tromey  <tom@tromey.com>
7286
7287         * target-debug.h (target_debug_print_signals): Constify.
7288         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7289         * procfs.c (procfs_target::pass_signals): Update.
7290         * linux-nat.c (linux_nat_target::pass_signals): Update.
7291         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7292         * target-delegates.c: Rebuild.
7293         * remote.c (remote_target::program_signals): Update.
7294         (remote_target::pass_signals): Update.
7295         * target.c (target_pass_signals): Constify argument.
7296         (target_program_signals): Likewise.
7297         * target.h (struct target_ops) <pass_signals, program_signals>:
7298         Constify argument.
7299         (target_pass_signals, target_program_signals): Constify argument.
7300
7301 2019-01-14  Tom Tromey  <tom@tromey.com>
7302
7303         PR tui/28819:
7304         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7305
7306 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7307
7308         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7309         field.
7310         * rs6000-tdep.c: Include reggroups.h.
7311         (IS_V_ALIAS_PSEUDOREG): Define.
7312         (rs6000_register_name): Return names for the "vX" aliases.
7313         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7314         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7315         aliases.  Call default_register_reggroup_p for all other
7316         pseudo-registers.
7317         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7318         New functions.
7319         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7320         Handle "vX" aliases.
7321         (v_alias_pseudo_register_collect): New function.
7322         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7323         (rs6000_gdbarch_init): Initialize "vX" aliases as
7324         pseudo-registers.  Restore registration of
7325         rs6000_pseudo_register_reggroup_p with
7326         set_tdesc_pseudo_register_reggroup_p.
7327
7328 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7329
7330         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7331         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7332         set_gdbarch_num_pseudo_regs.
7333
7334 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7335
7336         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7337         Remove arg prefixname, add do_set and do_show.
7338         Add member functions set_list and show_list.
7339         * cli/cli-style.c (class cli_style_option): Update accordingly.
7340         (style_set_list): Move to file scope.
7341         (style_show_list): Likewise.
7342         (set_style): Call help_list.
7343         (show_style): Call cmd_show_list.
7344         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7345         Update to use the new macro.
7346
7347 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7348
7349         * ada-lang.c (_initialize_ada_language): Expand the help text
7350         for the "catch exception" command.
7351
7352 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7353
7354         * symtab.c (matching_obj_sections): Initialize obj,
7355         declare it closer to its usage.
7356
7357 2019-01-10  Tom Tromey  <tom@tromey.com>
7358
7359         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7360         (basic_inf_threads_range): Remove.
7361         (inf_threads_range, inf_non_exited_threads_range)
7362         (safe_inf_threads_range): Use next_adapter.
7363
7364 2019-01-10  Keith Seitz  <keiths@redhat.com>
7365
7366         PR gdb/23712
7367         PR symtab/23010
7368         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7369         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7370
7371 2019-01-10  Keith Seitz  <keiths@redhat.com>
7372
7373         PR gdb/23712
7374         PR symtab/23010
7375         * dictionary.c (pending_to_vector): Remove.
7376         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7377         Remove _1 suffix, replacing functions of the same name.  Update
7378         all callers.
7379         (dict_create_hashed, dict_create_hashed_expandable)
7380         (dict_create_linear, dict_create_linear_expandable, dict_free)
7381         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7382         Make functions static.
7383
7384 2019-01-10  Keith Seitz  <keiths@redhat.com>
7385
7386         PR gdb/23712
7387         PR symtab/23010
7388         * dictionary.h (struct dictionary): Replace declaration with
7389         multidictionary.
7390         (dict_create_hashed, dict_create_hashed_expandable)
7391         (dict_create_linear, dict_create_linear_expandable)
7392         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7393         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7394         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7395         taking multidictionary argument.
7396         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7397         * block.h (struct block) <dict>: Change to multidictionary
7398         and rename `multidict'.
7399         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7400         symmisc.c: Update all dictionary references to multidictionary.
7401
7402 2019-01-10  Keith Seitz  <keiths@redhat.com>
7403
7404         PR gdb/23712
7405         PR symtab/23010
7406         * dictionary.c: Include unordered_map.
7407         (pending_to_vector): New function.
7408         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7409         Rewrite the non-"_1" functions to take vector instead
7410         of linked list.
7411         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7412         "new" _1 versions of the same name.
7413         (multidictionary): Define.
7414         (std::hash<enum language): New definition.
7415         (collate_pending_symbols_by_language, mdict_create_hashed)
7416         (mdict_create_hashed_expandable, mdict_create_linear)
7417         (mdict_create_linear_expandable, mdict_free)
7418         (find_language_dictionary, create_new_language_dictionary)
7419         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7420         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7421         (mdict_size, mdict_empty): New functions.
7422         * dictionary.h (mdict_iterator): Define.
7423
7424 2019-01-10  Pedro Alves  <palves@redhat.com>
7425
7426         * breakpoint.c (read_uploaded_action)
7427         (create_tracepoint_from_upload): Adjust to use
7428         gdb::unique_xmalloc_ptr.
7429         * ctf.c (ctf_write_uploaded_tp):
7430         (SET_ARRAY_FIELD): Use emplace_back.
7431         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7432         * tracefile-tfile.c (tfile_write_uploaded_tp):
7433         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7434         gdb::unique_xmalloc_ptr.
7435         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7436         at_string, cond_string, cmd_strings>: Replace char pointers
7437         with gdb::unique_xmalloc_ptr.
7438
7439 2019-01-10  Pedro Alves  <palves@redhat.com>
7440
7441         * solib-target.c (library_list_start_library): Don't xstrdup name.
7442
7443 2019-01-10  Pedro Alves  <palves@redhat.com>
7444
7445         * mdebugread.c (parse_partial_symbols): Use
7446         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7447
7448 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7449
7450         * linux-fork.c (scoped_switch_fork_info)
7451         <~scoped_switch_fork_info>: Fix incorrect variable name.
7452
7453 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7454
7455         * linux-fork.c (scoped_switch_fork_info)
7456         <scoped_switch_fork_info>: Make explicit.
7457         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7458
7459 2019-01-10  Tom Tromey  <tom@tromey.com>
7460
7461         * objfiles.h (objfile::reset_psymtabs): Update.
7462         * objfiles.c (objfile::objfile): Update.
7463         * psymtab.h (psymtab_storage::obstack): Update.
7464         (psymtab_storage::m_obstack): Use gdb::optional.
7465         (class psymtab_storage): Update comment.  Remove objfile
7466         parameter.
7467         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7468
7469 2019-01-10  Tom Tromey  <tom@tromey.com>
7470
7471         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7472         <free_psymtabs>: Now private.
7473         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7474         (allocate_psymtab): Use new method.
7475
7476 2019-01-10  Tom Tromey  <tom@tromey.com>
7477
7478         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7479         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7480         * mdebugread.c (parse_partial_symbols): Use
7481         allocate_dependencies.
7482         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7483         allocate_dependencies.
7484         (process_psymtab_comp_unit_reader)
7485         (build_type_psymtab_dependencies): Likewise.
7486         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7487
7488 2019-01-10  Tom Tromey  <tom@tromey.com>
7489
7490         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7491         PSYMBOL_SET_LANGUAGE.
7492         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7493
7494 2019-01-10  Tom Tromey  <tom@tromey.com>
7495
7496         * psymtab.h (psymtab_storage::obstack): New method.
7497         <m_obstack>: Rename from obstack; now private.
7498         * psymtab.c (psymtab_storage): Update.
7499         * dwarf2read.c (create_addrmap_from_index)
7500         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7501         Update.
7502
7503 2019-01-10  Tom Tromey  <tom@tromey.com>
7504
7505         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7506         * objfiles.h (objfile::reset_psymtabs): New method.
7507
7508 2019-01-10  Tom Tromey  <tom@tromey.com>
7509
7510         * symmisc.c (print_symbol_bcache_statistics): Update.
7511         (print_objfile_statistics): Update.
7512         * symfile.c (reread_symbols): Update.
7513         * psymtab.h (class psymtab_storage): New.
7514         * psymtab.c (psymtab_storage): New constructor.
7515         (~psymtab_storage): New destructor.
7516         (require_partial_symbols): Update.
7517         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7518         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7519         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7520         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7521         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7522         (start_psymtab_common, end_psymtab_common)
7523         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7524         (allocate_psymtab): Update.
7525         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7526         Update.
7527         (dump_psymtab_addrmap, maintenance_print_psymbols)
7528         (maintenance_check_psymtabs): Update.
7529         (class objfile_psymtabs): Move to objfiles.h.
7530         * psympriv.h (discard_psymtab): Now inline.
7531         (psymtab_discarder::psymtab_discarder): Update.
7532         (psymtab_discarder::~psymtab_discarder): Update.
7533         (ALL_OBJFILE_PSYMTABS): Rewrite.
7534         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7535         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7536         Remove fields.
7537         <partial_symtabs>: New field.
7538         (class objfile_psymtabs): Move from psymtab.h.  Update.
7539         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7540         psymbol_cache.
7541         (objfile::~objfile): Don't destroy psymbol_cache.
7542         * mdebugread.c (parse_partial_symbols): Update.
7543         * dwarf2read.c (create_addrmap_from_index)
7544         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7545         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7546         (add_partial_subprogram, dwarf2_ranges_read): Update.
7547         * dwarf-index-write.c (write_address_map)
7548         (write_one_signatured_type, recursively_write_psymbols)
7549         (class debug_names, class debug_names, write_psymtabs_to_index):
7550         Update.
7551
7552 2019-01-10  Tom Tromey  <tom@tromey.com>
7553
7554         * symtab.h (SYMBOL_SET_NAMES): Update.
7555         (symbol_set_names): Update.
7556         (MSYMBOL_SET_NAMES): Update.
7557         * symtab.c (symbol_set_names): Change argument to be an
7558         objfile_per_bfd_storage.
7559         * psymtab.c (add_psymbol_to_bcache): Update.
7560         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7561
7562 2019-01-10  Tom Tromey  <tom@tromey.com>
7563
7564         * symtab.c (create_demangled_names_hash): Change argument to be an
7565         objfile_per_bfd_storage.
7566         (symbol_set_names): Update.
7567
7568 2019-01-10  Tom Tromey  <tom@tromey.com>
7569
7570         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7571         init_psymbol_list.
7572         * psymtab.c (init_psymbol_list): Do nothing if already called.
7573         * psympriv.h (init_psymbol_list): Add comment.
7574         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7575         init_psymbol_list.
7576         * dbxread.c (dbx_symfile_read): Unconditionally call
7577         init_psymbol_list.
7578
7579 2019-01-10  Tom Tromey  <tom@tromey.com>
7580
7581         * xcoffread.c (scan_xcoff_symtab): Update.
7582         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7583         "where".
7584         * mdebugread.c (parse_partial_symbols)
7585         (handle_psymbol_enumerators): Update.
7586         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7587         * dbxread.c (read_dbx_symtab): Update.
7588         * psympriv.h (psymbol_placement): New enum.
7589         (add_psymbol_to_list): Update.
7590
7591 2019-01-10  Tom Tromey  <tom@tromey.com>
7592
7593         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7594         static_psymbols parameters.
7595         (scan_xcoff_symtab): Update.
7596         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7597         static_psymbols parameters.
7598         * psympriv.h (start_psymtab_common): Update.
7599         * mdebugread.c (parse_partial_symbols): Update.
7600         * dwarf2read.c (create_partial_symtab): Update.
7601         * dbxread.c (read_dbx_symtab): Update.
7602         (start_psymtab): Remove global_psymbols and static_psymbols
7603         parameters.
7604
7605 2019-01-10  Tom Tromey  <tom@tromey.com>
7606
7607         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7608         * psymtab.c (allocate_psymtab): Add comment.
7609         * psympriv.h (allocate_psymtab): Add comment.
7610         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7611         initializations.
7612         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7613
7614 2019-01-10  Tom Tromey  <tom@tromey.com>
7615
7616         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7617         Don't declare.
7618         * mipsread.c: Include mdebugread.h.
7619         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7620         Declare.
7621         * elfread.c: Include mdebugread.h.
7622
7623 2019-01-09  Tom Tromey  <tom@tromey.com>
7624
7625         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7626         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7627         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7628         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7629         (psym_lookup_symbol, psym_find_last_source_symtab)
7630         (psym_forget_cached_source_info, psym_print_stats)
7631         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7632         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7633         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7634         (psym_find_compunit_symtab_by_address)
7635         (maintenance_print_psymbols, maintenance_info_psymtabs)
7636         (maintenance_check_psymtabs): Use ranged for.
7637         * psymtab.h (class objfile_psymtabs): New.
7638         (require_partial_symbols): Return objfile_psymtabs.
7639         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7640
7641 2019-01-09  Tom Tromey  <tom@tromey.com>
7642
7643         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7644         (find_pc_mapped_section, list_overlays_command)
7645         (map_overlay_command, unmap_overlay_command)
7646         (simple_overlay_update): Use all_objfiles.
7647         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7648         * printcmd.c (info_symbol_command): Use all_objfiles.
7649         * objfiles.h (ALL_OBJSECTIONS): Remove.
7650         * maint.c (maintenance_translate_address): Use all_objfiles.
7651         * gcore.c (gcore_create_callback): Use all_objfiles.
7652         (objfile_find_memory_regions): Likewise.
7653
7654 2019-01-09  Tom Tromey  <tom@tromey.com>
7655
7656         * symtab.c (find_line_symtab, info_sources_command)
7657         (make_source_files_completion_list): Use objfile_compunits.
7658         * source.c (select_source_symtab): Use objfile_compunits.
7659         * objfiles.h (struct objfile): Update comment.
7660         (ALL_OBJFILES): Remove.
7661         (ALL_FILETABS): Remove.
7662         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7663         objfile_compunits.
7664
7665 2019-01-09  Tom Tromey  <tom@tromey.com>
7666
7667         * symmisc.c (print_objfile_statistics, dump_objfile)
7668         (maintenance_print_symbols): Use compunit_filetabs.
7669         * source.c (forget_cached_source_info_for_objfile): Use
7670         compunit_filetabs.
7671         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7672         (ALL_FILETABS): Use compunit_filetabs.
7673         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7674         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7675
7676 2019-01-09  Tom Tromey  <tom@tromey.com>
7677
7678         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7679         (compunit_filetabs): New.
7680         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7681         compunit_filetabs.
7682         (info_sources_command, make_source_files_completion_list): Remove
7683         declaration.
7684         * symmisc.c (print_objfile_statistics, dump_objfile)
7685         (maintenance_print_symbols): Remove declaration.
7686         (maintenance_info_symtabs): Use compunit_filetabs.
7687         (maintenance_info_line_tables): Likewise.
7688         * source.c (select_source_symtab): Change local variable name.
7689         (forget_cached_source_info_for_objfile): Remove declaration.
7690         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7691         * objfiles.c (objfile_relocate1): Remove declaration.
7692         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7693         declaration.
7694         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7695         * coffread.c (coff_symtab_read): Remove declaration.
7696         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7697         compunit_filetabs.
7698
7699 2019-01-09  Tom Tromey  <tom@tromey.com>
7700
7701         * symtab.c (lookup_objfile_from_block)
7702         (find_pc_sect_compunit_symtab, search_symbols)
7703         (default_collect_symbol_completion_matches_break_on): Use
7704         objfile_compunits.
7705         * objfiles.h (ALL_COMPUNITS): Remove.
7706         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7707         * cp-support.c (add_symbol_overload_list_qualified): Use
7708         objfile_compunits.
7709         * ada-lang.c (ada_collect_symbol_completion_matches)
7710         (ada_add_global_exceptions): Use objfile_compunits.
7711
7712 2019-01-09  Tom Tromey  <tom@tromey.com>
7713
7714         * source.c (select_source_symtab)
7715         (forget_cached_source_info_for_objfile): Remove declaration.
7716         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7717         declaration.
7718         * maint.c (count_symtabs_and_blocks): Remove declaration.
7719         * cp-support.c (add_symbol_overload_list_qualified): Remove
7720         declaration.
7721         * coffread.c (coff_symtab_read): Remove declaration.
7722         * symtab.c (lookup_symbol_in_objfile_symtabs)
7723         (basic_lookup_transparent_type_1): Use objfile_compunits.
7724         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7725         (info_sources_command, search_symbols)
7726         (default_collect_symbol_completion_matches_break_on)
7727         (make_source_files_completion_list): Remove declaration.
7728         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7729         (ada_collect_symbol_completion_matches)
7730         (ada_add_global_exceptions): Remove declaration.
7731         * linespec.c (iterate_over_all_matching_symtabs): Use
7732         objfile_compunits.
7733         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7734         (class objfile_compunits): New.
7735         (ALL_COMPUNITS): Use objfile_compunits.
7736         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7737         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7738         objfile_compunits.
7739         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7740
7741 2019-01-09  Tom Tromey  <tom@tromey.com>
7742
7743         * symtab.c (search_symbols)
7744         (default_collect_symbol_completion_matches_break_on): Use
7745         objfile_msymbols.
7746         * ada-lang.c (ada_lookup_simple_minsym)
7747         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7748         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7749         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7750         objfile_msymbols.
7751         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7752         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7753         * objc-lang.c (find_methods): Use objfile_msymbols.
7754         (info_selectors_command, info_classes_command): Likewise.
7755         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7756         * objfiles.h (class objfile_msymbols): New.
7757         (ALL_OBJFILE_MSYMBOLS): Remove.
7758         (ALL_MSYMBOLS): Remove.
7759
7760 2019-01-09  Tom Tromey  <tom@tromey.com>
7761
7762         * common/next-iterator.h (next_adapter): Add Iterator template
7763         parameter.
7764         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7765         (class all_objfiles_safe): New.
7766         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7767         * objfiles.c (put_objfile_before): Update comment.
7768         (add_separate_debug_objfile): Likewise.
7769         (free_all_objfiles): Use all_objfiles_safe.
7770         (objfile_purge_solibs): Likewise.
7771
7772 2019-01-09  Tom Tromey  <tom@tromey.com>
7773
7774         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7775         (expand_symtab_containing_pc, lookup_static_symbol)
7776         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7777         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7778         all_objfiles.
7779         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7780         * breakpoint.c (create_overlay_event_breakpoint)
7781         (create_longjmp_master_breakpoint)
7782         (create_std_terminate_master_breakpoint)
7783         (create_exception_master_breakpoint): Use all_objfiles.
7784         * linux-thread-db.c (try_thread_db_load_from_pdir)
7785         (has_libpthread): Use all_objfiles.
7786         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7787         * linespec.c (iterate_over_all_matching_symtabs)
7788         (search_minsyms_for_name): Use all_objfiles.
7789         * maint.c (maintenance_info_sections): Use all_objfiles.
7790         * main.c (captured_main_1): Use all_objfiles.
7791         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7792         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7793         * guile/scm-pretty-print.c
7794         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7795         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7796         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7797         (maintenance_print_msymbols): Use all_objfiles.
7798         * source.c (select_source_symtab): Use all_objfiles.
7799         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7800         * symfile.c (remove_symbol_file_command)
7801         (expand_symtabs_matching, map_symbol_filenames): Use
7802         all_objfiles.
7803         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7804         all_objfiles.
7805         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7806         * objc-lang.c (find_methods): Use all_objfiles.
7807         * objfiles.c (have_partial_symbols, have_full_symbols)
7808         (have_minimal_symbols, qsort_cmp)
7809         (default_iterate_over_objfiles_in_search_order): Use
7810         all_objfiles.
7811         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7812         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7813         (maintenance_check_psymtabs): Use all_objfiles.
7814         (ALL_PSYMTABS): Remove.
7815         * compile/compile-object-run.c (do_module_cleanup): Use
7816         all_objfiles.
7817         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7818         * cp-support.c (add_symbol_overload_list_qualified): Use
7819         all_objfiles.
7820         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7821         Use all_objfiles.
7822         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7823         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7824         all_objfiles.
7825         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7826         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7827         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7828         Uses all_objfiles.
7829         * solib.c (solib_read_symbols): Use all_objfiles
7830
7831 2019-01-09  Tom Tromey  <tom@tromey.com>
7832
7833         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7834         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7835         all_objfiles.
7836         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7837         * symmisc.c (print_symbol_bcache_statistics)
7838         (print_objfile_statistics, maintenance_print_objfiles)
7839         (maintenance_info_symtabs, maintenance_check_symtabs)
7840         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7841         all_objfiles.
7842         * source.c (forget_cached_source_info): Use all_objfiles.
7843         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7844         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7845         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7846         * objfiles.c (update_section_map): Use all_objfiles.
7847         (shared_objfile_contains_address_p): Likewise.
7848         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7849         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7850
7851 2019-01-09  Tom Tromey  <tom@tromey.com>
7852
7853         * common/next-iterator.h: New file.
7854         * objfiles.h (class all_objfiles): New.
7855         (struct objfile_iterator): New.
7856
7857 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7858
7859         * NEWS: Move the description of the changed "frame", "select-frame",
7860          and "info frame" commands to the Changed commands section.
7861
7862 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7863
7864         * gdbtypes.c (check_stub_method_group): Remove handling of old
7865         mangling schemes.
7866         * linespec.c (find_methods): Likewise.
7867         * stabsread.c (read_member_functions): Likewise.
7868         * valops.c (search_struct_method): Likewise.
7869         (value_struct_elt_for_reference): Likewise.
7870         * NEWS: Mention this change.
7871
7872 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7873
7874         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7875         print_source_lines.
7876         * source.c (print_source_lines_base): Update line number check.
7877         (print_source_lines): New function.
7878         (source_lines_range::source_lines_range): New function.
7879         * source.h (class source_lines_range): New class.
7880         (print_source_lines): New declaration.
7881
7882 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7883
7884         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7885
7886 2019-01-08  Tom Tromey  <tom@tromey.com>
7887             Simon Marchi  <simon.marchi@ericsson.com>
7888
7889         PR gdb/24060
7890         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7891         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7892         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7893         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7894         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7895         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7896
7897 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7898
7899         * source.c (select_source_symtab): Move header comment to
7900         declaration in source.h.
7901         (forget_cached_source_info_for_objfile): Likewise.
7902         (forget_cached_source_info): Likewise.
7903         (identify_source_line): Likewise.
7904         * source.h (identify_source_line): Move declaration from symtab.h
7905         and add comment from source.c
7906         (print_source_lines): Likewise.
7907         (forget_cached_source_info_for_objfile): Likewise.
7908         (forget_cached_source_info): Likewise.
7909         (select_source_symtab): Likewise.
7910         (enum print_source_lines_flag): Move definition from symtab.h.
7911         * symtab.h (identify_source_line): Move declaration to source.h.
7912         (print_source_lines): Likewise.
7913         (forget_cached_source_info_for_objfile): Likewise.
7914         (forget_cached_source_info): Likewise.
7915         (select_source_symtab): Likewise.
7916         (enum print_source_lines_flag): Move definition to source.h.
7917         * tui/tui-hooks.c: Add 'source.h' include.
7918
7919 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7920
7921         * source.c (print_source_lines_base): Handle requests to print
7922         reverse line number sequences, and guard against empty lines
7923         string.
7924
7925 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7926
7927         * source.c (print_source_lines_base): Fix skip of '\r' if next
7928         character is '\n'.
7929
7930 2019-01-06  Tom Tromey  <tom@tromey.com>
7931
7932         * c-exp.y (struct c_parse_state) <macro_original_text,
7933         expansion_obstack>: New member.
7934         (macro_original_text, expansion_obstack): Remove globals.
7935         (scan_macro_expansion, scanning_macro_expansion)
7936         (finished_macro_expansion): Update.
7937         (scan_macro_cleanup): Remove.
7938         (yylex, c_parse): Update.
7939
7940 2019-01-06  Tom Tromey  <tom@tromey.com>
7941
7942         * c-exp.y (struct c_parse_state) <strings>: New member.
7943         (operator_stoken): Update.
7944
7945 2019-01-06  Tom Tromey  <tom@tromey.com>
7946
7947         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7948         (union type_stack_elt) <typelist_val>: Now a pointer to
7949         std::vector.
7950         (type_stack_cleanup): Don't declare.
7951         (push_typelist): Update.
7952         * parse.c (pop_typelist): Return a std::vector.
7953         (push_typelist): Take a std::vector.
7954         (follow_types): Update.  Do not free args.
7955         (type_stack_cleanup): Remove.
7956         * c-exp.y (struct c_parse_state): New.
7957         (cpstate): New global.
7958         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7959         (nonempty_typelist): Update.
7960         (func_mod): Create a new vector.
7961         (c_parse): Create a c_parse_state.
7962         (check_parameter_typelist): Do not delete params.
7963         (function_method): Update.  Do not delete type_list.
7964
7965 2019-01-06  Tom Tromey  <tom@tromey.com>
7966
7967         PR gdb/28155:
7968         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7969         check_typedef.
7970         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7971         (print_return_value): Likewise.
7972
7973 2019-01-05  Tom Tromey  <tom@tromey.com>
7974
7975         * contrib/cleanup_check.py: Remove.
7976         * contrib/gcc-with-excheck: Remove.
7977         * contrib/exsummary.py: Remove.
7978         * contrib/excheck.py: Remove.
7979
7980 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7981
7982         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7983         NULL. Initialize tpprev to NULL instead of assigning it
7984         to NULL on the next statement.
7985         * windows-nat.c (windows_delete_thread): Remove check for
7986         main_thread_id before printing thread exit notifications.
7987         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7988         Remove thread ID check against main_thread_id.
7989         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7990         windows_delete_thread.
7991         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7992
7993 2019-01-04  Tom Tromey  <tom@tromey.com>
7994
7995         * compile/compile.c (_initialize_compile): Use upper case for
7996         metasyntactic variables.
7997         * symmisc.c (_initialize_symmisc): Use upper case for
7998         metasyntactic variables.
7999         * psymtab.c (_initialize_psymtab): Use upper case for
8000         metasyntactic variables.
8001         * demangle.c (demangle_command): Use upper case for metasyntactic
8002         variables.
8003         (_initialize_demangler): Likewise.
8004         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8005         variables.
8006
8007 2019-01-03  Tom Tromey  <tom@tromey.com>
8008
8009         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8010
8011 2019-01-03  Tom Tromey  <tom@tromey.com>
8012
8013         * python/py-symtab.c (salpy_str): Update.
8014         (struct salpy_sal_object) <symtab>: Now a PyObject.
8015         (salpy_dealloc): Update.
8016         (del_objfile_sal): Use gdbpy_ref.
8017
8018 2019-01-03  Tom Tromey  <tom@tromey.com>
8019
8020         * python/py-type.c (convert_field): Use new_reference.  Return
8021         gdbpy_ref.
8022         (make_fielditem): Return gdbpy_ref.
8023         (typy_fields): Update.
8024         (typy_getitem): Update.
8025         (field_name): Return gdbpy_ref.  Use new_reference.
8026         (typy_iterator_iternext): Update.
8027
8028 2019-01-03  Tom Tromey  <tom@tromey.com>
8029
8030         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8031
8032 2019-01-03  Tom Tromey  <tom@tromey.com>
8033
8034         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8035         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8036         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8037         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8038         (pspy_set_type_printers): Likewise.
8039         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8040         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8041         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8042         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8043         (objfpy_set_type_printers): Likewise.
8044
8045 2019-01-03  Tom Tromey  <tom@tromey.com>
8046
8047         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8048         (gdbpy_print_stack): Use gdbpy_err_fetch.
8049         * python/python-internal.h (class gdbpy_err_fetch): New class.
8050         (class gdbpy_enter) <m_error_type, m_error_value,
8051         m_error_traceback>: Remove.
8052         <m_error>: New member.
8053         (gdbpy_exception_to_string): Don't declare.
8054         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8055         * python/py-value.c (convert_value_from_python): Use
8056         gdbpy_err_fetch.
8057         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8058         gdbpy_exception_to_string.
8059         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8060         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8061         gdbpy_err_fetch.
8062
8063 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8064
8065         * linux-nat.c (delete_lwp_cleanup): Delete.
8066         (struct lwp_deleter): New struct.
8067         (lwp_info_up): New typedef.
8068         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8069         lwp_info_up.
8070
8071 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8072
8073         * linux-fork.c (class scoped_switch_fork_info): New class.
8074         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8075
8076 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8077
8078         * valops.c (find_overload_match): Remove use of null_cleanup, and
8079         calls to do_cleanups.
8080
8081 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8082
8083         * compile/compile-cplus-types.c
8084         (compile_cplus_instance::decl_name): Handle changes to
8085         cp_func_name.
8086         * cp-support.c (cp_func_name): Update header comment, update
8087         return type.
8088         * cp-support.h (cp_func_name): Update return type in declaration.
8089         * valops.c (find_overload_match): Move temp_func local to top
8090         level of function and change its type.  Use temp_func to hold and
8091         delete temporary string obtained from cp_func_name.
8092
8093 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8094
8095         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8096         gdb::char_vector, remove cleanup, and update uses of `msg`.
8097
8098 2019-01-03  Jim Wilson  <jimw@sifive.com>
8099
8100         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8101
8102 2019-01-02  Tom Tromey  <tom@tromey.com>
8103
8104         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8105         (tdesc_parse_xml): Remove cleanups.
8106         * target-descriptions.h (make_cleanup_free_target_description):
8107         Don't declare.
8108         (target_desc_deleter): New struct.
8109         (target_desc_up): New typedef.
8110         * target-descriptions.c (target_desc_deleter::operator()): Rename
8111         from free_target_description.
8112         (make_cleanup_free_target_description): Remove.
8113
8114 2019-01-02  Tom Tromey  <tom@tromey.com>
8115
8116         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8117         constructor, destructor.
8118         (linespec_parser): Remove typedef.
8119         (~linespec_parser): Rename from linespec_parser_delete.
8120         (linespec_lex_to_end, linespec_complete_label)
8121         (linespec_complete): Update.
8122         (decode_line_full): Remove cleanups.
8123         (decode_line_1): Update.
8124
8125 2019-01-02  Tom Tromey  <tom@tromey.com>
8126
8127         * python/python-internal.h (inferior_to_inferior_object): Change
8128         return type.
8129         * python/py-exitedevent.c (create_exited_event_object): Update.
8130         * python/py-inferior.c (inferior_to_inferior_object): Return
8131         gdbpy_ref.
8132         (python_new_inferior, python_inferior_deleted)
8133         (thread_to_thread_object, delete_thread_object)
8134         (build_inferior_list, gdbpy_selected_inferior): Update.
8135         * python/py-infthread.c (create_thread_object): Update.  Also fail
8136         if inferior_to_inferior_object fails.
8137
8138 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8139
8140         * inferior.h (class inferior) <displaced_step_state>: New field.
8141         * infrun.h (struct displaced_step_state): Move here from
8142         infrun.c.  Initialize fields, add constructor.
8143         <inf>: Remove field.
8144         <reset>: New method.
8145         * infrun.c (struct displaced_step_inferior_state): Move to
8146         infrun.h.
8147         (displaced_step_inferior_states): Remove.
8148         (get_displaced_stepping_state): Adust.
8149         (displaced_step_in_progress_any_inferior): Adjust.
8150         (displaced_step_in_progress_thread): Adjust.
8151         (displaced_step_in_progress): Adjust.
8152         (add_displaced_stepping_state): Remove.
8153         (get_displaced_step_closure_by_addr): Adjust.
8154         (remove_displaced_stepping_state): Remove.
8155         (infrun_inferior_exit): Call displaced_step_state.reset.
8156         (use_displaced_stepping): Don't check for NULL.
8157         (displaced_step_prepare_throw): Call
8158         get_displaced_stepping_state.
8159         (displaced_step_fixup): Don't check for NULL.
8160         (prepare_for_detach): Don't check for NULL.
8161
8162 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8163
8164         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8165          in case of call that did not complete.
8166
8167 2019-01-02  Andrey Utkin  <autkin@undo.io>
8168
8169         * symfile.c (find_separate_debug_file): Fix search of debug files for
8170         remote debuggee.
8171
8172 2019-01-02  Tom Tromey  <tom@tromey.com>
8173
8174         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8175         indentation.
8176         * python/py-frame.c (frapy_older): Remove cast.
8177         (frapy_newer): Likewise.
8178         * python/py-breakpoint.c (local_setattro): Remove cast.
8179         * python/py-arch.c (archpy_name): Remove local variable.
8180         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8181
8182 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8183
8184         * unittests/basic_string_view/element_access/char/empty.cc:
8185         Fix year range in copyright header.
8186
8187 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8190         Delete.
8191         <operator==>: Update with for removed field.
8192         <hash>: Likewise.
8193         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8194         <isa_features>: ...this.
8195         <abi_features>: New field.
8196         (riscv_isa_flen): Update comment.
8197         (riscv_abi_xlen): New declaration.
8198         (riscv_abi_flen): New declaration.
8199         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8200         isa_features.
8201         (riscv_abi_xlen): New function.
8202         (riscv_isa_flen): Update to get answer from isa_features.
8203         (riscv_abi_flen): New function.
8204         (riscv_has_fp_abi): Update to get answer from abi_features.
8205         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8206         xlen and flen.
8207         (riscv_call_info) <xlen, flen>: Update comment.
8208         (riscv_call_arg_struct): Remove invalid assertions
8209         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8210         is removed.
8211         (riscv_gdbarch_init): Gather isa features and abi features
8212         separately, ensure both match on the gdbarch when reusing an old
8213         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8214         a target with 64-bit float hardware.
8215
8216 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8217
8218         * source.c (search_command_helper): Stop reverse search
8219         when line 1 has been searched.
8220
8221 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8222
8223         * record-full.c (record_full_base_target::close): Rewrite
8224         record_full_core_buf_list free logic.
8225
8226 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8227
8228         * break-catch-syscall.c (print_one_catch_syscall): xfree
8229         the last text.
8230
8231 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8232
8233         * top.c (print_gdb_version): Update Copyright year in version
8234         message.
8235
8236 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8237
8238         Update copyright year range in all GDB files.
8239
8240 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8241
8242         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8243
8244 For older changes see ChangeLog-2018.
8245 \f
8246 Local Variables:
8247 mode: change-log
8248 left-margin: 8
8249 fill-column: 74
8250 version-control: never
8251 coding: utf-8
8252 End:
8253