gdb/ChangeLog

   1 2019-10-09  Tom de Vries  <tdevries@suse.de>
   2
   3         * python/lib/gdb/printer/bound_registers.py: Use
   4         '^builtin_type_bound128' as regexp argument for
   5         add_builtin_pretty_printer.
   6
   7 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
   8
   9         * guile/guile.c (guile_extension_script_ops): Remove forward
  10         declaration and mark as static.
  11         (guile_script_ops): Likewise.
  12         (extension_language_guile): Move further down in the file so
  13         it can reference the definitions for guile_{extension_,}script_ops.
  14
  15 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
  16
  17         * s390-tdep.c (390_process_record): Handle new arch13 instructions
  18         except SORTL, DFLTCC, and KDSA.
  19
  20 2019-10-08  Tom Tromey  <tromey@adacore.com>
  21
  22         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
  23         (struct safe_symbol_file_add_args): Remove.
  24
  25 2019-10-08  Tom Tromey  <tromey@adacore.com>
  26
  27         * windows-nat.c: Don't include buildsym-legacy.h.
  28
  29 2019-10-08  Tom Tromey  <tromey@adacore.com>
  30
  31         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
  32
  33 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
  34
  35         * gdbtypes.c (overload_debug): Move comment to header.
  36         * gdbtypes.h (overload_debug): Declare.
  37         * valops.c: Remove declaration of overload_debug, instead
  38         include gdbtypes.h.
  39
  40 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
  41
  42         * language.c (show_language_command): Pass lang_frame_mismatch_warn
  43         through _().
  44         (lang_frame_mismatch_warn): Make const, mark with N_(), and
  45         move comment...
  46         * language.h (lang_frame_mismatch_warn): ... here. Also add
  47         declaration.
  48         * top.c (lang_frame_mismatch_warn): Remove declaration.
  49         (check_frame_language_change): Pass lang_frame_mismatch_warn
  50         through _().
  51
  52 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
  53
  54         * c-lang.h (vtbl_ptr_name): Declare.
  55         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
  56         it from the header.
  57         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
  58
  59 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
  60
  61         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
  62         gdb_static_assert.
  63
  64 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
  65
  66         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
  67         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
  68         * ctfread.c: New file.
  69         * ctfread.h: New file.
  70         * elfread.c: Include ctfread.h.
  71         (struct elfinfo text_p): New member ctfsect.
  72         (elf_locate_sections): Mark CTF section.
  73         (elf_symfile_read): Call elfctf_build_psymtabs.
  74         * Makefile.in (LIBCTF): Add.
  75         (CLIBS): Use it.
  76         (CDEPS): Likewise.
  77         (DIST): Add ctfread.c.
  78
  79 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
  80
  81         * ctfread.c (struct nextfield): Renamed to ...
  82         (struct ctf_nextfield): ... this.
  83         (struct field_info): Renamed to ...
  84         (strut ctf_field_info): ... this.
  85         (attach_fields_to_type): Update for renamed structures.
  86         (ctf_add_member_cb): Likewise.
  87         (ctf_add_enum_member_cb): Likewise.
  88         (process_struct_members): Likewise.
  89         (process_enum_type): Likewise.
  90
  91 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
  92
  93         * tracectf.h: Rename, was ctf.h.
  94         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
  95         * tracefile.c: Likewise.
  96         * tracepoint.c: Remove unused include ctf.h.
  97         * mi/mi-main.c: Likewise.
  98         * Makefile.in Replace ctf.c with tracectf.c.
  99
 100 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 101
 102         * version.in: Change version number to "9.0.50.DATE-git".
 103
 104 2019-10-03  Tom Tromey  <tom@tromey.com>
 105
 106         PR rust/24976:
 107         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 108
 109 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 110
 111         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 112         cp_search_name_hash.
 113         * NEWS: Add entry about nested function support.
 114
 115 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 116             Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 119         for nested static variables when searchin VAR_DOMAIN.
 120         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 121         global scope, update comment.
 122         (add_partial_subprogram): Call add_partial_subprogram recursively
 123         for nested subroutines when processinng Fortran.
 124         (load_partial_dies): Process the child entities of a subprogram
 125         when processing Fortran.
 126         (partial_die_parent_scope): Handle building scope
 127         for Fortran nested functions.
 128         (process_die): Record that nested functions have a scope.
 129         (new_symbol): Always record Fortran subprograms on the global
 130         symbol list.
 131         (determine_prefix): How to build the prefix for Fortran
 132         subprograms.
 133
 134 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 135
 136         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 137         have just sent the thread a SIGSTOP and are waiting for it to
 138         arrive.
 139
 140 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 141
 142         * btrace.c (btrace_add_pc): Remove whitespace before the template
 143         parameter in 'std::vector <...>'.
 144         (parse_xml_btrace_block): Likewise.
 145         (btrace_maint_decode_pt): Likewise.
 146         (btrace_maint_update_packets): Likewise.
 147         (btrace_maint_print_packets): Likewise.
 148         * btrace.h (struct btrace_maint_info): Likewise.
 149         * dwarf2read.c (struct type_unit_group): Likewise.
 150         (build_type_psymtabs_reader): Likewise.
 151         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 152         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 153         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 154
 155 2019-10-03  Tom de Vries  <tdevries@suse.de>
 156
 157         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 158         the first line of the help text for set/show style metadata.
 159
 160 2019-10-02  Tom Tromey  <tromey@adacore.com>
 161
 162         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 163         * gdbsupport/common-inferior.c: New file.
 164         * infcmd.c (startup_with_shell): Don't define.
 165         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 166         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 167         * inferior.h (startup_with_shell): Don't declare.
 168
 169 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 170
 171         * gdbsupport/gdb_assert.h: Include errors.h.
 172         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 173
 174 2019-10-02  Tom Tromey  <tromey@adacore.com>
 175
 176         * NEWS: Add $_ada_exception entry.
 177         * ada-lang.c (struct ada_catchpoint): Add constructor.
 178         <m_kind>: New member.
 179         (allocate_location_exception, re_set_exception): Remove
 180         "ex" parameter.
 181         (should_stop_exception): Compute $_ada_exception.
 182         (check_status_exception, print_it_exception)
 183         (print_one_exception, print_mention_exception): Remove
 184         "ex" parameter.
 185         (allocate_location_catch_exception, re_set_catch_exception)
 186         (check_status_exception, print_it_catch_exception)
 187         (print_one_catch_exception, print_mention_catch_exception)
 188         (print_recreate_catch_exception)
 189         (allocate_location_catch_exception_unhandled)
 190         (re_set_catch_exception_unhandled)
 191         (check_status_exception, print_it_catch_exception_unhandled)
 192         (print_one_catch_exception_unhandled)
 193         (print_mention_catch_exception_unhandled)
 194         (print_recreate_catch_exception_unhandled)
 195         (allocate_location_catch_assert, re_set_catch_assert)
 196         (check_status_assert, print_it_catch_assert)
 197         (print_one_catch_assert, print_mention_catch_assert)
 198         (print_recreate_catch_assert)
 199         (allocate_location_catch_handlers, re_set_catch_handlers)
 200         (check_status_handlers, print_it_catch_handlers)
 201         (print_one_catch_handlers, print_mention_catch_handlers)
 202         (print_recreate_catch_handlers): Remove.
 203         (create_ada_exception_catchpoint): Update.
 204         (initialize_ada_catchpoint_ops): Update.
 205
 206 2019-10-02  Tom Tromey  <tromey@adacore.com>
 207
 208         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 209         (create_excep_cond_exprs): Simplify exception string computation.
 210         (ada_exception_catchpoint_cond_string): Likewise.
 211
 212 2019-10-02  Tom Tromey  <tromey@adacore.com>
 213
 214         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 215         * ada-lang.c (lesseq_defined_than): Handle
 216         LOC_STATIC.
 217         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 218         parameter.
 219         (dwarf2_has_info): Likewise.
 220         (new_symbol): Set maybe_copied on symbol when
 221         appropriate.
 222         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 223         parameter.
 224         <can_copy>: New member.
 225         * elfread.c (record_minimal_symbol): Set maybe_copied
 226         on symbol when appropriate.
 227         (elf_symfile_read): Update call to dwarf2_has_info.
 228         * minsyms.c (lookup_minimal_symbol_linkage): New
 229         function.
 230         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 231         * symtab.c (get_symbol_address, get_msymbol_address):
 232         New functions.
 233         * symtab.h (get_symbol_address, get_msymbol_address):
 234         Declare.
 235         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 236         maybe_copied.
 237         (struct symbol, struct minimal_symbol) <maybe_copied>:
 238         New member.
 239
 240 2019-10-02  Tom Tromey  <tromey@adacore.com>
 241
 242         * source.c (struct current_source_location): New.
 243         (current_source_key): New global.
 244         (current_source_symtab, current_source_line)
 245         (current_source_pspace): Remove.
 246         (get_source_location): New function.
 247         (get_current_source_symtab_and_line)
 248         (set_default_source_symtab_and_line)
 249         (set_current_source_symtab_and_line)
 250         (clear_current_source_symtab_and_line, select_source_symtab)
 251         (info_source_command, print_source_lines_base)
 252         (info_line_command, search_command_helper, _initialize_source):
 253         Update.
 254
 255 2019-10-02  Tom Tromey  <tromey@adacore.com>
 256
 257         * source.c (select_source_symtab): Don't call
 258         decode_line_with_current_source.
 259
 260 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * symtab.c (lookup_global_symbol): Search global block.
 263
 264 2019-10-02  Tom Tromey  <tromey@adacore.com>
 265
 266         * coffread.c (process_coff_symbol): Update.
 267         * dwarf2read.c (var_decode_location, new_symbol): Update.
 268         * mdebugread.c (parse_symbol): Update.
 269         * objfiles.c (relocate_one_symbol): Update.
 270         * stabsread.c (define_symbol, fix_common_block)
 271         (scan_file_globals): Update.
 272         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 273         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 274         * xcoffread.c (process_xcoff_symbol): Update.
 275
 276 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 277
 278         * MAINTAINERS: Update my email address.
 279
 280 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 281
 282         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 283         std::vector.
 284         (build_type_psymtabs_reader): Update for std::vector.
 285         (build_type_psymtab_dependencies): Likewise.
 286         * dwarf2read.h: Remove use of DEF_VEC_P.
 287         (typedef sig_type_ptr): Delete.
 288
 289 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 290
 291         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 292         to std::vector.
 293         (btrace_maint_decode_pt): Likewise, and move allocation of the
 294         vector outside of the loop.
 295         (btrace_maint_update_packets): Update to handle change from VEC to
 296         std::vector.
 297         (btrace_maint_print_packets): Likewise.
 298         (maint_info_btrace_cmd): Likewise.
 299         * btrace.h: Remove use of DEF_VEC_O.
 300         (typedef btrace_pt_packet_s): Delete.
 301         (struct btrace_maint_info) <packets>: Change fromm VEC to
 302         std::vector.
 303         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 304
 305 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 306
 307         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 308         make accesses into the vector constant references.
 309         (btrace_add_pc): Update for std::vector.
 310         (btrace_stitch_bts): Likewise.
 311         (parse_xml_btrace_block): Likewise.
 312         (btrace_maint_update_packets): Likewise.
 313         (btrace_maint_print_packets): Likewise.
 314         (maint_info_btrace_cmd): Likewise.
 315         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 316         std::vector.
 317         (btrace_data::empty): Likewise.
 318         (btrace_data_append): Likewise.
 319         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 320         (typedef btrace_block_s): Delete.
 321         (struct btrace_block): Add constructor.
 322         (struct btrace_data_bts) <blocks>: Change to std::vector.
 323         * nat/linux-btrace.c (perf_event_read_bts): Update for
 324         std::vector.
 325         (linux_read_bts): Likewise.
 326
 327 2019-10-01  Tom Tromey  <tom@tromey.com>
 328
 329         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 330
 331 2019-10-01  Tom Tromey  <tom@tromey.com>
 332
 333         * stack.c (print_frame, info_frame_command_core): Use
 334         styled_string.
 335         * linux-thread-db.c (try_thread_db_load_1)
 336         (try_thread_db_load_from_pdir_1): Use styled_string.
 337         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 338         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 339         (maybe_print_unsupported_script_warning)
 340         (maybe_print_script_not_found_warning): Use styled_string.
 341         * ada-lang.c (user_select_syms): Use styled_string.
 342
 343 2019-10-01  Tom Tromey  <tom@tromey.com>
 344
 345         * p-lang.c (pascal_printstr): Use metadata style.
 346         * value.c (show_convenience): Use metadata style.
 347         * valprint.c (valprint_check_validity, val_print_optimized_out)
 348         (val_print_not_saved, val_print_unavailable)
 349         (val_print_invalid_address, generic_val_print, val_print)
 350         (value_check_printable, val_print_array_elements): Use metadata
 351         style.
 352         * ui-out.h (class ui_out) <field_fmt>: New overload.
 353         <do_field_fmt>: Add style parameter.
 354         * ui-out.c (ui_out::field_fmt): New overload.
 355         * typeprint.c (type_print_unknown_return_type)
 356         (val_print_not_allocated, val_print_not_associated): Use metadata
 357         style.
 358         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 359         parameter.
 360         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 361         * tracepoint.c (tvariables_info_1): Use metadata style.
 362         * stack.c (print_frame_arg, print_frame_info, print_frame)
 363         (info_frame_command_core): Use metadata style.
 364         * skip.c (info_skip_command): Use metadata style.
 365         * rust-lang.c (rust_print_enum): Use metadata style.
 366         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 367         metadata style.
 368         * python/py-framefilter.c (py_print_single_arg): Use metadata
 369         style.
 370         * printcmd.c (do_one_display, print_variable_and_value): Use
 371         metadata style.
 372         * p-valprint.c (pascal_val_print)
 373         (pascal_object_print_value_fields): Use metadata style.
 374         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 375         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 376         parameter.
 377         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 378         * m2-valprint.c (m2_print_long_set): Use metadata style.
 379         * m2-typeprint.c (m2_print_type): Use metadata style.
 380         * infcmd.c (print_return_value_1): Use metadata style.
 381         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 382         * f-valprint.c (info_common_command_for_block): Use metadata
 383         style.
 384         * f-typeprint.c (f_type_print_base): Use metadata style.
 385         * expprint.c (print_subexp_standard): Use metadata style.
 386         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 387         * cli/cli-style.h (class cli_style_option): Add constructor.
 388         (metadata_style): Declare.
 389         * cli/cli-style.c (metadata_style): New global.
 390         (_initialize_cli_style): Register metadata style.
 391         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 392         parameter.
 393         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 394         * c-typeprint.c (c_type_print_base_struct_union)
 395         (c_type_print_base_1): Use metadata style.
 396         * breakpoint.c (watchpoint_value_print)
 397         (print_one_breakpoint_location): Use metadata style.
 398         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 399         style.
 400         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 401         style.
 402         * ada-valprint.c (val_print_packed_array_elements, printstr)
 403         (print_field_values, ada_val_print_ref, ada_val_print): Use
 404         metadata style.
 405         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 406         style.
 407         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 408         style.
 409         * ada-lang.c (user_select_syms): Use metadata style.
 410
 411 2019-10-01  Tom Tromey  <tom@tromey.com>
 412
 413         * cli/cli-cmds.c (pwd_command): Style output.
 414
 415 2019-10-01  Pedro Alves  <palves@redhat.com>
 416             Tom Tromey  <tom@tromey.com>
 417
 418         * symtab.c (print_symbol_info): Use %ps.
 419         (print_msymbol_info): Use %ps.
 420         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 421         * printcmd.c (print_variable_and_value): Use %ps.
 422         * macrocmd.c (show_pp_source_pos): Use %ps.
 423         * infrun.c (print_exited_reason): Use ui_out::message.
 424         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 425         (describe_other_breakpoints): Use ui_out::message and new
 426         formats.
 427         (say_where): Use new formats.
 428         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 429         and new formats.
 430
 431 2019-10-01  Pedro Alves  <palves@redhat.com>
 432             Tom Tromey  <tom@tromey.com>
 433
 434         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 435         (test_gdb_formats): New function.
 436         (run_tests): Call it.
 437         (test_format_specifier): Update.
 438         * utils.h (fputs_filtered): Update comment.
 439         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 440         (fputs_styled_unfiltered): Declare.
 441         * utils.c (fputs_styled_unfiltered): New function.
 442         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 443         (vfprintf_filtered): Update.
 444         (vfprintf_unfiltered, vprintf_filtered): Update.
 445         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 446         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 447         disallow_ui_out_field>: New constants.
 448         (enum class field_kind): New.
 449         (struct base_field_s, struct signed_field_s): New.
 450         (signed_field): New function.
 451         (struct string_field_s): New.
 452         (string_field): New function.
 453         (struct styled_string_s): New.
 454         (styled_string): New function.
 455         (class ui_out) <message>: Add comment.
 456         <vmessage, call_do_message>: New methods.
 457         <do_message>: Add style parameter.
 458         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 459         methods.
 460         (ui_out::message): Rewrite.
 461         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 462         parameter.
 463         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 464         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 465         gdb_extensions parameter.
 466         (class format_piece): Add parameter to constructor.
 467         (n_int_args): New field.
 468         * gdbsupport/format.c (format_pieces::format_pieces): Add
 469         gdb_extensions parameter.  Handle '*'.
 470         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 471         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 472         vfprintf_styled_no_gdbfmt.
 473         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 474         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 475         unfiltered output.
 476         * ui-style.h (struct ui_file_style) <ptr>: New method.
 477
 478 2019-10-01  Tom Tromey  <tom@tromey.com>
 479
 480         * unittests/format_pieces-selftests.c: Update.  Add final format.
 481         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 482         empty literal pieces.
 483
 484 2019-10-01  Tom Tromey  <tom@tromey.com>
 485
 486         * ui-out.h (enum class ui_out_style_kind): Remove.
 487         (class ui_out) <field_string, field_stsream, do_field_string>:
 488         Change type of "style".
 489         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 490         (ui_out::field_string): Update.
 491         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 492         of "style".
 493         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 494         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 495         * stack.c (print_frame_arg, print_frame_info, print_frame):
 496         Update.
 497         * source.c (print_source_lines_base): Update.
 498         * solib.c (info_sharedlibrary_command): Update.
 499         * skip.c (info_skip_command): Update.
 500         * record-btrace.c (btrace_call_history_src_line)
 501         (btrace_call_history): Update.
 502         * python/py-framefilter.c (py_print_frame): Update.
 503         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 504         "style".
 505         * mi/mi-out.c (mi_ui_out::do_table_header)
 506         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 507         (mi_ui_out::do_field_string): Update.
 508         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 509         Update.
 510         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 511         "style".
 512         * cli-out.c (cli_ui_out::do_table_header)
 513         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 514         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 515         (cli_ui_out::do_field_fmt): Update.
 516         * breakpoint.c (print_breakpoint_location): Update.
 517         (update_static_tracepoint): Update.
 518
 519 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 520
 521         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 522         conversion of gdb_datadir.
 523         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 524         remove not needed c_str ().
 525
 526 2019-09-30  Ali Tamur <tamur@google.com>
 527
 528         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 529         (dwarf2_string_attr): Likewise.
 530
 531 2019-09-30  Ali Tamur <tamur@google.com>
 532
 533         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 534         (process_full_type_unit): Likewise.
 535         (dump_die_shallow): Likewise.
 536         (cu_debug_loc_section): Likewise.
 537
 538 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 539
 540         * minsyms.c (compare_minimal_symbols): Rename to...
 541         (minimal_symbol_is_less_than): ...this, and adjust to STL
 542         conventions (return bool, take arguments as references)
 543         (minimal_symbol_reader::install): Call std::sort instead
 544         of qsort.
 545
 546 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 547
 548         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 549         hash and why.
 550         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 551         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 552
 553 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 554
 555         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 556         * psympriv.h (add_psymbol_to_list): Move comment here and update
 557         it.
 558
 559 2019-09-29  Tom de Vries  <tdevries@suse.de>
 560
 561         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 562         Use $tmpdir/$(basename "$output_file").dwz instead of
 563         "${output_file}.dwz".
 564
 565 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 566
 567         PR gdb/25045
 568         * hppa-linux-nat.c: Include gdbarch.h.
 569
 570 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 571
 572         * blockframe.c (find_pc_partial_function): Change return type to bool.
 573         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 574         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 575         (stub_gnu_ifunc_resolve_name): Likewise.
 576         * symtab.c (compare_filenames_for_search): Likewise.
 577         (compare_glob_filenames_for_search): Likewise.
 578         (matching_obj_sections): Likewise.
 579         (symbol_matches_domain): Likewise.
 580         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 581         (find_line_pc): Change return type to bool.
 582         (find_line_pc_range): Likewise.
 583         (producer_is_realview): Likewise.
 584         * symtab.h (symbol_matches_domain): Likewise.
 585         (find_pc_partial_function): Likewise.
 586         (find_pc_line_pc_range): Likewise.
 587         (in_gnu_ifunc_stub): Likewise.
 588         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 589         (find_line_pc): Likewise.
 590         (find_line_pc_range): Likewise.
 591         (matching_obj_sections): Likewise.
 592         (find_line_symtab): Change out parameter to bool.
 593         (producer_is_realview): Change return type to bool.
 594         (compare_filenames_for_search): Likewise.
 595         (compare_glob_filenames_for_search): Likewise.
 596
 597 2019-09-26  Tom Tromey  <tom@tromey.com>
 598
 599         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 600         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 601         * gdb_usleep.h: Remove.
 602         * gdb_usleep.c: Remove.
 603         * utils.c: Don't include gdb_usleep.h.
 604
 605 2019-09-26  Tom Tromey  <tromey@adacore.com>
 606
 607         * python/py-type.c (type_to_type_object): Call check_typedef
 608         for stub types.
 609
 610 2019-09-26  Tom Tromey  <tom@tromey.com>
 611
 612         * utils.h (initialize_utils): Don't declare.
 613         * top.c (gdb_init): Don't call initialize_utils.
 614         * utils.c (initialize_utils): Remove.  Move contents...
 615         (_initialize_utils): ... here.
 616
 617 2019-09-25  Tom Tromey  <tom@tromey.com>
 618
 619         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 620         * utils.h (make_hex_string): Don't declare.
 621         * utils.c (make_hex_string): Remove.
 622
 623 2019-09-24  Tom de Vries  <tdevries@suse.de>
 624
 625         PR gdb/23815
 626         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 627         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 628
 629 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 630
 631         * NEWS: Mention new simulator port for PRU.
 632
 633 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 634
 635         * ada-exp.y (write_object_remaining): Update.
 636         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 637         and eliminate the static buffer.
 638         (ada_decode_symbol): Update.
 639         (ada_la_decode): Update.
 640         (ada_sniff_from_mangled_name): Update.
 641         (is_valid_name_for_wild_match): Update.
 642         (ada_lookup_name_info::matches): Update and simplify.
 643         (name_matches_regex): Update.
 644         (ada_add_global_exceptions): Update.
 645         * ada-lang.h (ada_decode): Update signature.
 646         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 647         * dwarf-index-write.c (debug_names::insert): Update.
 648
 649 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 650
 651         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 652         formatting.
 653
 654 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 655
 656         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 657         Change "nonzero" to "true" in documentation.
 658
 659 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 660
 661         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 662         (_initialize_darwin_solib): Don't set
 663         darwin_so_ops.lookup_lib_global_symbol.
 664         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 665         set_gdbarch_iterate_over_objfiles_in_search_order.
 666         (elf_lookup_lib_symbol): Rename to...
 667         (svr4_iterate_over_objfiles_in_search_order): this, and update
 668         to iterate semantics.
 669         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 670         * solib.c (solib_global_lookup): Remove.
 671         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 672         (solib_global_lookup): Remove.
 673         * symtab.c (lookup_global_or_static_symbol): Remove call to
 674         solib_global_lookup.
 675
 676 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 677
 678         * NEWS: Move entries about default MI version now being
 679         version 3, and about the GDB/MI fix for multi-location
 680         breakpoints to the "since GDB 8.3" section.
 681
 682 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 683
 684         GDB 8.3.1 released.
 685
 686 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 687
 688         * NEWS: Mention that Cell/B.E. debugging support was removed.
 689         * MAINTAINERS: Remove spu target.
 690
 691         * config/djgpp/fnchange.lst: Remove entries for removed files.
 692
 693         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 694         spu-multiarch.o, and spu-tdep.o.
 695         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 696         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 697         spu-multiarch.c, and spu-tdep.c.
 698         * spu-linux-nat.c: Remove file.
 699         * spu-multiarch.c: Remove file.
 700         * spu-tdep.c: Remove file.
 701         * spu-tdep.h: Remove file.
 702         * solib-spu.c: Remove file.
 703         * solib-spu.h: Remove file.
 704
 705         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 706         * configure.nat (spu-linux): Remove.
 707         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 708         solib-multiarch.o from gdb_target_obs.
 709         (spu*-*-*): Remove.
 710
 711         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 712         feature flag.
 713         (ppc_linux_no_features): Update.
 714         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 715         Cell/B.E. support.
 716         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 717         (tdesc_powerpc_cell64l): Likewise.
 718         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 719         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 720         Cell/B.E. support.
 721         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 722         Do not include "features/rs6000/powerpc-cell32l.c" or
 723         "features/rs6000/powerpc-cell64l.c".
 724         (ppc_linux_spu_section): Remove.
 725         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 726         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 727         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 728         (ppc_linux_spe_context_lookup): Remove.
 729         (ppc_linux_spe_context_inferior_created): Remove.
 730         (ppc_linux_spe_context_solib_loaded): Remove.
 731         (ppc_linux_spe_context_solib_unloaded): Remove.
 732         (ppc_linux_spe_context): Remove.
 733         (struct ppu2spu_cache): Remove.
 734         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 735         (struct ppu2spu_data): Remove.
 736         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 737         ppu2spu_unwind): Remove.
 738         (ppc_linux_init_abi): Remove Cell/B.E. support.
 739         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 740
 741         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 742         (rs6000/powerpc-cell64l-expedite): Likewise
 743         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 744         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 745         rs6000/powerpc-cell64l.xml.
 746         * features/rs6000/powerpc-cell32l.xml: Remove.
 747         * features/rs6000/powerpc-cell64l.xml: Likewise.
 748         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 749         * features/rs6000/powerpc-cell64l.c: Likewise.
 750         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 751         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 752         * regformats/reg-spu.dat: Remove.
 753
 754         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 755         * corelow.c (struct spuid_list): Remove.
 756         (add_to_spuid_list): Remove.
 757         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 758         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 759         (remote_protocol_features): Remove associated entries.
 760         (_initialize_remote): No longer initialize them.
 761         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 762         * linux-nat.c (SPUFS_MAGIC): Remove.
 763         (linux_proc_xfer_spu): Remove.
 764         (spu_enumerate_spu_ids): Remove.
 765         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 766         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 767         (linux_make_corefile_notes): No longer call it.
 768
 769         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 770         (cooked_write_test): Likewise.
 771
 772 2019-09-20  Tom Tromey  <tom@tromey.com>
 773
 774         * NEWS: Mention case-sensitivity of TUI commands.
 775         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 776         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 777         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 778
 779 2019-09-20  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-source.c (tui_source_window::set_contents): Use
 782         make_unique_xstrdup.
 783         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 784         make_unique_xstrdup.
 785
 786 2019-09-20  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-data.c: Remove separator comments.
 789         * tui/tui-layout.c: Remove separator comments.
 790         * tui/tui-win.c: Remove separator comments.
 791         * tui/tui-wingeneral.c: Remove separator comments.
 792
 793 2019-09-20  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui.h (strcat_to_buf): Don't declare.
 796         * tui/tui.c (strcat_to_buf): Remove.
 797
 798 2019-09-20  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 801         from "fullname".
 802         * tui/tui-source.c (tui_source_window::set_contents)
 803         (tui_source_window::location_matches_p)
 804         (tui_source_window::maybe_update): Update.
 805
 806 2019-09-20  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 809         Update.
 810         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 811         prefix.
 812         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 813         (tui_data_window::line_from_reg_element_no)
 814         (tui_data_window::first_reg_element_no_inline)
 815         (tui_data_window::show_registers)
 816         (tui_data_window::show_register_group)
 817         (tui_data_window::display_registers_from)
 818         (tui_data_window::display_registers_from_line)
 819         (tui_data_window::first_data_item_displayed)
 820         (tui_data_window::delete_data_content_windows)
 821         (tui_data_window::erase_data_content)
 822         (tui_data_window::do_scroll_vertical)
 823         (tui_data_window::refresh_window)
 824         (tui_data_window::check_register_values): Update.
 825
 826 2019-09-20  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 829         (struct tui_locator_window) <full_name, proc_name>: Now
 830         std::string.
 831         * tui/tui-stack.c (tui_locator_window::make_status_line)
 832         (tui_locator_window::set_locator_fullname)
 833         (tui_locator_window::set_locator_info): Update.
 834         * tui/tui-source.c (tui_source_window::set_contents)
 835         (tui_source_window::showing_source_p): Update.
 836
 837 2019-09-20  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 840         Don't call tui_locator_win_info_ptr.
 841
 842 2019-09-20  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 845
 846 2019-09-20  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 849         height for locator.
 850         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 851         * tui/tui-layout.c (show_source_disasm_command, show_data)
 852         (show_source_or_disasm_and_command): Use 1 as height for locator.
 853
 854 2019-09-20  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui.c (tui_enable): Update.
 857         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 858         Update.
 859         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 860         Update.
 861         * tui/tui-data.c (win_resized): Now bool.
 862         (tui_win_resized): Return bool.
 863         (tui_set_win_resized_to): Accept a bool.
 864
 865 2019-09-20  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 868         Change type of "refresh_values_only".
 869         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 870         type of "refresh_values_only".
 871
 872 2019-09-20  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 875         std::string.
 876         (tui_disassemble): Add "pos" parameter.
 877         (tui_disasm_window::set_contents): Simplify.
 878
 879 2019-09-20  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-winsource.h (struct tui_source_window_base)
 882         <show_source_content>: Now private.
 883         * tui/tui-winsource.c
 884         (tui_source_window_base::show_source_content): Don't handle empty
 885         content case.
 886
 887 2019-09-20  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-layout.c (show_source_disasm_command)
 890         (show_source_or_disasm_and_command): Don't call
 891         show_source_content.
 892
 893 2019-09-20  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 896         Declare.
 897         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 898         from tui_make_status_line.
 899         (tui_locator_window::rerender): Update.
 900
 901 2019-09-20  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 904         (tui_locator_window::rerender): Update.
 905
 906 2019-09-20  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-winsource.h (struct tui_source_window_base)
 909         <~tui_source_window_base>: Don't declare.
 910         <fullname>: Remove.
 911         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 912         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 913         member.
 914         * tui/tui-source.c (tui_source_window::set_contents): Update.
 915         (tui_source_window::location_matches_p)
 916         (tui_source_window::maybe_update): Update.
 917
 918 2019-09-20  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-winsource.h (~tui_source_element): Remove.
 921         (tui_source_element): Update.
 922         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 923         * tui/tui-winsource.c (tui_show_source_line): Update.
 924         * tui/tui-source.c (tui_source_window::set_contents): Update.
 925         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 926
 927 2019-09-20  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 930         declare.
 931         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 932         tui_clear_source_windows_detail.
 933         * tui/tui-winsource.h (struct tui_source_window_base)
 934         <clear_detail>: Don't declare.
 935         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 936         Remove.
 937         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 938
 939 2019-09-20  Tom Tromey  <tromey@adacore.com>
 940
 941         PR ada/24919:
 942         * block.c (contained_in): Fix final return value.
 943
 944 2019-09-20  Alan Modra  <amodra@gmail.com>
 945
 946         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 947         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 948         (read_indirect_string_from_dwz): Use bfd accessor.
 949         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 950         * machoread.c (macho_symfile_read_all_oso): Likewise.
 951         * solib.c (solib_bfd_open): Likewise.
 952
 953 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 954
 955         * eval.c: Move declaration of overload_resolution to...
 956         * value.h: ...here.
 957
 958 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 959
 960         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 961         * arm-linux-tdep.c: Likewise.
 962         * arm-nbsd-nat.c: Likewise.
 963         * arm-tdep.h: Declare arm_apcs_32.
 964         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 965
 966 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 967
 968         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 969         * dwarf2read.h: Declare dwarf_always_disassemble.
 970
 971 2019-09-19  Tom de Vries  <tdevries@suse.de>
 972
 973         PR gdb/25009
 974         * source-cache.c (source_cache::ensure): Catch exception thrown during
 975         construction of the highlighter.
 976
 977 2019-09-18  Alan Modra  <amodra@gmail.com>
 978
 979         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 980         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 981         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 982         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 983         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 984         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 985         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 986         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 987         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 988         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 989         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 990         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 991         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 992         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 993         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 994         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 995         * mi/mi-interp.c: Update throughout for bfd section macro and
 996         function changes.
 997         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 998         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 999
1000 2019-09-18  Tom Tromey  <tom@tromey.com>
1001
1002         * NEWS: Add entry.
1003         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1004         call rl_initialize.
1005         (tui_enable): Do not call rl_initialize.
1006
1007 2019-09-18  Christian Groessler  <chris@groessler.org>
1008
1009         * alpha-linux-nat.c: Include gdbarch.h.
1010
1011 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1012
1013         * ui-file.c: Include cli/cli-style.h.
1014         (term_cli_styling): Remove cli_styling declaration.
1015
1016 2019-09-18  Alan Modra  <amodra@gmail.com>
1017
1018         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1019         to bfd_asymbol_section.
1020
1021 2019-09-18  Alan Modra  <amodra@gmail.com>
1022
1023         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1024         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1025         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1026
1027 2019-09-18  Alan Modra  <amodra@gmail.com>
1028
1029         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1030         * spu-linux-nat.c (spu_bfd_open): Likewise.
1031
1032 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1033
1034         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1035         to bool to match definition in dwarf2read.c.
1036
1037 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1038
1039         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1040         (print_signatures): Likewise.
1041         (trust_pad_over_xvs): Likewise.
1042         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1043         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1044         * arm-linux-nat.c (arm_apcs_32): Likewise.
1045         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1046         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1047         * arm-tdep.c (arm_debug): Likewise.
1048         (arm_apcs_32): Likewise.
1049         * auto-load.c (debug_auto_load): Likewise.
1050         (auto_load_gdb_scripts): Likewise.
1051         (global_auto_load): Likewise.
1052         (auto_load_local_gdbinit): Likewise.
1053         (auto_load_local_gdbinit_loaded): Likewise.
1054         * auto-load.h (global_auto_load): Likewise.
1055         (auto_load_local_gdbinit): Likewise.
1056         (auto_load_local_gdbinit_loaded): Likewise.
1057         * breakpoint.c (disconnected_dprintf): Likewise.
1058         (breakpoint_proceeded): Likewise.
1059         (automatic_hardware_breakpoints): Likewise.
1060         (always_inserted_mode): Likewise.
1061         (target_exact_watchpoints): Likewise.
1062         (_initialize_breakpoint): Update.
1063         * breakpoint.h (target_exact_watchpoints): Change to bool.
1064         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1065         * cli/cli-cmds.c (trace_commands): Likewise.
1066         * cli/cli-cmds.h (trace_commands): Likewise.
1067         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1068         to bool*.
1069         * cli/cli-logging.c (logging_overwrite): Change to bool.
1070         (logging_redirect): Likewise.
1071         (debug_redirect): Likewise.
1072         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1073         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1074         to bool.
1075         <boolean_option_def>: Update.
1076         (struct flag_option_def): Change default type of Context to bool
1077         from int.
1078         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1079         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1080         (get_setshow_command_value_string): Likewise.
1081         * cli/cli-style.c (cli_styling): Change to bool.
1082         (source_styling): Likewise.
1083         * cli/cli-style.h (source_styling): Likewise.
1084         (cli_styling): Likewise.
1085         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1086         to bool.
1087         * command.h (var_types): Update comment.
1088         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1089         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1090         bool.
1091         (debug_compile_cplus_scopes): Likewise.
1092         * compile/compile-internal.h (compile_debug): Likewise.
1093         * compile/compile.c (compile_debug): Likewise.
1094         (struct compile_options) <raw>: Likewise.
1095         * cp-support.c (catch_demangler_crashes): Likewise.
1096         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1097         (usr_cmd_cris_dwarf2_cfi): Likewise.
1098         * csky-tdep.c (csky_debug): Likewise.
1099         * darwin-nat.c (enable_mach_exceptions): Likewise.
1100         * dcache.c (dcache_enabled_p): Likewise.
1101         * defs.h (info_verbose): Likewise.
1102         * demangle.c (demangle): Likewise.
1103         (asm_demangle): Likewise.
1104         * dwarf-index-cache.c (debug_index_cache): Likewise.
1105         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1106         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1107         * dwarf2read.c (check_physname): Likewise.
1108         (use_deprecated_index_sections): Likewise.
1109         (dwarf_always_disassemble): Likewise.
1110         * eval.c (overload_resolution): Likewise.
1111         * event-top.c (set_editing_cmd_var): Likewise.
1112         (exec_done_display_p): Likewise.
1113         * event-top.h (set_editing_cmd_var): Likewise.
1114         (exec_done_display_p): Likewise.
1115         * exec.c (write_files): Likewise.
1116         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1117         (debug_fbsd_nat): Likewise.
1118         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1119         Likewise.
1120         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1121         <backtrace_past_entry> Likewise.
1122         * gdb-demangle.h (demangle): Likewise.
1123         (asm_demangle): Likewise.
1124         * gdb_bfd.c (bfd_sharing): Likewise.
1125         * gdbcore.h (write_files): Likewise.
1126         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1127         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1128         * gdbthread.h (print_thread_events): Likewise.
1129         * gdbtypes.c (opaque_type_resolution): Likewise.
1130         (strict_type_checking): Likewise.
1131         * gnu-nat.c (gnu_debug_flag): Likewise.
1132         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1133         * guile/scm-param.c (pascm_variable): Add boolval.
1134         (add_setshow_generic): Update.
1135         (pascm_param_value): Update.
1136         (pascm_set_param_value_x): Update.
1137         * hppa-tdep.c (hppa_debug): Change to bool..
1138         * infcall.c (may_call_functions_p): Likewise.
1139         (coerce_float_to_double_p): Likewise.
1140         (unwind_on_signal_p): Likewise.
1141         (unwind_on_terminating_exception_p): Likewise.
1142         * infcmd.c (startup_with_shell): Likewise.
1143         * inferior.c (print_inferior_events): Likewise.
1144         * inferior.h (startup_with_shell): Likewise.
1145         (print_inferior_events): Likewise.
1146         * infrun.c (step_stop_if_no_debug): Likewise.
1147         (detach_fork): Likewise.
1148         (debug_displaced): Likewise.
1149         (disable_randomization): Likewise.
1150         (non_stop): Likewise.
1151         (non_stop_1): Likewise.
1152         (observer_mode): Likewise.
1153         (observer_mode_1): Likewise.
1154         (set_observer_mode): Update.
1155         (sched_multi): Change to bool.
1156         * infrun.h (debug_displaced): Likewise.
1157         (sched_multi): Likewise.
1158         (step_stop_if_no_debug): Likewise.
1159         (non_stop): Likewise.
1160         (disable_randomization): Likewise.
1161         * linux-tdep.c (use_coredump_filter): Likewise.
1162         (dump_excluded_mappings): Likewise.
1163         * linux-thread-db.c (auto_load_thread_db): Likewise.
1164         (check_thread_db_on_load): Likewise.
1165         * main.c (captured_main_1): Update.
1166         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1167         xx2_opt, boolean_opt>: Change to bool.
1168         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1169         * maint.c (maintenance_profile_p): Likewise.
1170         (per_command_time): Likewise.
1171         (per_command_space): Likewise.
1172         (per_command_symtab): Likewise.
1173         * memattr.c (inaccessible_by_default): Likewise.
1174         * mi/mi-main.c (mi_async): Likewise.
1175         (mi_async_1): Likewise.
1176         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1177         * nat/fork-inferior.h (startup_with_shell): Likewise.
1178         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1179         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1180         * nios2-tdep.c (nios2_debug): Likewise.
1181         * or1k-tdep.c (or1k_debug): Likewise.
1182         * parse.c (parser_debug): Likewise.
1183         * parser-defs.h (parser_debug): Likewise.
1184         * printcmd.c (print_symbol_filename): Likewise.
1185         * proc-api.c (procfs_trace): Likewise.
1186         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1187         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1188         (set_parameter_value): Update.
1189         (add_setshow_generic): Update.
1190         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1191         to bool*.
1192         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1193         int*.
1194         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1195         * record-btrace.c (record_btrace_target::store_registers): Update.
1196         * record-full.c (record_full_memory_query): Change to bool.
1197         (record_full_stop_at_limit): Likewise.
1198         * record-full.h (record_full_memory_query): Likewise.
1199         * remote-notif.c (notif_debug): Likewise.
1200         * remote-notif.h (notif_debug): Likewise.
1201         * remote.c (use_range_stepping): Likewise.
1202         (interrupt_on_connect): Likewise.
1203         (remote_break): Likewise.
1204         * ser-tcp.c (tcp_auto_retry): Likewise.
1205         * ser-unix.c (serial_hwflow): Likewise.
1206         * skip.c (debug_skip): Likewise.
1207         * solib-aix.c (solib_aix_debug): Likewise.
1208         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1209         (spu_auto_flush_cache_p): Likewise.
1210         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1211         Likewise.
1212         (struct info_print_options) <quiet>: Likewise.
1213         * symfile-debug.c (debug_symfile): Likewise.
1214         * symfile.c (auto_solib_add): Likewise.
1215         (separate_debug_file_debug): Likewise.
1216         * symfile.h (auto_solib_add): Likewise.
1217         (separate_debug_file_debug): Likewise.
1218         * symtab.c (basenames_may_differ): Likewise.
1219         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1220         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1221         (struct info_types_options) <quiet>: Likewise.
1222         * symtab.h (demangle): Likewise.
1223         (basenames_may_differ): Likewise.
1224         * target-dcache.c (stack_cache_enabled_1): Likewise.
1225         (code_cache_enabled_1): Likewise.
1226         * target.c (trust_readonly): Likewise.
1227         (may_write_registers): Likewise.
1228         (may_write_memory): Likewise.
1229         (may_insert_breakpoints): Likewise.
1230         (may_insert_tracepoints): Likewise.
1231         (may_insert_fast_tracepoints): Likewise.
1232         (may_stop): Likewise.
1233         (auto_connect_native_target): Likewise.
1234         (target_stop_and_wait): Update.
1235         (target_async_permitted): Change to bool.
1236         (target_async_permitted_1): Likewise.
1237         (may_write_registers_1): Likewise.
1238         (may_write_memory_1): Likewise.
1239         (may_insert_breakpoints_1): Likewise.
1240         (may_insert_tracepoints_1): Likewise.
1241         (may_insert_fast_tracepoints_1): Likewise.
1242         (may_stop_1): Likewise.
1243         * target.h (target_async_permitted): Likewise.
1244         (may_write_registers): Likewise.
1245         (may_write_memory): Likewise.
1246         (may_insert_breakpoints): Likewise.
1247         (may_insert_tracepoints): Likewise.
1248         (may_insert_fast_tracepoints): Likewise.
1249         (may_stop): Likewise.
1250         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1251         (make_thread_apply_all_options_def_group): Change argument from int*
1252         to bool*.
1253         (thread_apply_all_command): Update.
1254         (print_thread_events): Change to bool.
1255         * top.c (confirm): Likewise.
1256         (command_editing_p): Likewise.
1257         (history_expansion_p): Likewise.
1258         (write_history_p): Likewise.
1259         (info_verbose): Likewise.
1260         * top.h (confirm): Likewise.
1261         (history_expansion_p): Likewise.
1262         * tracepoint.c (disconnected_tracing): Likewise.
1263         (circular_trace_buffer): Likewise.
1264         * typeprint.c (print_methods): Likewise.
1265         (print_typedefs): Likewise.
1266         * utils.c (debug_timestamp): Likewise.
1267         (sevenbit_strings): Likewise.
1268         (pagination_enabled): Likewise.
1269         * utils.h (sevenbit_strings): Likewise.
1270         (pagination_enabled): Likewise.
1271         * valops.c (overload_resolution): Likewise.
1272         * valprint.h (struct value_print_options) <prettyformat_arrays,
1273         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1274         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1275         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1276         Likewise.
1277         * windows-nat.c (new_console): Likewise.
1278         (cygwin_exceptions): Likewise.
1279         (new_group): Likewise.
1280         (debug_exec): Likewise.
1281         (debug_events): Likewise.
1282         (debug_memory): Likewise.
1283         (debug_exceptions): Likewise.
1284         (useshell): Likewise.
1285         * windows-tdep.c (maint_display_all_tib): Likewise.
1286         * xml-support.c (debug_xml): Likewise.
1287
1288 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1289
1290         * source.c (prepare_path_for_appending): New function.
1291         (openp): Make use of new function.
1292         (find_and_open_source): Search for the compilation directory and
1293         source file as a relative path beneath the directory search path.
1294
1295 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * source-cache.c (source_cache::get_line_charpos): Catch
1298         exceptions and return false, this matches the behaviour documented
1299         in the header file.
1300
1301 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1302
1303         * ada-tasks.c (info_task): Remove quoting of the task's name.
1304
1305 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1306
1307         * symfile.c (auto_solib_add): Replace comment with a reference
1308         to the header file.
1309
1310 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1311
1312         * NEWS: Mention that gdb can now be compiled with Python 3
1313         on Windows.
1314
1315 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * maint.c (maint_print_section_data::maint_print_section_data):
1318         Force use of 'float log10 (float)' by casting the argument to
1319         float.
1320
1321 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1322
1323         * maint.c: Add 'cmath' include.
1324         (struct maint_print_section_data): New structure.
1325         (print_section_index): New function.
1326         (print_bfd_section_info): Add header comment, small whitespace
1327         cleanup, and update to call new print_section_index function.
1328         (print_objfile_section_info): Likewise.
1329         (maint_obj_section_from_bfd_section): New function.
1330         (print_bfd_section_info_maybe_relocated): New function.
1331         (maintenance_info_sections): Add header comment, always use
1332         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1333
1334 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1337         inner scope, add check that the objfile has psymtabs before
1338         checking psymtabs_addrmap.
1339         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1340
1341 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1342
1343         * NEWS: Announce that Ada task names are now shown at more places,
1344         and between quotes (except in info task output).
1345         * gdb/ada-tasks.c (task_to_str): New function.
1346         (display_current_task_id): Call task_to_str.
1347         (task_command_1): Likewise.
1348         (print_ada_task_info): In non-mi mode, Properly align headers and data
1349         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1350
1351 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1352
1353         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1354         prstatus.pr_lwp.pr_info instead of making it up.
1355
1356 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1357
1358         * auto-load.c (auto_load_expand_dir_vars): Update.
1359         * defs.h (gdb_datadir): Change to std::string.
1360         (python_libdir): Likewise.
1361         (relocate_gdb_directory): Change return type to std::string.
1362         * guile/guile.c (gdbscm_data_directory): Update.
1363         (initialize_scheme_side): Update.
1364         * jit.c (jit_reader_dir): Change to std::string.
1365         (jit_reader_load_command): Update.
1366         * main.c (gdb_datadir): Change to std::string.
1367         (python_libdir): Likewise.
1368         (set_gdb_data_directory): Update.
1369         (relocate_path): Change to return std::string.
1370         (relocate_gdb_directory): Change to return std::string.
1371         (relocate_gdbinit_path_maybe_in_datadir): Update.
1372         (captured_main_1): Update.
1373         * python/python.c (do_start_initialization): Update.
1374         * top.c (show_gdb_datadir): Update.
1375         * xml-syscall.c (xml_init_syscalls_info): Update.
1376         (init_syscalls_info): Update.
1377
1378 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1379
1380         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1381         out of get_init_files.
1382         (get_init_files): Update.
1383
1384 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1385
1386         * main.c (get_init_files): Change to use std::string.
1387         (captured_main_1): Update.
1388         (print_gdb_help): Update.
1389
1390 2019-09-11  Ali Tamur  <tamur@google.com>
1391
1392         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1393         implementation.
1394
1395 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1396
1397         * dbxread.c (read_dbx_symtab): Update.
1398         * dwarf2read.c (load_partial_dies): Update.
1399         * mdebugread.c (parse_partial_symbols): Update.
1400         (handle_psymbol_enumerators): Update.
1401         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1402         * psymtab.c (add_psymbol_to_bcache): Likewise.
1403         (add_psymbol_to_list): Likewise.
1404         * symtab.c (symbol_set_names): Likewise.
1405         * symtab.h (symbol_set_names): Likewise.
1406         * xcoffread.c (scan_xcoff_symtab): Update.
1407
1408 2019-09-11  Tom Tromey  <tom@tromey.com>
1409
1410         * symfile-mem.c (symbol_file_add_from_memory): Use
1411         bfd_set_filename.
1412         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1413         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1414
1415 2019-09-10  Tom Tromey  <tromey@adacore.com>
1416
1417         * dwarf-index-write.c (write_psymbols): Extend error message.
1418         (debug_names::insert): Add Ada code.
1419         (debug_names::write_psymbols): Remove Ada check.
1420         (debug_names) <m_string_obstack>: New member.
1421         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1422         (gdb_index_symbol_name_matcher::matches): Remove.
1423         (mapped_index_base::find_name_components_bounds): Add "lang"
1424         parameter.
1425         (mapped_index_base::build_name_components): Also split names
1426         according to Ada syntax.
1427         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1428         type of "match_callback".
1429         (check_match, check_find_bounds_finds)
1430         (dw2_expand_symtabs_matching): Update.
1431         (dw2_debug_names_iterator): Add new constructor.
1432         (dw2_debug_names_map_matching_symbols): New function.
1433         (dw2_debug_names_expand_symtabs_matching): Update.
1434         (dwarf2_debug_names_functions): Use
1435         dw2_debug_names_map_matching_symbols.
1436
1437 2019-09-10  Tom Tromey  <tromey@adacore.com>
1438
1439         * dwarf2read.c (dw2_get_file_names_reader): Add the
1440         CU's file name to the results.
1441
1442 2019-09-10  Tom Tromey  <tromey@adacore.com>
1443
1444         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1445         map_matching_symbols.  Update.
1446         * dwarf2read.c (dw2_map_matching_symbols): Update.
1447         * psymtab.c (match_partial_symbol): Change type; update.
1448         (psym_map_matching_symbols): Likewise.
1449         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1450         type; update.
1451         * symfile.h (struct quick_symbol_functions)
1452         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1453         Remove "match".
1454
1455 2019-09-10  Tom Tromey  <tromey@adacore.com>
1456
1457         * psymtab.c (map_block): Remove.
1458         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1459         * symtab.c (iterate_over_symbols_terminated): New function.
1460         * symtab.c (iterate_over_symbols_terminated): Declare.
1461
1462 2019-09-10  Tom Tromey  <tromey@adacore.com>
1463
1464         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1465         * language.h (struct language_defn) <la_iterate_over_symbols>:
1466         Return bool.
1467         * symtab.c (iterate_over_symbols): Return bool.
1468         * symtab.h (iterate_over_symbols): Return bool.
1469
1470 2019-09-10  Tom Tromey  <tromey@adacore.com>
1471
1472         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1473         (add_nonlocal_symbols): Update.
1474         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1475         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1476         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1477         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1478         Change type of "callback".  Remove "data".
1479
1480
1481 2019-09-09  Ali Tamur  <tamur@google.com>
1482
1483         * dwarf2read.c (comp_unit_head): Update comment.
1484         (dwarf2_dwo_name): New function declaration.
1485         (dwarf_unit_type_name): New function declaration.
1486         (read_comp_unit_head): Add support for new compilation units,
1487         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1488         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1489         (currently named as "signature") in their header. Also clarify error
1490         messages.
1491         (lookup_dwo_id): New function. Returns the dwo id of the given
1492         compile unit.
1493         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1494         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1495         functions.
1496         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1497         (dwarf2_dwo_name): Get the dwo name if present.
1498         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1499         purposes.
1500
1501 2019-09-09  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1504
1505 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1506
1507         * python/python.c (do_start_initialization): Make progname_copy static,
1508         to avoid a leak report.
1509
1510 2019-09-08  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1513
1514 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1515
1516         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1517         Change type to gdb::optional<block_enum>.
1518         (dw2_symtab_iter_init): Change block_index parameter type
1519         to gdb::optional<block_enum>.
1520         (dw2_lookup_symbol): Change block_index parameter
1521         type to block_enum.c
1522         (dw2_debug_names_lookup_symbol): Likewise.
1523         * psymtab.c (psym_lookup_symbol): Likewise.
1524         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1525         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1526         Likewise.
1527
1528 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1529
1530         * defs.h (relocate_gdb_directory): Change int to bool in
1531         signature and rename flag to relocatable.
1532         * main.c (relocate_path): Likewise.
1533         (relocate_gdb_directory): Likewise.
1534
1535 2019-09-06  Alan Modra  <amodra@gmail.com>
1536
1537         * coffread.c (coff_symfile_read): Constify filename variable.
1538         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1539         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1540         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1541         * solib.c (reload_shared_libraries_1): Likewise.
1542         * symfile.c (reread_symbols): Likewise.
1543         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1544         * solib-darwin.c (darwin_bfd_open): Likewise.
1545         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1546
1547 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1550         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1551
1552 2019-09-03  Tom Tromey  <tromey@adacore.com>
1553
1554         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1555         types.
1556         (has_negatives): Unbias a range type bound.
1557         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1558         * gdbtypes.c (operator==): Handle new field.
1559         (create_range_type): Add "bias" parameter.
1560         (create_static_range_type, resolve_dynamic_range): Update.
1561         * gdbtypes.h (struct range_bounds) <bias>: New member.
1562         (create_range_type): Add bias parameter.
1563         * printcmd.c (print_scalar_formatted): Unbias range types.
1564         * value.c (unpack_long): Unbias range types.
1565         (pack_long): Bias range types.
1566
1567 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1568
1569         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1570         probe arguments.
1571
1572 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1573
1574         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1575         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1576         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1577         (compile_probe_arg): Likewise.
1578         * probe.h (get_argument_count): Likewise.
1579         * solib-svr4.c (solib_event_probe_action): Likewise.
1580         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1581
1582 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1583
1584         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1585         code to here...
1586         (svr4_create_solib_event_breakpoints): ...from here.
1587
1588 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1589
1590         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1591         suffix from warning message.
1592
1593 2019-08-30  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-winsource.h (struct tui_source_window_base)
1596         <refresh_all>: Don't declare.
1597         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1598         Remove.
1599         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1600         tui_show_locator_content.
1601         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1602         declare.
1603         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1604         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1605         declare.
1606
1607 2019-08-30  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1610
1611 2019-08-30  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1614         Remove unnecessary forward declarations.
1615
1616 2019-08-30  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1619         rerender.
1620         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1621         tui_show_locator_content.
1622
1623 2019-08-30  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1626         (tui_locator_window::rerender): Rewrite using body of previous
1627         tui_show_locator_content.
1628
1629 2019-08-30  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1632         set_locator_fullname>: New methods.
1633         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1634         Rename from tui_set_locator_fullname.
1635         (tui_locator_window::set_locator_info): Rename from
1636         tui_set_locator_info.  Return bool.
1637         (tui_update_locator_fullname, tui_show_frame_info): Update.
1638
1639 2019-08-30  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1642
1643 2019-08-30  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1646         call touchwin.
1647
1648 2019-08-30  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-wingeneral.c (box_win): Assume win_info and
1651         win_info->handle cannot be NULL.
1652
1653 2019-08-30  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1656         refresh_window>: Declare.
1657         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1658         resize.
1659         (tui_data_item_window::rerender): Rename from
1660         tui_display_register.
1661         (tui_data_item_window::refresh_window): New method.
1662         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1663         no-op.
1664
1665 2019-08-30  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1668         regs_column_count, current_group>: Move later.  Now private.
1669         <get_current_group>: New method.
1670         * tui/tui-regs.c (tui_reg_command): Update.
1671         * tui/tui-layout.c (tui_set_layout): Update.
1672
1673 2019-08-30  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1676         (tui_data_window::rerender): Don't call
1677         check_and_display_highlight_if_needed.
1678         (tui_data_window::refresh_all): Remove call to
1679         erase_data_content.
1680
1681 2019-08-30  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1684         (tui_data_window::display_registers_from)
1685         (tui_data_window::display_reg_element_at_line)
1686         (tui_data_window::display_registers_from_line): Remove checks of
1687         "empty".
1688
1689 2019-08-30  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1692         Don't declare.
1693         * tui/tui-regs.c (tui_data_window::show_registers): Call
1694         rerender.
1695         (tui_data_window::rerender): Rename from display_all_data.
1696         (tui_data_window::rerender): Remove old implementation.
1697
1698 2019-08-30  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1701         text.
1702         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1703
1704 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1705             Sergio Durigan Junior  <sergiodj@redhat.com>
1706
1707         PR win32/24284
1708         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1709
1710 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1711
1712         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1713         when searching for types.
1714
1715 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1716
1717         * f-lang.c (f_language_defn): Use f_print_typedef.
1718         * f-lang.h (f_print_typedef): Declare.
1719         * f-typeprint.c (f_print_typedef): Define.
1720
1721 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1722
1723         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1724
1725 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1726
1727         * cli/cli-utils.c (info_print_options_defs): Delete.
1728         (make_info_print_options_def_group): Delete.
1729         (extract_info_print_options): Delete.
1730         (info_print_command_completer): Delete.
1731         (info_print_args_help): Add extra parameter, and optionally
1732         include text about -n flag.
1733         * cli/cli-utils.h (struct info_print_options): Delete.
1734         (extract_info_print_options): Delete declaration.
1735         (info_print_command_completer): Delete declaration.
1736         (info_print_args_help): Add extra parameter, extend header
1737         comment.
1738         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1739         search_symbols.
1740         * stack.c (struct info_print_options): New type.
1741         (info_print_options_defs): New file scoped variable.
1742         (make_info_print_options_def_group): New static function.
1743         (info_print_command_completer): New static function.
1744         (info_locals_command): Update to use new local functions.
1745         (info_args_command): Likewise.
1746         (_initialize_stack): Add extra parameter to calls to
1747         info_print_args_help.
1748         * symtab.c (search_symbols): Add extra parameter, use this to
1749         possibly excluse non-debug symbols.
1750         (symtab_symbol_info): Add extra parameter, which is passed on to
1751         search_symbols.
1752         (struct info_print_options): New type.
1753         (info_print_options_defs): New file scoped variable.
1754         (make_info_print_options_def_group): New static function.
1755         (info_print_command_completer): New static function.
1756         (info_variables_command): Update to use local functions, and pass
1757         extra parameter through to symtab_symbol_info.
1758         (info_functions_command): Likewise.
1759         (info_types_command): Pass additional argument through to
1760         symtab_symbol_info.
1761         (rbreak_command): Pass extra argument to search_symbols.
1762         (_initialize_symtab): Add extra arguments for calls to
1763         info_print_args_help, and update help text for 'info variables',
1764         'whereis', and 'info functions' commands.
1765         * symtab.h (search_symbols): Add extra argument to declaration.
1766         * NEWS: Mention new flags.
1767
1768 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1769
1770         * symtab.c (lookup_static_symbol): Call the new function (and move
1771         it down to be next to lookup_global_symbol).
1772         (struct global_sym_lookup_data): Add block_enum member and rename to...
1773         (struct global_or_static_sym_lookup_data): ...this.
1774         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1775         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1776         (lookup_symbol_global_or_static_iterator_cb): ...this.
1777         (lookup_global_or_static_symbol): New function.
1778         (lookup_global_symbol): Call new function.
1779
1780 2019-08-26  Tom de Vries  <tdevries@suse.de>
1781
1782         PR c++/24852
1783         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1784         when pc_probe.prob == NULL.
1785
1786 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1787
1788         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1789         variable symbol_linkage to symbol_linkage_.
1790
1791 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1792
1793         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1794         represent whether the symbol is static, dynamic, or we don't
1795         know.
1796
1797 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1798
1799         * gdb/rx-tdep.c (rx_register_names): New.
1800         (rx_register_name): Delete.
1801         (rx_psw_type): Delete.
1802         (rx_fpsw_type): Delete.
1803         (rx_register_type): Delete.
1804         (rx_gdbarch_init): Convert target-descriptions.
1805         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1806         * gdb/features/Makefile: Add rx.xml.
1807         * gdb/features/rx.xml: New.
1808         * gdb/features/rx.c: Generated.
1809         * gdb/NEWS: Mention target description support.
1810
1811 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1812
1813         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1814         *slot_ptr.
1815
1816 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1817
1818         * configure.ac: Don't check for 'dlfcn.h' (moved to
1819         gdbsupport/common.m4).
1820         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1821         'gdbsupport/'.
1822         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1823         * compile/compile-c-support.c: Include
1824         'gdbsupport/gdb-dlfcn.h'.
1825         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1826         * gdb-dlfcn.c: Move to...
1827         * gdbsupport/gdb-dlfcn.c: ... here.
1828         * gdb-dlfcn.h: Move to...
1829         * gdbsupport/gdb-dlfcn.h: ... here.
1830
1831 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1832
1833         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1834         the offset field signed.
1835
1836 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1837
1838         * python/lib/gdb/__init__.py (_execute_file): New function.
1839         * python/python.c (python_run_simple_file): Call gdb._execute_file
1840         on Windows.
1841
1842 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1843
1844         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1845         all uses as this was never set to anything but a zero value.
1846
1847 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1848
1849         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1850
1851 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1852
1853         * tui/tui-data.h (tui_gen_win_info): Add an =default
1854         move constructor, required by some GCC versions.
1855
1856 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1857
1858         * go32-nat.c (go32_sysinfo): Add hygon_p.
1859
1860 2019-08-20  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1863         line_from_reg_element_no, first_reg_element_no_inline,
1864         display_all_data, delete_data_content_windows,
1865         erase_data_content>: Now private.
1866
1867 2019-08-20  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1870         (tui_unhighlight_win, tui_highlight_win)
1871         (tui_win_info::make_window): Update.
1872         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1873
1874 2019-08-20  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1877         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1878         (MAX_PID_WIDTH): Move to tui-stack.c.
1879         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1880         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1881         (MAX_PID_WIDTH): Move from tui-data.h.
1882
1883 2019-08-20  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1886         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1887         (box_win): Update.
1888         (tui_gen_win_info::make_window): Rename from tui_make_window.
1889         (tui_win_info::make_window): New method.
1890         (tui_gen_win_info::make_visible): Update.
1891         * tui/tui-source.c (tui_source_window::set_contents): Update.
1892         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1893         (tui_data_window::display_registers_from): Update.
1894         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1895         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1896         Declare.
1897         <can_box>: Remove.
1898         <title>: Remove.
1899         (struct tui_win_info) <make_window>: Declare.
1900         <can_box>: Now virtual.
1901         <title>: New member.
1902         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1903         * tui/tui-command.c (tui_cmd_window::resize): Update.
1904
1905 2019-08-20  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1908         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1909         (tui_data_window::check_register_values): Update.
1910
1911 2019-08-20  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-regs.h (struct tui_data_window): Use
1914         DISABLE_COPY_AND_ASSIGN.
1915         <regs_content>: Change type, removing unique_ptr.
1916         <tui_data_window>: Add move constructor.
1917         * tui/tui-regs.c (tui_data_window::show_registers)
1918         (tui_data_window::show_register_group)
1919         (tui_data_window::display_registers_from)
1920         (tui_data_window::display_registers_from)
1921         (tui_data_window::first_data_item_displayed)
1922         (tui_data_window::delete_data_content_windows)
1923         (tui_data_window::rerender, tui_data_window::refresh_window)
1924         (tui_data_window::check_register_values): Update.
1925
1926 2019-08-20  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1929         show_register_group>: Declare.
1930         (tui_show_register_group): Don't declare.
1931         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1932         tui_show_registers.
1933         (tui_data_window::show_register_group): Rename from
1934         tui_show_register_group.
1935         (tui_data_window::check_register_values, tui_reg_command):
1936         Update.
1937         * tui/tui-layout.c (tui_set_layout): Update.
1938
1939 2019-08-20  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1942         Declare.
1943         (tui_check_register_values): Don't declare.
1944         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1945         from tui_check_register_values.
1946         * tui/tui-hooks.c (tui_register_changed): Update.
1947
1948 2019-08-20  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-regs.c (tui_reg_layout): Move later.
1951         (tui_show_registers): Don't enable TUI mode or change layout.
1952
1953 2019-08-20  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-regs.h (struct tui_data_item_window)
1956         <~tui_data_item_window>: Remove.
1957         <content>: Now a unique_xmalloc_ptr.
1958         * tui/tui-regs.c (tui_register_format): Return a
1959         unique_xmalloc_ptr.
1960         (tui_get_register): Update.
1961         (~tui_data_item_window): Remove.
1962         (tui_data_window::display_registers_from, tui_display_register):
1963         Update.
1964         * tui/tui-io.h (tui_expand_tabs): Update.
1965         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1966         Remove "col" parameter.
1967
1968 2019-08-20  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1971         field.
1972         * tui/tui-regs.c (~tui_data_item_window): Update.
1973
1974 2019-08-20  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1977         earlier.
1978
1979 2019-08-20  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1982
1983 2019-08-20  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-source.h (struct tui_source_window): Update.
1986         * tui/tui-regs.c (tui_show_registers): Update.
1987         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1988         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1989         (NO_REGS_STRING): Remove defines.
1990
1991 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1992
1993         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1994         unnecessary thread walk if remote doesn't support the packet.
1995
1996 2019-08-19  Tom Tromey  <tromey@adacore.com>
1997
1998         * python/py-value.c (value_has_field): Fix indentation.
1999
2000 2019-08-19  Tom Tromey  <tromey@adacore.com>
2001
2002         * printcmd.c (do_one_display, info_display_command): Update.
2003         * block.h (contained_in): Return bool.  Add allow_nested
2004         parameter.
2005         * block.c (contained_in): Return bool.  Add allow_nested
2006         parameter.
2007
2008 2019-08-19  Tom Tromey  <tom@tromey.com>
2009
2010         * configure: Rebuild.
2011         * configure.ac: Disallow the combination of -static-libstdc++ and
2012         source highlight.
2013         * source-cache.c (get_language_name): Handle rust.
2014         (source_cache::get_source_lines): Ignore highlighting exceptions.
2015
2016 2019-08-16  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2019         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2020         (struct tui_source_window_base) <make_visible, refresh_window,
2021         resize>: Remove methods.
2022         <execution_info>: Remove field.
2023         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2024         (tui_show_source_line, tui_source_window_base)
2025         (~tui_source_window_base): Update.
2026         (tui_source_window_base::resize)
2027         (tui_source_window_base::make_visible)
2028         (tui_source_window_base::refresh_window): Remove.
2029         (tui_source_window_base::update_exec_info): Update.
2030         * tui/tui-source.c (tui_source_window::set_contents): Update.
2031         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2032
2033 2019-08-16  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2036         deprecated_query_hook.
2037
2038 2019-08-16  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2041         (tui_update_source_windows_with_line): Update.
2042         * tui/tui-source.h (struct tui_source_window)
2043         <show_symtab_source>: Declare.
2044         (tui_show_symtab_source): Don't declare.
2045         * tui/tui-source.c (tui_show_symtab_source): Rename from
2046         tui_show_symtab_source.
2047
2048 2019-08-16  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-winsource.h (struct tui_source_window_base)
2051         <set_contents>: Declare.
2052         * tui/tui-winsource.c
2053         (tui_source_window_base::update_source_window_as_is): Update.
2054         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2055         Declare.
2056         (tui_set_source_content): Don't declare.
2057         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2058         tui_set_source_content.
2059         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2060         Declare.
2061         (tui_set_disassem_content): Don't declare.
2062         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2063         tui_set_disassem_content.
2064
2065 2019-08-16  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-winsource.h (struct tui_source_window_base)
2068         <update_breakpoint_info>: Declare.
2069         (tui_update_breakpoint_info): Don't declare.
2070         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2071         (tui_update_all_breakpoint_info): Update.
2072         (tui_source_window_base::update_breakpoint_info): Rename from
2073         tui_update_breakpoint_info.
2074         (tui_source_window_base::update_exec_info): Update.
2075
2076 2019-08-16  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-winsource.h (struct tui_source_window_base)
2079         <update_source_window>: Declare.
2080         (tui_update_source_window): Don't declare.
2081         * tui/tui-winsource.c
2082         (tui_source_window_base::update_source_window): Rename from
2083         tui_update_source_window.
2084         (tui_source_window_base::rerender): Update.
2085         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2086         * tui/tui-disasm.c (tui_show_disassem)
2087         (tui_show_disassem_and_update_source)
2088         (tui_disasm_window::maybe_update): Update.
2089
2090 2019-08-16  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-winsource.h (struct tui_source_window_base)
2093         <update_source_window_as_is>: Declare.
2094         (tui_update_source_window_as_is): Don't declare.
2095         * tui/tui-winsource.c (tui_update_source_window): Update
2096         (tui_source_window_base::update_source_window_as_is): Rename from
2097         tui_update_source_window_as_is.
2098         (tui_source_window_base::refill): Update.
2099         * tui/tui-source.c (tui_show_symtab_source): Update.
2100         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2101         Update.
2102
2103 2019-08-16  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-winsource.h (tui_update_source_window)
2106         (tui_update_source_window_as_is): Remove "noerror" parameter.
2107         * tui/tui-winsource.c (tui_update_source_window)
2108         (tui_update_source_window_as_is): Remove "noerror" parameter.
2109         (tui_update_source_windows_with_addr)
2110         (tui_update_source_windows_with_line)
2111         (tui_source_window_base::rerender)
2112         (tui_source_window_base::refill): Update.
2113         * tui/tui-source.h (tui_set_source_content)
2114         (tui_show_symtab_source): Remove "noerror" parameter.
2115         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2116         parameter.
2117         (tui_show_symtab_source): Likewise.
2118         (tui_source_window::maybe_update): Update.
2119         * tui/tui-disasm.c (tui_show_disassem)
2120         (tui_show_disassem_and_update_source)
2121         (tui_disasm_window::do_scroll_vertical)
2122         (tui_disasm_window::maybe_update): Update.
2123
2124 2019-08-16  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui.c (tui_is_window_visible): Update.
2127         * tui/tui-wingeneral.c (tui_make_window)
2128         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2129         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2130         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2131         (tui_set_win_height_command, parse_scrolling_args): Update.
2132         * tui/tui-source.c (tui_source_window::style_changed): Update.
2133         * tui/tui-regs.c (tui_show_registers)
2134         (tui_data_window::first_data_item_displayed)
2135         (tui_data_window::delete_data_content_windows)
2136         (tui_check_register_values, tui_reg_command): Update.
2137         * tui/tui-disasm.c (tui_show_disassem): Update.
2138         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2139         method.
2140         <is_visible>: Remove field.
2141         * tui/tui-data.c (tui_next_win, tui_prev_win)
2142         (tui_delete_invisible_windows): Update.
2143
2144 2019-08-16  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-winsource.h (struct tui_source_window_base)
2147         <m_has_locator>: Remove.
2148         * tui/tui-layout.c (show_source_disasm_command, show_data)
2149         (show_source_or_disasm_and_command): Update.
2150
2151 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2152
2153         * NEWS (Other MI changes): New subsection.
2154         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2155         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2156         * arch-utils.c (default_get_pc_address_flags): New function.
2157         * arch-utils.h (default_get_pc_address_flags): New declaration.
2158         * gdbarch.sh: Add get_pc_address_flags.
2159         * gdbarch.c: Regenerate.
2160         * gdbarch.h: Likewise.
2161         * stack.c (print_pc): New function.
2162         (print_frame_info) (print_frame): Call print_pc.
2163
2164 2019-08-16  Tom de Vries  <tdevries@suse.de>
2165
2166         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2167         print_objfile_section_info.
2168
2169 2019-08-15  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2172         calling update_cmdwin_start_line.
2173         * tui/tui-winsource.h (struct tui_source_window_base)
2174         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2175         <rerender>: Declare.
2176         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2177         Call rerender.
2178         (tui_source_window_base::set_new_height): Remove.
2179         (tui_source_window_base::rerender): Rename from
2180         do_make_visible_with_new_height.
2181         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2182         resize method.
2183         (tui_win_info::make_invisible_and_set_new_height)
2184         (tui_win_info::make_visible_with_new_height): Remove.
2185         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2186         Declare.
2187         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2188         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2189         do_make_visible_with_new_height>: Don't declare.
2190         <rerender>: Declare.
2191         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2192         set_new_height.
2193         (tui_data_window::do_make_visible_with_new_height): Remove.
2194         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2195         call tui_show_locator_content.
2196         (tui_gen_win_info::resize): Call rerender.
2197         (show_source_or_disasm_and_command): Don't call
2198         tui_show_locator_content.
2199         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2200         method.
2201         (struct tui_win_info) <rerender>: Declare.
2202         <set_new_height, make_invisible_and_set_new_height,
2203         make_visible_with_new_height>: Don't declare.
2204         * tui/tui-data.c (tui_win_list::rerender): New method.
2205         * tui/tui-command.h (struct tui_cmd_window)
2206         <do_make_visible_with_new_height>: Don't declare.
2207         * tui/tui-command.c
2208         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2209
2210 2019-08-15  Tom Tromey  <tromey@adacore.com>
2211
2212         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2213         * ada-lang.c (ada_enum_name): Likewise.
2214
2215 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2216
2217         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2218         leading underscore.
2219         (GdbOutputErrorFile): Likewise.
2220         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2221         accordingly.
2222         (execute_unwinders): Rename to have a leading underscore.
2223         (auto_load_packages): Likewise.
2224         (global scope): Adjust call to auto_load_packages accordingly.
2225         (GdbSetPythonDirectory): Likewise.
2226         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2227         instead of execute_unwinders.
2228
2229 2019-08-15  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2232         (show_data): Don't change window visibility.
2233         (tui_gen_win_info::resize): Remove special case for command
2234         window.  Use wresize, when available.
2235         (show_source_or_disasm_and_command): Don't change window
2236         visibility.
2237         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2238         <make_visible>: New method.
2239         * tui/tui-command.c (tui_cmd_window::resize): New method.
2240
2241 2019-08-15  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2244         (struct tui_source_windows): New.
2245         * tui/tui-winsource.c (tui_display_main): Update.
2246         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2247         (new_height_ok, parse_scrolling_args): Update.
2248         * tui/tui-layout.c (show_layout, show_data): Update.
2249         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2250         (tui_add_to_source_windows): Don't declare.
2251         * tui/tui-data.c (source_windows, tui_source_windows)
2252         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2253
2254 2019-08-15  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2257         Rename from reset.
2258         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2259         * tui/tui-layout.c (show_source_disasm_command, show_data):
2260         Update.
2261         (tui_gen_win_info::resize): Rename.
2262         (show_source_or_disasm_and_command): Update.
2263         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2264         reset.
2265
2266 2019-08-15  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2269         * tui/tui-interp.c (tui_interp::init): Don't call
2270         tui_initialize_static_data.
2271         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2272
2273 2019-08-15  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2276         examine tui_win_list.
2277
2278 2019-08-15  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2281         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2282         tui_clear_source_content.
2283         (tui_clear_source_content): Remove.
2284         (tui_source_window_base::do_erase_source_content): Hoist call to
2285         content.clear().
2286         * tui/tui-stack.c (tui_show_frame_info): Don't call
2287         tui_clear_source_content.
2288
2289 2019-08-15  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-winsource.h (struct tui_source_window_base)
2292         <do_erase_source_content>: New method.
2293         <erase_source_content>: New method.
2294         (tui_erase_source_content): Don't declare.
2295         * tui/tui-winsource.c (tui_clear_source_content): Update.
2296         (tui_source_window_base::do_erase_source_content): Rename from
2297         tui_erase_source_content.
2298         (tui_source_window_base::show_source_content): Update.
2299         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2300         * tui/tui-source.h (struct tui_source_window)
2301         <erase_source_content>: New method.
2302         * tui/tui-disasm.h (struct tui_disasm_window)
2303         <erase_source_content>: New method.
2304
2305 2019-08-15  Tom Tromey  <tom@tromey.com>
2306
2307         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2308         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2309         constructor.
2310         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2311         * tui/tui-source.c (tui_set_source_content): Update.
2312         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2313
2314 2019-08-15  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2317         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2318         tui-source.c.
2319         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2320         Declare.
2321         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2322         method.
2323         (tui_source_window::maybe_update): Update.
2324
2325 2019-08-15  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2328         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2329         tui-disasm.c.
2330         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2331         Declare.
2332         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2333         method.
2334         (tui_disasm_window::maybe_update): Update.
2335
2336 2019-08-15  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-winsource.h (struct tui_source_window_base)
2339         <maybe_update>: Declare.
2340         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2341         method.
2342         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2343         Declare.
2344         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2345         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2346         Declare.
2347         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2348
2349 2019-08-15  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2352
2353 2019-08-15  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-wingeneral.c: Include tui-stack.h.
2356         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2357         (struct tui_locator_window): Move from tui-data.h.
2358         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2359         (tui_initialize_static_data): Move from tui-data.c.
2360         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2361         (struct tui_locator_window): Move to tui-stack.c.
2362         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2363         (tui_initialize_static_data): Move to tui-stack.c.
2364
2365 2019-08-15  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-layout.c (show_source_disasm_command)
2368         (show_source_or_disasm_and_command): Use make_visible method, not
2369         tui_make_window.
2370         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2371         Remove.
2372
2373 2019-08-15  Tom Tromey  <tom@tromey.com>
2374
2375         * tui/tui-wingeneral.h (tui_make_window): Update.
2376         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2377         parameter.
2378         (tui_gen_win_info::make_visible): Update.
2379         * tui/tui-regs.c (tui_data_window::display_registers_from):
2380         Update.
2381         * tui/tui-layout.c (show_source_disasm_command)
2382         (show_source_or_disasm_and_command): Update.
2383         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2384         (enum tui_box): Remove.
2385         (struct tui_win_info) <can_box>: New method.
2386         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2387         method.
2388
2389 2019-08-15  Tom de Vries  <tdevries@suse.de>
2390
2391         * linux-nat-trad.c: Include gdbarch.h.
2392
2393 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2394
2395         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2396         register sizes.
2397
2398 2019-08-14  Tom Tromey  <tromey@adacore.com>
2399
2400         * darwin-nat.c: Include gdbarch.h.
2401         * darwin-nat-info.c: Include gdbarch.h.
2402
2403 2019-08-13  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2406         Remove.
2407         * tui/tui-data.c (tui_initialize_static_data): Update.
2408
2409 2019-08-13  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-winsource.h (struct tui_exec_info_window)
2412         <~tui_exec_info_window, maybe_allocate_content, get_content,
2413         m_content>: Remove.
2414         (struct tui_source_window_base) <set_exec_info_content,
2415         show_exec_info_content>: Don't declare.
2416         * tui/tui-winsource.c
2417         (tui_exec_info_window::maybe_allocate_content): Remove.
2418         (tui_source_window_base::update_exec_info): Rename from
2419         set_exec_info_content.
2420         (tui_source_window_base::show_exec_info_content)
2421         (tui_source_window_base::update_exec_info): Remove.
2422
2423 2019-08-13  Tom Tromey  <tom@tromey.com>
2424
2425         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2426         declare.
2427         * tui/tui-winsource.c (tui_update_source_window_as_is)
2428         (tui_update_source_windows_with_addr, tui_erase_source_content):
2429         Update.
2430         (tui_clear_exec_info_content): Remove.
2431
2432 2019-08-13  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2435         declare.
2436         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2437         call tui_erase_exec_info_content.
2438         (tui_clear_exec_info_content): Rename from
2439         tui_erase_exec_info_content.
2440         (tui_clear_exec_info_content): Delete.
2441
2442 2019-08-13  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-winsource.h (struct tui_source_window_base)
2445         <show_exec_info_content>: Declare.
2446         (tui_show_exec_info_content): Don't declare.
2447         * tui/tui-winsource.c
2448         (tui_source_window_base::show_exec_info_content): Rename from
2449         tui_show_exec_info_content.
2450         (tui_source_window_base::update_exec_info): Update.
2451
2452 2019-08-13  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2455         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2456         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2457         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2458         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2459         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2460         ... here.
2461
2462 2019-08-13  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-winsource.h (struct tui_source_window_base)
2465         <update_exec_info>: Declare.
2466         (tui_update_exec_info): Don't declare.
2467         * tui/tui-winsource.c (tui_update_source_window_as_is)
2468         (tui_source_window_base::refresh_all)
2469         (tui_update_all_breakpoint_info): Update.
2470         (tui_source_window_base::update_exec_info): Rename from
2471         tui_update_exec_info.
2472         * tui/tui-stack.c (tui_show_frame_info): Update.
2473
2474 2019-08-13  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-winsource.h (struct tui_source_window_base)
2477         <set_exec_info_content>: Declare.
2478         (tui_set_exec_info_content): Don't declare.
2479         * tui/tui-winsource.c
2480         (tui_source_window_base::set_exec_info_content): Rename from
2481         tui_set_exec_info_content.
2482         (tui_update_exec_info): Update.
2483
2484 2019-08-13  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-winsource.h (struct tui_source_window_base)
2487         <show_source_content>: Declare.
2488         (tui_show_source_content): Don't declare.
2489         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2490         (tui_source_window_base::show_source_content): Rename from
2491         tui_show_source_content.
2492         (tui_source_window_base::refresh_all): Update.
2493         * tui/tui-layout.c (show_source_disasm_command)
2494         (show_source_or_disasm_and_command): Update.
2495
2496 2019-08-13  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-winsource.c (tui_erase_source_content)
2499         (tui_show_source_content, tui_source_window_base::refresh_all):
2500         Update.
2501         * tui/tui-wingeneral.h
2502         (tui_check_and_display_highlight_if_needed): Don't declare.
2503         * tui/tui-wingeneral.c
2504         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2505         check_and_display_highlight_if_needed.
2506         * tui/tui-win.c (tui_rehighlight_all)
2507         (tui_win_info::make_visible_with_new_height): Update.
2508         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2509         (tui_data_window::erase_data_content)
2510         (tui_data_window::display_all_data): Update.
2511         * tui/tui-data.h (struct tui_win_info)
2512         <check_and_display_highlight_if_needed>: Declare.
2513
2514 2019-08-13  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-win.c (tui_resize_all): Call
2517         tui_delete_invisible_windows.
2518         * tui/tui-layout.c (show_layout): Call
2519         tui_delete_invisible_windows.
2520         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2521         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2522
2523 2019-08-13  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2526         tui_add_win_to_layout.
2527
2528 2019-08-13  Tom Tromey  <tom@tromey.com>
2529
2530         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2531         * tui/tui-layout.c (tui_default_win_height): Now static.
2532
2533 2019-08-13  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2536         single switch.
2537         (show_source_disasm_command, show_source_or_disasm_and_command):
2538         Don't check current layout.
2539
2540 2019-08-13  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-wingeneral.c (make_all_visible): Remove.
2543         (tui_make_all_invisible): Simplify.
2544         * tui/tui-layout.c (tui_make_all_invisible): Move from
2545         tui-wingeneral.c; simplify.
2546         (show_layout): Hoist call to tui_make_all_invisible.
2547         (show_data): Don't call tui_make_all_invisible.
2548
2549 2019-08-13  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2552         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2553
2554 2019-08-13  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2557         tui-data.c.
2558         (show_source_disasm_command, show_data)
2559         (show_source_or_disasm_and_command): Don't use
2560         tui_set_current_layout_to.
2561         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2562         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2563         tui-layout.c.
2564         (tui_set_current_layout_to): Remove.
2565
2566 2019-08-13  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-layout.c (tui_set_layout): Update.
2569         * tui/tui-data.h (struct tui_layout_def): Remove.
2570         (tui_layout_def): Don't declare.
2571         * tui/tui-data.c (layout_def): Remove.
2572         (tui_layout_def): Remove.
2573
2574 2019-08-13  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-winsource.h (struct tui_source_window_base)
2577         <clear_detail>: No longer "override".
2578         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2579         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2580         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2581         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2582         Remove.
2583         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2584
2585 2019-08-13  Tom Tromey  <tromey@adacore.com>
2586
2587         * tracepoint.c: Don't include readline.h or history.h.
2588
2589 2019-08-12  Tom Tromey  <tom@tromey.com>
2590
2591         * configure: Rebuild.
2592         * configure.ac: Check for readline 7.
2593         * NEWS: Mention readline 7 requirement.
2594         * README: Update.
2595
2596 2019-08-12  Tom Tromey  <tom@tromey.com>
2597
2598         * mingw-hdep.c (gdb_select): Remove readline hack.
2599
2600 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2601
2602         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2603         when the function fails.
2604
2605 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2606
2607         * s390-tdep.c (s390_type_align): New function.
2608         (s390_gdbarch_init): Set it as type_align gdbarch method.
2609
2610 2019-08-09  Tom de Vries  <tdevries@suse.de>
2611
2612         PR gdb/24591
2613         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2614         pc_low with relocation offset.
2615
2616 2019-08-07  Tom Tromey  <tromey@adacore.com>
2617
2618         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2619         (print_frame_args): Update.
2620         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2621         Update.
2622         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2623         * frame.h (struct frame_arg): Add initializers.
2624         <error>: Now a unique_xmalloc_ptr.
2625
2626 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2627
2628         * NEWS: Expand the Pointer Authentication entry.
2629         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2630         (aarch64_frame_unmask_lr): ... to this.
2631         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2632         Call aarch64_frame_unmask_lr.
2633         * frame.c (struct frame_info): Add "masked" variable.
2634         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2635         (fprint_frame): Check for masked pc.
2636         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2637         declarations.
2638         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2639         * stack.c (print_frame): Check for masked pc.
2640
2641 2019-08-06  Tom Tromey  <tom@tromey.com>
2642
2643         * stabsread.c (patch_block_stabs, read_one_struct_field)
2644         (read_enum_type): Use obstack_strndup.
2645         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2646         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2647         * dwarf2read.c (guess_full_die_structure_name)
2648         (anonymous_struct_prefix): Use obstack_strndup.
2649         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2650         * c-exp.y (yylex): Use obstack_strndup.
2651         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2652         (write_var_or_type): Use obstack_strndup.
2653
2654 2019-08-06  Tom Tromey  <tom@tromey.com>
2655
2656         * symfile.c (reread_symbols): Use obstack_strdup.
2657         * stabsread.c (read_type): Use obstack_strdup.
2658         * gdb_obstack.h (obstack_strdup): New overload.
2659         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2660         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2661         (dwarf2_canonicalize_name): Use obstack_strdup.
2662         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2663         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2664         Use obstack_strdup.
2665
2666 2019-08-06  Tom Tromey  <tom@tromey.com>
2667
2668         * gdb_obstack.h (obstack_strdup): Define.
2669         * gdb_obstack.c (obstack_strdup): Don't define.
2670
2671 2019-08-06  Tom Tromey  <tom@tromey.com>
2672
2673         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2674         obstack_strdup.
2675         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2676         obstack_strdup.
2677         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2678         * stabsread.c (common_block_start): Use obstack_strdup.
2679         * objfiles.c (set_objfile_main_name, objfile): Use
2680         obstack_strdup.
2681         * namespace.c (add_using_directive): Use obstack_strdup.
2682         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2683         * jit.c (finalize_symtab): Use obstack_strdup.
2684         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2685         (guess_partial_die_structure_name, partial_die_info::fixup)
2686         (dwarf2_name): Use obstack_strdup.
2687         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2688         obstack_strdup.
2689         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2690         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2691         obstack_strdup.
2692         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2693
2694 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2695
2696         * unittests/help-doc-selftests.c: New file.
2697         * Makefile.in: Add the new file.
2698
2699 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2700
2701         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2702         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2703         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2704         the trailing '.' is not output, and the first character is uppercased.
2705         (print_help_for_command): Update call to print_doc_line.
2706         (print_doc_of_command): Likewise.
2707         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2708         * cli/cli-option.c (append_indented_doc): Do not append newline.
2709         (build_help_option): Append newline after first appended_indented_doc
2710         only if a second call is done.
2711         (build_help): Append 2 new lines before each option, except the first
2712         one.
2713         * compile/compile.c (_initialize_compile): Add new lines after
2714         %OPTIONS%, when not at the end of the help.
2715         Change help doc or code
2716         producing the help doc to respect the invariants.
2717         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2718         Also removed the new line after 'Options:', as all other commands
2719         do not put an empty line between 'Options:' and the first option.
2720         * printcmd.c (_initialize_printcmd): Likewise.
2721         * stack.c (_initialize_stack): Likewise.
2722         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2723         incorrectly telling COMMAND is optional.
2724         * ada-lang.c (_initialize_ada_language): Change help doc or code
2725         producing the help doc to respect the invariants.
2726         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2727         * breakpoint.c (_initialize_breakpoint): Likewise.
2728         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2729         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2730         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2731         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2732         _initialize_cli_style): Likewise.
2733         * corelow.c (core_target_info): Likewise.
2734         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2735         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2736         * filesystem.c (_initialize_filesystem): Likewise.
2737         * frame.c (_initialize_frame): Likewise.
2738         * gnu-nat.c (add_task_commands): Likewise.
2739         * infcall.c (_initialize_infcall): Likewise.
2740         * infcmd.c (_initialize_infcmd): Likewise.
2741         * interps.c (_initialize_interpreter): Likewise.
2742         * language.c (_initialize_language): Likewise.
2743         * linux-fork.c (_initialize_linux_fork): Likewise.
2744         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2745         * maint.c (_initialize_maint_cmds): Likewise.
2746         * memattr.c (_initialize_mem): Likewise.
2747         * printcmd.c (_initialize_printcmd): Likewise.
2748         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2749         _RegEx): Likewise.
2750         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2751         * record-btrace.c (_initialize_record_btrace): Likewise.
2752         * record-full.c (_initialize_record_full): Likewise.
2753         * record.c (_initialize_record): Likewise.
2754         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2755         * regcache.c (_initialize_regcache): Likewise.
2756         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2757         _initialize_remote): Likewise.
2758         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2759         * serial.c (_initialize_serial): Likewise.
2760         * skip.c (_initialize_step_skip): Likewise.
2761         * source.c (_initialize_source): Likewise.
2762         * stack.c (_initialize_stack): Likewise.
2763         * symfile.c (_initialize_symfile): Likewise.
2764         * symtab.c (_initialize_symtab): Likewise.
2765         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2766         * top.c (init_main): Likewise.
2767         * tracefile-tfile.c (tfile_target_info): Likewise.
2768         * tracepoint.c (_initialize_tracepoint): Likewise.
2769         * tui/tui-win.c (_initialize_tui_win): Likewise.
2770         * utils.c (add_internal_problem_command): Likewise.
2771         * valprint.c (value_print_option_defs): Likewise.
2772
2773 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2774
2775         PR build/24886
2776         * configure.ac: Drop enable-libmcheck support.
2777         * configure, config.in: Rebuild.
2778         * libmcheck.m4: Remove.
2779         * acinclude.m4: Don't include it.
2780         * Makefile.in: Don't distribute it.
2781         * top.c (print_gdb_configuration): Don't mention it.
2782
2783 2019-08-06  Tom Tromey  <tom@tromey.com>
2784
2785         * utils.c (set_output_style): Sometimes pass stream to
2786         emit_style_escape.
2787         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2788         * record-btrace.c (btrace_insn_history): Update.
2789         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2790         method.
2791         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2792         Update initializers.
2793         <m_uiout>: New field.
2794         <m_di>: Move lower.
2795         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2796         Remove "uiout" parameter.
2797         (dump_insns): Update.
2798         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2799         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2800
2801 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2802
2803         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2804         (error_in_psymtab_expansion): Likewise.
2805         (lookup_symbol_via_quick_fns): Likewise.
2806         (basic_lookup_transparent_type_quick): Likewise.
2807         (basic_lookup_transparent_type_1): Likewise.
2808
2809 2019-08-06  Tom Tromey  <tromey@adacore.com>
2810
2811         * source.c (last_source_error): Now bool.
2812         (print_source_lines_base): Make "noprint" bool.  Only open
2813         source file when last_source_visited changes.
2814
2815 2019-08-06  Tom Tromey  <tromey@adacore.com>
2816
2817         * annotate.c (annotate_source_line): Use g_source_cache.
2818         * source-cache.c (source_cache::get_plain_source_lines): Change
2819         parameters.  Populate m_offset_cache.
2820         (source_cache::ensure): New method.
2821         (source_cache::get_line_charpos): New method.
2822         (extract_lines): Move lower.  Change parameters.
2823         (source_cache::get_source_lines): Move lower.
2824         * source-cache.h (class source_cache): Update comment.
2825         <get_line_charpos>: New method.
2826         <get_source_lines>: Update comment.
2827         <clear>: Clear m_offset_cache.
2828         <get_plain_source_lines>: Change parameters.
2829         <ensure>: New method
2830         <m_offset_cache>: New member.
2831         * source.c (forget_cached_source_info_for_objfile): Update.
2832         (info_source_command): Use g_source_cache.
2833         (find_source_lines, open_source_file_with_line_charpos): Remove.
2834         (print_source_lines_base, search_command_helper): Use g_source_cache.
2835         * source.h (open_source_file_with_line_charpos): Don't declare.
2836         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2837         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2838         Use g_source_cache.
2839
2840 2019-08-06  Tom Tromey  <tromey@adacore.com>
2841
2842         * source-cache.c (source_cache::get_plain_source_lines):
2843         Remove "first_line" and "last_line" parameters.
2844         (source_cache::get_source_lines): Cache plain text.
2845         * source-cache.h (class source_cache)
2846         <get_plain_source_lines>: Update.
2847
2848 2019-08-06  Tom Tromey  <tromey@adacore.com>
2849
2850         * source-cache.c (extract_lines): No longer a method.
2851         Changed type of parameter.  Include final newline.
2852         (selftests::extract_lines_test): New function.
2853         (_initialize_source_cache): Likewise.
2854         * source-cache.h (class source_cache)
2855         <extract_lines>: Don't declare.
2856
2857 2019-08-06  Tom Tromey  <tromey@adacore.com>
2858
2859         * breakpoint.c (init_breakpoint_sal): Update.
2860         (breakpoint): Update.
2861         * breakpoint.h (struct breakpoint) <filter>: Now a
2862         unique_xmalloc_ptr.
2863
2864 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2865
2866         * NEWS: Mention dictionary access on blocks.
2867         * python/py-block.c (blpy_getitem): New function.
2868         (block_object_as_mapping): New struct.
2869         (block_object_type): Use new struct for tp_as_mapping field.
2870
2871 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2872
2873         * objfiles.h (objfile): Add a comment describing partial symbols.
2874
2875 2019-08-05  Tom Tromey  <tromey@adacore.com>
2876
2877         * compile/compile.c (_initialize_compile): Use _(), not N_().
2878         * thread.c (_initialize_thread): Use _(), not N_().
2879         * stack.c (_initialize_stack): Use _(), not N_().
2880         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2881
2882 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2883
2884         * dwarf2read.c (struct dw2_symtab_iterator):
2885         <want_specific_block>: Remove.
2886         <block_index>: Change type to gdb::optional.
2887         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2888         change type of BLOCK_INDEX parameter to gdb::optional.
2889         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2890         (dw2_lookup_symbol): Don't pass argument for
2891         WANT_SPECIFIC_BLOCK.
2892         (dw2_expand_symtabs_for_function): Don't pass argument for
2893         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2894         (class dw2_debug_names_iterator)
2895         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2896         parameter, change BLOCK_INDEX type to gdb::optional.
2897         <m_want_specific_block>: Remove.
2898         <m_block_index>: Change type to gdb::optional.
2899         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2900         gdb::optional.  Re-write in function of gdb::optional.
2901         (dw2_debug_names_lookup_symbol): Don't pass argument for
2902         WANT_SPECIFIC_BLOCK.
2903         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2904         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2905         BLOCK_INDEX.
2906
2907 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2908
2909         * NEWS: Mention changes to "info sources" command.
2910
2911 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2912
2913         * symtab.c (filename_partial_match_opts): New struct type.
2914         (struct output_source_filename_data): New members
2915         regexp, c_regexp, partial_match.
2916         (output_source_filename): Use new members to decide to print file.
2917         (info_sources_option_defs): New variable.
2918         (make_info_sources_options_def_group, print_info_sources_header,
2919         info_sources_command_completer):
2920         New functions.
2921         (info_sources_command): Read new optional arguments.
2922         (_initialize_symtab): Update info sources help.
2923
2924 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2925
2926         * ada-lang.c (exception_support_info_v0): Renamed from...
2927         (default_exception_support_info): ... this.  Create new
2928         definition for v1.
2929         (ada_has_this_exception_support): Look up catch_handlers_sym.
2930         (ada_exception_support_info_sniffer): Try v0 after default.
2931
2932 2019-08-01  Tom Tromey  <tromey@adacore.com>
2933
2934         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2935         gdbarch.h.
2936
2937 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2938
2939         * s12z-tdep.c: Fix include path for s12z-opc.h.
2940
2941 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2942
2943         * NEWS: Require GNU make 3.82.
2944
2945 2019-07-16  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2948         declare.
2949
2950 2019-07-30  Tom Tromey  <tromey@adacore.com>
2951
2952         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2953
2954 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2955
2956         * printcmd.c (print_address_symbolic): Print negative offsets.
2957         (build_address_symbolic): Force signed arithmetic when computing
2958         offset.
2959
2960 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2961
2962         PR/24474: Add a function to lookup static variables.
2963         * NEWS: Mention this new function.
2964         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2965         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2966         * python/python.c (python_GdbMethods): Add new function.
2967
2968 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2969
2970         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2971         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2972         (objfpy_lookup_static_symbol): New function.
2973         (objfile_object_methods): Add new functions.
2974
2975 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2976
2977         * NEWS: Mention 'set|show print frame-info'.  Mention new
2978         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2979         backtrace argument.  Mention that python frame filtering code
2980         is now consistent with what 'backtrace' command prints.
2981
2982 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2983
2984         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2985         comments.
2986         (print_frame_info_auto, print_frame_info_source_line,
2987         print_frame_info_location, print_frame_info_source_and_location,
2988         print_frame_info_location_and_address, print_frame_info_short_location):
2989         New declarations.
2990         (struct frame_print_options): New member print_frame_info.
2991         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2992         * stack.h (get_user_print_what_frame_info): New declaration.
2993         (frame_show_address): New declaration.
2994         * stack.c (print_frame_arguments_choices): New value 'presence'.
2995         (print_frame_info_auto, print_frame_info_source_line,
2996         print_frame_info_location, print_frame_info_source_and_location,
2997         print_frame_info_location_and_address, print_frame_info_short_location,
2998         print_frame_info_choices, print_frame_info_print_what): New definitions.
2999         (print_frame_args): Only print dots for args if print frame-arguments
3000         is 'presence'.
3001         (frame_print_option_defs): New element for "frame-info".
3002         (get_user_print_what_frame_info): New function.
3003         (frame_show_address): Make non static.  Move comment to stack.h.
3004         (print_frame_info_to_print_what): New function.
3005         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3006         to decide what to print.
3007         (backtrace_command_1): Handle the new print_frame_arguments_presence
3008         value.
3009         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3010         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3011         (py_print_frame): In non-mi mode, use LOCATION as default for
3012         print_what, similarly to frame information printed directly by
3013         backtrace command. Handle frame-info user option in non MI mode.
3014
3015 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3016
3017         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3018         Add case for debugging 32-bit target on 64-bit host.  Revise
3019         comment.
3020
3021 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3022
3023         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3024         instead of find_function_entry_range_from_pc.
3025
3026 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3027
3028         * stack.c (find_frame_funname): Remove code which preferred
3029         minsym over symtab sym in "certain pathological cases".
3030
3031         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3032         parameter.  Change type of "do_demangle" to bool.
3033         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3034         Pass suitable "prefer_sym_over_minsym" flag to
3035         build_address_symbolic().  Don't output "+" for negative offsets.
3036         * printcmd.c (print_address_symbolic): Update invocation of
3037         build_address_symbolic to include a "prefer_sym_over_minsym"
3038         flag.
3039         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3040         Restrict cases in which use of minimal symbol is preferred to that
3041         of a found symbol.  Update comments.
3042
3043         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3044         for entry pc when entry pc is out of range for that FDE.
3045
3046 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3047
3048         PR gdb/24839:
3049         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3050         type.
3051
3052 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3053
3054         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3055         this function's Python signature.
3056
3057
3058 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3059
3060         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3061         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3062         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3063         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3064         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3065
3066
3067 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3068
3069         * h8300-tdep.c (h8300_register_name_common): New.
3070         h8300_register_name): Use h8300_register_name_common.
3071         (h8300s_register_name): Likewise.
3072         (h8300sx_register_name): Likewise.
3073         (h8300h_register_nam): New.
3074         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3075
3076
3077 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3078
3079         * arm-tdep.c (arm_skip_cmse_entry): New function.
3080         (arm_is_sgstubs_section): New function.
3081         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3082
3083 2019-07-22  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3086         Don't self-assign.
3087
3088 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3089
3090         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3091         type_print.
3092
3093 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3096         so that GDB doesn't match any msymbols when searching in the
3097         TYPES_DOMAIN.
3098         (print_symbol_info): Print using typedef_print or type_print based
3099         on the type of the symbol.  Add updated FIXME comment moved from...
3100         (_initialize_symtab): ... move and update FIXME comment to above.
3101
3102 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3103
3104         * NEWS: Mention adding -q option to "info types".
3105         * symtab.c (struct info_types_options): New struct.
3106         (info_types_options_defs): New variable.
3107         (make_info_types_options_def_group): New function.
3108         (info_types_command): Use gdb::option framework to parse options.
3109         (info_types_command_completer): New function.
3110         (_initialize_symtab): Extend the help text on "info types" and
3111         register command completer.
3112
3113 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3114
3115         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3116         (lookup_symbol_in_objfile): Change int to block_enum and add a
3117         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3118
3119 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3120
3121         * MAINTAINERS (Write After Approval): Add self.
3122
3123 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3126         instruction to the dummy code region.
3127
3128 2019-07-19  Tom Tromey  <tromey@adacore.com>
3129
3130         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3131         (ARGSUSED, PARAMS, __func__): Remove rules.
3132
3133 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3134
3135         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3136         * features/arm/arm-with-iwmmxt.c: Remove.
3137         * features/arm/arm-with-iwmmxt.xml: Remove.
3138         * features/arm/arm-with-m-fpa-layout.c: Remove.
3139         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3140         * features/arm/arm-with-m-vfp-d16.c: Remove.
3141         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3142         * features/arm/arm-with-m.c: Remove.
3143         * features/arm/arm-with-m.xml: Remove.
3144         * features/arm/arm-with-neon.c: Remove.
3145         * features/arm/arm-with-neon.xml: Remove.
3146         * features/arm/arm-with-vfpv2.c: Remove.
3147         * features/arm/arm-with-vfpv2.xml: Remove.
3148         * features/arm/arm-with-vfpv3.c: Remove.
3149         * features/arm/arm-with-vfpv3.xml: Remove.
3150
3151 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3152
3153         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3154
3155 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3156
3157         * arch/aarch32.c (aarch32_create_target_description): Create
3158         target descriptions using features.
3159         * arch/arm.c (arm_create_target_description)
3160         (arm_create_mprofile_target_description): Likewise.
3161         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3162
3163 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3164
3165         * Makefile.in: Add new files.
3166         * aarch32-tdep.c: New file.
3167         * aarch32-tdep.h: New file.
3168         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3169         Call aarch32_read_description.
3170         * arch/aarch32.c: New file.
3171         * arch/aarch32.h: New file.
3172         * arch/arm.c (arm_create_target_description)
3173         (arm_create_mprofile_target_description): New function.
3174         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3175         (arm_create_target_description)
3176         (arm_create_mprofile_target_description): New declaration.
3177         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3178         read_description functions.
3179         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3180         Likewise.
3181         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3182         * arm-tdep.c (tdesc_arm_list): New variable.
3183         (arm_register_g_packet_guesses): Call create description functions.
3184         (arm_read_description) (arm_read_mprofile_description): New
3185         function.
3186         * arm-tdep.h (arm_read_description)
3187         (arm_read_mprofile_description): Add declaration.
3188         * configure.tgt: Add new files.
3189
3190 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3191
3192         * top.c (new_ui_command): Open specified terminal just once.
3193
3194 2019-07-18  Tom Tromey  <tromey@adacore.com>
3195
3196         * symtab.c (main_name): Constify return type.
3197         * symfile.c (set_initial_language): Update.
3198         * symtab.h (main_name): Constify return type.
3199
3200 2019-07-17  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-winsource.c (tui_update_source_window)
3203         (tui_update_source_window_as_is)
3204         (tui_update_source_windows_with_line): Remove return.
3205         * tui/tui-disasm.c (tui_show_disassem)
3206         (tui_show_disassem_and_update_source): Remove return.
3207         * tui/tui.c (tui_reset): Remove return.
3208         * tui/tui-wingeneral.c
3209         (tui_check_and_display_highlight_if_needed): Remove return.
3210
3211 2019-07-17  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3214
3215 2019-07-17  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-winsource.h (struct tui_exec_info_window)
3218         (struct tui_source_window_base): Move from tui-data.h.
3219         * tui/tui-winsource.c: Move many method definitions from
3220         elsewhere.  Remove "structuring" comments.
3221         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3222         (tui_source_window_base::refresh_window): Move to
3223         tui-winsource.c.
3224         * tui/tui-win.c (tui_source_window_base::refresh_all)
3225         (tui_source_window_base::update_tab_width)
3226         (tui_source_window_base::set_new_height)
3227         (tui_source_window_base::do_make_visible_with_new_height): Move to
3228         tui-winsource.c.
3229         * tui/tui-source.h: Update.
3230         * tui/tui-source.c (tui_source_window_base::reset): Move to
3231         tui-winsource.c.
3232         * tui/tui-disasm.h: Update.
3233         * tui/tui-data.h (struct tui_exec_info_window): Move to
3234         tui-winsource.h.
3235         (struct tui_source_window_base): Likewise.
3236         * tui/tui-data.c (tui_source_window_base::clear_detail)
3237         (tui_source_window_base, ~tui_source_window_base): Move to
3238         tui-winsource.c.
3239
3240 2019-07-17  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-win.c (tui_resize_all)
3243         (tui_source_window_base::update_tab_width)
3244         (tui_adjust_win_heights): Update.
3245         (tui_win_info::make_invisible_and_set_new_height): Rename from
3246         make_invisible_and_set_new_height.
3247         * tui/tui-data.h (struct tui_win_info)
3248         <make_invisible_and_set_new_height>: New method.
3249
3250 2019-07-17  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui.c: Update.
3253         * tui/tui-source.h (struct tui_source_window): Move from
3254         tui-data.h.
3255         * tui/tui-layout.c: Update.
3256         * tui/tui-disasm.c: Update.
3257         * tui/tui-data.h (struct tui_source_window): Move to
3258         tui-source.h.
3259
3260 2019-07-17  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3263         tui-data.h.
3264         * tui/tui-data.h (struct tui_disasm_window): Move to
3265         tui-disasm.h.
3266
3267 2019-07-17  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-regs.h (struct tui_data_item_window): Move from
3270         tui-data.h.
3271         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3272         * tui/tui-data.h (struct tui_data_item_window): Move to
3273         tui-regs.h.
3274         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3275
3276 2019-07-17  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui.c: Update.
3279         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3280         (tui_cmd_window::max_height): Move to tui-command.c.
3281         * tui/tui-layout.c: Update.
3282         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3283         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3284         tui-command.c.
3285         * tui/tui-command.h (struct tui_cmd_window): Move from
3286         tui-data.h.
3287         * tui/tui-command.c: Remove "structuring" comments.
3288         (tui_cmd_window::clear_detail)
3289         (tui_cmd_window::do_make_visible_with_new_height)
3290         (tui_cmd_window::max_height): Move from elsewhere.
3291
3292 2019-07-17  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3295         Now static.
3296         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3297         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3298
3299 2019-07-17  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui.c: Update.
3302         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3303         tui-regs.c.
3304         * tui/tui-windata.h: Remove file.
3305         * tui/tui-windata.c: Remove file.
3306         * tui/tui-win.c (tui_data_window::set_new_height)
3307         (tui_data_window::do_make_visible_with_new_height): Move to
3308         tui-regs.c.
3309         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3310         * tui/tui-regs.c: Remove "structuring" comments.
3311         (tui_data_window::first_data_item_displayed)
3312         (tui_data_window::delete_data_content_windows)
3313         (tui_data_window::erase_data_content)
3314         (tui_data_window::display_all_data)
3315         (tui_data_window::refresh_all)
3316         (tui_data_window::do_scroll_vertical)
3317         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3318         (tui_data_window::do_make_visible_with_new_height)
3319         (tui_data_window::refresh_window): Move from elsewhere.
3320         (_initialize_tui_regs): Move to end of file.
3321         * tui/tui-layout.c: Update.
3322         * tui/tui-hooks.c: Update.
3323         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3324         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3325         tui-regs.c.
3326         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3327
3328 2019-07-17  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3331         seen.
3332
3333 2019-07-17  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-win.c (tui_source_window_base::set_new_height)
3336         (tui_source_window_base::do_make_visible_with_new_height): Use
3337         m_has_locator field directly.
3338         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3339         method.
3340         (struct tui_source_window_base) <has_locator>: Likewise.
3341
3342 2019-07-17  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3345         Don't declare.
3346         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3347         Remove.
3348         * tui/tui-win.c (tui_source_window_base::set_new_height)
3349         (tui_source_window_base::set_new_height)
3350         (make_invisible_and_set_new_height)
3351         (tui_source_window_base::do_make_visible_with_new_height)
3352         (tui_source_window_base::do_make_visible_with_new_height):
3353         Update.
3354         * tui/tui-layout.c (show_source_disasm_command, show_data)
3355         (show_source_or_disasm_and_command): Update.
3356         * tui/tui-layout.c (show_layout): Update.
3357
3358 2019-07-17  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-layout.c (make_data_window): Remove.
3361         (show_data): Unify creation and re-initialization cases.
3362
3363 2019-07-17  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-layout.c (make_source_window, make_disasm_window):
3366         Remove.
3367         (show_data): Unify creation and re-initialization cases.
3368
3369 2019-07-17  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-layout.c (make_command_window): Remove.
3372         (show_source_disasm_command, show_source_or_disasm_and_command):
3373         Unify creation and re-initialization cases.
3374
3375 2019-07-17  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3378         creation and re-initialization cases.
3379
3380 2019-07-17  Tom Tromey  <tom@tromey.com>
3381
3382         * tui/tui-regs.c (tui_get_register): Return void.
3383
3384 2019-07-17  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3387         Simplify.
3388
3389 2019-07-17  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3392         resetting.
3393
3394 2019-07-17  Tom Tromey  <tom@tromey.com>
3395
3396         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3397         * tui/tui-regs.c (tui_reg_layout): New function.
3398         (tui_show_registers, tui_reg_command): Use it.
3399         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3400         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3401         parameters.
3402         (tui_layout_command): Remove.
3403
3404 2019-07-17  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-layout.h (tui/tui-layout): Return void.
3407         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3408
3409 2019-07-17  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-layout.c (show_source_disasm_command, show_data):
3412         Update.
3413         (reset_locator): Remove.
3414         (show_source_or_disasm_and_command): Update.
3415
3416 2019-07-17  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-source.c (tui_source_window_base::reset): Remove
3419         win_type parameter.
3420         * tui/tui-layout.c (make_command_window, make_source_window)
3421         (make_disasm_window, make_data_window)
3422         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3423         (reset_locator, show_source_or_disasm_and_command): Update.
3424         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3425         win_type parameter.
3426         (struct tui_source_window_base) <reset>: Likewise.
3427
3428 2019-07-17  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-layout.c (show_source_disasm_command): Use
3431         reset_locator.
3432         (reset_locator): New function.
3433         (init_and_make_win): Remove.
3434         (show_source_or_disasm_and_command): Use reset_locator.
3435
3436 2019-07-17  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3439         condition.
3440         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3441         Remove condition.
3442         * tui/tui-source.c (tui_source_window_base::reset): New method.
3443         * tui/tui-layout.c (make_command_window): Don't call
3444         init_and_make_win.
3445         (make_source_window, make_disasm_window): Don't call
3446         make_source_or_disasm_window.
3447         (make_data_window): Don't call init_and_make_win.  Change calling
3448         convention.
3449         (show_source_disasm_command, show_data): Simplify.
3450         (make_source_or_disasm_window): Remove.
3451         (show_source_or_disasm_and_command): Simplify.
3452         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3453         (struct tui_source_window_base) <reset>: Likewise.
3454         <execution_info>: Remove initializer.
3455         * tui/tui-data.c (tui_source_window_base): Initialize
3456         execution_info.
3457
3458 2019-07-17  Tom Tromey  <tom@tromey.com>
3459
3460         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3461         variable.
3462
3463 2019-07-17  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui.c (tui_rl_other_window): Update.
3466         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3467         superclass method first.  Always iterate over regs_content.
3468         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3469         method.
3470         * tui/tui-win.c (tui_set_focus_command): Update.
3471
3472 2019-07-17  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-win.c (tui_set_focus_command): Rename from
3475         tui_set_focus.  Call tui_enable.
3476         (tui_set_focus_command): Remove.
3477
3478 2019-07-17  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3481         refresh_window.
3482         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3483         touchwin.
3484         (tui_data_window::refresh_window): Call refresh_window on data
3485         items.  Always call superclass refresh_window.
3486         (tui_win_info::refresh): Remove.
3487         (tui_source_window_base::refresh_window): Update.
3488         (tui_refresh_all): Update.
3489         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3490         refresh_window.
3491         (show_source_or_disasm_and_command): Likewise.
3492         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3493         (struct tui_source_window_base) <refresh>: Likewise.
3494
3495 2019-07-17  Tom Tromey  <tom@tromey.com>
3496
3497         * tui/tui-winsource.c (tui_clear_source_content)
3498         (tui_show_source_content): Update.
3499         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3500         whether content is empty.
3501         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3502         Remove.
3503
3504 2019-07-17  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3507         window's contents.
3508         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3509         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3510
3511 2019-07-17  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3514         (struct tui_data_item_window): Update.
3515
3516 2019-07-17  Tom Tromey  <tom@tromey.com>
3517
3518         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3519         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3520         defines.
3521
3522 2019-07-17  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-winsource.h (tui_erase_source_content)
3525         (tui_clear_source_content): Remove "display_prompt" parameter.
3526         * tui/tui-winsource.c (tui_update_source_window_as_is)
3527         (tui_update_source_windows_with_addr): Update.
3528         (tui_clear_source_content): Remove "display_prompt" parameter.
3529         (tui_erase_source_content): Likewise.  Simplify.
3530         (tui_show_source_content): Update.
3531         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3532         * tui/tui-stack.c (tui_show_frame_info): Update.
3533         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3534         Remove defines.
3535
3536 2019-07-17  Tom Tromey  <tom@tromey.com>
3537
3538         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3539         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3540         parameter.
3541         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3542         parameter.
3543
3544 2019-07-17  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-winsource.c (tui_clear_source_content)
3547         (tui_show_source_content, tui_show_exec_info_content)
3548         (tui_clear_exec_info_content): Update.
3549         * tui/tui-stack.c (tui_show_locator_content): Update.
3550         (tui_show_frame_info): Update.
3551         * tui/tui-source.h (tui_source_window): Don't declare.
3552         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3553         from tui_source_is_displayed.
3554         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3555         Remove field.
3556         (struct tui_source_window_base) <content_in_use>: New field.  Now
3557         bool.
3558         (struct tui_source_window) <showing_source_p>: New method.
3559         (TUI_SRC_WIN): Change cast.
3560         * tui/tui-data.c (tui_initialize_static_data): Update.
3561
3562 2019-07-17  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3565         location_matches_p.
3566         * tui/tui-source.c (tui_source_window::location_matches_p): New
3567         method.
3568         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3569         method.
3570         * tui/tui-data.h (struct tui_source_window_base)
3571         <location_matches_p>: New method.
3572         (struct tui_source_window, struct tui_disasm_window)
3573         <location_matches_p>: Likewise.
3574
3575 2019-07-17  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-win.c (tui_set_win_height_command): Rename from
3578         tui_set_win_height.
3579         (tui_set_win_height_command): Remove.
3580
3581 2019-07-17  Tom Tromey  <tom@tromey.com>
3582
3583         * tui/tui-source.c (tui_source_window): New constructor.  Add
3584         observer.
3585         (~tui_source_window): New destructor.
3586         (tui_source_window::style_changed): New method.
3587         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3588         (tui_attach_detach_observers): Update.
3589         * tui/tui-data.h (struct tui_source_window): Make constructor not
3590         inline.  Add destructor.
3591         (struct tui_source_window) <style_changed>: New method.
3592         <m_observable>: New member.
3593
3594 2019-07-17  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3597         * tui/tui-win.c (tui_resize_all): Fix typo.
3598
3599 2019-07-17  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3602         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3603         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3604         * tui/tui-win.c (window_name_completer): Use foreach.
3605         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3606         (update_tab_width): Likewise.
3607         * tui/tui-layout.c (show_layout): Update.
3608         * tui/tui-data.h (class tui_window_iterator): New.
3609         (struct all_tui_windows): New.
3610         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3611
3612 2019-07-17  Tom Tromey  <tom@tromey.com>
3613
3614         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3615         parameter.  Don't reference globals.
3616         (tui_reg_command): Update.
3617
3618 2019-07-17  Tom Tromey  <tom@tromey.com>
3619
3620         * tui/tui-regs.c (tui_show_registers): Simplify.
3621
3622 2019-07-17  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui-regs.c (tui_show_registers): Update.
3625         (tui_show_register_group): Add win_info parameter.
3626
3627 2019-07-17  Tom Tromey  <tom@tromey.com>
3628
3629         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3630         Rename from tui_display_reg_element_at_line.
3631         (tui_data_window::display_registers_from_line): Update.
3632         * tui/tui-data.h (struct tui_data_window)
3633         <display_reg_element_at_line>: New method.
3634
3635 2019-07-17  Tom Tromey  <tom@tromey.com>
3636
3637         * tui/tui-regs.h (tui_display_registers_from)
3638         (tui_display_registers_from_line): Don't declare.
3639         * tui/tui-windata.c (tui_data_window::display_all_data)
3640         (tui_data_window::refresh_all)
3641         (tui_data_window::do_scroll_vertical): Update.
3642         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3643         from tui_display_registers_from.
3644         (tui_display_reg_element_at_line): Update.
3645         (tui_data_window::display_registers_from_line): Rename from
3646         tui_display_registers_from_line.
3647         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3648         display_registers_from_line>: New methods.
3649
3650 2019-07-17  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3653         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3654         from tui_erase_data_content.
3655         (tui_data_window::display_all_data)
3656         (tui_data_window::refresh_all)
3657         (tui_data_window::do_scroll_vertical): Update.
3658         * tui/tui-regs.c (tui_show_registers): Update.
3659         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3660         New method.
3661
3662 2019-07-17  Tom Tromey  <tom@tromey.com>
3663
3664         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3665         declare.
3666         * tui/tui-windata.c
3667         (tui_data_window::delete_data_content_windows): Rename from
3668         tui_delete_data_content_windows.
3669         (tui_data_window::display_all_data)
3670         (tui_data_window::do_scroll_vertical): Update.
3671         * tui/tui-data.h (struct tui_data_window)
3672         <delete_data_content_windows>: New method.
3673
3674 2019-07-17  Tom Tromey  <tom@tromey.com>
3675
3676         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3677         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3678
3679 2019-07-17  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3682         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3683         from tui_display_all_data.
3684         * tui/tui-win.c
3685         (tui_data_window::do_make_visible_with_new_height): Update.
3686         * tui/tui-regs.c (tui_show_registers): Update.
3687         * tui/tui-layout.c (tui_set_layout): Update.
3688         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3689         method.
3690
3691 2019-07-17  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3694         * tui/tui-windata.c (tui_display_data_from): Remove.
3695         (tui_data_window::refresh_all): Update.
3696
3697 2019-07-17  Tom Tromey  <tom@tromey.com>
3698
3699         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3700         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3701         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3702         tui_display_registers_from_line.
3703         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3704         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3705         "force_display" parameter.
3706
3707 2019-07-17  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3710         declare.
3711         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3712         Rename from tui_first_reg_element_no_inline.
3713         (tui_display_reg_element_at_line)
3714         (tui_display_registers_from_line): Update.
3715         * tui/tui-data.h (struct tui_data_window)
3716         <first_reg_element_no_inline>: New method.
3717
3718 2019-07-17  Tom Tromey  <tom@tromey.com>
3719
3720         * tui/tui-windata.c (tui_display_data_from)
3721         (tui_data_window::do_scroll_vertical): Update.
3722         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3723         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3724         Rename from tui_line_from_reg_element_no.
3725         (tui_display_registers_from_line): Update.
3726         * tui/tui-data.h (struct tui_data_window)
3727         <line_from_reg_element_no>: New method.
3728
3729 2019-07-17  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3732         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3733         tui_last_regs_line_no.
3734         (tui_display_reg_element_at_line)
3735         (tui_display_registers_from_line): Update.
3736         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3737         method.
3738
3739 2019-07-17  Tom Tromey  <tom@tromey.com>
3740
3741         PR tui/24722:
3742         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3743         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3744         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3745         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3746         (tui_update_breakpoint_info): Likewise.
3747         * tui/tui-hooks.c (tui_event_create_breakpoint)
3748         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3749         Update.
3750
3751 2019-07-17  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3754
3755 2019-07-17  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-winsource.c (tui_update_source_window_as_is)
3758         (tui_update_source_windows_with_addr): Update.
3759         * tui/tui-source.h (tui_set_source_content)
3760         (tui_show_symtab_source): Add "win_info" parameter.
3761         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3762         parameter.
3763         (tui_show_symtab_source): Likewise.
3764
3765 2019-07-17  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-wingeneral.c
3768         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3769
3770 2019-07-17  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3773         (struct tui_cmd_window) <can_scroll>: New method.
3774         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3775         method.
3776
3777 2019-07-17  Tom Tromey  <tromey@adacore.com>
3778
3779         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3780         do_field_signed>: Rename.  Change type of "value".
3781         * ui-out.c (ui_out::field_signed): Rename from field_int.
3782         Change type of "value".
3783         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3784         type of "value".
3785         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3786         do_field_int.  Change type of "value".
3787         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3788         do_field_int.  Change type of "value".
3789         * tracepoint.c (trace_status_mi, tfind_1)
3790         (print_one_static_tracepoint_marker): Update.
3791         * thread.c (print_thread_info_1, print_selected_thread_frame):
3792         Update.
3793         * stack.c (print_frame, print_frame_info): Update.
3794         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3795         Update.
3796         * source.c (print_source_lines_base): Update.
3797         * skip.c (info_skip_command): Update.
3798         * record-btrace.c (btrace_ui_out_decode_error)
3799         (btrace_call_history_src_line): Update.
3800         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3801         Update.
3802         * progspace.c (print_program_space): Update.
3803         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3804         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3805         do_field_int.  Change type of "value".
3806         * mi/mi-out.c (mi_ui_out::do_table_begin)
3807         (mi_ui_out::do_table_header): Update.
3808         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3809         type of "value".
3810         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3811         (mi_cmd_data_list_changed_registers, output_register)
3812         (mi_cmd_data_read_memory, mi_load_progress)
3813         (mi_cmd_trace_frame_collected): Update.
3814         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3815         Update.
3816         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3817         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3818         (mi_cmd_var_list_children, varobj_update_one): Update.
3819         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3820         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3821         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3822         * inferior.c (print_inferior): Update.
3823         * gdb_bfd.c (print_one_bfd): Update.
3824         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3825         Update.
3826         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3827         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3828         do_field_int.  Change type of "value".
3829         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3830         do_field_int.  Change type of "value".
3831         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3832         (print_one_breakpoint_location, print_it_catch_fork)
3833         (print_one_catch_fork, print_it_catch_vfork)
3834         (print_one_catch_vfork, print_it_catch_solib)
3835         (print_it_catch_exec, print_it_ranged_breakpoint)
3836         (print_mention_watchpoint, print_mention_masked_watchpoint)
3837         (bkpt_print_it, update_static_tracepoint): Update.
3838         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3839         * break-catch-syscall.c (print_it_catch_syscall): Update.
3840         * ada-tasks.c (print_ada_task_info): Update.
3841         * ada-lang.c (print_it_exception, print_mention_exception):
3842         Update.
3843
3844 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         PR breakpoints/24541
3847         * gdbarch.c: Regenerate.
3848         * gdbarch.h: Regenerate.
3849         * gdbarch.sh: Adjust return type and parameter types for
3850         'stap_adjust_register'.
3851         (i386_stap_adjust_register): Adjust signature and return new
3852         register name.
3853         * stap-probe.c (stap_parse_register_operand): Adjust use of
3854         'gdbarch_stap_adjust_register'.
3855
3856 2019-07-17  Tom Tromey  <tromey@adacore.com>
3857
3858         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3859         declare VEC.
3860         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3861         std::vector.
3862         (struct s390_process_info): Add initializers.
3863         (s390_add_process): Use new.
3864         (s390_linux_nat_target::low_forget_process): Use delete.
3865         (s390_linux_nat_target::low_new_fork)
3866         (s390_linux_nat_target::stopped_by_watchpoint)
3867         (s390_linux_nat_target::low_prepare_to_resume)
3868         (s390_linux_nat_target::insert_watchpoint)
3869         (s390_linux_nat_target::insert_hw_breakpoint)
3870         (s390_linux_nat_target::remove_watchpoint)
3871         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3872
3873 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3874
3875         * aarch64-fbsd-nat.c: Include regcache.h.
3876         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3877         argument.
3878         (aarch64_fbsd_nat_target::fetch_registers)
3879         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3880         variable.
3881         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3882
3883 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3884
3885         * fbsd-nat.c: Include gdbarch.h.
3886
3887 2019-07-15  Tom Tromey  <tromey@adacore.com>
3888
3889         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3890
3891 2019-07-15  Tom Tromey  <tromey@adacore.com>
3892
3893         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3894         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3895         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3896         * cli-out.c (cli_ui_out::do_field_int): New method.
3897         * ui-out.c (ui_out::field_unsigned): New method.
3898         * symfile.c (generic_load): Use field_unsigned.
3899         (print_transfer_performance): Likewise.
3900         * record-btrace.c (ui_out_field_uint): Remove.
3901         (btrace_call_history_insn_range, btrace_call_history): Use
3902         field_unsigned.
3903         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3904         field_unsigned.
3905         * ui-out.h (class ui_out) <field_unsigned>: New method.
3906         <do_field_unsigned>: Likewise.
3907
3908 2019-07-15  Tom Tromey  <tromey@adacore.com>
3909
3910         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3911         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3912         * target.c (flash_erase_command): Use field_string.
3913         * infrun.c (print_signal_received_reason): Use field_string.
3914         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3915         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3916         field_string.
3917         * ada-tasks.c (print_ada_task_info): Use field_string.
3918
3919 2019-07-15  Tom Tromey  <tromey@adacore.com>
3920
3921         * target.c (flash_erase_command): Use field_core_addr.
3922         * symfile.c (generic_load): Use field_core_addr.
3923         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3924         Use field_core_addr.
3925         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3926         field_core_addr.
3927
3928 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3931         value if its desired type is smaller than a CORE_ADDR and signed.
3932
3933 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3936         of changes to field names, and use new is_reference field to
3937         decide if a property is a reference or not.
3938         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3939         field.
3940         (struct dwarf2_property_baton): Update header comment, rename
3941         'referenced_type' to 'property_type' and update comments.
3942         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3943         default property type, store in property baton, update to take
3944         accound of renamed field.
3945         (read_func_scope): Update call to attr_to_dynamic_prop.
3946         (read_array_type): Likewise.
3947         (dwarf2_per_cu_addr_sized_int_type): New function.
3948         (read_subrange_index_type): Move type finding code to
3949         dwarf2_per_cu_addr_sized_int_type.
3950         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3951         (dwarf2_per_cu_addr_type): New function.
3952         (set_die_type): Update calls to attr_to_dynamic_prop.
3953
3954 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3955
3956         * dwarf2read.c (read_subrange_index_type): New function.
3957         (read_subrange_type): Move code into new function and call it.
3958         * gdbtypes.c (create_range_type): Add some asserts.
3959
3960 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3963         update return statements.
3964         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3965         declaration, and update comment to match.
3966         * gdbtypes.c (resolve_dynamic_array): Update call to
3967         dwarf2_evaluate_property to match new return type.
3968
3969 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3970
3971         * valarith.c (value_subscripted_rvalue): Change lowerbound
3972         parameter type from int to LONGEST.
3973         * value.h (value_subscripted_rvalue): Likewise in declaration.
3974
3975 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * cli/cli-utils.c (info_print_command_completer): New function.
3978         * cli/cli-utils.h: Add 'completer.h' include, and forward
3979         declaration for 'struct cmd_list_element'.
3980         (info_print_command_completer): Declare.
3981         * stack.c (_initialize_stack): Add completer for 'info locals' and
3982         'info args'.
3983         * symtab.c (_initialize_symtab): Add completer for 'info
3984         variables' and 'info functions'.
3985         * NEWS: Mention completion for additional info commands.
3986
3987 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * cli/cli-utils.c (extract_info_print_args): Delete.
3990         (extract_arg_maybe_quoted): Delete.
3991         (info_print_options_defs): New variable.
3992         (make_info_print_options_def_group): New function.
3993         (extract_info_print_options): Define new function.
3994         * cli/cli-utils.h (extract_info_print_args): Delete.
3995         (struct info_print_options): New structure.
3996         (extract_info_print_options): Declare new function.
3997         * stack.c (info_locals_command): Update to use new
3998         extract_info_print_options, also add a header comment.
3999         (info_args_command): Likewise.
4000         * symtab.c (info_variables_command): Likewise.
4001         (info_functions_command): Likewise.
4002
4003 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4006         to extract string arguments.
4007         * common/common-utils.c (extract_string_maybe_quoted): New function.
4008         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4009
4010 2019-07-11  Tom Tromey  <tromey@adacore.com>
4011
4012         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4013         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4014         * top.h (gdbinit): Don't declare.
4015         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4016         into...
4017         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4018         * top.c (gdb_init): Don't call init_cli_cmds.
4019         (gdbinit): Remove.
4020         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4021
4022 2019-07-11  Tom Tromey  <tromey@adacore.com>
4023
4024         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4025         after it has been moved.
4026
4027 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4028
4029         * valops.c (value_must_coerce_to_target): Change return type to
4030         bool.
4031         * value.h (value_must_coerce_to_target): Likewise.
4032
4033 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4034
4035         * breakpoint.c (is_hardware_watchpoint): Remove
4036         forward-declaration.
4037         (is_masked_watchpoint): Change return type to bool.
4038         (is_tracepoint): Likewise.
4039         (is_breakpoint): Likewise.
4040         (is_hardware_watchpoint): Likewise.
4041         (is_watchpoint): Likewise.
4042         (is_no_memory_software_watchpoint): Likewise.
4043         (is_catchpoint): Likewise.
4044         (breakpoint_1): Make FILTER parameter's return type bool.
4045         is_masked_watchpoint): Change return type to bool.
4046         (save_breakpoints): Make FILTER parameter's return type bool.
4047         * breakpoint.h (is_breakpoint): Change return type to bool.
4048         (is_watchpoint): Likewise.
4049         (is_catchpoint): Likewise.
4050         (is_tracepoint): Likewise.
4051
4052 2019-07-10  Tom Tromey  <tom@tromey.com>
4053
4054         * defs.h: Don't include gdbarch.h.
4055         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4056         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4057         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4058         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4059         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4060         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4061         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4062         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4063         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4064         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4065         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4066         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4067         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4068         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4069         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4070         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4071         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4072         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4073         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4074         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4075         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4076         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4077         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4078         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4079         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4080         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4081         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4082
4083 2019-07-10  Tom Tromey  <tromey@adacore.com>
4084
4085         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4086         * breakpoint.c (init_ada_exception_breakpoint): Register as
4087         bp_catchpoint.
4088         (print_one_breakpoint_location, print_one_breakpoint): Use
4089         is_ada_exception_catchpoint.
4090         * ada-lang.c (class ada_catchpoint_location): Pass
4091         bp_loc_software_breakpoint to bp_location constructor.
4092         (is_ada_exception_catchpoint): New function.
4093
4094 2019-07-10  Tom Tromey  <tromey@adacore.com>
4095
4096         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4097         VEC.
4098         (struct arm_exidx_entry): New method operator<.
4099         (struct arm_exidx_data) <section_maps>: Change type.
4100         (arm_exidx_data_free): Remove.
4101         (arm_exidx_data_key): Change type.  Move lower.
4102         (arm_exidx_new_objfile): Update.
4103         (arm_compare_exidx_entries): Remove.
4104         (arm_find_exidx_entry, _initialize_arm_tdep)
4105
4106 2019-07-10  Tom Tromey  <tromey@adacore.com>
4107
4108         * solib-spu.c (ocl_program_data_key): Change type.
4109         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4110         Update.
4111
4112 2019-07-10  Tom Tromey  <tromey@adacore.com>
4113
4114         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4115         (struct solib_aix_inferior_data) <library_list>: Change type.
4116         (solib_aix_inferior_data_handle): Change type.
4117         (get_solib_aix_inferior_data): Update.
4118         (solib_aix_free_library_list): Remove.
4119         (library_list_start_library): Update.
4120         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4121         return type.
4122         (solib_aix_get_library_list)
4123         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4124         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4125
4126 2019-07-10  Tom Tromey  <tromey@adacore.com>
4127
4128         * solib-dsbt.c (struct dsbt_info): Add initializers.
4129         (solib_dsbt_pspace_data): Change type.
4130         (dsbt_pspace_data_cleanup): Remove.
4131         (get_dsbt_info, _initialize_dsbt_solib): Update.
4132
4133 2019-07-10  Tom Tromey  <tromey@adacore.com>
4134
4135         * spu-tdep.c (spu_overlay_data): Change type.
4136         (spu_get_overlay_table, spu_overlay_new_objfile)
4137         (_initialize_spu_tdep): Update.
4138
4139 2019-07-10  Tom Tromey  <tromey@adacore.com>
4140
4141         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4142         destructor.
4143         (dbx_objfile_data_key): Change type and declare later.
4144         (DBX_SYMFILE_INFO): Rewrite.
4145         * dbxread.c (dbx_objfile_data_key): Change type.
4146         (dbx_symfile_init): Update.
4147         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4148         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4149         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4150
4151 2019-07-10  Tom Tromey  <tromey@adacore.com>
4152
4153         * jit.c (jit_program_space_key): Change type.  Move lower.
4154         (get_jit_program_space_data): Update.
4155         (jit_program_space_data_cleanup): Remove.
4156         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4157         Update.
4158         (struct jit_program_space_data): Add initializers.
4159
4160 2019-07-10  Tom Tromey  <tromey@adacore.com>
4161
4162         * solib-darwin.c (struct darwin_info): Add initializers.
4163         (solib_darwin_pspace_data): Change type.
4164         (darwin_pspace_data_cleanup): Remove.
4165         (get_darwin_info, _initialize_darwin_solib): Update.
4166
4167 2019-07-10  Tom Tromey  <tromey@adacore.com>
4168
4169         * remote-sim.c (struct sim_inferior_data): Add initializers,
4170         constructor, and destructor.
4171         (sim_inferior_data_key): Change type.  Move lower.
4172         (check_for_duplicate_sim_descriptor): Update.
4173         (get_sim_inferior_data): Use new.  Update.
4174         (~sim_inferior_data_cleanup): Rename from
4175         sim_inferior_data_cleanup.  Simplify.
4176         (gdbsim_close_inferior, simulator_command)
4177         (sim_command_completer, _initialize_remote_sim): Update.
4178         (next_pid, INITIAL_PID): Move earlier.
4179
4180 2019-07-10  Tom Tromey  <tromey@adacore.com>
4181
4182         * python/python-internal.h (create_thread_object): Return
4183         gdbpy_ref.
4184         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4185         * python/py-inferior.c (struct threadlist_entry): Add
4186         constructor.
4187         <thread_obj>: Now a gdbpy_ref.
4188         (thread_to_thread_object): Update.
4189         (add_thread_object): Use new.
4190         (delete_thread_object): Use delete.
4191         (infpy_threads): Update.
4192         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4193         GIL.
4194
4195 2019-07-10  Tom Tromey  <tromey@adacore.com>
4196
4197         * valops.c (value_cast): Specialize error message for Ada.
4198
4199 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4200
4201         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4202
4203 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4204
4205         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4206         bpstat_should_step): Return bool, adjust comments.
4207         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4208         bpstat_should_step): Likewise.
4209
4210 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4211
4212         * features/Makefile: Use feature target descriptions for Arm.
4213         * features/arm/arm-core.c: Generate new file.
4214         * features/arm/arm-fpa.c: Likewise.
4215         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4216         * features/arm/arm-m-profile.c: Likewise.
4217         * features/arm/arm-vfpv2.c: Likewise.
4218         * features/arm/arm-vfpv3.c: Likewise.
4219         * features/arm/xscale-iwmmxt.c: Likewise.
4220         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4221
4222 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4223
4224         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4225         ptrace earlier.
4226
4227 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4228
4229         * features/aarch64-pauth.c: Regenerate.
4230
4231 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4232
4233         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4234         bool.
4235         (bpstat_what): Use false instead of 0.
4236
4237 2019-07-09  Pedro Alves  <palves@redhat.com>
4238
4239         * break-catch-throw.c (is_exception_catchpoint): New.
4240         * breakpoint.c (print_one_breakpoint_location): New parameter
4241         'raw_loc'.  Handle it.  Use
4242         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4243         looking at the breakpoint's type.
4244         (print_one_breakpoint): If handling "maint info breakpoints", also
4245         print locations of exception catchpoints.
4246         * breakpoint.h (is_exception_catchpoint): Declare.
4247
4248 2019-07-09  Pedro Alves  <palves@redhat.com>
4249
4250         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4251         "addr" field.
4252         (allocate_location_exception_catchpoint): New.
4253         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4254         (initialize_throw_catchpoint_ops): Install
4255         allocate_location_exception_catchpoint as allocate_location
4256         method.
4257         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4258         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4259         bp_loc_other.
4260         (breakpoint_address_is_meaningful): Delete.
4261         (bl_address_is_meaningful): New.
4262         (breakpoint_locations_match): Adjust comment.
4263         (bp_location_from_bp_type): New, factored out of...
4264         (bp_location::bp_location(breakpoint *)): ... this.
4265         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4266         factored out of...
4267         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4268         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4269         breakpoint_address_is_meaningful.
4270         (bp_locations_compare): Adjust comment.
4271         (update_global_location_list): Use bl_address_is_meaningful
4272         instead of breakpoint_address_is_meaningful.
4273         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4274         explicit.
4275         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4276         * python/py-breakpoint.c (bppy_get_location): No longer check
4277         whether location is null.
4278
4279 2019-07-09  Pedro Alves  <palves@redhat.com>
4280
4281         PR c++/15468
4282         * breakpoint.c (print_one_breakpoint_location): Remove
4283         single-location assert.
4284
4285 2019-07-09  Tom Tromey  <tom@tromey.com>
4286
4287         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4288         * configure: Rebuild.
4289         * configure.ac: Change common to gdbsupport.
4290         * gdbsupport: Rename from common.
4291         * acinclude.m4: Change common to gdbsupport.
4292         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4293         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4294         gdbsupport.
4295         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4296         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4297         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4298         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4299         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4300         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4301         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4302         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4303         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4304         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4305         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4306         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4307         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4308         coff-pe-read.c, command.h, compile/compile-c-support.c,
4309         compile/compile-c.h, compile/compile-cplus-symbols.c,
4310         compile/compile-cplus-types.c, compile/compile-cplus.h,
4311         compile/compile-loc2c.c, compile/compile.c, completer.c,
4312         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4313         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4314         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4315         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4316         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4317         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4318         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4319         features/aarch64-core.c, features/aarch64-fpu.c,
4320         features/aarch64-pauth.c, features/aarch64-sve.c,
4321         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4322         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4323         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4324         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4325         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4326         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4327         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4328         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4329         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4330         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4331         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4332         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4333         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4334         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4335         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4336         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4337         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4338         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4339         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4340         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4341         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4342         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4343         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4344         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4345         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4346         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4347         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4348         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4349         minsyms.c, mips-linux-tdep.c, namespace.h,
4350         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4351         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4352         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4353         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4354         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4355         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4356         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4357         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4358         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4359         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4360         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4361         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4362         procfs.c, producer.c, progspace.h, psymtab.h,
4363         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4364         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4365         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4366         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4367         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4368         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4369         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4370         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4371         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4372         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4373         target-memory.c, target.c, target.h, target/waitstatus.c,
4374         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4375         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4376         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4377         unittests/array-view-selftests.c,
4378         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4379         unittests/common-utils-selftests.c,
4380         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4381         unittests/format_pieces-selftests.c,
4382         unittests/function-view-selftests.c,
4383         unittests/lookup_name_info-selftests.c,
4384         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4385         unittests/mkdir-recursive-selftests.c,
4386         unittests/observable-selftests.c,
4387         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4388         unittests/parse-connection-spec-selftests.c,
4389         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4390         unittests/scoped_fd-selftests.c,
4391         unittests/scoped_mmap-selftests.c,
4392         unittests/scoped_restore-selftests.c,
4393         unittests/string_view-selftests.c, unittests/style-selftests.c,
4394         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4395         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4396         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4397         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4398         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4399         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4400
4401 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4402
4403         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4404         bool value.
4405         (decode_digits_ordinary): Set explicit_line field in sal.
4406         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4407         symtab_and_line that was set on an explicit line number in
4408         assembler code.  Do always update the recorded symtab and line if
4409         we do skip the prologue.
4410
4411 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4412
4413         * breakpoint.c (set_breakpoint_location_function): Remove
4414         explicit_loc parameter.
4415         (momentary_breakpoint_from_master): Update call to
4416         set_breakpoint_location_function.
4417         (add_location_to_breakpoint): Likewise.
4418
4419 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4422         required features based on default bfd type when no specific bfd
4423         is present.
4424
4425 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4426
4427         * NEWS: Mention that GDB printf and eval commands can now print
4428         C-style and Ada-style convenience var strings without
4429         calling the inferior.
4430         * printcmd.c (printf_c_string): Locally print GDB internal var
4431         instead of transiting via the inferior.
4432         (printf_wide_c_string): Likewise.
4433
4434 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4435
4436         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4437
4438 2019-07-04  Tom Tromey  <tom@tromey.com>
4439
4440         PR tui/24724:
4441         * tui/tui-winsource.c (tui_clear_source_content): Update.
4442         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4443         (tui_update_breakpoint_info): Update.
4444         (tui_set_exec_info_content): Update.
4445         * tui/tui-source.c (tui_set_source_content_nil): Update.
4446         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4447         has_break.
4448         * tui/tui-data.h (enum tui_bp_flag): New.
4449         (tui_bp_flags): New enum flags type.
4450         (struct tui_source_element) <break_mode>: Change type.  Rename
4451         from has_break.
4452         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4453         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4454         constants.
4455         * tui/tui-winsource.h: Fix comment.
4456
4457 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4458
4459         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4460         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4461         (store_fpregs_to_thread)
4462         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4463         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4464         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4465         (IWMMXT_REGS_SIZE): Add define.
4466         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4467         (fetch_vfp_regs, store_vfp_regs)
4468         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4469         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4470
4471 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4472
4473         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4474         defines.
4475         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4476         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4477         (ARM_INT_REGISTER_SIZE): ...to this.
4478         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4479         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4480         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4481         (arm_linux_collect_gregset, supply_nwfpe_register)
4482         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4483         defines.
4484         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4485         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4486         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4487         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4488         (arm_return_in_memory, arm_store_return_value)
4489         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4490         (arm_record_ld_st_multiple): Likewise.
4491         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4492         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4493
4494 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4495
4496         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4497         AARCH64_DISPLACED_MODIFIED_INSNS.
4498         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4499         (aarch64_displaced_step_copy_insn): Likewise.
4500         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4501         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4502         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4503         ARM_DISPLACED_MODIFIED_INSNS.
4504         * arm-tdep.c (arm_gdbarch_init): Likewise.
4505         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4506         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4507         (struct arm_displaced_step_closure): Use
4508         ARM_DISPLACED_MODIFIED_INSNS.
4509
4510 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4511
4512         * features/Makefile: Remove unused xml files.
4513         * features/aarch64.xml: Remove.
4514         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4515         * features/i386/amd64-avx-avx512.xml: Remove.
4516         * features/i386/amd64-avx-linux.xml: Remove.
4517         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4518         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4519         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4520         * features/i386/amd64-avx-mpx.xml: Remove.
4521         * features/i386/amd64-avx.xml: Remove.
4522         * features/i386/amd64-linux.xml: Remove.
4523         * features/i386/amd64-mpx-linux.xml: Remove.
4524         * features/i386/amd64-mpx.xml: Remove.
4525         * features/i386/amd64.xml: Remove.
4526         * features/i386/i386-avx-avx512-linux.xml: Remove.
4527         * features/i386/i386-avx-avx512.xml: Remove.
4528         * features/i386/i386-avx-linux.xml: Remove.
4529         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4530         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4531         * features/i386/i386-avx-mpx-linux.xml: Remove.
4532         * features/i386/i386-avx-mpx.xml: Remove.
4533         * features/i386/i386-avx.xml: Remove.
4534         * features/i386/i386-linux.xml: Remove.
4535         * features/i386/i386-mmx-linux.xml: Remove.
4536         * features/i386/i386-mmx.xml: Remove.
4537         * features/i386/i386-mpx-linux.xml: Remove.
4538         * features/i386/i386-mpx.xml: Remove.
4539         * features/i386/i386.xml: Remove.
4540         * features/i386/x32-avx-avx512-linux.xml: Remove.
4541         * features/i386/x32-avx-linux.xml: Remove.
4542         * features/i386/x32-linux.xml: Remove.
4543
4544 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4545
4546         * regformats/aarch64.dat: Remove.
4547         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4548         * regformats/i386/amd64-avx-linux.dat: Remove.
4549         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4550         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4551         * regformats/i386/amd64-linux.dat: Remove.
4552         * regformats/i386/amd64-mpx-linux.dat: Remove.
4553         * regformats/i386/amd64.dat: Remove.
4554         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4555         * regformats/i386/i386-avx-linux.dat: Remove.
4556         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4557         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4558         * regformats/i386/i386-linux.dat: Remove.
4559         * regformats/i386/i386-mmx-linux.dat: Remove.
4560         * regformats/i386/i386-mpx-linux.dat: Remove.
4561         * regformats/i386/i386.dat: Remove.
4562         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4563         * regformats/i386/x32-avx-linux.dat: Remove.
4564         * regformats/i386/x32-linux.dat: Remove.
4565
4566 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4567
4568         * aarch64-tdep.c: Remove xml self tests.
4569         * amd64-linux-tdep.c: Likewise.
4570         * amd64-tdep.c: Likewise.
4571         * i386-linux-tdep.c: Likewise.
4572         * i386-tdep.c: Likewise.
4573
4574 2019-07-03  Pedro Alves  <palves@redhat.com>
4575
4576         PR cli/24732
4577         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4578         (pipe_cmd_option_defs): New.
4579         (make_pipe_cmd_options_def_group): New.
4580         (pipe_command): Use gdb::option::process_options.
4581         (pipe_command_completer): New function.
4582         (_initialize_cli_cmds): Install completer for "pipe" command.
4583
4584 2019-07-03  Pedro Alves  <palves@redhat.com>
4585
4586         * cli/cli-option.c (union option_value) <string>: New field.
4587         (struct option_def_and_value): Add ctor, move ctor, dtor and
4588         use DISABLE_COPY_AND_ASSIGN.
4589         (option_def_and_value::clear_value): New.
4590         (parse_option, save_option_value_in_ctx, get_val_type_str)
4591         (add_setshow_cmds_for_options): Handle var_string.
4592         * cli-option.h (union option_def::var_address) <string>: New
4593         field.
4594         (struct string_option_def): New.
4595         * maint-test-options.c (struct test_options_opts): Add default
4596         ctor and use DISABLE_COPY_AND_ASSIGN.
4597         <string_opt>: New field.
4598         (test_options_opts::~test_options_opts): New.
4599         (test_options_opts::dump): Also dump "-string".
4600         (test_options_option_defs): Install "string.
4601
4602 2019-07-03  Pedro Alves  <palves@redhat.com>
4603
4604         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4605         option_value with a null enumeration.
4606         (complete_options): Save the option values in the context.
4607         (save_option_value_in_ctx): New, factored out from ...
4608         (process_options): ... here.
4609         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4610         of the function.
4611         * maint-test-options.c (test_options_opts::dump): New, factored
4612         out from ...
4613         (maintenance_test_options_command_mode): ... here.
4614         (maintenance_test_options_command_completion_result): Delete.
4615         (maintenance_test_options_command_completion_text): Update
4616         comment.
4617         (maintenance_show_test_options_completion_result): Change
4618         prototype.  Just print
4619         maintenance_test_options_command_completion_text.
4620         (save_completion_result): New.
4621         (maintenance_test_options_completer_mode): Pass options context to
4622         complete_options, and then save a dump.
4623         (_initialize_maint_test_options): Use add_cmd to install "maint
4624         show test-options-completion-result".
4625
4626 2019-07-03  Pedro Alves  <palves@redhat.com>
4627
4628         * NEWS (New commands): Mention "with" and "maint with".
4629         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4630         (with_command, with_command_completer): New.
4631         (pipe_command): Adjust to new repeat_previous
4632         interface.
4633         (_initialize_cli_cmds): Install the "with" command and its "w"
4634         alias.
4635         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4636         declarations.
4637         * cli/cli-setshow.c (parse_cli_var_uinteger)
4638         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4639         argument strings for all var_types.
4640         (get_setshow_command_value_string): New, factored out from ...
4641         (do_show_command): ... this.
4642         * cli/cli-setshow.h: Include <string>.
4643         (get_setshow_command_value_string): Declare.
4644         * command.h (repeat_previous): Now returns const char *.  Adjust
4645         comment.
4646         * maint.c: Include "cli/cli-cmds.h".
4647         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4648         (_initialize_maint_cmds): Register the "maintenance with" command.
4649         * top.c (repeat_previous): Move bits from pipe_command here:
4650         Return the saved command line, if any; error out if there's no
4651         command to relaunch.
4652
4653 2019-07-03  Pedro Alves  <palves@redhat.com>
4654
4655         * NEWS (New commands): Mention "maint set/show test-settings"
4656         instead of "maint test-settings".
4657         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4658         (maintenance_test_settings_set_list): Rename to ...
4659         (maintenance_set_test_settings_list): ... this.
4660         (maintenance_test_settings_show_list): Rename to  ...
4661         (maintenance_show_test_settings_list): ... this.
4662         (maintenance_test_settings_cmd): Delete.
4663         (maintenance_test_settings_set_cmd): ...
4664         (maintenance_set_test_settings_cmd): ... this.
4665         (maintenance_test_settings_show_cmd): ...
4666         (maintenance_show_test_settings_cmd): ... this.
4667         (maintenance_test_settings_show_value_cmd):
4668         (maintenance_show_test_settings_value_cmd): ... this.
4669         (_initialize_maint_test_settings): No longer install the "maint
4670         test-settings" prefix command.  Rename "maint test-settings set"
4671         to "maint set test-settings", and "maint test-settings show" to
4672         "maint show test-settings".  Adjust all subcommands.
4673
4674 2019-07-03  Pedro Alves  <palves@redhat.com>
4675
4676         * maint-test-settings.c: Fix file's intro comment.  Replace all
4677         references to "test-options" with references to "test-settings",
4678         in comments.
4679
4680 2019-07-03  Pedro Alves  <palves@redhat.com>
4681
4682         * maint-test-settings.c (maintenance_test_settings_xxx)
4683         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4684         New.
4685         (maintenance_test_settings_enums): Use them.
4686         (maintenance_test_settings_enum): Default to
4687         maintenance_test_settings_xxx.
4688         (_initialize_maint_test_settings): Initialize
4689         MAINTENANCE_TEST_SETTINGS_FILENAME.
4690
4691 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4692
4693         * breakpoint.h (remove_breakpoints_inf): Change return type to
4694         void, move function documentation here.
4695         * breakpoint.c (remove_breakpoints_inf): Change return type to
4696         void, move function documentation to header.
4697
4698 2019-07-02  Pedro Alves  <palves@redhat.com>
4699
4700         * NEWS (Completion improvements): Mention "info threads".
4701         * thread.c (struct info_threads_opts, info_threads_option_defs)
4702         (make_info_threads_options_def_group): New.
4703         (info_threads_command): Use gdb::option::process_options.
4704         (info_threads_command_completer): New.
4705         (_initialize_thread): Use gdb::option::build_help to build the
4706         help text for "info threads".
4707
4708 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4709
4710         * defs.h (generic_load): Move from here...
4711         * symfile.h (generic_load): ... to here.  Rename name parameter
4712         to args.
4713         * symfile.c (generic_load): Add comment.
4714
4715 2019-07-01  Tom Tromey  <tromey@adacore.com>
4716
4717         * dwarf2read.c
4718         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4719         declaration of without_params.  Fix formatting.
4720
4721 2019-07-01  Tom Tromey  <tromey@adacore.com>
4722
4723         * ada-exp.y (find_primitive_type): Update.
4724         * ada-lang.h (ada_lookup_symbol): Update.
4725         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4726         parameter.
4727         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4728
4729 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4730
4731         PR breakpoints/24541
4732         * gdbarch.c: Regenerate.
4733         * gdbarch.h: Regenerate.
4734         * gdbarch.sh: Add 'stap_adjust_register'.
4735         * i386-tdep.c: Include '<unordered_set>'.
4736         (i386_stap_adjust_register): New function.
4737         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4738         * stap-probe.c (stap_parse_register_operand): Call
4739         'gdbarch_stap_adjust_register'.
4740
4741 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4742
4743         PR python/24742
4744         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4745         * python/python.c (do_start_initialization): Use 'xmalloc'
4746         instead of 'PyMem_Malloc'.
4747
4748 2019-06-28  Tom Tromey  <tromey@adacore.com>
4749
4750         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4751         for Ada.
4752
4753 2019-06-27  Tom Tromey  <tromey@adacore.com>
4754
4755         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4756         objfile_key.
4757         (arm_find_mapping_symbol, arm_record_special_symbol)
4758         (_initialize_arm_tdep): Update.
4759         (arm_objfile_data_free): Remove.
4760
4761 2019-06-27  Tom Tromey  <tromey@adacore.com>
4762
4763         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4764         to cp_print_static_field.
4765
4766 2019-06-26  Tom Tromey  <tromey@adacore.com>
4767
4768         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4769         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4770         declare.
4771
4772 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4773
4774         * features/aarch64-core.c (create_feature_aarch64_core):
4775         Regenerate.
4776         * features/aarch64-core.xml: Add cpsr flags.
4777
4778 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4779
4780         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4781         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4782
4783 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4784
4785         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4786         field.
4787         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4788         use.
4789         (arm_record_special_symbol): Don't insert new symbol in sorted
4790         position, push it at the end.
4791
4792 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4793
4794         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4795         (arm_mapping_symbol_s): Remove.
4796         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4797         (arm_mapping_symbol_vec): New typedef.
4798         (struct arm_per_objfile): Add constructor.
4799         <section_maps>: Change type to
4800         std::unique_ptr<arm_mapping_symbol_vec[]>.
4801         (arm_compare_mapping_symbols): Remove.
4802         (arm_find_mapping_symbol): Adjust to section_maps type change.
4803         (arm_objfile_data_free): Call delete on arm_per_objfile.
4804         (arm_record_special_symbol): Adjust to section_maps type change.
4805         Allocate arm_per_objfile with new.
4806
4807 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4808
4809         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4810         with the command prefix.
4811
4812 2019-06-25  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4815         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4816
4817 2019-06-25  Tom Tromey  <tom@tromey.com>
4818
4819         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4820         type.
4821         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4822         protected.
4823
4824 2019-06-25  Tom Tromey  <tom@tromey.com>
4825
4826         * tui/tui-winsource.c
4827         (tui_source_window_base::set_is_exec_point_at): Add check against
4828         LOA_ADDRESS.
4829
4830 2019-06-25  Tom Tromey  <tom@tromey.com>
4831
4832         * tui/tui-source.c (tui_set_source_content): Don't check before
4833         xfree.
4834         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4835
4836 2019-06-25  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-winsource.h (tui_update_source_window_as_is)
4839         (tui_alloc_source_buffer, tui_line_is_displayed)
4840         (tui_addr_is_displayed): Change type of win_info.
4841         * tui/tui-winsource.c (tui_update_source_window_as_is)
4842         (tui_clear_source_content, tui_show_source_line)
4843         (tui_show_source_content, tui_source_window_base::refill)
4844         (tui_source_window_base::set_is_exec_point_at)
4845         (tui_source_window_base::set_is_exec_point_at)
4846         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4847         (tui_alloc_source_buffer, tui_line_is_displayed)
4848         (tui_addr_is_displayed): Change type of win_info.  Update.
4849         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4850         (tui_source_window_base::do_make_visible_with_new_height):
4851         Update.
4852         * tui/tui-source.c (tui_set_source_content)
4853         (tui_set_source_content_nil)
4854         (tui_source_window::do_scroll_vertical): Update.
4855         * tui/tui-layout.c (show_layout): Update.
4856         * tui/tui-disasm.c (tui_set_disassem_content)
4857         (tui_disasm_window::do_scroll_vertical): Update.
4858         * tui/tui-data.h (tui_win_content): Remove.
4859         (struct tui_gen_win_info) <content, content_size>: Remove.
4860         (struct tui_source_element): Add initializers and destructor.
4861         (union tui_which_element, struct tui_win_element): Remove.
4862         (struct tui_source_window_base) <content>: New field.
4863         (struct tui_data_window): Remove destructor.
4864         (tui_alloc_content, tui_free_win_content)
4865         (tui_free_all_source_wins_content): Don't declare.
4866         * tui/tui-data.c (tui_initialize_static_data): Update.
4867         (init_content_element, tui_alloc_content): Remove.
4868         (~tui_gen_win_info): Update.
4869         (~tui_data_window, tui_free_all_source_wins_content)
4870         (tui_free_win_content, free_content, free_content_elements):
4871         Remove.
4872
4873 2019-06-25  Tom Tromey  <tom@tromey.com>
4874
4875         * tui/tui-winsource.h (tui_clear_source_content)
4876         (tui_erase_source_content, tui_show_source_content): Change type
4877         of win_info.
4878         * tui/tui-winsource.c (tui_clear_source_content)
4879         (tui_erase_source_content, tui_show_source_content): Change type
4880         of win_info.
4881         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4882         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4883         win_info.
4884         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4885         win_info.
4886         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4887
4888 2019-06-25  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui-winsource.c (tui_clear_source_content)
4891         (tui_source_window_base::set_is_exec_point_at): Update.
4892         * tui/tui-source.c (tui_set_source_content_nil): Update.
4893         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4894         a bool.
4895         * tui/tui-data.c (init_content_element): Update.
4896
4897 2019-06-25  Tom Tromey  <tom@tromey.com>
4898
4899         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4900         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4901         * tui/tui-layout.c (init_and_make_win): Update.
4902         * tui/tui.h (enum tui_win_type): Update.
4903         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4904         tui_win_is_auxillary.
4905         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4906         tui_win_is_auxillary.
4907
4908 2019-06-25  Tom Tromey  <tom@tromey.com>
4909
4910         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4911         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4912         (tui_delete_data_content_windows, tui_display_all_data)
4913         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4914         Update.
4915         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4916         * tui/tui-regs.c (tui_last_regs_line_no)
4917         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4918         (tui_show_registers): Update.
4919         (tui_show_register_group): Return void.  Update.
4920         (tui_display_registers_from, tui_display_reg_element_at_line)
4921         (tui_display_registers_from_line, tui_check_register_values):
4922         Update.
4923         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4924         member.
4925         (struct tui_data_window) <regs_content>: Now a std::vector.
4926         <regs_content_count>: Remove.
4927         (tui_add_content_elements, tui_free_data_content): Don't declare.
4928         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4929         (init_content_element): Remove DATA_WIN case.  Add assert.
4930         (tui_add_content_elements): Remove.
4931         (tui_data_window): Update.
4932         (tui_free_data_content): Remove.
4933         (free_content_elements): Remove DATA_WIN case.
4934
4935 2019-06-25  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-data.c (tui_data_item_window): Update.
4938         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4939         * tui/tui-windata.c (tui_display_all_data)
4940         (tui_display_data_from_line): Update.
4941         (tui_check_data_values): Remove.
4942         * tui/tui-regs.c (tui_show_register_group)
4943         (tui_display_reg_element_at_line): Update.
4944         * tui/tui-hooks.c (tui_register_changed)
4945         (tui_refresh_frame_and_register_information): Call
4946         tui_check_register_values.
4947         * tui/tui-data.h (struct tui_data_window) <data_content,
4948         data_content_count, data_type>: Remove.
4949         (enum tui_data_type): Remove.
4950
4951         * tui/tui-data.c (tui_data_window::clear_detail)
4952         (~tui_data_window): Update.
4953
4954 2019-06-25  Tom Tromey  <tom@tromey.com>
4955
4956         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4957         declare.
4958         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4959         Rename from tui_first_data_item_displayed.  Update.
4960         (tui_data_window::refresh_all)
4961         (tui_data_window::do_scroll_vertical): Update.
4962         * tui/tui-data.h (struct tui_data_window)
4963         <first_data_item_displayed>: Declare new method.
4964
4965 2019-06-25  Tom Tromey  <tom@tromey.com>
4966
4967         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4968         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4969         contents...
4970         (tui_initialize_static_data): ...here.
4971
4972 2019-06-25  Tom Tromey  <tom@tromey.com>
4973
4974         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4975         (tui_display_registers_from, tui_check_register_values): Update.
4976         (tui_display_register): Remove win_info parameter; update.
4977         (tui_get_register): Change type of parameters.
4978         * tui/tui-data.h (struct tui_data_element): Remove.
4979         (union tui_which_element) <data>: Remove.
4980         <data_window>: Change type.
4981         (struct tui_data_item_window): New.
4982         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4983         case.  Add assert.
4984         (~tui_data_item_window): New destructor.
4985         (free_content_elements): Remove DATA_ITEM_WIN case.
4986
4987 2019-06-25  Tom Tromey  <tom@tromey.com>
4988
4989         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4990         Remove.
4991
4992 2019-06-25  Tom Tromey  <tom@tromey.com>
4993
4994         * tui/tui-data.h (struct tui_command_element): Remove.
4995         (union tui_which_element) <command>: Remove.
4996         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4997         assert.
4998         (free_content_elements): Remove CMD_WIN case.
4999
5000 2019-06-25  Tom Tromey  <tom@tromey.com>
5001
5002         * tui/tui-layout.c (tui_set_layout): Update.
5003         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5004         * tui/tui-data.c (layout_def): Update.
5005
5006 2019-06-25  Tom Tromey  <tom@tromey.com>
5007
5008         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5009         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5010         (tui_source_window_base::set_new_height): Update.
5011         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5012         Update.
5013         (tui_set_locator_fullname, tui_set_locator_info)
5014         (tui_show_frame_info): Update.
5015         * tui/tui-source.c (tui_set_source_content)
5016         (tui_source_is_displayed): Update.
5017         * tui/tui-layout.c (show_source_disasm_command, show_data)
5018         (show_source_or_disasm_and_command): Update.
5019         * tui/tui-disasm.c (tui_set_disassem_content)
5020         (tui_get_begin_asm_address): Update.
5021         * tui/tui-data.h (struct tui_locator_element): Remove.
5022         (union tui_which_element) <locator>: Remove.
5023         (struct tui_locator_window): New.
5024         (tui_locator_win_info_ptr): Change return type.
5025         * tui/tui-data.c (_locator): Change type.
5026         (tui_locator_win_info_ptr): Change return type.
5027         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5028         (tui_alloc_content): Add assert.
5029
5030 2019-06-25  Tom Tromey  <tom@tromey.com>
5031
5032         * tui/tui-winsource.c
5033         (tui_exec_info_window::maybe_allocate_content): New method.
5034         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5035         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5036         (make_source_or_disasm_window): Add cast.
5037         * tui/tui-data.h (union tui_which_element) <simple_string>:
5038         Remove.
5039         (struct tui_source_info): New.
5040         (struct tui_source_window_base) <execution_info>: Change type.
5041         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5042         case, and add assert.
5043         (tui_alloc_content): Add assert.
5044
5045 2019-06-25  Tom Tromey  <tom@tromey.com>
5046
5047         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5048         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5049         * tui/tui-data.c (tui_alloc_win_info): Remove.
5050
5051 2019-06-25  Tom Tromey  <tom@tromey.com>
5052
5053         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5054         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5055         can_highlight.
5056
5057 2019-06-25  Tom Tromey  <tom@tromey.com>
5058
5059         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5060         make_visible_with_new_height method.
5061         (tui_win_info::make_visible_with_new_height): New method.
5062         (tui_source_window_base::do_make_visible_with_new_height)
5063         (tui_data_window::do_make_visible_with_new_height)
5064         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5065         (make_visible_with_new_height): Remove.
5066         (tui_resize_all, tui_adjust_win_heights): Use
5067         make_visible_with_new_height method.
5068         * tui/tui-data.h (struct tui_win_info)
5069         <do_make_visible_with_new_height, make_visible_with_new_height>:
5070         New methods.
5071         (struct tui_source_window_base, struct tui_data_window)
5072         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5073         methods.
5074
5075 2019-06-25  Tom Tromey  <tom@tromey.com>
5076
5077         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5078         method.
5079         (update_tab_width): Call update_tab_width method.
5080         * tui/tui-data.h (struct tui_win_info)
5081         (struct tui_source_window_base) <update_tab_width>: New methods.
5082
5083 2019-06-25  Tom Tromey  <tom@tromey.com>
5084
5085         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5086         parameter.
5087         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5088         parameter.
5089         (tui_gen_win_info::make_visible): Update.
5090         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5091         parameter.
5092         * tui/tui-data.h (enum tui_box): New enum.
5093         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5094
5095 2019-06-25  Tom Tromey  <tom@tromey.com>
5096
5097         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5098         init_and_make_win for EXEC_INFO_WIN.
5099         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5100         longer inline.
5101         (struct tui_win_info) <~tui_win_info>: Inline.
5102         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5103         Don't declare.
5104         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5105         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5106         Remove.
5107         (tui_initialize_static_data): Update.
5108         (~tui_gen_win_info): Handle more cleanup here.
5109         (~tui_source_window_base): Delete "execution_info".
5110         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5111
5112 2019-06-25  Tom Tromey  <tom@tromey.com>
5113
5114         * tui/tui-layout.c (make_command_window): Don't set
5115         can_highlight.
5116         (show_source_disasm_command): Call the reset method.
5117         (show_data): Don't set can_highlight.  Call the reset method.
5118         (tui_gen_win_info::reset): Rename from init_gen_win_info
5119         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5120         (show_source_or_disasm_and_command): Call the reset method.
5121         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5122         (struct tui_cmd_window): Set can_highlight.
5123
5124 2019-06-25  Tom Tromey  <tom@tromey.com>
5125
5126         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5127         from make_visible.
5128         (tui_make_visible, tui_make_invisible): Rewrite.
5129         (tui_win_info::make_visible): Remove.
5130         (tui_source_window_base::make_visible): Update.
5131         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5132         method.  Moved from...
5133         (struct tui_win_info) <make_visible>: ...here.
5134
5135 2019-06-25  Tom Tromey  <tom@tromey.com>
5136
5137         * tui/tui-winsource.c
5138         (tui_source_window_base::do_scroll_horizontal): Remove direction
5139         parameter.
5140         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5141         direction parameter.
5142         * tui/tui-win.c (tui_win_info::forward_scroll)
5143         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5144         (tui_win_info::right_scroll): Update.
5145         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5146         direction parameter.
5147         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5148         direction parameter.
5149         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5150         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5151         Remove direction parameter.
5152         (struct tui_source_window_base, struct tui_source_window)
5153         (struct tui_disasm_window, struct tui_data_window)
5154         (struct tui_cmd_window): Update.
5155
5156 2019-06-25  Tom Tromey  <tom@tromey.com>
5157
5158         * tui/tui-winsource.h (tui_set_exec_info_content)
5159         (tui_show_exec_info_content, tui_erase_exec_info_content)
5160         (tui_clear_exec_info_content, tui_update_exec_info): Change
5161         argument to tui_source_window_base.
5162         * tui/tui-winsource.c (tui_set_exec_info_content)
5163         (tui_show_exec_info_content, tui_erase_exec_info_content)
5164         (tui_clear_exec_info_content, tui_update_exec_info): Change
5165         argument to tui_source_window_base.
5166
5167 2019-06-25  Tom Tromey  <tom@tromey.com>
5168
5169         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5170         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5171
5172 2019-06-25  Tom Tromey  <tom@tromey.com>
5173
5174         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5175         check.
5176
5177 2019-06-25  Tom Tromey  <tom@tromey.com>
5178
5179         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5180         type to void.
5181         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5182         type to void.
5183         * tui/tui-source.c (tui_set_source_content): Update.
5184         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5185
5186 2019-06-25  Tom Tromey  <tom@tromey.com>
5187
5188         * tui/tui-win.c (window_name_completer, tui_set_focus)
5189         (tui_all_windows_info): Use name method.
5190         * tui/tui-data.h (struct tui_gen_win_info)
5191         (struct tui_source_window, struct tui_disasm_window)
5192         (struct tui_data_window, struct tui_cmd_window) <name>: New
5193         method.
5194         (tui_win_name): Don't declare.
5195         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5196         (tui_win_name): Remove.
5197
5198 2019-06-25  Tom Tromey  <tom@tromey.com>
5199
5200         * tui/tui-winsource.h (tui_update_source_window)
5201         (tui_update_source_window_as_is): Change parameter type.
5202         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5203         to be a tui_source_window_base.
5204         (tui_update_source_window_as_is): Likewise.
5205         * tui/tui-win.c (make_visible_with_new_height): Update.
5206
5207 2019-06-25  Tom Tromey  <tom@tromey.com>
5208
5209         * tui/tui-winsource.c (tui_erase_source_content)
5210         (tui_show_source_content, tui_show_exec_info_content)
5211         (tui_erase_exec_info_content): Use refresh_window method.
5212         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5213         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5214         from tui_refresh_win.
5215         (tui_data_window::refresh_window): New method.
5216         (tui_win_info::refresh, tui_source_window_base::refresh)
5217         (tui_refresh_all): Use refresh_window method.
5218         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5219         method.
5220         * tui/tui-regs.c (tui_display_register): Call refresh_window
5221         method.
5222         * tui/tui-layout.c (show_source_disasm_command)
5223         (show_source_or_disasm_and_command): Call refresh_window method.
5224         * tui/tui-data.h (struct tui_gen_win_info)
5225         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5226         New method.
5227
5228 2019-06-25  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui.c (tui_rl_other_window, tui_enable)
5231         (tui_is_window_visible, tui_get_command_dimension): Update.
5232         * tui/tui-winsource.c (tui_update_source_window_as_is)
5233         (tui_clear_source_content, tui_erase_source_content)
5234         (tui_show_source_line, tui_source_window_base::refill)
5235         (tui_source_window_base::do_scroll_horizontal)
5236         (tui_source_window_base::set_is_exec_point_at)
5237         (tui_update_breakpoint_info, tui_set_exec_info_content)
5238         (tui_alloc_source_buffer, tui_line_is_displayed)
5239         (tui_addr_is_displayed): Update.
5240         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5241         (tui_check_and_display_highlight_if_needed)
5242         (tui_win_info::make_visible, tui_win_info::refresh)
5243         (tui_refresh_all): Update.
5244         * tui/tui-windata.c (tui_first_data_item_displayed)
5245         (tui_delete_data_content_windows, tui_erase_data_content)
5246         (tui_display_all_data, tui_data_window::refresh_all)
5247         (tui_check_data_values): Update.
5248         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5249         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5250         (tui_win_info::backward_scroll, tui_refresh_all_win)
5251         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5252         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5253         (tui_source_window_base::set_new_height)
5254         (tui_data_window::set_new_height)
5255         (make_invisible_and_set_new_height)
5256         (make_visible_with_new_height, new_height_ok)
5257         (parse_scrolling_args): Update.
5258         * tui/tui-stack.c (tui_show_frame_info): Update.
5259         * tui/tui-source.c (tui_set_source_content)
5260         (tui_set_source_content_nil, tui_source_is_displayed)
5261         (tui_source_window::do_scroll_vertical): Update.
5262         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5263         (tui_display_registers_from, tui_display_reg_element_at_line)
5264         (tui_check_register_values, tui_reg_command): Update.
5265         * tui/tui-layout.c (tui_default_win_height)
5266         (show_source_disasm_command, show_data, init_and_make_win)
5267         (show_source_or_disasm_and_command): Update.
5268         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5269         (tui_redisplay_readline, tui_mld_flush)
5270         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5271         (tui_getc): Update.
5272         * tui/tui-disasm.c (tui_set_disassem_content)
5273         (tui_disasm_window::do_scroll_vertical): Update.
5274         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5275         Now virtual.
5276         (struct tui_win_info): Derive from tui_gen_win_info.
5277         <~tui_win_info>: Mark as override.
5278         <generic>: Remove member.
5279         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5280         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5281         (~tui_data_window, ~tui_win_info)
5282         (tui_free_all_source_wins_content): Update.
5283         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5284
5285 2019-06-25  Tom Tromey  <tom@tromey.com>
5286
5287         * tui/tui-layout.c (init_and_make_win): Use new.
5288         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5289         destructor, initializers.
5290         (tui_alloc_generic_win_info): Don't declare.
5291         * tui/tui-data.c (_locator): Add argument to constructor.
5292         (source_win, disasm_win): New globals.
5293         (exec_info): Remove.
5294         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5295         Update.
5296         (tui_alloc_generic_win_info): Remove.
5297         (init_content_element): Use new.
5298         (tui_win_info::tui_win_info): Update.
5299         (free_content_elements) <case DATA_WIN>: Use delete.
5300
5301 2019-06-25  Tom Tromey  <tom@tromey.com>
5302
5303         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5304         * tui/tui-windata.c (tui_first_data_item_displayed)
5305         (tui_delete_data_content_windows): Update.
5306         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5307         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5308         (tui_display_registers_from, tui_check_register_values): Update.
5309         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5310         pointer.
5311         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5312         window.
5313         (tui_free_data_content): Update.
5314         (free_content_elements) <case DATA_WIN>: Free the window.
5315
5316 2019-06-25  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5319         Update.
5320         * tui/tui-layout.c (make_command_window)
5321         (show_source_disasm_command, show_data, init_and_make_win)
5322         (show_source_or_disasm_and_command): Update.
5323         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5324         method.
5325         <can_highight, is_highlighted>: Now bool.
5326         (tui_set_win_highlight): Don't declare.
5327         * tui/tui-data.c (tui_set_win_highlight): Remove.
5328
5329 2019-06-25  Tom Tromey  <tom@tromey.com>
5330
5331         * tui/tui-wingeneral.c (make_visible): Remove check of window
5332         type.
5333
5334 2019-06-25  Tom Tromey  <tom@tromey.com>
5335
5336         * tui/tui-win.c (tui_win_info::max_height)
5337         (tui_cmd_window::max_height): New methods.
5338         (new_height_ok): Call max_height.
5339         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5340         <max_height>: New method.
5341
5342 2019-06-25  Tom Tromey  <tom@tromey.com>
5343
5344         * tui/tui-win.c (tui_source_window_base::set_new_height)
5345         (tui_data_window::set_new_height): New methods.
5346         (make_invisible_and_set_new_height): Call set_new_height method.
5347         * tui/tui-data.h (struct tui_win_info)
5348         (struct tui_source_window_base, struct tui_data_window)
5349         <set_new_height>: New method.
5350
5351 2019-06-25  Tom Tromey  <tom@tromey.com>
5352
5353         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5354         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5355         tui_refresh_data_win.
5356         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5357         method.
5358         (tui_refresh_all_win): Call the refresh_all method.
5359         (tui_set_focus): Likewise.
5360         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5361         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5362         Likewise.
5363
5364 2019-06-25  Tom Tromey  <tom@tromey.com>
5365
5366         * tui/tui-winsource.h (tui_refill_source_window)
5367         (tui_set_is_exec_point_at): Don't declare.
5368         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5369         (tui_source_window_base::refill): Rename from
5370         tui_refill_source_window.
5371         (tui_source_window_base::do_scroll_horizontal): Update.
5372         (tui_source_window_base::set_is_exec_point_at): Rename from
5373         tui_set_is_exec_point_at.
5374         (tui_update_all_breakpoint_info): Update.
5375         * tui/tui-stack.c (tui_show_frame_info): Update.
5376         * tui/tui-layout.c (show_data): Add cast.
5377         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5378         * tui/tui-data.h (struct tui_source_window_base) <refill,
5379         set_is_exec_point_at>: New methods.
5380         (tui_source_windows, tui_add_to_source_windows): Update types.
5381         (tui_add_to_source_windows): Remove redundant declaration.
5382         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5383         (tui_source_windows): Change return type.
5384         (tui_clear_source_windows_detail): Update.
5385         (tui_add_to_source_windows): Change type of parameter.
5386         (tui_free_all_source_wins_content): Update.
5387
5388 2019-06-25  Tom Tromey  <tom@tromey.com>
5389
5390         * tui/tui-wingeneral.c (tui_win_info::refresh)
5391         (tui_source_window_base::refresh): New methods.
5392         (tui_refresh_all): Call the refresh method.
5393         * tui/tui-data.h (struct tui_win_info)
5394         (struct tui_source_window_base) <refresh>: New method.
5395
5396 2019-06-25  Tom Tromey  <tom@tromey.com>
5397
5398         * tui/tui.h (tui_is_window_visible): Return bool.
5399         * tui/tui.c (tui_is_window_visible): Return bool.
5400         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5401         (tui_make_visible, tui_make_invisible)
5402         (tui_win_info::make_visible)
5403         (tui_source_window_base::make_visible, make_all_visible)
5404         (tui_make_all_visible, tui_make_all_invisible): Update.
5405         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5406         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5407         bool.
5408         (struct tui_win_info, struct tui_source_window_base)
5409         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5410         * tui/tui-data.c (tui_init_generic_part): Update.
5411
5412 2019-06-25  Tom Tromey  <tom@tromey.com>
5413
5414         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5415         (tui_source_window_base::make_visible): New methods.
5416         (make_all_visible): Make method call.
5417         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5418         (struct tui_source_window_base, struct tui_cmd_window): Override
5419         make_visible.
5420         (tui_win_is_source_type): Don't declare.
5421         * tui/tui-data.c (tui_win_is_source_type): Remove.
5422
5423 2019-06-25  Tom Tromey  <tom@tromey.com>
5424
5425         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5426         NULL check.
5427
5428 2019-06-25  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5431         Inline constructor.  Add initializers for members.
5432         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5433         constructors; now inline in class.
5434
5435 2019-06-25  Tom Tromey  <tom@tromey.com>
5436
5437         * tui/tui-regs.c (tui_show_registers): Update.
5438         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5439         bool.
5440         * tui/tui-data.c (tui_data_window::clear_detail)
5441         (tui_data_window): Update.
5442
5443 2019-06-25  Tom Tromey  <tom@tromey.com>
5444
5445         * tui/tui-windata.c (tui_display_all_data)
5446         (tui_display_data_from_line, tui_display_data_from)
5447         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5448         Update.
5449         * tui/tui-regs.c (tui_last_regs_line_no)
5450         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5451         (tui_show_registers, tui_show_register_group)
5452         (tui_display_registers_from, tui_display_reg_element_at_line)
5453         (tui_display_registers_from_line, tui_check_register_values)
5454         (tui_reg_next, tui_reg_prev): Update.
5455         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5456         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5457         tui_data_window.
5458         (struct tui_win_info) <detail>: Remove.  Add new fields from
5459         tui_data_info.
5460         (TUI_DATA_WIN): Add cast.
5461         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5462         (~tui_data_window): Simplify.
5463
5464 2019-06-25  Tom Tromey  <tom@tromey.com>
5465
5466         * tui/tui-layout.c (show_source_disasm_command)
5467         (show_source_or_disasm_and_command): Update.
5468         * tui/tui-io.c (update_cmdwin_start_line)
5469         (tui_redisplay_readline): Update.
5470         * tui/tui-data.h (struct tui_command_info): Remove.
5471         (struct tui_win_info) <detail>: Remove command_info member.
5472         (struct tui_data_window) <start_line>: New member, from
5473         tui_command_info.
5474         (TUI_CMD_WIN): Add casts.
5475
5476 2019-06-25  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-winsource.c (tui_update_source_window)
5479         (tui_refill_source_window)
5480         (tui_source_window_base::do_scroll_horizontal)
5481         (tui_update_breakpoint_info, tui_set_exec_info_content)
5482         (tui_show_exec_info_content, tui_erase_exec_info_content)
5483         (tui_clear_exec_info_content): Update.
5484         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5485         Update.
5486         * tui/tui-win.c (make_invisible_and_set_new_height)
5487         (make_visible_with_new_height): Update.
5488         * tui/tui-source.c (tui_set_source_content)
5489         (tui_show_symtab_source): Update.
5490         * tui/tui-layout.c (extract_display_start_addr)
5491         (show_source_disasm_command, show_data)
5492         (make_source_or_disasm_window)
5493         (show_source_or_disasm_and_command): Update.
5494         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5495         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5496         "gdbarch".
5497         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5498         to tui_source_window_base.
5499         (struct tui_win_info) <detail>: Remove source_info member.
5500         (struct tui_source_window_base) <has_locator>: Inline.
5501         Move contents from tui_source_info; rename has_locator member to
5502         m_has_locator.
5503         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5504         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5505         header file.
5506         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5507         Simplify.
5508         (tui_free_all_source_wins_content): Cast to
5509         tui_source_window_base.
5510
5511 2019-06-25  Tom Tromey  <tom@tromey.com>
5512
5513         * tui/tui-win.c (make_invisible_and_set_new_height)
5514         (make_visible_with_new_height): Call has_locator method.
5515         * tui/tui-layout.c (show_source_disasm_command, show_data)
5516         (show_source_or_disasm_and_command): Update for bool change.
5517         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5518         (tui_win_info) <has_locator>: New method.
5519         (struct tui_source_window_base) <has_locator>: New method.
5520         (tui_win_has_locator): Don't declare.
5521         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5522         from tui_win_has_locator.
5523         (tui_source_window_base): Use false, not FALSE.
5524
5525 2019-06-25  Tom Tromey  <tom@tromey.com>
5526
5527         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5528         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5529         clear_detail method directly.
5530         (tui_clear_win_detail): Remove.
5531
5532 2019-06-25  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5535         "this", not TUI_DISASM_WIN.
5536
5537 2019-06-25  Tom Tromey  <tom@tromey.com>
5538
5539         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5540         declare.
5541         * tui/tui-winsource.c
5542         (tui_source_window_base::do_scroll_horizontal): Rename from
5543         tui_horizontal_source_scroll.
5544         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5545         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5546         from tui_vertical_data_scroll.
5547         * tui/tui-win.h (tui_scroll): Don't declare.
5548         * tui/tui-win.c (tui_win_info::forward_scroll)
5549         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5550         (tui_win_info::right_scroll): Rename and update.
5551         (tui_scroll_forward_command, tui_scroll_backward_command)
5552         (tui_scroll_left_command, tui_scroll_right_command): Update.
5553         (tui_scroll): Remove.
5554         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5555         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5556         from tui_vertical_source_scroll.
5557         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5558         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5559         from tui_vertical_disassem_scroll.
5560         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5561         do_scroll_horizontal>: New methods.
5562         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5563         Likewise.
5564         (struct tui_source_window_base): Add do_scroll_horizontal.
5565         (struct tui_source_window, struct tui_disasm_window): Add
5566         do_scroll_vertical.
5567         (struct tui_data_window, struct tui_cmd_window): Add
5568         do_scroll_horizontal and do_scroll_vertical.
5569         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5570
5571 2019-06-25  Tom Tromey  <tom@tromey.com>
5572
5573         * tui/tui-data.h (struct tui_source_window_base): New struct.
5574         (struct tui_source_window): Derive from tui_source_window_base.
5575         (struct tui_disasm_window): New struct.
5576         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5577         from tui_source_window::clear_detail.
5578         (tui_source_window_base): Rename from tui_source_window.
5579         (~tui_source_window_base): Rename from ~tui_source_window.
5580         (tui_alloc_win_info): Create a tui_disasm_window.
5581
5582 2019-06-25  Tom Tromey  <tom@tromey.com>
5583
5584         * tui/tui-data.h (struct tui_source_window)
5585         (struct tui_data_window): Declare destructors.
5586         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5587         destructors.
5588         (tui_win_info): Simplify.
5589
5590 2019-06-25  Tom Tromey  <tom@tromey.com>
5591
5592         * tui/tui-winsource.c (tui_display_main)
5593         (tui_update_source_windows_with_addr)
5594         (tui_update_all_breakpoint_info): Update.
5595         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5596         (new_height_ok, parse_scrolling_args): Update.
5597         * tui/tui-stack.c (tui_show_frame_info): Update.
5598         * tui/tui-data.h (struct tui_list): Remove.
5599         (tui_source_windows): Return a reference to a std::vector.
5600         * tui/tui-data.c (source_windows): Now a std::vector.
5601         (tui_source_windows): Change return type.
5602         (tui_clear_source_windows): Rewrite.
5603         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5604         (tui_free_all_source_wins_content): Rewrite.
5605
5606 2019-06-25  Tom Tromey  <tom@tromey.com>
5607
5608         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5609         (struct tui_data_window, struct tui_cmd_window): Declare
5610         clear_detail method.
5611         * tui/tui-data.c (tui_source_window::clear_detail)
5612         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5613         methods.
5614         (tui_clear_win_detail): Simplify.
5615
5616 2019-06-25  Tom Tromey  <tom@tromey.com>
5617
5618         * tui/tui-layout.c (make_source_window, make_disasm_window)
5619         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5620         Return the new window.
5621         (show_source_disasm_command, show_data)
5622         (show_source_or_disasm_and_command): Update.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5627         parameter.  Return the new window.
5628         (show_source_disasm_command): Update and remove NULL check.
5629         (show_source_or_disasm_and_command): Update.
5630
5631 2019-06-25  Tom Tromey  <tom@tromey.com>
5632
5633         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5634
5635 2019-06-25  Tom Tromey  <tom@tromey.com>
5636
5637         * tui/tui-data.h (struct tui_win_info): Make constructor
5638         protected.  Make destructor virtual.  Add initializers.
5639         (tui_source_window, tui_data_window, tui_cmd_window): New
5640         classes.
5641         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5642         constructor.  Add "type" parameter.
5643         (tui_source_window, tui_data_window, tui_cmd_window): New
5644         constructors.
5645         (tui_alloc_win_info): Instantiate the appropriate subclass.
5646
5647 2019-06-25  Tom Tromey  <tom@tromey.com>
5648
5649         * tui/tui-win.c (tui_resize_all): Use delete.
5650         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5651         destructor.
5652         (tui_free_window): Don't declare.
5653         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5654         Update.
5655
5656 2019-06-25  Tom Tromey  <tom@tromey.com>
5657
5658         * tui/tui-data.h (struct tui_win_info): Add constructor.
5659         * tui/tui-data.c (tui_alloc_win_info): Use new.
5660         (tui_free_window): Use delete.
5661
5662 2019-06-22  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5665         declare.
5666         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5667
5668 2019-06-22  Tom Tromey  <tom@tromey.com>
5669
5670         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5671         declare.
5672         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5673
5674 2019-06-22  Tom de Vries  <tdevries@suse.de>
5675
5676         * dwarf2read.c (create_addrmap_from_aranges)
5677         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5678         instead of '%zu'.
5679
5680 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5681
5682         * dwarf2read.h (dwarf2_section_info_def): Remove.
5683         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5684         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5685         std::vector<dwarf2_section_info>.
5686         (struct dwo_file) <~dwo_file>: Remove.
5687         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5688         types field.
5689         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5690         (dwarf2_read_debug_names): Likewise.
5691         (create_debug_types_hash_table): Change parameter type to
5692         array_view, adjust code accordingly.
5693         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5694         (partial_die_info::fixup): Likewise.
5695         (determine_prefix): Likewise.
5696         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5697
5698 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5699
5700         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5701         gdb_bfd_ref_ptr.
5702         <~dwo_file>: Remove call to gdb_bfd_unref.
5703         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5704         gdb_bfd_ref_ptr::get.
5705
5706 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5707
5708         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5709         type to htab_up.
5710         * dwarf2read.c (struct dwo_file): Initialize fields.
5711         <~dwo_file>: New.
5712         (free_dwo_file): Remove, move content to ~dwo_file.
5713         (struct dwo_file_deleter): Remove.
5714         (dwo_file_up>: Remove custom deleter.
5715         (free_dwo_files): Remove.
5716         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5717         dwo_files.
5718         (process_skeletonless_type_units): Call unique_ptr::get.
5719         (allocate_dwo_file_hash_table): Add deleter to created hash
5720         table.  Change return type to htab_up.
5721         (lookup_dwo_file_slot): Don't memset dwo_file, call
5722         unique_ptr::get.
5723         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5724         (create_dwo_unit_in_dwp_v2): Likewise.
5725         (open_and_init_dwo_file): Likewise.
5726         (free_dwo_file_from_slot): Remove.
5727
5728 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5729
5730         * dwarf2read.h (struct dwarf2_section_info) <readin,
5731         is_virtual>: Change type to bool.
5732         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5733         true instead of 1.
5734
5735 2019-06-19  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-data.h (tui_init_content_element): Don't declare.
5738
5739 2019-06-19  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-data.h (tui_init_win_info): Don't declare.
5742
5743 2019-06-19  Tom de Vries  <tdevries@suse.de>
5744
5745         * dwarf2read.h (abstract_to_concrete): Change type to
5746         std::unordered_map<sect_offset, std::vector<sect_offset>,
5747         gdb::hash_enum<sect_offset>>.
5748
5749 2019-06-19  Tom Tromey  <tromey@adacore.com>
5750
5751         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5752         EVAL_AVOID_SIDE_EFFECTS specially.
5753
5754 2019-06-19  Tom Tromey  <tromey@adacore.com>
5755
5756         * source-cache.c (highlighter): New global.
5757         (source_cache::get_source_lines): Create a highlighter on demand.
5758
5759 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5760
5761         * defs.h (deprecated_interactive_hook): Delete declaration.
5762         * interps.c (clear_interpreter_hooks): Remove use of
5763         deprecated_interactive_hook.
5764         * top.c (deprecated_interactive_hook): Delete definition.
5765         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5766
5767 2019-06-18  Tom de Vries  <tdevries@suse.de>
5768
5769         PR gdb/24515
5770         * dwarf2read.h (abstract_to_concrete): Change type from
5771         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5772         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5773         * dwarf2read.c (read_variable): Update.
5774         (dwarf2_fetch_die_loc_sect_off): Update.
5775
5776 2019-06-17  Tom de Vries  <tdevries@suse.de>
5777
5778         PR gdb/24617
5779         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5780         accessing parent[parent_len - 1].
5781
5782 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5783
5784         PR gdb/24364
5785         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5786         call dtrace_process_dof with NULL dof.
5787
5788 2019-06-16  Tom de Vries  <tdevries@suse.de>
5789
5790         PR gdb/24445
5791         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5792
5793 2019-06-16  Tom Tromey  <tom@tromey.com>
5794
5795         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5796         (make_all_visible): Use address of member.
5797
5798 2019-06-16  Tom Tromey  <tom@tromey.com>
5799
5800         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5801         (tui_free_window, free_content, free_content_elements): Remove
5802         unnecessary cast.
5803         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5804         cast.
5805         * tui/tui-regs.c (tui_show_register_group)
5806         (tui_display_registers_from, tui_display_reg_element_at_line):
5807         Remove unnecessary cast.
5808
5809 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5810
5811         * linux-nat.c (normal_mask): Delete.
5812         (_initialize_linux_nat): Don't initialise normal_mask.
5813
5814 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5815
5816         PR gdb/24445
5817         * dwarf-index-write.h (write_psymtabs_to_index): Add
5818         dwz_basename parameter.
5819         * dwarf-index-write.c (write_gdbindex): Move file writing to
5820         write_gdbindex_1.  Change return type void.
5821         (assert_file_size): Move up, remove filename parameter.
5822         (write_gdbindex_1): New function.
5823         (write_debug_names): Change return type to void, call
5824         assert_file_size.
5825         (struct index_wip_file): New struct.
5826         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5827         file logic to index_wip_file.  Write index for dwz file if
5828         needed.
5829         (save_gdb_index_command): Pass basename of dwz file, if present.
5830         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5831         build-id of dwz file, if present.
5832         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5833         (dwarf2_get_dwz_file): Likewise.
5834         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5835         (dwarf2_get_dwz_file): Likewise.
5836
5837 2019-06-16  Tom Tromey  <tom@tromey.com>
5838
5839         * coffread.c (process_coff_symbol): Use xstrdup.
5840         * value.c (create_internalvar): Use xstrdup.
5841
5842 2019-06-16  Tom Tromey  <tom@tromey.com>
5843
5844         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5845         * breakpoint.c (stopin_command, stopat_command)
5846         (until_break_command, decode_location_default): Remove unnecessary
5847         cast.
5848         * utils.c (subset_compare): Remove unnecessary cast.
5849         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5850         cast.
5851         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5852         cast.
5853         * infcmd.c (path_command): Remove unnecessary cast.
5854         * coffread.c (decode_type): Remove unnecessary cast.
5855         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5856         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5857         * tui/tui-stack.c (tui_show_locator_content)
5858         (tui_show_frame_info): Remove unnecessary cast.
5859         * tui/tui-win.c (tui_scroll_forward_command)
5860         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5861         (parse_scrolling_args): Remove unnecessary cast.
5862         * tui/tui-data.c (init_win_info, tui_del_window)
5863         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5864         (free_content_elements): Remove unnecessary cast.
5865         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5866         unnecessary cast.
5867         * tui/tui-source.c (tui_set_source_content)
5868         (tui_vertical_source_scroll): Remove unnecessary cast.
5869         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5870         cast.
5871         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5872         * tui/tui-regs.c (tui_display_registers_from)
5873         (tui_display_register): Remove unnecessary cast.
5874         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5875         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5876         (make_visible): Remove unnecessary cast.
5877         * tui/tui-winsource.c (tui_erase_source_content)
5878         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5879         unnecessary cast.
5880         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5881         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5882         * stabsread.c (read_type, read_array_type, read_range_type):
5883         Remove unnecessary cast.
5884         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5885         (parse_symbol, parse_type, upgrade_type, parse_external)
5886         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5887         unnecessary cast.
5888         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5889
5890 2019-06-16  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-data.c (tui_alloc_generic_win_info)
5893         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5894         checks.
5895
5896 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5897             Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * f-typeprint.c (f_print_type): Don't return early for not
5900         associated or not allocated types.
5901         (f_type_print_varspec_suffix): Add print_rank parameter and print
5902         ranks of array types in case they dangling.
5903         (f_type_print_base): Add print_rank parameter.
5904
5905 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * NEWS: Mention new MI commands.
5908         * break-catch-throw.c (enum exception_event_kind): Move to
5909         breakpoint.h.
5910         (print_mention_exception_catchpoint): Output text as a single
5911         message.
5912         (catch_exception_command_1): Rename to...
5913         (catch_exception_event): ...this, make non-static, update header
5914         command, and change some parameter types.
5915         (catch_catch_command): Update for changes to
5916         catch_exception_command_1.
5917         (catch_throw_command): Likewise.
5918         (catch_rethrow_command): Likewise.
5919         * breakpoint.c (enum exception_event_kind): Delete.
5920         * breakpoint.h (enum exception_event_kind): Moved here from
5921         break-catch-throw.c.
5922         (catch_exception_event): Declare.
5923         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5924         (mi_cmd_catch_throw): New function.
5925         (mi_cmd_catch_rethrow): New function.
5926         (mi_cmd_catch_catch): New function.
5927         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5928         'catch-catch' entries.
5929         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5930         (mi_cmd_catch_rethrow): Declare.
5931         (mi_cmd_catch_catch): Declare.
5932
5933 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * annotate.c (annotate_source_line): Change return type to void,
5936         update implementation to match.
5937         * annotate.h (annotate_source_line): Change return type to void,
5938         update header comment.
5939         * stack.c (print_frame_info): Don't change what frame information
5940         is printed based on whether annotations are on or not.
5941
5942 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5943
5944         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5945         (annotate_source): Make static.
5946         (annotate_source_line): Moved from source.c and renamed from
5947         identify_source_line.  Update the return type.
5948         * annotate.h (annotate_source): Delete declaration.
5949         (annotate_source_line): Declaration moved from source.h, and
5950         renamed from identify_source_line.  Return type updated.
5951         * source.c (identify_source_line): Moved to annotate.c and renamed
5952         to annotate_source_line.
5953         (info_line_command): Remove check of annotation_level.
5954         * source.h (identify_source_line): Move declaration to annotate.h
5955         and rename to annotate_source_line.
5956         * stack.c: Add 'annotate.h' include.
5957         (print_frame_info): Remove check of annotation_level before
5958         calling annotate_source_line.
5959
5960 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * source-cache.c (source_cache::get_plain_source_lines): Use
5963         open_source_file_with_line_charpos instead of just
5964         open_source_file, remove call to find_source_lines.
5965         (source_cache::get_source_lines): Likewise.
5966         * source.c (find_source_lines): Make static.
5967         (get_filename_and_charpos): Renamed into...
5968         (open_source_file_with_line_charpos): ..this along with changes to
5969         return a scoped_fd, and some other minor clean ups.
5970         (identify_source_line): Use open_source_file_with_line_charpos.
5971         (search_command_helper): Use open_source_file_with_line_charpos
5972         instead of just open_source_file, remove call to
5973         find_source_lines.
5974         * source.h (open_source_file_with_line_charpos): Declare new
5975         function.
5976         (find_source_lines): Delete declaration.
5977
5978 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5979
5980         * source.c (get_filename_and_charpos): Remove fullname
5981         parameter.
5982         (identify_source_line): Update call to get_filename_and_charpos.
5983
5984 2019-06-14  Tom Tromey  <tromey@adacore.com>
5985
5986         PR gdb/24502:
5987         * ui-style.h (skip_ansi_escape): Update comment.
5988         * ui-file.h (class no_terminal_escape_file): New class.
5989         * ui-file.c (no_terminal_escape_file::write)
5990         (no_terminal_escape_file::puts): New methods.
5991         * cli/cli-logging.c (handle_redirections): Use
5992         no_terminal_escape_file.
5993
5994 2019-06-14  Tom Tromey  <tromey@adacore.com>
5995
5996         * NEWS: Move convenience variable news above Python news.
5997
5998 2019-06-14  Tom Tromey  <tom@tromey.com>
5999
6000         * gnulib: Move directory to top-level.
6001         * configure.ac: Don't configure gnulib.
6002         * configure: Rebuild.
6003         * common/common-defs.h: Use new path to gnulib.
6004         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6005         (GNULIB_H): Remove.
6006         (INCGNU): Look in new gnulib location.
6007         (HFILES_NO_SRCDIR): Remove gnulib files.
6008         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6009         (generated_files): Remove GNULIB_H.
6010         ($(LIBGNU), all-lib): Remove targets.
6011         (distclean): Don't mention GNULIB_BUILDDIR.
6012         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6013
6014 2019-06-14  Tom Tromey  <tromey@adacore.com>
6015
6016         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6017         Warn if symbol file does not provide any symbols.
6018
6019 2019-06-14  Tom Tromey  <tromey@adacore.com>
6020
6021         * source.c (find_and_open_source): Respect basenames_may_differ.
6022
6023 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6024
6025         * annotate.c (annotate_breakpoints_invalid): Make use of
6026         scoped_restore_terminal_state.
6027         (annotate_frames_invalid): Likewise.
6028
6029 2019-06-14  Tom Tromey  <tromey@adacore.com>
6030
6031         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6032         allow assignment to an internalvar.
6033
6034 2019-06-14  Tom Tromey  <tromey@adacore.com>
6035
6036         * ada-lex.l: Allow "_" in attribute names.
6037
6038 2019-06-14  Tom Tromey  <tromey@adacore.com>
6039
6040         PR gdb/24653:
6041         * regcache.c (registers_changed): Don't call alloca.
6042         * top.c (execute_command): Don't call alloca.
6043
6044 2019-06-13  Pedro Alves  <palves@redhat.com>
6045
6046         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6047         'expression'.  When parsing an expression, error out if there's
6048         junk after "unlimited".
6049         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6050         (do_set_command): Adjust calls to is_unlimited_literal.
6051
6052 2019-06-13  Pedro Alves  <palves@redhat.com>
6053
6054         * compile/compile.c (make_compile_options_def_group): Add braces
6055         around array_view initializer.
6056         * thread.c (make_thread_apply_all_options_def_group)
6057         (make_thread_apply_all_options_def_group): Likewise.
6058
6059 2019-06-13  Pedro Alves  <palves@redhat.com>
6060
6061         * NEWS (New commands): Mention "maint test-options
6062         require-delimiter", "maint test-options unknown-is-error", "maint
6063         test-options unknown-is-operand" and "maint show
6064         test-options-completion-result".
6065         (New command options, command completion): New section.
6066         (Completion improvements): New section.
6067         Mention that you can abbreviate "unlimited".
6068
6069 2019-06-13  Pedro Alves  <palves@redhat.com>
6070
6071         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6072         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6073         * unittests/cli-utils-selftests.c (test_parse_flags)
6074         (test_parse_flags_qcs): Delete.
6075         (test_cli_utils): Don't call deleted functions.
6076
6077 2019-06-13  Pedro Alves  <palves@redhat.com>
6078
6079         * thread.c: Include "cli/cli-option.h".
6080         (tp_array_compar_ascending): Global.
6081         (tp_array_compar): Delete function.
6082         (tp_array_compar_ascending, tp_array_compar_descending): New
6083         functions.
6084         (ascending_option_def, qcs_flag_option_def)
6085         (thr_qcs_flags_option_defs)
6086         (make_thread_apply_all_options_def_group)
6087         (make_thread_apply_options_def_group): New.
6088         (thread_apply_all_command): Use gdb::option::process_options.
6089         (thread_apply_command_completer)
6090         (thread_apply_all_command_completer): New.
6091         (thread_apply_command): Use gdb::option::process_options.
6092         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6093         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6094         to generate help text of "thread apply".  Adjust "taas"'s help.
6095         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6096         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6097
6098 2019-06-13  Pedro Alves  <palves@redhat.com>
6099
6100         * thread.c (thread_apply_command): Check for invalid TID with
6101         isdigit instead of !isalpha.
6102
6103 2019-06-13  Pedro Alves  <palves@redhat.com>
6104
6105         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6106         (validate_flags_qcs): New.
6107         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6108         (validate_flags_qcs): Declare.
6109         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6110         (make_frame_apply_options_def_group): New.
6111         (frame_apply_command_count): Process options with
6112         gdb::option::process_options.
6113         (frame_apply_completer): New.
6114         (frame_apply_level_completer, frame_apply_all_completer)
6115         (frame_apply_completer): New.
6116         (_initialize_stack): Update help of "frame apply", "frame apply
6117         level", "frame apply all" and "faas" to mention supported options
6118         and install command completers.
6119         * stack.h (frame_apply_all_completer): Declare.
6120         * thread.c: Include "stack.h".
6121         (tfaas_command): Add "--".
6122         (_initialize_thread): Update help "tfaas" to mention supported
6123         options and install command completer.
6124
6125 2019-06-13  Pedro Alves  <palves@redhat.com>
6126
6127         * completer.c (complete_nested_command_line): New.
6128         (gdb_completion_word_break_characters_throw): Add assertion.
6129         * completer.h (complete_nested_command_line): Declare.
6130
6131 2019-06-13  Pedro Alves  <palves@redhat.com>
6132
6133         * stack.c (parse_backtrace_qualifiers): New.
6134         (backtrace_command): Use it.
6135         (backtrace_command_completer): Complete on qualifiers.
6136
6137 2019-06-13  Pedro Alves  <palves@redhat.com>
6138
6139         * frame.c: Include "cli/cli-option.h.
6140         (user_set_backtrace_options): New.
6141         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6142         Delete.
6143         (get_prev_frame): Adjust.
6144         (boolean_option_def, uinteger_option_def)
6145         (set_backtrace_option_defs): New.
6146         (_initialize_frame): Adjust and use
6147         gdb::option::add_setshow_cmds_for_options to install "set
6148         backtrace past-main" and "set backtrace past-entry".
6149         * frame.h: Include "cli/cli-option.h".
6150         (struct frame_print_options): Forward declare.
6151         (print_frame_arguments_all, print_frame_arguments_scalars)
6152         (print_frame_arguments_none): Declare.
6153         (print_entry_values): Delete declaration.
6154         (struct frame_print_options, user_frame_print_options): New.
6155         (struct set_backtrace_options): New.
6156         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6157         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6158         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6159         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6160         (list_args_or_locals): Add frame_print_options parameter.
6161         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6162         * python/py-framefilter.c (enumerate_args): Pass down
6163         USER_FRAME_PRINT_OPTIONS.
6164         * stack.c: Include "cli/cli-option.h".
6165         (print_frame_arguments_all, print_frame_arguments_scalars)
6166         (print_frame_arguments_none): Declare.
6167         (print_raw_frame_arguments, print_entry_values): Delete.
6168         (user_frame_print_options): New.
6169         (boolean_option_def, enum_option_def, frame_print_option_defs):
6170         New.
6171         (struct backtrace_cmd_options): New.
6172         (bt_flag_option_def): New.
6173         (backtrace_command_option_defs): New.
6174         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6175         (print_frame_arg, read_frame_arg, print_frame_args)
6176         (print_frame_info, print_frame): Add frame_print_options parameter
6177         and use it.
6178         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6179         (backtrace_command_1): Add frame_print_options and
6180         backtrace_cmd_options parameters and use them.
6181         (make_backtrace_options_def_group): New.
6182         (backtrace_command): Process command options with
6183         gdb::option::process_options.
6184         (backtrace_command_completer): New.
6185         (_initialize_stack): Extend "backtrace"'s help to mention
6186         supported options.  Install completer for "backtrace".
6187         Install some settings commands with add_setshow_cmds_for_options.
6188
6189 2019-06-13  Pedro Alves  <palves@redhat.com>
6190
6191         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6192         and that "set/show print raw frame-arguments" are now deprecated.
6193
6194         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6195         command.
6196         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6197         * stack.c (_initialize_stack): Install "set/show print
6198         raw-frame-arguments", and deprecate "set/show print raw
6199         frame-arguments".
6200         * valprint.c (_initialize_valprint): Deprecate "set/show print
6201         raw".
6202
6203 2019-06-13  Pedro Alves  <palves@redhat.com>
6204
6205         * compile/compile.c (struct compile_options): New.
6206         (compile_flag_option_def, compile_command_option_defs)
6207         (make_compile_options_def_group): New.
6208         (compile_file_command): Handle options with
6209         gdb::option::process_options.
6210         (compile_file_command_completer): New function.
6211         (compile_code_command): Handle options with
6212         gdb::option::process_options.
6213         (compile_code_command_completer): New function.
6214         (_initialize_compiler): Install completers for "compile code" and
6215         "compile file".  Mention available options in "compile code" and
6216         "compile code"'s help.
6217         * completer.c (advance_to_completion_word): New, factored out from
6218         ...
6219         (advance_to_expression_complete_word_point): ... this.
6220         (advance_to_filename_complete_word_point): New.
6221         * completer.h (advance_to_filename_complete_word_point): New
6222         declaration.
6223
6224 2019-06-13  Pedro Alves  <palves@redhat.com>
6225
6226         * compile/compile.c: Include "cli/cli-option.h".
6227         (compile_print_value): Scope data pointer is now a
6228         value_print_options pointer; adjust.
6229         (compile_print_command): Process options.  Scope data pointer is
6230         now a value_print_options pointer; adjust.
6231         (_initialize_compile): Update "compile print"'s help to include
6232         supported options.  Install a completer for "compile print".
6233         * cp-valprint.c (show_vtblprint, show_objectprint)
6234         (show_static_field_print): Delete.
6235         (_initialize_cp_valprint): Don't install "set print
6236         static-members", "set print vtbl", "set print object" here.
6237         * printcmd.c: Include "cli/cli-option.h" and
6238         "common/gdb_optional.h".
6239         (print_command_parse_format): Rework to fill in a
6240         value_print_options instead of a format_data.
6241         (print_value): Change parameter type from format_data pointer to
6242         value_print_options reference.  Adjust.
6243         (print_command_1): Process options.  Adjust to pass down a
6244         value_print_options.
6245         (print_command_completer): New.
6246         (_initialize_printcmd): Install print_command_completer as
6247         handle_brkchars completer for the "print" command.  Update
6248         "print"'s help to include supported options.
6249         * valprint.c: Include "cli/cli-option.h".
6250         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6251         here from cp-valprint.c.
6252         (boolean_option_def, uinteger_option_def)
6253         (value_print_option_defs, make_value_print_options_def_group):
6254         New.  Use gdb::option::add_setshow_cmds_for_options to install
6255         "set print elements", "set print null-stop", "set print repeats",
6256         "set print pretty", "set print union", "set print array", "set
6257         print address", "set print symbol", "set print array-indexes".
6258         * valprint.h: Include <string> and "cli/cli-option.h".
6259         (make_value_print_options_def_group): Declare.
6260         (print_value): Change parameter type from format_data pointer to
6261         value_print_options reference.
6262         (print_command_completer): Declare.
6263
6264 2019-06-13  Pedro Alves  <palves@redhat.com>
6265
6266         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6267         (COMMON_SFILES): Add maint-test-settings.c.
6268         * cli/cli-decode.c (boolean_enums): New global, factored out from
6269         ...
6270         (add_setshow_boolean_cmd): ... here.
6271         * cli/cli-decode.h (boolean_enums): Declare.
6272         * cli/cli-option.c: New file.
6273         * cli/cli-option.h: New file.
6274         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6275         factored out from ...
6276         (parse_cli_boolean_value(const char *)): ... this.
6277         (is_unlimited_literal): Change parameter type to pointer to
6278         pointer.  Adjust and advance ARG pointer.
6279         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6280         (parse_cli_var_enum): New, factored out from ...
6281         (do_set_command): ... this.  Adjust.
6282         * cli/cli-setshow.h (parse_cli_boolean_value)
6283         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6284         (parse_cli_var_enum): Declare.
6285         * cli/cli-utils.c: Include "cli/cli-option.h".
6286         (get_ulongest): New.
6287         * cli/cli-utils.h (get_ulongest): Declare.
6288         (check_for_argument): New overloads.
6289         * maint-test-options.c: New file.
6290
6291 2019-06-13  Pedro Alves  <palves@redhat.com>
6292
6293         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6294         parse a range if "-" is at the end of the string.
6295
6296 2019-06-13  Pedro Alves  <palves@redhat.com>
6297
6298         * cli/cli-setshow.c (parse_auto_binary_operation)
6299         (parse_cli_boolean_value): Don't allow "o".
6300
6301 2019-06-13  Pedro Alves  <palves@redhat.com>
6302
6303         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6304         * NEWS: Mention maint test-settings KIND.
6305         * maint-test-settings.c: New file.
6306
6307 2019-06-13  Pedro Alves  <palves@redhat.com>
6308
6309         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6310         completer.
6311         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6312         "set" completers.
6313
6314 2019-06-13  Pedro Alves  <palves@redhat.com>
6315
6316         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6317         after item.
6318
6319 2019-06-13  Pedro Alves  <palves@redhat.com>
6320
6321         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6322
6323 2019-06-13  Pedro Alves <palves@redhat.com>
6324
6325         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6326         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6327         call.
6328         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6329         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6330         calls.
6331         (check_for_argument): Skip spaces after argument.
6332
6333 2019-06-13  Pedro Alves  <palves@redhat.com>
6334
6335         * thread.c (thread_apply_command): Adjust TID parsing.
6336         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6337         detected before end of string.
6338         (tid_is_in_list): Error out if LIST is invalid.
6339
6340 2019-06-13  Pedro Alves  <palves@redhat.com>
6341
6342         * completer.c (complete_line_internal_1): Rewind completion word
6343         point.
6344         (completion_tracker::advance_custom_word_point_by): Change
6345         parameter type to int.
6346         * completer.h (completion_tracker::advance_custom_word_point_by):
6347         Likewise.
6348
6349 2019-06-13  Pedro Alves  <palves@redhat.com>
6350
6351         * completer.c (advance_to_completion_word): Handle delimiters.
6352
6353 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6354
6355         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6356
6357 2019-06-11  Tom Tromey  <tom@tromey.com>
6358
6359         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6360         (xmalloc_failed): Move to alloc.c.
6361         * alloc.c: New file.
6362         * Makefile.in (COMMON_SFILES): Add alloc.c.
6363
6364 2019-06-11  Tom Tromey  <tom@tromey.com>
6365
6366         * nat/linux-waitpid.c: Don't include server.h.
6367         (linux_debug): Remove.
6368         (my_waitpid): Update.
6369
6370 2019-06-11  Tom Tromey  <tromey@adacore.com>
6371
6372         * infcall.c (_initialize_infcall): Remove trailing newline from
6373         help.
6374         * user-regs.c (_initialize_user_regs): Remove trailing newline
6375         from help.
6376         * typeprint.c (_initialize_typeprint): Remove trailing newline
6377         from help.
6378         * reverse.c (_initialize_reverse): Remove trailing newlines from
6379         help.
6380         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6381         from help.
6382         * language.c (add_set_language_command): Remove trailing newline
6383         from help.
6384         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6385         help.
6386         * disasm.c (_initialize_disasm): Remove trailing newline from
6387         help.
6388         * top.c (init_main): Remove trailing newline from help.
6389         * interps.c (_initialize_interpreter): Remove trailing newline
6390         from help.
6391         * btrace.c (_initialize_btrace): Remove trailing newlines from
6392         help.
6393         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6394         from help.
6395         * python/python.c (_initialize_python): Remove trailing newline
6396         from help.
6397         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6398         help.
6399         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6400         from help.  Reformat some text.
6401         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6402         from help.
6403         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6404         newline from help.
6405
6406 2019-06-11  Tom Tromey  <tromey@adacore.com>
6407
6408         * darwin-nat.c (darwin_decode_exception_message)
6409         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6410
6411 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * valops.c (value_slice): Check for not allocated or not
6414         associated values.
6415
6416 2019-06-10  Tom de Vries  <tdevries@suse.de>
6417
6418         PR gdb/24618
6419         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6420         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6421         invalid.
6422
6423 2019-06-10  Tom de Vries  <tdevries@suse.de>
6424
6425         PR gdb/24611
6426         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6427         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6428
6429 2019-06-10  Tom de Vries  <tdevries@suse.de>
6430
6431         PR symtab/24545
6432         * symtab.c (struct demangled_name_entry): Add language field.
6433         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6434         static minimal symbol".  Set and use language field.
6435
6436 2019-06-10  Tom Tromey  <tromey@adacore.com>
6437
6438         * ada-lang.c (_initialize_ada_language): Update help text.
6439
6440 2019-06-10  Tom Tromey  <tromey@adacore.com>
6441
6442         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6443         with a newline.
6444         * guile/guile.c (handle_boot_error): Don't end warning with a
6445         newline.
6446         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6447         warning with a newline.
6448         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6449         newline.
6450         (s12z_frame_cache): Likewise.
6451         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6452         a newline.
6453         * solib-svr4.c (disable_probes_interface): Don't end warning with
6454         a newline.
6455         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6456         newline.
6457         * python/python.c (do_finish_initialization): Don't end warning
6458         with a newline.
6459
6460 2019-06-10  Tom Tromey  <tom@tromey.com>
6461
6462         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6463         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6464         gdbpy_enter.
6465
6466 2019-06-10  Tom Tromey  <tromey@adacore.com>
6467
6468         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6469         data.
6470         (elf_new_init): Don't call stabsread_new_init.
6471         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6472         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6473         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6474
6475 2019-06-10  Tom de Vries  <tdevries@suse.de>
6476
6477         PR symtab/16264
6478         PR symtab/24517
6479         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6480
6481 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6482
6483         * source.c (find_and_open_source): Also rewrite relative file
6484         names.
6485
6486 2019-04-26  Amos Bird  <amosbird@gmail.com>
6487
6488         * annotate.c (annotate_thread_exited): Add "thread-exited"
6489         annotation.
6490
6491 2019-06-06  Tom Tromey  <tromey@adacore.com>
6492
6493         * maint.h (class scoped_command_stats): Use
6494         DISABLE_COPY_AND_ASSIGN.
6495         <print_time>: New method.
6496         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6497         print_time.
6498         (scoped_command_stats::print_time): New method.
6499
6500 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6501
6502         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6503         instructions of lengths 6 or 8 bytes.
6504
6505 2019-06-04  Pedro Alves  <palves@redhat.com>
6506
6507         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6508
6509         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6510         * breakpoint.c (condition_completer): Likewise.
6511         * cli/cli-dump.c (scan_expression): Likewise.
6512         * common/filestuff.c (mkdir_recursive): Likewise.
6513         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6514         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6515         (gdb_abspath): Likewise.
6516         * compile/compile-cplus-types.c
6517         (compile_cplus_instance::decl_name): Likewise.
6518         * completer.c (complete_explicit_location):
6519         (signal_completer, reg_or_group_completer_1): Likewise.
6520         * cp-support.c (cp_remove_params_if_any): Likewise.
6521         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6522         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6523         * infcmd.c (strip_bg_char): Likewise.
6524         * linespec.c (copy_token_string): Likewise.
6525         * mi/mi-main.c (output_cores): Likewise.
6526         * psymtab.c (psymtab_search_name):
6527         * symfile.c (test_set_ext_lang_command): Likewise.
6528         * target.c (target_fileio_read_stralloc): Likewise.
6529         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6530         * value.c (complete_internalvar): Likewise.
6531
6532 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6533
6534         Add objfile property to gdb.Type.
6535         * NEWS: Mention Python API addition.
6536         * python/py-type.c (typy_get_objfile): New method.
6537
6538 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6539
6540         * NEWS: Mention the new set|show style [title|highlight].
6541         Mention changes to "show style", "help" and "apropos".
6542
6543 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6544
6545         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6546         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6547         instead of print_help_for_command.
6548         (print_doc_of_command): New function.
6549         (help_list): Add 'apropos -v word' suggestion.
6550         (print_help_for_command): Style the command name using title style.
6551         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6552         (_initialize_cli_cmds): Describe -v in apropos_command help.
6553
6554 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6555
6556         * cli/cli-style.h (cli_style_option): Add name in constructor,
6557         add m_name class member, add constructor with intensity,
6558         add name class function.
6559         (cli_style_option::add_setshow_commands): Remove name argument.
6560         (highlight_style, title_style): New styles.
6561         * cli/cli-style.c (do_show): New function that shows a style
6562         characteristic styling the style name with itself.
6563         (set_style_name): New function.
6564         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6565         Update all callers according to the changes in cli/cli-style.h.
6566         * utils.h (fputs_highlighted): New function.
6567         * utils.c (fputs_highlighted): Likewise.
6568
6569 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6570
6571         * NEWS: Mention new pipe command and new convenience variables.
6572
6573 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6574
6575         * cli/cli-cmds.c (pipe_command): New function.
6576         (_initialize_cli_cmds): Call add_com for pipe_command.
6577         Define | as an alias for pipe.
6578         (exit_status_set_internal_vars): New function.
6579         (shell_escape): Call exit_status_set_internal_vars.
6580         cli/cli-decode.c (find_command_name_length): Recognize | as
6581         a single character command.
6582
6583 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6584
6585         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6586         top.c (execute_command_to_ui_file): New function, mostly a copy
6587         of execute_command_to_string.
6588         (execute_command_to_string): Implement by calling
6589         execute_command_to_ui_file.
6590
6591 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6592
6593         * top.h (saved_command_line): Remove declaration.
6594         * top.c (previous_saved_command_line, previous_repeat_arguments):
6595         New variables.
6596         (saved_command_line): Make static, define together with other
6597         'repeat variables'.
6598         (dont_repeat): Clear repeat_arguments.
6599         (repeat_previous, get_saved_command_line, save_command_line):
6600         New functions.
6601         (gdb_init): Initialize saved_command_line
6602         and previous_saved_command_line.
6603         * main.c (captured_main_1): Remove saved_command_line initialization.
6604         * event-top.c (handle_line_of_input): Update to use
6605         the new 'repeat' related functions instead of direct access to
6606         saved_command_line.
6607         * command.h (repeat_previous, get_saved_command_line,
6608         save_command_line): New declarations.
6609         (dont_repeat): Add comment.
6610
6611 2019-05-30  Tom Tromey  <tromey@adacore.com>
6612
6613         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6614         Fix comment.
6615         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6616
6617 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6618
6619         PR cli/24587
6620         * completer.c (complete): Initialize variable word.
6621
6622 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6623
6624         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6625         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6626         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6627         'body' is NULL to the outter 'if', protecting the '!is_define'
6628         situation as well.
6629
6630 2019-05-29  Tom Tromey  <tromey@adacore.com>
6631
6632         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6633         (dwarf_unknown): New function.
6634         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6635         (dwarf_type_encoding_name): Use dwarf_unknown.
6636
6637 2019-05-29  Tom Tromey  <tromey@adacore.com>
6638
6639         PR c++/20020:
6640         * cp-valprint.c (cp_print_value_fields): Call
6641         cp_print_static_field inside "try".
6642
6643 2019-05-29  Tom Tromey  <tromey@adacore.com>
6644
6645         * inflow.c (struct terminal_info): Add default operator=.
6646         * configure: Rebuild.
6647         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6648         -Wdeprecated-copy-dtor, -Wredundant-move.
6649
6650 2019-05-29  Tom Tromey  <tromey@adacore.com>
6651
6652         * NEWS: Add entry.
6653         * infcmd.c (print_return_value_1): Handle finish_print
6654         option.
6655         (show_print_finish): New function.
6656         (_initialize_infcmd): Add "set/show print finish" commands.
6657         * valprint.c (user_print_options): Initialize new member.
6658         * valprint.h (struct value_print_options) <finish_print>: New
6659         member.
6660
6661 2019-05-28  Tom Tromey  <tromey@adacore.com>
6662
6663         * ada-lang.c (ada_remove_Xbn_suffix)
6664         (find_old_style_renaming_symbol)
6665         (parse_old_style_renaming): Remove.
6666         (ada_find_renaming_symbol): Don't call
6667         find_old_style_renaming_symbol.
6668         (ada_is_renaming_symbol): Rename from
6669         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6670         bool.  Now static.
6671         (ada_read_var_value): Update and simplify.
6672         * ada-exp.y (write_var_or_type): Remove old code.
6673
6674 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6675
6676         * event-top.c: Remove include comment.
6677         * inflow.c (class scoped_ignore_sigttou): Move from here...
6678         * inflow.h (class scoped_ignore_sigttou): ...to here.
6679         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6680         * top.c:  Remove include comment.
6681
6682 2019-05-27  Tom Tromey  <tom@tromey.com>
6683
6684         * NEWS: Fix typo.
6685
6686 2019-05-22  Tom Tromey  <tromey@adacore.com>
6687
6688         * target.c (target_follow_exec): Constify parameter.
6689         * target-delegates.c: Rebuild.
6690         * remote.c (remote_target::follow_exec): Constify parameter.
6691         * infrun.c (follow_exec): Constify parameter.
6692         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6693         (target_follow_exec): Likewise.
6694
6695 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6696
6697         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6698         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6699
6700 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6701
6702         * NEWS: Add debugredirect and testsuite sections.
6703
6704 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6705
6706         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6707         target descriptions using exclusively floating point register name
6708         aliases.
6709
6710 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6711
6712         PR gdb/18644:
6713         * f-lang.c (build_fortran_types): Handle the case where
6714         gdbarch_floatformat_for_type returns a nullptr.
6715
6716 2019-05-21  Tom de Vries  <tdevries@suse.de>
6717
6718         PR cli/24587
6719         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6720
6721 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6722
6723         PR gdb/18644:
6724         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6725         16-byte floats.
6726         * i386-tdep.c (i386_floatformat_for_type): Use
6727         floatformats_ia64_quad for the 16-byte floating point component
6728         within a fortran 32-byte complex number.
6729
6730 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6733         delete default constructor.
6734         (find_partial_die): Update to return const struct.
6735         (partial_die_parent_scope): Move variable declaration into scope
6736         of its use and change its type to auto.
6737         (guess_partial_die_structure_name): Likewise.
6738         (partial_die_info::fixup): Likewise.
6739
6740 2019-05-17  Tom Tromey  <tromey@adacore.com>
6741
6742         * source.c (find_and_open_source): Remove cast.
6743
6744 2019-05-17  Tom Tromey  <tromey@adacore.com>
6745
6746         * annotate.c (annotate_source): Make "filename" const.
6747         * annotate.h (annotate_source): Use const.
6748
6749 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6750
6751         * disasm.c (set_disassembler_options): Send errors to stderr.
6752
6753 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6754
6755         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6756         (cli_interp_base::set_logging): Check debug_redirect.
6757         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6758         * cli/cli-logging.c (debug_redirect): Add static variable.
6759         (pop_output_files): Add default param.
6760         (handle_redirections): Print debug setting.
6761         (show_logging_command): Likewise.
6762         (_initialize_cli_logging): Add debugredirect command.
6763         * interps.c (current_interp_set_logging): Add debug_redirect
6764         parameter.
6765         * interps.h (set_logging): Add debug_redirect parameter.
6766         (current_interp_set_logging): Likewise.
6767         * mi/mi-common.h: Likewise.
6768         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6769
6770 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6771             Tom Tromey  <tromey@adacore.com>
6772
6773         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6774         directly.
6775         * cli/cli-interp.h (make_logging_output): Remove declaration.
6776         * cli/cli-logging.c (make_logging_output): Remove function.
6777         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6778         directly.
6779         * ui-file.c (tee_file::tee_file): Remove bools.
6780         (tee_file::~tee_file): Remove deletes.
6781         * ui-file.h (tee_file): Remove bools.
6782
6783 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6784
6785         * mi/mi-cmds.h (mi_cmd_complete): New function.
6786         * mi/mi-main.c (mi_cmd_complete): Likewise.
6787         * mi/mi-cmds.c: Define new MI command -complete.
6788         * NEWS: Mention new -complete command.
6789
6790 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6791
6792         * completer.h (complete): New function.
6793         * completer.c (complete): Likewise.
6794         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6795         function defined in completer.h.
6796
6797 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6798
6799         * MAINTAINERS (Write After Approval): Add myself.
6800
6801 2019-05-17  Tom de Vries  <tdevries@suse.de>
6802
6803         PR gdb/24094
6804         * dwarf2read.c (struct cu_partial_die_info): New struct.
6805         (find_partial_die): Return cu_partial_die_info.
6806         (partial_die_parent_scope, guess_partial_die_structure_name)
6807         (partial_die_info::fixup): Handle new return type of find_partial_die.
6808
6809 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6810
6811         PR breakpoints/24541
6812         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6813         "std::string", simplifying the algorithm.
6814
6815 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6816
6817         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6818         (stap_static_probe_ops::get_probes): Likewise.
6819
6820 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6821
6822         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6823         '-')" and "else if".
6824         (stap_parse_single_operand): Join checks for
6825         "gdbarch_stap_parse_special_token_p" and
6826         "gdbarch_stap_parse_special_token" in the same "if" statement.
6827         Invert check when verifying for operation on register
6828         displacement.
6829
6830 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6831
6832         * stap-probe.c (stap_get_opcode): Update comment.
6833         (stap_get_expected_argument_type): Likewise.
6834         (handle_stap_probe): Likewise.
6835
6836 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6837
6838         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6839         return type to 'bool'.  Adjust comment.  Use 'bool' when
6840         appropriate.
6841         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6842         * stap-probe.c (stap_parse_argument_1): Likewise.
6843         (stap_is_operator): Likewise.
6844         (stap_is_generic_prefix): Likewise.
6845         (stap_is_register_prefix): Likewise.
6846         (stap_is_register_indirection_prefix): Likewise.
6847         (stap_is_integer_prefix): Likewise.
6848         (stap_generic_check_suffix): Likewise.
6849         (stap_check_integer_suffix): Likewise.
6850         (stap_check_register_suffix): Likewise.
6851         (stap_check_register_indirection_suffix): Likewise.
6852         (stap_parse_register_operand): Likewise.
6853         (stap_parse_single_operand): Likewise.
6854         (stap_parse_argument_1): Likewise.
6855         (stap_probe::get_argument_count): Likewise.
6856         (stap_is_operator): Likewise.
6857
6858 2019-05-16  Tom Tromey  <tromey@adacore.com>
6859
6860         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6861         keyword to foreach.
6862
6863 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6864
6865         * linux-thread-db.c (try_thread_db_load_1): Change return type
6866         to bool.
6867         (try_thread_db_load): Likewise.
6868         (try_thread_db_load_from_pdir_1): Likewise.
6869         (try_thread_db_load_from_pdir): Likewise.
6870         (try_thread_db_load_from_sdir): Likewise.
6871         (try_thread_db_load_from_dir): Likewise.
6872         (thread_db_load_search): Likewise.
6873         (has_libpthread): Likewise.
6874         (thread_db_load): Likewise.
6875
6876 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6877
6878         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6879         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6880         NULL, and complain/return if that's the case.
6881
6882 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6883
6884         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6885         (advance, posn, abstract_read_memory): New functions.
6886         [struct mem_read_abstraction]: New struct.
6887         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6888
6889 2019-05-14  Tom Tromey  <tromey@adacore.com>
6890
6891         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6892         value is not lval_memory.
6893
6894 2019-05-14  Tom Tromey  <tromey@adacore.com>
6895
6896         * solib.c (info_sharedlibrary_command): Style the file name.
6897
6898 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6899
6900         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6901         (aarch64_vnv_type): Likewise.
6902         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6903         * common/tdesc.c: Likewise.
6904         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6905         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6906         * features/aarch64-fpu.xml: Add ieee half view.
6907         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6908         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6909         * gdbtypes.h (struct builtin_type): Likewise.
6910         (struct objfile_type): Likewise.
6911
6912 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6913
6914         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6915         typo.
6916         * location.h (string_to_event_location): Likewise.
6917
6918 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6919
6920         GDB 8.3 released.
6921
6922 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6923
6924         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6925         New variable declaration.
6926         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6927         New variable.
6928         (print_one_breakpoint): Use ui_out::test_flags and new global
6929         variable to compute use_fixed_output.
6930         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6931         Remove.
6932         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6933         (mi_multi_location_breakpoint_output_fixed): Remove.
6934         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6935         new variable.
6936         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6937         fix_multi_location_breakpoint_output flag if version >= 3.
6938         * ui-out.h (enum ui_out_flag)
6939         <fix_multi_location_breakpoint_output>: New enumerator.
6940
6941 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6942
6943         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6944
6945 2019-05-10  Tom Tromey  <tromey@adacore.com>
6946
6947         * ada-lang.c (catch_ada_completer): New function.
6948         (_initialize_ada_language): Use it.
6949
6950 2019-05-10  Tom Tromey  <tromey@adacore.com>
6951
6952         * thread.c (print_thread_info): Make "requested_threads" const.
6953         * gdbthread.h (print_thread_info): Make "requested_threads"
6954         const.
6955         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6956         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6957
6958 2019-05-08  Tom Tromey  <tom@tromey.com>
6959
6960         * gdbtypes.c (objfile_type_data): Change type.
6961         (objfile_type, _initialize_gdbtypes): Update.
6962
6963 2019-05-08  Tom Tromey  <tom@tromey.com>
6964
6965         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6966         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6967         (_initialize_dwarf2_frame): Update.
6968
6969 2019-05-08  Tom Tromey  <tom@tromey.com>
6970
6971         * objc-lang.c (objc_objfile_data): Change type.
6972         (find_methods): Update.
6973         (_initialize_objc_lang): Remove.
6974
6975 2019-05-08  Tom Tromey  <tom@tromey.com>
6976
6977         * stabsread.c (rs6000_builtin_type_data): Change type.
6978         (rs6000_builtin_type, _initialize_stabsread): Update.
6979
6980 2019-05-08  Tom Tromey  <tom@tromey.com>
6981
6982         * mips-tdep.c (mips_pdr_data): Remove.
6983         (_initialize_mips_tdep): Update.
6984
6985 2019-05-08  Tom Tromey  <tom@tromey.com>
6986
6987         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6988         (hppa_init_objfile_priv_data, read_unwind_info)
6989         (find_unwind_entry, _initialize_hppa_tdep): Update.
6990
6991 2019-05-08  Tom Tromey  <tom@tromey.com>
6992
6993         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6994         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6995         on obstack.
6996         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6997
6998 2019-05-08  Tom Tromey  <tom@tromey.com>
6999
7000         * mdebugread.c (basic_type_data): Change type.
7001         (basic_type, _initialize_mdebugread): Update.
7002
7003 2019-05-08  Tom Tromey  <tom@tromey.com>
7004
7005         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7006
7007 2019-05-08  Tom Tromey  <tom@tromey.com>
7008
7009         * nto-tdep.c (nto_inferior_data_reg): Change type.
7010         (nto_inferior_data): Update.
7011         (nto_inferior_data_cleanup, nto_new_inferior_data)
7012         (_initialize_nto_tdep): Remove.
7013         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7014
7015 2019-05-08  Tom Tromey  <tom@tromey.com>
7016
7017         * ada-lang.c (struct ada_inferior_data): Add initializers.
7018         (ada_inferior_data): Change type.
7019         (ada_inferior_data_cleanup): Remove.
7020         (get_ada_inferior_data, ada_inferior_exit)
7021         (struct ada_pspace_data): Add initializers, destructor.
7022         (ada_pspace_data_handle): Change type.
7023         (get_ada_pspace_data): Update.
7024         (ada_pspace_data_cleanup): Remove.
7025
7026 2019-05-08  Tom Tromey  <tom@tromey.com>
7027
7028         * coffread.c (struct coff_symfile_info): Add initializers.
7029         (coff_objfile_data_key): Move lower.  Change type.
7030         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7031         Update.
7032         (coff_free_info): Remove.
7033
7034 2019-05-08  Tom Tromey  <tom@tromey.com>
7035
7036         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7037         (fbsd_pspace_data_handle): Move lower.  Change type.
7038         (get_fbsd_pspace_data): Update.
7039         (fbsd_pspace_data_cleanup): Remove.
7040         (_initialize_fbsd_tdep): Update.
7041
7042 2019-05-08  Tom Tromey  <tom@tromey.com>
7043
7044         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7045         (get_ada_tasks_pspace_data): Update.
7046         (ada_tasks_pspace_data_cleanup): Remove.
7047         (_initialize_tasks): Update.
7048         (ada_tasks_inferior_data_handle): Change type.
7049         (get_ada_tasks_inferior_data): Update.
7050         (ada_tasks_inferior_data_cleanup): Remove.
7051         (struct ada_tasks_pspace_data): Add initializers.
7052
7053 2019-05-08  Tom Tromey  <tom@tromey.com>
7054
7055         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7056         * symfile-debug.c (debug_sym_get_probes): Change type.
7057         * stap-probe.c (handle_stap_probe):
7058         (stap_static_probe_ops::get_probes): Change type.
7059         * probe.h (class static_probe_ops) <get_probes>: Change type.
7060         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7061         (parse_probes_in_pspace): Update.
7062         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7063         Update.
7064         (any_static_probe_ops::get_probes): Change type.
7065         * elfread.c (elfread_data): New typedef.
7066         (probe_key): Change type.
7067         (elf_get_probes): Likewise.  Update.
7068         (probe_key_free): Remove.
7069         (_initialize_elfread): Update.
7070         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7071         Change type.
7072         (dtrace_process_dof_probe, dtrace_process_dof)
7073         (dtrace_static_probe_ops::get_probe): Change type.
7074
7075 2019-05-08  Tom Tromey  <tom@tromey.com>
7076
7077         * xcoffread.c (struct xcoff_symfile_info): Rename from
7078         coff_symfile_info.  Add initializers.
7079         (xcoff_objfile_data_key): Move lower.  Change type.
7080         (XCOFF_DATA): Rewrite.
7081         (xcoff_free_info): Remove.
7082         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7083         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7084         (xcoff_initial_scan): Update.
7085
7086 2019-05-08  Tom Tromey  <tom@tromey.com>
7087
7088         * solib-svr4.c (struct svr4_info): Add initializers and
7089         destructor.
7090         <probes_table>: Now an htab_up.
7091         (solib_svr4_pspace_data): Change type.
7092         (free_probes_table): Simplify.
7093         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7094         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7095         (probes_table_remove_objfile_probes, register_solib_event_probe)
7096         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7097         (_initialize_svr4_solib): Update.
7098
7099 2019-05-08  Tom Tromey  <tom@tromey.com>
7100
7101         * remote.c (remote_pspace_data): Change type.
7102         (remote_pspace_data_cleanup): Remove.
7103         (get_remote_exec_file, set_pspace_remote_exec_file)
7104         (_initialize_remote): Update.
7105
7106 2019-05-08  Tom Tromey  <tom@tromey.com>
7107
7108         * breakpoint.c (breakpoint_objfile_key): Change type.
7109         (get_breakpoint_objfile_data): Update.
7110         (free_breakpoint_objfile_data): Remove.
7111         (_initialize_breakpoint): Update.
7112
7113 2019-05-08  Tom Tromey  <tom@tromey.com>
7114
7115         * linux-tdep.c (struct linux_info): Add initializers.
7116         (linux_inferior_data): Move.  Change type.
7117         (invalidate_linux_cache_inf): Update.
7118         (linux_inferior_data_cleanup): Remove.
7119         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7120
7121 2019-05-08  Tom Tromey  <tom@tromey.com>
7122
7123         * auxv.c (auxv_inferior_data): Move.  Change type.
7124         (auxv_inferior_data_cleanup): Remove.
7125         (invalidate_auxv_cache_inf): Rewrite.
7126         (get_auxv_inferior_data, _initialize_auxv): Update.
7127
7128 2019-05-08  Tom Tromey  <tom@tromey.com>
7129
7130         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7131         (symfile_debug_objfile_data_key): Change type.
7132         (symfile_debug_installed, debug_qf_has_symbols)
7133         (debug_qf_find_last_source_symtab)
7134         (debug_qf_forget_cached_source_info)
7135         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7136         (debug_qf_print_stats, debug_qf_dump)
7137         (debug_qf_expand_symtabs_for_function)
7138         (debug_qf_expand_all_symtabs)
7139         (debug_qf_expand_symtabs_with_fullname)
7140         (debug_qf_map_matching_symbols)
7141         (debug_qf_expand_symtabs_matching)
7142         (debug_qf_find_pc_sect_compunit_symtab)
7143         (debug_qf_map_symbol_filenames)
7144         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7145         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7146         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7147         (debug_sym_read_linetable, debug_sym_relocate): Update.
7148         (symfile_debug_free_objfile): Remove.
7149         (install_symfile_debug_logging, _initialize_symfile_debug):
7150         Update.
7151
7152 2019-05-08  Tom Tromey  <tom@tromey.com>
7153
7154         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7155         allocate_on_obstack.
7156         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7157         (get_dwarf2_per_objfile): Update.
7158         (set_dwarf2_per_objfile): Remove.
7159         (dwarf2_has_info, dwarf2_get_section_info): Update.
7160         (dwarf2_free_objfile): Remove.
7161         (_initialize_dwarf2_read): Update.
7162
7163 2019-05-08  Tom Tromey  <tom@tromey.com>
7164
7165         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7166         initializers.
7167         <unsupported_script_warning_printed,
7168         script_not_found_warning_printed>: Now bool.
7169         (auto_load_pspace_data): Change type.
7170         (~auto_load_pspace_info): Rename from
7171         auto_load_pspace_data_cleanup.
7172         (get_auto_load_pspace_data, init_loaded_scripts_info)
7173         (clear_section_scripts, maybe_print_unsupported_script_warning)
7174         (maybe_print_script_not_found_warning, _initialize_auto_load):
7175         Update.
7176
7177 2019-05-08  Tom Tromey  <tom@tromey.com>
7178
7179         * objfiles.c (objfile_pspace_info): Add destructor and
7180         initializers.
7181         (objfiles_pspace_data): Change type.
7182         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7183         (get_objfile_pspace_data): Update.
7184         (objfiles_bfd_data): Change type.
7185         (get_objfile_bfd_data): Update.
7186         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7187
7188 2019-05-08  Tom Tromey  <tom@tromey.com>
7189
7190         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7191         Change type.
7192         (get_catch_syscall_inferior_data): Update.
7193         (catch_syscall_inferior_data_cleanup): Remove.
7194         (_initialize_break_catch_syscall): Update.
7195
7196 2019-05-08  Tom Tromey  <tom@tromey.com>
7197
7198         * inflow.c (struct terminal_info): Add destructor and
7199         initializers.
7200         (inflow_inferior_data): Change type.
7201         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7202         (get_inflow_inferior_data, inflow_inferior_exit)
7203         (swap_terminal_info, _initialize_inflow): Update.
7204
7205 2019-05-08  Tom Tromey  <tom@tromey.com>
7206
7207         * target-dcache.c (target_dcache_cleanup): Remove.
7208         (target_dcache_aspace_key): Change type.
7209         (target_dcache_init_p, target_dcache_invalidate)
7210         (target_dcache_get, target_dcache_get_or_init)
7211         (_initialize_target_dcache): Update.
7212         * dcache.h (struct dcache_deleter): New.
7213
7214 2019-05-08  Tom Tromey  <tom@tromey.com>
7215
7216         * symtab.c (struct symbol_cache): Add destructor and
7217         initializers.
7218         (symbol_cache_key): Move.  Change type.
7219         (make_symbol_cache, free_symbol_cache): Remove.
7220         (get_symbol_cache): Update.
7221         (symbol_cache_cleanup): Remove.
7222         (ALL_PSPACES, symbol_cache_flush)
7223         (maintenance_print_symbol_cache)
7224         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7225         Update.
7226
7227 2019-05-08  Tom Tromey  <tom@tromey.com>
7228
7229         * symtab.c (struct main_info): Add destructor and initializers.
7230         (main_progspace_key): Move.  Change type.
7231         (get_main_info): Update.
7232         (main_info_cleanup): Remove.
7233         (_initialize_symtab): Update.
7234
7235 2019-05-08  Tom Tromey  <tom@tromey.com>
7236
7237         * registry.h (DECLARE_REGISTRY): Define the _key class.
7238
7239 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7240
7241         * NEWS: Merge two 'New commands' sections.
7242
7243 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7244
7245         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7246         parameter and use Ada language definition instead.
7247         (ada_val_print_ptr): Remove unused language parameter.
7248         (ada_val_print_num): Remove language parameter and use Ada language
7249         definition instead.
7250         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7251         parameter.
7252         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7253         parameter and use Ada language definition instead.
7254         (ada_val_print_1): Update all ada_val_print_xxx calls.
7255         Remove language parameter.
7256         (ada_val_print): Update ada_val_print_1 call.
7257
7258 2019-05-08  Tom Tromey  <tromey@adacore.com>
7259
7260         * remote.c (remote_hw_watchpoint_limit)
7261         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7262         Now static.
7263
7264 2019-05-08  Tom Tromey  <tromey@adacore.com>
7265
7266         * maint.c (_initialize_maint_cmds): Move initialization code to
7267         remote.c.
7268         (watchdog, show_watchdog): Move to remote.c.
7269         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7270         "watchdog" static.
7271         (_initialize_remote): Move initialization code from maint.c.
7272         * defs.h (watchdog): Don't declare.
7273
7274 2019-05-08  Tom Tromey  <tromey@adacore.com>
7275
7276         * tui/tui-interp.c: Include main.h.
7277         * interps.c: Include main.h.
7278         * main.h (interpreter_p): Declare.
7279         * defs.h (interpreter_p): Don't declare.
7280
7281 2019-05-08  Tom Tromey  <tromey@adacore.com>
7282
7283         * dwarf2loc.c: Include dwarf2read.h.
7284         * defs.h (read_unsigned_leb128): Don't declare.
7285         * dwarf2read.h (read_unsigned_leb128): Declare.
7286
7287 2019-05-08  Tom Tromey  <tromey@adacore.com>
7288
7289         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7290         method.
7291
7292 2019-05-08  Tom Tromey  <tromey@adacore.com>
7293
7294         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7295         when no wrap column is set.
7296
7297 2019-05-08  Tom Tromey  <tromey@adacore.com>
7298
7299         * c-lang.c (c_get_string): Handle non-C-style arrays.
7300
7301 2019-05-08  Tom Tromey  <tromey@adacore.com>
7302
7303         * typeprint.c (print_offset_data::update): Print the bit offset,
7304         not the number of bits remaining.
7305
7306 2019-05-08  Tom Tromey  <tromey@adacore.com>
7307
7308         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7309         padding at end of comment.
7310
7311 2019-05-08  Tom Tromey  <tromey@adacore.com>
7312
7313         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7314         Compare main types.
7315
7316 2019-05-06  Tom Tromey  <tom@tromey.com>
7317
7318         * common/scoped_mmap.c: Include common-defs.h.
7319         * common/scoped_mmap.h: Don't include config.h.
7320
7321 2019-05-04  Tom Tromey  <tom@tromey.com>
7322
7323         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7324         (struct aarch64_call_info): Add initializers.
7325         <si>: Now a std::vector.
7326         (pass_on_stack, aarch64_push_dummy_call): Update.
7327
7328 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7329             Tom Tromey  <tom@tromey.com>
7330
7331         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7332         (ppc_threads): Now a std::vector.  Now static.
7333         (hwdebug_find_thread_points_by_tid)
7334         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7335         Update.
7336
7337 2019-05-04  Tom Tromey  <tom@tromey.com>
7338
7339         * arc-tdep.c (arc_tdesc_init): Return bool.
7340
7341 2019-05-04  Tom Tromey  <tom@tromey.com>
7342
7343         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7344         Use gdb_assert_not_reached.
7345
7346 2019-05-04  Tom Tromey  <tom@tromey.com>
7347
7348         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7349         "false".
7350
7351 2019-05-04  Tom Tromey  <tom@tromey.com>
7352
7353         * arc-tdep.c (arc_tdesc_init): Use bool.
7354
7355 2019-05-04  Tom Tromey  <tom@tromey.com>
7356
7357         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7358
7359 2019-05-04  Tom Tromey  <tom@tromey.com>
7360
7361         * cli/cli-cmds.c (valid_command_p): Return bool.
7362
7363 2019-05-04  Tom Tromey  <tom@tromey.com>
7364
7365         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7366         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7367
7368 2019-05-04  Raul Tambre  <raul@tambre.ee>
7369
7370         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7371         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7372         operator for comparison.
7373
7374 2019-05-04  Tom Tromey  <tom@tromey.com>
7375
7376         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7377         (lookup_partial_symbol, print_partial_symbols)
7378         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7379         (psymbol_compare): Update.
7380         (add_psymbol_to_bcache): Clear the entire psymbol.
7381         (maintenance_check_psymtabs): Update.
7382         * psympriv.h (struct partial_symbol): Don't derive from
7383         general_symbol_info.
7384         <obj_section, unrelocated_address, address,
7385         set_unrelocated_address>: Update.
7386         <ginfo>: New member.
7387         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7388         (debug_names::write_psymbols): Update.
7389
7390 2019-05-04  Tom de Vries  <tdevries@suse.de>
7391
7392         * contrib/cc-with-tweaks.sh: Support -n arg.
7393
7394 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7395
7396         * corelow.c (core_target::detach): Ensure frame cache and
7397         register caches are cleared.
7398         inferior.c (exit_inferior_1): Likewise.
7399
7400 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7401             Tom Tromey  <tom@tromey.com>
7402
7403         * dictionary.c (collate_pending_symbols_by_language): Remove
7404         "struct" from foreach.
7405         * symtab.c (lookup_global_symbol_from_objfile)
7406         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7407         foreach.
7408         * ser-tcp.c (net_open): Remove "struct" from foreach.
7409         * objfiles.c (objfile_relocate, objfile_rebase)
7410         (objfile_has_symbols): Remove "struct" from foreach.
7411         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7412         from foreach.
7413         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7414         foreach.
7415         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7416         "struct" from foreach.
7417         * ada-lang.c (create_excep_cond_exprs)
7418         (ada_exception_catchpoint_cond_string): Remove "struct" from
7419         foreach.
7420
7421 2019-05-03  Tom Tromey  <tromey@adacore.com>
7422
7423         * ada-exp.y (convert_char_literal): Check suffix of each
7424         enumerator.
7425
7426 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7427
7428         PR ada/21406:
7429         * ada-exp.y (yywrap): Don't define.
7430         * ada-lex.l (%option): Add noyywrap
7431         (yywrap): Remove.
7432
7433 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7434
7435         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7436         _WIN32_WINNT to the XP level, unless already defined to a higher
7437         level.
7438
7439         * unittests/parse-connection-spec-selftests.c:
7440         * ser-tcp.c:
7441         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7442         override.
7443
7444         * symfile.c (find_separate_debug_file): Remove colon from the
7445         drive spec of DOS/Windows file names of the target, so that the
7446         file name produced from DEBUGDIR and the target's directory will
7447         be valid on DOS/Windows systems.
7448
7449 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7450
7451         * rust-lang.c (val_print_struct): Handle printing structures
7452         containing strings.
7453
7454 2019-05-02  Tom Tromey  <tromey@adacore.com>
7455
7456         * valarith.c (_initialize_valarith): Remove.
7457
7458 2019-05-01  Tom Tromey  <tromey@adacore.com>
7459
7460         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7461         bitfields.
7462
7463 2019-05-01  Tom Tromey  <tromey@adacore.com>
7464
7465         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7466         for big-endian copies.
7467
7468 2019-04-30  Ali Tamur  <tamur@google.com>
7469         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7470         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7471         (read_3_bytes): New function.
7472
7473 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7474
7475         * windows-nat.c (main_thread_id): Delete.
7476         (handle_output_debug_string): Replace main_thread_id by
7477         current_event.dwThreadId.
7478         (fake_create_process): Likewise.
7479         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7480         Do not set main_thread_id.
7481         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7482         current_event.dwThreadId.
7483         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7484
7485 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7486
7487         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7488         Use current_event.dwThreadId instead of main_thread_id.
7489
7490 2019-04-30  Tom Tromey  <tromey@adacore.com>
7491
7492         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7493         (create_excep_cond_exprs): Iterate over program spaces.
7494         (ada_exception_catchpoint_cond_string): Examine all minimal
7495         symbols for exception types.
7496
7497 2019-04-30  Tom Tromey  <tromey@adacore.com>
7498
7499         PR c++/24470:
7500         * dwarf2read.c (process_structure_scope): Handle case where type
7501         has template parameters but no symbol was created.
7502
7503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7504             Chris January  <chris.january@arm.com>
7505
7506         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7507         qualifier.
7508         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7509
7510 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7511
7512         * f-typeprint.c (f_print_type): Update rules for printing
7513         whitespace.
7514         (f_type_print_varspec_suffix): Likewise.
7515
7516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7517             Chris January  <chris.january@arm.com>
7518
7519         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7520         function arguments.
7521
7522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * f-lang.c (build_fortran_types): Change name of void type to
7525         lower case.
7526         * f-typeprint.c (f_type_print_base): Print the name of the void
7527         type, rather than a fixed string.
7528         * f-valprint.c (f_decorations): Use lower case void string.
7529
7530 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7531             Chris January  <chris.january@arm.com>
7532
7533         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7534         types for Fortran.
7535
7536 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7537             Chris January  <chris.january@arm.com>
7538             David Lecomber  <david.lecomber@arm.com>
7539
7540         * f-exp.y (BINOP_INTRINSIC): New token.
7541         (exp): New parser rule handling BINOP_INTRINSIC.
7542         (f77_keywords): Add new builtin procedures.
7543         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7544         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7545         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7546         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7547         (print_unop_subexp_f): New function.
7548         (print_binop_subexp_f): New function.
7549         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7550         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7551         (dump_subexp_body_f): Likewise.
7552         (operator_check_f): Likewise.
7553         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7554         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7555
7556 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7557
7558         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7559         UNOP_KIND.
7560         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7561         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7562         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7563         (operator_length_f): New fuction.
7564         (print_subexp_f): New function.
7565         (op_name_f): New function.
7566         (dump_subexp_body_f): New function.
7567         (operator_check_f): New function.
7568         (exp_descriptor_f): Replace standard expression handling functions
7569         with new functions.
7570         * gdb/fortran-operator.def: New file.
7571         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7572         * gdb/std-operator.def: Remove UNOP_KIND.
7573
7574 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7575
7576         * std-operator.def: Remove unbalanced, stray double quote
7577         character.
7578
7579 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7580             Chris January  <chris.january@arm.com>
7581             Daniel Everett  <daniel.everett@arm.com>
7582             Nick Forrington  <nick.forrington@arm.com>
7583             Richard Bunt  <richard.bunt@arm.com>
7584
7585         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7586         of depth when printing anonymous structs or unions.
7587         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7588         Don't print either the top-level value, or the children if the
7589         max-depth is exceeded.
7590         (ppscm_print_children): When printing the key of a map, allow one
7591         extra level of depth.
7592         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7593         print either the top-level value, or the children if the max-depth
7594         is exceeded.
7595         (print_children): When printing the key of a map, allow one extra
7596         level of depth.
7597         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7598         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7599         (user_print_options): Initialise max_depth field.
7600         (val_print_scalar_or_string_type_p): New function.
7601         (val_print): Check to see if the max depth has been reached.
7602         (val_print_check_max_depth): Define new function.
7603         (show_print_max_depth): New function.
7604         (_initialize_valprint): Add 'print max-depth' option.
7605         * valprint.h (struct value_print_options) <max_depth>: New field.
7606         (val_print_check_max_depth): Declare new function.
7607         * NEWS: Document new feature.
7608
7609 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * ada-lang.c (ada_language_defn): Initialise new field.
7612         * c-lang.c (c_is_string_type_p): New function.
7613         (c_language_defn): Initialise new field.
7614         (cplus_language_defn): Initialise new field.
7615         (asm_language_defn): Initialise new field.
7616         (minimal_language_defn): Initialise new field.
7617         * c-lang.h (c_is_string_type_p): Declare new function.
7618         * d-lang.c (d_language_defn): Initialise new field.
7619         * f-lang.c (f_is_string_type_p): New function.
7620         (f_language_defn): Initialise new field.
7621         * go-lang.c (go_is_string_type_p): New function.
7622         (go_language_defn): Initialise new field.
7623         * language.c (default_is_string_type_p): New function.
7624         (unknown_language_defn): Initialise new field.
7625         (auto_language_defn): Initialise new field.
7626         * language.h (struct language_defn) <la_is_string_type_p>: New
7627         member variable.
7628         (default_is_string_type_p): Declare new function.
7629         * m2-lang.c (m2_language_defn): Initialise new field.
7630         * objc-lang.c (objc_language_defn): Initialise new field.
7631         * opencl-lang.c (opencl_language_defn): Initialise new field.
7632         * p-lang.c (pascal_is_string_type_p): New function.
7633         (pascal_language_defn): Initialise new field.
7634         * rust-lang.c (rust_is_string_type_p): New function.
7635         (rust_language_defn): Initialise new field.
7636
7637 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7638
7639         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7640         New field.
7641         * ada-lang.c (ada_language_defn): Initialise new field.
7642         * c-lang.c (c_language_defn): Likewise.
7643         (cplus_language_defn): Likewise.
7644         (asm_language_defn): Likewise.
7645         (minimal_language_defn): Likewise.
7646         * d-lang.c (d_language_defn): Likewise.
7647         * f-lang.c (f_language_defn): Likewise.
7648         * go-lang.c (go_language_defn): Likewise.
7649         * language.c (unknown_language_defn): Likewise.
7650         (auto_language_defn): Likewise.
7651         * m2-lang.c (m2_language_defn): Likewise.
7652         * objc-lang.c (objc_language_defn): Likewise.
7653         * opencl-lang.c (opencl_language_defn): Likewise.
7654         * p-lang.c (pascal_language_defn): Likewise.
7655         * rust-lang.c (rust_language_defn): Likewise.
7656
7657 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7658
7659         * ada-lang.c (ada_is_character_type): Change return type to bool.
7660         (ada_is_string_type): Likewise.
7661         * ada-lang.h (ada_is_character_type): Update declaration
7662         (ada_is_string_type): Likewise.
7663
7664 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7665
7666         Support style in 'frame|thread apply'
7667
7668         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7669         * record.c (record_start, record_stop): Update callers of
7670         execute_command_to_string with false.
7671         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7672         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7673         methods.
7674         (class string_file): New constructor with term_out parameter.
7675         Override methods term_out and can_emit_style_escape.  New member
7676         term_out.
7677         (class stdio_file): Override can_emit_style_escape.
7678         (class tee_file): Override term_out and can_emit_style_escape.
7679         * utils.h (can_emit_style_escape): Remove.
7680         * utils.c (can_emit_style_escape): Likewise.
7681         Update all callers of can_emit_style_escape (SOMESTREAM) to
7682         SOMESTREAM->can_emit_style_escape.
7683         * source-cache.c (source_cache::get_source_lines): Likewise.
7684         * stack.c (frame_apply_command_count): Call execute_command_to_string
7685         passing the term_out characteristic of the current gdb_stdout.
7686         * thread.c (thr_try_catch_cmd): Likewise.
7687         * top.c (execute_command_to_string): pass term_out parameter
7688         to construct the string_file for the command output.
7689         * ui-file.c (term_cli_styling): New function (most code moved
7690         from utils.c can_emit_style_escape).
7691         (string_file::string_file, string_file::can_emit_style_escape,
7692         stdio_file::can_emit_style_escape, tee_file::term_out,
7693         tee_file::can_emit_style_escape): New functions.
7694
7695 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7696
7697         * NEWS: Mention the new set|show may-call-functions.
7698         * infcall.c (may_call_functions_p): New variable.
7699         (show_may_call_functions_p): New function.
7700         (call_function_by_hand_dummy): Throws an error if not
7701         may-call-functions.
7702         (_initialize_infcall): Call add_setshow_boolean_cmd for
7703         may-call-functions.
7704
7705 2019-04-25  Keith Seitz  <keiths@redhat.com>
7706
7707         PR c++/24367
7708         * cp-support.c (inspect_type): Don't attempt substitutions
7709         of symbol with the same name.
7710
7711 2019-04-25  Tom Tromey  <tromey@adacore.com>
7712
7713         PR gdb/24475:
7714         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7715         static.
7716
7717 2019-04-25  Tom Tromey  <tromey@adacore.com>
7718
7719         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7720         rvalue reference.
7721         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7722         (gdb_xml_parser::parse): Use std::move.
7723         * python/python-internal.h (gdbpy_convert_exception): Take a const
7724         reference.
7725         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7726         std::move.
7727         * python/py-utils.c (gdbpy_convert_exception): Take a const
7728         reference.
7729         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7730         Use std::move.
7731         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7732         Use std::move.
7733         * mi/mi-main.c (mi_print_exception): Take a const reference.
7734         * main.c (handle_command_errors): Take a const reference.
7735         * linespec.c (parse_linespec): Use std::move.
7736         * infcall.c (run_inferior_call): Use std::move.
7737         (call_function_by_hand_dummy): Use std::move.
7738         * exec.c (try_open_exec_file): Use std::move.
7739         * exceptions.h (exception_print, exception_fprintf)
7740         (exception_print_same): Update.
7741         * exceptions.c (print_exception, exception_print)
7742         (exception_fprintf, exception_print_same): Change parameters to
7743         const reference.
7744         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7745         * common/new-op.c: Use std::move.
7746         * common/common-exceptions.h (struct gdb_exception): Add move
7747         constructor.
7748         (struct gdb_exception_error, struct gdb_exception_quit, struct
7749         gdb_quit_bad_alloc): Change constructor to move constructor.
7750         (throw_exception): Change parameter to rvalue reference.
7751         * common/common-exceptions.c (throw_exception): Take rvalue
7752         reference.
7753         * cli/cli-interp.c (safe_execute_command): Use std::move.
7754         * breakpoint.c (insert_bp_location, location_to_sals): Use
7755         std::move.
7756
7757 2019-04-25  Tom Tromey  <tromey@adacore.com>
7758
7759         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7760         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7761         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7762         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7763         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7764         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7765         guile/scm-value.c: Use unpack.
7766         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7767         gdbscm_gdb_exception.
7768         (gdbscm_throw_gdb_exception): Likewise.
7769         (struct gdbscm_gdb_exception): New.
7770         (unpack): New function.
7771         (gdbscm_wrap): Use unpack.
7772
7773 2019-04-25  Tom Tromey  <tromey@adacore.com>
7774
7775         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7776         (gdb_rl_callback_handler): Use std::move.
7777         * common/common-exceptions.h (struct gdb_exception): Add move
7778         assignment operator.
7779         (throw_exception_sjlj): Change "exception" to const reference.
7780         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7781         (throw_exception_sjlj): Change "exception" to const reference.
7782
7783 2019-04-25  Tom Tromey  <tromey@adacore.com>
7784
7785         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7786         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7787         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7788         Update.
7789         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7790         Update.
7791         * mi/mi-interp.c (mi_interp::exec): Update.
7792         * linespec.c (parse_linespec): Update.
7793         * infcall.c (run_inferior_call): Update.
7794         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7795         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7796         (gdbscm_lookup_global_symbol): Update.
7797         * guile/scm-param.c (gdbscm_parameter_value): Update.
7798         * guile/scm-frame.c (gdbscm_frame_read_register)
7799         (gdbscm_frame_read_var): Update.
7800         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7801         * exec.c (try_open_exec_file): Update.
7802         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7803         (gdb_rl_callback_handler): Update.
7804         * common/common-exceptions.h (exception_none): Don't declare.
7805         * common/common-exceptions.c (exception_none): Don't define.
7806         (struct catcher) <exception>: Update.
7807         * cli/cli-interp.c (safe_execute_command): Update.
7808         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7809
7810 2019-04-25  Ali Tamur  <tamur@google.com>
7811
7812         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7813         (read_attribute_value): Likewise.
7814         (dwarf2_read_addr_index): Update comment.
7815         (read_str_index): Add DW_FORM_strx.
7816         (dwarf2_string_attr): Likewise.
7817         (dwarf2_const_value_attr): Likewise.
7818         (dump_die_shallow): Likewise.
7819         (dwarf2_fetch_constant_bytes): Likewise.
7820         (skip_form_bytes): Likewise.
7821         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7822
7823 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7824
7825         PR corefiles/11608
7826         PR corefiles/18187
7827         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7828         OFFSET.  Verify if current mapping contains an ELF header.
7829         (linux_find_memory_regions_full): Adjust call to
7830         dump_mapping_p.
7831
7832 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7833             Kang Li <kanglictf@gmail.com>
7834
7835         PR gdb/21600
7836
7837         * dwarf2-frame.c (read_initial_length): Be consistent about using
7838         unsigned representation of length.
7839         (decode_frame_entry_1): Likewise.  Check for wraparound of
7840         end pointer as well as buffer overflow.
7841
7842 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7843
7844         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7845         "vq".
7846
7847 2019-04-24  Tom Tromey  <tromey@adacore.com>
7848
7849         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7850
7851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * s12z-tdep.c (s12z_unwind_pc): Delete.
7854         (s12z_unwind_sp): Delete.
7855         (s12z_gdbarch_init): Don't register deleted functions with
7856         gdbarch.
7857
7858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * rl78-tdep.c (rl78_unwind_sp): Delete.
7861         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7862
7863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7864
7865         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7866         (xstormy16_unwind_pc): Delete.
7867         (xstormy16_dummy_id): Delete.
7868         (xstormy16_gdbarch_init): Don't register deleted functions with
7869         gdbarch.
7870
7871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7872
7873         * vax-tdep.c (vax_unwind_pc): Delete.
7874         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7875
7876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7877
7878         * v850-tdep.c (v850_unwind_sp): Delete.
7879         (v850_unwind_pc): Delete.
7880         (v850_dummy_id): Delete.
7881         (v850_gdbarch_init): Don't register deleted functions with
7882         gdbarch.
7883
7884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7885
7886         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7887         (tilegx_unwind_pc): Delete.
7888         (tilegx_unwind_dummy_id): Delete.
7889         (tilegx_gdbarch_init): Don't register deleted functions with
7890         gdbarch.
7891
7892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7893
7894         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7895         (tic6x_dummy_id): Delete.
7896         (tic6x_gdbarch_init): Don't register deleted functions with
7897         gdbarch.
7898
7899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7900
7901         * sparc-tdep.c (sparc_unwind_pc): Delete.
7902         (sparc32_gdbarch_init): Don't register deleted function with
7903         gdbarch.
7904
7905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7906
7907         * sh-tdep.c (sh_unwind_sp): Delete.
7908         (sh_unwind_pc): Delete.
7909         (sh_dummy_id): Delete.
7910         (sh_gdbarch_init): Don't register deleted functions with
7911         gdbarch.
7912
7913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7914
7915         * score-tdep.c (score_unwind_sp): Delete.
7916         (score_unwind_pc): Delete.
7917         (score_dummy_id): Delete.
7918         (score_gdbarch_init): Don't register deleted functions with
7919         gdbarch.
7920
7921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7922
7923         * rx-tdep.c (rx_unwind_pc): Delete.
7924         (rx_unwind_sp): Delete.
7925         (rx_dummy_id): Delete.
7926         (rx_gdbarch_init): Don't register deleted functions with
7927         gdbarch.  Update comment.
7928
7929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7930
7931         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7932         (rs6000_dummy_id): Delete.
7933         (rs6000_gdbarch_init): Don't register deleted functions with
7934         gdbarch.
7935
7936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7937
7938         * or1k-tdep.c (or1k_dummy_id): Delete.
7939         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7940
7941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7942
7943         * nios2-tdep.c (nios2_dummy_id): Delete.
7944         (nios2_unwind_sp): Delete.
7945         (nios2_gdbarch_init): Don't register deleted functions with
7946         gdbarch.
7947
7948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7949
7950         * nds32-tdep.c (nds32_dummy_id): Delete.
7951         (nds32_unwind_pc): Delete.
7952         (nds32_unwind_sp): Delete.
7953         (nds32_gdbarch_init): Don't register deleted functions with
7954         gdbarch.
7955
7956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7957
7958         * msp430-tdep.c (msp430_unwind_pc): Delete.
7959         (msp430_unwind_sp): Delete.
7960         (msp430_dummy_id): Delete.
7961         (msp430_gdbarch_init): Don't register deleted functions with
7962         gdbarch.
7963
7964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * moxie-tdep.c (moxie_unwind_sp): Delete.
7967         (moxie_unwind_pc): Delete.
7968         (moxie_dummy_id): Delete.
7969         (moxie_gdbarch_init): Don't register deleted functions with
7970         gdbarch.
7971
7972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7973
7974         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7975         (mn10300_unwind_pc): Delete.
7976         (mn10300_unwind_sp): Delete.
7977         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7978         mn10300_unwind_sp.
7979         (mn10300_frame_unwind_init): Don't register deleted functions with
7980         gdbarch.
7981
7982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7983
7984         * mep-tdep.c (mep_unwind_pc): Delete.
7985         (mep_unwind_sp): Delete.
7986         (mep_dummy_id): Delete.
7987         (mep_gdbarch_init): Don't register deleted functions with
7988         gdbarch.
7989
7990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7991
7992         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7993         (m68hc11_unwind_sp): Delete.
7994         (m68hc11_gdbarch_init): Don't register deleted functions with
7995         gdbarch.
7996
7997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7998
7999         * m32r-tdep.c (m32r_unwind_sp): Delete.
8000         (m32r_unwind_pc): Delete.
8001         (m32r_dummy_id): Delete.
8002         (m32r_gdbarch_init): Don't register deleted functions with
8003         gdbarch.
8004
8005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8006
8007         * m32c-tdep.c (m32c_unwind_pc): Delete.
8008         (m32c_unwind_sp): Delete.
8009         (m32c_dummy_id): Delete.
8010         (m32c_gdbarch_init): Don't register deleted functions with
8011         gdbarch.
8012
8013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8014
8015         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8016         (lm32_unwind_pc): Delete.
8017         (lm32_dummy_id): Delete.
8018         (lm32_gdbarch_init): Don't register deleted functions with
8019         gdbarch.
8020
8021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8022
8023         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8024         (iq2000_unwind_pc): Delete.
8025         (iq2000_dummy_id): Delete.
8026         (iq2000_gdbarch_init): Don't register deleted functions with
8027         gdbarch.
8028
8029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8030
8031         * nds32-tdep.c (nds32_type_align): Delete.
8032         (nds32_push_dummy_call): Use type_align instead.
8033
8034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8035
8036         * arm-tdep.c (arm_type_align): Only handle vector override case.
8037         (arm_push_dummy_call): Use type_align.
8038         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8039
8040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8043         case.
8044         (pass_on_stack): Use type_align.
8045         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8046         function.
8047
8048 2019-04-23  Tom Tromey  <tromey@adacore.com>
8049
8050         * dwarf2read.c (line_header::file_name_at): Remove unused
8051         overload.
8052
8053 2019-04-23  Tom de Vries  <tdevries@suse.de>
8054
8055         PR gdb/24438
8056         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8057         invocation.
8058
8059
8060 2019-03-27  Ali Tamur  <tamur@google.com>
8061
8062         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8063         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8064         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8065         (dwarf_expr_context::get_addr_index): Likewise
8066         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8067         (symbol_needs_eval_context::get_addr_index): Likewise
8068         (disassemble_dwarf_expression): Add DW_OP_addrx
8069         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8070         (read_cutu_die_from_dwo): Update comment
8071         (skip_one_die): Add DW_FORM_addrx
8072         (read_attribute_value): Likewise
8073         (var_decode_location): Add DW_OP_addrx
8074         (dwarf2_const_value_attr): Add DW_FORM_addrx
8075         (dump_die_shallow): Likewise
8076         (dwarf2_fetch_constant_bytes): Likewise
8077         (decode_locdesc): Add DW_OP_addrx
8078         (skip_form_bytes): Add DW_FORM_addrx
8079
8080 2019-04-22  Ali Tamur  <tamur@google.com>
8081
8082         * MAINTAINERS (Write After Approval): Add self.
8083
8084 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8085
8086         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8087         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8088         (open_symbol_file_object): Likewise.
8089         (svr4_default_sos): Add info parameter.
8090         (svr4_read_so_list): Likewise.
8091         (svr4_current_sos_direct): Adjust functions calls to pass down
8092         info.
8093         (svr4_current_sos_1): Add info parameter.
8094         (svr4_current_sos): Call get_svr4_info, pass info down to
8095         svr4_current_sos_1.
8096         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8097         get_svr4_info.
8098         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8099         get_svr4_info.
8100         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8101         to get_svr4_info.
8102         (probes_table_remove_objfile_probes): Likewise.
8103         (register_solib_event_probe): Add info parameter.
8104         (solist_update_incremental): Pass info parameter down to
8105         svr4_read_so_list.
8106         (disable_probes_interface): Add info parameter.
8107         (svr4_handle_solib_event): Pass current_program_space to
8108         get_svr4_info.  Adjust disable_probes_interface cleanup.
8109         (svr4_create_probe_breakpoints): Add info parameter, pass it
8110         down to register_solib_event_probe.
8111         (svr4_create_solib_event_breakpoints): Add info parameter,
8112         pass it down to svr4_create_probe_breakpoints.
8113         (enable_break): Pass info down to
8114         svr4_create_solib_event_breakpoints.
8115         (svr4_solib_create_inferior_hook): Pass current_program_space to
8116         get_svr4_info.
8117         (svr4_clear_solib): Likewise.
8118
8119 2019-04-22  Pedro Alves  <palves@redhat.com>
8120
8121         * solib-svr4.c (svr4_free_objfile_observer): New.
8122         (probe_and_action::objfile): New field.
8123         (probes_table_htab_remove_objfile_probes)
8124         (probes_table_remove_objfile_probes): New functions.
8125         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8126         in the new probe_and_action.  Don't store the probe in 'lookup'.
8127         (svr4_create_probe_breakpoints): Pass objfile to
8128         register_solib_event_probe.
8129         (_initialize_svr4_solib): Register a free_objfile observer.
8130
8131 2019-04-19  Tom Tromey  <tom@tromey.com>
8132
8133         * common/queue.h: Remove.
8134
8135 2019-04-19  Tom Tromey  <tom@tromey.com>
8136
8137         * event-loop.c: Don't include "common/queue.h".
8138
8139 2019-04-19  Tom Tromey  <tom@tromey.com>
8140
8141         * remote.c (remote_target): Use delete.
8142         * remote-notif.h: Include <list>, not "common/queue.h".
8143         (notif_client_p): Remove typedef.
8144         (remote_notif_state): Add constructor, destructor, initializer.
8145         <notif_queue>: Now a std::list.
8146         (remote_notif_state_xfree): Don't declare.
8147         * remote-notif.c (remote_notif_process, handle_notification)
8148         (remote_notif_state_allocate): Update.
8149         (~remote_notif_state): Rename from remote_notif_state_xfree.
8150
8151 2019-04-19  Tom Tromey  <tom@tromey.com>
8152
8153         * symfile.c (reread_symbols): Update.
8154         * objfiles.c (objfile_register_static_link)
8155         (objfile_lookup_static_link): Update
8156         (~objfile) Don't delete static_links.
8157         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8158
8159 2019-04-19  Tom Tromey  <tom@tromey.com>
8160
8161         * type-stack.h (struct type_stack) <insert>: Constify string.
8162         * type-stack.c (type_stack::insert): Constify string.
8163         * gdbtypes.h (lookup_template_type): Update.
8164         (address_space_name_to_int): Update.
8165         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8166         const.
8167         (lookup_template_type): Make name const.
8168         * c-exp.y: Update rules.
8169         (lex_one_token, classify_name, classify_inner_name)
8170         (c_print_token): Update.
8171         * p-exp.y: Update rules.
8172         (yylex): Update.
8173         * f-exp.y: Update rules.
8174         (yylex): Update.
8175         * d-exp.y: Update rules.
8176         (lex_one_token, classify_name, classify_inner_name): Update.
8177         * parse.c (write_dollar_variable, copy_name): Return std::string.
8178         * parser-defs.h (copy_name): Change return type.
8179         * m2-exp.y: Update rules.
8180         (yylex): Update.
8181         * go-exp.y (lex_one_token): Update.
8182         Update rules.
8183         (classify_unsafe_function, classify_packaged_name)
8184         (classify_name, yylex): Update.
8185
8186 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8187
8188         * configure.ac: add --enable-source-highlight switch.
8189         * configure: Regenerate.
8190         * top.c (print_gdb_version): plumb --enable-source-highlight
8191         status to "show configuration".
8192
8193 2019-04-19  Tom Tromey  <tromey@adacore.com>
8194
8195         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8196         Check ADA_TYPE_P.
8197         (empty_record, ada_template_to_fixed_record_type_1)
8198         (template_to_static_fixed_type)
8199         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8200         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8201         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8202         macros.
8203
8204 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8205
8206         PR symtab/24423:
8207         * source.c (print_source_lines_base): Advance "iter" when a
8208         control character is seen.
8209
8210 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8211
8212         * inferior.h (struct infcall_suspend_state_deleter):
8213         Catch exception in destructor to avoid crash.
8214
8215 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8216
8217         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8218         close to the add_com "shell".
8219
8220 2019-04-18  Tom Tromey  <tromey@adacore.com>
8221
8222         * process-stratum-target.h (class process_stratum_target)
8223         <stratum>: Add "final".
8224
8225 2019-04-17  Tom Tromey  <tromey@adacore.com>
8226
8227         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8228         against nullptr before use.
8229
8230 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8231
8232         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8233
8234 2019-04-17  Jim Wilson  <jimw@sifive.com>
8235             Andrew Burgess  <andrew.burgess@embecosm.com>
8236
8237         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8238         code read might fail, assume 4-byte breakpoint in that case.
8239
8240 2019-04-15  Leszek Swirski  <leszeks@google.com>
8241
8242         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8243         rather than a hand-rolled POD check when checking for forced MEMORY
8244         classification.
8245
8246 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8247
8248         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8249         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8250         function.
8251         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8252         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8253         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8254         declaration.
8255
8256 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8257
8258         * aarch64-linux-nat.c
8259         (aarch64_linux_nat_target::thread_architecture): Add override.
8260         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8261         each VQ.
8262
8263 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8264
8265         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8266
8267 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8268
8269         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8270         target types of size 96-bits, add some additional comments, and
8271         check that the builtin type we found was the correct size.
8272
8273 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8274
8275         * utils.c (prompt_for_continue): Don't restore the styling at the
8276         end, as applied_style has the wrong value.  This fixes styling in
8277         long lists of file names that are interrupted by the "Continue?"
8278         prompt.
8279
8280 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8281
8282         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8283         * c-lang.c (c_language_defn): Likewise.
8284         (cplus_language_defn): Likewise.
8285         (asm_language_defn): Likewise.
8286         (minimal_language_defn): Likewise.
8287         * d-lang.c (d_language_defn): Likewise.
8288         * f-lang.c (f_language_defn): Likewise.
8289         * go-lang.c (go_language_defn): Likewise.
8290         * language.c (unknown_language_defn): Likewise.
8291         (auto_language_defn): Likewise.
8292         * language.h (struct language_defn): Remove la_magic field.
8293         (LANG_MAGIC): Delete.
8294         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8295         * objc-lang.c (objc_language_defn): Likewise.
8296         * opencl-lang.c (opencl_language_defn): Likewise.
8297         * p-lang.c (pascal_language_defn): Likewise.
8298         * rust-lang.c (rust_language_defn): Likewise.
8299
8300 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * riscv-tdep.c (riscv_type_align): New function.
8303         (riscv_type_alignment): Delete.
8304         (riscv_arg_location): Use 'type_align'.
8305         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8306
8307 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8308
8309         * gdbtypes.c (type_align): A struct with no non-static fields also
8310         has alignment of 1.
8311
8312 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8313
8314         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8315         component to 0.
8316         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8317         member.
8318         (riscv_struct_info::analyse): New implementation using new
8319         analyse_inner member function.
8320         (riscv_struct_info::field_offset): New member function.
8321         (riscv_struct_info::m_offsets): New member variable.
8322         (riscv_struct_info::analyse_inner): New private member function,
8323         takes the old implementation of riscv_struct_info::analyse but
8324         extended to track field offsets.
8325         (riscv_call_arg_struct): Update the struct folding special cases
8326         to handle cases where empty C++ structs, which are non-zero
8327         length, are found.
8328         (riscv_arg_location): Initialise the length of each location, a
8329         non-zero length now indicates the location is in use.
8330         (riscv_push_dummy_call): Allow for the first location having a
8331         non-zero offset when setting up arguments.
8332         (riscv_return_value): Likewise, but for return values.
8333
8334 2019-04-11  Tom Tromey  <tromey@adacore.com>
8335
8336         * utils.c (internal_vproblem): Make "msg" const.
8337
8338 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8339
8340         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8341         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8342         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8343         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8344
8345 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8346
8347         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8348         function.
8349         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8350         of amd64_collect_native_gregset.
8351         (amd64_linux_nat_target::store_registers): Likewise.
8352
8353 2019-04-10  Tom Tromey  <tom@tromey.com>
8354
8355         * symtab.c (lookup_global_symbol_from_objfile)
8356         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8357         * objfiles.h (class separate_debug_iterator): New.
8358         (class separate_debug_range): New.
8359         (struct objfile) <separate_debug_objfiles>: New method.
8360         (objfile_separate_debug_iterate): Don't declare.
8361         * objfiles.c (separate_debug_iterator::operator++): Rename from
8362         objfile_separate_debug_iterate.
8363         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8364         iterator.
8365         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8366         iterator.
8367
8368 2019-04-10  Tom Tromey  <tom@tromey.com>
8369
8370         * symfile.c (reread_symbols): Remove old comment.
8371         * objfiles.c (free_all_objfiles): Fix a typo.
8372
8373 2019-04-10  Tom Tromey  <tom@tromey.com>
8374
8375         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8376         * minsyms.c (lookup_minimal_symbol): Use foreach.
8377         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8378         (lookup_minimal_symbol_solib_trampoline): Likewise.
8379         * symfile.c (reread_symbols): Use foreach.
8380
8381 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8382             Tom Tromey  <tromey@adacore.com>
8383
8384         PR rust/24414:
8385         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8386         (rust_lex_int_test): Change "value" to be LONGEST.
8387         (rust_lex_tests): Add test for long integer literal.
8388
8389 2019-04-09  Tom Tromey  <tromey@adacore.com>
8390
8391         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8392         to bool.
8393         (extended_remote_target::attach): Update.
8394         (remote_target::remote_notice_new_inferior): Update.
8395         (remote_target::add_current_inferior_and_thread): Update.
8396         * inferior.c (exit_inferior_1): Use "false".
8397         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8398
8399 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8400
8401         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8402         the "start" command.
8403
8404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8405
8406         * python/py-inferior.c (infpy_thread_from_thread_handle):
8407         Adjust comments to reflect renaming of thread_from_thread_handle
8408         to thread_from_handle.  Adjust keywords.  Fix type error message.
8409         (inferior_object_methods): Add thread_from_handle.  Retain
8410         thread_from_thread_handle, but mark it as deprecated.
8411
8412 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8413
8414         * gdbthread.h (find_thread_by_handle): Revise declaration.
8415         * thread.c (find_thread_by_handle): Likewise.  Adjust
8416         implementation too.
8417         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8418         support for buffer objects as handles.
8419
8420 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8421
8422         * python/py-infthread.c (thpy_thread_handle): New function.
8423         (thread_object_methods): Register thpy_thread_handle.
8424
8425 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8426
8427         * gdbthread.h (thread_to_thread_handle): Declare.
8428         * thread.c (gdbtypes.h): Include.
8429         (thread_to_thread_handle): New function.
8430
8431         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8432         (target_thread_info_to_thread_handle): Declare.
8433         * target.c (target_thread_info_to_thread_handle): New function.
8434         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8435         * target-delegates.c: Regenerate.
8436
8437         * linux-thread-db.c (class thread_db_target): Add method
8438         thread_info_to_thread_handle.
8439         (thread_db_target::thread_info_to_thread_handle): Define.
8440         * remote.c (class remote_target): Add new method
8441         thread_info_to_thread_handle.
8442         (remote_target::thread_info_to_thread_handle): Define.
8443
8444 2019-04-08  Pedro Alves  <palves@redhat.com>
8445
8446         * common/common-exceptions.c (throw_exception): Don't create
8447         named object to throw; throw directly.
8448         (throw_it): Likewise.  Don't initialize gdb_exception::message
8449         here, with new; pass FMT and AP to the ctor instead.
8450         * common/common-exceptions.h: Include <string>.
8451         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8452         const char *, va_list)): New ctor.  Use std::make_shared.
8453         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8454         errors)): Delete.
8455         (gdb_exception_error::gdb_exception_error(enum errors, const char
8456         *, va_list)): New.
8457         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8458         Add assertion.
8459         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8460         errors)): Delete.
8461         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8462         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8463         Add assertion.
8464
8465 2019-04-08  Tom Tromey  <tom@tromey.com>
8466
8467         * valops.c (value_rtti_indirect_type): Replace throw_exception
8468         with throw.
8469         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8470         with throw.
8471         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8472         throw.
8473         * target.c (target_translate_tls_address): Replace throw_exception
8474         with throw.
8475         * stack.c (frame_apply_command_count): Replace throw_exception
8476         with throw.
8477         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8478         throw.
8479         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8480         with throw.
8481         * rs6000-tdep.c (rs6000_frame_cache)
8482         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8483         * remote.c: Replace throw_exception with throw.
8484         * record-full.c (record_full_message, record_full_wait_1)
8485         (record_full_restore): Replace throw_exception with throw.
8486         * record-btrace.c:
8487         (get_thread_current_frame_id, record_btrace_start_replaying)
8488         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8489         (cmd_record_btrace_start): Replace throw_exception with throw.
8490         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8491         throw.
8492         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8493         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8494         * linespec.c:
8495         (find_linespec_symbols): Replace throw_exception with throw.
8496         * infrun.c (displaced_step_prepare, resume): Replace
8497         throw_exception with throw.
8498         * infcmd.c (post_create_inferior): Replace throw_exception with
8499         throw.
8500         * inf-loop.c (inferior_event_handler): Replace throw_exception
8501         with throw.
8502         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8503         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8504         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8505         (get_prev_frame_always, get_frame_pc_if_available)
8506         (get_frame_address_in_block_if_available, get_frame_language):
8507         Replace throw_exception with throw.
8508         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8509         throw_exception with throw.
8510         * eval.c (fetch_subexp_value, evaluate_var_value)
8511         (evaluate_funcall, evaluate_subexp_standard): Replace
8512         throw_exception with throw.
8513         * dwarf2loc.c (call_site_find_chain)
8514         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8515         Replace throw_exception with throw.
8516         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8517         with throw.
8518         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8519         throw.
8520         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8521         * completer.c (complete_line_internal): Replace throw_exception
8522         with throw.
8523         * compile/compile-object-run.c (compile_object_run): Replace
8524         throw_exception with throw.
8525         * cli/cli-script.c (process_next_line): Replace throw_exception
8526         with throw.
8527         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8528         (btrace_enable, btrace_maint_update_pt_packets): Replace
8529         throw_exception with throw.
8530         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8531         throw_exception with throw.
8532         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8533         throw_exception with throw.
8534         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8535         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8536         * aarch64-tdep.c (aarch64_make_prologue_cache)
8537         (aarch64_make_stub_cache): Replace throw_exception with throw.
8538
8539 2019-04-08  Tom Tromey  <tom@tromey.com>
8540
8541         * common/common-exceptions.c (throw_exception): Rename from
8542         throw_exception_cxx.  Remove old copy.  Make argument const.
8543         (throw_it): Create and throw exception objects directly.
8544         * common/common-exceptions.h (throw_exception): Make argument
8545         const.
8546         (struct gdb_exception_error): Add constructor.
8547         (struct gdb_exception_quit): Add constructor.
8548
8549 2019-04-08  Tom Tromey  <tom@tromey.com>
8550
8551         * common/common-exceptions.h (exception_rethrow): Don't declare.
8552         (TRY_SJLJ): Update comment.
8553         (TRY, CATCH, END_CATCH): Remove.
8554         * common/common-exceptions.c (exception_rethrow): Remove.
8555
8556 2019-04-08  Tom Tromey  <tom@tromey.com>
8557
8558         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8559         Remove.
8560         (gdb_exception_error): Rename from
8561         gdb_exception_RETURN_MASK_ERROR.
8562         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8563         (gdb_quit_bad_alloc): Update.
8564         * aarch64-tdep.c: Update.
8565         * ada-lang.c: Update.
8566         * ada-typeprint.c: Update.
8567         * ada-valprint.c: Update.
8568         * amd64-tdep.c: Update.
8569         * arch-utils.c: Update.
8570         * break-catch-throw.c: Update.
8571         * breakpoint.c: Update.
8572         * btrace.c: Update.
8573         * c-varobj.c: Update.
8574         * cli/cli-cmds.c: Update.
8575         * cli/cli-interp.c: Update.
8576         * cli/cli-script.c: Update.
8577         * common/common-exceptions.c: Update.
8578         * common/new-op.c: Update.
8579         * common/selftest.c: Update.
8580         * compile/compile-c-symbols.c: Update.
8581         * compile/compile-cplus-symbols.c: Update.
8582         * compile/compile-object-load.c: Update.
8583         * compile/compile-object-run.c: Update.
8584         * completer.c: Update.
8585         * corelow.c: Update.
8586         * cp-abi.c: Update.
8587         * cp-support.c: Update.
8588         * cp-valprint.c: Update.
8589         * darwin-nat.c: Update.
8590         * disasm-selftests.c: Update.
8591         * dtrace-probe.c: Update.
8592         * dwarf-index-cache.c: Update.
8593         * dwarf-index-write.c: Update.
8594         * dwarf2-frame-tailcall.c: Update.
8595         * dwarf2-frame.c: Update.
8596         * dwarf2loc.c: Update.
8597         * dwarf2read.c: Update.
8598         * eval.c: Update.
8599         * event-loop.c: Update.
8600         * event-top.c: Update.
8601         * exec.c: Update.
8602         * f-valprint.c: Update.
8603         * fbsd-tdep.c: Update.
8604         * frame-unwind.c: Update.
8605         * frame.c: Update.
8606         * gdbtypes.c: Update.
8607         * gnu-v3-abi.c: Update.
8608         * guile/guile-internal.h: Update.
8609         * guile/scm-block.c: Update.
8610         * guile/scm-breakpoint.c: Update.
8611         * guile/scm-cmd.c: Update.
8612         * guile/scm-disasm.c: Update.
8613         * guile/scm-frame.c: Update.
8614         * guile/scm-lazy-string.c: Update.
8615         * guile/scm-math.c: Update.
8616         * guile/scm-param.c: Update.
8617         * guile/scm-ports.c: Update.
8618         * guile/scm-pretty-print.c: Update.
8619         * guile/scm-symbol.c: Update.
8620         * guile/scm-symtab.c: Update.
8621         * guile/scm-type.c: Update.
8622         * guile/scm-value.c: Update.
8623         * i386-linux-tdep.c: Update.
8624         * i386-tdep.c: Update.
8625         * inf-loop.c: Update.
8626         * infcall.c: Update.
8627         * infcmd.c: Update.
8628         * infrun.c: Update.
8629         * jit.c: Update.
8630         * language.c: Update.
8631         * linespec.c: Update.
8632         * linux-fork.c: Update.
8633         * linux-nat.c: Update.
8634         * linux-tdep.c: Update.
8635         * linux-thread-db.c: Update.
8636         * main.c: Update.
8637         * mi/mi-cmd-break.c: Update.
8638         * mi/mi-cmd-stack.c: Update.
8639         * mi/mi-interp.c: Update.
8640         * mi/mi-main.c: Update.
8641         * objc-lang.c: Update.
8642         * p-valprint.c: Update.
8643         * parse.c: Update.
8644         * ppc-linux-tdep.c: Update.
8645         * printcmd.c: Update.
8646         * python/py-arch.c: Update.
8647         * python/py-breakpoint.c: Update.
8648         * python/py-cmd.c: Update.
8649         * python/py-finishbreakpoint.c: Update.
8650         * python/py-frame.c: Update.
8651         * python/py-framefilter.c: Update.
8652         * python/py-gdb-readline.c: Update.
8653         * python/py-inferior.c: Update.
8654         * python/py-infthread.c: Update.
8655         * python/py-lazy-string.c: Update.
8656         * python/py-linetable.c: Update.
8657         * python/py-objfile.c: Update.
8658         * python/py-param.c: Update.
8659         * python/py-prettyprint.c: Update.
8660         * python/py-progspace.c: Update.
8661         * python/py-record-btrace.c: Update.
8662         * python/py-record.c: Update.
8663         * python/py-symbol.c: Update.
8664         * python/py-type.c: Update.
8665         * python/py-unwind.c: Update.
8666         * python/py-utils.c: Update.
8667         * python/py-value.c: Update.
8668         * python/python.c: Update.
8669         * record-btrace.c: Update.
8670         * record-full.c: Update.
8671         * remote-fileio.c: Update.
8672         * remote.c: Update.
8673         * riscv-tdep.c: Update.
8674         * rs6000-aix-tdep.c: Update.
8675         * rs6000-tdep.c: Update.
8676         * rust-exp.y: Update.
8677         * rust-lang.c: Update.
8678         * s390-tdep.c: Update.
8679         * selftest-arch.c: Update.
8680         * solib-dsbt.c: Update.
8681         * solib-frv.c: Update.
8682         * solib-spu.c: Update.
8683         * solib-svr4.c: Update.
8684         * solib.c: Update.
8685         * sparc64-linux-tdep.c: Update.
8686         * stack.c: Update.
8687         * symfile-mem.c: Update.
8688         * symmisc.c: Update.
8689         * target.c: Update.
8690         * thread.c: Update.
8691         * top.c: Update.
8692         * tracefile-tfile.c: Update.
8693         * tui/tui.c: Update.
8694         * typeprint.c: Update.
8695         * unittests/cli-utils-selftests.c: Update.
8696         * unittests/parse-connection-spec-selftests.c: Update.
8697         * valops.c: Update.
8698         * valprint.c: Update.
8699         * value.c: Update.
8700         * varobj.c: Update.
8701         * windows-nat.c: Update.
8702         * x86-linux-nat.c: Update.
8703         * xml-support.c: Update.
8704
8705 2019-04-08  Tom Tromey  <tom@tromey.com>
8706
8707         * xml-support.c: Use C++ exception handling.
8708         * x86-linux-nat.c: Use C++ exception handling.
8709         * windows-nat.c: Use C++ exception handling.
8710         * varobj.c: Use C++ exception handling.
8711         * value.c: Use C++ exception handling.
8712         * valprint.c: Use C++ exception handling.
8713         * valops.c: Use C++ exception handling.
8714         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8715         handling.
8716         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8717         * typeprint.c: Use C++ exception handling.
8718         * tui/tui.c: Use C++ exception handling.
8719         * tracefile-tfile.c: Use C++ exception handling.
8720         * top.c: Use C++ exception handling.
8721         * thread.c: Use C++ exception handling.
8722         * target.c: Use C++ exception handling.
8723         * symmisc.c: Use C++ exception handling.
8724         * symfile-mem.c: Use C++ exception handling.
8725         * stack.c: Use C++ exception handling.
8726         * sparc64-linux-tdep.c: Use C++ exception handling.
8727         * solib.c: Use C++ exception handling.
8728         * solib-svr4.c: Use C++ exception handling.
8729         * solib-spu.c: Use C++ exception handling.
8730         * solib-frv.c: Use C++ exception handling.
8731         * solib-dsbt.c: Use C++ exception handling.
8732         * selftest-arch.c: Use C++ exception handling.
8733         * s390-tdep.c: Use C++ exception handling.
8734         * rust-lang.c: Use C++ exception handling.
8735         * rust-exp.y: Use C++ exception handling.
8736         * rs6000-tdep.c: Use C++ exception handling.
8737         * rs6000-aix-tdep.c: Use C++ exception handling.
8738         * riscv-tdep.c: Use C++ exception handling.
8739         * remote.c: Use C++ exception handling.
8740         * remote-fileio.c: Use C++ exception handling.
8741         * record-full.c: Use C++ exception handling.
8742         * record-btrace.c: Use C++ exception handling.
8743         * python/python.c: Use C++ exception handling.
8744         * python/py-value.c: Use C++ exception handling.
8745         * python/py-utils.c: Use C++ exception handling.
8746         * python/py-unwind.c: Use C++ exception handling.
8747         * python/py-type.c: Use C++ exception handling.
8748         * python/py-symbol.c: Use C++ exception handling.
8749         * python/py-record.c: Use C++ exception handling.
8750         * python/py-record-btrace.c: Use C++ exception handling.
8751         * python/py-progspace.c: Use C++ exception handling.
8752         * python/py-prettyprint.c: Use C++ exception handling.
8753         * python/py-param.c: Use C++ exception handling.
8754         * python/py-objfile.c: Use C++ exception handling.
8755         * python/py-linetable.c: Use C++ exception handling.
8756         * python/py-lazy-string.c: Use C++ exception handling.
8757         * python/py-infthread.c: Use C++ exception handling.
8758         * python/py-inferior.c: Use C++ exception handling.
8759         * python/py-gdb-readline.c: Use C++ exception handling.
8760         * python/py-framefilter.c: Use C++ exception handling.
8761         * python/py-frame.c: Use C++ exception handling.
8762         * python/py-finishbreakpoint.c: Use C++ exception handling.
8763         * python/py-cmd.c: Use C++ exception handling.
8764         * python/py-breakpoint.c: Use C++ exception handling.
8765         * python/py-arch.c: Use C++ exception handling.
8766         * printcmd.c: Use C++ exception handling.
8767         * ppc-linux-tdep.c: Use C++ exception handling.
8768         * parse.c: Use C++ exception handling.
8769         * p-valprint.c: Use C++ exception handling.
8770         * objc-lang.c: Use C++ exception handling.
8771         * mi/mi-main.c: Use C++ exception handling.
8772         * mi/mi-interp.c: Use C++ exception handling.
8773         * mi/mi-cmd-stack.c: Use C++ exception handling.
8774         * mi/mi-cmd-break.c: Use C++ exception handling.
8775         * main.c: Use C++ exception handling.
8776         * linux-thread-db.c: Use C++ exception handling.
8777         * linux-tdep.c: Use C++ exception handling.
8778         * linux-nat.c: Use C++ exception handling.
8779         * linux-fork.c: Use C++ exception handling.
8780         * linespec.c: Use C++ exception handling.
8781         * language.c: Use C++ exception handling.
8782         * jit.c: Use C++ exception handling.
8783         * infrun.c: Use C++ exception handling.
8784         * infcmd.c: Use C++ exception handling.
8785         * infcall.c: Use C++ exception handling.
8786         * inf-loop.c: Use C++ exception handling.
8787         * i386-tdep.c: Use C++ exception handling.
8788         * i386-linux-tdep.c: Use C++ exception handling.
8789         * guile/scm-value.c: Use C++ exception handling.
8790         * guile/scm-type.c: Use C++ exception handling.
8791         * guile/scm-symtab.c: Use C++ exception handling.
8792         * guile/scm-symbol.c: Use C++ exception handling.
8793         * guile/scm-pretty-print.c: Use C++ exception handling.
8794         * guile/scm-ports.c: Use C++ exception handling.
8795         * guile/scm-param.c: Use C++ exception handling.
8796         * guile/scm-math.c: Use C++ exception handling.
8797         * guile/scm-lazy-string.c: Use C++ exception handling.
8798         * guile/scm-frame.c: Use C++ exception handling.
8799         * guile/scm-disasm.c: Use C++ exception handling.
8800         * guile/scm-cmd.c: Use C++ exception handling.
8801         * guile/scm-breakpoint.c: Use C++ exception handling.
8802         * guile/scm-block.c: Use C++ exception handling.
8803         * guile/guile-internal.h: Use C++ exception handling.
8804         * gnu-v3-abi.c: Use C++ exception handling.
8805         * gdbtypes.c: Use C++ exception handling.
8806         * frame.c: Use C++ exception handling.
8807         * frame-unwind.c: Use C++ exception handling.
8808         * fbsd-tdep.c: Use C++ exception handling.
8809         * f-valprint.c: Use C++ exception handling.
8810         * exec.c: Use C++ exception handling.
8811         * event-top.c: Use C++ exception handling.
8812         * event-loop.c: Use C++ exception handling.
8813         * eval.c: Use C++ exception handling.
8814         * dwarf2read.c: Use C++ exception handling.
8815         * dwarf2loc.c: Use C++ exception handling.
8816         * dwarf2-frame.c: Use C++ exception handling.
8817         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8818         * dwarf-index-write.c: Use C++ exception handling.
8819         * dwarf-index-cache.c: Use C++ exception handling.
8820         * dtrace-probe.c: Use C++ exception handling.
8821         * disasm-selftests.c: Use C++ exception handling.
8822         * darwin-nat.c: Use C++ exception handling.
8823         * cp-valprint.c: Use C++ exception handling.
8824         * cp-support.c: Use C++ exception handling.
8825         * cp-abi.c: Use C++ exception handling.
8826         * corelow.c: Use C++ exception handling.
8827         * completer.c: Use C++ exception handling.
8828         * compile/compile-object-run.c: Use C++ exception handling.
8829         * compile/compile-object-load.c: Use C++ exception handling.
8830         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8831         * compile/compile-c-symbols.c: Use C++ exception handling.
8832         * common/selftest.c: Use C++ exception handling.
8833         * common/new-op.c: Use C++ exception handling.
8834         * cli/cli-script.c: Use C++ exception handling.
8835         * cli/cli-interp.c: Use C++ exception handling.
8836         * cli/cli-cmds.c: Use C++ exception handling.
8837         * c-varobj.c: Use C++ exception handling.
8838         * btrace.c: Use C++ exception handling.
8839         * breakpoint.c: Use C++ exception handling.
8840         * break-catch-throw.c: Use C++ exception handling.
8841         * arch-utils.c: Use C++ exception handling.
8842         * amd64-tdep.c: Use C++ exception handling.
8843         * ada-valprint.c: Use C++ exception handling.
8844         * ada-typeprint.c: Use C++ exception handling.
8845         * ada-lang.c: Use C++ exception handling.
8846         * aarch64-tdep.c: Use C++ exception handling.
8847
8848 2019-04-08  Tom Tromey  <tom@tromey.com>
8849
8850         * xml-support.c (gdb_xml_parser::parse): Update.
8851         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8852         * value.c (show_convenience): Update.
8853         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8854         (test_parse_flags_qcs): Update.
8855         * thread.c (thr_try_catch_cmd): Update.
8856         * target.c (target_translate_tls_address): Update.
8857         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8858         (info_frame_command_core, frame_apply_command_count): Update.
8859         * rust-exp.y (rust_lex_exception_test): Update.
8860         * riscv-tdep.c (riscv_print_one_register_info): Update.
8861         * remote.c (remote_target::enable_btrace): Update.
8862         * record-btrace.c (record_btrace_enable_warn): Update.
8863         * python/py-utils.c (gdbpy_convert_exception): Update.
8864         * printcmd.c (do_one_display, print_variable_and_value): Update.
8865         * mi/mi-main.c (mi_print_exception): Update.
8866         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8867         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8868         * linux-nat.c (linux_nat_target::attach): Update.
8869         * linux-fork.c (class scoped_switch_fork_info): Update.
8870         * infrun.c (displaced_step_prepare): Update.
8871         * infcall.c (call_function_by_hand_dummy): Update.
8872         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8873         * gnu-v3-abi.c (print_one_vtable): Update.
8874         * frame.c (get_prev_frame_always): Update.
8875         * f-valprint.c (info_common_command_for_block): Update.
8876         * exec.c (try_open_exec_file): Update.
8877         * exceptions.c (print_exception, exception_print)
8878         (exception_fprintf, exception_print_same): Update.
8879         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8880         * dwarf-index-cache.c (index_cache::store)
8881         (index_cache::lookup_gdb_index): Update.
8882         * darwin-nat.c (maybe_cache_shell): Update.
8883         * cp-valprint.c (cp_print_value_fields): Update.
8884         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8885         (gcc_cplus_symbol_address): Update.
8886         * compile/compile-c-symbols.c (gcc_convert_symbol)
8887         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8888         * common/selftest.c: Update.
8889         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8890         a std::string.
8891         (exception_try_scope_entry, exception_try_scope_exit): Don't
8892         declare.
8893         (struct exception_try_scope): Remove.
8894         (TRY): Don't use exception_try_scope.
8895         (struct gdb_exception): Add constructor, operator=.
8896         <what>: New method.
8897         (struct gdb_exception_RETURN_MASK_ALL)
8898         (struct gdb_exception_RETURN_MASK_ERROR)
8899         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8900         (struct gdb_quit_bad_alloc): Update.
8901         * common/common-exceptions.c (exception_none): Change
8902         initializer.
8903         (struct catcher) <state, exception>: Initialize inline.
8904         <prev>: Remove member.
8905         (current_catcher): Remove.
8906         (catchers): New global.
8907         (exceptions_state_mc_init): Simplify.
8908         (catcher_pop): Remove.
8909         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8910         (try_scope_depth, exception_try_scope_entry)
8911         (exception_try_scope_exit): Remove.
8912         (throw_exception_sjlj): Update.
8913         (exception_messages, exception_messages_size): Remove.
8914         (throw_it): Simplify.
8915         (gdb_exception_sliced_copy): Remove.
8916         (throw_exception_cxx): Update.
8917         * cli/cli-script.c (script_from_file): Update.
8918         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8919         Update.
8920         * ada-valprint.c (ada_val_print): Update.
8921         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8922         (create_excep_cond_exprs): Update.
8923
8924 2019-04-08  Tom Tromey  <tom@tromey.com>
8925
8926         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8927         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8928         (TRY, CATCH, END_CATCH): Remove some definitions.
8929         * common/common-exceptions.c: Don't use GDB_XCPT.
8930         (catcher_list_size): Remove.
8931         (throw_exception, throw_it): Simplify.
8932
8933 2019-04-05  Tom Tromey  <tom@tromey.com>
8934
8935         Revert the header-sorting patch.
8936         * ft32-tdep.c: Revert.
8937         * frv-tdep.c: Revert.
8938         * frv-linux-tdep.c: Revert.
8939         * frame.c: Revert.
8940         * frame-unwind.c: Revert.
8941         * frame-base.c: Revert.
8942         * fork-child.c: Revert.
8943         * findvar.c: Revert.
8944         * findcmd.c: Revert.
8945         * filesystem.c: Revert.
8946         * filename-seen-cache.h: Revert.
8947         * filename-seen-cache.c: Revert.
8948         * fbsd-tdep.c: Revert.
8949         * fbsd-nat.h: Revert.
8950         * fbsd-nat.c: Revert.
8951         * f-valprint.c: Revert.
8952         * f-typeprint.c: Revert.
8953         * f-lang.c: Revert.
8954         * extension.h: Revert.
8955         * extension.c: Revert.
8956         * extension-priv.h: Revert.
8957         * expprint.c: Revert.
8958         * exec.h: Revert.
8959         * exec.c: Revert.
8960         * exceptions.c: Revert.
8961         * event-top.c: Revert.
8962         * event-loop.c: Revert.
8963         * eval.c: Revert.
8964         * elfread.c: Revert.
8965         * dwarf2read.h: Revert.
8966         * dwarf2read.c: Revert.
8967         * dwarf2loc.c: Revert.
8968         * dwarf2expr.h: Revert.
8969         * dwarf2expr.c: Revert.
8970         * dwarf2-frame.c: Revert.
8971         * dwarf2-frame-tailcall.c: Revert.
8972         * dwarf-index-write.h: Revert.
8973         * dwarf-index-write.c: Revert.
8974         * dwarf-index-common.c: Revert.
8975         * dwarf-index-cache.h: Revert.
8976         * dwarf-index-cache.c: Revert.
8977         * dummy-frame.c: Revert.
8978         * dtrace-probe.c: Revert.
8979         * disasm.h: Revert.
8980         * disasm.c: Revert.
8981         * disasm-selftests.c: Revert.
8982         * dictionary.c: Revert.
8983         * dicos-tdep.c: Revert.
8984         * demangle.c: Revert.
8985         * dcache.h: Revert.
8986         * dcache.c: Revert.
8987         * darwin-nat.h: Revert.
8988         * darwin-nat.c: Revert.
8989         * darwin-nat-info.c: Revert.
8990         * d-valprint.c: Revert.
8991         * d-namespace.c: Revert.
8992         * d-lang.c: Revert.
8993         * ctf.c: Revert.
8994         * csky-tdep.c: Revert.
8995         * csky-linux-tdep.c: Revert.
8996         * cris-tdep.c: Revert.
8997         * cris-linux-tdep.c: Revert.
8998         * cp-valprint.c: Revert.
8999         * cp-support.c: Revert.
9000         * cp-namespace.c: Revert.
9001         * cp-abi.c: Revert.
9002         * corelow.c: Revert.
9003         * corefile.c: Revert.
9004         * continuations.c: Revert.
9005         * completer.h: Revert.
9006         * completer.c: Revert.
9007         * complaints.c: Revert.
9008         * coffread.c: Revert.
9009         * coff-pe-read.c: Revert.
9010         * cli-out.h: Revert.
9011         * cli-out.c: Revert.
9012         * charset.c: Revert.
9013         * c-varobj.c: Revert.
9014         * c-valprint.c: Revert.
9015         * c-typeprint.c: Revert.
9016         * c-lang.c: Revert.
9017         * buildsym.c: Revert.
9018         * buildsym-legacy.c: Revert.
9019         * build-id.h: Revert.
9020         * build-id.c: Revert.
9021         * btrace.c: Revert.
9022         * bsd-uthread.c: Revert.
9023         * breakpoint.h: Revert.
9024         * breakpoint.c: Revert.
9025         * break-catch-throw.c: Revert.
9026         * break-catch-syscall.c: Revert.
9027         * break-catch-sig.c: Revert.
9028         * blockframe.c: Revert.
9029         * block.c: Revert.
9030         * bfin-tdep.c: Revert.
9031         * bfin-linux-tdep.c: Revert.
9032         * bfd-target.c: Revert.
9033         * bcache.c: Revert.
9034         * ax-general.c: Revert.
9035         * ax-gdb.h: Revert.
9036         * ax-gdb.c: Revert.
9037         * avr-tdep.c: Revert.
9038         * auxv.c: Revert.
9039         * auto-load.c: Revert.
9040         * arm-wince-tdep.c: Revert.
9041         * arm-tdep.c: Revert.
9042         * arm-symbian-tdep.c: Revert.
9043         * arm-pikeos-tdep.c: Revert.
9044         * arm-obsd-tdep.c: Revert.
9045         * arm-nbsd-tdep.c: Revert.
9046         * arm-nbsd-nat.c: Revert.
9047         * arm-linux-tdep.c: Revert.
9048         * arm-linux-nat.c: Revert.
9049         * arm-fbsd-tdep.c: Revert.
9050         * arm-fbsd-nat.c: Revert.
9051         * arm-bsd-tdep.c: Revert.
9052         * arch-utils.c: Revert.
9053         * arc-tdep.c: Revert.
9054         * arc-newlib-tdep.c: Revert.
9055         * annotate.h: Revert.
9056         * annotate.c: Revert.
9057         * amd64-windows-tdep.c: Revert.
9058         * amd64-windows-nat.c: Revert.
9059         * amd64-tdep.c: Revert.
9060         * amd64-sol2-tdep.c: Revert.
9061         * amd64-obsd-tdep.c: Revert.
9062         * amd64-obsd-nat.c: Revert.
9063         * amd64-nbsd-tdep.c: Revert.
9064         * amd64-nbsd-nat.c: Revert.
9065         * amd64-nat.c: Revert.
9066         * amd64-linux-tdep.c: Revert.
9067         * amd64-linux-nat.c: Revert.
9068         * amd64-fbsd-tdep.c: Revert.
9069         * amd64-fbsd-nat.c: Revert.
9070         * amd64-dicos-tdep.c: Revert.
9071         * amd64-darwin-tdep.c: Revert.
9072         * amd64-bsd-nat.c: Revert.
9073         * alpha-tdep.c: Revert.
9074         * alpha-obsd-tdep.c: Revert.
9075         * alpha-nbsd-tdep.c: Revert.
9076         * alpha-mdebug-tdep.c: Revert.
9077         * alpha-linux-tdep.c: Revert.
9078         * alpha-linux-nat.c: Revert.
9079         * alpha-bsd-tdep.c: Revert.
9080         * alpha-bsd-nat.c: Revert.
9081         * aix-thread.c: Revert.
9082         * agent.c: Revert.
9083         * addrmap.c: Revert.
9084         * ada-varobj.c: Revert.
9085         * ada-valprint.c: Revert.
9086         * ada-typeprint.c: Revert.
9087         * ada-tasks.c: Revert.
9088         * ada-lang.c: Revert.
9089         * aarch64-tdep.c: Revert.
9090         * aarch64-ravenscar-thread.c: Revert.
9091         * aarch64-newlib-tdep.c: Revert.
9092         * aarch64-linux-tdep.c: Revert.
9093         * aarch64-linux-nat.c: Revert.
9094         * aarch64-fbsd-tdep.c: Revert.
9095         * aarch64-fbsd-nat.c: Revert.
9096         * aarch32-linux-nat.c: Revert.
9097
9098 2019-04-05  Tom Tromey  <tom@tromey.com>
9099
9100         * ft32-tdep.c: Sort headers.
9101         * frv-tdep.c: Sort headers.
9102         * frv-linux-tdep.c: Sort headers.
9103         * frame.c: Sort headers.
9104         * frame-unwind.c: Sort headers.
9105         * frame-base.c: Sort headers.
9106         * fork-child.c: Sort headers.
9107         * findvar.c: Sort headers.
9108         * findcmd.c: Sort headers.
9109         * filesystem.c: Sort headers.
9110         * filename-seen-cache.h: Sort headers.
9111         * filename-seen-cache.c: Sort headers.
9112         * fbsd-tdep.c: Sort headers.
9113         * fbsd-nat.h: Sort headers.
9114         * fbsd-nat.c: Sort headers.
9115         * f-valprint.c: Sort headers.
9116         * f-typeprint.c: Sort headers.
9117         * f-lang.c: Sort headers.
9118         * extension.h: Sort headers.
9119         * extension.c: Sort headers.
9120         * extension-priv.h: Sort headers.
9121         * expprint.c: Sort headers.
9122         * exec.h: Sort headers.
9123         * exec.c: Sort headers.
9124         * exceptions.c: Sort headers.
9125         * event-top.c: Sort headers.
9126         * event-loop.c: Sort headers.
9127         * eval.c: Sort headers.
9128         * elfread.c: Sort headers.
9129         * dwarf2read.h: Sort headers.
9130         * dwarf2read.c: Sort headers.
9131         * dwarf2loc.c: Sort headers.
9132         * dwarf2expr.h: Sort headers.
9133         * dwarf2expr.c: Sort headers.
9134         * dwarf2-frame.c: Sort headers.
9135         * dwarf2-frame-tailcall.c: Sort headers.
9136         * dwarf-index-write.h: Sort headers.
9137         * dwarf-index-write.c: Sort headers.
9138         * dwarf-index-common.c: Sort headers.
9139         * dwarf-index-cache.h: Sort headers.
9140         * dwarf-index-cache.c: Sort headers.
9141         * dummy-frame.c: Sort headers.
9142         * dtrace-probe.c: Sort headers.
9143         * disasm.h: Sort headers.
9144         * disasm.c: Sort headers.
9145         * disasm-selftests.c: Sort headers.
9146         * dictionary.c: Sort headers.
9147         * dicos-tdep.c: Sort headers.
9148         * demangle.c: Sort headers.
9149         * dcache.h: Sort headers.
9150         * dcache.c: Sort headers.
9151         * darwin-nat.h: Sort headers.
9152         * darwin-nat.c: Sort headers.
9153         * darwin-nat-info.c: Sort headers.
9154         * d-valprint.c: Sort headers.
9155         * d-namespace.c: Sort headers.
9156         * d-lang.c: Sort headers.
9157         * ctf.c: Sort headers.
9158         * csky-tdep.c: Sort headers.
9159         * csky-linux-tdep.c: Sort headers.
9160         * cris-tdep.c: Sort headers.
9161         * cris-linux-tdep.c: Sort headers.
9162         * cp-valprint.c: Sort headers.
9163         * cp-support.c: Sort headers.
9164         * cp-namespace.c: Sort headers.
9165         * cp-abi.c: Sort headers.
9166         * corelow.c: Sort headers.
9167         * corefile.c: Sort headers.
9168         * continuations.c: Sort headers.
9169         * completer.h: Sort headers.
9170         * completer.c: Sort headers.
9171         * complaints.c: Sort headers.
9172         * coffread.c: Sort headers.
9173         * coff-pe-read.c: Sort headers.
9174         * cli-out.h: Sort headers.
9175         * cli-out.c: Sort headers.
9176         * charset.c: Sort headers.
9177         * c-varobj.c: Sort headers.
9178         * c-valprint.c: Sort headers.
9179         * c-typeprint.c: Sort headers.
9180         * c-lang.c: Sort headers.
9181         * buildsym.c: Sort headers.
9182         * buildsym-legacy.c: Sort headers.
9183         * build-id.h: Sort headers.
9184         * build-id.c: Sort headers.
9185         * btrace.c: Sort headers.
9186         * bsd-uthread.c: Sort headers.
9187         * breakpoint.h: Sort headers.
9188         * breakpoint.c: Sort headers.
9189         * break-catch-throw.c: Sort headers.
9190         * break-catch-syscall.c: Sort headers.
9191         * break-catch-sig.c: Sort headers.
9192         * blockframe.c: Sort headers.
9193         * block.c: Sort headers.
9194         * bfin-tdep.c: Sort headers.
9195         * bfin-linux-tdep.c: Sort headers.
9196         * bfd-target.c: Sort headers.
9197         * bcache.c: Sort headers.
9198         * ax-general.c: Sort headers.
9199         * ax-gdb.h: Sort headers.
9200         * ax-gdb.c: Sort headers.
9201         * avr-tdep.c: Sort headers.
9202         * auxv.c: Sort headers.
9203         * auto-load.c: Sort headers.
9204         * arm-wince-tdep.c: Sort headers.
9205         * arm-tdep.c: Sort headers.
9206         * arm-symbian-tdep.c: Sort headers.
9207         * arm-pikeos-tdep.c: Sort headers.
9208         * arm-obsd-tdep.c: Sort headers.
9209         * arm-nbsd-tdep.c: Sort headers.
9210         * arm-nbsd-nat.c: Sort headers.
9211         * arm-linux-tdep.c: Sort headers.
9212         * arm-linux-nat.c: Sort headers.
9213         * arm-fbsd-tdep.c: Sort headers.
9214         * arm-fbsd-nat.c: Sort headers.
9215         * arm-bsd-tdep.c: Sort headers.
9216         * arch-utils.c: Sort headers.
9217         * arc-tdep.c: Sort headers.
9218         * arc-newlib-tdep.c: Sort headers.
9219         * annotate.h: Sort headers.
9220         * annotate.c: Sort headers.
9221         * amd64-windows-tdep.c: Sort headers.
9222         * amd64-windows-nat.c: Sort headers.
9223         * amd64-tdep.c: Sort headers.
9224         * amd64-sol2-tdep.c: Sort headers.
9225         * amd64-obsd-tdep.c: Sort headers.
9226         * amd64-obsd-nat.c: Sort headers.
9227         * amd64-nbsd-tdep.c: Sort headers.
9228         * amd64-nbsd-nat.c: Sort headers.
9229         * amd64-nat.c: Sort headers.
9230         * amd64-linux-tdep.c: Sort headers.
9231         * amd64-linux-nat.c: Sort headers.
9232         * amd64-fbsd-tdep.c: Sort headers.
9233         * amd64-fbsd-nat.c: Sort headers.
9234         * amd64-dicos-tdep.c: Sort headers.
9235         * amd64-darwin-tdep.c: Sort headers.
9236         * amd64-bsd-nat.c: Sort headers.
9237         * alpha-tdep.c: Sort headers.
9238         * alpha-obsd-tdep.c: Sort headers.
9239         * alpha-nbsd-tdep.c: Sort headers.
9240         * alpha-mdebug-tdep.c: Sort headers.
9241         * alpha-linux-tdep.c: Sort headers.
9242         * alpha-linux-nat.c: Sort headers.
9243         * alpha-bsd-tdep.c: Sort headers.
9244         * alpha-bsd-nat.c: Sort headers.
9245         * aix-thread.c: Sort headers.
9246         * agent.c: Sort headers.
9247         * addrmap.c: Sort headers.
9248         * ada-varobj.c: Sort headers.
9249         * ada-valprint.c: Sort headers.
9250         * ada-typeprint.c: Sort headers.
9251         * ada-tasks.c: Sort headers.
9252         * ada-lang.c: Sort headers.
9253         * aarch64-tdep.c: Sort headers.
9254         * aarch64-ravenscar-thread.c: Sort headers.
9255         * aarch64-newlib-tdep.c: Sort headers.
9256         * aarch64-linux-tdep.c: Sort headers.
9257         * aarch64-linux-nat.c: Sort headers.
9258         * aarch64-fbsd-tdep.c: Sort headers.
9259         * aarch64-fbsd-nat.c: Sort headers.
9260         * aarch32-linux-nat.c: Sort headers.
9261
9262 2019-04-04  Tom Tromey  <tom@tromey.com>
9263
9264         * varobj.c (varobj_create): Update.
9265         * rust-exp.y (struct rust_parser) <update_innermost_block,
9266         lookup_symbol>: New methods.
9267         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9268         Rename.
9269         (rust_parser::rust_lookup_type)
9270         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9271         * printcmd.c (display_command, do_one_display): Update.
9272         * parser-defs.h (struct parser_state) <parser_state>: Add
9273         "tracker" parameter.
9274         (block_tracker): New member.
9275         (class innermost_block_tracker) <innermost_block_tracker>: Add
9276         "types" parameter.
9277         <reset>: Remove method.
9278         (innermost_block): Don't declare.
9279         (null_post_parser): Update.
9280         * parse.c (innermost_block): Remove global.
9281         (write_dollar_variable): Update.
9282         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9283         Remove "tracker_types" parameter.
9284         (parse_expression): Add "tracker" parameter.
9285         (parse_expression_for_completion): Update.
9286         (null_post_parser): Add "tracker" parameter.
9287         * p-exp.y: Update rules.
9288         * m2-exp.y: Update rules.
9289         * language.h (struct language_defn) <la_post_parser>: Add
9290         "tracker" parameter.
9291         * go-exp.y: Update rules.
9292         * f-exp.y: Update rules.
9293         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9294         parameter.
9295         * d-exp.y: Update rules.
9296         * c-exp.y: Update rules.
9297         * breakpoint.c (set_breakpoint_condition): Create an
9298         innermost_block_tracker.
9299         (watch_command_1): Likewise.
9300         * ada-lang.c (resolve): Add "tracker" parameter.
9301         (resolve_subexp): Likewise.
9302         * ada-exp.y (write_var_from_sym): Update.
9303
9304 2019-04-04  Tom Tromey  <tom@tromey.com>
9305
9306         * type-stack.h: New file.
9307         * type-stack.c: New file.
9308         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9309         type-stack.h.
9310         (insert_into_type_stack, insert_type, push_type, push_type_int)
9311         (insert_type_address_space, pop_type, pop_type_int)
9312         (pop_typelist, pop_type_stack, append_type_stack)
9313         (push_type_stack, get_type_stack, push_typelist)
9314         (follow_type_instance_flags, follow_types): Don't declare.
9315         * parse.c (type_stack): Remove global.
9316         (parse_exp_in_context): Update.
9317         (insert_into_type_stack, insert_type, push_type, push_type_int)
9318         (insert_type_address_space, pop_type, pop_type_int)
9319         (pop_typelist, pop_type_stack, append_type_stack)
9320         (push_type_stack, get_type_stack, push_typelist)
9321         (follow_type_instance_flags, follow_types): Remove (moved to
9322         type-stack.c).
9323         * f-exp.y (type_stack): New global.
9324         Update rules.
9325         (push_kind_type, f_parse): Update.
9326         * d-exp.y (type_stack): New global.
9327         Update rules.
9328         (d_parse): Update.
9329         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9330         Update rules.
9331         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9332         (HFILES_NO_SRCDIR): Add type-stack.h.
9333
9334 2019-04-04  Tom Tromey  <tom@tromey.com>
9335
9336         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9337         (rust_parser::convert_ast_to_expression, rust_parse)
9338         (rust_lex_test_completion, rust_lex_tests): Update.
9339         * parser-defs.h (struct expr_completion_state): New.
9340         (struct parser_state) <parser_state>: Add completion parameter.
9341         <mark_struct_expression, mark_completion_tag>: New methods.
9342         <parse_completion, m_completion_state>: New members.
9343         (prefixify_expression, null_post_parser): Update.
9344         (mark_struct_expression, mark_completion_tag): Don't declare.
9345         * parse.c (parse_completion, expout_last_struct)
9346         (expout_tag_completion_type, expout_completion_name): Remove
9347         globals.
9348         (parser_state::mark_struct_expression)
9349         (parser_state::mark_completion_tag): Now methods.
9350         (prefixify_expression): Add last_struct parameter.
9351         (prefixify_subexp): Likewise.
9352         (parse_exp_1): Update.
9353         (parse_exp_in_context): Add cstate parameter.  Update.
9354         (parse_expression_for_completion): Create an
9355         expr_completion_state.
9356         (null_post_parser): Add "completion" parameter.
9357         * p-exp.y: Update rules.
9358         (yylex): Update.
9359         * language.h (struct language_defn) <la_post_parser>: Add
9360         "completing" parameter.
9361         * go-exp.y: Update rules.
9362         (lex_one_token): Update.
9363         * expression.h (parse_completion): Don't declare.
9364         * d-exp.y: Update rules.
9365         (lex_one_token): Update rules.
9366         * c-exp.y: Update rules.
9367         (lex_one_token): Update.
9368         * ada-lang.c (resolve): Add "parse_completion" parameter.
9369         (resolve_subexp): Likewise.
9370         (ada_resolve_function): Likewise.
9371
9372 2019-04-04  Tom Tromey  <tom@tromey.com>
9373
9374         * parser-defs.h (struct parser_state) <start_arglist,
9375         end_arglist>: New methods.
9376         <arglist_len, m_funcall_chain>: New members.
9377         (arglist_len, start_arglist, end_arglist): Don't declare.
9378         * parse.c (arglist_len, funcall_chain): Remove global.
9379         (start_arglist, end_arglist): Remove functions.
9380         (parse_exp_in_context): Update.
9381         * p-exp.y: Update rules.
9382         * m2-exp.y: Update rules.
9383         * go-exp.y: Update rules.
9384         * f-exp.y: Update rules.
9385         * d-exp.y: Update rules.
9386         * c-exp.y: Update rules.
9387
9388 2019-04-04  Tom Tromey  <tom@tromey.com>
9389
9390         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9391         lex_operator, push_back>: New methods.
9392         Update all rules.
9393         (rust_parser::lex_hex, lex_escape): Rename and update.
9394         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9395         (rust_parser::lex_operator): Rename and update.
9396         (rust_parser::lex_number, rustyylex, rustyyerror)
9397         (rust_lex_test_init, rust_lex_test_sequence)
9398         (rust_lex_test_push_back, rust_lex_tests): Update.
9399         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9400         parameter.
9401         <lexptr, prev_lexptr>: New members.
9402         (lexptr, prev_lexptr): Don't declare.
9403         * parse.c (lexptr, prev_lexptr): Remove globals.
9404         (parse_exp_in_context): Update.
9405         * p-exp.y (yylex, yyerror): Update.
9406         * m2-exp.y (parse_number, yylex, yyerror): Update.
9407         * go-exp.y (lex_one_token, yyerror): Update.
9408         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9409         * d-exp.y (lex_one_token, yyerror): Update.
9410         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9411         (lex_one_token, yyerror): Update.
9412         * ada-lex.l (YY_INPUT): Update.
9413         (rewind_to_char): Update.
9414         * ada-exp.y (yyerror): Update.
9415
9416 2019-04-04  Tom Tromey  <tom@tromey.com>
9417
9418         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9419         * parser-defs.h (struct parser_state) <parser_state>: Add new
9420         parameter.
9421         <comma_terminates>: New member.
9422         (comma_terminates): Don't declare global.
9423         * parse.c (comma_terminates): Remove global.
9424         (parse_exp_in_context): Update.
9425         * p-exp.y (yylex): Update.
9426         * m2-exp.y (yylex): Update.
9427         * go-exp.y (lex_one_token): Update.
9428         * f-exp.y (yylex): Update.
9429         * d-exp.y (lex_one_token): Update.
9430         * c-exp.y (lex_one_token): Update.
9431         * ada-lex.l: Update.
9432
9433 2019-04-04  Tom Tromey  <tom@tromey.com>
9434
9435         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9436         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9437         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9438         * parser-defs.h (paren_depth): Don't declare.
9439         * parse.c (paren_depth): Remove global.
9440         (parse_exp_in_context): Update.
9441         * p-exp.y (paren_depth): New global.
9442         (pascal_parse): Initialize it.
9443         * m2-exp.y (paren_depth): New global.
9444         (m2_parse): Initialize it.
9445         * go-exp.y (paren_depth): New global.
9446         (go_parse): Initialize it.
9447         * f-exp.y (paren_depth): New global.
9448         (f_parse): Initialize it.
9449         * d-exp.y (paren_depth): New global.
9450         (d_parse): Initialize it.
9451         * c-exp.y (paren_depth): New global.
9452         (c_parse): Initialize it.
9453         * ada-lex.l (paren_depth): New global.
9454         (lexer_init): Initialize it.
9455
9456 2019-04-04  Tom Tromey  <tom@tromey.com>
9457
9458         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9459         (rust_parser::convert_ast_to_type)
9460         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9461         * parser-defs.h (struct parser_state) <parser_state>: Add
9462         parameters.  Initialize new members.
9463         <expression_context_block, expression_context_pc>: New members.
9464         * parse.c (expression_context_block, expression_context_pc):
9465         Remove globals.
9466         (parse_exp_in_context): Update.
9467         * p-exp.y: Update all rules.
9468         (yylex): Update.
9469         * m2-exp.y: Update all rules.
9470         (yylex): Update.
9471         * go-exp.y (yylex): Update.
9472         * f-exp.y (yylex): Update.
9473         * d-exp.y: Update all rules.
9474         (yylex): Update.
9475         * c-exp.y: Update all rules.
9476         (lex_one_token, classify_name, yylex, c_parse): Update.
9477         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9478
9479 2019-04-04  Tom Tromey  <tom@tromey.com>
9480
9481         * gdbarch.h, gdbarch.c: Rebuild.
9482         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9483         * stap-probe.h:
9484         (struct stap_parse_info): Replace "parser_state" with
9485         "expr_builder".
9486         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9487         (parser_state): New class.
9488         * parse.c (expr_builder): Rename.
9489         (expr_builder::release): Rename.
9490         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9491         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9492         (write_exp_elt_longcst, write_exp_elt_floatcst)
9493         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9494         (write_exp_string_vector, write_exp_bitstring)
9495         (write_exp_msymbol, mark_struct_expression)
9496         (write_dollar_variable)
9497         (insert_type_address_space, increase_expout_size): Replace
9498         "parser_state" with "expr_builder".
9499         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9500         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9501         "parser_state" with "expr_builder".
9502
9503 2019-04-04  Tom Tromey  <tom@tromey.com>
9504
9505         * rust-exp.y: Replace "parse_language" with method call.
9506         * p-exp.y:
9507         (yylex): Replace "parse_language" with method call.
9508         * m2-exp.y:
9509         (yylex): Replace "parse_language" with method call.
9510         * go-exp.y (classify_name): Replace "parse_language" with method
9511         call.
9512         * f-exp.y (yylex): Replace "parse_language" with method call.
9513         * d-exp.y (lex_one_token): Replace "parse_language" with method
9514         call.
9515         * c-exp.y:
9516         (lex_one_token, classify_name, yylex): Replace "parse_language"
9517         with method call.
9518         * ada-exp.y (find_primitive_type, type_char)
9519         (type_system_address): Replace "parse_language" with method call.
9520
9521 2019-04-04  Tom Tromey  <tom@tromey.com>
9522
9523         * rust-exp.y: Replace "parse_gdbarch" with method call.
9524         * parse.c (write_dollar_variable, insert_type_address_space):
9525         Replace "parse_gdbarch" with method call.
9526         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9527         call.
9528         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9529         call.
9530         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9531         "parse_gdbarch" with method call.
9532         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9533         with method call.
9534         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9535         "parse_gdbarch" with method call.
9536         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9537         "parse_gdbarch" with method call.
9538         * c-exp.y (parse_type, parse_number, classify_name): Replace
9539         "parse_gdbarch" with method call.
9540         * ada-lex.l: Replace "parse_gdbarch" with method call.
9541         * ada-exp.y (parse_type, find_primitive_type, type_char)
9542         (type_system_address): Replace "parse_gdbarch" with method call.
9543
9544 2019-04-04  Tom Tromey  <tom@tromey.com>
9545
9546         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9547         * stap-probe.c (stap_parse_argument): Update.
9548         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9549         initial_size parameter.
9550         * rust-exp.y (rust_lex_tests): Update.
9551         * parse.c (parser_state): Update.
9552         (parse_exp_in_context): Update.
9553         * parser-defs.h (struct parser_state) <parser_state>: Remove
9554         "initial_size" parameter.
9555
9556 2019-04-04  Tom Tromey  <tom@tromey.com>
9557
9558         * parser-defs.h (increase_expout_size): Don't declare.
9559         * parse.c (increase_expout_size): Now static.
9560
9561 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9562
9563         * gnu-nat.c (gnu_nat_target::wait): Fix
9564         target_waitstatus_to_string call.
9565
9566 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9567
9568         * eval.c (evaluate_subexp_standard): Handle internal functions
9569         during Fortran function call handling.
9570
9571 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9572
9573         * NEWS: Mention new internal functions.
9574         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9575         (read_base_type): Use dwarf2_init_complex_target_type.
9576         * value.c (creal_internal_fn): New function.
9577         (cimag_internal_fn): New function.
9578         (_initialize_values): Register new internal functions.
9579
9580 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9581
9582         * infrun.c (stop_all_threads): If debug_infrun, always
9583         trace the wait status after wait_one, using
9584         target_waitstatus_to_string and target_pid_to_str.
9585         (handle_inferior_event): Replace various trace of
9586         wait status kind by a single trace.
9587         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9588         wait status kind image by target_waitstatus_to_string.
9589         * target/waitstatus.c (target_waitstatus_to_string): Fix
9590         obsolete comment.
9591
9592 2019-04-01  Tom Tromey  <tromey@adacore.com>
9593
9594         PR symtab/23331:
9595         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9596
9597 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9598             Pedro Alves  <palves@redhat.com>
9599
9600         * top.c (quit_force): Call 'finalize_values'.
9601         * value.c (finalize_values): New function.
9602         * value.h (finalize_values): Declare.
9603
9604 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9605
9606         * NEWS: Announce $_gdb_major and $_gdb_minor.
9607
9608         * top.c (init_gdb_version_vars): New function.
9609         (gdb_init): Call init_gdb_version_vars.
9610
9611 2019-03-29  Tom Tromey  <tromey@adacore.com>
9612
9613         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9614         help text.  Remove dead code.
9615
9616 2019-03-29  Keith Seitz  <keiths@redhat.com>
9617
9618         From Siddhesh Poyarekar:
9619         * f-lang.h (f77_get_upperbound): Return LONGEST.
9620         (f77_get_lowerbound): Likewise.
9621         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9622         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9623         print them.
9624         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9625         plongest to format print it.
9626         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9627         (f77_get_upperbound): Likewise.
9628         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9629         LOWER_BOUND to LONGEST.
9630         (f77_create_arrayprint_offset_tbl): Likewise.
9631
9632 2019-03-29  Keith Seitz  <keiths@redhat.com>
9633
9634         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9635         %s/pulongest for TYPE_LENGTH instead of %d in format
9636         strings.
9637         * ada-typerint.c (ada_print_type): Likewise.
9638         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9639         * compile/compile-c-support.c (generate_register_struct): Likewise.
9640         * gdbtypes.c (recursive_dump_type): Likewise.
9641         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9642         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9643         instead of %d in format strings.
9644         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9645         to std::min to ULONGEST.
9646         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9647         instead of %d in format strings.
9648         * tracepoint.c (info_scope_command): Likewise.
9649         * typeprint.c (print_offset_data::update)
9650         (print_offset_data::finish): Likewise.
9651         * xtensa-tdep.c (xtensa_store_return_value)
9652         (xtensa_push_dummy_call): Likewise.
9653
9654 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9655
9656         * windows-nat.c (display_selector): Fixed format specifications
9657         for 64-bit Cygwin.
9658
9659 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9660
9661         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9662
9663 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9664
9665         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9666         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9667         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9668         (nios2_linux_init_abi): Install it.
9669
9670 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9671
9672         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9673
9674 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9675
9676         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9677
9678 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9679             Tom Tromey  <tromey@adacore.com>
9680
9681         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9682
9683 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9684
9685         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9686         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9687         method to compute the bounds of range types. Also print "[evaluated]"
9688         if the bounds' values come from a dynamic evaluation.
9689
9690 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9691
9692         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9693         whitespace when pretty printing is on.
9694
9695 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9696
9697         * ppc-linux-nat.c: Add include.
9698
9699 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9700
9701         * NEWS: Mention AArch64 Pointer Authentication.
9702
9703 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9704
9705         * arm-linux-nat.c: Add include.
9706
9707 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9708
9709         * source-cache.c (source_cache::get_source_lines): Re-read
9710         fullname after calling open_source_file.
9711
9712 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9713
9714         * NEWS: Mention TLS support for FreeBSD.
9715
9716 2019-03-25  Tom Tromey  <tromey@adacore.com>
9717
9718         * minsyms.c (BUNCH_SIZE): Update comment.
9719         (~minimal_symbol_reader): Remove old comment.
9720         (compact_minimal_symbols): Update comment.
9721         (minimal_symbol_reader::install): Remove old comment.  Update
9722         other comments.
9723
9724 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9725
9726         * s390-linux-nat.c: Add include.
9727
9728 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9729
9730         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9731         Call linux_get_hwcap.
9732         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9733         Likewise.
9734         (aarch64_linux_get_hwcap): Remove function.
9735         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9736         declaration.
9737         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9738         linux_get_hwcap.
9739         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9740         * linux-tdep.c (linux_get_hwcap): Add function.
9741         (linux_get_hwcap2): Likewise.
9742         * linux-tdep.h (linux_get_hwcap): Add declaration.
9743         (linux_get_hwcap2): Likewise.
9744         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9745         (ppc_linux_get_hwcap2): Likewise.
9746         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9747         linux_get_hwcap.
9748         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9749         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9750         (ppc_linux_nat_target::read_description): Likewise.
9751         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9752         * s390-linux-nat.c: Likewise.
9753         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9754
9755 2019-03-24  Tom Tromey  <tom@tromey.com>
9756
9757         * ada-lang.c (standard_lookup): Simplify initialization.
9758         (ada_lookup_symbol_nonlocal): Simplify return.
9759         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9760         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9761         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9762         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9763         initialization.
9764         * solib.c (solib_global_lookup): Simplify.
9765         * symtab.c (null_block_symbol): Remove.
9766         (symbol_cache_lookup): Simplify returns.
9767         (lookup_language_this): Simplify returns.
9768         (lookup_symbol_aux): Simplify return.
9769         (lookup_local_symbol): Simplify returns.
9770         (lookup_global_symbol_from_objfile): Simplify return.
9771         (lookup_symbol_in_objfile_symtabs)
9772         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9773         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9774         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9775         * cp-namespace.c (cp_lookup_bare_symbol)
9776         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9777         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9778         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9779         (cp_lookup_symbol_via_imports): Simplify initialization.
9780         (find_symbol_in_baseclass): Likewise.
9781         * symtab.h (null_block_symbol): Remove.
9782         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9783         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9784         (d_lookup_symbol_module): Likewise.
9785         (find_symbol_in_baseclass): Simplify initialization.
9786
9787 2019-03-24  Tom Tromey  <tom@tromey.com>
9788
9789         * expression.h: Don't include symtab.h.
9790         (struct block): Forward declare.
9791
9792 2019-03-24  Tom Tromey  <tom@tromey.com>
9793
9794         * c-exp.y (typebase): Remove casts.
9795         * gdbtypes.c (lookup_unsigned_typename, )
9796         (lookup_signed_typename): Remove cast.
9797         * eval.c (parse_to_comma_and_eval): Remove cast.
9798         * parse.c (write_dollar_variable): Remove cast.
9799         * block.h (struct block) <superblock>: Now const.
9800         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9801         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9802         (map_block): Make "block" const.
9803         * symfile.h (struct quick_symbol_functions)
9804         <map_matching_symbols>: Constify block argument to "callback".
9805         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9806         const.
9807         (find_pc_sect_compunit_symtab): Make "b" const.
9808         (find_symbol_at_address): Likewise.
9809         (search_symbols): Likewise.
9810         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9811         (dw2_debug_names_lookup_symbol): Likewise.
9812         (dw2_map_matching_symbols): Update.
9813         * p-valprint.c (pascal_val_print): Remove "block".
9814         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9815         (aux_add_nonlocal_symbols): Make "block" const.
9816         (resolve_subexp): Remove cast.
9817         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9818         const.
9819         (iterate_over_file_blocks): Likewise.
9820         * f-exp.y (%union) <bval>: Remove.
9821         * coffread.c (patch_opaque_types): Make "b" const.
9822         * spu-tdep.c (spu_catch_start): Make "block" const.
9823         * c-valprint.c (print_unpacked_pointer): Remove "block".
9824         * symmisc.c (dump_symtab_1): Make "b" const.
9825         (block_depth): Make "block" const.
9826         * d-exp.y (%union) <bval>: Remove.
9827         * cp-support.h (cp_lookup_rtti_type): Update.
9828         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9829         * psymtab.c (psym_lookup_symbol): Make "block" const.
9830         (maintenance_check_psymtabs): Make "b" const.
9831         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9832         (enumerate_locals, enumerate_args): Update.
9833         * python/py-symtab.c (stpy_global_block): Make "block" const.
9834         (stpy_static_block): Likewise.
9835         * inline-frame.c (block_starting_point_at): Make "new_block"
9836         const.
9837         * block.c (find_block_in_blockvector): Make return type const.
9838         (blockvector_for_pc_sect): Make "b" const.
9839         (find_block_in_blockvector): Make "b" const.
9840
9841 2019-03-23  Tom Tromey  <tom@tromey.com>
9842
9843         * varobj.c (varobj_create): Update.
9844         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9845         * printcmd.c (display_command, do_one_display): Don't reset
9846         innermost_block.
9847         * parser-defs.h (enum innermost_block_tracker_type): Move to
9848         expression.h.
9849         (innermost_block): Update comment.
9850         * parse.c (parse_exp_1): Add tracker_types parameter.
9851         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9852         tracker_types parameter.  Reset innermost_block.
9853         (parse_exp_in_context): Remove.
9854         (parse_expression_for_completion): Update.
9855         * objfiles.c (~objfile): Don't reset expression_context_block or
9856         innermost_block.
9857         * expression.h (enum innermost_block_tracker_type): Move from
9858         parser-defs.h.
9859         (parse_exp_1): Add tracker_types parameter.
9860         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9861         reset innermost_block.
9862
9863 2019-03-23  Tom Tromey  <tom@tromey.com>
9864
9865         * objfiles.h: Include bcache.h.
9866
9867 2019-03-23  Tom Tromey  <tom@tromey.com>
9868
9869         * linespec.c (get_current_search_block): Use
9870         scoped_restore_current_language.
9871         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9872
9873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9874             Jiong Wang  <jiong.wang@arm.com>
9875
9876         * aarch64-linux-tdep.c
9877         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9878         section.
9879         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9880
9881 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9882             Jiong Wang  <jiong.wang@arm.com>
9883
9884         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9885         instructions.
9886         (aarch64_analyze_prologue_test): Add PACIASP test.
9887         (aarch64_prologue_prev_register): Unmask PC value.
9888
9889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9890             Jiong Wang  <jiong.wang@arm.com>
9891
9892         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9893         (aarch64_dwarf2_prev_register): Unmask PC value.
9894         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9895         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9896         DW_CFA_AARCH64_negate_ra_state.
9897         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9898
9899 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9900             Jiong Wang  <jiong.wang@arm.com>
9901
9902         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9903         registers.
9904         (aarch64_pseudo_register_name): Likewise.
9905         (aarch64_pseudo_register_type): Likewise.
9906         (aarch64_pseudo_register_reggroup_p): Likewise.
9907         (aarch64_gdbarch_init): Add pauth registers.
9908         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9909         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9910         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9911         (struct gdbarch_tdep): Add regnum for ra_state.
9912
9913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9914             Jiong Wang  <jiong.wang@arm.com>
9915
9916         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9917
9918 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9919             Jiong Wang  <jiong.wang@arm.com>
9920
9921         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9922         function.
9923         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9924         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9925         (aarch64_gdbarch_init): Add puth registers.
9926         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9927         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9928         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9929
9930 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9931             Jiong Wang  <jiong.wang@arm.com>
9932
9933         * aarch64-linux-nat.c
9934         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9935         * aarch64-linux-tdep.c
9936         (aarch64_linux_core_read_description): Likewise.
9937         (aarch64_linux_get_hwcap): New function.
9938         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9939         (aarch64_linux_get_hwcap): New declaration.
9940
9941 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9942             Jiong Wang  <jiong.wang@arm.com>
9943
9944         * aarch64-linux-nat.c
9945         (aarch64_linux_nat_target::read_description): Add pauth param.
9946         * aarch64-linux-tdep.c
9947         (aarch64_linux_core_read_description): Likewise.
9948         * aarch64-tdep.c (struct target_desc): Add in pauth.
9949         (aarch64_read_description): Add pauth param.
9950         (aarch64_gdbarch_init): Likewise.
9951         * aarch64-tdep.h (aarch64_read_description): Likewise.
9952         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9953         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9954         * features/Makefile: Add new files.
9955         * features/aarch64-pauth.c: New file.
9956         * features/aarch64-pauth.xml: New file.
9957
9958 2019-03-20  Tom Tromey  <tromey@adacore.com>
9959
9960         * infrun.c (handle_inferior_event): Rename from
9961         handle_inferior_event_1.  Create a scoped_value_mark.
9962         (handle_inferior_event): Remove.
9963
9964 2019-03-19  Tom Tromey  <tromey@adacore.com>
9965
9966         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9967         * infrun.h (print_stop_event): Add "displays" parameter.
9968         * infrun.c (print_stop_event): Add "displays" parameter.
9969
9970 2019-03-19  Pedro Alves  <palves@redhat.com>
9971
9972         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9973         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9974         to -1.  Fix TABs vs spaces.
9975         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9976         * tui/tui-out.h (tui_ui_out) Add intro comments.
9977         <m_line, m_start_of_line>: In-class initialize, and add describing
9978         comment.
9979
9980 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9981
9982         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9983         variable names.
9984         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9985
9986 2019-03-18  Pedro Alves  <palves@redhat.com>
9987             Eli Zaretskii <eliz@gnu.org>
9988
9989         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9990         m_line and m_start_of_line.
9991
9992 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9993
9994         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9995         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9996         it returns a newline.  This fixes a regression in TU mode, whereby
9997         the next line is output on the same screen line as the user input.
9998
9999 2019-03-18  Tom Tromey  <tromey@adacore.com>
10000
10001         * minsyms.c (minimal_symbol_reader::install): Remove call to
10002         obstack_blank.
10003
10004 2019-03-18  Pedro Alves  <palves@redhat.com>
10005
10006         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10007         New globals.
10008         (apply_style): New, factored out from ...
10009         (apply_ansi_escape): ... this.  Handle reverse video mode.
10010         (tui_set_reverse_mode): New function.
10011         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10012         * tui/tui-winsource.c (tui_show_source_line): Use
10013         tui_set_reverse_mode instead of setting A_STANDOUT.
10014         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10015         New setter methods.
10016
10017 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10018
10019         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10020         Handle tabs.
10021
10022 2019-03-18  Tom Tromey  <tromey@adacore.com>
10023
10024         * ada-lang.c (empty_array): Add "high" parameter.
10025         (ada_evaluate_subexp): Update.
10026
10027 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10028
10029         * unittests/string_view-selftests.c: Define
10030         _initialize_string_view_selftests unconditionally.
10031
10032 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10033
10034         PR gdb/24350
10035         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10036
10037 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10038
10039         PR gdb/24351
10040         * windows-nat.c (display_selector): Fix format specifiers.
10041
10042 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10043
10044         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10045         tui_refill_source_window instead of tui_refresh_win, to update the
10046         current execution line.  This fixes redisplay of the current line
10047         when stepping through the code with "next" or "step".
10048
10049 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10050
10051         * source-cache.c (source_cache::get_source_lines): Call
10052         find_source_lines to initialize s->nlines.  This fixes vertical
10053         scrolling of TUI source window when the DOWN arrow is pressed.
10054
10055 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10056
10057         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10058         linux-thread-db.c (_initialize_thread_db): Likewise.
10059
10060 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10061
10062         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10063         wclrtoeol in tui_show_source_line".  This reverts changes made in
10064         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10065
10066 2019-03-15  Tom Tromey  <tom@tromey.com>
10067
10068         * symtab.h (struct minimal_symbol): Derive from
10069         general_symbol_info.
10070         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10071         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10072         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10073         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10074         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10075         (MSYMBOL_SEARCH_NAME): Update.
10076         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10077         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10078         * minsyms.c (minimal_symbol_reader::record_full): Update.
10079
10080 2019-03-15  Tom Tromey  <tom@tromey.com>
10081
10082         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10083
10084 2019-03-15  Tom Tromey  <tom@tromey.com>
10085
10086         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10087         unique_xmalloc_ptr.
10088         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10089         Update.
10090         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10091         (build_minimal_symbol_hash_tables)
10092         (minimal_symbol_reader::install): Update.
10093
10094 2019-03-15  Tom Tromey  <tom@tromey.com>
10095
10096         * symtab.c (create_demangled_names_hash): Update.
10097         (symbol_set_names): Update.
10098         * objfiles.h (struct objfile_per_bfd_storage)
10099         <demangled_names_hash>: Now an htab_up.
10100         * objfiles.c (objfile_per_bfd_storage): Simplify.
10101
10102 2019-03-15  Tom Tromey  <tom@tromey.com>
10103
10104         * objfiles.h (struct objfile_per_bfd_storage): Declare
10105         destructor.
10106         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10107         New.
10108         (get_objfile_bfd_data): Use new.  Don't initialize
10109         language_of_main.
10110         (free_objfile_per_bfd_storage): Remove.
10111         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10112
10113 2019-03-15  Tom Tromey  <tom@tromey.com>
10114
10115         * symfile.c (reread_symbols): Update.
10116         * objfiles.c (objfile::objfile): Update.
10117         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10118         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10119         comment.
10120         (minimal_symbol_reader::install): Update.
10121         (terminate_minimal_symbol_table): Remove.
10122         * jit.c (jit_object_close_impl): Update.
10123
10124 2019-03-15  Tom Tromey  <tom@tromey.com>
10125
10126         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10127         initializations.
10128
10129 2019-03-15  Tom Tromey  <tom@tromey.com>
10130
10131         * objfiles.h (struct objfile_per_bfd_storage)
10132         <demangled_hash_languages>: Now a bitset.
10133         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10134         (lookup_minimal_symbol): Update.
10135
10136 2019-03-15  Tom Tromey  <tom@tromey.com>
10137
10138         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10139         Don't return the symbol.
10140         * coffread.c (record_minimal_symbol): Use record_full.
10141
10142 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10143
10144         The MS-Windows port of ncurses fails to switch to a color pair if
10145         one or both of the colors are the implicit default colors.  This
10146         change records the default colors when TUI is initialized, and
10147         then specifies them explicitly when a color pair uses the default
10148         colors.  This allows color styling in TUI mode on MS-Windows.
10149
10150         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10151         ncurses_norm_attr.
10152         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10153         colors in ncurses_norm_attr.
10154         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10155         "none", replace it with the default color recorded in
10156         ncurses_norm_attr.
10157
10158 2019-03-14  Tom Tromey  <tromey@adacore.com>
10159
10160         * source-cache.h (class source_cache) <get_source_lines>: Return
10161         std::string.
10162         * source-cache.c (source_cache::extract_lines): Handle case where
10163         first_pos==npos.  Return std::string.
10164         (source_cache::get_source_lines): Update.
10165
10166 2019-03-14  Tom Tromey  <tromey@adacore.com>
10167
10168         * NEWS: Add item for "style sources" commands.
10169         * source-cache.c (source_cache::get_source_lines): Check
10170         source_styling.
10171         * cli/cli-style.c (source_styling): New global.
10172         (_initialize_cli_style): Add "style sources" commands.
10173         (show_style_sources): New function.
10174         * cli/cli-style.h (source_styling): Declare.
10175
10176 2019-03-14  Pedro Alves  <palves@redhat.com>
10177             Tom Tromey  <tromey@adacore.com>
10178
10179         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10180         * tui/tui-winsource.c (tui_refill_source_window): New function,
10181         from...
10182         (tui_horizontal_source_scroll): ... here.  Move some logic.
10183         * cli/cli-style.c (set_style_enabled): Notify new observable.
10184         * tui/tui-hooks.c (tui_redisplay_source): New function.
10185         (tui_attach_detach_observers): Attach or detach
10186         tui_redisplay_source.
10187         * observable.h (source_styling_changed): New observable.
10188         * observable.c: Define source_styling_changed observable.
10189
10190 2019-03-13  Tom Tromey  <tromey@adacore.com>
10191
10192         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10193         (i386_gnu_nat_target::store_registers): Update.
10194         * target-debug.h (target_debug_print_std_string): New macro.
10195         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10196         * windows-tdep.c (display_one_tib): Update.
10197         * tui/tui-stack.c (tui_make_status_line): Update.
10198         * top.c (print_inferior_quit_action): Update.
10199         * thread.c (thr_try_catch_cmd): Update.
10200         (add_thread_with_info): Update.
10201         (thread_target_id_str): Update.
10202         (thr_try_catch_cmd): Update.
10203         (thread_command): Update.
10204         (thread_find_command): Update.
10205         * record-btrace.c (record_btrace_target::info_record)
10206         (record_btrace_resume_thread, record_btrace_target::resume)
10207         (record_btrace_cancel_resume, record_btrace_step_thread)
10208         (record_btrace_target::wait, record_btrace_target::wait)
10209         (record_btrace_target::wait, record_btrace_target::stop): Update.
10210         * progspace.c (print_program_space): Update.
10211         * process-stratum-target.c
10212         (process_stratum_target::thread_address_space): Update.
10213         * linux-fork.c (linux_fork_mourn_inferior)
10214         (detach_checkpoint_command, info_checkpoints_command)
10215         (linux_fork_context): Update.
10216         (linux_fork_detach): Update.
10217         (class scoped_switch_fork_info): Update.
10218         (delete_checkpoint_command): Update.
10219         * infrun.c (follow_fork_inferior): Update.
10220         (follow_fork_inferior): Update.
10221         (proceed_after_vfork_done): Update.
10222         (handle_vfork_child_exec_or_exit): Update.
10223         (follow_exec): Update.
10224         (displaced_step_prepare_throw): Update.
10225         (displaced_step_restore): Update.
10226         (start_step_over): Update.
10227         (resume_1): Update.
10228         (clear_proceed_status_thread): Update.
10229         (proceed): Update.
10230         (print_target_wait_results): Update.
10231         (do_target_wait): Update.
10232         (context_switch): Update.
10233         (stop_all_threads): Update.
10234         (restart_threads): Update.
10235         (finish_step_over): Update.
10236         (handle_signal_stop): Update.
10237         (switch_back_to_stepped_thread): Update.
10238         (keep_going_pass_signal): Update.
10239         (print_exited_reason): Update.
10240         (normal_stop): Update.
10241         * inferior.c (inferior_pid_to_str): Change return type.
10242         (print_selected_inferior): Update.
10243         (add_inferior): Update.
10244         (detach_inferior): Update.
10245         * dummy-frame.c (fprint_dummy_frames): Update.
10246         * dcache.c (dcache_info_1): Update.
10247         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10248         (btrace_fetch, btrace_clear): Update.
10249         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10250         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10251         type.
10252         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10253         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10254         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10255         * gdbarch.c, gdbarch.h: Rebuild.
10256         * gdbarch.sh (core_pid_to_str): Change return type.
10257         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10258         return type.
10259         (windows_nat_target::pid_to_str): Change return type.
10260         (windows_delete_thread): Update.
10261         (windows_nat_target::attach): Update.
10262         (windows_nat_target::files_info): Update.
10263         * target-delegates.c: Rebuild.
10264         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10265         return type.
10266         (sol_thread_target::pid_to_str): Change return type.
10267         * remote.c (class remote_target) <pid_to_str>: Change return
10268         type.
10269         (remote_target::pid_to_str): Change return type.
10270         (extended_remote_target::attach, remote_target::remote_stop_ns)
10271         (remote_target::remote_notif_remove_queued_reply)
10272         (remote_target::push_stop_reply, remote_target::disable_btrace):
10273         Update.
10274         (extended_remote_target::attach): Update.
10275         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10276         type.
10277         (gdbsim_target::pid_to_str): Change return type.
10278         * ravenscar-thread.c (struct ravenscar_thread_target)
10279         <pid_to_str>: Change return type.
10280         (ravenscar_thread_target::pid_to_str): Change return type.
10281         * procfs.c (class procfs_target) <pid_to_str>: Change return
10282         type.
10283         (procfs_target::pid_to_str): Change return type.
10284         (procfs_target::attach): Update.
10285         (procfs_target::detach): Update.
10286         (procfs_target::fetch_registers): Update.
10287         (procfs_target::store_registers): Update.
10288         (procfs_target::wait): Update.
10289         (procfs_target::files_info): Update.
10290         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10291         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10292         return type.
10293         (nto_procfs_target::pid_to_str): Change return type.
10294         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10295         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10296         return type.
10297         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10298         (exit_lwp): Update.
10299         (attach_proc_task_lwp_callback, get_detach_signal)
10300         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10301         (linux_nat_target::resume, wait_lwp, stop_callback)
10302         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10303         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10304         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10305         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10306         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10307         type.
10308         (inf_ptrace_target::attach): Update.
10309         (inf_ptrace_target::files_info): Update.
10310         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10311         type.
10312         (go32_nat_target::pid_to_str): Change return type.
10313         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10314         (gnu_nat_target::wait): Update.
10315         (gnu_nat_target::wait): Update.
10316         (gnu_nat_target::resume): Update.
10317         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10318         (fbsd_nat_target::wait): Update.
10319         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10320         type.
10321         (darwin_nat_target::attach): Update.
10322         * corelow.c (class core_target) <pid_to_str>: Change return type.
10323         (core_target::pid_to_str): Change return type.
10324         * target.c (normal_pid_to_str): Change return type.
10325         (default_pid_to_str): Likewise.
10326         (target_pid_to_str): Change return type.
10327         (target_translate_tls_address): Update.
10328         (target_announce_detach): Update.
10329         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10330         return type.
10331         (bsd_uthread_target::pid_to_str): Change return type.
10332         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10333         type.
10334         (bsd_kvm_target::pid_to_str): Change return type.
10335         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10336         return type.
10337         (aix_thread_target::pid_to_str): Change return type.
10338         * target.h (struct target_ops) <pid_to_str>: Change return type.
10339         (target_pid_to_str, normal_pid_to_str): Likewise.
10340         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10341         type.
10342         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10343         type.
10344         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10345         return type.
10346         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10347         type.
10348         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10349         type.
10350         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10351         return type.
10352
10353 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10354
10355         * NEWS: Mention that the new default MI version is 3.  Mention
10356         changes to the output of commands and events that deal with
10357         multi-location breakpoints.
10358         * breakpoint.c: Include "mi/mi-out.h".
10359         (print_one_breakpoint): Change output syntax if using MI version
10360         >= 3.
10361         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10362         New.
10363         (mi_multi_location_breakpoint_output_fixed): New.
10364         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10365         (mi_cmd_fix_multi_location_breakpoint_output): New.
10366         (mi_multi_location_breakpoint_output_fixed): New.
10367         * mi/mi-cmds.c (mi_cmds): Register command
10368         -fix-multi-location-breakpoint-output.
10369         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10370         interpreter "mi".
10371
10372 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10373
10374         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10375         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10376         instantiate mi_ui_out based on interpreter name.
10377         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10378         * mi/mi-main.c (mi_load_progress): Likewise.
10379
10380 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10381
10382         * NEWS: Combine separate "New targets" sections for 8.3.
10383
10384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10385
10386         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10387         (ppcfbsd_init_abi): Install gdbarch
10388         "fetch_tls_load_module_address" and "get_thread_local_address"
10389         methods.
10390
10391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10392
10393         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10394         (riscv_fbsd_init_abi): Install gdbarch
10395         "fetch_tls_load_module_address" and "get_thread_local_address"
10396         methods.
10397
10398 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10399
10400         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10401         (i386fbsd_init_abi): Install gdbarch
10402         "fetch_tls_load_module_address" and "get_thread_local_address"
10403         methods.
10404
10405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10406
10407         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10408         (amd64fbsd_init_abi): Install gdbarch
10409         "fetch_tls_load_module_address" and "get_thread_local_address"
10410         methods.
10411
10412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10413
10414         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10415         (struct fbsd_pspace_data): New type.
10416         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10417         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10418         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10419         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10420         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10421
10422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10423
10424         * gdbtypes.c (lookup_struct_elt): New function.
10425         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10426         * gdbtypes.h (struct struct_elt): New type.
10427         (lookup_struct_elt): New prototype.
10428
10429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10430
10431         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10432         remove disabled code block.
10433
10434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10435
10436         * gdbarch.sh (get_thread_local_address): New method.
10437         * gdbarch.h, gdbarch.c: Regenerate.
10438         * target.c (target_translate_tls_address): Use
10439         gdbarch_get_thread_local_address if present instead of
10440         target::get_thread_local_address.
10441
10442 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10443
10444         * target.h (target::get_thread_local_address): Update comment.
10445
10446 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10447
10448         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10449         objfile->separate_debug_objfile_backlink if not NULL.
10450
10451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10452
10453         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10454         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10455         (amd64bsd_store_inferior_registers): Likewise.
10456         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10457         Enable segment base registers.
10458         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10459         PT_GETFSBASE and PT_GETGSBASE.
10460         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10461         PT_SETGSBASE.
10462         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10463         segment base registers.
10464         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10465
10466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10467
10468         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10469         Update calls to i386_target_description to add 'segments'
10470         parameter.
10471         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10472         add segment base registers.
10473         * arch/i386.c (i386_create_target_description): Add 'segments'
10474         parameter to enable segment base registers.
10475         * arch/i386.h (i386_create_target_description): Likewise.
10476         * features/i386/32bit-segments.xml: New file.
10477         * features/i386/32bit-segments.c: Generate.
10478         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10479         call to i386_target_description to add 'segments' parameter.
10480         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10481         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10482         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10483         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10484         if feature is present.
10485         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10486         Add 'segments' parameter to call to i386_target_description.
10487         (i386_target_description): Add 'segments' parameter to enable
10488         segment base registers.
10489         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10490         to call to i386_target_description.
10491         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10492         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10493         Define I386_NUM_REGS.
10494         (i386_target_description): Add 'segments' parameter to enable
10495         segment base registers.
10496
10497 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10498
10499         PR/24325
10500         * source-cache.c: #undef open and close, to avoid unresolved
10501         externals during linking.
10502
10503 2019-03-12  Tom Tromey  <tromey@adacore.com>
10504
10505         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10506         const.  Add initializers.
10507         (_initialize_remote): Don't initialize ptid globals.
10508
10509 2019-03-12  Pedro Alves  <palves@redhat.com>
10510
10511         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10512
10513 2019-03-12  Pedro Alves  <palves@redhat.com>
10514
10515         * cp-name-parser.y (main): Remove unused 'len' variable.
10516
10517 2019-03-12  Tom Tromey  <tromey@adacore.com>
10518
10519         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10520         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10521
10522 2019-03-12  Tom Tromey  <tromey@adacore.com>
10523
10524         * linux-nat.c (iterate_over_lwps): Update.
10525         (stop_callback): Remove parameter.
10526         (stop_wait_callback, detach_callback, resume_set_callback)
10527         (select_singlestep_lwp_callback, set_ignore_sigint)
10528         (status_callback, resumed_callback, resume_clear_callback)
10529         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10530         data parameter.
10531         (linux_nat_target::detach, linux_nat_target::resume)
10532         (linux_stop_and_wait_all_lwps, select_event_lwp)
10533         (linux_nat_filter_event, linux_nat_wait_1)
10534         (linux_nat_target::kill, linux_nat_target::stop)
10535         (linux_nat_target::stop): Update.
10536         (linux_nat_resume_callback): Change type.
10537         (resume_stopped_resumed_lwps, count_events_callback)
10538         (select_event_lwp_callback): Likewise.
10539         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10540         * arm-linux-nat.c (struct update_registers_data): Remove.
10541         (update_registers_callback): Change type.
10542         (arm_linux_insert_hw_breakpoint1): Update.
10543         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10544         parameter.
10545         (x86_linux_dr_set_addr): Update.
10546         (x86_linux_dr_set_control): Update.
10547         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10548         (iterate_over_lwps): Use gdb::function_view.
10549         * nat/aarch64-linux-hw-point.c (struct
10550         aarch64_dr_update_callback_param): Remove.
10551         (debug_reg_change_callback): Change type.
10552         (aarch64_notify_debug_reg_change): Update.
10553         * s390-linux-nat.c (s390_refresh_per_info): Update.
10554
10555 2019-03-11  Tom Tromey  <tromey@adacore.com>
10556
10557         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10558         redundant assignment to "this_cu".
10559
10560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10561
10562         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10563
10564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10565
10566         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10567         from...
10568         (rank_one_type): ... this.
10569
10570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10571
10572         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10573         from...
10574         (rank_one_type): ... this.
10575
10576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10577
10578         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10579         from...
10580         (rank_one_type): ... this.
10581
10582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10583
10584         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10585         from...
10586         (rank_one_type): ... this.
10587
10588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10589
10590         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10591         from...
10592         (rank_one_type): ... this.
10593
10594 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10595
10596         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10597         from...
10598         (rank_one_type): ... this.
10599
10600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10601
10602         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10603         from...
10604         (rank_one_type): ... this.
10605
10606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10607
10608         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10609         from...
10610         (rank_one_type): ... this.
10611
10612 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10613
10614         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10615         from...
10616         (rank_one_type): ... this.
10617
10618 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10619
10620         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10621         from...
10622         (rank_one_type): ... this.
10623
10624 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10625
10626         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10627         from...
10628         (rank_one_type): ... this.
10629
10630 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10631
10632         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10633         from...
10634         (rank_one_type): ... this.
10635
10636 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10637
10638         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10639         inferior-events' shows the example events.
10640
10641 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10642
10643         Support styling on native MS-Windows console
10644
10645         PR/24315
10646         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10647         on MS-Windows if $TERM is not defined.
10648
10649         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10650
10651         * posix-hdep.c (gdb_console_fputs):
10652         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10653         functions.
10654         * ui-file.h (gdb_console_fputs): Add prototype.
10655
10656         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10657         back to fputs only if the former returns zero.
10658
10659 2019-03-07  Tom Tromey  <tom@tromey.com>
10660
10661         * symmisc.c (print_symbol_bcache_statistics): Update.
10662         (print_objfile_statistics): Update.
10663         * symfile.c (allocate_symtab): Update.
10664         * stabsread.c: Don't include bcache.h.
10665         * psymtab.h (struct psymbol_bcache): Don't declare.
10666         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10667         (psymbol_bcache_init, psymbol_bcache_free)
10668         (psymbol_bcache_get_bcache): Don't declare.
10669         * psymtab.c (struct psymbol_bcache): Remove.
10670         (psymtab_storage::psymtab_storage): Update.
10671         (psymtab_storage::~psymtab_storage): Update.
10672         (psymbol_bcache_init, psymbol_bcache_free)
10673         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10674         (add_psymbol_to_bcache): Update.
10675         (allocate_psymtab): Update.
10676         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10677         macro_cache>: No longer pointers.
10678         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10679         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10680         * macrotab.c (macro_bcache): Update.
10681         * macroexp.c: Don't include bcache.h.
10682         * gdbtypes.c (check_types_worklist): Update.
10683         (types_deeply_equal): Remove TRY/CATCH.  Update.
10684         * elfread.c (elf_symtab_read): Update.
10685         * dwarf2read.c: Don't include bcache.h.
10686         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10687         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10688         (print_bcache_statistics, bcache_memory_used): Don't declare.
10689         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10690         methods.  Rename all data members.
10691         * bcache.c (struct bcache): Move to bcache.h.
10692         (bcache::expand_hash_table): Rename from expand_hash_table.
10693         (bcache): Remove.
10694         (bcache::insert): Rename from bcache_full.
10695         (bcache::compare): Rename from bcache_compare.
10696         (bcache_xmalloc): Remove.
10697         (bcache::~bcache): Rename from bcache_xfree.
10698         (bcache::print_statistics): Rename from print_bcache_statistics.
10699         (bcache::memory_used): Rename from bcache_memory_used.
10700
10701 2019-03-07  Pedro Alves  <palves@redhat.com>
10702
10703         * infrun.c (normal_stop): Also check for
10704         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10705
10706 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10707
10708         * f-lang.c (value_from_host_double): Moved to...
10709         * value.c (value_from_host_double): ...here.
10710         * value.h (value_from_host_double): Declare.
10711         * guile/scm-math.c (vlscm_convert_typed_number): Use
10712         value_from_host_double.
10713         (vlscm_convert_number): Likewise.
10714         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10715         * python/py-value.c (convert_value_from_python): Likewise.
10716
10717 2019-03-06  Tom Tromey  <tom@tromey.com>
10718
10719         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10720
10721 2019-03-06  Tom Tromey  <tom@tromey.com>
10722
10723         * utils.h (free_current_contents): Don't declare.
10724         * utils.c (free_current_contents): Remove.
10725
10726 2019-03-06  Tom Tromey  <tom@tromey.com>
10727
10728         * top.c (quit_force): Update.
10729         * main.c (captured_command_loop): Update.
10730         * common/new-op.c (operator new): Update.
10731         * common/common-exceptions.c (struct catcher)
10732         <save_cleanup_chain>: Remove member.
10733         (exceptions_state_mc_init): Update.
10734         (exception_try_scope_entry): Return nullptr.
10735         (exception_try_scope_exit, exception_rethrow)
10736         (throw_exception_sjlj, throw_exception_cxx): Update.
10737         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10738         (all_cleanups, do_cleanups, discard_cleanups)
10739         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10740         (restore_cleanups, restore_final_cleanups): Don't declare.
10741         (do_final_cleanups): Remove parameter.
10742         * common/cleanups.c (cleanup_chain, make_cleanup)
10743         (make_cleanup_dtor, all_cleanups, do_cleanups)
10744         (discard_my_cleanups, discard_cleanups)
10745         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10746         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10747         (null_cleanup): Remove.
10748         (do_final_cleanups): Remove parameter.
10749
10750 2019-03-06  Tom Tromey  <tom@tromey.com>
10751
10752         * remote.c (remote_target::remote_parse_stop_reply): Use
10753         unique_xmalloc_ptr.
10754
10755 2019-03-06  Tom Tromey  <tom@tromey.com>
10756
10757         * stabsread.c (struct stabs_field_info): Rename from field_info.
10758         <list, fnlist>: Add initializers.
10759         <obstack>: New member.
10760         (read_member_functions, read_struct_fields, read_baseclasses):
10761         Allocate on obstack.  Don't use cleanups.
10762         (read_one_struct_field, read_member_functions, read_struct_fields)
10763         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10764         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10765         (read_struct_type): Update.
10766
10767 2019-03-06  Tom Tromey  <tom@tromey.com>
10768
10769         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10770         * common/filestuff.h (make_cleanup_close): Don't declare.
10771         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10772         Remove.
10773
10774 2019-03-06  Tom Tromey  <tom@tromey.com>
10775
10776         * solib-aix.c: Use make_scope_exit.
10777
10778 2019-03-06  Tom Tromey  <tom@tromey.com>
10779
10780         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10781         Use make_scope_exit.
10782
10783 2019-03-06  Tom Tromey  <tom@tromey.com>
10784
10785         * solib-svr4.c (disable_probes_interface): Remove parameter.
10786         (svr4_handle_solib_event): Use make_scope_exit.
10787
10788 2019-03-06  Tom Tromey  <tom@tromey.com>
10789
10790         * remote.c (struct stop_reply_deleter): Remove.
10791         (stop_reply_up): Update.
10792         (struct stop_reply): Derive from notif_event.  Don't typedef.
10793         <regcache>: Now a std::vector.
10794         (stop_reply_xfree): Remove.
10795         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10796         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10797         (remote_target::discard_pending_stop_replies): Use delete.
10798         (remote_target::remote_parse_stop_reply): Update.
10799         (remote_target::process_stop_reply): Update.
10800         * remote-notif.h (struct notif_event): Add virtual destructor.
10801         Remove "dtr" member.
10802         (struct notif_client) <alloc_event>: Return a unique_ptr.
10803         (notif_event_xfree): Don't declare.
10804         (notif_event_up): New typedef.
10805         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10806         (notif_event_xfree, do_notif_event_xfree): Remove.
10807         (remote_notif_state_xfree): Update.
10808
10809 2019-03-06  Tom Tromey  <tom@tromey.com>
10810
10811         * infrun.c (displaced_step_clear_cleanup): Now a
10812         forward_scope_exit type.
10813         (displaced_step_prepare_throw): Update.
10814         (displaced_step_fixup): Update.
10815
10816 2019-03-06  Tom Tromey  <tom@tromey.com>
10817
10818         * inferior.h (class inferior): Update comment.
10819         * gdbthread.h (class thread_info): Update comment.
10820
10821 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10822             Tom Tromey  <tom@tromey.com>
10823
10824         * stabsread.h (struct stab_section_list): Remove.
10825         (coffstab_build_psymtabs): Update.
10826         * dbxread.c (symbuf_sections): Now a std::vector.
10827         (sect_idx): New global.
10828         (fill_symbuf): Update.
10829         (coffstab_build_psymtabs): Change type of stabsects parameter.
10830         Update.
10831         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10832         std::vector.
10833         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10834         (coff_locate_sections): Update.
10835         (coff_symfile_read): Remove cleanups.  Update.
10836         (init_stringtab): Add storage parameter.
10837         (free_stringtab, free_stringtab_cleanup): Remove.
10838         (init_lineno): Add storage parameter.
10839         (free_linetab, free_linetab_cleanup): Remove.
10840
10841 2019-03-06  Pedro Alves  <palves@redhat.com>
10842
10843         * linux-fork.c (fork_info::clobber_regs): Delete.
10844         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10845         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10846         comment.  Adjust.
10847         (scoped_switch_fork_info::scoped_switch_fork_info)
10848         (checkpoint_command, linux_fork_context): Adjust
10849         fork_save_infrun_state calls.
10850
10851 2019-03-06  Pedro Alves  <palves@redhat.com>
10852
10853         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10854         (inf_has_multiple_threads): Return 'bool' and rewrite using
10855         inferior_info::threads().
10856
10857 2019-03-06  Pedro Alves  <palves@redhat.com>
10858
10859         * linux-fork.c: Include <list>.
10860         (fork_list): Now a std::list instance.
10861         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10862         (forks_exist_p, find_last_fork): Adjust.
10863         (new_fork): Delete.
10864         (one_fork_p): New.
10865         (add_fork): Adjust.
10866         (free_fork): Delete, folded into fork_info::~fork_info().
10867         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10868         Adjust.
10869         (init_fork_list): Delete.
10870         (linux_fork_killall, linux_fork_mourn_inferior)
10871         (linux_fork_detach, info_checkpoints_command): Adjust.
10872         (_initialize_linux_fork): No longer call init_fork_list.
10873
10874 2019-03-06  Pedro Alves  <palves@redhat.com>
10875
10876         * linux-fork.c (new_fork): New, split out of ...
10877         (add_fork): ... this.  Return void.  Move "first fork" special
10878         case from here, to ...
10879         (checkpoint_command): ... here.
10880         * linux-linux.h (add_fork): Return void.
10881
10882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10883
10884         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10885
10886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10887             Chris January  <chris.january@arm.com>
10888             David Lecomber  <david.lecomber@arm.com>
10889
10890         * f-exp.y: New token, UNOP_INTRINSIC.
10891         (exp): New pattern using UNOP_INTRINSIC token.
10892         (f77_keywords): Add 'abs' keyword.
10893         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10894         (value_from_host_double): New function.
10895         (evaluate_subexp_f): Support UNOP_ABS.
10896
10897 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10898
10899         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10900         types.
10901
10902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10903
10904         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10905         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10906         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10907
10908 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10909
10910         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10911
10912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10913             Chris January  <chris.january@arm.com>
10914
10915         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10916         * f-exp.y: Define 'KIND' token.
10917         (exp): New pattern for KIND expressions.
10918         (ptype): Handle types with a kind extension.
10919         (direct_abs_decl): Extend to spot kind extensions.
10920         (f77_keywords): Add 'kind' to the list.
10921         (push_kind_type): New function.
10922         (convert_to_kind_type): New function.
10923         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10924         * parse.c (operator_length_standard): Likewise.
10925         * parser-defs.h (enum type_pieces): Add tp_kind.
10926         * std-operator.def: Add UNOP_KIND.
10927
10928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10929
10930         * f-exp.y (f_parse): Set yydebug.
10931
10932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10933
10934         * f-lang.c (evaluate_subexp_f): New function.
10935         (exp_descriptor_f): New global.
10936         (f_language_defn): Use exp_descriptor_f instead of
10937         exp_descriptor_standard.
10938
10939 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10940
10941         * f-exp.y (struct token): Add comments.
10942         (dot_ops): Remove uppercase versions and the end marker.
10943         (f77_keywords): Likewise.
10944         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10945         entries in the dot_ops array are case insensitive, and use
10946         strncasecmp to compare strings.  Also some whitespace cleanup in
10947         this area.  Similar for the f77_keywords array, except entries in
10948         this list might be case sensitive.
10949
10950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10951
10952         * f-exp.y (struct f77_boolean_val): Add comments.
10953         (boolean_values): Remove uppercase versions, and end marker.
10954         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10955         and use strncasecmp to achieve case insensitivity.  Additionally,
10956         perform whitespace cleanup around this code.
10957
10958 2019-03-06  Tom Tromey  <tromey@adacore.com>
10959
10960         * remote-sim.c (gdbsim_target_open): Use result of
10961         gdb_argv::release.
10962
10963 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10964         Dirk Schubert  <dirk.schubert@arm.com>
10965         Chris January  <chris.january@arm.com>
10966
10967         * eval.c (evaluate_subexp_standard): Call Fortran argument
10968         wrapping logic.
10969         * f-lang.c (struct value): A value which can be passed into a
10970         Fortran function call.
10971         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10972         where appropriate.
10973         (struct type): Value ready for a Fortran function call.
10974         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10975         is needed.
10976         * f-lang.h (fortran_argument_convert): Declaration.
10977         (fortran_preserve_arg_pointer): Declaration.
10978         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10979
10980 2019-03-05  Tom Tromey  <tromey@adacore.com>
10981
10982         * python/py-prettyprint.c (print_string_repr): Remove #if.
10983         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10984
10985 2019-03-05  Tom Tromey  <tromey@adacore.com>
10986
10987         * target.c (the_dummy_target): Move later.  Change type to
10988         "dummy_target".
10989         (initialize_targets): Don't initialize the_dummy_target.
10990
10991 2019-03-05  Tom Tromey  <tromey@adacore.com>
10992
10993         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10994         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10995
10996 2019-03-05  Tom Tromey  <tromey@adacore.com>
10997
10998         * windows-nat.c (windows_nat_target::attach)
10999         (windows_nat_target::detach): Don't call gdb_flush.
11000         * valprint.c (generic_val_print, val_print, val_print_string):
11001         Don't call gdb_flush.
11002         * utils.c (defaulted_query): Don't call gdb_flush.
11003         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11004         * target.c (target_announce_detach): Don't call gdb_flush.
11005         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11006         * remote.c (extended_remote_target::attach): Don't call
11007         gdb_flush.
11008         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11009         * printcmd.c (do_examine): Don't call gdb_flush.
11010         (info_display_command): Don't call gdb_flush.
11011         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11012         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11013         * memattr.c (info_mem_command): Don't call gdb_flush.
11014         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11015         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11016         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11017         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11018         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11019         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11020         (gnu_nat_target::detach): Don't call gdb_flush.
11021         * f-valprint.c (f_val_print): Don't call gdb_flush.
11022         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11023         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11024         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11025         gdb_flush.
11026         * c-valprint.c (c_val_print): Don't call gdb_flush.
11027         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11028
11029 2019-03-05  Tom Tromey  <tromey@adacore.com>
11030
11031         * varobj.c (update_dynamic_varobj_children): Update.
11032         (install_default_visualizer): Use reset, not release.
11033         * value.c (set_internalvar): Update.
11034         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11035         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11036         ATTRIBUTE_UNUSED_RESULT.
11037
11038 2019-03-05  Tom Tromey  <tromey@adacore.com>
11039
11040         * remote.c (class scoped_remote_fd) <release>: Add
11041         ATTRIBUTE_UNUSED_RESULT.
11042
11043 2019-03-05  Tom Tromey  <tromey@adacore.com>
11044
11045         * macroexp.c (struct macro_buffer) <release>: Add
11046         ATTRIBUTE_UNUSED_RESULT.
11047
11048 2019-03-05  Tom Tromey  <tromey@adacore.com>
11049
11050         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11051         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11052         ATTRIBUTE_UNUSED_RESULT.
11053
11054 2019-03-05  Tom Tromey  <tromey@adacore.com>
11055
11056         * common/scoped_fd.h (class scoped_fd) <release>: Add
11057         ATTRIBUTE_UNUSED_RESULT.
11058
11059 2019-03-05  Tom Tromey  <tromey@adacore.com>
11060
11061         * parser-defs.h (struct parser_state) <release>: Add
11062         ATTRIBUTE_UNUSED_RESULT.
11063
11064 2019-03-05  Tom Tromey  <tromey@adacore.com>
11065
11066         * utils.h (class gdb_argv) <release>: Add
11067         ATTRIBUTE_UNUSED_RESULT.
11068         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11069
11070 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11071
11072         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11073         for-loop range, to avoid compiler warnings.
11074
11075         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11076         avoid compiler warnings about unused variables.
11077
11078         * NEWS: Mention end of support for native debugging on MS-Windows
11079         before XP.
11080
11081         PR gdb/24292
11082         * common/netstuff.c:
11083         * gdbserver/gdbreplay.c
11084         * gdbserver/remote-utils.c:
11085         * ser-tcp.c:
11086         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11087         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11088         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11089         'getaddrinfo' and 'freeaddrinfo' were not available before
11090         Windows XP, and mingw.org's MinGW headers by default define
11091         _WIN32_WINNT to 0x500.
11092
11093 2019-03-01  Gary Benson <gbenson@redhat.com>
11094
11095         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11096
11097 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11098             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11099
11100         PR gdb/8527
11101         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11102         set_sigint_trap, clear_sigint_trap.
11103
11104 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11105
11106         * target.c (target_detach): Clear the regcache and the
11107         frame cache.
11108
11109 2019-02-27  Pedro Alves  <palves@redhat.com>
11110
11111         * utils.c (set_screen_size): When we cap the height/width sizes,
11112         tweak the corresponding command variable to show "unlimited":
11113
11114 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11115             Pedro Alves  <palves@redhat.com>
11116
11117         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11118         before calling rl_set_screen_size.
11119
11120 2019-02-27  Tom Tromey  <tromey@adacore.com>
11121
11122         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11123         define.
11124         * python/py-value.c: Remove Python 2.4 workaround.
11125         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11126         workaround.
11127         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11128         Python 2.4 workaround.
11129         * python/python-internal.h: Remove Python 2.4 comment.
11130         (Py_ssize_t): Don't define.
11131         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11132         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11133         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11134         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11135         * python/python.c (do_start_initialization): Remove Python 2.4
11136         workaround.
11137         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11138         (print_children): Remove Python 2.4 workaround.
11139         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11140         workaround.
11141         (CHARBUFFERPROC_NAME): Remove.
11142         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11143         Python 2.4 workaround.
11144
11145 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11146
11147         * NEWS: Note minimum Python version.
11148
11149 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11150
11151         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11152         code from these functions.  Remove corresponding ifdefs.  Use
11153         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11154         Remove gotos and target of gotos.
11155         (infpy_search_memory): Likewise.
11156
11157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11158
11159         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11160         (hppa_gdbarch_init): Don't register deleted functions with
11161         gdbarch.
11162
11163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11164
11165         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11166         (h8300_unwind_sp): Delete.
11167         (h8300_dummy_id): Delete.
11168         (h8300_gdbarch_init): Don't register deleted functions with
11169         gdbarch.
11170
11171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11172
11173         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11174         (ft32_unwind_pc): Delete.
11175         (ft32_unwind_sp): Delete.
11176         (ft32_gdbarch_init): Don't register deleted functions with
11177         gdbarch.
11178
11179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11180
11181         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11182         (frv_unwind_pc): Delete.
11183         (frv_unwind_sp): Delete.
11184         (frv_gdbarch_init): Don't register deleted functions with
11185         gdbarch.
11186
11187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11188
11189         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11190         (riscv_unwind_pc): Delete.
11191         (riscv_unwind_sp): Delete.
11192         (riscv_gdbarch_init): Don't register deleted functions with
11193         gdbarch.
11194
11195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11196
11197         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11198         (csky_unwind_pc): Delete.
11199         (csky_unwind_sp): Delete.
11200         (csky_gdbarch_init): Don't register deleted functions with
11201         gdbarch.
11202
11203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11204
11205         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11206         (cris_unwind_pc): Delete.
11207         (cris_unwind_sp): Delete.
11208         (cris_gdbarch_init): Don't register deleted functions with
11209         gdbarch.
11210
11211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11212
11213         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11214         (bfin_unwind_pc): Delete.
11215         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11216
11217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11218
11219         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11220         (arm_unwind_pc): Delete.
11221         (arm_unwind_sp): Delete.
11222         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11223
11224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11225
11226         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11227         (arc_unwind_pc): Delete.
11228         (arc_unwind_sp): Delete.
11229         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11230
11231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11232
11233         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11234         (alpha_unwind_pc): Delete.
11235         (alpha_gdbarch_init): Don't register deleted functions with
11236         gdbarch.
11237
11238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11239
11240         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11241         (aarch64_unwind_pc): Delete.
11242         (aarch64_unwind_sp): Delete.
11243         (aarch64_gdbarch_init): Don't register deleted functions with
11244         gdbarch.
11245
11246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11247
11248         * gdbtypes.c (type_align): Don't consider static members when
11249         computing structure alignment.
11250
11251 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11252
11253         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11254         return 0 for other types.
11255         * arch-utils.c (default_type_align): Always return 0.
11256         * gdbarch.h: Regenerate.
11257         * gdbarch.sh (type_align): Extend comment.
11258         * gdbtypes.c (type_align): Add additional comments, always call
11259         gdbarch_type_align before applying the default rules.
11260         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11261         generic code will then apply a suitable default.
11262         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11263         types, return 0 for other types.
11264
11265 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11266
11267         * NEWS: Create a new section for the next release branch.
11268         Rename the section of the current branch, now that it has
11269         been cut.
11270
11271 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11272
11273         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11274         * version.in: Bump version to 8.3.50.DATE-git.
11275
11276 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11277
11278         * aix-thread.c (ptid_cmp): Remove unused variable.
11279         (get_signaled_thread): Likewise.
11280         (store_regs_user_thread): Likewise.
11281         (store_regs_kernel_thread): Likewise.
11282         (fetch_regs_kernel_thread): Remove shadowed variable.
11283
11284 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11285
11286         * features/riscv/32bit-cpu.xml: Add register numbers.
11287         * features/riscv/32bit-fpu.c: Regenerate.
11288         * features/riscv/32bit-fpu.xml: Add register numbers.
11289         * features/riscv/64bit-cpu.xml: Add register numbers.
11290         * features/riscv/64bit-fpu.c: Regenerate.
11291         * features/riscv/64bit-fpu.xml: Add register numbers.
11292
11293 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11294
11295         * NEWS: Mention two argument form of gdb.Value constructor.
11296         * python/py-value.c (convert_buffer_and_type_to_value): New
11297         function.
11298         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11299         Add support for handling an optional second argument.  Call
11300         convert_buffer_and_type_to_value as appropriate.
11301         * python/python-internal.h (Py_buffer_deleter): New struct.
11302         (Py_buffer_up): New typedef.
11303
11304 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11305
11306         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11307         instead of releasing ownership.
11308
11309 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11310
11311         * dwarf2read.c (open_and_init_dwp_file): Call
11312         elf_numsections instead of bfd_count_sections to initialize
11313         dwp_file->num_sections.
11314
11315 2019-02-25  Tom Tromey  <tromey@adacore.com>
11316
11317         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11318
11319 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11320
11321         * gcore.in: Add '--readnever' option when invoking GDB.
11322
11323 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11324
11325         * MAINTAINERS: Update my email address.
11326
11327 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11328
11329         * build-id.c (build_id_to_debug_bfd_1): New function.
11330         (build_id_to_debug_bfd): Look for separate debug file in
11331         sysroot.
11332
11333 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11334
11335         * gdbarch.sh: Update the copyright year range that is placed into
11336         generated files.
11337
11338 2019-02-22  Keith Seitz  <keiths@redhat.com>
11339
11340         PR symtab/23853
11341         * linespec.c (create_sals_line_offset): Search for the default
11342         symtab's filename instead of its fullname.
11343
11344 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11345
11346         * NEWS: Update style defaults.
11347
11348 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11349
11350         * main.c (captured_main_1): Disable styling in batch mode.
11351
11352 2019-02-20  Tom Tromey  <tom@tromey.com>
11353
11354         * symtab.c (symtab_symbol_info): Fix typos.
11355
11356 2019-02-20  Tom Tromey  <tromey@adacore.com>
11357
11358         * findcmd.c (_initialize_mem_search): Use upper case for
11359         metasyntactic variables.
11360
11361 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11362
11363         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11364         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11365
11366 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11367
11368         * top.h (source_file_name): Change to std::string.
11369         * top.c (source_file_name): Likewise.
11370         (command_line_input): Adjust.
11371         * cli/cli-script.c (script_from_file): Adjust.
11372
11373 2019-02-19  Tom Tromey  <tromey@adacore.com>
11374
11375         * ravenscar-thread.c
11376         (ravenscar_thread_target::update_thread_list): Don't call
11377         ada_build_task_list.
11378         * ada-lang.h (ada_build_task_list): Don't declare.
11379         * ada-tasks.c (struct ada_tasks_inferior_data)
11380         <task_list_valid_p>: Now bool.
11381         (read_known_tasks, ada_task_list_changed)
11382         (ada_tasks_invalidate_inferior_data): Update.
11383         (read_known_tasks_array): Return bool.
11384         (read_known_tasks_list): Likewise.
11385         (read_known_tasks): Return void.
11386         (ada_build_task_list): Now static.
11387
11388 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11389
11390         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11391         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11392
11393 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11394
11395         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11396         variant for ada_tasks_pspace_data_handle and
11397         ada_tasks_inferior_data_handle.
11398         (ada_tasks_pspace_data_cleanup): New function.
11399         (ada_tasks_inferior_data_cleanup): New function.
11400
11401 2019-02-17  Tom Tromey  <tom@tromey.com>
11402
11403         * macrotab.h (macro_source_fullname): Return a std::string.
11404         * macrotab.c (macro_include, check_for_redefinition)
11405         (macro_undef, macro_lookup_definition, foreach_macro)
11406         (foreach_macro_in_scope): Update.
11407         (macro_source_fullname): Return a std::string.
11408         * macrocmd.c (show_pp_source_pos): Update.
11409
11410 2019-02-17  Tom Tromey  <tom@tromey.com>
11411
11412         * macrocmd.c (show_pp_source_pos): Style the file names.
11413
11414 2019-02-17  Tom Tromey  <tom@tromey.com>
11415
11416         PR tui/24197:
11417         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11418
11419 2019-02-17  Tom Tromey  <tom@tromey.com>
11420
11421         * ada-lang.c (user_select_syms): Use filtered printing.
11422         * utils.c (wrap_style): New global.
11423         (desired_style): Remove.
11424         (emit_style_escape): Add stream parameter.
11425         (set_output_style, reset_terminal_style, prompt_for_continue):
11426         Update.
11427         (flush_wrap_buffer): Only flush gdb_stdout.
11428         (wrap_here): Set wrap_style.
11429         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11430         treat escape sequences as a character.  Change when wrap buffer is
11431         flushed.
11432         (fputs_styled): Do not set the output style when the default is
11433         requested.
11434         * ui-style.h (struct ui_file_style) <is_default>: New method.
11435         * source.c (print_source_lines_base): Emit escape sequences in one
11436         piece.
11437
11438 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11439
11440         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11441         integers and enumeration types.
11442
11443 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11444
11445         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11446         instead of lookup_symbol_in_language
11447         (do_exact_match): New function.
11448         (ada_get_symbol_name_matcher): Return do_exact_match when
11449         doing a verbatim match.
11450
11451 2019-02-15  Tom Tromey  <tromey@adacore.com>
11452
11453         * ravenscar-thread.c (ravenscar_thread_target::resume)
11454         (ravenscar_thread_target::wait): Special case wildcard requests.
11455
11456 2019-02-15  Tom Tromey  <tromey@adacore.com>
11457
11458         * ravenscar-thread.c (base_ptid): Remove.
11459         (struct ravenscar_thread_target) <close>: New method.
11460         <m_base_ptid>: New member.
11461         <update_inferior_ptid, active_task, task_is_currently_active,
11462         runtime_initialized>: Declare methods.
11463         <ravenscar_thread_target>: Add constructor.
11464         (ravenscar_thread_target::task_is_currently_active)
11465         (ravenscar_thread_target::update_inferior_ptid)
11466         (ravenscar_runtime_initialized): Rename.  Now methods.
11467         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11468         (ravenscar_thread_target::update_thread_list): Update.
11469         (ravenscar_thread_target::active_task): Now method.
11470         (ravenscar_thread_target::store_registers)
11471         (ravenscar_thread_target::prepare_to_store)
11472         (ravenscar_thread_target::prepare_to_store)
11473         (ravenscar_thread_target::mourn_inferior): Update.
11474         (ravenscar_inferior_created): Use "new" to create target.
11475         (ravenscar_thread_target::get_ada_task_ptid): Update.
11476         (_initialize_ravenscar): Don't initialize base_ptid.
11477         (ravenscar_ops): Remove global.
11478
11479 2019-02-15  Tom Tromey  <tromey@adacore.com>
11480
11481         * target.h (push_target): Declare new overload.
11482         * target.c (push_target): New overload, taking an rvalue reference.
11483         * remote.c (remote_target::open_1): Use push_target overload.
11484         * corelow.c (core_target_open): Use push_target overload.
11485
11486 2019-02-15  Tom Tromey  <tromey@adacore.com>
11487
11488         * ravenscar-thread.c (is_ravenscar_task)
11489         (ravenscar_task_is_currently_active): Return bool.
11490         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11491         (_initialize_ravenscar): Remove "(void)".
11492         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11493         Return bool.
11494
11495 2019-02-15  Tom Tromey  <tromey@adacore.com>
11496
11497         * ravenscar-thread.c (ravenscar_runtime_initializer)
11498         (has_ravenscar_runtime, get_running_thread_id)
11499         (ravenscar_thread_target::resume): Fix indentation.
11500
11501 2019-02-15  Tom Tromey  <tromey@adacore.com>
11502
11503         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11504         from ravenscar_arch_ops.
11505         (sparc_ravenscar_ops::fetch_registers)
11506         (sparc_ravenscar_ops::store_registers): Now methods.
11507         (sparc_ravenscar_prepare_to_store): Remove.
11508         (sparc_ravenscar_ops): Redefine.
11509         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11510         methods and destructor.  Remove members.
11511         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11512         (ravenscar_thread_target::store_registers)
11513         (ravenscar_thread_target::prepare_to_store): Update.
11514         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11515         Remove.
11516         (struct ppc_ravenscar_powerpc_ops): Derive from
11517         ravenscar_arch_ops.
11518         (ppc_ravenscar_powerpc_ops::fetch_registers)
11519         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11520         (ppc_ravenscar_powerpc_ops): Redefine.
11521         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11522         (ppc_ravenscar_e500_ops::fetch_registers)
11523         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11524         (ppc_ravenscar_e500_ops): Redefine.
11525         * aarch64-ravenscar-thread.c
11526         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11527         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11528         (aarch64_ravenscar_fetch_registers)
11529         (aarch64_ravenscar_store_registers): Now methods.
11530         (aarch64_ravenscar_ops): Redefine.
11531
11532 2019-02-15  Tom Tromey  <tromey@adacore.com>
11533
11534         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11535         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11536         (ravenscar_thread_target::stopped_by_watchpoint)
11537         (ravenscar_thread_target::stopped_data_address)
11538         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11539
11540 2019-02-15  Tom Tromey  <tromey@adacore.com>
11541
11542         * ravenscar-thread.c: Fix some typos.
11543
11544 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11545             Tom Tromey  <tromey@adacore.com>
11546
11547         * ada-lang.c (ada_exception_sal): Change addr_string to a
11548         std::string.
11549         (create_ada_exception_catchpoint): Update.
11550
11551 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11552             Tom Tromey  <tromey@adacore.com>
11553
11554         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11555         (bp_location_ops): Remove.
11556         (base_breakpoint_allocate_location): Update.
11557         (free_bp_location): Update.
11558         * ada-lang.c (class ada_catchpoint_location)
11559         <ada_catchpoint_location>: Remove ops parameter.
11560         (ada_catchpoint_location_dtor): Remove.
11561         (ada_catchpoint_location_ops): Remove.
11562         (allocate_location_exception): Update.
11563         * breakpoint.h (struct bp_location_ops): Remove.
11564         (class bp_location) <bp_location>: Remove bp_location_ops
11565         parameter.
11566         <~bp_location>: Add destructor.
11567         <ops>: Remove.
11568
11569 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11570             Pedro Alves  <palves@redhat.com>
11571
11572         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11573         'PATH_MAX'.
11574
11575 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11576             Samuel Thibault  <samuel.thibault@gnu.org>
11577             Thomas Schwinge  <thomas@codesourcery.com>
11578
11579         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11580         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11581
11582 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11583
11584         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11585         (check_empty): Use "const char *".
11586
11587         * gnu-nat.c (gnu_nat_target::detach): Instead of
11588         'detach_inferior (pid)' call
11589         'detach_inferior (find_inferior_pid (pid))'.
11590
11591         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11592         'nat/fork-inferior.o'.
11593         * gnu-nat.c: #include "nat/fork-inferior.h".
11594
11595         * gnu-nat.c (gnu_nat_target::detach): Instead of
11596         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11597         * gnu-nat.h: #include "inf-child.h".
11598         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11599         'i386_gnu_nat_target::fetch_registers'.
11600         (gnu_store_registers): Rename/move to
11601         'i386_gnu_nat_target::store_registers'.
11602
11603         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11604         * gnu-nat.h (mach_thread_info): New function.
11605         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11606
11607         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11608
11609 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11610
11611         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11612
11613 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11614
11615         * windows-nat.c (windows_add_thread): Add new parameter
11616         "main_thread_p" with default value set to false.  Update
11617         function documentation as well as all callers.
11618         (windows_delete_thread): Likewise.
11619         (fake_create_process): Update call to windows_add_thread.
11620         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11621         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11622         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11623         call to windows_delete_thread.
11624
11625 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11626
11627         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11628
11629 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11630
11631         * symfile.c (find_separate_debug_file): Use canonical path of
11632         sysroot with child_path instead of gdb_sysroot if it is valid.
11633
11634 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11635
11636         * symfile.c (find_separate_debug_file): Use child_path to
11637         determine if an object file is under a sysroot.
11638
11639 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11640
11641         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11642         unittests/child-path-selftests.c.
11643         * common/pathstuff.c (child_path): New function.
11644         * common/pathstuff.h (child_path): New prototype.
11645         * unittests/child-path-selftests.c: New file.
11646
11647 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11648
11649         * symfile.c (find_separate_debug_file): Look for separate debug
11650         files in debug directories under the sysroot.
11651
11652 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11653
11654         * symtab.h (struct minimal_symbol data_p): New const method.
11655         (struct minimal_symbol text_p): Likewise.
11656         * symtab.c (output_source_filename): Use file name style
11657         to print file name.
11658         (print_symbol_info): Likewise.
11659         (print_msymbol_info): Use address style to print addresses.
11660         Use function name style to print executable text symbols.
11661         (expand_symtab_containing_pc): Use data_p.
11662         (find_pc_sect_compunit_symtab): Likewise.
11663
11664 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11665
11666         * breakpoint.c (describe_other_breakpoints): Use address style
11667         to print addresses.
11668         (say_where): Likewise.
11669
11670 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11671
11672         * ada-typeprint.c (print_func_type): Print function name
11673         style to print function name.
11674         * c-typeprint.c (c_print_type_1): Likewise.
11675
11676 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11677
11678         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11679         for execve.
11680
11681 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11682
11683         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11684         type_stack.
11685
11686 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11687
11688         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11689         TYPE_CODE_REF types.
11690
11691 2019-02-08  Jim Wilson  <jimw@sifive.com>
11692
11693         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11694         (riscv_linux_fregset): New.
11695         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11696
11697 2019-02-07  Tom Tromey  <tom@tromey.com>
11698
11699         * thread.c (thread_cancel_execution_command): Update.
11700         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11701         methods.
11702         (struct thread_fsm_ops): Remove.
11703         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11704         (thread_fsm_should_stop, thread_fsm_return_value)
11705         (thread_fsm_set_finished, thread_fsm_finished_p)
11706         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11707         Don't declare.
11708         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11709         * infrun.c (clear_proceed_status_thread)
11710         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11711         (print_stop_event): Update.
11712         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11713         Add constructor.
11714         (step_command_fsm_ops): Remove.
11715         (new_step_command_fsm): Remove.
11716         (step_1): Update.
11717         (step_command_fsm::should_stop): Rename from
11718         step_command_fsm_should_stop.
11719         (step_command_fsm::clean_up): Rename from
11720         step_command_fsm_clean_up.
11721         (step_command_fsm::do_async_reply_reason): Rename from
11722         step_command_fsm_async_reply_reason.
11723         (struct until_next_fsm): Inherit from thread_fsm.  Add
11724         constructor.
11725         (until_next_fsm_ops): Remove.
11726         (new_until_next_fsm): Remove.
11727         (until_next_fsm::should_stop): Rename from
11728         until_next_fsm_should_stop.
11729         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11730         (until_next_fsm::do_async_reply_reason): Rename from
11731         until_next_fsm_async_reply_reason.
11732         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11733         constructor.  Change type of breakpoint.
11734         (finish_command_fsm_ops): Remove.
11735         (new_finish_command_fsm): Remove.
11736         (finish_command_fsm::should_stop): Rename from
11737         finish_command_fsm_should_stop.
11738         (finish_command_fsm::clean_up): Rename from
11739         finish_command_fsm_clean_up.
11740         (finish_command_fsm::return_value): Rename from
11741         finish_command_fsm_return_value.
11742         (finish_command_fsm::do_async_reply_reason): Rename from
11743         finish_command_fsm_async_reply_reason.
11744         (finish_command): Update.
11745         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11746         Add constructor.
11747         (call_thread_fsm_ops): Remove.
11748         (call_thread_fsm::call_thread_fsm): Rename from
11749         new_call_thread_fsm.
11750         (call_thread_fsm::should_stop): Rename from
11751         call_thread_fsm_should_stop.
11752         (call_thread_fsm::should_notify_stop): Rename from
11753         call_thread_fsm_should_notify_stop.
11754         (run_inferior_call, call_function_by_hand_dummy): Update.
11755         * cli/cli-interp.c (should_print_stop_to_console): Update.
11756         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11757         Add constructor.  Change type of location_breakpoint,
11758         caller_breakpoint.
11759         (until_break_fsm_ops): Remove.
11760         (new_until_break_fsm): Remove.
11761         (until_break_fsm::should_stop): Rename from
11762         until_break_fsm_should_stop.
11763         (until_break_fsm::clean_up): Rename from
11764         until_break_fsm_clean_up.
11765         (until_break_fsm::do_async_reply_reason): Rename from
11766         until_break_fsm_async_reply_reason.
11767         (until_break_command): Update.
11768         * thread-fsm.c: Remove.
11769         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11770
11771 2019-02-07  Tom Tromey  <tom@tromey.com>
11772
11773         * yy-remap.h: Add include guard.
11774         * xtensa-tdep.h: Add include guard.
11775         * xcoffread.h: Rename include guard.
11776         * varobj-iter.h: Add include guard.
11777         * tui/tui.h: Rename include guard.
11778         * tui/tui-winsource.h: Rename include guard.
11779         * tui/tui-wingeneral.h: Rename include guard.
11780         * tui/tui-windata.h: Rename include guard.
11781         * tui/tui-win.h: Rename include guard.
11782         * tui/tui-stack.h: Rename include guard.
11783         * tui/tui-source.h: Rename include guard.
11784         * tui/tui-regs.h: Rename include guard.
11785         * tui/tui-out.h: Rename include guard.
11786         * tui/tui-layout.h: Rename include guard.
11787         * tui/tui-io.h: Rename include guard.
11788         * tui/tui-hooks.h: Rename include guard.
11789         * tui/tui-file.h: Rename include guard.
11790         * tui/tui-disasm.h: Rename include guard.
11791         * tui/tui-data.h: Rename include guard.
11792         * tui/tui-command.h: Rename include guard.
11793         * tic6x-tdep.h: Add include guard.
11794         * target/waitstatus.h: Rename include guard.
11795         * target/wait.h: Rename include guard.
11796         * target/target.h: Rename include guard.
11797         * target/resume.h: Rename include guard.
11798         * target-float.h: Rename include guard.
11799         * stabsread.h: Add include guard.
11800         * rs6000-tdep.h: Add include guard.
11801         * riscv-fbsd-tdep.h: Add include guard.
11802         * regformats/regdef.h: Rename include guard.
11803         * record.h: Rename include guard.
11804         * python/python.h: Rename include guard.
11805         * python/python-internal.h: Rename include guard.
11806         * python/py-stopevent.h: Rename include guard.
11807         * python/py-ref.h: Rename include guard.
11808         * python/py-record.h: Rename include guard.
11809         * python/py-record-full.h: Rename include guard.
11810         * python/py-record-btrace.h: Rename include guard.
11811         * python/py-instruction.h: Rename include guard.
11812         * python/py-events.h: Rename include guard.
11813         * python/py-event.h: Rename include guard.
11814         * procfs.h: Add include guard.
11815         * proc-utils.h: Add include guard.
11816         * p-lang.h: Add include guard.
11817         * or1k-tdep.h: Rename include guard.
11818         * observable.h: Rename include guard.
11819         * nto-tdep.h: Rename include guard.
11820         * nat/x86-linux.h: Rename include guard.
11821         * nat/x86-linux-dregs.h: Rename include guard.
11822         * nat/x86-gcc-cpuid.h: Add include guard.
11823         * nat/x86-dregs.h: Rename include guard.
11824         * nat/x86-cpuid.h: Rename include guard.
11825         * nat/ppc-linux.h: Rename include guard.
11826         * nat/mips-linux-watch.h: Rename include guard.
11827         * nat/linux-waitpid.h: Rename include guard.
11828         * nat/linux-ptrace.h: Rename include guard.
11829         * nat/linux-procfs.h: Rename include guard.
11830         * nat/linux-osdata.h: Rename include guard.
11831         * nat/linux-nat.h: Rename include guard.
11832         * nat/linux-namespaces.h: Rename include guard.
11833         * nat/linux-btrace.h: Rename include guard.
11834         * nat/glibc_thread_db.h: Rename include guard.
11835         * nat/gdb_thread_db.h: Rename include guard.
11836         * nat/gdb_ptrace.h: Rename include guard.
11837         * nat/fork-inferior.h: Rename include guard.
11838         * nat/amd64-linux-siginfo.h: Rename include guard.
11839         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11840         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11841         * nat/aarch64-linux.h: Rename include guard.
11842         * nat/aarch64-linux-hw-point.h: Rename include guard.
11843         * mn10300-tdep.h: Add include guard.
11844         * mips-linux-tdep.h: Add include guard.
11845         * mi/mi-parse.h: Rename include guard.
11846         * mi/mi-out.h: Rename include guard.
11847         * mi/mi-main.h: Rename include guard.
11848         * mi/mi-interp.h: Rename include guard.
11849         * mi/mi-getopt.h: Rename include guard.
11850         * mi/mi-console.h: Rename include guard.
11851         * mi/mi-common.h: Rename include guard.
11852         * mi/mi-cmds.h: Rename include guard.
11853         * mi/mi-cmd-break.h: Rename include guard.
11854         * m2-lang.h: Add include guard.
11855         * location.h: Rename include guard.
11856         * linux-record.h: Rename include guard.
11857         * linux-nat.h: Add include guard.
11858         * linux-fork.h: Add include guard.
11859         * i386-darwin-tdep.h: Rename include guard.
11860         * hppa-linux-offsets.h: Add include guard.
11861         * guile/guile.h: Rename include guard.
11862         * guile/guile-internal.h: Rename include guard.
11863         * gnu-nat.h: Rename include guard.
11864         * gdb-stabs.h: Rename include guard.
11865         * frv-tdep.h: Add include guard.
11866         * f-lang.h: Add include guard.
11867         * event-loop.h: Add include guard.
11868         * darwin-nat.h: Rename include guard.
11869         * cp-abi.h: Rename include guard.
11870         * config/sparc/nm-sol2.h: Rename include guard.
11871         * config/nm-nto.h: Rename include guard.
11872         * config/nm-linux.h: Add include guard.
11873         * config/i386/nm-i386gnu.h: Rename include guard.
11874         * config/djgpp/nl_types.h: Rename include guard.
11875         * config/djgpp/langinfo.h: Rename include guard.
11876         * compile/gcc-cp-plugin.h: Add include guard.
11877         * compile/gcc-c-plugin.h: Add include guard.
11878         * compile/compile.h: Rename include guard.
11879         * compile/compile-object-run.h: Rename include guard.
11880         * compile/compile-object-load.h: Rename include guard.
11881         * compile/compile-internal.h: Rename include guard.
11882         * compile/compile-cplus.h: Rename include guard.
11883         * compile/compile-c.h: Rename include guard.
11884         * common/xml-utils.h: Rename include guard.
11885         * common/x86-xstate.h: Rename include guard.
11886         * common/version.h: Rename include guard.
11887         * common/vec.h: Rename include guard.
11888         * common/tdesc.h: Rename include guard.
11889         * common/selftest.h: Rename include guard.
11890         * common/scoped_restore.h: Rename include guard.
11891         * common/scoped_mmap.h: Rename include guard.
11892         * common/scoped_fd.h: Rename include guard.
11893         * common/safe-iterator.h: Rename include guard.
11894         * common/run-time-clock.h: Rename include guard.
11895         * common/refcounted-object.h: Rename include guard.
11896         * common/queue.h: Rename include guard.
11897         * common/ptid.h: Rename include guard.
11898         * common/print-utils.h: Rename include guard.
11899         * common/preprocessor.h: Rename include guard.
11900         * common/pathstuff.h: Rename include guard.
11901         * common/observable.h: Rename include guard.
11902         * common/netstuff.h: Rename include guard.
11903         * common/job-control.h: Rename include guard.
11904         * common/host-defs.h: Rename include guard.
11905         * common/gdb_wait.h: Rename include guard.
11906         * common/gdb_vecs.h: Rename include guard.
11907         * common/gdb_unlinker.h: Rename include guard.
11908         * common/gdb_unique_ptr.h: Rename include guard.
11909         * common/gdb_tilde_expand.h: Rename include guard.
11910         * common/gdb_sys_time.h: Rename include guard.
11911         * common/gdb_string_view.h: Rename include guard.
11912         * common/gdb_splay_tree.h: Rename include guard.
11913         * common/gdb_setjmp.h: Rename include guard.
11914         * common/gdb_ref_ptr.h: Rename include guard.
11915         * common/gdb_optional.h: Rename include guard.
11916         * common/gdb_locale.h: Rename include guard.
11917         * common/gdb_assert.h: Rename include guard.
11918         * common/filtered-iterator.h: Rename include guard.
11919         * common/filestuff.h: Rename include guard.
11920         * common/fileio.h: Rename include guard.
11921         * common/environ.h: Rename include guard.
11922         * common/common-utils.h: Rename include guard.
11923         * common/common-types.h: Rename include guard.
11924         * common/common-regcache.h: Rename include guard.
11925         * common/common-inferior.h: Rename include guard.
11926         * common/common-gdbthread.h: Rename include guard.
11927         * common/common-exceptions.h: Rename include guard.
11928         * common/common-defs.h: Rename include guard.
11929         * common/common-debug.h: Rename include guard.
11930         * common/cleanups.h: Rename include guard.
11931         * common/buffer.h: Rename include guard.
11932         * common/btrace-common.h: Rename include guard.
11933         * common/break-common.h: Rename include guard.
11934         * cli/cli-utils.h: Rename include guard.
11935         * cli/cli-style.h: Rename include guard.
11936         * cli/cli-setshow.h: Rename include guard.
11937         * cli/cli-script.h: Rename include guard.
11938         * cli/cli-interp.h: Rename include guard.
11939         * cli/cli-decode.h: Rename include guard.
11940         * cli/cli-cmds.h: Rename include guard.
11941         * charset-list.h: Add include guard.
11942         * buildsym-legacy.h: Rename include guard.
11943         * bfin-tdep.h: Add include guard.
11944         * ax.h: Rename include guard.
11945         * arm-linux-tdep.h: Add include guard.
11946         * arm-fbsd-tdep.h: Add include guard.
11947         * arch/xtensa.h: Rename include guard.
11948         * arch/tic6x.h: Add include guard.
11949         * arch/i386.h: Add include guard.
11950         * arch/arm.h: Rename include guard.
11951         * arch/arm-linux.h: Rename include guard.
11952         * arch/arm-get-next-pcs.h: Rename include guard.
11953         * arch/amd64.h: Add include guard.
11954         * arch/aarch64-insn.h: Rename include guard.
11955         * arch-utils.h: Rename include guard.
11956         * annotate.h: Add include guard.
11957         * amd64-darwin-tdep.h: Rename include guard.
11958         * aarch64-linux-tdep.h: Add include guard.
11959         * aarch64-fbsd-tdep.h: Add include guard.
11960         * aarch32-linux-nat.h: Add include guard.
11961
11962 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11963
11964         * macrotab.c (macro_define_internal): New function that
11965         factorizes macro_define_object_internal and macro_define_function
11966         code.
11967         (macro_define_object_internal): Use macro_define_internal.
11968         (macro_define_function): Likewise.
11969
11970 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11971
11972         * macrocmd.c (extract_identifier): Return
11973         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11974         callers.
11975
11976 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11977
11978         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11979
11980 2019-02-05  Tom Tromey  <tom@tromey.com>
11981
11982         * target.c (target_stack::unpush): Move assertion earlier.
11983
11984 2019-01-30  Tom Tromey  <tom@tromey.com>
11985
11986         PR python/23615:
11987         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11988         (gdbpy_parse_and_eval): Likewise.
11989         * python/python-internal.h (gdbpy_allow_threads): New class.
11990
11991 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11992
11993         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11994         (aarch64_fbsd_fpregmap): Move earlier.
11995         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11996         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11997         instead of individual calls to trad_frame_set_reg_addr.
11998         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11999         earlier.
12000         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12001         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12002         instead of individual calls to trad_frame_set_reg_addr.
12003
12004 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12005
12006         * CONTRIBUTE: Replace contribution list with wiki link.
12007
12008 2019-01-25  Tom Tromey  <tom@tromey.com>
12009
12010         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12011
12012 2019-01-25  Tom Tromey  <tom@tromey.com>
12013
12014         * xtensa-linux-nat.c: Fix common/ includes.
12015         * xml-support.h: Fix common/ includes.
12016         * xml-support.c: Fix common/ includes.
12017         * x86-linux-nat.c: Fix common/ includes.
12018         * windows-nat.c: Fix common/ includes.
12019         * varobj.h: Fix common/ includes.
12020         * varobj.c: Fix common/ includes.
12021         * value.c: Fix common/ includes.
12022         * valops.c: Fix common/ includes.
12023         * utils.c: Fix common/ includes.
12024         * unittests/xml-utils-selftests.c: Fix common/ includes.
12025         * unittests/utils-selftests.c: Fix common/ includes.
12026         * unittests/unpack-selftests.c: Fix common/ includes.
12027         * unittests/tracepoint-selftests.c: Fix common/ includes.
12028         * unittests/style-selftests.c: Fix common/ includes.
12029         * unittests/string_view-selftests.c: Fix common/ includes.
12030         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12031         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12032         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12033         * unittests/rsp-low-selftests.c: Fix common/ includes.
12034         * unittests/parse-connection-spec-selftests.c: Fix common/
12035         includes.
12036         * unittests/optional-selftests.c: Fix common/ includes.
12037         * unittests/offset-type-selftests.c: Fix common/ includes.
12038         * unittests/observable-selftests.c: Fix common/ includes.
12039         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12040         * unittests/memrange-selftests.c: Fix common/ includes.
12041         * unittests/memory-map-selftests.c: Fix common/ includes.
12042         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12043         * unittests/function-view-selftests.c: Fix common/ includes.
12044         * unittests/environ-selftests.c: Fix common/ includes.
12045         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12046         * unittests/common-utils-selftests.c: Fix common/ includes.
12047         * unittests/cli-utils-selftests.c: Fix common/ includes.
12048         * unittests/array-view-selftests.c: Fix common/ includes.
12049         * ui-file.c: Fix common/ includes.
12050         * tui/tui-io.c: Fix common/ includes.
12051         * tracepoint.h: Fix common/ includes.
12052         * tracepoint.c: Fix common/ includes.
12053         * tracefile-tfile.c: Fix common/ includes.
12054         * top.h: Fix common/ includes.
12055         * top.c: Fix common/ includes.
12056         * thread.c: Fix common/ includes.
12057         * target/waitstatus.h: Fix common/ includes.
12058         * target/waitstatus.c: Fix common/ includes.
12059         * target.h: Fix common/ includes.
12060         * target.c: Fix common/ includes.
12061         * target-memory.c: Fix common/ includes.
12062         * target-descriptions.c: Fix common/ includes.
12063         * symtab.h: Fix common/ includes.
12064         * symfile.c: Fix common/ includes.
12065         * stap-probe.c: Fix common/ includes.
12066         * spu-linux-nat.c: Fix common/ includes.
12067         * sparc-nat.c: Fix common/ includes.
12068         * source.c: Fix common/ includes.
12069         * solib.c: Fix common/ includes.
12070         * solib-target.c: Fix common/ includes.
12071         * ser-unix.c: Fix common/ includes.
12072         * ser-tcp.c: Fix common/ includes.
12073         * ser-pipe.c: Fix common/ includes.
12074         * ser-base.c: Fix common/ includes.
12075         * selftest-arch.c: Fix common/ includes.
12076         * s12z-tdep.c: Fix common/ includes.
12077         * rust-exp.y: Fix common/ includes.
12078         * rs6000-aix-tdep.c: Fix common/ includes.
12079         * riscv-tdep.c: Fix common/ includes.
12080         * remote.c: Fix common/ includes.
12081         * remote-notif.h: Fix common/ includes.
12082         * remote-fileio.h: Fix common/ includes.
12083         * remote-fileio.c: Fix common/ includes.
12084         * regcache.h: Fix common/ includes.
12085         * regcache.c: Fix common/ includes.
12086         * record-btrace.c: Fix common/ includes.
12087         * python/python.c: Fix common/ includes.
12088         * python/py-type.c: Fix common/ includes.
12089         * python/py-inferior.c: Fix common/ includes.
12090         * progspace.h: Fix common/ includes.
12091         * producer.c: Fix common/ includes.
12092         * procfs.c: Fix common/ includes.
12093         * proc-api.c: Fix common/ includes.
12094         * printcmd.c: Fix common/ includes.
12095         * ppc-linux-nat.c: Fix common/ includes.
12096         * parser-defs.h: Fix common/ includes.
12097         * osdata.c: Fix common/ includes.
12098         * obsd-nat.c: Fix common/ includes.
12099         * nat/x86-linux.c: Fix common/ includes.
12100         * nat/x86-linux-dregs.c: Fix common/ includes.
12101         * nat/x86-dregs.h: Fix common/ includes.
12102         * nat/x86-dregs.c: Fix common/ includes.
12103         * nat/ppc-linux.c: Fix common/ includes.
12104         * nat/mips-linux-watch.h: Fix common/ includes.
12105         * nat/mips-linux-watch.c: Fix common/ includes.
12106         * nat/linux-waitpid.c: Fix common/ includes.
12107         * nat/linux-ptrace.h: Fix common/ includes.
12108         * nat/linux-ptrace.c: Fix common/ includes.
12109         * nat/linux-procfs.c: Fix common/ includes.
12110         * nat/linux-personality.c: Fix common/ includes.
12111         * nat/linux-osdata.c: Fix common/ includes.
12112         * nat/linux-namespaces.c: Fix common/ includes.
12113         * nat/linux-btrace.h: Fix common/ includes.
12114         * nat/linux-btrace.c: Fix common/ includes.
12115         * nat/fork-inferior.c: Fix common/ includes.
12116         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12117         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12118         * nat/aarch64-linux.c: Fix common/ includes.
12119         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12120         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12121         * namespace.h: Fix common/ includes.
12122         * mips-linux-tdep.c: Fix common/ includes.
12123         * minsyms.c: Fix common/ includes.
12124         * mi/mi-parse.h: Fix common/ includes.
12125         * mi/mi-main.c: Fix common/ includes.
12126         * mi/mi-cmd-env.c: Fix common/ includes.
12127         * memrange.h: Fix common/ includes.
12128         * memattr.c: Fix common/ includes.
12129         * maint.h: Fix common/ includes.
12130         * maint.c: Fix common/ includes.
12131         * main.c: Fix common/ includes.
12132         * machoread.c: Fix common/ includes.
12133         * location.c: Fix common/ includes.
12134         * linux-thread-db.c: Fix common/ includes.
12135         * linux-nat.c: Fix common/ includes.
12136         * linux-fork.c: Fix common/ includes.
12137         * inline-frame.c: Fix common/ includes.
12138         * infrun.c: Fix common/ includes.
12139         * inflow.c: Fix common/ includes.
12140         * inferior.h: Fix common/ includes.
12141         * inferior.c: Fix common/ includes.
12142         * infcmd.c: Fix common/ includes.
12143         * inf-ptrace.c: Fix common/ includes.
12144         * inf-child.c: Fix common/ includes.
12145         * ia64-linux-nat.c: Fix common/ includes.
12146         * i387-tdep.c: Fix common/ includes.
12147         * i386-tdep.c: Fix common/ includes.
12148         * i386-linux-tdep.c: Fix common/ includes.
12149         * i386-linux-nat.c: Fix common/ includes.
12150         * i386-go32-tdep.c: Fix common/ includes.
12151         * i386-fbsd-tdep.c: Fix common/ includes.
12152         * i386-fbsd-nat.c: Fix common/ includes.
12153         * guile/scm-type.c: Fix common/ includes.
12154         * guile/guile.c: Fix common/ includes.
12155         * go32-nat.c: Fix common/ includes.
12156         * gnu-nat.c: Fix common/ includes.
12157         * gdbthread.h: Fix common/ includes.
12158         * gdbarch-selftests.c: Fix common/ includes.
12159         * gdb_usleep.c: Fix common/ includes.
12160         * gdb_select.h: Fix common/ includes.
12161         * gdb_bfd.c: Fix common/ includes.
12162         * gcore.c: Fix common/ includes.
12163         * fork-child.c: Fix common/ includes.
12164         * findvar.c: Fix common/ includes.
12165         * fbsd-nat.c: Fix common/ includes.
12166         * event-top.c: Fix common/ includes.
12167         * event-loop.c: Fix common/ includes.
12168         * dwarf2read.c: Fix common/ includes.
12169         * dwarf2loc.c: Fix common/ includes.
12170         * dwarf2-frame.c: Fix common/ includes.
12171         * dwarf-index-cache.c: Fix common/ includes.
12172         * dtrace-probe.c: Fix common/ includes.
12173         * disasm-selftests.c: Fix common/ includes.
12174         * defs.h: Fix common/ includes.
12175         * csky-tdep.c: Fix common/ includes.
12176         * cp-valprint.c: Fix common/ includes.
12177         * cp-support.h: Fix common/ includes.
12178         * cp-support.c: Fix common/ includes.
12179         * corelow.c: Fix common/ includes.
12180         * completer.h: Fix common/ includes.
12181         * completer.c: Fix common/ includes.
12182         * compile/compile.c: Fix common/ includes.
12183         * compile/compile-loc2c.c: Fix common/ includes.
12184         * compile/compile-cplus-types.c: Fix common/ includes.
12185         * compile/compile-cplus-symbols.c: Fix common/ includes.
12186         * command.h: Fix common/ includes.
12187         * cli/cli-dump.c: Fix common/ includes.
12188         * cli/cli-cmds.c: Fix common/ includes.
12189         * charset.c: Fix common/ includes.
12190         * build-id.c: Fix common/ includes.
12191         * btrace.h: Fix common/ includes.
12192         * btrace.c: Fix common/ includes.
12193         * breakpoint.h: Fix common/ includes.
12194         * breakpoint.c: Fix common/ includes.
12195         * ax.h:
12196         (enum agent_op): Fix common/ includes.
12197         * ax-general.c (struct aop_map): Fix common/ includes.
12198         * ax-gdb.c: Fix common/ includes.
12199         * auxv.c: Fix common/ includes.
12200         * auto-load.c: Fix common/ includes.
12201         * arm-tdep.c: Fix common/ includes.
12202         * arch/riscv.c: Fix common/ includes.
12203         * arch/ppc-linux-common.c: Fix common/ includes.
12204         * arch/i386.c: Fix common/ includes.
12205         * arch/arm.c: Fix common/ includes.
12206         * arch/arm-linux.c: Fix common/ includes.
12207         * arch/arm-get-next-pcs.c: Fix common/ includes.
12208         * arch/amd64.c: Fix common/ includes.
12209         * arch/aarch64.c: Fix common/ includes.
12210         * arch/aarch64-insn.c: Fix common/ includes.
12211         * arch-utils.c: Fix common/ includes.
12212         * amd64-windows-tdep.c: Fix common/ includes.
12213         * amd64-tdep.c: Fix common/ includes.
12214         * amd64-sol2-tdep.c: Fix common/ includes.
12215         * amd64-obsd-tdep.c: Fix common/ includes.
12216         * amd64-nbsd-tdep.c: Fix common/ includes.
12217         * amd64-linux-tdep.c: Fix common/ includes.
12218         * amd64-linux-nat.c: Fix common/ includes.
12219         * amd64-fbsd-tdep.c: Fix common/ includes.
12220         * amd64-fbsd-nat.c: Fix common/ includes.
12221         * amd64-dicos-tdep.c: Fix common/ includes.
12222         * amd64-darwin-tdep.c: Fix common/ includes.
12223         * agent.c: Fix common/ includes.
12224         * ada-lang.h: Fix common/ includes.
12225         * ada-lang.c: Fix common/ includes.
12226         * aarch64-tdep.c: Fix common/ includes.
12227
12228 2019-01-25  Tom Tromey  <tom@tromey.com>
12229
12230         * common/create-version.sh: Use common/version.h.
12231
12232 2019-01-24  Pedro Alves  <palves@redhat.com>
12233
12234         * infrun.c (signal_stop, signal_print, signal_program)
12235         (signal_catch, signal_pass): Now arrays instead of pointers.
12236         (update_signals_program_target, do_target_resume)
12237         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12238         * linux-nat.c (linux_nat_target::pass_signals)
12239         (linux_nat_target::create_inferior, linux_nat_target::attach):
12240         Adjust.
12241         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12242         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12243         * procfs.c (procfs_target::pass_signals): Adjust.
12244         * record-full.c (record_full_target::resume): Adjust.
12245         * remote.c (remote_target::pass_signals)
12246         (remote_target::program_signals): Adjust.
12247         * target-debug.h (target_debug_print_signals): Now takes a
12248         gdb::array_view as parameter.  Adjust.
12249         * target.h (target_ops) <pass_signals, program_signals>: Replace
12250         pointer and length parameters with gdb::array_view.
12251         (target_pass_signals, target_program_signals): Likewise.
12252         * target-delegates.c: Regenerate.
12253
12254 2019-01-24  Pedro Alves  <palves@redhat.com>
12255
12256         * common/forward-scope-exit.h
12257         (forward_scope_exit::forward_scope_exit): Pass arguments to
12258         m_bind_function directly, instead of creating a std::bind and
12259         copying that.
12260
12261 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12262
12263         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12264         for static members.
12265         (pass_in_v_vfp_candidate): Likewise.
12266
12267 2019-01-23  Tom Tromey  <tom@tromey.com>
12268             Pedro Alves  <palves@redhat.com>
12269
12270         * regcache.c (class regcache_invalidator): Remove.
12271         (regcache::raw_write): Use make_scope_exit.
12272
12273 2019-01-23  Tom Tromey  <tom@tromey.com>
12274
12275         * ui-out.h (class ui_out_emit_type): Update comment.
12276
12277 2019-01-23  Tom Tromey  <tom@tromey.com>
12278
12279         * infrun.c (fetch_inferior_event): Update comment.
12280
12281 2019-01-23  Tom Tromey  <tom@tromey.com>
12282             Pedro Alves  <palves@redhat.com>
12283
12284         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12285         parameter.
12286         (fetch_inferior_event): Use SCOPE_EXIT.
12287
12288
12289 2019-01-23  Tom Tromey  <tom@tromey.com>
12290             Pedro Alves  <palves@redhat.com>
12291
12292         * infrun.c (disable_thread_events): Delete.
12293         (stop_all_threads): Use SCOPE_EXIT.
12294
12295 2019-01-23  Tom Tromey  <tom@tromey.com>
12296             Pedro Alves  <palves@redhat.com>
12297
12298         * symfile.c: Include forward-scope-exit.h.
12299         (clear_symtab_users_cleanup): Replace forward declaration with
12300         a FORWARD_SCOPE_EXIT.
12301         (syms_from_objfile_1): Use the forward_scope_exit and
12302         gdb::optional instead of cleanup_function.
12303         (reread_symbols): Use the forward_scope_exit instead of
12304         cleanup_function.
12305         (clear_symtab_users_cleanup): Remove function.
12306
12307 2019-01-23  Tom Tromey  <tom@tromey.com>
12308             Pedro Alves  <palves@redhat.com>
12309
12310         * linux-nat.c: Include scope-exit.h.
12311         (cleanup_target_stop): Remove.
12312         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12313         SCOPE_EXIT.
12314
12315 2019-01-23  Tom Tromey  <tom@tromey.com>
12316             Pedro Alves  <palves@redhat.com>
12317
12318         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12319         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12320
12321 2019-01-23  Tom Tromey  <tom@tromey.com>
12322             Andrew Burgess  <andrew.burgess@embecosm.com>
12323             Pedro Alves  <palves@redhat.com>
12324
12325         * infrun.c (fetch_inferior_event): Use scope_exit.
12326         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12327         * top.c (execute_command): Use scope_exit.
12328         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12329         * utils.c (do_bpstat_clear_actions_cleanup)
12330         (make_bpstat_clear_actions_cleanup): Remove.
12331
12332 2019-01-23  Tom Tromey  <tom@tromey.com>
12333             Pedro Alves  <palves@redhat.com>
12334
12335         * infrun.c: Include "common/scope-exit.h"
12336         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12337         (wait_for_inferior): Use SCOPE_EXIT.
12338         (fetch_inferior_event): Use scope_exit.
12339
12340 2019-01-23  Tom Tromey  <tom@tromey.com>
12341             Pedro Alves  <palves@redhat.com>
12342
12343         * breakpoint.c (create_breakpoint): Remove cleanup.
12344
12345 2019-01-23  Tom Tromey  <tom@tromey.com>
12346             Andrew Burgess  <andrew.burgess@embecosm.com>
12347             Pedro Alves  <palves@redhat.com>
12348
12349 2019-01-23  Pedro Alves  <palves@redhat.com>
12350
12351         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12352
12353 2019-01-23  Pedro Alves  <palves@redhat.com>
12354             Andrew Burgess  <andrew.burgess@embecosm.com>
12355
12356         * gdbthread.h: Include "common/forward-scope-exit.h".
12357         (scoped_finish_thread_state): Redefine custom class in terms of
12358         forward_scope_exit.
12359
12360 2019-01-23  Pedro Alves  <palves@redhat.com>
12361             Andrew Burgess  <andrew.burgess@embecosm.com>
12362
12363         * common/forward-scope-exit.h: New file.
12364
12365 2019-01-23  Pedro Alves  <palves@redhat.com>
12366             Andrew Burgess  <andrew.burgess@embecosm.com>
12367             Tom Tromey  <tom@tromey.com>
12368
12369         * common/scope-exit.h: New file.
12370
12371 2019-01-23  Pedro Alves  <palves@redhat.com>
12372
12373         * common/preprocessor.h (ESC): Rename to ...
12374         (ESC_PARENS): ... this.
12375         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12376         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12377
12378 2019-01-23  Tom Tromey  <tom@tromey.com>
12379
12380         * language.h (class scoped_switch_to_sym_language_if_auto):
12381         Initialize m_lang in both cases.
12382
12383 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12384
12385         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12386         with XCNEW.
12387
12388 2019-01-22  Tom Tromey  <tom@tromey.com>
12389
12390         * corelow.c: Do not include sys/file.h.
12391
12392 2019-01-22  Tom Tromey  <tom@tromey.com>
12393
12394         * tui/tui-wingeneral.h: Include gdb_curses.h.
12395
12396 2019-01-22  Tom Tromey  <tom@tromey.com>
12397
12398         * source-cache.h (class source_cache) <get_source_lines,
12399         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12400
12401 2019-01-22  Tom Tromey  <tom@tromey.com>
12402
12403         * remote-fileio.h (struct remote_target): Declare.
12404
12405 2019-01-22  Tom Tromey  <tom@tromey.com>
12406
12407         * python/py-arch.c: Do not include py-ref.h.
12408         * python/py-bpevent.c: Do not include py-ref.h.
12409         * python/py-cmd.c: Do not include py-ref.h.
12410         * python/py-continueevent.c: Do not include py-ref.h.
12411         * python/py-event.h: Do not include py-ref.h.
12412         * python/py-evtregistry.c: Do not include py-ref.h.
12413         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12414         * python/py-frame.c: Do not include py-ref.h.
12415         * python/py-framefilter.c: Do not include py-ref.h.
12416         * python/py-function.c: Do not include py-ref.h.
12417         * python/py-infevents.c: Do not include py-ref.h.
12418         * python/py-linetable.c: Do not include py-ref.h.
12419         * python/py-objfile.c: Do not include py-ref.h.
12420         * python/py-param.c: Do not include py-ref.h.
12421         * python/py-prettyprint.c: Do not include py-ref.h.
12422         * python/py-progspace.c: Do not include py-ref.h.
12423         * python/py-symbol.c: Do not include py-ref.h.
12424         * python/py-symtab.c: Do not include py-ref.h.
12425         * python/py-type.c: Do not include py-ref.h.
12426         * python/py-unwind.c: Do not include py-ref.h.
12427         * python/py-utils.c: Do not include py-ref.h.
12428         * python/py-value.c: Do not include py-ref.h.
12429         * python/py-varobj.c: Do not include py-ref.h.
12430         * python/py-xmethods.c: Do not include py-ref.h.
12431         * python/python.c: Do not include py-ref.h.
12432         * varobj.c: Do not include py-ref.h.
12433
12434 2019-01-22  Tom Tromey  <tom@tromey.com>
12435
12436         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12437         keyword for bcache.
12438
12439 2019-01-22  Tom Tromey  <tom@tromey.com>
12440
12441         * compile/compile-cplus-types.c: Remove a comment by #include.
12442
12443 2019-01-22  Tom Tromey  <tom@tromey.com>
12444
12445         * compile/gcc-c-plugin.h: Include compile-internal.h.
12446
12447 2019-01-22  Tom Tromey  <tom@tromey.com>
12448
12449         * stabsread.c (EXTERN): Do not define.
12450         (symnum, next_symbol_text_func, processing_gcc_compilation)
12451         (within_function, global_sym_chain, global_stabs)
12452         (previous_stab_code, this_object_header_files)
12453         (n_this_object_header_files)
12454         (n_allocated_this_object_header_files): Define.
12455         * stabsread.h (EXTERN): Never define.  Use "extern".
12456
12457 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12458
12459         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12460         history_value.
12461
12462 2019-01-21  Tom Tromey  <tom@tromey.com>
12463
12464         * ui-out.c: Fix includes.
12465         * tui/tui-source.c: Fix includes.
12466         * target.c: Fix includes.
12467         * remote.c: Fix includes.
12468         * regcache.c: Fix includes.
12469         * python/py-block.c: Fix includes.
12470         * printcmd.c: Fix includes.
12471         * or1k-tdep.c: Fix includes.
12472         * mi/mi-main.c: Fix includes.
12473         * m32r-tdep.c: Fix includes.
12474         * csky-tdep.c: Fix includes.
12475         * compile/compile-cplus-types.c: Fix includes.
12476         * cli/cli-interp.c: Fix includes.
12477
12478 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12479
12480         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12481         for padding.
12482
12483 2019-01-16  Tom Tromey  <tom@tromey.com>
12484
12485         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12486         earlier.
12487         (struct objfile) <msymbols_range>: Move from top level.
12488         <msymbols>: New method.
12489         (class objfile_msymbols): Remove.
12490         * symtab.c (default_collect_symbol_completion_matches_break_on):
12491         Update.
12492         * symmisc.c (dump_msymbols): Update.
12493         * stabsread.c (scan_file_globals): Update.
12494         * objc-lang.c (info_selectors_command, info_classes_command)
12495         (find_methods): Update.
12496         * minsyms.c (find_solib_trampoline_target): Update.
12497         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12498         * coffread.c (coff_symfile_read): Update.
12499         * ada-lang.c (ada_lookup_simple_minsym)
12500         (ada_collect_symbol_completion_matches): Update.
12501
12502 2019-01-16  Tom Tromey  <tom@tromey.com>
12503
12504         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12505         type.  Remove no-argument constructor.
12506         <iterator::operator++>: Simplify.
12507         <begin>: Update.
12508         <end>: Use minimal_symbol_count.
12509
12510 2019-01-16  Tom Tromey  <tom@tromey.com>
12511
12512         * objfiles.h (struct objfile) <psymtabs>: New method.
12513         (class objfile_psymtabs): Remove.
12514         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12515         typedef.
12516         <range>: New method.
12517         (require_partial_symbols): Change return type.
12518         * psymtab.c (require_partial_symbols)
12519         (psym_expand_symtabs_matching): Update.
12520         * mdebugread.c (parse_partial_symbols): Update.
12521         * dbxread.c (dbx_end_psymtab): Update.
12522
12523 2019-01-15  Tom Tromey  <tom@tromey.com>
12524
12525         * symtab.c (lookup_objfile_from_block)
12526         (lookup_symbol_in_objfile_symtabs)
12527         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12528         (find_line_symtab, info_sources_command)
12529         (default_collect_symbol_completion_matches_break_on)
12530         (make_source_files_completion_list): Update.
12531         * symmisc.c (print_objfile_statistics, dump_objfile)
12532         (maintenance_print_symbols, maintenance_info_symtabs)
12533         (maintenance_check_symtabs, maintenance_info_line_tables):
12534         Update.
12535         * source.c (select_source_symtab)
12536         (forget_cached_source_info_for_objfile): Update.
12537         * objfiles.h (class objfile_compunits): Remove.
12538         (struct objfile) <compunits_range>: New typedef.
12539         (compunits): New method.
12540         * objfiles.c (objfile_relocate1): Update.
12541         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12542         * maint.c (count_symtabs_and_blocks): Update.
12543         * linespec.c (iterate_over_all_matching_symtabs): Update.
12544         * cp-support.c (add_symbol_overload_list_qualified): Update.
12545         * coffread.c (coff_symtab_read): Update.
12546         * ada-lang.c (add_nonlocal_symbols)
12547         (ada_collect_symbol_completion_matches)
12548         (ada_add_global_exceptions): Update.
12549
12550 2019-01-15  Tom Tromey  <tom@tromey.com>
12551
12552         * progspace.h (program_space) <objfiles_safe_range>: New
12553         typedef.
12554         <objfiles_safe>: New method.
12555         * objfiles.h (class all_objfiles_safe): Remove.
12556         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12557         * jit.c (jit_inferior_exit_hook): Update.
12558
12559 2019-01-17  Tom Tromey  <tom@tromey.com>
12560
12561         * progspace.h (program_space) <objfiles_range>: New typedef.
12562         <objfiles>: New method.
12563         <objfiles_head>: Rename from objfiles.
12564         (object_files): Update.
12565         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12566         * guile/scm-pretty-print.c
12567         (ppscm_find_pretty_printer_from_objfiles): Update.
12568         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12569         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12570         Update.
12571         * python/py-progspace.c (pspy_get_objfiles): Update.
12572         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12573         Update.
12574         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12575         (objfpy_lookup_objfile_by_build_id): Update.
12576         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12577         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12578         Update.
12579         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12580         (expand_symtab_containing_pc, lookup_objfile_from_block)
12581         (lookup_static_symbol, basic_lookup_transparent_type)
12582         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12583         (find_line_symtab, info_sources_command)
12584         (default_collect_symbol_completion_matches_break_on)
12585         (make_source_files_completion_list, find_main_name): Update.
12586         * symmisc.c (print_symbol_bcache_statistics)
12587         (print_objfile_statistics, maintenance_print_symbols)
12588         (maintenance_print_msymbols, maintenance_print_objfiles)
12589         (maintenance_info_symtabs, maintenance_check_symtabs)
12590         (maintenance_expand_symtabs, maintenance_info_line_tables):
12591         Update.
12592         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12593         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12594         (map_overlay_command, unmap_overlay_command)
12595         (simple_overlay_update, expand_symtabs_matching)
12596         (map_symbol_filenames): Update.
12597         * symfile-debug.c (set_debug_symfile): Update.
12598         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12599         Update.
12600         * source.c (select_source_symtab, forget_cached_source_info):
12601         Update.
12602         * solib.c (solib_read_symbols): Update.
12603         * solib-spu.c (append_ocl_sos): Update.
12604         * psymtab.c (maintenance_print_psymbols)
12605         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12606         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12607         * printcmd.c (info_symbol_command): Update.
12608         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12609         Update.
12610         * objfiles.h (class all_objfiles): Remove.
12611         * objfiles.c (have_partial_symbols, have_full_symbols)
12612         (have_minimal_symbols, qsort_cmp, update_section_map)
12613         (shared_objfile_contains_address_p)
12614         (default_iterate_over_objfiles_in_search_order): Update.
12615         * objc-lang.c (info_selectors_command, info_classes_command)
12616         (find_methods): Update.
12617         * minsyms.c (find_solib_trampoline_target): Update.
12618         * maint.c (maintenance_info_sections)
12619         (maintenance_translate_address, count_symtabs_and_blocks):
12620         Update.
12621         * main.c (captured_main_1): Update.
12622         * linux-thread-db.c (try_thread_db_load_from_pdir)
12623         (has_libpthread): Update.
12624         * linespec.c (iterate_over_all_matching_symtabs)
12625         (search_minsyms_for_name): Update.
12626         * jit.c (jit_find_objf_with_entry_addr): Update.
12627         * hppa-tdep.c (find_unwind_entry)
12628         (hppa_lookup_stub_minimal_symbol): Update.
12629         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12630         Update.
12631         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12632         (elf_gnu_ifunc_resolve_by_got): Update.
12633         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12634         * dwarf-index-write.c (save_gdb_index_command): Update.
12635         * cp-support.c (add_symbol_overload_list_qualified): Update.
12636         * breakpoint.c (create_overlay_event_breakpoint)
12637         (create_longjmp_master_breakpoint)
12638         (create_std_terminate_master_breakpoint)
12639         (create_exception_master_breakpoint): Update.
12640         * blockframe.c (find_pc_partial_function): Update.
12641         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12642         (ada_collect_symbol_completion_matches)
12643         (ada_add_global_exceptions): Update.
12644
12645 2019-01-17  Tom Tromey  <tom@tromey.com>
12646
12647         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12648         declare VEC.
12649         (solib_target_parse_libraries): Change return type.
12650         (library_list_start_segment, library_list_start_section)
12651         (library_list_end_library, library_list_start_library); Update.
12652         (solib_target_free_library_list): Remove.
12653         (solib_target_parse_libraries): Remove cleanup.  Change return
12654         type.
12655         (solib_target_current_sos): Update.
12656
12657 2019-01-17  Tom Tromey  <tromey@bapiya>
12658
12659         * valprint.c: Replace "the the" with "the".
12660         * symtab.c: Replace "the the" with "the".
12661         * solib.c: Replace "the the" with "the".
12662         * solib-dsbt.c: Replace "the the" with "the".
12663         * linespec.c: Replace "the the" with "the".
12664         * dwarf2loc.h: Replace "the the" with "the".
12665         * amd64-windows-tdep.c: Replace "the the" with "the".
12666         * aarch64-tdep.c: Replace "the the" with "the".
12667
12668 2019-01-16  Keith Seitz  <keiths@redhat.com>
12669
12670         PR gdb/23773
12671         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12672         <builder>: Rename to ..
12673         <m_builder>: ... this and make private.
12674         (dwarf2_cu::get_builder): New method.  Change all users of
12675         `builder' to use this method.
12676         (dwarf2_start_symtab): Move to ...
12677         (dwarf2_cu::start_symtab): ... here.  Update all callers
12678         (setup_type_unit_groups): Move to ...
12679         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12680         callers.
12681         (dwarf2_cu::reset_builder): New method.
12682         (process_full_compunit, process_full_type_unit): Use
12683         dwarf2_cu::reset_builder.
12684         (follow_die_offset): Record the ancestor CU if it is different
12685         from the followed DIE's CU.
12686         (follow_die_sig_1): Likewise.
12687
12688 2019-01-15  Tom Tromey  <tom@tromey.com>
12689
12690         * remote.c (class remote_state) <buf>: Now a char_vector.
12691         <buf_size>: Remove.
12692         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12693         parameter.
12694         (remote_target::getpkt_or_notif_sane_1)
12695         (remote_target::getpkt_sane)
12696         (remote_target::getpkt_or_notif_sane): Likewise.
12697         (class remote_target) <putpkt>: New overload.
12698         (remote_target::read_frame): Change type of "buf_p".  Remove
12699         sizeof_p parameter.
12700         (packet_ok): New overload.
12701         (packet_check_result): New overload.
12702         Update all uses.
12703
12704 2019-01-14  Tom Tromey  <tom@tromey.com>
12705
12706         * remote-notif.c (handle_notification, remote_notif_ack)
12707         (remote_notif_parse): Make "buf" const.
12708         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12709         const.
12710         (remote_notif_parse, remote_notif_ack, handle_notification):
12711         Likewise.
12712         * remote.c (remote_notif_stop_parse): Make "buf" const.
12713         (remote_target::remote_parse_stop_reply): Make "buf" const.
12714         (remote_notif_stop_ack): Make "buf" const.
12715
12716 2019-01-14  Tom Tromey  <tom@tromey.com>
12717
12718         * remote.c (remote_console_output): Make parameter const.
12719
12720 2019-01-14  Tom Tromey  <tom@tromey.com>
12721
12722         * target-debug.h (target_debug_print_signals): Constify.
12723         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12724         * procfs.c (procfs_target::pass_signals): Update.
12725         * linux-nat.c (linux_nat_target::pass_signals): Update.
12726         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12727         * target-delegates.c: Rebuild.
12728         * remote.c (remote_target::program_signals): Update.
12729         (remote_target::pass_signals): Update.
12730         * target.c (target_pass_signals): Constify argument.
12731         (target_program_signals): Likewise.
12732         * target.h (struct target_ops) <pass_signals, program_signals>:
12733         Constify argument.
12734         (target_pass_signals, target_program_signals): Constify argument.
12735
12736 2019-01-14  Tom Tromey  <tom@tromey.com>
12737
12738         PR tui/28819:
12739         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12740
12741 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12742
12743         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12744         field.
12745         * rs6000-tdep.c: Include reggroups.h.
12746         (IS_V_ALIAS_PSEUDOREG): Define.
12747         (rs6000_register_name): Return names for the "vX" aliases.
12748         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12749         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12750         aliases.  Call default_register_reggroup_p for all other
12751         pseudo-registers.
12752         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12753         New functions.
12754         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12755         Handle "vX" aliases.
12756         (v_alias_pseudo_register_collect): New function.
12757         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12758         (rs6000_gdbarch_init): Initialize "vX" aliases as
12759         pseudo-registers.  Restore registration of
12760         rs6000_pseudo_register_reggroup_p with
12761         set_tdesc_pseudo_register_reggroup_p.
12762
12763 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12764
12765         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12766         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12767         set_gdbarch_num_pseudo_regs.
12768
12769 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12770
12771         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12772         Remove arg prefixname, add do_set and do_show.
12773         Add member functions set_list and show_list.
12774         * cli/cli-style.c (class cli_style_option): Update accordingly.
12775         (style_set_list): Move to file scope.
12776         (style_show_list): Likewise.
12777         (set_style): Call help_list.
12778         (show_style): Call cmd_show_list.
12779         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12780         Update to use the new macro.
12781
12782 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12783
12784         * ada-lang.c (_initialize_ada_language): Expand the help text
12785         for the "catch exception" command.
12786
12787 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12788
12789         * symtab.c (matching_obj_sections): Initialize obj,
12790         declare it closer to its usage.
12791
12792 2019-01-10  Tom Tromey  <tom@tromey.com>
12793
12794         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12795         (basic_inf_threads_range): Remove.
12796         (inf_threads_range, inf_non_exited_threads_range)
12797         (safe_inf_threads_range): Use next_adapter.
12798
12799 2019-01-10  Keith Seitz  <keiths@redhat.com>
12800
12801         PR gdb/23712
12802         PR symtab/23010
12803         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12804         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12805
12806 2019-01-10  Keith Seitz  <keiths@redhat.com>
12807
12808         PR gdb/23712
12809         PR symtab/23010
12810         * dictionary.c (pending_to_vector): Remove.
12811         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12812         Remove _1 suffix, replacing functions of the same name.  Update
12813         all callers.
12814         (dict_create_hashed, dict_create_hashed_expandable)
12815         (dict_create_linear, dict_create_linear_expandable, dict_free)
12816         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12817         Make functions static.
12818
12819 2019-01-10  Keith Seitz  <keiths@redhat.com>
12820
12821         PR gdb/23712
12822         PR symtab/23010
12823         * dictionary.h (struct dictionary): Replace declaration with
12824         multidictionary.
12825         (dict_create_hashed, dict_create_hashed_expandable)
12826         (dict_create_linear, dict_create_linear_expandable)
12827         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12828         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12829         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12830         taking multidictionary argument.
12831         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12832         * block.h (struct block) <dict>: Change to multidictionary
12833         and rename `multidict'.
12834         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12835         symmisc.c: Update all dictionary references to multidictionary.
12836
12837 2019-01-10  Keith Seitz  <keiths@redhat.com>
12838
12839         PR gdb/23712
12840         PR symtab/23010
12841         * dictionary.c: Include unordered_map.
12842         (pending_to_vector): New function.
12843         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12844         Rewrite the non-"_1" functions to take vector instead
12845         of linked list.
12846         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12847         "new" _1 versions of the same name.
12848         (multidictionary): Define.
12849         (std::hash<enum language): New definition.
12850         (collate_pending_symbols_by_language, mdict_create_hashed)
12851         (mdict_create_hashed_expandable, mdict_create_linear)
12852         (mdict_create_linear_expandable, mdict_free)
12853         (find_language_dictionary, create_new_language_dictionary)
12854         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12855         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12856         (mdict_size, mdict_empty): New functions.
12857         * dictionary.h (mdict_iterator): Define.
12858
12859 2019-01-10  Pedro Alves  <palves@redhat.com>
12860
12861         * breakpoint.c (read_uploaded_action)
12862         (create_tracepoint_from_upload): Adjust to use
12863         gdb::unique_xmalloc_ptr.
12864         * ctf.c (ctf_write_uploaded_tp):
12865         (SET_ARRAY_FIELD): Use emplace_back.
12866         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12867         * tracefile-tfile.c (tfile_write_uploaded_tp):
12868         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12869         gdb::unique_xmalloc_ptr.
12870         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12871         at_string, cond_string, cmd_strings>: Replace char pointers
12872         with gdb::unique_xmalloc_ptr.
12873
12874 2019-01-10  Pedro Alves  <palves@redhat.com>
12875
12876         * solib-target.c (library_list_start_library): Don't xstrdup name.
12877
12878 2019-01-10  Pedro Alves  <palves@redhat.com>
12879
12880         * mdebugread.c (parse_partial_symbols): Use
12881         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12882
12883 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12884
12885         * linux-fork.c (scoped_switch_fork_info)
12886         <~scoped_switch_fork_info>: Fix incorrect variable name.
12887
12888 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12889
12890         * linux-fork.c (scoped_switch_fork_info)
12891         <scoped_switch_fork_info>: Make explicit.
12892         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12893
12894 2019-01-10  Tom Tromey  <tom@tromey.com>
12895
12896         * objfiles.h (objfile::reset_psymtabs): Update.
12897         * objfiles.c (objfile::objfile): Update.
12898         * psymtab.h (psymtab_storage::obstack): Update.
12899         (psymtab_storage::m_obstack): Use gdb::optional.
12900         (class psymtab_storage): Update comment.  Remove objfile
12901         parameter.
12902         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12903
12904 2019-01-10  Tom Tromey  <tom@tromey.com>
12905
12906         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12907         <free_psymtabs>: Now private.
12908         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12909         (allocate_psymtab): Use new method.
12910
12911 2019-01-10  Tom Tromey  <tom@tromey.com>
12912
12913         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12914         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12915         * mdebugread.c (parse_partial_symbols): Use
12916         allocate_dependencies.
12917         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12918         allocate_dependencies.
12919         (process_psymtab_comp_unit_reader)
12920         (build_type_psymtab_dependencies): Likewise.
12921         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12922
12923 2019-01-10  Tom Tromey  <tom@tromey.com>
12924
12925         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12926         PSYMBOL_SET_LANGUAGE.
12927         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12928
12929 2019-01-10  Tom Tromey  <tom@tromey.com>
12930
12931         * psymtab.h (psymtab_storage::obstack): New method.
12932         <m_obstack>: Rename from obstack; now private.
12933         * psymtab.c (psymtab_storage): Update.
12934         * dwarf2read.c (create_addrmap_from_index)
12935         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12936         Update.
12937
12938 2019-01-10  Tom Tromey  <tom@tromey.com>
12939
12940         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12941         * objfiles.h (objfile::reset_psymtabs): New method.
12942
12943 2019-01-10  Tom Tromey  <tom@tromey.com>
12944
12945         * symmisc.c (print_symbol_bcache_statistics): Update.
12946         (print_objfile_statistics): Update.
12947         * symfile.c (reread_symbols): Update.
12948         * psymtab.h (class psymtab_storage): New.
12949         * psymtab.c (psymtab_storage): New constructor.
12950         (~psymtab_storage): New destructor.
12951         (require_partial_symbols): Update.
12952         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12953         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12954         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12955         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12956         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12957         (start_psymtab_common, end_psymtab_common)
12958         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12959         (allocate_psymtab): Update.
12960         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12961         Update.
12962         (dump_psymtab_addrmap, maintenance_print_psymbols)
12963         (maintenance_check_psymtabs): Update.
12964         (class objfile_psymtabs): Move to objfiles.h.
12965         * psympriv.h (discard_psymtab): Now inline.
12966         (psymtab_discarder::psymtab_discarder): Update.
12967         (psymtab_discarder::~psymtab_discarder): Update.
12968         (ALL_OBJFILE_PSYMTABS): Rewrite.
12969         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12970         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12971         Remove fields.
12972         <partial_symtabs>: New field.
12973         (class objfile_psymtabs): Move from psymtab.h.  Update.
12974         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12975         psymbol_cache.
12976         (objfile::~objfile): Don't destroy psymbol_cache.
12977         * mdebugread.c (parse_partial_symbols): Update.
12978         * dwarf2read.c (create_addrmap_from_index)
12979         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12980         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12981         (add_partial_subprogram, dwarf2_ranges_read): Update.
12982         * dwarf-index-write.c (write_address_map)
12983         (write_one_signatured_type, recursively_write_psymbols)
12984         (class debug_names, class debug_names, write_psymtabs_to_index):
12985         Update.
12986
12987 2019-01-10  Tom Tromey  <tom@tromey.com>
12988
12989         * symtab.h (SYMBOL_SET_NAMES): Update.
12990         (symbol_set_names): Update.
12991         (MSYMBOL_SET_NAMES): Update.
12992         * symtab.c (symbol_set_names): Change argument to be an
12993         objfile_per_bfd_storage.
12994         * psymtab.c (add_psymbol_to_bcache): Update.
12995         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12996
12997 2019-01-10  Tom Tromey  <tom@tromey.com>
12998
12999         * symtab.c (create_demangled_names_hash): Change argument to be an
13000         objfile_per_bfd_storage.
13001         (symbol_set_names): Update.
13002
13003 2019-01-10  Tom Tromey  <tom@tromey.com>
13004
13005         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13006         init_psymbol_list.
13007         * psymtab.c (init_psymbol_list): Do nothing if already called.
13008         * psympriv.h (init_psymbol_list): Add comment.
13009         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13010         init_psymbol_list.
13011         * dbxread.c (dbx_symfile_read): Unconditionally call
13012         init_psymbol_list.
13013
13014 2019-01-10  Tom Tromey  <tom@tromey.com>
13015
13016         * xcoffread.c (scan_xcoff_symtab): Update.
13017         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13018         "where".
13019         * mdebugread.c (parse_partial_symbols)
13020         (handle_psymbol_enumerators): Update.
13021         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13022         * dbxread.c (read_dbx_symtab): Update.
13023         * psympriv.h (psymbol_placement): New enum.
13024         (add_psymbol_to_list): Update.
13025
13026 2019-01-10  Tom Tromey  <tom@tromey.com>
13027
13028         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13029         static_psymbols parameters.
13030         (scan_xcoff_symtab): Update.
13031         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13032         static_psymbols parameters.
13033         * psympriv.h (start_psymtab_common): Update.
13034         * mdebugread.c (parse_partial_symbols): Update.
13035         * dwarf2read.c (create_partial_symtab): Update.
13036         * dbxread.c (read_dbx_symtab): Update.
13037         (start_psymtab): Remove global_psymbols and static_psymbols
13038         parameters.
13039
13040 2019-01-10  Tom Tromey  <tom@tromey.com>
13041
13042         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13043         * psymtab.c (allocate_psymtab): Add comment.
13044         * psympriv.h (allocate_psymtab): Add comment.
13045         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13046         initializations.
13047         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13048
13049 2019-01-10  Tom Tromey  <tom@tromey.com>
13050
13051         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13052         Don't declare.
13053         * mipsread.c: Include mdebugread.h.
13054         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13055         Declare.
13056         * elfread.c: Include mdebugread.h.
13057
13058 2019-01-09  Tom Tromey  <tom@tromey.com>
13059
13060         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13061         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13062         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13063         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13064         (psym_lookup_symbol, psym_find_last_source_symtab)
13065         (psym_forget_cached_source_info, psym_print_stats)
13066         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13067         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13068         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13069         (psym_find_compunit_symtab_by_address)
13070         (maintenance_print_psymbols, maintenance_info_psymtabs)
13071         (maintenance_check_psymtabs): Use ranged for.
13072         * psymtab.h (class objfile_psymtabs): New.
13073         (require_partial_symbols): Return objfile_psymtabs.
13074         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13075
13076 2019-01-09  Tom Tromey  <tom@tromey.com>
13077
13078         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13079         (find_pc_mapped_section, list_overlays_command)
13080         (map_overlay_command, unmap_overlay_command)
13081         (simple_overlay_update): Use all_objfiles.
13082         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13083         * printcmd.c (info_symbol_command): Use all_objfiles.
13084         * objfiles.h (ALL_OBJSECTIONS): Remove.
13085         * maint.c (maintenance_translate_address): Use all_objfiles.
13086         * gcore.c (gcore_create_callback): Use all_objfiles.
13087         (objfile_find_memory_regions): Likewise.
13088
13089 2019-01-09  Tom Tromey  <tom@tromey.com>
13090
13091         * symtab.c (find_line_symtab, info_sources_command)
13092         (make_source_files_completion_list): Use objfile_compunits.
13093         * source.c (select_source_symtab): Use objfile_compunits.
13094         * objfiles.h (struct objfile): Update comment.
13095         (ALL_OBJFILES): Remove.
13096         (ALL_FILETABS): Remove.
13097         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13098         objfile_compunits.
13099
13100 2019-01-09  Tom Tromey  <tom@tromey.com>
13101
13102         * symmisc.c (print_objfile_statistics, dump_objfile)
13103         (maintenance_print_symbols): Use compunit_filetabs.
13104         * source.c (forget_cached_source_info_for_objfile): Use
13105         compunit_filetabs.
13106         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13107         (ALL_FILETABS): Use compunit_filetabs.
13108         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13109         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13110
13111 2019-01-09  Tom Tromey  <tom@tromey.com>
13112
13113         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13114         (compunit_filetabs): New.
13115         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13116         compunit_filetabs.
13117         (info_sources_command, make_source_files_completion_list): Remove
13118         declaration.
13119         * symmisc.c (print_objfile_statistics, dump_objfile)
13120         (maintenance_print_symbols): Remove declaration.
13121         (maintenance_info_symtabs): Use compunit_filetabs.
13122         (maintenance_info_line_tables): Likewise.
13123         * source.c (select_source_symtab): Change local variable name.
13124         (forget_cached_source_info_for_objfile): Remove declaration.
13125         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13126         * objfiles.c (objfile_relocate1): Remove declaration.
13127         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13128         declaration.
13129         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13130         * coffread.c (coff_symtab_read): Remove declaration.
13131         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13132         compunit_filetabs.
13133
13134 2019-01-09  Tom Tromey  <tom@tromey.com>
13135
13136         * symtab.c (lookup_objfile_from_block)
13137         (find_pc_sect_compunit_symtab, search_symbols)
13138         (default_collect_symbol_completion_matches_break_on): Use
13139         objfile_compunits.
13140         * objfiles.h (ALL_COMPUNITS): Remove.
13141         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13142         * cp-support.c (add_symbol_overload_list_qualified): Use
13143         objfile_compunits.
13144         * ada-lang.c (ada_collect_symbol_completion_matches)
13145         (ada_add_global_exceptions): Use objfile_compunits.
13146
13147 2019-01-09  Tom Tromey  <tom@tromey.com>
13148
13149         * source.c (select_source_symtab)
13150         (forget_cached_source_info_for_objfile): Remove declaration.
13151         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13152         declaration.
13153         * maint.c (count_symtabs_and_blocks): Remove declaration.
13154         * cp-support.c (add_symbol_overload_list_qualified): Remove
13155         declaration.
13156         * coffread.c (coff_symtab_read): Remove declaration.
13157         * symtab.c (lookup_symbol_in_objfile_symtabs)
13158         (basic_lookup_transparent_type_1): Use objfile_compunits.
13159         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13160         (info_sources_command, search_symbols)
13161         (default_collect_symbol_completion_matches_break_on)
13162         (make_source_files_completion_list): Remove declaration.
13163         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13164         (ada_collect_symbol_completion_matches)
13165         (ada_add_global_exceptions): Remove declaration.
13166         * linespec.c (iterate_over_all_matching_symtabs): Use
13167         objfile_compunits.
13168         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13169         (class objfile_compunits): New.
13170         (ALL_COMPUNITS): Use objfile_compunits.
13171         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13172         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13173         objfile_compunits.
13174         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13175
13176 2019-01-09  Tom Tromey  <tom@tromey.com>
13177
13178         * symtab.c (search_symbols)
13179         (default_collect_symbol_completion_matches_break_on): Use
13180         objfile_msymbols.
13181         * ada-lang.c (ada_lookup_simple_minsym)
13182         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13183         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13184         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13185         objfile_msymbols.
13186         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13187         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13188         * objc-lang.c (find_methods): Use objfile_msymbols.
13189         (info_selectors_command, info_classes_command): Likewise.
13190         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13191         * objfiles.h (class objfile_msymbols): New.
13192         (ALL_OBJFILE_MSYMBOLS): Remove.
13193         (ALL_MSYMBOLS): Remove.
13194
13195 2019-01-09  Tom Tromey  <tom@tromey.com>
13196
13197         * common/next-iterator.h (next_adapter): Add Iterator template
13198         parameter.
13199         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13200         (class all_objfiles_safe): New.
13201         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13202         * objfiles.c (put_objfile_before): Update comment.
13203         (add_separate_debug_objfile): Likewise.
13204         (free_all_objfiles): Use all_objfiles_safe.
13205         (objfile_purge_solibs): Likewise.
13206
13207 2019-01-09  Tom Tromey  <tom@tromey.com>
13208
13209         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13210         (expand_symtab_containing_pc, lookup_static_symbol)
13211         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13212         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13213         all_objfiles.
13214         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13215         * breakpoint.c (create_overlay_event_breakpoint)
13216         (create_longjmp_master_breakpoint)
13217         (create_std_terminate_master_breakpoint)
13218         (create_exception_master_breakpoint): Use all_objfiles.
13219         * linux-thread-db.c (try_thread_db_load_from_pdir)
13220         (has_libpthread): Use all_objfiles.
13221         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13222         * linespec.c (iterate_over_all_matching_symtabs)
13223         (search_minsyms_for_name): Use all_objfiles.
13224         * maint.c (maintenance_info_sections): Use all_objfiles.
13225         * main.c (captured_main_1): Use all_objfiles.
13226         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13227         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13228         * guile/scm-pretty-print.c
13229         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13230         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13231         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13232         (maintenance_print_msymbols): Use all_objfiles.
13233         * source.c (select_source_symtab): Use all_objfiles.
13234         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13235         * symfile.c (remove_symbol_file_command)
13236         (expand_symtabs_matching, map_symbol_filenames): Use
13237         all_objfiles.
13238         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13239         all_objfiles.
13240         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13241         * objc-lang.c (find_methods): Use all_objfiles.
13242         * objfiles.c (have_partial_symbols, have_full_symbols)
13243         (have_minimal_symbols, qsort_cmp)
13244         (default_iterate_over_objfiles_in_search_order): Use
13245         all_objfiles.
13246         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13247         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13248         (maintenance_check_psymtabs): Use all_objfiles.
13249         (ALL_PSYMTABS): Remove.
13250         * compile/compile-object-run.c (do_module_cleanup): Use
13251         all_objfiles.
13252         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13253         * cp-support.c (add_symbol_overload_list_qualified): Use
13254         all_objfiles.
13255         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13256         Use all_objfiles.
13257         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13258         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13259         all_objfiles.
13260         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13261         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13262         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13263         Uses all_objfiles.
13264         * solib.c (solib_read_symbols): Use all_objfiles
13265
13266 2019-01-09  Tom Tromey  <tom@tromey.com>
13267
13268         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13269         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13270         all_objfiles.
13271         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13272         * symmisc.c (print_symbol_bcache_statistics)
13273         (print_objfile_statistics, maintenance_print_objfiles)
13274         (maintenance_info_symtabs, maintenance_check_symtabs)
13275         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13276         all_objfiles.
13277         * source.c (forget_cached_source_info): Use all_objfiles.
13278         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13279         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13280         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13281         * objfiles.c (update_section_map): Use all_objfiles.
13282         (shared_objfile_contains_address_p): Likewise.
13283         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13284         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13285
13286 2019-01-09  Tom Tromey  <tom@tromey.com>
13287
13288         * common/next-iterator.h: New file.
13289         * objfiles.h (class all_objfiles): New.
13290         (struct objfile_iterator): New.
13291
13292 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13293
13294         * NEWS: Move the description of the changed "frame", "select-frame",
13295          and "info frame" commands to the Changed commands section.
13296
13297 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13298
13299         * gdbtypes.c (check_stub_method_group): Remove handling of old
13300         mangling schemes.
13301         * linespec.c (find_methods): Likewise.
13302         * stabsread.c (read_member_functions): Likewise.
13303         * valops.c (search_struct_method): Likewise.
13304         (value_struct_elt_for_reference): Likewise.
13305         * NEWS: Mention this change.
13306
13307 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13308
13309         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13310         print_source_lines.
13311         * source.c (print_source_lines_base): Update line number check.
13312         (print_source_lines): New function.
13313         (source_lines_range::source_lines_range): New function.
13314         * source.h (class source_lines_range): New class.
13315         (print_source_lines): New declaration.
13316
13317 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13318
13319         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13320
13321 2019-01-08  Tom Tromey  <tom@tromey.com>
13322             Simon Marchi  <simon.marchi@ericsson.com>
13323
13324         PR gdb/24060
13325         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13326         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13327         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13328         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13329         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13330         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13331
13332 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13333
13334         * source.c (select_source_symtab): Move header comment to
13335         declaration in source.h.
13336         (forget_cached_source_info_for_objfile): Likewise.
13337         (forget_cached_source_info): Likewise.
13338         (identify_source_line): Likewise.
13339         * source.h (identify_source_line): Move declaration from symtab.h
13340         and add comment from source.c
13341         (print_source_lines): Likewise.
13342         (forget_cached_source_info_for_objfile): Likewise.
13343         (forget_cached_source_info): Likewise.
13344         (select_source_symtab): Likewise.
13345         (enum print_source_lines_flag): Move definition from symtab.h.
13346         * symtab.h (identify_source_line): Move declaration to source.h.
13347         (print_source_lines): Likewise.
13348         (forget_cached_source_info_for_objfile): Likewise.
13349         (forget_cached_source_info): Likewise.
13350         (select_source_symtab): Likewise.
13351         (enum print_source_lines_flag): Move definition to source.h.
13352         * tui/tui-hooks.c: Add 'source.h' include.
13353
13354 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13355
13356         * source.c (print_source_lines_base): Handle requests to print
13357         reverse line number sequences, and guard against empty lines
13358         string.
13359
13360 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13361
13362         * source.c (print_source_lines_base): Fix skip of '\r' if next
13363         character is '\n'.
13364
13365 2019-01-06  Tom Tromey  <tom@tromey.com>
13366
13367         * c-exp.y (struct c_parse_state) <macro_original_text,
13368         expansion_obstack>: New member.
13369         (macro_original_text, expansion_obstack): Remove globals.
13370         (scan_macro_expansion, scanning_macro_expansion)
13371         (finished_macro_expansion): Update.
13372         (scan_macro_cleanup): Remove.
13373         (yylex, c_parse): Update.
13374
13375 2019-01-06  Tom Tromey  <tom@tromey.com>
13376
13377         * c-exp.y (struct c_parse_state) <strings>: New member.
13378         (operator_stoken): Update.
13379
13380 2019-01-06  Tom Tromey  <tom@tromey.com>
13381
13382         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13383         (union type_stack_elt) <typelist_val>: Now a pointer to
13384         std::vector.
13385         (type_stack_cleanup): Don't declare.
13386         (push_typelist): Update.
13387         * parse.c (pop_typelist): Return a std::vector.
13388         (push_typelist): Take a std::vector.
13389         (follow_types): Update.  Do not free args.
13390         (type_stack_cleanup): Remove.
13391         * c-exp.y (struct c_parse_state): New.
13392         (cpstate): New global.
13393         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13394         (nonempty_typelist): Update.
13395         (func_mod): Create a new vector.
13396         (c_parse): Create a c_parse_state.
13397         (check_parameter_typelist): Do not delete params.
13398         (function_method): Update.  Do not delete type_list.
13399
13400 2019-01-06  Tom Tromey  <tom@tromey.com>
13401
13402         PR gdb/28155:
13403         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13404         check_typedef.
13405         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13406         (print_return_value): Likewise.
13407
13408 2019-01-05  Tom Tromey  <tom@tromey.com>
13409
13410         * contrib/cleanup_check.py: Remove.
13411         * contrib/gcc-with-excheck: Remove.
13412         * contrib/exsummary.py: Remove.
13413         * contrib/excheck.py: Remove.
13414
13415 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13416
13417         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13418         NULL. Initialize tpprev to NULL instead of assigning it
13419         to NULL on the next statement.
13420         * windows-nat.c (windows_delete_thread): Remove check for
13421         main_thread_id before printing thread exit notifications.
13422         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13423         Remove thread ID check against main_thread_id.
13424         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13425         windows_delete_thread.
13426         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13427
13428 2019-01-04  Tom Tromey  <tom@tromey.com>
13429
13430         * compile/compile.c (_initialize_compile): Use upper case for
13431         metasyntactic variables.
13432         * symmisc.c (_initialize_symmisc): Use upper case for
13433         metasyntactic variables.
13434         * psymtab.c (_initialize_psymtab): Use upper case for
13435         metasyntactic variables.
13436         * demangle.c (demangle_command): Use upper case for metasyntactic
13437         variables.
13438         (_initialize_demangler): Likewise.
13439         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13440         variables.
13441
13442 2019-01-03  Tom Tromey  <tom@tromey.com>
13443
13444         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13445
13446 2019-01-03  Tom Tromey  <tom@tromey.com>
13447
13448         * python/py-symtab.c (salpy_str): Update.
13449         (struct salpy_sal_object) <symtab>: Now a PyObject.
13450         (salpy_dealloc): Update.
13451         (del_objfile_sal): Use gdbpy_ref.
13452
13453 2019-01-03  Tom Tromey  <tom@tromey.com>
13454
13455         * python/py-type.c (convert_field): Use new_reference.  Return
13456         gdbpy_ref.
13457         (make_fielditem): Return gdbpy_ref.
13458         (typy_fields): Update.
13459         (typy_getitem): Update.
13460         (field_name): Return gdbpy_ref.  Use new_reference.
13461         (typy_iterator_iternext): Update.
13462
13463 2019-01-03  Tom Tromey  <tom@tromey.com>
13464
13465         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13466
13467 2019-01-03  Tom Tromey  <tom@tromey.com>
13468
13469         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13470         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13471         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13472         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13473         (pspy_set_type_printers): Likewise.
13474         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13475         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13476         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13477         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13478         (objfpy_set_type_printers): Likewise.
13479
13480 2019-01-03  Tom Tromey  <tom@tromey.com>
13481
13482         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13483         (gdbpy_print_stack): Use gdbpy_err_fetch.
13484         * python/python-internal.h (class gdbpy_err_fetch): New class.
13485         (class gdbpy_enter) <m_error_type, m_error_value,
13486         m_error_traceback>: Remove.
13487         <m_error>: New member.
13488         (gdbpy_exception_to_string): Don't declare.
13489         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13490         * python/py-value.c (convert_value_from_python): Use
13491         gdbpy_err_fetch.
13492         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13493         gdbpy_exception_to_string.
13494         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13495         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13496         gdbpy_err_fetch.
13497
13498 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13499
13500         * linux-nat.c (delete_lwp_cleanup): Delete.
13501         (struct lwp_deleter): New struct.
13502         (lwp_info_up): New typedef.
13503         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13504         lwp_info_up.
13505
13506 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13507
13508         * linux-fork.c (class scoped_switch_fork_info): New class.
13509         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13510
13511 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13512
13513         * valops.c (find_overload_match): Remove use of null_cleanup, and
13514         calls to do_cleanups.
13515
13516 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13517
13518         * compile/compile-cplus-types.c
13519         (compile_cplus_instance::decl_name): Handle changes to
13520         cp_func_name.
13521         * cp-support.c (cp_func_name): Update header comment, update
13522         return type.
13523         * cp-support.h (cp_func_name): Update return type in declaration.
13524         * valops.c (find_overload_match): Move temp_func local to top
13525         level of function and change its type.  Use temp_func to hold and
13526         delete temporary string obtained from cp_func_name.
13527
13528 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13529
13530         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13531         gdb::char_vector, remove cleanup, and update uses of `msg`.
13532
13533 2019-01-03  Jim Wilson  <jimw@sifive.com>
13534
13535         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13536
13537 2019-01-02  Tom Tromey  <tom@tromey.com>
13538
13539         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13540         (tdesc_parse_xml): Remove cleanups.
13541         * target-descriptions.h (make_cleanup_free_target_description):
13542         Don't declare.
13543         (target_desc_deleter): New struct.
13544         (target_desc_up): New typedef.
13545         * target-descriptions.c (target_desc_deleter::operator()): Rename
13546         from free_target_description.
13547         (make_cleanup_free_target_description): Remove.
13548
13549 2019-01-02  Tom Tromey  <tom@tromey.com>
13550
13551         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13552         constructor, destructor.
13553         (linespec_parser): Remove typedef.
13554         (~linespec_parser): Rename from linespec_parser_delete.
13555         (linespec_lex_to_end, linespec_complete_label)
13556         (linespec_complete): Update.
13557         (decode_line_full): Remove cleanups.
13558         (decode_line_1): Update.
13559
13560 2019-01-02  Tom Tromey  <tom@tromey.com>
13561
13562         * python/python-internal.h (inferior_to_inferior_object): Change
13563         return type.
13564         * python/py-exitedevent.c (create_exited_event_object): Update.
13565         * python/py-inferior.c (inferior_to_inferior_object): Return
13566         gdbpy_ref.
13567         (python_new_inferior, python_inferior_deleted)
13568         (thread_to_thread_object, delete_thread_object)
13569         (build_inferior_list, gdbpy_selected_inferior): Update.
13570         * python/py-infthread.c (create_thread_object): Update.  Also fail
13571         if inferior_to_inferior_object fails.
13572
13573 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13574
13575         * inferior.h (class inferior) <displaced_step_state>: New field.
13576         * infrun.h (struct displaced_step_state): Move here from
13577         infrun.c.  Initialize fields, add constructor.
13578         <inf>: Remove field.
13579         <reset>: New method.
13580         * infrun.c (struct displaced_step_inferior_state): Move to
13581         infrun.h.
13582         (displaced_step_inferior_states): Remove.
13583         (get_displaced_stepping_state): Adust.
13584         (displaced_step_in_progress_any_inferior): Adjust.
13585         (displaced_step_in_progress_thread): Adjust.
13586         (displaced_step_in_progress): Adjust.
13587         (add_displaced_stepping_state): Remove.
13588         (get_displaced_step_closure_by_addr): Adjust.
13589         (remove_displaced_stepping_state): Remove.
13590         (infrun_inferior_exit): Call displaced_step_state.reset.
13591         (use_displaced_stepping): Don't check for NULL.
13592         (displaced_step_prepare_throw): Call
13593         get_displaced_stepping_state.
13594         (displaced_step_fixup): Don't check for NULL.
13595         (prepare_for_detach): Don't check for NULL.
13596
13597 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13598
13599         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13600          in case of call that did not complete.
13601
13602 2019-01-02  Andrey Utkin  <autkin@undo.io>
13603
13604         * symfile.c (find_separate_debug_file): Fix search of debug files for
13605         remote debuggee.
13606
13607 2019-01-02  Tom Tromey  <tom@tromey.com>
13608
13609         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13610         indentation.
13611         * python/py-frame.c (frapy_older): Remove cast.
13612         (frapy_newer): Likewise.
13613         * python/py-breakpoint.c (local_setattro): Remove cast.
13614         * python/py-arch.c (archpy_name): Remove local variable.
13615         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13616
13617 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13618
13619         * unittests/basic_string_view/element_access/char/empty.cc:
13620         Fix year range in copyright header.
13621
13622 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13623
13624         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13625         Delete.
13626         <operator==>: Update with for removed field.
13627         <hash>: Likewise.
13628         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13629         <isa_features>: ...this.
13630         <abi_features>: New field.
13631         (riscv_isa_flen): Update comment.
13632         (riscv_abi_xlen): New declaration.
13633         (riscv_abi_flen): New declaration.
13634         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13635         isa_features.
13636         (riscv_abi_xlen): New function.
13637         (riscv_isa_flen): Update to get answer from isa_features.
13638         (riscv_abi_flen): New function.
13639         (riscv_has_fp_abi): Update to get answer from abi_features.
13640         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13641         xlen and flen.
13642         (riscv_call_info) <xlen, flen>: Update comment.
13643         (riscv_call_arg_struct): Remove invalid assertions
13644         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13645         is removed.
13646         (riscv_gdbarch_init): Gather isa features and abi features
13647         separately, ensure both match on the gdbarch when reusing an old
13648         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13649         a target with 64-bit float hardware.
13650
13651 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13652
13653         * source.c (search_command_helper): Stop reverse search
13654         when line 1 has been searched.
13655
13656 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13657
13658         * record-full.c (record_full_base_target::close): Rewrite
13659         record_full_core_buf_list free logic.
13660
13661 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13662
13663         * break-catch-syscall.c (print_one_catch_syscall): xfree
13664         the last text.
13665
13666 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13667
13668         * top.c (print_gdb_version): Update Copyright year in version
13669         message.
13670
13671 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13672
13673         Update copyright year range in all GDB files.
13674
13675 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13676
13677         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13678
13679 For older changes see ChangeLog-2018.
13680 \f
13681 Local Variables:
13682 mode: change-log
13683 left-margin: 8
13684 fill-column: 74
13685 version-control: never
13686 coding: utf-8
13687 End:
13688