gdb/ChangeLog

   1 2019-10-16  Tom de Vries  <tdevries@suse.de>
   2
   3         PR tdep/25096
   4         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
   5         (amd64_classify_aggregate): ... here.
   6         (amd64_classify_aggregate_field): Handled fiels of nested structs
   7         recursively.
   8
   9 2019-10-16  Tom de Vries  <tdevries@suse.de>
  10
  11         PR tdep/24104
  12         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
  13         that handles 'theclass'.
  14
  15 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  16
  17         * linespec.c (decode_digits_ordinary): Update comment.
  18         * make-target-delegates: No longer need to handle VEC case.
  19         * memrange.c (normalize_mem_ranges): Update comment.
  20         * namespace.c (add_using_directive): Update comment.
  21         * objc-lang.c (uniquify_strings): Update comment.
  22         * ppc-linux-nat.c (struct thread_points): Update comment.
  23         * probe.h (find_probes_in_objfile): Update comment.
  24         * target.h (enum flash_preserve_mode): Update comment.
  25         * varobj.c (varobj_restrict_range): Update comment.
  26         * varobj.h (varobj_list_children): Update comment.
  27
  28 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * Makefile.in: Remove references to vec.h and vec.c.
  31         * aarch64-tdep.c: No longer include vec.h.
  32         * ada-lang.c: Likewise.
  33         * ada-lang.h: Likewise.
  34         * arm-tdep.c: Likewise.
  35         * ax.h: Likewise.
  36         * breakpoint.h: Likewise.
  37         * charset.c: Likewise.
  38         * cp-support.h: Likewise.
  39         * dtrace-probe.c: Likewise.
  40         * dwarf2read.c: Likewise.
  41         * extension.h: Likewise.
  42         * gdb_bfd.c: Likewise.
  43         * gdbsupport/gdb_vecs.h: Likewise.
  44         * gdbsupport/vec.c: Remove.
  45         * gdbsupport/vec.h: Remove.
  46         * gdbthread.h: Likewise.
  47         * guile/scm-type.c: Likewise.
  48         * inline-frame.c: Likewise.
  49         * machoread.c: Likewise.
  50         * memattr.c: Likewise.
  51         * memrange.h: Likewise.
  52         * namespace.h: Likewise.
  53         * nat/linux-btrace.h: Likewise.
  54         * osdata.c: Likewise.
  55         * parser-defs.h: Likewise.
  56         * progspace.h: Likewise.
  57         * python/py-type.c: Likewise.
  58         * record-btrace.c: Likewise.
  59         * rust-exp.y: Likewise.
  60         * solib-target.c: Likewise.
  61         * stap-probe.c: Likewise.
  62         * target-descriptions.c: Likewise.
  63         * target-memory.c: Likewise.
  64         * target.h: Likewise.
  65         * varobj.c: Likewise.
  66         * varobj.h: Likewise.
  67         * xml-support.h: Likewise.
  68
  69 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  70
  71         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
  72         Update for new std::vector based implementation.
  73         (process_psymtab_comp_unit_reader): Likewise.
  74         (scan_partial_symbols): Likewise.
  75         (recursively_compute_inclusions): Likewise.
  76         (compute_compunit_symtab_includes): Likewise.
  77         (process_imported_unit_die): Likewise.
  78         (queue_and_load_dwo_tu): Likewise.
  79         (follow_die_sig_1): Likewise.
  80         * gdb/dwarf2read.h: Remove DEF_VEC_P.
  81         (typedef dwarf2_per_cu_ptr): Remove.
  82         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
  83         function.
  84         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
  85         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
  86         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
  87         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
  88         std::vector.
  89
  90 2019-10-15  Tom Tromey  <tromey@adacore.com>
  91
  92         * windows-nat.c (windows_nat_target::resume): Use %x when logging
  93         TID.
  94
  95 2019-10-15  Tom Tromey  <tromey@adacore.com>
  96
  97         * windows-nat.c (windows_nat_target::fetch_registers)
  98         (windows_nat_target::store_registers): Rename "pid" to "tid".
  99
 100 2019-10-15  Tom Tromey  <tromey@adacore.com>
 101
 102         * gdbarch.h, gdbarch.c: Rebuild.
 103         * gdbarch.sh (gcc_target_options): Change return type to
 104         std::string.
 105         * compile/compile.c (get_args): Update.
 106         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 107         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 108         std::string.
 109         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 110         std::string.
 111         * arch-utils.c (default_gcc_target_options): Return std::string.
 112         * arch-utils.h (default_gcc_target_options): Return std::string.
 113         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 114
 115 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 116
 117         * breakpoint.c (breakpoint_chain): Make static.
 118         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 119         of accessing breakpoint_chain.
 120
 121 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 122
 123         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 124         to a gdb::function_view and return value to bool.
 125         * breakpoint.h (iterate_over_breakpoints): Likewise.
 126         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 127         (pop_dummy_frame): Update.
 128         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 129         (gdbscm_breakpoints): Update.
 130         * python/py-breakpoint.c (build_bp_list): Update.
 131         (gdbpy_breakpoints): Update.
 132         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 133         Update.
 134         (bpfinishpy_handle_stop): Update.
 135         (bpfinishpy_handle_exit): Update.
 136         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 137         (svr4_update_solib_event_breakpoints): Update.
 138
 139 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 140
 141         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 142         when unwrapping single-field structs.
 143
 144 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 145
 146         * dwarf2read.c: Remove includes.
 147
 148 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 149
 150         * ui-out.c (ui_out::call_do_message): Silence
 151         -Wformat-nonliteral warning.
 152
 153 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 154
 155         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 156         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 157         include: readline/tilde.h.
 158
 159 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 160
 161         * remote.c (remote_target::get_trace_status): Remove declaration of
 162         trace_regblock_size.
 163
 164 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 165
 166         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 167         (show_user): Remove declaration of cmdlist.
 168         * cli/cli-cmds.h (max_user_call_depth): Declare.
 169         * cli/cli-script.c (execute_user_command): Remove declaration
 170         of max_user_call_depth.
 171
 172 2019-10-11  Jim Wilson  <jimw@sifive.com>
 173
 174         * gdbsupport/print-utils.h (pulongest): Fix comment.
 175         (plongest): Likewise.
 176         (phex): Add missing comment, mention leading zeros.
 177         (phex_nz): Add mention of no leading zeros to comment.
 178
 179         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 180         plongest instead of unsigned long long cast.
 181
 182 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 183
 184         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 185         for external_editor_command and gdbtk_test.
 186
 187 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 188
 189         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 190         * varobj.c (varobjdebug): Move comment to...
 191         * varobj.h (varobjdebug): ...here, and declare.
 192
 193 2019-10-09  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 196         erase_data_content.
 197
 198 2019-10-09  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 201         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 202         * tui/tui-command.c (tui_cmd_window::resize)
 203         (tui_refresh_cmd_win): Update.
 204         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 205         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 206         * tui/tui-data.c (~tui_gen_win_info): Remove.
 207         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 208         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 209         (tui_redisplay_readline, tui_mld_flush)
 210         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 211         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 212         (tui_data_window::erase_data_content)
 213         (tui_data_item_window::rerender)
 214         (tui_data_item_window::refresh_window): Update.
 215         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 216         (box_win, tui_gen_win_info::make_window)
 217         (tui_gen_win_info::make_visible): Update.
 218         (tui_delete_win): Remove.
 219         * tui/tui-winsource.c
 220         (tui_source_window_base::do_erase_source_content): Update.
 221         (tui_show_source_line, tui_source_window_base::update_tab_width)
 222         (tui_source_window_base::update_exec_info): Update.
 223         * tui/tui-data.h (struct curses_deleter): New.
 224         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 225         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 226
 227 2019-10-09  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 230
 231 2019-10-09  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 234         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 235
 236 2019-10-09  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 239         window height directly.
 240         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 241         declare.
 242         * tui/tui-layout.c (tui_default_win_height): Remove.
 243         (tui_default_win_viewport_height): Remove.
 244
 245 2019-10-09  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui.h: Remove comments.
 248
 249 2019-10-09  Tom de Vries  <tdevries@suse.de>
 250
 251         * python/lib/gdb/printer/bound_registers.py: Use
 252         '^builtin_type_bound128' as regexp argument for
 253         add_builtin_pretty_printer.
 254
 255 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 256
 257         * guile/guile.c (guile_extension_script_ops): Remove forward
 258         declaration and mark as static.
 259         (guile_script_ops): Likewise.
 260         (extension_language_guile): Move further down in the file so
 261         it can reference the definitions for guile_{extension_,}script_ops.
 262
 263 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 264
 265         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 266         except SORTL, DFLTCC, and KDSA.
 267
 268 2019-10-08  Tom Tromey  <tromey@adacore.com>
 269
 270         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 271         (struct safe_symbol_file_add_args): Remove.
 272
 273 2019-10-08  Tom Tromey  <tromey@adacore.com>
 274
 275         * windows-nat.c: Don't include buildsym-legacy.h.
 276
 277 2019-10-08  Tom Tromey  <tromey@adacore.com>
 278
 279         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 280
 281 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 282
 283         * gdbtypes.c (overload_debug): Move comment to header.
 284         * gdbtypes.h (overload_debug): Declare.
 285         * valops.c: Remove declaration of overload_debug, instead
 286         include gdbtypes.h.
 287
 288 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 289
 290         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 291         through _().
 292         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 293         move comment...
 294         * language.h (lang_frame_mismatch_warn): ... here. Also add
 295         declaration.
 296         * top.c (lang_frame_mismatch_warn): Remove declaration.
 297         (check_frame_language_change): Pass lang_frame_mismatch_warn
 298         through _().
 299
 300 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 301
 302         * c-lang.h (vtbl_ptr_name): Declare.
 303         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 304         it from the header.
 305         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 306
 307 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 308
 309         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 310         gdb_static_assert.
 311
 312 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 313
 314         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 315         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 316         * ctfread.c: New file.
 317         * ctfread.h: New file.
 318         * elfread.c: Include ctfread.h.
 319         (struct elfinfo text_p): New member ctfsect.
 320         (elf_locate_sections): Mark CTF section.
 321         (elf_symfile_read): Call elfctf_build_psymtabs.
 322         * Makefile.in (LIBCTF): Add.
 323         (CLIBS): Use it.
 324         (CDEPS): Likewise.
 325         (DIST): Add ctfread.c.
 326
 327 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * ctfread.c (struct nextfield): Renamed to ...
 330         (struct ctf_nextfield): ... this.
 331         (struct field_info): Renamed to ...
 332         (strut ctf_field_info): ... this.
 333         (attach_fields_to_type): Update for renamed structures.
 334         (ctf_add_member_cb): Likewise.
 335         (ctf_add_enum_member_cb): Likewise.
 336         (process_struct_members): Likewise.
 337         (process_enum_type): Likewise.
 338
 339 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 340
 341         * tracectf.h: Rename, was ctf.h.
 342         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 343         * tracefile.c: Likewise.
 344         * tracepoint.c: Remove unused include ctf.h.
 345         * mi/mi-main.c: Likewise.
 346         * Makefile.in Replace ctf.c with tracectf.c.
 347
 348 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 349
 350         * version.in: Change version number to "9.0.50.DATE-git".
 351
 352 2019-10-03  Tom Tromey  <tom@tromey.com>
 353
 354         PR rust/24976:
 355         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 356
 357 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 358
 359         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 360         cp_search_name_hash.
 361         * NEWS: Add entry about nested function support.
 362
 363 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 364             Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 367         for nested static variables when searchin VAR_DOMAIN.
 368         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 369         global scope, update comment.
 370         (add_partial_subprogram): Call add_partial_subprogram recursively
 371         for nested subroutines when processinng Fortran.
 372         (load_partial_dies): Process the child entities of a subprogram
 373         when processing Fortran.
 374         (partial_die_parent_scope): Handle building scope
 375         for Fortran nested functions.
 376         (process_die): Record that nested functions have a scope.
 377         (new_symbol): Always record Fortran subprograms on the global
 378         symbol list.
 379         (determine_prefix): How to build the prefix for Fortran
 380         subprograms.
 381
 382 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 385         have just sent the thread a SIGSTOP and are waiting for it to
 386         arrive.
 387
 388 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 389
 390         * btrace.c (btrace_add_pc): Remove whitespace before the template
 391         parameter in 'std::vector <...>'.
 392         (parse_xml_btrace_block): Likewise.
 393         (btrace_maint_decode_pt): Likewise.
 394         (btrace_maint_update_packets): Likewise.
 395         (btrace_maint_print_packets): Likewise.
 396         * btrace.h (struct btrace_maint_info): Likewise.
 397         * dwarf2read.c (struct type_unit_group): Likewise.
 398         (build_type_psymtabs_reader): Likewise.
 399         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 400         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 401         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 402
 403 2019-10-03  Tom de Vries  <tdevries@suse.de>
 404
 405         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 406         the first line of the help text for set/show style metadata.
 407
 408 2019-10-02  Tom Tromey  <tromey@adacore.com>
 409
 410         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 411         * gdbsupport/common-inferior.c: New file.
 412         * infcmd.c (startup_with_shell): Don't define.
 413         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 414         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 415         * inferior.h (startup_with_shell): Don't declare.
 416
 417 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 418
 419         * gdbsupport/gdb_assert.h: Include errors.h.
 420         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 421
 422 2019-10-02  Tom Tromey  <tromey@adacore.com>
 423
 424         * NEWS: Add $_ada_exception entry.
 425         * ada-lang.c (struct ada_catchpoint): Add constructor.
 426         <m_kind>: New member.
 427         (allocate_location_exception, re_set_exception): Remove
 428         "ex" parameter.
 429         (should_stop_exception): Compute $_ada_exception.
 430         (check_status_exception, print_it_exception)
 431         (print_one_exception, print_mention_exception): Remove
 432         "ex" parameter.
 433         (allocate_location_catch_exception, re_set_catch_exception)
 434         (check_status_exception, print_it_catch_exception)
 435         (print_one_catch_exception, print_mention_catch_exception)
 436         (print_recreate_catch_exception)
 437         (allocate_location_catch_exception_unhandled)
 438         (re_set_catch_exception_unhandled)
 439         (check_status_exception, print_it_catch_exception_unhandled)
 440         (print_one_catch_exception_unhandled)
 441         (print_mention_catch_exception_unhandled)
 442         (print_recreate_catch_exception_unhandled)
 443         (allocate_location_catch_assert, re_set_catch_assert)
 444         (check_status_assert, print_it_catch_assert)
 445         (print_one_catch_assert, print_mention_catch_assert)
 446         (print_recreate_catch_assert)
 447         (allocate_location_catch_handlers, re_set_catch_handlers)
 448         (check_status_handlers, print_it_catch_handlers)
 449         (print_one_catch_handlers, print_mention_catch_handlers)
 450         (print_recreate_catch_handlers): Remove.
 451         (create_ada_exception_catchpoint): Update.
 452         (initialize_ada_catchpoint_ops): Update.
 453
 454 2019-10-02  Tom Tromey  <tromey@adacore.com>
 455
 456         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 457         (create_excep_cond_exprs): Simplify exception string computation.
 458         (ada_exception_catchpoint_cond_string): Likewise.
 459
 460 2019-10-02  Tom Tromey  <tromey@adacore.com>
 461
 462         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 463         * ada-lang.c (lesseq_defined_than): Handle
 464         LOC_STATIC.
 465         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 466         parameter.
 467         (dwarf2_has_info): Likewise.
 468         (new_symbol): Set maybe_copied on symbol when
 469         appropriate.
 470         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 471         parameter.
 472         <can_copy>: New member.
 473         * elfread.c (record_minimal_symbol): Set maybe_copied
 474         on symbol when appropriate.
 475         (elf_symfile_read): Update call to dwarf2_has_info.
 476         * minsyms.c (lookup_minimal_symbol_linkage): New
 477         function.
 478         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 479         * symtab.c (get_symbol_address, get_msymbol_address):
 480         New functions.
 481         * symtab.h (get_symbol_address, get_msymbol_address):
 482         Declare.
 483         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 484         maybe_copied.
 485         (struct symbol, struct minimal_symbol) <maybe_copied>:
 486         New member.
 487
 488 2019-10-02  Tom Tromey  <tromey@adacore.com>
 489
 490         * source.c (struct current_source_location): New.
 491         (current_source_key): New global.
 492         (current_source_symtab, current_source_line)
 493         (current_source_pspace): Remove.
 494         (get_source_location): New function.
 495         (get_current_source_symtab_and_line)
 496         (set_default_source_symtab_and_line)
 497         (set_current_source_symtab_and_line)
 498         (clear_current_source_symtab_and_line, select_source_symtab)
 499         (info_source_command, print_source_lines_base)
 500         (info_line_command, search_command_helper, _initialize_source):
 501         Update.
 502
 503 2019-10-02  Tom Tromey  <tromey@adacore.com>
 504
 505         * source.c (select_source_symtab): Don't call
 506         decode_line_with_current_source.
 507
 508 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         * symtab.c (lookup_global_symbol): Search global block.
 511
 512 2019-10-02  Tom Tromey  <tromey@adacore.com>
 513
 514         * coffread.c (process_coff_symbol): Update.
 515         * dwarf2read.c (var_decode_location, new_symbol): Update.
 516         * mdebugread.c (parse_symbol): Update.
 517         * objfiles.c (relocate_one_symbol): Update.
 518         * stabsread.c (define_symbol, fix_common_block)
 519         (scan_file_globals): Update.
 520         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 521         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 522         * xcoffread.c (process_xcoff_symbol): Update.
 523
 524 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 525
 526         * MAINTAINERS: Update my email address.
 527
 528 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 529
 530         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 531         std::vector.
 532         (build_type_psymtabs_reader): Update for std::vector.
 533         (build_type_psymtab_dependencies): Likewise.
 534         * dwarf2read.h: Remove use of DEF_VEC_P.
 535         (typedef sig_type_ptr): Delete.
 536
 537 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 540         to std::vector.
 541         (btrace_maint_decode_pt): Likewise, and move allocation of the
 542         vector outside of the loop.
 543         (btrace_maint_update_packets): Update to handle change from VEC to
 544         std::vector.
 545         (btrace_maint_print_packets): Likewise.
 546         (maint_info_btrace_cmd): Likewise.
 547         * btrace.h: Remove use of DEF_VEC_O.
 548         (typedef btrace_pt_packet_s): Delete.
 549         (struct btrace_maint_info) <packets>: Change fromm VEC to
 550         std::vector.
 551         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 552
 553 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 554
 555         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 556         make accesses into the vector constant references.
 557         (btrace_add_pc): Update for std::vector.
 558         (btrace_stitch_bts): Likewise.
 559         (parse_xml_btrace_block): Likewise.
 560         (btrace_maint_update_packets): Likewise.
 561         (btrace_maint_print_packets): Likewise.
 562         (maint_info_btrace_cmd): Likewise.
 563         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 564         std::vector.
 565         (btrace_data::empty): Likewise.
 566         (btrace_data_append): Likewise.
 567         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 568         (typedef btrace_block_s): Delete.
 569         (struct btrace_block): Add constructor.
 570         (struct btrace_data_bts) <blocks>: Change to std::vector.
 571         * nat/linux-btrace.c (perf_event_read_bts): Update for
 572         std::vector.
 573         (linux_read_bts): Likewise.
 574
 575 2019-10-01  Tom Tromey  <tom@tromey.com>
 576
 577         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 578
 579 2019-10-01  Tom Tromey  <tom@tromey.com>
 580
 581         * stack.c (print_frame, info_frame_command_core): Use
 582         styled_string.
 583         * linux-thread-db.c (try_thread_db_load_1)
 584         (try_thread_db_load_from_pdir_1): Use styled_string.
 585         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 586         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 587         (maybe_print_unsupported_script_warning)
 588         (maybe_print_script_not_found_warning): Use styled_string.
 589         * ada-lang.c (user_select_syms): Use styled_string.
 590
 591 2019-10-01  Tom Tromey  <tom@tromey.com>
 592
 593         * p-lang.c (pascal_printstr): Use metadata style.
 594         * value.c (show_convenience): Use metadata style.
 595         * valprint.c (valprint_check_validity, val_print_optimized_out)
 596         (val_print_not_saved, val_print_unavailable)
 597         (val_print_invalid_address, generic_val_print, val_print)
 598         (value_check_printable, val_print_array_elements): Use metadata
 599         style.
 600         * ui-out.h (class ui_out) <field_fmt>: New overload.
 601         <do_field_fmt>: Add style parameter.
 602         * ui-out.c (ui_out::field_fmt): New overload.
 603         * typeprint.c (type_print_unknown_return_type)
 604         (val_print_not_allocated, val_print_not_associated): Use metadata
 605         style.
 606         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 607         parameter.
 608         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 609         * tracepoint.c (tvariables_info_1): Use metadata style.
 610         * stack.c (print_frame_arg, print_frame_info, print_frame)
 611         (info_frame_command_core): Use metadata style.
 612         * skip.c (info_skip_command): Use metadata style.
 613         * rust-lang.c (rust_print_enum): Use metadata style.
 614         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 615         metadata style.
 616         * python/py-framefilter.c (py_print_single_arg): Use metadata
 617         style.
 618         * printcmd.c (do_one_display, print_variable_and_value): Use
 619         metadata style.
 620         * p-valprint.c (pascal_val_print)
 621         (pascal_object_print_value_fields): Use metadata style.
 622         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 623         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 624         parameter.
 625         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 626         * m2-valprint.c (m2_print_long_set): Use metadata style.
 627         * m2-typeprint.c (m2_print_type): Use metadata style.
 628         * infcmd.c (print_return_value_1): Use metadata style.
 629         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 630         * f-valprint.c (info_common_command_for_block): Use metadata
 631         style.
 632         * f-typeprint.c (f_type_print_base): Use metadata style.
 633         * expprint.c (print_subexp_standard): Use metadata style.
 634         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 635         * cli/cli-style.h (class cli_style_option): Add constructor.
 636         (metadata_style): Declare.
 637         * cli/cli-style.c (metadata_style): New global.
 638         (_initialize_cli_style): Register metadata style.
 639         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 640         parameter.
 641         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 642         * c-typeprint.c (c_type_print_base_struct_union)
 643         (c_type_print_base_1): Use metadata style.
 644         * breakpoint.c (watchpoint_value_print)
 645         (print_one_breakpoint_location): Use metadata style.
 646         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 647         style.
 648         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 649         style.
 650         * ada-valprint.c (val_print_packed_array_elements, printstr)
 651         (print_field_values, ada_val_print_ref, ada_val_print): Use
 652         metadata style.
 653         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 654         style.
 655         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 656         style.
 657         * ada-lang.c (user_select_syms): Use metadata style.
 658
 659 2019-10-01  Tom Tromey  <tom@tromey.com>
 660
 661         * cli/cli-cmds.c (pwd_command): Style output.
 662
 663 2019-10-01  Pedro Alves  <palves@redhat.com>
 664             Tom Tromey  <tom@tromey.com>
 665
 666         * symtab.c (print_symbol_info): Use %ps.
 667         (print_msymbol_info): Use %ps.
 668         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 669         * printcmd.c (print_variable_and_value): Use %ps.
 670         * macrocmd.c (show_pp_source_pos): Use %ps.
 671         * infrun.c (print_exited_reason): Use ui_out::message.
 672         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 673         (describe_other_breakpoints): Use ui_out::message and new
 674         formats.
 675         (say_where): Use new formats.
 676         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 677         and new formats.
 678
 679 2019-10-01  Pedro Alves  <palves@redhat.com>
 680             Tom Tromey  <tom@tromey.com>
 681
 682         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 683         (test_gdb_formats): New function.
 684         (run_tests): Call it.
 685         (test_format_specifier): Update.
 686         * utils.h (fputs_filtered): Update comment.
 687         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 688         (fputs_styled_unfiltered): Declare.
 689         * utils.c (fputs_styled_unfiltered): New function.
 690         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 691         (vfprintf_filtered): Update.
 692         (vfprintf_unfiltered, vprintf_filtered): Update.
 693         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 694         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 695         disallow_ui_out_field>: New constants.
 696         (enum class field_kind): New.
 697         (struct base_field_s, struct signed_field_s): New.
 698         (signed_field): New function.
 699         (struct string_field_s): New.
 700         (string_field): New function.
 701         (struct styled_string_s): New.
 702         (styled_string): New function.
 703         (class ui_out) <message>: Add comment.
 704         <vmessage, call_do_message>: New methods.
 705         <do_message>: Add style parameter.
 706         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 707         methods.
 708         (ui_out::message): Rewrite.
 709         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 710         parameter.
 711         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 712         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 713         gdb_extensions parameter.
 714         (class format_piece): Add parameter to constructor.
 715         (n_int_args): New field.
 716         * gdbsupport/format.c (format_pieces::format_pieces): Add
 717         gdb_extensions parameter.  Handle '*'.
 718         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 719         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 720         vfprintf_styled_no_gdbfmt.
 721         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 722         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 723         unfiltered output.
 724         * ui-style.h (struct ui_file_style) <ptr>: New method.
 725
 726 2019-10-01  Tom Tromey  <tom@tromey.com>
 727
 728         * unittests/format_pieces-selftests.c: Update.  Add final format.
 729         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 730         empty literal pieces.
 731
 732 2019-10-01  Tom Tromey  <tom@tromey.com>
 733
 734         * ui-out.h (enum class ui_out_style_kind): Remove.
 735         (class ui_out) <field_string, field_stsream, do_field_string>:
 736         Change type of "style".
 737         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 738         (ui_out::field_string): Update.
 739         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 740         of "style".
 741         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 742         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 743         * stack.c (print_frame_arg, print_frame_info, print_frame):
 744         Update.
 745         * source.c (print_source_lines_base): Update.
 746         * solib.c (info_sharedlibrary_command): Update.
 747         * skip.c (info_skip_command): Update.
 748         * record-btrace.c (btrace_call_history_src_line)
 749         (btrace_call_history): Update.
 750         * python/py-framefilter.c (py_print_frame): Update.
 751         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 752         "style".
 753         * mi/mi-out.c (mi_ui_out::do_table_header)
 754         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 755         (mi_ui_out::do_field_string): Update.
 756         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 757         Update.
 758         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 759         "style".
 760         * cli-out.c (cli_ui_out::do_table_header)
 761         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 762         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 763         (cli_ui_out::do_field_fmt): Update.
 764         * breakpoint.c (print_breakpoint_location): Update.
 765         (update_static_tracepoint): Update.
 766
 767 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 768
 769         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 770         conversion of gdb_datadir.
 771         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 772         remove not needed c_str ().
 773
 774 2019-09-30  Ali Tamur <tamur@google.com>
 775
 776         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 777         (dwarf2_string_attr): Likewise.
 778
 779 2019-09-30  Ali Tamur <tamur@google.com>
 780
 781         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 782         (process_full_type_unit): Likewise.
 783         (dump_die_shallow): Likewise.
 784         (cu_debug_loc_section): Likewise.
 785
 786 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 787
 788         * minsyms.c (compare_minimal_symbols): Rename to...
 789         (minimal_symbol_is_less_than): ...this, and adjust to STL
 790         conventions (return bool, take arguments as references)
 791         (minimal_symbol_reader::install): Call std::sort instead
 792         of qsort.
 793
 794 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 795
 796         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 797         hash and why.
 798         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 799         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 800
 801 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 802
 803         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 804         * psympriv.h (add_psymbol_to_list): Move comment here and update
 805         it.
 806
 807 2019-09-29  Tom de Vries  <tdevries@suse.de>
 808
 809         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 810         Use $tmpdir/$(basename "$output_file").dwz instead of
 811         "${output_file}.dwz".
 812
 813 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 814
 815         PR gdb/25045
 816         * hppa-linux-nat.c: Include gdbarch.h.
 817
 818 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 819
 820         * blockframe.c (find_pc_partial_function): Change return type to bool.
 821         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 822         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 823         (stub_gnu_ifunc_resolve_name): Likewise.
 824         * symtab.c (compare_filenames_for_search): Likewise.
 825         (compare_glob_filenames_for_search): Likewise.
 826         (matching_obj_sections): Likewise.
 827         (symbol_matches_domain): Likewise.
 828         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 829         (find_line_pc): Change return type to bool.
 830         (find_line_pc_range): Likewise.
 831         (producer_is_realview): Likewise.
 832         * symtab.h (symbol_matches_domain): Likewise.
 833         (find_pc_partial_function): Likewise.
 834         (find_pc_line_pc_range): Likewise.
 835         (in_gnu_ifunc_stub): Likewise.
 836         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 837         (find_line_pc): Likewise.
 838         (find_line_pc_range): Likewise.
 839         (matching_obj_sections): Likewise.
 840         (find_line_symtab): Change out parameter to bool.
 841         (producer_is_realview): Change return type to bool.
 842         (compare_filenames_for_search): Likewise.
 843         (compare_glob_filenames_for_search): Likewise.
 844
 845 2019-09-26  Tom Tromey  <tom@tromey.com>
 846
 847         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 848         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 849         * gdb_usleep.h: Remove.
 850         * gdb_usleep.c: Remove.
 851         * utils.c: Don't include gdb_usleep.h.
 852
 853 2019-09-26  Tom Tromey  <tromey@adacore.com>
 854
 855         * python/py-type.c (type_to_type_object): Call check_typedef
 856         for stub types.
 857
 858 2019-09-26  Tom Tromey  <tom@tromey.com>
 859
 860         * utils.h (initialize_utils): Don't declare.
 861         * top.c (gdb_init): Don't call initialize_utils.
 862         * utils.c (initialize_utils): Remove.  Move contents...
 863         (_initialize_utils): ... here.
 864
 865 2019-09-25  Tom Tromey  <tom@tromey.com>
 866
 867         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 868         * utils.h (make_hex_string): Don't declare.
 869         * utils.c (make_hex_string): Remove.
 870
 871 2019-09-24  Tom de Vries  <tdevries@suse.de>
 872
 873         PR gdb/23815
 874         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 875         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 876
 877 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 878
 879         * NEWS: Mention new simulator port for PRU.
 880
 881 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 882
 883         * ada-exp.y (write_object_remaining): Update.
 884         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 885         and eliminate the static buffer.
 886         (ada_decode_symbol): Update.
 887         (ada_la_decode): Update.
 888         (ada_sniff_from_mangled_name): Update.
 889         (is_valid_name_for_wild_match): Update.
 890         (ada_lookup_name_info::matches): Update and simplify.
 891         (name_matches_regex): Update.
 892         (ada_add_global_exceptions): Update.
 893         * ada-lang.h (ada_decode): Update signature.
 894         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 895         * dwarf-index-write.c (debug_names::insert): Update.
 896
 897 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 898
 899         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 900         formatting.
 901
 902 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 903
 904         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 905         Change "nonzero" to "true" in documentation.
 906
 907 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 908
 909         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 910         (_initialize_darwin_solib): Don't set
 911         darwin_so_ops.lookup_lib_global_symbol.
 912         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 913         set_gdbarch_iterate_over_objfiles_in_search_order.
 914         (elf_lookup_lib_symbol): Rename to...
 915         (svr4_iterate_over_objfiles_in_search_order): this, and update
 916         to iterate semantics.
 917         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 918         * solib.c (solib_global_lookup): Remove.
 919         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 920         (solib_global_lookup): Remove.
 921         * symtab.c (lookup_global_or_static_symbol): Remove call to
 922         solib_global_lookup.
 923
 924 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 925
 926         * NEWS: Move entries about default MI version now being
 927         version 3, and about the GDB/MI fix for multi-location
 928         breakpoints to the "since GDB 8.3" section.
 929
 930 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 931
 932         GDB 8.3.1 released.
 933
 934 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 935
 936         * NEWS: Mention that Cell/B.E. debugging support was removed.
 937         * MAINTAINERS: Remove spu target.
 938
 939         * config/djgpp/fnchange.lst: Remove entries for removed files.
 940
 941         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 942         spu-multiarch.o, and spu-tdep.o.
 943         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 944         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 945         spu-multiarch.c, and spu-tdep.c.
 946         * spu-linux-nat.c: Remove file.
 947         * spu-multiarch.c: Remove file.
 948         * spu-tdep.c: Remove file.
 949         * spu-tdep.h: Remove file.
 950         * solib-spu.c: Remove file.
 951         * solib-spu.h: Remove file.
 952
 953         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 954         * configure.nat (spu-linux): Remove.
 955         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 956         solib-multiarch.o from gdb_target_obs.
 957         (spu*-*-*): Remove.
 958
 959         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 960         feature flag.
 961         (ppc_linux_no_features): Update.
 962         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 963         Cell/B.E. support.
 964         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 965         (tdesc_powerpc_cell64l): Likewise.
 966         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 967         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 968         Cell/B.E. support.
 969         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 970         Do not include "features/rs6000/powerpc-cell32l.c" or
 971         "features/rs6000/powerpc-cell64l.c".
 972         (ppc_linux_spu_section): Remove.
 973         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 974         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 975         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 976         (ppc_linux_spe_context_lookup): Remove.
 977         (ppc_linux_spe_context_inferior_created): Remove.
 978         (ppc_linux_spe_context_solib_loaded): Remove.
 979         (ppc_linux_spe_context_solib_unloaded): Remove.
 980         (ppc_linux_spe_context): Remove.
 981         (struct ppu2spu_cache): Remove.
 982         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 983         (struct ppu2spu_data): Remove.
 984         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 985         ppu2spu_unwind): Remove.
 986         (ppc_linux_init_abi): Remove Cell/B.E. support.
 987         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 988
 989         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 990         (rs6000/powerpc-cell64l-expedite): Likewise
 991         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 992         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 993         rs6000/powerpc-cell64l.xml.
 994         * features/rs6000/powerpc-cell32l.xml: Remove.
 995         * features/rs6000/powerpc-cell64l.xml: Likewise.
 996         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 997         * features/rs6000/powerpc-cell64l.c: Likewise.
 998         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 999         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1000         * regformats/reg-spu.dat: Remove.
1001
1002         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1003         * corelow.c (struct spuid_list): Remove.
1004         (add_to_spuid_list): Remove.
1005         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1006         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1007         (remote_protocol_features): Remove associated entries.
1008         (_initialize_remote): No longer initialize them.
1009         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1010         * linux-nat.c (SPUFS_MAGIC): Remove.
1011         (linux_proc_xfer_spu): Remove.
1012         (spu_enumerate_spu_ids): Remove.
1013         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1014         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1015         (linux_make_corefile_notes): No longer call it.
1016
1017         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1018         (cooked_write_test): Likewise.
1019
1020 2019-09-20  Tom Tromey  <tom@tromey.com>
1021
1022         * NEWS: Mention case-sensitivity of TUI commands.
1023         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1024         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1025         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1026
1027 2019-09-20  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-source.c (tui_source_window::set_contents): Use
1030         make_unique_xstrdup.
1031         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1032         make_unique_xstrdup.
1033
1034 2019-09-20  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui-data.c: Remove separator comments.
1037         * tui/tui-layout.c: Remove separator comments.
1038         * tui/tui-win.c: Remove separator comments.
1039         * tui/tui-wingeneral.c: Remove separator comments.
1040
1041 2019-09-20  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui.h (strcat_to_buf): Don't declare.
1044         * tui/tui.c (strcat_to_buf): Remove.
1045
1046 2019-09-20  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1049         from "fullname".
1050         * tui/tui-source.c (tui_source_window::set_contents)
1051         (tui_source_window::location_matches_p)
1052         (tui_source_window::maybe_update): Update.
1053
1054 2019-09-20  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1057         Update.
1058         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1059         prefix.
1060         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1061         (tui_data_window::line_from_reg_element_no)
1062         (tui_data_window::first_reg_element_no_inline)
1063         (tui_data_window::show_registers)
1064         (tui_data_window::show_register_group)
1065         (tui_data_window::display_registers_from)
1066         (tui_data_window::display_registers_from_line)
1067         (tui_data_window::first_data_item_displayed)
1068         (tui_data_window::delete_data_content_windows)
1069         (tui_data_window::erase_data_content)
1070         (tui_data_window::do_scroll_vertical)
1071         (tui_data_window::refresh_window)
1072         (tui_data_window::check_register_values): Update.
1073
1074 2019-09-20  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1077         (struct tui_locator_window) <full_name, proc_name>: Now
1078         std::string.
1079         * tui/tui-stack.c (tui_locator_window::make_status_line)
1080         (tui_locator_window::set_locator_fullname)
1081         (tui_locator_window::set_locator_info): Update.
1082         * tui/tui-source.c (tui_source_window::set_contents)
1083         (tui_source_window::showing_source_p): Update.
1084
1085 2019-09-20  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1088         Don't call tui_locator_win_info_ptr.
1089
1090 2019-09-20  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1093
1094 2019-09-20  Tom Tromey  <tom@tromey.com>
1095
1096         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1097         height for locator.
1098         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1099         * tui/tui-layout.c (show_source_disasm_command, show_data)
1100         (show_source_or_disasm_and_command): Use 1 as height for locator.
1101
1102 2019-09-20  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui.c (tui_enable): Update.
1105         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1106         Update.
1107         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1108         Update.
1109         * tui/tui-data.c (win_resized): Now bool.
1110         (tui_win_resized): Return bool.
1111         (tui_set_win_resized_to): Accept a bool.
1112
1113 2019-09-20  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1116         Change type of "refresh_values_only".
1117         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1118         type of "refresh_values_only".
1119
1120 2019-09-20  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1123         std::string.
1124         (tui_disassemble): Add "pos" parameter.
1125         (tui_disasm_window::set_contents): Simplify.
1126
1127 2019-09-20  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-winsource.h (struct tui_source_window_base)
1130         <show_source_content>: Now private.
1131         * tui/tui-winsource.c
1132         (tui_source_window_base::show_source_content): Don't handle empty
1133         content case.
1134
1135 2019-09-20  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-layout.c (show_source_disasm_command)
1138         (show_source_or_disasm_and_command): Don't call
1139         show_source_content.
1140
1141 2019-09-20  Tom Tromey  <tom@tromey.com>
1142
1143         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1144         Declare.
1145         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1146         from tui_make_status_line.
1147         (tui_locator_window::rerender): Update.
1148
1149 2019-09-20  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1152         (tui_locator_window::rerender): Update.
1153
1154 2019-09-20  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-winsource.h (struct tui_source_window_base)
1157         <~tui_source_window_base>: Don't declare.
1158         <fullname>: Remove.
1159         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1160         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1161         member.
1162         * tui/tui-source.c (tui_source_window::set_contents): Update.
1163         (tui_source_window::location_matches_p)
1164         (tui_source_window::maybe_update): Update.
1165
1166 2019-09-20  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-winsource.h (~tui_source_element): Remove.
1169         (tui_source_element): Update.
1170         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1171         * tui/tui-winsource.c (tui_show_source_line): Update.
1172         * tui/tui-source.c (tui_source_window::set_contents): Update.
1173         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1174
1175 2019-09-20  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1178         declare.
1179         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1180         tui_clear_source_windows_detail.
1181         * tui/tui-winsource.h (struct tui_source_window_base)
1182         <clear_detail>: Don't declare.
1183         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1184         Remove.
1185         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1186
1187 2019-09-20  Tom Tromey  <tromey@adacore.com>
1188
1189         PR ada/24919:
1190         * block.c (contained_in): Fix final return value.
1191
1192 2019-09-20  Alan Modra  <amodra@gmail.com>
1193
1194         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1195         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1196         (read_indirect_string_from_dwz): Use bfd accessor.
1197         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1198         * machoread.c (macho_symfile_read_all_oso): Likewise.
1199         * solib.c (solib_bfd_open): Likewise.
1200
1201 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1202
1203         * eval.c: Move declaration of overload_resolution to...
1204         * value.h: ...here.
1205
1206 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1207
1208         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1209         * arm-linux-tdep.c: Likewise.
1210         * arm-nbsd-nat.c: Likewise.
1211         * arm-tdep.h: Declare arm_apcs_32.
1212         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1213
1214 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1215
1216         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1217         * dwarf2read.h: Declare dwarf_always_disassemble.
1218
1219 2019-09-19  Tom de Vries  <tdevries@suse.de>
1220
1221         PR gdb/25009
1222         * source-cache.c (source_cache::ensure): Catch exception thrown during
1223         construction of the highlighter.
1224
1225 2019-09-18  Alan Modra  <amodra@gmail.com>
1226
1227         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1228         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1229         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1230         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1231         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1232         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1233         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1234         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1235         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1236         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1237         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1238         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1239         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1240         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1241         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1242         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1243         * mi/mi-interp.c: Update throughout for bfd section macro and
1244         function changes.
1245         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1246         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1247
1248 2019-09-18  Tom Tromey  <tom@tromey.com>
1249
1250         * NEWS: Add entry.
1251         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1252         call rl_initialize.
1253         (tui_enable): Do not call rl_initialize.
1254
1255 2019-09-18  Christian Groessler  <chris@groessler.org>
1256
1257         * alpha-linux-nat.c: Include gdbarch.h.
1258
1259 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1260
1261         * ui-file.c: Include cli/cli-style.h.
1262         (term_cli_styling): Remove cli_styling declaration.
1263
1264 2019-09-18  Alan Modra  <amodra@gmail.com>
1265
1266         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1267         to bfd_asymbol_section.
1268
1269 2019-09-18  Alan Modra  <amodra@gmail.com>
1270
1271         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1272         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1273         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1274
1275 2019-09-18  Alan Modra  <amodra@gmail.com>
1276
1277         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1278         * spu-linux-nat.c (spu_bfd_open): Likewise.
1279
1280 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1281
1282         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1283         to bool to match definition in dwarf2read.c.
1284
1285 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1286
1287         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1288         (print_signatures): Likewise.
1289         (trust_pad_over_xvs): Likewise.
1290         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1291         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1292         * arm-linux-nat.c (arm_apcs_32): Likewise.
1293         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1294         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1295         * arm-tdep.c (arm_debug): Likewise.
1296         (arm_apcs_32): Likewise.
1297         * auto-load.c (debug_auto_load): Likewise.
1298         (auto_load_gdb_scripts): Likewise.
1299         (global_auto_load): Likewise.
1300         (auto_load_local_gdbinit): Likewise.
1301         (auto_load_local_gdbinit_loaded): Likewise.
1302         * auto-load.h (global_auto_load): Likewise.
1303         (auto_load_local_gdbinit): Likewise.
1304         (auto_load_local_gdbinit_loaded): Likewise.
1305         * breakpoint.c (disconnected_dprintf): Likewise.
1306         (breakpoint_proceeded): Likewise.
1307         (automatic_hardware_breakpoints): Likewise.
1308         (always_inserted_mode): Likewise.
1309         (target_exact_watchpoints): Likewise.
1310         (_initialize_breakpoint): Update.
1311         * breakpoint.h (target_exact_watchpoints): Change to bool.
1312         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1313         * cli/cli-cmds.c (trace_commands): Likewise.
1314         * cli/cli-cmds.h (trace_commands): Likewise.
1315         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1316         to bool*.
1317         * cli/cli-logging.c (logging_overwrite): Change to bool.
1318         (logging_redirect): Likewise.
1319         (debug_redirect): Likewise.
1320         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1321         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1322         to bool.
1323         <boolean_option_def>: Update.
1324         (struct flag_option_def): Change default type of Context to bool
1325         from int.
1326         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1327         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1328         (get_setshow_command_value_string): Likewise.
1329         * cli/cli-style.c (cli_styling): Change to bool.
1330         (source_styling): Likewise.
1331         * cli/cli-style.h (source_styling): Likewise.
1332         (cli_styling): Likewise.
1333         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1334         to bool.
1335         * command.h (var_types): Update comment.
1336         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1337         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1338         bool.
1339         (debug_compile_cplus_scopes): Likewise.
1340         * compile/compile-internal.h (compile_debug): Likewise.
1341         * compile/compile.c (compile_debug): Likewise.
1342         (struct compile_options) <raw>: Likewise.
1343         * cp-support.c (catch_demangler_crashes): Likewise.
1344         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1345         (usr_cmd_cris_dwarf2_cfi): Likewise.
1346         * csky-tdep.c (csky_debug): Likewise.
1347         * darwin-nat.c (enable_mach_exceptions): Likewise.
1348         * dcache.c (dcache_enabled_p): Likewise.
1349         * defs.h (info_verbose): Likewise.
1350         * demangle.c (demangle): Likewise.
1351         (asm_demangle): Likewise.
1352         * dwarf-index-cache.c (debug_index_cache): Likewise.
1353         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1354         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1355         * dwarf2read.c (check_physname): Likewise.
1356         (use_deprecated_index_sections): Likewise.
1357         (dwarf_always_disassemble): Likewise.
1358         * eval.c (overload_resolution): Likewise.
1359         * event-top.c (set_editing_cmd_var): Likewise.
1360         (exec_done_display_p): Likewise.
1361         * event-top.h (set_editing_cmd_var): Likewise.
1362         (exec_done_display_p): Likewise.
1363         * exec.c (write_files): Likewise.
1364         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1365         (debug_fbsd_nat): Likewise.
1366         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1367         Likewise.
1368         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1369         <backtrace_past_entry> Likewise.
1370         * gdb-demangle.h (demangle): Likewise.
1371         (asm_demangle): Likewise.
1372         * gdb_bfd.c (bfd_sharing): Likewise.
1373         * gdbcore.h (write_files): Likewise.
1374         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1375         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1376         * gdbthread.h (print_thread_events): Likewise.
1377         * gdbtypes.c (opaque_type_resolution): Likewise.
1378         (strict_type_checking): Likewise.
1379         * gnu-nat.c (gnu_debug_flag): Likewise.
1380         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1381         * guile/scm-param.c (pascm_variable): Add boolval.
1382         (add_setshow_generic): Update.
1383         (pascm_param_value): Update.
1384         (pascm_set_param_value_x): Update.
1385         * hppa-tdep.c (hppa_debug): Change to bool..
1386         * infcall.c (may_call_functions_p): Likewise.
1387         (coerce_float_to_double_p): Likewise.
1388         (unwind_on_signal_p): Likewise.
1389         (unwind_on_terminating_exception_p): Likewise.
1390         * infcmd.c (startup_with_shell): Likewise.
1391         * inferior.c (print_inferior_events): Likewise.
1392         * inferior.h (startup_with_shell): Likewise.
1393         (print_inferior_events): Likewise.
1394         * infrun.c (step_stop_if_no_debug): Likewise.
1395         (detach_fork): Likewise.
1396         (debug_displaced): Likewise.
1397         (disable_randomization): Likewise.
1398         (non_stop): Likewise.
1399         (non_stop_1): Likewise.
1400         (observer_mode): Likewise.
1401         (observer_mode_1): Likewise.
1402         (set_observer_mode): Update.
1403         (sched_multi): Change to bool.
1404         * infrun.h (debug_displaced): Likewise.
1405         (sched_multi): Likewise.
1406         (step_stop_if_no_debug): Likewise.
1407         (non_stop): Likewise.
1408         (disable_randomization): Likewise.
1409         * linux-tdep.c (use_coredump_filter): Likewise.
1410         (dump_excluded_mappings): Likewise.
1411         * linux-thread-db.c (auto_load_thread_db): Likewise.
1412         (check_thread_db_on_load): Likewise.
1413         * main.c (captured_main_1): Update.
1414         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1415         xx2_opt, boolean_opt>: Change to bool.
1416         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1417         * maint.c (maintenance_profile_p): Likewise.
1418         (per_command_time): Likewise.
1419         (per_command_space): Likewise.
1420         (per_command_symtab): Likewise.
1421         * memattr.c (inaccessible_by_default): Likewise.
1422         * mi/mi-main.c (mi_async): Likewise.
1423         (mi_async_1): Likewise.
1424         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1425         * nat/fork-inferior.h (startup_with_shell): Likewise.
1426         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1427         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1428         * nios2-tdep.c (nios2_debug): Likewise.
1429         * or1k-tdep.c (or1k_debug): Likewise.
1430         * parse.c (parser_debug): Likewise.
1431         * parser-defs.h (parser_debug): Likewise.
1432         * printcmd.c (print_symbol_filename): Likewise.
1433         * proc-api.c (procfs_trace): Likewise.
1434         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1435         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1436         (set_parameter_value): Update.
1437         (add_setshow_generic): Update.
1438         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1439         to bool*.
1440         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1441         int*.
1442         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1443         * record-btrace.c (record_btrace_target::store_registers): Update.
1444         * record-full.c (record_full_memory_query): Change to bool.
1445         (record_full_stop_at_limit): Likewise.
1446         * record-full.h (record_full_memory_query): Likewise.
1447         * remote-notif.c (notif_debug): Likewise.
1448         * remote-notif.h (notif_debug): Likewise.
1449         * remote.c (use_range_stepping): Likewise.
1450         (interrupt_on_connect): Likewise.
1451         (remote_break): Likewise.
1452         * ser-tcp.c (tcp_auto_retry): Likewise.
1453         * ser-unix.c (serial_hwflow): Likewise.
1454         * skip.c (debug_skip): Likewise.
1455         * solib-aix.c (solib_aix_debug): Likewise.
1456         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1457         (spu_auto_flush_cache_p): Likewise.
1458         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1459         Likewise.
1460         (struct info_print_options) <quiet>: Likewise.
1461         * symfile-debug.c (debug_symfile): Likewise.
1462         * symfile.c (auto_solib_add): Likewise.
1463         (separate_debug_file_debug): Likewise.
1464         * symfile.h (auto_solib_add): Likewise.
1465         (separate_debug_file_debug): Likewise.
1466         * symtab.c (basenames_may_differ): Likewise.
1467         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1468         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1469         (struct info_types_options) <quiet>: Likewise.
1470         * symtab.h (demangle): Likewise.
1471         (basenames_may_differ): Likewise.
1472         * target-dcache.c (stack_cache_enabled_1): Likewise.
1473         (code_cache_enabled_1): Likewise.
1474         * target.c (trust_readonly): Likewise.
1475         (may_write_registers): Likewise.
1476         (may_write_memory): Likewise.
1477         (may_insert_breakpoints): Likewise.
1478         (may_insert_tracepoints): Likewise.
1479         (may_insert_fast_tracepoints): Likewise.
1480         (may_stop): Likewise.
1481         (auto_connect_native_target): Likewise.
1482         (target_stop_and_wait): Update.
1483         (target_async_permitted): Change to bool.
1484         (target_async_permitted_1): Likewise.
1485         (may_write_registers_1): Likewise.
1486         (may_write_memory_1): Likewise.
1487         (may_insert_breakpoints_1): Likewise.
1488         (may_insert_tracepoints_1): Likewise.
1489         (may_insert_fast_tracepoints_1): Likewise.
1490         (may_stop_1): Likewise.
1491         * target.h (target_async_permitted): Likewise.
1492         (may_write_registers): Likewise.
1493         (may_write_memory): Likewise.
1494         (may_insert_breakpoints): Likewise.
1495         (may_insert_tracepoints): Likewise.
1496         (may_insert_fast_tracepoints): Likewise.
1497         (may_stop): Likewise.
1498         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1499         (make_thread_apply_all_options_def_group): Change argument from int*
1500         to bool*.
1501         (thread_apply_all_command): Update.
1502         (print_thread_events): Change to bool.
1503         * top.c (confirm): Likewise.
1504         (command_editing_p): Likewise.
1505         (history_expansion_p): Likewise.
1506         (write_history_p): Likewise.
1507         (info_verbose): Likewise.
1508         * top.h (confirm): Likewise.
1509         (history_expansion_p): Likewise.
1510         * tracepoint.c (disconnected_tracing): Likewise.
1511         (circular_trace_buffer): Likewise.
1512         * typeprint.c (print_methods): Likewise.
1513         (print_typedefs): Likewise.
1514         * utils.c (debug_timestamp): Likewise.
1515         (sevenbit_strings): Likewise.
1516         (pagination_enabled): Likewise.
1517         * utils.h (sevenbit_strings): Likewise.
1518         (pagination_enabled): Likewise.
1519         * valops.c (overload_resolution): Likewise.
1520         * valprint.h (struct value_print_options) <prettyformat_arrays,
1521         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1522         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1523         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1524         Likewise.
1525         * windows-nat.c (new_console): Likewise.
1526         (cygwin_exceptions): Likewise.
1527         (new_group): Likewise.
1528         (debug_exec): Likewise.
1529         (debug_events): Likewise.
1530         (debug_memory): Likewise.
1531         (debug_exceptions): Likewise.
1532         (useshell): Likewise.
1533         * windows-tdep.c (maint_display_all_tib): Likewise.
1534         * xml-support.c (debug_xml): Likewise.
1535
1536 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1537
1538         * source.c (prepare_path_for_appending): New function.
1539         (openp): Make use of new function.
1540         (find_and_open_source): Search for the compilation directory and
1541         source file as a relative path beneath the directory search path.
1542
1543 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1544
1545         * source-cache.c (source_cache::get_line_charpos): Catch
1546         exceptions and return false, this matches the behaviour documented
1547         in the header file.
1548
1549 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1550
1551         * ada-tasks.c (info_task): Remove quoting of the task's name.
1552
1553 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1554
1555         * symfile.c (auto_solib_add): Replace comment with a reference
1556         to the header file.
1557
1558 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1559
1560         * NEWS: Mention that gdb can now be compiled with Python 3
1561         on Windows.
1562
1563 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1564
1565         * maint.c (maint_print_section_data::maint_print_section_data):
1566         Force use of 'float log10 (float)' by casting the argument to
1567         float.
1568
1569 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * maint.c: Add 'cmath' include.
1572         (struct maint_print_section_data): New structure.
1573         (print_section_index): New function.
1574         (print_bfd_section_info): Add header comment, small whitespace
1575         cleanup, and update to call new print_section_index function.
1576         (print_objfile_section_info): Likewise.
1577         (maint_obj_section_from_bfd_section): New function.
1578         (print_bfd_section_info_maybe_relocated): New function.
1579         (maintenance_info_sections): Add header comment, always use
1580         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1581
1582 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1583
1584         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1585         inner scope, add check that the objfile has psymtabs before
1586         checking psymtabs_addrmap.
1587         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1588
1589 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1590
1591         * NEWS: Announce that Ada task names are now shown at more places,
1592         and between quotes (except in info task output).
1593         * gdb/ada-tasks.c (task_to_str): New function.
1594         (display_current_task_id): Call task_to_str.
1595         (task_command_1): Likewise.
1596         (print_ada_task_info): In non-mi mode, Properly align headers and data
1597         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1598
1599 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1600
1601         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1602         prstatus.pr_lwp.pr_info instead of making it up.
1603
1604 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1605
1606         * auto-load.c (auto_load_expand_dir_vars): Update.
1607         * defs.h (gdb_datadir): Change to std::string.
1608         (python_libdir): Likewise.
1609         (relocate_gdb_directory): Change return type to std::string.
1610         * guile/guile.c (gdbscm_data_directory): Update.
1611         (initialize_scheme_side): Update.
1612         * jit.c (jit_reader_dir): Change to std::string.
1613         (jit_reader_load_command): Update.
1614         * main.c (gdb_datadir): Change to std::string.
1615         (python_libdir): Likewise.
1616         (set_gdb_data_directory): Update.
1617         (relocate_path): Change to return std::string.
1618         (relocate_gdb_directory): Change to return std::string.
1619         (relocate_gdbinit_path_maybe_in_datadir): Update.
1620         (captured_main_1): Update.
1621         * python/python.c (do_start_initialization): Update.
1622         * top.c (show_gdb_datadir): Update.
1623         * xml-syscall.c (xml_init_syscalls_info): Update.
1624         (init_syscalls_info): Update.
1625
1626 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1627
1628         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1629         out of get_init_files.
1630         (get_init_files): Update.
1631
1632 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1633
1634         * main.c (get_init_files): Change to use std::string.
1635         (captured_main_1): Update.
1636         (print_gdb_help): Update.
1637
1638 2019-09-11  Ali Tamur  <tamur@google.com>
1639
1640         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1641         implementation.
1642
1643 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1644
1645         * dbxread.c (read_dbx_symtab): Update.
1646         * dwarf2read.c (load_partial_dies): Update.
1647         * mdebugread.c (parse_partial_symbols): Update.
1648         (handle_psymbol_enumerators): Update.
1649         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1650         * psymtab.c (add_psymbol_to_bcache): Likewise.
1651         (add_psymbol_to_list): Likewise.
1652         * symtab.c (symbol_set_names): Likewise.
1653         * symtab.h (symbol_set_names): Likewise.
1654         * xcoffread.c (scan_xcoff_symtab): Update.
1655
1656 2019-09-11  Tom Tromey  <tom@tromey.com>
1657
1658         * symfile-mem.c (symbol_file_add_from_memory): Use
1659         bfd_set_filename.
1660         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1661         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1662
1663 2019-09-10  Tom Tromey  <tromey@adacore.com>
1664
1665         * dwarf-index-write.c (write_psymbols): Extend error message.
1666         (debug_names::insert): Add Ada code.
1667         (debug_names::write_psymbols): Remove Ada check.
1668         (debug_names) <m_string_obstack>: New member.
1669         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1670         (gdb_index_symbol_name_matcher::matches): Remove.
1671         (mapped_index_base::find_name_components_bounds): Add "lang"
1672         parameter.
1673         (mapped_index_base::build_name_components): Also split names
1674         according to Ada syntax.
1675         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1676         type of "match_callback".
1677         (check_match, check_find_bounds_finds)
1678         (dw2_expand_symtabs_matching): Update.
1679         (dw2_debug_names_iterator): Add new constructor.
1680         (dw2_debug_names_map_matching_symbols): New function.
1681         (dw2_debug_names_expand_symtabs_matching): Update.
1682         (dwarf2_debug_names_functions): Use
1683         dw2_debug_names_map_matching_symbols.
1684
1685 2019-09-10  Tom Tromey  <tromey@adacore.com>
1686
1687         * dwarf2read.c (dw2_get_file_names_reader): Add the
1688         CU's file name to the results.
1689
1690 2019-09-10  Tom Tromey  <tromey@adacore.com>
1691
1692         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1693         map_matching_symbols.  Update.
1694         * dwarf2read.c (dw2_map_matching_symbols): Update.
1695         * psymtab.c (match_partial_symbol): Change type; update.
1696         (psym_map_matching_symbols): Likewise.
1697         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1698         type; update.
1699         * symfile.h (struct quick_symbol_functions)
1700         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1701         Remove "match".
1702
1703 2019-09-10  Tom Tromey  <tromey@adacore.com>
1704
1705         * psymtab.c (map_block): Remove.
1706         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1707         * symtab.c (iterate_over_symbols_terminated): New function.
1708         * symtab.c (iterate_over_symbols_terminated): Declare.
1709
1710 2019-09-10  Tom Tromey  <tromey@adacore.com>
1711
1712         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1713         * language.h (struct language_defn) <la_iterate_over_symbols>:
1714         Return bool.
1715         * symtab.c (iterate_over_symbols): Return bool.
1716         * symtab.h (iterate_over_symbols): Return bool.
1717
1718 2019-09-10  Tom Tromey  <tromey@adacore.com>
1719
1720         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1721         (add_nonlocal_symbols): Update.
1722         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1723         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1724         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1725         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1726         Change type of "callback".  Remove "data".
1727
1728
1729 2019-09-09  Ali Tamur  <tamur@google.com>
1730
1731         * dwarf2read.c (comp_unit_head): Update comment.
1732         (dwarf2_dwo_name): New function declaration.
1733         (dwarf_unit_type_name): New function declaration.
1734         (read_comp_unit_head): Add support for new compilation units,
1735         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1736         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1737         (currently named as "signature") in their header. Also clarify error
1738         messages.
1739         (lookup_dwo_id): New function. Returns the dwo id of the given
1740         compile unit.
1741         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1742         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1743         functions.
1744         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1745         (dwarf2_dwo_name): Get the dwo name if present.
1746         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1747         purposes.
1748
1749 2019-09-09  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1752
1753 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1754
1755         * python/python.c (do_start_initialization): Make progname_copy static,
1756         to avoid a leak report.
1757
1758 2019-09-08  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1761
1762 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1763
1764         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1765         Change type to gdb::optional<block_enum>.
1766         (dw2_symtab_iter_init): Change block_index parameter type
1767         to gdb::optional<block_enum>.
1768         (dw2_lookup_symbol): Change block_index parameter
1769         type to block_enum.c
1770         (dw2_debug_names_lookup_symbol): Likewise.
1771         * psymtab.c (psym_lookup_symbol): Likewise.
1772         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1773         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1774         Likewise.
1775
1776 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1777
1778         * defs.h (relocate_gdb_directory): Change int to bool in
1779         signature and rename flag to relocatable.
1780         * main.c (relocate_path): Likewise.
1781         (relocate_gdb_directory): Likewise.
1782
1783 2019-09-06  Alan Modra  <amodra@gmail.com>
1784
1785         * coffread.c (coff_symfile_read): Constify filename variable.
1786         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1787         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1788         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1789         * solib.c (reload_shared_libraries_1): Likewise.
1790         * symfile.c (reread_symbols): Likewise.
1791         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1792         * solib-darwin.c (darwin_bfd_open): Likewise.
1793         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1794
1795 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1796
1797         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1798         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1799
1800 2019-09-03  Tom Tromey  <tromey@adacore.com>
1801
1802         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1803         types.
1804         (has_negatives): Unbias a range type bound.
1805         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1806         * gdbtypes.c (operator==): Handle new field.
1807         (create_range_type): Add "bias" parameter.
1808         (create_static_range_type, resolve_dynamic_range): Update.
1809         * gdbtypes.h (struct range_bounds) <bias>: New member.
1810         (create_range_type): Add bias parameter.
1811         * printcmd.c (print_scalar_formatted): Unbias range types.
1812         * value.c (unpack_long): Unbias range types.
1813         (pack_long): Bias range types.
1814
1815 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1816
1817         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1818         probe arguments.
1819
1820 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1821
1822         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1823         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1824         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1825         (compile_probe_arg): Likewise.
1826         * probe.h (get_argument_count): Likewise.
1827         * solib-svr4.c (solib_event_probe_action): Likewise.
1828         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1829
1830 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1831
1832         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1833         code to here...
1834         (svr4_create_solib_event_breakpoints): ...from here.
1835
1836 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1837
1838         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1839         suffix from warning message.
1840
1841 2019-08-30  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-winsource.h (struct tui_source_window_base)
1844         <refresh_all>: Don't declare.
1845         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1846         Remove.
1847         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1848         tui_show_locator_content.
1849         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1850         declare.
1851         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1852         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1853         declare.
1854
1855 2019-08-30  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1858
1859 2019-08-30  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1862         Remove unnecessary forward declarations.
1863
1864 2019-08-30  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1867         rerender.
1868         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1869         tui_show_locator_content.
1870
1871 2019-08-30  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1874         (tui_locator_window::rerender): Rewrite using body of previous
1875         tui_show_locator_content.
1876
1877 2019-08-30  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1880         set_locator_fullname>: New methods.
1881         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1882         Rename from tui_set_locator_fullname.
1883         (tui_locator_window::set_locator_info): Rename from
1884         tui_set_locator_info.  Return bool.
1885         (tui_update_locator_fullname, tui_show_frame_info): Update.
1886
1887 2019-08-30  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1890
1891 2019-08-30  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1894         call touchwin.
1895
1896 2019-08-30  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-wingeneral.c (box_win): Assume win_info and
1899         win_info->handle cannot be NULL.
1900
1901 2019-08-30  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1904         refresh_window>: Declare.
1905         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1906         resize.
1907         (tui_data_item_window::rerender): Rename from
1908         tui_display_register.
1909         (tui_data_item_window::refresh_window): New method.
1910         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1911         no-op.
1912
1913 2019-08-30  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1916         regs_column_count, current_group>: Move later.  Now private.
1917         <get_current_group>: New method.
1918         * tui/tui-regs.c (tui_reg_command): Update.
1919         * tui/tui-layout.c (tui_set_layout): Update.
1920
1921 2019-08-30  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1924         (tui_data_window::rerender): Don't call
1925         check_and_display_highlight_if_needed.
1926         (tui_data_window::refresh_all): Remove call to
1927         erase_data_content.
1928
1929 2019-08-30  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1932         (tui_data_window::display_registers_from)
1933         (tui_data_window::display_reg_element_at_line)
1934         (tui_data_window::display_registers_from_line): Remove checks of
1935         "empty".
1936
1937 2019-08-30  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1940         Don't declare.
1941         * tui/tui-regs.c (tui_data_window::show_registers): Call
1942         rerender.
1943         (tui_data_window::rerender): Rename from display_all_data.
1944         (tui_data_window::rerender): Remove old implementation.
1945
1946 2019-08-30  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1949         text.
1950         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1951
1952 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1953             Sergio Durigan Junior  <sergiodj@redhat.com>
1954
1955         PR win32/24284
1956         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1957
1958 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1959
1960         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1961         when searching for types.
1962
1963 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1964
1965         * f-lang.c (f_language_defn): Use f_print_typedef.
1966         * f-lang.h (f_print_typedef): Declare.
1967         * f-typeprint.c (f_print_typedef): Define.
1968
1969 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1970
1971         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1972
1973 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1974
1975         * cli/cli-utils.c (info_print_options_defs): Delete.
1976         (make_info_print_options_def_group): Delete.
1977         (extract_info_print_options): Delete.
1978         (info_print_command_completer): Delete.
1979         (info_print_args_help): Add extra parameter, and optionally
1980         include text about -n flag.
1981         * cli/cli-utils.h (struct info_print_options): Delete.
1982         (extract_info_print_options): Delete declaration.
1983         (info_print_command_completer): Delete declaration.
1984         (info_print_args_help): Add extra parameter, extend header
1985         comment.
1986         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1987         search_symbols.
1988         * stack.c (struct info_print_options): New type.
1989         (info_print_options_defs): New file scoped variable.
1990         (make_info_print_options_def_group): New static function.
1991         (info_print_command_completer): New static function.
1992         (info_locals_command): Update to use new local functions.
1993         (info_args_command): Likewise.
1994         (_initialize_stack): Add extra parameter to calls to
1995         info_print_args_help.
1996         * symtab.c (search_symbols): Add extra parameter, use this to
1997         possibly excluse non-debug symbols.
1998         (symtab_symbol_info): Add extra parameter, which is passed on to
1999         search_symbols.
2000         (struct info_print_options): New type.
2001         (info_print_options_defs): New file scoped variable.
2002         (make_info_print_options_def_group): New static function.
2003         (info_print_command_completer): New static function.
2004         (info_variables_command): Update to use local functions, and pass
2005         extra parameter through to symtab_symbol_info.
2006         (info_functions_command): Likewise.
2007         (info_types_command): Pass additional argument through to
2008         symtab_symbol_info.
2009         (rbreak_command): Pass extra argument to search_symbols.
2010         (_initialize_symtab): Add extra arguments for calls to
2011         info_print_args_help, and update help text for 'info variables',
2012         'whereis', and 'info functions' commands.
2013         * symtab.h (search_symbols): Add extra argument to declaration.
2014         * NEWS: Mention new flags.
2015
2016 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2017
2018         * symtab.c (lookup_static_symbol): Call the new function (and move
2019         it down to be next to lookup_global_symbol).
2020         (struct global_sym_lookup_data): Add block_enum member and rename to...
2021         (struct global_or_static_sym_lookup_data): ...this.
2022         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2023         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2024         (lookup_symbol_global_or_static_iterator_cb): ...this.
2025         (lookup_global_or_static_symbol): New function.
2026         (lookup_global_symbol): Call new function.
2027
2028 2019-08-26  Tom de Vries  <tdevries@suse.de>
2029
2030         PR c++/24852
2031         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2032         when pc_probe.prob == NULL.
2033
2034 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2035
2036         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2037         variable symbol_linkage to symbol_linkage_.
2038
2039 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2040
2041         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2042         represent whether the symbol is static, dynamic, or we don't
2043         know.
2044
2045 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2046
2047         * gdb/rx-tdep.c (rx_register_names): New.
2048         (rx_register_name): Delete.
2049         (rx_psw_type): Delete.
2050         (rx_fpsw_type): Delete.
2051         (rx_register_type): Delete.
2052         (rx_gdbarch_init): Convert target-descriptions.
2053         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2054         * gdb/features/Makefile: Add rx.xml.
2055         * gdb/features/rx.xml: New.
2056         * gdb/features/rx.c: Generated.
2057         * gdb/NEWS: Mention target description support.
2058
2059 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2060
2061         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2062         *slot_ptr.
2063
2064 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2065
2066         * configure.ac: Don't check for 'dlfcn.h' (moved to
2067         gdbsupport/common.m4).
2068         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2069         'gdbsupport/'.
2070         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2071         * compile/compile-c-support.c: Include
2072         'gdbsupport/gdb-dlfcn.h'.
2073         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2074         * gdb-dlfcn.c: Move to...
2075         * gdbsupport/gdb-dlfcn.c: ... here.
2076         * gdb-dlfcn.h: Move to...
2077         * gdbsupport/gdb-dlfcn.h: ... here.
2078
2079 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2080
2081         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2082         the offset field signed.
2083
2084 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2085
2086         * python/lib/gdb/__init__.py (_execute_file): New function.
2087         * python/python.c (python_run_simple_file): Call gdb._execute_file
2088         on Windows.
2089
2090 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2091
2092         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2093         all uses as this was never set to anything but a zero value.
2094
2095 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2096
2097         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2098
2099 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2100
2101         * tui/tui-data.h (tui_gen_win_info): Add an =default
2102         move constructor, required by some GCC versions.
2103
2104 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2105
2106         * go32-nat.c (go32_sysinfo): Add hygon_p.
2107
2108 2019-08-20  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2111         line_from_reg_element_no, first_reg_element_no_inline,
2112         display_all_data, delete_data_content_windows,
2113         erase_data_content>: Now private.
2114
2115 2019-08-20  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2118         (tui_unhighlight_win, tui_highlight_win)
2119         (tui_win_info::make_window): Update.
2120         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2121
2122 2019-08-20  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2125         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2126         (MAX_PID_WIDTH): Move to tui-stack.c.
2127         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2128         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2129         (MAX_PID_WIDTH): Move from tui-data.h.
2130
2131 2019-08-20  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2134         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2135         (box_win): Update.
2136         (tui_gen_win_info::make_window): Rename from tui_make_window.
2137         (tui_win_info::make_window): New method.
2138         (tui_gen_win_info::make_visible): Update.
2139         * tui/tui-source.c (tui_source_window::set_contents): Update.
2140         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2141         (tui_data_window::display_registers_from): Update.
2142         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2143         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2144         Declare.
2145         <can_box>: Remove.
2146         <title>: Remove.
2147         (struct tui_win_info) <make_window>: Declare.
2148         <can_box>: Now virtual.
2149         <title>: New member.
2150         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2151         * tui/tui-command.c (tui_cmd_window::resize): Update.
2152
2153 2019-08-20  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2156         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2157         (tui_data_window::check_register_values): Update.
2158
2159 2019-08-20  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-regs.h (struct tui_data_window): Use
2162         DISABLE_COPY_AND_ASSIGN.
2163         <regs_content>: Change type, removing unique_ptr.
2164         <tui_data_window>: Add move constructor.
2165         * tui/tui-regs.c (tui_data_window::show_registers)
2166         (tui_data_window::show_register_group)
2167         (tui_data_window::display_registers_from)
2168         (tui_data_window::display_registers_from)
2169         (tui_data_window::first_data_item_displayed)
2170         (tui_data_window::delete_data_content_windows)
2171         (tui_data_window::rerender, tui_data_window::refresh_window)
2172         (tui_data_window::check_register_values): Update.
2173
2174 2019-08-20  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2177         show_register_group>: Declare.
2178         (tui_show_register_group): Don't declare.
2179         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2180         tui_show_registers.
2181         (tui_data_window::show_register_group): Rename from
2182         tui_show_register_group.
2183         (tui_data_window::check_register_values, tui_reg_command):
2184         Update.
2185         * tui/tui-layout.c (tui_set_layout): Update.
2186
2187 2019-08-20  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2190         Declare.
2191         (tui_check_register_values): Don't declare.
2192         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2193         from tui_check_register_values.
2194         * tui/tui-hooks.c (tui_register_changed): Update.
2195
2196 2019-08-20  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-regs.c (tui_reg_layout): Move later.
2199         (tui_show_registers): Don't enable TUI mode or change layout.
2200
2201 2019-08-20  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-regs.h (struct tui_data_item_window)
2204         <~tui_data_item_window>: Remove.
2205         <content>: Now a unique_xmalloc_ptr.
2206         * tui/tui-regs.c (tui_register_format): Return a
2207         unique_xmalloc_ptr.
2208         (tui_get_register): Update.
2209         (~tui_data_item_window): Remove.
2210         (tui_data_window::display_registers_from, tui_display_register):
2211         Update.
2212         * tui/tui-io.h (tui_expand_tabs): Update.
2213         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2214         Remove "col" parameter.
2215
2216 2019-08-20  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2219         field.
2220         * tui/tui-regs.c (~tui_data_item_window): Update.
2221
2222 2019-08-20  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2225         earlier.
2226
2227 2019-08-20  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2230
2231 2019-08-20  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-source.h (struct tui_source_window): Update.
2234         * tui/tui-regs.c (tui_show_registers): Update.
2235         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2236         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2237         (NO_REGS_STRING): Remove defines.
2238
2239 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2240
2241         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2242         unnecessary thread walk if remote doesn't support the packet.
2243
2244 2019-08-19  Tom Tromey  <tromey@adacore.com>
2245
2246         * python/py-value.c (value_has_field): Fix indentation.
2247
2248 2019-08-19  Tom Tromey  <tromey@adacore.com>
2249
2250         * printcmd.c (do_one_display, info_display_command): Update.
2251         * block.h (contained_in): Return bool.  Add allow_nested
2252         parameter.
2253         * block.c (contained_in): Return bool.  Add allow_nested
2254         parameter.
2255
2256 2019-08-19  Tom Tromey  <tom@tromey.com>
2257
2258         * configure: Rebuild.
2259         * configure.ac: Disallow the combination of -static-libstdc++ and
2260         source highlight.
2261         * source-cache.c (get_language_name): Handle rust.
2262         (source_cache::get_source_lines): Ignore highlighting exceptions.
2263
2264 2019-08-16  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2267         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2268         (struct tui_source_window_base) <make_visible, refresh_window,
2269         resize>: Remove methods.
2270         <execution_info>: Remove field.
2271         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2272         (tui_show_source_line, tui_source_window_base)
2273         (~tui_source_window_base): Update.
2274         (tui_source_window_base::resize)
2275         (tui_source_window_base::make_visible)
2276         (tui_source_window_base::refresh_window): Remove.
2277         (tui_source_window_base::update_exec_info): Update.
2278         * tui/tui-source.c (tui_source_window::set_contents): Update.
2279         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2280
2281 2019-08-16  Tom Tromey  <tom@tromey.com>
2282
2283         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2284         deprecated_query_hook.
2285
2286 2019-08-16  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2289         (tui_update_source_windows_with_line): Update.
2290         * tui/tui-source.h (struct tui_source_window)
2291         <show_symtab_source>: Declare.
2292         (tui_show_symtab_source): Don't declare.
2293         * tui/tui-source.c (tui_show_symtab_source): Rename from
2294         tui_show_symtab_source.
2295
2296 2019-08-16  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-winsource.h (struct tui_source_window_base)
2299         <set_contents>: Declare.
2300         * tui/tui-winsource.c
2301         (tui_source_window_base::update_source_window_as_is): Update.
2302         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2303         Declare.
2304         (tui_set_source_content): Don't declare.
2305         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2306         tui_set_source_content.
2307         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2308         Declare.
2309         (tui_set_disassem_content): Don't declare.
2310         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2311         tui_set_disassem_content.
2312
2313 2019-08-16  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-winsource.h (struct tui_source_window_base)
2316         <update_breakpoint_info>: Declare.
2317         (tui_update_breakpoint_info): Don't declare.
2318         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2319         (tui_update_all_breakpoint_info): Update.
2320         (tui_source_window_base::update_breakpoint_info): Rename from
2321         tui_update_breakpoint_info.
2322         (tui_source_window_base::update_exec_info): Update.
2323
2324 2019-08-16  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-winsource.h (struct tui_source_window_base)
2327         <update_source_window>: Declare.
2328         (tui_update_source_window): Don't declare.
2329         * tui/tui-winsource.c
2330         (tui_source_window_base::update_source_window): Rename from
2331         tui_update_source_window.
2332         (tui_source_window_base::rerender): Update.
2333         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2334         * tui/tui-disasm.c (tui_show_disassem)
2335         (tui_show_disassem_and_update_source)
2336         (tui_disasm_window::maybe_update): Update.
2337
2338 2019-08-16  Tom Tromey  <tom@tromey.com>
2339
2340         * tui/tui-winsource.h (struct tui_source_window_base)
2341         <update_source_window_as_is>: Declare.
2342         (tui_update_source_window_as_is): Don't declare.
2343         * tui/tui-winsource.c (tui_update_source_window): Update
2344         (tui_source_window_base::update_source_window_as_is): Rename from
2345         tui_update_source_window_as_is.
2346         (tui_source_window_base::refill): Update.
2347         * tui/tui-source.c (tui_show_symtab_source): Update.
2348         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2349         Update.
2350
2351 2019-08-16  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-winsource.h (tui_update_source_window)
2354         (tui_update_source_window_as_is): Remove "noerror" parameter.
2355         * tui/tui-winsource.c (tui_update_source_window)
2356         (tui_update_source_window_as_is): Remove "noerror" parameter.
2357         (tui_update_source_windows_with_addr)
2358         (tui_update_source_windows_with_line)
2359         (tui_source_window_base::rerender)
2360         (tui_source_window_base::refill): Update.
2361         * tui/tui-source.h (tui_set_source_content)
2362         (tui_show_symtab_source): Remove "noerror" parameter.
2363         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2364         parameter.
2365         (tui_show_symtab_source): Likewise.
2366         (tui_source_window::maybe_update): Update.
2367         * tui/tui-disasm.c (tui_show_disassem)
2368         (tui_show_disassem_and_update_source)
2369         (tui_disasm_window::do_scroll_vertical)
2370         (tui_disasm_window::maybe_update): Update.
2371
2372 2019-08-16  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui.c (tui_is_window_visible): Update.
2375         * tui/tui-wingeneral.c (tui_make_window)
2376         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2377         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2378         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2379         (tui_set_win_height_command, parse_scrolling_args): Update.
2380         * tui/tui-source.c (tui_source_window::style_changed): Update.
2381         * tui/tui-regs.c (tui_show_registers)
2382         (tui_data_window::first_data_item_displayed)
2383         (tui_data_window::delete_data_content_windows)
2384         (tui_check_register_values, tui_reg_command): Update.
2385         * tui/tui-disasm.c (tui_show_disassem): Update.
2386         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2387         method.
2388         <is_visible>: Remove field.
2389         * tui/tui-data.c (tui_next_win, tui_prev_win)
2390         (tui_delete_invisible_windows): Update.
2391
2392 2019-08-16  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui-winsource.h (struct tui_source_window_base)
2395         <m_has_locator>: Remove.
2396         * tui/tui-layout.c (show_source_disasm_command, show_data)
2397         (show_source_or_disasm_and_command): Update.
2398
2399 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2400
2401         * NEWS (Other MI changes): New subsection.
2402         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2403         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2404         * arch-utils.c (default_get_pc_address_flags): New function.
2405         * arch-utils.h (default_get_pc_address_flags): New declaration.
2406         * gdbarch.sh: Add get_pc_address_flags.
2407         * gdbarch.c: Regenerate.
2408         * gdbarch.h: Likewise.
2409         * stack.c (print_pc): New function.
2410         (print_frame_info) (print_frame): Call print_pc.
2411
2412 2019-08-16  Tom de Vries  <tdevries@suse.de>
2413
2414         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2415         print_objfile_section_info.
2416
2417 2019-08-15  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2420         calling update_cmdwin_start_line.
2421         * tui/tui-winsource.h (struct tui_source_window_base)
2422         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2423         <rerender>: Declare.
2424         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2425         Call rerender.
2426         (tui_source_window_base::set_new_height): Remove.
2427         (tui_source_window_base::rerender): Rename from
2428         do_make_visible_with_new_height.
2429         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2430         resize method.
2431         (tui_win_info::make_invisible_and_set_new_height)
2432         (tui_win_info::make_visible_with_new_height): Remove.
2433         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2434         Declare.
2435         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2436         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2437         do_make_visible_with_new_height>: Don't declare.
2438         <rerender>: Declare.
2439         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2440         set_new_height.
2441         (tui_data_window::do_make_visible_with_new_height): Remove.
2442         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2443         call tui_show_locator_content.
2444         (tui_gen_win_info::resize): Call rerender.
2445         (show_source_or_disasm_and_command): Don't call
2446         tui_show_locator_content.
2447         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2448         method.
2449         (struct tui_win_info) <rerender>: Declare.
2450         <set_new_height, make_invisible_and_set_new_height,
2451         make_visible_with_new_height>: Don't declare.
2452         * tui/tui-data.c (tui_win_list::rerender): New method.
2453         * tui/tui-command.h (struct tui_cmd_window)
2454         <do_make_visible_with_new_height>: Don't declare.
2455         * tui/tui-command.c
2456         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2457
2458 2019-08-15  Tom Tromey  <tromey@adacore.com>
2459
2460         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2461         * ada-lang.c (ada_enum_name): Likewise.
2462
2463 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2464
2465         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2466         leading underscore.
2467         (GdbOutputErrorFile): Likewise.
2468         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2469         accordingly.
2470         (execute_unwinders): Rename to have a leading underscore.
2471         (auto_load_packages): Likewise.
2472         (global scope): Adjust call to auto_load_packages accordingly.
2473         (GdbSetPythonDirectory): Likewise.
2474         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2475         instead of execute_unwinders.
2476
2477 2019-08-15  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2480         (show_data): Don't change window visibility.
2481         (tui_gen_win_info::resize): Remove special case for command
2482         window.  Use wresize, when available.
2483         (show_source_or_disasm_and_command): Don't change window
2484         visibility.
2485         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2486         <make_visible>: New method.
2487         * tui/tui-command.c (tui_cmd_window::resize): New method.
2488
2489 2019-08-15  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2492         (struct tui_source_windows): New.
2493         * tui/tui-winsource.c (tui_display_main): Update.
2494         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2495         (new_height_ok, parse_scrolling_args): Update.
2496         * tui/tui-layout.c (show_layout, show_data): Update.
2497         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2498         (tui_add_to_source_windows): Don't declare.
2499         * tui/tui-data.c (source_windows, tui_source_windows)
2500         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2501
2502 2019-08-15  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2505         Rename from reset.
2506         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2507         * tui/tui-layout.c (show_source_disasm_command, show_data):
2508         Update.
2509         (tui_gen_win_info::resize): Rename.
2510         (show_source_or_disasm_and_command): Update.
2511         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2512         reset.
2513
2514 2019-08-15  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2517         * tui/tui-interp.c (tui_interp::init): Don't call
2518         tui_initialize_static_data.
2519         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2520
2521 2019-08-15  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2524         examine tui_win_list.
2525
2526 2019-08-15  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2529         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2530         tui_clear_source_content.
2531         (tui_clear_source_content): Remove.
2532         (tui_source_window_base::do_erase_source_content): Hoist call to
2533         content.clear().
2534         * tui/tui-stack.c (tui_show_frame_info): Don't call
2535         tui_clear_source_content.
2536
2537 2019-08-15  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-winsource.h (struct tui_source_window_base)
2540         <do_erase_source_content>: New method.
2541         <erase_source_content>: New method.
2542         (tui_erase_source_content): Don't declare.
2543         * tui/tui-winsource.c (tui_clear_source_content): Update.
2544         (tui_source_window_base::do_erase_source_content): Rename from
2545         tui_erase_source_content.
2546         (tui_source_window_base::show_source_content): Update.
2547         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2548         * tui/tui-source.h (struct tui_source_window)
2549         <erase_source_content>: New method.
2550         * tui/tui-disasm.h (struct tui_disasm_window)
2551         <erase_source_content>: New method.
2552
2553 2019-08-15  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2556         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2557         constructor.
2558         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2559         * tui/tui-source.c (tui_set_source_content): Update.
2560         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2561
2562 2019-08-15  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2565         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2566         tui-source.c.
2567         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2568         Declare.
2569         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2570         method.
2571         (tui_source_window::maybe_update): Update.
2572
2573 2019-08-15  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2576         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2577         tui-disasm.c.
2578         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2579         Declare.
2580         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2581         method.
2582         (tui_disasm_window::maybe_update): Update.
2583
2584 2019-08-15  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-winsource.h (struct tui_source_window_base)
2587         <maybe_update>: Declare.
2588         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2589         method.
2590         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2591         Declare.
2592         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2593         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2594         Declare.
2595         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2596
2597 2019-08-15  Tom Tromey  <tom@tromey.com>
2598
2599         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2600
2601 2019-08-15  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-wingeneral.c: Include tui-stack.h.
2604         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2605         (struct tui_locator_window): Move from tui-data.h.
2606         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2607         (tui_initialize_static_data): Move from tui-data.c.
2608         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2609         (struct tui_locator_window): Move to tui-stack.c.
2610         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2611         (tui_initialize_static_data): Move to tui-stack.c.
2612
2613 2019-08-15  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-layout.c (show_source_disasm_command)
2616         (show_source_or_disasm_and_command): Use make_visible method, not
2617         tui_make_window.
2618         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2619         Remove.
2620
2621 2019-08-15  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-wingeneral.h (tui_make_window): Update.
2624         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2625         parameter.
2626         (tui_gen_win_info::make_visible): Update.
2627         * tui/tui-regs.c (tui_data_window::display_registers_from):
2628         Update.
2629         * tui/tui-layout.c (show_source_disasm_command)
2630         (show_source_or_disasm_and_command): Update.
2631         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2632         (enum tui_box): Remove.
2633         (struct tui_win_info) <can_box>: New method.
2634         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2635         method.
2636
2637 2019-08-15  Tom de Vries  <tdevries@suse.de>
2638
2639         * linux-nat-trad.c: Include gdbarch.h.
2640
2641 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2642
2643         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2644         register sizes.
2645
2646 2019-08-14  Tom Tromey  <tromey@adacore.com>
2647
2648         * darwin-nat.c: Include gdbarch.h.
2649         * darwin-nat-info.c: Include gdbarch.h.
2650
2651 2019-08-13  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2654         Remove.
2655         * tui/tui-data.c (tui_initialize_static_data): Update.
2656
2657 2019-08-13  Tom Tromey  <tom@tromey.com>
2658
2659         * tui/tui-winsource.h (struct tui_exec_info_window)
2660         <~tui_exec_info_window, maybe_allocate_content, get_content,
2661         m_content>: Remove.
2662         (struct tui_source_window_base) <set_exec_info_content,
2663         show_exec_info_content>: Don't declare.
2664         * tui/tui-winsource.c
2665         (tui_exec_info_window::maybe_allocate_content): Remove.
2666         (tui_source_window_base::update_exec_info): Rename from
2667         set_exec_info_content.
2668         (tui_source_window_base::show_exec_info_content)
2669         (tui_source_window_base::update_exec_info): Remove.
2670
2671 2019-08-13  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2674         declare.
2675         * tui/tui-winsource.c (tui_update_source_window_as_is)
2676         (tui_update_source_windows_with_addr, tui_erase_source_content):
2677         Update.
2678         (tui_clear_exec_info_content): Remove.
2679
2680 2019-08-13  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2683         declare.
2684         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2685         call tui_erase_exec_info_content.
2686         (tui_clear_exec_info_content): Rename from
2687         tui_erase_exec_info_content.
2688         (tui_clear_exec_info_content): Delete.
2689
2690 2019-08-13  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-winsource.h (struct tui_source_window_base)
2693         <show_exec_info_content>: Declare.
2694         (tui_show_exec_info_content): Don't declare.
2695         * tui/tui-winsource.c
2696         (tui_source_window_base::show_exec_info_content): Rename from
2697         tui_show_exec_info_content.
2698         (tui_source_window_base::update_exec_info): Update.
2699
2700 2019-08-13  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2703         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2704         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2705         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2706         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2707         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2708         ... here.
2709
2710 2019-08-13  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-winsource.h (struct tui_source_window_base)
2713         <update_exec_info>: Declare.
2714         (tui_update_exec_info): Don't declare.
2715         * tui/tui-winsource.c (tui_update_source_window_as_is)
2716         (tui_source_window_base::refresh_all)
2717         (tui_update_all_breakpoint_info): Update.
2718         (tui_source_window_base::update_exec_info): Rename from
2719         tui_update_exec_info.
2720         * tui/tui-stack.c (tui_show_frame_info): Update.
2721
2722 2019-08-13  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-winsource.h (struct tui_source_window_base)
2725         <set_exec_info_content>: Declare.
2726         (tui_set_exec_info_content): Don't declare.
2727         * tui/tui-winsource.c
2728         (tui_source_window_base::set_exec_info_content): Rename from
2729         tui_set_exec_info_content.
2730         (tui_update_exec_info): Update.
2731
2732 2019-08-13  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-winsource.h (struct tui_source_window_base)
2735         <show_source_content>: Declare.
2736         (tui_show_source_content): Don't declare.
2737         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2738         (tui_source_window_base::show_source_content): Rename from
2739         tui_show_source_content.
2740         (tui_source_window_base::refresh_all): Update.
2741         * tui/tui-layout.c (show_source_disasm_command)
2742         (show_source_or_disasm_and_command): Update.
2743
2744 2019-08-13  Tom Tromey  <tom@tromey.com>
2745
2746         * tui/tui-winsource.c (tui_erase_source_content)
2747         (tui_show_source_content, tui_source_window_base::refresh_all):
2748         Update.
2749         * tui/tui-wingeneral.h
2750         (tui_check_and_display_highlight_if_needed): Don't declare.
2751         * tui/tui-wingeneral.c
2752         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2753         check_and_display_highlight_if_needed.
2754         * tui/tui-win.c (tui_rehighlight_all)
2755         (tui_win_info::make_visible_with_new_height): Update.
2756         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2757         (tui_data_window::erase_data_content)
2758         (tui_data_window::display_all_data): Update.
2759         * tui/tui-data.h (struct tui_win_info)
2760         <check_and_display_highlight_if_needed>: Declare.
2761
2762 2019-08-13  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-win.c (tui_resize_all): Call
2765         tui_delete_invisible_windows.
2766         * tui/tui-layout.c (show_layout): Call
2767         tui_delete_invisible_windows.
2768         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2769         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2770
2771 2019-08-13  Tom Tromey  <tom@tromey.com>
2772
2773         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2774         tui_add_win_to_layout.
2775
2776 2019-08-13  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2779         * tui/tui-layout.c (tui_default_win_height): Now static.
2780
2781 2019-08-13  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2784         single switch.
2785         (show_source_disasm_command, show_source_or_disasm_and_command):
2786         Don't check current layout.
2787
2788 2019-08-13  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-wingeneral.c (make_all_visible): Remove.
2791         (tui_make_all_invisible): Simplify.
2792         * tui/tui-layout.c (tui_make_all_invisible): Move from
2793         tui-wingeneral.c; simplify.
2794         (show_layout): Hoist call to tui_make_all_invisible.
2795         (show_data): Don't call tui_make_all_invisible.
2796
2797 2019-08-13  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2800         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2801
2802 2019-08-13  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2805         tui-data.c.
2806         (show_source_disasm_command, show_data)
2807         (show_source_or_disasm_and_command): Don't use
2808         tui_set_current_layout_to.
2809         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2810         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2811         tui-layout.c.
2812         (tui_set_current_layout_to): Remove.
2813
2814 2019-08-13  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-layout.c (tui_set_layout): Update.
2817         * tui/tui-data.h (struct tui_layout_def): Remove.
2818         (tui_layout_def): Don't declare.
2819         * tui/tui-data.c (layout_def): Remove.
2820         (tui_layout_def): Remove.
2821
2822 2019-08-13  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-winsource.h (struct tui_source_window_base)
2825         <clear_detail>: No longer "override".
2826         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2827         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2828         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2829         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2830         Remove.
2831         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2832
2833 2019-08-13  Tom Tromey  <tromey@adacore.com>
2834
2835         * tracepoint.c: Don't include readline.h or history.h.
2836
2837 2019-08-12  Tom Tromey  <tom@tromey.com>
2838
2839         * configure: Rebuild.
2840         * configure.ac: Check for readline 7.
2841         * NEWS: Mention readline 7 requirement.
2842         * README: Update.
2843
2844 2019-08-12  Tom Tromey  <tom@tromey.com>
2845
2846         * mingw-hdep.c (gdb_select): Remove readline hack.
2847
2848 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2849
2850         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2851         when the function fails.
2852
2853 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2854
2855         * s390-tdep.c (s390_type_align): New function.
2856         (s390_gdbarch_init): Set it as type_align gdbarch method.
2857
2858 2019-08-09  Tom de Vries  <tdevries@suse.de>
2859
2860         PR gdb/24591
2861         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2862         pc_low with relocation offset.
2863
2864 2019-08-07  Tom Tromey  <tromey@adacore.com>
2865
2866         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2867         (print_frame_args): Update.
2868         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2869         Update.
2870         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2871         * frame.h (struct frame_arg): Add initializers.
2872         <error>: Now a unique_xmalloc_ptr.
2873
2874 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2875
2876         * NEWS: Expand the Pointer Authentication entry.
2877         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2878         (aarch64_frame_unmask_lr): ... to this.
2879         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2880         Call aarch64_frame_unmask_lr.
2881         * frame.c (struct frame_info): Add "masked" variable.
2882         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2883         (fprint_frame): Check for masked pc.
2884         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2885         declarations.
2886         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2887         * stack.c (print_frame): Check for masked pc.
2888
2889 2019-08-06  Tom Tromey  <tom@tromey.com>
2890
2891         * stabsread.c (patch_block_stabs, read_one_struct_field)
2892         (read_enum_type): Use obstack_strndup.
2893         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2894         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2895         * dwarf2read.c (guess_full_die_structure_name)
2896         (anonymous_struct_prefix): Use obstack_strndup.
2897         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2898         * c-exp.y (yylex): Use obstack_strndup.
2899         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2900         (write_var_or_type): Use obstack_strndup.
2901
2902 2019-08-06  Tom Tromey  <tom@tromey.com>
2903
2904         * symfile.c (reread_symbols): Use obstack_strdup.
2905         * stabsread.c (read_type): Use obstack_strdup.
2906         * gdb_obstack.h (obstack_strdup): New overload.
2907         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2908         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2909         (dwarf2_canonicalize_name): Use obstack_strdup.
2910         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2911         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2912         Use obstack_strdup.
2913
2914 2019-08-06  Tom Tromey  <tom@tromey.com>
2915
2916         * gdb_obstack.h (obstack_strdup): Define.
2917         * gdb_obstack.c (obstack_strdup): Don't define.
2918
2919 2019-08-06  Tom Tromey  <tom@tromey.com>
2920
2921         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2922         obstack_strdup.
2923         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2924         obstack_strdup.
2925         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2926         * stabsread.c (common_block_start): Use obstack_strdup.
2927         * objfiles.c (set_objfile_main_name, objfile): Use
2928         obstack_strdup.
2929         * namespace.c (add_using_directive): Use obstack_strdup.
2930         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2931         * jit.c (finalize_symtab): Use obstack_strdup.
2932         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2933         (guess_partial_die_structure_name, partial_die_info::fixup)
2934         (dwarf2_name): Use obstack_strdup.
2935         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2936         obstack_strdup.
2937         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2938         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2939         obstack_strdup.
2940         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2941
2942 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2943
2944         * unittests/help-doc-selftests.c: New file.
2945         * Makefile.in: Add the new file.
2946
2947 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2948
2949         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2950         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2951         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2952         the trailing '.' is not output, and the first character is uppercased.
2953         (print_help_for_command): Update call to print_doc_line.
2954         (print_doc_of_command): Likewise.
2955         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2956         * cli/cli-option.c (append_indented_doc): Do not append newline.
2957         (build_help_option): Append newline after first appended_indented_doc
2958         only if a second call is done.
2959         (build_help): Append 2 new lines before each option, except the first
2960         one.
2961         * compile/compile.c (_initialize_compile): Add new lines after
2962         %OPTIONS%, when not at the end of the help.
2963         Change help doc or code
2964         producing the help doc to respect the invariants.
2965         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2966         Also removed the new line after 'Options:', as all other commands
2967         do not put an empty line between 'Options:' and the first option.
2968         * printcmd.c (_initialize_printcmd): Likewise.
2969         * stack.c (_initialize_stack): Likewise.
2970         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2971         incorrectly telling COMMAND is optional.
2972         * ada-lang.c (_initialize_ada_language): Change help doc or code
2973         producing the help doc to respect the invariants.
2974         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2975         * breakpoint.c (_initialize_breakpoint): Likewise.
2976         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2977         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2978         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2979         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2980         _initialize_cli_style): Likewise.
2981         * corelow.c (core_target_info): Likewise.
2982         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2983         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2984         * filesystem.c (_initialize_filesystem): Likewise.
2985         * frame.c (_initialize_frame): Likewise.
2986         * gnu-nat.c (add_task_commands): Likewise.
2987         * infcall.c (_initialize_infcall): Likewise.
2988         * infcmd.c (_initialize_infcmd): Likewise.
2989         * interps.c (_initialize_interpreter): Likewise.
2990         * language.c (_initialize_language): Likewise.
2991         * linux-fork.c (_initialize_linux_fork): Likewise.
2992         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2993         * maint.c (_initialize_maint_cmds): Likewise.
2994         * memattr.c (_initialize_mem): Likewise.
2995         * printcmd.c (_initialize_printcmd): Likewise.
2996         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2997         _RegEx): Likewise.
2998         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2999         * record-btrace.c (_initialize_record_btrace): Likewise.
3000         * record-full.c (_initialize_record_full): Likewise.
3001         * record.c (_initialize_record): Likewise.
3002         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3003         * regcache.c (_initialize_regcache): Likewise.
3004         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3005         _initialize_remote): Likewise.
3006         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3007         * serial.c (_initialize_serial): Likewise.
3008         * skip.c (_initialize_step_skip): Likewise.
3009         * source.c (_initialize_source): Likewise.
3010         * stack.c (_initialize_stack): Likewise.
3011         * symfile.c (_initialize_symfile): Likewise.
3012         * symtab.c (_initialize_symtab): Likewise.
3013         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3014         * top.c (init_main): Likewise.
3015         * tracefile-tfile.c (tfile_target_info): Likewise.
3016         * tracepoint.c (_initialize_tracepoint): Likewise.
3017         * tui/tui-win.c (_initialize_tui_win): Likewise.
3018         * utils.c (add_internal_problem_command): Likewise.
3019         * valprint.c (value_print_option_defs): Likewise.
3020
3021 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3022
3023         PR build/24886
3024         * configure.ac: Drop enable-libmcheck support.
3025         * configure, config.in: Rebuild.
3026         * libmcheck.m4: Remove.
3027         * acinclude.m4: Don't include it.
3028         * Makefile.in: Don't distribute it.
3029         * top.c (print_gdb_configuration): Don't mention it.
3030
3031 2019-08-06  Tom Tromey  <tom@tromey.com>
3032
3033         * utils.c (set_output_style): Sometimes pass stream to
3034         emit_style_escape.
3035         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3036         * record-btrace.c (btrace_insn_history): Update.
3037         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3038         method.
3039         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3040         Update initializers.
3041         <m_uiout>: New field.
3042         <m_di>: Move lower.
3043         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3044         Remove "uiout" parameter.
3045         (dump_insns): Update.
3046         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3047         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3048
3049 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3050
3051         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3052         (error_in_psymtab_expansion): Likewise.
3053         (lookup_symbol_via_quick_fns): Likewise.
3054         (basic_lookup_transparent_type_quick): Likewise.
3055         (basic_lookup_transparent_type_1): Likewise.
3056
3057 2019-08-06  Tom Tromey  <tromey@adacore.com>
3058
3059         * source.c (last_source_error): Now bool.
3060         (print_source_lines_base): Make "noprint" bool.  Only open
3061         source file when last_source_visited changes.
3062
3063 2019-08-06  Tom Tromey  <tromey@adacore.com>
3064
3065         * annotate.c (annotate_source_line): Use g_source_cache.
3066         * source-cache.c (source_cache::get_plain_source_lines): Change
3067         parameters.  Populate m_offset_cache.
3068         (source_cache::ensure): New method.
3069         (source_cache::get_line_charpos): New method.
3070         (extract_lines): Move lower.  Change parameters.
3071         (source_cache::get_source_lines): Move lower.
3072         * source-cache.h (class source_cache): Update comment.
3073         <get_line_charpos>: New method.
3074         <get_source_lines>: Update comment.
3075         <clear>: Clear m_offset_cache.
3076         <get_plain_source_lines>: Change parameters.
3077         <ensure>: New method
3078         <m_offset_cache>: New member.
3079         * source.c (forget_cached_source_info_for_objfile): Update.
3080         (info_source_command): Use g_source_cache.
3081         (find_source_lines, open_source_file_with_line_charpos): Remove.
3082         (print_source_lines_base, search_command_helper): Use g_source_cache.
3083         * source.h (open_source_file_with_line_charpos): Don't declare.
3084         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3085         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3086         Use g_source_cache.
3087
3088 2019-08-06  Tom Tromey  <tromey@adacore.com>
3089
3090         * source-cache.c (source_cache::get_plain_source_lines):
3091         Remove "first_line" and "last_line" parameters.
3092         (source_cache::get_source_lines): Cache plain text.
3093         * source-cache.h (class source_cache)
3094         <get_plain_source_lines>: Update.
3095
3096 2019-08-06  Tom Tromey  <tromey@adacore.com>
3097
3098         * source-cache.c (extract_lines): No longer a method.
3099         Changed type of parameter.  Include final newline.
3100         (selftests::extract_lines_test): New function.
3101         (_initialize_source_cache): Likewise.
3102         * source-cache.h (class source_cache)
3103         <extract_lines>: Don't declare.
3104
3105 2019-08-06  Tom Tromey  <tromey@adacore.com>
3106
3107         * breakpoint.c (init_breakpoint_sal): Update.
3108         (breakpoint): Update.
3109         * breakpoint.h (struct breakpoint) <filter>: Now a
3110         unique_xmalloc_ptr.
3111
3112 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3113
3114         * NEWS: Mention dictionary access on blocks.
3115         * python/py-block.c (blpy_getitem): New function.
3116         (block_object_as_mapping): New struct.
3117         (block_object_type): Use new struct for tp_as_mapping field.
3118
3119 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3120
3121         * objfiles.h (objfile): Add a comment describing partial symbols.
3122
3123 2019-08-05  Tom Tromey  <tromey@adacore.com>
3124
3125         * compile/compile.c (_initialize_compile): Use _(), not N_().
3126         * thread.c (_initialize_thread): Use _(), not N_().
3127         * stack.c (_initialize_stack): Use _(), not N_().
3128         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3129
3130 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3131
3132         * dwarf2read.c (struct dw2_symtab_iterator):
3133         <want_specific_block>: Remove.
3134         <block_index>: Change type to gdb::optional.
3135         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3136         change type of BLOCK_INDEX parameter to gdb::optional.
3137         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3138         (dw2_lookup_symbol): Don't pass argument for
3139         WANT_SPECIFIC_BLOCK.
3140         (dw2_expand_symtabs_for_function): Don't pass argument for
3141         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3142         (class dw2_debug_names_iterator)
3143         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3144         parameter, change BLOCK_INDEX type to gdb::optional.
3145         <m_want_specific_block>: Remove.
3146         <m_block_index>: Change type to gdb::optional.
3147         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3148         gdb::optional.  Re-write in function of gdb::optional.
3149         (dw2_debug_names_lookup_symbol): Don't pass argument for
3150         WANT_SPECIFIC_BLOCK.
3151         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3152         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3153         BLOCK_INDEX.
3154
3155 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3156
3157         * NEWS: Mention changes to "info sources" command.
3158
3159 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3160
3161         * symtab.c (filename_partial_match_opts): New struct type.
3162         (struct output_source_filename_data): New members
3163         regexp, c_regexp, partial_match.
3164         (output_source_filename): Use new members to decide to print file.
3165         (info_sources_option_defs): New variable.
3166         (make_info_sources_options_def_group, print_info_sources_header,
3167         info_sources_command_completer):
3168         New functions.
3169         (info_sources_command): Read new optional arguments.
3170         (_initialize_symtab): Update info sources help.
3171
3172 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3173
3174         * ada-lang.c (exception_support_info_v0): Renamed from...
3175         (default_exception_support_info): ... this.  Create new
3176         definition for v1.
3177         (ada_has_this_exception_support): Look up catch_handlers_sym.
3178         (ada_exception_support_info_sniffer): Try v0 after default.
3179
3180 2019-08-01  Tom Tromey  <tromey@adacore.com>
3181
3182         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3183         gdbarch.h.
3184
3185 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3186
3187         * s12z-tdep.c: Fix include path for s12z-opc.h.
3188
3189 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3190
3191         * NEWS: Require GNU make 3.82.
3192
3193 2019-07-16  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3196         declare.
3197
3198 2019-07-30  Tom Tromey  <tromey@adacore.com>
3199
3200         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3201
3202 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3203
3204         * printcmd.c (print_address_symbolic): Print negative offsets.
3205         (build_address_symbolic): Force signed arithmetic when computing
3206         offset.
3207
3208 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3209
3210         PR/24474: Add a function to lookup static variables.
3211         * NEWS: Mention this new function.
3212         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3213         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3214         * python/python.c (python_GdbMethods): Add new function.
3215
3216 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3217
3218         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3219         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3220         (objfpy_lookup_static_symbol): New function.
3221         (objfile_object_methods): Add new functions.
3222
3223 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3224
3225         * NEWS: Mention 'set|show print frame-info'.  Mention new
3226         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3227         backtrace argument.  Mention that python frame filtering code
3228         is now consistent with what 'backtrace' command prints.
3229
3230 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3231
3232         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3233         comments.
3234         (print_frame_info_auto, print_frame_info_source_line,
3235         print_frame_info_location, print_frame_info_source_and_location,
3236         print_frame_info_location_and_address, print_frame_info_short_location):
3237         New declarations.
3238         (struct frame_print_options): New member print_frame_info.
3239         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3240         * stack.h (get_user_print_what_frame_info): New declaration.
3241         (frame_show_address): New declaration.
3242         * stack.c (print_frame_arguments_choices): New value 'presence'.
3243         (print_frame_info_auto, print_frame_info_source_line,
3244         print_frame_info_location, print_frame_info_source_and_location,
3245         print_frame_info_location_and_address, print_frame_info_short_location,
3246         print_frame_info_choices, print_frame_info_print_what): New definitions.
3247         (print_frame_args): Only print dots for args if print frame-arguments
3248         is 'presence'.
3249         (frame_print_option_defs): New element for "frame-info".
3250         (get_user_print_what_frame_info): New function.
3251         (frame_show_address): Make non static.  Move comment to stack.h.
3252         (print_frame_info_to_print_what): New function.
3253         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3254         to decide what to print.
3255         (backtrace_command_1): Handle the new print_frame_arguments_presence
3256         value.
3257         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3258         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3259         (py_print_frame): In non-mi mode, use LOCATION as default for
3260         print_what, similarly to frame information printed directly by
3261         backtrace command. Handle frame-info user option in non MI mode.
3262
3263 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3264
3265         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3266         Add case for debugging 32-bit target on 64-bit host.  Revise
3267         comment.
3268
3269 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3270
3271         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3272         instead of find_function_entry_range_from_pc.
3273
3274 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3275
3276         * stack.c (find_frame_funname): Remove code which preferred
3277         minsym over symtab sym in "certain pathological cases".
3278
3279         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3280         parameter.  Change type of "do_demangle" to bool.
3281         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3282         Pass suitable "prefer_sym_over_minsym" flag to
3283         build_address_symbolic().  Don't output "+" for negative offsets.
3284         * printcmd.c (print_address_symbolic): Update invocation of
3285         build_address_symbolic to include a "prefer_sym_over_minsym"
3286         flag.
3287         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3288         Restrict cases in which use of minimal symbol is preferred to that
3289         of a found symbol.  Update comments.
3290
3291         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3292         for entry pc when entry pc is out of range for that FDE.
3293
3294 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3295
3296         PR gdb/24839:
3297         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3298         type.
3299
3300 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3301
3302         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3303         this function's Python signature.
3304
3305
3306 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3307
3308         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3309         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3310         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3311         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3312         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3313
3314
3315 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3316
3317         * h8300-tdep.c (h8300_register_name_common): New.
3318         h8300_register_name): Use h8300_register_name_common.
3319         (h8300s_register_name): Likewise.
3320         (h8300sx_register_name): Likewise.
3321         (h8300h_register_nam): New.
3322         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3323
3324
3325 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3326
3327         * arm-tdep.c (arm_skip_cmse_entry): New function.
3328         (arm_is_sgstubs_section): New function.
3329         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3330
3331 2019-07-22  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3334         Don't self-assign.
3335
3336 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3337
3338         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3339         type_print.
3340
3341 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3342
3343         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3344         so that GDB doesn't match any msymbols when searching in the
3345         TYPES_DOMAIN.
3346         (print_symbol_info): Print using typedef_print or type_print based
3347         on the type of the symbol.  Add updated FIXME comment moved from...
3348         (_initialize_symtab): ... move and update FIXME comment to above.
3349
3350 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3351
3352         * NEWS: Mention adding -q option to "info types".
3353         * symtab.c (struct info_types_options): New struct.
3354         (info_types_options_defs): New variable.
3355         (make_info_types_options_def_group): New function.
3356         (info_types_command): Use gdb::option framework to parse options.
3357         (info_types_command_completer): New function.
3358         (_initialize_symtab): Extend the help text on "info types" and
3359         register command completer.
3360
3361 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3362
3363         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3364         (lookup_symbol_in_objfile): Change int to block_enum and add a
3365         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3366
3367 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3368
3369         * MAINTAINERS (Write After Approval): Add self.
3370
3371 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3374         instruction to the dummy code region.
3375
3376 2019-07-19  Tom Tromey  <tromey@adacore.com>
3377
3378         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3379         (ARGSUSED, PARAMS, __func__): Remove rules.
3380
3381 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3382
3383         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3384         * features/arm/arm-with-iwmmxt.c: Remove.
3385         * features/arm/arm-with-iwmmxt.xml: Remove.
3386         * features/arm/arm-with-m-fpa-layout.c: Remove.
3387         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3388         * features/arm/arm-with-m-vfp-d16.c: Remove.
3389         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3390         * features/arm/arm-with-m.c: Remove.
3391         * features/arm/arm-with-m.xml: Remove.
3392         * features/arm/arm-with-neon.c: Remove.
3393         * features/arm/arm-with-neon.xml: Remove.
3394         * features/arm/arm-with-vfpv2.c: Remove.
3395         * features/arm/arm-with-vfpv2.xml: Remove.
3396         * features/arm/arm-with-vfpv3.c: Remove.
3397         * features/arm/arm-with-vfpv3.xml: Remove.
3398
3399 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3400
3401         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3402
3403 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3404
3405         * arch/aarch32.c (aarch32_create_target_description): Create
3406         target descriptions using features.
3407         * arch/arm.c (arm_create_target_description)
3408         (arm_create_mprofile_target_description): Likewise.
3409         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3410
3411 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3412
3413         * Makefile.in: Add new files.
3414         * aarch32-tdep.c: New file.
3415         * aarch32-tdep.h: New file.
3416         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3417         Call aarch32_read_description.
3418         * arch/aarch32.c: New file.
3419         * arch/aarch32.h: New file.
3420         * arch/arm.c (arm_create_target_description)
3421         (arm_create_mprofile_target_description): New function.
3422         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3423         (arm_create_target_description)
3424         (arm_create_mprofile_target_description): New declaration.
3425         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3426         read_description functions.
3427         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3428         Likewise.
3429         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3430         * arm-tdep.c (tdesc_arm_list): New variable.
3431         (arm_register_g_packet_guesses): Call create description functions.
3432         (arm_read_description) (arm_read_mprofile_description): New
3433         function.
3434         * arm-tdep.h (arm_read_description)
3435         (arm_read_mprofile_description): Add declaration.
3436         * configure.tgt: Add new files.
3437
3438 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3439
3440         * top.c (new_ui_command): Open specified terminal just once.
3441
3442 2019-07-18  Tom Tromey  <tromey@adacore.com>
3443
3444         * symtab.c (main_name): Constify return type.
3445         * symfile.c (set_initial_language): Update.
3446         * symtab.h (main_name): Constify return type.
3447
3448 2019-07-17  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-winsource.c (tui_update_source_window)
3451         (tui_update_source_window_as_is)
3452         (tui_update_source_windows_with_line): Remove return.
3453         * tui/tui-disasm.c (tui_show_disassem)
3454         (tui_show_disassem_and_update_source): Remove return.
3455         * tui/tui.c (tui_reset): Remove return.
3456         * tui/tui-wingeneral.c
3457         (tui_check_and_display_highlight_if_needed): Remove return.
3458
3459 2019-07-17  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3462
3463 2019-07-17  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-winsource.h (struct tui_exec_info_window)
3466         (struct tui_source_window_base): Move from tui-data.h.
3467         * tui/tui-winsource.c: Move many method definitions from
3468         elsewhere.  Remove "structuring" comments.
3469         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3470         (tui_source_window_base::refresh_window): Move to
3471         tui-winsource.c.
3472         * tui/tui-win.c (tui_source_window_base::refresh_all)
3473         (tui_source_window_base::update_tab_width)
3474         (tui_source_window_base::set_new_height)
3475         (tui_source_window_base::do_make_visible_with_new_height): Move to
3476         tui-winsource.c.
3477         * tui/tui-source.h: Update.
3478         * tui/tui-source.c (tui_source_window_base::reset): Move to
3479         tui-winsource.c.
3480         * tui/tui-disasm.h: Update.
3481         * tui/tui-data.h (struct tui_exec_info_window): Move to
3482         tui-winsource.h.
3483         (struct tui_source_window_base): Likewise.
3484         * tui/tui-data.c (tui_source_window_base::clear_detail)
3485         (tui_source_window_base, ~tui_source_window_base): Move to
3486         tui-winsource.c.
3487
3488 2019-07-17  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-win.c (tui_resize_all)
3491         (tui_source_window_base::update_tab_width)
3492         (tui_adjust_win_heights): Update.
3493         (tui_win_info::make_invisible_and_set_new_height): Rename from
3494         make_invisible_and_set_new_height.
3495         * tui/tui-data.h (struct tui_win_info)
3496         <make_invisible_and_set_new_height>: New method.
3497
3498 2019-07-17  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui.c: Update.
3501         * tui/tui-source.h (struct tui_source_window): Move from
3502         tui-data.h.
3503         * tui/tui-layout.c: Update.
3504         * tui/tui-disasm.c: Update.
3505         * tui/tui-data.h (struct tui_source_window): Move to
3506         tui-source.h.
3507
3508 2019-07-17  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3511         tui-data.h.
3512         * tui/tui-data.h (struct tui_disasm_window): Move to
3513         tui-disasm.h.
3514
3515 2019-07-17  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui-regs.h (struct tui_data_item_window): Move from
3518         tui-data.h.
3519         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3520         * tui/tui-data.h (struct tui_data_item_window): Move to
3521         tui-regs.h.
3522         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3523
3524 2019-07-17  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui.c: Update.
3527         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3528         (tui_cmd_window::max_height): Move to tui-command.c.
3529         * tui/tui-layout.c: Update.
3530         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3531         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3532         tui-command.c.
3533         * tui/tui-command.h (struct tui_cmd_window): Move from
3534         tui-data.h.
3535         * tui/tui-command.c: Remove "structuring" comments.
3536         (tui_cmd_window::clear_detail)
3537         (tui_cmd_window::do_make_visible_with_new_height)
3538         (tui_cmd_window::max_height): Move from elsewhere.
3539
3540 2019-07-17  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3543         Now static.
3544         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3545         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3546
3547 2019-07-17  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui.c: Update.
3550         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3551         tui-regs.c.
3552         * tui/tui-windata.h: Remove file.
3553         * tui/tui-windata.c: Remove file.
3554         * tui/tui-win.c (tui_data_window::set_new_height)
3555         (tui_data_window::do_make_visible_with_new_height): Move to
3556         tui-regs.c.
3557         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3558         * tui/tui-regs.c: Remove "structuring" comments.
3559         (tui_data_window::first_data_item_displayed)
3560         (tui_data_window::delete_data_content_windows)
3561         (tui_data_window::erase_data_content)
3562         (tui_data_window::display_all_data)
3563         (tui_data_window::refresh_all)
3564         (tui_data_window::do_scroll_vertical)
3565         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3566         (tui_data_window::do_make_visible_with_new_height)
3567         (tui_data_window::refresh_window): Move from elsewhere.
3568         (_initialize_tui_regs): Move to end of file.
3569         * tui/tui-layout.c: Update.
3570         * tui/tui-hooks.c: Update.
3571         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3572         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3573         tui-regs.c.
3574         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3575
3576 2019-07-17  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3579         seen.
3580
3581 2019-07-17  Tom Tromey  <tom@tromey.com>
3582
3583         * tui/tui-win.c (tui_source_window_base::set_new_height)
3584         (tui_source_window_base::do_make_visible_with_new_height): Use
3585         m_has_locator field directly.
3586         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3587         method.
3588         (struct tui_source_window_base) <has_locator>: Likewise.
3589
3590 2019-07-17  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3593         Don't declare.
3594         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3595         Remove.
3596         * tui/tui-win.c (tui_source_window_base::set_new_height)
3597         (tui_source_window_base::set_new_height)
3598         (make_invisible_and_set_new_height)
3599         (tui_source_window_base::do_make_visible_with_new_height)
3600         (tui_source_window_base::do_make_visible_with_new_height):
3601         Update.
3602         * tui/tui-layout.c (show_source_disasm_command, show_data)
3603         (show_source_or_disasm_and_command): Update.
3604         * tui/tui-layout.c (show_layout): Update.
3605
3606 2019-07-17  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui-layout.c (make_data_window): Remove.
3609         (show_data): Unify creation and re-initialization cases.
3610
3611 2019-07-17  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-layout.c (make_source_window, make_disasm_window):
3614         Remove.
3615         (show_data): Unify creation and re-initialization cases.
3616
3617 2019-07-17  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-layout.c (make_command_window): Remove.
3620         (show_source_disasm_command, show_source_or_disasm_and_command):
3621         Unify creation and re-initialization cases.
3622
3623 2019-07-17  Tom Tromey  <tom@tromey.com>
3624
3625         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3626         creation and re-initialization cases.
3627
3628 2019-07-17  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-regs.c (tui_get_register): Return void.
3631
3632 2019-07-17  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3635         Simplify.
3636
3637 2019-07-17  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3640         resetting.
3641
3642 2019-07-17  Tom Tromey  <tom@tromey.com>
3643
3644         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3645         * tui/tui-regs.c (tui_reg_layout): New function.
3646         (tui_show_registers, tui_reg_command): Use it.
3647         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3648         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3649         parameters.
3650         (tui_layout_command): Remove.
3651
3652 2019-07-17  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-layout.h (tui/tui-layout): Return void.
3655         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3656
3657 2019-07-17  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-layout.c (show_source_disasm_command, show_data):
3660         Update.
3661         (reset_locator): Remove.
3662         (show_source_or_disasm_and_command): Update.
3663
3664 2019-07-17  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-source.c (tui_source_window_base::reset): Remove
3667         win_type parameter.
3668         * tui/tui-layout.c (make_command_window, make_source_window)
3669         (make_disasm_window, make_data_window)
3670         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3671         (reset_locator, show_source_or_disasm_and_command): Update.
3672         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3673         win_type parameter.
3674         (struct tui_source_window_base) <reset>: Likewise.
3675
3676 2019-07-17  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-layout.c (show_source_disasm_command): Use
3679         reset_locator.
3680         (reset_locator): New function.
3681         (init_and_make_win): Remove.
3682         (show_source_or_disasm_and_command): Use reset_locator.
3683
3684 2019-07-17  Tom Tromey  <tom@tromey.com>
3685
3686         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3687         condition.
3688         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3689         Remove condition.
3690         * tui/tui-source.c (tui_source_window_base::reset): New method.
3691         * tui/tui-layout.c (make_command_window): Don't call
3692         init_and_make_win.
3693         (make_source_window, make_disasm_window): Don't call
3694         make_source_or_disasm_window.
3695         (make_data_window): Don't call init_and_make_win.  Change calling
3696         convention.
3697         (show_source_disasm_command, show_data): Simplify.
3698         (make_source_or_disasm_window): Remove.
3699         (show_source_or_disasm_and_command): Simplify.
3700         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3701         (struct tui_source_window_base) <reset>: Likewise.
3702         <execution_info>: Remove initializer.
3703         * tui/tui-data.c (tui_source_window_base): Initialize
3704         execution_info.
3705
3706 2019-07-17  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3709         variable.
3710
3711 2019-07-17  Tom Tromey  <tom@tromey.com>
3712
3713         * tui/tui.c (tui_rl_other_window): Update.
3714         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3715         superclass method first.  Always iterate over regs_content.
3716         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3717         method.
3718         * tui/tui-win.c (tui_set_focus_command): Update.
3719
3720 2019-07-17  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-win.c (tui_set_focus_command): Rename from
3723         tui_set_focus.  Call tui_enable.
3724         (tui_set_focus_command): Remove.
3725
3726 2019-07-17  Tom Tromey  <tom@tromey.com>
3727
3728         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3729         refresh_window.
3730         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3731         touchwin.
3732         (tui_data_window::refresh_window): Call refresh_window on data
3733         items.  Always call superclass refresh_window.
3734         (tui_win_info::refresh): Remove.
3735         (tui_source_window_base::refresh_window): Update.
3736         (tui_refresh_all): Update.
3737         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3738         refresh_window.
3739         (show_source_or_disasm_and_command): Likewise.
3740         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3741         (struct tui_source_window_base) <refresh>: Likewise.
3742
3743 2019-07-17  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-winsource.c (tui_clear_source_content)
3746         (tui_show_source_content): Update.
3747         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3748         whether content is empty.
3749         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3750         Remove.
3751
3752 2019-07-17  Tom Tromey  <tom@tromey.com>
3753
3754         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3755         window's contents.
3756         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3757         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3758
3759 2019-07-17  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3762         (struct tui_data_item_window): Update.
3763
3764 2019-07-17  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3767         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3768         defines.
3769
3770 2019-07-17  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-winsource.h (tui_erase_source_content)
3773         (tui_clear_source_content): Remove "display_prompt" parameter.
3774         * tui/tui-winsource.c (tui_update_source_window_as_is)
3775         (tui_update_source_windows_with_addr): Update.
3776         (tui_clear_source_content): Remove "display_prompt" parameter.
3777         (tui_erase_source_content): Likewise.  Simplify.
3778         (tui_show_source_content): Update.
3779         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3780         * tui/tui-stack.c (tui_show_frame_info): Update.
3781         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3782         Remove defines.
3783
3784 2019-07-17  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3787         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3788         parameter.
3789         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3790         parameter.
3791
3792 2019-07-17  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-winsource.c (tui_clear_source_content)
3795         (tui_show_source_content, tui_show_exec_info_content)
3796         (tui_clear_exec_info_content): Update.
3797         * tui/tui-stack.c (tui_show_locator_content): Update.
3798         (tui_show_frame_info): Update.
3799         * tui/tui-source.h (tui_source_window): Don't declare.
3800         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3801         from tui_source_is_displayed.
3802         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3803         Remove field.
3804         (struct tui_source_window_base) <content_in_use>: New field.  Now
3805         bool.
3806         (struct tui_source_window) <showing_source_p>: New method.
3807         (TUI_SRC_WIN): Change cast.
3808         * tui/tui-data.c (tui_initialize_static_data): Update.
3809
3810 2019-07-17  Tom Tromey  <tom@tromey.com>
3811
3812         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3813         location_matches_p.
3814         * tui/tui-source.c (tui_source_window::location_matches_p): New
3815         method.
3816         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3817         method.
3818         * tui/tui-data.h (struct tui_source_window_base)
3819         <location_matches_p>: New method.
3820         (struct tui_source_window, struct tui_disasm_window)
3821         <location_matches_p>: Likewise.
3822
3823 2019-07-17  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-win.c (tui_set_win_height_command): Rename from
3826         tui_set_win_height.
3827         (tui_set_win_height_command): Remove.
3828
3829 2019-07-17  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-source.c (tui_source_window): New constructor.  Add
3832         observer.
3833         (~tui_source_window): New destructor.
3834         (tui_source_window::style_changed): New method.
3835         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3836         (tui_attach_detach_observers): Update.
3837         * tui/tui-data.h (struct tui_source_window): Make constructor not
3838         inline.  Add destructor.
3839         (struct tui_source_window) <style_changed>: New method.
3840         <m_observable>: New member.
3841
3842 2019-07-17  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3845         * tui/tui-win.c (tui_resize_all): Fix typo.
3846
3847 2019-07-17  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3850         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3851         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3852         * tui/tui-win.c (window_name_completer): Use foreach.
3853         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3854         (update_tab_width): Likewise.
3855         * tui/tui-layout.c (show_layout): Update.
3856         * tui/tui-data.h (class tui_window_iterator): New.
3857         (struct all_tui_windows): New.
3858         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3859
3860 2019-07-17  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3863         parameter.  Don't reference globals.
3864         (tui_reg_command): Update.
3865
3866 2019-07-17  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-regs.c (tui_show_registers): Simplify.
3869
3870 2019-07-17  Tom Tromey  <tom@tromey.com>
3871
3872         * tui/tui-regs.c (tui_show_registers): Update.
3873         (tui_show_register_group): Add win_info parameter.
3874
3875 2019-07-17  Tom Tromey  <tom@tromey.com>
3876
3877         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3878         Rename from tui_display_reg_element_at_line.
3879         (tui_data_window::display_registers_from_line): Update.
3880         * tui/tui-data.h (struct tui_data_window)
3881         <display_reg_element_at_line>: New method.
3882
3883 2019-07-17  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-regs.h (tui_display_registers_from)
3886         (tui_display_registers_from_line): Don't declare.
3887         * tui/tui-windata.c (tui_data_window::display_all_data)
3888         (tui_data_window::refresh_all)
3889         (tui_data_window::do_scroll_vertical): Update.
3890         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3891         from tui_display_registers_from.
3892         (tui_display_reg_element_at_line): Update.
3893         (tui_data_window::display_registers_from_line): Rename from
3894         tui_display_registers_from_line.
3895         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3896         display_registers_from_line>: New methods.
3897
3898 2019-07-17  Tom Tromey  <tom@tromey.com>
3899
3900         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3901         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3902         from tui_erase_data_content.
3903         (tui_data_window::display_all_data)
3904         (tui_data_window::refresh_all)
3905         (tui_data_window::do_scroll_vertical): Update.
3906         * tui/tui-regs.c (tui_show_registers): Update.
3907         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3908         New method.
3909
3910 2019-07-17  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3913         declare.
3914         * tui/tui-windata.c
3915         (tui_data_window::delete_data_content_windows): Rename from
3916         tui_delete_data_content_windows.
3917         (tui_data_window::display_all_data)
3918         (tui_data_window::do_scroll_vertical): Update.
3919         * tui/tui-data.h (struct tui_data_window)
3920         <delete_data_content_windows>: New method.
3921
3922 2019-07-17  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3925         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3926
3927 2019-07-17  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3930         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3931         from tui_display_all_data.
3932         * tui/tui-win.c
3933         (tui_data_window::do_make_visible_with_new_height): Update.
3934         * tui/tui-regs.c (tui_show_registers): Update.
3935         * tui/tui-layout.c (tui_set_layout): Update.
3936         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3937         method.
3938
3939 2019-07-17  Tom Tromey  <tom@tromey.com>
3940
3941         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3942         * tui/tui-windata.c (tui_display_data_from): Remove.
3943         (tui_data_window::refresh_all): Update.
3944
3945 2019-07-17  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3948         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3949         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3950         tui_display_registers_from_line.
3951         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3952         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3953         "force_display" parameter.
3954
3955 2019-07-17  Tom Tromey  <tom@tromey.com>
3956
3957         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3958         declare.
3959         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3960         Rename from tui_first_reg_element_no_inline.
3961         (tui_display_reg_element_at_line)
3962         (tui_display_registers_from_line): Update.
3963         * tui/tui-data.h (struct tui_data_window)
3964         <first_reg_element_no_inline>: New method.
3965
3966 2019-07-17  Tom Tromey  <tom@tromey.com>
3967
3968         * tui/tui-windata.c (tui_display_data_from)
3969         (tui_data_window::do_scroll_vertical): Update.
3970         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3971         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3972         Rename from tui_line_from_reg_element_no.
3973         (tui_display_registers_from_line): Update.
3974         * tui/tui-data.h (struct tui_data_window)
3975         <line_from_reg_element_no>: New method.
3976
3977 2019-07-17  Tom Tromey  <tom@tromey.com>
3978
3979         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3980         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3981         tui_last_regs_line_no.
3982         (tui_display_reg_element_at_line)
3983         (tui_display_registers_from_line): Update.
3984         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3985         method.
3986
3987 2019-07-17  Tom Tromey  <tom@tromey.com>
3988
3989         PR tui/24722:
3990         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3991         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3992         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3993         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3994         (tui_update_breakpoint_info): Likewise.
3995         * tui/tui-hooks.c (tui_event_create_breakpoint)
3996         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3997         Update.
3998
3999 2019-07-17  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4002
4003 2019-07-17  Tom Tromey  <tom@tromey.com>
4004
4005         * tui/tui-winsource.c (tui_update_source_window_as_is)
4006         (tui_update_source_windows_with_addr): Update.
4007         * tui/tui-source.h (tui_set_source_content)
4008         (tui_show_symtab_source): Add "win_info" parameter.
4009         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4010         parameter.
4011         (tui_show_symtab_source): Likewise.
4012
4013 2019-07-17  Tom Tromey  <tom@tromey.com>
4014
4015         * tui/tui-wingeneral.c
4016         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4017
4018 2019-07-17  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4021         (struct tui_cmd_window) <can_scroll>: New method.
4022         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4023         method.
4024
4025 2019-07-17  Tom Tromey  <tromey@adacore.com>
4026
4027         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4028         do_field_signed>: Rename.  Change type of "value".
4029         * ui-out.c (ui_out::field_signed): Rename from field_int.
4030         Change type of "value".
4031         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4032         type of "value".
4033         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4034         do_field_int.  Change type of "value".
4035         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4036         do_field_int.  Change type of "value".
4037         * tracepoint.c (trace_status_mi, tfind_1)
4038         (print_one_static_tracepoint_marker): Update.
4039         * thread.c (print_thread_info_1, print_selected_thread_frame):
4040         Update.
4041         * stack.c (print_frame, print_frame_info): Update.
4042         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4043         Update.
4044         * source.c (print_source_lines_base): Update.
4045         * skip.c (info_skip_command): Update.
4046         * record-btrace.c (btrace_ui_out_decode_error)
4047         (btrace_call_history_src_line): Update.
4048         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4049         Update.
4050         * progspace.c (print_program_space): Update.
4051         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4052         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4053         do_field_int.  Change type of "value".
4054         * mi/mi-out.c (mi_ui_out::do_table_begin)
4055         (mi_ui_out::do_table_header): Update.
4056         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4057         type of "value".
4058         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4059         (mi_cmd_data_list_changed_registers, output_register)
4060         (mi_cmd_data_read_memory, mi_load_progress)
4061         (mi_cmd_trace_frame_collected): Update.
4062         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4063         Update.
4064         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4065         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4066         (mi_cmd_var_list_children, varobj_update_one): Update.
4067         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4068         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4069         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4070         * inferior.c (print_inferior): Update.
4071         * gdb_bfd.c (print_one_bfd): Update.
4072         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4073         Update.
4074         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4075         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4076         do_field_int.  Change type of "value".
4077         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4078         do_field_int.  Change type of "value".
4079         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4080         (print_one_breakpoint_location, print_it_catch_fork)
4081         (print_one_catch_fork, print_it_catch_vfork)
4082         (print_one_catch_vfork, print_it_catch_solib)
4083         (print_it_catch_exec, print_it_ranged_breakpoint)
4084         (print_mention_watchpoint, print_mention_masked_watchpoint)
4085         (bkpt_print_it, update_static_tracepoint): Update.
4086         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4087         * break-catch-syscall.c (print_it_catch_syscall): Update.
4088         * ada-tasks.c (print_ada_task_info): Update.
4089         * ada-lang.c (print_it_exception, print_mention_exception):
4090         Update.
4091
4092 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4093
4094         PR breakpoints/24541
4095         * gdbarch.c: Regenerate.
4096         * gdbarch.h: Regenerate.
4097         * gdbarch.sh: Adjust return type and parameter types for
4098         'stap_adjust_register'.
4099         (i386_stap_adjust_register): Adjust signature and return new
4100         register name.
4101         * stap-probe.c (stap_parse_register_operand): Adjust use of
4102         'gdbarch_stap_adjust_register'.
4103
4104 2019-07-17  Tom Tromey  <tromey@adacore.com>
4105
4106         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4107         declare VEC.
4108         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4109         std::vector.
4110         (struct s390_process_info): Add initializers.
4111         (s390_add_process): Use new.
4112         (s390_linux_nat_target::low_forget_process): Use delete.
4113         (s390_linux_nat_target::low_new_fork)
4114         (s390_linux_nat_target::stopped_by_watchpoint)
4115         (s390_linux_nat_target::low_prepare_to_resume)
4116         (s390_linux_nat_target::insert_watchpoint)
4117         (s390_linux_nat_target::insert_hw_breakpoint)
4118         (s390_linux_nat_target::remove_watchpoint)
4119         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4120
4121 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4122
4123         * aarch64-fbsd-nat.c: Include regcache.h.
4124         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4125         argument.
4126         (aarch64_fbsd_nat_target::fetch_registers)
4127         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4128         variable.
4129         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4130
4131 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4132
4133         * fbsd-nat.c: Include gdbarch.h.
4134
4135 2019-07-15  Tom Tromey  <tromey@adacore.com>
4136
4137         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4138
4139 2019-07-15  Tom Tromey  <tromey@adacore.com>
4140
4141         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4142         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4143         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4144         * cli-out.c (cli_ui_out::do_field_int): New method.
4145         * ui-out.c (ui_out::field_unsigned): New method.
4146         * symfile.c (generic_load): Use field_unsigned.
4147         (print_transfer_performance): Likewise.
4148         * record-btrace.c (ui_out_field_uint): Remove.
4149         (btrace_call_history_insn_range, btrace_call_history): Use
4150         field_unsigned.
4151         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4152         field_unsigned.
4153         * ui-out.h (class ui_out) <field_unsigned>: New method.
4154         <do_field_unsigned>: Likewise.
4155
4156 2019-07-15  Tom Tromey  <tromey@adacore.com>
4157
4158         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4159         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4160         * target.c (flash_erase_command): Use field_string.
4161         * infrun.c (print_signal_received_reason): Use field_string.
4162         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4163         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4164         field_string.
4165         * ada-tasks.c (print_ada_task_info): Use field_string.
4166
4167 2019-07-15  Tom Tromey  <tromey@adacore.com>
4168
4169         * target.c (flash_erase_command): Use field_core_addr.
4170         * symfile.c (generic_load): Use field_core_addr.
4171         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4172         Use field_core_addr.
4173         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4174         field_core_addr.
4175
4176 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4177
4178         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4179         value if its desired type is smaller than a CORE_ADDR and signed.
4180
4181 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4184         of changes to field names, and use new is_reference field to
4185         decide if a property is a reference or not.
4186         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4187         field.
4188         (struct dwarf2_property_baton): Update header comment, rename
4189         'referenced_type' to 'property_type' and update comments.
4190         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4191         default property type, store in property baton, update to take
4192         accound of renamed field.
4193         (read_func_scope): Update call to attr_to_dynamic_prop.
4194         (read_array_type): Likewise.
4195         (dwarf2_per_cu_addr_sized_int_type): New function.
4196         (read_subrange_index_type): Move type finding code to
4197         dwarf2_per_cu_addr_sized_int_type.
4198         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4199         (dwarf2_per_cu_addr_type): New function.
4200         (set_die_type): Update calls to attr_to_dynamic_prop.
4201
4202 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * dwarf2read.c (read_subrange_index_type): New function.
4205         (read_subrange_type): Move code into new function and call it.
4206         * gdbtypes.c (create_range_type): Add some asserts.
4207
4208 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4211         update return statements.
4212         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4213         declaration, and update comment to match.
4214         * gdbtypes.c (resolve_dynamic_array): Update call to
4215         dwarf2_evaluate_property to match new return type.
4216
4217 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * valarith.c (value_subscripted_rvalue): Change lowerbound
4220         parameter type from int to LONGEST.
4221         * value.h (value_subscripted_rvalue): Likewise in declaration.
4222
4223 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4224
4225         * cli/cli-utils.c (info_print_command_completer): New function.
4226         * cli/cli-utils.h: Add 'completer.h' include, and forward
4227         declaration for 'struct cmd_list_element'.
4228         (info_print_command_completer): Declare.
4229         * stack.c (_initialize_stack): Add completer for 'info locals' and
4230         'info args'.
4231         * symtab.c (_initialize_symtab): Add completer for 'info
4232         variables' and 'info functions'.
4233         * NEWS: Mention completion for additional info commands.
4234
4235 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * cli/cli-utils.c (extract_info_print_args): Delete.
4238         (extract_arg_maybe_quoted): Delete.
4239         (info_print_options_defs): New variable.
4240         (make_info_print_options_def_group): New function.
4241         (extract_info_print_options): Define new function.
4242         * cli/cli-utils.h (extract_info_print_args): Delete.
4243         (struct info_print_options): New structure.
4244         (extract_info_print_options): Declare new function.
4245         * stack.c (info_locals_command): Update to use new
4246         extract_info_print_options, also add a header comment.
4247         (info_args_command): Likewise.
4248         * symtab.c (info_variables_command): Likewise.
4249         (info_functions_command): Likewise.
4250
4251 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4254         to extract string arguments.
4255         * common/common-utils.c (extract_string_maybe_quoted): New function.
4256         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4257
4258 2019-07-11  Tom Tromey  <tromey@adacore.com>
4259
4260         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4261         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4262         * top.h (gdbinit): Don't declare.
4263         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4264         into...
4265         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4266         * top.c (gdb_init): Don't call init_cli_cmds.
4267         (gdbinit): Remove.
4268         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4269
4270 2019-07-11  Tom Tromey  <tromey@adacore.com>
4271
4272         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4273         after it has been moved.
4274
4275 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4276
4277         * valops.c (value_must_coerce_to_target): Change return type to
4278         bool.
4279         * value.h (value_must_coerce_to_target): Likewise.
4280
4281 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4282
4283         * breakpoint.c (is_hardware_watchpoint): Remove
4284         forward-declaration.
4285         (is_masked_watchpoint): Change return type to bool.
4286         (is_tracepoint): Likewise.
4287         (is_breakpoint): Likewise.
4288         (is_hardware_watchpoint): Likewise.
4289         (is_watchpoint): Likewise.
4290         (is_no_memory_software_watchpoint): Likewise.
4291         (is_catchpoint): Likewise.
4292         (breakpoint_1): Make FILTER parameter's return type bool.
4293         is_masked_watchpoint): Change return type to bool.
4294         (save_breakpoints): Make FILTER parameter's return type bool.
4295         * breakpoint.h (is_breakpoint): Change return type to bool.
4296         (is_watchpoint): Likewise.
4297         (is_catchpoint): Likewise.
4298         (is_tracepoint): Likewise.
4299
4300 2019-07-10  Tom Tromey  <tom@tromey.com>
4301
4302         * defs.h: Don't include gdbarch.h.
4303         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4304         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4305         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4306         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4307         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4308         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4309         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4310         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4311         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4312         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4313         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4314         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4315         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4316         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4317         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4318         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4319         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4320         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4321         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4322         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4323         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4324         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4325         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4326         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4327         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4328         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4329         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4330
4331 2019-07-10  Tom Tromey  <tromey@adacore.com>
4332
4333         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4334         * breakpoint.c (init_ada_exception_breakpoint): Register as
4335         bp_catchpoint.
4336         (print_one_breakpoint_location, print_one_breakpoint): Use
4337         is_ada_exception_catchpoint.
4338         * ada-lang.c (class ada_catchpoint_location): Pass
4339         bp_loc_software_breakpoint to bp_location constructor.
4340         (is_ada_exception_catchpoint): New function.
4341
4342 2019-07-10  Tom Tromey  <tromey@adacore.com>
4343
4344         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4345         VEC.
4346         (struct arm_exidx_entry): New method operator<.
4347         (struct arm_exidx_data) <section_maps>: Change type.
4348         (arm_exidx_data_free): Remove.
4349         (arm_exidx_data_key): Change type.  Move lower.
4350         (arm_exidx_new_objfile): Update.
4351         (arm_compare_exidx_entries): Remove.
4352         (arm_find_exidx_entry, _initialize_arm_tdep)
4353
4354 2019-07-10  Tom Tromey  <tromey@adacore.com>
4355
4356         * solib-spu.c (ocl_program_data_key): Change type.
4357         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4358         Update.
4359
4360 2019-07-10  Tom Tromey  <tromey@adacore.com>
4361
4362         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4363         (struct solib_aix_inferior_data) <library_list>: Change type.
4364         (solib_aix_inferior_data_handle): Change type.
4365         (get_solib_aix_inferior_data): Update.
4366         (solib_aix_free_library_list): Remove.
4367         (library_list_start_library): Update.
4368         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4369         return type.
4370         (solib_aix_get_library_list)
4371         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4372         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4373
4374 2019-07-10  Tom Tromey  <tromey@adacore.com>
4375
4376         * solib-dsbt.c (struct dsbt_info): Add initializers.
4377         (solib_dsbt_pspace_data): Change type.
4378         (dsbt_pspace_data_cleanup): Remove.
4379         (get_dsbt_info, _initialize_dsbt_solib): Update.
4380
4381 2019-07-10  Tom Tromey  <tromey@adacore.com>
4382
4383         * spu-tdep.c (spu_overlay_data): Change type.
4384         (spu_get_overlay_table, spu_overlay_new_objfile)
4385         (_initialize_spu_tdep): Update.
4386
4387 2019-07-10  Tom Tromey  <tromey@adacore.com>
4388
4389         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4390         destructor.
4391         (dbx_objfile_data_key): Change type and declare later.
4392         (DBX_SYMFILE_INFO): Rewrite.
4393         * dbxread.c (dbx_objfile_data_key): Change type.
4394         (dbx_symfile_init): Update.
4395         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4396         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4397         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4398
4399 2019-07-10  Tom Tromey  <tromey@adacore.com>
4400
4401         * jit.c (jit_program_space_key): Change type.  Move lower.
4402         (get_jit_program_space_data): Update.
4403         (jit_program_space_data_cleanup): Remove.
4404         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4405         Update.
4406         (struct jit_program_space_data): Add initializers.
4407
4408 2019-07-10  Tom Tromey  <tromey@adacore.com>
4409
4410         * solib-darwin.c (struct darwin_info): Add initializers.
4411         (solib_darwin_pspace_data): Change type.
4412         (darwin_pspace_data_cleanup): Remove.
4413         (get_darwin_info, _initialize_darwin_solib): Update.
4414
4415 2019-07-10  Tom Tromey  <tromey@adacore.com>
4416
4417         * remote-sim.c (struct sim_inferior_data): Add initializers,
4418         constructor, and destructor.
4419         (sim_inferior_data_key): Change type.  Move lower.
4420         (check_for_duplicate_sim_descriptor): Update.
4421         (get_sim_inferior_data): Use new.  Update.
4422         (~sim_inferior_data_cleanup): Rename from
4423         sim_inferior_data_cleanup.  Simplify.
4424         (gdbsim_close_inferior, simulator_command)
4425         (sim_command_completer, _initialize_remote_sim): Update.
4426         (next_pid, INITIAL_PID): Move earlier.
4427
4428 2019-07-10  Tom Tromey  <tromey@adacore.com>
4429
4430         * python/python-internal.h (create_thread_object): Return
4431         gdbpy_ref.
4432         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4433         * python/py-inferior.c (struct threadlist_entry): Add
4434         constructor.
4435         <thread_obj>: Now a gdbpy_ref.
4436         (thread_to_thread_object): Update.
4437         (add_thread_object): Use new.
4438         (delete_thread_object): Use delete.
4439         (infpy_threads): Update.
4440         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4441         GIL.
4442
4443 2019-07-10  Tom Tromey  <tromey@adacore.com>
4444
4445         * valops.c (value_cast): Specialize error message for Ada.
4446
4447 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4448
4449         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4450
4451 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4452
4453         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4454         bpstat_should_step): Return bool, adjust comments.
4455         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4456         bpstat_should_step): Likewise.
4457
4458 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4459
4460         * features/Makefile: Use feature target descriptions for Arm.
4461         * features/arm/arm-core.c: Generate new file.
4462         * features/arm/arm-fpa.c: Likewise.
4463         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4464         * features/arm/arm-m-profile.c: Likewise.
4465         * features/arm/arm-vfpv2.c: Likewise.
4466         * features/arm/arm-vfpv3.c: Likewise.
4467         * features/arm/xscale-iwmmxt.c: Likewise.
4468         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4469
4470 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4471
4472         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4473         ptrace earlier.
4474
4475 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4476
4477         * features/aarch64-pauth.c: Regenerate.
4478
4479 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4480
4481         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4482         bool.
4483         (bpstat_what): Use false instead of 0.
4484
4485 2019-07-09  Pedro Alves  <palves@redhat.com>
4486
4487         * break-catch-throw.c (is_exception_catchpoint): New.
4488         * breakpoint.c (print_one_breakpoint_location): New parameter
4489         'raw_loc'.  Handle it.  Use
4490         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4491         looking at the breakpoint's type.
4492         (print_one_breakpoint): If handling "maint info breakpoints", also
4493         print locations of exception catchpoints.
4494         * breakpoint.h (is_exception_catchpoint): Declare.
4495
4496 2019-07-09  Pedro Alves  <palves@redhat.com>
4497
4498         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4499         "addr" field.
4500         (allocate_location_exception_catchpoint): New.
4501         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4502         (initialize_throw_catchpoint_ops): Install
4503         allocate_location_exception_catchpoint as allocate_location
4504         method.
4505         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4506         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4507         bp_loc_other.
4508         (breakpoint_address_is_meaningful): Delete.
4509         (bl_address_is_meaningful): New.
4510         (breakpoint_locations_match): Adjust comment.
4511         (bp_location_from_bp_type): New, factored out of...
4512         (bp_location::bp_location(breakpoint *)): ... this.
4513         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4514         factored out of...
4515         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4516         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4517         breakpoint_address_is_meaningful.
4518         (bp_locations_compare): Adjust comment.
4519         (update_global_location_list): Use bl_address_is_meaningful
4520         instead of breakpoint_address_is_meaningful.
4521         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4522         explicit.
4523         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4524         * python/py-breakpoint.c (bppy_get_location): No longer check
4525         whether location is null.
4526
4527 2019-07-09  Pedro Alves  <palves@redhat.com>
4528
4529         PR c++/15468
4530         * breakpoint.c (print_one_breakpoint_location): Remove
4531         single-location assert.
4532
4533 2019-07-09  Tom Tromey  <tom@tromey.com>
4534
4535         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4536         * configure: Rebuild.
4537         * configure.ac: Change common to gdbsupport.
4538         * gdbsupport: Rename from common.
4539         * acinclude.m4: Change common to gdbsupport.
4540         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4541         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4542         gdbsupport.
4543         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4544         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4545         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4546         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4547         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4548         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4549         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4550         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4551         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4552         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4553         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4554         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4555         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4556         coff-pe-read.c, command.h, compile/compile-c-support.c,
4557         compile/compile-c.h, compile/compile-cplus-symbols.c,
4558         compile/compile-cplus-types.c, compile/compile-cplus.h,
4559         compile/compile-loc2c.c, compile/compile.c, completer.c,
4560         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4561         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4562         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4563         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4564         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4565         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4566         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4567         features/aarch64-core.c, features/aarch64-fpu.c,
4568         features/aarch64-pauth.c, features/aarch64-sve.c,
4569         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4570         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4571         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4572         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4573         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4574         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4575         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4576         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4577         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4578         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4579         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4580         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4581         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4582         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4583         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4584         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4585         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4586         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4587         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4588         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4589         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4590         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4591         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4592         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4593         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4594         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4595         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4596         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4597         minsyms.c, mips-linux-tdep.c, namespace.h,
4598         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4599         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4600         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4601         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4602         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4603         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4604         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4605         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4606         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4607         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4608         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4609         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4610         procfs.c, producer.c, progspace.h, psymtab.h,
4611         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4612         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4613         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4614         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4615         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4616         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4617         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4618         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4619         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4620         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4621         target-memory.c, target.c, target.h, target/waitstatus.c,
4622         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4623         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4624         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4625         unittests/array-view-selftests.c,
4626         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4627         unittests/common-utils-selftests.c,
4628         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4629         unittests/format_pieces-selftests.c,
4630         unittests/function-view-selftests.c,
4631         unittests/lookup_name_info-selftests.c,
4632         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4633         unittests/mkdir-recursive-selftests.c,
4634         unittests/observable-selftests.c,
4635         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4636         unittests/parse-connection-spec-selftests.c,
4637         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4638         unittests/scoped_fd-selftests.c,
4639         unittests/scoped_mmap-selftests.c,
4640         unittests/scoped_restore-selftests.c,
4641         unittests/string_view-selftests.c, unittests/style-selftests.c,
4642         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4643         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4644         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4645         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4646         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4647         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4648
4649 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4650
4651         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4652         bool value.
4653         (decode_digits_ordinary): Set explicit_line field in sal.
4654         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4655         symtab_and_line that was set on an explicit line number in
4656         assembler code.  Do always update the recorded symtab and line if
4657         we do skip the prologue.
4658
4659 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * breakpoint.c (set_breakpoint_location_function): Remove
4662         explicit_loc parameter.
4663         (momentary_breakpoint_from_master): Update call to
4664         set_breakpoint_location_function.
4665         (add_location_to_breakpoint): Likewise.
4666
4667 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4668
4669         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4670         required features based on default bfd type when no specific bfd
4671         is present.
4672
4673 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4674
4675         * NEWS: Mention that GDB printf and eval commands can now print
4676         C-style and Ada-style convenience var strings without
4677         calling the inferior.
4678         * printcmd.c (printf_c_string): Locally print GDB internal var
4679         instead of transiting via the inferior.
4680         (printf_wide_c_string): Likewise.
4681
4682 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4683
4684         PR breakpoints/25011
4685         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4686
4687 2019-07-04  Tom Tromey  <tom@tromey.com>
4688
4689         PR tui/24724:
4690         * tui/tui-winsource.c (tui_clear_source_content): Update.
4691         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4692         (tui_update_breakpoint_info): Update.
4693         (tui_set_exec_info_content): Update.
4694         * tui/tui-source.c (tui_set_source_content_nil): Update.
4695         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4696         has_break.
4697         * tui/tui-data.h (enum tui_bp_flag): New.
4698         (tui_bp_flags): New enum flags type.
4699         (struct tui_source_element) <break_mode>: Change type.  Rename
4700         from has_break.
4701         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4702         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4703         constants.
4704         * tui/tui-winsource.h: Fix comment.
4705
4706 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4707
4708         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4709         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4710         (store_fpregs_to_thread)
4711         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4712         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4713         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4714         (IWMMXT_REGS_SIZE): Add define.
4715         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4716         (fetch_vfp_regs, store_vfp_regs)
4717         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4718         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4719
4720 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4721
4722         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4723         defines.
4724         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4725         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4726         (ARM_INT_REGISTER_SIZE): ...to this.
4727         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4728         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4729         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4730         (arm_linux_collect_gregset, supply_nwfpe_register)
4731         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4732         defines.
4733         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4734         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4735         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4736         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4737         (arm_return_in_memory, arm_store_return_value)
4738         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4739         (arm_record_ld_st_multiple): Likewise.
4740         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4741         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4742
4743 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4744
4745         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4746         AARCH64_DISPLACED_MODIFIED_INSNS.
4747         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4748         (aarch64_displaced_step_copy_insn): Likewise.
4749         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4750         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4751         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4752         ARM_DISPLACED_MODIFIED_INSNS.
4753         * arm-tdep.c (arm_gdbarch_init): Likewise.
4754         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4755         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4756         (struct arm_displaced_step_closure): Use
4757         ARM_DISPLACED_MODIFIED_INSNS.
4758
4759 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4760
4761         * features/Makefile: Remove unused xml files.
4762         * features/aarch64.xml: Remove.
4763         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4764         * features/i386/amd64-avx-avx512.xml: Remove.
4765         * features/i386/amd64-avx-linux.xml: Remove.
4766         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4767         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4768         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4769         * features/i386/amd64-avx-mpx.xml: Remove.
4770         * features/i386/amd64-avx.xml: Remove.
4771         * features/i386/amd64-linux.xml: Remove.
4772         * features/i386/amd64-mpx-linux.xml: Remove.
4773         * features/i386/amd64-mpx.xml: Remove.
4774         * features/i386/amd64.xml: Remove.
4775         * features/i386/i386-avx-avx512-linux.xml: Remove.
4776         * features/i386/i386-avx-avx512.xml: Remove.
4777         * features/i386/i386-avx-linux.xml: Remove.
4778         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4779         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4780         * features/i386/i386-avx-mpx-linux.xml: Remove.
4781         * features/i386/i386-avx-mpx.xml: Remove.
4782         * features/i386/i386-avx.xml: Remove.
4783         * features/i386/i386-linux.xml: Remove.
4784         * features/i386/i386-mmx-linux.xml: Remove.
4785         * features/i386/i386-mmx.xml: Remove.
4786         * features/i386/i386-mpx-linux.xml: Remove.
4787         * features/i386/i386-mpx.xml: Remove.
4788         * features/i386/i386.xml: Remove.
4789         * features/i386/x32-avx-avx512-linux.xml: Remove.
4790         * features/i386/x32-avx-linux.xml: Remove.
4791         * features/i386/x32-linux.xml: Remove.
4792
4793 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4794
4795         * regformats/aarch64.dat: Remove.
4796         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4797         * regformats/i386/amd64-avx-linux.dat: Remove.
4798         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4799         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4800         * regformats/i386/amd64-linux.dat: Remove.
4801         * regformats/i386/amd64-mpx-linux.dat: Remove.
4802         * regformats/i386/amd64.dat: Remove.
4803         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4804         * regformats/i386/i386-avx-linux.dat: Remove.
4805         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4806         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4807         * regformats/i386/i386-linux.dat: Remove.
4808         * regformats/i386/i386-mmx-linux.dat: Remove.
4809         * regformats/i386/i386-mpx-linux.dat: Remove.
4810         * regformats/i386/i386.dat: Remove.
4811         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4812         * regformats/i386/x32-avx-linux.dat: Remove.
4813         * regformats/i386/x32-linux.dat: Remove.
4814
4815 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4816
4817         * aarch64-tdep.c: Remove xml self tests.
4818         * amd64-linux-tdep.c: Likewise.
4819         * amd64-tdep.c: Likewise.
4820         * i386-linux-tdep.c: Likewise.
4821         * i386-tdep.c: Likewise.
4822
4823 2019-07-03  Pedro Alves  <palves@redhat.com>
4824
4825         PR cli/24732
4826         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4827         (pipe_cmd_option_defs): New.
4828         (make_pipe_cmd_options_def_group): New.
4829         (pipe_command): Use gdb::option::process_options.
4830         (pipe_command_completer): New function.
4831         (_initialize_cli_cmds): Install completer for "pipe" command.
4832
4833 2019-07-03  Pedro Alves  <palves@redhat.com>
4834
4835         * cli/cli-option.c (union option_value) <string>: New field.
4836         (struct option_def_and_value): Add ctor, move ctor, dtor and
4837         use DISABLE_COPY_AND_ASSIGN.
4838         (option_def_and_value::clear_value): New.
4839         (parse_option, save_option_value_in_ctx, get_val_type_str)
4840         (add_setshow_cmds_for_options): Handle var_string.
4841         * cli-option.h (union option_def::var_address) <string>: New
4842         field.
4843         (struct string_option_def): New.
4844         * maint-test-options.c (struct test_options_opts): Add default
4845         ctor and use DISABLE_COPY_AND_ASSIGN.
4846         <string_opt>: New field.
4847         (test_options_opts::~test_options_opts): New.
4848         (test_options_opts::dump): Also dump "-string".
4849         (test_options_option_defs): Install "string.
4850
4851 2019-07-03  Pedro Alves  <palves@redhat.com>
4852
4853         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4854         option_value with a null enumeration.
4855         (complete_options): Save the option values in the context.
4856         (save_option_value_in_ctx): New, factored out from ...
4857         (process_options): ... here.
4858         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4859         of the function.
4860         * maint-test-options.c (test_options_opts::dump): New, factored
4861         out from ...
4862         (maintenance_test_options_command_mode): ... here.
4863         (maintenance_test_options_command_completion_result): Delete.
4864         (maintenance_test_options_command_completion_text): Update
4865         comment.
4866         (maintenance_show_test_options_completion_result): Change
4867         prototype.  Just print
4868         maintenance_test_options_command_completion_text.
4869         (save_completion_result): New.
4870         (maintenance_test_options_completer_mode): Pass options context to
4871         complete_options, and then save a dump.
4872         (_initialize_maint_test_options): Use add_cmd to install "maint
4873         show test-options-completion-result".
4874
4875 2019-07-03  Pedro Alves  <palves@redhat.com>
4876
4877         * NEWS (New commands): Mention "with" and "maint with".
4878         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4879         (with_command, with_command_completer): New.
4880         (pipe_command): Adjust to new repeat_previous
4881         interface.
4882         (_initialize_cli_cmds): Install the "with" command and its "w"
4883         alias.
4884         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4885         declarations.
4886         * cli/cli-setshow.c (parse_cli_var_uinteger)
4887         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4888         argument strings for all var_types.
4889         (get_setshow_command_value_string): New, factored out from ...
4890         (do_show_command): ... this.
4891         * cli/cli-setshow.h: Include <string>.
4892         (get_setshow_command_value_string): Declare.
4893         * command.h (repeat_previous): Now returns const char *.  Adjust
4894         comment.
4895         * maint.c: Include "cli/cli-cmds.h".
4896         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4897         (_initialize_maint_cmds): Register the "maintenance with" command.
4898         * top.c (repeat_previous): Move bits from pipe_command here:
4899         Return the saved command line, if any; error out if there's no
4900         command to relaunch.
4901
4902 2019-07-03  Pedro Alves  <palves@redhat.com>
4903
4904         * NEWS (New commands): Mention "maint set/show test-settings"
4905         instead of "maint test-settings".
4906         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4907         (maintenance_test_settings_set_list): Rename to ...
4908         (maintenance_set_test_settings_list): ... this.
4909         (maintenance_test_settings_show_list): Rename to  ...
4910         (maintenance_show_test_settings_list): ... this.
4911         (maintenance_test_settings_cmd): Delete.
4912         (maintenance_test_settings_set_cmd): ...
4913         (maintenance_set_test_settings_cmd): ... this.
4914         (maintenance_test_settings_show_cmd): ...
4915         (maintenance_show_test_settings_cmd): ... this.
4916         (maintenance_test_settings_show_value_cmd):
4917         (maintenance_show_test_settings_value_cmd): ... this.
4918         (_initialize_maint_test_settings): No longer install the "maint
4919         test-settings" prefix command.  Rename "maint test-settings set"
4920         to "maint set test-settings", and "maint test-settings show" to
4921         "maint show test-settings".  Adjust all subcommands.
4922
4923 2019-07-03  Pedro Alves  <palves@redhat.com>
4924
4925         * maint-test-settings.c: Fix file's intro comment.  Replace all
4926         references to "test-options" with references to "test-settings",
4927         in comments.
4928
4929 2019-07-03  Pedro Alves  <palves@redhat.com>
4930
4931         * maint-test-settings.c (maintenance_test_settings_xxx)
4932         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4933         New.
4934         (maintenance_test_settings_enums): Use them.
4935         (maintenance_test_settings_enum): Default to
4936         maintenance_test_settings_xxx.
4937         (_initialize_maint_test_settings): Initialize
4938         MAINTENANCE_TEST_SETTINGS_FILENAME.
4939
4940 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4941
4942         * breakpoint.h (remove_breakpoints_inf): Change return type to
4943         void, move function documentation here.
4944         * breakpoint.c (remove_breakpoints_inf): Change return type to
4945         void, move function documentation to header.
4946
4947 2019-07-02  Pedro Alves  <palves@redhat.com>
4948
4949         * NEWS (Completion improvements): Mention "info threads".
4950         * thread.c (struct info_threads_opts, info_threads_option_defs)
4951         (make_info_threads_options_def_group): New.
4952         (info_threads_command): Use gdb::option::process_options.
4953         (info_threads_command_completer): New.
4954         (_initialize_thread): Use gdb::option::build_help to build the
4955         help text for "info threads".
4956
4957 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4958
4959         * defs.h (generic_load): Move from here...
4960         * symfile.h (generic_load): ... to here.  Rename name parameter
4961         to args.
4962         * symfile.c (generic_load): Add comment.
4963
4964 2019-07-01  Tom Tromey  <tromey@adacore.com>
4965
4966         * dwarf2read.c
4967         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4968         declaration of without_params.  Fix formatting.
4969
4970 2019-07-01  Tom Tromey  <tromey@adacore.com>
4971
4972         * ada-exp.y (find_primitive_type): Update.
4973         * ada-lang.h (ada_lookup_symbol): Update.
4974         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4975         parameter.
4976         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4977
4978 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4979
4980         PR breakpoints/24541
4981         * gdbarch.c: Regenerate.
4982         * gdbarch.h: Regenerate.
4983         * gdbarch.sh: Add 'stap_adjust_register'.
4984         * i386-tdep.c: Include '<unordered_set>'.
4985         (i386_stap_adjust_register): New function.
4986         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4987         * stap-probe.c (stap_parse_register_operand): Call
4988         'gdbarch_stap_adjust_register'.
4989
4990 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4991
4992         PR python/24742
4993         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4994         * python/python.c (do_start_initialization): Use 'xmalloc'
4995         instead of 'PyMem_Malloc'.
4996
4997 2019-06-28  Tom Tromey  <tromey@adacore.com>
4998
4999         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5000         for Ada.
5001
5002 2019-06-27  Tom Tromey  <tromey@adacore.com>
5003
5004         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5005         objfile_key.
5006         (arm_find_mapping_symbol, arm_record_special_symbol)
5007         (_initialize_arm_tdep): Update.
5008         (arm_objfile_data_free): Remove.
5009
5010 2019-06-27  Tom Tromey  <tromey@adacore.com>
5011
5012         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5013         to cp_print_static_field.
5014
5015 2019-06-26  Tom Tromey  <tromey@adacore.com>
5016
5017         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5018         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5019         declare.
5020
5021 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5022
5023         * features/aarch64-core.c (create_feature_aarch64_core):
5024         Regenerate.
5025         * features/aarch64-core.xml: Add cpsr flags.
5026
5027 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5028
5029         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5030         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5031
5032 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5033
5034         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5035         field.
5036         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5037         use.
5038         (arm_record_special_symbol): Don't insert new symbol in sorted
5039         position, push it at the end.
5040
5041 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5042
5043         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5044         (arm_mapping_symbol_s): Remove.
5045         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5046         (arm_mapping_symbol_vec): New typedef.
5047         (struct arm_per_objfile): Add constructor.
5048         <section_maps>: Change type to
5049         std::unique_ptr<arm_mapping_symbol_vec[]>.
5050         (arm_compare_mapping_symbols): Remove.
5051         (arm_find_mapping_symbol): Adjust to section_maps type change.
5052         (arm_objfile_data_free): Call delete on arm_per_objfile.
5053         (arm_record_special_symbol): Adjust to section_maps type change.
5054         Allocate arm_per_objfile with new.
5055
5056 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5057
5058         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5059         with the command prefix.
5060
5061 2019-06-25  Tom Tromey  <tom@tromey.com>
5062
5063         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5064         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5065
5066 2019-06-25  Tom Tromey  <tom@tromey.com>
5067
5068         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5069         type.
5070         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5071         protected.
5072
5073 2019-06-25  Tom Tromey  <tom@tromey.com>
5074
5075         * tui/tui-winsource.c
5076         (tui_source_window_base::set_is_exec_point_at): Add check against
5077         LOA_ADDRESS.
5078
5079 2019-06-25  Tom Tromey  <tom@tromey.com>
5080
5081         * tui/tui-source.c (tui_set_source_content): Don't check before
5082         xfree.
5083         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5084
5085 2019-06-25  Tom Tromey  <tom@tromey.com>
5086
5087         * tui/tui-winsource.h (tui_update_source_window_as_is)
5088         (tui_alloc_source_buffer, tui_line_is_displayed)
5089         (tui_addr_is_displayed): Change type of win_info.
5090         * tui/tui-winsource.c (tui_update_source_window_as_is)
5091         (tui_clear_source_content, tui_show_source_line)
5092         (tui_show_source_content, tui_source_window_base::refill)
5093         (tui_source_window_base::set_is_exec_point_at)
5094         (tui_source_window_base::set_is_exec_point_at)
5095         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5096         (tui_alloc_source_buffer, tui_line_is_displayed)
5097         (tui_addr_is_displayed): Change type of win_info.  Update.
5098         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5099         (tui_source_window_base::do_make_visible_with_new_height):
5100         Update.
5101         * tui/tui-source.c (tui_set_source_content)
5102         (tui_set_source_content_nil)
5103         (tui_source_window::do_scroll_vertical): Update.
5104         * tui/tui-layout.c (show_layout): Update.
5105         * tui/tui-disasm.c (tui_set_disassem_content)
5106         (tui_disasm_window::do_scroll_vertical): Update.
5107         * tui/tui-data.h (tui_win_content): Remove.
5108         (struct tui_gen_win_info) <content, content_size>: Remove.
5109         (struct tui_source_element): Add initializers and destructor.
5110         (union tui_which_element, struct tui_win_element): Remove.
5111         (struct tui_source_window_base) <content>: New field.
5112         (struct tui_data_window): Remove destructor.
5113         (tui_alloc_content, tui_free_win_content)
5114         (tui_free_all_source_wins_content): Don't declare.
5115         * tui/tui-data.c (tui_initialize_static_data): Update.
5116         (init_content_element, tui_alloc_content): Remove.
5117         (~tui_gen_win_info): Update.
5118         (~tui_data_window, tui_free_all_source_wins_content)
5119         (tui_free_win_content, free_content, free_content_elements):
5120         Remove.
5121
5122 2019-06-25  Tom Tromey  <tom@tromey.com>
5123
5124         * tui/tui-winsource.h (tui_clear_source_content)
5125         (tui_erase_source_content, tui_show_source_content): Change type
5126         of win_info.
5127         * tui/tui-winsource.c (tui_clear_source_content)
5128         (tui_erase_source_content, tui_show_source_content): Change type
5129         of win_info.
5130         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5131         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5132         win_info.
5133         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5134         win_info.
5135         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5136
5137 2019-06-25  Tom Tromey  <tom@tromey.com>
5138
5139         * tui/tui-winsource.c (tui_clear_source_content)
5140         (tui_source_window_base::set_is_exec_point_at): Update.
5141         * tui/tui-source.c (tui_set_source_content_nil): Update.
5142         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5143         a bool.
5144         * tui/tui-data.c (init_content_element): Update.
5145
5146 2019-06-25  Tom Tromey  <tom@tromey.com>
5147
5148         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5149         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5150         * tui/tui-layout.c (init_and_make_win): Update.
5151         * tui/tui.h (enum tui_win_type): Update.
5152         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5153         tui_win_is_auxillary.
5154         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5155         tui_win_is_auxillary.
5156
5157 2019-06-25  Tom Tromey  <tom@tromey.com>
5158
5159         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5160         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5161         (tui_delete_data_content_windows, tui_display_all_data)
5162         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5163         Update.
5164         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5165         * tui/tui-regs.c (tui_last_regs_line_no)
5166         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5167         (tui_show_registers): Update.
5168         (tui_show_register_group): Return void.  Update.
5169         (tui_display_registers_from, tui_display_reg_element_at_line)
5170         (tui_display_registers_from_line, tui_check_register_values):
5171         Update.
5172         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5173         member.
5174         (struct tui_data_window) <regs_content>: Now a std::vector.
5175         <regs_content_count>: Remove.
5176         (tui_add_content_elements, tui_free_data_content): Don't declare.
5177         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5178         (init_content_element): Remove DATA_WIN case.  Add assert.
5179         (tui_add_content_elements): Remove.
5180         (tui_data_window): Update.
5181         (tui_free_data_content): Remove.
5182         (free_content_elements): Remove DATA_WIN case.
5183
5184 2019-06-25  Tom Tromey  <tom@tromey.com>
5185
5186         * tui/tui-data.c (tui_data_item_window): Update.
5187         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5188         * tui/tui-windata.c (tui_display_all_data)
5189         (tui_display_data_from_line): Update.
5190         (tui_check_data_values): Remove.
5191         * tui/tui-regs.c (tui_show_register_group)
5192         (tui_display_reg_element_at_line): Update.
5193         * tui/tui-hooks.c (tui_register_changed)
5194         (tui_refresh_frame_and_register_information): Call
5195         tui_check_register_values.
5196         * tui/tui-data.h (struct tui_data_window) <data_content,
5197         data_content_count, data_type>: Remove.
5198         (enum tui_data_type): Remove.
5199
5200         * tui/tui-data.c (tui_data_window::clear_detail)
5201         (~tui_data_window): Update.
5202
5203 2019-06-25  Tom Tromey  <tom@tromey.com>
5204
5205         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5206         declare.
5207         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5208         Rename from tui_first_data_item_displayed.  Update.
5209         (tui_data_window::refresh_all)
5210         (tui_data_window::do_scroll_vertical): Update.
5211         * tui/tui-data.h (struct tui_data_window)
5212         <first_data_item_displayed>: Declare new method.
5213
5214 2019-06-25  Tom Tromey  <tom@tromey.com>
5215
5216         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5217         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5218         contents...
5219         (tui_initialize_static_data): ...here.
5220
5221 2019-06-25  Tom Tromey  <tom@tromey.com>
5222
5223         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5224         (tui_display_registers_from, tui_check_register_values): Update.
5225         (tui_display_register): Remove win_info parameter; update.
5226         (tui_get_register): Change type of parameters.
5227         * tui/tui-data.h (struct tui_data_element): Remove.
5228         (union tui_which_element) <data>: Remove.
5229         <data_window>: Change type.
5230         (struct tui_data_item_window): New.
5231         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5232         case.  Add assert.
5233         (~tui_data_item_window): New destructor.
5234         (free_content_elements): Remove DATA_ITEM_WIN case.
5235
5236 2019-06-25  Tom Tromey  <tom@tromey.com>
5237
5238         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5239         Remove.
5240
5241 2019-06-25  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-data.h (struct tui_command_element): Remove.
5244         (union tui_which_element) <command>: Remove.
5245         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5246         assert.
5247         (free_content_elements): Remove CMD_WIN case.
5248
5249 2019-06-25  Tom Tromey  <tom@tromey.com>
5250
5251         * tui/tui-layout.c (tui_set_layout): Update.
5252         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5253         * tui/tui-data.c (layout_def): Update.
5254
5255 2019-06-25  Tom Tromey  <tom@tromey.com>
5256
5257         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5258         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5259         (tui_source_window_base::set_new_height): Update.
5260         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5261         Update.
5262         (tui_set_locator_fullname, tui_set_locator_info)
5263         (tui_show_frame_info): Update.
5264         * tui/tui-source.c (tui_set_source_content)
5265         (tui_source_is_displayed): Update.
5266         * tui/tui-layout.c (show_source_disasm_command, show_data)
5267         (show_source_or_disasm_and_command): Update.
5268         * tui/tui-disasm.c (tui_set_disassem_content)
5269         (tui_get_begin_asm_address): Update.
5270         * tui/tui-data.h (struct tui_locator_element): Remove.
5271         (union tui_which_element) <locator>: Remove.
5272         (struct tui_locator_window): New.
5273         (tui_locator_win_info_ptr): Change return type.
5274         * tui/tui-data.c (_locator): Change type.
5275         (tui_locator_win_info_ptr): Change return type.
5276         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5277         (tui_alloc_content): Add assert.
5278
5279 2019-06-25  Tom Tromey  <tom@tromey.com>
5280
5281         * tui/tui-winsource.c
5282         (tui_exec_info_window::maybe_allocate_content): New method.
5283         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5284         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5285         (make_source_or_disasm_window): Add cast.
5286         * tui/tui-data.h (union tui_which_element) <simple_string>:
5287         Remove.
5288         (struct tui_source_info): New.
5289         (struct tui_source_window_base) <execution_info>: Change type.
5290         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5291         case, and add assert.
5292         (tui_alloc_content): Add assert.
5293
5294 2019-06-25  Tom Tromey  <tom@tromey.com>
5295
5296         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5297         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5298         * tui/tui-data.c (tui_alloc_win_info): Remove.
5299
5300 2019-06-25  Tom Tromey  <tom@tromey.com>
5301
5302         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5303         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5304         can_highlight.
5305
5306 2019-06-25  Tom Tromey  <tom@tromey.com>
5307
5308         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5309         make_visible_with_new_height method.
5310         (tui_win_info::make_visible_with_new_height): New method.
5311         (tui_source_window_base::do_make_visible_with_new_height)
5312         (tui_data_window::do_make_visible_with_new_height)
5313         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5314         (make_visible_with_new_height): Remove.
5315         (tui_resize_all, tui_adjust_win_heights): Use
5316         make_visible_with_new_height method.
5317         * tui/tui-data.h (struct tui_win_info)
5318         <do_make_visible_with_new_height, make_visible_with_new_height>:
5319         New methods.
5320         (struct tui_source_window_base, struct tui_data_window)
5321         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5322         methods.
5323
5324 2019-06-25  Tom Tromey  <tom@tromey.com>
5325
5326         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5327         method.
5328         (update_tab_width): Call update_tab_width method.
5329         * tui/tui-data.h (struct tui_win_info)
5330         (struct tui_source_window_base) <update_tab_width>: New methods.
5331
5332 2019-06-25  Tom Tromey  <tom@tromey.com>
5333
5334         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5335         parameter.
5336         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5337         parameter.
5338         (tui_gen_win_info::make_visible): Update.
5339         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5340         parameter.
5341         * tui/tui-data.h (enum tui_box): New enum.
5342         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5343
5344 2019-06-25  Tom Tromey  <tom@tromey.com>
5345
5346         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5347         init_and_make_win for EXEC_INFO_WIN.
5348         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5349         longer inline.
5350         (struct tui_win_info) <~tui_win_info>: Inline.
5351         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5352         Don't declare.
5353         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5354         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5355         Remove.
5356         (tui_initialize_static_data): Update.
5357         (~tui_gen_win_info): Handle more cleanup here.
5358         (~tui_source_window_base): Delete "execution_info".
5359         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5360
5361 2019-06-25  Tom Tromey  <tom@tromey.com>
5362
5363         * tui/tui-layout.c (make_command_window): Don't set
5364         can_highlight.
5365         (show_source_disasm_command): Call the reset method.
5366         (show_data): Don't set can_highlight.  Call the reset method.
5367         (tui_gen_win_info::reset): Rename from init_gen_win_info
5368         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5369         (show_source_or_disasm_and_command): Call the reset method.
5370         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5371         (struct tui_cmd_window): Set can_highlight.
5372
5373 2019-06-25  Tom Tromey  <tom@tromey.com>
5374
5375         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5376         from make_visible.
5377         (tui_make_visible, tui_make_invisible): Rewrite.
5378         (tui_win_info::make_visible): Remove.
5379         (tui_source_window_base::make_visible): Update.
5380         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5381         method.  Moved from...
5382         (struct tui_win_info) <make_visible>: ...here.
5383
5384 2019-06-25  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui-winsource.c
5387         (tui_source_window_base::do_scroll_horizontal): Remove direction
5388         parameter.
5389         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5390         direction parameter.
5391         * tui/tui-win.c (tui_win_info::forward_scroll)
5392         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5393         (tui_win_info::right_scroll): Update.
5394         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5395         direction parameter.
5396         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5397         direction parameter.
5398         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5399         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5400         Remove direction parameter.
5401         (struct tui_source_window_base, struct tui_source_window)
5402         (struct tui_disasm_window, struct tui_data_window)
5403         (struct tui_cmd_window): Update.
5404
5405 2019-06-25  Tom Tromey  <tom@tromey.com>
5406
5407         * tui/tui-winsource.h (tui_set_exec_info_content)
5408         (tui_show_exec_info_content, tui_erase_exec_info_content)
5409         (tui_clear_exec_info_content, tui_update_exec_info): Change
5410         argument to tui_source_window_base.
5411         * tui/tui-winsource.c (tui_set_exec_info_content)
5412         (tui_show_exec_info_content, tui_erase_exec_info_content)
5413         (tui_clear_exec_info_content, tui_update_exec_info): Change
5414         argument to tui_source_window_base.
5415
5416 2019-06-25  Tom Tromey  <tom@tromey.com>
5417
5418         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5419         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5420
5421 2019-06-25  Tom Tromey  <tom@tromey.com>
5422
5423         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5424         check.
5425
5426 2019-06-25  Tom Tromey  <tom@tromey.com>
5427
5428         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5429         type to void.
5430         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5431         type to void.
5432         * tui/tui-source.c (tui_set_source_content): Update.
5433         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5434
5435 2019-06-25  Tom Tromey  <tom@tromey.com>
5436
5437         * tui/tui-win.c (window_name_completer, tui_set_focus)
5438         (tui_all_windows_info): Use name method.
5439         * tui/tui-data.h (struct tui_gen_win_info)
5440         (struct tui_source_window, struct tui_disasm_window)
5441         (struct tui_data_window, struct tui_cmd_window) <name>: New
5442         method.
5443         (tui_win_name): Don't declare.
5444         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5445         (tui_win_name): Remove.
5446
5447 2019-06-25  Tom Tromey  <tom@tromey.com>
5448
5449         * tui/tui-winsource.h (tui_update_source_window)
5450         (tui_update_source_window_as_is): Change parameter type.
5451         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5452         to be a tui_source_window_base.
5453         (tui_update_source_window_as_is): Likewise.
5454         * tui/tui-win.c (make_visible_with_new_height): Update.
5455
5456 2019-06-25  Tom Tromey  <tom@tromey.com>
5457
5458         * tui/tui-winsource.c (tui_erase_source_content)
5459         (tui_show_source_content, tui_show_exec_info_content)
5460         (tui_erase_exec_info_content): Use refresh_window method.
5461         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5462         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5463         from tui_refresh_win.
5464         (tui_data_window::refresh_window): New method.
5465         (tui_win_info::refresh, tui_source_window_base::refresh)
5466         (tui_refresh_all): Use refresh_window method.
5467         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5468         method.
5469         * tui/tui-regs.c (tui_display_register): Call refresh_window
5470         method.
5471         * tui/tui-layout.c (show_source_disasm_command)
5472         (show_source_or_disasm_and_command): Call refresh_window method.
5473         * tui/tui-data.h (struct tui_gen_win_info)
5474         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5475         New method.
5476
5477 2019-06-25  Tom Tromey  <tom@tromey.com>
5478
5479         * tui/tui.c (tui_rl_other_window, tui_enable)
5480         (tui_is_window_visible, tui_get_command_dimension): Update.
5481         * tui/tui-winsource.c (tui_update_source_window_as_is)
5482         (tui_clear_source_content, tui_erase_source_content)
5483         (tui_show_source_line, tui_source_window_base::refill)
5484         (tui_source_window_base::do_scroll_horizontal)
5485         (tui_source_window_base::set_is_exec_point_at)
5486         (tui_update_breakpoint_info, tui_set_exec_info_content)
5487         (tui_alloc_source_buffer, tui_line_is_displayed)
5488         (tui_addr_is_displayed): Update.
5489         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5490         (tui_check_and_display_highlight_if_needed)
5491         (tui_win_info::make_visible, tui_win_info::refresh)
5492         (tui_refresh_all): Update.
5493         * tui/tui-windata.c (tui_first_data_item_displayed)
5494         (tui_delete_data_content_windows, tui_erase_data_content)
5495         (tui_display_all_data, tui_data_window::refresh_all)
5496         (tui_check_data_values): Update.
5497         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5498         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5499         (tui_win_info::backward_scroll, tui_refresh_all_win)
5500         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5501         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5502         (tui_source_window_base::set_new_height)
5503         (tui_data_window::set_new_height)
5504         (make_invisible_and_set_new_height)
5505         (make_visible_with_new_height, new_height_ok)
5506         (parse_scrolling_args): Update.
5507         * tui/tui-stack.c (tui_show_frame_info): Update.
5508         * tui/tui-source.c (tui_set_source_content)
5509         (tui_set_source_content_nil, tui_source_is_displayed)
5510         (tui_source_window::do_scroll_vertical): Update.
5511         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5512         (tui_display_registers_from, tui_display_reg_element_at_line)
5513         (tui_check_register_values, tui_reg_command): Update.
5514         * tui/tui-layout.c (tui_default_win_height)
5515         (show_source_disasm_command, show_data, init_and_make_win)
5516         (show_source_or_disasm_and_command): Update.
5517         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5518         (tui_redisplay_readline, tui_mld_flush)
5519         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5520         (tui_getc): Update.
5521         * tui/tui-disasm.c (tui_set_disassem_content)
5522         (tui_disasm_window::do_scroll_vertical): Update.
5523         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5524         Now virtual.
5525         (struct tui_win_info): Derive from tui_gen_win_info.
5526         <~tui_win_info>: Mark as override.
5527         <generic>: Remove member.
5528         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5529         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5530         (~tui_data_window, ~tui_win_info)
5531         (tui_free_all_source_wins_content): Update.
5532         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5533
5534 2019-06-25  Tom Tromey  <tom@tromey.com>
5535
5536         * tui/tui-layout.c (init_and_make_win): Use new.
5537         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5538         destructor, initializers.
5539         (tui_alloc_generic_win_info): Don't declare.
5540         * tui/tui-data.c (_locator): Add argument to constructor.
5541         (source_win, disasm_win): New globals.
5542         (exec_info): Remove.
5543         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5544         Update.
5545         (tui_alloc_generic_win_info): Remove.
5546         (init_content_element): Use new.
5547         (tui_win_info::tui_win_info): Update.
5548         (free_content_elements) <case DATA_WIN>: Use delete.
5549
5550 2019-06-25  Tom Tromey  <tom@tromey.com>
5551
5552         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5553         * tui/tui-windata.c (tui_first_data_item_displayed)
5554         (tui_delete_data_content_windows): Update.
5555         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5556         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5557         (tui_display_registers_from, tui_check_register_values): Update.
5558         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5559         pointer.
5560         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5561         window.
5562         (tui_free_data_content): Update.
5563         (free_content_elements) <case DATA_WIN>: Free the window.
5564
5565 2019-06-25  Tom Tromey  <tom@tromey.com>
5566
5567         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5568         Update.
5569         * tui/tui-layout.c (make_command_window)
5570         (show_source_disasm_command, show_data, init_and_make_win)
5571         (show_source_or_disasm_and_command): Update.
5572         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5573         method.
5574         <can_highight, is_highlighted>: Now bool.
5575         (tui_set_win_highlight): Don't declare.
5576         * tui/tui-data.c (tui_set_win_highlight): Remove.
5577
5578 2019-06-25  Tom Tromey  <tom@tromey.com>
5579
5580         * tui/tui-wingeneral.c (make_visible): Remove check of window
5581         type.
5582
5583 2019-06-25  Tom Tromey  <tom@tromey.com>
5584
5585         * tui/tui-win.c (tui_win_info::max_height)
5586         (tui_cmd_window::max_height): New methods.
5587         (new_height_ok): Call max_height.
5588         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5589         <max_height>: New method.
5590
5591 2019-06-25  Tom Tromey  <tom@tromey.com>
5592
5593         * tui/tui-win.c (tui_source_window_base::set_new_height)
5594         (tui_data_window::set_new_height): New methods.
5595         (make_invisible_and_set_new_height): Call set_new_height method.
5596         * tui/tui-data.h (struct tui_win_info)
5597         (struct tui_source_window_base, struct tui_data_window)
5598         <set_new_height>: New method.
5599
5600 2019-06-25  Tom Tromey  <tom@tromey.com>
5601
5602         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5603         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5604         tui_refresh_data_win.
5605         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5606         method.
5607         (tui_refresh_all_win): Call the refresh_all method.
5608         (tui_set_focus): Likewise.
5609         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5610         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5611         Likewise.
5612
5613 2019-06-25  Tom Tromey  <tom@tromey.com>
5614
5615         * tui/tui-winsource.h (tui_refill_source_window)
5616         (tui_set_is_exec_point_at): Don't declare.
5617         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5618         (tui_source_window_base::refill): Rename from
5619         tui_refill_source_window.
5620         (tui_source_window_base::do_scroll_horizontal): Update.
5621         (tui_source_window_base::set_is_exec_point_at): Rename from
5622         tui_set_is_exec_point_at.
5623         (tui_update_all_breakpoint_info): Update.
5624         * tui/tui-stack.c (tui_show_frame_info): Update.
5625         * tui/tui-layout.c (show_data): Add cast.
5626         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5627         * tui/tui-data.h (struct tui_source_window_base) <refill,
5628         set_is_exec_point_at>: New methods.
5629         (tui_source_windows, tui_add_to_source_windows): Update types.
5630         (tui_add_to_source_windows): Remove redundant declaration.
5631         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5632         (tui_source_windows): Change return type.
5633         (tui_clear_source_windows_detail): Update.
5634         (tui_add_to_source_windows): Change type of parameter.
5635         (tui_free_all_source_wins_content): Update.
5636
5637 2019-06-25  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui-wingeneral.c (tui_win_info::refresh)
5640         (tui_source_window_base::refresh): New methods.
5641         (tui_refresh_all): Call the refresh method.
5642         * tui/tui-data.h (struct tui_win_info)
5643         (struct tui_source_window_base) <refresh>: New method.
5644
5645 2019-06-25  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui.h (tui_is_window_visible): Return bool.
5648         * tui/tui.c (tui_is_window_visible): Return bool.
5649         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5650         (tui_make_visible, tui_make_invisible)
5651         (tui_win_info::make_visible)
5652         (tui_source_window_base::make_visible, make_all_visible)
5653         (tui_make_all_visible, tui_make_all_invisible): Update.
5654         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5655         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5656         bool.
5657         (struct tui_win_info, struct tui_source_window_base)
5658         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5659         * tui/tui-data.c (tui_init_generic_part): Update.
5660
5661 2019-06-25  Tom Tromey  <tom@tromey.com>
5662
5663         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5664         (tui_source_window_base::make_visible): New methods.
5665         (make_all_visible): Make method call.
5666         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5667         (struct tui_source_window_base, struct tui_cmd_window): Override
5668         make_visible.
5669         (tui_win_is_source_type): Don't declare.
5670         * tui/tui-data.c (tui_win_is_source_type): Remove.
5671
5672 2019-06-25  Tom Tromey  <tom@tromey.com>
5673
5674         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5675         NULL check.
5676
5677 2019-06-25  Tom Tromey  <tom@tromey.com>
5678
5679         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5680         Inline constructor.  Add initializers for members.
5681         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5682         constructors; now inline in class.
5683
5684 2019-06-25  Tom Tromey  <tom@tromey.com>
5685
5686         * tui/tui-regs.c (tui_show_registers): Update.
5687         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5688         bool.
5689         * tui/tui-data.c (tui_data_window::clear_detail)
5690         (tui_data_window): Update.
5691
5692 2019-06-25  Tom Tromey  <tom@tromey.com>
5693
5694         * tui/tui-windata.c (tui_display_all_data)
5695         (tui_display_data_from_line, tui_display_data_from)
5696         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5697         Update.
5698         * tui/tui-regs.c (tui_last_regs_line_no)
5699         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5700         (tui_show_registers, tui_show_register_group)
5701         (tui_display_registers_from, tui_display_reg_element_at_line)
5702         (tui_display_registers_from_line, tui_check_register_values)
5703         (tui_reg_next, tui_reg_prev): Update.
5704         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5705         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5706         tui_data_window.
5707         (struct tui_win_info) <detail>: Remove.  Add new fields from
5708         tui_data_info.
5709         (TUI_DATA_WIN): Add cast.
5710         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5711         (~tui_data_window): Simplify.
5712
5713 2019-06-25  Tom Tromey  <tom@tromey.com>
5714
5715         * tui/tui-layout.c (show_source_disasm_command)
5716         (show_source_or_disasm_and_command): Update.
5717         * tui/tui-io.c (update_cmdwin_start_line)
5718         (tui_redisplay_readline): Update.
5719         * tui/tui-data.h (struct tui_command_info): Remove.
5720         (struct tui_win_info) <detail>: Remove command_info member.
5721         (struct tui_data_window) <start_line>: New member, from
5722         tui_command_info.
5723         (TUI_CMD_WIN): Add casts.
5724
5725 2019-06-25  Tom Tromey  <tom@tromey.com>
5726
5727         * tui/tui-winsource.c (tui_update_source_window)
5728         (tui_refill_source_window)
5729         (tui_source_window_base::do_scroll_horizontal)
5730         (tui_update_breakpoint_info, tui_set_exec_info_content)
5731         (tui_show_exec_info_content, tui_erase_exec_info_content)
5732         (tui_clear_exec_info_content): Update.
5733         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5734         Update.
5735         * tui/tui-win.c (make_invisible_and_set_new_height)
5736         (make_visible_with_new_height): Update.
5737         * tui/tui-source.c (tui_set_source_content)
5738         (tui_show_symtab_source): Update.
5739         * tui/tui-layout.c (extract_display_start_addr)
5740         (show_source_disasm_command, show_data)
5741         (make_source_or_disasm_window)
5742         (show_source_or_disasm_and_command): Update.
5743         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5744         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5745         "gdbarch".
5746         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5747         to tui_source_window_base.
5748         (struct tui_win_info) <detail>: Remove source_info member.
5749         (struct tui_source_window_base) <has_locator>: Inline.
5750         Move contents from tui_source_info; rename has_locator member to
5751         m_has_locator.
5752         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5753         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5754         header file.
5755         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5756         Simplify.
5757         (tui_free_all_source_wins_content): Cast to
5758         tui_source_window_base.
5759
5760 2019-06-25  Tom Tromey  <tom@tromey.com>
5761
5762         * tui/tui-win.c (make_invisible_and_set_new_height)
5763         (make_visible_with_new_height): Call has_locator method.
5764         * tui/tui-layout.c (show_source_disasm_command, show_data)
5765         (show_source_or_disasm_and_command): Update for bool change.
5766         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5767         (tui_win_info) <has_locator>: New method.
5768         (struct tui_source_window_base) <has_locator>: New method.
5769         (tui_win_has_locator): Don't declare.
5770         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5771         from tui_win_has_locator.
5772         (tui_source_window_base): Use false, not FALSE.
5773
5774 2019-06-25  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5777         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5778         clear_detail method directly.
5779         (tui_clear_win_detail): Remove.
5780
5781 2019-06-25  Tom Tromey  <tom@tromey.com>
5782
5783         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5784         "this", not TUI_DISASM_WIN.
5785
5786 2019-06-25  Tom Tromey  <tom@tromey.com>
5787
5788         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5789         declare.
5790         * tui/tui-winsource.c
5791         (tui_source_window_base::do_scroll_horizontal): Rename from
5792         tui_horizontal_source_scroll.
5793         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5794         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5795         from tui_vertical_data_scroll.
5796         * tui/tui-win.h (tui_scroll): Don't declare.
5797         * tui/tui-win.c (tui_win_info::forward_scroll)
5798         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5799         (tui_win_info::right_scroll): Rename and update.
5800         (tui_scroll_forward_command, tui_scroll_backward_command)
5801         (tui_scroll_left_command, tui_scroll_right_command): Update.
5802         (tui_scroll): Remove.
5803         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5804         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5805         from tui_vertical_source_scroll.
5806         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5807         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5808         from tui_vertical_disassem_scroll.
5809         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5810         do_scroll_horizontal>: New methods.
5811         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5812         Likewise.
5813         (struct tui_source_window_base): Add do_scroll_horizontal.
5814         (struct tui_source_window, struct tui_disasm_window): Add
5815         do_scroll_vertical.
5816         (struct tui_data_window, struct tui_cmd_window): Add
5817         do_scroll_horizontal and do_scroll_vertical.
5818         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5819
5820 2019-06-25  Tom Tromey  <tom@tromey.com>
5821
5822         * tui/tui-data.h (struct tui_source_window_base): New struct.
5823         (struct tui_source_window): Derive from tui_source_window_base.
5824         (struct tui_disasm_window): New struct.
5825         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5826         from tui_source_window::clear_detail.
5827         (tui_source_window_base): Rename from tui_source_window.
5828         (~tui_source_window_base): Rename from ~tui_source_window.
5829         (tui_alloc_win_info): Create a tui_disasm_window.
5830
5831 2019-06-25  Tom Tromey  <tom@tromey.com>
5832
5833         * tui/tui-data.h (struct tui_source_window)
5834         (struct tui_data_window): Declare destructors.
5835         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5836         destructors.
5837         (tui_win_info): Simplify.
5838
5839 2019-06-25  Tom Tromey  <tom@tromey.com>
5840
5841         * tui/tui-winsource.c (tui_display_main)
5842         (tui_update_source_windows_with_addr)
5843         (tui_update_all_breakpoint_info): Update.
5844         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5845         (new_height_ok, parse_scrolling_args): Update.
5846         * tui/tui-stack.c (tui_show_frame_info): Update.
5847         * tui/tui-data.h (struct tui_list): Remove.
5848         (tui_source_windows): Return a reference to a std::vector.
5849         * tui/tui-data.c (source_windows): Now a std::vector.
5850         (tui_source_windows): Change return type.
5851         (tui_clear_source_windows): Rewrite.
5852         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5853         (tui_free_all_source_wins_content): Rewrite.
5854
5855 2019-06-25  Tom Tromey  <tom@tromey.com>
5856
5857         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5858         (struct tui_data_window, struct tui_cmd_window): Declare
5859         clear_detail method.
5860         * tui/tui-data.c (tui_source_window::clear_detail)
5861         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5862         methods.
5863         (tui_clear_win_detail): Simplify.
5864
5865 2019-06-25  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-layout.c (make_source_window, make_disasm_window)
5868         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5869         Return the new window.
5870         (show_source_disasm_command, show_data)
5871         (show_source_or_disasm_and_command): Update.
5872
5873 2019-06-25  Tom Tromey  <tom@tromey.com>
5874
5875         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5876         parameter.  Return the new window.
5877         (show_source_disasm_command): Update and remove NULL check.
5878         (show_source_or_disasm_and_command): Update.
5879
5880 2019-06-25  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5883
5884 2019-06-25  Tom Tromey  <tom@tromey.com>
5885
5886         * tui/tui-data.h (struct tui_win_info): Make constructor
5887         protected.  Make destructor virtual.  Add initializers.
5888         (tui_source_window, tui_data_window, tui_cmd_window): New
5889         classes.
5890         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5891         constructor.  Add "type" parameter.
5892         (tui_source_window, tui_data_window, tui_cmd_window): New
5893         constructors.
5894         (tui_alloc_win_info): Instantiate the appropriate subclass.
5895
5896 2019-06-25  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-win.c (tui_resize_all): Use delete.
5899         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5900         destructor.
5901         (tui_free_window): Don't declare.
5902         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5903         Update.
5904
5905 2019-06-25  Tom Tromey  <tom@tromey.com>
5906
5907         * tui/tui-data.h (struct tui_win_info): Add constructor.
5908         * tui/tui-data.c (tui_alloc_win_info): Use new.
5909         (tui_free_window): Use delete.
5910
5911 2019-06-22  Tom Tromey  <tom@tromey.com>
5912
5913         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5914         declare.
5915         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5916
5917 2019-06-22  Tom Tromey  <tom@tromey.com>
5918
5919         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5920         declare.
5921         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5922
5923 2019-06-22  Tom de Vries  <tdevries@suse.de>
5924
5925         * dwarf2read.c (create_addrmap_from_aranges)
5926         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5927         instead of '%zu'.
5928
5929 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5930
5931         * dwarf2read.h (dwarf2_section_info_def): Remove.
5932         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5933         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5934         std::vector<dwarf2_section_info>.
5935         (struct dwo_file) <~dwo_file>: Remove.
5936         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5937         types field.
5938         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5939         (dwarf2_read_debug_names): Likewise.
5940         (create_debug_types_hash_table): Change parameter type to
5941         array_view, adjust code accordingly.
5942         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5943         (partial_die_info::fixup): Likewise.
5944         (determine_prefix): Likewise.
5945         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5946
5947 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5948
5949         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5950         gdb_bfd_ref_ptr.
5951         <~dwo_file>: Remove call to gdb_bfd_unref.
5952         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5953         gdb_bfd_ref_ptr::get.
5954
5955 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5956
5957         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5958         type to htab_up.
5959         * dwarf2read.c (struct dwo_file): Initialize fields.
5960         <~dwo_file>: New.
5961         (free_dwo_file): Remove, move content to ~dwo_file.
5962         (struct dwo_file_deleter): Remove.
5963         (dwo_file_up>: Remove custom deleter.
5964         (free_dwo_files): Remove.
5965         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5966         dwo_files.
5967         (process_skeletonless_type_units): Call unique_ptr::get.
5968         (allocate_dwo_file_hash_table): Add deleter to created hash
5969         table.  Change return type to htab_up.
5970         (lookup_dwo_file_slot): Don't memset dwo_file, call
5971         unique_ptr::get.
5972         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5973         (create_dwo_unit_in_dwp_v2): Likewise.
5974         (open_and_init_dwo_file): Likewise.
5975         (free_dwo_file_from_slot): Remove.
5976
5977 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5978
5979         * dwarf2read.h (struct dwarf2_section_info) <readin,
5980         is_virtual>: Change type to bool.
5981         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5982         true instead of 1.
5983
5984 2019-06-19  Tom Tromey  <tom@tromey.com>
5985
5986         * tui/tui-data.h (tui_init_content_element): Don't declare.
5987
5988 2019-06-19  Tom Tromey  <tom@tromey.com>
5989
5990         * tui/tui-data.h (tui_init_win_info): Don't declare.
5991
5992 2019-06-19  Tom de Vries  <tdevries@suse.de>
5993
5994         * dwarf2read.h (abstract_to_concrete): Change type to
5995         std::unordered_map<sect_offset, std::vector<sect_offset>,
5996         gdb::hash_enum<sect_offset>>.
5997
5998 2019-06-19  Tom Tromey  <tromey@adacore.com>
5999
6000         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6001         EVAL_AVOID_SIDE_EFFECTS specially.
6002
6003 2019-06-19  Tom Tromey  <tromey@adacore.com>
6004
6005         * source-cache.c (highlighter): New global.
6006         (source_cache::get_source_lines): Create a highlighter on demand.
6007
6008 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6009
6010         * defs.h (deprecated_interactive_hook): Delete declaration.
6011         * interps.c (clear_interpreter_hooks): Remove use of
6012         deprecated_interactive_hook.
6013         * top.c (deprecated_interactive_hook): Delete definition.
6014         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6015
6016 2019-06-18  Tom de Vries  <tdevries@suse.de>
6017
6018         PR gdb/24515
6019         * dwarf2read.h (abstract_to_concrete): Change type from
6020         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6021         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6022         * dwarf2read.c (read_variable): Update.
6023         (dwarf2_fetch_die_loc_sect_off): Update.
6024
6025 2019-06-17  Tom de Vries  <tdevries@suse.de>
6026
6027         PR gdb/24617
6028         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6029         accessing parent[parent_len - 1].
6030
6031 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6032
6033         PR gdb/24364
6034         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6035         call dtrace_process_dof with NULL dof.
6036
6037 2019-06-16  Tom de Vries  <tdevries@suse.de>
6038
6039         PR gdb/24445
6040         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6041
6042 2019-06-16  Tom Tromey  <tom@tromey.com>
6043
6044         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6045         (make_all_visible): Use address of member.
6046
6047 2019-06-16  Tom Tromey  <tom@tromey.com>
6048
6049         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6050         (tui_free_window, free_content, free_content_elements): Remove
6051         unnecessary cast.
6052         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6053         cast.
6054         * tui/tui-regs.c (tui_show_register_group)
6055         (tui_display_registers_from, tui_display_reg_element_at_line):
6056         Remove unnecessary cast.
6057
6058 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6059
6060         * linux-nat.c (normal_mask): Delete.
6061         (_initialize_linux_nat): Don't initialise normal_mask.
6062
6063 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6064
6065         PR gdb/24445
6066         * dwarf-index-write.h (write_psymtabs_to_index): Add
6067         dwz_basename parameter.
6068         * dwarf-index-write.c (write_gdbindex): Move file writing to
6069         write_gdbindex_1.  Change return type void.
6070         (assert_file_size): Move up, remove filename parameter.
6071         (write_gdbindex_1): New function.
6072         (write_debug_names): Change return type to void, call
6073         assert_file_size.
6074         (struct index_wip_file): New struct.
6075         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6076         file logic to index_wip_file.  Write index for dwz file if
6077         needed.
6078         (save_gdb_index_command): Pass basename of dwz file, if present.
6079         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6080         build-id of dwz file, if present.
6081         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6082         (dwarf2_get_dwz_file): Likewise.
6083         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6084         (dwarf2_get_dwz_file): Likewise.
6085
6086 2019-06-16  Tom Tromey  <tom@tromey.com>
6087
6088         * coffread.c (process_coff_symbol): Use xstrdup.
6089         * value.c (create_internalvar): Use xstrdup.
6090
6091 2019-06-16  Tom Tromey  <tom@tromey.com>
6092
6093         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6094         * breakpoint.c (stopin_command, stopat_command)
6095         (until_break_command, decode_location_default): Remove unnecessary
6096         cast.
6097         * utils.c (subset_compare): Remove unnecessary cast.
6098         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6099         cast.
6100         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6101         cast.
6102         * infcmd.c (path_command): Remove unnecessary cast.
6103         * coffread.c (decode_type): Remove unnecessary cast.
6104         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6105         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6106         * tui/tui-stack.c (tui_show_locator_content)
6107         (tui_show_frame_info): Remove unnecessary cast.
6108         * tui/tui-win.c (tui_scroll_forward_command)
6109         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6110         (parse_scrolling_args): Remove unnecessary cast.
6111         * tui/tui-data.c (init_win_info, tui_del_window)
6112         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6113         (free_content_elements): Remove unnecessary cast.
6114         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6115         unnecessary cast.
6116         * tui/tui-source.c (tui_set_source_content)
6117         (tui_vertical_source_scroll): Remove unnecessary cast.
6118         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6119         cast.
6120         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6121         * tui/tui-regs.c (tui_display_registers_from)
6122         (tui_display_register): Remove unnecessary cast.
6123         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6124         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6125         (make_visible): Remove unnecessary cast.
6126         * tui/tui-winsource.c (tui_erase_source_content)
6127         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6128         unnecessary cast.
6129         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6130         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6131         * stabsread.c (read_type, read_array_type, read_range_type):
6132         Remove unnecessary cast.
6133         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6134         (parse_symbol, parse_type, upgrade_type, parse_external)
6135         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6136         unnecessary cast.
6137         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6138
6139 2019-06-16  Tom Tromey  <tom@tromey.com>
6140
6141         * tui/tui-data.c (tui_alloc_generic_win_info)
6142         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6143         checks.
6144
6145 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6146             Andrew Burgess  <andrew.burgess@embecosm.com>
6147
6148         * f-typeprint.c (f_print_type): Don't return early for not
6149         associated or not allocated types.
6150         (f_type_print_varspec_suffix): Add print_rank parameter and print
6151         ranks of array types in case they dangling.
6152         (f_type_print_base): Add print_rank parameter.
6153
6154 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6155
6156         * NEWS: Mention new MI commands.
6157         * break-catch-throw.c (enum exception_event_kind): Move to
6158         breakpoint.h.
6159         (print_mention_exception_catchpoint): Output text as a single
6160         message.
6161         (catch_exception_command_1): Rename to...
6162         (catch_exception_event): ...this, make non-static, update header
6163         command, and change some parameter types.
6164         (catch_catch_command): Update for changes to
6165         catch_exception_command_1.
6166         (catch_throw_command): Likewise.
6167         (catch_rethrow_command): Likewise.
6168         * breakpoint.c (enum exception_event_kind): Delete.
6169         * breakpoint.h (enum exception_event_kind): Moved here from
6170         break-catch-throw.c.
6171         (catch_exception_event): Declare.
6172         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6173         (mi_cmd_catch_throw): New function.
6174         (mi_cmd_catch_rethrow): New function.
6175         (mi_cmd_catch_catch): New function.
6176         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6177         'catch-catch' entries.
6178         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6179         (mi_cmd_catch_rethrow): Declare.
6180         (mi_cmd_catch_catch): Declare.
6181
6182 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6183
6184         * annotate.c (annotate_source_line): Change return type to void,
6185         update implementation to match.
6186         * annotate.h (annotate_source_line): Change return type to void,
6187         update header comment.
6188         * stack.c (print_frame_info): Don't change what frame information
6189         is printed based on whether annotations are on or not.
6190
6191 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6194         (annotate_source): Make static.
6195         (annotate_source_line): Moved from source.c and renamed from
6196         identify_source_line.  Update the return type.
6197         * annotate.h (annotate_source): Delete declaration.
6198         (annotate_source_line): Declaration moved from source.h, and
6199         renamed from identify_source_line.  Return type updated.
6200         * source.c (identify_source_line): Moved to annotate.c and renamed
6201         to annotate_source_line.
6202         (info_line_command): Remove check of annotation_level.
6203         * source.h (identify_source_line): Move declaration to annotate.h
6204         and rename to annotate_source_line.
6205         * stack.c: Add 'annotate.h' include.
6206         (print_frame_info): Remove check of annotation_level before
6207         calling annotate_source_line.
6208
6209 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6210
6211         * source-cache.c (source_cache::get_plain_source_lines): Use
6212         open_source_file_with_line_charpos instead of just
6213         open_source_file, remove call to find_source_lines.
6214         (source_cache::get_source_lines): Likewise.
6215         * source.c (find_source_lines): Make static.
6216         (get_filename_and_charpos): Renamed into...
6217         (open_source_file_with_line_charpos): ..this along with changes to
6218         return a scoped_fd, and some other minor clean ups.
6219         (identify_source_line): Use open_source_file_with_line_charpos.
6220         (search_command_helper): Use open_source_file_with_line_charpos
6221         instead of just open_source_file, remove call to
6222         find_source_lines.
6223         * source.h (open_source_file_with_line_charpos): Declare new
6224         function.
6225         (find_source_lines): Delete declaration.
6226
6227 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         * source.c (get_filename_and_charpos): Remove fullname
6230         parameter.
6231         (identify_source_line): Update call to get_filename_and_charpos.
6232
6233 2019-06-14  Tom Tromey  <tromey@adacore.com>
6234
6235         PR gdb/24502:
6236         * ui-style.h (skip_ansi_escape): Update comment.
6237         * ui-file.h (class no_terminal_escape_file): New class.
6238         * ui-file.c (no_terminal_escape_file::write)
6239         (no_terminal_escape_file::puts): New methods.
6240         * cli/cli-logging.c (handle_redirections): Use
6241         no_terminal_escape_file.
6242
6243 2019-06-14  Tom Tromey  <tromey@adacore.com>
6244
6245         * NEWS: Move convenience variable news above Python news.
6246
6247 2019-06-14  Tom Tromey  <tom@tromey.com>
6248
6249         * gnulib: Move directory to top-level.
6250         * configure.ac: Don't configure gnulib.
6251         * configure: Rebuild.
6252         * common/common-defs.h: Use new path to gnulib.
6253         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6254         (GNULIB_H): Remove.
6255         (INCGNU): Look in new gnulib location.
6256         (HFILES_NO_SRCDIR): Remove gnulib files.
6257         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6258         (generated_files): Remove GNULIB_H.
6259         ($(LIBGNU), all-lib): Remove targets.
6260         (distclean): Don't mention GNULIB_BUILDDIR.
6261         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6262
6263 2019-06-14  Tom Tromey  <tromey@adacore.com>
6264
6265         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6266         Warn if symbol file does not provide any symbols.
6267
6268 2019-06-14  Tom Tromey  <tromey@adacore.com>
6269
6270         * source.c (find_and_open_source): Respect basenames_may_differ.
6271
6272 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6273
6274         * annotate.c (annotate_breakpoints_invalid): Make use of
6275         scoped_restore_terminal_state.
6276         (annotate_frames_invalid): Likewise.
6277
6278 2019-06-14  Tom Tromey  <tromey@adacore.com>
6279
6280         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6281         allow assignment to an internalvar.
6282
6283 2019-06-14  Tom Tromey  <tromey@adacore.com>
6284
6285         * ada-lex.l: Allow "_" in attribute names.
6286
6287 2019-06-14  Tom Tromey  <tromey@adacore.com>
6288
6289         PR gdb/24653:
6290         * regcache.c (registers_changed): Don't call alloca.
6291         * top.c (execute_command): Don't call alloca.
6292
6293 2019-06-13  Pedro Alves  <palves@redhat.com>
6294
6295         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6296         'expression'.  When parsing an expression, error out if there's
6297         junk after "unlimited".
6298         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6299         (do_set_command): Adjust calls to is_unlimited_literal.
6300
6301 2019-06-13  Pedro Alves  <palves@redhat.com>
6302
6303         * compile/compile.c (make_compile_options_def_group): Add braces
6304         around array_view initializer.
6305         * thread.c (make_thread_apply_all_options_def_group)
6306         (make_thread_apply_all_options_def_group): Likewise.
6307
6308 2019-06-13  Pedro Alves  <palves@redhat.com>
6309
6310         * NEWS (New commands): Mention "maint test-options
6311         require-delimiter", "maint test-options unknown-is-error", "maint
6312         test-options unknown-is-operand" and "maint show
6313         test-options-completion-result".
6314         (New command options, command completion): New section.
6315         (Completion improvements): New section.
6316         Mention that you can abbreviate "unlimited".
6317
6318 2019-06-13  Pedro Alves  <palves@redhat.com>
6319
6320         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6321         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6322         * unittests/cli-utils-selftests.c (test_parse_flags)
6323         (test_parse_flags_qcs): Delete.
6324         (test_cli_utils): Don't call deleted functions.
6325
6326 2019-06-13  Pedro Alves  <palves@redhat.com>
6327
6328         * thread.c: Include "cli/cli-option.h".
6329         (tp_array_compar_ascending): Global.
6330         (tp_array_compar): Delete function.
6331         (tp_array_compar_ascending, tp_array_compar_descending): New
6332         functions.
6333         (ascending_option_def, qcs_flag_option_def)
6334         (thr_qcs_flags_option_defs)
6335         (make_thread_apply_all_options_def_group)
6336         (make_thread_apply_options_def_group): New.
6337         (thread_apply_all_command): Use gdb::option::process_options.
6338         (thread_apply_command_completer)
6339         (thread_apply_all_command_completer): New.
6340         (thread_apply_command): Use gdb::option::process_options.
6341         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6342         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6343         to generate help text of "thread apply".  Adjust "taas"'s help.
6344         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6345         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6346
6347 2019-06-13  Pedro Alves  <palves@redhat.com>
6348
6349         * thread.c (thread_apply_command): Check for invalid TID with
6350         isdigit instead of !isalpha.
6351
6352 2019-06-13  Pedro Alves  <palves@redhat.com>
6353
6354         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6355         (validate_flags_qcs): New.
6356         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6357         (validate_flags_qcs): Declare.
6358         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6359         (make_frame_apply_options_def_group): New.
6360         (frame_apply_command_count): Process options with
6361         gdb::option::process_options.
6362         (frame_apply_completer): New.
6363         (frame_apply_level_completer, frame_apply_all_completer)
6364         (frame_apply_completer): New.
6365         (_initialize_stack): Update help of "frame apply", "frame apply
6366         level", "frame apply all" and "faas" to mention supported options
6367         and install command completers.
6368         * stack.h (frame_apply_all_completer): Declare.
6369         * thread.c: Include "stack.h".
6370         (tfaas_command): Add "--".
6371         (_initialize_thread): Update help "tfaas" to mention supported
6372         options and install command completer.
6373
6374 2019-06-13  Pedro Alves  <palves@redhat.com>
6375
6376         * completer.c (complete_nested_command_line): New.
6377         (gdb_completion_word_break_characters_throw): Add assertion.
6378         * completer.h (complete_nested_command_line): Declare.
6379
6380 2019-06-13  Pedro Alves  <palves@redhat.com>
6381
6382         * stack.c (parse_backtrace_qualifiers): New.
6383         (backtrace_command): Use it.
6384         (backtrace_command_completer): Complete on qualifiers.
6385
6386 2019-06-13  Pedro Alves  <palves@redhat.com>
6387
6388         * frame.c: Include "cli/cli-option.h.
6389         (user_set_backtrace_options): New.
6390         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6391         Delete.
6392         (get_prev_frame): Adjust.
6393         (boolean_option_def, uinteger_option_def)
6394         (set_backtrace_option_defs): New.
6395         (_initialize_frame): Adjust and use
6396         gdb::option::add_setshow_cmds_for_options to install "set
6397         backtrace past-main" and "set backtrace past-entry".
6398         * frame.h: Include "cli/cli-option.h".
6399         (struct frame_print_options): Forward declare.
6400         (print_frame_arguments_all, print_frame_arguments_scalars)
6401         (print_frame_arguments_none): Declare.
6402         (print_entry_values): Delete declaration.
6403         (struct frame_print_options, user_frame_print_options): New.
6404         (struct set_backtrace_options): New.
6405         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6406         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6407         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6408         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6409         (list_args_or_locals): Add frame_print_options parameter.
6410         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6411         * python/py-framefilter.c (enumerate_args): Pass down
6412         USER_FRAME_PRINT_OPTIONS.
6413         * stack.c: Include "cli/cli-option.h".
6414         (print_frame_arguments_all, print_frame_arguments_scalars)
6415         (print_frame_arguments_none): Declare.
6416         (print_raw_frame_arguments, print_entry_values): Delete.
6417         (user_frame_print_options): New.
6418         (boolean_option_def, enum_option_def, frame_print_option_defs):
6419         New.
6420         (struct backtrace_cmd_options): New.
6421         (bt_flag_option_def): New.
6422         (backtrace_command_option_defs): New.
6423         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6424         (print_frame_arg, read_frame_arg, print_frame_args)
6425         (print_frame_info, print_frame): Add frame_print_options parameter
6426         and use it.
6427         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6428         (backtrace_command_1): Add frame_print_options and
6429         backtrace_cmd_options parameters and use them.
6430         (make_backtrace_options_def_group): New.
6431         (backtrace_command): Process command options with
6432         gdb::option::process_options.
6433         (backtrace_command_completer): New.
6434         (_initialize_stack): Extend "backtrace"'s help to mention
6435         supported options.  Install completer for "backtrace".
6436         Install some settings commands with add_setshow_cmds_for_options.
6437
6438 2019-06-13  Pedro Alves  <palves@redhat.com>
6439
6440         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6441         and that "set/show print raw frame-arguments" are now deprecated.
6442
6443         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6444         command.
6445         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6446         * stack.c (_initialize_stack): Install "set/show print
6447         raw-frame-arguments", and deprecate "set/show print raw
6448         frame-arguments".
6449         * valprint.c (_initialize_valprint): Deprecate "set/show print
6450         raw".
6451
6452 2019-06-13  Pedro Alves  <palves@redhat.com>
6453
6454         * compile/compile.c (struct compile_options): New.
6455         (compile_flag_option_def, compile_command_option_defs)
6456         (make_compile_options_def_group): New.
6457         (compile_file_command): Handle options with
6458         gdb::option::process_options.
6459         (compile_file_command_completer): New function.
6460         (compile_code_command): Handle options with
6461         gdb::option::process_options.
6462         (compile_code_command_completer): New function.
6463         (_initialize_compiler): Install completers for "compile code" and
6464         "compile file".  Mention available options in "compile code" and
6465         "compile code"'s help.
6466         * completer.c (advance_to_completion_word): New, factored out from
6467         ...
6468         (advance_to_expression_complete_word_point): ... this.
6469         (advance_to_filename_complete_word_point): New.
6470         * completer.h (advance_to_filename_complete_word_point): New
6471         declaration.
6472
6473 2019-06-13  Pedro Alves  <palves@redhat.com>
6474
6475         * compile/compile.c: Include "cli/cli-option.h".
6476         (compile_print_value): Scope data pointer is now a
6477         value_print_options pointer; adjust.
6478         (compile_print_command): Process options.  Scope data pointer is
6479         now a value_print_options pointer; adjust.
6480         (_initialize_compile): Update "compile print"'s help to include
6481         supported options.  Install a completer for "compile print".
6482         * cp-valprint.c (show_vtblprint, show_objectprint)
6483         (show_static_field_print): Delete.
6484         (_initialize_cp_valprint): Don't install "set print
6485         static-members", "set print vtbl", "set print object" here.
6486         * printcmd.c: Include "cli/cli-option.h" and
6487         "common/gdb_optional.h".
6488         (print_command_parse_format): Rework to fill in a
6489         value_print_options instead of a format_data.
6490         (print_value): Change parameter type from format_data pointer to
6491         value_print_options reference.  Adjust.
6492         (print_command_1): Process options.  Adjust to pass down a
6493         value_print_options.
6494         (print_command_completer): New.
6495         (_initialize_printcmd): Install print_command_completer as
6496         handle_brkchars completer for the "print" command.  Update
6497         "print"'s help to include supported options.
6498         * valprint.c: Include "cli/cli-option.h".
6499         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6500         here from cp-valprint.c.
6501         (boolean_option_def, uinteger_option_def)
6502         (value_print_option_defs, make_value_print_options_def_group):
6503         New.  Use gdb::option::add_setshow_cmds_for_options to install
6504         "set print elements", "set print null-stop", "set print repeats",
6505         "set print pretty", "set print union", "set print array", "set
6506         print address", "set print symbol", "set print array-indexes".
6507         * valprint.h: Include <string> and "cli/cli-option.h".
6508         (make_value_print_options_def_group): Declare.
6509         (print_value): Change parameter type from format_data pointer to
6510         value_print_options reference.
6511         (print_command_completer): Declare.
6512
6513 2019-06-13  Pedro Alves  <palves@redhat.com>
6514
6515         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6516         (COMMON_SFILES): Add maint-test-settings.c.
6517         * cli/cli-decode.c (boolean_enums): New global, factored out from
6518         ...
6519         (add_setshow_boolean_cmd): ... here.
6520         * cli/cli-decode.h (boolean_enums): Declare.
6521         * cli/cli-option.c: New file.
6522         * cli/cli-option.h: New file.
6523         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6524         factored out from ...
6525         (parse_cli_boolean_value(const char *)): ... this.
6526         (is_unlimited_literal): Change parameter type to pointer to
6527         pointer.  Adjust and advance ARG pointer.
6528         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6529         (parse_cli_var_enum): New, factored out from ...
6530         (do_set_command): ... this.  Adjust.
6531         * cli/cli-setshow.h (parse_cli_boolean_value)
6532         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6533         (parse_cli_var_enum): Declare.
6534         * cli/cli-utils.c: Include "cli/cli-option.h".
6535         (get_ulongest): New.
6536         * cli/cli-utils.h (get_ulongest): Declare.
6537         (check_for_argument): New overloads.
6538         * maint-test-options.c: New file.
6539
6540 2019-06-13  Pedro Alves  <palves@redhat.com>
6541
6542         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6543         parse a range if "-" is at the end of the string.
6544
6545 2019-06-13  Pedro Alves  <palves@redhat.com>
6546
6547         * cli/cli-setshow.c (parse_auto_binary_operation)
6548         (parse_cli_boolean_value): Don't allow "o".
6549
6550 2019-06-13  Pedro Alves  <palves@redhat.com>
6551
6552         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6553         * NEWS: Mention maint test-settings KIND.
6554         * maint-test-settings.c: New file.
6555
6556 2019-06-13  Pedro Alves  <palves@redhat.com>
6557
6558         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6559         completer.
6560         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6561         "set" completers.
6562
6563 2019-06-13  Pedro Alves  <palves@redhat.com>
6564
6565         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6566         after item.
6567
6568 2019-06-13  Pedro Alves  <palves@redhat.com>
6569
6570         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6571
6572 2019-06-13  Pedro Alves <palves@redhat.com>
6573
6574         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6575         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6576         call.
6577         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6578         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6579         calls.
6580         (check_for_argument): Skip spaces after argument.
6581
6582 2019-06-13  Pedro Alves  <palves@redhat.com>
6583
6584         * thread.c (thread_apply_command): Adjust TID parsing.
6585         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6586         detected before end of string.
6587         (tid_is_in_list): Error out if LIST is invalid.
6588
6589 2019-06-13  Pedro Alves  <palves@redhat.com>
6590
6591         * completer.c (complete_line_internal_1): Rewind completion word
6592         point.
6593         (completion_tracker::advance_custom_word_point_by): Change
6594         parameter type to int.
6595         * completer.h (completion_tracker::advance_custom_word_point_by):
6596         Likewise.
6597
6598 2019-06-13  Pedro Alves  <palves@redhat.com>
6599
6600         * completer.c (advance_to_completion_word): Handle delimiters.
6601
6602 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6603
6604         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6605
6606 2019-06-11  Tom Tromey  <tom@tromey.com>
6607
6608         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6609         (xmalloc_failed): Move to alloc.c.
6610         * alloc.c: New file.
6611         * Makefile.in (COMMON_SFILES): Add alloc.c.
6612
6613 2019-06-11  Tom Tromey  <tom@tromey.com>
6614
6615         * nat/linux-waitpid.c: Don't include server.h.
6616         (linux_debug): Remove.
6617         (my_waitpid): Update.
6618
6619 2019-06-11  Tom Tromey  <tromey@adacore.com>
6620
6621         * infcall.c (_initialize_infcall): Remove trailing newline from
6622         help.
6623         * user-regs.c (_initialize_user_regs): Remove trailing newline
6624         from help.
6625         * typeprint.c (_initialize_typeprint): Remove trailing newline
6626         from help.
6627         * reverse.c (_initialize_reverse): Remove trailing newlines from
6628         help.
6629         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6630         from help.
6631         * language.c (add_set_language_command): Remove trailing newline
6632         from help.
6633         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6634         help.
6635         * disasm.c (_initialize_disasm): Remove trailing newline from
6636         help.
6637         * top.c (init_main): Remove trailing newline from help.
6638         * interps.c (_initialize_interpreter): Remove trailing newline
6639         from help.
6640         * btrace.c (_initialize_btrace): Remove trailing newlines from
6641         help.
6642         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6643         from help.
6644         * python/python.c (_initialize_python): Remove trailing newline
6645         from help.
6646         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6647         help.
6648         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6649         from help.  Reformat some text.
6650         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6651         from help.
6652         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6653         newline from help.
6654
6655 2019-06-11  Tom Tromey  <tromey@adacore.com>
6656
6657         * darwin-nat.c (darwin_decode_exception_message)
6658         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6659
6660 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * valops.c (value_slice): Check for not allocated or not
6663         associated values.
6664
6665 2019-06-10  Tom de Vries  <tdevries@suse.de>
6666
6667         PR gdb/24618
6668         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6669         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6670         invalid.
6671
6672 2019-06-10  Tom de Vries  <tdevries@suse.de>
6673
6674         PR gdb/24611
6675         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6676         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6677
6678 2019-06-10  Tom de Vries  <tdevries@suse.de>
6679
6680         PR symtab/24545
6681         * symtab.c (struct demangled_name_entry): Add language field.
6682         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6683         static minimal symbol".  Set and use language field.
6684
6685 2019-06-10  Tom Tromey  <tromey@adacore.com>
6686
6687         * ada-lang.c (_initialize_ada_language): Update help text.
6688
6689 2019-06-10  Tom Tromey  <tromey@adacore.com>
6690
6691         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6692         with a newline.
6693         * guile/guile.c (handle_boot_error): Don't end warning with a
6694         newline.
6695         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6696         warning with a newline.
6697         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6698         newline.
6699         (s12z_frame_cache): Likewise.
6700         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6701         a newline.
6702         * solib-svr4.c (disable_probes_interface): Don't end warning with
6703         a newline.
6704         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6705         newline.
6706         * python/python.c (do_finish_initialization): Don't end warning
6707         with a newline.
6708
6709 2019-06-10  Tom Tromey  <tom@tromey.com>
6710
6711         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6712         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6713         gdbpy_enter.
6714
6715 2019-06-10  Tom Tromey  <tromey@adacore.com>
6716
6717         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6718         data.
6719         (elf_new_init): Don't call stabsread_new_init.
6720         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6721         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6722         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6723
6724 2019-06-10  Tom de Vries  <tdevries@suse.de>
6725
6726         PR symtab/16264
6727         PR symtab/24517
6728         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6729
6730 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6731
6732         * source.c (find_and_open_source): Also rewrite relative file
6733         names.
6734
6735 2019-04-26  Amos Bird  <amosbird@gmail.com>
6736
6737         * annotate.c (annotate_thread_exited): Add "thread-exited"
6738         annotation.
6739
6740 2019-06-06  Tom Tromey  <tromey@adacore.com>
6741
6742         * maint.h (class scoped_command_stats): Use
6743         DISABLE_COPY_AND_ASSIGN.
6744         <print_time>: New method.
6745         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6746         print_time.
6747         (scoped_command_stats::print_time): New method.
6748
6749 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6752         instructions of lengths 6 or 8 bytes.
6753
6754 2019-06-04  Pedro Alves  <palves@redhat.com>
6755
6756         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6757
6758         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6759         * breakpoint.c (condition_completer): Likewise.
6760         * cli/cli-dump.c (scan_expression): Likewise.
6761         * common/filestuff.c (mkdir_recursive): Likewise.
6762         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6763         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6764         (gdb_abspath): Likewise.
6765         * compile/compile-cplus-types.c
6766         (compile_cplus_instance::decl_name): Likewise.
6767         * completer.c (complete_explicit_location):
6768         (signal_completer, reg_or_group_completer_1): Likewise.
6769         * cp-support.c (cp_remove_params_if_any): Likewise.
6770         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6771         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6772         * infcmd.c (strip_bg_char): Likewise.
6773         * linespec.c (copy_token_string): Likewise.
6774         * mi/mi-main.c (output_cores): Likewise.
6775         * psymtab.c (psymtab_search_name):
6776         * symfile.c (test_set_ext_lang_command): Likewise.
6777         * target.c (target_fileio_read_stralloc): Likewise.
6778         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6779         * value.c (complete_internalvar): Likewise.
6780
6781 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6782
6783         Add objfile property to gdb.Type.
6784         * NEWS: Mention Python API addition.
6785         * python/py-type.c (typy_get_objfile): New method.
6786
6787 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6788
6789         * NEWS: Mention the new set|show style [title|highlight].
6790         Mention changes to "show style", "help" and "apropos".
6791
6792 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6793
6794         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6795         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6796         instead of print_help_for_command.
6797         (print_doc_of_command): New function.
6798         (help_list): Add 'apropos -v word' suggestion.
6799         (print_help_for_command): Style the command name using title style.
6800         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6801         (_initialize_cli_cmds): Describe -v in apropos_command help.
6802
6803 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6804
6805         * cli/cli-style.h (cli_style_option): Add name in constructor,
6806         add m_name class member, add constructor with intensity,
6807         add name class function.
6808         (cli_style_option::add_setshow_commands): Remove name argument.
6809         (highlight_style, title_style): New styles.
6810         * cli/cli-style.c (do_show): New function that shows a style
6811         characteristic styling the style name with itself.
6812         (set_style_name): New function.
6813         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6814         Update all callers according to the changes in cli/cli-style.h.
6815         * utils.h (fputs_highlighted): New function.
6816         * utils.c (fputs_highlighted): Likewise.
6817
6818 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6819
6820         * NEWS: Mention new pipe command and new convenience variables.
6821
6822 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6823
6824         * cli/cli-cmds.c (pipe_command): New function.
6825         (_initialize_cli_cmds): Call add_com for pipe_command.
6826         Define | as an alias for pipe.
6827         (exit_status_set_internal_vars): New function.
6828         (shell_escape): Call exit_status_set_internal_vars.
6829         cli/cli-decode.c (find_command_name_length): Recognize | as
6830         a single character command.
6831
6832 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6833
6834         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6835         top.c (execute_command_to_ui_file): New function, mostly a copy
6836         of execute_command_to_string.
6837         (execute_command_to_string): Implement by calling
6838         execute_command_to_ui_file.
6839
6840 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6841
6842         * top.h (saved_command_line): Remove declaration.
6843         * top.c (previous_saved_command_line, previous_repeat_arguments):
6844         New variables.
6845         (saved_command_line): Make static, define together with other
6846         'repeat variables'.
6847         (dont_repeat): Clear repeat_arguments.
6848         (repeat_previous, get_saved_command_line, save_command_line):
6849         New functions.
6850         (gdb_init): Initialize saved_command_line
6851         and previous_saved_command_line.
6852         * main.c (captured_main_1): Remove saved_command_line initialization.
6853         * event-top.c (handle_line_of_input): Update to use
6854         the new 'repeat' related functions instead of direct access to
6855         saved_command_line.
6856         * command.h (repeat_previous, get_saved_command_line,
6857         save_command_line): New declarations.
6858         (dont_repeat): Add comment.
6859
6860 2019-05-30  Tom Tromey  <tromey@adacore.com>
6861
6862         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6863         Fix comment.
6864         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6865
6866 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6867
6868         PR cli/24587
6869         * completer.c (complete): Initialize variable word.
6870
6871 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6872
6873         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6874         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6875         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6876         'body' is NULL to the outter 'if', protecting the '!is_define'
6877         situation as well.
6878
6879 2019-05-29  Tom Tromey  <tromey@adacore.com>
6880
6881         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6882         (dwarf_unknown): New function.
6883         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6884         (dwarf_type_encoding_name): Use dwarf_unknown.
6885
6886 2019-05-29  Tom Tromey  <tromey@adacore.com>
6887
6888         PR c++/20020:
6889         * cp-valprint.c (cp_print_value_fields): Call
6890         cp_print_static_field inside "try".
6891
6892 2019-05-29  Tom Tromey  <tromey@adacore.com>
6893
6894         * inflow.c (struct terminal_info): Add default operator=.
6895         * configure: Rebuild.
6896         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6897         -Wdeprecated-copy-dtor, -Wredundant-move.
6898
6899 2019-05-29  Tom Tromey  <tromey@adacore.com>
6900
6901         * NEWS: Add entry.
6902         * infcmd.c (print_return_value_1): Handle finish_print
6903         option.
6904         (show_print_finish): New function.
6905         (_initialize_infcmd): Add "set/show print finish" commands.
6906         * valprint.c (user_print_options): Initialize new member.
6907         * valprint.h (struct value_print_options) <finish_print>: New
6908         member.
6909
6910 2019-05-28  Tom Tromey  <tromey@adacore.com>
6911
6912         * ada-lang.c (ada_remove_Xbn_suffix)
6913         (find_old_style_renaming_symbol)
6914         (parse_old_style_renaming): Remove.
6915         (ada_find_renaming_symbol): Don't call
6916         find_old_style_renaming_symbol.
6917         (ada_is_renaming_symbol): Rename from
6918         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6919         bool.  Now static.
6920         (ada_read_var_value): Update and simplify.
6921         * ada-exp.y (write_var_or_type): Remove old code.
6922
6923 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6924
6925         PR gdb/25010
6926         * event-top.c: Remove include comment.
6927         * inflow.c (class scoped_ignore_sigttou): Move from here...
6928         * inflow.h (class scoped_ignore_sigttou): ...to here.
6929         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6930         * top.c:  Remove include comment.
6931
6932 2019-05-27  Tom Tromey  <tom@tromey.com>
6933
6934         * NEWS: Fix typo.
6935
6936 2019-05-22  Tom Tromey  <tromey@adacore.com>
6937
6938         * target.c (target_follow_exec): Constify parameter.
6939         * target-delegates.c: Rebuild.
6940         * remote.c (remote_target::follow_exec): Constify parameter.
6941         * infrun.c (follow_exec): Constify parameter.
6942         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6943         (target_follow_exec): Likewise.
6944
6945 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6946
6947         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6948         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6949
6950 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6951
6952         * NEWS: Add debugredirect and testsuite sections.
6953
6954 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6955
6956         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6957         target descriptions using exclusively floating point register name
6958         aliases.
6959
6960 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6961
6962         PR gdb/18644:
6963         * f-lang.c (build_fortran_types): Handle the case where
6964         gdbarch_floatformat_for_type returns a nullptr.
6965
6966 2019-05-21  Tom de Vries  <tdevries@suse.de>
6967
6968         PR cli/24587
6969         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6970
6971 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6972
6973         PR gdb/18644:
6974         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6975         16-byte floats.
6976         * i386-tdep.c (i386_floatformat_for_type): Use
6977         floatformats_ia64_quad for the 16-byte floating point component
6978         within a fortran 32-byte complex number.
6979
6980 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6981
6982         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6983         delete default constructor.
6984         (find_partial_die): Update to return const struct.
6985         (partial_die_parent_scope): Move variable declaration into scope
6986         of its use and change its type to auto.
6987         (guess_partial_die_structure_name): Likewise.
6988         (partial_die_info::fixup): Likewise.
6989
6990 2019-05-17  Tom Tromey  <tromey@adacore.com>
6991
6992         * source.c (find_and_open_source): Remove cast.
6993
6994 2019-05-17  Tom Tromey  <tromey@adacore.com>
6995
6996         * annotate.c (annotate_source): Make "filename" const.
6997         * annotate.h (annotate_source): Use const.
6998
6999 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7000
7001         * disasm.c (set_disassembler_options): Send errors to stderr.
7002
7003 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7004
7005         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7006         (cli_interp_base::set_logging): Check debug_redirect.
7007         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7008         * cli/cli-logging.c (debug_redirect): Add static variable.
7009         (pop_output_files): Add default param.
7010         (handle_redirections): Print debug setting.
7011         (show_logging_command): Likewise.
7012         (_initialize_cli_logging): Add debugredirect command.
7013         * interps.c (current_interp_set_logging): Add debug_redirect
7014         parameter.
7015         * interps.h (set_logging): Add debug_redirect parameter.
7016         (current_interp_set_logging): Likewise.
7017         * mi/mi-common.h: Likewise.
7018         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7019
7020 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7021             Tom Tromey  <tromey@adacore.com>
7022
7023         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7024         directly.
7025         * cli/cli-interp.h (make_logging_output): Remove declaration.
7026         * cli/cli-logging.c (make_logging_output): Remove function.
7027         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7028         directly.
7029         * ui-file.c (tee_file::tee_file): Remove bools.
7030         (tee_file::~tee_file): Remove deletes.
7031         * ui-file.h (tee_file): Remove bools.
7032
7033 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7034
7035         * mi/mi-cmds.h (mi_cmd_complete): New function.
7036         * mi/mi-main.c (mi_cmd_complete): Likewise.
7037         * mi/mi-cmds.c: Define new MI command -complete.
7038         * NEWS: Mention new -complete command.
7039
7040 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7041
7042         * completer.h (complete): New function.
7043         * completer.c (complete): Likewise.
7044         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7045         function defined in completer.h.
7046
7047 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7048
7049         * MAINTAINERS (Write After Approval): Add myself.
7050
7051 2019-05-17  Tom de Vries  <tdevries@suse.de>
7052
7053         PR gdb/24094
7054         * dwarf2read.c (struct cu_partial_die_info): New struct.
7055         (find_partial_die): Return cu_partial_die_info.
7056         (partial_die_parent_scope, guess_partial_die_structure_name)
7057         (partial_die_info::fixup): Handle new return type of find_partial_die.
7058
7059 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7060
7061         PR breakpoints/24541
7062         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7063         "std::string", simplifying the algorithm.
7064
7065 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7066
7067         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7068         (stap_static_probe_ops::get_probes): Likewise.
7069
7070 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7071
7072         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7073         '-')" and "else if".
7074         (stap_parse_single_operand): Join checks for
7075         "gdbarch_stap_parse_special_token_p" and
7076         "gdbarch_stap_parse_special_token" in the same "if" statement.
7077         Invert check when verifying for operation on register
7078         displacement.
7079
7080 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7081
7082         * stap-probe.c (stap_get_opcode): Update comment.
7083         (stap_get_expected_argument_type): Likewise.
7084         (handle_stap_probe): Likewise.
7085
7086 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7087
7088         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7089         return type to 'bool'.  Adjust comment.  Use 'bool' when
7090         appropriate.
7091         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7092         * stap-probe.c (stap_parse_argument_1): Likewise.
7093         (stap_is_operator): Likewise.
7094         (stap_is_generic_prefix): Likewise.
7095         (stap_is_register_prefix): Likewise.
7096         (stap_is_register_indirection_prefix): Likewise.
7097         (stap_is_integer_prefix): Likewise.
7098         (stap_generic_check_suffix): Likewise.
7099         (stap_check_integer_suffix): Likewise.
7100         (stap_check_register_suffix): Likewise.
7101         (stap_check_register_indirection_suffix): Likewise.
7102         (stap_parse_register_operand): Likewise.
7103         (stap_parse_single_operand): Likewise.
7104         (stap_parse_argument_1): Likewise.
7105         (stap_probe::get_argument_count): Likewise.
7106         (stap_is_operator): Likewise.
7107
7108 2019-05-16  Tom Tromey  <tromey@adacore.com>
7109
7110         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7111         keyword to foreach.
7112
7113 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7114
7115         * linux-thread-db.c (try_thread_db_load_1): Change return type
7116         to bool.
7117         (try_thread_db_load): Likewise.
7118         (try_thread_db_load_from_pdir_1): Likewise.
7119         (try_thread_db_load_from_pdir): Likewise.
7120         (try_thread_db_load_from_sdir): Likewise.
7121         (try_thread_db_load_from_dir): Likewise.
7122         (thread_db_load_search): Likewise.
7123         (has_libpthread): Likewise.
7124         (thread_db_load): Likewise.
7125
7126 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7127
7128         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7129         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7130         NULL, and complain/return if that's the case.
7131
7132 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7133
7134         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7135         (advance, posn, abstract_read_memory): New functions.
7136         [struct mem_read_abstraction]: New struct.
7137         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7138
7139 2019-05-14  Tom Tromey  <tromey@adacore.com>
7140
7141         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7142         value is not lval_memory.
7143
7144 2019-05-14  Tom Tromey  <tromey@adacore.com>
7145
7146         * solib.c (info_sharedlibrary_command): Style the file name.
7147
7148 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7149
7150         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7151         (aarch64_vnv_type): Likewise.
7152         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7153         * common/tdesc.c: Likewise.
7154         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7155         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7156         * features/aarch64-fpu.xml: Add ieee half view.
7157         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7158         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7159         * gdbtypes.h (struct builtin_type): Likewise.
7160         (struct objfile_type): Likewise.
7161
7162 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7163
7164         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7165         typo.
7166         * location.h (string_to_event_location): Likewise.
7167
7168 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7169
7170         GDB 8.3 released.
7171
7172 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7173
7174         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7175         New variable declaration.
7176         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7177         New variable.
7178         (print_one_breakpoint): Use ui_out::test_flags and new global
7179         variable to compute use_fixed_output.
7180         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7181         Remove.
7182         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7183         (mi_multi_location_breakpoint_output_fixed): Remove.
7184         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7185         new variable.
7186         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7187         fix_multi_location_breakpoint_output flag if version >= 3.
7188         * ui-out.h (enum ui_out_flag)
7189         <fix_multi_location_breakpoint_output>: New enumerator.
7190
7191 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7192
7193         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7194
7195 2019-05-10  Tom Tromey  <tromey@adacore.com>
7196
7197         * ada-lang.c (catch_ada_completer): New function.
7198         (_initialize_ada_language): Use it.
7199
7200 2019-05-10  Tom Tromey  <tromey@adacore.com>
7201
7202         * thread.c (print_thread_info): Make "requested_threads" const.
7203         * gdbthread.h (print_thread_info): Make "requested_threads"
7204         const.
7205         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7206         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7207
7208 2019-05-08  Tom Tromey  <tom@tromey.com>
7209
7210         * gdbtypes.c (objfile_type_data): Change type.
7211         (objfile_type, _initialize_gdbtypes): Update.
7212
7213 2019-05-08  Tom Tromey  <tom@tromey.com>
7214
7215         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7216         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7217         (_initialize_dwarf2_frame): Update.
7218
7219 2019-05-08  Tom Tromey  <tom@tromey.com>
7220
7221         * objc-lang.c (objc_objfile_data): Change type.
7222         (find_methods): Update.
7223         (_initialize_objc_lang): Remove.
7224
7225 2019-05-08  Tom Tromey  <tom@tromey.com>
7226
7227         * stabsread.c (rs6000_builtin_type_data): Change type.
7228         (rs6000_builtin_type, _initialize_stabsread): Update.
7229
7230 2019-05-08  Tom Tromey  <tom@tromey.com>
7231
7232         * mips-tdep.c (mips_pdr_data): Remove.
7233         (_initialize_mips_tdep): Update.
7234
7235 2019-05-08  Tom Tromey  <tom@tromey.com>
7236
7237         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7238         (hppa_init_objfile_priv_data, read_unwind_info)
7239         (find_unwind_entry, _initialize_hppa_tdep): Update.
7240
7241 2019-05-08  Tom Tromey  <tom@tromey.com>
7242
7243         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7244         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7245         on obstack.
7246         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7247
7248 2019-05-08  Tom Tromey  <tom@tromey.com>
7249
7250         * mdebugread.c (basic_type_data): Change type.
7251         (basic_type, _initialize_mdebugread): Update.
7252
7253 2019-05-08  Tom Tromey  <tom@tromey.com>
7254
7255         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7256
7257 2019-05-08  Tom Tromey  <tom@tromey.com>
7258
7259         * nto-tdep.c (nto_inferior_data_reg): Change type.
7260         (nto_inferior_data): Update.
7261         (nto_inferior_data_cleanup, nto_new_inferior_data)
7262         (_initialize_nto_tdep): Remove.
7263         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7264
7265 2019-05-08  Tom Tromey  <tom@tromey.com>
7266
7267         * ada-lang.c (struct ada_inferior_data): Add initializers.
7268         (ada_inferior_data): Change type.
7269         (ada_inferior_data_cleanup): Remove.
7270         (get_ada_inferior_data, ada_inferior_exit)
7271         (struct ada_pspace_data): Add initializers, destructor.
7272         (ada_pspace_data_handle): Change type.
7273         (get_ada_pspace_data): Update.
7274         (ada_pspace_data_cleanup): Remove.
7275
7276 2019-05-08  Tom Tromey  <tom@tromey.com>
7277
7278         * coffread.c (struct coff_symfile_info): Add initializers.
7279         (coff_objfile_data_key): Move lower.  Change type.
7280         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7281         Update.
7282         (coff_free_info): Remove.
7283
7284 2019-05-08  Tom Tromey  <tom@tromey.com>
7285
7286         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7287         (fbsd_pspace_data_handle): Move lower.  Change type.
7288         (get_fbsd_pspace_data): Update.
7289         (fbsd_pspace_data_cleanup): Remove.
7290         (_initialize_fbsd_tdep): Update.
7291
7292 2019-05-08  Tom Tromey  <tom@tromey.com>
7293
7294         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7295         (get_ada_tasks_pspace_data): Update.
7296         (ada_tasks_pspace_data_cleanup): Remove.
7297         (_initialize_tasks): Update.
7298         (ada_tasks_inferior_data_handle): Change type.
7299         (get_ada_tasks_inferior_data): Update.
7300         (ada_tasks_inferior_data_cleanup): Remove.
7301         (struct ada_tasks_pspace_data): Add initializers.
7302
7303 2019-05-08  Tom Tromey  <tom@tromey.com>
7304
7305         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7306         * symfile-debug.c (debug_sym_get_probes): Change type.
7307         * stap-probe.c (handle_stap_probe):
7308         (stap_static_probe_ops::get_probes): Change type.
7309         * probe.h (class static_probe_ops) <get_probes>: Change type.
7310         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7311         (parse_probes_in_pspace): Update.
7312         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7313         Update.
7314         (any_static_probe_ops::get_probes): Change type.
7315         * elfread.c (elfread_data): New typedef.
7316         (probe_key): Change type.
7317         (elf_get_probes): Likewise.  Update.
7318         (probe_key_free): Remove.
7319         (_initialize_elfread): Update.
7320         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7321         Change type.
7322         (dtrace_process_dof_probe, dtrace_process_dof)
7323         (dtrace_static_probe_ops::get_probe): Change type.
7324
7325 2019-05-08  Tom Tromey  <tom@tromey.com>
7326
7327         * xcoffread.c (struct xcoff_symfile_info): Rename from
7328         coff_symfile_info.  Add initializers.
7329         (xcoff_objfile_data_key): Move lower.  Change type.
7330         (XCOFF_DATA): Rewrite.
7331         (xcoff_free_info): Remove.
7332         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7333         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7334         (xcoff_initial_scan): Update.
7335
7336 2019-05-08  Tom Tromey  <tom@tromey.com>
7337
7338         * solib-svr4.c (struct svr4_info): Add initializers and
7339         destructor.
7340         <probes_table>: Now an htab_up.
7341         (solib_svr4_pspace_data): Change type.
7342         (free_probes_table): Simplify.
7343         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7344         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7345         (probes_table_remove_objfile_probes, register_solib_event_probe)
7346         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7347         (_initialize_svr4_solib): Update.
7348
7349 2019-05-08  Tom Tromey  <tom@tromey.com>
7350
7351         * remote.c (remote_pspace_data): Change type.
7352         (remote_pspace_data_cleanup): Remove.
7353         (get_remote_exec_file, set_pspace_remote_exec_file)
7354         (_initialize_remote): Update.
7355
7356 2019-05-08  Tom Tromey  <tom@tromey.com>
7357
7358         * breakpoint.c (breakpoint_objfile_key): Change type.
7359         (get_breakpoint_objfile_data): Update.
7360         (free_breakpoint_objfile_data): Remove.
7361         (_initialize_breakpoint): Update.
7362
7363 2019-05-08  Tom Tromey  <tom@tromey.com>
7364
7365         * linux-tdep.c (struct linux_info): Add initializers.
7366         (linux_inferior_data): Move.  Change type.
7367         (invalidate_linux_cache_inf): Update.
7368         (linux_inferior_data_cleanup): Remove.
7369         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7370
7371 2019-05-08  Tom Tromey  <tom@tromey.com>
7372
7373         * auxv.c (auxv_inferior_data): Move.  Change type.
7374         (auxv_inferior_data_cleanup): Remove.
7375         (invalidate_auxv_cache_inf): Rewrite.
7376         (get_auxv_inferior_data, _initialize_auxv): Update.
7377
7378 2019-05-08  Tom Tromey  <tom@tromey.com>
7379
7380         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7381         (symfile_debug_objfile_data_key): Change type.
7382         (symfile_debug_installed, debug_qf_has_symbols)
7383         (debug_qf_find_last_source_symtab)
7384         (debug_qf_forget_cached_source_info)
7385         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7386         (debug_qf_print_stats, debug_qf_dump)
7387         (debug_qf_expand_symtabs_for_function)
7388         (debug_qf_expand_all_symtabs)
7389         (debug_qf_expand_symtabs_with_fullname)
7390         (debug_qf_map_matching_symbols)
7391         (debug_qf_expand_symtabs_matching)
7392         (debug_qf_find_pc_sect_compunit_symtab)
7393         (debug_qf_map_symbol_filenames)
7394         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7395         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7396         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7397         (debug_sym_read_linetable, debug_sym_relocate): Update.
7398         (symfile_debug_free_objfile): Remove.
7399         (install_symfile_debug_logging, _initialize_symfile_debug):
7400         Update.
7401
7402 2019-05-08  Tom Tromey  <tom@tromey.com>
7403
7404         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7405         allocate_on_obstack.
7406         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7407         (get_dwarf2_per_objfile): Update.
7408         (set_dwarf2_per_objfile): Remove.
7409         (dwarf2_has_info, dwarf2_get_section_info): Update.
7410         (dwarf2_free_objfile): Remove.
7411         (_initialize_dwarf2_read): Update.
7412
7413 2019-05-08  Tom Tromey  <tom@tromey.com>
7414
7415         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7416         initializers.
7417         <unsupported_script_warning_printed,
7418         script_not_found_warning_printed>: Now bool.
7419         (auto_load_pspace_data): Change type.
7420         (~auto_load_pspace_info): Rename from
7421         auto_load_pspace_data_cleanup.
7422         (get_auto_load_pspace_data, init_loaded_scripts_info)
7423         (clear_section_scripts, maybe_print_unsupported_script_warning)
7424         (maybe_print_script_not_found_warning, _initialize_auto_load):
7425         Update.
7426
7427 2019-05-08  Tom Tromey  <tom@tromey.com>
7428
7429         * objfiles.c (objfile_pspace_info): Add destructor and
7430         initializers.
7431         (objfiles_pspace_data): Change type.
7432         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7433         (get_objfile_pspace_data): Update.
7434         (objfiles_bfd_data): Change type.
7435         (get_objfile_bfd_data): Update.
7436         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7437
7438 2019-05-08  Tom Tromey  <tom@tromey.com>
7439
7440         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7441         Change type.
7442         (get_catch_syscall_inferior_data): Update.
7443         (catch_syscall_inferior_data_cleanup): Remove.
7444         (_initialize_break_catch_syscall): Update.
7445
7446 2019-05-08  Tom Tromey  <tom@tromey.com>
7447
7448         * inflow.c (struct terminal_info): Add destructor and
7449         initializers.
7450         (inflow_inferior_data): Change type.
7451         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7452         (get_inflow_inferior_data, inflow_inferior_exit)
7453         (swap_terminal_info, _initialize_inflow): Update.
7454
7455 2019-05-08  Tom Tromey  <tom@tromey.com>
7456
7457         * target-dcache.c (target_dcache_cleanup): Remove.
7458         (target_dcache_aspace_key): Change type.
7459         (target_dcache_init_p, target_dcache_invalidate)
7460         (target_dcache_get, target_dcache_get_or_init)
7461         (_initialize_target_dcache): Update.
7462         * dcache.h (struct dcache_deleter): New.
7463
7464 2019-05-08  Tom Tromey  <tom@tromey.com>
7465
7466         * symtab.c (struct symbol_cache): Add destructor and
7467         initializers.
7468         (symbol_cache_key): Move.  Change type.
7469         (make_symbol_cache, free_symbol_cache): Remove.
7470         (get_symbol_cache): Update.
7471         (symbol_cache_cleanup): Remove.
7472         (ALL_PSPACES, symbol_cache_flush)
7473         (maintenance_print_symbol_cache)
7474         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7475         Update.
7476
7477 2019-05-08  Tom Tromey  <tom@tromey.com>
7478
7479         * symtab.c (struct main_info): Add destructor and initializers.
7480         (main_progspace_key): Move.  Change type.
7481         (get_main_info): Update.
7482         (main_info_cleanup): Remove.
7483         (_initialize_symtab): Update.
7484
7485 2019-05-08  Tom Tromey  <tom@tromey.com>
7486
7487         * registry.h (DECLARE_REGISTRY): Define the _key class.
7488
7489 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7490
7491         * NEWS: Merge two 'New commands' sections.
7492
7493 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7494
7495         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7496         parameter and use Ada language definition instead.
7497         (ada_val_print_ptr): Remove unused language parameter.
7498         (ada_val_print_num): Remove language parameter and use Ada language
7499         definition instead.
7500         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7501         parameter.
7502         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7503         parameter and use Ada language definition instead.
7504         (ada_val_print_1): Update all ada_val_print_xxx calls.
7505         Remove language parameter.
7506         (ada_val_print): Update ada_val_print_1 call.
7507
7508 2019-05-08  Tom Tromey  <tromey@adacore.com>
7509
7510         * remote.c (remote_hw_watchpoint_limit)
7511         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7512         Now static.
7513
7514 2019-05-08  Tom Tromey  <tromey@adacore.com>
7515
7516         * maint.c (_initialize_maint_cmds): Move initialization code to
7517         remote.c.
7518         (watchdog, show_watchdog): Move to remote.c.
7519         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7520         "watchdog" static.
7521         (_initialize_remote): Move initialization code from maint.c.
7522         * defs.h (watchdog): Don't declare.
7523
7524 2019-05-08  Tom Tromey  <tromey@adacore.com>
7525
7526         * tui/tui-interp.c: Include main.h.
7527         * interps.c: Include main.h.
7528         * main.h (interpreter_p): Declare.
7529         * defs.h (interpreter_p): Don't declare.
7530
7531 2019-05-08  Tom Tromey  <tromey@adacore.com>
7532
7533         * dwarf2loc.c: Include dwarf2read.h.
7534         * defs.h (read_unsigned_leb128): Don't declare.
7535         * dwarf2read.h (read_unsigned_leb128): Declare.
7536
7537 2019-05-08  Tom Tromey  <tromey@adacore.com>
7538
7539         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7540         method.
7541
7542 2019-05-08  Tom Tromey  <tromey@adacore.com>
7543
7544         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7545         when no wrap column is set.
7546
7547 2019-05-08  Tom Tromey  <tromey@adacore.com>
7548
7549         * c-lang.c (c_get_string): Handle non-C-style arrays.
7550
7551 2019-05-08  Tom Tromey  <tromey@adacore.com>
7552
7553         * typeprint.c (print_offset_data::update): Print the bit offset,
7554         not the number of bits remaining.
7555
7556 2019-05-08  Tom Tromey  <tromey@adacore.com>
7557
7558         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7559         padding at end of comment.
7560
7561 2019-05-08  Tom Tromey  <tromey@adacore.com>
7562
7563         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7564         Compare main types.
7565
7566 2019-05-06  Tom Tromey  <tom@tromey.com>
7567
7568         * common/scoped_mmap.c: Include common-defs.h.
7569         * common/scoped_mmap.h: Don't include config.h.
7570
7571 2019-05-04  Tom Tromey  <tom@tromey.com>
7572
7573         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7574         (struct aarch64_call_info): Add initializers.
7575         <si>: Now a std::vector.
7576         (pass_on_stack, aarch64_push_dummy_call): Update.
7577
7578 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7579             Tom Tromey  <tom@tromey.com>
7580
7581         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7582         (ppc_threads): Now a std::vector.  Now static.
7583         (hwdebug_find_thread_points_by_tid)
7584         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7585         Update.
7586
7587 2019-05-04  Tom Tromey  <tom@tromey.com>
7588
7589         * arc-tdep.c (arc_tdesc_init): Return bool.
7590
7591 2019-05-04  Tom Tromey  <tom@tromey.com>
7592
7593         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7594         Use gdb_assert_not_reached.
7595
7596 2019-05-04  Tom Tromey  <tom@tromey.com>
7597
7598         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7599         "false".
7600
7601 2019-05-04  Tom Tromey  <tom@tromey.com>
7602
7603         * arc-tdep.c (arc_tdesc_init): Use bool.
7604
7605 2019-05-04  Tom Tromey  <tom@tromey.com>
7606
7607         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7608
7609 2019-05-04  Tom Tromey  <tom@tromey.com>
7610
7611         * cli/cli-cmds.c (valid_command_p): Return bool.
7612
7613 2019-05-04  Tom Tromey  <tom@tromey.com>
7614
7615         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7616         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7617
7618 2019-05-04  Raul Tambre  <raul@tambre.ee>
7619
7620         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7621         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7622         operator for comparison.
7623
7624 2019-05-04  Tom Tromey  <tom@tromey.com>
7625
7626         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7627         (lookup_partial_symbol, print_partial_symbols)
7628         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7629         (psymbol_compare): Update.
7630         (add_psymbol_to_bcache): Clear the entire psymbol.
7631         (maintenance_check_psymtabs): Update.
7632         * psympriv.h (struct partial_symbol): Don't derive from
7633         general_symbol_info.
7634         <obj_section, unrelocated_address, address,
7635         set_unrelocated_address>: Update.
7636         <ginfo>: New member.
7637         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7638         (debug_names::write_psymbols): Update.
7639
7640 2019-05-04  Tom de Vries  <tdevries@suse.de>
7641
7642         * contrib/cc-with-tweaks.sh: Support -n arg.
7643
7644 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7645
7646         * corelow.c (core_target::detach): Ensure frame cache and
7647         register caches are cleared.
7648         inferior.c (exit_inferior_1): Likewise.
7649
7650 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7651             Tom Tromey  <tom@tromey.com>
7652
7653         * dictionary.c (collate_pending_symbols_by_language): Remove
7654         "struct" from foreach.
7655         * symtab.c (lookup_global_symbol_from_objfile)
7656         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7657         foreach.
7658         * ser-tcp.c (net_open): Remove "struct" from foreach.
7659         * objfiles.c (objfile_relocate, objfile_rebase)
7660         (objfile_has_symbols): Remove "struct" from foreach.
7661         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7662         from foreach.
7663         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7664         foreach.
7665         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7666         "struct" from foreach.
7667         * ada-lang.c (create_excep_cond_exprs)
7668         (ada_exception_catchpoint_cond_string): Remove "struct" from
7669         foreach.
7670
7671 2019-05-03  Tom Tromey  <tromey@adacore.com>
7672
7673         * ada-exp.y (convert_char_literal): Check suffix of each
7674         enumerator.
7675
7676 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7677
7678         PR ada/21406:
7679         * ada-exp.y (yywrap): Don't define.
7680         * ada-lex.l (%option): Add noyywrap
7681         (yywrap): Remove.
7682
7683 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7684
7685         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7686         _WIN32_WINNT to the XP level, unless already defined to a higher
7687         level.
7688
7689         * unittests/parse-connection-spec-selftests.c:
7690         * ser-tcp.c:
7691         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7692         override.
7693
7694         * symfile.c (find_separate_debug_file): Remove colon from the
7695         drive spec of DOS/Windows file names of the target, so that the
7696         file name produced from DEBUGDIR and the target's directory will
7697         be valid on DOS/Windows systems.
7698
7699 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7700
7701         * rust-lang.c (val_print_struct): Handle printing structures
7702         containing strings.
7703
7704 2019-05-02  Tom Tromey  <tromey@adacore.com>
7705
7706         * valarith.c (_initialize_valarith): Remove.
7707
7708 2019-05-01  Tom Tromey  <tromey@adacore.com>
7709
7710         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7711         bitfields.
7712
7713 2019-05-01  Tom Tromey  <tromey@adacore.com>
7714
7715         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7716         for big-endian copies.
7717
7718 2019-04-30  Ali Tamur  <tamur@google.com>
7719         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7720         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7721         (read_3_bytes): New function.
7722
7723 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7724
7725         * windows-nat.c (main_thread_id): Delete.
7726         (handle_output_debug_string): Replace main_thread_id by
7727         current_event.dwThreadId.
7728         (fake_create_process): Likewise.
7729         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7730         Do not set main_thread_id.
7731         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7732         current_event.dwThreadId.
7733         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7734
7735 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7736
7737         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7738         Use current_event.dwThreadId instead of main_thread_id.
7739
7740 2019-04-30  Tom Tromey  <tromey@adacore.com>
7741
7742         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7743         (create_excep_cond_exprs): Iterate over program spaces.
7744         (ada_exception_catchpoint_cond_string): Examine all minimal
7745         symbols for exception types.
7746
7747 2019-04-30  Tom Tromey  <tromey@adacore.com>
7748
7749         PR c++/24470:
7750         * dwarf2read.c (process_structure_scope): Handle case where type
7751         has template parameters but no symbol was created.
7752
7753 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7754             Chris January  <chris.january@arm.com>
7755
7756         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7757         qualifier.
7758         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7759
7760 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7761
7762         * f-typeprint.c (f_print_type): Update rules for printing
7763         whitespace.
7764         (f_type_print_varspec_suffix): Likewise.
7765
7766 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7767             Chris January  <chris.january@arm.com>
7768
7769         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7770         function arguments.
7771
7772 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7773
7774         * f-lang.c (build_fortran_types): Change name of void type to
7775         lower case.
7776         * f-typeprint.c (f_type_print_base): Print the name of the void
7777         type, rather than a fixed string.
7778         * f-valprint.c (f_decorations): Use lower case void string.
7779
7780 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7781             Chris January  <chris.january@arm.com>
7782
7783         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7784         types for Fortran.
7785
7786 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7787             Chris January  <chris.january@arm.com>
7788             David Lecomber  <david.lecomber@arm.com>
7789
7790         * f-exp.y (BINOP_INTRINSIC): New token.
7791         (exp): New parser rule handling BINOP_INTRINSIC.
7792         (f77_keywords): Add new builtin procedures.
7793         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7794         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7795         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7796         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7797         (print_unop_subexp_f): New function.
7798         (print_binop_subexp_f): New function.
7799         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7800         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7801         (dump_subexp_body_f): Likewise.
7802         (operator_check_f): Likewise.
7803         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7804         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7805
7806 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7807
7808         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7809         UNOP_KIND.
7810         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7811         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7812         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7813         (operator_length_f): New fuction.
7814         (print_subexp_f): New function.
7815         (op_name_f): New function.
7816         (dump_subexp_body_f): New function.
7817         (operator_check_f): New function.
7818         (exp_descriptor_f): Replace standard expression handling functions
7819         with new functions.
7820         * gdb/fortran-operator.def: New file.
7821         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7822         * gdb/std-operator.def: Remove UNOP_KIND.
7823
7824 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * std-operator.def: Remove unbalanced, stray double quote
7827         character.
7828
7829 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7830             Chris January  <chris.january@arm.com>
7831             Daniel Everett  <daniel.everett@arm.com>
7832             Nick Forrington  <nick.forrington@arm.com>
7833             Richard Bunt  <richard.bunt@arm.com>
7834
7835         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7836         of depth when printing anonymous structs or unions.
7837         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7838         Don't print either the top-level value, or the children if the
7839         max-depth is exceeded.
7840         (ppscm_print_children): When printing the key of a map, allow one
7841         extra level of depth.
7842         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7843         print either the top-level value, or the children if the max-depth
7844         is exceeded.
7845         (print_children): When printing the key of a map, allow one extra
7846         level of depth.
7847         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7848         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7849         (user_print_options): Initialise max_depth field.
7850         (val_print_scalar_or_string_type_p): New function.
7851         (val_print): Check to see if the max depth has been reached.
7852         (val_print_check_max_depth): Define new function.
7853         (show_print_max_depth): New function.
7854         (_initialize_valprint): Add 'print max-depth' option.
7855         * valprint.h (struct value_print_options) <max_depth>: New field.
7856         (val_print_check_max_depth): Declare new function.
7857         * NEWS: Document new feature.
7858
7859 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7860
7861         * ada-lang.c (ada_language_defn): Initialise new field.
7862         * c-lang.c (c_is_string_type_p): New function.
7863         (c_language_defn): Initialise new field.
7864         (cplus_language_defn): Initialise new field.
7865         (asm_language_defn): Initialise new field.
7866         (minimal_language_defn): Initialise new field.
7867         * c-lang.h (c_is_string_type_p): Declare new function.
7868         * d-lang.c (d_language_defn): Initialise new field.
7869         * f-lang.c (f_is_string_type_p): New function.
7870         (f_language_defn): Initialise new field.
7871         * go-lang.c (go_is_string_type_p): New function.
7872         (go_language_defn): Initialise new field.
7873         * language.c (default_is_string_type_p): New function.
7874         (unknown_language_defn): Initialise new field.
7875         (auto_language_defn): Initialise new field.
7876         * language.h (struct language_defn) <la_is_string_type_p>: New
7877         member variable.
7878         (default_is_string_type_p): Declare new function.
7879         * m2-lang.c (m2_language_defn): Initialise new field.
7880         * objc-lang.c (objc_language_defn): Initialise new field.
7881         * opencl-lang.c (opencl_language_defn): Initialise new field.
7882         * p-lang.c (pascal_is_string_type_p): New function.
7883         (pascal_language_defn): Initialise new field.
7884         * rust-lang.c (rust_is_string_type_p): New function.
7885         (rust_language_defn): Initialise new field.
7886
7887 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7888
7889         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7890         New field.
7891         * ada-lang.c (ada_language_defn): Initialise new field.
7892         * c-lang.c (c_language_defn): Likewise.
7893         (cplus_language_defn): Likewise.
7894         (asm_language_defn): Likewise.
7895         (minimal_language_defn): Likewise.
7896         * d-lang.c (d_language_defn): Likewise.
7897         * f-lang.c (f_language_defn): Likewise.
7898         * go-lang.c (go_language_defn): Likewise.
7899         * language.c (unknown_language_defn): Likewise.
7900         (auto_language_defn): Likewise.
7901         * m2-lang.c (m2_language_defn): Likewise.
7902         * objc-lang.c (objc_language_defn): Likewise.
7903         * opencl-lang.c (opencl_language_defn): Likewise.
7904         * p-lang.c (pascal_language_defn): Likewise.
7905         * rust-lang.c (rust_language_defn): Likewise.
7906
7907 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7908
7909         * ada-lang.c (ada_is_character_type): Change return type to bool.
7910         (ada_is_string_type): Likewise.
7911         * ada-lang.h (ada_is_character_type): Update declaration
7912         (ada_is_string_type): Likewise.
7913
7914 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7915
7916         Support style in 'frame|thread apply'
7917
7918         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7919         * record.c (record_start, record_stop): Update callers of
7920         execute_command_to_string with false.
7921         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7922         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7923         methods.
7924         (class string_file): New constructor with term_out parameter.
7925         Override methods term_out and can_emit_style_escape.  New member
7926         term_out.
7927         (class stdio_file): Override can_emit_style_escape.
7928         (class tee_file): Override term_out and can_emit_style_escape.
7929         * utils.h (can_emit_style_escape): Remove.
7930         * utils.c (can_emit_style_escape): Likewise.
7931         Update all callers of can_emit_style_escape (SOMESTREAM) to
7932         SOMESTREAM->can_emit_style_escape.
7933         * source-cache.c (source_cache::get_source_lines): Likewise.
7934         * stack.c (frame_apply_command_count): Call execute_command_to_string
7935         passing the term_out characteristic of the current gdb_stdout.
7936         * thread.c (thr_try_catch_cmd): Likewise.
7937         * top.c (execute_command_to_string): pass term_out parameter
7938         to construct the string_file for the command output.
7939         * ui-file.c (term_cli_styling): New function (most code moved
7940         from utils.c can_emit_style_escape).
7941         (string_file::string_file, string_file::can_emit_style_escape,
7942         stdio_file::can_emit_style_escape, tee_file::term_out,
7943         tee_file::can_emit_style_escape): New functions.
7944
7945 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7946
7947         * NEWS: Mention the new set|show may-call-functions.
7948         * infcall.c (may_call_functions_p): New variable.
7949         (show_may_call_functions_p): New function.
7950         (call_function_by_hand_dummy): Throws an error if not
7951         may-call-functions.
7952         (_initialize_infcall): Call add_setshow_boolean_cmd for
7953         may-call-functions.
7954
7955 2019-04-25  Keith Seitz  <keiths@redhat.com>
7956
7957         PR c++/24367
7958         * cp-support.c (inspect_type): Don't attempt substitutions
7959         of symbol with the same name.
7960
7961 2019-04-25  Tom Tromey  <tromey@adacore.com>
7962
7963         PR gdb/24475:
7964         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7965         static.
7966
7967 2019-04-25  Tom Tromey  <tromey@adacore.com>
7968
7969         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7970         rvalue reference.
7971         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7972         (gdb_xml_parser::parse): Use std::move.
7973         * python/python-internal.h (gdbpy_convert_exception): Take a const
7974         reference.
7975         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7976         std::move.
7977         * python/py-utils.c (gdbpy_convert_exception): Take a const
7978         reference.
7979         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7980         Use std::move.
7981         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7982         Use std::move.
7983         * mi/mi-main.c (mi_print_exception): Take a const reference.
7984         * main.c (handle_command_errors): Take a const reference.
7985         * linespec.c (parse_linespec): Use std::move.
7986         * infcall.c (run_inferior_call): Use std::move.
7987         (call_function_by_hand_dummy): Use std::move.
7988         * exec.c (try_open_exec_file): Use std::move.
7989         * exceptions.h (exception_print, exception_fprintf)
7990         (exception_print_same): Update.
7991         * exceptions.c (print_exception, exception_print)
7992         (exception_fprintf, exception_print_same): Change parameters to
7993         const reference.
7994         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7995         * common/new-op.c: Use std::move.
7996         * common/common-exceptions.h (struct gdb_exception): Add move
7997         constructor.
7998         (struct gdb_exception_error, struct gdb_exception_quit, struct
7999         gdb_quit_bad_alloc): Change constructor to move constructor.
8000         (throw_exception): Change parameter to rvalue reference.
8001         * common/common-exceptions.c (throw_exception): Take rvalue
8002         reference.
8003         * cli/cli-interp.c (safe_execute_command): Use std::move.
8004         * breakpoint.c (insert_bp_location, location_to_sals): Use
8005         std::move.
8006
8007 2019-04-25  Tom Tromey  <tromey@adacore.com>
8008
8009         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8010         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8011         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8012         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8013         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8014         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8015         guile/scm-value.c: Use unpack.
8016         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8017         gdbscm_gdb_exception.
8018         (gdbscm_throw_gdb_exception): Likewise.
8019         (struct gdbscm_gdb_exception): New.
8020         (unpack): New function.
8021         (gdbscm_wrap): Use unpack.
8022
8023 2019-04-25  Tom Tromey  <tromey@adacore.com>
8024
8025         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8026         (gdb_rl_callback_handler): Use std::move.
8027         * common/common-exceptions.h (struct gdb_exception): Add move
8028         assignment operator.
8029         (throw_exception_sjlj): Change "exception" to const reference.
8030         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8031         (throw_exception_sjlj): Change "exception" to const reference.
8032
8033 2019-04-25  Tom Tromey  <tromey@adacore.com>
8034
8035         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8036         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8037         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8038         Update.
8039         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8040         Update.
8041         * mi/mi-interp.c (mi_interp::exec): Update.
8042         * linespec.c (parse_linespec): Update.
8043         * infcall.c (run_inferior_call): Update.
8044         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8045         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8046         (gdbscm_lookup_global_symbol): Update.
8047         * guile/scm-param.c (gdbscm_parameter_value): Update.
8048         * guile/scm-frame.c (gdbscm_frame_read_register)
8049         (gdbscm_frame_read_var): Update.
8050         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8051         * exec.c (try_open_exec_file): Update.
8052         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8053         (gdb_rl_callback_handler): Update.
8054         * common/common-exceptions.h (exception_none): Don't declare.
8055         * common/common-exceptions.c (exception_none): Don't define.
8056         (struct catcher) <exception>: Update.
8057         * cli/cli-interp.c (safe_execute_command): Update.
8058         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8059
8060 2019-04-25  Ali Tamur  <tamur@google.com>
8061
8062         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8063         (read_attribute_value): Likewise.
8064         (dwarf2_read_addr_index): Update comment.
8065         (read_str_index): Add DW_FORM_strx.
8066         (dwarf2_string_attr): Likewise.
8067         (dwarf2_const_value_attr): Likewise.
8068         (dump_die_shallow): Likewise.
8069         (dwarf2_fetch_constant_bytes): Likewise.
8070         (skip_form_bytes): Likewise.
8071         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8072
8073 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8074
8075         PR corefiles/11608
8076         PR corefiles/18187
8077         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8078         OFFSET.  Verify if current mapping contains an ELF header.
8079         (linux_find_memory_regions_full): Adjust call to
8080         dump_mapping_p.
8081
8082 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8083             Kang Li <kanglictf@gmail.com>
8084
8085         PR gdb/21600
8086
8087         * dwarf2-frame.c (read_initial_length): Be consistent about using
8088         unsigned representation of length.
8089         (decode_frame_entry_1): Likewise.  Check for wraparound of
8090         end pointer as well as buffer overflow.
8091
8092 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8093
8094         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8095         "vq".
8096
8097 2019-04-24  Tom Tromey  <tromey@adacore.com>
8098
8099         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8100
8101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8102
8103         * s12z-tdep.c (s12z_unwind_pc): Delete.
8104         (s12z_unwind_sp): Delete.
8105         (s12z_gdbarch_init): Don't register deleted functions with
8106         gdbarch.
8107
8108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8109
8110         * rl78-tdep.c (rl78_unwind_sp): Delete.
8111         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8112
8113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8114
8115         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8116         (xstormy16_unwind_pc): Delete.
8117         (xstormy16_dummy_id): Delete.
8118         (xstormy16_gdbarch_init): Don't register deleted functions with
8119         gdbarch.
8120
8121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8122
8123         * vax-tdep.c (vax_unwind_pc): Delete.
8124         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8125
8126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8127
8128         * v850-tdep.c (v850_unwind_sp): Delete.
8129         (v850_unwind_pc): Delete.
8130         (v850_dummy_id): Delete.
8131         (v850_gdbarch_init): Don't register deleted functions with
8132         gdbarch.
8133
8134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8137         (tilegx_unwind_pc): Delete.
8138         (tilegx_unwind_dummy_id): Delete.
8139         (tilegx_gdbarch_init): Don't register deleted functions with
8140         gdbarch.
8141
8142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8143
8144         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8145         (tic6x_dummy_id): Delete.
8146         (tic6x_gdbarch_init): Don't register deleted functions with
8147         gdbarch.
8148
8149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8150
8151         * sparc-tdep.c (sparc_unwind_pc): Delete.
8152         (sparc32_gdbarch_init): Don't register deleted function with
8153         gdbarch.
8154
8155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8156
8157         * sh-tdep.c (sh_unwind_sp): Delete.
8158         (sh_unwind_pc): Delete.
8159         (sh_dummy_id): Delete.
8160         (sh_gdbarch_init): Don't register deleted functions with
8161         gdbarch.
8162
8163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8164
8165         * score-tdep.c (score_unwind_sp): Delete.
8166         (score_unwind_pc): Delete.
8167         (score_dummy_id): Delete.
8168         (score_gdbarch_init): Don't register deleted functions with
8169         gdbarch.
8170
8171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * rx-tdep.c (rx_unwind_pc): Delete.
8174         (rx_unwind_sp): Delete.
8175         (rx_dummy_id): Delete.
8176         (rx_gdbarch_init): Don't register deleted functions with
8177         gdbarch.  Update comment.
8178
8179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8180
8181         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8182         (rs6000_dummy_id): Delete.
8183         (rs6000_gdbarch_init): Don't register deleted functions with
8184         gdbarch.
8185
8186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8187
8188         * or1k-tdep.c (or1k_dummy_id): Delete.
8189         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8190
8191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8192
8193         * nios2-tdep.c (nios2_dummy_id): Delete.
8194         (nios2_unwind_sp): Delete.
8195         (nios2_gdbarch_init): Don't register deleted functions with
8196         gdbarch.
8197
8198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8199
8200         * nds32-tdep.c (nds32_dummy_id): Delete.
8201         (nds32_unwind_pc): Delete.
8202         (nds32_unwind_sp): Delete.
8203         (nds32_gdbarch_init): Don't register deleted functions with
8204         gdbarch.
8205
8206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8207
8208         * msp430-tdep.c (msp430_unwind_pc): Delete.
8209         (msp430_unwind_sp): Delete.
8210         (msp430_dummy_id): Delete.
8211         (msp430_gdbarch_init): Don't register deleted functions with
8212         gdbarch.
8213
8214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8215
8216         * moxie-tdep.c (moxie_unwind_sp): Delete.
8217         (moxie_unwind_pc): Delete.
8218         (moxie_dummy_id): Delete.
8219         (moxie_gdbarch_init): Don't register deleted functions with
8220         gdbarch.
8221
8222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8223
8224         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8225         (mn10300_unwind_pc): Delete.
8226         (mn10300_unwind_sp): Delete.
8227         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8228         mn10300_unwind_sp.
8229         (mn10300_frame_unwind_init): Don't register deleted functions with
8230         gdbarch.
8231
8232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8233
8234         * mep-tdep.c (mep_unwind_pc): Delete.
8235         (mep_unwind_sp): Delete.
8236         (mep_dummy_id): Delete.
8237         (mep_gdbarch_init): Don't register deleted functions with
8238         gdbarch.
8239
8240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8241
8242         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8243         (m68hc11_unwind_sp): Delete.
8244         (m68hc11_gdbarch_init): Don't register deleted functions with
8245         gdbarch.
8246
8247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8248
8249         * m32r-tdep.c (m32r_unwind_sp): Delete.
8250         (m32r_unwind_pc): Delete.
8251         (m32r_dummy_id): Delete.
8252         (m32r_gdbarch_init): Don't register deleted functions with
8253         gdbarch.
8254
8255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * m32c-tdep.c (m32c_unwind_pc): Delete.
8258         (m32c_unwind_sp): Delete.
8259         (m32c_dummy_id): Delete.
8260         (m32c_gdbarch_init): Don't register deleted functions with
8261         gdbarch.
8262
8263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8264
8265         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8266         (lm32_unwind_pc): Delete.
8267         (lm32_dummy_id): Delete.
8268         (lm32_gdbarch_init): Don't register deleted functions with
8269         gdbarch.
8270
8271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8272
8273         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8274         (iq2000_unwind_pc): Delete.
8275         (iq2000_dummy_id): Delete.
8276         (iq2000_gdbarch_init): Don't register deleted functions with
8277         gdbarch.
8278
8279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8280
8281         * nds32-tdep.c (nds32_type_align): Delete.
8282         (nds32_push_dummy_call): Use type_align instead.
8283
8284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8285
8286         * arm-tdep.c (arm_type_align): Only handle vector override case.
8287         (arm_push_dummy_call): Use type_align.
8288         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8289
8290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8291
8292         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8293         case.
8294         (pass_on_stack): Use type_align.
8295         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8296         function.
8297
8298 2019-04-23  Tom Tromey  <tromey@adacore.com>
8299
8300         * dwarf2read.c (line_header::file_name_at): Remove unused
8301         overload.
8302
8303 2019-04-23  Tom de Vries  <tdevries@suse.de>
8304
8305         PR gdb/24438
8306         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8307         invocation.
8308
8309
8310 2019-03-27  Ali Tamur  <tamur@google.com>
8311
8312         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8313         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8314         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8315         (dwarf_expr_context::get_addr_index): Likewise
8316         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8317         (symbol_needs_eval_context::get_addr_index): Likewise
8318         (disassemble_dwarf_expression): Add DW_OP_addrx
8319         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8320         (read_cutu_die_from_dwo): Update comment
8321         (skip_one_die): Add DW_FORM_addrx
8322         (read_attribute_value): Likewise
8323         (var_decode_location): Add DW_OP_addrx
8324         (dwarf2_const_value_attr): Add DW_FORM_addrx
8325         (dump_die_shallow): Likewise
8326         (dwarf2_fetch_constant_bytes): Likewise
8327         (decode_locdesc): Add DW_OP_addrx
8328         (skip_form_bytes): Add DW_FORM_addrx
8329
8330 2019-04-22  Ali Tamur  <tamur@google.com>
8331
8332         * MAINTAINERS (Write After Approval): Add self.
8333
8334 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8335
8336         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8337         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8338         (open_symbol_file_object): Likewise.
8339         (svr4_default_sos): Add info parameter.
8340         (svr4_read_so_list): Likewise.
8341         (svr4_current_sos_direct): Adjust functions calls to pass down
8342         info.
8343         (svr4_current_sos_1): Add info parameter.
8344         (svr4_current_sos): Call get_svr4_info, pass info down to
8345         svr4_current_sos_1.
8346         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8347         get_svr4_info.
8348         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8349         get_svr4_info.
8350         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8351         to get_svr4_info.
8352         (probes_table_remove_objfile_probes): Likewise.
8353         (register_solib_event_probe): Add info parameter.
8354         (solist_update_incremental): Pass info parameter down to
8355         svr4_read_so_list.
8356         (disable_probes_interface): Add info parameter.
8357         (svr4_handle_solib_event): Pass current_program_space to
8358         get_svr4_info.  Adjust disable_probes_interface cleanup.
8359         (svr4_create_probe_breakpoints): Add info parameter, pass it
8360         down to register_solib_event_probe.
8361         (svr4_create_solib_event_breakpoints): Add info parameter,
8362         pass it down to svr4_create_probe_breakpoints.
8363         (enable_break): Pass info down to
8364         svr4_create_solib_event_breakpoints.
8365         (svr4_solib_create_inferior_hook): Pass current_program_space to
8366         get_svr4_info.
8367         (svr4_clear_solib): Likewise.
8368
8369 2019-04-22  Pedro Alves  <palves@redhat.com>
8370
8371         * solib-svr4.c (svr4_free_objfile_observer): New.
8372         (probe_and_action::objfile): New field.
8373         (probes_table_htab_remove_objfile_probes)
8374         (probes_table_remove_objfile_probes): New functions.
8375         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8376         in the new probe_and_action.  Don't store the probe in 'lookup'.
8377         (svr4_create_probe_breakpoints): Pass objfile to
8378         register_solib_event_probe.
8379         (_initialize_svr4_solib): Register a free_objfile observer.
8380
8381 2019-04-19  Tom Tromey  <tom@tromey.com>
8382
8383         * common/queue.h: Remove.
8384
8385 2019-04-19  Tom Tromey  <tom@tromey.com>
8386
8387         * event-loop.c: Don't include "common/queue.h".
8388
8389 2019-04-19  Tom Tromey  <tom@tromey.com>
8390
8391         * remote.c (remote_target): Use delete.
8392         * remote-notif.h: Include <list>, not "common/queue.h".
8393         (notif_client_p): Remove typedef.
8394         (remote_notif_state): Add constructor, destructor, initializer.
8395         <notif_queue>: Now a std::list.
8396         (remote_notif_state_xfree): Don't declare.
8397         * remote-notif.c (remote_notif_process, handle_notification)
8398         (remote_notif_state_allocate): Update.
8399         (~remote_notif_state): Rename from remote_notif_state_xfree.
8400
8401 2019-04-19  Tom Tromey  <tom@tromey.com>
8402
8403         * symfile.c (reread_symbols): Update.
8404         * objfiles.c (objfile_register_static_link)
8405         (objfile_lookup_static_link): Update
8406         (~objfile) Don't delete static_links.
8407         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8408
8409 2019-04-19  Tom Tromey  <tom@tromey.com>
8410
8411         * type-stack.h (struct type_stack) <insert>: Constify string.
8412         * type-stack.c (type_stack::insert): Constify string.
8413         * gdbtypes.h (lookup_template_type): Update.
8414         (address_space_name_to_int): Update.
8415         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8416         const.
8417         (lookup_template_type): Make name const.
8418         * c-exp.y: Update rules.
8419         (lex_one_token, classify_name, classify_inner_name)
8420         (c_print_token): Update.
8421         * p-exp.y: Update rules.
8422         (yylex): Update.
8423         * f-exp.y: Update rules.
8424         (yylex): Update.
8425         * d-exp.y: Update rules.
8426         (lex_one_token, classify_name, classify_inner_name): Update.
8427         * parse.c (write_dollar_variable, copy_name): Return std::string.
8428         * parser-defs.h (copy_name): Change return type.
8429         * m2-exp.y: Update rules.
8430         (yylex): Update.
8431         * go-exp.y (lex_one_token): Update.
8432         Update rules.
8433         (classify_unsafe_function, classify_packaged_name)
8434         (classify_name, yylex): Update.
8435
8436 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8437
8438         * configure.ac: add --enable-source-highlight switch.
8439         * configure: Regenerate.
8440         * top.c (print_gdb_version): plumb --enable-source-highlight
8441         status to "show configuration".
8442
8443 2019-04-19  Tom Tromey  <tromey@adacore.com>
8444
8445         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8446         Check ADA_TYPE_P.
8447         (empty_record, ada_template_to_fixed_record_type_1)
8448         (template_to_static_fixed_type)
8449         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8450         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8451         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8452         macros.
8453
8454 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8455
8456         PR symtab/24423:
8457         * source.c (print_source_lines_base): Advance "iter" when a
8458         control character is seen.
8459
8460 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8461
8462         * inferior.h (struct infcall_suspend_state_deleter):
8463         Catch exception in destructor to avoid crash.
8464
8465 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8466
8467         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8468         close to the add_com "shell".
8469
8470 2019-04-18  Tom Tromey  <tromey@adacore.com>
8471
8472         * process-stratum-target.h (class process_stratum_target)
8473         <stratum>: Add "final".
8474
8475 2019-04-17  Tom Tromey  <tromey@adacore.com>
8476
8477         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8478         against nullptr before use.
8479
8480 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8481
8482         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8483
8484 2019-04-17  Jim Wilson  <jimw@sifive.com>
8485             Andrew Burgess  <andrew.burgess@embecosm.com>
8486
8487         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8488         code read might fail, assume 4-byte breakpoint in that case.
8489
8490 2019-04-15  Leszek Swirski  <leszeks@google.com>
8491
8492         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8493         rather than a hand-rolled POD check when checking for forced MEMORY
8494         classification.
8495
8496 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8497
8498         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8499         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8500         function.
8501         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8502         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8503         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8504         declaration.
8505
8506 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8507
8508         * aarch64-linux-nat.c
8509         (aarch64_linux_nat_target::thread_architecture): Add override.
8510         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8511         each VQ.
8512
8513 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8514
8515         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8516
8517 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8518
8519         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8520         target types of size 96-bits, add some additional comments, and
8521         check that the builtin type we found was the correct size.
8522
8523 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8524
8525         * utils.c (prompt_for_continue): Don't restore the styling at the
8526         end, as applied_style has the wrong value.  This fixes styling in
8527         long lists of file names that are interrupted by the "Continue?"
8528         prompt.
8529
8530 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8531
8532         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8533         * c-lang.c (c_language_defn): Likewise.
8534         (cplus_language_defn): Likewise.
8535         (asm_language_defn): Likewise.
8536         (minimal_language_defn): Likewise.
8537         * d-lang.c (d_language_defn): Likewise.
8538         * f-lang.c (f_language_defn): Likewise.
8539         * go-lang.c (go_language_defn): Likewise.
8540         * language.c (unknown_language_defn): Likewise.
8541         (auto_language_defn): Likewise.
8542         * language.h (struct language_defn): Remove la_magic field.
8543         (LANG_MAGIC): Delete.
8544         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8545         * objc-lang.c (objc_language_defn): Likewise.
8546         * opencl-lang.c (opencl_language_defn): Likewise.
8547         * p-lang.c (pascal_language_defn): Likewise.
8548         * rust-lang.c (rust_language_defn): Likewise.
8549
8550 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8551
8552         * riscv-tdep.c (riscv_type_align): New function.
8553         (riscv_type_alignment): Delete.
8554         (riscv_arg_location): Use 'type_align'.
8555         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8556
8557 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8558
8559         * gdbtypes.c (type_align): A struct with no non-static fields also
8560         has alignment of 1.
8561
8562 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8563
8564         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8565         component to 0.
8566         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8567         member.
8568         (riscv_struct_info::analyse): New implementation using new
8569         analyse_inner member function.
8570         (riscv_struct_info::field_offset): New member function.
8571         (riscv_struct_info::m_offsets): New member variable.
8572         (riscv_struct_info::analyse_inner): New private member function,
8573         takes the old implementation of riscv_struct_info::analyse but
8574         extended to track field offsets.
8575         (riscv_call_arg_struct): Update the struct folding special cases
8576         to handle cases where empty C++ structs, which are non-zero
8577         length, are found.
8578         (riscv_arg_location): Initialise the length of each location, a
8579         non-zero length now indicates the location is in use.
8580         (riscv_push_dummy_call): Allow for the first location having a
8581         non-zero offset when setting up arguments.
8582         (riscv_return_value): Likewise, but for return values.
8583
8584 2019-04-11  Tom Tromey  <tromey@adacore.com>
8585
8586         * utils.c (internal_vproblem): Make "msg" const.
8587
8588 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8589
8590         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8591         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8592         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8593         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8594
8595 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8596
8597         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8598         function.
8599         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8600         of amd64_collect_native_gregset.
8601         (amd64_linux_nat_target::store_registers): Likewise.
8602
8603 2019-04-10  Tom Tromey  <tom@tromey.com>
8604
8605         * symtab.c (lookup_global_symbol_from_objfile)
8606         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8607         * objfiles.h (class separate_debug_iterator): New.
8608         (class separate_debug_range): New.
8609         (struct objfile) <separate_debug_objfiles>: New method.
8610         (objfile_separate_debug_iterate): Don't declare.
8611         * objfiles.c (separate_debug_iterator::operator++): Rename from
8612         objfile_separate_debug_iterate.
8613         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8614         iterator.
8615         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8616         iterator.
8617
8618 2019-04-10  Tom Tromey  <tom@tromey.com>
8619
8620         * symfile.c (reread_symbols): Remove old comment.
8621         * objfiles.c (free_all_objfiles): Fix a typo.
8622
8623 2019-04-10  Tom Tromey  <tom@tromey.com>
8624
8625         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8626         * minsyms.c (lookup_minimal_symbol): Use foreach.
8627         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8628         (lookup_minimal_symbol_solib_trampoline): Likewise.
8629         * symfile.c (reread_symbols): Use foreach.
8630
8631 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8632             Tom Tromey  <tromey@adacore.com>
8633
8634         PR rust/24414:
8635         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8636         (rust_lex_int_test): Change "value" to be LONGEST.
8637         (rust_lex_tests): Add test for long integer literal.
8638
8639 2019-04-09  Tom Tromey  <tromey@adacore.com>
8640
8641         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8642         to bool.
8643         (extended_remote_target::attach): Update.
8644         (remote_target::remote_notice_new_inferior): Update.
8645         (remote_target::add_current_inferior_and_thread): Update.
8646         * inferior.c (exit_inferior_1): Use "false".
8647         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8648
8649 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8650
8651         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8652         the "start" command.
8653
8654 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8655
8656         * python/py-inferior.c (infpy_thread_from_thread_handle):
8657         Adjust comments to reflect renaming of thread_from_thread_handle
8658         to thread_from_handle.  Adjust keywords.  Fix type error message.
8659         (inferior_object_methods): Add thread_from_handle.  Retain
8660         thread_from_thread_handle, but mark it as deprecated.
8661
8662 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8663
8664         * gdbthread.h (find_thread_by_handle): Revise declaration.
8665         * thread.c (find_thread_by_handle): Likewise.  Adjust
8666         implementation too.
8667         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8668         support for buffer objects as handles.
8669
8670 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8671
8672         * python/py-infthread.c (thpy_thread_handle): New function.
8673         (thread_object_methods): Register thpy_thread_handle.
8674
8675 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8676
8677         * gdbthread.h (thread_to_thread_handle): Declare.
8678         * thread.c (gdbtypes.h): Include.
8679         (thread_to_thread_handle): New function.
8680
8681         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8682         (target_thread_info_to_thread_handle): Declare.
8683         * target.c (target_thread_info_to_thread_handle): New function.
8684         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8685         * target-delegates.c: Regenerate.
8686
8687         * linux-thread-db.c (class thread_db_target): Add method
8688         thread_info_to_thread_handle.
8689         (thread_db_target::thread_info_to_thread_handle): Define.
8690         * remote.c (class remote_target): Add new method
8691         thread_info_to_thread_handle.
8692         (remote_target::thread_info_to_thread_handle): Define.
8693
8694 2019-04-08  Pedro Alves  <palves@redhat.com>
8695
8696         * common/common-exceptions.c (throw_exception): Don't create
8697         named object to throw; throw directly.
8698         (throw_it): Likewise.  Don't initialize gdb_exception::message
8699         here, with new; pass FMT and AP to the ctor instead.
8700         * common/common-exceptions.h: Include <string>.
8701         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8702         const char *, va_list)): New ctor.  Use std::make_shared.
8703         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8704         errors)): Delete.
8705         (gdb_exception_error::gdb_exception_error(enum errors, const char
8706         *, va_list)): New.
8707         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8708         Add assertion.
8709         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8710         errors)): Delete.
8711         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8712         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8713         Add assertion.
8714
8715 2019-04-08  Tom Tromey  <tom@tromey.com>
8716
8717         * valops.c (value_rtti_indirect_type): Replace throw_exception
8718         with throw.
8719         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8720         with throw.
8721         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8722         throw.
8723         * target.c (target_translate_tls_address): Replace throw_exception
8724         with throw.
8725         * stack.c (frame_apply_command_count): Replace throw_exception
8726         with throw.
8727         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8728         throw.
8729         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8730         with throw.
8731         * rs6000-tdep.c (rs6000_frame_cache)
8732         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8733         * remote.c: Replace throw_exception with throw.
8734         * record-full.c (record_full_message, record_full_wait_1)
8735         (record_full_restore): Replace throw_exception with throw.
8736         * record-btrace.c:
8737         (get_thread_current_frame_id, record_btrace_start_replaying)
8738         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8739         (cmd_record_btrace_start): Replace throw_exception with throw.
8740         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8741         throw.
8742         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8743         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8744         * linespec.c:
8745         (find_linespec_symbols): Replace throw_exception with throw.
8746         * infrun.c (displaced_step_prepare, resume): Replace
8747         throw_exception with throw.
8748         * infcmd.c (post_create_inferior): Replace throw_exception with
8749         throw.
8750         * inf-loop.c (inferior_event_handler): Replace throw_exception
8751         with throw.
8752         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8753         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8754         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8755         (get_prev_frame_always, get_frame_pc_if_available)
8756         (get_frame_address_in_block_if_available, get_frame_language):
8757         Replace throw_exception with throw.
8758         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8759         throw_exception with throw.
8760         * eval.c (fetch_subexp_value, evaluate_var_value)
8761         (evaluate_funcall, evaluate_subexp_standard): Replace
8762         throw_exception with throw.
8763         * dwarf2loc.c (call_site_find_chain)
8764         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8765         Replace throw_exception with throw.
8766         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8767         with throw.
8768         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8769         throw.
8770         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8771         * completer.c (complete_line_internal): Replace throw_exception
8772         with throw.
8773         * compile/compile-object-run.c (compile_object_run): Replace
8774         throw_exception with throw.
8775         * cli/cli-script.c (process_next_line): Replace throw_exception
8776         with throw.
8777         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8778         (btrace_enable, btrace_maint_update_pt_packets): Replace
8779         throw_exception with throw.
8780         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8781         throw_exception with throw.
8782         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8783         throw_exception with throw.
8784         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8785         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8786         * aarch64-tdep.c (aarch64_make_prologue_cache)
8787         (aarch64_make_stub_cache): Replace throw_exception with throw.
8788
8789 2019-04-08  Tom Tromey  <tom@tromey.com>
8790
8791         * common/common-exceptions.c (throw_exception): Rename from
8792         throw_exception_cxx.  Remove old copy.  Make argument const.
8793         (throw_it): Create and throw exception objects directly.
8794         * common/common-exceptions.h (throw_exception): Make argument
8795         const.
8796         (struct gdb_exception_error): Add constructor.
8797         (struct gdb_exception_quit): Add constructor.
8798
8799 2019-04-08  Tom Tromey  <tom@tromey.com>
8800
8801         * common/common-exceptions.h (exception_rethrow): Don't declare.
8802         (TRY_SJLJ): Update comment.
8803         (TRY, CATCH, END_CATCH): Remove.
8804         * common/common-exceptions.c (exception_rethrow): Remove.
8805
8806 2019-04-08  Tom Tromey  <tom@tromey.com>
8807
8808         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8809         Remove.
8810         (gdb_exception_error): Rename from
8811         gdb_exception_RETURN_MASK_ERROR.
8812         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8813         (gdb_quit_bad_alloc): Update.
8814         * aarch64-tdep.c: Update.
8815         * ada-lang.c: Update.
8816         * ada-typeprint.c: Update.
8817         * ada-valprint.c: Update.
8818         * amd64-tdep.c: Update.
8819         * arch-utils.c: Update.
8820         * break-catch-throw.c: Update.
8821         * breakpoint.c: Update.
8822         * btrace.c: Update.
8823         * c-varobj.c: Update.
8824         * cli/cli-cmds.c: Update.
8825         * cli/cli-interp.c: Update.
8826         * cli/cli-script.c: Update.
8827         * common/common-exceptions.c: Update.
8828         * common/new-op.c: Update.
8829         * common/selftest.c: Update.
8830         * compile/compile-c-symbols.c: Update.
8831         * compile/compile-cplus-symbols.c: Update.
8832         * compile/compile-object-load.c: Update.
8833         * compile/compile-object-run.c: Update.
8834         * completer.c: Update.
8835         * corelow.c: Update.
8836         * cp-abi.c: Update.
8837         * cp-support.c: Update.
8838         * cp-valprint.c: Update.
8839         * darwin-nat.c: Update.
8840         * disasm-selftests.c: Update.
8841         * dtrace-probe.c: Update.
8842         * dwarf-index-cache.c: Update.
8843         * dwarf-index-write.c: Update.
8844         * dwarf2-frame-tailcall.c: Update.
8845         * dwarf2-frame.c: Update.
8846         * dwarf2loc.c: Update.
8847         * dwarf2read.c: Update.
8848         * eval.c: Update.
8849         * event-loop.c: Update.
8850         * event-top.c: Update.
8851         * exec.c: Update.
8852         * f-valprint.c: Update.
8853         * fbsd-tdep.c: Update.
8854         * frame-unwind.c: Update.
8855         * frame.c: Update.
8856         * gdbtypes.c: Update.
8857         * gnu-v3-abi.c: Update.
8858         * guile/guile-internal.h: Update.
8859         * guile/scm-block.c: Update.
8860         * guile/scm-breakpoint.c: Update.
8861         * guile/scm-cmd.c: Update.
8862         * guile/scm-disasm.c: Update.
8863         * guile/scm-frame.c: Update.
8864         * guile/scm-lazy-string.c: Update.
8865         * guile/scm-math.c: Update.
8866         * guile/scm-param.c: Update.
8867         * guile/scm-ports.c: Update.
8868         * guile/scm-pretty-print.c: Update.
8869         * guile/scm-symbol.c: Update.
8870         * guile/scm-symtab.c: Update.
8871         * guile/scm-type.c: Update.
8872         * guile/scm-value.c: Update.
8873         * i386-linux-tdep.c: Update.
8874         * i386-tdep.c: Update.
8875         * inf-loop.c: Update.
8876         * infcall.c: Update.
8877         * infcmd.c: Update.
8878         * infrun.c: Update.
8879         * jit.c: Update.
8880         * language.c: Update.
8881         * linespec.c: Update.
8882         * linux-fork.c: Update.
8883         * linux-nat.c: Update.
8884         * linux-tdep.c: Update.
8885         * linux-thread-db.c: Update.
8886         * main.c: Update.
8887         * mi/mi-cmd-break.c: Update.
8888         * mi/mi-cmd-stack.c: Update.
8889         * mi/mi-interp.c: Update.
8890         * mi/mi-main.c: Update.
8891         * objc-lang.c: Update.
8892         * p-valprint.c: Update.
8893         * parse.c: Update.
8894         * ppc-linux-tdep.c: Update.
8895         * printcmd.c: Update.
8896         * python/py-arch.c: Update.
8897         * python/py-breakpoint.c: Update.
8898         * python/py-cmd.c: Update.
8899         * python/py-finishbreakpoint.c: Update.
8900         * python/py-frame.c: Update.
8901         * python/py-framefilter.c: Update.
8902         * python/py-gdb-readline.c: Update.
8903         * python/py-inferior.c: Update.
8904         * python/py-infthread.c: Update.
8905         * python/py-lazy-string.c: Update.
8906         * python/py-linetable.c: Update.
8907         * python/py-objfile.c: Update.
8908         * python/py-param.c: Update.
8909         * python/py-prettyprint.c: Update.
8910         * python/py-progspace.c: Update.
8911         * python/py-record-btrace.c: Update.
8912         * python/py-record.c: Update.
8913         * python/py-symbol.c: Update.
8914         * python/py-type.c: Update.
8915         * python/py-unwind.c: Update.
8916         * python/py-utils.c: Update.
8917         * python/py-value.c: Update.
8918         * python/python.c: Update.
8919         * record-btrace.c: Update.
8920         * record-full.c: Update.
8921         * remote-fileio.c: Update.
8922         * remote.c: Update.
8923         * riscv-tdep.c: Update.
8924         * rs6000-aix-tdep.c: Update.
8925         * rs6000-tdep.c: Update.
8926         * rust-exp.y: Update.
8927         * rust-lang.c: Update.
8928         * s390-tdep.c: Update.
8929         * selftest-arch.c: Update.
8930         * solib-dsbt.c: Update.
8931         * solib-frv.c: Update.
8932         * solib-spu.c: Update.
8933         * solib-svr4.c: Update.
8934         * solib.c: Update.
8935         * sparc64-linux-tdep.c: Update.
8936         * stack.c: Update.
8937         * symfile-mem.c: Update.
8938         * symmisc.c: Update.
8939         * target.c: Update.
8940         * thread.c: Update.
8941         * top.c: Update.
8942         * tracefile-tfile.c: Update.
8943         * tui/tui.c: Update.
8944         * typeprint.c: Update.
8945         * unittests/cli-utils-selftests.c: Update.
8946         * unittests/parse-connection-spec-selftests.c: Update.
8947         * valops.c: Update.
8948         * valprint.c: Update.
8949         * value.c: Update.
8950         * varobj.c: Update.
8951         * windows-nat.c: Update.
8952         * x86-linux-nat.c: Update.
8953         * xml-support.c: Update.
8954
8955 2019-04-08  Tom Tromey  <tom@tromey.com>
8956
8957         * xml-support.c: Use C++ exception handling.
8958         * x86-linux-nat.c: Use C++ exception handling.
8959         * windows-nat.c: Use C++ exception handling.
8960         * varobj.c: Use C++ exception handling.
8961         * value.c: Use C++ exception handling.
8962         * valprint.c: Use C++ exception handling.
8963         * valops.c: Use C++ exception handling.
8964         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8965         handling.
8966         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8967         * typeprint.c: Use C++ exception handling.
8968         * tui/tui.c: Use C++ exception handling.
8969         * tracefile-tfile.c: Use C++ exception handling.
8970         * top.c: Use C++ exception handling.
8971         * thread.c: Use C++ exception handling.
8972         * target.c: Use C++ exception handling.
8973         * symmisc.c: Use C++ exception handling.
8974         * symfile-mem.c: Use C++ exception handling.
8975         * stack.c: Use C++ exception handling.
8976         * sparc64-linux-tdep.c: Use C++ exception handling.
8977         * solib.c: Use C++ exception handling.
8978         * solib-svr4.c: Use C++ exception handling.
8979         * solib-spu.c: Use C++ exception handling.
8980         * solib-frv.c: Use C++ exception handling.
8981         * solib-dsbt.c: Use C++ exception handling.
8982         * selftest-arch.c: Use C++ exception handling.
8983         * s390-tdep.c: Use C++ exception handling.
8984         * rust-lang.c: Use C++ exception handling.
8985         * rust-exp.y: Use C++ exception handling.
8986         * rs6000-tdep.c: Use C++ exception handling.
8987         * rs6000-aix-tdep.c: Use C++ exception handling.
8988         * riscv-tdep.c: Use C++ exception handling.
8989         * remote.c: Use C++ exception handling.
8990         * remote-fileio.c: Use C++ exception handling.
8991         * record-full.c: Use C++ exception handling.
8992         * record-btrace.c: Use C++ exception handling.
8993         * python/python.c: Use C++ exception handling.
8994         * python/py-value.c: Use C++ exception handling.
8995         * python/py-utils.c: Use C++ exception handling.
8996         * python/py-unwind.c: Use C++ exception handling.
8997         * python/py-type.c: Use C++ exception handling.
8998         * python/py-symbol.c: Use C++ exception handling.
8999         * python/py-record.c: Use C++ exception handling.
9000         * python/py-record-btrace.c: Use C++ exception handling.
9001         * python/py-progspace.c: Use C++ exception handling.
9002         * python/py-prettyprint.c: Use C++ exception handling.
9003         * python/py-param.c: Use C++ exception handling.
9004         * python/py-objfile.c: Use C++ exception handling.
9005         * python/py-linetable.c: Use C++ exception handling.
9006         * python/py-lazy-string.c: Use C++ exception handling.
9007         * python/py-infthread.c: Use C++ exception handling.
9008         * python/py-inferior.c: Use C++ exception handling.
9009         * python/py-gdb-readline.c: Use C++ exception handling.
9010         * python/py-framefilter.c: Use C++ exception handling.
9011         * python/py-frame.c: Use C++ exception handling.
9012         * python/py-finishbreakpoint.c: Use C++ exception handling.
9013         * python/py-cmd.c: Use C++ exception handling.
9014         * python/py-breakpoint.c: Use C++ exception handling.
9015         * python/py-arch.c: Use C++ exception handling.
9016         * printcmd.c: Use C++ exception handling.
9017         * ppc-linux-tdep.c: Use C++ exception handling.
9018         * parse.c: Use C++ exception handling.
9019         * p-valprint.c: Use C++ exception handling.
9020         * objc-lang.c: Use C++ exception handling.
9021         * mi/mi-main.c: Use C++ exception handling.
9022         * mi/mi-interp.c: Use C++ exception handling.
9023         * mi/mi-cmd-stack.c: Use C++ exception handling.
9024         * mi/mi-cmd-break.c: Use C++ exception handling.
9025         * main.c: Use C++ exception handling.
9026         * linux-thread-db.c: Use C++ exception handling.
9027         * linux-tdep.c: Use C++ exception handling.
9028         * linux-nat.c: Use C++ exception handling.
9029         * linux-fork.c: Use C++ exception handling.
9030         * linespec.c: Use C++ exception handling.
9031         * language.c: Use C++ exception handling.
9032         * jit.c: Use C++ exception handling.
9033         * infrun.c: Use C++ exception handling.
9034         * infcmd.c: Use C++ exception handling.
9035         * infcall.c: Use C++ exception handling.
9036         * inf-loop.c: Use C++ exception handling.
9037         * i386-tdep.c: Use C++ exception handling.
9038         * i386-linux-tdep.c: Use C++ exception handling.
9039         * guile/scm-value.c: Use C++ exception handling.
9040         * guile/scm-type.c: Use C++ exception handling.
9041         * guile/scm-symtab.c: Use C++ exception handling.
9042         * guile/scm-symbol.c: Use C++ exception handling.
9043         * guile/scm-pretty-print.c: Use C++ exception handling.
9044         * guile/scm-ports.c: Use C++ exception handling.
9045         * guile/scm-param.c: Use C++ exception handling.
9046         * guile/scm-math.c: Use C++ exception handling.
9047         * guile/scm-lazy-string.c: Use C++ exception handling.
9048         * guile/scm-frame.c: Use C++ exception handling.
9049         * guile/scm-disasm.c: Use C++ exception handling.
9050         * guile/scm-cmd.c: Use C++ exception handling.
9051         * guile/scm-breakpoint.c: Use C++ exception handling.
9052         * guile/scm-block.c: Use C++ exception handling.
9053         * guile/guile-internal.h: Use C++ exception handling.
9054         * gnu-v3-abi.c: Use C++ exception handling.
9055         * gdbtypes.c: Use C++ exception handling.
9056         * frame.c: Use C++ exception handling.
9057         * frame-unwind.c: Use C++ exception handling.
9058         * fbsd-tdep.c: Use C++ exception handling.
9059         * f-valprint.c: Use C++ exception handling.
9060         * exec.c: Use C++ exception handling.
9061         * event-top.c: Use C++ exception handling.
9062         * event-loop.c: Use C++ exception handling.
9063         * eval.c: Use C++ exception handling.
9064         * dwarf2read.c: Use C++ exception handling.
9065         * dwarf2loc.c: Use C++ exception handling.
9066         * dwarf2-frame.c: Use C++ exception handling.
9067         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9068         * dwarf-index-write.c: Use C++ exception handling.
9069         * dwarf-index-cache.c: Use C++ exception handling.
9070         * dtrace-probe.c: Use C++ exception handling.
9071         * disasm-selftests.c: Use C++ exception handling.
9072         * darwin-nat.c: Use C++ exception handling.
9073         * cp-valprint.c: Use C++ exception handling.
9074         * cp-support.c: Use C++ exception handling.
9075         * cp-abi.c: Use C++ exception handling.
9076         * corelow.c: Use C++ exception handling.
9077         * completer.c: Use C++ exception handling.
9078         * compile/compile-object-run.c: Use C++ exception handling.
9079         * compile/compile-object-load.c: Use C++ exception handling.
9080         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9081         * compile/compile-c-symbols.c: Use C++ exception handling.
9082         * common/selftest.c: Use C++ exception handling.
9083         * common/new-op.c: Use C++ exception handling.
9084         * cli/cli-script.c: Use C++ exception handling.
9085         * cli/cli-interp.c: Use C++ exception handling.
9086         * cli/cli-cmds.c: Use C++ exception handling.
9087         * c-varobj.c: Use C++ exception handling.
9088         * btrace.c: Use C++ exception handling.
9089         * breakpoint.c: Use C++ exception handling.
9090         * break-catch-throw.c: Use C++ exception handling.
9091         * arch-utils.c: Use C++ exception handling.
9092         * amd64-tdep.c: Use C++ exception handling.
9093         * ada-valprint.c: Use C++ exception handling.
9094         * ada-typeprint.c: Use C++ exception handling.
9095         * ada-lang.c: Use C++ exception handling.
9096         * aarch64-tdep.c: Use C++ exception handling.
9097
9098 2019-04-08  Tom Tromey  <tom@tromey.com>
9099
9100         * xml-support.c (gdb_xml_parser::parse): Update.
9101         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9102         * value.c (show_convenience): Update.
9103         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9104         (test_parse_flags_qcs): Update.
9105         * thread.c (thr_try_catch_cmd): Update.
9106         * target.c (target_translate_tls_address): Update.
9107         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9108         (info_frame_command_core, frame_apply_command_count): Update.
9109         * rust-exp.y (rust_lex_exception_test): Update.
9110         * riscv-tdep.c (riscv_print_one_register_info): Update.
9111         * remote.c (remote_target::enable_btrace): Update.
9112         * record-btrace.c (record_btrace_enable_warn): Update.
9113         * python/py-utils.c (gdbpy_convert_exception): Update.
9114         * printcmd.c (do_one_display, print_variable_and_value): Update.
9115         * mi/mi-main.c (mi_print_exception): Update.
9116         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9117         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9118         * linux-nat.c (linux_nat_target::attach): Update.
9119         * linux-fork.c (class scoped_switch_fork_info): Update.
9120         * infrun.c (displaced_step_prepare): Update.
9121         * infcall.c (call_function_by_hand_dummy): Update.
9122         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9123         * gnu-v3-abi.c (print_one_vtable): Update.
9124         * frame.c (get_prev_frame_always): Update.
9125         * f-valprint.c (info_common_command_for_block): Update.
9126         * exec.c (try_open_exec_file): Update.
9127         * exceptions.c (print_exception, exception_print)
9128         (exception_fprintf, exception_print_same): Update.
9129         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9130         * dwarf-index-cache.c (index_cache::store)
9131         (index_cache::lookup_gdb_index): Update.
9132         * darwin-nat.c (maybe_cache_shell): Update.
9133         * cp-valprint.c (cp_print_value_fields): Update.
9134         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9135         (gcc_cplus_symbol_address): Update.
9136         * compile/compile-c-symbols.c (gcc_convert_symbol)
9137         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9138         * common/selftest.c: Update.
9139         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9140         a std::string.
9141         (exception_try_scope_entry, exception_try_scope_exit): Don't
9142         declare.
9143         (struct exception_try_scope): Remove.
9144         (TRY): Don't use exception_try_scope.
9145         (struct gdb_exception): Add constructor, operator=.
9146         <what>: New method.
9147         (struct gdb_exception_RETURN_MASK_ALL)
9148         (struct gdb_exception_RETURN_MASK_ERROR)
9149         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9150         (struct gdb_quit_bad_alloc): Update.
9151         * common/common-exceptions.c (exception_none): Change
9152         initializer.
9153         (struct catcher) <state, exception>: Initialize inline.
9154         <prev>: Remove member.
9155         (current_catcher): Remove.
9156         (catchers): New global.
9157         (exceptions_state_mc_init): Simplify.
9158         (catcher_pop): Remove.
9159         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9160         (try_scope_depth, exception_try_scope_entry)
9161         (exception_try_scope_exit): Remove.
9162         (throw_exception_sjlj): Update.
9163         (exception_messages, exception_messages_size): Remove.
9164         (throw_it): Simplify.
9165         (gdb_exception_sliced_copy): Remove.
9166         (throw_exception_cxx): Update.
9167         * cli/cli-script.c (script_from_file): Update.
9168         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9169         Update.
9170         * ada-valprint.c (ada_val_print): Update.
9171         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9172         (create_excep_cond_exprs): Update.
9173
9174 2019-04-08  Tom Tromey  <tom@tromey.com>
9175
9176         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9177         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9178         (TRY, CATCH, END_CATCH): Remove some definitions.
9179         * common/common-exceptions.c: Don't use GDB_XCPT.
9180         (catcher_list_size): Remove.
9181         (throw_exception, throw_it): Simplify.
9182
9183 2019-04-05  Tom Tromey  <tom@tromey.com>
9184
9185         Revert the header-sorting patch.
9186         * ft32-tdep.c: Revert.
9187         * frv-tdep.c: Revert.
9188         * frv-linux-tdep.c: Revert.
9189         * frame.c: Revert.
9190         * frame-unwind.c: Revert.
9191         * frame-base.c: Revert.
9192         * fork-child.c: Revert.
9193         * findvar.c: Revert.
9194         * findcmd.c: Revert.
9195         * filesystem.c: Revert.
9196         * filename-seen-cache.h: Revert.
9197         * filename-seen-cache.c: Revert.
9198         * fbsd-tdep.c: Revert.
9199         * fbsd-nat.h: Revert.
9200         * fbsd-nat.c: Revert.
9201         * f-valprint.c: Revert.
9202         * f-typeprint.c: Revert.
9203         * f-lang.c: Revert.
9204         * extension.h: Revert.
9205         * extension.c: Revert.
9206         * extension-priv.h: Revert.
9207         * expprint.c: Revert.
9208         * exec.h: Revert.
9209         * exec.c: Revert.
9210         * exceptions.c: Revert.
9211         * event-top.c: Revert.
9212         * event-loop.c: Revert.
9213         * eval.c: Revert.
9214         * elfread.c: Revert.
9215         * dwarf2read.h: Revert.
9216         * dwarf2read.c: Revert.
9217         * dwarf2loc.c: Revert.
9218         * dwarf2expr.h: Revert.
9219         * dwarf2expr.c: Revert.
9220         * dwarf2-frame.c: Revert.
9221         * dwarf2-frame-tailcall.c: Revert.
9222         * dwarf-index-write.h: Revert.
9223         * dwarf-index-write.c: Revert.
9224         * dwarf-index-common.c: Revert.
9225         * dwarf-index-cache.h: Revert.
9226         * dwarf-index-cache.c: Revert.
9227         * dummy-frame.c: Revert.
9228         * dtrace-probe.c: Revert.
9229         * disasm.h: Revert.
9230         * disasm.c: Revert.
9231         * disasm-selftests.c: Revert.
9232         * dictionary.c: Revert.
9233         * dicos-tdep.c: Revert.
9234         * demangle.c: Revert.
9235         * dcache.h: Revert.
9236         * dcache.c: Revert.
9237         * darwin-nat.h: Revert.
9238         * darwin-nat.c: Revert.
9239         * darwin-nat-info.c: Revert.
9240         * d-valprint.c: Revert.
9241         * d-namespace.c: Revert.
9242         * d-lang.c: Revert.
9243         * ctf.c: Revert.
9244         * csky-tdep.c: Revert.
9245         * csky-linux-tdep.c: Revert.
9246         * cris-tdep.c: Revert.
9247         * cris-linux-tdep.c: Revert.
9248         * cp-valprint.c: Revert.
9249         * cp-support.c: Revert.
9250         * cp-namespace.c: Revert.
9251         * cp-abi.c: Revert.
9252         * corelow.c: Revert.
9253         * corefile.c: Revert.
9254         * continuations.c: Revert.
9255         * completer.h: Revert.
9256         * completer.c: Revert.
9257         * complaints.c: Revert.
9258         * coffread.c: Revert.
9259         * coff-pe-read.c: Revert.
9260         * cli-out.h: Revert.
9261         * cli-out.c: Revert.
9262         * charset.c: Revert.
9263         * c-varobj.c: Revert.
9264         * c-valprint.c: Revert.
9265         * c-typeprint.c: Revert.
9266         * c-lang.c: Revert.
9267         * buildsym.c: Revert.
9268         * buildsym-legacy.c: Revert.
9269         * build-id.h: Revert.
9270         * build-id.c: Revert.
9271         * btrace.c: Revert.
9272         * bsd-uthread.c: Revert.
9273         * breakpoint.h: Revert.
9274         * breakpoint.c: Revert.
9275         * break-catch-throw.c: Revert.
9276         * break-catch-syscall.c: Revert.
9277         * break-catch-sig.c: Revert.
9278         * blockframe.c: Revert.
9279         * block.c: Revert.
9280         * bfin-tdep.c: Revert.
9281         * bfin-linux-tdep.c: Revert.
9282         * bfd-target.c: Revert.
9283         * bcache.c: Revert.
9284         * ax-general.c: Revert.
9285         * ax-gdb.h: Revert.
9286         * ax-gdb.c: Revert.
9287         * avr-tdep.c: Revert.
9288         * auxv.c: Revert.
9289         * auto-load.c: Revert.
9290         * arm-wince-tdep.c: Revert.
9291         * arm-tdep.c: Revert.
9292         * arm-symbian-tdep.c: Revert.
9293         * arm-pikeos-tdep.c: Revert.
9294         * arm-obsd-tdep.c: Revert.
9295         * arm-nbsd-tdep.c: Revert.
9296         * arm-nbsd-nat.c: Revert.
9297         * arm-linux-tdep.c: Revert.
9298         * arm-linux-nat.c: Revert.
9299         * arm-fbsd-tdep.c: Revert.
9300         * arm-fbsd-nat.c: Revert.
9301         * arm-bsd-tdep.c: Revert.
9302         * arch-utils.c: Revert.
9303         * arc-tdep.c: Revert.
9304         * arc-newlib-tdep.c: Revert.
9305         * annotate.h: Revert.
9306         * annotate.c: Revert.
9307         * amd64-windows-tdep.c: Revert.
9308         * amd64-windows-nat.c: Revert.
9309         * amd64-tdep.c: Revert.
9310         * amd64-sol2-tdep.c: Revert.
9311         * amd64-obsd-tdep.c: Revert.
9312         * amd64-obsd-nat.c: Revert.
9313         * amd64-nbsd-tdep.c: Revert.
9314         * amd64-nbsd-nat.c: Revert.
9315         * amd64-nat.c: Revert.
9316         * amd64-linux-tdep.c: Revert.
9317         * amd64-linux-nat.c: Revert.
9318         * amd64-fbsd-tdep.c: Revert.
9319         * amd64-fbsd-nat.c: Revert.
9320         * amd64-dicos-tdep.c: Revert.
9321         * amd64-darwin-tdep.c: Revert.
9322         * amd64-bsd-nat.c: Revert.
9323         * alpha-tdep.c: Revert.
9324         * alpha-obsd-tdep.c: Revert.
9325         * alpha-nbsd-tdep.c: Revert.
9326         * alpha-mdebug-tdep.c: Revert.
9327         * alpha-linux-tdep.c: Revert.
9328         * alpha-linux-nat.c: Revert.
9329         * alpha-bsd-tdep.c: Revert.
9330         * alpha-bsd-nat.c: Revert.
9331         * aix-thread.c: Revert.
9332         * agent.c: Revert.
9333         * addrmap.c: Revert.
9334         * ada-varobj.c: Revert.
9335         * ada-valprint.c: Revert.
9336         * ada-typeprint.c: Revert.
9337         * ada-tasks.c: Revert.
9338         * ada-lang.c: Revert.
9339         * aarch64-tdep.c: Revert.
9340         * aarch64-ravenscar-thread.c: Revert.
9341         * aarch64-newlib-tdep.c: Revert.
9342         * aarch64-linux-tdep.c: Revert.
9343         * aarch64-linux-nat.c: Revert.
9344         * aarch64-fbsd-tdep.c: Revert.
9345         * aarch64-fbsd-nat.c: Revert.
9346         * aarch32-linux-nat.c: Revert.
9347
9348 2019-04-05  Tom Tromey  <tom@tromey.com>
9349
9350         * ft32-tdep.c: Sort headers.
9351         * frv-tdep.c: Sort headers.
9352         * frv-linux-tdep.c: Sort headers.
9353         * frame.c: Sort headers.
9354         * frame-unwind.c: Sort headers.
9355         * frame-base.c: Sort headers.
9356         * fork-child.c: Sort headers.
9357         * findvar.c: Sort headers.
9358         * findcmd.c: Sort headers.
9359         * filesystem.c: Sort headers.
9360         * filename-seen-cache.h: Sort headers.
9361         * filename-seen-cache.c: Sort headers.
9362         * fbsd-tdep.c: Sort headers.
9363         * fbsd-nat.h: Sort headers.
9364         * fbsd-nat.c: Sort headers.
9365         * f-valprint.c: Sort headers.
9366         * f-typeprint.c: Sort headers.
9367         * f-lang.c: Sort headers.
9368         * extension.h: Sort headers.
9369         * extension.c: Sort headers.
9370         * extension-priv.h: Sort headers.
9371         * expprint.c: Sort headers.
9372         * exec.h: Sort headers.
9373         * exec.c: Sort headers.
9374         * exceptions.c: Sort headers.
9375         * event-top.c: Sort headers.
9376         * event-loop.c: Sort headers.
9377         * eval.c: Sort headers.
9378         * elfread.c: Sort headers.
9379         * dwarf2read.h: Sort headers.
9380         * dwarf2read.c: Sort headers.
9381         * dwarf2loc.c: Sort headers.
9382         * dwarf2expr.h: Sort headers.
9383         * dwarf2expr.c: Sort headers.
9384         * dwarf2-frame.c: Sort headers.
9385         * dwarf2-frame-tailcall.c: Sort headers.
9386         * dwarf-index-write.h: Sort headers.
9387         * dwarf-index-write.c: Sort headers.
9388         * dwarf-index-common.c: Sort headers.
9389         * dwarf-index-cache.h: Sort headers.
9390         * dwarf-index-cache.c: Sort headers.
9391         * dummy-frame.c: Sort headers.
9392         * dtrace-probe.c: Sort headers.
9393         * disasm.h: Sort headers.
9394         * disasm.c: Sort headers.
9395         * disasm-selftests.c: Sort headers.
9396         * dictionary.c: Sort headers.
9397         * dicos-tdep.c: Sort headers.
9398         * demangle.c: Sort headers.
9399         * dcache.h: Sort headers.
9400         * dcache.c: Sort headers.
9401         * darwin-nat.h: Sort headers.
9402         * darwin-nat.c: Sort headers.
9403         * darwin-nat-info.c: Sort headers.
9404         * d-valprint.c: Sort headers.
9405         * d-namespace.c: Sort headers.
9406         * d-lang.c: Sort headers.
9407         * ctf.c: Sort headers.
9408         * csky-tdep.c: Sort headers.
9409         * csky-linux-tdep.c: Sort headers.
9410         * cris-tdep.c: Sort headers.
9411         * cris-linux-tdep.c: Sort headers.
9412         * cp-valprint.c: Sort headers.
9413         * cp-support.c: Sort headers.
9414         * cp-namespace.c: Sort headers.
9415         * cp-abi.c: Sort headers.
9416         * corelow.c: Sort headers.
9417         * corefile.c: Sort headers.
9418         * continuations.c: Sort headers.
9419         * completer.h: Sort headers.
9420         * completer.c: Sort headers.
9421         * complaints.c: Sort headers.
9422         * coffread.c: Sort headers.
9423         * coff-pe-read.c: Sort headers.
9424         * cli-out.h: Sort headers.
9425         * cli-out.c: Sort headers.
9426         * charset.c: Sort headers.
9427         * c-varobj.c: Sort headers.
9428         * c-valprint.c: Sort headers.
9429         * c-typeprint.c: Sort headers.
9430         * c-lang.c: Sort headers.
9431         * buildsym.c: Sort headers.
9432         * buildsym-legacy.c: Sort headers.
9433         * build-id.h: Sort headers.
9434         * build-id.c: Sort headers.
9435         * btrace.c: Sort headers.
9436         * bsd-uthread.c: Sort headers.
9437         * breakpoint.h: Sort headers.
9438         * breakpoint.c: Sort headers.
9439         * break-catch-throw.c: Sort headers.
9440         * break-catch-syscall.c: Sort headers.
9441         * break-catch-sig.c: Sort headers.
9442         * blockframe.c: Sort headers.
9443         * block.c: Sort headers.
9444         * bfin-tdep.c: Sort headers.
9445         * bfin-linux-tdep.c: Sort headers.
9446         * bfd-target.c: Sort headers.
9447         * bcache.c: Sort headers.
9448         * ax-general.c: Sort headers.
9449         * ax-gdb.h: Sort headers.
9450         * ax-gdb.c: Sort headers.
9451         * avr-tdep.c: Sort headers.
9452         * auxv.c: Sort headers.
9453         * auto-load.c: Sort headers.
9454         * arm-wince-tdep.c: Sort headers.
9455         * arm-tdep.c: Sort headers.
9456         * arm-symbian-tdep.c: Sort headers.
9457         * arm-pikeos-tdep.c: Sort headers.
9458         * arm-obsd-tdep.c: Sort headers.
9459         * arm-nbsd-tdep.c: Sort headers.
9460         * arm-nbsd-nat.c: Sort headers.
9461         * arm-linux-tdep.c: Sort headers.
9462         * arm-linux-nat.c: Sort headers.
9463         * arm-fbsd-tdep.c: Sort headers.
9464         * arm-fbsd-nat.c: Sort headers.
9465         * arm-bsd-tdep.c: Sort headers.
9466         * arch-utils.c: Sort headers.
9467         * arc-tdep.c: Sort headers.
9468         * arc-newlib-tdep.c: Sort headers.
9469         * annotate.h: Sort headers.
9470         * annotate.c: Sort headers.
9471         * amd64-windows-tdep.c: Sort headers.
9472         * amd64-windows-nat.c: Sort headers.
9473         * amd64-tdep.c: Sort headers.
9474         * amd64-sol2-tdep.c: Sort headers.
9475         * amd64-obsd-tdep.c: Sort headers.
9476         * amd64-obsd-nat.c: Sort headers.
9477         * amd64-nbsd-tdep.c: Sort headers.
9478         * amd64-nbsd-nat.c: Sort headers.
9479         * amd64-nat.c: Sort headers.
9480         * amd64-linux-tdep.c: Sort headers.
9481         * amd64-linux-nat.c: Sort headers.
9482         * amd64-fbsd-tdep.c: Sort headers.
9483         * amd64-fbsd-nat.c: Sort headers.
9484         * amd64-dicos-tdep.c: Sort headers.
9485         * amd64-darwin-tdep.c: Sort headers.
9486         * amd64-bsd-nat.c: Sort headers.
9487         * alpha-tdep.c: Sort headers.
9488         * alpha-obsd-tdep.c: Sort headers.
9489         * alpha-nbsd-tdep.c: Sort headers.
9490         * alpha-mdebug-tdep.c: Sort headers.
9491         * alpha-linux-tdep.c: Sort headers.
9492         * alpha-linux-nat.c: Sort headers.
9493         * alpha-bsd-tdep.c: Sort headers.
9494         * alpha-bsd-nat.c: Sort headers.
9495         * aix-thread.c: Sort headers.
9496         * agent.c: Sort headers.
9497         * addrmap.c: Sort headers.
9498         * ada-varobj.c: Sort headers.
9499         * ada-valprint.c: Sort headers.
9500         * ada-typeprint.c: Sort headers.
9501         * ada-tasks.c: Sort headers.
9502         * ada-lang.c: Sort headers.
9503         * aarch64-tdep.c: Sort headers.
9504         * aarch64-ravenscar-thread.c: Sort headers.
9505         * aarch64-newlib-tdep.c: Sort headers.
9506         * aarch64-linux-tdep.c: Sort headers.
9507         * aarch64-linux-nat.c: Sort headers.
9508         * aarch64-fbsd-tdep.c: Sort headers.
9509         * aarch64-fbsd-nat.c: Sort headers.
9510         * aarch32-linux-nat.c: Sort headers.
9511
9512 2019-04-04  Tom Tromey  <tom@tromey.com>
9513
9514         * varobj.c (varobj_create): Update.
9515         * rust-exp.y (struct rust_parser) <update_innermost_block,
9516         lookup_symbol>: New methods.
9517         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9518         Rename.
9519         (rust_parser::rust_lookup_type)
9520         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9521         * printcmd.c (display_command, do_one_display): Update.
9522         * parser-defs.h (struct parser_state) <parser_state>: Add
9523         "tracker" parameter.
9524         (block_tracker): New member.
9525         (class innermost_block_tracker) <innermost_block_tracker>: Add
9526         "types" parameter.
9527         <reset>: Remove method.
9528         (innermost_block): Don't declare.
9529         (null_post_parser): Update.
9530         * parse.c (innermost_block): Remove global.
9531         (write_dollar_variable): Update.
9532         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9533         Remove "tracker_types" parameter.
9534         (parse_expression): Add "tracker" parameter.
9535         (parse_expression_for_completion): Update.
9536         (null_post_parser): Add "tracker" parameter.
9537         * p-exp.y: Update rules.
9538         * m2-exp.y: Update rules.
9539         * language.h (struct language_defn) <la_post_parser>: Add
9540         "tracker" parameter.
9541         * go-exp.y: Update rules.
9542         * f-exp.y: Update rules.
9543         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9544         parameter.
9545         * d-exp.y: Update rules.
9546         * c-exp.y: Update rules.
9547         * breakpoint.c (set_breakpoint_condition): Create an
9548         innermost_block_tracker.
9549         (watch_command_1): Likewise.
9550         * ada-lang.c (resolve): Add "tracker" parameter.
9551         (resolve_subexp): Likewise.
9552         * ada-exp.y (write_var_from_sym): Update.
9553
9554 2019-04-04  Tom Tromey  <tom@tromey.com>
9555
9556         * type-stack.h: New file.
9557         * type-stack.c: New file.
9558         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9559         type-stack.h.
9560         (insert_into_type_stack, insert_type, push_type, push_type_int)
9561         (insert_type_address_space, pop_type, pop_type_int)
9562         (pop_typelist, pop_type_stack, append_type_stack)
9563         (push_type_stack, get_type_stack, push_typelist)
9564         (follow_type_instance_flags, follow_types): Don't declare.
9565         * parse.c (type_stack): Remove global.
9566         (parse_exp_in_context): Update.
9567         (insert_into_type_stack, insert_type, push_type, push_type_int)
9568         (insert_type_address_space, pop_type, pop_type_int)
9569         (pop_typelist, pop_type_stack, append_type_stack)
9570         (push_type_stack, get_type_stack, push_typelist)
9571         (follow_type_instance_flags, follow_types): Remove (moved to
9572         type-stack.c).
9573         * f-exp.y (type_stack): New global.
9574         Update rules.
9575         (push_kind_type, f_parse): Update.
9576         * d-exp.y (type_stack): New global.
9577         Update rules.
9578         (d_parse): Update.
9579         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9580         Update rules.
9581         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9582         (HFILES_NO_SRCDIR): Add type-stack.h.
9583
9584 2019-04-04  Tom Tromey  <tom@tromey.com>
9585
9586         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9587         (rust_parser::convert_ast_to_expression, rust_parse)
9588         (rust_lex_test_completion, rust_lex_tests): Update.
9589         * parser-defs.h (struct expr_completion_state): New.
9590         (struct parser_state) <parser_state>: Add completion parameter.
9591         <mark_struct_expression, mark_completion_tag>: New methods.
9592         <parse_completion, m_completion_state>: New members.
9593         (prefixify_expression, null_post_parser): Update.
9594         (mark_struct_expression, mark_completion_tag): Don't declare.
9595         * parse.c (parse_completion, expout_last_struct)
9596         (expout_tag_completion_type, expout_completion_name): Remove
9597         globals.
9598         (parser_state::mark_struct_expression)
9599         (parser_state::mark_completion_tag): Now methods.
9600         (prefixify_expression): Add last_struct parameter.
9601         (prefixify_subexp): Likewise.
9602         (parse_exp_1): Update.
9603         (parse_exp_in_context): Add cstate parameter.  Update.
9604         (parse_expression_for_completion): Create an
9605         expr_completion_state.
9606         (null_post_parser): Add "completion" parameter.
9607         * p-exp.y: Update rules.
9608         (yylex): Update.
9609         * language.h (struct language_defn) <la_post_parser>: Add
9610         "completing" parameter.
9611         * go-exp.y: Update rules.
9612         (lex_one_token): Update.
9613         * expression.h (parse_completion): Don't declare.
9614         * d-exp.y: Update rules.
9615         (lex_one_token): Update rules.
9616         * c-exp.y: Update rules.
9617         (lex_one_token): Update.
9618         * ada-lang.c (resolve): Add "parse_completion" parameter.
9619         (resolve_subexp): Likewise.
9620         (ada_resolve_function): Likewise.
9621
9622 2019-04-04  Tom Tromey  <tom@tromey.com>
9623
9624         * parser-defs.h (struct parser_state) <start_arglist,
9625         end_arglist>: New methods.
9626         <arglist_len, m_funcall_chain>: New members.
9627         (arglist_len, start_arglist, end_arglist): Don't declare.
9628         * parse.c (arglist_len, funcall_chain): Remove global.
9629         (start_arglist, end_arglist): Remove functions.
9630         (parse_exp_in_context): Update.
9631         * p-exp.y: Update rules.
9632         * m2-exp.y: Update rules.
9633         * go-exp.y: Update rules.
9634         * f-exp.y: Update rules.
9635         * d-exp.y: Update rules.
9636         * c-exp.y: Update rules.
9637
9638 2019-04-04  Tom Tromey  <tom@tromey.com>
9639
9640         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9641         lex_operator, push_back>: New methods.
9642         Update all rules.
9643         (rust_parser::lex_hex, lex_escape): Rename and update.
9644         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9645         (rust_parser::lex_operator): Rename and update.
9646         (rust_parser::lex_number, rustyylex, rustyyerror)
9647         (rust_lex_test_init, rust_lex_test_sequence)
9648         (rust_lex_test_push_back, rust_lex_tests): Update.
9649         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9650         parameter.
9651         <lexptr, prev_lexptr>: New members.
9652         (lexptr, prev_lexptr): Don't declare.
9653         * parse.c (lexptr, prev_lexptr): Remove globals.
9654         (parse_exp_in_context): Update.
9655         * p-exp.y (yylex, yyerror): Update.
9656         * m2-exp.y (parse_number, yylex, yyerror): Update.
9657         * go-exp.y (lex_one_token, yyerror): Update.
9658         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9659         * d-exp.y (lex_one_token, yyerror): Update.
9660         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9661         (lex_one_token, yyerror): Update.
9662         * ada-lex.l (YY_INPUT): Update.
9663         (rewind_to_char): Update.
9664         * ada-exp.y (yyerror): Update.
9665
9666 2019-04-04  Tom Tromey  <tom@tromey.com>
9667
9668         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9669         * parser-defs.h (struct parser_state) <parser_state>: Add new
9670         parameter.
9671         <comma_terminates>: New member.
9672         (comma_terminates): Don't declare global.
9673         * parse.c (comma_terminates): Remove global.
9674         (parse_exp_in_context): Update.
9675         * p-exp.y (yylex): Update.
9676         * m2-exp.y (yylex): Update.
9677         * go-exp.y (lex_one_token): Update.
9678         * f-exp.y (yylex): Update.
9679         * d-exp.y (lex_one_token): Update.
9680         * c-exp.y (lex_one_token): Update.
9681         * ada-lex.l: Update.
9682
9683 2019-04-04  Tom Tromey  <tom@tromey.com>
9684
9685         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9686         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9687         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9688         * parser-defs.h (paren_depth): Don't declare.
9689         * parse.c (paren_depth): Remove global.
9690         (parse_exp_in_context): Update.
9691         * p-exp.y (paren_depth): New global.
9692         (pascal_parse): Initialize it.
9693         * m2-exp.y (paren_depth): New global.
9694         (m2_parse): Initialize it.
9695         * go-exp.y (paren_depth): New global.
9696         (go_parse): Initialize it.
9697         * f-exp.y (paren_depth): New global.
9698         (f_parse): Initialize it.
9699         * d-exp.y (paren_depth): New global.
9700         (d_parse): Initialize it.
9701         * c-exp.y (paren_depth): New global.
9702         (c_parse): Initialize it.
9703         * ada-lex.l (paren_depth): New global.
9704         (lexer_init): Initialize it.
9705
9706 2019-04-04  Tom Tromey  <tom@tromey.com>
9707
9708         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9709         (rust_parser::convert_ast_to_type)
9710         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9711         * parser-defs.h (struct parser_state) <parser_state>: Add
9712         parameters.  Initialize new members.
9713         <expression_context_block, expression_context_pc>: New members.
9714         * parse.c (expression_context_block, expression_context_pc):
9715         Remove globals.
9716         (parse_exp_in_context): Update.
9717         * p-exp.y: Update all rules.
9718         (yylex): Update.
9719         * m2-exp.y: Update all rules.
9720         (yylex): Update.
9721         * go-exp.y (yylex): Update.
9722         * f-exp.y (yylex): Update.
9723         * d-exp.y: Update all rules.
9724         (yylex): Update.
9725         * c-exp.y: Update all rules.
9726         (lex_one_token, classify_name, yylex, c_parse): Update.
9727         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9728
9729 2019-04-04  Tom Tromey  <tom@tromey.com>
9730
9731         * gdbarch.h, gdbarch.c: Rebuild.
9732         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9733         * stap-probe.h:
9734         (struct stap_parse_info): Replace "parser_state" with
9735         "expr_builder".
9736         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9737         (parser_state): New class.
9738         * parse.c (expr_builder): Rename.
9739         (expr_builder::release): Rename.
9740         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9741         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9742         (write_exp_elt_longcst, write_exp_elt_floatcst)
9743         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9744         (write_exp_string_vector, write_exp_bitstring)
9745         (write_exp_msymbol, mark_struct_expression)
9746         (write_dollar_variable)
9747         (insert_type_address_space, increase_expout_size): Replace
9748         "parser_state" with "expr_builder".
9749         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9750         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9751         "parser_state" with "expr_builder".
9752
9753 2019-04-04  Tom Tromey  <tom@tromey.com>
9754
9755         * rust-exp.y: Replace "parse_language" with method call.
9756         * p-exp.y:
9757         (yylex): Replace "parse_language" with method call.
9758         * m2-exp.y:
9759         (yylex): Replace "parse_language" with method call.
9760         * go-exp.y (classify_name): Replace "parse_language" with method
9761         call.
9762         * f-exp.y (yylex): Replace "parse_language" with method call.
9763         * d-exp.y (lex_one_token): Replace "parse_language" with method
9764         call.
9765         * c-exp.y:
9766         (lex_one_token, classify_name, yylex): Replace "parse_language"
9767         with method call.
9768         * ada-exp.y (find_primitive_type, type_char)
9769         (type_system_address): Replace "parse_language" with method call.
9770
9771 2019-04-04  Tom Tromey  <tom@tromey.com>
9772
9773         * rust-exp.y: Replace "parse_gdbarch" with method call.
9774         * parse.c (write_dollar_variable, insert_type_address_space):
9775         Replace "parse_gdbarch" with method call.
9776         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9777         call.
9778         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9779         call.
9780         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9781         "parse_gdbarch" with method call.
9782         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9783         with method call.
9784         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9785         "parse_gdbarch" with method call.
9786         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9787         "parse_gdbarch" with method call.
9788         * c-exp.y (parse_type, parse_number, classify_name): Replace
9789         "parse_gdbarch" with method call.
9790         * ada-lex.l: Replace "parse_gdbarch" with method call.
9791         * ada-exp.y (parse_type, find_primitive_type, type_char)
9792         (type_system_address): Replace "parse_gdbarch" with method call.
9793
9794 2019-04-04  Tom Tromey  <tom@tromey.com>
9795
9796         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9797         * stap-probe.c (stap_parse_argument): Update.
9798         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9799         initial_size parameter.
9800         * rust-exp.y (rust_lex_tests): Update.
9801         * parse.c (parser_state): Update.
9802         (parse_exp_in_context): Update.
9803         * parser-defs.h (struct parser_state) <parser_state>: Remove
9804         "initial_size" parameter.
9805
9806 2019-04-04  Tom Tromey  <tom@tromey.com>
9807
9808         * parser-defs.h (increase_expout_size): Don't declare.
9809         * parse.c (increase_expout_size): Now static.
9810
9811 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9812
9813         * gnu-nat.c (gnu_nat_target::wait): Fix
9814         target_waitstatus_to_string call.
9815
9816 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9817
9818         * eval.c (evaluate_subexp_standard): Handle internal functions
9819         during Fortran function call handling.
9820
9821 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * NEWS: Mention new internal functions.
9824         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9825         (read_base_type): Use dwarf2_init_complex_target_type.
9826         * value.c (creal_internal_fn): New function.
9827         (cimag_internal_fn): New function.
9828         (_initialize_values): Register new internal functions.
9829
9830 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9831
9832         * infrun.c (stop_all_threads): If debug_infrun, always
9833         trace the wait status after wait_one, using
9834         target_waitstatus_to_string and target_pid_to_str.
9835         (handle_inferior_event): Replace various trace of
9836         wait status kind by a single trace.
9837         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9838         wait status kind image by target_waitstatus_to_string.
9839         * target/waitstatus.c (target_waitstatus_to_string): Fix
9840         obsolete comment.
9841
9842 2019-04-01  Tom Tromey  <tromey@adacore.com>
9843
9844         PR symtab/23331:
9845         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9846
9847 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9848             Pedro Alves  <palves@redhat.com>
9849
9850         * top.c (quit_force): Call 'finalize_values'.
9851         * value.c (finalize_values): New function.
9852         * value.h (finalize_values): Declare.
9853
9854 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9855
9856         * NEWS: Announce $_gdb_major and $_gdb_minor.
9857
9858         * top.c (init_gdb_version_vars): New function.
9859         (gdb_init): Call init_gdb_version_vars.
9860
9861 2019-03-29  Tom Tromey  <tromey@adacore.com>
9862
9863         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9864         help text.  Remove dead code.
9865
9866 2019-03-29  Keith Seitz  <keiths@redhat.com>
9867
9868         From Siddhesh Poyarekar:
9869         * f-lang.h (f77_get_upperbound): Return LONGEST.
9870         (f77_get_lowerbound): Likewise.
9871         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9872         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9873         print them.
9874         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9875         plongest to format print it.
9876         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9877         (f77_get_upperbound): Likewise.
9878         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9879         LOWER_BOUND to LONGEST.
9880         (f77_create_arrayprint_offset_tbl): Likewise.
9881
9882 2019-03-29  Keith Seitz  <keiths@redhat.com>
9883
9884         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9885         %s/pulongest for TYPE_LENGTH instead of %d in format
9886         strings.
9887         * ada-typerint.c (ada_print_type): Likewise.
9888         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9889         * compile/compile-c-support.c (generate_register_struct): Likewise.
9890         * gdbtypes.c (recursive_dump_type): Likewise.
9891         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9892         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9893         instead of %d in format strings.
9894         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9895         to std::min to ULONGEST.
9896         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9897         instead of %d in format strings.
9898         * tracepoint.c (info_scope_command): Likewise.
9899         * typeprint.c (print_offset_data::update)
9900         (print_offset_data::finish): Likewise.
9901         * xtensa-tdep.c (xtensa_store_return_value)
9902         (xtensa_push_dummy_call): Likewise.
9903
9904 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9905
9906         * windows-nat.c (display_selector): Fixed format specifications
9907         for 64-bit Cygwin.
9908
9909 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9910
9911         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9912
9913 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9914
9915         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9916         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9917         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9918         (nios2_linux_init_abi): Install it.
9919
9920 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9921
9922         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9923
9924 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9925
9926         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9927
9928 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9929             Tom Tromey  <tromey@adacore.com>
9930
9931         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9932
9933 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9934
9935         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9936         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9937         method to compute the bounds of range types. Also print "[evaluated]"
9938         if the bounds' values come from a dynamic evaluation.
9939
9940 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9941
9942         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9943         whitespace when pretty printing is on.
9944
9945 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9946
9947         * ppc-linux-nat.c: Add include.
9948
9949 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9950
9951         * NEWS: Mention AArch64 Pointer Authentication.
9952
9953 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9954
9955         * arm-linux-nat.c: Add include.
9956
9957 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9958
9959         * source-cache.c (source_cache::get_source_lines): Re-read
9960         fullname after calling open_source_file.
9961
9962 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9963
9964         * NEWS: Mention TLS support for FreeBSD.
9965
9966 2019-03-25  Tom Tromey  <tromey@adacore.com>
9967
9968         * minsyms.c (BUNCH_SIZE): Update comment.
9969         (~minimal_symbol_reader): Remove old comment.
9970         (compact_minimal_symbols): Update comment.
9971         (minimal_symbol_reader::install): Remove old comment.  Update
9972         other comments.
9973
9974 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9975
9976         * s390-linux-nat.c: Add include.
9977
9978 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9979
9980         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9981         Call linux_get_hwcap.
9982         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9983         Likewise.
9984         (aarch64_linux_get_hwcap): Remove function.
9985         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9986         declaration.
9987         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9988         linux_get_hwcap.
9989         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9990         * linux-tdep.c (linux_get_hwcap): Add function.
9991         (linux_get_hwcap2): Likewise.
9992         * linux-tdep.h (linux_get_hwcap): Add declaration.
9993         (linux_get_hwcap2): Likewise.
9994         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9995         (ppc_linux_get_hwcap2): Likewise.
9996         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9997         linux_get_hwcap.
9998         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9999         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10000         (ppc_linux_nat_target::read_description): Likewise.
10001         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10002         * s390-linux-nat.c: Likewise.
10003         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10004
10005 2019-03-24  Tom Tromey  <tom@tromey.com>
10006
10007         * ada-lang.c (standard_lookup): Simplify initialization.
10008         (ada_lookup_symbol_nonlocal): Simplify return.
10009         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10010         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10011         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10012         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10013         initialization.
10014         * solib.c (solib_global_lookup): Simplify.
10015         * symtab.c (null_block_symbol): Remove.
10016         (symbol_cache_lookup): Simplify returns.
10017         (lookup_language_this): Simplify returns.
10018         (lookup_symbol_aux): Simplify return.
10019         (lookup_local_symbol): Simplify returns.
10020         (lookup_global_symbol_from_objfile): Simplify return.
10021         (lookup_symbol_in_objfile_symtabs)
10022         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10023         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10024         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10025         * cp-namespace.c (cp_lookup_bare_symbol)
10026         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10027         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10028         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10029         (cp_lookup_symbol_via_imports): Simplify initialization.
10030         (find_symbol_in_baseclass): Likewise.
10031         * symtab.h (null_block_symbol): Remove.
10032         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10033         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10034         (d_lookup_symbol_module): Likewise.
10035         (find_symbol_in_baseclass): Simplify initialization.
10036
10037 2019-03-24  Tom Tromey  <tom@tromey.com>
10038
10039         * expression.h: Don't include symtab.h.
10040         (struct block): Forward declare.
10041
10042 2019-03-24  Tom Tromey  <tom@tromey.com>
10043
10044         * c-exp.y (typebase): Remove casts.
10045         * gdbtypes.c (lookup_unsigned_typename, )
10046         (lookup_signed_typename): Remove cast.
10047         * eval.c (parse_to_comma_and_eval): Remove cast.
10048         * parse.c (write_dollar_variable): Remove cast.
10049         * block.h (struct block) <superblock>: Now const.
10050         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10051         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10052         (map_block): Make "block" const.
10053         * symfile.h (struct quick_symbol_functions)
10054         <map_matching_symbols>: Constify block argument to "callback".
10055         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10056         const.
10057         (find_pc_sect_compunit_symtab): Make "b" const.
10058         (find_symbol_at_address): Likewise.
10059         (search_symbols): Likewise.
10060         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10061         (dw2_debug_names_lookup_symbol): Likewise.
10062         (dw2_map_matching_symbols): Update.
10063         * p-valprint.c (pascal_val_print): Remove "block".
10064         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10065         (aux_add_nonlocal_symbols): Make "block" const.
10066         (resolve_subexp): Remove cast.
10067         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10068         const.
10069         (iterate_over_file_blocks): Likewise.
10070         * f-exp.y (%union) <bval>: Remove.
10071         * coffread.c (patch_opaque_types): Make "b" const.
10072         * spu-tdep.c (spu_catch_start): Make "block" const.
10073         * c-valprint.c (print_unpacked_pointer): Remove "block".
10074         * symmisc.c (dump_symtab_1): Make "b" const.
10075         (block_depth): Make "block" const.
10076         * d-exp.y (%union) <bval>: Remove.
10077         * cp-support.h (cp_lookup_rtti_type): Update.
10078         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10079         * psymtab.c (psym_lookup_symbol): Make "block" const.
10080         (maintenance_check_psymtabs): Make "b" const.
10081         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10082         (enumerate_locals, enumerate_args): Update.
10083         * python/py-symtab.c (stpy_global_block): Make "block" const.
10084         (stpy_static_block): Likewise.
10085         * inline-frame.c (block_starting_point_at): Make "new_block"
10086         const.
10087         * block.c (find_block_in_blockvector): Make return type const.
10088         (blockvector_for_pc_sect): Make "b" const.
10089         (find_block_in_blockvector): Make "b" const.
10090
10091 2019-03-23  Tom Tromey  <tom@tromey.com>
10092
10093         * varobj.c (varobj_create): Update.
10094         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10095         * printcmd.c (display_command, do_one_display): Don't reset
10096         innermost_block.
10097         * parser-defs.h (enum innermost_block_tracker_type): Move to
10098         expression.h.
10099         (innermost_block): Update comment.
10100         * parse.c (parse_exp_1): Add tracker_types parameter.
10101         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10102         tracker_types parameter.  Reset innermost_block.
10103         (parse_exp_in_context): Remove.
10104         (parse_expression_for_completion): Update.
10105         * objfiles.c (~objfile): Don't reset expression_context_block or
10106         innermost_block.
10107         * expression.h (enum innermost_block_tracker_type): Move from
10108         parser-defs.h.
10109         (parse_exp_1): Add tracker_types parameter.
10110         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10111         reset innermost_block.
10112
10113 2019-03-23  Tom Tromey  <tom@tromey.com>
10114
10115         * objfiles.h: Include bcache.h.
10116
10117 2019-03-23  Tom Tromey  <tom@tromey.com>
10118
10119         * linespec.c (get_current_search_block): Use
10120         scoped_restore_current_language.
10121         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10122
10123 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10124             Jiong Wang  <jiong.wang@arm.com>
10125
10126         * aarch64-linux-tdep.c
10127         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10128         section.
10129         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10130
10131 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10132             Jiong Wang  <jiong.wang@arm.com>
10133
10134         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10135         instructions.
10136         (aarch64_analyze_prologue_test): Add PACIASP test.
10137         (aarch64_prologue_prev_register): Unmask PC value.
10138
10139 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10140             Jiong Wang  <jiong.wang@arm.com>
10141
10142         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10143         (aarch64_dwarf2_prev_register): Unmask PC value.
10144         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10145         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10146         DW_CFA_AARCH64_negate_ra_state.
10147         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10148
10149 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10150             Jiong Wang  <jiong.wang@arm.com>
10151
10152         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10153         registers.
10154         (aarch64_pseudo_register_name): Likewise.
10155         (aarch64_pseudo_register_type): Likewise.
10156         (aarch64_pseudo_register_reggroup_p): Likewise.
10157         (aarch64_gdbarch_init): Add pauth registers.
10158         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10159         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10160         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10161         (struct gdbarch_tdep): Add regnum for ra_state.
10162
10163 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10164             Jiong Wang  <jiong.wang@arm.com>
10165
10166         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10167
10168 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10169             Jiong Wang  <jiong.wang@arm.com>
10170
10171         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10172         function.
10173         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10174         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10175         (aarch64_gdbarch_init): Add puth registers.
10176         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10177         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10178         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10179
10180 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10181             Jiong Wang  <jiong.wang@arm.com>
10182
10183         * aarch64-linux-nat.c
10184         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10185         * aarch64-linux-tdep.c
10186         (aarch64_linux_core_read_description): Likewise.
10187         (aarch64_linux_get_hwcap): New function.
10188         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10189         (aarch64_linux_get_hwcap): New declaration.
10190
10191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10192             Jiong Wang  <jiong.wang@arm.com>
10193
10194         * aarch64-linux-nat.c
10195         (aarch64_linux_nat_target::read_description): Add pauth param.
10196         * aarch64-linux-tdep.c
10197         (aarch64_linux_core_read_description): Likewise.
10198         * aarch64-tdep.c (struct target_desc): Add in pauth.
10199         (aarch64_read_description): Add pauth param.
10200         (aarch64_gdbarch_init): Likewise.
10201         * aarch64-tdep.h (aarch64_read_description): Likewise.
10202         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10203         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10204         * features/Makefile: Add new files.
10205         * features/aarch64-pauth.c: New file.
10206         * features/aarch64-pauth.xml: New file.
10207
10208 2019-03-20  Tom Tromey  <tromey@adacore.com>
10209
10210         * infrun.c (handle_inferior_event): Rename from
10211         handle_inferior_event_1.  Create a scoped_value_mark.
10212         (handle_inferior_event): Remove.
10213
10214 2019-03-19  Tom Tromey  <tromey@adacore.com>
10215
10216         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10217         * infrun.h (print_stop_event): Add "displays" parameter.
10218         * infrun.c (print_stop_event): Add "displays" parameter.
10219
10220 2019-03-19  Pedro Alves  <palves@redhat.com>
10221
10222         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10223         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10224         to -1.  Fix TABs vs spaces.
10225         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10226         * tui/tui-out.h (tui_ui_out) Add intro comments.
10227         <m_line, m_start_of_line>: In-class initialize, and add describing
10228         comment.
10229
10230 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10231
10232         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10233         variable names.
10234         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10235
10236 2019-03-18  Pedro Alves  <palves@redhat.com>
10237             Eli Zaretskii <eliz@gnu.org>
10238
10239         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10240         m_line and m_start_of_line.
10241
10242 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10243
10244         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10245         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10246         it returns a newline.  This fixes a regression in TU mode, whereby
10247         the next line is output on the same screen line as the user input.
10248
10249 2019-03-18  Tom Tromey  <tromey@adacore.com>
10250
10251         * minsyms.c (minimal_symbol_reader::install): Remove call to
10252         obstack_blank.
10253
10254 2019-03-18  Pedro Alves  <palves@redhat.com>
10255
10256         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10257         New globals.
10258         (apply_style): New, factored out from ...
10259         (apply_ansi_escape): ... this.  Handle reverse video mode.
10260         (tui_set_reverse_mode): New function.
10261         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10262         * tui/tui-winsource.c (tui_show_source_line): Use
10263         tui_set_reverse_mode instead of setting A_STANDOUT.
10264         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10265         New setter methods.
10266
10267 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10268
10269         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10270         Handle tabs.
10271
10272 2019-03-18  Tom Tromey  <tromey@adacore.com>
10273
10274         * ada-lang.c (empty_array): Add "high" parameter.
10275         (ada_evaluate_subexp): Update.
10276
10277 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10278
10279         * unittests/string_view-selftests.c: Define
10280         _initialize_string_view_selftests unconditionally.
10281
10282 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10283
10284         PR gdb/24350
10285         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10286
10287 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10288
10289         PR gdb/24351
10290         * windows-nat.c (display_selector): Fix format specifiers.
10291
10292 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10293
10294         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10295         tui_refill_source_window instead of tui_refresh_win, to update the
10296         current execution line.  This fixes redisplay of the current line
10297         when stepping through the code with "next" or "step".
10298
10299 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10300
10301         * source-cache.c (source_cache::get_source_lines): Call
10302         find_source_lines to initialize s->nlines.  This fixes vertical
10303         scrolling of TUI source window when the DOWN arrow is pressed.
10304
10305 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10306
10307         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10308         linux-thread-db.c (_initialize_thread_db): Likewise.
10309
10310 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10311
10312         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10313         wclrtoeol in tui_show_source_line".  This reverts changes made in
10314         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10315
10316 2019-03-15  Tom Tromey  <tom@tromey.com>
10317
10318         * symtab.h (struct minimal_symbol): Derive from
10319         general_symbol_info.
10320         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10321         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10322         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10323         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10324         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10325         (MSYMBOL_SEARCH_NAME): Update.
10326         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10327         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10328         * minsyms.c (minimal_symbol_reader::record_full): Update.
10329
10330 2019-03-15  Tom Tromey  <tom@tromey.com>
10331
10332         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10333
10334 2019-03-15  Tom Tromey  <tom@tromey.com>
10335
10336         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10337         unique_xmalloc_ptr.
10338         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10339         Update.
10340         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10341         (build_minimal_symbol_hash_tables)
10342         (minimal_symbol_reader::install): Update.
10343
10344 2019-03-15  Tom Tromey  <tom@tromey.com>
10345
10346         * symtab.c (create_demangled_names_hash): Update.
10347         (symbol_set_names): Update.
10348         * objfiles.h (struct objfile_per_bfd_storage)
10349         <demangled_names_hash>: Now an htab_up.
10350         * objfiles.c (objfile_per_bfd_storage): Simplify.
10351
10352 2019-03-15  Tom Tromey  <tom@tromey.com>
10353
10354         * objfiles.h (struct objfile_per_bfd_storage): Declare
10355         destructor.
10356         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10357         New.
10358         (get_objfile_bfd_data): Use new.  Don't initialize
10359         language_of_main.
10360         (free_objfile_per_bfd_storage): Remove.
10361         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10362
10363 2019-03-15  Tom Tromey  <tom@tromey.com>
10364
10365         * symfile.c (reread_symbols): Update.
10366         * objfiles.c (objfile::objfile): Update.
10367         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10368         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10369         comment.
10370         (minimal_symbol_reader::install): Update.
10371         (terminate_minimal_symbol_table): Remove.
10372         * jit.c (jit_object_close_impl): Update.
10373
10374 2019-03-15  Tom Tromey  <tom@tromey.com>
10375
10376         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10377         initializations.
10378
10379 2019-03-15  Tom Tromey  <tom@tromey.com>
10380
10381         * objfiles.h (struct objfile_per_bfd_storage)
10382         <demangled_hash_languages>: Now a bitset.
10383         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10384         (lookup_minimal_symbol): Update.
10385
10386 2019-03-15  Tom Tromey  <tom@tromey.com>
10387
10388         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10389         Don't return the symbol.
10390         * coffread.c (record_minimal_symbol): Use record_full.
10391
10392 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10393
10394         The MS-Windows port of ncurses fails to switch to a color pair if
10395         one or both of the colors are the implicit default colors.  This
10396         change records the default colors when TUI is initialized, and
10397         then specifies them explicitly when a color pair uses the default
10398         colors.  This allows color styling in TUI mode on MS-Windows.
10399
10400         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10401         ncurses_norm_attr.
10402         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10403         colors in ncurses_norm_attr.
10404         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10405         "none", replace it with the default color recorded in
10406         ncurses_norm_attr.
10407
10408 2019-03-14  Tom Tromey  <tromey@adacore.com>
10409
10410         * source-cache.h (class source_cache) <get_source_lines>: Return
10411         std::string.
10412         * source-cache.c (source_cache::extract_lines): Handle case where
10413         first_pos==npos.  Return std::string.
10414         (source_cache::get_source_lines): Update.
10415
10416 2019-03-14  Tom Tromey  <tromey@adacore.com>
10417
10418         * NEWS: Add item for "style sources" commands.
10419         * source-cache.c (source_cache::get_source_lines): Check
10420         source_styling.
10421         * cli/cli-style.c (source_styling): New global.
10422         (_initialize_cli_style): Add "style sources" commands.
10423         (show_style_sources): New function.
10424         * cli/cli-style.h (source_styling): Declare.
10425
10426 2019-03-14  Pedro Alves  <palves@redhat.com>
10427             Tom Tromey  <tromey@adacore.com>
10428
10429         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10430         * tui/tui-winsource.c (tui_refill_source_window): New function,
10431         from...
10432         (tui_horizontal_source_scroll): ... here.  Move some logic.
10433         * cli/cli-style.c (set_style_enabled): Notify new observable.
10434         * tui/tui-hooks.c (tui_redisplay_source): New function.
10435         (tui_attach_detach_observers): Attach or detach
10436         tui_redisplay_source.
10437         * observable.h (source_styling_changed): New observable.
10438         * observable.c: Define source_styling_changed observable.
10439
10440 2019-03-13  Tom Tromey  <tromey@adacore.com>
10441
10442         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10443         (i386_gnu_nat_target::store_registers): Update.
10444         * target-debug.h (target_debug_print_std_string): New macro.
10445         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10446         * windows-tdep.c (display_one_tib): Update.
10447         * tui/tui-stack.c (tui_make_status_line): Update.
10448         * top.c (print_inferior_quit_action): Update.
10449         * thread.c (thr_try_catch_cmd): Update.
10450         (add_thread_with_info): Update.
10451         (thread_target_id_str): Update.
10452         (thr_try_catch_cmd): Update.
10453         (thread_command): Update.
10454         (thread_find_command): Update.
10455         * record-btrace.c (record_btrace_target::info_record)
10456         (record_btrace_resume_thread, record_btrace_target::resume)
10457         (record_btrace_cancel_resume, record_btrace_step_thread)
10458         (record_btrace_target::wait, record_btrace_target::wait)
10459         (record_btrace_target::wait, record_btrace_target::stop): Update.
10460         * progspace.c (print_program_space): Update.
10461         * process-stratum-target.c
10462         (process_stratum_target::thread_address_space): Update.
10463         * linux-fork.c (linux_fork_mourn_inferior)
10464         (detach_checkpoint_command, info_checkpoints_command)
10465         (linux_fork_context): Update.
10466         (linux_fork_detach): Update.
10467         (class scoped_switch_fork_info): Update.
10468         (delete_checkpoint_command): Update.
10469         * infrun.c (follow_fork_inferior): Update.
10470         (follow_fork_inferior): Update.
10471         (proceed_after_vfork_done): Update.
10472         (handle_vfork_child_exec_or_exit): Update.
10473         (follow_exec): Update.
10474         (displaced_step_prepare_throw): Update.
10475         (displaced_step_restore): Update.
10476         (start_step_over): Update.
10477         (resume_1): Update.
10478         (clear_proceed_status_thread): Update.
10479         (proceed): Update.
10480         (print_target_wait_results): Update.
10481         (do_target_wait): Update.
10482         (context_switch): Update.
10483         (stop_all_threads): Update.
10484         (restart_threads): Update.
10485         (finish_step_over): Update.
10486         (handle_signal_stop): Update.
10487         (switch_back_to_stepped_thread): Update.
10488         (keep_going_pass_signal): Update.
10489         (print_exited_reason): Update.
10490         (normal_stop): Update.
10491         * inferior.c (inferior_pid_to_str): Change return type.
10492         (print_selected_inferior): Update.
10493         (add_inferior): Update.
10494         (detach_inferior): Update.
10495         * dummy-frame.c (fprint_dummy_frames): Update.
10496         * dcache.c (dcache_info_1): Update.
10497         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10498         (btrace_fetch, btrace_clear): Update.
10499         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10500         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10501         type.
10502         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10503         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10504         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10505         * gdbarch.c, gdbarch.h: Rebuild.
10506         * gdbarch.sh (core_pid_to_str): Change return type.
10507         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10508         return type.
10509         (windows_nat_target::pid_to_str): Change return type.
10510         (windows_delete_thread): Update.
10511         (windows_nat_target::attach): Update.
10512         (windows_nat_target::files_info): Update.
10513         * target-delegates.c: Rebuild.
10514         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10515         return type.
10516         (sol_thread_target::pid_to_str): Change return type.
10517         * remote.c (class remote_target) <pid_to_str>: Change return
10518         type.
10519         (remote_target::pid_to_str): Change return type.
10520         (extended_remote_target::attach, remote_target::remote_stop_ns)
10521         (remote_target::remote_notif_remove_queued_reply)
10522         (remote_target::push_stop_reply, remote_target::disable_btrace):
10523         Update.
10524         (extended_remote_target::attach): Update.
10525         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10526         type.
10527         (gdbsim_target::pid_to_str): Change return type.
10528         * ravenscar-thread.c (struct ravenscar_thread_target)
10529         <pid_to_str>: Change return type.
10530         (ravenscar_thread_target::pid_to_str): Change return type.
10531         * procfs.c (class procfs_target) <pid_to_str>: Change return
10532         type.
10533         (procfs_target::pid_to_str): Change return type.
10534         (procfs_target::attach): Update.
10535         (procfs_target::detach): Update.
10536         (procfs_target::fetch_registers): Update.
10537         (procfs_target::store_registers): Update.
10538         (procfs_target::wait): Update.
10539         (procfs_target::files_info): Update.
10540         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10541         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10542         return type.
10543         (nto_procfs_target::pid_to_str): Change return type.
10544         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10545         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10546         return type.
10547         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10548         (exit_lwp): Update.
10549         (attach_proc_task_lwp_callback, get_detach_signal)
10550         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10551         (linux_nat_target::resume, wait_lwp, stop_callback)
10552         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10553         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10554         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10555         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10556         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10557         type.
10558         (inf_ptrace_target::attach): Update.
10559         (inf_ptrace_target::files_info): Update.
10560         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10561         type.
10562         (go32_nat_target::pid_to_str): Change return type.
10563         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10564         (gnu_nat_target::wait): Update.
10565         (gnu_nat_target::wait): Update.
10566         (gnu_nat_target::resume): Update.
10567         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10568         (fbsd_nat_target::wait): Update.
10569         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10570         type.
10571         (darwin_nat_target::attach): Update.
10572         * corelow.c (class core_target) <pid_to_str>: Change return type.
10573         (core_target::pid_to_str): Change return type.
10574         * target.c (normal_pid_to_str): Change return type.
10575         (default_pid_to_str): Likewise.
10576         (target_pid_to_str): Change return type.
10577         (target_translate_tls_address): Update.
10578         (target_announce_detach): Update.
10579         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10580         return type.
10581         (bsd_uthread_target::pid_to_str): Change return type.
10582         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10583         type.
10584         (bsd_kvm_target::pid_to_str): Change return type.
10585         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10586         return type.
10587         (aix_thread_target::pid_to_str): Change return type.
10588         * target.h (struct target_ops) <pid_to_str>: Change return type.
10589         (target_pid_to_str, normal_pid_to_str): Likewise.
10590         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10591         type.
10592         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10593         type.
10594         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10595         return type.
10596         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10597         type.
10598         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10599         type.
10600         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10601         return type.
10602
10603 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10604
10605         * NEWS: Mention that the new default MI version is 3.  Mention
10606         changes to the output of commands and events that deal with
10607         multi-location breakpoints.
10608         * breakpoint.c: Include "mi/mi-out.h".
10609         (print_one_breakpoint): Change output syntax if using MI version
10610         >= 3.
10611         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10612         New.
10613         (mi_multi_location_breakpoint_output_fixed): New.
10614         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10615         (mi_cmd_fix_multi_location_breakpoint_output): New.
10616         (mi_multi_location_breakpoint_output_fixed): New.
10617         * mi/mi-cmds.c (mi_cmds): Register command
10618         -fix-multi-location-breakpoint-output.
10619         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10620         interpreter "mi".
10621
10622 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10623
10624         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10625         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10626         instantiate mi_ui_out based on interpreter name.
10627         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10628         * mi/mi-main.c (mi_load_progress): Likewise.
10629
10630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10631
10632         * NEWS: Combine separate "New targets" sections for 8.3.
10633
10634 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10635
10636         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10637         (ppcfbsd_init_abi): Install gdbarch
10638         "fetch_tls_load_module_address" and "get_thread_local_address"
10639         methods.
10640
10641 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10642
10643         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10644         (riscv_fbsd_init_abi): Install gdbarch
10645         "fetch_tls_load_module_address" and "get_thread_local_address"
10646         methods.
10647
10648 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10649
10650         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10651         (i386fbsd_init_abi): Install gdbarch
10652         "fetch_tls_load_module_address" and "get_thread_local_address"
10653         methods.
10654
10655 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10656
10657         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10658         (amd64fbsd_init_abi): Install gdbarch
10659         "fetch_tls_load_module_address" and "get_thread_local_address"
10660         methods.
10661
10662 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10663
10664         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10665         (struct fbsd_pspace_data): New type.
10666         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10667         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10668         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10669         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10670         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10671
10672 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10673
10674         * gdbtypes.c (lookup_struct_elt): New function.
10675         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10676         * gdbtypes.h (struct struct_elt): New type.
10677         (lookup_struct_elt): New prototype.
10678
10679 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10680
10681         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10682         remove disabled code block.
10683
10684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10685
10686         * gdbarch.sh (get_thread_local_address): New method.
10687         * gdbarch.h, gdbarch.c: Regenerate.
10688         * target.c (target_translate_tls_address): Use
10689         gdbarch_get_thread_local_address if present instead of
10690         target::get_thread_local_address.
10691
10692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10693
10694         * target.h (target::get_thread_local_address): Update comment.
10695
10696 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10697
10698         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10699         objfile->separate_debug_objfile_backlink if not NULL.
10700
10701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10702
10703         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10704         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10705         (amd64bsd_store_inferior_registers): Likewise.
10706         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10707         Enable segment base registers.
10708         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10709         PT_GETFSBASE and PT_GETGSBASE.
10710         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10711         PT_SETGSBASE.
10712         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10713         segment base registers.
10714         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10715
10716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10717
10718         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10719         Update calls to i386_target_description to add 'segments'
10720         parameter.
10721         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10722         add segment base registers.
10723         * arch/i386.c (i386_create_target_description): Add 'segments'
10724         parameter to enable segment base registers.
10725         * arch/i386.h (i386_create_target_description): Likewise.
10726         * features/i386/32bit-segments.xml: New file.
10727         * features/i386/32bit-segments.c: Generate.
10728         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10729         call to i386_target_description to add 'segments' parameter.
10730         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10731         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10732         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10733         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10734         if feature is present.
10735         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10736         Add 'segments' parameter to call to i386_target_description.
10737         (i386_target_description): Add 'segments' parameter to enable
10738         segment base registers.
10739         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10740         to call to i386_target_description.
10741         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10742         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10743         Define I386_NUM_REGS.
10744         (i386_target_description): Add 'segments' parameter to enable
10745         segment base registers.
10746
10747 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10748
10749         PR/24325
10750         * source-cache.c: #undef open and close, to avoid unresolved
10751         externals during linking.
10752
10753 2019-03-12  Tom Tromey  <tromey@adacore.com>
10754
10755         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10756         const.  Add initializers.
10757         (_initialize_remote): Don't initialize ptid globals.
10758
10759 2019-03-12  Pedro Alves  <palves@redhat.com>
10760
10761         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10762
10763 2019-03-12  Pedro Alves  <palves@redhat.com>
10764
10765         * cp-name-parser.y (main): Remove unused 'len' variable.
10766
10767 2019-03-12  Tom Tromey  <tromey@adacore.com>
10768
10769         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10770         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10771
10772 2019-03-12  Tom Tromey  <tromey@adacore.com>
10773
10774         * linux-nat.c (iterate_over_lwps): Update.
10775         (stop_callback): Remove parameter.
10776         (stop_wait_callback, detach_callback, resume_set_callback)
10777         (select_singlestep_lwp_callback, set_ignore_sigint)
10778         (status_callback, resumed_callback, resume_clear_callback)
10779         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10780         data parameter.
10781         (linux_nat_target::detach, linux_nat_target::resume)
10782         (linux_stop_and_wait_all_lwps, select_event_lwp)
10783         (linux_nat_filter_event, linux_nat_wait_1)
10784         (linux_nat_target::kill, linux_nat_target::stop)
10785         (linux_nat_target::stop): Update.
10786         (linux_nat_resume_callback): Change type.
10787         (resume_stopped_resumed_lwps, count_events_callback)
10788         (select_event_lwp_callback): Likewise.
10789         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10790         * arm-linux-nat.c (struct update_registers_data): Remove.
10791         (update_registers_callback): Change type.
10792         (arm_linux_insert_hw_breakpoint1): Update.
10793         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10794         parameter.
10795         (x86_linux_dr_set_addr): Update.
10796         (x86_linux_dr_set_control): Update.
10797         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10798         (iterate_over_lwps): Use gdb::function_view.
10799         * nat/aarch64-linux-hw-point.c (struct
10800         aarch64_dr_update_callback_param): Remove.
10801         (debug_reg_change_callback): Change type.
10802         (aarch64_notify_debug_reg_change): Update.
10803         * s390-linux-nat.c (s390_refresh_per_info): Update.
10804
10805 2019-03-11  Tom Tromey  <tromey@adacore.com>
10806
10807         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10808         redundant assignment to "this_cu".
10809
10810 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10811
10812         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10813
10814 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10815
10816         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10817         from...
10818         (rank_one_type): ... this.
10819
10820 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10821
10822         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10823         from...
10824         (rank_one_type): ... this.
10825
10826 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10827
10828         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10829         from...
10830         (rank_one_type): ... this.
10831
10832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10833
10834         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10835         from...
10836         (rank_one_type): ... this.
10837
10838 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10839
10840         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10841         from...
10842         (rank_one_type): ... this.
10843
10844 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10845
10846         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10847         from...
10848         (rank_one_type): ... this.
10849
10850 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10851
10852         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10853         from...
10854         (rank_one_type): ... this.
10855
10856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10857
10858         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10859         from...
10860         (rank_one_type): ... this.
10861
10862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10863
10864         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10865         from...
10866         (rank_one_type): ... this.
10867
10868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10869
10870         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10871         from...
10872         (rank_one_type): ... this.
10873
10874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10875
10876         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10877         from...
10878         (rank_one_type): ... this.
10879
10880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10881
10882         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10883         from...
10884         (rank_one_type): ... this.
10885
10886 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10887
10888         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10889         inferior-events' shows the example events.
10890
10891 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10892
10893         Support styling on native MS-Windows console
10894
10895         PR/24315
10896         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10897         on MS-Windows if $TERM is not defined.
10898
10899         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10900
10901         * posix-hdep.c (gdb_console_fputs):
10902         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10903         functions.
10904         * ui-file.h (gdb_console_fputs): Add prototype.
10905
10906         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10907         back to fputs only if the former returns zero.
10908
10909 2019-03-07  Tom Tromey  <tom@tromey.com>
10910
10911         * symmisc.c (print_symbol_bcache_statistics): Update.
10912         (print_objfile_statistics): Update.
10913         * symfile.c (allocate_symtab): Update.
10914         * stabsread.c: Don't include bcache.h.
10915         * psymtab.h (struct psymbol_bcache): Don't declare.
10916         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10917         (psymbol_bcache_init, psymbol_bcache_free)
10918         (psymbol_bcache_get_bcache): Don't declare.
10919         * psymtab.c (struct psymbol_bcache): Remove.
10920         (psymtab_storage::psymtab_storage): Update.
10921         (psymtab_storage::~psymtab_storage): Update.
10922         (psymbol_bcache_init, psymbol_bcache_free)
10923         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10924         (add_psymbol_to_bcache): Update.
10925         (allocate_psymtab): Update.
10926         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10927         macro_cache>: No longer pointers.
10928         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10929         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10930         * macrotab.c (macro_bcache): Update.
10931         * macroexp.c: Don't include bcache.h.
10932         * gdbtypes.c (check_types_worklist): Update.
10933         (types_deeply_equal): Remove TRY/CATCH.  Update.
10934         * elfread.c (elf_symtab_read): Update.
10935         * dwarf2read.c: Don't include bcache.h.
10936         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10937         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10938         (print_bcache_statistics, bcache_memory_used): Don't declare.
10939         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10940         methods.  Rename all data members.
10941         * bcache.c (struct bcache): Move to bcache.h.
10942         (bcache::expand_hash_table): Rename from expand_hash_table.
10943         (bcache): Remove.
10944         (bcache::insert): Rename from bcache_full.
10945         (bcache::compare): Rename from bcache_compare.
10946         (bcache_xmalloc): Remove.
10947         (bcache::~bcache): Rename from bcache_xfree.
10948         (bcache::print_statistics): Rename from print_bcache_statistics.
10949         (bcache::memory_used): Rename from bcache_memory_used.
10950
10951 2019-03-07  Pedro Alves  <palves@redhat.com>
10952
10953         * infrun.c (normal_stop): Also check for
10954         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10955
10956 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10957
10958         * f-lang.c (value_from_host_double): Moved to...
10959         * value.c (value_from_host_double): ...here.
10960         * value.h (value_from_host_double): Declare.
10961         * guile/scm-math.c (vlscm_convert_typed_number): Use
10962         value_from_host_double.
10963         (vlscm_convert_number): Likewise.
10964         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10965         * python/py-value.c (convert_value_from_python): Likewise.
10966
10967 2019-03-06  Tom Tromey  <tom@tromey.com>
10968
10969         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10970
10971 2019-03-06  Tom Tromey  <tom@tromey.com>
10972
10973         * utils.h (free_current_contents): Don't declare.
10974         * utils.c (free_current_contents): Remove.
10975
10976 2019-03-06  Tom Tromey  <tom@tromey.com>
10977
10978         * top.c (quit_force): Update.
10979         * main.c (captured_command_loop): Update.
10980         * common/new-op.c (operator new): Update.
10981         * common/common-exceptions.c (struct catcher)
10982         <save_cleanup_chain>: Remove member.
10983         (exceptions_state_mc_init): Update.
10984         (exception_try_scope_entry): Return nullptr.
10985         (exception_try_scope_exit, exception_rethrow)
10986         (throw_exception_sjlj, throw_exception_cxx): Update.
10987         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10988         (all_cleanups, do_cleanups, discard_cleanups)
10989         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10990         (restore_cleanups, restore_final_cleanups): Don't declare.
10991         (do_final_cleanups): Remove parameter.
10992         * common/cleanups.c (cleanup_chain, make_cleanup)
10993         (make_cleanup_dtor, all_cleanups, do_cleanups)
10994         (discard_my_cleanups, discard_cleanups)
10995         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10996         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10997         (null_cleanup): Remove.
10998         (do_final_cleanups): Remove parameter.
10999
11000 2019-03-06  Tom Tromey  <tom@tromey.com>
11001
11002         * remote.c (remote_target::remote_parse_stop_reply): Use
11003         unique_xmalloc_ptr.
11004
11005 2019-03-06  Tom Tromey  <tom@tromey.com>
11006
11007         * stabsread.c (struct stabs_field_info): Rename from field_info.
11008         <list, fnlist>: Add initializers.
11009         <obstack>: New member.
11010         (read_member_functions, read_struct_fields, read_baseclasses):
11011         Allocate on obstack.  Don't use cleanups.
11012         (read_one_struct_field, read_member_functions, read_struct_fields)
11013         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11014         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11015         (read_struct_type): Update.
11016
11017 2019-03-06  Tom Tromey  <tom@tromey.com>
11018
11019         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11020         * common/filestuff.h (make_cleanup_close): Don't declare.
11021         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11022         Remove.
11023
11024 2019-03-06  Tom Tromey  <tom@tromey.com>
11025
11026         * solib-aix.c: Use make_scope_exit.
11027
11028 2019-03-06  Tom Tromey  <tom@tromey.com>
11029
11030         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11031         Use make_scope_exit.
11032
11033 2019-03-06  Tom Tromey  <tom@tromey.com>
11034
11035         * solib-svr4.c (disable_probes_interface): Remove parameter.
11036         (svr4_handle_solib_event): Use make_scope_exit.
11037
11038 2019-03-06  Tom Tromey  <tom@tromey.com>
11039
11040         * remote.c (struct stop_reply_deleter): Remove.
11041         (stop_reply_up): Update.
11042         (struct stop_reply): Derive from notif_event.  Don't typedef.
11043         <regcache>: Now a std::vector.
11044         (stop_reply_xfree): Remove.
11045         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11046         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11047         (remote_target::discard_pending_stop_replies): Use delete.
11048         (remote_target::remote_parse_stop_reply): Update.
11049         (remote_target::process_stop_reply): Update.
11050         * remote-notif.h (struct notif_event): Add virtual destructor.
11051         Remove "dtr" member.
11052         (struct notif_client) <alloc_event>: Return a unique_ptr.
11053         (notif_event_xfree): Don't declare.
11054         (notif_event_up): New typedef.
11055         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11056         (notif_event_xfree, do_notif_event_xfree): Remove.
11057         (remote_notif_state_xfree): Update.
11058
11059 2019-03-06  Tom Tromey  <tom@tromey.com>
11060
11061         * infrun.c (displaced_step_clear_cleanup): Now a
11062         forward_scope_exit type.
11063         (displaced_step_prepare_throw): Update.
11064         (displaced_step_fixup): Update.
11065
11066 2019-03-06  Tom Tromey  <tom@tromey.com>
11067
11068         * inferior.h (class inferior): Update comment.
11069         * gdbthread.h (class thread_info): Update comment.
11070
11071 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11072             Tom Tromey  <tom@tromey.com>
11073
11074         * stabsread.h (struct stab_section_list): Remove.
11075         (coffstab_build_psymtabs): Update.
11076         * dbxread.c (symbuf_sections): Now a std::vector.
11077         (sect_idx): New global.
11078         (fill_symbuf): Update.
11079         (coffstab_build_psymtabs): Change type of stabsects parameter.
11080         Update.
11081         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11082         std::vector.
11083         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11084         (coff_locate_sections): Update.
11085         (coff_symfile_read): Remove cleanups.  Update.
11086         (init_stringtab): Add storage parameter.
11087         (free_stringtab, free_stringtab_cleanup): Remove.
11088         (init_lineno): Add storage parameter.
11089         (free_linetab, free_linetab_cleanup): Remove.
11090
11091 2019-03-06  Pedro Alves  <palves@redhat.com>
11092
11093         * linux-fork.c (fork_info::clobber_regs): Delete.
11094         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11095         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11096         comment.  Adjust.
11097         (scoped_switch_fork_info::scoped_switch_fork_info)
11098         (checkpoint_command, linux_fork_context): Adjust
11099         fork_save_infrun_state calls.
11100
11101 2019-03-06  Pedro Alves  <palves@redhat.com>
11102
11103         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11104         (inf_has_multiple_threads): Return 'bool' and rewrite using
11105         inferior_info::threads().
11106
11107 2019-03-06  Pedro Alves  <palves@redhat.com>
11108
11109         * linux-fork.c: Include <list>.
11110         (fork_list): Now a std::list instance.
11111         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11112         (forks_exist_p, find_last_fork): Adjust.
11113         (new_fork): Delete.
11114         (one_fork_p): New.
11115         (add_fork): Adjust.
11116         (free_fork): Delete, folded into fork_info::~fork_info().
11117         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11118         Adjust.
11119         (init_fork_list): Delete.
11120         (linux_fork_killall, linux_fork_mourn_inferior)
11121         (linux_fork_detach, info_checkpoints_command): Adjust.
11122         (_initialize_linux_fork): No longer call init_fork_list.
11123
11124 2019-03-06  Pedro Alves  <palves@redhat.com>
11125
11126         * linux-fork.c (new_fork): New, split out of ...
11127         (add_fork): ... this.  Return void.  Move "first fork" special
11128         case from here, to ...
11129         (checkpoint_command): ... here.
11130         * linux-linux.h (add_fork): Return void.
11131
11132 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11133
11134         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11135
11136 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11137             Chris January  <chris.january@arm.com>
11138             David Lecomber  <david.lecomber@arm.com>
11139
11140         * f-exp.y: New token, UNOP_INTRINSIC.
11141         (exp): New pattern using UNOP_INTRINSIC token.
11142         (f77_keywords): Add 'abs' keyword.
11143         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11144         (value_from_host_double): New function.
11145         (evaluate_subexp_f): Support UNOP_ABS.
11146
11147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11148
11149         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11150         types.
11151
11152 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11153
11154         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11155         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11156         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11157
11158 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11159
11160         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11161
11162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11163             Chris January  <chris.january@arm.com>
11164
11165         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11166         * f-exp.y: Define 'KIND' token.
11167         (exp): New pattern for KIND expressions.
11168         (ptype): Handle types with a kind extension.
11169         (direct_abs_decl): Extend to spot kind extensions.
11170         (f77_keywords): Add 'kind' to the list.
11171         (push_kind_type): New function.
11172         (convert_to_kind_type): New function.
11173         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11174         * parse.c (operator_length_standard): Likewise.
11175         * parser-defs.h (enum type_pieces): Add tp_kind.
11176         * std-operator.def: Add UNOP_KIND.
11177
11178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11179
11180         * f-exp.y (f_parse): Set yydebug.
11181
11182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11183
11184         * f-lang.c (evaluate_subexp_f): New function.
11185         (exp_descriptor_f): New global.
11186         (f_language_defn): Use exp_descriptor_f instead of
11187         exp_descriptor_standard.
11188
11189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11190
11191         * f-exp.y (struct token): Add comments.
11192         (dot_ops): Remove uppercase versions and the end marker.
11193         (f77_keywords): Likewise.
11194         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11195         entries in the dot_ops array are case insensitive, and use
11196         strncasecmp to compare strings.  Also some whitespace cleanup in
11197         this area.  Similar for the f77_keywords array, except entries in
11198         this list might be case sensitive.
11199
11200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11201
11202         * f-exp.y (struct f77_boolean_val): Add comments.
11203         (boolean_values): Remove uppercase versions, and end marker.
11204         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11205         and use strncasecmp to achieve case insensitivity.  Additionally,
11206         perform whitespace cleanup around this code.
11207
11208 2019-03-06  Tom Tromey  <tromey@adacore.com>
11209
11210         * remote-sim.c (gdbsim_target_open): Use result of
11211         gdb_argv::release.
11212
11213 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11214         Dirk Schubert  <dirk.schubert@arm.com>
11215         Chris January  <chris.january@arm.com>
11216
11217         * eval.c (evaluate_subexp_standard): Call Fortran argument
11218         wrapping logic.
11219         * f-lang.c (struct value): A value which can be passed into a
11220         Fortran function call.
11221         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11222         where appropriate.
11223         (struct type): Value ready for a Fortran function call.
11224         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11225         is needed.
11226         * f-lang.h (fortran_argument_convert): Declaration.
11227         (fortran_preserve_arg_pointer): Declaration.
11228         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11229
11230 2019-03-05  Tom Tromey  <tromey@adacore.com>
11231
11232         * python/py-prettyprint.c (print_string_repr): Remove #if.
11233         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11234
11235 2019-03-05  Tom Tromey  <tromey@adacore.com>
11236
11237         * target.c (the_dummy_target): Move later.  Change type to
11238         "dummy_target".
11239         (initialize_targets): Don't initialize the_dummy_target.
11240
11241 2019-03-05  Tom Tromey  <tromey@adacore.com>
11242
11243         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11244         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11245
11246 2019-03-05  Tom Tromey  <tromey@adacore.com>
11247
11248         * windows-nat.c (windows_nat_target::attach)
11249         (windows_nat_target::detach): Don't call gdb_flush.
11250         * valprint.c (generic_val_print, val_print, val_print_string):
11251         Don't call gdb_flush.
11252         * utils.c (defaulted_query): Don't call gdb_flush.
11253         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11254         * target.c (target_announce_detach): Don't call gdb_flush.
11255         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11256         * remote.c (extended_remote_target::attach): Don't call
11257         gdb_flush.
11258         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11259         * printcmd.c (do_examine): Don't call gdb_flush.
11260         (info_display_command): Don't call gdb_flush.
11261         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11262         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11263         * memattr.c (info_mem_command): Don't call gdb_flush.
11264         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11265         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11266         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11267         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11268         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11269         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11270         (gnu_nat_target::detach): Don't call gdb_flush.
11271         * f-valprint.c (f_val_print): Don't call gdb_flush.
11272         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11273         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11274         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11275         gdb_flush.
11276         * c-valprint.c (c_val_print): Don't call gdb_flush.
11277         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11278
11279 2019-03-05  Tom Tromey  <tromey@adacore.com>
11280
11281         * varobj.c (update_dynamic_varobj_children): Update.
11282         (install_default_visualizer): Use reset, not release.
11283         * value.c (set_internalvar): Update.
11284         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11285         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11286         ATTRIBUTE_UNUSED_RESULT.
11287
11288 2019-03-05  Tom Tromey  <tromey@adacore.com>
11289
11290         * remote.c (class scoped_remote_fd) <release>: Add
11291         ATTRIBUTE_UNUSED_RESULT.
11292
11293 2019-03-05  Tom Tromey  <tromey@adacore.com>
11294
11295         * macroexp.c (struct macro_buffer) <release>: Add
11296         ATTRIBUTE_UNUSED_RESULT.
11297
11298 2019-03-05  Tom Tromey  <tromey@adacore.com>
11299
11300         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11301         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11302         ATTRIBUTE_UNUSED_RESULT.
11303
11304 2019-03-05  Tom Tromey  <tromey@adacore.com>
11305
11306         * common/scoped_fd.h (class scoped_fd) <release>: Add
11307         ATTRIBUTE_UNUSED_RESULT.
11308
11309 2019-03-05  Tom Tromey  <tromey@adacore.com>
11310
11311         * parser-defs.h (struct parser_state) <release>: Add
11312         ATTRIBUTE_UNUSED_RESULT.
11313
11314 2019-03-05  Tom Tromey  <tromey@adacore.com>
11315
11316         * utils.h (class gdb_argv) <release>: Add
11317         ATTRIBUTE_UNUSED_RESULT.
11318         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11319
11320 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11321
11322         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11323         for-loop range, to avoid compiler warnings.
11324
11325         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11326         avoid compiler warnings about unused variables.
11327
11328         * NEWS: Mention end of support for native debugging on MS-Windows
11329         before XP.
11330
11331         PR gdb/24292
11332         * common/netstuff.c:
11333         * gdbserver/gdbreplay.c
11334         * gdbserver/remote-utils.c:
11335         * ser-tcp.c:
11336         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11337         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11338         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11339         'getaddrinfo' and 'freeaddrinfo' were not available before
11340         Windows XP, and mingw.org's MinGW headers by default define
11341         _WIN32_WINNT to 0x500.
11342
11343 2019-03-01  Gary Benson <gbenson@redhat.com>
11344
11345         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11346
11347 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11348             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11349
11350         PR gdb/8527
11351         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11352         set_sigint_trap, clear_sigint_trap.
11353
11354 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11355
11356         * target.c (target_detach): Clear the regcache and the
11357         frame cache.
11358
11359 2019-02-27  Pedro Alves  <palves@redhat.com>
11360
11361         * utils.c (set_screen_size): When we cap the height/width sizes,
11362         tweak the corresponding command variable to show "unlimited":
11363
11364 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11365             Pedro Alves  <palves@redhat.com>
11366
11367         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11368         before calling rl_set_screen_size.
11369
11370 2019-02-27  Tom Tromey  <tromey@adacore.com>
11371
11372         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11373         define.
11374         * python/py-value.c: Remove Python 2.4 workaround.
11375         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11376         workaround.
11377         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11378         Python 2.4 workaround.
11379         * python/python-internal.h: Remove Python 2.4 comment.
11380         (Py_ssize_t): Don't define.
11381         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11382         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11383         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11384         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11385         * python/python.c (do_start_initialization): Remove Python 2.4
11386         workaround.
11387         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11388         (print_children): Remove Python 2.4 workaround.
11389         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11390         workaround.
11391         (CHARBUFFERPROC_NAME): Remove.
11392         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11393         Python 2.4 workaround.
11394
11395 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11396
11397         * NEWS: Note minimum Python version.
11398
11399 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11400
11401         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11402         code from these functions.  Remove corresponding ifdefs.  Use
11403         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11404         Remove gotos and target of gotos.
11405         (infpy_search_memory): Likewise.
11406
11407 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11408
11409         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11410         (hppa_gdbarch_init): Don't register deleted functions with
11411         gdbarch.
11412
11413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11414
11415         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11416         (h8300_unwind_sp): Delete.
11417         (h8300_dummy_id): Delete.
11418         (h8300_gdbarch_init): Don't register deleted functions with
11419         gdbarch.
11420
11421 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11422
11423         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11424         (ft32_unwind_pc): Delete.
11425         (ft32_unwind_sp): Delete.
11426         (ft32_gdbarch_init): Don't register deleted functions with
11427         gdbarch.
11428
11429 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11430
11431         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11432         (frv_unwind_pc): Delete.
11433         (frv_unwind_sp): Delete.
11434         (frv_gdbarch_init): Don't register deleted functions with
11435         gdbarch.
11436
11437 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11438
11439         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11440         (riscv_unwind_pc): Delete.
11441         (riscv_unwind_sp): Delete.
11442         (riscv_gdbarch_init): Don't register deleted functions with
11443         gdbarch.
11444
11445 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11446
11447         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11448         (csky_unwind_pc): Delete.
11449         (csky_unwind_sp): Delete.
11450         (csky_gdbarch_init): Don't register deleted functions with
11451         gdbarch.
11452
11453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11454
11455         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11456         (cris_unwind_pc): Delete.
11457         (cris_unwind_sp): Delete.
11458         (cris_gdbarch_init): Don't register deleted functions with
11459         gdbarch.
11460
11461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11462
11463         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11464         (bfin_unwind_pc): Delete.
11465         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11466
11467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11468
11469         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11470         (arm_unwind_pc): Delete.
11471         (arm_unwind_sp): Delete.
11472         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11473
11474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11475
11476         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11477         (arc_unwind_pc): Delete.
11478         (arc_unwind_sp): Delete.
11479         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11480
11481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11482
11483         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11484         (alpha_unwind_pc): Delete.
11485         (alpha_gdbarch_init): Don't register deleted functions with
11486         gdbarch.
11487
11488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11489
11490         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11491         (aarch64_unwind_pc): Delete.
11492         (aarch64_unwind_sp): Delete.
11493         (aarch64_gdbarch_init): Don't register deleted functions with
11494         gdbarch.
11495
11496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11497
11498         * gdbtypes.c (type_align): Don't consider static members when
11499         computing structure alignment.
11500
11501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11502
11503         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11504         return 0 for other types.
11505         * arch-utils.c (default_type_align): Always return 0.
11506         * gdbarch.h: Regenerate.
11507         * gdbarch.sh (type_align): Extend comment.
11508         * gdbtypes.c (type_align): Add additional comments, always call
11509         gdbarch_type_align before applying the default rules.
11510         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11511         generic code will then apply a suitable default.
11512         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11513         types, return 0 for other types.
11514
11515 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11516
11517         * NEWS: Create a new section for the next release branch.
11518         Rename the section of the current branch, now that it has
11519         been cut.
11520
11521 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11522
11523         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11524         * version.in: Bump version to 8.3.50.DATE-git.
11525
11526 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11527
11528         * aix-thread.c (ptid_cmp): Remove unused variable.
11529         (get_signaled_thread): Likewise.
11530         (store_regs_user_thread): Likewise.
11531         (store_regs_kernel_thread): Likewise.
11532         (fetch_regs_kernel_thread): Remove shadowed variable.
11533
11534 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11535
11536         * features/riscv/32bit-cpu.xml: Add register numbers.
11537         * features/riscv/32bit-fpu.c: Regenerate.
11538         * features/riscv/32bit-fpu.xml: Add register numbers.
11539         * features/riscv/64bit-cpu.xml: Add register numbers.
11540         * features/riscv/64bit-fpu.c: Regenerate.
11541         * features/riscv/64bit-fpu.xml: Add register numbers.
11542
11543 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11544
11545         * NEWS: Mention two argument form of gdb.Value constructor.
11546         * python/py-value.c (convert_buffer_and_type_to_value): New
11547         function.
11548         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11549         Add support for handling an optional second argument.  Call
11550         convert_buffer_and_type_to_value as appropriate.
11551         * python/python-internal.h (Py_buffer_deleter): New struct.
11552         (Py_buffer_up): New typedef.
11553
11554 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11555
11556         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11557         instead of releasing ownership.
11558
11559 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11560
11561         * dwarf2read.c (open_and_init_dwp_file): Call
11562         elf_numsections instead of bfd_count_sections to initialize
11563         dwp_file->num_sections.
11564
11565 2019-02-25  Tom Tromey  <tromey@adacore.com>
11566
11567         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11568
11569 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11570
11571         * gcore.in: Add '--readnever' option when invoking GDB.
11572
11573 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11574
11575         * MAINTAINERS: Update my email address.
11576
11577 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11578
11579         * build-id.c (build_id_to_debug_bfd_1): New function.
11580         (build_id_to_debug_bfd): Look for separate debug file in
11581         sysroot.
11582
11583 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11584
11585         * gdbarch.sh: Update the copyright year range that is placed into
11586         generated files.
11587
11588 2019-02-22  Keith Seitz  <keiths@redhat.com>
11589
11590         PR symtab/23853
11591         * linespec.c (create_sals_line_offset): Search for the default
11592         symtab's filename instead of its fullname.
11593
11594 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11595
11596         * NEWS: Update style defaults.
11597
11598 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11599
11600         * main.c (captured_main_1): Disable styling in batch mode.
11601
11602 2019-02-20  Tom Tromey  <tom@tromey.com>
11603
11604         * symtab.c (symtab_symbol_info): Fix typos.
11605
11606 2019-02-20  Tom Tromey  <tromey@adacore.com>
11607
11608         * findcmd.c (_initialize_mem_search): Use upper case for
11609         metasyntactic variables.
11610
11611 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11612
11613         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11614         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11615
11616 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11617
11618         * top.h (source_file_name): Change to std::string.
11619         * top.c (source_file_name): Likewise.
11620         (command_line_input): Adjust.
11621         * cli/cli-script.c (script_from_file): Adjust.
11622
11623 2019-02-19  Tom Tromey  <tromey@adacore.com>
11624
11625         * ravenscar-thread.c
11626         (ravenscar_thread_target::update_thread_list): Don't call
11627         ada_build_task_list.
11628         * ada-lang.h (ada_build_task_list): Don't declare.
11629         * ada-tasks.c (struct ada_tasks_inferior_data)
11630         <task_list_valid_p>: Now bool.
11631         (read_known_tasks, ada_task_list_changed)
11632         (ada_tasks_invalidate_inferior_data): Update.
11633         (read_known_tasks_array): Return bool.
11634         (read_known_tasks_list): Likewise.
11635         (read_known_tasks): Return void.
11636         (ada_build_task_list): Now static.
11637
11638 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11639
11640         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11641         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11642
11643 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11644
11645         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11646         variant for ada_tasks_pspace_data_handle and
11647         ada_tasks_inferior_data_handle.
11648         (ada_tasks_pspace_data_cleanup): New function.
11649         (ada_tasks_inferior_data_cleanup): New function.
11650
11651 2019-02-17  Tom Tromey  <tom@tromey.com>
11652
11653         * macrotab.h (macro_source_fullname): Return a std::string.
11654         * macrotab.c (macro_include, check_for_redefinition)
11655         (macro_undef, macro_lookup_definition, foreach_macro)
11656         (foreach_macro_in_scope): Update.
11657         (macro_source_fullname): Return a std::string.
11658         * macrocmd.c (show_pp_source_pos): Update.
11659
11660 2019-02-17  Tom Tromey  <tom@tromey.com>
11661
11662         * macrocmd.c (show_pp_source_pos): Style the file names.
11663
11664 2019-02-17  Tom Tromey  <tom@tromey.com>
11665
11666         PR tui/24197:
11667         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11668
11669 2019-02-17  Tom Tromey  <tom@tromey.com>
11670
11671         * ada-lang.c (user_select_syms): Use filtered printing.
11672         * utils.c (wrap_style): New global.
11673         (desired_style): Remove.
11674         (emit_style_escape): Add stream parameter.
11675         (set_output_style, reset_terminal_style, prompt_for_continue):
11676         Update.
11677         (flush_wrap_buffer): Only flush gdb_stdout.
11678         (wrap_here): Set wrap_style.
11679         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11680         treat escape sequences as a character.  Change when wrap buffer is
11681         flushed.
11682         (fputs_styled): Do not set the output style when the default is
11683         requested.
11684         * ui-style.h (struct ui_file_style) <is_default>: New method.
11685         * source.c (print_source_lines_base): Emit escape sequences in one
11686         piece.
11687
11688 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11689
11690         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11691         integers and enumeration types.
11692
11693 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11694
11695         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11696         instead of lookup_symbol_in_language
11697         (do_exact_match): New function.
11698         (ada_get_symbol_name_matcher): Return do_exact_match when
11699         doing a verbatim match.
11700
11701 2019-02-15  Tom Tromey  <tromey@adacore.com>
11702
11703         * ravenscar-thread.c (ravenscar_thread_target::resume)
11704         (ravenscar_thread_target::wait): Special case wildcard requests.
11705
11706 2019-02-15  Tom Tromey  <tromey@adacore.com>
11707
11708         * ravenscar-thread.c (base_ptid): Remove.
11709         (struct ravenscar_thread_target) <close>: New method.
11710         <m_base_ptid>: New member.
11711         <update_inferior_ptid, active_task, task_is_currently_active,
11712         runtime_initialized>: Declare methods.
11713         <ravenscar_thread_target>: Add constructor.
11714         (ravenscar_thread_target::task_is_currently_active)
11715         (ravenscar_thread_target::update_inferior_ptid)
11716         (ravenscar_runtime_initialized): Rename.  Now methods.
11717         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11718         (ravenscar_thread_target::update_thread_list): Update.
11719         (ravenscar_thread_target::active_task): Now method.
11720         (ravenscar_thread_target::store_registers)
11721         (ravenscar_thread_target::prepare_to_store)
11722         (ravenscar_thread_target::prepare_to_store)
11723         (ravenscar_thread_target::mourn_inferior): Update.
11724         (ravenscar_inferior_created): Use "new" to create target.
11725         (ravenscar_thread_target::get_ada_task_ptid): Update.
11726         (_initialize_ravenscar): Don't initialize base_ptid.
11727         (ravenscar_ops): Remove global.
11728
11729 2019-02-15  Tom Tromey  <tromey@adacore.com>
11730
11731         * target.h (push_target): Declare new overload.
11732         * target.c (push_target): New overload, taking an rvalue reference.
11733         * remote.c (remote_target::open_1): Use push_target overload.
11734         * corelow.c (core_target_open): Use push_target overload.
11735
11736 2019-02-15  Tom Tromey  <tromey@adacore.com>
11737
11738         * ravenscar-thread.c (is_ravenscar_task)
11739         (ravenscar_task_is_currently_active): Return bool.
11740         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11741         (_initialize_ravenscar): Remove "(void)".
11742         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11743         Return bool.
11744
11745 2019-02-15  Tom Tromey  <tromey@adacore.com>
11746
11747         * ravenscar-thread.c (ravenscar_runtime_initializer)
11748         (has_ravenscar_runtime, get_running_thread_id)
11749         (ravenscar_thread_target::resume): Fix indentation.
11750
11751 2019-02-15  Tom Tromey  <tromey@adacore.com>
11752
11753         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11754         from ravenscar_arch_ops.
11755         (sparc_ravenscar_ops::fetch_registers)
11756         (sparc_ravenscar_ops::store_registers): Now methods.
11757         (sparc_ravenscar_prepare_to_store): Remove.
11758         (sparc_ravenscar_ops): Redefine.
11759         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11760         methods and destructor.  Remove members.
11761         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11762         (ravenscar_thread_target::store_registers)
11763         (ravenscar_thread_target::prepare_to_store): Update.
11764         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11765         Remove.
11766         (struct ppc_ravenscar_powerpc_ops): Derive from
11767         ravenscar_arch_ops.
11768         (ppc_ravenscar_powerpc_ops::fetch_registers)
11769         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11770         (ppc_ravenscar_powerpc_ops): Redefine.
11771         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11772         (ppc_ravenscar_e500_ops::fetch_registers)
11773         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11774         (ppc_ravenscar_e500_ops): Redefine.
11775         * aarch64-ravenscar-thread.c
11776         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11777         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11778         (aarch64_ravenscar_fetch_registers)
11779         (aarch64_ravenscar_store_registers): Now methods.
11780         (aarch64_ravenscar_ops): Redefine.
11781
11782 2019-02-15  Tom Tromey  <tromey@adacore.com>
11783
11784         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11785         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11786         (ravenscar_thread_target::stopped_by_watchpoint)
11787         (ravenscar_thread_target::stopped_data_address)
11788         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11789
11790 2019-02-15  Tom Tromey  <tromey@adacore.com>
11791
11792         * ravenscar-thread.c: Fix some typos.
11793
11794 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11795             Tom Tromey  <tromey@adacore.com>
11796
11797         * ada-lang.c (ada_exception_sal): Change addr_string to a
11798         std::string.
11799         (create_ada_exception_catchpoint): Update.
11800
11801 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11802             Tom Tromey  <tromey@adacore.com>
11803
11804         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11805         (bp_location_ops): Remove.
11806         (base_breakpoint_allocate_location): Update.
11807         (free_bp_location): Update.
11808         * ada-lang.c (class ada_catchpoint_location)
11809         <ada_catchpoint_location>: Remove ops parameter.
11810         (ada_catchpoint_location_dtor): Remove.
11811         (ada_catchpoint_location_ops): Remove.
11812         (allocate_location_exception): Update.
11813         * breakpoint.h (struct bp_location_ops): Remove.
11814         (class bp_location) <bp_location>: Remove bp_location_ops
11815         parameter.
11816         <~bp_location>: Add destructor.
11817         <ops>: Remove.
11818
11819 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11820             Pedro Alves  <palves@redhat.com>
11821
11822         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11823         'PATH_MAX'.
11824
11825 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11826             Samuel Thibault  <samuel.thibault@gnu.org>
11827             Thomas Schwinge  <thomas@codesourcery.com>
11828
11829         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11830         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11831
11832 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11833
11834         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11835         (check_empty): Use "const char *".
11836
11837         * gnu-nat.c (gnu_nat_target::detach): Instead of
11838         'detach_inferior (pid)' call
11839         'detach_inferior (find_inferior_pid (pid))'.
11840
11841         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11842         'nat/fork-inferior.o'.
11843         * gnu-nat.c: #include "nat/fork-inferior.h".
11844
11845         * gnu-nat.c (gnu_nat_target::detach): Instead of
11846         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11847         * gnu-nat.h: #include "inf-child.h".
11848         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11849         'i386_gnu_nat_target::fetch_registers'.
11850         (gnu_store_registers): Rename/move to
11851         'i386_gnu_nat_target::store_registers'.
11852
11853         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11854         * gnu-nat.h (mach_thread_info): New function.
11855         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11856
11857         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11858
11859 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11860
11861         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11862
11863 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11864
11865         * windows-nat.c (windows_add_thread): Add new parameter
11866         "main_thread_p" with default value set to false.  Update
11867         function documentation as well as all callers.
11868         (windows_delete_thread): Likewise.
11869         (fake_create_process): Update call to windows_add_thread.
11870         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11871         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11872         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11873         call to windows_delete_thread.
11874
11875 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11876
11877         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11878
11879 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11880
11881         * symfile.c (find_separate_debug_file): Use canonical path of
11882         sysroot with child_path instead of gdb_sysroot if it is valid.
11883
11884 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11885
11886         * symfile.c (find_separate_debug_file): Use child_path to
11887         determine if an object file is under a sysroot.
11888
11889 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11890
11891         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11892         unittests/child-path-selftests.c.
11893         * common/pathstuff.c (child_path): New function.
11894         * common/pathstuff.h (child_path): New prototype.
11895         * unittests/child-path-selftests.c: New file.
11896
11897 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11898
11899         * symfile.c (find_separate_debug_file): Look for separate debug
11900         files in debug directories under the sysroot.
11901
11902 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11903
11904         * symtab.h (struct minimal_symbol data_p): New const method.
11905         (struct minimal_symbol text_p): Likewise.
11906         * symtab.c (output_source_filename): Use file name style
11907         to print file name.
11908         (print_symbol_info): Likewise.
11909         (print_msymbol_info): Use address style to print addresses.
11910         Use function name style to print executable text symbols.
11911         (expand_symtab_containing_pc): Use data_p.
11912         (find_pc_sect_compunit_symtab): Likewise.
11913
11914 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11915
11916         * breakpoint.c (describe_other_breakpoints): Use address style
11917         to print addresses.
11918         (say_where): Likewise.
11919
11920 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11921
11922         * ada-typeprint.c (print_func_type): Print function name
11923         style to print function name.
11924         * c-typeprint.c (c_print_type_1): Likewise.
11925
11926 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11927
11928         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11929         for execve.
11930
11931 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11932
11933         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11934         type_stack.
11935
11936 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11937
11938         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11939         TYPE_CODE_REF types.
11940
11941 2019-02-08  Jim Wilson  <jimw@sifive.com>
11942
11943         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11944         (riscv_linux_fregset): New.
11945         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11946
11947 2019-02-07  Tom Tromey  <tom@tromey.com>
11948
11949         * thread.c (thread_cancel_execution_command): Update.
11950         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11951         methods.
11952         (struct thread_fsm_ops): Remove.
11953         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11954         (thread_fsm_should_stop, thread_fsm_return_value)
11955         (thread_fsm_set_finished, thread_fsm_finished_p)
11956         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11957         Don't declare.
11958         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11959         * infrun.c (clear_proceed_status_thread)
11960         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11961         (print_stop_event): Update.
11962         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11963         Add constructor.
11964         (step_command_fsm_ops): Remove.
11965         (new_step_command_fsm): Remove.
11966         (step_1): Update.
11967         (step_command_fsm::should_stop): Rename from
11968         step_command_fsm_should_stop.
11969         (step_command_fsm::clean_up): Rename from
11970         step_command_fsm_clean_up.
11971         (step_command_fsm::do_async_reply_reason): Rename from
11972         step_command_fsm_async_reply_reason.
11973         (struct until_next_fsm): Inherit from thread_fsm.  Add
11974         constructor.
11975         (until_next_fsm_ops): Remove.
11976         (new_until_next_fsm): Remove.
11977         (until_next_fsm::should_stop): Rename from
11978         until_next_fsm_should_stop.
11979         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11980         (until_next_fsm::do_async_reply_reason): Rename from
11981         until_next_fsm_async_reply_reason.
11982         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11983         constructor.  Change type of breakpoint.
11984         (finish_command_fsm_ops): Remove.
11985         (new_finish_command_fsm): Remove.
11986         (finish_command_fsm::should_stop): Rename from
11987         finish_command_fsm_should_stop.
11988         (finish_command_fsm::clean_up): Rename from
11989         finish_command_fsm_clean_up.
11990         (finish_command_fsm::return_value): Rename from
11991         finish_command_fsm_return_value.
11992         (finish_command_fsm::do_async_reply_reason): Rename from
11993         finish_command_fsm_async_reply_reason.
11994         (finish_command): Update.
11995         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11996         Add constructor.
11997         (call_thread_fsm_ops): Remove.
11998         (call_thread_fsm::call_thread_fsm): Rename from
11999         new_call_thread_fsm.
12000         (call_thread_fsm::should_stop): Rename from
12001         call_thread_fsm_should_stop.
12002         (call_thread_fsm::should_notify_stop): Rename from
12003         call_thread_fsm_should_notify_stop.
12004         (run_inferior_call, call_function_by_hand_dummy): Update.
12005         * cli/cli-interp.c (should_print_stop_to_console): Update.
12006         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12007         Add constructor.  Change type of location_breakpoint,
12008         caller_breakpoint.
12009         (until_break_fsm_ops): Remove.
12010         (new_until_break_fsm): Remove.
12011         (until_break_fsm::should_stop): Rename from
12012         until_break_fsm_should_stop.
12013         (until_break_fsm::clean_up): Rename from
12014         until_break_fsm_clean_up.
12015         (until_break_fsm::do_async_reply_reason): Rename from
12016         until_break_fsm_async_reply_reason.
12017         (until_break_command): Update.
12018         * thread-fsm.c: Remove.
12019         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12020
12021 2019-02-07  Tom Tromey  <tom@tromey.com>
12022
12023         * yy-remap.h: Add include guard.
12024         * xtensa-tdep.h: Add include guard.
12025         * xcoffread.h: Rename include guard.
12026         * varobj-iter.h: Add include guard.
12027         * tui/tui.h: Rename include guard.
12028         * tui/tui-winsource.h: Rename include guard.
12029         * tui/tui-wingeneral.h: Rename include guard.
12030         * tui/tui-windata.h: Rename include guard.
12031         * tui/tui-win.h: Rename include guard.
12032         * tui/tui-stack.h: Rename include guard.
12033         * tui/tui-source.h: Rename include guard.
12034         * tui/tui-regs.h: Rename include guard.
12035         * tui/tui-out.h: Rename include guard.
12036         * tui/tui-layout.h: Rename include guard.
12037         * tui/tui-io.h: Rename include guard.
12038         * tui/tui-hooks.h: Rename include guard.
12039         * tui/tui-file.h: Rename include guard.
12040         * tui/tui-disasm.h: Rename include guard.
12041         * tui/tui-data.h: Rename include guard.
12042         * tui/tui-command.h: Rename include guard.
12043         * tic6x-tdep.h: Add include guard.
12044         * target/waitstatus.h: Rename include guard.
12045         * target/wait.h: Rename include guard.
12046         * target/target.h: Rename include guard.
12047         * target/resume.h: Rename include guard.
12048         * target-float.h: Rename include guard.
12049         * stabsread.h: Add include guard.
12050         * rs6000-tdep.h: Add include guard.
12051         * riscv-fbsd-tdep.h: Add include guard.
12052         * regformats/regdef.h: Rename include guard.
12053         * record.h: Rename include guard.
12054         * python/python.h: Rename include guard.
12055         * python/python-internal.h: Rename include guard.
12056         * python/py-stopevent.h: Rename include guard.
12057         * python/py-ref.h: Rename include guard.
12058         * python/py-record.h: Rename include guard.
12059         * python/py-record-full.h: Rename include guard.
12060         * python/py-record-btrace.h: Rename include guard.
12061         * python/py-instruction.h: Rename include guard.
12062         * python/py-events.h: Rename include guard.
12063         * python/py-event.h: Rename include guard.
12064         * procfs.h: Add include guard.
12065         * proc-utils.h: Add include guard.
12066         * p-lang.h: Add include guard.
12067         * or1k-tdep.h: Rename include guard.
12068         * observable.h: Rename include guard.
12069         * nto-tdep.h: Rename include guard.
12070         * nat/x86-linux.h: Rename include guard.
12071         * nat/x86-linux-dregs.h: Rename include guard.
12072         * nat/x86-gcc-cpuid.h: Add include guard.
12073         * nat/x86-dregs.h: Rename include guard.
12074         * nat/x86-cpuid.h: Rename include guard.
12075         * nat/ppc-linux.h: Rename include guard.
12076         * nat/mips-linux-watch.h: Rename include guard.
12077         * nat/linux-waitpid.h: Rename include guard.
12078         * nat/linux-ptrace.h: Rename include guard.
12079         * nat/linux-procfs.h: Rename include guard.
12080         * nat/linux-osdata.h: Rename include guard.
12081         * nat/linux-nat.h: Rename include guard.
12082         * nat/linux-namespaces.h: Rename include guard.
12083         * nat/linux-btrace.h: Rename include guard.
12084         * nat/glibc_thread_db.h: Rename include guard.
12085         * nat/gdb_thread_db.h: Rename include guard.
12086         * nat/gdb_ptrace.h: Rename include guard.
12087         * nat/fork-inferior.h: Rename include guard.
12088         * nat/amd64-linux-siginfo.h: Rename include guard.
12089         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12090         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12091         * nat/aarch64-linux.h: Rename include guard.
12092         * nat/aarch64-linux-hw-point.h: Rename include guard.
12093         * mn10300-tdep.h: Add include guard.
12094         * mips-linux-tdep.h: Add include guard.
12095         * mi/mi-parse.h: Rename include guard.
12096         * mi/mi-out.h: Rename include guard.
12097         * mi/mi-main.h: Rename include guard.
12098         * mi/mi-interp.h: Rename include guard.
12099         * mi/mi-getopt.h: Rename include guard.
12100         * mi/mi-console.h: Rename include guard.
12101         * mi/mi-common.h: Rename include guard.
12102         * mi/mi-cmds.h: Rename include guard.
12103         * mi/mi-cmd-break.h: Rename include guard.
12104         * m2-lang.h: Add include guard.
12105         * location.h: Rename include guard.
12106         * linux-record.h: Rename include guard.
12107         * linux-nat.h: Add include guard.
12108         * linux-fork.h: Add include guard.
12109         * i386-darwin-tdep.h: Rename include guard.
12110         * hppa-linux-offsets.h: Add include guard.
12111         * guile/guile.h: Rename include guard.
12112         * guile/guile-internal.h: Rename include guard.
12113         * gnu-nat.h: Rename include guard.
12114         * gdb-stabs.h: Rename include guard.
12115         * frv-tdep.h: Add include guard.
12116         * f-lang.h: Add include guard.
12117         * event-loop.h: Add include guard.
12118         * darwin-nat.h: Rename include guard.
12119         * cp-abi.h: Rename include guard.
12120         * config/sparc/nm-sol2.h: Rename include guard.
12121         * config/nm-nto.h: Rename include guard.
12122         * config/nm-linux.h: Add include guard.
12123         * config/i386/nm-i386gnu.h: Rename include guard.
12124         * config/djgpp/nl_types.h: Rename include guard.
12125         * config/djgpp/langinfo.h: Rename include guard.
12126         * compile/gcc-cp-plugin.h: Add include guard.
12127         * compile/gcc-c-plugin.h: Add include guard.
12128         * compile/compile.h: Rename include guard.
12129         * compile/compile-object-run.h: Rename include guard.
12130         * compile/compile-object-load.h: Rename include guard.
12131         * compile/compile-internal.h: Rename include guard.
12132         * compile/compile-cplus.h: Rename include guard.
12133         * compile/compile-c.h: Rename include guard.
12134         * common/xml-utils.h: Rename include guard.
12135         * common/x86-xstate.h: Rename include guard.
12136         * common/version.h: Rename include guard.
12137         * common/vec.h: Rename include guard.
12138         * common/tdesc.h: Rename include guard.
12139         * common/selftest.h: Rename include guard.
12140         * common/scoped_restore.h: Rename include guard.
12141         * common/scoped_mmap.h: Rename include guard.
12142         * common/scoped_fd.h: Rename include guard.
12143         * common/safe-iterator.h: Rename include guard.
12144         * common/run-time-clock.h: Rename include guard.
12145         * common/refcounted-object.h: Rename include guard.
12146         * common/queue.h: Rename include guard.
12147         * common/ptid.h: Rename include guard.
12148         * common/print-utils.h: Rename include guard.
12149         * common/preprocessor.h: Rename include guard.
12150         * common/pathstuff.h: Rename include guard.
12151         * common/observable.h: Rename include guard.
12152         * common/netstuff.h: Rename include guard.
12153         * common/job-control.h: Rename include guard.
12154         * common/host-defs.h: Rename include guard.
12155         * common/gdb_wait.h: Rename include guard.
12156         * common/gdb_vecs.h: Rename include guard.
12157         * common/gdb_unlinker.h: Rename include guard.
12158         * common/gdb_unique_ptr.h: Rename include guard.
12159         * common/gdb_tilde_expand.h: Rename include guard.
12160         * common/gdb_sys_time.h: Rename include guard.
12161         * common/gdb_string_view.h: Rename include guard.
12162         * common/gdb_splay_tree.h: Rename include guard.
12163         * common/gdb_setjmp.h: Rename include guard.
12164         * common/gdb_ref_ptr.h: Rename include guard.
12165         * common/gdb_optional.h: Rename include guard.
12166         * common/gdb_locale.h: Rename include guard.
12167         * common/gdb_assert.h: Rename include guard.
12168         * common/filtered-iterator.h: Rename include guard.
12169         * common/filestuff.h: Rename include guard.
12170         * common/fileio.h: Rename include guard.
12171         * common/environ.h: Rename include guard.
12172         * common/common-utils.h: Rename include guard.
12173         * common/common-types.h: Rename include guard.
12174         * common/common-regcache.h: Rename include guard.
12175         * common/common-inferior.h: Rename include guard.
12176         * common/common-gdbthread.h: Rename include guard.
12177         * common/common-exceptions.h: Rename include guard.
12178         * common/common-defs.h: Rename include guard.
12179         * common/common-debug.h: Rename include guard.
12180         * common/cleanups.h: Rename include guard.
12181         * common/buffer.h: Rename include guard.
12182         * common/btrace-common.h: Rename include guard.
12183         * common/break-common.h: Rename include guard.
12184         * cli/cli-utils.h: Rename include guard.
12185         * cli/cli-style.h: Rename include guard.
12186         * cli/cli-setshow.h: Rename include guard.
12187         * cli/cli-script.h: Rename include guard.
12188         * cli/cli-interp.h: Rename include guard.
12189         * cli/cli-decode.h: Rename include guard.
12190         * cli/cli-cmds.h: Rename include guard.
12191         * charset-list.h: Add include guard.
12192         * buildsym-legacy.h: Rename include guard.
12193         * bfin-tdep.h: Add include guard.
12194         * ax.h: Rename include guard.
12195         * arm-linux-tdep.h: Add include guard.
12196         * arm-fbsd-tdep.h: Add include guard.
12197         * arch/xtensa.h: Rename include guard.
12198         * arch/tic6x.h: Add include guard.
12199         * arch/i386.h: Add include guard.
12200         * arch/arm.h: Rename include guard.
12201         * arch/arm-linux.h: Rename include guard.
12202         * arch/arm-get-next-pcs.h: Rename include guard.
12203         * arch/amd64.h: Add include guard.
12204         * arch/aarch64-insn.h: Rename include guard.
12205         * arch-utils.h: Rename include guard.
12206         * annotate.h: Add include guard.
12207         * amd64-darwin-tdep.h: Rename include guard.
12208         * aarch64-linux-tdep.h: Add include guard.
12209         * aarch64-fbsd-tdep.h: Add include guard.
12210         * aarch32-linux-nat.h: Add include guard.
12211
12212 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12213
12214         * macrotab.c (macro_define_internal): New function that
12215         factorizes macro_define_object_internal and macro_define_function
12216         code.
12217         (macro_define_object_internal): Use macro_define_internal.
12218         (macro_define_function): Likewise.
12219
12220 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12221
12222         * macrocmd.c (extract_identifier): Return
12223         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12224         callers.
12225
12226 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12227
12228         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12229
12230 2019-02-05  Tom Tromey  <tom@tromey.com>
12231
12232         * target.c (target_stack::unpush): Move assertion earlier.
12233
12234 2019-01-30  Tom Tromey  <tom@tromey.com>
12235
12236         PR python/23615:
12237         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12238         (gdbpy_parse_and_eval): Likewise.
12239         * python/python-internal.h (gdbpy_allow_threads): New class.
12240
12241 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12242
12243         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12244         (aarch64_fbsd_fpregmap): Move earlier.
12245         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12246         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12247         instead of individual calls to trad_frame_set_reg_addr.
12248         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12249         earlier.
12250         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12251         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12252         instead of individual calls to trad_frame_set_reg_addr.
12253
12254 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12255
12256         * CONTRIBUTE: Replace contribution list with wiki link.
12257
12258 2019-01-25  Tom Tromey  <tom@tromey.com>
12259
12260         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12261
12262 2019-01-25  Tom Tromey  <tom@tromey.com>
12263
12264         * xtensa-linux-nat.c: Fix common/ includes.
12265         * xml-support.h: Fix common/ includes.
12266         * xml-support.c: Fix common/ includes.
12267         * x86-linux-nat.c: Fix common/ includes.
12268         * windows-nat.c: Fix common/ includes.
12269         * varobj.h: Fix common/ includes.
12270         * varobj.c: Fix common/ includes.
12271         * value.c: Fix common/ includes.
12272         * valops.c: Fix common/ includes.
12273         * utils.c: Fix common/ includes.
12274         * unittests/xml-utils-selftests.c: Fix common/ includes.
12275         * unittests/utils-selftests.c: Fix common/ includes.
12276         * unittests/unpack-selftests.c: Fix common/ includes.
12277         * unittests/tracepoint-selftests.c: Fix common/ includes.
12278         * unittests/style-selftests.c: Fix common/ includes.
12279         * unittests/string_view-selftests.c: Fix common/ includes.
12280         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12281         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12282         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12283         * unittests/rsp-low-selftests.c: Fix common/ includes.
12284         * unittests/parse-connection-spec-selftests.c: Fix common/
12285         includes.
12286         * unittests/optional-selftests.c: Fix common/ includes.
12287         * unittests/offset-type-selftests.c: Fix common/ includes.
12288         * unittests/observable-selftests.c: Fix common/ includes.
12289         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12290         * unittests/memrange-selftests.c: Fix common/ includes.
12291         * unittests/memory-map-selftests.c: Fix common/ includes.
12292         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12293         * unittests/function-view-selftests.c: Fix common/ includes.
12294         * unittests/environ-selftests.c: Fix common/ includes.
12295         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12296         * unittests/common-utils-selftests.c: Fix common/ includes.
12297         * unittests/cli-utils-selftests.c: Fix common/ includes.
12298         * unittests/array-view-selftests.c: Fix common/ includes.
12299         * ui-file.c: Fix common/ includes.
12300         * tui/tui-io.c: Fix common/ includes.
12301         * tracepoint.h: Fix common/ includes.
12302         * tracepoint.c: Fix common/ includes.
12303         * tracefile-tfile.c: Fix common/ includes.
12304         * top.h: Fix common/ includes.
12305         * top.c: Fix common/ includes.
12306         * thread.c: Fix common/ includes.
12307         * target/waitstatus.h: Fix common/ includes.
12308         * target/waitstatus.c: Fix common/ includes.
12309         * target.h: Fix common/ includes.
12310         * target.c: Fix common/ includes.
12311         * target-memory.c: Fix common/ includes.
12312         * target-descriptions.c: Fix common/ includes.
12313         * symtab.h: Fix common/ includes.
12314         * symfile.c: Fix common/ includes.
12315         * stap-probe.c: Fix common/ includes.
12316         * spu-linux-nat.c: Fix common/ includes.
12317         * sparc-nat.c: Fix common/ includes.
12318         * source.c: Fix common/ includes.
12319         * solib.c: Fix common/ includes.
12320         * solib-target.c: Fix common/ includes.
12321         * ser-unix.c: Fix common/ includes.
12322         * ser-tcp.c: Fix common/ includes.
12323         * ser-pipe.c: Fix common/ includes.
12324         * ser-base.c: Fix common/ includes.
12325         * selftest-arch.c: Fix common/ includes.
12326         * s12z-tdep.c: Fix common/ includes.
12327         * rust-exp.y: Fix common/ includes.
12328         * rs6000-aix-tdep.c: Fix common/ includes.
12329         * riscv-tdep.c: Fix common/ includes.
12330         * remote.c: Fix common/ includes.
12331         * remote-notif.h: Fix common/ includes.
12332         * remote-fileio.h: Fix common/ includes.
12333         * remote-fileio.c: Fix common/ includes.
12334         * regcache.h: Fix common/ includes.
12335         * regcache.c: Fix common/ includes.
12336         * record-btrace.c: Fix common/ includes.
12337         * python/python.c: Fix common/ includes.
12338         * python/py-type.c: Fix common/ includes.
12339         * python/py-inferior.c: Fix common/ includes.
12340         * progspace.h: Fix common/ includes.
12341         * producer.c: Fix common/ includes.
12342         * procfs.c: Fix common/ includes.
12343         * proc-api.c: Fix common/ includes.
12344         * printcmd.c: Fix common/ includes.
12345         * ppc-linux-nat.c: Fix common/ includes.
12346         * parser-defs.h: Fix common/ includes.
12347         * osdata.c: Fix common/ includes.
12348         * obsd-nat.c: Fix common/ includes.
12349         * nat/x86-linux.c: Fix common/ includes.
12350         * nat/x86-linux-dregs.c: Fix common/ includes.
12351         * nat/x86-dregs.h: Fix common/ includes.
12352         * nat/x86-dregs.c: Fix common/ includes.
12353         * nat/ppc-linux.c: Fix common/ includes.
12354         * nat/mips-linux-watch.h: Fix common/ includes.
12355         * nat/mips-linux-watch.c: Fix common/ includes.
12356         * nat/linux-waitpid.c: Fix common/ includes.
12357         * nat/linux-ptrace.h: Fix common/ includes.
12358         * nat/linux-ptrace.c: Fix common/ includes.
12359         * nat/linux-procfs.c: Fix common/ includes.
12360         * nat/linux-personality.c: Fix common/ includes.
12361         * nat/linux-osdata.c: Fix common/ includes.
12362         * nat/linux-namespaces.c: Fix common/ includes.
12363         * nat/linux-btrace.h: Fix common/ includes.
12364         * nat/linux-btrace.c: Fix common/ includes.
12365         * nat/fork-inferior.c: Fix common/ includes.
12366         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12367         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12368         * nat/aarch64-linux.c: Fix common/ includes.
12369         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12370         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12371         * namespace.h: Fix common/ includes.
12372         * mips-linux-tdep.c: Fix common/ includes.
12373         * minsyms.c: Fix common/ includes.
12374         * mi/mi-parse.h: Fix common/ includes.
12375         * mi/mi-main.c: Fix common/ includes.
12376         * mi/mi-cmd-env.c: Fix common/ includes.
12377         * memrange.h: Fix common/ includes.
12378         * memattr.c: Fix common/ includes.
12379         * maint.h: Fix common/ includes.
12380         * maint.c: Fix common/ includes.
12381         * main.c: Fix common/ includes.
12382         * machoread.c: Fix common/ includes.
12383         * location.c: Fix common/ includes.
12384         * linux-thread-db.c: Fix common/ includes.
12385         * linux-nat.c: Fix common/ includes.
12386         * linux-fork.c: Fix common/ includes.
12387         * inline-frame.c: Fix common/ includes.
12388         * infrun.c: Fix common/ includes.
12389         * inflow.c: Fix common/ includes.
12390         * inferior.h: Fix common/ includes.
12391         * inferior.c: Fix common/ includes.
12392         * infcmd.c: Fix common/ includes.
12393         * inf-ptrace.c: Fix common/ includes.
12394         * inf-child.c: Fix common/ includes.
12395         * ia64-linux-nat.c: Fix common/ includes.
12396         * i387-tdep.c: Fix common/ includes.
12397         * i386-tdep.c: Fix common/ includes.
12398         * i386-linux-tdep.c: Fix common/ includes.
12399         * i386-linux-nat.c: Fix common/ includes.
12400         * i386-go32-tdep.c: Fix common/ includes.
12401         * i386-fbsd-tdep.c: Fix common/ includes.
12402         * i386-fbsd-nat.c: Fix common/ includes.
12403         * guile/scm-type.c: Fix common/ includes.
12404         * guile/guile.c: Fix common/ includes.
12405         * go32-nat.c: Fix common/ includes.
12406         * gnu-nat.c: Fix common/ includes.
12407         * gdbthread.h: Fix common/ includes.
12408         * gdbarch-selftests.c: Fix common/ includes.
12409         * gdb_usleep.c: Fix common/ includes.
12410         * gdb_select.h: Fix common/ includes.
12411         * gdb_bfd.c: Fix common/ includes.
12412         * gcore.c: Fix common/ includes.
12413         * fork-child.c: Fix common/ includes.
12414         * findvar.c: Fix common/ includes.
12415         * fbsd-nat.c: Fix common/ includes.
12416         * event-top.c: Fix common/ includes.
12417         * event-loop.c: Fix common/ includes.
12418         * dwarf2read.c: Fix common/ includes.
12419         * dwarf2loc.c: Fix common/ includes.
12420         * dwarf2-frame.c: Fix common/ includes.
12421         * dwarf-index-cache.c: Fix common/ includes.
12422         * dtrace-probe.c: Fix common/ includes.
12423         * disasm-selftests.c: Fix common/ includes.
12424         * defs.h: Fix common/ includes.
12425         * csky-tdep.c: Fix common/ includes.
12426         * cp-valprint.c: Fix common/ includes.
12427         * cp-support.h: Fix common/ includes.
12428         * cp-support.c: Fix common/ includes.
12429         * corelow.c: Fix common/ includes.
12430         * completer.h: Fix common/ includes.
12431         * completer.c: Fix common/ includes.
12432         * compile/compile.c: Fix common/ includes.
12433         * compile/compile-loc2c.c: Fix common/ includes.
12434         * compile/compile-cplus-types.c: Fix common/ includes.
12435         * compile/compile-cplus-symbols.c: Fix common/ includes.
12436         * command.h: Fix common/ includes.
12437         * cli/cli-dump.c: Fix common/ includes.
12438         * cli/cli-cmds.c: Fix common/ includes.
12439         * charset.c: Fix common/ includes.
12440         * build-id.c: Fix common/ includes.
12441         * btrace.h: Fix common/ includes.
12442         * btrace.c: Fix common/ includes.
12443         * breakpoint.h: Fix common/ includes.
12444         * breakpoint.c: Fix common/ includes.
12445         * ax.h:
12446         (enum agent_op): Fix common/ includes.
12447         * ax-general.c (struct aop_map): Fix common/ includes.
12448         * ax-gdb.c: Fix common/ includes.
12449         * auxv.c: Fix common/ includes.
12450         * auto-load.c: Fix common/ includes.
12451         * arm-tdep.c: Fix common/ includes.
12452         * arch/riscv.c: Fix common/ includes.
12453         * arch/ppc-linux-common.c: Fix common/ includes.
12454         * arch/i386.c: Fix common/ includes.
12455         * arch/arm.c: Fix common/ includes.
12456         * arch/arm-linux.c: Fix common/ includes.
12457         * arch/arm-get-next-pcs.c: Fix common/ includes.
12458         * arch/amd64.c: Fix common/ includes.
12459         * arch/aarch64.c: Fix common/ includes.
12460         * arch/aarch64-insn.c: Fix common/ includes.
12461         * arch-utils.c: Fix common/ includes.
12462         * amd64-windows-tdep.c: Fix common/ includes.
12463         * amd64-tdep.c: Fix common/ includes.
12464         * amd64-sol2-tdep.c: Fix common/ includes.
12465         * amd64-obsd-tdep.c: Fix common/ includes.
12466         * amd64-nbsd-tdep.c: Fix common/ includes.
12467         * amd64-linux-tdep.c: Fix common/ includes.
12468         * amd64-linux-nat.c: Fix common/ includes.
12469         * amd64-fbsd-tdep.c: Fix common/ includes.
12470         * amd64-fbsd-nat.c: Fix common/ includes.
12471         * amd64-dicos-tdep.c: Fix common/ includes.
12472         * amd64-darwin-tdep.c: Fix common/ includes.
12473         * agent.c: Fix common/ includes.
12474         * ada-lang.h: Fix common/ includes.
12475         * ada-lang.c: Fix common/ includes.
12476         * aarch64-tdep.c: Fix common/ includes.
12477
12478 2019-01-25  Tom Tromey  <tom@tromey.com>
12479
12480         * common/create-version.sh: Use common/version.h.
12481
12482 2019-01-24  Pedro Alves  <palves@redhat.com>
12483
12484         * infrun.c (signal_stop, signal_print, signal_program)
12485         (signal_catch, signal_pass): Now arrays instead of pointers.
12486         (update_signals_program_target, do_target_resume)
12487         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12488         * linux-nat.c (linux_nat_target::pass_signals)
12489         (linux_nat_target::create_inferior, linux_nat_target::attach):
12490         Adjust.
12491         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12492         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12493         * procfs.c (procfs_target::pass_signals): Adjust.
12494         * record-full.c (record_full_target::resume): Adjust.
12495         * remote.c (remote_target::pass_signals)
12496         (remote_target::program_signals): Adjust.
12497         * target-debug.h (target_debug_print_signals): Now takes a
12498         gdb::array_view as parameter.  Adjust.
12499         * target.h (target_ops) <pass_signals, program_signals>: Replace
12500         pointer and length parameters with gdb::array_view.
12501         (target_pass_signals, target_program_signals): Likewise.
12502         * target-delegates.c: Regenerate.
12503
12504 2019-01-24  Pedro Alves  <palves@redhat.com>
12505
12506         * common/forward-scope-exit.h
12507         (forward_scope_exit::forward_scope_exit): Pass arguments to
12508         m_bind_function directly, instead of creating a std::bind and
12509         copying that.
12510
12511 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12512
12513         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12514         for static members.
12515         (pass_in_v_vfp_candidate): Likewise.
12516
12517 2019-01-23  Tom Tromey  <tom@tromey.com>
12518             Pedro Alves  <palves@redhat.com>
12519
12520         * regcache.c (class regcache_invalidator): Remove.
12521         (regcache::raw_write): Use make_scope_exit.
12522
12523 2019-01-23  Tom Tromey  <tom@tromey.com>
12524
12525         * ui-out.h (class ui_out_emit_type): Update comment.
12526
12527 2019-01-23  Tom Tromey  <tom@tromey.com>
12528
12529         * infrun.c (fetch_inferior_event): Update comment.
12530
12531 2019-01-23  Tom Tromey  <tom@tromey.com>
12532             Pedro Alves  <palves@redhat.com>
12533
12534         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12535         parameter.
12536         (fetch_inferior_event): Use SCOPE_EXIT.
12537
12538
12539 2019-01-23  Tom Tromey  <tom@tromey.com>
12540             Pedro Alves  <palves@redhat.com>
12541
12542         * infrun.c (disable_thread_events): Delete.
12543         (stop_all_threads): Use SCOPE_EXIT.
12544
12545 2019-01-23  Tom Tromey  <tom@tromey.com>
12546             Pedro Alves  <palves@redhat.com>
12547
12548         * symfile.c: Include forward-scope-exit.h.
12549         (clear_symtab_users_cleanup): Replace forward declaration with
12550         a FORWARD_SCOPE_EXIT.
12551         (syms_from_objfile_1): Use the forward_scope_exit and
12552         gdb::optional instead of cleanup_function.
12553         (reread_symbols): Use the forward_scope_exit instead of
12554         cleanup_function.
12555         (clear_symtab_users_cleanup): Remove function.
12556
12557 2019-01-23  Tom Tromey  <tom@tromey.com>
12558             Pedro Alves  <palves@redhat.com>
12559
12560         * linux-nat.c: Include scope-exit.h.
12561         (cleanup_target_stop): Remove.
12562         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12563         SCOPE_EXIT.
12564
12565 2019-01-23  Tom Tromey  <tom@tromey.com>
12566             Pedro Alves  <palves@redhat.com>
12567
12568         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12569         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12570
12571 2019-01-23  Tom Tromey  <tom@tromey.com>
12572             Andrew Burgess  <andrew.burgess@embecosm.com>
12573             Pedro Alves  <palves@redhat.com>
12574
12575         * infrun.c (fetch_inferior_event): Use scope_exit.
12576         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12577         * top.c (execute_command): Use scope_exit.
12578         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12579         * utils.c (do_bpstat_clear_actions_cleanup)
12580         (make_bpstat_clear_actions_cleanup): Remove.
12581
12582 2019-01-23  Tom Tromey  <tom@tromey.com>
12583             Pedro Alves  <palves@redhat.com>
12584
12585         * infrun.c: Include "common/scope-exit.h"
12586         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12587         (wait_for_inferior): Use SCOPE_EXIT.
12588         (fetch_inferior_event): Use scope_exit.
12589
12590 2019-01-23  Tom Tromey  <tom@tromey.com>
12591             Pedro Alves  <palves@redhat.com>
12592
12593         * breakpoint.c (create_breakpoint): Remove cleanup.
12594
12595 2019-01-23  Tom Tromey  <tom@tromey.com>
12596             Andrew Burgess  <andrew.burgess@embecosm.com>
12597             Pedro Alves  <palves@redhat.com>
12598
12599 2019-01-23  Pedro Alves  <palves@redhat.com>
12600
12601         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12602
12603 2019-01-23  Pedro Alves  <palves@redhat.com>
12604             Andrew Burgess  <andrew.burgess@embecosm.com>
12605
12606         * gdbthread.h: Include "common/forward-scope-exit.h".
12607         (scoped_finish_thread_state): Redefine custom class in terms of
12608         forward_scope_exit.
12609
12610 2019-01-23  Pedro Alves  <palves@redhat.com>
12611             Andrew Burgess  <andrew.burgess@embecosm.com>
12612
12613         * common/forward-scope-exit.h: New file.
12614
12615 2019-01-23  Pedro Alves  <palves@redhat.com>
12616             Andrew Burgess  <andrew.burgess@embecosm.com>
12617             Tom Tromey  <tom@tromey.com>
12618
12619         * common/scope-exit.h: New file.
12620
12621 2019-01-23  Pedro Alves  <palves@redhat.com>
12622
12623         * common/preprocessor.h (ESC): Rename to ...
12624         (ESC_PARENS): ... this.
12625         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12626         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12627
12628 2019-01-23  Tom Tromey  <tom@tromey.com>
12629
12630         * language.h (class scoped_switch_to_sym_language_if_auto):
12631         Initialize m_lang in both cases.
12632
12633 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12634
12635         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12636         with XCNEW.
12637
12638 2019-01-22  Tom Tromey  <tom@tromey.com>
12639
12640         * corelow.c: Do not include sys/file.h.
12641
12642 2019-01-22  Tom Tromey  <tom@tromey.com>
12643
12644         * tui/tui-wingeneral.h: Include gdb_curses.h.
12645
12646 2019-01-22  Tom Tromey  <tom@tromey.com>
12647
12648         * source-cache.h (class source_cache) <get_source_lines,
12649         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12650
12651 2019-01-22  Tom Tromey  <tom@tromey.com>
12652
12653         * remote-fileio.h (struct remote_target): Declare.
12654
12655 2019-01-22  Tom Tromey  <tom@tromey.com>
12656
12657         * python/py-arch.c: Do not include py-ref.h.
12658         * python/py-bpevent.c: Do not include py-ref.h.
12659         * python/py-cmd.c: Do not include py-ref.h.
12660         * python/py-continueevent.c: Do not include py-ref.h.
12661         * python/py-event.h: Do not include py-ref.h.
12662         * python/py-evtregistry.c: Do not include py-ref.h.
12663         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12664         * python/py-frame.c: Do not include py-ref.h.
12665         * python/py-framefilter.c: Do not include py-ref.h.
12666         * python/py-function.c: Do not include py-ref.h.
12667         * python/py-infevents.c: Do not include py-ref.h.
12668         * python/py-linetable.c: Do not include py-ref.h.
12669         * python/py-objfile.c: Do not include py-ref.h.
12670         * python/py-param.c: Do not include py-ref.h.
12671         * python/py-prettyprint.c: Do not include py-ref.h.
12672         * python/py-progspace.c: Do not include py-ref.h.
12673         * python/py-symbol.c: Do not include py-ref.h.
12674         * python/py-symtab.c: Do not include py-ref.h.
12675         * python/py-type.c: Do not include py-ref.h.
12676         * python/py-unwind.c: Do not include py-ref.h.
12677         * python/py-utils.c: Do not include py-ref.h.
12678         * python/py-value.c: Do not include py-ref.h.
12679         * python/py-varobj.c: Do not include py-ref.h.
12680         * python/py-xmethods.c: Do not include py-ref.h.
12681         * python/python.c: Do not include py-ref.h.
12682         * varobj.c: Do not include py-ref.h.
12683
12684 2019-01-22  Tom Tromey  <tom@tromey.com>
12685
12686         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12687         keyword for bcache.
12688
12689 2019-01-22  Tom Tromey  <tom@tromey.com>
12690
12691         * compile/compile-cplus-types.c: Remove a comment by #include.
12692
12693 2019-01-22  Tom Tromey  <tom@tromey.com>
12694
12695         * compile/gcc-c-plugin.h: Include compile-internal.h.
12696
12697 2019-01-22  Tom Tromey  <tom@tromey.com>
12698
12699         * stabsread.c (EXTERN): Do not define.
12700         (symnum, next_symbol_text_func, processing_gcc_compilation)
12701         (within_function, global_sym_chain, global_stabs)
12702         (previous_stab_code, this_object_header_files)
12703         (n_this_object_header_files)
12704         (n_allocated_this_object_header_files): Define.
12705         * stabsread.h (EXTERN): Never define.  Use "extern".
12706
12707 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12708
12709         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12710         history_value.
12711
12712 2019-01-21  Tom Tromey  <tom@tromey.com>
12713
12714         * ui-out.c: Fix includes.
12715         * tui/tui-source.c: Fix includes.
12716         * target.c: Fix includes.
12717         * remote.c: Fix includes.
12718         * regcache.c: Fix includes.
12719         * python/py-block.c: Fix includes.
12720         * printcmd.c: Fix includes.
12721         * or1k-tdep.c: Fix includes.
12722         * mi/mi-main.c: Fix includes.
12723         * m32r-tdep.c: Fix includes.
12724         * csky-tdep.c: Fix includes.
12725         * compile/compile-cplus-types.c: Fix includes.
12726         * cli/cli-interp.c: Fix includes.
12727
12728 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12729
12730         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12731         for padding.
12732
12733 2019-01-16  Tom Tromey  <tom@tromey.com>
12734
12735         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12736         earlier.
12737         (struct objfile) <msymbols_range>: Move from top level.
12738         <msymbols>: New method.
12739         (class objfile_msymbols): Remove.
12740         * symtab.c (default_collect_symbol_completion_matches_break_on):
12741         Update.
12742         * symmisc.c (dump_msymbols): Update.
12743         * stabsread.c (scan_file_globals): Update.
12744         * objc-lang.c (info_selectors_command, info_classes_command)
12745         (find_methods): Update.
12746         * minsyms.c (find_solib_trampoline_target): Update.
12747         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12748         * coffread.c (coff_symfile_read): Update.
12749         * ada-lang.c (ada_lookup_simple_minsym)
12750         (ada_collect_symbol_completion_matches): Update.
12751
12752 2019-01-16  Tom Tromey  <tom@tromey.com>
12753
12754         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12755         type.  Remove no-argument constructor.
12756         <iterator::operator++>: Simplify.
12757         <begin>: Update.
12758         <end>: Use minimal_symbol_count.
12759
12760 2019-01-16  Tom Tromey  <tom@tromey.com>
12761
12762         * objfiles.h (struct objfile) <psymtabs>: New method.
12763         (class objfile_psymtabs): Remove.
12764         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12765         typedef.
12766         <range>: New method.
12767         (require_partial_symbols): Change return type.
12768         * psymtab.c (require_partial_symbols)
12769         (psym_expand_symtabs_matching): Update.
12770         * mdebugread.c (parse_partial_symbols): Update.
12771         * dbxread.c (dbx_end_psymtab): Update.
12772
12773 2019-01-15  Tom Tromey  <tom@tromey.com>
12774
12775         * symtab.c (lookup_objfile_from_block)
12776         (lookup_symbol_in_objfile_symtabs)
12777         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12778         (find_line_symtab, info_sources_command)
12779         (default_collect_symbol_completion_matches_break_on)
12780         (make_source_files_completion_list): Update.
12781         * symmisc.c (print_objfile_statistics, dump_objfile)
12782         (maintenance_print_symbols, maintenance_info_symtabs)
12783         (maintenance_check_symtabs, maintenance_info_line_tables):
12784         Update.
12785         * source.c (select_source_symtab)
12786         (forget_cached_source_info_for_objfile): Update.
12787         * objfiles.h (class objfile_compunits): Remove.
12788         (struct objfile) <compunits_range>: New typedef.
12789         (compunits): New method.
12790         * objfiles.c (objfile_relocate1): Update.
12791         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12792         * maint.c (count_symtabs_and_blocks): Update.
12793         * linespec.c (iterate_over_all_matching_symtabs): Update.
12794         * cp-support.c (add_symbol_overload_list_qualified): Update.
12795         * coffread.c (coff_symtab_read): Update.
12796         * ada-lang.c (add_nonlocal_symbols)
12797         (ada_collect_symbol_completion_matches)
12798         (ada_add_global_exceptions): Update.
12799
12800 2019-01-15  Tom Tromey  <tom@tromey.com>
12801
12802         * progspace.h (program_space) <objfiles_safe_range>: New
12803         typedef.
12804         <objfiles_safe>: New method.
12805         * objfiles.h (class all_objfiles_safe): Remove.
12806         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12807         * jit.c (jit_inferior_exit_hook): Update.
12808
12809 2019-01-17  Tom Tromey  <tom@tromey.com>
12810
12811         * progspace.h (program_space) <objfiles_range>: New typedef.
12812         <objfiles>: New method.
12813         <objfiles_head>: Rename from objfiles.
12814         (object_files): Update.
12815         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12816         * guile/scm-pretty-print.c
12817         (ppscm_find_pretty_printer_from_objfiles): Update.
12818         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12819         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12820         Update.
12821         * python/py-progspace.c (pspy_get_objfiles): Update.
12822         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12823         Update.
12824         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12825         (objfpy_lookup_objfile_by_build_id): Update.
12826         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12827         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12828         Update.
12829         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12830         (expand_symtab_containing_pc, lookup_objfile_from_block)
12831         (lookup_static_symbol, basic_lookup_transparent_type)
12832         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12833         (find_line_symtab, info_sources_command)
12834         (default_collect_symbol_completion_matches_break_on)
12835         (make_source_files_completion_list, find_main_name): Update.
12836         * symmisc.c (print_symbol_bcache_statistics)
12837         (print_objfile_statistics, maintenance_print_symbols)
12838         (maintenance_print_msymbols, maintenance_print_objfiles)
12839         (maintenance_info_symtabs, maintenance_check_symtabs)
12840         (maintenance_expand_symtabs, maintenance_info_line_tables):
12841         Update.
12842         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12843         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12844         (map_overlay_command, unmap_overlay_command)
12845         (simple_overlay_update, expand_symtabs_matching)
12846         (map_symbol_filenames): Update.
12847         * symfile-debug.c (set_debug_symfile): Update.
12848         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12849         Update.
12850         * source.c (select_source_symtab, forget_cached_source_info):
12851         Update.
12852         * solib.c (solib_read_symbols): Update.
12853         * solib-spu.c (append_ocl_sos): Update.
12854         * psymtab.c (maintenance_print_psymbols)
12855         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12856         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12857         * printcmd.c (info_symbol_command): Update.
12858         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12859         Update.
12860         * objfiles.h (class all_objfiles): Remove.
12861         * objfiles.c (have_partial_symbols, have_full_symbols)
12862         (have_minimal_symbols, qsort_cmp, update_section_map)
12863         (shared_objfile_contains_address_p)
12864         (default_iterate_over_objfiles_in_search_order): Update.
12865         * objc-lang.c (info_selectors_command, info_classes_command)
12866         (find_methods): Update.
12867         * minsyms.c (find_solib_trampoline_target): Update.
12868         * maint.c (maintenance_info_sections)
12869         (maintenance_translate_address, count_symtabs_and_blocks):
12870         Update.
12871         * main.c (captured_main_1): Update.
12872         * linux-thread-db.c (try_thread_db_load_from_pdir)
12873         (has_libpthread): Update.
12874         * linespec.c (iterate_over_all_matching_symtabs)
12875         (search_minsyms_for_name): Update.
12876         * jit.c (jit_find_objf_with_entry_addr): Update.
12877         * hppa-tdep.c (find_unwind_entry)
12878         (hppa_lookup_stub_minimal_symbol): Update.
12879         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12880         Update.
12881         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12882         (elf_gnu_ifunc_resolve_by_got): Update.
12883         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12884         * dwarf-index-write.c (save_gdb_index_command): Update.
12885         * cp-support.c (add_symbol_overload_list_qualified): Update.
12886         * breakpoint.c (create_overlay_event_breakpoint)
12887         (create_longjmp_master_breakpoint)
12888         (create_std_terminate_master_breakpoint)
12889         (create_exception_master_breakpoint): Update.
12890         * blockframe.c (find_pc_partial_function): Update.
12891         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12892         (ada_collect_symbol_completion_matches)
12893         (ada_add_global_exceptions): Update.
12894
12895 2019-01-17  Tom Tromey  <tom@tromey.com>
12896
12897         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12898         declare VEC.
12899         (solib_target_parse_libraries): Change return type.
12900         (library_list_start_segment, library_list_start_section)
12901         (library_list_end_library, library_list_start_library); Update.
12902         (solib_target_free_library_list): Remove.
12903         (solib_target_parse_libraries): Remove cleanup.  Change return
12904         type.
12905         (solib_target_current_sos): Update.
12906
12907 2019-01-17  Tom Tromey  <tromey@bapiya>
12908
12909         * valprint.c: Replace "the the" with "the".
12910         * symtab.c: Replace "the the" with "the".
12911         * solib.c: Replace "the the" with "the".
12912         * solib-dsbt.c: Replace "the the" with "the".
12913         * linespec.c: Replace "the the" with "the".
12914         * dwarf2loc.h: Replace "the the" with "the".
12915         * amd64-windows-tdep.c: Replace "the the" with "the".
12916         * aarch64-tdep.c: Replace "the the" with "the".
12917
12918 2019-01-16  Keith Seitz  <keiths@redhat.com>
12919
12920         PR gdb/23773
12921         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12922         <builder>: Rename to ..
12923         <m_builder>: ... this and make private.
12924         (dwarf2_cu::get_builder): New method.  Change all users of
12925         `builder' to use this method.
12926         (dwarf2_start_symtab): Move to ...
12927         (dwarf2_cu::start_symtab): ... here.  Update all callers
12928         (setup_type_unit_groups): Move to ...
12929         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12930         callers.
12931         (dwarf2_cu::reset_builder): New method.
12932         (process_full_compunit, process_full_type_unit): Use
12933         dwarf2_cu::reset_builder.
12934         (follow_die_offset): Record the ancestor CU if it is different
12935         from the followed DIE's CU.
12936         (follow_die_sig_1): Likewise.
12937
12938 2019-01-15  Tom Tromey  <tom@tromey.com>
12939
12940         * remote.c (class remote_state) <buf>: Now a char_vector.
12941         <buf_size>: Remove.
12942         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12943         parameter.
12944         (remote_target::getpkt_or_notif_sane_1)
12945         (remote_target::getpkt_sane)
12946         (remote_target::getpkt_or_notif_sane): Likewise.
12947         (class remote_target) <putpkt>: New overload.
12948         (remote_target::read_frame): Change type of "buf_p".  Remove
12949         sizeof_p parameter.
12950         (packet_ok): New overload.
12951         (packet_check_result): New overload.
12952         Update all uses.
12953
12954 2019-01-14  Tom Tromey  <tom@tromey.com>
12955
12956         * remote-notif.c (handle_notification, remote_notif_ack)
12957         (remote_notif_parse): Make "buf" const.
12958         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12959         const.
12960         (remote_notif_parse, remote_notif_ack, handle_notification):
12961         Likewise.
12962         * remote.c (remote_notif_stop_parse): Make "buf" const.
12963         (remote_target::remote_parse_stop_reply): Make "buf" const.
12964         (remote_notif_stop_ack): Make "buf" const.
12965
12966 2019-01-14  Tom Tromey  <tom@tromey.com>
12967
12968         * remote.c (remote_console_output): Make parameter const.
12969
12970 2019-01-14  Tom Tromey  <tom@tromey.com>
12971
12972         * target-debug.h (target_debug_print_signals): Constify.
12973         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12974         * procfs.c (procfs_target::pass_signals): Update.
12975         * linux-nat.c (linux_nat_target::pass_signals): Update.
12976         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12977         * target-delegates.c: Rebuild.
12978         * remote.c (remote_target::program_signals): Update.
12979         (remote_target::pass_signals): Update.
12980         * target.c (target_pass_signals): Constify argument.
12981         (target_program_signals): Likewise.
12982         * target.h (struct target_ops) <pass_signals, program_signals>:
12983         Constify argument.
12984         (target_pass_signals, target_program_signals): Constify argument.
12985
12986 2019-01-14  Tom Tromey  <tom@tromey.com>
12987
12988         PR tui/28819:
12989         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12990
12991 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12992
12993         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12994         field.
12995         * rs6000-tdep.c: Include reggroups.h.
12996         (IS_V_ALIAS_PSEUDOREG): Define.
12997         (rs6000_register_name): Return names for the "vX" aliases.
12998         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12999         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13000         aliases.  Call default_register_reggroup_p for all other
13001         pseudo-registers.
13002         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13003         New functions.
13004         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13005         Handle "vX" aliases.
13006         (v_alias_pseudo_register_collect): New function.
13007         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13008         (rs6000_gdbarch_init): Initialize "vX" aliases as
13009         pseudo-registers.  Restore registration of
13010         rs6000_pseudo_register_reggroup_p with
13011         set_tdesc_pseudo_register_reggroup_p.
13012
13013 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13014
13015         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13016         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13017         set_gdbarch_num_pseudo_regs.
13018
13019 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13020
13021         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13022         Remove arg prefixname, add do_set and do_show.
13023         Add member functions set_list and show_list.
13024         * cli/cli-style.c (class cli_style_option): Update accordingly.
13025         (style_set_list): Move to file scope.
13026         (style_show_list): Likewise.
13027         (set_style): Call help_list.
13028         (show_style): Call cmd_show_list.
13029         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13030         Update to use the new macro.
13031
13032 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13033
13034         * ada-lang.c (_initialize_ada_language): Expand the help text
13035         for the "catch exception" command.
13036
13037 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13038
13039         * symtab.c (matching_obj_sections): Initialize obj,
13040         declare it closer to its usage.
13041
13042 2019-01-10  Tom Tromey  <tom@tromey.com>
13043
13044         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13045         (basic_inf_threads_range): Remove.
13046         (inf_threads_range, inf_non_exited_threads_range)
13047         (safe_inf_threads_range): Use next_adapter.
13048
13049 2019-01-10  Keith Seitz  <keiths@redhat.com>
13050
13051         PR gdb/23712
13052         PR symtab/23010
13053         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13054         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13055
13056 2019-01-10  Keith Seitz  <keiths@redhat.com>
13057
13058         PR gdb/23712
13059         PR symtab/23010
13060         * dictionary.c (pending_to_vector): Remove.
13061         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13062         Remove _1 suffix, replacing functions of the same name.  Update
13063         all callers.
13064         (dict_create_hashed, dict_create_hashed_expandable)
13065         (dict_create_linear, dict_create_linear_expandable, dict_free)
13066         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13067         Make functions static.
13068
13069 2019-01-10  Keith Seitz  <keiths@redhat.com>
13070
13071         PR gdb/23712
13072         PR symtab/23010
13073         * dictionary.h (struct dictionary): Replace declaration with
13074         multidictionary.
13075         (dict_create_hashed, dict_create_hashed_expandable)
13076         (dict_create_linear, dict_create_linear_expandable)
13077         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13078         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13079         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13080         taking multidictionary argument.
13081         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13082         * block.h (struct block) <dict>: Change to multidictionary
13083         and rename `multidict'.
13084         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13085         symmisc.c: Update all dictionary references to multidictionary.
13086
13087 2019-01-10  Keith Seitz  <keiths@redhat.com>
13088
13089         PR gdb/23712
13090         PR symtab/23010
13091         * dictionary.c: Include unordered_map.
13092         (pending_to_vector): New function.
13093         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13094         Rewrite the non-"_1" functions to take vector instead
13095         of linked list.
13096         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13097         "new" _1 versions of the same name.
13098         (multidictionary): Define.
13099         (std::hash<enum language): New definition.
13100         (collate_pending_symbols_by_language, mdict_create_hashed)
13101         (mdict_create_hashed_expandable, mdict_create_linear)
13102         (mdict_create_linear_expandable, mdict_free)
13103         (find_language_dictionary, create_new_language_dictionary)
13104         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13105         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13106         (mdict_size, mdict_empty): New functions.
13107         * dictionary.h (mdict_iterator): Define.
13108
13109 2019-01-10  Pedro Alves  <palves@redhat.com>
13110
13111         * breakpoint.c (read_uploaded_action)
13112         (create_tracepoint_from_upload): Adjust to use
13113         gdb::unique_xmalloc_ptr.
13114         * ctf.c (ctf_write_uploaded_tp):
13115         (SET_ARRAY_FIELD): Use emplace_back.
13116         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13117         * tracefile-tfile.c (tfile_write_uploaded_tp):
13118         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13119         gdb::unique_xmalloc_ptr.
13120         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13121         at_string, cond_string, cmd_strings>: Replace char pointers
13122         with gdb::unique_xmalloc_ptr.
13123
13124 2019-01-10  Pedro Alves  <palves@redhat.com>
13125
13126         * solib-target.c (library_list_start_library): Don't xstrdup name.
13127
13128 2019-01-10  Pedro Alves  <palves@redhat.com>
13129
13130         * mdebugread.c (parse_partial_symbols): Use
13131         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13132
13133 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13134
13135         * linux-fork.c (scoped_switch_fork_info)
13136         <~scoped_switch_fork_info>: Fix incorrect variable name.
13137
13138 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13139
13140         * linux-fork.c (scoped_switch_fork_info)
13141         <scoped_switch_fork_info>: Make explicit.
13142         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13143
13144 2019-01-10  Tom Tromey  <tom@tromey.com>
13145
13146         * objfiles.h (objfile::reset_psymtabs): Update.
13147         * objfiles.c (objfile::objfile): Update.
13148         * psymtab.h (psymtab_storage::obstack): Update.
13149         (psymtab_storage::m_obstack): Use gdb::optional.
13150         (class psymtab_storage): Update comment.  Remove objfile
13151         parameter.
13152         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13153
13154 2019-01-10  Tom Tromey  <tom@tromey.com>
13155
13156         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13157         <free_psymtabs>: Now private.
13158         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13159         (allocate_psymtab): Use new method.
13160
13161 2019-01-10  Tom Tromey  <tom@tromey.com>
13162
13163         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13164         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13165         * mdebugread.c (parse_partial_symbols): Use
13166         allocate_dependencies.
13167         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13168         allocate_dependencies.
13169         (process_psymtab_comp_unit_reader)
13170         (build_type_psymtab_dependencies): Likewise.
13171         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13172
13173 2019-01-10  Tom Tromey  <tom@tromey.com>
13174
13175         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13176         PSYMBOL_SET_LANGUAGE.
13177         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13178
13179 2019-01-10  Tom Tromey  <tom@tromey.com>
13180
13181         * psymtab.h (psymtab_storage::obstack): New method.
13182         <m_obstack>: Rename from obstack; now private.
13183         * psymtab.c (psymtab_storage): Update.
13184         * dwarf2read.c (create_addrmap_from_index)
13185         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13186         Update.
13187
13188 2019-01-10  Tom Tromey  <tom@tromey.com>
13189
13190         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13191         * objfiles.h (objfile::reset_psymtabs): New method.
13192
13193 2019-01-10  Tom Tromey  <tom@tromey.com>
13194
13195         * symmisc.c (print_symbol_bcache_statistics): Update.
13196         (print_objfile_statistics): Update.
13197         * symfile.c (reread_symbols): Update.
13198         * psymtab.h (class psymtab_storage): New.
13199         * psymtab.c (psymtab_storage): New constructor.
13200         (~psymtab_storage): New destructor.
13201         (require_partial_symbols): Update.
13202         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13203         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13204         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13205         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13206         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13207         (start_psymtab_common, end_psymtab_common)
13208         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13209         (allocate_psymtab): Update.
13210         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13211         Update.
13212         (dump_psymtab_addrmap, maintenance_print_psymbols)
13213         (maintenance_check_psymtabs): Update.
13214         (class objfile_psymtabs): Move to objfiles.h.
13215         * psympriv.h (discard_psymtab): Now inline.
13216         (psymtab_discarder::psymtab_discarder): Update.
13217         (psymtab_discarder::~psymtab_discarder): Update.
13218         (ALL_OBJFILE_PSYMTABS): Rewrite.
13219         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13220         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13221         Remove fields.
13222         <partial_symtabs>: New field.
13223         (class objfile_psymtabs): Move from psymtab.h.  Update.
13224         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13225         psymbol_cache.
13226         (objfile::~objfile): Don't destroy psymbol_cache.
13227         * mdebugread.c (parse_partial_symbols): Update.
13228         * dwarf2read.c (create_addrmap_from_index)
13229         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13230         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13231         (add_partial_subprogram, dwarf2_ranges_read): Update.
13232         * dwarf-index-write.c (write_address_map)
13233         (write_one_signatured_type, recursively_write_psymbols)
13234         (class debug_names, class debug_names, write_psymtabs_to_index):
13235         Update.
13236
13237 2019-01-10  Tom Tromey  <tom@tromey.com>
13238
13239         * symtab.h (SYMBOL_SET_NAMES): Update.
13240         (symbol_set_names): Update.
13241         (MSYMBOL_SET_NAMES): Update.
13242         * symtab.c (symbol_set_names): Change argument to be an
13243         objfile_per_bfd_storage.
13244         * psymtab.c (add_psymbol_to_bcache): Update.
13245         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13246
13247 2019-01-10  Tom Tromey  <tom@tromey.com>
13248
13249         * symtab.c (create_demangled_names_hash): Change argument to be an
13250         objfile_per_bfd_storage.
13251         (symbol_set_names): Update.
13252
13253 2019-01-10  Tom Tromey  <tom@tromey.com>
13254
13255         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13256         init_psymbol_list.
13257         * psymtab.c (init_psymbol_list): Do nothing if already called.
13258         * psympriv.h (init_psymbol_list): Add comment.
13259         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13260         init_psymbol_list.
13261         * dbxread.c (dbx_symfile_read): Unconditionally call
13262         init_psymbol_list.
13263
13264 2019-01-10  Tom Tromey  <tom@tromey.com>
13265
13266         * xcoffread.c (scan_xcoff_symtab): Update.
13267         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13268         "where".
13269         * mdebugread.c (parse_partial_symbols)
13270         (handle_psymbol_enumerators): Update.
13271         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13272         * dbxread.c (read_dbx_symtab): Update.
13273         * psympriv.h (psymbol_placement): New enum.
13274         (add_psymbol_to_list): Update.
13275
13276 2019-01-10  Tom Tromey  <tom@tromey.com>
13277
13278         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13279         static_psymbols parameters.
13280         (scan_xcoff_symtab): Update.
13281         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13282         static_psymbols parameters.
13283         * psympriv.h (start_psymtab_common): Update.
13284         * mdebugread.c (parse_partial_symbols): Update.
13285         * dwarf2read.c (create_partial_symtab): Update.
13286         * dbxread.c (read_dbx_symtab): Update.
13287         (start_psymtab): Remove global_psymbols and static_psymbols
13288         parameters.
13289
13290 2019-01-10  Tom Tromey  <tom@tromey.com>
13291
13292         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13293         * psymtab.c (allocate_psymtab): Add comment.
13294         * psympriv.h (allocate_psymtab): Add comment.
13295         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13296         initializations.
13297         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13298
13299 2019-01-10  Tom Tromey  <tom@tromey.com>
13300
13301         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13302         Don't declare.
13303         * mipsread.c: Include mdebugread.h.
13304         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13305         Declare.
13306         * elfread.c: Include mdebugread.h.
13307
13308 2019-01-09  Tom Tromey  <tom@tromey.com>
13309
13310         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13311         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13312         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13313         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13314         (psym_lookup_symbol, psym_find_last_source_symtab)
13315         (psym_forget_cached_source_info, psym_print_stats)
13316         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13317         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13318         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13319         (psym_find_compunit_symtab_by_address)
13320         (maintenance_print_psymbols, maintenance_info_psymtabs)
13321         (maintenance_check_psymtabs): Use ranged for.
13322         * psymtab.h (class objfile_psymtabs): New.
13323         (require_partial_symbols): Return objfile_psymtabs.
13324         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13325
13326 2019-01-09  Tom Tromey  <tom@tromey.com>
13327
13328         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13329         (find_pc_mapped_section, list_overlays_command)
13330         (map_overlay_command, unmap_overlay_command)
13331         (simple_overlay_update): Use all_objfiles.
13332         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13333         * printcmd.c (info_symbol_command): Use all_objfiles.
13334         * objfiles.h (ALL_OBJSECTIONS): Remove.
13335         * maint.c (maintenance_translate_address): Use all_objfiles.
13336         * gcore.c (gcore_create_callback): Use all_objfiles.
13337         (objfile_find_memory_regions): Likewise.
13338
13339 2019-01-09  Tom Tromey  <tom@tromey.com>
13340
13341         * symtab.c (find_line_symtab, info_sources_command)
13342         (make_source_files_completion_list): Use objfile_compunits.
13343         * source.c (select_source_symtab): Use objfile_compunits.
13344         * objfiles.h (struct objfile): Update comment.
13345         (ALL_OBJFILES): Remove.
13346         (ALL_FILETABS): Remove.
13347         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13348         objfile_compunits.
13349
13350 2019-01-09  Tom Tromey  <tom@tromey.com>
13351
13352         * symmisc.c (print_objfile_statistics, dump_objfile)
13353         (maintenance_print_symbols): Use compunit_filetabs.
13354         * source.c (forget_cached_source_info_for_objfile): Use
13355         compunit_filetabs.
13356         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13357         (ALL_FILETABS): Use compunit_filetabs.
13358         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13359         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13360
13361 2019-01-09  Tom Tromey  <tom@tromey.com>
13362
13363         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13364         (compunit_filetabs): New.
13365         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13366         compunit_filetabs.
13367         (info_sources_command, make_source_files_completion_list): Remove
13368         declaration.
13369         * symmisc.c (print_objfile_statistics, dump_objfile)
13370         (maintenance_print_symbols): Remove declaration.
13371         (maintenance_info_symtabs): Use compunit_filetabs.
13372         (maintenance_info_line_tables): Likewise.
13373         * source.c (select_source_symtab): Change local variable name.
13374         (forget_cached_source_info_for_objfile): Remove declaration.
13375         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13376         * objfiles.c (objfile_relocate1): Remove declaration.
13377         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13378         declaration.
13379         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13380         * coffread.c (coff_symtab_read): Remove declaration.
13381         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13382         compunit_filetabs.
13383
13384 2019-01-09  Tom Tromey  <tom@tromey.com>
13385
13386         * symtab.c (lookup_objfile_from_block)
13387         (find_pc_sect_compunit_symtab, search_symbols)
13388         (default_collect_symbol_completion_matches_break_on): Use
13389         objfile_compunits.
13390         * objfiles.h (ALL_COMPUNITS): Remove.
13391         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13392         * cp-support.c (add_symbol_overload_list_qualified): Use
13393         objfile_compunits.
13394         * ada-lang.c (ada_collect_symbol_completion_matches)
13395         (ada_add_global_exceptions): Use objfile_compunits.
13396
13397 2019-01-09  Tom Tromey  <tom@tromey.com>
13398
13399         * source.c (select_source_symtab)
13400         (forget_cached_source_info_for_objfile): Remove declaration.
13401         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13402         declaration.
13403         * maint.c (count_symtabs_and_blocks): Remove declaration.
13404         * cp-support.c (add_symbol_overload_list_qualified): Remove
13405         declaration.
13406         * coffread.c (coff_symtab_read): Remove declaration.
13407         * symtab.c (lookup_symbol_in_objfile_symtabs)
13408         (basic_lookup_transparent_type_1): Use objfile_compunits.
13409         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13410         (info_sources_command, search_symbols)
13411         (default_collect_symbol_completion_matches_break_on)
13412         (make_source_files_completion_list): Remove declaration.
13413         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13414         (ada_collect_symbol_completion_matches)
13415         (ada_add_global_exceptions): Remove declaration.
13416         * linespec.c (iterate_over_all_matching_symtabs): Use
13417         objfile_compunits.
13418         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13419         (class objfile_compunits): New.
13420         (ALL_COMPUNITS): Use objfile_compunits.
13421         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13422         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13423         objfile_compunits.
13424         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13425
13426 2019-01-09  Tom Tromey  <tom@tromey.com>
13427
13428         * symtab.c (search_symbols)
13429         (default_collect_symbol_completion_matches_break_on): Use
13430         objfile_msymbols.
13431         * ada-lang.c (ada_lookup_simple_minsym)
13432         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13433         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13434         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13435         objfile_msymbols.
13436         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13437         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13438         * objc-lang.c (find_methods): Use objfile_msymbols.
13439         (info_selectors_command, info_classes_command): Likewise.
13440         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13441         * objfiles.h (class objfile_msymbols): New.
13442         (ALL_OBJFILE_MSYMBOLS): Remove.
13443         (ALL_MSYMBOLS): Remove.
13444
13445 2019-01-09  Tom Tromey  <tom@tromey.com>
13446
13447         * common/next-iterator.h (next_adapter): Add Iterator template
13448         parameter.
13449         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13450         (class all_objfiles_safe): New.
13451         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13452         * objfiles.c (put_objfile_before): Update comment.
13453         (add_separate_debug_objfile): Likewise.
13454         (free_all_objfiles): Use all_objfiles_safe.
13455         (objfile_purge_solibs): Likewise.
13456
13457 2019-01-09  Tom Tromey  <tom@tromey.com>
13458
13459         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13460         (expand_symtab_containing_pc, lookup_static_symbol)
13461         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13462         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13463         all_objfiles.
13464         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13465         * breakpoint.c (create_overlay_event_breakpoint)
13466         (create_longjmp_master_breakpoint)
13467         (create_std_terminate_master_breakpoint)
13468         (create_exception_master_breakpoint): Use all_objfiles.
13469         * linux-thread-db.c (try_thread_db_load_from_pdir)
13470         (has_libpthread): Use all_objfiles.
13471         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13472         * linespec.c (iterate_over_all_matching_symtabs)
13473         (search_minsyms_for_name): Use all_objfiles.
13474         * maint.c (maintenance_info_sections): Use all_objfiles.
13475         * main.c (captured_main_1): Use all_objfiles.
13476         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13477         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13478         * guile/scm-pretty-print.c
13479         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13480         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13481         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13482         (maintenance_print_msymbols): Use all_objfiles.
13483         * source.c (select_source_symtab): Use all_objfiles.
13484         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13485         * symfile.c (remove_symbol_file_command)
13486         (expand_symtabs_matching, map_symbol_filenames): Use
13487         all_objfiles.
13488         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13489         all_objfiles.
13490         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13491         * objc-lang.c (find_methods): Use all_objfiles.
13492         * objfiles.c (have_partial_symbols, have_full_symbols)
13493         (have_minimal_symbols, qsort_cmp)
13494         (default_iterate_over_objfiles_in_search_order): Use
13495         all_objfiles.
13496         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13497         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13498         (maintenance_check_psymtabs): Use all_objfiles.
13499         (ALL_PSYMTABS): Remove.
13500         * compile/compile-object-run.c (do_module_cleanup): Use
13501         all_objfiles.
13502         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13503         * cp-support.c (add_symbol_overload_list_qualified): Use
13504         all_objfiles.
13505         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13506         Use all_objfiles.
13507         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13508         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13509         all_objfiles.
13510         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13511         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13512         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13513         Uses all_objfiles.
13514         * solib.c (solib_read_symbols): Use all_objfiles
13515
13516 2019-01-09  Tom Tromey  <tom@tromey.com>
13517
13518         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13519         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13520         all_objfiles.
13521         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13522         * symmisc.c (print_symbol_bcache_statistics)
13523         (print_objfile_statistics, maintenance_print_objfiles)
13524         (maintenance_info_symtabs, maintenance_check_symtabs)
13525         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13526         all_objfiles.
13527         * source.c (forget_cached_source_info): Use all_objfiles.
13528         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13529         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13530         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13531         * objfiles.c (update_section_map): Use all_objfiles.
13532         (shared_objfile_contains_address_p): Likewise.
13533         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13534         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13535
13536 2019-01-09  Tom Tromey  <tom@tromey.com>
13537
13538         * common/next-iterator.h: New file.
13539         * objfiles.h (class all_objfiles): New.
13540         (struct objfile_iterator): New.
13541
13542 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13543
13544         * NEWS: Move the description of the changed "frame", "select-frame",
13545          and "info frame" commands to the Changed commands section.
13546
13547 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13548
13549         * gdbtypes.c (check_stub_method_group): Remove handling of old
13550         mangling schemes.
13551         * linespec.c (find_methods): Likewise.
13552         * stabsread.c (read_member_functions): Likewise.
13553         * valops.c (search_struct_method): Likewise.
13554         (value_struct_elt_for_reference): Likewise.
13555         * NEWS: Mention this change.
13556
13557 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13558
13559         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13560         print_source_lines.
13561         * source.c (print_source_lines_base): Update line number check.
13562         (print_source_lines): New function.
13563         (source_lines_range::source_lines_range): New function.
13564         * source.h (class source_lines_range): New class.
13565         (print_source_lines): New declaration.
13566
13567 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13568
13569         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13570
13571 2019-01-08  Tom Tromey  <tom@tromey.com>
13572             Simon Marchi  <simon.marchi@ericsson.com>
13573
13574         PR gdb/24060
13575         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13576         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13577         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13578         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13579         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13580         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13581
13582 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13583
13584         * source.c (select_source_symtab): Move header comment to
13585         declaration in source.h.
13586         (forget_cached_source_info_for_objfile): Likewise.
13587         (forget_cached_source_info): Likewise.
13588         (identify_source_line): Likewise.
13589         * source.h (identify_source_line): Move declaration from symtab.h
13590         and add comment from source.c
13591         (print_source_lines): Likewise.
13592         (forget_cached_source_info_for_objfile): Likewise.
13593         (forget_cached_source_info): Likewise.
13594         (select_source_symtab): Likewise.
13595         (enum print_source_lines_flag): Move definition from symtab.h.
13596         * symtab.h (identify_source_line): Move declaration to source.h.
13597         (print_source_lines): Likewise.
13598         (forget_cached_source_info_for_objfile): Likewise.
13599         (forget_cached_source_info): Likewise.
13600         (select_source_symtab): Likewise.
13601         (enum print_source_lines_flag): Move definition to source.h.
13602         * tui/tui-hooks.c: Add 'source.h' include.
13603
13604 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13605
13606         * source.c (print_source_lines_base): Handle requests to print
13607         reverse line number sequences, and guard against empty lines
13608         string.
13609
13610 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13611
13612         * source.c (print_source_lines_base): Fix skip of '\r' if next
13613         character is '\n'.
13614
13615 2019-01-06  Tom Tromey  <tom@tromey.com>
13616
13617         * c-exp.y (struct c_parse_state) <macro_original_text,
13618         expansion_obstack>: New member.
13619         (macro_original_text, expansion_obstack): Remove globals.
13620         (scan_macro_expansion, scanning_macro_expansion)
13621         (finished_macro_expansion): Update.
13622         (scan_macro_cleanup): Remove.
13623         (yylex, c_parse): Update.
13624
13625 2019-01-06  Tom Tromey  <tom@tromey.com>
13626
13627         * c-exp.y (struct c_parse_state) <strings>: New member.
13628         (operator_stoken): Update.
13629
13630 2019-01-06  Tom Tromey  <tom@tromey.com>
13631
13632         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13633         (union type_stack_elt) <typelist_val>: Now a pointer to
13634         std::vector.
13635         (type_stack_cleanup): Don't declare.
13636         (push_typelist): Update.
13637         * parse.c (pop_typelist): Return a std::vector.
13638         (push_typelist): Take a std::vector.
13639         (follow_types): Update.  Do not free args.
13640         (type_stack_cleanup): Remove.
13641         * c-exp.y (struct c_parse_state): New.
13642         (cpstate): New global.
13643         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13644         (nonempty_typelist): Update.
13645         (func_mod): Create a new vector.
13646         (c_parse): Create a c_parse_state.
13647         (check_parameter_typelist): Do not delete params.
13648         (function_method): Update.  Do not delete type_list.
13649
13650 2019-01-06  Tom Tromey  <tom@tromey.com>
13651
13652         PR gdb/28155:
13653         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13654         check_typedef.
13655         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13656         (print_return_value): Likewise.
13657
13658 2019-01-05  Tom Tromey  <tom@tromey.com>
13659
13660         * contrib/cleanup_check.py: Remove.
13661         * contrib/gcc-with-excheck: Remove.
13662         * contrib/exsummary.py: Remove.
13663         * contrib/excheck.py: Remove.
13664
13665 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13666
13667         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13668         NULL. Initialize tpprev to NULL instead of assigning it
13669         to NULL on the next statement.
13670         * windows-nat.c (windows_delete_thread): Remove check for
13671         main_thread_id before printing thread exit notifications.
13672         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13673         Remove thread ID check against main_thread_id.
13674         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13675         windows_delete_thread.
13676         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13677
13678 2019-01-04  Tom Tromey  <tom@tromey.com>
13679
13680         * compile/compile.c (_initialize_compile): Use upper case for
13681         metasyntactic variables.
13682         * symmisc.c (_initialize_symmisc): Use upper case for
13683         metasyntactic variables.
13684         * psymtab.c (_initialize_psymtab): Use upper case for
13685         metasyntactic variables.
13686         * demangle.c (demangle_command): Use upper case for metasyntactic
13687         variables.
13688         (_initialize_demangler): Likewise.
13689         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13690         variables.
13691
13692 2019-01-03  Tom Tromey  <tom@tromey.com>
13693
13694         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13695
13696 2019-01-03  Tom Tromey  <tom@tromey.com>
13697
13698         * python/py-symtab.c (salpy_str): Update.
13699         (struct salpy_sal_object) <symtab>: Now a PyObject.
13700         (salpy_dealloc): Update.
13701         (del_objfile_sal): Use gdbpy_ref.
13702
13703 2019-01-03  Tom Tromey  <tom@tromey.com>
13704
13705         * python/py-type.c (convert_field): Use new_reference.  Return
13706         gdbpy_ref.
13707         (make_fielditem): Return gdbpy_ref.
13708         (typy_fields): Update.
13709         (typy_getitem): Update.
13710         (field_name): Return gdbpy_ref.  Use new_reference.
13711         (typy_iterator_iternext): Update.
13712
13713 2019-01-03  Tom Tromey  <tom@tromey.com>
13714
13715         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13716
13717 2019-01-03  Tom Tromey  <tom@tromey.com>
13718
13719         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13720         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13721         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13722         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13723         (pspy_set_type_printers): Likewise.
13724         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13725         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13726         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13727         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13728         (objfpy_set_type_printers): Likewise.
13729
13730 2019-01-03  Tom Tromey  <tom@tromey.com>
13731
13732         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13733         (gdbpy_print_stack): Use gdbpy_err_fetch.
13734         * python/python-internal.h (class gdbpy_err_fetch): New class.
13735         (class gdbpy_enter) <m_error_type, m_error_value,
13736         m_error_traceback>: Remove.
13737         <m_error>: New member.
13738         (gdbpy_exception_to_string): Don't declare.
13739         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13740         * python/py-value.c (convert_value_from_python): Use
13741         gdbpy_err_fetch.
13742         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13743         gdbpy_exception_to_string.
13744         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13745         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13746         gdbpy_err_fetch.
13747
13748 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13749
13750         * linux-nat.c (delete_lwp_cleanup): Delete.
13751         (struct lwp_deleter): New struct.
13752         (lwp_info_up): New typedef.
13753         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13754         lwp_info_up.
13755
13756 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13757
13758         * linux-fork.c (class scoped_switch_fork_info): New class.
13759         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13760
13761 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13762
13763         * valops.c (find_overload_match): Remove use of null_cleanup, and
13764         calls to do_cleanups.
13765
13766 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13767
13768         * compile/compile-cplus-types.c
13769         (compile_cplus_instance::decl_name): Handle changes to
13770         cp_func_name.
13771         * cp-support.c (cp_func_name): Update header comment, update
13772         return type.
13773         * cp-support.h (cp_func_name): Update return type in declaration.
13774         * valops.c (find_overload_match): Move temp_func local to top
13775         level of function and change its type.  Use temp_func to hold and
13776         delete temporary string obtained from cp_func_name.
13777
13778 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13779
13780         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13781         gdb::char_vector, remove cleanup, and update uses of `msg`.
13782
13783 2019-01-03  Jim Wilson  <jimw@sifive.com>
13784
13785         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13786
13787 2019-01-02  Tom Tromey  <tom@tromey.com>
13788
13789         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13790         (tdesc_parse_xml): Remove cleanups.
13791         * target-descriptions.h (make_cleanup_free_target_description):
13792         Don't declare.
13793         (target_desc_deleter): New struct.
13794         (target_desc_up): New typedef.
13795         * target-descriptions.c (target_desc_deleter::operator()): Rename
13796         from free_target_description.
13797         (make_cleanup_free_target_description): Remove.
13798
13799 2019-01-02  Tom Tromey  <tom@tromey.com>
13800
13801         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13802         constructor, destructor.
13803         (linespec_parser): Remove typedef.
13804         (~linespec_parser): Rename from linespec_parser_delete.
13805         (linespec_lex_to_end, linespec_complete_label)
13806         (linespec_complete): Update.
13807         (decode_line_full): Remove cleanups.
13808         (decode_line_1): Update.
13809
13810 2019-01-02  Tom Tromey  <tom@tromey.com>
13811
13812         * python/python-internal.h (inferior_to_inferior_object): Change
13813         return type.
13814         * python/py-exitedevent.c (create_exited_event_object): Update.
13815         * python/py-inferior.c (inferior_to_inferior_object): Return
13816         gdbpy_ref.
13817         (python_new_inferior, python_inferior_deleted)
13818         (thread_to_thread_object, delete_thread_object)
13819         (build_inferior_list, gdbpy_selected_inferior): Update.
13820         * python/py-infthread.c (create_thread_object): Update.  Also fail
13821         if inferior_to_inferior_object fails.
13822
13823 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13824
13825         * inferior.h (class inferior) <displaced_step_state>: New field.
13826         * infrun.h (struct displaced_step_state): Move here from
13827         infrun.c.  Initialize fields, add constructor.
13828         <inf>: Remove field.
13829         <reset>: New method.
13830         * infrun.c (struct displaced_step_inferior_state): Move to
13831         infrun.h.
13832         (displaced_step_inferior_states): Remove.
13833         (get_displaced_stepping_state): Adust.
13834         (displaced_step_in_progress_any_inferior): Adjust.
13835         (displaced_step_in_progress_thread): Adjust.
13836         (displaced_step_in_progress): Adjust.
13837         (add_displaced_stepping_state): Remove.
13838         (get_displaced_step_closure_by_addr): Adjust.
13839         (remove_displaced_stepping_state): Remove.
13840         (infrun_inferior_exit): Call displaced_step_state.reset.
13841         (use_displaced_stepping): Don't check for NULL.
13842         (displaced_step_prepare_throw): Call
13843         get_displaced_stepping_state.
13844         (displaced_step_fixup): Don't check for NULL.
13845         (prepare_for_detach): Don't check for NULL.
13846
13847 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13848
13849         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13850          in case of call that did not complete.
13851
13852 2019-01-02  Andrey Utkin  <autkin@undo.io>
13853
13854         * symfile.c (find_separate_debug_file): Fix search of debug files for
13855         remote debuggee.
13856
13857 2019-01-02  Tom Tromey  <tom@tromey.com>
13858
13859         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13860         indentation.
13861         * python/py-frame.c (frapy_older): Remove cast.
13862         (frapy_newer): Likewise.
13863         * python/py-breakpoint.c (local_setattro): Remove cast.
13864         * python/py-arch.c (archpy_name): Remove local variable.
13865         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13866
13867 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13868
13869         * unittests/basic_string_view/element_access/char/empty.cc:
13870         Fix year range in copyright header.
13871
13872 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13873
13874         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13875         Delete.
13876         <operator==>: Update with for removed field.
13877         <hash>: Likewise.
13878         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13879         <isa_features>: ...this.
13880         <abi_features>: New field.
13881         (riscv_isa_flen): Update comment.
13882         (riscv_abi_xlen): New declaration.
13883         (riscv_abi_flen): New declaration.
13884         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13885         isa_features.
13886         (riscv_abi_xlen): New function.
13887         (riscv_isa_flen): Update to get answer from isa_features.
13888         (riscv_abi_flen): New function.
13889         (riscv_has_fp_abi): Update to get answer from abi_features.
13890         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13891         xlen and flen.
13892         (riscv_call_info) <xlen, flen>: Update comment.
13893         (riscv_call_arg_struct): Remove invalid assertions
13894         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13895         is removed.
13896         (riscv_gdbarch_init): Gather isa features and abi features
13897         separately, ensure both match on the gdbarch when reusing an old
13898         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13899         a target with 64-bit float hardware.
13900
13901 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13902
13903         * source.c (search_command_helper): Stop reverse search
13904         when line 1 has been searched.
13905
13906 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13907
13908         * record-full.c (record_full_base_target::close): Rewrite
13909         record_full_core_buf_list free logic.
13910
13911 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13912
13913         * break-catch-syscall.c (print_one_catch_syscall): xfree
13914         the last text.
13915
13916 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13917
13918         * top.c (print_gdb_version): Update Copyright year in version
13919         message.
13920
13921 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13922
13923         Update copyright year range in all GDB files.
13924
13925 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13926
13927         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13928
13929 For older changes see ChangeLog-2018.
13930 \f
13931 Local Variables:
13932 mode: change-log
13933 left-margin: 8
13934 fill-column: 74
13935 version-control: never
13936 coding: utf-8
13937 End:
13938