gdb/ChangeLog

   1 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * unittests/help-doc-selftests.c: New file.
   4         * Makefile.in: Add the new file.
   5
   6 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   7
   8         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
   9         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
  10         the full first line, except when FOR_VALUE_PREFIX.  In this case,
  11         the trailing '.' is not output, and the first character is uppercased.
  12         (print_help_for_command): Update call to print_doc_line.
  13         (print_doc_of_command): Likewise.
  14         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
  15         * cli/cli-option.c (append_indented_doc): Do not append newline.
  16         (build_help_option): Append newline after first appended_indented_doc
  17         only if a second call is done.
  18         (build_help): Append 2 new lines before each option, except the first
  19         one.
  20         * compile/compile.c (_initialize_compile): Add new lines after
  21         %OPTIONS%, when not at the end of the help.
  22         Change help doc or code
  23         producing the help doc to respect the invariants.
  24         * maint-test-options.c (_initialize_maint_test_options): Likewise.
  25         Also removed the new line after 'Options:', as all other commands
  26         do not put an empty line between 'Options:' and the first option.
  27         * printcmd.c (_initialize_printcmd): Likewise.
  28         * stack.c (_initialize_stack): Likewise.
  29         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
  30         incorrectly telling COMMAND is optional.
  31         * ada-lang.c (_initialize_ada_language): Change help doc or code
  32         producing the help doc to respect the invariants.
  33         * ada-tasks.c (_initialize_ada_tasks): Likewise.
  34         * breakpoint.c (_initialize_breakpoint): Likewise.
  35         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
  36         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
  37         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
  38         * cli/cli-style.c (cli_style_option::add_setshow_commands,
  39         _initialize_cli_style): Likewise.
  40         * corelow.c (core_target_info): Likewise.
  41         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
  42         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
  43         * filesystem.c (_initialize_filesystem): Likewise.
  44         * frame.c (_initialize_frame): Likewise.
  45         * gnu-nat.c (add_task_commands): Likewise.
  46         * infcall.c (_initialize_infcall): Likewise.
  47         * infcmd.c (_initialize_infcmd): Likewise.
  48         * interps.c (_initialize_interpreter): Likewise.
  49         * language.c (_initialize_language): Likewise.
  50         * linux-fork.c (_initialize_linux_fork): Likewise.
  51         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
  52         * maint.c (_initialize_maint_cmds): Likewise.
  53         * memattr.c (_initialize_mem): Likewise.
  54         * printcmd.c (_initialize_printcmd): Likewise.
  55         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
  56         _RegEx): Likewise.
  57         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
  58         * record-btrace.c (_initialize_record_btrace): Likewise.
  59         * record-full.c (_initialize_record_full): Likewise.
  60         * record.c (_initialize_record): Likewise.
  61         * regcache-dump.c (_initialize_regcache_dump): Likewise.
  62         * regcache.c (_initialize_regcache): Likewise.
  63         * remote.c (add_packet_config_cmd, init_remote_threadtests,
  64         _initialize_remote): Likewise.
  65         * ser-tcp.c (_initialize_ser_tcp): Likewise.
  66         * serial.c (_initialize_serial): Likewise.
  67         * skip.c (_initialize_step_skip): Likewise.
  68         * source.c (_initialize_source): Likewise.
  69         * stack.c (_initialize_stack): Likewise.
  70         * symfile.c (_initialize_symfile): Likewise.
  71         * symtab.c (_initialize_symtab): Likewise.
  72         * target-descriptions.c (_initialize_target_descriptions): Likewise.
  73         * top.c (init_main): Likewise.
  74         * tracefile-tfile.c (tfile_target_info): Likewise.
  75         * tracepoint.c (_initialize_tracepoint): Likewise.
  76         * tui/tui-win.c (_initialize_tui_win): Likewise.
  77         * utils.c (add_internal_problem_command): Likewise.
  78         * valprint.c (value_print_option_defs): Likewise.
  79
  80 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
  81
  82         PR build/24886
  83         * configure.ac: Drop enable-libmcheck support.
  84         * configure, config.in: Rebuild.
  85         * libmcheck.m4: Remove.
  86         * acinclude.m4: Don't include it.
  87         * Makefile.in: Don't distribute it.
  88         * top.c (print_gdb_configuration): Don't mention it.
  89
  90 2019-08-06  Tom Tromey  <tom@tromey.com>
  91
  92         * utils.c (set_output_style): Sometimes pass stream to
  93         emit_style_escape.
  94         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
  95         * record-btrace.c (btrace_insn_history): Update.
  96         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
  97         method.
  98         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
  99         Update initializers.
 100         <m_uiout>: New field.
 101         <m_di>: Move lower.
 102         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 103         Remove "uiout" parameter.
 104         (dump_insns): Update.
 105         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 106         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 107
 108 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 109
 110         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 111         (error_in_psymtab_expansion): Likewise.
 112         (lookup_symbol_via_quick_fns): Likewise.
 113         (basic_lookup_transparent_type_quick): Likewise.
 114         (basic_lookup_transparent_type_1): Likewise.
 115
 116 2019-08-06  Tom Tromey  <tromey@adacore.com>
 117
 118         * source.c (last_source_error): Now bool.
 119         (print_source_lines_base): Make "noprint" bool.  Only open
 120         source file when last_source_visited changes.
 121
 122 2019-08-06  Tom Tromey  <tromey@adacore.com>
 123
 124         * annotate.c (annotate_source_line): Use g_source_cache.
 125         * source-cache.c (source_cache::get_plain_source_lines): Change
 126         parameters.  Populate m_offset_cache.
 127         (source_cache::ensure): New method.
 128         (source_cache::get_line_charpos): New method.
 129         (extract_lines): Move lower.  Change parameters.
 130         (source_cache::get_source_lines): Move lower.
 131         * source-cache.h (class source_cache): Update comment.
 132         <get_line_charpos>: New method.
 133         <get_source_lines>: Update comment.
 134         <clear>: Clear m_offset_cache.
 135         <get_plain_source_lines>: Change parameters.
 136         <ensure>: New method
 137         <m_offset_cache>: New member.
 138         * source.c (forget_cached_source_info_for_objfile): Update.
 139         (info_source_command): Use g_source_cache.
 140         (find_source_lines, open_source_file_with_line_charpos): Remove.
 141         (print_source_lines_base, search_command_helper): Use g_source_cache.
 142         * source.h (open_source_file_with_line_charpos): Don't declare.
 143         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 144         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 145         Use g_source_cache.
 146
 147 2019-08-06  Tom Tromey  <tromey@adacore.com>
 148
 149         * source-cache.c (source_cache::get_plain_source_lines):
 150         Remove "first_line" and "last_line" parameters.
 151         (source_cache::get_source_lines): Cache plain text.
 152         * source-cache.h (class source_cache)
 153         <get_plain_source_lines>: Update.
 154
 155 2019-08-06  Tom Tromey  <tromey@adacore.com>
 156
 157         * source-cache.c (extract_lines): No longer a method.
 158         Changed type of parameter.  Include final newline.
 159         (selftests::extract_lines_test): New function.
 160         (_initialize_source_cache): Likewise.
 161         * source-cache.h (class source_cache)
 162         <extract_lines>: Don't declare.
 163
 164 2019-08-06  Tom Tromey  <tromey@adacore.com>
 165
 166         * breakpoint.c (init_breakpoint_sal): Update.
 167         (breakpoint): Update.
 168         * breakpoint.h (struct breakpoint) <filter>: Now a
 169         unique_xmalloc_ptr.
 170
 171 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 172
 173         * NEWS: Mention dictionary access on blocks.
 174         * python/py-block.c (blpy_getitem): New function.
 175         (block_object_as_mapping): New struct.
 176         (block_object_type): Use new struct for tp_as_mapping field.
 177
 178 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 179
 180         * objfiles.h (objfile): Add a comment describing partial symbols.
 181
 182 2019-08-05  Tom Tromey  <tromey@adacore.com>
 183
 184         * compile/compile.c (_initialize_compile): Use _(), not N_().
 185         * thread.c (_initialize_thread): Use _(), not N_().
 186         * stack.c (_initialize_stack): Use _(), not N_().
 187         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 188
 189 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 190
 191         * dwarf2read.c (struct dw2_symtab_iterator):
 192         <want_specific_block>: Remove.
 193         <block_index>: Change type to gdb::optional.
 194         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 195         change type of BLOCK_INDEX parameter to gdb::optional.
 196         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 197         (dw2_lookup_symbol): Don't pass argument for
 198         WANT_SPECIFIC_BLOCK.
 199         (dw2_expand_symtabs_for_function): Don't pass argument for
 200         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 201         (class dw2_debug_names_iterator)
 202         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 203         parameter, change BLOCK_INDEX type to gdb::optional.
 204         <m_want_specific_block>: Remove.
 205         <m_block_index>: Change type to gdb::optional.
 206         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 207         gdb::optional.  Re-write in function of gdb::optional.
 208         (dw2_debug_names_lookup_symbol): Don't pass argument for
 209         WANT_SPECIFIC_BLOCK.
 210         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 211         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 212         BLOCK_INDEX.
 213
 214 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 215
 216         * NEWS: Mention changes to "info sources" command.
 217
 218 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 219
 220         * symtab.c (filename_partial_match_opts): New struct type.
 221         (struct output_source_filename_data): New members
 222         regexp, c_regexp, partial_match.
 223         (output_source_filename): Use new members to decide to print file.
 224         (info_sources_option_defs): New variable.
 225         (make_info_sources_options_def_group, print_info_sources_header,
 226         info_sources_command_completer):
 227         New functions.
 228         (info_sources_command): Read new optional arguments.
 229         (_initialize_symtab): Update info sources help.
 230
 231 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 232
 233         * ada-lang.c (exception_support_info_v0): Renamed from...
 234         (default_exception_support_info): ... this.  Create new
 235         definition for v1.
 236         (ada_has_this_exception_support): Look up catch_handlers_sym.
 237         (ada_exception_support_info_sniffer): Try v0 after default.
 238
 239 2019-08-01  Tom Tromey  <tromey@adacore.com>
 240
 241         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 242         gdbarch.h.
 243
 244 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 245
 246         * s12z-tdep.c: Fix include path for s12z-opc.h.
 247
 248 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 249
 250         * NEWS: Require GNU make 3.82.
 251
 252 2019-07-16  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 255         declare.
 256
 257 2019-07-30  Tom Tromey  <tromey@adacore.com>
 258
 259         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 260
 261 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 262
 263         * printcmd.c (print_address_symbolic): Print negative offsets.
 264         (build_address_symbolic): Force signed arithmetic when computing
 265         offset.
 266
 267 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 268
 269         PR/24474: Add a function to lookup static variables.
 270         * NEWS: Mention this new function.
 271         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 272         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 273         * python/python.c (python_GdbMethods): Add new function.
 274
 275 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 276
 277         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 278         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 279         (objfpy_lookup_static_symbol): New function.
 280         (objfile_object_methods): Add new functions.
 281
 282 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 283
 284         * NEWS: Mention 'set|show print frame-info'.  Mention new
 285         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 286         backtrace argument.  Mention that python frame filtering code
 287         is now consistent with what 'backtrace' command prints.
 288
 289 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 290
 291         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 292         comments.
 293         (print_frame_info_auto, print_frame_info_source_line,
 294         print_frame_info_location, print_frame_info_source_and_location,
 295         print_frame_info_location_and_address, print_frame_info_short_location):
 296         New declarations.
 297         (struct frame_print_options): New member print_frame_info.
 298         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 299         * stack.h (get_user_print_what_frame_info): New declaration.
 300         (frame_show_address): New declaration.
 301         * stack.c (print_frame_arguments_choices): New value 'presence'.
 302         (print_frame_info_auto, print_frame_info_source_line,
 303         print_frame_info_location, print_frame_info_source_and_location,
 304         print_frame_info_location_and_address, print_frame_info_short_location,
 305         print_frame_info_choices, print_frame_info_print_what): New definitions.
 306         (print_frame_args): Only print dots for args if print frame-arguments
 307         is 'presence'.
 308         (frame_print_option_defs): New element for "frame-info".
 309         (get_user_print_what_frame_info): New function.
 310         (frame_show_address): Make non static.  Move comment to stack.h.
 311         (print_frame_info_to_print_what): New function.
 312         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 313         to decide what to print.
 314         (backtrace_command_1): Handle the new print_frame_arguments_presence
 315         value.
 316         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 317         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 318         (py_print_frame): In non-mi mode, use LOCATION as default for
 319         print_what, similarly to frame information printed directly by
 320         backtrace command. Handle frame-info user option in non MI mode.
 321
 322 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 323
 324         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 325         Add case for debugging 32-bit target on 64-bit host.  Revise
 326         comment.
 327
 328 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 329
 330         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 331         instead of find_function_entry_range_from_pc.
 332
 333 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 334
 335         * stack.c (find_frame_funname): Remove code which preferred
 336         minsym over symtab sym in "certain pathological cases".
 337
 338         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 339         parameter.  Change type of "do_demangle" to bool.
 340         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 341         Pass suitable "prefer_sym_over_minsym" flag to
 342         build_address_symbolic().  Don't output "+" for negative offsets.
 343         * printcmd.c (print_address_symbolic): Update invocation of
 344         build_address_symbolic to include a "prefer_sym_over_minsym"
 345         flag.
 346         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 347         Restrict cases in which use of minimal symbol is preferred to that
 348         of a found symbol.  Update comments.
 349
 350         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 351         for entry pc when entry pc is out of range for that FDE.
 352
 353 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 354
 355         PR gdb/24839:
 356         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 357         type.
 358
 359 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 360
 361         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 362         this function's Python signature.
 363
 364
 365 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 366
 367         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 368         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 369         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 370         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 371         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 372
 373
 374 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 375
 376         * h8300-tdep.c (h8300_register_name_common): New.
 377         h8300_register_name): Use h8300_register_name_common.
 378         (h8300s_register_name): Likewise.
 379         (h8300sx_register_name): Likewise.
 380         (h8300h_register_nam): New.
 381         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 382
 383
 384 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 385
 386         * arm-tdep.c (arm_skip_cmse_entry): New function.
 387         (arm_is_sgstubs_section): New function.
 388         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 389
 390 2019-07-22  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 393         Don't self-assign.
 394
 395 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 396
 397         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 398         type_print.
 399
 400 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 401
 402         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 403         so that GDB doesn't match any msymbols when searching in the
 404         TYPES_DOMAIN.
 405         (print_symbol_info): Print using typedef_print or type_print based
 406         on the type of the symbol.  Add updated FIXME comment moved from...
 407         (_initialize_symtab): ... move and update FIXME comment to above.
 408
 409 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 410
 411         * NEWS: Mention adding -q option to "info types".
 412         * symtab.c (struct info_types_options): New struct.
 413         (info_types_options_defs): New variable.
 414         (make_info_types_options_def_group): New function.
 415         (info_types_command): Use gdb::option framework to parse options.
 416         (info_types_command_completer): New function.
 417         (_initialize_symtab): Extend the help text on "info types" and
 418         register command completer.
 419
 420 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 421
 422         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 423         (lookup_symbol_in_objfile): Change int to block_enum and add a
 424         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 425
 426 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 427
 428         * MAINTAINERS (Write After Approval): Add self.
 429
 430 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 431
 432         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 433         instruction to the dummy code region.
 434
 435 2019-07-19  Tom Tromey  <tromey@adacore.com>
 436
 437         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 438         (ARGSUSED, PARAMS, __func__): Remove rules.
 439
 440 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 441
 442         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 443         * features/arm/arm-with-iwmmxt.c: Remove.
 444         * features/arm/arm-with-iwmmxt.xml: Remove.
 445         * features/arm/arm-with-m-fpa-layout.c: Remove.
 446         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 447         * features/arm/arm-with-m-vfp-d16.c: Remove.
 448         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 449         * features/arm/arm-with-m.c: Remove.
 450         * features/arm/arm-with-m.xml: Remove.
 451         * features/arm/arm-with-neon.c: Remove.
 452         * features/arm/arm-with-neon.xml: Remove.
 453         * features/arm/arm-with-vfpv2.c: Remove.
 454         * features/arm/arm-with-vfpv2.xml: Remove.
 455         * features/arm/arm-with-vfpv3.c: Remove.
 456         * features/arm/arm-with-vfpv3.xml: Remove.
 457
 458 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 459
 460         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 461
 462 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 463
 464         * arch/aarch32.c (aarch32_create_target_description): Create
 465         target descriptions using features.
 466         * arch/arm.c (arm_create_target_description)
 467         (arm_create_mprofile_target_description): Likewise.
 468         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 469
 470 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 471
 472         * Makefile.in: Add new files.
 473         * aarch32-tdep.c: New file.
 474         * aarch32-tdep.h: New file.
 475         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 476         Call aarch32_read_description.
 477         * arch/aarch32.c: New file.
 478         * arch/aarch32.h: New file.
 479         * arch/arm.c (arm_create_target_description)
 480         (arm_create_mprofile_target_description): New function.
 481         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 482         (arm_create_target_description)
 483         (arm_create_mprofile_target_description): New declaration.
 484         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 485         read_description functions.
 486         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 487         Likewise.
 488         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 489         * arm-tdep.c (tdesc_arm_list): New variable.
 490         (arm_register_g_packet_guesses): Call create description functions.
 491         (arm_read_description) (arm_read_mprofile_description): New
 492         function.
 493         * arm-tdep.h (arm_read_description)
 494         (arm_read_mprofile_description): Add declaration.
 495         * configure.tgt: Add new files.
 496
 497 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 498
 499         * top.c (new_ui_command): Open specified terminal just once.
 500
 501 2019-07-18  Tom Tromey  <tromey@adacore.com>
 502
 503         * symtab.c (main_name): Constify return type.
 504         * symfile.c (set_initial_language): Update.
 505         * symtab.h (main_name): Constify return type.
 506
 507 2019-07-17  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-winsource.c (tui_update_source_window)
 510         (tui_update_source_window_as_is)
 511         (tui_update_source_windows_with_line): Remove return.
 512         * tui/tui-disasm.c (tui_show_disassem)
 513         (tui_show_disassem_and_update_source): Remove return.
 514         * tui/tui.c (tui_reset): Remove return.
 515         * tui/tui-wingeneral.c
 516         (tui_check_and_display_highlight_if_needed): Remove return.
 517
 518 2019-07-17  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 521
 522 2019-07-17  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-winsource.h (struct tui_exec_info_window)
 525         (struct tui_source_window_base): Move from tui-data.h.
 526         * tui/tui-winsource.c: Move many method definitions from
 527         elsewhere.  Remove "structuring" comments.
 528         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 529         (tui_source_window_base::refresh_window): Move to
 530         tui-winsource.c.
 531         * tui/tui-win.c (tui_source_window_base::refresh_all)
 532         (tui_source_window_base::update_tab_width)
 533         (tui_source_window_base::set_new_height)
 534         (tui_source_window_base::do_make_visible_with_new_height): Move to
 535         tui-winsource.c.
 536         * tui/tui-source.h: Update.
 537         * tui/tui-source.c (tui_source_window_base::reset): Move to
 538         tui-winsource.c.
 539         * tui/tui-disasm.h: Update.
 540         * tui/tui-data.h (struct tui_exec_info_window): Move to
 541         tui-winsource.h.
 542         (struct tui_source_window_base): Likewise.
 543         * tui/tui-data.c (tui_source_window_base::clear_detail)
 544         (tui_source_window_base, ~tui_source_window_base): Move to
 545         tui-winsource.c.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-win.c (tui_resize_all)
 550         (tui_source_window_base::update_tab_width)
 551         (tui_adjust_win_heights): Update.
 552         (tui_win_info::make_invisible_and_set_new_height): Rename from
 553         make_invisible_and_set_new_height.
 554         * tui/tui-data.h (struct tui_win_info)
 555         <make_invisible_and_set_new_height>: New method.
 556
 557 2019-07-17  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui.c: Update.
 560         * tui/tui-source.h (struct tui_source_window): Move from
 561         tui-data.h.
 562         * tui/tui-layout.c: Update.
 563         * tui/tui-disasm.c: Update.
 564         * tui/tui-data.h (struct tui_source_window): Move to
 565         tui-source.h.
 566
 567 2019-07-17  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 570         tui-data.h.
 571         * tui/tui-data.h (struct tui_disasm_window): Move to
 572         tui-disasm.h.
 573
 574 2019-07-17  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-regs.h (struct tui_data_item_window): Move from
 577         tui-data.h.
 578         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 579         * tui/tui-data.h (struct tui_data_item_window): Move to
 580         tui-regs.h.
 581         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 582
 583 2019-07-17  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui.c: Update.
 586         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 587         (tui_cmd_window::max_height): Move to tui-command.c.
 588         * tui/tui-layout.c: Update.
 589         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 590         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 591         tui-command.c.
 592         * tui/tui-command.h (struct tui_cmd_window): Move from
 593         tui-data.h.
 594         * tui/tui-command.c: Remove "structuring" comments.
 595         (tui_cmd_window::clear_detail)
 596         (tui_cmd_window::do_make_visible_with_new_height)
 597         (tui_cmd_window::max_height): Move from elsewhere.
 598
 599 2019-07-17  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 602         Now static.
 603         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 604         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 605
 606 2019-07-17  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui.c: Update.
 609         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 610         tui-regs.c.
 611         * tui/tui-windata.h: Remove file.
 612         * tui/tui-windata.c: Remove file.
 613         * tui/tui-win.c (tui_data_window::set_new_height)
 614         (tui_data_window::do_make_visible_with_new_height): Move to
 615         tui-regs.c.
 616         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 617         * tui/tui-regs.c: Remove "structuring" comments.
 618         (tui_data_window::first_data_item_displayed)
 619         (tui_data_window::delete_data_content_windows)
 620         (tui_data_window::erase_data_content)
 621         (tui_data_window::display_all_data)
 622         (tui_data_window::refresh_all)
 623         (tui_data_window::do_scroll_vertical)
 624         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 625         (tui_data_window::do_make_visible_with_new_height)
 626         (tui_data_window::refresh_window): Move from elsewhere.
 627         (_initialize_tui_regs): Move to end of file.
 628         * tui/tui-layout.c: Update.
 629         * tui/tui-hooks.c: Update.
 630         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 631         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 632         tui-regs.c.
 633         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 634
 635 2019-07-17  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 638         seen.
 639
 640 2019-07-17  Tom Tromey  <tom@tromey.com>
 641
 642         * tui/tui-win.c (tui_source_window_base::set_new_height)
 643         (tui_source_window_base::do_make_visible_with_new_height): Use
 644         m_has_locator field directly.
 645         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 646         method.
 647         (struct tui_source_window_base) <has_locator>: Likewise.
 648
 649 2019-07-17  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 652         Don't declare.
 653         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 654         Remove.
 655         * tui/tui-win.c (tui_source_window_base::set_new_height)
 656         (tui_source_window_base::set_new_height)
 657         (make_invisible_and_set_new_height)
 658         (tui_source_window_base::do_make_visible_with_new_height)
 659         (tui_source_window_base::do_make_visible_with_new_height):
 660         Update.
 661         * tui/tui-layout.c (show_source_disasm_command, show_data)
 662         (show_source_or_disasm_and_command): Update.
 663         * tui/tui-layout.c (show_layout): Update.
 664
 665 2019-07-17  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-layout.c (make_data_window): Remove.
 668         (show_data): Unify creation and re-initialization cases.
 669
 670 2019-07-17  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-layout.c (make_source_window, make_disasm_window):
 673         Remove.
 674         (show_data): Unify creation and re-initialization cases.
 675
 676 2019-07-17  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-layout.c (make_command_window): Remove.
 679         (show_source_disasm_command, show_source_or_disasm_and_command):
 680         Unify creation and re-initialization cases.
 681
 682 2019-07-17  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 685         creation and re-initialization cases.
 686
 687 2019-07-17  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-regs.c (tui_get_register): Return void.
 690
 691 2019-07-17  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 694         Simplify.
 695
 696 2019-07-17  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 699         resetting.
 700
 701 2019-07-17  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 704         * tui/tui-regs.c (tui_reg_layout): New function.
 705         (tui_show_registers, tui_reg_command): Use it.
 706         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 707         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 708         parameters.
 709         (tui_layout_command): Remove.
 710
 711 2019-07-17  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-layout.h (tui/tui-layout): Return void.
 714         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 715
 716 2019-07-17  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-layout.c (show_source_disasm_command, show_data):
 719         Update.
 720         (reset_locator): Remove.
 721         (show_source_or_disasm_and_command): Update.
 722
 723 2019-07-17  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-source.c (tui_source_window_base::reset): Remove
 726         win_type parameter.
 727         * tui/tui-layout.c (make_command_window, make_source_window)
 728         (make_disasm_window, make_data_window)
 729         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 730         (reset_locator, show_source_or_disasm_and_command): Update.
 731         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 732         win_type parameter.
 733         (struct tui_source_window_base) <reset>: Likewise.
 734
 735 2019-07-17  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-layout.c (show_source_disasm_command): Use
 738         reset_locator.
 739         (reset_locator): New function.
 740         (init_and_make_win): Remove.
 741         (show_source_or_disasm_and_command): Use reset_locator.
 742
 743 2019-07-17  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 746         condition.
 747         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 748         Remove condition.
 749         * tui/tui-source.c (tui_source_window_base::reset): New method.
 750         * tui/tui-layout.c (make_command_window): Don't call
 751         init_and_make_win.
 752         (make_source_window, make_disasm_window): Don't call
 753         make_source_or_disasm_window.
 754         (make_data_window): Don't call init_and_make_win.  Change calling
 755         convention.
 756         (show_source_disasm_command, show_data): Simplify.
 757         (make_source_or_disasm_window): Remove.
 758         (show_source_or_disasm_and_command): Simplify.
 759         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 760         (struct tui_source_window_base) <reset>: Likewise.
 761         <execution_info>: Remove initializer.
 762         * tui/tui-data.c (tui_source_window_base): Initialize
 763         execution_info.
 764
 765 2019-07-17  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 768         variable.
 769
 770 2019-07-17  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui.c (tui_rl_other_window): Update.
 773         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 774         superclass method first.  Always iterate over regs_content.
 775         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 776         method.
 777         * tui/tui-win.c (tui_set_focus_command): Update.
 778
 779 2019-07-17  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-win.c (tui_set_focus_command): Rename from
 782         tui_set_focus.  Call tui_enable.
 783         (tui_set_focus_command): Remove.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 788         refresh_window.
 789         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 790         touchwin.
 791         (tui_data_window::refresh_window): Call refresh_window on data
 792         items.  Always call superclass refresh_window.
 793         (tui_win_info::refresh): Remove.
 794         (tui_source_window_base::refresh_window): Update.
 795         (tui_refresh_all): Update.
 796         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 797         refresh_window.
 798         (show_source_or_disasm_and_command): Likewise.
 799         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 800         (struct tui_source_window_base) <refresh>: Likewise.
 801
 802 2019-07-17  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-winsource.c (tui_clear_source_content)
 805         (tui_show_source_content): Update.
 806         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 807         whether content is empty.
 808         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 809         Remove.
 810
 811 2019-07-17  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 814         window's contents.
 815         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 816         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 817
 818 2019-07-17  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 821         (struct tui_data_item_window): Update.
 822
 823 2019-07-17  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 826         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 827         defines.
 828
 829 2019-07-17  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-winsource.h (tui_erase_source_content)
 832         (tui_clear_source_content): Remove "display_prompt" parameter.
 833         * tui/tui-winsource.c (tui_update_source_window_as_is)
 834         (tui_update_source_windows_with_addr): Update.
 835         (tui_clear_source_content): Remove "display_prompt" parameter.
 836         (tui_erase_source_content): Likewise.  Simplify.
 837         (tui_show_source_content): Update.
 838         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 839         * tui/tui-stack.c (tui_show_frame_info): Update.
 840         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 841         Remove defines.
 842
 843 2019-07-17  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 846         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 847         parameter.
 848         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 849         parameter.
 850
 851 2019-07-17  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-winsource.c (tui_clear_source_content)
 854         (tui_show_source_content, tui_show_exec_info_content)
 855         (tui_clear_exec_info_content): Update.
 856         * tui/tui-stack.c (tui_show_locator_content): Update.
 857         (tui_show_frame_info): Update.
 858         * tui/tui-source.h (tui_source_window): Don't declare.
 859         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 860         from tui_source_is_displayed.
 861         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 862         Remove field.
 863         (struct tui_source_window_base) <content_in_use>: New field.  Now
 864         bool.
 865         (struct tui_source_window) <showing_source_p>: New method.
 866         (TUI_SRC_WIN): Change cast.
 867         * tui/tui-data.c (tui_initialize_static_data): Update.
 868
 869 2019-07-17  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 872         location_matches_p.
 873         * tui/tui-source.c (tui_source_window::location_matches_p): New
 874         method.
 875         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 876         method.
 877         * tui/tui-data.h (struct tui_source_window_base)
 878         <location_matches_p>: New method.
 879         (struct tui_source_window, struct tui_disasm_window)
 880         <location_matches_p>: Likewise.
 881
 882 2019-07-17  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-win.c (tui_set_win_height_command): Rename from
 885         tui_set_win_height.
 886         (tui_set_win_height_command): Remove.
 887
 888 2019-07-17  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-source.c (tui_source_window): New constructor.  Add
 891         observer.
 892         (~tui_source_window): New destructor.
 893         (tui_source_window::style_changed): New method.
 894         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 895         (tui_attach_detach_observers): Update.
 896         * tui/tui-data.h (struct tui_source_window): Make constructor not
 897         inline.  Add destructor.
 898         (struct tui_source_window) <style_changed>: New method.
 899         <m_observable>: New member.
 900
 901 2019-07-17  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 904         * tui/tui-win.c (tui_resize_all): Fix typo.
 905
 906 2019-07-17  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 909         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 910         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 911         * tui/tui-win.c (window_name_completer): Use foreach.
 912         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 913         (update_tab_width): Likewise.
 914         * tui/tui-layout.c (show_layout): Update.
 915         * tui/tui-data.h (class tui_window_iterator): New.
 916         (struct all_tui_windows): New.
 917         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 918
 919 2019-07-17  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 922         parameter.  Don't reference globals.
 923         (tui_reg_command): Update.
 924
 925 2019-07-17  Tom Tromey  <tom@tromey.com>
 926
 927         * tui/tui-regs.c (tui_show_registers): Simplify.
 928
 929 2019-07-17  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui-regs.c (tui_show_registers): Update.
 932         (tui_show_register_group): Add win_info parameter.
 933
 934 2019-07-17  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 937         Rename from tui_display_reg_element_at_line.
 938         (tui_data_window::display_registers_from_line): Update.
 939         * tui/tui-data.h (struct tui_data_window)
 940         <display_reg_element_at_line>: New method.
 941
 942 2019-07-17  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-regs.h (tui_display_registers_from)
 945         (tui_display_registers_from_line): Don't declare.
 946         * tui/tui-windata.c (tui_data_window::display_all_data)
 947         (tui_data_window::refresh_all)
 948         (tui_data_window::do_scroll_vertical): Update.
 949         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 950         from tui_display_registers_from.
 951         (tui_display_reg_element_at_line): Update.
 952         (tui_data_window::display_registers_from_line): Rename from
 953         tui_display_registers_from_line.
 954         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 955         display_registers_from_line>: New methods.
 956
 957 2019-07-17  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 960         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 961         from tui_erase_data_content.
 962         (tui_data_window::display_all_data)
 963         (tui_data_window::refresh_all)
 964         (tui_data_window::do_scroll_vertical): Update.
 965         * tui/tui-regs.c (tui_show_registers): Update.
 966         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 967         New method.
 968
 969 2019-07-17  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 972         declare.
 973         * tui/tui-windata.c
 974         (tui_data_window::delete_data_content_windows): Rename from
 975         tui_delete_data_content_windows.
 976         (tui_data_window::display_all_data)
 977         (tui_data_window::do_scroll_vertical): Update.
 978         * tui/tui-data.h (struct tui_data_window)
 979         <delete_data_content_windows>: New method.
 980
 981 2019-07-17  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 984         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 985
 986 2019-07-17  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 989         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 990         from tui_display_all_data.
 991         * tui/tui-win.c
 992         (tui_data_window::do_make_visible_with_new_height): Update.
 993         * tui/tui-regs.c (tui_show_registers): Update.
 994         * tui/tui-layout.c (tui_set_layout): Update.
 995         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 996         method.
 997
 998 2019-07-17  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1001         * tui/tui-windata.c (tui_display_data_from): Remove.
1002         (tui_data_window::refresh_all): Update.
1003
1004 2019-07-17  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1007         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1008         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1009         tui_display_registers_from_line.
1010         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1011         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1012         "force_display" parameter.
1013
1014 2019-07-17  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1017         declare.
1018         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1019         Rename from tui_first_reg_element_no_inline.
1020         (tui_display_reg_element_at_line)
1021         (tui_display_registers_from_line): Update.
1022         * tui/tui-data.h (struct tui_data_window)
1023         <first_reg_element_no_inline>: New method.
1024
1025 2019-07-17  Tom Tromey  <tom@tromey.com>
1026
1027         * tui/tui-windata.c (tui_display_data_from)
1028         (tui_data_window::do_scroll_vertical): Update.
1029         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1030         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1031         Rename from tui_line_from_reg_element_no.
1032         (tui_display_registers_from_line): Update.
1033         * tui/tui-data.h (struct tui_data_window)
1034         <line_from_reg_element_no>: New method.
1035
1036 2019-07-17  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1039         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1040         tui_last_regs_line_no.
1041         (tui_display_reg_element_at_line)
1042         (tui_display_registers_from_line): Update.
1043         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1044         method.
1045
1046 2019-07-17  Tom Tromey  <tom@tromey.com>
1047
1048         PR tui/24722:
1049         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1050         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1051         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1052         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1053         (tui_update_breakpoint_info): Likewise.
1054         * tui/tui-hooks.c (tui_event_create_breakpoint)
1055         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1056         Update.
1057
1058 2019-07-17  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1061
1062 2019-07-17  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-winsource.c (tui_update_source_window_as_is)
1065         (tui_update_source_windows_with_addr): Update.
1066         * tui/tui-source.h (tui_set_source_content)
1067         (tui_show_symtab_source): Add "win_info" parameter.
1068         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1069         parameter.
1070         (tui_show_symtab_source): Likewise.
1071
1072 2019-07-17  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-wingeneral.c
1075         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1076
1077 2019-07-17  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1080         (struct tui_cmd_window) <can_scroll>: New method.
1081         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1082         method.
1083
1084 2019-07-17  Tom Tromey  <tromey@adacore.com>
1085
1086         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1087         do_field_signed>: Rename.  Change type of "value".
1088         * ui-out.c (ui_out::field_signed): Rename from field_int.
1089         Change type of "value".
1090         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1091         type of "value".
1092         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1093         do_field_int.  Change type of "value".
1094         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1095         do_field_int.  Change type of "value".
1096         * tracepoint.c (trace_status_mi, tfind_1)
1097         (print_one_static_tracepoint_marker): Update.
1098         * thread.c (print_thread_info_1, print_selected_thread_frame):
1099         Update.
1100         * stack.c (print_frame, print_frame_info): Update.
1101         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1102         Update.
1103         * source.c (print_source_lines_base): Update.
1104         * skip.c (info_skip_command): Update.
1105         * record-btrace.c (btrace_ui_out_decode_error)
1106         (btrace_call_history_src_line): Update.
1107         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1108         Update.
1109         * progspace.c (print_program_space): Update.
1110         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1111         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1112         do_field_int.  Change type of "value".
1113         * mi/mi-out.c (mi_ui_out::do_table_begin)
1114         (mi_ui_out::do_table_header): Update.
1115         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1116         type of "value".
1117         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1118         (mi_cmd_data_list_changed_registers, output_register)
1119         (mi_cmd_data_read_memory, mi_load_progress)
1120         (mi_cmd_trace_frame_collected): Update.
1121         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1122         Update.
1123         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1124         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1125         (mi_cmd_var_list_children, varobj_update_one): Update.
1126         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1127         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1128         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1129         * inferior.c (print_inferior): Update.
1130         * gdb_bfd.c (print_one_bfd): Update.
1131         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1132         Update.
1133         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1134         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1135         do_field_int.  Change type of "value".
1136         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1137         do_field_int.  Change type of "value".
1138         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1139         (print_one_breakpoint_location, print_it_catch_fork)
1140         (print_one_catch_fork, print_it_catch_vfork)
1141         (print_one_catch_vfork, print_it_catch_solib)
1142         (print_it_catch_exec, print_it_ranged_breakpoint)
1143         (print_mention_watchpoint, print_mention_masked_watchpoint)
1144         (bkpt_print_it, update_static_tracepoint): Update.
1145         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1146         * break-catch-syscall.c (print_it_catch_syscall): Update.
1147         * ada-tasks.c (print_ada_task_info): Update.
1148         * ada-lang.c (print_it_exception, print_mention_exception):
1149         Update.
1150
1151 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         PR breakpoints/24541
1154         * gdbarch.c: Regenerate.
1155         * gdbarch.h: Regenerate.
1156         * gdbarch.sh: Adjust return type and parameter types for
1157         'stap_adjust_register'.
1158         (i386_stap_adjust_register): Adjust signature and return new
1159         register name.
1160         * stap-probe.c (stap_parse_register_operand): Adjust use of
1161         'gdbarch_stap_adjust_register'.
1162
1163 2019-07-17  Tom Tromey  <tromey@adacore.com>
1164
1165         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1166         declare VEC.
1167         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1168         std::vector.
1169         (struct s390_process_info): Add initializers.
1170         (s390_add_process): Use new.
1171         (s390_linux_nat_target::low_forget_process): Use delete.
1172         (s390_linux_nat_target::low_new_fork)
1173         (s390_linux_nat_target::stopped_by_watchpoint)
1174         (s390_linux_nat_target::low_prepare_to_resume)
1175         (s390_linux_nat_target::insert_watchpoint)
1176         (s390_linux_nat_target::insert_hw_breakpoint)
1177         (s390_linux_nat_target::remove_watchpoint)
1178         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1179
1180 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1181
1182         * aarch64-fbsd-nat.c: Include regcache.h.
1183         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1184         argument.
1185         (aarch64_fbsd_nat_target::fetch_registers)
1186         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1187         variable.
1188         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1189
1190 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1191
1192         * fbsd-nat.c: Include gdbarch.h.
1193
1194 2019-07-15  Tom Tromey  <tromey@adacore.com>
1195
1196         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1197
1198 2019-07-15  Tom Tromey  <tromey@adacore.com>
1199
1200         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1201         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1202         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1203         * cli-out.c (cli_ui_out::do_field_int): New method.
1204         * ui-out.c (ui_out::field_unsigned): New method.
1205         * symfile.c (generic_load): Use field_unsigned.
1206         (print_transfer_performance): Likewise.
1207         * record-btrace.c (ui_out_field_uint): Remove.
1208         (btrace_call_history_insn_range, btrace_call_history): Use
1209         field_unsigned.
1210         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1211         field_unsigned.
1212         * ui-out.h (class ui_out) <field_unsigned>: New method.
1213         <do_field_unsigned>: Likewise.
1214
1215 2019-07-15  Tom Tromey  <tromey@adacore.com>
1216
1217         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1218         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1219         * target.c (flash_erase_command): Use field_string.
1220         * infrun.c (print_signal_received_reason): Use field_string.
1221         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1222         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1223         field_string.
1224         * ada-tasks.c (print_ada_task_info): Use field_string.
1225
1226 2019-07-15  Tom Tromey  <tromey@adacore.com>
1227
1228         * target.c (flash_erase_command): Use field_core_addr.
1229         * symfile.c (generic_load): Use field_core_addr.
1230         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1231         Use field_core_addr.
1232         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1233         field_core_addr.
1234
1235 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1238         value if its desired type is smaller than a CORE_ADDR and signed.
1239
1240 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1243         of changes to field names, and use new is_reference field to
1244         decide if a property is a reference or not.
1245         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1246         field.
1247         (struct dwarf2_property_baton): Update header comment, rename
1248         'referenced_type' to 'property_type' and update comments.
1249         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1250         default property type, store in property baton, update to take
1251         accound of renamed field.
1252         (read_func_scope): Update call to attr_to_dynamic_prop.
1253         (read_array_type): Likewise.
1254         (dwarf2_per_cu_addr_sized_int_type): New function.
1255         (read_subrange_index_type): Move type finding code to
1256         dwarf2_per_cu_addr_sized_int_type.
1257         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1258         (dwarf2_per_cu_addr_type): New function.
1259         (set_die_type): Update calls to attr_to_dynamic_prop.
1260
1261 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * dwarf2read.c (read_subrange_index_type): New function.
1264         (read_subrange_type): Move code into new function and call it.
1265         * gdbtypes.c (create_range_type): Add some asserts.
1266
1267 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1270         update return statements.
1271         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1272         declaration, and update comment to match.
1273         * gdbtypes.c (resolve_dynamic_array): Update call to
1274         dwarf2_evaluate_property to match new return type.
1275
1276 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1277
1278         * valarith.c (value_subscripted_rvalue): Change lowerbound
1279         parameter type from int to LONGEST.
1280         * value.h (value_subscripted_rvalue): Likewise in declaration.
1281
1282 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * cli/cli-utils.c (info_print_command_completer): New function.
1285         * cli/cli-utils.h: Add 'completer.h' include, and forward
1286         declaration for 'struct cmd_list_element'.
1287         (info_print_command_completer): Declare.
1288         * stack.c (_initialize_stack): Add completer for 'info locals' and
1289         'info args'.
1290         * symtab.c (_initialize_symtab): Add completer for 'info
1291         variables' and 'info functions'.
1292         * NEWS: Mention completion for additional info commands.
1293
1294 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * cli/cli-utils.c (extract_info_print_args): Delete.
1297         (extract_arg_maybe_quoted): Delete.
1298         (info_print_options_defs): New variable.
1299         (make_info_print_options_def_group): New function.
1300         (extract_info_print_options): Define new function.
1301         * cli/cli-utils.h (extract_info_print_args): Delete.
1302         (struct info_print_options): New structure.
1303         (extract_info_print_options): Declare new function.
1304         * stack.c (info_locals_command): Update to use new
1305         extract_info_print_options, also add a header comment.
1306         (info_args_command): Likewise.
1307         * symtab.c (info_variables_command): Likewise.
1308         (info_functions_command): Likewise.
1309
1310 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1313         to extract string arguments.
1314         * common/common-utils.c (extract_string_maybe_quoted): New function.
1315         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1316
1317 2019-07-11  Tom Tromey  <tromey@adacore.com>
1318
1319         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1320         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1321         * top.h (gdbinit): Don't declare.
1322         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1323         into...
1324         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1325         * top.c (gdb_init): Don't call init_cli_cmds.
1326         (gdbinit): Remove.
1327         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1328
1329 2019-07-11  Tom Tromey  <tromey@adacore.com>
1330
1331         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1332         after it has been moved.
1333
1334 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1335
1336         * valops.c (value_must_coerce_to_target): Change return type to
1337         bool.
1338         * value.h (value_must_coerce_to_target): Likewise.
1339
1340 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1341
1342         * breakpoint.c (is_hardware_watchpoint): Remove
1343         forward-declaration.
1344         (is_masked_watchpoint): Change return type to bool.
1345         (is_tracepoint): Likewise.
1346         (is_breakpoint): Likewise.
1347         (is_hardware_watchpoint): Likewise.
1348         (is_watchpoint): Likewise.
1349         (is_no_memory_software_watchpoint): Likewise.
1350         (is_catchpoint): Likewise.
1351         (breakpoint_1): Make FILTER parameter's return type bool.
1352         is_masked_watchpoint): Change return type to bool.
1353         (save_breakpoints): Make FILTER parameter's return type bool.
1354         * breakpoint.h (is_breakpoint): Change return type to bool.
1355         (is_watchpoint): Likewise.
1356         (is_catchpoint): Likewise.
1357         (is_tracepoint): Likewise.
1358
1359 2019-07-10  Tom Tromey  <tom@tromey.com>
1360
1361         * defs.h: Don't include gdbarch.h.
1362         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1363         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1364         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1365         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1366         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1367         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1368         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1369         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1370         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1371         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1372         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1373         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1374         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1375         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1376         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1377         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1378         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1379         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1380         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1381         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1382         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1383         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1384         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1385         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1386         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1387         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1388         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1389
1390 2019-07-10  Tom Tromey  <tromey@adacore.com>
1391
1392         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1393         * breakpoint.c (init_ada_exception_breakpoint): Register as
1394         bp_catchpoint.
1395         (print_one_breakpoint_location, print_one_breakpoint): Use
1396         is_ada_exception_catchpoint.
1397         * ada-lang.c (class ada_catchpoint_location): Pass
1398         bp_loc_software_breakpoint to bp_location constructor.
1399         (is_ada_exception_catchpoint): New function.
1400
1401 2019-07-10  Tom Tromey  <tromey@adacore.com>
1402
1403         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1404         VEC.
1405         (struct arm_exidx_entry): New method operator<.
1406         (struct arm_exidx_data) <section_maps>: Change type.
1407         (arm_exidx_data_free): Remove.
1408         (arm_exidx_data_key): Change type.  Move lower.
1409         (arm_exidx_new_objfile): Update.
1410         (arm_compare_exidx_entries): Remove.
1411         (arm_find_exidx_entry, _initialize_arm_tdep)
1412
1413 2019-07-10  Tom Tromey  <tromey@adacore.com>
1414
1415         * solib-spu.c (ocl_program_data_key): Change type.
1416         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1417         Update.
1418
1419 2019-07-10  Tom Tromey  <tromey@adacore.com>
1420
1421         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1422         (struct solib_aix_inferior_data) <library_list>: Change type.
1423         (solib_aix_inferior_data_handle): Change type.
1424         (get_solib_aix_inferior_data): Update.
1425         (solib_aix_free_library_list): Remove.
1426         (library_list_start_library): Update.
1427         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1428         return type.
1429         (solib_aix_get_library_list)
1430         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1431         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1432
1433 2019-07-10  Tom Tromey  <tromey@adacore.com>
1434
1435         * solib-dsbt.c (struct dsbt_info): Add initializers.
1436         (solib_dsbt_pspace_data): Change type.
1437         (dsbt_pspace_data_cleanup): Remove.
1438         (get_dsbt_info, _initialize_dsbt_solib): Update.
1439
1440 2019-07-10  Tom Tromey  <tromey@adacore.com>
1441
1442         * spu-tdep.c (spu_overlay_data): Change type.
1443         (spu_get_overlay_table, spu_overlay_new_objfile)
1444         (_initialize_spu_tdep): Update.
1445
1446 2019-07-10  Tom Tromey  <tromey@adacore.com>
1447
1448         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1449         destructor.
1450         (dbx_objfile_data_key): Change type and declare later.
1451         (DBX_SYMFILE_INFO): Rewrite.
1452         * dbxread.c (dbx_objfile_data_key): Change type.
1453         (dbx_symfile_init): Update.
1454         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1455         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1456         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1457
1458 2019-07-10  Tom Tromey  <tromey@adacore.com>
1459
1460         * jit.c (jit_program_space_key): Change type.  Move lower.
1461         (get_jit_program_space_data): Update.
1462         (jit_program_space_data_cleanup): Remove.
1463         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1464         Update.
1465         (struct jit_program_space_data): Add initializers.
1466
1467 2019-07-10  Tom Tromey  <tromey@adacore.com>
1468
1469         * solib-darwin.c (struct darwin_info): Add initializers.
1470         (solib_darwin_pspace_data): Change type.
1471         (darwin_pspace_data_cleanup): Remove.
1472         (get_darwin_info, _initialize_darwin_solib): Update.
1473
1474 2019-07-10  Tom Tromey  <tromey@adacore.com>
1475
1476         * remote-sim.c (struct sim_inferior_data): Add initializers,
1477         constructor, and destructor.
1478         (sim_inferior_data_key): Change type.  Move lower.
1479         (check_for_duplicate_sim_descriptor): Update.
1480         (get_sim_inferior_data): Use new.  Update.
1481         (~sim_inferior_data_cleanup): Rename from
1482         sim_inferior_data_cleanup.  Simplify.
1483         (gdbsim_close_inferior, simulator_command)
1484         (sim_command_completer, _initialize_remote_sim): Update.
1485         (next_pid, INITIAL_PID): Move earlier.
1486
1487 2019-07-10  Tom Tromey  <tromey@adacore.com>
1488
1489         * python/python-internal.h (create_thread_object): Return
1490         gdbpy_ref.
1491         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1492         * python/py-inferior.c (struct threadlist_entry): Add
1493         constructor.
1494         <thread_obj>: Now a gdbpy_ref.
1495         (thread_to_thread_object): Update.
1496         (add_thread_object): Use new.
1497         (delete_thread_object): Use delete.
1498         (infpy_threads): Update.
1499         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1500         GIL.
1501
1502 2019-07-10  Tom Tromey  <tromey@adacore.com>
1503
1504         * valops.c (value_cast): Specialize error message for Ada.
1505
1506 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1507
1508         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1509
1510 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1511
1512         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1513         bpstat_should_step): Return bool, adjust comments.
1514         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1515         bpstat_should_step): Likewise.
1516
1517 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1518
1519         * features/Makefile: Use feature target descriptions for Arm.
1520         * features/arm/arm-core.c: Generate new file.
1521         * features/arm/arm-fpa.c: Likewise.
1522         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1523         * features/arm/arm-m-profile.c: Likewise.
1524         * features/arm/arm-vfpv2.c: Likewise.
1525         * features/arm/arm-vfpv3.c: Likewise.
1526         * features/arm/xscale-iwmmxt.c: Likewise.
1527         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1528
1529 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1530
1531         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1532         ptrace earlier.
1533
1534 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1535
1536         * features/aarch64-pauth.c: Regenerate.
1537
1538 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1539
1540         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1541         bool.
1542         (bpstat_what): Use false instead of 0.
1543
1544 2019-07-09  Pedro Alves  <palves@redhat.com>
1545
1546         * break-catch-throw.c (is_exception_catchpoint): New.
1547         * breakpoint.c (print_one_breakpoint_location): New parameter
1548         'raw_loc'.  Handle it.  Use
1549         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1550         looking at the breakpoint's type.
1551         (print_one_breakpoint): If handling "maint info breakpoints", also
1552         print locations of exception catchpoints.
1553         * breakpoint.h (is_exception_catchpoint): Declare.
1554
1555 2019-07-09  Pedro Alves  <palves@redhat.com>
1556
1557         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1558         "addr" field.
1559         (allocate_location_exception_catchpoint): New.
1560         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1561         (initialize_throw_catchpoint_ops): Install
1562         allocate_location_exception_catchpoint as allocate_location
1563         method.
1564         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1565         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1566         bp_loc_other.
1567         (breakpoint_address_is_meaningful): Delete.
1568         (bl_address_is_meaningful): New.
1569         (breakpoint_locations_match): Adjust comment.
1570         (bp_location_from_bp_type): New, factored out of...
1571         (bp_location::bp_location(breakpoint *)): ... this.
1572         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1573         factored out of...
1574         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1575         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1576         breakpoint_address_is_meaningful.
1577         (bp_locations_compare): Adjust comment.
1578         (update_global_location_list): Use bl_address_is_meaningful
1579         instead of breakpoint_address_is_meaningful.
1580         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1581         explicit.
1582         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1583         * python/py-breakpoint.c (bppy_get_location): No longer check
1584         whether location is null.
1585
1586 2019-07-09  Pedro Alves  <palves@redhat.com>
1587
1588         PR c++/15468
1589         * breakpoint.c (print_one_breakpoint_location): Remove
1590         single-location assert.
1591
1592 2019-07-09  Tom Tromey  <tom@tromey.com>
1593
1594         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1595         * configure: Rebuild.
1596         * configure.ac: Change common to gdbsupport.
1597         * gdbsupport: Rename from common.
1598         * acinclude.m4: Change common to gdbsupport.
1599         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1600         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1601         gdbsupport.
1602         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1603         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1604         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1605         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1606         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1607         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1608         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1609         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1610         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1611         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1612         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1613         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1614         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1615         coff-pe-read.c, command.h, compile/compile-c-support.c,
1616         compile/compile-c.h, compile/compile-cplus-symbols.c,
1617         compile/compile-cplus-types.c, compile/compile-cplus.h,
1618         compile/compile-loc2c.c, compile/compile.c, completer.c,
1619         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1620         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1621         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1622         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1623         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1624         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1625         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1626         features/aarch64-core.c, features/aarch64-fpu.c,
1627         features/aarch64-pauth.c, features/aarch64-sve.c,
1628         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1629         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1630         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1631         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1632         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1633         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1634         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1635         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1636         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1637         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1638         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1639         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1640         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1641         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1642         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1643         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1644         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1645         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1646         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1647         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1648         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1649         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1650         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1651         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1652         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1653         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1654         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1655         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1656         minsyms.c, mips-linux-tdep.c, namespace.h,
1657         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1658         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1659         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1660         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1661         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1662         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1663         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1664         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1665         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1666         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1667         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1668         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1669         procfs.c, producer.c, progspace.h, psymtab.h,
1670         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1671         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1672         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1673         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1674         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1675         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1676         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1677         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1678         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1679         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1680         target-memory.c, target.c, target.h, target/waitstatus.c,
1681         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1682         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1683         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1684         unittests/array-view-selftests.c,
1685         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1686         unittests/common-utils-selftests.c,
1687         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1688         unittests/format_pieces-selftests.c,
1689         unittests/function-view-selftests.c,
1690         unittests/lookup_name_info-selftests.c,
1691         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1692         unittests/mkdir-recursive-selftests.c,
1693         unittests/observable-selftests.c,
1694         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1695         unittests/parse-connection-spec-selftests.c,
1696         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1697         unittests/scoped_fd-selftests.c,
1698         unittests/scoped_mmap-selftests.c,
1699         unittests/scoped_restore-selftests.c,
1700         unittests/string_view-selftests.c, unittests/style-selftests.c,
1701         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1702         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1703         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1704         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1705         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1706         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1707
1708 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1709
1710         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1711         bool value.
1712         (decode_digits_ordinary): Set explicit_line field in sal.
1713         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1714         symtab_and_line that was set on an explicit line number in
1715         assembler code.  Do always update the recorded symtab and line if
1716         we do skip the prologue.
1717
1718 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1719
1720         * breakpoint.c (set_breakpoint_location_function): Remove
1721         explicit_loc parameter.
1722         (momentary_breakpoint_from_master): Update call to
1723         set_breakpoint_location_function.
1724         (add_location_to_breakpoint): Likewise.
1725
1726 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1729         required features based on default bfd type when no specific bfd
1730         is present.
1731
1732 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1733
1734         * NEWS: Mention that GDB printf and eval commands can now print
1735         C-style and Ada-style convenience var strings without
1736         calling the inferior.
1737         * printcmd.c (printf_c_string): Locally print GDB internal var
1738         instead of transiting via the inferior.
1739         (printf_wide_c_string): Likewise.
1740
1741 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1742
1743         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1744
1745 2019-07-04  Tom Tromey  <tom@tromey.com>
1746
1747         PR tui/24724:
1748         * tui/tui-winsource.c (tui_clear_source_content): Update.
1749         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1750         (tui_update_breakpoint_info): Update.
1751         (tui_set_exec_info_content): Update.
1752         * tui/tui-source.c (tui_set_source_content_nil): Update.
1753         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1754         has_break.
1755         * tui/tui-data.h (enum tui_bp_flag): New.
1756         (tui_bp_flags): New enum flags type.
1757         (struct tui_source_element) <break_mode>: Change type.  Rename
1758         from has_break.
1759         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1760         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1761         constants.
1762         * tui/tui-winsource.h: Fix comment.
1763
1764 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1765
1766         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1767         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1768         (store_fpregs_to_thread)
1769         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1770         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1771         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1772         (IWMMXT_REGS_SIZE): Add define.
1773         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1774         (fetch_vfp_regs, store_vfp_regs)
1775         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1776         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1777
1778 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1779
1780         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1781         defines.
1782         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1783         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1784         (ARM_INT_REGISTER_SIZE): ...to this.
1785         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1786         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1787         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1788         (arm_linux_collect_gregset, supply_nwfpe_register)
1789         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1790         defines.
1791         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1792         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1793         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1794         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1795         (arm_return_in_memory, arm_store_return_value)
1796         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1797         (arm_record_ld_st_multiple): Likewise.
1798         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1799         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1800
1801 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1802
1803         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1804         AARCH64_DISPLACED_MODIFIED_INSNS.
1805         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1806         (aarch64_displaced_step_copy_insn): Likewise.
1807         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1808         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1809         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1810         ARM_DISPLACED_MODIFIED_INSNS.
1811         * arm-tdep.c (arm_gdbarch_init): Likewise.
1812         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1813         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1814         (struct arm_displaced_step_closure): Use
1815         ARM_DISPLACED_MODIFIED_INSNS.
1816
1817 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1818
1819         * features/Makefile: Remove unused xml files.
1820         * features/aarch64.xml: Remove.
1821         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1822         * features/i386/amd64-avx-avx512.xml: Remove.
1823         * features/i386/amd64-avx-linux.xml: Remove.
1824         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1825         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1826         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1827         * features/i386/amd64-avx-mpx.xml: Remove.
1828         * features/i386/amd64-avx.xml: Remove.
1829         * features/i386/amd64-linux.xml: Remove.
1830         * features/i386/amd64-mpx-linux.xml: Remove.
1831         * features/i386/amd64-mpx.xml: Remove.
1832         * features/i386/amd64.xml: Remove.
1833         * features/i386/i386-avx-avx512-linux.xml: Remove.
1834         * features/i386/i386-avx-avx512.xml: Remove.
1835         * features/i386/i386-avx-linux.xml: Remove.
1836         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1837         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1838         * features/i386/i386-avx-mpx-linux.xml: Remove.
1839         * features/i386/i386-avx-mpx.xml: Remove.
1840         * features/i386/i386-avx.xml: Remove.
1841         * features/i386/i386-linux.xml: Remove.
1842         * features/i386/i386-mmx-linux.xml: Remove.
1843         * features/i386/i386-mmx.xml: Remove.
1844         * features/i386/i386-mpx-linux.xml: Remove.
1845         * features/i386/i386-mpx.xml: Remove.
1846         * features/i386/i386.xml: Remove.
1847         * features/i386/x32-avx-avx512-linux.xml: Remove.
1848         * features/i386/x32-avx-linux.xml: Remove.
1849         * features/i386/x32-linux.xml: Remove.
1850
1851 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1852
1853         * regformats/aarch64.dat: Remove.
1854         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1855         * regformats/i386/amd64-avx-linux.dat: Remove.
1856         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1857         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1858         * regformats/i386/amd64-linux.dat: Remove.
1859         * regformats/i386/amd64-mpx-linux.dat: Remove.
1860         * regformats/i386/amd64.dat: Remove.
1861         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1862         * regformats/i386/i386-avx-linux.dat: Remove.
1863         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1864         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1865         * regformats/i386/i386-linux.dat: Remove.
1866         * regformats/i386/i386-mmx-linux.dat: Remove.
1867         * regformats/i386/i386-mpx-linux.dat: Remove.
1868         * regformats/i386/i386.dat: Remove.
1869         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1870         * regformats/i386/x32-avx-linux.dat: Remove.
1871         * regformats/i386/x32-linux.dat: Remove.
1872
1873 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1874
1875         * aarch64-tdep.c: Remove xml self tests.
1876         * amd64-linux-tdep.c: Likewise.
1877         * amd64-tdep.c: Likewise.
1878         * i386-linux-tdep.c: Likewise.
1879         * i386-tdep.c: Likewise.
1880
1881 2019-07-03  Pedro Alves  <palves@redhat.com>
1882
1883         PR cli/24732
1884         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1885         (pipe_cmd_option_defs): New.
1886         (make_pipe_cmd_options_def_group): New.
1887         (pipe_command): Use gdb::option::process_options.
1888         (pipe_command_completer): New function.
1889         (_initialize_cli_cmds): Install completer for "pipe" command.
1890
1891 2019-07-03  Pedro Alves  <palves@redhat.com>
1892
1893         * cli/cli-option.c (union option_value) <string>: New field.
1894         (struct option_def_and_value): Add ctor, move ctor, dtor and
1895         use DISABLE_COPY_AND_ASSIGN.
1896         (option_def_and_value::clear_value): New.
1897         (parse_option, save_option_value_in_ctx, get_val_type_str)
1898         (add_setshow_cmds_for_options): Handle var_string.
1899         * cli-option.h (union option_def::var_address) <string>: New
1900         field.
1901         (struct string_option_def): New.
1902         * maint-test-options.c (struct test_options_opts): Add default
1903         ctor and use DISABLE_COPY_AND_ASSIGN.
1904         <string_opt>: New field.
1905         (test_options_opts::~test_options_opts): New.
1906         (test_options_opts::dump): Also dump "-string".
1907         (test_options_option_defs): Install "string.
1908
1909 2019-07-03  Pedro Alves  <palves@redhat.com>
1910
1911         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1912         option_value with a null enumeration.
1913         (complete_options): Save the option values in the context.
1914         (save_option_value_in_ctx): New, factored out from ...
1915         (process_options): ... here.
1916         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1917         of the function.
1918         * maint-test-options.c (test_options_opts::dump): New, factored
1919         out from ...
1920         (maintenance_test_options_command_mode): ... here.
1921         (maintenance_test_options_command_completion_result): Delete.
1922         (maintenance_test_options_command_completion_text): Update
1923         comment.
1924         (maintenance_show_test_options_completion_result): Change
1925         prototype.  Just print
1926         maintenance_test_options_command_completion_text.
1927         (save_completion_result): New.
1928         (maintenance_test_options_completer_mode): Pass options context to
1929         complete_options, and then save a dump.
1930         (_initialize_maint_test_options): Use add_cmd to install "maint
1931         show test-options-completion-result".
1932
1933 2019-07-03  Pedro Alves  <palves@redhat.com>
1934
1935         * NEWS (New commands): Mention "with" and "maint with".
1936         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1937         (with_command, with_command_completer): New.
1938         (pipe_command): Adjust to new repeat_previous
1939         interface.
1940         (_initialize_cli_cmds): Install the "with" command and its "w"
1941         alias.
1942         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1943         declarations.
1944         * cli/cli-setshow.c (parse_cli_var_uinteger)
1945         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1946         argument strings for all var_types.
1947         (get_setshow_command_value_string): New, factored out from ...
1948         (do_show_command): ... this.
1949         * cli/cli-setshow.h: Include <string>.
1950         (get_setshow_command_value_string): Declare.
1951         * command.h (repeat_previous): Now returns const char *.  Adjust
1952         comment.
1953         * maint.c: Include "cli/cli-cmds.h".
1954         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1955         (_initialize_maint_cmds): Register the "maintenance with" command.
1956         * top.c (repeat_previous): Move bits from pipe_command here:
1957         Return the saved command line, if any; error out if there's no
1958         command to relaunch.
1959
1960 2019-07-03  Pedro Alves  <palves@redhat.com>
1961
1962         * NEWS (New commands): Mention "maint set/show test-settings"
1963         instead of "maint test-settings".
1964         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1965         (maintenance_test_settings_set_list): Rename to ...
1966         (maintenance_set_test_settings_list): ... this.
1967         (maintenance_test_settings_show_list): Rename to  ...
1968         (maintenance_show_test_settings_list): ... this.
1969         (maintenance_test_settings_cmd): Delete.
1970         (maintenance_test_settings_set_cmd): ...
1971         (maintenance_set_test_settings_cmd): ... this.
1972         (maintenance_test_settings_show_cmd): ...
1973         (maintenance_show_test_settings_cmd): ... this.
1974         (maintenance_test_settings_show_value_cmd):
1975         (maintenance_show_test_settings_value_cmd): ... this.
1976         (_initialize_maint_test_settings): No longer install the "maint
1977         test-settings" prefix command.  Rename "maint test-settings set"
1978         to "maint set test-settings", and "maint test-settings show" to
1979         "maint show test-settings".  Adjust all subcommands.
1980
1981 2019-07-03  Pedro Alves  <palves@redhat.com>
1982
1983         * maint-test-settings.c: Fix file's intro comment.  Replace all
1984         references to "test-options" with references to "test-settings",
1985         in comments.
1986
1987 2019-07-03  Pedro Alves  <palves@redhat.com>
1988
1989         * maint-test-settings.c (maintenance_test_settings_xxx)
1990         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1991         New.
1992         (maintenance_test_settings_enums): Use them.
1993         (maintenance_test_settings_enum): Default to
1994         maintenance_test_settings_xxx.
1995         (_initialize_maint_test_settings): Initialize
1996         MAINTENANCE_TEST_SETTINGS_FILENAME.
1997
1998 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1999
2000         * breakpoint.h (remove_breakpoints_inf): Change return type to
2001         void, move function documentation here.
2002         * breakpoint.c (remove_breakpoints_inf): Change return type to
2003         void, move function documentation to header.
2004
2005 2019-07-02  Pedro Alves  <palves@redhat.com>
2006
2007         * NEWS (Completion improvements): Mention "info threads".
2008         * thread.c (struct info_threads_opts, info_threads_option_defs)
2009         (make_info_threads_options_def_group): New.
2010         (info_threads_command): Use gdb::option::process_options.
2011         (info_threads_command_completer): New.
2012         (_initialize_thread): Use gdb::option::build_help to build the
2013         help text for "info threads".
2014
2015 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2016
2017         * defs.h (generic_load): Move from here...
2018         * symfile.h (generic_load): ... to here.  Rename name parameter
2019         to args.
2020         * symfile.c (generic_load): Add comment.
2021
2022 2019-07-01  Tom Tromey  <tromey@adacore.com>
2023
2024         * dwarf2read.c
2025         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2026         declaration of without_params.  Fix formatting.
2027
2028 2019-07-01  Tom Tromey  <tromey@adacore.com>
2029
2030         * ada-exp.y (find_primitive_type): Update.
2031         * ada-lang.h (ada_lookup_symbol): Update.
2032         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2033         parameter.
2034         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2035
2036 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2037
2038         PR breakpoints/24541
2039         * gdbarch.c: Regenerate.
2040         * gdbarch.h: Regenerate.
2041         * gdbarch.sh: Add 'stap_adjust_register'.
2042         * i386-tdep.c: Include '<unordered_set>'.
2043         (i386_stap_adjust_register): New function.
2044         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2045         * stap-probe.c (stap_parse_register_operand): Call
2046         'gdbarch_stap_adjust_register'.
2047
2048 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2049
2050         PR python/24742
2051         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2052         * python/python.c (do_start_initialization): Use 'xmalloc'
2053         instead of 'PyMem_Malloc'.
2054
2055 2019-06-28  Tom Tromey  <tromey@adacore.com>
2056
2057         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2058         for Ada.
2059
2060 2019-06-27  Tom Tromey  <tromey@adacore.com>
2061
2062         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2063         objfile_key.
2064         (arm_find_mapping_symbol, arm_record_special_symbol)
2065         (_initialize_arm_tdep): Update.
2066         (arm_objfile_data_free): Remove.
2067
2068 2019-06-27  Tom Tromey  <tromey@adacore.com>
2069
2070         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2071         to cp_print_static_field.
2072
2073 2019-06-26  Tom Tromey  <tromey@adacore.com>
2074
2075         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2076         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2077         declare.
2078
2079 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2080
2081         * features/aarch64-core.c (create_feature_aarch64_core):
2082         Regenerate.
2083         * features/aarch64-core.xml: Add cpsr flags.
2084
2085 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2086
2087         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2088         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2089
2090 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2091
2092         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2093         field.
2094         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2095         use.
2096         (arm_record_special_symbol): Don't insert new symbol in sorted
2097         position, push it at the end.
2098
2099 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2100
2101         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2102         (arm_mapping_symbol_s): Remove.
2103         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2104         (arm_mapping_symbol_vec): New typedef.
2105         (struct arm_per_objfile): Add constructor.
2106         <section_maps>: Change type to
2107         std::unique_ptr<arm_mapping_symbol_vec[]>.
2108         (arm_compare_mapping_symbols): Remove.
2109         (arm_find_mapping_symbol): Adjust to section_maps type change.
2110         (arm_objfile_data_free): Call delete on arm_per_objfile.
2111         (arm_record_special_symbol): Adjust to section_maps type change.
2112         Allocate arm_per_objfile with new.
2113
2114 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2115
2116         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2117         with the command prefix.
2118
2119 2019-06-25  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2122         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2123
2124 2019-06-25  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2127         type.
2128         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2129         protected.
2130
2131 2019-06-25  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-winsource.c
2134         (tui_source_window_base::set_is_exec_point_at): Add check against
2135         LOA_ADDRESS.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-source.c (tui_set_source_content): Don't check before
2140         xfree.
2141         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2142
2143 2019-06-25  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-winsource.h (tui_update_source_window_as_is)
2146         (tui_alloc_source_buffer, tui_line_is_displayed)
2147         (tui_addr_is_displayed): Change type of win_info.
2148         * tui/tui-winsource.c (tui_update_source_window_as_is)
2149         (tui_clear_source_content, tui_show_source_line)
2150         (tui_show_source_content, tui_source_window_base::refill)
2151         (tui_source_window_base::set_is_exec_point_at)
2152         (tui_source_window_base::set_is_exec_point_at)
2153         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2154         (tui_alloc_source_buffer, tui_line_is_displayed)
2155         (tui_addr_is_displayed): Change type of win_info.  Update.
2156         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2157         (tui_source_window_base::do_make_visible_with_new_height):
2158         Update.
2159         * tui/tui-source.c (tui_set_source_content)
2160         (tui_set_source_content_nil)
2161         (tui_source_window::do_scroll_vertical): Update.
2162         * tui/tui-layout.c (show_layout): Update.
2163         * tui/tui-disasm.c (tui_set_disassem_content)
2164         (tui_disasm_window::do_scroll_vertical): Update.
2165         * tui/tui-data.h (tui_win_content): Remove.
2166         (struct tui_gen_win_info) <content, content_size>: Remove.
2167         (struct tui_source_element): Add initializers and destructor.
2168         (union tui_which_element, struct tui_win_element): Remove.
2169         (struct tui_source_window_base) <content>: New field.
2170         (struct tui_data_window): Remove destructor.
2171         (tui_alloc_content, tui_free_win_content)
2172         (tui_free_all_source_wins_content): Don't declare.
2173         * tui/tui-data.c (tui_initialize_static_data): Update.
2174         (init_content_element, tui_alloc_content): Remove.
2175         (~tui_gen_win_info): Update.
2176         (~tui_data_window, tui_free_all_source_wins_content)
2177         (tui_free_win_content, free_content, free_content_elements):
2178         Remove.
2179
2180 2019-06-25  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-winsource.h (tui_clear_source_content)
2183         (tui_erase_source_content, tui_show_source_content): Change type
2184         of win_info.
2185         * tui/tui-winsource.c (tui_clear_source_content)
2186         (tui_erase_source_content, tui_show_source_content): Change type
2187         of win_info.
2188         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2189         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2190         win_info.
2191         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2192         win_info.
2193         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2194
2195 2019-06-25  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-winsource.c (tui_clear_source_content)
2198         (tui_source_window_base::set_is_exec_point_at): Update.
2199         * tui/tui-source.c (tui_set_source_content_nil): Update.
2200         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2201         a bool.
2202         * tui/tui-data.c (init_content_element): Update.
2203
2204 2019-06-25  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2207         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2208         * tui/tui-layout.c (init_and_make_win): Update.
2209         * tui/tui.h (enum tui_win_type): Update.
2210         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2211         tui_win_is_auxillary.
2212         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2213         tui_win_is_auxillary.
2214
2215 2019-06-25  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2218         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2219         (tui_delete_data_content_windows, tui_display_all_data)
2220         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2221         Update.
2222         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2223         * tui/tui-regs.c (tui_last_regs_line_no)
2224         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2225         (tui_show_registers): Update.
2226         (tui_show_register_group): Return void.  Update.
2227         (tui_display_registers_from, tui_display_reg_element_at_line)
2228         (tui_display_registers_from_line, tui_check_register_values):
2229         Update.
2230         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2231         member.
2232         (struct tui_data_window) <regs_content>: Now a std::vector.
2233         <regs_content_count>: Remove.
2234         (tui_add_content_elements, tui_free_data_content): Don't declare.
2235         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2236         (init_content_element): Remove DATA_WIN case.  Add assert.
2237         (tui_add_content_elements): Remove.
2238         (tui_data_window): Update.
2239         (tui_free_data_content): Remove.
2240         (free_content_elements): Remove DATA_WIN case.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-data.c (tui_data_item_window): Update.
2245         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2246         * tui/tui-windata.c (tui_display_all_data)
2247         (tui_display_data_from_line): Update.
2248         (tui_check_data_values): Remove.
2249         * tui/tui-regs.c (tui_show_register_group)
2250         (tui_display_reg_element_at_line): Update.
2251         * tui/tui-hooks.c (tui_register_changed)
2252         (tui_refresh_frame_and_register_information): Call
2253         tui_check_register_values.
2254         * tui/tui-data.h (struct tui_data_window) <data_content,
2255         data_content_count, data_type>: Remove.
2256         (enum tui_data_type): Remove.
2257
2258         * tui/tui-data.c (tui_data_window::clear_detail)
2259         (~tui_data_window): Update.
2260
2261 2019-06-25  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2264         declare.
2265         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2266         Rename from tui_first_data_item_displayed.  Update.
2267         (tui_data_window::refresh_all)
2268         (tui_data_window::do_scroll_vertical): Update.
2269         * tui/tui-data.h (struct tui_data_window)
2270         <first_data_item_displayed>: Declare new method.
2271
2272 2019-06-25  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2275         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2276         contents...
2277         (tui_initialize_static_data): ...here.
2278
2279 2019-06-25  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2282         (tui_display_registers_from, tui_check_register_values): Update.
2283         (tui_display_register): Remove win_info parameter; update.
2284         (tui_get_register): Change type of parameters.
2285         * tui/tui-data.h (struct tui_data_element): Remove.
2286         (union tui_which_element) <data>: Remove.
2287         <data_window>: Change type.
2288         (struct tui_data_item_window): New.
2289         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2290         case.  Add assert.
2291         (~tui_data_item_window): New destructor.
2292         (free_content_elements): Remove DATA_ITEM_WIN case.
2293
2294 2019-06-25  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2297         Remove.
2298
2299 2019-06-25  Tom Tromey  <tom@tromey.com>
2300
2301         * tui/tui-data.h (struct tui_command_element): Remove.
2302         (union tui_which_element) <command>: Remove.
2303         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2304         assert.
2305         (free_content_elements): Remove CMD_WIN case.
2306
2307 2019-06-25  Tom Tromey  <tom@tromey.com>
2308
2309         * tui/tui-layout.c (tui_set_layout): Update.
2310         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2311         * tui/tui-data.c (layout_def): Update.
2312
2313 2019-06-25  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2316         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2317         (tui_source_window_base::set_new_height): Update.
2318         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2319         Update.
2320         (tui_set_locator_fullname, tui_set_locator_info)
2321         (tui_show_frame_info): Update.
2322         * tui/tui-source.c (tui_set_source_content)
2323         (tui_source_is_displayed): Update.
2324         * tui/tui-layout.c (show_source_disasm_command, show_data)
2325         (show_source_or_disasm_and_command): Update.
2326         * tui/tui-disasm.c (tui_set_disassem_content)
2327         (tui_get_begin_asm_address): Update.
2328         * tui/tui-data.h (struct tui_locator_element): Remove.
2329         (union tui_which_element) <locator>: Remove.
2330         (struct tui_locator_window): New.
2331         (tui_locator_win_info_ptr): Change return type.
2332         * tui/tui-data.c (_locator): Change type.
2333         (tui_locator_win_info_ptr): Change return type.
2334         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2335         (tui_alloc_content): Add assert.
2336
2337 2019-06-25  Tom Tromey  <tom@tromey.com>
2338
2339         * tui/tui-winsource.c
2340         (tui_exec_info_window::maybe_allocate_content): New method.
2341         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2342         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2343         (make_source_or_disasm_window): Add cast.
2344         * tui/tui-data.h (union tui_which_element) <simple_string>:
2345         Remove.
2346         (struct tui_source_info): New.
2347         (struct tui_source_window_base) <execution_info>: Change type.
2348         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2349         case, and add assert.
2350         (tui_alloc_content): Add assert.
2351
2352 2019-06-25  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2355         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2356         * tui/tui-data.c (tui_alloc_win_info): Remove.
2357
2358 2019-06-25  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2361         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2362         can_highlight.
2363
2364 2019-06-25  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2367         make_visible_with_new_height method.
2368         (tui_win_info::make_visible_with_new_height): New method.
2369         (tui_source_window_base::do_make_visible_with_new_height)
2370         (tui_data_window::do_make_visible_with_new_height)
2371         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2372         (make_visible_with_new_height): Remove.
2373         (tui_resize_all, tui_adjust_win_heights): Use
2374         make_visible_with_new_height method.
2375         * tui/tui-data.h (struct tui_win_info)
2376         <do_make_visible_with_new_height, make_visible_with_new_height>:
2377         New methods.
2378         (struct tui_source_window_base, struct tui_data_window)
2379         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2380         methods.
2381
2382 2019-06-25  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2385         method.
2386         (update_tab_width): Call update_tab_width method.
2387         * tui/tui-data.h (struct tui_win_info)
2388         (struct tui_source_window_base) <update_tab_width>: New methods.
2389
2390 2019-06-25  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2393         parameter.
2394         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2395         parameter.
2396         (tui_gen_win_info::make_visible): Update.
2397         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2398         parameter.
2399         * tui/tui-data.h (enum tui_box): New enum.
2400         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2401
2402 2019-06-25  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2405         init_and_make_win for EXEC_INFO_WIN.
2406         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2407         longer inline.
2408         (struct tui_win_info) <~tui_win_info>: Inline.
2409         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2410         Don't declare.
2411         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2412         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2413         Remove.
2414         (tui_initialize_static_data): Update.
2415         (~tui_gen_win_info): Handle more cleanup here.
2416         (~tui_source_window_base): Delete "execution_info".
2417         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-layout.c (make_command_window): Don't set
2422         can_highlight.
2423         (show_source_disasm_command): Call the reset method.
2424         (show_data): Don't set can_highlight.  Call the reset method.
2425         (tui_gen_win_info::reset): Rename from init_gen_win_info
2426         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2427         (show_source_or_disasm_and_command): Call the reset method.
2428         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2429         (struct tui_cmd_window): Set can_highlight.
2430
2431 2019-06-25  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2434         from make_visible.
2435         (tui_make_visible, tui_make_invisible): Rewrite.
2436         (tui_win_info::make_visible): Remove.
2437         (tui_source_window_base::make_visible): Update.
2438         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2439         method.  Moved from...
2440         (struct tui_win_info) <make_visible>: ...here.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-winsource.c
2445         (tui_source_window_base::do_scroll_horizontal): Remove direction
2446         parameter.
2447         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2448         direction parameter.
2449         * tui/tui-win.c (tui_win_info::forward_scroll)
2450         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2451         (tui_win_info::right_scroll): Update.
2452         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2453         direction parameter.
2454         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2455         direction parameter.
2456         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2457         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2458         Remove direction parameter.
2459         (struct tui_source_window_base, struct tui_source_window)
2460         (struct tui_disasm_window, struct tui_data_window)
2461         (struct tui_cmd_window): Update.
2462
2463 2019-06-25  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-winsource.h (tui_set_exec_info_content)
2466         (tui_show_exec_info_content, tui_erase_exec_info_content)
2467         (tui_clear_exec_info_content, tui_update_exec_info): Change
2468         argument to tui_source_window_base.
2469         * tui/tui-winsource.c (tui_set_exec_info_content)
2470         (tui_show_exec_info_content, tui_erase_exec_info_content)
2471         (tui_clear_exec_info_content, tui_update_exec_info): Change
2472         argument to tui_source_window_base.
2473
2474 2019-06-25  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2477         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2478
2479 2019-06-25  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2482         check.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2487         type to void.
2488         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2489         type to void.
2490         * tui/tui-source.c (tui_set_source_content): Update.
2491         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2492
2493 2019-06-25  Tom Tromey  <tom@tromey.com>
2494
2495         * tui/tui-win.c (window_name_completer, tui_set_focus)
2496         (tui_all_windows_info): Use name method.
2497         * tui/tui-data.h (struct tui_gen_win_info)
2498         (struct tui_source_window, struct tui_disasm_window)
2499         (struct tui_data_window, struct tui_cmd_window) <name>: New
2500         method.
2501         (tui_win_name): Don't declare.
2502         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2503         (tui_win_name): Remove.
2504
2505 2019-06-25  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-winsource.h (tui_update_source_window)
2508         (tui_update_source_window_as_is): Change parameter type.
2509         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2510         to be a tui_source_window_base.
2511         (tui_update_source_window_as_is): Likewise.
2512         * tui/tui-win.c (make_visible_with_new_height): Update.
2513
2514 2019-06-25  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-winsource.c (tui_erase_source_content)
2517         (tui_show_source_content, tui_show_exec_info_content)
2518         (tui_erase_exec_info_content): Use refresh_window method.
2519         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2520         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2521         from tui_refresh_win.
2522         (tui_data_window::refresh_window): New method.
2523         (tui_win_info::refresh, tui_source_window_base::refresh)
2524         (tui_refresh_all): Use refresh_window method.
2525         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2526         method.
2527         * tui/tui-regs.c (tui_display_register): Call refresh_window
2528         method.
2529         * tui/tui-layout.c (show_source_disasm_command)
2530         (show_source_or_disasm_and_command): Call refresh_window method.
2531         * tui/tui-data.h (struct tui_gen_win_info)
2532         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2533         New method.
2534
2535 2019-06-25  Tom Tromey  <tom@tromey.com>
2536
2537         * tui/tui.c (tui_rl_other_window, tui_enable)
2538         (tui_is_window_visible, tui_get_command_dimension): Update.
2539         * tui/tui-winsource.c (tui_update_source_window_as_is)
2540         (tui_clear_source_content, tui_erase_source_content)
2541         (tui_show_source_line, tui_source_window_base::refill)
2542         (tui_source_window_base::do_scroll_horizontal)
2543         (tui_source_window_base::set_is_exec_point_at)
2544         (tui_update_breakpoint_info, tui_set_exec_info_content)
2545         (tui_alloc_source_buffer, tui_line_is_displayed)
2546         (tui_addr_is_displayed): Update.
2547         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2548         (tui_check_and_display_highlight_if_needed)
2549         (tui_win_info::make_visible, tui_win_info::refresh)
2550         (tui_refresh_all): Update.
2551         * tui/tui-windata.c (tui_first_data_item_displayed)
2552         (tui_delete_data_content_windows, tui_erase_data_content)
2553         (tui_display_all_data, tui_data_window::refresh_all)
2554         (tui_check_data_values): Update.
2555         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2556         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2557         (tui_win_info::backward_scroll, tui_refresh_all_win)
2558         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2559         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2560         (tui_source_window_base::set_new_height)
2561         (tui_data_window::set_new_height)
2562         (make_invisible_and_set_new_height)
2563         (make_visible_with_new_height, new_height_ok)
2564         (parse_scrolling_args): Update.
2565         * tui/tui-stack.c (tui_show_frame_info): Update.
2566         * tui/tui-source.c (tui_set_source_content)
2567         (tui_set_source_content_nil, tui_source_is_displayed)
2568         (tui_source_window::do_scroll_vertical): Update.
2569         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2570         (tui_display_registers_from, tui_display_reg_element_at_line)
2571         (tui_check_register_values, tui_reg_command): Update.
2572         * tui/tui-layout.c (tui_default_win_height)
2573         (show_source_disasm_command, show_data, init_and_make_win)
2574         (show_source_or_disasm_and_command): Update.
2575         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2576         (tui_redisplay_readline, tui_mld_flush)
2577         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2578         (tui_getc): Update.
2579         * tui/tui-disasm.c (tui_set_disassem_content)
2580         (tui_disasm_window::do_scroll_vertical): Update.
2581         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2582         Now virtual.
2583         (struct tui_win_info): Derive from tui_gen_win_info.
2584         <~tui_win_info>: Mark as override.
2585         <generic>: Remove member.
2586         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2587         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2588         (~tui_data_window, ~tui_win_info)
2589         (tui_free_all_source_wins_content): Update.
2590         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2591
2592 2019-06-25  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-layout.c (init_and_make_win): Use new.
2595         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2596         destructor, initializers.
2597         (tui_alloc_generic_win_info): Don't declare.
2598         * tui/tui-data.c (_locator): Add argument to constructor.
2599         (source_win, disasm_win): New globals.
2600         (exec_info): Remove.
2601         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2602         Update.
2603         (tui_alloc_generic_win_info): Remove.
2604         (init_content_element): Use new.
2605         (tui_win_info::tui_win_info): Update.
2606         (free_content_elements) <case DATA_WIN>: Use delete.
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2611         * tui/tui-windata.c (tui_first_data_item_displayed)
2612         (tui_delete_data_content_windows): Update.
2613         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2614         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2615         (tui_display_registers_from, tui_check_register_values): Update.
2616         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2617         pointer.
2618         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2619         window.
2620         (tui_free_data_content): Update.
2621         (free_content_elements) <case DATA_WIN>: Free the window.
2622
2623 2019-06-25  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2626         Update.
2627         * tui/tui-layout.c (make_command_window)
2628         (show_source_disasm_command, show_data, init_and_make_win)
2629         (show_source_or_disasm_and_command): Update.
2630         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2631         method.
2632         <can_highight, is_highlighted>: Now bool.
2633         (tui_set_win_highlight): Don't declare.
2634         * tui/tui-data.c (tui_set_win_highlight): Remove.
2635
2636 2019-06-25  Tom Tromey  <tom@tromey.com>
2637
2638         * tui/tui-wingeneral.c (make_visible): Remove check of window
2639         type.
2640
2641 2019-06-25  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-win.c (tui_win_info::max_height)
2644         (tui_cmd_window::max_height): New methods.
2645         (new_height_ok): Call max_height.
2646         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2647         <max_height>: New method.
2648
2649 2019-06-25  Tom Tromey  <tom@tromey.com>
2650
2651         * tui/tui-win.c (tui_source_window_base::set_new_height)
2652         (tui_data_window::set_new_height): New methods.
2653         (make_invisible_and_set_new_height): Call set_new_height method.
2654         * tui/tui-data.h (struct tui_win_info)
2655         (struct tui_source_window_base, struct tui_data_window)
2656         <set_new_height>: New method.
2657
2658 2019-06-25  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2661         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2662         tui_refresh_data_win.
2663         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2664         method.
2665         (tui_refresh_all_win): Call the refresh_all method.
2666         (tui_set_focus): Likewise.
2667         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2668         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2669         Likewise.
2670
2671 2019-06-25  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-winsource.h (tui_refill_source_window)
2674         (tui_set_is_exec_point_at): Don't declare.
2675         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2676         (tui_source_window_base::refill): Rename from
2677         tui_refill_source_window.
2678         (tui_source_window_base::do_scroll_horizontal): Update.
2679         (tui_source_window_base::set_is_exec_point_at): Rename from
2680         tui_set_is_exec_point_at.
2681         (tui_update_all_breakpoint_info): Update.
2682         * tui/tui-stack.c (tui_show_frame_info): Update.
2683         * tui/tui-layout.c (show_data): Add cast.
2684         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2685         * tui/tui-data.h (struct tui_source_window_base) <refill,
2686         set_is_exec_point_at>: New methods.
2687         (tui_source_windows, tui_add_to_source_windows): Update types.
2688         (tui_add_to_source_windows): Remove redundant declaration.
2689         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2690         (tui_source_windows): Change return type.
2691         (tui_clear_source_windows_detail): Update.
2692         (tui_add_to_source_windows): Change type of parameter.
2693         (tui_free_all_source_wins_content): Update.
2694
2695 2019-06-25  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-wingeneral.c (tui_win_info::refresh)
2698         (tui_source_window_base::refresh): New methods.
2699         (tui_refresh_all): Call the refresh method.
2700         * tui/tui-data.h (struct tui_win_info)
2701         (struct tui_source_window_base) <refresh>: New method.
2702
2703 2019-06-25  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui.h (tui_is_window_visible): Return bool.
2706         * tui/tui.c (tui_is_window_visible): Return bool.
2707         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2708         (tui_make_visible, tui_make_invisible)
2709         (tui_win_info::make_visible)
2710         (tui_source_window_base::make_visible, make_all_visible)
2711         (tui_make_all_visible, tui_make_all_invisible): Update.
2712         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2713         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2714         bool.
2715         (struct tui_win_info, struct tui_source_window_base)
2716         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2717         * tui/tui-data.c (tui_init_generic_part): Update.
2718
2719 2019-06-25  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2722         (tui_source_window_base::make_visible): New methods.
2723         (make_all_visible): Make method call.
2724         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2725         (struct tui_source_window_base, struct tui_cmd_window): Override
2726         make_visible.
2727         (tui_win_is_source_type): Don't declare.
2728         * tui/tui-data.c (tui_win_is_source_type): Remove.
2729
2730 2019-06-25  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2733         NULL check.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2738         Inline constructor.  Add initializers for members.
2739         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2740         constructors; now inline in class.
2741
2742 2019-06-25  Tom Tromey  <tom@tromey.com>
2743
2744         * tui/tui-regs.c (tui_show_registers): Update.
2745         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2746         bool.
2747         * tui/tui-data.c (tui_data_window::clear_detail)
2748         (tui_data_window): Update.
2749
2750 2019-06-25  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-windata.c (tui_display_all_data)
2753         (tui_display_data_from_line, tui_display_data_from)
2754         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2755         Update.
2756         * tui/tui-regs.c (tui_last_regs_line_no)
2757         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2758         (tui_show_registers, tui_show_register_group)
2759         (tui_display_registers_from, tui_display_reg_element_at_line)
2760         (tui_display_registers_from_line, tui_check_register_values)
2761         (tui_reg_next, tui_reg_prev): Update.
2762         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2763         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2764         tui_data_window.
2765         (struct tui_win_info) <detail>: Remove.  Add new fields from
2766         tui_data_info.
2767         (TUI_DATA_WIN): Add cast.
2768         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2769         (~tui_data_window): Simplify.
2770
2771 2019-06-25  Tom Tromey  <tom@tromey.com>
2772
2773         * tui/tui-layout.c (show_source_disasm_command)
2774         (show_source_or_disasm_and_command): Update.
2775         * tui/tui-io.c (update_cmdwin_start_line)
2776         (tui_redisplay_readline): Update.
2777         * tui/tui-data.h (struct tui_command_info): Remove.
2778         (struct tui_win_info) <detail>: Remove command_info member.
2779         (struct tui_data_window) <start_line>: New member, from
2780         tui_command_info.
2781         (TUI_CMD_WIN): Add casts.
2782
2783 2019-06-25  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-winsource.c (tui_update_source_window)
2786         (tui_refill_source_window)
2787         (tui_source_window_base::do_scroll_horizontal)
2788         (tui_update_breakpoint_info, tui_set_exec_info_content)
2789         (tui_show_exec_info_content, tui_erase_exec_info_content)
2790         (tui_clear_exec_info_content): Update.
2791         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2792         Update.
2793         * tui/tui-win.c (make_invisible_and_set_new_height)
2794         (make_visible_with_new_height): Update.
2795         * tui/tui-source.c (tui_set_source_content)
2796         (tui_show_symtab_source): Update.
2797         * tui/tui-layout.c (extract_display_start_addr)
2798         (show_source_disasm_command, show_data)
2799         (make_source_or_disasm_window)
2800         (show_source_or_disasm_and_command): Update.
2801         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2802         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2803         "gdbarch".
2804         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2805         to tui_source_window_base.
2806         (struct tui_win_info) <detail>: Remove source_info member.
2807         (struct tui_source_window_base) <has_locator>: Inline.
2808         Move contents from tui_source_info; rename has_locator member to
2809         m_has_locator.
2810         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2811         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2812         header file.
2813         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2814         Simplify.
2815         (tui_free_all_source_wins_content): Cast to
2816         tui_source_window_base.
2817
2818 2019-06-25  Tom Tromey  <tom@tromey.com>
2819
2820         * tui/tui-win.c (make_invisible_and_set_new_height)
2821         (make_visible_with_new_height): Call has_locator method.
2822         * tui/tui-layout.c (show_source_disasm_command, show_data)
2823         (show_source_or_disasm_and_command): Update for bool change.
2824         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2825         (tui_win_info) <has_locator>: New method.
2826         (struct tui_source_window_base) <has_locator>: New method.
2827         (tui_win_has_locator): Don't declare.
2828         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2829         from tui_win_has_locator.
2830         (tui_source_window_base): Use false, not FALSE.
2831
2832 2019-06-25  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2835         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2836         clear_detail method directly.
2837         (tui_clear_win_detail): Remove.
2838
2839 2019-06-25  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2842         "this", not TUI_DISASM_WIN.
2843
2844 2019-06-25  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2847         declare.
2848         * tui/tui-winsource.c
2849         (tui_source_window_base::do_scroll_horizontal): Rename from
2850         tui_horizontal_source_scroll.
2851         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2852         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2853         from tui_vertical_data_scroll.
2854         * tui/tui-win.h (tui_scroll): Don't declare.
2855         * tui/tui-win.c (tui_win_info::forward_scroll)
2856         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2857         (tui_win_info::right_scroll): Rename and update.
2858         (tui_scroll_forward_command, tui_scroll_backward_command)
2859         (tui_scroll_left_command, tui_scroll_right_command): Update.
2860         (tui_scroll): Remove.
2861         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2862         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2863         from tui_vertical_source_scroll.
2864         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2865         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2866         from tui_vertical_disassem_scroll.
2867         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2868         do_scroll_horizontal>: New methods.
2869         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2870         Likewise.
2871         (struct tui_source_window_base): Add do_scroll_horizontal.
2872         (struct tui_source_window, struct tui_disasm_window): Add
2873         do_scroll_vertical.
2874         (struct tui_data_window, struct tui_cmd_window): Add
2875         do_scroll_horizontal and do_scroll_vertical.
2876         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2877
2878 2019-06-25  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-data.h (struct tui_source_window_base): New struct.
2881         (struct tui_source_window): Derive from tui_source_window_base.
2882         (struct tui_disasm_window): New struct.
2883         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2884         from tui_source_window::clear_detail.
2885         (tui_source_window_base): Rename from tui_source_window.
2886         (~tui_source_window_base): Rename from ~tui_source_window.
2887         (tui_alloc_win_info): Create a tui_disasm_window.
2888
2889 2019-06-25  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui-data.h (struct tui_source_window)
2892         (struct tui_data_window): Declare destructors.
2893         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2894         destructors.
2895         (tui_win_info): Simplify.
2896
2897 2019-06-25  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-winsource.c (tui_display_main)
2900         (tui_update_source_windows_with_addr)
2901         (tui_update_all_breakpoint_info): Update.
2902         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2903         (new_height_ok, parse_scrolling_args): Update.
2904         * tui/tui-stack.c (tui_show_frame_info): Update.
2905         * tui/tui-data.h (struct tui_list): Remove.
2906         (tui_source_windows): Return a reference to a std::vector.
2907         * tui/tui-data.c (source_windows): Now a std::vector.
2908         (tui_source_windows): Change return type.
2909         (tui_clear_source_windows): Rewrite.
2910         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2911         (tui_free_all_source_wins_content): Rewrite.
2912
2913 2019-06-25  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2916         (struct tui_data_window, struct tui_cmd_window): Declare
2917         clear_detail method.
2918         * tui/tui-data.c (tui_source_window::clear_detail)
2919         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2920         methods.
2921         (tui_clear_win_detail): Simplify.
2922
2923 2019-06-25  Tom Tromey  <tom@tromey.com>
2924
2925         * tui/tui-layout.c (make_source_window, make_disasm_window)
2926         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2927         Return the new window.
2928         (show_source_disasm_command, show_data)
2929         (show_source_or_disasm_and_command): Update.
2930
2931 2019-06-25  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2934         parameter.  Return the new window.
2935         (show_source_disasm_command): Update and remove NULL check.
2936         (show_source_or_disasm_and_command): Update.
2937
2938 2019-06-25  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-data.h (struct tui_win_info): Make constructor
2945         protected.  Make destructor virtual.  Add initializers.
2946         (tui_source_window, tui_data_window, tui_cmd_window): New
2947         classes.
2948         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2949         constructor.  Add "type" parameter.
2950         (tui_source_window, tui_data_window, tui_cmd_window): New
2951         constructors.
2952         (tui_alloc_win_info): Instantiate the appropriate subclass.
2953
2954 2019-06-25  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-win.c (tui_resize_all): Use delete.
2957         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2958         destructor.
2959         (tui_free_window): Don't declare.
2960         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2961         Update.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-data.h (struct tui_win_info): Add constructor.
2966         * tui/tui-data.c (tui_alloc_win_info): Use new.
2967         (tui_free_window): Use delete.
2968
2969 2019-06-22  Tom Tromey  <tom@tromey.com>
2970
2971         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2972         declare.
2973         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2974
2975 2019-06-22  Tom Tromey  <tom@tromey.com>
2976
2977         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2978         declare.
2979         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2980
2981 2019-06-22  Tom de Vries  <tdevries@suse.de>
2982
2983         * dwarf2read.c (create_addrmap_from_aranges)
2984         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2985         instead of '%zu'.
2986
2987 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2988
2989         * dwarf2read.h (dwarf2_section_info_def): Remove.
2990         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2991         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2992         std::vector<dwarf2_section_info>.
2993         (struct dwo_file) <~dwo_file>: Remove.
2994         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2995         types field.
2996         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2997         (dwarf2_read_debug_names): Likewise.
2998         (create_debug_types_hash_table): Change parameter type to
2999         array_view, adjust code accordingly.
3000         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3001         (partial_die_info::fixup): Likewise.
3002         (determine_prefix): Likewise.
3003         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3004
3005 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3006
3007         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3008         gdb_bfd_ref_ptr.
3009         <~dwo_file>: Remove call to gdb_bfd_unref.
3010         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3011         gdb_bfd_ref_ptr::get.
3012
3013 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3014
3015         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3016         type to htab_up.
3017         * dwarf2read.c (struct dwo_file): Initialize fields.
3018         <~dwo_file>: New.
3019         (free_dwo_file): Remove, move content to ~dwo_file.
3020         (struct dwo_file_deleter): Remove.
3021         (dwo_file_up>: Remove custom deleter.
3022         (free_dwo_files): Remove.
3023         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3024         dwo_files.
3025         (process_skeletonless_type_units): Call unique_ptr::get.
3026         (allocate_dwo_file_hash_table): Add deleter to created hash
3027         table.  Change return type to htab_up.
3028         (lookup_dwo_file_slot): Don't memset dwo_file, call
3029         unique_ptr::get.
3030         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3031         (create_dwo_unit_in_dwp_v2): Likewise.
3032         (open_and_init_dwo_file): Likewise.
3033         (free_dwo_file_from_slot): Remove.
3034
3035 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3036
3037         * dwarf2read.h (struct dwarf2_section_info) <readin,
3038         is_virtual>: Change type to bool.
3039         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3040         true instead of 1.
3041
3042 2019-06-19  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-data.h (tui_init_content_element): Don't declare.
3045
3046 2019-06-19  Tom Tromey  <tom@tromey.com>
3047
3048         * tui/tui-data.h (tui_init_win_info): Don't declare.
3049
3050 2019-06-19  Tom de Vries  <tdevries@suse.de>
3051
3052         * dwarf2read.h (abstract_to_concrete): Change type to
3053         std::unordered_map<sect_offset, std::vector<sect_offset>,
3054         gdb::hash_enum<sect_offset>>.
3055
3056 2019-06-19  Tom Tromey  <tromey@adacore.com>
3057
3058         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3059         EVAL_AVOID_SIDE_EFFECTS specially.
3060
3061 2019-06-19  Tom Tromey  <tromey@adacore.com>
3062
3063         * source-cache.c (highlighter): New global.
3064         (source_cache::get_source_lines): Create a highlighter on demand.
3065
3066 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3067
3068         * defs.h (deprecated_interactive_hook): Delete declaration.
3069         * interps.c (clear_interpreter_hooks): Remove use of
3070         deprecated_interactive_hook.
3071         * top.c (deprecated_interactive_hook): Delete definition.
3072         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3073
3074 2019-06-18  Tom de Vries  <tdevries@suse.de>
3075
3076         PR gdb/24515
3077         * dwarf2read.h (abstract_to_concrete): Change type from
3078         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3079         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3080         * dwarf2read.c (read_variable): Update.
3081         (dwarf2_fetch_die_loc_sect_off): Update.
3082
3083 2019-06-17  Tom de Vries  <tdevries@suse.de>
3084
3085         PR gdb/24617
3086         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3087         accessing parent[parent_len - 1].
3088
3089 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3090
3091         PR gdb/24364
3092         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3093         call dtrace_process_dof with NULL dof.
3094
3095 2019-06-16  Tom de Vries  <tdevries@suse.de>
3096
3097         PR gdb/24445
3098         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3099
3100 2019-06-16  Tom Tromey  <tom@tromey.com>
3101
3102         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3103         (make_all_visible): Use address of member.
3104
3105 2019-06-16  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3108         (tui_free_window, free_content, free_content_elements): Remove
3109         unnecessary cast.
3110         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3111         cast.
3112         * tui/tui-regs.c (tui_show_register_group)
3113         (tui_display_registers_from, tui_display_reg_element_at_line):
3114         Remove unnecessary cast.
3115
3116 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3117
3118         * linux-nat.c (normal_mask): Delete.
3119         (_initialize_linux_nat): Don't initialise normal_mask.
3120
3121 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3122
3123         PR gdb/24445
3124         * dwarf-index-write.h (write_psymtabs_to_index): Add
3125         dwz_basename parameter.
3126         * dwarf-index-write.c (write_gdbindex): Move file writing to
3127         write_gdbindex_1.  Change return type void.
3128         (assert_file_size): Move up, remove filename parameter.
3129         (write_gdbindex_1): New function.
3130         (write_debug_names): Change return type to void, call
3131         assert_file_size.
3132         (struct index_wip_file): New struct.
3133         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3134         file logic to index_wip_file.  Write index for dwz file if
3135         needed.
3136         (save_gdb_index_command): Pass basename of dwz file, if present.
3137         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3138         build-id of dwz file, if present.
3139         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3140         (dwarf2_get_dwz_file): Likewise.
3141         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3142         (dwarf2_get_dwz_file): Likewise.
3143
3144 2019-06-16  Tom Tromey  <tom@tromey.com>
3145
3146         * coffread.c (process_coff_symbol): Use xstrdup.
3147         * value.c (create_internalvar): Use xstrdup.
3148
3149 2019-06-16  Tom Tromey  <tom@tromey.com>
3150
3151         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3152         * breakpoint.c (stopin_command, stopat_command)
3153         (until_break_command, decode_location_default): Remove unnecessary
3154         cast.
3155         * utils.c (subset_compare): Remove unnecessary cast.
3156         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3157         cast.
3158         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3159         cast.
3160         * infcmd.c (path_command): Remove unnecessary cast.
3161         * coffread.c (decode_type): Remove unnecessary cast.
3162         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3163         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3164         * tui/tui-stack.c (tui_show_locator_content)
3165         (tui_show_frame_info): Remove unnecessary cast.
3166         * tui/tui-win.c (tui_scroll_forward_command)
3167         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3168         (parse_scrolling_args): Remove unnecessary cast.
3169         * tui/tui-data.c (init_win_info, tui_del_window)
3170         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3171         (free_content_elements): Remove unnecessary cast.
3172         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3173         unnecessary cast.
3174         * tui/tui-source.c (tui_set_source_content)
3175         (tui_vertical_source_scroll): Remove unnecessary cast.
3176         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3177         cast.
3178         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3179         * tui/tui-regs.c (tui_display_registers_from)
3180         (tui_display_register): Remove unnecessary cast.
3181         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3182         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3183         (make_visible): Remove unnecessary cast.
3184         * tui/tui-winsource.c (tui_erase_source_content)
3185         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3186         unnecessary cast.
3187         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3188         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3189         * stabsread.c (read_type, read_array_type, read_range_type):
3190         Remove unnecessary cast.
3191         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3192         (parse_symbol, parse_type, upgrade_type, parse_external)
3193         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3194         unnecessary cast.
3195         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3196
3197 2019-06-16  Tom Tromey  <tom@tromey.com>
3198
3199         * tui/tui-data.c (tui_alloc_generic_win_info)
3200         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3201         checks.
3202
3203 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3204             Andrew Burgess  <andrew.burgess@embecosm.com>
3205
3206         * f-typeprint.c (f_print_type): Don't return early for not
3207         associated or not allocated types.
3208         (f_type_print_varspec_suffix): Add print_rank parameter and print
3209         ranks of array types in case they dangling.
3210         (f_type_print_base): Add print_rank parameter.
3211
3212 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * NEWS: Mention new MI commands.
3215         * break-catch-throw.c (enum exception_event_kind): Move to
3216         breakpoint.h.
3217         (print_mention_exception_catchpoint): Output text as a single
3218         message.
3219         (catch_exception_command_1): Rename to...
3220         (catch_exception_event): ...this, make non-static, update header
3221         command, and change some parameter types.
3222         (catch_catch_command): Update for changes to
3223         catch_exception_command_1.
3224         (catch_throw_command): Likewise.
3225         (catch_rethrow_command): Likewise.
3226         * breakpoint.c (enum exception_event_kind): Delete.
3227         * breakpoint.h (enum exception_event_kind): Moved here from
3228         break-catch-throw.c.
3229         (catch_exception_event): Declare.
3230         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3231         (mi_cmd_catch_throw): New function.
3232         (mi_cmd_catch_rethrow): New function.
3233         (mi_cmd_catch_catch): New function.
3234         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3235         'catch-catch' entries.
3236         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3237         (mi_cmd_catch_rethrow): Declare.
3238         (mi_cmd_catch_catch): Declare.
3239
3240 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3241
3242         * annotate.c (annotate_source_line): Change return type to void,
3243         update implementation to match.
3244         * annotate.h (annotate_source_line): Change return type to void,
3245         update header comment.
3246         * stack.c (print_frame_info): Don't change what frame information
3247         is printed based on whether annotations are on or not.
3248
3249 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3250
3251         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3252         (annotate_source): Make static.
3253         (annotate_source_line): Moved from source.c and renamed from
3254         identify_source_line.  Update the return type.
3255         * annotate.h (annotate_source): Delete declaration.
3256         (annotate_source_line): Declaration moved from source.h, and
3257         renamed from identify_source_line.  Return type updated.
3258         * source.c (identify_source_line): Moved to annotate.c and renamed
3259         to annotate_source_line.
3260         (info_line_command): Remove check of annotation_level.
3261         * source.h (identify_source_line): Move declaration to annotate.h
3262         and rename to annotate_source_line.
3263         * stack.c: Add 'annotate.h' include.
3264         (print_frame_info): Remove check of annotation_level before
3265         calling annotate_source_line.
3266
3267 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * source-cache.c (source_cache::get_plain_source_lines): Use
3270         open_source_file_with_line_charpos instead of just
3271         open_source_file, remove call to find_source_lines.
3272         (source_cache::get_source_lines): Likewise.
3273         * source.c (find_source_lines): Make static.
3274         (get_filename_and_charpos): Renamed into...
3275         (open_source_file_with_line_charpos): ..this along with changes to
3276         return a scoped_fd, and some other minor clean ups.
3277         (identify_source_line): Use open_source_file_with_line_charpos.
3278         (search_command_helper): Use open_source_file_with_line_charpos
3279         instead of just open_source_file, remove call to
3280         find_source_lines.
3281         * source.h (open_source_file_with_line_charpos): Declare new
3282         function.
3283         (find_source_lines): Delete declaration.
3284
3285 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3286
3287         * source.c (get_filename_and_charpos): Remove fullname
3288         parameter.
3289         (identify_source_line): Update call to get_filename_and_charpos.
3290
3291 2019-06-14  Tom Tromey  <tromey@adacore.com>
3292
3293         PR gdb/24502:
3294         * ui-style.h (skip_ansi_escape): Update comment.
3295         * ui-file.h (class no_terminal_escape_file): New class.
3296         * ui-file.c (no_terminal_escape_file::write)
3297         (no_terminal_escape_file::puts): New methods.
3298         * cli/cli-logging.c (handle_redirections): Use
3299         no_terminal_escape_file.
3300
3301 2019-06-14  Tom Tromey  <tromey@adacore.com>
3302
3303         * NEWS: Move convenience variable news above Python news.
3304
3305 2019-06-14  Tom Tromey  <tom@tromey.com>
3306
3307         * gnulib: Move directory to top-level.
3308         * configure.ac: Don't configure gnulib.
3309         * configure: Rebuild.
3310         * common/common-defs.h: Use new path to gnulib.
3311         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3312         (GNULIB_H): Remove.
3313         (INCGNU): Look in new gnulib location.
3314         (HFILES_NO_SRCDIR): Remove gnulib files.
3315         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3316         (generated_files): Remove GNULIB_H.
3317         ($(LIBGNU), all-lib): Remove targets.
3318         (distclean): Don't mention GNULIB_BUILDDIR.
3319         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3320
3321 2019-06-14  Tom Tromey  <tromey@adacore.com>
3322
3323         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3324         Warn if symbol file does not provide any symbols.
3325
3326 2019-06-14  Tom Tromey  <tromey@adacore.com>
3327
3328         * source.c (find_and_open_source): Respect basenames_may_differ.
3329
3330 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3331
3332         * annotate.c (annotate_breakpoints_invalid): Make use of
3333         scoped_restore_terminal_state.
3334         (annotate_frames_invalid): Likewise.
3335
3336 2019-06-14  Tom Tromey  <tromey@adacore.com>
3337
3338         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3339         allow assignment to an internalvar.
3340
3341 2019-06-14  Tom Tromey  <tromey@adacore.com>
3342
3343         * ada-lex.l: Allow "_" in attribute names.
3344
3345 2019-06-14  Tom Tromey  <tromey@adacore.com>
3346
3347         PR gdb/24653:
3348         * regcache.c (registers_changed): Don't call alloca.
3349         * top.c (execute_command): Don't call alloca.
3350
3351 2019-06-13  Pedro Alves  <palves@redhat.com>
3352
3353         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3354         'expression'.  When parsing an expression, error out if there's
3355         junk after "unlimited".
3356         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3357         (do_set_command): Adjust calls to is_unlimited_literal.
3358
3359 2019-06-13  Pedro Alves  <palves@redhat.com>
3360
3361         * compile/compile.c (make_compile_options_def_group): Add braces
3362         around array_view initializer.
3363         * thread.c (make_thread_apply_all_options_def_group)
3364         (make_thread_apply_all_options_def_group): Likewise.
3365
3366 2019-06-13  Pedro Alves  <palves@redhat.com>
3367
3368         * NEWS (New commands): Mention "maint test-options
3369         require-delimiter", "maint test-options unknown-is-error", "maint
3370         test-options unknown-is-operand" and "maint show
3371         test-options-completion-result".
3372         (New command options, command completion): New section.
3373         (Completion improvements): New section.
3374         Mention that you can abbreviate "unlimited".
3375
3376 2019-06-13  Pedro Alves  <palves@redhat.com>
3377
3378         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3379         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3380         * unittests/cli-utils-selftests.c (test_parse_flags)
3381         (test_parse_flags_qcs): Delete.
3382         (test_cli_utils): Don't call deleted functions.
3383
3384 2019-06-13  Pedro Alves  <palves@redhat.com>
3385
3386         * thread.c: Include "cli/cli-option.h".
3387         (tp_array_compar_ascending): Global.
3388         (tp_array_compar): Delete function.
3389         (tp_array_compar_ascending, tp_array_compar_descending): New
3390         functions.
3391         (ascending_option_def, qcs_flag_option_def)
3392         (thr_qcs_flags_option_defs)
3393         (make_thread_apply_all_options_def_group)
3394         (make_thread_apply_options_def_group): New.
3395         (thread_apply_all_command): Use gdb::option::process_options.
3396         (thread_apply_command_completer)
3397         (thread_apply_all_command_completer): New.
3398         (thread_apply_command): Use gdb::option::process_options.
3399         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3400         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3401         to generate help text of "thread apply".  Adjust "taas"'s help.
3402         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3403         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3404
3405 2019-06-13  Pedro Alves  <palves@redhat.com>
3406
3407         * thread.c (thread_apply_command): Check for invalid TID with
3408         isdigit instead of !isalpha.
3409
3410 2019-06-13  Pedro Alves  <palves@redhat.com>
3411
3412         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3413         (validate_flags_qcs): New.
3414         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3415         (validate_flags_qcs): Declare.
3416         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3417         (make_frame_apply_options_def_group): New.
3418         (frame_apply_command_count): Process options with
3419         gdb::option::process_options.
3420         (frame_apply_completer): New.
3421         (frame_apply_level_completer, frame_apply_all_completer)
3422         (frame_apply_completer): New.
3423         (_initialize_stack): Update help of "frame apply", "frame apply
3424         level", "frame apply all" and "faas" to mention supported options
3425         and install command completers.
3426         * stack.h (frame_apply_all_completer): Declare.
3427         * thread.c: Include "stack.h".
3428         (tfaas_command): Add "--".
3429         (_initialize_thread): Update help "tfaas" to mention supported
3430         options and install command completer.
3431
3432 2019-06-13  Pedro Alves  <palves@redhat.com>
3433
3434         * completer.c (complete_nested_command_line): New.
3435         (gdb_completion_word_break_characters_throw): Add assertion.
3436         * completer.h (complete_nested_command_line): Declare.
3437
3438 2019-06-13  Pedro Alves  <palves@redhat.com>
3439
3440         * stack.c (parse_backtrace_qualifiers): New.
3441         (backtrace_command): Use it.
3442         (backtrace_command_completer): Complete on qualifiers.
3443
3444 2019-06-13  Pedro Alves  <palves@redhat.com>
3445
3446         * frame.c: Include "cli/cli-option.h.
3447         (user_set_backtrace_options): New.
3448         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3449         Delete.
3450         (get_prev_frame): Adjust.
3451         (boolean_option_def, uinteger_option_def)
3452         (set_backtrace_option_defs): New.
3453         (_initialize_frame): Adjust and use
3454         gdb::option::add_setshow_cmds_for_options to install "set
3455         backtrace past-main" and "set backtrace past-entry".
3456         * frame.h: Include "cli/cli-option.h".
3457         (struct frame_print_options): Forward declare.
3458         (print_frame_arguments_all, print_frame_arguments_scalars)
3459         (print_frame_arguments_none): Declare.
3460         (print_entry_values): Delete declaration.
3461         (struct frame_print_options, user_frame_print_options): New.
3462         (struct set_backtrace_options): New.
3463         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3464         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3465         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3466         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3467         (list_args_or_locals): Add frame_print_options parameter.
3468         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3469         * python/py-framefilter.c (enumerate_args): Pass down
3470         USER_FRAME_PRINT_OPTIONS.
3471         * stack.c: Include "cli/cli-option.h".
3472         (print_frame_arguments_all, print_frame_arguments_scalars)
3473         (print_frame_arguments_none): Declare.
3474         (print_raw_frame_arguments, print_entry_values): Delete.
3475         (user_frame_print_options): New.
3476         (boolean_option_def, enum_option_def, frame_print_option_defs):
3477         New.
3478         (struct backtrace_cmd_options): New.
3479         (bt_flag_option_def): New.
3480         (backtrace_command_option_defs): New.
3481         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3482         (print_frame_arg, read_frame_arg, print_frame_args)
3483         (print_frame_info, print_frame): Add frame_print_options parameter
3484         and use it.
3485         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3486         (backtrace_command_1): Add frame_print_options and
3487         backtrace_cmd_options parameters and use them.
3488         (make_backtrace_options_def_group): New.
3489         (backtrace_command): Process command options with
3490         gdb::option::process_options.
3491         (backtrace_command_completer): New.
3492         (_initialize_stack): Extend "backtrace"'s help to mention
3493         supported options.  Install completer for "backtrace".
3494         Install some settings commands with add_setshow_cmds_for_options.
3495
3496 2019-06-13  Pedro Alves  <palves@redhat.com>
3497
3498         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3499         and that "set/show print raw frame-arguments" are now deprecated.
3500
3501         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3502         command.
3503         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3504         * stack.c (_initialize_stack): Install "set/show print
3505         raw-frame-arguments", and deprecate "set/show print raw
3506         frame-arguments".
3507         * valprint.c (_initialize_valprint): Deprecate "set/show print
3508         raw".
3509
3510 2019-06-13  Pedro Alves  <palves@redhat.com>
3511
3512         * compile/compile.c (struct compile_options): New.
3513         (compile_flag_option_def, compile_command_option_defs)
3514         (make_compile_options_def_group): New.
3515         (compile_file_command): Handle options with
3516         gdb::option::process_options.
3517         (compile_file_command_completer): New function.
3518         (compile_code_command): Handle options with
3519         gdb::option::process_options.
3520         (compile_code_command_completer): New function.
3521         (_initialize_compiler): Install completers for "compile code" and
3522         "compile file".  Mention available options in "compile code" and
3523         "compile code"'s help.
3524         * completer.c (advance_to_completion_word): New, factored out from
3525         ...
3526         (advance_to_expression_complete_word_point): ... this.
3527         (advance_to_filename_complete_word_point): New.
3528         * completer.h (advance_to_filename_complete_word_point): New
3529         declaration.
3530
3531 2019-06-13  Pedro Alves  <palves@redhat.com>
3532
3533         * compile/compile.c: Include "cli/cli-option.h".
3534         (compile_print_value): Scope data pointer is now a
3535         value_print_options pointer; adjust.
3536         (compile_print_command): Process options.  Scope data pointer is
3537         now a value_print_options pointer; adjust.
3538         (_initialize_compile): Update "compile print"'s help to include
3539         supported options.  Install a completer for "compile print".
3540         * cp-valprint.c (show_vtblprint, show_objectprint)
3541         (show_static_field_print): Delete.
3542         (_initialize_cp_valprint): Don't install "set print
3543         static-members", "set print vtbl", "set print object" here.
3544         * printcmd.c: Include "cli/cli-option.h" and
3545         "common/gdb_optional.h".
3546         (print_command_parse_format): Rework to fill in a
3547         value_print_options instead of a format_data.
3548         (print_value): Change parameter type from format_data pointer to
3549         value_print_options reference.  Adjust.
3550         (print_command_1): Process options.  Adjust to pass down a
3551         value_print_options.
3552         (print_command_completer): New.
3553         (_initialize_printcmd): Install print_command_completer as
3554         handle_brkchars completer for the "print" command.  Update
3555         "print"'s help to include supported options.
3556         * valprint.c: Include "cli/cli-option.h".
3557         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3558         here from cp-valprint.c.
3559         (boolean_option_def, uinteger_option_def)
3560         (value_print_option_defs, make_value_print_options_def_group):
3561         New.  Use gdb::option::add_setshow_cmds_for_options to install
3562         "set print elements", "set print null-stop", "set print repeats",
3563         "set print pretty", "set print union", "set print array", "set
3564         print address", "set print symbol", "set print array-indexes".
3565         * valprint.h: Include <string> and "cli/cli-option.h".
3566         (make_value_print_options_def_group): Declare.
3567         (print_value): Change parameter type from format_data pointer to
3568         value_print_options reference.
3569         (print_command_completer): Declare.
3570
3571 2019-06-13  Pedro Alves  <palves@redhat.com>
3572
3573         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3574         (COMMON_SFILES): Add maint-test-settings.c.
3575         * cli/cli-decode.c (boolean_enums): New global, factored out from
3576         ...
3577         (add_setshow_boolean_cmd): ... here.
3578         * cli/cli-decode.h (boolean_enums): Declare.
3579         * cli/cli-option.c: New file.
3580         * cli/cli-option.h: New file.
3581         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3582         factored out from ...
3583         (parse_cli_boolean_value(const char *)): ... this.
3584         (is_unlimited_literal): Change parameter type to pointer to
3585         pointer.  Adjust and advance ARG pointer.
3586         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3587         (parse_cli_var_enum): New, factored out from ...
3588         (do_set_command): ... this.  Adjust.
3589         * cli/cli-setshow.h (parse_cli_boolean_value)
3590         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3591         (parse_cli_var_enum): Declare.
3592         * cli/cli-utils.c: Include "cli/cli-option.h".
3593         (get_ulongest): New.
3594         * cli/cli-utils.h (get_ulongest): Declare.
3595         (check_for_argument): New overloads.
3596         * maint-test-options.c: New file.
3597
3598 2019-06-13  Pedro Alves  <palves@redhat.com>
3599
3600         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3601         parse a range if "-" is at the end of the string.
3602
3603 2019-06-13  Pedro Alves  <palves@redhat.com>
3604
3605         * cli/cli-setshow.c (parse_auto_binary_operation)
3606         (parse_cli_boolean_value): Don't allow "o".
3607
3608 2019-06-13  Pedro Alves  <palves@redhat.com>
3609
3610         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3611         * NEWS: Mention maint test-settings KIND.
3612         * maint-test-settings.c: New file.
3613
3614 2019-06-13  Pedro Alves  <palves@redhat.com>
3615
3616         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3617         completer.
3618         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3619         "set" completers.
3620
3621 2019-06-13  Pedro Alves  <palves@redhat.com>
3622
3623         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3624         after item.
3625
3626 2019-06-13  Pedro Alves  <palves@redhat.com>
3627
3628         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3629
3630 2019-06-13  Pedro Alves <palves@redhat.com>
3631
3632         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3633         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3634         call.
3635         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3636         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3637         calls.
3638         (check_for_argument): Skip spaces after argument.
3639
3640 2019-06-13  Pedro Alves  <palves@redhat.com>
3641
3642         * thread.c (thread_apply_command): Adjust TID parsing.
3643         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3644         detected before end of string.
3645         (tid_is_in_list): Error out if LIST is invalid.
3646
3647 2019-06-13  Pedro Alves  <palves@redhat.com>
3648
3649         * completer.c (complete_line_internal_1): Rewind completion word
3650         point.
3651         (completion_tracker::advance_custom_word_point_by): Change
3652         parameter type to int.
3653         * completer.h (completion_tracker::advance_custom_word_point_by):
3654         Likewise.
3655
3656 2019-06-13  Pedro Alves  <palves@redhat.com>
3657
3658         * completer.c (advance_to_completion_word): Handle delimiters.
3659
3660 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3661
3662         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3663
3664 2019-06-11  Tom Tromey  <tom@tromey.com>
3665
3666         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3667         (xmalloc_failed): Move to alloc.c.
3668         * alloc.c: New file.
3669         * Makefile.in (COMMON_SFILES): Add alloc.c.
3670
3671 2019-06-11  Tom Tromey  <tom@tromey.com>
3672
3673         * nat/linux-waitpid.c: Don't include server.h.
3674         (linux_debug): Remove.
3675         (my_waitpid): Update.
3676
3677 2019-06-11  Tom Tromey  <tromey@adacore.com>
3678
3679         * infcall.c (_initialize_infcall): Remove trailing newline from
3680         help.
3681         * user-regs.c (_initialize_user_regs): Remove trailing newline
3682         from help.
3683         * typeprint.c (_initialize_typeprint): Remove trailing newline
3684         from help.
3685         * reverse.c (_initialize_reverse): Remove trailing newlines from
3686         help.
3687         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3688         from help.
3689         * language.c (add_set_language_command): Remove trailing newline
3690         from help.
3691         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3692         help.
3693         * disasm.c (_initialize_disasm): Remove trailing newline from
3694         help.
3695         * top.c (init_main): Remove trailing newline from help.
3696         * interps.c (_initialize_interpreter): Remove trailing newline
3697         from help.
3698         * btrace.c (_initialize_btrace): Remove trailing newlines from
3699         help.
3700         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3701         from help.
3702         * python/python.c (_initialize_python): Remove trailing newline
3703         from help.
3704         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3705         help.
3706         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3707         from help.  Reformat some text.
3708         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3709         from help.
3710         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3711         newline from help.
3712
3713 2019-06-11  Tom Tromey  <tromey@adacore.com>
3714
3715         * darwin-nat.c (darwin_decode_exception_message)
3716         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3717
3718 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3719
3720         * valops.c (value_slice): Check for not allocated or not
3721         associated values.
3722
3723 2019-06-10  Tom de Vries  <tdevries@suse.de>
3724
3725         PR gdb/24618
3726         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3727         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3728         invalid.
3729
3730 2019-06-10  Tom de Vries  <tdevries@suse.de>
3731
3732         PR gdb/24611
3733         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3734         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3735
3736 2019-06-10  Tom de Vries  <tdevries@suse.de>
3737
3738         PR symtab/24545
3739         * symtab.c (struct demangled_name_entry): Add language field.
3740         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3741         static minimal symbol".  Set and use language field.
3742
3743 2019-06-10  Tom Tromey  <tromey@adacore.com>
3744
3745         * ada-lang.c (_initialize_ada_language): Update help text.
3746
3747 2019-06-10  Tom Tromey  <tromey@adacore.com>
3748
3749         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3750         with a newline.
3751         * guile/guile.c (handle_boot_error): Don't end warning with a
3752         newline.
3753         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3754         warning with a newline.
3755         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3756         newline.
3757         (s12z_frame_cache): Likewise.
3758         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3759         a newline.
3760         * solib-svr4.c (disable_probes_interface): Don't end warning with
3761         a newline.
3762         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3763         newline.
3764         * python/python.c (do_finish_initialization): Don't end warning
3765         with a newline.
3766
3767 2019-06-10  Tom Tromey  <tom@tromey.com>
3768
3769         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3770         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3771         gdbpy_enter.
3772
3773 2019-06-10  Tom Tromey  <tromey@adacore.com>
3774
3775         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3776         data.
3777         (elf_new_init): Don't call stabsread_new_init.
3778         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3779         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3780         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3781
3782 2019-06-10  Tom de Vries  <tdevries@suse.de>
3783
3784         PR symtab/16264
3785         PR symtab/24517
3786         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3787
3788 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3789
3790         * source.c (find_and_open_source): Also rewrite relative file
3791         names.
3792
3793 2019-04-26  Amos Bird  <amosbird@gmail.com>
3794
3795         * annotate.c (annotate_thread_exited): Add "thread-exited"
3796         annotation.
3797
3798 2019-06-06  Tom Tromey  <tromey@adacore.com>
3799
3800         * maint.h (class scoped_command_stats): Use
3801         DISABLE_COPY_AND_ASSIGN.
3802         <print_time>: New method.
3803         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3804         print_time.
3805         (scoped_command_stats::print_time): New method.
3806
3807 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3810         instructions of lengths 6 or 8 bytes.
3811
3812 2019-06-04  Pedro Alves  <palves@redhat.com>
3813
3814         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3815
3816         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3817         * breakpoint.c (condition_completer): Likewise.
3818         * cli/cli-dump.c (scan_expression): Likewise.
3819         * common/filestuff.c (mkdir_recursive): Likewise.
3820         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3821         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3822         (gdb_abspath): Likewise.
3823         * compile/compile-cplus-types.c
3824         (compile_cplus_instance::decl_name): Likewise.
3825         * completer.c (complete_explicit_location):
3826         (signal_completer, reg_or_group_completer_1): Likewise.
3827         * cp-support.c (cp_remove_params_if_any): Likewise.
3828         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3829         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3830         * infcmd.c (strip_bg_char): Likewise.
3831         * linespec.c (copy_token_string): Likewise.
3832         * mi/mi-main.c (output_cores): Likewise.
3833         * psymtab.c (psymtab_search_name):
3834         * symfile.c (test_set_ext_lang_command): Likewise.
3835         * target.c (target_fileio_read_stralloc): Likewise.
3836         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3837         * value.c (complete_internalvar): Likewise.
3838
3839 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3840
3841         Add objfile property to gdb.Type.
3842         * NEWS: Mention Python API addition.
3843         * python/py-type.c (typy_get_objfile): New method.
3844
3845 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3846
3847         * NEWS: Mention the new set|show style [title|highlight].
3848         Mention changes to "show style", "help" and "apropos".
3849
3850 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3851
3852         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3853         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3854         instead of print_help_for_command.
3855         (print_doc_of_command): New function.
3856         (help_list): Add 'apropos -v word' suggestion.
3857         (print_help_for_command): Style the command name using title style.
3858         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3859         (_initialize_cli_cmds): Describe -v in apropos_command help.
3860
3861 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3862
3863         * cli/cli-style.h (cli_style_option): Add name in constructor,
3864         add m_name class member, add constructor with intensity,
3865         add name class function.
3866         (cli_style_option::add_setshow_commands): Remove name argument.
3867         (highlight_style, title_style): New styles.
3868         * cli/cli-style.c (do_show): New function that shows a style
3869         characteristic styling the style name with itself.
3870         (set_style_name): New function.
3871         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3872         Update all callers according to the changes in cli/cli-style.h.
3873         * utils.h (fputs_highlighted): New function.
3874         * utils.c (fputs_highlighted): Likewise.
3875
3876 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3877
3878         * NEWS: Mention new pipe command and new convenience variables.
3879
3880 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3881
3882         * cli/cli-cmds.c (pipe_command): New function.
3883         (_initialize_cli_cmds): Call add_com for pipe_command.
3884         Define | as an alias for pipe.
3885         (exit_status_set_internal_vars): New function.
3886         (shell_escape): Call exit_status_set_internal_vars.
3887         cli/cli-decode.c (find_command_name_length): Recognize | as
3888         a single character command.
3889
3890 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3891
3892         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3893         top.c (execute_command_to_ui_file): New function, mostly a copy
3894         of execute_command_to_string.
3895         (execute_command_to_string): Implement by calling
3896         execute_command_to_ui_file.
3897
3898 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3899
3900         * top.h (saved_command_line): Remove declaration.
3901         * top.c (previous_saved_command_line, previous_repeat_arguments):
3902         New variables.
3903         (saved_command_line): Make static, define together with other
3904         'repeat variables'.
3905         (dont_repeat): Clear repeat_arguments.
3906         (repeat_previous, get_saved_command_line, save_command_line):
3907         New functions.
3908         (gdb_init): Initialize saved_command_line
3909         and previous_saved_command_line.
3910         * main.c (captured_main_1): Remove saved_command_line initialization.
3911         * event-top.c (handle_line_of_input): Update to use
3912         the new 'repeat' related functions instead of direct access to
3913         saved_command_line.
3914         * command.h (repeat_previous, get_saved_command_line,
3915         save_command_line): New declarations.
3916         (dont_repeat): Add comment.
3917
3918 2019-05-30  Tom Tromey  <tromey@adacore.com>
3919
3920         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3921         Fix comment.
3922         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3923
3924 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3925
3926         PR cli/24587
3927         * completer.c (complete): Initialize variable word.
3928
3929 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3930
3931         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3932         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3933         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3934         'body' is NULL to the outter 'if', protecting the '!is_define'
3935         situation as well.
3936
3937 2019-05-29  Tom Tromey  <tromey@adacore.com>
3938
3939         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3940         (dwarf_unknown): New function.
3941         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3942         (dwarf_type_encoding_name): Use dwarf_unknown.
3943
3944 2019-05-29  Tom Tromey  <tromey@adacore.com>
3945
3946         PR c++/20020:
3947         * cp-valprint.c (cp_print_value_fields): Call
3948         cp_print_static_field inside "try".
3949
3950 2019-05-29  Tom Tromey  <tromey@adacore.com>
3951
3952         * inflow.c (struct terminal_info): Add default operator=.
3953         * configure: Rebuild.
3954         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3955         -Wdeprecated-copy-dtor, -Wredundant-move.
3956
3957 2019-05-29  Tom Tromey  <tromey@adacore.com>
3958
3959         * NEWS: Add entry.
3960         * infcmd.c (print_return_value_1): Handle finish_print
3961         option.
3962         (show_print_finish): New function.
3963         (_initialize_infcmd): Add "set/show print finish" commands.
3964         * valprint.c (user_print_options): Initialize new member.
3965         * valprint.h (struct value_print_options) <finish_print>: New
3966         member.
3967
3968 2019-05-28  Tom Tromey  <tromey@adacore.com>
3969
3970         * ada-lang.c (ada_remove_Xbn_suffix)
3971         (find_old_style_renaming_symbol)
3972         (parse_old_style_renaming): Remove.
3973         (ada_find_renaming_symbol): Don't call
3974         find_old_style_renaming_symbol.
3975         (ada_is_renaming_symbol): Rename from
3976         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3977         bool.  Now static.
3978         (ada_read_var_value): Update and simplify.
3979         * ada-exp.y (write_var_or_type): Remove old code.
3980
3981 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3982
3983         * event-top.c: Remove include comment.
3984         * inflow.c (class scoped_ignore_sigttou): Move from here...
3985         * inflow.h (class scoped_ignore_sigttou): ...to here.
3986         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3987         * top.c:  Remove include comment.
3988
3989 2019-05-27  Tom Tromey  <tom@tromey.com>
3990
3991         * NEWS: Fix typo.
3992
3993 2019-05-22  Tom Tromey  <tromey@adacore.com>
3994
3995         * target.c (target_follow_exec): Constify parameter.
3996         * target-delegates.c: Rebuild.
3997         * remote.c (remote_target::follow_exec): Constify parameter.
3998         * infrun.c (follow_exec): Constify parameter.
3999         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4000         (target_follow_exec): Likewise.
4001
4002 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4003
4004         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4005         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4006
4007 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4008
4009         * NEWS: Add debugredirect and testsuite sections.
4010
4011 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4012
4013         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4014         target descriptions using exclusively floating point register name
4015         aliases.
4016
4017 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4018
4019         PR gdb/18644:
4020         * f-lang.c (build_fortran_types): Handle the case where
4021         gdbarch_floatformat_for_type returns a nullptr.
4022
4023 2019-05-21  Tom de Vries  <tdevries@suse.de>
4024
4025         PR cli/24587
4026         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4027
4028 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         PR gdb/18644:
4031         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4032         16-byte floats.
4033         * i386-tdep.c (i386_floatformat_for_type): Use
4034         floatformats_ia64_quad for the 16-byte floating point component
4035         within a fortran 32-byte complex number.
4036
4037 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4038
4039         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4040         delete default constructor.
4041         (find_partial_die): Update to return const struct.
4042         (partial_die_parent_scope): Move variable declaration into scope
4043         of its use and change its type to auto.
4044         (guess_partial_die_structure_name): Likewise.
4045         (partial_die_info::fixup): Likewise.
4046
4047 2019-05-17  Tom Tromey  <tromey@adacore.com>
4048
4049         * source.c (find_and_open_source): Remove cast.
4050
4051 2019-05-17  Tom Tromey  <tromey@adacore.com>
4052
4053         * annotate.c (annotate_source): Make "filename" const.
4054         * annotate.h (annotate_source): Use const.
4055
4056 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4057
4058         * disasm.c (set_disassembler_options): Send errors to stderr.
4059
4060 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4061
4062         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4063         (cli_interp_base::set_logging): Check debug_redirect.
4064         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4065         * cli/cli-logging.c (debug_redirect): Add static variable.
4066         (pop_output_files): Add default param.
4067         (handle_redirections): Print debug setting.
4068         (show_logging_command): Likewise.
4069         (_initialize_cli_logging): Add debugredirect command.
4070         * interps.c (current_interp_set_logging): Add debug_redirect
4071         parameter.
4072         * interps.h (set_logging): Add debug_redirect parameter.
4073         (current_interp_set_logging): Likewise.
4074         * mi/mi-common.h: Likewise.
4075         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4076
4077 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4078             Tom Tromey  <tromey@adacore.com>
4079
4080         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4081         directly.
4082         * cli/cli-interp.h (make_logging_output): Remove declaration.
4083         * cli/cli-logging.c (make_logging_output): Remove function.
4084         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4085         directly.
4086         * ui-file.c (tee_file::tee_file): Remove bools.
4087         (tee_file::~tee_file): Remove deletes.
4088         * ui-file.h (tee_file): Remove bools.
4089
4090 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4091
4092         * mi/mi-cmds.h (mi_cmd_complete): New function.
4093         * mi/mi-main.c (mi_cmd_complete): Likewise.
4094         * mi/mi-cmds.c: Define new MI command -complete.
4095         * NEWS: Mention new -complete command.
4096
4097 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4098
4099         * completer.h (complete): New function.
4100         * completer.c (complete): Likewise.
4101         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4102         function defined in completer.h.
4103
4104 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4105
4106         * MAINTAINERS (Write After Approval): Add myself.
4107
4108 2019-05-17  Tom de Vries  <tdevries@suse.de>
4109
4110         PR gdb/24094
4111         * dwarf2read.c (struct cu_partial_die_info): New struct.
4112         (find_partial_die): Return cu_partial_die_info.
4113         (partial_die_parent_scope, guess_partial_die_structure_name)
4114         (partial_die_info::fixup): Handle new return type of find_partial_die.
4115
4116 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4117
4118         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4119         "std::string", simplifying the algorithm.
4120
4121 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4122
4123         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4124         (stap_static_probe_ops::get_probes): Likewise.
4125
4126 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4127
4128         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4129         '-')" and "else if".
4130         (stap_parse_single_operand): Join checks for
4131         "gdbarch_stap_parse_special_token_p" and
4132         "gdbarch_stap_parse_special_token" in the same "if" statement.
4133         Invert check when verifying for operation on register
4134         displacement.
4135
4136 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4137
4138         * stap-probe.c (stap_get_opcode): Update comment.
4139         (stap_get_expected_argument_type): Likewise.
4140         (handle_stap_probe): Likewise.
4141
4142 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4143
4144         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4145         return type to 'bool'.  Adjust comment.  Use 'bool' when
4146         appropriate.
4147         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4148         * stap-probe.c (stap_parse_argument_1): Likewise.
4149         (stap_is_operator): Likewise.
4150         (stap_is_generic_prefix): Likewise.
4151         (stap_is_register_prefix): Likewise.
4152         (stap_is_register_indirection_prefix): Likewise.
4153         (stap_is_integer_prefix): Likewise.
4154         (stap_generic_check_suffix): Likewise.
4155         (stap_check_integer_suffix): Likewise.
4156         (stap_check_register_suffix): Likewise.
4157         (stap_check_register_indirection_suffix): Likewise.
4158         (stap_parse_register_operand): Likewise.
4159         (stap_parse_single_operand): Likewise.
4160         (stap_parse_argument_1): Likewise.
4161         (stap_probe::get_argument_count): Likewise.
4162         (stap_is_operator): Likewise.
4163
4164 2019-05-16  Tom Tromey  <tromey@adacore.com>
4165
4166         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4167         keyword to foreach.
4168
4169 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4170
4171         * linux-thread-db.c (try_thread_db_load_1): Change return type
4172         to bool.
4173         (try_thread_db_load): Likewise.
4174         (try_thread_db_load_from_pdir_1): Likewise.
4175         (try_thread_db_load_from_pdir): Likewise.
4176         (try_thread_db_load_from_sdir): Likewise.
4177         (try_thread_db_load_from_dir): Likewise.
4178         (thread_db_load_search): Likewise.
4179         (has_libpthread): Likewise.
4180         (thread_db_load): Likewise.
4181
4182 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4183
4184         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4185         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4186         NULL, and complain/return if that's the case.
4187
4188 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4189
4190         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4191         (advance, posn, abstract_read_memory): New functions.
4192         [struct mem_read_abstraction]: New struct.
4193         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4194
4195 2019-05-14  Tom Tromey  <tromey@adacore.com>
4196
4197         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4198         value is not lval_memory.
4199
4200 2019-05-14  Tom Tromey  <tromey@adacore.com>
4201
4202         * solib.c (info_sharedlibrary_command): Style the file name.
4203
4204 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4205
4206         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4207         (aarch64_vnv_type): Likewise.
4208         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4209         * common/tdesc.c: Likewise.
4210         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4211         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4212         * features/aarch64-fpu.xml: Add ieee half view.
4213         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4214         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4215         * gdbtypes.h (struct builtin_type): Likewise.
4216         (struct objfile_type): Likewise.
4217
4218 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4219
4220         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4221         typo.
4222         * location.h (string_to_event_location): Likewise.
4223
4224 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4225
4226         GDB 8.3 released.
4227
4228 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4229
4230         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4231         New variable declaration.
4232         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4233         New variable.
4234         (print_one_breakpoint): Use ui_out::test_flags and new global
4235         variable to compute use_fixed_output.
4236         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4237         Remove.
4238         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4239         (mi_multi_location_breakpoint_output_fixed): Remove.
4240         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4241         new variable.
4242         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4243         fix_multi_location_breakpoint_output flag if version >= 3.
4244         * ui-out.h (enum ui_out_flag)
4245         <fix_multi_location_breakpoint_output>: New enumerator.
4246
4247 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4248
4249         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4250
4251 2019-05-10  Tom Tromey  <tromey@adacore.com>
4252
4253         * ada-lang.c (catch_ada_completer): New function.
4254         (_initialize_ada_language): Use it.
4255
4256 2019-05-10  Tom Tromey  <tromey@adacore.com>
4257
4258         * thread.c (print_thread_info): Make "requested_threads" const.
4259         * gdbthread.h (print_thread_info): Make "requested_threads"
4260         const.
4261         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4262         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * gdbtypes.c (objfile_type_data): Change type.
4267         (objfile_type, _initialize_gdbtypes): Update.
4268
4269 2019-05-08  Tom Tromey  <tom@tromey.com>
4270
4271         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4272         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4273         (_initialize_dwarf2_frame): Update.
4274
4275 2019-05-08  Tom Tromey  <tom@tromey.com>
4276
4277         * objc-lang.c (objc_objfile_data): Change type.
4278         (find_methods): Update.
4279         (_initialize_objc_lang): Remove.
4280
4281 2019-05-08  Tom Tromey  <tom@tromey.com>
4282
4283         * stabsread.c (rs6000_builtin_type_data): Change type.
4284         (rs6000_builtin_type, _initialize_stabsread): Update.
4285
4286 2019-05-08  Tom Tromey  <tom@tromey.com>
4287
4288         * mips-tdep.c (mips_pdr_data): Remove.
4289         (_initialize_mips_tdep): Update.
4290
4291 2019-05-08  Tom Tromey  <tom@tromey.com>
4292
4293         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4294         (hppa_init_objfile_priv_data, read_unwind_info)
4295         (find_unwind_entry, _initialize_hppa_tdep): Update.
4296
4297 2019-05-08  Tom Tromey  <tom@tromey.com>
4298
4299         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4300         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4301         on obstack.
4302         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4303
4304 2019-05-08  Tom Tromey  <tom@tromey.com>
4305
4306         * mdebugread.c (basic_type_data): Change type.
4307         (basic_type, _initialize_mdebugread): Update.
4308
4309 2019-05-08  Tom Tromey  <tom@tromey.com>
4310
4311         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4312
4313 2019-05-08  Tom Tromey  <tom@tromey.com>
4314
4315         * nto-tdep.c (nto_inferior_data_reg): Change type.
4316         (nto_inferior_data): Update.
4317         (nto_inferior_data_cleanup, nto_new_inferior_data)
4318         (_initialize_nto_tdep): Remove.
4319         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4320
4321 2019-05-08  Tom Tromey  <tom@tromey.com>
4322
4323         * ada-lang.c (struct ada_inferior_data): Add initializers.
4324         (ada_inferior_data): Change type.
4325         (ada_inferior_data_cleanup): Remove.
4326         (get_ada_inferior_data, ada_inferior_exit)
4327         (struct ada_pspace_data): Add initializers, destructor.
4328         (ada_pspace_data_handle): Change type.
4329         (get_ada_pspace_data): Update.
4330         (ada_pspace_data_cleanup): Remove.
4331
4332 2019-05-08  Tom Tromey  <tom@tromey.com>
4333
4334         * coffread.c (struct coff_symfile_info): Add initializers.
4335         (coff_objfile_data_key): Move lower.  Change type.
4336         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4337         Update.
4338         (coff_free_info): Remove.
4339
4340 2019-05-08  Tom Tromey  <tom@tromey.com>
4341
4342         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4343         (fbsd_pspace_data_handle): Move lower.  Change type.
4344         (get_fbsd_pspace_data): Update.
4345         (fbsd_pspace_data_cleanup): Remove.
4346         (_initialize_fbsd_tdep): Update.
4347
4348 2019-05-08  Tom Tromey  <tom@tromey.com>
4349
4350         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4351         (get_ada_tasks_pspace_data): Update.
4352         (ada_tasks_pspace_data_cleanup): Remove.
4353         (_initialize_tasks): Update.
4354         (ada_tasks_inferior_data_handle): Change type.
4355         (get_ada_tasks_inferior_data): Update.
4356         (ada_tasks_inferior_data_cleanup): Remove.
4357         (struct ada_tasks_pspace_data): Add initializers.
4358
4359 2019-05-08  Tom Tromey  <tom@tromey.com>
4360
4361         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4362         * symfile-debug.c (debug_sym_get_probes): Change type.
4363         * stap-probe.c (handle_stap_probe):
4364         (stap_static_probe_ops::get_probes): Change type.
4365         * probe.h (class static_probe_ops) <get_probes>: Change type.
4366         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4367         (parse_probes_in_pspace): Update.
4368         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4369         Update.
4370         (any_static_probe_ops::get_probes): Change type.
4371         * elfread.c (elfread_data): New typedef.
4372         (probe_key): Change type.
4373         (elf_get_probes): Likewise.  Update.
4374         (probe_key_free): Remove.
4375         (_initialize_elfread): Update.
4376         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4377         Change type.
4378         (dtrace_process_dof_probe, dtrace_process_dof)
4379         (dtrace_static_probe_ops::get_probe): Change type.
4380
4381 2019-05-08  Tom Tromey  <tom@tromey.com>
4382
4383         * xcoffread.c (struct xcoff_symfile_info): Rename from
4384         coff_symfile_info.  Add initializers.
4385         (xcoff_objfile_data_key): Move lower.  Change type.
4386         (XCOFF_DATA): Rewrite.
4387         (xcoff_free_info): Remove.
4388         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4389         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4390         (xcoff_initial_scan): Update.
4391
4392 2019-05-08  Tom Tromey  <tom@tromey.com>
4393
4394         * solib-svr4.c (struct svr4_info): Add initializers and
4395         destructor.
4396         <probes_table>: Now an htab_up.
4397         (solib_svr4_pspace_data): Change type.
4398         (free_probes_table): Simplify.
4399         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4400         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4401         (probes_table_remove_objfile_probes, register_solib_event_probe)
4402         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4403         (_initialize_svr4_solib): Update.
4404
4405 2019-05-08  Tom Tromey  <tom@tromey.com>
4406
4407         * remote.c (remote_pspace_data): Change type.
4408         (remote_pspace_data_cleanup): Remove.
4409         (get_remote_exec_file, set_pspace_remote_exec_file)
4410         (_initialize_remote): Update.
4411
4412 2019-05-08  Tom Tromey  <tom@tromey.com>
4413
4414         * breakpoint.c (breakpoint_objfile_key): Change type.
4415         (get_breakpoint_objfile_data): Update.
4416         (free_breakpoint_objfile_data): Remove.
4417         (_initialize_breakpoint): Update.
4418
4419 2019-05-08  Tom Tromey  <tom@tromey.com>
4420
4421         * linux-tdep.c (struct linux_info): Add initializers.
4422         (linux_inferior_data): Move.  Change type.
4423         (invalidate_linux_cache_inf): Update.
4424         (linux_inferior_data_cleanup): Remove.
4425         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4426
4427 2019-05-08  Tom Tromey  <tom@tromey.com>
4428
4429         * auxv.c (auxv_inferior_data): Move.  Change type.
4430         (auxv_inferior_data_cleanup): Remove.
4431         (invalidate_auxv_cache_inf): Rewrite.
4432         (get_auxv_inferior_data, _initialize_auxv): Update.
4433
4434 2019-05-08  Tom Tromey  <tom@tromey.com>
4435
4436         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4437         (symfile_debug_objfile_data_key): Change type.
4438         (symfile_debug_installed, debug_qf_has_symbols)
4439         (debug_qf_find_last_source_symtab)
4440         (debug_qf_forget_cached_source_info)
4441         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4442         (debug_qf_print_stats, debug_qf_dump)
4443         (debug_qf_expand_symtabs_for_function)
4444         (debug_qf_expand_all_symtabs)
4445         (debug_qf_expand_symtabs_with_fullname)
4446         (debug_qf_map_matching_symbols)
4447         (debug_qf_expand_symtabs_matching)
4448         (debug_qf_find_pc_sect_compunit_symtab)
4449         (debug_qf_map_symbol_filenames)
4450         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4451         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4452         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4453         (debug_sym_read_linetable, debug_sym_relocate): Update.
4454         (symfile_debug_free_objfile): Remove.
4455         (install_symfile_debug_logging, _initialize_symfile_debug):
4456         Update.
4457
4458 2019-05-08  Tom Tromey  <tom@tromey.com>
4459
4460         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4461         allocate_on_obstack.
4462         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4463         (get_dwarf2_per_objfile): Update.
4464         (set_dwarf2_per_objfile): Remove.
4465         (dwarf2_has_info, dwarf2_get_section_info): Update.
4466         (dwarf2_free_objfile): Remove.
4467         (_initialize_dwarf2_read): Update.
4468
4469 2019-05-08  Tom Tromey  <tom@tromey.com>
4470
4471         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4472         initializers.
4473         <unsupported_script_warning_printed,
4474         script_not_found_warning_printed>: Now bool.
4475         (auto_load_pspace_data): Change type.
4476         (~auto_load_pspace_info): Rename from
4477         auto_load_pspace_data_cleanup.
4478         (get_auto_load_pspace_data, init_loaded_scripts_info)
4479         (clear_section_scripts, maybe_print_unsupported_script_warning)
4480         (maybe_print_script_not_found_warning, _initialize_auto_load):
4481         Update.
4482
4483 2019-05-08  Tom Tromey  <tom@tromey.com>
4484
4485         * objfiles.c (objfile_pspace_info): Add destructor and
4486         initializers.
4487         (objfiles_pspace_data): Change type.
4488         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4489         (get_objfile_pspace_data): Update.
4490         (objfiles_bfd_data): Change type.
4491         (get_objfile_bfd_data): Update.
4492         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4493
4494 2019-05-08  Tom Tromey  <tom@tromey.com>
4495
4496         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4497         Change type.
4498         (get_catch_syscall_inferior_data): Update.
4499         (catch_syscall_inferior_data_cleanup): Remove.
4500         (_initialize_break_catch_syscall): Update.
4501
4502 2019-05-08  Tom Tromey  <tom@tromey.com>
4503
4504         * inflow.c (struct terminal_info): Add destructor and
4505         initializers.
4506         (inflow_inferior_data): Change type.
4507         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4508         (get_inflow_inferior_data, inflow_inferior_exit)
4509         (swap_terminal_info, _initialize_inflow): Update.
4510
4511 2019-05-08  Tom Tromey  <tom@tromey.com>
4512
4513         * target-dcache.c (target_dcache_cleanup): Remove.
4514         (target_dcache_aspace_key): Change type.
4515         (target_dcache_init_p, target_dcache_invalidate)
4516         (target_dcache_get, target_dcache_get_or_init)
4517         (_initialize_target_dcache): Update.
4518         * dcache.h (struct dcache_deleter): New.
4519
4520 2019-05-08  Tom Tromey  <tom@tromey.com>
4521
4522         * symtab.c (struct symbol_cache): Add destructor and
4523         initializers.
4524         (symbol_cache_key): Move.  Change type.
4525         (make_symbol_cache, free_symbol_cache): Remove.
4526         (get_symbol_cache): Update.
4527         (symbol_cache_cleanup): Remove.
4528         (ALL_PSPACES, symbol_cache_flush)
4529         (maintenance_print_symbol_cache)
4530         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4531         Update.
4532
4533 2019-05-08  Tom Tromey  <tom@tromey.com>
4534
4535         * symtab.c (struct main_info): Add destructor and initializers.
4536         (main_progspace_key): Move.  Change type.
4537         (get_main_info): Update.
4538         (main_info_cleanup): Remove.
4539         (_initialize_symtab): Update.
4540
4541 2019-05-08  Tom Tromey  <tom@tromey.com>
4542
4543         * registry.h (DECLARE_REGISTRY): Define the _key class.
4544
4545 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * NEWS: Merge two 'New commands' sections.
4548
4549 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4550
4551         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4552         parameter and use Ada language definition instead.
4553         (ada_val_print_ptr): Remove unused language parameter.
4554         (ada_val_print_num): Remove language parameter and use Ada language
4555         definition instead.
4556         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4557         parameter.
4558         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4559         parameter and use Ada language definition instead.
4560         (ada_val_print_1): Update all ada_val_print_xxx calls.
4561         Remove language parameter.
4562         (ada_val_print): Update ada_val_print_1 call.
4563
4564 2019-05-08  Tom Tromey  <tromey@adacore.com>
4565
4566         * remote.c (remote_hw_watchpoint_limit)
4567         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4568         Now static.
4569
4570 2019-05-08  Tom Tromey  <tromey@adacore.com>
4571
4572         * maint.c (_initialize_maint_cmds): Move initialization code to
4573         remote.c.
4574         (watchdog, show_watchdog): Move to remote.c.
4575         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4576         "watchdog" static.
4577         (_initialize_remote): Move initialization code from maint.c.
4578         * defs.h (watchdog): Don't declare.
4579
4580 2019-05-08  Tom Tromey  <tromey@adacore.com>
4581
4582         * tui/tui-interp.c: Include main.h.
4583         * interps.c: Include main.h.
4584         * main.h (interpreter_p): Declare.
4585         * defs.h (interpreter_p): Don't declare.
4586
4587 2019-05-08  Tom Tromey  <tromey@adacore.com>
4588
4589         * dwarf2loc.c: Include dwarf2read.h.
4590         * defs.h (read_unsigned_leb128): Don't declare.
4591         * dwarf2read.h (read_unsigned_leb128): Declare.
4592
4593 2019-05-08  Tom Tromey  <tromey@adacore.com>
4594
4595         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4596         method.
4597
4598 2019-05-08  Tom Tromey  <tromey@adacore.com>
4599
4600         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4601         when no wrap column is set.
4602
4603 2019-05-08  Tom Tromey  <tromey@adacore.com>
4604
4605         * c-lang.c (c_get_string): Handle non-C-style arrays.
4606
4607 2019-05-08  Tom Tromey  <tromey@adacore.com>
4608
4609         * typeprint.c (print_offset_data::update): Print the bit offset,
4610         not the number of bits remaining.
4611
4612 2019-05-08  Tom Tromey  <tromey@adacore.com>
4613
4614         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4615         padding at end of comment.
4616
4617 2019-05-08  Tom Tromey  <tromey@adacore.com>
4618
4619         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4620         Compare main types.
4621
4622 2019-05-06  Tom Tromey  <tom@tromey.com>
4623
4624         * common/scoped_mmap.c: Include common-defs.h.
4625         * common/scoped_mmap.h: Don't include config.h.
4626
4627 2019-05-04  Tom Tromey  <tom@tromey.com>
4628
4629         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4630         (struct aarch64_call_info): Add initializers.
4631         <si>: Now a std::vector.
4632         (pass_on_stack, aarch64_push_dummy_call): Update.
4633
4634 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4635             Tom Tromey  <tom@tromey.com>
4636
4637         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4638         (ppc_threads): Now a std::vector.  Now static.
4639         (hwdebug_find_thread_points_by_tid)
4640         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4641         Update.
4642
4643 2019-05-04  Tom Tromey  <tom@tromey.com>
4644
4645         * arc-tdep.c (arc_tdesc_init): Return bool.
4646
4647 2019-05-04  Tom Tromey  <tom@tromey.com>
4648
4649         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4650         Use gdb_assert_not_reached.
4651
4652 2019-05-04  Tom Tromey  <tom@tromey.com>
4653
4654         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4655         "false".
4656
4657 2019-05-04  Tom Tromey  <tom@tromey.com>
4658
4659         * arc-tdep.c (arc_tdesc_init): Use bool.
4660
4661 2019-05-04  Tom Tromey  <tom@tromey.com>
4662
4663         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4664
4665 2019-05-04  Tom Tromey  <tom@tromey.com>
4666
4667         * cli/cli-cmds.c (valid_command_p): Return bool.
4668
4669 2019-05-04  Tom Tromey  <tom@tromey.com>
4670
4671         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4672         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4673
4674 2019-05-04  Raul Tambre  <raul@tambre.ee>
4675
4676         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4677         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4678         operator for comparison.
4679
4680 2019-05-04  Tom Tromey  <tom@tromey.com>
4681
4682         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4683         (lookup_partial_symbol, print_partial_symbols)
4684         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4685         (psymbol_compare): Update.
4686         (add_psymbol_to_bcache): Clear the entire psymbol.
4687         (maintenance_check_psymtabs): Update.
4688         * psympriv.h (struct partial_symbol): Don't derive from
4689         general_symbol_info.
4690         <obj_section, unrelocated_address, address,
4691         set_unrelocated_address>: Update.
4692         <ginfo>: New member.
4693         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4694         (debug_names::write_psymbols): Update.
4695
4696 2019-05-04  Tom de Vries  <tdevries@suse.de>
4697
4698         * contrib/cc-with-tweaks.sh: Support -n arg.
4699
4700 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4701
4702         * corelow.c (core_target::detach): Ensure frame cache and
4703         register caches are cleared.
4704         inferior.c (exit_inferior_1): Likewise.
4705
4706 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4707             Tom Tromey  <tom@tromey.com>
4708
4709         * dictionary.c (collate_pending_symbols_by_language): Remove
4710         "struct" from foreach.
4711         * symtab.c (lookup_global_symbol_from_objfile)
4712         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4713         foreach.
4714         * ser-tcp.c (net_open): Remove "struct" from foreach.
4715         * objfiles.c (objfile_relocate, objfile_rebase)
4716         (objfile_has_symbols): Remove "struct" from foreach.
4717         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4718         from foreach.
4719         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4720         foreach.
4721         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4722         "struct" from foreach.
4723         * ada-lang.c (create_excep_cond_exprs)
4724         (ada_exception_catchpoint_cond_string): Remove "struct" from
4725         foreach.
4726
4727 2019-05-03  Tom Tromey  <tromey@adacore.com>
4728
4729         * ada-exp.y (convert_char_literal): Check suffix of each
4730         enumerator.
4731
4732 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4733
4734         PR ada/21406:
4735         * ada-exp.y (yywrap): Don't define.
4736         * ada-lex.l (%option): Add noyywrap
4737         (yywrap): Remove.
4738
4739 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4740
4741         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4742         _WIN32_WINNT to the XP level, unless already defined to a higher
4743         level.
4744
4745         * unittests/parse-connection-spec-selftests.c:
4746         * ser-tcp.c:
4747         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4748         override.
4749
4750         * symfile.c (find_separate_debug_file): Remove colon from the
4751         drive spec of DOS/Windows file names of the target, so that the
4752         file name produced from DEBUGDIR and the target's directory will
4753         be valid on DOS/Windows systems.
4754
4755 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4756
4757         * rust-lang.c (val_print_struct): Handle printing structures
4758         containing strings.
4759
4760 2019-05-02  Tom Tromey  <tromey@adacore.com>
4761
4762         * valarith.c (_initialize_valarith): Remove.
4763
4764 2019-05-01  Tom Tromey  <tromey@adacore.com>
4765
4766         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4767         bitfields.
4768
4769 2019-05-01  Tom Tromey  <tromey@adacore.com>
4770
4771         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4772         for big-endian copies.
4773
4774 2019-04-30  Ali Tamur  <tamur@google.com>
4775         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4776         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4777         (read_3_bytes): New function.
4778
4779 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4780
4781         * windows-nat.c (main_thread_id): Delete.
4782         (handle_output_debug_string): Replace main_thread_id by
4783         current_event.dwThreadId.
4784         (fake_create_process): Likewise.
4785         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4786         Do not set main_thread_id.
4787         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4788         current_event.dwThreadId.
4789         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4790
4791 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4792
4793         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4794         Use current_event.dwThreadId instead of main_thread_id.
4795
4796 2019-04-30  Tom Tromey  <tromey@adacore.com>
4797
4798         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4799         (create_excep_cond_exprs): Iterate over program spaces.
4800         (ada_exception_catchpoint_cond_string): Examine all minimal
4801         symbols for exception types.
4802
4803 2019-04-30  Tom Tromey  <tromey@adacore.com>
4804
4805         PR c++/24470:
4806         * dwarf2read.c (process_structure_scope): Handle case where type
4807         has template parameters but no symbol was created.
4808
4809 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4810             Chris January  <chris.january@arm.com>
4811
4812         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4813         qualifier.
4814         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4815
4816 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4817
4818         * f-typeprint.c (f_print_type): Update rules for printing
4819         whitespace.
4820         (f_type_print_varspec_suffix): Likewise.
4821
4822 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4823             Chris January  <chris.january@arm.com>
4824
4825         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4826         function arguments.
4827
4828 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * f-lang.c (build_fortran_types): Change name of void type to
4831         lower case.
4832         * f-typeprint.c (f_type_print_base): Print the name of the void
4833         type, rather than a fixed string.
4834         * f-valprint.c (f_decorations): Use lower case void string.
4835
4836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4837             Chris January  <chris.january@arm.com>
4838
4839         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4840         types for Fortran.
4841
4842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4843             Chris January  <chris.january@arm.com>
4844             David Lecomber  <david.lecomber@arm.com>
4845
4846         * f-exp.y (BINOP_INTRINSIC): New token.
4847         (exp): New parser rule handling BINOP_INTRINSIC.
4848         (f77_keywords): Add new builtin procedures.
4849         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4850         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4851         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4852         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4853         (print_unop_subexp_f): New function.
4854         (print_binop_subexp_f): New function.
4855         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4856         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4857         (dump_subexp_body_f): Likewise.
4858         (operator_check_f): Likewise.
4859         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4860         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4861
4862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4865         UNOP_KIND.
4866         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4867         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4868         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4869         (operator_length_f): New fuction.
4870         (print_subexp_f): New function.
4871         (op_name_f): New function.
4872         (dump_subexp_body_f): New function.
4873         (operator_check_f): New function.
4874         (exp_descriptor_f): Replace standard expression handling functions
4875         with new functions.
4876         * gdb/fortran-operator.def: New file.
4877         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4878         * gdb/std-operator.def: Remove UNOP_KIND.
4879
4880 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * std-operator.def: Remove unbalanced, stray double quote
4883         character.
4884
4885 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4886             Chris January  <chris.january@arm.com>
4887             Daniel Everett  <daniel.everett@arm.com>
4888             Nick Forrington  <nick.forrington@arm.com>
4889             Richard Bunt  <richard.bunt@arm.com>
4890
4891         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4892         of depth when printing anonymous structs or unions.
4893         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4894         Don't print either the top-level value, or the children if the
4895         max-depth is exceeded.
4896         (ppscm_print_children): When printing the key of a map, allow one
4897         extra level of depth.
4898         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4899         print either the top-level value, or the children if the max-depth
4900         is exceeded.
4901         (print_children): When printing the key of a map, allow one extra
4902         level of depth.
4903         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4904         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4905         (user_print_options): Initialise max_depth field.
4906         (val_print_scalar_or_string_type_p): New function.
4907         (val_print): Check to see if the max depth has been reached.
4908         (val_print_check_max_depth): Define new function.
4909         (show_print_max_depth): New function.
4910         (_initialize_valprint): Add 'print max-depth' option.
4911         * valprint.h (struct value_print_options) <max_depth>: New field.
4912         (val_print_check_max_depth): Declare new function.
4913         * NEWS: Document new feature.
4914
4915 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * ada-lang.c (ada_language_defn): Initialise new field.
4918         * c-lang.c (c_is_string_type_p): New function.
4919         (c_language_defn): Initialise new field.
4920         (cplus_language_defn): Initialise new field.
4921         (asm_language_defn): Initialise new field.
4922         (minimal_language_defn): Initialise new field.
4923         * c-lang.h (c_is_string_type_p): Declare new function.
4924         * d-lang.c (d_language_defn): Initialise new field.
4925         * f-lang.c (f_is_string_type_p): New function.
4926         (f_language_defn): Initialise new field.
4927         * go-lang.c (go_is_string_type_p): New function.
4928         (go_language_defn): Initialise new field.
4929         * language.c (default_is_string_type_p): New function.
4930         (unknown_language_defn): Initialise new field.
4931         (auto_language_defn): Initialise new field.
4932         * language.h (struct language_defn) <la_is_string_type_p>: New
4933         member variable.
4934         (default_is_string_type_p): Declare new function.
4935         * m2-lang.c (m2_language_defn): Initialise new field.
4936         * objc-lang.c (objc_language_defn): Initialise new field.
4937         * opencl-lang.c (opencl_language_defn): Initialise new field.
4938         * p-lang.c (pascal_is_string_type_p): New function.
4939         (pascal_language_defn): Initialise new field.
4940         * rust-lang.c (rust_is_string_type_p): New function.
4941         (rust_language_defn): Initialise new field.
4942
4943 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4946         New field.
4947         * ada-lang.c (ada_language_defn): Initialise new field.
4948         * c-lang.c (c_language_defn): Likewise.
4949         (cplus_language_defn): Likewise.
4950         (asm_language_defn): Likewise.
4951         (minimal_language_defn): Likewise.
4952         * d-lang.c (d_language_defn): Likewise.
4953         * f-lang.c (f_language_defn): Likewise.
4954         * go-lang.c (go_language_defn): Likewise.
4955         * language.c (unknown_language_defn): Likewise.
4956         (auto_language_defn): Likewise.
4957         * m2-lang.c (m2_language_defn): Likewise.
4958         * objc-lang.c (objc_language_defn): Likewise.
4959         * opencl-lang.c (opencl_language_defn): Likewise.
4960         * p-lang.c (pascal_language_defn): Likewise.
4961         * rust-lang.c (rust_language_defn): Likewise.
4962
4963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * ada-lang.c (ada_is_character_type): Change return type to bool.
4966         (ada_is_string_type): Likewise.
4967         * ada-lang.h (ada_is_character_type): Update declaration
4968         (ada_is_string_type): Likewise.
4969
4970 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4971
4972         Support style in 'frame|thread apply'
4973
4974         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4975         * record.c (record_start, record_stop): Update callers of
4976         execute_command_to_string with false.
4977         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4978         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4979         methods.
4980         (class string_file): New constructor with term_out parameter.
4981         Override methods term_out and can_emit_style_escape.  New member
4982         term_out.
4983         (class stdio_file): Override can_emit_style_escape.
4984         (class tee_file): Override term_out and can_emit_style_escape.
4985         * utils.h (can_emit_style_escape): Remove.
4986         * utils.c (can_emit_style_escape): Likewise.
4987         Update all callers of can_emit_style_escape (SOMESTREAM) to
4988         SOMESTREAM->can_emit_style_escape.
4989         * source-cache.c (source_cache::get_source_lines): Likewise.
4990         * stack.c (frame_apply_command_count): Call execute_command_to_string
4991         passing the term_out characteristic of the current gdb_stdout.
4992         * thread.c (thr_try_catch_cmd): Likewise.
4993         * top.c (execute_command_to_string): pass term_out parameter
4994         to construct the string_file for the command output.
4995         * ui-file.c (term_cli_styling): New function (most code moved
4996         from utils.c can_emit_style_escape).
4997         (string_file::string_file, string_file::can_emit_style_escape,
4998         stdio_file::can_emit_style_escape, tee_file::term_out,
4999         tee_file::can_emit_style_escape): New functions.
5000
5001 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5002
5003         * NEWS: Mention the new set|show may-call-functions.
5004         * infcall.c (may_call_functions_p): New variable.
5005         (show_may_call_functions_p): New function.
5006         (call_function_by_hand_dummy): Throws an error if not
5007         may-call-functions.
5008         (_initialize_infcall): Call add_setshow_boolean_cmd for
5009         may-call-functions.
5010
5011 2019-04-25  Keith Seitz  <keiths@redhat.com>
5012
5013         PR c++/24367
5014         * cp-support.c (inspect_type): Don't attempt substitutions
5015         of symbol with the same name.
5016
5017 2019-04-25  Tom Tromey  <tromey@adacore.com>
5018
5019         PR gdb/24475:
5020         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5021         static.
5022
5023 2019-04-25  Tom Tromey  <tromey@adacore.com>
5024
5025         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5026         rvalue reference.
5027         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5028         (gdb_xml_parser::parse): Use std::move.
5029         * python/python-internal.h (gdbpy_convert_exception): Take a const
5030         reference.
5031         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5032         std::move.
5033         * python/py-utils.c (gdbpy_convert_exception): Take a const
5034         reference.
5035         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5036         Use std::move.
5037         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5038         Use std::move.
5039         * mi/mi-main.c (mi_print_exception): Take a const reference.
5040         * main.c (handle_command_errors): Take a const reference.
5041         * linespec.c (parse_linespec): Use std::move.
5042         * infcall.c (run_inferior_call): Use std::move.
5043         (call_function_by_hand_dummy): Use std::move.
5044         * exec.c (try_open_exec_file): Use std::move.
5045         * exceptions.h (exception_print, exception_fprintf)
5046         (exception_print_same): Update.
5047         * exceptions.c (print_exception, exception_print)
5048         (exception_fprintf, exception_print_same): Change parameters to
5049         const reference.
5050         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5051         * common/new-op.c: Use std::move.
5052         * common/common-exceptions.h (struct gdb_exception): Add move
5053         constructor.
5054         (struct gdb_exception_error, struct gdb_exception_quit, struct
5055         gdb_quit_bad_alloc): Change constructor to move constructor.
5056         (throw_exception): Change parameter to rvalue reference.
5057         * common/common-exceptions.c (throw_exception): Take rvalue
5058         reference.
5059         * cli/cli-interp.c (safe_execute_command): Use std::move.
5060         * breakpoint.c (insert_bp_location, location_to_sals): Use
5061         std::move.
5062
5063 2019-04-25  Tom Tromey  <tromey@adacore.com>
5064
5065         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5066         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5067         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5068         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5069         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5070         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5071         guile/scm-value.c: Use unpack.
5072         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5073         gdbscm_gdb_exception.
5074         (gdbscm_throw_gdb_exception): Likewise.
5075         (struct gdbscm_gdb_exception): New.
5076         (unpack): New function.
5077         (gdbscm_wrap): Use unpack.
5078
5079 2019-04-25  Tom Tromey  <tromey@adacore.com>
5080
5081         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5082         (gdb_rl_callback_handler): Use std::move.
5083         * common/common-exceptions.h (struct gdb_exception): Add move
5084         assignment operator.
5085         (throw_exception_sjlj): Change "exception" to const reference.
5086         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5087         (throw_exception_sjlj): Change "exception" to const reference.
5088
5089 2019-04-25  Tom Tromey  <tromey@adacore.com>
5090
5091         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5092         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5093         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5094         Update.
5095         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5096         Update.
5097         * mi/mi-interp.c (mi_interp::exec): Update.
5098         * linespec.c (parse_linespec): Update.
5099         * infcall.c (run_inferior_call): Update.
5100         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5101         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5102         (gdbscm_lookup_global_symbol): Update.
5103         * guile/scm-param.c (gdbscm_parameter_value): Update.
5104         * guile/scm-frame.c (gdbscm_frame_read_register)
5105         (gdbscm_frame_read_var): Update.
5106         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5107         * exec.c (try_open_exec_file): Update.
5108         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5109         (gdb_rl_callback_handler): Update.
5110         * common/common-exceptions.h (exception_none): Don't declare.
5111         * common/common-exceptions.c (exception_none): Don't define.
5112         (struct catcher) <exception>: Update.
5113         * cli/cli-interp.c (safe_execute_command): Update.
5114         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5115
5116 2019-04-25  Ali Tamur  <tamur@google.com>
5117
5118         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5119         (read_attribute_value): Likewise.
5120         (dwarf2_read_addr_index): Update comment.
5121         (read_str_index): Add DW_FORM_strx.
5122         (dwarf2_string_attr): Likewise.
5123         (dwarf2_const_value_attr): Likewise.
5124         (dump_die_shallow): Likewise.
5125         (dwarf2_fetch_constant_bytes): Likewise.
5126         (skip_form_bytes): Likewise.
5127         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5128
5129 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5130
5131         PR corefiles/11608
5132         PR corefiles/18187
5133         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5134         OFFSET.  Verify if current mapping contains an ELF header.
5135         (linux_find_memory_regions_full): Adjust call to
5136         dump_mapping_p.
5137
5138 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5139             Kang Li <kanglictf@gmail.com>
5140
5141         PR gdb/21600
5142
5143         * dwarf2-frame.c (read_initial_length): Be consistent about using
5144         unsigned representation of length.
5145         (decode_frame_entry_1): Likewise.  Check for wraparound of
5146         end pointer as well as buffer overflow.
5147
5148 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5149
5150         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5151         "vq".
5152
5153 2019-04-24  Tom Tromey  <tromey@adacore.com>
5154
5155         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5156
5157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * s12z-tdep.c (s12z_unwind_pc): Delete.
5160         (s12z_unwind_sp): Delete.
5161         (s12z_gdbarch_init): Don't register deleted functions with
5162         gdbarch.
5163
5164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * rl78-tdep.c (rl78_unwind_sp): Delete.
5167         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5168
5169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5172         (xstormy16_unwind_pc): Delete.
5173         (xstormy16_dummy_id): Delete.
5174         (xstormy16_gdbarch_init): Don't register deleted functions with
5175         gdbarch.
5176
5177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * vax-tdep.c (vax_unwind_pc): Delete.
5180         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5181
5182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5183
5184         * v850-tdep.c (v850_unwind_sp): Delete.
5185         (v850_unwind_pc): Delete.
5186         (v850_dummy_id): Delete.
5187         (v850_gdbarch_init): Don't register deleted functions with
5188         gdbarch.
5189
5190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5191
5192         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5193         (tilegx_unwind_pc): Delete.
5194         (tilegx_unwind_dummy_id): Delete.
5195         (tilegx_gdbarch_init): Don't register deleted functions with
5196         gdbarch.
5197
5198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5199
5200         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5201         (tic6x_dummy_id): Delete.
5202         (tic6x_gdbarch_init): Don't register deleted functions with
5203         gdbarch.
5204
5205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * sparc-tdep.c (sparc_unwind_pc): Delete.
5208         (sparc32_gdbarch_init): Don't register deleted function with
5209         gdbarch.
5210
5211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5212
5213         * sh-tdep.c (sh_unwind_sp): Delete.
5214         (sh_unwind_pc): Delete.
5215         (sh_dummy_id): Delete.
5216         (sh_gdbarch_init): Don't register deleted functions with
5217         gdbarch.
5218
5219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * score-tdep.c (score_unwind_sp): Delete.
5222         (score_unwind_pc): Delete.
5223         (score_dummy_id): Delete.
5224         (score_gdbarch_init): Don't register deleted functions with
5225         gdbarch.
5226
5227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5228
5229         * rx-tdep.c (rx_unwind_pc): Delete.
5230         (rx_unwind_sp): Delete.
5231         (rx_dummy_id): Delete.
5232         (rx_gdbarch_init): Don't register deleted functions with
5233         gdbarch.  Update comment.
5234
5235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5236
5237         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5238         (rs6000_dummy_id): Delete.
5239         (rs6000_gdbarch_init): Don't register deleted functions with
5240         gdbarch.
5241
5242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5243
5244         * or1k-tdep.c (or1k_dummy_id): Delete.
5245         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5246
5247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5248
5249         * nios2-tdep.c (nios2_dummy_id): Delete.
5250         (nios2_unwind_sp): Delete.
5251         (nios2_gdbarch_init): Don't register deleted functions with
5252         gdbarch.
5253
5254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5255
5256         * nds32-tdep.c (nds32_dummy_id): Delete.
5257         (nds32_unwind_pc): Delete.
5258         (nds32_unwind_sp): Delete.
5259         (nds32_gdbarch_init): Don't register deleted functions with
5260         gdbarch.
5261
5262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5263
5264         * msp430-tdep.c (msp430_unwind_pc): Delete.
5265         (msp430_unwind_sp): Delete.
5266         (msp430_dummy_id): Delete.
5267         (msp430_gdbarch_init): Don't register deleted functions with
5268         gdbarch.
5269
5270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5271
5272         * moxie-tdep.c (moxie_unwind_sp): Delete.
5273         (moxie_unwind_pc): Delete.
5274         (moxie_dummy_id): Delete.
5275         (moxie_gdbarch_init): Don't register deleted functions with
5276         gdbarch.
5277
5278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5279
5280         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5281         (mn10300_unwind_pc): Delete.
5282         (mn10300_unwind_sp): Delete.
5283         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5284         mn10300_unwind_sp.
5285         (mn10300_frame_unwind_init): Don't register deleted functions with
5286         gdbarch.
5287
5288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5289
5290         * mep-tdep.c (mep_unwind_pc): Delete.
5291         (mep_unwind_sp): Delete.
5292         (mep_dummy_id): Delete.
5293         (mep_gdbarch_init): Don't register deleted functions with
5294         gdbarch.
5295
5296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5297
5298         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5299         (m68hc11_unwind_sp): Delete.
5300         (m68hc11_gdbarch_init): Don't register deleted functions with
5301         gdbarch.
5302
5303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5304
5305         * m32r-tdep.c (m32r_unwind_sp): Delete.
5306         (m32r_unwind_pc): Delete.
5307         (m32r_dummy_id): Delete.
5308         (m32r_gdbarch_init): Don't register deleted functions with
5309         gdbarch.
5310
5311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * m32c-tdep.c (m32c_unwind_pc): Delete.
5314         (m32c_unwind_sp): Delete.
5315         (m32c_dummy_id): Delete.
5316         (m32c_gdbarch_init): Don't register deleted functions with
5317         gdbarch.
5318
5319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5320
5321         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5322         (lm32_unwind_pc): Delete.
5323         (lm32_dummy_id): Delete.
5324         (lm32_gdbarch_init): Don't register deleted functions with
5325         gdbarch.
5326
5327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5328
5329         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5330         (iq2000_unwind_pc): Delete.
5331         (iq2000_dummy_id): Delete.
5332         (iq2000_gdbarch_init): Don't register deleted functions with
5333         gdbarch.
5334
5335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * nds32-tdep.c (nds32_type_align): Delete.
5338         (nds32_push_dummy_call): Use type_align instead.
5339
5340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5341
5342         * arm-tdep.c (arm_type_align): Only handle vector override case.
5343         (arm_push_dummy_call): Use type_align.
5344         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5345
5346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5347
5348         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5349         case.
5350         (pass_on_stack): Use type_align.
5351         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5352         function.
5353
5354 2019-04-23  Tom Tromey  <tromey@adacore.com>
5355
5356         * dwarf2read.c (line_header::file_name_at): Remove unused
5357         overload.
5358
5359 2019-04-23  Tom de Vries  <tdevries@suse.de>
5360
5361         PR gdb/24438
5362         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5363         invocation.
5364
5365
5366 2019-03-27  Ali Tamur  <tamur@google.com>
5367
5368         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5369         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5370         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5371         (dwarf_expr_context::get_addr_index): Likewise
5372         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5373         (symbol_needs_eval_context::get_addr_index): Likewise
5374         (disassemble_dwarf_expression): Add DW_OP_addrx
5375         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5376         (read_cutu_die_from_dwo): Update comment
5377         (skip_one_die): Add DW_FORM_addrx
5378         (read_attribute_value): Likewise
5379         (var_decode_location): Add DW_OP_addrx
5380         (dwarf2_const_value_attr): Add DW_FORM_addrx
5381         (dump_die_shallow): Likewise
5382         (dwarf2_fetch_constant_bytes): Likewise
5383         (decode_locdesc): Add DW_OP_addrx
5384         (skip_form_bytes): Add DW_FORM_addrx
5385
5386 2019-04-22  Ali Tamur  <tamur@google.com>
5387
5388         * MAINTAINERS (Write After Approval): Add self.
5389
5390 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5391
5392         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5393         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5394         (open_symbol_file_object): Likewise.
5395         (svr4_default_sos): Add info parameter.
5396         (svr4_read_so_list): Likewise.
5397         (svr4_current_sos_direct): Adjust functions calls to pass down
5398         info.
5399         (svr4_current_sos_1): Add info parameter.
5400         (svr4_current_sos): Call get_svr4_info, pass info down to
5401         svr4_current_sos_1.
5402         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5403         get_svr4_info.
5404         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5405         get_svr4_info.
5406         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5407         to get_svr4_info.
5408         (probes_table_remove_objfile_probes): Likewise.
5409         (register_solib_event_probe): Add info parameter.
5410         (solist_update_incremental): Pass info parameter down to
5411         svr4_read_so_list.
5412         (disable_probes_interface): Add info parameter.
5413         (svr4_handle_solib_event): Pass current_program_space to
5414         get_svr4_info.  Adjust disable_probes_interface cleanup.
5415         (svr4_create_probe_breakpoints): Add info parameter, pass it
5416         down to register_solib_event_probe.
5417         (svr4_create_solib_event_breakpoints): Add info parameter,
5418         pass it down to svr4_create_probe_breakpoints.
5419         (enable_break): Pass info down to
5420         svr4_create_solib_event_breakpoints.
5421         (svr4_solib_create_inferior_hook): Pass current_program_space to
5422         get_svr4_info.
5423         (svr4_clear_solib): Likewise.
5424
5425 2019-04-22  Pedro Alves  <palves@redhat.com>
5426
5427         * solib-svr4.c (svr4_free_objfile_observer): New.
5428         (probe_and_action::objfile): New field.
5429         (probes_table_htab_remove_objfile_probes)
5430         (probes_table_remove_objfile_probes): New functions.
5431         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5432         in the new probe_and_action.  Don't store the probe in 'lookup'.
5433         (svr4_create_probe_breakpoints): Pass objfile to
5434         register_solib_event_probe.
5435         (_initialize_svr4_solib): Register a free_objfile observer.
5436
5437 2019-04-19  Tom Tromey  <tom@tromey.com>
5438
5439         * common/queue.h: Remove.
5440
5441 2019-04-19  Tom Tromey  <tom@tromey.com>
5442
5443         * event-loop.c: Don't include "common/queue.h".
5444
5445 2019-04-19  Tom Tromey  <tom@tromey.com>
5446
5447         * remote.c (remote_target): Use delete.
5448         * remote-notif.h: Include <list>, not "common/queue.h".
5449         (notif_client_p): Remove typedef.
5450         (remote_notif_state): Add constructor, destructor, initializer.
5451         <notif_queue>: Now a std::list.
5452         (remote_notif_state_xfree): Don't declare.
5453         * remote-notif.c (remote_notif_process, handle_notification)
5454         (remote_notif_state_allocate): Update.
5455         (~remote_notif_state): Rename from remote_notif_state_xfree.
5456
5457 2019-04-19  Tom Tromey  <tom@tromey.com>
5458
5459         * symfile.c (reread_symbols): Update.
5460         * objfiles.c (objfile_register_static_link)
5461         (objfile_lookup_static_link): Update
5462         (~objfile) Don't delete static_links.
5463         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5464
5465 2019-04-19  Tom Tromey  <tom@tromey.com>
5466
5467         * type-stack.h (struct type_stack) <insert>: Constify string.
5468         * type-stack.c (type_stack::insert): Constify string.
5469         * gdbtypes.h (lookup_template_type): Update.
5470         (address_space_name_to_int): Update.
5471         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5472         const.
5473         (lookup_template_type): Make name const.
5474         * c-exp.y: Update rules.
5475         (lex_one_token, classify_name, classify_inner_name)
5476         (c_print_token): Update.
5477         * p-exp.y: Update rules.
5478         (yylex): Update.
5479         * f-exp.y: Update rules.
5480         (yylex): Update.
5481         * d-exp.y: Update rules.
5482         (lex_one_token, classify_name, classify_inner_name): Update.
5483         * parse.c (write_dollar_variable, copy_name): Return std::string.
5484         * parser-defs.h (copy_name): Change return type.
5485         * m2-exp.y: Update rules.
5486         (yylex): Update.
5487         * go-exp.y (lex_one_token): Update.
5488         Update rules.
5489         (classify_unsafe_function, classify_packaged_name)
5490         (classify_name, yylex): Update.
5491
5492 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5493
5494         * configure.ac: add --enable-source-highlight switch.
5495         * configure: Regenerate.
5496         * top.c (print_gdb_version): plumb --enable-source-highlight
5497         status to "show configuration".
5498
5499 2019-04-19  Tom Tromey  <tromey@adacore.com>
5500
5501         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5502         Check ADA_TYPE_P.
5503         (empty_record, ada_template_to_fixed_record_type_1)
5504         (template_to_static_fixed_type)
5505         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5506         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5507         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5508         macros.
5509
5510 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5511
5512         PR symtab/24423:
5513         * source.c (print_source_lines_base): Advance "iter" when a
5514         control character is seen.
5515
5516 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5517
5518         * inferior.h (struct infcall_suspend_state_deleter):
5519         Catch exception in destructor to avoid crash.
5520
5521 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5522
5523         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5524         close to the add_com "shell".
5525
5526 2019-04-18  Tom Tromey  <tromey@adacore.com>
5527
5528         * process-stratum-target.h (class process_stratum_target)
5529         <stratum>: Add "final".
5530
5531 2019-04-17  Tom Tromey  <tromey@adacore.com>
5532
5533         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5534         against nullptr before use.
5535
5536 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5537
5538         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5539
5540 2019-04-17  Jim Wilson  <jimw@sifive.com>
5541             Andrew Burgess  <andrew.burgess@embecosm.com>
5542
5543         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5544         code read might fail, assume 4-byte breakpoint in that case.
5545
5546 2019-04-15  Leszek Swirski  <leszeks@google.com>
5547
5548         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5549         rather than a hand-rolled POD check when checking for forced MEMORY
5550         classification.
5551
5552 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5553
5554         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5555         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5556         function.
5557         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5558         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5559         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5560         declaration.
5561
5562 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5563
5564         * aarch64-linux-nat.c
5565         (aarch64_linux_nat_target::thread_architecture): Add override.
5566         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5567         each VQ.
5568
5569 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5570
5571         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5572
5573 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5574
5575         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5576         target types of size 96-bits, add some additional comments, and
5577         check that the builtin type we found was the correct size.
5578
5579 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5580
5581         * utils.c (prompt_for_continue): Don't restore the styling at the
5582         end, as applied_style has the wrong value.  This fixes styling in
5583         long lists of file names that are interrupted by the "Continue?"
5584         prompt.
5585
5586 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5589         * c-lang.c (c_language_defn): Likewise.
5590         (cplus_language_defn): Likewise.
5591         (asm_language_defn): Likewise.
5592         (minimal_language_defn): Likewise.
5593         * d-lang.c (d_language_defn): Likewise.
5594         * f-lang.c (f_language_defn): Likewise.
5595         * go-lang.c (go_language_defn): Likewise.
5596         * language.c (unknown_language_defn): Likewise.
5597         (auto_language_defn): Likewise.
5598         * language.h (struct language_defn): Remove la_magic field.
5599         (LANG_MAGIC): Delete.
5600         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5601         * objc-lang.c (objc_language_defn): Likewise.
5602         * opencl-lang.c (opencl_language_defn): Likewise.
5603         * p-lang.c (pascal_language_defn): Likewise.
5604         * rust-lang.c (rust_language_defn): Likewise.
5605
5606 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5607
5608         * riscv-tdep.c (riscv_type_align): New function.
5609         (riscv_type_alignment): Delete.
5610         (riscv_arg_location): Use 'type_align'.
5611         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5612
5613 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * gdbtypes.c (type_align): A struct with no non-static fields also
5616         has alignment of 1.
5617
5618 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5619
5620         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5621         component to 0.
5622         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5623         member.
5624         (riscv_struct_info::analyse): New implementation using new
5625         analyse_inner member function.
5626         (riscv_struct_info::field_offset): New member function.
5627         (riscv_struct_info::m_offsets): New member variable.
5628         (riscv_struct_info::analyse_inner): New private member function,
5629         takes the old implementation of riscv_struct_info::analyse but
5630         extended to track field offsets.
5631         (riscv_call_arg_struct): Update the struct folding special cases
5632         to handle cases where empty C++ structs, which are non-zero
5633         length, are found.
5634         (riscv_arg_location): Initialise the length of each location, a
5635         non-zero length now indicates the location is in use.
5636         (riscv_push_dummy_call): Allow for the first location having a
5637         non-zero offset when setting up arguments.
5638         (riscv_return_value): Likewise, but for return values.
5639
5640 2019-04-11  Tom Tromey  <tromey@adacore.com>
5641
5642         * utils.c (internal_vproblem): Make "msg" const.
5643
5644 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5645
5646         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5647         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5648         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5649         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5650
5651 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5652
5653         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5654         function.
5655         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5656         of amd64_collect_native_gregset.
5657         (amd64_linux_nat_target::store_registers): Likewise.
5658
5659 2019-04-10  Tom Tromey  <tom@tromey.com>
5660
5661         * symtab.c (lookup_global_symbol_from_objfile)
5662         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5663         * objfiles.h (class separate_debug_iterator): New.
5664         (class separate_debug_range): New.
5665         (struct objfile) <separate_debug_objfiles>: New method.
5666         (objfile_separate_debug_iterate): Don't declare.
5667         * objfiles.c (separate_debug_iterator::operator++): Rename from
5668         objfile_separate_debug_iterate.
5669         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5670         iterator.
5671         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5672         iterator.
5673
5674 2019-04-10  Tom Tromey  <tom@tromey.com>
5675
5676         * symfile.c (reread_symbols): Remove old comment.
5677         * objfiles.c (free_all_objfiles): Fix a typo.
5678
5679 2019-04-10  Tom Tromey  <tom@tromey.com>
5680
5681         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5682         * minsyms.c (lookup_minimal_symbol): Use foreach.
5683         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5684         (lookup_minimal_symbol_solib_trampoline): Likewise.
5685         * symfile.c (reread_symbols): Use foreach.
5686
5687 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5688             Tom Tromey  <tromey@adacore.com>
5689
5690         PR rust/24414:
5691         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5692         (rust_lex_int_test): Change "value" to be LONGEST.
5693         (rust_lex_tests): Add test for long integer literal.
5694
5695 2019-04-09  Tom Tromey  <tromey@adacore.com>
5696
5697         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5698         to bool.
5699         (extended_remote_target::attach): Update.
5700         (remote_target::remote_notice_new_inferior): Update.
5701         (remote_target::add_current_inferior_and_thread): Update.
5702         * inferior.c (exit_inferior_1): Use "false".
5703         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5704
5705 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5706
5707         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5708         the "start" command.
5709
5710 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5711
5712         * python/py-inferior.c (infpy_thread_from_thread_handle):
5713         Adjust comments to reflect renaming of thread_from_thread_handle
5714         to thread_from_handle.  Adjust keywords.  Fix type error message.
5715         (inferior_object_methods): Add thread_from_handle.  Retain
5716         thread_from_thread_handle, but mark it as deprecated.
5717
5718 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5719
5720         * gdbthread.h (find_thread_by_handle): Revise declaration.
5721         * thread.c (find_thread_by_handle): Likewise.  Adjust
5722         implementation too.
5723         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5724         support for buffer objects as handles.
5725
5726 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5727
5728         * python/py-infthread.c (thpy_thread_handle): New function.
5729         (thread_object_methods): Register thpy_thread_handle.
5730
5731 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5732
5733         * gdbthread.h (thread_to_thread_handle): Declare.
5734         * thread.c (gdbtypes.h): Include.
5735         (thread_to_thread_handle): New function.
5736
5737         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5738         (target_thread_info_to_thread_handle): Declare.
5739         * target.c (target_thread_info_to_thread_handle): New function.
5740         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5741         * target-delegates.c: Regenerate.
5742
5743         * linux-thread-db.c (class thread_db_target): Add method
5744         thread_info_to_thread_handle.
5745         (thread_db_target::thread_info_to_thread_handle): Define.
5746         * remote.c (class remote_target): Add new method
5747         thread_info_to_thread_handle.
5748         (remote_target::thread_info_to_thread_handle): Define.
5749
5750 2019-04-08  Pedro Alves  <palves@redhat.com>
5751
5752         * common/common-exceptions.c (throw_exception): Don't create
5753         named object to throw; throw directly.
5754         (throw_it): Likewise.  Don't initialize gdb_exception::message
5755         here, with new; pass FMT and AP to the ctor instead.
5756         * common/common-exceptions.h: Include <string>.
5757         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5758         const char *, va_list)): New ctor.  Use std::make_shared.
5759         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5760         errors)): Delete.
5761         (gdb_exception_error::gdb_exception_error(enum errors, const char
5762         *, va_list)): New.
5763         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5764         Add assertion.
5765         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5766         errors)): Delete.
5767         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5768         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5769         Add assertion.
5770
5771 2019-04-08  Tom Tromey  <tom@tromey.com>
5772
5773         * valops.c (value_rtti_indirect_type): Replace throw_exception
5774         with throw.
5775         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5776         with throw.
5777         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5778         throw.
5779         * target.c (target_translate_tls_address): Replace throw_exception
5780         with throw.
5781         * stack.c (frame_apply_command_count): Replace throw_exception
5782         with throw.
5783         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5784         throw.
5785         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5786         with throw.
5787         * rs6000-tdep.c (rs6000_frame_cache)
5788         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5789         * remote.c: Replace throw_exception with throw.
5790         * record-full.c (record_full_message, record_full_wait_1)
5791         (record_full_restore): Replace throw_exception with throw.
5792         * record-btrace.c:
5793         (get_thread_current_frame_id, record_btrace_start_replaying)
5794         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5795         (cmd_record_btrace_start): Replace throw_exception with throw.
5796         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5797         throw.
5798         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5799         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5800         * linespec.c:
5801         (find_linespec_symbols): Replace throw_exception with throw.
5802         * infrun.c (displaced_step_prepare, resume): Replace
5803         throw_exception with throw.
5804         * infcmd.c (post_create_inferior): Replace throw_exception with
5805         throw.
5806         * inf-loop.c (inferior_event_handler): Replace throw_exception
5807         with throw.
5808         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5809         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5810         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5811         (get_prev_frame_always, get_frame_pc_if_available)
5812         (get_frame_address_in_block_if_available, get_frame_language):
5813         Replace throw_exception with throw.
5814         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5815         throw_exception with throw.
5816         * eval.c (fetch_subexp_value, evaluate_var_value)
5817         (evaluate_funcall, evaluate_subexp_standard): Replace
5818         throw_exception with throw.
5819         * dwarf2loc.c (call_site_find_chain)
5820         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5821         Replace throw_exception with throw.
5822         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5823         with throw.
5824         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5825         throw.
5826         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5827         * completer.c (complete_line_internal): Replace throw_exception
5828         with throw.
5829         * compile/compile-object-run.c (compile_object_run): Replace
5830         throw_exception with throw.
5831         * cli/cli-script.c (process_next_line): Replace throw_exception
5832         with throw.
5833         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5834         (btrace_enable, btrace_maint_update_pt_packets): Replace
5835         throw_exception with throw.
5836         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5837         throw_exception with throw.
5838         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5839         throw_exception with throw.
5840         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5841         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5842         * aarch64-tdep.c (aarch64_make_prologue_cache)
5843         (aarch64_make_stub_cache): Replace throw_exception with throw.
5844
5845 2019-04-08  Tom Tromey  <tom@tromey.com>
5846
5847         * common/common-exceptions.c (throw_exception): Rename from
5848         throw_exception_cxx.  Remove old copy.  Make argument const.
5849         (throw_it): Create and throw exception objects directly.
5850         * common/common-exceptions.h (throw_exception): Make argument
5851         const.
5852         (struct gdb_exception_error): Add constructor.
5853         (struct gdb_exception_quit): Add constructor.
5854
5855 2019-04-08  Tom Tromey  <tom@tromey.com>
5856
5857         * common/common-exceptions.h (exception_rethrow): Don't declare.
5858         (TRY_SJLJ): Update comment.
5859         (TRY, CATCH, END_CATCH): Remove.
5860         * common/common-exceptions.c (exception_rethrow): Remove.
5861
5862 2019-04-08  Tom Tromey  <tom@tromey.com>
5863
5864         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5865         Remove.
5866         (gdb_exception_error): Rename from
5867         gdb_exception_RETURN_MASK_ERROR.
5868         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5869         (gdb_quit_bad_alloc): Update.
5870         * aarch64-tdep.c: Update.
5871         * ada-lang.c: Update.
5872         * ada-typeprint.c: Update.
5873         * ada-valprint.c: Update.
5874         * amd64-tdep.c: Update.
5875         * arch-utils.c: Update.
5876         * break-catch-throw.c: Update.
5877         * breakpoint.c: Update.
5878         * btrace.c: Update.
5879         * c-varobj.c: Update.
5880         * cli/cli-cmds.c: Update.
5881         * cli/cli-interp.c: Update.
5882         * cli/cli-script.c: Update.
5883         * common/common-exceptions.c: Update.
5884         * common/new-op.c: Update.
5885         * common/selftest.c: Update.
5886         * compile/compile-c-symbols.c: Update.
5887         * compile/compile-cplus-symbols.c: Update.
5888         * compile/compile-object-load.c: Update.
5889         * compile/compile-object-run.c: Update.
5890         * completer.c: Update.
5891         * corelow.c: Update.
5892         * cp-abi.c: Update.
5893         * cp-support.c: Update.
5894         * cp-valprint.c: Update.
5895         * darwin-nat.c: Update.
5896         * disasm-selftests.c: Update.
5897         * dtrace-probe.c: Update.
5898         * dwarf-index-cache.c: Update.
5899         * dwarf-index-write.c: Update.
5900         * dwarf2-frame-tailcall.c: Update.
5901         * dwarf2-frame.c: Update.
5902         * dwarf2loc.c: Update.
5903         * dwarf2read.c: Update.
5904         * eval.c: Update.
5905         * event-loop.c: Update.
5906         * event-top.c: Update.
5907         * exec.c: Update.
5908         * f-valprint.c: Update.
5909         * fbsd-tdep.c: Update.
5910         * frame-unwind.c: Update.
5911         * frame.c: Update.
5912         * gdbtypes.c: Update.
5913         * gnu-v3-abi.c: Update.
5914         * guile/guile-internal.h: Update.
5915         * guile/scm-block.c: Update.
5916         * guile/scm-breakpoint.c: Update.
5917         * guile/scm-cmd.c: Update.
5918         * guile/scm-disasm.c: Update.
5919         * guile/scm-frame.c: Update.
5920         * guile/scm-lazy-string.c: Update.
5921         * guile/scm-math.c: Update.
5922         * guile/scm-param.c: Update.
5923         * guile/scm-ports.c: Update.
5924         * guile/scm-pretty-print.c: Update.
5925         * guile/scm-symbol.c: Update.
5926         * guile/scm-symtab.c: Update.
5927         * guile/scm-type.c: Update.
5928         * guile/scm-value.c: Update.
5929         * i386-linux-tdep.c: Update.
5930         * i386-tdep.c: Update.
5931         * inf-loop.c: Update.
5932         * infcall.c: Update.
5933         * infcmd.c: Update.
5934         * infrun.c: Update.
5935         * jit.c: Update.
5936         * language.c: Update.
5937         * linespec.c: Update.
5938         * linux-fork.c: Update.
5939         * linux-nat.c: Update.
5940         * linux-tdep.c: Update.
5941         * linux-thread-db.c: Update.
5942         * main.c: Update.
5943         * mi/mi-cmd-break.c: Update.
5944         * mi/mi-cmd-stack.c: Update.
5945         * mi/mi-interp.c: Update.
5946         * mi/mi-main.c: Update.
5947         * objc-lang.c: Update.
5948         * p-valprint.c: Update.
5949         * parse.c: Update.
5950         * ppc-linux-tdep.c: Update.
5951         * printcmd.c: Update.
5952         * python/py-arch.c: Update.
5953         * python/py-breakpoint.c: Update.
5954         * python/py-cmd.c: Update.
5955         * python/py-finishbreakpoint.c: Update.
5956         * python/py-frame.c: Update.
5957         * python/py-framefilter.c: Update.
5958         * python/py-gdb-readline.c: Update.
5959         * python/py-inferior.c: Update.
5960         * python/py-infthread.c: Update.
5961         * python/py-lazy-string.c: Update.
5962         * python/py-linetable.c: Update.
5963         * python/py-objfile.c: Update.
5964         * python/py-param.c: Update.
5965         * python/py-prettyprint.c: Update.
5966         * python/py-progspace.c: Update.
5967         * python/py-record-btrace.c: Update.
5968         * python/py-record.c: Update.
5969         * python/py-symbol.c: Update.
5970         * python/py-type.c: Update.
5971         * python/py-unwind.c: Update.
5972         * python/py-utils.c: Update.
5973         * python/py-value.c: Update.
5974         * python/python.c: Update.
5975         * record-btrace.c: Update.
5976         * record-full.c: Update.
5977         * remote-fileio.c: Update.
5978         * remote.c: Update.
5979         * riscv-tdep.c: Update.
5980         * rs6000-aix-tdep.c: Update.
5981         * rs6000-tdep.c: Update.
5982         * rust-exp.y: Update.
5983         * rust-lang.c: Update.
5984         * s390-tdep.c: Update.
5985         * selftest-arch.c: Update.
5986         * solib-dsbt.c: Update.
5987         * solib-frv.c: Update.
5988         * solib-spu.c: Update.
5989         * solib-svr4.c: Update.
5990         * solib.c: Update.
5991         * sparc64-linux-tdep.c: Update.
5992         * stack.c: Update.
5993         * symfile-mem.c: Update.
5994         * symmisc.c: Update.
5995         * target.c: Update.
5996         * thread.c: Update.
5997         * top.c: Update.
5998         * tracefile-tfile.c: Update.
5999         * tui/tui.c: Update.
6000         * typeprint.c: Update.
6001         * unittests/cli-utils-selftests.c: Update.
6002         * unittests/parse-connection-spec-selftests.c: Update.
6003         * valops.c: Update.
6004         * valprint.c: Update.
6005         * value.c: Update.
6006         * varobj.c: Update.
6007         * windows-nat.c: Update.
6008         * x86-linux-nat.c: Update.
6009         * xml-support.c: Update.
6010
6011 2019-04-08  Tom Tromey  <tom@tromey.com>
6012
6013         * xml-support.c: Use C++ exception handling.
6014         * x86-linux-nat.c: Use C++ exception handling.
6015         * windows-nat.c: Use C++ exception handling.
6016         * varobj.c: Use C++ exception handling.
6017         * value.c: Use C++ exception handling.
6018         * valprint.c: Use C++ exception handling.
6019         * valops.c: Use C++ exception handling.
6020         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6021         handling.
6022         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6023         * typeprint.c: Use C++ exception handling.
6024         * tui/tui.c: Use C++ exception handling.
6025         * tracefile-tfile.c: Use C++ exception handling.
6026         * top.c: Use C++ exception handling.
6027         * thread.c: Use C++ exception handling.
6028         * target.c: Use C++ exception handling.
6029         * symmisc.c: Use C++ exception handling.
6030         * symfile-mem.c: Use C++ exception handling.
6031         * stack.c: Use C++ exception handling.
6032         * sparc64-linux-tdep.c: Use C++ exception handling.
6033         * solib.c: Use C++ exception handling.
6034         * solib-svr4.c: Use C++ exception handling.
6035         * solib-spu.c: Use C++ exception handling.
6036         * solib-frv.c: Use C++ exception handling.
6037         * solib-dsbt.c: Use C++ exception handling.
6038         * selftest-arch.c: Use C++ exception handling.
6039         * s390-tdep.c: Use C++ exception handling.
6040         * rust-lang.c: Use C++ exception handling.
6041         * rust-exp.y: Use C++ exception handling.
6042         * rs6000-tdep.c: Use C++ exception handling.
6043         * rs6000-aix-tdep.c: Use C++ exception handling.
6044         * riscv-tdep.c: Use C++ exception handling.
6045         * remote.c: Use C++ exception handling.
6046         * remote-fileio.c: Use C++ exception handling.
6047         * record-full.c: Use C++ exception handling.
6048         * record-btrace.c: Use C++ exception handling.
6049         * python/python.c: Use C++ exception handling.
6050         * python/py-value.c: Use C++ exception handling.
6051         * python/py-utils.c: Use C++ exception handling.
6052         * python/py-unwind.c: Use C++ exception handling.
6053         * python/py-type.c: Use C++ exception handling.
6054         * python/py-symbol.c: Use C++ exception handling.
6055         * python/py-record.c: Use C++ exception handling.
6056         * python/py-record-btrace.c: Use C++ exception handling.
6057         * python/py-progspace.c: Use C++ exception handling.
6058         * python/py-prettyprint.c: Use C++ exception handling.
6059         * python/py-param.c: Use C++ exception handling.
6060         * python/py-objfile.c: Use C++ exception handling.
6061         * python/py-linetable.c: Use C++ exception handling.
6062         * python/py-lazy-string.c: Use C++ exception handling.
6063         * python/py-infthread.c: Use C++ exception handling.
6064         * python/py-inferior.c: Use C++ exception handling.
6065         * python/py-gdb-readline.c: Use C++ exception handling.
6066         * python/py-framefilter.c: Use C++ exception handling.
6067         * python/py-frame.c: Use C++ exception handling.
6068         * python/py-finishbreakpoint.c: Use C++ exception handling.
6069         * python/py-cmd.c: Use C++ exception handling.
6070         * python/py-breakpoint.c: Use C++ exception handling.
6071         * python/py-arch.c: Use C++ exception handling.
6072         * printcmd.c: Use C++ exception handling.
6073         * ppc-linux-tdep.c: Use C++ exception handling.
6074         * parse.c: Use C++ exception handling.
6075         * p-valprint.c: Use C++ exception handling.
6076         * objc-lang.c: Use C++ exception handling.
6077         * mi/mi-main.c: Use C++ exception handling.
6078         * mi/mi-interp.c: Use C++ exception handling.
6079         * mi/mi-cmd-stack.c: Use C++ exception handling.
6080         * mi/mi-cmd-break.c: Use C++ exception handling.
6081         * main.c: Use C++ exception handling.
6082         * linux-thread-db.c: Use C++ exception handling.
6083         * linux-tdep.c: Use C++ exception handling.
6084         * linux-nat.c: Use C++ exception handling.
6085         * linux-fork.c: Use C++ exception handling.
6086         * linespec.c: Use C++ exception handling.
6087         * language.c: Use C++ exception handling.
6088         * jit.c: Use C++ exception handling.
6089         * infrun.c: Use C++ exception handling.
6090         * infcmd.c: Use C++ exception handling.
6091         * infcall.c: Use C++ exception handling.
6092         * inf-loop.c: Use C++ exception handling.
6093         * i386-tdep.c: Use C++ exception handling.
6094         * i386-linux-tdep.c: Use C++ exception handling.
6095         * guile/scm-value.c: Use C++ exception handling.
6096         * guile/scm-type.c: Use C++ exception handling.
6097         * guile/scm-symtab.c: Use C++ exception handling.
6098         * guile/scm-symbol.c: Use C++ exception handling.
6099         * guile/scm-pretty-print.c: Use C++ exception handling.
6100         * guile/scm-ports.c: Use C++ exception handling.
6101         * guile/scm-param.c: Use C++ exception handling.
6102         * guile/scm-math.c: Use C++ exception handling.
6103         * guile/scm-lazy-string.c: Use C++ exception handling.
6104         * guile/scm-frame.c: Use C++ exception handling.
6105         * guile/scm-disasm.c: Use C++ exception handling.
6106         * guile/scm-cmd.c: Use C++ exception handling.
6107         * guile/scm-breakpoint.c: Use C++ exception handling.
6108         * guile/scm-block.c: Use C++ exception handling.
6109         * guile/guile-internal.h: Use C++ exception handling.
6110         * gnu-v3-abi.c: Use C++ exception handling.
6111         * gdbtypes.c: Use C++ exception handling.
6112         * frame.c: Use C++ exception handling.
6113         * frame-unwind.c: Use C++ exception handling.
6114         * fbsd-tdep.c: Use C++ exception handling.
6115         * f-valprint.c: Use C++ exception handling.
6116         * exec.c: Use C++ exception handling.
6117         * event-top.c: Use C++ exception handling.
6118         * event-loop.c: Use C++ exception handling.
6119         * eval.c: Use C++ exception handling.
6120         * dwarf2read.c: Use C++ exception handling.
6121         * dwarf2loc.c: Use C++ exception handling.
6122         * dwarf2-frame.c: Use C++ exception handling.
6123         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6124         * dwarf-index-write.c: Use C++ exception handling.
6125         * dwarf-index-cache.c: Use C++ exception handling.
6126         * dtrace-probe.c: Use C++ exception handling.
6127         * disasm-selftests.c: Use C++ exception handling.
6128         * darwin-nat.c: Use C++ exception handling.
6129         * cp-valprint.c: Use C++ exception handling.
6130         * cp-support.c: Use C++ exception handling.
6131         * cp-abi.c: Use C++ exception handling.
6132         * corelow.c: Use C++ exception handling.
6133         * completer.c: Use C++ exception handling.
6134         * compile/compile-object-run.c: Use C++ exception handling.
6135         * compile/compile-object-load.c: Use C++ exception handling.
6136         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6137         * compile/compile-c-symbols.c: Use C++ exception handling.
6138         * common/selftest.c: Use C++ exception handling.
6139         * common/new-op.c: Use C++ exception handling.
6140         * cli/cli-script.c: Use C++ exception handling.
6141         * cli/cli-interp.c: Use C++ exception handling.
6142         * cli/cli-cmds.c: Use C++ exception handling.
6143         * c-varobj.c: Use C++ exception handling.
6144         * btrace.c: Use C++ exception handling.
6145         * breakpoint.c: Use C++ exception handling.
6146         * break-catch-throw.c: Use C++ exception handling.
6147         * arch-utils.c: Use C++ exception handling.
6148         * amd64-tdep.c: Use C++ exception handling.
6149         * ada-valprint.c: Use C++ exception handling.
6150         * ada-typeprint.c: Use C++ exception handling.
6151         * ada-lang.c: Use C++ exception handling.
6152         * aarch64-tdep.c: Use C++ exception handling.
6153
6154 2019-04-08  Tom Tromey  <tom@tromey.com>
6155
6156         * xml-support.c (gdb_xml_parser::parse): Update.
6157         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6158         * value.c (show_convenience): Update.
6159         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6160         (test_parse_flags_qcs): Update.
6161         * thread.c (thr_try_catch_cmd): Update.
6162         * target.c (target_translate_tls_address): Update.
6163         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6164         (info_frame_command_core, frame_apply_command_count): Update.
6165         * rust-exp.y (rust_lex_exception_test): Update.
6166         * riscv-tdep.c (riscv_print_one_register_info): Update.
6167         * remote.c (remote_target::enable_btrace): Update.
6168         * record-btrace.c (record_btrace_enable_warn): Update.
6169         * python/py-utils.c (gdbpy_convert_exception): Update.
6170         * printcmd.c (do_one_display, print_variable_and_value): Update.
6171         * mi/mi-main.c (mi_print_exception): Update.
6172         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6173         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6174         * linux-nat.c (linux_nat_target::attach): Update.
6175         * linux-fork.c (class scoped_switch_fork_info): Update.
6176         * infrun.c (displaced_step_prepare): Update.
6177         * infcall.c (call_function_by_hand_dummy): Update.
6178         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6179         * gnu-v3-abi.c (print_one_vtable): Update.
6180         * frame.c (get_prev_frame_always): Update.
6181         * f-valprint.c (info_common_command_for_block): Update.
6182         * exec.c (try_open_exec_file): Update.
6183         * exceptions.c (print_exception, exception_print)
6184         (exception_fprintf, exception_print_same): Update.
6185         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6186         * dwarf-index-cache.c (index_cache::store)
6187         (index_cache::lookup_gdb_index): Update.
6188         * darwin-nat.c (maybe_cache_shell): Update.
6189         * cp-valprint.c (cp_print_value_fields): Update.
6190         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6191         (gcc_cplus_symbol_address): Update.
6192         * compile/compile-c-symbols.c (gcc_convert_symbol)
6193         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6194         * common/selftest.c: Update.
6195         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6196         a std::string.
6197         (exception_try_scope_entry, exception_try_scope_exit): Don't
6198         declare.
6199         (struct exception_try_scope): Remove.
6200         (TRY): Don't use exception_try_scope.
6201         (struct gdb_exception): Add constructor, operator=.
6202         <what>: New method.
6203         (struct gdb_exception_RETURN_MASK_ALL)
6204         (struct gdb_exception_RETURN_MASK_ERROR)
6205         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6206         (struct gdb_quit_bad_alloc): Update.
6207         * common/common-exceptions.c (exception_none): Change
6208         initializer.
6209         (struct catcher) <state, exception>: Initialize inline.
6210         <prev>: Remove member.
6211         (current_catcher): Remove.
6212         (catchers): New global.
6213         (exceptions_state_mc_init): Simplify.
6214         (catcher_pop): Remove.
6215         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6216         (try_scope_depth, exception_try_scope_entry)
6217         (exception_try_scope_exit): Remove.
6218         (throw_exception_sjlj): Update.
6219         (exception_messages, exception_messages_size): Remove.
6220         (throw_it): Simplify.
6221         (gdb_exception_sliced_copy): Remove.
6222         (throw_exception_cxx): Update.
6223         * cli/cli-script.c (script_from_file): Update.
6224         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6225         Update.
6226         * ada-valprint.c (ada_val_print): Update.
6227         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6228         (create_excep_cond_exprs): Update.
6229
6230 2019-04-08  Tom Tromey  <tom@tromey.com>
6231
6232         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6233         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6234         (TRY, CATCH, END_CATCH): Remove some definitions.
6235         * common/common-exceptions.c: Don't use GDB_XCPT.
6236         (catcher_list_size): Remove.
6237         (throw_exception, throw_it): Simplify.
6238
6239 2019-04-05  Tom Tromey  <tom@tromey.com>
6240
6241         Revert the header-sorting patch.
6242         * ft32-tdep.c: Revert.
6243         * frv-tdep.c: Revert.
6244         * frv-linux-tdep.c: Revert.
6245         * frame.c: Revert.
6246         * frame-unwind.c: Revert.
6247         * frame-base.c: Revert.
6248         * fork-child.c: Revert.
6249         * findvar.c: Revert.
6250         * findcmd.c: Revert.
6251         * filesystem.c: Revert.
6252         * filename-seen-cache.h: Revert.
6253         * filename-seen-cache.c: Revert.
6254         * fbsd-tdep.c: Revert.
6255         * fbsd-nat.h: Revert.
6256         * fbsd-nat.c: Revert.
6257         * f-valprint.c: Revert.
6258         * f-typeprint.c: Revert.
6259         * f-lang.c: Revert.
6260         * extension.h: Revert.
6261         * extension.c: Revert.
6262         * extension-priv.h: Revert.
6263         * expprint.c: Revert.
6264         * exec.h: Revert.
6265         * exec.c: Revert.
6266         * exceptions.c: Revert.
6267         * event-top.c: Revert.
6268         * event-loop.c: Revert.
6269         * eval.c: Revert.
6270         * elfread.c: Revert.
6271         * dwarf2read.h: Revert.
6272         * dwarf2read.c: Revert.
6273         * dwarf2loc.c: Revert.
6274         * dwarf2expr.h: Revert.
6275         * dwarf2expr.c: Revert.
6276         * dwarf2-frame.c: Revert.
6277         * dwarf2-frame-tailcall.c: Revert.
6278         * dwarf-index-write.h: Revert.
6279         * dwarf-index-write.c: Revert.
6280         * dwarf-index-common.c: Revert.
6281         * dwarf-index-cache.h: Revert.
6282         * dwarf-index-cache.c: Revert.
6283         * dummy-frame.c: Revert.
6284         * dtrace-probe.c: Revert.
6285         * disasm.h: Revert.
6286         * disasm.c: Revert.
6287         * disasm-selftests.c: Revert.
6288         * dictionary.c: Revert.
6289         * dicos-tdep.c: Revert.
6290         * demangle.c: Revert.
6291         * dcache.h: Revert.
6292         * dcache.c: Revert.
6293         * darwin-nat.h: Revert.
6294         * darwin-nat.c: Revert.
6295         * darwin-nat-info.c: Revert.
6296         * d-valprint.c: Revert.
6297         * d-namespace.c: Revert.
6298         * d-lang.c: Revert.
6299         * ctf.c: Revert.
6300         * csky-tdep.c: Revert.
6301         * csky-linux-tdep.c: Revert.
6302         * cris-tdep.c: Revert.
6303         * cris-linux-tdep.c: Revert.
6304         * cp-valprint.c: Revert.
6305         * cp-support.c: Revert.
6306         * cp-namespace.c: Revert.
6307         * cp-abi.c: Revert.
6308         * corelow.c: Revert.
6309         * corefile.c: Revert.
6310         * continuations.c: Revert.
6311         * completer.h: Revert.
6312         * completer.c: Revert.
6313         * complaints.c: Revert.
6314         * coffread.c: Revert.
6315         * coff-pe-read.c: Revert.
6316         * cli-out.h: Revert.
6317         * cli-out.c: Revert.
6318         * charset.c: Revert.
6319         * c-varobj.c: Revert.
6320         * c-valprint.c: Revert.
6321         * c-typeprint.c: Revert.
6322         * c-lang.c: Revert.
6323         * buildsym.c: Revert.
6324         * buildsym-legacy.c: Revert.
6325         * build-id.h: Revert.
6326         * build-id.c: Revert.
6327         * btrace.c: Revert.
6328         * bsd-uthread.c: Revert.
6329         * breakpoint.h: Revert.
6330         * breakpoint.c: Revert.
6331         * break-catch-throw.c: Revert.
6332         * break-catch-syscall.c: Revert.
6333         * break-catch-sig.c: Revert.
6334         * blockframe.c: Revert.
6335         * block.c: Revert.
6336         * bfin-tdep.c: Revert.
6337         * bfin-linux-tdep.c: Revert.
6338         * bfd-target.c: Revert.
6339         * bcache.c: Revert.
6340         * ax-general.c: Revert.
6341         * ax-gdb.h: Revert.
6342         * ax-gdb.c: Revert.
6343         * avr-tdep.c: Revert.
6344         * auxv.c: Revert.
6345         * auto-load.c: Revert.
6346         * arm-wince-tdep.c: Revert.
6347         * arm-tdep.c: Revert.
6348         * arm-symbian-tdep.c: Revert.
6349         * arm-pikeos-tdep.c: Revert.
6350         * arm-obsd-tdep.c: Revert.
6351         * arm-nbsd-tdep.c: Revert.
6352         * arm-nbsd-nat.c: Revert.
6353         * arm-linux-tdep.c: Revert.
6354         * arm-linux-nat.c: Revert.
6355         * arm-fbsd-tdep.c: Revert.
6356         * arm-fbsd-nat.c: Revert.
6357         * arm-bsd-tdep.c: Revert.
6358         * arch-utils.c: Revert.
6359         * arc-tdep.c: Revert.
6360         * arc-newlib-tdep.c: Revert.
6361         * annotate.h: Revert.
6362         * annotate.c: Revert.
6363         * amd64-windows-tdep.c: Revert.
6364         * amd64-windows-nat.c: Revert.
6365         * amd64-tdep.c: Revert.
6366         * amd64-sol2-tdep.c: Revert.
6367         * amd64-obsd-tdep.c: Revert.
6368         * amd64-obsd-nat.c: Revert.
6369         * amd64-nbsd-tdep.c: Revert.
6370         * amd64-nbsd-nat.c: Revert.
6371         * amd64-nat.c: Revert.
6372         * amd64-linux-tdep.c: Revert.
6373         * amd64-linux-nat.c: Revert.
6374         * amd64-fbsd-tdep.c: Revert.
6375         * amd64-fbsd-nat.c: Revert.
6376         * amd64-dicos-tdep.c: Revert.
6377         * amd64-darwin-tdep.c: Revert.
6378         * amd64-bsd-nat.c: Revert.
6379         * alpha-tdep.c: Revert.
6380         * alpha-obsd-tdep.c: Revert.
6381         * alpha-nbsd-tdep.c: Revert.
6382         * alpha-mdebug-tdep.c: Revert.
6383         * alpha-linux-tdep.c: Revert.
6384         * alpha-linux-nat.c: Revert.
6385         * alpha-bsd-tdep.c: Revert.
6386         * alpha-bsd-nat.c: Revert.
6387         * aix-thread.c: Revert.
6388         * agent.c: Revert.
6389         * addrmap.c: Revert.
6390         * ada-varobj.c: Revert.
6391         * ada-valprint.c: Revert.
6392         * ada-typeprint.c: Revert.
6393         * ada-tasks.c: Revert.
6394         * ada-lang.c: Revert.
6395         * aarch64-tdep.c: Revert.
6396         * aarch64-ravenscar-thread.c: Revert.
6397         * aarch64-newlib-tdep.c: Revert.
6398         * aarch64-linux-tdep.c: Revert.
6399         * aarch64-linux-nat.c: Revert.
6400         * aarch64-fbsd-tdep.c: Revert.
6401         * aarch64-fbsd-nat.c: Revert.
6402         * aarch32-linux-nat.c: Revert.
6403
6404 2019-04-05  Tom Tromey  <tom@tromey.com>
6405
6406         * ft32-tdep.c: Sort headers.
6407         * frv-tdep.c: Sort headers.
6408         * frv-linux-tdep.c: Sort headers.
6409         * frame.c: Sort headers.
6410         * frame-unwind.c: Sort headers.
6411         * frame-base.c: Sort headers.
6412         * fork-child.c: Sort headers.
6413         * findvar.c: Sort headers.
6414         * findcmd.c: Sort headers.
6415         * filesystem.c: Sort headers.
6416         * filename-seen-cache.h: Sort headers.
6417         * filename-seen-cache.c: Sort headers.
6418         * fbsd-tdep.c: Sort headers.
6419         * fbsd-nat.h: Sort headers.
6420         * fbsd-nat.c: Sort headers.
6421         * f-valprint.c: Sort headers.
6422         * f-typeprint.c: Sort headers.
6423         * f-lang.c: Sort headers.
6424         * extension.h: Sort headers.
6425         * extension.c: Sort headers.
6426         * extension-priv.h: Sort headers.
6427         * expprint.c: Sort headers.
6428         * exec.h: Sort headers.
6429         * exec.c: Sort headers.
6430         * exceptions.c: Sort headers.
6431         * event-top.c: Sort headers.
6432         * event-loop.c: Sort headers.
6433         * eval.c: Sort headers.
6434         * elfread.c: Sort headers.
6435         * dwarf2read.h: Sort headers.
6436         * dwarf2read.c: Sort headers.
6437         * dwarf2loc.c: Sort headers.
6438         * dwarf2expr.h: Sort headers.
6439         * dwarf2expr.c: Sort headers.
6440         * dwarf2-frame.c: Sort headers.
6441         * dwarf2-frame-tailcall.c: Sort headers.
6442         * dwarf-index-write.h: Sort headers.
6443         * dwarf-index-write.c: Sort headers.
6444         * dwarf-index-common.c: Sort headers.
6445         * dwarf-index-cache.h: Sort headers.
6446         * dwarf-index-cache.c: Sort headers.
6447         * dummy-frame.c: Sort headers.
6448         * dtrace-probe.c: Sort headers.
6449         * disasm.h: Sort headers.
6450         * disasm.c: Sort headers.
6451         * disasm-selftests.c: Sort headers.
6452         * dictionary.c: Sort headers.
6453         * dicos-tdep.c: Sort headers.
6454         * demangle.c: Sort headers.
6455         * dcache.h: Sort headers.
6456         * dcache.c: Sort headers.
6457         * darwin-nat.h: Sort headers.
6458         * darwin-nat.c: Sort headers.
6459         * darwin-nat-info.c: Sort headers.
6460         * d-valprint.c: Sort headers.
6461         * d-namespace.c: Sort headers.
6462         * d-lang.c: Sort headers.
6463         * ctf.c: Sort headers.
6464         * csky-tdep.c: Sort headers.
6465         * csky-linux-tdep.c: Sort headers.
6466         * cris-tdep.c: Sort headers.
6467         * cris-linux-tdep.c: Sort headers.
6468         * cp-valprint.c: Sort headers.
6469         * cp-support.c: Sort headers.
6470         * cp-namespace.c: Sort headers.
6471         * cp-abi.c: Sort headers.
6472         * corelow.c: Sort headers.
6473         * corefile.c: Sort headers.
6474         * continuations.c: Sort headers.
6475         * completer.h: Sort headers.
6476         * completer.c: Sort headers.
6477         * complaints.c: Sort headers.
6478         * coffread.c: Sort headers.
6479         * coff-pe-read.c: Sort headers.
6480         * cli-out.h: Sort headers.
6481         * cli-out.c: Sort headers.
6482         * charset.c: Sort headers.
6483         * c-varobj.c: Sort headers.
6484         * c-valprint.c: Sort headers.
6485         * c-typeprint.c: Sort headers.
6486         * c-lang.c: Sort headers.
6487         * buildsym.c: Sort headers.
6488         * buildsym-legacy.c: Sort headers.
6489         * build-id.h: Sort headers.
6490         * build-id.c: Sort headers.
6491         * btrace.c: Sort headers.
6492         * bsd-uthread.c: Sort headers.
6493         * breakpoint.h: Sort headers.
6494         * breakpoint.c: Sort headers.
6495         * break-catch-throw.c: Sort headers.
6496         * break-catch-syscall.c: Sort headers.
6497         * break-catch-sig.c: Sort headers.
6498         * blockframe.c: Sort headers.
6499         * block.c: Sort headers.
6500         * bfin-tdep.c: Sort headers.
6501         * bfin-linux-tdep.c: Sort headers.
6502         * bfd-target.c: Sort headers.
6503         * bcache.c: Sort headers.
6504         * ax-general.c: Sort headers.
6505         * ax-gdb.h: Sort headers.
6506         * ax-gdb.c: Sort headers.
6507         * avr-tdep.c: Sort headers.
6508         * auxv.c: Sort headers.
6509         * auto-load.c: Sort headers.
6510         * arm-wince-tdep.c: Sort headers.
6511         * arm-tdep.c: Sort headers.
6512         * arm-symbian-tdep.c: Sort headers.
6513         * arm-pikeos-tdep.c: Sort headers.
6514         * arm-obsd-tdep.c: Sort headers.
6515         * arm-nbsd-tdep.c: Sort headers.
6516         * arm-nbsd-nat.c: Sort headers.
6517         * arm-linux-tdep.c: Sort headers.
6518         * arm-linux-nat.c: Sort headers.
6519         * arm-fbsd-tdep.c: Sort headers.
6520         * arm-fbsd-nat.c: Sort headers.
6521         * arm-bsd-tdep.c: Sort headers.
6522         * arch-utils.c: Sort headers.
6523         * arc-tdep.c: Sort headers.
6524         * arc-newlib-tdep.c: Sort headers.
6525         * annotate.h: Sort headers.
6526         * annotate.c: Sort headers.
6527         * amd64-windows-tdep.c: Sort headers.
6528         * amd64-windows-nat.c: Sort headers.
6529         * amd64-tdep.c: Sort headers.
6530         * amd64-sol2-tdep.c: Sort headers.
6531         * amd64-obsd-tdep.c: Sort headers.
6532         * amd64-obsd-nat.c: Sort headers.
6533         * amd64-nbsd-tdep.c: Sort headers.
6534         * amd64-nbsd-nat.c: Sort headers.
6535         * amd64-nat.c: Sort headers.
6536         * amd64-linux-tdep.c: Sort headers.
6537         * amd64-linux-nat.c: Sort headers.
6538         * amd64-fbsd-tdep.c: Sort headers.
6539         * amd64-fbsd-nat.c: Sort headers.
6540         * amd64-dicos-tdep.c: Sort headers.
6541         * amd64-darwin-tdep.c: Sort headers.
6542         * amd64-bsd-nat.c: Sort headers.
6543         * alpha-tdep.c: Sort headers.
6544         * alpha-obsd-tdep.c: Sort headers.
6545         * alpha-nbsd-tdep.c: Sort headers.
6546         * alpha-mdebug-tdep.c: Sort headers.
6547         * alpha-linux-tdep.c: Sort headers.
6548         * alpha-linux-nat.c: Sort headers.
6549         * alpha-bsd-tdep.c: Sort headers.
6550         * alpha-bsd-nat.c: Sort headers.
6551         * aix-thread.c: Sort headers.
6552         * agent.c: Sort headers.
6553         * addrmap.c: Sort headers.
6554         * ada-varobj.c: Sort headers.
6555         * ada-valprint.c: Sort headers.
6556         * ada-typeprint.c: Sort headers.
6557         * ada-tasks.c: Sort headers.
6558         * ada-lang.c: Sort headers.
6559         * aarch64-tdep.c: Sort headers.
6560         * aarch64-ravenscar-thread.c: Sort headers.
6561         * aarch64-newlib-tdep.c: Sort headers.
6562         * aarch64-linux-tdep.c: Sort headers.
6563         * aarch64-linux-nat.c: Sort headers.
6564         * aarch64-fbsd-tdep.c: Sort headers.
6565         * aarch64-fbsd-nat.c: Sort headers.
6566         * aarch32-linux-nat.c: Sort headers.
6567
6568 2019-04-04  Tom Tromey  <tom@tromey.com>
6569
6570         * varobj.c (varobj_create): Update.
6571         * rust-exp.y (struct rust_parser) <update_innermost_block,
6572         lookup_symbol>: New methods.
6573         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6574         Rename.
6575         (rust_parser::rust_lookup_type)
6576         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6577         * printcmd.c (display_command, do_one_display): Update.
6578         * parser-defs.h (struct parser_state) <parser_state>: Add
6579         "tracker" parameter.
6580         (block_tracker): New member.
6581         (class innermost_block_tracker) <innermost_block_tracker>: Add
6582         "types" parameter.
6583         <reset>: Remove method.
6584         (innermost_block): Don't declare.
6585         (null_post_parser): Update.
6586         * parse.c (innermost_block): Remove global.
6587         (write_dollar_variable): Update.
6588         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6589         Remove "tracker_types" parameter.
6590         (parse_expression): Add "tracker" parameter.
6591         (parse_expression_for_completion): Update.
6592         (null_post_parser): Add "tracker" parameter.
6593         * p-exp.y: Update rules.
6594         * m2-exp.y: Update rules.
6595         * language.h (struct language_defn) <la_post_parser>: Add
6596         "tracker" parameter.
6597         * go-exp.y: Update rules.
6598         * f-exp.y: Update rules.
6599         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6600         parameter.
6601         * d-exp.y: Update rules.
6602         * c-exp.y: Update rules.
6603         * breakpoint.c (set_breakpoint_condition): Create an
6604         innermost_block_tracker.
6605         (watch_command_1): Likewise.
6606         * ada-lang.c (resolve): Add "tracker" parameter.
6607         (resolve_subexp): Likewise.
6608         * ada-exp.y (write_var_from_sym): Update.
6609
6610 2019-04-04  Tom Tromey  <tom@tromey.com>
6611
6612         * type-stack.h: New file.
6613         * type-stack.c: New file.
6614         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6615         type-stack.h.
6616         (insert_into_type_stack, insert_type, push_type, push_type_int)
6617         (insert_type_address_space, pop_type, pop_type_int)
6618         (pop_typelist, pop_type_stack, append_type_stack)
6619         (push_type_stack, get_type_stack, push_typelist)
6620         (follow_type_instance_flags, follow_types): Don't declare.
6621         * parse.c (type_stack): Remove global.
6622         (parse_exp_in_context): Update.
6623         (insert_into_type_stack, insert_type, push_type, push_type_int)
6624         (insert_type_address_space, pop_type, pop_type_int)
6625         (pop_typelist, pop_type_stack, append_type_stack)
6626         (push_type_stack, get_type_stack, push_typelist)
6627         (follow_type_instance_flags, follow_types): Remove (moved to
6628         type-stack.c).
6629         * f-exp.y (type_stack): New global.
6630         Update rules.
6631         (push_kind_type, f_parse): Update.
6632         * d-exp.y (type_stack): New global.
6633         Update rules.
6634         (d_parse): Update.
6635         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6636         Update rules.
6637         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6638         (HFILES_NO_SRCDIR): Add type-stack.h.
6639
6640 2019-04-04  Tom Tromey  <tom@tromey.com>
6641
6642         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6643         (rust_parser::convert_ast_to_expression, rust_parse)
6644         (rust_lex_test_completion, rust_lex_tests): Update.
6645         * parser-defs.h (struct expr_completion_state): New.
6646         (struct parser_state) <parser_state>: Add completion parameter.
6647         <mark_struct_expression, mark_completion_tag>: New methods.
6648         <parse_completion, m_completion_state>: New members.
6649         (prefixify_expression, null_post_parser): Update.
6650         (mark_struct_expression, mark_completion_tag): Don't declare.
6651         * parse.c (parse_completion, expout_last_struct)
6652         (expout_tag_completion_type, expout_completion_name): Remove
6653         globals.
6654         (parser_state::mark_struct_expression)
6655         (parser_state::mark_completion_tag): Now methods.
6656         (prefixify_expression): Add last_struct parameter.
6657         (prefixify_subexp): Likewise.
6658         (parse_exp_1): Update.
6659         (parse_exp_in_context): Add cstate parameter.  Update.
6660         (parse_expression_for_completion): Create an
6661         expr_completion_state.
6662         (null_post_parser): Add "completion" parameter.
6663         * p-exp.y: Update rules.
6664         (yylex): Update.
6665         * language.h (struct language_defn) <la_post_parser>: Add
6666         "completing" parameter.
6667         * go-exp.y: Update rules.
6668         (lex_one_token): Update.
6669         * expression.h (parse_completion): Don't declare.
6670         * d-exp.y: Update rules.
6671         (lex_one_token): Update rules.
6672         * c-exp.y: Update rules.
6673         (lex_one_token): Update.
6674         * ada-lang.c (resolve): Add "parse_completion" parameter.
6675         (resolve_subexp): Likewise.
6676         (ada_resolve_function): Likewise.
6677
6678 2019-04-04  Tom Tromey  <tom@tromey.com>
6679
6680         * parser-defs.h (struct parser_state) <start_arglist,
6681         end_arglist>: New methods.
6682         <arglist_len, m_funcall_chain>: New members.
6683         (arglist_len, start_arglist, end_arglist): Don't declare.
6684         * parse.c (arglist_len, funcall_chain): Remove global.
6685         (start_arglist, end_arglist): Remove functions.
6686         (parse_exp_in_context): Update.
6687         * p-exp.y: Update rules.
6688         * m2-exp.y: Update rules.
6689         * go-exp.y: Update rules.
6690         * f-exp.y: Update rules.
6691         * d-exp.y: Update rules.
6692         * c-exp.y: Update rules.
6693
6694 2019-04-04  Tom Tromey  <tom@tromey.com>
6695
6696         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6697         lex_operator, push_back>: New methods.
6698         Update all rules.
6699         (rust_parser::lex_hex, lex_escape): Rename and update.
6700         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6701         (rust_parser::lex_operator): Rename and update.
6702         (rust_parser::lex_number, rustyylex, rustyyerror)
6703         (rust_lex_test_init, rust_lex_test_sequence)
6704         (rust_lex_test_push_back, rust_lex_tests): Update.
6705         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6706         parameter.
6707         <lexptr, prev_lexptr>: New members.
6708         (lexptr, prev_lexptr): Don't declare.
6709         * parse.c (lexptr, prev_lexptr): Remove globals.
6710         (parse_exp_in_context): Update.
6711         * p-exp.y (yylex, yyerror): Update.
6712         * m2-exp.y (parse_number, yylex, yyerror): Update.
6713         * go-exp.y (lex_one_token, yyerror): Update.
6714         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6715         * d-exp.y (lex_one_token, yyerror): Update.
6716         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6717         (lex_one_token, yyerror): Update.
6718         * ada-lex.l (YY_INPUT): Update.
6719         (rewind_to_char): Update.
6720         * ada-exp.y (yyerror): Update.
6721
6722 2019-04-04  Tom Tromey  <tom@tromey.com>
6723
6724         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6725         * parser-defs.h (struct parser_state) <parser_state>: Add new
6726         parameter.
6727         <comma_terminates>: New member.
6728         (comma_terminates): Don't declare global.
6729         * parse.c (comma_terminates): Remove global.
6730         (parse_exp_in_context): Update.
6731         * p-exp.y (yylex): Update.
6732         * m2-exp.y (yylex): Update.
6733         * go-exp.y (lex_one_token): Update.
6734         * f-exp.y (yylex): Update.
6735         * d-exp.y (lex_one_token): Update.
6736         * c-exp.y (lex_one_token): Update.
6737         * ada-lex.l: Update.
6738
6739 2019-04-04  Tom Tromey  <tom@tromey.com>
6740
6741         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6742         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6743         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6744         * parser-defs.h (paren_depth): Don't declare.
6745         * parse.c (paren_depth): Remove global.
6746         (parse_exp_in_context): Update.
6747         * p-exp.y (paren_depth): New global.
6748         (pascal_parse): Initialize it.
6749         * m2-exp.y (paren_depth): New global.
6750         (m2_parse): Initialize it.
6751         * go-exp.y (paren_depth): New global.
6752         (go_parse): Initialize it.
6753         * f-exp.y (paren_depth): New global.
6754         (f_parse): Initialize it.
6755         * d-exp.y (paren_depth): New global.
6756         (d_parse): Initialize it.
6757         * c-exp.y (paren_depth): New global.
6758         (c_parse): Initialize it.
6759         * ada-lex.l (paren_depth): New global.
6760         (lexer_init): Initialize it.
6761
6762 2019-04-04  Tom Tromey  <tom@tromey.com>
6763
6764         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6765         (rust_parser::convert_ast_to_type)
6766         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6767         * parser-defs.h (struct parser_state) <parser_state>: Add
6768         parameters.  Initialize new members.
6769         <expression_context_block, expression_context_pc>: New members.
6770         * parse.c (expression_context_block, expression_context_pc):
6771         Remove globals.
6772         (parse_exp_in_context): Update.
6773         * p-exp.y: Update all rules.
6774         (yylex): Update.
6775         * m2-exp.y: Update all rules.
6776         (yylex): Update.
6777         * go-exp.y (yylex): Update.
6778         * f-exp.y (yylex): Update.
6779         * d-exp.y: Update all rules.
6780         (yylex): Update.
6781         * c-exp.y: Update all rules.
6782         (lex_one_token, classify_name, yylex, c_parse): Update.
6783         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6784
6785 2019-04-04  Tom Tromey  <tom@tromey.com>
6786
6787         * gdbarch.h, gdbarch.c: Rebuild.
6788         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6789         * stap-probe.h:
6790         (struct stap_parse_info): Replace "parser_state" with
6791         "expr_builder".
6792         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6793         (parser_state): New class.
6794         * parse.c (expr_builder): Rename.
6795         (expr_builder::release): Rename.
6796         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6797         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6798         (write_exp_elt_longcst, write_exp_elt_floatcst)
6799         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6800         (write_exp_string_vector, write_exp_bitstring)
6801         (write_exp_msymbol, mark_struct_expression)
6802         (write_dollar_variable)
6803         (insert_type_address_space, increase_expout_size): Replace
6804         "parser_state" with "expr_builder".
6805         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6806         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6807         "parser_state" with "expr_builder".
6808
6809 2019-04-04  Tom Tromey  <tom@tromey.com>
6810
6811         * rust-exp.y: Replace "parse_language" with method call.
6812         * p-exp.y:
6813         (yylex): Replace "parse_language" with method call.
6814         * m2-exp.y:
6815         (yylex): Replace "parse_language" with method call.
6816         * go-exp.y (classify_name): Replace "parse_language" with method
6817         call.
6818         * f-exp.y (yylex): Replace "parse_language" with method call.
6819         * d-exp.y (lex_one_token): Replace "parse_language" with method
6820         call.
6821         * c-exp.y:
6822         (lex_one_token, classify_name, yylex): Replace "parse_language"
6823         with method call.
6824         * ada-exp.y (find_primitive_type, type_char)
6825         (type_system_address): Replace "parse_language" with method call.
6826
6827 2019-04-04  Tom Tromey  <tom@tromey.com>
6828
6829         * rust-exp.y: Replace "parse_gdbarch" with method call.
6830         * parse.c (write_dollar_variable, insert_type_address_space):
6831         Replace "parse_gdbarch" with method call.
6832         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6833         call.
6834         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6835         call.
6836         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6837         "parse_gdbarch" with method call.
6838         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6839         with method call.
6840         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6841         "parse_gdbarch" with method call.
6842         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6843         "parse_gdbarch" with method call.
6844         * c-exp.y (parse_type, parse_number, classify_name): Replace
6845         "parse_gdbarch" with method call.
6846         * ada-lex.l: Replace "parse_gdbarch" with method call.
6847         * ada-exp.y (parse_type, find_primitive_type, type_char)
6848         (type_system_address): Replace "parse_gdbarch" with method call.
6849
6850 2019-04-04  Tom Tromey  <tom@tromey.com>
6851
6852         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6853         * stap-probe.c (stap_parse_argument): Update.
6854         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6855         initial_size parameter.
6856         * rust-exp.y (rust_lex_tests): Update.
6857         * parse.c (parser_state): Update.
6858         (parse_exp_in_context): Update.
6859         * parser-defs.h (struct parser_state) <parser_state>: Remove
6860         "initial_size" parameter.
6861
6862 2019-04-04  Tom Tromey  <tom@tromey.com>
6863
6864         * parser-defs.h (increase_expout_size): Don't declare.
6865         * parse.c (increase_expout_size): Now static.
6866
6867 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6868
6869         * gnu-nat.c (gnu_nat_target::wait): Fix
6870         target_waitstatus_to_string call.
6871
6872 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6873
6874         * eval.c (evaluate_subexp_standard): Handle internal functions
6875         during Fortran function call handling.
6876
6877 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6878
6879         * NEWS: Mention new internal functions.
6880         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6881         (read_base_type): Use dwarf2_init_complex_target_type.
6882         * value.c (creal_internal_fn): New function.
6883         (cimag_internal_fn): New function.
6884         (_initialize_values): Register new internal functions.
6885
6886 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6887
6888         * infrun.c (stop_all_threads): If debug_infrun, always
6889         trace the wait status after wait_one, using
6890         target_waitstatus_to_string and target_pid_to_str.
6891         (handle_inferior_event): Replace various trace of
6892         wait status kind by a single trace.
6893         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6894         wait status kind image by target_waitstatus_to_string.
6895         * target/waitstatus.c (target_waitstatus_to_string): Fix
6896         obsolete comment.
6897
6898 2019-04-01  Tom Tromey  <tromey@adacore.com>
6899
6900         PR symtab/23331:
6901         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6902
6903 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6904             Pedro Alves  <palves@redhat.com>
6905
6906         * top.c (quit_force): Call 'finalize_values'.
6907         * value.c (finalize_values): New function.
6908         * value.h (finalize_values): Declare.
6909
6910 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6911
6912         * NEWS: Announce $_gdb_major and $_gdb_minor.
6913
6914         * top.c (init_gdb_version_vars): New function.
6915         (gdb_init): Call init_gdb_version_vars.
6916
6917 2019-03-29  Tom Tromey  <tromey@adacore.com>
6918
6919         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6920         help text.  Remove dead code.
6921
6922 2019-03-29  Keith Seitz  <keiths@redhat.com>
6923
6924         From Siddhesh Poyarekar:
6925         * f-lang.h (f77_get_upperbound): Return LONGEST.
6926         (f77_get_lowerbound): Likewise.
6927         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6928         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6929         print them.
6930         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6931         plongest to format print it.
6932         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6933         (f77_get_upperbound): Likewise.
6934         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6935         LOWER_BOUND to LONGEST.
6936         (f77_create_arrayprint_offset_tbl): Likewise.
6937
6938 2019-03-29  Keith Seitz  <keiths@redhat.com>
6939
6940         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6941         %s/pulongest for TYPE_LENGTH instead of %d in format
6942         strings.
6943         * ada-typerint.c (ada_print_type): Likewise.
6944         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6945         * compile/compile-c-support.c (generate_register_struct): Likewise.
6946         * gdbtypes.c (recursive_dump_type): Likewise.
6947         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6948         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6949         instead of %d in format strings.
6950         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6951         to std::min to ULONGEST.
6952         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6953         instead of %d in format strings.
6954         * tracepoint.c (info_scope_command): Likewise.
6955         * typeprint.c (print_offset_data::update)
6956         (print_offset_data::finish): Likewise.
6957         * xtensa-tdep.c (xtensa_store_return_value)
6958         (xtensa_push_dummy_call): Likewise.
6959
6960 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6961
6962         * windows-nat.c (display_selector): Fixed format specifications
6963         for 64-bit Cygwin.
6964
6965 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6966
6967         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6968
6969 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6970
6971         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6972         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6973         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6974         (nios2_linux_init_abi): Install it.
6975
6976 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6977
6978         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6979
6980 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6981
6982         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6983
6984 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6985             Tom Tromey  <tromey@adacore.com>
6986
6987         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6988
6989 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6990
6991         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6992         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6993         method to compute the bounds of range types. Also print "[evaluated]"
6994         if the bounds' values come from a dynamic evaluation.
6995
6996 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6997
6998         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6999         whitespace when pretty printing is on.
7000
7001 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7002
7003         * ppc-linux-nat.c: Add include.
7004
7005 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7006
7007         * NEWS: Mention AArch64 Pointer Authentication.
7008
7009 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7010
7011         * arm-linux-nat.c: Add include.
7012
7013 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7014
7015         * source-cache.c (source_cache::get_source_lines): Re-read
7016         fullname after calling open_source_file.
7017
7018 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7019
7020         * NEWS: Mention TLS support for FreeBSD.
7021
7022 2019-03-25  Tom Tromey  <tromey@adacore.com>
7023
7024         * minsyms.c (BUNCH_SIZE): Update comment.
7025         (~minimal_symbol_reader): Remove old comment.
7026         (compact_minimal_symbols): Update comment.
7027         (minimal_symbol_reader::install): Remove old comment.  Update
7028         other comments.
7029
7030 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7031
7032         * s390-linux-nat.c: Add include.
7033
7034 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7035
7036         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7037         Call linux_get_hwcap.
7038         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7039         Likewise.
7040         (aarch64_linux_get_hwcap): Remove function.
7041         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7042         declaration.
7043         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7044         linux_get_hwcap.
7045         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7046         * linux-tdep.c (linux_get_hwcap): Add function.
7047         (linux_get_hwcap2): Likewise.
7048         * linux-tdep.h (linux_get_hwcap): Add declaration.
7049         (linux_get_hwcap2): Likewise.
7050         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7051         (ppc_linux_get_hwcap2): Likewise.
7052         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7053         linux_get_hwcap.
7054         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7055         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7056         (ppc_linux_nat_target::read_description): Likewise.
7057         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7058         * s390-linux-nat.c: Likewise.
7059         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7060
7061 2019-03-24  Tom Tromey  <tom@tromey.com>
7062
7063         * ada-lang.c (standard_lookup): Simplify initialization.
7064         (ada_lookup_symbol_nonlocal): Simplify return.
7065         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7066         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7067         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7068         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7069         initialization.
7070         * solib.c (solib_global_lookup): Simplify.
7071         * symtab.c (null_block_symbol): Remove.
7072         (symbol_cache_lookup): Simplify returns.
7073         (lookup_language_this): Simplify returns.
7074         (lookup_symbol_aux): Simplify return.
7075         (lookup_local_symbol): Simplify returns.
7076         (lookup_global_symbol_from_objfile): Simplify return.
7077         (lookup_symbol_in_objfile_symtabs)
7078         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7079         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7080         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7081         * cp-namespace.c (cp_lookup_bare_symbol)
7082         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7083         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7084         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7085         (cp_lookup_symbol_via_imports): Simplify initialization.
7086         (find_symbol_in_baseclass): Likewise.
7087         * symtab.h (null_block_symbol): Remove.
7088         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7089         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7090         (d_lookup_symbol_module): Likewise.
7091         (find_symbol_in_baseclass): Simplify initialization.
7092
7093 2019-03-24  Tom Tromey  <tom@tromey.com>
7094
7095         * expression.h: Don't include symtab.h.
7096         (struct block): Forward declare.
7097
7098 2019-03-24  Tom Tromey  <tom@tromey.com>
7099
7100         * c-exp.y (typebase): Remove casts.
7101         * gdbtypes.c (lookup_unsigned_typename, )
7102         (lookup_signed_typename): Remove cast.
7103         * eval.c (parse_to_comma_and_eval): Remove cast.
7104         * parse.c (write_dollar_variable): Remove cast.
7105         * block.h (struct block) <superblock>: Now const.
7106         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7107         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7108         (map_block): Make "block" const.
7109         * symfile.h (struct quick_symbol_functions)
7110         <map_matching_symbols>: Constify block argument to "callback".
7111         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7112         const.
7113         (find_pc_sect_compunit_symtab): Make "b" const.
7114         (find_symbol_at_address): Likewise.
7115         (search_symbols): Likewise.
7116         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7117         (dw2_debug_names_lookup_symbol): Likewise.
7118         (dw2_map_matching_symbols): Update.
7119         * p-valprint.c (pascal_val_print): Remove "block".
7120         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7121         (aux_add_nonlocal_symbols): Make "block" const.
7122         (resolve_subexp): Remove cast.
7123         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7124         const.
7125         (iterate_over_file_blocks): Likewise.
7126         * f-exp.y (%union) <bval>: Remove.
7127         * coffread.c (patch_opaque_types): Make "b" const.
7128         * spu-tdep.c (spu_catch_start): Make "block" const.
7129         * c-valprint.c (print_unpacked_pointer): Remove "block".
7130         * symmisc.c (dump_symtab_1): Make "b" const.
7131         (block_depth): Make "block" const.
7132         * d-exp.y (%union) <bval>: Remove.
7133         * cp-support.h (cp_lookup_rtti_type): Update.
7134         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7135         * psymtab.c (psym_lookup_symbol): Make "block" const.
7136         (maintenance_check_psymtabs): Make "b" const.
7137         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7138         (enumerate_locals, enumerate_args): Update.
7139         * python/py-symtab.c (stpy_global_block): Make "block" const.
7140         (stpy_static_block): Likewise.
7141         * inline-frame.c (block_starting_point_at): Make "new_block"
7142         const.
7143         * block.c (find_block_in_blockvector): Make return type const.
7144         (blockvector_for_pc_sect): Make "b" const.
7145         (find_block_in_blockvector): Make "b" const.
7146
7147 2019-03-23  Tom Tromey  <tom@tromey.com>
7148
7149         * varobj.c (varobj_create): Update.
7150         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7151         * printcmd.c (display_command, do_one_display): Don't reset
7152         innermost_block.
7153         * parser-defs.h (enum innermost_block_tracker_type): Move to
7154         expression.h.
7155         (innermost_block): Update comment.
7156         * parse.c (parse_exp_1): Add tracker_types parameter.
7157         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7158         tracker_types parameter.  Reset innermost_block.
7159         (parse_exp_in_context): Remove.
7160         (parse_expression_for_completion): Update.
7161         * objfiles.c (~objfile): Don't reset expression_context_block or
7162         innermost_block.
7163         * expression.h (enum innermost_block_tracker_type): Move from
7164         parser-defs.h.
7165         (parse_exp_1): Add tracker_types parameter.
7166         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7167         reset innermost_block.
7168
7169 2019-03-23  Tom Tromey  <tom@tromey.com>
7170
7171         * objfiles.h: Include bcache.h.
7172
7173 2019-03-23  Tom Tromey  <tom@tromey.com>
7174
7175         * linespec.c (get_current_search_block): Use
7176         scoped_restore_current_language.
7177         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7178
7179 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7180             Jiong Wang  <jiong.wang@arm.com>
7181
7182         * aarch64-linux-tdep.c
7183         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7184         section.
7185         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7186
7187 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7188             Jiong Wang  <jiong.wang@arm.com>
7189
7190         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7191         instructions.
7192         (aarch64_analyze_prologue_test): Add PACIASP test.
7193         (aarch64_prologue_prev_register): Unmask PC value.
7194
7195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7196             Jiong Wang  <jiong.wang@arm.com>
7197
7198         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7199         (aarch64_dwarf2_prev_register): Unmask PC value.
7200         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7201         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7202         DW_CFA_AARCH64_negate_ra_state.
7203         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7204
7205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7206             Jiong Wang  <jiong.wang@arm.com>
7207
7208         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7209         registers.
7210         (aarch64_pseudo_register_name): Likewise.
7211         (aarch64_pseudo_register_type): Likewise.
7212         (aarch64_pseudo_register_reggroup_p): Likewise.
7213         (aarch64_gdbarch_init): Add pauth registers.
7214         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7215         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7216         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7217         (struct gdbarch_tdep): Add regnum for ra_state.
7218
7219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7220             Jiong Wang  <jiong.wang@arm.com>
7221
7222         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7223
7224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7225             Jiong Wang  <jiong.wang@arm.com>
7226
7227         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7228         function.
7229         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7230         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7231         (aarch64_gdbarch_init): Add puth registers.
7232         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7233         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7234         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7235
7236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7237             Jiong Wang  <jiong.wang@arm.com>
7238
7239         * aarch64-linux-nat.c
7240         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7241         * aarch64-linux-tdep.c
7242         (aarch64_linux_core_read_description): Likewise.
7243         (aarch64_linux_get_hwcap): New function.
7244         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7245         (aarch64_linux_get_hwcap): New declaration.
7246
7247 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7248             Jiong Wang  <jiong.wang@arm.com>
7249
7250         * aarch64-linux-nat.c
7251         (aarch64_linux_nat_target::read_description): Add pauth param.
7252         * aarch64-linux-tdep.c
7253         (aarch64_linux_core_read_description): Likewise.
7254         * aarch64-tdep.c (struct target_desc): Add in pauth.
7255         (aarch64_read_description): Add pauth param.
7256         (aarch64_gdbarch_init): Likewise.
7257         * aarch64-tdep.h (aarch64_read_description): Likewise.
7258         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7259         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7260         * features/Makefile: Add new files.
7261         * features/aarch64-pauth.c: New file.
7262         * features/aarch64-pauth.xml: New file.
7263
7264 2019-03-20  Tom Tromey  <tromey@adacore.com>
7265
7266         * infrun.c (handle_inferior_event): Rename from
7267         handle_inferior_event_1.  Create a scoped_value_mark.
7268         (handle_inferior_event): Remove.
7269
7270 2019-03-19  Tom Tromey  <tromey@adacore.com>
7271
7272         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7273         * infrun.h (print_stop_event): Add "displays" parameter.
7274         * infrun.c (print_stop_event): Add "displays" parameter.
7275
7276 2019-03-19  Pedro Alves  <palves@redhat.com>
7277
7278         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7279         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7280         to -1.  Fix TABs vs spaces.
7281         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7282         * tui/tui-out.h (tui_ui_out) Add intro comments.
7283         <m_line, m_start_of_line>: In-class initialize, and add describing
7284         comment.
7285
7286 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7287
7288         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7289         variable names.
7290         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7291
7292 2019-03-18  Pedro Alves  <palves@redhat.com>
7293             Eli Zaretskii <eliz@gnu.org>
7294
7295         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7296         m_line and m_start_of_line.
7297
7298 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7299
7300         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7301         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7302         it returns a newline.  This fixes a regression in TU mode, whereby
7303         the next line is output on the same screen line as the user input.
7304
7305 2019-03-18  Tom Tromey  <tromey@adacore.com>
7306
7307         * minsyms.c (minimal_symbol_reader::install): Remove call to
7308         obstack_blank.
7309
7310 2019-03-18  Pedro Alves  <palves@redhat.com>
7311
7312         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7313         New globals.
7314         (apply_style): New, factored out from ...
7315         (apply_ansi_escape): ... this.  Handle reverse video mode.
7316         (tui_set_reverse_mode): New function.
7317         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7318         * tui/tui-winsource.c (tui_show_source_line): Use
7319         tui_set_reverse_mode instead of setting A_STANDOUT.
7320         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7321         New setter methods.
7322
7323 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7324
7325         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7326         Handle tabs.
7327
7328 2019-03-18  Tom Tromey  <tromey@adacore.com>
7329
7330         * ada-lang.c (empty_array): Add "high" parameter.
7331         (ada_evaluate_subexp): Update.
7332
7333 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7334
7335         * unittests/string_view-selftests.c: Define
7336         _initialize_string_view_selftests unconditionally.
7337
7338 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7339
7340         PR gdb/24350
7341         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7342
7343 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7344
7345         PR gdb/24351
7346         * windows-nat.c (display_selector): Fix format specifiers.
7347
7348 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7349
7350         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7351         tui_refill_source_window instead of tui_refresh_win, to update the
7352         current execution line.  This fixes redisplay of the current line
7353         when stepping through the code with "next" or "step".
7354
7355 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7356
7357         * source-cache.c (source_cache::get_source_lines): Call
7358         find_source_lines to initialize s->nlines.  This fixes vertical
7359         scrolling of TUI source window when the DOWN arrow is pressed.
7360
7361 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7362
7363         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7364         linux-thread-db.c (_initialize_thread_db): Likewise.
7365
7366 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7367
7368         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7369         wclrtoeol in tui_show_source_line".  This reverts changes made in
7370         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7371
7372 2019-03-15  Tom Tromey  <tom@tromey.com>
7373
7374         * symtab.h (struct minimal_symbol): Derive from
7375         general_symbol_info.
7376         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7377         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7378         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7379         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7380         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7381         (MSYMBOL_SEARCH_NAME): Update.
7382         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7383         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7384         * minsyms.c (minimal_symbol_reader::record_full): Update.
7385
7386 2019-03-15  Tom Tromey  <tom@tromey.com>
7387
7388         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7389
7390 2019-03-15  Tom Tromey  <tom@tromey.com>
7391
7392         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7393         unique_xmalloc_ptr.
7394         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7395         Update.
7396         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7397         (build_minimal_symbol_hash_tables)
7398         (minimal_symbol_reader::install): Update.
7399
7400 2019-03-15  Tom Tromey  <tom@tromey.com>
7401
7402         * symtab.c (create_demangled_names_hash): Update.
7403         (symbol_set_names): Update.
7404         * objfiles.h (struct objfile_per_bfd_storage)
7405         <demangled_names_hash>: Now an htab_up.
7406         * objfiles.c (objfile_per_bfd_storage): Simplify.
7407
7408 2019-03-15  Tom Tromey  <tom@tromey.com>
7409
7410         * objfiles.h (struct objfile_per_bfd_storage): Declare
7411         destructor.
7412         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7413         New.
7414         (get_objfile_bfd_data): Use new.  Don't initialize
7415         language_of_main.
7416         (free_objfile_per_bfd_storage): Remove.
7417         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7418
7419 2019-03-15  Tom Tromey  <tom@tromey.com>
7420
7421         * symfile.c (reread_symbols): Update.
7422         * objfiles.c (objfile::objfile): Update.
7423         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7424         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7425         comment.
7426         (minimal_symbol_reader::install): Update.
7427         (terminate_minimal_symbol_table): Remove.
7428         * jit.c (jit_object_close_impl): Update.
7429
7430 2019-03-15  Tom Tromey  <tom@tromey.com>
7431
7432         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7433         initializations.
7434
7435 2019-03-15  Tom Tromey  <tom@tromey.com>
7436
7437         * objfiles.h (struct objfile_per_bfd_storage)
7438         <demangled_hash_languages>: Now a bitset.
7439         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7440         (lookup_minimal_symbol): Update.
7441
7442 2019-03-15  Tom Tromey  <tom@tromey.com>
7443
7444         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7445         Don't return the symbol.
7446         * coffread.c (record_minimal_symbol): Use record_full.
7447
7448 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7449
7450         The MS-Windows port of ncurses fails to switch to a color pair if
7451         one or both of the colors are the implicit default colors.  This
7452         change records the default colors when TUI is initialized, and
7453         then specifies them explicitly when a color pair uses the default
7454         colors.  This allows color styling in TUI mode on MS-Windows.
7455
7456         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7457         ncurses_norm_attr.
7458         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7459         colors in ncurses_norm_attr.
7460         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7461         "none", replace it with the default color recorded in
7462         ncurses_norm_attr.
7463
7464 2019-03-14  Tom Tromey  <tromey@adacore.com>
7465
7466         * source-cache.h (class source_cache) <get_source_lines>: Return
7467         std::string.
7468         * source-cache.c (source_cache::extract_lines): Handle case where
7469         first_pos==npos.  Return std::string.
7470         (source_cache::get_source_lines): Update.
7471
7472 2019-03-14  Tom Tromey  <tromey@adacore.com>
7473
7474         * NEWS: Add item for "style sources" commands.
7475         * source-cache.c (source_cache::get_source_lines): Check
7476         source_styling.
7477         * cli/cli-style.c (source_styling): New global.
7478         (_initialize_cli_style): Add "style sources" commands.
7479         (show_style_sources): New function.
7480         * cli/cli-style.h (source_styling): Declare.
7481
7482 2019-03-14  Pedro Alves  <palves@redhat.com>
7483             Tom Tromey  <tromey@adacore.com>
7484
7485         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7486         * tui/tui-winsource.c (tui_refill_source_window): New function,
7487         from...
7488         (tui_horizontal_source_scroll): ... here.  Move some logic.
7489         * cli/cli-style.c (set_style_enabled): Notify new observable.
7490         * tui/tui-hooks.c (tui_redisplay_source): New function.
7491         (tui_attach_detach_observers): Attach or detach
7492         tui_redisplay_source.
7493         * observable.h (source_styling_changed): New observable.
7494         * observable.c: Define source_styling_changed observable.
7495
7496 2019-03-13  Tom Tromey  <tromey@adacore.com>
7497
7498         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7499         (i386_gnu_nat_target::store_registers): Update.
7500         * target-debug.h (target_debug_print_std_string): New macro.
7501         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7502         * windows-tdep.c (display_one_tib): Update.
7503         * tui/tui-stack.c (tui_make_status_line): Update.
7504         * top.c (print_inferior_quit_action): Update.
7505         * thread.c (thr_try_catch_cmd): Update.
7506         (add_thread_with_info): Update.
7507         (thread_target_id_str): Update.
7508         (thr_try_catch_cmd): Update.
7509         (thread_command): Update.
7510         (thread_find_command): Update.
7511         * record-btrace.c (record_btrace_target::info_record)
7512         (record_btrace_resume_thread, record_btrace_target::resume)
7513         (record_btrace_cancel_resume, record_btrace_step_thread)
7514         (record_btrace_target::wait, record_btrace_target::wait)
7515         (record_btrace_target::wait, record_btrace_target::stop): Update.
7516         * progspace.c (print_program_space): Update.
7517         * process-stratum-target.c
7518         (process_stratum_target::thread_address_space): Update.
7519         * linux-fork.c (linux_fork_mourn_inferior)
7520         (detach_checkpoint_command, info_checkpoints_command)
7521         (linux_fork_context): Update.
7522         (linux_fork_detach): Update.
7523         (class scoped_switch_fork_info): Update.
7524         (delete_checkpoint_command): Update.
7525         * infrun.c (follow_fork_inferior): Update.
7526         (follow_fork_inferior): Update.
7527         (proceed_after_vfork_done): Update.
7528         (handle_vfork_child_exec_or_exit): Update.
7529         (follow_exec): Update.
7530         (displaced_step_prepare_throw): Update.
7531         (displaced_step_restore): Update.
7532         (start_step_over): Update.
7533         (resume_1): Update.
7534         (clear_proceed_status_thread): Update.
7535         (proceed): Update.
7536         (print_target_wait_results): Update.
7537         (do_target_wait): Update.
7538         (context_switch): Update.
7539         (stop_all_threads): Update.
7540         (restart_threads): Update.
7541         (finish_step_over): Update.
7542         (handle_signal_stop): Update.
7543         (switch_back_to_stepped_thread): Update.
7544         (keep_going_pass_signal): Update.
7545         (print_exited_reason): Update.
7546         (normal_stop): Update.
7547         * inferior.c (inferior_pid_to_str): Change return type.
7548         (print_selected_inferior): Update.
7549         (add_inferior): Update.
7550         (detach_inferior): Update.
7551         * dummy-frame.c (fprint_dummy_frames): Update.
7552         * dcache.c (dcache_info_1): Update.
7553         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7554         (btrace_fetch, btrace_clear): Update.
7555         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7556         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7557         type.
7558         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7559         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7560         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7561         * gdbarch.c, gdbarch.h: Rebuild.
7562         * gdbarch.sh (core_pid_to_str): Change return type.
7563         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7564         return type.
7565         (windows_nat_target::pid_to_str): Change return type.
7566         (windows_delete_thread): Update.
7567         (windows_nat_target::attach): Update.
7568         (windows_nat_target::files_info): Update.
7569         * target-delegates.c: Rebuild.
7570         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7571         return type.
7572         (sol_thread_target::pid_to_str): Change return type.
7573         * remote.c (class remote_target) <pid_to_str>: Change return
7574         type.
7575         (remote_target::pid_to_str): Change return type.
7576         (extended_remote_target::attach, remote_target::remote_stop_ns)
7577         (remote_target::remote_notif_remove_queued_reply)
7578         (remote_target::push_stop_reply, remote_target::disable_btrace):
7579         Update.
7580         (extended_remote_target::attach): Update.
7581         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7582         type.
7583         (gdbsim_target::pid_to_str): Change return type.
7584         * ravenscar-thread.c (struct ravenscar_thread_target)
7585         <pid_to_str>: Change return type.
7586         (ravenscar_thread_target::pid_to_str): Change return type.
7587         * procfs.c (class procfs_target) <pid_to_str>: Change return
7588         type.
7589         (procfs_target::pid_to_str): Change return type.
7590         (procfs_target::attach): Update.
7591         (procfs_target::detach): Update.
7592         (procfs_target::fetch_registers): Update.
7593         (procfs_target::store_registers): Update.
7594         (procfs_target::wait): Update.
7595         (procfs_target::files_info): Update.
7596         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7597         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7598         return type.
7599         (nto_procfs_target::pid_to_str): Change return type.
7600         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7601         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7602         return type.
7603         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7604         (exit_lwp): Update.
7605         (attach_proc_task_lwp_callback, get_detach_signal)
7606         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7607         (linux_nat_target::resume, wait_lwp, stop_callback)
7608         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7609         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7610         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7611         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7612         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7613         type.
7614         (inf_ptrace_target::attach): Update.
7615         (inf_ptrace_target::files_info): Update.
7616         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7617         type.
7618         (go32_nat_target::pid_to_str): Change return type.
7619         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7620         (gnu_nat_target::wait): Update.
7621         (gnu_nat_target::wait): Update.
7622         (gnu_nat_target::resume): Update.
7623         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7624         (fbsd_nat_target::wait): Update.
7625         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7626         type.
7627         (darwin_nat_target::attach): Update.
7628         * corelow.c (class core_target) <pid_to_str>: Change return type.
7629         (core_target::pid_to_str): Change return type.
7630         * target.c (normal_pid_to_str): Change return type.
7631         (default_pid_to_str): Likewise.
7632         (target_pid_to_str): Change return type.
7633         (target_translate_tls_address): Update.
7634         (target_announce_detach): Update.
7635         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7636         return type.
7637         (bsd_uthread_target::pid_to_str): Change return type.
7638         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7639         type.
7640         (bsd_kvm_target::pid_to_str): Change return type.
7641         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7642         return type.
7643         (aix_thread_target::pid_to_str): Change return type.
7644         * target.h (struct target_ops) <pid_to_str>: Change return type.
7645         (target_pid_to_str, normal_pid_to_str): Likewise.
7646         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7647         type.
7648         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7649         type.
7650         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7651         return type.
7652         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7653         type.
7654         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7655         type.
7656         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7657         return type.
7658
7659 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7660
7661         * NEWS: Mention that the new default MI version is 3.  Mention
7662         changes to the output of commands and events that deal with
7663         multi-location breakpoints.
7664         * breakpoint.c: Include "mi/mi-out.h".
7665         (print_one_breakpoint): Change output syntax if using MI version
7666         >= 3.
7667         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7668         New.
7669         (mi_multi_location_breakpoint_output_fixed): New.
7670         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7671         (mi_cmd_fix_multi_location_breakpoint_output): New.
7672         (mi_multi_location_breakpoint_output_fixed): New.
7673         * mi/mi-cmds.c (mi_cmds): Register command
7674         -fix-multi-location-breakpoint-output.
7675         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7676         interpreter "mi".
7677
7678 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7679
7680         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7681         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7682         instantiate mi_ui_out based on interpreter name.
7683         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7684         * mi/mi-main.c (mi_load_progress): Likewise.
7685
7686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7687
7688         * NEWS: Combine separate "New targets" sections for 8.3.
7689
7690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7691
7692         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7693         (ppcfbsd_init_abi): Install gdbarch
7694         "fetch_tls_load_module_address" and "get_thread_local_address"
7695         methods.
7696
7697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7698
7699         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7700         (riscv_fbsd_init_abi): Install gdbarch
7701         "fetch_tls_load_module_address" and "get_thread_local_address"
7702         methods.
7703
7704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7705
7706         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7707         (i386fbsd_init_abi): Install gdbarch
7708         "fetch_tls_load_module_address" and "get_thread_local_address"
7709         methods.
7710
7711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7712
7713         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7714         (amd64fbsd_init_abi): Install gdbarch
7715         "fetch_tls_load_module_address" and "get_thread_local_address"
7716         methods.
7717
7718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7719
7720         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7721         (struct fbsd_pspace_data): New type.
7722         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7723         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7724         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7725         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7726         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7727
7728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7729
7730         * gdbtypes.c (lookup_struct_elt): New function.
7731         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7732         * gdbtypes.h (struct struct_elt): New type.
7733         (lookup_struct_elt): New prototype.
7734
7735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7736
7737         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7738         remove disabled code block.
7739
7740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7741
7742         * gdbarch.sh (get_thread_local_address): New method.
7743         * gdbarch.h, gdbarch.c: Regenerate.
7744         * target.c (target_translate_tls_address): Use
7745         gdbarch_get_thread_local_address if present instead of
7746         target::get_thread_local_address.
7747
7748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7749
7750         * target.h (target::get_thread_local_address): Update comment.
7751
7752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7753
7754         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7755         objfile->separate_debug_objfile_backlink if not NULL.
7756
7757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7758
7759         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7760         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7761         (amd64bsd_store_inferior_registers): Likewise.
7762         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7763         Enable segment base registers.
7764         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7765         PT_GETFSBASE and PT_GETGSBASE.
7766         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7767         PT_SETGSBASE.
7768         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7769         segment base registers.
7770         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7771
7772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7773
7774         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7775         Update calls to i386_target_description to add 'segments'
7776         parameter.
7777         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7778         add segment base registers.
7779         * arch/i386.c (i386_create_target_description): Add 'segments'
7780         parameter to enable segment base registers.
7781         * arch/i386.h (i386_create_target_description): Likewise.
7782         * features/i386/32bit-segments.xml: New file.
7783         * features/i386/32bit-segments.c: Generate.
7784         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7785         call to i386_target_description to add 'segments' parameter.
7786         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7787         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7788         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7789         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7790         if feature is present.
7791         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7792         Add 'segments' parameter to call to i386_target_description.
7793         (i386_target_description): Add 'segments' parameter to enable
7794         segment base registers.
7795         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7796         to call to i386_target_description.
7797         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7798         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7799         Define I386_NUM_REGS.
7800         (i386_target_description): Add 'segments' parameter to enable
7801         segment base registers.
7802
7803 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7804
7805         PR/24325
7806         * source-cache.c: #undef open and close, to avoid unresolved
7807         externals during linking.
7808
7809 2019-03-12  Tom Tromey  <tromey@adacore.com>
7810
7811         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7812         const.  Add initializers.
7813         (_initialize_remote): Don't initialize ptid globals.
7814
7815 2019-03-12  Pedro Alves  <palves@redhat.com>
7816
7817         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7818
7819 2019-03-12  Pedro Alves  <palves@redhat.com>
7820
7821         * cp-name-parser.y (main): Remove unused 'len' variable.
7822
7823 2019-03-12  Tom Tromey  <tromey@adacore.com>
7824
7825         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7826         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7827
7828 2019-03-12  Tom Tromey  <tromey@adacore.com>
7829
7830         * linux-nat.c (iterate_over_lwps): Update.
7831         (stop_callback): Remove parameter.
7832         (stop_wait_callback, detach_callback, resume_set_callback)
7833         (select_singlestep_lwp_callback, set_ignore_sigint)
7834         (status_callback, resumed_callback, resume_clear_callback)
7835         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7836         data parameter.
7837         (linux_nat_target::detach, linux_nat_target::resume)
7838         (linux_stop_and_wait_all_lwps, select_event_lwp)
7839         (linux_nat_filter_event, linux_nat_wait_1)
7840         (linux_nat_target::kill, linux_nat_target::stop)
7841         (linux_nat_target::stop): Update.
7842         (linux_nat_resume_callback): Change type.
7843         (resume_stopped_resumed_lwps, count_events_callback)
7844         (select_event_lwp_callback): Likewise.
7845         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7846         * arm-linux-nat.c (struct update_registers_data): Remove.
7847         (update_registers_callback): Change type.
7848         (arm_linux_insert_hw_breakpoint1): Update.
7849         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7850         parameter.
7851         (x86_linux_dr_set_addr): Update.
7852         (x86_linux_dr_set_control): Update.
7853         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7854         (iterate_over_lwps): Use gdb::function_view.
7855         * nat/aarch64-linux-hw-point.c (struct
7856         aarch64_dr_update_callback_param): Remove.
7857         (debug_reg_change_callback): Change type.
7858         (aarch64_notify_debug_reg_change): Update.
7859         * s390-linux-nat.c (s390_refresh_per_info): Update.
7860
7861 2019-03-11  Tom Tromey  <tromey@adacore.com>
7862
7863         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7864         redundant assignment to "this_cu".
7865
7866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7867
7868         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7869
7870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7871
7872         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7873         from...
7874         (rank_one_type): ... this.
7875
7876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7877
7878         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7879         from...
7880         (rank_one_type): ... this.
7881
7882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7883
7884         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7885         from...
7886         (rank_one_type): ... this.
7887
7888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7889
7890         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7891         from...
7892         (rank_one_type): ... this.
7893
7894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7895
7896         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7897         from...
7898         (rank_one_type): ... this.
7899
7900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7901
7902         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7903         from...
7904         (rank_one_type): ... this.
7905
7906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7907
7908         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7909         from...
7910         (rank_one_type): ... this.
7911
7912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7913
7914         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7915         from...
7916         (rank_one_type): ... this.
7917
7918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7919
7920         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7921         from...
7922         (rank_one_type): ... this.
7923
7924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7925
7926         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7927         from...
7928         (rank_one_type): ... this.
7929
7930 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7931
7932         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7933         from...
7934         (rank_one_type): ... this.
7935
7936 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7937
7938         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7939         from...
7940         (rank_one_type): ... this.
7941
7942 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7943
7944         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7945         inferior-events' shows the example events.
7946
7947 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7948
7949         Support styling on native MS-Windows console
7950
7951         PR/24315
7952         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7953         on MS-Windows if $TERM is not defined.
7954
7955         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7956
7957         * posix-hdep.c (gdb_console_fputs):
7958         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7959         functions.
7960         * ui-file.h (gdb_console_fputs): Add prototype.
7961
7962         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7963         back to fputs only if the former returns zero.
7964
7965 2019-03-07  Tom Tromey  <tom@tromey.com>
7966
7967         * symmisc.c (print_symbol_bcache_statistics): Update.
7968         (print_objfile_statistics): Update.
7969         * symfile.c (allocate_symtab): Update.
7970         * stabsread.c: Don't include bcache.h.
7971         * psymtab.h (struct psymbol_bcache): Don't declare.
7972         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7973         (psymbol_bcache_init, psymbol_bcache_free)
7974         (psymbol_bcache_get_bcache): Don't declare.
7975         * psymtab.c (struct psymbol_bcache): Remove.
7976         (psymtab_storage::psymtab_storage): Update.
7977         (psymtab_storage::~psymtab_storage): Update.
7978         (psymbol_bcache_init, psymbol_bcache_free)
7979         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7980         (add_psymbol_to_bcache): Update.
7981         (allocate_psymtab): Update.
7982         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7983         macro_cache>: No longer pointers.
7984         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7985         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7986         * macrotab.c (macro_bcache): Update.
7987         * macroexp.c: Don't include bcache.h.
7988         * gdbtypes.c (check_types_worklist): Update.
7989         (types_deeply_equal): Remove TRY/CATCH.  Update.
7990         * elfread.c (elf_symtab_read): Update.
7991         * dwarf2read.c: Don't include bcache.h.
7992         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7993         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7994         (print_bcache_statistics, bcache_memory_used): Don't declare.
7995         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7996         methods.  Rename all data members.
7997         * bcache.c (struct bcache): Move to bcache.h.
7998         (bcache::expand_hash_table): Rename from expand_hash_table.
7999         (bcache): Remove.
8000         (bcache::insert): Rename from bcache_full.
8001         (bcache::compare): Rename from bcache_compare.
8002         (bcache_xmalloc): Remove.
8003         (bcache::~bcache): Rename from bcache_xfree.
8004         (bcache::print_statistics): Rename from print_bcache_statistics.
8005         (bcache::memory_used): Rename from bcache_memory_used.
8006
8007 2019-03-07  Pedro Alves  <palves@redhat.com>
8008
8009         * infrun.c (normal_stop): Also check for
8010         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8011
8012 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8013
8014         * f-lang.c (value_from_host_double): Moved to...
8015         * value.c (value_from_host_double): ...here.
8016         * value.h (value_from_host_double): Declare.
8017         * guile/scm-math.c (vlscm_convert_typed_number): Use
8018         value_from_host_double.
8019         (vlscm_convert_number): Likewise.
8020         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8021         * python/py-value.c (convert_value_from_python): Likewise.
8022
8023 2019-03-06  Tom Tromey  <tom@tromey.com>
8024
8025         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8026
8027 2019-03-06  Tom Tromey  <tom@tromey.com>
8028
8029         * utils.h (free_current_contents): Don't declare.
8030         * utils.c (free_current_contents): Remove.
8031
8032 2019-03-06  Tom Tromey  <tom@tromey.com>
8033
8034         * top.c (quit_force): Update.
8035         * main.c (captured_command_loop): Update.
8036         * common/new-op.c (operator new): Update.
8037         * common/common-exceptions.c (struct catcher)
8038         <save_cleanup_chain>: Remove member.
8039         (exceptions_state_mc_init): Update.
8040         (exception_try_scope_entry): Return nullptr.
8041         (exception_try_scope_exit, exception_rethrow)
8042         (throw_exception_sjlj, throw_exception_cxx): Update.
8043         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8044         (all_cleanups, do_cleanups, discard_cleanups)
8045         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8046         (restore_cleanups, restore_final_cleanups): Don't declare.
8047         (do_final_cleanups): Remove parameter.
8048         * common/cleanups.c (cleanup_chain, make_cleanup)
8049         (make_cleanup_dtor, all_cleanups, do_cleanups)
8050         (discard_my_cleanups, discard_cleanups)
8051         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8052         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8053         (null_cleanup): Remove.
8054         (do_final_cleanups): Remove parameter.
8055
8056 2019-03-06  Tom Tromey  <tom@tromey.com>
8057
8058         * remote.c (remote_target::remote_parse_stop_reply): Use
8059         unique_xmalloc_ptr.
8060
8061 2019-03-06  Tom Tromey  <tom@tromey.com>
8062
8063         * stabsread.c (struct stabs_field_info): Rename from field_info.
8064         <list, fnlist>: Add initializers.
8065         <obstack>: New member.
8066         (read_member_functions, read_struct_fields, read_baseclasses):
8067         Allocate on obstack.  Don't use cleanups.
8068         (read_one_struct_field, read_member_functions, read_struct_fields)
8069         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8070         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8071         (read_struct_type): Update.
8072
8073 2019-03-06  Tom Tromey  <tom@tromey.com>
8074
8075         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8076         * common/filestuff.h (make_cleanup_close): Don't declare.
8077         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8078         Remove.
8079
8080 2019-03-06  Tom Tromey  <tom@tromey.com>
8081
8082         * solib-aix.c: Use make_scope_exit.
8083
8084 2019-03-06  Tom Tromey  <tom@tromey.com>
8085
8086         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8087         Use make_scope_exit.
8088
8089 2019-03-06  Tom Tromey  <tom@tromey.com>
8090
8091         * solib-svr4.c (disable_probes_interface): Remove parameter.
8092         (svr4_handle_solib_event): Use make_scope_exit.
8093
8094 2019-03-06  Tom Tromey  <tom@tromey.com>
8095
8096         * remote.c (struct stop_reply_deleter): Remove.
8097         (stop_reply_up): Update.
8098         (struct stop_reply): Derive from notif_event.  Don't typedef.
8099         <regcache>: Now a std::vector.
8100         (stop_reply_xfree): Remove.
8101         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8102         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8103         (remote_target::discard_pending_stop_replies): Use delete.
8104         (remote_target::remote_parse_stop_reply): Update.
8105         (remote_target::process_stop_reply): Update.
8106         * remote-notif.h (struct notif_event): Add virtual destructor.
8107         Remove "dtr" member.
8108         (struct notif_client) <alloc_event>: Return a unique_ptr.
8109         (notif_event_xfree): Don't declare.
8110         (notif_event_up): New typedef.
8111         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8112         (notif_event_xfree, do_notif_event_xfree): Remove.
8113         (remote_notif_state_xfree): Update.
8114
8115 2019-03-06  Tom Tromey  <tom@tromey.com>
8116
8117         * infrun.c (displaced_step_clear_cleanup): Now a
8118         forward_scope_exit type.
8119         (displaced_step_prepare_throw): Update.
8120         (displaced_step_fixup): Update.
8121
8122 2019-03-06  Tom Tromey  <tom@tromey.com>
8123
8124         * inferior.h (class inferior): Update comment.
8125         * gdbthread.h (class thread_info): Update comment.
8126
8127 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8128             Tom Tromey  <tom@tromey.com>
8129
8130         * stabsread.h (struct stab_section_list): Remove.
8131         (coffstab_build_psymtabs): Update.
8132         * dbxread.c (symbuf_sections): Now a std::vector.
8133         (sect_idx): New global.
8134         (fill_symbuf): Update.
8135         (coffstab_build_psymtabs): Change type of stabsects parameter.
8136         Update.
8137         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8138         std::vector.
8139         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8140         (coff_locate_sections): Update.
8141         (coff_symfile_read): Remove cleanups.  Update.
8142         (init_stringtab): Add storage parameter.
8143         (free_stringtab, free_stringtab_cleanup): Remove.
8144         (init_lineno): Add storage parameter.
8145         (free_linetab, free_linetab_cleanup): Remove.
8146
8147 2019-03-06  Pedro Alves  <palves@redhat.com>
8148
8149         * linux-fork.c (fork_info::clobber_regs): Delete.
8150         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8151         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8152         comment.  Adjust.
8153         (scoped_switch_fork_info::scoped_switch_fork_info)
8154         (checkpoint_command, linux_fork_context): Adjust
8155         fork_save_infrun_state calls.
8156
8157 2019-03-06  Pedro Alves  <palves@redhat.com>
8158
8159         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8160         (inf_has_multiple_threads): Return 'bool' and rewrite using
8161         inferior_info::threads().
8162
8163 2019-03-06  Pedro Alves  <palves@redhat.com>
8164
8165         * linux-fork.c: Include <list>.
8166         (fork_list): Now a std::list instance.
8167         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8168         (forks_exist_p, find_last_fork): Adjust.
8169         (new_fork): Delete.
8170         (one_fork_p): New.
8171         (add_fork): Adjust.
8172         (free_fork): Delete, folded into fork_info::~fork_info().
8173         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8174         Adjust.
8175         (init_fork_list): Delete.
8176         (linux_fork_killall, linux_fork_mourn_inferior)
8177         (linux_fork_detach, info_checkpoints_command): Adjust.
8178         (_initialize_linux_fork): No longer call init_fork_list.
8179
8180 2019-03-06  Pedro Alves  <palves@redhat.com>
8181
8182         * linux-fork.c (new_fork): New, split out of ...
8183         (add_fork): ... this.  Return void.  Move "first fork" special
8184         case from here, to ...
8185         (checkpoint_command): ... here.
8186         * linux-linux.h (add_fork): Return void.
8187
8188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8189
8190         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8191
8192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8193             Chris January  <chris.january@arm.com>
8194             David Lecomber  <david.lecomber@arm.com>
8195
8196         * f-exp.y: New token, UNOP_INTRINSIC.
8197         (exp): New pattern using UNOP_INTRINSIC token.
8198         (f77_keywords): Add 'abs' keyword.
8199         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8200         (value_from_host_double): New function.
8201         (evaluate_subexp_f): Support UNOP_ABS.
8202
8203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8204
8205         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8206         types.
8207
8208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8209
8210         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8211         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8212         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8213
8214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8215
8216         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8217
8218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8219             Chris January  <chris.january@arm.com>
8220
8221         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8222         * f-exp.y: Define 'KIND' token.
8223         (exp): New pattern for KIND expressions.
8224         (ptype): Handle types with a kind extension.
8225         (direct_abs_decl): Extend to spot kind extensions.
8226         (f77_keywords): Add 'kind' to the list.
8227         (push_kind_type): New function.
8228         (convert_to_kind_type): New function.
8229         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8230         * parse.c (operator_length_standard): Likewise.
8231         * parser-defs.h (enum type_pieces): Add tp_kind.
8232         * std-operator.def: Add UNOP_KIND.
8233
8234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8235
8236         * f-exp.y (f_parse): Set yydebug.
8237
8238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8239
8240         * f-lang.c (evaluate_subexp_f): New function.
8241         (exp_descriptor_f): New global.
8242         (f_language_defn): Use exp_descriptor_f instead of
8243         exp_descriptor_standard.
8244
8245 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8246
8247         * f-exp.y (struct token): Add comments.
8248         (dot_ops): Remove uppercase versions and the end marker.
8249         (f77_keywords): Likewise.
8250         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8251         entries in the dot_ops array are case insensitive, and use
8252         strncasecmp to compare strings.  Also some whitespace cleanup in
8253         this area.  Similar for the f77_keywords array, except entries in
8254         this list might be case sensitive.
8255
8256 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8257
8258         * f-exp.y (struct f77_boolean_val): Add comments.
8259         (boolean_values): Remove uppercase versions, and end marker.
8260         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8261         and use strncasecmp to achieve case insensitivity.  Additionally,
8262         perform whitespace cleanup around this code.
8263
8264 2019-03-06  Tom Tromey  <tromey@adacore.com>
8265
8266         * remote-sim.c (gdbsim_target_open): Use result of
8267         gdb_argv::release.
8268
8269 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8270         Dirk Schubert  <dirk.schubert@arm.com>
8271         Chris January  <chris.january@arm.com>
8272
8273         * eval.c (evaluate_subexp_standard): Call Fortran argument
8274         wrapping logic.
8275         * f-lang.c (struct value): A value which can be passed into a
8276         Fortran function call.
8277         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8278         where appropriate.
8279         (struct type): Value ready for a Fortran function call.
8280         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8281         is needed.
8282         * f-lang.h (fortran_argument_convert): Declaration.
8283         (fortran_preserve_arg_pointer): Declaration.
8284         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8285
8286 2019-03-05  Tom Tromey  <tromey@adacore.com>
8287
8288         * python/py-prettyprint.c (print_string_repr): Remove #if.
8289         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8290
8291 2019-03-05  Tom Tromey  <tromey@adacore.com>
8292
8293         * target.c (the_dummy_target): Move later.  Change type to
8294         "dummy_target".
8295         (initialize_targets): Don't initialize the_dummy_target.
8296
8297 2019-03-05  Tom Tromey  <tromey@adacore.com>
8298
8299         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8300         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8301
8302 2019-03-05  Tom Tromey  <tromey@adacore.com>
8303
8304         * windows-nat.c (windows_nat_target::attach)
8305         (windows_nat_target::detach): Don't call gdb_flush.
8306         * valprint.c (generic_val_print, val_print, val_print_string):
8307         Don't call gdb_flush.
8308         * utils.c (defaulted_query): Don't call gdb_flush.
8309         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8310         * target.c (target_announce_detach): Don't call gdb_flush.
8311         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8312         * remote.c (extended_remote_target::attach): Don't call
8313         gdb_flush.
8314         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8315         * printcmd.c (do_examine): Don't call gdb_flush.
8316         (info_display_command): Don't call gdb_flush.
8317         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8318         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8319         * memattr.c (info_mem_command): Don't call gdb_flush.
8320         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8321         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8322         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8323         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8324         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8325         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8326         (gnu_nat_target::detach): Don't call gdb_flush.
8327         * f-valprint.c (f_val_print): Don't call gdb_flush.
8328         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8329         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8330         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8331         gdb_flush.
8332         * c-valprint.c (c_val_print): Don't call gdb_flush.
8333         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8334
8335 2019-03-05  Tom Tromey  <tromey@adacore.com>
8336
8337         * varobj.c (update_dynamic_varobj_children): Update.
8338         (install_default_visualizer): Use reset, not release.
8339         * value.c (set_internalvar): Update.
8340         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8341         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8342         ATTRIBUTE_UNUSED_RESULT.
8343
8344 2019-03-05  Tom Tromey  <tromey@adacore.com>
8345
8346         * remote.c (class scoped_remote_fd) <release>: Add
8347         ATTRIBUTE_UNUSED_RESULT.
8348
8349 2019-03-05  Tom Tromey  <tromey@adacore.com>
8350
8351         * macroexp.c (struct macro_buffer) <release>: Add
8352         ATTRIBUTE_UNUSED_RESULT.
8353
8354 2019-03-05  Tom Tromey  <tromey@adacore.com>
8355
8356         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8357         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8358         ATTRIBUTE_UNUSED_RESULT.
8359
8360 2019-03-05  Tom Tromey  <tromey@adacore.com>
8361
8362         * common/scoped_fd.h (class scoped_fd) <release>: Add
8363         ATTRIBUTE_UNUSED_RESULT.
8364
8365 2019-03-05  Tom Tromey  <tromey@adacore.com>
8366
8367         * parser-defs.h (struct parser_state) <release>: Add
8368         ATTRIBUTE_UNUSED_RESULT.
8369
8370 2019-03-05  Tom Tromey  <tromey@adacore.com>
8371
8372         * utils.h (class gdb_argv) <release>: Add
8373         ATTRIBUTE_UNUSED_RESULT.
8374         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8375
8376 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8377
8378         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8379         for-loop range, to avoid compiler warnings.
8380
8381         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8382         avoid compiler warnings about unused variables.
8383
8384         * NEWS: Mention end of support for native debugging on MS-Windows
8385         before XP.
8386
8387         PR gdb/24292
8388         * common/netstuff.c:
8389         * gdbserver/gdbreplay.c
8390         * gdbserver/remote-utils.c:
8391         * ser-tcp.c:
8392         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8393         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8394         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8395         'getaddrinfo' and 'freeaddrinfo' were not available before
8396         Windows XP, and mingw.org's MinGW headers by default define
8397         _WIN32_WINNT to 0x500.
8398
8399 2019-03-01  Gary Benson <gbenson@redhat.com>
8400
8401         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8402
8403 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8404             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8405
8406         PR gdb/8527
8407         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8408         set_sigint_trap, clear_sigint_trap.
8409
8410 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8411
8412         * target.c (target_detach): Clear the regcache and the
8413         frame cache.
8414
8415 2019-02-27  Pedro Alves  <palves@redhat.com>
8416
8417         * utils.c (set_screen_size): When we cap the height/width sizes,
8418         tweak the corresponding command variable to show "unlimited":
8419
8420 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8421             Pedro Alves  <palves@redhat.com>
8422
8423         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8424         before calling rl_set_screen_size.
8425
8426 2019-02-27  Tom Tromey  <tromey@adacore.com>
8427
8428         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8429         define.
8430         * python/py-value.c: Remove Python 2.4 workaround.
8431         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8432         workaround.
8433         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8434         Python 2.4 workaround.
8435         * python/python-internal.h: Remove Python 2.4 comment.
8436         (Py_ssize_t): Don't define.
8437         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8438         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8439         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8440         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8441         * python/python.c (do_start_initialization): Remove Python 2.4
8442         workaround.
8443         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8444         (print_children): Remove Python 2.4 workaround.
8445         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8446         workaround.
8447         (CHARBUFFERPROC_NAME): Remove.
8448         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8449         Python 2.4 workaround.
8450
8451 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8452
8453         * NEWS: Note minimum Python version.
8454
8455 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8456
8457         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8458         code from these functions.  Remove corresponding ifdefs.  Use
8459         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8460         Remove gotos and target of gotos.
8461         (infpy_search_memory): Likewise.
8462
8463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8464
8465         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8466         (hppa_gdbarch_init): Don't register deleted functions with
8467         gdbarch.
8468
8469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8470
8471         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8472         (h8300_unwind_sp): Delete.
8473         (h8300_dummy_id): Delete.
8474         (h8300_gdbarch_init): Don't register deleted functions with
8475         gdbarch.
8476
8477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8478
8479         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8480         (ft32_unwind_pc): Delete.
8481         (ft32_unwind_sp): Delete.
8482         (ft32_gdbarch_init): Don't register deleted functions with
8483         gdbarch.
8484
8485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8486
8487         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8488         (frv_unwind_pc): Delete.
8489         (frv_unwind_sp): Delete.
8490         (frv_gdbarch_init): Don't register deleted functions with
8491         gdbarch.
8492
8493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8494
8495         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8496         (riscv_unwind_pc): Delete.
8497         (riscv_unwind_sp): Delete.
8498         (riscv_gdbarch_init): Don't register deleted functions with
8499         gdbarch.
8500
8501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8502
8503         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8504         (csky_unwind_pc): Delete.
8505         (csky_unwind_sp): Delete.
8506         (csky_gdbarch_init): Don't register deleted functions with
8507         gdbarch.
8508
8509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8510
8511         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8512         (cris_unwind_pc): Delete.
8513         (cris_unwind_sp): Delete.
8514         (cris_gdbarch_init): Don't register deleted functions with
8515         gdbarch.
8516
8517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8518
8519         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8520         (bfin_unwind_pc): Delete.
8521         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8522
8523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8524
8525         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8526         (arm_unwind_pc): Delete.
8527         (arm_unwind_sp): Delete.
8528         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8529
8530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8531
8532         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8533         (arc_unwind_pc): Delete.
8534         (arc_unwind_sp): Delete.
8535         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8536
8537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8538
8539         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8540         (alpha_unwind_pc): Delete.
8541         (alpha_gdbarch_init): Don't register deleted functions with
8542         gdbarch.
8543
8544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8545
8546         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8547         (aarch64_unwind_pc): Delete.
8548         (aarch64_unwind_sp): Delete.
8549         (aarch64_gdbarch_init): Don't register deleted functions with
8550         gdbarch.
8551
8552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8553
8554         * gdbtypes.c (type_align): Don't consider static members when
8555         computing structure alignment.
8556
8557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8558
8559         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8560         return 0 for other types.
8561         * arch-utils.c (default_type_align): Always return 0.
8562         * gdbarch.h: Regenerate.
8563         * gdbarch.sh (type_align): Extend comment.
8564         * gdbtypes.c (type_align): Add additional comments, always call
8565         gdbarch_type_align before applying the default rules.
8566         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8567         generic code will then apply a suitable default.
8568         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8569         types, return 0 for other types.
8570
8571 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8572
8573         * NEWS: Create a new section for the next release branch.
8574         Rename the section of the current branch, now that it has
8575         been cut.
8576
8577 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8578
8579         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8580         * version.in: Bump version to 8.3.50.DATE-git.
8581
8582 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8583
8584         * aix-thread.c (ptid_cmp): Remove unused variable.
8585         (get_signaled_thread): Likewise.
8586         (store_regs_user_thread): Likewise.
8587         (store_regs_kernel_thread): Likewise.
8588         (fetch_regs_kernel_thread): Remove shadowed variable.
8589
8590 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8591
8592         * features/riscv/32bit-cpu.xml: Add register numbers.
8593         * features/riscv/32bit-fpu.c: Regenerate.
8594         * features/riscv/32bit-fpu.xml: Add register numbers.
8595         * features/riscv/64bit-cpu.xml: Add register numbers.
8596         * features/riscv/64bit-fpu.c: Regenerate.
8597         * features/riscv/64bit-fpu.xml: Add register numbers.
8598
8599 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8600
8601         * NEWS: Mention two argument form of gdb.Value constructor.
8602         * python/py-value.c (convert_buffer_and_type_to_value): New
8603         function.
8604         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8605         Add support for handling an optional second argument.  Call
8606         convert_buffer_and_type_to_value as appropriate.
8607         * python/python-internal.h (Py_buffer_deleter): New struct.
8608         (Py_buffer_up): New typedef.
8609
8610 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8611
8612         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8613         instead of releasing ownership.
8614
8615 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8616
8617         * dwarf2read.c (open_and_init_dwp_file): Call
8618         elf_numsections instead of bfd_count_sections to initialize
8619         dwp_file->num_sections.
8620
8621 2019-02-25  Tom Tromey  <tromey@adacore.com>
8622
8623         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8624
8625 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8626
8627         * gcore.in: Add '--readnever' option when invoking GDB.
8628
8629 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8630
8631         * MAINTAINERS: Update my email address.
8632
8633 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8634
8635         * build-id.c (build_id_to_debug_bfd_1): New function.
8636         (build_id_to_debug_bfd): Look for separate debug file in
8637         sysroot.
8638
8639 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8640
8641         * gdbarch.sh: Update the copyright year range that is placed into
8642         generated files.
8643
8644 2019-02-22  Keith Seitz  <keiths@redhat.com>
8645
8646         PR symtab/23853
8647         * linespec.c (create_sals_line_offset): Search for the default
8648         symtab's filename instead of its fullname.
8649
8650 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8651
8652         * NEWS: Update style defaults.
8653
8654 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8655
8656         * main.c (captured_main_1): Disable styling in batch mode.
8657
8658 2019-02-20  Tom Tromey  <tom@tromey.com>
8659
8660         * symtab.c (symtab_symbol_info): Fix typos.
8661
8662 2019-02-20  Tom Tromey  <tromey@adacore.com>
8663
8664         * findcmd.c (_initialize_mem_search): Use upper case for
8665         metasyntactic variables.
8666
8667 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8668
8669         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8670         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8671
8672 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8673
8674         * top.h (source_file_name): Change to std::string.
8675         * top.c (source_file_name): Likewise.
8676         (command_line_input): Adjust.
8677         * cli/cli-script.c (script_from_file): Adjust.
8678
8679 2019-02-19  Tom Tromey  <tromey@adacore.com>
8680
8681         * ravenscar-thread.c
8682         (ravenscar_thread_target::update_thread_list): Don't call
8683         ada_build_task_list.
8684         * ada-lang.h (ada_build_task_list): Don't declare.
8685         * ada-tasks.c (struct ada_tasks_inferior_data)
8686         <task_list_valid_p>: Now bool.
8687         (read_known_tasks, ada_task_list_changed)
8688         (ada_tasks_invalidate_inferior_data): Update.
8689         (read_known_tasks_array): Return bool.
8690         (read_known_tasks_list): Likewise.
8691         (read_known_tasks): Return void.
8692         (ada_build_task_list): Now static.
8693
8694 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8695
8696         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8697         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8698
8699 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8700
8701         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8702         variant for ada_tasks_pspace_data_handle and
8703         ada_tasks_inferior_data_handle.
8704         (ada_tasks_pspace_data_cleanup): New function.
8705         (ada_tasks_inferior_data_cleanup): New function.
8706
8707 2019-02-17  Tom Tromey  <tom@tromey.com>
8708
8709         * macrotab.h (macro_source_fullname): Return a std::string.
8710         * macrotab.c (macro_include, check_for_redefinition)
8711         (macro_undef, macro_lookup_definition, foreach_macro)
8712         (foreach_macro_in_scope): Update.
8713         (macro_source_fullname): Return a std::string.
8714         * macrocmd.c (show_pp_source_pos): Update.
8715
8716 2019-02-17  Tom Tromey  <tom@tromey.com>
8717
8718         * macrocmd.c (show_pp_source_pos): Style the file names.
8719
8720 2019-02-17  Tom Tromey  <tom@tromey.com>
8721
8722         PR tui/24197:
8723         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8724
8725 2019-02-17  Tom Tromey  <tom@tromey.com>
8726
8727         * ada-lang.c (user_select_syms): Use filtered printing.
8728         * utils.c (wrap_style): New global.
8729         (desired_style): Remove.
8730         (emit_style_escape): Add stream parameter.
8731         (set_output_style, reset_terminal_style, prompt_for_continue):
8732         Update.
8733         (flush_wrap_buffer): Only flush gdb_stdout.
8734         (wrap_here): Set wrap_style.
8735         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8736         treat escape sequences as a character.  Change when wrap buffer is
8737         flushed.
8738         (fputs_styled): Do not set the output style when the default is
8739         requested.
8740         * ui-style.h (struct ui_file_style) <is_default>: New method.
8741         * source.c (print_source_lines_base): Emit escape sequences in one
8742         piece.
8743
8744 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8745
8746         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8747         integers and enumeration types.
8748
8749 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8750
8751         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8752         instead of lookup_symbol_in_language
8753         (do_exact_match): New function.
8754         (ada_get_symbol_name_matcher): Return do_exact_match when
8755         doing a verbatim match.
8756
8757 2019-02-15  Tom Tromey  <tromey@adacore.com>
8758
8759         * ravenscar-thread.c (ravenscar_thread_target::resume)
8760         (ravenscar_thread_target::wait): Special case wildcard requests.
8761
8762 2019-02-15  Tom Tromey  <tromey@adacore.com>
8763
8764         * ravenscar-thread.c (base_ptid): Remove.
8765         (struct ravenscar_thread_target) <close>: New method.
8766         <m_base_ptid>: New member.
8767         <update_inferior_ptid, active_task, task_is_currently_active,
8768         runtime_initialized>: Declare methods.
8769         <ravenscar_thread_target>: Add constructor.
8770         (ravenscar_thread_target::task_is_currently_active)
8771         (ravenscar_thread_target::update_inferior_ptid)
8772         (ravenscar_runtime_initialized): Rename.  Now methods.
8773         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8774         (ravenscar_thread_target::update_thread_list): Update.
8775         (ravenscar_thread_target::active_task): Now method.
8776         (ravenscar_thread_target::store_registers)
8777         (ravenscar_thread_target::prepare_to_store)
8778         (ravenscar_thread_target::prepare_to_store)
8779         (ravenscar_thread_target::mourn_inferior): Update.
8780         (ravenscar_inferior_created): Use "new" to create target.
8781         (ravenscar_thread_target::get_ada_task_ptid): Update.
8782         (_initialize_ravenscar): Don't initialize base_ptid.
8783         (ravenscar_ops): Remove global.
8784
8785 2019-02-15  Tom Tromey  <tromey@adacore.com>
8786
8787         * target.h (push_target): Declare new overload.
8788         * target.c (push_target): New overload, taking an rvalue reference.
8789         * remote.c (remote_target::open_1): Use push_target overload.
8790         * corelow.c (core_target_open): Use push_target overload.
8791
8792 2019-02-15  Tom Tromey  <tromey@adacore.com>
8793
8794         * ravenscar-thread.c (is_ravenscar_task)
8795         (ravenscar_task_is_currently_active): Return bool.
8796         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8797         (_initialize_ravenscar): Remove "(void)".
8798         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8799         Return bool.
8800
8801 2019-02-15  Tom Tromey  <tromey@adacore.com>
8802
8803         * ravenscar-thread.c (ravenscar_runtime_initializer)
8804         (has_ravenscar_runtime, get_running_thread_id)
8805         (ravenscar_thread_target::resume): Fix indentation.
8806
8807 2019-02-15  Tom Tromey  <tromey@adacore.com>
8808
8809         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8810         from ravenscar_arch_ops.
8811         (sparc_ravenscar_ops::fetch_registers)
8812         (sparc_ravenscar_ops::store_registers): Now methods.
8813         (sparc_ravenscar_prepare_to_store): Remove.
8814         (sparc_ravenscar_ops): Redefine.
8815         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8816         methods and destructor.  Remove members.
8817         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8818         (ravenscar_thread_target::store_registers)
8819         (ravenscar_thread_target::prepare_to_store): Update.
8820         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8821         Remove.
8822         (struct ppc_ravenscar_powerpc_ops): Derive from
8823         ravenscar_arch_ops.
8824         (ppc_ravenscar_powerpc_ops::fetch_registers)
8825         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8826         (ppc_ravenscar_powerpc_ops): Redefine.
8827         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8828         (ppc_ravenscar_e500_ops::fetch_registers)
8829         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8830         (ppc_ravenscar_e500_ops): Redefine.
8831         * aarch64-ravenscar-thread.c
8832         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8833         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8834         (aarch64_ravenscar_fetch_registers)
8835         (aarch64_ravenscar_store_registers): Now methods.
8836         (aarch64_ravenscar_ops): Redefine.
8837
8838 2019-02-15  Tom Tromey  <tromey@adacore.com>
8839
8840         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8841         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8842         (ravenscar_thread_target::stopped_by_watchpoint)
8843         (ravenscar_thread_target::stopped_data_address)
8844         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8845
8846 2019-02-15  Tom Tromey  <tromey@adacore.com>
8847
8848         * ravenscar-thread.c: Fix some typos.
8849
8850 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8851             Tom Tromey  <tromey@adacore.com>
8852
8853         * ada-lang.c (ada_exception_sal): Change addr_string to a
8854         std::string.
8855         (create_ada_exception_catchpoint): Update.
8856
8857 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8858             Tom Tromey  <tromey@adacore.com>
8859
8860         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8861         (bp_location_ops): Remove.
8862         (base_breakpoint_allocate_location): Update.
8863         (free_bp_location): Update.
8864         * ada-lang.c (class ada_catchpoint_location)
8865         <ada_catchpoint_location>: Remove ops parameter.
8866         (ada_catchpoint_location_dtor): Remove.
8867         (ada_catchpoint_location_ops): Remove.
8868         (allocate_location_exception): Update.
8869         * breakpoint.h (struct bp_location_ops): Remove.
8870         (class bp_location) <bp_location>: Remove bp_location_ops
8871         parameter.
8872         <~bp_location>: Add destructor.
8873         <ops>: Remove.
8874
8875 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8876             Pedro Alves  <palves@redhat.com>
8877
8878         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8879         'PATH_MAX'.
8880
8881 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8882             Samuel Thibault  <samuel.thibault@gnu.org>
8883             Thomas Schwinge  <thomas@codesourcery.com>
8884
8885         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8886         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8887
8888 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8889
8890         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8891         (check_empty): Use "const char *".
8892
8893         * gnu-nat.c (gnu_nat_target::detach): Instead of
8894         'detach_inferior (pid)' call
8895         'detach_inferior (find_inferior_pid (pid))'.
8896
8897         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8898         'nat/fork-inferior.o'.
8899         * gnu-nat.c: #include "nat/fork-inferior.h".
8900
8901         * gnu-nat.c (gnu_nat_target::detach): Instead of
8902         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8903         * gnu-nat.h: #include "inf-child.h".
8904         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8905         'i386_gnu_nat_target::fetch_registers'.
8906         (gnu_store_registers): Rename/move to
8907         'i386_gnu_nat_target::store_registers'.
8908
8909         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8910         * gnu-nat.h (mach_thread_info): New function.
8911         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8912
8913         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8914
8915 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8916
8917         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8918
8919 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8920
8921         * windows-nat.c (windows_add_thread): Add new parameter
8922         "main_thread_p" with default value set to false.  Update
8923         function documentation as well as all callers.
8924         (windows_delete_thread): Likewise.
8925         (fake_create_process): Update call to windows_add_thread.
8926         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8927         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8928         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8929         call to windows_delete_thread.
8930
8931 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8932
8933         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8934
8935 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8936
8937         * symfile.c (find_separate_debug_file): Use canonical path of
8938         sysroot with child_path instead of gdb_sysroot if it is valid.
8939
8940 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8941
8942         * symfile.c (find_separate_debug_file): Use child_path to
8943         determine if an object file is under a sysroot.
8944
8945 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8946
8947         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8948         unittests/child-path-selftests.c.
8949         * common/pathstuff.c (child_path): New function.
8950         * common/pathstuff.h (child_path): New prototype.
8951         * unittests/child-path-selftests.c: New file.
8952
8953 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8954
8955         * symfile.c (find_separate_debug_file): Look for separate debug
8956         files in debug directories under the sysroot.
8957
8958 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8959
8960         * symtab.h (struct minimal_symbol data_p): New const method.
8961         (struct minimal_symbol text_p): Likewise.
8962         * symtab.c (output_source_filename): Use file name style
8963         to print file name.
8964         (print_symbol_info): Likewise.
8965         (print_msymbol_info): Use address style to print addresses.
8966         Use function name style to print executable text symbols.
8967         (expand_symtab_containing_pc): Use data_p.
8968         (find_pc_sect_compunit_symtab): Likewise.
8969
8970 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8971
8972         * breakpoint.c (describe_other_breakpoints): Use address style
8973         to print addresses.
8974         (say_where): Likewise.
8975
8976 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8977
8978         * ada-typeprint.c (print_func_type): Print function name
8979         style to print function name.
8980         * c-typeprint.c (c_print_type_1): Likewise.
8981
8982 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8983
8984         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8985         for execve.
8986
8987 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8988
8989         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8990         type_stack.
8991
8992 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8993
8994         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8995         TYPE_CODE_REF types.
8996
8997 2019-02-08  Jim Wilson  <jimw@sifive.com>
8998
8999         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9000         (riscv_linux_fregset): New.
9001         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9002
9003 2019-02-07  Tom Tromey  <tom@tromey.com>
9004
9005         * thread.c (thread_cancel_execution_command): Update.
9006         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9007         methods.
9008         (struct thread_fsm_ops): Remove.
9009         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9010         (thread_fsm_should_stop, thread_fsm_return_value)
9011         (thread_fsm_set_finished, thread_fsm_finished_p)
9012         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9013         Don't declare.
9014         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9015         * infrun.c (clear_proceed_status_thread)
9016         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9017         (print_stop_event): Update.
9018         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9019         Add constructor.
9020         (step_command_fsm_ops): Remove.
9021         (new_step_command_fsm): Remove.
9022         (step_1): Update.
9023         (step_command_fsm::should_stop): Rename from
9024         step_command_fsm_should_stop.
9025         (step_command_fsm::clean_up): Rename from
9026         step_command_fsm_clean_up.
9027         (step_command_fsm::do_async_reply_reason): Rename from
9028         step_command_fsm_async_reply_reason.
9029         (struct until_next_fsm): Inherit from thread_fsm.  Add
9030         constructor.
9031         (until_next_fsm_ops): Remove.
9032         (new_until_next_fsm): Remove.
9033         (until_next_fsm::should_stop): Rename from
9034         until_next_fsm_should_stop.
9035         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9036         (until_next_fsm::do_async_reply_reason): Rename from
9037         until_next_fsm_async_reply_reason.
9038         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9039         constructor.  Change type of breakpoint.
9040         (finish_command_fsm_ops): Remove.
9041         (new_finish_command_fsm): Remove.
9042         (finish_command_fsm::should_stop): Rename from
9043         finish_command_fsm_should_stop.
9044         (finish_command_fsm::clean_up): Rename from
9045         finish_command_fsm_clean_up.
9046         (finish_command_fsm::return_value): Rename from
9047         finish_command_fsm_return_value.
9048         (finish_command_fsm::do_async_reply_reason): Rename from
9049         finish_command_fsm_async_reply_reason.
9050         (finish_command): Update.
9051         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9052         Add constructor.
9053         (call_thread_fsm_ops): Remove.
9054         (call_thread_fsm::call_thread_fsm): Rename from
9055         new_call_thread_fsm.
9056         (call_thread_fsm::should_stop): Rename from
9057         call_thread_fsm_should_stop.
9058         (call_thread_fsm::should_notify_stop): Rename from
9059         call_thread_fsm_should_notify_stop.
9060         (run_inferior_call, call_function_by_hand_dummy): Update.
9061         * cli/cli-interp.c (should_print_stop_to_console): Update.
9062         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9063         Add constructor.  Change type of location_breakpoint,
9064         caller_breakpoint.
9065         (until_break_fsm_ops): Remove.
9066         (new_until_break_fsm): Remove.
9067         (until_break_fsm::should_stop): Rename from
9068         until_break_fsm_should_stop.
9069         (until_break_fsm::clean_up): Rename from
9070         until_break_fsm_clean_up.
9071         (until_break_fsm::do_async_reply_reason): Rename from
9072         until_break_fsm_async_reply_reason.
9073         (until_break_command): Update.
9074         * thread-fsm.c: Remove.
9075         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9076
9077 2019-02-07  Tom Tromey  <tom@tromey.com>
9078
9079         * yy-remap.h: Add include guard.
9080         * xtensa-tdep.h: Add include guard.
9081         * xcoffread.h: Rename include guard.
9082         * varobj-iter.h: Add include guard.
9083         * tui/tui.h: Rename include guard.
9084         * tui/tui-winsource.h: Rename include guard.
9085         * tui/tui-wingeneral.h: Rename include guard.
9086         * tui/tui-windata.h: Rename include guard.
9087         * tui/tui-win.h: Rename include guard.
9088         * tui/tui-stack.h: Rename include guard.
9089         * tui/tui-source.h: Rename include guard.
9090         * tui/tui-regs.h: Rename include guard.
9091         * tui/tui-out.h: Rename include guard.
9092         * tui/tui-layout.h: Rename include guard.
9093         * tui/tui-io.h: Rename include guard.
9094         * tui/tui-hooks.h: Rename include guard.
9095         * tui/tui-file.h: Rename include guard.
9096         * tui/tui-disasm.h: Rename include guard.
9097         * tui/tui-data.h: Rename include guard.
9098         * tui/tui-command.h: Rename include guard.
9099         * tic6x-tdep.h: Add include guard.
9100         * target/waitstatus.h: Rename include guard.
9101         * target/wait.h: Rename include guard.
9102         * target/target.h: Rename include guard.
9103         * target/resume.h: Rename include guard.
9104         * target-float.h: Rename include guard.
9105         * stabsread.h: Add include guard.
9106         * rs6000-tdep.h: Add include guard.
9107         * riscv-fbsd-tdep.h: Add include guard.
9108         * regformats/regdef.h: Rename include guard.
9109         * record.h: Rename include guard.
9110         * python/python.h: Rename include guard.
9111         * python/python-internal.h: Rename include guard.
9112         * python/py-stopevent.h: Rename include guard.
9113         * python/py-ref.h: Rename include guard.
9114         * python/py-record.h: Rename include guard.
9115         * python/py-record-full.h: Rename include guard.
9116         * python/py-record-btrace.h: Rename include guard.
9117         * python/py-instruction.h: Rename include guard.
9118         * python/py-events.h: Rename include guard.
9119         * python/py-event.h: Rename include guard.
9120         * procfs.h: Add include guard.
9121         * proc-utils.h: Add include guard.
9122         * p-lang.h: Add include guard.
9123         * or1k-tdep.h: Rename include guard.
9124         * observable.h: Rename include guard.
9125         * nto-tdep.h: Rename include guard.
9126         * nat/x86-linux.h: Rename include guard.
9127         * nat/x86-linux-dregs.h: Rename include guard.
9128         * nat/x86-gcc-cpuid.h: Add include guard.
9129         * nat/x86-dregs.h: Rename include guard.
9130         * nat/x86-cpuid.h: Rename include guard.
9131         * nat/ppc-linux.h: Rename include guard.
9132         * nat/mips-linux-watch.h: Rename include guard.
9133         * nat/linux-waitpid.h: Rename include guard.
9134         * nat/linux-ptrace.h: Rename include guard.
9135         * nat/linux-procfs.h: Rename include guard.
9136         * nat/linux-osdata.h: Rename include guard.
9137         * nat/linux-nat.h: Rename include guard.
9138         * nat/linux-namespaces.h: Rename include guard.
9139         * nat/linux-btrace.h: Rename include guard.
9140         * nat/glibc_thread_db.h: Rename include guard.
9141         * nat/gdb_thread_db.h: Rename include guard.
9142         * nat/gdb_ptrace.h: Rename include guard.
9143         * nat/fork-inferior.h: Rename include guard.
9144         * nat/amd64-linux-siginfo.h: Rename include guard.
9145         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9146         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9147         * nat/aarch64-linux.h: Rename include guard.
9148         * nat/aarch64-linux-hw-point.h: Rename include guard.
9149         * mn10300-tdep.h: Add include guard.
9150         * mips-linux-tdep.h: Add include guard.
9151         * mi/mi-parse.h: Rename include guard.
9152         * mi/mi-out.h: Rename include guard.
9153         * mi/mi-main.h: Rename include guard.
9154         * mi/mi-interp.h: Rename include guard.
9155         * mi/mi-getopt.h: Rename include guard.
9156         * mi/mi-console.h: Rename include guard.
9157         * mi/mi-common.h: Rename include guard.
9158         * mi/mi-cmds.h: Rename include guard.
9159         * mi/mi-cmd-break.h: Rename include guard.
9160         * m2-lang.h: Add include guard.
9161         * location.h: Rename include guard.
9162         * linux-record.h: Rename include guard.
9163         * linux-nat.h: Add include guard.
9164         * linux-fork.h: Add include guard.
9165         * i386-darwin-tdep.h: Rename include guard.
9166         * hppa-linux-offsets.h: Add include guard.
9167         * guile/guile.h: Rename include guard.
9168         * guile/guile-internal.h: Rename include guard.
9169         * gnu-nat.h: Rename include guard.
9170         * gdb-stabs.h: Rename include guard.
9171         * frv-tdep.h: Add include guard.
9172         * f-lang.h: Add include guard.
9173         * event-loop.h: Add include guard.
9174         * darwin-nat.h: Rename include guard.
9175         * cp-abi.h: Rename include guard.
9176         * config/sparc/nm-sol2.h: Rename include guard.
9177         * config/nm-nto.h: Rename include guard.
9178         * config/nm-linux.h: Add include guard.
9179         * config/i386/nm-i386gnu.h: Rename include guard.
9180         * config/djgpp/nl_types.h: Rename include guard.
9181         * config/djgpp/langinfo.h: Rename include guard.
9182         * compile/gcc-cp-plugin.h: Add include guard.
9183         * compile/gcc-c-plugin.h: Add include guard.
9184         * compile/compile.h: Rename include guard.
9185         * compile/compile-object-run.h: Rename include guard.
9186         * compile/compile-object-load.h: Rename include guard.
9187         * compile/compile-internal.h: Rename include guard.
9188         * compile/compile-cplus.h: Rename include guard.
9189         * compile/compile-c.h: Rename include guard.
9190         * common/xml-utils.h: Rename include guard.
9191         * common/x86-xstate.h: Rename include guard.
9192         * common/version.h: Rename include guard.
9193         * common/vec.h: Rename include guard.
9194         * common/tdesc.h: Rename include guard.
9195         * common/selftest.h: Rename include guard.
9196         * common/scoped_restore.h: Rename include guard.
9197         * common/scoped_mmap.h: Rename include guard.
9198         * common/scoped_fd.h: Rename include guard.
9199         * common/safe-iterator.h: Rename include guard.
9200         * common/run-time-clock.h: Rename include guard.
9201         * common/refcounted-object.h: Rename include guard.
9202         * common/queue.h: Rename include guard.
9203         * common/ptid.h: Rename include guard.
9204         * common/print-utils.h: Rename include guard.
9205         * common/preprocessor.h: Rename include guard.
9206         * common/pathstuff.h: Rename include guard.
9207         * common/observable.h: Rename include guard.
9208         * common/netstuff.h: Rename include guard.
9209         * common/job-control.h: Rename include guard.
9210         * common/host-defs.h: Rename include guard.
9211         * common/gdb_wait.h: Rename include guard.
9212         * common/gdb_vecs.h: Rename include guard.
9213         * common/gdb_unlinker.h: Rename include guard.
9214         * common/gdb_unique_ptr.h: Rename include guard.
9215         * common/gdb_tilde_expand.h: Rename include guard.
9216         * common/gdb_sys_time.h: Rename include guard.
9217         * common/gdb_string_view.h: Rename include guard.
9218         * common/gdb_splay_tree.h: Rename include guard.
9219         * common/gdb_setjmp.h: Rename include guard.
9220         * common/gdb_ref_ptr.h: Rename include guard.
9221         * common/gdb_optional.h: Rename include guard.
9222         * common/gdb_locale.h: Rename include guard.
9223         * common/gdb_assert.h: Rename include guard.
9224         * common/filtered-iterator.h: Rename include guard.
9225         * common/filestuff.h: Rename include guard.
9226         * common/fileio.h: Rename include guard.
9227         * common/environ.h: Rename include guard.
9228         * common/common-utils.h: Rename include guard.
9229         * common/common-types.h: Rename include guard.
9230         * common/common-regcache.h: Rename include guard.
9231         * common/common-inferior.h: Rename include guard.
9232         * common/common-gdbthread.h: Rename include guard.
9233         * common/common-exceptions.h: Rename include guard.
9234         * common/common-defs.h: Rename include guard.
9235         * common/common-debug.h: Rename include guard.
9236         * common/cleanups.h: Rename include guard.
9237         * common/buffer.h: Rename include guard.
9238         * common/btrace-common.h: Rename include guard.
9239         * common/break-common.h: Rename include guard.
9240         * cli/cli-utils.h: Rename include guard.
9241         * cli/cli-style.h: Rename include guard.
9242         * cli/cli-setshow.h: Rename include guard.
9243         * cli/cli-script.h: Rename include guard.
9244         * cli/cli-interp.h: Rename include guard.
9245         * cli/cli-decode.h: Rename include guard.
9246         * cli/cli-cmds.h: Rename include guard.
9247         * charset-list.h: Add include guard.
9248         * buildsym-legacy.h: Rename include guard.
9249         * bfin-tdep.h: Add include guard.
9250         * ax.h: Rename include guard.
9251         * arm-linux-tdep.h: Add include guard.
9252         * arm-fbsd-tdep.h: Add include guard.
9253         * arch/xtensa.h: Rename include guard.
9254         * arch/tic6x.h: Add include guard.
9255         * arch/i386.h: Add include guard.
9256         * arch/arm.h: Rename include guard.
9257         * arch/arm-linux.h: Rename include guard.
9258         * arch/arm-get-next-pcs.h: Rename include guard.
9259         * arch/amd64.h: Add include guard.
9260         * arch/aarch64-insn.h: Rename include guard.
9261         * arch-utils.h: Rename include guard.
9262         * annotate.h: Add include guard.
9263         * amd64-darwin-tdep.h: Rename include guard.
9264         * aarch64-linux-tdep.h: Add include guard.
9265         * aarch64-fbsd-tdep.h: Add include guard.
9266         * aarch32-linux-nat.h: Add include guard.
9267
9268 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9269
9270         * macrotab.c (macro_define_internal): New function that
9271         factorizes macro_define_object_internal and macro_define_function
9272         code.
9273         (macro_define_object_internal): Use macro_define_internal.
9274         (macro_define_function): Likewise.
9275
9276 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9277
9278         * macrocmd.c (extract_identifier): Return
9279         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9280         callers.
9281
9282 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9283
9284         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9285
9286 2019-02-05  Tom Tromey  <tom@tromey.com>
9287
9288         * target.c (target_stack::unpush): Move assertion earlier.
9289
9290 2019-01-30  Tom Tromey  <tom@tromey.com>
9291
9292         PR python/23615:
9293         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9294         (gdbpy_parse_and_eval): Likewise.
9295         * python/python-internal.h (gdbpy_allow_threads): New class.
9296
9297 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9298
9299         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9300         (aarch64_fbsd_fpregmap): Move earlier.
9301         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9302         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9303         instead of individual calls to trad_frame_set_reg_addr.
9304         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9305         earlier.
9306         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9307         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9308         instead of individual calls to trad_frame_set_reg_addr.
9309
9310 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9311
9312         * CONTRIBUTE: Replace contribution list with wiki link.
9313
9314 2019-01-25  Tom Tromey  <tom@tromey.com>
9315
9316         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9317
9318 2019-01-25  Tom Tromey  <tom@tromey.com>
9319
9320         * xtensa-linux-nat.c: Fix common/ includes.
9321         * xml-support.h: Fix common/ includes.
9322         * xml-support.c: Fix common/ includes.
9323         * x86-linux-nat.c: Fix common/ includes.
9324         * windows-nat.c: Fix common/ includes.
9325         * varobj.h: Fix common/ includes.
9326         * varobj.c: Fix common/ includes.
9327         * value.c: Fix common/ includes.
9328         * valops.c: Fix common/ includes.
9329         * utils.c: Fix common/ includes.
9330         * unittests/xml-utils-selftests.c: Fix common/ includes.
9331         * unittests/utils-selftests.c: Fix common/ includes.
9332         * unittests/unpack-selftests.c: Fix common/ includes.
9333         * unittests/tracepoint-selftests.c: Fix common/ includes.
9334         * unittests/style-selftests.c: Fix common/ includes.
9335         * unittests/string_view-selftests.c: Fix common/ includes.
9336         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9337         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9338         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9339         * unittests/rsp-low-selftests.c: Fix common/ includes.
9340         * unittests/parse-connection-spec-selftests.c: Fix common/
9341         includes.
9342         * unittests/optional-selftests.c: Fix common/ includes.
9343         * unittests/offset-type-selftests.c: Fix common/ includes.
9344         * unittests/observable-selftests.c: Fix common/ includes.
9345         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9346         * unittests/memrange-selftests.c: Fix common/ includes.
9347         * unittests/memory-map-selftests.c: Fix common/ includes.
9348         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9349         * unittests/function-view-selftests.c: Fix common/ includes.
9350         * unittests/environ-selftests.c: Fix common/ includes.
9351         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9352         * unittests/common-utils-selftests.c: Fix common/ includes.
9353         * unittests/cli-utils-selftests.c: Fix common/ includes.
9354         * unittests/array-view-selftests.c: Fix common/ includes.
9355         * ui-file.c: Fix common/ includes.
9356         * tui/tui-io.c: Fix common/ includes.
9357         * tracepoint.h: Fix common/ includes.
9358         * tracepoint.c: Fix common/ includes.
9359         * tracefile-tfile.c: Fix common/ includes.
9360         * top.h: Fix common/ includes.
9361         * top.c: Fix common/ includes.
9362         * thread.c: Fix common/ includes.
9363         * target/waitstatus.h: Fix common/ includes.
9364         * target/waitstatus.c: Fix common/ includes.
9365         * target.h: Fix common/ includes.
9366         * target.c: Fix common/ includes.
9367         * target-memory.c: Fix common/ includes.
9368         * target-descriptions.c: Fix common/ includes.
9369         * symtab.h: Fix common/ includes.
9370         * symfile.c: Fix common/ includes.
9371         * stap-probe.c: Fix common/ includes.
9372         * spu-linux-nat.c: Fix common/ includes.
9373         * sparc-nat.c: Fix common/ includes.
9374         * source.c: Fix common/ includes.
9375         * solib.c: Fix common/ includes.
9376         * solib-target.c: Fix common/ includes.
9377         * ser-unix.c: Fix common/ includes.
9378         * ser-tcp.c: Fix common/ includes.
9379         * ser-pipe.c: Fix common/ includes.
9380         * ser-base.c: Fix common/ includes.
9381         * selftest-arch.c: Fix common/ includes.
9382         * s12z-tdep.c: Fix common/ includes.
9383         * rust-exp.y: Fix common/ includes.
9384         * rs6000-aix-tdep.c: Fix common/ includes.
9385         * riscv-tdep.c: Fix common/ includes.
9386         * remote.c: Fix common/ includes.
9387         * remote-notif.h: Fix common/ includes.
9388         * remote-fileio.h: Fix common/ includes.
9389         * remote-fileio.c: Fix common/ includes.
9390         * regcache.h: Fix common/ includes.
9391         * regcache.c: Fix common/ includes.
9392         * record-btrace.c: Fix common/ includes.
9393         * python/python.c: Fix common/ includes.
9394         * python/py-type.c: Fix common/ includes.
9395         * python/py-inferior.c: Fix common/ includes.
9396         * progspace.h: Fix common/ includes.
9397         * producer.c: Fix common/ includes.
9398         * procfs.c: Fix common/ includes.
9399         * proc-api.c: Fix common/ includes.
9400         * printcmd.c: Fix common/ includes.
9401         * ppc-linux-nat.c: Fix common/ includes.
9402         * parser-defs.h: Fix common/ includes.
9403         * osdata.c: Fix common/ includes.
9404         * obsd-nat.c: Fix common/ includes.
9405         * nat/x86-linux.c: Fix common/ includes.
9406         * nat/x86-linux-dregs.c: Fix common/ includes.
9407         * nat/x86-dregs.h: Fix common/ includes.
9408         * nat/x86-dregs.c: Fix common/ includes.
9409         * nat/ppc-linux.c: Fix common/ includes.
9410         * nat/mips-linux-watch.h: Fix common/ includes.
9411         * nat/mips-linux-watch.c: Fix common/ includes.
9412         * nat/linux-waitpid.c: Fix common/ includes.
9413         * nat/linux-ptrace.h: Fix common/ includes.
9414         * nat/linux-ptrace.c: Fix common/ includes.
9415         * nat/linux-procfs.c: Fix common/ includes.
9416         * nat/linux-personality.c: Fix common/ includes.
9417         * nat/linux-osdata.c: Fix common/ includes.
9418         * nat/linux-namespaces.c: Fix common/ includes.
9419         * nat/linux-btrace.h: Fix common/ includes.
9420         * nat/linux-btrace.c: Fix common/ includes.
9421         * nat/fork-inferior.c: Fix common/ includes.
9422         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9423         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9424         * nat/aarch64-linux.c: Fix common/ includes.
9425         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9426         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9427         * namespace.h: Fix common/ includes.
9428         * mips-linux-tdep.c: Fix common/ includes.
9429         * minsyms.c: Fix common/ includes.
9430         * mi/mi-parse.h: Fix common/ includes.
9431         * mi/mi-main.c: Fix common/ includes.
9432         * mi/mi-cmd-env.c: Fix common/ includes.
9433         * memrange.h: Fix common/ includes.
9434         * memattr.c: Fix common/ includes.
9435         * maint.h: Fix common/ includes.
9436         * maint.c: Fix common/ includes.
9437         * main.c: Fix common/ includes.
9438         * machoread.c: Fix common/ includes.
9439         * location.c: Fix common/ includes.
9440         * linux-thread-db.c: Fix common/ includes.
9441         * linux-nat.c: Fix common/ includes.
9442         * linux-fork.c: Fix common/ includes.
9443         * inline-frame.c: Fix common/ includes.
9444         * infrun.c: Fix common/ includes.
9445         * inflow.c: Fix common/ includes.
9446         * inferior.h: Fix common/ includes.
9447         * inferior.c: Fix common/ includes.
9448         * infcmd.c: Fix common/ includes.
9449         * inf-ptrace.c: Fix common/ includes.
9450         * inf-child.c: Fix common/ includes.
9451         * ia64-linux-nat.c: Fix common/ includes.
9452         * i387-tdep.c: Fix common/ includes.
9453         * i386-tdep.c: Fix common/ includes.
9454         * i386-linux-tdep.c: Fix common/ includes.
9455         * i386-linux-nat.c: Fix common/ includes.
9456         * i386-go32-tdep.c: Fix common/ includes.
9457         * i386-fbsd-tdep.c: Fix common/ includes.
9458         * i386-fbsd-nat.c: Fix common/ includes.
9459         * guile/scm-type.c: Fix common/ includes.
9460         * guile/guile.c: Fix common/ includes.
9461         * go32-nat.c: Fix common/ includes.
9462         * gnu-nat.c: Fix common/ includes.
9463         * gdbthread.h: Fix common/ includes.
9464         * gdbarch-selftests.c: Fix common/ includes.
9465         * gdb_usleep.c: Fix common/ includes.
9466         * gdb_select.h: Fix common/ includes.
9467         * gdb_bfd.c: Fix common/ includes.
9468         * gcore.c: Fix common/ includes.
9469         * fork-child.c: Fix common/ includes.
9470         * findvar.c: Fix common/ includes.
9471         * fbsd-nat.c: Fix common/ includes.
9472         * event-top.c: Fix common/ includes.
9473         * event-loop.c: Fix common/ includes.
9474         * dwarf2read.c: Fix common/ includes.
9475         * dwarf2loc.c: Fix common/ includes.
9476         * dwarf2-frame.c: Fix common/ includes.
9477         * dwarf-index-cache.c: Fix common/ includes.
9478         * dtrace-probe.c: Fix common/ includes.
9479         * disasm-selftests.c: Fix common/ includes.
9480         * defs.h: Fix common/ includes.
9481         * csky-tdep.c: Fix common/ includes.
9482         * cp-valprint.c: Fix common/ includes.
9483         * cp-support.h: Fix common/ includes.
9484         * cp-support.c: Fix common/ includes.
9485         * corelow.c: Fix common/ includes.
9486         * completer.h: Fix common/ includes.
9487         * completer.c: Fix common/ includes.
9488         * compile/compile.c: Fix common/ includes.
9489         * compile/compile-loc2c.c: Fix common/ includes.
9490         * compile/compile-cplus-types.c: Fix common/ includes.
9491         * compile/compile-cplus-symbols.c: Fix common/ includes.
9492         * command.h: Fix common/ includes.
9493         * cli/cli-dump.c: Fix common/ includes.
9494         * cli/cli-cmds.c: Fix common/ includes.
9495         * charset.c: Fix common/ includes.
9496         * build-id.c: Fix common/ includes.
9497         * btrace.h: Fix common/ includes.
9498         * btrace.c: Fix common/ includes.
9499         * breakpoint.h: Fix common/ includes.
9500         * breakpoint.c: Fix common/ includes.
9501         * ax.h:
9502         (enum agent_op): Fix common/ includes.
9503         * ax-general.c (struct aop_map): Fix common/ includes.
9504         * ax-gdb.c: Fix common/ includes.
9505         * auxv.c: Fix common/ includes.
9506         * auto-load.c: Fix common/ includes.
9507         * arm-tdep.c: Fix common/ includes.
9508         * arch/riscv.c: Fix common/ includes.
9509         * arch/ppc-linux-common.c: Fix common/ includes.
9510         * arch/i386.c: Fix common/ includes.
9511         * arch/arm.c: Fix common/ includes.
9512         * arch/arm-linux.c: Fix common/ includes.
9513         * arch/arm-get-next-pcs.c: Fix common/ includes.
9514         * arch/amd64.c: Fix common/ includes.
9515         * arch/aarch64.c: Fix common/ includes.
9516         * arch/aarch64-insn.c: Fix common/ includes.
9517         * arch-utils.c: Fix common/ includes.
9518         * amd64-windows-tdep.c: Fix common/ includes.
9519         * amd64-tdep.c: Fix common/ includes.
9520         * amd64-sol2-tdep.c: Fix common/ includes.
9521         * amd64-obsd-tdep.c: Fix common/ includes.
9522         * amd64-nbsd-tdep.c: Fix common/ includes.
9523         * amd64-linux-tdep.c: Fix common/ includes.
9524         * amd64-linux-nat.c: Fix common/ includes.
9525         * amd64-fbsd-tdep.c: Fix common/ includes.
9526         * amd64-fbsd-nat.c: Fix common/ includes.
9527         * amd64-dicos-tdep.c: Fix common/ includes.
9528         * amd64-darwin-tdep.c: Fix common/ includes.
9529         * agent.c: Fix common/ includes.
9530         * ada-lang.h: Fix common/ includes.
9531         * ada-lang.c: Fix common/ includes.
9532         * aarch64-tdep.c: Fix common/ includes.
9533
9534 2019-01-25  Tom Tromey  <tom@tromey.com>
9535
9536         * common/create-version.sh: Use common/version.h.
9537
9538 2019-01-24  Pedro Alves  <palves@redhat.com>
9539
9540         * infrun.c (signal_stop, signal_print, signal_program)
9541         (signal_catch, signal_pass): Now arrays instead of pointers.
9542         (update_signals_program_target, do_target_resume)
9543         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9544         * linux-nat.c (linux_nat_target::pass_signals)
9545         (linux_nat_target::create_inferior, linux_nat_target::attach):
9546         Adjust.
9547         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9548         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9549         * procfs.c (procfs_target::pass_signals): Adjust.
9550         * record-full.c (record_full_target::resume): Adjust.
9551         * remote.c (remote_target::pass_signals)
9552         (remote_target::program_signals): Adjust.
9553         * target-debug.h (target_debug_print_signals): Now takes a
9554         gdb::array_view as parameter.  Adjust.
9555         * target.h (target_ops) <pass_signals, program_signals>: Replace
9556         pointer and length parameters with gdb::array_view.
9557         (target_pass_signals, target_program_signals): Likewise.
9558         * target-delegates.c: Regenerate.
9559
9560 2019-01-24  Pedro Alves  <palves@redhat.com>
9561
9562         * common/forward-scope-exit.h
9563         (forward_scope_exit::forward_scope_exit): Pass arguments to
9564         m_bind_function directly, instead of creating a std::bind and
9565         copying that.
9566
9567 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9568
9569         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9570         for static members.
9571         (pass_in_v_vfp_candidate): Likewise.
9572
9573 2019-01-23  Tom Tromey  <tom@tromey.com>
9574             Pedro Alves  <palves@redhat.com>
9575
9576         * regcache.c (class regcache_invalidator): Remove.
9577         (regcache::raw_write): Use make_scope_exit.
9578
9579 2019-01-23  Tom Tromey  <tom@tromey.com>
9580
9581         * ui-out.h (class ui_out_emit_type): Update comment.
9582
9583 2019-01-23  Tom Tromey  <tom@tromey.com>
9584
9585         * infrun.c (fetch_inferior_event): Update comment.
9586
9587 2019-01-23  Tom Tromey  <tom@tromey.com>
9588             Pedro Alves  <palves@redhat.com>
9589
9590         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9591         parameter.
9592         (fetch_inferior_event): Use SCOPE_EXIT.
9593
9594
9595 2019-01-23  Tom Tromey  <tom@tromey.com>
9596             Pedro Alves  <palves@redhat.com>
9597
9598         * infrun.c (disable_thread_events): Delete.
9599         (stop_all_threads): Use SCOPE_EXIT.
9600
9601 2019-01-23  Tom Tromey  <tom@tromey.com>
9602             Pedro Alves  <palves@redhat.com>
9603
9604         * symfile.c: Include forward-scope-exit.h.
9605         (clear_symtab_users_cleanup): Replace forward declaration with
9606         a FORWARD_SCOPE_EXIT.
9607         (syms_from_objfile_1): Use the forward_scope_exit and
9608         gdb::optional instead of cleanup_function.
9609         (reread_symbols): Use the forward_scope_exit instead of
9610         cleanup_function.
9611         (clear_symtab_users_cleanup): Remove function.
9612
9613 2019-01-23  Tom Tromey  <tom@tromey.com>
9614             Pedro Alves  <palves@redhat.com>
9615
9616         * linux-nat.c: Include scope-exit.h.
9617         (cleanup_target_stop): Remove.
9618         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9619         SCOPE_EXIT.
9620
9621 2019-01-23  Tom Tromey  <tom@tromey.com>
9622             Pedro Alves  <palves@redhat.com>
9623
9624         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9625         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9626
9627 2019-01-23  Tom Tromey  <tom@tromey.com>
9628             Andrew Burgess  <andrew.burgess@embecosm.com>
9629             Pedro Alves  <palves@redhat.com>
9630
9631         * infrun.c (fetch_inferior_event): Use scope_exit.
9632         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9633         * top.c (execute_command): Use scope_exit.
9634         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9635         * utils.c (do_bpstat_clear_actions_cleanup)
9636         (make_bpstat_clear_actions_cleanup): Remove.
9637
9638 2019-01-23  Tom Tromey  <tom@tromey.com>
9639             Pedro Alves  <palves@redhat.com>
9640
9641         * infrun.c: Include "common/scope-exit.h"
9642         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9643         (wait_for_inferior): Use SCOPE_EXIT.
9644         (fetch_inferior_event): Use scope_exit.
9645
9646 2019-01-23  Tom Tromey  <tom@tromey.com>
9647             Pedro Alves  <palves@redhat.com>
9648
9649         * breakpoint.c (create_breakpoint): Remove cleanup.
9650
9651 2019-01-23  Tom Tromey  <tom@tromey.com>
9652             Andrew Burgess  <andrew.burgess@embecosm.com>
9653             Pedro Alves  <palves@redhat.com>
9654
9655 2019-01-23  Pedro Alves  <palves@redhat.com>
9656
9657         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9658
9659 2019-01-23  Pedro Alves  <palves@redhat.com>
9660             Andrew Burgess  <andrew.burgess@embecosm.com>
9661
9662         * gdbthread.h: Include "common/forward-scope-exit.h".
9663         (scoped_finish_thread_state): Redefine custom class in terms of
9664         forward_scope_exit.
9665
9666 2019-01-23  Pedro Alves  <palves@redhat.com>
9667             Andrew Burgess  <andrew.burgess@embecosm.com>
9668
9669         * common/forward-scope-exit.h: New file.
9670
9671 2019-01-23  Pedro Alves  <palves@redhat.com>
9672             Andrew Burgess  <andrew.burgess@embecosm.com>
9673             Tom Tromey  <tom@tromey.com>
9674
9675         * common/scope-exit.h: New file.
9676
9677 2019-01-23  Pedro Alves  <palves@redhat.com>
9678
9679         * common/preprocessor.h (ESC): Rename to ...
9680         (ESC_PARENS): ... this.
9681         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9682         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9683
9684 2019-01-23  Tom Tromey  <tom@tromey.com>
9685
9686         * language.h (class scoped_switch_to_sym_language_if_auto):
9687         Initialize m_lang in both cases.
9688
9689 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9690
9691         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9692         with XCNEW.
9693
9694 2019-01-22  Tom Tromey  <tom@tromey.com>
9695
9696         * corelow.c: Do not include sys/file.h.
9697
9698 2019-01-22  Tom Tromey  <tom@tromey.com>
9699
9700         * tui/tui-wingeneral.h: Include gdb_curses.h.
9701
9702 2019-01-22  Tom Tromey  <tom@tromey.com>
9703
9704         * source-cache.h (class source_cache) <get_source_lines,
9705         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9706
9707 2019-01-22  Tom Tromey  <tom@tromey.com>
9708
9709         * remote-fileio.h (struct remote_target): Declare.
9710
9711 2019-01-22  Tom Tromey  <tom@tromey.com>
9712
9713         * python/py-arch.c: Do not include py-ref.h.
9714         * python/py-bpevent.c: Do not include py-ref.h.
9715         * python/py-cmd.c: Do not include py-ref.h.
9716         * python/py-continueevent.c: Do not include py-ref.h.
9717         * python/py-event.h: Do not include py-ref.h.
9718         * python/py-evtregistry.c: Do not include py-ref.h.
9719         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9720         * python/py-frame.c: Do not include py-ref.h.
9721         * python/py-framefilter.c: Do not include py-ref.h.
9722         * python/py-function.c: Do not include py-ref.h.
9723         * python/py-infevents.c: Do not include py-ref.h.
9724         * python/py-linetable.c: Do not include py-ref.h.
9725         * python/py-objfile.c: Do not include py-ref.h.
9726         * python/py-param.c: Do not include py-ref.h.
9727         * python/py-prettyprint.c: Do not include py-ref.h.
9728         * python/py-progspace.c: Do not include py-ref.h.
9729         * python/py-symbol.c: Do not include py-ref.h.
9730         * python/py-symtab.c: Do not include py-ref.h.
9731         * python/py-type.c: Do not include py-ref.h.
9732         * python/py-unwind.c: Do not include py-ref.h.
9733         * python/py-utils.c: Do not include py-ref.h.
9734         * python/py-value.c: Do not include py-ref.h.
9735         * python/py-varobj.c: Do not include py-ref.h.
9736         * python/py-xmethods.c: Do not include py-ref.h.
9737         * python/python.c: Do not include py-ref.h.
9738         * varobj.c: Do not include py-ref.h.
9739
9740 2019-01-22  Tom Tromey  <tom@tromey.com>
9741
9742         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9743         keyword for bcache.
9744
9745 2019-01-22  Tom Tromey  <tom@tromey.com>
9746
9747         * compile/compile-cplus-types.c: Remove a comment by #include.
9748
9749 2019-01-22  Tom Tromey  <tom@tromey.com>
9750
9751         * compile/gcc-c-plugin.h: Include compile-internal.h.
9752
9753 2019-01-22  Tom Tromey  <tom@tromey.com>
9754
9755         * stabsread.c (EXTERN): Do not define.
9756         (symnum, next_symbol_text_func, processing_gcc_compilation)
9757         (within_function, global_sym_chain, global_stabs)
9758         (previous_stab_code, this_object_header_files)
9759         (n_this_object_header_files)
9760         (n_allocated_this_object_header_files): Define.
9761         * stabsread.h (EXTERN): Never define.  Use "extern".
9762
9763 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9764
9765         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9766         history_value.
9767
9768 2019-01-21  Tom Tromey  <tom@tromey.com>
9769
9770         * ui-out.c: Fix includes.
9771         * tui/tui-source.c: Fix includes.
9772         * target.c: Fix includes.
9773         * remote.c: Fix includes.
9774         * regcache.c: Fix includes.
9775         * python/py-block.c: Fix includes.
9776         * printcmd.c: Fix includes.
9777         * or1k-tdep.c: Fix includes.
9778         * mi/mi-main.c: Fix includes.
9779         * m32r-tdep.c: Fix includes.
9780         * csky-tdep.c: Fix includes.
9781         * compile/compile-cplus-types.c: Fix includes.
9782         * cli/cli-interp.c: Fix includes.
9783
9784 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9785
9786         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9787         for padding.
9788
9789 2019-01-16  Tom Tromey  <tom@tromey.com>
9790
9791         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9792         earlier.
9793         (struct objfile) <msymbols_range>: Move from top level.
9794         <msymbols>: New method.
9795         (class objfile_msymbols): Remove.
9796         * symtab.c (default_collect_symbol_completion_matches_break_on):
9797         Update.
9798         * symmisc.c (dump_msymbols): Update.
9799         * stabsread.c (scan_file_globals): Update.
9800         * objc-lang.c (info_selectors_command, info_classes_command)
9801         (find_methods): Update.
9802         * minsyms.c (find_solib_trampoline_target): Update.
9803         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9804         * coffread.c (coff_symfile_read): Update.
9805         * ada-lang.c (ada_lookup_simple_minsym)
9806         (ada_collect_symbol_completion_matches): Update.
9807
9808 2019-01-16  Tom Tromey  <tom@tromey.com>
9809
9810         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9811         type.  Remove no-argument constructor.
9812         <iterator::operator++>: Simplify.
9813         <begin>: Update.
9814         <end>: Use minimal_symbol_count.
9815
9816 2019-01-16  Tom Tromey  <tom@tromey.com>
9817
9818         * objfiles.h (struct objfile) <psymtabs>: New method.
9819         (class objfile_psymtabs): Remove.
9820         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9821         typedef.
9822         <range>: New method.
9823         (require_partial_symbols): Change return type.
9824         * psymtab.c (require_partial_symbols)
9825         (psym_expand_symtabs_matching): Update.
9826         * mdebugread.c (parse_partial_symbols): Update.
9827         * dbxread.c (dbx_end_psymtab): Update.
9828
9829 2019-01-15  Tom Tromey  <tom@tromey.com>
9830
9831         * symtab.c (lookup_objfile_from_block)
9832         (lookup_symbol_in_objfile_symtabs)
9833         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9834         (find_line_symtab, info_sources_command)
9835         (default_collect_symbol_completion_matches_break_on)
9836         (make_source_files_completion_list): Update.
9837         * symmisc.c (print_objfile_statistics, dump_objfile)
9838         (maintenance_print_symbols, maintenance_info_symtabs)
9839         (maintenance_check_symtabs, maintenance_info_line_tables):
9840         Update.
9841         * source.c (select_source_symtab)
9842         (forget_cached_source_info_for_objfile): Update.
9843         * objfiles.h (class objfile_compunits): Remove.
9844         (struct objfile) <compunits_range>: New typedef.
9845         (compunits): New method.
9846         * objfiles.c (objfile_relocate1): Update.
9847         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9848         * maint.c (count_symtabs_and_blocks): Update.
9849         * linespec.c (iterate_over_all_matching_symtabs): Update.
9850         * cp-support.c (add_symbol_overload_list_qualified): Update.
9851         * coffread.c (coff_symtab_read): Update.
9852         * ada-lang.c (add_nonlocal_symbols)
9853         (ada_collect_symbol_completion_matches)
9854         (ada_add_global_exceptions): Update.
9855
9856 2019-01-15  Tom Tromey  <tom@tromey.com>
9857
9858         * progspace.h (program_space) <objfiles_safe_range>: New
9859         typedef.
9860         <objfiles_safe>: New method.
9861         * objfiles.h (class all_objfiles_safe): Remove.
9862         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9863         * jit.c (jit_inferior_exit_hook): Update.
9864
9865 2019-01-17  Tom Tromey  <tom@tromey.com>
9866
9867         * progspace.h (program_space) <objfiles_range>: New typedef.
9868         <objfiles>: New method.
9869         <objfiles_head>: Rename from objfiles.
9870         (object_files): Update.
9871         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9872         * guile/scm-pretty-print.c
9873         (ppscm_find_pretty_printer_from_objfiles): Update.
9874         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9875         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9876         Update.
9877         * python/py-progspace.c (pspy_get_objfiles): Update.
9878         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9879         Update.
9880         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9881         (objfpy_lookup_objfile_by_build_id): Update.
9882         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9883         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9884         Update.
9885         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9886         (expand_symtab_containing_pc, lookup_objfile_from_block)
9887         (lookup_static_symbol, basic_lookup_transparent_type)
9888         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9889         (find_line_symtab, info_sources_command)
9890         (default_collect_symbol_completion_matches_break_on)
9891         (make_source_files_completion_list, find_main_name): Update.
9892         * symmisc.c (print_symbol_bcache_statistics)
9893         (print_objfile_statistics, maintenance_print_symbols)
9894         (maintenance_print_msymbols, maintenance_print_objfiles)
9895         (maintenance_info_symtabs, maintenance_check_symtabs)
9896         (maintenance_expand_symtabs, maintenance_info_line_tables):
9897         Update.
9898         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9899         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9900         (map_overlay_command, unmap_overlay_command)
9901         (simple_overlay_update, expand_symtabs_matching)
9902         (map_symbol_filenames): Update.
9903         * symfile-debug.c (set_debug_symfile): Update.
9904         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9905         Update.
9906         * source.c (select_source_symtab, forget_cached_source_info):
9907         Update.
9908         * solib.c (solib_read_symbols): Update.
9909         * solib-spu.c (append_ocl_sos): Update.
9910         * psymtab.c (maintenance_print_psymbols)
9911         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9912         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9913         * printcmd.c (info_symbol_command): Update.
9914         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9915         Update.
9916         * objfiles.h (class all_objfiles): Remove.
9917         * objfiles.c (have_partial_symbols, have_full_symbols)
9918         (have_minimal_symbols, qsort_cmp, update_section_map)
9919         (shared_objfile_contains_address_p)
9920         (default_iterate_over_objfiles_in_search_order): Update.
9921         * objc-lang.c (info_selectors_command, info_classes_command)
9922         (find_methods): Update.
9923         * minsyms.c (find_solib_trampoline_target): Update.
9924         * maint.c (maintenance_info_sections)
9925         (maintenance_translate_address, count_symtabs_and_blocks):
9926         Update.
9927         * main.c (captured_main_1): Update.
9928         * linux-thread-db.c (try_thread_db_load_from_pdir)
9929         (has_libpthread): Update.
9930         * linespec.c (iterate_over_all_matching_symtabs)
9931         (search_minsyms_for_name): Update.
9932         * jit.c (jit_find_objf_with_entry_addr): Update.
9933         * hppa-tdep.c (find_unwind_entry)
9934         (hppa_lookup_stub_minimal_symbol): Update.
9935         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9936         Update.
9937         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9938         (elf_gnu_ifunc_resolve_by_got): Update.
9939         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9940         * dwarf-index-write.c (save_gdb_index_command): Update.
9941         * cp-support.c (add_symbol_overload_list_qualified): Update.
9942         * breakpoint.c (create_overlay_event_breakpoint)
9943         (create_longjmp_master_breakpoint)
9944         (create_std_terminate_master_breakpoint)
9945         (create_exception_master_breakpoint): Update.
9946         * blockframe.c (find_pc_partial_function): Update.
9947         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9948         (ada_collect_symbol_completion_matches)
9949         (ada_add_global_exceptions): Update.
9950
9951 2019-01-17  Tom Tromey  <tom@tromey.com>
9952
9953         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9954         declare VEC.
9955         (solib_target_parse_libraries): Change return type.
9956         (library_list_start_segment, library_list_start_section)
9957         (library_list_end_library, library_list_start_library); Update.
9958         (solib_target_free_library_list): Remove.
9959         (solib_target_parse_libraries): Remove cleanup.  Change return
9960         type.
9961         (solib_target_current_sos): Update.
9962
9963 2019-01-17  Tom Tromey  <tromey@bapiya>
9964
9965         * valprint.c: Replace "the the" with "the".
9966         * symtab.c: Replace "the the" with "the".
9967         * solib.c: Replace "the the" with "the".
9968         * solib-dsbt.c: Replace "the the" with "the".
9969         * linespec.c: Replace "the the" with "the".
9970         * dwarf2loc.h: Replace "the the" with "the".
9971         * amd64-windows-tdep.c: Replace "the the" with "the".
9972         * aarch64-tdep.c: Replace "the the" with "the".
9973
9974 2019-01-16  Keith Seitz  <keiths@redhat.com>
9975
9976         PR gdb/23773
9977         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9978         <builder>: Rename to ..
9979         <m_builder>: ... this and make private.
9980         (dwarf2_cu::get_builder): New method.  Change all users of
9981         `builder' to use this method.
9982         (dwarf2_start_symtab): Move to ...
9983         (dwarf2_cu::start_symtab): ... here.  Update all callers
9984         (setup_type_unit_groups): Move to ...
9985         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9986         callers.
9987         (dwarf2_cu::reset_builder): New method.
9988         (process_full_compunit, process_full_type_unit): Use
9989         dwarf2_cu::reset_builder.
9990         (follow_die_offset): Record the ancestor CU if it is different
9991         from the followed DIE's CU.
9992         (follow_die_sig_1): Likewise.
9993
9994 2019-01-15  Tom Tromey  <tom@tromey.com>
9995
9996         * remote.c (class remote_state) <buf>: Now a char_vector.
9997         <buf_size>: Remove.
9998         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9999         parameter.
10000         (remote_target::getpkt_or_notif_sane_1)
10001         (remote_target::getpkt_sane)
10002         (remote_target::getpkt_or_notif_sane): Likewise.
10003         (class remote_target) <putpkt>: New overload.
10004         (remote_target::read_frame): Change type of "buf_p".  Remove
10005         sizeof_p parameter.
10006         (packet_ok): New overload.
10007         (packet_check_result): New overload.
10008         Update all uses.
10009
10010 2019-01-14  Tom Tromey  <tom@tromey.com>
10011
10012         * remote-notif.c (handle_notification, remote_notif_ack)
10013         (remote_notif_parse): Make "buf" const.
10014         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10015         const.
10016         (remote_notif_parse, remote_notif_ack, handle_notification):
10017         Likewise.
10018         * remote.c (remote_notif_stop_parse): Make "buf" const.
10019         (remote_target::remote_parse_stop_reply): Make "buf" const.
10020         (remote_notif_stop_ack): Make "buf" const.
10021
10022 2019-01-14  Tom Tromey  <tom@tromey.com>
10023
10024         * remote.c (remote_console_output): Make parameter const.
10025
10026 2019-01-14  Tom Tromey  <tom@tromey.com>
10027
10028         * target-debug.h (target_debug_print_signals): Constify.
10029         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10030         * procfs.c (procfs_target::pass_signals): Update.
10031         * linux-nat.c (linux_nat_target::pass_signals): Update.
10032         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10033         * target-delegates.c: Rebuild.
10034         * remote.c (remote_target::program_signals): Update.
10035         (remote_target::pass_signals): Update.
10036         * target.c (target_pass_signals): Constify argument.
10037         (target_program_signals): Likewise.
10038         * target.h (struct target_ops) <pass_signals, program_signals>:
10039         Constify argument.
10040         (target_pass_signals, target_program_signals): Constify argument.
10041
10042 2019-01-14  Tom Tromey  <tom@tromey.com>
10043
10044         PR tui/28819:
10045         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10046
10047 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10048
10049         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10050         field.
10051         * rs6000-tdep.c: Include reggroups.h.
10052         (IS_V_ALIAS_PSEUDOREG): Define.
10053         (rs6000_register_name): Return names for the "vX" aliases.
10054         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10055         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10056         aliases.  Call default_register_reggroup_p for all other
10057         pseudo-registers.
10058         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10059         New functions.
10060         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10061         Handle "vX" aliases.
10062         (v_alias_pseudo_register_collect): New function.
10063         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10064         (rs6000_gdbarch_init): Initialize "vX" aliases as
10065         pseudo-registers.  Restore registration of
10066         rs6000_pseudo_register_reggroup_p with
10067         set_tdesc_pseudo_register_reggroup_p.
10068
10069 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10070
10071         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10072         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10073         set_gdbarch_num_pseudo_regs.
10074
10075 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10076
10077         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10078         Remove arg prefixname, add do_set and do_show.
10079         Add member functions set_list and show_list.
10080         * cli/cli-style.c (class cli_style_option): Update accordingly.
10081         (style_set_list): Move to file scope.
10082         (style_show_list): Likewise.
10083         (set_style): Call help_list.
10084         (show_style): Call cmd_show_list.
10085         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10086         Update to use the new macro.
10087
10088 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10089
10090         * ada-lang.c (_initialize_ada_language): Expand the help text
10091         for the "catch exception" command.
10092
10093 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10094
10095         * symtab.c (matching_obj_sections): Initialize obj,
10096         declare it closer to its usage.
10097
10098 2019-01-10  Tom Tromey  <tom@tromey.com>
10099
10100         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10101         (basic_inf_threads_range): Remove.
10102         (inf_threads_range, inf_non_exited_threads_range)
10103         (safe_inf_threads_range): Use next_adapter.
10104
10105 2019-01-10  Keith Seitz  <keiths@redhat.com>
10106
10107         PR gdb/23712
10108         PR symtab/23010
10109         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10110         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10111
10112 2019-01-10  Keith Seitz  <keiths@redhat.com>
10113
10114         PR gdb/23712
10115         PR symtab/23010
10116         * dictionary.c (pending_to_vector): Remove.
10117         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10118         Remove _1 suffix, replacing functions of the same name.  Update
10119         all callers.
10120         (dict_create_hashed, dict_create_hashed_expandable)
10121         (dict_create_linear, dict_create_linear_expandable, dict_free)
10122         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10123         Make functions static.
10124
10125 2019-01-10  Keith Seitz  <keiths@redhat.com>
10126
10127         PR gdb/23712
10128         PR symtab/23010
10129         * dictionary.h (struct dictionary): Replace declaration with
10130         multidictionary.
10131         (dict_create_hashed, dict_create_hashed_expandable)
10132         (dict_create_linear, dict_create_linear_expandable)
10133         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10134         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10135         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10136         taking multidictionary argument.
10137         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10138         * block.h (struct block) <dict>: Change to multidictionary
10139         and rename `multidict'.
10140         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10141         symmisc.c: Update all dictionary references to multidictionary.
10142
10143 2019-01-10  Keith Seitz  <keiths@redhat.com>
10144
10145         PR gdb/23712
10146         PR symtab/23010
10147         * dictionary.c: Include unordered_map.
10148         (pending_to_vector): New function.
10149         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10150         Rewrite the non-"_1" functions to take vector instead
10151         of linked list.
10152         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10153         "new" _1 versions of the same name.
10154         (multidictionary): Define.
10155         (std::hash<enum language): New definition.
10156         (collate_pending_symbols_by_language, mdict_create_hashed)
10157         (mdict_create_hashed_expandable, mdict_create_linear)
10158         (mdict_create_linear_expandable, mdict_free)
10159         (find_language_dictionary, create_new_language_dictionary)
10160         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10161         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10162         (mdict_size, mdict_empty): New functions.
10163         * dictionary.h (mdict_iterator): Define.
10164
10165 2019-01-10  Pedro Alves  <palves@redhat.com>
10166
10167         * breakpoint.c (read_uploaded_action)
10168         (create_tracepoint_from_upload): Adjust to use
10169         gdb::unique_xmalloc_ptr.
10170         * ctf.c (ctf_write_uploaded_tp):
10171         (SET_ARRAY_FIELD): Use emplace_back.
10172         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10173         * tracefile-tfile.c (tfile_write_uploaded_tp):
10174         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10175         gdb::unique_xmalloc_ptr.
10176         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10177         at_string, cond_string, cmd_strings>: Replace char pointers
10178         with gdb::unique_xmalloc_ptr.
10179
10180 2019-01-10  Pedro Alves  <palves@redhat.com>
10181
10182         * solib-target.c (library_list_start_library): Don't xstrdup name.
10183
10184 2019-01-10  Pedro Alves  <palves@redhat.com>
10185
10186         * mdebugread.c (parse_partial_symbols): Use
10187         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10188
10189 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10190
10191         * linux-fork.c (scoped_switch_fork_info)
10192         <~scoped_switch_fork_info>: Fix incorrect variable name.
10193
10194 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10195
10196         * linux-fork.c (scoped_switch_fork_info)
10197         <scoped_switch_fork_info>: Make explicit.
10198         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10199
10200 2019-01-10  Tom Tromey  <tom@tromey.com>
10201
10202         * objfiles.h (objfile::reset_psymtabs): Update.
10203         * objfiles.c (objfile::objfile): Update.
10204         * psymtab.h (psymtab_storage::obstack): Update.
10205         (psymtab_storage::m_obstack): Use gdb::optional.
10206         (class psymtab_storage): Update comment.  Remove objfile
10207         parameter.
10208         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10209
10210 2019-01-10  Tom Tromey  <tom@tromey.com>
10211
10212         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10213         <free_psymtabs>: Now private.
10214         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10215         (allocate_psymtab): Use new method.
10216
10217 2019-01-10  Tom Tromey  <tom@tromey.com>
10218
10219         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10220         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10221         * mdebugread.c (parse_partial_symbols): Use
10222         allocate_dependencies.
10223         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10224         allocate_dependencies.
10225         (process_psymtab_comp_unit_reader)
10226         (build_type_psymtab_dependencies): Likewise.
10227         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10228
10229 2019-01-10  Tom Tromey  <tom@tromey.com>
10230
10231         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10232         PSYMBOL_SET_LANGUAGE.
10233         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10234
10235 2019-01-10  Tom Tromey  <tom@tromey.com>
10236
10237         * psymtab.h (psymtab_storage::obstack): New method.
10238         <m_obstack>: Rename from obstack; now private.
10239         * psymtab.c (psymtab_storage): Update.
10240         * dwarf2read.c (create_addrmap_from_index)
10241         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10242         Update.
10243
10244 2019-01-10  Tom Tromey  <tom@tromey.com>
10245
10246         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10247         * objfiles.h (objfile::reset_psymtabs): New method.
10248
10249 2019-01-10  Tom Tromey  <tom@tromey.com>
10250
10251         * symmisc.c (print_symbol_bcache_statistics): Update.
10252         (print_objfile_statistics): Update.
10253         * symfile.c (reread_symbols): Update.
10254         * psymtab.h (class psymtab_storage): New.
10255         * psymtab.c (psymtab_storage): New constructor.
10256         (~psymtab_storage): New destructor.
10257         (require_partial_symbols): Update.
10258         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10259         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10260         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10261         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10262         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10263         (start_psymtab_common, end_psymtab_common)
10264         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10265         (allocate_psymtab): Update.
10266         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10267         Update.
10268         (dump_psymtab_addrmap, maintenance_print_psymbols)
10269         (maintenance_check_psymtabs): Update.
10270         (class objfile_psymtabs): Move to objfiles.h.
10271         * psympriv.h (discard_psymtab): Now inline.
10272         (psymtab_discarder::psymtab_discarder): Update.
10273         (psymtab_discarder::~psymtab_discarder): Update.
10274         (ALL_OBJFILE_PSYMTABS): Rewrite.
10275         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10276         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10277         Remove fields.
10278         <partial_symtabs>: New field.
10279         (class objfile_psymtabs): Move from psymtab.h.  Update.
10280         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10281         psymbol_cache.
10282         (objfile::~objfile): Don't destroy psymbol_cache.
10283         * mdebugread.c (parse_partial_symbols): Update.
10284         * dwarf2read.c (create_addrmap_from_index)
10285         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10286         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10287         (add_partial_subprogram, dwarf2_ranges_read): Update.
10288         * dwarf-index-write.c (write_address_map)
10289         (write_one_signatured_type, recursively_write_psymbols)
10290         (class debug_names, class debug_names, write_psymtabs_to_index):
10291         Update.
10292
10293 2019-01-10  Tom Tromey  <tom@tromey.com>
10294
10295         * symtab.h (SYMBOL_SET_NAMES): Update.
10296         (symbol_set_names): Update.
10297         (MSYMBOL_SET_NAMES): Update.
10298         * symtab.c (symbol_set_names): Change argument to be an
10299         objfile_per_bfd_storage.
10300         * psymtab.c (add_psymbol_to_bcache): Update.
10301         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10302
10303 2019-01-10  Tom Tromey  <tom@tromey.com>
10304
10305         * symtab.c (create_demangled_names_hash): Change argument to be an
10306         objfile_per_bfd_storage.
10307         (symbol_set_names): Update.
10308
10309 2019-01-10  Tom Tromey  <tom@tromey.com>
10310
10311         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10312         init_psymbol_list.
10313         * psymtab.c (init_psymbol_list): Do nothing if already called.
10314         * psympriv.h (init_psymbol_list): Add comment.
10315         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10316         init_psymbol_list.
10317         * dbxread.c (dbx_symfile_read): Unconditionally call
10318         init_psymbol_list.
10319
10320 2019-01-10  Tom Tromey  <tom@tromey.com>
10321
10322         * xcoffread.c (scan_xcoff_symtab): Update.
10323         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10324         "where".
10325         * mdebugread.c (parse_partial_symbols)
10326         (handle_psymbol_enumerators): Update.
10327         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10328         * dbxread.c (read_dbx_symtab): Update.
10329         * psympriv.h (psymbol_placement): New enum.
10330         (add_psymbol_to_list): Update.
10331
10332 2019-01-10  Tom Tromey  <tom@tromey.com>
10333
10334         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10335         static_psymbols parameters.
10336         (scan_xcoff_symtab): Update.
10337         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10338         static_psymbols parameters.
10339         * psympriv.h (start_psymtab_common): Update.
10340         * mdebugread.c (parse_partial_symbols): Update.
10341         * dwarf2read.c (create_partial_symtab): Update.
10342         * dbxread.c (read_dbx_symtab): Update.
10343         (start_psymtab): Remove global_psymbols and static_psymbols
10344         parameters.
10345
10346 2019-01-10  Tom Tromey  <tom@tromey.com>
10347
10348         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10349         * psymtab.c (allocate_psymtab): Add comment.
10350         * psympriv.h (allocate_psymtab): Add comment.
10351         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10352         initializations.
10353         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10354
10355 2019-01-10  Tom Tromey  <tom@tromey.com>
10356
10357         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10358         Don't declare.
10359         * mipsread.c: Include mdebugread.h.
10360         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10361         Declare.
10362         * elfread.c: Include mdebugread.h.
10363
10364 2019-01-09  Tom Tromey  <tom@tromey.com>
10365
10366         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10367         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10368         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10369         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10370         (psym_lookup_symbol, psym_find_last_source_symtab)
10371         (psym_forget_cached_source_info, psym_print_stats)
10372         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10373         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10374         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10375         (psym_find_compunit_symtab_by_address)
10376         (maintenance_print_psymbols, maintenance_info_psymtabs)
10377         (maintenance_check_psymtabs): Use ranged for.
10378         * psymtab.h (class objfile_psymtabs): New.
10379         (require_partial_symbols): Return objfile_psymtabs.
10380         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10381
10382 2019-01-09  Tom Tromey  <tom@tromey.com>
10383
10384         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10385         (find_pc_mapped_section, list_overlays_command)
10386         (map_overlay_command, unmap_overlay_command)
10387         (simple_overlay_update): Use all_objfiles.
10388         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10389         * printcmd.c (info_symbol_command): Use all_objfiles.
10390         * objfiles.h (ALL_OBJSECTIONS): Remove.
10391         * maint.c (maintenance_translate_address): Use all_objfiles.
10392         * gcore.c (gcore_create_callback): Use all_objfiles.
10393         (objfile_find_memory_regions): Likewise.
10394
10395 2019-01-09  Tom Tromey  <tom@tromey.com>
10396
10397         * symtab.c (find_line_symtab, info_sources_command)
10398         (make_source_files_completion_list): Use objfile_compunits.
10399         * source.c (select_source_symtab): Use objfile_compunits.
10400         * objfiles.h (struct objfile): Update comment.
10401         (ALL_OBJFILES): Remove.
10402         (ALL_FILETABS): Remove.
10403         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10404         objfile_compunits.
10405
10406 2019-01-09  Tom Tromey  <tom@tromey.com>
10407
10408         * symmisc.c (print_objfile_statistics, dump_objfile)
10409         (maintenance_print_symbols): Use compunit_filetabs.
10410         * source.c (forget_cached_source_info_for_objfile): Use
10411         compunit_filetabs.
10412         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10413         (ALL_FILETABS): Use compunit_filetabs.
10414         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10415         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10416
10417 2019-01-09  Tom Tromey  <tom@tromey.com>
10418
10419         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10420         (compunit_filetabs): New.
10421         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10422         compunit_filetabs.
10423         (info_sources_command, make_source_files_completion_list): Remove
10424         declaration.
10425         * symmisc.c (print_objfile_statistics, dump_objfile)
10426         (maintenance_print_symbols): Remove declaration.
10427         (maintenance_info_symtabs): Use compunit_filetabs.
10428         (maintenance_info_line_tables): Likewise.
10429         * source.c (select_source_symtab): Change local variable name.
10430         (forget_cached_source_info_for_objfile): Remove declaration.
10431         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10432         * objfiles.c (objfile_relocate1): Remove declaration.
10433         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10434         declaration.
10435         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10436         * coffread.c (coff_symtab_read): Remove declaration.
10437         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10438         compunit_filetabs.
10439
10440 2019-01-09  Tom Tromey  <tom@tromey.com>
10441
10442         * symtab.c (lookup_objfile_from_block)
10443         (find_pc_sect_compunit_symtab, search_symbols)
10444         (default_collect_symbol_completion_matches_break_on): Use
10445         objfile_compunits.
10446         * objfiles.h (ALL_COMPUNITS): Remove.
10447         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10448         * cp-support.c (add_symbol_overload_list_qualified): Use
10449         objfile_compunits.
10450         * ada-lang.c (ada_collect_symbol_completion_matches)
10451         (ada_add_global_exceptions): Use objfile_compunits.
10452
10453 2019-01-09  Tom Tromey  <tom@tromey.com>
10454
10455         * source.c (select_source_symtab)
10456         (forget_cached_source_info_for_objfile): Remove declaration.
10457         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10458         declaration.
10459         * maint.c (count_symtabs_and_blocks): Remove declaration.
10460         * cp-support.c (add_symbol_overload_list_qualified): Remove
10461         declaration.
10462         * coffread.c (coff_symtab_read): Remove declaration.
10463         * symtab.c (lookup_symbol_in_objfile_symtabs)
10464         (basic_lookup_transparent_type_1): Use objfile_compunits.
10465         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10466         (info_sources_command, search_symbols)
10467         (default_collect_symbol_completion_matches_break_on)
10468         (make_source_files_completion_list): Remove declaration.
10469         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10470         (ada_collect_symbol_completion_matches)
10471         (ada_add_global_exceptions): Remove declaration.
10472         * linespec.c (iterate_over_all_matching_symtabs): Use
10473         objfile_compunits.
10474         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10475         (class objfile_compunits): New.
10476         (ALL_COMPUNITS): Use objfile_compunits.
10477         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10478         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10479         objfile_compunits.
10480         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10481
10482 2019-01-09  Tom Tromey  <tom@tromey.com>
10483
10484         * symtab.c (search_symbols)
10485         (default_collect_symbol_completion_matches_break_on): Use
10486         objfile_msymbols.
10487         * ada-lang.c (ada_lookup_simple_minsym)
10488         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10489         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10490         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10491         objfile_msymbols.
10492         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10493         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10494         * objc-lang.c (find_methods): Use objfile_msymbols.
10495         (info_selectors_command, info_classes_command): Likewise.
10496         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10497         * objfiles.h (class objfile_msymbols): New.
10498         (ALL_OBJFILE_MSYMBOLS): Remove.
10499         (ALL_MSYMBOLS): Remove.
10500
10501 2019-01-09  Tom Tromey  <tom@tromey.com>
10502
10503         * common/next-iterator.h (next_adapter): Add Iterator template
10504         parameter.
10505         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10506         (class all_objfiles_safe): New.
10507         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10508         * objfiles.c (put_objfile_before): Update comment.
10509         (add_separate_debug_objfile): Likewise.
10510         (free_all_objfiles): Use all_objfiles_safe.
10511         (objfile_purge_solibs): Likewise.
10512
10513 2019-01-09  Tom Tromey  <tom@tromey.com>
10514
10515         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10516         (expand_symtab_containing_pc, lookup_static_symbol)
10517         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10518         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10519         all_objfiles.
10520         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10521         * breakpoint.c (create_overlay_event_breakpoint)
10522         (create_longjmp_master_breakpoint)
10523         (create_std_terminate_master_breakpoint)
10524         (create_exception_master_breakpoint): Use all_objfiles.
10525         * linux-thread-db.c (try_thread_db_load_from_pdir)
10526         (has_libpthread): Use all_objfiles.
10527         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10528         * linespec.c (iterate_over_all_matching_symtabs)
10529         (search_minsyms_for_name): Use all_objfiles.
10530         * maint.c (maintenance_info_sections): Use all_objfiles.
10531         * main.c (captured_main_1): Use all_objfiles.
10532         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10533         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10534         * guile/scm-pretty-print.c
10535         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10536         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10537         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10538         (maintenance_print_msymbols): Use all_objfiles.
10539         * source.c (select_source_symtab): Use all_objfiles.
10540         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10541         * symfile.c (remove_symbol_file_command)
10542         (expand_symtabs_matching, map_symbol_filenames): Use
10543         all_objfiles.
10544         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10545         all_objfiles.
10546         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10547         * objc-lang.c (find_methods): Use all_objfiles.
10548         * objfiles.c (have_partial_symbols, have_full_symbols)
10549         (have_minimal_symbols, qsort_cmp)
10550         (default_iterate_over_objfiles_in_search_order): Use
10551         all_objfiles.
10552         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10553         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10554         (maintenance_check_psymtabs): Use all_objfiles.
10555         (ALL_PSYMTABS): Remove.
10556         * compile/compile-object-run.c (do_module_cleanup): Use
10557         all_objfiles.
10558         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10559         * cp-support.c (add_symbol_overload_list_qualified): Use
10560         all_objfiles.
10561         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10562         Use all_objfiles.
10563         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10564         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10565         all_objfiles.
10566         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10567         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10568         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10569         Uses all_objfiles.
10570         * solib.c (solib_read_symbols): Use all_objfiles
10571
10572 2019-01-09  Tom Tromey  <tom@tromey.com>
10573
10574         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10575         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10576         all_objfiles.
10577         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10578         * symmisc.c (print_symbol_bcache_statistics)
10579         (print_objfile_statistics, maintenance_print_objfiles)
10580         (maintenance_info_symtabs, maintenance_check_symtabs)
10581         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10582         all_objfiles.
10583         * source.c (forget_cached_source_info): Use all_objfiles.
10584         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10585         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10586         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10587         * objfiles.c (update_section_map): Use all_objfiles.
10588         (shared_objfile_contains_address_p): Likewise.
10589         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10590         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10591
10592 2019-01-09  Tom Tromey  <tom@tromey.com>
10593
10594         * common/next-iterator.h: New file.
10595         * objfiles.h (class all_objfiles): New.
10596         (struct objfile_iterator): New.
10597
10598 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10599
10600         * NEWS: Move the description of the changed "frame", "select-frame",
10601          and "info frame" commands to the Changed commands section.
10602
10603 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10604
10605         * gdbtypes.c (check_stub_method_group): Remove handling of old
10606         mangling schemes.
10607         * linespec.c (find_methods): Likewise.
10608         * stabsread.c (read_member_functions): Likewise.
10609         * valops.c (search_struct_method): Likewise.
10610         (value_struct_elt_for_reference): Likewise.
10611         * NEWS: Mention this change.
10612
10613 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10614
10615         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10616         print_source_lines.
10617         * source.c (print_source_lines_base): Update line number check.
10618         (print_source_lines): New function.
10619         (source_lines_range::source_lines_range): New function.
10620         * source.h (class source_lines_range): New class.
10621         (print_source_lines): New declaration.
10622
10623 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10624
10625         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10626
10627 2019-01-08  Tom Tromey  <tom@tromey.com>
10628             Simon Marchi  <simon.marchi@ericsson.com>
10629
10630         PR gdb/24060
10631         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10632         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10633         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10634         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10635         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10636         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10637
10638 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10639
10640         * source.c (select_source_symtab): Move header comment to
10641         declaration in source.h.
10642         (forget_cached_source_info_for_objfile): Likewise.
10643         (forget_cached_source_info): Likewise.
10644         (identify_source_line): Likewise.
10645         * source.h (identify_source_line): Move declaration from symtab.h
10646         and add comment from source.c
10647         (print_source_lines): Likewise.
10648         (forget_cached_source_info_for_objfile): Likewise.
10649         (forget_cached_source_info): Likewise.
10650         (select_source_symtab): Likewise.
10651         (enum print_source_lines_flag): Move definition from symtab.h.
10652         * symtab.h (identify_source_line): Move declaration to source.h.
10653         (print_source_lines): Likewise.
10654         (forget_cached_source_info_for_objfile): Likewise.
10655         (forget_cached_source_info): Likewise.
10656         (select_source_symtab): Likewise.
10657         (enum print_source_lines_flag): Move definition to source.h.
10658         * tui/tui-hooks.c: Add 'source.h' include.
10659
10660 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10661
10662         * source.c (print_source_lines_base): Handle requests to print
10663         reverse line number sequences, and guard against empty lines
10664         string.
10665
10666 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10667
10668         * source.c (print_source_lines_base): Fix skip of '\r' if next
10669         character is '\n'.
10670
10671 2019-01-06  Tom Tromey  <tom@tromey.com>
10672
10673         * c-exp.y (struct c_parse_state) <macro_original_text,
10674         expansion_obstack>: New member.
10675         (macro_original_text, expansion_obstack): Remove globals.
10676         (scan_macro_expansion, scanning_macro_expansion)
10677         (finished_macro_expansion): Update.
10678         (scan_macro_cleanup): Remove.
10679         (yylex, c_parse): Update.
10680
10681 2019-01-06  Tom Tromey  <tom@tromey.com>
10682
10683         * c-exp.y (struct c_parse_state) <strings>: New member.
10684         (operator_stoken): Update.
10685
10686 2019-01-06  Tom Tromey  <tom@tromey.com>
10687
10688         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10689         (union type_stack_elt) <typelist_val>: Now a pointer to
10690         std::vector.
10691         (type_stack_cleanup): Don't declare.
10692         (push_typelist): Update.
10693         * parse.c (pop_typelist): Return a std::vector.
10694         (push_typelist): Take a std::vector.
10695         (follow_types): Update.  Do not free args.
10696         (type_stack_cleanup): Remove.
10697         * c-exp.y (struct c_parse_state): New.
10698         (cpstate): New global.
10699         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10700         (nonempty_typelist): Update.
10701         (func_mod): Create a new vector.
10702         (c_parse): Create a c_parse_state.
10703         (check_parameter_typelist): Do not delete params.
10704         (function_method): Update.  Do not delete type_list.
10705
10706 2019-01-06  Tom Tromey  <tom@tromey.com>
10707
10708         PR gdb/28155:
10709         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10710         check_typedef.
10711         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10712         (print_return_value): Likewise.
10713
10714 2019-01-05  Tom Tromey  <tom@tromey.com>
10715
10716         * contrib/cleanup_check.py: Remove.
10717         * contrib/gcc-with-excheck: Remove.
10718         * contrib/exsummary.py: Remove.
10719         * contrib/excheck.py: Remove.
10720
10721 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10722
10723         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10724         NULL. Initialize tpprev to NULL instead of assigning it
10725         to NULL on the next statement.
10726         * windows-nat.c (windows_delete_thread): Remove check for
10727         main_thread_id before printing thread exit notifications.
10728         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10729         Remove thread ID check against main_thread_id.
10730         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10731         windows_delete_thread.
10732         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10733
10734 2019-01-04  Tom Tromey  <tom@tromey.com>
10735
10736         * compile/compile.c (_initialize_compile): Use upper case for
10737         metasyntactic variables.
10738         * symmisc.c (_initialize_symmisc): Use upper case for
10739         metasyntactic variables.
10740         * psymtab.c (_initialize_psymtab): Use upper case for
10741         metasyntactic variables.
10742         * demangle.c (demangle_command): Use upper case for metasyntactic
10743         variables.
10744         (_initialize_demangler): Likewise.
10745         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10746         variables.
10747
10748 2019-01-03  Tom Tromey  <tom@tromey.com>
10749
10750         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10751
10752 2019-01-03  Tom Tromey  <tom@tromey.com>
10753
10754         * python/py-symtab.c (salpy_str): Update.
10755         (struct salpy_sal_object) <symtab>: Now a PyObject.
10756         (salpy_dealloc): Update.
10757         (del_objfile_sal): Use gdbpy_ref.
10758
10759 2019-01-03  Tom Tromey  <tom@tromey.com>
10760
10761         * python/py-type.c (convert_field): Use new_reference.  Return
10762         gdbpy_ref.
10763         (make_fielditem): Return gdbpy_ref.
10764         (typy_fields): Update.
10765         (typy_getitem): Update.
10766         (field_name): Return gdbpy_ref.  Use new_reference.
10767         (typy_iterator_iternext): Update.
10768
10769 2019-01-03  Tom Tromey  <tom@tromey.com>
10770
10771         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10772
10773 2019-01-03  Tom Tromey  <tom@tromey.com>
10774
10775         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10776         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10777         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10778         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10779         (pspy_set_type_printers): Likewise.
10780         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10781         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10782         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10783         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10784         (objfpy_set_type_printers): Likewise.
10785
10786 2019-01-03  Tom Tromey  <tom@tromey.com>
10787
10788         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10789         (gdbpy_print_stack): Use gdbpy_err_fetch.
10790         * python/python-internal.h (class gdbpy_err_fetch): New class.
10791         (class gdbpy_enter) <m_error_type, m_error_value,
10792         m_error_traceback>: Remove.
10793         <m_error>: New member.
10794         (gdbpy_exception_to_string): Don't declare.
10795         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10796         * python/py-value.c (convert_value_from_python): Use
10797         gdbpy_err_fetch.
10798         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10799         gdbpy_exception_to_string.
10800         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10801         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10802         gdbpy_err_fetch.
10803
10804 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10805
10806         * linux-nat.c (delete_lwp_cleanup): Delete.
10807         (struct lwp_deleter): New struct.
10808         (lwp_info_up): New typedef.
10809         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10810         lwp_info_up.
10811
10812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10813
10814         * linux-fork.c (class scoped_switch_fork_info): New class.
10815         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10816
10817 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10818
10819         * valops.c (find_overload_match): Remove use of null_cleanup, and
10820         calls to do_cleanups.
10821
10822 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10823
10824         * compile/compile-cplus-types.c
10825         (compile_cplus_instance::decl_name): Handle changes to
10826         cp_func_name.
10827         * cp-support.c (cp_func_name): Update header comment, update
10828         return type.
10829         * cp-support.h (cp_func_name): Update return type in declaration.
10830         * valops.c (find_overload_match): Move temp_func local to top
10831         level of function and change its type.  Use temp_func to hold and
10832         delete temporary string obtained from cp_func_name.
10833
10834 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10835
10836         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10837         gdb::char_vector, remove cleanup, and update uses of `msg`.
10838
10839 2019-01-03  Jim Wilson  <jimw@sifive.com>
10840
10841         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10842
10843 2019-01-02  Tom Tromey  <tom@tromey.com>
10844
10845         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10846         (tdesc_parse_xml): Remove cleanups.
10847         * target-descriptions.h (make_cleanup_free_target_description):
10848         Don't declare.
10849         (target_desc_deleter): New struct.
10850         (target_desc_up): New typedef.
10851         * target-descriptions.c (target_desc_deleter::operator()): Rename
10852         from free_target_description.
10853         (make_cleanup_free_target_description): Remove.
10854
10855 2019-01-02  Tom Tromey  <tom@tromey.com>
10856
10857         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10858         constructor, destructor.
10859         (linespec_parser): Remove typedef.
10860         (~linespec_parser): Rename from linespec_parser_delete.
10861         (linespec_lex_to_end, linespec_complete_label)
10862         (linespec_complete): Update.
10863         (decode_line_full): Remove cleanups.
10864         (decode_line_1): Update.
10865
10866 2019-01-02  Tom Tromey  <tom@tromey.com>
10867
10868         * python/python-internal.h (inferior_to_inferior_object): Change
10869         return type.
10870         * python/py-exitedevent.c (create_exited_event_object): Update.
10871         * python/py-inferior.c (inferior_to_inferior_object): Return
10872         gdbpy_ref.
10873         (python_new_inferior, python_inferior_deleted)
10874         (thread_to_thread_object, delete_thread_object)
10875         (build_inferior_list, gdbpy_selected_inferior): Update.
10876         * python/py-infthread.c (create_thread_object): Update.  Also fail
10877         if inferior_to_inferior_object fails.
10878
10879 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10880
10881         * inferior.h (class inferior) <displaced_step_state>: New field.
10882         * infrun.h (struct displaced_step_state): Move here from
10883         infrun.c.  Initialize fields, add constructor.
10884         <inf>: Remove field.
10885         <reset>: New method.
10886         * infrun.c (struct displaced_step_inferior_state): Move to
10887         infrun.h.
10888         (displaced_step_inferior_states): Remove.
10889         (get_displaced_stepping_state): Adust.
10890         (displaced_step_in_progress_any_inferior): Adjust.
10891         (displaced_step_in_progress_thread): Adjust.
10892         (displaced_step_in_progress): Adjust.
10893         (add_displaced_stepping_state): Remove.
10894         (get_displaced_step_closure_by_addr): Adjust.
10895         (remove_displaced_stepping_state): Remove.
10896         (infrun_inferior_exit): Call displaced_step_state.reset.
10897         (use_displaced_stepping): Don't check for NULL.
10898         (displaced_step_prepare_throw): Call
10899         get_displaced_stepping_state.
10900         (displaced_step_fixup): Don't check for NULL.
10901         (prepare_for_detach): Don't check for NULL.
10902
10903 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10904
10905         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10906          in case of call that did not complete.
10907
10908 2019-01-02  Andrey Utkin  <autkin@undo.io>
10909
10910         * symfile.c (find_separate_debug_file): Fix search of debug files for
10911         remote debuggee.
10912
10913 2019-01-02  Tom Tromey  <tom@tromey.com>
10914
10915         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10916         indentation.
10917         * python/py-frame.c (frapy_older): Remove cast.
10918         (frapy_newer): Likewise.
10919         * python/py-breakpoint.c (local_setattro): Remove cast.
10920         * python/py-arch.c (archpy_name): Remove local variable.
10921         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10922
10923 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10924
10925         * unittests/basic_string_view/element_access/char/empty.cc:
10926         Fix year range in copyright header.
10927
10928 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10929
10930         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10931         Delete.
10932         <operator==>: Update with for removed field.
10933         <hash>: Likewise.
10934         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10935         <isa_features>: ...this.
10936         <abi_features>: New field.
10937         (riscv_isa_flen): Update comment.
10938         (riscv_abi_xlen): New declaration.
10939         (riscv_abi_flen): New declaration.
10940         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10941         isa_features.
10942         (riscv_abi_xlen): New function.
10943         (riscv_isa_flen): Update to get answer from isa_features.
10944         (riscv_abi_flen): New function.
10945         (riscv_has_fp_abi): Update to get answer from abi_features.
10946         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10947         xlen and flen.
10948         (riscv_call_info) <xlen, flen>: Update comment.
10949         (riscv_call_arg_struct): Remove invalid assertions
10950         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10951         is removed.
10952         (riscv_gdbarch_init): Gather isa features and abi features
10953         separately, ensure both match on the gdbarch when reusing an old
10954         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10955         a target with 64-bit float hardware.
10956
10957 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10958
10959         * source.c (search_command_helper): Stop reverse search
10960         when line 1 has been searched.
10961
10962 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10963
10964         * record-full.c (record_full_base_target::close): Rewrite
10965         record_full_core_buf_list free logic.
10966
10967 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10968
10969         * break-catch-syscall.c (print_one_catch_syscall): xfree
10970         the last text.
10971
10972 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10973
10974         * top.c (print_gdb_version): Update Copyright year in version
10975         message.
10976
10977 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10978
10979         Update copyright year range in all GDB files.
10980
10981 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10982
10983         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10984
10985 For older changes see ChangeLog-2018.
10986 \f
10987 Local Variables:
10988 mode: change-log
10989 left-margin: 8
10990 fill-column: 74
10991 version-control: never
10992 coding: utf-8
10993 End:
10994