gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (make_command_window): Don't set
   4         can_highlight.
   5         (show_source_disasm_command): Call the reset method.
   6         (show_data): Don't set can_highlight.  Call the reset method.
   7         (tui_gen_win_info::reset): Rename from init_gen_win_info
   8         (init_and_make_win): Simplify.  Return tui_gen_win_info.
   9         (show_source_or_disasm_and_command): Call the reset method.
  10         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
  11         (struct tui_cmd_window): Set can_highlight.
  12
  13 2019-06-25  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
  16         from make_visible.
  17         (tui_make_visible, tui_make_invisible): Rewrite.
  18         (tui_win_info::make_visible): Remove.
  19         (tui_source_window_base::make_visible): Update.
  20         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
  21         method.  Moved from...
  22         (struct tui_win_info) <make_visible>: ...here.
  23
  24 2019-06-25  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-winsource.c
  27         (tui_source_window_base::do_scroll_horizontal): Remove direction
  28         parameter.
  29         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
  30         direction parameter.
  31         * tui/tui-win.c (tui_win_info::forward_scroll)
  32         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
  33         (tui_win_info::right_scroll): Update.
  34         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
  35         direction parameter.
  36         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
  37         direction parameter.
  38         * tui/tui-data.h (enum tui_scroll_direction): Remove.
  39         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
  40         Remove direction parameter.
  41         (struct tui_source_window_base, struct tui_source_window)
  42         (struct tui_disasm_window, struct tui_data_window)
  43         (struct tui_cmd_window): Update.
  44
  45 2019-06-25  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-winsource.h (tui_set_exec_info_content)
  48         (tui_show_exec_info_content, tui_erase_exec_info_content)
  49         (tui_clear_exec_info_content, tui_update_exec_info): Change
  50         argument to tui_source_window_base.
  51         * tui/tui-winsource.c (tui_set_exec_info_content)
  52         (tui_show_exec_info_content, tui_erase_exec_info_content)
  53         (tui_clear_exec_info_content, tui_update_exec_info): Change
  54         argument to tui_source_window_base.
  55
  56 2019-06-25  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
  59         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
  60
  61 2019-06-25  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
  64         check.
  65
  66 2019-06-25  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
  69         type to void.
  70         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
  71         type to void.
  72         * tui/tui-source.c (tui_set_source_content): Update.
  73         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  74
  75 2019-06-25  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-win.c (window_name_completer, tui_set_focus)
  78         (tui_all_windows_info): Use name method.
  79         * tui/tui-data.h (struct tui_gen_win_info)
  80         (struct tui_source_window, struct tui_disasm_window)
  81         (struct tui_data_window, struct tui_cmd_window) <name>: New
  82         method.
  83         (tui_win_name): Don't declare.
  84         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
  85         (tui_win_name): Remove.
  86
  87 2019-06-25  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-winsource.h (tui_update_source_window)
  90         (tui_update_source_window_as_is): Change parameter type.
  91         * tui/tui-winsource.c (tui_update_source_window): Change win_info
  92         to be a tui_source_window_base.
  93         (tui_update_source_window_as_is): Likewise.
  94         * tui/tui-win.c (make_visible_with_new_height): Update.
  95
  96 2019-06-25  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.c (tui_erase_source_content)
  99         (tui_show_source_content, tui_show_exec_info_content)
 100         (tui_erase_exec_info_content): Use refresh_window method.
 101         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 102         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 103         from tui_refresh_win.
 104         (tui_data_window::refresh_window): New method.
 105         (tui_win_info::refresh, tui_source_window_base::refresh)
 106         (tui_refresh_all): Use refresh_window method.
 107         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 108         method.
 109         * tui/tui-regs.c (tui_display_register): Call refresh_window
 110         method.
 111         * tui/tui-layout.c (show_source_disasm_command)
 112         (show_source_or_disasm_and_command): Call refresh_window method.
 113         * tui/tui-data.h (struct tui_gen_win_info)
 114         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 115         New method.
 116
 117 2019-06-25  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui.c (tui_rl_other_window, tui_enable)
 120         (tui_is_window_visible, tui_get_command_dimension): Update.
 121         * tui/tui-winsource.c (tui_update_source_window_as_is)
 122         (tui_clear_source_content, tui_erase_source_content)
 123         (tui_show_source_line, tui_source_window_base::refill)
 124         (tui_source_window_base::do_scroll_horizontal)
 125         (tui_source_window_base::set_is_exec_point_at)
 126         (tui_update_breakpoint_info, tui_set_exec_info_content)
 127         (tui_alloc_source_buffer, tui_line_is_displayed)
 128         (tui_addr_is_displayed): Update.
 129         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 130         (tui_check_and_display_highlight_if_needed)
 131         (tui_win_info::make_visible, tui_win_info::refresh)
 132         (tui_refresh_all): Update.
 133         * tui/tui-windata.c (tui_first_data_item_displayed)
 134         (tui_delete_data_content_windows, tui_erase_data_content)
 135         (tui_display_all_data, tui_data_window::refresh_all)
 136         (tui_check_data_values): Update.
 137         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 138         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 139         (tui_win_info::backward_scroll, tui_refresh_all_win)
 140         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 141         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 142         (tui_source_window_base::set_new_height)
 143         (tui_data_window::set_new_height)
 144         (make_invisible_and_set_new_height)
 145         (make_visible_with_new_height, new_height_ok)
 146         (parse_scrolling_args): Update.
 147         * tui/tui-stack.c (tui_show_frame_info): Update.
 148         * tui/tui-source.c (tui_set_source_content)
 149         (tui_set_source_content_nil, tui_source_is_displayed)
 150         (tui_source_window::do_scroll_vertical): Update.
 151         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 152         (tui_display_registers_from, tui_display_reg_element_at_line)
 153         (tui_check_register_values, tui_reg_command): Update.
 154         * tui/tui-layout.c (tui_default_win_height)
 155         (show_source_disasm_command, show_data, init_and_make_win)
 156         (show_source_or_disasm_and_command): Update.
 157         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 158         (tui_redisplay_readline, tui_mld_flush)
 159         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 160         (tui_getc): Update.
 161         * tui/tui-disasm.c (tui_set_disassem_content)
 162         (tui_disasm_window::do_scroll_vertical): Update.
 163         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 164         Now virtual.
 165         (struct tui_win_info): Derive from tui_gen_win_info.
 166         <~tui_win_info>: Mark as override.
 167         <generic>: Remove member.
 168         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 169         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 170         (~tui_data_window, ~tui_win_info)
 171         (tui_free_all_source_wins_content): Update.
 172         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 173
 174 2019-06-25  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-layout.c (init_and_make_win): Use new.
 177         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 178         destructor, initializers.
 179         (tui_alloc_generic_win_info): Don't declare.
 180         * tui/tui-data.c (_locator): Add argument to constructor.
 181         (source_win, disasm_win): New globals.
 182         (exec_info): Remove.
 183         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 184         Update.
 185         (tui_alloc_generic_win_info): Remove.
 186         (init_content_element): Use new.
 187         (tui_win_info::tui_win_info): Update.
 188         (free_content_elements) <case DATA_WIN>: Use delete.
 189
 190 2019-06-25  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 193         * tui/tui-windata.c (tui_first_data_item_displayed)
 194         (tui_delete_data_content_windows): Update.
 195         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 196         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 197         (tui_display_registers_from, tui_check_register_values): Update.
 198         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 199         pointer.
 200         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 201         window.
 202         (tui_free_data_content): Update.
 203         (free_content_elements) <case DATA_WIN>: Free the window.
 204
 205 2019-06-25  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 208         Update.
 209         * tui/tui-layout.c (make_command_window)
 210         (show_source_disasm_command, show_data, init_and_make_win)
 211         (show_source_or_disasm_and_command): Update.
 212         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 213         method.
 214         <can_highight, is_highlighted>: Now bool.
 215         (tui_set_win_highlight): Don't declare.
 216         * tui/tui-data.c (tui_set_win_highlight): Remove.
 217
 218 2019-06-25  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-wingeneral.c (make_visible): Remove check of window
 221         type.
 222
 223 2019-06-25  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-win.c (tui_win_info::max_height)
 226         (tui_cmd_window::max_height): New methods.
 227         (new_height_ok): Call max_height.
 228         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 229         <max_height>: New method.
 230
 231 2019-06-25  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-win.c (tui_source_window_base::set_new_height)
 234         (tui_data_window::set_new_height): New methods.
 235         (make_invisible_and_set_new_height): Call set_new_height method.
 236         * tui/tui-data.h (struct tui_win_info)
 237         (struct tui_source_window_base, struct tui_data_window)
 238         <set_new_height>: New method.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 243         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 244         tui_refresh_data_win.
 245         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 246         method.
 247         (tui_refresh_all_win): Call the refresh_all method.
 248         (tui_set_focus): Likewise.
 249         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 250         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 251         Likewise.
 252
 253 2019-06-25  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-winsource.h (tui_refill_source_window)
 256         (tui_set_is_exec_point_at): Don't declare.
 257         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 258         (tui_source_window_base::refill): Rename from
 259         tui_refill_source_window.
 260         (tui_source_window_base::do_scroll_horizontal): Update.
 261         (tui_source_window_base::set_is_exec_point_at): Rename from
 262         tui_set_is_exec_point_at.
 263         (tui_update_all_breakpoint_info): Update.
 264         * tui/tui-stack.c (tui_show_frame_info): Update.
 265         * tui/tui-layout.c (show_data): Add cast.
 266         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 267         * tui/tui-data.h (struct tui_source_window_base) <refill,
 268         set_is_exec_point_at>: New methods.
 269         (tui_source_windows, tui_add_to_source_windows): Update types.
 270         (tui_add_to_source_windows): Remove redundant declaration.
 271         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 272         (tui_source_windows): Change return type.
 273         (tui_clear_source_windows_detail): Update.
 274         (tui_add_to_source_windows): Change type of parameter.
 275         (tui_free_all_source_wins_content): Update.
 276
 277 2019-06-25  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-wingeneral.c (tui_win_info::refresh)
 280         (tui_source_window_base::refresh): New methods.
 281         (tui_refresh_all): Call the refresh method.
 282         * tui/tui-data.h (struct tui_win_info)
 283         (struct tui_source_window_base) <refresh>: New method.
 284
 285 2019-06-25  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui.h (tui_is_window_visible): Return bool.
 288         * tui/tui.c (tui_is_window_visible): Return bool.
 289         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 290         (tui_make_visible, tui_make_invisible)
 291         (tui_win_info::make_visible)
 292         (tui_source_window_base::make_visible, make_all_visible)
 293         (tui_make_all_visible, tui_make_all_invisible): Update.
 294         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 295         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 296         bool.
 297         (struct tui_win_info, struct tui_source_window_base)
 298         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 299         * tui/tui-data.c (tui_init_generic_part): Update.
 300
 301 2019-06-25  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 304         (tui_source_window_base::make_visible): New methods.
 305         (make_all_visible): Make method call.
 306         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 307         (struct tui_source_window_base, struct tui_cmd_window): Override
 308         make_visible.
 309         (tui_win_is_source_type): Don't declare.
 310         * tui/tui-data.c (tui_win_is_source_type): Remove.
 311
 312 2019-06-25  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 315         NULL check.
 316
 317 2019-06-25  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 320         Inline constructor.  Add initializers for members.
 321         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 322         constructors; now inline in class.
 323
 324 2019-06-25  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-regs.c (tui_show_registers): Update.
 327         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 328         bool.
 329         * tui/tui-data.c (tui_data_window::clear_detail)
 330         (tui_data_window): Update.
 331
 332 2019-06-25  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-windata.c (tui_display_all_data)
 335         (tui_display_data_from_line, tui_display_data_from)
 336         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 337         Update.
 338         * tui/tui-regs.c (tui_last_regs_line_no)
 339         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 340         (tui_show_registers, tui_show_register_group)
 341         (tui_display_registers_from, tui_display_reg_element_at_line)
 342         (tui_display_registers_from_line, tui_check_register_values)
 343         (tui_reg_next, tui_reg_prev): Update.
 344         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 345         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 346         tui_data_window.
 347         (struct tui_win_info) <detail>: Remove.  Add new fields from
 348         tui_data_info.
 349         (TUI_DATA_WIN): Add cast.
 350         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 351         (~tui_data_window): Simplify.
 352
 353 2019-06-25  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-layout.c (show_source_disasm_command)
 356         (show_source_or_disasm_and_command): Update.
 357         * tui/tui-io.c (update_cmdwin_start_line)
 358         (tui_redisplay_readline): Update.
 359         * tui/tui-data.h (struct tui_command_info): Remove.
 360         (struct tui_win_info) <detail>: Remove command_info member.
 361         (struct tui_data_window) <start_line>: New member, from
 362         tui_command_info.
 363         (TUI_CMD_WIN): Add casts.
 364
 365 2019-06-25  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-winsource.c (tui_update_source_window)
 368         (tui_refill_source_window)
 369         (tui_source_window_base::do_scroll_horizontal)
 370         (tui_update_breakpoint_info, tui_set_exec_info_content)
 371         (tui_show_exec_info_content, tui_erase_exec_info_content)
 372         (tui_clear_exec_info_content): Update.
 373         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 374         Update.
 375         * tui/tui-win.c (make_invisible_and_set_new_height)
 376         (make_visible_with_new_height): Update.
 377         * tui/tui-source.c (tui_set_source_content)
 378         (tui_show_symtab_source): Update.
 379         * tui/tui-layout.c (extract_display_start_addr)
 380         (show_source_disasm_command, show_data)
 381         (make_source_or_disasm_window)
 382         (show_source_or_disasm_and_command): Update.
 383         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 384         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 385         "gdbarch".
 386         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 387         to tui_source_window_base.
 388         (struct tui_win_info) <detail>: Remove source_info member.
 389         (struct tui_source_window_base) <has_locator>: Inline.
 390         Move contents from tui_source_info; rename has_locator member to
 391         m_has_locator.
 392         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 393         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 394         header file.
 395         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 396         Simplify.
 397         (tui_free_all_source_wins_content): Cast to
 398         tui_source_window_base.
 399
 400 2019-06-25  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-win.c (make_invisible_and_set_new_height)
 403         (make_visible_with_new_height): Call has_locator method.
 404         * tui/tui-layout.c (show_source_disasm_command, show_data)
 405         (show_source_or_disasm_and_command): Update for bool change.
 406         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 407         (tui_win_info) <has_locator>: New method.
 408         (struct tui_source_window_base) <has_locator>: New method.
 409         (tui_win_has_locator): Don't declare.
 410         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 411         from tui_win_has_locator.
 412         (tui_source_window_base): Use false, not FALSE.
 413
 414 2019-06-25  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 417         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 418         clear_detail method directly.
 419         (tui_clear_win_detail): Remove.
 420
 421 2019-06-25  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 424         "this", not TUI_DISASM_WIN.
 425
 426 2019-06-25  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 429         declare.
 430         * tui/tui-winsource.c
 431         (tui_source_window_base::do_scroll_horizontal): Rename from
 432         tui_horizontal_source_scroll.
 433         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 434         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 435         from tui_vertical_data_scroll.
 436         * tui/tui-win.h (tui_scroll): Don't declare.
 437         * tui/tui-win.c (tui_win_info::forward_scroll)
 438         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 439         (tui_win_info::right_scroll): Rename and update.
 440         (tui_scroll_forward_command, tui_scroll_backward_command)
 441         (tui_scroll_left_command, tui_scroll_right_command): Update.
 442         (tui_scroll): Remove.
 443         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 444         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 445         from tui_vertical_source_scroll.
 446         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 447         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 448         from tui_vertical_disassem_scroll.
 449         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 450         do_scroll_horizontal>: New methods.
 451         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 452         Likewise.
 453         (struct tui_source_window_base): Add do_scroll_horizontal.
 454         (struct tui_source_window, struct tui_disasm_window): Add
 455         do_scroll_vertical.
 456         (struct tui_data_window, struct tui_cmd_window): Add
 457         do_scroll_horizontal and do_scroll_vertical.
 458         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 459
 460 2019-06-25  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-data.h (struct tui_source_window_base): New struct.
 463         (struct tui_source_window): Derive from tui_source_window_base.
 464         (struct tui_disasm_window): New struct.
 465         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 466         from tui_source_window::clear_detail.
 467         (tui_source_window_base): Rename from tui_source_window.
 468         (~tui_source_window_base): Rename from ~tui_source_window.
 469         (tui_alloc_win_info): Create a tui_disasm_window.
 470
 471 2019-06-25  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-data.h (struct tui_source_window)
 474         (struct tui_data_window): Declare destructors.
 475         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 476         destructors.
 477         (tui_win_info): Simplify.
 478
 479 2019-06-25  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-winsource.c (tui_display_main)
 482         (tui_update_source_windows_with_addr)
 483         (tui_update_all_breakpoint_info): Update.
 484         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 485         (new_height_ok, parse_scrolling_args): Update.
 486         * tui/tui-stack.c (tui_show_frame_info): Update.
 487         * tui/tui-data.h (struct tui_list): Remove.
 488         (tui_source_windows): Return a reference to a std::vector.
 489         * tui/tui-data.c (source_windows): Now a std::vector.
 490         (tui_source_windows): Change return type.
 491         (tui_clear_source_windows): Rewrite.
 492         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 493         (tui_free_all_source_wins_content): Rewrite.
 494
 495 2019-06-25  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 498         (struct tui_data_window, struct tui_cmd_window): Declare
 499         clear_detail method.
 500         * tui/tui-data.c (tui_source_window::clear_detail)
 501         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 502         methods.
 503         (tui_clear_win_detail): Simplify.
 504
 505 2019-06-25  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-layout.c (make_source_window, make_disasm_window)
 508         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 509         Return the new window.
 510         (show_source_disasm_command, show_data)
 511         (show_source_or_disasm_and_command): Update.
 512
 513 2019-06-25  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 516         parameter.  Return the new window.
 517         (show_source_disasm_command): Update and remove NULL check.
 518         (show_source_or_disasm_and_command): Update.
 519
 520 2019-06-25  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 523
 524 2019-06-25  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-data.h (struct tui_win_info): Make constructor
 527         protected.  Make destructor virtual.  Add initializers.
 528         (tui_source_window, tui_data_window, tui_cmd_window): New
 529         classes.
 530         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 531         constructor.  Add "type" parameter.
 532         (tui_source_window, tui_data_window, tui_cmd_window): New
 533         constructors.
 534         (tui_alloc_win_info): Instantiate the appropriate subclass.
 535
 536 2019-06-25  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-win.c (tui_resize_all): Use delete.
 539         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 540         destructor.
 541         (tui_free_window): Don't declare.
 542         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 543         Update.
 544
 545 2019-06-25  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-data.h (struct tui_win_info): Add constructor.
 548         * tui/tui-data.c (tui_alloc_win_info): Use new.
 549         (tui_free_window): Use delete.
 550
 551 2019-06-22  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 554         declare.
 555         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 556
 557 2019-06-22  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 560         declare.
 561         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 562
 563 2019-06-22  Tom de Vries  <tdevries@suse.de>
 564
 565         * dwarf2read.c (create_addrmap_from_aranges)
 566         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 567         instead of '%zu'.
 568
 569 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 570
 571         * dwarf2read.h (dwarf2_section_info_def): Remove.
 572         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 573         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 574         std::vector<dwarf2_section_info>.
 575         (struct dwo_file) <~dwo_file>: Remove.
 576         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 577         types field.
 578         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 579         (dwarf2_read_debug_names): Likewise.
 580         (create_debug_types_hash_table): Change parameter type to
 581         array_view, adjust code accordingly.
 582         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 583         (partial_die_info::fixup): Likewise.
 584         (determine_prefix): Likewise.
 585         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 586
 587 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 588
 589         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 590         gdb_bfd_ref_ptr.
 591         <~dwo_file>: Remove call to gdb_bfd_unref.
 592         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 593         gdb_bfd_ref_ptr::get.
 594
 595 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 596
 597         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 598         type to htab_up.
 599         * dwarf2read.c (struct dwo_file): Initialize fields.
 600         <~dwo_file>: New.
 601         (free_dwo_file): Remove, move content to ~dwo_file.
 602         (struct dwo_file_deleter): Remove.
 603         (dwo_file_up>: Remove custom deleter.
 604         (free_dwo_files): Remove.
 605         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 606         dwo_files.
 607         (process_skeletonless_type_units): Call unique_ptr::get.
 608         (allocate_dwo_file_hash_table): Add deleter to created hash
 609         table.  Change return type to htab_up.
 610         (lookup_dwo_file_slot): Don't memset dwo_file, call
 611         unique_ptr::get.
 612         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 613         (create_dwo_unit_in_dwp_v2): Likewise.
 614         (open_and_init_dwo_file): Likewise.
 615         (free_dwo_file_from_slot): Remove.
 616
 617 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 618
 619         * dwarf2read.h (struct dwarf2_section_info) <readin,
 620         is_virtual>: Change type to bool.
 621         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 622         true instead of 1.
 623
 624 2019-06-19  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-data.h (tui_init_content_element): Don't declare.
 627
 628 2019-06-19  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-data.h (tui_init_win_info): Don't declare.
 631
 632 2019-06-19  Tom de Vries  <tdevries@suse.de>
 633
 634         * dwarf2read.h (abstract_to_concrete): Change type to
 635         std::unordered_map<sect_offset, std::vector<sect_offset>,
 636         gdb::hash_enum<sect_offset>>.
 637
 638 2019-06-19  Tom Tromey  <tromey@adacore.com>
 639
 640         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 641         EVAL_AVOID_SIDE_EFFECTS specially.
 642
 643 2019-06-19  Tom Tromey  <tromey@adacore.com>
 644
 645         * source-cache.c (highlighter): New global.
 646         (source_cache::get_source_lines): Create a highlighter on demand.
 647
 648 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 649
 650         * defs.h (deprecated_interactive_hook): Delete declaration.
 651         * interps.c (clear_interpreter_hooks): Remove use of
 652         deprecated_interactive_hook.
 653         * top.c (deprecated_interactive_hook): Delete definition.
 654         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 655
 656 2019-06-18  Tom de Vries  <tdevries@suse.de>
 657
 658         PR gdb/24515
 659         * dwarf2read.h (abstract_to_concrete): Change type from
 660         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 661         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 662         * dwarf2read.c (read_variable): Update.
 663         (dwarf2_fetch_die_loc_sect_off): Update.
 664
 665 2019-06-17  Tom de Vries  <tdevries@suse.de>
 666
 667         PR gdb/24617
 668         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 669         accessing parent[parent_len - 1].
 670
 671 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 672
 673         PR gdb/24364
 674         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 675         call dtrace_process_dof with NULL dof.
 676
 677 2019-06-16  Tom de Vries  <tdevries@suse.de>
 678
 679         PR gdb/24445
 680         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 681
 682 2019-06-16  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 685         (make_all_visible): Use address of member.
 686
 687 2019-06-16  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 690         (tui_free_window, free_content, free_content_elements): Remove
 691         unnecessary cast.
 692         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 693         cast.
 694         * tui/tui-regs.c (tui_show_register_group)
 695         (tui_display_registers_from, tui_display_reg_element_at_line):
 696         Remove unnecessary cast.
 697
 698 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 699
 700         * linux-nat.c (normal_mask): Delete.
 701         (_initialize_linux_nat): Don't initialise normal_mask.
 702
 703 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 704
 705         PR gdb/24445
 706         * dwarf-index-write.h (write_psymtabs_to_index): Add
 707         dwz_basename parameter.
 708         * dwarf-index-write.c (write_gdbindex): Move file writing to
 709         write_gdbindex_1.  Change return type void.
 710         (assert_file_size): Move up, remove filename parameter.
 711         (write_gdbindex_1): New function.
 712         (write_debug_names): Change return type to void, call
 713         assert_file_size.
 714         (struct index_wip_file): New struct.
 715         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 716         file logic to index_wip_file.  Write index for dwz file if
 717         needed.
 718         (save_gdb_index_command): Pass basename of dwz file, if present.
 719         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 720         build-id of dwz file, if present.
 721         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 722         (dwarf2_get_dwz_file): Likewise.
 723         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 724         (dwarf2_get_dwz_file): Likewise.
 725
 726 2019-06-16  Tom Tromey  <tom@tromey.com>
 727
 728         * coffread.c (process_coff_symbol): Use xstrdup.
 729         * value.c (create_internalvar): Use xstrdup.
 730
 731 2019-06-16  Tom Tromey  <tom@tromey.com>
 732
 733         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 734         * breakpoint.c (stopin_command, stopat_command)
 735         (until_break_command, decode_location_default): Remove unnecessary
 736         cast.
 737         * utils.c (subset_compare): Remove unnecessary cast.
 738         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 739         cast.
 740         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 741         cast.
 742         * infcmd.c (path_command): Remove unnecessary cast.
 743         * coffread.c (decode_type): Remove unnecessary cast.
 744         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 745         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 746         * tui/tui-stack.c (tui_show_locator_content)
 747         (tui_show_frame_info): Remove unnecessary cast.
 748         * tui/tui-win.c (tui_scroll_forward_command)
 749         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 750         (parse_scrolling_args): Remove unnecessary cast.
 751         * tui/tui-data.c (init_win_info, tui_del_window)
 752         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 753         (free_content_elements): Remove unnecessary cast.
 754         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 755         unnecessary cast.
 756         * tui/tui-source.c (tui_set_source_content)
 757         (tui_vertical_source_scroll): Remove unnecessary cast.
 758         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 759         cast.
 760         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 761         * tui/tui-regs.c (tui_display_registers_from)
 762         (tui_display_register): Remove unnecessary cast.
 763         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 764         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 765         (make_visible): Remove unnecessary cast.
 766         * tui/tui-winsource.c (tui_erase_source_content)
 767         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 768         unnecessary cast.
 769         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 770         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 771         * stabsread.c (read_type, read_array_type, read_range_type):
 772         Remove unnecessary cast.
 773         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 774         (parse_symbol, parse_type, upgrade_type, parse_external)
 775         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 776         unnecessary cast.
 777         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 778
 779 2019-06-16  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-data.c (tui_alloc_generic_win_info)
 782         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 783         checks.
 784
 785 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 786             Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * f-typeprint.c (f_print_type): Don't return early for not
 789         associated or not allocated types.
 790         (f_type_print_varspec_suffix): Add print_rank parameter and print
 791         ranks of array types in case they dangling.
 792         (f_type_print_base): Add print_rank parameter.
 793
 794 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * NEWS: Mention new MI commands.
 797         * break-catch-throw.c (enum exception_event_kind): Move to
 798         breakpoint.h.
 799         (print_mention_exception_catchpoint): Output text as a single
 800         message.
 801         (catch_exception_command_1): Rename to...
 802         (catch_exception_event): ...this, make non-static, update header
 803         command, and change some parameter types.
 804         (catch_catch_command): Update for changes to
 805         catch_exception_command_1.
 806         (catch_throw_command): Likewise.
 807         (catch_rethrow_command): Likewise.
 808         * breakpoint.c (enum exception_event_kind): Delete.
 809         * breakpoint.h (enum exception_event_kind): Moved here from
 810         break-catch-throw.c.
 811         (catch_exception_event): Declare.
 812         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 813         (mi_cmd_catch_throw): New function.
 814         (mi_cmd_catch_rethrow): New function.
 815         (mi_cmd_catch_catch): New function.
 816         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 817         'catch-catch' entries.
 818         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 819         (mi_cmd_catch_rethrow): Declare.
 820         (mi_cmd_catch_catch): Declare.
 821
 822 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * annotate.c (annotate_source_line): Change return type to void,
 825         update implementation to match.
 826         * annotate.h (annotate_source_line): Change return type to void,
 827         update header comment.
 828         * stack.c (print_frame_info): Don't change what frame information
 829         is printed based on whether annotations are on or not.
 830
 831 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 834         (annotate_source): Make static.
 835         (annotate_source_line): Moved from source.c and renamed from
 836         identify_source_line.  Update the return type.
 837         * annotate.h (annotate_source): Delete declaration.
 838         (annotate_source_line): Declaration moved from source.h, and
 839         renamed from identify_source_line.  Return type updated.
 840         * source.c (identify_source_line): Moved to annotate.c and renamed
 841         to annotate_source_line.
 842         (info_line_command): Remove check of annotation_level.
 843         * source.h (identify_source_line): Move declaration to annotate.h
 844         and rename to annotate_source_line.
 845         * stack.c: Add 'annotate.h' include.
 846         (print_frame_info): Remove check of annotation_level before
 847         calling annotate_source_line.
 848
 849 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * source-cache.c (source_cache::get_plain_source_lines): Use
 852         open_source_file_with_line_charpos instead of just
 853         open_source_file, remove call to find_source_lines.
 854         (source_cache::get_source_lines): Likewise.
 855         * source.c (find_source_lines): Make static.
 856         (get_filename_and_charpos): Renamed into...
 857         (open_source_file_with_line_charpos): ..this along with changes to
 858         return a scoped_fd, and some other minor clean ups.
 859         (identify_source_line): Use open_source_file_with_line_charpos.
 860         (search_command_helper): Use open_source_file_with_line_charpos
 861         instead of just open_source_file, remove call to
 862         find_source_lines.
 863         * source.h (open_source_file_with_line_charpos): Declare new
 864         function.
 865         (find_source_lines): Delete declaration.
 866
 867 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * source.c (get_filename_and_charpos): Remove fullname
 870         parameter.
 871         (identify_source_line): Update call to get_filename_and_charpos.
 872
 873 2019-06-14  Tom Tromey  <tromey@adacore.com>
 874
 875         PR gdb/24502:
 876         * ui-style.h (skip_ansi_escape): Update comment.
 877         * ui-file.h (class no_terminal_escape_file): New class.
 878         * ui-file.c (no_terminal_escape_file::write)
 879         (no_terminal_escape_file::puts): New methods.
 880         * cli/cli-logging.c (handle_redirections): Use
 881         no_terminal_escape_file.
 882
 883 2019-06-14  Tom Tromey  <tromey@adacore.com>
 884
 885         * NEWS: Move convenience variable news above Python news.
 886
 887 2019-06-14  Tom Tromey  <tom@tromey.com>
 888
 889         * gnulib: Move directory to top-level.
 890         * configure.ac: Don't configure gnulib.
 891         * configure: Rebuild.
 892         * common/common-defs.h: Use new path to gnulib.
 893         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 894         (GNULIB_H): Remove.
 895         (INCGNU): Look in new gnulib location.
 896         (HFILES_NO_SRCDIR): Remove gnulib files.
 897         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 898         (generated_files): Remove GNULIB_H.
 899         ($(LIBGNU), all-lib): Remove targets.
 900         (distclean): Don't mention GNULIB_BUILDDIR.
 901         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 902
 903 2019-06-14  Tom Tromey  <tromey@adacore.com>
 904
 905         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 906         Warn if symbol file does not provide any symbols.
 907
 908 2019-06-14  Tom Tromey  <tromey@adacore.com>
 909
 910         * source.c (find_and_open_source): Respect basenames_may_differ.
 911
 912 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * annotate.c (annotate_breakpoints_invalid): Make use of
 915         scoped_restore_terminal_state.
 916         (annotate_frames_invalid): Likewise.
 917
 918 2019-06-14  Tom Tromey  <tromey@adacore.com>
 919
 920         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 921         allow assignment to an internalvar.
 922
 923 2019-06-14  Tom Tromey  <tromey@adacore.com>
 924
 925         * ada-lex.l: Allow "_" in attribute names.
 926
 927 2019-06-14  Tom Tromey  <tromey@adacore.com>
 928
 929         PR gdb/24653:
 930         * regcache.c (registers_changed): Don't call alloca.
 931         * top.c (execute_command): Don't call alloca.
 932
 933 2019-06-13  Pedro Alves  <palves@redhat.com>
 934
 935         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 936         'expression'.  When parsing an expression, error out if there's
 937         junk after "unlimited".
 938         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 939         (do_set_command): Adjust calls to is_unlimited_literal.
 940
 941 2019-06-13  Pedro Alves  <palves@redhat.com>
 942
 943         * compile/compile.c (make_compile_options_def_group): Add braces
 944         around array_view initializer.
 945         * thread.c (make_thread_apply_all_options_def_group)
 946         (make_thread_apply_all_options_def_group): Likewise.
 947
 948 2019-06-13  Pedro Alves  <palves@redhat.com>
 949
 950         * NEWS (New commands): Mention "maint test-options
 951         require-delimiter", "maint test-options unknown-is-error", "maint
 952         test-options unknown-is-operand" and "maint show
 953         test-options-completion-result".
 954         (New command options, command completion): New section.
 955         (Completion improvements): New section.
 956         Mention that you can abbreviate "unlimited".
 957
 958 2019-06-13  Pedro Alves  <palves@redhat.com>
 959
 960         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 961         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 962         * unittests/cli-utils-selftests.c (test_parse_flags)
 963         (test_parse_flags_qcs): Delete.
 964         (test_cli_utils): Don't call deleted functions.
 965
 966 2019-06-13  Pedro Alves  <palves@redhat.com>
 967
 968         * thread.c: Include "cli/cli-option.h".
 969         (tp_array_compar_ascending): Global.
 970         (tp_array_compar): Delete function.
 971         (tp_array_compar_ascending, tp_array_compar_descending): New
 972         functions.
 973         (ascending_option_def, qcs_flag_option_def)
 974         (thr_qcs_flags_option_defs)
 975         (make_thread_apply_all_options_def_group)
 976         (make_thread_apply_options_def_group): New.
 977         (thread_apply_all_command): Use gdb::option::process_options.
 978         (thread_apply_command_completer)
 979         (thread_apply_all_command_completer): New.
 980         (thread_apply_command): Use gdb::option::process_options.
 981         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 982         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 983         to generate help text of "thread apply".  Adjust "taas"'s help.
 984         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 985         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 986
 987 2019-06-13  Pedro Alves  <palves@redhat.com>
 988
 989         * thread.c (thread_apply_command): Check for invalid TID with
 990         isdigit instead of !isalpha.
 991
 992 2019-06-13  Pedro Alves  <palves@redhat.com>
 993
 994         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 995         (validate_flags_qcs): New.
 996         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 997         (validate_flags_qcs): Declare.
 998         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 999         (make_frame_apply_options_def_group): New.
1000         (frame_apply_command_count): Process options with
1001         gdb::option::process_options.
1002         (frame_apply_completer): New.
1003         (frame_apply_level_completer, frame_apply_all_completer)
1004         (frame_apply_completer): New.
1005         (_initialize_stack): Update help of "frame apply", "frame apply
1006         level", "frame apply all" and "faas" to mention supported options
1007         and install command completers.
1008         * stack.h (frame_apply_all_completer): Declare.
1009         * thread.c: Include "stack.h".
1010         (tfaas_command): Add "--".
1011         (_initialize_thread): Update help "tfaas" to mention supported
1012         options and install command completer.
1013
1014 2019-06-13  Pedro Alves  <palves@redhat.com>
1015
1016         * completer.c (complete_nested_command_line): New.
1017         (gdb_completion_word_break_characters_throw): Add assertion.
1018         * completer.h (complete_nested_command_line): Declare.
1019
1020 2019-06-13  Pedro Alves  <palves@redhat.com>
1021
1022         * stack.c (parse_backtrace_qualifiers): New.
1023         (backtrace_command): Use it.
1024         (backtrace_command_completer): Complete on qualifiers.
1025
1026 2019-06-13  Pedro Alves  <palves@redhat.com>
1027
1028         * frame.c: Include "cli/cli-option.h.
1029         (user_set_backtrace_options): New.
1030         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1031         Delete.
1032         (get_prev_frame): Adjust.
1033         (boolean_option_def, uinteger_option_def)
1034         (set_backtrace_option_defs): New.
1035         (_initialize_frame): Adjust and use
1036         gdb::option::add_setshow_cmds_for_options to install "set
1037         backtrace past-main" and "set backtrace past-entry".
1038         * frame.h: Include "cli/cli-option.h".
1039         (struct frame_print_options): Forward declare.
1040         (print_frame_arguments_all, print_frame_arguments_scalars)
1041         (print_frame_arguments_none): Declare.
1042         (print_entry_values): Delete declaration.
1043         (struct frame_print_options, user_frame_print_options): New.
1044         (struct set_backtrace_options): New.
1045         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1046         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1047         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1048         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1049         (list_args_or_locals): Add frame_print_options parameter.
1050         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1051         * python/py-framefilter.c (enumerate_args): Pass down
1052         USER_FRAME_PRINT_OPTIONS.
1053         * stack.c: Include "cli/cli-option.h".
1054         (print_frame_arguments_all, print_frame_arguments_scalars)
1055         (print_frame_arguments_none): Declare.
1056         (print_raw_frame_arguments, print_entry_values): Delete.
1057         (user_frame_print_options): New.
1058         (boolean_option_def, enum_option_def, frame_print_option_defs):
1059         New.
1060         (struct backtrace_cmd_options): New.
1061         (bt_flag_option_def): New.
1062         (backtrace_command_option_defs): New.
1063         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1064         (print_frame_arg, read_frame_arg, print_frame_args)
1065         (print_frame_info, print_frame): Add frame_print_options parameter
1066         and use it.
1067         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1068         (backtrace_command_1): Add frame_print_options and
1069         backtrace_cmd_options parameters and use them.
1070         (make_backtrace_options_def_group): New.
1071         (backtrace_command): Process command options with
1072         gdb::option::process_options.
1073         (backtrace_command_completer): New.
1074         (_initialize_stack): Extend "backtrace"'s help to mention
1075         supported options.  Install completer for "backtrace".
1076         Install some settings commands with add_setshow_cmds_for_options.
1077
1078 2019-06-13  Pedro Alves  <palves@redhat.com>
1079
1080         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1081         and that "set/show print raw frame-arguments" are now deprecated.
1082
1083         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1084         command.
1085         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1086         * stack.c (_initialize_stack): Install "set/show print
1087         raw-frame-arguments", and deprecate "set/show print raw
1088         frame-arguments".
1089         * valprint.c (_initialize_valprint): Deprecate "set/show print
1090         raw".
1091
1092 2019-06-13  Pedro Alves  <palves@redhat.com>
1093
1094         * compile/compile.c (struct compile_options): New.
1095         (compile_flag_option_def, compile_command_option_defs)
1096         (make_compile_options_def_group): New.
1097         (compile_file_command): Handle options with
1098         gdb::option::process_options.
1099         (compile_file_command_completer): New function.
1100         (compile_code_command): Handle options with
1101         gdb::option::process_options.
1102         (compile_code_command_completer): New function.
1103         (_initialize_compiler): Install completers for "compile code" and
1104         "compile file".  Mention available options in "compile code" and
1105         "compile code"'s help.
1106         * completer.c (advance_to_completion_word): New, factored out from
1107         ...
1108         (advance_to_expression_complete_word_point): ... this.
1109         (advance_to_filename_complete_word_point): New.
1110         * completer.h (advance_to_filename_complete_word_point): New
1111         declaration.
1112
1113 2019-06-13  Pedro Alves  <palves@redhat.com>
1114
1115         * compile/compile.c: Include "cli/cli-option.h".
1116         (compile_print_value): Scope data pointer is now a
1117         value_print_options pointer; adjust.
1118         (compile_print_command): Process options.  Scope data pointer is
1119         now a value_print_options pointer; adjust.
1120         (_initialize_compile): Update "compile print"'s help to include
1121         supported options.  Install a completer for "compile print".
1122         * cp-valprint.c (show_vtblprint, show_objectprint)
1123         (show_static_field_print): Delete.
1124         (_initialize_cp_valprint): Don't install "set print
1125         static-members", "set print vtbl", "set print object" here.
1126         * printcmd.c: Include "cli/cli-option.h" and
1127         "common/gdb_optional.h".
1128         (print_command_parse_format): Rework to fill in a
1129         value_print_options instead of a format_data.
1130         (print_value): Change parameter type from format_data pointer to
1131         value_print_options reference.  Adjust.
1132         (print_command_1): Process options.  Adjust to pass down a
1133         value_print_options.
1134         (print_command_completer): New.
1135         (_initialize_printcmd): Install print_command_completer as
1136         handle_brkchars completer for the "print" command.  Update
1137         "print"'s help to include supported options.
1138         * valprint.c: Include "cli/cli-option.h".
1139         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1140         here from cp-valprint.c.
1141         (boolean_option_def, uinteger_option_def)
1142         (value_print_option_defs, make_value_print_options_def_group):
1143         New.  Use gdb::option::add_setshow_cmds_for_options to install
1144         "set print elements", "set print null-stop", "set print repeats",
1145         "set print pretty", "set print union", "set print array", "set
1146         print address", "set print symbol", "set print array-indexes".
1147         * valprint.h: Include <string> and "cli/cli-option.h".
1148         (make_value_print_options_def_group): Declare.
1149         (print_value): Change parameter type from format_data pointer to
1150         value_print_options reference.
1151         (print_command_completer): Declare.
1152
1153 2019-06-13  Pedro Alves  <palves@redhat.com>
1154
1155         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1156         (COMMON_SFILES): Add maint-test-settings.c.
1157         * cli/cli-decode.c (boolean_enums): New global, factored out from
1158         ...
1159         (add_setshow_boolean_cmd): ... here.
1160         * cli/cli-decode.h (boolean_enums): Declare.
1161         * cli/cli-option.c: New file.
1162         * cli/cli-option.h: New file.
1163         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1164         factored out from ...
1165         (parse_cli_boolean_value(const char *)): ... this.
1166         (is_unlimited_literal): Change parameter type to pointer to
1167         pointer.  Adjust and advance ARG pointer.
1168         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1169         (parse_cli_var_enum): New, factored out from ...
1170         (do_set_command): ... this.  Adjust.
1171         * cli/cli-setshow.h (parse_cli_boolean_value)
1172         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1173         (parse_cli_var_enum): Declare.
1174         * cli/cli-utils.c: Include "cli/cli-option.h".
1175         (get_ulongest): New.
1176         * cli/cli-utils.h (get_ulongest): Declare.
1177         (check_for_argument): New overloads.
1178         * maint-test-options.c: New file.
1179
1180 2019-06-13  Pedro Alves  <palves@redhat.com>
1181
1182         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1183         parse a range if "-" is at the end of the string.
1184
1185 2019-06-13  Pedro Alves  <palves@redhat.com>
1186
1187         * cli/cli-setshow.c (parse_auto_binary_operation)
1188         (parse_cli_boolean_value): Don't allow "o".
1189
1190 2019-06-13  Pedro Alves  <palves@redhat.com>
1191
1192         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1193         * NEWS: Mention maint test-settings KIND.
1194         * maint-test-settings.c: New file.
1195
1196 2019-06-13  Pedro Alves  <palves@redhat.com>
1197
1198         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1199         completer.
1200         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1201         "set" completers.
1202
1203 2019-06-13  Pedro Alves  <palves@redhat.com>
1204
1205         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1206         after item.
1207
1208 2019-06-13  Pedro Alves  <palves@redhat.com>
1209
1210         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1211
1212 2019-06-13  Pedro Alves <palves@redhat.com>
1213
1214         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1215         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1216         call.
1217         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1218         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1219         calls.
1220         (check_for_argument): Skip spaces after argument.
1221
1222 2019-06-13  Pedro Alves  <palves@redhat.com>
1223
1224         * thread.c (thread_apply_command): Adjust TID parsing.
1225         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1226         detected before end of string.
1227         (tid_is_in_list): Error out if LIST is invalid.
1228
1229 2019-06-13  Pedro Alves  <palves@redhat.com>
1230
1231         * completer.c (complete_line_internal_1): Rewind completion word
1232         point.
1233         (completion_tracker::advance_custom_word_point_by): Change
1234         parameter type to int.
1235         * completer.h (completion_tracker::advance_custom_word_point_by):
1236         Likewise.
1237
1238 2019-06-13  Pedro Alves  <palves@redhat.com>
1239
1240         * completer.c (advance_to_completion_word): Handle delimiters.
1241
1242 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1243
1244         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1245
1246 2019-06-11  Tom Tromey  <tom@tromey.com>
1247
1248         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1249         (xmalloc_failed): Move to alloc.c.
1250         * alloc.c: New file.
1251         * Makefile.in (COMMON_SFILES): Add alloc.c.
1252
1253 2019-06-11  Tom Tromey  <tom@tromey.com>
1254
1255         * nat/linux-waitpid.c: Don't include server.h.
1256         (linux_debug): Remove.
1257         (my_waitpid): Update.
1258
1259 2019-06-11  Tom Tromey  <tromey@adacore.com>
1260
1261         * infcall.c (_initialize_infcall): Remove trailing newline from
1262         help.
1263         * user-regs.c (_initialize_user_regs): Remove trailing newline
1264         from help.
1265         * typeprint.c (_initialize_typeprint): Remove trailing newline
1266         from help.
1267         * reverse.c (_initialize_reverse): Remove trailing newlines from
1268         help.
1269         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1270         from help.
1271         * language.c (add_set_language_command): Remove trailing newline
1272         from help.
1273         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1274         help.
1275         * disasm.c (_initialize_disasm): Remove trailing newline from
1276         help.
1277         * top.c (init_main): Remove trailing newline from help.
1278         * interps.c (_initialize_interpreter): Remove trailing newline
1279         from help.
1280         * btrace.c (_initialize_btrace): Remove trailing newlines from
1281         help.
1282         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1283         from help.
1284         * python/python.c (_initialize_python): Remove trailing newline
1285         from help.
1286         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1287         help.
1288         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1289         from help.  Reformat some text.
1290         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1291         from help.
1292         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1293         newline from help.
1294
1295 2019-06-11  Tom Tromey  <tromey@adacore.com>
1296
1297         * darwin-nat.c (darwin_decode_exception_message)
1298         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1299
1300 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * valops.c (value_slice): Check for not allocated or not
1303         associated values.
1304
1305 2019-06-10  Tom de Vries  <tdevries@suse.de>
1306
1307         PR gdb/24618
1308         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1309         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1310         invalid.
1311
1312 2019-06-10  Tom de Vries  <tdevries@suse.de>
1313
1314         PR gdb/24611
1315         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1316         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1317
1318 2019-06-10  Tom de Vries  <tdevries@suse.de>
1319
1320         PR symtab/24545
1321         * symtab.c (struct demangled_name_entry): Add language field.
1322         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1323         static minimal symbol".  Set and use language field.
1324
1325 2019-06-10  Tom Tromey  <tromey@adacore.com>
1326
1327         * ada-lang.c (_initialize_ada_language): Update help text.
1328
1329 2019-06-10  Tom Tromey  <tromey@adacore.com>
1330
1331         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1332         with a newline.
1333         * guile/guile.c (handle_boot_error): Don't end warning with a
1334         newline.
1335         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1336         warning with a newline.
1337         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1338         newline.
1339         (s12z_frame_cache): Likewise.
1340         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1341         a newline.
1342         * solib-svr4.c (disable_probes_interface): Don't end warning with
1343         a newline.
1344         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1345         newline.
1346         * python/python.c (do_finish_initialization): Don't end warning
1347         with a newline.
1348
1349 2019-06-10  Tom Tromey  <tom@tromey.com>
1350
1351         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1352         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1353         gdbpy_enter.
1354
1355 2019-06-10  Tom Tromey  <tromey@adacore.com>
1356
1357         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1358         data.
1359         (elf_new_init): Don't call stabsread_new_init.
1360         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1361         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1362         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1363
1364 2019-06-10  Tom de Vries  <tdevries@suse.de>
1365
1366         PR symtab/16264
1367         PR symtab/24517
1368         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1369
1370 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1371
1372         * source.c (find_and_open_source): Also rewrite relative file
1373         names.
1374
1375 2019-04-26  Amos Bird  <amosbird@gmail.com>
1376
1377         * annotate.c (annotate_thread_exited): Add "thread-exited"
1378         annotation.
1379
1380 2019-06-06  Tom Tromey  <tromey@adacore.com>
1381
1382         * maint.h (class scoped_command_stats): Use
1383         DISABLE_COPY_AND_ASSIGN.
1384         <print_time>: New method.
1385         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1386         print_time.
1387         (scoped_command_stats::print_time): New method.
1388
1389 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1390
1391         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1392         instructions of lengths 6 or 8 bytes.
1393
1394 2019-06-04  Pedro Alves  <palves@redhat.com>
1395
1396         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1397
1398         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1399         * breakpoint.c (condition_completer): Likewise.
1400         * cli/cli-dump.c (scan_expression): Likewise.
1401         * common/filestuff.c (mkdir_recursive): Likewise.
1402         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1403         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1404         (gdb_abspath): Likewise.
1405         * compile/compile-cplus-types.c
1406         (compile_cplus_instance::decl_name): Likewise.
1407         * completer.c (complete_explicit_location):
1408         (signal_completer, reg_or_group_completer_1): Likewise.
1409         * cp-support.c (cp_remove_params_if_any): Likewise.
1410         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1411         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1412         * infcmd.c (strip_bg_char): Likewise.
1413         * linespec.c (copy_token_string): Likewise.
1414         * mi/mi-main.c (output_cores): Likewise.
1415         * psymtab.c (psymtab_search_name):
1416         * symfile.c (test_set_ext_lang_command): Likewise.
1417         * target.c (target_fileio_read_stralloc): Likewise.
1418         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1419         * value.c (complete_internalvar): Likewise.
1420
1421 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1422
1423         Add objfile property to gdb.Type.
1424         * NEWS: Mention Python API addition.
1425         * python/py-type.c (typy_get_objfile): New method.
1426
1427 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1428
1429         * NEWS: Mention the new set|show style [title|highlight].
1430         Mention changes to "show style", "help" and "apropos".
1431
1432 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1433
1434         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1435         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1436         instead of print_help_for_command.
1437         (print_doc_of_command): New function.
1438         (help_list): Add 'apropos -v word' suggestion.
1439         (print_help_for_command): Style the command name using title style.
1440         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1441         (_initialize_cli_cmds): Describe -v in apropos_command help.
1442
1443 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1444
1445         * cli/cli-style.h (cli_style_option): Add name in constructor,
1446         add m_name class member, add constructor with intensity,
1447         add name class function.
1448         (cli_style_option::add_setshow_commands): Remove name argument.
1449         (highlight_style, title_style): New styles.
1450         * cli/cli-style.c (do_show): New function that shows a style
1451         characteristic styling the style name with itself.
1452         (set_style_name): New function.
1453         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1454         Update all callers according to the changes in cli/cli-style.h.
1455         * utils.h (fputs_highlighted): New function.
1456         * utils.c (fputs_highlighted): Likewise.
1457
1458 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1459
1460         * NEWS: Mention new pipe command and new convenience variables.
1461
1462 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1463
1464         * cli/cli-cmds.c (pipe_command): New function.
1465         (_initialize_cli_cmds): Call add_com for pipe_command.
1466         Define | as an alias for pipe.
1467         (exit_status_set_internal_vars): New function.
1468         (shell_escape): Call exit_status_set_internal_vars.
1469         cli/cli-decode.c (find_command_name_length): Recognize | as
1470         a single character command.
1471
1472 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1473
1474         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1475         top.c (execute_command_to_ui_file): New function, mostly a copy
1476         of execute_command_to_string.
1477         (execute_command_to_string): Implement by calling
1478         execute_command_to_ui_file.
1479
1480 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1481
1482         * top.h (saved_command_line): Remove declaration.
1483         * top.c (previous_saved_command_line, previous_repeat_arguments):
1484         New variables.
1485         (saved_command_line): Make static, define together with other
1486         'repeat variables'.
1487         (dont_repeat): Clear repeat_arguments.
1488         (repeat_previous, get_saved_command_line, save_command_line):
1489         New functions.
1490         (gdb_init): Initialize saved_command_line
1491         and previous_saved_command_line.
1492         * main.c (captured_main_1): Remove saved_command_line initialization.
1493         * event-top.c (handle_line_of_input): Update to use
1494         the new 'repeat' related functions instead of direct access to
1495         saved_command_line.
1496         * command.h (repeat_previous, get_saved_command_line,
1497         save_command_line): New declarations.
1498         (dont_repeat): Add comment.
1499
1500 2019-05-30  Tom Tromey  <tromey@adacore.com>
1501
1502         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1503         Fix comment.
1504         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1505
1506 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1507
1508         PR cli/24587
1509         * completer.c (complete): Initialize variable word.
1510
1511 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1512
1513         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1514         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1515         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1516         'body' is NULL to the outter 'if', protecting the '!is_define'
1517         situation as well.
1518
1519 2019-05-29  Tom Tromey  <tromey@adacore.com>
1520
1521         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1522         (dwarf_unknown): New function.
1523         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1524         (dwarf_type_encoding_name): Use dwarf_unknown.
1525
1526 2019-05-29  Tom Tromey  <tromey@adacore.com>
1527
1528         PR c++/20020:
1529         * cp-valprint.c (cp_print_value_fields): Call
1530         cp_print_static_field inside "try".
1531
1532 2019-05-29  Tom Tromey  <tromey@adacore.com>
1533
1534         * inflow.c (struct terminal_info): Add default operator=.
1535         * configure: Rebuild.
1536         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1537         -Wdeprecated-copy-dtor, -Wredundant-move.
1538
1539 2019-05-29  Tom Tromey  <tromey@adacore.com>
1540
1541         * NEWS: Add entry.
1542         * infcmd.c (print_return_value_1): Handle finish_print
1543         option.
1544         (show_print_finish): New function.
1545         (_initialize_infcmd): Add "set/show print finish" commands.
1546         * valprint.c (user_print_options): Initialize new member.
1547         * valprint.h (struct value_print_options) <finish_print>: New
1548         member.
1549
1550 2019-05-28  Tom Tromey  <tromey@adacore.com>
1551
1552         * ada-lang.c (ada_remove_Xbn_suffix)
1553         (find_old_style_renaming_symbol)
1554         (parse_old_style_renaming): Remove.
1555         (ada_find_renaming_symbol): Don't call
1556         find_old_style_renaming_symbol.
1557         (ada_is_renaming_symbol): Rename from
1558         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1559         bool.  Now static.
1560         (ada_read_var_value): Update and simplify.
1561         * ada-exp.y (write_var_or_type): Remove old code.
1562
1563 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1564
1565         * event-top.c: Remove include comment.
1566         * inflow.c (class scoped_ignore_sigttou): Move from here...
1567         * inflow.h (class scoped_ignore_sigttou): ...to here.
1568         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1569         * top.c:  Remove include comment.
1570
1571 2019-05-27  Tom Tromey  <tom@tromey.com>
1572
1573         * NEWS: Fix typo.
1574
1575 2019-05-22  Tom Tromey  <tromey@adacore.com>
1576
1577         * target.c (target_follow_exec): Constify parameter.
1578         * target-delegates.c: Rebuild.
1579         * remote.c (remote_target::follow_exec): Constify parameter.
1580         * infrun.c (follow_exec): Constify parameter.
1581         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1582         (target_follow_exec): Likewise.
1583
1584 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1585
1586         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1587         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1588
1589 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1590
1591         * NEWS: Add debugredirect and testsuite sections.
1592
1593 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1594
1595         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1596         target descriptions using exclusively floating point register name
1597         aliases.
1598
1599 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         PR gdb/18644:
1602         * f-lang.c (build_fortran_types): Handle the case where
1603         gdbarch_floatformat_for_type returns a nullptr.
1604
1605 2019-05-21  Tom de Vries  <tdevries@suse.de>
1606
1607         PR cli/24587
1608         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1609
1610 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1611
1612         PR gdb/18644:
1613         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1614         16-byte floats.
1615         * i386-tdep.c (i386_floatformat_for_type): Use
1616         floatformats_ia64_quad for the 16-byte floating point component
1617         within a fortran 32-byte complex number.
1618
1619 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1620
1621         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1622         delete default constructor.
1623         (find_partial_die): Update to return const struct.
1624         (partial_die_parent_scope): Move variable declaration into scope
1625         of its use and change its type to auto.
1626         (guess_partial_die_structure_name): Likewise.
1627         (partial_die_info::fixup): Likewise.
1628
1629 2019-05-17  Tom Tromey  <tromey@adacore.com>
1630
1631         * source.c (find_and_open_source): Remove cast.
1632
1633 2019-05-17  Tom Tromey  <tromey@adacore.com>
1634
1635         * annotate.c (annotate_source): Make "filename" const.
1636         * annotate.h (annotate_source): Use const.
1637
1638 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1639
1640         * disasm.c (set_disassembler_options): Send errors to stderr.
1641
1642 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1643
1644         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1645         (cli_interp_base::set_logging): Check debug_redirect.
1646         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1647         * cli/cli-logging.c (debug_redirect): Add static variable.
1648         (pop_output_files): Add default param.
1649         (handle_redirections): Print debug setting.
1650         (show_logging_command): Likewise.
1651         (_initialize_cli_logging): Add debugredirect command.
1652         * interps.c (current_interp_set_logging): Add debug_redirect
1653         parameter.
1654         * interps.h (set_logging): Add debug_redirect parameter.
1655         (current_interp_set_logging): Likewise.
1656         * mi/mi-common.h: Likewise.
1657         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1658
1659 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1660             Tom Tromey  <tromey@adacore.com>
1661
1662         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1663         directly.
1664         * cli/cli-interp.h (make_logging_output): Remove declaration.
1665         * cli/cli-logging.c (make_logging_output): Remove function.
1666         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1667         directly.
1668         * ui-file.c (tee_file::tee_file): Remove bools.
1669         (tee_file::~tee_file): Remove deletes.
1670         * ui-file.h (tee_file): Remove bools.
1671
1672 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1673
1674         * mi/mi-cmds.h (mi_cmd_complete): New function.
1675         * mi/mi-main.c (mi_cmd_complete): Likewise.
1676         * mi/mi-cmds.c: Define new MI command -complete.
1677         * NEWS: Mention new -complete command.
1678
1679 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1680
1681         * completer.h (complete): New function.
1682         * completer.c (complete): Likewise.
1683         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1684         function defined in completer.h.
1685
1686 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1687
1688         * MAINTAINERS (Write After Approval): Add myself.
1689
1690 2019-05-17  Tom de Vries  <tdevries@suse.de>
1691
1692         PR gdb/24094
1693         * dwarf2read.c (struct cu_partial_die_info): New struct.
1694         (find_partial_die): Return cu_partial_die_info.
1695         (partial_die_parent_scope, guess_partial_die_structure_name)
1696         (partial_die_info::fixup): Handle new return type of find_partial_die.
1697
1698 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1699
1700         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1701         "std::string", simplifying the algorithm.
1702
1703 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1704
1705         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1706         (stap_static_probe_ops::get_probes): Likewise.
1707
1708 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1709
1710         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1711         '-')" and "else if".
1712         (stap_parse_single_operand): Join checks for
1713         "gdbarch_stap_parse_special_token_p" and
1714         "gdbarch_stap_parse_special_token" in the same "if" statement.
1715         Invert check when verifying for operation on register
1716         displacement.
1717
1718 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1719
1720         * stap-probe.c (stap_get_opcode): Update comment.
1721         (stap_get_expected_argument_type): Likewise.
1722         (handle_stap_probe): Likewise.
1723
1724 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1725
1726         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1727         return type to 'bool'.  Adjust comment.  Use 'bool' when
1728         appropriate.
1729         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1730         * stap-probe.c (stap_parse_argument_1): Likewise.
1731         (stap_is_operator): Likewise.
1732         (stap_is_generic_prefix): Likewise.
1733         (stap_is_register_prefix): Likewise.
1734         (stap_is_register_indirection_prefix): Likewise.
1735         (stap_is_integer_prefix): Likewise.
1736         (stap_generic_check_suffix): Likewise.
1737         (stap_check_integer_suffix): Likewise.
1738         (stap_check_register_suffix): Likewise.
1739         (stap_check_register_indirection_suffix): Likewise.
1740         (stap_parse_register_operand): Likewise.
1741         (stap_parse_single_operand): Likewise.
1742         (stap_parse_argument_1): Likewise.
1743         (stap_probe::get_argument_count): Likewise.
1744         (stap_is_operator): Likewise.
1745
1746 2019-05-16  Tom Tromey  <tromey@adacore.com>
1747
1748         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1749         keyword to foreach.
1750
1751 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1752
1753         * linux-thread-db.c (try_thread_db_load_1): Change return type
1754         to bool.
1755         (try_thread_db_load): Likewise.
1756         (try_thread_db_load_from_pdir_1): Likewise.
1757         (try_thread_db_load_from_pdir): Likewise.
1758         (try_thread_db_load_from_sdir): Likewise.
1759         (try_thread_db_load_from_dir): Likewise.
1760         (thread_db_load_search): Likewise.
1761         (has_libpthread): Likewise.
1762         (thread_db_load): Likewise.
1763
1764 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1765
1766         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1767         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1768         NULL, and complain/return if that's the case.
1769
1770 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1771
1772         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1773         (advance, posn, abstract_read_memory): New functions.
1774         [struct mem_read_abstraction]: New struct.
1775         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1776
1777 2019-05-14  Tom Tromey  <tromey@adacore.com>
1778
1779         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1780         value is not lval_memory.
1781
1782 2019-05-14  Tom Tromey  <tromey@adacore.com>
1783
1784         * solib.c (info_sharedlibrary_command): Style the file name.
1785
1786 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1787
1788         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1789         (aarch64_vnv_type): Likewise.
1790         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1791         * common/tdesc.c: Likewise.
1792         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1793         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1794         * features/aarch64-fpu.xml: Add ieee half view.
1795         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1796         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1797         * gdbtypes.h (struct builtin_type): Likewise.
1798         (struct objfile_type): Likewise.
1799
1800 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1801
1802         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1803         typo.
1804         * location.h (string_to_event_location): Likewise.
1805
1806 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1807
1808         GDB 8.3 released.
1809
1810 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1811
1812         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1813         New variable declaration.
1814         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1815         New variable.
1816         (print_one_breakpoint): Use ui_out::test_flags and new global
1817         variable to compute use_fixed_output.
1818         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1819         Remove.
1820         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1821         (mi_multi_location_breakpoint_output_fixed): Remove.
1822         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1823         new variable.
1824         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1825         fix_multi_location_breakpoint_output flag if version >= 3.
1826         * ui-out.h (enum ui_out_flag)
1827         <fix_multi_location_breakpoint_output>: New enumerator.
1828
1829 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1830
1831         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1832
1833 2019-05-10  Tom Tromey  <tromey@adacore.com>
1834
1835         * ada-lang.c (catch_ada_completer): New function.
1836         (_initialize_ada_language): Use it.
1837
1838 2019-05-10  Tom Tromey  <tromey@adacore.com>
1839
1840         * thread.c (print_thread_info): Make "requested_threads" const.
1841         * gdbthread.h (print_thread_info): Make "requested_threads"
1842         const.
1843         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1844         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1845
1846 2019-05-08  Tom Tromey  <tom@tromey.com>
1847
1848         * gdbtypes.c (objfile_type_data): Change type.
1849         (objfile_type, _initialize_gdbtypes): Update.
1850
1851 2019-05-08  Tom Tromey  <tom@tromey.com>
1852
1853         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1854         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1855         (_initialize_dwarf2_frame): Update.
1856
1857 2019-05-08  Tom Tromey  <tom@tromey.com>
1858
1859         * objc-lang.c (objc_objfile_data): Change type.
1860         (find_methods): Update.
1861         (_initialize_objc_lang): Remove.
1862
1863 2019-05-08  Tom Tromey  <tom@tromey.com>
1864
1865         * stabsread.c (rs6000_builtin_type_data): Change type.
1866         (rs6000_builtin_type, _initialize_stabsread): Update.
1867
1868 2019-05-08  Tom Tromey  <tom@tromey.com>
1869
1870         * mips-tdep.c (mips_pdr_data): Remove.
1871         (_initialize_mips_tdep): Update.
1872
1873 2019-05-08  Tom Tromey  <tom@tromey.com>
1874
1875         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1876         (hppa_init_objfile_priv_data, read_unwind_info)
1877         (find_unwind_entry, _initialize_hppa_tdep): Update.
1878
1879 2019-05-08  Tom Tromey  <tom@tromey.com>
1880
1881         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1882         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1883         on obstack.
1884         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1885
1886 2019-05-08  Tom Tromey  <tom@tromey.com>
1887
1888         * mdebugread.c (basic_type_data): Change type.
1889         (basic_type, _initialize_mdebugread): Update.
1890
1891 2019-05-08  Tom Tromey  <tom@tromey.com>
1892
1893         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1894
1895 2019-05-08  Tom Tromey  <tom@tromey.com>
1896
1897         * nto-tdep.c (nto_inferior_data_reg): Change type.
1898         (nto_inferior_data): Update.
1899         (nto_inferior_data_cleanup, nto_new_inferior_data)
1900         (_initialize_nto_tdep): Remove.
1901         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1902
1903 2019-05-08  Tom Tromey  <tom@tromey.com>
1904
1905         * ada-lang.c (struct ada_inferior_data): Add initializers.
1906         (ada_inferior_data): Change type.
1907         (ada_inferior_data_cleanup): Remove.
1908         (get_ada_inferior_data, ada_inferior_exit)
1909         (struct ada_pspace_data): Add initializers, destructor.
1910         (ada_pspace_data_handle): Change type.
1911         (get_ada_pspace_data): Update.
1912         (ada_pspace_data_cleanup): Remove.
1913
1914 2019-05-08  Tom Tromey  <tom@tromey.com>
1915
1916         * coffread.c (struct coff_symfile_info): Add initializers.
1917         (coff_objfile_data_key): Move lower.  Change type.
1918         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1919         Update.
1920         (coff_free_info): Remove.
1921
1922 2019-05-08  Tom Tromey  <tom@tromey.com>
1923
1924         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1925         (fbsd_pspace_data_handle): Move lower.  Change type.
1926         (get_fbsd_pspace_data): Update.
1927         (fbsd_pspace_data_cleanup): Remove.
1928         (_initialize_fbsd_tdep): Update.
1929
1930 2019-05-08  Tom Tromey  <tom@tromey.com>
1931
1932         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1933         (get_ada_tasks_pspace_data): Update.
1934         (ada_tasks_pspace_data_cleanup): Remove.
1935         (_initialize_tasks): Update.
1936         (ada_tasks_inferior_data_handle): Change type.
1937         (get_ada_tasks_inferior_data): Update.
1938         (ada_tasks_inferior_data_cleanup): Remove.
1939         (struct ada_tasks_pspace_data): Add initializers.
1940
1941 2019-05-08  Tom Tromey  <tom@tromey.com>
1942
1943         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1944         * symfile-debug.c (debug_sym_get_probes): Change type.
1945         * stap-probe.c (handle_stap_probe):
1946         (stap_static_probe_ops::get_probes): Change type.
1947         * probe.h (class static_probe_ops) <get_probes>: Change type.
1948         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1949         (parse_probes_in_pspace): Update.
1950         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1951         Update.
1952         (any_static_probe_ops::get_probes): Change type.
1953         * elfread.c (elfread_data): New typedef.
1954         (probe_key): Change type.
1955         (elf_get_probes): Likewise.  Update.
1956         (probe_key_free): Remove.
1957         (_initialize_elfread): Update.
1958         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1959         Change type.
1960         (dtrace_process_dof_probe, dtrace_process_dof)
1961         (dtrace_static_probe_ops::get_probe): Change type.
1962
1963 2019-05-08  Tom Tromey  <tom@tromey.com>
1964
1965         * xcoffread.c (struct xcoff_symfile_info): Rename from
1966         coff_symfile_info.  Add initializers.
1967         (xcoff_objfile_data_key): Move lower.  Change type.
1968         (XCOFF_DATA): Rewrite.
1969         (xcoff_free_info): Remove.
1970         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1971         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1972         (xcoff_initial_scan): Update.
1973
1974 2019-05-08  Tom Tromey  <tom@tromey.com>
1975
1976         * solib-svr4.c (struct svr4_info): Add initializers and
1977         destructor.
1978         <probes_table>: Now an htab_up.
1979         (solib_svr4_pspace_data): Change type.
1980         (free_probes_table): Simplify.
1981         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1982         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1983         (probes_table_remove_objfile_probes, register_solib_event_probe)
1984         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1985         (_initialize_svr4_solib): Update.
1986
1987 2019-05-08  Tom Tromey  <tom@tromey.com>
1988
1989         * remote.c (remote_pspace_data): Change type.
1990         (remote_pspace_data_cleanup): Remove.
1991         (get_remote_exec_file, set_pspace_remote_exec_file)
1992         (_initialize_remote): Update.
1993
1994 2019-05-08  Tom Tromey  <tom@tromey.com>
1995
1996         * breakpoint.c (breakpoint_objfile_key): Change type.
1997         (get_breakpoint_objfile_data): Update.
1998         (free_breakpoint_objfile_data): Remove.
1999         (_initialize_breakpoint): Update.
2000
2001 2019-05-08  Tom Tromey  <tom@tromey.com>
2002
2003         * linux-tdep.c (struct linux_info): Add initializers.
2004         (linux_inferior_data): Move.  Change type.
2005         (invalidate_linux_cache_inf): Update.
2006         (linux_inferior_data_cleanup): Remove.
2007         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2008
2009 2019-05-08  Tom Tromey  <tom@tromey.com>
2010
2011         * auxv.c (auxv_inferior_data): Move.  Change type.
2012         (auxv_inferior_data_cleanup): Remove.
2013         (invalidate_auxv_cache_inf): Rewrite.
2014         (get_auxv_inferior_data, _initialize_auxv): Update.
2015
2016 2019-05-08  Tom Tromey  <tom@tromey.com>
2017
2018         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2019         (symfile_debug_objfile_data_key): Change type.
2020         (symfile_debug_installed, debug_qf_has_symbols)
2021         (debug_qf_find_last_source_symtab)
2022         (debug_qf_forget_cached_source_info)
2023         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2024         (debug_qf_print_stats, debug_qf_dump)
2025         (debug_qf_expand_symtabs_for_function)
2026         (debug_qf_expand_all_symtabs)
2027         (debug_qf_expand_symtabs_with_fullname)
2028         (debug_qf_map_matching_symbols)
2029         (debug_qf_expand_symtabs_matching)
2030         (debug_qf_find_pc_sect_compunit_symtab)
2031         (debug_qf_map_symbol_filenames)
2032         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2033         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2034         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2035         (debug_sym_read_linetable, debug_sym_relocate): Update.
2036         (symfile_debug_free_objfile): Remove.
2037         (install_symfile_debug_logging, _initialize_symfile_debug):
2038         Update.
2039
2040 2019-05-08  Tom Tromey  <tom@tromey.com>
2041
2042         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2043         allocate_on_obstack.
2044         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2045         (get_dwarf2_per_objfile): Update.
2046         (set_dwarf2_per_objfile): Remove.
2047         (dwarf2_has_info, dwarf2_get_section_info): Update.
2048         (dwarf2_free_objfile): Remove.
2049         (_initialize_dwarf2_read): Update.
2050
2051 2019-05-08  Tom Tromey  <tom@tromey.com>
2052
2053         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2054         initializers.
2055         <unsupported_script_warning_printed,
2056         script_not_found_warning_printed>: Now bool.
2057         (auto_load_pspace_data): Change type.
2058         (~auto_load_pspace_info): Rename from
2059         auto_load_pspace_data_cleanup.
2060         (get_auto_load_pspace_data, init_loaded_scripts_info)
2061         (clear_section_scripts, maybe_print_unsupported_script_warning)
2062         (maybe_print_script_not_found_warning, _initialize_auto_load):
2063         Update.
2064
2065 2019-05-08  Tom Tromey  <tom@tromey.com>
2066
2067         * objfiles.c (objfile_pspace_info): Add destructor and
2068         initializers.
2069         (objfiles_pspace_data): Change type.
2070         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2071         (get_objfile_pspace_data): Update.
2072         (objfiles_bfd_data): Change type.
2073         (get_objfile_bfd_data): Update.
2074         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2075
2076 2019-05-08  Tom Tromey  <tom@tromey.com>
2077
2078         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2079         Change type.
2080         (get_catch_syscall_inferior_data): Update.
2081         (catch_syscall_inferior_data_cleanup): Remove.
2082         (_initialize_break_catch_syscall): Update.
2083
2084 2019-05-08  Tom Tromey  <tom@tromey.com>
2085
2086         * inflow.c (struct terminal_info): Add destructor and
2087         initializers.
2088         (inflow_inferior_data): Change type.
2089         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2090         (get_inflow_inferior_data, inflow_inferior_exit)
2091         (swap_terminal_info, _initialize_inflow): Update.
2092
2093 2019-05-08  Tom Tromey  <tom@tromey.com>
2094
2095         * target-dcache.c (target_dcache_cleanup): Remove.
2096         (target_dcache_aspace_key): Change type.
2097         (target_dcache_init_p, target_dcache_invalidate)
2098         (target_dcache_get, target_dcache_get_or_init)
2099         (_initialize_target_dcache): Update.
2100         * dcache.h (struct dcache_deleter): New.
2101
2102 2019-05-08  Tom Tromey  <tom@tromey.com>
2103
2104         * symtab.c (struct symbol_cache): Add destructor and
2105         initializers.
2106         (symbol_cache_key): Move.  Change type.
2107         (make_symbol_cache, free_symbol_cache): Remove.
2108         (get_symbol_cache): Update.
2109         (symbol_cache_cleanup): Remove.
2110         (ALL_PSPACES, symbol_cache_flush)
2111         (maintenance_print_symbol_cache)
2112         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2113         Update.
2114
2115 2019-05-08  Tom Tromey  <tom@tromey.com>
2116
2117         * symtab.c (struct main_info): Add destructor and initializers.
2118         (main_progspace_key): Move.  Change type.
2119         (get_main_info): Update.
2120         (main_info_cleanup): Remove.
2121         (_initialize_symtab): Update.
2122
2123 2019-05-08  Tom Tromey  <tom@tromey.com>
2124
2125         * registry.h (DECLARE_REGISTRY): Define the _key class.
2126
2127 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2128
2129         * NEWS: Merge two 'New commands' sections.
2130
2131 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2132
2133         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2134         parameter and use Ada language definition instead.
2135         (ada_val_print_ptr): Remove unused language parameter.
2136         (ada_val_print_num): Remove language parameter and use Ada language
2137         definition instead.
2138         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2139         parameter.
2140         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2141         parameter and use Ada language definition instead.
2142         (ada_val_print_1): Update all ada_val_print_xxx calls.
2143         Remove language parameter.
2144         (ada_val_print): Update ada_val_print_1 call.
2145
2146 2019-05-08  Tom Tromey  <tromey@adacore.com>
2147
2148         * remote.c (remote_hw_watchpoint_limit)
2149         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2150         Now static.
2151
2152 2019-05-08  Tom Tromey  <tromey@adacore.com>
2153
2154         * maint.c (_initialize_maint_cmds): Move initialization code to
2155         remote.c.
2156         (watchdog, show_watchdog): Move to remote.c.
2157         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2158         "watchdog" static.
2159         (_initialize_remote): Move initialization code from maint.c.
2160         * defs.h (watchdog): Don't declare.
2161
2162 2019-05-08  Tom Tromey  <tromey@adacore.com>
2163
2164         * tui/tui-interp.c: Include main.h.
2165         * interps.c: Include main.h.
2166         * main.h (interpreter_p): Declare.
2167         * defs.h (interpreter_p): Don't declare.
2168
2169 2019-05-08  Tom Tromey  <tromey@adacore.com>
2170
2171         * dwarf2loc.c: Include dwarf2read.h.
2172         * defs.h (read_unsigned_leb128): Don't declare.
2173         * dwarf2read.h (read_unsigned_leb128): Declare.
2174
2175 2019-05-08  Tom Tromey  <tromey@adacore.com>
2176
2177         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2178         method.
2179
2180 2019-05-08  Tom Tromey  <tromey@adacore.com>
2181
2182         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2183         when no wrap column is set.
2184
2185 2019-05-08  Tom Tromey  <tromey@adacore.com>
2186
2187         * c-lang.c (c_get_string): Handle non-C-style arrays.
2188
2189 2019-05-08  Tom Tromey  <tromey@adacore.com>
2190
2191         * typeprint.c (print_offset_data::update): Print the bit offset,
2192         not the number of bits remaining.
2193
2194 2019-05-08  Tom Tromey  <tromey@adacore.com>
2195
2196         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2197         padding at end of comment.
2198
2199 2019-05-08  Tom Tromey  <tromey@adacore.com>
2200
2201         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2202         Compare main types.
2203
2204 2019-05-06  Tom Tromey  <tom@tromey.com>
2205
2206         * common/scoped_mmap.c: Include common-defs.h.
2207         * common/scoped_mmap.h: Don't include config.h.
2208
2209 2019-05-04  Tom Tromey  <tom@tromey.com>
2210
2211         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2212         (struct aarch64_call_info): Add initializers.
2213         <si>: Now a std::vector.
2214         (pass_on_stack, aarch64_push_dummy_call): Update.
2215
2216 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2217             Tom Tromey  <tom@tromey.com>
2218
2219         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2220         (ppc_threads): Now a std::vector.  Now static.
2221         (hwdebug_find_thread_points_by_tid)
2222         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2223         Update.
2224
2225 2019-05-04  Tom Tromey  <tom@tromey.com>
2226
2227         * arc-tdep.c (arc_tdesc_init): Return bool.
2228
2229 2019-05-04  Tom Tromey  <tom@tromey.com>
2230
2231         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2232         Use gdb_assert_not_reached.
2233
2234 2019-05-04  Tom Tromey  <tom@tromey.com>
2235
2236         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2237         "false".
2238
2239 2019-05-04  Tom Tromey  <tom@tromey.com>
2240
2241         * arc-tdep.c (arc_tdesc_init): Use bool.
2242
2243 2019-05-04  Tom Tromey  <tom@tromey.com>
2244
2245         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2246
2247 2019-05-04  Tom Tromey  <tom@tromey.com>
2248
2249         * cli/cli-cmds.c (valid_command_p): Return bool.
2250
2251 2019-05-04  Tom Tromey  <tom@tromey.com>
2252
2253         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2254         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2255
2256 2019-05-04  Raul Tambre  <raul@tambre.ee>
2257
2258         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2259         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2260         operator for comparison.
2261
2262 2019-05-04  Tom Tromey  <tom@tromey.com>
2263
2264         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2265         (lookup_partial_symbol, print_partial_symbols)
2266         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2267         (psymbol_compare): Update.
2268         (add_psymbol_to_bcache): Clear the entire psymbol.
2269         (maintenance_check_psymtabs): Update.
2270         * psympriv.h (struct partial_symbol): Don't derive from
2271         general_symbol_info.
2272         <obj_section, unrelocated_address, address,
2273         set_unrelocated_address>: Update.
2274         <ginfo>: New member.
2275         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2276         (debug_names::write_psymbols): Update.
2277
2278 2019-05-04  Tom de Vries  <tdevries@suse.de>
2279
2280         * contrib/cc-with-tweaks.sh: Support -n arg.
2281
2282 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2283
2284         * corelow.c (core_target::detach): Ensure frame cache and
2285         register caches are cleared.
2286         inferior.c (exit_inferior_1): Likewise.
2287
2288 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2289             Tom Tromey  <tom@tromey.com>
2290
2291         * dictionary.c (collate_pending_symbols_by_language): Remove
2292         "struct" from foreach.
2293         * symtab.c (lookup_global_symbol_from_objfile)
2294         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2295         foreach.
2296         * ser-tcp.c (net_open): Remove "struct" from foreach.
2297         * objfiles.c (objfile_relocate, objfile_rebase)
2298         (objfile_has_symbols): Remove "struct" from foreach.
2299         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2300         from foreach.
2301         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2302         foreach.
2303         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2304         "struct" from foreach.
2305         * ada-lang.c (create_excep_cond_exprs)
2306         (ada_exception_catchpoint_cond_string): Remove "struct" from
2307         foreach.
2308
2309 2019-05-03  Tom Tromey  <tromey@adacore.com>
2310
2311         * ada-exp.y (convert_char_literal): Check suffix of each
2312         enumerator.
2313
2314 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2315
2316         PR ada/21406:
2317         * ada-exp.y (yywrap): Don't define.
2318         * ada-lex.l (%option): Add noyywrap
2319         (yywrap): Remove.
2320
2321 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2322
2323         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2324         _WIN32_WINNT to the XP level, unless already defined to a higher
2325         level.
2326
2327         * unittests/parse-connection-spec-selftests.c:
2328         * ser-tcp.c:
2329         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2330         override.
2331
2332         * symfile.c (find_separate_debug_file): Remove colon from the
2333         drive spec of DOS/Windows file names of the target, so that the
2334         file name produced from DEBUGDIR and the target's directory will
2335         be valid on DOS/Windows systems.
2336
2337 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * rust-lang.c (val_print_struct): Handle printing structures
2340         containing strings.
2341
2342 2019-05-02  Tom Tromey  <tromey@adacore.com>
2343
2344         * valarith.c (_initialize_valarith): Remove.
2345
2346 2019-05-01  Tom Tromey  <tromey@adacore.com>
2347
2348         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2349         bitfields.
2350
2351 2019-05-01  Tom Tromey  <tromey@adacore.com>
2352
2353         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2354         for big-endian copies.
2355
2356 2019-04-30  Ali Tamur  <tamur@google.com>
2357         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2358         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2359         (read_3_bytes): New function.
2360
2361 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2362
2363         * windows-nat.c (main_thread_id): Delete.
2364         (handle_output_debug_string): Replace main_thread_id by
2365         current_event.dwThreadId.
2366         (fake_create_process): Likewise.
2367         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2368         Do not set main_thread_id.
2369         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2370         current_event.dwThreadId.
2371         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2372
2373 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2374
2375         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2376         Use current_event.dwThreadId instead of main_thread_id.
2377
2378 2019-04-30  Tom Tromey  <tromey@adacore.com>
2379
2380         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2381         (create_excep_cond_exprs): Iterate over program spaces.
2382         (ada_exception_catchpoint_cond_string): Examine all minimal
2383         symbols for exception types.
2384
2385 2019-04-30  Tom Tromey  <tromey@adacore.com>
2386
2387         PR c++/24470:
2388         * dwarf2read.c (process_structure_scope): Handle case where type
2389         has template parameters but no symbol was created.
2390
2391 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2392             Chris January  <chris.january@arm.com>
2393
2394         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2395         qualifier.
2396         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2397
2398 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2399
2400         * f-typeprint.c (f_print_type): Update rules for printing
2401         whitespace.
2402         (f_type_print_varspec_suffix): Likewise.
2403
2404 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2405             Chris January  <chris.january@arm.com>
2406
2407         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2408         function arguments.
2409
2410 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2411
2412         * f-lang.c (build_fortran_types): Change name of void type to
2413         lower case.
2414         * f-typeprint.c (f_type_print_base): Print the name of the void
2415         type, rather than a fixed string.
2416         * f-valprint.c (f_decorations): Use lower case void string.
2417
2418 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2419             Chris January  <chris.january@arm.com>
2420
2421         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2422         types for Fortran.
2423
2424 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2425             Chris January  <chris.january@arm.com>
2426             David Lecomber  <david.lecomber@arm.com>
2427
2428         * f-exp.y (BINOP_INTRINSIC): New token.
2429         (exp): New parser rule handling BINOP_INTRINSIC.
2430         (f77_keywords): Add new builtin procedures.
2431         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2432         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2433         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2434         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2435         (print_unop_subexp_f): New function.
2436         (print_binop_subexp_f): New function.
2437         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2438         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2439         (dump_subexp_body_f): Likewise.
2440         (operator_check_f): Likewise.
2441         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2442         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2443
2444 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2445
2446         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2447         UNOP_KIND.
2448         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2449         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2450         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2451         (operator_length_f): New fuction.
2452         (print_subexp_f): New function.
2453         (op_name_f): New function.
2454         (dump_subexp_body_f): New function.
2455         (operator_check_f): New function.
2456         (exp_descriptor_f): Replace standard expression handling functions
2457         with new functions.
2458         * gdb/fortran-operator.def: New file.
2459         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2460         * gdb/std-operator.def: Remove UNOP_KIND.
2461
2462 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * std-operator.def: Remove unbalanced, stray double quote
2465         character.
2466
2467 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2468             Chris January  <chris.january@arm.com>
2469             Daniel Everett  <daniel.everett@arm.com>
2470             Nick Forrington  <nick.forrington@arm.com>
2471             Richard Bunt  <richard.bunt@arm.com>
2472
2473         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2474         of depth when printing anonymous structs or unions.
2475         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2476         Don't print either the top-level value, or the children if the
2477         max-depth is exceeded.
2478         (ppscm_print_children): When printing the key of a map, allow one
2479         extra level of depth.
2480         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2481         print either the top-level value, or the children if the max-depth
2482         is exceeded.
2483         (print_children): When printing the key of a map, allow one extra
2484         level of depth.
2485         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2486         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2487         (user_print_options): Initialise max_depth field.
2488         (val_print_scalar_or_string_type_p): New function.
2489         (val_print): Check to see if the max depth has been reached.
2490         (val_print_check_max_depth): Define new function.
2491         (show_print_max_depth): New function.
2492         (_initialize_valprint): Add 'print max-depth' option.
2493         * valprint.h (struct value_print_options) <max_depth>: New field.
2494         (val_print_check_max_depth): Declare new function.
2495         * NEWS: Document new feature.
2496
2497 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2498
2499         * ada-lang.c (ada_language_defn): Initialise new field.
2500         * c-lang.c (c_is_string_type_p): New function.
2501         (c_language_defn): Initialise new field.
2502         (cplus_language_defn): Initialise new field.
2503         (asm_language_defn): Initialise new field.
2504         (minimal_language_defn): Initialise new field.
2505         * c-lang.h (c_is_string_type_p): Declare new function.
2506         * d-lang.c (d_language_defn): Initialise new field.
2507         * f-lang.c (f_is_string_type_p): New function.
2508         (f_language_defn): Initialise new field.
2509         * go-lang.c (go_is_string_type_p): New function.
2510         (go_language_defn): Initialise new field.
2511         * language.c (default_is_string_type_p): New function.
2512         (unknown_language_defn): Initialise new field.
2513         (auto_language_defn): Initialise new field.
2514         * language.h (struct language_defn) <la_is_string_type_p>: New
2515         member variable.
2516         (default_is_string_type_p): Declare new function.
2517         * m2-lang.c (m2_language_defn): Initialise new field.
2518         * objc-lang.c (objc_language_defn): Initialise new field.
2519         * opencl-lang.c (opencl_language_defn): Initialise new field.
2520         * p-lang.c (pascal_is_string_type_p): New function.
2521         (pascal_language_defn): Initialise new field.
2522         * rust-lang.c (rust_is_string_type_p): New function.
2523         (rust_language_defn): Initialise new field.
2524
2525 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2528         New field.
2529         * ada-lang.c (ada_language_defn): Initialise new field.
2530         * c-lang.c (c_language_defn): Likewise.
2531         (cplus_language_defn): Likewise.
2532         (asm_language_defn): Likewise.
2533         (minimal_language_defn): Likewise.
2534         * d-lang.c (d_language_defn): Likewise.
2535         * f-lang.c (f_language_defn): Likewise.
2536         * go-lang.c (go_language_defn): Likewise.
2537         * language.c (unknown_language_defn): Likewise.
2538         (auto_language_defn): Likewise.
2539         * m2-lang.c (m2_language_defn): Likewise.
2540         * objc-lang.c (objc_language_defn): Likewise.
2541         * opencl-lang.c (opencl_language_defn): Likewise.
2542         * p-lang.c (pascal_language_defn): Likewise.
2543         * rust-lang.c (rust_language_defn): Likewise.
2544
2545 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * ada-lang.c (ada_is_character_type): Change return type to bool.
2548         (ada_is_string_type): Likewise.
2549         * ada-lang.h (ada_is_character_type): Update declaration
2550         (ada_is_string_type): Likewise.
2551
2552 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2553
2554         Support style in 'frame|thread apply'
2555
2556         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2557         * record.c (record_start, record_stop): Update callers of
2558         execute_command_to_string with false.
2559         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2560         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2561         methods.
2562         (class string_file): New constructor with term_out parameter.
2563         Override methods term_out and can_emit_style_escape.  New member
2564         term_out.
2565         (class stdio_file): Override can_emit_style_escape.
2566         (class tee_file): Override term_out and can_emit_style_escape.
2567         * utils.h (can_emit_style_escape): Remove.
2568         * utils.c (can_emit_style_escape): Likewise.
2569         Update all callers of can_emit_style_escape (SOMESTREAM) to
2570         SOMESTREAM->can_emit_style_escape.
2571         * source-cache.c (source_cache::get_source_lines): Likewise.
2572         * stack.c (frame_apply_command_count): Call execute_command_to_string
2573         passing the term_out characteristic of the current gdb_stdout.
2574         * thread.c (thr_try_catch_cmd): Likewise.
2575         * top.c (execute_command_to_string): pass term_out parameter
2576         to construct the string_file for the command output.
2577         * ui-file.c (term_cli_styling): New function (most code moved
2578         from utils.c can_emit_style_escape).
2579         (string_file::string_file, string_file::can_emit_style_escape,
2580         stdio_file::can_emit_style_escape, tee_file::term_out,
2581         tee_file::can_emit_style_escape): New functions.
2582
2583 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2584
2585         * NEWS: Mention the new set|show may-call-functions.
2586         * infcall.c (may_call_functions_p): New variable.
2587         (show_may_call_functions_p): New function.
2588         (call_function_by_hand_dummy): Throws an error if not
2589         may-call-functions.
2590         (_initialize_infcall): Call add_setshow_boolean_cmd for
2591         may-call-functions.
2592
2593 2019-04-25  Keith Seitz  <keiths@redhat.com>
2594
2595         PR c++/24367
2596         * cp-support.c (inspect_type): Don't attempt substitutions
2597         of symbol with the same name.
2598
2599 2019-04-25  Tom Tromey  <tromey@adacore.com>
2600
2601         PR gdb/24475:
2602         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2603         static.
2604
2605 2019-04-25  Tom Tromey  <tromey@adacore.com>
2606
2607         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2608         rvalue reference.
2609         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2610         (gdb_xml_parser::parse): Use std::move.
2611         * python/python-internal.h (gdbpy_convert_exception): Take a const
2612         reference.
2613         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2614         std::move.
2615         * python/py-utils.c (gdbpy_convert_exception): Take a const
2616         reference.
2617         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2618         Use std::move.
2619         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2620         Use std::move.
2621         * mi/mi-main.c (mi_print_exception): Take a const reference.
2622         * main.c (handle_command_errors): Take a const reference.
2623         * linespec.c (parse_linespec): Use std::move.
2624         * infcall.c (run_inferior_call): Use std::move.
2625         (call_function_by_hand_dummy): Use std::move.
2626         * exec.c (try_open_exec_file): Use std::move.
2627         * exceptions.h (exception_print, exception_fprintf)
2628         (exception_print_same): Update.
2629         * exceptions.c (print_exception, exception_print)
2630         (exception_fprintf, exception_print_same): Change parameters to
2631         const reference.
2632         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2633         * common/new-op.c: Use std::move.
2634         * common/common-exceptions.h (struct gdb_exception): Add move
2635         constructor.
2636         (struct gdb_exception_error, struct gdb_exception_quit, struct
2637         gdb_quit_bad_alloc): Change constructor to move constructor.
2638         (throw_exception): Change parameter to rvalue reference.
2639         * common/common-exceptions.c (throw_exception): Take rvalue
2640         reference.
2641         * cli/cli-interp.c (safe_execute_command): Use std::move.
2642         * breakpoint.c (insert_bp_location, location_to_sals): Use
2643         std::move.
2644
2645 2019-04-25  Tom Tromey  <tromey@adacore.com>
2646
2647         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2648         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2649         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2650         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2651         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2652         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2653         guile/scm-value.c: Use unpack.
2654         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2655         gdbscm_gdb_exception.
2656         (gdbscm_throw_gdb_exception): Likewise.
2657         (struct gdbscm_gdb_exception): New.
2658         (unpack): New function.
2659         (gdbscm_wrap): Use unpack.
2660
2661 2019-04-25  Tom Tromey  <tromey@adacore.com>
2662
2663         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2664         (gdb_rl_callback_handler): Use std::move.
2665         * common/common-exceptions.h (struct gdb_exception): Add move
2666         assignment operator.
2667         (throw_exception_sjlj): Change "exception" to const reference.
2668         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2669         (throw_exception_sjlj): Change "exception" to const reference.
2670
2671 2019-04-25  Tom Tromey  <tromey@adacore.com>
2672
2673         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2674         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2675         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2676         Update.
2677         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2678         Update.
2679         * mi/mi-interp.c (mi_interp::exec): Update.
2680         * linespec.c (parse_linespec): Update.
2681         * infcall.c (run_inferior_call): Update.
2682         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2683         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2684         (gdbscm_lookup_global_symbol): Update.
2685         * guile/scm-param.c (gdbscm_parameter_value): Update.
2686         * guile/scm-frame.c (gdbscm_frame_read_register)
2687         (gdbscm_frame_read_var): Update.
2688         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2689         * exec.c (try_open_exec_file): Update.
2690         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2691         (gdb_rl_callback_handler): Update.
2692         * common/common-exceptions.h (exception_none): Don't declare.
2693         * common/common-exceptions.c (exception_none): Don't define.
2694         (struct catcher) <exception>: Update.
2695         * cli/cli-interp.c (safe_execute_command): Update.
2696         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2697
2698 2019-04-25  Ali Tamur  <tamur@google.com>
2699
2700         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2701         (read_attribute_value): Likewise.
2702         (dwarf2_read_addr_index): Update comment.
2703         (read_str_index): Add DW_FORM_strx.
2704         (dwarf2_string_attr): Likewise.
2705         (dwarf2_const_value_attr): Likewise.
2706         (dump_die_shallow): Likewise.
2707         (dwarf2_fetch_constant_bytes): Likewise.
2708         (skip_form_bytes): Likewise.
2709         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2710
2711 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2712
2713         PR corefiles/11608
2714         PR corefiles/18187
2715         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2716         OFFSET.  Verify if current mapping contains an ELF header.
2717         (linux_find_memory_regions_full): Adjust call to
2718         dump_mapping_p.
2719
2720 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2721             Kang Li <kanglictf@gmail.com>
2722
2723         PR gdb/21600
2724
2725         * dwarf2-frame.c (read_initial_length): Be consistent about using
2726         unsigned representation of length.
2727         (decode_frame_entry_1): Likewise.  Check for wraparound of
2728         end pointer as well as buffer overflow.
2729
2730 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2731
2732         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2733         "vq".
2734
2735 2019-04-24  Tom Tromey  <tromey@adacore.com>
2736
2737         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2738
2739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * s12z-tdep.c (s12z_unwind_pc): Delete.
2742         (s12z_unwind_sp): Delete.
2743         (s12z_gdbarch_init): Don't register deleted functions with
2744         gdbarch.
2745
2746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2747
2748         * rl78-tdep.c (rl78_unwind_sp): Delete.
2749         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2750
2751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2752
2753         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2754         (xstormy16_unwind_pc): Delete.
2755         (xstormy16_dummy_id): Delete.
2756         (xstormy16_gdbarch_init): Don't register deleted functions with
2757         gdbarch.
2758
2759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2760
2761         * vax-tdep.c (vax_unwind_pc): Delete.
2762         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2763
2764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2765
2766         * v850-tdep.c (v850_unwind_sp): Delete.
2767         (v850_unwind_pc): Delete.
2768         (v850_dummy_id): Delete.
2769         (v850_gdbarch_init): Don't register deleted functions with
2770         gdbarch.
2771
2772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2773
2774         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2775         (tilegx_unwind_pc): Delete.
2776         (tilegx_unwind_dummy_id): Delete.
2777         (tilegx_gdbarch_init): Don't register deleted functions with
2778         gdbarch.
2779
2780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2781
2782         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2783         (tic6x_dummy_id): Delete.
2784         (tic6x_gdbarch_init): Don't register deleted functions with
2785         gdbarch.
2786
2787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2788
2789         * sparc-tdep.c (sparc_unwind_pc): Delete.
2790         (sparc32_gdbarch_init): Don't register deleted function with
2791         gdbarch.
2792
2793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * sh-tdep.c (sh_unwind_sp): Delete.
2796         (sh_unwind_pc): Delete.
2797         (sh_dummy_id): Delete.
2798         (sh_gdbarch_init): Don't register deleted functions with
2799         gdbarch.
2800
2801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * score-tdep.c (score_unwind_sp): Delete.
2804         (score_unwind_pc): Delete.
2805         (score_dummy_id): Delete.
2806         (score_gdbarch_init): Don't register deleted functions with
2807         gdbarch.
2808
2809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2810
2811         * rx-tdep.c (rx_unwind_pc): Delete.
2812         (rx_unwind_sp): Delete.
2813         (rx_dummy_id): Delete.
2814         (rx_gdbarch_init): Don't register deleted functions with
2815         gdbarch.  Update comment.
2816
2817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2818
2819         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2820         (rs6000_dummy_id): Delete.
2821         (rs6000_gdbarch_init): Don't register deleted functions with
2822         gdbarch.
2823
2824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * or1k-tdep.c (or1k_dummy_id): Delete.
2827         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2828
2829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2830
2831         * nios2-tdep.c (nios2_dummy_id): Delete.
2832         (nios2_unwind_sp): Delete.
2833         (nios2_gdbarch_init): Don't register deleted functions with
2834         gdbarch.
2835
2836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * nds32-tdep.c (nds32_dummy_id): Delete.
2839         (nds32_unwind_pc): Delete.
2840         (nds32_unwind_sp): Delete.
2841         (nds32_gdbarch_init): Don't register deleted functions with
2842         gdbarch.
2843
2844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2845
2846         * msp430-tdep.c (msp430_unwind_pc): Delete.
2847         (msp430_unwind_sp): Delete.
2848         (msp430_dummy_id): Delete.
2849         (msp430_gdbarch_init): Don't register deleted functions with
2850         gdbarch.
2851
2852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2853
2854         * moxie-tdep.c (moxie_unwind_sp): Delete.
2855         (moxie_unwind_pc): Delete.
2856         (moxie_dummy_id): Delete.
2857         (moxie_gdbarch_init): Don't register deleted functions with
2858         gdbarch.
2859
2860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2863         (mn10300_unwind_pc): Delete.
2864         (mn10300_unwind_sp): Delete.
2865         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2866         mn10300_unwind_sp.
2867         (mn10300_frame_unwind_init): Don't register deleted functions with
2868         gdbarch.
2869
2870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2871
2872         * mep-tdep.c (mep_unwind_pc): Delete.
2873         (mep_unwind_sp): Delete.
2874         (mep_dummy_id): Delete.
2875         (mep_gdbarch_init): Don't register deleted functions with
2876         gdbarch.
2877
2878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2879
2880         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2881         (m68hc11_unwind_sp): Delete.
2882         (m68hc11_gdbarch_init): Don't register deleted functions with
2883         gdbarch.
2884
2885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * m32r-tdep.c (m32r_unwind_sp): Delete.
2888         (m32r_unwind_pc): Delete.
2889         (m32r_dummy_id): Delete.
2890         (m32r_gdbarch_init): Don't register deleted functions with
2891         gdbarch.
2892
2893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2894
2895         * m32c-tdep.c (m32c_unwind_pc): Delete.
2896         (m32c_unwind_sp): Delete.
2897         (m32c_dummy_id): Delete.
2898         (m32c_gdbarch_init): Don't register deleted functions with
2899         gdbarch.
2900
2901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2904         (lm32_unwind_pc): Delete.
2905         (lm32_dummy_id): Delete.
2906         (lm32_gdbarch_init): Don't register deleted functions with
2907         gdbarch.
2908
2909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2910
2911         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2912         (iq2000_unwind_pc): Delete.
2913         (iq2000_dummy_id): Delete.
2914         (iq2000_gdbarch_init): Don't register deleted functions with
2915         gdbarch.
2916
2917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2918
2919         * nds32-tdep.c (nds32_type_align): Delete.
2920         (nds32_push_dummy_call): Use type_align instead.
2921
2922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2923
2924         * arm-tdep.c (arm_type_align): Only handle vector override case.
2925         (arm_push_dummy_call): Use type_align.
2926         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2927
2928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2929
2930         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2931         case.
2932         (pass_on_stack): Use type_align.
2933         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2934         function.
2935
2936 2019-04-23  Tom Tromey  <tromey@adacore.com>
2937
2938         * dwarf2read.c (line_header::file_name_at): Remove unused
2939         overload.
2940
2941 2019-04-23  Tom de Vries  <tdevries@suse.de>
2942
2943         PR gdb/24438
2944         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2945         invocation.
2946
2947
2948 2019-03-27  Ali Tamur  <tamur@google.com>
2949
2950         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2951         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2952         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2953         (dwarf_expr_context::get_addr_index): Likewise
2954         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2955         (symbol_needs_eval_context::get_addr_index): Likewise
2956         (disassemble_dwarf_expression): Add DW_OP_addrx
2957         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2958         (read_cutu_die_from_dwo): Update comment
2959         (skip_one_die): Add DW_FORM_addrx
2960         (read_attribute_value): Likewise
2961         (var_decode_location): Add DW_OP_addrx
2962         (dwarf2_const_value_attr): Add DW_FORM_addrx
2963         (dump_die_shallow): Likewise
2964         (dwarf2_fetch_constant_bytes): Likewise
2965         (decode_locdesc): Add DW_OP_addrx
2966         (skip_form_bytes): Add DW_FORM_addrx
2967
2968 2019-04-22  Ali Tamur  <tamur@google.com>
2969
2970         * MAINTAINERS (Write After Approval): Add self.
2971
2972 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2973
2974         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2975         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2976         (open_symbol_file_object): Likewise.
2977         (svr4_default_sos): Add info parameter.
2978         (svr4_read_so_list): Likewise.
2979         (svr4_current_sos_direct): Adjust functions calls to pass down
2980         info.
2981         (svr4_current_sos_1): Add info parameter.
2982         (svr4_current_sos): Call get_svr4_info, pass info down to
2983         svr4_current_sos_1.
2984         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2985         get_svr4_info.
2986         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2987         get_svr4_info.
2988         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2989         to get_svr4_info.
2990         (probes_table_remove_objfile_probes): Likewise.
2991         (register_solib_event_probe): Add info parameter.
2992         (solist_update_incremental): Pass info parameter down to
2993         svr4_read_so_list.
2994         (disable_probes_interface): Add info parameter.
2995         (svr4_handle_solib_event): Pass current_program_space to
2996         get_svr4_info.  Adjust disable_probes_interface cleanup.
2997         (svr4_create_probe_breakpoints): Add info parameter, pass it
2998         down to register_solib_event_probe.
2999         (svr4_create_solib_event_breakpoints): Add info parameter,
3000         pass it down to svr4_create_probe_breakpoints.
3001         (enable_break): Pass info down to
3002         svr4_create_solib_event_breakpoints.
3003         (svr4_solib_create_inferior_hook): Pass current_program_space to
3004         get_svr4_info.
3005         (svr4_clear_solib): Likewise.
3006
3007 2019-04-22  Pedro Alves  <palves@redhat.com>
3008
3009         * solib-svr4.c (svr4_free_objfile_observer): New.
3010         (probe_and_action::objfile): New field.
3011         (probes_table_htab_remove_objfile_probes)
3012         (probes_table_remove_objfile_probes): New functions.
3013         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3014         in the new probe_and_action.  Don't store the probe in 'lookup'.
3015         (svr4_create_probe_breakpoints): Pass objfile to
3016         register_solib_event_probe.
3017         (_initialize_svr4_solib): Register a free_objfile observer.
3018
3019 2019-04-19  Tom Tromey  <tom@tromey.com>
3020
3021         * common/queue.h: Remove.
3022
3023 2019-04-19  Tom Tromey  <tom@tromey.com>
3024
3025         * event-loop.c: Don't include "common/queue.h".
3026
3027 2019-04-19  Tom Tromey  <tom@tromey.com>
3028
3029         * remote.c (remote_target): Use delete.
3030         * remote-notif.h: Include <list>, not "common/queue.h".
3031         (notif_client_p): Remove typedef.
3032         (remote_notif_state): Add constructor, destructor, initializer.
3033         <notif_queue>: Now a std::list.
3034         (remote_notif_state_xfree): Don't declare.
3035         * remote-notif.c (remote_notif_process, handle_notification)
3036         (remote_notif_state_allocate): Update.
3037         (~remote_notif_state): Rename from remote_notif_state_xfree.
3038
3039 2019-04-19  Tom Tromey  <tom@tromey.com>
3040
3041         * symfile.c (reread_symbols): Update.
3042         * objfiles.c (objfile_register_static_link)
3043         (objfile_lookup_static_link): Update
3044         (~objfile) Don't delete static_links.
3045         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3046
3047 2019-04-19  Tom Tromey  <tom@tromey.com>
3048
3049         * type-stack.h (struct type_stack) <insert>: Constify string.
3050         * type-stack.c (type_stack::insert): Constify string.
3051         * gdbtypes.h (lookup_template_type): Update.
3052         (address_space_name_to_int): Update.
3053         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3054         const.
3055         (lookup_template_type): Make name const.
3056         * c-exp.y: Update rules.
3057         (lex_one_token, classify_name, classify_inner_name)
3058         (c_print_token): Update.
3059         * p-exp.y: Update rules.
3060         (yylex): Update.
3061         * f-exp.y: Update rules.
3062         (yylex): Update.
3063         * d-exp.y: Update rules.
3064         (lex_one_token, classify_name, classify_inner_name): Update.
3065         * parse.c (write_dollar_variable, copy_name): Return std::string.
3066         * parser-defs.h (copy_name): Change return type.
3067         * m2-exp.y: Update rules.
3068         (yylex): Update.
3069         * go-exp.y (lex_one_token): Update.
3070         Update rules.
3071         (classify_unsafe_function, classify_packaged_name)
3072         (classify_name, yylex): Update.
3073
3074 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3075
3076         * configure.ac: add --enable-source-highlight switch.
3077         * configure: Regenerate.
3078         * top.c (print_gdb_version): plumb --enable-source-highlight
3079         status to "show configuration".
3080
3081 2019-04-19  Tom Tromey  <tromey@adacore.com>
3082
3083         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3084         Check ADA_TYPE_P.
3085         (empty_record, ada_template_to_fixed_record_type_1)
3086         (template_to_static_fixed_type)
3087         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3088         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3089         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3090         macros.
3091
3092 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3093
3094         PR symtab/24423:
3095         * source.c (print_source_lines_base): Advance "iter" when a
3096         control character is seen.
3097
3098 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3099
3100         * inferior.h (struct infcall_suspend_state_deleter):
3101         Catch exception in destructor to avoid crash.
3102
3103 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3104
3105         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3106         close to the add_com "shell".
3107
3108 2019-04-18  Tom Tromey  <tromey@adacore.com>
3109
3110         * process-stratum-target.h (class process_stratum_target)
3111         <stratum>: Add "final".
3112
3113 2019-04-17  Tom Tromey  <tromey@adacore.com>
3114
3115         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3116         against nullptr before use.
3117
3118 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3119
3120         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3121
3122 2019-04-17  Jim Wilson  <jimw@sifive.com>
3123             Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3126         code read might fail, assume 4-byte breakpoint in that case.
3127
3128 2019-04-15  Leszek Swirski  <leszeks@google.com>
3129
3130         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3131         rather than a hand-rolled POD check when checking for forced MEMORY
3132         classification.
3133
3134 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3135
3136         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3137         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3138         function.
3139         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3140         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3141         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3142         declaration.
3143
3144 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3145
3146         * aarch64-linux-nat.c
3147         (aarch64_linux_nat_target::thread_architecture): Add override.
3148         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3149         each VQ.
3150
3151 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3152
3153         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3154
3155 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3158         target types of size 96-bits, add some additional comments, and
3159         check that the builtin type we found was the correct size.
3160
3161 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3162
3163         * utils.c (prompt_for_continue): Don't restore the styling at the
3164         end, as applied_style has the wrong value.  This fixes styling in
3165         long lists of file names that are interrupted by the "Continue?"
3166         prompt.
3167
3168 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3169
3170         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3171         * c-lang.c (c_language_defn): Likewise.
3172         (cplus_language_defn): Likewise.
3173         (asm_language_defn): Likewise.
3174         (minimal_language_defn): Likewise.
3175         * d-lang.c (d_language_defn): Likewise.
3176         * f-lang.c (f_language_defn): Likewise.
3177         * go-lang.c (go_language_defn): Likewise.
3178         * language.c (unknown_language_defn): Likewise.
3179         (auto_language_defn): Likewise.
3180         * language.h (struct language_defn): Remove la_magic field.
3181         (LANG_MAGIC): Delete.
3182         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3183         * objc-lang.c (objc_language_defn): Likewise.
3184         * opencl-lang.c (opencl_language_defn): Likewise.
3185         * p-lang.c (pascal_language_defn): Likewise.
3186         * rust-lang.c (rust_language_defn): Likewise.
3187
3188 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3189
3190         * riscv-tdep.c (riscv_type_align): New function.
3191         (riscv_type_alignment): Delete.
3192         (riscv_arg_location): Use 'type_align'.
3193         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3194
3195 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3196
3197         * gdbtypes.c (type_align): A struct with no non-static fields also
3198         has alignment of 1.
3199
3200 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3203         component to 0.
3204         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3205         member.
3206         (riscv_struct_info::analyse): New implementation using new
3207         analyse_inner member function.
3208         (riscv_struct_info::field_offset): New member function.
3209         (riscv_struct_info::m_offsets): New member variable.
3210         (riscv_struct_info::analyse_inner): New private member function,
3211         takes the old implementation of riscv_struct_info::analyse but
3212         extended to track field offsets.
3213         (riscv_call_arg_struct): Update the struct folding special cases
3214         to handle cases where empty C++ structs, which are non-zero
3215         length, are found.
3216         (riscv_arg_location): Initialise the length of each location, a
3217         non-zero length now indicates the location is in use.
3218         (riscv_push_dummy_call): Allow for the first location having a
3219         non-zero offset when setting up arguments.
3220         (riscv_return_value): Likewise, but for return values.
3221
3222 2019-04-11  Tom Tromey  <tromey@adacore.com>
3223
3224         * utils.c (internal_vproblem): Make "msg" const.
3225
3226 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3227
3228         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3229         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3230         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3231         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3232
3233 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3234
3235         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3236         function.
3237         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3238         of amd64_collect_native_gregset.
3239         (amd64_linux_nat_target::store_registers): Likewise.
3240
3241 2019-04-10  Tom Tromey  <tom@tromey.com>
3242
3243         * symtab.c (lookup_global_symbol_from_objfile)
3244         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3245         * objfiles.h (class separate_debug_iterator): New.
3246         (class separate_debug_range): New.
3247         (struct objfile) <separate_debug_objfiles>: New method.
3248         (objfile_separate_debug_iterate): Don't declare.
3249         * objfiles.c (separate_debug_iterator::operator++): Rename from
3250         objfile_separate_debug_iterate.
3251         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3252         iterator.
3253         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3254         iterator.
3255
3256 2019-04-10  Tom Tromey  <tom@tromey.com>
3257
3258         * symfile.c (reread_symbols): Remove old comment.
3259         * objfiles.c (free_all_objfiles): Fix a typo.
3260
3261 2019-04-10  Tom Tromey  <tom@tromey.com>
3262
3263         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3264         * minsyms.c (lookup_minimal_symbol): Use foreach.
3265         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3266         (lookup_minimal_symbol_solib_trampoline): Likewise.
3267         * symfile.c (reread_symbols): Use foreach.
3268
3269 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3270             Tom Tromey  <tromey@adacore.com>
3271
3272         PR rust/24414:
3273         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3274         (rust_lex_int_test): Change "value" to be LONGEST.
3275         (rust_lex_tests): Add test for long integer literal.
3276
3277 2019-04-09  Tom Tromey  <tromey@adacore.com>
3278
3279         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3280         to bool.
3281         (extended_remote_target::attach): Update.
3282         (remote_target::remote_notice_new_inferior): Update.
3283         (remote_target::add_current_inferior_and_thread): Update.
3284         * inferior.c (exit_inferior_1): Use "false".
3285         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3286
3287 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3288
3289         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3290         the "start" command.
3291
3292 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3293
3294         * python/py-inferior.c (infpy_thread_from_thread_handle):
3295         Adjust comments to reflect renaming of thread_from_thread_handle
3296         to thread_from_handle.  Adjust keywords.  Fix type error message.
3297         (inferior_object_methods): Add thread_from_handle.  Retain
3298         thread_from_thread_handle, but mark it as deprecated.
3299
3300 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3301
3302         * gdbthread.h (find_thread_by_handle): Revise declaration.
3303         * thread.c (find_thread_by_handle): Likewise.  Adjust
3304         implementation too.
3305         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3306         support for buffer objects as handles.
3307
3308 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3309
3310         * python/py-infthread.c (thpy_thread_handle): New function.
3311         (thread_object_methods): Register thpy_thread_handle.
3312
3313 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3314
3315         * gdbthread.h (thread_to_thread_handle): Declare.
3316         * thread.c (gdbtypes.h): Include.
3317         (thread_to_thread_handle): New function.
3318
3319         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3320         (target_thread_info_to_thread_handle): Declare.
3321         * target.c (target_thread_info_to_thread_handle): New function.
3322         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3323         * target-delegates.c: Regenerate.
3324
3325         * linux-thread-db.c (class thread_db_target): Add method
3326         thread_info_to_thread_handle.
3327         (thread_db_target::thread_info_to_thread_handle): Define.
3328         * remote.c (class remote_target): Add new method
3329         thread_info_to_thread_handle.
3330         (remote_target::thread_info_to_thread_handle): Define.
3331
3332 2019-04-08  Pedro Alves  <palves@redhat.com>
3333
3334         * common/common-exceptions.c (throw_exception): Don't create
3335         named object to throw; throw directly.
3336         (throw_it): Likewise.  Don't initialize gdb_exception::message
3337         here, with new; pass FMT and AP to the ctor instead.
3338         * common/common-exceptions.h: Include <string>.
3339         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3340         const char *, va_list)): New ctor.  Use std::make_shared.
3341         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3342         errors)): Delete.
3343         (gdb_exception_error::gdb_exception_error(enum errors, const char
3344         *, va_list)): New.
3345         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3346         Add assertion.
3347         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3348         errors)): Delete.
3349         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3350         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3351         Add assertion.
3352
3353 2019-04-08  Tom Tromey  <tom@tromey.com>
3354
3355         * valops.c (value_rtti_indirect_type): Replace throw_exception
3356         with throw.
3357         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3358         with throw.
3359         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3360         throw.
3361         * target.c (target_translate_tls_address): Replace throw_exception
3362         with throw.
3363         * stack.c (frame_apply_command_count): Replace throw_exception
3364         with throw.
3365         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3366         throw.
3367         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3368         with throw.
3369         * rs6000-tdep.c (rs6000_frame_cache)
3370         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3371         * remote.c: Replace throw_exception with throw.
3372         * record-full.c (record_full_message, record_full_wait_1)
3373         (record_full_restore): Replace throw_exception with throw.
3374         * record-btrace.c:
3375         (get_thread_current_frame_id, record_btrace_start_replaying)
3376         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3377         (cmd_record_btrace_start): Replace throw_exception with throw.
3378         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3379         throw.
3380         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3381         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3382         * linespec.c:
3383         (find_linespec_symbols): Replace throw_exception with throw.
3384         * infrun.c (displaced_step_prepare, resume): Replace
3385         throw_exception with throw.
3386         * infcmd.c (post_create_inferior): Replace throw_exception with
3387         throw.
3388         * inf-loop.c (inferior_event_handler): Replace throw_exception
3389         with throw.
3390         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3391         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3392         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3393         (get_prev_frame_always, get_frame_pc_if_available)
3394         (get_frame_address_in_block_if_available, get_frame_language):
3395         Replace throw_exception with throw.
3396         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3397         throw_exception with throw.
3398         * eval.c (fetch_subexp_value, evaluate_var_value)
3399         (evaluate_funcall, evaluate_subexp_standard): Replace
3400         throw_exception with throw.
3401         * dwarf2loc.c (call_site_find_chain)
3402         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3403         Replace throw_exception with throw.
3404         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3405         with throw.
3406         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3407         throw.
3408         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3409         * completer.c (complete_line_internal): Replace throw_exception
3410         with throw.
3411         * compile/compile-object-run.c (compile_object_run): Replace
3412         throw_exception with throw.
3413         * cli/cli-script.c (process_next_line): Replace throw_exception
3414         with throw.
3415         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3416         (btrace_enable, btrace_maint_update_pt_packets): Replace
3417         throw_exception with throw.
3418         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3419         throw_exception with throw.
3420         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3421         throw_exception with throw.
3422         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3423         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3424         * aarch64-tdep.c (aarch64_make_prologue_cache)
3425         (aarch64_make_stub_cache): Replace throw_exception with throw.
3426
3427 2019-04-08  Tom Tromey  <tom@tromey.com>
3428
3429         * common/common-exceptions.c (throw_exception): Rename from
3430         throw_exception_cxx.  Remove old copy.  Make argument const.
3431         (throw_it): Create and throw exception objects directly.
3432         * common/common-exceptions.h (throw_exception): Make argument
3433         const.
3434         (struct gdb_exception_error): Add constructor.
3435         (struct gdb_exception_quit): Add constructor.
3436
3437 2019-04-08  Tom Tromey  <tom@tromey.com>
3438
3439         * common/common-exceptions.h (exception_rethrow): Don't declare.
3440         (TRY_SJLJ): Update comment.
3441         (TRY, CATCH, END_CATCH): Remove.
3442         * common/common-exceptions.c (exception_rethrow): Remove.
3443
3444 2019-04-08  Tom Tromey  <tom@tromey.com>
3445
3446         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3447         Remove.
3448         (gdb_exception_error): Rename from
3449         gdb_exception_RETURN_MASK_ERROR.
3450         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3451         (gdb_quit_bad_alloc): Update.
3452         * aarch64-tdep.c: Update.
3453         * ada-lang.c: Update.
3454         * ada-typeprint.c: Update.
3455         * ada-valprint.c: Update.
3456         * amd64-tdep.c: Update.
3457         * arch-utils.c: Update.
3458         * break-catch-throw.c: Update.
3459         * breakpoint.c: Update.
3460         * btrace.c: Update.
3461         * c-varobj.c: Update.
3462         * cli/cli-cmds.c: Update.
3463         * cli/cli-interp.c: Update.
3464         * cli/cli-script.c: Update.
3465         * common/common-exceptions.c: Update.
3466         * common/new-op.c: Update.
3467         * common/selftest.c: Update.
3468         * compile/compile-c-symbols.c: Update.
3469         * compile/compile-cplus-symbols.c: Update.
3470         * compile/compile-object-load.c: Update.
3471         * compile/compile-object-run.c: Update.
3472         * completer.c: Update.
3473         * corelow.c: Update.
3474         * cp-abi.c: Update.
3475         * cp-support.c: Update.
3476         * cp-valprint.c: Update.
3477         * darwin-nat.c: Update.
3478         * disasm-selftests.c: Update.
3479         * dtrace-probe.c: Update.
3480         * dwarf-index-cache.c: Update.
3481         * dwarf-index-write.c: Update.
3482         * dwarf2-frame-tailcall.c: Update.
3483         * dwarf2-frame.c: Update.
3484         * dwarf2loc.c: Update.
3485         * dwarf2read.c: Update.
3486         * eval.c: Update.
3487         * event-loop.c: Update.
3488         * event-top.c: Update.
3489         * exec.c: Update.
3490         * f-valprint.c: Update.
3491         * fbsd-tdep.c: Update.
3492         * frame-unwind.c: Update.
3493         * frame.c: Update.
3494         * gdbtypes.c: Update.
3495         * gnu-v3-abi.c: Update.
3496         * guile/guile-internal.h: Update.
3497         * guile/scm-block.c: Update.
3498         * guile/scm-breakpoint.c: Update.
3499         * guile/scm-cmd.c: Update.
3500         * guile/scm-disasm.c: Update.
3501         * guile/scm-frame.c: Update.
3502         * guile/scm-lazy-string.c: Update.
3503         * guile/scm-math.c: Update.
3504         * guile/scm-param.c: Update.
3505         * guile/scm-ports.c: Update.
3506         * guile/scm-pretty-print.c: Update.
3507         * guile/scm-symbol.c: Update.
3508         * guile/scm-symtab.c: Update.
3509         * guile/scm-type.c: Update.
3510         * guile/scm-value.c: Update.
3511         * i386-linux-tdep.c: Update.
3512         * i386-tdep.c: Update.
3513         * inf-loop.c: Update.
3514         * infcall.c: Update.
3515         * infcmd.c: Update.
3516         * infrun.c: Update.
3517         * jit.c: Update.
3518         * language.c: Update.
3519         * linespec.c: Update.
3520         * linux-fork.c: Update.
3521         * linux-nat.c: Update.
3522         * linux-tdep.c: Update.
3523         * linux-thread-db.c: Update.
3524         * main.c: Update.
3525         * mi/mi-cmd-break.c: Update.
3526         * mi/mi-cmd-stack.c: Update.
3527         * mi/mi-interp.c: Update.
3528         * mi/mi-main.c: Update.
3529         * objc-lang.c: Update.
3530         * p-valprint.c: Update.
3531         * parse.c: Update.
3532         * ppc-linux-tdep.c: Update.
3533         * printcmd.c: Update.
3534         * python/py-arch.c: Update.
3535         * python/py-breakpoint.c: Update.
3536         * python/py-cmd.c: Update.
3537         * python/py-finishbreakpoint.c: Update.
3538         * python/py-frame.c: Update.
3539         * python/py-framefilter.c: Update.
3540         * python/py-gdb-readline.c: Update.
3541         * python/py-inferior.c: Update.
3542         * python/py-infthread.c: Update.
3543         * python/py-lazy-string.c: Update.
3544         * python/py-linetable.c: Update.
3545         * python/py-objfile.c: Update.
3546         * python/py-param.c: Update.
3547         * python/py-prettyprint.c: Update.
3548         * python/py-progspace.c: Update.
3549         * python/py-record-btrace.c: Update.
3550         * python/py-record.c: Update.
3551         * python/py-symbol.c: Update.
3552         * python/py-type.c: Update.
3553         * python/py-unwind.c: Update.
3554         * python/py-utils.c: Update.
3555         * python/py-value.c: Update.
3556         * python/python.c: Update.
3557         * record-btrace.c: Update.
3558         * record-full.c: Update.
3559         * remote-fileio.c: Update.
3560         * remote.c: Update.
3561         * riscv-tdep.c: Update.
3562         * rs6000-aix-tdep.c: Update.
3563         * rs6000-tdep.c: Update.
3564         * rust-exp.y: Update.
3565         * rust-lang.c: Update.
3566         * s390-tdep.c: Update.
3567         * selftest-arch.c: Update.
3568         * solib-dsbt.c: Update.
3569         * solib-frv.c: Update.
3570         * solib-spu.c: Update.
3571         * solib-svr4.c: Update.
3572         * solib.c: Update.
3573         * sparc64-linux-tdep.c: Update.
3574         * stack.c: Update.
3575         * symfile-mem.c: Update.
3576         * symmisc.c: Update.
3577         * target.c: Update.
3578         * thread.c: Update.
3579         * top.c: Update.
3580         * tracefile-tfile.c: Update.
3581         * tui/tui.c: Update.
3582         * typeprint.c: Update.
3583         * unittests/cli-utils-selftests.c: Update.
3584         * unittests/parse-connection-spec-selftests.c: Update.
3585         * valops.c: Update.
3586         * valprint.c: Update.
3587         * value.c: Update.
3588         * varobj.c: Update.
3589         * windows-nat.c: Update.
3590         * x86-linux-nat.c: Update.
3591         * xml-support.c: Update.
3592
3593 2019-04-08  Tom Tromey  <tom@tromey.com>
3594
3595         * xml-support.c: Use C++ exception handling.
3596         * x86-linux-nat.c: Use C++ exception handling.
3597         * windows-nat.c: Use C++ exception handling.
3598         * varobj.c: Use C++ exception handling.
3599         * value.c: Use C++ exception handling.
3600         * valprint.c: Use C++ exception handling.
3601         * valops.c: Use C++ exception handling.
3602         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3603         handling.
3604         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3605         * typeprint.c: Use C++ exception handling.
3606         * tui/tui.c: Use C++ exception handling.
3607         * tracefile-tfile.c: Use C++ exception handling.
3608         * top.c: Use C++ exception handling.
3609         * thread.c: Use C++ exception handling.
3610         * target.c: Use C++ exception handling.
3611         * symmisc.c: Use C++ exception handling.
3612         * symfile-mem.c: Use C++ exception handling.
3613         * stack.c: Use C++ exception handling.
3614         * sparc64-linux-tdep.c: Use C++ exception handling.
3615         * solib.c: Use C++ exception handling.
3616         * solib-svr4.c: Use C++ exception handling.
3617         * solib-spu.c: Use C++ exception handling.
3618         * solib-frv.c: Use C++ exception handling.
3619         * solib-dsbt.c: Use C++ exception handling.
3620         * selftest-arch.c: Use C++ exception handling.
3621         * s390-tdep.c: Use C++ exception handling.
3622         * rust-lang.c: Use C++ exception handling.
3623         * rust-exp.y: Use C++ exception handling.
3624         * rs6000-tdep.c: Use C++ exception handling.
3625         * rs6000-aix-tdep.c: Use C++ exception handling.
3626         * riscv-tdep.c: Use C++ exception handling.
3627         * remote.c: Use C++ exception handling.
3628         * remote-fileio.c: Use C++ exception handling.
3629         * record-full.c: Use C++ exception handling.
3630         * record-btrace.c: Use C++ exception handling.
3631         * python/python.c: Use C++ exception handling.
3632         * python/py-value.c: Use C++ exception handling.
3633         * python/py-utils.c: Use C++ exception handling.
3634         * python/py-unwind.c: Use C++ exception handling.
3635         * python/py-type.c: Use C++ exception handling.
3636         * python/py-symbol.c: Use C++ exception handling.
3637         * python/py-record.c: Use C++ exception handling.
3638         * python/py-record-btrace.c: Use C++ exception handling.
3639         * python/py-progspace.c: Use C++ exception handling.
3640         * python/py-prettyprint.c: Use C++ exception handling.
3641         * python/py-param.c: Use C++ exception handling.
3642         * python/py-objfile.c: Use C++ exception handling.
3643         * python/py-linetable.c: Use C++ exception handling.
3644         * python/py-lazy-string.c: Use C++ exception handling.
3645         * python/py-infthread.c: Use C++ exception handling.
3646         * python/py-inferior.c: Use C++ exception handling.
3647         * python/py-gdb-readline.c: Use C++ exception handling.
3648         * python/py-framefilter.c: Use C++ exception handling.
3649         * python/py-frame.c: Use C++ exception handling.
3650         * python/py-finishbreakpoint.c: Use C++ exception handling.
3651         * python/py-cmd.c: Use C++ exception handling.
3652         * python/py-breakpoint.c: Use C++ exception handling.
3653         * python/py-arch.c: Use C++ exception handling.
3654         * printcmd.c: Use C++ exception handling.
3655         * ppc-linux-tdep.c: Use C++ exception handling.
3656         * parse.c: Use C++ exception handling.
3657         * p-valprint.c: Use C++ exception handling.
3658         * objc-lang.c: Use C++ exception handling.
3659         * mi/mi-main.c: Use C++ exception handling.
3660         * mi/mi-interp.c: Use C++ exception handling.
3661         * mi/mi-cmd-stack.c: Use C++ exception handling.
3662         * mi/mi-cmd-break.c: Use C++ exception handling.
3663         * main.c: Use C++ exception handling.
3664         * linux-thread-db.c: Use C++ exception handling.
3665         * linux-tdep.c: Use C++ exception handling.
3666         * linux-nat.c: Use C++ exception handling.
3667         * linux-fork.c: Use C++ exception handling.
3668         * linespec.c: Use C++ exception handling.
3669         * language.c: Use C++ exception handling.
3670         * jit.c: Use C++ exception handling.
3671         * infrun.c: Use C++ exception handling.
3672         * infcmd.c: Use C++ exception handling.
3673         * infcall.c: Use C++ exception handling.
3674         * inf-loop.c: Use C++ exception handling.
3675         * i386-tdep.c: Use C++ exception handling.
3676         * i386-linux-tdep.c: Use C++ exception handling.
3677         * guile/scm-value.c: Use C++ exception handling.
3678         * guile/scm-type.c: Use C++ exception handling.
3679         * guile/scm-symtab.c: Use C++ exception handling.
3680         * guile/scm-symbol.c: Use C++ exception handling.
3681         * guile/scm-pretty-print.c: Use C++ exception handling.
3682         * guile/scm-ports.c: Use C++ exception handling.
3683         * guile/scm-param.c: Use C++ exception handling.
3684         * guile/scm-math.c: Use C++ exception handling.
3685         * guile/scm-lazy-string.c: Use C++ exception handling.
3686         * guile/scm-frame.c: Use C++ exception handling.
3687         * guile/scm-disasm.c: Use C++ exception handling.
3688         * guile/scm-cmd.c: Use C++ exception handling.
3689         * guile/scm-breakpoint.c: Use C++ exception handling.
3690         * guile/scm-block.c: Use C++ exception handling.
3691         * guile/guile-internal.h: Use C++ exception handling.
3692         * gnu-v3-abi.c: Use C++ exception handling.
3693         * gdbtypes.c: Use C++ exception handling.
3694         * frame.c: Use C++ exception handling.
3695         * frame-unwind.c: Use C++ exception handling.
3696         * fbsd-tdep.c: Use C++ exception handling.
3697         * f-valprint.c: Use C++ exception handling.
3698         * exec.c: Use C++ exception handling.
3699         * event-top.c: Use C++ exception handling.
3700         * event-loop.c: Use C++ exception handling.
3701         * eval.c: Use C++ exception handling.
3702         * dwarf2read.c: Use C++ exception handling.
3703         * dwarf2loc.c: Use C++ exception handling.
3704         * dwarf2-frame.c: Use C++ exception handling.
3705         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3706         * dwarf-index-write.c: Use C++ exception handling.
3707         * dwarf-index-cache.c: Use C++ exception handling.
3708         * dtrace-probe.c: Use C++ exception handling.
3709         * disasm-selftests.c: Use C++ exception handling.
3710         * darwin-nat.c: Use C++ exception handling.
3711         * cp-valprint.c: Use C++ exception handling.
3712         * cp-support.c: Use C++ exception handling.
3713         * cp-abi.c: Use C++ exception handling.
3714         * corelow.c: Use C++ exception handling.
3715         * completer.c: Use C++ exception handling.
3716         * compile/compile-object-run.c: Use C++ exception handling.
3717         * compile/compile-object-load.c: Use C++ exception handling.
3718         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3719         * compile/compile-c-symbols.c: Use C++ exception handling.
3720         * common/selftest.c: Use C++ exception handling.
3721         * common/new-op.c: Use C++ exception handling.
3722         * cli/cli-script.c: Use C++ exception handling.
3723         * cli/cli-interp.c: Use C++ exception handling.
3724         * cli/cli-cmds.c: Use C++ exception handling.
3725         * c-varobj.c: Use C++ exception handling.
3726         * btrace.c: Use C++ exception handling.
3727         * breakpoint.c: Use C++ exception handling.
3728         * break-catch-throw.c: Use C++ exception handling.
3729         * arch-utils.c: Use C++ exception handling.
3730         * amd64-tdep.c: Use C++ exception handling.
3731         * ada-valprint.c: Use C++ exception handling.
3732         * ada-typeprint.c: Use C++ exception handling.
3733         * ada-lang.c: Use C++ exception handling.
3734         * aarch64-tdep.c: Use C++ exception handling.
3735
3736 2019-04-08  Tom Tromey  <tom@tromey.com>
3737
3738         * xml-support.c (gdb_xml_parser::parse): Update.
3739         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3740         * value.c (show_convenience): Update.
3741         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3742         (test_parse_flags_qcs): Update.
3743         * thread.c (thr_try_catch_cmd): Update.
3744         * target.c (target_translate_tls_address): Update.
3745         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3746         (info_frame_command_core, frame_apply_command_count): Update.
3747         * rust-exp.y (rust_lex_exception_test): Update.
3748         * riscv-tdep.c (riscv_print_one_register_info): Update.
3749         * remote.c (remote_target::enable_btrace): Update.
3750         * record-btrace.c (record_btrace_enable_warn): Update.
3751         * python/py-utils.c (gdbpy_convert_exception): Update.
3752         * printcmd.c (do_one_display, print_variable_and_value): Update.
3753         * mi/mi-main.c (mi_print_exception): Update.
3754         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3755         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3756         * linux-nat.c (linux_nat_target::attach): Update.
3757         * linux-fork.c (class scoped_switch_fork_info): Update.
3758         * infrun.c (displaced_step_prepare): Update.
3759         * infcall.c (call_function_by_hand_dummy): Update.
3760         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3761         * gnu-v3-abi.c (print_one_vtable): Update.
3762         * frame.c (get_prev_frame_always): Update.
3763         * f-valprint.c (info_common_command_for_block): Update.
3764         * exec.c (try_open_exec_file): Update.
3765         * exceptions.c (print_exception, exception_print)
3766         (exception_fprintf, exception_print_same): Update.
3767         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3768         * dwarf-index-cache.c (index_cache::store)
3769         (index_cache::lookup_gdb_index): Update.
3770         * darwin-nat.c (maybe_cache_shell): Update.
3771         * cp-valprint.c (cp_print_value_fields): Update.
3772         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3773         (gcc_cplus_symbol_address): Update.
3774         * compile/compile-c-symbols.c (gcc_convert_symbol)
3775         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3776         * common/selftest.c: Update.
3777         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3778         a std::string.
3779         (exception_try_scope_entry, exception_try_scope_exit): Don't
3780         declare.
3781         (struct exception_try_scope): Remove.
3782         (TRY): Don't use exception_try_scope.
3783         (struct gdb_exception): Add constructor, operator=.
3784         <what>: New method.
3785         (struct gdb_exception_RETURN_MASK_ALL)
3786         (struct gdb_exception_RETURN_MASK_ERROR)
3787         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3788         (struct gdb_quit_bad_alloc): Update.
3789         * common/common-exceptions.c (exception_none): Change
3790         initializer.
3791         (struct catcher) <state, exception>: Initialize inline.
3792         <prev>: Remove member.
3793         (current_catcher): Remove.
3794         (catchers): New global.
3795         (exceptions_state_mc_init): Simplify.
3796         (catcher_pop): Remove.
3797         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3798         (try_scope_depth, exception_try_scope_entry)
3799         (exception_try_scope_exit): Remove.
3800         (throw_exception_sjlj): Update.
3801         (exception_messages, exception_messages_size): Remove.
3802         (throw_it): Simplify.
3803         (gdb_exception_sliced_copy): Remove.
3804         (throw_exception_cxx): Update.
3805         * cli/cli-script.c (script_from_file): Update.
3806         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3807         Update.
3808         * ada-valprint.c (ada_val_print): Update.
3809         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3810         (create_excep_cond_exprs): Update.
3811
3812 2019-04-08  Tom Tromey  <tom@tromey.com>
3813
3814         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3815         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3816         (TRY, CATCH, END_CATCH): Remove some definitions.
3817         * common/common-exceptions.c: Don't use GDB_XCPT.
3818         (catcher_list_size): Remove.
3819         (throw_exception, throw_it): Simplify.
3820
3821 2019-04-05  Tom Tromey  <tom@tromey.com>
3822
3823         Revert the header-sorting patch.
3824         * ft32-tdep.c: Revert.
3825         * frv-tdep.c: Revert.
3826         * frv-linux-tdep.c: Revert.
3827         * frame.c: Revert.
3828         * frame-unwind.c: Revert.
3829         * frame-base.c: Revert.
3830         * fork-child.c: Revert.
3831         * findvar.c: Revert.
3832         * findcmd.c: Revert.
3833         * filesystem.c: Revert.
3834         * filename-seen-cache.h: Revert.
3835         * filename-seen-cache.c: Revert.
3836         * fbsd-tdep.c: Revert.
3837         * fbsd-nat.h: Revert.
3838         * fbsd-nat.c: Revert.
3839         * f-valprint.c: Revert.
3840         * f-typeprint.c: Revert.
3841         * f-lang.c: Revert.
3842         * extension.h: Revert.
3843         * extension.c: Revert.
3844         * extension-priv.h: Revert.
3845         * expprint.c: Revert.
3846         * exec.h: Revert.
3847         * exec.c: Revert.
3848         * exceptions.c: Revert.
3849         * event-top.c: Revert.
3850         * event-loop.c: Revert.
3851         * eval.c: Revert.
3852         * elfread.c: Revert.
3853         * dwarf2read.h: Revert.
3854         * dwarf2read.c: Revert.
3855         * dwarf2loc.c: Revert.
3856         * dwarf2expr.h: Revert.
3857         * dwarf2expr.c: Revert.
3858         * dwarf2-frame.c: Revert.
3859         * dwarf2-frame-tailcall.c: Revert.
3860         * dwarf-index-write.h: Revert.
3861         * dwarf-index-write.c: Revert.
3862         * dwarf-index-common.c: Revert.
3863         * dwarf-index-cache.h: Revert.
3864         * dwarf-index-cache.c: Revert.
3865         * dummy-frame.c: Revert.
3866         * dtrace-probe.c: Revert.
3867         * disasm.h: Revert.
3868         * disasm.c: Revert.
3869         * disasm-selftests.c: Revert.
3870         * dictionary.c: Revert.
3871         * dicos-tdep.c: Revert.
3872         * demangle.c: Revert.
3873         * dcache.h: Revert.
3874         * dcache.c: Revert.
3875         * darwin-nat.h: Revert.
3876         * darwin-nat.c: Revert.
3877         * darwin-nat-info.c: Revert.
3878         * d-valprint.c: Revert.
3879         * d-namespace.c: Revert.
3880         * d-lang.c: Revert.
3881         * ctf.c: Revert.
3882         * csky-tdep.c: Revert.
3883         * csky-linux-tdep.c: Revert.
3884         * cris-tdep.c: Revert.
3885         * cris-linux-tdep.c: Revert.
3886         * cp-valprint.c: Revert.
3887         * cp-support.c: Revert.
3888         * cp-namespace.c: Revert.
3889         * cp-abi.c: Revert.
3890         * corelow.c: Revert.
3891         * corefile.c: Revert.
3892         * continuations.c: Revert.
3893         * completer.h: Revert.
3894         * completer.c: Revert.
3895         * complaints.c: Revert.
3896         * coffread.c: Revert.
3897         * coff-pe-read.c: Revert.
3898         * cli-out.h: Revert.
3899         * cli-out.c: Revert.
3900         * charset.c: Revert.
3901         * c-varobj.c: Revert.
3902         * c-valprint.c: Revert.
3903         * c-typeprint.c: Revert.
3904         * c-lang.c: Revert.
3905         * buildsym.c: Revert.
3906         * buildsym-legacy.c: Revert.
3907         * build-id.h: Revert.
3908         * build-id.c: Revert.
3909         * btrace.c: Revert.
3910         * bsd-uthread.c: Revert.
3911         * breakpoint.h: Revert.
3912         * breakpoint.c: Revert.
3913         * break-catch-throw.c: Revert.
3914         * break-catch-syscall.c: Revert.
3915         * break-catch-sig.c: Revert.
3916         * blockframe.c: Revert.
3917         * block.c: Revert.
3918         * bfin-tdep.c: Revert.
3919         * bfin-linux-tdep.c: Revert.
3920         * bfd-target.c: Revert.
3921         * bcache.c: Revert.
3922         * ax-general.c: Revert.
3923         * ax-gdb.h: Revert.
3924         * ax-gdb.c: Revert.
3925         * avr-tdep.c: Revert.
3926         * auxv.c: Revert.
3927         * auto-load.c: Revert.
3928         * arm-wince-tdep.c: Revert.
3929         * arm-tdep.c: Revert.
3930         * arm-symbian-tdep.c: Revert.
3931         * arm-pikeos-tdep.c: Revert.
3932         * arm-obsd-tdep.c: Revert.
3933         * arm-nbsd-tdep.c: Revert.
3934         * arm-nbsd-nat.c: Revert.
3935         * arm-linux-tdep.c: Revert.
3936         * arm-linux-nat.c: Revert.
3937         * arm-fbsd-tdep.c: Revert.
3938         * arm-fbsd-nat.c: Revert.
3939         * arm-bsd-tdep.c: Revert.
3940         * arch-utils.c: Revert.
3941         * arc-tdep.c: Revert.
3942         * arc-newlib-tdep.c: Revert.
3943         * annotate.h: Revert.
3944         * annotate.c: Revert.
3945         * amd64-windows-tdep.c: Revert.
3946         * amd64-windows-nat.c: Revert.
3947         * amd64-tdep.c: Revert.
3948         * amd64-sol2-tdep.c: Revert.
3949         * amd64-obsd-tdep.c: Revert.
3950         * amd64-obsd-nat.c: Revert.
3951         * amd64-nbsd-tdep.c: Revert.
3952         * amd64-nbsd-nat.c: Revert.
3953         * amd64-nat.c: Revert.
3954         * amd64-linux-tdep.c: Revert.
3955         * amd64-linux-nat.c: Revert.
3956         * amd64-fbsd-tdep.c: Revert.
3957         * amd64-fbsd-nat.c: Revert.
3958         * amd64-dicos-tdep.c: Revert.
3959         * amd64-darwin-tdep.c: Revert.
3960         * amd64-bsd-nat.c: Revert.
3961         * alpha-tdep.c: Revert.
3962         * alpha-obsd-tdep.c: Revert.
3963         * alpha-nbsd-tdep.c: Revert.
3964         * alpha-mdebug-tdep.c: Revert.
3965         * alpha-linux-tdep.c: Revert.
3966         * alpha-linux-nat.c: Revert.
3967         * alpha-bsd-tdep.c: Revert.
3968         * alpha-bsd-nat.c: Revert.
3969         * aix-thread.c: Revert.
3970         * agent.c: Revert.
3971         * addrmap.c: Revert.
3972         * ada-varobj.c: Revert.
3973         * ada-valprint.c: Revert.
3974         * ada-typeprint.c: Revert.
3975         * ada-tasks.c: Revert.
3976         * ada-lang.c: Revert.
3977         * aarch64-tdep.c: Revert.
3978         * aarch64-ravenscar-thread.c: Revert.
3979         * aarch64-newlib-tdep.c: Revert.
3980         * aarch64-linux-tdep.c: Revert.
3981         * aarch64-linux-nat.c: Revert.
3982         * aarch64-fbsd-tdep.c: Revert.
3983         * aarch64-fbsd-nat.c: Revert.
3984         * aarch32-linux-nat.c: Revert.
3985
3986 2019-04-05  Tom Tromey  <tom@tromey.com>
3987
3988         * ft32-tdep.c: Sort headers.
3989         * frv-tdep.c: Sort headers.
3990         * frv-linux-tdep.c: Sort headers.
3991         * frame.c: Sort headers.
3992         * frame-unwind.c: Sort headers.
3993         * frame-base.c: Sort headers.
3994         * fork-child.c: Sort headers.
3995         * findvar.c: Sort headers.
3996         * findcmd.c: Sort headers.
3997         * filesystem.c: Sort headers.
3998         * filename-seen-cache.h: Sort headers.
3999         * filename-seen-cache.c: Sort headers.
4000         * fbsd-tdep.c: Sort headers.
4001         * fbsd-nat.h: Sort headers.
4002         * fbsd-nat.c: Sort headers.
4003         * f-valprint.c: Sort headers.
4004         * f-typeprint.c: Sort headers.
4005         * f-lang.c: Sort headers.
4006         * extension.h: Sort headers.
4007         * extension.c: Sort headers.
4008         * extension-priv.h: Sort headers.
4009         * expprint.c: Sort headers.
4010         * exec.h: Sort headers.
4011         * exec.c: Sort headers.
4012         * exceptions.c: Sort headers.
4013         * event-top.c: Sort headers.
4014         * event-loop.c: Sort headers.
4015         * eval.c: Sort headers.
4016         * elfread.c: Sort headers.
4017         * dwarf2read.h: Sort headers.
4018         * dwarf2read.c: Sort headers.
4019         * dwarf2loc.c: Sort headers.
4020         * dwarf2expr.h: Sort headers.
4021         * dwarf2expr.c: Sort headers.
4022         * dwarf2-frame.c: Sort headers.
4023         * dwarf2-frame-tailcall.c: Sort headers.
4024         * dwarf-index-write.h: Sort headers.
4025         * dwarf-index-write.c: Sort headers.
4026         * dwarf-index-common.c: Sort headers.
4027         * dwarf-index-cache.h: Sort headers.
4028         * dwarf-index-cache.c: Sort headers.
4029         * dummy-frame.c: Sort headers.
4030         * dtrace-probe.c: Sort headers.
4031         * disasm.h: Sort headers.
4032         * disasm.c: Sort headers.
4033         * disasm-selftests.c: Sort headers.
4034         * dictionary.c: Sort headers.
4035         * dicos-tdep.c: Sort headers.
4036         * demangle.c: Sort headers.
4037         * dcache.h: Sort headers.
4038         * dcache.c: Sort headers.
4039         * darwin-nat.h: Sort headers.
4040         * darwin-nat.c: Sort headers.
4041         * darwin-nat-info.c: Sort headers.
4042         * d-valprint.c: Sort headers.
4043         * d-namespace.c: Sort headers.
4044         * d-lang.c: Sort headers.
4045         * ctf.c: Sort headers.
4046         * csky-tdep.c: Sort headers.
4047         * csky-linux-tdep.c: Sort headers.
4048         * cris-tdep.c: Sort headers.
4049         * cris-linux-tdep.c: Sort headers.
4050         * cp-valprint.c: Sort headers.
4051         * cp-support.c: Sort headers.
4052         * cp-namespace.c: Sort headers.
4053         * cp-abi.c: Sort headers.
4054         * corelow.c: Sort headers.
4055         * corefile.c: Sort headers.
4056         * continuations.c: Sort headers.
4057         * completer.h: Sort headers.
4058         * completer.c: Sort headers.
4059         * complaints.c: Sort headers.
4060         * coffread.c: Sort headers.
4061         * coff-pe-read.c: Sort headers.
4062         * cli-out.h: Sort headers.
4063         * cli-out.c: Sort headers.
4064         * charset.c: Sort headers.
4065         * c-varobj.c: Sort headers.
4066         * c-valprint.c: Sort headers.
4067         * c-typeprint.c: Sort headers.
4068         * c-lang.c: Sort headers.
4069         * buildsym.c: Sort headers.
4070         * buildsym-legacy.c: Sort headers.
4071         * build-id.h: Sort headers.
4072         * build-id.c: Sort headers.
4073         * btrace.c: Sort headers.
4074         * bsd-uthread.c: Sort headers.
4075         * breakpoint.h: Sort headers.
4076         * breakpoint.c: Sort headers.
4077         * break-catch-throw.c: Sort headers.
4078         * break-catch-syscall.c: Sort headers.
4079         * break-catch-sig.c: Sort headers.
4080         * blockframe.c: Sort headers.
4081         * block.c: Sort headers.
4082         * bfin-tdep.c: Sort headers.
4083         * bfin-linux-tdep.c: Sort headers.
4084         * bfd-target.c: Sort headers.
4085         * bcache.c: Sort headers.
4086         * ax-general.c: Sort headers.
4087         * ax-gdb.h: Sort headers.
4088         * ax-gdb.c: Sort headers.
4089         * avr-tdep.c: Sort headers.
4090         * auxv.c: Sort headers.
4091         * auto-load.c: Sort headers.
4092         * arm-wince-tdep.c: Sort headers.
4093         * arm-tdep.c: Sort headers.
4094         * arm-symbian-tdep.c: Sort headers.
4095         * arm-pikeos-tdep.c: Sort headers.
4096         * arm-obsd-tdep.c: Sort headers.
4097         * arm-nbsd-tdep.c: Sort headers.
4098         * arm-nbsd-nat.c: Sort headers.
4099         * arm-linux-tdep.c: Sort headers.
4100         * arm-linux-nat.c: Sort headers.
4101         * arm-fbsd-tdep.c: Sort headers.
4102         * arm-fbsd-nat.c: Sort headers.
4103         * arm-bsd-tdep.c: Sort headers.
4104         * arch-utils.c: Sort headers.
4105         * arc-tdep.c: Sort headers.
4106         * arc-newlib-tdep.c: Sort headers.
4107         * annotate.h: Sort headers.
4108         * annotate.c: Sort headers.
4109         * amd64-windows-tdep.c: Sort headers.
4110         * amd64-windows-nat.c: Sort headers.
4111         * amd64-tdep.c: Sort headers.
4112         * amd64-sol2-tdep.c: Sort headers.
4113         * amd64-obsd-tdep.c: Sort headers.
4114         * amd64-obsd-nat.c: Sort headers.
4115         * amd64-nbsd-tdep.c: Sort headers.
4116         * amd64-nbsd-nat.c: Sort headers.
4117         * amd64-nat.c: Sort headers.
4118         * amd64-linux-tdep.c: Sort headers.
4119         * amd64-linux-nat.c: Sort headers.
4120         * amd64-fbsd-tdep.c: Sort headers.
4121         * amd64-fbsd-nat.c: Sort headers.
4122         * amd64-dicos-tdep.c: Sort headers.
4123         * amd64-darwin-tdep.c: Sort headers.
4124         * amd64-bsd-nat.c: Sort headers.
4125         * alpha-tdep.c: Sort headers.
4126         * alpha-obsd-tdep.c: Sort headers.
4127         * alpha-nbsd-tdep.c: Sort headers.
4128         * alpha-mdebug-tdep.c: Sort headers.
4129         * alpha-linux-tdep.c: Sort headers.
4130         * alpha-linux-nat.c: Sort headers.
4131         * alpha-bsd-tdep.c: Sort headers.
4132         * alpha-bsd-nat.c: Sort headers.
4133         * aix-thread.c: Sort headers.
4134         * agent.c: Sort headers.
4135         * addrmap.c: Sort headers.
4136         * ada-varobj.c: Sort headers.
4137         * ada-valprint.c: Sort headers.
4138         * ada-typeprint.c: Sort headers.
4139         * ada-tasks.c: Sort headers.
4140         * ada-lang.c: Sort headers.
4141         * aarch64-tdep.c: Sort headers.
4142         * aarch64-ravenscar-thread.c: Sort headers.
4143         * aarch64-newlib-tdep.c: Sort headers.
4144         * aarch64-linux-tdep.c: Sort headers.
4145         * aarch64-linux-nat.c: Sort headers.
4146         * aarch64-fbsd-tdep.c: Sort headers.
4147         * aarch64-fbsd-nat.c: Sort headers.
4148         * aarch32-linux-nat.c: Sort headers.
4149
4150 2019-04-04  Tom Tromey  <tom@tromey.com>
4151
4152         * varobj.c (varobj_create): Update.
4153         * rust-exp.y (struct rust_parser) <update_innermost_block,
4154         lookup_symbol>: New methods.
4155         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4156         Rename.
4157         (rust_parser::rust_lookup_type)
4158         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4159         * printcmd.c (display_command, do_one_display): Update.
4160         * parser-defs.h (struct parser_state) <parser_state>: Add
4161         "tracker" parameter.
4162         (block_tracker): New member.
4163         (class innermost_block_tracker) <innermost_block_tracker>: Add
4164         "types" parameter.
4165         <reset>: Remove method.
4166         (innermost_block): Don't declare.
4167         (null_post_parser): Update.
4168         * parse.c (innermost_block): Remove global.
4169         (write_dollar_variable): Update.
4170         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4171         Remove "tracker_types" parameter.
4172         (parse_expression): Add "tracker" parameter.
4173         (parse_expression_for_completion): Update.
4174         (null_post_parser): Add "tracker" parameter.
4175         * p-exp.y: Update rules.
4176         * m2-exp.y: Update rules.
4177         * language.h (struct language_defn) <la_post_parser>: Add
4178         "tracker" parameter.
4179         * go-exp.y: Update rules.
4180         * f-exp.y: Update rules.
4181         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4182         parameter.
4183         * d-exp.y: Update rules.
4184         * c-exp.y: Update rules.
4185         * breakpoint.c (set_breakpoint_condition): Create an
4186         innermost_block_tracker.
4187         (watch_command_1): Likewise.
4188         * ada-lang.c (resolve): Add "tracker" parameter.
4189         (resolve_subexp): Likewise.
4190         * ada-exp.y (write_var_from_sym): Update.
4191
4192 2019-04-04  Tom Tromey  <tom@tromey.com>
4193
4194         * type-stack.h: New file.
4195         * type-stack.c: New file.
4196         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4197         type-stack.h.
4198         (insert_into_type_stack, insert_type, push_type, push_type_int)
4199         (insert_type_address_space, pop_type, pop_type_int)
4200         (pop_typelist, pop_type_stack, append_type_stack)
4201         (push_type_stack, get_type_stack, push_typelist)
4202         (follow_type_instance_flags, follow_types): Don't declare.
4203         * parse.c (type_stack): Remove global.
4204         (parse_exp_in_context): Update.
4205         (insert_into_type_stack, insert_type, push_type, push_type_int)
4206         (insert_type_address_space, pop_type, pop_type_int)
4207         (pop_typelist, pop_type_stack, append_type_stack)
4208         (push_type_stack, get_type_stack, push_typelist)
4209         (follow_type_instance_flags, follow_types): Remove (moved to
4210         type-stack.c).
4211         * f-exp.y (type_stack): New global.
4212         Update rules.
4213         (push_kind_type, f_parse): Update.
4214         * d-exp.y (type_stack): New global.
4215         Update rules.
4216         (d_parse): Update.
4217         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4218         Update rules.
4219         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4220         (HFILES_NO_SRCDIR): Add type-stack.h.
4221
4222 2019-04-04  Tom Tromey  <tom@tromey.com>
4223
4224         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4225         (rust_parser::convert_ast_to_expression, rust_parse)
4226         (rust_lex_test_completion, rust_lex_tests): Update.
4227         * parser-defs.h (struct expr_completion_state): New.
4228         (struct parser_state) <parser_state>: Add completion parameter.
4229         <mark_struct_expression, mark_completion_tag>: New methods.
4230         <parse_completion, m_completion_state>: New members.
4231         (prefixify_expression, null_post_parser): Update.
4232         (mark_struct_expression, mark_completion_tag): Don't declare.
4233         * parse.c (parse_completion, expout_last_struct)
4234         (expout_tag_completion_type, expout_completion_name): Remove
4235         globals.
4236         (parser_state::mark_struct_expression)
4237         (parser_state::mark_completion_tag): Now methods.
4238         (prefixify_expression): Add last_struct parameter.
4239         (prefixify_subexp): Likewise.
4240         (parse_exp_1): Update.
4241         (parse_exp_in_context): Add cstate parameter.  Update.
4242         (parse_expression_for_completion): Create an
4243         expr_completion_state.
4244         (null_post_parser): Add "completion" parameter.
4245         * p-exp.y: Update rules.
4246         (yylex): Update.
4247         * language.h (struct language_defn) <la_post_parser>: Add
4248         "completing" parameter.
4249         * go-exp.y: Update rules.
4250         (lex_one_token): Update.
4251         * expression.h (parse_completion): Don't declare.
4252         * d-exp.y: Update rules.
4253         (lex_one_token): Update rules.
4254         * c-exp.y: Update rules.
4255         (lex_one_token): Update.
4256         * ada-lang.c (resolve): Add "parse_completion" parameter.
4257         (resolve_subexp): Likewise.
4258         (ada_resolve_function): Likewise.
4259
4260 2019-04-04  Tom Tromey  <tom@tromey.com>
4261
4262         * parser-defs.h (struct parser_state) <start_arglist,
4263         end_arglist>: New methods.
4264         <arglist_len, m_funcall_chain>: New members.
4265         (arglist_len, start_arglist, end_arglist): Don't declare.
4266         * parse.c (arglist_len, funcall_chain): Remove global.
4267         (start_arglist, end_arglist): Remove functions.
4268         (parse_exp_in_context): Update.
4269         * p-exp.y: Update rules.
4270         * m2-exp.y: Update rules.
4271         * go-exp.y: Update rules.
4272         * f-exp.y: Update rules.
4273         * d-exp.y: Update rules.
4274         * c-exp.y: Update rules.
4275
4276 2019-04-04  Tom Tromey  <tom@tromey.com>
4277
4278         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4279         lex_operator, push_back>: New methods.
4280         Update all rules.
4281         (rust_parser::lex_hex, lex_escape): Rename and update.
4282         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4283         (rust_parser::lex_operator): Rename and update.
4284         (rust_parser::lex_number, rustyylex, rustyyerror)
4285         (rust_lex_test_init, rust_lex_test_sequence)
4286         (rust_lex_test_push_back, rust_lex_tests): Update.
4287         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4288         parameter.
4289         <lexptr, prev_lexptr>: New members.
4290         (lexptr, prev_lexptr): Don't declare.
4291         * parse.c (lexptr, prev_lexptr): Remove globals.
4292         (parse_exp_in_context): Update.
4293         * p-exp.y (yylex, yyerror): Update.
4294         * m2-exp.y (parse_number, yylex, yyerror): Update.
4295         * go-exp.y (lex_one_token, yyerror): Update.
4296         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4297         * d-exp.y (lex_one_token, yyerror): Update.
4298         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4299         (lex_one_token, yyerror): Update.
4300         * ada-lex.l (YY_INPUT): Update.
4301         (rewind_to_char): Update.
4302         * ada-exp.y (yyerror): Update.
4303
4304 2019-04-04  Tom Tromey  <tom@tromey.com>
4305
4306         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4307         * parser-defs.h (struct parser_state) <parser_state>: Add new
4308         parameter.
4309         <comma_terminates>: New member.
4310         (comma_terminates): Don't declare global.
4311         * parse.c (comma_terminates): Remove global.
4312         (parse_exp_in_context): Update.
4313         * p-exp.y (yylex): Update.
4314         * m2-exp.y (yylex): Update.
4315         * go-exp.y (lex_one_token): Update.
4316         * f-exp.y (yylex): Update.
4317         * d-exp.y (lex_one_token): Update.
4318         * c-exp.y (lex_one_token): Update.
4319         * ada-lex.l: Update.
4320
4321 2019-04-04  Tom Tromey  <tom@tromey.com>
4322
4323         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4324         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4325         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4326         * parser-defs.h (paren_depth): Don't declare.
4327         * parse.c (paren_depth): Remove global.
4328         (parse_exp_in_context): Update.
4329         * p-exp.y (paren_depth): New global.
4330         (pascal_parse): Initialize it.
4331         * m2-exp.y (paren_depth): New global.
4332         (m2_parse): Initialize it.
4333         * go-exp.y (paren_depth): New global.
4334         (go_parse): Initialize it.
4335         * f-exp.y (paren_depth): New global.
4336         (f_parse): Initialize it.
4337         * d-exp.y (paren_depth): New global.
4338         (d_parse): Initialize it.
4339         * c-exp.y (paren_depth): New global.
4340         (c_parse): Initialize it.
4341         * ada-lex.l (paren_depth): New global.
4342         (lexer_init): Initialize it.
4343
4344 2019-04-04  Tom Tromey  <tom@tromey.com>
4345
4346         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4347         (rust_parser::convert_ast_to_type)
4348         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4349         * parser-defs.h (struct parser_state) <parser_state>: Add
4350         parameters.  Initialize new members.
4351         <expression_context_block, expression_context_pc>: New members.
4352         * parse.c (expression_context_block, expression_context_pc):
4353         Remove globals.
4354         (parse_exp_in_context): Update.
4355         * p-exp.y: Update all rules.
4356         (yylex): Update.
4357         * m2-exp.y: Update all rules.
4358         (yylex): Update.
4359         * go-exp.y (yylex): Update.
4360         * f-exp.y (yylex): Update.
4361         * d-exp.y: Update all rules.
4362         (yylex): Update.
4363         * c-exp.y: Update all rules.
4364         (lex_one_token, classify_name, yylex, c_parse): Update.
4365         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4366
4367 2019-04-04  Tom Tromey  <tom@tromey.com>
4368
4369         * gdbarch.h, gdbarch.c: Rebuild.
4370         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4371         * stap-probe.h:
4372         (struct stap_parse_info): Replace "parser_state" with
4373         "expr_builder".
4374         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4375         (parser_state): New class.
4376         * parse.c (expr_builder): Rename.
4377         (expr_builder::release): Rename.
4378         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4379         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4380         (write_exp_elt_longcst, write_exp_elt_floatcst)
4381         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4382         (write_exp_string_vector, write_exp_bitstring)
4383         (write_exp_msymbol, mark_struct_expression)
4384         (write_dollar_variable)
4385         (insert_type_address_space, increase_expout_size): Replace
4386         "parser_state" with "expr_builder".
4387         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4388         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4389         "parser_state" with "expr_builder".
4390
4391 2019-04-04  Tom Tromey  <tom@tromey.com>
4392
4393         * rust-exp.y: Replace "parse_language" with method call.
4394         * p-exp.y:
4395         (yylex): Replace "parse_language" with method call.
4396         * m2-exp.y:
4397         (yylex): Replace "parse_language" with method call.
4398         * go-exp.y (classify_name): Replace "parse_language" with method
4399         call.
4400         * f-exp.y (yylex): Replace "parse_language" with method call.
4401         * d-exp.y (lex_one_token): Replace "parse_language" with method
4402         call.
4403         * c-exp.y:
4404         (lex_one_token, classify_name, yylex): Replace "parse_language"
4405         with method call.
4406         * ada-exp.y (find_primitive_type, type_char)
4407         (type_system_address): Replace "parse_language" with method call.
4408
4409 2019-04-04  Tom Tromey  <tom@tromey.com>
4410
4411         * rust-exp.y: Replace "parse_gdbarch" with method call.
4412         * parse.c (write_dollar_variable, insert_type_address_space):
4413         Replace "parse_gdbarch" with method call.
4414         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4415         call.
4416         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4417         call.
4418         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4419         "parse_gdbarch" with method call.
4420         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4421         with method call.
4422         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4423         "parse_gdbarch" with method call.
4424         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4425         "parse_gdbarch" with method call.
4426         * c-exp.y (parse_type, parse_number, classify_name): Replace
4427         "parse_gdbarch" with method call.
4428         * ada-lex.l: Replace "parse_gdbarch" with method call.
4429         * ada-exp.y (parse_type, find_primitive_type, type_char)
4430         (type_system_address): Replace "parse_gdbarch" with method call.
4431
4432 2019-04-04  Tom Tromey  <tom@tromey.com>
4433
4434         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4435         * stap-probe.c (stap_parse_argument): Update.
4436         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4437         initial_size parameter.
4438         * rust-exp.y (rust_lex_tests): Update.
4439         * parse.c (parser_state): Update.
4440         (parse_exp_in_context): Update.
4441         * parser-defs.h (struct parser_state) <parser_state>: Remove
4442         "initial_size" parameter.
4443
4444 2019-04-04  Tom Tromey  <tom@tromey.com>
4445
4446         * parser-defs.h (increase_expout_size): Don't declare.
4447         * parse.c (increase_expout_size): Now static.
4448
4449 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4450
4451         * gnu-nat.c (gnu_nat_target::wait): Fix
4452         target_waitstatus_to_string call.
4453
4454 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         * eval.c (evaluate_subexp_standard): Handle internal functions
4457         during Fortran function call handling.
4458
4459 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * NEWS: Mention new internal functions.
4462         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4463         (read_base_type): Use dwarf2_init_complex_target_type.
4464         * value.c (creal_internal_fn): New function.
4465         (cimag_internal_fn): New function.
4466         (_initialize_values): Register new internal functions.
4467
4468 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4469
4470         * infrun.c (stop_all_threads): If debug_infrun, always
4471         trace the wait status after wait_one, using
4472         target_waitstatus_to_string and target_pid_to_str.
4473         (handle_inferior_event): Replace various trace of
4474         wait status kind by a single trace.
4475         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4476         wait status kind image by target_waitstatus_to_string.
4477         * target/waitstatus.c (target_waitstatus_to_string): Fix
4478         obsolete comment.
4479
4480 2019-04-01  Tom Tromey  <tromey@adacore.com>
4481
4482         PR symtab/23331:
4483         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4484
4485 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4486             Pedro Alves  <palves@redhat.com>
4487
4488         * top.c (quit_force): Call 'finalize_values'.
4489         * value.c (finalize_values): New function.
4490         * value.h (finalize_values): Declare.
4491
4492 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4493
4494         * NEWS: Announce $_gdb_major and $_gdb_minor.
4495
4496         * top.c (init_gdb_version_vars): New function.
4497         (gdb_init): Call init_gdb_version_vars.
4498
4499 2019-03-29  Tom Tromey  <tromey@adacore.com>
4500
4501         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4502         help text.  Remove dead code.
4503
4504 2019-03-29  Keith Seitz  <keiths@redhat.com>
4505
4506         From Siddhesh Poyarekar:
4507         * f-lang.h (f77_get_upperbound): Return LONGEST.
4508         (f77_get_lowerbound): Likewise.
4509         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4510         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4511         print them.
4512         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4513         plongest to format print it.
4514         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4515         (f77_get_upperbound): Likewise.
4516         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4517         LOWER_BOUND to LONGEST.
4518         (f77_create_arrayprint_offset_tbl): Likewise.
4519
4520 2019-03-29  Keith Seitz  <keiths@redhat.com>
4521
4522         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4523         %s/pulongest for TYPE_LENGTH instead of %d in format
4524         strings.
4525         * ada-typerint.c (ada_print_type): Likewise.
4526         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4527         * compile/compile-c-support.c (generate_register_struct): Likewise.
4528         * gdbtypes.c (recursive_dump_type): Likewise.
4529         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4530         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4531         instead of %d in format strings.
4532         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4533         to std::min to ULONGEST.
4534         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4535         instead of %d in format strings.
4536         * tracepoint.c (info_scope_command): Likewise.
4537         * typeprint.c (print_offset_data::update)
4538         (print_offset_data::finish): Likewise.
4539         * xtensa-tdep.c (xtensa_store_return_value)
4540         (xtensa_push_dummy_call): Likewise.
4541
4542 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4543
4544         * windows-nat.c (display_selector): Fixed format specifications
4545         for 64-bit Cygwin.
4546
4547 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4548
4549         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4550
4551 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4552
4553         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4554         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4555         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4556         (nios2_linux_init_abi): Install it.
4557
4558 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4559
4560         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4561
4562 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4563
4564         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4565
4566 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4567             Tom Tromey  <tromey@adacore.com>
4568
4569         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4570
4571 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4572
4573         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4574         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4575         method to compute the bounds of range types. Also print "[evaluated]"
4576         if the bounds' values come from a dynamic evaluation.
4577
4578 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4581         whitespace when pretty printing is on.
4582
4583 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4584
4585         * ppc-linux-nat.c: Add include.
4586
4587 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4588
4589         * NEWS: Mention AArch64 Pointer Authentication.
4590
4591 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4592
4593         * arm-linux-nat.c: Add include.
4594
4595 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4596
4597         * source-cache.c (source_cache::get_source_lines): Re-read
4598         fullname after calling open_source_file.
4599
4600 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4601
4602         * NEWS: Mention TLS support for FreeBSD.
4603
4604 2019-03-25  Tom Tromey  <tromey@adacore.com>
4605
4606         * minsyms.c (BUNCH_SIZE): Update comment.
4607         (~minimal_symbol_reader): Remove old comment.
4608         (compact_minimal_symbols): Update comment.
4609         (minimal_symbol_reader::install): Remove old comment.  Update
4610         other comments.
4611
4612 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4613
4614         * s390-linux-nat.c: Add include.
4615
4616 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4617
4618         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4619         Call linux_get_hwcap.
4620         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4621         Likewise.
4622         (aarch64_linux_get_hwcap): Remove function.
4623         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4624         declaration.
4625         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4626         linux_get_hwcap.
4627         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4628         * linux-tdep.c (linux_get_hwcap): Add function.
4629         (linux_get_hwcap2): Likewise.
4630         * linux-tdep.h (linux_get_hwcap): Add declaration.
4631         (linux_get_hwcap2): Likewise.
4632         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4633         (ppc_linux_get_hwcap2): Likewise.
4634         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4635         linux_get_hwcap.
4636         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4637         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4638         (ppc_linux_nat_target::read_description): Likewise.
4639         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4640         * s390-linux-nat.c: Likewise.
4641         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4642
4643 2019-03-24  Tom Tromey  <tom@tromey.com>
4644
4645         * ada-lang.c (standard_lookup): Simplify initialization.
4646         (ada_lookup_symbol_nonlocal): Simplify return.
4647         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4648         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4649         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4650         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4651         initialization.
4652         * solib.c (solib_global_lookup): Simplify.
4653         * symtab.c (null_block_symbol): Remove.
4654         (symbol_cache_lookup): Simplify returns.
4655         (lookup_language_this): Simplify returns.
4656         (lookup_symbol_aux): Simplify return.
4657         (lookup_local_symbol): Simplify returns.
4658         (lookup_global_symbol_from_objfile): Simplify return.
4659         (lookup_symbol_in_objfile_symtabs)
4660         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4661         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4662         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4663         * cp-namespace.c (cp_lookup_bare_symbol)
4664         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4665         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4666         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4667         (cp_lookup_symbol_via_imports): Simplify initialization.
4668         (find_symbol_in_baseclass): Likewise.
4669         * symtab.h (null_block_symbol): Remove.
4670         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4671         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4672         (d_lookup_symbol_module): Likewise.
4673         (find_symbol_in_baseclass): Simplify initialization.
4674
4675 2019-03-24  Tom Tromey  <tom@tromey.com>
4676
4677         * expression.h: Don't include symtab.h.
4678         (struct block): Forward declare.
4679
4680 2019-03-24  Tom Tromey  <tom@tromey.com>
4681
4682         * c-exp.y (typebase): Remove casts.
4683         * gdbtypes.c (lookup_unsigned_typename, )
4684         (lookup_signed_typename): Remove cast.
4685         * eval.c (parse_to_comma_and_eval): Remove cast.
4686         * parse.c (write_dollar_variable): Remove cast.
4687         * block.h (struct block) <superblock>: Now const.
4688         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4689         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4690         (map_block): Make "block" const.
4691         * symfile.h (struct quick_symbol_functions)
4692         <map_matching_symbols>: Constify block argument to "callback".
4693         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4694         const.
4695         (find_pc_sect_compunit_symtab): Make "b" const.
4696         (find_symbol_at_address): Likewise.
4697         (search_symbols): Likewise.
4698         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4699         (dw2_debug_names_lookup_symbol): Likewise.
4700         (dw2_map_matching_symbols): Update.
4701         * p-valprint.c (pascal_val_print): Remove "block".
4702         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4703         (aux_add_nonlocal_symbols): Make "block" const.
4704         (resolve_subexp): Remove cast.
4705         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4706         const.
4707         (iterate_over_file_blocks): Likewise.
4708         * f-exp.y (%union) <bval>: Remove.
4709         * coffread.c (patch_opaque_types): Make "b" const.
4710         * spu-tdep.c (spu_catch_start): Make "block" const.
4711         * c-valprint.c (print_unpacked_pointer): Remove "block".
4712         * symmisc.c (dump_symtab_1): Make "b" const.
4713         (block_depth): Make "block" const.
4714         * d-exp.y (%union) <bval>: Remove.
4715         * cp-support.h (cp_lookup_rtti_type): Update.
4716         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4717         * psymtab.c (psym_lookup_symbol): Make "block" const.
4718         (maintenance_check_psymtabs): Make "b" const.
4719         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4720         (enumerate_locals, enumerate_args): Update.
4721         * python/py-symtab.c (stpy_global_block): Make "block" const.
4722         (stpy_static_block): Likewise.
4723         * inline-frame.c (block_starting_point_at): Make "new_block"
4724         const.
4725         * block.c (find_block_in_blockvector): Make return type const.
4726         (blockvector_for_pc_sect): Make "b" const.
4727         (find_block_in_blockvector): Make "b" const.
4728
4729 2019-03-23  Tom Tromey  <tom@tromey.com>
4730
4731         * varobj.c (varobj_create): Update.
4732         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4733         * printcmd.c (display_command, do_one_display): Don't reset
4734         innermost_block.
4735         * parser-defs.h (enum innermost_block_tracker_type): Move to
4736         expression.h.
4737         (innermost_block): Update comment.
4738         * parse.c (parse_exp_1): Add tracker_types parameter.
4739         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4740         tracker_types parameter.  Reset innermost_block.
4741         (parse_exp_in_context): Remove.
4742         (parse_expression_for_completion): Update.
4743         * objfiles.c (~objfile): Don't reset expression_context_block or
4744         innermost_block.
4745         * expression.h (enum innermost_block_tracker_type): Move from
4746         parser-defs.h.
4747         (parse_exp_1): Add tracker_types parameter.
4748         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4749         reset innermost_block.
4750
4751 2019-03-23  Tom Tromey  <tom@tromey.com>
4752
4753         * objfiles.h: Include bcache.h.
4754
4755 2019-03-23  Tom Tromey  <tom@tromey.com>
4756
4757         * linespec.c (get_current_search_block): Use
4758         scoped_restore_current_language.
4759         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4760
4761 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4762             Jiong Wang  <jiong.wang@arm.com>
4763
4764         * aarch64-linux-tdep.c
4765         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4766         section.
4767         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4768
4769 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4770             Jiong Wang  <jiong.wang@arm.com>
4771
4772         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4773         instructions.
4774         (aarch64_analyze_prologue_test): Add PACIASP test.
4775         (aarch64_prologue_prev_register): Unmask PC value.
4776
4777 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4778             Jiong Wang  <jiong.wang@arm.com>
4779
4780         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4781         (aarch64_dwarf2_prev_register): Unmask PC value.
4782         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4783         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4784         DW_CFA_AARCH64_negate_ra_state.
4785         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4786
4787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4788             Jiong Wang  <jiong.wang@arm.com>
4789
4790         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4791         registers.
4792         (aarch64_pseudo_register_name): Likewise.
4793         (aarch64_pseudo_register_type): Likewise.
4794         (aarch64_pseudo_register_reggroup_p): Likewise.
4795         (aarch64_gdbarch_init): Add pauth registers.
4796         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4797         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4798         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4799         (struct gdbarch_tdep): Add regnum for ra_state.
4800
4801 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4802             Jiong Wang  <jiong.wang@arm.com>
4803
4804         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4805
4806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4807             Jiong Wang  <jiong.wang@arm.com>
4808
4809         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4810         function.
4811         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4812         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4813         (aarch64_gdbarch_init): Add puth registers.
4814         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4815         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4816         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4817
4818 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4819             Jiong Wang  <jiong.wang@arm.com>
4820
4821         * aarch64-linux-nat.c
4822         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4823         * aarch64-linux-tdep.c
4824         (aarch64_linux_core_read_description): Likewise.
4825         (aarch64_linux_get_hwcap): New function.
4826         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4827         (aarch64_linux_get_hwcap): New declaration.
4828
4829 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4830             Jiong Wang  <jiong.wang@arm.com>
4831
4832         * aarch64-linux-nat.c
4833         (aarch64_linux_nat_target::read_description): Add pauth param.
4834         * aarch64-linux-tdep.c
4835         (aarch64_linux_core_read_description): Likewise.
4836         * aarch64-tdep.c (struct target_desc): Add in pauth.
4837         (aarch64_read_description): Add pauth param.
4838         (aarch64_gdbarch_init): Likewise.
4839         * aarch64-tdep.h (aarch64_read_description): Likewise.
4840         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4841         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4842         * features/Makefile: Add new files.
4843         * features/aarch64-pauth.c: New file.
4844         * features/aarch64-pauth.xml: New file.
4845
4846 2019-03-20  Tom Tromey  <tromey@adacore.com>
4847
4848         * infrun.c (handle_inferior_event): Rename from
4849         handle_inferior_event_1.  Create a scoped_value_mark.
4850         (handle_inferior_event): Remove.
4851
4852 2019-03-19  Tom Tromey  <tromey@adacore.com>
4853
4854         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4855         * infrun.h (print_stop_event): Add "displays" parameter.
4856         * infrun.c (print_stop_event): Add "displays" parameter.
4857
4858 2019-03-19  Pedro Alves  <palves@redhat.com>
4859
4860         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4861         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4862         to -1.  Fix TABs vs spaces.
4863         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4864         * tui/tui-out.h (tui_ui_out) Add intro comments.
4865         <m_line, m_start_of_line>: In-class initialize, and add describing
4866         comment.
4867
4868 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4869
4870         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4871         variable names.
4872         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4873
4874 2019-03-18  Pedro Alves  <palves@redhat.com>
4875             Eli Zaretskii <eliz@gnu.org>
4876
4877         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4878         m_line and m_start_of_line.
4879
4880 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4881
4882         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4883         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4884         it returns a newline.  This fixes a regression in TU mode, whereby
4885         the next line is output on the same screen line as the user input.
4886
4887 2019-03-18  Tom Tromey  <tromey@adacore.com>
4888
4889         * minsyms.c (minimal_symbol_reader::install): Remove call to
4890         obstack_blank.
4891
4892 2019-03-18  Pedro Alves  <palves@redhat.com>
4893
4894         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4895         New globals.
4896         (apply_style): New, factored out from ...
4897         (apply_ansi_escape): ... this.  Handle reverse video mode.
4898         (tui_set_reverse_mode): New function.
4899         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4900         * tui/tui-winsource.c (tui_show_source_line): Use
4901         tui_set_reverse_mode instead of setting A_STANDOUT.
4902         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4903         New setter methods.
4904
4905 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4906
4907         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4908         Handle tabs.
4909
4910 2019-03-18  Tom Tromey  <tromey@adacore.com>
4911
4912         * ada-lang.c (empty_array): Add "high" parameter.
4913         (ada_evaluate_subexp): Update.
4914
4915 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4916
4917         * unittests/string_view-selftests.c: Define
4918         _initialize_string_view_selftests unconditionally.
4919
4920 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4921
4922         PR gdb/24350
4923         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4924
4925 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4926
4927         PR gdb/24351
4928         * windows-nat.c (display_selector): Fix format specifiers.
4929
4930 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4931
4932         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4933         tui_refill_source_window instead of tui_refresh_win, to update the
4934         current execution line.  This fixes redisplay of the current line
4935         when stepping through the code with "next" or "step".
4936
4937 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4938
4939         * source-cache.c (source_cache::get_source_lines): Call
4940         find_source_lines to initialize s->nlines.  This fixes vertical
4941         scrolling of TUI source window when the DOWN arrow is pressed.
4942
4943 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4944
4945         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4946         linux-thread-db.c (_initialize_thread_db): Likewise.
4947
4948 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4949
4950         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4951         wclrtoeol in tui_show_source_line".  This reverts changes made in
4952         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4953
4954 2019-03-15  Tom Tromey  <tom@tromey.com>
4955
4956         * symtab.h (struct minimal_symbol): Derive from
4957         general_symbol_info.
4958         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4959         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4960         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4961         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4962         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4963         (MSYMBOL_SEARCH_NAME): Update.
4964         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4965         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4966         * minsyms.c (minimal_symbol_reader::record_full): Update.
4967
4968 2019-03-15  Tom Tromey  <tom@tromey.com>
4969
4970         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4971
4972 2019-03-15  Tom Tromey  <tom@tromey.com>
4973
4974         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4975         unique_xmalloc_ptr.
4976         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4977         Update.
4978         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4979         (build_minimal_symbol_hash_tables)
4980         (minimal_symbol_reader::install): Update.
4981
4982 2019-03-15  Tom Tromey  <tom@tromey.com>
4983
4984         * symtab.c (create_demangled_names_hash): Update.
4985         (symbol_set_names): Update.
4986         * objfiles.h (struct objfile_per_bfd_storage)
4987         <demangled_names_hash>: Now an htab_up.
4988         * objfiles.c (objfile_per_bfd_storage): Simplify.
4989
4990 2019-03-15  Tom Tromey  <tom@tromey.com>
4991
4992         * objfiles.h (struct objfile_per_bfd_storage): Declare
4993         destructor.
4994         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4995         New.
4996         (get_objfile_bfd_data): Use new.  Don't initialize
4997         language_of_main.
4998         (free_objfile_per_bfd_storage): Remove.
4999         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5000
5001 2019-03-15  Tom Tromey  <tom@tromey.com>
5002
5003         * symfile.c (reread_symbols): Update.
5004         * objfiles.c (objfile::objfile): Update.
5005         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5006         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5007         comment.
5008         (minimal_symbol_reader::install): Update.
5009         (terminate_minimal_symbol_table): Remove.
5010         * jit.c (jit_object_close_impl): Update.
5011
5012 2019-03-15  Tom Tromey  <tom@tromey.com>
5013
5014         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5015         initializations.
5016
5017 2019-03-15  Tom Tromey  <tom@tromey.com>
5018
5019         * objfiles.h (struct objfile_per_bfd_storage)
5020         <demangled_hash_languages>: Now a bitset.
5021         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5022         (lookup_minimal_symbol): Update.
5023
5024 2019-03-15  Tom Tromey  <tom@tromey.com>
5025
5026         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5027         Don't return the symbol.
5028         * coffread.c (record_minimal_symbol): Use record_full.
5029
5030 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5031
5032         The MS-Windows port of ncurses fails to switch to a color pair if
5033         one or both of the colors are the implicit default colors.  This
5034         change records the default colors when TUI is initialized, and
5035         then specifies them explicitly when a color pair uses the default
5036         colors.  This allows color styling in TUI mode on MS-Windows.
5037
5038         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5039         ncurses_norm_attr.
5040         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5041         colors in ncurses_norm_attr.
5042         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5043         "none", replace it with the default color recorded in
5044         ncurses_norm_attr.
5045
5046 2019-03-14  Tom Tromey  <tromey@adacore.com>
5047
5048         * source-cache.h (class source_cache) <get_source_lines>: Return
5049         std::string.
5050         * source-cache.c (source_cache::extract_lines): Handle case where
5051         first_pos==npos.  Return std::string.
5052         (source_cache::get_source_lines): Update.
5053
5054 2019-03-14  Tom Tromey  <tromey@adacore.com>
5055
5056         * NEWS: Add item for "style sources" commands.
5057         * source-cache.c (source_cache::get_source_lines): Check
5058         source_styling.
5059         * cli/cli-style.c (source_styling): New global.
5060         (_initialize_cli_style): Add "style sources" commands.
5061         (show_style_sources): New function.
5062         * cli/cli-style.h (source_styling): Declare.
5063
5064 2019-03-14  Pedro Alves  <palves@redhat.com>
5065             Tom Tromey  <tromey@adacore.com>
5066
5067         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5068         * tui/tui-winsource.c (tui_refill_source_window): New function,
5069         from...
5070         (tui_horizontal_source_scroll): ... here.  Move some logic.
5071         * cli/cli-style.c (set_style_enabled): Notify new observable.
5072         * tui/tui-hooks.c (tui_redisplay_source): New function.
5073         (tui_attach_detach_observers): Attach or detach
5074         tui_redisplay_source.
5075         * observable.h (source_styling_changed): New observable.
5076         * observable.c: Define source_styling_changed observable.
5077
5078 2019-03-13  Tom Tromey  <tromey@adacore.com>
5079
5080         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5081         (i386_gnu_nat_target::store_registers): Update.
5082         * target-debug.h (target_debug_print_std_string): New macro.
5083         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5084         * windows-tdep.c (display_one_tib): Update.
5085         * tui/tui-stack.c (tui_make_status_line): Update.
5086         * top.c (print_inferior_quit_action): Update.
5087         * thread.c (thr_try_catch_cmd): Update.
5088         (add_thread_with_info): Update.
5089         (thread_target_id_str): Update.
5090         (thr_try_catch_cmd): Update.
5091         (thread_command): Update.
5092         (thread_find_command): Update.
5093         * record-btrace.c (record_btrace_target::info_record)
5094         (record_btrace_resume_thread, record_btrace_target::resume)
5095         (record_btrace_cancel_resume, record_btrace_step_thread)
5096         (record_btrace_target::wait, record_btrace_target::wait)
5097         (record_btrace_target::wait, record_btrace_target::stop): Update.
5098         * progspace.c (print_program_space): Update.
5099         * process-stratum-target.c
5100         (process_stratum_target::thread_address_space): Update.
5101         * linux-fork.c (linux_fork_mourn_inferior)
5102         (detach_checkpoint_command, info_checkpoints_command)
5103         (linux_fork_context): Update.
5104         (linux_fork_detach): Update.
5105         (class scoped_switch_fork_info): Update.
5106         (delete_checkpoint_command): Update.
5107         * infrun.c (follow_fork_inferior): Update.
5108         (follow_fork_inferior): Update.
5109         (proceed_after_vfork_done): Update.
5110         (handle_vfork_child_exec_or_exit): Update.
5111         (follow_exec): Update.
5112         (displaced_step_prepare_throw): Update.
5113         (displaced_step_restore): Update.
5114         (start_step_over): Update.
5115         (resume_1): Update.
5116         (clear_proceed_status_thread): Update.
5117         (proceed): Update.
5118         (print_target_wait_results): Update.
5119         (do_target_wait): Update.
5120         (context_switch): Update.
5121         (stop_all_threads): Update.
5122         (restart_threads): Update.
5123         (finish_step_over): Update.
5124         (handle_signal_stop): Update.
5125         (switch_back_to_stepped_thread): Update.
5126         (keep_going_pass_signal): Update.
5127         (print_exited_reason): Update.
5128         (normal_stop): Update.
5129         * inferior.c (inferior_pid_to_str): Change return type.
5130         (print_selected_inferior): Update.
5131         (add_inferior): Update.
5132         (detach_inferior): Update.
5133         * dummy-frame.c (fprint_dummy_frames): Update.
5134         * dcache.c (dcache_info_1): Update.
5135         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5136         (btrace_fetch, btrace_clear): Update.
5137         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5138         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5139         type.
5140         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5141         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5142         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5143         * gdbarch.c, gdbarch.h: Rebuild.
5144         * gdbarch.sh (core_pid_to_str): Change return type.
5145         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5146         return type.
5147         (windows_nat_target::pid_to_str): Change return type.
5148         (windows_delete_thread): Update.
5149         (windows_nat_target::attach): Update.
5150         (windows_nat_target::files_info): Update.
5151         * target-delegates.c: Rebuild.
5152         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5153         return type.
5154         (sol_thread_target::pid_to_str): Change return type.
5155         * remote.c (class remote_target) <pid_to_str>: Change return
5156         type.
5157         (remote_target::pid_to_str): Change return type.
5158         (extended_remote_target::attach, remote_target::remote_stop_ns)
5159         (remote_target::remote_notif_remove_queued_reply)
5160         (remote_target::push_stop_reply, remote_target::disable_btrace):
5161         Update.
5162         (extended_remote_target::attach): Update.
5163         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5164         type.
5165         (gdbsim_target::pid_to_str): Change return type.
5166         * ravenscar-thread.c (struct ravenscar_thread_target)
5167         <pid_to_str>: Change return type.
5168         (ravenscar_thread_target::pid_to_str): Change return type.
5169         * procfs.c (class procfs_target) <pid_to_str>: Change return
5170         type.
5171         (procfs_target::pid_to_str): Change return type.
5172         (procfs_target::attach): Update.
5173         (procfs_target::detach): Update.
5174         (procfs_target::fetch_registers): Update.
5175         (procfs_target::store_registers): Update.
5176         (procfs_target::wait): Update.
5177         (procfs_target::files_info): Update.
5178         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5179         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5180         return type.
5181         (nto_procfs_target::pid_to_str): Change return type.
5182         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5183         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5184         return type.
5185         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5186         (exit_lwp): Update.
5187         (attach_proc_task_lwp_callback, get_detach_signal)
5188         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5189         (linux_nat_target::resume, wait_lwp, stop_callback)
5190         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5191         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5192         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5193         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5194         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5195         type.
5196         (inf_ptrace_target::attach): Update.
5197         (inf_ptrace_target::files_info): Update.
5198         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5199         type.
5200         (go32_nat_target::pid_to_str): Change return type.
5201         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5202         (gnu_nat_target::wait): Update.
5203         (gnu_nat_target::wait): Update.
5204         (gnu_nat_target::resume): Update.
5205         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5206         (fbsd_nat_target::wait): Update.
5207         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5208         type.
5209         (darwin_nat_target::attach): Update.
5210         * corelow.c (class core_target) <pid_to_str>: Change return type.
5211         (core_target::pid_to_str): Change return type.
5212         * target.c (normal_pid_to_str): Change return type.
5213         (default_pid_to_str): Likewise.
5214         (target_pid_to_str): Change return type.
5215         (target_translate_tls_address): Update.
5216         (target_announce_detach): Update.
5217         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5218         return type.
5219         (bsd_uthread_target::pid_to_str): Change return type.
5220         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5221         type.
5222         (bsd_kvm_target::pid_to_str): Change return type.
5223         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5224         return type.
5225         (aix_thread_target::pid_to_str): Change return type.
5226         * target.h (struct target_ops) <pid_to_str>: Change return type.
5227         (target_pid_to_str, normal_pid_to_str): Likewise.
5228         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5229         type.
5230         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5231         type.
5232         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5233         return type.
5234         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5235         type.
5236         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5237         type.
5238         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5239         return type.
5240
5241 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5242
5243         * NEWS: Mention that the new default MI version is 3.  Mention
5244         changes to the output of commands and events that deal with
5245         multi-location breakpoints.
5246         * breakpoint.c: Include "mi/mi-out.h".
5247         (print_one_breakpoint): Change output syntax if using MI version
5248         >= 3.
5249         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5250         New.
5251         (mi_multi_location_breakpoint_output_fixed): New.
5252         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5253         (mi_cmd_fix_multi_location_breakpoint_output): New.
5254         (mi_multi_location_breakpoint_output_fixed): New.
5255         * mi/mi-cmds.c (mi_cmds): Register command
5256         -fix-multi-location-breakpoint-output.
5257         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5258         interpreter "mi".
5259
5260 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5261
5262         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5263         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5264         instantiate mi_ui_out based on interpreter name.
5265         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5266         * mi/mi-main.c (mi_load_progress): Likewise.
5267
5268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5269
5270         * NEWS: Combine separate "New targets" sections for 8.3.
5271
5272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5273
5274         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5275         (ppcfbsd_init_abi): Install gdbarch
5276         "fetch_tls_load_module_address" and "get_thread_local_address"
5277         methods.
5278
5279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5280
5281         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5282         (riscv_fbsd_init_abi): Install gdbarch
5283         "fetch_tls_load_module_address" and "get_thread_local_address"
5284         methods.
5285
5286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5287
5288         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5289         (i386fbsd_init_abi): Install gdbarch
5290         "fetch_tls_load_module_address" and "get_thread_local_address"
5291         methods.
5292
5293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5294
5295         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5296         (amd64fbsd_init_abi): Install gdbarch
5297         "fetch_tls_load_module_address" and "get_thread_local_address"
5298         methods.
5299
5300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5301
5302         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5303         (struct fbsd_pspace_data): New type.
5304         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5305         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5306         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5307         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5308         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5309
5310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5311
5312         * gdbtypes.c (lookup_struct_elt): New function.
5313         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5314         * gdbtypes.h (struct struct_elt): New type.
5315         (lookup_struct_elt): New prototype.
5316
5317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5318
5319         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5320         remove disabled code block.
5321
5322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5323
5324         * gdbarch.sh (get_thread_local_address): New method.
5325         * gdbarch.h, gdbarch.c: Regenerate.
5326         * target.c (target_translate_tls_address): Use
5327         gdbarch_get_thread_local_address if present instead of
5328         target::get_thread_local_address.
5329
5330 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5331
5332         * target.h (target::get_thread_local_address): Update comment.
5333
5334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5335
5336         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5337         objfile->separate_debug_objfile_backlink if not NULL.
5338
5339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5340
5341         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5342         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5343         (amd64bsd_store_inferior_registers): Likewise.
5344         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5345         Enable segment base registers.
5346         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5347         PT_GETFSBASE and PT_GETGSBASE.
5348         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5349         PT_SETGSBASE.
5350         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5351         segment base registers.
5352         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5353
5354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5355
5356         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5357         Update calls to i386_target_description to add 'segments'
5358         parameter.
5359         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5360         add segment base registers.
5361         * arch/i386.c (i386_create_target_description): Add 'segments'
5362         parameter to enable segment base registers.
5363         * arch/i386.h (i386_create_target_description): Likewise.
5364         * features/i386/32bit-segments.xml: New file.
5365         * features/i386/32bit-segments.c: Generate.
5366         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5367         call to i386_target_description to add 'segments' parameter.
5368         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5369         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5370         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5371         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5372         if feature is present.
5373         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5374         Add 'segments' parameter to call to i386_target_description.
5375         (i386_target_description): Add 'segments' parameter to enable
5376         segment base registers.
5377         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5378         to call to i386_target_description.
5379         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5380         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5381         Define I386_NUM_REGS.
5382         (i386_target_description): Add 'segments' parameter to enable
5383         segment base registers.
5384
5385 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5386
5387         PR/24325
5388         * source-cache.c: #undef open and close, to avoid unresolved
5389         externals during linking.
5390
5391 2019-03-12  Tom Tromey  <tromey@adacore.com>
5392
5393         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5394         const.  Add initializers.
5395         (_initialize_remote): Don't initialize ptid globals.
5396
5397 2019-03-12  Pedro Alves  <palves@redhat.com>
5398
5399         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5400
5401 2019-03-12  Pedro Alves  <palves@redhat.com>
5402
5403         * cp-name-parser.y (main): Remove unused 'len' variable.
5404
5405 2019-03-12  Tom Tromey  <tromey@adacore.com>
5406
5407         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5408         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5409
5410 2019-03-12  Tom Tromey  <tromey@adacore.com>
5411
5412         * linux-nat.c (iterate_over_lwps): Update.
5413         (stop_callback): Remove parameter.
5414         (stop_wait_callback, detach_callback, resume_set_callback)
5415         (select_singlestep_lwp_callback, set_ignore_sigint)
5416         (status_callback, resumed_callback, resume_clear_callback)
5417         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5418         data parameter.
5419         (linux_nat_target::detach, linux_nat_target::resume)
5420         (linux_stop_and_wait_all_lwps, select_event_lwp)
5421         (linux_nat_filter_event, linux_nat_wait_1)
5422         (linux_nat_target::kill, linux_nat_target::stop)
5423         (linux_nat_target::stop): Update.
5424         (linux_nat_resume_callback): Change type.
5425         (resume_stopped_resumed_lwps, count_events_callback)
5426         (select_event_lwp_callback): Likewise.
5427         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5428         * arm-linux-nat.c (struct update_registers_data): Remove.
5429         (update_registers_callback): Change type.
5430         (arm_linux_insert_hw_breakpoint1): Update.
5431         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5432         parameter.
5433         (x86_linux_dr_set_addr): Update.
5434         (x86_linux_dr_set_control): Update.
5435         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5436         (iterate_over_lwps): Use gdb::function_view.
5437         * nat/aarch64-linux-hw-point.c (struct
5438         aarch64_dr_update_callback_param): Remove.
5439         (debug_reg_change_callback): Change type.
5440         (aarch64_notify_debug_reg_change): Update.
5441         * s390-linux-nat.c (s390_refresh_per_info): Update.
5442
5443 2019-03-11  Tom Tromey  <tromey@adacore.com>
5444
5445         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5446         redundant assignment to "this_cu".
5447
5448 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5449
5450         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5451
5452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5453
5454         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5455         from...
5456         (rank_one_type): ... this.
5457
5458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5459
5460         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5461         from...
5462         (rank_one_type): ... this.
5463
5464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5465
5466         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5467         from...
5468         (rank_one_type): ... this.
5469
5470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5471
5472         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5473         from...
5474         (rank_one_type): ... this.
5475
5476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5477
5478         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5479         from...
5480         (rank_one_type): ... this.
5481
5482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5483
5484         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5485         from...
5486         (rank_one_type): ... this.
5487
5488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5489
5490         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5491         from...
5492         (rank_one_type): ... this.
5493
5494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5495
5496         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5497         from...
5498         (rank_one_type): ... this.
5499
5500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5501
5502         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5503         from...
5504         (rank_one_type): ... this.
5505
5506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5507
5508         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5509         from...
5510         (rank_one_type): ... this.
5511
5512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5513
5514         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5515         from...
5516         (rank_one_type): ... this.
5517
5518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5519
5520         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5521         from...
5522         (rank_one_type): ... this.
5523
5524 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5525
5526         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5527         inferior-events' shows the example events.
5528
5529 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5530
5531         Support styling on native MS-Windows console
5532
5533         PR/24315
5534         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5535         on MS-Windows if $TERM is not defined.
5536
5537         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5538
5539         * posix-hdep.c (gdb_console_fputs):
5540         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5541         functions.
5542         * ui-file.h (gdb_console_fputs): Add prototype.
5543
5544         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5545         back to fputs only if the former returns zero.
5546
5547 2019-03-07  Tom Tromey  <tom@tromey.com>
5548
5549         * symmisc.c (print_symbol_bcache_statistics): Update.
5550         (print_objfile_statistics): Update.
5551         * symfile.c (allocate_symtab): Update.
5552         * stabsread.c: Don't include bcache.h.
5553         * psymtab.h (struct psymbol_bcache): Don't declare.
5554         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5555         (psymbol_bcache_init, psymbol_bcache_free)
5556         (psymbol_bcache_get_bcache): Don't declare.
5557         * psymtab.c (struct psymbol_bcache): Remove.
5558         (psymtab_storage::psymtab_storage): Update.
5559         (psymtab_storage::~psymtab_storage): Update.
5560         (psymbol_bcache_init, psymbol_bcache_free)
5561         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5562         (add_psymbol_to_bcache): Update.
5563         (allocate_psymtab): Update.
5564         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5565         macro_cache>: No longer pointers.
5566         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5567         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5568         * macrotab.c (macro_bcache): Update.
5569         * macroexp.c: Don't include bcache.h.
5570         * gdbtypes.c (check_types_worklist): Update.
5571         (types_deeply_equal): Remove TRY/CATCH.  Update.
5572         * elfread.c (elf_symtab_read): Update.
5573         * dwarf2read.c: Don't include bcache.h.
5574         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5575         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5576         (print_bcache_statistics, bcache_memory_used): Don't declare.
5577         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5578         methods.  Rename all data members.
5579         * bcache.c (struct bcache): Move to bcache.h.
5580         (bcache::expand_hash_table): Rename from expand_hash_table.
5581         (bcache): Remove.
5582         (bcache::insert): Rename from bcache_full.
5583         (bcache::compare): Rename from bcache_compare.
5584         (bcache_xmalloc): Remove.
5585         (bcache::~bcache): Rename from bcache_xfree.
5586         (bcache::print_statistics): Rename from print_bcache_statistics.
5587         (bcache::memory_used): Rename from bcache_memory_used.
5588
5589 2019-03-07  Pedro Alves  <palves@redhat.com>
5590
5591         * infrun.c (normal_stop): Also check for
5592         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5593
5594 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5595
5596         * f-lang.c (value_from_host_double): Moved to...
5597         * value.c (value_from_host_double): ...here.
5598         * value.h (value_from_host_double): Declare.
5599         * guile/scm-math.c (vlscm_convert_typed_number): Use
5600         value_from_host_double.
5601         (vlscm_convert_number): Likewise.
5602         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5603         * python/py-value.c (convert_value_from_python): Likewise.
5604
5605 2019-03-06  Tom Tromey  <tom@tromey.com>
5606
5607         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5608
5609 2019-03-06  Tom Tromey  <tom@tromey.com>
5610
5611         * utils.h (free_current_contents): Don't declare.
5612         * utils.c (free_current_contents): Remove.
5613
5614 2019-03-06  Tom Tromey  <tom@tromey.com>
5615
5616         * top.c (quit_force): Update.
5617         * main.c (captured_command_loop): Update.
5618         * common/new-op.c (operator new): Update.
5619         * common/common-exceptions.c (struct catcher)
5620         <save_cleanup_chain>: Remove member.
5621         (exceptions_state_mc_init): Update.
5622         (exception_try_scope_entry): Return nullptr.
5623         (exception_try_scope_exit, exception_rethrow)
5624         (throw_exception_sjlj, throw_exception_cxx): Update.
5625         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5626         (all_cleanups, do_cleanups, discard_cleanups)
5627         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5628         (restore_cleanups, restore_final_cleanups): Don't declare.
5629         (do_final_cleanups): Remove parameter.
5630         * common/cleanups.c (cleanup_chain, make_cleanup)
5631         (make_cleanup_dtor, all_cleanups, do_cleanups)
5632         (discard_my_cleanups, discard_cleanups)
5633         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5634         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5635         (null_cleanup): Remove.
5636         (do_final_cleanups): Remove parameter.
5637
5638 2019-03-06  Tom Tromey  <tom@tromey.com>
5639
5640         * remote.c (remote_target::remote_parse_stop_reply): Use
5641         unique_xmalloc_ptr.
5642
5643 2019-03-06  Tom Tromey  <tom@tromey.com>
5644
5645         * stabsread.c (struct stabs_field_info): Rename from field_info.
5646         <list, fnlist>: Add initializers.
5647         <obstack>: New member.
5648         (read_member_functions, read_struct_fields, read_baseclasses):
5649         Allocate on obstack.  Don't use cleanups.
5650         (read_one_struct_field, read_member_functions, read_struct_fields)
5651         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5652         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5653         (read_struct_type): Update.
5654
5655 2019-03-06  Tom Tromey  <tom@tromey.com>
5656
5657         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5658         * common/filestuff.h (make_cleanup_close): Don't declare.
5659         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5660         Remove.
5661
5662 2019-03-06  Tom Tromey  <tom@tromey.com>
5663
5664         * solib-aix.c: Use make_scope_exit.
5665
5666 2019-03-06  Tom Tromey  <tom@tromey.com>
5667
5668         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5669         Use make_scope_exit.
5670
5671 2019-03-06  Tom Tromey  <tom@tromey.com>
5672
5673         * solib-svr4.c (disable_probes_interface): Remove parameter.
5674         (svr4_handle_solib_event): Use make_scope_exit.
5675
5676 2019-03-06  Tom Tromey  <tom@tromey.com>
5677
5678         * remote.c (struct stop_reply_deleter): Remove.
5679         (stop_reply_up): Update.
5680         (struct stop_reply): Derive from notif_event.  Don't typedef.
5681         <regcache>: Now a std::vector.
5682         (stop_reply_xfree): Remove.
5683         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5684         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5685         (remote_target::discard_pending_stop_replies): Use delete.
5686         (remote_target::remote_parse_stop_reply): Update.
5687         (remote_target::process_stop_reply): Update.
5688         * remote-notif.h (struct notif_event): Add virtual destructor.
5689         Remove "dtr" member.
5690         (struct notif_client) <alloc_event>: Return a unique_ptr.
5691         (notif_event_xfree): Don't declare.
5692         (notif_event_up): New typedef.
5693         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5694         (notif_event_xfree, do_notif_event_xfree): Remove.
5695         (remote_notif_state_xfree): Update.
5696
5697 2019-03-06  Tom Tromey  <tom@tromey.com>
5698
5699         * infrun.c (displaced_step_clear_cleanup): Now a
5700         forward_scope_exit type.
5701         (displaced_step_prepare_throw): Update.
5702         (displaced_step_fixup): Update.
5703
5704 2019-03-06  Tom Tromey  <tom@tromey.com>
5705
5706         * inferior.h (class inferior): Update comment.
5707         * gdbthread.h (class thread_info): Update comment.
5708
5709 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5710             Tom Tromey  <tom@tromey.com>
5711
5712         * stabsread.h (struct stab_section_list): Remove.
5713         (coffstab_build_psymtabs): Update.
5714         * dbxread.c (symbuf_sections): Now a std::vector.
5715         (sect_idx): New global.
5716         (fill_symbuf): Update.
5717         (coffstab_build_psymtabs): Change type of stabsects parameter.
5718         Update.
5719         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5720         std::vector.
5721         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5722         (coff_locate_sections): Update.
5723         (coff_symfile_read): Remove cleanups.  Update.
5724         (init_stringtab): Add storage parameter.
5725         (free_stringtab, free_stringtab_cleanup): Remove.
5726         (init_lineno): Add storage parameter.
5727         (free_linetab, free_linetab_cleanup): Remove.
5728
5729 2019-03-06  Pedro Alves  <palves@redhat.com>
5730
5731         * linux-fork.c (fork_info::clobber_regs): Delete.
5732         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5733         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5734         comment.  Adjust.
5735         (scoped_switch_fork_info::scoped_switch_fork_info)
5736         (checkpoint_command, linux_fork_context): Adjust
5737         fork_save_infrun_state calls.
5738
5739 2019-03-06  Pedro Alves  <palves@redhat.com>
5740
5741         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5742         (inf_has_multiple_threads): Return 'bool' and rewrite using
5743         inferior_info::threads().
5744
5745 2019-03-06  Pedro Alves  <palves@redhat.com>
5746
5747         * linux-fork.c: Include <list>.
5748         (fork_list): Now a std::list instance.
5749         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5750         (forks_exist_p, find_last_fork): Adjust.
5751         (new_fork): Delete.
5752         (one_fork_p): New.
5753         (add_fork): Adjust.
5754         (free_fork): Delete, folded into fork_info::~fork_info().
5755         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5756         Adjust.
5757         (init_fork_list): Delete.
5758         (linux_fork_killall, linux_fork_mourn_inferior)
5759         (linux_fork_detach, info_checkpoints_command): Adjust.
5760         (_initialize_linux_fork): No longer call init_fork_list.
5761
5762 2019-03-06  Pedro Alves  <palves@redhat.com>
5763
5764         * linux-fork.c (new_fork): New, split out of ...
5765         (add_fork): ... this.  Return void.  Move "first fork" special
5766         case from here, to ...
5767         (checkpoint_command): ... here.
5768         * linux-linux.h (add_fork): Return void.
5769
5770 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5771
5772         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5773
5774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5775             Chris January  <chris.january@arm.com>
5776             David Lecomber  <david.lecomber@arm.com>
5777
5778         * f-exp.y: New token, UNOP_INTRINSIC.
5779         (exp): New pattern using UNOP_INTRINSIC token.
5780         (f77_keywords): Add 'abs' keyword.
5781         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5782         (value_from_host_double): New function.
5783         (evaluate_subexp_f): Support UNOP_ABS.
5784
5785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5786
5787         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5788         types.
5789
5790 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5791
5792         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5793         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5794         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5795
5796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5797
5798         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5799
5800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5801             Chris January  <chris.january@arm.com>
5802
5803         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5804         * f-exp.y: Define 'KIND' token.
5805         (exp): New pattern for KIND expressions.
5806         (ptype): Handle types with a kind extension.
5807         (direct_abs_decl): Extend to spot kind extensions.
5808         (f77_keywords): Add 'kind' to the list.
5809         (push_kind_type): New function.
5810         (convert_to_kind_type): New function.
5811         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5812         * parse.c (operator_length_standard): Likewise.
5813         * parser-defs.h (enum type_pieces): Add tp_kind.
5814         * std-operator.def: Add UNOP_KIND.
5815
5816 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5817
5818         * f-exp.y (f_parse): Set yydebug.
5819
5820 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5821
5822         * f-lang.c (evaluate_subexp_f): New function.
5823         (exp_descriptor_f): New global.
5824         (f_language_defn): Use exp_descriptor_f instead of
5825         exp_descriptor_standard.
5826
5827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5828
5829         * f-exp.y (struct token): Add comments.
5830         (dot_ops): Remove uppercase versions and the end marker.
5831         (f77_keywords): Likewise.
5832         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5833         entries in the dot_ops array are case insensitive, and use
5834         strncasecmp to compare strings.  Also some whitespace cleanup in
5835         this area.  Similar for the f77_keywords array, except entries in
5836         this list might be case sensitive.
5837
5838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * f-exp.y (struct f77_boolean_val): Add comments.
5841         (boolean_values): Remove uppercase versions, and end marker.
5842         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5843         and use strncasecmp to achieve case insensitivity.  Additionally,
5844         perform whitespace cleanup around this code.
5845
5846 2019-03-06  Tom Tromey  <tromey@adacore.com>
5847
5848         * remote-sim.c (gdbsim_target_open): Use result of
5849         gdb_argv::release.
5850
5851 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5852         Dirk Schubert  <dirk.schubert@arm.com>
5853         Chris January  <chris.january@arm.com>
5854
5855         * eval.c (evaluate_subexp_standard): Call Fortran argument
5856         wrapping logic.
5857         * f-lang.c (struct value): A value which can be passed into a
5858         Fortran function call.
5859         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5860         where appropriate.
5861         (struct type): Value ready for a Fortran function call.
5862         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5863         is needed.
5864         * f-lang.h (fortran_argument_convert): Declaration.
5865         (fortran_preserve_arg_pointer): Declaration.
5866         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5867
5868 2019-03-05  Tom Tromey  <tromey@adacore.com>
5869
5870         * python/py-prettyprint.c (print_string_repr): Remove #if.
5871         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5872
5873 2019-03-05  Tom Tromey  <tromey@adacore.com>
5874
5875         * target.c (the_dummy_target): Move later.  Change type to
5876         "dummy_target".
5877         (initialize_targets): Don't initialize the_dummy_target.
5878
5879 2019-03-05  Tom Tromey  <tromey@adacore.com>
5880
5881         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5882         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5883
5884 2019-03-05  Tom Tromey  <tromey@adacore.com>
5885
5886         * windows-nat.c (windows_nat_target::attach)
5887         (windows_nat_target::detach): Don't call gdb_flush.
5888         * valprint.c (generic_val_print, val_print, val_print_string):
5889         Don't call gdb_flush.
5890         * utils.c (defaulted_query): Don't call gdb_flush.
5891         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5892         * target.c (target_announce_detach): Don't call gdb_flush.
5893         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5894         * remote.c (extended_remote_target::attach): Don't call
5895         gdb_flush.
5896         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5897         * printcmd.c (do_examine): Don't call gdb_flush.
5898         (info_display_command): Don't call gdb_flush.
5899         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5900         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5901         * memattr.c (info_mem_command): Don't call gdb_flush.
5902         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5903         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5904         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5905         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5906         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5907         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5908         (gnu_nat_target::detach): Don't call gdb_flush.
5909         * f-valprint.c (f_val_print): Don't call gdb_flush.
5910         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5911         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5912         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5913         gdb_flush.
5914         * c-valprint.c (c_val_print): Don't call gdb_flush.
5915         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5916
5917 2019-03-05  Tom Tromey  <tromey@adacore.com>
5918
5919         * varobj.c (update_dynamic_varobj_children): Update.
5920         (install_default_visualizer): Use reset, not release.
5921         * value.c (set_internalvar): Update.
5922         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5923         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5924         ATTRIBUTE_UNUSED_RESULT.
5925
5926 2019-03-05  Tom Tromey  <tromey@adacore.com>
5927
5928         * remote.c (class scoped_remote_fd) <release>: Add
5929         ATTRIBUTE_UNUSED_RESULT.
5930
5931 2019-03-05  Tom Tromey  <tromey@adacore.com>
5932
5933         * macroexp.c (struct macro_buffer) <release>: Add
5934         ATTRIBUTE_UNUSED_RESULT.
5935
5936 2019-03-05  Tom Tromey  <tromey@adacore.com>
5937
5938         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5939         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5940         ATTRIBUTE_UNUSED_RESULT.
5941
5942 2019-03-05  Tom Tromey  <tromey@adacore.com>
5943
5944         * common/scoped_fd.h (class scoped_fd) <release>: Add
5945         ATTRIBUTE_UNUSED_RESULT.
5946
5947 2019-03-05  Tom Tromey  <tromey@adacore.com>
5948
5949         * parser-defs.h (struct parser_state) <release>: Add
5950         ATTRIBUTE_UNUSED_RESULT.
5951
5952 2019-03-05  Tom Tromey  <tromey@adacore.com>
5953
5954         * utils.h (class gdb_argv) <release>: Add
5955         ATTRIBUTE_UNUSED_RESULT.
5956         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5957
5958 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5959
5960         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5961         for-loop range, to avoid compiler warnings.
5962
5963         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5964         avoid compiler warnings about unused variables.
5965
5966         * NEWS: Mention end of support for native debugging on MS-Windows
5967         before XP.
5968
5969         PR gdb/24292
5970         * common/netstuff.c:
5971         * gdbserver/gdbreplay.c
5972         * gdbserver/remote-utils.c:
5973         * ser-tcp.c:
5974         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5975         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5976         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5977         'getaddrinfo' and 'freeaddrinfo' were not available before
5978         Windows XP, and mingw.org's MinGW headers by default define
5979         _WIN32_WINNT to 0x500.
5980
5981 2019-03-01  Gary Benson <gbenson@redhat.com>
5982
5983         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5984
5985 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5986             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5987
5988         PR gdb/8527
5989         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5990         set_sigint_trap, clear_sigint_trap.
5991
5992 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5993
5994         * target.c (target_detach): Clear the regcache and the
5995         frame cache.
5996
5997 2019-02-27  Pedro Alves  <palves@redhat.com>
5998
5999         * utils.c (set_screen_size): When we cap the height/width sizes,
6000         tweak the corresponding command variable to show "unlimited":
6001
6002 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6003             Pedro Alves  <palves@redhat.com>
6004
6005         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6006         before calling rl_set_screen_size.
6007
6008 2019-02-27  Tom Tromey  <tromey@adacore.com>
6009
6010         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6011         define.
6012         * python/py-value.c: Remove Python 2.4 workaround.
6013         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6014         workaround.
6015         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6016         Python 2.4 workaround.
6017         * python/python-internal.h: Remove Python 2.4 comment.
6018         (Py_ssize_t): Don't define.
6019         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6020         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6021         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6022         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6023         * python/python.c (do_start_initialization): Remove Python 2.4
6024         workaround.
6025         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6026         (print_children): Remove Python 2.4 workaround.
6027         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6028         workaround.
6029         (CHARBUFFERPROC_NAME): Remove.
6030         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6031         Python 2.4 workaround.
6032
6033 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6034
6035         * NEWS: Note minimum Python version.
6036
6037 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6038
6039         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6040         code from these functions.  Remove corresponding ifdefs.  Use
6041         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6042         Remove gotos and target of gotos.
6043         (infpy_search_memory): Likewise.
6044
6045 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6048         (hppa_gdbarch_init): Don't register deleted functions with
6049         gdbarch.
6050
6051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6052
6053         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6054         (h8300_unwind_sp): Delete.
6055         (h8300_dummy_id): Delete.
6056         (h8300_gdbarch_init): Don't register deleted functions with
6057         gdbarch.
6058
6059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6060
6061         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6062         (ft32_unwind_pc): Delete.
6063         (ft32_unwind_sp): Delete.
6064         (ft32_gdbarch_init): Don't register deleted functions with
6065         gdbarch.
6066
6067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6068
6069         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6070         (frv_unwind_pc): Delete.
6071         (frv_unwind_sp): Delete.
6072         (frv_gdbarch_init): Don't register deleted functions with
6073         gdbarch.
6074
6075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6076
6077         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6078         (riscv_unwind_pc): Delete.
6079         (riscv_unwind_sp): Delete.
6080         (riscv_gdbarch_init): Don't register deleted functions with
6081         gdbarch.
6082
6083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6084
6085         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6086         (csky_unwind_pc): Delete.
6087         (csky_unwind_sp): Delete.
6088         (csky_gdbarch_init): Don't register deleted functions with
6089         gdbarch.
6090
6091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6092
6093         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6094         (cris_unwind_pc): Delete.
6095         (cris_unwind_sp): Delete.
6096         (cris_gdbarch_init): Don't register deleted functions with
6097         gdbarch.
6098
6099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6100
6101         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6102         (bfin_unwind_pc): Delete.
6103         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6104
6105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6108         (arm_unwind_pc): Delete.
6109         (arm_unwind_sp): Delete.
6110         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6111
6112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6115         (arc_unwind_pc): Delete.
6116         (arc_unwind_sp): Delete.
6117         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6118
6119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6120
6121         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6122         (alpha_unwind_pc): Delete.
6123         (alpha_gdbarch_init): Don't register deleted functions with
6124         gdbarch.
6125
6126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6127
6128         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6129         (aarch64_unwind_pc): Delete.
6130         (aarch64_unwind_sp): Delete.
6131         (aarch64_gdbarch_init): Don't register deleted functions with
6132         gdbarch.
6133
6134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6135
6136         * gdbtypes.c (type_align): Don't consider static members when
6137         computing structure alignment.
6138
6139 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6140
6141         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6142         return 0 for other types.
6143         * arch-utils.c (default_type_align): Always return 0.
6144         * gdbarch.h: Regenerate.
6145         * gdbarch.sh (type_align): Extend comment.
6146         * gdbtypes.c (type_align): Add additional comments, always call
6147         gdbarch_type_align before applying the default rules.
6148         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6149         generic code will then apply a suitable default.
6150         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6151         types, return 0 for other types.
6152
6153 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6154
6155         * NEWS: Create a new section for the next release branch.
6156         Rename the section of the current branch, now that it has
6157         been cut.
6158
6159 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6160
6161         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6162         * version.in: Bump version to 8.3.50.DATE-git.
6163
6164 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6165
6166         * aix-thread.c (ptid_cmp): Remove unused variable.
6167         (get_signaled_thread): Likewise.
6168         (store_regs_user_thread): Likewise.
6169         (store_regs_kernel_thread): Likewise.
6170         (fetch_regs_kernel_thread): Remove shadowed variable.
6171
6172 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6173
6174         * features/riscv/32bit-cpu.xml: Add register numbers.
6175         * features/riscv/32bit-fpu.c: Regenerate.
6176         * features/riscv/32bit-fpu.xml: Add register numbers.
6177         * features/riscv/64bit-cpu.xml: Add register numbers.
6178         * features/riscv/64bit-fpu.c: Regenerate.
6179         * features/riscv/64bit-fpu.xml: Add register numbers.
6180
6181 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6182
6183         * NEWS: Mention two argument form of gdb.Value constructor.
6184         * python/py-value.c (convert_buffer_and_type_to_value): New
6185         function.
6186         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6187         Add support for handling an optional second argument.  Call
6188         convert_buffer_and_type_to_value as appropriate.
6189         * python/python-internal.h (Py_buffer_deleter): New struct.
6190         (Py_buffer_up): New typedef.
6191
6192 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6193
6194         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6195         instead of releasing ownership.
6196
6197 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6198
6199         * dwarf2read.c (open_and_init_dwp_file): Call
6200         elf_numsections instead of bfd_count_sections to initialize
6201         dwp_file->num_sections.
6202
6203 2019-02-25  Tom Tromey  <tromey@adacore.com>
6204
6205         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6206
6207 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6208
6209         * gcore.in: Add '--readnever' option when invoking GDB.
6210
6211 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6212
6213         * MAINTAINERS: Update my email address.
6214
6215 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6216
6217         * build-id.c (build_id_to_debug_bfd_1): New function.
6218         (build_id_to_debug_bfd): Look for separate debug file in
6219         sysroot.
6220
6221 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6222
6223         * gdbarch.sh: Update the copyright year range that is placed into
6224         generated files.
6225
6226 2019-02-22  Keith Seitz  <keiths@redhat.com>
6227
6228         PR symtab/23853
6229         * linespec.c (create_sals_line_offset): Search for the default
6230         symtab's filename instead of its fullname.
6231
6232 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6233
6234         * NEWS: Update style defaults.
6235
6236 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6237
6238         * main.c (captured_main_1): Disable styling in batch mode.
6239
6240 2019-02-20  Tom Tromey  <tom@tromey.com>
6241
6242         * symtab.c (symtab_symbol_info): Fix typos.
6243
6244 2019-02-20  Tom Tromey  <tromey@adacore.com>
6245
6246         * findcmd.c (_initialize_mem_search): Use upper case for
6247         metasyntactic variables.
6248
6249 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6250
6251         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6252         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6253
6254 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6255
6256         * top.h (source_file_name): Change to std::string.
6257         * top.c (source_file_name): Likewise.
6258         (command_line_input): Adjust.
6259         * cli/cli-script.c (script_from_file): Adjust.
6260
6261 2019-02-19  Tom Tromey  <tromey@adacore.com>
6262
6263         * ravenscar-thread.c
6264         (ravenscar_thread_target::update_thread_list): Don't call
6265         ada_build_task_list.
6266         * ada-lang.h (ada_build_task_list): Don't declare.
6267         * ada-tasks.c (struct ada_tasks_inferior_data)
6268         <task_list_valid_p>: Now bool.
6269         (read_known_tasks, ada_task_list_changed)
6270         (ada_tasks_invalidate_inferior_data): Update.
6271         (read_known_tasks_array): Return bool.
6272         (read_known_tasks_list): Likewise.
6273         (read_known_tasks): Return void.
6274         (ada_build_task_list): Now static.
6275
6276 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6279         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6280
6281 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6282
6283         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6284         variant for ada_tasks_pspace_data_handle and
6285         ada_tasks_inferior_data_handle.
6286         (ada_tasks_pspace_data_cleanup): New function.
6287         (ada_tasks_inferior_data_cleanup): New function.
6288
6289 2019-02-17  Tom Tromey  <tom@tromey.com>
6290
6291         * macrotab.h (macro_source_fullname): Return a std::string.
6292         * macrotab.c (macro_include, check_for_redefinition)
6293         (macro_undef, macro_lookup_definition, foreach_macro)
6294         (foreach_macro_in_scope): Update.
6295         (macro_source_fullname): Return a std::string.
6296         * macrocmd.c (show_pp_source_pos): Update.
6297
6298 2019-02-17  Tom Tromey  <tom@tromey.com>
6299
6300         * macrocmd.c (show_pp_source_pos): Style the file names.
6301
6302 2019-02-17  Tom Tromey  <tom@tromey.com>
6303
6304         PR tui/24197:
6305         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6306
6307 2019-02-17  Tom Tromey  <tom@tromey.com>
6308
6309         * ada-lang.c (user_select_syms): Use filtered printing.
6310         * utils.c (wrap_style): New global.
6311         (desired_style): Remove.
6312         (emit_style_escape): Add stream parameter.
6313         (set_output_style, reset_terminal_style, prompt_for_continue):
6314         Update.
6315         (flush_wrap_buffer): Only flush gdb_stdout.
6316         (wrap_here): Set wrap_style.
6317         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6318         treat escape sequences as a character.  Change when wrap buffer is
6319         flushed.
6320         (fputs_styled): Do not set the output style when the default is
6321         requested.
6322         * ui-style.h (struct ui_file_style) <is_default>: New method.
6323         * source.c (print_source_lines_base): Emit escape sequences in one
6324         piece.
6325
6326 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6327
6328         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6329         integers and enumeration types.
6330
6331 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6332
6333         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6334         instead of lookup_symbol_in_language
6335         (do_exact_match): New function.
6336         (ada_get_symbol_name_matcher): Return do_exact_match when
6337         doing a verbatim match.
6338
6339 2019-02-15  Tom Tromey  <tromey@adacore.com>
6340
6341         * ravenscar-thread.c (ravenscar_thread_target::resume)
6342         (ravenscar_thread_target::wait): Special case wildcard requests.
6343
6344 2019-02-15  Tom Tromey  <tromey@adacore.com>
6345
6346         * ravenscar-thread.c (base_ptid): Remove.
6347         (struct ravenscar_thread_target) <close>: New method.
6348         <m_base_ptid>: New member.
6349         <update_inferior_ptid, active_task, task_is_currently_active,
6350         runtime_initialized>: Declare methods.
6351         <ravenscar_thread_target>: Add constructor.
6352         (ravenscar_thread_target::task_is_currently_active)
6353         (ravenscar_thread_target::update_inferior_ptid)
6354         (ravenscar_runtime_initialized): Rename.  Now methods.
6355         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6356         (ravenscar_thread_target::update_thread_list): Update.
6357         (ravenscar_thread_target::active_task): Now method.
6358         (ravenscar_thread_target::store_registers)
6359         (ravenscar_thread_target::prepare_to_store)
6360         (ravenscar_thread_target::prepare_to_store)
6361         (ravenscar_thread_target::mourn_inferior): Update.
6362         (ravenscar_inferior_created): Use "new" to create target.
6363         (ravenscar_thread_target::get_ada_task_ptid): Update.
6364         (_initialize_ravenscar): Don't initialize base_ptid.
6365         (ravenscar_ops): Remove global.
6366
6367 2019-02-15  Tom Tromey  <tromey@adacore.com>
6368
6369         * target.h (push_target): Declare new overload.
6370         * target.c (push_target): New overload, taking an rvalue reference.
6371         * remote.c (remote_target::open_1): Use push_target overload.
6372         * corelow.c (core_target_open): Use push_target overload.
6373
6374 2019-02-15  Tom Tromey  <tromey@adacore.com>
6375
6376         * ravenscar-thread.c (is_ravenscar_task)
6377         (ravenscar_task_is_currently_active): Return bool.
6378         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6379         (_initialize_ravenscar): Remove "(void)".
6380         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6381         Return bool.
6382
6383 2019-02-15  Tom Tromey  <tromey@adacore.com>
6384
6385         * ravenscar-thread.c (ravenscar_runtime_initializer)
6386         (has_ravenscar_runtime, get_running_thread_id)
6387         (ravenscar_thread_target::resume): Fix indentation.
6388
6389 2019-02-15  Tom Tromey  <tromey@adacore.com>
6390
6391         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6392         from ravenscar_arch_ops.
6393         (sparc_ravenscar_ops::fetch_registers)
6394         (sparc_ravenscar_ops::store_registers): Now methods.
6395         (sparc_ravenscar_prepare_to_store): Remove.
6396         (sparc_ravenscar_ops): Redefine.
6397         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6398         methods and destructor.  Remove members.
6399         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6400         (ravenscar_thread_target::store_registers)
6401         (ravenscar_thread_target::prepare_to_store): Update.
6402         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6403         Remove.
6404         (struct ppc_ravenscar_powerpc_ops): Derive from
6405         ravenscar_arch_ops.
6406         (ppc_ravenscar_powerpc_ops::fetch_registers)
6407         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6408         (ppc_ravenscar_powerpc_ops): Redefine.
6409         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6410         (ppc_ravenscar_e500_ops::fetch_registers)
6411         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6412         (ppc_ravenscar_e500_ops): Redefine.
6413         * aarch64-ravenscar-thread.c
6414         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6415         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6416         (aarch64_ravenscar_fetch_registers)
6417         (aarch64_ravenscar_store_registers): Now methods.
6418         (aarch64_ravenscar_ops): Redefine.
6419
6420 2019-02-15  Tom Tromey  <tromey@adacore.com>
6421
6422         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6423         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6424         (ravenscar_thread_target::stopped_by_watchpoint)
6425         (ravenscar_thread_target::stopped_data_address)
6426         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6427
6428 2019-02-15  Tom Tromey  <tromey@adacore.com>
6429
6430         * ravenscar-thread.c: Fix some typos.
6431
6432 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6433             Tom Tromey  <tromey@adacore.com>
6434
6435         * ada-lang.c (ada_exception_sal): Change addr_string to a
6436         std::string.
6437         (create_ada_exception_catchpoint): Update.
6438
6439 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6440             Tom Tromey  <tromey@adacore.com>
6441
6442         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6443         (bp_location_ops): Remove.
6444         (base_breakpoint_allocate_location): Update.
6445         (free_bp_location): Update.
6446         * ada-lang.c (class ada_catchpoint_location)
6447         <ada_catchpoint_location>: Remove ops parameter.
6448         (ada_catchpoint_location_dtor): Remove.
6449         (ada_catchpoint_location_ops): Remove.
6450         (allocate_location_exception): Update.
6451         * breakpoint.h (struct bp_location_ops): Remove.
6452         (class bp_location) <bp_location>: Remove bp_location_ops
6453         parameter.
6454         <~bp_location>: Add destructor.
6455         <ops>: Remove.
6456
6457 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6458             Pedro Alves  <palves@redhat.com>
6459
6460         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6461         'PATH_MAX'.
6462
6463 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6464             Samuel Thibault  <samuel.thibault@gnu.org>
6465             Thomas Schwinge  <thomas@codesourcery.com>
6466
6467         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6468         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6469
6470 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6471
6472         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6473         (check_empty): Use "const char *".
6474
6475         * gnu-nat.c (gnu_nat_target::detach): Instead of
6476         'detach_inferior (pid)' call
6477         'detach_inferior (find_inferior_pid (pid))'.
6478
6479         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6480         'nat/fork-inferior.o'.
6481         * gnu-nat.c: #include "nat/fork-inferior.h".
6482
6483         * gnu-nat.c (gnu_nat_target::detach): Instead of
6484         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6485         * gnu-nat.h: #include "inf-child.h".
6486         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6487         'i386_gnu_nat_target::fetch_registers'.
6488         (gnu_store_registers): Rename/move to
6489         'i386_gnu_nat_target::store_registers'.
6490
6491         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6492         * gnu-nat.h (mach_thread_info): New function.
6493         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6494
6495         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6496
6497 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6498
6499         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6500
6501 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6502
6503         * windows-nat.c (windows_add_thread): Add new parameter
6504         "main_thread_p" with default value set to false.  Update
6505         function documentation as well as all callers.
6506         (windows_delete_thread): Likewise.
6507         (fake_create_process): Update call to windows_add_thread.
6508         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6509         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6510         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6511         call to windows_delete_thread.
6512
6513 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6514
6515         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6516
6517 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6518
6519         * symfile.c (find_separate_debug_file): Use canonical path of
6520         sysroot with child_path instead of gdb_sysroot if it is valid.
6521
6522 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6523
6524         * symfile.c (find_separate_debug_file): Use child_path to
6525         determine if an object file is under a sysroot.
6526
6527 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6528
6529         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6530         unittests/child-path-selftests.c.
6531         * common/pathstuff.c (child_path): New function.
6532         * common/pathstuff.h (child_path): New prototype.
6533         * unittests/child-path-selftests.c: New file.
6534
6535 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6536
6537         * symfile.c (find_separate_debug_file): Look for separate debug
6538         files in debug directories under the sysroot.
6539
6540 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6541
6542         * symtab.h (struct minimal_symbol data_p): New const method.
6543         (struct minimal_symbol text_p): Likewise.
6544         * symtab.c (output_source_filename): Use file name style
6545         to print file name.
6546         (print_symbol_info): Likewise.
6547         (print_msymbol_info): Use address style to print addresses.
6548         Use function name style to print executable text symbols.
6549         (expand_symtab_containing_pc): Use data_p.
6550         (find_pc_sect_compunit_symtab): Likewise.
6551
6552 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6553
6554         * breakpoint.c (describe_other_breakpoints): Use address style
6555         to print addresses.
6556         (say_where): Likewise.
6557
6558 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6559
6560         * ada-typeprint.c (print_func_type): Print function name
6561         style to print function name.
6562         * c-typeprint.c (c_print_type_1): Likewise.
6563
6564 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6565
6566         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6567         for execve.
6568
6569 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6570
6571         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6572         type_stack.
6573
6574 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6575
6576         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6577         TYPE_CODE_REF types.
6578
6579 2019-02-08  Jim Wilson  <jimw@sifive.com>
6580
6581         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6582         (riscv_linux_fregset): New.
6583         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6584
6585 2019-02-07  Tom Tromey  <tom@tromey.com>
6586
6587         * thread.c (thread_cancel_execution_command): Update.
6588         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6589         methods.
6590         (struct thread_fsm_ops): Remove.
6591         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6592         (thread_fsm_should_stop, thread_fsm_return_value)
6593         (thread_fsm_set_finished, thread_fsm_finished_p)
6594         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6595         Don't declare.
6596         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6597         * infrun.c (clear_proceed_status_thread)
6598         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6599         (print_stop_event): Update.
6600         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6601         Add constructor.
6602         (step_command_fsm_ops): Remove.
6603         (new_step_command_fsm): Remove.
6604         (step_1): Update.
6605         (step_command_fsm::should_stop): Rename from
6606         step_command_fsm_should_stop.
6607         (step_command_fsm::clean_up): Rename from
6608         step_command_fsm_clean_up.
6609         (step_command_fsm::do_async_reply_reason): Rename from
6610         step_command_fsm_async_reply_reason.
6611         (struct until_next_fsm): Inherit from thread_fsm.  Add
6612         constructor.
6613         (until_next_fsm_ops): Remove.
6614         (new_until_next_fsm): Remove.
6615         (until_next_fsm::should_stop): Rename from
6616         until_next_fsm_should_stop.
6617         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6618         (until_next_fsm::do_async_reply_reason): Rename from
6619         until_next_fsm_async_reply_reason.
6620         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6621         constructor.  Change type of breakpoint.
6622         (finish_command_fsm_ops): Remove.
6623         (new_finish_command_fsm): Remove.
6624         (finish_command_fsm::should_stop): Rename from
6625         finish_command_fsm_should_stop.
6626         (finish_command_fsm::clean_up): Rename from
6627         finish_command_fsm_clean_up.
6628         (finish_command_fsm::return_value): Rename from
6629         finish_command_fsm_return_value.
6630         (finish_command_fsm::do_async_reply_reason): Rename from
6631         finish_command_fsm_async_reply_reason.
6632         (finish_command): Update.
6633         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6634         Add constructor.
6635         (call_thread_fsm_ops): Remove.
6636         (call_thread_fsm::call_thread_fsm): Rename from
6637         new_call_thread_fsm.
6638         (call_thread_fsm::should_stop): Rename from
6639         call_thread_fsm_should_stop.
6640         (call_thread_fsm::should_notify_stop): Rename from
6641         call_thread_fsm_should_notify_stop.
6642         (run_inferior_call, call_function_by_hand_dummy): Update.
6643         * cli/cli-interp.c (should_print_stop_to_console): Update.
6644         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6645         Add constructor.  Change type of location_breakpoint,
6646         caller_breakpoint.
6647         (until_break_fsm_ops): Remove.
6648         (new_until_break_fsm): Remove.
6649         (until_break_fsm::should_stop): Rename from
6650         until_break_fsm_should_stop.
6651         (until_break_fsm::clean_up): Rename from
6652         until_break_fsm_clean_up.
6653         (until_break_fsm::do_async_reply_reason): Rename from
6654         until_break_fsm_async_reply_reason.
6655         (until_break_command): Update.
6656         * thread-fsm.c: Remove.
6657         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6658
6659 2019-02-07  Tom Tromey  <tom@tromey.com>
6660
6661         * yy-remap.h: Add include guard.
6662         * xtensa-tdep.h: Add include guard.
6663         * xcoffread.h: Rename include guard.
6664         * varobj-iter.h: Add include guard.
6665         * tui/tui.h: Rename include guard.
6666         * tui/tui-winsource.h: Rename include guard.
6667         * tui/tui-wingeneral.h: Rename include guard.
6668         * tui/tui-windata.h: Rename include guard.
6669         * tui/tui-win.h: Rename include guard.
6670         * tui/tui-stack.h: Rename include guard.
6671         * tui/tui-source.h: Rename include guard.
6672         * tui/tui-regs.h: Rename include guard.
6673         * tui/tui-out.h: Rename include guard.
6674         * tui/tui-layout.h: Rename include guard.
6675         * tui/tui-io.h: Rename include guard.
6676         * tui/tui-hooks.h: Rename include guard.
6677         * tui/tui-file.h: Rename include guard.
6678         * tui/tui-disasm.h: Rename include guard.
6679         * tui/tui-data.h: Rename include guard.
6680         * tui/tui-command.h: Rename include guard.
6681         * tic6x-tdep.h: Add include guard.
6682         * target/waitstatus.h: Rename include guard.
6683         * target/wait.h: Rename include guard.
6684         * target/target.h: Rename include guard.
6685         * target/resume.h: Rename include guard.
6686         * target-float.h: Rename include guard.
6687         * stabsread.h: Add include guard.
6688         * rs6000-tdep.h: Add include guard.
6689         * riscv-fbsd-tdep.h: Add include guard.
6690         * regformats/regdef.h: Rename include guard.
6691         * record.h: Rename include guard.
6692         * python/python.h: Rename include guard.
6693         * python/python-internal.h: Rename include guard.
6694         * python/py-stopevent.h: Rename include guard.
6695         * python/py-ref.h: Rename include guard.
6696         * python/py-record.h: Rename include guard.
6697         * python/py-record-full.h: Rename include guard.
6698         * python/py-record-btrace.h: Rename include guard.
6699         * python/py-instruction.h: Rename include guard.
6700         * python/py-events.h: Rename include guard.
6701         * python/py-event.h: Rename include guard.
6702         * procfs.h: Add include guard.
6703         * proc-utils.h: Add include guard.
6704         * p-lang.h: Add include guard.
6705         * or1k-tdep.h: Rename include guard.
6706         * observable.h: Rename include guard.
6707         * nto-tdep.h: Rename include guard.
6708         * nat/x86-linux.h: Rename include guard.
6709         * nat/x86-linux-dregs.h: Rename include guard.
6710         * nat/x86-gcc-cpuid.h: Add include guard.
6711         * nat/x86-dregs.h: Rename include guard.
6712         * nat/x86-cpuid.h: Rename include guard.
6713         * nat/ppc-linux.h: Rename include guard.
6714         * nat/mips-linux-watch.h: Rename include guard.
6715         * nat/linux-waitpid.h: Rename include guard.
6716         * nat/linux-ptrace.h: Rename include guard.
6717         * nat/linux-procfs.h: Rename include guard.
6718         * nat/linux-osdata.h: Rename include guard.
6719         * nat/linux-nat.h: Rename include guard.
6720         * nat/linux-namespaces.h: Rename include guard.
6721         * nat/linux-btrace.h: Rename include guard.
6722         * nat/glibc_thread_db.h: Rename include guard.
6723         * nat/gdb_thread_db.h: Rename include guard.
6724         * nat/gdb_ptrace.h: Rename include guard.
6725         * nat/fork-inferior.h: Rename include guard.
6726         * nat/amd64-linux-siginfo.h: Rename include guard.
6727         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6728         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6729         * nat/aarch64-linux.h: Rename include guard.
6730         * nat/aarch64-linux-hw-point.h: Rename include guard.
6731         * mn10300-tdep.h: Add include guard.
6732         * mips-linux-tdep.h: Add include guard.
6733         * mi/mi-parse.h: Rename include guard.
6734         * mi/mi-out.h: Rename include guard.
6735         * mi/mi-main.h: Rename include guard.
6736         * mi/mi-interp.h: Rename include guard.
6737         * mi/mi-getopt.h: Rename include guard.
6738         * mi/mi-console.h: Rename include guard.
6739         * mi/mi-common.h: Rename include guard.
6740         * mi/mi-cmds.h: Rename include guard.
6741         * mi/mi-cmd-break.h: Rename include guard.
6742         * m2-lang.h: Add include guard.
6743         * location.h: Rename include guard.
6744         * linux-record.h: Rename include guard.
6745         * linux-nat.h: Add include guard.
6746         * linux-fork.h: Add include guard.
6747         * i386-darwin-tdep.h: Rename include guard.
6748         * hppa-linux-offsets.h: Add include guard.
6749         * guile/guile.h: Rename include guard.
6750         * guile/guile-internal.h: Rename include guard.
6751         * gnu-nat.h: Rename include guard.
6752         * gdb-stabs.h: Rename include guard.
6753         * frv-tdep.h: Add include guard.
6754         * f-lang.h: Add include guard.
6755         * event-loop.h: Add include guard.
6756         * darwin-nat.h: Rename include guard.
6757         * cp-abi.h: Rename include guard.
6758         * config/sparc/nm-sol2.h: Rename include guard.
6759         * config/nm-nto.h: Rename include guard.
6760         * config/nm-linux.h: Add include guard.
6761         * config/i386/nm-i386gnu.h: Rename include guard.
6762         * config/djgpp/nl_types.h: Rename include guard.
6763         * config/djgpp/langinfo.h: Rename include guard.
6764         * compile/gcc-cp-plugin.h: Add include guard.
6765         * compile/gcc-c-plugin.h: Add include guard.
6766         * compile/compile.h: Rename include guard.
6767         * compile/compile-object-run.h: Rename include guard.
6768         * compile/compile-object-load.h: Rename include guard.
6769         * compile/compile-internal.h: Rename include guard.
6770         * compile/compile-cplus.h: Rename include guard.
6771         * compile/compile-c.h: Rename include guard.
6772         * common/xml-utils.h: Rename include guard.
6773         * common/x86-xstate.h: Rename include guard.
6774         * common/version.h: Rename include guard.
6775         * common/vec.h: Rename include guard.
6776         * common/tdesc.h: Rename include guard.
6777         * common/selftest.h: Rename include guard.
6778         * common/scoped_restore.h: Rename include guard.
6779         * common/scoped_mmap.h: Rename include guard.
6780         * common/scoped_fd.h: Rename include guard.
6781         * common/safe-iterator.h: Rename include guard.
6782         * common/run-time-clock.h: Rename include guard.
6783         * common/refcounted-object.h: Rename include guard.
6784         * common/queue.h: Rename include guard.
6785         * common/ptid.h: Rename include guard.
6786         * common/print-utils.h: Rename include guard.
6787         * common/preprocessor.h: Rename include guard.
6788         * common/pathstuff.h: Rename include guard.
6789         * common/observable.h: Rename include guard.
6790         * common/netstuff.h: Rename include guard.
6791         * common/job-control.h: Rename include guard.
6792         * common/host-defs.h: Rename include guard.
6793         * common/gdb_wait.h: Rename include guard.
6794         * common/gdb_vecs.h: Rename include guard.
6795         * common/gdb_unlinker.h: Rename include guard.
6796         * common/gdb_unique_ptr.h: Rename include guard.
6797         * common/gdb_tilde_expand.h: Rename include guard.
6798         * common/gdb_sys_time.h: Rename include guard.
6799         * common/gdb_string_view.h: Rename include guard.
6800         * common/gdb_splay_tree.h: Rename include guard.
6801         * common/gdb_setjmp.h: Rename include guard.
6802         * common/gdb_ref_ptr.h: Rename include guard.
6803         * common/gdb_optional.h: Rename include guard.
6804         * common/gdb_locale.h: Rename include guard.
6805         * common/gdb_assert.h: Rename include guard.
6806         * common/filtered-iterator.h: Rename include guard.
6807         * common/filestuff.h: Rename include guard.
6808         * common/fileio.h: Rename include guard.
6809         * common/environ.h: Rename include guard.
6810         * common/common-utils.h: Rename include guard.
6811         * common/common-types.h: Rename include guard.
6812         * common/common-regcache.h: Rename include guard.
6813         * common/common-inferior.h: Rename include guard.
6814         * common/common-gdbthread.h: Rename include guard.
6815         * common/common-exceptions.h: Rename include guard.
6816         * common/common-defs.h: Rename include guard.
6817         * common/common-debug.h: Rename include guard.
6818         * common/cleanups.h: Rename include guard.
6819         * common/buffer.h: Rename include guard.
6820         * common/btrace-common.h: Rename include guard.
6821         * common/break-common.h: Rename include guard.
6822         * cli/cli-utils.h: Rename include guard.
6823         * cli/cli-style.h: Rename include guard.
6824         * cli/cli-setshow.h: Rename include guard.
6825         * cli/cli-script.h: Rename include guard.
6826         * cli/cli-interp.h: Rename include guard.
6827         * cli/cli-decode.h: Rename include guard.
6828         * cli/cli-cmds.h: Rename include guard.
6829         * charset-list.h: Add include guard.
6830         * buildsym-legacy.h: Rename include guard.
6831         * bfin-tdep.h: Add include guard.
6832         * ax.h: Rename include guard.
6833         * arm-linux-tdep.h: Add include guard.
6834         * arm-fbsd-tdep.h: Add include guard.
6835         * arch/xtensa.h: Rename include guard.
6836         * arch/tic6x.h: Add include guard.
6837         * arch/i386.h: Add include guard.
6838         * arch/arm.h: Rename include guard.
6839         * arch/arm-linux.h: Rename include guard.
6840         * arch/arm-get-next-pcs.h: Rename include guard.
6841         * arch/amd64.h: Add include guard.
6842         * arch/aarch64-insn.h: Rename include guard.
6843         * arch-utils.h: Rename include guard.
6844         * annotate.h: Add include guard.
6845         * amd64-darwin-tdep.h: Rename include guard.
6846         * aarch64-linux-tdep.h: Add include guard.
6847         * aarch64-fbsd-tdep.h: Add include guard.
6848         * aarch32-linux-nat.h: Add include guard.
6849
6850 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6851
6852         * macrotab.c (macro_define_internal): New function that
6853         factorizes macro_define_object_internal and macro_define_function
6854         code.
6855         (macro_define_object_internal): Use macro_define_internal.
6856         (macro_define_function): Likewise.
6857
6858 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6859
6860         * macrocmd.c (extract_identifier): Return
6861         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6862         callers.
6863
6864 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6865
6866         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6867
6868 2019-02-05  Tom Tromey  <tom@tromey.com>
6869
6870         * target.c (target_stack::unpush): Move assertion earlier.
6871
6872 2019-01-30  Tom Tromey  <tom@tromey.com>
6873
6874         PR python/23615:
6875         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6876         (gdbpy_parse_and_eval): Likewise.
6877         * python/python-internal.h (gdbpy_allow_threads): New class.
6878
6879 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6880
6881         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6882         (aarch64_fbsd_fpregmap): Move earlier.
6883         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6884         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6885         instead of individual calls to trad_frame_set_reg_addr.
6886         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6887         earlier.
6888         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6889         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6890         instead of individual calls to trad_frame_set_reg_addr.
6891
6892 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6893
6894         * CONTRIBUTE: Replace contribution list with wiki link.
6895
6896 2019-01-25  Tom Tromey  <tom@tromey.com>
6897
6898         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6899
6900 2019-01-25  Tom Tromey  <tom@tromey.com>
6901
6902         * xtensa-linux-nat.c: Fix common/ includes.
6903         * xml-support.h: Fix common/ includes.
6904         * xml-support.c: Fix common/ includes.
6905         * x86-linux-nat.c: Fix common/ includes.
6906         * windows-nat.c: Fix common/ includes.
6907         * varobj.h: Fix common/ includes.
6908         * varobj.c: Fix common/ includes.
6909         * value.c: Fix common/ includes.
6910         * valops.c: Fix common/ includes.
6911         * utils.c: Fix common/ includes.
6912         * unittests/xml-utils-selftests.c: Fix common/ includes.
6913         * unittests/utils-selftests.c: Fix common/ includes.
6914         * unittests/unpack-selftests.c: Fix common/ includes.
6915         * unittests/tracepoint-selftests.c: Fix common/ includes.
6916         * unittests/style-selftests.c: Fix common/ includes.
6917         * unittests/string_view-selftests.c: Fix common/ includes.
6918         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6919         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6920         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6921         * unittests/rsp-low-selftests.c: Fix common/ includes.
6922         * unittests/parse-connection-spec-selftests.c: Fix common/
6923         includes.
6924         * unittests/optional-selftests.c: Fix common/ includes.
6925         * unittests/offset-type-selftests.c: Fix common/ includes.
6926         * unittests/observable-selftests.c: Fix common/ includes.
6927         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6928         * unittests/memrange-selftests.c: Fix common/ includes.
6929         * unittests/memory-map-selftests.c: Fix common/ includes.
6930         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6931         * unittests/function-view-selftests.c: Fix common/ includes.
6932         * unittests/environ-selftests.c: Fix common/ includes.
6933         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6934         * unittests/common-utils-selftests.c: Fix common/ includes.
6935         * unittests/cli-utils-selftests.c: Fix common/ includes.
6936         * unittests/array-view-selftests.c: Fix common/ includes.
6937         * ui-file.c: Fix common/ includes.
6938         * tui/tui-io.c: Fix common/ includes.
6939         * tracepoint.h: Fix common/ includes.
6940         * tracepoint.c: Fix common/ includes.
6941         * tracefile-tfile.c: Fix common/ includes.
6942         * top.h: Fix common/ includes.
6943         * top.c: Fix common/ includes.
6944         * thread.c: Fix common/ includes.
6945         * target/waitstatus.h: Fix common/ includes.
6946         * target/waitstatus.c: Fix common/ includes.
6947         * target.h: Fix common/ includes.
6948         * target.c: Fix common/ includes.
6949         * target-memory.c: Fix common/ includes.
6950         * target-descriptions.c: Fix common/ includes.
6951         * symtab.h: Fix common/ includes.
6952         * symfile.c: Fix common/ includes.
6953         * stap-probe.c: Fix common/ includes.
6954         * spu-linux-nat.c: Fix common/ includes.
6955         * sparc-nat.c: Fix common/ includes.
6956         * source.c: Fix common/ includes.
6957         * solib.c: Fix common/ includes.
6958         * solib-target.c: Fix common/ includes.
6959         * ser-unix.c: Fix common/ includes.
6960         * ser-tcp.c: Fix common/ includes.
6961         * ser-pipe.c: Fix common/ includes.
6962         * ser-base.c: Fix common/ includes.
6963         * selftest-arch.c: Fix common/ includes.
6964         * s12z-tdep.c: Fix common/ includes.
6965         * rust-exp.y: Fix common/ includes.
6966         * rs6000-aix-tdep.c: Fix common/ includes.
6967         * riscv-tdep.c: Fix common/ includes.
6968         * remote.c: Fix common/ includes.
6969         * remote-notif.h: Fix common/ includes.
6970         * remote-fileio.h: Fix common/ includes.
6971         * remote-fileio.c: Fix common/ includes.
6972         * regcache.h: Fix common/ includes.
6973         * regcache.c: Fix common/ includes.
6974         * record-btrace.c: Fix common/ includes.
6975         * python/python.c: Fix common/ includes.
6976         * python/py-type.c: Fix common/ includes.
6977         * python/py-inferior.c: Fix common/ includes.
6978         * progspace.h: Fix common/ includes.
6979         * producer.c: Fix common/ includes.
6980         * procfs.c: Fix common/ includes.
6981         * proc-api.c: Fix common/ includes.
6982         * printcmd.c: Fix common/ includes.
6983         * ppc-linux-nat.c: Fix common/ includes.
6984         * parser-defs.h: Fix common/ includes.
6985         * osdata.c: Fix common/ includes.
6986         * obsd-nat.c: Fix common/ includes.
6987         * nat/x86-linux.c: Fix common/ includes.
6988         * nat/x86-linux-dregs.c: Fix common/ includes.
6989         * nat/x86-dregs.h: Fix common/ includes.
6990         * nat/x86-dregs.c: Fix common/ includes.
6991         * nat/ppc-linux.c: Fix common/ includes.
6992         * nat/mips-linux-watch.h: Fix common/ includes.
6993         * nat/mips-linux-watch.c: Fix common/ includes.
6994         * nat/linux-waitpid.c: Fix common/ includes.
6995         * nat/linux-ptrace.h: Fix common/ includes.
6996         * nat/linux-ptrace.c: Fix common/ includes.
6997         * nat/linux-procfs.c: Fix common/ includes.
6998         * nat/linux-personality.c: Fix common/ includes.
6999         * nat/linux-osdata.c: Fix common/ includes.
7000         * nat/linux-namespaces.c: Fix common/ includes.
7001         * nat/linux-btrace.h: Fix common/ includes.
7002         * nat/linux-btrace.c: Fix common/ includes.
7003         * nat/fork-inferior.c: Fix common/ includes.
7004         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7005         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7006         * nat/aarch64-linux.c: Fix common/ includes.
7007         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7008         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7009         * namespace.h: Fix common/ includes.
7010         * mips-linux-tdep.c: Fix common/ includes.
7011         * minsyms.c: Fix common/ includes.
7012         * mi/mi-parse.h: Fix common/ includes.
7013         * mi/mi-main.c: Fix common/ includes.
7014         * mi/mi-cmd-env.c: Fix common/ includes.
7015         * memrange.h: Fix common/ includes.
7016         * memattr.c: Fix common/ includes.
7017         * maint.h: Fix common/ includes.
7018         * maint.c: Fix common/ includes.
7019         * main.c: Fix common/ includes.
7020         * machoread.c: Fix common/ includes.
7021         * location.c: Fix common/ includes.
7022         * linux-thread-db.c: Fix common/ includes.
7023         * linux-nat.c: Fix common/ includes.
7024         * linux-fork.c: Fix common/ includes.
7025         * inline-frame.c: Fix common/ includes.
7026         * infrun.c: Fix common/ includes.
7027         * inflow.c: Fix common/ includes.
7028         * inferior.h: Fix common/ includes.
7029         * inferior.c: Fix common/ includes.
7030         * infcmd.c: Fix common/ includes.
7031         * inf-ptrace.c: Fix common/ includes.
7032         * inf-child.c: Fix common/ includes.
7033         * ia64-linux-nat.c: Fix common/ includes.
7034         * i387-tdep.c: Fix common/ includes.
7035         * i386-tdep.c: Fix common/ includes.
7036         * i386-linux-tdep.c: Fix common/ includes.
7037         * i386-linux-nat.c: Fix common/ includes.
7038         * i386-go32-tdep.c: Fix common/ includes.
7039         * i386-fbsd-tdep.c: Fix common/ includes.
7040         * i386-fbsd-nat.c: Fix common/ includes.
7041         * guile/scm-type.c: Fix common/ includes.
7042         * guile/guile.c: Fix common/ includes.
7043         * go32-nat.c: Fix common/ includes.
7044         * gnu-nat.c: Fix common/ includes.
7045         * gdbthread.h: Fix common/ includes.
7046         * gdbarch-selftests.c: Fix common/ includes.
7047         * gdb_usleep.c: Fix common/ includes.
7048         * gdb_select.h: Fix common/ includes.
7049         * gdb_bfd.c: Fix common/ includes.
7050         * gcore.c: Fix common/ includes.
7051         * fork-child.c: Fix common/ includes.
7052         * findvar.c: Fix common/ includes.
7053         * fbsd-nat.c: Fix common/ includes.
7054         * event-top.c: Fix common/ includes.
7055         * event-loop.c: Fix common/ includes.
7056         * dwarf2read.c: Fix common/ includes.
7057         * dwarf2loc.c: Fix common/ includes.
7058         * dwarf2-frame.c: Fix common/ includes.
7059         * dwarf-index-cache.c: Fix common/ includes.
7060         * dtrace-probe.c: Fix common/ includes.
7061         * disasm-selftests.c: Fix common/ includes.
7062         * defs.h: Fix common/ includes.
7063         * csky-tdep.c: Fix common/ includes.
7064         * cp-valprint.c: Fix common/ includes.
7065         * cp-support.h: Fix common/ includes.
7066         * cp-support.c: Fix common/ includes.
7067         * corelow.c: Fix common/ includes.
7068         * completer.h: Fix common/ includes.
7069         * completer.c: Fix common/ includes.
7070         * compile/compile.c: Fix common/ includes.
7071         * compile/compile-loc2c.c: Fix common/ includes.
7072         * compile/compile-cplus-types.c: Fix common/ includes.
7073         * compile/compile-cplus-symbols.c: Fix common/ includes.
7074         * command.h: Fix common/ includes.
7075         * cli/cli-dump.c: Fix common/ includes.
7076         * cli/cli-cmds.c: Fix common/ includes.
7077         * charset.c: Fix common/ includes.
7078         * build-id.c: Fix common/ includes.
7079         * btrace.h: Fix common/ includes.
7080         * btrace.c: Fix common/ includes.
7081         * breakpoint.h: Fix common/ includes.
7082         * breakpoint.c: Fix common/ includes.
7083         * ax.h:
7084         (enum agent_op): Fix common/ includes.
7085         * ax-general.c (struct aop_map): Fix common/ includes.
7086         * ax-gdb.c: Fix common/ includes.
7087         * auxv.c: Fix common/ includes.
7088         * auto-load.c: Fix common/ includes.
7089         * arm-tdep.c: Fix common/ includes.
7090         * arch/riscv.c: Fix common/ includes.
7091         * arch/ppc-linux-common.c: Fix common/ includes.
7092         * arch/i386.c: Fix common/ includes.
7093         * arch/arm.c: Fix common/ includes.
7094         * arch/arm-linux.c: Fix common/ includes.
7095         * arch/arm-get-next-pcs.c: Fix common/ includes.
7096         * arch/amd64.c: Fix common/ includes.
7097         * arch/aarch64.c: Fix common/ includes.
7098         * arch/aarch64-insn.c: Fix common/ includes.
7099         * arch-utils.c: Fix common/ includes.
7100         * amd64-windows-tdep.c: Fix common/ includes.
7101         * amd64-tdep.c: Fix common/ includes.
7102         * amd64-sol2-tdep.c: Fix common/ includes.
7103         * amd64-obsd-tdep.c: Fix common/ includes.
7104         * amd64-nbsd-tdep.c: Fix common/ includes.
7105         * amd64-linux-tdep.c: Fix common/ includes.
7106         * amd64-linux-nat.c: Fix common/ includes.
7107         * amd64-fbsd-tdep.c: Fix common/ includes.
7108         * amd64-fbsd-nat.c: Fix common/ includes.
7109         * amd64-dicos-tdep.c: Fix common/ includes.
7110         * amd64-darwin-tdep.c: Fix common/ includes.
7111         * agent.c: Fix common/ includes.
7112         * ada-lang.h: Fix common/ includes.
7113         * ada-lang.c: Fix common/ includes.
7114         * aarch64-tdep.c: Fix common/ includes.
7115
7116 2019-01-25  Tom Tromey  <tom@tromey.com>
7117
7118         * common/create-version.sh: Use common/version.h.
7119
7120 2019-01-24  Pedro Alves  <palves@redhat.com>
7121
7122         * infrun.c (signal_stop, signal_print, signal_program)
7123         (signal_catch, signal_pass): Now arrays instead of pointers.
7124         (update_signals_program_target, do_target_resume)
7125         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7126         * linux-nat.c (linux_nat_target::pass_signals)
7127         (linux_nat_target::create_inferior, linux_nat_target::attach):
7128         Adjust.
7129         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7130         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7131         * procfs.c (procfs_target::pass_signals): Adjust.
7132         * record-full.c (record_full_target::resume): Adjust.
7133         * remote.c (remote_target::pass_signals)
7134         (remote_target::program_signals): Adjust.
7135         * target-debug.h (target_debug_print_signals): Now takes a
7136         gdb::array_view as parameter.  Adjust.
7137         * target.h (target_ops) <pass_signals, program_signals>: Replace
7138         pointer and length parameters with gdb::array_view.
7139         (target_pass_signals, target_program_signals): Likewise.
7140         * target-delegates.c: Regenerate.
7141
7142 2019-01-24  Pedro Alves  <palves@redhat.com>
7143
7144         * common/forward-scope-exit.h
7145         (forward_scope_exit::forward_scope_exit): Pass arguments to
7146         m_bind_function directly, instead of creating a std::bind and
7147         copying that.
7148
7149 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7150
7151         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7152         for static members.
7153         (pass_in_v_vfp_candidate): Likewise.
7154
7155 2019-01-23  Tom Tromey  <tom@tromey.com>
7156             Pedro Alves  <palves@redhat.com>
7157
7158         * regcache.c (class regcache_invalidator): Remove.
7159         (regcache::raw_write): Use make_scope_exit.
7160
7161 2019-01-23  Tom Tromey  <tom@tromey.com>
7162
7163         * ui-out.h (class ui_out_emit_type): Update comment.
7164
7165 2019-01-23  Tom Tromey  <tom@tromey.com>
7166
7167         * infrun.c (fetch_inferior_event): Update comment.
7168
7169 2019-01-23  Tom Tromey  <tom@tromey.com>
7170             Pedro Alves  <palves@redhat.com>
7171
7172         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7173         parameter.
7174         (fetch_inferior_event): Use SCOPE_EXIT.
7175
7176
7177 2019-01-23  Tom Tromey  <tom@tromey.com>
7178             Pedro Alves  <palves@redhat.com>
7179
7180         * infrun.c (disable_thread_events): Delete.
7181         (stop_all_threads): Use SCOPE_EXIT.
7182
7183 2019-01-23  Tom Tromey  <tom@tromey.com>
7184             Pedro Alves  <palves@redhat.com>
7185
7186         * symfile.c: Include forward-scope-exit.h.
7187         (clear_symtab_users_cleanup): Replace forward declaration with
7188         a FORWARD_SCOPE_EXIT.
7189         (syms_from_objfile_1): Use the forward_scope_exit and
7190         gdb::optional instead of cleanup_function.
7191         (reread_symbols): Use the forward_scope_exit instead of
7192         cleanup_function.
7193         (clear_symtab_users_cleanup): Remove function.
7194
7195 2019-01-23  Tom Tromey  <tom@tromey.com>
7196             Pedro Alves  <palves@redhat.com>
7197
7198         * linux-nat.c: Include scope-exit.h.
7199         (cleanup_target_stop): Remove.
7200         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7201         SCOPE_EXIT.
7202
7203 2019-01-23  Tom Tromey  <tom@tromey.com>
7204             Pedro Alves  <palves@redhat.com>
7205
7206         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7207         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7208
7209 2019-01-23  Tom Tromey  <tom@tromey.com>
7210             Andrew Burgess  <andrew.burgess@embecosm.com>
7211             Pedro Alves  <palves@redhat.com>
7212
7213         * infrun.c (fetch_inferior_event): Use scope_exit.
7214         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7215         * top.c (execute_command): Use scope_exit.
7216         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7217         * utils.c (do_bpstat_clear_actions_cleanup)
7218         (make_bpstat_clear_actions_cleanup): Remove.
7219
7220 2019-01-23  Tom Tromey  <tom@tromey.com>
7221             Pedro Alves  <palves@redhat.com>
7222
7223         * infrun.c: Include "common/scope-exit.h"
7224         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7225         (wait_for_inferior): Use SCOPE_EXIT.
7226         (fetch_inferior_event): Use scope_exit.
7227
7228 2019-01-23  Tom Tromey  <tom@tromey.com>
7229             Pedro Alves  <palves@redhat.com>
7230
7231         * breakpoint.c (create_breakpoint): Remove cleanup.
7232
7233 2019-01-23  Tom Tromey  <tom@tromey.com>
7234             Andrew Burgess  <andrew.burgess@embecosm.com>
7235             Pedro Alves  <palves@redhat.com>
7236
7237 2019-01-23  Pedro Alves  <palves@redhat.com>
7238
7239         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7240
7241 2019-01-23  Pedro Alves  <palves@redhat.com>
7242             Andrew Burgess  <andrew.burgess@embecosm.com>
7243
7244         * gdbthread.h: Include "common/forward-scope-exit.h".
7245         (scoped_finish_thread_state): Redefine custom class in terms of
7246         forward_scope_exit.
7247
7248 2019-01-23  Pedro Alves  <palves@redhat.com>
7249             Andrew Burgess  <andrew.burgess@embecosm.com>
7250
7251         * common/forward-scope-exit.h: New file.
7252
7253 2019-01-23  Pedro Alves  <palves@redhat.com>
7254             Andrew Burgess  <andrew.burgess@embecosm.com>
7255             Tom Tromey  <tom@tromey.com>
7256
7257         * common/scope-exit.h: New file.
7258
7259 2019-01-23  Pedro Alves  <palves@redhat.com>
7260
7261         * common/preprocessor.h (ESC): Rename to ...
7262         (ESC_PARENS): ... this.
7263         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7264         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7265
7266 2019-01-23  Tom Tromey  <tom@tromey.com>
7267
7268         * language.h (class scoped_switch_to_sym_language_if_auto):
7269         Initialize m_lang in both cases.
7270
7271 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7272
7273         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7274         with XCNEW.
7275
7276 2019-01-22  Tom Tromey  <tom@tromey.com>
7277
7278         * corelow.c: Do not include sys/file.h.
7279
7280 2019-01-22  Tom Tromey  <tom@tromey.com>
7281
7282         * tui/tui-wingeneral.h: Include gdb_curses.h.
7283
7284 2019-01-22  Tom Tromey  <tom@tromey.com>
7285
7286         * source-cache.h (class source_cache) <get_source_lines,
7287         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7288
7289 2019-01-22  Tom Tromey  <tom@tromey.com>
7290
7291         * remote-fileio.h (struct remote_target): Declare.
7292
7293 2019-01-22  Tom Tromey  <tom@tromey.com>
7294
7295         * python/py-arch.c: Do not include py-ref.h.
7296         * python/py-bpevent.c: Do not include py-ref.h.
7297         * python/py-cmd.c: Do not include py-ref.h.
7298         * python/py-continueevent.c: Do not include py-ref.h.
7299         * python/py-event.h: Do not include py-ref.h.
7300         * python/py-evtregistry.c: Do not include py-ref.h.
7301         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7302         * python/py-frame.c: Do not include py-ref.h.
7303         * python/py-framefilter.c: Do not include py-ref.h.
7304         * python/py-function.c: Do not include py-ref.h.
7305         * python/py-infevents.c: Do not include py-ref.h.
7306         * python/py-linetable.c: Do not include py-ref.h.
7307         * python/py-objfile.c: Do not include py-ref.h.
7308         * python/py-param.c: Do not include py-ref.h.
7309         * python/py-prettyprint.c: Do not include py-ref.h.
7310         * python/py-progspace.c: Do not include py-ref.h.
7311         * python/py-symbol.c: Do not include py-ref.h.
7312         * python/py-symtab.c: Do not include py-ref.h.
7313         * python/py-type.c: Do not include py-ref.h.
7314         * python/py-unwind.c: Do not include py-ref.h.
7315         * python/py-utils.c: Do not include py-ref.h.
7316         * python/py-value.c: Do not include py-ref.h.
7317         * python/py-varobj.c: Do not include py-ref.h.
7318         * python/py-xmethods.c: Do not include py-ref.h.
7319         * python/python.c: Do not include py-ref.h.
7320         * varobj.c: Do not include py-ref.h.
7321
7322 2019-01-22  Tom Tromey  <tom@tromey.com>
7323
7324         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7325         keyword for bcache.
7326
7327 2019-01-22  Tom Tromey  <tom@tromey.com>
7328
7329         * compile/compile-cplus-types.c: Remove a comment by #include.
7330
7331 2019-01-22  Tom Tromey  <tom@tromey.com>
7332
7333         * compile/gcc-c-plugin.h: Include compile-internal.h.
7334
7335 2019-01-22  Tom Tromey  <tom@tromey.com>
7336
7337         * stabsread.c (EXTERN): Do not define.
7338         (symnum, next_symbol_text_func, processing_gcc_compilation)
7339         (within_function, global_sym_chain, global_stabs)
7340         (previous_stab_code, this_object_header_files)
7341         (n_this_object_header_files)
7342         (n_allocated_this_object_header_files): Define.
7343         * stabsread.h (EXTERN): Never define.  Use "extern".
7344
7345 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7346
7347         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7348         history_value.
7349
7350 2019-01-21  Tom Tromey  <tom@tromey.com>
7351
7352         * ui-out.c: Fix includes.
7353         * tui/tui-source.c: Fix includes.
7354         * target.c: Fix includes.
7355         * remote.c: Fix includes.
7356         * regcache.c: Fix includes.
7357         * python/py-block.c: Fix includes.
7358         * printcmd.c: Fix includes.
7359         * or1k-tdep.c: Fix includes.
7360         * mi/mi-main.c: Fix includes.
7361         * m32r-tdep.c: Fix includes.
7362         * csky-tdep.c: Fix includes.
7363         * compile/compile-cplus-types.c: Fix includes.
7364         * cli/cli-interp.c: Fix includes.
7365
7366 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7367
7368         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7369         for padding.
7370
7371 2019-01-16  Tom Tromey  <tom@tromey.com>
7372
7373         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7374         earlier.
7375         (struct objfile) <msymbols_range>: Move from top level.
7376         <msymbols>: New method.
7377         (class objfile_msymbols): Remove.
7378         * symtab.c (default_collect_symbol_completion_matches_break_on):
7379         Update.
7380         * symmisc.c (dump_msymbols): Update.
7381         * stabsread.c (scan_file_globals): Update.
7382         * objc-lang.c (info_selectors_command, info_classes_command)
7383         (find_methods): Update.
7384         * minsyms.c (find_solib_trampoline_target): Update.
7385         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7386         * coffread.c (coff_symfile_read): Update.
7387         * ada-lang.c (ada_lookup_simple_minsym)
7388         (ada_collect_symbol_completion_matches): Update.
7389
7390 2019-01-16  Tom Tromey  <tom@tromey.com>
7391
7392         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7393         type.  Remove no-argument constructor.
7394         <iterator::operator++>: Simplify.
7395         <begin>: Update.
7396         <end>: Use minimal_symbol_count.
7397
7398 2019-01-16  Tom Tromey  <tom@tromey.com>
7399
7400         * objfiles.h (struct objfile) <psymtabs>: New method.
7401         (class objfile_psymtabs): Remove.
7402         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7403         typedef.
7404         <range>: New method.
7405         (require_partial_symbols): Change return type.
7406         * psymtab.c (require_partial_symbols)
7407         (psym_expand_symtabs_matching): Update.
7408         * mdebugread.c (parse_partial_symbols): Update.
7409         * dbxread.c (dbx_end_psymtab): Update.
7410
7411 2019-01-15  Tom Tromey  <tom@tromey.com>
7412
7413         * symtab.c (lookup_objfile_from_block)
7414         (lookup_symbol_in_objfile_symtabs)
7415         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7416         (find_line_symtab, info_sources_command)
7417         (default_collect_symbol_completion_matches_break_on)
7418         (make_source_files_completion_list): Update.
7419         * symmisc.c (print_objfile_statistics, dump_objfile)
7420         (maintenance_print_symbols, maintenance_info_symtabs)
7421         (maintenance_check_symtabs, maintenance_info_line_tables):
7422         Update.
7423         * source.c (select_source_symtab)
7424         (forget_cached_source_info_for_objfile): Update.
7425         * objfiles.h (class objfile_compunits): Remove.
7426         (struct objfile) <compunits_range>: New typedef.
7427         (compunits): New method.
7428         * objfiles.c (objfile_relocate1): Update.
7429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7430         * maint.c (count_symtabs_and_blocks): Update.
7431         * linespec.c (iterate_over_all_matching_symtabs): Update.
7432         * cp-support.c (add_symbol_overload_list_qualified): Update.
7433         * coffread.c (coff_symtab_read): Update.
7434         * ada-lang.c (add_nonlocal_symbols)
7435         (ada_collect_symbol_completion_matches)
7436         (ada_add_global_exceptions): Update.
7437
7438 2019-01-15  Tom Tromey  <tom@tromey.com>
7439
7440         * progspace.h (program_space) <objfiles_safe_range>: New
7441         typedef.
7442         <objfiles_safe>: New method.
7443         * objfiles.h (class all_objfiles_safe): Remove.
7444         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7445         * jit.c (jit_inferior_exit_hook): Update.
7446
7447 2019-01-17  Tom Tromey  <tom@tromey.com>
7448
7449         * progspace.h (program_space) <objfiles_range>: New typedef.
7450         <objfiles>: New method.
7451         <objfiles_head>: Rename from objfiles.
7452         (object_files): Update.
7453         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7454         * guile/scm-pretty-print.c
7455         (ppscm_find_pretty_printer_from_objfiles): Update.
7456         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7457         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7458         Update.
7459         * python/py-progspace.c (pspy_get_objfiles): Update.
7460         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7461         Update.
7462         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7463         (objfpy_lookup_objfile_by_build_id): Update.
7464         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7465         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7466         Update.
7467         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7468         (expand_symtab_containing_pc, lookup_objfile_from_block)
7469         (lookup_static_symbol, basic_lookup_transparent_type)
7470         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7471         (find_line_symtab, info_sources_command)
7472         (default_collect_symbol_completion_matches_break_on)
7473         (make_source_files_completion_list, find_main_name): Update.
7474         * symmisc.c (print_symbol_bcache_statistics)
7475         (print_objfile_statistics, maintenance_print_symbols)
7476         (maintenance_print_msymbols, maintenance_print_objfiles)
7477         (maintenance_info_symtabs, maintenance_check_symtabs)
7478         (maintenance_expand_symtabs, maintenance_info_line_tables):
7479         Update.
7480         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7481         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7482         (map_overlay_command, unmap_overlay_command)
7483         (simple_overlay_update, expand_symtabs_matching)
7484         (map_symbol_filenames): Update.
7485         * symfile-debug.c (set_debug_symfile): Update.
7486         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7487         Update.
7488         * source.c (select_source_symtab, forget_cached_source_info):
7489         Update.
7490         * solib.c (solib_read_symbols): Update.
7491         * solib-spu.c (append_ocl_sos): Update.
7492         * psymtab.c (maintenance_print_psymbols)
7493         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7494         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7495         * printcmd.c (info_symbol_command): Update.
7496         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7497         Update.
7498         * objfiles.h (class all_objfiles): Remove.
7499         * objfiles.c (have_partial_symbols, have_full_symbols)
7500         (have_minimal_symbols, qsort_cmp, update_section_map)
7501         (shared_objfile_contains_address_p)
7502         (default_iterate_over_objfiles_in_search_order): Update.
7503         * objc-lang.c (info_selectors_command, info_classes_command)
7504         (find_methods): Update.
7505         * minsyms.c (find_solib_trampoline_target): Update.
7506         * maint.c (maintenance_info_sections)
7507         (maintenance_translate_address, count_symtabs_and_blocks):
7508         Update.
7509         * main.c (captured_main_1): Update.
7510         * linux-thread-db.c (try_thread_db_load_from_pdir)
7511         (has_libpthread): Update.
7512         * linespec.c (iterate_over_all_matching_symtabs)
7513         (search_minsyms_for_name): Update.
7514         * jit.c (jit_find_objf_with_entry_addr): Update.
7515         * hppa-tdep.c (find_unwind_entry)
7516         (hppa_lookup_stub_minimal_symbol): Update.
7517         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7518         Update.
7519         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7520         (elf_gnu_ifunc_resolve_by_got): Update.
7521         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7522         * dwarf-index-write.c (save_gdb_index_command): Update.
7523         * cp-support.c (add_symbol_overload_list_qualified): Update.
7524         * breakpoint.c (create_overlay_event_breakpoint)
7525         (create_longjmp_master_breakpoint)
7526         (create_std_terminate_master_breakpoint)
7527         (create_exception_master_breakpoint): Update.
7528         * blockframe.c (find_pc_partial_function): Update.
7529         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7530         (ada_collect_symbol_completion_matches)
7531         (ada_add_global_exceptions): Update.
7532
7533 2019-01-17  Tom Tromey  <tom@tromey.com>
7534
7535         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7536         declare VEC.
7537         (solib_target_parse_libraries): Change return type.
7538         (library_list_start_segment, library_list_start_section)
7539         (library_list_end_library, library_list_start_library); Update.
7540         (solib_target_free_library_list): Remove.
7541         (solib_target_parse_libraries): Remove cleanup.  Change return
7542         type.
7543         (solib_target_current_sos): Update.
7544
7545 2019-01-17  Tom Tromey  <tromey@bapiya>
7546
7547         * valprint.c: Replace "the the" with "the".
7548         * symtab.c: Replace "the the" with "the".
7549         * solib.c: Replace "the the" with "the".
7550         * solib-dsbt.c: Replace "the the" with "the".
7551         * linespec.c: Replace "the the" with "the".
7552         * dwarf2loc.h: Replace "the the" with "the".
7553         * amd64-windows-tdep.c: Replace "the the" with "the".
7554         * aarch64-tdep.c: Replace "the the" with "the".
7555
7556 2019-01-16  Keith Seitz  <keiths@redhat.com>
7557
7558         PR gdb/23773
7559         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7560         <builder>: Rename to ..
7561         <m_builder>: ... this and make private.
7562         (dwarf2_cu::get_builder): New method.  Change all users of
7563         `builder' to use this method.
7564         (dwarf2_start_symtab): Move to ...
7565         (dwarf2_cu::start_symtab): ... here.  Update all callers
7566         (setup_type_unit_groups): Move to ...
7567         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7568         callers.
7569         (dwarf2_cu::reset_builder): New method.
7570         (process_full_compunit, process_full_type_unit): Use
7571         dwarf2_cu::reset_builder.
7572         (follow_die_offset): Record the ancestor CU if it is different
7573         from the followed DIE's CU.
7574         (follow_die_sig_1): Likewise.
7575
7576 2019-01-15  Tom Tromey  <tom@tromey.com>
7577
7578         * remote.c (class remote_state) <buf>: Now a char_vector.
7579         <buf_size>: Remove.
7580         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7581         parameter.
7582         (remote_target::getpkt_or_notif_sane_1)
7583         (remote_target::getpkt_sane)
7584         (remote_target::getpkt_or_notif_sane): Likewise.
7585         (class remote_target) <putpkt>: New overload.
7586         (remote_target::read_frame): Change type of "buf_p".  Remove
7587         sizeof_p parameter.
7588         (packet_ok): New overload.
7589         (packet_check_result): New overload.
7590         Update all uses.
7591
7592 2019-01-14  Tom Tromey  <tom@tromey.com>
7593
7594         * remote-notif.c (handle_notification, remote_notif_ack)
7595         (remote_notif_parse): Make "buf" const.
7596         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7597         const.
7598         (remote_notif_parse, remote_notif_ack, handle_notification):
7599         Likewise.
7600         * remote.c (remote_notif_stop_parse): Make "buf" const.
7601         (remote_target::remote_parse_stop_reply): Make "buf" const.
7602         (remote_notif_stop_ack): Make "buf" const.
7603
7604 2019-01-14  Tom Tromey  <tom@tromey.com>
7605
7606         * remote.c (remote_console_output): Make parameter const.
7607
7608 2019-01-14  Tom Tromey  <tom@tromey.com>
7609
7610         * target-debug.h (target_debug_print_signals): Constify.
7611         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7612         * procfs.c (procfs_target::pass_signals): Update.
7613         * linux-nat.c (linux_nat_target::pass_signals): Update.
7614         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7615         * target-delegates.c: Rebuild.
7616         * remote.c (remote_target::program_signals): Update.
7617         (remote_target::pass_signals): Update.
7618         * target.c (target_pass_signals): Constify argument.
7619         (target_program_signals): Likewise.
7620         * target.h (struct target_ops) <pass_signals, program_signals>:
7621         Constify argument.
7622         (target_pass_signals, target_program_signals): Constify argument.
7623
7624 2019-01-14  Tom Tromey  <tom@tromey.com>
7625
7626         PR tui/28819:
7627         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7628
7629 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7630
7631         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7632         field.
7633         * rs6000-tdep.c: Include reggroups.h.
7634         (IS_V_ALIAS_PSEUDOREG): Define.
7635         (rs6000_register_name): Return names for the "vX" aliases.
7636         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7637         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7638         aliases.  Call default_register_reggroup_p for all other
7639         pseudo-registers.
7640         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7641         New functions.
7642         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7643         Handle "vX" aliases.
7644         (v_alias_pseudo_register_collect): New function.
7645         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7646         (rs6000_gdbarch_init): Initialize "vX" aliases as
7647         pseudo-registers.  Restore registration of
7648         rs6000_pseudo_register_reggroup_p with
7649         set_tdesc_pseudo_register_reggroup_p.
7650
7651 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7652
7653         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7654         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7655         set_gdbarch_num_pseudo_regs.
7656
7657 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7658
7659         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7660         Remove arg prefixname, add do_set and do_show.
7661         Add member functions set_list and show_list.
7662         * cli/cli-style.c (class cli_style_option): Update accordingly.
7663         (style_set_list): Move to file scope.
7664         (style_show_list): Likewise.
7665         (set_style): Call help_list.
7666         (show_style): Call cmd_show_list.
7667         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7668         Update to use the new macro.
7669
7670 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7671
7672         * ada-lang.c (_initialize_ada_language): Expand the help text
7673         for the "catch exception" command.
7674
7675 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7676
7677         * symtab.c (matching_obj_sections): Initialize obj,
7678         declare it closer to its usage.
7679
7680 2019-01-10  Tom Tromey  <tom@tromey.com>
7681
7682         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7683         (basic_inf_threads_range): Remove.
7684         (inf_threads_range, inf_non_exited_threads_range)
7685         (safe_inf_threads_range): Use next_adapter.
7686
7687 2019-01-10  Keith Seitz  <keiths@redhat.com>
7688
7689         PR gdb/23712
7690         PR symtab/23010
7691         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7692         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7693
7694 2019-01-10  Keith Seitz  <keiths@redhat.com>
7695
7696         PR gdb/23712
7697         PR symtab/23010
7698         * dictionary.c (pending_to_vector): Remove.
7699         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7700         Remove _1 suffix, replacing functions of the same name.  Update
7701         all callers.
7702         (dict_create_hashed, dict_create_hashed_expandable)
7703         (dict_create_linear, dict_create_linear_expandable, dict_free)
7704         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7705         Make functions static.
7706
7707 2019-01-10  Keith Seitz  <keiths@redhat.com>
7708
7709         PR gdb/23712
7710         PR symtab/23010
7711         * dictionary.h (struct dictionary): Replace declaration with
7712         multidictionary.
7713         (dict_create_hashed, dict_create_hashed_expandable)
7714         (dict_create_linear, dict_create_linear_expandable)
7715         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7716         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7717         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7718         taking multidictionary argument.
7719         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7720         * block.h (struct block) <dict>: Change to multidictionary
7721         and rename `multidict'.
7722         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7723         symmisc.c: Update all dictionary references to multidictionary.
7724
7725 2019-01-10  Keith Seitz  <keiths@redhat.com>
7726
7727         PR gdb/23712
7728         PR symtab/23010
7729         * dictionary.c: Include unordered_map.
7730         (pending_to_vector): New function.
7731         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7732         Rewrite the non-"_1" functions to take vector instead
7733         of linked list.
7734         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7735         "new" _1 versions of the same name.
7736         (multidictionary): Define.
7737         (std::hash<enum language): New definition.
7738         (collate_pending_symbols_by_language, mdict_create_hashed)
7739         (mdict_create_hashed_expandable, mdict_create_linear)
7740         (mdict_create_linear_expandable, mdict_free)
7741         (find_language_dictionary, create_new_language_dictionary)
7742         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7743         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7744         (mdict_size, mdict_empty): New functions.
7745         * dictionary.h (mdict_iterator): Define.
7746
7747 2019-01-10  Pedro Alves  <palves@redhat.com>
7748
7749         * breakpoint.c (read_uploaded_action)
7750         (create_tracepoint_from_upload): Adjust to use
7751         gdb::unique_xmalloc_ptr.
7752         * ctf.c (ctf_write_uploaded_tp):
7753         (SET_ARRAY_FIELD): Use emplace_back.
7754         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7755         * tracefile-tfile.c (tfile_write_uploaded_tp):
7756         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7757         gdb::unique_xmalloc_ptr.
7758         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7759         at_string, cond_string, cmd_strings>: Replace char pointers
7760         with gdb::unique_xmalloc_ptr.
7761
7762 2019-01-10  Pedro Alves  <palves@redhat.com>
7763
7764         * solib-target.c (library_list_start_library): Don't xstrdup name.
7765
7766 2019-01-10  Pedro Alves  <palves@redhat.com>
7767
7768         * mdebugread.c (parse_partial_symbols): Use
7769         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7770
7771 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7772
7773         * linux-fork.c (scoped_switch_fork_info)
7774         <~scoped_switch_fork_info>: Fix incorrect variable name.
7775
7776 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7777
7778         * linux-fork.c (scoped_switch_fork_info)
7779         <scoped_switch_fork_info>: Make explicit.
7780         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7781
7782 2019-01-10  Tom Tromey  <tom@tromey.com>
7783
7784         * objfiles.h (objfile::reset_psymtabs): Update.
7785         * objfiles.c (objfile::objfile): Update.
7786         * psymtab.h (psymtab_storage::obstack): Update.
7787         (psymtab_storage::m_obstack): Use gdb::optional.
7788         (class psymtab_storage): Update comment.  Remove objfile
7789         parameter.
7790         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7791
7792 2019-01-10  Tom Tromey  <tom@tromey.com>
7793
7794         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7795         <free_psymtabs>: Now private.
7796         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7797         (allocate_psymtab): Use new method.
7798
7799 2019-01-10  Tom Tromey  <tom@tromey.com>
7800
7801         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7802         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7803         * mdebugread.c (parse_partial_symbols): Use
7804         allocate_dependencies.
7805         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7806         allocate_dependencies.
7807         (process_psymtab_comp_unit_reader)
7808         (build_type_psymtab_dependencies): Likewise.
7809         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7810
7811 2019-01-10  Tom Tromey  <tom@tromey.com>
7812
7813         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7814         PSYMBOL_SET_LANGUAGE.
7815         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7816
7817 2019-01-10  Tom Tromey  <tom@tromey.com>
7818
7819         * psymtab.h (psymtab_storage::obstack): New method.
7820         <m_obstack>: Rename from obstack; now private.
7821         * psymtab.c (psymtab_storage): Update.
7822         * dwarf2read.c (create_addrmap_from_index)
7823         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7824         Update.
7825
7826 2019-01-10  Tom Tromey  <tom@tromey.com>
7827
7828         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7829         * objfiles.h (objfile::reset_psymtabs): New method.
7830
7831 2019-01-10  Tom Tromey  <tom@tromey.com>
7832
7833         * symmisc.c (print_symbol_bcache_statistics): Update.
7834         (print_objfile_statistics): Update.
7835         * symfile.c (reread_symbols): Update.
7836         * psymtab.h (class psymtab_storage): New.
7837         * psymtab.c (psymtab_storage): New constructor.
7838         (~psymtab_storage): New destructor.
7839         (require_partial_symbols): Update.
7840         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7841         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7842         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7843         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7844         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7845         (start_psymtab_common, end_psymtab_common)
7846         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7847         (allocate_psymtab): Update.
7848         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7849         Update.
7850         (dump_psymtab_addrmap, maintenance_print_psymbols)
7851         (maintenance_check_psymtabs): Update.
7852         (class objfile_psymtabs): Move to objfiles.h.
7853         * psympriv.h (discard_psymtab): Now inline.
7854         (psymtab_discarder::psymtab_discarder): Update.
7855         (psymtab_discarder::~psymtab_discarder): Update.
7856         (ALL_OBJFILE_PSYMTABS): Rewrite.
7857         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7858         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7859         Remove fields.
7860         <partial_symtabs>: New field.
7861         (class objfile_psymtabs): Move from psymtab.h.  Update.
7862         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7863         psymbol_cache.
7864         (objfile::~objfile): Don't destroy psymbol_cache.
7865         * mdebugread.c (parse_partial_symbols): Update.
7866         * dwarf2read.c (create_addrmap_from_index)
7867         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7868         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7869         (add_partial_subprogram, dwarf2_ranges_read): Update.
7870         * dwarf-index-write.c (write_address_map)
7871         (write_one_signatured_type, recursively_write_psymbols)
7872         (class debug_names, class debug_names, write_psymtabs_to_index):
7873         Update.
7874
7875 2019-01-10  Tom Tromey  <tom@tromey.com>
7876
7877         * symtab.h (SYMBOL_SET_NAMES): Update.
7878         (symbol_set_names): Update.
7879         (MSYMBOL_SET_NAMES): Update.
7880         * symtab.c (symbol_set_names): Change argument to be an
7881         objfile_per_bfd_storage.
7882         * psymtab.c (add_psymbol_to_bcache): Update.
7883         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7884
7885 2019-01-10  Tom Tromey  <tom@tromey.com>
7886
7887         * symtab.c (create_demangled_names_hash): Change argument to be an
7888         objfile_per_bfd_storage.
7889         (symbol_set_names): Update.
7890
7891 2019-01-10  Tom Tromey  <tom@tromey.com>
7892
7893         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7894         init_psymbol_list.
7895         * psymtab.c (init_psymbol_list): Do nothing if already called.
7896         * psympriv.h (init_psymbol_list): Add comment.
7897         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7898         init_psymbol_list.
7899         * dbxread.c (dbx_symfile_read): Unconditionally call
7900         init_psymbol_list.
7901
7902 2019-01-10  Tom Tromey  <tom@tromey.com>
7903
7904         * xcoffread.c (scan_xcoff_symtab): Update.
7905         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7906         "where".
7907         * mdebugread.c (parse_partial_symbols)
7908         (handle_psymbol_enumerators): Update.
7909         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7910         * dbxread.c (read_dbx_symtab): Update.
7911         * psympriv.h (psymbol_placement): New enum.
7912         (add_psymbol_to_list): Update.
7913
7914 2019-01-10  Tom Tromey  <tom@tromey.com>
7915
7916         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7917         static_psymbols parameters.
7918         (scan_xcoff_symtab): Update.
7919         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7920         static_psymbols parameters.
7921         * psympriv.h (start_psymtab_common): Update.
7922         * mdebugread.c (parse_partial_symbols): Update.
7923         * dwarf2read.c (create_partial_symtab): Update.
7924         * dbxread.c (read_dbx_symtab): Update.
7925         (start_psymtab): Remove global_psymbols and static_psymbols
7926         parameters.
7927
7928 2019-01-10  Tom Tromey  <tom@tromey.com>
7929
7930         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7931         * psymtab.c (allocate_psymtab): Add comment.
7932         * psympriv.h (allocate_psymtab): Add comment.
7933         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7934         initializations.
7935         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7936
7937 2019-01-10  Tom Tromey  <tom@tromey.com>
7938
7939         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7940         Don't declare.
7941         * mipsread.c: Include mdebugread.h.
7942         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7943         Declare.
7944         * elfread.c: Include mdebugread.h.
7945
7946 2019-01-09  Tom Tromey  <tom@tromey.com>
7947
7948         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7949         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7950         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7951         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7952         (psym_lookup_symbol, psym_find_last_source_symtab)
7953         (psym_forget_cached_source_info, psym_print_stats)
7954         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7955         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7956         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7957         (psym_find_compunit_symtab_by_address)
7958         (maintenance_print_psymbols, maintenance_info_psymtabs)
7959         (maintenance_check_psymtabs): Use ranged for.
7960         * psymtab.h (class objfile_psymtabs): New.
7961         (require_partial_symbols): Return objfile_psymtabs.
7962         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7963
7964 2019-01-09  Tom Tromey  <tom@tromey.com>
7965
7966         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7967         (find_pc_mapped_section, list_overlays_command)
7968         (map_overlay_command, unmap_overlay_command)
7969         (simple_overlay_update): Use all_objfiles.
7970         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7971         * printcmd.c (info_symbol_command): Use all_objfiles.
7972         * objfiles.h (ALL_OBJSECTIONS): Remove.
7973         * maint.c (maintenance_translate_address): Use all_objfiles.
7974         * gcore.c (gcore_create_callback): Use all_objfiles.
7975         (objfile_find_memory_regions): Likewise.
7976
7977 2019-01-09  Tom Tromey  <tom@tromey.com>
7978
7979         * symtab.c (find_line_symtab, info_sources_command)
7980         (make_source_files_completion_list): Use objfile_compunits.
7981         * source.c (select_source_symtab): Use objfile_compunits.
7982         * objfiles.h (struct objfile): Update comment.
7983         (ALL_OBJFILES): Remove.
7984         (ALL_FILETABS): Remove.
7985         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7986         objfile_compunits.
7987
7988 2019-01-09  Tom Tromey  <tom@tromey.com>
7989
7990         * symmisc.c (print_objfile_statistics, dump_objfile)
7991         (maintenance_print_symbols): Use compunit_filetabs.
7992         * source.c (forget_cached_source_info_for_objfile): Use
7993         compunit_filetabs.
7994         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7995         (ALL_FILETABS): Use compunit_filetabs.
7996         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7997         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7998
7999 2019-01-09  Tom Tromey  <tom@tromey.com>
8000
8001         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8002         (compunit_filetabs): New.
8003         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8004         compunit_filetabs.
8005         (info_sources_command, make_source_files_completion_list): Remove
8006         declaration.
8007         * symmisc.c (print_objfile_statistics, dump_objfile)
8008         (maintenance_print_symbols): Remove declaration.
8009         (maintenance_info_symtabs): Use compunit_filetabs.
8010         (maintenance_info_line_tables): Likewise.
8011         * source.c (select_source_symtab): Change local variable name.
8012         (forget_cached_source_info_for_objfile): Remove declaration.
8013         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8014         * objfiles.c (objfile_relocate1): Remove declaration.
8015         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8016         declaration.
8017         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8018         * coffread.c (coff_symtab_read): Remove declaration.
8019         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8020         compunit_filetabs.
8021
8022 2019-01-09  Tom Tromey  <tom@tromey.com>
8023
8024         * symtab.c (lookup_objfile_from_block)
8025         (find_pc_sect_compunit_symtab, search_symbols)
8026         (default_collect_symbol_completion_matches_break_on): Use
8027         objfile_compunits.
8028         * objfiles.h (ALL_COMPUNITS): Remove.
8029         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8030         * cp-support.c (add_symbol_overload_list_qualified): Use
8031         objfile_compunits.
8032         * ada-lang.c (ada_collect_symbol_completion_matches)
8033         (ada_add_global_exceptions): Use objfile_compunits.
8034
8035 2019-01-09  Tom Tromey  <tom@tromey.com>
8036
8037         * source.c (select_source_symtab)
8038         (forget_cached_source_info_for_objfile): Remove declaration.
8039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8040         declaration.
8041         * maint.c (count_symtabs_and_blocks): Remove declaration.
8042         * cp-support.c (add_symbol_overload_list_qualified): Remove
8043         declaration.
8044         * coffread.c (coff_symtab_read): Remove declaration.
8045         * symtab.c (lookup_symbol_in_objfile_symtabs)
8046         (basic_lookup_transparent_type_1): Use objfile_compunits.
8047         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8048         (info_sources_command, search_symbols)
8049         (default_collect_symbol_completion_matches_break_on)
8050         (make_source_files_completion_list): Remove declaration.
8051         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8052         (ada_collect_symbol_completion_matches)
8053         (ada_add_global_exceptions): Remove declaration.
8054         * linespec.c (iterate_over_all_matching_symtabs): Use
8055         objfile_compunits.
8056         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8057         (class objfile_compunits): New.
8058         (ALL_COMPUNITS): Use objfile_compunits.
8059         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8060         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8061         objfile_compunits.
8062         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8063
8064 2019-01-09  Tom Tromey  <tom@tromey.com>
8065
8066         * symtab.c (search_symbols)
8067         (default_collect_symbol_completion_matches_break_on): Use
8068         objfile_msymbols.
8069         * ada-lang.c (ada_lookup_simple_minsym)
8070         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8071         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8072         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8073         objfile_msymbols.
8074         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8075         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8076         * objc-lang.c (find_methods): Use objfile_msymbols.
8077         (info_selectors_command, info_classes_command): Likewise.
8078         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8079         * objfiles.h (class objfile_msymbols): New.
8080         (ALL_OBJFILE_MSYMBOLS): Remove.
8081         (ALL_MSYMBOLS): Remove.
8082
8083 2019-01-09  Tom Tromey  <tom@tromey.com>
8084
8085         * common/next-iterator.h (next_adapter): Add Iterator template
8086         parameter.
8087         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8088         (class all_objfiles_safe): New.
8089         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8090         * objfiles.c (put_objfile_before): Update comment.
8091         (add_separate_debug_objfile): Likewise.
8092         (free_all_objfiles): Use all_objfiles_safe.
8093         (objfile_purge_solibs): Likewise.
8094
8095 2019-01-09  Tom Tromey  <tom@tromey.com>
8096
8097         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8098         (expand_symtab_containing_pc, lookup_static_symbol)
8099         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8100         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8101         all_objfiles.
8102         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8103         * breakpoint.c (create_overlay_event_breakpoint)
8104         (create_longjmp_master_breakpoint)
8105         (create_std_terminate_master_breakpoint)
8106         (create_exception_master_breakpoint): Use all_objfiles.
8107         * linux-thread-db.c (try_thread_db_load_from_pdir)
8108         (has_libpthread): Use all_objfiles.
8109         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8110         * linespec.c (iterate_over_all_matching_symtabs)
8111         (search_minsyms_for_name): Use all_objfiles.
8112         * maint.c (maintenance_info_sections): Use all_objfiles.
8113         * main.c (captured_main_1): Use all_objfiles.
8114         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8115         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8116         * guile/scm-pretty-print.c
8117         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8118         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8119         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8120         (maintenance_print_msymbols): Use all_objfiles.
8121         * source.c (select_source_symtab): Use all_objfiles.
8122         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8123         * symfile.c (remove_symbol_file_command)
8124         (expand_symtabs_matching, map_symbol_filenames): Use
8125         all_objfiles.
8126         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8127         all_objfiles.
8128         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8129         * objc-lang.c (find_methods): Use all_objfiles.
8130         * objfiles.c (have_partial_symbols, have_full_symbols)
8131         (have_minimal_symbols, qsort_cmp)
8132         (default_iterate_over_objfiles_in_search_order): Use
8133         all_objfiles.
8134         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8135         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8136         (maintenance_check_psymtabs): Use all_objfiles.
8137         (ALL_PSYMTABS): Remove.
8138         * compile/compile-object-run.c (do_module_cleanup): Use
8139         all_objfiles.
8140         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8141         * cp-support.c (add_symbol_overload_list_qualified): Use
8142         all_objfiles.
8143         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8144         Use all_objfiles.
8145         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8146         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8147         all_objfiles.
8148         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8149         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8150         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8151         Uses all_objfiles.
8152         * solib.c (solib_read_symbols): Use all_objfiles
8153
8154 2019-01-09  Tom Tromey  <tom@tromey.com>
8155
8156         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8157         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8158         all_objfiles.
8159         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8160         * symmisc.c (print_symbol_bcache_statistics)
8161         (print_objfile_statistics, maintenance_print_objfiles)
8162         (maintenance_info_symtabs, maintenance_check_symtabs)
8163         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8164         all_objfiles.
8165         * source.c (forget_cached_source_info): Use all_objfiles.
8166         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8167         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8168         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8169         * objfiles.c (update_section_map): Use all_objfiles.
8170         (shared_objfile_contains_address_p): Likewise.
8171         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8172         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8173
8174 2019-01-09  Tom Tromey  <tom@tromey.com>
8175
8176         * common/next-iterator.h: New file.
8177         * objfiles.h (class all_objfiles): New.
8178         (struct objfile_iterator): New.
8179
8180 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8181
8182         * NEWS: Move the description of the changed "frame", "select-frame",
8183          and "info frame" commands to the Changed commands section.
8184
8185 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8186
8187         * gdbtypes.c (check_stub_method_group): Remove handling of old
8188         mangling schemes.
8189         * linespec.c (find_methods): Likewise.
8190         * stabsread.c (read_member_functions): Likewise.
8191         * valops.c (search_struct_method): Likewise.
8192         (value_struct_elt_for_reference): Likewise.
8193         * NEWS: Mention this change.
8194
8195 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8196
8197         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8198         print_source_lines.
8199         * source.c (print_source_lines_base): Update line number check.
8200         (print_source_lines): New function.
8201         (source_lines_range::source_lines_range): New function.
8202         * source.h (class source_lines_range): New class.
8203         (print_source_lines): New declaration.
8204
8205 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8206
8207         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8208
8209 2019-01-08  Tom Tromey  <tom@tromey.com>
8210             Simon Marchi  <simon.marchi@ericsson.com>
8211
8212         PR gdb/24060
8213         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8214         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8215         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8216         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8217         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8218         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8219
8220 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8221
8222         * source.c (select_source_symtab): Move header comment to
8223         declaration in source.h.
8224         (forget_cached_source_info_for_objfile): Likewise.
8225         (forget_cached_source_info): Likewise.
8226         (identify_source_line): Likewise.
8227         * source.h (identify_source_line): Move declaration from symtab.h
8228         and add comment from source.c
8229         (print_source_lines): Likewise.
8230         (forget_cached_source_info_for_objfile): Likewise.
8231         (forget_cached_source_info): Likewise.
8232         (select_source_symtab): Likewise.
8233         (enum print_source_lines_flag): Move definition from symtab.h.
8234         * symtab.h (identify_source_line): Move declaration to source.h.
8235         (print_source_lines): Likewise.
8236         (forget_cached_source_info_for_objfile): Likewise.
8237         (forget_cached_source_info): Likewise.
8238         (select_source_symtab): Likewise.
8239         (enum print_source_lines_flag): Move definition to source.h.
8240         * tui/tui-hooks.c: Add 'source.h' include.
8241
8242 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8243
8244         * source.c (print_source_lines_base): Handle requests to print
8245         reverse line number sequences, and guard against empty lines
8246         string.
8247
8248 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8249
8250         * source.c (print_source_lines_base): Fix skip of '\r' if next
8251         character is '\n'.
8252
8253 2019-01-06  Tom Tromey  <tom@tromey.com>
8254
8255         * c-exp.y (struct c_parse_state) <macro_original_text,
8256         expansion_obstack>: New member.
8257         (macro_original_text, expansion_obstack): Remove globals.
8258         (scan_macro_expansion, scanning_macro_expansion)
8259         (finished_macro_expansion): Update.
8260         (scan_macro_cleanup): Remove.
8261         (yylex, c_parse): Update.
8262
8263 2019-01-06  Tom Tromey  <tom@tromey.com>
8264
8265         * c-exp.y (struct c_parse_state) <strings>: New member.
8266         (operator_stoken): Update.
8267
8268 2019-01-06  Tom Tromey  <tom@tromey.com>
8269
8270         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8271         (union type_stack_elt) <typelist_val>: Now a pointer to
8272         std::vector.
8273         (type_stack_cleanup): Don't declare.
8274         (push_typelist): Update.
8275         * parse.c (pop_typelist): Return a std::vector.
8276         (push_typelist): Take a std::vector.
8277         (follow_types): Update.  Do not free args.
8278         (type_stack_cleanup): Remove.
8279         * c-exp.y (struct c_parse_state): New.
8280         (cpstate): New global.
8281         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8282         (nonempty_typelist): Update.
8283         (func_mod): Create a new vector.
8284         (c_parse): Create a c_parse_state.
8285         (check_parameter_typelist): Do not delete params.
8286         (function_method): Update.  Do not delete type_list.
8287
8288 2019-01-06  Tom Tromey  <tom@tromey.com>
8289
8290         PR gdb/28155:
8291         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8292         check_typedef.
8293         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8294         (print_return_value): Likewise.
8295
8296 2019-01-05  Tom Tromey  <tom@tromey.com>
8297
8298         * contrib/cleanup_check.py: Remove.
8299         * contrib/gcc-with-excheck: Remove.
8300         * contrib/exsummary.py: Remove.
8301         * contrib/excheck.py: Remove.
8302
8303 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8304
8305         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8306         NULL. Initialize tpprev to NULL instead of assigning it
8307         to NULL on the next statement.
8308         * windows-nat.c (windows_delete_thread): Remove check for
8309         main_thread_id before printing thread exit notifications.
8310         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8311         Remove thread ID check against main_thread_id.
8312         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8313         windows_delete_thread.
8314         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8315
8316 2019-01-04  Tom Tromey  <tom@tromey.com>
8317
8318         * compile/compile.c (_initialize_compile): Use upper case for
8319         metasyntactic variables.
8320         * symmisc.c (_initialize_symmisc): Use upper case for
8321         metasyntactic variables.
8322         * psymtab.c (_initialize_psymtab): Use upper case for
8323         metasyntactic variables.
8324         * demangle.c (demangle_command): Use upper case for metasyntactic
8325         variables.
8326         (_initialize_demangler): Likewise.
8327         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8328         variables.
8329
8330 2019-01-03  Tom Tromey  <tom@tromey.com>
8331
8332         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8333
8334 2019-01-03  Tom Tromey  <tom@tromey.com>
8335
8336         * python/py-symtab.c (salpy_str): Update.
8337         (struct salpy_sal_object) <symtab>: Now a PyObject.
8338         (salpy_dealloc): Update.
8339         (del_objfile_sal): Use gdbpy_ref.
8340
8341 2019-01-03  Tom Tromey  <tom@tromey.com>
8342
8343         * python/py-type.c (convert_field): Use new_reference.  Return
8344         gdbpy_ref.
8345         (make_fielditem): Return gdbpy_ref.
8346         (typy_fields): Update.
8347         (typy_getitem): Update.
8348         (field_name): Return gdbpy_ref.  Use new_reference.
8349         (typy_iterator_iternext): Update.
8350
8351 2019-01-03  Tom Tromey  <tom@tromey.com>
8352
8353         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8354
8355 2019-01-03  Tom Tromey  <tom@tromey.com>
8356
8357         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8358         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8359         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8360         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8361         (pspy_set_type_printers): Likewise.
8362         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8363         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8364         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8365         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8366         (objfpy_set_type_printers): Likewise.
8367
8368 2019-01-03  Tom Tromey  <tom@tromey.com>
8369
8370         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8371         (gdbpy_print_stack): Use gdbpy_err_fetch.
8372         * python/python-internal.h (class gdbpy_err_fetch): New class.
8373         (class gdbpy_enter) <m_error_type, m_error_value,
8374         m_error_traceback>: Remove.
8375         <m_error>: New member.
8376         (gdbpy_exception_to_string): Don't declare.
8377         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8378         * python/py-value.c (convert_value_from_python): Use
8379         gdbpy_err_fetch.
8380         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8381         gdbpy_exception_to_string.
8382         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8383         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8384         gdbpy_err_fetch.
8385
8386 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8387
8388         * linux-nat.c (delete_lwp_cleanup): Delete.
8389         (struct lwp_deleter): New struct.
8390         (lwp_info_up): New typedef.
8391         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8392         lwp_info_up.
8393
8394 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * linux-fork.c (class scoped_switch_fork_info): New class.
8397         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8398
8399 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8400
8401         * valops.c (find_overload_match): Remove use of null_cleanup, and
8402         calls to do_cleanups.
8403
8404 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8405
8406         * compile/compile-cplus-types.c
8407         (compile_cplus_instance::decl_name): Handle changes to
8408         cp_func_name.
8409         * cp-support.c (cp_func_name): Update header comment, update
8410         return type.
8411         * cp-support.h (cp_func_name): Update return type in declaration.
8412         * valops.c (find_overload_match): Move temp_func local to top
8413         level of function and change its type.  Use temp_func to hold and
8414         delete temporary string obtained from cp_func_name.
8415
8416 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8417
8418         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8419         gdb::char_vector, remove cleanup, and update uses of `msg`.
8420
8421 2019-01-03  Jim Wilson  <jimw@sifive.com>
8422
8423         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8424
8425 2019-01-02  Tom Tromey  <tom@tromey.com>
8426
8427         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8428         (tdesc_parse_xml): Remove cleanups.
8429         * target-descriptions.h (make_cleanup_free_target_description):
8430         Don't declare.
8431         (target_desc_deleter): New struct.
8432         (target_desc_up): New typedef.
8433         * target-descriptions.c (target_desc_deleter::operator()): Rename
8434         from free_target_description.
8435         (make_cleanup_free_target_description): Remove.
8436
8437 2019-01-02  Tom Tromey  <tom@tromey.com>
8438
8439         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8440         constructor, destructor.
8441         (linespec_parser): Remove typedef.
8442         (~linespec_parser): Rename from linespec_parser_delete.
8443         (linespec_lex_to_end, linespec_complete_label)
8444         (linespec_complete): Update.
8445         (decode_line_full): Remove cleanups.
8446         (decode_line_1): Update.
8447
8448 2019-01-02  Tom Tromey  <tom@tromey.com>
8449
8450         * python/python-internal.h (inferior_to_inferior_object): Change
8451         return type.
8452         * python/py-exitedevent.c (create_exited_event_object): Update.
8453         * python/py-inferior.c (inferior_to_inferior_object): Return
8454         gdbpy_ref.
8455         (python_new_inferior, python_inferior_deleted)
8456         (thread_to_thread_object, delete_thread_object)
8457         (build_inferior_list, gdbpy_selected_inferior): Update.
8458         * python/py-infthread.c (create_thread_object): Update.  Also fail
8459         if inferior_to_inferior_object fails.
8460
8461 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8462
8463         * inferior.h (class inferior) <displaced_step_state>: New field.
8464         * infrun.h (struct displaced_step_state): Move here from
8465         infrun.c.  Initialize fields, add constructor.
8466         <inf>: Remove field.
8467         <reset>: New method.
8468         * infrun.c (struct displaced_step_inferior_state): Move to
8469         infrun.h.
8470         (displaced_step_inferior_states): Remove.
8471         (get_displaced_stepping_state): Adust.
8472         (displaced_step_in_progress_any_inferior): Adjust.
8473         (displaced_step_in_progress_thread): Adjust.
8474         (displaced_step_in_progress): Adjust.
8475         (add_displaced_stepping_state): Remove.
8476         (get_displaced_step_closure_by_addr): Adjust.
8477         (remove_displaced_stepping_state): Remove.
8478         (infrun_inferior_exit): Call displaced_step_state.reset.
8479         (use_displaced_stepping): Don't check for NULL.
8480         (displaced_step_prepare_throw): Call
8481         get_displaced_stepping_state.
8482         (displaced_step_fixup): Don't check for NULL.
8483         (prepare_for_detach): Don't check for NULL.
8484
8485 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8486
8487         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8488          in case of call that did not complete.
8489
8490 2019-01-02  Andrey Utkin  <autkin@undo.io>
8491
8492         * symfile.c (find_separate_debug_file): Fix search of debug files for
8493         remote debuggee.
8494
8495 2019-01-02  Tom Tromey  <tom@tromey.com>
8496
8497         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8498         indentation.
8499         * python/py-frame.c (frapy_older): Remove cast.
8500         (frapy_newer): Likewise.
8501         * python/py-breakpoint.c (local_setattro): Remove cast.
8502         * python/py-arch.c (archpy_name): Remove local variable.
8503         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8504
8505 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8506
8507         * unittests/basic_string_view/element_access/char/empty.cc:
8508         Fix year range in copyright header.
8509
8510 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8511
8512         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8513         Delete.
8514         <operator==>: Update with for removed field.
8515         <hash>: Likewise.
8516         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8517         <isa_features>: ...this.
8518         <abi_features>: New field.
8519         (riscv_isa_flen): Update comment.
8520         (riscv_abi_xlen): New declaration.
8521         (riscv_abi_flen): New declaration.
8522         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8523         isa_features.
8524         (riscv_abi_xlen): New function.
8525         (riscv_isa_flen): Update to get answer from isa_features.
8526         (riscv_abi_flen): New function.
8527         (riscv_has_fp_abi): Update to get answer from abi_features.
8528         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8529         xlen and flen.
8530         (riscv_call_info) <xlen, flen>: Update comment.
8531         (riscv_call_arg_struct): Remove invalid assertions
8532         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8533         is removed.
8534         (riscv_gdbarch_init): Gather isa features and abi features
8535         separately, ensure both match on the gdbarch when reusing an old
8536         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8537         a target with 64-bit float hardware.
8538
8539 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8540
8541         * source.c (search_command_helper): Stop reverse search
8542         when line 1 has been searched.
8543
8544 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8545
8546         * record-full.c (record_full_base_target::close): Rewrite
8547         record_full_core_buf_list free logic.
8548
8549 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8550
8551         * break-catch-syscall.c (print_one_catch_syscall): xfree
8552         the last text.
8553
8554 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8555
8556         * top.c (print_gdb_version): Update Copyright year in version
8557         message.
8558
8559 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8560
8561         Update copyright year range in all GDB files.
8562
8563 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8564
8565         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8566
8567 For older changes see ChangeLog-2018.
8568 \f
8569 Local Variables:
8570 mode: change-log
8571 left-margin: 8
8572 fill-column: 74
8573 version-control: never
8574 coding: utf-8
8575 End:
8576