gdb/ChangeLog

   1 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
   2
   3         * blockframe.c (find_pc_partial_function): Set *block to nullptr
   4         when the function fails.
   5
   6 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
   7
   8         * s390-tdep.c (s390_type_align): New function.
   9         (s390_gdbarch_init): Set it as type_align gdbarch method.
  10
  11 2019-08-09  Tom de Vries  <tdevries@suse.de>
  12
  13         PR gdb/24591
  14         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
  15         pc_low with relocation offset.
  16
  17 2019-08-07  Tom Tromey  <tromey@adacore.com>
  18
  19         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
  20         (print_frame_args): Update.
  21         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
  22         Update.
  23         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
  24         * frame.h (struct frame_arg): Add initializers.
  25         <error>: Now a unique_xmalloc_ptr.
  26
  27 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
  28
  29         * NEWS: Expand the Pointer Authentication entry.
  30         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
  31         (aarch64_frame_unmask_lr): ... to this.
  32         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
  33         Call aarch64_frame_unmask_lr.
  34         * frame.c (struct frame_info): Add "masked" variable.
  35         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
  36         (fprint_frame): Check for masked pc.
  37         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
  38         declarations.
  39         * python/py-framefilter.c (py_print_frame): Check for masked pc.
  40         * stack.c (print_frame): Check for masked pc.
  41
  42 2019-08-06  Tom Tromey  <tom@tromey.com>
  43
  44         * stabsread.c (patch_block_stabs, read_one_struct_field)
  45         (read_enum_type): Use obstack_strndup.
  46         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
  47         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
  48         * dwarf2read.c (guess_full_die_structure_name)
  49         (anonymous_struct_prefix): Use obstack_strndup.
  50         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
  51         * c-exp.y (yylex): Use obstack_strndup.
  52         * ada-exp.y (write_object_renaming, write_ambiguous_var)
  53         (write_var_or_type): Use obstack_strndup.
  54
  55 2019-08-06  Tom Tromey  <tom@tromey.com>
  56
  57         * symfile.c (reread_symbols): Use obstack_strdup.
  58         * stabsread.c (read_type): Use obstack_strdup.
  59         * gdb_obstack.h (obstack_strdup): New overload.
  60         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
  61         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
  62         (dwarf2_canonicalize_name): Use obstack_strdup.
  63         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
  64         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
  65         Use obstack_strdup.
  66
  67 2019-08-06  Tom Tromey  <tom@tromey.com>
  68
  69         * gdb_obstack.h (obstack_strdup): Define.
  70         * gdb_obstack.c (obstack_strdup): Don't define.
  71
  72 2019-08-06  Tom Tromey  <tom@tromey.com>
  73
  74         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
  75         obstack_strdup.
  76         * typeprint.c (typedef_hash_table::find_global_typedef): Use
  77         obstack_strdup.
  78         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
  79         * stabsread.c (common_block_start): Use obstack_strdup.
  80         * objfiles.c (set_objfile_main_name, objfile): Use
  81         obstack_strdup.
  82         * namespace.c (add_using_directive): Use obstack_strdup.
  83         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
  84         * jit.c (finalize_symtab): Use obstack_strdup.
  85         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
  86         (guess_partial_die_structure_name, partial_die_info::fixup)
  87         (dwarf2_name): Use obstack_strdup.
  88         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
  89         obstack_strdup.
  90         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
  91         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
  92         obstack_strdup.
  93         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
  94
  95 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  96
  97         * unittests/help-doc-selftests.c: New file.
  98         * Makefile.in: Add the new file.
  99
 100 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 101
 102         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 103         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 104         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 105         the trailing '.' is not output, and the first character is uppercased.
 106         (print_help_for_command): Update call to print_doc_line.
 107         (print_doc_of_command): Likewise.
 108         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 109         * cli/cli-option.c (append_indented_doc): Do not append newline.
 110         (build_help_option): Append newline after first appended_indented_doc
 111         only if a second call is done.
 112         (build_help): Append 2 new lines before each option, except the first
 113         one.
 114         * compile/compile.c (_initialize_compile): Add new lines after
 115         %OPTIONS%, when not at the end of the help.
 116         Change help doc or code
 117         producing the help doc to respect the invariants.
 118         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 119         Also removed the new line after 'Options:', as all other commands
 120         do not put an empty line between 'Options:' and the first option.
 121         * printcmd.c (_initialize_printcmd): Likewise.
 122         * stack.c (_initialize_stack): Likewise.
 123         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 124         incorrectly telling COMMAND is optional.
 125         * ada-lang.c (_initialize_ada_language): Change help doc or code
 126         producing the help doc to respect the invariants.
 127         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 128         * breakpoint.c (_initialize_breakpoint): Likewise.
 129         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 130         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 131         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 132         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 133         _initialize_cli_style): Likewise.
 134         * corelow.c (core_target_info): Likewise.
 135         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 136         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 137         * filesystem.c (_initialize_filesystem): Likewise.
 138         * frame.c (_initialize_frame): Likewise.
 139         * gnu-nat.c (add_task_commands): Likewise.
 140         * infcall.c (_initialize_infcall): Likewise.
 141         * infcmd.c (_initialize_infcmd): Likewise.
 142         * interps.c (_initialize_interpreter): Likewise.
 143         * language.c (_initialize_language): Likewise.
 144         * linux-fork.c (_initialize_linux_fork): Likewise.
 145         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 146         * maint.c (_initialize_maint_cmds): Likewise.
 147         * memattr.c (_initialize_mem): Likewise.
 148         * printcmd.c (_initialize_printcmd): Likewise.
 149         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 150         _RegEx): Likewise.
 151         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 152         * record-btrace.c (_initialize_record_btrace): Likewise.
 153         * record-full.c (_initialize_record_full): Likewise.
 154         * record.c (_initialize_record): Likewise.
 155         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 156         * regcache.c (_initialize_regcache): Likewise.
 157         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 158         _initialize_remote): Likewise.
 159         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 160         * serial.c (_initialize_serial): Likewise.
 161         * skip.c (_initialize_step_skip): Likewise.
 162         * source.c (_initialize_source): Likewise.
 163         * stack.c (_initialize_stack): Likewise.
 164         * symfile.c (_initialize_symfile): Likewise.
 165         * symtab.c (_initialize_symtab): Likewise.
 166         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 167         * top.c (init_main): Likewise.
 168         * tracefile-tfile.c (tfile_target_info): Likewise.
 169         * tracepoint.c (_initialize_tracepoint): Likewise.
 170         * tui/tui-win.c (_initialize_tui_win): Likewise.
 171         * utils.c (add_internal_problem_command): Likewise.
 172         * valprint.c (value_print_option_defs): Likewise.
 173
 174 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 175
 176         PR build/24886
 177         * configure.ac: Drop enable-libmcheck support.
 178         * configure, config.in: Rebuild.
 179         * libmcheck.m4: Remove.
 180         * acinclude.m4: Don't include it.
 181         * Makefile.in: Don't distribute it.
 182         * top.c (print_gdb_configuration): Don't mention it.
 183
 184 2019-08-06  Tom Tromey  <tom@tromey.com>
 185
 186         * utils.c (set_output_style): Sometimes pass stream to
 187         emit_style_escape.
 188         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 189         * record-btrace.c (btrace_insn_history): Update.
 190         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 191         method.
 192         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 193         Update initializers.
 194         <m_uiout>: New field.
 195         <m_di>: Move lower.
 196         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 197         Remove "uiout" parameter.
 198         (dump_insns): Update.
 199         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 200         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 201
 202 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 203
 204         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 205         (error_in_psymtab_expansion): Likewise.
 206         (lookup_symbol_via_quick_fns): Likewise.
 207         (basic_lookup_transparent_type_quick): Likewise.
 208         (basic_lookup_transparent_type_1): Likewise.
 209
 210 2019-08-06  Tom Tromey  <tromey@adacore.com>
 211
 212         * source.c (last_source_error): Now bool.
 213         (print_source_lines_base): Make "noprint" bool.  Only open
 214         source file when last_source_visited changes.
 215
 216 2019-08-06  Tom Tromey  <tromey@adacore.com>
 217
 218         * annotate.c (annotate_source_line): Use g_source_cache.
 219         * source-cache.c (source_cache::get_plain_source_lines): Change
 220         parameters.  Populate m_offset_cache.
 221         (source_cache::ensure): New method.
 222         (source_cache::get_line_charpos): New method.
 223         (extract_lines): Move lower.  Change parameters.
 224         (source_cache::get_source_lines): Move lower.
 225         * source-cache.h (class source_cache): Update comment.
 226         <get_line_charpos>: New method.
 227         <get_source_lines>: Update comment.
 228         <clear>: Clear m_offset_cache.
 229         <get_plain_source_lines>: Change parameters.
 230         <ensure>: New method
 231         <m_offset_cache>: New member.
 232         * source.c (forget_cached_source_info_for_objfile): Update.
 233         (info_source_command): Use g_source_cache.
 234         (find_source_lines, open_source_file_with_line_charpos): Remove.
 235         (print_source_lines_base, search_command_helper): Use g_source_cache.
 236         * source.h (open_source_file_with_line_charpos): Don't declare.
 237         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 238         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 239         Use g_source_cache.
 240
 241 2019-08-06  Tom Tromey  <tromey@adacore.com>
 242
 243         * source-cache.c (source_cache::get_plain_source_lines):
 244         Remove "first_line" and "last_line" parameters.
 245         (source_cache::get_source_lines): Cache plain text.
 246         * source-cache.h (class source_cache)
 247         <get_plain_source_lines>: Update.
 248
 249 2019-08-06  Tom Tromey  <tromey@adacore.com>
 250
 251         * source-cache.c (extract_lines): No longer a method.
 252         Changed type of parameter.  Include final newline.
 253         (selftests::extract_lines_test): New function.
 254         (_initialize_source_cache): Likewise.
 255         * source-cache.h (class source_cache)
 256         <extract_lines>: Don't declare.
 257
 258 2019-08-06  Tom Tromey  <tromey@adacore.com>
 259
 260         * breakpoint.c (init_breakpoint_sal): Update.
 261         (breakpoint): Update.
 262         * breakpoint.h (struct breakpoint) <filter>: Now a
 263         unique_xmalloc_ptr.
 264
 265 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 266
 267         * NEWS: Mention dictionary access on blocks.
 268         * python/py-block.c (blpy_getitem): New function.
 269         (block_object_as_mapping): New struct.
 270         (block_object_type): Use new struct for tp_as_mapping field.
 271
 272 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 273
 274         * objfiles.h (objfile): Add a comment describing partial symbols.
 275
 276 2019-08-05  Tom Tromey  <tromey@adacore.com>
 277
 278         * compile/compile.c (_initialize_compile): Use _(), not N_().
 279         * thread.c (_initialize_thread): Use _(), not N_().
 280         * stack.c (_initialize_stack): Use _(), not N_().
 281         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 282
 283 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 284
 285         * dwarf2read.c (struct dw2_symtab_iterator):
 286         <want_specific_block>: Remove.
 287         <block_index>: Change type to gdb::optional.
 288         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 289         change type of BLOCK_INDEX parameter to gdb::optional.
 290         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 291         (dw2_lookup_symbol): Don't pass argument for
 292         WANT_SPECIFIC_BLOCK.
 293         (dw2_expand_symtabs_for_function): Don't pass argument for
 294         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 295         (class dw2_debug_names_iterator)
 296         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 297         parameter, change BLOCK_INDEX type to gdb::optional.
 298         <m_want_specific_block>: Remove.
 299         <m_block_index>: Change type to gdb::optional.
 300         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 301         gdb::optional.  Re-write in function of gdb::optional.
 302         (dw2_debug_names_lookup_symbol): Don't pass argument for
 303         WANT_SPECIFIC_BLOCK.
 304         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 305         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 306         BLOCK_INDEX.
 307
 308 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 309
 310         * NEWS: Mention changes to "info sources" command.
 311
 312 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 313
 314         * symtab.c (filename_partial_match_opts): New struct type.
 315         (struct output_source_filename_data): New members
 316         regexp, c_regexp, partial_match.
 317         (output_source_filename): Use new members to decide to print file.
 318         (info_sources_option_defs): New variable.
 319         (make_info_sources_options_def_group, print_info_sources_header,
 320         info_sources_command_completer):
 321         New functions.
 322         (info_sources_command): Read new optional arguments.
 323         (_initialize_symtab): Update info sources help.
 324
 325 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 326
 327         * ada-lang.c (exception_support_info_v0): Renamed from...
 328         (default_exception_support_info): ... this.  Create new
 329         definition for v1.
 330         (ada_has_this_exception_support): Look up catch_handlers_sym.
 331         (ada_exception_support_info_sniffer): Try v0 after default.
 332
 333 2019-08-01  Tom Tromey  <tromey@adacore.com>
 334
 335         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 336         gdbarch.h.
 337
 338 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 339
 340         * s12z-tdep.c: Fix include path for s12z-opc.h.
 341
 342 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 343
 344         * NEWS: Require GNU make 3.82.
 345
 346 2019-07-16  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 349         declare.
 350
 351 2019-07-30  Tom Tromey  <tromey@adacore.com>
 352
 353         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 354
 355 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 356
 357         * printcmd.c (print_address_symbolic): Print negative offsets.
 358         (build_address_symbolic): Force signed arithmetic when computing
 359         offset.
 360
 361 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 362
 363         PR/24474: Add a function to lookup static variables.
 364         * NEWS: Mention this new function.
 365         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 366         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 367         * python/python.c (python_GdbMethods): Add new function.
 368
 369 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 370
 371         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 372         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 373         (objfpy_lookup_static_symbol): New function.
 374         (objfile_object_methods): Add new functions.
 375
 376 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 377
 378         * NEWS: Mention 'set|show print frame-info'.  Mention new
 379         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 380         backtrace argument.  Mention that python frame filtering code
 381         is now consistent with what 'backtrace' command prints.
 382
 383 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 384
 385         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 386         comments.
 387         (print_frame_info_auto, print_frame_info_source_line,
 388         print_frame_info_location, print_frame_info_source_and_location,
 389         print_frame_info_location_and_address, print_frame_info_short_location):
 390         New declarations.
 391         (struct frame_print_options): New member print_frame_info.
 392         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 393         * stack.h (get_user_print_what_frame_info): New declaration.
 394         (frame_show_address): New declaration.
 395         * stack.c (print_frame_arguments_choices): New value 'presence'.
 396         (print_frame_info_auto, print_frame_info_source_line,
 397         print_frame_info_location, print_frame_info_source_and_location,
 398         print_frame_info_location_and_address, print_frame_info_short_location,
 399         print_frame_info_choices, print_frame_info_print_what): New definitions.
 400         (print_frame_args): Only print dots for args if print frame-arguments
 401         is 'presence'.
 402         (frame_print_option_defs): New element for "frame-info".
 403         (get_user_print_what_frame_info): New function.
 404         (frame_show_address): Make non static.  Move comment to stack.h.
 405         (print_frame_info_to_print_what): New function.
 406         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 407         to decide what to print.
 408         (backtrace_command_1): Handle the new print_frame_arguments_presence
 409         value.
 410         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 411         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 412         (py_print_frame): In non-mi mode, use LOCATION as default for
 413         print_what, similarly to frame information printed directly by
 414         backtrace command. Handle frame-info user option in non MI mode.
 415
 416 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 417
 418         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 419         Add case for debugging 32-bit target on 64-bit host.  Revise
 420         comment.
 421
 422 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 423
 424         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 425         instead of find_function_entry_range_from_pc.
 426
 427 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 428
 429         * stack.c (find_frame_funname): Remove code which preferred
 430         minsym over symtab sym in "certain pathological cases".
 431
 432         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 433         parameter.  Change type of "do_demangle" to bool.
 434         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 435         Pass suitable "prefer_sym_over_minsym" flag to
 436         build_address_symbolic().  Don't output "+" for negative offsets.
 437         * printcmd.c (print_address_symbolic): Update invocation of
 438         build_address_symbolic to include a "prefer_sym_over_minsym"
 439         flag.
 440         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 441         Restrict cases in which use of minimal symbol is preferred to that
 442         of a found symbol.  Update comments.
 443
 444         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 445         for entry pc when entry pc is out of range for that FDE.
 446
 447 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 448
 449         PR gdb/24839:
 450         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 451         type.
 452
 453 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 454
 455         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 456         this function's Python signature.
 457
 458
 459 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 460
 461         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 462         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 463         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 464         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 465         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 466
 467
 468 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 469
 470         * h8300-tdep.c (h8300_register_name_common): New.
 471         h8300_register_name): Use h8300_register_name_common.
 472         (h8300s_register_name): Likewise.
 473         (h8300sx_register_name): Likewise.
 474         (h8300h_register_nam): New.
 475         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 476
 477
 478 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 479
 480         * arm-tdep.c (arm_skip_cmse_entry): New function.
 481         (arm_is_sgstubs_section): New function.
 482         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 483
 484 2019-07-22  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 487         Don't self-assign.
 488
 489 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 490
 491         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 492         type_print.
 493
 494 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 495
 496         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 497         so that GDB doesn't match any msymbols when searching in the
 498         TYPES_DOMAIN.
 499         (print_symbol_info): Print using typedef_print or type_print based
 500         on the type of the symbol.  Add updated FIXME comment moved from...
 501         (_initialize_symtab): ... move and update FIXME comment to above.
 502
 503 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * NEWS: Mention adding -q option to "info types".
 506         * symtab.c (struct info_types_options): New struct.
 507         (info_types_options_defs): New variable.
 508         (make_info_types_options_def_group): New function.
 509         (info_types_command): Use gdb::option framework to parse options.
 510         (info_types_command_completer): New function.
 511         (_initialize_symtab): Extend the help text on "info types" and
 512         register command completer.
 513
 514 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 515
 516         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 517         (lookup_symbol_in_objfile): Change int to block_enum and add a
 518         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 519
 520 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 521
 522         * MAINTAINERS (Write After Approval): Add self.
 523
 524 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 525
 526         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 527         instruction to the dummy code region.
 528
 529 2019-07-19  Tom Tromey  <tromey@adacore.com>
 530
 531         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 532         (ARGSUSED, PARAMS, __func__): Remove rules.
 533
 534 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 535
 536         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 537         * features/arm/arm-with-iwmmxt.c: Remove.
 538         * features/arm/arm-with-iwmmxt.xml: Remove.
 539         * features/arm/arm-with-m-fpa-layout.c: Remove.
 540         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 541         * features/arm/arm-with-m-vfp-d16.c: Remove.
 542         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 543         * features/arm/arm-with-m.c: Remove.
 544         * features/arm/arm-with-m.xml: Remove.
 545         * features/arm/arm-with-neon.c: Remove.
 546         * features/arm/arm-with-neon.xml: Remove.
 547         * features/arm/arm-with-vfpv2.c: Remove.
 548         * features/arm/arm-with-vfpv2.xml: Remove.
 549         * features/arm/arm-with-vfpv3.c: Remove.
 550         * features/arm/arm-with-vfpv3.xml: Remove.
 551
 552 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 553
 554         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 555
 556 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 557
 558         * arch/aarch32.c (aarch32_create_target_description): Create
 559         target descriptions using features.
 560         * arch/arm.c (arm_create_target_description)
 561         (arm_create_mprofile_target_description): Likewise.
 562         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 563
 564 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 565
 566         * Makefile.in: Add new files.
 567         * aarch32-tdep.c: New file.
 568         * aarch32-tdep.h: New file.
 569         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 570         Call aarch32_read_description.
 571         * arch/aarch32.c: New file.
 572         * arch/aarch32.h: New file.
 573         * arch/arm.c (arm_create_target_description)
 574         (arm_create_mprofile_target_description): New function.
 575         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 576         (arm_create_target_description)
 577         (arm_create_mprofile_target_description): New declaration.
 578         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 579         read_description functions.
 580         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 581         Likewise.
 582         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 583         * arm-tdep.c (tdesc_arm_list): New variable.
 584         (arm_register_g_packet_guesses): Call create description functions.
 585         (arm_read_description) (arm_read_mprofile_description): New
 586         function.
 587         * arm-tdep.h (arm_read_description)
 588         (arm_read_mprofile_description): Add declaration.
 589         * configure.tgt: Add new files.
 590
 591 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 592
 593         * top.c (new_ui_command): Open specified terminal just once.
 594
 595 2019-07-18  Tom Tromey  <tromey@adacore.com>
 596
 597         * symtab.c (main_name): Constify return type.
 598         * symfile.c (set_initial_language): Update.
 599         * symtab.h (main_name): Constify return type.
 600
 601 2019-07-17  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-winsource.c (tui_update_source_window)
 604         (tui_update_source_window_as_is)
 605         (tui_update_source_windows_with_line): Remove return.
 606         * tui/tui-disasm.c (tui_show_disassem)
 607         (tui_show_disassem_and_update_source): Remove return.
 608         * tui/tui.c (tui_reset): Remove return.
 609         * tui/tui-wingeneral.c
 610         (tui_check_and_display_highlight_if_needed): Remove return.
 611
 612 2019-07-17  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 615
 616 2019-07-17  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-winsource.h (struct tui_exec_info_window)
 619         (struct tui_source_window_base): Move from tui-data.h.
 620         * tui/tui-winsource.c: Move many method definitions from
 621         elsewhere.  Remove "structuring" comments.
 622         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 623         (tui_source_window_base::refresh_window): Move to
 624         tui-winsource.c.
 625         * tui/tui-win.c (tui_source_window_base::refresh_all)
 626         (tui_source_window_base::update_tab_width)
 627         (tui_source_window_base::set_new_height)
 628         (tui_source_window_base::do_make_visible_with_new_height): Move to
 629         tui-winsource.c.
 630         * tui/tui-source.h: Update.
 631         * tui/tui-source.c (tui_source_window_base::reset): Move to
 632         tui-winsource.c.
 633         * tui/tui-disasm.h: Update.
 634         * tui/tui-data.h (struct tui_exec_info_window): Move to
 635         tui-winsource.h.
 636         (struct tui_source_window_base): Likewise.
 637         * tui/tui-data.c (tui_source_window_base::clear_detail)
 638         (tui_source_window_base, ~tui_source_window_base): Move to
 639         tui-winsource.c.
 640
 641 2019-07-17  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-win.c (tui_resize_all)
 644         (tui_source_window_base::update_tab_width)
 645         (tui_adjust_win_heights): Update.
 646         (tui_win_info::make_invisible_and_set_new_height): Rename from
 647         make_invisible_and_set_new_height.
 648         * tui/tui-data.h (struct tui_win_info)
 649         <make_invisible_and_set_new_height>: New method.
 650
 651 2019-07-17  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui.c: Update.
 654         * tui/tui-source.h (struct tui_source_window): Move from
 655         tui-data.h.
 656         * tui/tui-layout.c: Update.
 657         * tui/tui-disasm.c: Update.
 658         * tui/tui-data.h (struct tui_source_window): Move to
 659         tui-source.h.
 660
 661 2019-07-17  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 664         tui-data.h.
 665         * tui/tui-data.h (struct tui_disasm_window): Move to
 666         tui-disasm.h.
 667
 668 2019-07-17  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-regs.h (struct tui_data_item_window): Move from
 671         tui-data.h.
 672         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 673         * tui/tui-data.h (struct tui_data_item_window): Move to
 674         tui-regs.h.
 675         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 676
 677 2019-07-17  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui.c: Update.
 680         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 681         (tui_cmd_window::max_height): Move to tui-command.c.
 682         * tui/tui-layout.c: Update.
 683         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 684         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 685         tui-command.c.
 686         * tui/tui-command.h (struct tui_cmd_window): Move from
 687         tui-data.h.
 688         * tui/tui-command.c: Remove "structuring" comments.
 689         (tui_cmd_window::clear_detail)
 690         (tui_cmd_window::do_make_visible_with_new_height)
 691         (tui_cmd_window::max_height): Move from elsewhere.
 692
 693 2019-07-17  Tom Tromey  <tom@tromey.com>
 694
 695         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 696         Now static.
 697         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 698         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 699
 700 2019-07-17  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui.c: Update.
 703         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 704         tui-regs.c.
 705         * tui/tui-windata.h: Remove file.
 706         * tui/tui-windata.c: Remove file.
 707         * tui/tui-win.c (tui_data_window::set_new_height)
 708         (tui_data_window::do_make_visible_with_new_height): Move to
 709         tui-regs.c.
 710         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 711         * tui/tui-regs.c: Remove "structuring" comments.
 712         (tui_data_window::first_data_item_displayed)
 713         (tui_data_window::delete_data_content_windows)
 714         (tui_data_window::erase_data_content)
 715         (tui_data_window::display_all_data)
 716         (tui_data_window::refresh_all)
 717         (tui_data_window::do_scroll_vertical)
 718         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 719         (tui_data_window::do_make_visible_with_new_height)
 720         (tui_data_window::refresh_window): Move from elsewhere.
 721         (_initialize_tui_regs): Move to end of file.
 722         * tui/tui-layout.c: Update.
 723         * tui/tui-hooks.c: Update.
 724         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 725         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 726         tui-regs.c.
 727         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 728
 729 2019-07-17  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 732         seen.
 733
 734 2019-07-17  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-win.c (tui_source_window_base::set_new_height)
 737         (tui_source_window_base::do_make_visible_with_new_height): Use
 738         m_has_locator field directly.
 739         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 740         method.
 741         (struct tui_source_window_base) <has_locator>: Likewise.
 742
 743 2019-07-17  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 746         Don't declare.
 747         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 748         Remove.
 749         * tui/tui-win.c (tui_source_window_base::set_new_height)
 750         (tui_source_window_base::set_new_height)
 751         (make_invisible_and_set_new_height)
 752         (tui_source_window_base::do_make_visible_with_new_height)
 753         (tui_source_window_base::do_make_visible_with_new_height):
 754         Update.
 755         * tui/tui-layout.c (show_source_disasm_command, show_data)
 756         (show_source_or_disasm_and_command): Update.
 757         * tui/tui-layout.c (show_layout): Update.
 758
 759 2019-07-17  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-layout.c (make_data_window): Remove.
 762         (show_data): Unify creation and re-initialization cases.
 763
 764 2019-07-17  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-layout.c (make_source_window, make_disasm_window):
 767         Remove.
 768         (show_data): Unify creation and re-initialization cases.
 769
 770 2019-07-17  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-layout.c (make_command_window): Remove.
 773         (show_source_disasm_command, show_source_or_disasm_and_command):
 774         Unify creation and re-initialization cases.
 775
 776 2019-07-17  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 779         creation and re-initialization cases.
 780
 781 2019-07-17  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-regs.c (tui_get_register): Return void.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 788         Simplify.
 789
 790 2019-07-17  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 793         resetting.
 794
 795 2019-07-17  Tom Tromey  <tom@tromey.com>
 796
 797         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 798         * tui/tui-regs.c (tui_reg_layout): New function.
 799         (tui_show_registers, tui_reg_command): Use it.
 800         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 801         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 802         parameters.
 803         (tui_layout_command): Remove.
 804
 805 2019-07-17  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-layout.h (tui/tui-layout): Return void.
 808         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 809
 810 2019-07-17  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-layout.c (show_source_disasm_command, show_data):
 813         Update.
 814         (reset_locator): Remove.
 815         (show_source_or_disasm_and_command): Update.
 816
 817 2019-07-17  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-source.c (tui_source_window_base::reset): Remove
 820         win_type parameter.
 821         * tui/tui-layout.c (make_command_window, make_source_window)
 822         (make_disasm_window, make_data_window)
 823         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 824         (reset_locator, show_source_or_disasm_and_command): Update.
 825         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 826         win_type parameter.
 827         (struct tui_source_window_base) <reset>: Likewise.
 828
 829 2019-07-17  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-layout.c (show_source_disasm_command): Use
 832         reset_locator.
 833         (reset_locator): New function.
 834         (init_and_make_win): Remove.
 835         (show_source_or_disasm_and_command): Use reset_locator.
 836
 837 2019-07-17  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 840         condition.
 841         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 842         Remove condition.
 843         * tui/tui-source.c (tui_source_window_base::reset): New method.
 844         * tui/tui-layout.c (make_command_window): Don't call
 845         init_and_make_win.
 846         (make_source_window, make_disasm_window): Don't call
 847         make_source_or_disasm_window.
 848         (make_data_window): Don't call init_and_make_win.  Change calling
 849         convention.
 850         (show_source_disasm_command, show_data): Simplify.
 851         (make_source_or_disasm_window): Remove.
 852         (show_source_or_disasm_and_command): Simplify.
 853         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 854         (struct tui_source_window_base) <reset>: Likewise.
 855         <execution_info>: Remove initializer.
 856         * tui/tui-data.c (tui_source_window_base): Initialize
 857         execution_info.
 858
 859 2019-07-17  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 862         variable.
 863
 864 2019-07-17  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui.c (tui_rl_other_window): Update.
 867         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 868         superclass method first.  Always iterate over regs_content.
 869         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 870         method.
 871         * tui/tui-win.c (tui_set_focus_command): Update.
 872
 873 2019-07-17  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-win.c (tui_set_focus_command): Rename from
 876         tui_set_focus.  Call tui_enable.
 877         (tui_set_focus_command): Remove.
 878
 879 2019-07-17  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 882         refresh_window.
 883         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 884         touchwin.
 885         (tui_data_window::refresh_window): Call refresh_window on data
 886         items.  Always call superclass refresh_window.
 887         (tui_win_info::refresh): Remove.
 888         (tui_source_window_base::refresh_window): Update.
 889         (tui_refresh_all): Update.
 890         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 891         refresh_window.
 892         (show_source_or_disasm_and_command): Likewise.
 893         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 894         (struct tui_source_window_base) <refresh>: Likewise.
 895
 896 2019-07-17  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-winsource.c (tui_clear_source_content)
 899         (tui_show_source_content): Update.
 900         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 901         whether content is empty.
 902         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 903         Remove.
 904
 905 2019-07-17  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 908         window's contents.
 909         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 910         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 911
 912 2019-07-17  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 915         (struct tui_data_item_window): Update.
 916
 917 2019-07-17  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 920         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 921         defines.
 922
 923 2019-07-17  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-winsource.h (tui_erase_source_content)
 926         (tui_clear_source_content): Remove "display_prompt" parameter.
 927         * tui/tui-winsource.c (tui_update_source_window_as_is)
 928         (tui_update_source_windows_with_addr): Update.
 929         (tui_clear_source_content): Remove "display_prompt" parameter.
 930         (tui_erase_source_content): Likewise.  Simplify.
 931         (tui_show_source_content): Update.
 932         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 933         * tui/tui-stack.c (tui_show_frame_info): Update.
 934         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 935         Remove defines.
 936
 937 2019-07-17  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 940         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 941         parameter.
 942         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 943         parameter.
 944
 945 2019-07-17  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-winsource.c (tui_clear_source_content)
 948         (tui_show_source_content, tui_show_exec_info_content)
 949         (tui_clear_exec_info_content): Update.
 950         * tui/tui-stack.c (tui_show_locator_content): Update.
 951         (tui_show_frame_info): Update.
 952         * tui/tui-source.h (tui_source_window): Don't declare.
 953         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 954         from tui_source_is_displayed.
 955         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 956         Remove field.
 957         (struct tui_source_window_base) <content_in_use>: New field.  Now
 958         bool.
 959         (struct tui_source_window) <showing_source_p>: New method.
 960         (TUI_SRC_WIN): Change cast.
 961         * tui/tui-data.c (tui_initialize_static_data): Update.
 962
 963 2019-07-17  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 966         location_matches_p.
 967         * tui/tui-source.c (tui_source_window::location_matches_p): New
 968         method.
 969         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 970         method.
 971         * tui/tui-data.h (struct tui_source_window_base)
 972         <location_matches_p>: New method.
 973         (struct tui_source_window, struct tui_disasm_window)
 974         <location_matches_p>: Likewise.
 975
 976 2019-07-17  Tom Tromey  <tom@tromey.com>
 977
 978         * tui/tui-win.c (tui_set_win_height_command): Rename from
 979         tui_set_win_height.
 980         (tui_set_win_height_command): Remove.
 981
 982 2019-07-17  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-source.c (tui_source_window): New constructor.  Add
 985         observer.
 986         (~tui_source_window): New destructor.
 987         (tui_source_window::style_changed): New method.
 988         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 989         (tui_attach_detach_observers): Update.
 990         * tui/tui-data.h (struct tui_source_window): Make constructor not
 991         inline.  Add destructor.
 992         (struct tui_source_window) <style_changed>: New method.
 993         <m_observable>: New member.
 994
 995 2019-07-17  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 998         * tui/tui-win.c (tui_resize_all): Fix typo.
 999
1000 2019-07-17  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1003         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1004         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1005         * tui/tui-win.c (window_name_completer): Use foreach.
1006         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1007         (update_tab_width): Likewise.
1008         * tui/tui-layout.c (show_layout): Update.
1009         * tui/tui-data.h (class tui_window_iterator): New.
1010         (struct all_tui_windows): New.
1011         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1012
1013 2019-07-17  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1016         parameter.  Don't reference globals.
1017         (tui_reg_command): Update.
1018
1019 2019-07-17  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-regs.c (tui_show_registers): Simplify.
1022
1023 2019-07-17  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-regs.c (tui_show_registers): Update.
1026         (tui_show_register_group): Add win_info parameter.
1027
1028 2019-07-17  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1031         Rename from tui_display_reg_element_at_line.
1032         (tui_data_window::display_registers_from_line): Update.
1033         * tui/tui-data.h (struct tui_data_window)
1034         <display_reg_element_at_line>: New method.
1035
1036 2019-07-17  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-regs.h (tui_display_registers_from)
1039         (tui_display_registers_from_line): Don't declare.
1040         * tui/tui-windata.c (tui_data_window::display_all_data)
1041         (tui_data_window::refresh_all)
1042         (tui_data_window::do_scroll_vertical): Update.
1043         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1044         from tui_display_registers_from.
1045         (tui_display_reg_element_at_line): Update.
1046         (tui_data_window::display_registers_from_line): Rename from
1047         tui_display_registers_from_line.
1048         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1049         display_registers_from_line>: New methods.
1050
1051 2019-07-17  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1054         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1055         from tui_erase_data_content.
1056         (tui_data_window::display_all_data)
1057         (tui_data_window::refresh_all)
1058         (tui_data_window::do_scroll_vertical): Update.
1059         * tui/tui-regs.c (tui_show_registers): Update.
1060         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1061         New method.
1062
1063 2019-07-17  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1066         declare.
1067         * tui/tui-windata.c
1068         (tui_data_window::delete_data_content_windows): Rename from
1069         tui_delete_data_content_windows.
1070         (tui_data_window::display_all_data)
1071         (tui_data_window::do_scroll_vertical): Update.
1072         * tui/tui-data.h (struct tui_data_window)
1073         <delete_data_content_windows>: New method.
1074
1075 2019-07-17  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1078         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1079
1080 2019-07-17  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1083         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1084         from tui_display_all_data.
1085         * tui/tui-win.c
1086         (tui_data_window::do_make_visible_with_new_height): Update.
1087         * tui/tui-regs.c (tui_show_registers): Update.
1088         * tui/tui-layout.c (tui_set_layout): Update.
1089         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1090         method.
1091
1092 2019-07-17  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1095         * tui/tui-windata.c (tui_display_data_from): Remove.
1096         (tui_data_window::refresh_all): Update.
1097
1098 2019-07-17  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1101         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1102         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1103         tui_display_registers_from_line.
1104         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1105         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1106         "force_display" parameter.
1107
1108 2019-07-17  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1111         declare.
1112         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1113         Rename from tui_first_reg_element_no_inline.
1114         (tui_display_reg_element_at_line)
1115         (tui_display_registers_from_line): Update.
1116         * tui/tui-data.h (struct tui_data_window)
1117         <first_reg_element_no_inline>: New method.
1118
1119 2019-07-17  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-windata.c (tui_display_data_from)
1122         (tui_data_window::do_scroll_vertical): Update.
1123         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1124         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1125         Rename from tui_line_from_reg_element_no.
1126         (tui_display_registers_from_line): Update.
1127         * tui/tui-data.h (struct tui_data_window)
1128         <line_from_reg_element_no>: New method.
1129
1130 2019-07-17  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1133         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1134         tui_last_regs_line_no.
1135         (tui_display_reg_element_at_line)
1136         (tui_display_registers_from_line): Update.
1137         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1138         method.
1139
1140 2019-07-17  Tom Tromey  <tom@tromey.com>
1141
1142         PR tui/24722:
1143         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1144         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1145         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1146         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1147         (tui_update_breakpoint_info): Likewise.
1148         * tui/tui-hooks.c (tui_event_create_breakpoint)
1149         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1150         Update.
1151
1152 2019-07-17  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1155
1156 2019-07-17  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-winsource.c (tui_update_source_window_as_is)
1159         (tui_update_source_windows_with_addr): Update.
1160         * tui/tui-source.h (tui_set_source_content)
1161         (tui_show_symtab_source): Add "win_info" parameter.
1162         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1163         parameter.
1164         (tui_show_symtab_source): Likewise.
1165
1166 2019-07-17  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-wingeneral.c
1169         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1170
1171 2019-07-17  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1174         (struct tui_cmd_window) <can_scroll>: New method.
1175         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1176         method.
1177
1178 2019-07-17  Tom Tromey  <tromey@adacore.com>
1179
1180         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1181         do_field_signed>: Rename.  Change type of "value".
1182         * ui-out.c (ui_out::field_signed): Rename from field_int.
1183         Change type of "value".
1184         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1185         type of "value".
1186         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1187         do_field_int.  Change type of "value".
1188         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1189         do_field_int.  Change type of "value".
1190         * tracepoint.c (trace_status_mi, tfind_1)
1191         (print_one_static_tracepoint_marker): Update.
1192         * thread.c (print_thread_info_1, print_selected_thread_frame):
1193         Update.
1194         * stack.c (print_frame, print_frame_info): Update.
1195         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1196         Update.
1197         * source.c (print_source_lines_base): Update.
1198         * skip.c (info_skip_command): Update.
1199         * record-btrace.c (btrace_ui_out_decode_error)
1200         (btrace_call_history_src_line): Update.
1201         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1202         Update.
1203         * progspace.c (print_program_space): Update.
1204         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1205         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1206         do_field_int.  Change type of "value".
1207         * mi/mi-out.c (mi_ui_out::do_table_begin)
1208         (mi_ui_out::do_table_header): Update.
1209         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1210         type of "value".
1211         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1212         (mi_cmd_data_list_changed_registers, output_register)
1213         (mi_cmd_data_read_memory, mi_load_progress)
1214         (mi_cmd_trace_frame_collected): Update.
1215         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1216         Update.
1217         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1218         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1219         (mi_cmd_var_list_children, varobj_update_one): Update.
1220         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1221         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1222         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1223         * inferior.c (print_inferior): Update.
1224         * gdb_bfd.c (print_one_bfd): Update.
1225         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1226         Update.
1227         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1228         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1229         do_field_int.  Change type of "value".
1230         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1231         do_field_int.  Change type of "value".
1232         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1233         (print_one_breakpoint_location, print_it_catch_fork)
1234         (print_one_catch_fork, print_it_catch_vfork)
1235         (print_one_catch_vfork, print_it_catch_solib)
1236         (print_it_catch_exec, print_it_ranged_breakpoint)
1237         (print_mention_watchpoint, print_mention_masked_watchpoint)
1238         (bkpt_print_it, update_static_tracepoint): Update.
1239         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1240         * break-catch-syscall.c (print_it_catch_syscall): Update.
1241         * ada-tasks.c (print_ada_task_info): Update.
1242         * ada-lang.c (print_it_exception, print_mention_exception):
1243         Update.
1244
1245 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         PR breakpoints/24541
1248         * gdbarch.c: Regenerate.
1249         * gdbarch.h: Regenerate.
1250         * gdbarch.sh: Adjust return type and parameter types for
1251         'stap_adjust_register'.
1252         (i386_stap_adjust_register): Adjust signature and return new
1253         register name.
1254         * stap-probe.c (stap_parse_register_operand): Adjust use of
1255         'gdbarch_stap_adjust_register'.
1256
1257 2019-07-17  Tom Tromey  <tromey@adacore.com>
1258
1259         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1260         declare VEC.
1261         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1262         std::vector.
1263         (struct s390_process_info): Add initializers.
1264         (s390_add_process): Use new.
1265         (s390_linux_nat_target::low_forget_process): Use delete.
1266         (s390_linux_nat_target::low_new_fork)
1267         (s390_linux_nat_target::stopped_by_watchpoint)
1268         (s390_linux_nat_target::low_prepare_to_resume)
1269         (s390_linux_nat_target::insert_watchpoint)
1270         (s390_linux_nat_target::insert_hw_breakpoint)
1271         (s390_linux_nat_target::remove_watchpoint)
1272         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1273
1274 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1275
1276         * aarch64-fbsd-nat.c: Include regcache.h.
1277         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1278         argument.
1279         (aarch64_fbsd_nat_target::fetch_registers)
1280         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1281         variable.
1282         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1283
1284 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1285
1286         * fbsd-nat.c: Include gdbarch.h.
1287
1288 2019-07-15  Tom Tromey  <tromey@adacore.com>
1289
1290         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1291
1292 2019-07-15  Tom Tromey  <tromey@adacore.com>
1293
1294         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1295         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1296         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1297         * cli-out.c (cli_ui_out::do_field_int): New method.
1298         * ui-out.c (ui_out::field_unsigned): New method.
1299         * symfile.c (generic_load): Use field_unsigned.
1300         (print_transfer_performance): Likewise.
1301         * record-btrace.c (ui_out_field_uint): Remove.
1302         (btrace_call_history_insn_range, btrace_call_history): Use
1303         field_unsigned.
1304         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1305         field_unsigned.
1306         * ui-out.h (class ui_out) <field_unsigned>: New method.
1307         <do_field_unsigned>: Likewise.
1308
1309 2019-07-15  Tom Tromey  <tromey@adacore.com>
1310
1311         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1312         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1313         * target.c (flash_erase_command): Use field_string.
1314         * infrun.c (print_signal_received_reason): Use field_string.
1315         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1316         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1317         field_string.
1318         * ada-tasks.c (print_ada_task_info): Use field_string.
1319
1320 2019-07-15  Tom Tromey  <tromey@adacore.com>
1321
1322         * target.c (flash_erase_command): Use field_core_addr.
1323         * symfile.c (generic_load): Use field_core_addr.
1324         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1325         Use field_core_addr.
1326         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1327         field_core_addr.
1328
1329 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1332         value if its desired type is smaller than a CORE_ADDR and signed.
1333
1334 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1337         of changes to field names, and use new is_reference field to
1338         decide if a property is a reference or not.
1339         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1340         field.
1341         (struct dwarf2_property_baton): Update header comment, rename
1342         'referenced_type' to 'property_type' and update comments.
1343         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1344         default property type, store in property baton, update to take
1345         accound of renamed field.
1346         (read_func_scope): Update call to attr_to_dynamic_prop.
1347         (read_array_type): Likewise.
1348         (dwarf2_per_cu_addr_sized_int_type): New function.
1349         (read_subrange_index_type): Move type finding code to
1350         dwarf2_per_cu_addr_sized_int_type.
1351         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1352         (dwarf2_per_cu_addr_type): New function.
1353         (set_die_type): Update calls to attr_to_dynamic_prop.
1354
1355 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1356
1357         * dwarf2read.c (read_subrange_index_type): New function.
1358         (read_subrange_type): Move code into new function and call it.
1359         * gdbtypes.c (create_range_type): Add some asserts.
1360
1361 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1362
1363         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1364         update return statements.
1365         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1366         declaration, and update comment to match.
1367         * gdbtypes.c (resolve_dynamic_array): Update call to
1368         dwarf2_evaluate_property to match new return type.
1369
1370 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1371
1372         * valarith.c (value_subscripted_rvalue): Change lowerbound
1373         parameter type from int to LONGEST.
1374         * value.h (value_subscripted_rvalue): Likewise in declaration.
1375
1376 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1377
1378         * cli/cli-utils.c (info_print_command_completer): New function.
1379         * cli/cli-utils.h: Add 'completer.h' include, and forward
1380         declaration for 'struct cmd_list_element'.
1381         (info_print_command_completer): Declare.
1382         * stack.c (_initialize_stack): Add completer for 'info locals' and
1383         'info args'.
1384         * symtab.c (_initialize_symtab): Add completer for 'info
1385         variables' and 'info functions'.
1386         * NEWS: Mention completion for additional info commands.
1387
1388 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         * cli/cli-utils.c (extract_info_print_args): Delete.
1391         (extract_arg_maybe_quoted): Delete.
1392         (info_print_options_defs): New variable.
1393         (make_info_print_options_def_group): New function.
1394         (extract_info_print_options): Define new function.
1395         * cli/cli-utils.h (extract_info_print_args): Delete.
1396         (struct info_print_options): New structure.
1397         (extract_info_print_options): Declare new function.
1398         * stack.c (info_locals_command): Update to use new
1399         extract_info_print_options, also add a header comment.
1400         (info_args_command): Likewise.
1401         * symtab.c (info_variables_command): Likewise.
1402         (info_functions_command): Likewise.
1403
1404 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1405
1406         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1407         to extract string arguments.
1408         * common/common-utils.c (extract_string_maybe_quoted): New function.
1409         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1410
1411 2019-07-11  Tom Tromey  <tromey@adacore.com>
1412
1413         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1414         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1415         * top.h (gdbinit): Don't declare.
1416         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1417         into...
1418         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1419         * top.c (gdb_init): Don't call init_cli_cmds.
1420         (gdbinit): Remove.
1421         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1422
1423 2019-07-11  Tom Tromey  <tromey@adacore.com>
1424
1425         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1426         after it has been moved.
1427
1428 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1429
1430         * valops.c (value_must_coerce_to_target): Change return type to
1431         bool.
1432         * value.h (value_must_coerce_to_target): Likewise.
1433
1434 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1435
1436         * breakpoint.c (is_hardware_watchpoint): Remove
1437         forward-declaration.
1438         (is_masked_watchpoint): Change return type to bool.
1439         (is_tracepoint): Likewise.
1440         (is_breakpoint): Likewise.
1441         (is_hardware_watchpoint): Likewise.
1442         (is_watchpoint): Likewise.
1443         (is_no_memory_software_watchpoint): Likewise.
1444         (is_catchpoint): Likewise.
1445         (breakpoint_1): Make FILTER parameter's return type bool.
1446         is_masked_watchpoint): Change return type to bool.
1447         (save_breakpoints): Make FILTER parameter's return type bool.
1448         * breakpoint.h (is_breakpoint): Change return type to bool.
1449         (is_watchpoint): Likewise.
1450         (is_catchpoint): Likewise.
1451         (is_tracepoint): Likewise.
1452
1453 2019-07-10  Tom Tromey  <tom@tromey.com>
1454
1455         * defs.h: Don't include gdbarch.h.
1456         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1457         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1458         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1459         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1460         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1461         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1462         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1463         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1464         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1465         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1466         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1467         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1468         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1469         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1470         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1471         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1472         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1473         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1474         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1475         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1476         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1477         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1478         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1479         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1480         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1481         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1482         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1483
1484 2019-07-10  Tom Tromey  <tromey@adacore.com>
1485
1486         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1487         * breakpoint.c (init_ada_exception_breakpoint): Register as
1488         bp_catchpoint.
1489         (print_one_breakpoint_location, print_one_breakpoint): Use
1490         is_ada_exception_catchpoint.
1491         * ada-lang.c (class ada_catchpoint_location): Pass
1492         bp_loc_software_breakpoint to bp_location constructor.
1493         (is_ada_exception_catchpoint): New function.
1494
1495 2019-07-10  Tom Tromey  <tromey@adacore.com>
1496
1497         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1498         VEC.
1499         (struct arm_exidx_entry): New method operator<.
1500         (struct arm_exidx_data) <section_maps>: Change type.
1501         (arm_exidx_data_free): Remove.
1502         (arm_exidx_data_key): Change type.  Move lower.
1503         (arm_exidx_new_objfile): Update.
1504         (arm_compare_exidx_entries): Remove.
1505         (arm_find_exidx_entry, _initialize_arm_tdep)
1506
1507 2019-07-10  Tom Tromey  <tromey@adacore.com>
1508
1509         * solib-spu.c (ocl_program_data_key): Change type.
1510         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1511         Update.
1512
1513 2019-07-10  Tom Tromey  <tromey@adacore.com>
1514
1515         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1516         (struct solib_aix_inferior_data) <library_list>: Change type.
1517         (solib_aix_inferior_data_handle): Change type.
1518         (get_solib_aix_inferior_data): Update.
1519         (solib_aix_free_library_list): Remove.
1520         (library_list_start_library): Update.
1521         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1522         return type.
1523         (solib_aix_get_library_list)
1524         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1525         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1526
1527 2019-07-10  Tom Tromey  <tromey@adacore.com>
1528
1529         * solib-dsbt.c (struct dsbt_info): Add initializers.
1530         (solib_dsbt_pspace_data): Change type.
1531         (dsbt_pspace_data_cleanup): Remove.
1532         (get_dsbt_info, _initialize_dsbt_solib): Update.
1533
1534 2019-07-10  Tom Tromey  <tromey@adacore.com>
1535
1536         * spu-tdep.c (spu_overlay_data): Change type.
1537         (spu_get_overlay_table, spu_overlay_new_objfile)
1538         (_initialize_spu_tdep): Update.
1539
1540 2019-07-10  Tom Tromey  <tromey@adacore.com>
1541
1542         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1543         destructor.
1544         (dbx_objfile_data_key): Change type and declare later.
1545         (DBX_SYMFILE_INFO): Rewrite.
1546         * dbxread.c (dbx_objfile_data_key): Change type.
1547         (dbx_symfile_init): Update.
1548         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1549         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1550         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1551
1552 2019-07-10  Tom Tromey  <tromey@adacore.com>
1553
1554         * jit.c (jit_program_space_key): Change type.  Move lower.
1555         (get_jit_program_space_data): Update.
1556         (jit_program_space_data_cleanup): Remove.
1557         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1558         Update.
1559         (struct jit_program_space_data): Add initializers.
1560
1561 2019-07-10  Tom Tromey  <tromey@adacore.com>
1562
1563         * solib-darwin.c (struct darwin_info): Add initializers.
1564         (solib_darwin_pspace_data): Change type.
1565         (darwin_pspace_data_cleanup): Remove.
1566         (get_darwin_info, _initialize_darwin_solib): Update.
1567
1568 2019-07-10  Tom Tromey  <tromey@adacore.com>
1569
1570         * remote-sim.c (struct sim_inferior_data): Add initializers,
1571         constructor, and destructor.
1572         (sim_inferior_data_key): Change type.  Move lower.
1573         (check_for_duplicate_sim_descriptor): Update.
1574         (get_sim_inferior_data): Use new.  Update.
1575         (~sim_inferior_data_cleanup): Rename from
1576         sim_inferior_data_cleanup.  Simplify.
1577         (gdbsim_close_inferior, simulator_command)
1578         (sim_command_completer, _initialize_remote_sim): Update.
1579         (next_pid, INITIAL_PID): Move earlier.
1580
1581 2019-07-10  Tom Tromey  <tromey@adacore.com>
1582
1583         * python/python-internal.h (create_thread_object): Return
1584         gdbpy_ref.
1585         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1586         * python/py-inferior.c (struct threadlist_entry): Add
1587         constructor.
1588         <thread_obj>: Now a gdbpy_ref.
1589         (thread_to_thread_object): Update.
1590         (add_thread_object): Use new.
1591         (delete_thread_object): Use delete.
1592         (infpy_threads): Update.
1593         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1594         GIL.
1595
1596 2019-07-10  Tom Tromey  <tromey@adacore.com>
1597
1598         * valops.c (value_cast): Specialize error message for Ada.
1599
1600 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1601
1602         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1603
1604 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1605
1606         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1607         bpstat_should_step): Return bool, adjust comments.
1608         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1609         bpstat_should_step): Likewise.
1610
1611 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1612
1613         * features/Makefile: Use feature target descriptions for Arm.
1614         * features/arm/arm-core.c: Generate new file.
1615         * features/arm/arm-fpa.c: Likewise.
1616         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1617         * features/arm/arm-m-profile.c: Likewise.
1618         * features/arm/arm-vfpv2.c: Likewise.
1619         * features/arm/arm-vfpv3.c: Likewise.
1620         * features/arm/xscale-iwmmxt.c: Likewise.
1621         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1622
1623 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1624
1625         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1626         ptrace earlier.
1627
1628 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1629
1630         * features/aarch64-pauth.c: Regenerate.
1631
1632 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1633
1634         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1635         bool.
1636         (bpstat_what): Use false instead of 0.
1637
1638 2019-07-09  Pedro Alves  <palves@redhat.com>
1639
1640         * break-catch-throw.c (is_exception_catchpoint): New.
1641         * breakpoint.c (print_one_breakpoint_location): New parameter
1642         'raw_loc'.  Handle it.  Use
1643         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1644         looking at the breakpoint's type.
1645         (print_one_breakpoint): If handling "maint info breakpoints", also
1646         print locations of exception catchpoints.
1647         * breakpoint.h (is_exception_catchpoint): Declare.
1648
1649 2019-07-09  Pedro Alves  <palves@redhat.com>
1650
1651         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1652         "addr" field.
1653         (allocate_location_exception_catchpoint): New.
1654         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1655         (initialize_throw_catchpoint_ops): Install
1656         allocate_location_exception_catchpoint as allocate_location
1657         method.
1658         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1659         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1660         bp_loc_other.
1661         (breakpoint_address_is_meaningful): Delete.
1662         (bl_address_is_meaningful): New.
1663         (breakpoint_locations_match): Adjust comment.
1664         (bp_location_from_bp_type): New, factored out of...
1665         (bp_location::bp_location(breakpoint *)): ... this.
1666         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1667         factored out of...
1668         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1669         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1670         breakpoint_address_is_meaningful.
1671         (bp_locations_compare): Adjust comment.
1672         (update_global_location_list): Use bl_address_is_meaningful
1673         instead of breakpoint_address_is_meaningful.
1674         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1675         explicit.
1676         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1677         * python/py-breakpoint.c (bppy_get_location): No longer check
1678         whether location is null.
1679
1680 2019-07-09  Pedro Alves  <palves@redhat.com>
1681
1682         PR c++/15468
1683         * breakpoint.c (print_one_breakpoint_location): Remove
1684         single-location assert.
1685
1686 2019-07-09  Tom Tromey  <tom@tromey.com>
1687
1688         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1689         * configure: Rebuild.
1690         * configure.ac: Change common to gdbsupport.
1691         * gdbsupport: Rename from common.
1692         * acinclude.m4: Change common to gdbsupport.
1693         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1694         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1695         gdbsupport.
1696         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1697         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1698         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1699         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1700         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1701         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1702         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1703         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1704         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1705         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1706         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1707         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1708         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1709         coff-pe-read.c, command.h, compile/compile-c-support.c,
1710         compile/compile-c.h, compile/compile-cplus-symbols.c,
1711         compile/compile-cplus-types.c, compile/compile-cplus.h,
1712         compile/compile-loc2c.c, compile/compile.c, completer.c,
1713         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1714         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1715         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1716         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1717         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1718         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1719         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1720         features/aarch64-core.c, features/aarch64-fpu.c,
1721         features/aarch64-pauth.c, features/aarch64-sve.c,
1722         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1723         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1724         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1725         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1726         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1727         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1728         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1729         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1730         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1731         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1732         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1733         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1734         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1735         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1736         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1737         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1738         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1739         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1740         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1741         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1742         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1743         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1744         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1745         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1746         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1747         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1748         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1749         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1750         minsyms.c, mips-linux-tdep.c, namespace.h,
1751         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1752         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1753         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1754         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1755         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1756         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1757         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1758         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1759         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1760         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1761         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1762         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1763         procfs.c, producer.c, progspace.h, psymtab.h,
1764         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1765         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1766         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1767         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1768         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1769         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1770         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1771         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1772         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1773         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1774         target-memory.c, target.c, target.h, target/waitstatus.c,
1775         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1776         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1777         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1778         unittests/array-view-selftests.c,
1779         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1780         unittests/common-utils-selftests.c,
1781         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1782         unittests/format_pieces-selftests.c,
1783         unittests/function-view-selftests.c,
1784         unittests/lookup_name_info-selftests.c,
1785         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1786         unittests/mkdir-recursive-selftests.c,
1787         unittests/observable-selftests.c,
1788         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1789         unittests/parse-connection-spec-selftests.c,
1790         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1791         unittests/scoped_fd-selftests.c,
1792         unittests/scoped_mmap-selftests.c,
1793         unittests/scoped_restore-selftests.c,
1794         unittests/string_view-selftests.c, unittests/style-selftests.c,
1795         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1796         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1797         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1798         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1799         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1800         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1801
1802 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1803
1804         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1805         bool value.
1806         (decode_digits_ordinary): Set explicit_line field in sal.
1807         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1808         symtab_and_line that was set on an explicit line number in
1809         assembler code.  Do always update the recorded symtab and line if
1810         we do skip the prologue.
1811
1812 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1813
1814         * breakpoint.c (set_breakpoint_location_function): Remove
1815         explicit_loc parameter.
1816         (momentary_breakpoint_from_master): Update call to
1817         set_breakpoint_location_function.
1818         (add_location_to_breakpoint): Likewise.
1819
1820 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1821
1822         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1823         required features based on default bfd type when no specific bfd
1824         is present.
1825
1826 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1827
1828         * NEWS: Mention that GDB printf and eval commands can now print
1829         C-style and Ada-style convenience var strings without
1830         calling the inferior.
1831         * printcmd.c (printf_c_string): Locally print GDB internal var
1832         instead of transiting via the inferior.
1833         (printf_wide_c_string): Likewise.
1834
1835 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1836
1837         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1838
1839 2019-07-04  Tom Tromey  <tom@tromey.com>
1840
1841         PR tui/24724:
1842         * tui/tui-winsource.c (tui_clear_source_content): Update.
1843         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1844         (tui_update_breakpoint_info): Update.
1845         (tui_set_exec_info_content): Update.
1846         * tui/tui-source.c (tui_set_source_content_nil): Update.
1847         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1848         has_break.
1849         * tui/tui-data.h (enum tui_bp_flag): New.
1850         (tui_bp_flags): New enum flags type.
1851         (struct tui_source_element) <break_mode>: Change type.  Rename
1852         from has_break.
1853         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1854         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1855         constants.
1856         * tui/tui-winsource.h: Fix comment.
1857
1858 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1859
1860         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1861         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1862         (store_fpregs_to_thread)
1863         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1864         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1865         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1866         (IWMMXT_REGS_SIZE): Add define.
1867         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1868         (fetch_vfp_regs, store_vfp_regs)
1869         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1870         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1871
1872 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1873
1874         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1875         defines.
1876         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1877         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1878         (ARM_INT_REGISTER_SIZE): ...to this.
1879         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1880         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1881         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1882         (arm_linux_collect_gregset, supply_nwfpe_register)
1883         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1884         defines.
1885         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1886         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1887         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1888         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1889         (arm_return_in_memory, arm_store_return_value)
1890         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1891         (arm_record_ld_st_multiple): Likewise.
1892         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1893         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1894
1895 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1896
1897         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1898         AARCH64_DISPLACED_MODIFIED_INSNS.
1899         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1900         (aarch64_displaced_step_copy_insn): Likewise.
1901         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1902         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1903         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1904         ARM_DISPLACED_MODIFIED_INSNS.
1905         * arm-tdep.c (arm_gdbarch_init): Likewise.
1906         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1907         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1908         (struct arm_displaced_step_closure): Use
1909         ARM_DISPLACED_MODIFIED_INSNS.
1910
1911 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1912
1913         * features/Makefile: Remove unused xml files.
1914         * features/aarch64.xml: Remove.
1915         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1916         * features/i386/amd64-avx-avx512.xml: Remove.
1917         * features/i386/amd64-avx-linux.xml: Remove.
1918         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1919         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1920         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1921         * features/i386/amd64-avx-mpx.xml: Remove.
1922         * features/i386/amd64-avx.xml: Remove.
1923         * features/i386/amd64-linux.xml: Remove.
1924         * features/i386/amd64-mpx-linux.xml: Remove.
1925         * features/i386/amd64-mpx.xml: Remove.
1926         * features/i386/amd64.xml: Remove.
1927         * features/i386/i386-avx-avx512-linux.xml: Remove.
1928         * features/i386/i386-avx-avx512.xml: Remove.
1929         * features/i386/i386-avx-linux.xml: Remove.
1930         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1931         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1932         * features/i386/i386-avx-mpx-linux.xml: Remove.
1933         * features/i386/i386-avx-mpx.xml: Remove.
1934         * features/i386/i386-avx.xml: Remove.
1935         * features/i386/i386-linux.xml: Remove.
1936         * features/i386/i386-mmx-linux.xml: Remove.
1937         * features/i386/i386-mmx.xml: Remove.
1938         * features/i386/i386-mpx-linux.xml: Remove.
1939         * features/i386/i386-mpx.xml: Remove.
1940         * features/i386/i386.xml: Remove.
1941         * features/i386/x32-avx-avx512-linux.xml: Remove.
1942         * features/i386/x32-avx-linux.xml: Remove.
1943         * features/i386/x32-linux.xml: Remove.
1944
1945 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1946
1947         * regformats/aarch64.dat: Remove.
1948         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1949         * regformats/i386/amd64-avx-linux.dat: Remove.
1950         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1951         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1952         * regformats/i386/amd64-linux.dat: Remove.
1953         * regformats/i386/amd64-mpx-linux.dat: Remove.
1954         * regformats/i386/amd64.dat: Remove.
1955         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1956         * regformats/i386/i386-avx-linux.dat: Remove.
1957         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1958         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1959         * regformats/i386/i386-linux.dat: Remove.
1960         * regformats/i386/i386-mmx-linux.dat: Remove.
1961         * regformats/i386/i386-mpx-linux.dat: Remove.
1962         * regformats/i386/i386.dat: Remove.
1963         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1964         * regformats/i386/x32-avx-linux.dat: Remove.
1965         * regformats/i386/x32-linux.dat: Remove.
1966
1967 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1968
1969         * aarch64-tdep.c: Remove xml self tests.
1970         * amd64-linux-tdep.c: Likewise.
1971         * amd64-tdep.c: Likewise.
1972         * i386-linux-tdep.c: Likewise.
1973         * i386-tdep.c: Likewise.
1974
1975 2019-07-03  Pedro Alves  <palves@redhat.com>
1976
1977         PR cli/24732
1978         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1979         (pipe_cmd_option_defs): New.
1980         (make_pipe_cmd_options_def_group): New.
1981         (pipe_command): Use gdb::option::process_options.
1982         (pipe_command_completer): New function.
1983         (_initialize_cli_cmds): Install completer for "pipe" command.
1984
1985 2019-07-03  Pedro Alves  <palves@redhat.com>
1986
1987         * cli/cli-option.c (union option_value) <string>: New field.
1988         (struct option_def_and_value): Add ctor, move ctor, dtor and
1989         use DISABLE_COPY_AND_ASSIGN.
1990         (option_def_and_value::clear_value): New.
1991         (parse_option, save_option_value_in_ctx, get_val_type_str)
1992         (add_setshow_cmds_for_options): Handle var_string.
1993         * cli-option.h (union option_def::var_address) <string>: New
1994         field.
1995         (struct string_option_def): New.
1996         * maint-test-options.c (struct test_options_opts): Add default
1997         ctor and use DISABLE_COPY_AND_ASSIGN.
1998         <string_opt>: New field.
1999         (test_options_opts::~test_options_opts): New.
2000         (test_options_opts::dump): Also dump "-string".
2001         (test_options_option_defs): Install "string.
2002
2003 2019-07-03  Pedro Alves  <palves@redhat.com>
2004
2005         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2006         option_value with a null enumeration.
2007         (complete_options): Save the option values in the context.
2008         (save_option_value_in_ctx): New, factored out from ...
2009         (process_options): ... here.
2010         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2011         of the function.
2012         * maint-test-options.c (test_options_opts::dump): New, factored
2013         out from ...
2014         (maintenance_test_options_command_mode): ... here.
2015         (maintenance_test_options_command_completion_result): Delete.
2016         (maintenance_test_options_command_completion_text): Update
2017         comment.
2018         (maintenance_show_test_options_completion_result): Change
2019         prototype.  Just print
2020         maintenance_test_options_command_completion_text.
2021         (save_completion_result): New.
2022         (maintenance_test_options_completer_mode): Pass options context to
2023         complete_options, and then save a dump.
2024         (_initialize_maint_test_options): Use add_cmd to install "maint
2025         show test-options-completion-result".
2026
2027 2019-07-03  Pedro Alves  <palves@redhat.com>
2028
2029         * NEWS (New commands): Mention "with" and "maint with".
2030         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2031         (with_command, with_command_completer): New.
2032         (pipe_command): Adjust to new repeat_previous
2033         interface.
2034         (_initialize_cli_cmds): Install the "with" command and its "w"
2035         alias.
2036         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2037         declarations.
2038         * cli/cli-setshow.c (parse_cli_var_uinteger)
2039         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2040         argument strings for all var_types.
2041         (get_setshow_command_value_string): New, factored out from ...
2042         (do_show_command): ... this.
2043         * cli/cli-setshow.h: Include <string>.
2044         (get_setshow_command_value_string): Declare.
2045         * command.h (repeat_previous): Now returns const char *.  Adjust
2046         comment.
2047         * maint.c: Include "cli/cli-cmds.h".
2048         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2049         (_initialize_maint_cmds): Register the "maintenance with" command.
2050         * top.c (repeat_previous): Move bits from pipe_command here:
2051         Return the saved command line, if any; error out if there's no
2052         command to relaunch.
2053
2054 2019-07-03  Pedro Alves  <palves@redhat.com>
2055
2056         * NEWS (New commands): Mention "maint set/show test-settings"
2057         instead of "maint test-settings".
2058         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2059         (maintenance_test_settings_set_list): Rename to ...
2060         (maintenance_set_test_settings_list): ... this.
2061         (maintenance_test_settings_show_list): Rename to  ...
2062         (maintenance_show_test_settings_list): ... this.
2063         (maintenance_test_settings_cmd): Delete.
2064         (maintenance_test_settings_set_cmd): ...
2065         (maintenance_set_test_settings_cmd): ... this.
2066         (maintenance_test_settings_show_cmd): ...
2067         (maintenance_show_test_settings_cmd): ... this.
2068         (maintenance_test_settings_show_value_cmd):
2069         (maintenance_show_test_settings_value_cmd): ... this.
2070         (_initialize_maint_test_settings): No longer install the "maint
2071         test-settings" prefix command.  Rename "maint test-settings set"
2072         to "maint set test-settings", and "maint test-settings show" to
2073         "maint show test-settings".  Adjust all subcommands.
2074
2075 2019-07-03  Pedro Alves  <palves@redhat.com>
2076
2077         * maint-test-settings.c: Fix file's intro comment.  Replace all
2078         references to "test-options" with references to "test-settings",
2079         in comments.
2080
2081 2019-07-03  Pedro Alves  <palves@redhat.com>
2082
2083         * maint-test-settings.c (maintenance_test_settings_xxx)
2084         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2085         New.
2086         (maintenance_test_settings_enums): Use them.
2087         (maintenance_test_settings_enum): Default to
2088         maintenance_test_settings_xxx.
2089         (_initialize_maint_test_settings): Initialize
2090         MAINTENANCE_TEST_SETTINGS_FILENAME.
2091
2092 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2093
2094         * breakpoint.h (remove_breakpoints_inf): Change return type to
2095         void, move function documentation here.
2096         * breakpoint.c (remove_breakpoints_inf): Change return type to
2097         void, move function documentation to header.
2098
2099 2019-07-02  Pedro Alves  <palves@redhat.com>
2100
2101         * NEWS (Completion improvements): Mention "info threads".
2102         * thread.c (struct info_threads_opts, info_threads_option_defs)
2103         (make_info_threads_options_def_group): New.
2104         (info_threads_command): Use gdb::option::process_options.
2105         (info_threads_command_completer): New.
2106         (_initialize_thread): Use gdb::option::build_help to build the
2107         help text for "info threads".
2108
2109 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2110
2111         * defs.h (generic_load): Move from here...
2112         * symfile.h (generic_load): ... to here.  Rename name parameter
2113         to args.
2114         * symfile.c (generic_load): Add comment.
2115
2116 2019-07-01  Tom Tromey  <tromey@adacore.com>
2117
2118         * dwarf2read.c
2119         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2120         declaration of without_params.  Fix formatting.
2121
2122 2019-07-01  Tom Tromey  <tromey@adacore.com>
2123
2124         * ada-exp.y (find_primitive_type): Update.
2125         * ada-lang.h (ada_lookup_symbol): Update.
2126         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2127         parameter.
2128         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2129
2130 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2131
2132         PR breakpoints/24541
2133         * gdbarch.c: Regenerate.
2134         * gdbarch.h: Regenerate.
2135         * gdbarch.sh: Add 'stap_adjust_register'.
2136         * i386-tdep.c: Include '<unordered_set>'.
2137         (i386_stap_adjust_register): New function.
2138         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2139         * stap-probe.c (stap_parse_register_operand): Call
2140         'gdbarch_stap_adjust_register'.
2141
2142 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2143
2144         PR python/24742
2145         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2146         * python/python.c (do_start_initialization): Use 'xmalloc'
2147         instead of 'PyMem_Malloc'.
2148
2149 2019-06-28  Tom Tromey  <tromey@adacore.com>
2150
2151         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2152         for Ada.
2153
2154 2019-06-27  Tom Tromey  <tromey@adacore.com>
2155
2156         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2157         objfile_key.
2158         (arm_find_mapping_symbol, arm_record_special_symbol)
2159         (_initialize_arm_tdep): Update.
2160         (arm_objfile_data_free): Remove.
2161
2162 2019-06-27  Tom Tromey  <tromey@adacore.com>
2163
2164         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2165         to cp_print_static_field.
2166
2167 2019-06-26  Tom Tromey  <tromey@adacore.com>
2168
2169         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2170         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2171         declare.
2172
2173 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2174
2175         * features/aarch64-core.c (create_feature_aarch64_core):
2176         Regenerate.
2177         * features/aarch64-core.xml: Add cpsr flags.
2178
2179 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2180
2181         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2182         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2183
2184 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2185
2186         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2187         field.
2188         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2189         use.
2190         (arm_record_special_symbol): Don't insert new symbol in sorted
2191         position, push it at the end.
2192
2193 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2194
2195         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2196         (arm_mapping_symbol_s): Remove.
2197         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2198         (arm_mapping_symbol_vec): New typedef.
2199         (struct arm_per_objfile): Add constructor.
2200         <section_maps>: Change type to
2201         std::unique_ptr<arm_mapping_symbol_vec[]>.
2202         (arm_compare_mapping_symbols): Remove.
2203         (arm_find_mapping_symbol): Adjust to section_maps type change.
2204         (arm_objfile_data_free): Call delete on arm_per_objfile.
2205         (arm_record_special_symbol): Adjust to section_maps type change.
2206         Allocate arm_per_objfile with new.
2207
2208 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2209
2210         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2211         with the command prefix.
2212
2213 2019-06-25  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2216         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2217
2218 2019-06-25  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2221         type.
2222         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2223         protected.
2224
2225 2019-06-25  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-winsource.c
2228         (tui_source_window_base::set_is_exec_point_at): Add check against
2229         LOA_ADDRESS.
2230
2231 2019-06-25  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-source.c (tui_set_source_content): Don't check before
2234         xfree.
2235         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.h (tui_update_source_window_as_is)
2240         (tui_alloc_source_buffer, tui_line_is_displayed)
2241         (tui_addr_is_displayed): Change type of win_info.
2242         * tui/tui-winsource.c (tui_update_source_window_as_is)
2243         (tui_clear_source_content, tui_show_source_line)
2244         (tui_show_source_content, tui_source_window_base::refill)
2245         (tui_source_window_base::set_is_exec_point_at)
2246         (tui_source_window_base::set_is_exec_point_at)
2247         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2248         (tui_alloc_source_buffer, tui_line_is_displayed)
2249         (tui_addr_is_displayed): Change type of win_info.  Update.
2250         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2251         (tui_source_window_base::do_make_visible_with_new_height):
2252         Update.
2253         * tui/tui-source.c (tui_set_source_content)
2254         (tui_set_source_content_nil)
2255         (tui_source_window::do_scroll_vertical): Update.
2256         * tui/tui-layout.c (show_layout): Update.
2257         * tui/tui-disasm.c (tui_set_disassem_content)
2258         (tui_disasm_window::do_scroll_vertical): Update.
2259         * tui/tui-data.h (tui_win_content): Remove.
2260         (struct tui_gen_win_info) <content, content_size>: Remove.
2261         (struct tui_source_element): Add initializers and destructor.
2262         (union tui_which_element, struct tui_win_element): Remove.
2263         (struct tui_source_window_base) <content>: New field.
2264         (struct tui_data_window): Remove destructor.
2265         (tui_alloc_content, tui_free_win_content)
2266         (tui_free_all_source_wins_content): Don't declare.
2267         * tui/tui-data.c (tui_initialize_static_data): Update.
2268         (init_content_element, tui_alloc_content): Remove.
2269         (~tui_gen_win_info): Update.
2270         (~tui_data_window, tui_free_all_source_wins_content)
2271         (tui_free_win_content, free_content, free_content_elements):
2272         Remove.
2273
2274 2019-06-25  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-winsource.h (tui_clear_source_content)
2277         (tui_erase_source_content, tui_show_source_content): Change type
2278         of win_info.
2279         * tui/tui-winsource.c (tui_clear_source_content)
2280         (tui_erase_source_content, tui_show_source_content): Change type
2281         of win_info.
2282         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2283         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2284         win_info.
2285         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2286         win_info.
2287         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2288
2289 2019-06-25  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-winsource.c (tui_clear_source_content)
2292         (tui_source_window_base::set_is_exec_point_at): Update.
2293         * tui/tui-source.c (tui_set_source_content_nil): Update.
2294         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2295         a bool.
2296         * tui/tui-data.c (init_content_element): Update.
2297
2298 2019-06-25  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2301         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2302         * tui/tui-layout.c (init_and_make_win): Update.
2303         * tui/tui.h (enum tui_win_type): Update.
2304         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2305         tui_win_is_auxillary.
2306         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2307         tui_win_is_auxillary.
2308
2309 2019-06-25  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2312         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2313         (tui_delete_data_content_windows, tui_display_all_data)
2314         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2315         Update.
2316         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2317         * tui/tui-regs.c (tui_last_regs_line_no)
2318         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2319         (tui_show_registers): Update.
2320         (tui_show_register_group): Return void.  Update.
2321         (tui_display_registers_from, tui_display_reg_element_at_line)
2322         (tui_display_registers_from_line, tui_check_register_values):
2323         Update.
2324         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2325         member.
2326         (struct tui_data_window) <regs_content>: Now a std::vector.
2327         <regs_content_count>: Remove.
2328         (tui_add_content_elements, tui_free_data_content): Don't declare.
2329         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2330         (init_content_element): Remove DATA_WIN case.  Add assert.
2331         (tui_add_content_elements): Remove.
2332         (tui_data_window): Update.
2333         (tui_free_data_content): Remove.
2334         (free_content_elements): Remove DATA_WIN case.
2335
2336 2019-06-25  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-data.c (tui_data_item_window): Update.
2339         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2340         * tui/tui-windata.c (tui_display_all_data)
2341         (tui_display_data_from_line): Update.
2342         (tui_check_data_values): Remove.
2343         * tui/tui-regs.c (tui_show_register_group)
2344         (tui_display_reg_element_at_line): Update.
2345         * tui/tui-hooks.c (tui_register_changed)
2346         (tui_refresh_frame_and_register_information): Call
2347         tui_check_register_values.
2348         * tui/tui-data.h (struct tui_data_window) <data_content,
2349         data_content_count, data_type>: Remove.
2350         (enum tui_data_type): Remove.
2351
2352         * tui/tui-data.c (tui_data_window::clear_detail)
2353         (~tui_data_window): Update.
2354
2355 2019-06-25  Tom Tromey  <tom@tromey.com>
2356
2357         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2358         declare.
2359         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2360         Rename from tui_first_data_item_displayed.  Update.
2361         (tui_data_window::refresh_all)
2362         (tui_data_window::do_scroll_vertical): Update.
2363         * tui/tui-data.h (struct tui_data_window)
2364         <first_data_item_displayed>: Declare new method.
2365
2366 2019-06-25  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2369         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2370         contents...
2371         (tui_initialize_static_data): ...here.
2372
2373 2019-06-25  Tom Tromey  <tom@tromey.com>
2374
2375         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2376         (tui_display_registers_from, tui_check_register_values): Update.
2377         (tui_display_register): Remove win_info parameter; update.
2378         (tui_get_register): Change type of parameters.
2379         * tui/tui-data.h (struct tui_data_element): Remove.
2380         (union tui_which_element) <data>: Remove.
2381         <data_window>: Change type.
2382         (struct tui_data_item_window): New.
2383         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2384         case.  Add assert.
2385         (~tui_data_item_window): New destructor.
2386         (free_content_elements): Remove DATA_ITEM_WIN case.
2387
2388 2019-06-25  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2391         Remove.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-data.h (struct tui_command_element): Remove.
2396         (union tui_which_element) <command>: Remove.
2397         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2398         assert.
2399         (free_content_elements): Remove CMD_WIN case.
2400
2401 2019-06-25  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-layout.c (tui_set_layout): Update.
2404         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2405         * tui/tui-data.c (layout_def): Update.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2410         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2411         (tui_source_window_base::set_new_height): Update.
2412         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2413         Update.
2414         (tui_set_locator_fullname, tui_set_locator_info)
2415         (tui_show_frame_info): Update.
2416         * tui/tui-source.c (tui_set_source_content)
2417         (tui_source_is_displayed): Update.
2418         * tui/tui-layout.c (show_source_disasm_command, show_data)
2419         (show_source_or_disasm_and_command): Update.
2420         * tui/tui-disasm.c (tui_set_disassem_content)
2421         (tui_get_begin_asm_address): Update.
2422         * tui/tui-data.h (struct tui_locator_element): Remove.
2423         (union tui_which_element) <locator>: Remove.
2424         (struct tui_locator_window): New.
2425         (tui_locator_win_info_ptr): Change return type.
2426         * tui/tui-data.c (_locator): Change type.
2427         (tui_locator_win_info_ptr): Change return type.
2428         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2429         (tui_alloc_content): Add assert.
2430
2431 2019-06-25  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-winsource.c
2434         (tui_exec_info_window::maybe_allocate_content): New method.
2435         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2436         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2437         (make_source_or_disasm_window): Add cast.
2438         * tui/tui-data.h (union tui_which_element) <simple_string>:
2439         Remove.
2440         (struct tui_source_info): New.
2441         (struct tui_source_window_base) <execution_info>: Change type.
2442         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2443         case, and add assert.
2444         (tui_alloc_content): Add assert.
2445
2446 2019-06-25  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2449         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2450         * tui/tui-data.c (tui_alloc_win_info): Remove.
2451
2452 2019-06-25  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2455         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2456         can_highlight.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2461         make_visible_with_new_height method.
2462         (tui_win_info::make_visible_with_new_height): New method.
2463         (tui_source_window_base::do_make_visible_with_new_height)
2464         (tui_data_window::do_make_visible_with_new_height)
2465         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2466         (make_visible_with_new_height): Remove.
2467         (tui_resize_all, tui_adjust_win_heights): Use
2468         make_visible_with_new_height method.
2469         * tui/tui-data.h (struct tui_win_info)
2470         <do_make_visible_with_new_height, make_visible_with_new_height>:
2471         New methods.
2472         (struct tui_source_window_base, struct tui_data_window)
2473         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2474         methods.
2475
2476 2019-06-25  Tom Tromey  <tom@tromey.com>
2477
2478         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2479         method.
2480         (update_tab_width): Call update_tab_width method.
2481         * tui/tui-data.h (struct tui_win_info)
2482         (struct tui_source_window_base) <update_tab_width>: New methods.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2487         parameter.
2488         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2489         parameter.
2490         (tui_gen_win_info::make_visible): Update.
2491         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2492         parameter.
2493         * tui/tui-data.h (enum tui_box): New enum.
2494         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2495
2496 2019-06-25  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2499         init_and_make_win for EXEC_INFO_WIN.
2500         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2501         longer inline.
2502         (struct tui_win_info) <~tui_win_info>: Inline.
2503         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2504         Don't declare.
2505         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2506         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2507         Remove.
2508         (tui_initialize_static_data): Update.
2509         (~tui_gen_win_info): Handle more cleanup here.
2510         (~tui_source_window_base): Delete "execution_info".
2511         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2512
2513 2019-06-25  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-layout.c (make_command_window): Don't set
2516         can_highlight.
2517         (show_source_disasm_command): Call the reset method.
2518         (show_data): Don't set can_highlight.  Call the reset method.
2519         (tui_gen_win_info::reset): Rename from init_gen_win_info
2520         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2521         (show_source_or_disasm_and_command): Call the reset method.
2522         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2523         (struct tui_cmd_window): Set can_highlight.
2524
2525 2019-06-25  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2528         from make_visible.
2529         (tui_make_visible, tui_make_invisible): Rewrite.
2530         (tui_win_info::make_visible): Remove.
2531         (tui_source_window_base::make_visible): Update.
2532         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2533         method.  Moved from...
2534         (struct tui_win_info) <make_visible>: ...here.
2535
2536 2019-06-25  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-winsource.c
2539         (tui_source_window_base::do_scroll_horizontal): Remove direction
2540         parameter.
2541         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2542         direction parameter.
2543         * tui/tui-win.c (tui_win_info::forward_scroll)
2544         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2545         (tui_win_info::right_scroll): Update.
2546         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2547         direction parameter.
2548         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2549         direction parameter.
2550         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2551         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2552         Remove direction parameter.
2553         (struct tui_source_window_base, struct tui_source_window)
2554         (struct tui_disasm_window, struct tui_data_window)
2555         (struct tui_cmd_window): Update.
2556
2557 2019-06-25  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui-winsource.h (tui_set_exec_info_content)
2560         (tui_show_exec_info_content, tui_erase_exec_info_content)
2561         (tui_clear_exec_info_content, tui_update_exec_info): Change
2562         argument to tui_source_window_base.
2563         * tui/tui-winsource.c (tui_set_exec_info_content)
2564         (tui_show_exec_info_content, tui_erase_exec_info_content)
2565         (tui_clear_exec_info_content, tui_update_exec_info): Change
2566         argument to tui_source_window_base.
2567
2568 2019-06-25  Tom Tromey  <tom@tromey.com>
2569
2570         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2571         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2572
2573 2019-06-25  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2576         check.
2577
2578 2019-06-25  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2581         type to void.
2582         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2583         type to void.
2584         * tui/tui-source.c (tui_set_source_content): Update.
2585         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2586
2587 2019-06-25  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-win.c (window_name_completer, tui_set_focus)
2590         (tui_all_windows_info): Use name method.
2591         * tui/tui-data.h (struct tui_gen_win_info)
2592         (struct tui_source_window, struct tui_disasm_window)
2593         (struct tui_data_window, struct tui_cmd_window) <name>: New
2594         method.
2595         (tui_win_name): Don't declare.
2596         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2597         (tui_win_name): Remove.
2598
2599 2019-06-25  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-winsource.h (tui_update_source_window)
2602         (tui_update_source_window_as_is): Change parameter type.
2603         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2604         to be a tui_source_window_base.
2605         (tui_update_source_window_as_is): Likewise.
2606         * tui/tui-win.c (make_visible_with_new_height): Update.
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-winsource.c (tui_erase_source_content)
2611         (tui_show_source_content, tui_show_exec_info_content)
2612         (tui_erase_exec_info_content): Use refresh_window method.
2613         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2614         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2615         from tui_refresh_win.
2616         (tui_data_window::refresh_window): New method.
2617         (tui_win_info::refresh, tui_source_window_base::refresh)
2618         (tui_refresh_all): Use refresh_window method.
2619         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2620         method.
2621         * tui/tui-regs.c (tui_display_register): Call refresh_window
2622         method.
2623         * tui/tui-layout.c (show_source_disasm_command)
2624         (show_source_or_disasm_and_command): Call refresh_window method.
2625         * tui/tui-data.h (struct tui_gen_win_info)
2626         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2627         New method.
2628
2629 2019-06-25  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui.c (tui_rl_other_window, tui_enable)
2632         (tui_is_window_visible, tui_get_command_dimension): Update.
2633         * tui/tui-winsource.c (tui_update_source_window_as_is)
2634         (tui_clear_source_content, tui_erase_source_content)
2635         (tui_show_source_line, tui_source_window_base::refill)
2636         (tui_source_window_base::do_scroll_horizontal)
2637         (tui_source_window_base::set_is_exec_point_at)
2638         (tui_update_breakpoint_info, tui_set_exec_info_content)
2639         (tui_alloc_source_buffer, tui_line_is_displayed)
2640         (tui_addr_is_displayed): Update.
2641         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2642         (tui_check_and_display_highlight_if_needed)
2643         (tui_win_info::make_visible, tui_win_info::refresh)
2644         (tui_refresh_all): Update.
2645         * tui/tui-windata.c (tui_first_data_item_displayed)
2646         (tui_delete_data_content_windows, tui_erase_data_content)
2647         (tui_display_all_data, tui_data_window::refresh_all)
2648         (tui_check_data_values): Update.
2649         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2650         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2651         (tui_win_info::backward_scroll, tui_refresh_all_win)
2652         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2653         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2654         (tui_source_window_base::set_new_height)
2655         (tui_data_window::set_new_height)
2656         (make_invisible_and_set_new_height)
2657         (make_visible_with_new_height, new_height_ok)
2658         (parse_scrolling_args): Update.
2659         * tui/tui-stack.c (tui_show_frame_info): Update.
2660         * tui/tui-source.c (tui_set_source_content)
2661         (tui_set_source_content_nil, tui_source_is_displayed)
2662         (tui_source_window::do_scroll_vertical): Update.
2663         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2664         (tui_display_registers_from, tui_display_reg_element_at_line)
2665         (tui_check_register_values, tui_reg_command): Update.
2666         * tui/tui-layout.c (tui_default_win_height)
2667         (show_source_disasm_command, show_data, init_and_make_win)
2668         (show_source_or_disasm_and_command): Update.
2669         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2670         (tui_redisplay_readline, tui_mld_flush)
2671         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2672         (tui_getc): Update.
2673         * tui/tui-disasm.c (tui_set_disassem_content)
2674         (tui_disasm_window::do_scroll_vertical): Update.
2675         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2676         Now virtual.
2677         (struct tui_win_info): Derive from tui_gen_win_info.
2678         <~tui_win_info>: Mark as override.
2679         <generic>: Remove member.
2680         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2681         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2682         (~tui_data_window, ~tui_win_info)
2683         (tui_free_all_source_wins_content): Update.
2684         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2685
2686 2019-06-25  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-layout.c (init_and_make_win): Use new.
2689         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2690         destructor, initializers.
2691         (tui_alloc_generic_win_info): Don't declare.
2692         * tui/tui-data.c (_locator): Add argument to constructor.
2693         (source_win, disasm_win): New globals.
2694         (exec_info): Remove.
2695         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2696         Update.
2697         (tui_alloc_generic_win_info): Remove.
2698         (init_content_element): Use new.
2699         (tui_win_info::tui_win_info): Update.
2700         (free_content_elements) <case DATA_WIN>: Use delete.
2701
2702 2019-06-25  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2705         * tui/tui-windata.c (tui_first_data_item_displayed)
2706         (tui_delete_data_content_windows): Update.
2707         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2708         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2709         (tui_display_registers_from, tui_check_register_values): Update.
2710         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2711         pointer.
2712         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2713         window.
2714         (tui_free_data_content): Update.
2715         (free_content_elements) <case DATA_WIN>: Free the window.
2716
2717 2019-06-25  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2720         Update.
2721         * tui/tui-layout.c (make_command_window)
2722         (show_source_disasm_command, show_data, init_and_make_win)
2723         (show_source_or_disasm_and_command): Update.
2724         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2725         method.
2726         <can_highight, is_highlighted>: Now bool.
2727         (tui_set_win_highlight): Don't declare.
2728         * tui/tui-data.c (tui_set_win_highlight): Remove.
2729
2730 2019-06-25  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-wingeneral.c (make_visible): Remove check of window
2733         type.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-win.c (tui_win_info::max_height)
2738         (tui_cmd_window::max_height): New methods.
2739         (new_height_ok): Call max_height.
2740         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2741         <max_height>: New method.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-win.c (tui_source_window_base::set_new_height)
2746         (tui_data_window::set_new_height): New methods.
2747         (make_invisible_and_set_new_height): Call set_new_height method.
2748         * tui/tui-data.h (struct tui_win_info)
2749         (struct tui_source_window_base, struct tui_data_window)
2750         <set_new_height>: New method.
2751
2752 2019-06-25  Tom Tromey  <tom@tromey.com>
2753
2754         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2755         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2756         tui_refresh_data_win.
2757         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2758         method.
2759         (tui_refresh_all_win): Call the refresh_all method.
2760         (tui_set_focus): Likewise.
2761         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2762         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2763         Likewise.
2764
2765 2019-06-25  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-winsource.h (tui_refill_source_window)
2768         (tui_set_is_exec_point_at): Don't declare.
2769         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2770         (tui_source_window_base::refill): Rename from
2771         tui_refill_source_window.
2772         (tui_source_window_base::do_scroll_horizontal): Update.
2773         (tui_source_window_base::set_is_exec_point_at): Rename from
2774         tui_set_is_exec_point_at.
2775         (tui_update_all_breakpoint_info): Update.
2776         * tui/tui-stack.c (tui_show_frame_info): Update.
2777         * tui/tui-layout.c (show_data): Add cast.
2778         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2779         * tui/tui-data.h (struct tui_source_window_base) <refill,
2780         set_is_exec_point_at>: New methods.
2781         (tui_source_windows, tui_add_to_source_windows): Update types.
2782         (tui_add_to_source_windows): Remove redundant declaration.
2783         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2784         (tui_source_windows): Change return type.
2785         (tui_clear_source_windows_detail): Update.
2786         (tui_add_to_source_windows): Change type of parameter.
2787         (tui_free_all_source_wins_content): Update.
2788
2789 2019-06-25  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-wingeneral.c (tui_win_info::refresh)
2792         (tui_source_window_base::refresh): New methods.
2793         (tui_refresh_all): Call the refresh method.
2794         * tui/tui-data.h (struct tui_win_info)
2795         (struct tui_source_window_base) <refresh>: New method.
2796
2797 2019-06-25  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui.h (tui_is_window_visible): Return bool.
2800         * tui/tui.c (tui_is_window_visible): Return bool.
2801         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2802         (tui_make_visible, tui_make_invisible)
2803         (tui_win_info::make_visible)
2804         (tui_source_window_base::make_visible, make_all_visible)
2805         (tui_make_all_visible, tui_make_all_invisible): Update.
2806         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2807         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2808         bool.
2809         (struct tui_win_info, struct tui_source_window_base)
2810         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2811         * tui/tui-data.c (tui_init_generic_part): Update.
2812
2813 2019-06-25  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2816         (tui_source_window_base::make_visible): New methods.
2817         (make_all_visible): Make method call.
2818         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2819         (struct tui_source_window_base, struct tui_cmd_window): Override
2820         make_visible.
2821         (tui_win_is_source_type): Don't declare.
2822         * tui/tui-data.c (tui_win_is_source_type): Remove.
2823
2824 2019-06-25  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2827         NULL check.
2828
2829 2019-06-25  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2832         Inline constructor.  Add initializers for members.
2833         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2834         constructors; now inline in class.
2835
2836 2019-06-25  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-regs.c (tui_show_registers): Update.
2839         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2840         bool.
2841         * tui/tui-data.c (tui_data_window::clear_detail)
2842         (tui_data_window): Update.
2843
2844 2019-06-25  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-windata.c (tui_display_all_data)
2847         (tui_display_data_from_line, tui_display_data_from)
2848         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2849         Update.
2850         * tui/tui-regs.c (tui_last_regs_line_no)
2851         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2852         (tui_show_registers, tui_show_register_group)
2853         (tui_display_registers_from, tui_display_reg_element_at_line)
2854         (tui_display_registers_from_line, tui_check_register_values)
2855         (tui_reg_next, tui_reg_prev): Update.
2856         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2857         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2858         tui_data_window.
2859         (struct tui_win_info) <detail>: Remove.  Add new fields from
2860         tui_data_info.
2861         (TUI_DATA_WIN): Add cast.
2862         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2863         (~tui_data_window): Simplify.
2864
2865 2019-06-25  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-layout.c (show_source_disasm_command)
2868         (show_source_or_disasm_and_command): Update.
2869         * tui/tui-io.c (update_cmdwin_start_line)
2870         (tui_redisplay_readline): Update.
2871         * tui/tui-data.h (struct tui_command_info): Remove.
2872         (struct tui_win_info) <detail>: Remove command_info member.
2873         (struct tui_data_window) <start_line>: New member, from
2874         tui_command_info.
2875         (TUI_CMD_WIN): Add casts.
2876
2877 2019-06-25  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-winsource.c (tui_update_source_window)
2880         (tui_refill_source_window)
2881         (tui_source_window_base::do_scroll_horizontal)
2882         (tui_update_breakpoint_info, tui_set_exec_info_content)
2883         (tui_show_exec_info_content, tui_erase_exec_info_content)
2884         (tui_clear_exec_info_content): Update.
2885         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2886         Update.
2887         * tui/tui-win.c (make_invisible_and_set_new_height)
2888         (make_visible_with_new_height): Update.
2889         * tui/tui-source.c (tui_set_source_content)
2890         (tui_show_symtab_source): Update.
2891         * tui/tui-layout.c (extract_display_start_addr)
2892         (show_source_disasm_command, show_data)
2893         (make_source_or_disasm_window)
2894         (show_source_or_disasm_and_command): Update.
2895         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2896         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2897         "gdbarch".
2898         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2899         to tui_source_window_base.
2900         (struct tui_win_info) <detail>: Remove source_info member.
2901         (struct tui_source_window_base) <has_locator>: Inline.
2902         Move contents from tui_source_info; rename has_locator member to
2903         m_has_locator.
2904         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2905         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2906         header file.
2907         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2908         Simplify.
2909         (tui_free_all_source_wins_content): Cast to
2910         tui_source_window_base.
2911
2912 2019-06-25  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-win.c (make_invisible_and_set_new_height)
2915         (make_visible_with_new_height): Call has_locator method.
2916         * tui/tui-layout.c (show_source_disasm_command, show_data)
2917         (show_source_or_disasm_and_command): Update for bool change.
2918         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2919         (tui_win_info) <has_locator>: New method.
2920         (struct tui_source_window_base) <has_locator>: New method.
2921         (tui_win_has_locator): Don't declare.
2922         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2923         from tui_win_has_locator.
2924         (tui_source_window_base): Use false, not FALSE.
2925
2926 2019-06-25  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2929         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2930         clear_detail method directly.
2931         (tui_clear_win_detail): Remove.
2932
2933 2019-06-25  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2936         "this", not TUI_DISASM_WIN.
2937
2938 2019-06-25  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2941         declare.
2942         * tui/tui-winsource.c
2943         (tui_source_window_base::do_scroll_horizontal): Rename from
2944         tui_horizontal_source_scroll.
2945         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2946         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2947         from tui_vertical_data_scroll.
2948         * tui/tui-win.h (tui_scroll): Don't declare.
2949         * tui/tui-win.c (tui_win_info::forward_scroll)
2950         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2951         (tui_win_info::right_scroll): Rename and update.
2952         (tui_scroll_forward_command, tui_scroll_backward_command)
2953         (tui_scroll_left_command, tui_scroll_right_command): Update.
2954         (tui_scroll): Remove.
2955         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2956         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2957         from tui_vertical_source_scroll.
2958         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2959         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2960         from tui_vertical_disassem_scroll.
2961         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2962         do_scroll_horizontal>: New methods.
2963         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2964         Likewise.
2965         (struct tui_source_window_base): Add do_scroll_horizontal.
2966         (struct tui_source_window, struct tui_disasm_window): Add
2967         do_scroll_vertical.
2968         (struct tui_data_window, struct tui_cmd_window): Add
2969         do_scroll_horizontal and do_scroll_vertical.
2970         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-data.h (struct tui_source_window_base): New struct.
2975         (struct tui_source_window): Derive from tui_source_window_base.
2976         (struct tui_disasm_window): New struct.
2977         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2978         from tui_source_window::clear_detail.
2979         (tui_source_window_base): Rename from tui_source_window.
2980         (~tui_source_window_base): Rename from ~tui_source_window.
2981         (tui_alloc_win_info): Create a tui_disasm_window.
2982
2983 2019-06-25  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-data.h (struct tui_source_window)
2986         (struct tui_data_window): Declare destructors.
2987         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2988         destructors.
2989         (tui_win_info): Simplify.
2990
2991 2019-06-25  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-winsource.c (tui_display_main)
2994         (tui_update_source_windows_with_addr)
2995         (tui_update_all_breakpoint_info): Update.
2996         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2997         (new_height_ok, parse_scrolling_args): Update.
2998         * tui/tui-stack.c (tui_show_frame_info): Update.
2999         * tui/tui-data.h (struct tui_list): Remove.
3000         (tui_source_windows): Return a reference to a std::vector.
3001         * tui/tui-data.c (source_windows): Now a std::vector.
3002         (tui_source_windows): Change return type.
3003         (tui_clear_source_windows): Rewrite.
3004         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3005         (tui_free_all_source_wins_content): Rewrite.
3006
3007 2019-06-25  Tom Tromey  <tom@tromey.com>
3008
3009         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3010         (struct tui_data_window, struct tui_cmd_window): Declare
3011         clear_detail method.
3012         * tui/tui-data.c (tui_source_window::clear_detail)
3013         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3014         methods.
3015         (tui_clear_win_detail): Simplify.
3016
3017 2019-06-25  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui-layout.c (make_source_window, make_disasm_window)
3020         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3021         Return the new window.
3022         (show_source_disasm_command, show_data)
3023         (show_source_or_disasm_and_command): Update.
3024
3025 2019-06-25  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3028         parameter.  Return the new window.
3029         (show_source_disasm_command): Update and remove NULL check.
3030         (show_source_or_disasm_and_command): Update.
3031
3032 2019-06-25  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3035
3036 2019-06-25  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-data.h (struct tui_win_info): Make constructor
3039         protected.  Make destructor virtual.  Add initializers.
3040         (tui_source_window, tui_data_window, tui_cmd_window): New
3041         classes.
3042         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3043         constructor.  Add "type" parameter.
3044         (tui_source_window, tui_data_window, tui_cmd_window): New
3045         constructors.
3046         (tui_alloc_win_info): Instantiate the appropriate subclass.
3047
3048 2019-06-25  Tom Tromey  <tom@tromey.com>
3049
3050         * tui/tui-win.c (tui_resize_all): Use delete.
3051         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3052         destructor.
3053         (tui_free_window): Don't declare.
3054         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3055         Update.
3056
3057 2019-06-25  Tom Tromey  <tom@tromey.com>
3058
3059         * tui/tui-data.h (struct tui_win_info): Add constructor.
3060         * tui/tui-data.c (tui_alloc_win_info): Use new.
3061         (tui_free_window): Use delete.
3062
3063 2019-06-22  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3066         declare.
3067         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3068
3069 2019-06-22  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3072         declare.
3073         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3074
3075 2019-06-22  Tom de Vries  <tdevries@suse.de>
3076
3077         * dwarf2read.c (create_addrmap_from_aranges)
3078         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3079         instead of '%zu'.
3080
3081 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3082
3083         * dwarf2read.h (dwarf2_section_info_def): Remove.
3084         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3085         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3086         std::vector<dwarf2_section_info>.
3087         (struct dwo_file) <~dwo_file>: Remove.
3088         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3089         types field.
3090         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3091         (dwarf2_read_debug_names): Likewise.
3092         (create_debug_types_hash_table): Change parameter type to
3093         array_view, adjust code accordingly.
3094         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3095         (partial_die_info::fixup): Likewise.
3096         (determine_prefix): Likewise.
3097         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3098
3099 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3100
3101         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3102         gdb_bfd_ref_ptr.
3103         <~dwo_file>: Remove call to gdb_bfd_unref.
3104         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3105         gdb_bfd_ref_ptr::get.
3106
3107 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3108
3109         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3110         type to htab_up.
3111         * dwarf2read.c (struct dwo_file): Initialize fields.
3112         <~dwo_file>: New.
3113         (free_dwo_file): Remove, move content to ~dwo_file.
3114         (struct dwo_file_deleter): Remove.
3115         (dwo_file_up>: Remove custom deleter.
3116         (free_dwo_files): Remove.
3117         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3118         dwo_files.
3119         (process_skeletonless_type_units): Call unique_ptr::get.
3120         (allocate_dwo_file_hash_table): Add deleter to created hash
3121         table.  Change return type to htab_up.
3122         (lookup_dwo_file_slot): Don't memset dwo_file, call
3123         unique_ptr::get.
3124         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3125         (create_dwo_unit_in_dwp_v2): Likewise.
3126         (open_and_init_dwo_file): Likewise.
3127         (free_dwo_file_from_slot): Remove.
3128
3129 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3130
3131         * dwarf2read.h (struct dwarf2_section_info) <readin,
3132         is_virtual>: Change type to bool.
3133         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3134         true instead of 1.
3135
3136 2019-06-19  Tom Tromey  <tom@tromey.com>
3137
3138         * tui/tui-data.h (tui_init_content_element): Don't declare.
3139
3140 2019-06-19  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-data.h (tui_init_win_info): Don't declare.
3143
3144 2019-06-19  Tom de Vries  <tdevries@suse.de>
3145
3146         * dwarf2read.h (abstract_to_concrete): Change type to
3147         std::unordered_map<sect_offset, std::vector<sect_offset>,
3148         gdb::hash_enum<sect_offset>>.
3149
3150 2019-06-19  Tom Tromey  <tromey@adacore.com>
3151
3152         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3153         EVAL_AVOID_SIDE_EFFECTS specially.
3154
3155 2019-06-19  Tom Tromey  <tromey@adacore.com>
3156
3157         * source-cache.c (highlighter): New global.
3158         (source_cache::get_source_lines): Create a highlighter on demand.
3159
3160 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * defs.h (deprecated_interactive_hook): Delete declaration.
3163         * interps.c (clear_interpreter_hooks): Remove use of
3164         deprecated_interactive_hook.
3165         * top.c (deprecated_interactive_hook): Delete definition.
3166         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3167
3168 2019-06-18  Tom de Vries  <tdevries@suse.de>
3169
3170         PR gdb/24515
3171         * dwarf2read.h (abstract_to_concrete): Change type from
3172         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3173         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3174         * dwarf2read.c (read_variable): Update.
3175         (dwarf2_fetch_die_loc_sect_off): Update.
3176
3177 2019-06-17  Tom de Vries  <tdevries@suse.de>
3178
3179         PR gdb/24617
3180         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3181         accessing parent[parent_len - 1].
3182
3183 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3184
3185         PR gdb/24364
3186         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3187         call dtrace_process_dof with NULL dof.
3188
3189 2019-06-16  Tom de Vries  <tdevries@suse.de>
3190
3191         PR gdb/24445
3192         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3193
3194 2019-06-16  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3197         (make_all_visible): Use address of member.
3198
3199 2019-06-16  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3202         (tui_free_window, free_content, free_content_elements): Remove
3203         unnecessary cast.
3204         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3205         cast.
3206         * tui/tui-regs.c (tui_show_register_group)
3207         (tui_display_registers_from, tui_display_reg_element_at_line):
3208         Remove unnecessary cast.
3209
3210 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3211
3212         * linux-nat.c (normal_mask): Delete.
3213         (_initialize_linux_nat): Don't initialise normal_mask.
3214
3215 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3216
3217         PR gdb/24445
3218         * dwarf-index-write.h (write_psymtabs_to_index): Add
3219         dwz_basename parameter.
3220         * dwarf-index-write.c (write_gdbindex): Move file writing to
3221         write_gdbindex_1.  Change return type void.
3222         (assert_file_size): Move up, remove filename parameter.
3223         (write_gdbindex_1): New function.
3224         (write_debug_names): Change return type to void, call
3225         assert_file_size.
3226         (struct index_wip_file): New struct.
3227         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3228         file logic to index_wip_file.  Write index for dwz file if
3229         needed.
3230         (save_gdb_index_command): Pass basename of dwz file, if present.
3231         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3232         build-id of dwz file, if present.
3233         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3234         (dwarf2_get_dwz_file): Likewise.
3235         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3236         (dwarf2_get_dwz_file): Likewise.
3237
3238 2019-06-16  Tom Tromey  <tom@tromey.com>
3239
3240         * coffread.c (process_coff_symbol): Use xstrdup.
3241         * value.c (create_internalvar): Use xstrdup.
3242
3243 2019-06-16  Tom Tromey  <tom@tromey.com>
3244
3245         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3246         * breakpoint.c (stopin_command, stopat_command)
3247         (until_break_command, decode_location_default): Remove unnecessary
3248         cast.
3249         * utils.c (subset_compare): Remove unnecessary cast.
3250         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3251         cast.
3252         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3253         cast.
3254         * infcmd.c (path_command): Remove unnecessary cast.
3255         * coffread.c (decode_type): Remove unnecessary cast.
3256         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3257         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3258         * tui/tui-stack.c (tui_show_locator_content)
3259         (tui_show_frame_info): Remove unnecessary cast.
3260         * tui/tui-win.c (tui_scroll_forward_command)
3261         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3262         (parse_scrolling_args): Remove unnecessary cast.
3263         * tui/tui-data.c (init_win_info, tui_del_window)
3264         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3265         (free_content_elements): Remove unnecessary cast.
3266         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3267         unnecessary cast.
3268         * tui/tui-source.c (tui_set_source_content)
3269         (tui_vertical_source_scroll): Remove unnecessary cast.
3270         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3271         cast.
3272         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3273         * tui/tui-regs.c (tui_display_registers_from)
3274         (tui_display_register): Remove unnecessary cast.
3275         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3276         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3277         (make_visible): Remove unnecessary cast.
3278         * tui/tui-winsource.c (tui_erase_source_content)
3279         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3280         unnecessary cast.
3281         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3282         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3283         * stabsread.c (read_type, read_array_type, read_range_type):
3284         Remove unnecessary cast.
3285         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3286         (parse_symbol, parse_type, upgrade_type, parse_external)
3287         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3288         unnecessary cast.
3289         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3290
3291 2019-06-16  Tom Tromey  <tom@tromey.com>
3292
3293         * tui/tui-data.c (tui_alloc_generic_win_info)
3294         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3295         checks.
3296
3297 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3298             Andrew Burgess  <andrew.burgess@embecosm.com>
3299
3300         * f-typeprint.c (f_print_type): Don't return early for not
3301         associated or not allocated types.
3302         (f_type_print_varspec_suffix): Add print_rank parameter and print
3303         ranks of array types in case they dangling.
3304         (f_type_print_base): Add print_rank parameter.
3305
3306 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3307
3308         * NEWS: Mention new MI commands.
3309         * break-catch-throw.c (enum exception_event_kind): Move to
3310         breakpoint.h.
3311         (print_mention_exception_catchpoint): Output text as a single
3312         message.
3313         (catch_exception_command_1): Rename to...
3314         (catch_exception_event): ...this, make non-static, update header
3315         command, and change some parameter types.
3316         (catch_catch_command): Update for changes to
3317         catch_exception_command_1.
3318         (catch_throw_command): Likewise.
3319         (catch_rethrow_command): Likewise.
3320         * breakpoint.c (enum exception_event_kind): Delete.
3321         * breakpoint.h (enum exception_event_kind): Moved here from
3322         break-catch-throw.c.
3323         (catch_exception_event): Declare.
3324         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3325         (mi_cmd_catch_throw): New function.
3326         (mi_cmd_catch_rethrow): New function.
3327         (mi_cmd_catch_catch): New function.
3328         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3329         'catch-catch' entries.
3330         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3331         (mi_cmd_catch_rethrow): Declare.
3332         (mi_cmd_catch_catch): Declare.
3333
3334 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3335
3336         * annotate.c (annotate_source_line): Change return type to void,
3337         update implementation to match.
3338         * annotate.h (annotate_source_line): Change return type to void,
3339         update header comment.
3340         * stack.c (print_frame_info): Don't change what frame information
3341         is printed based on whether annotations are on or not.
3342
3343 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3344
3345         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3346         (annotate_source): Make static.
3347         (annotate_source_line): Moved from source.c and renamed from
3348         identify_source_line.  Update the return type.
3349         * annotate.h (annotate_source): Delete declaration.
3350         (annotate_source_line): Declaration moved from source.h, and
3351         renamed from identify_source_line.  Return type updated.
3352         * source.c (identify_source_line): Moved to annotate.c and renamed
3353         to annotate_source_line.
3354         (info_line_command): Remove check of annotation_level.
3355         * source.h (identify_source_line): Move declaration to annotate.h
3356         and rename to annotate_source_line.
3357         * stack.c: Add 'annotate.h' include.
3358         (print_frame_info): Remove check of annotation_level before
3359         calling annotate_source_line.
3360
3361 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * source-cache.c (source_cache::get_plain_source_lines): Use
3364         open_source_file_with_line_charpos instead of just
3365         open_source_file, remove call to find_source_lines.
3366         (source_cache::get_source_lines): Likewise.
3367         * source.c (find_source_lines): Make static.
3368         (get_filename_and_charpos): Renamed into...
3369         (open_source_file_with_line_charpos): ..this along with changes to
3370         return a scoped_fd, and some other minor clean ups.
3371         (identify_source_line): Use open_source_file_with_line_charpos.
3372         (search_command_helper): Use open_source_file_with_line_charpos
3373         instead of just open_source_file, remove call to
3374         find_source_lines.
3375         * source.h (open_source_file_with_line_charpos): Declare new
3376         function.
3377         (find_source_lines): Delete declaration.
3378
3379 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3380
3381         * source.c (get_filename_and_charpos): Remove fullname
3382         parameter.
3383         (identify_source_line): Update call to get_filename_and_charpos.
3384
3385 2019-06-14  Tom Tromey  <tromey@adacore.com>
3386
3387         PR gdb/24502:
3388         * ui-style.h (skip_ansi_escape): Update comment.
3389         * ui-file.h (class no_terminal_escape_file): New class.
3390         * ui-file.c (no_terminal_escape_file::write)
3391         (no_terminal_escape_file::puts): New methods.
3392         * cli/cli-logging.c (handle_redirections): Use
3393         no_terminal_escape_file.
3394
3395 2019-06-14  Tom Tromey  <tromey@adacore.com>
3396
3397         * NEWS: Move convenience variable news above Python news.
3398
3399 2019-06-14  Tom Tromey  <tom@tromey.com>
3400
3401         * gnulib: Move directory to top-level.
3402         * configure.ac: Don't configure gnulib.
3403         * configure: Rebuild.
3404         * common/common-defs.h: Use new path to gnulib.
3405         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3406         (GNULIB_H): Remove.
3407         (INCGNU): Look in new gnulib location.
3408         (HFILES_NO_SRCDIR): Remove gnulib files.
3409         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3410         (generated_files): Remove GNULIB_H.
3411         ($(LIBGNU), all-lib): Remove targets.
3412         (distclean): Don't mention GNULIB_BUILDDIR.
3413         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3414
3415 2019-06-14  Tom Tromey  <tromey@adacore.com>
3416
3417         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3418         Warn if symbol file does not provide any symbols.
3419
3420 2019-06-14  Tom Tromey  <tromey@adacore.com>
3421
3422         * source.c (find_and_open_source): Respect basenames_may_differ.
3423
3424 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3425
3426         * annotate.c (annotate_breakpoints_invalid): Make use of
3427         scoped_restore_terminal_state.
3428         (annotate_frames_invalid): Likewise.
3429
3430 2019-06-14  Tom Tromey  <tromey@adacore.com>
3431
3432         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3433         allow assignment to an internalvar.
3434
3435 2019-06-14  Tom Tromey  <tromey@adacore.com>
3436
3437         * ada-lex.l: Allow "_" in attribute names.
3438
3439 2019-06-14  Tom Tromey  <tromey@adacore.com>
3440
3441         PR gdb/24653:
3442         * regcache.c (registers_changed): Don't call alloca.
3443         * top.c (execute_command): Don't call alloca.
3444
3445 2019-06-13  Pedro Alves  <palves@redhat.com>
3446
3447         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3448         'expression'.  When parsing an expression, error out if there's
3449         junk after "unlimited".
3450         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3451         (do_set_command): Adjust calls to is_unlimited_literal.
3452
3453 2019-06-13  Pedro Alves  <palves@redhat.com>
3454
3455         * compile/compile.c (make_compile_options_def_group): Add braces
3456         around array_view initializer.
3457         * thread.c (make_thread_apply_all_options_def_group)
3458         (make_thread_apply_all_options_def_group): Likewise.
3459
3460 2019-06-13  Pedro Alves  <palves@redhat.com>
3461
3462         * NEWS (New commands): Mention "maint test-options
3463         require-delimiter", "maint test-options unknown-is-error", "maint
3464         test-options unknown-is-operand" and "maint show
3465         test-options-completion-result".
3466         (New command options, command completion): New section.
3467         (Completion improvements): New section.
3468         Mention that you can abbreviate "unlimited".
3469
3470 2019-06-13  Pedro Alves  <palves@redhat.com>
3471
3472         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3473         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3474         * unittests/cli-utils-selftests.c (test_parse_flags)
3475         (test_parse_flags_qcs): Delete.
3476         (test_cli_utils): Don't call deleted functions.
3477
3478 2019-06-13  Pedro Alves  <palves@redhat.com>
3479
3480         * thread.c: Include "cli/cli-option.h".
3481         (tp_array_compar_ascending): Global.
3482         (tp_array_compar): Delete function.
3483         (tp_array_compar_ascending, tp_array_compar_descending): New
3484         functions.
3485         (ascending_option_def, qcs_flag_option_def)
3486         (thr_qcs_flags_option_defs)
3487         (make_thread_apply_all_options_def_group)
3488         (make_thread_apply_options_def_group): New.
3489         (thread_apply_all_command): Use gdb::option::process_options.
3490         (thread_apply_command_completer)
3491         (thread_apply_all_command_completer): New.
3492         (thread_apply_command): Use gdb::option::process_options.
3493         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3494         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3495         to generate help text of "thread apply".  Adjust "taas"'s help.
3496         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3497         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3498
3499 2019-06-13  Pedro Alves  <palves@redhat.com>
3500
3501         * thread.c (thread_apply_command): Check for invalid TID with
3502         isdigit instead of !isalpha.
3503
3504 2019-06-13  Pedro Alves  <palves@redhat.com>
3505
3506         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3507         (validate_flags_qcs): New.
3508         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3509         (validate_flags_qcs): Declare.
3510         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3511         (make_frame_apply_options_def_group): New.
3512         (frame_apply_command_count): Process options with
3513         gdb::option::process_options.
3514         (frame_apply_completer): New.
3515         (frame_apply_level_completer, frame_apply_all_completer)
3516         (frame_apply_completer): New.
3517         (_initialize_stack): Update help of "frame apply", "frame apply
3518         level", "frame apply all" and "faas" to mention supported options
3519         and install command completers.
3520         * stack.h (frame_apply_all_completer): Declare.
3521         * thread.c: Include "stack.h".
3522         (tfaas_command): Add "--".
3523         (_initialize_thread): Update help "tfaas" to mention supported
3524         options and install command completer.
3525
3526 2019-06-13  Pedro Alves  <palves@redhat.com>
3527
3528         * completer.c (complete_nested_command_line): New.
3529         (gdb_completion_word_break_characters_throw): Add assertion.
3530         * completer.h (complete_nested_command_line): Declare.
3531
3532 2019-06-13  Pedro Alves  <palves@redhat.com>
3533
3534         * stack.c (parse_backtrace_qualifiers): New.
3535         (backtrace_command): Use it.
3536         (backtrace_command_completer): Complete on qualifiers.
3537
3538 2019-06-13  Pedro Alves  <palves@redhat.com>
3539
3540         * frame.c: Include "cli/cli-option.h.
3541         (user_set_backtrace_options): New.
3542         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3543         Delete.
3544         (get_prev_frame): Adjust.
3545         (boolean_option_def, uinteger_option_def)
3546         (set_backtrace_option_defs): New.
3547         (_initialize_frame): Adjust and use
3548         gdb::option::add_setshow_cmds_for_options to install "set
3549         backtrace past-main" and "set backtrace past-entry".
3550         * frame.h: Include "cli/cli-option.h".
3551         (struct frame_print_options): Forward declare.
3552         (print_frame_arguments_all, print_frame_arguments_scalars)
3553         (print_frame_arguments_none): Declare.
3554         (print_entry_values): Delete declaration.
3555         (struct frame_print_options, user_frame_print_options): New.
3556         (struct set_backtrace_options): New.
3557         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3558         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3559         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3560         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3561         (list_args_or_locals): Add frame_print_options parameter.
3562         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3563         * python/py-framefilter.c (enumerate_args): Pass down
3564         USER_FRAME_PRINT_OPTIONS.
3565         * stack.c: Include "cli/cli-option.h".
3566         (print_frame_arguments_all, print_frame_arguments_scalars)
3567         (print_frame_arguments_none): Declare.
3568         (print_raw_frame_arguments, print_entry_values): Delete.
3569         (user_frame_print_options): New.
3570         (boolean_option_def, enum_option_def, frame_print_option_defs):
3571         New.
3572         (struct backtrace_cmd_options): New.
3573         (bt_flag_option_def): New.
3574         (backtrace_command_option_defs): New.
3575         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3576         (print_frame_arg, read_frame_arg, print_frame_args)
3577         (print_frame_info, print_frame): Add frame_print_options parameter
3578         and use it.
3579         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3580         (backtrace_command_1): Add frame_print_options and
3581         backtrace_cmd_options parameters and use them.
3582         (make_backtrace_options_def_group): New.
3583         (backtrace_command): Process command options with
3584         gdb::option::process_options.
3585         (backtrace_command_completer): New.
3586         (_initialize_stack): Extend "backtrace"'s help to mention
3587         supported options.  Install completer for "backtrace".
3588         Install some settings commands with add_setshow_cmds_for_options.
3589
3590 2019-06-13  Pedro Alves  <palves@redhat.com>
3591
3592         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3593         and that "set/show print raw frame-arguments" are now deprecated.
3594
3595         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3596         command.
3597         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3598         * stack.c (_initialize_stack): Install "set/show print
3599         raw-frame-arguments", and deprecate "set/show print raw
3600         frame-arguments".
3601         * valprint.c (_initialize_valprint): Deprecate "set/show print
3602         raw".
3603
3604 2019-06-13  Pedro Alves  <palves@redhat.com>
3605
3606         * compile/compile.c (struct compile_options): New.
3607         (compile_flag_option_def, compile_command_option_defs)
3608         (make_compile_options_def_group): New.
3609         (compile_file_command): Handle options with
3610         gdb::option::process_options.
3611         (compile_file_command_completer): New function.
3612         (compile_code_command): Handle options with
3613         gdb::option::process_options.
3614         (compile_code_command_completer): New function.
3615         (_initialize_compiler): Install completers for "compile code" and
3616         "compile file".  Mention available options in "compile code" and
3617         "compile code"'s help.
3618         * completer.c (advance_to_completion_word): New, factored out from
3619         ...
3620         (advance_to_expression_complete_word_point): ... this.
3621         (advance_to_filename_complete_word_point): New.
3622         * completer.h (advance_to_filename_complete_word_point): New
3623         declaration.
3624
3625 2019-06-13  Pedro Alves  <palves@redhat.com>
3626
3627         * compile/compile.c: Include "cli/cli-option.h".
3628         (compile_print_value): Scope data pointer is now a
3629         value_print_options pointer; adjust.
3630         (compile_print_command): Process options.  Scope data pointer is
3631         now a value_print_options pointer; adjust.
3632         (_initialize_compile): Update "compile print"'s help to include
3633         supported options.  Install a completer for "compile print".
3634         * cp-valprint.c (show_vtblprint, show_objectprint)
3635         (show_static_field_print): Delete.
3636         (_initialize_cp_valprint): Don't install "set print
3637         static-members", "set print vtbl", "set print object" here.
3638         * printcmd.c: Include "cli/cli-option.h" and
3639         "common/gdb_optional.h".
3640         (print_command_parse_format): Rework to fill in a
3641         value_print_options instead of a format_data.
3642         (print_value): Change parameter type from format_data pointer to
3643         value_print_options reference.  Adjust.
3644         (print_command_1): Process options.  Adjust to pass down a
3645         value_print_options.
3646         (print_command_completer): New.
3647         (_initialize_printcmd): Install print_command_completer as
3648         handle_brkchars completer for the "print" command.  Update
3649         "print"'s help to include supported options.
3650         * valprint.c: Include "cli/cli-option.h".
3651         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3652         here from cp-valprint.c.
3653         (boolean_option_def, uinteger_option_def)
3654         (value_print_option_defs, make_value_print_options_def_group):
3655         New.  Use gdb::option::add_setshow_cmds_for_options to install
3656         "set print elements", "set print null-stop", "set print repeats",
3657         "set print pretty", "set print union", "set print array", "set
3658         print address", "set print symbol", "set print array-indexes".
3659         * valprint.h: Include <string> and "cli/cli-option.h".
3660         (make_value_print_options_def_group): Declare.
3661         (print_value): Change parameter type from format_data pointer to
3662         value_print_options reference.
3663         (print_command_completer): Declare.
3664
3665 2019-06-13  Pedro Alves  <palves@redhat.com>
3666
3667         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3668         (COMMON_SFILES): Add maint-test-settings.c.
3669         * cli/cli-decode.c (boolean_enums): New global, factored out from
3670         ...
3671         (add_setshow_boolean_cmd): ... here.
3672         * cli/cli-decode.h (boolean_enums): Declare.
3673         * cli/cli-option.c: New file.
3674         * cli/cli-option.h: New file.
3675         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3676         factored out from ...
3677         (parse_cli_boolean_value(const char *)): ... this.
3678         (is_unlimited_literal): Change parameter type to pointer to
3679         pointer.  Adjust and advance ARG pointer.
3680         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3681         (parse_cli_var_enum): New, factored out from ...
3682         (do_set_command): ... this.  Adjust.
3683         * cli/cli-setshow.h (parse_cli_boolean_value)
3684         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3685         (parse_cli_var_enum): Declare.
3686         * cli/cli-utils.c: Include "cli/cli-option.h".
3687         (get_ulongest): New.
3688         * cli/cli-utils.h (get_ulongest): Declare.
3689         (check_for_argument): New overloads.
3690         * maint-test-options.c: New file.
3691
3692 2019-06-13  Pedro Alves  <palves@redhat.com>
3693
3694         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3695         parse a range if "-" is at the end of the string.
3696
3697 2019-06-13  Pedro Alves  <palves@redhat.com>
3698
3699         * cli/cli-setshow.c (parse_auto_binary_operation)
3700         (parse_cli_boolean_value): Don't allow "o".
3701
3702 2019-06-13  Pedro Alves  <palves@redhat.com>
3703
3704         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3705         * NEWS: Mention maint test-settings KIND.
3706         * maint-test-settings.c: New file.
3707
3708 2019-06-13  Pedro Alves  <palves@redhat.com>
3709
3710         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3711         completer.
3712         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3713         "set" completers.
3714
3715 2019-06-13  Pedro Alves  <palves@redhat.com>
3716
3717         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3718         after item.
3719
3720 2019-06-13  Pedro Alves  <palves@redhat.com>
3721
3722         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3723
3724 2019-06-13  Pedro Alves <palves@redhat.com>
3725
3726         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3727         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3728         call.
3729         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3730         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3731         calls.
3732         (check_for_argument): Skip spaces after argument.
3733
3734 2019-06-13  Pedro Alves  <palves@redhat.com>
3735
3736         * thread.c (thread_apply_command): Adjust TID parsing.
3737         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3738         detected before end of string.
3739         (tid_is_in_list): Error out if LIST is invalid.
3740
3741 2019-06-13  Pedro Alves  <palves@redhat.com>
3742
3743         * completer.c (complete_line_internal_1): Rewind completion word
3744         point.
3745         (completion_tracker::advance_custom_word_point_by): Change
3746         parameter type to int.
3747         * completer.h (completion_tracker::advance_custom_word_point_by):
3748         Likewise.
3749
3750 2019-06-13  Pedro Alves  <palves@redhat.com>
3751
3752         * completer.c (advance_to_completion_word): Handle delimiters.
3753
3754 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3755
3756         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3757
3758 2019-06-11  Tom Tromey  <tom@tromey.com>
3759
3760         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3761         (xmalloc_failed): Move to alloc.c.
3762         * alloc.c: New file.
3763         * Makefile.in (COMMON_SFILES): Add alloc.c.
3764
3765 2019-06-11  Tom Tromey  <tom@tromey.com>
3766
3767         * nat/linux-waitpid.c: Don't include server.h.
3768         (linux_debug): Remove.
3769         (my_waitpid): Update.
3770
3771 2019-06-11  Tom Tromey  <tromey@adacore.com>
3772
3773         * infcall.c (_initialize_infcall): Remove trailing newline from
3774         help.
3775         * user-regs.c (_initialize_user_regs): Remove trailing newline
3776         from help.
3777         * typeprint.c (_initialize_typeprint): Remove trailing newline
3778         from help.
3779         * reverse.c (_initialize_reverse): Remove trailing newlines from
3780         help.
3781         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3782         from help.
3783         * language.c (add_set_language_command): Remove trailing newline
3784         from help.
3785         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3786         help.
3787         * disasm.c (_initialize_disasm): Remove trailing newline from
3788         help.
3789         * top.c (init_main): Remove trailing newline from help.
3790         * interps.c (_initialize_interpreter): Remove trailing newline
3791         from help.
3792         * btrace.c (_initialize_btrace): Remove trailing newlines from
3793         help.
3794         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3795         from help.
3796         * python/python.c (_initialize_python): Remove trailing newline
3797         from help.
3798         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3799         help.
3800         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3801         from help.  Reformat some text.
3802         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3803         from help.
3804         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3805         newline from help.
3806
3807 2019-06-11  Tom Tromey  <tromey@adacore.com>
3808
3809         * darwin-nat.c (darwin_decode_exception_message)
3810         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3811
3812 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * valops.c (value_slice): Check for not allocated or not
3815         associated values.
3816
3817 2019-06-10  Tom de Vries  <tdevries@suse.de>
3818
3819         PR gdb/24618
3820         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3821         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3822         invalid.
3823
3824 2019-06-10  Tom de Vries  <tdevries@suse.de>
3825
3826         PR gdb/24611
3827         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3828         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3829
3830 2019-06-10  Tom de Vries  <tdevries@suse.de>
3831
3832         PR symtab/24545
3833         * symtab.c (struct demangled_name_entry): Add language field.
3834         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3835         static minimal symbol".  Set and use language field.
3836
3837 2019-06-10  Tom Tromey  <tromey@adacore.com>
3838
3839         * ada-lang.c (_initialize_ada_language): Update help text.
3840
3841 2019-06-10  Tom Tromey  <tromey@adacore.com>
3842
3843         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3844         with a newline.
3845         * guile/guile.c (handle_boot_error): Don't end warning with a
3846         newline.
3847         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3848         warning with a newline.
3849         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3850         newline.
3851         (s12z_frame_cache): Likewise.
3852         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3853         a newline.
3854         * solib-svr4.c (disable_probes_interface): Don't end warning with
3855         a newline.
3856         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3857         newline.
3858         * python/python.c (do_finish_initialization): Don't end warning
3859         with a newline.
3860
3861 2019-06-10  Tom Tromey  <tom@tromey.com>
3862
3863         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3864         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3865         gdbpy_enter.
3866
3867 2019-06-10  Tom Tromey  <tromey@adacore.com>
3868
3869         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3870         data.
3871         (elf_new_init): Don't call stabsread_new_init.
3872         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3873         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3874         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3875
3876 2019-06-10  Tom de Vries  <tdevries@suse.de>
3877
3878         PR symtab/16264
3879         PR symtab/24517
3880         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3881
3882 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3883
3884         * source.c (find_and_open_source): Also rewrite relative file
3885         names.
3886
3887 2019-04-26  Amos Bird  <amosbird@gmail.com>
3888
3889         * annotate.c (annotate_thread_exited): Add "thread-exited"
3890         annotation.
3891
3892 2019-06-06  Tom Tromey  <tromey@adacore.com>
3893
3894         * maint.h (class scoped_command_stats): Use
3895         DISABLE_COPY_AND_ASSIGN.
3896         <print_time>: New method.
3897         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3898         print_time.
3899         (scoped_command_stats::print_time): New method.
3900
3901 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3904         instructions of lengths 6 or 8 bytes.
3905
3906 2019-06-04  Pedro Alves  <palves@redhat.com>
3907
3908         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3909
3910         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3911         * breakpoint.c (condition_completer): Likewise.
3912         * cli/cli-dump.c (scan_expression): Likewise.
3913         * common/filestuff.c (mkdir_recursive): Likewise.
3914         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3915         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3916         (gdb_abspath): Likewise.
3917         * compile/compile-cplus-types.c
3918         (compile_cplus_instance::decl_name): Likewise.
3919         * completer.c (complete_explicit_location):
3920         (signal_completer, reg_or_group_completer_1): Likewise.
3921         * cp-support.c (cp_remove_params_if_any): Likewise.
3922         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3923         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3924         * infcmd.c (strip_bg_char): Likewise.
3925         * linespec.c (copy_token_string): Likewise.
3926         * mi/mi-main.c (output_cores): Likewise.
3927         * psymtab.c (psymtab_search_name):
3928         * symfile.c (test_set_ext_lang_command): Likewise.
3929         * target.c (target_fileio_read_stralloc): Likewise.
3930         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3931         * value.c (complete_internalvar): Likewise.
3932
3933 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3934
3935         Add objfile property to gdb.Type.
3936         * NEWS: Mention Python API addition.
3937         * python/py-type.c (typy_get_objfile): New method.
3938
3939 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3940
3941         * NEWS: Mention the new set|show style [title|highlight].
3942         Mention changes to "show style", "help" and "apropos".
3943
3944 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3945
3946         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3947         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3948         instead of print_help_for_command.
3949         (print_doc_of_command): New function.
3950         (help_list): Add 'apropos -v word' suggestion.
3951         (print_help_for_command): Style the command name using title style.
3952         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3953         (_initialize_cli_cmds): Describe -v in apropos_command help.
3954
3955 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3956
3957         * cli/cli-style.h (cli_style_option): Add name in constructor,
3958         add m_name class member, add constructor with intensity,
3959         add name class function.
3960         (cli_style_option::add_setshow_commands): Remove name argument.
3961         (highlight_style, title_style): New styles.
3962         * cli/cli-style.c (do_show): New function that shows a style
3963         characteristic styling the style name with itself.
3964         (set_style_name): New function.
3965         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3966         Update all callers according to the changes in cli/cli-style.h.
3967         * utils.h (fputs_highlighted): New function.
3968         * utils.c (fputs_highlighted): Likewise.
3969
3970 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3971
3972         * NEWS: Mention new pipe command and new convenience variables.
3973
3974 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3975
3976         * cli/cli-cmds.c (pipe_command): New function.
3977         (_initialize_cli_cmds): Call add_com for pipe_command.
3978         Define | as an alias for pipe.
3979         (exit_status_set_internal_vars): New function.
3980         (shell_escape): Call exit_status_set_internal_vars.
3981         cli/cli-decode.c (find_command_name_length): Recognize | as
3982         a single character command.
3983
3984 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3985
3986         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3987         top.c (execute_command_to_ui_file): New function, mostly a copy
3988         of execute_command_to_string.
3989         (execute_command_to_string): Implement by calling
3990         execute_command_to_ui_file.
3991
3992 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3993
3994         * top.h (saved_command_line): Remove declaration.
3995         * top.c (previous_saved_command_line, previous_repeat_arguments):
3996         New variables.
3997         (saved_command_line): Make static, define together with other
3998         'repeat variables'.
3999         (dont_repeat): Clear repeat_arguments.
4000         (repeat_previous, get_saved_command_line, save_command_line):
4001         New functions.
4002         (gdb_init): Initialize saved_command_line
4003         and previous_saved_command_line.
4004         * main.c (captured_main_1): Remove saved_command_line initialization.
4005         * event-top.c (handle_line_of_input): Update to use
4006         the new 'repeat' related functions instead of direct access to
4007         saved_command_line.
4008         * command.h (repeat_previous, get_saved_command_line,
4009         save_command_line): New declarations.
4010         (dont_repeat): Add comment.
4011
4012 2019-05-30  Tom Tromey  <tromey@adacore.com>
4013
4014         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4015         Fix comment.
4016         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4017
4018 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4019
4020         PR cli/24587
4021         * completer.c (complete): Initialize variable word.
4022
4023 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4024
4025         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4026         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4027         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4028         'body' is NULL to the outter 'if', protecting the '!is_define'
4029         situation as well.
4030
4031 2019-05-29  Tom Tromey  <tromey@adacore.com>
4032
4033         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4034         (dwarf_unknown): New function.
4035         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4036         (dwarf_type_encoding_name): Use dwarf_unknown.
4037
4038 2019-05-29  Tom Tromey  <tromey@adacore.com>
4039
4040         PR c++/20020:
4041         * cp-valprint.c (cp_print_value_fields): Call
4042         cp_print_static_field inside "try".
4043
4044 2019-05-29  Tom Tromey  <tromey@adacore.com>
4045
4046         * inflow.c (struct terminal_info): Add default operator=.
4047         * configure: Rebuild.
4048         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4049         -Wdeprecated-copy-dtor, -Wredundant-move.
4050
4051 2019-05-29  Tom Tromey  <tromey@adacore.com>
4052
4053         * NEWS: Add entry.
4054         * infcmd.c (print_return_value_1): Handle finish_print
4055         option.
4056         (show_print_finish): New function.
4057         (_initialize_infcmd): Add "set/show print finish" commands.
4058         * valprint.c (user_print_options): Initialize new member.
4059         * valprint.h (struct value_print_options) <finish_print>: New
4060         member.
4061
4062 2019-05-28  Tom Tromey  <tromey@adacore.com>
4063
4064         * ada-lang.c (ada_remove_Xbn_suffix)
4065         (find_old_style_renaming_symbol)
4066         (parse_old_style_renaming): Remove.
4067         (ada_find_renaming_symbol): Don't call
4068         find_old_style_renaming_symbol.
4069         (ada_is_renaming_symbol): Rename from
4070         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4071         bool.  Now static.
4072         (ada_read_var_value): Update and simplify.
4073         * ada-exp.y (write_var_or_type): Remove old code.
4074
4075 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4076
4077         * event-top.c: Remove include comment.
4078         * inflow.c (class scoped_ignore_sigttou): Move from here...
4079         * inflow.h (class scoped_ignore_sigttou): ...to here.
4080         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4081         * top.c:  Remove include comment.
4082
4083 2019-05-27  Tom Tromey  <tom@tromey.com>
4084
4085         * NEWS: Fix typo.
4086
4087 2019-05-22  Tom Tromey  <tromey@adacore.com>
4088
4089         * target.c (target_follow_exec): Constify parameter.
4090         * target-delegates.c: Rebuild.
4091         * remote.c (remote_target::follow_exec): Constify parameter.
4092         * infrun.c (follow_exec): Constify parameter.
4093         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4094         (target_follow_exec): Likewise.
4095
4096 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4097
4098         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4099         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4100
4101 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4102
4103         * NEWS: Add debugredirect and testsuite sections.
4104
4105 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4106
4107         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4108         target descriptions using exclusively floating point register name
4109         aliases.
4110
4111 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         PR gdb/18644:
4114         * f-lang.c (build_fortran_types): Handle the case where
4115         gdbarch_floatformat_for_type returns a nullptr.
4116
4117 2019-05-21  Tom de Vries  <tdevries@suse.de>
4118
4119         PR cli/24587
4120         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4121
4122 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4123
4124         PR gdb/18644:
4125         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4126         16-byte floats.
4127         * i386-tdep.c (i386_floatformat_for_type): Use
4128         floatformats_ia64_quad for the 16-byte floating point component
4129         within a fortran 32-byte complex number.
4130
4131 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4132
4133         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4134         delete default constructor.
4135         (find_partial_die): Update to return const struct.
4136         (partial_die_parent_scope): Move variable declaration into scope
4137         of its use and change its type to auto.
4138         (guess_partial_die_structure_name): Likewise.
4139         (partial_die_info::fixup): Likewise.
4140
4141 2019-05-17  Tom Tromey  <tromey@adacore.com>
4142
4143         * source.c (find_and_open_source): Remove cast.
4144
4145 2019-05-17  Tom Tromey  <tromey@adacore.com>
4146
4147         * annotate.c (annotate_source): Make "filename" const.
4148         * annotate.h (annotate_source): Use const.
4149
4150 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4151
4152         * disasm.c (set_disassembler_options): Send errors to stderr.
4153
4154 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4155
4156         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4157         (cli_interp_base::set_logging): Check debug_redirect.
4158         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4159         * cli/cli-logging.c (debug_redirect): Add static variable.
4160         (pop_output_files): Add default param.
4161         (handle_redirections): Print debug setting.
4162         (show_logging_command): Likewise.
4163         (_initialize_cli_logging): Add debugredirect command.
4164         * interps.c (current_interp_set_logging): Add debug_redirect
4165         parameter.
4166         * interps.h (set_logging): Add debug_redirect parameter.
4167         (current_interp_set_logging): Likewise.
4168         * mi/mi-common.h: Likewise.
4169         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4170
4171 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4172             Tom Tromey  <tromey@adacore.com>
4173
4174         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4175         directly.
4176         * cli/cli-interp.h (make_logging_output): Remove declaration.
4177         * cli/cli-logging.c (make_logging_output): Remove function.
4178         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4179         directly.
4180         * ui-file.c (tee_file::tee_file): Remove bools.
4181         (tee_file::~tee_file): Remove deletes.
4182         * ui-file.h (tee_file): Remove bools.
4183
4184 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4185
4186         * mi/mi-cmds.h (mi_cmd_complete): New function.
4187         * mi/mi-main.c (mi_cmd_complete): Likewise.
4188         * mi/mi-cmds.c: Define new MI command -complete.
4189         * NEWS: Mention new -complete command.
4190
4191 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4192
4193         * completer.h (complete): New function.
4194         * completer.c (complete): Likewise.
4195         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4196         function defined in completer.h.
4197
4198 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4199
4200         * MAINTAINERS (Write After Approval): Add myself.
4201
4202 2019-05-17  Tom de Vries  <tdevries@suse.de>
4203
4204         PR gdb/24094
4205         * dwarf2read.c (struct cu_partial_die_info): New struct.
4206         (find_partial_die): Return cu_partial_die_info.
4207         (partial_die_parent_scope, guess_partial_die_structure_name)
4208         (partial_die_info::fixup): Handle new return type of find_partial_die.
4209
4210 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4211
4212         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4213         "std::string", simplifying the algorithm.
4214
4215 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4216
4217         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4218         (stap_static_probe_ops::get_probes): Likewise.
4219
4220 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4221
4222         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4223         '-')" and "else if".
4224         (stap_parse_single_operand): Join checks for
4225         "gdbarch_stap_parse_special_token_p" and
4226         "gdbarch_stap_parse_special_token" in the same "if" statement.
4227         Invert check when verifying for operation on register
4228         displacement.
4229
4230 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4231
4232         * stap-probe.c (stap_get_opcode): Update comment.
4233         (stap_get_expected_argument_type): Likewise.
4234         (handle_stap_probe): Likewise.
4235
4236 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4237
4238         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4239         return type to 'bool'.  Adjust comment.  Use 'bool' when
4240         appropriate.
4241         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4242         * stap-probe.c (stap_parse_argument_1): Likewise.
4243         (stap_is_operator): Likewise.
4244         (stap_is_generic_prefix): Likewise.
4245         (stap_is_register_prefix): Likewise.
4246         (stap_is_register_indirection_prefix): Likewise.
4247         (stap_is_integer_prefix): Likewise.
4248         (stap_generic_check_suffix): Likewise.
4249         (stap_check_integer_suffix): Likewise.
4250         (stap_check_register_suffix): Likewise.
4251         (stap_check_register_indirection_suffix): Likewise.
4252         (stap_parse_register_operand): Likewise.
4253         (stap_parse_single_operand): Likewise.
4254         (stap_parse_argument_1): Likewise.
4255         (stap_probe::get_argument_count): Likewise.
4256         (stap_is_operator): Likewise.
4257
4258 2019-05-16  Tom Tromey  <tromey@adacore.com>
4259
4260         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4261         keyword to foreach.
4262
4263 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4264
4265         * linux-thread-db.c (try_thread_db_load_1): Change return type
4266         to bool.
4267         (try_thread_db_load): Likewise.
4268         (try_thread_db_load_from_pdir_1): Likewise.
4269         (try_thread_db_load_from_pdir): Likewise.
4270         (try_thread_db_load_from_sdir): Likewise.
4271         (try_thread_db_load_from_dir): Likewise.
4272         (thread_db_load_search): Likewise.
4273         (has_libpthread): Likewise.
4274         (thread_db_load): Likewise.
4275
4276 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4277
4278         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4279         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4280         NULL, and complain/return if that's the case.
4281
4282 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4283
4284         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4285         (advance, posn, abstract_read_memory): New functions.
4286         [struct mem_read_abstraction]: New struct.
4287         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4288
4289 2019-05-14  Tom Tromey  <tromey@adacore.com>
4290
4291         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4292         value is not lval_memory.
4293
4294 2019-05-14  Tom Tromey  <tromey@adacore.com>
4295
4296         * solib.c (info_sharedlibrary_command): Style the file name.
4297
4298 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4299
4300         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4301         (aarch64_vnv_type): Likewise.
4302         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4303         * common/tdesc.c: Likewise.
4304         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4305         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4306         * features/aarch64-fpu.xml: Add ieee half view.
4307         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4308         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4309         * gdbtypes.h (struct builtin_type): Likewise.
4310         (struct objfile_type): Likewise.
4311
4312 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4313
4314         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4315         typo.
4316         * location.h (string_to_event_location): Likewise.
4317
4318 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4319
4320         GDB 8.3 released.
4321
4322 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4323
4324         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4325         New variable declaration.
4326         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4327         New variable.
4328         (print_one_breakpoint): Use ui_out::test_flags and new global
4329         variable to compute use_fixed_output.
4330         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4331         Remove.
4332         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4333         (mi_multi_location_breakpoint_output_fixed): Remove.
4334         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4335         new variable.
4336         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4337         fix_multi_location_breakpoint_output flag if version >= 3.
4338         * ui-out.h (enum ui_out_flag)
4339         <fix_multi_location_breakpoint_output>: New enumerator.
4340
4341 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4342
4343         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4344
4345 2019-05-10  Tom Tromey  <tromey@adacore.com>
4346
4347         * ada-lang.c (catch_ada_completer): New function.
4348         (_initialize_ada_language): Use it.
4349
4350 2019-05-10  Tom Tromey  <tromey@adacore.com>
4351
4352         * thread.c (print_thread_info): Make "requested_threads" const.
4353         * gdbthread.h (print_thread_info): Make "requested_threads"
4354         const.
4355         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4356         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4357
4358 2019-05-08  Tom Tromey  <tom@tromey.com>
4359
4360         * gdbtypes.c (objfile_type_data): Change type.
4361         (objfile_type, _initialize_gdbtypes): Update.
4362
4363 2019-05-08  Tom Tromey  <tom@tromey.com>
4364
4365         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4366         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4367         (_initialize_dwarf2_frame): Update.
4368
4369 2019-05-08  Tom Tromey  <tom@tromey.com>
4370
4371         * objc-lang.c (objc_objfile_data): Change type.
4372         (find_methods): Update.
4373         (_initialize_objc_lang): Remove.
4374
4375 2019-05-08  Tom Tromey  <tom@tromey.com>
4376
4377         * stabsread.c (rs6000_builtin_type_data): Change type.
4378         (rs6000_builtin_type, _initialize_stabsread): Update.
4379
4380 2019-05-08  Tom Tromey  <tom@tromey.com>
4381
4382         * mips-tdep.c (mips_pdr_data): Remove.
4383         (_initialize_mips_tdep): Update.
4384
4385 2019-05-08  Tom Tromey  <tom@tromey.com>
4386
4387         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4388         (hppa_init_objfile_priv_data, read_unwind_info)
4389         (find_unwind_entry, _initialize_hppa_tdep): Update.
4390
4391 2019-05-08  Tom Tromey  <tom@tromey.com>
4392
4393         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4394         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4395         on obstack.
4396         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4397
4398 2019-05-08  Tom Tromey  <tom@tromey.com>
4399
4400         * mdebugread.c (basic_type_data): Change type.
4401         (basic_type, _initialize_mdebugread): Update.
4402
4403 2019-05-08  Tom Tromey  <tom@tromey.com>
4404
4405         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4406
4407 2019-05-08  Tom Tromey  <tom@tromey.com>
4408
4409         * nto-tdep.c (nto_inferior_data_reg): Change type.
4410         (nto_inferior_data): Update.
4411         (nto_inferior_data_cleanup, nto_new_inferior_data)
4412         (_initialize_nto_tdep): Remove.
4413         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4414
4415 2019-05-08  Tom Tromey  <tom@tromey.com>
4416
4417         * ada-lang.c (struct ada_inferior_data): Add initializers.
4418         (ada_inferior_data): Change type.
4419         (ada_inferior_data_cleanup): Remove.
4420         (get_ada_inferior_data, ada_inferior_exit)
4421         (struct ada_pspace_data): Add initializers, destructor.
4422         (ada_pspace_data_handle): Change type.
4423         (get_ada_pspace_data): Update.
4424         (ada_pspace_data_cleanup): Remove.
4425
4426 2019-05-08  Tom Tromey  <tom@tromey.com>
4427
4428         * coffread.c (struct coff_symfile_info): Add initializers.
4429         (coff_objfile_data_key): Move lower.  Change type.
4430         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4431         Update.
4432         (coff_free_info): Remove.
4433
4434 2019-05-08  Tom Tromey  <tom@tromey.com>
4435
4436         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4437         (fbsd_pspace_data_handle): Move lower.  Change type.
4438         (get_fbsd_pspace_data): Update.
4439         (fbsd_pspace_data_cleanup): Remove.
4440         (_initialize_fbsd_tdep): Update.
4441
4442 2019-05-08  Tom Tromey  <tom@tromey.com>
4443
4444         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4445         (get_ada_tasks_pspace_data): Update.
4446         (ada_tasks_pspace_data_cleanup): Remove.
4447         (_initialize_tasks): Update.
4448         (ada_tasks_inferior_data_handle): Change type.
4449         (get_ada_tasks_inferior_data): Update.
4450         (ada_tasks_inferior_data_cleanup): Remove.
4451         (struct ada_tasks_pspace_data): Add initializers.
4452
4453 2019-05-08  Tom Tromey  <tom@tromey.com>
4454
4455         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4456         * symfile-debug.c (debug_sym_get_probes): Change type.
4457         * stap-probe.c (handle_stap_probe):
4458         (stap_static_probe_ops::get_probes): Change type.
4459         * probe.h (class static_probe_ops) <get_probes>: Change type.
4460         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4461         (parse_probes_in_pspace): Update.
4462         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4463         Update.
4464         (any_static_probe_ops::get_probes): Change type.
4465         * elfread.c (elfread_data): New typedef.
4466         (probe_key): Change type.
4467         (elf_get_probes): Likewise.  Update.
4468         (probe_key_free): Remove.
4469         (_initialize_elfread): Update.
4470         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4471         Change type.
4472         (dtrace_process_dof_probe, dtrace_process_dof)
4473         (dtrace_static_probe_ops::get_probe): Change type.
4474
4475 2019-05-08  Tom Tromey  <tom@tromey.com>
4476
4477         * xcoffread.c (struct xcoff_symfile_info): Rename from
4478         coff_symfile_info.  Add initializers.
4479         (xcoff_objfile_data_key): Move lower.  Change type.
4480         (XCOFF_DATA): Rewrite.
4481         (xcoff_free_info): Remove.
4482         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4483         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4484         (xcoff_initial_scan): Update.
4485
4486 2019-05-08  Tom Tromey  <tom@tromey.com>
4487
4488         * solib-svr4.c (struct svr4_info): Add initializers and
4489         destructor.
4490         <probes_table>: Now an htab_up.
4491         (solib_svr4_pspace_data): Change type.
4492         (free_probes_table): Simplify.
4493         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4494         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4495         (probes_table_remove_objfile_probes, register_solib_event_probe)
4496         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4497         (_initialize_svr4_solib): Update.
4498
4499 2019-05-08  Tom Tromey  <tom@tromey.com>
4500
4501         * remote.c (remote_pspace_data): Change type.
4502         (remote_pspace_data_cleanup): Remove.
4503         (get_remote_exec_file, set_pspace_remote_exec_file)
4504         (_initialize_remote): Update.
4505
4506 2019-05-08  Tom Tromey  <tom@tromey.com>
4507
4508         * breakpoint.c (breakpoint_objfile_key): Change type.
4509         (get_breakpoint_objfile_data): Update.
4510         (free_breakpoint_objfile_data): Remove.
4511         (_initialize_breakpoint): Update.
4512
4513 2019-05-08  Tom Tromey  <tom@tromey.com>
4514
4515         * linux-tdep.c (struct linux_info): Add initializers.
4516         (linux_inferior_data): Move.  Change type.
4517         (invalidate_linux_cache_inf): Update.
4518         (linux_inferior_data_cleanup): Remove.
4519         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4520
4521 2019-05-08  Tom Tromey  <tom@tromey.com>
4522
4523         * auxv.c (auxv_inferior_data): Move.  Change type.
4524         (auxv_inferior_data_cleanup): Remove.
4525         (invalidate_auxv_cache_inf): Rewrite.
4526         (get_auxv_inferior_data, _initialize_auxv): Update.
4527
4528 2019-05-08  Tom Tromey  <tom@tromey.com>
4529
4530         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4531         (symfile_debug_objfile_data_key): Change type.
4532         (symfile_debug_installed, debug_qf_has_symbols)
4533         (debug_qf_find_last_source_symtab)
4534         (debug_qf_forget_cached_source_info)
4535         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4536         (debug_qf_print_stats, debug_qf_dump)
4537         (debug_qf_expand_symtabs_for_function)
4538         (debug_qf_expand_all_symtabs)
4539         (debug_qf_expand_symtabs_with_fullname)
4540         (debug_qf_map_matching_symbols)
4541         (debug_qf_expand_symtabs_matching)
4542         (debug_qf_find_pc_sect_compunit_symtab)
4543         (debug_qf_map_symbol_filenames)
4544         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4545         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4546         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4547         (debug_sym_read_linetable, debug_sym_relocate): Update.
4548         (symfile_debug_free_objfile): Remove.
4549         (install_symfile_debug_logging, _initialize_symfile_debug):
4550         Update.
4551
4552 2019-05-08  Tom Tromey  <tom@tromey.com>
4553
4554         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4555         allocate_on_obstack.
4556         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4557         (get_dwarf2_per_objfile): Update.
4558         (set_dwarf2_per_objfile): Remove.
4559         (dwarf2_has_info, dwarf2_get_section_info): Update.
4560         (dwarf2_free_objfile): Remove.
4561         (_initialize_dwarf2_read): Update.
4562
4563 2019-05-08  Tom Tromey  <tom@tromey.com>
4564
4565         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4566         initializers.
4567         <unsupported_script_warning_printed,
4568         script_not_found_warning_printed>: Now bool.
4569         (auto_load_pspace_data): Change type.
4570         (~auto_load_pspace_info): Rename from
4571         auto_load_pspace_data_cleanup.
4572         (get_auto_load_pspace_data, init_loaded_scripts_info)
4573         (clear_section_scripts, maybe_print_unsupported_script_warning)
4574         (maybe_print_script_not_found_warning, _initialize_auto_load):
4575         Update.
4576
4577 2019-05-08  Tom Tromey  <tom@tromey.com>
4578
4579         * objfiles.c (objfile_pspace_info): Add destructor and
4580         initializers.
4581         (objfiles_pspace_data): Change type.
4582         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4583         (get_objfile_pspace_data): Update.
4584         (objfiles_bfd_data): Change type.
4585         (get_objfile_bfd_data): Update.
4586         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4587
4588 2019-05-08  Tom Tromey  <tom@tromey.com>
4589
4590         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4591         Change type.
4592         (get_catch_syscall_inferior_data): Update.
4593         (catch_syscall_inferior_data_cleanup): Remove.
4594         (_initialize_break_catch_syscall): Update.
4595
4596 2019-05-08  Tom Tromey  <tom@tromey.com>
4597
4598         * inflow.c (struct terminal_info): Add destructor and
4599         initializers.
4600         (inflow_inferior_data): Change type.
4601         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4602         (get_inflow_inferior_data, inflow_inferior_exit)
4603         (swap_terminal_info, _initialize_inflow): Update.
4604
4605 2019-05-08  Tom Tromey  <tom@tromey.com>
4606
4607         * target-dcache.c (target_dcache_cleanup): Remove.
4608         (target_dcache_aspace_key): Change type.
4609         (target_dcache_init_p, target_dcache_invalidate)
4610         (target_dcache_get, target_dcache_get_or_init)
4611         (_initialize_target_dcache): Update.
4612         * dcache.h (struct dcache_deleter): New.
4613
4614 2019-05-08  Tom Tromey  <tom@tromey.com>
4615
4616         * symtab.c (struct symbol_cache): Add destructor and
4617         initializers.
4618         (symbol_cache_key): Move.  Change type.
4619         (make_symbol_cache, free_symbol_cache): Remove.
4620         (get_symbol_cache): Update.
4621         (symbol_cache_cleanup): Remove.
4622         (ALL_PSPACES, symbol_cache_flush)
4623         (maintenance_print_symbol_cache)
4624         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4625         Update.
4626
4627 2019-05-08  Tom Tromey  <tom@tromey.com>
4628
4629         * symtab.c (struct main_info): Add destructor and initializers.
4630         (main_progspace_key): Move.  Change type.
4631         (get_main_info): Update.
4632         (main_info_cleanup): Remove.
4633         (_initialize_symtab): Update.
4634
4635 2019-05-08  Tom Tromey  <tom@tromey.com>
4636
4637         * registry.h (DECLARE_REGISTRY): Define the _key class.
4638
4639 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4640
4641         * NEWS: Merge two 'New commands' sections.
4642
4643 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4644
4645         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4646         parameter and use Ada language definition instead.
4647         (ada_val_print_ptr): Remove unused language parameter.
4648         (ada_val_print_num): Remove language parameter and use Ada language
4649         definition instead.
4650         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4651         parameter.
4652         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4653         parameter and use Ada language definition instead.
4654         (ada_val_print_1): Update all ada_val_print_xxx calls.
4655         Remove language parameter.
4656         (ada_val_print): Update ada_val_print_1 call.
4657
4658 2019-05-08  Tom Tromey  <tromey@adacore.com>
4659
4660         * remote.c (remote_hw_watchpoint_limit)
4661         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4662         Now static.
4663
4664 2019-05-08  Tom Tromey  <tromey@adacore.com>
4665
4666         * maint.c (_initialize_maint_cmds): Move initialization code to
4667         remote.c.
4668         (watchdog, show_watchdog): Move to remote.c.
4669         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4670         "watchdog" static.
4671         (_initialize_remote): Move initialization code from maint.c.
4672         * defs.h (watchdog): Don't declare.
4673
4674 2019-05-08  Tom Tromey  <tromey@adacore.com>
4675
4676         * tui/tui-interp.c: Include main.h.
4677         * interps.c: Include main.h.
4678         * main.h (interpreter_p): Declare.
4679         * defs.h (interpreter_p): Don't declare.
4680
4681 2019-05-08  Tom Tromey  <tromey@adacore.com>
4682
4683         * dwarf2loc.c: Include dwarf2read.h.
4684         * defs.h (read_unsigned_leb128): Don't declare.
4685         * dwarf2read.h (read_unsigned_leb128): Declare.
4686
4687 2019-05-08  Tom Tromey  <tromey@adacore.com>
4688
4689         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4690         method.
4691
4692 2019-05-08  Tom Tromey  <tromey@adacore.com>
4693
4694         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4695         when no wrap column is set.
4696
4697 2019-05-08  Tom Tromey  <tromey@adacore.com>
4698
4699         * c-lang.c (c_get_string): Handle non-C-style arrays.
4700
4701 2019-05-08  Tom Tromey  <tromey@adacore.com>
4702
4703         * typeprint.c (print_offset_data::update): Print the bit offset,
4704         not the number of bits remaining.
4705
4706 2019-05-08  Tom Tromey  <tromey@adacore.com>
4707
4708         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4709         padding at end of comment.
4710
4711 2019-05-08  Tom Tromey  <tromey@adacore.com>
4712
4713         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4714         Compare main types.
4715
4716 2019-05-06  Tom Tromey  <tom@tromey.com>
4717
4718         * common/scoped_mmap.c: Include common-defs.h.
4719         * common/scoped_mmap.h: Don't include config.h.
4720
4721 2019-05-04  Tom Tromey  <tom@tromey.com>
4722
4723         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4724         (struct aarch64_call_info): Add initializers.
4725         <si>: Now a std::vector.
4726         (pass_on_stack, aarch64_push_dummy_call): Update.
4727
4728 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4729             Tom Tromey  <tom@tromey.com>
4730
4731         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4732         (ppc_threads): Now a std::vector.  Now static.
4733         (hwdebug_find_thread_points_by_tid)
4734         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4735         Update.
4736
4737 2019-05-04  Tom Tromey  <tom@tromey.com>
4738
4739         * arc-tdep.c (arc_tdesc_init): Return bool.
4740
4741 2019-05-04  Tom Tromey  <tom@tromey.com>
4742
4743         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4744         Use gdb_assert_not_reached.
4745
4746 2019-05-04  Tom Tromey  <tom@tromey.com>
4747
4748         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4749         "false".
4750
4751 2019-05-04  Tom Tromey  <tom@tromey.com>
4752
4753         * arc-tdep.c (arc_tdesc_init): Use bool.
4754
4755 2019-05-04  Tom Tromey  <tom@tromey.com>
4756
4757         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4758
4759 2019-05-04  Tom Tromey  <tom@tromey.com>
4760
4761         * cli/cli-cmds.c (valid_command_p): Return bool.
4762
4763 2019-05-04  Tom Tromey  <tom@tromey.com>
4764
4765         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4766         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4767
4768 2019-05-04  Raul Tambre  <raul@tambre.ee>
4769
4770         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4771         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4772         operator for comparison.
4773
4774 2019-05-04  Tom Tromey  <tom@tromey.com>
4775
4776         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4777         (lookup_partial_symbol, print_partial_symbols)
4778         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4779         (psymbol_compare): Update.
4780         (add_psymbol_to_bcache): Clear the entire psymbol.
4781         (maintenance_check_psymtabs): Update.
4782         * psympriv.h (struct partial_symbol): Don't derive from
4783         general_symbol_info.
4784         <obj_section, unrelocated_address, address,
4785         set_unrelocated_address>: Update.
4786         <ginfo>: New member.
4787         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4788         (debug_names::write_psymbols): Update.
4789
4790 2019-05-04  Tom de Vries  <tdevries@suse.de>
4791
4792         * contrib/cc-with-tweaks.sh: Support -n arg.
4793
4794 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4795
4796         * corelow.c (core_target::detach): Ensure frame cache and
4797         register caches are cleared.
4798         inferior.c (exit_inferior_1): Likewise.
4799
4800 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4801             Tom Tromey  <tom@tromey.com>
4802
4803         * dictionary.c (collate_pending_symbols_by_language): Remove
4804         "struct" from foreach.
4805         * symtab.c (lookup_global_symbol_from_objfile)
4806         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4807         foreach.
4808         * ser-tcp.c (net_open): Remove "struct" from foreach.
4809         * objfiles.c (objfile_relocate, objfile_rebase)
4810         (objfile_has_symbols): Remove "struct" from foreach.
4811         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4812         from foreach.
4813         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4814         foreach.
4815         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4816         "struct" from foreach.
4817         * ada-lang.c (create_excep_cond_exprs)
4818         (ada_exception_catchpoint_cond_string): Remove "struct" from
4819         foreach.
4820
4821 2019-05-03  Tom Tromey  <tromey@adacore.com>
4822
4823         * ada-exp.y (convert_char_literal): Check suffix of each
4824         enumerator.
4825
4826 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4827
4828         PR ada/21406:
4829         * ada-exp.y (yywrap): Don't define.
4830         * ada-lex.l (%option): Add noyywrap
4831         (yywrap): Remove.
4832
4833 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4834
4835         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4836         _WIN32_WINNT to the XP level, unless already defined to a higher
4837         level.
4838
4839         * unittests/parse-connection-spec-selftests.c:
4840         * ser-tcp.c:
4841         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4842         override.
4843
4844         * symfile.c (find_separate_debug_file): Remove colon from the
4845         drive spec of DOS/Windows file names of the target, so that the
4846         file name produced from DEBUGDIR and the target's directory will
4847         be valid on DOS/Windows systems.
4848
4849 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * rust-lang.c (val_print_struct): Handle printing structures
4852         containing strings.
4853
4854 2019-05-02  Tom Tromey  <tromey@adacore.com>
4855
4856         * valarith.c (_initialize_valarith): Remove.
4857
4858 2019-05-01  Tom Tromey  <tromey@adacore.com>
4859
4860         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4861         bitfields.
4862
4863 2019-05-01  Tom Tromey  <tromey@adacore.com>
4864
4865         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4866         for big-endian copies.
4867
4868 2019-04-30  Ali Tamur  <tamur@google.com>
4869         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4870         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4871         (read_3_bytes): New function.
4872
4873 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4874
4875         * windows-nat.c (main_thread_id): Delete.
4876         (handle_output_debug_string): Replace main_thread_id by
4877         current_event.dwThreadId.
4878         (fake_create_process): Likewise.
4879         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4880         Do not set main_thread_id.
4881         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4882         current_event.dwThreadId.
4883         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4884
4885 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4886
4887         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4888         Use current_event.dwThreadId instead of main_thread_id.
4889
4890 2019-04-30  Tom Tromey  <tromey@adacore.com>
4891
4892         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4893         (create_excep_cond_exprs): Iterate over program spaces.
4894         (ada_exception_catchpoint_cond_string): Examine all minimal
4895         symbols for exception types.
4896
4897 2019-04-30  Tom Tromey  <tromey@adacore.com>
4898
4899         PR c++/24470:
4900         * dwarf2read.c (process_structure_scope): Handle case where type
4901         has template parameters but no symbol was created.
4902
4903 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4904             Chris January  <chris.january@arm.com>
4905
4906         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4907         qualifier.
4908         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4909
4910 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * f-typeprint.c (f_print_type): Update rules for printing
4913         whitespace.
4914         (f_type_print_varspec_suffix): Likewise.
4915
4916 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4917             Chris January  <chris.january@arm.com>
4918
4919         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4920         function arguments.
4921
4922 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4923
4924         * f-lang.c (build_fortran_types): Change name of void type to
4925         lower case.
4926         * f-typeprint.c (f_type_print_base): Print the name of the void
4927         type, rather than a fixed string.
4928         * f-valprint.c (f_decorations): Use lower case void string.
4929
4930 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4931             Chris January  <chris.january@arm.com>
4932
4933         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4934         types for Fortran.
4935
4936 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4937             Chris January  <chris.january@arm.com>
4938             David Lecomber  <david.lecomber@arm.com>
4939
4940         * f-exp.y (BINOP_INTRINSIC): New token.
4941         (exp): New parser rule handling BINOP_INTRINSIC.
4942         (f77_keywords): Add new builtin procedures.
4943         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4944         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4945         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4946         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4947         (print_unop_subexp_f): New function.
4948         (print_binop_subexp_f): New function.
4949         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4950         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4951         (dump_subexp_body_f): Likewise.
4952         (operator_check_f): Likewise.
4953         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4954         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4955
4956 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4957
4958         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4959         UNOP_KIND.
4960         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4961         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4962         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4963         (operator_length_f): New fuction.
4964         (print_subexp_f): New function.
4965         (op_name_f): New function.
4966         (dump_subexp_body_f): New function.
4967         (operator_check_f): New function.
4968         (exp_descriptor_f): Replace standard expression handling functions
4969         with new functions.
4970         * gdb/fortran-operator.def: New file.
4971         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4972         * gdb/std-operator.def: Remove UNOP_KIND.
4973
4974 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4975
4976         * std-operator.def: Remove unbalanced, stray double quote
4977         character.
4978
4979 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4980             Chris January  <chris.january@arm.com>
4981             Daniel Everett  <daniel.everett@arm.com>
4982             Nick Forrington  <nick.forrington@arm.com>
4983             Richard Bunt  <richard.bunt@arm.com>
4984
4985         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4986         of depth when printing anonymous structs or unions.
4987         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4988         Don't print either the top-level value, or the children if the
4989         max-depth is exceeded.
4990         (ppscm_print_children): When printing the key of a map, allow one
4991         extra level of depth.
4992         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4993         print either the top-level value, or the children if the max-depth
4994         is exceeded.
4995         (print_children): When printing the key of a map, allow one extra
4996         level of depth.
4997         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4998         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4999         (user_print_options): Initialise max_depth field.
5000         (val_print_scalar_or_string_type_p): New function.
5001         (val_print): Check to see if the max depth has been reached.
5002         (val_print_check_max_depth): Define new function.
5003         (show_print_max_depth): New function.
5004         (_initialize_valprint): Add 'print max-depth' option.
5005         * valprint.h (struct value_print_options) <max_depth>: New field.
5006         (val_print_check_max_depth): Declare new function.
5007         * NEWS: Document new feature.
5008
5009 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5010
5011         * ada-lang.c (ada_language_defn): Initialise new field.
5012         * c-lang.c (c_is_string_type_p): New function.
5013         (c_language_defn): Initialise new field.
5014         (cplus_language_defn): Initialise new field.
5015         (asm_language_defn): Initialise new field.
5016         (minimal_language_defn): Initialise new field.
5017         * c-lang.h (c_is_string_type_p): Declare new function.
5018         * d-lang.c (d_language_defn): Initialise new field.
5019         * f-lang.c (f_is_string_type_p): New function.
5020         (f_language_defn): Initialise new field.
5021         * go-lang.c (go_is_string_type_p): New function.
5022         (go_language_defn): Initialise new field.
5023         * language.c (default_is_string_type_p): New function.
5024         (unknown_language_defn): Initialise new field.
5025         (auto_language_defn): Initialise new field.
5026         * language.h (struct language_defn) <la_is_string_type_p>: New
5027         member variable.
5028         (default_is_string_type_p): Declare new function.
5029         * m2-lang.c (m2_language_defn): Initialise new field.
5030         * objc-lang.c (objc_language_defn): Initialise new field.
5031         * opencl-lang.c (opencl_language_defn): Initialise new field.
5032         * p-lang.c (pascal_is_string_type_p): New function.
5033         (pascal_language_defn): Initialise new field.
5034         * rust-lang.c (rust_is_string_type_p): New function.
5035         (rust_language_defn): Initialise new field.
5036
5037 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5038
5039         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5040         New field.
5041         * ada-lang.c (ada_language_defn): Initialise new field.
5042         * c-lang.c (c_language_defn): Likewise.
5043         (cplus_language_defn): Likewise.
5044         (asm_language_defn): Likewise.
5045         (minimal_language_defn): Likewise.
5046         * d-lang.c (d_language_defn): Likewise.
5047         * f-lang.c (f_language_defn): Likewise.
5048         * go-lang.c (go_language_defn): Likewise.
5049         * language.c (unknown_language_defn): Likewise.
5050         (auto_language_defn): Likewise.
5051         * m2-lang.c (m2_language_defn): Likewise.
5052         * objc-lang.c (objc_language_defn): Likewise.
5053         * opencl-lang.c (opencl_language_defn): Likewise.
5054         * p-lang.c (pascal_language_defn): Likewise.
5055         * rust-lang.c (rust_language_defn): Likewise.
5056
5057 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         * ada-lang.c (ada_is_character_type): Change return type to bool.
5060         (ada_is_string_type): Likewise.
5061         * ada-lang.h (ada_is_character_type): Update declaration
5062         (ada_is_string_type): Likewise.
5063
5064 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5065
5066         Support style in 'frame|thread apply'
5067
5068         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5069         * record.c (record_start, record_stop): Update callers of
5070         execute_command_to_string with false.
5071         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5072         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5073         methods.
5074         (class string_file): New constructor with term_out parameter.
5075         Override methods term_out and can_emit_style_escape.  New member
5076         term_out.
5077         (class stdio_file): Override can_emit_style_escape.
5078         (class tee_file): Override term_out and can_emit_style_escape.
5079         * utils.h (can_emit_style_escape): Remove.
5080         * utils.c (can_emit_style_escape): Likewise.
5081         Update all callers of can_emit_style_escape (SOMESTREAM) to
5082         SOMESTREAM->can_emit_style_escape.
5083         * source-cache.c (source_cache::get_source_lines): Likewise.
5084         * stack.c (frame_apply_command_count): Call execute_command_to_string
5085         passing the term_out characteristic of the current gdb_stdout.
5086         * thread.c (thr_try_catch_cmd): Likewise.
5087         * top.c (execute_command_to_string): pass term_out parameter
5088         to construct the string_file for the command output.
5089         * ui-file.c (term_cli_styling): New function (most code moved
5090         from utils.c can_emit_style_escape).
5091         (string_file::string_file, string_file::can_emit_style_escape,
5092         stdio_file::can_emit_style_escape, tee_file::term_out,
5093         tee_file::can_emit_style_escape): New functions.
5094
5095 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5096
5097         * NEWS: Mention the new set|show may-call-functions.
5098         * infcall.c (may_call_functions_p): New variable.
5099         (show_may_call_functions_p): New function.
5100         (call_function_by_hand_dummy): Throws an error if not
5101         may-call-functions.
5102         (_initialize_infcall): Call add_setshow_boolean_cmd for
5103         may-call-functions.
5104
5105 2019-04-25  Keith Seitz  <keiths@redhat.com>
5106
5107         PR c++/24367
5108         * cp-support.c (inspect_type): Don't attempt substitutions
5109         of symbol with the same name.
5110
5111 2019-04-25  Tom Tromey  <tromey@adacore.com>
5112
5113         PR gdb/24475:
5114         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5115         static.
5116
5117 2019-04-25  Tom Tromey  <tromey@adacore.com>
5118
5119         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5120         rvalue reference.
5121         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5122         (gdb_xml_parser::parse): Use std::move.
5123         * python/python-internal.h (gdbpy_convert_exception): Take a const
5124         reference.
5125         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5126         std::move.
5127         * python/py-utils.c (gdbpy_convert_exception): Take a const
5128         reference.
5129         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5130         Use std::move.
5131         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5132         Use std::move.
5133         * mi/mi-main.c (mi_print_exception): Take a const reference.
5134         * main.c (handle_command_errors): Take a const reference.
5135         * linespec.c (parse_linespec): Use std::move.
5136         * infcall.c (run_inferior_call): Use std::move.
5137         (call_function_by_hand_dummy): Use std::move.
5138         * exec.c (try_open_exec_file): Use std::move.
5139         * exceptions.h (exception_print, exception_fprintf)
5140         (exception_print_same): Update.
5141         * exceptions.c (print_exception, exception_print)
5142         (exception_fprintf, exception_print_same): Change parameters to
5143         const reference.
5144         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5145         * common/new-op.c: Use std::move.
5146         * common/common-exceptions.h (struct gdb_exception): Add move
5147         constructor.
5148         (struct gdb_exception_error, struct gdb_exception_quit, struct
5149         gdb_quit_bad_alloc): Change constructor to move constructor.
5150         (throw_exception): Change parameter to rvalue reference.
5151         * common/common-exceptions.c (throw_exception): Take rvalue
5152         reference.
5153         * cli/cli-interp.c (safe_execute_command): Use std::move.
5154         * breakpoint.c (insert_bp_location, location_to_sals): Use
5155         std::move.
5156
5157 2019-04-25  Tom Tromey  <tromey@adacore.com>
5158
5159         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5160         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5161         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5162         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5163         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5164         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5165         guile/scm-value.c: Use unpack.
5166         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5167         gdbscm_gdb_exception.
5168         (gdbscm_throw_gdb_exception): Likewise.
5169         (struct gdbscm_gdb_exception): New.
5170         (unpack): New function.
5171         (gdbscm_wrap): Use unpack.
5172
5173 2019-04-25  Tom Tromey  <tromey@adacore.com>
5174
5175         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5176         (gdb_rl_callback_handler): Use std::move.
5177         * common/common-exceptions.h (struct gdb_exception): Add move
5178         assignment operator.
5179         (throw_exception_sjlj): Change "exception" to const reference.
5180         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5181         (throw_exception_sjlj): Change "exception" to const reference.
5182
5183 2019-04-25  Tom Tromey  <tromey@adacore.com>
5184
5185         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5186         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5187         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5188         Update.
5189         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5190         Update.
5191         * mi/mi-interp.c (mi_interp::exec): Update.
5192         * linespec.c (parse_linespec): Update.
5193         * infcall.c (run_inferior_call): Update.
5194         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5195         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5196         (gdbscm_lookup_global_symbol): Update.
5197         * guile/scm-param.c (gdbscm_parameter_value): Update.
5198         * guile/scm-frame.c (gdbscm_frame_read_register)
5199         (gdbscm_frame_read_var): Update.
5200         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5201         * exec.c (try_open_exec_file): Update.
5202         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5203         (gdb_rl_callback_handler): Update.
5204         * common/common-exceptions.h (exception_none): Don't declare.
5205         * common/common-exceptions.c (exception_none): Don't define.
5206         (struct catcher) <exception>: Update.
5207         * cli/cli-interp.c (safe_execute_command): Update.
5208         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5209
5210 2019-04-25  Ali Tamur  <tamur@google.com>
5211
5212         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5213         (read_attribute_value): Likewise.
5214         (dwarf2_read_addr_index): Update comment.
5215         (read_str_index): Add DW_FORM_strx.
5216         (dwarf2_string_attr): Likewise.
5217         (dwarf2_const_value_attr): Likewise.
5218         (dump_die_shallow): Likewise.
5219         (dwarf2_fetch_constant_bytes): Likewise.
5220         (skip_form_bytes): Likewise.
5221         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5222
5223 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5224
5225         PR corefiles/11608
5226         PR corefiles/18187
5227         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5228         OFFSET.  Verify if current mapping contains an ELF header.
5229         (linux_find_memory_regions_full): Adjust call to
5230         dump_mapping_p.
5231
5232 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5233             Kang Li <kanglictf@gmail.com>
5234
5235         PR gdb/21600
5236
5237         * dwarf2-frame.c (read_initial_length): Be consistent about using
5238         unsigned representation of length.
5239         (decode_frame_entry_1): Likewise.  Check for wraparound of
5240         end pointer as well as buffer overflow.
5241
5242 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5243
5244         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5245         "vq".
5246
5247 2019-04-24  Tom Tromey  <tromey@adacore.com>
5248
5249         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5250
5251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * s12z-tdep.c (s12z_unwind_pc): Delete.
5254         (s12z_unwind_sp): Delete.
5255         (s12z_gdbarch_init): Don't register deleted functions with
5256         gdbarch.
5257
5258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * rl78-tdep.c (rl78_unwind_sp): Delete.
5261         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5262
5263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5264
5265         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5266         (xstormy16_unwind_pc): Delete.
5267         (xstormy16_dummy_id): Delete.
5268         (xstormy16_gdbarch_init): Don't register deleted functions with
5269         gdbarch.
5270
5271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * vax-tdep.c (vax_unwind_pc): Delete.
5274         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5275
5276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5277
5278         * v850-tdep.c (v850_unwind_sp): Delete.
5279         (v850_unwind_pc): Delete.
5280         (v850_dummy_id): Delete.
5281         (v850_gdbarch_init): Don't register deleted functions with
5282         gdbarch.
5283
5284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5285
5286         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5287         (tilegx_unwind_pc): Delete.
5288         (tilegx_unwind_dummy_id): Delete.
5289         (tilegx_gdbarch_init): Don't register deleted functions with
5290         gdbarch.
5291
5292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5293
5294         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5295         (tic6x_dummy_id): Delete.
5296         (tic6x_gdbarch_init): Don't register deleted functions with
5297         gdbarch.
5298
5299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5300
5301         * sparc-tdep.c (sparc_unwind_pc): Delete.
5302         (sparc32_gdbarch_init): Don't register deleted function with
5303         gdbarch.
5304
5305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5306
5307         * sh-tdep.c (sh_unwind_sp): Delete.
5308         (sh_unwind_pc): Delete.
5309         (sh_dummy_id): Delete.
5310         (sh_gdbarch_init): Don't register deleted functions with
5311         gdbarch.
5312
5313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5314
5315         * score-tdep.c (score_unwind_sp): Delete.
5316         (score_unwind_pc): Delete.
5317         (score_dummy_id): Delete.
5318         (score_gdbarch_init): Don't register deleted functions with
5319         gdbarch.
5320
5321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5322
5323         * rx-tdep.c (rx_unwind_pc): Delete.
5324         (rx_unwind_sp): Delete.
5325         (rx_dummy_id): Delete.
5326         (rx_gdbarch_init): Don't register deleted functions with
5327         gdbarch.  Update comment.
5328
5329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5330
5331         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5332         (rs6000_dummy_id): Delete.
5333         (rs6000_gdbarch_init): Don't register deleted functions with
5334         gdbarch.
5335
5336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * or1k-tdep.c (or1k_dummy_id): Delete.
5339         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5340
5341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5342
5343         * nios2-tdep.c (nios2_dummy_id): Delete.
5344         (nios2_unwind_sp): Delete.
5345         (nios2_gdbarch_init): Don't register deleted functions with
5346         gdbarch.
5347
5348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         * nds32-tdep.c (nds32_dummy_id): Delete.
5351         (nds32_unwind_pc): Delete.
5352         (nds32_unwind_sp): Delete.
5353         (nds32_gdbarch_init): Don't register deleted functions with
5354         gdbarch.
5355
5356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * msp430-tdep.c (msp430_unwind_pc): Delete.
5359         (msp430_unwind_sp): Delete.
5360         (msp430_dummy_id): Delete.
5361         (msp430_gdbarch_init): Don't register deleted functions with
5362         gdbarch.
5363
5364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * moxie-tdep.c (moxie_unwind_sp): Delete.
5367         (moxie_unwind_pc): Delete.
5368         (moxie_dummy_id): Delete.
5369         (moxie_gdbarch_init): Don't register deleted functions with
5370         gdbarch.
5371
5372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5373
5374         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5375         (mn10300_unwind_pc): Delete.
5376         (mn10300_unwind_sp): Delete.
5377         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5378         mn10300_unwind_sp.
5379         (mn10300_frame_unwind_init): Don't register deleted functions with
5380         gdbarch.
5381
5382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5383
5384         * mep-tdep.c (mep_unwind_pc): Delete.
5385         (mep_unwind_sp): Delete.
5386         (mep_dummy_id): Delete.
5387         (mep_gdbarch_init): Don't register deleted functions with
5388         gdbarch.
5389
5390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5393         (m68hc11_unwind_sp): Delete.
5394         (m68hc11_gdbarch_init): Don't register deleted functions with
5395         gdbarch.
5396
5397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5398
5399         * m32r-tdep.c (m32r_unwind_sp): Delete.
5400         (m32r_unwind_pc): Delete.
5401         (m32r_dummy_id): Delete.
5402         (m32r_gdbarch_init): Don't register deleted functions with
5403         gdbarch.
5404
5405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5406
5407         * m32c-tdep.c (m32c_unwind_pc): Delete.
5408         (m32c_unwind_sp): Delete.
5409         (m32c_dummy_id): Delete.
5410         (m32c_gdbarch_init): Don't register deleted functions with
5411         gdbarch.
5412
5413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5414
5415         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5416         (lm32_unwind_pc): Delete.
5417         (lm32_dummy_id): Delete.
5418         (lm32_gdbarch_init): Don't register deleted functions with
5419         gdbarch.
5420
5421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5422
5423         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5424         (iq2000_unwind_pc): Delete.
5425         (iq2000_dummy_id): Delete.
5426         (iq2000_gdbarch_init): Don't register deleted functions with
5427         gdbarch.
5428
5429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5430
5431         * nds32-tdep.c (nds32_type_align): Delete.
5432         (nds32_push_dummy_call): Use type_align instead.
5433
5434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5435
5436         * arm-tdep.c (arm_type_align): Only handle vector override case.
5437         (arm_push_dummy_call): Use type_align.
5438         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5439
5440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5441
5442         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5443         case.
5444         (pass_on_stack): Use type_align.
5445         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5446         function.
5447
5448 2019-04-23  Tom Tromey  <tromey@adacore.com>
5449
5450         * dwarf2read.c (line_header::file_name_at): Remove unused
5451         overload.
5452
5453 2019-04-23  Tom de Vries  <tdevries@suse.de>
5454
5455         PR gdb/24438
5456         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5457         invocation.
5458
5459
5460 2019-03-27  Ali Tamur  <tamur@google.com>
5461
5462         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5463         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5464         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5465         (dwarf_expr_context::get_addr_index): Likewise
5466         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5467         (symbol_needs_eval_context::get_addr_index): Likewise
5468         (disassemble_dwarf_expression): Add DW_OP_addrx
5469         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5470         (read_cutu_die_from_dwo): Update comment
5471         (skip_one_die): Add DW_FORM_addrx
5472         (read_attribute_value): Likewise
5473         (var_decode_location): Add DW_OP_addrx
5474         (dwarf2_const_value_attr): Add DW_FORM_addrx
5475         (dump_die_shallow): Likewise
5476         (dwarf2_fetch_constant_bytes): Likewise
5477         (decode_locdesc): Add DW_OP_addrx
5478         (skip_form_bytes): Add DW_FORM_addrx
5479
5480 2019-04-22  Ali Tamur  <tamur@google.com>
5481
5482         * MAINTAINERS (Write After Approval): Add self.
5483
5484 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5485
5486         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5487         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5488         (open_symbol_file_object): Likewise.
5489         (svr4_default_sos): Add info parameter.
5490         (svr4_read_so_list): Likewise.
5491         (svr4_current_sos_direct): Adjust functions calls to pass down
5492         info.
5493         (svr4_current_sos_1): Add info parameter.
5494         (svr4_current_sos): Call get_svr4_info, pass info down to
5495         svr4_current_sos_1.
5496         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5497         get_svr4_info.
5498         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5499         get_svr4_info.
5500         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5501         to get_svr4_info.
5502         (probes_table_remove_objfile_probes): Likewise.
5503         (register_solib_event_probe): Add info parameter.
5504         (solist_update_incremental): Pass info parameter down to
5505         svr4_read_so_list.
5506         (disable_probes_interface): Add info parameter.
5507         (svr4_handle_solib_event): Pass current_program_space to
5508         get_svr4_info.  Adjust disable_probes_interface cleanup.
5509         (svr4_create_probe_breakpoints): Add info parameter, pass it
5510         down to register_solib_event_probe.
5511         (svr4_create_solib_event_breakpoints): Add info parameter,
5512         pass it down to svr4_create_probe_breakpoints.
5513         (enable_break): Pass info down to
5514         svr4_create_solib_event_breakpoints.
5515         (svr4_solib_create_inferior_hook): Pass current_program_space to
5516         get_svr4_info.
5517         (svr4_clear_solib): Likewise.
5518
5519 2019-04-22  Pedro Alves  <palves@redhat.com>
5520
5521         * solib-svr4.c (svr4_free_objfile_observer): New.
5522         (probe_and_action::objfile): New field.
5523         (probes_table_htab_remove_objfile_probes)
5524         (probes_table_remove_objfile_probes): New functions.
5525         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5526         in the new probe_and_action.  Don't store the probe in 'lookup'.
5527         (svr4_create_probe_breakpoints): Pass objfile to
5528         register_solib_event_probe.
5529         (_initialize_svr4_solib): Register a free_objfile observer.
5530
5531 2019-04-19  Tom Tromey  <tom@tromey.com>
5532
5533         * common/queue.h: Remove.
5534
5535 2019-04-19  Tom Tromey  <tom@tromey.com>
5536
5537         * event-loop.c: Don't include "common/queue.h".
5538
5539 2019-04-19  Tom Tromey  <tom@tromey.com>
5540
5541         * remote.c (remote_target): Use delete.
5542         * remote-notif.h: Include <list>, not "common/queue.h".
5543         (notif_client_p): Remove typedef.
5544         (remote_notif_state): Add constructor, destructor, initializer.
5545         <notif_queue>: Now a std::list.
5546         (remote_notif_state_xfree): Don't declare.
5547         * remote-notif.c (remote_notif_process, handle_notification)
5548         (remote_notif_state_allocate): Update.
5549         (~remote_notif_state): Rename from remote_notif_state_xfree.
5550
5551 2019-04-19  Tom Tromey  <tom@tromey.com>
5552
5553         * symfile.c (reread_symbols): Update.
5554         * objfiles.c (objfile_register_static_link)
5555         (objfile_lookup_static_link): Update
5556         (~objfile) Don't delete static_links.
5557         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5558
5559 2019-04-19  Tom Tromey  <tom@tromey.com>
5560
5561         * type-stack.h (struct type_stack) <insert>: Constify string.
5562         * type-stack.c (type_stack::insert): Constify string.
5563         * gdbtypes.h (lookup_template_type): Update.
5564         (address_space_name_to_int): Update.
5565         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5566         const.
5567         (lookup_template_type): Make name const.
5568         * c-exp.y: Update rules.
5569         (lex_one_token, classify_name, classify_inner_name)
5570         (c_print_token): Update.
5571         * p-exp.y: Update rules.
5572         (yylex): Update.
5573         * f-exp.y: Update rules.
5574         (yylex): Update.
5575         * d-exp.y: Update rules.
5576         (lex_one_token, classify_name, classify_inner_name): Update.
5577         * parse.c (write_dollar_variable, copy_name): Return std::string.
5578         * parser-defs.h (copy_name): Change return type.
5579         * m2-exp.y: Update rules.
5580         (yylex): Update.
5581         * go-exp.y (lex_one_token): Update.
5582         Update rules.
5583         (classify_unsafe_function, classify_packaged_name)
5584         (classify_name, yylex): Update.
5585
5586 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5587
5588         * configure.ac: add --enable-source-highlight switch.
5589         * configure: Regenerate.
5590         * top.c (print_gdb_version): plumb --enable-source-highlight
5591         status to "show configuration".
5592
5593 2019-04-19  Tom Tromey  <tromey@adacore.com>
5594
5595         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5596         Check ADA_TYPE_P.
5597         (empty_record, ada_template_to_fixed_record_type_1)
5598         (template_to_static_fixed_type)
5599         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5600         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5601         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5602         macros.
5603
5604 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5605
5606         PR symtab/24423:
5607         * source.c (print_source_lines_base): Advance "iter" when a
5608         control character is seen.
5609
5610 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5611
5612         * inferior.h (struct infcall_suspend_state_deleter):
5613         Catch exception in destructor to avoid crash.
5614
5615 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5616
5617         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5618         close to the add_com "shell".
5619
5620 2019-04-18  Tom Tromey  <tromey@adacore.com>
5621
5622         * process-stratum-target.h (class process_stratum_target)
5623         <stratum>: Add "final".
5624
5625 2019-04-17  Tom Tromey  <tromey@adacore.com>
5626
5627         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5628         against nullptr before use.
5629
5630 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5631
5632         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5633
5634 2019-04-17  Jim Wilson  <jimw@sifive.com>
5635             Andrew Burgess  <andrew.burgess@embecosm.com>
5636
5637         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5638         code read might fail, assume 4-byte breakpoint in that case.
5639
5640 2019-04-15  Leszek Swirski  <leszeks@google.com>
5641
5642         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5643         rather than a hand-rolled POD check when checking for forced MEMORY
5644         classification.
5645
5646 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5647
5648         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5649         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5650         function.
5651         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5652         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5653         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5654         declaration.
5655
5656 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5657
5658         * aarch64-linux-nat.c
5659         (aarch64_linux_nat_target::thread_architecture): Add override.
5660         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5661         each VQ.
5662
5663 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5664
5665         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5666
5667 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5668
5669         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5670         target types of size 96-bits, add some additional comments, and
5671         check that the builtin type we found was the correct size.
5672
5673 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5674
5675         * utils.c (prompt_for_continue): Don't restore the styling at the
5676         end, as applied_style has the wrong value.  This fixes styling in
5677         long lists of file names that are interrupted by the "Continue?"
5678         prompt.
5679
5680 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5681
5682         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5683         * c-lang.c (c_language_defn): Likewise.
5684         (cplus_language_defn): Likewise.
5685         (asm_language_defn): Likewise.
5686         (minimal_language_defn): Likewise.
5687         * d-lang.c (d_language_defn): Likewise.
5688         * f-lang.c (f_language_defn): Likewise.
5689         * go-lang.c (go_language_defn): Likewise.
5690         * language.c (unknown_language_defn): Likewise.
5691         (auto_language_defn): Likewise.
5692         * language.h (struct language_defn): Remove la_magic field.
5693         (LANG_MAGIC): Delete.
5694         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5695         * objc-lang.c (objc_language_defn): Likewise.
5696         * opencl-lang.c (opencl_language_defn): Likewise.
5697         * p-lang.c (pascal_language_defn): Likewise.
5698         * rust-lang.c (rust_language_defn): Likewise.
5699
5700 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5701
5702         * riscv-tdep.c (riscv_type_align): New function.
5703         (riscv_type_alignment): Delete.
5704         (riscv_arg_location): Use 'type_align'.
5705         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5706
5707 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5708
5709         * gdbtypes.c (type_align): A struct with no non-static fields also
5710         has alignment of 1.
5711
5712 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5713
5714         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5715         component to 0.
5716         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5717         member.
5718         (riscv_struct_info::analyse): New implementation using new
5719         analyse_inner member function.
5720         (riscv_struct_info::field_offset): New member function.
5721         (riscv_struct_info::m_offsets): New member variable.
5722         (riscv_struct_info::analyse_inner): New private member function,
5723         takes the old implementation of riscv_struct_info::analyse but
5724         extended to track field offsets.
5725         (riscv_call_arg_struct): Update the struct folding special cases
5726         to handle cases where empty C++ structs, which are non-zero
5727         length, are found.
5728         (riscv_arg_location): Initialise the length of each location, a
5729         non-zero length now indicates the location is in use.
5730         (riscv_push_dummy_call): Allow for the first location having a
5731         non-zero offset when setting up arguments.
5732         (riscv_return_value): Likewise, but for return values.
5733
5734 2019-04-11  Tom Tromey  <tromey@adacore.com>
5735
5736         * utils.c (internal_vproblem): Make "msg" const.
5737
5738 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5739
5740         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5741         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5742         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5743         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5744
5745 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5746
5747         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5748         function.
5749         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5750         of amd64_collect_native_gregset.
5751         (amd64_linux_nat_target::store_registers): Likewise.
5752
5753 2019-04-10  Tom Tromey  <tom@tromey.com>
5754
5755         * symtab.c (lookup_global_symbol_from_objfile)
5756         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5757         * objfiles.h (class separate_debug_iterator): New.
5758         (class separate_debug_range): New.
5759         (struct objfile) <separate_debug_objfiles>: New method.
5760         (objfile_separate_debug_iterate): Don't declare.
5761         * objfiles.c (separate_debug_iterator::operator++): Rename from
5762         objfile_separate_debug_iterate.
5763         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5764         iterator.
5765         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5766         iterator.
5767
5768 2019-04-10  Tom Tromey  <tom@tromey.com>
5769
5770         * symfile.c (reread_symbols): Remove old comment.
5771         * objfiles.c (free_all_objfiles): Fix a typo.
5772
5773 2019-04-10  Tom Tromey  <tom@tromey.com>
5774
5775         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5776         * minsyms.c (lookup_minimal_symbol): Use foreach.
5777         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5778         (lookup_minimal_symbol_solib_trampoline): Likewise.
5779         * symfile.c (reread_symbols): Use foreach.
5780
5781 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5782             Tom Tromey  <tromey@adacore.com>
5783
5784         PR rust/24414:
5785         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5786         (rust_lex_int_test): Change "value" to be LONGEST.
5787         (rust_lex_tests): Add test for long integer literal.
5788
5789 2019-04-09  Tom Tromey  <tromey@adacore.com>
5790
5791         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5792         to bool.
5793         (extended_remote_target::attach): Update.
5794         (remote_target::remote_notice_new_inferior): Update.
5795         (remote_target::add_current_inferior_and_thread): Update.
5796         * inferior.c (exit_inferior_1): Use "false".
5797         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5798
5799 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5800
5801         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5802         the "start" command.
5803
5804 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5805
5806         * python/py-inferior.c (infpy_thread_from_thread_handle):
5807         Adjust comments to reflect renaming of thread_from_thread_handle
5808         to thread_from_handle.  Adjust keywords.  Fix type error message.
5809         (inferior_object_methods): Add thread_from_handle.  Retain
5810         thread_from_thread_handle, but mark it as deprecated.
5811
5812 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5813
5814         * gdbthread.h (find_thread_by_handle): Revise declaration.
5815         * thread.c (find_thread_by_handle): Likewise.  Adjust
5816         implementation too.
5817         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5818         support for buffer objects as handles.
5819
5820 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5821
5822         * python/py-infthread.c (thpy_thread_handle): New function.
5823         (thread_object_methods): Register thpy_thread_handle.
5824
5825 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5826
5827         * gdbthread.h (thread_to_thread_handle): Declare.
5828         * thread.c (gdbtypes.h): Include.
5829         (thread_to_thread_handle): New function.
5830
5831         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5832         (target_thread_info_to_thread_handle): Declare.
5833         * target.c (target_thread_info_to_thread_handle): New function.
5834         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5835         * target-delegates.c: Regenerate.
5836
5837         * linux-thread-db.c (class thread_db_target): Add method
5838         thread_info_to_thread_handle.
5839         (thread_db_target::thread_info_to_thread_handle): Define.
5840         * remote.c (class remote_target): Add new method
5841         thread_info_to_thread_handle.
5842         (remote_target::thread_info_to_thread_handle): Define.
5843
5844 2019-04-08  Pedro Alves  <palves@redhat.com>
5845
5846         * common/common-exceptions.c (throw_exception): Don't create
5847         named object to throw; throw directly.
5848         (throw_it): Likewise.  Don't initialize gdb_exception::message
5849         here, with new; pass FMT and AP to the ctor instead.
5850         * common/common-exceptions.h: Include <string>.
5851         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5852         const char *, va_list)): New ctor.  Use std::make_shared.
5853         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5854         errors)): Delete.
5855         (gdb_exception_error::gdb_exception_error(enum errors, const char
5856         *, va_list)): New.
5857         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5858         Add assertion.
5859         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5860         errors)): Delete.
5861         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5862         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5863         Add assertion.
5864
5865 2019-04-08  Tom Tromey  <tom@tromey.com>
5866
5867         * valops.c (value_rtti_indirect_type): Replace throw_exception
5868         with throw.
5869         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5870         with throw.
5871         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5872         throw.
5873         * target.c (target_translate_tls_address): Replace throw_exception
5874         with throw.
5875         * stack.c (frame_apply_command_count): Replace throw_exception
5876         with throw.
5877         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5878         throw.
5879         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5880         with throw.
5881         * rs6000-tdep.c (rs6000_frame_cache)
5882         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5883         * remote.c: Replace throw_exception with throw.
5884         * record-full.c (record_full_message, record_full_wait_1)
5885         (record_full_restore): Replace throw_exception with throw.
5886         * record-btrace.c:
5887         (get_thread_current_frame_id, record_btrace_start_replaying)
5888         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5889         (cmd_record_btrace_start): Replace throw_exception with throw.
5890         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5891         throw.
5892         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5893         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5894         * linespec.c:
5895         (find_linespec_symbols): Replace throw_exception with throw.
5896         * infrun.c (displaced_step_prepare, resume): Replace
5897         throw_exception with throw.
5898         * infcmd.c (post_create_inferior): Replace throw_exception with
5899         throw.
5900         * inf-loop.c (inferior_event_handler): Replace throw_exception
5901         with throw.
5902         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5903         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5904         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5905         (get_prev_frame_always, get_frame_pc_if_available)
5906         (get_frame_address_in_block_if_available, get_frame_language):
5907         Replace throw_exception with throw.
5908         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5909         throw_exception with throw.
5910         * eval.c (fetch_subexp_value, evaluate_var_value)
5911         (evaluate_funcall, evaluate_subexp_standard): Replace
5912         throw_exception with throw.
5913         * dwarf2loc.c (call_site_find_chain)
5914         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5915         Replace throw_exception with throw.
5916         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5917         with throw.
5918         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5919         throw.
5920         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5921         * completer.c (complete_line_internal): Replace throw_exception
5922         with throw.
5923         * compile/compile-object-run.c (compile_object_run): Replace
5924         throw_exception with throw.
5925         * cli/cli-script.c (process_next_line): Replace throw_exception
5926         with throw.
5927         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5928         (btrace_enable, btrace_maint_update_pt_packets): Replace
5929         throw_exception with throw.
5930         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5931         throw_exception with throw.
5932         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5933         throw_exception with throw.
5934         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5935         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5936         * aarch64-tdep.c (aarch64_make_prologue_cache)
5937         (aarch64_make_stub_cache): Replace throw_exception with throw.
5938
5939 2019-04-08  Tom Tromey  <tom@tromey.com>
5940
5941         * common/common-exceptions.c (throw_exception): Rename from
5942         throw_exception_cxx.  Remove old copy.  Make argument const.
5943         (throw_it): Create and throw exception objects directly.
5944         * common/common-exceptions.h (throw_exception): Make argument
5945         const.
5946         (struct gdb_exception_error): Add constructor.
5947         (struct gdb_exception_quit): Add constructor.
5948
5949 2019-04-08  Tom Tromey  <tom@tromey.com>
5950
5951         * common/common-exceptions.h (exception_rethrow): Don't declare.
5952         (TRY_SJLJ): Update comment.
5953         (TRY, CATCH, END_CATCH): Remove.
5954         * common/common-exceptions.c (exception_rethrow): Remove.
5955
5956 2019-04-08  Tom Tromey  <tom@tromey.com>
5957
5958         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5959         Remove.
5960         (gdb_exception_error): Rename from
5961         gdb_exception_RETURN_MASK_ERROR.
5962         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5963         (gdb_quit_bad_alloc): Update.
5964         * aarch64-tdep.c: Update.
5965         * ada-lang.c: Update.
5966         * ada-typeprint.c: Update.
5967         * ada-valprint.c: Update.
5968         * amd64-tdep.c: Update.
5969         * arch-utils.c: Update.
5970         * break-catch-throw.c: Update.
5971         * breakpoint.c: Update.
5972         * btrace.c: Update.
5973         * c-varobj.c: Update.
5974         * cli/cli-cmds.c: Update.
5975         * cli/cli-interp.c: Update.
5976         * cli/cli-script.c: Update.
5977         * common/common-exceptions.c: Update.
5978         * common/new-op.c: Update.
5979         * common/selftest.c: Update.
5980         * compile/compile-c-symbols.c: Update.
5981         * compile/compile-cplus-symbols.c: Update.
5982         * compile/compile-object-load.c: Update.
5983         * compile/compile-object-run.c: Update.
5984         * completer.c: Update.
5985         * corelow.c: Update.
5986         * cp-abi.c: Update.
5987         * cp-support.c: Update.
5988         * cp-valprint.c: Update.
5989         * darwin-nat.c: Update.
5990         * disasm-selftests.c: Update.
5991         * dtrace-probe.c: Update.
5992         * dwarf-index-cache.c: Update.
5993         * dwarf-index-write.c: Update.
5994         * dwarf2-frame-tailcall.c: Update.
5995         * dwarf2-frame.c: Update.
5996         * dwarf2loc.c: Update.
5997         * dwarf2read.c: Update.
5998         * eval.c: Update.
5999         * event-loop.c: Update.
6000         * event-top.c: Update.
6001         * exec.c: Update.
6002         * f-valprint.c: Update.
6003         * fbsd-tdep.c: Update.
6004         * frame-unwind.c: Update.
6005         * frame.c: Update.
6006         * gdbtypes.c: Update.
6007         * gnu-v3-abi.c: Update.
6008         * guile/guile-internal.h: Update.
6009         * guile/scm-block.c: Update.
6010         * guile/scm-breakpoint.c: Update.
6011         * guile/scm-cmd.c: Update.
6012         * guile/scm-disasm.c: Update.
6013         * guile/scm-frame.c: Update.
6014         * guile/scm-lazy-string.c: Update.
6015         * guile/scm-math.c: Update.
6016         * guile/scm-param.c: Update.
6017         * guile/scm-ports.c: Update.
6018         * guile/scm-pretty-print.c: Update.
6019         * guile/scm-symbol.c: Update.
6020         * guile/scm-symtab.c: Update.
6021         * guile/scm-type.c: Update.
6022         * guile/scm-value.c: Update.
6023         * i386-linux-tdep.c: Update.
6024         * i386-tdep.c: Update.
6025         * inf-loop.c: Update.
6026         * infcall.c: Update.
6027         * infcmd.c: Update.
6028         * infrun.c: Update.
6029         * jit.c: Update.
6030         * language.c: Update.
6031         * linespec.c: Update.
6032         * linux-fork.c: Update.
6033         * linux-nat.c: Update.
6034         * linux-tdep.c: Update.
6035         * linux-thread-db.c: Update.
6036         * main.c: Update.
6037         * mi/mi-cmd-break.c: Update.
6038         * mi/mi-cmd-stack.c: Update.
6039         * mi/mi-interp.c: Update.
6040         * mi/mi-main.c: Update.
6041         * objc-lang.c: Update.
6042         * p-valprint.c: Update.
6043         * parse.c: Update.
6044         * ppc-linux-tdep.c: Update.
6045         * printcmd.c: Update.
6046         * python/py-arch.c: Update.
6047         * python/py-breakpoint.c: Update.
6048         * python/py-cmd.c: Update.
6049         * python/py-finishbreakpoint.c: Update.
6050         * python/py-frame.c: Update.
6051         * python/py-framefilter.c: Update.
6052         * python/py-gdb-readline.c: Update.
6053         * python/py-inferior.c: Update.
6054         * python/py-infthread.c: Update.
6055         * python/py-lazy-string.c: Update.
6056         * python/py-linetable.c: Update.
6057         * python/py-objfile.c: Update.
6058         * python/py-param.c: Update.
6059         * python/py-prettyprint.c: Update.
6060         * python/py-progspace.c: Update.
6061         * python/py-record-btrace.c: Update.
6062         * python/py-record.c: Update.
6063         * python/py-symbol.c: Update.
6064         * python/py-type.c: Update.
6065         * python/py-unwind.c: Update.
6066         * python/py-utils.c: Update.
6067         * python/py-value.c: Update.
6068         * python/python.c: Update.
6069         * record-btrace.c: Update.
6070         * record-full.c: Update.
6071         * remote-fileio.c: Update.
6072         * remote.c: Update.
6073         * riscv-tdep.c: Update.
6074         * rs6000-aix-tdep.c: Update.
6075         * rs6000-tdep.c: Update.
6076         * rust-exp.y: Update.
6077         * rust-lang.c: Update.
6078         * s390-tdep.c: Update.
6079         * selftest-arch.c: Update.
6080         * solib-dsbt.c: Update.
6081         * solib-frv.c: Update.
6082         * solib-spu.c: Update.
6083         * solib-svr4.c: Update.
6084         * solib.c: Update.
6085         * sparc64-linux-tdep.c: Update.
6086         * stack.c: Update.
6087         * symfile-mem.c: Update.
6088         * symmisc.c: Update.
6089         * target.c: Update.
6090         * thread.c: Update.
6091         * top.c: Update.
6092         * tracefile-tfile.c: Update.
6093         * tui/tui.c: Update.
6094         * typeprint.c: Update.
6095         * unittests/cli-utils-selftests.c: Update.
6096         * unittests/parse-connection-spec-selftests.c: Update.
6097         * valops.c: Update.
6098         * valprint.c: Update.
6099         * value.c: Update.
6100         * varobj.c: Update.
6101         * windows-nat.c: Update.
6102         * x86-linux-nat.c: Update.
6103         * xml-support.c: Update.
6104
6105 2019-04-08  Tom Tromey  <tom@tromey.com>
6106
6107         * xml-support.c: Use C++ exception handling.
6108         * x86-linux-nat.c: Use C++ exception handling.
6109         * windows-nat.c: Use C++ exception handling.
6110         * varobj.c: Use C++ exception handling.
6111         * value.c: Use C++ exception handling.
6112         * valprint.c: Use C++ exception handling.
6113         * valops.c: Use C++ exception handling.
6114         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6115         handling.
6116         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6117         * typeprint.c: Use C++ exception handling.
6118         * tui/tui.c: Use C++ exception handling.
6119         * tracefile-tfile.c: Use C++ exception handling.
6120         * top.c: Use C++ exception handling.
6121         * thread.c: Use C++ exception handling.
6122         * target.c: Use C++ exception handling.
6123         * symmisc.c: Use C++ exception handling.
6124         * symfile-mem.c: Use C++ exception handling.
6125         * stack.c: Use C++ exception handling.
6126         * sparc64-linux-tdep.c: Use C++ exception handling.
6127         * solib.c: Use C++ exception handling.
6128         * solib-svr4.c: Use C++ exception handling.
6129         * solib-spu.c: Use C++ exception handling.
6130         * solib-frv.c: Use C++ exception handling.
6131         * solib-dsbt.c: Use C++ exception handling.
6132         * selftest-arch.c: Use C++ exception handling.
6133         * s390-tdep.c: Use C++ exception handling.
6134         * rust-lang.c: Use C++ exception handling.
6135         * rust-exp.y: Use C++ exception handling.
6136         * rs6000-tdep.c: Use C++ exception handling.
6137         * rs6000-aix-tdep.c: Use C++ exception handling.
6138         * riscv-tdep.c: Use C++ exception handling.
6139         * remote.c: Use C++ exception handling.
6140         * remote-fileio.c: Use C++ exception handling.
6141         * record-full.c: Use C++ exception handling.
6142         * record-btrace.c: Use C++ exception handling.
6143         * python/python.c: Use C++ exception handling.
6144         * python/py-value.c: Use C++ exception handling.
6145         * python/py-utils.c: Use C++ exception handling.
6146         * python/py-unwind.c: Use C++ exception handling.
6147         * python/py-type.c: Use C++ exception handling.
6148         * python/py-symbol.c: Use C++ exception handling.
6149         * python/py-record.c: Use C++ exception handling.
6150         * python/py-record-btrace.c: Use C++ exception handling.
6151         * python/py-progspace.c: Use C++ exception handling.
6152         * python/py-prettyprint.c: Use C++ exception handling.
6153         * python/py-param.c: Use C++ exception handling.
6154         * python/py-objfile.c: Use C++ exception handling.
6155         * python/py-linetable.c: Use C++ exception handling.
6156         * python/py-lazy-string.c: Use C++ exception handling.
6157         * python/py-infthread.c: Use C++ exception handling.
6158         * python/py-inferior.c: Use C++ exception handling.
6159         * python/py-gdb-readline.c: Use C++ exception handling.
6160         * python/py-framefilter.c: Use C++ exception handling.
6161         * python/py-frame.c: Use C++ exception handling.
6162         * python/py-finishbreakpoint.c: Use C++ exception handling.
6163         * python/py-cmd.c: Use C++ exception handling.
6164         * python/py-breakpoint.c: Use C++ exception handling.
6165         * python/py-arch.c: Use C++ exception handling.
6166         * printcmd.c: Use C++ exception handling.
6167         * ppc-linux-tdep.c: Use C++ exception handling.
6168         * parse.c: Use C++ exception handling.
6169         * p-valprint.c: Use C++ exception handling.
6170         * objc-lang.c: Use C++ exception handling.
6171         * mi/mi-main.c: Use C++ exception handling.
6172         * mi/mi-interp.c: Use C++ exception handling.
6173         * mi/mi-cmd-stack.c: Use C++ exception handling.
6174         * mi/mi-cmd-break.c: Use C++ exception handling.
6175         * main.c: Use C++ exception handling.
6176         * linux-thread-db.c: Use C++ exception handling.
6177         * linux-tdep.c: Use C++ exception handling.
6178         * linux-nat.c: Use C++ exception handling.
6179         * linux-fork.c: Use C++ exception handling.
6180         * linespec.c: Use C++ exception handling.
6181         * language.c: Use C++ exception handling.
6182         * jit.c: Use C++ exception handling.
6183         * infrun.c: Use C++ exception handling.
6184         * infcmd.c: Use C++ exception handling.
6185         * infcall.c: Use C++ exception handling.
6186         * inf-loop.c: Use C++ exception handling.
6187         * i386-tdep.c: Use C++ exception handling.
6188         * i386-linux-tdep.c: Use C++ exception handling.
6189         * guile/scm-value.c: Use C++ exception handling.
6190         * guile/scm-type.c: Use C++ exception handling.
6191         * guile/scm-symtab.c: Use C++ exception handling.
6192         * guile/scm-symbol.c: Use C++ exception handling.
6193         * guile/scm-pretty-print.c: Use C++ exception handling.
6194         * guile/scm-ports.c: Use C++ exception handling.
6195         * guile/scm-param.c: Use C++ exception handling.
6196         * guile/scm-math.c: Use C++ exception handling.
6197         * guile/scm-lazy-string.c: Use C++ exception handling.
6198         * guile/scm-frame.c: Use C++ exception handling.
6199         * guile/scm-disasm.c: Use C++ exception handling.
6200         * guile/scm-cmd.c: Use C++ exception handling.
6201         * guile/scm-breakpoint.c: Use C++ exception handling.
6202         * guile/scm-block.c: Use C++ exception handling.
6203         * guile/guile-internal.h: Use C++ exception handling.
6204         * gnu-v3-abi.c: Use C++ exception handling.
6205         * gdbtypes.c: Use C++ exception handling.
6206         * frame.c: Use C++ exception handling.
6207         * frame-unwind.c: Use C++ exception handling.
6208         * fbsd-tdep.c: Use C++ exception handling.
6209         * f-valprint.c: Use C++ exception handling.
6210         * exec.c: Use C++ exception handling.
6211         * event-top.c: Use C++ exception handling.
6212         * event-loop.c: Use C++ exception handling.
6213         * eval.c: Use C++ exception handling.
6214         * dwarf2read.c: Use C++ exception handling.
6215         * dwarf2loc.c: Use C++ exception handling.
6216         * dwarf2-frame.c: Use C++ exception handling.
6217         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6218         * dwarf-index-write.c: Use C++ exception handling.
6219         * dwarf-index-cache.c: Use C++ exception handling.
6220         * dtrace-probe.c: Use C++ exception handling.
6221         * disasm-selftests.c: Use C++ exception handling.
6222         * darwin-nat.c: Use C++ exception handling.
6223         * cp-valprint.c: Use C++ exception handling.
6224         * cp-support.c: Use C++ exception handling.
6225         * cp-abi.c: Use C++ exception handling.
6226         * corelow.c: Use C++ exception handling.
6227         * completer.c: Use C++ exception handling.
6228         * compile/compile-object-run.c: Use C++ exception handling.
6229         * compile/compile-object-load.c: Use C++ exception handling.
6230         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6231         * compile/compile-c-symbols.c: Use C++ exception handling.
6232         * common/selftest.c: Use C++ exception handling.
6233         * common/new-op.c: Use C++ exception handling.
6234         * cli/cli-script.c: Use C++ exception handling.
6235         * cli/cli-interp.c: Use C++ exception handling.
6236         * cli/cli-cmds.c: Use C++ exception handling.
6237         * c-varobj.c: Use C++ exception handling.
6238         * btrace.c: Use C++ exception handling.
6239         * breakpoint.c: Use C++ exception handling.
6240         * break-catch-throw.c: Use C++ exception handling.
6241         * arch-utils.c: Use C++ exception handling.
6242         * amd64-tdep.c: Use C++ exception handling.
6243         * ada-valprint.c: Use C++ exception handling.
6244         * ada-typeprint.c: Use C++ exception handling.
6245         * ada-lang.c: Use C++ exception handling.
6246         * aarch64-tdep.c: Use C++ exception handling.
6247
6248 2019-04-08  Tom Tromey  <tom@tromey.com>
6249
6250         * xml-support.c (gdb_xml_parser::parse): Update.
6251         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6252         * value.c (show_convenience): Update.
6253         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6254         (test_parse_flags_qcs): Update.
6255         * thread.c (thr_try_catch_cmd): Update.
6256         * target.c (target_translate_tls_address): Update.
6257         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6258         (info_frame_command_core, frame_apply_command_count): Update.
6259         * rust-exp.y (rust_lex_exception_test): Update.
6260         * riscv-tdep.c (riscv_print_one_register_info): Update.
6261         * remote.c (remote_target::enable_btrace): Update.
6262         * record-btrace.c (record_btrace_enable_warn): Update.
6263         * python/py-utils.c (gdbpy_convert_exception): Update.
6264         * printcmd.c (do_one_display, print_variable_and_value): Update.
6265         * mi/mi-main.c (mi_print_exception): Update.
6266         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6267         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6268         * linux-nat.c (linux_nat_target::attach): Update.
6269         * linux-fork.c (class scoped_switch_fork_info): Update.
6270         * infrun.c (displaced_step_prepare): Update.
6271         * infcall.c (call_function_by_hand_dummy): Update.
6272         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6273         * gnu-v3-abi.c (print_one_vtable): Update.
6274         * frame.c (get_prev_frame_always): Update.
6275         * f-valprint.c (info_common_command_for_block): Update.
6276         * exec.c (try_open_exec_file): Update.
6277         * exceptions.c (print_exception, exception_print)
6278         (exception_fprintf, exception_print_same): Update.
6279         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6280         * dwarf-index-cache.c (index_cache::store)
6281         (index_cache::lookup_gdb_index): Update.
6282         * darwin-nat.c (maybe_cache_shell): Update.
6283         * cp-valprint.c (cp_print_value_fields): Update.
6284         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6285         (gcc_cplus_symbol_address): Update.
6286         * compile/compile-c-symbols.c (gcc_convert_symbol)
6287         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6288         * common/selftest.c: Update.
6289         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6290         a std::string.
6291         (exception_try_scope_entry, exception_try_scope_exit): Don't
6292         declare.
6293         (struct exception_try_scope): Remove.
6294         (TRY): Don't use exception_try_scope.
6295         (struct gdb_exception): Add constructor, operator=.
6296         <what>: New method.
6297         (struct gdb_exception_RETURN_MASK_ALL)
6298         (struct gdb_exception_RETURN_MASK_ERROR)
6299         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6300         (struct gdb_quit_bad_alloc): Update.
6301         * common/common-exceptions.c (exception_none): Change
6302         initializer.
6303         (struct catcher) <state, exception>: Initialize inline.
6304         <prev>: Remove member.
6305         (current_catcher): Remove.
6306         (catchers): New global.
6307         (exceptions_state_mc_init): Simplify.
6308         (catcher_pop): Remove.
6309         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6310         (try_scope_depth, exception_try_scope_entry)
6311         (exception_try_scope_exit): Remove.
6312         (throw_exception_sjlj): Update.
6313         (exception_messages, exception_messages_size): Remove.
6314         (throw_it): Simplify.
6315         (gdb_exception_sliced_copy): Remove.
6316         (throw_exception_cxx): Update.
6317         * cli/cli-script.c (script_from_file): Update.
6318         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6319         Update.
6320         * ada-valprint.c (ada_val_print): Update.
6321         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6322         (create_excep_cond_exprs): Update.
6323
6324 2019-04-08  Tom Tromey  <tom@tromey.com>
6325
6326         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6327         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6328         (TRY, CATCH, END_CATCH): Remove some definitions.
6329         * common/common-exceptions.c: Don't use GDB_XCPT.
6330         (catcher_list_size): Remove.
6331         (throw_exception, throw_it): Simplify.
6332
6333 2019-04-05  Tom Tromey  <tom@tromey.com>
6334
6335         Revert the header-sorting patch.
6336         * ft32-tdep.c: Revert.
6337         * frv-tdep.c: Revert.
6338         * frv-linux-tdep.c: Revert.
6339         * frame.c: Revert.
6340         * frame-unwind.c: Revert.
6341         * frame-base.c: Revert.
6342         * fork-child.c: Revert.
6343         * findvar.c: Revert.
6344         * findcmd.c: Revert.
6345         * filesystem.c: Revert.
6346         * filename-seen-cache.h: Revert.
6347         * filename-seen-cache.c: Revert.
6348         * fbsd-tdep.c: Revert.
6349         * fbsd-nat.h: Revert.
6350         * fbsd-nat.c: Revert.
6351         * f-valprint.c: Revert.
6352         * f-typeprint.c: Revert.
6353         * f-lang.c: Revert.
6354         * extension.h: Revert.
6355         * extension.c: Revert.
6356         * extension-priv.h: Revert.
6357         * expprint.c: Revert.
6358         * exec.h: Revert.
6359         * exec.c: Revert.
6360         * exceptions.c: Revert.
6361         * event-top.c: Revert.
6362         * event-loop.c: Revert.
6363         * eval.c: Revert.
6364         * elfread.c: Revert.
6365         * dwarf2read.h: Revert.
6366         * dwarf2read.c: Revert.
6367         * dwarf2loc.c: Revert.
6368         * dwarf2expr.h: Revert.
6369         * dwarf2expr.c: Revert.
6370         * dwarf2-frame.c: Revert.
6371         * dwarf2-frame-tailcall.c: Revert.
6372         * dwarf-index-write.h: Revert.
6373         * dwarf-index-write.c: Revert.
6374         * dwarf-index-common.c: Revert.
6375         * dwarf-index-cache.h: Revert.
6376         * dwarf-index-cache.c: Revert.
6377         * dummy-frame.c: Revert.
6378         * dtrace-probe.c: Revert.
6379         * disasm.h: Revert.
6380         * disasm.c: Revert.
6381         * disasm-selftests.c: Revert.
6382         * dictionary.c: Revert.
6383         * dicos-tdep.c: Revert.
6384         * demangle.c: Revert.
6385         * dcache.h: Revert.
6386         * dcache.c: Revert.
6387         * darwin-nat.h: Revert.
6388         * darwin-nat.c: Revert.
6389         * darwin-nat-info.c: Revert.
6390         * d-valprint.c: Revert.
6391         * d-namespace.c: Revert.
6392         * d-lang.c: Revert.
6393         * ctf.c: Revert.
6394         * csky-tdep.c: Revert.
6395         * csky-linux-tdep.c: Revert.
6396         * cris-tdep.c: Revert.
6397         * cris-linux-tdep.c: Revert.
6398         * cp-valprint.c: Revert.
6399         * cp-support.c: Revert.
6400         * cp-namespace.c: Revert.
6401         * cp-abi.c: Revert.
6402         * corelow.c: Revert.
6403         * corefile.c: Revert.
6404         * continuations.c: Revert.
6405         * completer.h: Revert.
6406         * completer.c: Revert.
6407         * complaints.c: Revert.
6408         * coffread.c: Revert.
6409         * coff-pe-read.c: Revert.
6410         * cli-out.h: Revert.
6411         * cli-out.c: Revert.
6412         * charset.c: Revert.
6413         * c-varobj.c: Revert.
6414         * c-valprint.c: Revert.
6415         * c-typeprint.c: Revert.
6416         * c-lang.c: Revert.
6417         * buildsym.c: Revert.
6418         * buildsym-legacy.c: Revert.
6419         * build-id.h: Revert.
6420         * build-id.c: Revert.
6421         * btrace.c: Revert.
6422         * bsd-uthread.c: Revert.
6423         * breakpoint.h: Revert.
6424         * breakpoint.c: Revert.
6425         * break-catch-throw.c: Revert.
6426         * break-catch-syscall.c: Revert.
6427         * break-catch-sig.c: Revert.
6428         * blockframe.c: Revert.
6429         * block.c: Revert.
6430         * bfin-tdep.c: Revert.
6431         * bfin-linux-tdep.c: Revert.
6432         * bfd-target.c: Revert.
6433         * bcache.c: Revert.
6434         * ax-general.c: Revert.
6435         * ax-gdb.h: Revert.
6436         * ax-gdb.c: Revert.
6437         * avr-tdep.c: Revert.
6438         * auxv.c: Revert.
6439         * auto-load.c: Revert.
6440         * arm-wince-tdep.c: Revert.
6441         * arm-tdep.c: Revert.
6442         * arm-symbian-tdep.c: Revert.
6443         * arm-pikeos-tdep.c: Revert.
6444         * arm-obsd-tdep.c: Revert.
6445         * arm-nbsd-tdep.c: Revert.
6446         * arm-nbsd-nat.c: Revert.
6447         * arm-linux-tdep.c: Revert.
6448         * arm-linux-nat.c: Revert.
6449         * arm-fbsd-tdep.c: Revert.
6450         * arm-fbsd-nat.c: Revert.
6451         * arm-bsd-tdep.c: Revert.
6452         * arch-utils.c: Revert.
6453         * arc-tdep.c: Revert.
6454         * arc-newlib-tdep.c: Revert.
6455         * annotate.h: Revert.
6456         * annotate.c: Revert.
6457         * amd64-windows-tdep.c: Revert.
6458         * amd64-windows-nat.c: Revert.
6459         * amd64-tdep.c: Revert.
6460         * amd64-sol2-tdep.c: Revert.
6461         * amd64-obsd-tdep.c: Revert.
6462         * amd64-obsd-nat.c: Revert.
6463         * amd64-nbsd-tdep.c: Revert.
6464         * amd64-nbsd-nat.c: Revert.
6465         * amd64-nat.c: Revert.
6466         * amd64-linux-tdep.c: Revert.
6467         * amd64-linux-nat.c: Revert.
6468         * amd64-fbsd-tdep.c: Revert.
6469         * amd64-fbsd-nat.c: Revert.
6470         * amd64-dicos-tdep.c: Revert.
6471         * amd64-darwin-tdep.c: Revert.
6472         * amd64-bsd-nat.c: Revert.
6473         * alpha-tdep.c: Revert.
6474         * alpha-obsd-tdep.c: Revert.
6475         * alpha-nbsd-tdep.c: Revert.
6476         * alpha-mdebug-tdep.c: Revert.
6477         * alpha-linux-tdep.c: Revert.
6478         * alpha-linux-nat.c: Revert.
6479         * alpha-bsd-tdep.c: Revert.
6480         * alpha-bsd-nat.c: Revert.
6481         * aix-thread.c: Revert.
6482         * agent.c: Revert.
6483         * addrmap.c: Revert.
6484         * ada-varobj.c: Revert.
6485         * ada-valprint.c: Revert.
6486         * ada-typeprint.c: Revert.
6487         * ada-tasks.c: Revert.
6488         * ada-lang.c: Revert.
6489         * aarch64-tdep.c: Revert.
6490         * aarch64-ravenscar-thread.c: Revert.
6491         * aarch64-newlib-tdep.c: Revert.
6492         * aarch64-linux-tdep.c: Revert.
6493         * aarch64-linux-nat.c: Revert.
6494         * aarch64-fbsd-tdep.c: Revert.
6495         * aarch64-fbsd-nat.c: Revert.
6496         * aarch32-linux-nat.c: Revert.
6497
6498 2019-04-05  Tom Tromey  <tom@tromey.com>
6499
6500         * ft32-tdep.c: Sort headers.
6501         * frv-tdep.c: Sort headers.
6502         * frv-linux-tdep.c: Sort headers.
6503         * frame.c: Sort headers.
6504         * frame-unwind.c: Sort headers.
6505         * frame-base.c: Sort headers.
6506         * fork-child.c: Sort headers.
6507         * findvar.c: Sort headers.
6508         * findcmd.c: Sort headers.
6509         * filesystem.c: Sort headers.
6510         * filename-seen-cache.h: Sort headers.
6511         * filename-seen-cache.c: Sort headers.
6512         * fbsd-tdep.c: Sort headers.
6513         * fbsd-nat.h: Sort headers.
6514         * fbsd-nat.c: Sort headers.
6515         * f-valprint.c: Sort headers.
6516         * f-typeprint.c: Sort headers.
6517         * f-lang.c: Sort headers.
6518         * extension.h: Sort headers.
6519         * extension.c: Sort headers.
6520         * extension-priv.h: Sort headers.
6521         * expprint.c: Sort headers.
6522         * exec.h: Sort headers.
6523         * exec.c: Sort headers.
6524         * exceptions.c: Sort headers.
6525         * event-top.c: Sort headers.
6526         * event-loop.c: Sort headers.
6527         * eval.c: Sort headers.
6528         * elfread.c: Sort headers.
6529         * dwarf2read.h: Sort headers.
6530         * dwarf2read.c: Sort headers.
6531         * dwarf2loc.c: Sort headers.
6532         * dwarf2expr.h: Sort headers.
6533         * dwarf2expr.c: Sort headers.
6534         * dwarf2-frame.c: Sort headers.
6535         * dwarf2-frame-tailcall.c: Sort headers.
6536         * dwarf-index-write.h: Sort headers.
6537         * dwarf-index-write.c: Sort headers.
6538         * dwarf-index-common.c: Sort headers.
6539         * dwarf-index-cache.h: Sort headers.
6540         * dwarf-index-cache.c: Sort headers.
6541         * dummy-frame.c: Sort headers.
6542         * dtrace-probe.c: Sort headers.
6543         * disasm.h: Sort headers.
6544         * disasm.c: Sort headers.
6545         * disasm-selftests.c: Sort headers.
6546         * dictionary.c: Sort headers.
6547         * dicos-tdep.c: Sort headers.
6548         * demangle.c: Sort headers.
6549         * dcache.h: Sort headers.
6550         * dcache.c: Sort headers.
6551         * darwin-nat.h: Sort headers.
6552         * darwin-nat.c: Sort headers.
6553         * darwin-nat-info.c: Sort headers.
6554         * d-valprint.c: Sort headers.
6555         * d-namespace.c: Sort headers.
6556         * d-lang.c: Sort headers.
6557         * ctf.c: Sort headers.
6558         * csky-tdep.c: Sort headers.
6559         * csky-linux-tdep.c: Sort headers.
6560         * cris-tdep.c: Sort headers.
6561         * cris-linux-tdep.c: Sort headers.
6562         * cp-valprint.c: Sort headers.
6563         * cp-support.c: Sort headers.
6564         * cp-namespace.c: Sort headers.
6565         * cp-abi.c: Sort headers.
6566         * corelow.c: Sort headers.
6567         * corefile.c: Sort headers.
6568         * continuations.c: Sort headers.
6569         * completer.h: Sort headers.
6570         * completer.c: Sort headers.
6571         * complaints.c: Sort headers.
6572         * coffread.c: Sort headers.
6573         * coff-pe-read.c: Sort headers.
6574         * cli-out.h: Sort headers.
6575         * cli-out.c: Sort headers.
6576         * charset.c: Sort headers.
6577         * c-varobj.c: Sort headers.
6578         * c-valprint.c: Sort headers.
6579         * c-typeprint.c: Sort headers.
6580         * c-lang.c: Sort headers.
6581         * buildsym.c: Sort headers.
6582         * buildsym-legacy.c: Sort headers.
6583         * build-id.h: Sort headers.
6584         * build-id.c: Sort headers.
6585         * btrace.c: Sort headers.
6586         * bsd-uthread.c: Sort headers.
6587         * breakpoint.h: Sort headers.
6588         * breakpoint.c: Sort headers.
6589         * break-catch-throw.c: Sort headers.
6590         * break-catch-syscall.c: Sort headers.
6591         * break-catch-sig.c: Sort headers.
6592         * blockframe.c: Sort headers.
6593         * block.c: Sort headers.
6594         * bfin-tdep.c: Sort headers.
6595         * bfin-linux-tdep.c: Sort headers.
6596         * bfd-target.c: Sort headers.
6597         * bcache.c: Sort headers.
6598         * ax-general.c: Sort headers.
6599         * ax-gdb.h: Sort headers.
6600         * ax-gdb.c: Sort headers.
6601         * avr-tdep.c: Sort headers.
6602         * auxv.c: Sort headers.
6603         * auto-load.c: Sort headers.
6604         * arm-wince-tdep.c: Sort headers.
6605         * arm-tdep.c: Sort headers.
6606         * arm-symbian-tdep.c: Sort headers.
6607         * arm-pikeos-tdep.c: Sort headers.
6608         * arm-obsd-tdep.c: Sort headers.
6609         * arm-nbsd-tdep.c: Sort headers.
6610         * arm-nbsd-nat.c: Sort headers.
6611         * arm-linux-tdep.c: Sort headers.
6612         * arm-linux-nat.c: Sort headers.
6613         * arm-fbsd-tdep.c: Sort headers.
6614         * arm-fbsd-nat.c: Sort headers.
6615         * arm-bsd-tdep.c: Sort headers.
6616         * arch-utils.c: Sort headers.
6617         * arc-tdep.c: Sort headers.
6618         * arc-newlib-tdep.c: Sort headers.
6619         * annotate.h: Sort headers.
6620         * annotate.c: Sort headers.
6621         * amd64-windows-tdep.c: Sort headers.
6622         * amd64-windows-nat.c: Sort headers.
6623         * amd64-tdep.c: Sort headers.
6624         * amd64-sol2-tdep.c: Sort headers.
6625         * amd64-obsd-tdep.c: Sort headers.
6626         * amd64-obsd-nat.c: Sort headers.
6627         * amd64-nbsd-tdep.c: Sort headers.
6628         * amd64-nbsd-nat.c: Sort headers.
6629         * amd64-nat.c: Sort headers.
6630         * amd64-linux-tdep.c: Sort headers.
6631         * amd64-linux-nat.c: Sort headers.
6632         * amd64-fbsd-tdep.c: Sort headers.
6633         * amd64-fbsd-nat.c: Sort headers.
6634         * amd64-dicos-tdep.c: Sort headers.
6635         * amd64-darwin-tdep.c: Sort headers.
6636         * amd64-bsd-nat.c: Sort headers.
6637         * alpha-tdep.c: Sort headers.
6638         * alpha-obsd-tdep.c: Sort headers.
6639         * alpha-nbsd-tdep.c: Sort headers.
6640         * alpha-mdebug-tdep.c: Sort headers.
6641         * alpha-linux-tdep.c: Sort headers.
6642         * alpha-linux-nat.c: Sort headers.
6643         * alpha-bsd-tdep.c: Sort headers.
6644         * alpha-bsd-nat.c: Sort headers.
6645         * aix-thread.c: Sort headers.
6646         * agent.c: Sort headers.
6647         * addrmap.c: Sort headers.
6648         * ada-varobj.c: Sort headers.
6649         * ada-valprint.c: Sort headers.
6650         * ada-typeprint.c: Sort headers.
6651         * ada-tasks.c: Sort headers.
6652         * ada-lang.c: Sort headers.
6653         * aarch64-tdep.c: Sort headers.
6654         * aarch64-ravenscar-thread.c: Sort headers.
6655         * aarch64-newlib-tdep.c: Sort headers.
6656         * aarch64-linux-tdep.c: Sort headers.
6657         * aarch64-linux-nat.c: Sort headers.
6658         * aarch64-fbsd-tdep.c: Sort headers.
6659         * aarch64-fbsd-nat.c: Sort headers.
6660         * aarch32-linux-nat.c: Sort headers.
6661
6662 2019-04-04  Tom Tromey  <tom@tromey.com>
6663
6664         * varobj.c (varobj_create): Update.
6665         * rust-exp.y (struct rust_parser) <update_innermost_block,
6666         lookup_symbol>: New methods.
6667         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6668         Rename.
6669         (rust_parser::rust_lookup_type)
6670         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6671         * printcmd.c (display_command, do_one_display): Update.
6672         * parser-defs.h (struct parser_state) <parser_state>: Add
6673         "tracker" parameter.
6674         (block_tracker): New member.
6675         (class innermost_block_tracker) <innermost_block_tracker>: Add
6676         "types" parameter.
6677         <reset>: Remove method.
6678         (innermost_block): Don't declare.
6679         (null_post_parser): Update.
6680         * parse.c (innermost_block): Remove global.
6681         (write_dollar_variable): Update.
6682         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6683         Remove "tracker_types" parameter.
6684         (parse_expression): Add "tracker" parameter.
6685         (parse_expression_for_completion): Update.
6686         (null_post_parser): Add "tracker" parameter.
6687         * p-exp.y: Update rules.
6688         * m2-exp.y: Update rules.
6689         * language.h (struct language_defn) <la_post_parser>: Add
6690         "tracker" parameter.
6691         * go-exp.y: Update rules.
6692         * f-exp.y: Update rules.
6693         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6694         parameter.
6695         * d-exp.y: Update rules.
6696         * c-exp.y: Update rules.
6697         * breakpoint.c (set_breakpoint_condition): Create an
6698         innermost_block_tracker.
6699         (watch_command_1): Likewise.
6700         * ada-lang.c (resolve): Add "tracker" parameter.
6701         (resolve_subexp): Likewise.
6702         * ada-exp.y (write_var_from_sym): Update.
6703
6704 2019-04-04  Tom Tromey  <tom@tromey.com>
6705
6706         * type-stack.h: New file.
6707         * type-stack.c: New file.
6708         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6709         type-stack.h.
6710         (insert_into_type_stack, insert_type, push_type, push_type_int)
6711         (insert_type_address_space, pop_type, pop_type_int)
6712         (pop_typelist, pop_type_stack, append_type_stack)
6713         (push_type_stack, get_type_stack, push_typelist)
6714         (follow_type_instance_flags, follow_types): Don't declare.
6715         * parse.c (type_stack): Remove global.
6716         (parse_exp_in_context): Update.
6717         (insert_into_type_stack, insert_type, push_type, push_type_int)
6718         (insert_type_address_space, pop_type, pop_type_int)
6719         (pop_typelist, pop_type_stack, append_type_stack)
6720         (push_type_stack, get_type_stack, push_typelist)
6721         (follow_type_instance_flags, follow_types): Remove (moved to
6722         type-stack.c).
6723         * f-exp.y (type_stack): New global.
6724         Update rules.
6725         (push_kind_type, f_parse): Update.
6726         * d-exp.y (type_stack): New global.
6727         Update rules.
6728         (d_parse): Update.
6729         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6730         Update rules.
6731         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6732         (HFILES_NO_SRCDIR): Add type-stack.h.
6733
6734 2019-04-04  Tom Tromey  <tom@tromey.com>
6735
6736         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6737         (rust_parser::convert_ast_to_expression, rust_parse)
6738         (rust_lex_test_completion, rust_lex_tests): Update.
6739         * parser-defs.h (struct expr_completion_state): New.
6740         (struct parser_state) <parser_state>: Add completion parameter.
6741         <mark_struct_expression, mark_completion_tag>: New methods.
6742         <parse_completion, m_completion_state>: New members.
6743         (prefixify_expression, null_post_parser): Update.
6744         (mark_struct_expression, mark_completion_tag): Don't declare.
6745         * parse.c (parse_completion, expout_last_struct)
6746         (expout_tag_completion_type, expout_completion_name): Remove
6747         globals.
6748         (parser_state::mark_struct_expression)
6749         (parser_state::mark_completion_tag): Now methods.
6750         (prefixify_expression): Add last_struct parameter.
6751         (prefixify_subexp): Likewise.
6752         (parse_exp_1): Update.
6753         (parse_exp_in_context): Add cstate parameter.  Update.
6754         (parse_expression_for_completion): Create an
6755         expr_completion_state.
6756         (null_post_parser): Add "completion" parameter.
6757         * p-exp.y: Update rules.
6758         (yylex): Update.
6759         * language.h (struct language_defn) <la_post_parser>: Add
6760         "completing" parameter.
6761         * go-exp.y: Update rules.
6762         (lex_one_token): Update.
6763         * expression.h (parse_completion): Don't declare.
6764         * d-exp.y: Update rules.
6765         (lex_one_token): Update rules.
6766         * c-exp.y: Update rules.
6767         (lex_one_token): Update.
6768         * ada-lang.c (resolve): Add "parse_completion" parameter.
6769         (resolve_subexp): Likewise.
6770         (ada_resolve_function): Likewise.
6771
6772 2019-04-04  Tom Tromey  <tom@tromey.com>
6773
6774         * parser-defs.h (struct parser_state) <start_arglist,
6775         end_arglist>: New methods.
6776         <arglist_len, m_funcall_chain>: New members.
6777         (arglist_len, start_arglist, end_arglist): Don't declare.
6778         * parse.c (arglist_len, funcall_chain): Remove global.
6779         (start_arglist, end_arglist): Remove functions.
6780         (parse_exp_in_context): Update.
6781         * p-exp.y: Update rules.
6782         * m2-exp.y: Update rules.
6783         * go-exp.y: Update rules.
6784         * f-exp.y: Update rules.
6785         * d-exp.y: Update rules.
6786         * c-exp.y: Update rules.
6787
6788 2019-04-04  Tom Tromey  <tom@tromey.com>
6789
6790         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6791         lex_operator, push_back>: New methods.
6792         Update all rules.
6793         (rust_parser::lex_hex, lex_escape): Rename and update.
6794         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6795         (rust_parser::lex_operator): Rename and update.
6796         (rust_parser::lex_number, rustyylex, rustyyerror)
6797         (rust_lex_test_init, rust_lex_test_sequence)
6798         (rust_lex_test_push_back, rust_lex_tests): Update.
6799         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6800         parameter.
6801         <lexptr, prev_lexptr>: New members.
6802         (lexptr, prev_lexptr): Don't declare.
6803         * parse.c (lexptr, prev_lexptr): Remove globals.
6804         (parse_exp_in_context): Update.
6805         * p-exp.y (yylex, yyerror): Update.
6806         * m2-exp.y (parse_number, yylex, yyerror): Update.
6807         * go-exp.y (lex_one_token, yyerror): Update.
6808         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6809         * d-exp.y (lex_one_token, yyerror): Update.
6810         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6811         (lex_one_token, yyerror): Update.
6812         * ada-lex.l (YY_INPUT): Update.
6813         (rewind_to_char): Update.
6814         * ada-exp.y (yyerror): Update.
6815
6816 2019-04-04  Tom Tromey  <tom@tromey.com>
6817
6818         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6819         * parser-defs.h (struct parser_state) <parser_state>: Add new
6820         parameter.
6821         <comma_terminates>: New member.
6822         (comma_terminates): Don't declare global.
6823         * parse.c (comma_terminates): Remove global.
6824         (parse_exp_in_context): Update.
6825         * p-exp.y (yylex): Update.
6826         * m2-exp.y (yylex): Update.
6827         * go-exp.y (lex_one_token): Update.
6828         * f-exp.y (yylex): Update.
6829         * d-exp.y (lex_one_token): Update.
6830         * c-exp.y (lex_one_token): Update.
6831         * ada-lex.l: Update.
6832
6833 2019-04-04  Tom Tromey  <tom@tromey.com>
6834
6835         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6836         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6837         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6838         * parser-defs.h (paren_depth): Don't declare.
6839         * parse.c (paren_depth): Remove global.
6840         (parse_exp_in_context): Update.
6841         * p-exp.y (paren_depth): New global.
6842         (pascal_parse): Initialize it.
6843         * m2-exp.y (paren_depth): New global.
6844         (m2_parse): Initialize it.
6845         * go-exp.y (paren_depth): New global.
6846         (go_parse): Initialize it.
6847         * f-exp.y (paren_depth): New global.
6848         (f_parse): Initialize it.
6849         * d-exp.y (paren_depth): New global.
6850         (d_parse): Initialize it.
6851         * c-exp.y (paren_depth): New global.
6852         (c_parse): Initialize it.
6853         * ada-lex.l (paren_depth): New global.
6854         (lexer_init): Initialize it.
6855
6856 2019-04-04  Tom Tromey  <tom@tromey.com>
6857
6858         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6859         (rust_parser::convert_ast_to_type)
6860         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6861         * parser-defs.h (struct parser_state) <parser_state>: Add
6862         parameters.  Initialize new members.
6863         <expression_context_block, expression_context_pc>: New members.
6864         * parse.c (expression_context_block, expression_context_pc):
6865         Remove globals.
6866         (parse_exp_in_context): Update.
6867         * p-exp.y: Update all rules.
6868         (yylex): Update.
6869         * m2-exp.y: Update all rules.
6870         (yylex): Update.
6871         * go-exp.y (yylex): Update.
6872         * f-exp.y (yylex): Update.
6873         * d-exp.y: Update all rules.
6874         (yylex): Update.
6875         * c-exp.y: Update all rules.
6876         (lex_one_token, classify_name, yylex, c_parse): Update.
6877         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6878
6879 2019-04-04  Tom Tromey  <tom@tromey.com>
6880
6881         * gdbarch.h, gdbarch.c: Rebuild.
6882         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6883         * stap-probe.h:
6884         (struct stap_parse_info): Replace "parser_state" with
6885         "expr_builder".
6886         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6887         (parser_state): New class.
6888         * parse.c (expr_builder): Rename.
6889         (expr_builder::release): Rename.
6890         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6891         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6892         (write_exp_elt_longcst, write_exp_elt_floatcst)
6893         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6894         (write_exp_string_vector, write_exp_bitstring)
6895         (write_exp_msymbol, mark_struct_expression)
6896         (write_dollar_variable)
6897         (insert_type_address_space, increase_expout_size): Replace
6898         "parser_state" with "expr_builder".
6899         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6900         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6901         "parser_state" with "expr_builder".
6902
6903 2019-04-04  Tom Tromey  <tom@tromey.com>
6904
6905         * rust-exp.y: Replace "parse_language" with method call.
6906         * p-exp.y:
6907         (yylex): Replace "parse_language" with method call.
6908         * m2-exp.y:
6909         (yylex): Replace "parse_language" with method call.
6910         * go-exp.y (classify_name): Replace "parse_language" with method
6911         call.
6912         * f-exp.y (yylex): Replace "parse_language" with method call.
6913         * d-exp.y (lex_one_token): Replace "parse_language" with method
6914         call.
6915         * c-exp.y:
6916         (lex_one_token, classify_name, yylex): Replace "parse_language"
6917         with method call.
6918         * ada-exp.y (find_primitive_type, type_char)
6919         (type_system_address): Replace "parse_language" with method call.
6920
6921 2019-04-04  Tom Tromey  <tom@tromey.com>
6922
6923         * rust-exp.y: Replace "parse_gdbarch" with method call.
6924         * parse.c (write_dollar_variable, insert_type_address_space):
6925         Replace "parse_gdbarch" with method call.
6926         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6927         call.
6928         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6929         call.
6930         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6931         "parse_gdbarch" with method call.
6932         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6933         with method call.
6934         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6935         "parse_gdbarch" with method call.
6936         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6937         "parse_gdbarch" with method call.
6938         * c-exp.y (parse_type, parse_number, classify_name): Replace
6939         "parse_gdbarch" with method call.
6940         * ada-lex.l: Replace "parse_gdbarch" with method call.
6941         * ada-exp.y (parse_type, find_primitive_type, type_char)
6942         (type_system_address): Replace "parse_gdbarch" with method call.
6943
6944 2019-04-04  Tom Tromey  <tom@tromey.com>
6945
6946         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6947         * stap-probe.c (stap_parse_argument): Update.
6948         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6949         initial_size parameter.
6950         * rust-exp.y (rust_lex_tests): Update.
6951         * parse.c (parser_state): Update.
6952         (parse_exp_in_context): Update.
6953         * parser-defs.h (struct parser_state) <parser_state>: Remove
6954         "initial_size" parameter.
6955
6956 2019-04-04  Tom Tromey  <tom@tromey.com>
6957
6958         * parser-defs.h (increase_expout_size): Don't declare.
6959         * parse.c (increase_expout_size): Now static.
6960
6961 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6962
6963         * gnu-nat.c (gnu_nat_target::wait): Fix
6964         target_waitstatus_to_string call.
6965
6966 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6967
6968         * eval.c (evaluate_subexp_standard): Handle internal functions
6969         during Fortran function call handling.
6970
6971 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6972
6973         * NEWS: Mention new internal functions.
6974         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6975         (read_base_type): Use dwarf2_init_complex_target_type.
6976         * value.c (creal_internal_fn): New function.
6977         (cimag_internal_fn): New function.
6978         (_initialize_values): Register new internal functions.
6979
6980 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6981
6982         * infrun.c (stop_all_threads): If debug_infrun, always
6983         trace the wait status after wait_one, using
6984         target_waitstatus_to_string and target_pid_to_str.
6985         (handle_inferior_event): Replace various trace of
6986         wait status kind by a single trace.
6987         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6988         wait status kind image by target_waitstatus_to_string.
6989         * target/waitstatus.c (target_waitstatus_to_string): Fix
6990         obsolete comment.
6991
6992 2019-04-01  Tom Tromey  <tromey@adacore.com>
6993
6994         PR symtab/23331:
6995         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6996
6997 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6998             Pedro Alves  <palves@redhat.com>
6999
7000         * top.c (quit_force): Call 'finalize_values'.
7001         * value.c (finalize_values): New function.
7002         * value.h (finalize_values): Declare.
7003
7004 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7005
7006         * NEWS: Announce $_gdb_major and $_gdb_minor.
7007
7008         * top.c (init_gdb_version_vars): New function.
7009         (gdb_init): Call init_gdb_version_vars.
7010
7011 2019-03-29  Tom Tromey  <tromey@adacore.com>
7012
7013         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7014         help text.  Remove dead code.
7015
7016 2019-03-29  Keith Seitz  <keiths@redhat.com>
7017
7018         From Siddhesh Poyarekar:
7019         * f-lang.h (f77_get_upperbound): Return LONGEST.
7020         (f77_get_lowerbound): Likewise.
7021         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7022         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7023         print them.
7024         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7025         plongest to format print it.
7026         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7027         (f77_get_upperbound): Likewise.
7028         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7029         LOWER_BOUND to LONGEST.
7030         (f77_create_arrayprint_offset_tbl): Likewise.
7031
7032 2019-03-29  Keith Seitz  <keiths@redhat.com>
7033
7034         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7035         %s/pulongest for TYPE_LENGTH instead of %d in format
7036         strings.
7037         * ada-typerint.c (ada_print_type): Likewise.
7038         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7039         * compile/compile-c-support.c (generate_register_struct): Likewise.
7040         * gdbtypes.c (recursive_dump_type): Likewise.
7041         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7042         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7043         instead of %d in format strings.
7044         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7045         to std::min to ULONGEST.
7046         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7047         instead of %d in format strings.
7048         * tracepoint.c (info_scope_command): Likewise.
7049         * typeprint.c (print_offset_data::update)
7050         (print_offset_data::finish): Likewise.
7051         * xtensa-tdep.c (xtensa_store_return_value)
7052         (xtensa_push_dummy_call): Likewise.
7053
7054 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7055
7056         * windows-nat.c (display_selector): Fixed format specifications
7057         for 64-bit Cygwin.
7058
7059 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7060
7061         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7062
7063 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7064
7065         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7066         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7067         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7068         (nios2_linux_init_abi): Install it.
7069
7070 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7071
7072         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7073
7074 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7075
7076         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7077
7078 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7079             Tom Tromey  <tromey@adacore.com>
7080
7081         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7082
7083 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7084
7085         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7086         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7087         method to compute the bounds of range types. Also print "[evaluated]"
7088         if the bounds' values come from a dynamic evaluation.
7089
7090 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7091
7092         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7093         whitespace when pretty printing is on.
7094
7095 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7096
7097         * ppc-linux-nat.c: Add include.
7098
7099 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7100
7101         * NEWS: Mention AArch64 Pointer Authentication.
7102
7103 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7104
7105         * arm-linux-nat.c: Add include.
7106
7107 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7108
7109         * source-cache.c (source_cache::get_source_lines): Re-read
7110         fullname after calling open_source_file.
7111
7112 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7113
7114         * NEWS: Mention TLS support for FreeBSD.
7115
7116 2019-03-25  Tom Tromey  <tromey@adacore.com>
7117
7118         * minsyms.c (BUNCH_SIZE): Update comment.
7119         (~minimal_symbol_reader): Remove old comment.
7120         (compact_minimal_symbols): Update comment.
7121         (minimal_symbol_reader::install): Remove old comment.  Update
7122         other comments.
7123
7124 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7125
7126         * s390-linux-nat.c: Add include.
7127
7128 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7129
7130         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7131         Call linux_get_hwcap.
7132         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7133         Likewise.
7134         (aarch64_linux_get_hwcap): Remove function.
7135         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7136         declaration.
7137         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7138         linux_get_hwcap.
7139         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7140         * linux-tdep.c (linux_get_hwcap): Add function.
7141         (linux_get_hwcap2): Likewise.
7142         * linux-tdep.h (linux_get_hwcap): Add declaration.
7143         (linux_get_hwcap2): Likewise.
7144         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7145         (ppc_linux_get_hwcap2): Likewise.
7146         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7147         linux_get_hwcap.
7148         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7149         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7150         (ppc_linux_nat_target::read_description): Likewise.
7151         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7152         * s390-linux-nat.c: Likewise.
7153         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7154
7155 2019-03-24  Tom Tromey  <tom@tromey.com>
7156
7157         * ada-lang.c (standard_lookup): Simplify initialization.
7158         (ada_lookup_symbol_nonlocal): Simplify return.
7159         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7160         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7161         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7162         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7163         initialization.
7164         * solib.c (solib_global_lookup): Simplify.
7165         * symtab.c (null_block_symbol): Remove.
7166         (symbol_cache_lookup): Simplify returns.
7167         (lookup_language_this): Simplify returns.
7168         (lookup_symbol_aux): Simplify return.
7169         (lookup_local_symbol): Simplify returns.
7170         (lookup_global_symbol_from_objfile): Simplify return.
7171         (lookup_symbol_in_objfile_symtabs)
7172         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7173         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7174         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7175         * cp-namespace.c (cp_lookup_bare_symbol)
7176         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7177         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7178         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7179         (cp_lookup_symbol_via_imports): Simplify initialization.
7180         (find_symbol_in_baseclass): Likewise.
7181         * symtab.h (null_block_symbol): Remove.
7182         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7183         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7184         (d_lookup_symbol_module): Likewise.
7185         (find_symbol_in_baseclass): Simplify initialization.
7186
7187 2019-03-24  Tom Tromey  <tom@tromey.com>
7188
7189         * expression.h: Don't include symtab.h.
7190         (struct block): Forward declare.
7191
7192 2019-03-24  Tom Tromey  <tom@tromey.com>
7193
7194         * c-exp.y (typebase): Remove casts.
7195         * gdbtypes.c (lookup_unsigned_typename, )
7196         (lookup_signed_typename): Remove cast.
7197         * eval.c (parse_to_comma_and_eval): Remove cast.
7198         * parse.c (write_dollar_variable): Remove cast.
7199         * block.h (struct block) <superblock>: Now const.
7200         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7201         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7202         (map_block): Make "block" const.
7203         * symfile.h (struct quick_symbol_functions)
7204         <map_matching_symbols>: Constify block argument to "callback".
7205         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7206         const.
7207         (find_pc_sect_compunit_symtab): Make "b" const.
7208         (find_symbol_at_address): Likewise.
7209         (search_symbols): Likewise.
7210         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7211         (dw2_debug_names_lookup_symbol): Likewise.
7212         (dw2_map_matching_symbols): Update.
7213         * p-valprint.c (pascal_val_print): Remove "block".
7214         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7215         (aux_add_nonlocal_symbols): Make "block" const.
7216         (resolve_subexp): Remove cast.
7217         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7218         const.
7219         (iterate_over_file_blocks): Likewise.
7220         * f-exp.y (%union) <bval>: Remove.
7221         * coffread.c (patch_opaque_types): Make "b" const.
7222         * spu-tdep.c (spu_catch_start): Make "block" const.
7223         * c-valprint.c (print_unpacked_pointer): Remove "block".
7224         * symmisc.c (dump_symtab_1): Make "b" const.
7225         (block_depth): Make "block" const.
7226         * d-exp.y (%union) <bval>: Remove.
7227         * cp-support.h (cp_lookup_rtti_type): Update.
7228         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7229         * psymtab.c (psym_lookup_symbol): Make "block" const.
7230         (maintenance_check_psymtabs): Make "b" const.
7231         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7232         (enumerate_locals, enumerate_args): Update.
7233         * python/py-symtab.c (stpy_global_block): Make "block" const.
7234         (stpy_static_block): Likewise.
7235         * inline-frame.c (block_starting_point_at): Make "new_block"
7236         const.
7237         * block.c (find_block_in_blockvector): Make return type const.
7238         (blockvector_for_pc_sect): Make "b" const.
7239         (find_block_in_blockvector): Make "b" const.
7240
7241 2019-03-23  Tom Tromey  <tom@tromey.com>
7242
7243         * varobj.c (varobj_create): Update.
7244         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7245         * printcmd.c (display_command, do_one_display): Don't reset
7246         innermost_block.
7247         * parser-defs.h (enum innermost_block_tracker_type): Move to
7248         expression.h.
7249         (innermost_block): Update comment.
7250         * parse.c (parse_exp_1): Add tracker_types parameter.
7251         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7252         tracker_types parameter.  Reset innermost_block.
7253         (parse_exp_in_context): Remove.
7254         (parse_expression_for_completion): Update.
7255         * objfiles.c (~objfile): Don't reset expression_context_block or
7256         innermost_block.
7257         * expression.h (enum innermost_block_tracker_type): Move from
7258         parser-defs.h.
7259         (parse_exp_1): Add tracker_types parameter.
7260         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7261         reset innermost_block.
7262
7263 2019-03-23  Tom Tromey  <tom@tromey.com>
7264
7265         * objfiles.h: Include bcache.h.
7266
7267 2019-03-23  Tom Tromey  <tom@tromey.com>
7268
7269         * linespec.c (get_current_search_block): Use
7270         scoped_restore_current_language.
7271         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7272
7273 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7274             Jiong Wang  <jiong.wang@arm.com>
7275
7276         * aarch64-linux-tdep.c
7277         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7278         section.
7279         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7280
7281 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7282             Jiong Wang  <jiong.wang@arm.com>
7283
7284         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7285         instructions.
7286         (aarch64_analyze_prologue_test): Add PACIASP test.
7287         (aarch64_prologue_prev_register): Unmask PC value.
7288
7289 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7290             Jiong Wang  <jiong.wang@arm.com>
7291
7292         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7293         (aarch64_dwarf2_prev_register): Unmask PC value.
7294         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7295         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7296         DW_CFA_AARCH64_negate_ra_state.
7297         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7298
7299 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7300             Jiong Wang  <jiong.wang@arm.com>
7301
7302         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7303         registers.
7304         (aarch64_pseudo_register_name): Likewise.
7305         (aarch64_pseudo_register_type): Likewise.
7306         (aarch64_pseudo_register_reggroup_p): Likewise.
7307         (aarch64_gdbarch_init): Add pauth registers.
7308         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7309         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7310         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7311         (struct gdbarch_tdep): Add regnum for ra_state.
7312
7313 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7314             Jiong Wang  <jiong.wang@arm.com>
7315
7316         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7317
7318 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7319             Jiong Wang  <jiong.wang@arm.com>
7320
7321         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7322         function.
7323         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7324         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7325         (aarch64_gdbarch_init): Add puth registers.
7326         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7327         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7328         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7329
7330 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7331             Jiong Wang  <jiong.wang@arm.com>
7332
7333         * aarch64-linux-nat.c
7334         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7335         * aarch64-linux-tdep.c
7336         (aarch64_linux_core_read_description): Likewise.
7337         (aarch64_linux_get_hwcap): New function.
7338         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7339         (aarch64_linux_get_hwcap): New declaration.
7340
7341 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7342             Jiong Wang  <jiong.wang@arm.com>
7343
7344         * aarch64-linux-nat.c
7345         (aarch64_linux_nat_target::read_description): Add pauth param.
7346         * aarch64-linux-tdep.c
7347         (aarch64_linux_core_read_description): Likewise.
7348         * aarch64-tdep.c (struct target_desc): Add in pauth.
7349         (aarch64_read_description): Add pauth param.
7350         (aarch64_gdbarch_init): Likewise.
7351         * aarch64-tdep.h (aarch64_read_description): Likewise.
7352         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7353         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7354         * features/Makefile: Add new files.
7355         * features/aarch64-pauth.c: New file.
7356         * features/aarch64-pauth.xml: New file.
7357
7358 2019-03-20  Tom Tromey  <tromey@adacore.com>
7359
7360         * infrun.c (handle_inferior_event): Rename from
7361         handle_inferior_event_1.  Create a scoped_value_mark.
7362         (handle_inferior_event): Remove.
7363
7364 2019-03-19  Tom Tromey  <tromey@adacore.com>
7365
7366         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7367         * infrun.h (print_stop_event): Add "displays" parameter.
7368         * infrun.c (print_stop_event): Add "displays" parameter.
7369
7370 2019-03-19  Pedro Alves  <palves@redhat.com>
7371
7372         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7373         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7374         to -1.  Fix TABs vs spaces.
7375         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7376         * tui/tui-out.h (tui_ui_out) Add intro comments.
7377         <m_line, m_start_of_line>: In-class initialize, and add describing
7378         comment.
7379
7380 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7381
7382         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7383         variable names.
7384         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7385
7386 2019-03-18  Pedro Alves  <palves@redhat.com>
7387             Eli Zaretskii <eliz@gnu.org>
7388
7389         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7390         m_line and m_start_of_line.
7391
7392 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7393
7394         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7395         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7396         it returns a newline.  This fixes a regression in TU mode, whereby
7397         the next line is output on the same screen line as the user input.
7398
7399 2019-03-18  Tom Tromey  <tromey@adacore.com>
7400
7401         * minsyms.c (minimal_symbol_reader::install): Remove call to
7402         obstack_blank.
7403
7404 2019-03-18  Pedro Alves  <palves@redhat.com>
7405
7406         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7407         New globals.
7408         (apply_style): New, factored out from ...
7409         (apply_ansi_escape): ... this.  Handle reverse video mode.
7410         (tui_set_reverse_mode): New function.
7411         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7412         * tui/tui-winsource.c (tui_show_source_line): Use
7413         tui_set_reverse_mode instead of setting A_STANDOUT.
7414         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7415         New setter methods.
7416
7417 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7418
7419         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7420         Handle tabs.
7421
7422 2019-03-18  Tom Tromey  <tromey@adacore.com>
7423
7424         * ada-lang.c (empty_array): Add "high" parameter.
7425         (ada_evaluate_subexp): Update.
7426
7427 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7428
7429         * unittests/string_view-selftests.c: Define
7430         _initialize_string_view_selftests unconditionally.
7431
7432 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7433
7434         PR gdb/24350
7435         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7436
7437 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7438
7439         PR gdb/24351
7440         * windows-nat.c (display_selector): Fix format specifiers.
7441
7442 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7443
7444         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7445         tui_refill_source_window instead of tui_refresh_win, to update the
7446         current execution line.  This fixes redisplay of the current line
7447         when stepping through the code with "next" or "step".
7448
7449 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7450
7451         * source-cache.c (source_cache::get_source_lines): Call
7452         find_source_lines to initialize s->nlines.  This fixes vertical
7453         scrolling of TUI source window when the DOWN arrow is pressed.
7454
7455 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7456
7457         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7458         linux-thread-db.c (_initialize_thread_db): Likewise.
7459
7460 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7461
7462         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7463         wclrtoeol in tui_show_source_line".  This reverts changes made in
7464         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7465
7466 2019-03-15  Tom Tromey  <tom@tromey.com>
7467
7468         * symtab.h (struct minimal_symbol): Derive from
7469         general_symbol_info.
7470         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7471         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7472         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7473         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7474         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7475         (MSYMBOL_SEARCH_NAME): Update.
7476         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7477         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7478         * minsyms.c (minimal_symbol_reader::record_full): Update.
7479
7480 2019-03-15  Tom Tromey  <tom@tromey.com>
7481
7482         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7483
7484 2019-03-15  Tom Tromey  <tom@tromey.com>
7485
7486         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7487         unique_xmalloc_ptr.
7488         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7489         Update.
7490         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7491         (build_minimal_symbol_hash_tables)
7492         (minimal_symbol_reader::install): Update.
7493
7494 2019-03-15  Tom Tromey  <tom@tromey.com>
7495
7496         * symtab.c (create_demangled_names_hash): Update.
7497         (symbol_set_names): Update.
7498         * objfiles.h (struct objfile_per_bfd_storage)
7499         <demangled_names_hash>: Now an htab_up.
7500         * objfiles.c (objfile_per_bfd_storage): Simplify.
7501
7502 2019-03-15  Tom Tromey  <tom@tromey.com>
7503
7504         * objfiles.h (struct objfile_per_bfd_storage): Declare
7505         destructor.
7506         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7507         New.
7508         (get_objfile_bfd_data): Use new.  Don't initialize
7509         language_of_main.
7510         (free_objfile_per_bfd_storage): Remove.
7511         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7512
7513 2019-03-15  Tom Tromey  <tom@tromey.com>
7514
7515         * symfile.c (reread_symbols): Update.
7516         * objfiles.c (objfile::objfile): Update.
7517         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7518         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7519         comment.
7520         (minimal_symbol_reader::install): Update.
7521         (terminate_minimal_symbol_table): Remove.
7522         * jit.c (jit_object_close_impl): Update.
7523
7524 2019-03-15  Tom Tromey  <tom@tromey.com>
7525
7526         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7527         initializations.
7528
7529 2019-03-15  Tom Tromey  <tom@tromey.com>
7530
7531         * objfiles.h (struct objfile_per_bfd_storage)
7532         <demangled_hash_languages>: Now a bitset.
7533         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7534         (lookup_minimal_symbol): Update.
7535
7536 2019-03-15  Tom Tromey  <tom@tromey.com>
7537
7538         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7539         Don't return the symbol.
7540         * coffread.c (record_minimal_symbol): Use record_full.
7541
7542 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7543
7544         The MS-Windows port of ncurses fails to switch to a color pair if
7545         one or both of the colors are the implicit default colors.  This
7546         change records the default colors when TUI is initialized, and
7547         then specifies them explicitly when a color pair uses the default
7548         colors.  This allows color styling in TUI mode on MS-Windows.
7549
7550         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7551         ncurses_norm_attr.
7552         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7553         colors in ncurses_norm_attr.
7554         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7555         "none", replace it with the default color recorded in
7556         ncurses_norm_attr.
7557
7558 2019-03-14  Tom Tromey  <tromey@adacore.com>
7559
7560         * source-cache.h (class source_cache) <get_source_lines>: Return
7561         std::string.
7562         * source-cache.c (source_cache::extract_lines): Handle case where
7563         first_pos==npos.  Return std::string.
7564         (source_cache::get_source_lines): Update.
7565
7566 2019-03-14  Tom Tromey  <tromey@adacore.com>
7567
7568         * NEWS: Add item for "style sources" commands.
7569         * source-cache.c (source_cache::get_source_lines): Check
7570         source_styling.
7571         * cli/cli-style.c (source_styling): New global.
7572         (_initialize_cli_style): Add "style sources" commands.
7573         (show_style_sources): New function.
7574         * cli/cli-style.h (source_styling): Declare.
7575
7576 2019-03-14  Pedro Alves  <palves@redhat.com>
7577             Tom Tromey  <tromey@adacore.com>
7578
7579         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7580         * tui/tui-winsource.c (tui_refill_source_window): New function,
7581         from...
7582         (tui_horizontal_source_scroll): ... here.  Move some logic.
7583         * cli/cli-style.c (set_style_enabled): Notify new observable.
7584         * tui/tui-hooks.c (tui_redisplay_source): New function.
7585         (tui_attach_detach_observers): Attach or detach
7586         tui_redisplay_source.
7587         * observable.h (source_styling_changed): New observable.
7588         * observable.c: Define source_styling_changed observable.
7589
7590 2019-03-13  Tom Tromey  <tromey@adacore.com>
7591
7592         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7593         (i386_gnu_nat_target::store_registers): Update.
7594         * target-debug.h (target_debug_print_std_string): New macro.
7595         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7596         * windows-tdep.c (display_one_tib): Update.
7597         * tui/tui-stack.c (tui_make_status_line): Update.
7598         * top.c (print_inferior_quit_action): Update.
7599         * thread.c (thr_try_catch_cmd): Update.
7600         (add_thread_with_info): Update.
7601         (thread_target_id_str): Update.
7602         (thr_try_catch_cmd): Update.
7603         (thread_command): Update.
7604         (thread_find_command): Update.
7605         * record-btrace.c (record_btrace_target::info_record)
7606         (record_btrace_resume_thread, record_btrace_target::resume)
7607         (record_btrace_cancel_resume, record_btrace_step_thread)
7608         (record_btrace_target::wait, record_btrace_target::wait)
7609         (record_btrace_target::wait, record_btrace_target::stop): Update.
7610         * progspace.c (print_program_space): Update.
7611         * process-stratum-target.c
7612         (process_stratum_target::thread_address_space): Update.
7613         * linux-fork.c (linux_fork_mourn_inferior)
7614         (detach_checkpoint_command, info_checkpoints_command)
7615         (linux_fork_context): Update.
7616         (linux_fork_detach): Update.
7617         (class scoped_switch_fork_info): Update.
7618         (delete_checkpoint_command): Update.
7619         * infrun.c (follow_fork_inferior): Update.
7620         (follow_fork_inferior): Update.
7621         (proceed_after_vfork_done): Update.
7622         (handle_vfork_child_exec_or_exit): Update.
7623         (follow_exec): Update.
7624         (displaced_step_prepare_throw): Update.
7625         (displaced_step_restore): Update.
7626         (start_step_over): Update.
7627         (resume_1): Update.
7628         (clear_proceed_status_thread): Update.
7629         (proceed): Update.
7630         (print_target_wait_results): Update.
7631         (do_target_wait): Update.
7632         (context_switch): Update.
7633         (stop_all_threads): Update.
7634         (restart_threads): Update.
7635         (finish_step_over): Update.
7636         (handle_signal_stop): Update.
7637         (switch_back_to_stepped_thread): Update.
7638         (keep_going_pass_signal): Update.
7639         (print_exited_reason): Update.
7640         (normal_stop): Update.
7641         * inferior.c (inferior_pid_to_str): Change return type.
7642         (print_selected_inferior): Update.
7643         (add_inferior): Update.
7644         (detach_inferior): Update.
7645         * dummy-frame.c (fprint_dummy_frames): Update.
7646         * dcache.c (dcache_info_1): Update.
7647         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7648         (btrace_fetch, btrace_clear): Update.
7649         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7650         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7651         type.
7652         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7653         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7654         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7655         * gdbarch.c, gdbarch.h: Rebuild.
7656         * gdbarch.sh (core_pid_to_str): Change return type.
7657         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7658         return type.
7659         (windows_nat_target::pid_to_str): Change return type.
7660         (windows_delete_thread): Update.
7661         (windows_nat_target::attach): Update.
7662         (windows_nat_target::files_info): Update.
7663         * target-delegates.c: Rebuild.
7664         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7665         return type.
7666         (sol_thread_target::pid_to_str): Change return type.
7667         * remote.c (class remote_target) <pid_to_str>: Change return
7668         type.
7669         (remote_target::pid_to_str): Change return type.
7670         (extended_remote_target::attach, remote_target::remote_stop_ns)
7671         (remote_target::remote_notif_remove_queued_reply)
7672         (remote_target::push_stop_reply, remote_target::disable_btrace):
7673         Update.
7674         (extended_remote_target::attach): Update.
7675         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7676         type.
7677         (gdbsim_target::pid_to_str): Change return type.
7678         * ravenscar-thread.c (struct ravenscar_thread_target)
7679         <pid_to_str>: Change return type.
7680         (ravenscar_thread_target::pid_to_str): Change return type.
7681         * procfs.c (class procfs_target) <pid_to_str>: Change return
7682         type.
7683         (procfs_target::pid_to_str): Change return type.
7684         (procfs_target::attach): Update.
7685         (procfs_target::detach): Update.
7686         (procfs_target::fetch_registers): Update.
7687         (procfs_target::store_registers): Update.
7688         (procfs_target::wait): Update.
7689         (procfs_target::files_info): Update.
7690         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7691         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7692         return type.
7693         (nto_procfs_target::pid_to_str): Change return type.
7694         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7695         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7696         return type.
7697         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7698         (exit_lwp): Update.
7699         (attach_proc_task_lwp_callback, get_detach_signal)
7700         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7701         (linux_nat_target::resume, wait_lwp, stop_callback)
7702         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7703         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7704         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7705         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7706         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7707         type.
7708         (inf_ptrace_target::attach): Update.
7709         (inf_ptrace_target::files_info): Update.
7710         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7711         type.
7712         (go32_nat_target::pid_to_str): Change return type.
7713         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7714         (gnu_nat_target::wait): Update.
7715         (gnu_nat_target::wait): Update.
7716         (gnu_nat_target::resume): Update.
7717         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7718         (fbsd_nat_target::wait): Update.
7719         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7720         type.
7721         (darwin_nat_target::attach): Update.
7722         * corelow.c (class core_target) <pid_to_str>: Change return type.
7723         (core_target::pid_to_str): Change return type.
7724         * target.c (normal_pid_to_str): Change return type.
7725         (default_pid_to_str): Likewise.
7726         (target_pid_to_str): Change return type.
7727         (target_translate_tls_address): Update.
7728         (target_announce_detach): Update.
7729         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7730         return type.
7731         (bsd_uthread_target::pid_to_str): Change return type.
7732         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7733         type.
7734         (bsd_kvm_target::pid_to_str): Change return type.
7735         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7736         return type.
7737         (aix_thread_target::pid_to_str): Change return type.
7738         * target.h (struct target_ops) <pid_to_str>: Change return type.
7739         (target_pid_to_str, normal_pid_to_str): Likewise.
7740         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7741         type.
7742         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7743         type.
7744         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7745         return type.
7746         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7747         type.
7748         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7749         type.
7750         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7751         return type.
7752
7753 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7754
7755         * NEWS: Mention that the new default MI version is 3.  Mention
7756         changes to the output of commands and events that deal with
7757         multi-location breakpoints.
7758         * breakpoint.c: Include "mi/mi-out.h".
7759         (print_one_breakpoint): Change output syntax if using MI version
7760         >= 3.
7761         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7762         New.
7763         (mi_multi_location_breakpoint_output_fixed): New.
7764         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7765         (mi_cmd_fix_multi_location_breakpoint_output): New.
7766         (mi_multi_location_breakpoint_output_fixed): New.
7767         * mi/mi-cmds.c (mi_cmds): Register command
7768         -fix-multi-location-breakpoint-output.
7769         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7770         interpreter "mi".
7771
7772 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7773
7774         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7775         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7776         instantiate mi_ui_out based on interpreter name.
7777         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7778         * mi/mi-main.c (mi_load_progress): Likewise.
7779
7780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7781
7782         * NEWS: Combine separate "New targets" sections for 8.3.
7783
7784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7785
7786         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7787         (ppcfbsd_init_abi): Install gdbarch
7788         "fetch_tls_load_module_address" and "get_thread_local_address"
7789         methods.
7790
7791 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7792
7793         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7794         (riscv_fbsd_init_abi): Install gdbarch
7795         "fetch_tls_load_module_address" and "get_thread_local_address"
7796         methods.
7797
7798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7799
7800         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7801         (i386fbsd_init_abi): Install gdbarch
7802         "fetch_tls_load_module_address" and "get_thread_local_address"
7803         methods.
7804
7805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7806
7807         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7808         (amd64fbsd_init_abi): Install gdbarch
7809         "fetch_tls_load_module_address" and "get_thread_local_address"
7810         methods.
7811
7812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7813
7814         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7815         (struct fbsd_pspace_data): New type.
7816         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7817         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7818         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7819         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7820         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7821
7822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7823
7824         * gdbtypes.c (lookup_struct_elt): New function.
7825         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7826         * gdbtypes.h (struct struct_elt): New type.
7827         (lookup_struct_elt): New prototype.
7828
7829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7830
7831         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7832         remove disabled code block.
7833
7834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7835
7836         * gdbarch.sh (get_thread_local_address): New method.
7837         * gdbarch.h, gdbarch.c: Regenerate.
7838         * target.c (target_translate_tls_address): Use
7839         gdbarch_get_thread_local_address if present instead of
7840         target::get_thread_local_address.
7841
7842 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7843
7844         * target.h (target::get_thread_local_address): Update comment.
7845
7846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7847
7848         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7849         objfile->separate_debug_objfile_backlink if not NULL.
7850
7851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7852
7853         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7854         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7855         (amd64bsd_store_inferior_registers): Likewise.
7856         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7857         Enable segment base registers.
7858         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7859         PT_GETFSBASE and PT_GETGSBASE.
7860         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7861         PT_SETGSBASE.
7862         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7863         segment base registers.
7864         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7865
7866 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7867
7868         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7869         Update calls to i386_target_description to add 'segments'
7870         parameter.
7871         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7872         add segment base registers.
7873         * arch/i386.c (i386_create_target_description): Add 'segments'
7874         parameter to enable segment base registers.
7875         * arch/i386.h (i386_create_target_description): Likewise.
7876         * features/i386/32bit-segments.xml: New file.
7877         * features/i386/32bit-segments.c: Generate.
7878         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7879         call to i386_target_description to add 'segments' parameter.
7880         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7881         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7882         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7883         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7884         if feature is present.
7885         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7886         Add 'segments' parameter to call to i386_target_description.
7887         (i386_target_description): Add 'segments' parameter to enable
7888         segment base registers.
7889         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7890         to call to i386_target_description.
7891         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7892         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7893         Define I386_NUM_REGS.
7894         (i386_target_description): Add 'segments' parameter to enable
7895         segment base registers.
7896
7897 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7898
7899         PR/24325
7900         * source-cache.c: #undef open and close, to avoid unresolved
7901         externals during linking.
7902
7903 2019-03-12  Tom Tromey  <tromey@adacore.com>
7904
7905         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7906         const.  Add initializers.
7907         (_initialize_remote): Don't initialize ptid globals.
7908
7909 2019-03-12  Pedro Alves  <palves@redhat.com>
7910
7911         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7912
7913 2019-03-12  Pedro Alves  <palves@redhat.com>
7914
7915         * cp-name-parser.y (main): Remove unused 'len' variable.
7916
7917 2019-03-12  Tom Tromey  <tromey@adacore.com>
7918
7919         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7920         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7921
7922 2019-03-12  Tom Tromey  <tromey@adacore.com>
7923
7924         * linux-nat.c (iterate_over_lwps): Update.
7925         (stop_callback): Remove parameter.
7926         (stop_wait_callback, detach_callback, resume_set_callback)
7927         (select_singlestep_lwp_callback, set_ignore_sigint)
7928         (status_callback, resumed_callback, resume_clear_callback)
7929         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7930         data parameter.
7931         (linux_nat_target::detach, linux_nat_target::resume)
7932         (linux_stop_and_wait_all_lwps, select_event_lwp)
7933         (linux_nat_filter_event, linux_nat_wait_1)
7934         (linux_nat_target::kill, linux_nat_target::stop)
7935         (linux_nat_target::stop): Update.
7936         (linux_nat_resume_callback): Change type.
7937         (resume_stopped_resumed_lwps, count_events_callback)
7938         (select_event_lwp_callback): Likewise.
7939         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7940         * arm-linux-nat.c (struct update_registers_data): Remove.
7941         (update_registers_callback): Change type.
7942         (arm_linux_insert_hw_breakpoint1): Update.
7943         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7944         parameter.
7945         (x86_linux_dr_set_addr): Update.
7946         (x86_linux_dr_set_control): Update.
7947         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7948         (iterate_over_lwps): Use gdb::function_view.
7949         * nat/aarch64-linux-hw-point.c (struct
7950         aarch64_dr_update_callback_param): Remove.
7951         (debug_reg_change_callback): Change type.
7952         (aarch64_notify_debug_reg_change): Update.
7953         * s390-linux-nat.c (s390_refresh_per_info): Update.
7954
7955 2019-03-11  Tom Tromey  <tromey@adacore.com>
7956
7957         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7958         redundant assignment to "this_cu".
7959
7960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7961
7962         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7963
7964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7965
7966         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7967         from...
7968         (rank_one_type): ... this.
7969
7970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7971
7972         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7973         from...
7974         (rank_one_type): ... this.
7975
7976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7977
7978         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7979         from...
7980         (rank_one_type): ... this.
7981
7982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7983
7984         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7985         from...
7986         (rank_one_type): ... this.
7987
7988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7989
7990         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7991         from...
7992         (rank_one_type): ... this.
7993
7994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7995
7996         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7997         from...
7998         (rank_one_type): ... this.
7999
8000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8001
8002         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8003         from...
8004         (rank_one_type): ... this.
8005
8006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8007
8008         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8009         from...
8010         (rank_one_type): ... this.
8011
8012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8013
8014         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8015         from...
8016         (rank_one_type): ... this.
8017
8018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8019
8020         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8021         from...
8022         (rank_one_type): ... this.
8023
8024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8025
8026         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8027         from...
8028         (rank_one_type): ... this.
8029
8030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8031
8032         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8033         from...
8034         (rank_one_type): ... this.
8035
8036 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8037
8038         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8039         inferior-events' shows the example events.
8040
8041 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8042
8043         Support styling on native MS-Windows console
8044
8045         PR/24315
8046         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8047         on MS-Windows if $TERM is not defined.
8048
8049         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8050
8051         * posix-hdep.c (gdb_console_fputs):
8052         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8053         functions.
8054         * ui-file.h (gdb_console_fputs): Add prototype.
8055
8056         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8057         back to fputs only if the former returns zero.
8058
8059 2019-03-07  Tom Tromey  <tom@tromey.com>
8060
8061         * symmisc.c (print_symbol_bcache_statistics): Update.
8062         (print_objfile_statistics): Update.
8063         * symfile.c (allocate_symtab): Update.
8064         * stabsread.c: Don't include bcache.h.
8065         * psymtab.h (struct psymbol_bcache): Don't declare.
8066         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8067         (psymbol_bcache_init, psymbol_bcache_free)
8068         (psymbol_bcache_get_bcache): Don't declare.
8069         * psymtab.c (struct psymbol_bcache): Remove.
8070         (psymtab_storage::psymtab_storage): Update.
8071         (psymtab_storage::~psymtab_storage): Update.
8072         (psymbol_bcache_init, psymbol_bcache_free)
8073         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8074         (add_psymbol_to_bcache): Update.
8075         (allocate_psymtab): Update.
8076         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8077         macro_cache>: No longer pointers.
8078         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8079         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8080         * macrotab.c (macro_bcache): Update.
8081         * macroexp.c: Don't include bcache.h.
8082         * gdbtypes.c (check_types_worklist): Update.
8083         (types_deeply_equal): Remove TRY/CATCH.  Update.
8084         * elfread.c (elf_symtab_read): Update.
8085         * dwarf2read.c: Don't include bcache.h.
8086         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8087         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8088         (print_bcache_statistics, bcache_memory_used): Don't declare.
8089         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8090         methods.  Rename all data members.
8091         * bcache.c (struct bcache): Move to bcache.h.
8092         (bcache::expand_hash_table): Rename from expand_hash_table.
8093         (bcache): Remove.
8094         (bcache::insert): Rename from bcache_full.
8095         (bcache::compare): Rename from bcache_compare.
8096         (bcache_xmalloc): Remove.
8097         (bcache::~bcache): Rename from bcache_xfree.
8098         (bcache::print_statistics): Rename from print_bcache_statistics.
8099         (bcache::memory_used): Rename from bcache_memory_used.
8100
8101 2019-03-07  Pedro Alves  <palves@redhat.com>
8102
8103         * infrun.c (normal_stop): Also check for
8104         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8105
8106 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8107
8108         * f-lang.c (value_from_host_double): Moved to...
8109         * value.c (value_from_host_double): ...here.
8110         * value.h (value_from_host_double): Declare.
8111         * guile/scm-math.c (vlscm_convert_typed_number): Use
8112         value_from_host_double.
8113         (vlscm_convert_number): Likewise.
8114         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8115         * python/py-value.c (convert_value_from_python): Likewise.
8116
8117 2019-03-06  Tom Tromey  <tom@tromey.com>
8118
8119         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8120
8121 2019-03-06  Tom Tromey  <tom@tromey.com>
8122
8123         * utils.h (free_current_contents): Don't declare.
8124         * utils.c (free_current_contents): Remove.
8125
8126 2019-03-06  Tom Tromey  <tom@tromey.com>
8127
8128         * top.c (quit_force): Update.
8129         * main.c (captured_command_loop): Update.
8130         * common/new-op.c (operator new): Update.
8131         * common/common-exceptions.c (struct catcher)
8132         <save_cleanup_chain>: Remove member.
8133         (exceptions_state_mc_init): Update.
8134         (exception_try_scope_entry): Return nullptr.
8135         (exception_try_scope_exit, exception_rethrow)
8136         (throw_exception_sjlj, throw_exception_cxx): Update.
8137         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8138         (all_cleanups, do_cleanups, discard_cleanups)
8139         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8140         (restore_cleanups, restore_final_cleanups): Don't declare.
8141         (do_final_cleanups): Remove parameter.
8142         * common/cleanups.c (cleanup_chain, make_cleanup)
8143         (make_cleanup_dtor, all_cleanups, do_cleanups)
8144         (discard_my_cleanups, discard_cleanups)
8145         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8146         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8147         (null_cleanup): Remove.
8148         (do_final_cleanups): Remove parameter.
8149
8150 2019-03-06  Tom Tromey  <tom@tromey.com>
8151
8152         * remote.c (remote_target::remote_parse_stop_reply): Use
8153         unique_xmalloc_ptr.
8154
8155 2019-03-06  Tom Tromey  <tom@tromey.com>
8156
8157         * stabsread.c (struct stabs_field_info): Rename from field_info.
8158         <list, fnlist>: Add initializers.
8159         <obstack>: New member.
8160         (read_member_functions, read_struct_fields, read_baseclasses):
8161         Allocate on obstack.  Don't use cleanups.
8162         (read_one_struct_field, read_member_functions, read_struct_fields)
8163         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8164         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8165         (read_struct_type): Update.
8166
8167 2019-03-06  Tom Tromey  <tom@tromey.com>
8168
8169         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8170         * common/filestuff.h (make_cleanup_close): Don't declare.
8171         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8172         Remove.
8173
8174 2019-03-06  Tom Tromey  <tom@tromey.com>
8175
8176         * solib-aix.c: Use make_scope_exit.
8177
8178 2019-03-06  Tom Tromey  <tom@tromey.com>
8179
8180         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8181         Use make_scope_exit.
8182
8183 2019-03-06  Tom Tromey  <tom@tromey.com>
8184
8185         * solib-svr4.c (disable_probes_interface): Remove parameter.
8186         (svr4_handle_solib_event): Use make_scope_exit.
8187
8188 2019-03-06  Tom Tromey  <tom@tromey.com>
8189
8190         * remote.c (struct stop_reply_deleter): Remove.
8191         (stop_reply_up): Update.
8192         (struct stop_reply): Derive from notif_event.  Don't typedef.
8193         <regcache>: Now a std::vector.
8194         (stop_reply_xfree): Remove.
8195         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8196         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8197         (remote_target::discard_pending_stop_replies): Use delete.
8198         (remote_target::remote_parse_stop_reply): Update.
8199         (remote_target::process_stop_reply): Update.
8200         * remote-notif.h (struct notif_event): Add virtual destructor.
8201         Remove "dtr" member.
8202         (struct notif_client) <alloc_event>: Return a unique_ptr.
8203         (notif_event_xfree): Don't declare.
8204         (notif_event_up): New typedef.
8205         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8206         (notif_event_xfree, do_notif_event_xfree): Remove.
8207         (remote_notif_state_xfree): Update.
8208
8209 2019-03-06  Tom Tromey  <tom@tromey.com>
8210
8211         * infrun.c (displaced_step_clear_cleanup): Now a
8212         forward_scope_exit type.
8213         (displaced_step_prepare_throw): Update.
8214         (displaced_step_fixup): Update.
8215
8216 2019-03-06  Tom Tromey  <tom@tromey.com>
8217
8218         * inferior.h (class inferior): Update comment.
8219         * gdbthread.h (class thread_info): Update comment.
8220
8221 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8222             Tom Tromey  <tom@tromey.com>
8223
8224         * stabsread.h (struct stab_section_list): Remove.
8225         (coffstab_build_psymtabs): Update.
8226         * dbxread.c (symbuf_sections): Now a std::vector.
8227         (sect_idx): New global.
8228         (fill_symbuf): Update.
8229         (coffstab_build_psymtabs): Change type of stabsects parameter.
8230         Update.
8231         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8232         std::vector.
8233         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8234         (coff_locate_sections): Update.
8235         (coff_symfile_read): Remove cleanups.  Update.
8236         (init_stringtab): Add storage parameter.
8237         (free_stringtab, free_stringtab_cleanup): Remove.
8238         (init_lineno): Add storage parameter.
8239         (free_linetab, free_linetab_cleanup): Remove.
8240
8241 2019-03-06  Pedro Alves  <palves@redhat.com>
8242
8243         * linux-fork.c (fork_info::clobber_regs): Delete.
8244         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8245         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8246         comment.  Adjust.
8247         (scoped_switch_fork_info::scoped_switch_fork_info)
8248         (checkpoint_command, linux_fork_context): Adjust
8249         fork_save_infrun_state calls.
8250
8251 2019-03-06  Pedro Alves  <palves@redhat.com>
8252
8253         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8254         (inf_has_multiple_threads): Return 'bool' and rewrite using
8255         inferior_info::threads().
8256
8257 2019-03-06  Pedro Alves  <palves@redhat.com>
8258
8259         * linux-fork.c: Include <list>.
8260         (fork_list): Now a std::list instance.
8261         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8262         (forks_exist_p, find_last_fork): Adjust.
8263         (new_fork): Delete.
8264         (one_fork_p): New.
8265         (add_fork): Adjust.
8266         (free_fork): Delete, folded into fork_info::~fork_info().
8267         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8268         Adjust.
8269         (init_fork_list): Delete.
8270         (linux_fork_killall, linux_fork_mourn_inferior)
8271         (linux_fork_detach, info_checkpoints_command): Adjust.
8272         (_initialize_linux_fork): No longer call init_fork_list.
8273
8274 2019-03-06  Pedro Alves  <palves@redhat.com>
8275
8276         * linux-fork.c (new_fork): New, split out of ...
8277         (add_fork): ... this.  Return void.  Move "first fork" special
8278         case from here, to ...
8279         (checkpoint_command): ... here.
8280         * linux-linux.h (add_fork): Return void.
8281
8282 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8283
8284         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8285
8286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8287             Chris January  <chris.january@arm.com>
8288             David Lecomber  <david.lecomber@arm.com>
8289
8290         * f-exp.y: New token, UNOP_INTRINSIC.
8291         (exp): New pattern using UNOP_INTRINSIC token.
8292         (f77_keywords): Add 'abs' keyword.
8293         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8294         (value_from_host_double): New function.
8295         (evaluate_subexp_f): Support UNOP_ABS.
8296
8297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8298
8299         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8300         types.
8301
8302 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8303
8304         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8305         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8306         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8307
8308 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8309
8310         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8311
8312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8313             Chris January  <chris.january@arm.com>
8314
8315         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8316         * f-exp.y: Define 'KIND' token.
8317         (exp): New pattern for KIND expressions.
8318         (ptype): Handle types with a kind extension.
8319         (direct_abs_decl): Extend to spot kind extensions.
8320         (f77_keywords): Add 'kind' to the list.
8321         (push_kind_type): New function.
8322         (convert_to_kind_type): New function.
8323         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8324         * parse.c (operator_length_standard): Likewise.
8325         * parser-defs.h (enum type_pieces): Add tp_kind.
8326         * std-operator.def: Add UNOP_KIND.
8327
8328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8329
8330         * f-exp.y (f_parse): Set yydebug.
8331
8332 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8333
8334         * f-lang.c (evaluate_subexp_f): New function.
8335         (exp_descriptor_f): New global.
8336         (f_language_defn): Use exp_descriptor_f instead of
8337         exp_descriptor_standard.
8338
8339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * f-exp.y (struct token): Add comments.
8342         (dot_ops): Remove uppercase versions and the end marker.
8343         (f77_keywords): Likewise.
8344         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8345         entries in the dot_ops array are case insensitive, and use
8346         strncasecmp to compare strings.  Also some whitespace cleanup in
8347         this area.  Similar for the f77_keywords array, except entries in
8348         this list might be case sensitive.
8349
8350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8351
8352         * f-exp.y (struct f77_boolean_val): Add comments.
8353         (boolean_values): Remove uppercase versions, and end marker.
8354         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8355         and use strncasecmp to achieve case insensitivity.  Additionally,
8356         perform whitespace cleanup around this code.
8357
8358 2019-03-06  Tom Tromey  <tromey@adacore.com>
8359
8360         * remote-sim.c (gdbsim_target_open): Use result of
8361         gdb_argv::release.
8362
8363 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8364         Dirk Schubert  <dirk.schubert@arm.com>
8365         Chris January  <chris.january@arm.com>
8366
8367         * eval.c (evaluate_subexp_standard): Call Fortran argument
8368         wrapping logic.
8369         * f-lang.c (struct value): A value which can be passed into a
8370         Fortran function call.
8371         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8372         where appropriate.
8373         (struct type): Value ready for a Fortran function call.
8374         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8375         is needed.
8376         * f-lang.h (fortran_argument_convert): Declaration.
8377         (fortran_preserve_arg_pointer): Declaration.
8378         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8379
8380 2019-03-05  Tom Tromey  <tromey@adacore.com>
8381
8382         * python/py-prettyprint.c (print_string_repr): Remove #if.
8383         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8384
8385 2019-03-05  Tom Tromey  <tromey@adacore.com>
8386
8387         * target.c (the_dummy_target): Move later.  Change type to
8388         "dummy_target".
8389         (initialize_targets): Don't initialize the_dummy_target.
8390
8391 2019-03-05  Tom Tromey  <tromey@adacore.com>
8392
8393         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8394         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8395
8396 2019-03-05  Tom Tromey  <tromey@adacore.com>
8397
8398         * windows-nat.c (windows_nat_target::attach)
8399         (windows_nat_target::detach): Don't call gdb_flush.
8400         * valprint.c (generic_val_print, val_print, val_print_string):
8401         Don't call gdb_flush.
8402         * utils.c (defaulted_query): Don't call gdb_flush.
8403         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8404         * target.c (target_announce_detach): Don't call gdb_flush.
8405         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8406         * remote.c (extended_remote_target::attach): Don't call
8407         gdb_flush.
8408         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8409         * printcmd.c (do_examine): Don't call gdb_flush.
8410         (info_display_command): Don't call gdb_flush.
8411         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8412         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8413         * memattr.c (info_mem_command): Don't call gdb_flush.
8414         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8415         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8416         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8417         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8418         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8419         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8420         (gnu_nat_target::detach): Don't call gdb_flush.
8421         * f-valprint.c (f_val_print): Don't call gdb_flush.
8422         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8423         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8424         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8425         gdb_flush.
8426         * c-valprint.c (c_val_print): Don't call gdb_flush.
8427         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8428
8429 2019-03-05  Tom Tromey  <tromey@adacore.com>
8430
8431         * varobj.c (update_dynamic_varobj_children): Update.
8432         (install_default_visualizer): Use reset, not release.
8433         * value.c (set_internalvar): Update.
8434         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8435         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8436         ATTRIBUTE_UNUSED_RESULT.
8437
8438 2019-03-05  Tom Tromey  <tromey@adacore.com>
8439
8440         * remote.c (class scoped_remote_fd) <release>: Add
8441         ATTRIBUTE_UNUSED_RESULT.
8442
8443 2019-03-05  Tom Tromey  <tromey@adacore.com>
8444
8445         * macroexp.c (struct macro_buffer) <release>: Add
8446         ATTRIBUTE_UNUSED_RESULT.
8447
8448 2019-03-05  Tom Tromey  <tromey@adacore.com>
8449
8450         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8451         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8452         ATTRIBUTE_UNUSED_RESULT.
8453
8454 2019-03-05  Tom Tromey  <tromey@adacore.com>
8455
8456         * common/scoped_fd.h (class scoped_fd) <release>: Add
8457         ATTRIBUTE_UNUSED_RESULT.
8458
8459 2019-03-05  Tom Tromey  <tromey@adacore.com>
8460
8461         * parser-defs.h (struct parser_state) <release>: Add
8462         ATTRIBUTE_UNUSED_RESULT.
8463
8464 2019-03-05  Tom Tromey  <tromey@adacore.com>
8465
8466         * utils.h (class gdb_argv) <release>: Add
8467         ATTRIBUTE_UNUSED_RESULT.
8468         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8469
8470 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8471
8472         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8473         for-loop range, to avoid compiler warnings.
8474
8475         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8476         avoid compiler warnings about unused variables.
8477
8478         * NEWS: Mention end of support for native debugging on MS-Windows
8479         before XP.
8480
8481         PR gdb/24292
8482         * common/netstuff.c:
8483         * gdbserver/gdbreplay.c
8484         * gdbserver/remote-utils.c:
8485         * ser-tcp.c:
8486         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8487         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8488         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8489         'getaddrinfo' and 'freeaddrinfo' were not available before
8490         Windows XP, and mingw.org's MinGW headers by default define
8491         _WIN32_WINNT to 0x500.
8492
8493 2019-03-01  Gary Benson <gbenson@redhat.com>
8494
8495         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8496
8497 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8498             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8499
8500         PR gdb/8527
8501         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8502         set_sigint_trap, clear_sigint_trap.
8503
8504 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8505
8506         * target.c (target_detach): Clear the regcache and the
8507         frame cache.
8508
8509 2019-02-27  Pedro Alves  <palves@redhat.com>
8510
8511         * utils.c (set_screen_size): When we cap the height/width sizes,
8512         tweak the corresponding command variable to show "unlimited":
8513
8514 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8515             Pedro Alves  <palves@redhat.com>
8516
8517         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8518         before calling rl_set_screen_size.
8519
8520 2019-02-27  Tom Tromey  <tromey@adacore.com>
8521
8522         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8523         define.
8524         * python/py-value.c: Remove Python 2.4 workaround.
8525         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8526         workaround.
8527         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8528         Python 2.4 workaround.
8529         * python/python-internal.h: Remove Python 2.4 comment.
8530         (Py_ssize_t): Don't define.
8531         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8532         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8533         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8534         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8535         * python/python.c (do_start_initialization): Remove Python 2.4
8536         workaround.
8537         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8538         (print_children): Remove Python 2.4 workaround.
8539         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8540         workaround.
8541         (CHARBUFFERPROC_NAME): Remove.
8542         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8543         Python 2.4 workaround.
8544
8545 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8546
8547         * NEWS: Note minimum Python version.
8548
8549 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8550
8551         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8552         code from these functions.  Remove corresponding ifdefs.  Use
8553         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8554         Remove gotos and target of gotos.
8555         (infpy_search_memory): Likewise.
8556
8557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8558
8559         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8560         (hppa_gdbarch_init): Don't register deleted functions with
8561         gdbarch.
8562
8563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8564
8565         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8566         (h8300_unwind_sp): Delete.
8567         (h8300_dummy_id): Delete.
8568         (h8300_gdbarch_init): Don't register deleted functions with
8569         gdbarch.
8570
8571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8572
8573         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8574         (ft32_unwind_pc): Delete.
8575         (ft32_unwind_sp): Delete.
8576         (ft32_gdbarch_init): Don't register deleted functions with
8577         gdbarch.
8578
8579 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8580
8581         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8582         (frv_unwind_pc): Delete.
8583         (frv_unwind_sp): Delete.
8584         (frv_gdbarch_init): Don't register deleted functions with
8585         gdbarch.
8586
8587 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8588
8589         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8590         (riscv_unwind_pc): Delete.
8591         (riscv_unwind_sp): Delete.
8592         (riscv_gdbarch_init): Don't register deleted functions with
8593         gdbarch.
8594
8595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8596
8597         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8598         (csky_unwind_pc): Delete.
8599         (csky_unwind_sp): Delete.
8600         (csky_gdbarch_init): Don't register deleted functions with
8601         gdbarch.
8602
8603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8604
8605         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8606         (cris_unwind_pc): Delete.
8607         (cris_unwind_sp): Delete.
8608         (cris_gdbarch_init): Don't register deleted functions with
8609         gdbarch.
8610
8611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8612
8613         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8614         (bfin_unwind_pc): Delete.
8615         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8616
8617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8618
8619         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8620         (arm_unwind_pc): Delete.
8621         (arm_unwind_sp): Delete.
8622         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8623
8624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8625
8626         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8627         (arc_unwind_pc): Delete.
8628         (arc_unwind_sp): Delete.
8629         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8630
8631 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8632
8633         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8634         (alpha_unwind_pc): Delete.
8635         (alpha_gdbarch_init): Don't register deleted functions with
8636         gdbarch.
8637
8638 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8639
8640         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8641         (aarch64_unwind_pc): Delete.
8642         (aarch64_unwind_sp): Delete.
8643         (aarch64_gdbarch_init): Don't register deleted functions with
8644         gdbarch.
8645
8646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8647
8648         * gdbtypes.c (type_align): Don't consider static members when
8649         computing structure alignment.
8650
8651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8652
8653         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8654         return 0 for other types.
8655         * arch-utils.c (default_type_align): Always return 0.
8656         * gdbarch.h: Regenerate.
8657         * gdbarch.sh (type_align): Extend comment.
8658         * gdbtypes.c (type_align): Add additional comments, always call
8659         gdbarch_type_align before applying the default rules.
8660         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8661         generic code will then apply a suitable default.
8662         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8663         types, return 0 for other types.
8664
8665 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8666
8667         * NEWS: Create a new section for the next release branch.
8668         Rename the section of the current branch, now that it has
8669         been cut.
8670
8671 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8672
8673         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8674         * version.in: Bump version to 8.3.50.DATE-git.
8675
8676 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8677
8678         * aix-thread.c (ptid_cmp): Remove unused variable.
8679         (get_signaled_thread): Likewise.
8680         (store_regs_user_thread): Likewise.
8681         (store_regs_kernel_thread): Likewise.
8682         (fetch_regs_kernel_thread): Remove shadowed variable.
8683
8684 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8685
8686         * features/riscv/32bit-cpu.xml: Add register numbers.
8687         * features/riscv/32bit-fpu.c: Regenerate.
8688         * features/riscv/32bit-fpu.xml: Add register numbers.
8689         * features/riscv/64bit-cpu.xml: Add register numbers.
8690         * features/riscv/64bit-fpu.c: Regenerate.
8691         * features/riscv/64bit-fpu.xml: Add register numbers.
8692
8693 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8694
8695         * NEWS: Mention two argument form of gdb.Value constructor.
8696         * python/py-value.c (convert_buffer_and_type_to_value): New
8697         function.
8698         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8699         Add support for handling an optional second argument.  Call
8700         convert_buffer_and_type_to_value as appropriate.
8701         * python/python-internal.h (Py_buffer_deleter): New struct.
8702         (Py_buffer_up): New typedef.
8703
8704 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8705
8706         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8707         instead of releasing ownership.
8708
8709 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8710
8711         * dwarf2read.c (open_and_init_dwp_file): Call
8712         elf_numsections instead of bfd_count_sections to initialize
8713         dwp_file->num_sections.
8714
8715 2019-02-25  Tom Tromey  <tromey@adacore.com>
8716
8717         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8718
8719 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8720
8721         * gcore.in: Add '--readnever' option when invoking GDB.
8722
8723 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8724
8725         * MAINTAINERS: Update my email address.
8726
8727 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8728
8729         * build-id.c (build_id_to_debug_bfd_1): New function.
8730         (build_id_to_debug_bfd): Look for separate debug file in
8731         sysroot.
8732
8733 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8734
8735         * gdbarch.sh: Update the copyright year range that is placed into
8736         generated files.
8737
8738 2019-02-22  Keith Seitz  <keiths@redhat.com>
8739
8740         PR symtab/23853
8741         * linespec.c (create_sals_line_offset): Search for the default
8742         symtab's filename instead of its fullname.
8743
8744 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8745
8746         * NEWS: Update style defaults.
8747
8748 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8749
8750         * main.c (captured_main_1): Disable styling in batch mode.
8751
8752 2019-02-20  Tom Tromey  <tom@tromey.com>
8753
8754         * symtab.c (symtab_symbol_info): Fix typos.
8755
8756 2019-02-20  Tom Tromey  <tromey@adacore.com>
8757
8758         * findcmd.c (_initialize_mem_search): Use upper case for
8759         metasyntactic variables.
8760
8761 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8762
8763         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8764         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8765
8766 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8767
8768         * top.h (source_file_name): Change to std::string.
8769         * top.c (source_file_name): Likewise.
8770         (command_line_input): Adjust.
8771         * cli/cli-script.c (script_from_file): Adjust.
8772
8773 2019-02-19  Tom Tromey  <tromey@adacore.com>
8774
8775         * ravenscar-thread.c
8776         (ravenscar_thread_target::update_thread_list): Don't call
8777         ada_build_task_list.
8778         * ada-lang.h (ada_build_task_list): Don't declare.
8779         * ada-tasks.c (struct ada_tasks_inferior_data)
8780         <task_list_valid_p>: Now bool.
8781         (read_known_tasks, ada_task_list_changed)
8782         (ada_tasks_invalidate_inferior_data): Update.
8783         (read_known_tasks_array): Return bool.
8784         (read_known_tasks_list): Likewise.
8785         (read_known_tasks): Return void.
8786         (ada_build_task_list): Now static.
8787
8788 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8791         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8792
8793 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8794
8795         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8796         variant for ada_tasks_pspace_data_handle and
8797         ada_tasks_inferior_data_handle.
8798         (ada_tasks_pspace_data_cleanup): New function.
8799         (ada_tasks_inferior_data_cleanup): New function.
8800
8801 2019-02-17  Tom Tromey  <tom@tromey.com>
8802
8803         * macrotab.h (macro_source_fullname): Return a std::string.
8804         * macrotab.c (macro_include, check_for_redefinition)
8805         (macro_undef, macro_lookup_definition, foreach_macro)
8806         (foreach_macro_in_scope): Update.
8807         (macro_source_fullname): Return a std::string.
8808         * macrocmd.c (show_pp_source_pos): Update.
8809
8810 2019-02-17  Tom Tromey  <tom@tromey.com>
8811
8812         * macrocmd.c (show_pp_source_pos): Style the file names.
8813
8814 2019-02-17  Tom Tromey  <tom@tromey.com>
8815
8816         PR tui/24197:
8817         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8818
8819 2019-02-17  Tom Tromey  <tom@tromey.com>
8820
8821         * ada-lang.c (user_select_syms): Use filtered printing.
8822         * utils.c (wrap_style): New global.
8823         (desired_style): Remove.
8824         (emit_style_escape): Add stream parameter.
8825         (set_output_style, reset_terminal_style, prompt_for_continue):
8826         Update.
8827         (flush_wrap_buffer): Only flush gdb_stdout.
8828         (wrap_here): Set wrap_style.
8829         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8830         treat escape sequences as a character.  Change when wrap buffer is
8831         flushed.
8832         (fputs_styled): Do not set the output style when the default is
8833         requested.
8834         * ui-style.h (struct ui_file_style) <is_default>: New method.
8835         * source.c (print_source_lines_base): Emit escape sequences in one
8836         piece.
8837
8838 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8839
8840         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8841         integers and enumeration types.
8842
8843 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8844
8845         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8846         instead of lookup_symbol_in_language
8847         (do_exact_match): New function.
8848         (ada_get_symbol_name_matcher): Return do_exact_match when
8849         doing a verbatim match.
8850
8851 2019-02-15  Tom Tromey  <tromey@adacore.com>
8852
8853         * ravenscar-thread.c (ravenscar_thread_target::resume)
8854         (ravenscar_thread_target::wait): Special case wildcard requests.
8855
8856 2019-02-15  Tom Tromey  <tromey@adacore.com>
8857
8858         * ravenscar-thread.c (base_ptid): Remove.
8859         (struct ravenscar_thread_target) <close>: New method.
8860         <m_base_ptid>: New member.
8861         <update_inferior_ptid, active_task, task_is_currently_active,
8862         runtime_initialized>: Declare methods.
8863         <ravenscar_thread_target>: Add constructor.
8864         (ravenscar_thread_target::task_is_currently_active)
8865         (ravenscar_thread_target::update_inferior_ptid)
8866         (ravenscar_runtime_initialized): Rename.  Now methods.
8867         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8868         (ravenscar_thread_target::update_thread_list): Update.
8869         (ravenscar_thread_target::active_task): Now method.
8870         (ravenscar_thread_target::store_registers)
8871         (ravenscar_thread_target::prepare_to_store)
8872         (ravenscar_thread_target::prepare_to_store)
8873         (ravenscar_thread_target::mourn_inferior): Update.
8874         (ravenscar_inferior_created): Use "new" to create target.
8875         (ravenscar_thread_target::get_ada_task_ptid): Update.
8876         (_initialize_ravenscar): Don't initialize base_ptid.
8877         (ravenscar_ops): Remove global.
8878
8879 2019-02-15  Tom Tromey  <tromey@adacore.com>
8880
8881         * target.h (push_target): Declare new overload.
8882         * target.c (push_target): New overload, taking an rvalue reference.
8883         * remote.c (remote_target::open_1): Use push_target overload.
8884         * corelow.c (core_target_open): Use push_target overload.
8885
8886 2019-02-15  Tom Tromey  <tromey@adacore.com>
8887
8888         * ravenscar-thread.c (is_ravenscar_task)
8889         (ravenscar_task_is_currently_active): Return bool.
8890         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8891         (_initialize_ravenscar): Remove "(void)".
8892         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8893         Return bool.
8894
8895 2019-02-15  Tom Tromey  <tromey@adacore.com>
8896
8897         * ravenscar-thread.c (ravenscar_runtime_initializer)
8898         (has_ravenscar_runtime, get_running_thread_id)
8899         (ravenscar_thread_target::resume): Fix indentation.
8900
8901 2019-02-15  Tom Tromey  <tromey@adacore.com>
8902
8903         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8904         from ravenscar_arch_ops.
8905         (sparc_ravenscar_ops::fetch_registers)
8906         (sparc_ravenscar_ops::store_registers): Now methods.
8907         (sparc_ravenscar_prepare_to_store): Remove.
8908         (sparc_ravenscar_ops): Redefine.
8909         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8910         methods and destructor.  Remove members.
8911         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8912         (ravenscar_thread_target::store_registers)
8913         (ravenscar_thread_target::prepare_to_store): Update.
8914         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8915         Remove.
8916         (struct ppc_ravenscar_powerpc_ops): Derive from
8917         ravenscar_arch_ops.
8918         (ppc_ravenscar_powerpc_ops::fetch_registers)
8919         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8920         (ppc_ravenscar_powerpc_ops): Redefine.
8921         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8922         (ppc_ravenscar_e500_ops::fetch_registers)
8923         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8924         (ppc_ravenscar_e500_ops): Redefine.
8925         * aarch64-ravenscar-thread.c
8926         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8927         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8928         (aarch64_ravenscar_fetch_registers)
8929         (aarch64_ravenscar_store_registers): Now methods.
8930         (aarch64_ravenscar_ops): Redefine.
8931
8932 2019-02-15  Tom Tromey  <tromey@adacore.com>
8933
8934         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8935         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8936         (ravenscar_thread_target::stopped_by_watchpoint)
8937         (ravenscar_thread_target::stopped_data_address)
8938         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8939
8940 2019-02-15  Tom Tromey  <tromey@adacore.com>
8941
8942         * ravenscar-thread.c: Fix some typos.
8943
8944 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8945             Tom Tromey  <tromey@adacore.com>
8946
8947         * ada-lang.c (ada_exception_sal): Change addr_string to a
8948         std::string.
8949         (create_ada_exception_catchpoint): Update.
8950
8951 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8952             Tom Tromey  <tromey@adacore.com>
8953
8954         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8955         (bp_location_ops): Remove.
8956         (base_breakpoint_allocate_location): Update.
8957         (free_bp_location): Update.
8958         * ada-lang.c (class ada_catchpoint_location)
8959         <ada_catchpoint_location>: Remove ops parameter.
8960         (ada_catchpoint_location_dtor): Remove.
8961         (ada_catchpoint_location_ops): Remove.
8962         (allocate_location_exception): Update.
8963         * breakpoint.h (struct bp_location_ops): Remove.
8964         (class bp_location) <bp_location>: Remove bp_location_ops
8965         parameter.
8966         <~bp_location>: Add destructor.
8967         <ops>: Remove.
8968
8969 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8970             Pedro Alves  <palves@redhat.com>
8971
8972         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8973         'PATH_MAX'.
8974
8975 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8976             Samuel Thibault  <samuel.thibault@gnu.org>
8977             Thomas Schwinge  <thomas@codesourcery.com>
8978
8979         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8980         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8981
8982 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8983
8984         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8985         (check_empty): Use "const char *".
8986
8987         * gnu-nat.c (gnu_nat_target::detach): Instead of
8988         'detach_inferior (pid)' call
8989         'detach_inferior (find_inferior_pid (pid))'.
8990
8991         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8992         'nat/fork-inferior.o'.
8993         * gnu-nat.c: #include "nat/fork-inferior.h".
8994
8995         * gnu-nat.c (gnu_nat_target::detach): Instead of
8996         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8997         * gnu-nat.h: #include "inf-child.h".
8998         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8999         'i386_gnu_nat_target::fetch_registers'.
9000         (gnu_store_registers): Rename/move to
9001         'i386_gnu_nat_target::store_registers'.
9002
9003         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9004         * gnu-nat.h (mach_thread_info): New function.
9005         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9006
9007         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9008
9009 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9010
9011         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9012
9013 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9014
9015         * windows-nat.c (windows_add_thread): Add new parameter
9016         "main_thread_p" with default value set to false.  Update
9017         function documentation as well as all callers.
9018         (windows_delete_thread): Likewise.
9019         (fake_create_process): Update call to windows_add_thread.
9020         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9021         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9022         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9023         call to windows_delete_thread.
9024
9025 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9026
9027         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9028
9029 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9030
9031         * symfile.c (find_separate_debug_file): Use canonical path of
9032         sysroot with child_path instead of gdb_sysroot if it is valid.
9033
9034 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9035
9036         * symfile.c (find_separate_debug_file): Use child_path to
9037         determine if an object file is under a sysroot.
9038
9039 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9040
9041         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9042         unittests/child-path-selftests.c.
9043         * common/pathstuff.c (child_path): New function.
9044         * common/pathstuff.h (child_path): New prototype.
9045         * unittests/child-path-selftests.c: New file.
9046
9047 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9048
9049         * symfile.c (find_separate_debug_file): Look for separate debug
9050         files in debug directories under the sysroot.
9051
9052 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9053
9054         * symtab.h (struct minimal_symbol data_p): New const method.
9055         (struct minimal_symbol text_p): Likewise.
9056         * symtab.c (output_source_filename): Use file name style
9057         to print file name.
9058         (print_symbol_info): Likewise.
9059         (print_msymbol_info): Use address style to print addresses.
9060         Use function name style to print executable text symbols.
9061         (expand_symtab_containing_pc): Use data_p.
9062         (find_pc_sect_compunit_symtab): Likewise.
9063
9064 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9065
9066         * breakpoint.c (describe_other_breakpoints): Use address style
9067         to print addresses.
9068         (say_where): Likewise.
9069
9070 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9071
9072         * ada-typeprint.c (print_func_type): Print function name
9073         style to print function name.
9074         * c-typeprint.c (c_print_type_1): Likewise.
9075
9076 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9077
9078         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9079         for execve.
9080
9081 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9082
9083         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9084         type_stack.
9085
9086 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9087
9088         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9089         TYPE_CODE_REF types.
9090
9091 2019-02-08  Jim Wilson  <jimw@sifive.com>
9092
9093         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9094         (riscv_linux_fregset): New.
9095         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9096
9097 2019-02-07  Tom Tromey  <tom@tromey.com>
9098
9099         * thread.c (thread_cancel_execution_command): Update.
9100         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9101         methods.
9102         (struct thread_fsm_ops): Remove.
9103         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9104         (thread_fsm_should_stop, thread_fsm_return_value)
9105         (thread_fsm_set_finished, thread_fsm_finished_p)
9106         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9107         Don't declare.
9108         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9109         * infrun.c (clear_proceed_status_thread)
9110         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9111         (print_stop_event): Update.
9112         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9113         Add constructor.
9114         (step_command_fsm_ops): Remove.
9115         (new_step_command_fsm): Remove.
9116         (step_1): Update.
9117         (step_command_fsm::should_stop): Rename from
9118         step_command_fsm_should_stop.
9119         (step_command_fsm::clean_up): Rename from
9120         step_command_fsm_clean_up.
9121         (step_command_fsm::do_async_reply_reason): Rename from
9122         step_command_fsm_async_reply_reason.
9123         (struct until_next_fsm): Inherit from thread_fsm.  Add
9124         constructor.
9125         (until_next_fsm_ops): Remove.
9126         (new_until_next_fsm): Remove.
9127         (until_next_fsm::should_stop): Rename from
9128         until_next_fsm_should_stop.
9129         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9130         (until_next_fsm::do_async_reply_reason): Rename from
9131         until_next_fsm_async_reply_reason.
9132         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9133         constructor.  Change type of breakpoint.
9134         (finish_command_fsm_ops): Remove.
9135         (new_finish_command_fsm): Remove.
9136         (finish_command_fsm::should_stop): Rename from
9137         finish_command_fsm_should_stop.
9138         (finish_command_fsm::clean_up): Rename from
9139         finish_command_fsm_clean_up.
9140         (finish_command_fsm::return_value): Rename from
9141         finish_command_fsm_return_value.
9142         (finish_command_fsm::do_async_reply_reason): Rename from
9143         finish_command_fsm_async_reply_reason.
9144         (finish_command): Update.
9145         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9146         Add constructor.
9147         (call_thread_fsm_ops): Remove.
9148         (call_thread_fsm::call_thread_fsm): Rename from
9149         new_call_thread_fsm.
9150         (call_thread_fsm::should_stop): Rename from
9151         call_thread_fsm_should_stop.
9152         (call_thread_fsm::should_notify_stop): Rename from
9153         call_thread_fsm_should_notify_stop.
9154         (run_inferior_call, call_function_by_hand_dummy): Update.
9155         * cli/cli-interp.c (should_print_stop_to_console): Update.
9156         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9157         Add constructor.  Change type of location_breakpoint,
9158         caller_breakpoint.
9159         (until_break_fsm_ops): Remove.
9160         (new_until_break_fsm): Remove.
9161         (until_break_fsm::should_stop): Rename from
9162         until_break_fsm_should_stop.
9163         (until_break_fsm::clean_up): Rename from
9164         until_break_fsm_clean_up.
9165         (until_break_fsm::do_async_reply_reason): Rename from
9166         until_break_fsm_async_reply_reason.
9167         (until_break_command): Update.
9168         * thread-fsm.c: Remove.
9169         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9170
9171 2019-02-07  Tom Tromey  <tom@tromey.com>
9172
9173         * yy-remap.h: Add include guard.
9174         * xtensa-tdep.h: Add include guard.
9175         * xcoffread.h: Rename include guard.
9176         * varobj-iter.h: Add include guard.
9177         * tui/tui.h: Rename include guard.
9178         * tui/tui-winsource.h: Rename include guard.
9179         * tui/tui-wingeneral.h: Rename include guard.
9180         * tui/tui-windata.h: Rename include guard.
9181         * tui/tui-win.h: Rename include guard.
9182         * tui/tui-stack.h: Rename include guard.
9183         * tui/tui-source.h: Rename include guard.
9184         * tui/tui-regs.h: Rename include guard.
9185         * tui/tui-out.h: Rename include guard.
9186         * tui/tui-layout.h: Rename include guard.
9187         * tui/tui-io.h: Rename include guard.
9188         * tui/tui-hooks.h: Rename include guard.
9189         * tui/tui-file.h: Rename include guard.
9190         * tui/tui-disasm.h: Rename include guard.
9191         * tui/tui-data.h: Rename include guard.
9192         * tui/tui-command.h: Rename include guard.
9193         * tic6x-tdep.h: Add include guard.
9194         * target/waitstatus.h: Rename include guard.
9195         * target/wait.h: Rename include guard.
9196         * target/target.h: Rename include guard.
9197         * target/resume.h: Rename include guard.
9198         * target-float.h: Rename include guard.
9199         * stabsread.h: Add include guard.
9200         * rs6000-tdep.h: Add include guard.
9201         * riscv-fbsd-tdep.h: Add include guard.
9202         * regformats/regdef.h: Rename include guard.
9203         * record.h: Rename include guard.
9204         * python/python.h: Rename include guard.
9205         * python/python-internal.h: Rename include guard.
9206         * python/py-stopevent.h: Rename include guard.
9207         * python/py-ref.h: Rename include guard.
9208         * python/py-record.h: Rename include guard.
9209         * python/py-record-full.h: Rename include guard.
9210         * python/py-record-btrace.h: Rename include guard.
9211         * python/py-instruction.h: Rename include guard.
9212         * python/py-events.h: Rename include guard.
9213         * python/py-event.h: Rename include guard.
9214         * procfs.h: Add include guard.
9215         * proc-utils.h: Add include guard.
9216         * p-lang.h: Add include guard.
9217         * or1k-tdep.h: Rename include guard.
9218         * observable.h: Rename include guard.
9219         * nto-tdep.h: Rename include guard.
9220         * nat/x86-linux.h: Rename include guard.
9221         * nat/x86-linux-dregs.h: Rename include guard.
9222         * nat/x86-gcc-cpuid.h: Add include guard.
9223         * nat/x86-dregs.h: Rename include guard.
9224         * nat/x86-cpuid.h: Rename include guard.
9225         * nat/ppc-linux.h: Rename include guard.
9226         * nat/mips-linux-watch.h: Rename include guard.
9227         * nat/linux-waitpid.h: Rename include guard.
9228         * nat/linux-ptrace.h: Rename include guard.
9229         * nat/linux-procfs.h: Rename include guard.
9230         * nat/linux-osdata.h: Rename include guard.
9231         * nat/linux-nat.h: Rename include guard.
9232         * nat/linux-namespaces.h: Rename include guard.
9233         * nat/linux-btrace.h: Rename include guard.
9234         * nat/glibc_thread_db.h: Rename include guard.
9235         * nat/gdb_thread_db.h: Rename include guard.
9236         * nat/gdb_ptrace.h: Rename include guard.
9237         * nat/fork-inferior.h: Rename include guard.
9238         * nat/amd64-linux-siginfo.h: Rename include guard.
9239         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9240         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9241         * nat/aarch64-linux.h: Rename include guard.
9242         * nat/aarch64-linux-hw-point.h: Rename include guard.
9243         * mn10300-tdep.h: Add include guard.
9244         * mips-linux-tdep.h: Add include guard.
9245         * mi/mi-parse.h: Rename include guard.
9246         * mi/mi-out.h: Rename include guard.
9247         * mi/mi-main.h: Rename include guard.
9248         * mi/mi-interp.h: Rename include guard.
9249         * mi/mi-getopt.h: Rename include guard.
9250         * mi/mi-console.h: Rename include guard.
9251         * mi/mi-common.h: Rename include guard.
9252         * mi/mi-cmds.h: Rename include guard.
9253         * mi/mi-cmd-break.h: Rename include guard.
9254         * m2-lang.h: Add include guard.
9255         * location.h: Rename include guard.
9256         * linux-record.h: Rename include guard.
9257         * linux-nat.h: Add include guard.
9258         * linux-fork.h: Add include guard.
9259         * i386-darwin-tdep.h: Rename include guard.
9260         * hppa-linux-offsets.h: Add include guard.
9261         * guile/guile.h: Rename include guard.
9262         * guile/guile-internal.h: Rename include guard.
9263         * gnu-nat.h: Rename include guard.
9264         * gdb-stabs.h: Rename include guard.
9265         * frv-tdep.h: Add include guard.
9266         * f-lang.h: Add include guard.
9267         * event-loop.h: Add include guard.
9268         * darwin-nat.h: Rename include guard.
9269         * cp-abi.h: Rename include guard.
9270         * config/sparc/nm-sol2.h: Rename include guard.
9271         * config/nm-nto.h: Rename include guard.
9272         * config/nm-linux.h: Add include guard.
9273         * config/i386/nm-i386gnu.h: Rename include guard.
9274         * config/djgpp/nl_types.h: Rename include guard.
9275         * config/djgpp/langinfo.h: Rename include guard.
9276         * compile/gcc-cp-plugin.h: Add include guard.
9277         * compile/gcc-c-plugin.h: Add include guard.
9278         * compile/compile.h: Rename include guard.
9279         * compile/compile-object-run.h: Rename include guard.
9280         * compile/compile-object-load.h: Rename include guard.
9281         * compile/compile-internal.h: Rename include guard.
9282         * compile/compile-cplus.h: Rename include guard.
9283         * compile/compile-c.h: Rename include guard.
9284         * common/xml-utils.h: Rename include guard.
9285         * common/x86-xstate.h: Rename include guard.
9286         * common/version.h: Rename include guard.
9287         * common/vec.h: Rename include guard.
9288         * common/tdesc.h: Rename include guard.
9289         * common/selftest.h: Rename include guard.
9290         * common/scoped_restore.h: Rename include guard.
9291         * common/scoped_mmap.h: Rename include guard.
9292         * common/scoped_fd.h: Rename include guard.
9293         * common/safe-iterator.h: Rename include guard.
9294         * common/run-time-clock.h: Rename include guard.
9295         * common/refcounted-object.h: Rename include guard.
9296         * common/queue.h: Rename include guard.
9297         * common/ptid.h: Rename include guard.
9298         * common/print-utils.h: Rename include guard.
9299         * common/preprocessor.h: Rename include guard.
9300         * common/pathstuff.h: Rename include guard.
9301         * common/observable.h: Rename include guard.
9302         * common/netstuff.h: Rename include guard.
9303         * common/job-control.h: Rename include guard.
9304         * common/host-defs.h: Rename include guard.
9305         * common/gdb_wait.h: Rename include guard.
9306         * common/gdb_vecs.h: Rename include guard.
9307         * common/gdb_unlinker.h: Rename include guard.
9308         * common/gdb_unique_ptr.h: Rename include guard.
9309         * common/gdb_tilde_expand.h: Rename include guard.
9310         * common/gdb_sys_time.h: Rename include guard.
9311         * common/gdb_string_view.h: Rename include guard.
9312         * common/gdb_splay_tree.h: Rename include guard.
9313         * common/gdb_setjmp.h: Rename include guard.
9314         * common/gdb_ref_ptr.h: Rename include guard.
9315         * common/gdb_optional.h: Rename include guard.
9316         * common/gdb_locale.h: Rename include guard.
9317         * common/gdb_assert.h: Rename include guard.
9318         * common/filtered-iterator.h: Rename include guard.
9319         * common/filestuff.h: Rename include guard.
9320         * common/fileio.h: Rename include guard.
9321         * common/environ.h: Rename include guard.
9322         * common/common-utils.h: Rename include guard.
9323         * common/common-types.h: Rename include guard.
9324         * common/common-regcache.h: Rename include guard.
9325         * common/common-inferior.h: Rename include guard.
9326         * common/common-gdbthread.h: Rename include guard.
9327         * common/common-exceptions.h: Rename include guard.
9328         * common/common-defs.h: Rename include guard.
9329         * common/common-debug.h: Rename include guard.
9330         * common/cleanups.h: Rename include guard.
9331         * common/buffer.h: Rename include guard.
9332         * common/btrace-common.h: Rename include guard.
9333         * common/break-common.h: Rename include guard.
9334         * cli/cli-utils.h: Rename include guard.
9335         * cli/cli-style.h: Rename include guard.
9336         * cli/cli-setshow.h: Rename include guard.
9337         * cli/cli-script.h: Rename include guard.
9338         * cli/cli-interp.h: Rename include guard.
9339         * cli/cli-decode.h: Rename include guard.
9340         * cli/cli-cmds.h: Rename include guard.
9341         * charset-list.h: Add include guard.
9342         * buildsym-legacy.h: Rename include guard.
9343         * bfin-tdep.h: Add include guard.
9344         * ax.h: Rename include guard.
9345         * arm-linux-tdep.h: Add include guard.
9346         * arm-fbsd-tdep.h: Add include guard.
9347         * arch/xtensa.h: Rename include guard.
9348         * arch/tic6x.h: Add include guard.
9349         * arch/i386.h: Add include guard.
9350         * arch/arm.h: Rename include guard.
9351         * arch/arm-linux.h: Rename include guard.
9352         * arch/arm-get-next-pcs.h: Rename include guard.
9353         * arch/amd64.h: Add include guard.
9354         * arch/aarch64-insn.h: Rename include guard.
9355         * arch-utils.h: Rename include guard.
9356         * annotate.h: Add include guard.
9357         * amd64-darwin-tdep.h: Rename include guard.
9358         * aarch64-linux-tdep.h: Add include guard.
9359         * aarch64-fbsd-tdep.h: Add include guard.
9360         * aarch32-linux-nat.h: Add include guard.
9361
9362 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9363
9364         * macrotab.c (macro_define_internal): New function that
9365         factorizes macro_define_object_internal and macro_define_function
9366         code.
9367         (macro_define_object_internal): Use macro_define_internal.
9368         (macro_define_function): Likewise.
9369
9370 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9371
9372         * macrocmd.c (extract_identifier): Return
9373         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9374         callers.
9375
9376 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9377
9378         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9379
9380 2019-02-05  Tom Tromey  <tom@tromey.com>
9381
9382         * target.c (target_stack::unpush): Move assertion earlier.
9383
9384 2019-01-30  Tom Tromey  <tom@tromey.com>
9385
9386         PR python/23615:
9387         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9388         (gdbpy_parse_and_eval): Likewise.
9389         * python/python-internal.h (gdbpy_allow_threads): New class.
9390
9391 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9392
9393         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9394         (aarch64_fbsd_fpregmap): Move earlier.
9395         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9396         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9397         instead of individual calls to trad_frame_set_reg_addr.
9398         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9399         earlier.
9400         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9401         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9402         instead of individual calls to trad_frame_set_reg_addr.
9403
9404 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9405
9406         * CONTRIBUTE: Replace contribution list with wiki link.
9407
9408 2019-01-25  Tom Tromey  <tom@tromey.com>
9409
9410         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9411
9412 2019-01-25  Tom Tromey  <tom@tromey.com>
9413
9414         * xtensa-linux-nat.c: Fix common/ includes.
9415         * xml-support.h: Fix common/ includes.
9416         * xml-support.c: Fix common/ includes.
9417         * x86-linux-nat.c: Fix common/ includes.
9418         * windows-nat.c: Fix common/ includes.
9419         * varobj.h: Fix common/ includes.
9420         * varobj.c: Fix common/ includes.
9421         * value.c: Fix common/ includes.
9422         * valops.c: Fix common/ includes.
9423         * utils.c: Fix common/ includes.
9424         * unittests/xml-utils-selftests.c: Fix common/ includes.
9425         * unittests/utils-selftests.c: Fix common/ includes.
9426         * unittests/unpack-selftests.c: Fix common/ includes.
9427         * unittests/tracepoint-selftests.c: Fix common/ includes.
9428         * unittests/style-selftests.c: Fix common/ includes.
9429         * unittests/string_view-selftests.c: Fix common/ includes.
9430         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9431         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9432         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9433         * unittests/rsp-low-selftests.c: Fix common/ includes.
9434         * unittests/parse-connection-spec-selftests.c: Fix common/
9435         includes.
9436         * unittests/optional-selftests.c: Fix common/ includes.
9437         * unittests/offset-type-selftests.c: Fix common/ includes.
9438         * unittests/observable-selftests.c: Fix common/ includes.
9439         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9440         * unittests/memrange-selftests.c: Fix common/ includes.
9441         * unittests/memory-map-selftests.c: Fix common/ includes.
9442         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9443         * unittests/function-view-selftests.c: Fix common/ includes.
9444         * unittests/environ-selftests.c: Fix common/ includes.
9445         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9446         * unittests/common-utils-selftests.c: Fix common/ includes.
9447         * unittests/cli-utils-selftests.c: Fix common/ includes.
9448         * unittests/array-view-selftests.c: Fix common/ includes.
9449         * ui-file.c: Fix common/ includes.
9450         * tui/tui-io.c: Fix common/ includes.
9451         * tracepoint.h: Fix common/ includes.
9452         * tracepoint.c: Fix common/ includes.
9453         * tracefile-tfile.c: Fix common/ includes.
9454         * top.h: Fix common/ includes.
9455         * top.c: Fix common/ includes.
9456         * thread.c: Fix common/ includes.
9457         * target/waitstatus.h: Fix common/ includes.
9458         * target/waitstatus.c: Fix common/ includes.
9459         * target.h: Fix common/ includes.
9460         * target.c: Fix common/ includes.
9461         * target-memory.c: Fix common/ includes.
9462         * target-descriptions.c: Fix common/ includes.
9463         * symtab.h: Fix common/ includes.
9464         * symfile.c: Fix common/ includes.
9465         * stap-probe.c: Fix common/ includes.
9466         * spu-linux-nat.c: Fix common/ includes.
9467         * sparc-nat.c: Fix common/ includes.
9468         * source.c: Fix common/ includes.
9469         * solib.c: Fix common/ includes.
9470         * solib-target.c: Fix common/ includes.
9471         * ser-unix.c: Fix common/ includes.
9472         * ser-tcp.c: Fix common/ includes.
9473         * ser-pipe.c: Fix common/ includes.
9474         * ser-base.c: Fix common/ includes.
9475         * selftest-arch.c: Fix common/ includes.
9476         * s12z-tdep.c: Fix common/ includes.
9477         * rust-exp.y: Fix common/ includes.
9478         * rs6000-aix-tdep.c: Fix common/ includes.
9479         * riscv-tdep.c: Fix common/ includes.
9480         * remote.c: Fix common/ includes.
9481         * remote-notif.h: Fix common/ includes.
9482         * remote-fileio.h: Fix common/ includes.
9483         * remote-fileio.c: Fix common/ includes.
9484         * regcache.h: Fix common/ includes.
9485         * regcache.c: Fix common/ includes.
9486         * record-btrace.c: Fix common/ includes.
9487         * python/python.c: Fix common/ includes.
9488         * python/py-type.c: Fix common/ includes.
9489         * python/py-inferior.c: Fix common/ includes.
9490         * progspace.h: Fix common/ includes.
9491         * producer.c: Fix common/ includes.
9492         * procfs.c: Fix common/ includes.
9493         * proc-api.c: Fix common/ includes.
9494         * printcmd.c: Fix common/ includes.
9495         * ppc-linux-nat.c: Fix common/ includes.
9496         * parser-defs.h: Fix common/ includes.
9497         * osdata.c: Fix common/ includes.
9498         * obsd-nat.c: Fix common/ includes.
9499         * nat/x86-linux.c: Fix common/ includes.
9500         * nat/x86-linux-dregs.c: Fix common/ includes.
9501         * nat/x86-dregs.h: Fix common/ includes.
9502         * nat/x86-dregs.c: Fix common/ includes.
9503         * nat/ppc-linux.c: Fix common/ includes.
9504         * nat/mips-linux-watch.h: Fix common/ includes.
9505         * nat/mips-linux-watch.c: Fix common/ includes.
9506         * nat/linux-waitpid.c: Fix common/ includes.
9507         * nat/linux-ptrace.h: Fix common/ includes.
9508         * nat/linux-ptrace.c: Fix common/ includes.
9509         * nat/linux-procfs.c: Fix common/ includes.
9510         * nat/linux-personality.c: Fix common/ includes.
9511         * nat/linux-osdata.c: Fix common/ includes.
9512         * nat/linux-namespaces.c: Fix common/ includes.
9513         * nat/linux-btrace.h: Fix common/ includes.
9514         * nat/linux-btrace.c: Fix common/ includes.
9515         * nat/fork-inferior.c: Fix common/ includes.
9516         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9517         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9518         * nat/aarch64-linux.c: Fix common/ includes.
9519         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9520         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9521         * namespace.h: Fix common/ includes.
9522         * mips-linux-tdep.c: Fix common/ includes.
9523         * minsyms.c: Fix common/ includes.
9524         * mi/mi-parse.h: Fix common/ includes.
9525         * mi/mi-main.c: Fix common/ includes.
9526         * mi/mi-cmd-env.c: Fix common/ includes.
9527         * memrange.h: Fix common/ includes.
9528         * memattr.c: Fix common/ includes.
9529         * maint.h: Fix common/ includes.
9530         * maint.c: Fix common/ includes.
9531         * main.c: Fix common/ includes.
9532         * machoread.c: Fix common/ includes.
9533         * location.c: Fix common/ includes.
9534         * linux-thread-db.c: Fix common/ includes.
9535         * linux-nat.c: Fix common/ includes.
9536         * linux-fork.c: Fix common/ includes.
9537         * inline-frame.c: Fix common/ includes.
9538         * infrun.c: Fix common/ includes.
9539         * inflow.c: Fix common/ includes.
9540         * inferior.h: Fix common/ includes.
9541         * inferior.c: Fix common/ includes.
9542         * infcmd.c: Fix common/ includes.
9543         * inf-ptrace.c: Fix common/ includes.
9544         * inf-child.c: Fix common/ includes.
9545         * ia64-linux-nat.c: Fix common/ includes.
9546         * i387-tdep.c: Fix common/ includes.
9547         * i386-tdep.c: Fix common/ includes.
9548         * i386-linux-tdep.c: Fix common/ includes.
9549         * i386-linux-nat.c: Fix common/ includes.
9550         * i386-go32-tdep.c: Fix common/ includes.
9551         * i386-fbsd-tdep.c: Fix common/ includes.
9552         * i386-fbsd-nat.c: Fix common/ includes.
9553         * guile/scm-type.c: Fix common/ includes.
9554         * guile/guile.c: Fix common/ includes.
9555         * go32-nat.c: Fix common/ includes.
9556         * gnu-nat.c: Fix common/ includes.
9557         * gdbthread.h: Fix common/ includes.
9558         * gdbarch-selftests.c: Fix common/ includes.
9559         * gdb_usleep.c: Fix common/ includes.
9560         * gdb_select.h: Fix common/ includes.
9561         * gdb_bfd.c: Fix common/ includes.
9562         * gcore.c: Fix common/ includes.
9563         * fork-child.c: Fix common/ includes.
9564         * findvar.c: Fix common/ includes.
9565         * fbsd-nat.c: Fix common/ includes.
9566         * event-top.c: Fix common/ includes.
9567         * event-loop.c: Fix common/ includes.
9568         * dwarf2read.c: Fix common/ includes.
9569         * dwarf2loc.c: Fix common/ includes.
9570         * dwarf2-frame.c: Fix common/ includes.
9571         * dwarf-index-cache.c: Fix common/ includes.
9572         * dtrace-probe.c: Fix common/ includes.
9573         * disasm-selftests.c: Fix common/ includes.
9574         * defs.h: Fix common/ includes.
9575         * csky-tdep.c: Fix common/ includes.
9576         * cp-valprint.c: Fix common/ includes.
9577         * cp-support.h: Fix common/ includes.
9578         * cp-support.c: Fix common/ includes.
9579         * corelow.c: Fix common/ includes.
9580         * completer.h: Fix common/ includes.
9581         * completer.c: Fix common/ includes.
9582         * compile/compile.c: Fix common/ includes.
9583         * compile/compile-loc2c.c: Fix common/ includes.
9584         * compile/compile-cplus-types.c: Fix common/ includes.
9585         * compile/compile-cplus-symbols.c: Fix common/ includes.
9586         * command.h: Fix common/ includes.
9587         * cli/cli-dump.c: Fix common/ includes.
9588         * cli/cli-cmds.c: Fix common/ includes.
9589         * charset.c: Fix common/ includes.
9590         * build-id.c: Fix common/ includes.
9591         * btrace.h: Fix common/ includes.
9592         * btrace.c: Fix common/ includes.
9593         * breakpoint.h: Fix common/ includes.
9594         * breakpoint.c: Fix common/ includes.
9595         * ax.h:
9596         (enum agent_op): Fix common/ includes.
9597         * ax-general.c (struct aop_map): Fix common/ includes.
9598         * ax-gdb.c: Fix common/ includes.
9599         * auxv.c: Fix common/ includes.
9600         * auto-load.c: Fix common/ includes.
9601         * arm-tdep.c: Fix common/ includes.
9602         * arch/riscv.c: Fix common/ includes.
9603         * arch/ppc-linux-common.c: Fix common/ includes.
9604         * arch/i386.c: Fix common/ includes.
9605         * arch/arm.c: Fix common/ includes.
9606         * arch/arm-linux.c: Fix common/ includes.
9607         * arch/arm-get-next-pcs.c: Fix common/ includes.
9608         * arch/amd64.c: Fix common/ includes.
9609         * arch/aarch64.c: Fix common/ includes.
9610         * arch/aarch64-insn.c: Fix common/ includes.
9611         * arch-utils.c: Fix common/ includes.
9612         * amd64-windows-tdep.c: Fix common/ includes.
9613         * amd64-tdep.c: Fix common/ includes.
9614         * amd64-sol2-tdep.c: Fix common/ includes.
9615         * amd64-obsd-tdep.c: Fix common/ includes.
9616         * amd64-nbsd-tdep.c: Fix common/ includes.
9617         * amd64-linux-tdep.c: Fix common/ includes.
9618         * amd64-linux-nat.c: Fix common/ includes.
9619         * amd64-fbsd-tdep.c: Fix common/ includes.
9620         * amd64-fbsd-nat.c: Fix common/ includes.
9621         * amd64-dicos-tdep.c: Fix common/ includes.
9622         * amd64-darwin-tdep.c: Fix common/ includes.
9623         * agent.c: Fix common/ includes.
9624         * ada-lang.h: Fix common/ includes.
9625         * ada-lang.c: Fix common/ includes.
9626         * aarch64-tdep.c: Fix common/ includes.
9627
9628 2019-01-25  Tom Tromey  <tom@tromey.com>
9629
9630         * common/create-version.sh: Use common/version.h.
9631
9632 2019-01-24  Pedro Alves  <palves@redhat.com>
9633
9634         * infrun.c (signal_stop, signal_print, signal_program)
9635         (signal_catch, signal_pass): Now arrays instead of pointers.
9636         (update_signals_program_target, do_target_resume)
9637         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9638         * linux-nat.c (linux_nat_target::pass_signals)
9639         (linux_nat_target::create_inferior, linux_nat_target::attach):
9640         Adjust.
9641         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9642         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9643         * procfs.c (procfs_target::pass_signals): Adjust.
9644         * record-full.c (record_full_target::resume): Adjust.
9645         * remote.c (remote_target::pass_signals)
9646         (remote_target::program_signals): Adjust.
9647         * target-debug.h (target_debug_print_signals): Now takes a
9648         gdb::array_view as parameter.  Adjust.
9649         * target.h (target_ops) <pass_signals, program_signals>: Replace
9650         pointer and length parameters with gdb::array_view.
9651         (target_pass_signals, target_program_signals): Likewise.
9652         * target-delegates.c: Regenerate.
9653
9654 2019-01-24  Pedro Alves  <palves@redhat.com>
9655
9656         * common/forward-scope-exit.h
9657         (forward_scope_exit::forward_scope_exit): Pass arguments to
9658         m_bind_function directly, instead of creating a std::bind and
9659         copying that.
9660
9661 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9662
9663         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9664         for static members.
9665         (pass_in_v_vfp_candidate): Likewise.
9666
9667 2019-01-23  Tom Tromey  <tom@tromey.com>
9668             Pedro Alves  <palves@redhat.com>
9669
9670         * regcache.c (class regcache_invalidator): Remove.
9671         (regcache::raw_write): Use make_scope_exit.
9672
9673 2019-01-23  Tom Tromey  <tom@tromey.com>
9674
9675         * ui-out.h (class ui_out_emit_type): Update comment.
9676
9677 2019-01-23  Tom Tromey  <tom@tromey.com>
9678
9679         * infrun.c (fetch_inferior_event): Update comment.
9680
9681 2019-01-23  Tom Tromey  <tom@tromey.com>
9682             Pedro Alves  <palves@redhat.com>
9683
9684         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9685         parameter.
9686         (fetch_inferior_event): Use SCOPE_EXIT.
9687
9688
9689 2019-01-23  Tom Tromey  <tom@tromey.com>
9690             Pedro Alves  <palves@redhat.com>
9691
9692         * infrun.c (disable_thread_events): Delete.
9693         (stop_all_threads): Use SCOPE_EXIT.
9694
9695 2019-01-23  Tom Tromey  <tom@tromey.com>
9696             Pedro Alves  <palves@redhat.com>
9697
9698         * symfile.c: Include forward-scope-exit.h.
9699         (clear_symtab_users_cleanup): Replace forward declaration with
9700         a FORWARD_SCOPE_EXIT.
9701         (syms_from_objfile_1): Use the forward_scope_exit and
9702         gdb::optional instead of cleanup_function.
9703         (reread_symbols): Use the forward_scope_exit instead of
9704         cleanup_function.
9705         (clear_symtab_users_cleanup): Remove function.
9706
9707 2019-01-23  Tom Tromey  <tom@tromey.com>
9708             Pedro Alves  <palves@redhat.com>
9709
9710         * linux-nat.c: Include scope-exit.h.
9711         (cleanup_target_stop): Remove.
9712         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9713         SCOPE_EXIT.
9714
9715 2019-01-23  Tom Tromey  <tom@tromey.com>
9716             Pedro Alves  <palves@redhat.com>
9717
9718         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9719         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9720
9721 2019-01-23  Tom Tromey  <tom@tromey.com>
9722             Andrew Burgess  <andrew.burgess@embecosm.com>
9723             Pedro Alves  <palves@redhat.com>
9724
9725         * infrun.c (fetch_inferior_event): Use scope_exit.
9726         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9727         * top.c (execute_command): Use scope_exit.
9728         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9729         * utils.c (do_bpstat_clear_actions_cleanup)
9730         (make_bpstat_clear_actions_cleanup): Remove.
9731
9732 2019-01-23  Tom Tromey  <tom@tromey.com>
9733             Pedro Alves  <palves@redhat.com>
9734
9735         * infrun.c: Include "common/scope-exit.h"
9736         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9737         (wait_for_inferior): Use SCOPE_EXIT.
9738         (fetch_inferior_event): Use scope_exit.
9739
9740 2019-01-23  Tom Tromey  <tom@tromey.com>
9741             Pedro Alves  <palves@redhat.com>
9742
9743         * breakpoint.c (create_breakpoint): Remove cleanup.
9744
9745 2019-01-23  Tom Tromey  <tom@tromey.com>
9746             Andrew Burgess  <andrew.burgess@embecosm.com>
9747             Pedro Alves  <palves@redhat.com>
9748
9749 2019-01-23  Pedro Alves  <palves@redhat.com>
9750
9751         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9752
9753 2019-01-23  Pedro Alves  <palves@redhat.com>
9754             Andrew Burgess  <andrew.burgess@embecosm.com>
9755
9756         * gdbthread.h: Include "common/forward-scope-exit.h".
9757         (scoped_finish_thread_state): Redefine custom class in terms of
9758         forward_scope_exit.
9759
9760 2019-01-23  Pedro Alves  <palves@redhat.com>
9761             Andrew Burgess  <andrew.burgess@embecosm.com>
9762
9763         * common/forward-scope-exit.h: New file.
9764
9765 2019-01-23  Pedro Alves  <palves@redhat.com>
9766             Andrew Burgess  <andrew.burgess@embecosm.com>
9767             Tom Tromey  <tom@tromey.com>
9768
9769         * common/scope-exit.h: New file.
9770
9771 2019-01-23  Pedro Alves  <palves@redhat.com>
9772
9773         * common/preprocessor.h (ESC): Rename to ...
9774         (ESC_PARENS): ... this.
9775         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9776         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9777
9778 2019-01-23  Tom Tromey  <tom@tromey.com>
9779
9780         * language.h (class scoped_switch_to_sym_language_if_auto):
9781         Initialize m_lang in both cases.
9782
9783 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9784
9785         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9786         with XCNEW.
9787
9788 2019-01-22  Tom Tromey  <tom@tromey.com>
9789
9790         * corelow.c: Do not include sys/file.h.
9791
9792 2019-01-22  Tom Tromey  <tom@tromey.com>
9793
9794         * tui/tui-wingeneral.h: Include gdb_curses.h.
9795
9796 2019-01-22  Tom Tromey  <tom@tromey.com>
9797
9798         * source-cache.h (class source_cache) <get_source_lines,
9799         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9800
9801 2019-01-22  Tom Tromey  <tom@tromey.com>
9802
9803         * remote-fileio.h (struct remote_target): Declare.
9804
9805 2019-01-22  Tom Tromey  <tom@tromey.com>
9806
9807         * python/py-arch.c: Do not include py-ref.h.
9808         * python/py-bpevent.c: Do not include py-ref.h.
9809         * python/py-cmd.c: Do not include py-ref.h.
9810         * python/py-continueevent.c: Do not include py-ref.h.
9811         * python/py-event.h: Do not include py-ref.h.
9812         * python/py-evtregistry.c: Do not include py-ref.h.
9813         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9814         * python/py-frame.c: Do not include py-ref.h.
9815         * python/py-framefilter.c: Do not include py-ref.h.
9816         * python/py-function.c: Do not include py-ref.h.
9817         * python/py-infevents.c: Do not include py-ref.h.
9818         * python/py-linetable.c: Do not include py-ref.h.
9819         * python/py-objfile.c: Do not include py-ref.h.
9820         * python/py-param.c: Do not include py-ref.h.
9821         * python/py-prettyprint.c: Do not include py-ref.h.
9822         * python/py-progspace.c: Do not include py-ref.h.
9823         * python/py-symbol.c: Do not include py-ref.h.
9824         * python/py-symtab.c: Do not include py-ref.h.
9825         * python/py-type.c: Do not include py-ref.h.
9826         * python/py-unwind.c: Do not include py-ref.h.
9827         * python/py-utils.c: Do not include py-ref.h.
9828         * python/py-value.c: Do not include py-ref.h.
9829         * python/py-varobj.c: Do not include py-ref.h.
9830         * python/py-xmethods.c: Do not include py-ref.h.
9831         * python/python.c: Do not include py-ref.h.
9832         * varobj.c: Do not include py-ref.h.
9833
9834 2019-01-22  Tom Tromey  <tom@tromey.com>
9835
9836         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9837         keyword for bcache.
9838
9839 2019-01-22  Tom Tromey  <tom@tromey.com>
9840
9841         * compile/compile-cplus-types.c: Remove a comment by #include.
9842
9843 2019-01-22  Tom Tromey  <tom@tromey.com>
9844
9845         * compile/gcc-c-plugin.h: Include compile-internal.h.
9846
9847 2019-01-22  Tom Tromey  <tom@tromey.com>
9848
9849         * stabsread.c (EXTERN): Do not define.
9850         (symnum, next_symbol_text_func, processing_gcc_compilation)
9851         (within_function, global_sym_chain, global_stabs)
9852         (previous_stab_code, this_object_header_files)
9853         (n_this_object_header_files)
9854         (n_allocated_this_object_header_files): Define.
9855         * stabsread.h (EXTERN): Never define.  Use "extern".
9856
9857 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9858
9859         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9860         history_value.
9861
9862 2019-01-21  Tom Tromey  <tom@tromey.com>
9863
9864         * ui-out.c: Fix includes.
9865         * tui/tui-source.c: Fix includes.
9866         * target.c: Fix includes.
9867         * remote.c: Fix includes.
9868         * regcache.c: Fix includes.
9869         * python/py-block.c: Fix includes.
9870         * printcmd.c: Fix includes.
9871         * or1k-tdep.c: Fix includes.
9872         * mi/mi-main.c: Fix includes.
9873         * m32r-tdep.c: Fix includes.
9874         * csky-tdep.c: Fix includes.
9875         * compile/compile-cplus-types.c: Fix includes.
9876         * cli/cli-interp.c: Fix includes.
9877
9878 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9879
9880         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9881         for padding.
9882
9883 2019-01-16  Tom Tromey  <tom@tromey.com>
9884
9885         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9886         earlier.
9887         (struct objfile) <msymbols_range>: Move from top level.
9888         <msymbols>: New method.
9889         (class objfile_msymbols): Remove.
9890         * symtab.c (default_collect_symbol_completion_matches_break_on):
9891         Update.
9892         * symmisc.c (dump_msymbols): Update.
9893         * stabsread.c (scan_file_globals): Update.
9894         * objc-lang.c (info_selectors_command, info_classes_command)
9895         (find_methods): Update.
9896         * minsyms.c (find_solib_trampoline_target): Update.
9897         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9898         * coffread.c (coff_symfile_read): Update.
9899         * ada-lang.c (ada_lookup_simple_minsym)
9900         (ada_collect_symbol_completion_matches): Update.
9901
9902 2019-01-16  Tom Tromey  <tom@tromey.com>
9903
9904         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9905         type.  Remove no-argument constructor.
9906         <iterator::operator++>: Simplify.
9907         <begin>: Update.
9908         <end>: Use minimal_symbol_count.
9909
9910 2019-01-16  Tom Tromey  <tom@tromey.com>
9911
9912         * objfiles.h (struct objfile) <psymtabs>: New method.
9913         (class objfile_psymtabs): Remove.
9914         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9915         typedef.
9916         <range>: New method.
9917         (require_partial_symbols): Change return type.
9918         * psymtab.c (require_partial_symbols)
9919         (psym_expand_symtabs_matching): Update.
9920         * mdebugread.c (parse_partial_symbols): Update.
9921         * dbxread.c (dbx_end_psymtab): Update.
9922
9923 2019-01-15  Tom Tromey  <tom@tromey.com>
9924
9925         * symtab.c (lookup_objfile_from_block)
9926         (lookup_symbol_in_objfile_symtabs)
9927         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9928         (find_line_symtab, info_sources_command)
9929         (default_collect_symbol_completion_matches_break_on)
9930         (make_source_files_completion_list): Update.
9931         * symmisc.c (print_objfile_statistics, dump_objfile)
9932         (maintenance_print_symbols, maintenance_info_symtabs)
9933         (maintenance_check_symtabs, maintenance_info_line_tables):
9934         Update.
9935         * source.c (select_source_symtab)
9936         (forget_cached_source_info_for_objfile): Update.
9937         * objfiles.h (class objfile_compunits): Remove.
9938         (struct objfile) <compunits_range>: New typedef.
9939         (compunits): New method.
9940         * objfiles.c (objfile_relocate1): Update.
9941         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9942         * maint.c (count_symtabs_and_blocks): Update.
9943         * linespec.c (iterate_over_all_matching_symtabs): Update.
9944         * cp-support.c (add_symbol_overload_list_qualified): Update.
9945         * coffread.c (coff_symtab_read): Update.
9946         * ada-lang.c (add_nonlocal_symbols)
9947         (ada_collect_symbol_completion_matches)
9948         (ada_add_global_exceptions): Update.
9949
9950 2019-01-15  Tom Tromey  <tom@tromey.com>
9951
9952         * progspace.h (program_space) <objfiles_safe_range>: New
9953         typedef.
9954         <objfiles_safe>: New method.
9955         * objfiles.h (class all_objfiles_safe): Remove.
9956         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9957         * jit.c (jit_inferior_exit_hook): Update.
9958
9959 2019-01-17  Tom Tromey  <tom@tromey.com>
9960
9961         * progspace.h (program_space) <objfiles_range>: New typedef.
9962         <objfiles>: New method.
9963         <objfiles_head>: Rename from objfiles.
9964         (object_files): Update.
9965         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9966         * guile/scm-pretty-print.c
9967         (ppscm_find_pretty_printer_from_objfiles): Update.
9968         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9969         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9970         Update.
9971         * python/py-progspace.c (pspy_get_objfiles): Update.
9972         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9973         Update.
9974         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9975         (objfpy_lookup_objfile_by_build_id): Update.
9976         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9977         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9978         Update.
9979         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9980         (expand_symtab_containing_pc, lookup_objfile_from_block)
9981         (lookup_static_symbol, basic_lookup_transparent_type)
9982         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9983         (find_line_symtab, info_sources_command)
9984         (default_collect_symbol_completion_matches_break_on)
9985         (make_source_files_completion_list, find_main_name): Update.
9986         * symmisc.c (print_symbol_bcache_statistics)
9987         (print_objfile_statistics, maintenance_print_symbols)
9988         (maintenance_print_msymbols, maintenance_print_objfiles)
9989         (maintenance_info_symtabs, maintenance_check_symtabs)
9990         (maintenance_expand_symtabs, maintenance_info_line_tables):
9991         Update.
9992         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9993         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9994         (map_overlay_command, unmap_overlay_command)
9995         (simple_overlay_update, expand_symtabs_matching)
9996         (map_symbol_filenames): Update.
9997         * symfile-debug.c (set_debug_symfile): Update.
9998         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9999         Update.
10000         * source.c (select_source_symtab, forget_cached_source_info):
10001         Update.
10002         * solib.c (solib_read_symbols): Update.
10003         * solib-spu.c (append_ocl_sos): Update.
10004         * psymtab.c (maintenance_print_psymbols)
10005         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10006         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10007         * printcmd.c (info_symbol_command): Update.
10008         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10009         Update.
10010         * objfiles.h (class all_objfiles): Remove.
10011         * objfiles.c (have_partial_symbols, have_full_symbols)
10012         (have_minimal_symbols, qsort_cmp, update_section_map)
10013         (shared_objfile_contains_address_p)
10014         (default_iterate_over_objfiles_in_search_order): Update.
10015         * objc-lang.c (info_selectors_command, info_classes_command)
10016         (find_methods): Update.
10017         * minsyms.c (find_solib_trampoline_target): Update.
10018         * maint.c (maintenance_info_sections)
10019         (maintenance_translate_address, count_symtabs_and_blocks):
10020         Update.
10021         * main.c (captured_main_1): Update.
10022         * linux-thread-db.c (try_thread_db_load_from_pdir)
10023         (has_libpthread): Update.
10024         * linespec.c (iterate_over_all_matching_symtabs)
10025         (search_minsyms_for_name): Update.
10026         * jit.c (jit_find_objf_with_entry_addr): Update.
10027         * hppa-tdep.c (find_unwind_entry)
10028         (hppa_lookup_stub_minimal_symbol): Update.
10029         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10030         Update.
10031         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10032         (elf_gnu_ifunc_resolve_by_got): Update.
10033         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10034         * dwarf-index-write.c (save_gdb_index_command): Update.
10035         * cp-support.c (add_symbol_overload_list_qualified): Update.
10036         * breakpoint.c (create_overlay_event_breakpoint)
10037         (create_longjmp_master_breakpoint)
10038         (create_std_terminate_master_breakpoint)
10039         (create_exception_master_breakpoint): Update.
10040         * blockframe.c (find_pc_partial_function): Update.
10041         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10042         (ada_collect_symbol_completion_matches)
10043         (ada_add_global_exceptions): Update.
10044
10045 2019-01-17  Tom Tromey  <tom@tromey.com>
10046
10047         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10048         declare VEC.
10049         (solib_target_parse_libraries): Change return type.
10050         (library_list_start_segment, library_list_start_section)
10051         (library_list_end_library, library_list_start_library); Update.
10052         (solib_target_free_library_list): Remove.
10053         (solib_target_parse_libraries): Remove cleanup.  Change return
10054         type.
10055         (solib_target_current_sos): Update.
10056
10057 2019-01-17  Tom Tromey  <tromey@bapiya>
10058
10059         * valprint.c: Replace "the the" with "the".
10060         * symtab.c: Replace "the the" with "the".
10061         * solib.c: Replace "the the" with "the".
10062         * solib-dsbt.c: Replace "the the" with "the".
10063         * linespec.c: Replace "the the" with "the".
10064         * dwarf2loc.h: Replace "the the" with "the".
10065         * amd64-windows-tdep.c: Replace "the the" with "the".
10066         * aarch64-tdep.c: Replace "the the" with "the".
10067
10068 2019-01-16  Keith Seitz  <keiths@redhat.com>
10069
10070         PR gdb/23773
10071         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10072         <builder>: Rename to ..
10073         <m_builder>: ... this and make private.
10074         (dwarf2_cu::get_builder): New method.  Change all users of
10075         `builder' to use this method.
10076         (dwarf2_start_symtab): Move to ...
10077         (dwarf2_cu::start_symtab): ... here.  Update all callers
10078         (setup_type_unit_groups): Move to ...
10079         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10080         callers.
10081         (dwarf2_cu::reset_builder): New method.
10082         (process_full_compunit, process_full_type_unit): Use
10083         dwarf2_cu::reset_builder.
10084         (follow_die_offset): Record the ancestor CU if it is different
10085         from the followed DIE's CU.
10086         (follow_die_sig_1): Likewise.
10087
10088 2019-01-15  Tom Tromey  <tom@tromey.com>
10089
10090         * remote.c (class remote_state) <buf>: Now a char_vector.
10091         <buf_size>: Remove.
10092         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10093         parameter.
10094         (remote_target::getpkt_or_notif_sane_1)
10095         (remote_target::getpkt_sane)
10096         (remote_target::getpkt_or_notif_sane): Likewise.
10097         (class remote_target) <putpkt>: New overload.
10098         (remote_target::read_frame): Change type of "buf_p".  Remove
10099         sizeof_p parameter.
10100         (packet_ok): New overload.
10101         (packet_check_result): New overload.
10102         Update all uses.
10103
10104 2019-01-14  Tom Tromey  <tom@tromey.com>
10105
10106         * remote-notif.c (handle_notification, remote_notif_ack)
10107         (remote_notif_parse): Make "buf" const.
10108         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10109         const.
10110         (remote_notif_parse, remote_notif_ack, handle_notification):
10111         Likewise.
10112         * remote.c (remote_notif_stop_parse): Make "buf" const.
10113         (remote_target::remote_parse_stop_reply): Make "buf" const.
10114         (remote_notif_stop_ack): Make "buf" const.
10115
10116 2019-01-14  Tom Tromey  <tom@tromey.com>
10117
10118         * remote.c (remote_console_output): Make parameter const.
10119
10120 2019-01-14  Tom Tromey  <tom@tromey.com>
10121
10122         * target-debug.h (target_debug_print_signals): Constify.
10123         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10124         * procfs.c (procfs_target::pass_signals): Update.
10125         * linux-nat.c (linux_nat_target::pass_signals): Update.
10126         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10127         * target-delegates.c: Rebuild.
10128         * remote.c (remote_target::program_signals): Update.
10129         (remote_target::pass_signals): Update.
10130         * target.c (target_pass_signals): Constify argument.
10131         (target_program_signals): Likewise.
10132         * target.h (struct target_ops) <pass_signals, program_signals>:
10133         Constify argument.
10134         (target_pass_signals, target_program_signals): Constify argument.
10135
10136 2019-01-14  Tom Tromey  <tom@tromey.com>
10137
10138         PR tui/28819:
10139         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10140
10141 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10142
10143         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10144         field.
10145         * rs6000-tdep.c: Include reggroups.h.
10146         (IS_V_ALIAS_PSEUDOREG): Define.
10147         (rs6000_register_name): Return names for the "vX" aliases.
10148         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10149         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10150         aliases.  Call default_register_reggroup_p for all other
10151         pseudo-registers.
10152         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10153         New functions.
10154         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10155         Handle "vX" aliases.
10156         (v_alias_pseudo_register_collect): New function.
10157         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10158         (rs6000_gdbarch_init): Initialize "vX" aliases as
10159         pseudo-registers.  Restore registration of
10160         rs6000_pseudo_register_reggroup_p with
10161         set_tdesc_pseudo_register_reggroup_p.
10162
10163 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10164
10165         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10166         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10167         set_gdbarch_num_pseudo_regs.
10168
10169 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10170
10171         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10172         Remove arg prefixname, add do_set and do_show.
10173         Add member functions set_list and show_list.
10174         * cli/cli-style.c (class cli_style_option): Update accordingly.
10175         (style_set_list): Move to file scope.
10176         (style_show_list): Likewise.
10177         (set_style): Call help_list.
10178         (show_style): Call cmd_show_list.
10179         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10180         Update to use the new macro.
10181
10182 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10183
10184         * ada-lang.c (_initialize_ada_language): Expand the help text
10185         for the "catch exception" command.
10186
10187 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10188
10189         * symtab.c (matching_obj_sections): Initialize obj,
10190         declare it closer to its usage.
10191
10192 2019-01-10  Tom Tromey  <tom@tromey.com>
10193
10194         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10195         (basic_inf_threads_range): Remove.
10196         (inf_threads_range, inf_non_exited_threads_range)
10197         (safe_inf_threads_range): Use next_adapter.
10198
10199 2019-01-10  Keith Seitz  <keiths@redhat.com>
10200
10201         PR gdb/23712
10202         PR symtab/23010
10203         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10204         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10205
10206 2019-01-10  Keith Seitz  <keiths@redhat.com>
10207
10208         PR gdb/23712
10209         PR symtab/23010
10210         * dictionary.c (pending_to_vector): Remove.
10211         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10212         Remove _1 suffix, replacing functions of the same name.  Update
10213         all callers.
10214         (dict_create_hashed, dict_create_hashed_expandable)
10215         (dict_create_linear, dict_create_linear_expandable, dict_free)
10216         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10217         Make functions static.
10218
10219 2019-01-10  Keith Seitz  <keiths@redhat.com>
10220
10221         PR gdb/23712
10222         PR symtab/23010
10223         * dictionary.h (struct dictionary): Replace declaration with
10224         multidictionary.
10225         (dict_create_hashed, dict_create_hashed_expandable)
10226         (dict_create_linear, dict_create_linear_expandable)
10227         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10228         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10229         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10230         taking multidictionary argument.
10231         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10232         * block.h (struct block) <dict>: Change to multidictionary
10233         and rename `multidict'.
10234         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10235         symmisc.c: Update all dictionary references to multidictionary.
10236
10237 2019-01-10  Keith Seitz  <keiths@redhat.com>
10238
10239         PR gdb/23712
10240         PR symtab/23010
10241         * dictionary.c: Include unordered_map.
10242         (pending_to_vector): New function.
10243         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10244         Rewrite the non-"_1" functions to take vector instead
10245         of linked list.
10246         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10247         "new" _1 versions of the same name.
10248         (multidictionary): Define.
10249         (std::hash<enum language): New definition.
10250         (collate_pending_symbols_by_language, mdict_create_hashed)
10251         (mdict_create_hashed_expandable, mdict_create_linear)
10252         (mdict_create_linear_expandable, mdict_free)
10253         (find_language_dictionary, create_new_language_dictionary)
10254         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10255         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10256         (mdict_size, mdict_empty): New functions.
10257         * dictionary.h (mdict_iterator): Define.
10258
10259 2019-01-10  Pedro Alves  <palves@redhat.com>
10260
10261         * breakpoint.c (read_uploaded_action)
10262         (create_tracepoint_from_upload): Adjust to use
10263         gdb::unique_xmalloc_ptr.
10264         * ctf.c (ctf_write_uploaded_tp):
10265         (SET_ARRAY_FIELD): Use emplace_back.
10266         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10267         * tracefile-tfile.c (tfile_write_uploaded_tp):
10268         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10269         gdb::unique_xmalloc_ptr.
10270         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10271         at_string, cond_string, cmd_strings>: Replace char pointers
10272         with gdb::unique_xmalloc_ptr.
10273
10274 2019-01-10  Pedro Alves  <palves@redhat.com>
10275
10276         * solib-target.c (library_list_start_library): Don't xstrdup name.
10277
10278 2019-01-10  Pedro Alves  <palves@redhat.com>
10279
10280         * mdebugread.c (parse_partial_symbols): Use
10281         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10282
10283 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10284
10285         * linux-fork.c (scoped_switch_fork_info)
10286         <~scoped_switch_fork_info>: Fix incorrect variable name.
10287
10288 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10289
10290         * linux-fork.c (scoped_switch_fork_info)
10291         <scoped_switch_fork_info>: Make explicit.
10292         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10293
10294 2019-01-10  Tom Tromey  <tom@tromey.com>
10295
10296         * objfiles.h (objfile::reset_psymtabs): Update.
10297         * objfiles.c (objfile::objfile): Update.
10298         * psymtab.h (psymtab_storage::obstack): Update.
10299         (psymtab_storage::m_obstack): Use gdb::optional.
10300         (class psymtab_storage): Update comment.  Remove objfile
10301         parameter.
10302         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10303
10304 2019-01-10  Tom Tromey  <tom@tromey.com>
10305
10306         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10307         <free_psymtabs>: Now private.
10308         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10309         (allocate_psymtab): Use new method.
10310
10311 2019-01-10  Tom Tromey  <tom@tromey.com>
10312
10313         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10314         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10315         * mdebugread.c (parse_partial_symbols): Use
10316         allocate_dependencies.
10317         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10318         allocate_dependencies.
10319         (process_psymtab_comp_unit_reader)
10320         (build_type_psymtab_dependencies): Likewise.
10321         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10322
10323 2019-01-10  Tom Tromey  <tom@tromey.com>
10324
10325         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10326         PSYMBOL_SET_LANGUAGE.
10327         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10328
10329 2019-01-10  Tom Tromey  <tom@tromey.com>
10330
10331         * psymtab.h (psymtab_storage::obstack): New method.
10332         <m_obstack>: Rename from obstack; now private.
10333         * psymtab.c (psymtab_storage): Update.
10334         * dwarf2read.c (create_addrmap_from_index)
10335         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10336         Update.
10337
10338 2019-01-10  Tom Tromey  <tom@tromey.com>
10339
10340         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10341         * objfiles.h (objfile::reset_psymtabs): New method.
10342
10343 2019-01-10  Tom Tromey  <tom@tromey.com>
10344
10345         * symmisc.c (print_symbol_bcache_statistics): Update.
10346         (print_objfile_statistics): Update.
10347         * symfile.c (reread_symbols): Update.
10348         * psymtab.h (class psymtab_storage): New.
10349         * psymtab.c (psymtab_storage): New constructor.
10350         (~psymtab_storage): New destructor.
10351         (require_partial_symbols): Update.
10352         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10353         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10354         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10355         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10356         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10357         (start_psymtab_common, end_psymtab_common)
10358         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10359         (allocate_psymtab): Update.
10360         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10361         Update.
10362         (dump_psymtab_addrmap, maintenance_print_psymbols)
10363         (maintenance_check_psymtabs): Update.
10364         (class objfile_psymtabs): Move to objfiles.h.
10365         * psympriv.h (discard_psymtab): Now inline.
10366         (psymtab_discarder::psymtab_discarder): Update.
10367         (psymtab_discarder::~psymtab_discarder): Update.
10368         (ALL_OBJFILE_PSYMTABS): Rewrite.
10369         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10370         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10371         Remove fields.
10372         <partial_symtabs>: New field.
10373         (class objfile_psymtabs): Move from psymtab.h.  Update.
10374         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10375         psymbol_cache.
10376         (objfile::~objfile): Don't destroy psymbol_cache.
10377         * mdebugread.c (parse_partial_symbols): Update.
10378         * dwarf2read.c (create_addrmap_from_index)
10379         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10380         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10381         (add_partial_subprogram, dwarf2_ranges_read): Update.
10382         * dwarf-index-write.c (write_address_map)
10383         (write_one_signatured_type, recursively_write_psymbols)
10384         (class debug_names, class debug_names, write_psymtabs_to_index):
10385         Update.
10386
10387 2019-01-10  Tom Tromey  <tom@tromey.com>
10388
10389         * symtab.h (SYMBOL_SET_NAMES): Update.
10390         (symbol_set_names): Update.
10391         (MSYMBOL_SET_NAMES): Update.
10392         * symtab.c (symbol_set_names): Change argument to be an
10393         objfile_per_bfd_storage.
10394         * psymtab.c (add_psymbol_to_bcache): Update.
10395         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10396
10397 2019-01-10  Tom Tromey  <tom@tromey.com>
10398
10399         * symtab.c (create_demangled_names_hash): Change argument to be an
10400         objfile_per_bfd_storage.
10401         (symbol_set_names): Update.
10402
10403 2019-01-10  Tom Tromey  <tom@tromey.com>
10404
10405         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10406         init_psymbol_list.
10407         * psymtab.c (init_psymbol_list): Do nothing if already called.
10408         * psympriv.h (init_psymbol_list): Add comment.
10409         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10410         init_psymbol_list.
10411         * dbxread.c (dbx_symfile_read): Unconditionally call
10412         init_psymbol_list.
10413
10414 2019-01-10  Tom Tromey  <tom@tromey.com>
10415
10416         * xcoffread.c (scan_xcoff_symtab): Update.
10417         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10418         "where".
10419         * mdebugread.c (parse_partial_symbols)
10420         (handle_psymbol_enumerators): Update.
10421         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10422         * dbxread.c (read_dbx_symtab): Update.
10423         * psympriv.h (psymbol_placement): New enum.
10424         (add_psymbol_to_list): Update.
10425
10426 2019-01-10  Tom Tromey  <tom@tromey.com>
10427
10428         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10429         static_psymbols parameters.
10430         (scan_xcoff_symtab): Update.
10431         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10432         static_psymbols parameters.
10433         * psympriv.h (start_psymtab_common): Update.
10434         * mdebugread.c (parse_partial_symbols): Update.
10435         * dwarf2read.c (create_partial_symtab): Update.
10436         * dbxread.c (read_dbx_symtab): Update.
10437         (start_psymtab): Remove global_psymbols and static_psymbols
10438         parameters.
10439
10440 2019-01-10  Tom Tromey  <tom@tromey.com>
10441
10442         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10443         * psymtab.c (allocate_psymtab): Add comment.
10444         * psympriv.h (allocate_psymtab): Add comment.
10445         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10446         initializations.
10447         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10448
10449 2019-01-10  Tom Tromey  <tom@tromey.com>
10450
10451         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10452         Don't declare.
10453         * mipsread.c: Include mdebugread.h.
10454         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10455         Declare.
10456         * elfread.c: Include mdebugread.h.
10457
10458 2019-01-09  Tom Tromey  <tom@tromey.com>
10459
10460         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10461         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10462         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10463         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10464         (psym_lookup_symbol, psym_find_last_source_symtab)
10465         (psym_forget_cached_source_info, psym_print_stats)
10466         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10467         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10468         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10469         (psym_find_compunit_symtab_by_address)
10470         (maintenance_print_psymbols, maintenance_info_psymtabs)
10471         (maintenance_check_psymtabs): Use ranged for.
10472         * psymtab.h (class objfile_psymtabs): New.
10473         (require_partial_symbols): Return objfile_psymtabs.
10474         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10475
10476 2019-01-09  Tom Tromey  <tom@tromey.com>
10477
10478         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10479         (find_pc_mapped_section, list_overlays_command)
10480         (map_overlay_command, unmap_overlay_command)
10481         (simple_overlay_update): Use all_objfiles.
10482         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10483         * printcmd.c (info_symbol_command): Use all_objfiles.
10484         * objfiles.h (ALL_OBJSECTIONS): Remove.
10485         * maint.c (maintenance_translate_address): Use all_objfiles.
10486         * gcore.c (gcore_create_callback): Use all_objfiles.
10487         (objfile_find_memory_regions): Likewise.
10488
10489 2019-01-09  Tom Tromey  <tom@tromey.com>
10490
10491         * symtab.c (find_line_symtab, info_sources_command)
10492         (make_source_files_completion_list): Use objfile_compunits.
10493         * source.c (select_source_symtab): Use objfile_compunits.
10494         * objfiles.h (struct objfile): Update comment.
10495         (ALL_OBJFILES): Remove.
10496         (ALL_FILETABS): Remove.
10497         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10498         objfile_compunits.
10499
10500 2019-01-09  Tom Tromey  <tom@tromey.com>
10501
10502         * symmisc.c (print_objfile_statistics, dump_objfile)
10503         (maintenance_print_symbols): Use compunit_filetabs.
10504         * source.c (forget_cached_source_info_for_objfile): Use
10505         compunit_filetabs.
10506         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10507         (ALL_FILETABS): Use compunit_filetabs.
10508         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10509         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10510
10511 2019-01-09  Tom Tromey  <tom@tromey.com>
10512
10513         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10514         (compunit_filetabs): New.
10515         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10516         compunit_filetabs.
10517         (info_sources_command, make_source_files_completion_list): Remove
10518         declaration.
10519         * symmisc.c (print_objfile_statistics, dump_objfile)
10520         (maintenance_print_symbols): Remove declaration.
10521         (maintenance_info_symtabs): Use compunit_filetabs.
10522         (maintenance_info_line_tables): Likewise.
10523         * source.c (select_source_symtab): Change local variable name.
10524         (forget_cached_source_info_for_objfile): Remove declaration.
10525         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10526         * objfiles.c (objfile_relocate1): Remove declaration.
10527         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10528         declaration.
10529         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10530         * coffread.c (coff_symtab_read): Remove declaration.
10531         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10532         compunit_filetabs.
10533
10534 2019-01-09  Tom Tromey  <tom@tromey.com>
10535
10536         * symtab.c (lookup_objfile_from_block)
10537         (find_pc_sect_compunit_symtab, search_symbols)
10538         (default_collect_symbol_completion_matches_break_on): Use
10539         objfile_compunits.
10540         * objfiles.h (ALL_COMPUNITS): Remove.
10541         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10542         * cp-support.c (add_symbol_overload_list_qualified): Use
10543         objfile_compunits.
10544         * ada-lang.c (ada_collect_symbol_completion_matches)
10545         (ada_add_global_exceptions): Use objfile_compunits.
10546
10547 2019-01-09  Tom Tromey  <tom@tromey.com>
10548
10549         * source.c (select_source_symtab)
10550         (forget_cached_source_info_for_objfile): Remove declaration.
10551         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10552         declaration.
10553         * maint.c (count_symtabs_and_blocks): Remove declaration.
10554         * cp-support.c (add_symbol_overload_list_qualified): Remove
10555         declaration.
10556         * coffread.c (coff_symtab_read): Remove declaration.
10557         * symtab.c (lookup_symbol_in_objfile_symtabs)
10558         (basic_lookup_transparent_type_1): Use objfile_compunits.
10559         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10560         (info_sources_command, search_symbols)
10561         (default_collect_symbol_completion_matches_break_on)
10562         (make_source_files_completion_list): Remove declaration.
10563         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10564         (ada_collect_symbol_completion_matches)
10565         (ada_add_global_exceptions): Remove declaration.
10566         * linespec.c (iterate_over_all_matching_symtabs): Use
10567         objfile_compunits.
10568         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10569         (class objfile_compunits): New.
10570         (ALL_COMPUNITS): Use objfile_compunits.
10571         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10572         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10573         objfile_compunits.
10574         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10575
10576 2019-01-09  Tom Tromey  <tom@tromey.com>
10577
10578         * symtab.c (search_symbols)
10579         (default_collect_symbol_completion_matches_break_on): Use
10580         objfile_msymbols.
10581         * ada-lang.c (ada_lookup_simple_minsym)
10582         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10583         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10584         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10585         objfile_msymbols.
10586         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10587         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10588         * objc-lang.c (find_methods): Use objfile_msymbols.
10589         (info_selectors_command, info_classes_command): Likewise.
10590         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10591         * objfiles.h (class objfile_msymbols): New.
10592         (ALL_OBJFILE_MSYMBOLS): Remove.
10593         (ALL_MSYMBOLS): Remove.
10594
10595 2019-01-09  Tom Tromey  <tom@tromey.com>
10596
10597         * common/next-iterator.h (next_adapter): Add Iterator template
10598         parameter.
10599         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10600         (class all_objfiles_safe): New.
10601         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10602         * objfiles.c (put_objfile_before): Update comment.
10603         (add_separate_debug_objfile): Likewise.
10604         (free_all_objfiles): Use all_objfiles_safe.
10605         (objfile_purge_solibs): Likewise.
10606
10607 2019-01-09  Tom Tromey  <tom@tromey.com>
10608
10609         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10610         (expand_symtab_containing_pc, lookup_static_symbol)
10611         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10612         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10613         all_objfiles.
10614         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10615         * breakpoint.c (create_overlay_event_breakpoint)
10616         (create_longjmp_master_breakpoint)
10617         (create_std_terminate_master_breakpoint)
10618         (create_exception_master_breakpoint): Use all_objfiles.
10619         * linux-thread-db.c (try_thread_db_load_from_pdir)
10620         (has_libpthread): Use all_objfiles.
10621         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10622         * linespec.c (iterate_over_all_matching_symtabs)
10623         (search_minsyms_for_name): Use all_objfiles.
10624         * maint.c (maintenance_info_sections): Use all_objfiles.
10625         * main.c (captured_main_1): Use all_objfiles.
10626         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10627         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10628         * guile/scm-pretty-print.c
10629         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10630         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10631         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10632         (maintenance_print_msymbols): Use all_objfiles.
10633         * source.c (select_source_symtab): Use all_objfiles.
10634         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10635         * symfile.c (remove_symbol_file_command)
10636         (expand_symtabs_matching, map_symbol_filenames): Use
10637         all_objfiles.
10638         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10639         all_objfiles.
10640         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10641         * objc-lang.c (find_methods): Use all_objfiles.
10642         * objfiles.c (have_partial_symbols, have_full_symbols)
10643         (have_minimal_symbols, qsort_cmp)
10644         (default_iterate_over_objfiles_in_search_order): Use
10645         all_objfiles.
10646         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10647         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10648         (maintenance_check_psymtabs): Use all_objfiles.
10649         (ALL_PSYMTABS): Remove.
10650         * compile/compile-object-run.c (do_module_cleanup): Use
10651         all_objfiles.
10652         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10653         * cp-support.c (add_symbol_overload_list_qualified): Use
10654         all_objfiles.
10655         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10656         Use all_objfiles.
10657         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10658         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10659         all_objfiles.
10660         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10661         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10662         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10663         Uses all_objfiles.
10664         * solib.c (solib_read_symbols): Use all_objfiles
10665
10666 2019-01-09  Tom Tromey  <tom@tromey.com>
10667
10668         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10669         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10670         all_objfiles.
10671         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10672         * symmisc.c (print_symbol_bcache_statistics)
10673         (print_objfile_statistics, maintenance_print_objfiles)
10674         (maintenance_info_symtabs, maintenance_check_symtabs)
10675         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10676         all_objfiles.
10677         * source.c (forget_cached_source_info): Use all_objfiles.
10678         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10679         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10680         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10681         * objfiles.c (update_section_map): Use all_objfiles.
10682         (shared_objfile_contains_address_p): Likewise.
10683         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10684         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10685
10686 2019-01-09  Tom Tromey  <tom@tromey.com>
10687
10688         * common/next-iterator.h: New file.
10689         * objfiles.h (class all_objfiles): New.
10690         (struct objfile_iterator): New.
10691
10692 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10693
10694         * NEWS: Move the description of the changed "frame", "select-frame",
10695          and "info frame" commands to the Changed commands section.
10696
10697 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10698
10699         * gdbtypes.c (check_stub_method_group): Remove handling of old
10700         mangling schemes.
10701         * linespec.c (find_methods): Likewise.
10702         * stabsread.c (read_member_functions): Likewise.
10703         * valops.c (search_struct_method): Likewise.
10704         (value_struct_elt_for_reference): Likewise.
10705         * NEWS: Mention this change.
10706
10707 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10708
10709         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10710         print_source_lines.
10711         * source.c (print_source_lines_base): Update line number check.
10712         (print_source_lines): New function.
10713         (source_lines_range::source_lines_range): New function.
10714         * source.h (class source_lines_range): New class.
10715         (print_source_lines): New declaration.
10716
10717 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10718
10719         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10720
10721 2019-01-08  Tom Tromey  <tom@tromey.com>
10722             Simon Marchi  <simon.marchi@ericsson.com>
10723
10724         PR gdb/24060
10725         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10726         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10727         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10728         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10729         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10730         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10731
10732 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10733
10734         * source.c (select_source_symtab): Move header comment to
10735         declaration in source.h.
10736         (forget_cached_source_info_for_objfile): Likewise.
10737         (forget_cached_source_info): Likewise.
10738         (identify_source_line): Likewise.
10739         * source.h (identify_source_line): Move declaration from symtab.h
10740         and add comment from source.c
10741         (print_source_lines): Likewise.
10742         (forget_cached_source_info_for_objfile): Likewise.
10743         (forget_cached_source_info): Likewise.
10744         (select_source_symtab): Likewise.
10745         (enum print_source_lines_flag): Move definition from symtab.h.
10746         * symtab.h (identify_source_line): Move declaration to source.h.
10747         (print_source_lines): Likewise.
10748         (forget_cached_source_info_for_objfile): Likewise.
10749         (forget_cached_source_info): Likewise.
10750         (select_source_symtab): Likewise.
10751         (enum print_source_lines_flag): Move definition to source.h.
10752         * tui/tui-hooks.c: Add 'source.h' include.
10753
10754 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10755
10756         * source.c (print_source_lines_base): Handle requests to print
10757         reverse line number sequences, and guard against empty lines
10758         string.
10759
10760 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10761
10762         * source.c (print_source_lines_base): Fix skip of '\r' if next
10763         character is '\n'.
10764
10765 2019-01-06  Tom Tromey  <tom@tromey.com>
10766
10767         * c-exp.y (struct c_parse_state) <macro_original_text,
10768         expansion_obstack>: New member.
10769         (macro_original_text, expansion_obstack): Remove globals.
10770         (scan_macro_expansion, scanning_macro_expansion)
10771         (finished_macro_expansion): Update.
10772         (scan_macro_cleanup): Remove.
10773         (yylex, c_parse): Update.
10774
10775 2019-01-06  Tom Tromey  <tom@tromey.com>
10776
10777         * c-exp.y (struct c_parse_state) <strings>: New member.
10778         (operator_stoken): Update.
10779
10780 2019-01-06  Tom Tromey  <tom@tromey.com>
10781
10782         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10783         (union type_stack_elt) <typelist_val>: Now a pointer to
10784         std::vector.
10785         (type_stack_cleanup): Don't declare.
10786         (push_typelist): Update.
10787         * parse.c (pop_typelist): Return a std::vector.
10788         (push_typelist): Take a std::vector.
10789         (follow_types): Update.  Do not free args.
10790         (type_stack_cleanup): Remove.
10791         * c-exp.y (struct c_parse_state): New.
10792         (cpstate): New global.
10793         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10794         (nonempty_typelist): Update.
10795         (func_mod): Create a new vector.
10796         (c_parse): Create a c_parse_state.
10797         (check_parameter_typelist): Do not delete params.
10798         (function_method): Update.  Do not delete type_list.
10799
10800 2019-01-06  Tom Tromey  <tom@tromey.com>
10801
10802         PR gdb/28155:
10803         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10804         check_typedef.
10805         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10806         (print_return_value): Likewise.
10807
10808 2019-01-05  Tom Tromey  <tom@tromey.com>
10809
10810         * contrib/cleanup_check.py: Remove.
10811         * contrib/gcc-with-excheck: Remove.
10812         * contrib/exsummary.py: Remove.
10813         * contrib/excheck.py: Remove.
10814
10815 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10816
10817         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10818         NULL. Initialize tpprev to NULL instead of assigning it
10819         to NULL on the next statement.
10820         * windows-nat.c (windows_delete_thread): Remove check for
10821         main_thread_id before printing thread exit notifications.
10822         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10823         Remove thread ID check against main_thread_id.
10824         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10825         windows_delete_thread.
10826         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10827
10828 2019-01-04  Tom Tromey  <tom@tromey.com>
10829
10830         * compile/compile.c (_initialize_compile): Use upper case for
10831         metasyntactic variables.
10832         * symmisc.c (_initialize_symmisc): Use upper case for
10833         metasyntactic variables.
10834         * psymtab.c (_initialize_psymtab): Use upper case for
10835         metasyntactic variables.
10836         * demangle.c (demangle_command): Use upper case for metasyntactic
10837         variables.
10838         (_initialize_demangler): Likewise.
10839         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10840         variables.
10841
10842 2019-01-03  Tom Tromey  <tom@tromey.com>
10843
10844         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10845
10846 2019-01-03  Tom Tromey  <tom@tromey.com>
10847
10848         * python/py-symtab.c (salpy_str): Update.
10849         (struct salpy_sal_object) <symtab>: Now a PyObject.
10850         (salpy_dealloc): Update.
10851         (del_objfile_sal): Use gdbpy_ref.
10852
10853 2019-01-03  Tom Tromey  <tom@tromey.com>
10854
10855         * python/py-type.c (convert_field): Use new_reference.  Return
10856         gdbpy_ref.
10857         (make_fielditem): Return gdbpy_ref.
10858         (typy_fields): Update.
10859         (typy_getitem): Update.
10860         (field_name): Return gdbpy_ref.  Use new_reference.
10861         (typy_iterator_iternext): Update.
10862
10863 2019-01-03  Tom Tromey  <tom@tromey.com>
10864
10865         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10866
10867 2019-01-03  Tom Tromey  <tom@tromey.com>
10868
10869         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10870         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10871         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10872         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10873         (pspy_set_type_printers): Likewise.
10874         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10875         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10876         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10877         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10878         (objfpy_set_type_printers): Likewise.
10879
10880 2019-01-03  Tom Tromey  <tom@tromey.com>
10881
10882         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10883         (gdbpy_print_stack): Use gdbpy_err_fetch.
10884         * python/python-internal.h (class gdbpy_err_fetch): New class.
10885         (class gdbpy_enter) <m_error_type, m_error_value,
10886         m_error_traceback>: Remove.
10887         <m_error>: New member.
10888         (gdbpy_exception_to_string): Don't declare.
10889         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10890         * python/py-value.c (convert_value_from_python): Use
10891         gdbpy_err_fetch.
10892         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10893         gdbpy_exception_to_string.
10894         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10895         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10896         gdbpy_err_fetch.
10897
10898 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10899
10900         * linux-nat.c (delete_lwp_cleanup): Delete.
10901         (struct lwp_deleter): New struct.
10902         (lwp_info_up): New typedef.
10903         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10904         lwp_info_up.
10905
10906 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10907
10908         * linux-fork.c (class scoped_switch_fork_info): New class.
10909         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10910
10911 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10912
10913         * valops.c (find_overload_match): Remove use of null_cleanup, and
10914         calls to do_cleanups.
10915
10916 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10917
10918         * compile/compile-cplus-types.c
10919         (compile_cplus_instance::decl_name): Handle changes to
10920         cp_func_name.
10921         * cp-support.c (cp_func_name): Update header comment, update
10922         return type.
10923         * cp-support.h (cp_func_name): Update return type in declaration.
10924         * valops.c (find_overload_match): Move temp_func local to top
10925         level of function and change its type.  Use temp_func to hold and
10926         delete temporary string obtained from cp_func_name.
10927
10928 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10929
10930         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10931         gdb::char_vector, remove cleanup, and update uses of `msg`.
10932
10933 2019-01-03  Jim Wilson  <jimw@sifive.com>
10934
10935         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10936
10937 2019-01-02  Tom Tromey  <tom@tromey.com>
10938
10939         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10940         (tdesc_parse_xml): Remove cleanups.
10941         * target-descriptions.h (make_cleanup_free_target_description):
10942         Don't declare.
10943         (target_desc_deleter): New struct.
10944         (target_desc_up): New typedef.
10945         * target-descriptions.c (target_desc_deleter::operator()): Rename
10946         from free_target_description.
10947         (make_cleanup_free_target_description): Remove.
10948
10949 2019-01-02  Tom Tromey  <tom@tromey.com>
10950
10951         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10952         constructor, destructor.
10953         (linespec_parser): Remove typedef.
10954         (~linespec_parser): Rename from linespec_parser_delete.
10955         (linespec_lex_to_end, linespec_complete_label)
10956         (linespec_complete): Update.
10957         (decode_line_full): Remove cleanups.
10958         (decode_line_1): Update.
10959
10960 2019-01-02  Tom Tromey  <tom@tromey.com>
10961
10962         * python/python-internal.h (inferior_to_inferior_object): Change
10963         return type.
10964         * python/py-exitedevent.c (create_exited_event_object): Update.
10965         * python/py-inferior.c (inferior_to_inferior_object): Return
10966         gdbpy_ref.
10967         (python_new_inferior, python_inferior_deleted)
10968         (thread_to_thread_object, delete_thread_object)
10969         (build_inferior_list, gdbpy_selected_inferior): Update.
10970         * python/py-infthread.c (create_thread_object): Update.  Also fail
10971         if inferior_to_inferior_object fails.
10972
10973 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10974
10975         * inferior.h (class inferior) <displaced_step_state>: New field.
10976         * infrun.h (struct displaced_step_state): Move here from
10977         infrun.c.  Initialize fields, add constructor.
10978         <inf>: Remove field.
10979         <reset>: New method.
10980         * infrun.c (struct displaced_step_inferior_state): Move to
10981         infrun.h.
10982         (displaced_step_inferior_states): Remove.
10983         (get_displaced_stepping_state): Adust.
10984         (displaced_step_in_progress_any_inferior): Adjust.
10985         (displaced_step_in_progress_thread): Adjust.
10986         (displaced_step_in_progress): Adjust.
10987         (add_displaced_stepping_state): Remove.
10988         (get_displaced_step_closure_by_addr): Adjust.
10989         (remove_displaced_stepping_state): Remove.
10990         (infrun_inferior_exit): Call displaced_step_state.reset.
10991         (use_displaced_stepping): Don't check for NULL.
10992         (displaced_step_prepare_throw): Call
10993         get_displaced_stepping_state.
10994         (displaced_step_fixup): Don't check for NULL.
10995         (prepare_for_detach): Don't check for NULL.
10996
10997 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10998
10999         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11000          in case of call that did not complete.
11001
11002 2019-01-02  Andrey Utkin  <autkin@undo.io>
11003
11004         * symfile.c (find_separate_debug_file): Fix search of debug files for
11005         remote debuggee.
11006
11007 2019-01-02  Tom Tromey  <tom@tromey.com>
11008
11009         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11010         indentation.
11011         * python/py-frame.c (frapy_older): Remove cast.
11012         (frapy_newer): Likewise.
11013         * python/py-breakpoint.c (local_setattro): Remove cast.
11014         * python/py-arch.c (archpy_name): Remove local variable.
11015         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11016
11017 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11018
11019         * unittests/basic_string_view/element_access/char/empty.cc:
11020         Fix year range in copyright header.
11021
11022 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11023
11024         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11025         Delete.
11026         <operator==>: Update with for removed field.
11027         <hash>: Likewise.
11028         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11029         <isa_features>: ...this.
11030         <abi_features>: New field.
11031         (riscv_isa_flen): Update comment.
11032         (riscv_abi_xlen): New declaration.
11033         (riscv_abi_flen): New declaration.
11034         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11035         isa_features.
11036         (riscv_abi_xlen): New function.
11037         (riscv_isa_flen): Update to get answer from isa_features.
11038         (riscv_abi_flen): New function.
11039         (riscv_has_fp_abi): Update to get answer from abi_features.
11040         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11041         xlen and flen.
11042         (riscv_call_info) <xlen, flen>: Update comment.
11043         (riscv_call_arg_struct): Remove invalid assertions
11044         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11045         is removed.
11046         (riscv_gdbarch_init): Gather isa features and abi features
11047         separately, ensure both match on the gdbarch when reusing an old
11048         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11049         a target with 64-bit float hardware.
11050
11051 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11052
11053         * source.c (search_command_helper): Stop reverse search
11054         when line 1 has been searched.
11055
11056 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11057
11058         * record-full.c (record_full_base_target::close): Rewrite
11059         record_full_core_buf_list free logic.
11060
11061 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11062
11063         * break-catch-syscall.c (print_one_catch_syscall): xfree
11064         the last text.
11065
11066 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11067
11068         * top.c (print_gdb_version): Update Copyright year in version
11069         message.
11070
11071 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11072
11073         Update copyright year range in all GDB files.
11074
11075 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11076
11077         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11078
11079 For older changes see ChangeLog-2018.
11080 \f
11081 Local Variables:
11082 mode: change-log
11083 left-margin: 8
11084 fill-column: 74
11085 version-control: never
11086 coding: utf-8
11087 End:
11088