gdb/ChangeLog

   1 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * dwarf2read.h (struct dwarf2_section_info) <readin,
   4         is_virtual>: Change type to bool.
   5         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
   6         true instead of 1.
   7
   8 2019-06-19  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-data.h (tui_init_content_element): Don't declare.
  11
  12 2019-06-19  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-data.h (tui_init_win_info): Don't declare.
  15
  16 2019-06-19  Tom de Vries  <tdevries@suse.de>
  17
  18         * dwarf2read.h (abstract_to_concrete): Change type to
  19         std::unordered_map<sect_offset, std::vector<sect_offset>,
  20         gdb::hash_enum<sect_offset>>.
  21
  22 2019-06-19  Tom Tromey  <tromey@adacore.com>
  23
  24         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  25         EVAL_AVOID_SIDE_EFFECTS specially.
  26
  27 2019-06-19  Tom Tromey  <tromey@adacore.com>
  28
  29         * source-cache.c (highlighter): New global.
  30         (source_cache::get_source_lines): Create a highlighter on demand.
  31
  32 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  33
  34         * defs.h (deprecated_interactive_hook): Delete declaration.
  35         * interps.c (clear_interpreter_hooks): Remove use of
  36         deprecated_interactive_hook.
  37         * top.c (deprecated_interactive_hook): Delete definition.
  38         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  39
  40 2019-06-18  Tom de Vries  <tdevries@suse.de>
  41
  42         PR gdb/24515
  43         * dwarf2read.h (abstract_to_concrete): Change type from
  44         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  45         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  46         * dwarf2read.c (read_variable): Update.
  47         (dwarf2_fetch_die_loc_sect_off): Update.
  48
  49 2019-06-17  Tom de Vries  <tdevries@suse.de>
  50
  51         PR gdb/24617
  52         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  53         accessing parent[parent_len - 1].
  54
  55 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  56
  57         PR gdb/24364
  58         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  59         call dtrace_process_dof with NULL dof.
  60
  61 2019-06-16  Tom de Vries  <tdevries@suse.de>
  62
  63         PR gdb/24445
  64         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  65
  66 2019-06-16  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  69         (make_all_visible): Use address of member.
  70
  71 2019-06-16  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  74         (tui_free_window, free_content, free_content_elements): Remove
  75         unnecessary cast.
  76         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  77         cast.
  78         * tui/tui-regs.c (tui_show_register_group)
  79         (tui_display_registers_from, tui_display_reg_element_at_line):
  80         Remove unnecessary cast.
  81
  82 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  83
  84         * linux-nat.c (normal_mask): Delete.
  85         (_initialize_linux_nat): Don't initialise normal_mask.
  86
  87 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  88
  89         PR gdb/24445
  90         * dwarf-index-write.h (write_psymtabs_to_index): Add
  91         dwz_basename parameter.
  92         * dwarf-index-write.c (write_gdbindex): Move file writing to
  93         write_gdbindex_1.  Change return type void.
  94         (assert_file_size): Move up, remove filename parameter.
  95         (write_gdbindex_1): New function.
  96         (write_debug_names): Change return type to void, call
  97         assert_file_size.
  98         (struct index_wip_file): New struct.
  99         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 100         file logic to index_wip_file.  Write index for dwz file if
 101         needed.
 102         (save_gdb_index_command): Pass basename of dwz file, if present.
 103         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 104         build-id of dwz file, if present.
 105         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 106         (dwarf2_get_dwz_file): Likewise.
 107         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 108         (dwarf2_get_dwz_file): Likewise.
 109
 110 2019-06-16  Tom Tromey  <tom@tromey.com>
 111
 112         * coffread.c (process_coff_symbol): Use xstrdup.
 113         * value.c (create_internalvar): Use xstrdup.
 114
 115 2019-06-16  Tom Tromey  <tom@tromey.com>
 116
 117         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 118         * breakpoint.c (stopin_command, stopat_command)
 119         (until_break_command, decode_location_default): Remove unnecessary
 120         cast.
 121         * utils.c (subset_compare): Remove unnecessary cast.
 122         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 123         cast.
 124         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 125         cast.
 126         * infcmd.c (path_command): Remove unnecessary cast.
 127         * coffread.c (decode_type): Remove unnecessary cast.
 128         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 129         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 130         * tui/tui-stack.c (tui_show_locator_content)
 131         (tui_show_frame_info): Remove unnecessary cast.
 132         * tui/tui-win.c (tui_scroll_forward_command)
 133         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 134         (parse_scrolling_args): Remove unnecessary cast.
 135         * tui/tui-data.c (init_win_info, tui_del_window)
 136         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 137         (free_content_elements): Remove unnecessary cast.
 138         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 139         unnecessary cast.
 140         * tui/tui-source.c (tui_set_source_content)
 141         (tui_vertical_source_scroll): Remove unnecessary cast.
 142         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 143         cast.
 144         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 145         * tui/tui-regs.c (tui_display_registers_from)
 146         (tui_display_register): Remove unnecessary cast.
 147         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 148         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 149         (make_visible): Remove unnecessary cast.
 150         * tui/tui-winsource.c (tui_erase_source_content)
 151         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 152         unnecessary cast.
 153         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 154         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 155         * stabsread.c (read_type, read_array_type, read_range_type):
 156         Remove unnecessary cast.
 157         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 158         (parse_symbol, parse_type, upgrade_type, parse_external)
 159         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 160         unnecessary cast.
 161         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 162
 163 2019-06-16  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-data.c (tui_alloc_generic_win_info)
 166         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 167         checks.
 168
 169 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 170             Andrew Burgess  <andrew.burgess@embecosm.com>
 171
 172         * f-typeprint.c (f_print_type): Don't return early for not
 173         associated or not allocated types.
 174         (f_type_print_varspec_suffix): Add print_rank parameter and print
 175         ranks of array types in case they dangling.
 176         (f_type_print_base): Add print_rank parameter.
 177
 178 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 179
 180         * NEWS: Mention new MI commands.
 181         * break-catch-throw.c (enum exception_event_kind): Move to
 182         breakpoint.h.
 183         (print_mention_exception_catchpoint): Output text as a single
 184         message.
 185         (catch_exception_command_1): Rename to...
 186         (catch_exception_event): ...this, make non-static, update header
 187         command, and change some parameter types.
 188         (catch_catch_command): Update for changes to
 189         catch_exception_command_1.
 190         (catch_throw_command): Likewise.
 191         (catch_rethrow_command): Likewise.
 192         * breakpoint.c (enum exception_event_kind): Delete.
 193         * breakpoint.h (enum exception_event_kind): Moved here from
 194         break-catch-throw.c.
 195         (catch_exception_event): Declare.
 196         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 197         (mi_cmd_catch_throw): New function.
 198         (mi_cmd_catch_rethrow): New function.
 199         (mi_cmd_catch_catch): New function.
 200         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 201         'catch-catch' entries.
 202         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 203         (mi_cmd_catch_rethrow): Declare.
 204         (mi_cmd_catch_catch): Declare.
 205
 206 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * annotate.c (annotate_source_line): Change return type to void,
 209         update implementation to match.
 210         * annotate.h (annotate_source_line): Change return type to void,
 211         update header comment.
 212         * stack.c (print_frame_info): Don't change what frame information
 213         is printed based on whether annotations are on or not.
 214
 215 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 216
 217         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 218         (annotate_source): Make static.
 219         (annotate_source_line): Moved from source.c and renamed from
 220         identify_source_line.  Update the return type.
 221         * annotate.h (annotate_source): Delete declaration.
 222         (annotate_source_line): Declaration moved from source.h, and
 223         renamed from identify_source_line.  Return type updated.
 224         * source.c (identify_source_line): Moved to annotate.c and renamed
 225         to annotate_source_line.
 226         (info_line_command): Remove check of annotation_level.
 227         * source.h (identify_source_line): Move declaration to annotate.h
 228         and rename to annotate_source_line.
 229         * stack.c: Add 'annotate.h' include.
 230         (print_frame_info): Remove check of annotation_level before
 231         calling annotate_source_line.
 232
 233 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 234
 235         * source-cache.c (source_cache::get_plain_source_lines): Use
 236         open_source_file_with_line_charpos instead of just
 237         open_source_file, remove call to find_source_lines.
 238         (source_cache::get_source_lines): Likewise.
 239         * source.c (find_source_lines): Make static.
 240         (get_filename_and_charpos): Renamed into...
 241         (open_source_file_with_line_charpos): ..this along with changes to
 242         return a scoped_fd, and some other minor clean ups.
 243         (identify_source_line): Use open_source_file_with_line_charpos.
 244         (search_command_helper): Use open_source_file_with_line_charpos
 245         instead of just open_source_file, remove call to
 246         find_source_lines.
 247         * source.h (open_source_file_with_line_charpos): Declare new
 248         function.
 249         (find_source_lines): Delete declaration.
 250
 251 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 252
 253         * source.c (get_filename_and_charpos): Remove fullname
 254         parameter.
 255         (identify_source_line): Update call to get_filename_and_charpos.
 256
 257 2019-06-14  Tom Tromey  <tromey@adacore.com>
 258
 259         PR gdb/24502:
 260         * ui-style.h (skip_ansi_escape): Update comment.
 261         * ui-file.h (class no_terminal_escape_file): New class.
 262         * ui-file.c (no_terminal_escape_file::write)
 263         (no_terminal_escape_file::puts): New methods.
 264         * cli/cli-logging.c (handle_redirections): Use
 265         no_terminal_escape_file.
 266
 267 2019-06-14  Tom Tromey  <tromey@adacore.com>
 268
 269         * NEWS: Move convenience variable news above Python news.
 270
 271 2019-06-14  Tom Tromey  <tom@tromey.com>
 272
 273         * gnulib: Move directory to top-level.
 274         * configure.ac: Don't configure gnulib.
 275         * configure: Rebuild.
 276         * common/common-defs.h: Use new path to gnulib.
 277         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 278         (GNULIB_H): Remove.
 279         (INCGNU): Look in new gnulib location.
 280         (HFILES_NO_SRCDIR): Remove gnulib files.
 281         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 282         (generated_files): Remove GNULIB_H.
 283         ($(LIBGNU), all-lib): Remove targets.
 284         (distclean): Don't mention GNULIB_BUILDDIR.
 285         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 286
 287 2019-06-14  Tom Tromey  <tromey@adacore.com>
 288
 289         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 290         Warn if symbol file does not provide any symbols.
 291
 292 2019-06-14  Tom Tromey  <tromey@adacore.com>
 293
 294         * source.c (find_and_open_source): Respect basenames_may_differ.
 295
 296 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * annotate.c (annotate_breakpoints_invalid): Make use of
 299         scoped_restore_terminal_state.
 300         (annotate_frames_invalid): Likewise.
 301
 302 2019-06-14  Tom Tromey  <tromey@adacore.com>
 303
 304         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 305         allow assignment to an internalvar.
 306
 307 2019-06-14  Tom Tromey  <tromey@adacore.com>
 308
 309         * ada-lex.l: Allow "_" in attribute names.
 310
 311 2019-06-14  Tom Tromey  <tromey@adacore.com>
 312
 313         PR gdb/24653:
 314         * regcache.c (registers_changed): Don't call alloca.
 315         * top.c (execute_command): Don't call alloca.
 316
 317 2019-06-13  Pedro Alves  <palves@redhat.com>
 318
 319         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 320         'expression'.  When parsing an expression, error out if there's
 321         junk after "unlimited".
 322         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 323         (do_set_command): Adjust calls to is_unlimited_literal.
 324
 325 2019-06-13  Pedro Alves  <palves@redhat.com>
 326
 327         * compile/compile.c (make_compile_options_def_group): Add braces
 328         around array_view initializer.
 329         * thread.c (make_thread_apply_all_options_def_group)
 330         (make_thread_apply_all_options_def_group): Likewise.
 331
 332 2019-06-13  Pedro Alves  <palves@redhat.com>
 333
 334         * NEWS (New commands): Mention "maint test-options
 335         require-delimiter", "maint test-options unknown-is-error", "maint
 336         test-options unknown-is-operand" and "maint show
 337         test-options-completion-result".
 338         (New command options, command completion): New section.
 339         (Completion improvements): New section.
 340         Mention that you can abbreviate "unlimited".
 341
 342 2019-06-13  Pedro Alves  <palves@redhat.com>
 343
 344         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 345         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 346         * unittests/cli-utils-selftests.c (test_parse_flags)
 347         (test_parse_flags_qcs): Delete.
 348         (test_cli_utils): Don't call deleted functions.
 349
 350 2019-06-13  Pedro Alves  <palves@redhat.com>
 351
 352         * thread.c: Include "cli/cli-option.h".
 353         (tp_array_compar_ascending): Global.
 354         (tp_array_compar): Delete function.
 355         (tp_array_compar_ascending, tp_array_compar_descending): New
 356         functions.
 357         (ascending_option_def, qcs_flag_option_def)
 358         (thr_qcs_flags_option_defs)
 359         (make_thread_apply_all_options_def_group)
 360         (make_thread_apply_options_def_group): New.
 361         (thread_apply_all_command): Use gdb::option::process_options.
 362         (thread_apply_command_completer)
 363         (thread_apply_all_command_completer): New.
 364         (thread_apply_command): Use gdb::option::process_options.
 365         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 366         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 367         to generate help text of "thread apply".  Adjust "taas"'s help.
 368         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 369         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 370
 371 2019-06-13  Pedro Alves  <palves@redhat.com>
 372
 373         * thread.c (thread_apply_command): Check for invalid TID with
 374         isdigit instead of !isalpha.
 375
 376 2019-06-13  Pedro Alves  <palves@redhat.com>
 377
 378         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 379         (validate_flags_qcs): New.
 380         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 381         (validate_flags_qcs): Declare.
 382         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 383         (make_frame_apply_options_def_group): New.
 384         (frame_apply_command_count): Process options with
 385         gdb::option::process_options.
 386         (frame_apply_completer): New.
 387         (frame_apply_level_completer, frame_apply_all_completer)
 388         (frame_apply_completer): New.
 389         (_initialize_stack): Update help of "frame apply", "frame apply
 390         level", "frame apply all" and "faas" to mention supported options
 391         and install command completers.
 392         * stack.h (frame_apply_all_completer): Declare.
 393         * thread.c: Include "stack.h".
 394         (tfaas_command): Add "--".
 395         (_initialize_thread): Update help "tfaas" to mention supported
 396         options and install command completer.
 397
 398 2019-06-13  Pedro Alves  <palves@redhat.com>
 399
 400         * completer.c (complete_nested_command_line): New.
 401         (gdb_completion_word_break_characters_throw): Add assertion.
 402         * completer.h (complete_nested_command_line): Declare.
 403
 404 2019-06-13  Pedro Alves  <palves@redhat.com>
 405
 406         * stack.c (parse_backtrace_qualifiers): New.
 407         (backtrace_command): Use it.
 408         (backtrace_command_completer): Complete on qualifiers.
 409
 410 2019-06-13  Pedro Alves  <palves@redhat.com>
 411
 412         * frame.c: Include "cli/cli-option.h.
 413         (user_set_backtrace_options): New.
 414         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 415         Delete.
 416         (get_prev_frame): Adjust.
 417         (boolean_option_def, uinteger_option_def)
 418         (set_backtrace_option_defs): New.
 419         (_initialize_frame): Adjust and use
 420         gdb::option::add_setshow_cmds_for_options to install "set
 421         backtrace past-main" and "set backtrace past-entry".
 422         * frame.h: Include "cli/cli-option.h".
 423         (struct frame_print_options): Forward declare.
 424         (print_frame_arguments_all, print_frame_arguments_scalars)
 425         (print_frame_arguments_none): Declare.
 426         (print_entry_values): Delete declaration.
 427         (struct frame_print_options, user_frame_print_options): New.
 428         (struct set_backtrace_options): New.
 429         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 430         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 431         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 432         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 433         (list_args_or_locals): Add frame_print_options parameter.
 434         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 435         * python/py-framefilter.c (enumerate_args): Pass down
 436         USER_FRAME_PRINT_OPTIONS.
 437         * stack.c: Include "cli/cli-option.h".
 438         (print_frame_arguments_all, print_frame_arguments_scalars)
 439         (print_frame_arguments_none): Declare.
 440         (print_raw_frame_arguments, print_entry_values): Delete.
 441         (user_frame_print_options): New.
 442         (boolean_option_def, enum_option_def, frame_print_option_defs):
 443         New.
 444         (struct backtrace_cmd_options): New.
 445         (bt_flag_option_def): New.
 446         (backtrace_command_option_defs): New.
 447         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 448         (print_frame_arg, read_frame_arg, print_frame_args)
 449         (print_frame_info, print_frame): Add frame_print_options parameter
 450         and use it.
 451         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 452         (backtrace_command_1): Add frame_print_options and
 453         backtrace_cmd_options parameters and use them.
 454         (make_backtrace_options_def_group): New.
 455         (backtrace_command): Process command options with
 456         gdb::option::process_options.
 457         (backtrace_command_completer): New.
 458         (_initialize_stack): Extend "backtrace"'s help to mention
 459         supported options.  Install completer for "backtrace".
 460         Install some settings commands with add_setshow_cmds_for_options.
 461
 462 2019-06-13  Pedro Alves  <palves@redhat.com>
 463
 464         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 465         and that "set/show print raw frame-arguments" are now deprecated.
 466
 467         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 468         command.
 469         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 470         * stack.c (_initialize_stack): Install "set/show print
 471         raw-frame-arguments", and deprecate "set/show print raw
 472         frame-arguments".
 473         * valprint.c (_initialize_valprint): Deprecate "set/show print
 474         raw".
 475
 476 2019-06-13  Pedro Alves  <palves@redhat.com>
 477
 478         * compile/compile.c (struct compile_options): New.
 479         (compile_flag_option_def, compile_command_option_defs)
 480         (make_compile_options_def_group): New.
 481         (compile_file_command): Handle options with
 482         gdb::option::process_options.
 483         (compile_file_command_completer): New function.
 484         (compile_code_command): Handle options with
 485         gdb::option::process_options.
 486         (compile_code_command_completer): New function.
 487         (_initialize_compiler): Install completers for "compile code" and
 488         "compile file".  Mention available options in "compile code" and
 489         "compile code"'s help.
 490         * completer.c (advance_to_completion_word): New, factored out from
 491         ...
 492         (advance_to_expression_complete_word_point): ... this.
 493         (advance_to_filename_complete_word_point): New.
 494         * completer.h (advance_to_filename_complete_word_point): New
 495         declaration.
 496
 497 2019-06-13  Pedro Alves  <palves@redhat.com>
 498
 499         * compile/compile.c: Include "cli/cli-option.h".
 500         (compile_print_value): Scope data pointer is now a
 501         value_print_options pointer; adjust.
 502         (compile_print_command): Process options.  Scope data pointer is
 503         now a value_print_options pointer; adjust.
 504         (_initialize_compile): Update "compile print"'s help to include
 505         supported options.  Install a completer for "compile print".
 506         * cp-valprint.c (show_vtblprint, show_objectprint)
 507         (show_static_field_print): Delete.
 508         (_initialize_cp_valprint): Don't install "set print
 509         static-members", "set print vtbl", "set print object" here.
 510         * printcmd.c: Include "cli/cli-option.h" and
 511         "common/gdb_optional.h".
 512         (print_command_parse_format): Rework to fill in a
 513         value_print_options instead of a format_data.
 514         (print_value): Change parameter type from format_data pointer to
 515         value_print_options reference.  Adjust.
 516         (print_command_1): Process options.  Adjust to pass down a
 517         value_print_options.
 518         (print_command_completer): New.
 519         (_initialize_printcmd): Install print_command_completer as
 520         handle_brkchars completer for the "print" command.  Update
 521         "print"'s help to include supported options.
 522         * valprint.c: Include "cli/cli-option.h".
 523         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 524         here from cp-valprint.c.
 525         (boolean_option_def, uinteger_option_def)
 526         (value_print_option_defs, make_value_print_options_def_group):
 527         New.  Use gdb::option::add_setshow_cmds_for_options to install
 528         "set print elements", "set print null-stop", "set print repeats",
 529         "set print pretty", "set print union", "set print array", "set
 530         print address", "set print symbol", "set print array-indexes".
 531         * valprint.h: Include <string> and "cli/cli-option.h".
 532         (make_value_print_options_def_group): Declare.
 533         (print_value): Change parameter type from format_data pointer to
 534         value_print_options reference.
 535         (print_command_completer): Declare.
 536
 537 2019-06-13  Pedro Alves  <palves@redhat.com>
 538
 539         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 540         (COMMON_SFILES): Add maint-test-settings.c.
 541         * cli/cli-decode.c (boolean_enums): New global, factored out from
 542         ...
 543         (add_setshow_boolean_cmd): ... here.
 544         * cli/cli-decode.h (boolean_enums): Declare.
 545         * cli/cli-option.c: New file.
 546         * cli/cli-option.h: New file.
 547         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 548         factored out from ...
 549         (parse_cli_boolean_value(const char *)): ... this.
 550         (is_unlimited_literal): Change parameter type to pointer to
 551         pointer.  Adjust and advance ARG pointer.
 552         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 553         (parse_cli_var_enum): New, factored out from ...
 554         (do_set_command): ... this.  Adjust.
 555         * cli/cli-setshow.h (parse_cli_boolean_value)
 556         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 557         (parse_cli_var_enum): Declare.
 558         * cli/cli-utils.c: Include "cli/cli-option.h".
 559         (get_ulongest): New.
 560         * cli/cli-utils.h (get_ulongest): Declare.
 561         (check_for_argument): New overloads.
 562         * maint-test-options.c: New file.
 563
 564 2019-06-13  Pedro Alves  <palves@redhat.com>
 565
 566         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 567         parse a range if "-" is at the end of the string.
 568
 569 2019-06-13  Pedro Alves  <palves@redhat.com>
 570
 571         * cli/cli-setshow.c (parse_auto_binary_operation)
 572         (parse_cli_boolean_value): Don't allow "o".
 573
 574 2019-06-13  Pedro Alves  <palves@redhat.com>
 575
 576         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 577         * NEWS: Mention maint test-settings KIND.
 578         * maint-test-settings.c: New file.
 579
 580 2019-06-13  Pedro Alves  <palves@redhat.com>
 581
 582         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 583         completer.
 584         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 585         "set" completers.
 586
 587 2019-06-13  Pedro Alves  <palves@redhat.com>
 588
 589         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 590         after item.
 591
 592 2019-06-13  Pedro Alves  <palves@redhat.com>
 593
 594         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 595
 596 2019-06-13  Pedro Alves <palves@redhat.com>
 597
 598         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 599         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 600         call.
 601         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 602         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 603         calls.
 604         (check_for_argument): Skip spaces after argument.
 605
 606 2019-06-13  Pedro Alves  <palves@redhat.com>
 607
 608         * thread.c (thread_apply_command): Adjust TID parsing.
 609         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 610         detected before end of string.
 611         (tid_is_in_list): Error out if LIST is invalid.
 612
 613 2019-06-13  Pedro Alves  <palves@redhat.com>
 614
 615         * completer.c (complete_line_internal_1): Rewind completion word
 616         point.
 617         (completion_tracker::advance_custom_word_point_by): Change
 618         parameter type to int.
 619         * completer.h (completion_tracker::advance_custom_word_point_by):
 620         Likewise.
 621
 622 2019-06-13  Pedro Alves  <palves@redhat.com>
 623
 624         * completer.c (advance_to_completion_word): Handle delimiters.
 625
 626 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 627
 628         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 629
 630 2019-06-11  Tom Tromey  <tom@tromey.com>
 631
 632         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 633         (xmalloc_failed): Move to alloc.c.
 634         * alloc.c: New file.
 635         * Makefile.in (COMMON_SFILES): Add alloc.c.
 636
 637 2019-06-11  Tom Tromey  <tom@tromey.com>
 638
 639         * nat/linux-waitpid.c: Don't include server.h.
 640         (linux_debug): Remove.
 641         (my_waitpid): Update.
 642
 643 2019-06-11  Tom Tromey  <tromey@adacore.com>
 644
 645         * infcall.c (_initialize_infcall): Remove trailing newline from
 646         help.
 647         * user-regs.c (_initialize_user_regs): Remove trailing newline
 648         from help.
 649         * typeprint.c (_initialize_typeprint): Remove trailing newline
 650         from help.
 651         * reverse.c (_initialize_reverse): Remove trailing newlines from
 652         help.
 653         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 654         from help.
 655         * language.c (add_set_language_command): Remove trailing newline
 656         from help.
 657         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 658         help.
 659         * disasm.c (_initialize_disasm): Remove trailing newline from
 660         help.
 661         * top.c (init_main): Remove trailing newline from help.
 662         * interps.c (_initialize_interpreter): Remove trailing newline
 663         from help.
 664         * btrace.c (_initialize_btrace): Remove trailing newlines from
 665         help.
 666         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 667         from help.
 668         * python/python.c (_initialize_python): Remove trailing newline
 669         from help.
 670         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 671         help.
 672         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 673         from help.  Reformat some text.
 674         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 675         from help.
 676         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 677         newline from help.
 678
 679 2019-06-11  Tom Tromey  <tromey@adacore.com>
 680
 681         * darwin-nat.c (darwin_decode_exception_message)
 682         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 683
 684 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 685
 686         * valops.c (value_slice): Check for not allocated or not
 687         associated values.
 688
 689 2019-06-10  Tom de Vries  <tdevries@suse.de>
 690
 691         PR gdb/24618
 692         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 693         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 694         invalid.
 695
 696 2019-06-10  Tom de Vries  <tdevries@suse.de>
 697
 698         PR gdb/24611
 699         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 700         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 701
 702 2019-06-10  Tom de Vries  <tdevries@suse.de>
 703
 704         PR symtab/24545
 705         * symtab.c (struct demangled_name_entry): Add language field.
 706         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 707         static minimal symbol".  Set and use language field.
 708
 709 2019-06-10  Tom Tromey  <tromey@adacore.com>
 710
 711         * ada-lang.c (_initialize_ada_language): Update help text.
 712
 713 2019-06-10  Tom Tromey  <tromey@adacore.com>
 714
 715         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 716         with a newline.
 717         * guile/guile.c (handle_boot_error): Don't end warning with a
 718         newline.
 719         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 720         warning with a newline.
 721         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 722         newline.
 723         (s12z_frame_cache): Likewise.
 724         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 725         a newline.
 726         * solib-svr4.c (disable_probes_interface): Don't end warning with
 727         a newline.
 728         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 729         newline.
 730         * python/python.c (do_finish_initialization): Don't end warning
 731         with a newline.
 732
 733 2019-06-10  Tom Tromey  <tom@tromey.com>
 734
 735         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 736         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 737         gdbpy_enter.
 738
 739 2019-06-10  Tom Tromey  <tromey@adacore.com>
 740
 741         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 742         data.
 743         (elf_new_init): Don't call stabsread_new_init.
 744         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 745         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 746         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 747
 748 2019-06-10  Tom de Vries  <tdevries@suse.de>
 749
 750         PR symtab/16264
 751         PR symtab/24517
 752         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 753
 754 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 755
 756         * source.c (find_and_open_source): Also rewrite relative file
 757         names.
 758
 759 2019-04-26  Amos Bird  <amosbird@gmail.com>
 760
 761         * annotate.c (annotate_thread_exited): Add "thread-exited"
 762         annotation.
 763
 764 2019-06-06  Tom Tromey  <tromey@adacore.com>
 765
 766         * maint.h (class scoped_command_stats): Use
 767         DISABLE_COPY_AND_ASSIGN.
 768         <print_time>: New method.
 769         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 770         print_time.
 771         (scoped_command_stats::print_time): New method.
 772
 773 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 776         instructions of lengths 6 or 8 bytes.
 777
 778 2019-06-04  Pedro Alves  <palves@redhat.com>
 779
 780         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 781
 782         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 783         * breakpoint.c (condition_completer): Likewise.
 784         * cli/cli-dump.c (scan_expression): Likewise.
 785         * common/filestuff.c (mkdir_recursive): Likewise.
 786         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 787         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 788         (gdb_abspath): Likewise.
 789         * compile/compile-cplus-types.c
 790         (compile_cplus_instance::decl_name): Likewise.
 791         * completer.c (complete_explicit_location):
 792         (signal_completer, reg_or_group_completer_1): Likewise.
 793         * cp-support.c (cp_remove_params_if_any): Likewise.
 794         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 795         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 796         * infcmd.c (strip_bg_char): Likewise.
 797         * linespec.c (copy_token_string): Likewise.
 798         * mi/mi-main.c (output_cores): Likewise.
 799         * psymtab.c (psymtab_search_name):
 800         * symfile.c (test_set_ext_lang_command): Likewise.
 801         * target.c (target_fileio_read_stralloc): Likewise.
 802         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 803         * value.c (complete_internalvar): Likewise.
 804
 805 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 806
 807         Add objfile property to gdb.Type.
 808         * NEWS: Mention Python API addition.
 809         * python/py-type.c (typy_get_objfile): New method.
 810
 811 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 812
 813         * NEWS: Mention the new set|show style [title|highlight].
 814         Mention changes to "show style", "help" and "apropos".
 815
 816 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 817
 818         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 819         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 820         instead of print_help_for_command.
 821         (print_doc_of_command): New function.
 822         (help_list): Add 'apropos -v word' suggestion.
 823         (print_help_for_command): Style the command name using title style.
 824         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 825         (_initialize_cli_cmds): Describe -v in apropos_command help.
 826
 827 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 828
 829         * cli/cli-style.h (cli_style_option): Add name in constructor,
 830         add m_name class member, add constructor with intensity,
 831         add name class function.
 832         (cli_style_option::add_setshow_commands): Remove name argument.
 833         (highlight_style, title_style): New styles.
 834         * cli/cli-style.c (do_show): New function that shows a style
 835         characteristic styling the style name with itself.
 836         (set_style_name): New function.
 837         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 838         Update all callers according to the changes in cli/cli-style.h.
 839         * utils.h (fputs_highlighted): New function.
 840         * utils.c (fputs_highlighted): Likewise.
 841
 842 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 843
 844         * NEWS: Mention new pipe command and new convenience variables.
 845
 846 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 847
 848         * cli/cli-cmds.c (pipe_command): New function.
 849         (_initialize_cli_cmds): Call add_com for pipe_command.
 850         Define | as an alias for pipe.
 851         (exit_status_set_internal_vars): New function.
 852         (shell_escape): Call exit_status_set_internal_vars.
 853         cli/cli-decode.c (find_command_name_length): Recognize | as
 854         a single character command.
 855
 856 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 857
 858         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 859         top.c (execute_command_to_ui_file): New function, mostly a copy
 860         of execute_command_to_string.
 861         (execute_command_to_string): Implement by calling
 862         execute_command_to_ui_file.
 863
 864 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 865
 866         * top.h (saved_command_line): Remove declaration.
 867         * top.c (previous_saved_command_line, previous_repeat_arguments):
 868         New variables.
 869         (saved_command_line): Make static, define together with other
 870         'repeat variables'.
 871         (dont_repeat): Clear repeat_arguments.
 872         (repeat_previous, get_saved_command_line, save_command_line):
 873         New functions.
 874         (gdb_init): Initialize saved_command_line
 875         and previous_saved_command_line.
 876         * main.c (captured_main_1): Remove saved_command_line initialization.
 877         * event-top.c (handle_line_of_input): Update to use
 878         the new 'repeat' related functions instead of direct access to
 879         saved_command_line.
 880         * command.h (repeat_previous, get_saved_command_line,
 881         save_command_line): New declarations.
 882         (dont_repeat): Add comment.
 883
 884 2019-05-30  Tom Tromey  <tromey@adacore.com>
 885
 886         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 887         Fix comment.
 888         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 889
 890 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 891
 892         PR cli/24587
 893         * completer.c (complete): Initialize variable word.
 894
 895 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 896
 897         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 898         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 899         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 900         'body' is NULL to the outter 'if', protecting the '!is_define'
 901         situation as well.
 902
 903 2019-05-29  Tom Tromey  <tromey@adacore.com>
 904
 905         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 906         (dwarf_unknown): New function.
 907         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 908         (dwarf_type_encoding_name): Use dwarf_unknown.
 909
 910 2019-05-29  Tom Tromey  <tromey@adacore.com>
 911
 912         PR c++/20020:
 913         * cp-valprint.c (cp_print_value_fields): Call
 914         cp_print_static_field inside "try".
 915
 916 2019-05-29  Tom Tromey  <tromey@adacore.com>
 917
 918         * inflow.c (struct terminal_info): Add default operator=.
 919         * configure: Rebuild.
 920         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 921         -Wdeprecated-copy-dtor, -Wredundant-move.
 922
 923 2019-05-29  Tom Tromey  <tromey@adacore.com>
 924
 925         * NEWS: Add entry.
 926         * infcmd.c (print_return_value_1): Handle finish_print
 927         option.
 928         (show_print_finish): New function.
 929         (_initialize_infcmd): Add "set/show print finish" commands.
 930         * valprint.c (user_print_options): Initialize new member.
 931         * valprint.h (struct value_print_options) <finish_print>: New
 932         member.
 933
 934 2019-05-28  Tom Tromey  <tromey@adacore.com>
 935
 936         * ada-lang.c (ada_remove_Xbn_suffix)
 937         (find_old_style_renaming_symbol)
 938         (parse_old_style_renaming): Remove.
 939         (ada_find_renaming_symbol): Don't call
 940         find_old_style_renaming_symbol.
 941         (ada_is_renaming_symbol): Rename from
 942         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 943         bool.  Now static.
 944         (ada_read_var_value): Update and simplify.
 945         * ada-exp.y (write_var_or_type): Remove old code.
 946
 947 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 948
 949         * event-top.c: Remove include comment.
 950         * inflow.c (class scoped_ignore_sigttou): Move from here...
 951         * inflow.h (class scoped_ignore_sigttou): ...to here.
 952         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 953         * top.c:  Remove include comment.
 954
 955 2019-05-27  Tom Tromey  <tom@tromey.com>
 956
 957         * NEWS: Fix typo.
 958
 959 2019-05-22  Tom Tromey  <tromey@adacore.com>
 960
 961         * target.c (target_follow_exec): Constify parameter.
 962         * target-delegates.c: Rebuild.
 963         * remote.c (remote_target::follow_exec): Constify parameter.
 964         * infrun.c (follow_exec): Constify parameter.
 965         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 966         (target_follow_exec): Likewise.
 967
 968 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 969
 970         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 971         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 972
 973 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 974
 975         * NEWS: Add debugredirect and testsuite sections.
 976
 977 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 978
 979         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 980         target descriptions using exclusively floating point register name
 981         aliases.
 982
 983 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         PR gdb/18644:
 986         * f-lang.c (build_fortran_types): Handle the case where
 987         gdbarch_floatformat_for_type returns a nullptr.
 988
 989 2019-05-21  Tom de Vries  <tdevries@suse.de>
 990
 991         PR cli/24587
 992         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 993
 994 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         PR gdb/18644:
 997         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 998         16-byte floats.
 999         * i386-tdep.c (i386_floatformat_for_type): Use
1000         floatformats_ia64_quad for the 16-byte floating point component
1001         within a fortran 32-byte complex number.
1002
1003 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1006         delete default constructor.
1007         (find_partial_die): Update to return const struct.
1008         (partial_die_parent_scope): Move variable declaration into scope
1009         of its use and change its type to auto.
1010         (guess_partial_die_structure_name): Likewise.
1011         (partial_die_info::fixup): Likewise.
1012
1013 2019-05-17  Tom Tromey  <tromey@adacore.com>
1014
1015         * source.c (find_and_open_source): Remove cast.
1016
1017 2019-05-17  Tom Tromey  <tromey@adacore.com>
1018
1019         * annotate.c (annotate_source): Make "filename" const.
1020         * annotate.h (annotate_source): Use const.
1021
1022 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1023
1024         * disasm.c (set_disassembler_options): Send errors to stderr.
1025
1026 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1027
1028         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1029         (cli_interp_base::set_logging): Check debug_redirect.
1030         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1031         * cli/cli-logging.c (debug_redirect): Add static variable.
1032         (pop_output_files): Add default param.
1033         (handle_redirections): Print debug setting.
1034         (show_logging_command): Likewise.
1035         (_initialize_cli_logging): Add debugredirect command.
1036         * interps.c (current_interp_set_logging): Add debug_redirect
1037         parameter.
1038         * interps.h (set_logging): Add debug_redirect parameter.
1039         (current_interp_set_logging): Likewise.
1040         * mi/mi-common.h: Likewise.
1041         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1042
1043 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1044             Tom Tromey  <tromey@adacore.com>
1045
1046         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1047         directly.
1048         * cli/cli-interp.h (make_logging_output): Remove declaration.
1049         * cli/cli-logging.c (make_logging_output): Remove function.
1050         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1051         directly.
1052         * ui-file.c (tee_file::tee_file): Remove bools.
1053         (tee_file::~tee_file): Remove deletes.
1054         * ui-file.h (tee_file): Remove bools.
1055
1056 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1057
1058         * mi/mi-cmds.h (mi_cmd_complete): New function.
1059         * mi/mi-main.c (mi_cmd_complete): Likewise.
1060         * mi/mi-cmds.c: Define new MI command -complete.
1061         * NEWS: Mention new -complete command.
1062
1063 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1064
1065         * completer.h (complete): New function.
1066         * completer.c (complete): Likewise.
1067         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1068         function defined in completer.h.
1069
1070 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1071
1072         * MAINTAINERS (Write After Approval): Add myself.
1073
1074 2019-05-17  Tom de Vries  <tdevries@suse.de>
1075
1076         PR gdb/24094
1077         * dwarf2read.c (struct cu_partial_die_info): New struct.
1078         (find_partial_die): Return cu_partial_die_info.
1079         (partial_die_parent_scope, guess_partial_die_structure_name)
1080         (partial_die_info::fixup): Handle new return type of find_partial_die.
1081
1082 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1083
1084         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1085         "std::string", simplifying the algorithm.
1086
1087 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1088
1089         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1090         (stap_static_probe_ops::get_probes): Likewise.
1091
1092 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1093
1094         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1095         '-')" and "else if".
1096         (stap_parse_single_operand): Join checks for
1097         "gdbarch_stap_parse_special_token_p" and
1098         "gdbarch_stap_parse_special_token" in the same "if" statement.
1099         Invert check when verifying for operation on register
1100         displacement.
1101
1102 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1103
1104         * stap-probe.c (stap_get_opcode): Update comment.
1105         (stap_get_expected_argument_type): Likewise.
1106         (handle_stap_probe): Likewise.
1107
1108 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1109
1110         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1111         return type to 'bool'.  Adjust comment.  Use 'bool' when
1112         appropriate.
1113         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1114         * stap-probe.c (stap_parse_argument_1): Likewise.
1115         (stap_is_operator): Likewise.
1116         (stap_is_generic_prefix): Likewise.
1117         (stap_is_register_prefix): Likewise.
1118         (stap_is_register_indirection_prefix): Likewise.
1119         (stap_is_integer_prefix): Likewise.
1120         (stap_generic_check_suffix): Likewise.
1121         (stap_check_integer_suffix): Likewise.
1122         (stap_check_register_suffix): Likewise.
1123         (stap_check_register_indirection_suffix): Likewise.
1124         (stap_parse_register_operand): Likewise.
1125         (stap_parse_single_operand): Likewise.
1126         (stap_parse_argument_1): Likewise.
1127         (stap_probe::get_argument_count): Likewise.
1128         (stap_is_operator): Likewise.
1129
1130 2019-05-16  Tom Tromey  <tromey@adacore.com>
1131
1132         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1133         keyword to foreach.
1134
1135 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1136
1137         * linux-thread-db.c (try_thread_db_load_1): Change return type
1138         to bool.
1139         (try_thread_db_load): Likewise.
1140         (try_thread_db_load_from_pdir_1): Likewise.
1141         (try_thread_db_load_from_pdir): Likewise.
1142         (try_thread_db_load_from_sdir): Likewise.
1143         (try_thread_db_load_from_dir): Likewise.
1144         (thread_db_load_search): Likewise.
1145         (has_libpthread): Likewise.
1146         (thread_db_load): Likewise.
1147
1148 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1149
1150         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1151         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1152         NULL, and complain/return if that's the case.
1153
1154 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1155
1156         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1157         (advance, posn, abstract_read_memory): New functions.
1158         [struct mem_read_abstraction]: New struct.
1159         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1160
1161 2019-05-14  Tom Tromey  <tromey@adacore.com>
1162
1163         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1164         value is not lval_memory.
1165
1166 2019-05-14  Tom Tromey  <tromey@adacore.com>
1167
1168         * solib.c (info_sharedlibrary_command): Style the file name.
1169
1170 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1171
1172         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1173         (aarch64_vnv_type): Likewise.
1174         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1175         * common/tdesc.c: Likewise.
1176         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1177         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1178         * features/aarch64-fpu.xml: Add ieee half view.
1179         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1180         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1181         * gdbtypes.h (struct builtin_type): Likewise.
1182         (struct objfile_type): Likewise.
1183
1184 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1185
1186         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1187         typo.
1188         * location.h (string_to_event_location): Likewise.
1189
1190 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1191
1192         GDB 8.3 released.
1193
1194 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1195
1196         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1197         New variable declaration.
1198         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1199         New variable.
1200         (print_one_breakpoint): Use ui_out::test_flags and new global
1201         variable to compute use_fixed_output.
1202         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1203         Remove.
1204         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1205         (mi_multi_location_breakpoint_output_fixed): Remove.
1206         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1207         new variable.
1208         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1209         fix_multi_location_breakpoint_output flag if version >= 3.
1210         * ui-out.h (enum ui_out_flag)
1211         <fix_multi_location_breakpoint_output>: New enumerator.
1212
1213 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1214
1215         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1216
1217 2019-05-10  Tom Tromey  <tromey@adacore.com>
1218
1219         * ada-lang.c (catch_ada_completer): New function.
1220         (_initialize_ada_language): Use it.
1221
1222 2019-05-10  Tom Tromey  <tromey@adacore.com>
1223
1224         * thread.c (print_thread_info): Make "requested_threads" const.
1225         * gdbthread.h (print_thread_info): Make "requested_threads"
1226         const.
1227         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1228         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1229
1230 2019-05-08  Tom Tromey  <tom@tromey.com>
1231
1232         * gdbtypes.c (objfile_type_data): Change type.
1233         (objfile_type, _initialize_gdbtypes): Update.
1234
1235 2019-05-08  Tom Tromey  <tom@tromey.com>
1236
1237         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1238         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1239         (_initialize_dwarf2_frame): Update.
1240
1241 2019-05-08  Tom Tromey  <tom@tromey.com>
1242
1243         * objc-lang.c (objc_objfile_data): Change type.
1244         (find_methods): Update.
1245         (_initialize_objc_lang): Remove.
1246
1247 2019-05-08  Tom Tromey  <tom@tromey.com>
1248
1249         * stabsread.c (rs6000_builtin_type_data): Change type.
1250         (rs6000_builtin_type, _initialize_stabsread): Update.
1251
1252 2019-05-08  Tom Tromey  <tom@tromey.com>
1253
1254         * mips-tdep.c (mips_pdr_data): Remove.
1255         (_initialize_mips_tdep): Update.
1256
1257 2019-05-08  Tom Tromey  <tom@tromey.com>
1258
1259         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1260         (hppa_init_objfile_priv_data, read_unwind_info)
1261         (find_unwind_entry, _initialize_hppa_tdep): Update.
1262
1263 2019-05-08  Tom Tromey  <tom@tromey.com>
1264
1265         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1266         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1267         on obstack.
1268         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1269
1270 2019-05-08  Tom Tromey  <tom@tromey.com>
1271
1272         * mdebugread.c (basic_type_data): Change type.
1273         (basic_type, _initialize_mdebugread): Update.
1274
1275 2019-05-08  Tom Tromey  <tom@tromey.com>
1276
1277         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1278
1279 2019-05-08  Tom Tromey  <tom@tromey.com>
1280
1281         * nto-tdep.c (nto_inferior_data_reg): Change type.
1282         (nto_inferior_data): Update.
1283         (nto_inferior_data_cleanup, nto_new_inferior_data)
1284         (_initialize_nto_tdep): Remove.
1285         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1286
1287 2019-05-08  Tom Tromey  <tom@tromey.com>
1288
1289         * ada-lang.c (struct ada_inferior_data): Add initializers.
1290         (ada_inferior_data): Change type.
1291         (ada_inferior_data_cleanup): Remove.
1292         (get_ada_inferior_data, ada_inferior_exit)
1293         (struct ada_pspace_data): Add initializers, destructor.
1294         (ada_pspace_data_handle): Change type.
1295         (get_ada_pspace_data): Update.
1296         (ada_pspace_data_cleanup): Remove.
1297
1298 2019-05-08  Tom Tromey  <tom@tromey.com>
1299
1300         * coffread.c (struct coff_symfile_info): Add initializers.
1301         (coff_objfile_data_key): Move lower.  Change type.
1302         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1303         Update.
1304         (coff_free_info): Remove.
1305
1306 2019-05-08  Tom Tromey  <tom@tromey.com>
1307
1308         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1309         (fbsd_pspace_data_handle): Move lower.  Change type.
1310         (get_fbsd_pspace_data): Update.
1311         (fbsd_pspace_data_cleanup): Remove.
1312         (_initialize_fbsd_tdep): Update.
1313
1314 2019-05-08  Tom Tromey  <tom@tromey.com>
1315
1316         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1317         (get_ada_tasks_pspace_data): Update.
1318         (ada_tasks_pspace_data_cleanup): Remove.
1319         (_initialize_tasks): Update.
1320         (ada_tasks_inferior_data_handle): Change type.
1321         (get_ada_tasks_inferior_data): Update.
1322         (ada_tasks_inferior_data_cleanup): Remove.
1323         (struct ada_tasks_pspace_data): Add initializers.
1324
1325 2019-05-08  Tom Tromey  <tom@tromey.com>
1326
1327         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1328         * symfile-debug.c (debug_sym_get_probes): Change type.
1329         * stap-probe.c (handle_stap_probe):
1330         (stap_static_probe_ops::get_probes): Change type.
1331         * probe.h (class static_probe_ops) <get_probes>: Change type.
1332         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1333         (parse_probes_in_pspace): Update.
1334         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1335         Update.
1336         (any_static_probe_ops::get_probes): Change type.
1337         * elfread.c (elfread_data): New typedef.
1338         (probe_key): Change type.
1339         (elf_get_probes): Likewise.  Update.
1340         (probe_key_free): Remove.
1341         (_initialize_elfread): Update.
1342         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1343         Change type.
1344         (dtrace_process_dof_probe, dtrace_process_dof)
1345         (dtrace_static_probe_ops::get_probe): Change type.
1346
1347 2019-05-08  Tom Tromey  <tom@tromey.com>
1348
1349         * xcoffread.c (struct xcoff_symfile_info): Rename from
1350         coff_symfile_info.  Add initializers.
1351         (xcoff_objfile_data_key): Move lower.  Change type.
1352         (XCOFF_DATA): Rewrite.
1353         (xcoff_free_info): Remove.
1354         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1355         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1356         (xcoff_initial_scan): Update.
1357
1358 2019-05-08  Tom Tromey  <tom@tromey.com>
1359
1360         * solib-svr4.c (struct svr4_info): Add initializers and
1361         destructor.
1362         <probes_table>: Now an htab_up.
1363         (solib_svr4_pspace_data): Change type.
1364         (free_probes_table): Simplify.
1365         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1366         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1367         (probes_table_remove_objfile_probes, register_solib_event_probe)
1368         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1369         (_initialize_svr4_solib): Update.
1370
1371 2019-05-08  Tom Tromey  <tom@tromey.com>
1372
1373         * remote.c (remote_pspace_data): Change type.
1374         (remote_pspace_data_cleanup): Remove.
1375         (get_remote_exec_file, set_pspace_remote_exec_file)
1376         (_initialize_remote): Update.
1377
1378 2019-05-08  Tom Tromey  <tom@tromey.com>
1379
1380         * breakpoint.c (breakpoint_objfile_key): Change type.
1381         (get_breakpoint_objfile_data): Update.
1382         (free_breakpoint_objfile_data): Remove.
1383         (_initialize_breakpoint): Update.
1384
1385 2019-05-08  Tom Tromey  <tom@tromey.com>
1386
1387         * linux-tdep.c (struct linux_info): Add initializers.
1388         (linux_inferior_data): Move.  Change type.
1389         (invalidate_linux_cache_inf): Update.
1390         (linux_inferior_data_cleanup): Remove.
1391         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1392
1393 2019-05-08  Tom Tromey  <tom@tromey.com>
1394
1395         * auxv.c (auxv_inferior_data): Move.  Change type.
1396         (auxv_inferior_data_cleanup): Remove.
1397         (invalidate_auxv_cache_inf): Rewrite.
1398         (get_auxv_inferior_data, _initialize_auxv): Update.
1399
1400 2019-05-08  Tom Tromey  <tom@tromey.com>
1401
1402         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1403         (symfile_debug_objfile_data_key): Change type.
1404         (symfile_debug_installed, debug_qf_has_symbols)
1405         (debug_qf_find_last_source_symtab)
1406         (debug_qf_forget_cached_source_info)
1407         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1408         (debug_qf_print_stats, debug_qf_dump)
1409         (debug_qf_expand_symtabs_for_function)
1410         (debug_qf_expand_all_symtabs)
1411         (debug_qf_expand_symtabs_with_fullname)
1412         (debug_qf_map_matching_symbols)
1413         (debug_qf_expand_symtabs_matching)
1414         (debug_qf_find_pc_sect_compunit_symtab)
1415         (debug_qf_map_symbol_filenames)
1416         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1417         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1418         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1419         (debug_sym_read_linetable, debug_sym_relocate): Update.
1420         (symfile_debug_free_objfile): Remove.
1421         (install_symfile_debug_logging, _initialize_symfile_debug):
1422         Update.
1423
1424 2019-05-08  Tom Tromey  <tom@tromey.com>
1425
1426         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1427         allocate_on_obstack.
1428         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1429         (get_dwarf2_per_objfile): Update.
1430         (set_dwarf2_per_objfile): Remove.
1431         (dwarf2_has_info, dwarf2_get_section_info): Update.
1432         (dwarf2_free_objfile): Remove.
1433         (_initialize_dwarf2_read): Update.
1434
1435 2019-05-08  Tom Tromey  <tom@tromey.com>
1436
1437         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1438         initializers.
1439         <unsupported_script_warning_printed,
1440         script_not_found_warning_printed>: Now bool.
1441         (auto_load_pspace_data): Change type.
1442         (~auto_load_pspace_info): Rename from
1443         auto_load_pspace_data_cleanup.
1444         (get_auto_load_pspace_data, init_loaded_scripts_info)
1445         (clear_section_scripts, maybe_print_unsupported_script_warning)
1446         (maybe_print_script_not_found_warning, _initialize_auto_load):
1447         Update.
1448
1449 2019-05-08  Tom Tromey  <tom@tromey.com>
1450
1451         * objfiles.c (objfile_pspace_info): Add destructor and
1452         initializers.
1453         (objfiles_pspace_data): Change type.
1454         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1455         (get_objfile_pspace_data): Update.
1456         (objfiles_bfd_data): Change type.
1457         (get_objfile_bfd_data): Update.
1458         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1459
1460 2019-05-08  Tom Tromey  <tom@tromey.com>
1461
1462         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1463         Change type.
1464         (get_catch_syscall_inferior_data): Update.
1465         (catch_syscall_inferior_data_cleanup): Remove.
1466         (_initialize_break_catch_syscall): Update.
1467
1468 2019-05-08  Tom Tromey  <tom@tromey.com>
1469
1470         * inflow.c (struct terminal_info): Add destructor and
1471         initializers.
1472         (inflow_inferior_data): Change type.
1473         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1474         (get_inflow_inferior_data, inflow_inferior_exit)
1475         (swap_terminal_info, _initialize_inflow): Update.
1476
1477 2019-05-08  Tom Tromey  <tom@tromey.com>
1478
1479         * target-dcache.c (target_dcache_cleanup): Remove.
1480         (target_dcache_aspace_key): Change type.
1481         (target_dcache_init_p, target_dcache_invalidate)
1482         (target_dcache_get, target_dcache_get_or_init)
1483         (_initialize_target_dcache): Update.
1484         * dcache.h (struct dcache_deleter): New.
1485
1486 2019-05-08  Tom Tromey  <tom@tromey.com>
1487
1488         * symtab.c (struct symbol_cache): Add destructor and
1489         initializers.
1490         (symbol_cache_key): Move.  Change type.
1491         (make_symbol_cache, free_symbol_cache): Remove.
1492         (get_symbol_cache): Update.
1493         (symbol_cache_cleanup): Remove.
1494         (ALL_PSPACES, symbol_cache_flush)
1495         (maintenance_print_symbol_cache)
1496         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1497         Update.
1498
1499 2019-05-08  Tom Tromey  <tom@tromey.com>
1500
1501         * symtab.c (struct main_info): Add destructor and initializers.
1502         (main_progspace_key): Move.  Change type.
1503         (get_main_info): Update.
1504         (main_info_cleanup): Remove.
1505         (_initialize_symtab): Update.
1506
1507 2019-05-08  Tom Tromey  <tom@tromey.com>
1508
1509         * registry.h (DECLARE_REGISTRY): Define the _key class.
1510
1511 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1512
1513         * NEWS: Merge two 'New commands' sections.
1514
1515 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1516
1517         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1518         parameter and use Ada language definition instead.
1519         (ada_val_print_ptr): Remove unused language parameter.
1520         (ada_val_print_num): Remove language parameter and use Ada language
1521         definition instead.
1522         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1523         parameter.
1524         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1525         parameter and use Ada language definition instead.
1526         (ada_val_print_1): Update all ada_val_print_xxx calls.
1527         Remove language parameter.
1528         (ada_val_print): Update ada_val_print_1 call.
1529
1530 2019-05-08  Tom Tromey  <tromey@adacore.com>
1531
1532         * remote.c (remote_hw_watchpoint_limit)
1533         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1534         Now static.
1535
1536 2019-05-08  Tom Tromey  <tromey@adacore.com>
1537
1538         * maint.c (_initialize_maint_cmds): Move initialization code to
1539         remote.c.
1540         (watchdog, show_watchdog): Move to remote.c.
1541         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1542         "watchdog" static.
1543         (_initialize_remote): Move initialization code from maint.c.
1544         * defs.h (watchdog): Don't declare.
1545
1546 2019-05-08  Tom Tromey  <tromey@adacore.com>
1547
1548         * tui/tui-interp.c: Include main.h.
1549         * interps.c: Include main.h.
1550         * main.h (interpreter_p): Declare.
1551         * defs.h (interpreter_p): Don't declare.
1552
1553 2019-05-08  Tom Tromey  <tromey@adacore.com>
1554
1555         * dwarf2loc.c: Include dwarf2read.h.
1556         * defs.h (read_unsigned_leb128): Don't declare.
1557         * dwarf2read.h (read_unsigned_leb128): Declare.
1558
1559 2019-05-08  Tom Tromey  <tromey@adacore.com>
1560
1561         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1562         method.
1563
1564 2019-05-08  Tom Tromey  <tromey@adacore.com>
1565
1566         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1567         when no wrap column is set.
1568
1569 2019-05-08  Tom Tromey  <tromey@adacore.com>
1570
1571         * c-lang.c (c_get_string): Handle non-C-style arrays.
1572
1573 2019-05-08  Tom Tromey  <tromey@adacore.com>
1574
1575         * typeprint.c (print_offset_data::update): Print the bit offset,
1576         not the number of bits remaining.
1577
1578 2019-05-08  Tom Tromey  <tromey@adacore.com>
1579
1580         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1581         padding at end of comment.
1582
1583 2019-05-08  Tom Tromey  <tromey@adacore.com>
1584
1585         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1586         Compare main types.
1587
1588 2019-05-06  Tom Tromey  <tom@tromey.com>
1589
1590         * common/scoped_mmap.c: Include common-defs.h.
1591         * common/scoped_mmap.h: Don't include config.h.
1592
1593 2019-05-04  Tom Tromey  <tom@tromey.com>
1594
1595         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1596         (struct aarch64_call_info): Add initializers.
1597         <si>: Now a std::vector.
1598         (pass_on_stack, aarch64_push_dummy_call): Update.
1599
1600 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1601             Tom Tromey  <tom@tromey.com>
1602
1603         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1604         (ppc_threads): Now a std::vector.  Now static.
1605         (hwdebug_find_thread_points_by_tid)
1606         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1607         Update.
1608
1609 2019-05-04  Tom Tromey  <tom@tromey.com>
1610
1611         * arc-tdep.c (arc_tdesc_init): Return bool.
1612
1613 2019-05-04  Tom Tromey  <tom@tromey.com>
1614
1615         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1616         Use gdb_assert_not_reached.
1617
1618 2019-05-04  Tom Tromey  <tom@tromey.com>
1619
1620         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1621         "false".
1622
1623 2019-05-04  Tom Tromey  <tom@tromey.com>
1624
1625         * arc-tdep.c (arc_tdesc_init): Use bool.
1626
1627 2019-05-04  Tom Tromey  <tom@tromey.com>
1628
1629         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1630
1631 2019-05-04  Tom Tromey  <tom@tromey.com>
1632
1633         * cli/cli-cmds.c (valid_command_p): Return bool.
1634
1635 2019-05-04  Tom Tromey  <tom@tromey.com>
1636
1637         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1638         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1639
1640 2019-05-04  Raul Tambre  <raul@tambre.ee>
1641
1642         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1643         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1644         operator for comparison.
1645
1646 2019-05-04  Tom Tromey  <tom@tromey.com>
1647
1648         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1649         (lookup_partial_symbol, print_partial_symbols)
1650         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1651         (psymbol_compare): Update.
1652         (add_psymbol_to_bcache): Clear the entire psymbol.
1653         (maintenance_check_psymtabs): Update.
1654         * psympriv.h (struct partial_symbol): Don't derive from
1655         general_symbol_info.
1656         <obj_section, unrelocated_address, address,
1657         set_unrelocated_address>: Update.
1658         <ginfo>: New member.
1659         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1660         (debug_names::write_psymbols): Update.
1661
1662 2019-05-04  Tom de Vries  <tdevries@suse.de>
1663
1664         * contrib/cc-with-tweaks.sh: Support -n arg.
1665
1666 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         * corelow.c (core_target::detach): Ensure frame cache and
1669         register caches are cleared.
1670         inferior.c (exit_inferior_1): Likewise.
1671
1672 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1673             Tom Tromey  <tom@tromey.com>
1674
1675         * dictionary.c (collate_pending_symbols_by_language): Remove
1676         "struct" from foreach.
1677         * symtab.c (lookup_global_symbol_from_objfile)
1678         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1679         foreach.
1680         * ser-tcp.c (net_open): Remove "struct" from foreach.
1681         * objfiles.c (objfile_relocate, objfile_rebase)
1682         (objfile_has_symbols): Remove "struct" from foreach.
1683         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1684         from foreach.
1685         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1686         foreach.
1687         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1688         "struct" from foreach.
1689         * ada-lang.c (create_excep_cond_exprs)
1690         (ada_exception_catchpoint_cond_string): Remove "struct" from
1691         foreach.
1692
1693 2019-05-03  Tom Tromey  <tromey@adacore.com>
1694
1695         * ada-exp.y (convert_char_literal): Check suffix of each
1696         enumerator.
1697
1698 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1699
1700         PR ada/21406:
1701         * ada-exp.y (yywrap): Don't define.
1702         * ada-lex.l (%option): Add noyywrap
1703         (yywrap): Remove.
1704
1705 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1706
1707         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1708         _WIN32_WINNT to the XP level, unless already defined to a higher
1709         level.
1710
1711         * unittests/parse-connection-spec-selftests.c:
1712         * ser-tcp.c:
1713         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1714         override.
1715
1716         * symfile.c (find_separate_debug_file): Remove colon from the
1717         drive spec of DOS/Windows file names of the target, so that the
1718         file name produced from DEBUGDIR and the target's directory will
1719         be valid on DOS/Windows systems.
1720
1721 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1722
1723         * rust-lang.c (val_print_struct): Handle printing structures
1724         containing strings.
1725
1726 2019-05-02  Tom Tromey  <tromey@adacore.com>
1727
1728         * valarith.c (_initialize_valarith): Remove.
1729
1730 2019-05-01  Tom Tromey  <tromey@adacore.com>
1731
1732         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1733         bitfields.
1734
1735 2019-05-01  Tom Tromey  <tromey@adacore.com>
1736
1737         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1738         for big-endian copies.
1739
1740 2019-04-30  Ali Tamur  <tamur@google.com>
1741         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1742         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1743         (read_3_bytes): New function.
1744
1745 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1746
1747         * windows-nat.c (main_thread_id): Delete.
1748         (handle_output_debug_string): Replace main_thread_id by
1749         current_event.dwThreadId.
1750         (fake_create_process): Likewise.
1751         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1752         Do not set main_thread_id.
1753         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1754         current_event.dwThreadId.
1755         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1756
1757 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1758
1759         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1760         Use current_event.dwThreadId instead of main_thread_id.
1761
1762 2019-04-30  Tom Tromey  <tromey@adacore.com>
1763
1764         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1765         (create_excep_cond_exprs): Iterate over program spaces.
1766         (ada_exception_catchpoint_cond_string): Examine all minimal
1767         symbols for exception types.
1768
1769 2019-04-30  Tom Tromey  <tromey@adacore.com>
1770
1771         PR c++/24470:
1772         * dwarf2read.c (process_structure_scope): Handle case where type
1773         has template parameters but no symbol was created.
1774
1775 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1776             Chris January  <chris.january@arm.com>
1777
1778         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1779         qualifier.
1780         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1781
1782 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1783
1784         * f-typeprint.c (f_print_type): Update rules for printing
1785         whitespace.
1786         (f_type_print_varspec_suffix): Likewise.
1787
1788 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1789             Chris January  <chris.january@arm.com>
1790
1791         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1792         function arguments.
1793
1794 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * f-lang.c (build_fortran_types): Change name of void type to
1797         lower case.
1798         * f-typeprint.c (f_type_print_base): Print the name of the void
1799         type, rather than a fixed string.
1800         * f-valprint.c (f_decorations): Use lower case void string.
1801
1802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1803             Chris January  <chris.january@arm.com>
1804
1805         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1806         types for Fortran.
1807
1808 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1809             Chris January  <chris.january@arm.com>
1810             David Lecomber  <david.lecomber@arm.com>
1811
1812         * f-exp.y (BINOP_INTRINSIC): New token.
1813         (exp): New parser rule handling BINOP_INTRINSIC.
1814         (f77_keywords): Add new builtin procedures.
1815         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1816         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1817         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1818         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1819         (print_unop_subexp_f): New function.
1820         (print_binop_subexp_f): New function.
1821         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1822         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1823         (dump_subexp_body_f): Likewise.
1824         (operator_check_f): Likewise.
1825         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1826         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1827
1828 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1829
1830         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1831         UNOP_KIND.
1832         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1833         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1834         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1835         (operator_length_f): New fuction.
1836         (print_subexp_f): New function.
1837         (op_name_f): New function.
1838         (dump_subexp_body_f): New function.
1839         (operator_check_f): New function.
1840         (exp_descriptor_f): Replace standard expression handling functions
1841         with new functions.
1842         * gdb/fortran-operator.def: New file.
1843         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1844         * gdb/std-operator.def: Remove UNOP_KIND.
1845
1846 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * std-operator.def: Remove unbalanced, stray double quote
1849         character.
1850
1851 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1852             Chris January  <chris.january@arm.com>
1853             Daniel Everett  <daniel.everett@arm.com>
1854             Nick Forrington  <nick.forrington@arm.com>
1855             Richard Bunt  <richard.bunt@arm.com>
1856
1857         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1858         of depth when printing anonymous structs or unions.
1859         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1860         Don't print either the top-level value, or the children if the
1861         max-depth is exceeded.
1862         (ppscm_print_children): When printing the key of a map, allow one
1863         extra level of depth.
1864         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1865         print either the top-level value, or the children if the max-depth
1866         is exceeded.
1867         (print_children): When printing the key of a map, allow one extra
1868         level of depth.
1869         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1870         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1871         (user_print_options): Initialise max_depth field.
1872         (val_print_scalar_or_string_type_p): New function.
1873         (val_print): Check to see if the max depth has been reached.
1874         (val_print_check_max_depth): Define new function.
1875         (show_print_max_depth): New function.
1876         (_initialize_valprint): Add 'print max-depth' option.
1877         * valprint.h (struct value_print_options) <max_depth>: New field.
1878         (val_print_check_max_depth): Declare new function.
1879         * NEWS: Document new feature.
1880
1881 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1882
1883         * ada-lang.c (ada_language_defn): Initialise new field.
1884         * c-lang.c (c_is_string_type_p): New function.
1885         (c_language_defn): Initialise new field.
1886         (cplus_language_defn): Initialise new field.
1887         (asm_language_defn): Initialise new field.
1888         (minimal_language_defn): Initialise new field.
1889         * c-lang.h (c_is_string_type_p): Declare new function.
1890         * d-lang.c (d_language_defn): Initialise new field.
1891         * f-lang.c (f_is_string_type_p): New function.
1892         (f_language_defn): Initialise new field.
1893         * go-lang.c (go_is_string_type_p): New function.
1894         (go_language_defn): Initialise new field.
1895         * language.c (default_is_string_type_p): New function.
1896         (unknown_language_defn): Initialise new field.
1897         (auto_language_defn): Initialise new field.
1898         * language.h (struct language_defn) <la_is_string_type_p>: New
1899         member variable.
1900         (default_is_string_type_p): Declare new function.
1901         * m2-lang.c (m2_language_defn): Initialise new field.
1902         * objc-lang.c (objc_language_defn): Initialise new field.
1903         * opencl-lang.c (opencl_language_defn): Initialise new field.
1904         * p-lang.c (pascal_is_string_type_p): New function.
1905         (pascal_language_defn): Initialise new field.
1906         * rust-lang.c (rust_is_string_type_p): New function.
1907         (rust_language_defn): Initialise new field.
1908
1909 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1910
1911         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1912         New field.
1913         * ada-lang.c (ada_language_defn): Initialise new field.
1914         * c-lang.c (c_language_defn): Likewise.
1915         (cplus_language_defn): Likewise.
1916         (asm_language_defn): Likewise.
1917         (minimal_language_defn): Likewise.
1918         * d-lang.c (d_language_defn): Likewise.
1919         * f-lang.c (f_language_defn): Likewise.
1920         * go-lang.c (go_language_defn): Likewise.
1921         * language.c (unknown_language_defn): Likewise.
1922         (auto_language_defn): Likewise.
1923         * m2-lang.c (m2_language_defn): Likewise.
1924         * objc-lang.c (objc_language_defn): Likewise.
1925         * opencl-lang.c (opencl_language_defn): Likewise.
1926         * p-lang.c (pascal_language_defn): Likewise.
1927         * rust-lang.c (rust_language_defn): Likewise.
1928
1929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1930
1931         * ada-lang.c (ada_is_character_type): Change return type to bool.
1932         (ada_is_string_type): Likewise.
1933         * ada-lang.h (ada_is_character_type): Update declaration
1934         (ada_is_string_type): Likewise.
1935
1936 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1937
1938         Support style in 'frame|thread apply'
1939
1940         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1941         * record.c (record_start, record_stop): Update callers of
1942         execute_command_to_string with false.
1943         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1944         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1945         methods.
1946         (class string_file): New constructor with term_out parameter.
1947         Override methods term_out and can_emit_style_escape.  New member
1948         term_out.
1949         (class stdio_file): Override can_emit_style_escape.
1950         (class tee_file): Override term_out and can_emit_style_escape.
1951         * utils.h (can_emit_style_escape): Remove.
1952         * utils.c (can_emit_style_escape): Likewise.
1953         Update all callers of can_emit_style_escape (SOMESTREAM) to
1954         SOMESTREAM->can_emit_style_escape.
1955         * source-cache.c (source_cache::get_source_lines): Likewise.
1956         * stack.c (frame_apply_command_count): Call execute_command_to_string
1957         passing the term_out characteristic of the current gdb_stdout.
1958         * thread.c (thr_try_catch_cmd): Likewise.
1959         * top.c (execute_command_to_string): pass term_out parameter
1960         to construct the string_file for the command output.
1961         * ui-file.c (term_cli_styling): New function (most code moved
1962         from utils.c can_emit_style_escape).
1963         (string_file::string_file, string_file::can_emit_style_escape,
1964         stdio_file::can_emit_style_escape, tee_file::term_out,
1965         tee_file::can_emit_style_escape): New functions.
1966
1967 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1968
1969         * NEWS: Mention the new set|show may-call-functions.
1970         * infcall.c (may_call_functions_p): New variable.
1971         (show_may_call_functions_p): New function.
1972         (call_function_by_hand_dummy): Throws an error if not
1973         may-call-functions.
1974         (_initialize_infcall): Call add_setshow_boolean_cmd for
1975         may-call-functions.
1976
1977 2019-04-25  Keith Seitz  <keiths@redhat.com>
1978
1979         PR c++/24367
1980         * cp-support.c (inspect_type): Don't attempt substitutions
1981         of symbol with the same name.
1982
1983 2019-04-25  Tom Tromey  <tromey@adacore.com>
1984
1985         PR gdb/24475:
1986         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1987         static.
1988
1989 2019-04-25  Tom Tromey  <tromey@adacore.com>
1990
1991         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1992         rvalue reference.
1993         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1994         (gdb_xml_parser::parse): Use std::move.
1995         * python/python-internal.h (gdbpy_convert_exception): Take a const
1996         reference.
1997         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1998         std::move.
1999         * python/py-utils.c (gdbpy_convert_exception): Take a const
2000         reference.
2001         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2002         Use std::move.
2003         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2004         Use std::move.
2005         * mi/mi-main.c (mi_print_exception): Take a const reference.
2006         * main.c (handle_command_errors): Take a const reference.
2007         * linespec.c (parse_linespec): Use std::move.
2008         * infcall.c (run_inferior_call): Use std::move.
2009         (call_function_by_hand_dummy): Use std::move.
2010         * exec.c (try_open_exec_file): Use std::move.
2011         * exceptions.h (exception_print, exception_fprintf)
2012         (exception_print_same): Update.
2013         * exceptions.c (print_exception, exception_print)
2014         (exception_fprintf, exception_print_same): Change parameters to
2015         const reference.
2016         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2017         * common/new-op.c: Use std::move.
2018         * common/common-exceptions.h (struct gdb_exception): Add move
2019         constructor.
2020         (struct gdb_exception_error, struct gdb_exception_quit, struct
2021         gdb_quit_bad_alloc): Change constructor to move constructor.
2022         (throw_exception): Change parameter to rvalue reference.
2023         * common/common-exceptions.c (throw_exception): Take rvalue
2024         reference.
2025         * cli/cli-interp.c (safe_execute_command): Use std::move.
2026         * breakpoint.c (insert_bp_location, location_to_sals): Use
2027         std::move.
2028
2029 2019-04-25  Tom Tromey  <tromey@adacore.com>
2030
2031         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2032         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2033         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2034         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2035         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2036         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2037         guile/scm-value.c: Use unpack.
2038         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2039         gdbscm_gdb_exception.
2040         (gdbscm_throw_gdb_exception): Likewise.
2041         (struct gdbscm_gdb_exception): New.
2042         (unpack): New function.
2043         (gdbscm_wrap): Use unpack.
2044
2045 2019-04-25  Tom Tromey  <tromey@adacore.com>
2046
2047         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2048         (gdb_rl_callback_handler): Use std::move.
2049         * common/common-exceptions.h (struct gdb_exception): Add move
2050         assignment operator.
2051         (throw_exception_sjlj): Change "exception" to const reference.
2052         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2053         (throw_exception_sjlj): Change "exception" to const reference.
2054
2055 2019-04-25  Tom Tromey  <tromey@adacore.com>
2056
2057         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2058         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2059         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2060         Update.
2061         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2062         Update.
2063         * mi/mi-interp.c (mi_interp::exec): Update.
2064         * linespec.c (parse_linespec): Update.
2065         * infcall.c (run_inferior_call): Update.
2066         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2067         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2068         (gdbscm_lookup_global_symbol): Update.
2069         * guile/scm-param.c (gdbscm_parameter_value): Update.
2070         * guile/scm-frame.c (gdbscm_frame_read_register)
2071         (gdbscm_frame_read_var): Update.
2072         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2073         * exec.c (try_open_exec_file): Update.
2074         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2075         (gdb_rl_callback_handler): Update.
2076         * common/common-exceptions.h (exception_none): Don't declare.
2077         * common/common-exceptions.c (exception_none): Don't define.
2078         (struct catcher) <exception>: Update.
2079         * cli/cli-interp.c (safe_execute_command): Update.
2080         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2081
2082 2019-04-25  Ali Tamur  <tamur@google.com>
2083
2084         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2085         (read_attribute_value): Likewise.
2086         (dwarf2_read_addr_index): Update comment.
2087         (read_str_index): Add DW_FORM_strx.
2088         (dwarf2_string_attr): Likewise.
2089         (dwarf2_const_value_attr): Likewise.
2090         (dump_die_shallow): Likewise.
2091         (dwarf2_fetch_constant_bytes): Likewise.
2092         (skip_form_bytes): Likewise.
2093         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2094
2095 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2096
2097         PR corefiles/11608
2098         PR corefiles/18187
2099         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2100         OFFSET.  Verify if current mapping contains an ELF header.
2101         (linux_find_memory_regions_full): Adjust call to
2102         dump_mapping_p.
2103
2104 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2105             Kang Li <kanglictf@gmail.com>
2106
2107         PR gdb/21600
2108
2109         * dwarf2-frame.c (read_initial_length): Be consistent about using
2110         unsigned representation of length.
2111         (decode_frame_entry_1): Likewise.  Check for wraparound of
2112         end pointer as well as buffer overflow.
2113
2114 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2115
2116         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2117         "vq".
2118
2119 2019-04-24  Tom Tromey  <tromey@adacore.com>
2120
2121         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2122
2123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * s12z-tdep.c (s12z_unwind_pc): Delete.
2126         (s12z_unwind_sp): Delete.
2127         (s12z_gdbarch_init): Don't register deleted functions with
2128         gdbarch.
2129
2130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         * rl78-tdep.c (rl78_unwind_sp): Delete.
2133         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2134
2135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2136
2137         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2138         (xstormy16_unwind_pc): Delete.
2139         (xstormy16_dummy_id): Delete.
2140         (xstormy16_gdbarch_init): Don't register deleted functions with
2141         gdbarch.
2142
2143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2144
2145         * vax-tdep.c (vax_unwind_pc): Delete.
2146         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2147
2148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * v850-tdep.c (v850_unwind_sp): Delete.
2151         (v850_unwind_pc): Delete.
2152         (v850_dummy_id): Delete.
2153         (v850_gdbarch_init): Don't register deleted functions with
2154         gdbarch.
2155
2156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2159         (tilegx_unwind_pc): Delete.
2160         (tilegx_unwind_dummy_id): Delete.
2161         (tilegx_gdbarch_init): Don't register deleted functions with
2162         gdbarch.
2163
2164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2167         (tic6x_dummy_id): Delete.
2168         (tic6x_gdbarch_init): Don't register deleted functions with
2169         gdbarch.
2170
2171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2172
2173         * sparc-tdep.c (sparc_unwind_pc): Delete.
2174         (sparc32_gdbarch_init): Don't register deleted function with
2175         gdbarch.
2176
2177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2178
2179         * sh-tdep.c (sh_unwind_sp): Delete.
2180         (sh_unwind_pc): Delete.
2181         (sh_dummy_id): Delete.
2182         (sh_gdbarch_init): Don't register deleted functions with
2183         gdbarch.
2184
2185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2186
2187         * score-tdep.c (score_unwind_sp): Delete.
2188         (score_unwind_pc): Delete.
2189         (score_dummy_id): Delete.
2190         (score_gdbarch_init): Don't register deleted functions with
2191         gdbarch.
2192
2193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * rx-tdep.c (rx_unwind_pc): Delete.
2196         (rx_unwind_sp): Delete.
2197         (rx_dummy_id): Delete.
2198         (rx_gdbarch_init): Don't register deleted functions with
2199         gdbarch.  Update comment.
2200
2201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2204         (rs6000_dummy_id): Delete.
2205         (rs6000_gdbarch_init): Don't register deleted functions with
2206         gdbarch.
2207
2208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2209
2210         * or1k-tdep.c (or1k_dummy_id): Delete.
2211         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2212
2213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2214
2215         * nios2-tdep.c (nios2_dummy_id): Delete.
2216         (nios2_unwind_sp): Delete.
2217         (nios2_gdbarch_init): Don't register deleted functions with
2218         gdbarch.
2219
2220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2221
2222         * nds32-tdep.c (nds32_dummy_id): Delete.
2223         (nds32_unwind_pc): Delete.
2224         (nds32_unwind_sp): Delete.
2225         (nds32_gdbarch_init): Don't register deleted functions with
2226         gdbarch.
2227
2228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * msp430-tdep.c (msp430_unwind_pc): Delete.
2231         (msp430_unwind_sp): Delete.
2232         (msp430_dummy_id): Delete.
2233         (msp430_gdbarch_init): Don't register deleted functions with
2234         gdbarch.
2235
2236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * moxie-tdep.c (moxie_unwind_sp): Delete.
2239         (moxie_unwind_pc): Delete.
2240         (moxie_dummy_id): Delete.
2241         (moxie_gdbarch_init): Don't register deleted functions with
2242         gdbarch.
2243
2244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2245
2246         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2247         (mn10300_unwind_pc): Delete.
2248         (mn10300_unwind_sp): Delete.
2249         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2250         mn10300_unwind_sp.
2251         (mn10300_frame_unwind_init): Don't register deleted functions with
2252         gdbarch.
2253
2254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2255
2256         * mep-tdep.c (mep_unwind_pc): Delete.
2257         (mep_unwind_sp): Delete.
2258         (mep_dummy_id): Delete.
2259         (mep_gdbarch_init): Don't register deleted functions with
2260         gdbarch.
2261
2262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2265         (m68hc11_unwind_sp): Delete.
2266         (m68hc11_gdbarch_init): Don't register deleted functions with
2267         gdbarch.
2268
2269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * m32r-tdep.c (m32r_unwind_sp): Delete.
2272         (m32r_unwind_pc): Delete.
2273         (m32r_dummy_id): Delete.
2274         (m32r_gdbarch_init): Don't register deleted functions with
2275         gdbarch.
2276
2277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2278
2279         * m32c-tdep.c (m32c_unwind_pc): Delete.
2280         (m32c_unwind_sp): Delete.
2281         (m32c_dummy_id): Delete.
2282         (m32c_gdbarch_init): Don't register deleted functions with
2283         gdbarch.
2284
2285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2288         (lm32_unwind_pc): Delete.
2289         (lm32_dummy_id): Delete.
2290         (lm32_gdbarch_init): Don't register deleted functions with
2291         gdbarch.
2292
2293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2296         (iq2000_unwind_pc): Delete.
2297         (iq2000_dummy_id): Delete.
2298         (iq2000_gdbarch_init): Don't register deleted functions with
2299         gdbarch.
2300
2301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2302
2303         * nds32-tdep.c (nds32_type_align): Delete.
2304         (nds32_push_dummy_call): Use type_align instead.
2305
2306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * arm-tdep.c (arm_type_align): Only handle vector override case.
2309         (arm_push_dummy_call): Use type_align.
2310         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2311
2312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2315         case.
2316         (pass_on_stack): Use type_align.
2317         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2318         function.
2319
2320 2019-04-23  Tom Tromey  <tromey@adacore.com>
2321
2322         * dwarf2read.c (line_header::file_name_at): Remove unused
2323         overload.
2324
2325 2019-04-23  Tom de Vries  <tdevries@suse.de>
2326
2327         PR gdb/24438
2328         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2329         invocation.
2330
2331
2332 2019-03-27  Ali Tamur  <tamur@google.com>
2333
2334         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2335         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2336         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2337         (dwarf_expr_context::get_addr_index): Likewise
2338         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2339         (symbol_needs_eval_context::get_addr_index): Likewise
2340         (disassemble_dwarf_expression): Add DW_OP_addrx
2341         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2342         (read_cutu_die_from_dwo): Update comment
2343         (skip_one_die): Add DW_FORM_addrx
2344         (read_attribute_value): Likewise
2345         (var_decode_location): Add DW_OP_addrx
2346         (dwarf2_const_value_attr): Add DW_FORM_addrx
2347         (dump_die_shallow): Likewise
2348         (dwarf2_fetch_constant_bytes): Likewise
2349         (decode_locdesc): Add DW_OP_addrx
2350         (skip_form_bytes): Add DW_FORM_addrx
2351
2352 2019-04-22  Ali Tamur  <tamur@google.com>
2353
2354         * MAINTAINERS (Write After Approval): Add self.
2355
2356 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2357
2358         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2359         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2360         (open_symbol_file_object): Likewise.
2361         (svr4_default_sos): Add info parameter.
2362         (svr4_read_so_list): Likewise.
2363         (svr4_current_sos_direct): Adjust functions calls to pass down
2364         info.
2365         (svr4_current_sos_1): Add info parameter.
2366         (svr4_current_sos): Call get_svr4_info, pass info down to
2367         svr4_current_sos_1.
2368         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2369         get_svr4_info.
2370         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2371         get_svr4_info.
2372         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2373         to get_svr4_info.
2374         (probes_table_remove_objfile_probes): Likewise.
2375         (register_solib_event_probe): Add info parameter.
2376         (solist_update_incremental): Pass info parameter down to
2377         svr4_read_so_list.
2378         (disable_probes_interface): Add info parameter.
2379         (svr4_handle_solib_event): Pass current_program_space to
2380         get_svr4_info.  Adjust disable_probes_interface cleanup.
2381         (svr4_create_probe_breakpoints): Add info parameter, pass it
2382         down to register_solib_event_probe.
2383         (svr4_create_solib_event_breakpoints): Add info parameter,
2384         pass it down to svr4_create_probe_breakpoints.
2385         (enable_break): Pass info down to
2386         svr4_create_solib_event_breakpoints.
2387         (svr4_solib_create_inferior_hook): Pass current_program_space to
2388         get_svr4_info.
2389         (svr4_clear_solib): Likewise.
2390
2391 2019-04-22  Pedro Alves  <palves@redhat.com>
2392
2393         * solib-svr4.c (svr4_free_objfile_observer): New.
2394         (probe_and_action::objfile): New field.
2395         (probes_table_htab_remove_objfile_probes)
2396         (probes_table_remove_objfile_probes): New functions.
2397         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2398         in the new probe_and_action.  Don't store the probe in 'lookup'.
2399         (svr4_create_probe_breakpoints): Pass objfile to
2400         register_solib_event_probe.
2401         (_initialize_svr4_solib): Register a free_objfile observer.
2402
2403 2019-04-19  Tom Tromey  <tom@tromey.com>
2404
2405         * common/queue.h: Remove.
2406
2407 2019-04-19  Tom Tromey  <tom@tromey.com>
2408
2409         * event-loop.c: Don't include "common/queue.h".
2410
2411 2019-04-19  Tom Tromey  <tom@tromey.com>
2412
2413         * remote.c (remote_target): Use delete.
2414         * remote-notif.h: Include <list>, not "common/queue.h".
2415         (notif_client_p): Remove typedef.
2416         (remote_notif_state): Add constructor, destructor, initializer.
2417         <notif_queue>: Now a std::list.
2418         (remote_notif_state_xfree): Don't declare.
2419         * remote-notif.c (remote_notif_process, handle_notification)
2420         (remote_notif_state_allocate): Update.
2421         (~remote_notif_state): Rename from remote_notif_state_xfree.
2422
2423 2019-04-19  Tom Tromey  <tom@tromey.com>
2424
2425         * symfile.c (reread_symbols): Update.
2426         * objfiles.c (objfile_register_static_link)
2427         (objfile_lookup_static_link): Update
2428         (~objfile) Don't delete static_links.
2429         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2430
2431 2019-04-19  Tom Tromey  <tom@tromey.com>
2432
2433         * type-stack.h (struct type_stack) <insert>: Constify string.
2434         * type-stack.c (type_stack::insert): Constify string.
2435         * gdbtypes.h (lookup_template_type): Update.
2436         (address_space_name_to_int): Update.
2437         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2438         const.
2439         (lookup_template_type): Make name const.
2440         * c-exp.y: Update rules.
2441         (lex_one_token, classify_name, classify_inner_name)
2442         (c_print_token): Update.
2443         * p-exp.y: Update rules.
2444         (yylex): Update.
2445         * f-exp.y: Update rules.
2446         (yylex): Update.
2447         * d-exp.y: Update rules.
2448         (lex_one_token, classify_name, classify_inner_name): Update.
2449         * parse.c (write_dollar_variable, copy_name): Return std::string.
2450         * parser-defs.h (copy_name): Change return type.
2451         * m2-exp.y: Update rules.
2452         (yylex): Update.
2453         * go-exp.y (lex_one_token): Update.
2454         Update rules.
2455         (classify_unsafe_function, classify_packaged_name)
2456         (classify_name, yylex): Update.
2457
2458 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2459
2460         * configure.ac: add --enable-source-highlight switch.
2461         * configure: Regenerate.
2462         * top.c (print_gdb_version): plumb --enable-source-highlight
2463         status to "show configuration".
2464
2465 2019-04-19  Tom Tromey  <tromey@adacore.com>
2466
2467         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2468         Check ADA_TYPE_P.
2469         (empty_record, ada_template_to_fixed_record_type_1)
2470         (template_to_static_fixed_type)
2471         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2472         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2473         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2474         macros.
2475
2476 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2477
2478         PR symtab/24423:
2479         * source.c (print_source_lines_base): Advance "iter" when a
2480         control character is seen.
2481
2482 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2483
2484         * inferior.h (struct infcall_suspend_state_deleter):
2485         Catch exception in destructor to avoid crash.
2486
2487 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2488
2489         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2490         close to the add_com "shell".
2491
2492 2019-04-18  Tom Tromey  <tromey@adacore.com>
2493
2494         * process-stratum-target.h (class process_stratum_target)
2495         <stratum>: Add "final".
2496
2497 2019-04-17  Tom Tromey  <tromey@adacore.com>
2498
2499         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2500         against nullptr before use.
2501
2502 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2503
2504         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2505
2506 2019-04-17  Jim Wilson  <jimw@sifive.com>
2507             Andrew Burgess  <andrew.burgess@embecosm.com>
2508
2509         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2510         code read might fail, assume 4-byte breakpoint in that case.
2511
2512 2019-04-15  Leszek Swirski  <leszeks@google.com>
2513
2514         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2515         rather than a hand-rolled POD check when checking for forced MEMORY
2516         classification.
2517
2518 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2519
2520         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2521         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2522         function.
2523         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2524         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2525         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2526         declaration.
2527
2528 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2529
2530         * aarch64-linux-nat.c
2531         (aarch64_linux_nat_target::thread_architecture): Add override.
2532         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2533         each VQ.
2534
2535 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2536
2537         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2538
2539 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2542         target types of size 96-bits, add some additional comments, and
2543         check that the builtin type we found was the correct size.
2544
2545 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2546
2547         * utils.c (prompt_for_continue): Don't restore the styling at the
2548         end, as applied_style has the wrong value.  This fixes styling in
2549         long lists of file names that are interrupted by the "Continue?"
2550         prompt.
2551
2552 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2555         * c-lang.c (c_language_defn): Likewise.
2556         (cplus_language_defn): Likewise.
2557         (asm_language_defn): Likewise.
2558         (minimal_language_defn): Likewise.
2559         * d-lang.c (d_language_defn): Likewise.
2560         * f-lang.c (f_language_defn): Likewise.
2561         * go-lang.c (go_language_defn): Likewise.
2562         * language.c (unknown_language_defn): Likewise.
2563         (auto_language_defn): Likewise.
2564         * language.h (struct language_defn): Remove la_magic field.
2565         (LANG_MAGIC): Delete.
2566         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2567         * objc-lang.c (objc_language_defn): Likewise.
2568         * opencl-lang.c (opencl_language_defn): Likewise.
2569         * p-lang.c (pascal_language_defn): Likewise.
2570         * rust-lang.c (rust_language_defn): Likewise.
2571
2572 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         * riscv-tdep.c (riscv_type_align): New function.
2575         (riscv_type_alignment): Delete.
2576         (riscv_arg_location): Use 'type_align'.
2577         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2578
2579 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2580
2581         * gdbtypes.c (type_align): A struct with no non-static fields also
2582         has alignment of 1.
2583
2584 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2585
2586         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2587         component to 0.
2588         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2589         member.
2590         (riscv_struct_info::analyse): New implementation using new
2591         analyse_inner member function.
2592         (riscv_struct_info::field_offset): New member function.
2593         (riscv_struct_info::m_offsets): New member variable.
2594         (riscv_struct_info::analyse_inner): New private member function,
2595         takes the old implementation of riscv_struct_info::analyse but
2596         extended to track field offsets.
2597         (riscv_call_arg_struct): Update the struct folding special cases
2598         to handle cases where empty C++ structs, which are non-zero
2599         length, are found.
2600         (riscv_arg_location): Initialise the length of each location, a
2601         non-zero length now indicates the location is in use.
2602         (riscv_push_dummy_call): Allow for the first location having a
2603         non-zero offset when setting up arguments.
2604         (riscv_return_value): Likewise, but for return values.
2605
2606 2019-04-11  Tom Tromey  <tromey@adacore.com>
2607
2608         * utils.c (internal_vproblem): Make "msg" const.
2609
2610 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2611
2612         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2613         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2614         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2615         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2616
2617 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2618
2619         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2620         function.
2621         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2622         of amd64_collect_native_gregset.
2623         (amd64_linux_nat_target::store_registers): Likewise.
2624
2625 2019-04-10  Tom Tromey  <tom@tromey.com>
2626
2627         * symtab.c (lookup_global_symbol_from_objfile)
2628         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2629         * objfiles.h (class separate_debug_iterator): New.
2630         (class separate_debug_range): New.
2631         (struct objfile) <separate_debug_objfiles>: New method.
2632         (objfile_separate_debug_iterate): Don't declare.
2633         * objfiles.c (separate_debug_iterator::operator++): Rename from
2634         objfile_separate_debug_iterate.
2635         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2636         iterator.
2637         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2638         iterator.
2639
2640 2019-04-10  Tom Tromey  <tom@tromey.com>
2641
2642         * symfile.c (reread_symbols): Remove old comment.
2643         * objfiles.c (free_all_objfiles): Fix a typo.
2644
2645 2019-04-10  Tom Tromey  <tom@tromey.com>
2646
2647         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2648         * minsyms.c (lookup_minimal_symbol): Use foreach.
2649         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2650         (lookup_minimal_symbol_solib_trampoline): Likewise.
2651         * symfile.c (reread_symbols): Use foreach.
2652
2653 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2654             Tom Tromey  <tromey@adacore.com>
2655
2656         PR rust/24414:
2657         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2658         (rust_lex_int_test): Change "value" to be LONGEST.
2659         (rust_lex_tests): Add test for long integer literal.
2660
2661 2019-04-09  Tom Tromey  <tromey@adacore.com>
2662
2663         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2664         to bool.
2665         (extended_remote_target::attach): Update.
2666         (remote_target::remote_notice_new_inferior): Update.
2667         (remote_target::add_current_inferior_and_thread): Update.
2668         * inferior.c (exit_inferior_1): Use "false".
2669         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2670
2671 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2672
2673         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2674         the "start" command.
2675
2676 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2677
2678         * python/py-inferior.c (infpy_thread_from_thread_handle):
2679         Adjust comments to reflect renaming of thread_from_thread_handle
2680         to thread_from_handle.  Adjust keywords.  Fix type error message.
2681         (inferior_object_methods): Add thread_from_handle.  Retain
2682         thread_from_thread_handle, but mark it as deprecated.
2683
2684 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2685
2686         * gdbthread.h (find_thread_by_handle): Revise declaration.
2687         * thread.c (find_thread_by_handle): Likewise.  Adjust
2688         implementation too.
2689         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2690         support for buffer objects as handles.
2691
2692 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2693
2694         * python/py-infthread.c (thpy_thread_handle): New function.
2695         (thread_object_methods): Register thpy_thread_handle.
2696
2697 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2698
2699         * gdbthread.h (thread_to_thread_handle): Declare.
2700         * thread.c (gdbtypes.h): Include.
2701         (thread_to_thread_handle): New function.
2702
2703         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2704         (target_thread_info_to_thread_handle): Declare.
2705         * target.c (target_thread_info_to_thread_handle): New function.
2706         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2707         * target-delegates.c: Regenerate.
2708
2709         * linux-thread-db.c (class thread_db_target): Add method
2710         thread_info_to_thread_handle.
2711         (thread_db_target::thread_info_to_thread_handle): Define.
2712         * remote.c (class remote_target): Add new method
2713         thread_info_to_thread_handle.
2714         (remote_target::thread_info_to_thread_handle): Define.
2715
2716 2019-04-08  Pedro Alves  <palves@redhat.com>
2717
2718         * common/common-exceptions.c (throw_exception): Don't create
2719         named object to throw; throw directly.
2720         (throw_it): Likewise.  Don't initialize gdb_exception::message
2721         here, with new; pass FMT and AP to the ctor instead.
2722         * common/common-exceptions.h: Include <string>.
2723         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2724         const char *, va_list)): New ctor.  Use std::make_shared.
2725         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2726         errors)): Delete.
2727         (gdb_exception_error::gdb_exception_error(enum errors, const char
2728         *, va_list)): New.
2729         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2730         Add assertion.
2731         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2732         errors)): Delete.
2733         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2734         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2735         Add assertion.
2736
2737 2019-04-08  Tom Tromey  <tom@tromey.com>
2738
2739         * valops.c (value_rtti_indirect_type): Replace throw_exception
2740         with throw.
2741         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2742         with throw.
2743         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2744         throw.
2745         * target.c (target_translate_tls_address): Replace throw_exception
2746         with throw.
2747         * stack.c (frame_apply_command_count): Replace throw_exception
2748         with throw.
2749         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2750         throw.
2751         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2752         with throw.
2753         * rs6000-tdep.c (rs6000_frame_cache)
2754         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2755         * remote.c: Replace throw_exception with throw.
2756         * record-full.c (record_full_message, record_full_wait_1)
2757         (record_full_restore): Replace throw_exception with throw.
2758         * record-btrace.c:
2759         (get_thread_current_frame_id, record_btrace_start_replaying)
2760         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2761         (cmd_record_btrace_start): Replace throw_exception with throw.
2762         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2763         throw.
2764         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2765         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2766         * linespec.c:
2767         (find_linespec_symbols): Replace throw_exception with throw.
2768         * infrun.c (displaced_step_prepare, resume): Replace
2769         throw_exception with throw.
2770         * infcmd.c (post_create_inferior): Replace throw_exception with
2771         throw.
2772         * inf-loop.c (inferior_event_handler): Replace throw_exception
2773         with throw.
2774         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2775         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2776         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2777         (get_prev_frame_always, get_frame_pc_if_available)
2778         (get_frame_address_in_block_if_available, get_frame_language):
2779         Replace throw_exception with throw.
2780         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2781         throw_exception with throw.
2782         * eval.c (fetch_subexp_value, evaluate_var_value)
2783         (evaluate_funcall, evaluate_subexp_standard): Replace
2784         throw_exception with throw.
2785         * dwarf2loc.c (call_site_find_chain)
2786         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2787         Replace throw_exception with throw.
2788         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2789         with throw.
2790         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2791         throw.
2792         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2793         * completer.c (complete_line_internal): Replace throw_exception
2794         with throw.
2795         * compile/compile-object-run.c (compile_object_run): Replace
2796         throw_exception with throw.
2797         * cli/cli-script.c (process_next_line): Replace throw_exception
2798         with throw.
2799         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2800         (btrace_enable, btrace_maint_update_pt_packets): Replace
2801         throw_exception with throw.
2802         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2803         throw_exception with throw.
2804         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2805         throw_exception with throw.
2806         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2807         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2808         * aarch64-tdep.c (aarch64_make_prologue_cache)
2809         (aarch64_make_stub_cache): Replace throw_exception with throw.
2810
2811 2019-04-08  Tom Tromey  <tom@tromey.com>
2812
2813         * common/common-exceptions.c (throw_exception): Rename from
2814         throw_exception_cxx.  Remove old copy.  Make argument const.
2815         (throw_it): Create and throw exception objects directly.
2816         * common/common-exceptions.h (throw_exception): Make argument
2817         const.
2818         (struct gdb_exception_error): Add constructor.
2819         (struct gdb_exception_quit): Add constructor.
2820
2821 2019-04-08  Tom Tromey  <tom@tromey.com>
2822
2823         * common/common-exceptions.h (exception_rethrow): Don't declare.
2824         (TRY_SJLJ): Update comment.
2825         (TRY, CATCH, END_CATCH): Remove.
2826         * common/common-exceptions.c (exception_rethrow): Remove.
2827
2828 2019-04-08  Tom Tromey  <tom@tromey.com>
2829
2830         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2831         Remove.
2832         (gdb_exception_error): Rename from
2833         gdb_exception_RETURN_MASK_ERROR.
2834         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2835         (gdb_quit_bad_alloc): Update.
2836         * aarch64-tdep.c: Update.
2837         * ada-lang.c: Update.
2838         * ada-typeprint.c: Update.
2839         * ada-valprint.c: Update.
2840         * amd64-tdep.c: Update.
2841         * arch-utils.c: Update.
2842         * break-catch-throw.c: Update.
2843         * breakpoint.c: Update.
2844         * btrace.c: Update.
2845         * c-varobj.c: Update.
2846         * cli/cli-cmds.c: Update.
2847         * cli/cli-interp.c: Update.
2848         * cli/cli-script.c: Update.
2849         * common/common-exceptions.c: Update.
2850         * common/new-op.c: Update.
2851         * common/selftest.c: Update.
2852         * compile/compile-c-symbols.c: Update.
2853         * compile/compile-cplus-symbols.c: Update.
2854         * compile/compile-object-load.c: Update.
2855         * compile/compile-object-run.c: Update.
2856         * completer.c: Update.
2857         * corelow.c: Update.
2858         * cp-abi.c: Update.
2859         * cp-support.c: Update.
2860         * cp-valprint.c: Update.
2861         * darwin-nat.c: Update.
2862         * disasm-selftests.c: Update.
2863         * dtrace-probe.c: Update.
2864         * dwarf-index-cache.c: Update.
2865         * dwarf-index-write.c: Update.
2866         * dwarf2-frame-tailcall.c: Update.
2867         * dwarf2-frame.c: Update.
2868         * dwarf2loc.c: Update.
2869         * dwarf2read.c: Update.
2870         * eval.c: Update.
2871         * event-loop.c: Update.
2872         * event-top.c: Update.
2873         * exec.c: Update.
2874         * f-valprint.c: Update.
2875         * fbsd-tdep.c: Update.
2876         * frame-unwind.c: Update.
2877         * frame.c: Update.
2878         * gdbtypes.c: Update.
2879         * gnu-v3-abi.c: Update.
2880         * guile/guile-internal.h: Update.
2881         * guile/scm-block.c: Update.
2882         * guile/scm-breakpoint.c: Update.
2883         * guile/scm-cmd.c: Update.
2884         * guile/scm-disasm.c: Update.
2885         * guile/scm-frame.c: Update.
2886         * guile/scm-lazy-string.c: Update.
2887         * guile/scm-math.c: Update.
2888         * guile/scm-param.c: Update.
2889         * guile/scm-ports.c: Update.
2890         * guile/scm-pretty-print.c: Update.
2891         * guile/scm-symbol.c: Update.
2892         * guile/scm-symtab.c: Update.
2893         * guile/scm-type.c: Update.
2894         * guile/scm-value.c: Update.
2895         * i386-linux-tdep.c: Update.
2896         * i386-tdep.c: Update.
2897         * inf-loop.c: Update.
2898         * infcall.c: Update.
2899         * infcmd.c: Update.
2900         * infrun.c: Update.
2901         * jit.c: Update.
2902         * language.c: Update.
2903         * linespec.c: Update.
2904         * linux-fork.c: Update.
2905         * linux-nat.c: Update.
2906         * linux-tdep.c: Update.
2907         * linux-thread-db.c: Update.
2908         * main.c: Update.
2909         * mi/mi-cmd-break.c: Update.
2910         * mi/mi-cmd-stack.c: Update.
2911         * mi/mi-interp.c: Update.
2912         * mi/mi-main.c: Update.
2913         * objc-lang.c: Update.
2914         * p-valprint.c: Update.
2915         * parse.c: Update.
2916         * ppc-linux-tdep.c: Update.
2917         * printcmd.c: Update.
2918         * python/py-arch.c: Update.
2919         * python/py-breakpoint.c: Update.
2920         * python/py-cmd.c: Update.
2921         * python/py-finishbreakpoint.c: Update.
2922         * python/py-frame.c: Update.
2923         * python/py-framefilter.c: Update.
2924         * python/py-gdb-readline.c: Update.
2925         * python/py-inferior.c: Update.
2926         * python/py-infthread.c: Update.
2927         * python/py-lazy-string.c: Update.
2928         * python/py-linetable.c: Update.
2929         * python/py-objfile.c: Update.
2930         * python/py-param.c: Update.
2931         * python/py-prettyprint.c: Update.
2932         * python/py-progspace.c: Update.
2933         * python/py-record-btrace.c: Update.
2934         * python/py-record.c: Update.
2935         * python/py-symbol.c: Update.
2936         * python/py-type.c: Update.
2937         * python/py-unwind.c: Update.
2938         * python/py-utils.c: Update.
2939         * python/py-value.c: Update.
2940         * python/python.c: Update.
2941         * record-btrace.c: Update.
2942         * record-full.c: Update.
2943         * remote-fileio.c: Update.
2944         * remote.c: Update.
2945         * riscv-tdep.c: Update.
2946         * rs6000-aix-tdep.c: Update.
2947         * rs6000-tdep.c: Update.
2948         * rust-exp.y: Update.
2949         * rust-lang.c: Update.
2950         * s390-tdep.c: Update.
2951         * selftest-arch.c: Update.
2952         * solib-dsbt.c: Update.
2953         * solib-frv.c: Update.
2954         * solib-spu.c: Update.
2955         * solib-svr4.c: Update.
2956         * solib.c: Update.
2957         * sparc64-linux-tdep.c: Update.
2958         * stack.c: Update.
2959         * symfile-mem.c: Update.
2960         * symmisc.c: Update.
2961         * target.c: Update.
2962         * thread.c: Update.
2963         * top.c: Update.
2964         * tracefile-tfile.c: Update.
2965         * tui/tui.c: Update.
2966         * typeprint.c: Update.
2967         * unittests/cli-utils-selftests.c: Update.
2968         * unittests/parse-connection-spec-selftests.c: Update.
2969         * valops.c: Update.
2970         * valprint.c: Update.
2971         * value.c: Update.
2972         * varobj.c: Update.
2973         * windows-nat.c: Update.
2974         * x86-linux-nat.c: Update.
2975         * xml-support.c: Update.
2976
2977 2019-04-08  Tom Tromey  <tom@tromey.com>
2978
2979         * xml-support.c: Use C++ exception handling.
2980         * x86-linux-nat.c: Use C++ exception handling.
2981         * windows-nat.c: Use C++ exception handling.
2982         * varobj.c: Use C++ exception handling.
2983         * value.c: Use C++ exception handling.
2984         * valprint.c: Use C++ exception handling.
2985         * valops.c: Use C++ exception handling.
2986         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2987         handling.
2988         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2989         * typeprint.c: Use C++ exception handling.
2990         * tui/tui.c: Use C++ exception handling.
2991         * tracefile-tfile.c: Use C++ exception handling.
2992         * top.c: Use C++ exception handling.
2993         * thread.c: Use C++ exception handling.
2994         * target.c: Use C++ exception handling.
2995         * symmisc.c: Use C++ exception handling.
2996         * symfile-mem.c: Use C++ exception handling.
2997         * stack.c: Use C++ exception handling.
2998         * sparc64-linux-tdep.c: Use C++ exception handling.
2999         * solib.c: Use C++ exception handling.
3000         * solib-svr4.c: Use C++ exception handling.
3001         * solib-spu.c: Use C++ exception handling.
3002         * solib-frv.c: Use C++ exception handling.
3003         * solib-dsbt.c: Use C++ exception handling.
3004         * selftest-arch.c: Use C++ exception handling.
3005         * s390-tdep.c: Use C++ exception handling.
3006         * rust-lang.c: Use C++ exception handling.
3007         * rust-exp.y: Use C++ exception handling.
3008         * rs6000-tdep.c: Use C++ exception handling.
3009         * rs6000-aix-tdep.c: Use C++ exception handling.
3010         * riscv-tdep.c: Use C++ exception handling.
3011         * remote.c: Use C++ exception handling.
3012         * remote-fileio.c: Use C++ exception handling.
3013         * record-full.c: Use C++ exception handling.
3014         * record-btrace.c: Use C++ exception handling.
3015         * python/python.c: Use C++ exception handling.
3016         * python/py-value.c: Use C++ exception handling.
3017         * python/py-utils.c: Use C++ exception handling.
3018         * python/py-unwind.c: Use C++ exception handling.
3019         * python/py-type.c: Use C++ exception handling.
3020         * python/py-symbol.c: Use C++ exception handling.
3021         * python/py-record.c: Use C++ exception handling.
3022         * python/py-record-btrace.c: Use C++ exception handling.
3023         * python/py-progspace.c: Use C++ exception handling.
3024         * python/py-prettyprint.c: Use C++ exception handling.
3025         * python/py-param.c: Use C++ exception handling.
3026         * python/py-objfile.c: Use C++ exception handling.
3027         * python/py-linetable.c: Use C++ exception handling.
3028         * python/py-lazy-string.c: Use C++ exception handling.
3029         * python/py-infthread.c: Use C++ exception handling.
3030         * python/py-inferior.c: Use C++ exception handling.
3031         * python/py-gdb-readline.c: Use C++ exception handling.
3032         * python/py-framefilter.c: Use C++ exception handling.
3033         * python/py-frame.c: Use C++ exception handling.
3034         * python/py-finishbreakpoint.c: Use C++ exception handling.
3035         * python/py-cmd.c: Use C++ exception handling.
3036         * python/py-breakpoint.c: Use C++ exception handling.
3037         * python/py-arch.c: Use C++ exception handling.
3038         * printcmd.c: Use C++ exception handling.
3039         * ppc-linux-tdep.c: Use C++ exception handling.
3040         * parse.c: Use C++ exception handling.
3041         * p-valprint.c: Use C++ exception handling.
3042         * objc-lang.c: Use C++ exception handling.
3043         * mi/mi-main.c: Use C++ exception handling.
3044         * mi/mi-interp.c: Use C++ exception handling.
3045         * mi/mi-cmd-stack.c: Use C++ exception handling.
3046         * mi/mi-cmd-break.c: Use C++ exception handling.
3047         * main.c: Use C++ exception handling.
3048         * linux-thread-db.c: Use C++ exception handling.
3049         * linux-tdep.c: Use C++ exception handling.
3050         * linux-nat.c: Use C++ exception handling.
3051         * linux-fork.c: Use C++ exception handling.
3052         * linespec.c: Use C++ exception handling.
3053         * language.c: Use C++ exception handling.
3054         * jit.c: Use C++ exception handling.
3055         * infrun.c: Use C++ exception handling.
3056         * infcmd.c: Use C++ exception handling.
3057         * infcall.c: Use C++ exception handling.
3058         * inf-loop.c: Use C++ exception handling.
3059         * i386-tdep.c: Use C++ exception handling.
3060         * i386-linux-tdep.c: Use C++ exception handling.
3061         * guile/scm-value.c: Use C++ exception handling.
3062         * guile/scm-type.c: Use C++ exception handling.
3063         * guile/scm-symtab.c: Use C++ exception handling.
3064         * guile/scm-symbol.c: Use C++ exception handling.
3065         * guile/scm-pretty-print.c: Use C++ exception handling.
3066         * guile/scm-ports.c: Use C++ exception handling.
3067         * guile/scm-param.c: Use C++ exception handling.
3068         * guile/scm-math.c: Use C++ exception handling.
3069         * guile/scm-lazy-string.c: Use C++ exception handling.
3070         * guile/scm-frame.c: Use C++ exception handling.
3071         * guile/scm-disasm.c: Use C++ exception handling.
3072         * guile/scm-cmd.c: Use C++ exception handling.
3073         * guile/scm-breakpoint.c: Use C++ exception handling.
3074         * guile/scm-block.c: Use C++ exception handling.
3075         * guile/guile-internal.h: Use C++ exception handling.
3076         * gnu-v3-abi.c: Use C++ exception handling.
3077         * gdbtypes.c: Use C++ exception handling.
3078         * frame.c: Use C++ exception handling.
3079         * frame-unwind.c: Use C++ exception handling.
3080         * fbsd-tdep.c: Use C++ exception handling.
3081         * f-valprint.c: Use C++ exception handling.
3082         * exec.c: Use C++ exception handling.
3083         * event-top.c: Use C++ exception handling.
3084         * event-loop.c: Use C++ exception handling.
3085         * eval.c: Use C++ exception handling.
3086         * dwarf2read.c: Use C++ exception handling.
3087         * dwarf2loc.c: Use C++ exception handling.
3088         * dwarf2-frame.c: Use C++ exception handling.
3089         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3090         * dwarf-index-write.c: Use C++ exception handling.
3091         * dwarf-index-cache.c: Use C++ exception handling.
3092         * dtrace-probe.c: Use C++ exception handling.
3093         * disasm-selftests.c: Use C++ exception handling.
3094         * darwin-nat.c: Use C++ exception handling.
3095         * cp-valprint.c: Use C++ exception handling.
3096         * cp-support.c: Use C++ exception handling.
3097         * cp-abi.c: Use C++ exception handling.
3098         * corelow.c: Use C++ exception handling.
3099         * completer.c: Use C++ exception handling.
3100         * compile/compile-object-run.c: Use C++ exception handling.
3101         * compile/compile-object-load.c: Use C++ exception handling.
3102         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3103         * compile/compile-c-symbols.c: Use C++ exception handling.
3104         * common/selftest.c: Use C++ exception handling.
3105         * common/new-op.c: Use C++ exception handling.
3106         * cli/cli-script.c: Use C++ exception handling.
3107         * cli/cli-interp.c: Use C++ exception handling.
3108         * cli/cli-cmds.c: Use C++ exception handling.
3109         * c-varobj.c: Use C++ exception handling.
3110         * btrace.c: Use C++ exception handling.
3111         * breakpoint.c: Use C++ exception handling.
3112         * break-catch-throw.c: Use C++ exception handling.
3113         * arch-utils.c: Use C++ exception handling.
3114         * amd64-tdep.c: Use C++ exception handling.
3115         * ada-valprint.c: Use C++ exception handling.
3116         * ada-typeprint.c: Use C++ exception handling.
3117         * ada-lang.c: Use C++ exception handling.
3118         * aarch64-tdep.c: Use C++ exception handling.
3119
3120 2019-04-08  Tom Tromey  <tom@tromey.com>
3121
3122         * xml-support.c (gdb_xml_parser::parse): Update.
3123         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3124         * value.c (show_convenience): Update.
3125         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3126         (test_parse_flags_qcs): Update.
3127         * thread.c (thr_try_catch_cmd): Update.
3128         * target.c (target_translate_tls_address): Update.
3129         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3130         (info_frame_command_core, frame_apply_command_count): Update.
3131         * rust-exp.y (rust_lex_exception_test): Update.
3132         * riscv-tdep.c (riscv_print_one_register_info): Update.
3133         * remote.c (remote_target::enable_btrace): Update.
3134         * record-btrace.c (record_btrace_enable_warn): Update.
3135         * python/py-utils.c (gdbpy_convert_exception): Update.
3136         * printcmd.c (do_one_display, print_variable_and_value): Update.
3137         * mi/mi-main.c (mi_print_exception): Update.
3138         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3139         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3140         * linux-nat.c (linux_nat_target::attach): Update.
3141         * linux-fork.c (class scoped_switch_fork_info): Update.
3142         * infrun.c (displaced_step_prepare): Update.
3143         * infcall.c (call_function_by_hand_dummy): Update.
3144         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3145         * gnu-v3-abi.c (print_one_vtable): Update.
3146         * frame.c (get_prev_frame_always): Update.
3147         * f-valprint.c (info_common_command_for_block): Update.
3148         * exec.c (try_open_exec_file): Update.
3149         * exceptions.c (print_exception, exception_print)
3150         (exception_fprintf, exception_print_same): Update.
3151         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3152         * dwarf-index-cache.c (index_cache::store)
3153         (index_cache::lookup_gdb_index): Update.
3154         * darwin-nat.c (maybe_cache_shell): Update.
3155         * cp-valprint.c (cp_print_value_fields): Update.
3156         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3157         (gcc_cplus_symbol_address): Update.
3158         * compile/compile-c-symbols.c (gcc_convert_symbol)
3159         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3160         * common/selftest.c: Update.
3161         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3162         a std::string.
3163         (exception_try_scope_entry, exception_try_scope_exit): Don't
3164         declare.
3165         (struct exception_try_scope): Remove.
3166         (TRY): Don't use exception_try_scope.
3167         (struct gdb_exception): Add constructor, operator=.
3168         <what>: New method.
3169         (struct gdb_exception_RETURN_MASK_ALL)
3170         (struct gdb_exception_RETURN_MASK_ERROR)
3171         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3172         (struct gdb_quit_bad_alloc): Update.
3173         * common/common-exceptions.c (exception_none): Change
3174         initializer.
3175         (struct catcher) <state, exception>: Initialize inline.
3176         <prev>: Remove member.
3177         (current_catcher): Remove.
3178         (catchers): New global.
3179         (exceptions_state_mc_init): Simplify.
3180         (catcher_pop): Remove.
3181         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3182         (try_scope_depth, exception_try_scope_entry)
3183         (exception_try_scope_exit): Remove.
3184         (throw_exception_sjlj): Update.
3185         (exception_messages, exception_messages_size): Remove.
3186         (throw_it): Simplify.
3187         (gdb_exception_sliced_copy): Remove.
3188         (throw_exception_cxx): Update.
3189         * cli/cli-script.c (script_from_file): Update.
3190         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3191         Update.
3192         * ada-valprint.c (ada_val_print): Update.
3193         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3194         (create_excep_cond_exprs): Update.
3195
3196 2019-04-08  Tom Tromey  <tom@tromey.com>
3197
3198         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3199         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3200         (TRY, CATCH, END_CATCH): Remove some definitions.
3201         * common/common-exceptions.c: Don't use GDB_XCPT.
3202         (catcher_list_size): Remove.
3203         (throw_exception, throw_it): Simplify.
3204
3205 2019-04-05  Tom Tromey  <tom@tromey.com>
3206
3207         Revert the header-sorting patch.
3208         * ft32-tdep.c: Revert.
3209         * frv-tdep.c: Revert.
3210         * frv-linux-tdep.c: Revert.
3211         * frame.c: Revert.
3212         * frame-unwind.c: Revert.
3213         * frame-base.c: Revert.
3214         * fork-child.c: Revert.
3215         * findvar.c: Revert.
3216         * findcmd.c: Revert.
3217         * filesystem.c: Revert.
3218         * filename-seen-cache.h: Revert.
3219         * filename-seen-cache.c: Revert.
3220         * fbsd-tdep.c: Revert.
3221         * fbsd-nat.h: Revert.
3222         * fbsd-nat.c: Revert.
3223         * f-valprint.c: Revert.
3224         * f-typeprint.c: Revert.
3225         * f-lang.c: Revert.
3226         * extension.h: Revert.
3227         * extension.c: Revert.
3228         * extension-priv.h: Revert.
3229         * expprint.c: Revert.
3230         * exec.h: Revert.
3231         * exec.c: Revert.
3232         * exceptions.c: Revert.
3233         * event-top.c: Revert.
3234         * event-loop.c: Revert.
3235         * eval.c: Revert.
3236         * elfread.c: Revert.
3237         * dwarf2read.h: Revert.
3238         * dwarf2read.c: Revert.
3239         * dwarf2loc.c: Revert.
3240         * dwarf2expr.h: Revert.
3241         * dwarf2expr.c: Revert.
3242         * dwarf2-frame.c: Revert.
3243         * dwarf2-frame-tailcall.c: Revert.
3244         * dwarf-index-write.h: Revert.
3245         * dwarf-index-write.c: Revert.
3246         * dwarf-index-common.c: Revert.
3247         * dwarf-index-cache.h: Revert.
3248         * dwarf-index-cache.c: Revert.
3249         * dummy-frame.c: Revert.
3250         * dtrace-probe.c: Revert.
3251         * disasm.h: Revert.
3252         * disasm.c: Revert.
3253         * disasm-selftests.c: Revert.
3254         * dictionary.c: Revert.
3255         * dicos-tdep.c: Revert.
3256         * demangle.c: Revert.
3257         * dcache.h: Revert.
3258         * dcache.c: Revert.
3259         * darwin-nat.h: Revert.
3260         * darwin-nat.c: Revert.
3261         * darwin-nat-info.c: Revert.
3262         * d-valprint.c: Revert.
3263         * d-namespace.c: Revert.
3264         * d-lang.c: Revert.
3265         * ctf.c: Revert.
3266         * csky-tdep.c: Revert.
3267         * csky-linux-tdep.c: Revert.
3268         * cris-tdep.c: Revert.
3269         * cris-linux-tdep.c: Revert.
3270         * cp-valprint.c: Revert.
3271         * cp-support.c: Revert.
3272         * cp-namespace.c: Revert.
3273         * cp-abi.c: Revert.
3274         * corelow.c: Revert.
3275         * corefile.c: Revert.
3276         * continuations.c: Revert.
3277         * completer.h: Revert.
3278         * completer.c: Revert.
3279         * complaints.c: Revert.
3280         * coffread.c: Revert.
3281         * coff-pe-read.c: Revert.
3282         * cli-out.h: Revert.
3283         * cli-out.c: Revert.
3284         * charset.c: Revert.
3285         * c-varobj.c: Revert.
3286         * c-valprint.c: Revert.
3287         * c-typeprint.c: Revert.
3288         * c-lang.c: Revert.
3289         * buildsym.c: Revert.
3290         * buildsym-legacy.c: Revert.
3291         * build-id.h: Revert.
3292         * build-id.c: Revert.
3293         * btrace.c: Revert.
3294         * bsd-uthread.c: Revert.
3295         * breakpoint.h: Revert.
3296         * breakpoint.c: Revert.
3297         * break-catch-throw.c: Revert.
3298         * break-catch-syscall.c: Revert.
3299         * break-catch-sig.c: Revert.
3300         * blockframe.c: Revert.
3301         * block.c: Revert.
3302         * bfin-tdep.c: Revert.
3303         * bfin-linux-tdep.c: Revert.
3304         * bfd-target.c: Revert.
3305         * bcache.c: Revert.
3306         * ax-general.c: Revert.
3307         * ax-gdb.h: Revert.
3308         * ax-gdb.c: Revert.
3309         * avr-tdep.c: Revert.
3310         * auxv.c: Revert.
3311         * auto-load.c: Revert.
3312         * arm-wince-tdep.c: Revert.
3313         * arm-tdep.c: Revert.
3314         * arm-symbian-tdep.c: Revert.
3315         * arm-pikeos-tdep.c: Revert.
3316         * arm-obsd-tdep.c: Revert.
3317         * arm-nbsd-tdep.c: Revert.
3318         * arm-nbsd-nat.c: Revert.
3319         * arm-linux-tdep.c: Revert.
3320         * arm-linux-nat.c: Revert.
3321         * arm-fbsd-tdep.c: Revert.
3322         * arm-fbsd-nat.c: Revert.
3323         * arm-bsd-tdep.c: Revert.
3324         * arch-utils.c: Revert.
3325         * arc-tdep.c: Revert.
3326         * arc-newlib-tdep.c: Revert.
3327         * annotate.h: Revert.
3328         * annotate.c: Revert.
3329         * amd64-windows-tdep.c: Revert.
3330         * amd64-windows-nat.c: Revert.
3331         * amd64-tdep.c: Revert.
3332         * amd64-sol2-tdep.c: Revert.
3333         * amd64-obsd-tdep.c: Revert.
3334         * amd64-obsd-nat.c: Revert.
3335         * amd64-nbsd-tdep.c: Revert.
3336         * amd64-nbsd-nat.c: Revert.
3337         * amd64-nat.c: Revert.
3338         * amd64-linux-tdep.c: Revert.
3339         * amd64-linux-nat.c: Revert.
3340         * amd64-fbsd-tdep.c: Revert.
3341         * amd64-fbsd-nat.c: Revert.
3342         * amd64-dicos-tdep.c: Revert.
3343         * amd64-darwin-tdep.c: Revert.
3344         * amd64-bsd-nat.c: Revert.
3345         * alpha-tdep.c: Revert.
3346         * alpha-obsd-tdep.c: Revert.
3347         * alpha-nbsd-tdep.c: Revert.
3348         * alpha-mdebug-tdep.c: Revert.
3349         * alpha-linux-tdep.c: Revert.
3350         * alpha-linux-nat.c: Revert.
3351         * alpha-bsd-tdep.c: Revert.
3352         * alpha-bsd-nat.c: Revert.
3353         * aix-thread.c: Revert.
3354         * agent.c: Revert.
3355         * addrmap.c: Revert.
3356         * ada-varobj.c: Revert.
3357         * ada-valprint.c: Revert.
3358         * ada-typeprint.c: Revert.
3359         * ada-tasks.c: Revert.
3360         * ada-lang.c: Revert.
3361         * aarch64-tdep.c: Revert.
3362         * aarch64-ravenscar-thread.c: Revert.
3363         * aarch64-newlib-tdep.c: Revert.
3364         * aarch64-linux-tdep.c: Revert.
3365         * aarch64-linux-nat.c: Revert.
3366         * aarch64-fbsd-tdep.c: Revert.
3367         * aarch64-fbsd-nat.c: Revert.
3368         * aarch32-linux-nat.c: Revert.
3369
3370 2019-04-05  Tom Tromey  <tom@tromey.com>
3371
3372         * ft32-tdep.c: Sort headers.
3373         * frv-tdep.c: Sort headers.
3374         * frv-linux-tdep.c: Sort headers.
3375         * frame.c: Sort headers.
3376         * frame-unwind.c: Sort headers.
3377         * frame-base.c: Sort headers.
3378         * fork-child.c: Sort headers.
3379         * findvar.c: Sort headers.
3380         * findcmd.c: Sort headers.
3381         * filesystem.c: Sort headers.
3382         * filename-seen-cache.h: Sort headers.
3383         * filename-seen-cache.c: Sort headers.
3384         * fbsd-tdep.c: Sort headers.
3385         * fbsd-nat.h: Sort headers.
3386         * fbsd-nat.c: Sort headers.
3387         * f-valprint.c: Sort headers.
3388         * f-typeprint.c: Sort headers.
3389         * f-lang.c: Sort headers.
3390         * extension.h: Sort headers.
3391         * extension.c: Sort headers.
3392         * extension-priv.h: Sort headers.
3393         * expprint.c: Sort headers.
3394         * exec.h: Sort headers.
3395         * exec.c: Sort headers.
3396         * exceptions.c: Sort headers.
3397         * event-top.c: Sort headers.
3398         * event-loop.c: Sort headers.
3399         * eval.c: Sort headers.
3400         * elfread.c: Sort headers.
3401         * dwarf2read.h: Sort headers.
3402         * dwarf2read.c: Sort headers.
3403         * dwarf2loc.c: Sort headers.
3404         * dwarf2expr.h: Sort headers.
3405         * dwarf2expr.c: Sort headers.
3406         * dwarf2-frame.c: Sort headers.
3407         * dwarf2-frame-tailcall.c: Sort headers.
3408         * dwarf-index-write.h: Sort headers.
3409         * dwarf-index-write.c: Sort headers.
3410         * dwarf-index-common.c: Sort headers.
3411         * dwarf-index-cache.h: Sort headers.
3412         * dwarf-index-cache.c: Sort headers.
3413         * dummy-frame.c: Sort headers.
3414         * dtrace-probe.c: Sort headers.
3415         * disasm.h: Sort headers.
3416         * disasm.c: Sort headers.
3417         * disasm-selftests.c: Sort headers.
3418         * dictionary.c: Sort headers.
3419         * dicos-tdep.c: Sort headers.
3420         * demangle.c: Sort headers.
3421         * dcache.h: Sort headers.
3422         * dcache.c: Sort headers.
3423         * darwin-nat.h: Sort headers.
3424         * darwin-nat.c: Sort headers.
3425         * darwin-nat-info.c: Sort headers.
3426         * d-valprint.c: Sort headers.
3427         * d-namespace.c: Sort headers.
3428         * d-lang.c: Sort headers.
3429         * ctf.c: Sort headers.
3430         * csky-tdep.c: Sort headers.
3431         * csky-linux-tdep.c: Sort headers.
3432         * cris-tdep.c: Sort headers.
3433         * cris-linux-tdep.c: Sort headers.
3434         * cp-valprint.c: Sort headers.
3435         * cp-support.c: Sort headers.
3436         * cp-namespace.c: Sort headers.
3437         * cp-abi.c: Sort headers.
3438         * corelow.c: Sort headers.
3439         * corefile.c: Sort headers.
3440         * continuations.c: Sort headers.
3441         * completer.h: Sort headers.
3442         * completer.c: Sort headers.
3443         * complaints.c: Sort headers.
3444         * coffread.c: Sort headers.
3445         * coff-pe-read.c: Sort headers.
3446         * cli-out.h: Sort headers.
3447         * cli-out.c: Sort headers.
3448         * charset.c: Sort headers.
3449         * c-varobj.c: Sort headers.
3450         * c-valprint.c: Sort headers.
3451         * c-typeprint.c: Sort headers.
3452         * c-lang.c: Sort headers.
3453         * buildsym.c: Sort headers.
3454         * buildsym-legacy.c: Sort headers.
3455         * build-id.h: Sort headers.
3456         * build-id.c: Sort headers.
3457         * btrace.c: Sort headers.
3458         * bsd-uthread.c: Sort headers.
3459         * breakpoint.h: Sort headers.
3460         * breakpoint.c: Sort headers.
3461         * break-catch-throw.c: Sort headers.
3462         * break-catch-syscall.c: Sort headers.
3463         * break-catch-sig.c: Sort headers.
3464         * blockframe.c: Sort headers.
3465         * block.c: Sort headers.
3466         * bfin-tdep.c: Sort headers.
3467         * bfin-linux-tdep.c: Sort headers.
3468         * bfd-target.c: Sort headers.
3469         * bcache.c: Sort headers.
3470         * ax-general.c: Sort headers.
3471         * ax-gdb.h: Sort headers.
3472         * ax-gdb.c: Sort headers.
3473         * avr-tdep.c: Sort headers.
3474         * auxv.c: Sort headers.
3475         * auto-load.c: Sort headers.
3476         * arm-wince-tdep.c: Sort headers.
3477         * arm-tdep.c: Sort headers.
3478         * arm-symbian-tdep.c: Sort headers.
3479         * arm-pikeos-tdep.c: Sort headers.
3480         * arm-obsd-tdep.c: Sort headers.
3481         * arm-nbsd-tdep.c: Sort headers.
3482         * arm-nbsd-nat.c: Sort headers.
3483         * arm-linux-tdep.c: Sort headers.
3484         * arm-linux-nat.c: Sort headers.
3485         * arm-fbsd-tdep.c: Sort headers.
3486         * arm-fbsd-nat.c: Sort headers.
3487         * arm-bsd-tdep.c: Sort headers.
3488         * arch-utils.c: Sort headers.
3489         * arc-tdep.c: Sort headers.
3490         * arc-newlib-tdep.c: Sort headers.
3491         * annotate.h: Sort headers.
3492         * annotate.c: Sort headers.
3493         * amd64-windows-tdep.c: Sort headers.
3494         * amd64-windows-nat.c: Sort headers.
3495         * amd64-tdep.c: Sort headers.
3496         * amd64-sol2-tdep.c: Sort headers.
3497         * amd64-obsd-tdep.c: Sort headers.
3498         * amd64-obsd-nat.c: Sort headers.
3499         * amd64-nbsd-tdep.c: Sort headers.
3500         * amd64-nbsd-nat.c: Sort headers.
3501         * amd64-nat.c: Sort headers.
3502         * amd64-linux-tdep.c: Sort headers.
3503         * amd64-linux-nat.c: Sort headers.
3504         * amd64-fbsd-tdep.c: Sort headers.
3505         * amd64-fbsd-nat.c: Sort headers.
3506         * amd64-dicos-tdep.c: Sort headers.
3507         * amd64-darwin-tdep.c: Sort headers.
3508         * amd64-bsd-nat.c: Sort headers.
3509         * alpha-tdep.c: Sort headers.
3510         * alpha-obsd-tdep.c: Sort headers.
3511         * alpha-nbsd-tdep.c: Sort headers.
3512         * alpha-mdebug-tdep.c: Sort headers.
3513         * alpha-linux-tdep.c: Sort headers.
3514         * alpha-linux-nat.c: Sort headers.
3515         * alpha-bsd-tdep.c: Sort headers.
3516         * alpha-bsd-nat.c: Sort headers.
3517         * aix-thread.c: Sort headers.
3518         * agent.c: Sort headers.
3519         * addrmap.c: Sort headers.
3520         * ada-varobj.c: Sort headers.
3521         * ada-valprint.c: Sort headers.
3522         * ada-typeprint.c: Sort headers.
3523         * ada-tasks.c: Sort headers.
3524         * ada-lang.c: Sort headers.
3525         * aarch64-tdep.c: Sort headers.
3526         * aarch64-ravenscar-thread.c: Sort headers.
3527         * aarch64-newlib-tdep.c: Sort headers.
3528         * aarch64-linux-tdep.c: Sort headers.
3529         * aarch64-linux-nat.c: Sort headers.
3530         * aarch64-fbsd-tdep.c: Sort headers.
3531         * aarch64-fbsd-nat.c: Sort headers.
3532         * aarch32-linux-nat.c: Sort headers.
3533
3534 2019-04-04  Tom Tromey  <tom@tromey.com>
3535
3536         * varobj.c (varobj_create): Update.
3537         * rust-exp.y (struct rust_parser) <update_innermost_block,
3538         lookup_symbol>: New methods.
3539         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3540         Rename.
3541         (rust_parser::rust_lookup_type)
3542         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3543         * printcmd.c (display_command, do_one_display): Update.
3544         * parser-defs.h (struct parser_state) <parser_state>: Add
3545         "tracker" parameter.
3546         (block_tracker): New member.
3547         (class innermost_block_tracker) <innermost_block_tracker>: Add
3548         "types" parameter.
3549         <reset>: Remove method.
3550         (innermost_block): Don't declare.
3551         (null_post_parser): Update.
3552         * parse.c (innermost_block): Remove global.
3553         (write_dollar_variable): Update.
3554         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3555         Remove "tracker_types" parameter.
3556         (parse_expression): Add "tracker" parameter.
3557         (parse_expression_for_completion): Update.
3558         (null_post_parser): Add "tracker" parameter.
3559         * p-exp.y: Update rules.
3560         * m2-exp.y: Update rules.
3561         * language.h (struct language_defn) <la_post_parser>: Add
3562         "tracker" parameter.
3563         * go-exp.y: Update rules.
3564         * f-exp.y: Update rules.
3565         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3566         parameter.
3567         * d-exp.y: Update rules.
3568         * c-exp.y: Update rules.
3569         * breakpoint.c (set_breakpoint_condition): Create an
3570         innermost_block_tracker.
3571         (watch_command_1): Likewise.
3572         * ada-lang.c (resolve): Add "tracker" parameter.
3573         (resolve_subexp): Likewise.
3574         * ada-exp.y (write_var_from_sym): Update.
3575
3576 2019-04-04  Tom Tromey  <tom@tromey.com>
3577
3578         * type-stack.h: New file.
3579         * type-stack.c: New file.
3580         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3581         type-stack.h.
3582         (insert_into_type_stack, insert_type, push_type, push_type_int)
3583         (insert_type_address_space, pop_type, pop_type_int)
3584         (pop_typelist, pop_type_stack, append_type_stack)
3585         (push_type_stack, get_type_stack, push_typelist)
3586         (follow_type_instance_flags, follow_types): Don't declare.
3587         * parse.c (type_stack): Remove global.
3588         (parse_exp_in_context): Update.
3589         (insert_into_type_stack, insert_type, push_type, push_type_int)
3590         (insert_type_address_space, pop_type, pop_type_int)
3591         (pop_typelist, pop_type_stack, append_type_stack)
3592         (push_type_stack, get_type_stack, push_typelist)
3593         (follow_type_instance_flags, follow_types): Remove (moved to
3594         type-stack.c).
3595         * f-exp.y (type_stack): New global.
3596         Update rules.
3597         (push_kind_type, f_parse): Update.
3598         * d-exp.y (type_stack): New global.
3599         Update rules.
3600         (d_parse): Update.
3601         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3602         Update rules.
3603         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3604         (HFILES_NO_SRCDIR): Add type-stack.h.
3605
3606 2019-04-04  Tom Tromey  <tom@tromey.com>
3607
3608         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3609         (rust_parser::convert_ast_to_expression, rust_parse)
3610         (rust_lex_test_completion, rust_lex_tests): Update.
3611         * parser-defs.h (struct expr_completion_state): New.
3612         (struct parser_state) <parser_state>: Add completion parameter.
3613         <mark_struct_expression, mark_completion_tag>: New methods.
3614         <parse_completion, m_completion_state>: New members.
3615         (prefixify_expression, null_post_parser): Update.
3616         (mark_struct_expression, mark_completion_tag): Don't declare.
3617         * parse.c (parse_completion, expout_last_struct)
3618         (expout_tag_completion_type, expout_completion_name): Remove
3619         globals.
3620         (parser_state::mark_struct_expression)
3621         (parser_state::mark_completion_tag): Now methods.
3622         (prefixify_expression): Add last_struct parameter.
3623         (prefixify_subexp): Likewise.
3624         (parse_exp_1): Update.
3625         (parse_exp_in_context): Add cstate parameter.  Update.
3626         (parse_expression_for_completion): Create an
3627         expr_completion_state.
3628         (null_post_parser): Add "completion" parameter.
3629         * p-exp.y: Update rules.
3630         (yylex): Update.
3631         * language.h (struct language_defn) <la_post_parser>: Add
3632         "completing" parameter.
3633         * go-exp.y: Update rules.
3634         (lex_one_token): Update.
3635         * expression.h (parse_completion): Don't declare.
3636         * d-exp.y: Update rules.
3637         (lex_one_token): Update rules.
3638         * c-exp.y: Update rules.
3639         (lex_one_token): Update.
3640         * ada-lang.c (resolve): Add "parse_completion" parameter.
3641         (resolve_subexp): Likewise.
3642         (ada_resolve_function): Likewise.
3643
3644 2019-04-04  Tom Tromey  <tom@tromey.com>
3645
3646         * parser-defs.h (struct parser_state) <start_arglist,
3647         end_arglist>: New methods.
3648         <arglist_len, m_funcall_chain>: New members.
3649         (arglist_len, start_arglist, end_arglist): Don't declare.
3650         * parse.c (arglist_len, funcall_chain): Remove global.
3651         (start_arglist, end_arglist): Remove functions.
3652         (parse_exp_in_context): Update.
3653         * p-exp.y: Update rules.
3654         * m2-exp.y: Update rules.
3655         * go-exp.y: Update rules.
3656         * f-exp.y: Update rules.
3657         * d-exp.y: Update rules.
3658         * c-exp.y: Update rules.
3659
3660 2019-04-04  Tom Tromey  <tom@tromey.com>
3661
3662         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3663         lex_operator, push_back>: New methods.
3664         Update all rules.
3665         (rust_parser::lex_hex, lex_escape): Rename and update.
3666         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3667         (rust_parser::lex_operator): Rename and update.
3668         (rust_parser::lex_number, rustyylex, rustyyerror)
3669         (rust_lex_test_init, rust_lex_test_sequence)
3670         (rust_lex_test_push_back, rust_lex_tests): Update.
3671         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3672         parameter.
3673         <lexptr, prev_lexptr>: New members.
3674         (lexptr, prev_lexptr): Don't declare.
3675         * parse.c (lexptr, prev_lexptr): Remove globals.
3676         (parse_exp_in_context): Update.
3677         * p-exp.y (yylex, yyerror): Update.
3678         * m2-exp.y (parse_number, yylex, yyerror): Update.
3679         * go-exp.y (lex_one_token, yyerror): Update.
3680         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3681         * d-exp.y (lex_one_token, yyerror): Update.
3682         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3683         (lex_one_token, yyerror): Update.
3684         * ada-lex.l (YY_INPUT): Update.
3685         (rewind_to_char): Update.
3686         * ada-exp.y (yyerror): Update.
3687
3688 2019-04-04  Tom Tromey  <tom@tromey.com>
3689
3690         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3691         * parser-defs.h (struct parser_state) <parser_state>: Add new
3692         parameter.
3693         <comma_terminates>: New member.
3694         (comma_terminates): Don't declare global.
3695         * parse.c (comma_terminates): Remove global.
3696         (parse_exp_in_context): Update.
3697         * p-exp.y (yylex): Update.
3698         * m2-exp.y (yylex): Update.
3699         * go-exp.y (lex_one_token): Update.
3700         * f-exp.y (yylex): Update.
3701         * d-exp.y (lex_one_token): Update.
3702         * c-exp.y (lex_one_token): Update.
3703         * ada-lex.l: Update.
3704
3705 2019-04-04  Tom Tromey  <tom@tromey.com>
3706
3707         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3708         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3709         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3710         * parser-defs.h (paren_depth): Don't declare.
3711         * parse.c (paren_depth): Remove global.
3712         (parse_exp_in_context): Update.
3713         * p-exp.y (paren_depth): New global.
3714         (pascal_parse): Initialize it.
3715         * m2-exp.y (paren_depth): New global.
3716         (m2_parse): Initialize it.
3717         * go-exp.y (paren_depth): New global.
3718         (go_parse): Initialize it.
3719         * f-exp.y (paren_depth): New global.
3720         (f_parse): Initialize it.
3721         * d-exp.y (paren_depth): New global.
3722         (d_parse): Initialize it.
3723         * c-exp.y (paren_depth): New global.
3724         (c_parse): Initialize it.
3725         * ada-lex.l (paren_depth): New global.
3726         (lexer_init): Initialize it.
3727
3728 2019-04-04  Tom Tromey  <tom@tromey.com>
3729
3730         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3731         (rust_parser::convert_ast_to_type)
3732         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3733         * parser-defs.h (struct parser_state) <parser_state>: Add
3734         parameters.  Initialize new members.
3735         <expression_context_block, expression_context_pc>: New members.
3736         * parse.c (expression_context_block, expression_context_pc):
3737         Remove globals.
3738         (parse_exp_in_context): Update.
3739         * p-exp.y: Update all rules.
3740         (yylex): Update.
3741         * m2-exp.y: Update all rules.
3742         (yylex): Update.
3743         * go-exp.y (yylex): Update.
3744         * f-exp.y (yylex): Update.
3745         * d-exp.y: Update all rules.
3746         (yylex): Update.
3747         * c-exp.y: Update all rules.
3748         (lex_one_token, classify_name, yylex, c_parse): Update.
3749         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3750
3751 2019-04-04  Tom Tromey  <tom@tromey.com>
3752
3753         * gdbarch.h, gdbarch.c: Rebuild.
3754         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3755         * stap-probe.h:
3756         (struct stap_parse_info): Replace "parser_state" with
3757         "expr_builder".
3758         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3759         (parser_state): New class.
3760         * parse.c (expr_builder): Rename.
3761         (expr_builder::release): Rename.
3762         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3763         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3764         (write_exp_elt_longcst, write_exp_elt_floatcst)
3765         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3766         (write_exp_string_vector, write_exp_bitstring)
3767         (write_exp_msymbol, mark_struct_expression)
3768         (write_dollar_variable)
3769         (insert_type_address_space, increase_expout_size): Replace
3770         "parser_state" with "expr_builder".
3771         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3772         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3773         "parser_state" with "expr_builder".
3774
3775 2019-04-04  Tom Tromey  <tom@tromey.com>
3776
3777         * rust-exp.y: Replace "parse_language" with method call.
3778         * p-exp.y:
3779         (yylex): Replace "parse_language" with method call.
3780         * m2-exp.y:
3781         (yylex): Replace "parse_language" with method call.
3782         * go-exp.y (classify_name): Replace "parse_language" with method
3783         call.
3784         * f-exp.y (yylex): Replace "parse_language" with method call.
3785         * d-exp.y (lex_one_token): Replace "parse_language" with method
3786         call.
3787         * c-exp.y:
3788         (lex_one_token, classify_name, yylex): Replace "parse_language"
3789         with method call.
3790         * ada-exp.y (find_primitive_type, type_char)
3791         (type_system_address): Replace "parse_language" with method call.
3792
3793 2019-04-04  Tom Tromey  <tom@tromey.com>
3794
3795         * rust-exp.y: Replace "parse_gdbarch" with method call.
3796         * parse.c (write_dollar_variable, insert_type_address_space):
3797         Replace "parse_gdbarch" with method call.
3798         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3799         call.
3800         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3801         call.
3802         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3803         "parse_gdbarch" with method call.
3804         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3805         with method call.
3806         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3807         "parse_gdbarch" with method call.
3808         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3809         "parse_gdbarch" with method call.
3810         * c-exp.y (parse_type, parse_number, classify_name): Replace
3811         "parse_gdbarch" with method call.
3812         * ada-lex.l: Replace "parse_gdbarch" with method call.
3813         * ada-exp.y (parse_type, find_primitive_type, type_char)
3814         (type_system_address): Replace "parse_gdbarch" with method call.
3815
3816 2019-04-04  Tom Tromey  <tom@tromey.com>
3817
3818         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3819         * stap-probe.c (stap_parse_argument): Update.
3820         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3821         initial_size parameter.
3822         * rust-exp.y (rust_lex_tests): Update.
3823         * parse.c (parser_state): Update.
3824         (parse_exp_in_context): Update.
3825         * parser-defs.h (struct parser_state) <parser_state>: Remove
3826         "initial_size" parameter.
3827
3828 2019-04-04  Tom Tromey  <tom@tromey.com>
3829
3830         * parser-defs.h (increase_expout_size): Don't declare.
3831         * parse.c (increase_expout_size): Now static.
3832
3833 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3834
3835         * gnu-nat.c (gnu_nat_target::wait): Fix
3836         target_waitstatus_to_string call.
3837
3838 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * eval.c (evaluate_subexp_standard): Handle internal functions
3841         during Fortran function call handling.
3842
3843 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * NEWS: Mention new internal functions.
3846         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3847         (read_base_type): Use dwarf2_init_complex_target_type.
3848         * value.c (creal_internal_fn): New function.
3849         (cimag_internal_fn): New function.
3850         (_initialize_values): Register new internal functions.
3851
3852 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3853
3854         * infrun.c (stop_all_threads): If debug_infrun, always
3855         trace the wait status after wait_one, using
3856         target_waitstatus_to_string and target_pid_to_str.
3857         (handle_inferior_event): Replace various trace of
3858         wait status kind by a single trace.
3859         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3860         wait status kind image by target_waitstatus_to_string.
3861         * target/waitstatus.c (target_waitstatus_to_string): Fix
3862         obsolete comment.
3863
3864 2019-04-01  Tom Tromey  <tromey@adacore.com>
3865
3866         PR symtab/23331:
3867         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3868
3869 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3870             Pedro Alves  <palves@redhat.com>
3871
3872         * top.c (quit_force): Call 'finalize_values'.
3873         * value.c (finalize_values): New function.
3874         * value.h (finalize_values): Declare.
3875
3876 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3877
3878         * NEWS: Announce $_gdb_major and $_gdb_minor.
3879
3880         * top.c (init_gdb_version_vars): New function.
3881         (gdb_init): Call init_gdb_version_vars.
3882
3883 2019-03-29  Tom Tromey  <tromey@adacore.com>
3884
3885         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3886         help text.  Remove dead code.
3887
3888 2019-03-29  Keith Seitz  <keiths@redhat.com>
3889
3890         From Siddhesh Poyarekar:
3891         * f-lang.h (f77_get_upperbound): Return LONGEST.
3892         (f77_get_lowerbound): Likewise.
3893         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3894         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3895         print them.
3896         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3897         plongest to format print it.
3898         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3899         (f77_get_upperbound): Likewise.
3900         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3901         LOWER_BOUND to LONGEST.
3902         (f77_create_arrayprint_offset_tbl): Likewise.
3903
3904 2019-03-29  Keith Seitz  <keiths@redhat.com>
3905
3906         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3907         %s/pulongest for TYPE_LENGTH instead of %d in format
3908         strings.
3909         * ada-typerint.c (ada_print_type): Likewise.
3910         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3911         * compile/compile-c-support.c (generate_register_struct): Likewise.
3912         * gdbtypes.c (recursive_dump_type): Likewise.
3913         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3914         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3915         instead of %d in format strings.
3916         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3917         to std::min to ULONGEST.
3918         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3919         instead of %d in format strings.
3920         * tracepoint.c (info_scope_command): Likewise.
3921         * typeprint.c (print_offset_data::update)
3922         (print_offset_data::finish): Likewise.
3923         * xtensa-tdep.c (xtensa_store_return_value)
3924         (xtensa_push_dummy_call): Likewise.
3925
3926 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3927
3928         * windows-nat.c (display_selector): Fixed format specifications
3929         for 64-bit Cygwin.
3930
3931 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3932
3933         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3934
3935 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3936
3937         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3938         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3939         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3940         (nios2_linux_init_abi): Install it.
3941
3942 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3943
3944         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3945
3946 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3947
3948         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3949
3950 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3951             Tom Tromey  <tromey@adacore.com>
3952
3953         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3954
3955 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3956
3957         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3958         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3959         method to compute the bounds of range types. Also print "[evaluated]"
3960         if the bounds' values come from a dynamic evaluation.
3961
3962 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3963
3964         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3965         whitespace when pretty printing is on.
3966
3967 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3968
3969         * ppc-linux-nat.c: Add include.
3970
3971 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3972
3973         * NEWS: Mention AArch64 Pointer Authentication.
3974
3975 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3976
3977         * arm-linux-nat.c: Add include.
3978
3979 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3980
3981         * source-cache.c (source_cache::get_source_lines): Re-read
3982         fullname after calling open_source_file.
3983
3984 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3985
3986         * NEWS: Mention TLS support for FreeBSD.
3987
3988 2019-03-25  Tom Tromey  <tromey@adacore.com>
3989
3990         * minsyms.c (BUNCH_SIZE): Update comment.
3991         (~minimal_symbol_reader): Remove old comment.
3992         (compact_minimal_symbols): Update comment.
3993         (minimal_symbol_reader::install): Remove old comment.  Update
3994         other comments.
3995
3996 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3997
3998         * s390-linux-nat.c: Add include.
3999
4000 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4001
4002         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4003         Call linux_get_hwcap.
4004         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4005         Likewise.
4006         (aarch64_linux_get_hwcap): Remove function.
4007         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4008         declaration.
4009         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4010         linux_get_hwcap.
4011         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4012         * linux-tdep.c (linux_get_hwcap): Add function.
4013         (linux_get_hwcap2): Likewise.
4014         * linux-tdep.h (linux_get_hwcap): Add declaration.
4015         (linux_get_hwcap2): Likewise.
4016         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4017         (ppc_linux_get_hwcap2): Likewise.
4018         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4019         linux_get_hwcap.
4020         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4021         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4022         (ppc_linux_nat_target::read_description): Likewise.
4023         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4024         * s390-linux-nat.c: Likewise.
4025         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4026
4027 2019-03-24  Tom Tromey  <tom@tromey.com>
4028
4029         * ada-lang.c (standard_lookup): Simplify initialization.
4030         (ada_lookup_symbol_nonlocal): Simplify return.
4031         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4032         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4033         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4034         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4035         initialization.
4036         * solib.c (solib_global_lookup): Simplify.
4037         * symtab.c (null_block_symbol): Remove.
4038         (symbol_cache_lookup): Simplify returns.
4039         (lookup_language_this): Simplify returns.
4040         (lookup_symbol_aux): Simplify return.
4041         (lookup_local_symbol): Simplify returns.
4042         (lookup_global_symbol_from_objfile): Simplify return.
4043         (lookup_symbol_in_objfile_symtabs)
4044         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4045         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4046         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4047         * cp-namespace.c (cp_lookup_bare_symbol)
4048         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4049         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4050         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4051         (cp_lookup_symbol_via_imports): Simplify initialization.
4052         (find_symbol_in_baseclass): Likewise.
4053         * symtab.h (null_block_symbol): Remove.
4054         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4055         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4056         (d_lookup_symbol_module): Likewise.
4057         (find_symbol_in_baseclass): Simplify initialization.
4058
4059 2019-03-24  Tom Tromey  <tom@tromey.com>
4060
4061         * expression.h: Don't include symtab.h.
4062         (struct block): Forward declare.
4063
4064 2019-03-24  Tom Tromey  <tom@tromey.com>
4065
4066         * c-exp.y (typebase): Remove casts.
4067         * gdbtypes.c (lookup_unsigned_typename, )
4068         (lookup_signed_typename): Remove cast.
4069         * eval.c (parse_to_comma_and_eval): Remove cast.
4070         * parse.c (write_dollar_variable): Remove cast.
4071         * block.h (struct block) <superblock>: Now const.
4072         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4073         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4074         (map_block): Make "block" const.
4075         * symfile.h (struct quick_symbol_functions)
4076         <map_matching_symbols>: Constify block argument to "callback".
4077         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4078         const.
4079         (find_pc_sect_compunit_symtab): Make "b" const.
4080         (find_symbol_at_address): Likewise.
4081         (search_symbols): Likewise.
4082         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4083         (dw2_debug_names_lookup_symbol): Likewise.
4084         (dw2_map_matching_symbols): Update.
4085         * p-valprint.c (pascal_val_print): Remove "block".
4086         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4087         (aux_add_nonlocal_symbols): Make "block" const.
4088         (resolve_subexp): Remove cast.
4089         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4090         const.
4091         (iterate_over_file_blocks): Likewise.
4092         * f-exp.y (%union) <bval>: Remove.
4093         * coffread.c (patch_opaque_types): Make "b" const.
4094         * spu-tdep.c (spu_catch_start): Make "block" const.
4095         * c-valprint.c (print_unpacked_pointer): Remove "block".
4096         * symmisc.c (dump_symtab_1): Make "b" const.
4097         (block_depth): Make "block" const.
4098         * d-exp.y (%union) <bval>: Remove.
4099         * cp-support.h (cp_lookup_rtti_type): Update.
4100         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4101         * psymtab.c (psym_lookup_symbol): Make "block" const.
4102         (maintenance_check_psymtabs): Make "b" const.
4103         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4104         (enumerate_locals, enumerate_args): Update.
4105         * python/py-symtab.c (stpy_global_block): Make "block" const.
4106         (stpy_static_block): Likewise.
4107         * inline-frame.c (block_starting_point_at): Make "new_block"
4108         const.
4109         * block.c (find_block_in_blockvector): Make return type const.
4110         (blockvector_for_pc_sect): Make "b" const.
4111         (find_block_in_blockvector): Make "b" const.
4112
4113 2019-03-23  Tom Tromey  <tom@tromey.com>
4114
4115         * varobj.c (varobj_create): Update.
4116         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4117         * printcmd.c (display_command, do_one_display): Don't reset
4118         innermost_block.
4119         * parser-defs.h (enum innermost_block_tracker_type): Move to
4120         expression.h.
4121         (innermost_block): Update comment.
4122         * parse.c (parse_exp_1): Add tracker_types parameter.
4123         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4124         tracker_types parameter.  Reset innermost_block.
4125         (parse_exp_in_context): Remove.
4126         (parse_expression_for_completion): Update.
4127         * objfiles.c (~objfile): Don't reset expression_context_block or
4128         innermost_block.
4129         * expression.h (enum innermost_block_tracker_type): Move from
4130         parser-defs.h.
4131         (parse_exp_1): Add tracker_types parameter.
4132         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4133         reset innermost_block.
4134
4135 2019-03-23  Tom Tromey  <tom@tromey.com>
4136
4137         * objfiles.h: Include bcache.h.
4138
4139 2019-03-23  Tom Tromey  <tom@tromey.com>
4140
4141         * linespec.c (get_current_search_block): Use
4142         scoped_restore_current_language.
4143         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4144
4145 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4146             Jiong Wang  <jiong.wang@arm.com>
4147
4148         * aarch64-linux-tdep.c
4149         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4150         section.
4151         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4152
4153 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4154             Jiong Wang  <jiong.wang@arm.com>
4155
4156         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4157         instructions.
4158         (aarch64_analyze_prologue_test): Add PACIASP test.
4159         (aarch64_prologue_prev_register): Unmask PC value.
4160
4161 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4162             Jiong Wang  <jiong.wang@arm.com>
4163
4164         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4165         (aarch64_dwarf2_prev_register): Unmask PC value.
4166         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4167         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4168         DW_CFA_AARCH64_negate_ra_state.
4169         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4170
4171 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4172             Jiong Wang  <jiong.wang@arm.com>
4173
4174         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4175         registers.
4176         (aarch64_pseudo_register_name): Likewise.
4177         (aarch64_pseudo_register_type): Likewise.
4178         (aarch64_pseudo_register_reggroup_p): Likewise.
4179         (aarch64_gdbarch_init): Add pauth registers.
4180         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4181         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4182         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4183         (struct gdbarch_tdep): Add regnum for ra_state.
4184
4185 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4186             Jiong Wang  <jiong.wang@arm.com>
4187
4188         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4189
4190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4191             Jiong Wang  <jiong.wang@arm.com>
4192
4193         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4194         function.
4195         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4196         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4197         (aarch64_gdbarch_init): Add puth registers.
4198         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4199         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4200         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4201
4202 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4203             Jiong Wang  <jiong.wang@arm.com>
4204
4205         * aarch64-linux-nat.c
4206         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4207         * aarch64-linux-tdep.c
4208         (aarch64_linux_core_read_description): Likewise.
4209         (aarch64_linux_get_hwcap): New function.
4210         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4211         (aarch64_linux_get_hwcap): New declaration.
4212
4213 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4214             Jiong Wang  <jiong.wang@arm.com>
4215
4216         * aarch64-linux-nat.c
4217         (aarch64_linux_nat_target::read_description): Add pauth param.
4218         * aarch64-linux-tdep.c
4219         (aarch64_linux_core_read_description): Likewise.
4220         * aarch64-tdep.c (struct target_desc): Add in pauth.
4221         (aarch64_read_description): Add pauth param.
4222         (aarch64_gdbarch_init): Likewise.
4223         * aarch64-tdep.h (aarch64_read_description): Likewise.
4224         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4225         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4226         * features/Makefile: Add new files.
4227         * features/aarch64-pauth.c: New file.
4228         * features/aarch64-pauth.xml: New file.
4229
4230 2019-03-20  Tom Tromey  <tromey@adacore.com>
4231
4232         * infrun.c (handle_inferior_event): Rename from
4233         handle_inferior_event_1.  Create a scoped_value_mark.
4234         (handle_inferior_event): Remove.
4235
4236 2019-03-19  Tom Tromey  <tromey@adacore.com>
4237
4238         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4239         * infrun.h (print_stop_event): Add "displays" parameter.
4240         * infrun.c (print_stop_event): Add "displays" parameter.
4241
4242 2019-03-19  Pedro Alves  <palves@redhat.com>
4243
4244         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4245         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4246         to -1.  Fix TABs vs spaces.
4247         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4248         * tui/tui-out.h (tui_ui_out) Add intro comments.
4249         <m_line, m_start_of_line>: In-class initialize, and add describing
4250         comment.
4251
4252 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4253
4254         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4255         variable names.
4256         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4257
4258 2019-03-18  Pedro Alves  <palves@redhat.com>
4259             Eli Zaretskii <eliz@gnu.org>
4260
4261         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4262         m_line and m_start_of_line.
4263
4264 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4265
4266         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4267         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4268         it returns a newline.  This fixes a regression in TU mode, whereby
4269         the next line is output on the same screen line as the user input.
4270
4271 2019-03-18  Tom Tromey  <tromey@adacore.com>
4272
4273         * minsyms.c (minimal_symbol_reader::install): Remove call to
4274         obstack_blank.
4275
4276 2019-03-18  Pedro Alves  <palves@redhat.com>
4277
4278         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4279         New globals.
4280         (apply_style): New, factored out from ...
4281         (apply_ansi_escape): ... this.  Handle reverse video mode.
4282         (tui_set_reverse_mode): New function.
4283         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4284         * tui/tui-winsource.c (tui_show_source_line): Use
4285         tui_set_reverse_mode instead of setting A_STANDOUT.
4286         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4287         New setter methods.
4288
4289 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4290
4291         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4292         Handle tabs.
4293
4294 2019-03-18  Tom Tromey  <tromey@adacore.com>
4295
4296         * ada-lang.c (empty_array): Add "high" parameter.
4297         (ada_evaluate_subexp): Update.
4298
4299 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4300
4301         * unittests/string_view-selftests.c: Define
4302         _initialize_string_view_selftests unconditionally.
4303
4304 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4305
4306         PR gdb/24350
4307         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4308
4309 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4310
4311         PR gdb/24351
4312         * windows-nat.c (display_selector): Fix format specifiers.
4313
4314 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4315
4316         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4317         tui_refill_source_window instead of tui_refresh_win, to update the
4318         current execution line.  This fixes redisplay of the current line
4319         when stepping through the code with "next" or "step".
4320
4321 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4322
4323         * source-cache.c (source_cache::get_source_lines): Call
4324         find_source_lines to initialize s->nlines.  This fixes vertical
4325         scrolling of TUI source window when the DOWN arrow is pressed.
4326
4327 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4328
4329         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4330         linux-thread-db.c (_initialize_thread_db): Likewise.
4331
4332 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4333
4334         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4335         wclrtoeol in tui_show_source_line".  This reverts changes made in
4336         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4337
4338 2019-03-15  Tom Tromey  <tom@tromey.com>
4339
4340         * symtab.h (struct minimal_symbol): Derive from
4341         general_symbol_info.
4342         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4343         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4344         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4345         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4346         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4347         (MSYMBOL_SEARCH_NAME): Update.
4348         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4349         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4350         * minsyms.c (minimal_symbol_reader::record_full): Update.
4351
4352 2019-03-15  Tom Tromey  <tom@tromey.com>
4353
4354         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4355
4356 2019-03-15  Tom Tromey  <tom@tromey.com>
4357
4358         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4359         unique_xmalloc_ptr.
4360         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4361         Update.
4362         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4363         (build_minimal_symbol_hash_tables)
4364         (minimal_symbol_reader::install): Update.
4365
4366 2019-03-15  Tom Tromey  <tom@tromey.com>
4367
4368         * symtab.c (create_demangled_names_hash): Update.
4369         (symbol_set_names): Update.
4370         * objfiles.h (struct objfile_per_bfd_storage)
4371         <demangled_names_hash>: Now an htab_up.
4372         * objfiles.c (objfile_per_bfd_storage): Simplify.
4373
4374 2019-03-15  Tom Tromey  <tom@tromey.com>
4375
4376         * objfiles.h (struct objfile_per_bfd_storage): Declare
4377         destructor.
4378         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4379         New.
4380         (get_objfile_bfd_data): Use new.  Don't initialize
4381         language_of_main.
4382         (free_objfile_per_bfd_storage): Remove.
4383         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4384
4385 2019-03-15  Tom Tromey  <tom@tromey.com>
4386
4387         * symfile.c (reread_symbols): Update.
4388         * objfiles.c (objfile::objfile): Update.
4389         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4390         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4391         comment.
4392         (minimal_symbol_reader::install): Update.
4393         (terminate_minimal_symbol_table): Remove.
4394         * jit.c (jit_object_close_impl): Update.
4395
4396 2019-03-15  Tom Tromey  <tom@tromey.com>
4397
4398         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4399         initializations.
4400
4401 2019-03-15  Tom Tromey  <tom@tromey.com>
4402
4403         * objfiles.h (struct objfile_per_bfd_storage)
4404         <demangled_hash_languages>: Now a bitset.
4405         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4406         (lookup_minimal_symbol): Update.
4407
4408 2019-03-15  Tom Tromey  <tom@tromey.com>
4409
4410         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4411         Don't return the symbol.
4412         * coffread.c (record_minimal_symbol): Use record_full.
4413
4414 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4415
4416         The MS-Windows port of ncurses fails to switch to a color pair if
4417         one or both of the colors are the implicit default colors.  This
4418         change records the default colors when TUI is initialized, and
4419         then specifies them explicitly when a color pair uses the default
4420         colors.  This allows color styling in TUI mode on MS-Windows.
4421
4422         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4423         ncurses_norm_attr.
4424         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4425         colors in ncurses_norm_attr.
4426         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4427         "none", replace it with the default color recorded in
4428         ncurses_norm_attr.
4429
4430 2019-03-14  Tom Tromey  <tromey@adacore.com>
4431
4432         * source-cache.h (class source_cache) <get_source_lines>: Return
4433         std::string.
4434         * source-cache.c (source_cache::extract_lines): Handle case where
4435         first_pos==npos.  Return std::string.
4436         (source_cache::get_source_lines): Update.
4437
4438 2019-03-14  Tom Tromey  <tromey@adacore.com>
4439
4440         * NEWS: Add item for "style sources" commands.
4441         * source-cache.c (source_cache::get_source_lines): Check
4442         source_styling.
4443         * cli/cli-style.c (source_styling): New global.
4444         (_initialize_cli_style): Add "style sources" commands.
4445         (show_style_sources): New function.
4446         * cli/cli-style.h (source_styling): Declare.
4447
4448 2019-03-14  Pedro Alves  <palves@redhat.com>
4449             Tom Tromey  <tromey@adacore.com>
4450
4451         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4452         * tui/tui-winsource.c (tui_refill_source_window): New function,
4453         from...
4454         (tui_horizontal_source_scroll): ... here.  Move some logic.
4455         * cli/cli-style.c (set_style_enabled): Notify new observable.
4456         * tui/tui-hooks.c (tui_redisplay_source): New function.
4457         (tui_attach_detach_observers): Attach or detach
4458         tui_redisplay_source.
4459         * observable.h (source_styling_changed): New observable.
4460         * observable.c: Define source_styling_changed observable.
4461
4462 2019-03-13  Tom Tromey  <tromey@adacore.com>
4463
4464         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4465         (i386_gnu_nat_target::store_registers): Update.
4466         * target-debug.h (target_debug_print_std_string): New macro.
4467         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4468         * windows-tdep.c (display_one_tib): Update.
4469         * tui/tui-stack.c (tui_make_status_line): Update.
4470         * top.c (print_inferior_quit_action): Update.
4471         * thread.c (thr_try_catch_cmd): Update.
4472         (add_thread_with_info): Update.
4473         (thread_target_id_str): Update.
4474         (thr_try_catch_cmd): Update.
4475         (thread_command): Update.
4476         (thread_find_command): Update.
4477         * record-btrace.c (record_btrace_target::info_record)
4478         (record_btrace_resume_thread, record_btrace_target::resume)
4479         (record_btrace_cancel_resume, record_btrace_step_thread)
4480         (record_btrace_target::wait, record_btrace_target::wait)
4481         (record_btrace_target::wait, record_btrace_target::stop): Update.
4482         * progspace.c (print_program_space): Update.
4483         * process-stratum-target.c
4484         (process_stratum_target::thread_address_space): Update.
4485         * linux-fork.c (linux_fork_mourn_inferior)
4486         (detach_checkpoint_command, info_checkpoints_command)
4487         (linux_fork_context): Update.
4488         (linux_fork_detach): Update.
4489         (class scoped_switch_fork_info): Update.
4490         (delete_checkpoint_command): Update.
4491         * infrun.c (follow_fork_inferior): Update.
4492         (follow_fork_inferior): Update.
4493         (proceed_after_vfork_done): Update.
4494         (handle_vfork_child_exec_or_exit): Update.
4495         (follow_exec): Update.
4496         (displaced_step_prepare_throw): Update.
4497         (displaced_step_restore): Update.
4498         (start_step_over): Update.
4499         (resume_1): Update.
4500         (clear_proceed_status_thread): Update.
4501         (proceed): Update.
4502         (print_target_wait_results): Update.
4503         (do_target_wait): Update.
4504         (context_switch): Update.
4505         (stop_all_threads): Update.
4506         (restart_threads): Update.
4507         (finish_step_over): Update.
4508         (handle_signal_stop): Update.
4509         (switch_back_to_stepped_thread): Update.
4510         (keep_going_pass_signal): Update.
4511         (print_exited_reason): Update.
4512         (normal_stop): Update.
4513         * inferior.c (inferior_pid_to_str): Change return type.
4514         (print_selected_inferior): Update.
4515         (add_inferior): Update.
4516         (detach_inferior): Update.
4517         * dummy-frame.c (fprint_dummy_frames): Update.
4518         * dcache.c (dcache_info_1): Update.
4519         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4520         (btrace_fetch, btrace_clear): Update.
4521         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4522         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4523         type.
4524         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4525         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4526         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4527         * gdbarch.c, gdbarch.h: Rebuild.
4528         * gdbarch.sh (core_pid_to_str): Change return type.
4529         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4530         return type.
4531         (windows_nat_target::pid_to_str): Change return type.
4532         (windows_delete_thread): Update.
4533         (windows_nat_target::attach): Update.
4534         (windows_nat_target::files_info): Update.
4535         * target-delegates.c: Rebuild.
4536         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4537         return type.
4538         (sol_thread_target::pid_to_str): Change return type.
4539         * remote.c (class remote_target) <pid_to_str>: Change return
4540         type.
4541         (remote_target::pid_to_str): Change return type.
4542         (extended_remote_target::attach, remote_target::remote_stop_ns)
4543         (remote_target::remote_notif_remove_queued_reply)
4544         (remote_target::push_stop_reply, remote_target::disable_btrace):
4545         Update.
4546         (extended_remote_target::attach): Update.
4547         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4548         type.
4549         (gdbsim_target::pid_to_str): Change return type.
4550         * ravenscar-thread.c (struct ravenscar_thread_target)
4551         <pid_to_str>: Change return type.
4552         (ravenscar_thread_target::pid_to_str): Change return type.
4553         * procfs.c (class procfs_target) <pid_to_str>: Change return
4554         type.
4555         (procfs_target::pid_to_str): Change return type.
4556         (procfs_target::attach): Update.
4557         (procfs_target::detach): Update.
4558         (procfs_target::fetch_registers): Update.
4559         (procfs_target::store_registers): Update.
4560         (procfs_target::wait): Update.
4561         (procfs_target::files_info): Update.
4562         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4563         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4564         return type.
4565         (nto_procfs_target::pid_to_str): Change return type.
4566         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4567         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4568         return type.
4569         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4570         (exit_lwp): Update.
4571         (attach_proc_task_lwp_callback, get_detach_signal)
4572         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4573         (linux_nat_target::resume, wait_lwp, stop_callback)
4574         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4575         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4576         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4577         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4578         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4579         type.
4580         (inf_ptrace_target::attach): Update.
4581         (inf_ptrace_target::files_info): Update.
4582         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4583         type.
4584         (go32_nat_target::pid_to_str): Change return type.
4585         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4586         (gnu_nat_target::wait): Update.
4587         (gnu_nat_target::wait): Update.
4588         (gnu_nat_target::resume): Update.
4589         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4590         (fbsd_nat_target::wait): Update.
4591         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4592         type.
4593         (darwin_nat_target::attach): Update.
4594         * corelow.c (class core_target) <pid_to_str>: Change return type.
4595         (core_target::pid_to_str): Change return type.
4596         * target.c (normal_pid_to_str): Change return type.
4597         (default_pid_to_str): Likewise.
4598         (target_pid_to_str): Change return type.
4599         (target_translate_tls_address): Update.
4600         (target_announce_detach): Update.
4601         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4602         return type.
4603         (bsd_uthread_target::pid_to_str): Change return type.
4604         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4605         type.
4606         (bsd_kvm_target::pid_to_str): Change return type.
4607         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4608         return type.
4609         (aix_thread_target::pid_to_str): Change return type.
4610         * target.h (struct target_ops) <pid_to_str>: Change return type.
4611         (target_pid_to_str, normal_pid_to_str): Likewise.
4612         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4613         type.
4614         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4615         type.
4616         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4617         return type.
4618         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4619         type.
4620         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4621         type.
4622         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4623         return type.
4624
4625 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4626
4627         * NEWS: Mention that the new default MI version is 3.  Mention
4628         changes to the output of commands and events that deal with
4629         multi-location breakpoints.
4630         * breakpoint.c: Include "mi/mi-out.h".
4631         (print_one_breakpoint): Change output syntax if using MI version
4632         >= 3.
4633         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4634         New.
4635         (mi_multi_location_breakpoint_output_fixed): New.
4636         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4637         (mi_cmd_fix_multi_location_breakpoint_output): New.
4638         (mi_multi_location_breakpoint_output_fixed): New.
4639         * mi/mi-cmds.c (mi_cmds): Register command
4640         -fix-multi-location-breakpoint-output.
4641         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4642         interpreter "mi".
4643
4644 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4645
4646         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4647         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4648         instantiate mi_ui_out based on interpreter name.
4649         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4650         * mi/mi-main.c (mi_load_progress): Likewise.
4651
4652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4653
4654         * NEWS: Combine separate "New targets" sections for 8.3.
4655
4656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4657
4658         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4659         (ppcfbsd_init_abi): Install gdbarch
4660         "fetch_tls_load_module_address" and "get_thread_local_address"
4661         methods.
4662
4663 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4664
4665         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4666         (riscv_fbsd_init_abi): Install gdbarch
4667         "fetch_tls_load_module_address" and "get_thread_local_address"
4668         methods.
4669
4670 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4671
4672         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4673         (i386fbsd_init_abi): Install gdbarch
4674         "fetch_tls_load_module_address" and "get_thread_local_address"
4675         methods.
4676
4677 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4678
4679         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4680         (amd64fbsd_init_abi): Install gdbarch
4681         "fetch_tls_load_module_address" and "get_thread_local_address"
4682         methods.
4683
4684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4685
4686         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4687         (struct fbsd_pspace_data): New type.
4688         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4689         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4690         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4691         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4692         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4693
4694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4695
4696         * gdbtypes.c (lookup_struct_elt): New function.
4697         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4698         * gdbtypes.h (struct struct_elt): New type.
4699         (lookup_struct_elt): New prototype.
4700
4701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4702
4703         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4704         remove disabled code block.
4705
4706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4707
4708         * gdbarch.sh (get_thread_local_address): New method.
4709         * gdbarch.h, gdbarch.c: Regenerate.
4710         * target.c (target_translate_tls_address): Use
4711         gdbarch_get_thread_local_address if present instead of
4712         target::get_thread_local_address.
4713
4714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4715
4716         * target.h (target::get_thread_local_address): Update comment.
4717
4718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4719
4720         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4721         objfile->separate_debug_objfile_backlink if not NULL.
4722
4723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4724
4725         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4726         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4727         (amd64bsd_store_inferior_registers): Likewise.
4728         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4729         Enable segment base registers.
4730         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4731         PT_GETFSBASE and PT_GETGSBASE.
4732         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4733         PT_SETGSBASE.
4734         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4735         segment base registers.
4736         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4737
4738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4739
4740         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4741         Update calls to i386_target_description to add 'segments'
4742         parameter.
4743         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4744         add segment base registers.
4745         * arch/i386.c (i386_create_target_description): Add 'segments'
4746         parameter to enable segment base registers.
4747         * arch/i386.h (i386_create_target_description): Likewise.
4748         * features/i386/32bit-segments.xml: New file.
4749         * features/i386/32bit-segments.c: Generate.
4750         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4751         call to i386_target_description to add 'segments' parameter.
4752         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4753         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4754         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4755         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4756         if feature is present.
4757         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4758         Add 'segments' parameter to call to i386_target_description.
4759         (i386_target_description): Add 'segments' parameter to enable
4760         segment base registers.
4761         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4762         to call to i386_target_description.
4763         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4764         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4765         Define I386_NUM_REGS.
4766         (i386_target_description): Add 'segments' parameter to enable
4767         segment base registers.
4768
4769 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4770
4771         PR/24325
4772         * source-cache.c: #undef open and close, to avoid unresolved
4773         externals during linking.
4774
4775 2019-03-12  Tom Tromey  <tromey@adacore.com>
4776
4777         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4778         const.  Add initializers.
4779         (_initialize_remote): Don't initialize ptid globals.
4780
4781 2019-03-12  Pedro Alves  <palves@redhat.com>
4782
4783         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4784
4785 2019-03-12  Pedro Alves  <palves@redhat.com>
4786
4787         * cp-name-parser.y (main): Remove unused 'len' variable.
4788
4789 2019-03-12  Tom Tromey  <tromey@adacore.com>
4790
4791         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4792         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4793
4794 2019-03-12  Tom Tromey  <tromey@adacore.com>
4795
4796         * linux-nat.c (iterate_over_lwps): Update.
4797         (stop_callback): Remove parameter.
4798         (stop_wait_callback, detach_callback, resume_set_callback)
4799         (select_singlestep_lwp_callback, set_ignore_sigint)
4800         (status_callback, resumed_callback, resume_clear_callback)
4801         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4802         data parameter.
4803         (linux_nat_target::detach, linux_nat_target::resume)
4804         (linux_stop_and_wait_all_lwps, select_event_lwp)
4805         (linux_nat_filter_event, linux_nat_wait_1)
4806         (linux_nat_target::kill, linux_nat_target::stop)
4807         (linux_nat_target::stop): Update.
4808         (linux_nat_resume_callback): Change type.
4809         (resume_stopped_resumed_lwps, count_events_callback)
4810         (select_event_lwp_callback): Likewise.
4811         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4812         * arm-linux-nat.c (struct update_registers_data): Remove.
4813         (update_registers_callback): Change type.
4814         (arm_linux_insert_hw_breakpoint1): Update.
4815         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4816         parameter.
4817         (x86_linux_dr_set_addr): Update.
4818         (x86_linux_dr_set_control): Update.
4819         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4820         (iterate_over_lwps): Use gdb::function_view.
4821         * nat/aarch64-linux-hw-point.c (struct
4822         aarch64_dr_update_callback_param): Remove.
4823         (debug_reg_change_callback): Change type.
4824         (aarch64_notify_debug_reg_change): Update.
4825         * s390-linux-nat.c (s390_refresh_per_info): Update.
4826
4827 2019-03-11  Tom Tromey  <tromey@adacore.com>
4828
4829         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4830         redundant assignment to "this_cu".
4831
4832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4833
4834         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4835
4836 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4837
4838         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4839         from...
4840         (rank_one_type): ... this.
4841
4842 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4843
4844         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4845         from...
4846         (rank_one_type): ... this.
4847
4848 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4849
4850         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4851         from...
4852         (rank_one_type): ... this.
4853
4854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4855
4856         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4857         from...
4858         (rank_one_type): ... this.
4859
4860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4861
4862         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4863         from...
4864         (rank_one_type): ... this.
4865
4866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4867
4868         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4869         from...
4870         (rank_one_type): ... this.
4871
4872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4873
4874         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4875         from...
4876         (rank_one_type): ... this.
4877
4878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4879
4880         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4881         from...
4882         (rank_one_type): ... this.
4883
4884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4885
4886         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4887         from...
4888         (rank_one_type): ... this.
4889
4890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4891
4892         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4893         from...
4894         (rank_one_type): ... this.
4895
4896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4897
4898         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4899         from...
4900         (rank_one_type): ... this.
4901
4902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4903
4904         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4905         from...
4906         (rank_one_type): ... this.
4907
4908 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4909
4910         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4911         inferior-events' shows the example events.
4912
4913 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4914
4915         Support styling on native MS-Windows console
4916
4917         PR/24315
4918         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4919         on MS-Windows if $TERM is not defined.
4920
4921         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4922
4923         * posix-hdep.c (gdb_console_fputs):
4924         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4925         functions.
4926         * ui-file.h (gdb_console_fputs): Add prototype.
4927
4928         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4929         back to fputs only if the former returns zero.
4930
4931 2019-03-07  Tom Tromey  <tom@tromey.com>
4932
4933         * symmisc.c (print_symbol_bcache_statistics): Update.
4934         (print_objfile_statistics): Update.
4935         * symfile.c (allocate_symtab): Update.
4936         * stabsread.c: Don't include bcache.h.
4937         * psymtab.h (struct psymbol_bcache): Don't declare.
4938         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4939         (psymbol_bcache_init, psymbol_bcache_free)
4940         (psymbol_bcache_get_bcache): Don't declare.
4941         * psymtab.c (struct psymbol_bcache): Remove.
4942         (psymtab_storage::psymtab_storage): Update.
4943         (psymtab_storage::~psymtab_storage): Update.
4944         (psymbol_bcache_init, psymbol_bcache_free)
4945         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4946         (add_psymbol_to_bcache): Update.
4947         (allocate_psymtab): Update.
4948         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4949         macro_cache>: No longer pointers.
4950         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4951         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4952         * macrotab.c (macro_bcache): Update.
4953         * macroexp.c: Don't include bcache.h.
4954         * gdbtypes.c (check_types_worklist): Update.
4955         (types_deeply_equal): Remove TRY/CATCH.  Update.
4956         * elfread.c (elf_symtab_read): Update.
4957         * dwarf2read.c: Don't include bcache.h.
4958         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4959         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4960         (print_bcache_statistics, bcache_memory_used): Don't declare.
4961         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4962         methods.  Rename all data members.
4963         * bcache.c (struct bcache): Move to bcache.h.
4964         (bcache::expand_hash_table): Rename from expand_hash_table.
4965         (bcache): Remove.
4966         (bcache::insert): Rename from bcache_full.
4967         (bcache::compare): Rename from bcache_compare.
4968         (bcache_xmalloc): Remove.
4969         (bcache::~bcache): Rename from bcache_xfree.
4970         (bcache::print_statistics): Rename from print_bcache_statistics.
4971         (bcache::memory_used): Rename from bcache_memory_used.
4972
4973 2019-03-07  Pedro Alves  <palves@redhat.com>
4974
4975         * infrun.c (normal_stop): Also check for
4976         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4977
4978 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4979
4980         * f-lang.c (value_from_host_double): Moved to...
4981         * value.c (value_from_host_double): ...here.
4982         * value.h (value_from_host_double): Declare.
4983         * guile/scm-math.c (vlscm_convert_typed_number): Use
4984         value_from_host_double.
4985         (vlscm_convert_number): Likewise.
4986         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4987         * python/py-value.c (convert_value_from_python): Likewise.
4988
4989 2019-03-06  Tom Tromey  <tom@tromey.com>
4990
4991         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4992
4993 2019-03-06  Tom Tromey  <tom@tromey.com>
4994
4995         * utils.h (free_current_contents): Don't declare.
4996         * utils.c (free_current_contents): Remove.
4997
4998 2019-03-06  Tom Tromey  <tom@tromey.com>
4999
5000         * top.c (quit_force): Update.
5001         * main.c (captured_command_loop): Update.
5002         * common/new-op.c (operator new): Update.
5003         * common/common-exceptions.c (struct catcher)
5004         <save_cleanup_chain>: Remove member.
5005         (exceptions_state_mc_init): Update.
5006         (exception_try_scope_entry): Return nullptr.
5007         (exception_try_scope_exit, exception_rethrow)
5008         (throw_exception_sjlj, throw_exception_cxx): Update.
5009         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5010         (all_cleanups, do_cleanups, discard_cleanups)
5011         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5012         (restore_cleanups, restore_final_cleanups): Don't declare.
5013         (do_final_cleanups): Remove parameter.
5014         * common/cleanups.c (cleanup_chain, make_cleanup)
5015         (make_cleanup_dtor, all_cleanups, do_cleanups)
5016         (discard_my_cleanups, discard_cleanups)
5017         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5018         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5019         (null_cleanup): Remove.
5020         (do_final_cleanups): Remove parameter.
5021
5022 2019-03-06  Tom Tromey  <tom@tromey.com>
5023
5024         * remote.c (remote_target::remote_parse_stop_reply): Use
5025         unique_xmalloc_ptr.
5026
5027 2019-03-06  Tom Tromey  <tom@tromey.com>
5028
5029         * stabsread.c (struct stabs_field_info): Rename from field_info.
5030         <list, fnlist>: Add initializers.
5031         <obstack>: New member.
5032         (read_member_functions, read_struct_fields, read_baseclasses):
5033         Allocate on obstack.  Don't use cleanups.
5034         (read_one_struct_field, read_member_functions, read_struct_fields)
5035         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5036         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5037         (read_struct_type): Update.
5038
5039 2019-03-06  Tom Tromey  <tom@tromey.com>
5040
5041         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5042         * common/filestuff.h (make_cleanup_close): Don't declare.
5043         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5044         Remove.
5045
5046 2019-03-06  Tom Tromey  <tom@tromey.com>
5047
5048         * solib-aix.c: Use make_scope_exit.
5049
5050 2019-03-06  Tom Tromey  <tom@tromey.com>
5051
5052         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5053         Use make_scope_exit.
5054
5055 2019-03-06  Tom Tromey  <tom@tromey.com>
5056
5057         * solib-svr4.c (disable_probes_interface): Remove parameter.
5058         (svr4_handle_solib_event): Use make_scope_exit.
5059
5060 2019-03-06  Tom Tromey  <tom@tromey.com>
5061
5062         * remote.c (struct stop_reply_deleter): Remove.
5063         (stop_reply_up): Update.
5064         (struct stop_reply): Derive from notif_event.  Don't typedef.
5065         <regcache>: Now a std::vector.
5066         (stop_reply_xfree): Remove.
5067         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5068         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5069         (remote_target::discard_pending_stop_replies): Use delete.
5070         (remote_target::remote_parse_stop_reply): Update.
5071         (remote_target::process_stop_reply): Update.
5072         * remote-notif.h (struct notif_event): Add virtual destructor.
5073         Remove "dtr" member.
5074         (struct notif_client) <alloc_event>: Return a unique_ptr.
5075         (notif_event_xfree): Don't declare.
5076         (notif_event_up): New typedef.
5077         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5078         (notif_event_xfree, do_notif_event_xfree): Remove.
5079         (remote_notif_state_xfree): Update.
5080
5081 2019-03-06  Tom Tromey  <tom@tromey.com>
5082
5083         * infrun.c (displaced_step_clear_cleanup): Now a
5084         forward_scope_exit type.
5085         (displaced_step_prepare_throw): Update.
5086         (displaced_step_fixup): Update.
5087
5088 2019-03-06  Tom Tromey  <tom@tromey.com>
5089
5090         * inferior.h (class inferior): Update comment.
5091         * gdbthread.h (class thread_info): Update comment.
5092
5093 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5094             Tom Tromey  <tom@tromey.com>
5095
5096         * stabsread.h (struct stab_section_list): Remove.
5097         (coffstab_build_psymtabs): Update.
5098         * dbxread.c (symbuf_sections): Now a std::vector.
5099         (sect_idx): New global.
5100         (fill_symbuf): Update.
5101         (coffstab_build_psymtabs): Change type of stabsects parameter.
5102         Update.
5103         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5104         std::vector.
5105         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5106         (coff_locate_sections): Update.
5107         (coff_symfile_read): Remove cleanups.  Update.
5108         (init_stringtab): Add storage parameter.
5109         (free_stringtab, free_stringtab_cleanup): Remove.
5110         (init_lineno): Add storage parameter.
5111         (free_linetab, free_linetab_cleanup): Remove.
5112
5113 2019-03-06  Pedro Alves  <palves@redhat.com>
5114
5115         * linux-fork.c (fork_info::clobber_regs): Delete.
5116         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5117         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5118         comment.  Adjust.
5119         (scoped_switch_fork_info::scoped_switch_fork_info)
5120         (checkpoint_command, linux_fork_context): Adjust
5121         fork_save_infrun_state calls.
5122
5123 2019-03-06  Pedro Alves  <palves@redhat.com>
5124
5125         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5126         (inf_has_multiple_threads): Return 'bool' and rewrite using
5127         inferior_info::threads().
5128
5129 2019-03-06  Pedro Alves  <palves@redhat.com>
5130
5131         * linux-fork.c: Include <list>.
5132         (fork_list): Now a std::list instance.
5133         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5134         (forks_exist_p, find_last_fork): Adjust.
5135         (new_fork): Delete.
5136         (one_fork_p): New.
5137         (add_fork): Adjust.
5138         (free_fork): Delete, folded into fork_info::~fork_info().
5139         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5140         Adjust.
5141         (init_fork_list): Delete.
5142         (linux_fork_killall, linux_fork_mourn_inferior)
5143         (linux_fork_detach, info_checkpoints_command): Adjust.
5144         (_initialize_linux_fork): No longer call init_fork_list.
5145
5146 2019-03-06  Pedro Alves  <palves@redhat.com>
5147
5148         * linux-fork.c (new_fork): New, split out of ...
5149         (add_fork): ... this.  Return void.  Move "first fork" special
5150         case from here, to ...
5151         (checkpoint_command): ... here.
5152         * linux-linux.h (add_fork): Return void.
5153
5154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5155
5156         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5157
5158 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5159             Chris January  <chris.january@arm.com>
5160             David Lecomber  <david.lecomber@arm.com>
5161
5162         * f-exp.y: New token, UNOP_INTRINSIC.
5163         (exp): New pattern using UNOP_INTRINSIC token.
5164         (f77_keywords): Add 'abs' keyword.
5165         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5166         (value_from_host_double): New function.
5167         (evaluate_subexp_f): Support UNOP_ABS.
5168
5169 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5172         types.
5173
5174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5175
5176         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5177         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5178         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5179
5180 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5181
5182         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5183
5184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5185             Chris January  <chris.january@arm.com>
5186
5187         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5188         * f-exp.y: Define 'KIND' token.
5189         (exp): New pattern for KIND expressions.
5190         (ptype): Handle types with a kind extension.
5191         (direct_abs_decl): Extend to spot kind extensions.
5192         (f77_keywords): Add 'kind' to the list.
5193         (push_kind_type): New function.
5194         (convert_to_kind_type): New function.
5195         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5196         * parse.c (operator_length_standard): Likewise.
5197         * parser-defs.h (enum type_pieces): Add tp_kind.
5198         * std-operator.def: Add UNOP_KIND.
5199
5200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5201
5202         * f-exp.y (f_parse): Set yydebug.
5203
5204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5205
5206         * f-lang.c (evaluate_subexp_f): New function.
5207         (exp_descriptor_f): New global.
5208         (f_language_defn): Use exp_descriptor_f instead of
5209         exp_descriptor_standard.
5210
5211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5212
5213         * f-exp.y (struct token): Add comments.
5214         (dot_ops): Remove uppercase versions and the end marker.
5215         (f77_keywords): Likewise.
5216         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5217         entries in the dot_ops array are case insensitive, and use
5218         strncasecmp to compare strings.  Also some whitespace cleanup in
5219         this area.  Similar for the f77_keywords array, except entries in
5220         this list might be case sensitive.
5221
5222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * f-exp.y (struct f77_boolean_val): Add comments.
5225         (boolean_values): Remove uppercase versions, and end marker.
5226         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5227         and use strncasecmp to achieve case insensitivity.  Additionally,
5228         perform whitespace cleanup around this code.
5229
5230 2019-03-06  Tom Tromey  <tromey@adacore.com>
5231
5232         * remote-sim.c (gdbsim_target_open): Use result of
5233         gdb_argv::release.
5234
5235 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5236         Dirk Schubert  <dirk.schubert@arm.com>
5237         Chris January  <chris.january@arm.com>
5238
5239         * eval.c (evaluate_subexp_standard): Call Fortran argument
5240         wrapping logic.
5241         * f-lang.c (struct value): A value which can be passed into a
5242         Fortran function call.
5243         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5244         where appropriate.
5245         (struct type): Value ready for a Fortran function call.
5246         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5247         is needed.
5248         * f-lang.h (fortran_argument_convert): Declaration.
5249         (fortran_preserve_arg_pointer): Declaration.
5250         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5251
5252 2019-03-05  Tom Tromey  <tromey@adacore.com>
5253
5254         * python/py-prettyprint.c (print_string_repr): Remove #if.
5255         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5256
5257 2019-03-05  Tom Tromey  <tromey@adacore.com>
5258
5259         * target.c (the_dummy_target): Move later.  Change type to
5260         "dummy_target".
5261         (initialize_targets): Don't initialize the_dummy_target.
5262
5263 2019-03-05  Tom Tromey  <tromey@adacore.com>
5264
5265         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5266         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5267
5268 2019-03-05  Tom Tromey  <tromey@adacore.com>
5269
5270         * windows-nat.c (windows_nat_target::attach)
5271         (windows_nat_target::detach): Don't call gdb_flush.
5272         * valprint.c (generic_val_print, val_print, val_print_string):
5273         Don't call gdb_flush.
5274         * utils.c (defaulted_query): Don't call gdb_flush.
5275         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5276         * target.c (target_announce_detach): Don't call gdb_flush.
5277         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5278         * remote.c (extended_remote_target::attach): Don't call
5279         gdb_flush.
5280         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5281         * printcmd.c (do_examine): Don't call gdb_flush.
5282         (info_display_command): Don't call gdb_flush.
5283         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5284         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5285         * memattr.c (info_mem_command): Don't call gdb_flush.
5286         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5287         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5288         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5289         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5290         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5291         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5292         (gnu_nat_target::detach): Don't call gdb_flush.
5293         * f-valprint.c (f_val_print): Don't call gdb_flush.
5294         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5295         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5296         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5297         gdb_flush.
5298         * c-valprint.c (c_val_print): Don't call gdb_flush.
5299         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5300
5301 2019-03-05  Tom Tromey  <tromey@adacore.com>
5302
5303         * varobj.c (update_dynamic_varobj_children): Update.
5304         (install_default_visualizer): Use reset, not release.
5305         * value.c (set_internalvar): Update.
5306         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5307         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5308         ATTRIBUTE_UNUSED_RESULT.
5309
5310 2019-03-05  Tom Tromey  <tromey@adacore.com>
5311
5312         * remote.c (class scoped_remote_fd) <release>: Add
5313         ATTRIBUTE_UNUSED_RESULT.
5314
5315 2019-03-05  Tom Tromey  <tromey@adacore.com>
5316
5317         * macroexp.c (struct macro_buffer) <release>: Add
5318         ATTRIBUTE_UNUSED_RESULT.
5319
5320 2019-03-05  Tom Tromey  <tromey@adacore.com>
5321
5322         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5323         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5324         ATTRIBUTE_UNUSED_RESULT.
5325
5326 2019-03-05  Tom Tromey  <tromey@adacore.com>
5327
5328         * common/scoped_fd.h (class scoped_fd) <release>: Add
5329         ATTRIBUTE_UNUSED_RESULT.
5330
5331 2019-03-05  Tom Tromey  <tromey@adacore.com>
5332
5333         * parser-defs.h (struct parser_state) <release>: Add
5334         ATTRIBUTE_UNUSED_RESULT.
5335
5336 2019-03-05  Tom Tromey  <tromey@adacore.com>
5337
5338         * utils.h (class gdb_argv) <release>: Add
5339         ATTRIBUTE_UNUSED_RESULT.
5340         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5341
5342 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5343
5344         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5345         for-loop range, to avoid compiler warnings.
5346
5347         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5348         avoid compiler warnings about unused variables.
5349
5350         * NEWS: Mention end of support for native debugging on MS-Windows
5351         before XP.
5352
5353         PR gdb/24292
5354         * common/netstuff.c:
5355         * gdbserver/gdbreplay.c
5356         * gdbserver/remote-utils.c:
5357         * ser-tcp.c:
5358         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5359         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5360         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5361         'getaddrinfo' and 'freeaddrinfo' were not available before
5362         Windows XP, and mingw.org's MinGW headers by default define
5363         _WIN32_WINNT to 0x500.
5364
5365 2019-03-01  Gary Benson <gbenson@redhat.com>
5366
5367         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5368
5369 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5370             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5371
5372         PR gdb/8527
5373         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5374         set_sigint_trap, clear_sigint_trap.
5375
5376 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5377
5378         * target.c (target_detach): Clear the regcache and the
5379         frame cache.
5380
5381 2019-02-27  Pedro Alves  <palves@redhat.com>
5382
5383         * utils.c (set_screen_size): When we cap the height/width sizes,
5384         tweak the corresponding command variable to show "unlimited":
5385
5386 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5387             Pedro Alves  <palves@redhat.com>
5388
5389         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5390         before calling rl_set_screen_size.
5391
5392 2019-02-27  Tom Tromey  <tromey@adacore.com>
5393
5394         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5395         define.
5396         * python/py-value.c: Remove Python 2.4 workaround.
5397         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5398         workaround.
5399         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5400         Python 2.4 workaround.
5401         * python/python-internal.h: Remove Python 2.4 comment.
5402         (Py_ssize_t): Don't define.
5403         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5404         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5405         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5406         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5407         * python/python.c (do_start_initialization): Remove Python 2.4
5408         workaround.
5409         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5410         (print_children): Remove Python 2.4 workaround.
5411         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5412         workaround.
5413         (CHARBUFFERPROC_NAME): Remove.
5414         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5415         Python 2.4 workaround.
5416
5417 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5418
5419         * NEWS: Note minimum Python version.
5420
5421 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5422
5423         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5424         code from these functions.  Remove corresponding ifdefs.  Use
5425         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5426         Remove gotos and target of gotos.
5427         (infpy_search_memory): Likewise.
5428
5429 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5430
5431         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5432         (hppa_gdbarch_init): Don't register deleted functions with
5433         gdbarch.
5434
5435 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5436
5437         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5438         (h8300_unwind_sp): Delete.
5439         (h8300_dummy_id): Delete.
5440         (h8300_gdbarch_init): Don't register deleted functions with
5441         gdbarch.
5442
5443 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5444
5445         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5446         (ft32_unwind_pc): Delete.
5447         (ft32_unwind_sp): Delete.
5448         (ft32_gdbarch_init): Don't register deleted functions with
5449         gdbarch.
5450
5451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5452
5453         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5454         (frv_unwind_pc): Delete.
5455         (frv_unwind_sp): Delete.
5456         (frv_gdbarch_init): Don't register deleted functions with
5457         gdbarch.
5458
5459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5462         (riscv_unwind_pc): Delete.
5463         (riscv_unwind_sp): Delete.
5464         (riscv_gdbarch_init): Don't register deleted functions with
5465         gdbarch.
5466
5467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5468
5469         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5470         (csky_unwind_pc): Delete.
5471         (csky_unwind_sp): Delete.
5472         (csky_gdbarch_init): Don't register deleted functions with
5473         gdbarch.
5474
5475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5476
5477         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5478         (cris_unwind_pc): Delete.
5479         (cris_unwind_sp): Delete.
5480         (cris_gdbarch_init): Don't register deleted functions with
5481         gdbarch.
5482
5483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5486         (bfin_unwind_pc): Delete.
5487         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5488
5489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5492         (arm_unwind_pc): Delete.
5493         (arm_unwind_sp): Delete.
5494         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5495
5496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5497
5498         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5499         (arc_unwind_pc): Delete.
5500         (arc_unwind_sp): Delete.
5501         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5502
5503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5504
5505         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5506         (alpha_unwind_pc): Delete.
5507         (alpha_gdbarch_init): Don't register deleted functions with
5508         gdbarch.
5509
5510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5513         (aarch64_unwind_pc): Delete.
5514         (aarch64_unwind_sp): Delete.
5515         (aarch64_gdbarch_init): Don't register deleted functions with
5516         gdbarch.
5517
5518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5519
5520         * gdbtypes.c (type_align): Don't consider static members when
5521         computing structure alignment.
5522
5523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5526         return 0 for other types.
5527         * arch-utils.c (default_type_align): Always return 0.
5528         * gdbarch.h: Regenerate.
5529         * gdbarch.sh (type_align): Extend comment.
5530         * gdbtypes.c (type_align): Add additional comments, always call
5531         gdbarch_type_align before applying the default rules.
5532         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5533         generic code will then apply a suitable default.
5534         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5535         types, return 0 for other types.
5536
5537 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5538
5539         * NEWS: Create a new section for the next release branch.
5540         Rename the section of the current branch, now that it has
5541         been cut.
5542
5543 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5544
5545         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5546         * version.in: Bump version to 8.3.50.DATE-git.
5547
5548 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5549
5550         * aix-thread.c (ptid_cmp): Remove unused variable.
5551         (get_signaled_thread): Likewise.
5552         (store_regs_user_thread): Likewise.
5553         (store_regs_kernel_thread): Likewise.
5554         (fetch_regs_kernel_thread): Remove shadowed variable.
5555
5556 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5557
5558         * features/riscv/32bit-cpu.xml: Add register numbers.
5559         * features/riscv/32bit-fpu.c: Regenerate.
5560         * features/riscv/32bit-fpu.xml: Add register numbers.
5561         * features/riscv/64bit-cpu.xml: Add register numbers.
5562         * features/riscv/64bit-fpu.c: Regenerate.
5563         * features/riscv/64bit-fpu.xml: Add register numbers.
5564
5565 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5566
5567         * NEWS: Mention two argument form of gdb.Value constructor.
5568         * python/py-value.c (convert_buffer_and_type_to_value): New
5569         function.
5570         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5571         Add support for handling an optional second argument.  Call
5572         convert_buffer_and_type_to_value as appropriate.
5573         * python/python-internal.h (Py_buffer_deleter): New struct.
5574         (Py_buffer_up): New typedef.
5575
5576 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5577
5578         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5579         instead of releasing ownership.
5580
5581 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5582
5583         * dwarf2read.c (open_and_init_dwp_file): Call
5584         elf_numsections instead of bfd_count_sections to initialize
5585         dwp_file->num_sections.
5586
5587 2019-02-25  Tom Tromey  <tromey@adacore.com>
5588
5589         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5590
5591 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5592
5593         * gcore.in: Add '--readnever' option when invoking GDB.
5594
5595 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5596
5597         * MAINTAINERS: Update my email address.
5598
5599 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5600
5601         * build-id.c (build_id_to_debug_bfd_1): New function.
5602         (build_id_to_debug_bfd): Look for separate debug file in
5603         sysroot.
5604
5605 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5606
5607         * gdbarch.sh: Update the copyright year range that is placed into
5608         generated files.
5609
5610 2019-02-22  Keith Seitz  <keiths@redhat.com>
5611
5612         PR symtab/23853
5613         * linespec.c (create_sals_line_offset): Search for the default
5614         symtab's filename instead of its fullname.
5615
5616 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5617
5618         * NEWS: Update style defaults.
5619
5620 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5621
5622         * main.c (captured_main_1): Disable styling in batch mode.
5623
5624 2019-02-20  Tom Tromey  <tom@tromey.com>
5625
5626         * symtab.c (symtab_symbol_info): Fix typos.
5627
5628 2019-02-20  Tom Tromey  <tromey@adacore.com>
5629
5630         * findcmd.c (_initialize_mem_search): Use upper case for
5631         metasyntactic variables.
5632
5633 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5634
5635         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5636         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5637
5638 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5639
5640         * top.h (source_file_name): Change to std::string.
5641         * top.c (source_file_name): Likewise.
5642         (command_line_input): Adjust.
5643         * cli/cli-script.c (script_from_file): Adjust.
5644
5645 2019-02-19  Tom Tromey  <tromey@adacore.com>
5646
5647         * ravenscar-thread.c
5648         (ravenscar_thread_target::update_thread_list): Don't call
5649         ada_build_task_list.
5650         * ada-lang.h (ada_build_task_list): Don't declare.
5651         * ada-tasks.c (struct ada_tasks_inferior_data)
5652         <task_list_valid_p>: Now bool.
5653         (read_known_tasks, ada_task_list_changed)
5654         (ada_tasks_invalidate_inferior_data): Update.
5655         (read_known_tasks_array): Return bool.
5656         (read_known_tasks_list): Likewise.
5657         (read_known_tasks): Return void.
5658         (ada_build_task_list): Now static.
5659
5660 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5661
5662         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5663         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5664
5665 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5666
5667         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5668         variant for ada_tasks_pspace_data_handle and
5669         ada_tasks_inferior_data_handle.
5670         (ada_tasks_pspace_data_cleanup): New function.
5671         (ada_tasks_inferior_data_cleanup): New function.
5672
5673 2019-02-17  Tom Tromey  <tom@tromey.com>
5674
5675         * macrotab.h (macro_source_fullname): Return a std::string.
5676         * macrotab.c (macro_include, check_for_redefinition)
5677         (macro_undef, macro_lookup_definition, foreach_macro)
5678         (foreach_macro_in_scope): Update.
5679         (macro_source_fullname): Return a std::string.
5680         * macrocmd.c (show_pp_source_pos): Update.
5681
5682 2019-02-17  Tom Tromey  <tom@tromey.com>
5683
5684         * macrocmd.c (show_pp_source_pos): Style the file names.
5685
5686 2019-02-17  Tom Tromey  <tom@tromey.com>
5687
5688         PR tui/24197:
5689         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5690
5691 2019-02-17  Tom Tromey  <tom@tromey.com>
5692
5693         * ada-lang.c (user_select_syms): Use filtered printing.
5694         * utils.c (wrap_style): New global.
5695         (desired_style): Remove.
5696         (emit_style_escape): Add stream parameter.
5697         (set_output_style, reset_terminal_style, prompt_for_continue):
5698         Update.
5699         (flush_wrap_buffer): Only flush gdb_stdout.
5700         (wrap_here): Set wrap_style.
5701         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5702         treat escape sequences as a character.  Change when wrap buffer is
5703         flushed.
5704         (fputs_styled): Do not set the output style when the default is
5705         requested.
5706         * ui-style.h (struct ui_file_style) <is_default>: New method.
5707         * source.c (print_source_lines_base): Emit escape sequences in one
5708         piece.
5709
5710 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5711
5712         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5713         integers and enumeration types.
5714
5715 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5716
5717         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5718         instead of lookup_symbol_in_language
5719         (do_exact_match): New function.
5720         (ada_get_symbol_name_matcher): Return do_exact_match when
5721         doing a verbatim match.
5722
5723 2019-02-15  Tom Tromey  <tromey@adacore.com>
5724
5725         * ravenscar-thread.c (ravenscar_thread_target::resume)
5726         (ravenscar_thread_target::wait): Special case wildcard requests.
5727
5728 2019-02-15  Tom Tromey  <tromey@adacore.com>
5729
5730         * ravenscar-thread.c (base_ptid): Remove.
5731         (struct ravenscar_thread_target) <close>: New method.
5732         <m_base_ptid>: New member.
5733         <update_inferior_ptid, active_task, task_is_currently_active,
5734         runtime_initialized>: Declare methods.
5735         <ravenscar_thread_target>: Add constructor.
5736         (ravenscar_thread_target::task_is_currently_active)
5737         (ravenscar_thread_target::update_inferior_ptid)
5738         (ravenscar_runtime_initialized): Rename.  Now methods.
5739         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5740         (ravenscar_thread_target::update_thread_list): Update.
5741         (ravenscar_thread_target::active_task): Now method.
5742         (ravenscar_thread_target::store_registers)
5743         (ravenscar_thread_target::prepare_to_store)
5744         (ravenscar_thread_target::prepare_to_store)
5745         (ravenscar_thread_target::mourn_inferior): Update.
5746         (ravenscar_inferior_created): Use "new" to create target.
5747         (ravenscar_thread_target::get_ada_task_ptid): Update.
5748         (_initialize_ravenscar): Don't initialize base_ptid.
5749         (ravenscar_ops): Remove global.
5750
5751 2019-02-15  Tom Tromey  <tromey@adacore.com>
5752
5753         * target.h (push_target): Declare new overload.
5754         * target.c (push_target): New overload, taking an rvalue reference.
5755         * remote.c (remote_target::open_1): Use push_target overload.
5756         * corelow.c (core_target_open): Use push_target overload.
5757
5758 2019-02-15  Tom Tromey  <tromey@adacore.com>
5759
5760         * ravenscar-thread.c (is_ravenscar_task)
5761         (ravenscar_task_is_currently_active): Return bool.
5762         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5763         (_initialize_ravenscar): Remove "(void)".
5764         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5765         Return bool.
5766
5767 2019-02-15  Tom Tromey  <tromey@adacore.com>
5768
5769         * ravenscar-thread.c (ravenscar_runtime_initializer)
5770         (has_ravenscar_runtime, get_running_thread_id)
5771         (ravenscar_thread_target::resume): Fix indentation.
5772
5773 2019-02-15  Tom Tromey  <tromey@adacore.com>
5774
5775         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5776         from ravenscar_arch_ops.
5777         (sparc_ravenscar_ops::fetch_registers)
5778         (sparc_ravenscar_ops::store_registers): Now methods.
5779         (sparc_ravenscar_prepare_to_store): Remove.
5780         (sparc_ravenscar_ops): Redefine.
5781         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5782         methods and destructor.  Remove members.
5783         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5784         (ravenscar_thread_target::store_registers)
5785         (ravenscar_thread_target::prepare_to_store): Update.
5786         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5787         Remove.
5788         (struct ppc_ravenscar_powerpc_ops): Derive from
5789         ravenscar_arch_ops.
5790         (ppc_ravenscar_powerpc_ops::fetch_registers)
5791         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5792         (ppc_ravenscar_powerpc_ops): Redefine.
5793         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5794         (ppc_ravenscar_e500_ops::fetch_registers)
5795         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5796         (ppc_ravenscar_e500_ops): Redefine.
5797         * aarch64-ravenscar-thread.c
5798         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5799         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5800         (aarch64_ravenscar_fetch_registers)
5801         (aarch64_ravenscar_store_registers): Now methods.
5802         (aarch64_ravenscar_ops): Redefine.
5803
5804 2019-02-15  Tom Tromey  <tromey@adacore.com>
5805
5806         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5807         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5808         (ravenscar_thread_target::stopped_by_watchpoint)
5809         (ravenscar_thread_target::stopped_data_address)
5810         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5811
5812 2019-02-15  Tom Tromey  <tromey@adacore.com>
5813
5814         * ravenscar-thread.c: Fix some typos.
5815
5816 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5817             Tom Tromey  <tromey@adacore.com>
5818
5819         * ada-lang.c (ada_exception_sal): Change addr_string to a
5820         std::string.
5821         (create_ada_exception_catchpoint): Update.
5822
5823 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5824             Tom Tromey  <tromey@adacore.com>
5825
5826         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5827         (bp_location_ops): Remove.
5828         (base_breakpoint_allocate_location): Update.
5829         (free_bp_location): Update.
5830         * ada-lang.c (class ada_catchpoint_location)
5831         <ada_catchpoint_location>: Remove ops parameter.
5832         (ada_catchpoint_location_dtor): Remove.
5833         (ada_catchpoint_location_ops): Remove.
5834         (allocate_location_exception): Update.
5835         * breakpoint.h (struct bp_location_ops): Remove.
5836         (class bp_location) <bp_location>: Remove bp_location_ops
5837         parameter.
5838         <~bp_location>: Add destructor.
5839         <ops>: Remove.
5840
5841 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5842             Pedro Alves  <palves@redhat.com>
5843
5844         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5845         'PATH_MAX'.
5846
5847 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5848             Samuel Thibault  <samuel.thibault@gnu.org>
5849             Thomas Schwinge  <thomas@codesourcery.com>
5850
5851         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5852         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5853
5854 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5855
5856         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5857         (check_empty): Use "const char *".
5858
5859         * gnu-nat.c (gnu_nat_target::detach): Instead of
5860         'detach_inferior (pid)' call
5861         'detach_inferior (find_inferior_pid (pid))'.
5862
5863         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5864         'nat/fork-inferior.o'.
5865         * gnu-nat.c: #include "nat/fork-inferior.h".
5866
5867         * gnu-nat.c (gnu_nat_target::detach): Instead of
5868         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5869         * gnu-nat.h: #include "inf-child.h".
5870         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5871         'i386_gnu_nat_target::fetch_registers'.
5872         (gnu_store_registers): Rename/move to
5873         'i386_gnu_nat_target::store_registers'.
5874
5875         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5876         * gnu-nat.h (mach_thread_info): New function.
5877         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5878
5879         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5880
5881 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5882
5883         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5884
5885 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5886
5887         * windows-nat.c (windows_add_thread): Add new parameter
5888         "main_thread_p" with default value set to false.  Update
5889         function documentation as well as all callers.
5890         (windows_delete_thread): Likewise.
5891         (fake_create_process): Update call to windows_add_thread.
5892         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5893         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5894         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5895         call to windows_delete_thread.
5896
5897 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5898
5899         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5900
5901 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5902
5903         * symfile.c (find_separate_debug_file): Use canonical path of
5904         sysroot with child_path instead of gdb_sysroot if it is valid.
5905
5906 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5907
5908         * symfile.c (find_separate_debug_file): Use child_path to
5909         determine if an object file is under a sysroot.
5910
5911 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5912
5913         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5914         unittests/child-path-selftests.c.
5915         * common/pathstuff.c (child_path): New function.
5916         * common/pathstuff.h (child_path): New prototype.
5917         * unittests/child-path-selftests.c: New file.
5918
5919 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5920
5921         * symfile.c (find_separate_debug_file): Look for separate debug
5922         files in debug directories under the sysroot.
5923
5924 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5925
5926         * symtab.h (struct minimal_symbol data_p): New const method.
5927         (struct minimal_symbol text_p): Likewise.
5928         * symtab.c (output_source_filename): Use file name style
5929         to print file name.
5930         (print_symbol_info): Likewise.
5931         (print_msymbol_info): Use address style to print addresses.
5932         Use function name style to print executable text symbols.
5933         (expand_symtab_containing_pc): Use data_p.
5934         (find_pc_sect_compunit_symtab): Likewise.
5935
5936 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5937
5938         * breakpoint.c (describe_other_breakpoints): Use address style
5939         to print addresses.
5940         (say_where): Likewise.
5941
5942 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5943
5944         * ada-typeprint.c (print_func_type): Print function name
5945         style to print function name.
5946         * c-typeprint.c (c_print_type_1): Likewise.
5947
5948 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5949
5950         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5951         for execve.
5952
5953 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5954
5955         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5956         type_stack.
5957
5958 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5959
5960         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5961         TYPE_CODE_REF types.
5962
5963 2019-02-08  Jim Wilson  <jimw@sifive.com>
5964
5965         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5966         (riscv_linux_fregset): New.
5967         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5968
5969 2019-02-07  Tom Tromey  <tom@tromey.com>
5970
5971         * thread.c (thread_cancel_execution_command): Update.
5972         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5973         methods.
5974         (struct thread_fsm_ops): Remove.
5975         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5976         (thread_fsm_should_stop, thread_fsm_return_value)
5977         (thread_fsm_set_finished, thread_fsm_finished_p)
5978         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5979         Don't declare.
5980         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5981         * infrun.c (clear_proceed_status_thread)
5982         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5983         (print_stop_event): Update.
5984         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5985         Add constructor.
5986         (step_command_fsm_ops): Remove.
5987         (new_step_command_fsm): Remove.
5988         (step_1): Update.
5989         (step_command_fsm::should_stop): Rename from
5990         step_command_fsm_should_stop.
5991         (step_command_fsm::clean_up): Rename from
5992         step_command_fsm_clean_up.
5993         (step_command_fsm::do_async_reply_reason): Rename from
5994         step_command_fsm_async_reply_reason.
5995         (struct until_next_fsm): Inherit from thread_fsm.  Add
5996         constructor.
5997         (until_next_fsm_ops): Remove.
5998         (new_until_next_fsm): Remove.
5999         (until_next_fsm::should_stop): Rename from
6000         until_next_fsm_should_stop.
6001         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6002         (until_next_fsm::do_async_reply_reason): Rename from
6003         until_next_fsm_async_reply_reason.
6004         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6005         constructor.  Change type of breakpoint.
6006         (finish_command_fsm_ops): Remove.
6007         (new_finish_command_fsm): Remove.
6008         (finish_command_fsm::should_stop): Rename from
6009         finish_command_fsm_should_stop.
6010         (finish_command_fsm::clean_up): Rename from
6011         finish_command_fsm_clean_up.
6012         (finish_command_fsm::return_value): Rename from
6013         finish_command_fsm_return_value.
6014         (finish_command_fsm::do_async_reply_reason): Rename from
6015         finish_command_fsm_async_reply_reason.
6016         (finish_command): Update.
6017         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6018         Add constructor.
6019         (call_thread_fsm_ops): Remove.
6020         (call_thread_fsm::call_thread_fsm): Rename from
6021         new_call_thread_fsm.
6022         (call_thread_fsm::should_stop): Rename from
6023         call_thread_fsm_should_stop.
6024         (call_thread_fsm::should_notify_stop): Rename from
6025         call_thread_fsm_should_notify_stop.
6026         (run_inferior_call, call_function_by_hand_dummy): Update.
6027         * cli/cli-interp.c (should_print_stop_to_console): Update.
6028         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6029         Add constructor.  Change type of location_breakpoint,
6030         caller_breakpoint.
6031         (until_break_fsm_ops): Remove.
6032         (new_until_break_fsm): Remove.
6033         (until_break_fsm::should_stop): Rename from
6034         until_break_fsm_should_stop.
6035         (until_break_fsm::clean_up): Rename from
6036         until_break_fsm_clean_up.
6037         (until_break_fsm::do_async_reply_reason): Rename from
6038         until_break_fsm_async_reply_reason.
6039         (until_break_command): Update.
6040         * thread-fsm.c: Remove.
6041         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6042
6043 2019-02-07  Tom Tromey  <tom@tromey.com>
6044
6045         * yy-remap.h: Add include guard.
6046         * xtensa-tdep.h: Add include guard.
6047         * xcoffread.h: Rename include guard.
6048         * varobj-iter.h: Add include guard.
6049         * tui/tui.h: Rename include guard.
6050         * tui/tui-winsource.h: Rename include guard.
6051         * tui/tui-wingeneral.h: Rename include guard.
6052         * tui/tui-windata.h: Rename include guard.
6053         * tui/tui-win.h: Rename include guard.
6054         * tui/tui-stack.h: Rename include guard.
6055         * tui/tui-source.h: Rename include guard.
6056         * tui/tui-regs.h: Rename include guard.
6057         * tui/tui-out.h: Rename include guard.
6058         * tui/tui-layout.h: Rename include guard.
6059         * tui/tui-io.h: Rename include guard.
6060         * tui/tui-hooks.h: Rename include guard.
6061         * tui/tui-file.h: Rename include guard.
6062         * tui/tui-disasm.h: Rename include guard.
6063         * tui/tui-data.h: Rename include guard.
6064         * tui/tui-command.h: Rename include guard.
6065         * tic6x-tdep.h: Add include guard.
6066         * target/waitstatus.h: Rename include guard.
6067         * target/wait.h: Rename include guard.
6068         * target/target.h: Rename include guard.
6069         * target/resume.h: Rename include guard.
6070         * target-float.h: Rename include guard.
6071         * stabsread.h: Add include guard.
6072         * rs6000-tdep.h: Add include guard.
6073         * riscv-fbsd-tdep.h: Add include guard.
6074         * regformats/regdef.h: Rename include guard.
6075         * record.h: Rename include guard.
6076         * python/python.h: Rename include guard.
6077         * python/python-internal.h: Rename include guard.
6078         * python/py-stopevent.h: Rename include guard.
6079         * python/py-ref.h: Rename include guard.
6080         * python/py-record.h: Rename include guard.
6081         * python/py-record-full.h: Rename include guard.
6082         * python/py-record-btrace.h: Rename include guard.
6083         * python/py-instruction.h: Rename include guard.
6084         * python/py-events.h: Rename include guard.
6085         * python/py-event.h: Rename include guard.
6086         * procfs.h: Add include guard.
6087         * proc-utils.h: Add include guard.
6088         * p-lang.h: Add include guard.
6089         * or1k-tdep.h: Rename include guard.
6090         * observable.h: Rename include guard.
6091         * nto-tdep.h: Rename include guard.
6092         * nat/x86-linux.h: Rename include guard.
6093         * nat/x86-linux-dregs.h: Rename include guard.
6094         * nat/x86-gcc-cpuid.h: Add include guard.
6095         * nat/x86-dregs.h: Rename include guard.
6096         * nat/x86-cpuid.h: Rename include guard.
6097         * nat/ppc-linux.h: Rename include guard.
6098         * nat/mips-linux-watch.h: Rename include guard.
6099         * nat/linux-waitpid.h: Rename include guard.
6100         * nat/linux-ptrace.h: Rename include guard.
6101         * nat/linux-procfs.h: Rename include guard.
6102         * nat/linux-osdata.h: Rename include guard.
6103         * nat/linux-nat.h: Rename include guard.
6104         * nat/linux-namespaces.h: Rename include guard.
6105         * nat/linux-btrace.h: Rename include guard.
6106         * nat/glibc_thread_db.h: Rename include guard.
6107         * nat/gdb_thread_db.h: Rename include guard.
6108         * nat/gdb_ptrace.h: Rename include guard.
6109         * nat/fork-inferior.h: Rename include guard.
6110         * nat/amd64-linux-siginfo.h: Rename include guard.
6111         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6112         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6113         * nat/aarch64-linux.h: Rename include guard.
6114         * nat/aarch64-linux-hw-point.h: Rename include guard.
6115         * mn10300-tdep.h: Add include guard.
6116         * mips-linux-tdep.h: Add include guard.
6117         * mi/mi-parse.h: Rename include guard.
6118         * mi/mi-out.h: Rename include guard.
6119         * mi/mi-main.h: Rename include guard.
6120         * mi/mi-interp.h: Rename include guard.
6121         * mi/mi-getopt.h: Rename include guard.
6122         * mi/mi-console.h: Rename include guard.
6123         * mi/mi-common.h: Rename include guard.
6124         * mi/mi-cmds.h: Rename include guard.
6125         * mi/mi-cmd-break.h: Rename include guard.
6126         * m2-lang.h: Add include guard.
6127         * location.h: Rename include guard.
6128         * linux-record.h: Rename include guard.
6129         * linux-nat.h: Add include guard.
6130         * linux-fork.h: Add include guard.
6131         * i386-darwin-tdep.h: Rename include guard.
6132         * hppa-linux-offsets.h: Add include guard.
6133         * guile/guile.h: Rename include guard.
6134         * guile/guile-internal.h: Rename include guard.
6135         * gnu-nat.h: Rename include guard.
6136         * gdb-stabs.h: Rename include guard.
6137         * frv-tdep.h: Add include guard.
6138         * f-lang.h: Add include guard.
6139         * event-loop.h: Add include guard.
6140         * darwin-nat.h: Rename include guard.
6141         * cp-abi.h: Rename include guard.
6142         * config/sparc/nm-sol2.h: Rename include guard.
6143         * config/nm-nto.h: Rename include guard.
6144         * config/nm-linux.h: Add include guard.
6145         * config/i386/nm-i386gnu.h: Rename include guard.
6146         * config/djgpp/nl_types.h: Rename include guard.
6147         * config/djgpp/langinfo.h: Rename include guard.
6148         * compile/gcc-cp-plugin.h: Add include guard.
6149         * compile/gcc-c-plugin.h: Add include guard.
6150         * compile/compile.h: Rename include guard.
6151         * compile/compile-object-run.h: Rename include guard.
6152         * compile/compile-object-load.h: Rename include guard.
6153         * compile/compile-internal.h: Rename include guard.
6154         * compile/compile-cplus.h: Rename include guard.
6155         * compile/compile-c.h: Rename include guard.
6156         * common/xml-utils.h: Rename include guard.
6157         * common/x86-xstate.h: Rename include guard.
6158         * common/version.h: Rename include guard.
6159         * common/vec.h: Rename include guard.
6160         * common/tdesc.h: Rename include guard.
6161         * common/selftest.h: Rename include guard.
6162         * common/scoped_restore.h: Rename include guard.
6163         * common/scoped_mmap.h: Rename include guard.
6164         * common/scoped_fd.h: Rename include guard.
6165         * common/safe-iterator.h: Rename include guard.
6166         * common/run-time-clock.h: Rename include guard.
6167         * common/refcounted-object.h: Rename include guard.
6168         * common/queue.h: Rename include guard.
6169         * common/ptid.h: Rename include guard.
6170         * common/print-utils.h: Rename include guard.
6171         * common/preprocessor.h: Rename include guard.
6172         * common/pathstuff.h: Rename include guard.
6173         * common/observable.h: Rename include guard.
6174         * common/netstuff.h: Rename include guard.
6175         * common/job-control.h: Rename include guard.
6176         * common/host-defs.h: Rename include guard.
6177         * common/gdb_wait.h: Rename include guard.
6178         * common/gdb_vecs.h: Rename include guard.
6179         * common/gdb_unlinker.h: Rename include guard.
6180         * common/gdb_unique_ptr.h: Rename include guard.
6181         * common/gdb_tilde_expand.h: Rename include guard.
6182         * common/gdb_sys_time.h: Rename include guard.
6183         * common/gdb_string_view.h: Rename include guard.
6184         * common/gdb_splay_tree.h: Rename include guard.
6185         * common/gdb_setjmp.h: Rename include guard.
6186         * common/gdb_ref_ptr.h: Rename include guard.
6187         * common/gdb_optional.h: Rename include guard.
6188         * common/gdb_locale.h: Rename include guard.
6189         * common/gdb_assert.h: Rename include guard.
6190         * common/filtered-iterator.h: Rename include guard.
6191         * common/filestuff.h: Rename include guard.
6192         * common/fileio.h: Rename include guard.
6193         * common/environ.h: Rename include guard.
6194         * common/common-utils.h: Rename include guard.
6195         * common/common-types.h: Rename include guard.
6196         * common/common-regcache.h: Rename include guard.
6197         * common/common-inferior.h: Rename include guard.
6198         * common/common-gdbthread.h: Rename include guard.
6199         * common/common-exceptions.h: Rename include guard.
6200         * common/common-defs.h: Rename include guard.
6201         * common/common-debug.h: Rename include guard.
6202         * common/cleanups.h: Rename include guard.
6203         * common/buffer.h: Rename include guard.
6204         * common/btrace-common.h: Rename include guard.
6205         * common/break-common.h: Rename include guard.
6206         * cli/cli-utils.h: Rename include guard.
6207         * cli/cli-style.h: Rename include guard.
6208         * cli/cli-setshow.h: Rename include guard.
6209         * cli/cli-script.h: Rename include guard.
6210         * cli/cli-interp.h: Rename include guard.
6211         * cli/cli-decode.h: Rename include guard.
6212         * cli/cli-cmds.h: Rename include guard.
6213         * charset-list.h: Add include guard.
6214         * buildsym-legacy.h: Rename include guard.
6215         * bfin-tdep.h: Add include guard.
6216         * ax.h: Rename include guard.
6217         * arm-linux-tdep.h: Add include guard.
6218         * arm-fbsd-tdep.h: Add include guard.
6219         * arch/xtensa.h: Rename include guard.
6220         * arch/tic6x.h: Add include guard.
6221         * arch/i386.h: Add include guard.
6222         * arch/arm.h: Rename include guard.
6223         * arch/arm-linux.h: Rename include guard.
6224         * arch/arm-get-next-pcs.h: Rename include guard.
6225         * arch/amd64.h: Add include guard.
6226         * arch/aarch64-insn.h: Rename include guard.
6227         * arch-utils.h: Rename include guard.
6228         * annotate.h: Add include guard.
6229         * amd64-darwin-tdep.h: Rename include guard.
6230         * aarch64-linux-tdep.h: Add include guard.
6231         * aarch64-fbsd-tdep.h: Add include guard.
6232         * aarch32-linux-nat.h: Add include guard.
6233
6234 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6235
6236         * macrotab.c (macro_define_internal): New function that
6237         factorizes macro_define_object_internal and macro_define_function
6238         code.
6239         (macro_define_object_internal): Use macro_define_internal.
6240         (macro_define_function): Likewise.
6241
6242 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6243
6244         * macrocmd.c (extract_identifier): Return
6245         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6246         callers.
6247
6248 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6249
6250         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6251
6252 2019-02-05  Tom Tromey  <tom@tromey.com>
6253
6254         * target.c (target_stack::unpush): Move assertion earlier.
6255
6256 2019-01-30  Tom Tromey  <tom@tromey.com>
6257
6258         PR python/23615:
6259         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6260         (gdbpy_parse_and_eval): Likewise.
6261         * python/python-internal.h (gdbpy_allow_threads): New class.
6262
6263 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6264
6265         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6266         (aarch64_fbsd_fpregmap): Move earlier.
6267         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6268         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6269         instead of individual calls to trad_frame_set_reg_addr.
6270         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6271         earlier.
6272         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6273         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6274         instead of individual calls to trad_frame_set_reg_addr.
6275
6276 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6277
6278         * CONTRIBUTE: Replace contribution list with wiki link.
6279
6280 2019-01-25  Tom Tromey  <tom@tromey.com>
6281
6282         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6283
6284 2019-01-25  Tom Tromey  <tom@tromey.com>
6285
6286         * xtensa-linux-nat.c: Fix common/ includes.
6287         * xml-support.h: Fix common/ includes.
6288         * xml-support.c: Fix common/ includes.
6289         * x86-linux-nat.c: Fix common/ includes.
6290         * windows-nat.c: Fix common/ includes.
6291         * varobj.h: Fix common/ includes.
6292         * varobj.c: Fix common/ includes.
6293         * value.c: Fix common/ includes.
6294         * valops.c: Fix common/ includes.
6295         * utils.c: Fix common/ includes.
6296         * unittests/xml-utils-selftests.c: Fix common/ includes.
6297         * unittests/utils-selftests.c: Fix common/ includes.
6298         * unittests/unpack-selftests.c: Fix common/ includes.
6299         * unittests/tracepoint-selftests.c: Fix common/ includes.
6300         * unittests/style-selftests.c: Fix common/ includes.
6301         * unittests/string_view-selftests.c: Fix common/ includes.
6302         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6303         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6304         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6305         * unittests/rsp-low-selftests.c: Fix common/ includes.
6306         * unittests/parse-connection-spec-selftests.c: Fix common/
6307         includes.
6308         * unittests/optional-selftests.c: Fix common/ includes.
6309         * unittests/offset-type-selftests.c: Fix common/ includes.
6310         * unittests/observable-selftests.c: Fix common/ includes.
6311         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6312         * unittests/memrange-selftests.c: Fix common/ includes.
6313         * unittests/memory-map-selftests.c: Fix common/ includes.
6314         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6315         * unittests/function-view-selftests.c: Fix common/ includes.
6316         * unittests/environ-selftests.c: Fix common/ includes.
6317         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6318         * unittests/common-utils-selftests.c: Fix common/ includes.
6319         * unittests/cli-utils-selftests.c: Fix common/ includes.
6320         * unittests/array-view-selftests.c: Fix common/ includes.
6321         * ui-file.c: Fix common/ includes.
6322         * tui/tui-io.c: Fix common/ includes.
6323         * tracepoint.h: Fix common/ includes.
6324         * tracepoint.c: Fix common/ includes.
6325         * tracefile-tfile.c: Fix common/ includes.
6326         * top.h: Fix common/ includes.
6327         * top.c: Fix common/ includes.
6328         * thread.c: Fix common/ includes.
6329         * target/waitstatus.h: Fix common/ includes.
6330         * target/waitstatus.c: Fix common/ includes.
6331         * target.h: Fix common/ includes.
6332         * target.c: Fix common/ includes.
6333         * target-memory.c: Fix common/ includes.
6334         * target-descriptions.c: Fix common/ includes.
6335         * symtab.h: Fix common/ includes.
6336         * symfile.c: Fix common/ includes.
6337         * stap-probe.c: Fix common/ includes.
6338         * spu-linux-nat.c: Fix common/ includes.
6339         * sparc-nat.c: Fix common/ includes.
6340         * source.c: Fix common/ includes.
6341         * solib.c: Fix common/ includes.
6342         * solib-target.c: Fix common/ includes.
6343         * ser-unix.c: Fix common/ includes.
6344         * ser-tcp.c: Fix common/ includes.
6345         * ser-pipe.c: Fix common/ includes.
6346         * ser-base.c: Fix common/ includes.
6347         * selftest-arch.c: Fix common/ includes.
6348         * s12z-tdep.c: Fix common/ includes.
6349         * rust-exp.y: Fix common/ includes.
6350         * rs6000-aix-tdep.c: Fix common/ includes.
6351         * riscv-tdep.c: Fix common/ includes.
6352         * remote.c: Fix common/ includes.
6353         * remote-notif.h: Fix common/ includes.
6354         * remote-fileio.h: Fix common/ includes.
6355         * remote-fileio.c: Fix common/ includes.
6356         * regcache.h: Fix common/ includes.
6357         * regcache.c: Fix common/ includes.
6358         * record-btrace.c: Fix common/ includes.
6359         * python/python.c: Fix common/ includes.
6360         * python/py-type.c: Fix common/ includes.
6361         * python/py-inferior.c: Fix common/ includes.
6362         * progspace.h: Fix common/ includes.
6363         * producer.c: Fix common/ includes.
6364         * procfs.c: Fix common/ includes.
6365         * proc-api.c: Fix common/ includes.
6366         * printcmd.c: Fix common/ includes.
6367         * ppc-linux-nat.c: Fix common/ includes.
6368         * parser-defs.h: Fix common/ includes.
6369         * osdata.c: Fix common/ includes.
6370         * obsd-nat.c: Fix common/ includes.
6371         * nat/x86-linux.c: Fix common/ includes.
6372         * nat/x86-linux-dregs.c: Fix common/ includes.
6373         * nat/x86-dregs.h: Fix common/ includes.
6374         * nat/x86-dregs.c: Fix common/ includes.
6375         * nat/ppc-linux.c: Fix common/ includes.
6376         * nat/mips-linux-watch.h: Fix common/ includes.
6377         * nat/mips-linux-watch.c: Fix common/ includes.
6378         * nat/linux-waitpid.c: Fix common/ includes.
6379         * nat/linux-ptrace.h: Fix common/ includes.
6380         * nat/linux-ptrace.c: Fix common/ includes.
6381         * nat/linux-procfs.c: Fix common/ includes.
6382         * nat/linux-personality.c: Fix common/ includes.
6383         * nat/linux-osdata.c: Fix common/ includes.
6384         * nat/linux-namespaces.c: Fix common/ includes.
6385         * nat/linux-btrace.h: Fix common/ includes.
6386         * nat/linux-btrace.c: Fix common/ includes.
6387         * nat/fork-inferior.c: Fix common/ includes.
6388         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6389         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6390         * nat/aarch64-linux.c: Fix common/ includes.
6391         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6392         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6393         * namespace.h: Fix common/ includes.
6394         * mips-linux-tdep.c: Fix common/ includes.
6395         * minsyms.c: Fix common/ includes.
6396         * mi/mi-parse.h: Fix common/ includes.
6397         * mi/mi-main.c: Fix common/ includes.
6398         * mi/mi-cmd-env.c: Fix common/ includes.
6399         * memrange.h: Fix common/ includes.
6400         * memattr.c: Fix common/ includes.
6401         * maint.h: Fix common/ includes.
6402         * maint.c: Fix common/ includes.
6403         * main.c: Fix common/ includes.
6404         * machoread.c: Fix common/ includes.
6405         * location.c: Fix common/ includes.
6406         * linux-thread-db.c: Fix common/ includes.
6407         * linux-nat.c: Fix common/ includes.
6408         * linux-fork.c: Fix common/ includes.
6409         * inline-frame.c: Fix common/ includes.
6410         * infrun.c: Fix common/ includes.
6411         * inflow.c: Fix common/ includes.
6412         * inferior.h: Fix common/ includes.
6413         * inferior.c: Fix common/ includes.
6414         * infcmd.c: Fix common/ includes.
6415         * inf-ptrace.c: Fix common/ includes.
6416         * inf-child.c: Fix common/ includes.
6417         * ia64-linux-nat.c: Fix common/ includes.
6418         * i387-tdep.c: Fix common/ includes.
6419         * i386-tdep.c: Fix common/ includes.
6420         * i386-linux-tdep.c: Fix common/ includes.
6421         * i386-linux-nat.c: Fix common/ includes.
6422         * i386-go32-tdep.c: Fix common/ includes.
6423         * i386-fbsd-tdep.c: Fix common/ includes.
6424         * i386-fbsd-nat.c: Fix common/ includes.
6425         * guile/scm-type.c: Fix common/ includes.
6426         * guile/guile.c: Fix common/ includes.
6427         * go32-nat.c: Fix common/ includes.
6428         * gnu-nat.c: Fix common/ includes.
6429         * gdbthread.h: Fix common/ includes.
6430         * gdbarch-selftests.c: Fix common/ includes.
6431         * gdb_usleep.c: Fix common/ includes.
6432         * gdb_select.h: Fix common/ includes.
6433         * gdb_bfd.c: Fix common/ includes.
6434         * gcore.c: Fix common/ includes.
6435         * fork-child.c: Fix common/ includes.
6436         * findvar.c: Fix common/ includes.
6437         * fbsd-nat.c: Fix common/ includes.
6438         * event-top.c: Fix common/ includes.
6439         * event-loop.c: Fix common/ includes.
6440         * dwarf2read.c: Fix common/ includes.
6441         * dwarf2loc.c: Fix common/ includes.
6442         * dwarf2-frame.c: Fix common/ includes.
6443         * dwarf-index-cache.c: Fix common/ includes.
6444         * dtrace-probe.c: Fix common/ includes.
6445         * disasm-selftests.c: Fix common/ includes.
6446         * defs.h: Fix common/ includes.
6447         * csky-tdep.c: Fix common/ includes.
6448         * cp-valprint.c: Fix common/ includes.
6449         * cp-support.h: Fix common/ includes.
6450         * cp-support.c: Fix common/ includes.
6451         * corelow.c: Fix common/ includes.
6452         * completer.h: Fix common/ includes.
6453         * completer.c: Fix common/ includes.
6454         * compile/compile.c: Fix common/ includes.
6455         * compile/compile-loc2c.c: Fix common/ includes.
6456         * compile/compile-cplus-types.c: Fix common/ includes.
6457         * compile/compile-cplus-symbols.c: Fix common/ includes.
6458         * command.h: Fix common/ includes.
6459         * cli/cli-dump.c: Fix common/ includes.
6460         * cli/cli-cmds.c: Fix common/ includes.
6461         * charset.c: Fix common/ includes.
6462         * build-id.c: Fix common/ includes.
6463         * btrace.h: Fix common/ includes.
6464         * btrace.c: Fix common/ includes.
6465         * breakpoint.h: Fix common/ includes.
6466         * breakpoint.c: Fix common/ includes.
6467         * ax.h:
6468         (enum agent_op): Fix common/ includes.
6469         * ax-general.c (struct aop_map): Fix common/ includes.
6470         * ax-gdb.c: Fix common/ includes.
6471         * auxv.c: Fix common/ includes.
6472         * auto-load.c: Fix common/ includes.
6473         * arm-tdep.c: Fix common/ includes.
6474         * arch/riscv.c: Fix common/ includes.
6475         * arch/ppc-linux-common.c: Fix common/ includes.
6476         * arch/i386.c: Fix common/ includes.
6477         * arch/arm.c: Fix common/ includes.
6478         * arch/arm-linux.c: Fix common/ includes.
6479         * arch/arm-get-next-pcs.c: Fix common/ includes.
6480         * arch/amd64.c: Fix common/ includes.
6481         * arch/aarch64.c: Fix common/ includes.
6482         * arch/aarch64-insn.c: Fix common/ includes.
6483         * arch-utils.c: Fix common/ includes.
6484         * amd64-windows-tdep.c: Fix common/ includes.
6485         * amd64-tdep.c: Fix common/ includes.
6486         * amd64-sol2-tdep.c: Fix common/ includes.
6487         * amd64-obsd-tdep.c: Fix common/ includes.
6488         * amd64-nbsd-tdep.c: Fix common/ includes.
6489         * amd64-linux-tdep.c: Fix common/ includes.
6490         * amd64-linux-nat.c: Fix common/ includes.
6491         * amd64-fbsd-tdep.c: Fix common/ includes.
6492         * amd64-fbsd-nat.c: Fix common/ includes.
6493         * amd64-dicos-tdep.c: Fix common/ includes.
6494         * amd64-darwin-tdep.c: Fix common/ includes.
6495         * agent.c: Fix common/ includes.
6496         * ada-lang.h: Fix common/ includes.
6497         * ada-lang.c: Fix common/ includes.
6498         * aarch64-tdep.c: Fix common/ includes.
6499
6500 2019-01-25  Tom Tromey  <tom@tromey.com>
6501
6502         * common/create-version.sh: Use common/version.h.
6503
6504 2019-01-24  Pedro Alves  <palves@redhat.com>
6505
6506         * infrun.c (signal_stop, signal_print, signal_program)
6507         (signal_catch, signal_pass): Now arrays instead of pointers.
6508         (update_signals_program_target, do_target_resume)
6509         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6510         * linux-nat.c (linux_nat_target::pass_signals)
6511         (linux_nat_target::create_inferior, linux_nat_target::attach):
6512         Adjust.
6513         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6514         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6515         * procfs.c (procfs_target::pass_signals): Adjust.
6516         * record-full.c (record_full_target::resume): Adjust.
6517         * remote.c (remote_target::pass_signals)
6518         (remote_target::program_signals): Adjust.
6519         * target-debug.h (target_debug_print_signals): Now takes a
6520         gdb::array_view as parameter.  Adjust.
6521         * target.h (target_ops) <pass_signals, program_signals>: Replace
6522         pointer and length parameters with gdb::array_view.
6523         (target_pass_signals, target_program_signals): Likewise.
6524         * target-delegates.c: Regenerate.
6525
6526 2019-01-24  Pedro Alves  <palves@redhat.com>
6527
6528         * common/forward-scope-exit.h
6529         (forward_scope_exit::forward_scope_exit): Pass arguments to
6530         m_bind_function directly, instead of creating a std::bind and
6531         copying that.
6532
6533 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6534
6535         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6536         for static members.
6537         (pass_in_v_vfp_candidate): Likewise.
6538
6539 2019-01-23  Tom Tromey  <tom@tromey.com>
6540             Pedro Alves  <palves@redhat.com>
6541
6542         * regcache.c (class regcache_invalidator): Remove.
6543         (regcache::raw_write): Use make_scope_exit.
6544
6545 2019-01-23  Tom Tromey  <tom@tromey.com>
6546
6547         * ui-out.h (class ui_out_emit_type): Update comment.
6548
6549 2019-01-23  Tom Tromey  <tom@tromey.com>
6550
6551         * infrun.c (fetch_inferior_event): Update comment.
6552
6553 2019-01-23  Tom Tromey  <tom@tromey.com>
6554             Pedro Alves  <palves@redhat.com>
6555
6556         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6557         parameter.
6558         (fetch_inferior_event): Use SCOPE_EXIT.
6559
6560
6561 2019-01-23  Tom Tromey  <tom@tromey.com>
6562             Pedro Alves  <palves@redhat.com>
6563
6564         * infrun.c (disable_thread_events): Delete.
6565         (stop_all_threads): Use SCOPE_EXIT.
6566
6567 2019-01-23  Tom Tromey  <tom@tromey.com>
6568             Pedro Alves  <palves@redhat.com>
6569
6570         * symfile.c: Include forward-scope-exit.h.
6571         (clear_symtab_users_cleanup): Replace forward declaration with
6572         a FORWARD_SCOPE_EXIT.
6573         (syms_from_objfile_1): Use the forward_scope_exit and
6574         gdb::optional instead of cleanup_function.
6575         (reread_symbols): Use the forward_scope_exit instead of
6576         cleanup_function.
6577         (clear_symtab_users_cleanup): Remove function.
6578
6579 2019-01-23  Tom Tromey  <tom@tromey.com>
6580             Pedro Alves  <palves@redhat.com>
6581
6582         * linux-nat.c: Include scope-exit.h.
6583         (cleanup_target_stop): Remove.
6584         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6585         SCOPE_EXIT.
6586
6587 2019-01-23  Tom Tromey  <tom@tromey.com>
6588             Pedro Alves  <palves@redhat.com>
6589
6590         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6591         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6592
6593 2019-01-23  Tom Tromey  <tom@tromey.com>
6594             Andrew Burgess  <andrew.burgess@embecosm.com>
6595             Pedro Alves  <palves@redhat.com>
6596
6597         * infrun.c (fetch_inferior_event): Use scope_exit.
6598         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6599         * top.c (execute_command): Use scope_exit.
6600         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6601         * utils.c (do_bpstat_clear_actions_cleanup)
6602         (make_bpstat_clear_actions_cleanup): Remove.
6603
6604 2019-01-23  Tom Tromey  <tom@tromey.com>
6605             Pedro Alves  <palves@redhat.com>
6606
6607         * infrun.c: Include "common/scope-exit.h"
6608         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6609         (wait_for_inferior): Use SCOPE_EXIT.
6610         (fetch_inferior_event): Use scope_exit.
6611
6612 2019-01-23  Tom Tromey  <tom@tromey.com>
6613             Pedro Alves  <palves@redhat.com>
6614
6615         * breakpoint.c (create_breakpoint): Remove cleanup.
6616
6617 2019-01-23  Tom Tromey  <tom@tromey.com>
6618             Andrew Burgess  <andrew.burgess@embecosm.com>
6619             Pedro Alves  <palves@redhat.com>
6620
6621 2019-01-23  Pedro Alves  <palves@redhat.com>
6622
6623         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6624
6625 2019-01-23  Pedro Alves  <palves@redhat.com>
6626             Andrew Burgess  <andrew.burgess@embecosm.com>
6627
6628         * gdbthread.h: Include "common/forward-scope-exit.h".
6629         (scoped_finish_thread_state): Redefine custom class in terms of
6630         forward_scope_exit.
6631
6632 2019-01-23  Pedro Alves  <palves@redhat.com>
6633             Andrew Burgess  <andrew.burgess@embecosm.com>
6634
6635         * common/forward-scope-exit.h: New file.
6636
6637 2019-01-23  Pedro Alves  <palves@redhat.com>
6638             Andrew Burgess  <andrew.burgess@embecosm.com>
6639             Tom Tromey  <tom@tromey.com>
6640
6641         * common/scope-exit.h: New file.
6642
6643 2019-01-23  Pedro Alves  <palves@redhat.com>
6644
6645         * common/preprocessor.h (ESC): Rename to ...
6646         (ESC_PARENS): ... this.
6647         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6648         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6649
6650 2019-01-23  Tom Tromey  <tom@tromey.com>
6651
6652         * language.h (class scoped_switch_to_sym_language_if_auto):
6653         Initialize m_lang in both cases.
6654
6655 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6656
6657         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6658         with XCNEW.
6659
6660 2019-01-22  Tom Tromey  <tom@tromey.com>
6661
6662         * corelow.c: Do not include sys/file.h.
6663
6664 2019-01-22  Tom Tromey  <tom@tromey.com>
6665
6666         * tui/tui-wingeneral.h: Include gdb_curses.h.
6667
6668 2019-01-22  Tom Tromey  <tom@tromey.com>
6669
6670         * source-cache.h (class source_cache) <get_source_lines,
6671         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6672
6673 2019-01-22  Tom Tromey  <tom@tromey.com>
6674
6675         * remote-fileio.h (struct remote_target): Declare.
6676
6677 2019-01-22  Tom Tromey  <tom@tromey.com>
6678
6679         * python/py-arch.c: Do not include py-ref.h.
6680         * python/py-bpevent.c: Do not include py-ref.h.
6681         * python/py-cmd.c: Do not include py-ref.h.
6682         * python/py-continueevent.c: Do not include py-ref.h.
6683         * python/py-event.h: Do not include py-ref.h.
6684         * python/py-evtregistry.c: Do not include py-ref.h.
6685         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6686         * python/py-frame.c: Do not include py-ref.h.
6687         * python/py-framefilter.c: Do not include py-ref.h.
6688         * python/py-function.c: Do not include py-ref.h.
6689         * python/py-infevents.c: Do not include py-ref.h.
6690         * python/py-linetable.c: Do not include py-ref.h.
6691         * python/py-objfile.c: Do not include py-ref.h.
6692         * python/py-param.c: Do not include py-ref.h.
6693         * python/py-prettyprint.c: Do not include py-ref.h.
6694         * python/py-progspace.c: Do not include py-ref.h.
6695         * python/py-symbol.c: Do not include py-ref.h.
6696         * python/py-symtab.c: Do not include py-ref.h.
6697         * python/py-type.c: Do not include py-ref.h.
6698         * python/py-unwind.c: Do not include py-ref.h.
6699         * python/py-utils.c: Do not include py-ref.h.
6700         * python/py-value.c: Do not include py-ref.h.
6701         * python/py-varobj.c: Do not include py-ref.h.
6702         * python/py-xmethods.c: Do not include py-ref.h.
6703         * python/python.c: Do not include py-ref.h.
6704         * varobj.c: Do not include py-ref.h.
6705
6706 2019-01-22  Tom Tromey  <tom@tromey.com>
6707
6708         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6709         keyword for bcache.
6710
6711 2019-01-22  Tom Tromey  <tom@tromey.com>
6712
6713         * compile/compile-cplus-types.c: Remove a comment by #include.
6714
6715 2019-01-22  Tom Tromey  <tom@tromey.com>
6716
6717         * compile/gcc-c-plugin.h: Include compile-internal.h.
6718
6719 2019-01-22  Tom Tromey  <tom@tromey.com>
6720
6721         * stabsread.c (EXTERN): Do not define.
6722         (symnum, next_symbol_text_func, processing_gcc_compilation)
6723         (within_function, global_sym_chain, global_stabs)
6724         (previous_stab_code, this_object_header_files)
6725         (n_this_object_header_files)
6726         (n_allocated_this_object_header_files): Define.
6727         * stabsread.h (EXTERN): Never define.  Use "extern".
6728
6729 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6730
6731         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6732         history_value.
6733
6734 2019-01-21  Tom Tromey  <tom@tromey.com>
6735
6736         * ui-out.c: Fix includes.
6737         * tui/tui-source.c: Fix includes.
6738         * target.c: Fix includes.
6739         * remote.c: Fix includes.
6740         * regcache.c: Fix includes.
6741         * python/py-block.c: Fix includes.
6742         * printcmd.c: Fix includes.
6743         * or1k-tdep.c: Fix includes.
6744         * mi/mi-main.c: Fix includes.
6745         * m32r-tdep.c: Fix includes.
6746         * csky-tdep.c: Fix includes.
6747         * compile/compile-cplus-types.c: Fix includes.
6748         * cli/cli-interp.c: Fix includes.
6749
6750 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6751
6752         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6753         for padding.
6754
6755 2019-01-16  Tom Tromey  <tom@tromey.com>
6756
6757         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6758         earlier.
6759         (struct objfile) <msymbols_range>: Move from top level.
6760         <msymbols>: New method.
6761         (class objfile_msymbols): Remove.
6762         * symtab.c (default_collect_symbol_completion_matches_break_on):
6763         Update.
6764         * symmisc.c (dump_msymbols): Update.
6765         * stabsread.c (scan_file_globals): Update.
6766         * objc-lang.c (info_selectors_command, info_classes_command)
6767         (find_methods): Update.
6768         * minsyms.c (find_solib_trampoline_target): Update.
6769         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6770         * coffread.c (coff_symfile_read): Update.
6771         * ada-lang.c (ada_lookup_simple_minsym)
6772         (ada_collect_symbol_completion_matches): Update.
6773
6774 2019-01-16  Tom Tromey  <tom@tromey.com>
6775
6776         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6777         type.  Remove no-argument constructor.
6778         <iterator::operator++>: Simplify.
6779         <begin>: Update.
6780         <end>: Use minimal_symbol_count.
6781
6782 2019-01-16  Tom Tromey  <tom@tromey.com>
6783
6784         * objfiles.h (struct objfile) <psymtabs>: New method.
6785         (class objfile_psymtabs): Remove.
6786         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6787         typedef.
6788         <range>: New method.
6789         (require_partial_symbols): Change return type.
6790         * psymtab.c (require_partial_symbols)
6791         (psym_expand_symtabs_matching): Update.
6792         * mdebugread.c (parse_partial_symbols): Update.
6793         * dbxread.c (dbx_end_psymtab): Update.
6794
6795 2019-01-15  Tom Tromey  <tom@tromey.com>
6796
6797         * symtab.c (lookup_objfile_from_block)
6798         (lookup_symbol_in_objfile_symtabs)
6799         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6800         (find_line_symtab, info_sources_command)
6801         (default_collect_symbol_completion_matches_break_on)
6802         (make_source_files_completion_list): Update.
6803         * symmisc.c (print_objfile_statistics, dump_objfile)
6804         (maintenance_print_symbols, maintenance_info_symtabs)
6805         (maintenance_check_symtabs, maintenance_info_line_tables):
6806         Update.
6807         * source.c (select_source_symtab)
6808         (forget_cached_source_info_for_objfile): Update.
6809         * objfiles.h (class objfile_compunits): Remove.
6810         (struct objfile) <compunits_range>: New typedef.
6811         (compunits): New method.
6812         * objfiles.c (objfile_relocate1): Update.
6813         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6814         * maint.c (count_symtabs_and_blocks): Update.
6815         * linespec.c (iterate_over_all_matching_symtabs): Update.
6816         * cp-support.c (add_symbol_overload_list_qualified): Update.
6817         * coffread.c (coff_symtab_read): Update.
6818         * ada-lang.c (add_nonlocal_symbols)
6819         (ada_collect_symbol_completion_matches)
6820         (ada_add_global_exceptions): Update.
6821
6822 2019-01-15  Tom Tromey  <tom@tromey.com>
6823
6824         * progspace.h (program_space) <objfiles_safe_range>: New
6825         typedef.
6826         <objfiles_safe>: New method.
6827         * objfiles.h (class all_objfiles_safe): Remove.
6828         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6829         * jit.c (jit_inferior_exit_hook): Update.
6830
6831 2019-01-17  Tom Tromey  <tom@tromey.com>
6832
6833         * progspace.h (program_space) <objfiles_range>: New typedef.
6834         <objfiles>: New method.
6835         <objfiles_head>: Rename from objfiles.
6836         (object_files): Update.
6837         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6838         * guile/scm-pretty-print.c
6839         (ppscm_find_pretty_printer_from_objfiles): Update.
6840         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6841         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6842         Update.
6843         * python/py-progspace.c (pspy_get_objfiles): Update.
6844         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6845         Update.
6846         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6847         (objfpy_lookup_objfile_by_build_id): Update.
6848         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6849         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6850         Update.
6851         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6852         (expand_symtab_containing_pc, lookup_objfile_from_block)
6853         (lookup_static_symbol, basic_lookup_transparent_type)
6854         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6855         (find_line_symtab, info_sources_command)
6856         (default_collect_symbol_completion_matches_break_on)
6857         (make_source_files_completion_list, find_main_name): Update.
6858         * symmisc.c (print_symbol_bcache_statistics)
6859         (print_objfile_statistics, maintenance_print_symbols)
6860         (maintenance_print_msymbols, maintenance_print_objfiles)
6861         (maintenance_info_symtabs, maintenance_check_symtabs)
6862         (maintenance_expand_symtabs, maintenance_info_line_tables):
6863         Update.
6864         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6865         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6866         (map_overlay_command, unmap_overlay_command)
6867         (simple_overlay_update, expand_symtabs_matching)
6868         (map_symbol_filenames): Update.
6869         * symfile-debug.c (set_debug_symfile): Update.
6870         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6871         Update.
6872         * source.c (select_source_symtab, forget_cached_source_info):
6873         Update.
6874         * solib.c (solib_read_symbols): Update.
6875         * solib-spu.c (append_ocl_sos): Update.
6876         * psymtab.c (maintenance_print_psymbols)
6877         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6878         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6879         * printcmd.c (info_symbol_command): Update.
6880         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6881         Update.
6882         * objfiles.h (class all_objfiles): Remove.
6883         * objfiles.c (have_partial_symbols, have_full_symbols)
6884         (have_minimal_symbols, qsort_cmp, update_section_map)
6885         (shared_objfile_contains_address_p)
6886         (default_iterate_over_objfiles_in_search_order): Update.
6887         * objc-lang.c (info_selectors_command, info_classes_command)
6888         (find_methods): Update.
6889         * minsyms.c (find_solib_trampoline_target): Update.
6890         * maint.c (maintenance_info_sections)
6891         (maintenance_translate_address, count_symtabs_and_blocks):
6892         Update.
6893         * main.c (captured_main_1): Update.
6894         * linux-thread-db.c (try_thread_db_load_from_pdir)
6895         (has_libpthread): Update.
6896         * linespec.c (iterate_over_all_matching_symtabs)
6897         (search_minsyms_for_name): Update.
6898         * jit.c (jit_find_objf_with_entry_addr): Update.
6899         * hppa-tdep.c (find_unwind_entry)
6900         (hppa_lookup_stub_minimal_symbol): Update.
6901         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6902         Update.
6903         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6904         (elf_gnu_ifunc_resolve_by_got): Update.
6905         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6906         * dwarf-index-write.c (save_gdb_index_command): Update.
6907         * cp-support.c (add_symbol_overload_list_qualified): Update.
6908         * breakpoint.c (create_overlay_event_breakpoint)
6909         (create_longjmp_master_breakpoint)
6910         (create_std_terminate_master_breakpoint)
6911         (create_exception_master_breakpoint): Update.
6912         * blockframe.c (find_pc_partial_function): Update.
6913         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6914         (ada_collect_symbol_completion_matches)
6915         (ada_add_global_exceptions): Update.
6916
6917 2019-01-17  Tom Tromey  <tom@tromey.com>
6918
6919         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6920         declare VEC.
6921         (solib_target_parse_libraries): Change return type.
6922         (library_list_start_segment, library_list_start_section)
6923         (library_list_end_library, library_list_start_library); Update.
6924         (solib_target_free_library_list): Remove.
6925         (solib_target_parse_libraries): Remove cleanup.  Change return
6926         type.
6927         (solib_target_current_sos): Update.
6928
6929 2019-01-17  Tom Tromey  <tromey@bapiya>
6930
6931         * valprint.c: Replace "the the" with "the".
6932         * symtab.c: Replace "the the" with "the".
6933         * solib.c: Replace "the the" with "the".
6934         * solib-dsbt.c: Replace "the the" with "the".
6935         * linespec.c: Replace "the the" with "the".
6936         * dwarf2loc.h: Replace "the the" with "the".
6937         * amd64-windows-tdep.c: Replace "the the" with "the".
6938         * aarch64-tdep.c: Replace "the the" with "the".
6939
6940 2019-01-16  Keith Seitz  <keiths@redhat.com>
6941
6942         PR gdb/23773
6943         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6944         <builder>: Rename to ..
6945         <m_builder>: ... this and make private.
6946         (dwarf2_cu::get_builder): New method.  Change all users of
6947         `builder' to use this method.
6948         (dwarf2_start_symtab): Move to ...
6949         (dwarf2_cu::start_symtab): ... here.  Update all callers
6950         (setup_type_unit_groups): Move to ...
6951         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6952         callers.
6953         (dwarf2_cu::reset_builder): New method.
6954         (process_full_compunit, process_full_type_unit): Use
6955         dwarf2_cu::reset_builder.
6956         (follow_die_offset): Record the ancestor CU if it is different
6957         from the followed DIE's CU.
6958         (follow_die_sig_1): Likewise.
6959
6960 2019-01-15  Tom Tromey  <tom@tromey.com>
6961
6962         * remote.c (class remote_state) <buf>: Now a char_vector.
6963         <buf_size>: Remove.
6964         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6965         parameter.
6966         (remote_target::getpkt_or_notif_sane_1)
6967         (remote_target::getpkt_sane)
6968         (remote_target::getpkt_or_notif_sane): Likewise.
6969         (class remote_target) <putpkt>: New overload.
6970         (remote_target::read_frame): Change type of "buf_p".  Remove
6971         sizeof_p parameter.
6972         (packet_ok): New overload.
6973         (packet_check_result): New overload.
6974         Update all uses.
6975
6976 2019-01-14  Tom Tromey  <tom@tromey.com>
6977
6978         * remote-notif.c (handle_notification, remote_notif_ack)
6979         (remote_notif_parse): Make "buf" const.
6980         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6981         const.
6982         (remote_notif_parse, remote_notif_ack, handle_notification):
6983         Likewise.
6984         * remote.c (remote_notif_stop_parse): Make "buf" const.
6985         (remote_target::remote_parse_stop_reply): Make "buf" const.
6986         (remote_notif_stop_ack): Make "buf" const.
6987
6988 2019-01-14  Tom Tromey  <tom@tromey.com>
6989
6990         * remote.c (remote_console_output): Make parameter const.
6991
6992 2019-01-14  Tom Tromey  <tom@tromey.com>
6993
6994         * target-debug.h (target_debug_print_signals): Constify.
6995         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6996         * procfs.c (procfs_target::pass_signals): Update.
6997         * linux-nat.c (linux_nat_target::pass_signals): Update.
6998         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6999         * target-delegates.c: Rebuild.
7000         * remote.c (remote_target::program_signals): Update.
7001         (remote_target::pass_signals): Update.
7002         * target.c (target_pass_signals): Constify argument.
7003         (target_program_signals): Likewise.
7004         * target.h (struct target_ops) <pass_signals, program_signals>:
7005         Constify argument.
7006         (target_pass_signals, target_program_signals): Constify argument.
7007
7008 2019-01-14  Tom Tromey  <tom@tromey.com>
7009
7010         PR tui/28819:
7011         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7012
7013 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7014
7015         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7016         field.
7017         * rs6000-tdep.c: Include reggroups.h.
7018         (IS_V_ALIAS_PSEUDOREG): Define.
7019         (rs6000_register_name): Return names for the "vX" aliases.
7020         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7021         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7022         aliases.  Call default_register_reggroup_p for all other
7023         pseudo-registers.
7024         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7025         New functions.
7026         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7027         Handle "vX" aliases.
7028         (v_alias_pseudo_register_collect): New function.
7029         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7030         (rs6000_gdbarch_init): Initialize "vX" aliases as
7031         pseudo-registers.  Restore registration of
7032         rs6000_pseudo_register_reggroup_p with
7033         set_tdesc_pseudo_register_reggroup_p.
7034
7035 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7036
7037         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7038         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7039         set_gdbarch_num_pseudo_regs.
7040
7041 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7042
7043         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7044         Remove arg prefixname, add do_set and do_show.
7045         Add member functions set_list and show_list.
7046         * cli/cli-style.c (class cli_style_option): Update accordingly.
7047         (style_set_list): Move to file scope.
7048         (style_show_list): Likewise.
7049         (set_style): Call help_list.
7050         (show_style): Call cmd_show_list.
7051         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7052         Update to use the new macro.
7053
7054 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7055
7056         * ada-lang.c (_initialize_ada_language): Expand the help text
7057         for the "catch exception" command.
7058
7059 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7060
7061         * symtab.c (matching_obj_sections): Initialize obj,
7062         declare it closer to its usage.
7063
7064 2019-01-10  Tom Tromey  <tom@tromey.com>
7065
7066         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7067         (basic_inf_threads_range): Remove.
7068         (inf_threads_range, inf_non_exited_threads_range)
7069         (safe_inf_threads_range): Use next_adapter.
7070
7071 2019-01-10  Keith Seitz  <keiths@redhat.com>
7072
7073         PR gdb/23712
7074         PR symtab/23010
7075         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7076         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7077
7078 2019-01-10  Keith Seitz  <keiths@redhat.com>
7079
7080         PR gdb/23712
7081         PR symtab/23010
7082         * dictionary.c (pending_to_vector): Remove.
7083         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7084         Remove _1 suffix, replacing functions of the same name.  Update
7085         all callers.
7086         (dict_create_hashed, dict_create_hashed_expandable)
7087         (dict_create_linear, dict_create_linear_expandable, dict_free)
7088         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7089         Make functions static.
7090
7091 2019-01-10  Keith Seitz  <keiths@redhat.com>
7092
7093         PR gdb/23712
7094         PR symtab/23010
7095         * dictionary.h (struct dictionary): Replace declaration with
7096         multidictionary.
7097         (dict_create_hashed, dict_create_hashed_expandable)
7098         (dict_create_linear, dict_create_linear_expandable)
7099         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7100         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7101         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7102         taking multidictionary argument.
7103         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7104         * block.h (struct block) <dict>: Change to multidictionary
7105         and rename `multidict'.
7106         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7107         symmisc.c: Update all dictionary references to multidictionary.
7108
7109 2019-01-10  Keith Seitz  <keiths@redhat.com>
7110
7111         PR gdb/23712
7112         PR symtab/23010
7113         * dictionary.c: Include unordered_map.
7114         (pending_to_vector): New function.
7115         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7116         Rewrite the non-"_1" functions to take vector instead
7117         of linked list.
7118         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7119         "new" _1 versions of the same name.
7120         (multidictionary): Define.
7121         (std::hash<enum language): New definition.
7122         (collate_pending_symbols_by_language, mdict_create_hashed)
7123         (mdict_create_hashed_expandable, mdict_create_linear)
7124         (mdict_create_linear_expandable, mdict_free)
7125         (find_language_dictionary, create_new_language_dictionary)
7126         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7127         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7128         (mdict_size, mdict_empty): New functions.
7129         * dictionary.h (mdict_iterator): Define.
7130
7131 2019-01-10  Pedro Alves  <palves@redhat.com>
7132
7133         * breakpoint.c (read_uploaded_action)
7134         (create_tracepoint_from_upload): Adjust to use
7135         gdb::unique_xmalloc_ptr.
7136         * ctf.c (ctf_write_uploaded_tp):
7137         (SET_ARRAY_FIELD): Use emplace_back.
7138         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7139         * tracefile-tfile.c (tfile_write_uploaded_tp):
7140         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7141         gdb::unique_xmalloc_ptr.
7142         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7143         at_string, cond_string, cmd_strings>: Replace char pointers
7144         with gdb::unique_xmalloc_ptr.
7145
7146 2019-01-10  Pedro Alves  <palves@redhat.com>
7147
7148         * solib-target.c (library_list_start_library): Don't xstrdup name.
7149
7150 2019-01-10  Pedro Alves  <palves@redhat.com>
7151
7152         * mdebugread.c (parse_partial_symbols): Use
7153         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7154
7155 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7156
7157         * linux-fork.c (scoped_switch_fork_info)
7158         <~scoped_switch_fork_info>: Fix incorrect variable name.
7159
7160 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7161
7162         * linux-fork.c (scoped_switch_fork_info)
7163         <scoped_switch_fork_info>: Make explicit.
7164         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7165
7166 2019-01-10  Tom Tromey  <tom@tromey.com>
7167
7168         * objfiles.h (objfile::reset_psymtabs): Update.
7169         * objfiles.c (objfile::objfile): Update.
7170         * psymtab.h (psymtab_storage::obstack): Update.
7171         (psymtab_storage::m_obstack): Use gdb::optional.
7172         (class psymtab_storage): Update comment.  Remove objfile
7173         parameter.
7174         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7175
7176 2019-01-10  Tom Tromey  <tom@tromey.com>
7177
7178         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7179         <free_psymtabs>: Now private.
7180         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7181         (allocate_psymtab): Use new method.
7182
7183 2019-01-10  Tom Tromey  <tom@tromey.com>
7184
7185         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7186         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7187         * mdebugread.c (parse_partial_symbols): Use
7188         allocate_dependencies.
7189         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7190         allocate_dependencies.
7191         (process_psymtab_comp_unit_reader)
7192         (build_type_psymtab_dependencies): Likewise.
7193         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7194
7195 2019-01-10  Tom Tromey  <tom@tromey.com>
7196
7197         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7198         PSYMBOL_SET_LANGUAGE.
7199         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7200
7201 2019-01-10  Tom Tromey  <tom@tromey.com>
7202
7203         * psymtab.h (psymtab_storage::obstack): New method.
7204         <m_obstack>: Rename from obstack; now private.
7205         * psymtab.c (psymtab_storage): Update.
7206         * dwarf2read.c (create_addrmap_from_index)
7207         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7208         Update.
7209
7210 2019-01-10  Tom Tromey  <tom@tromey.com>
7211
7212         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7213         * objfiles.h (objfile::reset_psymtabs): New method.
7214
7215 2019-01-10  Tom Tromey  <tom@tromey.com>
7216
7217         * symmisc.c (print_symbol_bcache_statistics): Update.
7218         (print_objfile_statistics): Update.
7219         * symfile.c (reread_symbols): Update.
7220         * psymtab.h (class psymtab_storage): New.
7221         * psymtab.c (psymtab_storage): New constructor.
7222         (~psymtab_storage): New destructor.
7223         (require_partial_symbols): Update.
7224         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7225         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7226         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7227         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7228         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7229         (start_psymtab_common, end_psymtab_common)
7230         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7231         (allocate_psymtab): Update.
7232         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7233         Update.
7234         (dump_psymtab_addrmap, maintenance_print_psymbols)
7235         (maintenance_check_psymtabs): Update.
7236         (class objfile_psymtabs): Move to objfiles.h.
7237         * psympriv.h (discard_psymtab): Now inline.
7238         (psymtab_discarder::psymtab_discarder): Update.
7239         (psymtab_discarder::~psymtab_discarder): Update.
7240         (ALL_OBJFILE_PSYMTABS): Rewrite.
7241         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7242         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7243         Remove fields.
7244         <partial_symtabs>: New field.
7245         (class objfile_psymtabs): Move from psymtab.h.  Update.
7246         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7247         psymbol_cache.
7248         (objfile::~objfile): Don't destroy psymbol_cache.
7249         * mdebugread.c (parse_partial_symbols): Update.
7250         * dwarf2read.c (create_addrmap_from_index)
7251         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7252         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7253         (add_partial_subprogram, dwarf2_ranges_read): Update.
7254         * dwarf-index-write.c (write_address_map)
7255         (write_one_signatured_type, recursively_write_psymbols)
7256         (class debug_names, class debug_names, write_psymtabs_to_index):
7257         Update.
7258
7259 2019-01-10  Tom Tromey  <tom@tromey.com>
7260
7261         * symtab.h (SYMBOL_SET_NAMES): Update.
7262         (symbol_set_names): Update.
7263         (MSYMBOL_SET_NAMES): Update.
7264         * symtab.c (symbol_set_names): Change argument to be an
7265         objfile_per_bfd_storage.
7266         * psymtab.c (add_psymbol_to_bcache): Update.
7267         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7268
7269 2019-01-10  Tom Tromey  <tom@tromey.com>
7270
7271         * symtab.c (create_demangled_names_hash): Change argument to be an
7272         objfile_per_bfd_storage.
7273         (symbol_set_names): Update.
7274
7275 2019-01-10  Tom Tromey  <tom@tromey.com>
7276
7277         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7278         init_psymbol_list.
7279         * psymtab.c (init_psymbol_list): Do nothing if already called.
7280         * psympriv.h (init_psymbol_list): Add comment.
7281         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7282         init_psymbol_list.
7283         * dbxread.c (dbx_symfile_read): Unconditionally call
7284         init_psymbol_list.
7285
7286 2019-01-10  Tom Tromey  <tom@tromey.com>
7287
7288         * xcoffread.c (scan_xcoff_symtab): Update.
7289         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7290         "where".
7291         * mdebugread.c (parse_partial_symbols)
7292         (handle_psymbol_enumerators): Update.
7293         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7294         * dbxread.c (read_dbx_symtab): Update.
7295         * psympriv.h (psymbol_placement): New enum.
7296         (add_psymbol_to_list): Update.
7297
7298 2019-01-10  Tom Tromey  <tom@tromey.com>
7299
7300         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7301         static_psymbols parameters.
7302         (scan_xcoff_symtab): Update.
7303         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7304         static_psymbols parameters.
7305         * psympriv.h (start_psymtab_common): Update.
7306         * mdebugread.c (parse_partial_symbols): Update.
7307         * dwarf2read.c (create_partial_symtab): Update.
7308         * dbxread.c (read_dbx_symtab): Update.
7309         (start_psymtab): Remove global_psymbols and static_psymbols
7310         parameters.
7311
7312 2019-01-10  Tom Tromey  <tom@tromey.com>
7313
7314         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7315         * psymtab.c (allocate_psymtab): Add comment.
7316         * psympriv.h (allocate_psymtab): Add comment.
7317         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7318         initializations.
7319         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7320
7321 2019-01-10  Tom Tromey  <tom@tromey.com>
7322
7323         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7324         Don't declare.
7325         * mipsread.c: Include mdebugread.h.
7326         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7327         Declare.
7328         * elfread.c: Include mdebugread.h.
7329
7330 2019-01-09  Tom Tromey  <tom@tromey.com>
7331
7332         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7333         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7334         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7335         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7336         (psym_lookup_symbol, psym_find_last_source_symtab)
7337         (psym_forget_cached_source_info, psym_print_stats)
7338         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7339         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7340         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7341         (psym_find_compunit_symtab_by_address)
7342         (maintenance_print_psymbols, maintenance_info_psymtabs)
7343         (maintenance_check_psymtabs): Use ranged for.
7344         * psymtab.h (class objfile_psymtabs): New.
7345         (require_partial_symbols): Return objfile_psymtabs.
7346         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7347
7348 2019-01-09  Tom Tromey  <tom@tromey.com>
7349
7350         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7351         (find_pc_mapped_section, list_overlays_command)
7352         (map_overlay_command, unmap_overlay_command)
7353         (simple_overlay_update): Use all_objfiles.
7354         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7355         * printcmd.c (info_symbol_command): Use all_objfiles.
7356         * objfiles.h (ALL_OBJSECTIONS): Remove.
7357         * maint.c (maintenance_translate_address): Use all_objfiles.
7358         * gcore.c (gcore_create_callback): Use all_objfiles.
7359         (objfile_find_memory_regions): Likewise.
7360
7361 2019-01-09  Tom Tromey  <tom@tromey.com>
7362
7363         * symtab.c (find_line_symtab, info_sources_command)
7364         (make_source_files_completion_list): Use objfile_compunits.
7365         * source.c (select_source_symtab): Use objfile_compunits.
7366         * objfiles.h (struct objfile): Update comment.
7367         (ALL_OBJFILES): Remove.
7368         (ALL_FILETABS): Remove.
7369         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7370         objfile_compunits.
7371
7372 2019-01-09  Tom Tromey  <tom@tromey.com>
7373
7374         * symmisc.c (print_objfile_statistics, dump_objfile)
7375         (maintenance_print_symbols): Use compunit_filetabs.
7376         * source.c (forget_cached_source_info_for_objfile): Use
7377         compunit_filetabs.
7378         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7379         (ALL_FILETABS): Use compunit_filetabs.
7380         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7381         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7382
7383 2019-01-09  Tom Tromey  <tom@tromey.com>
7384
7385         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7386         (compunit_filetabs): New.
7387         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7388         compunit_filetabs.
7389         (info_sources_command, make_source_files_completion_list): Remove
7390         declaration.
7391         * symmisc.c (print_objfile_statistics, dump_objfile)
7392         (maintenance_print_symbols): Remove declaration.
7393         (maintenance_info_symtabs): Use compunit_filetabs.
7394         (maintenance_info_line_tables): Likewise.
7395         * source.c (select_source_symtab): Change local variable name.
7396         (forget_cached_source_info_for_objfile): Remove declaration.
7397         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7398         * objfiles.c (objfile_relocate1): Remove declaration.
7399         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7400         declaration.
7401         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7402         * coffread.c (coff_symtab_read): Remove declaration.
7403         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7404         compunit_filetabs.
7405
7406 2019-01-09  Tom Tromey  <tom@tromey.com>
7407
7408         * symtab.c (lookup_objfile_from_block)
7409         (find_pc_sect_compunit_symtab, search_symbols)
7410         (default_collect_symbol_completion_matches_break_on): Use
7411         objfile_compunits.
7412         * objfiles.h (ALL_COMPUNITS): Remove.
7413         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7414         * cp-support.c (add_symbol_overload_list_qualified): Use
7415         objfile_compunits.
7416         * ada-lang.c (ada_collect_symbol_completion_matches)
7417         (ada_add_global_exceptions): Use objfile_compunits.
7418
7419 2019-01-09  Tom Tromey  <tom@tromey.com>
7420
7421         * source.c (select_source_symtab)
7422         (forget_cached_source_info_for_objfile): Remove declaration.
7423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7424         declaration.
7425         * maint.c (count_symtabs_and_blocks): Remove declaration.
7426         * cp-support.c (add_symbol_overload_list_qualified): Remove
7427         declaration.
7428         * coffread.c (coff_symtab_read): Remove declaration.
7429         * symtab.c (lookup_symbol_in_objfile_symtabs)
7430         (basic_lookup_transparent_type_1): Use objfile_compunits.
7431         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7432         (info_sources_command, search_symbols)
7433         (default_collect_symbol_completion_matches_break_on)
7434         (make_source_files_completion_list): Remove declaration.
7435         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7436         (ada_collect_symbol_completion_matches)
7437         (ada_add_global_exceptions): Remove declaration.
7438         * linespec.c (iterate_over_all_matching_symtabs): Use
7439         objfile_compunits.
7440         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7441         (class objfile_compunits): New.
7442         (ALL_COMPUNITS): Use objfile_compunits.
7443         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7444         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7445         objfile_compunits.
7446         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7447
7448 2019-01-09  Tom Tromey  <tom@tromey.com>
7449
7450         * symtab.c (search_symbols)
7451         (default_collect_symbol_completion_matches_break_on): Use
7452         objfile_msymbols.
7453         * ada-lang.c (ada_lookup_simple_minsym)
7454         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7455         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7456         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7457         objfile_msymbols.
7458         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7459         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7460         * objc-lang.c (find_methods): Use objfile_msymbols.
7461         (info_selectors_command, info_classes_command): Likewise.
7462         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7463         * objfiles.h (class objfile_msymbols): New.
7464         (ALL_OBJFILE_MSYMBOLS): Remove.
7465         (ALL_MSYMBOLS): Remove.
7466
7467 2019-01-09  Tom Tromey  <tom@tromey.com>
7468
7469         * common/next-iterator.h (next_adapter): Add Iterator template
7470         parameter.
7471         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7472         (class all_objfiles_safe): New.
7473         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7474         * objfiles.c (put_objfile_before): Update comment.
7475         (add_separate_debug_objfile): Likewise.
7476         (free_all_objfiles): Use all_objfiles_safe.
7477         (objfile_purge_solibs): Likewise.
7478
7479 2019-01-09  Tom Tromey  <tom@tromey.com>
7480
7481         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7482         (expand_symtab_containing_pc, lookup_static_symbol)
7483         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7484         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7485         all_objfiles.
7486         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7487         * breakpoint.c (create_overlay_event_breakpoint)
7488         (create_longjmp_master_breakpoint)
7489         (create_std_terminate_master_breakpoint)
7490         (create_exception_master_breakpoint): Use all_objfiles.
7491         * linux-thread-db.c (try_thread_db_load_from_pdir)
7492         (has_libpthread): Use all_objfiles.
7493         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7494         * linespec.c (iterate_over_all_matching_symtabs)
7495         (search_minsyms_for_name): Use all_objfiles.
7496         * maint.c (maintenance_info_sections): Use all_objfiles.
7497         * main.c (captured_main_1): Use all_objfiles.
7498         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7499         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7500         * guile/scm-pretty-print.c
7501         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7502         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7503         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7504         (maintenance_print_msymbols): Use all_objfiles.
7505         * source.c (select_source_symtab): Use all_objfiles.
7506         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7507         * symfile.c (remove_symbol_file_command)
7508         (expand_symtabs_matching, map_symbol_filenames): Use
7509         all_objfiles.
7510         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7511         all_objfiles.
7512         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7513         * objc-lang.c (find_methods): Use all_objfiles.
7514         * objfiles.c (have_partial_symbols, have_full_symbols)
7515         (have_minimal_symbols, qsort_cmp)
7516         (default_iterate_over_objfiles_in_search_order): Use
7517         all_objfiles.
7518         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7519         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7520         (maintenance_check_psymtabs): Use all_objfiles.
7521         (ALL_PSYMTABS): Remove.
7522         * compile/compile-object-run.c (do_module_cleanup): Use
7523         all_objfiles.
7524         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7525         * cp-support.c (add_symbol_overload_list_qualified): Use
7526         all_objfiles.
7527         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7528         Use all_objfiles.
7529         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7530         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7531         all_objfiles.
7532         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7533         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7534         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7535         Uses all_objfiles.
7536         * solib.c (solib_read_symbols): Use all_objfiles
7537
7538 2019-01-09  Tom Tromey  <tom@tromey.com>
7539
7540         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7541         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7542         all_objfiles.
7543         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7544         * symmisc.c (print_symbol_bcache_statistics)
7545         (print_objfile_statistics, maintenance_print_objfiles)
7546         (maintenance_info_symtabs, maintenance_check_symtabs)
7547         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7548         all_objfiles.
7549         * source.c (forget_cached_source_info): Use all_objfiles.
7550         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7551         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7552         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7553         * objfiles.c (update_section_map): Use all_objfiles.
7554         (shared_objfile_contains_address_p): Likewise.
7555         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7556         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7557
7558 2019-01-09  Tom Tromey  <tom@tromey.com>
7559
7560         * common/next-iterator.h: New file.
7561         * objfiles.h (class all_objfiles): New.
7562         (struct objfile_iterator): New.
7563
7564 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7565
7566         * NEWS: Move the description of the changed "frame", "select-frame",
7567          and "info frame" commands to the Changed commands section.
7568
7569 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7570
7571         * gdbtypes.c (check_stub_method_group): Remove handling of old
7572         mangling schemes.
7573         * linespec.c (find_methods): Likewise.
7574         * stabsread.c (read_member_functions): Likewise.
7575         * valops.c (search_struct_method): Likewise.
7576         (value_struct_elt_for_reference): Likewise.
7577         * NEWS: Mention this change.
7578
7579 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7580
7581         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7582         print_source_lines.
7583         * source.c (print_source_lines_base): Update line number check.
7584         (print_source_lines): New function.
7585         (source_lines_range::source_lines_range): New function.
7586         * source.h (class source_lines_range): New class.
7587         (print_source_lines): New declaration.
7588
7589 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7590
7591         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7592
7593 2019-01-08  Tom Tromey  <tom@tromey.com>
7594             Simon Marchi  <simon.marchi@ericsson.com>
7595
7596         PR gdb/24060
7597         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7598         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7599         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7600         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7601         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7602         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7603
7604 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * source.c (select_source_symtab): Move header comment to
7607         declaration in source.h.
7608         (forget_cached_source_info_for_objfile): Likewise.
7609         (forget_cached_source_info): Likewise.
7610         (identify_source_line): Likewise.
7611         * source.h (identify_source_line): Move declaration from symtab.h
7612         and add comment from source.c
7613         (print_source_lines): Likewise.
7614         (forget_cached_source_info_for_objfile): Likewise.
7615         (forget_cached_source_info): Likewise.
7616         (select_source_symtab): Likewise.
7617         (enum print_source_lines_flag): Move definition from symtab.h.
7618         * symtab.h (identify_source_line): Move declaration to source.h.
7619         (print_source_lines): Likewise.
7620         (forget_cached_source_info_for_objfile): Likewise.
7621         (forget_cached_source_info): Likewise.
7622         (select_source_symtab): Likewise.
7623         (enum print_source_lines_flag): Move definition to source.h.
7624         * tui/tui-hooks.c: Add 'source.h' include.
7625
7626 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7627
7628         * source.c (print_source_lines_base): Handle requests to print
7629         reverse line number sequences, and guard against empty lines
7630         string.
7631
7632 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * source.c (print_source_lines_base): Fix skip of '\r' if next
7635         character is '\n'.
7636
7637 2019-01-06  Tom Tromey  <tom@tromey.com>
7638
7639         * c-exp.y (struct c_parse_state) <macro_original_text,
7640         expansion_obstack>: New member.
7641         (macro_original_text, expansion_obstack): Remove globals.
7642         (scan_macro_expansion, scanning_macro_expansion)
7643         (finished_macro_expansion): Update.
7644         (scan_macro_cleanup): Remove.
7645         (yylex, c_parse): Update.
7646
7647 2019-01-06  Tom Tromey  <tom@tromey.com>
7648
7649         * c-exp.y (struct c_parse_state) <strings>: New member.
7650         (operator_stoken): Update.
7651
7652 2019-01-06  Tom Tromey  <tom@tromey.com>
7653
7654         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7655         (union type_stack_elt) <typelist_val>: Now a pointer to
7656         std::vector.
7657         (type_stack_cleanup): Don't declare.
7658         (push_typelist): Update.
7659         * parse.c (pop_typelist): Return a std::vector.
7660         (push_typelist): Take a std::vector.
7661         (follow_types): Update.  Do not free args.
7662         (type_stack_cleanup): Remove.
7663         * c-exp.y (struct c_parse_state): New.
7664         (cpstate): New global.
7665         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7666         (nonempty_typelist): Update.
7667         (func_mod): Create a new vector.
7668         (c_parse): Create a c_parse_state.
7669         (check_parameter_typelist): Do not delete params.
7670         (function_method): Update.  Do not delete type_list.
7671
7672 2019-01-06  Tom Tromey  <tom@tromey.com>
7673
7674         PR gdb/28155:
7675         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7676         check_typedef.
7677         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7678         (print_return_value): Likewise.
7679
7680 2019-01-05  Tom Tromey  <tom@tromey.com>
7681
7682         * contrib/cleanup_check.py: Remove.
7683         * contrib/gcc-with-excheck: Remove.
7684         * contrib/exsummary.py: Remove.
7685         * contrib/excheck.py: Remove.
7686
7687 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7688
7689         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7690         NULL. Initialize tpprev to NULL instead of assigning it
7691         to NULL on the next statement.
7692         * windows-nat.c (windows_delete_thread): Remove check for
7693         main_thread_id before printing thread exit notifications.
7694         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7695         Remove thread ID check against main_thread_id.
7696         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7697         windows_delete_thread.
7698         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7699
7700 2019-01-04  Tom Tromey  <tom@tromey.com>
7701
7702         * compile/compile.c (_initialize_compile): Use upper case for
7703         metasyntactic variables.
7704         * symmisc.c (_initialize_symmisc): Use upper case for
7705         metasyntactic variables.
7706         * psymtab.c (_initialize_psymtab): Use upper case for
7707         metasyntactic variables.
7708         * demangle.c (demangle_command): Use upper case for metasyntactic
7709         variables.
7710         (_initialize_demangler): Likewise.
7711         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7712         variables.
7713
7714 2019-01-03  Tom Tromey  <tom@tromey.com>
7715
7716         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7717
7718 2019-01-03  Tom Tromey  <tom@tromey.com>
7719
7720         * python/py-symtab.c (salpy_str): Update.
7721         (struct salpy_sal_object) <symtab>: Now a PyObject.
7722         (salpy_dealloc): Update.
7723         (del_objfile_sal): Use gdbpy_ref.
7724
7725 2019-01-03  Tom Tromey  <tom@tromey.com>
7726
7727         * python/py-type.c (convert_field): Use new_reference.  Return
7728         gdbpy_ref.
7729         (make_fielditem): Return gdbpy_ref.
7730         (typy_fields): Update.
7731         (typy_getitem): Update.
7732         (field_name): Return gdbpy_ref.  Use new_reference.
7733         (typy_iterator_iternext): Update.
7734
7735 2019-01-03  Tom Tromey  <tom@tromey.com>
7736
7737         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7738
7739 2019-01-03  Tom Tromey  <tom@tromey.com>
7740
7741         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7742         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7743         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7744         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7745         (pspy_set_type_printers): Likewise.
7746         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7747         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7748         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7749         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7750         (objfpy_set_type_printers): Likewise.
7751
7752 2019-01-03  Tom Tromey  <tom@tromey.com>
7753
7754         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7755         (gdbpy_print_stack): Use gdbpy_err_fetch.
7756         * python/python-internal.h (class gdbpy_err_fetch): New class.
7757         (class gdbpy_enter) <m_error_type, m_error_value,
7758         m_error_traceback>: Remove.
7759         <m_error>: New member.
7760         (gdbpy_exception_to_string): Don't declare.
7761         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7762         * python/py-value.c (convert_value_from_python): Use
7763         gdbpy_err_fetch.
7764         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7765         gdbpy_exception_to_string.
7766         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7767         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7768         gdbpy_err_fetch.
7769
7770 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * linux-nat.c (delete_lwp_cleanup): Delete.
7773         (struct lwp_deleter): New struct.
7774         (lwp_info_up): New typedef.
7775         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7776         lwp_info_up.
7777
7778 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7779
7780         * linux-fork.c (class scoped_switch_fork_info): New class.
7781         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7782
7783 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * valops.c (find_overload_match): Remove use of null_cleanup, and
7786         calls to do_cleanups.
7787
7788 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * compile/compile-cplus-types.c
7791         (compile_cplus_instance::decl_name): Handle changes to
7792         cp_func_name.
7793         * cp-support.c (cp_func_name): Update header comment, update
7794         return type.
7795         * cp-support.h (cp_func_name): Update return type in declaration.
7796         * valops.c (find_overload_match): Move temp_func local to top
7797         level of function and change its type.  Use temp_func to hold and
7798         delete temporary string obtained from cp_func_name.
7799
7800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7803         gdb::char_vector, remove cleanup, and update uses of `msg`.
7804
7805 2019-01-03  Jim Wilson  <jimw@sifive.com>
7806
7807         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7808
7809 2019-01-02  Tom Tromey  <tom@tromey.com>
7810
7811         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7812         (tdesc_parse_xml): Remove cleanups.
7813         * target-descriptions.h (make_cleanup_free_target_description):
7814         Don't declare.
7815         (target_desc_deleter): New struct.
7816         (target_desc_up): New typedef.
7817         * target-descriptions.c (target_desc_deleter::operator()): Rename
7818         from free_target_description.
7819         (make_cleanup_free_target_description): Remove.
7820
7821 2019-01-02  Tom Tromey  <tom@tromey.com>
7822
7823         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7824         constructor, destructor.
7825         (linespec_parser): Remove typedef.
7826         (~linespec_parser): Rename from linespec_parser_delete.
7827         (linespec_lex_to_end, linespec_complete_label)
7828         (linespec_complete): Update.
7829         (decode_line_full): Remove cleanups.
7830         (decode_line_1): Update.
7831
7832 2019-01-02  Tom Tromey  <tom@tromey.com>
7833
7834         * python/python-internal.h (inferior_to_inferior_object): Change
7835         return type.
7836         * python/py-exitedevent.c (create_exited_event_object): Update.
7837         * python/py-inferior.c (inferior_to_inferior_object): Return
7838         gdbpy_ref.
7839         (python_new_inferior, python_inferior_deleted)
7840         (thread_to_thread_object, delete_thread_object)
7841         (build_inferior_list, gdbpy_selected_inferior): Update.
7842         * python/py-infthread.c (create_thread_object): Update.  Also fail
7843         if inferior_to_inferior_object fails.
7844
7845 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7846
7847         * inferior.h (class inferior) <displaced_step_state>: New field.
7848         * infrun.h (struct displaced_step_state): Move here from
7849         infrun.c.  Initialize fields, add constructor.
7850         <inf>: Remove field.
7851         <reset>: New method.
7852         * infrun.c (struct displaced_step_inferior_state): Move to
7853         infrun.h.
7854         (displaced_step_inferior_states): Remove.
7855         (get_displaced_stepping_state): Adust.
7856         (displaced_step_in_progress_any_inferior): Adjust.
7857         (displaced_step_in_progress_thread): Adjust.
7858         (displaced_step_in_progress): Adjust.
7859         (add_displaced_stepping_state): Remove.
7860         (get_displaced_step_closure_by_addr): Adjust.
7861         (remove_displaced_stepping_state): Remove.
7862         (infrun_inferior_exit): Call displaced_step_state.reset.
7863         (use_displaced_stepping): Don't check for NULL.
7864         (displaced_step_prepare_throw): Call
7865         get_displaced_stepping_state.
7866         (displaced_step_fixup): Don't check for NULL.
7867         (prepare_for_detach): Don't check for NULL.
7868
7869 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7870
7871         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7872          in case of call that did not complete.
7873
7874 2019-01-02  Andrey Utkin  <autkin@undo.io>
7875
7876         * symfile.c (find_separate_debug_file): Fix search of debug files for
7877         remote debuggee.
7878
7879 2019-01-02  Tom Tromey  <tom@tromey.com>
7880
7881         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7882         indentation.
7883         * python/py-frame.c (frapy_older): Remove cast.
7884         (frapy_newer): Likewise.
7885         * python/py-breakpoint.c (local_setattro): Remove cast.
7886         * python/py-arch.c (archpy_name): Remove local variable.
7887         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7888
7889 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7890
7891         * unittests/basic_string_view/element_access/char/empty.cc:
7892         Fix year range in copyright header.
7893
7894 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7895
7896         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7897         Delete.
7898         <operator==>: Update with for removed field.
7899         <hash>: Likewise.
7900         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7901         <isa_features>: ...this.
7902         <abi_features>: New field.
7903         (riscv_isa_flen): Update comment.
7904         (riscv_abi_xlen): New declaration.
7905         (riscv_abi_flen): New declaration.
7906         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7907         isa_features.
7908         (riscv_abi_xlen): New function.
7909         (riscv_isa_flen): Update to get answer from isa_features.
7910         (riscv_abi_flen): New function.
7911         (riscv_has_fp_abi): Update to get answer from abi_features.
7912         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7913         xlen and flen.
7914         (riscv_call_info) <xlen, flen>: Update comment.
7915         (riscv_call_arg_struct): Remove invalid assertions
7916         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7917         is removed.
7918         (riscv_gdbarch_init): Gather isa features and abi features
7919         separately, ensure both match on the gdbarch when reusing an old
7920         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7921         a target with 64-bit float hardware.
7922
7923 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7924
7925         * source.c (search_command_helper): Stop reverse search
7926         when line 1 has been searched.
7927
7928 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7929
7930         * record-full.c (record_full_base_target::close): Rewrite
7931         record_full_core_buf_list free logic.
7932
7933 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7934
7935         * break-catch-syscall.c (print_one_catch_syscall): xfree
7936         the last text.
7937
7938 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7939
7940         * top.c (print_gdb_version): Update Copyright year in version
7941         message.
7942
7943 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7944
7945         Update copyright year range in all GDB files.
7946
7947 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7948
7949         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7950
7951 For older changes see ChangeLog-2018.
7952 \f
7953 Local Variables:
7954 mode: change-log
7955 left-margin: 8
7956 fill-column: 74
7957 version-control: never
7958 coding: utf-8
7959 End:
7960