gdb/ChangeLog

   1 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
   4         end.
   5         * c-typeprint.c (c_print_typedef): Likewise.
   6         * f-typeprint.c (f_print_typedef): Likewise.
   7         * m2-typeprint.c (m2_print_typedef): Likewise.
   8         * p-typeprint.c (pascal_print_typedef): Likewise.
   9         * rust-lang.c (rust_print_typedef): Likewise.
  10         * symtab.c (print_symbol_info): Print a newline after calling
  11         typedef_print.
  12
  13 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  14
  15         * symtab.c (info_module_cmdlist): New variable.
  16         (info_module_command): New function.
  17         (search_module_symbols): New function.
  18         (info_module_subcommand): New function.
  19         (struct info_modules_var_func_options): New struct.
  20         (info_modules_var_func_options_defs): New variable.
  21         (make_info_modules_var_func_options_def_group): New function.
  22         (info_module_functions_command): New function.
  23         (info_module_variables_command): New function.
  24         (info_module_var_func_command_completer): New function.
  25         (_initialize_symtab): Register new 'info module functions' and
  26         'info module variables' commands.
  27         * symtab.h (typedef symbol_search_in_module): New typedef.
  28         (search_module_symbols): Declare new function.
  29         * NEWS: Mention new commands.
  30
  31 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  32
  33         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
  34         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
  35         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
  36         MODULES_DOMAIN.
  37         (scan_partial_symbols): Only create partial module symbols for non
  38         declarations.
  39         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
  40         and MODULES_DOMAIN.
  41         * symtab.c (search_domain_name): Likewise.
  42         (search_symbols): Likewise.
  43         (print_symbol_info): Likewise.
  44         (symtab_symbol_info): Likewise.
  45         (info_modules_command): New function.
  46         (_initialize_symtab): Register 'info modules' command.
  47         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
  48         * NEWS: Mention new 'info modules' command.
  49
  50 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  51
  52         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
  53         and $_gdb_maint_setting_str.
  54
  55 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  56
  57         * cli/cli-cmds.c (setting_cmd, value_from_setting)
  58         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
  59         (str_value_from_setting, gdb_setting_str_internal_fn)
  60         (gdb_maint_setting_str_internal_fn): New functions.
  61         (_initialize_cli_cmds): Define the new convenience functions.
  62         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
  63         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
  64
  65 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  66
  67         * agent.c (set_can_use_agent): When the setting is turned on,
  68         look up agent symbols if we don't have them yet.
  69         (agent_new_objfile): Don't look up agent symbols when the agent
  70         setting is off.
  71
  72 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  73
  74         * config.in: Regenerate.
  75
  76 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  77
  78         * configure: Regenerate.
  79         * configure.ac: Check for strerror_r.
  80         * gdbsupport/common-utils.h (safe_strerror): Change return value
  81         to const char * and document that this function is now threadsafe.
  82         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
  83         thread_local and call strerror_r, if available.
  84         * utils.c (perror_string): Update.
  85         (print_sys_errmsg): Update.
  86
  87 2019-10-31  Luis Machado  <luis.machado@linaro.org>
  88
  89         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
  90         objfile_key.
  91         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
  92         objfile to fetch per-bfd data.
  93         (arm_find_exidx_entry): Likewise.
  94
  95 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  96
  97         * gdbsupport/agent.c (debug_agent): Change type to bool.
  98         (use_agent): Likewise.
  99         (all_agent_symbols_look_up): Likewise.
 100         (agent_loaded_p): Change return value to bool.
 101         (agent_look_up_symbols): Update.
 102         (agent_capability_check): Change return value to bool.
 103         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 104         (debug_agent): Change type to bool.
 105         (use_agent): Likewise.
 106         (agent_capability_check): Change return value to bool.
 107
 108 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 109
 110         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 111         (build_minimal_symbol_hash_tables): Code to clear the table moved
 112         to clear_minimal_symbol_hash_tables.
 113         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 114         when needed.
 115
 116 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 117
 118         * infcmd.c: Remove includes.
 119         * infrun.c: Remove includes.
 120
 121 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 122
 123         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 124         (grow_vect): Remove declaration.
 125         (ada_type_of_array): Remove declaration.
 126         (ada_update_initial_language): Remove declaration.
 127         (ada_fold_name): Remove declaration.
 128         (ada_fill_in_ada_prototype): Remove declaration.
 129         (user_select_syms): Remove declaration.
 130         (get_selections): Remove declaration.
 131         (ada_tag_type): Remove declaration.
 132         (ada_value_tag): Remove declaration.
 133         (ada_is_others_clause): Remove declaration.
 134         (ada_in_variant): Remove declaration.
 135         (ada_value_struct_elt): Remove declaration.
 136         (ada_attribute_name): Remove declaration.
 137         (ada_system_address_type): Remove declaration.
 138         * ada-lang.c (ada_watch_location_expression): Make static.
 139         (GROW_VECT): Move here from ada-lang.h.
 140         (grow_vect): Make static.
 141         (ada_update_initial_language): Make static.
 142         (ada_fold_name): Make static.
 143         (ada_type_of_array): Make static.
 144         (encoded_ordered_before): Move up.
 145         (sort_choices): Move up.
 146         (print_signatures): Move up.
 147         (ada_print_symbol_signature): Move up.
 148         (get_selections): Move up and make static.
 149         (user_select_syms): Move up and make static.
 150         (ada_value_struct_elt): Move up and make static.
 151         (ada_tag_type): Make static.
 152         (ada_value_tag): Make static.
 153         (ada_is_others_clause): Make static.
 154         (ada_in_variant): Make static.
 155         (ada_attribute_name): Make static.
 156
 157 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 158
 159         * ada-lang.c: Remove includes.
 160         * ada-typeprint.c: Remove includes.
 161         * ada-valprint.c: Remove includes.
 162
 163 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 164
 165         * addrmap.c: Add static assertions of type size, moved from
 166         _initialize_addrmap.
 167         (_initialize_addrmap): Remove.
 168
 169 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 170
 171         * coffread.c (record_minimal_symbol): Update.
 172         (process_coff_symbol): Update.
 173         * dbxread.c (read_dbx_symtab): Update.
 174         * dwarf2read.c (add_partial_symbol): Update.
 175         (fixup_go_packaging): Update.
 176         (load_partial_dies): Update.
 177         (new_symbol): Update.
 178         * elfread.c (record_minimal_symbol): Change signature to use
 179         gdb::string_view instead of name+len.
 180         (elf_symtab_read): Update.
 181         (elf_rel_plt_read): Update.
 182         * mdebugread.c (parse_partial_symbols): Update.
 183         (handle_psymbol_enumerators): Update.
 184         (new_symbol): Update.
 185         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 186         to use gdb::string_view instead of name+len.
 187         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 188         * psympriv.h (add_psymbol_to_list): Likewise.
 189         * psymtab.c (add_psymbol_to_bcache): Likewise.
 190         (add_psymbol_to_list): Likewise.
 191         * stabsread.c (define_symbol): Update.
 192         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 193         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 194         (symbol_set_names): Likewise.
 195         * xcoffread.c (scan_xcoff_symtab): Update.
 196
 197 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 198
 199         * symtab.h (symbol_set_names): Document that copy_name must be
 200         set to true for non-nullterminated strings.
 201         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 202         linkage_name if the entry was not found and we need to demangle.
 203
 204 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 205
 206         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 207         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 208         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 209         * gdbsupport/gdb_binary_search.h: New file.
 210
 211 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 212
 213         * NEWS: Mention new --with-system-gdbinit-dir option.
 214         * config.in: Regenerate.
 215         * configure: Regenerate.
 216         * configure.ac: Add new option --with-system-gdbinit-dir.
 217         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 218         for a ".gdb" suffix.
 219         * main.c (get_init_files): Change system_gdbinit argument to
 220         a vector and return the files in SYSTEM_GDBINIT_DIR in
 221         addition to SYSTEM_GDBINIT.
 222         (captured_main_1): Update.
 223         (print_gdb_help): Update.
 224         * top.c (print_gdb_configuration): Also print the value of
 225         SYSTEM_GDBINIT_DIR.
 226
 227 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 228
 229         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 230         that takes gdb::string_view arguments.
 231
 232 2019-10-26  Tom de Vries  <tdevries@suse.de>
 233
 234         * aarch64-linux-tdep.c: Fix typos in comments.
 235         * aarch64-tdep.c: Same.
 236         * ada-lang.c: Same.
 237         * amd64-nat.c: Same.
 238         * arc-tdep.c: Same.
 239         * arch/aarch64-insn.c: Same.
 240         * block.c: Same.
 241         * breakpoint.h: Same.
 242         * btrace.h: Same.
 243         * c-varobj.c: Same.
 244         * cli/cli-decode.c: Same.
 245         * cli/cli-script.c: Same.
 246         * cli/cli-utils.h: Same.
 247         * coff-pe-read.c: Same.
 248         * coffread.c: Same.
 249         * compile/compile-cplus-symbols.c: Same.
 250         * compile/compile-object-run.c: Same.
 251         * completer.c: Same.
 252         * corelow.c: Same.
 253         * cp-support.c: Same.
 254         * demangle.c: Same.
 255         * dwarf-index-write.c: Same.
 256         * dwarf2-frame.c: Same.
 257         * dwarf2-frame.h: Same.
 258         * eval.c: Same.
 259         * frame-base.h: Same.
 260         * frame.h: Same.
 261         * gdbcmd.h: Same.
 262         * gdbtypes.h: Same.
 263         * gnu-nat.c: Same.
 264         * guile/scm-objfile.c: Same.
 265         * i386-tdep.c: Same.
 266         * i386-tdep.h: Same.
 267         * infcall.c: Same.
 268         * infcall.h: Same.
 269         * linux-nat.c: Same.
 270         * m68k-tdep.c: Same.
 271         * macroexp.c: Same.
 272         * memattr.c: Same.
 273         * mi/mi-cmd-disas.c: Same.
 274         * mi/mi-getopt.h: Same.
 275         * mi/mi-main.c: Same.
 276         * minsyms.c: Same.
 277         * nat/aarch64-sve-linux-sigcontext.h: Same.
 278         * objfiles.h: Same.
 279         * ppc-linux-nat.c: Same.
 280         * ppc-linux-tdep.c: Same.
 281         * ppc-tdep.h: Same.
 282         * progspace.h: Same.
 283         * prologue-value.h: Same.
 284         * python/py-evtregistry.c: Same.
 285         * python/py-instruction.h: Same.
 286         * record-btrace.c: Same.
 287         * record-full.c: Same.
 288         * remote.c: Same.
 289         * rs6000-tdep.c: Same.
 290         * ser-tcp.c: Same.
 291         * sol-thread.c: Same.
 292         * sparc-sol2-tdep.c: Same.
 293         * sparc64-tdep.c: Same.
 294         * stabsread.c: Same.
 295         * symfile.c: Same.
 296         * symtab.h: Same.
 297         * target.c: Same.
 298         * tracepoint.c: Same.
 299         * tui/tui-data.h: Same.
 300         * tui/tui-io.c: Same.
 301         * tui/tui-win.c: Same.
 302         * tui/tui.c: Same.
 303         * unittests/rsp-low-selftests.c: Same.
 304         * user-regs.h: Same.
 305         * utils.c: Same.
 306         * utils.h: Same.
 307         * valarith.c: Same.
 308         * valops.c: Same.
 309         * valprint.c: Same.
 310         * valprint.h: Same.
 311         * value.c: Same.
 312         * value.h: Same.
 313         * varobj.c: Same.
 314         * x86-nat.h: Same.
 315         * xtensa-tdep.c: Same.
 316
 317 2019-10-25  Ali Tamur <tamur@google.com>
 318
 319         * charset.c (find_charset_names): Reflect API change.
 320
 321 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 322
 323         * symtab.c (struct demangled_name_entry): Change demangled name
 324         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 325         part of the struct anymore.
 326         (symbol_set_names): No longer obstack allocate + copy the demangled
 327         name, just store the allocated name from bfd.
 328
 329 2019-10-25  Tom Tromey  <tromey@adacore.com>
 330
 331         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 332         (bsearch_cie_cmp, add_cie): Remove.
 333         (find_cie): Reimplement.
 334         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 335         (dwarf2_build_frame_info): Update.
 336
 337 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 338
 339         PR gdb/25126
 340         * symfile.c (reread_symbols): Call forget_cached_source_info to
 341         clear the stale source cache.
 342
 343 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 344
 345         * configure: Regenerate.
 346         * configure.ac: Remove code that sets python_has_threads.
 347
 348 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 349
 350         * config.in: Regenerate.
 351         * configure: Regenerate.
 352         * configure.ac: Remove the code that uses sed to get the python
 353         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 354
 355 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 356
 357         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 358         error paths.
 359
 360 2019-10-23  Tom Tromey  <tom@tromey.com>
 361
 362         * arc-tdep.c: Remove ".." from include.
 363         * frv-tdep.c: Remove ".." from include.
 364         * lm32-tdep.c: Remove ".." from include.
 365         * microblaze-tdep.c: Remove ".." from include.
 366         * or1k-tdep.h: Remove ".." from include.
 367         * s12z-tdep.c: Remove ".." from include.
 368         * Makefile.in (OPCODES_CFLAGS): Add comment.
 369         (TOP_CFLAGS): New variable.
 370         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 371
 372 2019-10-23  Tom Tromey  <tom@tromey.com>
 373
 374         * Makefile.in (READLINE_DIR): Update.
 375
 376 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 377
 378         * infcall.c (call_function_by_hand_dummy): Fix the function
 379         comment.  And extract out a code section into...
 380         (reserve_stack_space): ...this new function.
 381
 382 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 383
 384         * infcall.c (value_arg_coerce): Remove an unused parameter.
 385         (call_function_by_hand_dummy): Update the call to
 386         'value_arg_coerce'.
 387
 388 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 389
 390         * infcall.c (call_function_by_hand_dummy): Refactor.
 391
 392 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 393
 394         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 395
 396 2019-10-23  Tom Tromey  <tom@tromey.com>
 397
 398         * configure: Rebuild.
 399         * configure.ac: Don't check for sigprocmask.
 400         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 401
 402 2019-10-23  Tom Tromey  <tom@tromey.com>
 403
 404         * configure: Rebuild.
 405         * acinclude.m4: Use m4_include, not sinclude.
 406
 407 2019-10-23  Tom de Vries  <tdevries@suse.de>
 408
 409         PR breakpoints/24687
 410         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 411
 412 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 413
 414         * symtab.c (struct demangled_name_entry) <language>: Change from
 415         bitfield to regular variable.
 416
 417 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 418
 419         * symtab.c (struct demangled_name_entry): Add a constructor.
 420         (free_demangled_name_entry): New function to call the destructor
 421         for demangled_name_entry.
 422         (create_demangled_names_hash): Pass free_demangled_name_entry to
 423         htab_create_alloc.
 424         (symbol_set_names): Call placement new for demangled_name_entry.
 425         * utils.c: No longer include xxhash.h here, now that fast_hash
 426         is inlined in the header.
 427         * utils.h: Instead, include it here.
 428
 429 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 430
 431         * Makefile.in: Link with libxxhash.
 432         * config.in: Regenerate.
 433         * configure: Regenerate.
 434         * configure.ac: Search for libxxhash.
 435         * utils.c (fast_hash): Use xxhash if present.
 436
 437 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 438
 439         * utils.h (fast_hash): New function.
 440         * symtab.c (hash_demangled_name_entry): Call new function
 441         fast_hash.
 442
 443 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 444
 445         * symtab.c (struct demangled_name_entry): Change type of mangled
 446         to gdb::string_view. Also adds a constructor that takes the
 447         mangled name.
 448         (hash_demangled_name_entry): Update.
 449         (eq_demangled_name_entry): Update.
 450         (free_demangled_name_entry): New function to call the destructor
 451         now that this is not a POD anymore.
 452         (create_demangled_names_hash): Pass free_demangled_name_entry to
 453         htab_create_alloc.
 454         (symbol_set_names): Update.
 455
 456 2019-10-21  Ali Tamur  <tamu@google.com>
 457
 458         * dwarf2read.c (dir_index): Change type.
 459         (file_name_index): Likewise.
 460         (line_header::include_dir_at): Change comment and implementation on
 461         whether it is DWARF 5.
 462         (line_header::is_valid_file_index): New function.
 463         (line_header::file_name_at): Change comment and implementation on
 464         whether it is DWARF 5.
 465         (line_header::file_names): Change to private field renamed as
 466         m_file_names and introduce a new accessor method.
 467         (line_header::file_names_size): New method.
 468         (line_header::include_dirs): Change to private field and rename as
 469         m_include_dirs.
 470         (dw2_get_file_names_reader): Define local var at a smaller scope and
 471         reflect API change.
 472         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 473         (process_structure_scope): Likewise.
 474         (line_header::add_include_dir): Change message and reflect renaming.
 475         (line_header::add_file_name): Likewise.
 476         (read_formatted_entries): Handle DW_FORM_data16.
 477         (dwarf_decode_line_header): Fix line header length calculation.
 478         (psymtab_include_file_name): Change comment and API.
 479         (lnp_state_machine::m_file): Update comment and reflect type change.
 480         (lnp_state_machine::record_line): Reflect type change.
 481         (dwarf_decode_lines): Reflect API change.
 482         (file_file_name): Likewise.
 483         (file_full_name): Likewise.
 484
 485 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 486
 487         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 488
 489 2019-10-21  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 492
 493 2019-10-21  Tom Tromey  <tom@tromey.com>
 494
 495         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 496         NM_H.   Use AC_CONFIG_LINKS.
 497         * configure: Rebuild.
 498         * Makefile.in (NM_H): New variable.
 499         (generated_files): Add NM_H.  Remove gcore.
 500         (nm.h, stamp-nmh): New targets.
 501
 502 2019-10-20  Tom Tromey  <tom@tromey.com>
 503
 504         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 505         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 506         obsolete comment.
 507         (put_objfile_before): Now static.
 508
 509 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 510
 511         * gdbsupport/common-utils.h (startswith): Change return type to
 512         bool.
 513
 514 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 515
 516         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 517         * breakpoint.c (bp_locations_compare): Rename to...
 518         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 519         (update_global_location_list): Use std::sort instead of qsort.
 520         * buildsym.c (compare_line_numbers): Rename to...
 521         (lte_is_less_than): ...this, and change to std::sort semantics.
 522         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 523         instead of qsort.
 524         * disasm.c (compare_lines): Rename to...
 525         (line_is_less_than): ...this, and change to std::sort semantics.
 526         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 527         of qsort.
 528         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 529         (fde_is_less_than): ...this, and change to std::sort semantics.
 530         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 531         * mdebugread.c (compare_blocks):
 532         (block_is_less_than): ...this, and change to std::sort semantics.
 533         (sort_blocks): Call std::sort instead of qsort.
 534         * objfiles.c (qsort_cmp): Rename to...
 535         (sort_cmp): ...this, and change to std::sort semantics.
 536         (update_section_map): Call std::sort instead of qsort.
 537         * remote.c (compare_pnums): Remove.
 538         (map_regcache_remote_table): Call std::sort instead of qsort.
 539         * utils.c (compare_positive_ints): Remove.
 540         * utils.h (compare_positive_ints): Remove.
 541         * xcoffread.c (compare_lte): Remove.
 542         (arrange_linetable): Call std::sort instead of qsort.
 543
 544 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 545
 546         * symfile.c (init_entry_point_info): Fix typo.
 547         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 548
 549 2019-10-18  Tom de Vries  <tdevries@suse.de>
 550
 551         * aarch64-tdep.c: Fix typos in comments.
 552         * ada-lang.c: Same.
 553         * ada-tasks.c: Same.
 554         * alpha-tdep.c: Same.
 555         * alpha-tdep.h: Same.
 556         * amd64-nat.c: Same.
 557         * amd64-windows-tdep.c: Same.
 558         * arc-tdep.c: Same.
 559         * arc-tdep.h: Same.
 560         * arch-utils.c: Same.
 561         * arm-nbsd-tdep.c: Same.
 562         * arm-tdep.c: Same.
 563         * ax-gdb.c: Same.
 564         * blockframe.c: Same.
 565         * btrace.c: Same.
 566         * c-varobj.c: Same.
 567         * coff-pe-read.c: Same.
 568         * coffread.c: Same.
 569         * cris-tdep.c: Same.
 570         * darwin-nat.c: Same.
 571         * dbxread.c: Same.
 572         * dcache.c: Same.
 573         * disasm.c: Same.
 574         * dtrace-probe.c: Same.
 575         * dwarf-index-write.c: Same.
 576         * dwarf2-frame-tailcall.c: Same.
 577         * dwarf2-frame.c: Same.
 578         * dwarf2read.c: Same.
 579         * eval.c: Same.
 580         * exceptions.c: Same.
 581         * fbsd-tdep.c: Same.
 582         * findvar.c: Same.
 583         * frame.c: Same.
 584         * frv-tdep.c: Same.
 585         * gnu-v3-abi.c: Same.
 586         * go32-nat.c: Same.
 587         * h8300-tdep.c: Same.
 588         * hppa-tdep.c: Same.
 589         * i386-linux-tdep.c: Same.
 590         * i386-tdep.c: Same.
 591         * ia64-libunwind-tdep.c: Same.
 592         * ia64-tdep.c: Same.
 593         * infcmd.c: Same.
 594         * infrun.c: Same.
 595         * linespec.c: Same.
 596         * linux-nat.c: Same.
 597         * linux-thread-db.c: Same.
 598         * machoread.c: Same.
 599         * mdebugread.c: Same.
 600         * mep-tdep.c: Same.
 601         * mn10300-tdep.c: Same.
 602         * namespace.c: Same.
 603         * objfiles.c: Same.
 604         * opencl-lang.c: Same.
 605         * or1k-tdep.c: Same.
 606         * osabi.c: Same.
 607         * ppc-linux-nat.c: Same.
 608         * ppc-linux-tdep.c: Same.
 609         * ppc-sysv-tdep.c: Same.
 610         * printcmd.c: Same.
 611         * procfs.c: Same.
 612         * record-btrace.c: Same.
 613         * record-full.c: Same.
 614         * remote-fileio.c: Same.
 615         * remote.c: Same.
 616         * rs6000-tdep.c: Same.
 617         * s12z-tdep.c: Same.
 618         * score-tdep.c: Same.
 619         * ser-base.c: Same.
 620         * ser-go32.c: Same.
 621         * skip.c: Same.
 622         * sol-thread.c: Same.
 623         * solib-svr4.c: Same.
 624         * solib.c: Same.
 625         * source.c: Same.
 626         * sparc-nat.c: Same.
 627         * sparc-sol2-tdep.c: Same.
 628         * sparc-tdep.c: Same.
 629         * sparc64-tdep.c: Same.
 630         * stabsread.c: Same.
 631         * stack.c: Same.
 632         * symfile.c: Same.
 633         * symtab.c: Same.
 634         * target-descriptions.c: Same.
 635         * target-float.c: Same.
 636         * thread.c: Same.
 637         * utils.c: Same.
 638         * valops.c: Same.
 639         * valprint.c: Same.
 640         * value.c: Same.
 641         * varobj.c: Same.
 642         * windows-nat.c: Same.
 643         * xcoffread.c: Same.
 644         * xstormy16-tdep.c: Same.
 645         * xtensa-tdep.c: Same.
 646
 647 2019-10-17  Tom Tromey  <tromey@adacore.com>
 648
 649         * configure: Rebuild.
 650         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 651         in AC_CONFIG_FILES invocation.
 652         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 653         new-style config.status invocation.
 654
 655 2019-10-17  Tom de Vries  <tdevries@suse.de>
 656
 657         * arm-nbsd-nat.c: Fix typos in comments.
 658         * arm-tdep.c: Same.
 659         * darwin-nat-info.c: Same.
 660         * dwarf2read.c: Same.
 661         * elfread.c: Same.
 662         * event-top.c: Same.
 663         * findvar.c: Same.
 664         * gdbtypes.c: Same.
 665         * hppa-tdep.c: Same.
 666         * i386-tdep.c: Same.
 667         * jit.c: Same.
 668         * main.c: Same.
 669         * mdebugread.c: Same.
 670         * moxie-tdep.c: Same.
 671         * nto-procfs.c: Same.
 672         * osabi.c: Same.
 673         * ppc-linux-tdep.c: Same.
 674         * remote.c: Same.
 675         * riscv-tdep.c: Same.
 676         * s390-tdep.c: Same.
 677         * sh-tdep.c: Same.
 678         * sparc-linux-tdep.c: Same.
 679         * sparc-nat.c: Same.
 680         * stack.c: Same.
 681         * target-descriptions.c: Same.
 682         * top.c: Same.
 683         * varobj.c: Same.
 684
 685 2019-10-16  Tom Tromey  <tom@tromey.com>
 686
 687         * objfiles.h (struct objfile) <original_name>: Now const.
 688
 689 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 690
 691         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 692         pass on to sigsetjmp's second argument.
 693         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 694
 695 2019-10-16  Keith Seitz  <keiths@redhat.com>
 696
 697         PR gdb/23567
 698         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 699         sections whose size is greater than the file size.
 700
 701 2019-10-16  Jim Wilson  <jimw@sifive.com>
 702
 703         * riscv-tdep.c (riscv_gcc_target_options): New.
 704         (riscv_gnu_triplet_regexp): New.
 705         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 706         set_gdbarch_gnu_triplet_regexp.
 707
 708 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 709
 710         * Makefile.in: Add xml-builtin.h.
 711         * features/feature_to_c.sh: Add an include for xml-builtin.h
 712         to ensure that the compiler checks that the types match.
 713         * xml-builtin.h: New file.
 714         * xml-support.c (fetch_xml_builtin): Add missing const.
 715         * xml-support.h: Remove declaration of xml_builtins.
 716
 717 2019-10-16  Tom de Vries  <tdevries@suse.de>
 718
 719         PR tdep/25096
 720         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 721         (amd64_classify_aggregate): ... here.
 722         (amd64_classify_aggregate_field): Handled fiels of nested structs
 723         recursively.
 724
 725 2019-10-16  Tom de Vries  <tdevries@suse.de>
 726
 727         PR tdep/24104
 728         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 729         that handles 'theclass'.
 730
 731 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 732
 733         * linespec.c (decode_digits_ordinary): Update comment.
 734         * make-target-delegates: No longer need to handle VEC case.
 735         * memrange.c (normalize_mem_ranges): Update comment.
 736         * namespace.c (add_using_directive): Update comment.
 737         * objc-lang.c (uniquify_strings): Update comment.
 738         * ppc-linux-nat.c (struct thread_points): Update comment.
 739         * probe.h (find_probes_in_objfile): Update comment.
 740         * target.h (enum flash_preserve_mode): Update comment.
 741         * varobj.c (varobj_restrict_range): Update comment.
 742         * varobj.h (varobj_list_children): Update comment.
 743
 744 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * Makefile.in: Remove references to vec.h and vec.c.
 747         * aarch64-tdep.c: No longer include vec.h.
 748         * ada-lang.c: Likewise.
 749         * ada-lang.h: Likewise.
 750         * arm-tdep.c: Likewise.
 751         * ax.h: Likewise.
 752         * breakpoint.h: Likewise.
 753         * charset.c: Likewise.
 754         * cp-support.h: Likewise.
 755         * dtrace-probe.c: Likewise.
 756         * dwarf2read.c: Likewise.
 757         * extension.h: Likewise.
 758         * gdb_bfd.c: Likewise.
 759         * gdbsupport/gdb_vecs.h: Likewise.
 760         * gdbsupport/vec.c: Remove.
 761         * gdbsupport/vec.h: Remove.
 762         * gdbthread.h: Likewise.
 763         * guile/scm-type.c: Likewise.
 764         * inline-frame.c: Likewise.
 765         * machoread.c: Likewise.
 766         * memattr.c: Likewise.
 767         * memrange.h: Likewise.
 768         * namespace.h: Likewise.
 769         * nat/linux-btrace.h: Likewise.
 770         * osdata.c: Likewise.
 771         * parser-defs.h: Likewise.
 772         * progspace.h: Likewise.
 773         * python/py-type.c: Likewise.
 774         * record-btrace.c: Likewise.
 775         * rust-exp.y: Likewise.
 776         * solib-target.c: Likewise.
 777         * stap-probe.c: Likewise.
 778         * target-descriptions.c: Likewise.
 779         * target-memory.c: Likewise.
 780         * target.h: Likewise.
 781         * varobj.c: Likewise.
 782         * varobj.h: Likewise.
 783         * xml-support.h: Likewise.
 784
 785 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 788         Update for new std::vector based implementation.
 789         (process_psymtab_comp_unit_reader): Likewise.
 790         (scan_partial_symbols): Likewise.
 791         (recursively_compute_inclusions): Likewise.
 792         (compute_compunit_symtab_includes): Likewise.
 793         (process_imported_unit_die): Likewise.
 794         (queue_and_load_dwo_tu): Likewise.
 795         (follow_die_sig_1): Likewise.
 796         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 797         (typedef dwarf2_per_cu_ptr): Remove.
 798         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 799         function.
 800         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 801         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 802         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 803         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 804         std::vector.
 805
 806 2019-10-15  Tom Tromey  <tromey@adacore.com>
 807
 808         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 809         TID.
 810
 811 2019-10-15  Tom Tromey  <tromey@adacore.com>
 812
 813         * windows-nat.c (windows_nat_target::fetch_registers)
 814         (windows_nat_target::store_registers): Rename "pid" to "tid".
 815
 816 2019-10-15  Tom Tromey  <tromey@adacore.com>
 817
 818         * gdbarch.h, gdbarch.c: Rebuild.
 819         * gdbarch.sh (gcc_target_options): Change return type to
 820         std::string.
 821         * compile/compile.c (get_args): Update.
 822         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 823         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 824         std::string.
 825         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 826         std::string.
 827         * arch-utils.c (default_gcc_target_options): Return std::string.
 828         * arch-utils.h (default_gcc_target_options): Return std::string.
 829         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 830
 831 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 832
 833         * breakpoint.c (breakpoint_chain): Make static.
 834         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 835         of accessing breakpoint_chain.
 836
 837 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 838
 839         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 840         to a gdb::function_view and return value to bool.
 841         * breakpoint.h (iterate_over_breakpoints): Likewise.
 842         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 843         (pop_dummy_frame): Update.
 844         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 845         (gdbscm_breakpoints): Update.
 846         * python/py-breakpoint.c (build_bp_list): Update.
 847         (gdbpy_breakpoints): Update.
 848         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 849         Update.
 850         (bpfinishpy_handle_stop): Update.
 851         (bpfinishpy_handle_exit): Update.
 852         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 853         (svr4_update_solib_event_breakpoints): Update.
 854
 855 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 856
 857         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 858         when unwrapping single-field structs.
 859
 860 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 861
 862         * dwarf2read.c: Remove includes.
 863
 864 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 865
 866         * ui-out.c (ui_out::call_do_message): Silence
 867         -Wformat-nonliteral warning.
 868
 869 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 870
 871         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 872         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 873         include: readline/tilde.h.
 874
 875 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 876
 877         * remote.c (remote_target::get_trace_status): Remove declaration of
 878         trace_regblock_size.
 879
 880 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 881
 882         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 883         (show_user): Remove declaration of cmdlist.
 884         * cli/cli-cmds.h (max_user_call_depth): Declare.
 885         * cli/cli-script.c (execute_user_command): Remove declaration
 886         of max_user_call_depth.
 887
 888 2019-10-11  Jim Wilson  <jimw@sifive.com>
 889
 890         * gdbsupport/print-utils.h (pulongest): Fix comment.
 891         (plongest): Likewise.
 892         (phex): Add missing comment, mention leading zeros.
 893         (phex_nz): Add mention of no leading zeros to comment.
 894
 895         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 896         plongest instead of unsigned long long cast.
 897
 898 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 899
 900         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 901         for external_editor_command and gdbtk_test.
 902
 903 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 904
 905         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 906         * varobj.c (varobjdebug): Move comment to...
 907         * varobj.h (varobjdebug): ...here, and declare.
 908
 909 2019-10-09  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 912         erase_data_content.
 913
 914 2019-10-09  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 917         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 918         * tui/tui-command.c (tui_cmd_window::resize)
 919         (tui_refresh_cmd_win): Update.
 920         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 921         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 922         * tui/tui-data.c (~tui_gen_win_info): Remove.
 923         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 924         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 925         (tui_redisplay_readline, tui_mld_flush)
 926         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 927         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 928         (tui_data_window::erase_data_content)
 929         (tui_data_item_window::rerender)
 930         (tui_data_item_window::refresh_window): Update.
 931         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 932         (box_win, tui_gen_win_info::make_window)
 933         (tui_gen_win_info::make_visible): Update.
 934         (tui_delete_win): Remove.
 935         * tui/tui-winsource.c
 936         (tui_source_window_base::do_erase_source_content): Update.
 937         (tui_show_source_line, tui_source_window_base::update_tab_width)
 938         (tui_source_window_base::update_exec_info): Update.
 939         * tui/tui-data.h (struct curses_deleter): New.
 940         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 941         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 942
 943 2019-10-09  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 946
 947 2019-10-09  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 950         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 951
 952 2019-10-09  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 955         window height directly.
 956         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 957         declare.
 958         * tui/tui-layout.c (tui_default_win_height): Remove.
 959         (tui_default_win_viewport_height): Remove.
 960
 961 2019-10-09  Tom Tromey  <tom@tromey.com>
 962
 963         * tui/tui.h: Remove comments.
 964
 965 2019-10-09  Tom de Vries  <tdevries@suse.de>
 966
 967         * python/lib/gdb/printer/bound_registers.py: Use
 968         '^builtin_type_bound128' as regexp argument for
 969         add_builtin_pretty_printer.
 970
 971 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 972
 973         * guile/guile.c (guile_extension_script_ops): Remove forward
 974         declaration and mark as static.
 975         (guile_script_ops): Likewise.
 976         (extension_language_guile): Move further down in the file so
 977         it can reference the definitions for guile_{extension_,}script_ops.
 978
 979 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 980
 981         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 982         except SORTL, DFLTCC, and KDSA.
 983
 984 2019-10-08  Tom Tromey  <tromey@adacore.com>
 985
 986         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 987         (struct safe_symbol_file_add_args): Remove.
 988
 989 2019-10-08  Tom Tromey  <tromey@adacore.com>
 990
 991         * windows-nat.c: Don't include buildsym-legacy.h.
 992
 993 2019-10-08  Tom Tromey  <tromey@adacore.com>
 994
 995         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 996
 997 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 998
 999         * gdbtypes.c (overload_debug): Move comment to header.
1000         * gdbtypes.h (overload_debug): Declare.
1001         * valops.c: Remove declaration of overload_debug, instead
1002         include gdbtypes.h.
1003
1004 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1005
1006         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1007         through _().
1008         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1009         move comment...
1010         * language.h (lang_frame_mismatch_warn): ... here. Also add
1011         declaration.
1012         * top.c (lang_frame_mismatch_warn): Remove declaration.
1013         (check_frame_language_change): Pass lang_frame_mismatch_warn
1014         through _().
1015
1016 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1017
1018         * c-lang.h (vtbl_ptr_name): Declare.
1019         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1020         it from the header.
1021         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1022
1023 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1024
1025         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1026         gdb_static_assert.
1027
1028 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1029
1030         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1031         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1032         * ctfread.c: New file.
1033         * ctfread.h: New file.
1034         * elfread.c: Include ctfread.h.
1035         (struct elfinfo text_p): New member ctfsect.
1036         (elf_locate_sections): Mark CTF section.
1037         (elf_symfile_read): Call elfctf_build_psymtabs.
1038         * Makefile.in (LIBCTF): Add.
1039         (CLIBS): Use it.
1040         (CDEPS): Likewise.
1041         (DIST): Add ctfread.c.
1042
1043 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * ctfread.c (struct nextfield): Renamed to ...
1046         (struct ctf_nextfield): ... this.
1047         (struct field_info): Renamed to ...
1048         (strut ctf_field_info): ... this.
1049         (attach_fields_to_type): Update for renamed structures.
1050         (ctf_add_member_cb): Likewise.
1051         (ctf_add_enum_member_cb): Likewise.
1052         (process_struct_members): Likewise.
1053         (process_enum_type): Likewise.
1054
1055 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1056
1057         * tracectf.h: Rename, was ctf.h.
1058         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1059         * tracefile.c: Likewise.
1060         * tracepoint.c: Remove unused include ctf.h.
1061         * mi/mi-main.c: Likewise.
1062         * Makefile.in Replace ctf.c with tracectf.c.
1063
1064 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1065
1066         * version.in: Change version number to "9.0.50.DATE-git".
1067
1068 2019-10-03  Tom Tromey  <tom@tromey.com>
1069
1070         PR rust/24976:
1071         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1072
1073 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1076         cp_search_name_hash.
1077         * NEWS: Add entry about nested function support.
1078
1079 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1080             Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1083         for nested static variables when searchin VAR_DOMAIN.
1084         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1085         global scope, update comment.
1086         (add_partial_subprogram): Call add_partial_subprogram recursively
1087         for nested subroutines when processinng Fortran.
1088         (load_partial_dies): Process the child entities of a subprogram
1089         when processing Fortran.
1090         (partial_die_parent_scope): Handle building scope
1091         for Fortran nested functions.
1092         (process_die): Record that nested functions have a scope.
1093         (new_symbol): Always record Fortran subprograms on the global
1094         symbol list.
1095         (determine_prefix): How to build the prefix for Fortran
1096         subprograms.
1097
1098 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1101         have just sent the thread a SIGSTOP and are waiting for it to
1102         arrive.
1103
1104 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * btrace.c (btrace_add_pc): Remove whitespace before the template
1107         parameter in 'std::vector <...>'.
1108         (parse_xml_btrace_block): Likewise.
1109         (btrace_maint_decode_pt): Likewise.
1110         (btrace_maint_update_packets): Likewise.
1111         (btrace_maint_print_packets): Likewise.
1112         * btrace.h (struct btrace_maint_info): Likewise.
1113         * dwarf2read.c (struct type_unit_group): Likewise.
1114         (build_type_psymtabs_reader): Likewise.
1115         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1116         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1117         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1118
1119 2019-10-03  Tom de Vries  <tdevries@suse.de>
1120
1121         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1122         the first line of the help text for set/show style metadata.
1123
1124 2019-10-02  Tom Tromey  <tromey@adacore.com>
1125
1126         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1127         * gdbsupport/common-inferior.c: New file.
1128         * infcmd.c (startup_with_shell): Don't define.
1129         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1130         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1131         * inferior.h (startup_with_shell): Don't declare.
1132
1133 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1134
1135         * gdbsupport/gdb_assert.h: Include errors.h.
1136         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1137
1138 2019-10-02  Tom Tromey  <tromey@adacore.com>
1139
1140         * NEWS: Add $_ada_exception entry.
1141         * ada-lang.c (struct ada_catchpoint): Add constructor.
1142         <m_kind>: New member.
1143         (allocate_location_exception, re_set_exception): Remove
1144         "ex" parameter.
1145         (should_stop_exception): Compute $_ada_exception.
1146         (check_status_exception, print_it_exception)
1147         (print_one_exception, print_mention_exception): Remove
1148         "ex" parameter.
1149         (allocate_location_catch_exception, re_set_catch_exception)
1150         (check_status_exception, print_it_catch_exception)
1151         (print_one_catch_exception, print_mention_catch_exception)
1152         (print_recreate_catch_exception)
1153         (allocate_location_catch_exception_unhandled)
1154         (re_set_catch_exception_unhandled)
1155         (check_status_exception, print_it_catch_exception_unhandled)
1156         (print_one_catch_exception_unhandled)
1157         (print_mention_catch_exception_unhandled)
1158         (print_recreate_catch_exception_unhandled)
1159         (allocate_location_catch_assert, re_set_catch_assert)
1160         (check_status_assert, print_it_catch_assert)
1161         (print_one_catch_assert, print_mention_catch_assert)
1162         (print_recreate_catch_assert)
1163         (allocate_location_catch_handlers, re_set_catch_handlers)
1164         (check_status_handlers, print_it_catch_handlers)
1165         (print_one_catch_handlers, print_mention_catch_handlers)
1166         (print_recreate_catch_handlers): Remove.
1167         (create_ada_exception_catchpoint): Update.
1168         (initialize_ada_catchpoint_ops): Update.
1169
1170 2019-10-02  Tom Tromey  <tromey@adacore.com>
1171
1172         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1173         (create_excep_cond_exprs): Simplify exception string computation.
1174         (ada_exception_catchpoint_cond_string): Likewise.
1175
1176 2019-10-02  Tom Tromey  <tromey@adacore.com>
1177
1178         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1179         * ada-lang.c (lesseq_defined_than): Handle
1180         LOC_STATIC.
1181         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1182         parameter.
1183         (dwarf2_has_info): Likewise.
1184         (new_symbol): Set maybe_copied on symbol when
1185         appropriate.
1186         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1187         parameter.
1188         <can_copy>: New member.
1189         * elfread.c (record_minimal_symbol): Set maybe_copied
1190         on symbol when appropriate.
1191         (elf_symfile_read): Update call to dwarf2_has_info.
1192         * minsyms.c (lookup_minimal_symbol_linkage): New
1193         function.
1194         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1195         * symtab.c (get_symbol_address, get_msymbol_address):
1196         New functions.
1197         * symtab.h (get_symbol_address, get_msymbol_address):
1198         Declare.
1199         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1200         maybe_copied.
1201         (struct symbol, struct minimal_symbol) <maybe_copied>:
1202         New member.
1203
1204 2019-10-02  Tom Tromey  <tromey@adacore.com>
1205
1206         * source.c (struct current_source_location): New.
1207         (current_source_key): New global.
1208         (current_source_symtab, current_source_line)
1209         (current_source_pspace): Remove.
1210         (get_source_location): New function.
1211         (get_current_source_symtab_and_line)
1212         (set_default_source_symtab_and_line)
1213         (set_current_source_symtab_and_line)
1214         (clear_current_source_symtab_and_line, select_source_symtab)
1215         (info_source_command, print_source_lines_base)
1216         (info_line_command, search_command_helper, _initialize_source):
1217         Update.
1218
1219 2019-10-02  Tom Tromey  <tromey@adacore.com>
1220
1221         * source.c (select_source_symtab): Don't call
1222         decode_line_with_current_source.
1223
1224 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1225
1226         * symtab.c (lookup_global_symbol): Search global block.
1227
1228 2019-10-02  Tom Tromey  <tromey@adacore.com>
1229
1230         * coffread.c (process_coff_symbol): Update.
1231         * dwarf2read.c (var_decode_location, new_symbol): Update.
1232         * mdebugread.c (parse_symbol): Update.
1233         * objfiles.c (relocate_one_symbol): Update.
1234         * stabsread.c (define_symbol, fix_common_block)
1235         (scan_file_globals): Update.
1236         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1237         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1238         * xcoffread.c (process_xcoff_symbol): Update.
1239
1240 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1241
1242         * MAINTAINERS: Update my email address.
1243
1244 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1247         std::vector.
1248         (build_type_psymtabs_reader): Update for std::vector.
1249         (build_type_psymtab_dependencies): Likewise.
1250         * dwarf2read.h: Remove use of DEF_VEC_P.
1251         (typedef sig_type_ptr): Delete.
1252
1253 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1256         to std::vector.
1257         (btrace_maint_decode_pt): Likewise, and move allocation of the
1258         vector outside of the loop.
1259         (btrace_maint_update_packets): Update to handle change from VEC to
1260         std::vector.
1261         (btrace_maint_print_packets): Likewise.
1262         (maint_info_btrace_cmd): Likewise.
1263         * btrace.h: Remove use of DEF_VEC_O.
1264         (typedef btrace_pt_packet_s): Delete.
1265         (struct btrace_maint_info) <packets>: Change fromm VEC to
1266         std::vector.
1267         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1268
1269 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1272         make accesses into the vector constant references.
1273         (btrace_add_pc): Update for std::vector.
1274         (btrace_stitch_bts): Likewise.
1275         (parse_xml_btrace_block): Likewise.
1276         (btrace_maint_update_packets): Likewise.
1277         (btrace_maint_print_packets): Likewise.
1278         (maint_info_btrace_cmd): Likewise.
1279         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1280         std::vector.
1281         (btrace_data::empty): Likewise.
1282         (btrace_data_append): Likewise.
1283         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1284         (typedef btrace_block_s): Delete.
1285         (struct btrace_block): Add constructor.
1286         (struct btrace_data_bts) <blocks>: Change to std::vector.
1287         * nat/linux-btrace.c (perf_event_read_bts): Update for
1288         std::vector.
1289         (linux_read_bts): Likewise.
1290
1291 2019-10-01  Tom Tromey  <tom@tromey.com>
1292
1293         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1294
1295 2019-10-01  Tom Tromey  <tom@tromey.com>
1296
1297         * stack.c (print_frame, info_frame_command_core): Use
1298         styled_string.
1299         * linux-thread-db.c (try_thread_db_load_1)
1300         (try_thread_db_load_from_pdir_1): Use styled_string.
1301         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1302         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1303         (maybe_print_unsupported_script_warning)
1304         (maybe_print_script_not_found_warning): Use styled_string.
1305         * ada-lang.c (user_select_syms): Use styled_string.
1306
1307 2019-10-01  Tom Tromey  <tom@tromey.com>
1308
1309         * p-lang.c (pascal_printstr): Use metadata style.
1310         * value.c (show_convenience): Use metadata style.
1311         * valprint.c (valprint_check_validity, val_print_optimized_out)
1312         (val_print_not_saved, val_print_unavailable)
1313         (val_print_invalid_address, generic_val_print, val_print)
1314         (value_check_printable, val_print_array_elements): Use metadata
1315         style.
1316         * ui-out.h (class ui_out) <field_fmt>: New overload.
1317         <do_field_fmt>: Add style parameter.
1318         * ui-out.c (ui_out::field_fmt): New overload.
1319         * typeprint.c (type_print_unknown_return_type)
1320         (val_print_not_allocated, val_print_not_associated): Use metadata
1321         style.
1322         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1323         parameter.
1324         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1325         * tracepoint.c (tvariables_info_1): Use metadata style.
1326         * stack.c (print_frame_arg, print_frame_info, print_frame)
1327         (info_frame_command_core): Use metadata style.
1328         * skip.c (info_skip_command): Use metadata style.
1329         * rust-lang.c (rust_print_enum): Use metadata style.
1330         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1331         metadata style.
1332         * python/py-framefilter.c (py_print_single_arg): Use metadata
1333         style.
1334         * printcmd.c (do_one_display, print_variable_and_value): Use
1335         metadata style.
1336         * p-valprint.c (pascal_val_print)
1337         (pascal_object_print_value_fields): Use metadata style.
1338         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1339         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1340         parameter.
1341         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1342         * m2-valprint.c (m2_print_long_set): Use metadata style.
1343         * m2-typeprint.c (m2_print_type): Use metadata style.
1344         * infcmd.c (print_return_value_1): Use metadata style.
1345         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1346         * f-valprint.c (info_common_command_for_block): Use metadata
1347         style.
1348         * f-typeprint.c (f_type_print_base): Use metadata style.
1349         * expprint.c (print_subexp_standard): Use metadata style.
1350         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1351         * cli/cli-style.h (class cli_style_option): Add constructor.
1352         (metadata_style): Declare.
1353         * cli/cli-style.c (metadata_style): New global.
1354         (_initialize_cli_style): Register metadata style.
1355         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1356         parameter.
1357         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1358         * c-typeprint.c (c_type_print_base_struct_union)
1359         (c_type_print_base_1): Use metadata style.
1360         * breakpoint.c (watchpoint_value_print)
1361         (print_one_breakpoint_location): Use metadata style.
1362         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1363         style.
1364         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1365         style.
1366         * ada-valprint.c (val_print_packed_array_elements, printstr)
1367         (print_field_values, ada_val_print_ref, ada_val_print): Use
1368         metadata style.
1369         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1370         style.
1371         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1372         style.
1373         * ada-lang.c (user_select_syms): Use metadata style.
1374
1375 2019-10-01  Tom Tromey  <tom@tromey.com>
1376
1377         * cli/cli-cmds.c (pwd_command): Style output.
1378
1379 2019-10-01  Pedro Alves  <palves@redhat.com>
1380             Tom Tromey  <tom@tromey.com>
1381
1382         * symtab.c (print_symbol_info): Use %ps.
1383         (print_msymbol_info): Use %ps.
1384         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1385         * printcmd.c (print_variable_and_value): Use %ps.
1386         * macrocmd.c (show_pp_source_pos): Use %ps.
1387         * infrun.c (print_exited_reason): Use ui_out::message.
1388         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1389         (describe_other_breakpoints): Use ui_out::message and new
1390         formats.
1391         (say_where): Use new formats.
1392         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1393         and new formats.
1394
1395 2019-10-01  Pedro Alves  <palves@redhat.com>
1396             Tom Tromey  <tom@tromey.com>
1397
1398         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1399         (test_gdb_formats): New function.
1400         (run_tests): Call it.
1401         (test_format_specifier): Update.
1402         * utils.h (fputs_filtered): Update comment.
1403         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1404         (fputs_styled_unfiltered): Declare.
1405         * utils.c (fputs_styled_unfiltered): New function.
1406         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1407         (vfprintf_filtered): Update.
1408         (vfprintf_unfiltered, vprintf_filtered): Update.
1409         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1410         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1411         disallow_ui_out_field>: New constants.
1412         (enum class field_kind): New.
1413         (struct base_field_s, struct signed_field_s): New.
1414         (signed_field): New function.
1415         (struct string_field_s): New.
1416         (string_field): New function.
1417         (struct styled_string_s): New.
1418         (styled_string): New function.
1419         (class ui_out) <message>: Add comment.
1420         <vmessage, call_do_message>: New methods.
1421         <do_message>: Add style parameter.
1422         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1423         methods.
1424         (ui_out::message): Rewrite.
1425         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1426         parameter.
1427         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1428         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1429         gdb_extensions parameter.
1430         (class format_piece): Add parameter to constructor.
1431         (n_int_args): New field.
1432         * gdbsupport/format.c (format_pieces::format_pieces): Add
1433         gdb_extensions parameter.  Handle '*'.
1434         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1435         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1436         vfprintf_styled_no_gdbfmt.
1437         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1438         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1439         unfiltered output.
1440         * ui-style.h (struct ui_file_style) <ptr>: New method.
1441
1442 2019-10-01  Tom Tromey  <tom@tromey.com>
1443
1444         * unittests/format_pieces-selftests.c: Update.  Add final format.
1445         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1446         empty literal pieces.
1447
1448 2019-10-01  Tom Tromey  <tom@tromey.com>
1449
1450         * ui-out.h (enum class ui_out_style_kind): Remove.
1451         (class ui_out) <field_string, field_stsream, do_field_string>:
1452         Change type of "style".
1453         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1454         (ui_out::field_string): Update.
1455         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1456         of "style".
1457         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1458         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1459         * stack.c (print_frame_arg, print_frame_info, print_frame):
1460         Update.
1461         * source.c (print_source_lines_base): Update.
1462         * solib.c (info_sharedlibrary_command): Update.
1463         * skip.c (info_skip_command): Update.
1464         * record-btrace.c (btrace_call_history_src_line)
1465         (btrace_call_history): Update.
1466         * python/py-framefilter.c (py_print_frame): Update.
1467         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1468         "style".
1469         * mi/mi-out.c (mi_ui_out::do_table_header)
1470         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1471         (mi_ui_out::do_field_string): Update.
1472         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1473         Update.
1474         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1475         "style".
1476         * cli-out.c (cli_ui_out::do_table_header)
1477         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1478         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1479         (cli_ui_out::do_field_fmt): Update.
1480         * breakpoint.c (print_breakpoint_location): Update.
1481         (update_static_tracepoint): Update.
1482
1483 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1484
1485         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1486         conversion of gdb_datadir.
1487         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1488         remove not needed c_str ().
1489
1490 2019-09-30  Ali Tamur <tamur@google.com>
1491
1492         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1493         (dwarf2_string_attr): Likewise.
1494
1495 2019-09-30  Ali Tamur <tamur@google.com>
1496
1497         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1498         (process_full_type_unit): Likewise.
1499         (dump_die_shallow): Likewise.
1500         (cu_debug_loc_section): Likewise.
1501
1502 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1503
1504         * minsyms.c (compare_minimal_symbols): Rename to...
1505         (minimal_symbol_is_less_than): ...this, and adjust to STL
1506         conventions (return bool, take arguments as references)
1507         (minimal_symbol_reader::install): Call std::sort instead
1508         of qsort.
1509
1510 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1511
1512         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1513         hash and why.
1514         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1515         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1516
1517 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1518
1519         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1520         * psympriv.h (add_psymbol_to_list): Move comment here and update
1521         it.
1522
1523 2019-09-29  Tom de Vries  <tdevries@suse.de>
1524
1525         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1526         Use $tmpdir/$(basename "$output_file").dwz instead of
1527         "${output_file}.dwz".
1528
1529 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1530
1531         PR gdb/25045
1532         * hppa-linux-nat.c: Include gdbarch.h.
1533
1534 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1535
1536         * blockframe.c (find_pc_partial_function): Change return type to bool.
1537         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1538         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1539         (stub_gnu_ifunc_resolve_name): Likewise.
1540         * symtab.c (compare_filenames_for_search): Likewise.
1541         (compare_glob_filenames_for_search): Likewise.
1542         (matching_obj_sections): Likewise.
1543         (symbol_matches_domain): Likewise.
1544         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1545         (find_line_pc): Change return type to bool.
1546         (find_line_pc_range): Likewise.
1547         (producer_is_realview): Likewise.
1548         * symtab.h (symbol_matches_domain): Likewise.
1549         (find_pc_partial_function): Likewise.
1550         (find_pc_line_pc_range): Likewise.
1551         (in_gnu_ifunc_stub): Likewise.
1552         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1553         (find_line_pc): Likewise.
1554         (find_line_pc_range): Likewise.
1555         (matching_obj_sections): Likewise.
1556         (find_line_symtab): Change out parameter to bool.
1557         (producer_is_realview): Change return type to bool.
1558         (compare_filenames_for_search): Likewise.
1559         (compare_glob_filenames_for_search): Likewise.
1560
1561 2019-09-26  Tom Tromey  <tom@tromey.com>
1562
1563         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1564         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1565         * gdb_usleep.h: Remove.
1566         * gdb_usleep.c: Remove.
1567         * utils.c: Don't include gdb_usleep.h.
1568
1569 2019-09-26  Tom Tromey  <tromey@adacore.com>
1570
1571         * python/py-type.c (type_to_type_object): Call check_typedef
1572         for stub types.
1573
1574 2019-09-26  Tom Tromey  <tom@tromey.com>
1575
1576         * utils.h (initialize_utils): Don't declare.
1577         * top.c (gdb_init): Don't call initialize_utils.
1578         * utils.c (initialize_utils): Remove.  Move contents...
1579         (_initialize_utils): ... here.
1580
1581 2019-09-25  Tom Tromey  <tom@tromey.com>
1582
1583         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1584         * utils.h (make_hex_string): Don't declare.
1585         * utils.c (make_hex_string): Remove.
1586
1587 2019-09-24  Tom de Vries  <tdevries@suse.de>
1588
1589         PR gdb/23815
1590         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1591         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1592
1593 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1594
1595         * NEWS: Mention new simulator port for PRU.
1596
1597 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1598
1599         * ada-exp.y (write_object_remaining): Update.
1600         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1601         and eliminate the static buffer.
1602         (ada_decode_symbol): Update.
1603         (ada_la_decode): Update.
1604         (ada_sniff_from_mangled_name): Update.
1605         (is_valid_name_for_wild_match): Update.
1606         (ada_lookup_name_info::matches): Update and simplify.
1607         (name_matches_regex): Update.
1608         (ada_add_global_exceptions): Update.
1609         * ada-lang.h (ada_decode): Update signature.
1610         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1611         * dwarf-index-write.c (debug_names::insert): Update.
1612
1613 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1614
1615         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1616         formatting.
1617
1618 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1619
1620         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1621         Change "nonzero" to "true" in documentation.
1622
1623 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1624
1625         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1626         (_initialize_darwin_solib): Don't set
1627         darwin_so_ops.lookup_lib_global_symbol.
1628         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1629         set_gdbarch_iterate_over_objfiles_in_search_order.
1630         (elf_lookup_lib_symbol): Rename to...
1631         (svr4_iterate_over_objfiles_in_search_order): this, and update
1632         to iterate semantics.
1633         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1634         * solib.c (solib_global_lookup): Remove.
1635         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1636         (solib_global_lookup): Remove.
1637         * symtab.c (lookup_global_or_static_symbol): Remove call to
1638         solib_global_lookup.
1639
1640 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1641
1642         * NEWS: Move entries about default MI version now being
1643         version 3, and about the GDB/MI fix for multi-location
1644         breakpoints to the "since GDB 8.3" section.
1645
1646 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1647
1648         GDB 8.3.1 released.
1649
1650 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1651
1652         * NEWS: Mention that Cell/B.E. debugging support was removed.
1653         * MAINTAINERS: Remove spu target.
1654
1655         * config/djgpp/fnchange.lst: Remove entries for removed files.
1656
1657         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1658         spu-multiarch.o, and spu-tdep.o.
1659         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1660         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1661         spu-multiarch.c, and spu-tdep.c.
1662         * spu-linux-nat.c: Remove file.
1663         * spu-multiarch.c: Remove file.
1664         * spu-tdep.c: Remove file.
1665         * spu-tdep.h: Remove file.
1666         * solib-spu.c: Remove file.
1667         * solib-spu.h: Remove file.
1668
1669         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1670         * configure.nat (spu-linux): Remove.
1671         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1672         solib-multiarch.o from gdb_target_obs.
1673         (spu*-*-*): Remove.
1674
1675         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1676         feature flag.
1677         (ppc_linux_no_features): Update.
1678         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1679         Cell/B.E. support.
1680         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1681         (tdesc_powerpc_cell64l): Likewise.
1682         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1683         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1684         Cell/B.E. support.
1685         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1686         Do not include "features/rs6000/powerpc-cell32l.c" or
1687         "features/rs6000/powerpc-cell64l.c".
1688         (ppc_linux_spu_section): Remove.
1689         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1690         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1691         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1692         (ppc_linux_spe_context_lookup): Remove.
1693         (ppc_linux_spe_context_inferior_created): Remove.
1694         (ppc_linux_spe_context_solib_loaded): Remove.
1695         (ppc_linux_spe_context_solib_unloaded): Remove.
1696         (ppc_linux_spe_context): Remove.
1697         (struct ppu2spu_cache): Remove.
1698         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1699         (struct ppu2spu_data): Remove.
1700         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1701         ppu2spu_unwind): Remove.
1702         (ppc_linux_init_abi): Remove Cell/B.E. support.
1703         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1704
1705         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1706         (rs6000/powerpc-cell64l-expedite): Likewise
1707         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1708         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1709         rs6000/powerpc-cell64l.xml.
1710         * features/rs6000/powerpc-cell32l.xml: Remove.
1711         * features/rs6000/powerpc-cell64l.xml: Likewise.
1712         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1713         * features/rs6000/powerpc-cell64l.c: Likewise.
1714         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1715         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1716         * regformats/reg-spu.dat: Remove.
1717
1718         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1719         * corelow.c (struct spuid_list): Remove.
1720         (add_to_spuid_list): Remove.
1721         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1722         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1723         (remote_protocol_features): Remove associated entries.
1724         (_initialize_remote): No longer initialize them.
1725         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1726         * linux-nat.c (SPUFS_MAGIC): Remove.
1727         (linux_proc_xfer_spu): Remove.
1728         (spu_enumerate_spu_ids): Remove.
1729         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1730         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1731         (linux_make_corefile_notes): No longer call it.
1732
1733         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1734         (cooked_write_test): Likewise.
1735
1736 2019-09-20  Tom Tromey  <tom@tromey.com>
1737
1738         * NEWS: Mention case-sensitivity of TUI commands.
1739         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1740         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1741         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1742
1743 2019-09-20  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-source.c (tui_source_window::set_contents): Use
1746         make_unique_xstrdup.
1747         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1748         make_unique_xstrdup.
1749
1750 2019-09-20  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-data.c: Remove separator comments.
1753         * tui/tui-layout.c: Remove separator comments.
1754         * tui/tui-win.c: Remove separator comments.
1755         * tui/tui-wingeneral.c: Remove separator comments.
1756
1757 2019-09-20  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui.h (strcat_to_buf): Don't declare.
1760         * tui/tui.c (strcat_to_buf): Remove.
1761
1762 2019-09-20  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1765         from "fullname".
1766         * tui/tui-source.c (tui_source_window::set_contents)
1767         (tui_source_window::location_matches_p)
1768         (tui_source_window::maybe_update): Update.
1769
1770 2019-09-20  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1773         Update.
1774         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1775         prefix.
1776         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1777         (tui_data_window::line_from_reg_element_no)
1778         (tui_data_window::first_reg_element_no_inline)
1779         (tui_data_window::show_registers)
1780         (tui_data_window::show_register_group)
1781         (tui_data_window::display_registers_from)
1782         (tui_data_window::display_registers_from_line)
1783         (tui_data_window::first_data_item_displayed)
1784         (tui_data_window::delete_data_content_windows)
1785         (tui_data_window::erase_data_content)
1786         (tui_data_window::do_scroll_vertical)
1787         (tui_data_window::refresh_window)
1788         (tui_data_window::check_register_values): Update.
1789
1790 2019-09-20  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1793         (struct tui_locator_window) <full_name, proc_name>: Now
1794         std::string.
1795         * tui/tui-stack.c (tui_locator_window::make_status_line)
1796         (tui_locator_window::set_locator_fullname)
1797         (tui_locator_window::set_locator_info): Update.
1798         * tui/tui-source.c (tui_source_window::set_contents)
1799         (tui_source_window::showing_source_p): Update.
1800
1801 2019-09-20  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1804         Don't call tui_locator_win_info_ptr.
1805
1806 2019-09-20  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1809
1810 2019-09-20  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1813         height for locator.
1814         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1815         * tui/tui-layout.c (show_source_disasm_command, show_data)
1816         (show_source_or_disasm_and_command): Use 1 as height for locator.
1817
1818 2019-09-20  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui.c (tui_enable): Update.
1821         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1822         Update.
1823         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1824         Update.
1825         * tui/tui-data.c (win_resized): Now bool.
1826         (tui_win_resized): Return bool.
1827         (tui_set_win_resized_to): Accept a bool.
1828
1829 2019-09-20  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1832         Change type of "refresh_values_only".
1833         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1834         type of "refresh_values_only".
1835
1836 2019-09-20  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1839         std::string.
1840         (tui_disassemble): Add "pos" parameter.
1841         (tui_disasm_window::set_contents): Simplify.
1842
1843 2019-09-20  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-winsource.h (struct tui_source_window_base)
1846         <show_source_content>: Now private.
1847         * tui/tui-winsource.c
1848         (tui_source_window_base::show_source_content): Don't handle empty
1849         content case.
1850
1851 2019-09-20  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-layout.c (show_source_disasm_command)
1854         (show_source_or_disasm_and_command): Don't call
1855         show_source_content.
1856
1857 2019-09-20  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1860         Declare.
1861         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1862         from tui_make_status_line.
1863         (tui_locator_window::rerender): Update.
1864
1865 2019-09-20  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1868         (tui_locator_window::rerender): Update.
1869
1870 2019-09-20  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-winsource.h (struct tui_source_window_base)
1873         <~tui_source_window_base>: Don't declare.
1874         <fullname>: Remove.
1875         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1876         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1877         member.
1878         * tui/tui-source.c (tui_source_window::set_contents): Update.
1879         (tui_source_window::location_matches_p)
1880         (tui_source_window::maybe_update): Update.
1881
1882 2019-09-20  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-winsource.h (~tui_source_element): Remove.
1885         (tui_source_element): Update.
1886         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1887         * tui/tui-winsource.c (tui_show_source_line): Update.
1888         * tui/tui-source.c (tui_source_window::set_contents): Update.
1889         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1890
1891 2019-09-20  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1894         declare.
1895         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1896         tui_clear_source_windows_detail.
1897         * tui/tui-winsource.h (struct tui_source_window_base)
1898         <clear_detail>: Don't declare.
1899         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1900         Remove.
1901         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1902
1903 2019-09-20  Tom Tromey  <tromey@adacore.com>
1904
1905         PR ada/24919:
1906         * block.c (contained_in): Fix final return value.
1907
1908 2019-09-20  Alan Modra  <amodra@gmail.com>
1909
1910         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1911         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1912         (read_indirect_string_from_dwz): Use bfd accessor.
1913         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1914         * machoread.c (macho_symfile_read_all_oso): Likewise.
1915         * solib.c (solib_bfd_open): Likewise.
1916
1917 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1918
1919         * eval.c: Move declaration of overload_resolution to...
1920         * value.h: ...here.
1921
1922 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1923
1924         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1925         * arm-linux-tdep.c: Likewise.
1926         * arm-nbsd-nat.c: Likewise.
1927         * arm-tdep.h: Declare arm_apcs_32.
1928         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1929
1930 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1931
1932         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1933         * dwarf2read.h: Declare dwarf_always_disassemble.
1934
1935 2019-09-19  Tom de Vries  <tdevries@suse.de>
1936
1937         PR gdb/25009
1938         * source-cache.c (source_cache::ensure): Catch exception thrown during
1939         construction of the highlighter.
1940
1941 2019-09-18  Alan Modra  <amodra@gmail.com>
1942
1943         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1944         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1945         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1946         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1947         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1948         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1949         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1950         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1951         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1952         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1953         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1954         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1955         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1956         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1957         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1958         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1959         * mi/mi-interp.c: Update throughout for bfd section macro and
1960         function changes.
1961         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1962         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1963
1964 2019-09-18  Tom Tromey  <tom@tromey.com>
1965
1966         * NEWS: Add entry.
1967         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1968         call rl_initialize.
1969         (tui_enable): Do not call rl_initialize.
1970
1971 2019-09-18  Christian Groessler  <chris@groessler.org>
1972
1973         * alpha-linux-nat.c: Include gdbarch.h.
1974
1975 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1976
1977         * ui-file.c: Include cli/cli-style.h.
1978         (term_cli_styling): Remove cli_styling declaration.
1979
1980 2019-09-18  Alan Modra  <amodra@gmail.com>
1981
1982         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1983         to bfd_asymbol_section.
1984
1985 2019-09-18  Alan Modra  <amodra@gmail.com>
1986
1987         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1988         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1989         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1990
1991 2019-09-18  Alan Modra  <amodra@gmail.com>
1992
1993         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1994         * spu-linux-nat.c (spu_bfd_open): Likewise.
1995
1996 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1997
1998         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1999         to bool to match definition in dwarf2read.c.
2000
2001 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2002
2003         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2004         (print_signatures): Likewise.
2005         (trust_pad_over_xvs): Likewise.
2006         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2007         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2008         * arm-linux-nat.c (arm_apcs_32): Likewise.
2009         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2010         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2011         * arm-tdep.c (arm_debug): Likewise.
2012         (arm_apcs_32): Likewise.
2013         * auto-load.c (debug_auto_load): Likewise.
2014         (auto_load_gdb_scripts): Likewise.
2015         (global_auto_load): Likewise.
2016         (auto_load_local_gdbinit): Likewise.
2017         (auto_load_local_gdbinit_loaded): Likewise.
2018         * auto-load.h (global_auto_load): Likewise.
2019         (auto_load_local_gdbinit): Likewise.
2020         (auto_load_local_gdbinit_loaded): Likewise.
2021         * breakpoint.c (disconnected_dprintf): Likewise.
2022         (breakpoint_proceeded): Likewise.
2023         (automatic_hardware_breakpoints): Likewise.
2024         (always_inserted_mode): Likewise.
2025         (target_exact_watchpoints): Likewise.
2026         (_initialize_breakpoint): Update.
2027         * breakpoint.h (target_exact_watchpoints): Change to bool.
2028         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2029         * cli/cli-cmds.c (trace_commands): Likewise.
2030         * cli/cli-cmds.h (trace_commands): Likewise.
2031         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2032         to bool*.
2033         * cli/cli-logging.c (logging_overwrite): Change to bool.
2034         (logging_redirect): Likewise.
2035         (debug_redirect): Likewise.
2036         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2037         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2038         to bool.
2039         <boolean_option_def>: Update.
2040         (struct flag_option_def): Change default type of Context to bool
2041         from int.
2042         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2043         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2044         (get_setshow_command_value_string): Likewise.
2045         * cli/cli-style.c (cli_styling): Change to bool.
2046         (source_styling): Likewise.
2047         * cli/cli-style.h (source_styling): Likewise.
2048         (cli_styling): Likewise.
2049         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2050         to bool.
2051         * command.h (var_types): Update comment.
2052         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2053         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2054         bool.
2055         (debug_compile_cplus_scopes): Likewise.
2056         * compile/compile-internal.h (compile_debug): Likewise.
2057         * compile/compile.c (compile_debug): Likewise.
2058         (struct compile_options) <raw>: Likewise.
2059         * cp-support.c (catch_demangler_crashes): Likewise.
2060         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2061         (usr_cmd_cris_dwarf2_cfi): Likewise.
2062         * csky-tdep.c (csky_debug): Likewise.
2063         * darwin-nat.c (enable_mach_exceptions): Likewise.
2064         * dcache.c (dcache_enabled_p): Likewise.
2065         * defs.h (info_verbose): Likewise.
2066         * demangle.c (demangle): Likewise.
2067         (asm_demangle): Likewise.
2068         * dwarf-index-cache.c (debug_index_cache): Likewise.
2069         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2070         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2071         * dwarf2read.c (check_physname): Likewise.
2072         (use_deprecated_index_sections): Likewise.
2073         (dwarf_always_disassemble): Likewise.
2074         * eval.c (overload_resolution): Likewise.
2075         * event-top.c (set_editing_cmd_var): Likewise.
2076         (exec_done_display_p): Likewise.
2077         * event-top.h (set_editing_cmd_var): Likewise.
2078         (exec_done_display_p): Likewise.
2079         * exec.c (write_files): Likewise.
2080         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2081         (debug_fbsd_nat): Likewise.
2082         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2083         Likewise.
2084         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2085         <backtrace_past_entry> Likewise.
2086         * gdb-demangle.h (demangle): Likewise.
2087         (asm_demangle): Likewise.
2088         * gdb_bfd.c (bfd_sharing): Likewise.
2089         * gdbcore.h (write_files): Likewise.
2090         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2091         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2092         * gdbthread.h (print_thread_events): Likewise.
2093         * gdbtypes.c (opaque_type_resolution): Likewise.
2094         (strict_type_checking): Likewise.
2095         * gnu-nat.c (gnu_debug_flag): Likewise.
2096         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2097         * guile/scm-param.c (pascm_variable): Add boolval.
2098         (add_setshow_generic): Update.
2099         (pascm_param_value): Update.
2100         (pascm_set_param_value_x): Update.
2101         * hppa-tdep.c (hppa_debug): Change to bool..
2102         * infcall.c (may_call_functions_p): Likewise.
2103         (coerce_float_to_double_p): Likewise.
2104         (unwind_on_signal_p): Likewise.
2105         (unwind_on_terminating_exception_p): Likewise.
2106         * infcmd.c (startup_with_shell): Likewise.
2107         * inferior.c (print_inferior_events): Likewise.
2108         * inferior.h (startup_with_shell): Likewise.
2109         (print_inferior_events): Likewise.
2110         * infrun.c (step_stop_if_no_debug): Likewise.
2111         (detach_fork): Likewise.
2112         (debug_displaced): Likewise.
2113         (disable_randomization): Likewise.
2114         (non_stop): Likewise.
2115         (non_stop_1): Likewise.
2116         (observer_mode): Likewise.
2117         (observer_mode_1): Likewise.
2118         (set_observer_mode): Update.
2119         (sched_multi): Change to bool.
2120         * infrun.h (debug_displaced): Likewise.
2121         (sched_multi): Likewise.
2122         (step_stop_if_no_debug): Likewise.
2123         (non_stop): Likewise.
2124         (disable_randomization): Likewise.
2125         * linux-tdep.c (use_coredump_filter): Likewise.
2126         (dump_excluded_mappings): Likewise.
2127         * linux-thread-db.c (auto_load_thread_db): Likewise.
2128         (check_thread_db_on_load): Likewise.
2129         * main.c (captured_main_1): Update.
2130         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2131         xx2_opt, boolean_opt>: Change to bool.
2132         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2133         * maint.c (maintenance_profile_p): Likewise.
2134         (per_command_time): Likewise.
2135         (per_command_space): Likewise.
2136         (per_command_symtab): Likewise.
2137         * memattr.c (inaccessible_by_default): Likewise.
2138         * mi/mi-main.c (mi_async): Likewise.
2139         (mi_async_1): Likewise.
2140         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2141         * nat/fork-inferior.h (startup_with_shell): Likewise.
2142         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2143         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2144         * nios2-tdep.c (nios2_debug): Likewise.
2145         * or1k-tdep.c (or1k_debug): Likewise.
2146         * parse.c (parser_debug): Likewise.
2147         * parser-defs.h (parser_debug): Likewise.
2148         * printcmd.c (print_symbol_filename): Likewise.
2149         * proc-api.c (procfs_trace): Likewise.
2150         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2151         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2152         (set_parameter_value): Update.
2153         (add_setshow_generic): Update.
2154         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2155         to bool*.
2156         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2157         int*.
2158         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2159         * record-btrace.c (record_btrace_target::store_registers): Update.
2160         * record-full.c (record_full_memory_query): Change to bool.
2161         (record_full_stop_at_limit): Likewise.
2162         * record-full.h (record_full_memory_query): Likewise.
2163         * remote-notif.c (notif_debug): Likewise.
2164         * remote-notif.h (notif_debug): Likewise.
2165         * remote.c (use_range_stepping): Likewise.
2166         (interrupt_on_connect): Likewise.
2167         (remote_break): Likewise.
2168         * ser-tcp.c (tcp_auto_retry): Likewise.
2169         * ser-unix.c (serial_hwflow): Likewise.
2170         * skip.c (debug_skip): Likewise.
2171         * solib-aix.c (solib_aix_debug): Likewise.
2172         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2173         (spu_auto_flush_cache_p): Likewise.
2174         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2175         Likewise.
2176         (struct info_print_options) <quiet>: Likewise.
2177         * symfile-debug.c (debug_symfile): Likewise.
2178         * symfile.c (auto_solib_add): Likewise.
2179         (separate_debug_file_debug): Likewise.
2180         * symfile.h (auto_solib_add): Likewise.
2181         (separate_debug_file_debug): Likewise.
2182         * symtab.c (basenames_may_differ): Likewise.
2183         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2184         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2185         (struct info_types_options) <quiet>: Likewise.
2186         * symtab.h (demangle): Likewise.
2187         (basenames_may_differ): Likewise.
2188         * target-dcache.c (stack_cache_enabled_1): Likewise.
2189         (code_cache_enabled_1): Likewise.
2190         * target.c (trust_readonly): Likewise.
2191         (may_write_registers): Likewise.
2192         (may_write_memory): Likewise.
2193         (may_insert_breakpoints): Likewise.
2194         (may_insert_tracepoints): Likewise.
2195         (may_insert_fast_tracepoints): Likewise.
2196         (may_stop): Likewise.
2197         (auto_connect_native_target): Likewise.
2198         (target_stop_and_wait): Update.
2199         (target_async_permitted): Change to bool.
2200         (target_async_permitted_1): Likewise.
2201         (may_write_registers_1): Likewise.
2202         (may_write_memory_1): Likewise.
2203         (may_insert_breakpoints_1): Likewise.
2204         (may_insert_tracepoints_1): Likewise.
2205         (may_insert_fast_tracepoints_1): Likewise.
2206         (may_stop_1): Likewise.
2207         * target.h (target_async_permitted): Likewise.
2208         (may_write_registers): Likewise.
2209         (may_write_memory): Likewise.
2210         (may_insert_breakpoints): Likewise.
2211         (may_insert_tracepoints): Likewise.
2212         (may_insert_fast_tracepoints): Likewise.
2213         (may_stop): Likewise.
2214         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2215         (make_thread_apply_all_options_def_group): Change argument from int*
2216         to bool*.
2217         (thread_apply_all_command): Update.
2218         (print_thread_events): Change to bool.
2219         * top.c (confirm): Likewise.
2220         (command_editing_p): Likewise.
2221         (history_expansion_p): Likewise.
2222         (write_history_p): Likewise.
2223         (info_verbose): Likewise.
2224         * top.h (confirm): Likewise.
2225         (history_expansion_p): Likewise.
2226         * tracepoint.c (disconnected_tracing): Likewise.
2227         (circular_trace_buffer): Likewise.
2228         * typeprint.c (print_methods): Likewise.
2229         (print_typedefs): Likewise.
2230         * utils.c (debug_timestamp): Likewise.
2231         (sevenbit_strings): Likewise.
2232         (pagination_enabled): Likewise.
2233         * utils.h (sevenbit_strings): Likewise.
2234         (pagination_enabled): Likewise.
2235         * valops.c (overload_resolution): Likewise.
2236         * valprint.h (struct value_print_options) <prettyformat_arrays,
2237         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2238         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2239         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2240         Likewise.
2241         * windows-nat.c (new_console): Likewise.
2242         (cygwin_exceptions): Likewise.
2243         (new_group): Likewise.
2244         (debug_exec): Likewise.
2245         (debug_events): Likewise.
2246         (debug_memory): Likewise.
2247         (debug_exceptions): Likewise.
2248         (useshell): Likewise.
2249         * windows-tdep.c (maint_display_all_tib): Likewise.
2250         * xml-support.c (debug_xml): Likewise.
2251
2252 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2253
2254         * source.c (prepare_path_for_appending): New function.
2255         (openp): Make use of new function.
2256         (find_and_open_source): Search for the compilation directory and
2257         source file as a relative path beneath the directory search path.
2258
2259 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2260
2261         * source-cache.c (source_cache::get_line_charpos): Catch
2262         exceptions and return false, this matches the behaviour documented
2263         in the header file.
2264
2265 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2266
2267         * ada-tasks.c (info_task): Remove quoting of the task's name.
2268
2269 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2270
2271         * symfile.c (auto_solib_add): Replace comment with a reference
2272         to the header file.
2273
2274 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2275
2276         * NEWS: Mention that gdb can now be compiled with Python 3
2277         on Windows.
2278
2279 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * maint.c (maint_print_section_data::maint_print_section_data):
2282         Force use of 'float log10 (float)' by casting the argument to
2283         float.
2284
2285 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * maint.c: Add 'cmath' include.
2288         (struct maint_print_section_data): New structure.
2289         (print_section_index): New function.
2290         (print_bfd_section_info): Add header comment, small whitespace
2291         cleanup, and update to call new print_section_index function.
2292         (print_objfile_section_info): Likewise.
2293         (maint_obj_section_from_bfd_section): New function.
2294         (print_bfd_section_info_maybe_relocated): New function.
2295         (maintenance_info_sections): Add header comment, always use
2296         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2297
2298 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2299
2300         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2301         inner scope, add check that the objfile has psymtabs before
2302         checking psymtabs_addrmap.
2303         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2304
2305 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2306
2307         * NEWS: Announce that Ada task names are now shown at more places,
2308         and between quotes (except in info task output).
2309         * gdb/ada-tasks.c (task_to_str): New function.
2310         (display_current_task_id): Call task_to_str.
2311         (task_command_1): Likewise.
2312         (print_ada_task_info): In non-mi mode, Properly align headers and data
2313         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2314
2315 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2316
2317         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2318         prstatus.pr_lwp.pr_info instead of making it up.
2319
2320 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2321
2322         * auto-load.c (auto_load_expand_dir_vars): Update.
2323         * defs.h (gdb_datadir): Change to std::string.
2324         (python_libdir): Likewise.
2325         (relocate_gdb_directory): Change return type to std::string.
2326         * guile/guile.c (gdbscm_data_directory): Update.
2327         (initialize_scheme_side): Update.
2328         * jit.c (jit_reader_dir): Change to std::string.
2329         (jit_reader_load_command): Update.
2330         * main.c (gdb_datadir): Change to std::string.
2331         (python_libdir): Likewise.
2332         (set_gdb_data_directory): Update.
2333         (relocate_path): Change to return std::string.
2334         (relocate_gdb_directory): Change to return std::string.
2335         (relocate_gdbinit_path_maybe_in_datadir): Update.
2336         (captured_main_1): Update.
2337         * python/python.c (do_start_initialization): Update.
2338         * top.c (show_gdb_datadir): Update.
2339         * xml-syscall.c (xml_init_syscalls_info): Update.
2340         (init_syscalls_info): Update.
2341
2342 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2343
2344         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2345         out of get_init_files.
2346         (get_init_files): Update.
2347
2348 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2349
2350         * main.c (get_init_files): Change to use std::string.
2351         (captured_main_1): Update.
2352         (print_gdb_help): Update.
2353
2354 2019-09-11  Ali Tamur  <tamur@google.com>
2355
2356         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2357         implementation.
2358
2359 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2360
2361         * dbxread.c (read_dbx_symtab): Update.
2362         * dwarf2read.c (load_partial_dies): Update.
2363         * mdebugread.c (parse_partial_symbols): Update.
2364         (handle_psymbol_enumerators): Update.
2365         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2366         * psymtab.c (add_psymbol_to_bcache): Likewise.
2367         (add_psymbol_to_list): Likewise.
2368         * symtab.c (symbol_set_names): Likewise.
2369         * symtab.h (symbol_set_names): Likewise.
2370         * xcoffread.c (scan_xcoff_symtab): Update.
2371
2372 2019-09-11  Tom Tromey  <tom@tromey.com>
2373
2374         * symfile-mem.c (symbol_file_add_from_memory): Use
2375         bfd_set_filename.
2376         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2377         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2378
2379 2019-09-10  Tom Tromey  <tromey@adacore.com>
2380
2381         * dwarf-index-write.c (write_psymbols): Extend error message.
2382         (debug_names::insert): Add Ada code.
2383         (debug_names::write_psymbols): Remove Ada check.
2384         (debug_names) <m_string_obstack>: New member.
2385         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2386         (gdb_index_symbol_name_matcher::matches): Remove.
2387         (mapped_index_base::find_name_components_bounds): Add "lang"
2388         parameter.
2389         (mapped_index_base::build_name_components): Also split names
2390         according to Ada syntax.
2391         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2392         type of "match_callback".
2393         (check_match, check_find_bounds_finds)
2394         (dw2_expand_symtabs_matching): Update.
2395         (dw2_debug_names_iterator): Add new constructor.
2396         (dw2_debug_names_map_matching_symbols): New function.
2397         (dw2_debug_names_expand_symtabs_matching): Update.
2398         (dwarf2_debug_names_functions): Use
2399         dw2_debug_names_map_matching_symbols.
2400
2401 2019-09-10  Tom Tromey  <tromey@adacore.com>
2402
2403         * dwarf2read.c (dw2_get_file_names_reader): Add the
2404         CU's file name to the results.
2405
2406 2019-09-10  Tom Tromey  <tromey@adacore.com>
2407
2408         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2409         map_matching_symbols.  Update.
2410         * dwarf2read.c (dw2_map_matching_symbols): Update.
2411         * psymtab.c (match_partial_symbol): Change type; update.
2412         (psym_map_matching_symbols): Likewise.
2413         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2414         type; update.
2415         * symfile.h (struct quick_symbol_functions)
2416         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2417         Remove "match".
2418
2419 2019-09-10  Tom Tromey  <tromey@adacore.com>
2420
2421         * psymtab.c (map_block): Remove.
2422         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2423         * symtab.c (iterate_over_symbols_terminated): New function.
2424         * symtab.c (iterate_over_symbols_terminated): Declare.
2425
2426 2019-09-10  Tom Tromey  <tromey@adacore.com>
2427
2428         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2429         * language.h (struct language_defn) <la_iterate_over_symbols>:
2430         Return bool.
2431         * symtab.c (iterate_over_symbols): Return bool.
2432         * symtab.h (iterate_over_symbols): Return bool.
2433
2434 2019-09-10  Tom Tromey  <tromey@adacore.com>
2435
2436         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2437         (add_nonlocal_symbols): Update.
2438         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2439         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2440         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2441         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2442         Change type of "callback".  Remove "data".
2443
2444
2445 2019-09-09  Ali Tamur  <tamur@google.com>
2446
2447         * dwarf2read.c (comp_unit_head): Update comment.
2448         (dwarf2_dwo_name): New function declaration.
2449         (dwarf_unit_type_name): New function declaration.
2450         (read_comp_unit_head): Add support for new compilation units,
2451         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2452         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2453         (currently named as "signature") in their header. Also clarify error
2454         messages.
2455         (lookup_dwo_id): New function. Returns the dwo id of the given
2456         compile unit.
2457         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2458         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2459         functions.
2460         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2461         (dwarf2_dwo_name): Get the dwo name if present.
2462         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2463         purposes.
2464
2465 2019-09-09  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2468
2469 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2470
2471         * python/python.c (do_start_initialization): Make progname_copy static,
2472         to avoid a leak report.
2473
2474 2019-09-08  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2477
2478 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2479
2480         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2481         Change type to gdb::optional<block_enum>.
2482         (dw2_symtab_iter_init): Change block_index parameter type
2483         to gdb::optional<block_enum>.
2484         (dw2_lookup_symbol): Change block_index parameter
2485         type to block_enum.c
2486         (dw2_debug_names_lookup_symbol): Likewise.
2487         * psymtab.c (psym_lookup_symbol): Likewise.
2488         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2489         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2490         Likewise.
2491
2492 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2493
2494         * defs.h (relocate_gdb_directory): Change int to bool in
2495         signature and rename flag to relocatable.
2496         * main.c (relocate_path): Likewise.
2497         (relocate_gdb_directory): Likewise.
2498
2499 2019-09-06  Alan Modra  <amodra@gmail.com>
2500
2501         * coffread.c (coff_symfile_read): Constify filename variable.
2502         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2503         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2504         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2505         * solib.c (reload_shared_libraries_1): Likewise.
2506         * symfile.c (reread_symbols): Likewise.
2507         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2508         * solib-darwin.c (darwin_bfd_open): Likewise.
2509         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2510
2511 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2512
2513         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2514         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2515
2516 2019-09-03  Tom Tromey  <tromey@adacore.com>
2517
2518         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2519         types.
2520         (has_negatives): Unbias a range type bound.
2521         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2522         * gdbtypes.c (operator==): Handle new field.
2523         (create_range_type): Add "bias" parameter.
2524         (create_static_range_type, resolve_dynamic_range): Update.
2525         * gdbtypes.h (struct range_bounds) <bias>: New member.
2526         (create_range_type): Add bias parameter.
2527         * printcmd.c (print_scalar_formatted): Unbias range types.
2528         * value.c (unpack_long): Unbias range types.
2529         (pack_long): Bias range types.
2530
2531 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2532
2533         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2534         probe arguments.
2535
2536 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2537
2538         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2539         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2540         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2541         (compile_probe_arg): Likewise.
2542         * probe.h (get_argument_count): Likewise.
2543         * solib-svr4.c (solib_event_probe_action): Likewise.
2544         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2545
2546 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2547
2548         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2549         code to here...
2550         (svr4_create_solib_event_breakpoints): ...from here.
2551
2552 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2553
2554         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2555         suffix from warning message.
2556
2557 2019-08-30  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui-winsource.h (struct tui_source_window_base)
2560         <refresh_all>: Don't declare.
2561         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2562         Remove.
2563         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2564         tui_show_locator_content.
2565         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2566         declare.
2567         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2568         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2569         declare.
2570
2571 2019-08-30  Tom Tromey  <tom@tromey.com>
2572
2573         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2574
2575 2019-08-30  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2578         Remove unnecessary forward declarations.
2579
2580 2019-08-30  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2583         rerender.
2584         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2585         tui_show_locator_content.
2586
2587 2019-08-30  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2590         (tui_locator_window::rerender): Rewrite using body of previous
2591         tui_show_locator_content.
2592
2593 2019-08-30  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2596         set_locator_fullname>: New methods.
2597         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2598         Rename from tui_set_locator_fullname.
2599         (tui_locator_window::set_locator_info): Rename from
2600         tui_set_locator_info.  Return bool.
2601         (tui_update_locator_fullname, tui_show_frame_info): Update.
2602
2603 2019-08-30  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2606
2607 2019-08-30  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2610         call touchwin.
2611
2612 2019-08-30  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-wingeneral.c (box_win): Assume win_info and
2615         win_info->handle cannot be NULL.
2616
2617 2019-08-30  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2620         refresh_window>: Declare.
2621         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2622         resize.
2623         (tui_data_item_window::rerender): Rename from
2624         tui_display_register.
2625         (tui_data_item_window::refresh_window): New method.
2626         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2627         no-op.
2628
2629 2019-08-30  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2632         regs_column_count, current_group>: Move later.  Now private.
2633         <get_current_group>: New method.
2634         * tui/tui-regs.c (tui_reg_command): Update.
2635         * tui/tui-layout.c (tui_set_layout): Update.
2636
2637 2019-08-30  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2640         (tui_data_window::rerender): Don't call
2641         check_and_display_highlight_if_needed.
2642         (tui_data_window::refresh_all): Remove call to
2643         erase_data_content.
2644
2645 2019-08-30  Tom Tromey  <tom@tromey.com>
2646
2647         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2648         (tui_data_window::display_registers_from)
2649         (tui_data_window::display_reg_element_at_line)
2650         (tui_data_window::display_registers_from_line): Remove checks of
2651         "empty".
2652
2653 2019-08-30  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2656         Don't declare.
2657         * tui/tui-regs.c (tui_data_window::show_registers): Call
2658         rerender.
2659         (tui_data_window::rerender): Rename from display_all_data.
2660         (tui_data_window::rerender): Remove old implementation.
2661
2662 2019-08-30  Tom Tromey  <tom@tromey.com>
2663
2664         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2665         text.
2666         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2667
2668 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2669             Sergio Durigan Junior  <sergiodj@redhat.com>
2670
2671         PR win32/24284
2672         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2673
2674 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2677         when searching for types.
2678
2679 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * f-lang.c (f_language_defn): Use f_print_typedef.
2682         * f-lang.h (f_print_typedef): Declare.
2683         * f-typeprint.c (f_print_typedef): Define.
2684
2685 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2686
2687         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2688
2689 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         * cli/cli-utils.c (info_print_options_defs): Delete.
2692         (make_info_print_options_def_group): Delete.
2693         (extract_info_print_options): Delete.
2694         (info_print_command_completer): Delete.
2695         (info_print_args_help): Add extra parameter, and optionally
2696         include text about -n flag.
2697         * cli/cli-utils.h (struct info_print_options): Delete.
2698         (extract_info_print_options): Delete declaration.
2699         (info_print_command_completer): Delete declaration.
2700         (info_print_args_help): Add extra parameter, extend header
2701         comment.
2702         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2703         search_symbols.
2704         * stack.c (struct info_print_options): New type.
2705         (info_print_options_defs): New file scoped variable.
2706         (make_info_print_options_def_group): New static function.
2707         (info_print_command_completer): New static function.
2708         (info_locals_command): Update to use new local functions.
2709         (info_args_command): Likewise.
2710         (_initialize_stack): Add extra parameter to calls to
2711         info_print_args_help.
2712         * symtab.c (search_symbols): Add extra parameter, use this to
2713         possibly excluse non-debug symbols.
2714         (symtab_symbol_info): Add extra parameter, which is passed on to
2715         search_symbols.
2716         (struct info_print_options): New type.
2717         (info_print_options_defs): New file scoped variable.
2718         (make_info_print_options_def_group): New static function.
2719         (info_print_command_completer): New static function.
2720         (info_variables_command): Update to use local functions, and pass
2721         extra parameter through to symtab_symbol_info.
2722         (info_functions_command): Likewise.
2723         (info_types_command): Pass additional argument through to
2724         symtab_symbol_info.
2725         (rbreak_command): Pass extra argument to search_symbols.
2726         (_initialize_symtab): Add extra arguments for calls to
2727         info_print_args_help, and update help text for 'info variables',
2728         'whereis', and 'info functions' commands.
2729         * symtab.h (search_symbols): Add extra argument to declaration.
2730         * NEWS: Mention new flags.
2731
2732 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2733
2734         * symtab.c (lookup_static_symbol): Call the new function (and move
2735         it down to be next to lookup_global_symbol).
2736         (struct global_sym_lookup_data): Add block_enum member and rename to...
2737         (struct global_or_static_sym_lookup_data): ...this.
2738         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2739         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2740         (lookup_symbol_global_or_static_iterator_cb): ...this.
2741         (lookup_global_or_static_symbol): New function.
2742         (lookup_global_symbol): Call new function.
2743
2744 2019-08-26  Tom de Vries  <tdevries@suse.de>
2745
2746         PR c++/24852
2747         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2748         when pc_probe.prob == NULL.
2749
2750 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2751
2752         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2753         variable symbol_linkage to symbol_linkage_.
2754
2755 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2756
2757         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2758         represent whether the symbol is static, dynamic, or we don't
2759         know.
2760
2761 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2762
2763         * gdb/rx-tdep.c (rx_register_names): New.
2764         (rx_register_name): Delete.
2765         (rx_psw_type): Delete.
2766         (rx_fpsw_type): Delete.
2767         (rx_register_type): Delete.
2768         (rx_gdbarch_init): Convert target-descriptions.
2769         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2770         * gdb/features/Makefile: Add rx.xml.
2771         * gdb/features/rx.xml: New.
2772         * gdb/features/rx.c: Generated.
2773         * gdb/NEWS: Mention target description support.
2774
2775 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2776
2777         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2778         *slot_ptr.
2779
2780 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2781
2782         * configure.ac: Don't check for 'dlfcn.h' (moved to
2783         gdbsupport/common.m4).
2784         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2785         'gdbsupport/'.
2786         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2787         * compile/compile-c-support.c: Include
2788         'gdbsupport/gdb-dlfcn.h'.
2789         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2790         * gdb-dlfcn.c: Move to...
2791         * gdbsupport/gdb-dlfcn.c: ... here.
2792         * gdb-dlfcn.h: Move to...
2793         * gdbsupport/gdb-dlfcn.h: ... here.
2794
2795 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2796
2797         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2798         the offset field signed.
2799
2800 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2801
2802         * python/lib/gdb/__init__.py (_execute_file): New function.
2803         * python/python.c (python_run_simple_file): Call gdb._execute_file
2804         on Windows.
2805
2806 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2809         all uses as this was never set to anything but a zero value.
2810
2811 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2812
2813         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2814
2815 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2816
2817         * tui/tui-data.h (tui_gen_win_info): Add an =default
2818         move constructor, required by some GCC versions.
2819
2820 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2821
2822         * go32-nat.c (go32_sysinfo): Add hygon_p.
2823
2824 2019-08-20  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2827         line_from_reg_element_no, first_reg_element_no_inline,
2828         display_all_data, delete_data_content_windows,
2829         erase_data_content>: Now private.
2830
2831 2019-08-20  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2834         (tui_unhighlight_win, tui_highlight_win)
2835         (tui_win_info::make_window): Update.
2836         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2837
2838 2019-08-20  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2841         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2842         (MAX_PID_WIDTH): Move to tui-stack.c.
2843         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2844         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2845         (MAX_PID_WIDTH): Move from tui-data.h.
2846
2847 2019-08-20  Tom Tromey  <tom@tromey.com>
2848
2849         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2850         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2851         (box_win): Update.
2852         (tui_gen_win_info::make_window): Rename from tui_make_window.
2853         (tui_win_info::make_window): New method.
2854         (tui_gen_win_info::make_visible): Update.
2855         * tui/tui-source.c (tui_source_window::set_contents): Update.
2856         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2857         (tui_data_window::display_registers_from): Update.
2858         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2859         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2860         Declare.
2861         <can_box>: Remove.
2862         <title>: Remove.
2863         (struct tui_win_info) <make_window>: Declare.
2864         <can_box>: Now virtual.
2865         <title>: New member.
2866         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2867         * tui/tui-command.c (tui_cmd_window::resize): Update.
2868
2869 2019-08-20  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2872         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2873         (tui_data_window::check_register_values): Update.
2874
2875 2019-08-20  Tom Tromey  <tom@tromey.com>
2876
2877         * tui/tui-regs.h (struct tui_data_window): Use
2878         DISABLE_COPY_AND_ASSIGN.
2879         <regs_content>: Change type, removing unique_ptr.
2880         <tui_data_window>: Add move constructor.
2881         * tui/tui-regs.c (tui_data_window::show_registers)
2882         (tui_data_window::show_register_group)
2883         (tui_data_window::display_registers_from)
2884         (tui_data_window::display_registers_from)
2885         (tui_data_window::first_data_item_displayed)
2886         (tui_data_window::delete_data_content_windows)
2887         (tui_data_window::rerender, tui_data_window::refresh_window)
2888         (tui_data_window::check_register_values): Update.
2889
2890 2019-08-20  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2893         show_register_group>: Declare.
2894         (tui_show_register_group): Don't declare.
2895         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2896         tui_show_registers.
2897         (tui_data_window::show_register_group): Rename from
2898         tui_show_register_group.
2899         (tui_data_window::check_register_values, tui_reg_command):
2900         Update.
2901         * tui/tui-layout.c (tui_set_layout): Update.
2902
2903 2019-08-20  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2906         Declare.
2907         (tui_check_register_values): Don't declare.
2908         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2909         from tui_check_register_values.
2910         * tui/tui-hooks.c (tui_register_changed): Update.
2911
2912 2019-08-20  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-regs.c (tui_reg_layout): Move later.
2915         (tui_show_registers): Don't enable TUI mode or change layout.
2916
2917 2019-08-20  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui-regs.h (struct tui_data_item_window)
2920         <~tui_data_item_window>: Remove.
2921         <content>: Now a unique_xmalloc_ptr.
2922         * tui/tui-regs.c (tui_register_format): Return a
2923         unique_xmalloc_ptr.
2924         (tui_get_register): Update.
2925         (~tui_data_item_window): Remove.
2926         (tui_data_window::display_registers_from, tui_display_register):
2927         Update.
2928         * tui/tui-io.h (tui_expand_tabs): Update.
2929         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2930         Remove "col" parameter.
2931
2932 2019-08-20  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2935         field.
2936         * tui/tui-regs.c (~tui_data_item_window): Update.
2937
2938 2019-08-20  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2941         earlier.
2942
2943 2019-08-20  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2946
2947 2019-08-20  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-source.h (struct tui_source_window): Update.
2950         * tui/tui-regs.c (tui_show_registers): Update.
2951         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2952         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2953         (NO_REGS_STRING): Remove defines.
2954
2955 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2956
2957         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2958         unnecessary thread walk if remote doesn't support the packet.
2959
2960 2019-08-19  Tom Tromey  <tromey@adacore.com>
2961
2962         * python/py-value.c (value_has_field): Fix indentation.
2963
2964 2019-08-19  Tom Tromey  <tromey@adacore.com>
2965
2966         * printcmd.c (do_one_display, info_display_command): Update.
2967         * block.h (contained_in): Return bool.  Add allow_nested
2968         parameter.
2969         * block.c (contained_in): Return bool.  Add allow_nested
2970         parameter.
2971
2972 2019-08-19  Tom Tromey  <tom@tromey.com>
2973
2974         * configure: Rebuild.
2975         * configure.ac: Disallow the combination of -static-libstdc++ and
2976         source highlight.
2977         * source-cache.c (get_language_name): Handle rust.
2978         (source_cache::get_source_lines): Ignore highlighting exceptions.
2979
2980 2019-08-16  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2983         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2984         (struct tui_source_window_base) <make_visible, refresh_window,
2985         resize>: Remove methods.
2986         <execution_info>: Remove field.
2987         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2988         (tui_show_source_line, tui_source_window_base)
2989         (~tui_source_window_base): Update.
2990         (tui_source_window_base::resize)
2991         (tui_source_window_base::make_visible)
2992         (tui_source_window_base::refresh_window): Remove.
2993         (tui_source_window_base::update_exec_info): Update.
2994         * tui/tui-source.c (tui_source_window::set_contents): Update.
2995         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2996
2997 2019-08-16  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3000         deprecated_query_hook.
3001
3002 2019-08-16  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3005         (tui_update_source_windows_with_line): Update.
3006         * tui/tui-source.h (struct tui_source_window)
3007         <show_symtab_source>: Declare.
3008         (tui_show_symtab_source): Don't declare.
3009         * tui/tui-source.c (tui_show_symtab_source): Rename from
3010         tui_show_symtab_source.
3011
3012 2019-08-16  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-winsource.h (struct tui_source_window_base)
3015         <set_contents>: Declare.
3016         * tui/tui-winsource.c
3017         (tui_source_window_base::update_source_window_as_is): Update.
3018         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3019         Declare.
3020         (tui_set_source_content): Don't declare.
3021         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3022         tui_set_source_content.
3023         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3024         Declare.
3025         (tui_set_disassem_content): Don't declare.
3026         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3027         tui_set_disassem_content.
3028
3029 2019-08-16  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-winsource.h (struct tui_source_window_base)
3032         <update_breakpoint_info>: Declare.
3033         (tui_update_breakpoint_info): Don't declare.
3034         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3035         (tui_update_all_breakpoint_info): Update.
3036         (tui_source_window_base::update_breakpoint_info): Rename from
3037         tui_update_breakpoint_info.
3038         (tui_source_window_base::update_exec_info): Update.
3039
3040 2019-08-16  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-winsource.h (struct tui_source_window_base)
3043         <update_source_window>: Declare.
3044         (tui_update_source_window): Don't declare.
3045         * tui/tui-winsource.c
3046         (tui_source_window_base::update_source_window): Rename from
3047         tui_update_source_window.
3048         (tui_source_window_base::rerender): Update.
3049         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3050         * tui/tui-disasm.c (tui_show_disassem)
3051         (tui_show_disassem_and_update_source)
3052         (tui_disasm_window::maybe_update): Update.
3053
3054 2019-08-16  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-winsource.h (struct tui_source_window_base)
3057         <update_source_window_as_is>: Declare.
3058         (tui_update_source_window_as_is): Don't declare.
3059         * tui/tui-winsource.c (tui_update_source_window): Update
3060         (tui_source_window_base::update_source_window_as_is): Rename from
3061         tui_update_source_window_as_is.
3062         (tui_source_window_base::refill): Update.
3063         * tui/tui-source.c (tui_show_symtab_source): Update.
3064         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3065         Update.
3066
3067 2019-08-16  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-winsource.h (tui_update_source_window)
3070         (tui_update_source_window_as_is): Remove "noerror" parameter.
3071         * tui/tui-winsource.c (tui_update_source_window)
3072         (tui_update_source_window_as_is): Remove "noerror" parameter.
3073         (tui_update_source_windows_with_addr)
3074         (tui_update_source_windows_with_line)
3075         (tui_source_window_base::rerender)
3076         (tui_source_window_base::refill): Update.
3077         * tui/tui-source.h (tui_set_source_content)
3078         (tui_show_symtab_source): Remove "noerror" parameter.
3079         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3080         parameter.
3081         (tui_show_symtab_source): Likewise.
3082         (tui_source_window::maybe_update): Update.
3083         * tui/tui-disasm.c (tui_show_disassem)
3084         (tui_show_disassem_and_update_source)
3085         (tui_disasm_window::do_scroll_vertical)
3086         (tui_disasm_window::maybe_update): Update.
3087
3088 2019-08-16  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui.c (tui_is_window_visible): Update.
3091         * tui/tui-wingeneral.c (tui_make_window)
3092         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3093         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3094         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3095         (tui_set_win_height_command, parse_scrolling_args): Update.
3096         * tui/tui-source.c (tui_source_window::style_changed): Update.
3097         * tui/tui-regs.c (tui_show_registers)
3098         (tui_data_window::first_data_item_displayed)
3099         (tui_data_window::delete_data_content_windows)
3100         (tui_check_register_values, tui_reg_command): Update.
3101         * tui/tui-disasm.c (tui_show_disassem): Update.
3102         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3103         method.
3104         <is_visible>: Remove field.
3105         * tui/tui-data.c (tui_next_win, tui_prev_win)
3106         (tui_delete_invisible_windows): Update.
3107
3108 2019-08-16  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-winsource.h (struct tui_source_window_base)
3111         <m_has_locator>: Remove.
3112         * tui/tui-layout.c (show_source_disasm_command, show_data)
3113         (show_source_or_disasm_and_command): Update.
3114
3115 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3116
3117         * NEWS (Other MI changes): New subsection.
3118         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3119         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3120         * arch-utils.c (default_get_pc_address_flags): New function.
3121         * arch-utils.h (default_get_pc_address_flags): New declaration.
3122         * gdbarch.sh: Add get_pc_address_flags.
3123         * gdbarch.c: Regenerate.
3124         * gdbarch.h: Likewise.
3125         * stack.c (print_pc): New function.
3126         (print_frame_info) (print_frame): Call print_pc.
3127
3128 2019-08-16  Tom de Vries  <tdevries@suse.de>
3129
3130         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3131         print_objfile_section_info.
3132
3133 2019-08-15  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3136         calling update_cmdwin_start_line.
3137         * tui/tui-winsource.h (struct tui_source_window_base)
3138         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3139         <rerender>: Declare.
3140         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3141         Call rerender.
3142         (tui_source_window_base::set_new_height): Remove.
3143         (tui_source_window_base::rerender): Rename from
3144         do_make_visible_with_new_height.
3145         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3146         resize method.
3147         (tui_win_info::make_invisible_and_set_new_height)
3148         (tui_win_info::make_visible_with_new_height): Remove.
3149         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3150         Declare.
3151         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3152         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3153         do_make_visible_with_new_height>: Don't declare.
3154         <rerender>: Declare.
3155         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3156         set_new_height.
3157         (tui_data_window::do_make_visible_with_new_height): Remove.
3158         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3159         call tui_show_locator_content.
3160         (tui_gen_win_info::resize): Call rerender.
3161         (show_source_or_disasm_and_command): Don't call
3162         tui_show_locator_content.
3163         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3164         method.
3165         (struct tui_win_info) <rerender>: Declare.
3166         <set_new_height, make_invisible_and_set_new_height,
3167         make_visible_with_new_height>: Don't declare.
3168         * tui/tui-data.c (tui_win_list::rerender): New method.
3169         * tui/tui-command.h (struct tui_cmd_window)
3170         <do_make_visible_with_new_height>: Don't declare.
3171         * tui/tui-command.c
3172         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3173
3174 2019-08-15  Tom Tromey  <tromey@adacore.com>
3175
3176         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3177         * ada-lang.c (ada_enum_name): Likewise.
3178
3179 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3180
3181         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3182         leading underscore.
3183         (GdbOutputErrorFile): Likewise.
3184         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3185         accordingly.
3186         (execute_unwinders): Rename to have a leading underscore.
3187         (auto_load_packages): Likewise.
3188         (global scope): Adjust call to auto_load_packages accordingly.
3189         (GdbSetPythonDirectory): Likewise.
3190         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3191         instead of execute_unwinders.
3192
3193 2019-08-15  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3196         (show_data): Don't change window visibility.
3197         (tui_gen_win_info::resize): Remove special case for command
3198         window.  Use wresize, when available.
3199         (show_source_or_disasm_and_command): Don't change window
3200         visibility.
3201         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3202         <make_visible>: New method.
3203         * tui/tui-command.c (tui_cmd_window::resize): New method.
3204
3205 2019-08-15  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3208         (struct tui_source_windows): New.
3209         * tui/tui-winsource.c (tui_display_main): Update.
3210         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3211         (new_height_ok, parse_scrolling_args): Update.
3212         * tui/tui-layout.c (show_layout, show_data): Update.
3213         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3214         (tui_add_to_source_windows): Don't declare.
3215         * tui/tui-data.c (source_windows, tui_source_windows)
3216         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3217
3218 2019-08-15  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3221         Rename from reset.
3222         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3223         * tui/tui-layout.c (show_source_disasm_command, show_data):
3224         Update.
3225         (tui_gen_win_info::resize): Rename.
3226         (show_source_or_disasm_and_command): Update.
3227         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3228         reset.
3229
3230 2019-08-15  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3233         * tui/tui-interp.c (tui_interp::init): Don't call
3234         tui_initialize_static_data.
3235         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3236
3237 2019-08-15  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3240         examine tui_win_list.
3241
3242 2019-08-15  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3245         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3246         tui_clear_source_content.
3247         (tui_clear_source_content): Remove.
3248         (tui_source_window_base::do_erase_source_content): Hoist call to
3249         content.clear().
3250         * tui/tui-stack.c (tui_show_frame_info): Don't call
3251         tui_clear_source_content.
3252
3253 2019-08-15  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-winsource.h (struct tui_source_window_base)
3256         <do_erase_source_content>: New method.
3257         <erase_source_content>: New method.
3258         (tui_erase_source_content): Don't declare.
3259         * tui/tui-winsource.c (tui_clear_source_content): Update.
3260         (tui_source_window_base::do_erase_source_content): Rename from
3261         tui_erase_source_content.
3262         (tui_source_window_base::show_source_content): Update.
3263         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3264         * tui/tui-source.h (struct tui_source_window)
3265         <erase_source_content>: New method.
3266         * tui/tui-disasm.h (struct tui_disasm_window)
3267         <erase_source_content>: New method.
3268
3269 2019-08-15  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3272         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3273         constructor.
3274         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3275         * tui/tui-source.c (tui_set_source_content): Update.
3276         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3277
3278 2019-08-15  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3281         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3282         tui-source.c.
3283         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3284         Declare.
3285         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3286         method.
3287         (tui_source_window::maybe_update): Update.
3288
3289 2019-08-15  Tom Tromey  <tom@tromey.com>
3290
3291         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3292         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3293         tui-disasm.c.
3294         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3295         Declare.
3296         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3297         method.
3298         (tui_disasm_window::maybe_update): Update.
3299
3300 2019-08-15  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-winsource.h (struct tui_source_window_base)
3303         <maybe_update>: Declare.
3304         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3305         method.
3306         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3307         Declare.
3308         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3309         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3310         Declare.
3311         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3312
3313 2019-08-15  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3316
3317 2019-08-15  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-wingeneral.c: Include tui-stack.h.
3320         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3321         (struct tui_locator_window): Move from tui-data.h.
3322         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3323         (tui_initialize_static_data): Move from tui-data.c.
3324         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3325         (struct tui_locator_window): Move to tui-stack.c.
3326         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3327         (tui_initialize_static_data): Move to tui-stack.c.
3328
3329 2019-08-15  Tom Tromey  <tom@tromey.com>
3330
3331         * tui/tui-layout.c (show_source_disasm_command)
3332         (show_source_or_disasm_and_command): Use make_visible method, not
3333         tui_make_window.
3334         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3335         Remove.
3336
3337 2019-08-15  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-wingeneral.h (tui_make_window): Update.
3340         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3341         parameter.
3342         (tui_gen_win_info::make_visible): Update.
3343         * tui/tui-regs.c (tui_data_window::display_registers_from):
3344         Update.
3345         * tui/tui-layout.c (show_source_disasm_command)
3346         (show_source_or_disasm_and_command): Update.
3347         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3348         (enum tui_box): Remove.
3349         (struct tui_win_info) <can_box>: New method.
3350         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3351         method.
3352
3353 2019-08-15  Tom de Vries  <tdevries@suse.de>
3354
3355         * linux-nat-trad.c: Include gdbarch.h.
3356
3357 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3358
3359         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3360         register sizes.
3361
3362 2019-08-14  Tom Tromey  <tromey@adacore.com>
3363
3364         * darwin-nat.c: Include gdbarch.h.
3365         * darwin-nat-info.c: Include gdbarch.h.
3366
3367 2019-08-13  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3370         Remove.
3371         * tui/tui-data.c (tui_initialize_static_data): Update.
3372
3373 2019-08-13  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-winsource.h (struct tui_exec_info_window)
3376         <~tui_exec_info_window, maybe_allocate_content, get_content,
3377         m_content>: Remove.
3378         (struct tui_source_window_base) <set_exec_info_content,
3379         show_exec_info_content>: Don't declare.
3380         * tui/tui-winsource.c
3381         (tui_exec_info_window::maybe_allocate_content): Remove.
3382         (tui_source_window_base::update_exec_info): Rename from
3383         set_exec_info_content.
3384         (tui_source_window_base::show_exec_info_content)
3385         (tui_source_window_base::update_exec_info): Remove.
3386
3387 2019-08-13  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3390         declare.
3391         * tui/tui-winsource.c (tui_update_source_window_as_is)
3392         (tui_update_source_windows_with_addr, tui_erase_source_content):
3393         Update.
3394         (tui_clear_exec_info_content): Remove.
3395
3396 2019-08-13  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3399         declare.
3400         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3401         call tui_erase_exec_info_content.
3402         (tui_clear_exec_info_content): Rename from
3403         tui_erase_exec_info_content.
3404         (tui_clear_exec_info_content): Delete.
3405
3406 2019-08-13  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui-winsource.h (struct tui_source_window_base)
3409         <show_exec_info_content>: Declare.
3410         (tui_show_exec_info_content): Don't declare.
3411         * tui/tui-winsource.c
3412         (tui_source_window_base::show_exec_info_content): Rename from
3413         tui_show_exec_info_content.
3414         (tui_source_window_base::update_exec_info): Update.
3415
3416 2019-08-13  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3419         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3420         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3421         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3422         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3423         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3424         ... here.
3425
3426 2019-08-13  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-winsource.h (struct tui_source_window_base)
3429         <update_exec_info>: Declare.
3430         (tui_update_exec_info): Don't declare.
3431         * tui/tui-winsource.c (tui_update_source_window_as_is)
3432         (tui_source_window_base::refresh_all)
3433         (tui_update_all_breakpoint_info): Update.
3434         (tui_source_window_base::update_exec_info): Rename from
3435         tui_update_exec_info.
3436         * tui/tui-stack.c (tui_show_frame_info): Update.
3437
3438 2019-08-13  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-winsource.h (struct tui_source_window_base)
3441         <set_exec_info_content>: Declare.
3442         (tui_set_exec_info_content): Don't declare.
3443         * tui/tui-winsource.c
3444         (tui_source_window_base::set_exec_info_content): Rename from
3445         tui_set_exec_info_content.
3446         (tui_update_exec_info): Update.
3447
3448 2019-08-13  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-winsource.h (struct tui_source_window_base)
3451         <show_source_content>: Declare.
3452         (tui_show_source_content): Don't declare.
3453         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3454         (tui_source_window_base::show_source_content): Rename from
3455         tui_show_source_content.
3456         (tui_source_window_base::refresh_all): Update.
3457         * tui/tui-layout.c (show_source_disasm_command)
3458         (show_source_or_disasm_and_command): Update.
3459
3460 2019-08-13  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-winsource.c (tui_erase_source_content)
3463         (tui_show_source_content, tui_source_window_base::refresh_all):
3464         Update.
3465         * tui/tui-wingeneral.h
3466         (tui_check_and_display_highlight_if_needed): Don't declare.
3467         * tui/tui-wingeneral.c
3468         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3469         check_and_display_highlight_if_needed.
3470         * tui/tui-win.c (tui_rehighlight_all)
3471         (tui_win_info::make_visible_with_new_height): Update.
3472         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3473         (tui_data_window::erase_data_content)
3474         (tui_data_window::display_all_data): Update.
3475         * tui/tui-data.h (struct tui_win_info)
3476         <check_and_display_highlight_if_needed>: Declare.
3477
3478 2019-08-13  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui-win.c (tui_resize_all): Call
3481         tui_delete_invisible_windows.
3482         * tui/tui-layout.c (show_layout): Call
3483         tui_delete_invisible_windows.
3484         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3485         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3486
3487 2019-08-13  Tom Tromey  <tom@tromey.com>
3488
3489         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3490         tui_add_win_to_layout.
3491
3492 2019-08-13  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3495         * tui/tui-layout.c (tui_default_win_height): Now static.
3496
3497 2019-08-13  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3500         single switch.
3501         (show_source_disasm_command, show_source_or_disasm_and_command):
3502         Don't check current layout.
3503
3504 2019-08-13  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-wingeneral.c (make_all_visible): Remove.
3507         (tui_make_all_invisible): Simplify.
3508         * tui/tui-layout.c (tui_make_all_invisible): Move from
3509         tui-wingeneral.c; simplify.
3510         (show_layout): Hoist call to tui_make_all_invisible.
3511         (show_data): Don't call tui_make_all_invisible.
3512
3513 2019-08-13  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3516         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3517
3518 2019-08-13  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3521         tui-data.c.
3522         (show_source_disasm_command, show_data)
3523         (show_source_or_disasm_and_command): Don't use
3524         tui_set_current_layout_to.
3525         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3526         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3527         tui-layout.c.
3528         (tui_set_current_layout_to): Remove.
3529
3530 2019-08-13  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-layout.c (tui_set_layout): Update.
3533         * tui/tui-data.h (struct tui_layout_def): Remove.
3534         (tui_layout_def): Don't declare.
3535         * tui/tui-data.c (layout_def): Remove.
3536         (tui_layout_def): Remove.
3537
3538 2019-08-13  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-winsource.h (struct tui_source_window_base)
3541         <clear_detail>: No longer "override".
3542         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3543         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3544         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3545         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3546         Remove.
3547         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3548
3549 2019-08-13  Tom Tromey  <tromey@adacore.com>
3550
3551         * tracepoint.c: Don't include readline.h or history.h.
3552
3553 2019-08-12  Tom Tromey  <tom@tromey.com>
3554
3555         * configure: Rebuild.
3556         * configure.ac: Check for readline 7.
3557         * NEWS: Mention readline 7 requirement.
3558         * README: Update.
3559
3560 2019-08-12  Tom Tromey  <tom@tromey.com>
3561
3562         * mingw-hdep.c (gdb_select): Remove readline hack.
3563
3564 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3565
3566         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3567         when the function fails.
3568
3569 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3570
3571         * s390-tdep.c (s390_type_align): New function.
3572         (s390_gdbarch_init): Set it as type_align gdbarch method.
3573
3574 2019-08-09  Tom de Vries  <tdevries@suse.de>
3575
3576         PR gdb/24591
3577         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3578         pc_low with relocation offset.
3579
3580 2019-08-07  Tom Tromey  <tromey@adacore.com>
3581
3582         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3583         (print_frame_args): Update.
3584         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3585         Update.
3586         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3587         * frame.h (struct frame_arg): Add initializers.
3588         <error>: Now a unique_xmalloc_ptr.
3589
3590 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3591
3592         * NEWS: Expand the Pointer Authentication entry.
3593         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3594         (aarch64_frame_unmask_lr): ... to this.
3595         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3596         Call aarch64_frame_unmask_lr.
3597         * frame.c (struct frame_info): Add "masked" variable.
3598         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3599         (fprint_frame): Check for masked pc.
3600         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3601         declarations.
3602         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3603         * stack.c (print_frame): Check for masked pc.
3604
3605 2019-08-06  Tom Tromey  <tom@tromey.com>
3606
3607         * stabsread.c (patch_block_stabs, read_one_struct_field)
3608         (read_enum_type): Use obstack_strndup.
3609         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3610         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3611         * dwarf2read.c (guess_full_die_structure_name)
3612         (anonymous_struct_prefix): Use obstack_strndup.
3613         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3614         * c-exp.y (yylex): Use obstack_strndup.
3615         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3616         (write_var_or_type): Use obstack_strndup.
3617
3618 2019-08-06  Tom Tromey  <tom@tromey.com>
3619
3620         * symfile.c (reread_symbols): Use obstack_strdup.
3621         * stabsread.c (read_type): Use obstack_strdup.
3622         * gdb_obstack.h (obstack_strdup): New overload.
3623         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3624         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3625         (dwarf2_canonicalize_name): Use obstack_strdup.
3626         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3627         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3628         Use obstack_strdup.
3629
3630 2019-08-06  Tom Tromey  <tom@tromey.com>
3631
3632         * gdb_obstack.h (obstack_strdup): Define.
3633         * gdb_obstack.c (obstack_strdup): Don't define.
3634
3635 2019-08-06  Tom Tromey  <tom@tromey.com>
3636
3637         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3638         obstack_strdup.
3639         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3640         obstack_strdup.
3641         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3642         * stabsread.c (common_block_start): Use obstack_strdup.
3643         * objfiles.c (set_objfile_main_name, objfile): Use
3644         obstack_strdup.
3645         * namespace.c (add_using_directive): Use obstack_strdup.
3646         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3647         * jit.c (finalize_symtab): Use obstack_strdup.
3648         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3649         (guess_partial_die_structure_name, partial_die_info::fixup)
3650         (dwarf2_name): Use obstack_strdup.
3651         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3652         obstack_strdup.
3653         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3654         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3655         obstack_strdup.
3656         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3657
3658 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3659
3660         * unittests/help-doc-selftests.c: New file.
3661         * Makefile.in: Add the new file.
3662
3663 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3664
3665         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3666         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3667         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3668         the trailing '.' is not output, and the first character is uppercased.
3669         (print_help_for_command): Update call to print_doc_line.
3670         (print_doc_of_command): Likewise.
3671         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3672         * cli/cli-option.c (append_indented_doc): Do not append newline.
3673         (build_help_option): Append newline after first appended_indented_doc
3674         only if a second call is done.
3675         (build_help): Append 2 new lines before each option, except the first
3676         one.
3677         * compile/compile.c (_initialize_compile): Add new lines after
3678         %OPTIONS%, when not at the end of the help.
3679         Change help doc or code
3680         producing the help doc to respect the invariants.
3681         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3682         Also removed the new line after 'Options:', as all other commands
3683         do not put an empty line between 'Options:' and the first option.
3684         * printcmd.c (_initialize_printcmd): Likewise.
3685         * stack.c (_initialize_stack): Likewise.
3686         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3687         incorrectly telling COMMAND is optional.
3688         * ada-lang.c (_initialize_ada_language): Change help doc or code
3689         producing the help doc to respect the invariants.
3690         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3691         * breakpoint.c (_initialize_breakpoint): Likewise.
3692         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3693         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3694         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3695         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3696         _initialize_cli_style): Likewise.
3697         * corelow.c (core_target_info): Likewise.
3698         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3699         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3700         * filesystem.c (_initialize_filesystem): Likewise.
3701         * frame.c (_initialize_frame): Likewise.
3702         * gnu-nat.c (add_task_commands): Likewise.
3703         * infcall.c (_initialize_infcall): Likewise.
3704         * infcmd.c (_initialize_infcmd): Likewise.
3705         * interps.c (_initialize_interpreter): Likewise.
3706         * language.c (_initialize_language): Likewise.
3707         * linux-fork.c (_initialize_linux_fork): Likewise.
3708         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3709         * maint.c (_initialize_maint_cmds): Likewise.
3710         * memattr.c (_initialize_mem): Likewise.
3711         * printcmd.c (_initialize_printcmd): Likewise.
3712         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3713         _RegEx): Likewise.
3714         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3715         * record-btrace.c (_initialize_record_btrace): Likewise.
3716         * record-full.c (_initialize_record_full): Likewise.
3717         * record.c (_initialize_record): Likewise.
3718         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3719         * regcache.c (_initialize_regcache): Likewise.
3720         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3721         _initialize_remote): Likewise.
3722         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3723         * serial.c (_initialize_serial): Likewise.
3724         * skip.c (_initialize_step_skip): Likewise.
3725         * source.c (_initialize_source): Likewise.
3726         * stack.c (_initialize_stack): Likewise.
3727         * symfile.c (_initialize_symfile): Likewise.
3728         * symtab.c (_initialize_symtab): Likewise.
3729         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3730         * top.c (init_main): Likewise.
3731         * tracefile-tfile.c (tfile_target_info): Likewise.
3732         * tracepoint.c (_initialize_tracepoint): Likewise.
3733         * tui/tui-win.c (_initialize_tui_win): Likewise.
3734         * utils.c (add_internal_problem_command): Likewise.
3735         * valprint.c (value_print_option_defs): Likewise.
3736
3737 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3738
3739         PR build/24886
3740         * configure.ac: Drop enable-libmcheck support.
3741         * configure, config.in: Rebuild.
3742         * libmcheck.m4: Remove.
3743         * acinclude.m4: Don't include it.
3744         * Makefile.in: Don't distribute it.
3745         * top.c (print_gdb_configuration): Don't mention it.
3746
3747 2019-08-06  Tom Tromey  <tom@tromey.com>
3748
3749         * utils.c (set_output_style): Sometimes pass stream to
3750         emit_style_escape.
3751         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3752         * record-btrace.c (btrace_insn_history): Update.
3753         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3754         method.
3755         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3756         Update initializers.
3757         <m_uiout>: New field.
3758         <m_di>: Move lower.
3759         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3760         Remove "uiout" parameter.
3761         (dump_insns): Update.
3762         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3763         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3764
3765 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3766
3767         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3768         (error_in_psymtab_expansion): Likewise.
3769         (lookup_symbol_via_quick_fns): Likewise.
3770         (basic_lookup_transparent_type_quick): Likewise.
3771         (basic_lookup_transparent_type_1): Likewise.
3772
3773 2019-08-06  Tom Tromey  <tromey@adacore.com>
3774
3775         * source.c (last_source_error): Now bool.
3776         (print_source_lines_base): Make "noprint" bool.  Only open
3777         source file when last_source_visited changes.
3778
3779 2019-08-06  Tom Tromey  <tromey@adacore.com>
3780
3781         * annotate.c (annotate_source_line): Use g_source_cache.
3782         * source-cache.c (source_cache::get_plain_source_lines): Change
3783         parameters.  Populate m_offset_cache.
3784         (source_cache::ensure): New method.
3785         (source_cache::get_line_charpos): New method.
3786         (extract_lines): Move lower.  Change parameters.
3787         (source_cache::get_source_lines): Move lower.
3788         * source-cache.h (class source_cache): Update comment.
3789         <get_line_charpos>: New method.
3790         <get_source_lines>: Update comment.
3791         <clear>: Clear m_offset_cache.
3792         <get_plain_source_lines>: Change parameters.
3793         <ensure>: New method
3794         <m_offset_cache>: New member.
3795         * source.c (forget_cached_source_info_for_objfile): Update.
3796         (info_source_command): Use g_source_cache.
3797         (find_source_lines, open_source_file_with_line_charpos): Remove.
3798         (print_source_lines_base, search_command_helper): Use g_source_cache.
3799         * source.h (open_source_file_with_line_charpos): Don't declare.
3800         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3801         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3802         Use g_source_cache.
3803
3804 2019-08-06  Tom Tromey  <tromey@adacore.com>
3805
3806         * source-cache.c (source_cache::get_plain_source_lines):
3807         Remove "first_line" and "last_line" parameters.
3808         (source_cache::get_source_lines): Cache plain text.
3809         * source-cache.h (class source_cache)
3810         <get_plain_source_lines>: Update.
3811
3812 2019-08-06  Tom Tromey  <tromey@adacore.com>
3813
3814         * source-cache.c (extract_lines): No longer a method.
3815         Changed type of parameter.  Include final newline.
3816         (selftests::extract_lines_test): New function.
3817         (_initialize_source_cache): Likewise.
3818         * source-cache.h (class source_cache)
3819         <extract_lines>: Don't declare.
3820
3821 2019-08-06  Tom Tromey  <tromey@adacore.com>
3822
3823         * breakpoint.c (init_breakpoint_sal): Update.
3824         (breakpoint): Update.
3825         * breakpoint.h (struct breakpoint) <filter>: Now a
3826         unique_xmalloc_ptr.
3827
3828 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3829
3830         * NEWS: Mention dictionary access on blocks.
3831         * python/py-block.c (blpy_getitem): New function.
3832         (block_object_as_mapping): New struct.
3833         (block_object_type): Use new struct for tp_as_mapping field.
3834
3835 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3836
3837         * objfiles.h (objfile): Add a comment describing partial symbols.
3838
3839 2019-08-05  Tom Tromey  <tromey@adacore.com>
3840
3841         * compile/compile.c (_initialize_compile): Use _(), not N_().
3842         * thread.c (_initialize_thread): Use _(), not N_().
3843         * stack.c (_initialize_stack): Use _(), not N_().
3844         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3845
3846 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3847
3848         * dwarf2read.c (struct dw2_symtab_iterator):
3849         <want_specific_block>: Remove.
3850         <block_index>: Change type to gdb::optional.
3851         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3852         change type of BLOCK_INDEX parameter to gdb::optional.
3853         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3854         (dw2_lookup_symbol): Don't pass argument for
3855         WANT_SPECIFIC_BLOCK.
3856         (dw2_expand_symtabs_for_function): Don't pass argument for
3857         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3858         (class dw2_debug_names_iterator)
3859         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3860         parameter, change BLOCK_INDEX type to gdb::optional.
3861         <m_want_specific_block>: Remove.
3862         <m_block_index>: Change type to gdb::optional.
3863         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3864         gdb::optional.  Re-write in function of gdb::optional.
3865         (dw2_debug_names_lookup_symbol): Don't pass argument for
3866         WANT_SPECIFIC_BLOCK.
3867         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3868         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3869         BLOCK_INDEX.
3870
3871 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3872
3873         * NEWS: Mention changes to "info sources" command.
3874
3875 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3876
3877         * symtab.c (filename_partial_match_opts): New struct type.
3878         (struct output_source_filename_data): New members
3879         regexp, c_regexp, partial_match.
3880         (output_source_filename): Use new members to decide to print file.
3881         (info_sources_option_defs): New variable.
3882         (make_info_sources_options_def_group, print_info_sources_header,
3883         info_sources_command_completer):
3884         New functions.
3885         (info_sources_command): Read new optional arguments.
3886         (_initialize_symtab): Update info sources help.
3887
3888 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3889
3890         * ada-lang.c (exception_support_info_v0): Renamed from...
3891         (default_exception_support_info): ... this.  Create new
3892         definition for v1.
3893         (ada_has_this_exception_support): Look up catch_handlers_sym.
3894         (ada_exception_support_info_sniffer): Try v0 after default.
3895
3896 2019-08-01  Tom Tromey  <tromey@adacore.com>
3897
3898         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3899         gdbarch.h.
3900
3901 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3902
3903         * s12z-tdep.c: Fix include path for s12z-opc.h.
3904
3905 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3906
3907         * NEWS: Require GNU make 3.82.
3908
3909 2019-07-16  Tom Tromey  <tom@tromey.com>
3910
3911         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3912         declare.
3913
3914 2019-07-30  Tom Tromey  <tromey@adacore.com>
3915
3916         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3917
3918 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3919
3920         * printcmd.c (print_address_symbolic): Print negative offsets.
3921         (build_address_symbolic): Force signed arithmetic when computing
3922         offset.
3923
3924 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3925
3926         PR/24474: Add a function to lookup static variables.
3927         * NEWS: Mention this new function.
3928         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3929         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3930         * python/python.c (python_GdbMethods): Add new function.
3931
3932 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3933
3934         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3935         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3936         (objfpy_lookup_static_symbol): New function.
3937         (objfile_object_methods): Add new functions.
3938
3939 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3940
3941         * NEWS: Mention 'set|show print frame-info'.  Mention new
3942         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3943         backtrace argument.  Mention that python frame filtering code
3944         is now consistent with what 'backtrace' command prints.
3945
3946 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3947
3948         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3949         comments.
3950         (print_frame_info_auto, print_frame_info_source_line,
3951         print_frame_info_location, print_frame_info_source_and_location,
3952         print_frame_info_location_and_address, print_frame_info_short_location):
3953         New declarations.
3954         (struct frame_print_options): New member print_frame_info.
3955         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3956         * stack.h (get_user_print_what_frame_info): New declaration.
3957         (frame_show_address): New declaration.
3958         * stack.c (print_frame_arguments_choices): New value 'presence'.
3959         (print_frame_info_auto, print_frame_info_source_line,
3960         print_frame_info_location, print_frame_info_source_and_location,
3961         print_frame_info_location_and_address, print_frame_info_short_location,
3962         print_frame_info_choices, print_frame_info_print_what): New definitions.
3963         (print_frame_args): Only print dots for args if print frame-arguments
3964         is 'presence'.
3965         (frame_print_option_defs): New element for "frame-info".
3966         (get_user_print_what_frame_info): New function.
3967         (frame_show_address): Make non static.  Move comment to stack.h.
3968         (print_frame_info_to_print_what): New function.
3969         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3970         to decide what to print.
3971         (backtrace_command_1): Handle the new print_frame_arguments_presence
3972         value.
3973         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3974         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3975         (py_print_frame): In non-mi mode, use LOCATION as default for
3976         print_what, similarly to frame information printed directly by
3977         backtrace command. Handle frame-info user option in non MI mode.
3978
3979 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3980
3981         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3982         Add case for debugging 32-bit target on 64-bit host.  Revise
3983         comment.
3984
3985 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3986
3987         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3988         instead of find_function_entry_range_from_pc.
3989
3990 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3991
3992         * stack.c (find_frame_funname): Remove code which preferred
3993         minsym over symtab sym in "certain pathological cases".
3994
3995         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3996         parameter.  Change type of "do_demangle" to bool.
3997         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3998         Pass suitable "prefer_sym_over_minsym" flag to
3999         build_address_symbolic().  Don't output "+" for negative offsets.
4000         * printcmd.c (print_address_symbolic): Update invocation of
4001         build_address_symbolic to include a "prefer_sym_over_minsym"
4002         flag.
4003         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4004         Restrict cases in which use of minimal symbol is preferred to that
4005         of a found symbol.  Update comments.
4006
4007         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4008         for entry pc when entry pc is out of range for that FDE.
4009
4010 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4011
4012         PR gdb/24839:
4013         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4014         type.
4015
4016 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4017
4018         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4019         this function's Python signature.
4020
4021
4022 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4023
4024         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4025         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4026         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4027         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4028         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4029
4030
4031 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4032
4033         * h8300-tdep.c (h8300_register_name_common): New.
4034         h8300_register_name): Use h8300_register_name_common.
4035         (h8300s_register_name): Likewise.
4036         (h8300sx_register_name): Likewise.
4037         (h8300h_register_nam): New.
4038         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4039
4040
4041 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4042
4043         * arm-tdep.c (arm_skip_cmse_entry): New function.
4044         (arm_is_sgstubs_section): New function.
4045         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4046
4047 2019-07-22  Tom Tromey  <tom@tromey.com>
4048
4049         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4050         Don't self-assign.
4051
4052 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4055         type_print.
4056
4057 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4058
4059         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4060         so that GDB doesn't match any msymbols when searching in the
4061         TYPES_DOMAIN.
4062         (print_symbol_info): Print using typedef_print or type_print based
4063         on the type of the symbol.  Add updated FIXME comment moved from...
4064         (_initialize_symtab): ... move and update FIXME comment to above.
4065
4066 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4067
4068         * NEWS: Mention adding -q option to "info types".
4069         * symtab.c (struct info_types_options): New struct.
4070         (info_types_options_defs): New variable.
4071         (make_info_types_options_def_group): New function.
4072         (info_types_command): Use gdb::option framework to parse options.
4073         (info_types_command_completer): New function.
4074         (_initialize_symtab): Extend the help text on "info types" and
4075         register command completer.
4076
4077 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4078
4079         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4080         (lookup_symbol_in_objfile): Change int to block_enum and add a
4081         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4082
4083 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4084
4085         * MAINTAINERS (Write After Approval): Add self.
4086
4087 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4090         instruction to the dummy code region.
4091
4092 2019-07-19  Tom Tromey  <tromey@adacore.com>
4093
4094         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4095         (ARGSUSED, PARAMS, __func__): Remove rules.
4096
4097 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4098
4099         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4100         * features/arm/arm-with-iwmmxt.c: Remove.
4101         * features/arm/arm-with-iwmmxt.xml: Remove.
4102         * features/arm/arm-with-m-fpa-layout.c: Remove.
4103         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4104         * features/arm/arm-with-m-vfp-d16.c: Remove.
4105         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4106         * features/arm/arm-with-m.c: Remove.
4107         * features/arm/arm-with-m.xml: Remove.
4108         * features/arm/arm-with-neon.c: Remove.
4109         * features/arm/arm-with-neon.xml: Remove.
4110         * features/arm/arm-with-vfpv2.c: Remove.
4111         * features/arm/arm-with-vfpv2.xml: Remove.
4112         * features/arm/arm-with-vfpv3.c: Remove.
4113         * features/arm/arm-with-vfpv3.xml: Remove.
4114
4115 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4116
4117         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4118
4119 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4120
4121         * arch/aarch32.c (aarch32_create_target_description): Create
4122         target descriptions using features.
4123         * arch/arm.c (arm_create_target_description)
4124         (arm_create_mprofile_target_description): Likewise.
4125         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4126
4127 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4128
4129         * Makefile.in: Add new files.
4130         * aarch32-tdep.c: New file.
4131         * aarch32-tdep.h: New file.
4132         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4133         Call aarch32_read_description.
4134         * arch/aarch32.c: New file.
4135         * arch/aarch32.h: New file.
4136         * arch/arm.c (arm_create_target_description)
4137         (arm_create_mprofile_target_description): New function.
4138         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4139         (arm_create_target_description)
4140         (arm_create_mprofile_target_description): New declaration.
4141         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4142         read_description functions.
4143         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4144         Likewise.
4145         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4146         * arm-tdep.c (tdesc_arm_list): New variable.
4147         (arm_register_g_packet_guesses): Call create description functions.
4148         (arm_read_description) (arm_read_mprofile_description): New
4149         function.
4150         * arm-tdep.h (arm_read_description)
4151         (arm_read_mprofile_description): Add declaration.
4152         * configure.tgt: Add new files.
4153
4154 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4155
4156         * top.c (new_ui_command): Open specified terminal just once.
4157
4158 2019-07-18  Tom Tromey  <tromey@adacore.com>
4159
4160         * symtab.c (main_name): Constify return type.
4161         * symfile.c (set_initial_language): Update.
4162         * symtab.h (main_name): Constify return type.
4163
4164 2019-07-17  Tom Tromey  <tom@tromey.com>
4165
4166         * tui/tui-winsource.c (tui_update_source_window)
4167         (tui_update_source_window_as_is)
4168         (tui_update_source_windows_with_line): Remove return.
4169         * tui/tui-disasm.c (tui_show_disassem)
4170         (tui_show_disassem_and_update_source): Remove return.
4171         * tui/tui.c (tui_reset): Remove return.
4172         * tui/tui-wingeneral.c
4173         (tui_check_and_display_highlight_if_needed): Remove return.
4174
4175 2019-07-17  Tom Tromey  <tom@tromey.com>
4176
4177         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4178
4179 2019-07-17  Tom Tromey  <tom@tromey.com>
4180
4181         * tui/tui-winsource.h (struct tui_exec_info_window)
4182         (struct tui_source_window_base): Move from tui-data.h.
4183         * tui/tui-winsource.c: Move many method definitions from
4184         elsewhere.  Remove "structuring" comments.
4185         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4186         (tui_source_window_base::refresh_window): Move to
4187         tui-winsource.c.
4188         * tui/tui-win.c (tui_source_window_base::refresh_all)
4189         (tui_source_window_base::update_tab_width)
4190         (tui_source_window_base::set_new_height)
4191         (tui_source_window_base::do_make_visible_with_new_height): Move to
4192         tui-winsource.c.
4193         * tui/tui-source.h: Update.
4194         * tui/tui-source.c (tui_source_window_base::reset): Move to
4195         tui-winsource.c.
4196         * tui/tui-disasm.h: Update.
4197         * tui/tui-data.h (struct tui_exec_info_window): Move to
4198         tui-winsource.h.
4199         (struct tui_source_window_base): Likewise.
4200         * tui/tui-data.c (tui_source_window_base::clear_detail)
4201         (tui_source_window_base, ~tui_source_window_base): Move to
4202         tui-winsource.c.
4203
4204 2019-07-17  Tom Tromey  <tom@tromey.com>
4205
4206         * tui/tui-win.c (tui_resize_all)
4207         (tui_source_window_base::update_tab_width)
4208         (tui_adjust_win_heights): Update.
4209         (tui_win_info::make_invisible_and_set_new_height): Rename from
4210         make_invisible_and_set_new_height.
4211         * tui/tui-data.h (struct tui_win_info)
4212         <make_invisible_and_set_new_height>: New method.
4213
4214 2019-07-17  Tom Tromey  <tom@tromey.com>
4215
4216         * tui/tui.c: Update.
4217         * tui/tui-source.h (struct tui_source_window): Move from
4218         tui-data.h.
4219         * tui/tui-layout.c: Update.
4220         * tui/tui-disasm.c: Update.
4221         * tui/tui-data.h (struct tui_source_window): Move to
4222         tui-source.h.
4223
4224 2019-07-17  Tom Tromey  <tom@tromey.com>
4225
4226         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4227         tui-data.h.
4228         * tui/tui-data.h (struct tui_disasm_window): Move to
4229         tui-disasm.h.
4230
4231 2019-07-17  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui-regs.h (struct tui_data_item_window): Move from
4234         tui-data.h.
4235         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4236         * tui/tui-data.h (struct tui_data_item_window): Move to
4237         tui-regs.h.
4238         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4239
4240 2019-07-17  Tom Tromey  <tom@tromey.com>
4241
4242         * tui/tui.c: Update.
4243         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4244         (tui_cmd_window::max_height): Move to tui-command.c.
4245         * tui/tui-layout.c: Update.
4246         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4247         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4248         tui-command.c.
4249         * tui/tui-command.h (struct tui_cmd_window): Move from
4250         tui-data.h.
4251         * tui/tui-command.c: Remove "structuring" comments.
4252         (tui_cmd_window::clear_detail)
4253         (tui_cmd_window::do_make_visible_with_new_height)
4254         (tui_cmd_window::max_height): Move from elsewhere.
4255
4256 2019-07-17  Tom Tromey  <tom@tromey.com>
4257
4258         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4259         Now static.
4260         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4261         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4262
4263 2019-07-17  Tom Tromey  <tom@tromey.com>
4264
4265         * tui/tui.c: Update.
4266         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4267         tui-regs.c.
4268         * tui/tui-windata.h: Remove file.
4269         * tui/tui-windata.c: Remove file.
4270         * tui/tui-win.c (tui_data_window::set_new_height)
4271         (tui_data_window::do_make_visible_with_new_height): Move to
4272         tui-regs.c.
4273         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4274         * tui/tui-regs.c: Remove "structuring" comments.
4275         (tui_data_window::first_data_item_displayed)
4276         (tui_data_window::delete_data_content_windows)
4277         (tui_data_window::erase_data_content)
4278         (tui_data_window::display_all_data)
4279         (tui_data_window::refresh_all)
4280         (tui_data_window::do_scroll_vertical)
4281         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4282         (tui_data_window::do_make_visible_with_new_height)
4283         (tui_data_window::refresh_window): Move from elsewhere.
4284         (_initialize_tui_regs): Move to end of file.
4285         * tui/tui-layout.c: Update.
4286         * tui/tui-hooks.c: Update.
4287         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4288         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4289         tui-regs.c.
4290         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4291
4292 2019-07-17  Tom Tromey  <tom@tromey.com>
4293
4294         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4295         seen.
4296
4297 2019-07-17  Tom Tromey  <tom@tromey.com>
4298
4299         * tui/tui-win.c (tui_source_window_base::set_new_height)
4300         (tui_source_window_base::do_make_visible_with_new_height): Use
4301         m_has_locator field directly.
4302         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4303         method.
4304         (struct tui_source_window_base) <has_locator>: Likewise.
4305
4306 2019-07-17  Tom Tromey  <tom@tromey.com>
4307
4308         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4309         Don't declare.
4310         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4311         Remove.
4312         * tui/tui-win.c (tui_source_window_base::set_new_height)
4313         (tui_source_window_base::set_new_height)
4314         (make_invisible_and_set_new_height)
4315         (tui_source_window_base::do_make_visible_with_new_height)
4316         (tui_source_window_base::do_make_visible_with_new_height):
4317         Update.
4318         * tui/tui-layout.c (show_source_disasm_command, show_data)
4319         (show_source_or_disasm_and_command): Update.
4320         * tui/tui-layout.c (show_layout): Update.
4321
4322 2019-07-17  Tom Tromey  <tom@tromey.com>
4323
4324         * tui/tui-layout.c (make_data_window): Remove.
4325         (show_data): Unify creation and re-initialization cases.
4326
4327 2019-07-17  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-layout.c (make_source_window, make_disasm_window):
4330         Remove.
4331         (show_data): Unify creation and re-initialization cases.
4332
4333 2019-07-17  Tom Tromey  <tom@tromey.com>
4334
4335         * tui/tui-layout.c (make_command_window): Remove.
4336         (show_source_disasm_command, show_source_or_disasm_and_command):
4337         Unify creation and re-initialization cases.
4338
4339 2019-07-17  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4342         creation and re-initialization cases.
4343
4344 2019-07-17  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-regs.c (tui_get_register): Return void.
4347
4348 2019-07-17  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4351         Simplify.
4352
4353 2019-07-17  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4356         resetting.
4357
4358 2019-07-17  Tom Tromey  <tom@tromey.com>
4359
4360         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4361         * tui/tui-regs.c (tui_reg_layout): New function.
4362         (tui_show_registers, tui_reg_command): Use it.
4363         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4364         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4365         parameters.
4366         (tui_layout_command): Remove.
4367
4368 2019-07-17  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-layout.h (tui/tui-layout): Return void.
4371         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4372
4373 2019-07-17  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-layout.c (show_source_disasm_command, show_data):
4376         Update.
4377         (reset_locator): Remove.
4378         (show_source_or_disasm_and_command): Update.
4379
4380 2019-07-17  Tom Tromey  <tom@tromey.com>
4381
4382         * tui/tui-source.c (tui_source_window_base::reset): Remove
4383         win_type parameter.
4384         * tui/tui-layout.c (make_command_window, make_source_window)
4385         (make_disasm_window, make_data_window)
4386         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4387         (reset_locator, show_source_or_disasm_and_command): Update.
4388         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4389         win_type parameter.
4390         (struct tui_source_window_base) <reset>: Likewise.
4391
4392 2019-07-17  Tom Tromey  <tom@tromey.com>
4393
4394         * tui/tui-layout.c (show_source_disasm_command): Use
4395         reset_locator.
4396         (reset_locator): New function.
4397         (init_and_make_win): Remove.
4398         (show_source_or_disasm_and_command): Use reset_locator.
4399
4400 2019-07-17  Tom Tromey  <tom@tromey.com>
4401
4402         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4403         condition.
4404         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4405         Remove condition.
4406         * tui/tui-source.c (tui_source_window_base::reset): New method.
4407         * tui/tui-layout.c (make_command_window): Don't call
4408         init_and_make_win.
4409         (make_source_window, make_disasm_window): Don't call
4410         make_source_or_disasm_window.
4411         (make_data_window): Don't call init_and_make_win.  Change calling
4412         convention.
4413         (show_source_disasm_command, show_data): Simplify.
4414         (make_source_or_disasm_window): Remove.
4415         (show_source_or_disasm_and_command): Simplify.
4416         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4417         (struct tui_source_window_base) <reset>: Likewise.
4418         <execution_info>: Remove initializer.
4419         * tui/tui-data.c (tui_source_window_base): Initialize
4420         execution_info.
4421
4422 2019-07-17  Tom Tromey  <tom@tromey.com>
4423
4424         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4425         variable.
4426
4427 2019-07-17  Tom Tromey  <tom@tromey.com>
4428
4429         * tui/tui.c (tui_rl_other_window): Update.
4430         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4431         superclass method first.  Always iterate over regs_content.
4432         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4433         method.
4434         * tui/tui-win.c (tui_set_focus_command): Update.
4435
4436 2019-07-17  Tom Tromey  <tom@tromey.com>
4437
4438         * tui/tui-win.c (tui_set_focus_command): Rename from
4439         tui_set_focus.  Call tui_enable.
4440         (tui_set_focus_command): Remove.
4441
4442 2019-07-17  Tom Tromey  <tom@tromey.com>
4443
4444         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4445         refresh_window.
4446         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4447         touchwin.
4448         (tui_data_window::refresh_window): Call refresh_window on data
4449         items.  Always call superclass refresh_window.
4450         (tui_win_info::refresh): Remove.
4451         (tui_source_window_base::refresh_window): Update.
4452         (tui_refresh_all): Update.
4453         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4454         refresh_window.
4455         (show_source_or_disasm_and_command): Likewise.
4456         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4457         (struct tui_source_window_base) <refresh>: Likewise.
4458
4459 2019-07-17  Tom Tromey  <tom@tromey.com>
4460
4461         * tui/tui-winsource.c (tui_clear_source_content)
4462         (tui_show_source_content): Update.
4463         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4464         whether content is empty.
4465         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4466         Remove.
4467
4468 2019-07-17  Tom Tromey  <tom@tromey.com>
4469
4470         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4471         window's contents.
4472         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4473         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4474
4475 2019-07-17  Tom Tromey  <tom@tromey.com>
4476
4477         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4478         (struct tui_data_item_window): Update.
4479
4480 2019-07-17  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4483         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4484         defines.
4485
4486 2019-07-17  Tom Tromey  <tom@tromey.com>
4487
4488         * tui/tui-winsource.h (tui_erase_source_content)
4489         (tui_clear_source_content): Remove "display_prompt" parameter.
4490         * tui/tui-winsource.c (tui_update_source_window_as_is)
4491         (tui_update_source_windows_with_addr): Update.
4492         (tui_clear_source_content): Remove "display_prompt" parameter.
4493         (tui_erase_source_content): Likewise.  Simplify.
4494         (tui_show_source_content): Update.
4495         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4496         * tui/tui-stack.c (tui_show_frame_info): Update.
4497         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4498         Remove defines.
4499
4500 2019-07-17  Tom Tromey  <tom@tromey.com>
4501
4502         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4503         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4504         parameter.
4505         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4506         parameter.
4507
4508 2019-07-17  Tom Tromey  <tom@tromey.com>
4509
4510         * tui/tui-winsource.c (tui_clear_source_content)
4511         (tui_show_source_content, tui_show_exec_info_content)
4512         (tui_clear_exec_info_content): Update.
4513         * tui/tui-stack.c (tui_show_locator_content): Update.
4514         (tui_show_frame_info): Update.
4515         * tui/tui-source.h (tui_source_window): Don't declare.
4516         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4517         from tui_source_is_displayed.
4518         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4519         Remove field.
4520         (struct tui_source_window_base) <content_in_use>: New field.  Now
4521         bool.
4522         (struct tui_source_window) <showing_source_p>: New method.
4523         (TUI_SRC_WIN): Change cast.
4524         * tui/tui-data.c (tui_initialize_static_data): Update.
4525
4526 2019-07-17  Tom Tromey  <tom@tromey.com>
4527
4528         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4529         location_matches_p.
4530         * tui/tui-source.c (tui_source_window::location_matches_p): New
4531         method.
4532         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4533         method.
4534         * tui/tui-data.h (struct tui_source_window_base)
4535         <location_matches_p>: New method.
4536         (struct tui_source_window, struct tui_disasm_window)
4537         <location_matches_p>: Likewise.
4538
4539 2019-07-17  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-win.c (tui_set_win_height_command): Rename from
4542         tui_set_win_height.
4543         (tui_set_win_height_command): Remove.
4544
4545 2019-07-17  Tom Tromey  <tom@tromey.com>
4546
4547         * tui/tui-source.c (tui_source_window): New constructor.  Add
4548         observer.
4549         (~tui_source_window): New destructor.
4550         (tui_source_window::style_changed): New method.
4551         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4552         (tui_attach_detach_observers): Update.
4553         * tui/tui-data.h (struct tui_source_window): Make constructor not
4554         inline.  Add destructor.
4555         (struct tui_source_window) <style_changed>: New method.
4556         <m_observable>: New member.
4557
4558 2019-07-17  Tom Tromey  <tom@tromey.com>
4559
4560         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4561         * tui/tui-win.c (tui_resize_all): Fix typo.
4562
4563 2019-07-17  Tom Tromey  <tom@tromey.com>
4564
4565         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4566         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4567         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4568         * tui/tui-win.c (window_name_completer): Use foreach.
4569         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4570         (update_tab_width): Likewise.
4571         * tui/tui-layout.c (show_layout): Update.
4572         * tui/tui-data.h (class tui_window_iterator): New.
4573         (struct all_tui_windows): New.
4574         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4575
4576 2019-07-17  Tom Tromey  <tom@tromey.com>
4577
4578         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4579         parameter.  Don't reference globals.
4580         (tui_reg_command): Update.
4581
4582 2019-07-17  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-regs.c (tui_show_registers): Simplify.
4585
4586 2019-07-17  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-regs.c (tui_show_registers): Update.
4589         (tui_show_register_group): Add win_info parameter.
4590
4591 2019-07-17  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4594         Rename from tui_display_reg_element_at_line.
4595         (tui_data_window::display_registers_from_line): Update.
4596         * tui/tui-data.h (struct tui_data_window)
4597         <display_reg_element_at_line>: New method.
4598
4599 2019-07-17  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui-regs.h (tui_display_registers_from)
4602         (tui_display_registers_from_line): Don't declare.
4603         * tui/tui-windata.c (tui_data_window::display_all_data)
4604         (tui_data_window::refresh_all)
4605         (tui_data_window::do_scroll_vertical): Update.
4606         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4607         from tui_display_registers_from.
4608         (tui_display_reg_element_at_line): Update.
4609         (tui_data_window::display_registers_from_line): Rename from
4610         tui_display_registers_from_line.
4611         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4612         display_registers_from_line>: New methods.
4613
4614 2019-07-17  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4617         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4618         from tui_erase_data_content.
4619         (tui_data_window::display_all_data)
4620         (tui_data_window::refresh_all)
4621         (tui_data_window::do_scroll_vertical): Update.
4622         * tui/tui-regs.c (tui_show_registers): Update.
4623         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4624         New method.
4625
4626 2019-07-17  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4629         declare.
4630         * tui/tui-windata.c
4631         (tui_data_window::delete_data_content_windows): Rename from
4632         tui_delete_data_content_windows.
4633         (tui_data_window::display_all_data)
4634         (tui_data_window::do_scroll_vertical): Update.
4635         * tui/tui-data.h (struct tui_data_window)
4636         <delete_data_content_windows>: New method.
4637
4638 2019-07-17  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4641         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4642
4643 2019-07-17  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4646         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4647         from tui_display_all_data.
4648         * tui/tui-win.c
4649         (tui_data_window::do_make_visible_with_new_height): Update.
4650         * tui/tui-regs.c (tui_show_registers): Update.
4651         * tui/tui-layout.c (tui_set_layout): Update.
4652         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4653         method.
4654
4655 2019-07-17  Tom Tromey  <tom@tromey.com>
4656
4657         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4658         * tui/tui-windata.c (tui_display_data_from): Remove.
4659         (tui_data_window::refresh_all): Update.
4660
4661 2019-07-17  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4664         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4665         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4666         tui_display_registers_from_line.
4667         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4668         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4669         "force_display" parameter.
4670
4671 2019-07-17  Tom Tromey  <tom@tromey.com>
4672
4673         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4674         declare.
4675         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4676         Rename from tui_first_reg_element_no_inline.
4677         (tui_display_reg_element_at_line)
4678         (tui_display_registers_from_line): Update.
4679         * tui/tui-data.h (struct tui_data_window)
4680         <first_reg_element_no_inline>: New method.
4681
4682 2019-07-17  Tom Tromey  <tom@tromey.com>
4683
4684         * tui/tui-windata.c (tui_display_data_from)
4685         (tui_data_window::do_scroll_vertical): Update.
4686         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4687         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4688         Rename from tui_line_from_reg_element_no.
4689         (tui_display_registers_from_line): Update.
4690         * tui/tui-data.h (struct tui_data_window)
4691         <line_from_reg_element_no>: New method.
4692
4693 2019-07-17  Tom Tromey  <tom@tromey.com>
4694
4695         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4696         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4697         tui_last_regs_line_no.
4698         (tui_display_reg_element_at_line)
4699         (tui_display_registers_from_line): Update.
4700         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4701         method.
4702
4703 2019-07-17  Tom Tromey  <tom@tromey.com>
4704
4705         PR tui/24722:
4706         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4707         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4708         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4709         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4710         (tui_update_breakpoint_info): Likewise.
4711         * tui/tui-hooks.c (tui_event_create_breakpoint)
4712         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4713         Update.
4714
4715 2019-07-17  Tom Tromey  <tom@tromey.com>
4716
4717         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4718
4719 2019-07-17  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui-winsource.c (tui_update_source_window_as_is)
4722         (tui_update_source_windows_with_addr): Update.
4723         * tui/tui-source.h (tui_set_source_content)
4724         (tui_show_symtab_source): Add "win_info" parameter.
4725         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4726         parameter.
4727         (tui_show_symtab_source): Likewise.
4728
4729 2019-07-17  Tom Tromey  <tom@tromey.com>
4730
4731         * tui/tui-wingeneral.c
4732         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4733
4734 2019-07-17  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4737         (struct tui_cmd_window) <can_scroll>: New method.
4738         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4739         method.
4740
4741 2019-07-17  Tom Tromey  <tromey@adacore.com>
4742
4743         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4744         do_field_signed>: Rename.  Change type of "value".
4745         * ui-out.c (ui_out::field_signed): Rename from field_int.
4746         Change type of "value".
4747         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4748         type of "value".
4749         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4750         do_field_int.  Change type of "value".
4751         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4752         do_field_int.  Change type of "value".
4753         * tracepoint.c (trace_status_mi, tfind_1)
4754         (print_one_static_tracepoint_marker): Update.
4755         * thread.c (print_thread_info_1, print_selected_thread_frame):
4756         Update.
4757         * stack.c (print_frame, print_frame_info): Update.
4758         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4759         Update.
4760         * source.c (print_source_lines_base): Update.
4761         * skip.c (info_skip_command): Update.
4762         * record-btrace.c (btrace_ui_out_decode_error)
4763         (btrace_call_history_src_line): Update.
4764         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4765         Update.
4766         * progspace.c (print_program_space): Update.
4767         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4768         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4769         do_field_int.  Change type of "value".
4770         * mi/mi-out.c (mi_ui_out::do_table_begin)
4771         (mi_ui_out::do_table_header): Update.
4772         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4773         type of "value".
4774         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4775         (mi_cmd_data_list_changed_registers, output_register)
4776         (mi_cmd_data_read_memory, mi_load_progress)
4777         (mi_cmd_trace_frame_collected): Update.
4778         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4779         Update.
4780         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4781         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4782         (mi_cmd_var_list_children, varobj_update_one): Update.
4783         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4784         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4785         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4786         * inferior.c (print_inferior): Update.
4787         * gdb_bfd.c (print_one_bfd): Update.
4788         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4789         Update.
4790         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4791         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4792         do_field_int.  Change type of "value".
4793         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4794         do_field_int.  Change type of "value".
4795         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4796         (print_one_breakpoint_location, print_it_catch_fork)
4797         (print_one_catch_fork, print_it_catch_vfork)
4798         (print_one_catch_vfork, print_it_catch_solib)
4799         (print_it_catch_exec, print_it_ranged_breakpoint)
4800         (print_mention_watchpoint, print_mention_masked_watchpoint)
4801         (bkpt_print_it, update_static_tracepoint): Update.
4802         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4803         * break-catch-syscall.c (print_it_catch_syscall): Update.
4804         * ada-tasks.c (print_ada_task_info): Update.
4805         * ada-lang.c (print_it_exception, print_mention_exception):
4806         Update.
4807
4808 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         PR breakpoints/24541
4811         * gdbarch.c: Regenerate.
4812         * gdbarch.h: Regenerate.
4813         * gdbarch.sh: Adjust return type and parameter types for
4814         'stap_adjust_register'.
4815         (i386_stap_adjust_register): Adjust signature and return new
4816         register name.
4817         * stap-probe.c (stap_parse_register_operand): Adjust use of
4818         'gdbarch_stap_adjust_register'.
4819
4820 2019-07-17  Tom Tromey  <tromey@adacore.com>
4821
4822         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4823         declare VEC.
4824         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4825         std::vector.
4826         (struct s390_process_info): Add initializers.
4827         (s390_add_process): Use new.
4828         (s390_linux_nat_target::low_forget_process): Use delete.
4829         (s390_linux_nat_target::low_new_fork)
4830         (s390_linux_nat_target::stopped_by_watchpoint)
4831         (s390_linux_nat_target::low_prepare_to_resume)
4832         (s390_linux_nat_target::insert_watchpoint)
4833         (s390_linux_nat_target::insert_hw_breakpoint)
4834         (s390_linux_nat_target::remove_watchpoint)
4835         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4836
4837 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4838
4839         * aarch64-fbsd-nat.c: Include regcache.h.
4840         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4841         argument.
4842         (aarch64_fbsd_nat_target::fetch_registers)
4843         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4844         variable.
4845         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4846
4847 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4848
4849         * fbsd-nat.c: Include gdbarch.h.
4850
4851 2019-07-15  Tom Tromey  <tromey@adacore.com>
4852
4853         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4854
4855 2019-07-15  Tom Tromey  <tromey@adacore.com>
4856
4857         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4858         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4859         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4860         * cli-out.c (cli_ui_out::do_field_int): New method.
4861         * ui-out.c (ui_out::field_unsigned): New method.
4862         * symfile.c (generic_load): Use field_unsigned.
4863         (print_transfer_performance): Likewise.
4864         * record-btrace.c (ui_out_field_uint): Remove.
4865         (btrace_call_history_insn_range, btrace_call_history): Use
4866         field_unsigned.
4867         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4868         field_unsigned.
4869         * ui-out.h (class ui_out) <field_unsigned>: New method.
4870         <do_field_unsigned>: Likewise.
4871
4872 2019-07-15  Tom Tromey  <tromey@adacore.com>
4873
4874         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4875         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4876         * target.c (flash_erase_command): Use field_string.
4877         * infrun.c (print_signal_received_reason): Use field_string.
4878         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4879         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4880         field_string.
4881         * ada-tasks.c (print_ada_task_info): Use field_string.
4882
4883 2019-07-15  Tom Tromey  <tromey@adacore.com>
4884
4885         * target.c (flash_erase_command): Use field_core_addr.
4886         * symfile.c (generic_load): Use field_core_addr.
4887         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4888         Use field_core_addr.
4889         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4890         field_core_addr.
4891
4892 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4895         value if its desired type is smaller than a CORE_ADDR and signed.
4896
4897 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4900         of changes to field names, and use new is_reference field to
4901         decide if a property is a reference or not.
4902         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4903         field.
4904         (struct dwarf2_property_baton): Update header comment, rename
4905         'referenced_type' to 'property_type' and update comments.
4906         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4907         default property type, store in property baton, update to take
4908         accound of renamed field.
4909         (read_func_scope): Update call to attr_to_dynamic_prop.
4910         (read_array_type): Likewise.
4911         (dwarf2_per_cu_addr_sized_int_type): New function.
4912         (read_subrange_index_type): Move type finding code to
4913         dwarf2_per_cu_addr_sized_int_type.
4914         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4915         (dwarf2_per_cu_addr_type): New function.
4916         (set_die_type): Update calls to attr_to_dynamic_prop.
4917
4918 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * dwarf2read.c (read_subrange_index_type): New function.
4921         (read_subrange_type): Move code into new function and call it.
4922         * gdbtypes.c (create_range_type): Add some asserts.
4923
4924 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4925
4926         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4927         update return statements.
4928         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4929         declaration, and update comment to match.
4930         * gdbtypes.c (resolve_dynamic_array): Update call to
4931         dwarf2_evaluate_property to match new return type.
4932
4933 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4934
4935         * valarith.c (value_subscripted_rvalue): Change lowerbound
4936         parameter type from int to LONGEST.
4937         * value.h (value_subscripted_rvalue): Likewise in declaration.
4938
4939 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * cli/cli-utils.c (info_print_command_completer): New function.
4942         * cli/cli-utils.h: Add 'completer.h' include, and forward
4943         declaration for 'struct cmd_list_element'.
4944         (info_print_command_completer): Declare.
4945         * stack.c (_initialize_stack): Add completer for 'info locals' and
4946         'info args'.
4947         * symtab.c (_initialize_symtab): Add completer for 'info
4948         variables' and 'info functions'.
4949         * NEWS: Mention completion for additional info commands.
4950
4951 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * cli/cli-utils.c (extract_info_print_args): Delete.
4954         (extract_arg_maybe_quoted): Delete.
4955         (info_print_options_defs): New variable.
4956         (make_info_print_options_def_group): New function.
4957         (extract_info_print_options): Define new function.
4958         * cli/cli-utils.h (extract_info_print_args): Delete.
4959         (struct info_print_options): New structure.
4960         (extract_info_print_options): Declare new function.
4961         * stack.c (info_locals_command): Update to use new
4962         extract_info_print_options, also add a header comment.
4963         (info_args_command): Likewise.
4964         * symtab.c (info_variables_command): Likewise.
4965         (info_functions_command): Likewise.
4966
4967 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4970         to extract string arguments.
4971         * common/common-utils.c (extract_string_maybe_quoted): New function.
4972         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4973
4974 2019-07-11  Tom Tromey  <tromey@adacore.com>
4975
4976         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4977         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4978         * top.h (gdbinit): Don't declare.
4979         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4980         into...
4981         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4982         * top.c (gdb_init): Don't call init_cli_cmds.
4983         (gdbinit): Remove.
4984         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4985
4986 2019-07-11  Tom Tromey  <tromey@adacore.com>
4987
4988         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4989         after it has been moved.
4990
4991 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4992
4993         * valops.c (value_must_coerce_to_target): Change return type to
4994         bool.
4995         * value.h (value_must_coerce_to_target): Likewise.
4996
4997 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4998
4999         * breakpoint.c (is_hardware_watchpoint): Remove
5000         forward-declaration.
5001         (is_masked_watchpoint): Change return type to bool.
5002         (is_tracepoint): Likewise.
5003         (is_breakpoint): Likewise.
5004         (is_hardware_watchpoint): Likewise.
5005         (is_watchpoint): Likewise.
5006         (is_no_memory_software_watchpoint): Likewise.
5007         (is_catchpoint): Likewise.
5008         (breakpoint_1): Make FILTER parameter's return type bool.
5009         is_masked_watchpoint): Change return type to bool.
5010         (save_breakpoints): Make FILTER parameter's return type bool.
5011         * breakpoint.h (is_breakpoint): Change return type to bool.
5012         (is_watchpoint): Likewise.
5013         (is_catchpoint): Likewise.
5014         (is_tracepoint): Likewise.
5015
5016 2019-07-10  Tom Tromey  <tom@tromey.com>
5017
5018         * defs.h: Don't include gdbarch.h.
5019         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5020         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5021         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5022         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5023         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5024         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5025         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5026         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5027         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5028         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5029         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5030         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5031         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5032         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5033         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5034         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5035         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5036         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5037         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5038         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5039         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5040         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5041         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5042         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5043         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5044         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5045         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5046
5047 2019-07-10  Tom Tromey  <tromey@adacore.com>
5048
5049         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5050         * breakpoint.c (init_ada_exception_breakpoint): Register as
5051         bp_catchpoint.
5052         (print_one_breakpoint_location, print_one_breakpoint): Use
5053         is_ada_exception_catchpoint.
5054         * ada-lang.c (class ada_catchpoint_location): Pass
5055         bp_loc_software_breakpoint to bp_location constructor.
5056         (is_ada_exception_catchpoint): New function.
5057
5058 2019-07-10  Tom Tromey  <tromey@adacore.com>
5059
5060         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5061         VEC.
5062         (struct arm_exidx_entry): New method operator<.
5063         (struct arm_exidx_data) <section_maps>: Change type.
5064         (arm_exidx_data_free): Remove.
5065         (arm_exidx_data_key): Change type.  Move lower.
5066         (arm_exidx_new_objfile): Update.
5067         (arm_compare_exidx_entries): Remove.
5068         (arm_find_exidx_entry, _initialize_arm_tdep)
5069
5070 2019-07-10  Tom Tromey  <tromey@adacore.com>
5071
5072         * solib-spu.c (ocl_program_data_key): Change type.
5073         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5074         Update.
5075
5076 2019-07-10  Tom Tromey  <tromey@adacore.com>
5077
5078         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5079         (struct solib_aix_inferior_data) <library_list>: Change type.
5080         (solib_aix_inferior_data_handle): Change type.
5081         (get_solib_aix_inferior_data): Update.
5082         (solib_aix_free_library_list): Remove.
5083         (library_list_start_library): Update.
5084         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5085         return type.
5086         (solib_aix_get_library_list)
5087         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5088         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5089
5090 2019-07-10  Tom Tromey  <tromey@adacore.com>
5091
5092         * solib-dsbt.c (struct dsbt_info): Add initializers.
5093         (solib_dsbt_pspace_data): Change type.
5094         (dsbt_pspace_data_cleanup): Remove.
5095         (get_dsbt_info, _initialize_dsbt_solib): Update.
5096
5097 2019-07-10  Tom Tromey  <tromey@adacore.com>
5098
5099         * spu-tdep.c (spu_overlay_data): Change type.
5100         (spu_get_overlay_table, spu_overlay_new_objfile)
5101         (_initialize_spu_tdep): Update.
5102
5103 2019-07-10  Tom Tromey  <tromey@adacore.com>
5104
5105         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5106         destructor.
5107         (dbx_objfile_data_key): Change type and declare later.
5108         (DBX_SYMFILE_INFO): Rewrite.
5109         * dbxread.c (dbx_objfile_data_key): Change type.
5110         (dbx_symfile_init): Update.
5111         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5112         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5113         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5114
5115 2019-07-10  Tom Tromey  <tromey@adacore.com>
5116
5117         * jit.c (jit_program_space_key): Change type.  Move lower.
5118         (get_jit_program_space_data): Update.
5119         (jit_program_space_data_cleanup): Remove.
5120         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5121         Update.
5122         (struct jit_program_space_data): Add initializers.
5123
5124 2019-07-10  Tom Tromey  <tromey@adacore.com>
5125
5126         * solib-darwin.c (struct darwin_info): Add initializers.
5127         (solib_darwin_pspace_data): Change type.
5128         (darwin_pspace_data_cleanup): Remove.
5129         (get_darwin_info, _initialize_darwin_solib): Update.
5130
5131 2019-07-10  Tom Tromey  <tromey@adacore.com>
5132
5133         * remote-sim.c (struct sim_inferior_data): Add initializers,
5134         constructor, and destructor.
5135         (sim_inferior_data_key): Change type.  Move lower.
5136         (check_for_duplicate_sim_descriptor): Update.
5137         (get_sim_inferior_data): Use new.  Update.
5138         (~sim_inferior_data_cleanup): Rename from
5139         sim_inferior_data_cleanup.  Simplify.
5140         (gdbsim_close_inferior, simulator_command)
5141         (sim_command_completer, _initialize_remote_sim): Update.
5142         (next_pid, INITIAL_PID): Move earlier.
5143
5144 2019-07-10  Tom Tromey  <tromey@adacore.com>
5145
5146         * python/python-internal.h (create_thread_object): Return
5147         gdbpy_ref.
5148         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5149         * python/py-inferior.c (struct threadlist_entry): Add
5150         constructor.
5151         <thread_obj>: Now a gdbpy_ref.
5152         (thread_to_thread_object): Update.
5153         (add_thread_object): Use new.
5154         (delete_thread_object): Use delete.
5155         (infpy_threads): Update.
5156         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5157         GIL.
5158
5159 2019-07-10  Tom Tromey  <tromey@adacore.com>
5160
5161         * valops.c (value_cast): Specialize error message for Ada.
5162
5163 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5164
5165         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5166
5167 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5168
5169         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5170         bpstat_should_step): Return bool, adjust comments.
5171         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5172         bpstat_should_step): Likewise.
5173
5174 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5175
5176         * features/Makefile: Use feature target descriptions for Arm.
5177         * features/arm/arm-core.c: Generate new file.
5178         * features/arm/arm-fpa.c: Likewise.
5179         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5180         * features/arm/arm-m-profile.c: Likewise.
5181         * features/arm/arm-vfpv2.c: Likewise.
5182         * features/arm/arm-vfpv3.c: Likewise.
5183         * features/arm/xscale-iwmmxt.c: Likewise.
5184         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5185
5186 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5187
5188         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5189         ptrace earlier.
5190
5191 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5192
5193         * features/aarch64-pauth.c: Regenerate.
5194
5195 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5196
5197         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5198         bool.
5199         (bpstat_what): Use false instead of 0.
5200
5201 2019-07-09  Pedro Alves  <palves@redhat.com>
5202
5203         * break-catch-throw.c (is_exception_catchpoint): New.
5204         * breakpoint.c (print_one_breakpoint_location): New parameter
5205         'raw_loc'.  Handle it.  Use
5206         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5207         looking at the breakpoint's type.
5208         (print_one_breakpoint): If handling "maint info breakpoints", also
5209         print locations of exception catchpoints.
5210         * breakpoint.h (is_exception_catchpoint): Declare.
5211
5212 2019-07-09  Pedro Alves  <palves@redhat.com>
5213
5214         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5215         "addr" field.
5216         (allocate_location_exception_catchpoint): New.
5217         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5218         (initialize_throw_catchpoint_ops): Install
5219         allocate_location_exception_catchpoint as allocate_location
5220         method.
5221         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5222         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5223         bp_loc_other.
5224         (breakpoint_address_is_meaningful): Delete.
5225         (bl_address_is_meaningful): New.
5226         (breakpoint_locations_match): Adjust comment.
5227         (bp_location_from_bp_type): New, factored out of...
5228         (bp_location::bp_location(breakpoint *)): ... this.
5229         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5230         factored out of...
5231         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5232         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5233         breakpoint_address_is_meaningful.
5234         (bp_locations_compare): Adjust comment.
5235         (update_global_location_list): Use bl_address_is_meaningful
5236         instead of breakpoint_address_is_meaningful.
5237         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5238         explicit.
5239         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5240         * python/py-breakpoint.c (bppy_get_location): No longer check
5241         whether location is null.
5242
5243 2019-07-09  Pedro Alves  <palves@redhat.com>
5244
5245         PR c++/15468
5246         * breakpoint.c (print_one_breakpoint_location): Remove
5247         single-location assert.
5248
5249 2019-07-09  Tom Tromey  <tom@tromey.com>
5250
5251         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5252         * configure: Rebuild.
5253         * configure.ac: Change common to gdbsupport.
5254         * gdbsupport: Rename from common.
5255         * acinclude.m4: Change common to gdbsupport.
5256         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5257         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5258         gdbsupport.
5259         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5260         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5261         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5262         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5263         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5264         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5265         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5266         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5267         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5268         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5269         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5270         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5271         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5272         coff-pe-read.c, command.h, compile/compile-c-support.c,
5273         compile/compile-c.h, compile/compile-cplus-symbols.c,
5274         compile/compile-cplus-types.c, compile/compile-cplus.h,
5275         compile/compile-loc2c.c, compile/compile.c, completer.c,
5276         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5277         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5278         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5279         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5280         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5281         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5282         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5283         features/aarch64-core.c, features/aarch64-fpu.c,
5284         features/aarch64-pauth.c, features/aarch64-sve.c,
5285         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5286         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5287         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5288         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5289         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5290         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5291         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5292         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5293         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5294         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5295         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5296         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5297         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5298         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5299         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5300         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5301         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5302         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5303         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5304         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5305         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5306         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5307         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5308         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5309         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5310         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5311         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5312         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5313         minsyms.c, mips-linux-tdep.c, namespace.h,
5314         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5315         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5316         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5317         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5318         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5319         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5320         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5321         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5322         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5323         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5324         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5325         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5326         procfs.c, producer.c, progspace.h, psymtab.h,
5327         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5328         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5329         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5330         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5331         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5332         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5333         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5334         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5335         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5336         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5337         target-memory.c, target.c, target.h, target/waitstatus.c,
5338         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5339         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5340         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5341         unittests/array-view-selftests.c,
5342         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5343         unittests/common-utils-selftests.c,
5344         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5345         unittests/format_pieces-selftests.c,
5346         unittests/function-view-selftests.c,
5347         unittests/lookup_name_info-selftests.c,
5348         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5349         unittests/mkdir-recursive-selftests.c,
5350         unittests/observable-selftests.c,
5351         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5352         unittests/parse-connection-spec-selftests.c,
5353         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5354         unittests/scoped_fd-selftests.c,
5355         unittests/scoped_mmap-selftests.c,
5356         unittests/scoped_restore-selftests.c,
5357         unittests/string_view-selftests.c, unittests/style-selftests.c,
5358         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5359         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5360         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5361         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5362         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5363         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5364
5365 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5366
5367         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5368         bool value.
5369         (decode_digits_ordinary): Set explicit_line field in sal.
5370         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5371         symtab_and_line that was set on an explicit line number in
5372         assembler code.  Do always update the recorded symtab and line if
5373         we do skip the prologue.
5374
5375 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * breakpoint.c (set_breakpoint_location_function): Remove
5378         explicit_loc parameter.
5379         (momentary_breakpoint_from_master): Update call to
5380         set_breakpoint_location_function.
5381         (add_location_to_breakpoint): Likewise.
5382
5383 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5384
5385         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5386         required features based on default bfd type when no specific bfd
5387         is present.
5388
5389 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5390
5391         * NEWS: Mention that GDB printf and eval commands can now print
5392         C-style and Ada-style convenience var strings without
5393         calling the inferior.
5394         * printcmd.c (printf_c_string): Locally print GDB internal var
5395         instead of transiting via the inferior.
5396         (printf_wide_c_string): Likewise.
5397
5398 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5399
5400         PR breakpoints/25011
5401         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5402
5403 2019-07-04  Tom Tromey  <tom@tromey.com>
5404
5405         PR tui/24724:
5406         * tui/tui-winsource.c (tui_clear_source_content): Update.
5407         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5408         (tui_update_breakpoint_info): Update.
5409         (tui_set_exec_info_content): Update.
5410         * tui/tui-source.c (tui_set_source_content_nil): Update.
5411         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5412         has_break.
5413         * tui/tui-data.h (enum tui_bp_flag): New.
5414         (tui_bp_flags): New enum flags type.
5415         (struct tui_source_element) <break_mode>: Change type.  Rename
5416         from has_break.
5417         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5418         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5419         constants.
5420         * tui/tui-winsource.h: Fix comment.
5421
5422 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5423
5424         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5425         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5426         (store_fpregs_to_thread)
5427         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5428         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5429         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5430         (IWMMXT_REGS_SIZE): Add define.
5431         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5432         (fetch_vfp_regs, store_vfp_regs)
5433         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5434         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5435
5436 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5437
5438         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5439         defines.
5440         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5441         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5442         (ARM_INT_REGISTER_SIZE): ...to this.
5443         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5444         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5445         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5446         (arm_linux_collect_gregset, supply_nwfpe_register)
5447         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5448         defines.
5449         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5450         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5451         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5452         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5453         (arm_return_in_memory, arm_store_return_value)
5454         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5455         (arm_record_ld_st_multiple): Likewise.
5456         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5457         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5458
5459 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5460
5461         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5462         AARCH64_DISPLACED_MODIFIED_INSNS.
5463         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5464         (aarch64_displaced_step_copy_insn): Likewise.
5465         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5466         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5467         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5468         ARM_DISPLACED_MODIFIED_INSNS.
5469         * arm-tdep.c (arm_gdbarch_init): Likewise.
5470         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5471         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5472         (struct arm_displaced_step_closure): Use
5473         ARM_DISPLACED_MODIFIED_INSNS.
5474
5475 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5476
5477         * features/Makefile: Remove unused xml files.
5478         * features/aarch64.xml: Remove.
5479         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5480         * features/i386/amd64-avx-avx512.xml: Remove.
5481         * features/i386/amd64-avx-linux.xml: Remove.
5482         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5483         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5484         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5485         * features/i386/amd64-avx-mpx.xml: Remove.
5486         * features/i386/amd64-avx.xml: Remove.
5487         * features/i386/amd64-linux.xml: Remove.
5488         * features/i386/amd64-mpx-linux.xml: Remove.
5489         * features/i386/amd64-mpx.xml: Remove.
5490         * features/i386/amd64.xml: Remove.
5491         * features/i386/i386-avx-avx512-linux.xml: Remove.
5492         * features/i386/i386-avx-avx512.xml: Remove.
5493         * features/i386/i386-avx-linux.xml: Remove.
5494         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5495         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5496         * features/i386/i386-avx-mpx-linux.xml: Remove.
5497         * features/i386/i386-avx-mpx.xml: Remove.
5498         * features/i386/i386-avx.xml: Remove.
5499         * features/i386/i386-linux.xml: Remove.
5500         * features/i386/i386-mmx-linux.xml: Remove.
5501         * features/i386/i386-mmx.xml: Remove.
5502         * features/i386/i386-mpx-linux.xml: Remove.
5503         * features/i386/i386-mpx.xml: Remove.
5504         * features/i386/i386.xml: Remove.
5505         * features/i386/x32-avx-avx512-linux.xml: Remove.
5506         * features/i386/x32-avx-linux.xml: Remove.
5507         * features/i386/x32-linux.xml: Remove.
5508
5509 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5510
5511         * regformats/aarch64.dat: Remove.
5512         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5513         * regformats/i386/amd64-avx-linux.dat: Remove.
5514         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5515         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5516         * regformats/i386/amd64-linux.dat: Remove.
5517         * regformats/i386/amd64-mpx-linux.dat: Remove.
5518         * regformats/i386/amd64.dat: Remove.
5519         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5520         * regformats/i386/i386-avx-linux.dat: Remove.
5521         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5522         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5523         * regformats/i386/i386-linux.dat: Remove.
5524         * regformats/i386/i386-mmx-linux.dat: Remove.
5525         * regformats/i386/i386-mpx-linux.dat: Remove.
5526         * regformats/i386/i386.dat: Remove.
5527         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5528         * regformats/i386/x32-avx-linux.dat: Remove.
5529         * regformats/i386/x32-linux.dat: Remove.
5530
5531 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5532
5533         * aarch64-tdep.c: Remove xml self tests.
5534         * amd64-linux-tdep.c: Likewise.
5535         * amd64-tdep.c: Likewise.
5536         * i386-linux-tdep.c: Likewise.
5537         * i386-tdep.c: Likewise.
5538
5539 2019-07-03  Pedro Alves  <palves@redhat.com>
5540
5541         PR cli/24732
5542         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5543         (pipe_cmd_option_defs): New.
5544         (make_pipe_cmd_options_def_group): New.
5545         (pipe_command): Use gdb::option::process_options.
5546         (pipe_command_completer): New function.
5547         (_initialize_cli_cmds): Install completer for "pipe" command.
5548
5549 2019-07-03  Pedro Alves  <palves@redhat.com>
5550
5551         * cli/cli-option.c (union option_value) <string>: New field.
5552         (struct option_def_and_value): Add ctor, move ctor, dtor and
5553         use DISABLE_COPY_AND_ASSIGN.
5554         (option_def_and_value::clear_value): New.
5555         (parse_option, save_option_value_in_ctx, get_val_type_str)
5556         (add_setshow_cmds_for_options): Handle var_string.
5557         * cli-option.h (union option_def::var_address) <string>: New
5558         field.
5559         (struct string_option_def): New.
5560         * maint-test-options.c (struct test_options_opts): Add default
5561         ctor and use DISABLE_COPY_AND_ASSIGN.
5562         <string_opt>: New field.
5563         (test_options_opts::~test_options_opts): New.
5564         (test_options_opts::dump): Also dump "-string".
5565         (test_options_option_defs): Install "string.
5566
5567 2019-07-03  Pedro Alves  <palves@redhat.com>
5568
5569         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5570         option_value with a null enumeration.
5571         (complete_options): Save the option values in the context.
5572         (save_option_value_in_ctx): New, factored out from ...
5573         (process_options): ... here.
5574         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5575         of the function.
5576         * maint-test-options.c (test_options_opts::dump): New, factored
5577         out from ...
5578         (maintenance_test_options_command_mode): ... here.
5579         (maintenance_test_options_command_completion_result): Delete.
5580         (maintenance_test_options_command_completion_text): Update
5581         comment.
5582         (maintenance_show_test_options_completion_result): Change
5583         prototype.  Just print
5584         maintenance_test_options_command_completion_text.
5585         (save_completion_result): New.
5586         (maintenance_test_options_completer_mode): Pass options context to
5587         complete_options, and then save a dump.
5588         (_initialize_maint_test_options): Use add_cmd to install "maint
5589         show test-options-completion-result".
5590
5591 2019-07-03  Pedro Alves  <palves@redhat.com>
5592
5593         * NEWS (New commands): Mention "with" and "maint with".
5594         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5595         (with_command, with_command_completer): New.
5596         (pipe_command): Adjust to new repeat_previous
5597         interface.
5598         (_initialize_cli_cmds): Install the "with" command and its "w"
5599         alias.
5600         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5601         declarations.
5602         * cli/cli-setshow.c (parse_cli_var_uinteger)
5603         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5604         argument strings for all var_types.
5605         (get_setshow_command_value_string): New, factored out from ...
5606         (do_show_command): ... this.
5607         * cli/cli-setshow.h: Include <string>.
5608         (get_setshow_command_value_string): Declare.
5609         * command.h (repeat_previous): Now returns const char *.  Adjust
5610         comment.
5611         * maint.c: Include "cli/cli-cmds.h".
5612         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5613         (_initialize_maint_cmds): Register the "maintenance with" command.
5614         * top.c (repeat_previous): Move bits from pipe_command here:
5615         Return the saved command line, if any; error out if there's no
5616         command to relaunch.
5617
5618 2019-07-03  Pedro Alves  <palves@redhat.com>
5619
5620         * NEWS (New commands): Mention "maint set/show test-settings"
5621         instead of "maint test-settings".
5622         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5623         (maintenance_test_settings_set_list): Rename to ...
5624         (maintenance_set_test_settings_list): ... this.
5625         (maintenance_test_settings_show_list): Rename to  ...
5626         (maintenance_show_test_settings_list): ... this.
5627         (maintenance_test_settings_cmd): Delete.
5628         (maintenance_test_settings_set_cmd): ...
5629         (maintenance_set_test_settings_cmd): ... this.
5630         (maintenance_test_settings_show_cmd): ...
5631         (maintenance_show_test_settings_cmd): ... this.
5632         (maintenance_test_settings_show_value_cmd):
5633         (maintenance_show_test_settings_value_cmd): ... this.
5634         (_initialize_maint_test_settings): No longer install the "maint
5635         test-settings" prefix command.  Rename "maint test-settings set"
5636         to "maint set test-settings", and "maint test-settings show" to
5637         "maint show test-settings".  Adjust all subcommands.
5638
5639 2019-07-03  Pedro Alves  <palves@redhat.com>
5640
5641         * maint-test-settings.c: Fix file's intro comment.  Replace all
5642         references to "test-options" with references to "test-settings",
5643         in comments.
5644
5645 2019-07-03  Pedro Alves  <palves@redhat.com>
5646
5647         * maint-test-settings.c (maintenance_test_settings_xxx)
5648         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5649         New.
5650         (maintenance_test_settings_enums): Use them.
5651         (maintenance_test_settings_enum): Default to
5652         maintenance_test_settings_xxx.
5653         (_initialize_maint_test_settings): Initialize
5654         MAINTENANCE_TEST_SETTINGS_FILENAME.
5655
5656 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5657
5658         * breakpoint.h (remove_breakpoints_inf): Change return type to
5659         void, move function documentation here.
5660         * breakpoint.c (remove_breakpoints_inf): Change return type to
5661         void, move function documentation to header.
5662
5663 2019-07-02  Pedro Alves  <palves@redhat.com>
5664
5665         * NEWS (Completion improvements): Mention "info threads".
5666         * thread.c (struct info_threads_opts, info_threads_option_defs)
5667         (make_info_threads_options_def_group): New.
5668         (info_threads_command): Use gdb::option::process_options.
5669         (info_threads_command_completer): New.
5670         (_initialize_thread): Use gdb::option::build_help to build the
5671         help text for "info threads".
5672
5673 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5674
5675         * defs.h (generic_load): Move from here...
5676         * symfile.h (generic_load): ... to here.  Rename name parameter
5677         to args.
5678         * symfile.c (generic_load): Add comment.
5679
5680 2019-07-01  Tom Tromey  <tromey@adacore.com>
5681
5682         * dwarf2read.c
5683         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5684         declaration of without_params.  Fix formatting.
5685
5686 2019-07-01  Tom Tromey  <tromey@adacore.com>
5687
5688         * ada-exp.y (find_primitive_type): Update.
5689         * ada-lang.h (ada_lookup_symbol): Update.
5690         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5691         parameter.
5692         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5693
5694 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5695
5696         PR breakpoints/24541
5697         * gdbarch.c: Regenerate.
5698         * gdbarch.h: Regenerate.
5699         * gdbarch.sh: Add 'stap_adjust_register'.
5700         * i386-tdep.c: Include '<unordered_set>'.
5701         (i386_stap_adjust_register): New function.
5702         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5703         * stap-probe.c (stap_parse_register_operand): Call
5704         'gdbarch_stap_adjust_register'.
5705
5706 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5707
5708         PR python/24742
5709         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5710         * python/python.c (do_start_initialization): Use 'xmalloc'
5711         instead of 'PyMem_Malloc'.
5712
5713 2019-06-28  Tom Tromey  <tromey@adacore.com>
5714
5715         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5716         for Ada.
5717
5718 2019-06-27  Tom Tromey  <tromey@adacore.com>
5719
5720         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5721         objfile_key.
5722         (arm_find_mapping_symbol, arm_record_special_symbol)
5723         (_initialize_arm_tdep): Update.
5724         (arm_objfile_data_free): Remove.
5725
5726 2019-06-27  Tom Tromey  <tromey@adacore.com>
5727
5728         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5729         to cp_print_static_field.
5730
5731 2019-06-26  Tom Tromey  <tromey@adacore.com>
5732
5733         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5734         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5735         declare.
5736
5737 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5738
5739         * features/aarch64-core.c (create_feature_aarch64_core):
5740         Regenerate.
5741         * features/aarch64-core.xml: Add cpsr flags.
5742
5743 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5744
5745         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5746         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5747
5748 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5749
5750         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5751         field.
5752         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5753         use.
5754         (arm_record_special_symbol): Don't insert new symbol in sorted
5755         position, push it at the end.
5756
5757 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5758
5759         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5760         (arm_mapping_symbol_s): Remove.
5761         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5762         (arm_mapping_symbol_vec): New typedef.
5763         (struct arm_per_objfile): Add constructor.
5764         <section_maps>: Change type to
5765         std::unique_ptr<arm_mapping_symbol_vec[]>.
5766         (arm_compare_mapping_symbols): Remove.
5767         (arm_find_mapping_symbol): Adjust to section_maps type change.
5768         (arm_objfile_data_free): Call delete on arm_per_objfile.
5769         (arm_record_special_symbol): Adjust to section_maps type change.
5770         Allocate arm_per_objfile with new.
5771
5772 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5773
5774         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5775         with the command prefix.
5776
5777 2019-06-25  Tom Tromey  <tom@tromey.com>
5778
5779         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5780         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5781
5782 2019-06-25  Tom Tromey  <tom@tromey.com>
5783
5784         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5785         type.
5786         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5787         protected.
5788
5789 2019-06-25  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-winsource.c
5792         (tui_source_window_base::set_is_exec_point_at): Add check against
5793         LOA_ADDRESS.
5794
5795 2019-06-25  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-source.c (tui_set_source_content): Don't check before
5798         xfree.
5799         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5800
5801 2019-06-25  Tom Tromey  <tom@tromey.com>
5802
5803         * tui/tui-winsource.h (tui_update_source_window_as_is)
5804         (tui_alloc_source_buffer, tui_line_is_displayed)
5805         (tui_addr_is_displayed): Change type of win_info.
5806         * tui/tui-winsource.c (tui_update_source_window_as_is)
5807         (tui_clear_source_content, tui_show_source_line)
5808         (tui_show_source_content, tui_source_window_base::refill)
5809         (tui_source_window_base::set_is_exec_point_at)
5810         (tui_source_window_base::set_is_exec_point_at)
5811         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5812         (tui_alloc_source_buffer, tui_line_is_displayed)
5813         (tui_addr_is_displayed): Change type of win_info.  Update.
5814         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5815         (tui_source_window_base::do_make_visible_with_new_height):
5816         Update.
5817         * tui/tui-source.c (tui_set_source_content)
5818         (tui_set_source_content_nil)
5819         (tui_source_window::do_scroll_vertical): Update.
5820         * tui/tui-layout.c (show_layout): Update.
5821         * tui/tui-disasm.c (tui_set_disassem_content)
5822         (tui_disasm_window::do_scroll_vertical): Update.
5823         * tui/tui-data.h (tui_win_content): Remove.
5824         (struct tui_gen_win_info) <content, content_size>: Remove.
5825         (struct tui_source_element): Add initializers and destructor.
5826         (union tui_which_element, struct tui_win_element): Remove.
5827         (struct tui_source_window_base) <content>: New field.
5828         (struct tui_data_window): Remove destructor.
5829         (tui_alloc_content, tui_free_win_content)
5830         (tui_free_all_source_wins_content): Don't declare.
5831         * tui/tui-data.c (tui_initialize_static_data): Update.
5832         (init_content_element, tui_alloc_content): Remove.
5833         (~tui_gen_win_info): Update.
5834         (~tui_data_window, tui_free_all_source_wins_content)
5835         (tui_free_win_content, free_content, free_content_elements):
5836         Remove.
5837
5838 2019-06-25  Tom Tromey  <tom@tromey.com>
5839
5840         * tui/tui-winsource.h (tui_clear_source_content)
5841         (tui_erase_source_content, tui_show_source_content): Change type
5842         of win_info.
5843         * tui/tui-winsource.c (tui_clear_source_content)
5844         (tui_erase_source_content, tui_show_source_content): Change type
5845         of win_info.
5846         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5847         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5848         win_info.
5849         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5850         win_info.
5851         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5852
5853 2019-06-25  Tom Tromey  <tom@tromey.com>
5854
5855         * tui/tui-winsource.c (tui_clear_source_content)
5856         (tui_source_window_base::set_is_exec_point_at): Update.
5857         * tui/tui-source.c (tui_set_source_content_nil): Update.
5858         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5859         a bool.
5860         * tui/tui-data.c (init_content_element): Update.
5861
5862 2019-06-25  Tom Tromey  <tom@tromey.com>
5863
5864         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5865         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5866         * tui/tui-layout.c (init_and_make_win): Update.
5867         * tui/tui.h (enum tui_win_type): Update.
5868         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5869         tui_win_is_auxillary.
5870         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5871         tui_win_is_auxillary.
5872
5873 2019-06-25  Tom Tromey  <tom@tromey.com>
5874
5875         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5876         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5877         (tui_delete_data_content_windows, tui_display_all_data)
5878         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5879         Update.
5880         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5881         * tui/tui-regs.c (tui_last_regs_line_no)
5882         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5883         (tui_show_registers): Update.
5884         (tui_show_register_group): Return void.  Update.
5885         (tui_display_registers_from, tui_display_reg_element_at_line)
5886         (tui_display_registers_from_line, tui_check_register_values):
5887         Update.
5888         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5889         member.
5890         (struct tui_data_window) <regs_content>: Now a std::vector.
5891         <regs_content_count>: Remove.
5892         (tui_add_content_elements, tui_free_data_content): Don't declare.
5893         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5894         (init_content_element): Remove DATA_WIN case.  Add assert.
5895         (tui_add_content_elements): Remove.
5896         (tui_data_window): Update.
5897         (tui_free_data_content): Remove.
5898         (free_content_elements): Remove DATA_WIN case.
5899
5900 2019-06-25  Tom Tromey  <tom@tromey.com>
5901
5902         * tui/tui-data.c (tui_data_item_window): Update.
5903         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5904         * tui/tui-windata.c (tui_display_all_data)
5905         (tui_display_data_from_line): Update.
5906         (tui_check_data_values): Remove.
5907         * tui/tui-regs.c (tui_show_register_group)
5908         (tui_display_reg_element_at_line): Update.
5909         * tui/tui-hooks.c (tui_register_changed)
5910         (tui_refresh_frame_and_register_information): Call
5911         tui_check_register_values.
5912         * tui/tui-data.h (struct tui_data_window) <data_content,
5913         data_content_count, data_type>: Remove.
5914         (enum tui_data_type): Remove.
5915
5916         * tui/tui-data.c (tui_data_window::clear_detail)
5917         (~tui_data_window): Update.
5918
5919 2019-06-25  Tom Tromey  <tom@tromey.com>
5920
5921         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5922         declare.
5923         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5924         Rename from tui_first_data_item_displayed.  Update.
5925         (tui_data_window::refresh_all)
5926         (tui_data_window::do_scroll_vertical): Update.
5927         * tui/tui-data.h (struct tui_data_window)
5928         <first_data_item_displayed>: Declare new method.
5929
5930 2019-06-25  Tom Tromey  <tom@tromey.com>
5931
5932         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5933         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5934         contents...
5935         (tui_initialize_static_data): ...here.
5936
5937 2019-06-25  Tom Tromey  <tom@tromey.com>
5938
5939         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5940         (tui_display_registers_from, tui_check_register_values): Update.
5941         (tui_display_register): Remove win_info parameter; update.
5942         (tui_get_register): Change type of parameters.
5943         * tui/tui-data.h (struct tui_data_element): Remove.
5944         (union tui_which_element) <data>: Remove.
5945         <data_window>: Change type.
5946         (struct tui_data_item_window): New.
5947         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5948         case.  Add assert.
5949         (~tui_data_item_window): New destructor.
5950         (free_content_elements): Remove DATA_ITEM_WIN case.
5951
5952 2019-06-25  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5955         Remove.
5956
5957 2019-06-25  Tom Tromey  <tom@tromey.com>
5958
5959         * tui/tui-data.h (struct tui_command_element): Remove.
5960         (union tui_which_element) <command>: Remove.
5961         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5962         assert.
5963         (free_content_elements): Remove CMD_WIN case.
5964
5965 2019-06-25  Tom Tromey  <tom@tromey.com>
5966
5967         * tui/tui-layout.c (tui_set_layout): Update.
5968         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5969         * tui/tui-data.c (layout_def): Update.
5970
5971 2019-06-25  Tom Tromey  <tom@tromey.com>
5972
5973         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5974         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5975         (tui_source_window_base::set_new_height): Update.
5976         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5977         Update.
5978         (tui_set_locator_fullname, tui_set_locator_info)
5979         (tui_show_frame_info): Update.
5980         * tui/tui-source.c (tui_set_source_content)
5981         (tui_source_is_displayed): Update.
5982         * tui/tui-layout.c (show_source_disasm_command, show_data)
5983         (show_source_or_disasm_and_command): Update.
5984         * tui/tui-disasm.c (tui_set_disassem_content)
5985         (tui_get_begin_asm_address): Update.
5986         * tui/tui-data.h (struct tui_locator_element): Remove.
5987         (union tui_which_element) <locator>: Remove.
5988         (struct tui_locator_window): New.
5989         (tui_locator_win_info_ptr): Change return type.
5990         * tui/tui-data.c (_locator): Change type.
5991         (tui_locator_win_info_ptr): Change return type.
5992         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5993         (tui_alloc_content): Add assert.
5994
5995 2019-06-25  Tom Tromey  <tom@tromey.com>
5996
5997         * tui/tui-winsource.c
5998         (tui_exec_info_window::maybe_allocate_content): New method.
5999         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6000         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6001         (make_source_or_disasm_window): Add cast.
6002         * tui/tui-data.h (union tui_which_element) <simple_string>:
6003         Remove.
6004         (struct tui_source_info): New.
6005         (struct tui_source_window_base) <execution_info>: Change type.
6006         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6007         case, and add assert.
6008         (tui_alloc_content): Add assert.
6009
6010 2019-06-25  Tom Tromey  <tom@tromey.com>
6011
6012         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6013         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6014         * tui/tui-data.c (tui_alloc_win_info): Remove.
6015
6016 2019-06-25  Tom Tromey  <tom@tromey.com>
6017
6018         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6019         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6020         can_highlight.
6021
6022 2019-06-25  Tom Tromey  <tom@tromey.com>
6023
6024         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6025         make_visible_with_new_height method.
6026         (tui_win_info::make_visible_with_new_height): New method.
6027         (tui_source_window_base::do_make_visible_with_new_height)
6028         (tui_data_window::do_make_visible_with_new_height)
6029         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6030         (make_visible_with_new_height): Remove.
6031         (tui_resize_all, tui_adjust_win_heights): Use
6032         make_visible_with_new_height method.
6033         * tui/tui-data.h (struct tui_win_info)
6034         <do_make_visible_with_new_height, make_visible_with_new_height>:
6035         New methods.
6036         (struct tui_source_window_base, struct tui_data_window)
6037         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6038         methods.
6039
6040 2019-06-25  Tom Tromey  <tom@tromey.com>
6041
6042         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6043         method.
6044         (update_tab_width): Call update_tab_width method.
6045         * tui/tui-data.h (struct tui_win_info)
6046         (struct tui_source_window_base) <update_tab_width>: New methods.
6047
6048 2019-06-25  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6051         parameter.
6052         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6053         parameter.
6054         (tui_gen_win_info::make_visible): Update.
6055         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6056         parameter.
6057         * tui/tui-data.h (enum tui_box): New enum.
6058         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6059
6060 2019-06-25  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6063         init_and_make_win for EXEC_INFO_WIN.
6064         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6065         longer inline.
6066         (struct tui_win_info) <~tui_win_info>: Inline.
6067         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6068         Don't declare.
6069         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6070         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6071         Remove.
6072         (tui_initialize_static_data): Update.
6073         (~tui_gen_win_info): Handle more cleanup here.
6074         (~tui_source_window_base): Delete "execution_info".
6075         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6076
6077 2019-06-25  Tom Tromey  <tom@tromey.com>
6078
6079         * tui/tui-layout.c (make_command_window): Don't set
6080         can_highlight.
6081         (show_source_disasm_command): Call the reset method.
6082         (show_data): Don't set can_highlight.  Call the reset method.
6083         (tui_gen_win_info::reset): Rename from init_gen_win_info
6084         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6085         (show_source_or_disasm_and_command): Call the reset method.
6086         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6087         (struct tui_cmd_window): Set can_highlight.
6088
6089 2019-06-25  Tom Tromey  <tom@tromey.com>
6090
6091         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6092         from make_visible.
6093         (tui_make_visible, tui_make_invisible): Rewrite.
6094         (tui_win_info::make_visible): Remove.
6095         (tui_source_window_base::make_visible): Update.
6096         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6097         method.  Moved from...
6098         (struct tui_win_info) <make_visible>: ...here.
6099
6100 2019-06-25  Tom Tromey  <tom@tromey.com>
6101
6102         * tui/tui-winsource.c
6103         (tui_source_window_base::do_scroll_horizontal): Remove direction
6104         parameter.
6105         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6106         direction parameter.
6107         * tui/tui-win.c (tui_win_info::forward_scroll)
6108         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6109         (tui_win_info::right_scroll): Update.
6110         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6111         direction parameter.
6112         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6113         direction parameter.
6114         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6115         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6116         Remove direction parameter.
6117         (struct tui_source_window_base, struct tui_source_window)
6118         (struct tui_disasm_window, struct tui_data_window)
6119         (struct tui_cmd_window): Update.
6120
6121 2019-06-25  Tom Tromey  <tom@tromey.com>
6122
6123         * tui/tui-winsource.h (tui_set_exec_info_content)
6124         (tui_show_exec_info_content, tui_erase_exec_info_content)
6125         (tui_clear_exec_info_content, tui_update_exec_info): Change
6126         argument to tui_source_window_base.
6127         * tui/tui-winsource.c (tui_set_exec_info_content)
6128         (tui_show_exec_info_content, tui_erase_exec_info_content)
6129         (tui_clear_exec_info_content, tui_update_exec_info): Change
6130         argument to tui_source_window_base.
6131
6132 2019-06-25  Tom Tromey  <tom@tromey.com>
6133
6134         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6135         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6136
6137 2019-06-25  Tom Tromey  <tom@tromey.com>
6138
6139         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6140         check.
6141
6142 2019-06-25  Tom Tromey  <tom@tromey.com>
6143
6144         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6145         type to void.
6146         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6147         type to void.
6148         * tui/tui-source.c (tui_set_source_content): Update.
6149         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6150
6151 2019-06-25  Tom Tromey  <tom@tromey.com>
6152
6153         * tui/tui-win.c (window_name_completer, tui_set_focus)
6154         (tui_all_windows_info): Use name method.
6155         * tui/tui-data.h (struct tui_gen_win_info)
6156         (struct tui_source_window, struct tui_disasm_window)
6157         (struct tui_data_window, struct tui_cmd_window) <name>: New
6158         method.
6159         (tui_win_name): Don't declare.
6160         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6161         (tui_win_name): Remove.
6162
6163 2019-06-25  Tom Tromey  <tom@tromey.com>
6164
6165         * tui/tui-winsource.h (tui_update_source_window)
6166         (tui_update_source_window_as_is): Change parameter type.
6167         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6168         to be a tui_source_window_base.
6169         (tui_update_source_window_as_is): Likewise.
6170         * tui/tui-win.c (make_visible_with_new_height): Update.
6171
6172 2019-06-25  Tom Tromey  <tom@tromey.com>
6173
6174         * tui/tui-winsource.c (tui_erase_source_content)
6175         (tui_show_source_content, tui_show_exec_info_content)
6176         (tui_erase_exec_info_content): Use refresh_window method.
6177         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6178         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6179         from tui_refresh_win.
6180         (tui_data_window::refresh_window): New method.
6181         (tui_win_info::refresh, tui_source_window_base::refresh)
6182         (tui_refresh_all): Use refresh_window method.
6183         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6184         method.
6185         * tui/tui-regs.c (tui_display_register): Call refresh_window
6186         method.
6187         * tui/tui-layout.c (show_source_disasm_command)
6188         (show_source_or_disasm_and_command): Call refresh_window method.
6189         * tui/tui-data.h (struct tui_gen_win_info)
6190         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6191         New method.
6192
6193 2019-06-25  Tom Tromey  <tom@tromey.com>
6194
6195         * tui/tui.c (tui_rl_other_window, tui_enable)
6196         (tui_is_window_visible, tui_get_command_dimension): Update.
6197         * tui/tui-winsource.c (tui_update_source_window_as_is)
6198         (tui_clear_source_content, tui_erase_source_content)
6199         (tui_show_source_line, tui_source_window_base::refill)
6200         (tui_source_window_base::do_scroll_horizontal)
6201         (tui_source_window_base::set_is_exec_point_at)
6202         (tui_update_breakpoint_info, tui_set_exec_info_content)
6203         (tui_alloc_source_buffer, tui_line_is_displayed)
6204         (tui_addr_is_displayed): Update.
6205         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6206         (tui_check_and_display_highlight_if_needed)
6207         (tui_win_info::make_visible, tui_win_info::refresh)
6208         (tui_refresh_all): Update.
6209         * tui/tui-windata.c (tui_first_data_item_displayed)
6210         (tui_delete_data_content_windows, tui_erase_data_content)
6211         (tui_display_all_data, tui_data_window::refresh_all)
6212         (tui_check_data_values): Update.
6213         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6214         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6215         (tui_win_info::backward_scroll, tui_refresh_all_win)
6216         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6217         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6218         (tui_source_window_base::set_new_height)
6219         (tui_data_window::set_new_height)
6220         (make_invisible_and_set_new_height)
6221         (make_visible_with_new_height, new_height_ok)
6222         (parse_scrolling_args): Update.
6223         * tui/tui-stack.c (tui_show_frame_info): Update.
6224         * tui/tui-source.c (tui_set_source_content)
6225         (tui_set_source_content_nil, tui_source_is_displayed)
6226         (tui_source_window::do_scroll_vertical): Update.
6227         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6228         (tui_display_registers_from, tui_display_reg_element_at_line)
6229         (tui_check_register_values, tui_reg_command): Update.
6230         * tui/tui-layout.c (tui_default_win_height)
6231         (show_source_disasm_command, show_data, init_and_make_win)
6232         (show_source_or_disasm_and_command): Update.
6233         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6234         (tui_redisplay_readline, tui_mld_flush)
6235         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6236         (tui_getc): Update.
6237         * tui/tui-disasm.c (tui_set_disassem_content)
6238         (tui_disasm_window::do_scroll_vertical): Update.
6239         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6240         Now virtual.
6241         (struct tui_win_info): Derive from tui_gen_win_info.
6242         <~tui_win_info>: Mark as override.
6243         <generic>: Remove member.
6244         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6245         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6246         (~tui_data_window, ~tui_win_info)
6247         (tui_free_all_source_wins_content): Update.
6248         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6249
6250 2019-06-25  Tom Tromey  <tom@tromey.com>
6251
6252         * tui/tui-layout.c (init_and_make_win): Use new.
6253         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6254         destructor, initializers.
6255         (tui_alloc_generic_win_info): Don't declare.
6256         * tui/tui-data.c (_locator): Add argument to constructor.
6257         (source_win, disasm_win): New globals.
6258         (exec_info): Remove.
6259         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6260         Update.
6261         (tui_alloc_generic_win_info): Remove.
6262         (init_content_element): Use new.
6263         (tui_win_info::tui_win_info): Update.
6264         (free_content_elements) <case DATA_WIN>: Use delete.
6265
6266 2019-06-25  Tom Tromey  <tom@tromey.com>
6267
6268         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6269         * tui/tui-windata.c (tui_first_data_item_displayed)
6270         (tui_delete_data_content_windows): Update.
6271         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6272         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6273         (tui_display_registers_from, tui_check_register_values): Update.
6274         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6275         pointer.
6276         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6277         window.
6278         (tui_free_data_content): Update.
6279         (free_content_elements) <case DATA_WIN>: Free the window.
6280
6281 2019-06-25  Tom Tromey  <tom@tromey.com>
6282
6283         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6284         Update.
6285         * tui/tui-layout.c (make_command_window)
6286         (show_source_disasm_command, show_data, init_and_make_win)
6287         (show_source_or_disasm_and_command): Update.
6288         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6289         method.
6290         <can_highight, is_highlighted>: Now bool.
6291         (tui_set_win_highlight): Don't declare.
6292         * tui/tui-data.c (tui_set_win_highlight): Remove.
6293
6294 2019-06-25  Tom Tromey  <tom@tromey.com>
6295
6296         * tui/tui-wingeneral.c (make_visible): Remove check of window
6297         type.
6298
6299 2019-06-25  Tom Tromey  <tom@tromey.com>
6300
6301         * tui/tui-win.c (tui_win_info::max_height)
6302         (tui_cmd_window::max_height): New methods.
6303         (new_height_ok): Call max_height.
6304         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6305         <max_height>: New method.
6306
6307 2019-06-25  Tom Tromey  <tom@tromey.com>
6308
6309         * tui/tui-win.c (tui_source_window_base::set_new_height)
6310         (tui_data_window::set_new_height): New methods.
6311         (make_invisible_and_set_new_height): Call set_new_height method.
6312         * tui/tui-data.h (struct tui_win_info)
6313         (struct tui_source_window_base, struct tui_data_window)
6314         <set_new_height>: New method.
6315
6316 2019-06-25  Tom Tromey  <tom@tromey.com>
6317
6318         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6319         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6320         tui_refresh_data_win.
6321         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6322         method.
6323         (tui_refresh_all_win): Call the refresh_all method.
6324         (tui_set_focus): Likewise.
6325         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6326         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6327         Likewise.
6328
6329 2019-06-25  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-winsource.h (tui_refill_source_window)
6332         (tui_set_is_exec_point_at): Don't declare.
6333         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6334         (tui_source_window_base::refill): Rename from
6335         tui_refill_source_window.
6336         (tui_source_window_base::do_scroll_horizontal): Update.
6337         (tui_source_window_base::set_is_exec_point_at): Rename from
6338         tui_set_is_exec_point_at.
6339         (tui_update_all_breakpoint_info): Update.
6340         * tui/tui-stack.c (tui_show_frame_info): Update.
6341         * tui/tui-layout.c (show_data): Add cast.
6342         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6343         * tui/tui-data.h (struct tui_source_window_base) <refill,
6344         set_is_exec_point_at>: New methods.
6345         (tui_source_windows, tui_add_to_source_windows): Update types.
6346         (tui_add_to_source_windows): Remove redundant declaration.
6347         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6348         (tui_source_windows): Change return type.
6349         (tui_clear_source_windows_detail): Update.
6350         (tui_add_to_source_windows): Change type of parameter.
6351         (tui_free_all_source_wins_content): Update.
6352
6353 2019-06-25  Tom Tromey  <tom@tromey.com>
6354
6355         * tui/tui-wingeneral.c (tui_win_info::refresh)
6356         (tui_source_window_base::refresh): New methods.
6357         (tui_refresh_all): Call the refresh method.
6358         * tui/tui-data.h (struct tui_win_info)
6359         (struct tui_source_window_base) <refresh>: New method.
6360
6361 2019-06-25  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui.h (tui_is_window_visible): Return bool.
6364         * tui/tui.c (tui_is_window_visible): Return bool.
6365         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6366         (tui_make_visible, tui_make_invisible)
6367         (tui_win_info::make_visible)
6368         (tui_source_window_base::make_visible, make_all_visible)
6369         (tui_make_all_visible, tui_make_all_invisible): Update.
6370         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6371         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6372         bool.
6373         (struct tui_win_info, struct tui_source_window_base)
6374         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6375         * tui/tui-data.c (tui_init_generic_part): Update.
6376
6377 2019-06-25  Tom Tromey  <tom@tromey.com>
6378
6379         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6380         (tui_source_window_base::make_visible): New methods.
6381         (make_all_visible): Make method call.
6382         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6383         (struct tui_source_window_base, struct tui_cmd_window): Override
6384         make_visible.
6385         (tui_win_is_source_type): Don't declare.
6386         * tui/tui-data.c (tui_win_is_source_type): Remove.
6387
6388 2019-06-25  Tom Tromey  <tom@tromey.com>
6389
6390         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6391         NULL check.
6392
6393 2019-06-25  Tom Tromey  <tom@tromey.com>
6394
6395         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6396         Inline constructor.  Add initializers for members.
6397         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6398         constructors; now inline in class.
6399
6400 2019-06-25  Tom Tromey  <tom@tromey.com>
6401
6402         * tui/tui-regs.c (tui_show_registers): Update.
6403         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6404         bool.
6405         * tui/tui-data.c (tui_data_window::clear_detail)
6406         (tui_data_window): Update.
6407
6408 2019-06-25  Tom Tromey  <tom@tromey.com>
6409
6410         * tui/tui-windata.c (tui_display_all_data)
6411         (tui_display_data_from_line, tui_display_data_from)
6412         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6413         Update.
6414         * tui/tui-regs.c (tui_last_regs_line_no)
6415         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6416         (tui_show_registers, tui_show_register_group)
6417         (tui_display_registers_from, tui_display_reg_element_at_line)
6418         (tui_display_registers_from_line, tui_check_register_values)
6419         (tui_reg_next, tui_reg_prev): Update.
6420         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6421         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6422         tui_data_window.
6423         (struct tui_win_info) <detail>: Remove.  Add new fields from
6424         tui_data_info.
6425         (TUI_DATA_WIN): Add cast.
6426         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6427         (~tui_data_window): Simplify.
6428
6429 2019-06-25  Tom Tromey  <tom@tromey.com>
6430
6431         * tui/tui-layout.c (show_source_disasm_command)
6432         (show_source_or_disasm_and_command): Update.
6433         * tui/tui-io.c (update_cmdwin_start_line)
6434         (tui_redisplay_readline): Update.
6435         * tui/tui-data.h (struct tui_command_info): Remove.
6436         (struct tui_win_info) <detail>: Remove command_info member.
6437         (struct tui_data_window) <start_line>: New member, from
6438         tui_command_info.
6439         (TUI_CMD_WIN): Add casts.
6440
6441 2019-06-25  Tom Tromey  <tom@tromey.com>
6442
6443         * tui/tui-winsource.c (tui_update_source_window)
6444         (tui_refill_source_window)
6445         (tui_source_window_base::do_scroll_horizontal)
6446         (tui_update_breakpoint_info, tui_set_exec_info_content)
6447         (tui_show_exec_info_content, tui_erase_exec_info_content)
6448         (tui_clear_exec_info_content): Update.
6449         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6450         Update.
6451         * tui/tui-win.c (make_invisible_and_set_new_height)
6452         (make_visible_with_new_height): Update.
6453         * tui/tui-source.c (tui_set_source_content)
6454         (tui_show_symtab_source): Update.
6455         * tui/tui-layout.c (extract_display_start_addr)
6456         (show_source_disasm_command, show_data)
6457         (make_source_or_disasm_window)
6458         (show_source_or_disasm_and_command): Update.
6459         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6460         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6461         "gdbarch".
6462         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6463         to tui_source_window_base.
6464         (struct tui_win_info) <detail>: Remove source_info member.
6465         (struct tui_source_window_base) <has_locator>: Inline.
6466         Move contents from tui_source_info; rename has_locator member to
6467         m_has_locator.
6468         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6469         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6470         header file.
6471         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6472         Simplify.
6473         (tui_free_all_source_wins_content): Cast to
6474         tui_source_window_base.
6475
6476 2019-06-25  Tom Tromey  <tom@tromey.com>
6477
6478         * tui/tui-win.c (make_invisible_and_set_new_height)
6479         (make_visible_with_new_height): Call has_locator method.
6480         * tui/tui-layout.c (show_source_disasm_command, show_data)
6481         (show_source_or_disasm_and_command): Update for bool change.
6482         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6483         (tui_win_info) <has_locator>: New method.
6484         (struct tui_source_window_base) <has_locator>: New method.
6485         (tui_win_has_locator): Don't declare.
6486         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6487         from tui_win_has_locator.
6488         (tui_source_window_base): Use false, not FALSE.
6489
6490 2019-06-25  Tom Tromey  <tom@tromey.com>
6491
6492         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6493         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6494         clear_detail method directly.
6495         (tui_clear_win_detail): Remove.
6496
6497 2019-06-25  Tom Tromey  <tom@tromey.com>
6498
6499         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6500         "this", not TUI_DISASM_WIN.
6501
6502 2019-06-25  Tom Tromey  <tom@tromey.com>
6503
6504         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6505         declare.
6506         * tui/tui-winsource.c
6507         (tui_source_window_base::do_scroll_horizontal): Rename from
6508         tui_horizontal_source_scroll.
6509         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6510         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6511         from tui_vertical_data_scroll.
6512         * tui/tui-win.h (tui_scroll): Don't declare.
6513         * tui/tui-win.c (tui_win_info::forward_scroll)
6514         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6515         (tui_win_info::right_scroll): Rename and update.
6516         (tui_scroll_forward_command, tui_scroll_backward_command)
6517         (tui_scroll_left_command, tui_scroll_right_command): Update.
6518         (tui_scroll): Remove.
6519         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6520         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6521         from tui_vertical_source_scroll.
6522         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6523         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6524         from tui_vertical_disassem_scroll.
6525         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6526         do_scroll_horizontal>: New methods.
6527         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6528         Likewise.
6529         (struct tui_source_window_base): Add do_scroll_horizontal.
6530         (struct tui_source_window, struct tui_disasm_window): Add
6531         do_scroll_vertical.
6532         (struct tui_data_window, struct tui_cmd_window): Add
6533         do_scroll_horizontal and do_scroll_vertical.
6534         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6535
6536 2019-06-25  Tom Tromey  <tom@tromey.com>
6537
6538         * tui/tui-data.h (struct tui_source_window_base): New struct.
6539         (struct tui_source_window): Derive from tui_source_window_base.
6540         (struct tui_disasm_window): New struct.
6541         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6542         from tui_source_window::clear_detail.
6543         (tui_source_window_base): Rename from tui_source_window.
6544         (~tui_source_window_base): Rename from ~tui_source_window.
6545         (tui_alloc_win_info): Create a tui_disasm_window.
6546
6547 2019-06-25  Tom Tromey  <tom@tromey.com>
6548
6549         * tui/tui-data.h (struct tui_source_window)
6550         (struct tui_data_window): Declare destructors.
6551         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6552         destructors.
6553         (tui_win_info): Simplify.
6554
6555 2019-06-25  Tom Tromey  <tom@tromey.com>
6556
6557         * tui/tui-winsource.c (tui_display_main)
6558         (tui_update_source_windows_with_addr)
6559         (tui_update_all_breakpoint_info): Update.
6560         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6561         (new_height_ok, parse_scrolling_args): Update.
6562         * tui/tui-stack.c (tui_show_frame_info): Update.
6563         * tui/tui-data.h (struct tui_list): Remove.
6564         (tui_source_windows): Return a reference to a std::vector.
6565         * tui/tui-data.c (source_windows): Now a std::vector.
6566         (tui_source_windows): Change return type.
6567         (tui_clear_source_windows): Rewrite.
6568         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6569         (tui_free_all_source_wins_content): Rewrite.
6570
6571 2019-06-25  Tom Tromey  <tom@tromey.com>
6572
6573         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6574         (struct tui_data_window, struct tui_cmd_window): Declare
6575         clear_detail method.
6576         * tui/tui-data.c (tui_source_window::clear_detail)
6577         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6578         methods.
6579         (tui_clear_win_detail): Simplify.
6580
6581 2019-06-25  Tom Tromey  <tom@tromey.com>
6582
6583         * tui/tui-layout.c (make_source_window, make_disasm_window)
6584         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6585         Return the new window.
6586         (show_source_disasm_command, show_data)
6587         (show_source_or_disasm_and_command): Update.
6588
6589 2019-06-25  Tom Tromey  <tom@tromey.com>
6590
6591         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6592         parameter.  Return the new window.
6593         (show_source_disasm_command): Update and remove NULL check.
6594         (show_source_or_disasm_and_command): Update.
6595
6596 2019-06-25  Tom Tromey  <tom@tromey.com>
6597
6598         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6599
6600 2019-06-25  Tom Tromey  <tom@tromey.com>
6601
6602         * tui/tui-data.h (struct tui_win_info): Make constructor
6603         protected.  Make destructor virtual.  Add initializers.
6604         (tui_source_window, tui_data_window, tui_cmd_window): New
6605         classes.
6606         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6607         constructor.  Add "type" parameter.
6608         (tui_source_window, tui_data_window, tui_cmd_window): New
6609         constructors.
6610         (tui_alloc_win_info): Instantiate the appropriate subclass.
6611
6612 2019-06-25  Tom Tromey  <tom@tromey.com>
6613
6614         * tui/tui-win.c (tui_resize_all): Use delete.
6615         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6616         destructor.
6617         (tui_free_window): Don't declare.
6618         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6619         Update.
6620
6621 2019-06-25  Tom Tromey  <tom@tromey.com>
6622
6623         * tui/tui-data.h (struct tui_win_info): Add constructor.
6624         * tui/tui-data.c (tui_alloc_win_info): Use new.
6625         (tui_free_window): Use delete.
6626
6627 2019-06-22  Tom Tromey  <tom@tromey.com>
6628
6629         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6630         declare.
6631         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6632
6633 2019-06-22  Tom Tromey  <tom@tromey.com>
6634
6635         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6636         declare.
6637         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6638
6639 2019-06-22  Tom de Vries  <tdevries@suse.de>
6640
6641         * dwarf2read.c (create_addrmap_from_aranges)
6642         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6643         instead of '%zu'.
6644
6645 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6646
6647         * dwarf2read.h (dwarf2_section_info_def): Remove.
6648         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6649         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6650         std::vector<dwarf2_section_info>.
6651         (struct dwo_file) <~dwo_file>: Remove.
6652         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6653         types field.
6654         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6655         (dwarf2_read_debug_names): Likewise.
6656         (create_debug_types_hash_table): Change parameter type to
6657         array_view, adjust code accordingly.
6658         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6659         (partial_die_info::fixup): Likewise.
6660         (determine_prefix): Likewise.
6661         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6662
6663 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6664
6665         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6666         gdb_bfd_ref_ptr.
6667         <~dwo_file>: Remove call to gdb_bfd_unref.
6668         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6669         gdb_bfd_ref_ptr::get.
6670
6671 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6672
6673         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6674         type to htab_up.
6675         * dwarf2read.c (struct dwo_file): Initialize fields.
6676         <~dwo_file>: New.
6677         (free_dwo_file): Remove, move content to ~dwo_file.
6678         (struct dwo_file_deleter): Remove.
6679         (dwo_file_up>: Remove custom deleter.
6680         (free_dwo_files): Remove.
6681         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6682         dwo_files.
6683         (process_skeletonless_type_units): Call unique_ptr::get.
6684         (allocate_dwo_file_hash_table): Add deleter to created hash
6685         table.  Change return type to htab_up.
6686         (lookup_dwo_file_slot): Don't memset dwo_file, call
6687         unique_ptr::get.
6688         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6689         (create_dwo_unit_in_dwp_v2): Likewise.
6690         (open_and_init_dwo_file): Likewise.
6691         (free_dwo_file_from_slot): Remove.
6692
6693 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6694
6695         * dwarf2read.h (struct dwarf2_section_info) <readin,
6696         is_virtual>: Change type to bool.
6697         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6698         true instead of 1.
6699
6700 2019-06-19  Tom Tromey  <tom@tromey.com>
6701
6702         * tui/tui-data.h (tui_init_content_element): Don't declare.
6703
6704 2019-06-19  Tom Tromey  <tom@tromey.com>
6705
6706         * tui/tui-data.h (tui_init_win_info): Don't declare.
6707
6708 2019-06-19  Tom de Vries  <tdevries@suse.de>
6709
6710         * dwarf2read.h (abstract_to_concrete): Change type to
6711         std::unordered_map<sect_offset, std::vector<sect_offset>,
6712         gdb::hash_enum<sect_offset>>.
6713
6714 2019-06-19  Tom Tromey  <tromey@adacore.com>
6715
6716         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6717         EVAL_AVOID_SIDE_EFFECTS specially.
6718
6719 2019-06-19  Tom Tromey  <tromey@adacore.com>
6720
6721         * source-cache.c (highlighter): New global.
6722         (source_cache::get_source_lines): Create a highlighter on demand.
6723
6724 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6725
6726         * defs.h (deprecated_interactive_hook): Delete declaration.
6727         * interps.c (clear_interpreter_hooks): Remove use of
6728         deprecated_interactive_hook.
6729         * top.c (deprecated_interactive_hook): Delete definition.
6730         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6731
6732 2019-06-18  Tom de Vries  <tdevries@suse.de>
6733
6734         PR gdb/24515
6735         * dwarf2read.h (abstract_to_concrete): Change type from
6736         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6737         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6738         * dwarf2read.c (read_variable): Update.
6739         (dwarf2_fetch_die_loc_sect_off): Update.
6740
6741 2019-06-17  Tom de Vries  <tdevries@suse.de>
6742
6743         PR gdb/24617
6744         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6745         accessing parent[parent_len - 1].
6746
6747 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6748
6749         PR gdb/24364
6750         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6751         call dtrace_process_dof with NULL dof.
6752
6753 2019-06-16  Tom de Vries  <tdevries@suse.de>
6754
6755         PR gdb/24445
6756         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6757
6758 2019-06-16  Tom Tromey  <tom@tromey.com>
6759
6760         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6761         (make_all_visible): Use address of member.
6762
6763 2019-06-16  Tom Tromey  <tom@tromey.com>
6764
6765         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6766         (tui_free_window, free_content, free_content_elements): Remove
6767         unnecessary cast.
6768         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6769         cast.
6770         * tui/tui-regs.c (tui_show_register_group)
6771         (tui_display_registers_from, tui_display_reg_element_at_line):
6772         Remove unnecessary cast.
6773
6774 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6775
6776         * linux-nat.c (normal_mask): Delete.
6777         (_initialize_linux_nat): Don't initialise normal_mask.
6778
6779 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6780
6781         PR gdb/24445
6782         * dwarf-index-write.h (write_psymtabs_to_index): Add
6783         dwz_basename parameter.
6784         * dwarf-index-write.c (write_gdbindex): Move file writing to
6785         write_gdbindex_1.  Change return type void.
6786         (assert_file_size): Move up, remove filename parameter.
6787         (write_gdbindex_1): New function.
6788         (write_debug_names): Change return type to void, call
6789         assert_file_size.
6790         (struct index_wip_file): New struct.
6791         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6792         file logic to index_wip_file.  Write index for dwz file if
6793         needed.
6794         (save_gdb_index_command): Pass basename of dwz file, if present.
6795         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6796         build-id of dwz file, if present.
6797         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6798         (dwarf2_get_dwz_file): Likewise.
6799         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6800         (dwarf2_get_dwz_file): Likewise.
6801
6802 2019-06-16  Tom Tromey  <tom@tromey.com>
6803
6804         * coffread.c (process_coff_symbol): Use xstrdup.
6805         * value.c (create_internalvar): Use xstrdup.
6806
6807 2019-06-16  Tom Tromey  <tom@tromey.com>
6808
6809         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6810         * breakpoint.c (stopin_command, stopat_command)
6811         (until_break_command, decode_location_default): Remove unnecessary
6812         cast.
6813         * utils.c (subset_compare): Remove unnecessary cast.
6814         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6815         cast.
6816         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6817         cast.
6818         * infcmd.c (path_command): Remove unnecessary cast.
6819         * coffread.c (decode_type): Remove unnecessary cast.
6820         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6821         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6822         * tui/tui-stack.c (tui_show_locator_content)
6823         (tui_show_frame_info): Remove unnecessary cast.
6824         * tui/tui-win.c (tui_scroll_forward_command)
6825         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6826         (parse_scrolling_args): Remove unnecessary cast.
6827         * tui/tui-data.c (init_win_info, tui_del_window)
6828         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6829         (free_content_elements): Remove unnecessary cast.
6830         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6831         unnecessary cast.
6832         * tui/tui-source.c (tui_set_source_content)
6833         (tui_vertical_source_scroll): Remove unnecessary cast.
6834         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6835         cast.
6836         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6837         * tui/tui-regs.c (tui_display_registers_from)
6838         (tui_display_register): Remove unnecessary cast.
6839         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6840         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6841         (make_visible): Remove unnecessary cast.
6842         * tui/tui-winsource.c (tui_erase_source_content)
6843         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6844         unnecessary cast.
6845         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6846         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6847         * stabsread.c (read_type, read_array_type, read_range_type):
6848         Remove unnecessary cast.
6849         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6850         (parse_symbol, parse_type, upgrade_type, parse_external)
6851         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6852         unnecessary cast.
6853         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6854
6855 2019-06-16  Tom Tromey  <tom@tromey.com>
6856
6857         * tui/tui-data.c (tui_alloc_generic_win_info)
6858         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6859         checks.
6860
6861 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6862             Andrew Burgess  <andrew.burgess@embecosm.com>
6863
6864         * f-typeprint.c (f_print_type): Don't return early for not
6865         associated or not allocated types.
6866         (f_type_print_varspec_suffix): Add print_rank parameter and print
6867         ranks of array types in case they dangling.
6868         (f_type_print_base): Add print_rank parameter.
6869
6870 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6871
6872         * NEWS: Mention new MI commands.
6873         * break-catch-throw.c (enum exception_event_kind): Move to
6874         breakpoint.h.
6875         (print_mention_exception_catchpoint): Output text as a single
6876         message.
6877         (catch_exception_command_1): Rename to...
6878         (catch_exception_event): ...this, make non-static, update header
6879         command, and change some parameter types.
6880         (catch_catch_command): Update for changes to
6881         catch_exception_command_1.
6882         (catch_throw_command): Likewise.
6883         (catch_rethrow_command): Likewise.
6884         * breakpoint.c (enum exception_event_kind): Delete.
6885         * breakpoint.h (enum exception_event_kind): Moved here from
6886         break-catch-throw.c.
6887         (catch_exception_event): Declare.
6888         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6889         (mi_cmd_catch_throw): New function.
6890         (mi_cmd_catch_rethrow): New function.
6891         (mi_cmd_catch_catch): New function.
6892         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6893         'catch-catch' entries.
6894         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6895         (mi_cmd_catch_rethrow): Declare.
6896         (mi_cmd_catch_catch): Declare.
6897
6898 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6899
6900         * annotate.c (annotate_source_line): Change return type to void,
6901         update implementation to match.
6902         * annotate.h (annotate_source_line): Change return type to void,
6903         update header comment.
6904         * stack.c (print_frame_info): Don't change what frame information
6905         is printed based on whether annotations are on or not.
6906
6907 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6908
6909         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6910         (annotate_source): Make static.
6911         (annotate_source_line): Moved from source.c and renamed from
6912         identify_source_line.  Update the return type.
6913         * annotate.h (annotate_source): Delete declaration.
6914         (annotate_source_line): Declaration moved from source.h, and
6915         renamed from identify_source_line.  Return type updated.
6916         * source.c (identify_source_line): Moved to annotate.c and renamed
6917         to annotate_source_line.
6918         (info_line_command): Remove check of annotation_level.
6919         * source.h (identify_source_line): Move declaration to annotate.h
6920         and rename to annotate_source_line.
6921         * stack.c: Add 'annotate.h' include.
6922         (print_frame_info): Remove check of annotation_level before
6923         calling annotate_source_line.
6924
6925 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * source-cache.c (source_cache::get_plain_source_lines): Use
6928         open_source_file_with_line_charpos instead of just
6929         open_source_file, remove call to find_source_lines.
6930         (source_cache::get_source_lines): Likewise.
6931         * source.c (find_source_lines): Make static.
6932         (get_filename_and_charpos): Renamed into...
6933         (open_source_file_with_line_charpos): ..this along with changes to
6934         return a scoped_fd, and some other minor clean ups.
6935         (identify_source_line): Use open_source_file_with_line_charpos.
6936         (search_command_helper): Use open_source_file_with_line_charpos
6937         instead of just open_source_file, remove call to
6938         find_source_lines.
6939         * source.h (open_source_file_with_line_charpos): Declare new
6940         function.
6941         (find_source_lines): Delete declaration.
6942
6943 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6944
6945         * source.c (get_filename_and_charpos): Remove fullname
6946         parameter.
6947         (identify_source_line): Update call to get_filename_and_charpos.
6948
6949 2019-06-14  Tom Tromey  <tromey@adacore.com>
6950
6951         PR gdb/24502:
6952         * ui-style.h (skip_ansi_escape): Update comment.
6953         * ui-file.h (class no_terminal_escape_file): New class.
6954         * ui-file.c (no_terminal_escape_file::write)
6955         (no_terminal_escape_file::puts): New methods.
6956         * cli/cli-logging.c (handle_redirections): Use
6957         no_terminal_escape_file.
6958
6959 2019-06-14  Tom Tromey  <tromey@adacore.com>
6960
6961         * NEWS: Move convenience variable news above Python news.
6962
6963 2019-06-14  Tom Tromey  <tom@tromey.com>
6964
6965         * gnulib: Move directory to top-level.
6966         * configure.ac: Don't configure gnulib.
6967         * configure: Rebuild.
6968         * common/common-defs.h: Use new path to gnulib.
6969         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6970         (GNULIB_H): Remove.
6971         (INCGNU): Look in new gnulib location.
6972         (HFILES_NO_SRCDIR): Remove gnulib files.
6973         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6974         (generated_files): Remove GNULIB_H.
6975         ($(LIBGNU), all-lib): Remove targets.
6976         (distclean): Don't mention GNULIB_BUILDDIR.
6977         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6978
6979 2019-06-14  Tom Tromey  <tromey@adacore.com>
6980
6981         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6982         Warn if symbol file does not provide any symbols.
6983
6984 2019-06-14  Tom Tromey  <tromey@adacore.com>
6985
6986         * source.c (find_and_open_source): Respect basenames_may_differ.
6987
6988 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6989
6990         * annotate.c (annotate_breakpoints_invalid): Make use of
6991         scoped_restore_terminal_state.
6992         (annotate_frames_invalid): Likewise.
6993
6994 2019-06-14  Tom Tromey  <tromey@adacore.com>
6995
6996         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6997         allow assignment to an internalvar.
6998
6999 2019-06-14  Tom Tromey  <tromey@adacore.com>
7000
7001         * ada-lex.l: Allow "_" in attribute names.
7002
7003 2019-06-14  Tom Tromey  <tromey@adacore.com>
7004
7005         PR gdb/24653:
7006         * regcache.c (registers_changed): Don't call alloca.
7007         * top.c (execute_command): Don't call alloca.
7008
7009 2019-06-13  Pedro Alves  <palves@redhat.com>
7010
7011         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7012         'expression'.  When parsing an expression, error out if there's
7013         junk after "unlimited".
7014         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7015         (do_set_command): Adjust calls to is_unlimited_literal.
7016
7017 2019-06-13  Pedro Alves  <palves@redhat.com>
7018
7019         * compile/compile.c (make_compile_options_def_group): Add braces
7020         around array_view initializer.
7021         * thread.c (make_thread_apply_all_options_def_group)
7022         (make_thread_apply_all_options_def_group): Likewise.
7023
7024 2019-06-13  Pedro Alves  <palves@redhat.com>
7025
7026         * NEWS (New commands): Mention "maint test-options
7027         require-delimiter", "maint test-options unknown-is-error", "maint
7028         test-options unknown-is-operand" and "maint show
7029         test-options-completion-result".
7030         (New command options, command completion): New section.
7031         (Completion improvements): New section.
7032         Mention that you can abbreviate "unlimited".
7033
7034 2019-06-13  Pedro Alves  <palves@redhat.com>
7035
7036         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7037         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7038         * unittests/cli-utils-selftests.c (test_parse_flags)
7039         (test_parse_flags_qcs): Delete.
7040         (test_cli_utils): Don't call deleted functions.
7041
7042 2019-06-13  Pedro Alves  <palves@redhat.com>
7043
7044         * thread.c: Include "cli/cli-option.h".
7045         (tp_array_compar_ascending): Global.
7046         (tp_array_compar): Delete function.
7047         (tp_array_compar_ascending, tp_array_compar_descending): New
7048         functions.
7049         (ascending_option_def, qcs_flag_option_def)
7050         (thr_qcs_flags_option_defs)
7051         (make_thread_apply_all_options_def_group)
7052         (make_thread_apply_options_def_group): New.
7053         (thread_apply_all_command): Use gdb::option::process_options.
7054         (thread_apply_command_completer)
7055         (thread_apply_all_command_completer): New.
7056         (thread_apply_command): Use gdb::option::process_options.
7057         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7058         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7059         to generate help text of "thread apply".  Adjust "taas"'s help.
7060         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7061         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7062
7063 2019-06-13  Pedro Alves  <palves@redhat.com>
7064
7065         * thread.c (thread_apply_command): Check for invalid TID with
7066         isdigit instead of !isalpha.
7067
7068 2019-06-13  Pedro Alves  <palves@redhat.com>
7069
7070         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7071         (validate_flags_qcs): New.
7072         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7073         (validate_flags_qcs): Declare.
7074         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7075         (make_frame_apply_options_def_group): New.
7076         (frame_apply_command_count): Process options with
7077         gdb::option::process_options.
7078         (frame_apply_completer): New.
7079         (frame_apply_level_completer, frame_apply_all_completer)
7080         (frame_apply_completer): New.
7081         (_initialize_stack): Update help of "frame apply", "frame apply
7082         level", "frame apply all" and "faas" to mention supported options
7083         and install command completers.
7084         * stack.h (frame_apply_all_completer): Declare.
7085         * thread.c: Include "stack.h".
7086         (tfaas_command): Add "--".
7087         (_initialize_thread): Update help "tfaas" to mention supported
7088         options and install command completer.
7089
7090 2019-06-13  Pedro Alves  <palves@redhat.com>
7091
7092         * completer.c (complete_nested_command_line): New.
7093         (gdb_completion_word_break_characters_throw): Add assertion.
7094         * completer.h (complete_nested_command_line): Declare.
7095
7096 2019-06-13  Pedro Alves  <palves@redhat.com>
7097
7098         * stack.c (parse_backtrace_qualifiers): New.
7099         (backtrace_command): Use it.
7100         (backtrace_command_completer): Complete on qualifiers.
7101
7102 2019-06-13  Pedro Alves  <palves@redhat.com>
7103
7104         * frame.c: Include "cli/cli-option.h.
7105         (user_set_backtrace_options): New.
7106         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7107         Delete.
7108         (get_prev_frame): Adjust.
7109         (boolean_option_def, uinteger_option_def)
7110         (set_backtrace_option_defs): New.
7111         (_initialize_frame): Adjust and use
7112         gdb::option::add_setshow_cmds_for_options to install "set
7113         backtrace past-main" and "set backtrace past-entry".
7114         * frame.h: Include "cli/cli-option.h".
7115         (struct frame_print_options): Forward declare.
7116         (print_frame_arguments_all, print_frame_arguments_scalars)
7117         (print_frame_arguments_none): Declare.
7118         (print_entry_values): Delete declaration.
7119         (struct frame_print_options, user_frame_print_options): New.
7120         (struct set_backtrace_options): New.
7121         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7122         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7123         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7124         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7125         (list_args_or_locals): Add frame_print_options parameter.
7126         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7127         * python/py-framefilter.c (enumerate_args): Pass down
7128         USER_FRAME_PRINT_OPTIONS.
7129         * stack.c: Include "cli/cli-option.h".
7130         (print_frame_arguments_all, print_frame_arguments_scalars)
7131         (print_frame_arguments_none): Declare.
7132         (print_raw_frame_arguments, print_entry_values): Delete.
7133         (user_frame_print_options): New.
7134         (boolean_option_def, enum_option_def, frame_print_option_defs):
7135         New.
7136         (struct backtrace_cmd_options): New.
7137         (bt_flag_option_def): New.
7138         (backtrace_command_option_defs): New.
7139         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7140         (print_frame_arg, read_frame_arg, print_frame_args)
7141         (print_frame_info, print_frame): Add frame_print_options parameter
7142         and use it.
7143         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7144         (backtrace_command_1): Add frame_print_options and
7145         backtrace_cmd_options parameters and use them.
7146         (make_backtrace_options_def_group): New.
7147         (backtrace_command): Process command options with
7148         gdb::option::process_options.
7149         (backtrace_command_completer): New.
7150         (_initialize_stack): Extend "backtrace"'s help to mention
7151         supported options.  Install completer for "backtrace".
7152         Install some settings commands with add_setshow_cmds_for_options.
7153
7154 2019-06-13  Pedro Alves  <palves@redhat.com>
7155
7156         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7157         and that "set/show print raw frame-arguments" are now deprecated.
7158
7159         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7160         command.
7161         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7162         * stack.c (_initialize_stack): Install "set/show print
7163         raw-frame-arguments", and deprecate "set/show print raw
7164         frame-arguments".
7165         * valprint.c (_initialize_valprint): Deprecate "set/show print
7166         raw".
7167
7168 2019-06-13  Pedro Alves  <palves@redhat.com>
7169
7170         * compile/compile.c (struct compile_options): New.
7171         (compile_flag_option_def, compile_command_option_defs)
7172         (make_compile_options_def_group): New.
7173         (compile_file_command): Handle options with
7174         gdb::option::process_options.
7175         (compile_file_command_completer): New function.
7176         (compile_code_command): Handle options with
7177         gdb::option::process_options.
7178         (compile_code_command_completer): New function.
7179         (_initialize_compiler): Install completers for "compile code" and
7180         "compile file".  Mention available options in "compile code" and
7181         "compile code"'s help.
7182         * completer.c (advance_to_completion_word): New, factored out from
7183         ...
7184         (advance_to_expression_complete_word_point): ... this.
7185         (advance_to_filename_complete_word_point): New.
7186         * completer.h (advance_to_filename_complete_word_point): New
7187         declaration.
7188
7189 2019-06-13  Pedro Alves  <palves@redhat.com>
7190
7191         * compile/compile.c: Include "cli/cli-option.h".
7192         (compile_print_value): Scope data pointer is now a
7193         value_print_options pointer; adjust.
7194         (compile_print_command): Process options.  Scope data pointer is
7195         now a value_print_options pointer; adjust.
7196         (_initialize_compile): Update "compile print"'s help to include
7197         supported options.  Install a completer for "compile print".
7198         * cp-valprint.c (show_vtblprint, show_objectprint)
7199         (show_static_field_print): Delete.
7200         (_initialize_cp_valprint): Don't install "set print
7201         static-members", "set print vtbl", "set print object" here.
7202         * printcmd.c: Include "cli/cli-option.h" and
7203         "common/gdb_optional.h".
7204         (print_command_parse_format): Rework to fill in a
7205         value_print_options instead of a format_data.
7206         (print_value): Change parameter type from format_data pointer to
7207         value_print_options reference.  Adjust.
7208         (print_command_1): Process options.  Adjust to pass down a
7209         value_print_options.
7210         (print_command_completer): New.
7211         (_initialize_printcmd): Install print_command_completer as
7212         handle_brkchars completer for the "print" command.  Update
7213         "print"'s help to include supported options.
7214         * valprint.c: Include "cli/cli-option.h".
7215         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7216         here from cp-valprint.c.
7217         (boolean_option_def, uinteger_option_def)
7218         (value_print_option_defs, make_value_print_options_def_group):
7219         New.  Use gdb::option::add_setshow_cmds_for_options to install
7220         "set print elements", "set print null-stop", "set print repeats",
7221         "set print pretty", "set print union", "set print array", "set
7222         print address", "set print symbol", "set print array-indexes".
7223         * valprint.h: Include <string> and "cli/cli-option.h".
7224         (make_value_print_options_def_group): Declare.
7225         (print_value): Change parameter type from format_data pointer to
7226         value_print_options reference.
7227         (print_command_completer): Declare.
7228
7229 2019-06-13  Pedro Alves  <palves@redhat.com>
7230
7231         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7232         (COMMON_SFILES): Add maint-test-settings.c.
7233         * cli/cli-decode.c (boolean_enums): New global, factored out from
7234         ...
7235         (add_setshow_boolean_cmd): ... here.
7236         * cli/cli-decode.h (boolean_enums): Declare.
7237         * cli/cli-option.c: New file.
7238         * cli/cli-option.h: New file.
7239         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7240         factored out from ...
7241         (parse_cli_boolean_value(const char *)): ... this.
7242         (is_unlimited_literal): Change parameter type to pointer to
7243         pointer.  Adjust and advance ARG pointer.
7244         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7245         (parse_cli_var_enum): New, factored out from ...
7246         (do_set_command): ... this.  Adjust.
7247         * cli/cli-setshow.h (parse_cli_boolean_value)
7248         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7249         (parse_cli_var_enum): Declare.
7250         * cli/cli-utils.c: Include "cli/cli-option.h".
7251         (get_ulongest): New.
7252         * cli/cli-utils.h (get_ulongest): Declare.
7253         (check_for_argument): New overloads.
7254         * maint-test-options.c: New file.
7255
7256 2019-06-13  Pedro Alves  <palves@redhat.com>
7257
7258         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7259         parse a range if "-" is at the end of the string.
7260
7261 2019-06-13  Pedro Alves  <palves@redhat.com>
7262
7263         * cli/cli-setshow.c (parse_auto_binary_operation)
7264         (parse_cli_boolean_value): Don't allow "o".
7265
7266 2019-06-13  Pedro Alves  <palves@redhat.com>
7267
7268         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7269         * NEWS: Mention maint test-settings KIND.
7270         * maint-test-settings.c: New file.
7271
7272 2019-06-13  Pedro Alves  <palves@redhat.com>
7273
7274         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7275         completer.
7276         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7277         "set" completers.
7278
7279 2019-06-13  Pedro Alves  <palves@redhat.com>
7280
7281         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7282         after item.
7283
7284 2019-06-13  Pedro Alves  <palves@redhat.com>
7285
7286         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7287
7288 2019-06-13  Pedro Alves <palves@redhat.com>
7289
7290         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7291         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7292         call.
7293         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7294         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7295         calls.
7296         (check_for_argument): Skip spaces after argument.
7297
7298 2019-06-13  Pedro Alves  <palves@redhat.com>
7299
7300         * thread.c (thread_apply_command): Adjust TID parsing.
7301         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7302         detected before end of string.
7303         (tid_is_in_list): Error out if LIST is invalid.
7304
7305 2019-06-13  Pedro Alves  <palves@redhat.com>
7306
7307         * completer.c (complete_line_internal_1): Rewind completion word
7308         point.
7309         (completion_tracker::advance_custom_word_point_by): Change
7310         parameter type to int.
7311         * completer.h (completion_tracker::advance_custom_word_point_by):
7312         Likewise.
7313
7314 2019-06-13  Pedro Alves  <palves@redhat.com>
7315
7316         * completer.c (advance_to_completion_word): Handle delimiters.
7317
7318 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7319
7320         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7321
7322 2019-06-11  Tom Tromey  <tom@tromey.com>
7323
7324         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7325         (xmalloc_failed): Move to alloc.c.
7326         * alloc.c: New file.
7327         * Makefile.in (COMMON_SFILES): Add alloc.c.
7328
7329 2019-06-11  Tom Tromey  <tom@tromey.com>
7330
7331         * nat/linux-waitpid.c: Don't include server.h.
7332         (linux_debug): Remove.
7333         (my_waitpid): Update.
7334
7335 2019-06-11  Tom Tromey  <tromey@adacore.com>
7336
7337         * infcall.c (_initialize_infcall): Remove trailing newline from
7338         help.
7339         * user-regs.c (_initialize_user_regs): Remove trailing newline
7340         from help.
7341         * typeprint.c (_initialize_typeprint): Remove trailing newline
7342         from help.
7343         * reverse.c (_initialize_reverse): Remove trailing newlines from
7344         help.
7345         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7346         from help.
7347         * language.c (add_set_language_command): Remove trailing newline
7348         from help.
7349         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7350         help.
7351         * disasm.c (_initialize_disasm): Remove trailing newline from
7352         help.
7353         * top.c (init_main): Remove trailing newline from help.
7354         * interps.c (_initialize_interpreter): Remove trailing newline
7355         from help.
7356         * btrace.c (_initialize_btrace): Remove trailing newlines from
7357         help.
7358         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7359         from help.
7360         * python/python.c (_initialize_python): Remove trailing newline
7361         from help.
7362         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7363         help.
7364         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7365         from help.  Reformat some text.
7366         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7367         from help.
7368         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7369         newline from help.
7370
7371 2019-06-11  Tom Tromey  <tromey@adacore.com>
7372
7373         * darwin-nat.c (darwin_decode_exception_message)
7374         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7375
7376 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7377
7378         * valops.c (value_slice): Check for not allocated or not
7379         associated values.
7380
7381 2019-06-10  Tom de Vries  <tdevries@suse.de>
7382
7383         PR gdb/24618
7384         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7385         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7386         invalid.
7387
7388 2019-06-10  Tom de Vries  <tdevries@suse.de>
7389
7390         PR gdb/24611
7391         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7392         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7393
7394 2019-06-10  Tom de Vries  <tdevries@suse.de>
7395
7396         PR symtab/24545
7397         * symtab.c (struct demangled_name_entry): Add language field.
7398         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7399         static minimal symbol".  Set and use language field.
7400
7401 2019-06-10  Tom Tromey  <tromey@adacore.com>
7402
7403         * ada-lang.c (_initialize_ada_language): Update help text.
7404
7405 2019-06-10  Tom Tromey  <tromey@adacore.com>
7406
7407         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7408         with a newline.
7409         * guile/guile.c (handle_boot_error): Don't end warning with a
7410         newline.
7411         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7412         warning with a newline.
7413         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7414         newline.
7415         (s12z_frame_cache): Likewise.
7416         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7417         a newline.
7418         * solib-svr4.c (disable_probes_interface): Don't end warning with
7419         a newline.
7420         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7421         newline.
7422         * python/python.c (do_finish_initialization): Don't end warning
7423         with a newline.
7424
7425 2019-06-10  Tom Tromey  <tom@tromey.com>
7426
7427         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7428         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7429         gdbpy_enter.
7430
7431 2019-06-10  Tom Tromey  <tromey@adacore.com>
7432
7433         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7434         data.
7435         (elf_new_init): Don't call stabsread_new_init.
7436         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7437         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7438         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7439
7440 2019-06-10  Tom de Vries  <tdevries@suse.de>
7441
7442         PR symtab/16264
7443         PR symtab/24517
7444         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7445
7446 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7447
7448         * source.c (find_and_open_source): Also rewrite relative file
7449         names.
7450
7451 2019-04-26  Amos Bird  <amosbird@gmail.com>
7452
7453         * annotate.c (annotate_thread_exited): Add "thread-exited"
7454         annotation.
7455
7456 2019-06-06  Tom Tromey  <tromey@adacore.com>
7457
7458         * maint.h (class scoped_command_stats): Use
7459         DISABLE_COPY_AND_ASSIGN.
7460         <print_time>: New method.
7461         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7462         print_time.
7463         (scoped_command_stats::print_time): New method.
7464
7465 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7466
7467         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7468         instructions of lengths 6 or 8 bytes.
7469
7470 2019-06-04  Pedro Alves  <palves@redhat.com>
7471
7472         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7473
7474         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7475         * breakpoint.c (condition_completer): Likewise.
7476         * cli/cli-dump.c (scan_expression): Likewise.
7477         * common/filestuff.c (mkdir_recursive): Likewise.
7478         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7479         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7480         (gdb_abspath): Likewise.
7481         * compile/compile-cplus-types.c
7482         (compile_cplus_instance::decl_name): Likewise.
7483         * completer.c (complete_explicit_location):
7484         (signal_completer, reg_or_group_completer_1): Likewise.
7485         * cp-support.c (cp_remove_params_if_any): Likewise.
7486         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7487         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7488         * infcmd.c (strip_bg_char): Likewise.
7489         * linespec.c (copy_token_string): Likewise.
7490         * mi/mi-main.c (output_cores): Likewise.
7491         * psymtab.c (psymtab_search_name):
7492         * symfile.c (test_set_ext_lang_command): Likewise.
7493         * target.c (target_fileio_read_stralloc): Likewise.
7494         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7495         * value.c (complete_internalvar): Likewise.
7496
7497 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7498
7499         Add objfile property to gdb.Type.
7500         * NEWS: Mention Python API addition.
7501         * python/py-type.c (typy_get_objfile): New method.
7502
7503 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7504
7505         * NEWS: Mention the new set|show style [title|highlight].
7506         Mention changes to "show style", "help" and "apropos".
7507
7508 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7509
7510         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7511         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7512         instead of print_help_for_command.
7513         (print_doc_of_command): New function.
7514         (help_list): Add 'apropos -v word' suggestion.
7515         (print_help_for_command): Style the command name using title style.
7516         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7517         (_initialize_cli_cmds): Describe -v in apropos_command help.
7518
7519 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7520
7521         * cli/cli-style.h (cli_style_option): Add name in constructor,
7522         add m_name class member, add constructor with intensity,
7523         add name class function.
7524         (cli_style_option::add_setshow_commands): Remove name argument.
7525         (highlight_style, title_style): New styles.
7526         * cli/cli-style.c (do_show): New function that shows a style
7527         characteristic styling the style name with itself.
7528         (set_style_name): New function.
7529         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7530         Update all callers according to the changes in cli/cli-style.h.
7531         * utils.h (fputs_highlighted): New function.
7532         * utils.c (fputs_highlighted): Likewise.
7533
7534 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7535
7536         * NEWS: Mention new pipe command and new convenience variables.
7537
7538 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7539
7540         * cli/cli-cmds.c (pipe_command): New function.
7541         (_initialize_cli_cmds): Call add_com for pipe_command.
7542         Define | as an alias for pipe.
7543         (exit_status_set_internal_vars): New function.
7544         (shell_escape): Call exit_status_set_internal_vars.
7545         cli/cli-decode.c (find_command_name_length): Recognize | as
7546         a single character command.
7547
7548 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7549
7550         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7551         top.c (execute_command_to_ui_file): New function, mostly a copy
7552         of execute_command_to_string.
7553         (execute_command_to_string): Implement by calling
7554         execute_command_to_ui_file.
7555
7556 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7557
7558         * top.h (saved_command_line): Remove declaration.
7559         * top.c (previous_saved_command_line, previous_repeat_arguments):
7560         New variables.
7561         (saved_command_line): Make static, define together with other
7562         'repeat variables'.
7563         (dont_repeat): Clear repeat_arguments.
7564         (repeat_previous, get_saved_command_line, save_command_line):
7565         New functions.
7566         (gdb_init): Initialize saved_command_line
7567         and previous_saved_command_line.
7568         * main.c (captured_main_1): Remove saved_command_line initialization.
7569         * event-top.c (handle_line_of_input): Update to use
7570         the new 'repeat' related functions instead of direct access to
7571         saved_command_line.
7572         * command.h (repeat_previous, get_saved_command_line,
7573         save_command_line): New declarations.
7574         (dont_repeat): Add comment.
7575
7576 2019-05-30  Tom Tromey  <tromey@adacore.com>
7577
7578         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7579         Fix comment.
7580         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7581
7582 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7583
7584         PR cli/24587
7585         * completer.c (complete): Initialize variable word.
7586
7587 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7588
7589         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7590         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7591         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7592         'body' is NULL to the outter 'if', protecting the '!is_define'
7593         situation as well.
7594
7595 2019-05-29  Tom Tromey  <tromey@adacore.com>
7596
7597         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7598         (dwarf_unknown): New function.
7599         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7600         (dwarf_type_encoding_name): Use dwarf_unknown.
7601
7602 2019-05-29  Tom Tromey  <tromey@adacore.com>
7603
7604         PR c++/20020:
7605         * cp-valprint.c (cp_print_value_fields): Call
7606         cp_print_static_field inside "try".
7607
7608 2019-05-29  Tom Tromey  <tromey@adacore.com>
7609
7610         * inflow.c (struct terminal_info): Add default operator=.
7611         * configure: Rebuild.
7612         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7613         -Wdeprecated-copy-dtor, -Wredundant-move.
7614
7615 2019-05-29  Tom Tromey  <tromey@adacore.com>
7616
7617         * NEWS: Add entry.
7618         * infcmd.c (print_return_value_1): Handle finish_print
7619         option.
7620         (show_print_finish): New function.
7621         (_initialize_infcmd): Add "set/show print finish" commands.
7622         * valprint.c (user_print_options): Initialize new member.
7623         * valprint.h (struct value_print_options) <finish_print>: New
7624         member.
7625
7626 2019-05-28  Tom Tromey  <tromey@adacore.com>
7627
7628         * ada-lang.c (ada_remove_Xbn_suffix)
7629         (find_old_style_renaming_symbol)
7630         (parse_old_style_renaming): Remove.
7631         (ada_find_renaming_symbol): Don't call
7632         find_old_style_renaming_symbol.
7633         (ada_is_renaming_symbol): Rename from
7634         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7635         bool.  Now static.
7636         (ada_read_var_value): Update and simplify.
7637         * ada-exp.y (write_var_or_type): Remove old code.
7638
7639 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7640
7641         PR gdb/25010
7642         * event-top.c: Remove include comment.
7643         * inflow.c (class scoped_ignore_sigttou): Move from here...
7644         * inflow.h (class scoped_ignore_sigttou): ...to here.
7645         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7646         * top.c:  Remove include comment.
7647
7648 2019-05-27  Tom Tromey  <tom@tromey.com>
7649
7650         * NEWS: Fix typo.
7651
7652 2019-05-22  Tom Tromey  <tromey@adacore.com>
7653
7654         * target.c (target_follow_exec): Constify parameter.
7655         * target-delegates.c: Rebuild.
7656         * remote.c (remote_target::follow_exec): Constify parameter.
7657         * infrun.c (follow_exec): Constify parameter.
7658         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7659         (target_follow_exec): Likewise.
7660
7661 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7662
7663         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7664         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7665
7666 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7667
7668         * NEWS: Add debugredirect and testsuite sections.
7669
7670 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7671
7672         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7673         target descriptions using exclusively floating point register name
7674         aliases.
7675
7676 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         PR gdb/18644:
7679         * f-lang.c (build_fortran_types): Handle the case where
7680         gdbarch_floatformat_for_type returns a nullptr.
7681
7682 2019-05-21  Tom de Vries  <tdevries@suse.de>
7683
7684         PR cli/24587
7685         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7686
7687 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7688
7689         PR gdb/18644:
7690         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7691         16-byte floats.
7692         * i386-tdep.c (i386_floatformat_for_type): Use
7693         floatformats_ia64_quad for the 16-byte floating point component
7694         within a fortran 32-byte complex number.
7695
7696 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7697
7698         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7699         delete default constructor.
7700         (find_partial_die): Update to return const struct.
7701         (partial_die_parent_scope): Move variable declaration into scope
7702         of its use and change its type to auto.
7703         (guess_partial_die_structure_name): Likewise.
7704         (partial_die_info::fixup): Likewise.
7705
7706 2019-05-17  Tom Tromey  <tromey@adacore.com>
7707
7708         * source.c (find_and_open_source): Remove cast.
7709
7710 2019-05-17  Tom Tromey  <tromey@adacore.com>
7711
7712         * annotate.c (annotate_source): Make "filename" const.
7713         * annotate.h (annotate_source): Use const.
7714
7715 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7716
7717         * disasm.c (set_disassembler_options): Send errors to stderr.
7718
7719 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7720
7721         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7722         (cli_interp_base::set_logging): Check debug_redirect.
7723         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7724         * cli/cli-logging.c (debug_redirect): Add static variable.
7725         (pop_output_files): Add default param.
7726         (handle_redirections): Print debug setting.
7727         (show_logging_command): Likewise.
7728         (_initialize_cli_logging): Add debugredirect command.
7729         * interps.c (current_interp_set_logging): Add debug_redirect
7730         parameter.
7731         * interps.h (set_logging): Add debug_redirect parameter.
7732         (current_interp_set_logging): Likewise.
7733         * mi/mi-common.h: Likewise.
7734         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7735
7736 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7737             Tom Tromey  <tromey@adacore.com>
7738
7739         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7740         directly.
7741         * cli/cli-interp.h (make_logging_output): Remove declaration.
7742         * cli/cli-logging.c (make_logging_output): Remove function.
7743         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7744         directly.
7745         * ui-file.c (tee_file::tee_file): Remove bools.
7746         (tee_file::~tee_file): Remove deletes.
7747         * ui-file.h (tee_file): Remove bools.
7748
7749 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7750
7751         * mi/mi-cmds.h (mi_cmd_complete): New function.
7752         * mi/mi-main.c (mi_cmd_complete): Likewise.
7753         * mi/mi-cmds.c: Define new MI command -complete.
7754         * NEWS: Mention new -complete command.
7755
7756 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7757
7758         * completer.h (complete): New function.
7759         * completer.c (complete): Likewise.
7760         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7761         function defined in completer.h.
7762
7763 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7764
7765         * MAINTAINERS (Write After Approval): Add myself.
7766
7767 2019-05-17  Tom de Vries  <tdevries@suse.de>
7768
7769         PR gdb/24094
7770         * dwarf2read.c (struct cu_partial_die_info): New struct.
7771         (find_partial_die): Return cu_partial_die_info.
7772         (partial_die_parent_scope, guess_partial_die_structure_name)
7773         (partial_die_info::fixup): Handle new return type of find_partial_die.
7774
7775 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7776
7777         PR breakpoints/24541
7778         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7779         "std::string", simplifying the algorithm.
7780
7781 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7782
7783         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7784         (stap_static_probe_ops::get_probes): Likewise.
7785
7786 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7787
7788         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7789         '-')" and "else if".
7790         (stap_parse_single_operand): Join checks for
7791         "gdbarch_stap_parse_special_token_p" and
7792         "gdbarch_stap_parse_special_token" in the same "if" statement.
7793         Invert check when verifying for operation on register
7794         displacement.
7795
7796 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7797
7798         * stap-probe.c (stap_get_opcode): Update comment.
7799         (stap_get_expected_argument_type): Likewise.
7800         (handle_stap_probe): Likewise.
7801
7802 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7803
7804         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7805         return type to 'bool'.  Adjust comment.  Use 'bool' when
7806         appropriate.
7807         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7808         * stap-probe.c (stap_parse_argument_1): Likewise.
7809         (stap_is_operator): Likewise.
7810         (stap_is_generic_prefix): Likewise.
7811         (stap_is_register_prefix): Likewise.
7812         (stap_is_register_indirection_prefix): Likewise.
7813         (stap_is_integer_prefix): Likewise.
7814         (stap_generic_check_suffix): Likewise.
7815         (stap_check_integer_suffix): Likewise.
7816         (stap_check_register_suffix): Likewise.
7817         (stap_check_register_indirection_suffix): Likewise.
7818         (stap_parse_register_operand): Likewise.
7819         (stap_parse_single_operand): Likewise.
7820         (stap_parse_argument_1): Likewise.
7821         (stap_probe::get_argument_count): Likewise.
7822         (stap_is_operator): Likewise.
7823
7824 2019-05-16  Tom Tromey  <tromey@adacore.com>
7825
7826         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7827         keyword to foreach.
7828
7829 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7830
7831         * linux-thread-db.c (try_thread_db_load_1): Change return type
7832         to bool.
7833         (try_thread_db_load): Likewise.
7834         (try_thread_db_load_from_pdir_1): Likewise.
7835         (try_thread_db_load_from_pdir): Likewise.
7836         (try_thread_db_load_from_sdir): Likewise.
7837         (try_thread_db_load_from_dir): Likewise.
7838         (thread_db_load_search): Likewise.
7839         (has_libpthread): Likewise.
7840         (thread_db_load): Likewise.
7841
7842 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7843
7844         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7845         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7846         NULL, and complain/return if that's the case.
7847
7848 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7849
7850         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7851         (advance, posn, abstract_read_memory): New functions.
7852         [struct mem_read_abstraction]: New struct.
7853         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7854
7855 2019-05-14  Tom Tromey  <tromey@adacore.com>
7856
7857         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7858         value is not lval_memory.
7859
7860 2019-05-14  Tom Tromey  <tromey@adacore.com>
7861
7862         * solib.c (info_sharedlibrary_command): Style the file name.
7863
7864 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7865
7866         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7867         (aarch64_vnv_type): Likewise.
7868         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7869         * common/tdesc.c: Likewise.
7870         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7871         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7872         * features/aarch64-fpu.xml: Add ieee half view.
7873         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7874         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7875         * gdbtypes.h (struct builtin_type): Likewise.
7876         (struct objfile_type): Likewise.
7877
7878 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7879
7880         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7881         typo.
7882         * location.h (string_to_event_location): Likewise.
7883
7884 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7885
7886         GDB 8.3 released.
7887
7888 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7889
7890         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7891         New variable declaration.
7892         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7893         New variable.
7894         (print_one_breakpoint): Use ui_out::test_flags and new global
7895         variable to compute use_fixed_output.
7896         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7897         Remove.
7898         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7899         (mi_multi_location_breakpoint_output_fixed): Remove.
7900         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7901         new variable.
7902         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7903         fix_multi_location_breakpoint_output flag if version >= 3.
7904         * ui-out.h (enum ui_out_flag)
7905         <fix_multi_location_breakpoint_output>: New enumerator.
7906
7907 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7908
7909         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7910
7911 2019-05-10  Tom Tromey  <tromey@adacore.com>
7912
7913         * ada-lang.c (catch_ada_completer): New function.
7914         (_initialize_ada_language): Use it.
7915
7916 2019-05-10  Tom Tromey  <tromey@adacore.com>
7917
7918         * thread.c (print_thread_info): Make "requested_threads" const.
7919         * gdbthread.h (print_thread_info): Make "requested_threads"
7920         const.
7921         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7922         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7923
7924 2019-05-08  Tom Tromey  <tom@tromey.com>
7925
7926         * gdbtypes.c (objfile_type_data): Change type.
7927         (objfile_type, _initialize_gdbtypes): Update.
7928
7929 2019-05-08  Tom Tromey  <tom@tromey.com>
7930
7931         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7932         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7933         (_initialize_dwarf2_frame): Update.
7934
7935 2019-05-08  Tom Tromey  <tom@tromey.com>
7936
7937         * objc-lang.c (objc_objfile_data): Change type.
7938         (find_methods): Update.
7939         (_initialize_objc_lang): Remove.
7940
7941 2019-05-08  Tom Tromey  <tom@tromey.com>
7942
7943         * stabsread.c (rs6000_builtin_type_data): Change type.
7944         (rs6000_builtin_type, _initialize_stabsread): Update.
7945
7946 2019-05-08  Tom Tromey  <tom@tromey.com>
7947
7948         * mips-tdep.c (mips_pdr_data): Remove.
7949         (_initialize_mips_tdep): Update.
7950
7951 2019-05-08  Tom Tromey  <tom@tromey.com>
7952
7953         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7954         (hppa_init_objfile_priv_data, read_unwind_info)
7955         (find_unwind_entry, _initialize_hppa_tdep): Update.
7956
7957 2019-05-08  Tom Tromey  <tom@tromey.com>
7958
7959         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7960         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7961         on obstack.
7962         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7963
7964 2019-05-08  Tom Tromey  <tom@tromey.com>
7965
7966         * mdebugread.c (basic_type_data): Change type.
7967         (basic_type, _initialize_mdebugread): Update.
7968
7969 2019-05-08  Tom Tromey  <tom@tromey.com>
7970
7971         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7972
7973 2019-05-08  Tom Tromey  <tom@tromey.com>
7974
7975         * nto-tdep.c (nto_inferior_data_reg): Change type.
7976         (nto_inferior_data): Update.
7977         (nto_inferior_data_cleanup, nto_new_inferior_data)
7978         (_initialize_nto_tdep): Remove.
7979         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7980
7981 2019-05-08  Tom Tromey  <tom@tromey.com>
7982
7983         * ada-lang.c (struct ada_inferior_data): Add initializers.
7984         (ada_inferior_data): Change type.
7985         (ada_inferior_data_cleanup): Remove.
7986         (get_ada_inferior_data, ada_inferior_exit)
7987         (struct ada_pspace_data): Add initializers, destructor.
7988         (ada_pspace_data_handle): Change type.
7989         (get_ada_pspace_data): Update.
7990         (ada_pspace_data_cleanup): Remove.
7991
7992 2019-05-08  Tom Tromey  <tom@tromey.com>
7993
7994         * coffread.c (struct coff_symfile_info): Add initializers.
7995         (coff_objfile_data_key): Move lower.  Change type.
7996         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7997         Update.
7998         (coff_free_info): Remove.
7999
8000 2019-05-08  Tom Tromey  <tom@tromey.com>
8001
8002         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8003         (fbsd_pspace_data_handle): Move lower.  Change type.
8004         (get_fbsd_pspace_data): Update.
8005         (fbsd_pspace_data_cleanup): Remove.
8006         (_initialize_fbsd_tdep): Update.
8007
8008 2019-05-08  Tom Tromey  <tom@tromey.com>
8009
8010         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8011         (get_ada_tasks_pspace_data): Update.
8012         (ada_tasks_pspace_data_cleanup): Remove.
8013         (_initialize_tasks): Update.
8014         (ada_tasks_inferior_data_handle): Change type.
8015         (get_ada_tasks_inferior_data): Update.
8016         (ada_tasks_inferior_data_cleanup): Remove.
8017         (struct ada_tasks_pspace_data): Add initializers.
8018
8019 2019-05-08  Tom Tromey  <tom@tromey.com>
8020
8021         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8022         * symfile-debug.c (debug_sym_get_probes): Change type.
8023         * stap-probe.c (handle_stap_probe):
8024         (stap_static_probe_ops::get_probes): Change type.
8025         * probe.h (class static_probe_ops) <get_probes>: Change type.
8026         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8027         (parse_probes_in_pspace): Update.
8028         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8029         Update.
8030         (any_static_probe_ops::get_probes): Change type.
8031         * elfread.c (elfread_data): New typedef.
8032         (probe_key): Change type.
8033         (elf_get_probes): Likewise.  Update.
8034         (probe_key_free): Remove.
8035         (_initialize_elfread): Update.
8036         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8037         Change type.
8038         (dtrace_process_dof_probe, dtrace_process_dof)
8039         (dtrace_static_probe_ops::get_probe): Change type.
8040
8041 2019-05-08  Tom Tromey  <tom@tromey.com>
8042
8043         * xcoffread.c (struct xcoff_symfile_info): Rename from
8044         coff_symfile_info.  Add initializers.
8045         (xcoff_objfile_data_key): Move lower.  Change type.
8046         (XCOFF_DATA): Rewrite.
8047         (xcoff_free_info): Remove.
8048         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8049         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8050         (xcoff_initial_scan): Update.
8051
8052 2019-05-08  Tom Tromey  <tom@tromey.com>
8053
8054         * solib-svr4.c (struct svr4_info): Add initializers and
8055         destructor.
8056         <probes_table>: Now an htab_up.
8057         (solib_svr4_pspace_data): Change type.
8058         (free_probes_table): Simplify.
8059         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8060         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8061         (probes_table_remove_objfile_probes, register_solib_event_probe)
8062         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8063         (_initialize_svr4_solib): Update.
8064
8065 2019-05-08  Tom Tromey  <tom@tromey.com>
8066
8067         * remote.c (remote_pspace_data): Change type.
8068         (remote_pspace_data_cleanup): Remove.
8069         (get_remote_exec_file, set_pspace_remote_exec_file)
8070         (_initialize_remote): Update.
8071
8072 2019-05-08  Tom Tromey  <tom@tromey.com>
8073
8074         * breakpoint.c (breakpoint_objfile_key): Change type.
8075         (get_breakpoint_objfile_data): Update.
8076         (free_breakpoint_objfile_data): Remove.
8077         (_initialize_breakpoint): Update.
8078
8079 2019-05-08  Tom Tromey  <tom@tromey.com>
8080
8081         * linux-tdep.c (struct linux_info): Add initializers.
8082         (linux_inferior_data): Move.  Change type.
8083         (invalidate_linux_cache_inf): Update.
8084         (linux_inferior_data_cleanup): Remove.
8085         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8086
8087 2019-05-08  Tom Tromey  <tom@tromey.com>
8088
8089         * auxv.c (auxv_inferior_data): Move.  Change type.
8090         (auxv_inferior_data_cleanup): Remove.
8091         (invalidate_auxv_cache_inf): Rewrite.
8092         (get_auxv_inferior_data, _initialize_auxv): Update.
8093
8094 2019-05-08  Tom Tromey  <tom@tromey.com>
8095
8096         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8097         (symfile_debug_objfile_data_key): Change type.
8098         (symfile_debug_installed, debug_qf_has_symbols)
8099         (debug_qf_find_last_source_symtab)
8100         (debug_qf_forget_cached_source_info)
8101         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8102         (debug_qf_print_stats, debug_qf_dump)
8103         (debug_qf_expand_symtabs_for_function)
8104         (debug_qf_expand_all_symtabs)
8105         (debug_qf_expand_symtabs_with_fullname)
8106         (debug_qf_map_matching_symbols)
8107         (debug_qf_expand_symtabs_matching)
8108         (debug_qf_find_pc_sect_compunit_symtab)
8109         (debug_qf_map_symbol_filenames)
8110         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8111         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8112         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8113         (debug_sym_read_linetable, debug_sym_relocate): Update.
8114         (symfile_debug_free_objfile): Remove.
8115         (install_symfile_debug_logging, _initialize_symfile_debug):
8116         Update.
8117
8118 2019-05-08  Tom Tromey  <tom@tromey.com>
8119
8120         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8121         allocate_on_obstack.
8122         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8123         (get_dwarf2_per_objfile): Update.
8124         (set_dwarf2_per_objfile): Remove.
8125         (dwarf2_has_info, dwarf2_get_section_info): Update.
8126         (dwarf2_free_objfile): Remove.
8127         (_initialize_dwarf2_read): Update.
8128
8129 2019-05-08  Tom Tromey  <tom@tromey.com>
8130
8131         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8132         initializers.
8133         <unsupported_script_warning_printed,
8134         script_not_found_warning_printed>: Now bool.
8135         (auto_load_pspace_data): Change type.
8136         (~auto_load_pspace_info): Rename from
8137         auto_load_pspace_data_cleanup.
8138         (get_auto_load_pspace_data, init_loaded_scripts_info)
8139         (clear_section_scripts, maybe_print_unsupported_script_warning)
8140         (maybe_print_script_not_found_warning, _initialize_auto_load):
8141         Update.
8142
8143 2019-05-08  Tom Tromey  <tom@tromey.com>
8144
8145         * objfiles.c (objfile_pspace_info): Add destructor and
8146         initializers.
8147         (objfiles_pspace_data): Change type.
8148         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8149         (get_objfile_pspace_data): Update.
8150         (objfiles_bfd_data): Change type.
8151         (get_objfile_bfd_data): Update.
8152         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8153
8154 2019-05-08  Tom Tromey  <tom@tromey.com>
8155
8156         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8157         Change type.
8158         (get_catch_syscall_inferior_data): Update.
8159         (catch_syscall_inferior_data_cleanup): Remove.
8160         (_initialize_break_catch_syscall): Update.
8161
8162 2019-05-08  Tom Tromey  <tom@tromey.com>
8163
8164         * inflow.c (struct terminal_info): Add destructor and
8165         initializers.
8166         (inflow_inferior_data): Change type.
8167         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8168         (get_inflow_inferior_data, inflow_inferior_exit)
8169         (swap_terminal_info, _initialize_inflow): Update.
8170
8171 2019-05-08  Tom Tromey  <tom@tromey.com>
8172
8173         * target-dcache.c (target_dcache_cleanup): Remove.
8174         (target_dcache_aspace_key): Change type.
8175         (target_dcache_init_p, target_dcache_invalidate)
8176         (target_dcache_get, target_dcache_get_or_init)
8177         (_initialize_target_dcache): Update.
8178         * dcache.h (struct dcache_deleter): New.
8179
8180 2019-05-08  Tom Tromey  <tom@tromey.com>
8181
8182         * symtab.c (struct symbol_cache): Add destructor and
8183         initializers.
8184         (symbol_cache_key): Move.  Change type.
8185         (make_symbol_cache, free_symbol_cache): Remove.
8186         (get_symbol_cache): Update.
8187         (symbol_cache_cleanup): Remove.
8188         (ALL_PSPACES, symbol_cache_flush)
8189         (maintenance_print_symbol_cache)
8190         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8191         Update.
8192
8193 2019-05-08  Tom Tromey  <tom@tromey.com>
8194
8195         * symtab.c (struct main_info): Add destructor and initializers.
8196         (main_progspace_key): Move.  Change type.
8197         (get_main_info): Update.
8198         (main_info_cleanup): Remove.
8199         (_initialize_symtab): Update.
8200
8201 2019-05-08  Tom Tromey  <tom@tromey.com>
8202
8203         * registry.h (DECLARE_REGISTRY): Define the _key class.
8204
8205 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8206
8207         * NEWS: Merge two 'New commands' sections.
8208
8209 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8210
8211         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8212         parameter and use Ada language definition instead.
8213         (ada_val_print_ptr): Remove unused language parameter.
8214         (ada_val_print_num): Remove language parameter and use Ada language
8215         definition instead.
8216         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8217         parameter.
8218         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8219         parameter and use Ada language definition instead.
8220         (ada_val_print_1): Update all ada_val_print_xxx calls.
8221         Remove language parameter.
8222         (ada_val_print): Update ada_val_print_1 call.
8223
8224 2019-05-08  Tom Tromey  <tromey@adacore.com>
8225
8226         * remote.c (remote_hw_watchpoint_limit)
8227         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8228         Now static.
8229
8230 2019-05-08  Tom Tromey  <tromey@adacore.com>
8231
8232         * maint.c (_initialize_maint_cmds): Move initialization code to
8233         remote.c.
8234         (watchdog, show_watchdog): Move to remote.c.
8235         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8236         "watchdog" static.
8237         (_initialize_remote): Move initialization code from maint.c.
8238         * defs.h (watchdog): Don't declare.
8239
8240 2019-05-08  Tom Tromey  <tromey@adacore.com>
8241
8242         * tui/tui-interp.c: Include main.h.
8243         * interps.c: Include main.h.
8244         * main.h (interpreter_p): Declare.
8245         * defs.h (interpreter_p): Don't declare.
8246
8247 2019-05-08  Tom Tromey  <tromey@adacore.com>
8248
8249         * dwarf2loc.c: Include dwarf2read.h.
8250         * defs.h (read_unsigned_leb128): Don't declare.
8251         * dwarf2read.h (read_unsigned_leb128): Declare.
8252
8253 2019-05-08  Tom Tromey  <tromey@adacore.com>
8254
8255         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8256         method.
8257
8258 2019-05-08  Tom Tromey  <tromey@adacore.com>
8259
8260         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8261         when no wrap column is set.
8262
8263 2019-05-08  Tom Tromey  <tromey@adacore.com>
8264
8265         * c-lang.c (c_get_string): Handle non-C-style arrays.
8266
8267 2019-05-08  Tom Tromey  <tromey@adacore.com>
8268
8269         * typeprint.c (print_offset_data::update): Print the bit offset,
8270         not the number of bits remaining.
8271
8272 2019-05-08  Tom Tromey  <tromey@adacore.com>
8273
8274         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8275         padding at end of comment.
8276
8277 2019-05-08  Tom Tromey  <tromey@adacore.com>
8278
8279         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8280         Compare main types.
8281
8282 2019-05-06  Tom Tromey  <tom@tromey.com>
8283
8284         * common/scoped_mmap.c: Include common-defs.h.
8285         * common/scoped_mmap.h: Don't include config.h.
8286
8287 2019-05-04  Tom Tromey  <tom@tromey.com>
8288
8289         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8290         (struct aarch64_call_info): Add initializers.
8291         <si>: Now a std::vector.
8292         (pass_on_stack, aarch64_push_dummy_call): Update.
8293
8294 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8295             Tom Tromey  <tom@tromey.com>
8296
8297         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8298         (ppc_threads): Now a std::vector.  Now static.
8299         (hwdebug_find_thread_points_by_tid)
8300         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8301         Update.
8302
8303 2019-05-04  Tom Tromey  <tom@tromey.com>
8304
8305         * arc-tdep.c (arc_tdesc_init): Return bool.
8306
8307 2019-05-04  Tom Tromey  <tom@tromey.com>
8308
8309         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8310         Use gdb_assert_not_reached.
8311
8312 2019-05-04  Tom Tromey  <tom@tromey.com>
8313
8314         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8315         "false".
8316
8317 2019-05-04  Tom Tromey  <tom@tromey.com>
8318
8319         * arc-tdep.c (arc_tdesc_init): Use bool.
8320
8321 2019-05-04  Tom Tromey  <tom@tromey.com>
8322
8323         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8324
8325 2019-05-04  Tom Tromey  <tom@tromey.com>
8326
8327         * cli/cli-cmds.c (valid_command_p): Return bool.
8328
8329 2019-05-04  Tom Tromey  <tom@tromey.com>
8330
8331         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8332         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8333
8334 2019-05-04  Raul Tambre  <raul@tambre.ee>
8335
8336         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8337         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8338         operator for comparison.
8339
8340 2019-05-04  Tom Tromey  <tom@tromey.com>
8341
8342         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8343         (lookup_partial_symbol, print_partial_symbols)
8344         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8345         (psymbol_compare): Update.
8346         (add_psymbol_to_bcache): Clear the entire psymbol.
8347         (maintenance_check_psymtabs): Update.
8348         * psympriv.h (struct partial_symbol): Don't derive from
8349         general_symbol_info.
8350         <obj_section, unrelocated_address, address,
8351         set_unrelocated_address>: Update.
8352         <ginfo>: New member.
8353         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8354         (debug_names::write_psymbols): Update.
8355
8356 2019-05-04  Tom de Vries  <tdevries@suse.de>
8357
8358         * contrib/cc-with-tweaks.sh: Support -n arg.
8359
8360 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8361
8362         * corelow.c (core_target::detach): Ensure frame cache and
8363         register caches are cleared.
8364         inferior.c (exit_inferior_1): Likewise.
8365
8366 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8367             Tom Tromey  <tom@tromey.com>
8368
8369         * dictionary.c (collate_pending_symbols_by_language): Remove
8370         "struct" from foreach.
8371         * symtab.c (lookup_global_symbol_from_objfile)
8372         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8373         foreach.
8374         * ser-tcp.c (net_open): Remove "struct" from foreach.
8375         * objfiles.c (objfile_relocate, objfile_rebase)
8376         (objfile_has_symbols): Remove "struct" from foreach.
8377         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8378         from foreach.
8379         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8380         foreach.
8381         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8382         "struct" from foreach.
8383         * ada-lang.c (create_excep_cond_exprs)
8384         (ada_exception_catchpoint_cond_string): Remove "struct" from
8385         foreach.
8386
8387 2019-05-03  Tom Tromey  <tromey@adacore.com>
8388
8389         * ada-exp.y (convert_char_literal): Check suffix of each
8390         enumerator.
8391
8392 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8393
8394         PR ada/21406:
8395         * ada-exp.y (yywrap): Don't define.
8396         * ada-lex.l (%option): Add noyywrap
8397         (yywrap): Remove.
8398
8399 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8400
8401         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8402         _WIN32_WINNT to the XP level, unless already defined to a higher
8403         level.
8404
8405         * unittests/parse-connection-spec-selftests.c:
8406         * ser-tcp.c:
8407         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8408         override.
8409
8410         * symfile.c (find_separate_debug_file): Remove colon from the
8411         drive spec of DOS/Windows file names of the target, so that the
8412         file name produced from DEBUGDIR and the target's directory will
8413         be valid on DOS/Windows systems.
8414
8415 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8416
8417         * rust-lang.c (val_print_struct): Handle printing structures
8418         containing strings.
8419
8420 2019-05-02  Tom Tromey  <tromey@adacore.com>
8421
8422         * valarith.c (_initialize_valarith): Remove.
8423
8424 2019-05-01  Tom Tromey  <tromey@adacore.com>
8425
8426         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8427         bitfields.
8428
8429 2019-05-01  Tom Tromey  <tromey@adacore.com>
8430
8431         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8432         for big-endian copies.
8433
8434 2019-04-30  Ali Tamur  <tamur@google.com>
8435         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8436         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8437         (read_3_bytes): New function.
8438
8439 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8440
8441         * windows-nat.c (main_thread_id): Delete.
8442         (handle_output_debug_string): Replace main_thread_id by
8443         current_event.dwThreadId.
8444         (fake_create_process): Likewise.
8445         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8446         Do not set main_thread_id.
8447         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8448         current_event.dwThreadId.
8449         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8450
8451 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8452
8453         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8454         Use current_event.dwThreadId instead of main_thread_id.
8455
8456 2019-04-30  Tom Tromey  <tromey@adacore.com>
8457
8458         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8459         (create_excep_cond_exprs): Iterate over program spaces.
8460         (ada_exception_catchpoint_cond_string): Examine all minimal
8461         symbols for exception types.
8462
8463 2019-04-30  Tom Tromey  <tromey@adacore.com>
8464
8465         PR c++/24470:
8466         * dwarf2read.c (process_structure_scope): Handle case where type
8467         has template parameters but no symbol was created.
8468
8469 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8470             Chris January  <chris.january@arm.com>
8471
8472         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8473         qualifier.
8474         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8475
8476 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * f-typeprint.c (f_print_type): Update rules for printing
8479         whitespace.
8480         (f_type_print_varspec_suffix): Likewise.
8481
8482 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8483             Chris January  <chris.january@arm.com>
8484
8485         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8486         function arguments.
8487
8488 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8489
8490         * f-lang.c (build_fortran_types): Change name of void type to
8491         lower case.
8492         * f-typeprint.c (f_type_print_base): Print the name of the void
8493         type, rather than a fixed string.
8494         * f-valprint.c (f_decorations): Use lower case void string.
8495
8496 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8497             Chris January  <chris.january@arm.com>
8498
8499         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8500         types for Fortran.
8501
8502 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8503             Chris January  <chris.january@arm.com>
8504             David Lecomber  <david.lecomber@arm.com>
8505
8506         * f-exp.y (BINOP_INTRINSIC): New token.
8507         (exp): New parser rule handling BINOP_INTRINSIC.
8508         (f77_keywords): Add new builtin procedures.
8509         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8510         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8511         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8512         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8513         (print_unop_subexp_f): New function.
8514         (print_binop_subexp_f): New function.
8515         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8516         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8517         (dump_subexp_body_f): Likewise.
8518         (operator_check_f): Likewise.
8519         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8520         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8521
8522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8523
8524         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8525         UNOP_KIND.
8526         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8527         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8528         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8529         (operator_length_f): New fuction.
8530         (print_subexp_f): New function.
8531         (op_name_f): New function.
8532         (dump_subexp_body_f): New function.
8533         (operator_check_f): New function.
8534         (exp_descriptor_f): Replace standard expression handling functions
8535         with new functions.
8536         * gdb/fortran-operator.def: New file.
8537         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8538         * gdb/std-operator.def: Remove UNOP_KIND.
8539
8540 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8541
8542         * std-operator.def: Remove unbalanced, stray double quote
8543         character.
8544
8545 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8546             Chris January  <chris.january@arm.com>
8547             Daniel Everett  <daniel.everett@arm.com>
8548             Nick Forrington  <nick.forrington@arm.com>
8549             Richard Bunt  <richard.bunt@arm.com>
8550
8551         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8552         of depth when printing anonymous structs or unions.
8553         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8554         Don't print either the top-level value, or the children if the
8555         max-depth is exceeded.
8556         (ppscm_print_children): When printing the key of a map, allow one
8557         extra level of depth.
8558         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8559         print either the top-level value, or the children if the max-depth
8560         is exceeded.
8561         (print_children): When printing the key of a map, allow one extra
8562         level of depth.
8563         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8564         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8565         (user_print_options): Initialise max_depth field.
8566         (val_print_scalar_or_string_type_p): New function.
8567         (val_print): Check to see if the max depth has been reached.
8568         (val_print_check_max_depth): Define new function.
8569         (show_print_max_depth): New function.
8570         (_initialize_valprint): Add 'print max-depth' option.
8571         * valprint.h (struct value_print_options) <max_depth>: New field.
8572         (val_print_check_max_depth): Declare new function.
8573         * NEWS: Document new feature.
8574
8575 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8576
8577         * ada-lang.c (ada_language_defn): Initialise new field.
8578         * c-lang.c (c_is_string_type_p): New function.
8579         (c_language_defn): Initialise new field.
8580         (cplus_language_defn): Initialise new field.
8581         (asm_language_defn): Initialise new field.
8582         (minimal_language_defn): Initialise new field.
8583         * c-lang.h (c_is_string_type_p): Declare new function.
8584         * d-lang.c (d_language_defn): Initialise new field.
8585         * f-lang.c (f_is_string_type_p): New function.
8586         (f_language_defn): Initialise new field.
8587         * go-lang.c (go_is_string_type_p): New function.
8588         (go_language_defn): Initialise new field.
8589         * language.c (default_is_string_type_p): New function.
8590         (unknown_language_defn): Initialise new field.
8591         (auto_language_defn): Initialise new field.
8592         * language.h (struct language_defn) <la_is_string_type_p>: New
8593         member variable.
8594         (default_is_string_type_p): Declare new function.
8595         * m2-lang.c (m2_language_defn): Initialise new field.
8596         * objc-lang.c (objc_language_defn): Initialise new field.
8597         * opencl-lang.c (opencl_language_defn): Initialise new field.
8598         * p-lang.c (pascal_is_string_type_p): New function.
8599         (pascal_language_defn): Initialise new field.
8600         * rust-lang.c (rust_is_string_type_p): New function.
8601         (rust_language_defn): Initialise new field.
8602
8603 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8604
8605         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8606         New field.
8607         * ada-lang.c (ada_language_defn): Initialise new field.
8608         * c-lang.c (c_language_defn): Likewise.
8609         (cplus_language_defn): Likewise.
8610         (asm_language_defn): Likewise.
8611         (minimal_language_defn): Likewise.
8612         * d-lang.c (d_language_defn): Likewise.
8613         * f-lang.c (f_language_defn): Likewise.
8614         * go-lang.c (go_language_defn): Likewise.
8615         * language.c (unknown_language_defn): Likewise.
8616         (auto_language_defn): Likewise.
8617         * m2-lang.c (m2_language_defn): Likewise.
8618         * objc-lang.c (objc_language_defn): Likewise.
8619         * opencl-lang.c (opencl_language_defn): Likewise.
8620         * p-lang.c (pascal_language_defn): Likewise.
8621         * rust-lang.c (rust_language_defn): Likewise.
8622
8623 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8624
8625         * ada-lang.c (ada_is_character_type): Change return type to bool.
8626         (ada_is_string_type): Likewise.
8627         * ada-lang.h (ada_is_character_type): Update declaration
8628         (ada_is_string_type): Likewise.
8629
8630 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8631
8632         Support style in 'frame|thread apply'
8633
8634         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8635         * record.c (record_start, record_stop): Update callers of
8636         execute_command_to_string with false.
8637         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8638         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8639         methods.
8640         (class string_file): New constructor with term_out parameter.
8641         Override methods term_out and can_emit_style_escape.  New member
8642         term_out.
8643         (class stdio_file): Override can_emit_style_escape.
8644         (class tee_file): Override term_out and can_emit_style_escape.
8645         * utils.h (can_emit_style_escape): Remove.
8646         * utils.c (can_emit_style_escape): Likewise.
8647         Update all callers of can_emit_style_escape (SOMESTREAM) to
8648         SOMESTREAM->can_emit_style_escape.
8649         * source-cache.c (source_cache::get_source_lines): Likewise.
8650         * stack.c (frame_apply_command_count): Call execute_command_to_string
8651         passing the term_out characteristic of the current gdb_stdout.
8652         * thread.c (thr_try_catch_cmd): Likewise.
8653         * top.c (execute_command_to_string): pass term_out parameter
8654         to construct the string_file for the command output.
8655         * ui-file.c (term_cli_styling): New function (most code moved
8656         from utils.c can_emit_style_escape).
8657         (string_file::string_file, string_file::can_emit_style_escape,
8658         stdio_file::can_emit_style_escape, tee_file::term_out,
8659         tee_file::can_emit_style_escape): New functions.
8660
8661 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8662
8663         * NEWS: Mention the new set|show may-call-functions.
8664         * infcall.c (may_call_functions_p): New variable.
8665         (show_may_call_functions_p): New function.
8666         (call_function_by_hand_dummy): Throws an error if not
8667         may-call-functions.
8668         (_initialize_infcall): Call add_setshow_boolean_cmd for
8669         may-call-functions.
8670
8671 2019-04-25  Keith Seitz  <keiths@redhat.com>
8672
8673         PR c++/24367
8674         * cp-support.c (inspect_type): Don't attempt substitutions
8675         of symbol with the same name.
8676
8677 2019-04-25  Tom Tromey  <tromey@adacore.com>
8678
8679         PR gdb/24475:
8680         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8681         static.
8682
8683 2019-04-25  Tom Tromey  <tromey@adacore.com>
8684
8685         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8686         rvalue reference.
8687         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8688         (gdb_xml_parser::parse): Use std::move.
8689         * python/python-internal.h (gdbpy_convert_exception): Take a const
8690         reference.
8691         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8692         std::move.
8693         * python/py-utils.c (gdbpy_convert_exception): Take a const
8694         reference.
8695         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8696         Use std::move.
8697         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8698         Use std::move.
8699         * mi/mi-main.c (mi_print_exception): Take a const reference.
8700         * main.c (handle_command_errors): Take a const reference.
8701         * linespec.c (parse_linespec): Use std::move.
8702         * infcall.c (run_inferior_call): Use std::move.
8703         (call_function_by_hand_dummy): Use std::move.
8704         * exec.c (try_open_exec_file): Use std::move.
8705         * exceptions.h (exception_print, exception_fprintf)
8706         (exception_print_same): Update.
8707         * exceptions.c (print_exception, exception_print)
8708         (exception_fprintf, exception_print_same): Change parameters to
8709         const reference.
8710         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8711         * common/new-op.c: Use std::move.
8712         * common/common-exceptions.h (struct gdb_exception): Add move
8713         constructor.
8714         (struct gdb_exception_error, struct gdb_exception_quit, struct
8715         gdb_quit_bad_alloc): Change constructor to move constructor.
8716         (throw_exception): Change parameter to rvalue reference.
8717         * common/common-exceptions.c (throw_exception): Take rvalue
8718         reference.
8719         * cli/cli-interp.c (safe_execute_command): Use std::move.
8720         * breakpoint.c (insert_bp_location, location_to_sals): Use
8721         std::move.
8722
8723 2019-04-25  Tom Tromey  <tromey@adacore.com>
8724
8725         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8726         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8727         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8728         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8729         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8730         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8731         guile/scm-value.c: Use unpack.
8732         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8733         gdbscm_gdb_exception.
8734         (gdbscm_throw_gdb_exception): Likewise.
8735         (struct gdbscm_gdb_exception): New.
8736         (unpack): New function.
8737         (gdbscm_wrap): Use unpack.
8738
8739 2019-04-25  Tom Tromey  <tromey@adacore.com>
8740
8741         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8742         (gdb_rl_callback_handler): Use std::move.
8743         * common/common-exceptions.h (struct gdb_exception): Add move
8744         assignment operator.
8745         (throw_exception_sjlj): Change "exception" to const reference.
8746         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8747         (throw_exception_sjlj): Change "exception" to const reference.
8748
8749 2019-04-25  Tom Tromey  <tromey@adacore.com>
8750
8751         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8752         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8753         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8754         Update.
8755         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8756         Update.
8757         * mi/mi-interp.c (mi_interp::exec): Update.
8758         * linespec.c (parse_linespec): Update.
8759         * infcall.c (run_inferior_call): Update.
8760         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8761         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8762         (gdbscm_lookup_global_symbol): Update.
8763         * guile/scm-param.c (gdbscm_parameter_value): Update.
8764         * guile/scm-frame.c (gdbscm_frame_read_register)
8765         (gdbscm_frame_read_var): Update.
8766         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8767         * exec.c (try_open_exec_file): Update.
8768         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8769         (gdb_rl_callback_handler): Update.
8770         * common/common-exceptions.h (exception_none): Don't declare.
8771         * common/common-exceptions.c (exception_none): Don't define.
8772         (struct catcher) <exception>: Update.
8773         * cli/cli-interp.c (safe_execute_command): Update.
8774         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8775
8776 2019-04-25  Ali Tamur  <tamur@google.com>
8777
8778         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8779         (read_attribute_value): Likewise.
8780         (dwarf2_read_addr_index): Update comment.
8781         (read_str_index): Add DW_FORM_strx.
8782         (dwarf2_string_attr): Likewise.
8783         (dwarf2_const_value_attr): Likewise.
8784         (dump_die_shallow): Likewise.
8785         (dwarf2_fetch_constant_bytes): Likewise.
8786         (skip_form_bytes): Likewise.
8787         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8788
8789 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8790
8791         PR corefiles/11608
8792         PR corefiles/18187
8793         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8794         OFFSET.  Verify if current mapping contains an ELF header.
8795         (linux_find_memory_regions_full): Adjust call to
8796         dump_mapping_p.
8797
8798 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8799             Kang Li <kanglictf@gmail.com>
8800
8801         PR gdb/21600
8802
8803         * dwarf2-frame.c (read_initial_length): Be consistent about using
8804         unsigned representation of length.
8805         (decode_frame_entry_1): Likewise.  Check for wraparound of
8806         end pointer as well as buffer overflow.
8807
8808 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8809
8810         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8811         "vq".
8812
8813 2019-04-24  Tom Tromey  <tromey@adacore.com>
8814
8815         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8816
8817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8818
8819         * s12z-tdep.c (s12z_unwind_pc): Delete.
8820         (s12z_unwind_sp): Delete.
8821         (s12z_gdbarch_init): Don't register deleted functions with
8822         gdbarch.
8823
8824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8825
8826         * rl78-tdep.c (rl78_unwind_sp): Delete.
8827         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8828
8829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8830
8831         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8832         (xstormy16_unwind_pc): Delete.
8833         (xstormy16_dummy_id): Delete.
8834         (xstormy16_gdbarch_init): Don't register deleted functions with
8835         gdbarch.
8836
8837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8838
8839         * vax-tdep.c (vax_unwind_pc): Delete.
8840         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8841
8842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8843
8844         * v850-tdep.c (v850_unwind_sp): Delete.
8845         (v850_unwind_pc): Delete.
8846         (v850_dummy_id): Delete.
8847         (v850_gdbarch_init): Don't register deleted functions with
8848         gdbarch.
8849
8850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8853         (tilegx_unwind_pc): Delete.
8854         (tilegx_unwind_dummy_id): Delete.
8855         (tilegx_gdbarch_init): Don't register deleted functions with
8856         gdbarch.
8857
8858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8861         (tic6x_dummy_id): Delete.
8862         (tic6x_gdbarch_init): Don't register deleted functions with
8863         gdbarch.
8864
8865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8866
8867         * sparc-tdep.c (sparc_unwind_pc): Delete.
8868         (sparc32_gdbarch_init): Don't register deleted function with
8869         gdbarch.
8870
8871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8872
8873         * sh-tdep.c (sh_unwind_sp): Delete.
8874         (sh_unwind_pc): Delete.
8875         (sh_dummy_id): Delete.
8876         (sh_gdbarch_init): Don't register deleted functions with
8877         gdbarch.
8878
8879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8880
8881         * score-tdep.c (score_unwind_sp): Delete.
8882         (score_unwind_pc): Delete.
8883         (score_dummy_id): Delete.
8884         (score_gdbarch_init): Don't register deleted functions with
8885         gdbarch.
8886
8887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8888
8889         * rx-tdep.c (rx_unwind_pc): Delete.
8890         (rx_unwind_sp): Delete.
8891         (rx_dummy_id): Delete.
8892         (rx_gdbarch_init): Don't register deleted functions with
8893         gdbarch.  Update comment.
8894
8895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8896
8897         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8898         (rs6000_dummy_id): Delete.
8899         (rs6000_gdbarch_init): Don't register deleted functions with
8900         gdbarch.
8901
8902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8903
8904         * or1k-tdep.c (or1k_dummy_id): Delete.
8905         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8906
8907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8908
8909         * nios2-tdep.c (nios2_dummy_id): Delete.
8910         (nios2_unwind_sp): Delete.
8911         (nios2_gdbarch_init): Don't register deleted functions with
8912         gdbarch.
8913
8914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8915
8916         * nds32-tdep.c (nds32_dummy_id): Delete.
8917         (nds32_unwind_pc): Delete.
8918         (nds32_unwind_sp): Delete.
8919         (nds32_gdbarch_init): Don't register deleted functions with
8920         gdbarch.
8921
8922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8923
8924         * msp430-tdep.c (msp430_unwind_pc): Delete.
8925         (msp430_unwind_sp): Delete.
8926         (msp430_dummy_id): Delete.
8927         (msp430_gdbarch_init): Don't register deleted functions with
8928         gdbarch.
8929
8930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8931
8932         * moxie-tdep.c (moxie_unwind_sp): Delete.
8933         (moxie_unwind_pc): Delete.
8934         (moxie_dummy_id): Delete.
8935         (moxie_gdbarch_init): Don't register deleted functions with
8936         gdbarch.
8937
8938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8939
8940         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8941         (mn10300_unwind_pc): Delete.
8942         (mn10300_unwind_sp): Delete.
8943         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8944         mn10300_unwind_sp.
8945         (mn10300_frame_unwind_init): Don't register deleted functions with
8946         gdbarch.
8947
8948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * mep-tdep.c (mep_unwind_pc): Delete.
8951         (mep_unwind_sp): Delete.
8952         (mep_dummy_id): Delete.
8953         (mep_gdbarch_init): Don't register deleted functions with
8954         gdbarch.
8955
8956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8959         (m68hc11_unwind_sp): Delete.
8960         (m68hc11_gdbarch_init): Don't register deleted functions with
8961         gdbarch.
8962
8963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8964
8965         * m32r-tdep.c (m32r_unwind_sp): Delete.
8966         (m32r_unwind_pc): Delete.
8967         (m32r_dummy_id): Delete.
8968         (m32r_gdbarch_init): Don't register deleted functions with
8969         gdbarch.
8970
8971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8972
8973         * m32c-tdep.c (m32c_unwind_pc): Delete.
8974         (m32c_unwind_sp): Delete.
8975         (m32c_dummy_id): Delete.
8976         (m32c_gdbarch_init): Don't register deleted functions with
8977         gdbarch.
8978
8979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8980
8981         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8982         (lm32_unwind_pc): Delete.
8983         (lm32_dummy_id): Delete.
8984         (lm32_gdbarch_init): Don't register deleted functions with
8985         gdbarch.
8986
8987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8988
8989         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8990         (iq2000_unwind_pc): Delete.
8991         (iq2000_dummy_id): Delete.
8992         (iq2000_gdbarch_init): Don't register deleted functions with
8993         gdbarch.
8994
8995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8996
8997         * nds32-tdep.c (nds32_type_align): Delete.
8998         (nds32_push_dummy_call): Use type_align instead.
8999
9000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9001
9002         * arm-tdep.c (arm_type_align): Only handle vector override case.
9003         (arm_push_dummy_call): Use type_align.
9004         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9005
9006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9007
9008         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9009         case.
9010         (pass_on_stack): Use type_align.
9011         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9012         function.
9013
9014 2019-04-23  Tom Tromey  <tromey@adacore.com>
9015
9016         * dwarf2read.c (line_header::file_name_at): Remove unused
9017         overload.
9018
9019 2019-04-23  Tom de Vries  <tdevries@suse.de>
9020
9021         PR gdb/24438
9022         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9023         invocation.
9024
9025
9026 2019-03-27  Ali Tamur  <tamur@google.com>
9027
9028         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9029         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9030         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9031         (dwarf_expr_context::get_addr_index): Likewise
9032         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9033         (symbol_needs_eval_context::get_addr_index): Likewise
9034         (disassemble_dwarf_expression): Add DW_OP_addrx
9035         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9036         (read_cutu_die_from_dwo): Update comment
9037         (skip_one_die): Add DW_FORM_addrx
9038         (read_attribute_value): Likewise
9039         (var_decode_location): Add DW_OP_addrx
9040         (dwarf2_const_value_attr): Add DW_FORM_addrx
9041         (dump_die_shallow): Likewise
9042         (dwarf2_fetch_constant_bytes): Likewise
9043         (decode_locdesc): Add DW_OP_addrx
9044         (skip_form_bytes): Add DW_FORM_addrx
9045
9046 2019-04-22  Ali Tamur  <tamur@google.com>
9047
9048         * MAINTAINERS (Write After Approval): Add self.
9049
9050 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9051
9052         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9053         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9054         (open_symbol_file_object): Likewise.
9055         (svr4_default_sos): Add info parameter.
9056         (svr4_read_so_list): Likewise.
9057         (svr4_current_sos_direct): Adjust functions calls to pass down
9058         info.
9059         (svr4_current_sos_1): Add info parameter.
9060         (svr4_current_sos): Call get_svr4_info, pass info down to
9061         svr4_current_sos_1.
9062         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9063         get_svr4_info.
9064         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9065         get_svr4_info.
9066         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9067         to get_svr4_info.
9068         (probes_table_remove_objfile_probes): Likewise.
9069         (register_solib_event_probe): Add info parameter.
9070         (solist_update_incremental): Pass info parameter down to
9071         svr4_read_so_list.
9072         (disable_probes_interface): Add info parameter.
9073         (svr4_handle_solib_event): Pass current_program_space to
9074         get_svr4_info.  Adjust disable_probes_interface cleanup.
9075         (svr4_create_probe_breakpoints): Add info parameter, pass it
9076         down to register_solib_event_probe.
9077         (svr4_create_solib_event_breakpoints): Add info parameter,
9078         pass it down to svr4_create_probe_breakpoints.
9079         (enable_break): Pass info down to
9080         svr4_create_solib_event_breakpoints.
9081         (svr4_solib_create_inferior_hook): Pass current_program_space to
9082         get_svr4_info.
9083         (svr4_clear_solib): Likewise.
9084
9085 2019-04-22  Pedro Alves  <palves@redhat.com>
9086
9087         * solib-svr4.c (svr4_free_objfile_observer): New.
9088         (probe_and_action::objfile): New field.
9089         (probes_table_htab_remove_objfile_probes)
9090         (probes_table_remove_objfile_probes): New functions.
9091         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9092         in the new probe_and_action.  Don't store the probe in 'lookup'.
9093         (svr4_create_probe_breakpoints): Pass objfile to
9094         register_solib_event_probe.
9095         (_initialize_svr4_solib): Register a free_objfile observer.
9096
9097 2019-04-19  Tom Tromey  <tom@tromey.com>
9098
9099         * common/queue.h: Remove.
9100
9101 2019-04-19  Tom Tromey  <tom@tromey.com>
9102
9103         * event-loop.c: Don't include "common/queue.h".
9104
9105 2019-04-19  Tom Tromey  <tom@tromey.com>
9106
9107         * remote.c (remote_target): Use delete.
9108         * remote-notif.h: Include <list>, not "common/queue.h".
9109         (notif_client_p): Remove typedef.
9110         (remote_notif_state): Add constructor, destructor, initializer.
9111         <notif_queue>: Now a std::list.
9112         (remote_notif_state_xfree): Don't declare.
9113         * remote-notif.c (remote_notif_process, handle_notification)
9114         (remote_notif_state_allocate): Update.
9115         (~remote_notif_state): Rename from remote_notif_state_xfree.
9116
9117 2019-04-19  Tom Tromey  <tom@tromey.com>
9118
9119         * symfile.c (reread_symbols): Update.
9120         * objfiles.c (objfile_register_static_link)
9121         (objfile_lookup_static_link): Update
9122         (~objfile) Don't delete static_links.
9123         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9124
9125 2019-04-19  Tom Tromey  <tom@tromey.com>
9126
9127         * type-stack.h (struct type_stack) <insert>: Constify string.
9128         * type-stack.c (type_stack::insert): Constify string.
9129         * gdbtypes.h (lookup_template_type): Update.
9130         (address_space_name_to_int): Update.
9131         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9132         const.
9133         (lookup_template_type): Make name const.
9134         * c-exp.y: Update rules.
9135         (lex_one_token, classify_name, classify_inner_name)
9136         (c_print_token): Update.
9137         * p-exp.y: Update rules.
9138         (yylex): Update.
9139         * f-exp.y: Update rules.
9140         (yylex): Update.
9141         * d-exp.y: Update rules.
9142         (lex_one_token, classify_name, classify_inner_name): Update.
9143         * parse.c (write_dollar_variable, copy_name): Return std::string.
9144         * parser-defs.h (copy_name): Change return type.
9145         * m2-exp.y: Update rules.
9146         (yylex): Update.
9147         * go-exp.y (lex_one_token): Update.
9148         Update rules.
9149         (classify_unsafe_function, classify_packaged_name)
9150         (classify_name, yylex): Update.
9151
9152 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9153
9154         * configure.ac: add --enable-source-highlight switch.
9155         * configure: Regenerate.
9156         * top.c (print_gdb_version): plumb --enable-source-highlight
9157         status to "show configuration".
9158
9159 2019-04-19  Tom Tromey  <tromey@adacore.com>
9160
9161         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9162         Check ADA_TYPE_P.
9163         (empty_record, ada_template_to_fixed_record_type_1)
9164         (template_to_static_fixed_type)
9165         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9166         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9167         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9168         macros.
9169
9170 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9171
9172         PR symtab/24423:
9173         * source.c (print_source_lines_base): Advance "iter" when a
9174         control character is seen.
9175
9176 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9177
9178         * inferior.h (struct infcall_suspend_state_deleter):
9179         Catch exception in destructor to avoid crash.
9180
9181 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9182
9183         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9184         close to the add_com "shell".
9185
9186 2019-04-18  Tom Tromey  <tromey@adacore.com>
9187
9188         * process-stratum-target.h (class process_stratum_target)
9189         <stratum>: Add "final".
9190
9191 2019-04-17  Tom Tromey  <tromey@adacore.com>
9192
9193         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9194         against nullptr before use.
9195
9196 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9197
9198         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9199
9200 2019-04-17  Jim Wilson  <jimw@sifive.com>
9201             Andrew Burgess  <andrew.burgess@embecosm.com>
9202
9203         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9204         code read might fail, assume 4-byte breakpoint in that case.
9205
9206 2019-04-15  Leszek Swirski  <leszeks@google.com>
9207
9208         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9209         rather than a hand-rolled POD check when checking for forced MEMORY
9210         classification.
9211
9212 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9213
9214         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9215         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9216         function.
9217         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9218         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9219         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9220         declaration.
9221
9222 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9223
9224         * aarch64-linux-nat.c
9225         (aarch64_linux_nat_target::thread_architecture): Add override.
9226         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9227         each VQ.
9228
9229 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9230
9231         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9232
9233 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9234
9235         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9236         target types of size 96-bits, add some additional comments, and
9237         check that the builtin type we found was the correct size.
9238
9239 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9240
9241         * utils.c (prompt_for_continue): Don't restore the styling at the
9242         end, as applied_style has the wrong value.  This fixes styling in
9243         long lists of file names that are interrupted by the "Continue?"
9244         prompt.
9245
9246 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9247
9248         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9249         * c-lang.c (c_language_defn): Likewise.
9250         (cplus_language_defn): Likewise.
9251         (asm_language_defn): Likewise.
9252         (minimal_language_defn): Likewise.
9253         * d-lang.c (d_language_defn): Likewise.
9254         * f-lang.c (f_language_defn): Likewise.
9255         * go-lang.c (go_language_defn): Likewise.
9256         * language.c (unknown_language_defn): Likewise.
9257         (auto_language_defn): Likewise.
9258         * language.h (struct language_defn): Remove la_magic field.
9259         (LANG_MAGIC): Delete.
9260         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9261         * objc-lang.c (objc_language_defn): Likewise.
9262         * opencl-lang.c (opencl_language_defn): Likewise.
9263         * p-lang.c (pascal_language_defn): Likewise.
9264         * rust-lang.c (rust_language_defn): Likewise.
9265
9266 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * riscv-tdep.c (riscv_type_align): New function.
9269         (riscv_type_alignment): Delete.
9270         (riscv_arg_location): Use 'type_align'.
9271         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9272
9273 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9274
9275         * gdbtypes.c (type_align): A struct with no non-static fields also
9276         has alignment of 1.
9277
9278 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9279
9280         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9281         component to 0.
9282         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9283         member.
9284         (riscv_struct_info::analyse): New implementation using new
9285         analyse_inner member function.
9286         (riscv_struct_info::field_offset): New member function.
9287         (riscv_struct_info::m_offsets): New member variable.
9288         (riscv_struct_info::analyse_inner): New private member function,
9289         takes the old implementation of riscv_struct_info::analyse but
9290         extended to track field offsets.
9291         (riscv_call_arg_struct): Update the struct folding special cases
9292         to handle cases where empty C++ structs, which are non-zero
9293         length, are found.
9294         (riscv_arg_location): Initialise the length of each location, a
9295         non-zero length now indicates the location is in use.
9296         (riscv_push_dummy_call): Allow for the first location having a
9297         non-zero offset when setting up arguments.
9298         (riscv_return_value): Likewise, but for return values.
9299
9300 2019-04-11  Tom Tromey  <tromey@adacore.com>
9301
9302         * utils.c (internal_vproblem): Make "msg" const.
9303
9304 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9305
9306         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9307         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9308         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9309         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9310
9311 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9312
9313         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9314         function.
9315         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9316         of amd64_collect_native_gregset.
9317         (amd64_linux_nat_target::store_registers): Likewise.
9318
9319 2019-04-10  Tom Tromey  <tom@tromey.com>
9320
9321         * symtab.c (lookup_global_symbol_from_objfile)
9322         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9323         * objfiles.h (class separate_debug_iterator): New.
9324         (class separate_debug_range): New.
9325         (struct objfile) <separate_debug_objfiles>: New method.
9326         (objfile_separate_debug_iterate): Don't declare.
9327         * objfiles.c (separate_debug_iterator::operator++): Rename from
9328         objfile_separate_debug_iterate.
9329         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9330         iterator.
9331         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9332         iterator.
9333
9334 2019-04-10  Tom Tromey  <tom@tromey.com>
9335
9336         * symfile.c (reread_symbols): Remove old comment.
9337         * objfiles.c (free_all_objfiles): Fix a typo.
9338
9339 2019-04-10  Tom Tromey  <tom@tromey.com>
9340
9341         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9342         * minsyms.c (lookup_minimal_symbol): Use foreach.
9343         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9344         (lookup_minimal_symbol_solib_trampoline): Likewise.
9345         * symfile.c (reread_symbols): Use foreach.
9346
9347 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9348             Tom Tromey  <tromey@adacore.com>
9349
9350         PR rust/24414:
9351         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9352         (rust_lex_int_test): Change "value" to be LONGEST.
9353         (rust_lex_tests): Add test for long integer literal.
9354
9355 2019-04-09  Tom Tromey  <tromey@adacore.com>
9356
9357         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9358         to bool.
9359         (extended_remote_target::attach): Update.
9360         (remote_target::remote_notice_new_inferior): Update.
9361         (remote_target::add_current_inferior_and_thread): Update.
9362         * inferior.c (exit_inferior_1): Use "false".
9363         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9364
9365 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9366
9367         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9368         the "start" command.
9369
9370 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9371
9372         * python/py-inferior.c (infpy_thread_from_thread_handle):
9373         Adjust comments to reflect renaming of thread_from_thread_handle
9374         to thread_from_handle.  Adjust keywords.  Fix type error message.
9375         (inferior_object_methods): Add thread_from_handle.  Retain
9376         thread_from_thread_handle, but mark it as deprecated.
9377
9378 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9379
9380         * gdbthread.h (find_thread_by_handle): Revise declaration.
9381         * thread.c (find_thread_by_handle): Likewise.  Adjust
9382         implementation too.
9383         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9384         support for buffer objects as handles.
9385
9386 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9387
9388         * python/py-infthread.c (thpy_thread_handle): New function.
9389         (thread_object_methods): Register thpy_thread_handle.
9390
9391 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9392
9393         * gdbthread.h (thread_to_thread_handle): Declare.
9394         * thread.c (gdbtypes.h): Include.
9395         (thread_to_thread_handle): New function.
9396
9397         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9398         (target_thread_info_to_thread_handle): Declare.
9399         * target.c (target_thread_info_to_thread_handle): New function.
9400         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9401         * target-delegates.c: Regenerate.
9402
9403         * linux-thread-db.c (class thread_db_target): Add method
9404         thread_info_to_thread_handle.
9405         (thread_db_target::thread_info_to_thread_handle): Define.
9406         * remote.c (class remote_target): Add new method
9407         thread_info_to_thread_handle.
9408         (remote_target::thread_info_to_thread_handle): Define.
9409
9410 2019-04-08  Pedro Alves  <palves@redhat.com>
9411
9412         * common/common-exceptions.c (throw_exception): Don't create
9413         named object to throw; throw directly.
9414         (throw_it): Likewise.  Don't initialize gdb_exception::message
9415         here, with new; pass FMT and AP to the ctor instead.
9416         * common/common-exceptions.h: Include <string>.
9417         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9418         const char *, va_list)): New ctor.  Use std::make_shared.
9419         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9420         errors)): Delete.
9421         (gdb_exception_error::gdb_exception_error(enum errors, const char
9422         *, va_list)): New.
9423         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9424         Add assertion.
9425         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9426         errors)): Delete.
9427         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9428         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9429         Add assertion.
9430
9431 2019-04-08  Tom Tromey  <tom@tromey.com>
9432
9433         * valops.c (value_rtti_indirect_type): Replace throw_exception
9434         with throw.
9435         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9436         with throw.
9437         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9438         throw.
9439         * target.c (target_translate_tls_address): Replace throw_exception
9440         with throw.
9441         * stack.c (frame_apply_command_count): Replace throw_exception
9442         with throw.
9443         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9444         throw.
9445         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9446         with throw.
9447         * rs6000-tdep.c (rs6000_frame_cache)
9448         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9449         * remote.c: Replace throw_exception with throw.
9450         * record-full.c (record_full_message, record_full_wait_1)
9451         (record_full_restore): Replace throw_exception with throw.
9452         * record-btrace.c:
9453         (get_thread_current_frame_id, record_btrace_start_replaying)
9454         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9455         (cmd_record_btrace_start): Replace throw_exception with throw.
9456         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9457         throw.
9458         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9459         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9460         * linespec.c:
9461         (find_linespec_symbols): Replace throw_exception with throw.
9462         * infrun.c (displaced_step_prepare, resume): Replace
9463         throw_exception with throw.
9464         * infcmd.c (post_create_inferior): Replace throw_exception with
9465         throw.
9466         * inf-loop.c (inferior_event_handler): Replace throw_exception
9467         with throw.
9468         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9469         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9470         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9471         (get_prev_frame_always, get_frame_pc_if_available)
9472         (get_frame_address_in_block_if_available, get_frame_language):
9473         Replace throw_exception with throw.
9474         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9475         throw_exception with throw.
9476         * eval.c (fetch_subexp_value, evaluate_var_value)
9477         (evaluate_funcall, evaluate_subexp_standard): Replace
9478         throw_exception with throw.
9479         * dwarf2loc.c (call_site_find_chain)
9480         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9481         Replace throw_exception with throw.
9482         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9483         with throw.
9484         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9485         throw.
9486         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9487         * completer.c (complete_line_internal): Replace throw_exception
9488         with throw.
9489         * compile/compile-object-run.c (compile_object_run): Replace
9490         throw_exception with throw.
9491         * cli/cli-script.c (process_next_line): Replace throw_exception
9492         with throw.
9493         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9494         (btrace_enable, btrace_maint_update_pt_packets): Replace
9495         throw_exception with throw.
9496         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9497         throw_exception with throw.
9498         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9499         throw_exception with throw.
9500         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9501         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9502         * aarch64-tdep.c (aarch64_make_prologue_cache)
9503         (aarch64_make_stub_cache): Replace throw_exception with throw.
9504
9505 2019-04-08  Tom Tromey  <tom@tromey.com>
9506
9507         * common/common-exceptions.c (throw_exception): Rename from
9508         throw_exception_cxx.  Remove old copy.  Make argument const.
9509         (throw_it): Create and throw exception objects directly.
9510         * common/common-exceptions.h (throw_exception): Make argument
9511         const.
9512         (struct gdb_exception_error): Add constructor.
9513         (struct gdb_exception_quit): Add constructor.
9514
9515 2019-04-08  Tom Tromey  <tom@tromey.com>
9516
9517         * common/common-exceptions.h (exception_rethrow): Don't declare.
9518         (TRY_SJLJ): Update comment.
9519         (TRY, CATCH, END_CATCH): Remove.
9520         * common/common-exceptions.c (exception_rethrow): Remove.
9521
9522 2019-04-08  Tom Tromey  <tom@tromey.com>
9523
9524         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9525         Remove.
9526         (gdb_exception_error): Rename from
9527         gdb_exception_RETURN_MASK_ERROR.
9528         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9529         (gdb_quit_bad_alloc): Update.
9530         * aarch64-tdep.c: Update.
9531         * ada-lang.c: Update.
9532         * ada-typeprint.c: Update.
9533         * ada-valprint.c: Update.
9534         * amd64-tdep.c: Update.
9535         * arch-utils.c: Update.
9536         * break-catch-throw.c: Update.
9537         * breakpoint.c: Update.
9538         * btrace.c: Update.
9539         * c-varobj.c: Update.
9540         * cli/cli-cmds.c: Update.
9541         * cli/cli-interp.c: Update.
9542         * cli/cli-script.c: Update.
9543         * common/common-exceptions.c: Update.
9544         * common/new-op.c: Update.
9545         * common/selftest.c: Update.
9546         * compile/compile-c-symbols.c: Update.
9547         * compile/compile-cplus-symbols.c: Update.
9548         * compile/compile-object-load.c: Update.
9549         * compile/compile-object-run.c: Update.
9550         * completer.c: Update.
9551         * corelow.c: Update.
9552         * cp-abi.c: Update.
9553         * cp-support.c: Update.
9554         * cp-valprint.c: Update.
9555         * darwin-nat.c: Update.
9556         * disasm-selftests.c: Update.
9557         * dtrace-probe.c: Update.
9558         * dwarf-index-cache.c: Update.
9559         * dwarf-index-write.c: Update.
9560         * dwarf2-frame-tailcall.c: Update.
9561         * dwarf2-frame.c: Update.
9562         * dwarf2loc.c: Update.
9563         * dwarf2read.c: Update.
9564         * eval.c: Update.
9565         * event-loop.c: Update.
9566         * event-top.c: Update.
9567         * exec.c: Update.
9568         * f-valprint.c: Update.
9569         * fbsd-tdep.c: Update.
9570         * frame-unwind.c: Update.
9571         * frame.c: Update.
9572         * gdbtypes.c: Update.
9573         * gnu-v3-abi.c: Update.
9574         * guile/guile-internal.h: Update.
9575         * guile/scm-block.c: Update.
9576         * guile/scm-breakpoint.c: Update.
9577         * guile/scm-cmd.c: Update.
9578         * guile/scm-disasm.c: Update.
9579         * guile/scm-frame.c: Update.
9580         * guile/scm-lazy-string.c: Update.
9581         * guile/scm-math.c: Update.
9582         * guile/scm-param.c: Update.
9583         * guile/scm-ports.c: Update.
9584         * guile/scm-pretty-print.c: Update.
9585         * guile/scm-symbol.c: Update.
9586         * guile/scm-symtab.c: Update.
9587         * guile/scm-type.c: Update.
9588         * guile/scm-value.c: Update.
9589         * i386-linux-tdep.c: Update.
9590         * i386-tdep.c: Update.
9591         * inf-loop.c: Update.
9592         * infcall.c: Update.
9593         * infcmd.c: Update.
9594         * infrun.c: Update.
9595         * jit.c: Update.
9596         * language.c: Update.
9597         * linespec.c: Update.
9598         * linux-fork.c: Update.
9599         * linux-nat.c: Update.
9600         * linux-tdep.c: Update.
9601         * linux-thread-db.c: Update.
9602         * main.c: Update.
9603         * mi/mi-cmd-break.c: Update.
9604         * mi/mi-cmd-stack.c: Update.
9605         * mi/mi-interp.c: Update.
9606         * mi/mi-main.c: Update.
9607         * objc-lang.c: Update.
9608         * p-valprint.c: Update.
9609         * parse.c: Update.
9610         * ppc-linux-tdep.c: Update.
9611         * printcmd.c: Update.
9612         * python/py-arch.c: Update.
9613         * python/py-breakpoint.c: Update.
9614         * python/py-cmd.c: Update.
9615         * python/py-finishbreakpoint.c: Update.
9616         * python/py-frame.c: Update.
9617         * python/py-framefilter.c: Update.
9618         * python/py-gdb-readline.c: Update.
9619         * python/py-inferior.c: Update.
9620         * python/py-infthread.c: Update.
9621         * python/py-lazy-string.c: Update.
9622         * python/py-linetable.c: Update.
9623         * python/py-objfile.c: Update.
9624         * python/py-param.c: Update.
9625         * python/py-prettyprint.c: Update.
9626         * python/py-progspace.c: Update.
9627         * python/py-record-btrace.c: Update.
9628         * python/py-record.c: Update.
9629         * python/py-symbol.c: Update.
9630         * python/py-type.c: Update.
9631         * python/py-unwind.c: Update.
9632         * python/py-utils.c: Update.
9633         * python/py-value.c: Update.
9634         * python/python.c: Update.
9635         * record-btrace.c: Update.
9636         * record-full.c: Update.
9637         * remote-fileio.c: Update.
9638         * remote.c: Update.
9639         * riscv-tdep.c: Update.
9640         * rs6000-aix-tdep.c: Update.
9641         * rs6000-tdep.c: Update.
9642         * rust-exp.y: Update.
9643         * rust-lang.c: Update.
9644         * s390-tdep.c: Update.
9645         * selftest-arch.c: Update.
9646         * solib-dsbt.c: Update.
9647         * solib-frv.c: Update.
9648         * solib-spu.c: Update.
9649         * solib-svr4.c: Update.
9650         * solib.c: Update.
9651         * sparc64-linux-tdep.c: Update.
9652         * stack.c: Update.
9653         * symfile-mem.c: Update.
9654         * symmisc.c: Update.
9655         * target.c: Update.
9656         * thread.c: Update.
9657         * top.c: Update.
9658         * tracefile-tfile.c: Update.
9659         * tui/tui.c: Update.
9660         * typeprint.c: Update.
9661         * unittests/cli-utils-selftests.c: Update.
9662         * unittests/parse-connection-spec-selftests.c: Update.
9663         * valops.c: Update.
9664         * valprint.c: Update.
9665         * value.c: Update.
9666         * varobj.c: Update.
9667         * windows-nat.c: Update.
9668         * x86-linux-nat.c: Update.
9669         * xml-support.c: Update.
9670
9671 2019-04-08  Tom Tromey  <tom@tromey.com>
9672
9673         * xml-support.c: Use C++ exception handling.
9674         * x86-linux-nat.c: Use C++ exception handling.
9675         * windows-nat.c: Use C++ exception handling.
9676         * varobj.c: Use C++ exception handling.
9677         * value.c: Use C++ exception handling.
9678         * valprint.c: Use C++ exception handling.
9679         * valops.c: Use C++ exception handling.
9680         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9681         handling.
9682         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9683         * typeprint.c: Use C++ exception handling.
9684         * tui/tui.c: Use C++ exception handling.
9685         * tracefile-tfile.c: Use C++ exception handling.
9686         * top.c: Use C++ exception handling.
9687         * thread.c: Use C++ exception handling.
9688         * target.c: Use C++ exception handling.
9689         * symmisc.c: Use C++ exception handling.
9690         * symfile-mem.c: Use C++ exception handling.
9691         * stack.c: Use C++ exception handling.
9692         * sparc64-linux-tdep.c: Use C++ exception handling.
9693         * solib.c: Use C++ exception handling.
9694         * solib-svr4.c: Use C++ exception handling.
9695         * solib-spu.c: Use C++ exception handling.
9696         * solib-frv.c: Use C++ exception handling.
9697         * solib-dsbt.c: Use C++ exception handling.
9698         * selftest-arch.c: Use C++ exception handling.
9699         * s390-tdep.c: Use C++ exception handling.
9700         * rust-lang.c: Use C++ exception handling.
9701         * rust-exp.y: Use C++ exception handling.
9702         * rs6000-tdep.c: Use C++ exception handling.
9703         * rs6000-aix-tdep.c: Use C++ exception handling.
9704         * riscv-tdep.c: Use C++ exception handling.
9705         * remote.c: Use C++ exception handling.
9706         * remote-fileio.c: Use C++ exception handling.
9707         * record-full.c: Use C++ exception handling.
9708         * record-btrace.c: Use C++ exception handling.
9709         * python/python.c: Use C++ exception handling.
9710         * python/py-value.c: Use C++ exception handling.
9711         * python/py-utils.c: Use C++ exception handling.
9712         * python/py-unwind.c: Use C++ exception handling.
9713         * python/py-type.c: Use C++ exception handling.
9714         * python/py-symbol.c: Use C++ exception handling.
9715         * python/py-record.c: Use C++ exception handling.
9716         * python/py-record-btrace.c: Use C++ exception handling.
9717         * python/py-progspace.c: Use C++ exception handling.
9718         * python/py-prettyprint.c: Use C++ exception handling.
9719         * python/py-param.c: Use C++ exception handling.
9720         * python/py-objfile.c: Use C++ exception handling.
9721         * python/py-linetable.c: Use C++ exception handling.
9722         * python/py-lazy-string.c: Use C++ exception handling.
9723         * python/py-infthread.c: Use C++ exception handling.
9724         * python/py-inferior.c: Use C++ exception handling.
9725         * python/py-gdb-readline.c: Use C++ exception handling.
9726         * python/py-framefilter.c: Use C++ exception handling.
9727         * python/py-frame.c: Use C++ exception handling.
9728         * python/py-finishbreakpoint.c: Use C++ exception handling.
9729         * python/py-cmd.c: Use C++ exception handling.
9730         * python/py-breakpoint.c: Use C++ exception handling.
9731         * python/py-arch.c: Use C++ exception handling.
9732         * printcmd.c: Use C++ exception handling.
9733         * ppc-linux-tdep.c: Use C++ exception handling.
9734         * parse.c: Use C++ exception handling.
9735         * p-valprint.c: Use C++ exception handling.
9736         * objc-lang.c: Use C++ exception handling.
9737         * mi/mi-main.c: Use C++ exception handling.
9738         * mi/mi-interp.c: Use C++ exception handling.
9739         * mi/mi-cmd-stack.c: Use C++ exception handling.
9740         * mi/mi-cmd-break.c: Use C++ exception handling.
9741         * main.c: Use C++ exception handling.
9742         * linux-thread-db.c: Use C++ exception handling.
9743         * linux-tdep.c: Use C++ exception handling.
9744         * linux-nat.c: Use C++ exception handling.
9745         * linux-fork.c: Use C++ exception handling.
9746         * linespec.c: Use C++ exception handling.
9747         * language.c: Use C++ exception handling.
9748         * jit.c: Use C++ exception handling.
9749         * infrun.c: Use C++ exception handling.
9750         * infcmd.c: Use C++ exception handling.
9751         * infcall.c: Use C++ exception handling.
9752         * inf-loop.c: Use C++ exception handling.
9753         * i386-tdep.c: Use C++ exception handling.
9754         * i386-linux-tdep.c: Use C++ exception handling.
9755         * guile/scm-value.c: Use C++ exception handling.
9756         * guile/scm-type.c: Use C++ exception handling.
9757         * guile/scm-symtab.c: Use C++ exception handling.
9758         * guile/scm-symbol.c: Use C++ exception handling.
9759         * guile/scm-pretty-print.c: Use C++ exception handling.
9760         * guile/scm-ports.c: Use C++ exception handling.
9761         * guile/scm-param.c: Use C++ exception handling.
9762         * guile/scm-math.c: Use C++ exception handling.
9763         * guile/scm-lazy-string.c: Use C++ exception handling.
9764         * guile/scm-frame.c: Use C++ exception handling.
9765         * guile/scm-disasm.c: Use C++ exception handling.
9766         * guile/scm-cmd.c: Use C++ exception handling.
9767         * guile/scm-breakpoint.c: Use C++ exception handling.
9768         * guile/scm-block.c: Use C++ exception handling.
9769         * guile/guile-internal.h: Use C++ exception handling.
9770         * gnu-v3-abi.c: Use C++ exception handling.
9771         * gdbtypes.c: Use C++ exception handling.
9772         * frame.c: Use C++ exception handling.
9773         * frame-unwind.c: Use C++ exception handling.
9774         * fbsd-tdep.c: Use C++ exception handling.
9775         * f-valprint.c: Use C++ exception handling.
9776         * exec.c: Use C++ exception handling.
9777         * event-top.c: Use C++ exception handling.
9778         * event-loop.c: Use C++ exception handling.
9779         * eval.c: Use C++ exception handling.
9780         * dwarf2read.c: Use C++ exception handling.
9781         * dwarf2loc.c: Use C++ exception handling.
9782         * dwarf2-frame.c: Use C++ exception handling.
9783         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9784         * dwarf-index-write.c: Use C++ exception handling.
9785         * dwarf-index-cache.c: Use C++ exception handling.
9786         * dtrace-probe.c: Use C++ exception handling.
9787         * disasm-selftests.c: Use C++ exception handling.
9788         * darwin-nat.c: Use C++ exception handling.
9789         * cp-valprint.c: Use C++ exception handling.
9790         * cp-support.c: Use C++ exception handling.
9791         * cp-abi.c: Use C++ exception handling.
9792         * corelow.c: Use C++ exception handling.
9793         * completer.c: Use C++ exception handling.
9794         * compile/compile-object-run.c: Use C++ exception handling.
9795         * compile/compile-object-load.c: Use C++ exception handling.
9796         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9797         * compile/compile-c-symbols.c: Use C++ exception handling.
9798         * common/selftest.c: Use C++ exception handling.
9799         * common/new-op.c: Use C++ exception handling.
9800         * cli/cli-script.c: Use C++ exception handling.
9801         * cli/cli-interp.c: Use C++ exception handling.
9802         * cli/cli-cmds.c: Use C++ exception handling.
9803         * c-varobj.c: Use C++ exception handling.
9804         * btrace.c: Use C++ exception handling.
9805         * breakpoint.c: Use C++ exception handling.
9806         * break-catch-throw.c: Use C++ exception handling.
9807         * arch-utils.c: Use C++ exception handling.
9808         * amd64-tdep.c: Use C++ exception handling.
9809         * ada-valprint.c: Use C++ exception handling.
9810         * ada-typeprint.c: Use C++ exception handling.
9811         * ada-lang.c: Use C++ exception handling.
9812         * aarch64-tdep.c: Use C++ exception handling.
9813
9814 2019-04-08  Tom Tromey  <tom@tromey.com>
9815
9816         * xml-support.c (gdb_xml_parser::parse): Update.
9817         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9818         * value.c (show_convenience): Update.
9819         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9820         (test_parse_flags_qcs): Update.
9821         * thread.c (thr_try_catch_cmd): Update.
9822         * target.c (target_translate_tls_address): Update.
9823         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9824         (info_frame_command_core, frame_apply_command_count): Update.
9825         * rust-exp.y (rust_lex_exception_test): Update.
9826         * riscv-tdep.c (riscv_print_one_register_info): Update.
9827         * remote.c (remote_target::enable_btrace): Update.
9828         * record-btrace.c (record_btrace_enable_warn): Update.
9829         * python/py-utils.c (gdbpy_convert_exception): Update.
9830         * printcmd.c (do_one_display, print_variable_and_value): Update.
9831         * mi/mi-main.c (mi_print_exception): Update.
9832         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9833         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9834         * linux-nat.c (linux_nat_target::attach): Update.
9835         * linux-fork.c (class scoped_switch_fork_info): Update.
9836         * infrun.c (displaced_step_prepare): Update.
9837         * infcall.c (call_function_by_hand_dummy): Update.
9838         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9839         * gnu-v3-abi.c (print_one_vtable): Update.
9840         * frame.c (get_prev_frame_always): Update.
9841         * f-valprint.c (info_common_command_for_block): Update.
9842         * exec.c (try_open_exec_file): Update.
9843         * exceptions.c (print_exception, exception_print)
9844         (exception_fprintf, exception_print_same): Update.
9845         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9846         * dwarf-index-cache.c (index_cache::store)
9847         (index_cache::lookup_gdb_index): Update.
9848         * darwin-nat.c (maybe_cache_shell): Update.
9849         * cp-valprint.c (cp_print_value_fields): Update.
9850         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9851         (gcc_cplus_symbol_address): Update.
9852         * compile/compile-c-symbols.c (gcc_convert_symbol)
9853         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9854         * common/selftest.c: Update.
9855         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9856         a std::string.
9857         (exception_try_scope_entry, exception_try_scope_exit): Don't
9858         declare.
9859         (struct exception_try_scope): Remove.
9860         (TRY): Don't use exception_try_scope.
9861         (struct gdb_exception): Add constructor, operator=.
9862         <what>: New method.
9863         (struct gdb_exception_RETURN_MASK_ALL)
9864         (struct gdb_exception_RETURN_MASK_ERROR)
9865         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9866         (struct gdb_quit_bad_alloc): Update.
9867         * common/common-exceptions.c (exception_none): Change
9868         initializer.
9869         (struct catcher) <state, exception>: Initialize inline.
9870         <prev>: Remove member.
9871         (current_catcher): Remove.
9872         (catchers): New global.
9873         (exceptions_state_mc_init): Simplify.
9874         (catcher_pop): Remove.
9875         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9876         (try_scope_depth, exception_try_scope_entry)
9877         (exception_try_scope_exit): Remove.
9878         (throw_exception_sjlj): Update.
9879         (exception_messages, exception_messages_size): Remove.
9880         (throw_it): Simplify.
9881         (gdb_exception_sliced_copy): Remove.
9882         (throw_exception_cxx): Update.
9883         * cli/cli-script.c (script_from_file): Update.
9884         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9885         Update.
9886         * ada-valprint.c (ada_val_print): Update.
9887         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9888         (create_excep_cond_exprs): Update.
9889
9890 2019-04-08  Tom Tromey  <tom@tromey.com>
9891
9892         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9893         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9894         (TRY, CATCH, END_CATCH): Remove some definitions.
9895         * common/common-exceptions.c: Don't use GDB_XCPT.
9896         (catcher_list_size): Remove.
9897         (throw_exception, throw_it): Simplify.
9898
9899 2019-04-05  Tom Tromey  <tom@tromey.com>
9900
9901         Revert the header-sorting patch.
9902         * ft32-tdep.c: Revert.
9903         * frv-tdep.c: Revert.
9904         * frv-linux-tdep.c: Revert.
9905         * frame.c: Revert.
9906         * frame-unwind.c: Revert.
9907         * frame-base.c: Revert.
9908         * fork-child.c: Revert.
9909         * findvar.c: Revert.
9910         * findcmd.c: Revert.
9911         * filesystem.c: Revert.
9912         * filename-seen-cache.h: Revert.
9913         * filename-seen-cache.c: Revert.
9914         * fbsd-tdep.c: Revert.
9915         * fbsd-nat.h: Revert.
9916         * fbsd-nat.c: Revert.
9917         * f-valprint.c: Revert.
9918         * f-typeprint.c: Revert.
9919         * f-lang.c: Revert.
9920         * extension.h: Revert.
9921         * extension.c: Revert.
9922         * extension-priv.h: Revert.
9923         * expprint.c: Revert.
9924         * exec.h: Revert.
9925         * exec.c: Revert.
9926         * exceptions.c: Revert.
9927         * event-top.c: Revert.
9928         * event-loop.c: Revert.
9929         * eval.c: Revert.
9930         * elfread.c: Revert.
9931         * dwarf2read.h: Revert.
9932         * dwarf2read.c: Revert.
9933         * dwarf2loc.c: Revert.
9934         * dwarf2expr.h: Revert.
9935         * dwarf2expr.c: Revert.
9936         * dwarf2-frame.c: Revert.
9937         * dwarf2-frame-tailcall.c: Revert.
9938         * dwarf-index-write.h: Revert.
9939         * dwarf-index-write.c: Revert.
9940         * dwarf-index-common.c: Revert.
9941         * dwarf-index-cache.h: Revert.
9942         * dwarf-index-cache.c: Revert.
9943         * dummy-frame.c: Revert.
9944         * dtrace-probe.c: Revert.
9945         * disasm.h: Revert.
9946         * disasm.c: Revert.
9947         * disasm-selftests.c: Revert.
9948         * dictionary.c: Revert.
9949         * dicos-tdep.c: Revert.
9950         * demangle.c: Revert.
9951         * dcache.h: Revert.
9952         * dcache.c: Revert.
9953         * darwin-nat.h: Revert.
9954         * darwin-nat.c: Revert.
9955         * darwin-nat-info.c: Revert.
9956         * d-valprint.c: Revert.
9957         * d-namespace.c: Revert.
9958         * d-lang.c: Revert.
9959         * ctf.c: Revert.
9960         * csky-tdep.c: Revert.
9961         * csky-linux-tdep.c: Revert.
9962         * cris-tdep.c: Revert.
9963         * cris-linux-tdep.c: Revert.
9964         * cp-valprint.c: Revert.
9965         * cp-support.c: Revert.
9966         * cp-namespace.c: Revert.
9967         * cp-abi.c: Revert.
9968         * corelow.c: Revert.
9969         * corefile.c: Revert.
9970         * continuations.c: Revert.
9971         * completer.h: Revert.
9972         * completer.c: Revert.
9973         * complaints.c: Revert.
9974         * coffread.c: Revert.
9975         * coff-pe-read.c: Revert.
9976         * cli-out.h: Revert.
9977         * cli-out.c: Revert.
9978         * charset.c: Revert.
9979         * c-varobj.c: Revert.
9980         * c-valprint.c: Revert.
9981         * c-typeprint.c: Revert.
9982         * c-lang.c: Revert.
9983         * buildsym.c: Revert.
9984         * buildsym-legacy.c: Revert.
9985         * build-id.h: Revert.
9986         * build-id.c: Revert.
9987         * btrace.c: Revert.
9988         * bsd-uthread.c: Revert.
9989         * breakpoint.h: Revert.
9990         * breakpoint.c: Revert.
9991         * break-catch-throw.c: Revert.
9992         * break-catch-syscall.c: Revert.
9993         * break-catch-sig.c: Revert.
9994         * blockframe.c: Revert.
9995         * block.c: Revert.
9996         * bfin-tdep.c: Revert.
9997         * bfin-linux-tdep.c: Revert.
9998         * bfd-target.c: Revert.
9999         * bcache.c: Revert.
10000         * ax-general.c: Revert.
10001         * ax-gdb.h: Revert.
10002         * ax-gdb.c: Revert.
10003         * avr-tdep.c: Revert.
10004         * auxv.c: Revert.
10005         * auto-load.c: Revert.
10006         * arm-wince-tdep.c: Revert.
10007         * arm-tdep.c: Revert.
10008         * arm-symbian-tdep.c: Revert.
10009         * arm-pikeos-tdep.c: Revert.
10010         * arm-obsd-tdep.c: Revert.
10011         * arm-nbsd-tdep.c: Revert.
10012         * arm-nbsd-nat.c: Revert.
10013         * arm-linux-tdep.c: Revert.
10014         * arm-linux-nat.c: Revert.
10015         * arm-fbsd-tdep.c: Revert.
10016         * arm-fbsd-nat.c: Revert.
10017         * arm-bsd-tdep.c: Revert.
10018         * arch-utils.c: Revert.
10019         * arc-tdep.c: Revert.
10020         * arc-newlib-tdep.c: Revert.
10021         * annotate.h: Revert.
10022         * annotate.c: Revert.
10023         * amd64-windows-tdep.c: Revert.
10024         * amd64-windows-nat.c: Revert.
10025         * amd64-tdep.c: Revert.
10026         * amd64-sol2-tdep.c: Revert.
10027         * amd64-obsd-tdep.c: Revert.
10028         * amd64-obsd-nat.c: Revert.
10029         * amd64-nbsd-tdep.c: Revert.
10030         * amd64-nbsd-nat.c: Revert.
10031         * amd64-nat.c: Revert.
10032         * amd64-linux-tdep.c: Revert.
10033         * amd64-linux-nat.c: Revert.
10034         * amd64-fbsd-tdep.c: Revert.
10035         * amd64-fbsd-nat.c: Revert.
10036         * amd64-dicos-tdep.c: Revert.
10037         * amd64-darwin-tdep.c: Revert.
10038         * amd64-bsd-nat.c: Revert.
10039         * alpha-tdep.c: Revert.
10040         * alpha-obsd-tdep.c: Revert.
10041         * alpha-nbsd-tdep.c: Revert.
10042         * alpha-mdebug-tdep.c: Revert.
10043         * alpha-linux-tdep.c: Revert.
10044         * alpha-linux-nat.c: Revert.
10045         * alpha-bsd-tdep.c: Revert.
10046         * alpha-bsd-nat.c: Revert.
10047         * aix-thread.c: Revert.
10048         * agent.c: Revert.
10049         * addrmap.c: Revert.
10050         * ada-varobj.c: Revert.
10051         * ada-valprint.c: Revert.
10052         * ada-typeprint.c: Revert.
10053         * ada-tasks.c: Revert.
10054         * ada-lang.c: Revert.
10055         * aarch64-tdep.c: Revert.
10056         * aarch64-ravenscar-thread.c: Revert.
10057         * aarch64-newlib-tdep.c: Revert.
10058         * aarch64-linux-tdep.c: Revert.
10059         * aarch64-linux-nat.c: Revert.
10060         * aarch64-fbsd-tdep.c: Revert.
10061         * aarch64-fbsd-nat.c: Revert.
10062         * aarch32-linux-nat.c: Revert.
10063
10064 2019-04-05  Tom Tromey  <tom@tromey.com>
10065
10066         * ft32-tdep.c: Sort headers.
10067         * frv-tdep.c: Sort headers.
10068         * frv-linux-tdep.c: Sort headers.
10069         * frame.c: Sort headers.
10070         * frame-unwind.c: Sort headers.
10071         * frame-base.c: Sort headers.
10072         * fork-child.c: Sort headers.
10073         * findvar.c: Sort headers.
10074         * findcmd.c: Sort headers.
10075         * filesystem.c: Sort headers.
10076         * filename-seen-cache.h: Sort headers.
10077         * filename-seen-cache.c: Sort headers.
10078         * fbsd-tdep.c: Sort headers.
10079         * fbsd-nat.h: Sort headers.
10080         * fbsd-nat.c: Sort headers.
10081         * f-valprint.c: Sort headers.
10082         * f-typeprint.c: Sort headers.
10083         * f-lang.c: Sort headers.
10084         * extension.h: Sort headers.
10085         * extension.c: Sort headers.
10086         * extension-priv.h: Sort headers.
10087         * expprint.c: Sort headers.
10088         * exec.h: Sort headers.
10089         * exec.c: Sort headers.
10090         * exceptions.c: Sort headers.
10091         * event-top.c: Sort headers.
10092         * event-loop.c: Sort headers.
10093         * eval.c: Sort headers.
10094         * elfread.c: Sort headers.
10095         * dwarf2read.h: Sort headers.
10096         * dwarf2read.c: Sort headers.
10097         * dwarf2loc.c: Sort headers.
10098         * dwarf2expr.h: Sort headers.
10099         * dwarf2expr.c: Sort headers.
10100         * dwarf2-frame.c: Sort headers.
10101         * dwarf2-frame-tailcall.c: Sort headers.
10102         * dwarf-index-write.h: Sort headers.
10103         * dwarf-index-write.c: Sort headers.
10104         * dwarf-index-common.c: Sort headers.
10105         * dwarf-index-cache.h: Sort headers.
10106         * dwarf-index-cache.c: Sort headers.
10107         * dummy-frame.c: Sort headers.
10108         * dtrace-probe.c: Sort headers.
10109         * disasm.h: Sort headers.
10110         * disasm.c: Sort headers.
10111         * disasm-selftests.c: Sort headers.
10112         * dictionary.c: Sort headers.
10113         * dicos-tdep.c: Sort headers.
10114         * demangle.c: Sort headers.
10115         * dcache.h: Sort headers.
10116         * dcache.c: Sort headers.
10117         * darwin-nat.h: Sort headers.
10118         * darwin-nat.c: Sort headers.
10119         * darwin-nat-info.c: Sort headers.
10120         * d-valprint.c: Sort headers.
10121         * d-namespace.c: Sort headers.
10122         * d-lang.c: Sort headers.
10123         * ctf.c: Sort headers.
10124         * csky-tdep.c: Sort headers.
10125         * csky-linux-tdep.c: Sort headers.
10126         * cris-tdep.c: Sort headers.
10127         * cris-linux-tdep.c: Sort headers.
10128         * cp-valprint.c: Sort headers.
10129         * cp-support.c: Sort headers.
10130         * cp-namespace.c: Sort headers.
10131         * cp-abi.c: Sort headers.
10132         * corelow.c: Sort headers.
10133         * corefile.c: Sort headers.
10134         * continuations.c: Sort headers.
10135         * completer.h: Sort headers.
10136         * completer.c: Sort headers.
10137         * complaints.c: Sort headers.
10138         * coffread.c: Sort headers.
10139         * coff-pe-read.c: Sort headers.
10140         * cli-out.h: Sort headers.
10141         * cli-out.c: Sort headers.
10142         * charset.c: Sort headers.
10143         * c-varobj.c: Sort headers.
10144         * c-valprint.c: Sort headers.
10145         * c-typeprint.c: Sort headers.
10146         * c-lang.c: Sort headers.
10147         * buildsym.c: Sort headers.
10148         * buildsym-legacy.c: Sort headers.
10149         * build-id.h: Sort headers.
10150         * build-id.c: Sort headers.
10151         * btrace.c: Sort headers.
10152         * bsd-uthread.c: Sort headers.
10153         * breakpoint.h: Sort headers.
10154         * breakpoint.c: Sort headers.
10155         * break-catch-throw.c: Sort headers.
10156         * break-catch-syscall.c: Sort headers.
10157         * break-catch-sig.c: Sort headers.
10158         * blockframe.c: Sort headers.
10159         * block.c: Sort headers.
10160         * bfin-tdep.c: Sort headers.
10161         * bfin-linux-tdep.c: Sort headers.
10162         * bfd-target.c: Sort headers.
10163         * bcache.c: Sort headers.
10164         * ax-general.c: Sort headers.
10165         * ax-gdb.h: Sort headers.
10166         * ax-gdb.c: Sort headers.
10167         * avr-tdep.c: Sort headers.
10168         * auxv.c: Sort headers.
10169         * auto-load.c: Sort headers.
10170         * arm-wince-tdep.c: Sort headers.
10171         * arm-tdep.c: Sort headers.
10172         * arm-symbian-tdep.c: Sort headers.
10173         * arm-pikeos-tdep.c: Sort headers.
10174         * arm-obsd-tdep.c: Sort headers.
10175         * arm-nbsd-tdep.c: Sort headers.
10176         * arm-nbsd-nat.c: Sort headers.
10177         * arm-linux-tdep.c: Sort headers.
10178         * arm-linux-nat.c: Sort headers.
10179         * arm-fbsd-tdep.c: Sort headers.
10180         * arm-fbsd-nat.c: Sort headers.
10181         * arm-bsd-tdep.c: Sort headers.
10182         * arch-utils.c: Sort headers.
10183         * arc-tdep.c: Sort headers.
10184         * arc-newlib-tdep.c: Sort headers.
10185         * annotate.h: Sort headers.
10186         * annotate.c: Sort headers.
10187         * amd64-windows-tdep.c: Sort headers.
10188         * amd64-windows-nat.c: Sort headers.
10189         * amd64-tdep.c: Sort headers.
10190         * amd64-sol2-tdep.c: Sort headers.
10191         * amd64-obsd-tdep.c: Sort headers.
10192         * amd64-obsd-nat.c: Sort headers.
10193         * amd64-nbsd-tdep.c: Sort headers.
10194         * amd64-nbsd-nat.c: Sort headers.
10195         * amd64-nat.c: Sort headers.
10196         * amd64-linux-tdep.c: Sort headers.
10197         * amd64-linux-nat.c: Sort headers.
10198         * amd64-fbsd-tdep.c: Sort headers.
10199         * amd64-fbsd-nat.c: Sort headers.
10200         * amd64-dicos-tdep.c: Sort headers.
10201         * amd64-darwin-tdep.c: Sort headers.
10202         * amd64-bsd-nat.c: Sort headers.
10203         * alpha-tdep.c: Sort headers.
10204         * alpha-obsd-tdep.c: Sort headers.
10205         * alpha-nbsd-tdep.c: Sort headers.
10206         * alpha-mdebug-tdep.c: Sort headers.
10207         * alpha-linux-tdep.c: Sort headers.
10208         * alpha-linux-nat.c: Sort headers.
10209         * alpha-bsd-tdep.c: Sort headers.
10210         * alpha-bsd-nat.c: Sort headers.
10211         * aix-thread.c: Sort headers.
10212         * agent.c: Sort headers.
10213         * addrmap.c: Sort headers.
10214         * ada-varobj.c: Sort headers.
10215         * ada-valprint.c: Sort headers.
10216         * ada-typeprint.c: Sort headers.
10217         * ada-tasks.c: Sort headers.
10218         * ada-lang.c: Sort headers.
10219         * aarch64-tdep.c: Sort headers.
10220         * aarch64-ravenscar-thread.c: Sort headers.
10221         * aarch64-newlib-tdep.c: Sort headers.
10222         * aarch64-linux-tdep.c: Sort headers.
10223         * aarch64-linux-nat.c: Sort headers.
10224         * aarch64-fbsd-tdep.c: Sort headers.
10225         * aarch64-fbsd-nat.c: Sort headers.
10226         * aarch32-linux-nat.c: Sort headers.
10227
10228 2019-04-04  Tom Tromey  <tom@tromey.com>
10229
10230         * varobj.c (varobj_create): Update.
10231         * rust-exp.y (struct rust_parser) <update_innermost_block,
10232         lookup_symbol>: New methods.
10233         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10234         Rename.
10235         (rust_parser::rust_lookup_type)
10236         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10237         * printcmd.c (display_command, do_one_display): Update.
10238         * parser-defs.h (struct parser_state) <parser_state>: Add
10239         "tracker" parameter.
10240         (block_tracker): New member.
10241         (class innermost_block_tracker) <innermost_block_tracker>: Add
10242         "types" parameter.
10243         <reset>: Remove method.
10244         (innermost_block): Don't declare.
10245         (null_post_parser): Update.
10246         * parse.c (innermost_block): Remove global.
10247         (write_dollar_variable): Update.
10248         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10249         Remove "tracker_types" parameter.
10250         (parse_expression): Add "tracker" parameter.
10251         (parse_expression_for_completion): Update.
10252         (null_post_parser): Add "tracker" parameter.
10253         * p-exp.y: Update rules.
10254         * m2-exp.y: Update rules.
10255         * language.h (struct language_defn) <la_post_parser>: Add
10256         "tracker" parameter.
10257         * go-exp.y: Update rules.
10258         * f-exp.y: Update rules.
10259         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10260         parameter.
10261         * d-exp.y: Update rules.
10262         * c-exp.y: Update rules.
10263         * breakpoint.c (set_breakpoint_condition): Create an
10264         innermost_block_tracker.
10265         (watch_command_1): Likewise.
10266         * ada-lang.c (resolve): Add "tracker" parameter.
10267         (resolve_subexp): Likewise.
10268         * ada-exp.y (write_var_from_sym): Update.
10269
10270 2019-04-04  Tom Tromey  <tom@tromey.com>
10271
10272         * type-stack.h: New file.
10273         * type-stack.c: New file.
10274         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10275         type-stack.h.
10276         (insert_into_type_stack, insert_type, push_type, push_type_int)
10277         (insert_type_address_space, pop_type, pop_type_int)
10278         (pop_typelist, pop_type_stack, append_type_stack)
10279         (push_type_stack, get_type_stack, push_typelist)
10280         (follow_type_instance_flags, follow_types): Don't declare.
10281         * parse.c (type_stack): Remove global.
10282         (parse_exp_in_context): Update.
10283         (insert_into_type_stack, insert_type, push_type, push_type_int)
10284         (insert_type_address_space, pop_type, pop_type_int)
10285         (pop_typelist, pop_type_stack, append_type_stack)
10286         (push_type_stack, get_type_stack, push_typelist)
10287         (follow_type_instance_flags, follow_types): Remove (moved to
10288         type-stack.c).
10289         * f-exp.y (type_stack): New global.
10290         Update rules.
10291         (push_kind_type, f_parse): Update.
10292         * d-exp.y (type_stack): New global.
10293         Update rules.
10294         (d_parse): Update.
10295         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10296         Update rules.
10297         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10298         (HFILES_NO_SRCDIR): Add type-stack.h.
10299
10300 2019-04-04  Tom Tromey  <tom@tromey.com>
10301
10302         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10303         (rust_parser::convert_ast_to_expression, rust_parse)
10304         (rust_lex_test_completion, rust_lex_tests): Update.
10305         * parser-defs.h (struct expr_completion_state): New.
10306         (struct parser_state) <parser_state>: Add completion parameter.
10307         <mark_struct_expression, mark_completion_tag>: New methods.
10308         <parse_completion, m_completion_state>: New members.
10309         (prefixify_expression, null_post_parser): Update.
10310         (mark_struct_expression, mark_completion_tag): Don't declare.
10311         * parse.c (parse_completion, expout_last_struct)
10312         (expout_tag_completion_type, expout_completion_name): Remove
10313         globals.
10314         (parser_state::mark_struct_expression)
10315         (parser_state::mark_completion_tag): Now methods.
10316         (prefixify_expression): Add last_struct parameter.
10317         (prefixify_subexp): Likewise.
10318         (parse_exp_1): Update.
10319         (parse_exp_in_context): Add cstate parameter.  Update.
10320         (parse_expression_for_completion): Create an
10321         expr_completion_state.
10322         (null_post_parser): Add "completion" parameter.
10323         * p-exp.y: Update rules.
10324         (yylex): Update.
10325         * language.h (struct language_defn) <la_post_parser>: Add
10326         "completing" parameter.
10327         * go-exp.y: Update rules.
10328         (lex_one_token): Update.
10329         * expression.h (parse_completion): Don't declare.
10330         * d-exp.y: Update rules.
10331         (lex_one_token): Update rules.
10332         * c-exp.y: Update rules.
10333         (lex_one_token): Update.
10334         * ada-lang.c (resolve): Add "parse_completion" parameter.
10335         (resolve_subexp): Likewise.
10336         (ada_resolve_function): Likewise.
10337
10338 2019-04-04  Tom Tromey  <tom@tromey.com>
10339
10340         * parser-defs.h (struct parser_state) <start_arglist,
10341         end_arglist>: New methods.
10342         <arglist_len, m_funcall_chain>: New members.
10343         (arglist_len, start_arglist, end_arglist): Don't declare.
10344         * parse.c (arglist_len, funcall_chain): Remove global.
10345         (start_arglist, end_arglist): Remove functions.
10346         (parse_exp_in_context): Update.
10347         * p-exp.y: Update rules.
10348         * m2-exp.y: Update rules.
10349         * go-exp.y: Update rules.
10350         * f-exp.y: Update rules.
10351         * d-exp.y: Update rules.
10352         * c-exp.y: Update rules.
10353
10354 2019-04-04  Tom Tromey  <tom@tromey.com>
10355
10356         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10357         lex_operator, push_back>: New methods.
10358         Update all rules.
10359         (rust_parser::lex_hex, lex_escape): Rename and update.
10360         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10361         (rust_parser::lex_operator): Rename and update.
10362         (rust_parser::lex_number, rustyylex, rustyyerror)
10363         (rust_lex_test_init, rust_lex_test_sequence)
10364         (rust_lex_test_push_back, rust_lex_tests): Update.
10365         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10366         parameter.
10367         <lexptr, prev_lexptr>: New members.
10368         (lexptr, prev_lexptr): Don't declare.
10369         * parse.c (lexptr, prev_lexptr): Remove globals.
10370         (parse_exp_in_context): Update.
10371         * p-exp.y (yylex, yyerror): Update.
10372         * m2-exp.y (parse_number, yylex, yyerror): Update.
10373         * go-exp.y (lex_one_token, yyerror): Update.
10374         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10375         * d-exp.y (lex_one_token, yyerror): Update.
10376         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10377         (lex_one_token, yyerror): Update.
10378         * ada-lex.l (YY_INPUT): Update.
10379         (rewind_to_char): Update.
10380         * ada-exp.y (yyerror): Update.
10381
10382 2019-04-04  Tom Tromey  <tom@tromey.com>
10383
10384         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10385         * parser-defs.h (struct parser_state) <parser_state>: Add new
10386         parameter.
10387         <comma_terminates>: New member.
10388         (comma_terminates): Don't declare global.
10389         * parse.c (comma_terminates): Remove global.
10390         (parse_exp_in_context): Update.
10391         * p-exp.y (yylex): Update.
10392         * m2-exp.y (yylex): Update.
10393         * go-exp.y (lex_one_token): Update.
10394         * f-exp.y (yylex): Update.
10395         * d-exp.y (lex_one_token): Update.
10396         * c-exp.y (lex_one_token): Update.
10397         * ada-lex.l: Update.
10398
10399 2019-04-04  Tom Tromey  <tom@tromey.com>
10400
10401         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10402         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10403         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10404         * parser-defs.h (paren_depth): Don't declare.
10405         * parse.c (paren_depth): Remove global.
10406         (parse_exp_in_context): Update.
10407         * p-exp.y (paren_depth): New global.
10408         (pascal_parse): Initialize it.
10409         * m2-exp.y (paren_depth): New global.
10410         (m2_parse): Initialize it.
10411         * go-exp.y (paren_depth): New global.
10412         (go_parse): Initialize it.
10413         * f-exp.y (paren_depth): New global.
10414         (f_parse): Initialize it.
10415         * d-exp.y (paren_depth): New global.
10416         (d_parse): Initialize it.
10417         * c-exp.y (paren_depth): New global.
10418         (c_parse): Initialize it.
10419         * ada-lex.l (paren_depth): New global.
10420         (lexer_init): Initialize it.
10421
10422 2019-04-04  Tom Tromey  <tom@tromey.com>
10423
10424         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10425         (rust_parser::convert_ast_to_type)
10426         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10427         * parser-defs.h (struct parser_state) <parser_state>: Add
10428         parameters.  Initialize new members.
10429         <expression_context_block, expression_context_pc>: New members.
10430         * parse.c (expression_context_block, expression_context_pc):
10431         Remove globals.
10432         (parse_exp_in_context): Update.
10433         * p-exp.y: Update all rules.
10434         (yylex): Update.
10435         * m2-exp.y: Update all rules.
10436         (yylex): Update.
10437         * go-exp.y (yylex): Update.
10438         * f-exp.y (yylex): Update.
10439         * d-exp.y: Update all rules.
10440         (yylex): Update.
10441         * c-exp.y: Update all rules.
10442         (lex_one_token, classify_name, yylex, c_parse): Update.
10443         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10444
10445 2019-04-04  Tom Tromey  <tom@tromey.com>
10446
10447         * gdbarch.h, gdbarch.c: Rebuild.
10448         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10449         * stap-probe.h:
10450         (struct stap_parse_info): Replace "parser_state" with
10451         "expr_builder".
10452         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10453         (parser_state): New class.
10454         * parse.c (expr_builder): Rename.
10455         (expr_builder::release): Rename.
10456         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10457         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10458         (write_exp_elt_longcst, write_exp_elt_floatcst)
10459         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10460         (write_exp_string_vector, write_exp_bitstring)
10461         (write_exp_msymbol, mark_struct_expression)
10462         (write_dollar_variable)
10463         (insert_type_address_space, increase_expout_size): Replace
10464         "parser_state" with "expr_builder".
10465         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10466         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10467         "parser_state" with "expr_builder".
10468
10469 2019-04-04  Tom Tromey  <tom@tromey.com>
10470
10471         * rust-exp.y: Replace "parse_language" with method call.
10472         * p-exp.y:
10473         (yylex): Replace "parse_language" with method call.
10474         * m2-exp.y:
10475         (yylex): Replace "parse_language" with method call.
10476         * go-exp.y (classify_name): Replace "parse_language" with method
10477         call.
10478         * f-exp.y (yylex): Replace "parse_language" with method call.
10479         * d-exp.y (lex_one_token): Replace "parse_language" with method
10480         call.
10481         * c-exp.y:
10482         (lex_one_token, classify_name, yylex): Replace "parse_language"
10483         with method call.
10484         * ada-exp.y (find_primitive_type, type_char)
10485         (type_system_address): Replace "parse_language" with method call.
10486
10487 2019-04-04  Tom Tromey  <tom@tromey.com>
10488
10489         * rust-exp.y: Replace "parse_gdbarch" with method call.
10490         * parse.c (write_dollar_variable, insert_type_address_space):
10491         Replace "parse_gdbarch" with method call.
10492         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10493         call.
10494         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10495         call.
10496         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10497         "parse_gdbarch" with method call.
10498         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10499         with method call.
10500         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10501         "parse_gdbarch" with method call.
10502         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10503         "parse_gdbarch" with method call.
10504         * c-exp.y (parse_type, parse_number, classify_name): Replace
10505         "parse_gdbarch" with method call.
10506         * ada-lex.l: Replace "parse_gdbarch" with method call.
10507         * ada-exp.y (parse_type, find_primitive_type, type_char)
10508         (type_system_address): Replace "parse_gdbarch" with method call.
10509
10510 2019-04-04  Tom Tromey  <tom@tromey.com>
10511
10512         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10513         * stap-probe.c (stap_parse_argument): Update.
10514         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10515         initial_size parameter.
10516         * rust-exp.y (rust_lex_tests): Update.
10517         * parse.c (parser_state): Update.
10518         (parse_exp_in_context): Update.
10519         * parser-defs.h (struct parser_state) <parser_state>: Remove
10520         "initial_size" parameter.
10521
10522 2019-04-04  Tom Tromey  <tom@tromey.com>
10523
10524         * parser-defs.h (increase_expout_size): Don't declare.
10525         * parse.c (increase_expout_size): Now static.
10526
10527 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10528
10529         * gnu-nat.c (gnu_nat_target::wait): Fix
10530         target_waitstatus_to_string call.
10531
10532 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10533
10534         * eval.c (evaluate_subexp_standard): Handle internal functions
10535         during Fortran function call handling.
10536
10537 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10538
10539         * NEWS: Mention new internal functions.
10540         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10541         (read_base_type): Use dwarf2_init_complex_target_type.
10542         * value.c (creal_internal_fn): New function.
10543         (cimag_internal_fn): New function.
10544         (_initialize_values): Register new internal functions.
10545
10546 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10547
10548         * infrun.c (stop_all_threads): If debug_infrun, always
10549         trace the wait status after wait_one, using
10550         target_waitstatus_to_string and target_pid_to_str.
10551         (handle_inferior_event): Replace various trace of
10552         wait status kind by a single trace.
10553         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10554         wait status kind image by target_waitstatus_to_string.
10555         * target/waitstatus.c (target_waitstatus_to_string): Fix
10556         obsolete comment.
10557
10558 2019-04-01  Tom Tromey  <tromey@adacore.com>
10559
10560         PR symtab/23331:
10561         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10562
10563 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10564             Pedro Alves  <palves@redhat.com>
10565
10566         * top.c (quit_force): Call 'finalize_values'.
10567         * value.c (finalize_values): New function.
10568         * value.h (finalize_values): Declare.
10569
10570 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10571
10572         * NEWS: Announce $_gdb_major and $_gdb_minor.
10573
10574         * top.c (init_gdb_version_vars): New function.
10575         (gdb_init): Call init_gdb_version_vars.
10576
10577 2019-03-29  Tom Tromey  <tromey@adacore.com>
10578
10579         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10580         help text.  Remove dead code.
10581
10582 2019-03-29  Keith Seitz  <keiths@redhat.com>
10583
10584         From Siddhesh Poyarekar:
10585         * f-lang.h (f77_get_upperbound): Return LONGEST.
10586         (f77_get_lowerbound): Likewise.
10587         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10588         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10589         print them.
10590         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10591         plongest to format print it.
10592         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10593         (f77_get_upperbound): Likewise.
10594         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10595         LOWER_BOUND to LONGEST.
10596         (f77_create_arrayprint_offset_tbl): Likewise.
10597
10598 2019-03-29  Keith Seitz  <keiths@redhat.com>
10599
10600         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10601         %s/pulongest for TYPE_LENGTH instead of %d in format
10602         strings.
10603         * ada-typerint.c (ada_print_type): Likewise.
10604         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10605         * compile/compile-c-support.c (generate_register_struct): Likewise.
10606         * gdbtypes.c (recursive_dump_type): Likewise.
10607         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10608         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10609         instead of %d in format strings.
10610         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10611         to std::min to ULONGEST.
10612         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10613         instead of %d in format strings.
10614         * tracepoint.c (info_scope_command): Likewise.
10615         * typeprint.c (print_offset_data::update)
10616         (print_offset_data::finish): Likewise.
10617         * xtensa-tdep.c (xtensa_store_return_value)
10618         (xtensa_push_dummy_call): Likewise.
10619
10620 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10621
10622         * windows-nat.c (display_selector): Fixed format specifications
10623         for 64-bit Cygwin.
10624
10625 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10626
10627         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10628
10629 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10630
10631         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10632         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10633         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10634         (nios2_linux_init_abi): Install it.
10635
10636 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10637
10638         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10639
10640 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10641
10642         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10643
10644 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10645             Tom Tromey  <tromey@adacore.com>
10646
10647         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10648
10649 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10650
10651         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10652         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10653         method to compute the bounds of range types. Also print "[evaluated]"
10654         if the bounds' values come from a dynamic evaluation.
10655
10656 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10657
10658         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10659         whitespace when pretty printing is on.
10660
10661 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10662
10663         * ppc-linux-nat.c: Add include.
10664
10665 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10666
10667         * NEWS: Mention AArch64 Pointer Authentication.
10668
10669 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10670
10671         * arm-linux-nat.c: Add include.
10672
10673 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10674
10675         * source-cache.c (source_cache::get_source_lines): Re-read
10676         fullname after calling open_source_file.
10677
10678 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10679
10680         * NEWS: Mention TLS support for FreeBSD.
10681
10682 2019-03-25  Tom Tromey  <tromey@adacore.com>
10683
10684         * minsyms.c (BUNCH_SIZE): Update comment.
10685         (~minimal_symbol_reader): Remove old comment.
10686         (compact_minimal_symbols): Update comment.
10687         (minimal_symbol_reader::install): Remove old comment.  Update
10688         other comments.
10689
10690 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10691
10692         * s390-linux-nat.c: Add include.
10693
10694 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10695
10696         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10697         Call linux_get_hwcap.
10698         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10699         Likewise.
10700         (aarch64_linux_get_hwcap): Remove function.
10701         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10702         declaration.
10703         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10704         linux_get_hwcap.
10705         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10706         * linux-tdep.c (linux_get_hwcap): Add function.
10707         (linux_get_hwcap2): Likewise.
10708         * linux-tdep.h (linux_get_hwcap): Add declaration.
10709         (linux_get_hwcap2): Likewise.
10710         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10711         (ppc_linux_get_hwcap2): Likewise.
10712         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10713         linux_get_hwcap.
10714         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10715         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10716         (ppc_linux_nat_target::read_description): Likewise.
10717         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10718         * s390-linux-nat.c: Likewise.
10719         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10720
10721 2019-03-24  Tom Tromey  <tom@tromey.com>
10722
10723         * ada-lang.c (standard_lookup): Simplify initialization.
10724         (ada_lookup_symbol_nonlocal): Simplify return.
10725         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10726         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10727         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10728         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10729         initialization.
10730         * solib.c (solib_global_lookup): Simplify.
10731         * symtab.c (null_block_symbol): Remove.
10732         (symbol_cache_lookup): Simplify returns.
10733         (lookup_language_this): Simplify returns.
10734         (lookup_symbol_aux): Simplify return.
10735         (lookup_local_symbol): Simplify returns.
10736         (lookup_global_symbol_from_objfile): Simplify return.
10737         (lookup_symbol_in_objfile_symtabs)
10738         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10739         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10740         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10741         * cp-namespace.c (cp_lookup_bare_symbol)
10742         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10743         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10744         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10745         (cp_lookup_symbol_via_imports): Simplify initialization.
10746         (find_symbol_in_baseclass): Likewise.
10747         * symtab.h (null_block_symbol): Remove.
10748         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10749         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10750         (d_lookup_symbol_module): Likewise.
10751         (find_symbol_in_baseclass): Simplify initialization.
10752
10753 2019-03-24  Tom Tromey  <tom@tromey.com>
10754
10755         * expression.h: Don't include symtab.h.
10756         (struct block): Forward declare.
10757
10758 2019-03-24  Tom Tromey  <tom@tromey.com>
10759
10760         * c-exp.y (typebase): Remove casts.
10761         * gdbtypes.c (lookup_unsigned_typename, )
10762         (lookup_signed_typename): Remove cast.
10763         * eval.c (parse_to_comma_and_eval): Remove cast.
10764         * parse.c (write_dollar_variable): Remove cast.
10765         * block.h (struct block) <superblock>: Now const.
10766         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10767         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10768         (map_block): Make "block" const.
10769         * symfile.h (struct quick_symbol_functions)
10770         <map_matching_symbols>: Constify block argument to "callback".
10771         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10772         const.
10773         (find_pc_sect_compunit_symtab): Make "b" const.
10774         (find_symbol_at_address): Likewise.
10775         (search_symbols): Likewise.
10776         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10777         (dw2_debug_names_lookup_symbol): Likewise.
10778         (dw2_map_matching_symbols): Update.
10779         * p-valprint.c (pascal_val_print): Remove "block".
10780         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10781         (aux_add_nonlocal_symbols): Make "block" const.
10782         (resolve_subexp): Remove cast.
10783         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10784         const.
10785         (iterate_over_file_blocks): Likewise.
10786         * f-exp.y (%union) <bval>: Remove.
10787         * coffread.c (patch_opaque_types): Make "b" const.
10788         * spu-tdep.c (spu_catch_start): Make "block" const.
10789         * c-valprint.c (print_unpacked_pointer): Remove "block".
10790         * symmisc.c (dump_symtab_1): Make "b" const.
10791         (block_depth): Make "block" const.
10792         * d-exp.y (%union) <bval>: Remove.
10793         * cp-support.h (cp_lookup_rtti_type): Update.
10794         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10795         * psymtab.c (psym_lookup_symbol): Make "block" const.
10796         (maintenance_check_psymtabs): Make "b" const.
10797         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10798         (enumerate_locals, enumerate_args): Update.
10799         * python/py-symtab.c (stpy_global_block): Make "block" const.
10800         (stpy_static_block): Likewise.
10801         * inline-frame.c (block_starting_point_at): Make "new_block"
10802         const.
10803         * block.c (find_block_in_blockvector): Make return type const.
10804         (blockvector_for_pc_sect): Make "b" const.
10805         (find_block_in_blockvector): Make "b" const.
10806
10807 2019-03-23  Tom Tromey  <tom@tromey.com>
10808
10809         * varobj.c (varobj_create): Update.
10810         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10811         * printcmd.c (display_command, do_one_display): Don't reset
10812         innermost_block.
10813         * parser-defs.h (enum innermost_block_tracker_type): Move to
10814         expression.h.
10815         (innermost_block): Update comment.
10816         * parse.c (parse_exp_1): Add tracker_types parameter.
10817         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10818         tracker_types parameter.  Reset innermost_block.
10819         (parse_exp_in_context): Remove.
10820         (parse_expression_for_completion): Update.
10821         * objfiles.c (~objfile): Don't reset expression_context_block or
10822         innermost_block.
10823         * expression.h (enum innermost_block_tracker_type): Move from
10824         parser-defs.h.
10825         (parse_exp_1): Add tracker_types parameter.
10826         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10827         reset innermost_block.
10828
10829 2019-03-23  Tom Tromey  <tom@tromey.com>
10830
10831         * objfiles.h: Include bcache.h.
10832
10833 2019-03-23  Tom Tromey  <tom@tromey.com>
10834
10835         * linespec.c (get_current_search_block): Use
10836         scoped_restore_current_language.
10837         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10838
10839 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10840             Jiong Wang  <jiong.wang@arm.com>
10841
10842         * aarch64-linux-tdep.c
10843         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10844         section.
10845         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10846
10847 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10848             Jiong Wang  <jiong.wang@arm.com>
10849
10850         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10851         instructions.
10852         (aarch64_analyze_prologue_test): Add PACIASP test.
10853         (aarch64_prologue_prev_register): Unmask PC value.
10854
10855 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10856             Jiong Wang  <jiong.wang@arm.com>
10857
10858         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10859         (aarch64_dwarf2_prev_register): Unmask PC value.
10860         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10861         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10862         DW_CFA_AARCH64_negate_ra_state.
10863         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10864
10865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10866             Jiong Wang  <jiong.wang@arm.com>
10867
10868         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10869         registers.
10870         (aarch64_pseudo_register_name): Likewise.
10871         (aarch64_pseudo_register_type): Likewise.
10872         (aarch64_pseudo_register_reggroup_p): Likewise.
10873         (aarch64_gdbarch_init): Add pauth registers.
10874         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10875         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10876         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10877         (struct gdbarch_tdep): Add regnum for ra_state.
10878
10879 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10880             Jiong Wang  <jiong.wang@arm.com>
10881
10882         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10883
10884 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10885             Jiong Wang  <jiong.wang@arm.com>
10886
10887         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10888         function.
10889         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10890         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10891         (aarch64_gdbarch_init): Add puth registers.
10892         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10893         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10894         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10895
10896 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10897             Jiong Wang  <jiong.wang@arm.com>
10898
10899         * aarch64-linux-nat.c
10900         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10901         * aarch64-linux-tdep.c
10902         (aarch64_linux_core_read_description): Likewise.
10903         (aarch64_linux_get_hwcap): New function.
10904         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10905         (aarch64_linux_get_hwcap): New declaration.
10906
10907 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10908             Jiong Wang  <jiong.wang@arm.com>
10909
10910         * aarch64-linux-nat.c
10911         (aarch64_linux_nat_target::read_description): Add pauth param.
10912         * aarch64-linux-tdep.c
10913         (aarch64_linux_core_read_description): Likewise.
10914         * aarch64-tdep.c (struct target_desc): Add in pauth.
10915         (aarch64_read_description): Add pauth param.
10916         (aarch64_gdbarch_init): Likewise.
10917         * aarch64-tdep.h (aarch64_read_description): Likewise.
10918         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10919         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10920         * features/Makefile: Add new files.
10921         * features/aarch64-pauth.c: New file.
10922         * features/aarch64-pauth.xml: New file.
10923
10924 2019-03-20  Tom Tromey  <tromey@adacore.com>
10925
10926         * infrun.c (handle_inferior_event): Rename from
10927         handle_inferior_event_1.  Create a scoped_value_mark.
10928         (handle_inferior_event): Remove.
10929
10930 2019-03-19  Tom Tromey  <tromey@adacore.com>
10931
10932         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10933         * infrun.h (print_stop_event): Add "displays" parameter.
10934         * infrun.c (print_stop_event): Add "displays" parameter.
10935
10936 2019-03-19  Pedro Alves  <palves@redhat.com>
10937
10938         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10939         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10940         to -1.  Fix TABs vs spaces.
10941         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10942         * tui/tui-out.h (tui_ui_out) Add intro comments.
10943         <m_line, m_start_of_line>: In-class initialize, and add describing
10944         comment.
10945
10946 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10947
10948         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10949         variable names.
10950         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10951
10952 2019-03-18  Pedro Alves  <palves@redhat.com>
10953             Eli Zaretskii <eliz@gnu.org>
10954
10955         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10956         m_line and m_start_of_line.
10957
10958 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10959
10960         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10961         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10962         it returns a newline.  This fixes a regression in TU mode, whereby
10963         the next line is output on the same screen line as the user input.
10964
10965 2019-03-18  Tom Tromey  <tromey@adacore.com>
10966
10967         * minsyms.c (minimal_symbol_reader::install): Remove call to
10968         obstack_blank.
10969
10970 2019-03-18  Pedro Alves  <palves@redhat.com>
10971
10972         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10973         New globals.
10974         (apply_style): New, factored out from ...
10975         (apply_ansi_escape): ... this.  Handle reverse video mode.
10976         (tui_set_reverse_mode): New function.
10977         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10978         * tui/tui-winsource.c (tui_show_source_line): Use
10979         tui_set_reverse_mode instead of setting A_STANDOUT.
10980         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10981         New setter methods.
10982
10983 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10984
10985         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10986         Handle tabs.
10987
10988 2019-03-18  Tom Tromey  <tromey@adacore.com>
10989
10990         * ada-lang.c (empty_array): Add "high" parameter.
10991         (ada_evaluate_subexp): Update.
10992
10993 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10994
10995         * unittests/string_view-selftests.c: Define
10996         _initialize_string_view_selftests unconditionally.
10997
10998 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10999
11000         PR gdb/24350
11001         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11002
11003 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11004
11005         PR gdb/24351
11006         * windows-nat.c (display_selector): Fix format specifiers.
11007
11008 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11009
11010         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11011         tui_refill_source_window instead of tui_refresh_win, to update the
11012         current execution line.  This fixes redisplay of the current line
11013         when stepping through the code with "next" or "step".
11014
11015 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11016
11017         * source-cache.c (source_cache::get_source_lines): Call
11018         find_source_lines to initialize s->nlines.  This fixes vertical
11019         scrolling of TUI source window when the DOWN arrow is pressed.
11020
11021 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11022
11023         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11024         linux-thread-db.c (_initialize_thread_db): Likewise.
11025
11026 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11027
11028         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11029         wclrtoeol in tui_show_source_line".  This reverts changes made in
11030         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11031
11032 2019-03-15  Tom Tromey  <tom@tromey.com>
11033
11034         * symtab.h (struct minimal_symbol): Derive from
11035         general_symbol_info.
11036         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11037         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11038         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11039         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11040         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11041         (MSYMBOL_SEARCH_NAME): Update.
11042         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11043         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11044         * minsyms.c (minimal_symbol_reader::record_full): Update.
11045
11046 2019-03-15  Tom Tromey  <tom@tromey.com>
11047
11048         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11049
11050 2019-03-15  Tom Tromey  <tom@tromey.com>
11051
11052         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11053         unique_xmalloc_ptr.
11054         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11055         Update.
11056         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11057         (build_minimal_symbol_hash_tables)
11058         (minimal_symbol_reader::install): Update.
11059
11060 2019-03-15  Tom Tromey  <tom@tromey.com>
11061
11062         * symtab.c (create_demangled_names_hash): Update.
11063         (symbol_set_names): Update.
11064         * objfiles.h (struct objfile_per_bfd_storage)
11065         <demangled_names_hash>: Now an htab_up.
11066         * objfiles.c (objfile_per_bfd_storage): Simplify.
11067
11068 2019-03-15  Tom Tromey  <tom@tromey.com>
11069
11070         * objfiles.h (struct objfile_per_bfd_storage): Declare
11071         destructor.
11072         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11073         New.
11074         (get_objfile_bfd_data): Use new.  Don't initialize
11075         language_of_main.
11076         (free_objfile_per_bfd_storage): Remove.
11077         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11078
11079 2019-03-15  Tom Tromey  <tom@tromey.com>
11080
11081         * symfile.c (reread_symbols): Update.
11082         * objfiles.c (objfile::objfile): Update.
11083         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11084         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11085         comment.
11086         (minimal_symbol_reader::install): Update.
11087         (terminate_minimal_symbol_table): Remove.
11088         * jit.c (jit_object_close_impl): Update.
11089
11090 2019-03-15  Tom Tromey  <tom@tromey.com>
11091
11092         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11093         initializations.
11094
11095 2019-03-15  Tom Tromey  <tom@tromey.com>
11096
11097         * objfiles.h (struct objfile_per_bfd_storage)
11098         <demangled_hash_languages>: Now a bitset.
11099         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11100         (lookup_minimal_symbol): Update.
11101
11102 2019-03-15  Tom Tromey  <tom@tromey.com>
11103
11104         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11105         Don't return the symbol.
11106         * coffread.c (record_minimal_symbol): Use record_full.
11107
11108 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11109
11110         The MS-Windows port of ncurses fails to switch to a color pair if
11111         one or both of the colors are the implicit default colors.  This
11112         change records the default colors when TUI is initialized, and
11113         then specifies them explicitly when a color pair uses the default
11114         colors.  This allows color styling in TUI mode on MS-Windows.
11115
11116         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11117         ncurses_norm_attr.
11118         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11119         colors in ncurses_norm_attr.
11120         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11121         "none", replace it with the default color recorded in
11122         ncurses_norm_attr.
11123
11124 2019-03-14  Tom Tromey  <tromey@adacore.com>
11125
11126         * source-cache.h (class source_cache) <get_source_lines>: Return
11127         std::string.
11128         * source-cache.c (source_cache::extract_lines): Handle case where
11129         first_pos==npos.  Return std::string.
11130         (source_cache::get_source_lines): Update.
11131
11132 2019-03-14  Tom Tromey  <tromey@adacore.com>
11133
11134         * NEWS: Add item for "style sources" commands.
11135         * source-cache.c (source_cache::get_source_lines): Check
11136         source_styling.
11137         * cli/cli-style.c (source_styling): New global.
11138         (_initialize_cli_style): Add "style sources" commands.
11139         (show_style_sources): New function.
11140         * cli/cli-style.h (source_styling): Declare.
11141
11142 2019-03-14  Pedro Alves  <palves@redhat.com>
11143             Tom Tromey  <tromey@adacore.com>
11144
11145         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11146         * tui/tui-winsource.c (tui_refill_source_window): New function,
11147         from...
11148         (tui_horizontal_source_scroll): ... here.  Move some logic.
11149         * cli/cli-style.c (set_style_enabled): Notify new observable.
11150         * tui/tui-hooks.c (tui_redisplay_source): New function.
11151         (tui_attach_detach_observers): Attach or detach
11152         tui_redisplay_source.
11153         * observable.h (source_styling_changed): New observable.
11154         * observable.c: Define source_styling_changed observable.
11155
11156 2019-03-13  Tom Tromey  <tromey@adacore.com>
11157
11158         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11159         (i386_gnu_nat_target::store_registers): Update.
11160         * target-debug.h (target_debug_print_std_string): New macro.
11161         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11162         * windows-tdep.c (display_one_tib): Update.
11163         * tui/tui-stack.c (tui_make_status_line): Update.
11164         * top.c (print_inferior_quit_action): Update.
11165         * thread.c (thr_try_catch_cmd): Update.
11166         (add_thread_with_info): Update.
11167         (thread_target_id_str): Update.
11168         (thr_try_catch_cmd): Update.
11169         (thread_command): Update.
11170         (thread_find_command): Update.
11171         * record-btrace.c (record_btrace_target::info_record)
11172         (record_btrace_resume_thread, record_btrace_target::resume)
11173         (record_btrace_cancel_resume, record_btrace_step_thread)
11174         (record_btrace_target::wait, record_btrace_target::wait)
11175         (record_btrace_target::wait, record_btrace_target::stop): Update.
11176         * progspace.c (print_program_space): Update.
11177         * process-stratum-target.c
11178         (process_stratum_target::thread_address_space): Update.
11179         * linux-fork.c (linux_fork_mourn_inferior)
11180         (detach_checkpoint_command, info_checkpoints_command)
11181         (linux_fork_context): Update.
11182         (linux_fork_detach): Update.
11183         (class scoped_switch_fork_info): Update.
11184         (delete_checkpoint_command): Update.
11185         * infrun.c (follow_fork_inferior): Update.
11186         (follow_fork_inferior): Update.
11187         (proceed_after_vfork_done): Update.
11188         (handle_vfork_child_exec_or_exit): Update.
11189         (follow_exec): Update.
11190         (displaced_step_prepare_throw): Update.
11191         (displaced_step_restore): Update.
11192         (start_step_over): Update.
11193         (resume_1): Update.
11194         (clear_proceed_status_thread): Update.
11195         (proceed): Update.
11196         (print_target_wait_results): Update.
11197         (do_target_wait): Update.
11198         (context_switch): Update.
11199         (stop_all_threads): Update.
11200         (restart_threads): Update.
11201         (finish_step_over): Update.
11202         (handle_signal_stop): Update.
11203         (switch_back_to_stepped_thread): Update.
11204         (keep_going_pass_signal): Update.
11205         (print_exited_reason): Update.
11206         (normal_stop): Update.
11207         * inferior.c (inferior_pid_to_str): Change return type.
11208         (print_selected_inferior): Update.
11209         (add_inferior): Update.
11210         (detach_inferior): Update.
11211         * dummy-frame.c (fprint_dummy_frames): Update.
11212         * dcache.c (dcache_info_1): Update.
11213         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11214         (btrace_fetch, btrace_clear): Update.
11215         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11216         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11217         type.
11218         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11219         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11220         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11221         * gdbarch.c, gdbarch.h: Rebuild.
11222         * gdbarch.sh (core_pid_to_str): Change return type.
11223         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11224         return type.
11225         (windows_nat_target::pid_to_str): Change return type.
11226         (windows_delete_thread): Update.
11227         (windows_nat_target::attach): Update.
11228         (windows_nat_target::files_info): Update.
11229         * target-delegates.c: Rebuild.
11230         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11231         return type.
11232         (sol_thread_target::pid_to_str): Change return type.
11233         * remote.c (class remote_target) <pid_to_str>: Change return
11234         type.
11235         (remote_target::pid_to_str): Change return type.
11236         (extended_remote_target::attach, remote_target::remote_stop_ns)
11237         (remote_target::remote_notif_remove_queued_reply)
11238         (remote_target::push_stop_reply, remote_target::disable_btrace):
11239         Update.
11240         (extended_remote_target::attach): Update.
11241         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11242         type.
11243         (gdbsim_target::pid_to_str): Change return type.
11244         * ravenscar-thread.c (struct ravenscar_thread_target)
11245         <pid_to_str>: Change return type.
11246         (ravenscar_thread_target::pid_to_str): Change return type.
11247         * procfs.c (class procfs_target) <pid_to_str>: Change return
11248         type.
11249         (procfs_target::pid_to_str): Change return type.
11250         (procfs_target::attach): Update.
11251         (procfs_target::detach): Update.
11252         (procfs_target::fetch_registers): Update.
11253         (procfs_target::store_registers): Update.
11254         (procfs_target::wait): Update.
11255         (procfs_target::files_info): Update.
11256         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11257         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11258         return type.
11259         (nto_procfs_target::pid_to_str): Change return type.
11260         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11261         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11262         return type.
11263         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11264         (exit_lwp): Update.
11265         (attach_proc_task_lwp_callback, get_detach_signal)
11266         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11267         (linux_nat_target::resume, wait_lwp, stop_callback)
11268         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11269         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11270         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11271         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11272         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11273         type.
11274         (inf_ptrace_target::attach): Update.
11275         (inf_ptrace_target::files_info): Update.
11276         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11277         type.
11278         (go32_nat_target::pid_to_str): Change return type.
11279         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11280         (gnu_nat_target::wait): Update.
11281         (gnu_nat_target::wait): Update.
11282         (gnu_nat_target::resume): Update.
11283         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11284         (fbsd_nat_target::wait): Update.
11285         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11286         type.
11287         (darwin_nat_target::attach): Update.
11288         * corelow.c (class core_target) <pid_to_str>: Change return type.
11289         (core_target::pid_to_str): Change return type.
11290         * target.c (normal_pid_to_str): Change return type.
11291         (default_pid_to_str): Likewise.
11292         (target_pid_to_str): Change return type.
11293         (target_translate_tls_address): Update.
11294         (target_announce_detach): Update.
11295         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11296         return type.
11297         (bsd_uthread_target::pid_to_str): Change return type.
11298         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11299         type.
11300         (bsd_kvm_target::pid_to_str): Change return type.
11301         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11302         return type.
11303         (aix_thread_target::pid_to_str): Change return type.
11304         * target.h (struct target_ops) <pid_to_str>: Change return type.
11305         (target_pid_to_str, normal_pid_to_str): Likewise.
11306         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11307         type.
11308         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11309         type.
11310         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11311         return type.
11312         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11313         type.
11314         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11315         type.
11316         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11317         return type.
11318
11319 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11320
11321         * NEWS: Mention that the new default MI version is 3.  Mention
11322         changes to the output of commands and events that deal with
11323         multi-location breakpoints.
11324         * breakpoint.c: Include "mi/mi-out.h".
11325         (print_one_breakpoint): Change output syntax if using MI version
11326         >= 3.
11327         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11328         New.
11329         (mi_multi_location_breakpoint_output_fixed): New.
11330         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11331         (mi_cmd_fix_multi_location_breakpoint_output): New.
11332         (mi_multi_location_breakpoint_output_fixed): New.
11333         * mi/mi-cmds.c (mi_cmds): Register command
11334         -fix-multi-location-breakpoint-output.
11335         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11336         interpreter "mi".
11337
11338 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11339
11340         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11341         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11342         instantiate mi_ui_out based on interpreter name.
11343         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11344         * mi/mi-main.c (mi_load_progress): Likewise.
11345
11346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11347
11348         * NEWS: Combine separate "New targets" sections for 8.3.
11349
11350 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11351
11352         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11353         (ppcfbsd_init_abi): Install gdbarch
11354         "fetch_tls_load_module_address" and "get_thread_local_address"
11355         methods.
11356
11357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11358
11359         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11360         (riscv_fbsd_init_abi): Install gdbarch
11361         "fetch_tls_load_module_address" and "get_thread_local_address"
11362         methods.
11363
11364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11365
11366         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11367         (i386fbsd_init_abi): Install gdbarch
11368         "fetch_tls_load_module_address" and "get_thread_local_address"
11369         methods.
11370
11371 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11372
11373         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11374         (amd64fbsd_init_abi): Install gdbarch
11375         "fetch_tls_load_module_address" and "get_thread_local_address"
11376         methods.
11377
11378 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11379
11380         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11381         (struct fbsd_pspace_data): New type.
11382         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11383         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11384         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11385         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11386         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11387
11388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11389
11390         * gdbtypes.c (lookup_struct_elt): New function.
11391         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11392         * gdbtypes.h (struct struct_elt): New type.
11393         (lookup_struct_elt): New prototype.
11394
11395 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11396
11397         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11398         remove disabled code block.
11399
11400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11401
11402         * gdbarch.sh (get_thread_local_address): New method.
11403         * gdbarch.h, gdbarch.c: Regenerate.
11404         * target.c (target_translate_tls_address): Use
11405         gdbarch_get_thread_local_address if present instead of
11406         target::get_thread_local_address.
11407
11408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11409
11410         * target.h (target::get_thread_local_address): Update comment.
11411
11412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11413
11414         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11415         objfile->separate_debug_objfile_backlink if not NULL.
11416
11417 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11418
11419         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11420         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11421         (amd64bsd_store_inferior_registers): Likewise.
11422         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11423         Enable segment base registers.
11424         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11425         PT_GETFSBASE and PT_GETGSBASE.
11426         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11427         PT_SETGSBASE.
11428         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11429         segment base registers.
11430         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11431
11432 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11433
11434         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11435         Update calls to i386_target_description to add 'segments'
11436         parameter.
11437         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11438         add segment base registers.
11439         * arch/i386.c (i386_create_target_description): Add 'segments'
11440         parameter to enable segment base registers.
11441         * arch/i386.h (i386_create_target_description): Likewise.
11442         * features/i386/32bit-segments.xml: New file.
11443         * features/i386/32bit-segments.c: Generate.
11444         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11445         call to i386_target_description to add 'segments' parameter.
11446         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11447         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11448         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11449         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11450         if feature is present.
11451         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11452         Add 'segments' parameter to call to i386_target_description.
11453         (i386_target_description): Add 'segments' parameter to enable
11454         segment base registers.
11455         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11456         to call to i386_target_description.
11457         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11458         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11459         Define I386_NUM_REGS.
11460         (i386_target_description): Add 'segments' parameter to enable
11461         segment base registers.
11462
11463 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11464
11465         PR/24325
11466         * source-cache.c: #undef open and close, to avoid unresolved
11467         externals during linking.
11468
11469 2019-03-12  Tom Tromey  <tromey@adacore.com>
11470
11471         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11472         const.  Add initializers.
11473         (_initialize_remote): Don't initialize ptid globals.
11474
11475 2019-03-12  Pedro Alves  <palves@redhat.com>
11476
11477         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11478
11479 2019-03-12  Pedro Alves  <palves@redhat.com>
11480
11481         * cp-name-parser.y (main): Remove unused 'len' variable.
11482
11483 2019-03-12  Tom Tromey  <tromey@adacore.com>
11484
11485         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11486         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11487
11488 2019-03-12  Tom Tromey  <tromey@adacore.com>
11489
11490         * linux-nat.c (iterate_over_lwps): Update.
11491         (stop_callback): Remove parameter.
11492         (stop_wait_callback, detach_callback, resume_set_callback)
11493         (select_singlestep_lwp_callback, set_ignore_sigint)
11494         (status_callback, resumed_callback, resume_clear_callback)
11495         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11496         data parameter.
11497         (linux_nat_target::detach, linux_nat_target::resume)
11498         (linux_stop_and_wait_all_lwps, select_event_lwp)
11499         (linux_nat_filter_event, linux_nat_wait_1)
11500         (linux_nat_target::kill, linux_nat_target::stop)
11501         (linux_nat_target::stop): Update.
11502         (linux_nat_resume_callback): Change type.
11503         (resume_stopped_resumed_lwps, count_events_callback)
11504         (select_event_lwp_callback): Likewise.
11505         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11506         * arm-linux-nat.c (struct update_registers_data): Remove.
11507         (update_registers_callback): Change type.
11508         (arm_linux_insert_hw_breakpoint1): Update.
11509         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11510         parameter.
11511         (x86_linux_dr_set_addr): Update.
11512         (x86_linux_dr_set_control): Update.
11513         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11514         (iterate_over_lwps): Use gdb::function_view.
11515         * nat/aarch64-linux-hw-point.c (struct
11516         aarch64_dr_update_callback_param): Remove.
11517         (debug_reg_change_callback): Change type.
11518         (aarch64_notify_debug_reg_change): Update.
11519         * s390-linux-nat.c (s390_refresh_per_info): Update.
11520
11521 2019-03-11  Tom Tromey  <tromey@adacore.com>
11522
11523         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11524         redundant assignment to "this_cu".
11525
11526 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11527
11528         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11529
11530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11531
11532         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11533         from...
11534         (rank_one_type): ... this.
11535
11536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11537
11538         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11539         from...
11540         (rank_one_type): ... this.
11541
11542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11543
11544         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11545         from...
11546         (rank_one_type): ... this.
11547
11548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11549
11550         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11551         from...
11552         (rank_one_type): ... this.
11553
11554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11555
11556         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11557         from...
11558         (rank_one_type): ... this.
11559
11560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11561
11562         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11563         from...
11564         (rank_one_type): ... this.
11565
11566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11567
11568         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11569         from...
11570         (rank_one_type): ... this.
11571
11572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11573
11574         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11575         from...
11576         (rank_one_type): ... this.
11577
11578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11579
11580         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11581         from...
11582         (rank_one_type): ... this.
11583
11584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11585
11586         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11587         from...
11588         (rank_one_type): ... this.
11589
11590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11591
11592         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11593         from...
11594         (rank_one_type): ... this.
11595
11596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11597
11598         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11599         from...
11600         (rank_one_type): ... this.
11601
11602 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11603
11604         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11605         inferior-events' shows the example events.
11606
11607 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11608
11609         Support styling on native MS-Windows console
11610
11611         PR/24315
11612         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11613         on MS-Windows if $TERM is not defined.
11614
11615         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11616
11617         * posix-hdep.c (gdb_console_fputs):
11618         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11619         functions.
11620         * ui-file.h (gdb_console_fputs): Add prototype.
11621
11622         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11623         back to fputs only if the former returns zero.
11624
11625 2019-03-07  Tom Tromey  <tom@tromey.com>
11626
11627         * symmisc.c (print_symbol_bcache_statistics): Update.
11628         (print_objfile_statistics): Update.
11629         * symfile.c (allocate_symtab): Update.
11630         * stabsread.c: Don't include bcache.h.
11631         * psymtab.h (struct psymbol_bcache): Don't declare.
11632         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11633         (psymbol_bcache_init, psymbol_bcache_free)
11634         (psymbol_bcache_get_bcache): Don't declare.
11635         * psymtab.c (struct psymbol_bcache): Remove.
11636         (psymtab_storage::psymtab_storage): Update.
11637         (psymtab_storage::~psymtab_storage): Update.
11638         (psymbol_bcache_init, psymbol_bcache_free)
11639         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11640         (add_psymbol_to_bcache): Update.
11641         (allocate_psymtab): Update.
11642         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11643         macro_cache>: No longer pointers.
11644         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11645         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11646         * macrotab.c (macro_bcache): Update.
11647         * macroexp.c: Don't include bcache.h.
11648         * gdbtypes.c (check_types_worklist): Update.
11649         (types_deeply_equal): Remove TRY/CATCH.  Update.
11650         * elfread.c (elf_symtab_read): Update.
11651         * dwarf2read.c: Don't include bcache.h.
11652         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11653         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11654         (print_bcache_statistics, bcache_memory_used): Don't declare.
11655         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11656         methods.  Rename all data members.
11657         * bcache.c (struct bcache): Move to bcache.h.
11658         (bcache::expand_hash_table): Rename from expand_hash_table.
11659         (bcache): Remove.
11660         (bcache::insert): Rename from bcache_full.
11661         (bcache::compare): Rename from bcache_compare.
11662         (bcache_xmalloc): Remove.
11663         (bcache::~bcache): Rename from bcache_xfree.
11664         (bcache::print_statistics): Rename from print_bcache_statistics.
11665         (bcache::memory_used): Rename from bcache_memory_used.
11666
11667 2019-03-07  Pedro Alves  <palves@redhat.com>
11668
11669         * infrun.c (normal_stop): Also check for
11670         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11671
11672 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11673
11674         * f-lang.c (value_from_host_double): Moved to...
11675         * value.c (value_from_host_double): ...here.
11676         * value.h (value_from_host_double): Declare.
11677         * guile/scm-math.c (vlscm_convert_typed_number): Use
11678         value_from_host_double.
11679         (vlscm_convert_number): Likewise.
11680         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11681         * python/py-value.c (convert_value_from_python): Likewise.
11682
11683 2019-03-06  Tom Tromey  <tom@tromey.com>
11684
11685         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11686
11687 2019-03-06  Tom Tromey  <tom@tromey.com>
11688
11689         * utils.h (free_current_contents): Don't declare.
11690         * utils.c (free_current_contents): Remove.
11691
11692 2019-03-06  Tom Tromey  <tom@tromey.com>
11693
11694         * top.c (quit_force): Update.
11695         * main.c (captured_command_loop): Update.
11696         * common/new-op.c (operator new): Update.
11697         * common/common-exceptions.c (struct catcher)
11698         <save_cleanup_chain>: Remove member.
11699         (exceptions_state_mc_init): Update.
11700         (exception_try_scope_entry): Return nullptr.
11701         (exception_try_scope_exit, exception_rethrow)
11702         (throw_exception_sjlj, throw_exception_cxx): Update.
11703         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11704         (all_cleanups, do_cleanups, discard_cleanups)
11705         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11706         (restore_cleanups, restore_final_cleanups): Don't declare.
11707         (do_final_cleanups): Remove parameter.
11708         * common/cleanups.c (cleanup_chain, make_cleanup)
11709         (make_cleanup_dtor, all_cleanups, do_cleanups)
11710         (discard_my_cleanups, discard_cleanups)
11711         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11712         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11713         (null_cleanup): Remove.
11714         (do_final_cleanups): Remove parameter.
11715
11716 2019-03-06  Tom Tromey  <tom@tromey.com>
11717
11718         * remote.c (remote_target::remote_parse_stop_reply): Use
11719         unique_xmalloc_ptr.
11720
11721 2019-03-06  Tom Tromey  <tom@tromey.com>
11722
11723         * stabsread.c (struct stabs_field_info): Rename from field_info.
11724         <list, fnlist>: Add initializers.
11725         <obstack>: New member.
11726         (read_member_functions, read_struct_fields, read_baseclasses):
11727         Allocate on obstack.  Don't use cleanups.
11728         (read_one_struct_field, read_member_functions, read_struct_fields)
11729         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11730         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11731         (read_struct_type): Update.
11732
11733 2019-03-06  Tom Tromey  <tom@tromey.com>
11734
11735         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11736         * common/filestuff.h (make_cleanup_close): Don't declare.
11737         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11738         Remove.
11739
11740 2019-03-06  Tom Tromey  <tom@tromey.com>
11741
11742         * solib-aix.c: Use make_scope_exit.
11743
11744 2019-03-06  Tom Tromey  <tom@tromey.com>
11745
11746         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11747         Use make_scope_exit.
11748
11749 2019-03-06  Tom Tromey  <tom@tromey.com>
11750
11751         * solib-svr4.c (disable_probes_interface): Remove parameter.
11752         (svr4_handle_solib_event): Use make_scope_exit.
11753
11754 2019-03-06  Tom Tromey  <tom@tromey.com>
11755
11756         * remote.c (struct stop_reply_deleter): Remove.
11757         (stop_reply_up): Update.
11758         (struct stop_reply): Derive from notif_event.  Don't typedef.
11759         <regcache>: Now a std::vector.
11760         (stop_reply_xfree): Remove.
11761         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11762         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11763         (remote_target::discard_pending_stop_replies): Use delete.
11764         (remote_target::remote_parse_stop_reply): Update.
11765         (remote_target::process_stop_reply): Update.
11766         * remote-notif.h (struct notif_event): Add virtual destructor.
11767         Remove "dtr" member.
11768         (struct notif_client) <alloc_event>: Return a unique_ptr.
11769         (notif_event_xfree): Don't declare.
11770         (notif_event_up): New typedef.
11771         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11772         (notif_event_xfree, do_notif_event_xfree): Remove.
11773         (remote_notif_state_xfree): Update.
11774
11775 2019-03-06  Tom Tromey  <tom@tromey.com>
11776
11777         * infrun.c (displaced_step_clear_cleanup): Now a
11778         forward_scope_exit type.
11779         (displaced_step_prepare_throw): Update.
11780         (displaced_step_fixup): Update.
11781
11782 2019-03-06  Tom Tromey  <tom@tromey.com>
11783
11784         * inferior.h (class inferior): Update comment.
11785         * gdbthread.h (class thread_info): Update comment.
11786
11787 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11788             Tom Tromey  <tom@tromey.com>
11789
11790         * stabsread.h (struct stab_section_list): Remove.
11791         (coffstab_build_psymtabs): Update.
11792         * dbxread.c (symbuf_sections): Now a std::vector.
11793         (sect_idx): New global.
11794         (fill_symbuf): Update.
11795         (coffstab_build_psymtabs): Change type of stabsects parameter.
11796         Update.
11797         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11798         std::vector.
11799         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11800         (coff_locate_sections): Update.
11801         (coff_symfile_read): Remove cleanups.  Update.
11802         (init_stringtab): Add storage parameter.
11803         (free_stringtab, free_stringtab_cleanup): Remove.
11804         (init_lineno): Add storage parameter.
11805         (free_linetab, free_linetab_cleanup): Remove.
11806
11807 2019-03-06  Pedro Alves  <palves@redhat.com>
11808
11809         * linux-fork.c (fork_info::clobber_regs): Delete.
11810         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11811         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11812         comment.  Adjust.
11813         (scoped_switch_fork_info::scoped_switch_fork_info)
11814         (checkpoint_command, linux_fork_context): Adjust
11815         fork_save_infrun_state calls.
11816
11817 2019-03-06  Pedro Alves  <palves@redhat.com>
11818
11819         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11820         (inf_has_multiple_threads): Return 'bool' and rewrite using
11821         inferior_info::threads().
11822
11823 2019-03-06  Pedro Alves  <palves@redhat.com>
11824
11825         * linux-fork.c: Include <list>.
11826         (fork_list): Now a std::list instance.
11827         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11828         (forks_exist_p, find_last_fork): Adjust.
11829         (new_fork): Delete.
11830         (one_fork_p): New.
11831         (add_fork): Adjust.
11832         (free_fork): Delete, folded into fork_info::~fork_info().
11833         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11834         Adjust.
11835         (init_fork_list): Delete.
11836         (linux_fork_killall, linux_fork_mourn_inferior)
11837         (linux_fork_detach, info_checkpoints_command): Adjust.
11838         (_initialize_linux_fork): No longer call init_fork_list.
11839
11840 2019-03-06  Pedro Alves  <palves@redhat.com>
11841
11842         * linux-fork.c (new_fork): New, split out of ...
11843         (add_fork): ... this.  Return void.  Move "first fork" special
11844         case from here, to ...
11845         (checkpoint_command): ... here.
11846         * linux-linux.h (add_fork): Return void.
11847
11848 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11849
11850         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11851
11852 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11853             Chris January  <chris.january@arm.com>
11854             David Lecomber  <david.lecomber@arm.com>
11855
11856         * f-exp.y: New token, UNOP_INTRINSIC.
11857         (exp): New pattern using UNOP_INTRINSIC token.
11858         (f77_keywords): Add 'abs' keyword.
11859         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11860         (value_from_host_double): New function.
11861         (evaluate_subexp_f): Support UNOP_ABS.
11862
11863 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11864
11865         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11866         types.
11867
11868 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11869
11870         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11871         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11872         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11873
11874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11875
11876         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11877
11878 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11879             Chris January  <chris.january@arm.com>
11880
11881         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11882         * f-exp.y: Define 'KIND' token.
11883         (exp): New pattern for KIND expressions.
11884         (ptype): Handle types with a kind extension.
11885         (direct_abs_decl): Extend to spot kind extensions.
11886         (f77_keywords): Add 'kind' to the list.
11887         (push_kind_type): New function.
11888         (convert_to_kind_type): New function.
11889         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11890         * parse.c (operator_length_standard): Likewise.
11891         * parser-defs.h (enum type_pieces): Add tp_kind.
11892         * std-operator.def: Add UNOP_KIND.
11893
11894 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11895
11896         * f-exp.y (f_parse): Set yydebug.
11897
11898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11899
11900         * f-lang.c (evaluate_subexp_f): New function.
11901         (exp_descriptor_f): New global.
11902         (f_language_defn): Use exp_descriptor_f instead of
11903         exp_descriptor_standard.
11904
11905 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11906
11907         * f-exp.y (struct token): Add comments.
11908         (dot_ops): Remove uppercase versions and the end marker.
11909         (f77_keywords): Likewise.
11910         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11911         entries in the dot_ops array are case insensitive, and use
11912         strncasecmp to compare strings.  Also some whitespace cleanup in
11913         this area.  Similar for the f77_keywords array, except entries in
11914         this list might be case sensitive.
11915
11916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11917
11918         * f-exp.y (struct f77_boolean_val): Add comments.
11919         (boolean_values): Remove uppercase versions, and end marker.
11920         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11921         and use strncasecmp to achieve case insensitivity.  Additionally,
11922         perform whitespace cleanup around this code.
11923
11924 2019-03-06  Tom Tromey  <tromey@adacore.com>
11925
11926         * remote-sim.c (gdbsim_target_open): Use result of
11927         gdb_argv::release.
11928
11929 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11930         Dirk Schubert  <dirk.schubert@arm.com>
11931         Chris January  <chris.january@arm.com>
11932
11933         * eval.c (evaluate_subexp_standard): Call Fortran argument
11934         wrapping logic.
11935         * f-lang.c (struct value): A value which can be passed into a
11936         Fortran function call.
11937         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11938         where appropriate.
11939         (struct type): Value ready for a Fortran function call.
11940         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11941         is needed.
11942         * f-lang.h (fortran_argument_convert): Declaration.
11943         (fortran_preserve_arg_pointer): Declaration.
11944         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11945
11946 2019-03-05  Tom Tromey  <tromey@adacore.com>
11947
11948         * python/py-prettyprint.c (print_string_repr): Remove #if.
11949         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11950
11951 2019-03-05  Tom Tromey  <tromey@adacore.com>
11952
11953         * target.c (the_dummy_target): Move later.  Change type to
11954         "dummy_target".
11955         (initialize_targets): Don't initialize the_dummy_target.
11956
11957 2019-03-05  Tom Tromey  <tromey@adacore.com>
11958
11959         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11960         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11961
11962 2019-03-05  Tom Tromey  <tromey@adacore.com>
11963
11964         * windows-nat.c (windows_nat_target::attach)
11965         (windows_nat_target::detach): Don't call gdb_flush.
11966         * valprint.c (generic_val_print, val_print, val_print_string):
11967         Don't call gdb_flush.
11968         * utils.c (defaulted_query): Don't call gdb_flush.
11969         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11970         * target.c (target_announce_detach): Don't call gdb_flush.
11971         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11972         * remote.c (extended_remote_target::attach): Don't call
11973         gdb_flush.
11974         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11975         * printcmd.c (do_examine): Don't call gdb_flush.
11976         (info_display_command): Don't call gdb_flush.
11977         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11978         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11979         * memattr.c (info_mem_command): Don't call gdb_flush.
11980         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11981         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11982         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11983         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11984         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11985         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11986         (gnu_nat_target::detach): Don't call gdb_flush.
11987         * f-valprint.c (f_val_print): Don't call gdb_flush.
11988         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11989         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11990         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11991         gdb_flush.
11992         * c-valprint.c (c_val_print): Don't call gdb_flush.
11993         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11994
11995 2019-03-05  Tom Tromey  <tromey@adacore.com>
11996
11997         * varobj.c (update_dynamic_varobj_children): Update.
11998         (install_default_visualizer): Use reset, not release.
11999         * value.c (set_internalvar): Update.
12000         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12001         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12002         ATTRIBUTE_UNUSED_RESULT.
12003
12004 2019-03-05  Tom Tromey  <tromey@adacore.com>
12005
12006         * remote.c (class scoped_remote_fd) <release>: Add
12007         ATTRIBUTE_UNUSED_RESULT.
12008
12009 2019-03-05  Tom Tromey  <tromey@adacore.com>
12010
12011         * macroexp.c (struct macro_buffer) <release>: Add
12012         ATTRIBUTE_UNUSED_RESULT.
12013
12014 2019-03-05  Tom Tromey  <tromey@adacore.com>
12015
12016         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12017         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12018         ATTRIBUTE_UNUSED_RESULT.
12019
12020 2019-03-05  Tom Tromey  <tromey@adacore.com>
12021
12022         * common/scoped_fd.h (class scoped_fd) <release>: Add
12023         ATTRIBUTE_UNUSED_RESULT.
12024
12025 2019-03-05  Tom Tromey  <tromey@adacore.com>
12026
12027         * parser-defs.h (struct parser_state) <release>: Add
12028         ATTRIBUTE_UNUSED_RESULT.
12029
12030 2019-03-05  Tom Tromey  <tromey@adacore.com>
12031
12032         * utils.h (class gdb_argv) <release>: Add
12033         ATTRIBUTE_UNUSED_RESULT.
12034         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12035
12036 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12037
12038         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12039         for-loop range, to avoid compiler warnings.
12040
12041         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12042         avoid compiler warnings about unused variables.
12043
12044         * NEWS: Mention end of support for native debugging on MS-Windows
12045         before XP.
12046
12047         PR gdb/24292
12048         * common/netstuff.c:
12049         * gdbserver/gdbreplay.c
12050         * gdbserver/remote-utils.c:
12051         * ser-tcp.c:
12052         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12053         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12054         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12055         'getaddrinfo' and 'freeaddrinfo' were not available before
12056         Windows XP, and mingw.org's MinGW headers by default define
12057         _WIN32_WINNT to 0x500.
12058
12059 2019-03-01  Gary Benson <gbenson@redhat.com>
12060
12061         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12062
12063 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12064             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12065
12066         PR gdb/8527
12067         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12068         set_sigint_trap, clear_sigint_trap.
12069
12070 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12071
12072         * target.c (target_detach): Clear the regcache and the
12073         frame cache.
12074
12075 2019-02-27  Pedro Alves  <palves@redhat.com>
12076
12077         * utils.c (set_screen_size): When we cap the height/width sizes,
12078         tweak the corresponding command variable to show "unlimited":
12079
12080 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12081             Pedro Alves  <palves@redhat.com>
12082
12083         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12084         before calling rl_set_screen_size.
12085
12086 2019-02-27  Tom Tromey  <tromey@adacore.com>
12087
12088         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12089         define.
12090         * python/py-value.c: Remove Python 2.4 workaround.
12091         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12092         workaround.
12093         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12094         Python 2.4 workaround.
12095         * python/python-internal.h: Remove Python 2.4 comment.
12096         (Py_ssize_t): Don't define.
12097         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12098         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12099         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12100         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12101         * python/python.c (do_start_initialization): Remove Python 2.4
12102         workaround.
12103         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12104         (print_children): Remove Python 2.4 workaround.
12105         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12106         workaround.
12107         (CHARBUFFERPROC_NAME): Remove.
12108         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12109         Python 2.4 workaround.
12110
12111 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12112
12113         * NEWS: Note minimum Python version.
12114
12115 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12116
12117         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12118         code from these functions.  Remove corresponding ifdefs.  Use
12119         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12120         Remove gotos and target of gotos.
12121         (infpy_search_memory): Likewise.
12122
12123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12124
12125         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12126         (hppa_gdbarch_init): Don't register deleted functions with
12127         gdbarch.
12128
12129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12130
12131         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12132         (h8300_unwind_sp): Delete.
12133         (h8300_dummy_id): Delete.
12134         (h8300_gdbarch_init): Don't register deleted functions with
12135         gdbarch.
12136
12137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12138
12139         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12140         (ft32_unwind_pc): Delete.
12141         (ft32_unwind_sp): Delete.
12142         (ft32_gdbarch_init): Don't register deleted functions with
12143         gdbarch.
12144
12145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12146
12147         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12148         (frv_unwind_pc): Delete.
12149         (frv_unwind_sp): Delete.
12150         (frv_gdbarch_init): Don't register deleted functions with
12151         gdbarch.
12152
12153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12154
12155         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12156         (riscv_unwind_pc): Delete.
12157         (riscv_unwind_sp): Delete.
12158         (riscv_gdbarch_init): Don't register deleted functions with
12159         gdbarch.
12160
12161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12162
12163         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12164         (csky_unwind_pc): Delete.
12165         (csky_unwind_sp): Delete.
12166         (csky_gdbarch_init): Don't register deleted functions with
12167         gdbarch.
12168
12169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12170
12171         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12172         (cris_unwind_pc): Delete.
12173         (cris_unwind_sp): Delete.
12174         (cris_gdbarch_init): Don't register deleted functions with
12175         gdbarch.
12176
12177 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12178
12179         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12180         (bfin_unwind_pc): Delete.
12181         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12182
12183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12184
12185         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12186         (arm_unwind_pc): Delete.
12187         (arm_unwind_sp): Delete.
12188         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12189
12190 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12191
12192         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12193         (arc_unwind_pc): Delete.
12194         (arc_unwind_sp): Delete.
12195         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12196
12197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12198
12199         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12200         (alpha_unwind_pc): Delete.
12201         (alpha_gdbarch_init): Don't register deleted functions with
12202         gdbarch.
12203
12204 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12205
12206         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12207         (aarch64_unwind_pc): Delete.
12208         (aarch64_unwind_sp): Delete.
12209         (aarch64_gdbarch_init): Don't register deleted functions with
12210         gdbarch.
12211
12212 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12213
12214         * gdbtypes.c (type_align): Don't consider static members when
12215         computing structure alignment.
12216
12217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12218
12219         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12220         return 0 for other types.
12221         * arch-utils.c (default_type_align): Always return 0.
12222         * gdbarch.h: Regenerate.
12223         * gdbarch.sh (type_align): Extend comment.
12224         * gdbtypes.c (type_align): Add additional comments, always call
12225         gdbarch_type_align before applying the default rules.
12226         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12227         generic code will then apply a suitable default.
12228         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12229         types, return 0 for other types.
12230
12231 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12232
12233         * NEWS: Create a new section for the next release branch.
12234         Rename the section of the current branch, now that it has
12235         been cut.
12236
12237 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12238
12239         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12240         * version.in: Bump version to 8.3.50.DATE-git.
12241
12242 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12243
12244         * aix-thread.c (ptid_cmp): Remove unused variable.
12245         (get_signaled_thread): Likewise.
12246         (store_regs_user_thread): Likewise.
12247         (store_regs_kernel_thread): Likewise.
12248         (fetch_regs_kernel_thread): Remove shadowed variable.
12249
12250 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12251
12252         * features/riscv/32bit-cpu.xml: Add register numbers.
12253         * features/riscv/32bit-fpu.c: Regenerate.
12254         * features/riscv/32bit-fpu.xml: Add register numbers.
12255         * features/riscv/64bit-cpu.xml: Add register numbers.
12256         * features/riscv/64bit-fpu.c: Regenerate.
12257         * features/riscv/64bit-fpu.xml: Add register numbers.
12258
12259 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12260
12261         * NEWS: Mention two argument form of gdb.Value constructor.
12262         * python/py-value.c (convert_buffer_and_type_to_value): New
12263         function.
12264         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12265         Add support for handling an optional second argument.  Call
12266         convert_buffer_and_type_to_value as appropriate.
12267         * python/python-internal.h (Py_buffer_deleter): New struct.
12268         (Py_buffer_up): New typedef.
12269
12270 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12271
12272         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12273         instead of releasing ownership.
12274
12275 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12276
12277         * dwarf2read.c (open_and_init_dwp_file): Call
12278         elf_numsections instead of bfd_count_sections to initialize
12279         dwp_file->num_sections.
12280
12281 2019-02-25  Tom Tromey  <tromey@adacore.com>
12282
12283         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12284
12285 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12286
12287         * gcore.in: Add '--readnever' option when invoking GDB.
12288
12289 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12290
12291         * MAINTAINERS: Update my email address.
12292
12293 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12294
12295         * build-id.c (build_id_to_debug_bfd_1): New function.
12296         (build_id_to_debug_bfd): Look for separate debug file in
12297         sysroot.
12298
12299 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12300
12301         * gdbarch.sh: Update the copyright year range that is placed into
12302         generated files.
12303
12304 2019-02-22  Keith Seitz  <keiths@redhat.com>
12305
12306         PR symtab/23853
12307         * linespec.c (create_sals_line_offset): Search for the default
12308         symtab's filename instead of its fullname.
12309
12310 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12311
12312         * NEWS: Update style defaults.
12313
12314 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12315
12316         * main.c (captured_main_1): Disable styling in batch mode.
12317
12318 2019-02-20  Tom Tromey  <tom@tromey.com>
12319
12320         * symtab.c (symtab_symbol_info): Fix typos.
12321
12322 2019-02-20  Tom Tromey  <tromey@adacore.com>
12323
12324         * findcmd.c (_initialize_mem_search): Use upper case for
12325         metasyntactic variables.
12326
12327 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12328
12329         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12330         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12331
12332 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12333
12334         * top.h (source_file_name): Change to std::string.
12335         * top.c (source_file_name): Likewise.
12336         (command_line_input): Adjust.
12337         * cli/cli-script.c (script_from_file): Adjust.
12338
12339 2019-02-19  Tom Tromey  <tromey@adacore.com>
12340
12341         * ravenscar-thread.c
12342         (ravenscar_thread_target::update_thread_list): Don't call
12343         ada_build_task_list.
12344         * ada-lang.h (ada_build_task_list): Don't declare.
12345         * ada-tasks.c (struct ada_tasks_inferior_data)
12346         <task_list_valid_p>: Now bool.
12347         (read_known_tasks, ada_task_list_changed)
12348         (ada_tasks_invalidate_inferior_data): Update.
12349         (read_known_tasks_array): Return bool.
12350         (read_known_tasks_list): Likewise.
12351         (read_known_tasks): Return void.
12352         (ada_build_task_list): Now static.
12353
12354 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12355
12356         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12357         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12358
12359 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12360
12361         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12362         variant for ada_tasks_pspace_data_handle and
12363         ada_tasks_inferior_data_handle.
12364         (ada_tasks_pspace_data_cleanup): New function.
12365         (ada_tasks_inferior_data_cleanup): New function.
12366
12367 2019-02-17  Tom Tromey  <tom@tromey.com>
12368
12369         * macrotab.h (macro_source_fullname): Return a std::string.
12370         * macrotab.c (macro_include, check_for_redefinition)
12371         (macro_undef, macro_lookup_definition, foreach_macro)
12372         (foreach_macro_in_scope): Update.
12373         (macro_source_fullname): Return a std::string.
12374         * macrocmd.c (show_pp_source_pos): Update.
12375
12376 2019-02-17  Tom Tromey  <tom@tromey.com>
12377
12378         * macrocmd.c (show_pp_source_pos): Style the file names.
12379
12380 2019-02-17  Tom Tromey  <tom@tromey.com>
12381
12382         PR tui/24197:
12383         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12384
12385 2019-02-17  Tom Tromey  <tom@tromey.com>
12386
12387         * ada-lang.c (user_select_syms): Use filtered printing.
12388         * utils.c (wrap_style): New global.
12389         (desired_style): Remove.
12390         (emit_style_escape): Add stream parameter.
12391         (set_output_style, reset_terminal_style, prompt_for_continue):
12392         Update.
12393         (flush_wrap_buffer): Only flush gdb_stdout.
12394         (wrap_here): Set wrap_style.
12395         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12396         treat escape sequences as a character.  Change when wrap buffer is
12397         flushed.
12398         (fputs_styled): Do not set the output style when the default is
12399         requested.
12400         * ui-style.h (struct ui_file_style) <is_default>: New method.
12401         * source.c (print_source_lines_base): Emit escape sequences in one
12402         piece.
12403
12404 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12405
12406         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12407         integers and enumeration types.
12408
12409 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12410
12411         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12412         instead of lookup_symbol_in_language
12413         (do_exact_match): New function.
12414         (ada_get_symbol_name_matcher): Return do_exact_match when
12415         doing a verbatim match.
12416
12417 2019-02-15  Tom Tromey  <tromey@adacore.com>
12418
12419         * ravenscar-thread.c (ravenscar_thread_target::resume)
12420         (ravenscar_thread_target::wait): Special case wildcard requests.
12421
12422 2019-02-15  Tom Tromey  <tromey@adacore.com>
12423
12424         * ravenscar-thread.c (base_ptid): Remove.
12425         (struct ravenscar_thread_target) <close>: New method.
12426         <m_base_ptid>: New member.
12427         <update_inferior_ptid, active_task, task_is_currently_active,
12428         runtime_initialized>: Declare methods.
12429         <ravenscar_thread_target>: Add constructor.
12430         (ravenscar_thread_target::task_is_currently_active)
12431         (ravenscar_thread_target::update_inferior_ptid)
12432         (ravenscar_runtime_initialized): Rename.  Now methods.
12433         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12434         (ravenscar_thread_target::update_thread_list): Update.
12435         (ravenscar_thread_target::active_task): Now method.
12436         (ravenscar_thread_target::store_registers)
12437         (ravenscar_thread_target::prepare_to_store)
12438         (ravenscar_thread_target::prepare_to_store)
12439         (ravenscar_thread_target::mourn_inferior): Update.
12440         (ravenscar_inferior_created): Use "new" to create target.
12441         (ravenscar_thread_target::get_ada_task_ptid): Update.
12442         (_initialize_ravenscar): Don't initialize base_ptid.
12443         (ravenscar_ops): Remove global.
12444
12445 2019-02-15  Tom Tromey  <tromey@adacore.com>
12446
12447         * target.h (push_target): Declare new overload.
12448         * target.c (push_target): New overload, taking an rvalue reference.
12449         * remote.c (remote_target::open_1): Use push_target overload.
12450         * corelow.c (core_target_open): Use push_target overload.
12451
12452 2019-02-15  Tom Tromey  <tromey@adacore.com>
12453
12454         * ravenscar-thread.c (is_ravenscar_task)
12455         (ravenscar_task_is_currently_active): Return bool.
12456         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12457         (_initialize_ravenscar): Remove "(void)".
12458         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12459         Return bool.
12460
12461 2019-02-15  Tom Tromey  <tromey@adacore.com>
12462
12463         * ravenscar-thread.c (ravenscar_runtime_initializer)
12464         (has_ravenscar_runtime, get_running_thread_id)
12465         (ravenscar_thread_target::resume): Fix indentation.
12466
12467 2019-02-15  Tom Tromey  <tromey@adacore.com>
12468
12469         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12470         from ravenscar_arch_ops.
12471         (sparc_ravenscar_ops::fetch_registers)
12472         (sparc_ravenscar_ops::store_registers): Now methods.
12473         (sparc_ravenscar_prepare_to_store): Remove.
12474         (sparc_ravenscar_ops): Redefine.
12475         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12476         methods and destructor.  Remove members.
12477         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12478         (ravenscar_thread_target::store_registers)
12479         (ravenscar_thread_target::prepare_to_store): Update.
12480         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12481         Remove.
12482         (struct ppc_ravenscar_powerpc_ops): Derive from
12483         ravenscar_arch_ops.
12484         (ppc_ravenscar_powerpc_ops::fetch_registers)
12485         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12486         (ppc_ravenscar_powerpc_ops): Redefine.
12487         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12488         (ppc_ravenscar_e500_ops::fetch_registers)
12489         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12490         (ppc_ravenscar_e500_ops): Redefine.
12491         * aarch64-ravenscar-thread.c
12492         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12493         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12494         (aarch64_ravenscar_fetch_registers)
12495         (aarch64_ravenscar_store_registers): Now methods.
12496         (aarch64_ravenscar_ops): Redefine.
12497
12498 2019-02-15  Tom Tromey  <tromey@adacore.com>
12499
12500         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12501         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12502         (ravenscar_thread_target::stopped_by_watchpoint)
12503         (ravenscar_thread_target::stopped_data_address)
12504         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12505
12506 2019-02-15  Tom Tromey  <tromey@adacore.com>
12507
12508         * ravenscar-thread.c: Fix some typos.
12509
12510 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12511             Tom Tromey  <tromey@adacore.com>
12512
12513         * ada-lang.c (ada_exception_sal): Change addr_string to a
12514         std::string.
12515         (create_ada_exception_catchpoint): Update.
12516
12517 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12518             Tom Tromey  <tromey@adacore.com>
12519
12520         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12521         (bp_location_ops): Remove.
12522         (base_breakpoint_allocate_location): Update.
12523         (free_bp_location): Update.
12524         * ada-lang.c (class ada_catchpoint_location)
12525         <ada_catchpoint_location>: Remove ops parameter.
12526         (ada_catchpoint_location_dtor): Remove.
12527         (ada_catchpoint_location_ops): Remove.
12528         (allocate_location_exception): Update.
12529         * breakpoint.h (struct bp_location_ops): Remove.
12530         (class bp_location) <bp_location>: Remove bp_location_ops
12531         parameter.
12532         <~bp_location>: Add destructor.
12533         <ops>: Remove.
12534
12535 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12536             Pedro Alves  <palves@redhat.com>
12537
12538         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12539         'PATH_MAX'.
12540
12541 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12542             Samuel Thibault  <samuel.thibault@gnu.org>
12543             Thomas Schwinge  <thomas@codesourcery.com>
12544
12545         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12546         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12547
12548 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12549
12550         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12551         (check_empty): Use "const char *".
12552
12553         * gnu-nat.c (gnu_nat_target::detach): Instead of
12554         'detach_inferior (pid)' call
12555         'detach_inferior (find_inferior_pid (pid))'.
12556
12557         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12558         'nat/fork-inferior.o'.
12559         * gnu-nat.c: #include "nat/fork-inferior.h".
12560
12561         * gnu-nat.c (gnu_nat_target::detach): Instead of
12562         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12563         * gnu-nat.h: #include "inf-child.h".
12564         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12565         'i386_gnu_nat_target::fetch_registers'.
12566         (gnu_store_registers): Rename/move to
12567         'i386_gnu_nat_target::store_registers'.
12568
12569         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12570         * gnu-nat.h (mach_thread_info): New function.
12571         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12572
12573         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12574
12575 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12576
12577         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12578
12579 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12580
12581         * windows-nat.c (windows_add_thread): Add new parameter
12582         "main_thread_p" with default value set to false.  Update
12583         function documentation as well as all callers.
12584         (windows_delete_thread): Likewise.
12585         (fake_create_process): Update call to windows_add_thread.
12586         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12587         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12588         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12589         call to windows_delete_thread.
12590
12591 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12592
12593         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12594
12595 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12596
12597         * symfile.c (find_separate_debug_file): Use canonical path of
12598         sysroot with child_path instead of gdb_sysroot if it is valid.
12599
12600 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12601
12602         * symfile.c (find_separate_debug_file): Use child_path to
12603         determine if an object file is under a sysroot.
12604
12605 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12606
12607         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12608         unittests/child-path-selftests.c.
12609         * common/pathstuff.c (child_path): New function.
12610         * common/pathstuff.h (child_path): New prototype.
12611         * unittests/child-path-selftests.c: New file.
12612
12613 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12614
12615         * symfile.c (find_separate_debug_file): Look for separate debug
12616         files in debug directories under the sysroot.
12617
12618 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12619
12620         * symtab.h (struct minimal_symbol data_p): New const method.
12621         (struct minimal_symbol text_p): Likewise.
12622         * symtab.c (output_source_filename): Use file name style
12623         to print file name.
12624         (print_symbol_info): Likewise.
12625         (print_msymbol_info): Use address style to print addresses.
12626         Use function name style to print executable text symbols.
12627         (expand_symtab_containing_pc): Use data_p.
12628         (find_pc_sect_compunit_symtab): Likewise.
12629
12630 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12631
12632         * breakpoint.c (describe_other_breakpoints): Use address style
12633         to print addresses.
12634         (say_where): Likewise.
12635
12636 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12637
12638         * ada-typeprint.c (print_func_type): Print function name
12639         style to print function name.
12640         * c-typeprint.c (c_print_type_1): Likewise.
12641
12642 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12643
12644         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12645         for execve.
12646
12647 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12648
12649         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12650         type_stack.
12651
12652 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12653
12654         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12655         TYPE_CODE_REF types.
12656
12657 2019-02-08  Jim Wilson  <jimw@sifive.com>
12658
12659         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12660         (riscv_linux_fregset): New.
12661         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12662
12663 2019-02-07  Tom Tromey  <tom@tromey.com>
12664
12665         * thread.c (thread_cancel_execution_command): Update.
12666         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12667         methods.
12668         (struct thread_fsm_ops): Remove.
12669         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12670         (thread_fsm_should_stop, thread_fsm_return_value)
12671         (thread_fsm_set_finished, thread_fsm_finished_p)
12672         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12673         Don't declare.
12674         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12675         * infrun.c (clear_proceed_status_thread)
12676         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12677         (print_stop_event): Update.
12678         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12679         Add constructor.
12680         (step_command_fsm_ops): Remove.
12681         (new_step_command_fsm): Remove.
12682         (step_1): Update.
12683         (step_command_fsm::should_stop): Rename from
12684         step_command_fsm_should_stop.
12685         (step_command_fsm::clean_up): Rename from
12686         step_command_fsm_clean_up.
12687         (step_command_fsm::do_async_reply_reason): Rename from
12688         step_command_fsm_async_reply_reason.
12689         (struct until_next_fsm): Inherit from thread_fsm.  Add
12690         constructor.
12691         (until_next_fsm_ops): Remove.
12692         (new_until_next_fsm): Remove.
12693         (until_next_fsm::should_stop): Rename from
12694         until_next_fsm_should_stop.
12695         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12696         (until_next_fsm::do_async_reply_reason): Rename from
12697         until_next_fsm_async_reply_reason.
12698         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12699         constructor.  Change type of breakpoint.
12700         (finish_command_fsm_ops): Remove.
12701         (new_finish_command_fsm): Remove.
12702         (finish_command_fsm::should_stop): Rename from
12703         finish_command_fsm_should_stop.
12704         (finish_command_fsm::clean_up): Rename from
12705         finish_command_fsm_clean_up.
12706         (finish_command_fsm::return_value): Rename from
12707         finish_command_fsm_return_value.
12708         (finish_command_fsm::do_async_reply_reason): Rename from
12709         finish_command_fsm_async_reply_reason.
12710         (finish_command): Update.
12711         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12712         Add constructor.
12713         (call_thread_fsm_ops): Remove.
12714         (call_thread_fsm::call_thread_fsm): Rename from
12715         new_call_thread_fsm.
12716         (call_thread_fsm::should_stop): Rename from
12717         call_thread_fsm_should_stop.
12718         (call_thread_fsm::should_notify_stop): Rename from
12719         call_thread_fsm_should_notify_stop.
12720         (run_inferior_call, call_function_by_hand_dummy): Update.
12721         * cli/cli-interp.c (should_print_stop_to_console): Update.
12722         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12723         Add constructor.  Change type of location_breakpoint,
12724         caller_breakpoint.
12725         (until_break_fsm_ops): Remove.
12726         (new_until_break_fsm): Remove.
12727         (until_break_fsm::should_stop): Rename from
12728         until_break_fsm_should_stop.
12729         (until_break_fsm::clean_up): Rename from
12730         until_break_fsm_clean_up.
12731         (until_break_fsm::do_async_reply_reason): Rename from
12732         until_break_fsm_async_reply_reason.
12733         (until_break_command): Update.
12734         * thread-fsm.c: Remove.
12735         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12736
12737 2019-02-07  Tom Tromey  <tom@tromey.com>
12738
12739         * yy-remap.h: Add include guard.
12740         * xtensa-tdep.h: Add include guard.
12741         * xcoffread.h: Rename include guard.
12742         * varobj-iter.h: Add include guard.
12743         * tui/tui.h: Rename include guard.
12744         * tui/tui-winsource.h: Rename include guard.
12745         * tui/tui-wingeneral.h: Rename include guard.
12746         * tui/tui-windata.h: Rename include guard.
12747         * tui/tui-win.h: Rename include guard.
12748         * tui/tui-stack.h: Rename include guard.
12749         * tui/tui-source.h: Rename include guard.
12750         * tui/tui-regs.h: Rename include guard.
12751         * tui/tui-out.h: Rename include guard.
12752         * tui/tui-layout.h: Rename include guard.
12753         * tui/tui-io.h: Rename include guard.
12754         * tui/tui-hooks.h: Rename include guard.
12755         * tui/tui-file.h: Rename include guard.
12756         * tui/tui-disasm.h: Rename include guard.
12757         * tui/tui-data.h: Rename include guard.
12758         * tui/tui-command.h: Rename include guard.
12759         * tic6x-tdep.h: Add include guard.
12760         * target/waitstatus.h: Rename include guard.
12761         * target/wait.h: Rename include guard.
12762         * target/target.h: Rename include guard.
12763         * target/resume.h: Rename include guard.
12764         * target-float.h: Rename include guard.
12765         * stabsread.h: Add include guard.
12766         * rs6000-tdep.h: Add include guard.
12767         * riscv-fbsd-tdep.h: Add include guard.
12768         * regformats/regdef.h: Rename include guard.
12769         * record.h: Rename include guard.
12770         * python/python.h: Rename include guard.
12771         * python/python-internal.h: Rename include guard.
12772         * python/py-stopevent.h: Rename include guard.
12773         * python/py-ref.h: Rename include guard.
12774         * python/py-record.h: Rename include guard.
12775         * python/py-record-full.h: Rename include guard.
12776         * python/py-record-btrace.h: Rename include guard.
12777         * python/py-instruction.h: Rename include guard.
12778         * python/py-events.h: Rename include guard.
12779         * python/py-event.h: Rename include guard.
12780         * procfs.h: Add include guard.
12781         * proc-utils.h: Add include guard.
12782         * p-lang.h: Add include guard.
12783         * or1k-tdep.h: Rename include guard.
12784         * observable.h: Rename include guard.
12785         * nto-tdep.h: Rename include guard.
12786         * nat/x86-linux.h: Rename include guard.
12787         * nat/x86-linux-dregs.h: Rename include guard.
12788         * nat/x86-gcc-cpuid.h: Add include guard.
12789         * nat/x86-dregs.h: Rename include guard.
12790         * nat/x86-cpuid.h: Rename include guard.
12791         * nat/ppc-linux.h: Rename include guard.
12792         * nat/mips-linux-watch.h: Rename include guard.
12793         * nat/linux-waitpid.h: Rename include guard.
12794         * nat/linux-ptrace.h: Rename include guard.
12795         * nat/linux-procfs.h: Rename include guard.
12796         * nat/linux-osdata.h: Rename include guard.
12797         * nat/linux-nat.h: Rename include guard.
12798         * nat/linux-namespaces.h: Rename include guard.
12799         * nat/linux-btrace.h: Rename include guard.
12800         * nat/glibc_thread_db.h: Rename include guard.
12801         * nat/gdb_thread_db.h: Rename include guard.
12802         * nat/gdb_ptrace.h: Rename include guard.
12803         * nat/fork-inferior.h: Rename include guard.
12804         * nat/amd64-linux-siginfo.h: Rename include guard.
12805         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12806         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12807         * nat/aarch64-linux.h: Rename include guard.
12808         * nat/aarch64-linux-hw-point.h: Rename include guard.
12809         * mn10300-tdep.h: Add include guard.
12810         * mips-linux-tdep.h: Add include guard.
12811         * mi/mi-parse.h: Rename include guard.
12812         * mi/mi-out.h: Rename include guard.
12813         * mi/mi-main.h: Rename include guard.
12814         * mi/mi-interp.h: Rename include guard.
12815         * mi/mi-getopt.h: Rename include guard.
12816         * mi/mi-console.h: Rename include guard.
12817         * mi/mi-common.h: Rename include guard.
12818         * mi/mi-cmds.h: Rename include guard.
12819         * mi/mi-cmd-break.h: Rename include guard.
12820         * m2-lang.h: Add include guard.
12821         * location.h: Rename include guard.
12822         * linux-record.h: Rename include guard.
12823         * linux-nat.h: Add include guard.
12824         * linux-fork.h: Add include guard.
12825         * i386-darwin-tdep.h: Rename include guard.
12826         * hppa-linux-offsets.h: Add include guard.
12827         * guile/guile.h: Rename include guard.
12828         * guile/guile-internal.h: Rename include guard.
12829         * gnu-nat.h: Rename include guard.
12830         * gdb-stabs.h: Rename include guard.
12831         * frv-tdep.h: Add include guard.
12832         * f-lang.h: Add include guard.
12833         * event-loop.h: Add include guard.
12834         * darwin-nat.h: Rename include guard.
12835         * cp-abi.h: Rename include guard.
12836         * config/sparc/nm-sol2.h: Rename include guard.
12837         * config/nm-nto.h: Rename include guard.
12838         * config/nm-linux.h: Add include guard.
12839         * config/i386/nm-i386gnu.h: Rename include guard.
12840         * config/djgpp/nl_types.h: Rename include guard.
12841         * config/djgpp/langinfo.h: Rename include guard.
12842         * compile/gcc-cp-plugin.h: Add include guard.
12843         * compile/gcc-c-plugin.h: Add include guard.
12844         * compile/compile.h: Rename include guard.
12845         * compile/compile-object-run.h: Rename include guard.
12846         * compile/compile-object-load.h: Rename include guard.
12847         * compile/compile-internal.h: Rename include guard.
12848         * compile/compile-cplus.h: Rename include guard.
12849         * compile/compile-c.h: Rename include guard.
12850         * common/xml-utils.h: Rename include guard.
12851         * common/x86-xstate.h: Rename include guard.
12852         * common/version.h: Rename include guard.
12853         * common/vec.h: Rename include guard.
12854         * common/tdesc.h: Rename include guard.
12855         * common/selftest.h: Rename include guard.
12856         * common/scoped_restore.h: Rename include guard.
12857         * common/scoped_mmap.h: Rename include guard.
12858         * common/scoped_fd.h: Rename include guard.
12859         * common/safe-iterator.h: Rename include guard.
12860         * common/run-time-clock.h: Rename include guard.
12861         * common/refcounted-object.h: Rename include guard.
12862         * common/queue.h: Rename include guard.
12863         * common/ptid.h: Rename include guard.
12864         * common/print-utils.h: Rename include guard.
12865         * common/preprocessor.h: Rename include guard.
12866         * common/pathstuff.h: Rename include guard.
12867         * common/observable.h: Rename include guard.
12868         * common/netstuff.h: Rename include guard.
12869         * common/job-control.h: Rename include guard.
12870         * common/host-defs.h: Rename include guard.
12871         * common/gdb_wait.h: Rename include guard.
12872         * common/gdb_vecs.h: Rename include guard.
12873         * common/gdb_unlinker.h: Rename include guard.
12874         * common/gdb_unique_ptr.h: Rename include guard.
12875         * common/gdb_tilde_expand.h: Rename include guard.
12876         * common/gdb_sys_time.h: Rename include guard.
12877         * common/gdb_string_view.h: Rename include guard.
12878         * common/gdb_splay_tree.h: Rename include guard.
12879         * common/gdb_setjmp.h: Rename include guard.
12880         * common/gdb_ref_ptr.h: Rename include guard.
12881         * common/gdb_optional.h: Rename include guard.
12882         * common/gdb_locale.h: Rename include guard.
12883         * common/gdb_assert.h: Rename include guard.
12884         * common/filtered-iterator.h: Rename include guard.
12885         * common/filestuff.h: Rename include guard.
12886         * common/fileio.h: Rename include guard.
12887         * common/environ.h: Rename include guard.
12888         * common/common-utils.h: Rename include guard.
12889         * common/common-types.h: Rename include guard.
12890         * common/common-regcache.h: Rename include guard.
12891         * common/common-inferior.h: Rename include guard.
12892         * common/common-gdbthread.h: Rename include guard.
12893         * common/common-exceptions.h: Rename include guard.
12894         * common/common-defs.h: Rename include guard.
12895         * common/common-debug.h: Rename include guard.
12896         * common/cleanups.h: Rename include guard.
12897         * common/buffer.h: Rename include guard.
12898         * common/btrace-common.h: Rename include guard.
12899         * common/break-common.h: Rename include guard.
12900         * cli/cli-utils.h: Rename include guard.
12901         * cli/cli-style.h: Rename include guard.
12902         * cli/cli-setshow.h: Rename include guard.
12903         * cli/cli-script.h: Rename include guard.
12904         * cli/cli-interp.h: Rename include guard.
12905         * cli/cli-decode.h: Rename include guard.
12906         * cli/cli-cmds.h: Rename include guard.
12907         * charset-list.h: Add include guard.
12908         * buildsym-legacy.h: Rename include guard.
12909         * bfin-tdep.h: Add include guard.
12910         * ax.h: Rename include guard.
12911         * arm-linux-tdep.h: Add include guard.
12912         * arm-fbsd-tdep.h: Add include guard.
12913         * arch/xtensa.h: Rename include guard.
12914         * arch/tic6x.h: Add include guard.
12915         * arch/i386.h: Add include guard.
12916         * arch/arm.h: Rename include guard.
12917         * arch/arm-linux.h: Rename include guard.
12918         * arch/arm-get-next-pcs.h: Rename include guard.
12919         * arch/amd64.h: Add include guard.
12920         * arch/aarch64-insn.h: Rename include guard.
12921         * arch-utils.h: Rename include guard.
12922         * annotate.h: Add include guard.
12923         * amd64-darwin-tdep.h: Rename include guard.
12924         * aarch64-linux-tdep.h: Add include guard.
12925         * aarch64-fbsd-tdep.h: Add include guard.
12926         * aarch32-linux-nat.h: Add include guard.
12927
12928 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12929
12930         * macrotab.c (macro_define_internal): New function that
12931         factorizes macro_define_object_internal and macro_define_function
12932         code.
12933         (macro_define_object_internal): Use macro_define_internal.
12934         (macro_define_function): Likewise.
12935
12936 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12937
12938         * macrocmd.c (extract_identifier): Return
12939         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12940         callers.
12941
12942 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12943
12944         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12945
12946 2019-02-05  Tom Tromey  <tom@tromey.com>
12947
12948         * target.c (target_stack::unpush): Move assertion earlier.
12949
12950 2019-01-30  Tom Tromey  <tom@tromey.com>
12951
12952         PR python/23615:
12953         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12954         (gdbpy_parse_and_eval): Likewise.
12955         * python/python-internal.h (gdbpy_allow_threads): New class.
12956
12957 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12958
12959         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12960         (aarch64_fbsd_fpregmap): Move earlier.
12961         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12962         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12963         instead of individual calls to trad_frame_set_reg_addr.
12964         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12965         earlier.
12966         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12967         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12968         instead of individual calls to trad_frame_set_reg_addr.
12969
12970 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12971
12972         * CONTRIBUTE: Replace contribution list with wiki link.
12973
12974 2019-01-25  Tom Tromey  <tom@tromey.com>
12975
12976         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12977
12978 2019-01-25  Tom Tromey  <tom@tromey.com>
12979
12980         * xtensa-linux-nat.c: Fix common/ includes.
12981         * xml-support.h: Fix common/ includes.
12982         * xml-support.c: Fix common/ includes.
12983         * x86-linux-nat.c: Fix common/ includes.
12984         * windows-nat.c: Fix common/ includes.
12985         * varobj.h: Fix common/ includes.
12986         * varobj.c: Fix common/ includes.
12987         * value.c: Fix common/ includes.
12988         * valops.c: Fix common/ includes.
12989         * utils.c: Fix common/ includes.
12990         * unittests/xml-utils-selftests.c: Fix common/ includes.
12991         * unittests/utils-selftests.c: Fix common/ includes.
12992         * unittests/unpack-selftests.c: Fix common/ includes.
12993         * unittests/tracepoint-selftests.c: Fix common/ includes.
12994         * unittests/style-selftests.c: Fix common/ includes.
12995         * unittests/string_view-selftests.c: Fix common/ includes.
12996         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12997         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12998         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12999         * unittests/rsp-low-selftests.c: Fix common/ includes.
13000         * unittests/parse-connection-spec-selftests.c: Fix common/
13001         includes.
13002         * unittests/optional-selftests.c: Fix common/ includes.
13003         * unittests/offset-type-selftests.c: Fix common/ includes.
13004         * unittests/observable-selftests.c: Fix common/ includes.
13005         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13006         * unittests/memrange-selftests.c: Fix common/ includes.
13007         * unittests/memory-map-selftests.c: Fix common/ includes.
13008         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13009         * unittests/function-view-selftests.c: Fix common/ includes.
13010         * unittests/environ-selftests.c: Fix common/ includes.
13011         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13012         * unittests/common-utils-selftests.c: Fix common/ includes.
13013         * unittests/cli-utils-selftests.c: Fix common/ includes.
13014         * unittests/array-view-selftests.c: Fix common/ includes.
13015         * ui-file.c: Fix common/ includes.
13016         * tui/tui-io.c: Fix common/ includes.
13017         * tracepoint.h: Fix common/ includes.
13018         * tracepoint.c: Fix common/ includes.
13019         * tracefile-tfile.c: Fix common/ includes.
13020         * top.h: Fix common/ includes.
13021         * top.c: Fix common/ includes.
13022         * thread.c: Fix common/ includes.
13023         * target/waitstatus.h: Fix common/ includes.
13024         * target/waitstatus.c: Fix common/ includes.
13025         * target.h: Fix common/ includes.
13026         * target.c: Fix common/ includes.
13027         * target-memory.c: Fix common/ includes.
13028         * target-descriptions.c: Fix common/ includes.
13029         * symtab.h: Fix common/ includes.
13030         * symfile.c: Fix common/ includes.
13031         * stap-probe.c: Fix common/ includes.
13032         * spu-linux-nat.c: Fix common/ includes.
13033         * sparc-nat.c: Fix common/ includes.
13034         * source.c: Fix common/ includes.
13035         * solib.c: Fix common/ includes.
13036         * solib-target.c: Fix common/ includes.
13037         * ser-unix.c: Fix common/ includes.
13038         * ser-tcp.c: Fix common/ includes.
13039         * ser-pipe.c: Fix common/ includes.
13040         * ser-base.c: Fix common/ includes.
13041         * selftest-arch.c: Fix common/ includes.
13042         * s12z-tdep.c: Fix common/ includes.
13043         * rust-exp.y: Fix common/ includes.
13044         * rs6000-aix-tdep.c: Fix common/ includes.
13045         * riscv-tdep.c: Fix common/ includes.
13046         * remote.c: Fix common/ includes.
13047         * remote-notif.h: Fix common/ includes.
13048         * remote-fileio.h: Fix common/ includes.
13049         * remote-fileio.c: Fix common/ includes.
13050         * regcache.h: Fix common/ includes.
13051         * regcache.c: Fix common/ includes.
13052         * record-btrace.c: Fix common/ includes.
13053         * python/python.c: Fix common/ includes.
13054         * python/py-type.c: Fix common/ includes.
13055         * python/py-inferior.c: Fix common/ includes.
13056         * progspace.h: Fix common/ includes.
13057         * producer.c: Fix common/ includes.
13058         * procfs.c: Fix common/ includes.
13059         * proc-api.c: Fix common/ includes.
13060         * printcmd.c: Fix common/ includes.
13061         * ppc-linux-nat.c: Fix common/ includes.
13062         * parser-defs.h: Fix common/ includes.
13063         * osdata.c: Fix common/ includes.
13064         * obsd-nat.c: Fix common/ includes.
13065         * nat/x86-linux.c: Fix common/ includes.
13066         * nat/x86-linux-dregs.c: Fix common/ includes.
13067         * nat/x86-dregs.h: Fix common/ includes.
13068         * nat/x86-dregs.c: Fix common/ includes.
13069         * nat/ppc-linux.c: Fix common/ includes.
13070         * nat/mips-linux-watch.h: Fix common/ includes.
13071         * nat/mips-linux-watch.c: Fix common/ includes.
13072         * nat/linux-waitpid.c: Fix common/ includes.
13073         * nat/linux-ptrace.h: Fix common/ includes.
13074         * nat/linux-ptrace.c: Fix common/ includes.
13075         * nat/linux-procfs.c: Fix common/ includes.
13076         * nat/linux-personality.c: Fix common/ includes.
13077         * nat/linux-osdata.c: Fix common/ includes.
13078         * nat/linux-namespaces.c: Fix common/ includes.
13079         * nat/linux-btrace.h: Fix common/ includes.
13080         * nat/linux-btrace.c: Fix common/ includes.
13081         * nat/fork-inferior.c: Fix common/ includes.
13082         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13083         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13084         * nat/aarch64-linux.c: Fix common/ includes.
13085         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13086         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13087         * namespace.h: Fix common/ includes.
13088         * mips-linux-tdep.c: Fix common/ includes.
13089         * minsyms.c: Fix common/ includes.
13090         * mi/mi-parse.h: Fix common/ includes.
13091         * mi/mi-main.c: Fix common/ includes.
13092         * mi/mi-cmd-env.c: Fix common/ includes.
13093         * memrange.h: Fix common/ includes.
13094         * memattr.c: Fix common/ includes.
13095         * maint.h: Fix common/ includes.
13096         * maint.c: Fix common/ includes.
13097         * main.c: Fix common/ includes.
13098         * machoread.c: Fix common/ includes.
13099         * location.c: Fix common/ includes.
13100         * linux-thread-db.c: Fix common/ includes.
13101         * linux-nat.c: Fix common/ includes.
13102         * linux-fork.c: Fix common/ includes.
13103         * inline-frame.c: Fix common/ includes.
13104         * infrun.c: Fix common/ includes.
13105         * inflow.c: Fix common/ includes.
13106         * inferior.h: Fix common/ includes.
13107         * inferior.c: Fix common/ includes.
13108         * infcmd.c: Fix common/ includes.
13109         * inf-ptrace.c: Fix common/ includes.
13110         * inf-child.c: Fix common/ includes.
13111         * ia64-linux-nat.c: Fix common/ includes.
13112         * i387-tdep.c: Fix common/ includes.
13113         * i386-tdep.c: Fix common/ includes.
13114         * i386-linux-tdep.c: Fix common/ includes.
13115         * i386-linux-nat.c: Fix common/ includes.
13116         * i386-go32-tdep.c: Fix common/ includes.
13117         * i386-fbsd-tdep.c: Fix common/ includes.
13118         * i386-fbsd-nat.c: Fix common/ includes.
13119         * guile/scm-type.c: Fix common/ includes.
13120         * guile/guile.c: Fix common/ includes.
13121         * go32-nat.c: Fix common/ includes.
13122         * gnu-nat.c: Fix common/ includes.
13123         * gdbthread.h: Fix common/ includes.
13124         * gdbarch-selftests.c: Fix common/ includes.
13125         * gdb_usleep.c: Fix common/ includes.
13126         * gdb_select.h: Fix common/ includes.
13127         * gdb_bfd.c: Fix common/ includes.
13128         * gcore.c: Fix common/ includes.
13129         * fork-child.c: Fix common/ includes.
13130         * findvar.c: Fix common/ includes.
13131         * fbsd-nat.c: Fix common/ includes.
13132         * event-top.c: Fix common/ includes.
13133         * event-loop.c: Fix common/ includes.
13134         * dwarf2read.c: Fix common/ includes.
13135         * dwarf2loc.c: Fix common/ includes.
13136         * dwarf2-frame.c: Fix common/ includes.
13137         * dwarf-index-cache.c: Fix common/ includes.
13138         * dtrace-probe.c: Fix common/ includes.
13139         * disasm-selftests.c: Fix common/ includes.
13140         * defs.h: Fix common/ includes.
13141         * csky-tdep.c: Fix common/ includes.
13142         * cp-valprint.c: Fix common/ includes.
13143         * cp-support.h: Fix common/ includes.
13144         * cp-support.c: Fix common/ includes.
13145         * corelow.c: Fix common/ includes.
13146         * completer.h: Fix common/ includes.
13147         * completer.c: Fix common/ includes.
13148         * compile/compile.c: Fix common/ includes.
13149         * compile/compile-loc2c.c: Fix common/ includes.
13150         * compile/compile-cplus-types.c: Fix common/ includes.
13151         * compile/compile-cplus-symbols.c: Fix common/ includes.
13152         * command.h: Fix common/ includes.
13153         * cli/cli-dump.c: Fix common/ includes.
13154         * cli/cli-cmds.c: Fix common/ includes.
13155         * charset.c: Fix common/ includes.
13156         * build-id.c: Fix common/ includes.
13157         * btrace.h: Fix common/ includes.
13158         * btrace.c: Fix common/ includes.
13159         * breakpoint.h: Fix common/ includes.
13160         * breakpoint.c: Fix common/ includes.
13161         * ax.h:
13162         (enum agent_op): Fix common/ includes.
13163         * ax-general.c (struct aop_map): Fix common/ includes.
13164         * ax-gdb.c: Fix common/ includes.
13165         * auxv.c: Fix common/ includes.
13166         * auto-load.c: Fix common/ includes.
13167         * arm-tdep.c: Fix common/ includes.
13168         * arch/riscv.c: Fix common/ includes.
13169         * arch/ppc-linux-common.c: Fix common/ includes.
13170         * arch/i386.c: Fix common/ includes.
13171         * arch/arm.c: Fix common/ includes.
13172         * arch/arm-linux.c: Fix common/ includes.
13173         * arch/arm-get-next-pcs.c: Fix common/ includes.
13174         * arch/amd64.c: Fix common/ includes.
13175         * arch/aarch64.c: Fix common/ includes.
13176         * arch/aarch64-insn.c: Fix common/ includes.
13177         * arch-utils.c: Fix common/ includes.
13178         * amd64-windows-tdep.c: Fix common/ includes.
13179         * amd64-tdep.c: Fix common/ includes.
13180         * amd64-sol2-tdep.c: Fix common/ includes.
13181         * amd64-obsd-tdep.c: Fix common/ includes.
13182         * amd64-nbsd-tdep.c: Fix common/ includes.
13183         * amd64-linux-tdep.c: Fix common/ includes.
13184         * amd64-linux-nat.c: Fix common/ includes.
13185         * amd64-fbsd-tdep.c: Fix common/ includes.
13186         * amd64-fbsd-nat.c: Fix common/ includes.
13187         * amd64-dicos-tdep.c: Fix common/ includes.
13188         * amd64-darwin-tdep.c: Fix common/ includes.
13189         * agent.c: Fix common/ includes.
13190         * ada-lang.h: Fix common/ includes.
13191         * ada-lang.c: Fix common/ includes.
13192         * aarch64-tdep.c: Fix common/ includes.
13193
13194 2019-01-25  Tom Tromey  <tom@tromey.com>
13195
13196         * common/create-version.sh: Use common/version.h.
13197
13198 2019-01-24  Pedro Alves  <palves@redhat.com>
13199
13200         * infrun.c (signal_stop, signal_print, signal_program)
13201         (signal_catch, signal_pass): Now arrays instead of pointers.
13202         (update_signals_program_target, do_target_resume)
13203         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13204         * linux-nat.c (linux_nat_target::pass_signals)
13205         (linux_nat_target::create_inferior, linux_nat_target::attach):
13206         Adjust.
13207         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13208         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13209         * procfs.c (procfs_target::pass_signals): Adjust.
13210         * record-full.c (record_full_target::resume): Adjust.
13211         * remote.c (remote_target::pass_signals)
13212         (remote_target::program_signals): Adjust.
13213         * target-debug.h (target_debug_print_signals): Now takes a
13214         gdb::array_view as parameter.  Adjust.
13215         * target.h (target_ops) <pass_signals, program_signals>: Replace
13216         pointer and length parameters with gdb::array_view.
13217         (target_pass_signals, target_program_signals): Likewise.
13218         * target-delegates.c: Regenerate.
13219
13220 2019-01-24  Pedro Alves  <palves@redhat.com>
13221
13222         * common/forward-scope-exit.h
13223         (forward_scope_exit::forward_scope_exit): Pass arguments to
13224         m_bind_function directly, instead of creating a std::bind and
13225         copying that.
13226
13227 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13228
13229         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13230         for static members.
13231         (pass_in_v_vfp_candidate): Likewise.
13232
13233 2019-01-23  Tom Tromey  <tom@tromey.com>
13234             Pedro Alves  <palves@redhat.com>
13235
13236         * regcache.c (class regcache_invalidator): Remove.
13237         (regcache::raw_write): Use make_scope_exit.
13238
13239 2019-01-23  Tom Tromey  <tom@tromey.com>
13240
13241         * ui-out.h (class ui_out_emit_type): Update comment.
13242
13243 2019-01-23  Tom Tromey  <tom@tromey.com>
13244
13245         * infrun.c (fetch_inferior_event): Update comment.
13246
13247 2019-01-23  Tom Tromey  <tom@tromey.com>
13248             Pedro Alves  <palves@redhat.com>
13249
13250         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13251         parameter.
13252         (fetch_inferior_event): Use SCOPE_EXIT.
13253
13254
13255 2019-01-23  Tom Tromey  <tom@tromey.com>
13256             Pedro Alves  <palves@redhat.com>
13257
13258         * infrun.c (disable_thread_events): Delete.
13259         (stop_all_threads): Use SCOPE_EXIT.
13260
13261 2019-01-23  Tom Tromey  <tom@tromey.com>
13262             Pedro Alves  <palves@redhat.com>
13263
13264         * symfile.c: Include forward-scope-exit.h.
13265         (clear_symtab_users_cleanup): Replace forward declaration with
13266         a FORWARD_SCOPE_EXIT.
13267         (syms_from_objfile_1): Use the forward_scope_exit and
13268         gdb::optional instead of cleanup_function.
13269         (reread_symbols): Use the forward_scope_exit instead of
13270         cleanup_function.
13271         (clear_symtab_users_cleanup): Remove function.
13272
13273 2019-01-23  Tom Tromey  <tom@tromey.com>
13274             Pedro Alves  <palves@redhat.com>
13275
13276         * linux-nat.c: Include scope-exit.h.
13277         (cleanup_target_stop): Remove.
13278         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13279         SCOPE_EXIT.
13280
13281 2019-01-23  Tom Tromey  <tom@tromey.com>
13282             Pedro Alves  <palves@redhat.com>
13283
13284         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13285         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13286
13287 2019-01-23  Tom Tromey  <tom@tromey.com>
13288             Andrew Burgess  <andrew.burgess@embecosm.com>
13289             Pedro Alves  <palves@redhat.com>
13290
13291         * infrun.c (fetch_inferior_event): Use scope_exit.
13292         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13293         * top.c (execute_command): Use scope_exit.
13294         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13295         * utils.c (do_bpstat_clear_actions_cleanup)
13296         (make_bpstat_clear_actions_cleanup): Remove.
13297
13298 2019-01-23  Tom Tromey  <tom@tromey.com>
13299             Pedro Alves  <palves@redhat.com>
13300
13301         * infrun.c: Include "common/scope-exit.h"
13302         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13303         (wait_for_inferior): Use SCOPE_EXIT.
13304         (fetch_inferior_event): Use scope_exit.
13305
13306 2019-01-23  Tom Tromey  <tom@tromey.com>
13307             Pedro Alves  <palves@redhat.com>
13308
13309         * breakpoint.c (create_breakpoint): Remove cleanup.
13310
13311 2019-01-23  Tom Tromey  <tom@tromey.com>
13312             Andrew Burgess  <andrew.burgess@embecosm.com>
13313             Pedro Alves  <palves@redhat.com>
13314
13315 2019-01-23  Pedro Alves  <palves@redhat.com>
13316
13317         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13318
13319 2019-01-23  Pedro Alves  <palves@redhat.com>
13320             Andrew Burgess  <andrew.burgess@embecosm.com>
13321
13322         * gdbthread.h: Include "common/forward-scope-exit.h".
13323         (scoped_finish_thread_state): Redefine custom class in terms of
13324         forward_scope_exit.
13325
13326 2019-01-23  Pedro Alves  <palves@redhat.com>
13327             Andrew Burgess  <andrew.burgess@embecosm.com>
13328
13329         * common/forward-scope-exit.h: New file.
13330
13331 2019-01-23  Pedro Alves  <palves@redhat.com>
13332             Andrew Burgess  <andrew.burgess@embecosm.com>
13333             Tom Tromey  <tom@tromey.com>
13334
13335         * common/scope-exit.h: New file.
13336
13337 2019-01-23  Pedro Alves  <palves@redhat.com>
13338
13339         * common/preprocessor.h (ESC): Rename to ...
13340         (ESC_PARENS): ... this.
13341         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13342         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13343
13344 2019-01-23  Tom Tromey  <tom@tromey.com>
13345
13346         * language.h (class scoped_switch_to_sym_language_if_auto):
13347         Initialize m_lang in both cases.
13348
13349 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13350
13351         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13352         with XCNEW.
13353
13354 2019-01-22  Tom Tromey  <tom@tromey.com>
13355
13356         * corelow.c: Do not include sys/file.h.
13357
13358 2019-01-22  Tom Tromey  <tom@tromey.com>
13359
13360         * tui/tui-wingeneral.h: Include gdb_curses.h.
13361
13362 2019-01-22  Tom Tromey  <tom@tromey.com>
13363
13364         * source-cache.h (class source_cache) <get_source_lines,
13365         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13366
13367 2019-01-22  Tom Tromey  <tom@tromey.com>
13368
13369         * remote-fileio.h (struct remote_target): Declare.
13370
13371 2019-01-22  Tom Tromey  <tom@tromey.com>
13372
13373         * python/py-arch.c: Do not include py-ref.h.
13374         * python/py-bpevent.c: Do not include py-ref.h.
13375         * python/py-cmd.c: Do not include py-ref.h.
13376         * python/py-continueevent.c: Do not include py-ref.h.
13377         * python/py-event.h: Do not include py-ref.h.
13378         * python/py-evtregistry.c: Do not include py-ref.h.
13379         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13380         * python/py-frame.c: Do not include py-ref.h.
13381         * python/py-framefilter.c: Do not include py-ref.h.
13382         * python/py-function.c: Do not include py-ref.h.
13383         * python/py-infevents.c: Do not include py-ref.h.
13384         * python/py-linetable.c: Do not include py-ref.h.
13385         * python/py-objfile.c: Do not include py-ref.h.
13386         * python/py-param.c: Do not include py-ref.h.
13387         * python/py-prettyprint.c: Do not include py-ref.h.
13388         * python/py-progspace.c: Do not include py-ref.h.
13389         * python/py-symbol.c: Do not include py-ref.h.
13390         * python/py-symtab.c: Do not include py-ref.h.
13391         * python/py-type.c: Do not include py-ref.h.
13392         * python/py-unwind.c: Do not include py-ref.h.
13393         * python/py-utils.c: Do not include py-ref.h.
13394         * python/py-value.c: Do not include py-ref.h.
13395         * python/py-varobj.c: Do not include py-ref.h.
13396         * python/py-xmethods.c: Do not include py-ref.h.
13397         * python/python.c: Do not include py-ref.h.
13398         * varobj.c: Do not include py-ref.h.
13399
13400 2019-01-22  Tom Tromey  <tom@tromey.com>
13401
13402         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13403         keyword for bcache.
13404
13405 2019-01-22  Tom Tromey  <tom@tromey.com>
13406
13407         * compile/compile-cplus-types.c: Remove a comment by #include.
13408
13409 2019-01-22  Tom Tromey  <tom@tromey.com>
13410
13411         * compile/gcc-c-plugin.h: Include compile-internal.h.
13412
13413 2019-01-22  Tom Tromey  <tom@tromey.com>
13414
13415         * stabsread.c (EXTERN): Do not define.
13416         (symnum, next_symbol_text_func, processing_gcc_compilation)
13417         (within_function, global_sym_chain, global_stabs)
13418         (previous_stab_code, this_object_header_files)
13419         (n_this_object_header_files)
13420         (n_allocated_this_object_header_files): Define.
13421         * stabsread.h (EXTERN): Never define.  Use "extern".
13422
13423 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13424
13425         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13426         history_value.
13427
13428 2019-01-21  Tom Tromey  <tom@tromey.com>
13429
13430         * ui-out.c: Fix includes.
13431         * tui/tui-source.c: Fix includes.
13432         * target.c: Fix includes.
13433         * remote.c: Fix includes.
13434         * regcache.c: Fix includes.
13435         * python/py-block.c: Fix includes.
13436         * printcmd.c: Fix includes.
13437         * or1k-tdep.c: Fix includes.
13438         * mi/mi-main.c: Fix includes.
13439         * m32r-tdep.c: Fix includes.
13440         * csky-tdep.c: Fix includes.
13441         * compile/compile-cplus-types.c: Fix includes.
13442         * cli/cli-interp.c: Fix includes.
13443
13444 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13445
13446         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13447         for padding.
13448
13449 2019-01-16  Tom Tromey  <tom@tromey.com>
13450
13451         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13452         earlier.
13453         (struct objfile) <msymbols_range>: Move from top level.
13454         <msymbols>: New method.
13455         (class objfile_msymbols): Remove.
13456         * symtab.c (default_collect_symbol_completion_matches_break_on):
13457         Update.
13458         * symmisc.c (dump_msymbols): Update.
13459         * stabsread.c (scan_file_globals): Update.
13460         * objc-lang.c (info_selectors_command, info_classes_command)
13461         (find_methods): Update.
13462         * minsyms.c (find_solib_trampoline_target): Update.
13463         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13464         * coffread.c (coff_symfile_read): Update.
13465         * ada-lang.c (ada_lookup_simple_minsym)
13466         (ada_collect_symbol_completion_matches): Update.
13467
13468 2019-01-16  Tom Tromey  <tom@tromey.com>
13469
13470         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13471         type.  Remove no-argument constructor.
13472         <iterator::operator++>: Simplify.
13473         <begin>: Update.
13474         <end>: Use minimal_symbol_count.
13475
13476 2019-01-16  Tom Tromey  <tom@tromey.com>
13477
13478         * objfiles.h (struct objfile) <psymtabs>: New method.
13479         (class objfile_psymtabs): Remove.
13480         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13481         typedef.
13482         <range>: New method.
13483         (require_partial_symbols): Change return type.
13484         * psymtab.c (require_partial_symbols)
13485         (psym_expand_symtabs_matching): Update.
13486         * mdebugread.c (parse_partial_symbols): Update.
13487         * dbxread.c (dbx_end_psymtab): Update.
13488
13489 2019-01-15  Tom Tromey  <tom@tromey.com>
13490
13491         * symtab.c (lookup_objfile_from_block)
13492         (lookup_symbol_in_objfile_symtabs)
13493         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13494         (find_line_symtab, info_sources_command)
13495         (default_collect_symbol_completion_matches_break_on)
13496         (make_source_files_completion_list): Update.
13497         * symmisc.c (print_objfile_statistics, dump_objfile)
13498         (maintenance_print_symbols, maintenance_info_symtabs)
13499         (maintenance_check_symtabs, maintenance_info_line_tables):
13500         Update.
13501         * source.c (select_source_symtab)
13502         (forget_cached_source_info_for_objfile): Update.
13503         * objfiles.h (class objfile_compunits): Remove.
13504         (struct objfile) <compunits_range>: New typedef.
13505         (compunits): New method.
13506         * objfiles.c (objfile_relocate1): Update.
13507         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13508         * maint.c (count_symtabs_and_blocks): Update.
13509         * linespec.c (iterate_over_all_matching_symtabs): Update.
13510         * cp-support.c (add_symbol_overload_list_qualified): Update.
13511         * coffread.c (coff_symtab_read): Update.
13512         * ada-lang.c (add_nonlocal_symbols)
13513         (ada_collect_symbol_completion_matches)
13514         (ada_add_global_exceptions): Update.
13515
13516 2019-01-15  Tom Tromey  <tom@tromey.com>
13517
13518         * progspace.h (program_space) <objfiles_safe_range>: New
13519         typedef.
13520         <objfiles_safe>: New method.
13521         * objfiles.h (class all_objfiles_safe): Remove.
13522         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13523         * jit.c (jit_inferior_exit_hook): Update.
13524
13525 2019-01-17  Tom Tromey  <tom@tromey.com>
13526
13527         * progspace.h (program_space) <objfiles_range>: New typedef.
13528         <objfiles>: New method.
13529         <objfiles_head>: Rename from objfiles.
13530         (object_files): Update.
13531         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13532         * guile/scm-pretty-print.c
13533         (ppscm_find_pretty_printer_from_objfiles): Update.
13534         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13535         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13536         Update.
13537         * python/py-progspace.c (pspy_get_objfiles): Update.
13538         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13539         Update.
13540         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13541         (objfpy_lookup_objfile_by_build_id): Update.
13542         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13543         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13544         Update.
13545         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13546         (expand_symtab_containing_pc, lookup_objfile_from_block)
13547         (lookup_static_symbol, basic_lookup_transparent_type)
13548         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13549         (find_line_symtab, info_sources_command)
13550         (default_collect_symbol_completion_matches_break_on)
13551         (make_source_files_completion_list, find_main_name): Update.
13552         * symmisc.c (print_symbol_bcache_statistics)
13553         (print_objfile_statistics, maintenance_print_symbols)
13554         (maintenance_print_msymbols, maintenance_print_objfiles)
13555         (maintenance_info_symtabs, maintenance_check_symtabs)
13556         (maintenance_expand_symtabs, maintenance_info_line_tables):
13557         Update.
13558         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13559         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13560         (map_overlay_command, unmap_overlay_command)
13561         (simple_overlay_update, expand_symtabs_matching)
13562         (map_symbol_filenames): Update.
13563         * symfile-debug.c (set_debug_symfile): Update.
13564         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13565         Update.
13566         * source.c (select_source_symtab, forget_cached_source_info):
13567         Update.
13568         * solib.c (solib_read_symbols): Update.
13569         * solib-spu.c (append_ocl_sos): Update.
13570         * psymtab.c (maintenance_print_psymbols)
13571         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13572         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13573         * printcmd.c (info_symbol_command): Update.
13574         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13575         Update.
13576         * objfiles.h (class all_objfiles): Remove.
13577         * objfiles.c (have_partial_symbols, have_full_symbols)
13578         (have_minimal_symbols, qsort_cmp, update_section_map)
13579         (shared_objfile_contains_address_p)
13580         (default_iterate_over_objfiles_in_search_order): Update.
13581         * objc-lang.c (info_selectors_command, info_classes_command)
13582         (find_methods): Update.
13583         * minsyms.c (find_solib_trampoline_target): Update.
13584         * maint.c (maintenance_info_sections)
13585         (maintenance_translate_address, count_symtabs_and_blocks):
13586         Update.
13587         * main.c (captured_main_1): Update.
13588         * linux-thread-db.c (try_thread_db_load_from_pdir)
13589         (has_libpthread): Update.
13590         * linespec.c (iterate_over_all_matching_symtabs)
13591         (search_minsyms_for_name): Update.
13592         * jit.c (jit_find_objf_with_entry_addr): Update.
13593         * hppa-tdep.c (find_unwind_entry)
13594         (hppa_lookup_stub_minimal_symbol): Update.
13595         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13596         Update.
13597         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13598         (elf_gnu_ifunc_resolve_by_got): Update.
13599         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13600         * dwarf-index-write.c (save_gdb_index_command): Update.
13601         * cp-support.c (add_symbol_overload_list_qualified): Update.
13602         * breakpoint.c (create_overlay_event_breakpoint)
13603         (create_longjmp_master_breakpoint)
13604         (create_std_terminate_master_breakpoint)
13605         (create_exception_master_breakpoint): Update.
13606         * blockframe.c (find_pc_partial_function): Update.
13607         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13608         (ada_collect_symbol_completion_matches)
13609         (ada_add_global_exceptions): Update.
13610
13611 2019-01-17  Tom Tromey  <tom@tromey.com>
13612
13613         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13614         declare VEC.
13615         (solib_target_parse_libraries): Change return type.
13616         (library_list_start_segment, library_list_start_section)
13617         (library_list_end_library, library_list_start_library); Update.
13618         (solib_target_free_library_list): Remove.
13619         (solib_target_parse_libraries): Remove cleanup.  Change return
13620         type.
13621         (solib_target_current_sos): Update.
13622
13623 2019-01-17  Tom Tromey  <tromey@bapiya>
13624
13625         * valprint.c: Replace "the the" with "the".
13626         * symtab.c: Replace "the the" with "the".
13627         * solib.c: Replace "the the" with "the".
13628         * solib-dsbt.c: Replace "the the" with "the".
13629         * linespec.c: Replace "the the" with "the".
13630         * dwarf2loc.h: Replace "the the" with "the".
13631         * amd64-windows-tdep.c: Replace "the the" with "the".
13632         * aarch64-tdep.c: Replace "the the" with "the".
13633
13634 2019-01-16  Keith Seitz  <keiths@redhat.com>
13635
13636         PR gdb/23773
13637         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13638         <builder>: Rename to ..
13639         <m_builder>: ... this and make private.
13640         (dwarf2_cu::get_builder): New method.  Change all users of
13641         `builder' to use this method.
13642         (dwarf2_start_symtab): Move to ...
13643         (dwarf2_cu::start_symtab): ... here.  Update all callers
13644         (setup_type_unit_groups): Move to ...
13645         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13646         callers.
13647         (dwarf2_cu::reset_builder): New method.
13648         (process_full_compunit, process_full_type_unit): Use
13649         dwarf2_cu::reset_builder.
13650         (follow_die_offset): Record the ancestor CU if it is different
13651         from the followed DIE's CU.
13652         (follow_die_sig_1): Likewise.
13653
13654 2019-01-15  Tom Tromey  <tom@tromey.com>
13655
13656         * remote.c (class remote_state) <buf>: Now a char_vector.
13657         <buf_size>: Remove.
13658         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13659         parameter.
13660         (remote_target::getpkt_or_notif_sane_1)
13661         (remote_target::getpkt_sane)
13662         (remote_target::getpkt_or_notif_sane): Likewise.
13663         (class remote_target) <putpkt>: New overload.
13664         (remote_target::read_frame): Change type of "buf_p".  Remove
13665         sizeof_p parameter.
13666         (packet_ok): New overload.
13667         (packet_check_result): New overload.
13668         Update all uses.
13669
13670 2019-01-14  Tom Tromey  <tom@tromey.com>
13671
13672         * remote-notif.c (handle_notification, remote_notif_ack)
13673         (remote_notif_parse): Make "buf" const.
13674         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13675         const.
13676         (remote_notif_parse, remote_notif_ack, handle_notification):
13677         Likewise.
13678         * remote.c (remote_notif_stop_parse): Make "buf" const.
13679         (remote_target::remote_parse_stop_reply): Make "buf" const.
13680         (remote_notif_stop_ack): Make "buf" const.
13681
13682 2019-01-14  Tom Tromey  <tom@tromey.com>
13683
13684         * remote.c (remote_console_output): Make parameter const.
13685
13686 2019-01-14  Tom Tromey  <tom@tromey.com>
13687
13688         * target-debug.h (target_debug_print_signals): Constify.
13689         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13690         * procfs.c (procfs_target::pass_signals): Update.
13691         * linux-nat.c (linux_nat_target::pass_signals): Update.
13692         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13693         * target-delegates.c: Rebuild.
13694         * remote.c (remote_target::program_signals): Update.
13695         (remote_target::pass_signals): Update.
13696         * target.c (target_pass_signals): Constify argument.
13697         (target_program_signals): Likewise.
13698         * target.h (struct target_ops) <pass_signals, program_signals>:
13699         Constify argument.
13700         (target_pass_signals, target_program_signals): Constify argument.
13701
13702 2019-01-14  Tom Tromey  <tom@tromey.com>
13703
13704         PR tui/28819:
13705         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13706
13707 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13708
13709         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13710         field.
13711         * rs6000-tdep.c: Include reggroups.h.
13712         (IS_V_ALIAS_PSEUDOREG): Define.
13713         (rs6000_register_name): Return names for the "vX" aliases.
13714         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13715         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13716         aliases.  Call default_register_reggroup_p for all other
13717         pseudo-registers.
13718         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13719         New functions.
13720         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13721         Handle "vX" aliases.
13722         (v_alias_pseudo_register_collect): New function.
13723         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13724         (rs6000_gdbarch_init): Initialize "vX" aliases as
13725         pseudo-registers.  Restore registration of
13726         rs6000_pseudo_register_reggroup_p with
13727         set_tdesc_pseudo_register_reggroup_p.
13728
13729 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13730
13731         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13732         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13733         set_gdbarch_num_pseudo_regs.
13734
13735 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13736
13737         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13738         Remove arg prefixname, add do_set and do_show.
13739         Add member functions set_list and show_list.
13740         * cli/cli-style.c (class cli_style_option): Update accordingly.
13741         (style_set_list): Move to file scope.
13742         (style_show_list): Likewise.
13743         (set_style): Call help_list.
13744         (show_style): Call cmd_show_list.
13745         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13746         Update to use the new macro.
13747
13748 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13749
13750         * ada-lang.c (_initialize_ada_language): Expand the help text
13751         for the "catch exception" command.
13752
13753 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13754
13755         * symtab.c (matching_obj_sections): Initialize obj,
13756         declare it closer to its usage.
13757
13758 2019-01-10  Tom Tromey  <tom@tromey.com>
13759
13760         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13761         (basic_inf_threads_range): Remove.
13762         (inf_threads_range, inf_non_exited_threads_range)
13763         (safe_inf_threads_range): Use next_adapter.
13764
13765 2019-01-10  Keith Seitz  <keiths@redhat.com>
13766
13767         PR gdb/23712
13768         PR symtab/23010
13769         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13770         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13771
13772 2019-01-10  Keith Seitz  <keiths@redhat.com>
13773
13774         PR gdb/23712
13775         PR symtab/23010
13776         * dictionary.c (pending_to_vector): Remove.
13777         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13778         Remove _1 suffix, replacing functions of the same name.  Update
13779         all callers.
13780         (dict_create_hashed, dict_create_hashed_expandable)
13781         (dict_create_linear, dict_create_linear_expandable, dict_free)
13782         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13783         Make functions static.
13784
13785 2019-01-10  Keith Seitz  <keiths@redhat.com>
13786
13787         PR gdb/23712
13788         PR symtab/23010
13789         * dictionary.h (struct dictionary): Replace declaration with
13790         multidictionary.
13791         (dict_create_hashed, dict_create_hashed_expandable)
13792         (dict_create_linear, dict_create_linear_expandable)
13793         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13794         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13795         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13796         taking multidictionary argument.
13797         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13798         * block.h (struct block) <dict>: Change to multidictionary
13799         and rename `multidict'.
13800         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13801         symmisc.c: Update all dictionary references to multidictionary.
13802
13803 2019-01-10  Keith Seitz  <keiths@redhat.com>
13804
13805         PR gdb/23712
13806         PR symtab/23010
13807         * dictionary.c: Include unordered_map.
13808         (pending_to_vector): New function.
13809         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13810         Rewrite the non-"_1" functions to take vector instead
13811         of linked list.
13812         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13813         "new" _1 versions of the same name.
13814         (multidictionary): Define.
13815         (std::hash<enum language): New definition.
13816         (collate_pending_symbols_by_language, mdict_create_hashed)
13817         (mdict_create_hashed_expandable, mdict_create_linear)
13818         (mdict_create_linear_expandable, mdict_free)
13819         (find_language_dictionary, create_new_language_dictionary)
13820         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13821         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13822         (mdict_size, mdict_empty): New functions.
13823         * dictionary.h (mdict_iterator): Define.
13824
13825 2019-01-10  Pedro Alves  <palves@redhat.com>
13826
13827         * breakpoint.c (read_uploaded_action)
13828         (create_tracepoint_from_upload): Adjust to use
13829         gdb::unique_xmalloc_ptr.
13830         * ctf.c (ctf_write_uploaded_tp):
13831         (SET_ARRAY_FIELD): Use emplace_back.
13832         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13833         * tracefile-tfile.c (tfile_write_uploaded_tp):
13834         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13835         gdb::unique_xmalloc_ptr.
13836         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13837         at_string, cond_string, cmd_strings>: Replace char pointers
13838         with gdb::unique_xmalloc_ptr.
13839
13840 2019-01-10  Pedro Alves  <palves@redhat.com>
13841
13842         * solib-target.c (library_list_start_library): Don't xstrdup name.
13843
13844 2019-01-10  Pedro Alves  <palves@redhat.com>
13845
13846         * mdebugread.c (parse_partial_symbols): Use
13847         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13848
13849 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13850
13851         * linux-fork.c (scoped_switch_fork_info)
13852         <~scoped_switch_fork_info>: Fix incorrect variable name.
13853
13854 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13855
13856         * linux-fork.c (scoped_switch_fork_info)
13857         <scoped_switch_fork_info>: Make explicit.
13858         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13859
13860 2019-01-10  Tom Tromey  <tom@tromey.com>
13861
13862         * objfiles.h (objfile::reset_psymtabs): Update.
13863         * objfiles.c (objfile::objfile): Update.
13864         * psymtab.h (psymtab_storage::obstack): Update.
13865         (psymtab_storage::m_obstack): Use gdb::optional.
13866         (class psymtab_storage): Update comment.  Remove objfile
13867         parameter.
13868         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13869
13870 2019-01-10  Tom Tromey  <tom@tromey.com>
13871
13872         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13873         <free_psymtabs>: Now private.
13874         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13875         (allocate_psymtab): Use new method.
13876
13877 2019-01-10  Tom Tromey  <tom@tromey.com>
13878
13879         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13880         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13881         * mdebugread.c (parse_partial_symbols): Use
13882         allocate_dependencies.
13883         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13884         allocate_dependencies.
13885         (process_psymtab_comp_unit_reader)
13886         (build_type_psymtab_dependencies): Likewise.
13887         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13888
13889 2019-01-10  Tom Tromey  <tom@tromey.com>
13890
13891         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13892         PSYMBOL_SET_LANGUAGE.
13893         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13894
13895 2019-01-10  Tom Tromey  <tom@tromey.com>
13896
13897         * psymtab.h (psymtab_storage::obstack): New method.
13898         <m_obstack>: Rename from obstack; now private.
13899         * psymtab.c (psymtab_storage): Update.
13900         * dwarf2read.c (create_addrmap_from_index)
13901         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13902         Update.
13903
13904 2019-01-10  Tom Tromey  <tom@tromey.com>
13905
13906         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13907         * objfiles.h (objfile::reset_psymtabs): New method.
13908
13909 2019-01-10  Tom Tromey  <tom@tromey.com>
13910
13911         * symmisc.c (print_symbol_bcache_statistics): Update.
13912         (print_objfile_statistics): Update.
13913         * symfile.c (reread_symbols): Update.
13914         * psymtab.h (class psymtab_storage): New.
13915         * psymtab.c (psymtab_storage): New constructor.
13916         (~psymtab_storage): New destructor.
13917         (require_partial_symbols): Update.
13918         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13919         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13920         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13921         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13922         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13923         (start_psymtab_common, end_psymtab_common)
13924         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13925         (allocate_psymtab): Update.
13926         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13927         Update.
13928         (dump_psymtab_addrmap, maintenance_print_psymbols)
13929         (maintenance_check_psymtabs): Update.
13930         (class objfile_psymtabs): Move to objfiles.h.
13931         * psympriv.h (discard_psymtab): Now inline.
13932         (psymtab_discarder::psymtab_discarder): Update.
13933         (psymtab_discarder::~psymtab_discarder): Update.
13934         (ALL_OBJFILE_PSYMTABS): Rewrite.
13935         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13936         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13937         Remove fields.
13938         <partial_symtabs>: New field.
13939         (class objfile_psymtabs): Move from psymtab.h.  Update.
13940         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13941         psymbol_cache.
13942         (objfile::~objfile): Don't destroy psymbol_cache.
13943         * mdebugread.c (parse_partial_symbols): Update.
13944         * dwarf2read.c (create_addrmap_from_index)
13945         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13946         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13947         (add_partial_subprogram, dwarf2_ranges_read): Update.
13948         * dwarf-index-write.c (write_address_map)
13949         (write_one_signatured_type, recursively_write_psymbols)
13950         (class debug_names, class debug_names, write_psymtabs_to_index):
13951         Update.
13952
13953 2019-01-10  Tom Tromey  <tom@tromey.com>
13954
13955         * symtab.h (SYMBOL_SET_NAMES): Update.
13956         (symbol_set_names): Update.
13957         (MSYMBOL_SET_NAMES): Update.
13958         * symtab.c (symbol_set_names): Change argument to be an
13959         objfile_per_bfd_storage.
13960         * psymtab.c (add_psymbol_to_bcache): Update.
13961         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13962
13963 2019-01-10  Tom Tromey  <tom@tromey.com>
13964
13965         * symtab.c (create_demangled_names_hash): Change argument to be an
13966         objfile_per_bfd_storage.
13967         (symbol_set_names): Update.
13968
13969 2019-01-10  Tom Tromey  <tom@tromey.com>
13970
13971         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13972         init_psymbol_list.
13973         * psymtab.c (init_psymbol_list): Do nothing if already called.
13974         * psympriv.h (init_psymbol_list): Add comment.
13975         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13976         init_psymbol_list.
13977         * dbxread.c (dbx_symfile_read): Unconditionally call
13978         init_psymbol_list.
13979
13980 2019-01-10  Tom Tromey  <tom@tromey.com>
13981
13982         * xcoffread.c (scan_xcoff_symtab): Update.
13983         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13984         "where".
13985         * mdebugread.c (parse_partial_symbols)
13986         (handle_psymbol_enumerators): Update.
13987         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13988         * dbxread.c (read_dbx_symtab): Update.
13989         * psympriv.h (psymbol_placement): New enum.
13990         (add_psymbol_to_list): Update.
13991
13992 2019-01-10  Tom Tromey  <tom@tromey.com>
13993
13994         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13995         static_psymbols parameters.
13996         (scan_xcoff_symtab): Update.
13997         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13998         static_psymbols parameters.
13999         * psympriv.h (start_psymtab_common): Update.
14000         * mdebugread.c (parse_partial_symbols): Update.
14001         * dwarf2read.c (create_partial_symtab): Update.
14002         * dbxread.c (read_dbx_symtab): Update.
14003         (start_psymtab): Remove global_psymbols and static_psymbols
14004         parameters.
14005
14006 2019-01-10  Tom Tromey  <tom@tromey.com>
14007
14008         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14009         * psymtab.c (allocate_psymtab): Add comment.
14010         * psympriv.h (allocate_psymtab): Add comment.
14011         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14012         initializations.
14013         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14014
14015 2019-01-10  Tom Tromey  <tom@tromey.com>
14016
14017         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14018         Don't declare.
14019         * mipsread.c: Include mdebugread.h.
14020         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14021         Declare.
14022         * elfread.c: Include mdebugread.h.
14023
14024 2019-01-09  Tom Tromey  <tom@tromey.com>
14025
14026         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14027         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14028         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14029         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14030         (psym_lookup_symbol, psym_find_last_source_symtab)
14031         (psym_forget_cached_source_info, psym_print_stats)
14032         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14033         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14034         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14035         (psym_find_compunit_symtab_by_address)
14036         (maintenance_print_psymbols, maintenance_info_psymtabs)
14037         (maintenance_check_psymtabs): Use ranged for.
14038         * psymtab.h (class objfile_psymtabs): New.
14039         (require_partial_symbols): Return objfile_psymtabs.
14040         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14041
14042 2019-01-09  Tom Tromey  <tom@tromey.com>
14043
14044         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14045         (find_pc_mapped_section, list_overlays_command)
14046         (map_overlay_command, unmap_overlay_command)
14047         (simple_overlay_update): Use all_objfiles.
14048         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14049         * printcmd.c (info_symbol_command): Use all_objfiles.
14050         * objfiles.h (ALL_OBJSECTIONS): Remove.
14051         * maint.c (maintenance_translate_address): Use all_objfiles.
14052         * gcore.c (gcore_create_callback): Use all_objfiles.
14053         (objfile_find_memory_regions): Likewise.
14054
14055 2019-01-09  Tom Tromey  <tom@tromey.com>
14056
14057         * symtab.c (find_line_symtab, info_sources_command)
14058         (make_source_files_completion_list): Use objfile_compunits.
14059         * source.c (select_source_symtab): Use objfile_compunits.
14060         * objfiles.h (struct objfile): Update comment.
14061         (ALL_OBJFILES): Remove.
14062         (ALL_FILETABS): Remove.
14063         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14064         objfile_compunits.
14065
14066 2019-01-09  Tom Tromey  <tom@tromey.com>
14067
14068         * symmisc.c (print_objfile_statistics, dump_objfile)
14069         (maintenance_print_symbols): Use compunit_filetabs.
14070         * source.c (forget_cached_source_info_for_objfile): Use
14071         compunit_filetabs.
14072         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14073         (ALL_FILETABS): Use compunit_filetabs.
14074         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14075         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14076
14077 2019-01-09  Tom Tromey  <tom@tromey.com>
14078
14079         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14080         (compunit_filetabs): New.
14081         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14082         compunit_filetabs.
14083         (info_sources_command, make_source_files_completion_list): Remove
14084         declaration.
14085         * symmisc.c (print_objfile_statistics, dump_objfile)
14086         (maintenance_print_symbols): Remove declaration.
14087         (maintenance_info_symtabs): Use compunit_filetabs.
14088         (maintenance_info_line_tables): Likewise.
14089         * source.c (select_source_symtab): Change local variable name.
14090         (forget_cached_source_info_for_objfile): Remove declaration.
14091         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14092         * objfiles.c (objfile_relocate1): Remove declaration.
14093         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14094         declaration.
14095         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14096         * coffread.c (coff_symtab_read): Remove declaration.
14097         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14098         compunit_filetabs.
14099
14100 2019-01-09  Tom Tromey  <tom@tromey.com>
14101
14102         * symtab.c (lookup_objfile_from_block)
14103         (find_pc_sect_compunit_symtab, search_symbols)
14104         (default_collect_symbol_completion_matches_break_on): Use
14105         objfile_compunits.
14106         * objfiles.h (ALL_COMPUNITS): Remove.
14107         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14108         * cp-support.c (add_symbol_overload_list_qualified): Use
14109         objfile_compunits.
14110         * ada-lang.c (ada_collect_symbol_completion_matches)
14111         (ada_add_global_exceptions): Use objfile_compunits.
14112
14113 2019-01-09  Tom Tromey  <tom@tromey.com>
14114
14115         * source.c (select_source_symtab)
14116         (forget_cached_source_info_for_objfile): Remove declaration.
14117         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14118         declaration.
14119         * maint.c (count_symtabs_and_blocks): Remove declaration.
14120         * cp-support.c (add_symbol_overload_list_qualified): Remove
14121         declaration.
14122         * coffread.c (coff_symtab_read): Remove declaration.
14123         * symtab.c (lookup_symbol_in_objfile_symtabs)
14124         (basic_lookup_transparent_type_1): Use objfile_compunits.
14125         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14126         (info_sources_command, search_symbols)
14127         (default_collect_symbol_completion_matches_break_on)
14128         (make_source_files_completion_list): Remove declaration.
14129         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14130         (ada_collect_symbol_completion_matches)
14131         (ada_add_global_exceptions): Remove declaration.
14132         * linespec.c (iterate_over_all_matching_symtabs): Use
14133         objfile_compunits.
14134         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14135         (class objfile_compunits): New.
14136         (ALL_COMPUNITS): Use objfile_compunits.
14137         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14138         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14139         objfile_compunits.
14140         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14141
14142 2019-01-09  Tom Tromey  <tom@tromey.com>
14143
14144         * symtab.c (search_symbols)
14145         (default_collect_symbol_completion_matches_break_on): Use
14146         objfile_msymbols.
14147         * ada-lang.c (ada_lookup_simple_minsym)
14148         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14149         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14150         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14151         objfile_msymbols.
14152         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14153         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14154         * objc-lang.c (find_methods): Use objfile_msymbols.
14155         (info_selectors_command, info_classes_command): Likewise.
14156         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14157         * objfiles.h (class objfile_msymbols): New.
14158         (ALL_OBJFILE_MSYMBOLS): Remove.
14159         (ALL_MSYMBOLS): Remove.
14160
14161 2019-01-09  Tom Tromey  <tom@tromey.com>
14162
14163         * common/next-iterator.h (next_adapter): Add Iterator template
14164         parameter.
14165         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14166         (class all_objfiles_safe): New.
14167         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14168         * objfiles.c (put_objfile_before): Update comment.
14169         (add_separate_debug_objfile): Likewise.
14170         (free_all_objfiles): Use all_objfiles_safe.
14171         (objfile_purge_solibs): Likewise.
14172
14173 2019-01-09  Tom Tromey  <tom@tromey.com>
14174
14175         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14176         (expand_symtab_containing_pc, lookup_static_symbol)
14177         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14178         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14179         all_objfiles.
14180         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14181         * breakpoint.c (create_overlay_event_breakpoint)
14182         (create_longjmp_master_breakpoint)
14183         (create_std_terminate_master_breakpoint)
14184         (create_exception_master_breakpoint): Use all_objfiles.
14185         * linux-thread-db.c (try_thread_db_load_from_pdir)
14186         (has_libpthread): Use all_objfiles.
14187         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14188         * linespec.c (iterate_over_all_matching_symtabs)
14189         (search_minsyms_for_name): Use all_objfiles.
14190         * maint.c (maintenance_info_sections): Use all_objfiles.
14191         * main.c (captured_main_1): Use all_objfiles.
14192         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14193         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14194         * guile/scm-pretty-print.c
14195         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14196         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14197         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14198         (maintenance_print_msymbols): Use all_objfiles.
14199         * source.c (select_source_symtab): Use all_objfiles.
14200         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14201         * symfile.c (remove_symbol_file_command)
14202         (expand_symtabs_matching, map_symbol_filenames): Use
14203         all_objfiles.
14204         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14205         all_objfiles.
14206         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14207         * objc-lang.c (find_methods): Use all_objfiles.
14208         * objfiles.c (have_partial_symbols, have_full_symbols)
14209         (have_minimal_symbols, qsort_cmp)
14210         (default_iterate_over_objfiles_in_search_order): Use
14211         all_objfiles.
14212         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14213         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14214         (maintenance_check_psymtabs): Use all_objfiles.
14215         (ALL_PSYMTABS): Remove.
14216         * compile/compile-object-run.c (do_module_cleanup): Use
14217         all_objfiles.
14218         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14219         * cp-support.c (add_symbol_overload_list_qualified): Use
14220         all_objfiles.
14221         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14222         Use all_objfiles.
14223         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14224         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14225         all_objfiles.
14226         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14227         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14228         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14229         Uses all_objfiles.
14230         * solib.c (solib_read_symbols): Use all_objfiles
14231
14232 2019-01-09  Tom Tromey  <tom@tromey.com>
14233
14234         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14235         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14236         all_objfiles.
14237         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14238         * symmisc.c (print_symbol_bcache_statistics)
14239         (print_objfile_statistics, maintenance_print_objfiles)
14240         (maintenance_info_symtabs, maintenance_check_symtabs)
14241         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14242         all_objfiles.
14243         * source.c (forget_cached_source_info): Use all_objfiles.
14244         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14245         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14246         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14247         * objfiles.c (update_section_map): Use all_objfiles.
14248         (shared_objfile_contains_address_p): Likewise.
14249         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14250         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14251
14252 2019-01-09  Tom Tromey  <tom@tromey.com>
14253
14254         * common/next-iterator.h: New file.
14255         * objfiles.h (class all_objfiles): New.
14256         (struct objfile_iterator): New.
14257
14258 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14259
14260         * NEWS: Move the description of the changed "frame", "select-frame",
14261          and "info frame" commands to the Changed commands section.
14262
14263 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14264
14265         * gdbtypes.c (check_stub_method_group): Remove handling of old
14266         mangling schemes.
14267         * linespec.c (find_methods): Likewise.
14268         * stabsread.c (read_member_functions): Likewise.
14269         * valops.c (search_struct_method): Likewise.
14270         (value_struct_elt_for_reference): Likewise.
14271         * NEWS: Mention this change.
14272
14273 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14274
14275         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14276         print_source_lines.
14277         * source.c (print_source_lines_base): Update line number check.
14278         (print_source_lines): New function.
14279         (source_lines_range::source_lines_range): New function.
14280         * source.h (class source_lines_range): New class.
14281         (print_source_lines): New declaration.
14282
14283 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14284
14285         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14286
14287 2019-01-08  Tom Tromey  <tom@tromey.com>
14288             Simon Marchi  <simon.marchi@ericsson.com>
14289
14290         PR gdb/24060
14291         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14292         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14293         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14294         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14295         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14296         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14297
14298 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14299
14300         * source.c (select_source_symtab): Move header comment to
14301         declaration in source.h.
14302         (forget_cached_source_info_for_objfile): Likewise.
14303         (forget_cached_source_info): Likewise.
14304         (identify_source_line): Likewise.
14305         * source.h (identify_source_line): Move declaration from symtab.h
14306         and add comment from source.c
14307         (print_source_lines): Likewise.
14308         (forget_cached_source_info_for_objfile): Likewise.
14309         (forget_cached_source_info): Likewise.
14310         (select_source_symtab): Likewise.
14311         (enum print_source_lines_flag): Move definition from symtab.h.
14312         * symtab.h (identify_source_line): Move declaration to source.h.
14313         (print_source_lines): Likewise.
14314         (forget_cached_source_info_for_objfile): Likewise.
14315         (forget_cached_source_info): Likewise.
14316         (select_source_symtab): Likewise.
14317         (enum print_source_lines_flag): Move definition to source.h.
14318         * tui/tui-hooks.c: Add 'source.h' include.
14319
14320 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14321
14322         * source.c (print_source_lines_base): Handle requests to print
14323         reverse line number sequences, and guard against empty lines
14324         string.
14325
14326 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14327
14328         * source.c (print_source_lines_base): Fix skip of '\r' if next
14329         character is '\n'.
14330
14331 2019-01-06  Tom Tromey  <tom@tromey.com>
14332
14333         * c-exp.y (struct c_parse_state) <macro_original_text,
14334         expansion_obstack>: New member.
14335         (macro_original_text, expansion_obstack): Remove globals.
14336         (scan_macro_expansion, scanning_macro_expansion)
14337         (finished_macro_expansion): Update.
14338         (scan_macro_cleanup): Remove.
14339         (yylex, c_parse): Update.
14340
14341 2019-01-06  Tom Tromey  <tom@tromey.com>
14342
14343         * c-exp.y (struct c_parse_state) <strings>: New member.
14344         (operator_stoken): Update.
14345
14346 2019-01-06  Tom Tromey  <tom@tromey.com>
14347
14348         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14349         (union type_stack_elt) <typelist_val>: Now a pointer to
14350         std::vector.
14351         (type_stack_cleanup): Don't declare.
14352         (push_typelist): Update.
14353         * parse.c (pop_typelist): Return a std::vector.
14354         (push_typelist): Take a std::vector.
14355         (follow_types): Update.  Do not free args.
14356         (type_stack_cleanup): Remove.
14357         * c-exp.y (struct c_parse_state): New.
14358         (cpstate): New global.
14359         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14360         (nonempty_typelist): Update.
14361         (func_mod): Create a new vector.
14362         (c_parse): Create a c_parse_state.
14363         (check_parameter_typelist): Do not delete params.
14364         (function_method): Update.  Do not delete type_list.
14365
14366 2019-01-06  Tom Tromey  <tom@tromey.com>
14367
14368         PR gdb/28155:
14369         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14370         check_typedef.
14371         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14372         (print_return_value): Likewise.
14373
14374 2019-01-05  Tom Tromey  <tom@tromey.com>
14375
14376         * contrib/cleanup_check.py: Remove.
14377         * contrib/gcc-with-excheck: Remove.
14378         * contrib/exsummary.py: Remove.
14379         * contrib/excheck.py: Remove.
14380
14381 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14382
14383         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14384         NULL. Initialize tpprev to NULL instead of assigning it
14385         to NULL on the next statement.
14386         * windows-nat.c (windows_delete_thread): Remove check for
14387         main_thread_id before printing thread exit notifications.
14388         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14389         Remove thread ID check against main_thread_id.
14390         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14391         windows_delete_thread.
14392         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14393
14394 2019-01-04  Tom Tromey  <tom@tromey.com>
14395
14396         * compile/compile.c (_initialize_compile): Use upper case for
14397         metasyntactic variables.
14398         * symmisc.c (_initialize_symmisc): Use upper case for
14399         metasyntactic variables.
14400         * psymtab.c (_initialize_psymtab): Use upper case for
14401         metasyntactic variables.
14402         * demangle.c (demangle_command): Use upper case for metasyntactic
14403         variables.
14404         (_initialize_demangler): Likewise.
14405         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14406         variables.
14407
14408 2019-01-03  Tom Tromey  <tom@tromey.com>
14409
14410         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14411
14412 2019-01-03  Tom Tromey  <tom@tromey.com>
14413
14414         * python/py-symtab.c (salpy_str): Update.
14415         (struct salpy_sal_object) <symtab>: Now a PyObject.
14416         (salpy_dealloc): Update.
14417         (del_objfile_sal): Use gdbpy_ref.
14418
14419 2019-01-03  Tom Tromey  <tom@tromey.com>
14420
14421         * python/py-type.c (convert_field): Use new_reference.  Return
14422         gdbpy_ref.
14423         (make_fielditem): Return gdbpy_ref.
14424         (typy_fields): Update.
14425         (typy_getitem): Update.
14426         (field_name): Return gdbpy_ref.  Use new_reference.
14427         (typy_iterator_iternext): Update.
14428
14429 2019-01-03  Tom Tromey  <tom@tromey.com>
14430
14431         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14432
14433 2019-01-03  Tom Tromey  <tom@tromey.com>
14434
14435         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14436         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14437         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14438         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14439         (pspy_set_type_printers): Likewise.
14440         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14441         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14442         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14443         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14444         (objfpy_set_type_printers): Likewise.
14445
14446 2019-01-03  Tom Tromey  <tom@tromey.com>
14447
14448         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14449         (gdbpy_print_stack): Use gdbpy_err_fetch.
14450         * python/python-internal.h (class gdbpy_err_fetch): New class.
14451         (class gdbpy_enter) <m_error_type, m_error_value,
14452         m_error_traceback>: Remove.
14453         <m_error>: New member.
14454         (gdbpy_exception_to_string): Don't declare.
14455         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14456         * python/py-value.c (convert_value_from_python): Use
14457         gdbpy_err_fetch.
14458         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14459         gdbpy_exception_to_string.
14460         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14461         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14462         gdbpy_err_fetch.
14463
14464 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14465
14466         * linux-nat.c (delete_lwp_cleanup): Delete.
14467         (struct lwp_deleter): New struct.
14468         (lwp_info_up): New typedef.
14469         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14470         lwp_info_up.
14471
14472 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14473
14474         * linux-fork.c (class scoped_switch_fork_info): New class.
14475         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14476
14477 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14478
14479         * valops.c (find_overload_match): Remove use of null_cleanup, and
14480         calls to do_cleanups.
14481
14482 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14483
14484         * compile/compile-cplus-types.c
14485         (compile_cplus_instance::decl_name): Handle changes to
14486         cp_func_name.
14487         * cp-support.c (cp_func_name): Update header comment, update
14488         return type.
14489         * cp-support.h (cp_func_name): Update return type in declaration.
14490         * valops.c (find_overload_match): Move temp_func local to top
14491         level of function and change its type.  Use temp_func to hold and
14492         delete temporary string obtained from cp_func_name.
14493
14494 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14495
14496         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14497         gdb::char_vector, remove cleanup, and update uses of `msg`.
14498
14499 2019-01-03  Jim Wilson  <jimw@sifive.com>
14500
14501         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14502
14503 2019-01-02  Tom Tromey  <tom@tromey.com>
14504
14505         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14506         (tdesc_parse_xml): Remove cleanups.
14507         * target-descriptions.h (make_cleanup_free_target_description):
14508         Don't declare.
14509         (target_desc_deleter): New struct.
14510         (target_desc_up): New typedef.
14511         * target-descriptions.c (target_desc_deleter::operator()): Rename
14512         from free_target_description.
14513         (make_cleanup_free_target_description): Remove.
14514
14515 2019-01-02  Tom Tromey  <tom@tromey.com>
14516
14517         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14518         constructor, destructor.
14519         (linespec_parser): Remove typedef.
14520         (~linespec_parser): Rename from linespec_parser_delete.
14521         (linespec_lex_to_end, linespec_complete_label)
14522         (linespec_complete): Update.
14523         (decode_line_full): Remove cleanups.
14524         (decode_line_1): Update.
14525
14526 2019-01-02  Tom Tromey  <tom@tromey.com>
14527
14528         * python/python-internal.h (inferior_to_inferior_object): Change
14529         return type.
14530         * python/py-exitedevent.c (create_exited_event_object): Update.
14531         * python/py-inferior.c (inferior_to_inferior_object): Return
14532         gdbpy_ref.
14533         (python_new_inferior, python_inferior_deleted)
14534         (thread_to_thread_object, delete_thread_object)
14535         (build_inferior_list, gdbpy_selected_inferior): Update.
14536         * python/py-infthread.c (create_thread_object): Update.  Also fail
14537         if inferior_to_inferior_object fails.
14538
14539 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14540
14541         * inferior.h (class inferior) <displaced_step_state>: New field.
14542         * infrun.h (struct displaced_step_state): Move here from
14543         infrun.c.  Initialize fields, add constructor.
14544         <inf>: Remove field.
14545         <reset>: New method.
14546         * infrun.c (struct displaced_step_inferior_state): Move to
14547         infrun.h.
14548         (displaced_step_inferior_states): Remove.
14549         (get_displaced_stepping_state): Adust.
14550         (displaced_step_in_progress_any_inferior): Adjust.
14551         (displaced_step_in_progress_thread): Adjust.
14552         (displaced_step_in_progress): Adjust.
14553         (add_displaced_stepping_state): Remove.
14554         (get_displaced_step_closure_by_addr): Adjust.
14555         (remove_displaced_stepping_state): Remove.
14556         (infrun_inferior_exit): Call displaced_step_state.reset.
14557         (use_displaced_stepping): Don't check for NULL.
14558         (displaced_step_prepare_throw): Call
14559         get_displaced_stepping_state.
14560         (displaced_step_fixup): Don't check for NULL.
14561         (prepare_for_detach): Don't check for NULL.
14562
14563 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14564
14565         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14566          in case of call that did not complete.
14567
14568 2019-01-02  Andrey Utkin  <autkin@undo.io>
14569
14570         * symfile.c (find_separate_debug_file): Fix search of debug files for
14571         remote debuggee.
14572
14573 2019-01-02  Tom Tromey  <tom@tromey.com>
14574
14575         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14576         indentation.
14577         * python/py-frame.c (frapy_older): Remove cast.
14578         (frapy_newer): Likewise.
14579         * python/py-breakpoint.c (local_setattro): Remove cast.
14580         * python/py-arch.c (archpy_name): Remove local variable.
14581         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14582
14583 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14584
14585         * unittests/basic_string_view/element_access/char/empty.cc:
14586         Fix year range in copyright header.
14587
14588 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14589
14590         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14591         Delete.
14592         <operator==>: Update with for removed field.
14593         <hash>: Likewise.
14594         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14595         <isa_features>: ...this.
14596         <abi_features>: New field.
14597         (riscv_isa_flen): Update comment.
14598         (riscv_abi_xlen): New declaration.
14599         (riscv_abi_flen): New declaration.
14600         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14601         isa_features.
14602         (riscv_abi_xlen): New function.
14603         (riscv_isa_flen): Update to get answer from isa_features.
14604         (riscv_abi_flen): New function.
14605         (riscv_has_fp_abi): Update to get answer from abi_features.
14606         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14607         xlen and flen.
14608         (riscv_call_info) <xlen, flen>: Update comment.
14609         (riscv_call_arg_struct): Remove invalid assertions
14610         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14611         is removed.
14612         (riscv_gdbarch_init): Gather isa features and abi features
14613         separately, ensure both match on the gdbarch when reusing an old
14614         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14615         a target with 64-bit float hardware.
14616
14617 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14618
14619         * source.c (search_command_helper): Stop reverse search
14620         when line 1 has been searched.
14621
14622 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14623
14624         * record-full.c (record_full_base_target::close): Rewrite
14625         record_full_core_buf_list free logic.
14626
14627 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14628
14629         * break-catch-syscall.c (print_one_catch_syscall): xfree
14630         the last text.
14631
14632 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14633
14634         * top.c (print_gdb_version): Update Copyright year in version
14635         message.
14636
14637 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14638
14639         Update copyright year range in all GDB files.
14640
14641 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14642
14643         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14644
14645 For older changes see ChangeLog-2018.
14646 \f
14647 Local Variables:
14648 mode: change-log
14649 left-margin: 8
14650 fill-column: 74
14651 version-control: never
14652 coding: utf-8
14653 End:
14654