gdb/ChangeLog

   1 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
   2
   3         * gdb/rx-tdep.c (rx_register_names): New.
   4         (rx_register_name): Delete.
   5         (rx_psw_type): Delete.
   6         (rx_fpsw_type): Delete.
   7         (rx_register_type): Delete.
   8         (rx_gdbarch_init): Convert target-descriptions.
   9         (_initialize_rx_tdep): Add initialize_tdesc_rx.
  10         * gdb/features/Makefile: Add rx.xml.
  11         * gdb/features/rx.xml: New.
  12         * gdb/features/rx.c: Generated.
  13         * gdb/NEWS: Mention target description support.
  14
  15 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  16
  17         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
  18         *slot_ptr.
  19
  20 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  21
  22         * configure.ac: Don't check for 'dlfcn.h' (moved to
  23         gdbsupport/common.m4).
  24         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
  25         'gdbsupport/'.
  26         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
  27         * compile/compile-c-support.c: Include
  28         'gdbsupport/gdb-dlfcn.h'.
  29         * gdbsupport/common.m4: Check for 'dlfcn.h'.
  30         * gdb-dlfcn.c: Move to...
  31         * gdbsupport/gdb-dlfcn.c: ... here.
  32         * gdb-dlfcn.h: Move to...
  33         * gdbsupport/gdb-dlfcn.h: ... here.
  34
  35 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
  36
  37         * nios2-tdep.c (struct reg_value): Improve comments.  Make
  38         the offset field signed.
  39
  40 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  41
  42         * python/lib/gdb/__init__.py (_execute_file): New function.
  43         * python/python.c (python_run_simple_file): Call gdb._execute_file
  44         on Windows.
  45
  46 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  47
  48         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
  49         all uses as this was never set to anything but a zero value.
  50
  51 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
  52
  53         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
  54
  55 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
  56
  57         * tui/tui-data.h (tui_gen_win_info): Add an =default
  58         move constructor, required by some GCC versions.
  59
  60 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
  61
  62         * go32-nat.c (go32_sysinfo): Add hygon_p.
  63
  64 2019-08-20  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
  67         line_from_reg_element_no, first_reg_element_no_inline,
  68         display_all_data, delete_data_content_windows,
  69         erase_data_content>: Now private.
  70
  71 2019-08-20  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
  74         (tui_unhighlight_win, tui_highlight_win)
  75         (tui_win_info::make_window): Update.
  76         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
  77
  78 2019-08-20  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  81         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  82         (MAX_PID_WIDTH): Move to tui-stack.c.
  83         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  84         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  85         (MAX_PID_WIDTH): Move from tui-data.h.
  86
  87 2019-08-20  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
  90         * tui/tui-wingeneral.c (box_win): Change type of win_info.
  91         (box_win): Update.
  92         (tui_gen_win_info::make_window): Rename from tui_make_window.
  93         (tui_win_info::make_window): New method.
  94         (tui_gen_win_info::make_visible): Update.
  95         * tui/tui-source.c (tui_source_window::set_contents): Update.
  96         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  97         (tui_data_window::display_registers_from): Update.
  98         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  99         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 100         Declare.
 101         <can_box>: Remove.
 102         <title>: Remove.
 103         (struct tui_win_info) <make_window>: Declare.
 104         <can_box>: Now virtual.
 105         <title>: New member.
 106         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 107         * tui/tui-command.c (tui_cmd_window::resize): Update.
 108
 109 2019-08-20  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 112         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 113         (tui_data_window::check_register_values): Update.
 114
 115 2019-08-20  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-regs.h (struct tui_data_window): Use
 118         DISABLE_COPY_AND_ASSIGN.
 119         <regs_content>: Change type, removing unique_ptr.
 120         <tui_data_window>: Add move constructor.
 121         * tui/tui-regs.c (tui_data_window::show_registers)
 122         (tui_data_window::show_register_group)
 123         (tui_data_window::display_registers_from)
 124         (tui_data_window::display_registers_from)
 125         (tui_data_window::first_data_item_displayed)
 126         (tui_data_window::delete_data_content_windows)
 127         (tui_data_window::rerender, tui_data_window::refresh_window)
 128         (tui_data_window::check_register_values): Update.
 129
 130 2019-08-20  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 133         show_register_group>: Declare.
 134         (tui_show_register_group): Don't declare.
 135         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 136         tui_show_registers.
 137         (tui_data_window::show_register_group): Rename from
 138         tui_show_register_group.
 139         (tui_data_window::check_register_values, tui_reg_command):
 140         Update.
 141         * tui/tui-layout.c (tui_set_layout): Update.
 142
 143 2019-08-20  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 146         Declare.
 147         (tui_check_register_values): Don't declare.
 148         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 149         from tui_check_register_values.
 150         * tui/tui-hooks.c (tui_register_changed): Update.
 151
 152 2019-08-20  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-regs.c (tui_reg_layout): Move later.
 155         (tui_show_registers): Don't enable TUI mode or change layout.
 156
 157 2019-08-20  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-regs.h (struct tui_data_item_window)
 160         <~tui_data_item_window>: Remove.
 161         <content>: Now a unique_xmalloc_ptr.
 162         * tui/tui-regs.c (tui_register_format): Return a
 163         unique_xmalloc_ptr.
 164         (tui_get_register): Update.
 165         (~tui_data_item_window): Remove.
 166         (tui_data_window::display_registers_from, tui_display_register):
 167         Update.
 168         * tui/tui-io.h (tui_expand_tabs): Update.
 169         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 170         Remove "col" parameter.
 171
 172 2019-08-20  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 175         field.
 176         * tui/tui-regs.c (~tui_data_item_window): Update.
 177
 178 2019-08-20  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 181         earlier.
 182
 183 2019-08-20  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 186
 187 2019-08-20  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-source.h (struct tui_source_window): Update.
 190         * tui/tui-regs.c (tui_show_registers): Update.
 191         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 192         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 193         (NO_REGS_STRING): Remove defines.
 194
 195 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 196
 197         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 198         unnecessary thread walk if remote doesn't support the packet.
 199
 200 2019-08-19  Tom Tromey  <tromey@adacore.com>
 201
 202         * python/py-value.c (value_has_field): Fix indentation.
 203
 204 2019-08-19  Tom Tromey  <tromey@adacore.com>
 205
 206         * printcmd.c (do_one_display, info_display_command): Update.
 207         * block.h (contained_in): Return bool.  Add allow_nested
 208         parameter.
 209         * block.c (contained_in): Return bool.  Add allow_nested
 210         parameter.
 211
 212 2019-08-19  Tom Tromey  <tom@tromey.com>
 213
 214         * configure: Rebuild.
 215         * configure.ac: Disallow the combination of -static-libstdc++ and
 216         source highlight.
 217         * source-cache.c (get_language_name): Handle rust.
 218         (source_cache::get_source_lines): Ignore highlighting exceptions.
 219
 220 2019-08-16  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 223         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 224         (struct tui_source_window_base) <make_visible, refresh_window,
 225         resize>: Remove methods.
 226         <execution_info>: Remove field.
 227         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 228         (tui_show_source_line, tui_source_window_base)
 229         (~tui_source_window_base): Update.
 230         (tui_source_window_base::resize)
 231         (tui_source_window_base::make_visible)
 232         (tui_source_window_base::refresh_window): Remove.
 233         (tui_source_window_base::update_exec_info): Update.
 234         * tui/tui-source.c (tui_source_window::set_contents): Update.
 235         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 236
 237 2019-08-16  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 240         deprecated_query_hook.
 241
 242 2019-08-16  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 245         (tui_update_source_windows_with_line): Update.
 246         * tui/tui-source.h (struct tui_source_window)
 247         <show_symtab_source>: Declare.
 248         (tui_show_symtab_source): Don't declare.
 249         * tui/tui-source.c (tui_show_symtab_source): Rename from
 250         tui_show_symtab_source.
 251
 252 2019-08-16  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-winsource.h (struct tui_source_window_base)
 255         <set_contents>: Declare.
 256         * tui/tui-winsource.c
 257         (tui_source_window_base::update_source_window_as_is): Update.
 258         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 259         Declare.
 260         (tui_set_source_content): Don't declare.
 261         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 262         tui_set_source_content.
 263         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 264         Declare.
 265         (tui_set_disassem_content): Don't declare.
 266         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 267         tui_set_disassem_content.
 268
 269 2019-08-16  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-winsource.h (struct tui_source_window_base)
 272         <update_breakpoint_info>: Declare.
 273         (tui_update_breakpoint_info): Don't declare.
 274         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 275         (tui_update_all_breakpoint_info): Update.
 276         (tui_source_window_base::update_breakpoint_info): Rename from
 277         tui_update_breakpoint_info.
 278         (tui_source_window_base::update_exec_info): Update.
 279
 280 2019-08-16  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-winsource.h (struct tui_source_window_base)
 283         <update_source_window>: Declare.
 284         (tui_update_source_window): Don't declare.
 285         * tui/tui-winsource.c
 286         (tui_source_window_base::update_source_window): Rename from
 287         tui_update_source_window.
 288         (tui_source_window_base::rerender): Update.
 289         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 290         * tui/tui-disasm.c (tui_show_disassem)
 291         (tui_show_disassem_and_update_source)
 292         (tui_disasm_window::maybe_update): Update.
 293
 294 2019-08-16  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-winsource.h (struct tui_source_window_base)
 297         <update_source_window_as_is>: Declare.
 298         (tui_update_source_window_as_is): Don't declare.
 299         * tui/tui-winsource.c (tui_update_source_window): Update
 300         (tui_source_window_base::update_source_window_as_is): Rename from
 301         tui_update_source_window_as_is.
 302         (tui_source_window_base::refill): Update.
 303         * tui/tui-source.c (tui_show_symtab_source): Update.
 304         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 305         Update.
 306
 307 2019-08-16  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-winsource.h (tui_update_source_window)
 310         (tui_update_source_window_as_is): Remove "noerror" parameter.
 311         * tui/tui-winsource.c (tui_update_source_window)
 312         (tui_update_source_window_as_is): Remove "noerror" parameter.
 313         (tui_update_source_windows_with_addr)
 314         (tui_update_source_windows_with_line)
 315         (tui_source_window_base::rerender)
 316         (tui_source_window_base::refill): Update.
 317         * tui/tui-source.h (tui_set_source_content)
 318         (tui_show_symtab_source): Remove "noerror" parameter.
 319         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 320         parameter.
 321         (tui_show_symtab_source): Likewise.
 322         (tui_source_window::maybe_update): Update.
 323         * tui/tui-disasm.c (tui_show_disassem)
 324         (tui_show_disassem_and_update_source)
 325         (tui_disasm_window::do_scroll_vertical)
 326         (tui_disasm_window::maybe_update): Update.
 327
 328 2019-08-16  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui.c (tui_is_window_visible): Update.
 331         * tui/tui-wingeneral.c (tui_make_window)
 332         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 333         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 334         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 335         (tui_set_win_height_command, parse_scrolling_args): Update.
 336         * tui/tui-source.c (tui_source_window::style_changed): Update.
 337         * tui/tui-regs.c (tui_show_registers)
 338         (tui_data_window::first_data_item_displayed)
 339         (tui_data_window::delete_data_content_windows)
 340         (tui_check_register_values, tui_reg_command): Update.
 341         * tui/tui-disasm.c (tui_show_disassem): Update.
 342         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 343         method.
 344         <is_visible>: Remove field.
 345         * tui/tui-data.c (tui_next_win, tui_prev_win)
 346         (tui_delete_invisible_windows): Update.
 347
 348 2019-08-16  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-winsource.h (struct tui_source_window_base)
 351         <m_has_locator>: Remove.
 352         * tui/tui-layout.c (show_source_disasm_command, show_data)
 353         (show_source_or_disasm_and_command): Update.
 354
 355 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 356
 357         * NEWS (Other MI changes): New subsection.
 358         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 359         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 360         * arch-utils.c (default_get_pc_address_flags): New function.
 361         * arch-utils.h (default_get_pc_address_flags): New declaration.
 362         * gdbarch.sh: Add get_pc_address_flags.
 363         * gdbarch.c: Regenerate.
 364         * gdbarch.h: Likewise.
 365         * stack.c (print_pc): New function.
 366         (print_frame_info) (print_frame): Call print_pc.
 367
 368 2019-08-16  Tom de Vries  <tdevries@suse.de>
 369
 370         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 371         print_objfile_section_info.
 372
 373 2019-08-15  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 376         calling update_cmdwin_start_line.
 377         * tui/tui-winsource.h (struct tui_source_window_base)
 378         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 379         <rerender>: Declare.
 380         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 381         Call rerender.
 382         (tui_source_window_base::set_new_height): Remove.
 383         (tui_source_window_base::rerender): Rename from
 384         do_make_visible_with_new_height.
 385         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 386         resize method.
 387         (tui_win_info::make_invisible_and_set_new_height)
 388         (tui_win_info::make_visible_with_new_height): Remove.
 389         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 390         Declare.
 391         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 392         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 393         do_make_visible_with_new_height>: Don't declare.
 394         <rerender>: Declare.
 395         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 396         set_new_height.
 397         (tui_data_window::do_make_visible_with_new_height): Remove.
 398         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 399         call tui_show_locator_content.
 400         (tui_gen_win_info::resize): Call rerender.
 401         (show_source_or_disasm_and_command): Don't call
 402         tui_show_locator_content.
 403         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 404         method.
 405         (struct tui_win_info) <rerender>: Declare.
 406         <set_new_height, make_invisible_and_set_new_height,
 407         make_visible_with_new_height>: Don't declare.
 408         * tui/tui-data.c (tui_win_list::rerender): New method.
 409         * tui/tui-command.h (struct tui_cmd_window)
 410         <do_make_visible_with_new_height>: Don't declare.
 411         * tui/tui-command.c
 412         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 413
 414 2019-08-15  Tom Tromey  <tromey@adacore.com>
 415
 416         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 417         * ada-lang.c (ada_enum_name): Likewise.
 418
 419 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 420
 421         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 422         leading underscore.
 423         (GdbOutputErrorFile): Likewise.
 424         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 425         accordingly.
 426         (execute_unwinders): Rename to have a leading underscore.
 427         (auto_load_packages): Likewise.
 428         (global scope): Adjust call to auto_load_packages accordingly.
 429         (GdbSetPythonDirectory): Likewise.
 430         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 431         instead of execute_unwinders.
 432
 433 2019-08-15  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 436         (show_data): Don't change window visibility.
 437         (tui_gen_win_info::resize): Remove special case for command
 438         window.  Use wresize, when available.
 439         (show_source_or_disasm_and_command): Don't change window
 440         visibility.
 441         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 442         <make_visible>: New method.
 443         * tui/tui-command.c (tui_cmd_window::resize): New method.
 444
 445 2019-08-15  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 448         (struct tui_source_windows): New.
 449         * tui/tui-winsource.c (tui_display_main): Update.
 450         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 451         (new_height_ok, parse_scrolling_args): Update.
 452         * tui/tui-layout.c (show_layout, show_data): Update.
 453         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 454         (tui_add_to_source_windows): Don't declare.
 455         * tui/tui-data.c (source_windows, tui_source_windows)
 456         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 457
 458 2019-08-15  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 461         Rename from reset.
 462         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 463         * tui/tui-layout.c (show_source_disasm_command, show_data):
 464         Update.
 465         (tui_gen_win_info::resize): Rename.
 466         (show_source_or_disasm_and_command): Update.
 467         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 468         reset.
 469
 470 2019-08-15  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 473         * tui/tui-interp.c (tui_interp::init): Don't call
 474         tui_initialize_static_data.
 475         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 476
 477 2019-08-15  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 480         examine tui_win_list.
 481
 482 2019-08-15  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 485         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 486         tui_clear_source_content.
 487         (tui_clear_source_content): Remove.
 488         (tui_source_window_base::do_erase_source_content): Hoist call to
 489         content.clear().
 490         * tui/tui-stack.c (tui_show_frame_info): Don't call
 491         tui_clear_source_content.
 492
 493 2019-08-15  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-winsource.h (struct tui_source_window_base)
 496         <do_erase_source_content>: New method.
 497         <erase_source_content>: New method.
 498         (tui_erase_source_content): Don't declare.
 499         * tui/tui-winsource.c (tui_clear_source_content): Update.
 500         (tui_source_window_base::do_erase_source_content): Rename from
 501         tui_erase_source_content.
 502         (tui_source_window_base::show_source_content): Update.
 503         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 504         * tui/tui-source.h (struct tui_source_window)
 505         <erase_source_content>: New method.
 506         * tui/tui-disasm.h (struct tui_disasm_window)
 507         <erase_source_content>: New method.
 508
 509 2019-08-15  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 512         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 513         constructor.
 514         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 515         * tui/tui-source.c (tui_set_source_content): Update.
 516         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 517
 518 2019-08-15  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 521         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 522         tui-source.c.
 523         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 524         Declare.
 525         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 526         method.
 527         (tui_source_window::maybe_update): Update.
 528
 529 2019-08-15  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 532         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 533         tui-disasm.c.
 534         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 535         Declare.
 536         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 537         method.
 538         (tui_disasm_window::maybe_update): Update.
 539
 540 2019-08-15  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-winsource.h (struct tui_source_window_base)
 543         <maybe_update>: Declare.
 544         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 545         method.
 546         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 547         Declare.
 548         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 549         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 550         Declare.
 551         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 552
 553 2019-08-15  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 556
 557 2019-08-15  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-wingeneral.c: Include tui-stack.h.
 560         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 561         (struct tui_locator_window): Move from tui-data.h.
 562         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 563         (tui_initialize_static_data): Move from tui-data.c.
 564         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 565         (struct tui_locator_window): Move to tui-stack.c.
 566         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 567         (tui_initialize_static_data): Move to tui-stack.c.
 568
 569 2019-08-15  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-layout.c (show_source_disasm_command)
 572         (show_source_or_disasm_and_command): Use make_visible method, not
 573         tui_make_window.
 574         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 575         Remove.
 576
 577 2019-08-15  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-wingeneral.h (tui_make_window): Update.
 580         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 581         parameter.
 582         (tui_gen_win_info::make_visible): Update.
 583         * tui/tui-regs.c (tui_data_window::display_registers_from):
 584         Update.
 585         * tui/tui-layout.c (show_source_disasm_command)
 586         (show_source_or_disasm_and_command): Update.
 587         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 588         (enum tui_box): Remove.
 589         (struct tui_win_info) <can_box>: New method.
 590         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 591         method.
 592
 593 2019-08-15  Tom de Vries  <tdevries@suse.de>
 594
 595         * linux-nat-trad.c: Include gdbarch.h.
 596
 597 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 598
 599         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 600         register sizes.
 601
 602 2019-08-14  Tom Tromey  <tromey@adacore.com>
 603
 604         * darwin-nat.c: Include gdbarch.h.
 605         * darwin-nat-info.c: Include gdbarch.h.
 606
 607 2019-08-13  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 610         Remove.
 611         * tui/tui-data.c (tui_initialize_static_data): Update.
 612
 613 2019-08-13  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-winsource.h (struct tui_exec_info_window)
 616         <~tui_exec_info_window, maybe_allocate_content, get_content,
 617         m_content>: Remove.
 618         (struct tui_source_window_base) <set_exec_info_content,
 619         show_exec_info_content>: Don't declare.
 620         * tui/tui-winsource.c
 621         (tui_exec_info_window::maybe_allocate_content): Remove.
 622         (tui_source_window_base::update_exec_info): Rename from
 623         set_exec_info_content.
 624         (tui_source_window_base::show_exec_info_content)
 625         (tui_source_window_base::update_exec_info): Remove.
 626
 627 2019-08-13  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 630         declare.
 631         * tui/tui-winsource.c (tui_update_source_window_as_is)
 632         (tui_update_source_windows_with_addr, tui_erase_source_content):
 633         Update.
 634         (tui_clear_exec_info_content): Remove.
 635
 636 2019-08-13  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 639         declare.
 640         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 641         call tui_erase_exec_info_content.
 642         (tui_clear_exec_info_content): Rename from
 643         tui_erase_exec_info_content.
 644         (tui_clear_exec_info_content): Delete.
 645
 646 2019-08-13  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-winsource.h (struct tui_source_window_base)
 649         <show_exec_info_content>: Declare.
 650         (tui_show_exec_info_content): Don't declare.
 651         * tui/tui-winsource.c
 652         (tui_source_window_base::show_exec_info_content): Rename from
 653         tui_show_exec_info_content.
 654         (tui_source_window_base::update_exec_info): Update.
 655
 656 2019-08-13  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 659         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 660         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 661         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 662         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 663         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 664         ... here.
 665
 666 2019-08-13  Tom Tromey  <tom@tromey.com>
 667
 668         * tui/tui-winsource.h (struct tui_source_window_base)
 669         <update_exec_info>: Declare.
 670         (tui_update_exec_info): Don't declare.
 671         * tui/tui-winsource.c (tui_update_source_window_as_is)
 672         (tui_source_window_base::refresh_all)
 673         (tui_update_all_breakpoint_info): Update.
 674         (tui_source_window_base::update_exec_info): Rename from
 675         tui_update_exec_info.
 676         * tui/tui-stack.c (tui_show_frame_info): Update.
 677
 678 2019-08-13  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-winsource.h (struct tui_source_window_base)
 681         <set_exec_info_content>: Declare.
 682         (tui_set_exec_info_content): Don't declare.
 683         * tui/tui-winsource.c
 684         (tui_source_window_base::set_exec_info_content): Rename from
 685         tui_set_exec_info_content.
 686         (tui_update_exec_info): Update.
 687
 688 2019-08-13  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-winsource.h (struct tui_source_window_base)
 691         <show_source_content>: Declare.
 692         (tui_show_source_content): Don't declare.
 693         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 694         (tui_source_window_base::show_source_content): Rename from
 695         tui_show_source_content.
 696         (tui_source_window_base::refresh_all): Update.
 697         * tui/tui-layout.c (show_source_disasm_command)
 698         (show_source_or_disasm_and_command): Update.
 699
 700 2019-08-13  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-winsource.c (tui_erase_source_content)
 703         (tui_show_source_content, tui_source_window_base::refresh_all):
 704         Update.
 705         * tui/tui-wingeneral.h
 706         (tui_check_and_display_highlight_if_needed): Don't declare.
 707         * tui/tui-wingeneral.c
 708         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 709         check_and_display_highlight_if_needed.
 710         * tui/tui-win.c (tui_rehighlight_all)
 711         (tui_win_info::make_visible_with_new_height): Update.
 712         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 713         (tui_data_window::erase_data_content)
 714         (tui_data_window::display_all_data): Update.
 715         * tui/tui-data.h (struct tui_win_info)
 716         <check_and_display_highlight_if_needed>: Declare.
 717
 718 2019-08-13  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-win.c (tui_resize_all): Call
 721         tui_delete_invisible_windows.
 722         * tui/tui-layout.c (show_layout): Call
 723         tui_delete_invisible_windows.
 724         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 725         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 726
 727 2019-08-13  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 730         tui_add_win_to_layout.
 731
 732 2019-08-13  Tom Tromey  <tom@tromey.com>
 733
 734         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 735         * tui/tui-layout.c (tui_default_win_height): Now static.
 736
 737 2019-08-13  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 740         single switch.
 741         (show_source_disasm_command, show_source_or_disasm_and_command):
 742         Don't check current layout.
 743
 744 2019-08-13  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-wingeneral.c (make_all_visible): Remove.
 747         (tui_make_all_invisible): Simplify.
 748         * tui/tui-layout.c (tui_make_all_invisible): Move from
 749         tui-wingeneral.c; simplify.
 750         (show_layout): Hoist call to tui_make_all_invisible.
 751         (show_data): Don't call tui_make_all_invisible.
 752
 753 2019-08-13  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 756         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 757
 758 2019-08-13  Tom Tromey  <tom@tromey.com>
 759
 760         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 761         tui-data.c.
 762         (show_source_disasm_command, show_data)
 763         (show_source_or_disasm_and_command): Don't use
 764         tui_set_current_layout_to.
 765         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 766         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 767         tui-layout.c.
 768         (tui_set_current_layout_to): Remove.
 769
 770 2019-08-13  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-layout.c (tui_set_layout): Update.
 773         * tui/tui-data.h (struct tui_layout_def): Remove.
 774         (tui_layout_def): Don't declare.
 775         * tui/tui-data.c (layout_def): Remove.
 776         (tui_layout_def): Remove.
 777
 778 2019-08-13  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-winsource.h (struct tui_source_window_base)
 781         <clear_detail>: No longer "override".
 782         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 783         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 784         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 785         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 786         Remove.
 787         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 788
 789 2019-08-13  Tom Tromey  <tromey@adacore.com>
 790
 791         * tracepoint.c: Don't include readline.h or history.h.
 792
 793 2019-08-12  Tom Tromey  <tom@tromey.com>
 794
 795         * configure: Rebuild.
 796         * configure.ac: Check for readline 7.
 797         * NEWS: Mention readline 7 requirement.
 798         * README: Update.
 799
 800 2019-08-12  Tom Tromey  <tom@tromey.com>
 801
 802         * mingw-hdep.c (gdb_select): Remove readline hack.
 803
 804 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 805
 806         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 807         when the function fails.
 808
 809 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 810
 811         * s390-tdep.c (s390_type_align): New function.
 812         (s390_gdbarch_init): Set it as type_align gdbarch method.
 813
 814 2019-08-09  Tom de Vries  <tdevries@suse.de>
 815
 816         PR gdb/24591
 817         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 818         pc_low with relocation offset.
 819
 820 2019-08-07  Tom Tromey  <tromey@adacore.com>
 821
 822         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 823         (print_frame_args): Update.
 824         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 825         Update.
 826         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 827         * frame.h (struct frame_arg): Add initializers.
 828         <error>: Now a unique_xmalloc_ptr.
 829
 830 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 831
 832         * NEWS: Expand the Pointer Authentication entry.
 833         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 834         (aarch64_frame_unmask_lr): ... to this.
 835         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 836         Call aarch64_frame_unmask_lr.
 837         * frame.c (struct frame_info): Add "masked" variable.
 838         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 839         (fprint_frame): Check for masked pc.
 840         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 841         declarations.
 842         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 843         * stack.c (print_frame): Check for masked pc.
 844
 845 2019-08-06  Tom Tromey  <tom@tromey.com>
 846
 847         * stabsread.c (patch_block_stabs, read_one_struct_field)
 848         (read_enum_type): Use obstack_strndup.
 849         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 850         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 851         * dwarf2read.c (guess_full_die_structure_name)
 852         (anonymous_struct_prefix): Use obstack_strndup.
 853         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 854         * c-exp.y (yylex): Use obstack_strndup.
 855         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 856         (write_var_or_type): Use obstack_strndup.
 857
 858 2019-08-06  Tom Tromey  <tom@tromey.com>
 859
 860         * symfile.c (reread_symbols): Use obstack_strdup.
 861         * stabsread.c (read_type): Use obstack_strdup.
 862         * gdb_obstack.h (obstack_strdup): New overload.
 863         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 864         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 865         (dwarf2_canonicalize_name): Use obstack_strdup.
 866         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 867         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 868         Use obstack_strdup.
 869
 870 2019-08-06  Tom Tromey  <tom@tromey.com>
 871
 872         * gdb_obstack.h (obstack_strdup): Define.
 873         * gdb_obstack.c (obstack_strdup): Don't define.
 874
 875 2019-08-06  Tom Tromey  <tom@tromey.com>
 876
 877         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 878         obstack_strdup.
 879         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 880         obstack_strdup.
 881         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 882         * stabsread.c (common_block_start): Use obstack_strdup.
 883         * objfiles.c (set_objfile_main_name, objfile): Use
 884         obstack_strdup.
 885         * namespace.c (add_using_directive): Use obstack_strdup.
 886         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 887         * jit.c (finalize_symtab): Use obstack_strdup.
 888         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 889         (guess_partial_die_structure_name, partial_die_info::fixup)
 890         (dwarf2_name): Use obstack_strdup.
 891         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 892         obstack_strdup.
 893         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 894         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 895         obstack_strdup.
 896         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 897
 898 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 899
 900         * unittests/help-doc-selftests.c: New file.
 901         * Makefile.in: Add the new file.
 902
 903 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 904
 905         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 906         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 907         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 908         the trailing '.' is not output, and the first character is uppercased.
 909         (print_help_for_command): Update call to print_doc_line.
 910         (print_doc_of_command): Likewise.
 911         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 912         * cli/cli-option.c (append_indented_doc): Do not append newline.
 913         (build_help_option): Append newline after first appended_indented_doc
 914         only if a second call is done.
 915         (build_help): Append 2 new lines before each option, except the first
 916         one.
 917         * compile/compile.c (_initialize_compile): Add new lines after
 918         %OPTIONS%, when not at the end of the help.
 919         Change help doc or code
 920         producing the help doc to respect the invariants.
 921         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 922         Also removed the new line after 'Options:', as all other commands
 923         do not put an empty line between 'Options:' and the first option.
 924         * printcmd.c (_initialize_printcmd): Likewise.
 925         * stack.c (_initialize_stack): Likewise.
 926         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 927         incorrectly telling COMMAND is optional.
 928         * ada-lang.c (_initialize_ada_language): Change help doc or code
 929         producing the help doc to respect the invariants.
 930         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 931         * breakpoint.c (_initialize_breakpoint): Likewise.
 932         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 933         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 934         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 935         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 936         _initialize_cli_style): Likewise.
 937         * corelow.c (core_target_info): Likewise.
 938         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 939         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 940         * filesystem.c (_initialize_filesystem): Likewise.
 941         * frame.c (_initialize_frame): Likewise.
 942         * gnu-nat.c (add_task_commands): Likewise.
 943         * infcall.c (_initialize_infcall): Likewise.
 944         * infcmd.c (_initialize_infcmd): Likewise.
 945         * interps.c (_initialize_interpreter): Likewise.
 946         * language.c (_initialize_language): Likewise.
 947         * linux-fork.c (_initialize_linux_fork): Likewise.
 948         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 949         * maint.c (_initialize_maint_cmds): Likewise.
 950         * memattr.c (_initialize_mem): Likewise.
 951         * printcmd.c (_initialize_printcmd): Likewise.
 952         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 953         _RegEx): Likewise.
 954         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 955         * record-btrace.c (_initialize_record_btrace): Likewise.
 956         * record-full.c (_initialize_record_full): Likewise.
 957         * record.c (_initialize_record): Likewise.
 958         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 959         * regcache.c (_initialize_regcache): Likewise.
 960         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 961         _initialize_remote): Likewise.
 962         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 963         * serial.c (_initialize_serial): Likewise.
 964         * skip.c (_initialize_step_skip): Likewise.
 965         * source.c (_initialize_source): Likewise.
 966         * stack.c (_initialize_stack): Likewise.
 967         * symfile.c (_initialize_symfile): Likewise.
 968         * symtab.c (_initialize_symtab): Likewise.
 969         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 970         * top.c (init_main): Likewise.
 971         * tracefile-tfile.c (tfile_target_info): Likewise.
 972         * tracepoint.c (_initialize_tracepoint): Likewise.
 973         * tui/tui-win.c (_initialize_tui_win): Likewise.
 974         * utils.c (add_internal_problem_command): Likewise.
 975         * valprint.c (value_print_option_defs): Likewise.
 976
 977 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 978
 979         PR build/24886
 980         * configure.ac: Drop enable-libmcheck support.
 981         * configure, config.in: Rebuild.
 982         * libmcheck.m4: Remove.
 983         * acinclude.m4: Don't include it.
 984         * Makefile.in: Don't distribute it.
 985         * top.c (print_gdb_configuration): Don't mention it.
 986
 987 2019-08-06  Tom Tromey  <tom@tromey.com>
 988
 989         * utils.c (set_output_style): Sometimes pass stream to
 990         emit_style_escape.
 991         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 992         * record-btrace.c (btrace_insn_history): Update.
 993         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 994         method.
 995         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 996         Update initializers.
 997         <m_uiout>: New field.
 998         <m_di>: Move lower.
 999         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1000         Remove "uiout" parameter.
1001         (dump_insns): Update.
1002         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1003         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1004
1005 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1006
1007         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1008         (error_in_psymtab_expansion): Likewise.
1009         (lookup_symbol_via_quick_fns): Likewise.
1010         (basic_lookup_transparent_type_quick): Likewise.
1011         (basic_lookup_transparent_type_1): Likewise.
1012
1013 2019-08-06  Tom Tromey  <tromey@adacore.com>
1014
1015         * source.c (last_source_error): Now bool.
1016         (print_source_lines_base): Make "noprint" bool.  Only open
1017         source file when last_source_visited changes.
1018
1019 2019-08-06  Tom Tromey  <tromey@adacore.com>
1020
1021         * annotate.c (annotate_source_line): Use g_source_cache.
1022         * source-cache.c (source_cache::get_plain_source_lines): Change
1023         parameters.  Populate m_offset_cache.
1024         (source_cache::ensure): New method.
1025         (source_cache::get_line_charpos): New method.
1026         (extract_lines): Move lower.  Change parameters.
1027         (source_cache::get_source_lines): Move lower.
1028         * source-cache.h (class source_cache): Update comment.
1029         <get_line_charpos>: New method.
1030         <get_source_lines>: Update comment.
1031         <clear>: Clear m_offset_cache.
1032         <get_plain_source_lines>: Change parameters.
1033         <ensure>: New method
1034         <m_offset_cache>: New member.
1035         * source.c (forget_cached_source_info_for_objfile): Update.
1036         (info_source_command): Use g_source_cache.
1037         (find_source_lines, open_source_file_with_line_charpos): Remove.
1038         (print_source_lines_base, search_command_helper): Use g_source_cache.
1039         * source.h (open_source_file_with_line_charpos): Don't declare.
1040         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1041         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1042         Use g_source_cache.
1043
1044 2019-08-06  Tom Tromey  <tromey@adacore.com>
1045
1046         * source-cache.c (source_cache::get_plain_source_lines):
1047         Remove "first_line" and "last_line" parameters.
1048         (source_cache::get_source_lines): Cache plain text.
1049         * source-cache.h (class source_cache)
1050         <get_plain_source_lines>: Update.
1051
1052 2019-08-06  Tom Tromey  <tromey@adacore.com>
1053
1054         * source-cache.c (extract_lines): No longer a method.
1055         Changed type of parameter.  Include final newline.
1056         (selftests::extract_lines_test): New function.
1057         (_initialize_source_cache): Likewise.
1058         * source-cache.h (class source_cache)
1059         <extract_lines>: Don't declare.
1060
1061 2019-08-06  Tom Tromey  <tromey@adacore.com>
1062
1063         * breakpoint.c (init_breakpoint_sal): Update.
1064         (breakpoint): Update.
1065         * breakpoint.h (struct breakpoint) <filter>: Now a
1066         unique_xmalloc_ptr.
1067
1068 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1069
1070         * NEWS: Mention dictionary access on blocks.
1071         * python/py-block.c (blpy_getitem): New function.
1072         (block_object_as_mapping): New struct.
1073         (block_object_type): Use new struct for tp_as_mapping field.
1074
1075 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1076
1077         * objfiles.h (objfile): Add a comment describing partial symbols.
1078
1079 2019-08-05  Tom Tromey  <tromey@adacore.com>
1080
1081         * compile/compile.c (_initialize_compile): Use _(), not N_().
1082         * thread.c (_initialize_thread): Use _(), not N_().
1083         * stack.c (_initialize_stack): Use _(), not N_().
1084         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1085
1086 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1087
1088         * dwarf2read.c (struct dw2_symtab_iterator):
1089         <want_specific_block>: Remove.
1090         <block_index>: Change type to gdb::optional.
1091         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1092         change type of BLOCK_INDEX parameter to gdb::optional.
1093         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1094         (dw2_lookup_symbol): Don't pass argument for
1095         WANT_SPECIFIC_BLOCK.
1096         (dw2_expand_symtabs_for_function): Don't pass argument for
1097         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1098         (class dw2_debug_names_iterator)
1099         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1100         parameter, change BLOCK_INDEX type to gdb::optional.
1101         <m_want_specific_block>: Remove.
1102         <m_block_index>: Change type to gdb::optional.
1103         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1104         gdb::optional.  Re-write in function of gdb::optional.
1105         (dw2_debug_names_lookup_symbol): Don't pass argument for
1106         WANT_SPECIFIC_BLOCK.
1107         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1108         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1109         BLOCK_INDEX.
1110
1111 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1112
1113         * NEWS: Mention changes to "info sources" command.
1114
1115 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1116
1117         * symtab.c (filename_partial_match_opts): New struct type.
1118         (struct output_source_filename_data): New members
1119         regexp, c_regexp, partial_match.
1120         (output_source_filename): Use new members to decide to print file.
1121         (info_sources_option_defs): New variable.
1122         (make_info_sources_options_def_group, print_info_sources_header,
1123         info_sources_command_completer):
1124         New functions.
1125         (info_sources_command): Read new optional arguments.
1126         (_initialize_symtab): Update info sources help.
1127
1128 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1129
1130         * ada-lang.c (exception_support_info_v0): Renamed from...
1131         (default_exception_support_info): ... this.  Create new
1132         definition for v1.
1133         (ada_has_this_exception_support): Look up catch_handlers_sym.
1134         (ada_exception_support_info_sniffer): Try v0 after default.
1135
1136 2019-08-01  Tom Tromey  <tromey@adacore.com>
1137
1138         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1139         gdbarch.h.
1140
1141 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1142
1143         * s12z-tdep.c: Fix include path for s12z-opc.h.
1144
1145 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1146
1147         * NEWS: Require GNU make 3.82.
1148
1149 2019-07-16  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1152         declare.
1153
1154 2019-07-30  Tom Tromey  <tromey@adacore.com>
1155
1156         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1157
1158 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1159
1160         * printcmd.c (print_address_symbolic): Print negative offsets.
1161         (build_address_symbolic): Force signed arithmetic when computing
1162         offset.
1163
1164 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1165
1166         PR/24474: Add a function to lookup static variables.
1167         * NEWS: Mention this new function.
1168         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1169         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1170         * python/python.c (python_GdbMethods): Add new function.
1171
1172 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1173
1174         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1175         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1176         (objfpy_lookup_static_symbol): New function.
1177         (objfile_object_methods): Add new functions.
1178
1179 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1180
1181         * NEWS: Mention 'set|show print frame-info'.  Mention new
1182         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1183         backtrace argument.  Mention that python frame filtering code
1184         is now consistent with what 'backtrace' command prints.
1185
1186 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1187
1188         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1189         comments.
1190         (print_frame_info_auto, print_frame_info_source_line,
1191         print_frame_info_location, print_frame_info_source_and_location,
1192         print_frame_info_location_and_address, print_frame_info_short_location):
1193         New declarations.
1194         (struct frame_print_options): New member print_frame_info.
1195         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1196         * stack.h (get_user_print_what_frame_info): New declaration.
1197         (frame_show_address): New declaration.
1198         * stack.c (print_frame_arguments_choices): New value 'presence'.
1199         (print_frame_info_auto, print_frame_info_source_line,
1200         print_frame_info_location, print_frame_info_source_and_location,
1201         print_frame_info_location_and_address, print_frame_info_short_location,
1202         print_frame_info_choices, print_frame_info_print_what): New definitions.
1203         (print_frame_args): Only print dots for args if print frame-arguments
1204         is 'presence'.
1205         (frame_print_option_defs): New element for "frame-info".
1206         (get_user_print_what_frame_info): New function.
1207         (frame_show_address): Make non static.  Move comment to stack.h.
1208         (print_frame_info_to_print_what): New function.
1209         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1210         to decide what to print.
1211         (backtrace_command_1): Handle the new print_frame_arguments_presence
1212         value.
1213         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1214         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1215         (py_print_frame): In non-mi mode, use LOCATION as default for
1216         print_what, similarly to frame information printed directly by
1217         backtrace command. Handle frame-info user option in non MI mode.
1218
1219 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1220
1221         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1222         Add case for debugging 32-bit target on 64-bit host.  Revise
1223         comment.
1224
1225 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1226
1227         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1228         instead of find_function_entry_range_from_pc.
1229
1230 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1231
1232         * stack.c (find_frame_funname): Remove code which preferred
1233         minsym over symtab sym in "certain pathological cases".
1234
1235         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1236         parameter.  Change type of "do_demangle" to bool.
1237         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1238         Pass suitable "prefer_sym_over_minsym" flag to
1239         build_address_symbolic().  Don't output "+" for negative offsets.
1240         * printcmd.c (print_address_symbolic): Update invocation of
1241         build_address_symbolic to include a "prefer_sym_over_minsym"
1242         flag.
1243         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1244         Restrict cases in which use of minimal symbol is preferred to that
1245         of a found symbol.  Update comments.
1246
1247         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1248         for entry pc when entry pc is out of range for that FDE.
1249
1250 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1251
1252         PR gdb/24839:
1253         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1254         type.
1255
1256 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1257
1258         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1259         this function's Python signature.
1260
1261
1262 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1263
1264         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1265         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1266         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1267         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1268         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1269
1270
1271 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1272
1273         * h8300-tdep.c (h8300_register_name_common): New.
1274         h8300_register_name): Use h8300_register_name_common.
1275         (h8300s_register_name): Likewise.
1276         (h8300sx_register_name): Likewise.
1277         (h8300h_register_nam): New.
1278         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1279
1280
1281 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1282
1283         * arm-tdep.c (arm_skip_cmse_entry): New function.
1284         (arm_is_sgstubs_section): New function.
1285         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1286
1287 2019-07-22  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1290         Don't self-assign.
1291
1292 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1293
1294         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1295         type_print.
1296
1297 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1300         so that GDB doesn't match any msymbols when searching in the
1301         TYPES_DOMAIN.
1302         (print_symbol_info): Print using typedef_print or type_print based
1303         on the type of the symbol.  Add updated FIXME comment moved from...
1304         (_initialize_symtab): ... move and update FIXME comment to above.
1305
1306 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1307
1308         * NEWS: Mention adding -q option to "info types".
1309         * symtab.c (struct info_types_options): New struct.
1310         (info_types_options_defs): New variable.
1311         (make_info_types_options_def_group): New function.
1312         (info_types_command): Use gdb::option framework to parse options.
1313         (info_types_command_completer): New function.
1314         (_initialize_symtab): Extend the help text on "info types" and
1315         register command completer.
1316
1317 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1318
1319         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1320         (lookup_symbol_in_objfile): Change int to block_enum and add a
1321         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1322
1323 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1324
1325         * MAINTAINERS (Write After Approval): Add self.
1326
1327 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1328
1329         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1330         instruction to the dummy code region.
1331
1332 2019-07-19  Tom Tromey  <tromey@adacore.com>
1333
1334         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1335         (ARGSUSED, PARAMS, __func__): Remove rules.
1336
1337 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1338
1339         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1340         * features/arm/arm-with-iwmmxt.c: Remove.
1341         * features/arm/arm-with-iwmmxt.xml: Remove.
1342         * features/arm/arm-with-m-fpa-layout.c: Remove.
1343         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1344         * features/arm/arm-with-m-vfp-d16.c: Remove.
1345         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1346         * features/arm/arm-with-m.c: Remove.
1347         * features/arm/arm-with-m.xml: Remove.
1348         * features/arm/arm-with-neon.c: Remove.
1349         * features/arm/arm-with-neon.xml: Remove.
1350         * features/arm/arm-with-vfpv2.c: Remove.
1351         * features/arm/arm-with-vfpv2.xml: Remove.
1352         * features/arm/arm-with-vfpv3.c: Remove.
1353         * features/arm/arm-with-vfpv3.xml: Remove.
1354
1355 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1356
1357         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1358
1359 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1360
1361         * arch/aarch32.c (aarch32_create_target_description): Create
1362         target descriptions using features.
1363         * arch/arm.c (arm_create_target_description)
1364         (arm_create_mprofile_target_description): Likewise.
1365         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1366
1367 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1368
1369         * Makefile.in: Add new files.
1370         * aarch32-tdep.c: New file.
1371         * aarch32-tdep.h: New file.
1372         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1373         Call aarch32_read_description.
1374         * arch/aarch32.c: New file.
1375         * arch/aarch32.h: New file.
1376         * arch/arm.c (arm_create_target_description)
1377         (arm_create_mprofile_target_description): New function.
1378         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1379         (arm_create_target_description)
1380         (arm_create_mprofile_target_description): New declaration.
1381         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1382         read_description functions.
1383         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1384         Likewise.
1385         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1386         * arm-tdep.c (tdesc_arm_list): New variable.
1387         (arm_register_g_packet_guesses): Call create description functions.
1388         (arm_read_description) (arm_read_mprofile_description): New
1389         function.
1390         * arm-tdep.h (arm_read_description)
1391         (arm_read_mprofile_description): Add declaration.
1392         * configure.tgt: Add new files.
1393
1394 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1395
1396         * top.c (new_ui_command): Open specified terminal just once.
1397
1398 2019-07-18  Tom Tromey  <tromey@adacore.com>
1399
1400         * symtab.c (main_name): Constify return type.
1401         * symfile.c (set_initial_language): Update.
1402         * symtab.h (main_name): Constify return type.
1403
1404 2019-07-17  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-winsource.c (tui_update_source_window)
1407         (tui_update_source_window_as_is)
1408         (tui_update_source_windows_with_line): Remove return.
1409         * tui/tui-disasm.c (tui_show_disassem)
1410         (tui_show_disassem_and_update_source): Remove return.
1411         * tui/tui.c (tui_reset): Remove return.
1412         * tui/tui-wingeneral.c
1413         (tui_check_and_display_highlight_if_needed): Remove return.
1414
1415 2019-07-17  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1418
1419 2019-07-17  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-winsource.h (struct tui_exec_info_window)
1422         (struct tui_source_window_base): Move from tui-data.h.
1423         * tui/tui-winsource.c: Move many method definitions from
1424         elsewhere.  Remove "structuring" comments.
1425         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1426         (tui_source_window_base::refresh_window): Move to
1427         tui-winsource.c.
1428         * tui/tui-win.c (tui_source_window_base::refresh_all)
1429         (tui_source_window_base::update_tab_width)
1430         (tui_source_window_base::set_new_height)
1431         (tui_source_window_base::do_make_visible_with_new_height): Move to
1432         tui-winsource.c.
1433         * tui/tui-source.h: Update.
1434         * tui/tui-source.c (tui_source_window_base::reset): Move to
1435         tui-winsource.c.
1436         * tui/tui-disasm.h: Update.
1437         * tui/tui-data.h (struct tui_exec_info_window): Move to
1438         tui-winsource.h.
1439         (struct tui_source_window_base): Likewise.
1440         * tui/tui-data.c (tui_source_window_base::clear_detail)
1441         (tui_source_window_base, ~tui_source_window_base): Move to
1442         tui-winsource.c.
1443
1444 2019-07-17  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-win.c (tui_resize_all)
1447         (tui_source_window_base::update_tab_width)
1448         (tui_adjust_win_heights): Update.
1449         (tui_win_info::make_invisible_and_set_new_height): Rename from
1450         make_invisible_and_set_new_height.
1451         * tui/tui-data.h (struct tui_win_info)
1452         <make_invisible_and_set_new_height>: New method.
1453
1454 2019-07-17  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui.c: Update.
1457         * tui/tui-source.h (struct tui_source_window): Move from
1458         tui-data.h.
1459         * tui/tui-layout.c: Update.
1460         * tui/tui-disasm.c: Update.
1461         * tui/tui-data.h (struct tui_source_window): Move to
1462         tui-source.h.
1463
1464 2019-07-17  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1467         tui-data.h.
1468         * tui/tui-data.h (struct tui_disasm_window): Move to
1469         tui-disasm.h.
1470
1471 2019-07-17  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-regs.h (struct tui_data_item_window): Move from
1474         tui-data.h.
1475         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1476         * tui/tui-data.h (struct tui_data_item_window): Move to
1477         tui-regs.h.
1478         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1479
1480 2019-07-17  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui.c: Update.
1483         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1484         (tui_cmd_window::max_height): Move to tui-command.c.
1485         * tui/tui-layout.c: Update.
1486         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1487         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1488         tui-command.c.
1489         * tui/tui-command.h (struct tui_cmd_window): Move from
1490         tui-data.h.
1491         * tui/tui-command.c: Remove "structuring" comments.
1492         (tui_cmd_window::clear_detail)
1493         (tui_cmd_window::do_make_visible_with_new_height)
1494         (tui_cmd_window::max_height): Move from elsewhere.
1495
1496 2019-07-17  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1499         Now static.
1500         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1501         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1502
1503 2019-07-17  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui.c: Update.
1506         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1507         tui-regs.c.
1508         * tui/tui-windata.h: Remove file.
1509         * tui/tui-windata.c: Remove file.
1510         * tui/tui-win.c (tui_data_window::set_new_height)
1511         (tui_data_window::do_make_visible_with_new_height): Move to
1512         tui-regs.c.
1513         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1514         * tui/tui-regs.c: Remove "structuring" comments.
1515         (tui_data_window::first_data_item_displayed)
1516         (tui_data_window::delete_data_content_windows)
1517         (tui_data_window::erase_data_content)
1518         (tui_data_window::display_all_data)
1519         (tui_data_window::refresh_all)
1520         (tui_data_window::do_scroll_vertical)
1521         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1522         (tui_data_window::do_make_visible_with_new_height)
1523         (tui_data_window::refresh_window): Move from elsewhere.
1524         (_initialize_tui_regs): Move to end of file.
1525         * tui/tui-layout.c: Update.
1526         * tui/tui-hooks.c: Update.
1527         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1528         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1529         tui-regs.c.
1530         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1531
1532 2019-07-17  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1535         seen.
1536
1537 2019-07-17  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-win.c (tui_source_window_base::set_new_height)
1540         (tui_source_window_base::do_make_visible_with_new_height): Use
1541         m_has_locator field directly.
1542         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1543         method.
1544         (struct tui_source_window_base) <has_locator>: Likewise.
1545
1546 2019-07-17  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1549         Don't declare.
1550         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1551         Remove.
1552         * tui/tui-win.c (tui_source_window_base::set_new_height)
1553         (tui_source_window_base::set_new_height)
1554         (make_invisible_and_set_new_height)
1555         (tui_source_window_base::do_make_visible_with_new_height)
1556         (tui_source_window_base::do_make_visible_with_new_height):
1557         Update.
1558         * tui/tui-layout.c (show_source_disasm_command, show_data)
1559         (show_source_or_disasm_and_command): Update.
1560         * tui/tui-layout.c (show_layout): Update.
1561
1562 2019-07-17  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-layout.c (make_data_window): Remove.
1565         (show_data): Unify creation and re-initialization cases.
1566
1567 2019-07-17  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-layout.c (make_source_window, make_disasm_window):
1570         Remove.
1571         (show_data): Unify creation and re-initialization cases.
1572
1573 2019-07-17  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-layout.c (make_command_window): Remove.
1576         (show_source_disasm_command, show_source_or_disasm_and_command):
1577         Unify creation and re-initialization cases.
1578
1579 2019-07-17  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1582         creation and re-initialization cases.
1583
1584 2019-07-17  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-regs.c (tui_get_register): Return void.
1587
1588 2019-07-17  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1591         Simplify.
1592
1593 2019-07-17  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1596         resetting.
1597
1598 2019-07-17  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1601         * tui/tui-regs.c (tui_reg_layout): New function.
1602         (tui_show_registers, tui_reg_command): Use it.
1603         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1604         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1605         parameters.
1606         (tui_layout_command): Remove.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-layout.h (tui/tui-layout): Return void.
1611         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-layout.c (show_source_disasm_command, show_data):
1616         Update.
1617         (reset_locator): Remove.
1618         (show_source_or_disasm_and_command): Update.
1619
1620 2019-07-17  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-source.c (tui_source_window_base::reset): Remove
1623         win_type parameter.
1624         * tui/tui-layout.c (make_command_window, make_source_window)
1625         (make_disasm_window, make_data_window)
1626         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1627         (reset_locator, show_source_or_disasm_and_command): Update.
1628         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1629         win_type parameter.
1630         (struct tui_source_window_base) <reset>: Likewise.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-layout.c (show_source_disasm_command): Use
1635         reset_locator.
1636         (reset_locator): New function.
1637         (init_and_make_win): Remove.
1638         (show_source_or_disasm_and_command): Use reset_locator.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1643         condition.
1644         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1645         Remove condition.
1646         * tui/tui-source.c (tui_source_window_base::reset): New method.
1647         * tui/tui-layout.c (make_command_window): Don't call
1648         init_and_make_win.
1649         (make_source_window, make_disasm_window): Don't call
1650         make_source_or_disasm_window.
1651         (make_data_window): Don't call init_and_make_win.  Change calling
1652         convention.
1653         (show_source_disasm_command, show_data): Simplify.
1654         (make_source_or_disasm_window): Remove.
1655         (show_source_or_disasm_and_command): Simplify.
1656         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1657         (struct tui_source_window_base) <reset>: Likewise.
1658         <execution_info>: Remove initializer.
1659         * tui/tui-data.c (tui_source_window_base): Initialize
1660         execution_info.
1661
1662 2019-07-17  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1665         variable.
1666
1667 2019-07-17  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui.c (tui_rl_other_window): Update.
1670         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1671         superclass method first.  Always iterate over regs_content.
1672         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1673         method.
1674         * tui/tui-win.c (tui_set_focus_command): Update.
1675
1676 2019-07-17  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-win.c (tui_set_focus_command): Rename from
1679         tui_set_focus.  Call tui_enable.
1680         (tui_set_focus_command): Remove.
1681
1682 2019-07-17  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1685         refresh_window.
1686         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1687         touchwin.
1688         (tui_data_window::refresh_window): Call refresh_window on data
1689         items.  Always call superclass refresh_window.
1690         (tui_win_info::refresh): Remove.
1691         (tui_source_window_base::refresh_window): Update.
1692         (tui_refresh_all): Update.
1693         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1694         refresh_window.
1695         (show_source_or_disasm_and_command): Likewise.
1696         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1697         (struct tui_source_window_base) <refresh>: Likewise.
1698
1699 2019-07-17  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-winsource.c (tui_clear_source_content)
1702         (tui_show_source_content): Update.
1703         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1704         whether content is empty.
1705         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1706         Remove.
1707
1708 2019-07-17  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1711         window's contents.
1712         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1713         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1714
1715 2019-07-17  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1718         (struct tui_data_item_window): Update.
1719
1720 2019-07-17  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1723         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1724         defines.
1725
1726 2019-07-17  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-winsource.h (tui_erase_source_content)
1729         (tui_clear_source_content): Remove "display_prompt" parameter.
1730         * tui/tui-winsource.c (tui_update_source_window_as_is)
1731         (tui_update_source_windows_with_addr): Update.
1732         (tui_clear_source_content): Remove "display_prompt" parameter.
1733         (tui_erase_source_content): Likewise.  Simplify.
1734         (tui_show_source_content): Update.
1735         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1736         * tui/tui-stack.c (tui_show_frame_info): Update.
1737         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1738         Remove defines.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1743         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1744         parameter.
1745         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1746         parameter.
1747
1748 2019-07-17  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-winsource.c (tui_clear_source_content)
1751         (tui_show_source_content, tui_show_exec_info_content)
1752         (tui_clear_exec_info_content): Update.
1753         * tui/tui-stack.c (tui_show_locator_content): Update.
1754         (tui_show_frame_info): Update.
1755         * tui/tui-source.h (tui_source_window): Don't declare.
1756         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1757         from tui_source_is_displayed.
1758         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1759         Remove field.
1760         (struct tui_source_window_base) <content_in_use>: New field.  Now
1761         bool.
1762         (struct tui_source_window) <showing_source_p>: New method.
1763         (TUI_SRC_WIN): Change cast.
1764         * tui/tui-data.c (tui_initialize_static_data): Update.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1769         location_matches_p.
1770         * tui/tui-source.c (tui_source_window::location_matches_p): New
1771         method.
1772         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1773         method.
1774         * tui/tui-data.h (struct tui_source_window_base)
1775         <location_matches_p>: New method.
1776         (struct tui_source_window, struct tui_disasm_window)
1777         <location_matches_p>: Likewise.
1778
1779 2019-07-17  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-win.c (tui_set_win_height_command): Rename from
1782         tui_set_win_height.
1783         (tui_set_win_height_command): Remove.
1784
1785 2019-07-17  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-source.c (tui_source_window): New constructor.  Add
1788         observer.
1789         (~tui_source_window): New destructor.
1790         (tui_source_window::style_changed): New method.
1791         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1792         (tui_attach_detach_observers): Update.
1793         * tui/tui-data.h (struct tui_source_window): Make constructor not
1794         inline.  Add destructor.
1795         (struct tui_source_window) <style_changed>: New method.
1796         <m_observable>: New member.
1797
1798 2019-07-17  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1801         * tui/tui-win.c (tui_resize_all): Fix typo.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1806         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1807         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1808         * tui/tui-win.c (window_name_completer): Use foreach.
1809         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1810         (update_tab_width): Likewise.
1811         * tui/tui-layout.c (show_layout): Update.
1812         * tui/tui-data.h (class tui_window_iterator): New.
1813         (struct all_tui_windows): New.
1814         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1815
1816 2019-07-17  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1819         parameter.  Don't reference globals.
1820         (tui_reg_command): Update.
1821
1822 2019-07-17  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-regs.c (tui_show_registers): Simplify.
1825
1826 2019-07-17  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-regs.c (tui_show_registers): Update.
1829         (tui_show_register_group): Add win_info parameter.
1830
1831 2019-07-17  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1834         Rename from tui_display_reg_element_at_line.
1835         (tui_data_window::display_registers_from_line): Update.
1836         * tui/tui-data.h (struct tui_data_window)
1837         <display_reg_element_at_line>: New method.
1838
1839 2019-07-17  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-regs.h (tui_display_registers_from)
1842         (tui_display_registers_from_line): Don't declare.
1843         * tui/tui-windata.c (tui_data_window::display_all_data)
1844         (tui_data_window::refresh_all)
1845         (tui_data_window::do_scroll_vertical): Update.
1846         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1847         from tui_display_registers_from.
1848         (tui_display_reg_element_at_line): Update.
1849         (tui_data_window::display_registers_from_line): Rename from
1850         tui_display_registers_from_line.
1851         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1852         display_registers_from_line>: New methods.
1853
1854 2019-07-17  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1857         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1858         from tui_erase_data_content.
1859         (tui_data_window::display_all_data)
1860         (tui_data_window::refresh_all)
1861         (tui_data_window::do_scroll_vertical): Update.
1862         * tui/tui-regs.c (tui_show_registers): Update.
1863         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1864         New method.
1865
1866 2019-07-17  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1869         declare.
1870         * tui/tui-windata.c
1871         (tui_data_window::delete_data_content_windows): Rename from
1872         tui_delete_data_content_windows.
1873         (tui_data_window::display_all_data)
1874         (tui_data_window::do_scroll_vertical): Update.
1875         * tui/tui-data.h (struct tui_data_window)
1876         <delete_data_content_windows>: New method.
1877
1878 2019-07-17  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1881         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1882
1883 2019-07-17  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1886         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1887         from tui_display_all_data.
1888         * tui/tui-win.c
1889         (tui_data_window::do_make_visible_with_new_height): Update.
1890         * tui/tui-regs.c (tui_show_registers): Update.
1891         * tui/tui-layout.c (tui_set_layout): Update.
1892         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1893         method.
1894
1895 2019-07-17  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1898         * tui/tui-windata.c (tui_display_data_from): Remove.
1899         (tui_data_window::refresh_all): Update.
1900
1901 2019-07-17  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1904         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1905         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1906         tui_display_registers_from_line.
1907         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1908         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1909         "force_display" parameter.
1910
1911 2019-07-17  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1914         declare.
1915         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1916         Rename from tui_first_reg_element_no_inline.
1917         (tui_display_reg_element_at_line)
1918         (tui_display_registers_from_line): Update.
1919         * tui/tui-data.h (struct tui_data_window)
1920         <first_reg_element_no_inline>: New method.
1921
1922 2019-07-17  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-windata.c (tui_display_data_from)
1925         (tui_data_window::do_scroll_vertical): Update.
1926         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1927         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1928         Rename from tui_line_from_reg_element_no.
1929         (tui_display_registers_from_line): Update.
1930         * tui/tui-data.h (struct tui_data_window)
1931         <line_from_reg_element_no>: New method.
1932
1933 2019-07-17  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1936         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1937         tui_last_regs_line_no.
1938         (tui_display_reg_element_at_line)
1939         (tui_display_registers_from_line): Update.
1940         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1941         method.
1942
1943 2019-07-17  Tom Tromey  <tom@tromey.com>
1944
1945         PR tui/24722:
1946         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1947         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1948         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1949         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1950         (tui_update_breakpoint_info): Likewise.
1951         * tui/tui-hooks.c (tui_event_create_breakpoint)
1952         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1953         Update.
1954
1955 2019-07-17  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1958
1959 2019-07-17  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-winsource.c (tui_update_source_window_as_is)
1962         (tui_update_source_windows_with_addr): Update.
1963         * tui/tui-source.h (tui_set_source_content)
1964         (tui_show_symtab_source): Add "win_info" parameter.
1965         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1966         parameter.
1967         (tui_show_symtab_source): Likewise.
1968
1969 2019-07-17  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-wingeneral.c
1972         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1973
1974 2019-07-17  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1977         (struct tui_cmd_window) <can_scroll>: New method.
1978         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1979         method.
1980
1981 2019-07-17  Tom Tromey  <tromey@adacore.com>
1982
1983         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1984         do_field_signed>: Rename.  Change type of "value".
1985         * ui-out.c (ui_out::field_signed): Rename from field_int.
1986         Change type of "value".
1987         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1988         type of "value".
1989         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1990         do_field_int.  Change type of "value".
1991         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1992         do_field_int.  Change type of "value".
1993         * tracepoint.c (trace_status_mi, tfind_1)
1994         (print_one_static_tracepoint_marker): Update.
1995         * thread.c (print_thread_info_1, print_selected_thread_frame):
1996         Update.
1997         * stack.c (print_frame, print_frame_info): Update.
1998         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1999         Update.
2000         * source.c (print_source_lines_base): Update.
2001         * skip.c (info_skip_command): Update.
2002         * record-btrace.c (btrace_ui_out_decode_error)
2003         (btrace_call_history_src_line): Update.
2004         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2005         Update.
2006         * progspace.c (print_program_space): Update.
2007         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2008         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2009         do_field_int.  Change type of "value".
2010         * mi/mi-out.c (mi_ui_out::do_table_begin)
2011         (mi_ui_out::do_table_header): Update.
2012         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2013         type of "value".
2014         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2015         (mi_cmd_data_list_changed_registers, output_register)
2016         (mi_cmd_data_read_memory, mi_load_progress)
2017         (mi_cmd_trace_frame_collected): Update.
2018         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2019         Update.
2020         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2021         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2022         (mi_cmd_var_list_children, varobj_update_one): Update.
2023         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2024         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2025         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2026         * inferior.c (print_inferior): Update.
2027         * gdb_bfd.c (print_one_bfd): Update.
2028         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2029         Update.
2030         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2031         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2032         do_field_int.  Change type of "value".
2033         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2034         do_field_int.  Change type of "value".
2035         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2036         (print_one_breakpoint_location, print_it_catch_fork)
2037         (print_one_catch_fork, print_it_catch_vfork)
2038         (print_one_catch_vfork, print_it_catch_solib)
2039         (print_it_catch_exec, print_it_ranged_breakpoint)
2040         (print_mention_watchpoint, print_mention_masked_watchpoint)
2041         (bkpt_print_it, update_static_tracepoint): Update.
2042         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2043         * break-catch-syscall.c (print_it_catch_syscall): Update.
2044         * ada-tasks.c (print_ada_task_info): Update.
2045         * ada-lang.c (print_it_exception, print_mention_exception):
2046         Update.
2047
2048 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2049
2050         PR breakpoints/24541
2051         * gdbarch.c: Regenerate.
2052         * gdbarch.h: Regenerate.
2053         * gdbarch.sh: Adjust return type and parameter types for
2054         'stap_adjust_register'.
2055         (i386_stap_adjust_register): Adjust signature and return new
2056         register name.
2057         * stap-probe.c (stap_parse_register_operand): Adjust use of
2058         'gdbarch_stap_adjust_register'.
2059
2060 2019-07-17  Tom Tromey  <tromey@adacore.com>
2061
2062         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2063         declare VEC.
2064         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2065         std::vector.
2066         (struct s390_process_info): Add initializers.
2067         (s390_add_process): Use new.
2068         (s390_linux_nat_target::low_forget_process): Use delete.
2069         (s390_linux_nat_target::low_new_fork)
2070         (s390_linux_nat_target::stopped_by_watchpoint)
2071         (s390_linux_nat_target::low_prepare_to_resume)
2072         (s390_linux_nat_target::insert_watchpoint)
2073         (s390_linux_nat_target::insert_hw_breakpoint)
2074         (s390_linux_nat_target::remove_watchpoint)
2075         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2076
2077 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2078
2079         * aarch64-fbsd-nat.c: Include regcache.h.
2080         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2081         argument.
2082         (aarch64_fbsd_nat_target::fetch_registers)
2083         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2084         variable.
2085         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2086
2087 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2088
2089         * fbsd-nat.c: Include gdbarch.h.
2090
2091 2019-07-15  Tom Tromey  <tromey@adacore.com>
2092
2093         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2094
2095 2019-07-15  Tom Tromey  <tromey@adacore.com>
2096
2097         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2098         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2099         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2100         * cli-out.c (cli_ui_out::do_field_int): New method.
2101         * ui-out.c (ui_out::field_unsigned): New method.
2102         * symfile.c (generic_load): Use field_unsigned.
2103         (print_transfer_performance): Likewise.
2104         * record-btrace.c (ui_out_field_uint): Remove.
2105         (btrace_call_history_insn_range, btrace_call_history): Use
2106         field_unsigned.
2107         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2108         field_unsigned.
2109         * ui-out.h (class ui_out) <field_unsigned>: New method.
2110         <do_field_unsigned>: Likewise.
2111
2112 2019-07-15  Tom Tromey  <tromey@adacore.com>
2113
2114         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2115         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2116         * target.c (flash_erase_command): Use field_string.
2117         * infrun.c (print_signal_received_reason): Use field_string.
2118         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2119         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2120         field_string.
2121         * ada-tasks.c (print_ada_task_info): Use field_string.
2122
2123 2019-07-15  Tom Tromey  <tromey@adacore.com>
2124
2125         * target.c (flash_erase_command): Use field_core_addr.
2126         * symfile.c (generic_load): Use field_core_addr.
2127         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2128         Use field_core_addr.
2129         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2130         field_core_addr.
2131
2132 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2133
2134         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2135         value if its desired type is smaller than a CORE_ADDR and signed.
2136
2137 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2140         of changes to field names, and use new is_reference field to
2141         decide if a property is a reference or not.
2142         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2143         field.
2144         (struct dwarf2_property_baton): Update header comment, rename
2145         'referenced_type' to 'property_type' and update comments.
2146         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2147         default property type, store in property baton, update to take
2148         accound of renamed field.
2149         (read_func_scope): Update call to attr_to_dynamic_prop.
2150         (read_array_type): Likewise.
2151         (dwarf2_per_cu_addr_sized_int_type): New function.
2152         (read_subrange_index_type): Move type finding code to
2153         dwarf2_per_cu_addr_sized_int_type.
2154         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2155         (dwarf2_per_cu_addr_type): New function.
2156         (set_die_type): Update calls to attr_to_dynamic_prop.
2157
2158 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2159
2160         * dwarf2read.c (read_subrange_index_type): New function.
2161         (read_subrange_type): Move code into new function and call it.
2162         * gdbtypes.c (create_range_type): Add some asserts.
2163
2164 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2167         update return statements.
2168         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2169         declaration, and update comment to match.
2170         * gdbtypes.c (resolve_dynamic_array): Update call to
2171         dwarf2_evaluate_property to match new return type.
2172
2173 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * valarith.c (value_subscripted_rvalue): Change lowerbound
2176         parameter type from int to LONGEST.
2177         * value.h (value_subscripted_rvalue): Likewise in declaration.
2178
2179 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2180
2181         * cli/cli-utils.c (info_print_command_completer): New function.
2182         * cli/cli-utils.h: Add 'completer.h' include, and forward
2183         declaration for 'struct cmd_list_element'.
2184         (info_print_command_completer): Declare.
2185         * stack.c (_initialize_stack): Add completer for 'info locals' and
2186         'info args'.
2187         * symtab.c (_initialize_symtab): Add completer for 'info
2188         variables' and 'info functions'.
2189         * NEWS: Mention completion for additional info commands.
2190
2191 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * cli/cli-utils.c (extract_info_print_args): Delete.
2194         (extract_arg_maybe_quoted): Delete.
2195         (info_print_options_defs): New variable.
2196         (make_info_print_options_def_group): New function.
2197         (extract_info_print_options): Define new function.
2198         * cli/cli-utils.h (extract_info_print_args): Delete.
2199         (struct info_print_options): New structure.
2200         (extract_info_print_options): Declare new function.
2201         * stack.c (info_locals_command): Update to use new
2202         extract_info_print_options, also add a header comment.
2203         (info_args_command): Likewise.
2204         * symtab.c (info_variables_command): Likewise.
2205         (info_functions_command): Likewise.
2206
2207 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2210         to extract string arguments.
2211         * common/common-utils.c (extract_string_maybe_quoted): New function.
2212         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2213
2214 2019-07-11  Tom Tromey  <tromey@adacore.com>
2215
2216         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2217         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2218         * top.h (gdbinit): Don't declare.
2219         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2220         into...
2221         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2222         * top.c (gdb_init): Don't call init_cli_cmds.
2223         (gdbinit): Remove.
2224         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2225
2226 2019-07-11  Tom Tromey  <tromey@adacore.com>
2227
2228         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2229         after it has been moved.
2230
2231 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2232
2233         * valops.c (value_must_coerce_to_target): Change return type to
2234         bool.
2235         * value.h (value_must_coerce_to_target): Likewise.
2236
2237 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2238
2239         * breakpoint.c (is_hardware_watchpoint): Remove
2240         forward-declaration.
2241         (is_masked_watchpoint): Change return type to bool.
2242         (is_tracepoint): Likewise.
2243         (is_breakpoint): Likewise.
2244         (is_hardware_watchpoint): Likewise.
2245         (is_watchpoint): Likewise.
2246         (is_no_memory_software_watchpoint): Likewise.
2247         (is_catchpoint): Likewise.
2248         (breakpoint_1): Make FILTER parameter's return type bool.
2249         is_masked_watchpoint): Change return type to bool.
2250         (save_breakpoints): Make FILTER parameter's return type bool.
2251         * breakpoint.h (is_breakpoint): Change return type to bool.
2252         (is_watchpoint): Likewise.
2253         (is_catchpoint): Likewise.
2254         (is_tracepoint): Likewise.
2255
2256 2019-07-10  Tom Tromey  <tom@tromey.com>
2257
2258         * defs.h: Don't include gdbarch.h.
2259         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2260         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2261         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2262         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2263         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2264         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2265         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2266         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2267         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2268         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2269         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2270         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2271         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2272         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2273         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2274         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2275         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2276         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2277         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2278         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2279         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2280         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2281         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2282         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2283         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2284         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2285         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2286
2287 2019-07-10  Tom Tromey  <tromey@adacore.com>
2288
2289         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2290         * breakpoint.c (init_ada_exception_breakpoint): Register as
2291         bp_catchpoint.
2292         (print_one_breakpoint_location, print_one_breakpoint): Use
2293         is_ada_exception_catchpoint.
2294         * ada-lang.c (class ada_catchpoint_location): Pass
2295         bp_loc_software_breakpoint to bp_location constructor.
2296         (is_ada_exception_catchpoint): New function.
2297
2298 2019-07-10  Tom Tromey  <tromey@adacore.com>
2299
2300         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2301         VEC.
2302         (struct arm_exidx_entry): New method operator<.
2303         (struct arm_exidx_data) <section_maps>: Change type.
2304         (arm_exidx_data_free): Remove.
2305         (arm_exidx_data_key): Change type.  Move lower.
2306         (arm_exidx_new_objfile): Update.
2307         (arm_compare_exidx_entries): Remove.
2308         (arm_find_exidx_entry, _initialize_arm_tdep)
2309
2310 2019-07-10  Tom Tromey  <tromey@adacore.com>
2311
2312         * solib-spu.c (ocl_program_data_key): Change type.
2313         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2314         Update.
2315
2316 2019-07-10  Tom Tromey  <tromey@adacore.com>
2317
2318         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2319         (struct solib_aix_inferior_data) <library_list>: Change type.
2320         (solib_aix_inferior_data_handle): Change type.
2321         (get_solib_aix_inferior_data): Update.
2322         (solib_aix_free_library_list): Remove.
2323         (library_list_start_library): Update.
2324         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2325         return type.
2326         (solib_aix_get_library_list)
2327         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2328         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2329
2330 2019-07-10  Tom Tromey  <tromey@adacore.com>
2331
2332         * solib-dsbt.c (struct dsbt_info): Add initializers.
2333         (solib_dsbt_pspace_data): Change type.
2334         (dsbt_pspace_data_cleanup): Remove.
2335         (get_dsbt_info, _initialize_dsbt_solib): Update.
2336
2337 2019-07-10  Tom Tromey  <tromey@adacore.com>
2338
2339         * spu-tdep.c (spu_overlay_data): Change type.
2340         (spu_get_overlay_table, spu_overlay_new_objfile)
2341         (_initialize_spu_tdep): Update.
2342
2343 2019-07-10  Tom Tromey  <tromey@adacore.com>
2344
2345         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2346         destructor.
2347         (dbx_objfile_data_key): Change type and declare later.
2348         (DBX_SYMFILE_INFO): Rewrite.
2349         * dbxread.c (dbx_objfile_data_key): Change type.
2350         (dbx_symfile_init): Update.
2351         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2352         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2353         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2354
2355 2019-07-10  Tom Tromey  <tromey@adacore.com>
2356
2357         * jit.c (jit_program_space_key): Change type.  Move lower.
2358         (get_jit_program_space_data): Update.
2359         (jit_program_space_data_cleanup): Remove.
2360         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2361         Update.
2362         (struct jit_program_space_data): Add initializers.
2363
2364 2019-07-10  Tom Tromey  <tromey@adacore.com>
2365
2366         * solib-darwin.c (struct darwin_info): Add initializers.
2367         (solib_darwin_pspace_data): Change type.
2368         (darwin_pspace_data_cleanup): Remove.
2369         (get_darwin_info, _initialize_darwin_solib): Update.
2370
2371 2019-07-10  Tom Tromey  <tromey@adacore.com>
2372
2373         * remote-sim.c (struct sim_inferior_data): Add initializers,
2374         constructor, and destructor.
2375         (sim_inferior_data_key): Change type.  Move lower.
2376         (check_for_duplicate_sim_descriptor): Update.
2377         (get_sim_inferior_data): Use new.  Update.
2378         (~sim_inferior_data_cleanup): Rename from
2379         sim_inferior_data_cleanup.  Simplify.
2380         (gdbsim_close_inferior, simulator_command)
2381         (sim_command_completer, _initialize_remote_sim): Update.
2382         (next_pid, INITIAL_PID): Move earlier.
2383
2384 2019-07-10  Tom Tromey  <tromey@adacore.com>
2385
2386         * python/python-internal.h (create_thread_object): Return
2387         gdbpy_ref.
2388         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2389         * python/py-inferior.c (struct threadlist_entry): Add
2390         constructor.
2391         <thread_obj>: Now a gdbpy_ref.
2392         (thread_to_thread_object): Update.
2393         (add_thread_object): Use new.
2394         (delete_thread_object): Use delete.
2395         (infpy_threads): Update.
2396         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2397         GIL.
2398
2399 2019-07-10  Tom Tromey  <tromey@adacore.com>
2400
2401         * valops.c (value_cast): Specialize error message for Ada.
2402
2403 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2404
2405         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2406
2407 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2408
2409         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2410         bpstat_should_step): Return bool, adjust comments.
2411         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2412         bpstat_should_step): Likewise.
2413
2414 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2415
2416         * features/Makefile: Use feature target descriptions for Arm.
2417         * features/arm/arm-core.c: Generate new file.
2418         * features/arm/arm-fpa.c: Likewise.
2419         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2420         * features/arm/arm-m-profile.c: Likewise.
2421         * features/arm/arm-vfpv2.c: Likewise.
2422         * features/arm/arm-vfpv3.c: Likewise.
2423         * features/arm/xscale-iwmmxt.c: Likewise.
2424         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2425
2426 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2427
2428         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2429         ptrace earlier.
2430
2431 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2432
2433         * features/aarch64-pauth.c: Regenerate.
2434
2435 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2436
2437         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2438         bool.
2439         (bpstat_what): Use false instead of 0.
2440
2441 2019-07-09  Pedro Alves  <palves@redhat.com>
2442
2443         * break-catch-throw.c (is_exception_catchpoint): New.
2444         * breakpoint.c (print_one_breakpoint_location): New parameter
2445         'raw_loc'.  Handle it.  Use
2446         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2447         looking at the breakpoint's type.
2448         (print_one_breakpoint): If handling "maint info breakpoints", also
2449         print locations of exception catchpoints.
2450         * breakpoint.h (is_exception_catchpoint): Declare.
2451
2452 2019-07-09  Pedro Alves  <palves@redhat.com>
2453
2454         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2455         "addr" field.
2456         (allocate_location_exception_catchpoint): New.
2457         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2458         (initialize_throw_catchpoint_ops): Install
2459         allocate_location_exception_catchpoint as allocate_location
2460         method.
2461         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2462         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2463         bp_loc_other.
2464         (breakpoint_address_is_meaningful): Delete.
2465         (bl_address_is_meaningful): New.
2466         (breakpoint_locations_match): Adjust comment.
2467         (bp_location_from_bp_type): New, factored out of...
2468         (bp_location::bp_location(breakpoint *)): ... this.
2469         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2470         factored out of...
2471         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2472         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2473         breakpoint_address_is_meaningful.
2474         (bp_locations_compare): Adjust comment.
2475         (update_global_location_list): Use bl_address_is_meaningful
2476         instead of breakpoint_address_is_meaningful.
2477         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2478         explicit.
2479         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2480         * python/py-breakpoint.c (bppy_get_location): No longer check
2481         whether location is null.
2482
2483 2019-07-09  Pedro Alves  <palves@redhat.com>
2484
2485         PR c++/15468
2486         * breakpoint.c (print_one_breakpoint_location): Remove
2487         single-location assert.
2488
2489 2019-07-09  Tom Tromey  <tom@tromey.com>
2490
2491         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2492         * configure: Rebuild.
2493         * configure.ac: Change common to gdbsupport.
2494         * gdbsupport: Rename from common.
2495         * acinclude.m4: Change common to gdbsupport.
2496         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2497         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2498         gdbsupport.
2499         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2500         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2501         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2502         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2503         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2504         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2505         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2506         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2507         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2508         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2509         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2510         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2511         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2512         coff-pe-read.c, command.h, compile/compile-c-support.c,
2513         compile/compile-c.h, compile/compile-cplus-symbols.c,
2514         compile/compile-cplus-types.c, compile/compile-cplus.h,
2515         compile/compile-loc2c.c, compile/compile.c, completer.c,
2516         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2517         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2518         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2519         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2520         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2521         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2522         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2523         features/aarch64-core.c, features/aarch64-fpu.c,
2524         features/aarch64-pauth.c, features/aarch64-sve.c,
2525         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2526         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2527         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2528         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2529         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2530         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2531         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2532         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2533         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2534         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2535         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2536         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2537         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2538         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2539         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2540         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2541         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2542         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2543         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2544         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2545         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2546         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2547         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2548         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2549         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2550         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2551         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2552         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2553         minsyms.c, mips-linux-tdep.c, namespace.h,
2554         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2555         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2556         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2557         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2558         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2559         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2560         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2561         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2562         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2563         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2564         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2565         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2566         procfs.c, producer.c, progspace.h, psymtab.h,
2567         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2568         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2569         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2570         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2571         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2572         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2573         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2574         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2575         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2576         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2577         target-memory.c, target.c, target.h, target/waitstatus.c,
2578         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2579         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2580         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2581         unittests/array-view-selftests.c,
2582         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2583         unittests/common-utils-selftests.c,
2584         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2585         unittests/format_pieces-selftests.c,
2586         unittests/function-view-selftests.c,
2587         unittests/lookup_name_info-selftests.c,
2588         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2589         unittests/mkdir-recursive-selftests.c,
2590         unittests/observable-selftests.c,
2591         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2592         unittests/parse-connection-spec-selftests.c,
2593         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2594         unittests/scoped_fd-selftests.c,
2595         unittests/scoped_mmap-selftests.c,
2596         unittests/scoped_restore-selftests.c,
2597         unittests/string_view-selftests.c, unittests/style-selftests.c,
2598         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2599         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2600         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2601         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2602         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2603         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2604
2605 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2608         bool value.
2609         (decode_digits_ordinary): Set explicit_line field in sal.
2610         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2611         symtab_and_line that was set on an explicit line number in
2612         assembler code.  Do always update the recorded symtab and line if
2613         we do skip the prologue.
2614
2615 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2616
2617         * breakpoint.c (set_breakpoint_location_function): Remove
2618         explicit_loc parameter.
2619         (momentary_breakpoint_from_master): Update call to
2620         set_breakpoint_location_function.
2621         (add_location_to_breakpoint): Likewise.
2622
2623 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2624
2625         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2626         required features based on default bfd type when no specific bfd
2627         is present.
2628
2629 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2630
2631         * NEWS: Mention that GDB printf and eval commands can now print
2632         C-style and Ada-style convenience var strings without
2633         calling the inferior.
2634         * printcmd.c (printf_c_string): Locally print GDB internal var
2635         instead of transiting via the inferior.
2636         (printf_wide_c_string): Likewise.
2637
2638 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2639
2640         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2641
2642 2019-07-04  Tom Tromey  <tom@tromey.com>
2643
2644         PR tui/24724:
2645         * tui/tui-winsource.c (tui_clear_source_content): Update.
2646         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2647         (tui_update_breakpoint_info): Update.
2648         (tui_set_exec_info_content): Update.
2649         * tui/tui-source.c (tui_set_source_content_nil): Update.
2650         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2651         has_break.
2652         * tui/tui-data.h (enum tui_bp_flag): New.
2653         (tui_bp_flags): New enum flags type.
2654         (struct tui_source_element) <break_mode>: Change type.  Rename
2655         from has_break.
2656         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2657         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2658         constants.
2659         * tui/tui-winsource.h: Fix comment.
2660
2661 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2662
2663         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2664         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2665         (store_fpregs_to_thread)
2666         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2667         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2668         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2669         (IWMMXT_REGS_SIZE): Add define.
2670         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2671         (fetch_vfp_regs, store_vfp_regs)
2672         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2673         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2674
2675 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2676
2677         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2678         defines.
2679         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2680         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2681         (ARM_INT_REGISTER_SIZE): ...to this.
2682         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2683         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2684         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2685         (arm_linux_collect_gregset, supply_nwfpe_register)
2686         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2687         defines.
2688         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2689         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2690         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2691         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2692         (arm_return_in_memory, arm_store_return_value)
2693         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2694         (arm_record_ld_st_multiple): Likewise.
2695         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2696         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2697
2698 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2699
2700         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2701         AARCH64_DISPLACED_MODIFIED_INSNS.
2702         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2703         (aarch64_displaced_step_copy_insn): Likewise.
2704         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2705         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2706         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2707         ARM_DISPLACED_MODIFIED_INSNS.
2708         * arm-tdep.c (arm_gdbarch_init): Likewise.
2709         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2710         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2711         (struct arm_displaced_step_closure): Use
2712         ARM_DISPLACED_MODIFIED_INSNS.
2713
2714 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2715
2716         * features/Makefile: Remove unused xml files.
2717         * features/aarch64.xml: Remove.
2718         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2719         * features/i386/amd64-avx-avx512.xml: Remove.
2720         * features/i386/amd64-avx-linux.xml: Remove.
2721         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2722         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2723         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2724         * features/i386/amd64-avx-mpx.xml: Remove.
2725         * features/i386/amd64-avx.xml: Remove.
2726         * features/i386/amd64-linux.xml: Remove.
2727         * features/i386/amd64-mpx-linux.xml: Remove.
2728         * features/i386/amd64-mpx.xml: Remove.
2729         * features/i386/amd64.xml: Remove.
2730         * features/i386/i386-avx-avx512-linux.xml: Remove.
2731         * features/i386/i386-avx-avx512.xml: Remove.
2732         * features/i386/i386-avx-linux.xml: Remove.
2733         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2734         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2735         * features/i386/i386-avx-mpx-linux.xml: Remove.
2736         * features/i386/i386-avx-mpx.xml: Remove.
2737         * features/i386/i386-avx.xml: Remove.
2738         * features/i386/i386-linux.xml: Remove.
2739         * features/i386/i386-mmx-linux.xml: Remove.
2740         * features/i386/i386-mmx.xml: Remove.
2741         * features/i386/i386-mpx-linux.xml: Remove.
2742         * features/i386/i386-mpx.xml: Remove.
2743         * features/i386/i386.xml: Remove.
2744         * features/i386/x32-avx-avx512-linux.xml: Remove.
2745         * features/i386/x32-avx-linux.xml: Remove.
2746         * features/i386/x32-linux.xml: Remove.
2747
2748 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2749
2750         * regformats/aarch64.dat: Remove.
2751         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2752         * regformats/i386/amd64-avx-linux.dat: Remove.
2753         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2754         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2755         * regformats/i386/amd64-linux.dat: Remove.
2756         * regformats/i386/amd64-mpx-linux.dat: Remove.
2757         * regformats/i386/amd64.dat: Remove.
2758         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2759         * regformats/i386/i386-avx-linux.dat: Remove.
2760         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2761         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2762         * regformats/i386/i386-linux.dat: Remove.
2763         * regformats/i386/i386-mmx-linux.dat: Remove.
2764         * regformats/i386/i386-mpx-linux.dat: Remove.
2765         * regformats/i386/i386.dat: Remove.
2766         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2767         * regformats/i386/x32-avx-linux.dat: Remove.
2768         * regformats/i386/x32-linux.dat: Remove.
2769
2770 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2771
2772         * aarch64-tdep.c: Remove xml self tests.
2773         * amd64-linux-tdep.c: Likewise.
2774         * amd64-tdep.c: Likewise.
2775         * i386-linux-tdep.c: Likewise.
2776         * i386-tdep.c: Likewise.
2777
2778 2019-07-03  Pedro Alves  <palves@redhat.com>
2779
2780         PR cli/24732
2781         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2782         (pipe_cmd_option_defs): New.
2783         (make_pipe_cmd_options_def_group): New.
2784         (pipe_command): Use gdb::option::process_options.
2785         (pipe_command_completer): New function.
2786         (_initialize_cli_cmds): Install completer for "pipe" command.
2787
2788 2019-07-03  Pedro Alves  <palves@redhat.com>
2789
2790         * cli/cli-option.c (union option_value) <string>: New field.
2791         (struct option_def_and_value): Add ctor, move ctor, dtor and
2792         use DISABLE_COPY_AND_ASSIGN.
2793         (option_def_and_value::clear_value): New.
2794         (parse_option, save_option_value_in_ctx, get_val_type_str)
2795         (add_setshow_cmds_for_options): Handle var_string.
2796         * cli-option.h (union option_def::var_address) <string>: New
2797         field.
2798         (struct string_option_def): New.
2799         * maint-test-options.c (struct test_options_opts): Add default
2800         ctor and use DISABLE_COPY_AND_ASSIGN.
2801         <string_opt>: New field.
2802         (test_options_opts::~test_options_opts): New.
2803         (test_options_opts::dump): Also dump "-string".
2804         (test_options_option_defs): Install "string.
2805
2806 2019-07-03  Pedro Alves  <palves@redhat.com>
2807
2808         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2809         option_value with a null enumeration.
2810         (complete_options): Save the option values in the context.
2811         (save_option_value_in_ctx): New, factored out from ...
2812         (process_options): ... here.
2813         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2814         of the function.
2815         * maint-test-options.c (test_options_opts::dump): New, factored
2816         out from ...
2817         (maintenance_test_options_command_mode): ... here.
2818         (maintenance_test_options_command_completion_result): Delete.
2819         (maintenance_test_options_command_completion_text): Update
2820         comment.
2821         (maintenance_show_test_options_completion_result): Change
2822         prototype.  Just print
2823         maintenance_test_options_command_completion_text.
2824         (save_completion_result): New.
2825         (maintenance_test_options_completer_mode): Pass options context to
2826         complete_options, and then save a dump.
2827         (_initialize_maint_test_options): Use add_cmd to install "maint
2828         show test-options-completion-result".
2829
2830 2019-07-03  Pedro Alves  <palves@redhat.com>
2831
2832         * NEWS (New commands): Mention "with" and "maint with".
2833         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2834         (with_command, with_command_completer): New.
2835         (pipe_command): Adjust to new repeat_previous
2836         interface.
2837         (_initialize_cli_cmds): Install the "with" command and its "w"
2838         alias.
2839         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2840         declarations.
2841         * cli/cli-setshow.c (parse_cli_var_uinteger)
2842         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2843         argument strings for all var_types.
2844         (get_setshow_command_value_string): New, factored out from ...
2845         (do_show_command): ... this.
2846         * cli/cli-setshow.h: Include <string>.
2847         (get_setshow_command_value_string): Declare.
2848         * command.h (repeat_previous): Now returns const char *.  Adjust
2849         comment.
2850         * maint.c: Include "cli/cli-cmds.h".
2851         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2852         (_initialize_maint_cmds): Register the "maintenance with" command.
2853         * top.c (repeat_previous): Move bits from pipe_command here:
2854         Return the saved command line, if any; error out if there's no
2855         command to relaunch.
2856
2857 2019-07-03  Pedro Alves  <palves@redhat.com>
2858
2859         * NEWS (New commands): Mention "maint set/show test-settings"
2860         instead of "maint test-settings".
2861         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2862         (maintenance_test_settings_set_list): Rename to ...
2863         (maintenance_set_test_settings_list): ... this.
2864         (maintenance_test_settings_show_list): Rename to  ...
2865         (maintenance_show_test_settings_list): ... this.
2866         (maintenance_test_settings_cmd): Delete.
2867         (maintenance_test_settings_set_cmd): ...
2868         (maintenance_set_test_settings_cmd): ... this.
2869         (maintenance_test_settings_show_cmd): ...
2870         (maintenance_show_test_settings_cmd): ... this.
2871         (maintenance_test_settings_show_value_cmd):
2872         (maintenance_show_test_settings_value_cmd): ... this.
2873         (_initialize_maint_test_settings): No longer install the "maint
2874         test-settings" prefix command.  Rename "maint test-settings set"
2875         to "maint set test-settings", and "maint test-settings show" to
2876         "maint show test-settings".  Adjust all subcommands.
2877
2878 2019-07-03  Pedro Alves  <palves@redhat.com>
2879
2880         * maint-test-settings.c: Fix file's intro comment.  Replace all
2881         references to "test-options" with references to "test-settings",
2882         in comments.
2883
2884 2019-07-03  Pedro Alves  <palves@redhat.com>
2885
2886         * maint-test-settings.c (maintenance_test_settings_xxx)
2887         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2888         New.
2889         (maintenance_test_settings_enums): Use them.
2890         (maintenance_test_settings_enum): Default to
2891         maintenance_test_settings_xxx.
2892         (_initialize_maint_test_settings): Initialize
2893         MAINTENANCE_TEST_SETTINGS_FILENAME.
2894
2895 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2896
2897         * breakpoint.h (remove_breakpoints_inf): Change return type to
2898         void, move function documentation here.
2899         * breakpoint.c (remove_breakpoints_inf): Change return type to
2900         void, move function documentation to header.
2901
2902 2019-07-02  Pedro Alves  <palves@redhat.com>
2903
2904         * NEWS (Completion improvements): Mention "info threads".
2905         * thread.c (struct info_threads_opts, info_threads_option_defs)
2906         (make_info_threads_options_def_group): New.
2907         (info_threads_command): Use gdb::option::process_options.
2908         (info_threads_command_completer): New.
2909         (_initialize_thread): Use gdb::option::build_help to build the
2910         help text for "info threads".
2911
2912 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2913
2914         * defs.h (generic_load): Move from here...
2915         * symfile.h (generic_load): ... to here.  Rename name parameter
2916         to args.
2917         * symfile.c (generic_load): Add comment.
2918
2919 2019-07-01  Tom Tromey  <tromey@adacore.com>
2920
2921         * dwarf2read.c
2922         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2923         declaration of without_params.  Fix formatting.
2924
2925 2019-07-01  Tom Tromey  <tromey@adacore.com>
2926
2927         * ada-exp.y (find_primitive_type): Update.
2928         * ada-lang.h (ada_lookup_symbol): Update.
2929         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2930         parameter.
2931         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2932
2933 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2934
2935         PR breakpoints/24541
2936         * gdbarch.c: Regenerate.
2937         * gdbarch.h: Regenerate.
2938         * gdbarch.sh: Add 'stap_adjust_register'.
2939         * i386-tdep.c: Include '<unordered_set>'.
2940         (i386_stap_adjust_register): New function.
2941         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2942         * stap-probe.c (stap_parse_register_operand): Call
2943         'gdbarch_stap_adjust_register'.
2944
2945 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2946
2947         PR python/24742
2948         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2949         * python/python.c (do_start_initialization): Use 'xmalloc'
2950         instead of 'PyMem_Malloc'.
2951
2952 2019-06-28  Tom Tromey  <tromey@adacore.com>
2953
2954         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2955         for Ada.
2956
2957 2019-06-27  Tom Tromey  <tromey@adacore.com>
2958
2959         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2960         objfile_key.
2961         (arm_find_mapping_symbol, arm_record_special_symbol)
2962         (_initialize_arm_tdep): Update.
2963         (arm_objfile_data_free): Remove.
2964
2965 2019-06-27  Tom Tromey  <tromey@adacore.com>
2966
2967         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2968         to cp_print_static_field.
2969
2970 2019-06-26  Tom Tromey  <tromey@adacore.com>
2971
2972         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2973         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2974         declare.
2975
2976 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2977
2978         * features/aarch64-core.c (create_feature_aarch64_core):
2979         Regenerate.
2980         * features/aarch64-core.xml: Add cpsr flags.
2981
2982 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2983
2984         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2985         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2986
2987 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2988
2989         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2990         field.
2991         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2992         use.
2993         (arm_record_special_symbol): Don't insert new symbol in sorted
2994         position, push it at the end.
2995
2996 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2997
2998         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2999         (arm_mapping_symbol_s): Remove.
3000         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3001         (arm_mapping_symbol_vec): New typedef.
3002         (struct arm_per_objfile): Add constructor.
3003         <section_maps>: Change type to
3004         std::unique_ptr<arm_mapping_symbol_vec[]>.
3005         (arm_compare_mapping_symbols): Remove.
3006         (arm_find_mapping_symbol): Adjust to section_maps type change.
3007         (arm_objfile_data_free): Call delete on arm_per_objfile.
3008         (arm_record_special_symbol): Adjust to section_maps type change.
3009         Allocate arm_per_objfile with new.
3010
3011 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3012
3013         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3014         with the command prefix.
3015
3016 2019-06-25  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3019         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3020
3021 2019-06-25  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3024         type.
3025         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3026         protected.
3027
3028 2019-06-25  Tom Tromey  <tom@tromey.com>
3029
3030         * tui/tui-winsource.c
3031         (tui_source_window_base::set_is_exec_point_at): Add check against
3032         LOA_ADDRESS.
3033
3034 2019-06-25  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui-source.c (tui_set_source_content): Don't check before
3037         xfree.
3038         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-winsource.h (tui_update_source_window_as_is)
3043         (tui_alloc_source_buffer, tui_line_is_displayed)
3044         (tui_addr_is_displayed): Change type of win_info.
3045         * tui/tui-winsource.c (tui_update_source_window_as_is)
3046         (tui_clear_source_content, tui_show_source_line)
3047         (tui_show_source_content, tui_source_window_base::refill)
3048         (tui_source_window_base::set_is_exec_point_at)
3049         (tui_source_window_base::set_is_exec_point_at)
3050         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3051         (tui_alloc_source_buffer, tui_line_is_displayed)
3052         (tui_addr_is_displayed): Change type of win_info.  Update.
3053         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3054         (tui_source_window_base::do_make_visible_with_new_height):
3055         Update.
3056         * tui/tui-source.c (tui_set_source_content)
3057         (tui_set_source_content_nil)
3058         (tui_source_window::do_scroll_vertical): Update.
3059         * tui/tui-layout.c (show_layout): Update.
3060         * tui/tui-disasm.c (tui_set_disassem_content)
3061         (tui_disasm_window::do_scroll_vertical): Update.
3062         * tui/tui-data.h (tui_win_content): Remove.
3063         (struct tui_gen_win_info) <content, content_size>: Remove.
3064         (struct tui_source_element): Add initializers and destructor.
3065         (union tui_which_element, struct tui_win_element): Remove.
3066         (struct tui_source_window_base) <content>: New field.
3067         (struct tui_data_window): Remove destructor.
3068         (tui_alloc_content, tui_free_win_content)
3069         (tui_free_all_source_wins_content): Don't declare.
3070         * tui/tui-data.c (tui_initialize_static_data): Update.
3071         (init_content_element, tui_alloc_content): Remove.
3072         (~tui_gen_win_info): Update.
3073         (~tui_data_window, tui_free_all_source_wins_content)
3074         (tui_free_win_content, free_content, free_content_elements):
3075         Remove.
3076
3077 2019-06-25  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-winsource.h (tui_clear_source_content)
3080         (tui_erase_source_content, tui_show_source_content): Change type
3081         of win_info.
3082         * tui/tui-winsource.c (tui_clear_source_content)
3083         (tui_erase_source_content, tui_show_source_content): Change type
3084         of win_info.
3085         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3086         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3087         win_info.
3088         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3089         win_info.
3090         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-winsource.c (tui_clear_source_content)
3095         (tui_source_window_base::set_is_exec_point_at): Update.
3096         * tui/tui-source.c (tui_set_source_content_nil): Update.
3097         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3098         a bool.
3099         * tui/tui-data.c (init_content_element): Update.
3100
3101 2019-06-25  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3104         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3105         * tui/tui-layout.c (init_and_make_win): Update.
3106         * tui/tui.h (enum tui_win_type): Update.
3107         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3108         tui_win_is_auxillary.
3109         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3110         tui_win_is_auxillary.
3111
3112 2019-06-25  Tom Tromey  <tom@tromey.com>
3113
3114         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3115         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3116         (tui_delete_data_content_windows, tui_display_all_data)
3117         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3118         Update.
3119         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3120         * tui/tui-regs.c (tui_last_regs_line_no)
3121         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3122         (tui_show_registers): Update.
3123         (tui_show_register_group): Return void.  Update.
3124         (tui_display_registers_from, tui_display_reg_element_at_line)
3125         (tui_display_registers_from_line, tui_check_register_values):
3126         Update.
3127         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3128         member.
3129         (struct tui_data_window) <regs_content>: Now a std::vector.
3130         <regs_content_count>: Remove.
3131         (tui_add_content_elements, tui_free_data_content): Don't declare.
3132         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3133         (init_content_element): Remove DATA_WIN case.  Add assert.
3134         (tui_add_content_elements): Remove.
3135         (tui_data_window): Update.
3136         (tui_free_data_content): Remove.
3137         (free_content_elements): Remove DATA_WIN case.
3138
3139 2019-06-25  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-data.c (tui_data_item_window): Update.
3142         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3143         * tui/tui-windata.c (tui_display_all_data)
3144         (tui_display_data_from_line): Update.
3145         (tui_check_data_values): Remove.
3146         * tui/tui-regs.c (tui_show_register_group)
3147         (tui_display_reg_element_at_line): Update.
3148         * tui/tui-hooks.c (tui_register_changed)
3149         (tui_refresh_frame_and_register_information): Call
3150         tui_check_register_values.
3151         * tui/tui-data.h (struct tui_data_window) <data_content,
3152         data_content_count, data_type>: Remove.
3153         (enum tui_data_type): Remove.
3154
3155         * tui/tui-data.c (tui_data_window::clear_detail)
3156         (~tui_data_window): Update.
3157
3158 2019-06-25  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3161         declare.
3162         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3163         Rename from tui_first_data_item_displayed.  Update.
3164         (tui_data_window::refresh_all)
3165         (tui_data_window::do_scroll_vertical): Update.
3166         * tui/tui-data.h (struct tui_data_window)
3167         <first_data_item_displayed>: Declare new method.
3168
3169 2019-06-25  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3172         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3173         contents...
3174         (tui_initialize_static_data): ...here.
3175
3176 2019-06-25  Tom Tromey  <tom@tromey.com>
3177
3178         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3179         (tui_display_registers_from, tui_check_register_values): Update.
3180         (tui_display_register): Remove win_info parameter; update.
3181         (tui_get_register): Change type of parameters.
3182         * tui/tui-data.h (struct tui_data_element): Remove.
3183         (union tui_which_element) <data>: Remove.
3184         <data_window>: Change type.
3185         (struct tui_data_item_window): New.
3186         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3187         case.  Add assert.
3188         (~tui_data_item_window): New destructor.
3189         (free_content_elements): Remove DATA_ITEM_WIN case.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3194         Remove.
3195
3196 2019-06-25  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-data.h (struct tui_command_element): Remove.
3199         (union tui_which_element) <command>: Remove.
3200         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3201         assert.
3202         (free_content_elements): Remove CMD_WIN case.
3203
3204 2019-06-25  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-layout.c (tui_set_layout): Update.
3207         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3208         * tui/tui-data.c (layout_def): Update.
3209
3210 2019-06-25  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3213         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3214         (tui_source_window_base::set_new_height): Update.
3215         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3216         Update.
3217         (tui_set_locator_fullname, tui_set_locator_info)
3218         (tui_show_frame_info): Update.
3219         * tui/tui-source.c (tui_set_source_content)
3220         (tui_source_is_displayed): Update.
3221         * tui/tui-layout.c (show_source_disasm_command, show_data)
3222         (show_source_or_disasm_and_command): Update.
3223         * tui/tui-disasm.c (tui_set_disassem_content)
3224         (tui_get_begin_asm_address): Update.
3225         * tui/tui-data.h (struct tui_locator_element): Remove.
3226         (union tui_which_element) <locator>: Remove.
3227         (struct tui_locator_window): New.
3228         (tui_locator_win_info_ptr): Change return type.
3229         * tui/tui-data.c (_locator): Change type.
3230         (tui_locator_win_info_ptr): Change return type.
3231         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3232         (tui_alloc_content): Add assert.
3233
3234 2019-06-25  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-winsource.c
3237         (tui_exec_info_window::maybe_allocate_content): New method.
3238         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3239         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3240         (make_source_or_disasm_window): Add cast.
3241         * tui/tui-data.h (union tui_which_element) <simple_string>:
3242         Remove.
3243         (struct tui_source_info): New.
3244         (struct tui_source_window_base) <execution_info>: Change type.
3245         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3246         case, and add assert.
3247         (tui_alloc_content): Add assert.
3248
3249 2019-06-25  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3252         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3253         * tui/tui-data.c (tui_alloc_win_info): Remove.
3254
3255 2019-06-25  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3258         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3259         can_highlight.
3260
3261 2019-06-25  Tom Tromey  <tom@tromey.com>
3262
3263         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3264         make_visible_with_new_height method.
3265         (tui_win_info::make_visible_with_new_height): New method.
3266         (tui_source_window_base::do_make_visible_with_new_height)
3267         (tui_data_window::do_make_visible_with_new_height)
3268         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3269         (make_visible_with_new_height): Remove.
3270         (tui_resize_all, tui_adjust_win_heights): Use
3271         make_visible_with_new_height method.
3272         * tui/tui-data.h (struct tui_win_info)
3273         <do_make_visible_with_new_height, make_visible_with_new_height>:
3274         New methods.
3275         (struct tui_source_window_base, struct tui_data_window)
3276         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3277         methods.
3278
3279 2019-06-25  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3282         method.
3283         (update_tab_width): Call update_tab_width method.
3284         * tui/tui-data.h (struct tui_win_info)
3285         (struct tui_source_window_base) <update_tab_width>: New methods.
3286
3287 2019-06-25  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3290         parameter.
3291         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3292         parameter.
3293         (tui_gen_win_info::make_visible): Update.
3294         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3295         parameter.
3296         * tui/tui-data.h (enum tui_box): New enum.
3297         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3298
3299 2019-06-25  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3302         init_and_make_win for EXEC_INFO_WIN.
3303         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3304         longer inline.
3305         (struct tui_win_info) <~tui_win_info>: Inline.
3306         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3307         Don't declare.
3308         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3309         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3310         Remove.
3311         (tui_initialize_static_data): Update.
3312         (~tui_gen_win_info): Handle more cleanup here.
3313         (~tui_source_window_base): Delete "execution_info".
3314         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3315
3316 2019-06-25  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-layout.c (make_command_window): Don't set
3319         can_highlight.
3320         (show_source_disasm_command): Call the reset method.
3321         (show_data): Don't set can_highlight.  Call the reset method.
3322         (tui_gen_win_info::reset): Rename from init_gen_win_info
3323         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3324         (show_source_or_disasm_and_command): Call the reset method.
3325         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3326         (struct tui_cmd_window): Set can_highlight.
3327
3328 2019-06-25  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3331         from make_visible.
3332         (tui_make_visible, tui_make_invisible): Rewrite.
3333         (tui_win_info::make_visible): Remove.
3334         (tui_source_window_base::make_visible): Update.
3335         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3336         method.  Moved from...
3337         (struct tui_win_info) <make_visible>: ...here.
3338
3339 2019-06-25  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-winsource.c
3342         (tui_source_window_base::do_scroll_horizontal): Remove direction
3343         parameter.
3344         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3345         direction parameter.
3346         * tui/tui-win.c (tui_win_info::forward_scroll)
3347         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3348         (tui_win_info::right_scroll): Update.
3349         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3350         direction parameter.
3351         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3352         direction parameter.
3353         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3354         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3355         Remove direction parameter.
3356         (struct tui_source_window_base, struct tui_source_window)
3357         (struct tui_disasm_window, struct tui_data_window)
3358         (struct tui_cmd_window): Update.
3359
3360 2019-06-25  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui-winsource.h (tui_set_exec_info_content)
3363         (tui_show_exec_info_content, tui_erase_exec_info_content)
3364         (tui_clear_exec_info_content, tui_update_exec_info): Change
3365         argument to tui_source_window_base.
3366         * tui/tui-winsource.c (tui_set_exec_info_content)
3367         (tui_show_exec_info_content, tui_erase_exec_info_content)
3368         (tui_clear_exec_info_content, tui_update_exec_info): Change
3369         argument to tui_source_window_base.
3370
3371 2019-06-25  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3374         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3375
3376 2019-06-25  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3379         check.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3384         type to void.
3385         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3386         type to void.
3387         * tui/tui-source.c (tui_set_source_content): Update.
3388         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3389
3390 2019-06-25  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-win.c (window_name_completer, tui_set_focus)
3393         (tui_all_windows_info): Use name method.
3394         * tui/tui-data.h (struct tui_gen_win_info)
3395         (struct tui_source_window, struct tui_disasm_window)
3396         (struct tui_data_window, struct tui_cmd_window) <name>: New
3397         method.
3398         (tui_win_name): Don't declare.
3399         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3400         (tui_win_name): Remove.
3401
3402 2019-06-25  Tom Tromey  <tom@tromey.com>
3403
3404         * tui/tui-winsource.h (tui_update_source_window)
3405         (tui_update_source_window_as_is): Change parameter type.
3406         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3407         to be a tui_source_window_base.
3408         (tui_update_source_window_as_is): Likewise.
3409         * tui/tui-win.c (make_visible_with_new_height): Update.
3410
3411 2019-06-25  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-winsource.c (tui_erase_source_content)
3414         (tui_show_source_content, tui_show_exec_info_content)
3415         (tui_erase_exec_info_content): Use refresh_window method.
3416         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3417         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3418         from tui_refresh_win.
3419         (tui_data_window::refresh_window): New method.
3420         (tui_win_info::refresh, tui_source_window_base::refresh)
3421         (tui_refresh_all): Use refresh_window method.
3422         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3423         method.
3424         * tui/tui-regs.c (tui_display_register): Call refresh_window
3425         method.
3426         * tui/tui-layout.c (show_source_disasm_command)
3427         (show_source_or_disasm_and_command): Call refresh_window method.
3428         * tui/tui-data.h (struct tui_gen_win_info)
3429         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3430         New method.
3431
3432 2019-06-25  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui.c (tui_rl_other_window, tui_enable)
3435         (tui_is_window_visible, tui_get_command_dimension): Update.
3436         * tui/tui-winsource.c (tui_update_source_window_as_is)
3437         (tui_clear_source_content, tui_erase_source_content)
3438         (tui_show_source_line, tui_source_window_base::refill)
3439         (tui_source_window_base::do_scroll_horizontal)
3440         (tui_source_window_base::set_is_exec_point_at)
3441         (tui_update_breakpoint_info, tui_set_exec_info_content)
3442         (tui_alloc_source_buffer, tui_line_is_displayed)
3443         (tui_addr_is_displayed): Update.
3444         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3445         (tui_check_and_display_highlight_if_needed)
3446         (tui_win_info::make_visible, tui_win_info::refresh)
3447         (tui_refresh_all): Update.
3448         * tui/tui-windata.c (tui_first_data_item_displayed)
3449         (tui_delete_data_content_windows, tui_erase_data_content)
3450         (tui_display_all_data, tui_data_window::refresh_all)
3451         (tui_check_data_values): Update.
3452         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3453         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3454         (tui_win_info::backward_scroll, tui_refresh_all_win)
3455         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3456         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3457         (tui_source_window_base::set_new_height)
3458         (tui_data_window::set_new_height)
3459         (make_invisible_and_set_new_height)
3460         (make_visible_with_new_height, new_height_ok)
3461         (parse_scrolling_args): Update.
3462         * tui/tui-stack.c (tui_show_frame_info): Update.
3463         * tui/tui-source.c (tui_set_source_content)
3464         (tui_set_source_content_nil, tui_source_is_displayed)
3465         (tui_source_window::do_scroll_vertical): Update.
3466         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3467         (tui_display_registers_from, tui_display_reg_element_at_line)
3468         (tui_check_register_values, tui_reg_command): Update.
3469         * tui/tui-layout.c (tui_default_win_height)
3470         (show_source_disasm_command, show_data, init_and_make_win)
3471         (show_source_or_disasm_and_command): Update.
3472         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3473         (tui_redisplay_readline, tui_mld_flush)
3474         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3475         (tui_getc): Update.
3476         * tui/tui-disasm.c (tui_set_disassem_content)
3477         (tui_disasm_window::do_scroll_vertical): Update.
3478         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3479         Now virtual.
3480         (struct tui_win_info): Derive from tui_gen_win_info.
3481         <~tui_win_info>: Mark as override.
3482         <generic>: Remove member.
3483         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3484         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3485         (~tui_data_window, ~tui_win_info)
3486         (tui_free_all_source_wins_content): Update.
3487         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3488
3489 2019-06-25  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-layout.c (init_and_make_win): Use new.
3492         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3493         destructor, initializers.
3494         (tui_alloc_generic_win_info): Don't declare.
3495         * tui/tui-data.c (_locator): Add argument to constructor.
3496         (source_win, disasm_win): New globals.
3497         (exec_info): Remove.
3498         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3499         Update.
3500         (tui_alloc_generic_win_info): Remove.
3501         (init_content_element): Use new.
3502         (tui_win_info::tui_win_info): Update.
3503         (free_content_elements) <case DATA_WIN>: Use delete.
3504
3505 2019-06-25  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3508         * tui/tui-windata.c (tui_first_data_item_displayed)
3509         (tui_delete_data_content_windows): Update.
3510         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3511         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3512         (tui_display_registers_from, tui_check_register_values): Update.
3513         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3514         pointer.
3515         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3516         window.
3517         (tui_free_data_content): Update.
3518         (free_content_elements) <case DATA_WIN>: Free the window.
3519
3520 2019-06-25  Tom Tromey  <tom@tromey.com>
3521
3522         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3523         Update.
3524         * tui/tui-layout.c (make_command_window)
3525         (show_source_disasm_command, show_data, init_and_make_win)
3526         (show_source_or_disasm_and_command): Update.
3527         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3528         method.
3529         <can_highight, is_highlighted>: Now bool.
3530         (tui_set_win_highlight): Don't declare.
3531         * tui/tui-data.c (tui_set_win_highlight): Remove.
3532
3533 2019-06-25  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-wingeneral.c (make_visible): Remove check of window
3536         type.
3537
3538 2019-06-25  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-win.c (tui_win_info::max_height)
3541         (tui_cmd_window::max_height): New methods.
3542         (new_height_ok): Call max_height.
3543         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3544         <max_height>: New method.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-win.c (tui_source_window_base::set_new_height)
3549         (tui_data_window::set_new_height): New methods.
3550         (make_invisible_and_set_new_height): Call set_new_height method.
3551         * tui/tui-data.h (struct tui_win_info)
3552         (struct tui_source_window_base, struct tui_data_window)
3553         <set_new_height>: New method.
3554
3555 2019-06-25  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3558         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3559         tui_refresh_data_win.
3560         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3561         method.
3562         (tui_refresh_all_win): Call the refresh_all method.
3563         (tui_set_focus): Likewise.
3564         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3565         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3566         Likewise.
3567
3568 2019-06-25  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-winsource.h (tui_refill_source_window)
3571         (tui_set_is_exec_point_at): Don't declare.
3572         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3573         (tui_source_window_base::refill): Rename from
3574         tui_refill_source_window.
3575         (tui_source_window_base::do_scroll_horizontal): Update.
3576         (tui_source_window_base::set_is_exec_point_at): Rename from
3577         tui_set_is_exec_point_at.
3578         (tui_update_all_breakpoint_info): Update.
3579         * tui/tui-stack.c (tui_show_frame_info): Update.
3580         * tui/tui-layout.c (show_data): Add cast.
3581         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3582         * tui/tui-data.h (struct tui_source_window_base) <refill,
3583         set_is_exec_point_at>: New methods.
3584         (tui_source_windows, tui_add_to_source_windows): Update types.
3585         (tui_add_to_source_windows): Remove redundant declaration.
3586         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3587         (tui_source_windows): Change return type.
3588         (tui_clear_source_windows_detail): Update.
3589         (tui_add_to_source_windows): Change type of parameter.
3590         (tui_free_all_source_wins_content): Update.
3591
3592 2019-06-25  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-wingeneral.c (tui_win_info::refresh)
3595         (tui_source_window_base::refresh): New methods.
3596         (tui_refresh_all): Call the refresh method.
3597         * tui/tui-data.h (struct tui_win_info)
3598         (struct tui_source_window_base) <refresh>: New method.
3599
3600 2019-06-25  Tom Tromey  <tom@tromey.com>
3601
3602         * tui/tui.h (tui_is_window_visible): Return bool.
3603         * tui/tui.c (tui_is_window_visible): Return bool.
3604         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3605         (tui_make_visible, tui_make_invisible)
3606         (tui_win_info::make_visible)
3607         (tui_source_window_base::make_visible, make_all_visible)
3608         (tui_make_all_visible, tui_make_all_invisible): Update.
3609         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3610         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3611         bool.
3612         (struct tui_win_info, struct tui_source_window_base)
3613         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3614         * tui/tui-data.c (tui_init_generic_part): Update.
3615
3616 2019-06-25  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3619         (tui_source_window_base::make_visible): New methods.
3620         (make_all_visible): Make method call.
3621         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3622         (struct tui_source_window_base, struct tui_cmd_window): Override
3623         make_visible.
3624         (tui_win_is_source_type): Don't declare.
3625         * tui/tui-data.c (tui_win_is_source_type): Remove.
3626
3627 2019-06-25  Tom Tromey  <tom@tromey.com>
3628
3629         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3630         NULL check.
3631
3632 2019-06-25  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3635         Inline constructor.  Add initializers for members.
3636         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3637         constructors; now inline in class.
3638
3639 2019-06-25  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-regs.c (tui_show_registers): Update.
3642         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3643         bool.
3644         * tui/tui-data.c (tui_data_window::clear_detail)
3645         (tui_data_window): Update.
3646
3647 2019-06-25  Tom Tromey  <tom@tromey.com>
3648
3649         * tui/tui-windata.c (tui_display_all_data)
3650         (tui_display_data_from_line, tui_display_data_from)
3651         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3652         Update.
3653         * tui/tui-regs.c (tui_last_regs_line_no)
3654         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3655         (tui_show_registers, tui_show_register_group)
3656         (tui_display_registers_from, tui_display_reg_element_at_line)
3657         (tui_display_registers_from_line, tui_check_register_values)
3658         (tui_reg_next, tui_reg_prev): Update.
3659         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3660         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3661         tui_data_window.
3662         (struct tui_win_info) <detail>: Remove.  Add new fields from
3663         tui_data_info.
3664         (TUI_DATA_WIN): Add cast.
3665         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3666         (~tui_data_window): Simplify.
3667
3668 2019-06-25  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-layout.c (show_source_disasm_command)
3671         (show_source_or_disasm_and_command): Update.
3672         * tui/tui-io.c (update_cmdwin_start_line)
3673         (tui_redisplay_readline): Update.
3674         * tui/tui-data.h (struct tui_command_info): Remove.
3675         (struct tui_win_info) <detail>: Remove command_info member.
3676         (struct tui_data_window) <start_line>: New member, from
3677         tui_command_info.
3678         (TUI_CMD_WIN): Add casts.
3679
3680 2019-06-25  Tom Tromey  <tom@tromey.com>
3681
3682         * tui/tui-winsource.c (tui_update_source_window)
3683         (tui_refill_source_window)
3684         (tui_source_window_base::do_scroll_horizontal)
3685         (tui_update_breakpoint_info, tui_set_exec_info_content)
3686         (tui_show_exec_info_content, tui_erase_exec_info_content)
3687         (tui_clear_exec_info_content): Update.
3688         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3689         Update.
3690         * tui/tui-win.c (make_invisible_and_set_new_height)
3691         (make_visible_with_new_height): Update.
3692         * tui/tui-source.c (tui_set_source_content)
3693         (tui_show_symtab_source): Update.
3694         * tui/tui-layout.c (extract_display_start_addr)
3695         (show_source_disasm_command, show_data)
3696         (make_source_or_disasm_window)
3697         (show_source_or_disasm_and_command): Update.
3698         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3699         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3700         "gdbarch".
3701         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3702         to tui_source_window_base.
3703         (struct tui_win_info) <detail>: Remove source_info member.
3704         (struct tui_source_window_base) <has_locator>: Inline.
3705         Move contents from tui_source_info; rename has_locator member to
3706         m_has_locator.
3707         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3708         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3709         header file.
3710         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3711         Simplify.
3712         (tui_free_all_source_wins_content): Cast to
3713         tui_source_window_base.
3714
3715 2019-06-25  Tom Tromey  <tom@tromey.com>
3716
3717         * tui/tui-win.c (make_invisible_and_set_new_height)
3718         (make_visible_with_new_height): Call has_locator method.
3719         * tui/tui-layout.c (show_source_disasm_command, show_data)
3720         (show_source_or_disasm_and_command): Update for bool change.
3721         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3722         (tui_win_info) <has_locator>: New method.
3723         (struct tui_source_window_base) <has_locator>: New method.
3724         (tui_win_has_locator): Don't declare.
3725         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3726         from tui_win_has_locator.
3727         (tui_source_window_base): Use false, not FALSE.
3728
3729 2019-06-25  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3732         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3733         clear_detail method directly.
3734         (tui_clear_win_detail): Remove.
3735
3736 2019-06-25  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3739         "this", not TUI_DISASM_WIN.
3740
3741 2019-06-25  Tom Tromey  <tom@tromey.com>
3742
3743         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3744         declare.
3745         * tui/tui-winsource.c
3746         (tui_source_window_base::do_scroll_horizontal): Rename from
3747         tui_horizontal_source_scroll.
3748         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3749         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3750         from tui_vertical_data_scroll.
3751         * tui/tui-win.h (tui_scroll): Don't declare.
3752         * tui/tui-win.c (tui_win_info::forward_scroll)
3753         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3754         (tui_win_info::right_scroll): Rename and update.
3755         (tui_scroll_forward_command, tui_scroll_backward_command)
3756         (tui_scroll_left_command, tui_scroll_right_command): Update.
3757         (tui_scroll): Remove.
3758         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3759         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3760         from tui_vertical_source_scroll.
3761         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3762         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3763         from tui_vertical_disassem_scroll.
3764         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3765         do_scroll_horizontal>: New methods.
3766         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3767         Likewise.
3768         (struct tui_source_window_base): Add do_scroll_horizontal.
3769         (struct tui_source_window, struct tui_disasm_window): Add
3770         do_scroll_vertical.
3771         (struct tui_data_window, struct tui_cmd_window): Add
3772         do_scroll_horizontal and do_scroll_vertical.
3773         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3774
3775 2019-06-25  Tom Tromey  <tom@tromey.com>
3776
3777         * tui/tui-data.h (struct tui_source_window_base): New struct.
3778         (struct tui_source_window): Derive from tui_source_window_base.
3779         (struct tui_disasm_window): New struct.
3780         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3781         from tui_source_window::clear_detail.
3782         (tui_source_window_base): Rename from tui_source_window.
3783         (~tui_source_window_base): Rename from ~tui_source_window.
3784         (tui_alloc_win_info): Create a tui_disasm_window.
3785
3786 2019-06-25  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-data.h (struct tui_source_window)
3789         (struct tui_data_window): Declare destructors.
3790         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3791         destructors.
3792         (tui_win_info): Simplify.
3793
3794 2019-06-25  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-winsource.c (tui_display_main)
3797         (tui_update_source_windows_with_addr)
3798         (tui_update_all_breakpoint_info): Update.
3799         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3800         (new_height_ok, parse_scrolling_args): Update.
3801         * tui/tui-stack.c (tui_show_frame_info): Update.
3802         * tui/tui-data.h (struct tui_list): Remove.
3803         (tui_source_windows): Return a reference to a std::vector.
3804         * tui/tui-data.c (source_windows): Now a std::vector.
3805         (tui_source_windows): Change return type.
3806         (tui_clear_source_windows): Rewrite.
3807         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3808         (tui_free_all_source_wins_content): Rewrite.
3809
3810 2019-06-25  Tom Tromey  <tom@tromey.com>
3811
3812         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3813         (struct tui_data_window, struct tui_cmd_window): Declare
3814         clear_detail method.
3815         * tui/tui-data.c (tui_source_window::clear_detail)
3816         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3817         methods.
3818         (tui_clear_win_detail): Simplify.
3819
3820 2019-06-25  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-layout.c (make_source_window, make_disasm_window)
3823         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3824         Return the new window.
3825         (show_source_disasm_command, show_data)
3826         (show_source_or_disasm_and_command): Update.
3827
3828 2019-06-25  Tom Tromey  <tom@tromey.com>
3829
3830         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3831         parameter.  Return the new window.
3832         (show_source_disasm_command): Update and remove NULL check.
3833         (show_source_or_disasm_and_command): Update.
3834
3835 2019-06-25  Tom Tromey  <tom@tromey.com>
3836
3837         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3838
3839 2019-06-25  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-data.h (struct tui_win_info): Make constructor
3842         protected.  Make destructor virtual.  Add initializers.
3843         (tui_source_window, tui_data_window, tui_cmd_window): New
3844         classes.
3845         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3846         constructor.  Add "type" parameter.
3847         (tui_source_window, tui_data_window, tui_cmd_window): New
3848         constructors.
3849         (tui_alloc_win_info): Instantiate the appropriate subclass.
3850
3851 2019-06-25  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-win.c (tui_resize_all): Use delete.
3854         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3855         destructor.
3856         (tui_free_window): Don't declare.
3857         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3858         Update.
3859
3860 2019-06-25  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-data.h (struct tui_win_info): Add constructor.
3863         * tui/tui-data.c (tui_alloc_win_info): Use new.
3864         (tui_free_window): Use delete.
3865
3866 2019-06-22  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3869         declare.
3870         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3871
3872 2019-06-22  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3875         declare.
3876         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3877
3878 2019-06-22  Tom de Vries  <tdevries@suse.de>
3879
3880         * dwarf2read.c (create_addrmap_from_aranges)
3881         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3882         instead of '%zu'.
3883
3884 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3885
3886         * dwarf2read.h (dwarf2_section_info_def): Remove.
3887         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3888         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3889         std::vector<dwarf2_section_info>.
3890         (struct dwo_file) <~dwo_file>: Remove.
3891         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3892         types field.
3893         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3894         (dwarf2_read_debug_names): Likewise.
3895         (create_debug_types_hash_table): Change parameter type to
3896         array_view, adjust code accordingly.
3897         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3898         (partial_die_info::fixup): Likewise.
3899         (determine_prefix): Likewise.
3900         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3901
3902 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3903
3904         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3905         gdb_bfd_ref_ptr.
3906         <~dwo_file>: Remove call to gdb_bfd_unref.
3907         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3908         gdb_bfd_ref_ptr::get.
3909
3910 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3911
3912         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3913         type to htab_up.
3914         * dwarf2read.c (struct dwo_file): Initialize fields.
3915         <~dwo_file>: New.
3916         (free_dwo_file): Remove, move content to ~dwo_file.
3917         (struct dwo_file_deleter): Remove.
3918         (dwo_file_up>: Remove custom deleter.
3919         (free_dwo_files): Remove.
3920         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3921         dwo_files.
3922         (process_skeletonless_type_units): Call unique_ptr::get.
3923         (allocate_dwo_file_hash_table): Add deleter to created hash
3924         table.  Change return type to htab_up.
3925         (lookup_dwo_file_slot): Don't memset dwo_file, call
3926         unique_ptr::get.
3927         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3928         (create_dwo_unit_in_dwp_v2): Likewise.
3929         (open_and_init_dwo_file): Likewise.
3930         (free_dwo_file_from_slot): Remove.
3931
3932 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3933
3934         * dwarf2read.h (struct dwarf2_section_info) <readin,
3935         is_virtual>: Change type to bool.
3936         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3937         true instead of 1.
3938
3939 2019-06-19  Tom Tromey  <tom@tromey.com>
3940
3941         * tui/tui-data.h (tui_init_content_element): Don't declare.
3942
3943 2019-06-19  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-data.h (tui_init_win_info): Don't declare.
3946
3947 2019-06-19  Tom de Vries  <tdevries@suse.de>
3948
3949         * dwarf2read.h (abstract_to_concrete): Change type to
3950         std::unordered_map<sect_offset, std::vector<sect_offset>,
3951         gdb::hash_enum<sect_offset>>.
3952
3953 2019-06-19  Tom Tromey  <tromey@adacore.com>
3954
3955         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3956         EVAL_AVOID_SIDE_EFFECTS specially.
3957
3958 2019-06-19  Tom Tromey  <tromey@adacore.com>
3959
3960         * source-cache.c (highlighter): New global.
3961         (source_cache::get_source_lines): Create a highlighter on demand.
3962
3963 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * defs.h (deprecated_interactive_hook): Delete declaration.
3966         * interps.c (clear_interpreter_hooks): Remove use of
3967         deprecated_interactive_hook.
3968         * top.c (deprecated_interactive_hook): Delete definition.
3969         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3970
3971 2019-06-18  Tom de Vries  <tdevries@suse.de>
3972
3973         PR gdb/24515
3974         * dwarf2read.h (abstract_to_concrete): Change type from
3975         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3976         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3977         * dwarf2read.c (read_variable): Update.
3978         (dwarf2_fetch_die_loc_sect_off): Update.
3979
3980 2019-06-17  Tom de Vries  <tdevries@suse.de>
3981
3982         PR gdb/24617
3983         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3984         accessing parent[parent_len - 1].
3985
3986 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3987
3988         PR gdb/24364
3989         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3990         call dtrace_process_dof with NULL dof.
3991
3992 2019-06-16  Tom de Vries  <tdevries@suse.de>
3993
3994         PR gdb/24445
3995         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3996
3997 2019-06-16  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4000         (make_all_visible): Use address of member.
4001
4002 2019-06-16  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4005         (tui_free_window, free_content, free_content_elements): Remove
4006         unnecessary cast.
4007         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4008         cast.
4009         * tui/tui-regs.c (tui_show_register_group)
4010         (tui_display_registers_from, tui_display_reg_element_at_line):
4011         Remove unnecessary cast.
4012
4013 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4014
4015         * linux-nat.c (normal_mask): Delete.
4016         (_initialize_linux_nat): Don't initialise normal_mask.
4017
4018 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4019
4020         PR gdb/24445
4021         * dwarf-index-write.h (write_psymtabs_to_index): Add
4022         dwz_basename parameter.
4023         * dwarf-index-write.c (write_gdbindex): Move file writing to
4024         write_gdbindex_1.  Change return type void.
4025         (assert_file_size): Move up, remove filename parameter.
4026         (write_gdbindex_1): New function.
4027         (write_debug_names): Change return type to void, call
4028         assert_file_size.
4029         (struct index_wip_file): New struct.
4030         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4031         file logic to index_wip_file.  Write index for dwz file if
4032         needed.
4033         (save_gdb_index_command): Pass basename of dwz file, if present.
4034         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4035         build-id of dwz file, if present.
4036         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4037         (dwarf2_get_dwz_file): Likewise.
4038         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4039         (dwarf2_get_dwz_file): Likewise.
4040
4041 2019-06-16  Tom Tromey  <tom@tromey.com>
4042
4043         * coffread.c (process_coff_symbol): Use xstrdup.
4044         * value.c (create_internalvar): Use xstrdup.
4045
4046 2019-06-16  Tom Tromey  <tom@tromey.com>
4047
4048         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4049         * breakpoint.c (stopin_command, stopat_command)
4050         (until_break_command, decode_location_default): Remove unnecessary
4051         cast.
4052         * utils.c (subset_compare): Remove unnecessary cast.
4053         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4054         cast.
4055         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4056         cast.
4057         * infcmd.c (path_command): Remove unnecessary cast.
4058         * coffread.c (decode_type): Remove unnecessary cast.
4059         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4060         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4061         * tui/tui-stack.c (tui_show_locator_content)
4062         (tui_show_frame_info): Remove unnecessary cast.
4063         * tui/tui-win.c (tui_scroll_forward_command)
4064         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4065         (parse_scrolling_args): Remove unnecessary cast.
4066         * tui/tui-data.c (init_win_info, tui_del_window)
4067         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4068         (free_content_elements): Remove unnecessary cast.
4069         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4070         unnecessary cast.
4071         * tui/tui-source.c (tui_set_source_content)
4072         (tui_vertical_source_scroll): Remove unnecessary cast.
4073         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4074         cast.
4075         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4076         * tui/tui-regs.c (tui_display_registers_from)
4077         (tui_display_register): Remove unnecessary cast.
4078         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4079         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4080         (make_visible): Remove unnecessary cast.
4081         * tui/tui-winsource.c (tui_erase_source_content)
4082         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4083         unnecessary cast.
4084         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4085         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4086         * stabsread.c (read_type, read_array_type, read_range_type):
4087         Remove unnecessary cast.
4088         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4089         (parse_symbol, parse_type, upgrade_type, parse_external)
4090         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4091         unnecessary cast.
4092         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4093
4094 2019-06-16  Tom Tromey  <tom@tromey.com>
4095
4096         * tui/tui-data.c (tui_alloc_generic_win_info)
4097         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4098         checks.
4099
4100 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4101             Andrew Burgess  <andrew.burgess@embecosm.com>
4102
4103         * f-typeprint.c (f_print_type): Don't return early for not
4104         associated or not allocated types.
4105         (f_type_print_varspec_suffix): Add print_rank parameter and print
4106         ranks of array types in case they dangling.
4107         (f_type_print_base): Add print_rank parameter.
4108
4109 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4110
4111         * NEWS: Mention new MI commands.
4112         * break-catch-throw.c (enum exception_event_kind): Move to
4113         breakpoint.h.
4114         (print_mention_exception_catchpoint): Output text as a single
4115         message.
4116         (catch_exception_command_1): Rename to...
4117         (catch_exception_event): ...this, make non-static, update header
4118         command, and change some parameter types.
4119         (catch_catch_command): Update for changes to
4120         catch_exception_command_1.
4121         (catch_throw_command): Likewise.
4122         (catch_rethrow_command): Likewise.
4123         * breakpoint.c (enum exception_event_kind): Delete.
4124         * breakpoint.h (enum exception_event_kind): Moved here from
4125         break-catch-throw.c.
4126         (catch_exception_event): Declare.
4127         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4128         (mi_cmd_catch_throw): New function.
4129         (mi_cmd_catch_rethrow): New function.
4130         (mi_cmd_catch_catch): New function.
4131         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4132         'catch-catch' entries.
4133         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4134         (mi_cmd_catch_rethrow): Declare.
4135         (mi_cmd_catch_catch): Declare.
4136
4137 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * annotate.c (annotate_source_line): Change return type to void,
4140         update implementation to match.
4141         * annotate.h (annotate_source_line): Change return type to void,
4142         update header comment.
4143         * stack.c (print_frame_info): Don't change what frame information
4144         is printed based on whether annotations are on or not.
4145
4146 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4149         (annotate_source): Make static.
4150         (annotate_source_line): Moved from source.c and renamed from
4151         identify_source_line.  Update the return type.
4152         * annotate.h (annotate_source): Delete declaration.
4153         (annotate_source_line): Declaration moved from source.h, and
4154         renamed from identify_source_line.  Return type updated.
4155         * source.c (identify_source_line): Moved to annotate.c and renamed
4156         to annotate_source_line.
4157         (info_line_command): Remove check of annotation_level.
4158         * source.h (identify_source_line): Move declaration to annotate.h
4159         and rename to annotate_source_line.
4160         * stack.c: Add 'annotate.h' include.
4161         (print_frame_info): Remove check of annotation_level before
4162         calling annotate_source_line.
4163
4164 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * source-cache.c (source_cache::get_plain_source_lines): Use
4167         open_source_file_with_line_charpos instead of just
4168         open_source_file, remove call to find_source_lines.
4169         (source_cache::get_source_lines): Likewise.
4170         * source.c (find_source_lines): Make static.
4171         (get_filename_and_charpos): Renamed into...
4172         (open_source_file_with_line_charpos): ..this along with changes to
4173         return a scoped_fd, and some other minor clean ups.
4174         (identify_source_line): Use open_source_file_with_line_charpos.
4175         (search_command_helper): Use open_source_file_with_line_charpos
4176         instead of just open_source_file, remove call to
4177         find_source_lines.
4178         * source.h (open_source_file_with_line_charpos): Declare new
4179         function.
4180         (find_source_lines): Delete declaration.
4181
4182 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4183
4184         * source.c (get_filename_and_charpos): Remove fullname
4185         parameter.
4186         (identify_source_line): Update call to get_filename_and_charpos.
4187
4188 2019-06-14  Tom Tromey  <tromey@adacore.com>
4189
4190         PR gdb/24502:
4191         * ui-style.h (skip_ansi_escape): Update comment.
4192         * ui-file.h (class no_terminal_escape_file): New class.
4193         * ui-file.c (no_terminal_escape_file::write)
4194         (no_terminal_escape_file::puts): New methods.
4195         * cli/cli-logging.c (handle_redirections): Use
4196         no_terminal_escape_file.
4197
4198 2019-06-14  Tom Tromey  <tromey@adacore.com>
4199
4200         * NEWS: Move convenience variable news above Python news.
4201
4202 2019-06-14  Tom Tromey  <tom@tromey.com>
4203
4204         * gnulib: Move directory to top-level.
4205         * configure.ac: Don't configure gnulib.
4206         * configure: Rebuild.
4207         * common/common-defs.h: Use new path to gnulib.
4208         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4209         (GNULIB_H): Remove.
4210         (INCGNU): Look in new gnulib location.
4211         (HFILES_NO_SRCDIR): Remove gnulib files.
4212         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4213         (generated_files): Remove GNULIB_H.
4214         ($(LIBGNU), all-lib): Remove targets.
4215         (distclean): Don't mention GNULIB_BUILDDIR.
4216         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4217
4218 2019-06-14  Tom Tromey  <tromey@adacore.com>
4219
4220         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4221         Warn if symbol file does not provide any symbols.
4222
4223 2019-06-14  Tom Tromey  <tromey@adacore.com>
4224
4225         * source.c (find_and_open_source): Respect basenames_may_differ.
4226
4227 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * annotate.c (annotate_breakpoints_invalid): Make use of
4230         scoped_restore_terminal_state.
4231         (annotate_frames_invalid): Likewise.
4232
4233 2019-06-14  Tom Tromey  <tromey@adacore.com>
4234
4235         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4236         allow assignment to an internalvar.
4237
4238 2019-06-14  Tom Tromey  <tromey@adacore.com>
4239
4240         * ada-lex.l: Allow "_" in attribute names.
4241
4242 2019-06-14  Tom Tromey  <tromey@adacore.com>
4243
4244         PR gdb/24653:
4245         * regcache.c (registers_changed): Don't call alloca.
4246         * top.c (execute_command): Don't call alloca.
4247
4248 2019-06-13  Pedro Alves  <palves@redhat.com>
4249
4250         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4251         'expression'.  When parsing an expression, error out if there's
4252         junk after "unlimited".
4253         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4254         (do_set_command): Adjust calls to is_unlimited_literal.
4255
4256 2019-06-13  Pedro Alves  <palves@redhat.com>
4257
4258         * compile/compile.c (make_compile_options_def_group): Add braces
4259         around array_view initializer.
4260         * thread.c (make_thread_apply_all_options_def_group)
4261         (make_thread_apply_all_options_def_group): Likewise.
4262
4263 2019-06-13  Pedro Alves  <palves@redhat.com>
4264
4265         * NEWS (New commands): Mention "maint test-options
4266         require-delimiter", "maint test-options unknown-is-error", "maint
4267         test-options unknown-is-operand" and "maint show
4268         test-options-completion-result".
4269         (New command options, command completion): New section.
4270         (Completion improvements): New section.
4271         Mention that you can abbreviate "unlimited".
4272
4273 2019-06-13  Pedro Alves  <palves@redhat.com>
4274
4275         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4276         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4277         * unittests/cli-utils-selftests.c (test_parse_flags)
4278         (test_parse_flags_qcs): Delete.
4279         (test_cli_utils): Don't call deleted functions.
4280
4281 2019-06-13  Pedro Alves  <palves@redhat.com>
4282
4283         * thread.c: Include "cli/cli-option.h".
4284         (tp_array_compar_ascending): Global.
4285         (tp_array_compar): Delete function.
4286         (tp_array_compar_ascending, tp_array_compar_descending): New
4287         functions.
4288         (ascending_option_def, qcs_flag_option_def)
4289         (thr_qcs_flags_option_defs)
4290         (make_thread_apply_all_options_def_group)
4291         (make_thread_apply_options_def_group): New.
4292         (thread_apply_all_command): Use gdb::option::process_options.
4293         (thread_apply_command_completer)
4294         (thread_apply_all_command_completer): New.
4295         (thread_apply_command): Use gdb::option::process_options.
4296         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4297         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4298         to generate help text of "thread apply".  Adjust "taas"'s help.
4299         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4300         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4301
4302 2019-06-13  Pedro Alves  <palves@redhat.com>
4303
4304         * thread.c (thread_apply_command): Check for invalid TID with
4305         isdigit instead of !isalpha.
4306
4307 2019-06-13  Pedro Alves  <palves@redhat.com>
4308
4309         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4310         (validate_flags_qcs): New.
4311         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4312         (validate_flags_qcs): Declare.
4313         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4314         (make_frame_apply_options_def_group): New.
4315         (frame_apply_command_count): Process options with
4316         gdb::option::process_options.
4317         (frame_apply_completer): New.
4318         (frame_apply_level_completer, frame_apply_all_completer)
4319         (frame_apply_completer): New.
4320         (_initialize_stack): Update help of "frame apply", "frame apply
4321         level", "frame apply all" and "faas" to mention supported options
4322         and install command completers.
4323         * stack.h (frame_apply_all_completer): Declare.
4324         * thread.c: Include "stack.h".
4325         (tfaas_command): Add "--".
4326         (_initialize_thread): Update help "tfaas" to mention supported
4327         options and install command completer.
4328
4329 2019-06-13  Pedro Alves  <palves@redhat.com>
4330
4331         * completer.c (complete_nested_command_line): New.
4332         (gdb_completion_word_break_characters_throw): Add assertion.
4333         * completer.h (complete_nested_command_line): Declare.
4334
4335 2019-06-13  Pedro Alves  <palves@redhat.com>
4336
4337         * stack.c (parse_backtrace_qualifiers): New.
4338         (backtrace_command): Use it.
4339         (backtrace_command_completer): Complete on qualifiers.
4340
4341 2019-06-13  Pedro Alves  <palves@redhat.com>
4342
4343         * frame.c: Include "cli/cli-option.h.
4344         (user_set_backtrace_options): New.
4345         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4346         Delete.
4347         (get_prev_frame): Adjust.
4348         (boolean_option_def, uinteger_option_def)
4349         (set_backtrace_option_defs): New.
4350         (_initialize_frame): Adjust and use
4351         gdb::option::add_setshow_cmds_for_options to install "set
4352         backtrace past-main" and "set backtrace past-entry".
4353         * frame.h: Include "cli/cli-option.h".
4354         (struct frame_print_options): Forward declare.
4355         (print_frame_arguments_all, print_frame_arguments_scalars)
4356         (print_frame_arguments_none): Declare.
4357         (print_entry_values): Delete declaration.
4358         (struct frame_print_options, user_frame_print_options): New.
4359         (struct set_backtrace_options): New.
4360         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4361         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4362         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4363         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4364         (list_args_or_locals): Add frame_print_options parameter.
4365         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4366         * python/py-framefilter.c (enumerate_args): Pass down
4367         USER_FRAME_PRINT_OPTIONS.
4368         * stack.c: Include "cli/cli-option.h".
4369         (print_frame_arguments_all, print_frame_arguments_scalars)
4370         (print_frame_arguments_none): Declare.
4371         (print_raw_frame_arguments, print_entry_values): Delete.
4372         (user_frame_print_options): New.
4373         (boolean_option_def, enum_option_def, frame_print_option_defs):
4374         New.
4375         (struct backtrace_cmd_options): New.
4376         (bt_flag_option_def): New.
4377         (backtrace_command_option_defs): New.
4378         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4379         (print_frame_arg, read_frame_arg, print_frame_args)
4380         (print_frame_info, print_frame): Add frame_print_options parameter
4381         and use it.
4382         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4383         (backtrace_command_1): Add frame_print_options and
4384         backtrace_cmd_options parameters and use them.
4385         (make_backtrace_options_def_group): New.
4386         (backtrace_command): Process command options with
4387         gdb::option::process_options.
4388         (backtrace_command_completer): New.
4389         (_initialize_stack): Extend "backtrace"'s help to mention
4390         supported options.  Install completer for "backtrace".
4391         Install some settings commands with add_setshow_cmds_for_options.
4392
4393 2019-06-13  Pedro Alves  <palves@redhat.com>
4394
4395         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4396         and that "set/show print raw frame-arguments" are now deprecated.
4397
4398         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4399         command.
4400         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4401         * stack.c (_initialize_stack): Install "set/show print
4402         raw-frame-arguments", and deprecate "set/show print raw
4403         frame-arguments".
4404         * valprint.c (_initialize_valprint): Deprecate "set/show print
4405         raw".
4406
4407 2019-06-13  Pedro Alves  <palves@redhat.com>
4408
4409         * compile/compile.c (struct compile_options): New.
4410         (compile_flag_option_def, compile_command_option_defs)
4411         (make_compile_options_def_group): New.
4412         (compile_file_command): Handle options with
4413         gdb::option::process_options.
4414         (compile_file_command_completer): New function.
4415         (compile_code_command): Handle options with
4416         gdb::option::process_options.
4417         (compile_code_command_completer): New function.
4418         (_initialize_compiler): Install completers for "compile code" and
4419         "compile file".  Mention available options in "compile code" and
4420         "compile code"'s help.
4421         * completer.c (advance_to_completion_word): New, factored out from
4422         ...
4423         (advance_to_expression_complete_word_point): ... this.
4424         (advance_to_filename_complete_word_point): New.
4425         * completer.h (advance_to_filename_complete_word_point): New
4426         declaration.
4427
4428 2019-06-13  Pedro Alves  <palves@redhat.com>
4429
4430         * compile/compile.c: Include "cli/cli-option.h".
4431         (compile_print_value): Scope data pointer is now a
4432         value_print_options pointer; adjust.
4433         (compile_print_command): Process options.  Scope data pointer is
4434         now a value_print_options pointer; adjust.
4435         (_initialize_compile): Update "compile print"'s help to include
4436         supported options.  Install a completer for "compile print".
4437         * cp-valprint.c (show_vtblprint, show_objectprint)
4438         (show_static_field_print): Delete.
4439         (_initialize_cp_valprint): Don't install "set print
4440         static-members", "set print vtbl", "set print object" here.
4441         * printcmd.c: Include "cli/cli-option.h" and
4442         "common/gdb_optional.h".
4443         (print_command_parse_format): Rework to fill in a
4444         value_print_options instead of a format_data.
4445         (print_value): Change parameter type from format_data pointer to
4446         value_print_options reference.  Adjust.
4447         (print_command_1): Process options.  Adjust to pass down a
4448         value_print_options.
4449         (print_command_completer): New.
4450         (_initialize_printcmd): Install print_command_completer as
4451         handle_brkchars completer for the "print" command.  Update
4452         "print"'s help to include supported options.
4453         * valprint.c: Include "cli/cli-option.h".
4454         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4455         here from cp-valprint.c.
4456         (boolean_option_def, uinteger_option_def)
4457         (value_print_option_defs, make_value_print_options_def_group):
4458         New.  Use gdb::option::add_setshow_cmds_for_options to install
4459         "set print elements", "set print null-stop", "set print repeats",
4460         "set print pretty", "set print union", "set print array", "set
4461         print address", "set print symbol", "set print array-indexes".
4462         * valprint.h: Include <string> and "cli/cli-option.h".
4463         (make_value_print_options_def_group): Declare.
4464         (print_value): Change parameter type from format_data pointer to
4465         value_print_options reference.
4466         (print_command_completer): Declare.
4467
4468 2019-06-13  Pedro Alves  <palves@redhat.com>
4469
4470         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4471         (COMMON_SFILES): Add maint-test-settings.c.
4472         * cli/cli-decode.c (boolean_enums): New global, factored out from
4473         ...
4474         (add_setshow_boolean_cmd): ... here.
4475         * cli/cli-decode.h (boolean_enums): Declare.
4476         * cli/cli-option.c: New file.
4477         * cli/cli-option.h: New file.
4478         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4479         factored out from ...
4480         (parse_cli_boolean_value(const char *)): ... this.
4481         (is_unlimited_literal): Change parameter type to pointer to
4482         pointer.  Adjust and advance ARG pointer.
4483         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4484         (parse_cli_var_enum): New, factored out from ...
4485         (do_set_command): ... this.  Adjust.
4486         * cli/cli-setshow.h (parse_cli_boolean_value)
4487         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4488         (parse_cli_var_enum): Declare.
4489         * cli/cli-utils.c: Include "cli/cli-option.h".
4490         (get_ulongest): New.
4491         * cli/cli-utils.h (get_ulongest): Declare.
4492         (check_for_argument): New overloads.
4493         * maint-test-options.c: New file.
4494
4495 2019-06-13  Pedro Alves  <palves@redhat.com>
4496
4497         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4498         parse a range if "-" is at the end of the string.
4499
4500 2019-06-13  Pedro Alves  <palves@redhat.com>
4501
4502         * cli/cli-setshow.c (parse_auto_binary_operation)
4503         (parse_cli_boolean_value): Don't allow "o".
4504
4505 2019-06-13  Pedro Alves  <palves@redhat.com>
4506
4507         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4508         * NEWS: Mention maint test-settings KIND.
4509         * maint-test-settings.c: New file.
4510
4511 2019-06-13  Pedro Alves  <palves@redhat.com>
4512
4513         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4514         completer.
4515         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4516         "set" completers.
4517
4518 2019-06-13  Pedro Alves  <palves@redhat.com>
4519
4520         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4521         after item.
4522
4523 2019-06-13  Pedro Alves  <palves@redhat.com>
4524
4525         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4526
4527 2019-06-13  Pedro Alves <palves@redhat.com>
4528
4529         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4530         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4531         call.
4532         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4533         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4534         calls.
4535         (check_for_argument): Skip spaces after argument.
4536
4537 2019-06-13  Pedro Alves  <palves@redhat.com>
4538
4539         * thread.c (thread_apply_command): Adjust TID parsing.
4540         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4541         detected before end of string.
4542         (tid_is_in_list): Error out if LIST is invalid.
4543
4544 2019-06-13  Pedro Alves  <palves@redhat.com>
4545
4546         * completer.c (complete_line_internal_1): Rewind completion word
4547         point.
4548         (completion_tracker::advance_custom_word_point_by): Change
4549         parameter type to int.
4550         * completer.h (completion_tracker::advance_custom_word_point_by):
4551         Likewise.
4552
4553 2019-06-13  Pedro Alves  <palves@redhat.com>
4554
4555         * completer.c (advance_to_completion_word): Handle delimiters.
4556
4557 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4558
4559         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4560
4561 2019-06-11  Tom Tromey  <tom@tromey.com>
4562
4563         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4564         (xmalloc_failed): Move to alloc.c.
4565         * alloc.c: New file.
4566         * Makefile.in (COMMON_SFILES): Add alloc.c.
4567
4568 2019-06-11  Tom Tromey  <tom@tromey.com>
4569
4570         * nat/linux-waitpid.c: Don't include server.h.
4571         (linux_debug): Remove.
4572         (my_waitpid): Update.
4573
4574 2019-06-11  Tom Tromey  <tromey@adacore.com>
4575
4576         * infcall.c (_initialize_infcall): Remove trailing newline from
4577         help.
4578         * user-regs.c (_initialize_user_regs): Remove trailing newline
4579         from help.
4580         * typeprint.c (_initialize_typeprint): Remove trailing newline
4581         from help.
4582         * reverse.c (_initialize_reverse): Remove trailing newlines from
4583         help.
4584         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4585         from help.
4586         * language.c (add_set_language_command): Remove trailing newline
4587         from help.
4588         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4589         help.
4590         * disasm.c (_initialize_disasm): Remove trailing newline from
4591         help.
4592         * top.c (init_main): Remove trailing newline from help.
4593         * interps.c (_initialize_interpreter): Remove trailing newline
4594         from help.
4595         * btrace.c (_initialize_btrace): Remove trailing newlines from
4596         help.
4597         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4598         from help.
4599         * python/python.c (_initialize_python): Remove trailing newline
4600         from help.
4601         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4602         help.
4603         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4604         from help.  Reformat some text.
4605         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4606         from help.
4607         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4608         newline from help.
4609
4610 2019-06-11  Tom Tromey  <tromey@adacore.com>
4611
4612         * darwin-nat.c (darwin_decode_exception_message)
4613         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4614
4615 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4616
4617         * valops.c (value_slice): Check for not allocated or not
4618         associated values.
4619
4620 2019-06-10  Tom de Vries  <tdevries@suse.de>
4621
4622         PR gdb/24618
4623         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4624         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4625         invalid.
4626
4627 2019-06-10  Tom de Vries  <tdevries@suse.de>
4628
4629         PR gdb/24611
4630         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4631         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4632
4633 2019-06-10  Tom de Vries  <tdevries@suse.de>
4634
4635         PR symtab/24545
4636         * symtab.c (struct demangled_name_entry): Add language field.
4637         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4638         static minimal symbol".  Set and use language field.
4639
4640 2019-06-10  Tom Tromey  <tromey@adacore.com>
4641
4642         * ada-lang.c (_initialize_ada_language): Update help text.
4643
4644 2019-06-10  Tom Tromey  <tromey@adacore.com>
4645
4646         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4647         with a newline.
4648         * guile/guile.c (handle_boot_error): Don't end warning with a
4649         newline.
4650         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4651         warning with a newline.
4652         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4653         newline.
4654         (s12z_frame_cache): Likewise.
4655         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4656         a newline.
4657         * solib-svr4.c (disable_probes_interface): Don't end warning with
4658         a newline.
4659         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4660         newline.
4661         * python/python.c (do_finish_initialization): Don't end warning
4662         with a newline.
4663
4664 2019-06-10  Tom Tromey  <tom@tromey.com>
4665
4666         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4667         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4668         gdbpy_enter.
4669
4670 2019-06-10  Tom Tromey  <tromey@adacore.com>
4671
4672         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4673         data.
4674         (elf_new_init): Don't call stabsread_new_init.
4675         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4676         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4677         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4678
4679 2019-06-10  Tom de Vries  <tdevries@suse.de>
4680
4681         PR symtab/16264
4682         PR symtab/24517
4683         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4684
4685 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4686
4687         * source.c (find_and_open_source): Also rewrite relative file
4688         names.
4689
4690 2019-04-26  Amos Bird  <amosbird@gmail.com>
4691
4692         * annotate.c (annotate_thread_exited): Add "thread-exited"
4693         annotation.
4694
4695 2019-06-06  Tom Tromey  <tromey@adacore.com>
4696
4697         * maint.h (class scoped_command_stats): Use
4698         DISABLE_COPY_AND_ASSIGN.
4699         <print_time>: New method.
4700         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4701         print_time.
4702         (scoped_command_stats::print_time): New method.
4703
4704 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4705
4706         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4707         instructions of lengths 6 or 8 bytes.
4708
4709 2019-06-04  Pedro Alves  <palves@redhat.com>
4710
4711         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4712
4713         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4714         * breakpoint.c (condition_completer): Likewise.
4715         * cli/cli-dump.c (scan_expression): Likewise.
4716         * common/filestuff.c (mkdir_recursive): Likewise.
4717         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4718         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4719         (gdb_abspath): Likewise.
4720         * compile/compile-cplus-types.c
4721         (compile_cplus_instance::decl_name): Likewise.
4722         * completer.c (complete_explicit_location):
4723         (signal_completer, reg_or_group_completer_1): Likewise.
4724         * cp-support.c (cp_remove_params_if_any): Likewise.
4725         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4726         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4727         * infcmd.c (strip_bg_char): Likewise.
4728         * linespec.c (copy_token_string): Likewise.
4729         * mi/mi-main.c (output_cores): Likewise.
4730         * psymtab.c (psymtab_search_name):
4731         * symfile.c (test_set_ext_lang_command): Likewise.
4732         * target.c (target_fileio_read_stralloc): Likewise.
4733         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4734         * value.c (complete_internalvar): Likewise.
4735
4736 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4737
4738         Add objfile property to gdb.Type.
4739         * NEWS: Mention Python API addition.
4740         * python/py-type.c (typy_get_objfile): New method.
4741
4742 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4743
4744         * NEWS: Mention the new set|show style [title|highlight].
4745         Mention changes to "show style", "help" and "apropos".
4746
4747 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4748
4749         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4750         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4751         instead of print_help_for_command.
4752         (print_doc_of_command): New function.
4753         (help_list): Add 'apropos -v word' suggestion.
4754         (print_help_for_command): Style the command name using title style.
4755         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4756         (_initialize_cli_cmds): Describe -v in apropos_command help.
4757
4758 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4759
4760         * cli/cli-style.h (cli_style_option): Add name in constructor,
4761         add m_name class member, add constructor with intensity,
4762         add name class function.
4763         (cli_style_option::add_setshow_commands): Remove name argument.
4764         (highlight_style, title_style): New styles.
4765         * cli/cli-style.c (do_show): New function that shows a style
4766         characteristic styling the style name with itself.
4767         (set_style_name): New function.
4768         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4769         Update all callers according to the changes in cli/cli-style.h.
4770         * utils.h (fputs_highlighted): New function.
4771         * utils.c (fputs_highlighted): Likewise.
4772
4773 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4774
4775         * NEWS: Mention new pipe command and new convenience variables.
4776
4777 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4778
4779         * cli/cli-cmds.c (pipe_command): New function.
4780         (_initialize_cli_cmds): Call add_com for pipe_command.
4781         Define | as an alias for pipe.
4782         (exit_status_set_internal_vars): New function.
4783         (shell_escape): Call exit_status_set_internal_vars.
4784         cli/cli-decode.c (find_command_name_length): Recognize | as
4785         a single character command.
4786
4787 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4788
4789         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4790         top.c (execute_command_to_ui_file): New function, mostly a copy
4791         of execute_command_to_string.
4792         (execute_command_to_string): Implement by calling
4793         execute_command_to_ui_file.
4794
4795 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4796
4797         * top.h (saved_command_line): Remove declaration.
4798         * top.c (previous_saved_command_line, previous_repeat_arguments):
4799         New variables.
4800         (saved_command_line): Make static, define together with other
4801         'repeat variables'.
4802         (dont_repeat): Clear repeat_arguments.
4803         (repeat_previous, get_saved_command_line, save_command_line):
4804         New functions.
4805         (gdb_init): Initialize saved_command_line
4806         and previous_saved_command_line.
4807         * main.c (captured_main_1): Remove saved_command_line initialization.
4808         * event-top.c (handle_line_of_input): Update to use
4809         the new 'repeat' related functions instead of direct access to
4810         saved_command_line.
4811         * command.h (repeat_previous, get_saved_command_line,
4812         save_command_line): New declarations.
4813         (dont_repeat): Add comment.
4814
4815 2019-05-30  Tom Tromey  <tromey@adacore.com>
4816
4817         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4818         Fix comment.
4819         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4820
4821 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4822
4823         PR cli/24587
4824         * completer.c (complete): Initialize variable word.
4825
4826 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4827
4828         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4829         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4830         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4831         'body' is NULL to the outter 'if', protecting the '!is_define'
4832         situation as well.
4833
4834 2019-05-29  Tom Tromey  <tromey@adacore.com>
4835
4836         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4837         (dwarf_unknown): New function.
4838         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4839         (dwarf_type_encoding_name): Use dwarf_unknown.
4840
4841 2019-05-29  Tom Tromey  <tromey@adacore.com>
4842
4843         PR c++/20020:
4844         * cp-valprint.c (cp_print_value_fields): Call
4845         cp_print_static_field inside "try".
4846
4847 2019-05-29  Tom Tromey  <tromey@adacore.com>
4848
4849         * inflow.c (struct terminal_info): Add default operator=.
4850         * configure: Rebuild.
4851         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4852         -Wdeprecated-copy-dtor, -Wredundant-move.
4853
4854 2019-05-29  Tom Tromey  <tromey@adacore.com>
4855
4856         * NEWS: Add entry.
4857         * infcmd.c (print_return_value_1): Handle finish_print
4858         option.
4859         (show_print_finish): New function.
4860         (_initialize_infcmd): Add "set/show print finish" commands.
4861         * valprint.c (user_print_options): Initialize new member.
4862         * valprint.h (struct value_print_options) <finish_print>: New
4863         member.
4864
4865 2019-05-28  Tom Tromey  <tromey@adacore.com>
4866
4867         * ada-lang.c (ada_remove_Xbn_suffix)
4868         (find_old_style_renaming_symbol)
4869         (parse_old_style_renaming): Remove.
4870         (ada_find_renaming_symbol): Don't call
4871         find_old_style_renaming_symbol.
4872         (ada_is_renaming_symbol): Rename from
4873         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4874         bool.  Now static.
4875         (ada_read_var_value): Update and simplify.
4876         * ada-exp.y (write_var_or_type): Remove old code.
4877
4878 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4879
4880         * event-top.c: Remove include comment.
4881         * inflow.c (class scoped_ignore_sigttou): Move from here...
4882         * inflow.h (class scoped_ignore_sigttou): ...to here.
4883         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4884         * top.c:  Remove include comment.
4885
4886 2019-05-27  Tom Tromey  <tom@tromey.com>
4887
4888         * NEWS: Fix typo.
4889
4890 2019-05-22  Tom Tromey  <tromey@adacore.com>
4891
4892         * target.c (target_follow_exec): Constify parameter.
4893         * target-delegates.c: Rebuild.
4894         * remote.c (remote_target::follow_exec): Constify parameter.
4895         * infrun.c (follow_exec): Constify parameter.
4896         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4897         (target_follow_exec): Likewise.
4898
4899 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4900
4901         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4902         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4903
4904 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4905
4906         * NEWS: Add debugredirect and testsuite sections.
4907
4908 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4909
4910         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4911         target descriptions using exclusively floating point register name
4912         aliases.
4913
4914 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         PR gdb/18644:
4917         * f-lang.c (build_fortran_types): Handle the case where
4918         gdbarch_floatformat_for_type returns a nullptr.
4919
4920 2019-05-21  Tom de Vries  <tdevries@suse.de>
4921
4922         PR cli/24587
4923         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4924
4925 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4926
4927         PR gdb/18644:
4928         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4929         16-byte floats.
4930         * i386-tdep.c (i386_floatformat_for_type): Use
4931         floatformats_ia64_quad for the 16-byte floating point component
4932         within a fortran 32-byte complex number.
4933
4934 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4937         delete default constructor.
4938         (find_partial_die): Update to return const struct.
4939         (partial_die_parent_scope): Move variable declaration into scope
4940         of its use and change its type to auto.
4941         (guess_partial_die_structure_name): Likewise.
4942         (partial_die_info::fixup): Likewise.
4943
4944 2019-05-17  Tom Tromey  <tromey@adacore.com>
4945
4946         * source.c (find_and_open_source): Remove cast.
4947
4948 2019-05-17  Tom Tromey  <tromey@adacore.com>
4949
4950         * annotate.c (annotate_source): Make "filename" const.
4951         * annotate.h (annotate_source): Use const.
4952
4953 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4954
4955         * disasm.c (set_disassembler_options): Send errors to stderr.
4956
4957 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4958
4959         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4960         (cli_interp_base::set_logging): Check debug_redirect.
4961         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4962         * cli/cli-logging.c (debug_redirect): Add static variable.
4963         (pop_output_files): Add default param.
4964         (handle_redirections): Print debug setting.
4965         (show_logging_command): Likewise.
4966         (_initialize_cli_logging): Add debugredirect command.
4967         * interps.c (current_interp_set_logging): Add debug_redirect
4968         parameter.
4969         * interps.h (set_logging): Add debug_redirect parameter.
4970         (current_interp_set_logging): Likewise.
4971         * mi/mi-common.h: Likewise.
4972         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4973
4974 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4975             Tom Tromey  <tromey@adacore.com>
4976
4977         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4978         directly.
4979         * cli/cli-interp.h (make_logging_output): Remove declaration.
4980         * cli/cli-logging.c (make_logging_output): Remove function.
4981         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4982         directly.
4983         * ui-file.c (tee_file::tee_file): Remove bools.
4984         (tee_file::~tee_file): Remove deletes.
4985         * ui-file.h (tee_file): Remove bools.
4986
4987 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4988
4989         * mi/mi-cmds.h (mi_cmd_complete): New function.
4990         * mi/mi-main.c (mi_cmd_complete): Likewise.
4991         * mi/mi-cmds.c: Define new MI command -complete.
4992         * NEWS: Mention new -complete command.
4993
4994 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4995
4996         * completer.h (complete): New function.
4997         * completer.c (complete): Likewise.
4998         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4999         function defined in completer.h.
5000
5001 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5002
5003         * MAINTAINERS (Write After Approval): Add myself.
5004
5005 2019-05-17  Tom de Vries  <tdevries@suse.de>
5006
5007         PR gdb/24094
5008         * dwarf2read.c (struct cu_partial_die_info): New struct.
5009         (find_partial_die): Return cu_partial_die_info.
5010         (partial_die_parent_scope, guess_partial_die_structure_name)
5011         (partial_die_info::fixup): Handle new return type of find_partial_die.
5012
5013 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5014
5015         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5016         "std::string", simplifying the algorithm.
5017
5018 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5019
5020         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5021         (stap_static_probe_ops::get_probes): Likewise.
5022
5023 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5024
5025         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5026         '-')" and "else if".
5027         (stap_parse_single_operand): Join checks for
5028         "gdbarch_stap_parse_special_token_p" and
5029         "gdbarch_stap_parse_special_token" in the same "if" statement.
5030         Invert check when verifying for operation on register
5031         displacement.
5032
5033 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5034
5035         * stap-probe.c (stap_get_opcode): Update comment.
5036         (stap_get_expected_argument_type): Likewise.
5037         (handle_stap_probe): Likewise.
5038
5039 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5040
5041         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5042         return type to 'bool'.  Adjust comment.  Use 'bool' when
5043         appropriate.
5044         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5045         * stap-probe.c (stap_parse_argument_1): Likewise.
5046         (stap_is_operator): Likewise.
5047         (stap_is_generic_prefix): Likewise.
5048         (stap_is_register_prefix): Likewise.
5049         (stap_is_register_indirection_prefix): Likewise.
5050         (stap_is_integer_prefix): Likewise.
5051         (stap_generic_check_suffix): Likewise.
5052         (stap_check_integer_suffix): Likewise.
5053         (stap_check_register_suffix): Likewise.
5054         (stap_check_register_indirection_suffix): Likewise.
5055         (stap_parse_register_operand): Likewise.
5056         (stap_parse_single_operand): Likewise.
5057         (stap_parse_argument_1): Likewise.
5058         (stap_probe::get_argument_count): Likewise.
5059         (stap_is_operator): Likewise.
5060
5061 2019-05-16  Tom Tromey  <tromey@adacore.com>
5062
5063         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5064         keyword to foreach.
5065
5066 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5067
5068         * linux-thread-db.c (try_thread_db_load_1): Change return type
5069         to bool.
5070         (try_thread_db_load): Likewise.
5071         (try_thread_db_load_from_pdir_1): Likewise.
5072         (try_thread_db_load_from_pdir): Likewise.
5073         (try_thread_db_load_from_sdir): Likewise.
5074         (try_thread_db_load_from_dir): Likewise.
5075         (thread_db_load_search): Likewise.
5076         (has_libpthread): Likewise.
5077         (thread_db_load): Likewise.
5078
5079 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5080
5081         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5082         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5083         NULL, and complain/return if that's the case.
5084
5085 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5086
5087         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5088         (advance, posn, abstract_read_memory): New functions.
5089         [struct mem_read_abstraction]: New struct.
5090         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5091
5092 2019-05-14  Tom Tromey  <tromey@adacore.com>
5093
5094         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5095         value is not lval_memory.
5096
5097 2019-05-14  Tom Tromey  <tromey@adacore.com>
5098
5099         * solib.c (info_sharedlibrary_command): Style the file name.
5100
5101 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5102
5103         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5104         (aarch64_vnv_type): Likewise.
5105         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5106         * common/tdesc.c: Likewise.
5107         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5108         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5109         * features/aarch64-fpu.xml: Add ieee half view.
5110         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5111         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5112         * gdbtypes.h (struct builtin_type): Likewise.
5113         (struct objfile_type): Likewise.
5114
5115 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5116
5117         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5118         typo.
5119         * location.h (string_to_event_location): Likewise.
5120
5121 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5122
5123         GDB 8.3 released.
5124
5125 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5126
5127         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5128         New variable declaration.
5129         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5130         New variable.
5131         (print_one_breakpoint): Use ui_out::test_flags and new global
5132         variable to compute use_fixed_output.
5133         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5134         Remove.
5135         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5136         (mi_multi_location_breakpoint_output_fixed): Remove.
5137         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5138         new variable.
5139         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5140         fix_multi_location_breakpoint_output flag if version >= 3.
5141         * ui-out.h (enum ui_out_flag)
5142         <fix_multi_location_breakpoint_output>: New enumerator.
5143
5144 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5145
5146         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5147
5148 2019-05-10  Tom Tromey  <tromey@adacore.com>
5149
5150         * ada-lang.c (catch_ada_completer): New function.
5151         (_initialize_ada_language): Use it.
5152
5153 2019-05-10  Tom Tromey  <tromey@adacore.com>
5154
5155         * thread.c (print_thread_info): Make "requested_threads" const.
5156         * gdbthread.h (print_thread_info): Make "requested_threads"
5157         const.
5158         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5159         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5160
5161 2019-05-08  Tom Tromey  <tom@tromey.com>
5162
5163         * gdbtypes.c (objfile_type_data): Change type.
5164         (objfile_type, _initialize_gdbtypes): Update.
5165
5166 2019-05-08  Tom Tromey  <tom@tromey.com>
5167
5168         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5169         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5170         (_initialize_dwarf2_frame): Update.
5171
5172 2019-05-08  Tom Tromey  <tom@tromey.com>
5173
5174         * objc-lang.c (objc_objfile_data): Change type.
5175         (find_methods): Update.
5176         (_initialize_objc_lang): Remove.
5177
5178 2019-05-08  Tom Tromey  <tom@tromey.com>
5179
5180         * stabsread.c (rs6000_builtin_type_data): Change type.
5181         (rs6000_builtin_type, _initialize_stabsread): Update.
5182
5183 2019-05-08  Tom Tromey  <tom@tromey.com>
5184
5185         * mips-tdep.c (mips_pdr_data): Remove.
5186         (_initialize_mips_tdep): Update.
5187
5188 2019-05-08  Tom Tromey  <tom@tromey.com>
5189
5190         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5191         (hppa_init_objfile_priv_data, read_unwind_info)
5192         (find_unwind_entry, _initialize_hppa_tdep): Update.
5193
5194 2019-05-08  Tom Tromey  <tom@tromey.com>
5195
5196         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5197         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5198         on obstack.
5199         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5200
5201 2019-05-08  Tom Tromey  <tom@tromey.com>
5202
5203         * mdebugread.c (basic_type_data): Change type.
5204         (basic_type, _initialize_mdebugread): Update.
5205
5206 2019-05-08  Tom Tromey  <tom@tromey.com>
5207
5208         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5209
5210 2019-05-08  Tom Tromey  <tom@tromey.com>
5211
5212         * nto-tdep.c (nto_inferior_data_reg): Change type.
5213         (nto_inferior_data): Update.
5214         (nto_inferior_data_cleanup, nto_new_inferior_data)
5215         (_initialize_nto_tdep): Remove.
5216         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5217
5218 2019-05-08  Tom Tromey  <tom@tromey.com>
5219
5220         * ada-lang.c (struct ada_inferior_data): Add initializers.
5221         (ada_inferior_data): Change type.
5222         (ada_inferior_data_cleanup): Remove.
5223         (get_ada_inferior_data, ada_inferior_exit)
5224         (struct ada_pspace_data): Add initializers, destructor.
5225         (ada_pspace_data_handle): Change type.
5226         (get_ada_pspace_data): Update.
5227         (ada_pspace_data_cleanup): Remove.
5228
5229 2019-05-08  Tom Tromey  <tom@tromey.com>
5230
5231         * coffread.c (struct coff_symfile_info): Add initializers.
5232         (coff_objfile_data_key): Move lower.  Change type.
5233         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5234         Update.
5235         (coff_free_info): Remove.
5236
5237 2019-05-08  Tom Tromey  <tom@tromey.com>
5238
5239         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5240         (fbsd_pspace_data_handle): Move lower.  Change type.
5241         (get_fbsd_pspace_data): Update.
5242         (fbsd_pspace_data_cleanup): Remove.
5243         (_initialize_fbsd_tdep): Update.
5244
5245 2019-05-08  Tom Tromey  <tom@tromey.com>
5246
5247         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5248         (get_ada_tasks_pspace_data): Update.
5249         (ada_tasks_pspace_data_cleanup): Remove.
5250         (_initialize_tasks): Update.
5251         (ada_tasks_inferior_data_handle): Change type.
5252         (get_ada_tasks_inferior_data): Update.
5253         (ada_tasks_inferior_data_cleanup): Remove.
5254         (struct ada_tasks_pspace_data): Add initializers.
5255
5256 2019-05-08  Tom Tromey  <tom@tromey.com>
5257
5258         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5259         * symfile-debug.c (debug_sym_get_probes): Change type.
5260         * stap-probe.c (handle_stap_probe):
5261         (stap_static_probe_ops::get_probes): Change type.
5262         * probe.h (class static_probe_ops) <get_probes>: Change type.
5263         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5264         (parse_probes_in_pspace): Update.
5265         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5266         Update.
5267         (any_static_probe_ops::get_probes): Change type.
5268         * elfread.c (elfread_data): New typedef.
5269         (probe_key): Change type.
5270         (elf_get_probes): Likewise.  Update.
5271         (probe_key_free): Remove.
5272         (_initialize_elfread): Update.
5273         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5274         Change type.
5275         (dtrace_process_dof_probe, dtrace_process_dof)
5276         (dtrace_static_probe_ops::get_probe): Change type.
5277
5278 2019-05-08  Tom Tromey  <tom@tromey.com>
5279
5280         * xcoffread.c (struct xcoff_symfile_info): Rename from
5281         coff_symfile_info.  Add initializers.
5282         (xcoff_objfile_data_key): Move lower.  Change type.
5283         (XCOFF_DATA): Rewrite.
5284         (xcoff_free_info): Remove.
5285         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5286         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5287         (xcoff_initial_scan): Update.
5288
5289 2019-05-08  Tom Tromey  <tom@tromey.com>
5290
5291         * solib-svr4.c (struct svr4_info): Add initializers and
5292         destructor.
5293         <probes_table>: Now an htab_up.
5294         (solib_svr4_pspace_data): Change type.
5295         (free_probes_table): Simplify.
5296         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5297         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5298         (probes_table_remove_objfile_probes, register_solib_event_probe)
5299         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5300         (_initialize_svr4_solib): Update.
5301
5302 2019-05-08  Tom Tromey  <tom@tromey.com>
5303
5304         * remote.c (remote_pspace_data): Change type.
5305         (remote_pspace_data_cleanup): Remove.
5306         (get_remote_exec_file, set_pspace_remote_exec_file)
5307         (_initialize_remote): Update.
5308
5309 2019-05-08  Tom Tromey  <tom@tromey.com>
5310
5311         * breakpoint.c (breakpoint_objfile_key): Change type.
5312         (get_breakpoint_objfile_data): Update.
5313         (free_breakpoint_objfile_data): Remove.
5314         (_initialize_breakpoint): Update.
5315
5316 2019-05-08  Tom Tromey  <tom@tromey.com>
5317
5318         * linux-tdep.c (struct linux_info): Add initializers.
5319         (linux_inferior_data): Move.  Change type.
5320         (invalidate_linux_cache_inf): Update.
5321         (linux_inferior_data_cleanup): Remove.
5322         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5323
5324 2019-05-08  Tom Tromey  <tom@tromey.com>
5325
5326         * auxv.c (auxv_inferior_data): Move.  Change type.
5327         (auxv_inferior_data_cleanup): Remove.
5328         (invalidate_auxv_cache_inf): Rewrite.
5329         (get_auxv_inferior_data, _initialize_auxv): Update.
5330
5331 2019-05-08  Tom Tromey  <tom@tromey.com>
5332
5333         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5334         (symfile_debug_objfile_data_key): Change type.
5335         (symfile_debug_installed, debug_qf_has_symbols)
5336         (debug_qf_find_last_source_symtab)
5337         (debug_qf_forget_cached_source_info)
5338         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5339         (debug_qf_print_stats, debug_qf_dump)
5340         (debug_qf_expand_symtabs_for_function)
5341         (debug_qf_expand_all_symtabs)
5342         (debug_qf_expand_symtabs_with_fullname)
5343         (debug_qf_map_matching_symbols)
5344         (debug_qf_expand_symtabs_matching)
5345         (debug_qf_find_pc_sect_compunit_symtab)
5346         (debug_qf_map_symbol_filenames)
5347         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5348         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5349         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5350         (debug_sym_read_linetable, debug_sym_relocate): Update.
5351         (symfile_debug_free_objfile): Remove.
5352         (install_symfile_debug_logging, _initialize_symfile_debug):
5353         Update.
5354
5355 2019-05-08  Tom Tromey  <tom@tromey.com>
5356
5357         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5358         allocate_on_obstack.
5359         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5360         (get_dwarf2_per_objfile): Update.
5361         (set_dwarf2_per_objfile): Remove.
5362         (dwarf2_has_info, dwarf2_get_section_info): Update.
5363         (dwarf2_free_objfile): Remove.
5364         (_initialize_dwarf2_read): Update.
5365
5366 2019-05-08  Tom Tromey  <tom@tromey.com>
5367
5368         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5369         initializers.
5370         <unsupported_script_warning_printed,
5371         script_not_found_warning_printed>: Now bool.
5372         (auto_load_pspace_data): Change type.
5373         (~auto_load_pspace_info): Rename from
5374         auto_load_pspace_data_cleanup.
5375         (get_auto_load_pspace_data, init_loaded_scripts_info)
5376         (clear_section_scripts, maybe_print_unsupported_script_warning)
5377         (maybe_print_script_not_found_warning, _initialize_auto_load):
5378         Update.
5379
5380 2019-05-08  Tom Tromey  <tom@tromey.com>
5381
5382         * objfiles.c (objfile_pspace_info): Add destructor and
5383         initializers.
5384         (objfiles_pspace_data): Change type.
5385         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5386         (get_objfile_pspace_data): Update.
5387         (objfiles_bfd_data): Change type.
5388         (get_objfile_bfd_data): Update.
5389         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5390
5391 2019-05-08  Tom Tromey  <tom@tromey.com>
5392
5393         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5394         Change type.
5395         (get_catch_syscall_inferior_data): Update.
5396         (catch_syscall_inferior_data_cleanup): Remove.
5397         (_initialize_break_catch_syscall): Update.
5398
5399 2019-05-08  Tom Tromey  <tom@tromey.com>
5400
5401         * inflow.c (struct terminal_info): Add destructor and
5402         initializers.
5403         (inflow_inferior_data): Change type.
5404         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5405         (get_inflow_inferior_data, inflow_inferior_exit)
5406         (swap_terminal_info, _initialize_inflow): Update.
5407
5408 2019-05-08  Tom Tromey  <tom@tromey.com>
5409
5410         * target-dcache.c (target_dcache_cleanup): Remove.
5411         (target_dcache_aspace_key): Change type.
5412         (target_dcache_init_p, target_dcache_invalidate)
5413         (target_dcache_get, target_dcache_get_or_init)
5414         (_initialize_target_dcache): Update.
5415         * dcache.h (struct dcache_deleter): New.
5416
5417 2019-05-08  Tom Tromey  <tom@tromey.com>
5418
5419         * symtab.c (struct symbol_cache): Add destructor and
5420         initializers.
5421         (symbol_cache_key): Move.  Change type.
5422         (make_symbol_cache, free_symbol_cache): Remove.
5423         (get_symbol_cache): Update.
5424         (symbol_cache_cleanup): Remove.
5425         (ALL_PSPACES, symbol_cache_flush)
5426         (maintenance_print_symbol_cache)
5427         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5428         Update.
5429
5430 2019-05-08  Tom Tromey  <tom@tromey.com>
5431
5432         * symtab.c (struct main_info): Add destructor and initializers.
5433         (main_progspace_key): Move.  Change type.
5434         (get_main_info): Update.
5435         (main_info_cleanup): Remove.
5436         (_initialize_symtab): Update.
5437
5438 2019-05-08  Tom Tromey  <tom@tromey.com>
5439
5440         * registry.h (DECLARE_REGISTRY): Define the _key class.
5441
5442 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5443
5444         * NEWS: Merge two 'New commands' sections.
5445
5446 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5447
5448         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5449         parameter and use Ada language definition instead.
5450         (ada_val_print_ptr): Remove unused language parameter.
5451         (ada_val_print_num): Remove language parameter and use Ada language
5452         definition instead.
5453         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5454         parameter.
5455         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5456         parameter and use Ada language definition instead.
5457         (ada_val_print_1): Update all ada_val_print_xxx calls.
5458         Remove language parameter.
5459         (ada_val_print): Update ada_val_print_1 call.
5460
5461 2019-05-08  Tom Tromey  <tromey@adacore.com>
5462
5463         * remote.c (remote_hw_watchpoint_limit)
5464         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5465         Now static.
5466
5467 2019-05-08  Tom Tromey  <tromey@adacore.com>
5468
5469         * maint.c (_initialize_maint_cmds): Move initialization code to
5470         remote.c.
5471         (watchdog, show_watchdog): Move to remote.c.
5472         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5473         "watchdog" static.
5474         (_initialize_remote): Move initialization code from maint.c.
5475         * defs.h (watchdog): Don't declare.
5476
5477 2019-05-08  Tom Tromey  <tromey@adacore.com>
5478
5479         * tui/tui-interp.c: Include main.h.
5480         * interps.c: Include main.h.
5481         * main.h (interpreter_p): Declare.
5482         * defs.h (interpreter_p): Don't declare.
5483
5484 2019-05-08  Tom Tromey  <tromey@adacore.com>
5485
5486         * dwarf2loc.c: Include dwarf2read.h.
5487         * defs.h (read_unsigned_leb128): Don't declare.
5488         * dwarf2read.h (read_unsigned_leb128): Declare.
5489
5490 2019-05-08  Tom Tromey  <tromey@adacore.com>
5491
5492         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5493         method.
5494
5495 2019-05-08  Tom Tromey  <tromey@adacore.com>
5496
5497         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5498         when no wrap column is set.
5499
5500 2019-05-08  Tom Tromey  <tromey@adacore.com>
5501
5502         * c-lang.c (c_get_string): Handle non-C-style arrays.
5503
5504 2019-05-08  Tom Tromey  <tromey@adacore.com>
5505
5506         * typeprint.c (print_offset_data::update): Print the bit offset,
5507         not the number of bits remaining.
5508
5509 2019-05-08  Tom Tromey  <tromey@adacore.com>
5510
5511         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5512         padding at end of comment.
5513
5514 2019-05-08  Tom Tromey  <tromey@adacore.com>
5515
5516         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5517         Compare main types.
5518
5519 2019-05-06  Tom Tromey  <tom@tromey.com>
5520
5521         * common/scoped_mmap.c: Include common-defs.h.
5522         * common/scoped_mmap.h: Don't include config.h.
5523
5524 2019-05-04  Tom Tromey  <tom@tromey.com>
5525
5526         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5527         (struct aarch64_call_info): Add initializers.
5528         <si>: Now a std::vector.
5529         (pass_on_stack, aarch64_push_dummy_call): Update.
5530
5531 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5532             Tom Tromey  <tom@tromey.com>
5533
5534         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5535         (ppc_threads): Now a std::vector.  Now static.
5536         (hwdebug_find_thread_points_by_tid)
5537         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5538         Update.
5539
5540 2019-05-04  Tom Tromey  <tom@tromey.com>
5541
5542         * arc-tdep.c (arc_tdesc_init): Return bool.
5543
5544 2019-05-04  Tom Tromey  <tom@tromey.com>
5545
5546         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5547         Use gdb_assert_not_reached.
5548
5549 2019-05-04  Tom Tromey  <tom@tromey.com>
5550
5551         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5552         "false".
5553
5554 2019-05-04  Tom Tromey  <tom@tromey.com>
5555
5556         * arc-tdep.c (arc_tdesc_init): Use bool.
5557
5558 2019-05-04  Tom Tromey  <tom@tromey.com>
5559
5560         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5561
5562 2019-05-04  Tom Tromey  <tom@tromey.com>
5563
5564         * cli/cli-cmds.c (valid_command_p): Return bool.
5565
5566 2019-05-04  Tom Tromey  <tom@tromey.com>
5567
5568         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5569         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5570
5571 2019-05-04  Raul Tambre  <raul@tambre.ee>
5572
5573         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5574         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5575         operator for comparison.
5576
5577 2019-05-04  Tom Tromey  <tom@tromey.com>
5578
5579         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5580         (lookup_partial_symbol, print_partial_symbols)
5581         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5582         (psymbol_compare): Update.
5583         (add_psymbol_to_bcache): Clear the entire psymbol.
5584         (maintenance_check_psymtabs): Update.
5585         * psympriv.h (struct partial_symbol): Don't derive from
5586         general_symbol_info.
5587         <obj_section, unrelocated_address, address,
5588         set_unrelocated_address>: Update.
5589         <ginfo>: New member.
5590         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5591         (debug_names::write_psymbols): Update.
5592
5593 2019-05-04  Tom de Vries  <tdevries@suse.de>
5594
5595         * contrib/cc-with-tweaks.sh: Support -n arg.
5596
5597 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5598
5599         * corelow.c (core_target::detach): Ensure frame cache and
5600         register caches are cleared.
5601         inferior.c (exit_inferior_1): Likewise.
5602
5603 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5604             Tom Tromey  <tom@tromey.com>
5605
5606         * dictionary.c (collate_pending_symbols_by_language): Remove
5607         "struct" from foreach.
5608         * symtab.c (lookup_global_symbol_from_objfile)
5609         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5610         foreach.
5611         * ser-tcp.c (net_open): Remove "struct" from foreach.
5612         * objfiles.c (objfile_relocate, objfile_rebase)
5613         (objfile_has_symbols): Remove "struct" from foreach.
5614         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5615         from foreach.
5616         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5617         foreach.
5618         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5619         "struct" from foreach.
5620         * ada-lang.c (create_excep_cond_exprs)
5621         (ada_exception_catchpoint_cond_string): Remove "struct" from
5622         foreach.
5623
5624 2019-05-03  Tom Tromey  <tromey@adacore.com>
5625
5626         * ada-exp.y (convert_char_literal): Check suffix of each
5627         enumerator.
5628
5629 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5630
5631         PR ada/21406:
5632         * ada-exp.y (yywrap): Don't define.
5633         * ada-lex.l (%option): Add noyywrap
5634         (yywrap): Remove.
5635
5636 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5637
5638         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5639         _WIN32_WINNT to the XP level, unless already defined to a higher
5640         level.
5641
5642         * unittests/parse-connection-spec-selftests.c:
5643         * ser-tcp.c:
5644         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5645         override.
5646
5647         * symfile.c (find_separate_debug_file): Remove colon from the
5648         drive spec of DOS/Windows file names of the target, so that the
5649         file name produced from DEBUGDIR and the target's directory will
5650         be valid on DOS/Windows systems.
5651
5652 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5653
5654         * rust-lang.c (val_print_struct): Handle printing structures
5655         containing strings.
5656
5657 2019-05-02  Tom Tromey  <tromey@adacore.com>
5658
5659         * valarith.c (_initialize_valarith): Remove.
5660
5661 2019-05-01  Tom Tromey  <tromey@adacore.com>
5662
5663         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5664         bitfields.
5665
5666 2019-05-01  Tom Tromey  <tromey@adacore.com>
5667
5668         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5669         for big-endian copies.
5670
5671 2019-04-30  Ali Tamur  <tamur@google.com>
5672         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5673         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5674         (read_3_bytes): New function.
5675
5676 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5677
5678         * windows-nat.c (main_thread_id): Delete.
5679         (handle_output_debug_string): Replace main_thread_id by
5680         current_event.dwThreadId.
5681         (fake_create_process): Likewise.
5682         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5683         Do not set main_thread_id.
5684         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5685         current_event.dwThreadId.
5686         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5687
5688 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5689
5690         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5691         Use current_event.dwThreadId instead of main_thread_id.
5692
5693 2019-04-30  Tom Tromey  <tromey@adacore.com>
5694
5695         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5696         (create_excep_cond_exprs): Iterate over program spaces.
5697         (ada_exception_catchpoint_cond_string): Examine all minimal
5698         symbols for exception types.
5699
5700 2019-04-30  Tom Tromey  <tromey@adacore.com>
5701
5702         PR c++/24470:
5703         * dwarf2read.c (process_structure_scope): Handle case where type
5704         has template parameters but no symbol was created.
5705
5706 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5707             Chris January  <chris.january@arm.com>
5708
5709         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5710         qualifier.
5711         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5712
5713 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5714
5715         * f-typeprint.c (f_print_type): Update rules for printing
5716         whitespace.
5717         (f_type_print_varspec_suffix): Likewise.
5718
5719 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5720             Chris January  <chris.january@arm.com>
5721
5722         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5723         function arguments.
5724
5725 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5726
5727         * f-lang.c (build_fortran_types): Change name of void type to
5728         lower case.
5729         * f-typeprint.c (f_type_print_base): Print the name of the void
5730         type, rather than a fixed string.
5731         * f-valprint.c (f_decorations): Use lower case void string.
5732
5733 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5734             Chris January  <chris.january@arm.com>
5735
5736         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5737         types for Fortran.
5738
5739 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5740             Chris January  <chris.january@arm.com>
5741             David Lecomber  <david.lecomber@arm.com>
5742
5743         * f-exp.y (BINOP_INTRINSIC): New token.
5744         (exp): New parser rule handling BINOP_INTRINSIC.
5745         (f77_keywords): Add new builtin procedures.
5746         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5747         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5748         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5749         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5750         (print_unop_subexp_f): New function.
5751         (print_binop_subexp_f): New function.
5752         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5753         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5754         (dump_subexp_body_f): Likewise.
5755         (operator_check_f): Likewise.
5756         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5757         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5758
5759 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5760
5761         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5762         UNOP_KIND.
5763         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5764         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5765         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5766         (operator_length_f): New fuction.
5767         (print_subexp_f): New function.
5768         (op_name_f): New function.
5769         (dump_subexp_body_f): New function.
5770         (operator_check_f): New function.
5771         (exp_descriptor_f): Replace standard expression handling functions
5772         with new functions.
5773         * gdb/fortran-operator.def: New file.
5774         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5775         * gdb/std-operator.def: Remove UNOP_KIND.
5776
5777 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5778
5779         * std-operator.def: Remove unbalanced, stray double quote
5780         character.
5781
5782 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5783             Chris January  <chris.january@arm.com>
5784             Daniel Everett  <daniel.everett@arm.com>
5785             Nick Forrington  <nick.forrington@arm.com>
5786             Richard Bunt  <richard.bunt@arm.com>
5787
5788         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5789         of depth when printing anonymous structs or unions.
5790         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5791         Don't print either the top-level value, or the children if the
5792         max-depth is exceeded.
5793         (ppscm_print_children): When printing the key of a map, allow one
5794         extra level of depth.
5795         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5796         print either the top-level value, or the children if the max-depth
5797         is exceeded.
5798         (print_children): When printing the key of a map, allow one extra
5799         level of depth.
5800         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5801         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5802         (user_print_options): Initialise max_depth field.
5803         (val_print_scalar_or_string_type_p): New function.
5804         (val_print): Check to see if the max depth has been reached.
5805         (val_print_check_max_depth): Define new function.
5806         (show_print_max_depth): New function.
5807         (_initialize_valprint): Add 'print max-depth' option.
5808         * valprint.h (struct value_print_options) <max_depth>: New field.
5809         (val_print_check_max_depth): Declare new function.
5810         * NEWS: Document new feature.
5811
5812 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5813
5814         * ada-lang.c (ada_language_defn): Initialise new field.
5815         * c-lang.c (c_is_string_type_p): New function.
5816         (c_language_defn): Initialise new field.
5817         (cplus_language_defn): Initialise new field.
5818         (asm_language_defn): Initialise new field.
5819         (minimal_language_defn): Initialise new field.
5820         * c-lang.h (c_is_string_type_p): Declare new function.
5821         * d-lang.c (d_language_defn): Initialise new field.
5822         * f-lang.c (f_is_string_type_p): New function.
5823         (f_language_defn): Initialise new field.
5824         * go-lang.c (go_is_string_type_p): New function.
5825         (go_language_defn): Initialise new field.
5826         * language.c (default_is_string_type_p): New function.
5827         (unknown_language_defn): Initialise new field.
5828         (auto_language_defn): Initialise new field.
5829         * language.h (struct language_defn) <la_is_string_type_p>: New
5830         member variable.
5831         (default_is_string_type_p): Declare new function.
5832         * m2-lang.c (m2_language_defn): Initialise new field.
5833         * objc-lang.c (objc_language_defn): Initialise new field.
5834         * opencl-lang.c (opencl_language_defn): Initialise new field.
5835         * p-lang.c (pascal_is_string_type_p): New function.
5836         (pascal_language_defn): Initialise new field.
5837         * rust-lang.c (rust_is_string_type_p): New function.
5838         (rust_language_defn): Initialise new field.
5839
5840 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5841
5842         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5843         New field.
5844         * ada-lang.c (ada_language_defn): Initialise new field.
5845         * c-lang.c (c_language_defn): Likewise.
5846         (cplus_language_defn): Likewise.
5847         (asm_language_defn): Likewise.
5848         (minimal_language_defn): Likewise.
5849         * d-lang.c (d_language_defn): Likewise.
5850         * f-lang.c (f_language_defn): Likewise.
5851         * go-lang.c (go_language_defn): Likewise.
5852         * language.c (unknown_language_defn): Likewise.
5853         (auto_language_defn): Likewise.
5854         * m2-lang.c (m2_language_defn): Likewise.
5855         * objc-lang.c (objc_language_defn): Likewise.
5856         * opencl-lang.c (opencl_language_defn): Likewise.
5857         * p-lang.c (pascal_language_defn): Likewise.
5858         * rust-lang.c (rust_language_defn): Likewise.
5859
5860 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * ada-lang.c (ada_is_character_type): Change return type to bool.
5863         (ada_is_string_type): Likewise.
5864         * ada-lang.h (ada_is_character_type): Update declaration
5865         (ada_is_string_type): Likewise.
5866
5867 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5868
5869         Support style in 'frame|thread apply'
5870
5871         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5872         * record.c (record_start, record_stop): Update callers of
5873         execute_command_to_string with false.
5874         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5875         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5876         methods.
5877         (class string_file): New constructor with term_out parameter.
5878         Override methods term_out and can_emit_style_escape.  New member
5879         term_out.
5880         (class stdio_file): Override can_emit_style_escape.
5881         (class tee_file): Override term_out and can_emit_style_escape.
5882         * utils.h (can_emit_style_escape): Remove.
5883         * utils.c (can_emit_style_escape): Likewise.
5884         Update all callers of can_emit_style_escape (SOMESTREAM) to
5885         SOMESTREAM->can_emit_style_escape.
5886         * source-cache.c (source_cache::get_source_lines): Likewise.
5887         * stack.c (frame_apply_command_count): Call execute_command_to_string
5888         passing the term_out characteristic of the current gdb_stdout.
5889         * thread.c (thr_try_catch_cmd): Likewise.
5890         * top.c (execute_command_to_string): pass term_out parameter
5891         to construct the string_file for the command output.
5892         * ui-file.c (term_cli_styling): New function (most code moved
5893         from utils.c can_emit_style_escape).
5894         (string_file::string_file, string_file::can_emit_style_escape,
5895         stdio_file::can_emit_style_escape, tee_file::term_out,
5896         tee_file::can_emit_style_escape): New functions.
5897
5898 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5899
5900         * NEWS: Mention the new set|show may-call-functions.
5901         * infcall.c (may_call_functions_p): New variable.
5902         (show_may_call_functions_p): New function.
5903         (call_function_by_hand_dummy): Throws an error if not
5904         may-call-functions.
5905         (_initialize_infcall): Call add_setshow_boolean_cmd for
5906         may-call-functions.
5907
5908 2019-04-25  Keith Seitz  <keiths@redhat.com>
5909
5910         PR c++/24367
5911         * cp-support.c (inspect_type): Don't attempt substitutions
5912         of symbol with the same name.
5913
5914 2019-04-25  Tom Tromey  <tromey@adacore.com>
5915
5916         PR gdb/24475:
5917         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5918         static.
5919
5920 2019-04-25  Tom Tromey  <tromey@adacore.com>
5921
5922         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5923         rvalue reference.
5924         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5925         (gdb_xml_parser::parse): Use std::move.
5926         * python/python-internal.h (gdbpy_convert_exception): Take a const
5927         reference.
5928         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5929         std::move.
5930         * python/py-utils.c (gdbpy_convert_exception): Take a const
5931         reference.
5932         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5933         Use std::move.
5934         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5935         Use std::move.
5936         * mi/mi-main.c (mi_print_exception): Take a const reference.
5937         * main.c (handle_command_errors): Take a const reference.
5938         * linespec.c (parse_linespec): Use std::move.
5939         * infcall.c (run_inferior_call): Use std::move.
5940         (call_function_by_hand_dummy): Use std::move.
5941         * exec.c (try_open_exec_file): Use std::move.
5942         * exceptions.h (exception_print, exception_fprintf)
5943         (exception_print_same): Update.
5944         * exceptions.c (print_exception, exception_print)
5945         (exception_fprintf, exception_print_same): Change parameters to
5946         const reference.
5947         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5948         * common/new-op.c: Use std::move.
5949         * common/common-exceptions.h (struct gdb_exception): Add move
5950         constructor.
5951         (struct gdb_exception_error, struct gdb_exception_quit, struct
5952         gdb_quit_bad_alloc): Change constructor to move constructor.
5953         (throw_exception): Change parameter to rvalue reference.
5954         * common/common-exceptions.c (throw_exception): Take rvalue
5955         reference.
5956         * cli/cli-interp.c (safe_execute_command): Use std::move.
5957         * breakpoint.c (insert_bp_location, location_to_sals): Use
5958         std::move.
5959
5960 2019-04-25  Tom Tromey  <tromey@adacore.com>
5961
5962         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5963         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5964         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5965         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5966         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5967         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5968         guile/scm-value.c: Use unpack.
5969         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5970         gdbscm_gdb_exception.
5971         (gdbscm_throw_gdb_exception): Likewise.
5972         (struct gdbscm_gdb_exception): New.
5973         (unpack): New function.
5974         (gdbscm_wrap): Use unpack.
5975
5976 2019-04-25  Tom Tromey  <tromey@adacore.com>
5977
5978         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5979         (gdb_rl_callback_handler): Use std::move.
5980         * common/common-exceptions.h (struct gdb_exception): Add move
5981         assignment operator.
5982         (throw_exception_sjlj): Change "exception" to const reference.
5983         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5984         (throw_exception_sjlj): Change "exception" to const reference.
5985
5986 2019-04-25  Tom Tromey  <tromey@adacore.com>
5987
5988         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5989         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5990         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5991         Update.
5992         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5993         Update.
5994         * mi/mi-interp.c (mi_interp::exec): Update.
5995         * linespec.c (parse_linespec): Update.
5996         * infcall.c (run_inferior_call): Update.
5997         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5998         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5999         (gdbscm_lookup_global_symbol): Update.
6000         * guile/scm-param.c (gdbscm_parameter_value): Update.
6001         * guile/scm-frame.c (gdbscm_frame_read_register)
6002         (gdbscm_frame_read_var): Update.
6003         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6004         * exec.c (try_open_exec_file): Update.
6005         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6006         (gdb_rl_callback_handler): Update.
6007         * common/common-exceptions.h (exception_none): Don't declare.
6008         * common/common-exceptions.c (exception_none): Don't define.
6009         (struct catcher) <exception>: Update.
6010         * cli/cli-interp.c (safe_execute_command): Update.
6011         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6012
6013 2019-04-25  Ali Tamur  <tamur@google.com>
6014
6015         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6016         (read_attribute_value): Likewise.
6017         (dwarf2_read_addr_index): Update comment.
6018         (read_str_index): Add DW_FORM_strx.
6019         (dwarf2_string_attr): Likewise.
6020         (dwarf2_const_value_attr): Likewise.
6021         (dump_die_shallow): Likewise.
6022         (dwarf2_fetch_constant_bytes): Likewise.
6023         (skip_form_bytes): Likewise.
6024         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6025
6026 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6027
6028         PR corefiles/11608
6029         PR corefiles/18187
6030         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6031         OFFSET.  Verify if current mapping contains an ELF header.
6032         (linux_find_memory_regions_full): Adjust call to
6033         dump_mapping_p.
6034
6035 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6036             Kang Li <kanglictf@gmail.com>
6037
6038         PR gdb/21600
6039
6040         * dwarf2-frame.c (read_initial_length): Be consistent about using
6041         unsigned representation of length.
6042         (decode_frame_entry_1): Likewise.  Check for wraparound of
6043         end pointer as well as buffer overflow.
6044
6045 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6046
6047         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6048         "vq".
6049
6050 2019-04-24  Tom Tromey  <tromey@adacore.com>
6051
6052         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6053
6054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6055
6056         * s12z-tdep.c (s12z_unwind_pc): Delete.
6057         (s12z_unwind_sp): Delete.
6058         (s12z_gdbarch_init): Don't register deleted functions with
6059         gdbarch.
6060
6061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6062
6063         * rl78-tdep.c (rl78_unwind_sp): Delete.
6064         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6065
6066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6067
6068         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6069         (xstormy16_unwind_pc): Delete.
6070         (xstormy16_dummy_id): Delete.
6071         (xstormy16_gdbarch_init): Don't register deleted functions with
6072         gdbarch.
6073
6074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6075
6076         * vax-tdep.c (vax_unwind_pc): Delete.
6077         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6078
6079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * v850-tdep.c (v850_unwind_sp): Delete.
6082         (v850_unwind_pc): Delete.
6083         (v850_dummy_id): Delete.
6084         (v850_gdbarch_init): Don't register deleted functions with
6085         gdbarch.
6086
6087 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6088
6089         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6090         (tilegx_unwind_pc): Delete.
6091         (tilegx_unwind_dummy_id): Delete.
6092         (tilegx_gdbarch_init): Don't register deleted functions with
6093         gdbarch.
6094
6095 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6096
6097         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6098         (tic6x_dummy_id): Delete.
6099         (tic6x_gdbarch_init): Don't register deleted functions with
6100         gdbarch.
6101
6102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6103
6104         * sparc-tdep.c (sparc_unwind_pc): Delete.
6105         (sparc32_gdbarch_init): Don't register deleted function with
6106         gdbarch.
6107
6108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * sh-tdep.c (sh_unwind_sp): Delete.
6111         (sh_unwind_pc): Delete.
6112         (sh_dummy_id): Delete.
6113         (sh_gdbarch_init): Don't register deleted functions with
6114         gdbarch.
6115
6116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6117
6118         * score-tdep.c (score_unwind_sp): Delete.
6119         (score_unwind_pc): Delete.
6120         (score_dummy_id): Delete.
6121         (score_gdbarch_init): Don't register deleted functions with
6122         gdbarch.
6123
6124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6125
6126         * rx-tdep.c (rx_unwind_pc): Delete.
6127         (rx_unwind_sp): Delete.
6128         (rx_dummy_id): Delete.
6129         (rx_gdbarch_init): Don't register deleted functions with
6130         gdbarch.  Update comment.
6131
6132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6133
6134         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6135         (rs6000_dummy_id): Delete.
6136         (rs6000_gdbarch_init): Don't register deleted functions with
6137         gdbarch.
6138
6139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6140
6141         * or1k-tdep.c (or1k_dummy_id): Delete.
6142         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6143
6144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6145
6146         * nios2-tdep.c (nios2_dummy_id): Delete.
6147         (nios2_unwind_sp): Delete.
6148         (nios2_gdbarch_init): Don't register deleted functions with
6149         gdbarch.
6150
6151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6152
6153         * nds32-tdep.c (nds32_dummy_id): Delete.
6154         (nds32_unwind_pc): Delete.
6155         (nds32_unwind_sp): Delete.
6156         (nds32_gdbarch_init): Don't register deleted functions with
6157         gdbarch.
6158
6159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6160
6161         * msp430-tdep.c (msp430_unwind_pc): Delete.
6162         (msp430_unwind_sp): Delete.
6163         (msp430_dummy_id): Delete.
6164         (msp430_gdbarch_init): Don't register deleted functions with
6165         gdbarch.
6166
6167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * moxie-tdep.c (moxie_unwind_sp): Delete.
6170         (moxie_unwind_pc): Delete.
6171         (moxie_dummy_id): Delete.
6172         (moxie_gdbarch_init): Don't register deleted functions with
6173         gdbarch.
6174
6175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6176
6177         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6178         (mn10300_unwind_pc): Delete.
6179         (mn10300_unwind_sp): Delete.
6180         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6181         mn10300_unwind_sp.
6182         (mn10300_frame_unwind_init): Don't register deleted functions with
6183         gdbarch.
6184
6185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6186
6187         * mep-tdep.c (mep_unwind_pc): Delete.
6188         (mep_unwind_sp): Delete.
6189         (mep_dummy_id): Delete.
6190         (mep_gdbarch_init): Don't register deleted functions with
6191         gdbarch.
6192
6193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6194
6195         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6196         (m68hc11_unwind_sp): Delete.
6197         (m68hc11_gdbarch_init): Don't register deleted functions with
6198         gdbarch.
6199
6200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6201
6202         * m32r-tdep.c (m32r_unwind_sp): Delete.
6203         (m32r_unwind_pc): Delete.
6204         (m32r_dummy_id): Delete.
6205         (m32r_gdbarch_init): Don't register deleted functions with
6206         gdbarch.
6207
6208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6209
6210         * m32c-tdep.c (m32c_unwind_pc): Delete.
6211         (m32c_unwind_sp): Delete.
6212         (m32c_dummy_id): Delete.
6213         (m32c_gdbarch_init): Don't register deleted functions with
6214         gdbarch.
6215
6216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6217
6218         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6219         (lm32_unwind_pc): Delete.
6220         (lm32_dummy_id): Delete.
6221         (lm32_gdbarch_init): Don't register deleted functions with
6222         gdbarch.
6223
6224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6227         (iq2000_unwind_pc): Delete.
6228         (iq2000_dummy_id): Delete.
6229         (iq2000_gdbarch_init): Don't register deleted functions with
6230         gdbarch.
6231
6232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * nds32-tdep.c (nds32_type_align): Delete.
6235         (nds32_push_dummy_call): Use type_align instead.
6236
6237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6238
6239         * arm-tdep.c (arm_type_align): Only handle vector override case.
6240         (arm_push_dummy_call): Use type_align.
6241         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6242
6243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6244
6245         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6246         case.
6247         (pass_on_stack): Use type_align.
6248         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6249         function.
6250
6251 2019-04-23  Tom Tromey  <tromey@adacore.com>
6252
6253         * dwarf2read.c (line_header::file_name_at): Remove unused
6254         overload.
6255
6256 2019-04-23  Tom de Vries  <tdevries@suse.de>
6257
6258         PR gdb/24438
6259         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6260         invocation.
6261
6262
6263 2019-03-27  Ali Tamur  <tamur@google.com>
6264
6265         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6266         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6267         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6268         (dwarf_expr_context::get_addr_index): Likewise
6269         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6270         (symbol_needs_eval_context::get_addr_index): Likewise
6271         (disassemble_dwarf_expression): Add DW_OP_addrx
6272         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6273         (read_cutu_die_from_dwo): Update comment
6274         (skip_one_die): Add DW_FORM_addrx
6275         (read_attribute_value): Likewise
6276         (var_decode_location): Add DW_OP_addrx
6277         (dwarf2_const_value_attr): Add DW_FORM_addrx
6278         (dump_die_shallow): Likewise
6279         (dwarf2_fetch_constant_bytes): Likewise
6280         (decode_locdesc): Add DW_OP_addrx
6281         (skip_form_bytes): Add DW_FORM_addrx
6282
6283 2019-04-22  Ali Tamur  <tamur@google.com>
6284
6285         * MAINTAINERS (Write After Approval): Add self.
6286
6287 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6288
6289         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6290         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6291         (open_symbol_file_object): Likewise.
6292         (svr4_default_sos): Add info parameter.
6293         (svr4_read_so_list): Likewise.
6294         (svr4_current_sos_direct): Adjust functions calls to pass down
6295         info.
6296         (svr4_current_sos_1): Add info parameter.
6297         (svr4_current_sos): Call get_svr4_info, pass info down to
6298         svr4_current_sos_1.
6299         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6300         get_svr4_info.
6301         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6302         get_svr4_info.
6303         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6304         to get_svr4_info.
6305         (probes_table_remove_objfile_probes): Likewise.
6306         (register_solib_event_probe): Add info parameter.
6307         (solist_update_incremental): Pass info parameter down to
6308         svr4_read_so_list.
6309         (disable_probes_interface): Add info parameter.
6310         (svr4_handle_solib_event): Pass current_program_space to
6311         get_svr4_info.  Adjust disable_probes_interface cleanup.
6312         (svr4_create_probe_breakpoints): Add info parameter, pass it
6313         down to register_solib_event_probe.
6314         (svr4_create_solib_event_breakpoints): Add info parameter,
6315         pass it down to svr4_create_probe_breakpoints.
6316         (enable_break): Pass info down to
6317         svr4_create_solib_event_breakpoints.
6318         (svr4_solib_create_inferior_hook): Pass current_program_space to
6319         get_svr4_info.
6320         (svr4_clear_solib): Likewise.
6321
6322 2019-04-22  Pedro Alves  <palves@redhat.com>
6323
6324         * solib-svr4.c (svr4_free_objfile_observer): New.
6325         (probe_and_action::objfile): New field.
6326         (probes_table_htab_remove_objfile_probes)
6327         (probes_table_remove_objfile_probes): New functions.
6328         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6329         in the new probe_and_action.  Don't store the probe in 'lookup'.
6330         (svr4_create_probe_breakpoints): Pass objfile to
6331         register_solib_event_probe.
6332         (_initialize_svr4_solib): Register a free_objfile observer.
6333
6334 2019-04-19  Tom Tromey  <tom@tromey.com>
6335
6336         * common/queue.h: Remove.
6337
6338 2019-04-19  Tom Tromey  <tom@tromey.com>
6339
6340         * event-loop.c: Don't include "common/queue.h".
6341
6342 2019-04-19  Tom Tromey  <tom@tromey.com>
6343
6344         * remote.c (remote_target): Use delete.
6345         * remote-notif.h: Include <list>, not "common/queue.h".
6346         (notif_client_p): Remove typedef.
6347         (remote_notif_state): Add constructor, destructor, initializer.
6348         <notif_queue>: Now a std::list.
6349         (remote_notif_state_xfree): Don't declare.
6350         * remote-notif.c (remote_notif_process, handle_notification)
6351         (remote_notif_state_allocate): Update.
6352         (~remote_notif_state): Rename from remote_notif_state_xfree.
6353
6354 2019-04-19  Tom Tromey  <tom@tromey.com>
6355
6356         * symfile.c (reread_symbols): Update.
6357         * objfiles.c (objfile_register_static_link)
6358         (objfile_lookup_static_link): Update
6359         (~objfile) Don't delete static_links.
6360         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6361
6362 2019-04-19  Tom Tromey  <tom@tromey.com>
6363
6364         * type-stack.h (struct type_stack) <insert>: Constify string.
6365         * type-stack.c (type_stack::insert): Constify string.
6366         * gdbtypes.h (lookup_template_type): Update.
6367         (address_space_name_to_int): Update.
6368         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6369         const.
6370         (lookup_template_type): Make name const.
6371         * c-exp.y: Update rules.
6372         (lex_one_token, classify_name, classify_inner_name)
6373         (c_print_token): Update.
6374         * p-exp.y: Update rules.
6375         (yylex): Update.
6376         * f-exp.y: Update rules.
6377         (yylex): Update.
6378         * d-exp.y: Update rules.
6379         (lex_one_token, classify_name, classify_inner_name): Update.
6380         * parse.c (write_dollar_variable, copy_name): Return std::string.
6381         * parser-defs.h (copy_name): Change return type.
6382         * m2-exp.y: Update rules.
6383         (yylex): Update.
6384         * go-exp.y (lex_one_token): Update.
6385         Update rules.
6386         (classify_unsafe_function, classify_packaged_name)
6387         (classify_name, yylex): Update.
6388
6389 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6390
6391         * configure.ac: add --enable-source-highlight switch.
6392         * configure: Regenerate.
6393         * top.c (print_gdb_version): plumb --enable-source-highlight
6394         status to "show configuration".
6395
6396 2019-04-19  Tom Tromey  <tromey@adacore.com>
6397
6398         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6399         Check ADA_TYPE_P.
6400         (empty_record, ada_template_to_fixed_record_type_1)
6401         (template_to_static_fixed_type)
6402         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6403         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6404         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6405         macros.
6406
6407 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6408
6409         PR symtab/24423:
6410         * source.c (print_source_lines_base): Advance "iter" when a
6411         control character is seen.
6412
6413 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6414
6415         * inferior.h (struct infcall_suspend_state_deleter):
6416         Catch exception in destructor to avoid crash.
6417
6418 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6419
6420         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6421         close to the add_com "shell".
6422
6423 2019-04-18  Tom Tromey  <tromey@adacore.com>
6424
6425         * process-stratum-target.h (class process_stratum_target)
6426         <stratum>: Add "final".
6427
6428 2019-04-17  Tom Tromey  <tromey@adacore.com>
6429
6430         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6431         against nullptr before use.
6432
6433 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6434
6435         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6436
6437 2019-04-17  Jim Wilson  <jimw@sifive.com>
6438             Andrew Burgess  <andrew.burgess@embecosm.com>
6439
6440         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6441         code read might fail, assume 4-byte breakpoint in that case.
6442
6443 2019-04-15  Leszek Swirski  <leszeks@google.com>
6444
6445         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6446         rather than a hand-rolled POD check when checking for forced MEMORY
6447         classification.
6448
6449 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6450
6451         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6452         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6453         function.
6454         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6455         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6456         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6457         declaration.
6458
6459 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6460
6461         * aarch64-linux-nat.c
6462         (aarch64_linux_nat_target::thread_architecture): Add override.
6463         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6464         each VQ.
6465
6466 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6467
6468         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6469
6470 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6471
6472         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6473         target types of size 96-bits, add some additional comments, and
6474         check that the builtin type we found was the correct size.
6475
6476 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6477
6478         * utils.c (prompt_for_continue): Don't restore the styling at the
6479         end, as applied_style has the wrong value.  This fixes styling in
6480         long lists of file names that are interrupted by the "Continue?"
6481         prompt.
6482
6483 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6486         * c-lang.c (c_language_defn): Likewise.
6487         (cplus_language_defn): Likewise.
6488         (asm_language_defn): Likewise.
6489         (minimal_language_defn): Likewise.
6490         * d-lang.c (d_language_defn): Likewise.
6491         * f-lang.c (f_language_defn): Likewise.
6492         * go-lang.c (go_language_defn): Likewise.
6493         * language.c (unknown_language_defn): Likewise.
6494         (auto_language_defn): Likewise.
6495         * language.h (struct language_defn): Remove la_magic field.
6496         (LANG_MAGIC): Delete.
6497         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6498         * objc-lang.c (objc_language_defn): Likewise.
6499         * opencl-lang.c (opencl_language_defn): Likewise.
6500         * p-lang.c (pascal_language_defn): Likewise.
6501         * rust-lang.c (rust_language_defn): Likewise.
6502
6503 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * riscv-tdep.c (riscv_type_align): New function.
6506         (riscv_type_alignment): Delete.
6507         (riscv_arg_location): Use 'type_align'.
6508         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6509
6510 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         * gdbtypes.c (type_align): A struct with no non-static fields also
6513         has alignment of 1.
6514
6515 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6518         component to 0.
6519         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6520         member.
6521         (riscv_struct_info::analyse): New implementation using new
6522         analyse_inner member function.
6523         (riscv_struct_info::field_offset): New member function.
6524         (riscv_struct_info::m_offsets): New member variable.
6525         (riscv_struct_info::analyse_inner): New private member function,
6526         takes the old implementation of riscv_struct_info::analyse but
6527         extended to track field offsets.
6528         (riscv_call_arg_struct): Update the struct folding special cases
6529         to handle cases where empty C++ structs, which are non-zero
6530         length, are found.
6531         (riscv_arg_location): Initialise the length of each location, a
6532         non-zero length now indicates the location is in use.
6533         (riscv_push_dummy_call): Allow for the first location having a
6534         non-zero offset when setting up arguments.
6535         (riscv_return_value): Likewise, but for return values.
6536
6537 2019-04-11  Tom Tromey  <tromey@adacore.com>
6538
6539         * utils.c (internal_vproblem): Make "msg" const.
6540
6541 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6542
6543         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6544         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6545         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6546         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6547
6548 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6549
6550         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6551         function.
6552         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6553         of amd64_collect_native_gregset.
6554         (amd64_linux_nat_target::store_registers): Likewise.
6555
6556 2019-04-10  Tom Tromey  <tom@tromey.com>
6557
6558         * symtab.c (lookup_global_symbol_from_objfile)
6559         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6560         * objfiles.h (class separate_debug_iterator): New.
6561         (class separate_debug_range): New.
6562         (struct objfile) <separate_debug_objfiles>: New method.
6563         (objfile_separate_debug_iterate): Don't declare.
6564         * objfiles.c (separate_debug_iterator::operator++): Rename from
6565         objfile_separate_debug_iterate.
6566         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6567         iterator.
6568         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6569         iterator.
6570
6571 2019-04-10  Tom Tromey  <tom@tromey.com>
6572
6573         * symfile.c (reread_symbols): Remove old comment.
6574         * objfiles.c (free_all_objfiles): Fix a typo.
6575
6576 2019-04-10  Tom Tromey  <tom@tromey.com>
6577
6578         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6579         * minsyms.c (lookup_minimal_symbol): Use foreach.
6580         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6581         (lookup_minimal_symbol_solib_trampoline): Likewise.
6582         * symfile.c (reread_symbols): Use foreach.
6583
6584 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6585             Tom Tromey  <tromey@adacore.com>
6586
6587         PR rust/24414:
6588         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6589         (rust_lex_int_test): Change "value" to be LONGEST.
6590         (rust_lex_tests): Add test for long integer literal.
6591
6592 2019-04-09  Tom Tromey  <tromey@adacore.com>
6593
6594         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6595         to bool.
6596         (extended_remote_target::attach): Update.
6597         (remote_target::remote_notice_new_inferior): Update.
6598         (remote_target::add_current_inferior_and_thread): Update.
6599         * inferior.c (exit_inferior_1): Use "false".
6600         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6601
6602 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6603
6604         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6605         the "start" command.
6606
6607 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6608
6609         * python/py-inferior.c (infpy_thread_from_thread_handle):
6610         Adjust comments to reflect renaming of thread_from_thread_handle
6611         to thread_from_handle.  Adjust keywords.  Fix type error message.
6612         (inferior_object_methods): Add thread_from_handle.  Retain
6613         thread_from_thread_handle, but mark it as deprecated.
6614
6615 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6616
6617         * gdbthread.h (find_thread_by_handle): Revise declaration.
6618         * thread.c (find_thread_by_handle): Likewise.  Adjust
6619         implementation too.
6620         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6621         support for buffer objects as handles.
6622
6623 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6624
6625         * python/py-infthread.c (thpy_thread_handle): New function.
6626         (thread_object_methods): Register thpy_thread_handle.
6627
6628 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6629
6630         * gdbthread.h (thread_to_thread_handle): Declare.
6631         * thread.c (gdbtypes.h): Include.
6632         (thread_to_thread_handle): New function.
6633
6634         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6635         (target_thread_info_to_thread_handle): Declare.
6636         * target.c (target_thread_info_to_thread_handle): New function.
6637         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6638         * target-delegates.c: Regenerate.
6639
6640         * linux-thread-db.c (class thread_db_target): Add method
6641         thread_info_to_thread_handle.
6642         (thread_db_target::thread_info_to_thread_handle): Define.
6643         * remote.c (class remote_target): Add new method
6644         thread_info_to_thread_handle.
6645         (remote_target::thread_info_to_thread_handle): Define.
6646
6647 2019-04-08  Pedro Alves  <palves@redhat.com>
6648
6649         * common/common-exceptions.c (throw_exception): Don't create
6650         named object to throw; throw directly.
6651         (throw_it): Likewise.  Don't initialize gdb_exception::message
6652         here, with new; pass FMT and AP to the ctor instead.
6653         * common/common-exceptions.h: Include <string>.
6654         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6655         const char *, va_list)): New ctor.  Use std::make_shared.
6656         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6657         errors)): Delete.
6658         (gdb_exception_error::gdb_exception_error(enum errors, const char
6659         *, va_list)): New.
6660         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6661         Add assertion.
6662         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6663         errors)): Delete.
6664         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6665         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6666         Add assertion.
6667
6668 2019-04-08  Tom Tromey  <tom@tromey.com>
6669
6670         * valops.c (value_rtti_indirect_type): Replace throw_exception
6671         with throw.
6672         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6673         with throw.
6674         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6675         throw.
6676         * target.c (target_translate_tls_address): Replace throw_exception
6677         with throw.
6678         * stack.c (frame_apply_command_count): Replace throw_exception
6679         with throw.
6680         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6681         throw.
6682         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6683         with throw.
6684         * rs6000-tdep.c (rs6000_frame_cache)
6685         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6686         * remote.c: Replace throw_exception with throw.
6687         * record-full.c (record_full_message, record_full_wait_1)
6688         (record_full_restore): Replace throw_exception with throw.
6689         * record-btrace.c:
6690         (get_thread_current_frame_id, record_btrace_start_replaying)
6691         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6692         (cmd_record_btrace_start): Replace throw_exception with throw.
6693         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6694         throw.
6695         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6696         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6697         * linespec.c:
6698         (find_linespec_symbols): Replace throw_exception with throw.
6699         * infrun.c (displaced_step_prepare, resume): Replace
6700         throw_exception with throw.
6701         * infcmd.c (post_create_inferior): Replace throw_exception with
6702         throw.
6703         * inf-loop.c (inferior_event_handler): Replace throw_exception
6704         with throw.
6705         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6706         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6707         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6708         (get_prev_frame_always, get_frame_pc_if_available)
6709         (get_frame_address_in_block_if_available, get_frame_language):
6710         Replace throw_exception with throw.
6711         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6712         throw_exception with throw.
6713         * eval.c (fetch_subexp_value, evaluate_var_value)
6714         (evaluate_funcall, evaluate_subexp_standard): Replace
6715         throw_exception with throw.
6716         * dwarf2loc.c (call_site_find_chain)
6717         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6718         Replace throw_exception with throw.
6719         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6720         with throw.
6721         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6722         throw.
6723         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6724         * completer.c (complete_line_internal): Replace throw_exception
6725         with throw.
6726         * compile/compile-object-run.c (compile_object_run): Replace
6727         throw_exception with throw.
6728         * cli/cli-script.c (process_next_line): Replace throw_exception
6729         with throw.
6730         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6731         (btrace_enable, btrace_maint_update_pt_packets): Replace
6732         throw_exception with throw.
6733         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6734         throw_exception with throw.
6735         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6736         throw_exception with throw.
6737         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6738         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6739         * aarch64-tdep.c (aarch64_make_prologue_cache)
6740         (aarch64_make_stub_cache): Replace throw_exception with throw.
6741
6742 2019-04-08  Tom Tromey  <tom@tromey.com>
6743
6744         * common/common-exceptions.c (throw_exception): Rename from
6745         throw_exception_cxx.  Remove old copy.  Make argument const.
6746         (throw_it): Create and throw exception objects directly.
6747         * common/common-exceptions.h (throw_exception): Make argument
6748         const.
6749         (struct gdb_exception_error): Add constructor.
6750         (struct gdb_exception_quit): Add constructor.
6751
6752 2019-04-08  Tom Tromey  <tom@tromey.com>
6753
6754         * common/common-exceptions.h (exception_rethrow): Don't declare.
6755         (TRY_SJLJ): Update comment.
6756         (TRY, CATCH, END_CATCH): Remove.
6757         * common/common-exceptions.c (exception_rethrow): Remove.
6758
6759 2019-04-08  Tom Tromey  <tom@tromey.com>
6760
6761         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6762         Remove.
6763         (gdb_exception_error): Rename from
6764         gdb_exception_RETURN_MASK_ERROR.
6765         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6766         (gdb_quit_bad_alloc): Update.
6767         * aarch64-tdep.c: Update.
6768         * ada-lang.c: Update.
6769         * ada-typeprint.c: Update.
6770         * ada-valprint.c: Update.
6771         * amd64-tdep.c: Update.
6772         * arch-utils.c: Update.
6773         * break-catch-throw.c: Update.
6774         * breakpoint.c: Update.
6775         * btrace.c: Update.
6776         * c-varobj.c: Update.
6777         * cli/cli-cmds.c: Update.
6778         * cli/cli-interp.c: Update.
6779         * cli/cli-script.c: Update.
6780         * common/common-exceptions.c: Update.
6781         * common/new-op.c: Update.
6782         * common/selftest.c: Update.
6783         * compile/compile-c-symbols.c: Update.
6784         * compile/compile-cplus-symbols.c: Update.
6785         * compile/compile-object-load.c: Update.
6786         * compile/compile-object-run.c: Update.
6787         * completer.c: Update.
6788         * corelow.c: Update.
6789         * cp-abi.c: Update.
6790         * cp-support.c: Update.
6791         * cp-valprint.c: Update.
6792         * darwin-nat.c: Update.
6793         * disasm-selftests.c: Update.
6794         * dtrace-probe.c: Update.
6795         * dwarf-index-cache.c: Update.
6796         * dwarf-index-write.c: Update.
6797         * dwarf2-frame-tailcall.c: Update.
6798         * dwarf2-frame.c: Update.
6799         * dwarf2loc.c: Update.
6800         * dwarf2read.c: Update.
6801         * eval.c: Update.
6802         * event-loop.c: Update.
6803         * event-top.c: Update.
6804         * exec.c: Update.
6805         * f-valprint.c: Update.
6806         * fbsd-tdep.c: Update.
6807         * frame-unwind.c: Update.
6808         * frame.c: Update.
6809         * gdbtypes.c: Update.
6810         * gnu-v3-abi.c: Update.
6811         * guile/guile-internal.h: Update.
6812         * guile/scm-block.c: Update.
6813         * guile/scm-breakpoint.c: Update.
6814         * guile/scm-cmd.c: Update.
6815         * guile/scm-disasm.c: Update.
6816         * guile/scm-frame.c: Update.
6817         * guile/scm-lazy-string.c: Update.
6818         * guile/scm-math.c: Update.
6819         * guile/scm-param.c: Update.
6820         * guile/scm-ports.c: Update.
6821         * guile/scm-pretty-print.c: Update.
6822         * guile/scm-symbol.c: Update.
6823         * guile/scm-symtab.c: Update.
6824         * guile/scm-type.c: Update.
6825         * guile/scm-value.c: Update.
6826         * i386-linux-tdep.c: Update.
6827         * i386-tdep.c: Update.
6828         * inf-loop.c: Update.
6829         * infcall.c: Update.
6830         * infcmd.c: Update.
6831         * infrun.c: Update.
6832         * jit.c: Update.
6833         * language.c: Update.
6834         * linespec.c: Update.
6835         * linux-fork.c: Update.
6836         * linux-nat.c: Update.
6837         * linux-tdep.c: Update.
6838         * linux-thread-db.c: Update.
6839         * main.c: Update.
6840         * mi/mi-cmd-break.c: Update.
6841         * mi/mi-cmd-stack.c: Update.
6842         * mi/mi-interp.c: Update.
6843         * mi/mi-main.c: Update.
6844         * objc-lang.c: Update.
6845         * p-valprint.c: Update.
6846         * parse.c: Update.
6847         * ppc-linux-tdep.c: Update.
6848         * printcmd.c: Update.
6849         * python/py-arch.c: Update.
6850         * python/py-breakpoint.c: Update.
6851         * python/py-cmd.c: Update.
6852         * python/py-finishbreakpoint.c: Update.
6853         * python/py-frame.c: Update.
6854         * python/py-framefilter.c: Update.
6855         * python/py-gdb-readline.c: Update.
6856         * python/py-inferior.c: Update.
6857         * python/py-infthread.c: Update.
6858         * python/py-lazy-string.c: Update.
6859         * python/py-linetable.c: Update.
6860         * python/py-objfile.c: Update.
6861         * python/py-param.c: Update.
6862         * python/py-prettyprint.c: Update.
6863         * python/py-progspace.c: Update.
6864         * python/py-record-btrace.c: Update.
6865         * python/py-record.c: Update.
6866         * python/py-symbol.c: Update.
6867         * python/py-type.c: Update.
6868         * python/py-unwind.c: Update.
6869         * python/py-utils.c: Update.
6870         * python/py-value.c: Update.
6871         * python/python.c: Update.
6872         * record-btrace.c: Update.
6873         * record-full.c: Update.
6874         * remote-fileio.c: Update.
6875         * remote.c: Update.
6876         * riscv-tdep.c: Update.
6877         * rs6000-aix-tdep.c: Update.
6878         * rs6000-tdep.c: Update.
6879         * rust-exp.y: Update.
6880         * rust-lang.c: Update.
6881         * s390-tdep.c: Update.
6882         * selftest-arch.c: Update.
6883         * solib-dsbt.c: Update.
6884         * solib-frv.c: Update.
6885         * solib-spu.c: Update.
6886         * solib-svr4.c: Update.
6887         * solib.c: Update.
6888         * sparc64-linux-tdep.c: Update.
6889         * stack.c: Update.
6890         * symfile-mem.c: Update.
6891         * symmisc.c: Update.
6892         * target.c: Update.
6893         * thread.c: Update.
6894         * top.c: Update.
6895         * tracefile-tfile.c: Update.
6896         * tui/tui.c: Update.
6897         * typeprint.c: Update.
6898         * unittests/cli-utils-selftests.c: Update.
6899         * unittests/parse-connection-spec-selftests.c: Update.
6900         * valops.c: Update.
6901         * valprint.c: Update.
6902         * value.c: Update.
6903         * varobj.c: Update.
6904         * windows-nat.c: Update.
6905         * x86-linux-nat.c: Update.
6906         * xml-support.c: Update.
6907
6908 2019-04-08  Tom Tromey  <tom@tromey.com>
6909
6910         * xml-support.c: Use C++ exception handling.
6911         * x86-linux-nat.c: Use C++ exception handling.
6912         * windows-nat.c: Use C++ exception handling.
6913         * varobj.c: Use C++ exception handling.
6914         * value.c: Use C++ exception handling.
6915         * valprint.c: Use C++ exception handling.
6916         * valops.c: Use C++ exception handling.
6917         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6918         handling.
6919         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6920         * typeprint.c: Use C++ exception handling.
6921         * tui/tui.c: Use C++ exception handling.
6922         * tracefile-tfile.c: Use C++ exception handling.
6923         * top.c: Use C++ exception handling.
6924         * thread.c: Use C++ exception handling.
6925         * target.c: Use C++ exception handling.
6926         * symmisc.c: Use C++ exception handling.
6927         * symfile-mem.c: Use C++ exception handling.
6928         * stack.c: Use C++ exception handling.
6929         * sparc64-linux-tdep.c: Use C++ exception handling.
6930         * solib.c: Use C++ exception handling.
6931         * solib-svr4.c: Use C++ exception handling.
6932         * solib-spu.c: Use C++ exception handling.
6933         * solib-frv.c: Use C++ exception handling.
6934         * solib-dsbt.c: Use C++ exception handling.
6935         * selftest-arch.c: Use C++ exception handling.
6936         * s390-tdep.c: Use C++ exception handling.
6937         * rust-lang.c: Use C++ exception handling.
6938         * rust-exp.y: Use C++ exception handling.
6939         * rs6000-tdep.c: Use C++ exception handling.
6940         * rs6000-aix-tdep.c: Use C++ exception handling.
6941         * riscv-tdep.c: Use C++ exception handling.
6942         * remote.c: Use C++ exception handling.
6943         * remote-fileio.c: Use C++ exception handling.
6944         * record-full.c: Use C++ exception handling.
6945         * record-btrace.c: Use C++ exception handling.
6946         * python/python.c: Use C++ exception handling.
6947         * python/py-value.c: Use C++ exception handling.
6948         * python/py-utils.c: Use C++ exception handling.
6949         * python/py-unwind.c: Use C++ exception handling.
6950         * python/py-type.c: Use C++ exception handling.
6951         * python/py-symbol.c: Use C++ exception handling.
6952         * python/py-record.c: Use C++ exception handling.
6953         * python/py-record-btrace.c: Use C++ exception handling.
6954         * python/py-progspace.c: Use C++ exception handling.
6955         * python/py-prettyprint.c: Use C++ exception handling.
6956         * python/py-param.c: Use C++ exception handling.
6957         * python/py-objfile.c: Use C++ exception handling.
6958         * python/py-linetable.c: Use C++ exception handling.
6959         * python/py-lazy-string.c: Use C++ exception handling.
6960         * python/py-infthread.c: Use C++ exception handling.
6961         * python/py-inferior.c: Use C++ exception handling.
6962         * python/py-gdb-readline.c: Use C++ exception handling.
6963         * python/py-framefilter.c: Use C++ exception handling.
6964         * python/py-frame.c: Use C++ exception handling.
6965         * python/py-finishbreakpoint.c: Use C++ exception handling.
6966         * python/py-cmd.c: Use C++ exception handling.
6967         * python/py-breakpoint.c: Use C++ exception handling.
6968         * python/py-arch.c: Use C++ exception handling.
6969         * printcmd.c: Use C++ exception handling.
6970         * ppc-linux-tdep.c: Use C++ exception handling.
6971         * parse.c: Use C++ exception handling.
6972         * p-valprint.c: Use C++ exception handling.
6973         * objc-lang.c: Use C++ exception handling.
6974         * mi/mi-main.c: Use C++ exception handling.
6975         * mi/mi-interp.c: Use C++ exception handling.
6976         * mi/mi-cmd-stack.c: Use C++ exception handling.
6977         * mi/mi-cmd-break.c: Use C++ exception handling.
6978         * main.c: Use C++ exception handling.
6979         * linux-thread-db.c: Use C++ exception handling.
6980         * linux-tdep.c: Use C++ exception handling.
6981         * linux-nat.c: Use C++ exception handling.
6982         * linux-fork.c: Use C++ exception handling.
6983         * linespec.c: Use C++ exception handling.
6984         * language.c: Use C++ exception handling.
6985         * jit.c: Use C++ exception handling.
6986         * infrun.c: Use C++ exception handling.
6987         * infcmd.c: Use C++ exception handling.
6988         * infcall.c: Use C++ exception handling.
6989         * inf-loop.c: Use C++ exception handling.
6990         * i386-tdep.c: Use C++ exception handling.
6991         * i386-linux-tdep.c: Use C++ exception handling.
6992         * guile/scm-value.c: Use C++ exception handling.
6993         * guile/scm-type.c: Use C++ exception handling.
6994         * guile/scm-symtab.c: Use C++ exception handling.
6995         * guile/scm-symbol.c: Use C++ exception handling.
6996         * guile/scm-pretty-print.c: Use C++ exception handling.
6997         * guile/scm-ports.c: Use C++ exception handling.
6998         * guile/scm-param.c: Use C++ exception handling.
6999         * guile/scm-math.c: Use C++ exception handling.
7000         * guile/scm-lazy-string.c: Use C++ exception handling.
7001         * guile/scm-frame.c: Use C++ exception handling.
7002         * guile/scm-disasm.c: Use C++ exception handling.
7003         * guile/scm-cmd.c: Use C++ exception handling.
7004         * guile/scm-breakpoint.c: Use C++ exception handling.
7005         * guile/scm-block.c: Use C++ exception handling.
7006         * guile/guile-internal.h: Use C++ exception handling.
7007         * gnu-v3-abi.c: Use C++ exception handling.
7008         * gdbtypes.c: Use C++ exception handling.
7009         * frame.c: Use C++ exception handling.
7010         * frame-unwind.c: Use C++ exception handling.
7011         * fbsd-tdep.c: Use C++ exception handling.
7012         * f-valprint.c: Use C++ exception handling.
7013         * exec.c: Use C++ exception handling.
7014         * event-top.c: Use C++ exception handling.
7015         * event-loop.c: Use C++ exception handling.
7016         * eval.c: Use C++ exception handling.
7017         * dwarf2read.c: Use C++ exception handling.
7018         * dwarf2loc.c: Use C++ exception handling.
7019         * dwarf2-frame.c: Use C++ exception handling.
7020         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7021         * dwarf-index-write.c: Use C++ exception handling.
7022         * dwarf-index-cache.c: Use C++ exception handling.
7023         * dtrace-probe.c: Use C++ exception handling.
7024         * disasm-selftests.c: Use C++ exception handling.
7025         * darwin-nat.c: Use C++ exception handling.
7026         * cp-valprint.c: Use C++ exception handling.
7027         * cp-support.c: Use C++ exception handling.
7028         * cp-abi.c: Use C++ exception handling.
7029         * corelow.c: Use C++ exception handling.
7030         * completer.c: Use C++ exception handling.
7031         * compile/compile-object-run.c: Use C++ exception handling.
7032         * compile/compile-object-load.c: Use C++ exception handling.
7033         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7034         * compile/compile-c-symbols.c: Use C++ exception handling.
7035         * common/selftest.c: Use C++ exception handling.
7036         * common/new-op.c: Use C++ exception handling.
7037         * cli/cli-script.c: Use C++ exception handling.
7038         * cli/cli-interp.c: Use C++ exception handling.
7039         * cli/cli-cmds.c: Use C++ exception handling.
7040         * c-varobj.c: Use C++ exception handling.
7041         * btrace.c: Use C++ exception handling.
7042         * breakpoint.c: Use C++ exception handling.
7043         * break-catch-throw.c: Use C++ exception handling.
7044         * arch-utils.c: Use C++ exception handling.
7045         * amd64-tdep.c: Use C++ exception handling.
7046         * ada-valprint.c: Use C++ exception handling.
7047         * ada-typeprint.c: Use C++ exception handling.
7048         * ada-lang.c: Use C++ exception handling.
7049         * aarch64-tdep.c: Use C++ exception handling.
7050
7051 2019-04-08  Tom Tromey  <tom@tromey.com>
7052
7053         * xml-support.c (gdb_xml_parser::parse): Update.
7054         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7055         * value.c (show_convenience): Update.
7056         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7057         (test_parse_flags_qcs): Update.
7058         * thread.c (thr_try_catch_cmd): Update.
7059         * target.c (target_translate_tls_address): Update.
7060         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7061         (info_frame_command_core, frame_apply_command_count): Update.
7062         * rust-exp.y (rust_lex_exception_test): Update.
7063         * riscv-tdep.c (riscv_print_one_register_info): Update.
7064         * remote.c (remote_target::enable_btrace): Update.
7065         * record-btrace.c (record_btrace_enable_warn): Update.
7066         * python/py-utils.c (gdbpy_convert_exception): Update.
7067         * printcmd.c (do_one_display, print_variable_and_value): Update.
7068         * mi/mi-main.c (mi_print_exception): Update.
7069         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7070         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7071         * linux-nat.c (linux_nat_target::attach): Update.
7072         * linux-fork.c (class scoped_switch_fork_info): Update.
7073         * infrun.c (displaced_step_prepare): Update.
7074         * infcall.c (call_function_by_hand_dummy): Update.
7075         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7076         * gnu-v3-abi.c (print_one_vtable): Update.
7077         * frame.c (get_prev_frame_always): Update.
7078         * f-valprint.c (info_common_command_for_block): Update.
7079         * exec.c (try_open_exec_file): Update.
7080         * exceptions.c (print_exception, exception_print)
7081         (exception_fprintf, exception_print_same): Update.
7082         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7083         * dwarf-index-cache.c (index_cache::store)
7084         (index_cache::lookup_gdb_index): Update.
7085         * darwin-nat.c (maybe_cache_shell): Update.
7086         * cp-valprint.c (cp_print_value_fields): Update.
7087         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7088         (gcc_cplus_symbol_address): Update.
7089         * compile/compile-c-symbols.c (gcc_convert_symbol)
7090         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7091         * common/selftest.c: Update.
7092         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7093         a std::string.
7094         (exception_try_scope_entry, exception_try_scope_exit): Don't
7095         declare.
7096         (struct exception_try_scope): Remove.
7097         (TRY): Don't use exception_try_scope.
7098         (struct gdb_exception): Add constructor, operator=.
7099         <what>: New method.
7100         (struct gdb_exception_RETURN_MASK_ALL)
7101         (struct gdb_exception_RETURN_MASK_ERROR)
7102         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7103         (struct gdb_quit_bad_alloc): Update.
7104         * common/common-exceptions.c (exception_none): Change
7105         initializer.
7106         (struct catcher) <state, exception>: Initialize inline.
7107         <prev>: Remove member.
7108         (current_catcher): Remove.
7109         (catchers): New global.
7110         (exceptions_state_mc_init): Simplify.
7111         (catcher_pop): Remove.
7112         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7113         (try_scope_depth, exception_try_scope_entry)
7114         (exception_try_scope_exit): Remove.
7115         (throw_exception_sjlj): Update.
7116         (exception_messages, exception_messages_size): Remove.
7117         (throw_it): Simplify.
7118         (gdb_exception_sliced_copy): Remove.
7119         (throw_exception_cxx): Update.
7120         * cli/cli-script.c (script_from_file): Update.
7121         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7122         Update.
7123         * ada-valprint.c (ada_val_print): Update.
7124         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7125         (create_excep_cond_exprs): Update.
7126
7127 2019-04-08  Tom Tromey  <tom@tromey.com>
7128
7129         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7130         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7131         (TRY, CATCH, END_CATCH): Remove some definitions.
7132         * common/common-exceptions.c: Don't use GDB_XCPT.
7133         (catcher_list_size): Remove.
7134         (throw_exception, throw_it): Simplify.
7135
7136 2019-04-05  Tom Tromey  <tom@tromey.com>
7137
7138         Revert the header-sorting patch.
7139         * ft32-tdep.c: Revert.
7140         * frv-tdep.c: Revert.
7141         * frv-linux-tdep.c: Revert.
7142         * frame.c: Revert.
7143         * frame-unwind.c: Revert.
7144         * frame-base.c: Revert.
7145         * fork-child.c: Revert.
7146         * findvar.c: Revert.
7147         * findcmd.c: Revert.
7148         * filesystem.c: Revert.
7149         * filename-seen-cache.h: Revert.
7150         * filename-seen-cache.c: Revert.
7151         * fbsd-tdep.c: Revert.
7152         * fbsd-nat.h: Revert.
7153         * fbsd-nat.c: Revert.
7154         * f-valprint.c: Revert.
7155         * f-typeprint.c: Revert.
7156         * f-lang.c: Revert.
7157         * extension.h: Revert.
7158         * extension.c: Revert.
7159         * extension-priv.h: Revert.
7160         * expprint.c: Revert.
7161         * exec.h: Revert.
7162         * exec.c: Revert.
7163         * exceptions.c: Revert.
7164         * event-top.c: Revert.
7165         * event-loop.c: Revert.
7166         * eval.c: Revert.
7167         * elfread.c: Revert.
7168         * dwarf2read.h: Revert.
7169         * dwarf2read.c: Revert.
7170         * dwarf2loc.c: Revert.
7171         * dwarf2expr.h: Revert.
7172         * dwarf2expr.c: Revert.
7173         * dwarf2-frame.c: Revert.
7174         * dwarf2-frame-tailcall.c: Revert.
7175         * dwarf-index-write.h: Revert.
7176         * dwarf-index-write.c: Revert.
7177         * dwarf-index-common.c: Revert.
7178         * dwarf-index-cache.h: Revert.
7179         * dwarf-index-cache.c: Revert.
7180         * dummy-frame.c: Revert.
7181         * dtrace-probe.c: Revert.
7182         * disasm.h: Revert.
7183         * disasm.c: Revert.
7184         * disasm-selftests.c: Revert.
7185         * dictionary.c: Revert.
7186         * dicos-tdep.c: Revert.
7187         * demangle.c: Revert.
7188         * dcache.h: Revert.
7189         * dcache.c: Revert.
7190         * darwin-nat.h: Revert.
7191         * darwin-nat.c: Revert.
7192         * darwin-nat-info.c: Revert.
7193         * d-valprint.c: Revert.
7194         * d-namespace.c: Revert.
7195         * d-lang.c: Revert.
7196         * ctf.c: Revert.
7197         * csky-tdep.c: Revert.
7198         * csky-linux-tdep.c: Revert.
7199         * cris-tdep.c: Revert.
7200         * cris-linux-tdep.c: Revert.
7201         * cp-valprint.c: Revert.
7202         * cp-support.c: Revert.
7203         * cp-namespace.c: Revert.
7204         * cp-abi.c: Revert.
7205         * corelow.c: Revert.
7206         * corefile.c: Revert.
7207         * continuations.c: Revert.
7208         * completer.h: Revert.
7209         * completer.c: Revert.
7210         * complaints.c: Revert.
7211         * coffread.c: Revert.
7212         * coff-pe-read.c: Revert.
7213         * cli-out.h: Revert.
7214         * cli-out.c: Revert.
7215         * charset.c: Revert.
7216         * c-varobj.c: Revert.
7217         * c-valprint.c: Revert.
7218         * c-typeprint.c: Revert.
7219         * c-lang.c: Revert.
7220         * buildsym.c: Revert.
7221         * buildsym-legacy.c: Revert.
7222         * build-id.h: Revert.
7223         * build-id.c: Revert.
7224         * btrace.c: Revert.
7225         * bsd-uthread.c: Revert.
7226         * breakpoint.h: Revert.
7227         * breakpoint.c: Revert.
7228         * break-catch-throw.c: Revert.
7229         * break-catch-syscall.c: Revert.
7230         * break-catch-sig.c: Revert.
7231         * blockframe.c: Revert.
7232         * block.c: Revert.
7233         * bfin-tdep.c: Revert.
7234         * bfin-linux-tdep.c: Revert.
7235         * bfd-target.c: Revert.
7236         * bcache.c: Revert.
7237         * ax-general.c: Revert.
7238         * ax-gdb.h: Revert.
7239         * ax-gdb.c: Revert.
7240         * avr-tdep.c: Revert.
7241         * auxv.c: Revert.
7242         * auto-load.c: Revert.
7243         * arm-wince-tdep.c: Revert.
7244         * arm-tdep.c: Revert.
7245         * arm-symbian-tdep.c: Revert.
7246         * arm-pikeos-tdep.c: Revert.
7247         * arm-obsd-tdep.c: Revert.
7248         * arm-nbsd-tdep.c: Revert.
7249         * arm-nbsd-nat.c: Revert.
7250         * arm-linux-tdep.c: Revert.
7251         * arm-linux-nat.c: Revert.
7252         * arm-fbsd-tdep.c: Revert.
7253         * arm-fbsd-nat.c: Revert.
7254         * arm-bsd-tdep.c: Revert.
7255         * arch-utils.c: Revert.
7256         * arc-tdep.c: Revert.
7257         * arc-newlib-tdep.c: Revert.
7258         * annotate.h: Revert.
7259         * annotate.c: Revert.
7260         * amd64-windows-tdep.c: Revert.
7261         * amd64-windows-nat.c: Revert.
7262         * amd64-tdep.c: Revert.
7263         * amd64-sol2-tdep.c: Revert.
7264         * amd64-obsd-tdep.c: Revert.
7265         * amd64-obsd-nat.c: Revert.
7266         * amd64-nbsd-tdep.c: Revert.
7267         * amd64-nbsd-nat.c: Revert.
7268         * amd64-nat.c: Revert.
7269         * amd64-linux-tdep.c: Revert.
7270         * amd64-linux-nat.c: Revert.
7271         * amd64-fbsd-tdep.c: Revert.
7272         * amd64-fbsd-nat.c: Revert.
7273         * amd64-dicos-tdep.c: Revert.
7274         * amd64-darwin-tdep.c: Revert.
7275         * amd64-bsd-nat.c: Revert.
7276         * alpha-tdep.c: Revert.
7277         * alpha-obsd-tdep.c: Revert.
7278         * alpha-nbsd-tdep.c: Revert.
7279         * alpha-mdebug-tdep.c: Revert.
7280         * alpha-linux-tdep.c: Revert.
7281         * alpha-linux-nat.c: Revert.
7282         * alpha-bsd-tdep.c: Revert.
7283         * alpha-bsd-nat.c: Revert.
7284         * aix-thread.c: Revert.
7285         * agent.c: Revert.
7286         * addrmap.c: Revert.
7287         * ada-varobj.c: Revert.
7288         * ada-valprint.c: Revert.
7289         * ada-typeprint.c: Revert.
7290         * ada-tasks.c: Revert.
7291         * ada-lang.c: Revert.
7292         * aarch64-tdep.c: Revert.
7293         * aarch64-ravenscar-thread.c: Revert.
7294         * aarch64-newlib-tdep.c: Revert.
7295         * aarch64-linux-tdep.c: Revert.
7296         * aarch64-linux-nat.c: Revert.
7297         * aarch64-fbsd-tdep.c: Revert.
7298         * aarch64-fbsd-nat.c: Revert.
7299         * aarch32-linux-nat.c: Revert.
7300
7301 2019-04-05  Tom Tromey  <tom@tromey.com>
7302
7303         * ft32-tdep.c: Sort headers.
7304         * frv-tdep.c: Sort headers.
7305         * frv-linux-tdep.c: Sort headers.
7306         * frame.c: Sort headers.
7307         * frame-unwind.c: Sort headers.
7308         * frame-base.c: Sort headers.
7309         * fork-child.c: Sort headers.
7310         * findvar.c: Sort headers.
7311         * findcmd.c: Sort headers.
7312         * filesystem.c: Sort headers.
7313         * filename-seen-cache.h: Sort headers.
7314         * filename-seen-cache.c: Sort headers.
7315         * fbsd-tdep.c: Sort headers.
7316         * fbsd-nat.h: Sort headers.
7317         * fbsd-nat.c: Sort headers.
7318         * f-valprint.c: Sort headers.
7319         * f-typeprint.c: Sort headers.
7320         * f-lang.c: Sort headers.
7321         * extension.h: Sort headers.
7322         * extension.c: Sort headers.
7323         * extension-priv.h: Sort headers.
7324         * expprint.c: Sort headers.
7325         * exec.h: Sort headers.
7326         * exec.c: Sort headers.
7327         * exceptions.c: Sort headers.
7328         * event-top.c: Sort headers.
7329         * event-loop.c: Sort headers.
7330         * eval.c: Sort headers.
7331         * elfread.c: Sort headers.
7332         * dwarf2read.h: Sort headers.
7333         * dwarf2read.c: Sort headers.
7334         * dwarf2loc.c: Sort headers.
7335         * dwarf2expr.h: Sort headers.
7336         * dwarf2expr.c: Sort headers.
7337         * dwarf2-frame.c: Sort headers.
7338         * dwarf2-frame-tailcall.c: Sort headers.
7339         * dwarf-index-write.h: Sort headers.
7340         * dwarf-index-write.c: Sort headers.
7341         * dwarf-index-common.c: Sort headers.
7342         * dwarf-index-cache.h: Sort headers.
7343         * dwarf-index-cache.c: Sort headers.
7344         * dummy-frame.c: Sort headers.
7345         * dtrace-probe.c: Sort headers.
7346         * disasm.h: Sort headers.
7347         * disasm.c: Sort headers.
7348         * disasm-selftests.c: Sort headers.
7349         * dictionary.c: Sort headers.
7350         * dicos-tdep.c: Sort headers.
7351         * demangle.c: Sort headers.
7352         * dcache.h: Sort headers.
7353         * dcache.c: Sort headers.
7354         * darwin-nat.h: Sort headers.
7355         * darwin-nat.c: Sort headers.
7356         * darwin-nat-info.c: Sort headers.
7357         * d-valprint.c: Sort headers.
7358         * d-namespace.c: Sort headers.
7359         * d-lang.c: Sort headers.
7360         * ctf.c: Sort headers.
7361         * csky-tdep.c: Sort headers.
7362         * csky-linux-tdep.c: Sort headers.
7363         * cris-tdep.c: Sort headers.
7364         * cris-linux-tdep.c: Sort headers.
7365         * cp-valprint.c: Sort headers.
7366         * cp-support.c: Sort headers.
7367         * cp-namespace.c: Sort headers.
7368         * cp-abi.c: Sort headers.
7369         * corelow.c: Sort headers.
7370         * corefile.c: Sort headers.
7371         * continuations.c: Sort headers.
7372         * completer.h: Sort headers.
7373         * completer.c: Sort headers.
7374         * complaints.c: Sort headers.
7375         * coffread.c: Sort headers.
7376         * coff-pe-read.c: Sort headers.
7377         * cli-out.h: Sort headers.
7378         * cli-out.c: Sort headers.
7379         * charset.c: Sort headers.
7380         * c-varobj.c: Sort headers.
7381         * c-valprint.c: Sort headers.
7382         * c-typeprint.c: Sort headers.
7383         * c-lang.c: Sort headers.
7384         * buildsym.c: Sort headers.
7385         * buildsym-legacy.c: Sort headers.
7386         * build-id.h: Sort headers.
7387         * build-id.c: Sort headers.
7388         * btrace.c: Sort headers.
7389         * bsd-uthread.c: Sort headers.
7390         * breakpoint.h: Sort headers.
7391         * breakpoint.c: Sort headers.
7392         * break-catch-throw.c: Sort headers.
7393         * break-catch-syscall.c: Sort headers.
7394         * break-catch-sig.c: Sort headers.
7395         * blockframe.c: Sort headers.
7396         * block.c: Sort headers.
7397         * bfin-tdep.c: Sort headers.
7398         * bfin-linux-tdep.c: Sort headers.
7399         * bfd-target.c: Sort headers.
7400         * bcache.c: Sort headers.
7401         * ax-general.c: Sort headers.
7402         * ax-gdb.h: Sort headers.
7403         * ax-gdb.c: Sort headers.
7404         * avr-tdep.c: Sort headers.
7405         * auxv.c: Sort headers.
7406         * auto-load.c: Sort headers.
7407         * arm-wince-tdep.c: Sort headers.
7408         * arm-tdep.c: Sort headers.
7409         * arm-symbian-tdep.c: Sort headers.
7410         * arm-pikeos-tdep.c: Sort headers.
7411         * arm-obsd-tdep.c: Sort headers.
7412         * arm-nbsd-tdep.c: Sort headers.
7413         * arm-nbsd-nat.c: Sort headers.
7414         * arm-linux-tdep.c: Sort headers.
7415         * arm-linux-nat.c: Sort headers.
7416         * arm-fbsd-tdep.c: Sort headers.
7417         * arm-fbsd-nat.c: Sort headers.
7418         * arm-bsd-tdep.c: Sort headers.
7419         * arch-utils.c: Sort headers.
7420         * arc-tdep.c: Sort headers.
7421         * arc-newlib-tdep.c: Sort headers.
7422         * annotate.h: Sort headers.
7423         * annotate.c: Sort headers.
7424         * amd64-windows-tdep.c: Sort headers.
7425         * amd64-windows-nat.c: Sort headers.
7426         * amd64-tdep.c: Sort headers.
7427         * amd64-sol2-tdep.c: Sort headers.
7428         * amd64-obsd-tdep.c: Sort headers.
7429         * amd64-obsd-nat.c: Sort headers.
7430         * amd64-nbsd-tdep.c: Sort headers.
7431         * amd64-nbsd-nat.c: Sort headers.
7432         * amd64-nat.c: Sort headers.
7433         * amd64-linux-tdep.c: Sort headers.
7434         * amd64-linux-nat.c: Sort headers.
7435         * amd64-fbsd-tdep.c: Sort headers.
7436         * amd64-fbsd-nat.c: Sort headers.
7437         * amd64-dicos-tdep.c: Sort headers.
7438         * amd64-darwin-tdep.c: Sort headers.
7439         * amd64-bsd-nat.c: Sort headers.
7440         * alpha-tdep.c: Sort headers.
7441         * alpha-obsd-tdep.c: Sort headers.
7442         * alpha-nbsd-tdep.c: Sort headers.
7443         * alpha-mdebug-tdep.c: Sort headers.
7444         * alpha-linux-tdep.c: Sort headers.
7445         * alpha-linux-nat.c: Sort headers.
7446         * alpha-bsd-tdep.c: Sort headers.
7447         * alpha-bsd-nat.c: Sort headers.
7448         * aix-thread.c: Sort headers.
7449         * agent.c: Sort headers.
7450         * addrmap.c: Sort headers.
7451         * ada-varobj.c: Sort headers.
7452         * ada-valprint.c: Sort headers.
7453         * ada-typeprint.c: Sort headers.
7454         * ada-tasks.c: Sort headers.
7455         * ada-lang.c: Sort headers.
7456         * aarch64-tdep.c: Sort headers.
7457         * aarch64-ravenscar-thread.c: Sort headers.
7458         * aarch64-newlib-tdep.c: Sort headers.
7459         * aarch64-linux-tdep.c: Sort headers.
7460         * aarch64-linux-nat.c: Sort headers.
7461         * aarch64-fbsd-tdep.c: Sort headers.
7462         * aarch64-fbsd-nat.c: Sort headers.
7463         * aarch32-linux-nat.c: Sort headers.
7464
7465 2019-04-04  Tom Tromey  <tom@tromey.com>
7466
7467         * varobj.c (varobj_create): Update.
7468         * rust-exp.y (struct rust_parser) <update_innermost_block,
7469         lookup_symbol>: New methods.
7470         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7471         Rename.
7472         (rust_parser::rust_lookup_type)
7473         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7474         * printcmd.c (display_command, do_one_display): Update.
7475         * parser-defs.h (struct parser_state) <parser_state>: Add
7476         "tracker" parameter.
7477         (block_tracker): New member.
7478         (class innermost_block_tracker) <innermost_block_tracker>: Add
7479         "types" parameter.
7480         <reset>: Remove method.
7481         (innermost_block): Don't declare.
7482         (null_post_parser): Update.
7483         * parse.c (innermost_block): Remove global.
7484         (write_dollar_variable): Update.
7485         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7486         Remove "tracker_types" parameter.
7487         (parse_expression): Add "tracker" parameter.
7488         (parse_expression_for_completion): Update.
7489         (null_post_parser): Add "tracker" parameter.
7490         * p-exp.y: Update rules.
7491         * m2-exp.y: Update rules.
7492         * language.h (struct language_defn) <la_post_parser>: Add
7493         "tracker" parameter.
7494         * go-exp.y: Update rules.
7495         * f-exp.y: Update rules.
7496         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7497         parameter.
7498         * d-exp.y: Update rules.
7499         * c-exp.y: Update rules.
7500         * breakpoint.c (set_breakpoint_condition): Create an
7501         innermost_block_tracker.
7502         (watch_command_1): Likewise.
7503         * ada-lang.c (resolve): Add "tracker" parameter.
7504         (resolve_subexp): Likewise.
7505         * ada-exp.y (write_var_from_sym): Update.
7506
7507 2019-04-04  Tom Tromey  <tom@tromey.com>
7508
7509         * type-stack.h: New file.
7510         * type-stack.c: New file.
7511         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7512         type-stack.h.
7513         (insert_into_type_stack, insert_type, push_type, push_type_int)
7514         (insert_type_address_space, pop_type, pop_type_int)
7515         (pop_typelist, pop_type_stack, append_type_stack)
7516         (push_type_stack, get_type_stack, push_typelist)
7517         (follow_type_instance_flags, follow_types): Don't declare.
7518         * parse.c (type_stack): Remove global.
7519         (parse_exp_in_context): Update.
7520         (insert_into_type_stack, insert_type, push_type, push_type_int)
7521         (insert_type_address_space, pop_type, pop_type_int)
7522         (pop_typelist, pop_type_stack, append_type_stack)
7523         (push_type_stack, get_type_stack, push_typelist)
7524         (follow_type_instance_flags, follow_types): Remove (moved to
7525         type-stack.c).
7526         * f-exp.y (type_stack): New global.
7527         Update rules.
7528         (push_kind_type, f_parse): Update.
7529         * d-exp.y (type_stack): New global.
7530         Update rules.
7531         (d_parse): Update.
7532         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7533         Update rules.
7534         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7535         (HFILES_NO_SRCDIR): Add type-stack.h.
7536
7537 2019-04-04  Tom Tromey  <tom@tromey.com>
7538
7539         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7540         (rust_parser::convert_ast_to_expression, rust_parse)
7541         (rust_lex_test_completion, rust_lex_tests): Update.
7542         * parser-defs.h (struct expr_completion_state): New.
7543         (struct parser_state) <parser_state>: Add completion parameter.
7544         <mark_struct_expression, mark_completion_tag>: New methods.
7545         <parse_completion, m_completion_state>: New members.
7546         (prefixify_expression, null_post_parser): Update.
7547         (mark_struct_expression, mark_completion_tag): Don't declare.
7548         * parse.c (parse_completion, expout_last_struct)
7549         (expout_tag_completion_type, expout_completion_name): Remove
7550         globals.
7551         (parser_state::mark_struct_expression)
7552         (parser_state::mark_completion_tag): Now methods.
7553         (prefixify_expression): Add last_struct parameter.
7554         (prefixify_subexp): Likewise.
7555         (parse_exp_1): Update.
7556         (parse_exp_in_context): Add cstate parameter.  Update.
7557         (parse_expression_for_completion): Create an
7558         expr_completion_state.
7559         (null_post_parser): Add "completion" parameter.
7560         * p-exp.y: Update rules.
7561         (yylex): Update.
7562         * language.h (struct language_defn) <la_post_parser>: Add
7563         "completing" parameter.
7564         * go-exp.y: Update rules.
7565         (lex_one_token): Update.
7566         * expression.h (parse_completion): Don't declare.
7567         * d-exp.y: Update rules.
7568         (lex_one_token): Update rules.
7569         * c-exp.y: Update rules.
7570         (lex_one_token): Update.
7571         * ada-lang.c (resolve): Add "parse_completion" parameter.
7572         (resolve_subexp): Likewise.
7573         (ada_resolve_function): Likewise.
7574
7575 2019-04-04  Tom Tromey  <tom@tromey.com>
7576
7577         * parser-defs.h (struct parser_state) <start_arglist,
7578         end_arglist>: New methods.
7579         <arglist_len, m_funcall_chain>: New members.
7580         (arglist_len, start_arglist, end_arglist): Don't declare.
7581         * parse.c (arglist_len, funcall_chain): Remove global.
7582         (start_arglist, end_arglist): Remove functions.
7583         (parse_exp_in_context): Update.
7584         * p-exp.y: Update rules.
7585         * m2-exp.y: Update rules.
7586         * go-exp.y: Update rules.
7587         * f-exp.y: Update rules.
7588         * d-exp.y: Update rules.
7589         * c-exp.y: Update rules.
7590
7591 2019-04-04  Tom Tromey  <tom@tromey.com>
7592
7593         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7594         lex_operator, push_back>: New methods.
7595         Update all rules.
7596         (rust_parser::lex_hex, lex_escape): Rename and update.
7597         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7598         (rust_parser::lex_operator): Rename and update.
7599         (rust_parser::lex_number, rustyylex, rustyyerror)
7600         (rust_lex_test_init, rust_lex_test_sequence)
7601         (rust_lex_test_push_back, rust_lex_tests): Update.
7602         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7603         parameter.
7604         <lexptr, prev_lexptr>: New members.
7605         (lexptr, prev_lexptr): Don't declare.
7606         * parse.c (lexptr, prev_lexptr): Remove globals.
7607         (parse_exp_in_context): Update.
7608         * p-exp.y (yylex, yyerror): Update.
7609         * m2-exp.y (parse_number, yylex, yyerror): Update.
7610         * go-exp.y (lex_one_token, yyerror): Update.
7611         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7612         * d-exp.y (lex_one_token, yyerror): Update.
7613         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7614         (lex_one_token, yyerror): Update.
7615         * ada-lex.l (YY_INPUT): Update.
7616         (rewind_to_char): Update.
7617         * ada-exp.y (yyerror): Update.
7618
7619 2019-04-04  Tom Tromey  <tom@tromey.com>
7620
7621         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7622         * parser-defs.h (struct parser_state) <parser_state>: Add new
7623         parameter.
7624         <comma_terminates>: New member.
7625         (comma_terminates): Don't declare global.
7626         * parse.c (comma_terminates): Remove global.
7627         (parse_exp_in_context): Update.
7628         * p-exp.y (yylex): Update.
7629         * m2-exp.y (yylex): Update.
7630         * go-exp.y (lex_one_token): Update.
7631         * f-exp.y (yylex): Update.
7632         * d-exp.y (lex_one_token): Update.
7633         * c-exp.y (lex_one_token): Update.
7634         * ada-lex.l: Update.
7635
7636 2019-04-04  Tom Tromey  <tom@tromey.com>
7637
7638         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7639         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7640         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7641         * parser-defs.h (paren_depth): Don't declare.
7642         * parse.c (paren_depth): Remove global.
7643         (parse_exp_in_context): Update.
7644         * p-exp.y (paren_depth): New global.
7645         (pascal_parse): Initialize it.
7646         * m2-exp.y (paren_depth): New global.
7647         (m2_parse): Initialize it.
7648         * go-exp.y (paren_depth): New global.
7649         (go_parse): Initialize it.
7650         * f-exp.y (paren_depth): New global.
7651         (f_parse): Initialize it.
7652         * d-exp.y (paren_depth): New global.
7653         (d_parse): Initialize it.
7654         * c-exp.y (paren_depth): New global.
7655         (c_parse): Initialize it.
7656         * ada-lex.l (paren_depth): New global.
7657         (lexer_init): Initialize it.
7658
7659 2019-04-04  Tom Tromey  <tom@tromey.com>
7660
7661         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7662         (rust_parser::convert_ast_to_type)
7663         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7664         * parser-defs.h (struct parser_state) <parser_state>: Add
7665         parameters.  Initialize new members.
7666         <expression_context_block, expression_context_pc>: New members.
7667         * parse.c (expression_context_block, expression_context_pc):
7668         Remove globals.
7669         (parse_exp_in_context): Update.
7670         * p-exp.y: Update all rules.
7671         (yylex): Update.
7672         * m2-exp.y: Update all rules.
7673         (yylex): Update.
7674         * go-exp.y (yylex): Update.
7675         * f-exp.y (yylex): Update.
7676         * d-exp.y: Update all rules.
7677         (yylex): Update.
7678         * c-exp.y: Update all rules.
7679         (lex_one_token, classify_name, yylex, c_parse): Update.
7680         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7681
7682 2019-04-04  Tom Tromey  <tom@tromey.com>
7683
7684         * gdbarch.h, gdbarch.c: Rebuild.
7685         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7686         * stap-probe.h:
7687         (struct stap_parse_info): Replace "parser_state" with
7688         "expr_builder".
7689         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7690         (parser_state): New class.
7691         * parse.c (expr_builder): Rename.
7692         (expr_builder::release): Rename.
7693         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7694         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7695         (write_exp_elt_longcst, write_exp_elt_floatcst)
7696         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7697         (write_exp_string_vector, write_exp_bitstring)
7698         (write_exp_msymbol, mark_struct_expression)
7699         (write_dollar_variable)
7700         (insert_type_address_space, increase_expout_size): Replace
7701         "parser_state" with "expr_builder".
7702         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7703         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7704         "parser_state" with "expr_builder".
7705
7706 2019-04-04  Tom Tromey  <tom@tromey.com>
7707
7708         * rust-exp.y: Replace "parse_language" with method call.
7709         * p-exp.y:
7710         (yylex): Replace "parse_language" with method call.
7711         * m2-exp.y:
7712         (yylex): Replace "parse_language" with method call.
7713         * go-exp.y (classify_name): Replace "parse_language" with method
7714         call.
7715         * f-exp.y (yylex): Replace "parse_language" with method call.
7716         * d-exp.y (lex_one_token): Replace "parse_language" with method
7717         call.
7718         * c-exp.y:
7719         (lex_one_token, classify_name, yylex): Replace "parse_language"
7720         with method call.
7721         * ada-exp.y (find_primitive_type, type_char)
7722         (type_system_address): Replace "parse_language" with method call.
7723
7724 2019-04-04  Tom Tromey  <tom@tromey.com>
7725
7726         * rust-exp.y: Replace "parse_gdbarch" with method call.
7727         * parse.c (write_dollar_variable, insert_type_address_space):
7728         Replace "parse_gdbarch" with method call.
7729         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7730         call.
7731         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7732         call.
7733         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7734         "parse_gdbarch" with method call.
7735         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7736         with method call.
7737         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7738         "parse_gdbarch" with method call.
7739         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7740         "parse_gdbarch" with method call.
7741         * c-exp.y (parse_type, parse_number, classify_name): Replace
7742         "parse_gdbarch" with method call.
7743         * ada-lex.l: Replace "parse_gdbarch" with method call.
7744         * ada-exp.y (parse_type, find_primitive_type, type_char)
7745         (type_system_address): Replace "parse_gdbarch" with method call.
7746
7747 2019-04-04  Tom Tromey  <tom@tromey.com>
7748
7749         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7750         * stap-probe.c (stap_parse_argument): Update.
7751         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7752         initial_size parameter.
7753         * rust-exp.y (rust_lex_tests): Update.
7754         * parse.c (parser_state): Update.
7755         (parse_exp_in_context): Update.
7756         * parser-defs.h (struct parser_state) <parser_state>: Remove
7757         "initial_size" parameter.
7758
7759 2019-04-04  Tom Tromey  <tom@tromey.com>
7760
7761         * parser-defs.h (increase_expout_size): Don't declare.
7762         * parse.c (increase_expout_size): Now static.
7763
7764 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7765
7766         * gnu-nat.c (gnu_nat_target::wait): Fix
7767         target_waitstatus_to_string call.
7768
7769 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * eval.c (evaluate_subexp_standard): Handle internal functions
7772         during Fortran function call handling.
7773
7774 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * NEWS: Mention new internal functions.
7777         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7778         (read_base_type): Use dwarf2_init_complex_target_type.
7779         * value.c (creal_internal_fn): New function.
7780         (cimag_internal_fn): New function.
7781         (_initialize_values): Register new internal functions.
7782
7783 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7784
7785         * infrun.c (stop_all_threads): If debug_infrun, always
7786         trace the wait status after wait_one, using
7787         target_waitstatus_to_string and target_pid_to_str.
7788         (handle_inferior_event): Replace various trace of
7789         wait status kind by a single trace.
7790         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7791         wait status kind image by target_waitstatus_to_string.
7792         * target/waitstatus.c (target_waitstatus_to_string): Fix
7793         obsolete comment.
7794
7795 2019-04-01  Tom Tromey  <tromey@adacore.com>
7796
7797         PR symtab/23331:
7798         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7799
7800 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7801             Pedro Alves  <palves@redhat.com>
7802
7803         * top.c (quit_force): Call 'finalize_values'.
7804         * value.c (finalize_values): New function.
7805         * value.h (finalize_values): Declare.
7806
7807 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7808
7809         * NEWS: Announce $_gdb_major and $_gdb_minor.
7810
7811         * top.c (init_gdb_version_vars): New function.
7812         (gdb_init): Call init_gdb_version_vars.
7813
7814 2019-03-29  Tom Tromey  <tromey@adacore.com>
7815
7816         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7817         help text.  Remove dead code.
7818
7819 2019-03-29  Keith Seitz  <keiths@redhat.com>
7820
7821         From Siddhesh Poyarekar:
7822         * f-lang.h (f77_get_upperbound): Return LONGEST.
7823         (f77_get_lowerbound): Likewise.
7824         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7825         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7826         print them.
7827         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7828         plongest to format print it.
7829         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7830         (f77_get_upperbound): Likewise.
7831         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7832         LOWER_BOUND to LONGEST.
7833         (f77_create_arrayprint_offset_tbl): Likewise.
7834
7835 2019-03-29  Keith Seitz  <keiths@redhat.com>
7836
7837         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7838         %s/pulongest for TYPE_LENGTH instead of %d in format
7839         strings.
7840         * ada-typerint.c (ada_print_type): Likewise.
7841         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7842         * compile/compile-c-support.c (generate_register_struct): Likewise.
7843         * gdbtypes.c (recursive_dump_type): Likewise.
7844         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7845         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7846         instead of %d in format strings.
7847         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7848         to std::min to ULONGEST.
7849         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7850         instead of %d in format strings.
7851         * tracepoint.c (info_scope_command): Likewise.
7852         * typeprint.c (print_offset_data::update)
7853         (print_offset_data::finish): Likewise.
7854         * xtensa-tdep.c (xtensa_store_return_value)
7855         (xtensa_push_dummy_call): Likewise.
7856
7857 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7858
7859         * windows-nat.c (display_selector): Fixed format specifications
7860         for 64-bit Cygwin.
7861
7862 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7863
7864         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7865
7866 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7867
7868         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7869         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7870         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7871         (nios2_linux_init_abi): Install it.
7872
7873 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7874
7875         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7876
7877 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7878
7879         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7880
7881 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7882             Tom Tromey  <tromey@adacore.com>
7883
7884         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7885
7886 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7887
7888         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7889         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7890         method to compute the bounds of range types. Also print "[evaluated]"
7891         if the bounds' values come from a dynamic evaluation.
7892
7893 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7896         whitespace when pretty printing is on.
7897
7898 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7899
7900         * ppc-linux-nat.c: Add include.
7901
7902 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7903
7904         * NEWS: Mention AArch64 Pointer Authentication.
7905
7906 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7907
7908         * arm-linux-nat.c: Add include.
7909
7910 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7911
7912         * source-cache.c (source_cache::get_source_lines): Re-read
7913         fullname after calling open_source_file.
7914
7915 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7916
7917         * NEWS: Mention TLS support for FreeBSD.
7918
7919 2019-03-25  Tom Tromey  <tromey@adacore.com>
7920
7921         * minsyms.c (BUNCH_SIZE): Update comment.
7922         (~minimal_symbol_reader): Remove old comment.
7923         (compact_minimal_symbols): Update comment.
7924         (minimal_symbol_reader::install): Remove old comment.  Update
7925         other comments.
7926
7927 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7928
7929         * s390-linux-nat.c: Add include.
7930
7931 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7932
7933         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7934         Call linux_get_hwcap.
7935         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7936         Likewise.
7937         (aarch64_linux_get_hwcap): Remove function.
7938         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7939         declaration.
7940         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7941         linux_get_hwcap.
7942         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7943         * linux-tdep.c (linux_get_hwcap): Add function.
7944         (linux_get_hwcap2): Likewise.
7945         * linux-tdep.h (linux_get_hwcap): Add declaration.
7946         (linux_get_hwcap2): Likewise.
7947         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7948         (ppc_linux_get_hwcap2): Likewise.
7949         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7950         linux_get_hwcap.
7951         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7952         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7953         (ppc_linux_nat_target::read_description): Likewise.
7954         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7955         * s390-linux-nat.c: Likewise.
7956         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7957
7958 2019-03-24  Tom Tromey  <tom@tromey.com>
7959
7960         * ada-lang.c (standard_lookup): Simplify initialization.
7961         (ada_lookup_symbol_nonlocal): Simplify return.
7962         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7963         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7964         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7965         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7966         initialization.
7967         * solib.c (solib_global_lookup): Simplify.
7968         * symtab.c (null_block_symbol): Remove.
7969         (symbol_cache_lookup): Simplify returns.
7970         (lookup_language_this): Simplify returns.
7971         (lookup_symbol_aux): Simplify return.
7972         (lookup_local_symbol): Simplify returns.
7973         (lookup_global_symbol_from_objfile): Simplify return.
7974         (lookup_symbol_in_objfile_symtabs)
7975         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7976         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7977         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7978         * cp-namespace.c (cp_lookup_bare_symbol)
7979         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7980         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7981         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7982         (cp_lookup_symbol_via_imports): Simplify initialization.
7983         (find_symbol_in_baseclass): Likewise.
7984         * symtab.h (null_block_symbol): Remove.
7985         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7986         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7987         (d_lookup_symbol_module): Likewise.
7988         (find_symbol_in_baseclass): Simplify initialization.
7989
7990 2019-03-24  Tom Tromey  <tom@tromey.com>
7991
7992         * expression.h: Don't include symtab.h.
7993         (struct block): Forward declare.
7994
7995 2019-03-24  Tom Tromey  <tom@tromey.com>
7996
7997         * c-exp.y (typebase): Remove casts.
7998         * gdbtypes.c (lookup_unsigned_typename, )
7999         (lookup_signed_typename): Remove cast.
8000         * eval.c (parse_to_comma_and_eval): Remove cast.
8001         * parse.c (write_dollar_variable): Remove cast.
8002         * block.h (struct block) <superblock>: Now const.
8003         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8004         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8005         (map_block): Make "block" const.
8006         * symfile.h (struct quick_symbol_functions)
8007         <map_matching_symbols>: Constify block argument to "callback".
8008         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8009         const.
8010         (find_pc_sect_compunit_symtab): Make "b" const.
8011         (find_symbol_at_address): Likewise.
8012         (search_symbols): Likewise.
8013         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8014         (dw2_debug_names_lookup_symbol): Likewise.
8015         (dw2_map_matching_symbols): Update.
8016         * p-valprint.c (pascal_val_print): Remove "block".
8017         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8018         (aux_add_nonlocal_symbols): Make "block" const.
8019         (resolve_subexp): Remove cast.
8020         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8021         const.
8022         (iterate_over_file_blocks): Likewise.
8023         * f-exp.y (%union) <bval>: Remove.
8024         * coffread.c (patch_opaque_types): Make "b" const.
8025         * spu-tdep.c (spu_catch_start): Make "block" const.
8026         * c-valprint.c (print_unpacked_pointer): Remove "block".
8027         * symmisc.c (dump_symtab_1): Make "b" const.
8028         (block_depth): Make "block" const.
8029         * d-exp.y (%union) <bval>: Remove.
8030         * cp-support.h (cp_lookup_rtti_type): Update.
8031         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8032         * psymtab.c (psym_lookup_symbol): Make "block" const.
8033         (maintenance_check_psymtabs): Make "b" const.
8034         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8035         (enumerate_locals, enumerate_args): Update.
8036         * python/py-symtab.c (stpy_global_block): Make "block" const.
8037         (stpy_static_block): Likewise.
8038         * inline-frame.c (block_starting_point_at): Make "new_block"
8039         const.
8040         * block.c (find_block_in_blockvector): Make return type const.
8041         (blockvector_for_pc_sect): Make "b" const.
8042         (find_block_in_blockvector): Make "b" const.
8043
8044 2019-03-23  Tom Tromey  <tom@tromey.com>
8045
8046         * varobj.c (varobj_create): Update.
8047         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8048         * printcmd.c (display_command, do_one_display): Don't reset
8049         innermost_block.
8050         * parser-defs.h (enum innermost_block_tracker_type): Move to
8051         expression.h.
8052         (innermost_block): Update comment.
8053         * parse.c (parse_exp_1): Add tracker_types parameter.
8054         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8055         tracker_types parameter.  Reset innermost_block.
8056         (parse_exp_in_context): Remove.
8057         (parse_expression_for_completion): Update.
8058         * objfiles.c (~objfile): Don't reset expression_context_block or
8059         innermost_block.
8060         * expression.h (enum innermost_block_tracker_type): Move from
8061         parser-defs.h.
8062         (parse_exp_1): Add tracker_types parameter.
8063         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8064         reset innermost_block.
8065
8066 2019-03-23  Tom Tromey  <tom@tromey.com>
8067
8068         * objfiles.h: Include bcache.h.
8069
8070 2019-03-23  Tom Tromey  <tom@tromey.com>
8071
8072         * linespec.c (get_current_search_block): Use
8073         scoped_restore_current_language.
8074         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8075
8076 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8077             Jiong Wang  <jiong.wang@arm.com>
8078
8079         * aarch64-linux-tdep.c
8080         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8081         section.
8082         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8083
8084 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8085             Jiong Wang  <jiong.wang@arm.com>
8086
8087         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8088         instructions.
8089         (aarch64_analyze_prologue_test): Add PACIASP test.
8090         (aarch64_prologue_prev_register): Unmask PC value.
8091
8092 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8093             Jiong Wang  <jiong.wang@arm.com>
8094
8095         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8096         (aarch64_dwarf2_prev_register): Unmask PC value.
8097         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8098         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8099         DW_CFA_AARCH64_negate_ra_state.
8100         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8101
8102 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8103             Jiong Wang  <jiong.wang@arm.com>
8104
8105         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8106         registers.
8107         (aarch64_pseudo_register_name): Likewise.
8108         (aarch64_pseudo_register_type): Likewise.
8109         (aarch64_pseudo_register_reggroup_p): Likewise.
8110         (aarch64_gdbarch_init): Add pauth registers.
8111         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8112         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8113         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8114         (struct gdbarch_tdep): Add regnum for ra_state.
8115
8116 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8117             Jiong Wang  <jiong.wang@arm.com>
8118
8119         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8120
8121 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8122             Jiong Wang  <jiong.wang@arm.com>
8123
8124         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8125         function.
8126         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8127         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8128         (aarch64_gdbarch_init): Add puth registers.
8129         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8130         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8131         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8132
8133 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8134             Jiong Wang  <jiong.wang@arm.com>
8135
8136         * aarch64-linux-nat.c
8137         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8138         * aarch64-linux-tdep.c
8139         (aarch64_linux_core_read_description): Likewise.
8140         (aarch64_linux_get_hwcap): New function.
8141         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8142         (aarch64_linux_get_hwcap): New declaration.
8143
8144 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8145             Jiong Wang  <jiong.wang@arm.com>
8146
8147         * aarch64-linux-nat.c
8148         (aarch64_linux_nat_target::read_description): Add pauth param.
8149         * aarch64-linux-tdep.c
8150         (aarch64_linux_core_read_description): Likewise.
8151         * aarch64-tdep.c (struct target_desc): Add in pauth.
8152         (aarch64_read_description): Add pauth param.
8153         (aarch64_gdbarch_init): Likewise.
8154         * aarch64-tdep.h (aarch64_read_description): Likewise.
8155         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8156         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8157         * features/Makefile: Add new files.
8158         * features/aarch64-pauth.c: New file.
8159         * features/aarch64-pauth.xml: New file.
8160
8161 2019-03-20  Tom Tromey  <tromey@adacore.com>
8162
8163         * infrun.c (handle_inferior_event): Rename from
8164         handle_inferior_event_1.  Create a scoped_value_mark.
8165         (handle_inferior_event): Remove.
8166
8167 2019-03-19  Tom Tromey  <tromey@adacore.com>
8168
8169         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8170         * infrun.h (print_stop_event): Add "displays" parameter.
8171         * infrun.c (print_stop_event): Add "displays" parameter.
8172
8173 2019-03-19  Pedro Alves  <palves@redhat.com>
8174
8175         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8176         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8177         to -1.  Fix TABs vs spaces.
8178         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8179         * tui/tui-out.h (tui_ui_out) Add intro comments.
8180         <m_line, m_start_of_line>: In-class initialize, and add describing
8181         comment.
8182
8183 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8184
8185         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8186         variable names.
8187         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8188
8189 2019-03-18  Pedro Alves  <palves@redhat.com>
8190             Eli Zaretskii <eliz@gnu.org>
8191
8192         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8193         m_line and m_start_of_line.
8194
8195 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8196
8197         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8198         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8199         it returns a newline.  This fixes a regression in TU mode, whereby
8200         the next line is output on the same screen line as the user input.
8201
8202 2019-03-18  Tom Tromey  <tromey@adacore.com>
8203
8204         * minsyms.c (minimal_symbol_reader::install): Remove call to
8205         obstack_blank.
8206
8207 2019-03-18  Pedro Alves  <palves@redhat.com>
8208
8209         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8210         New globals.
8211         (apply_style): New, factored out from ...
8212         (apply_ansi_escape): ... this.  Handle reverse video mode.
8213         (tui_set_reverse_mode): New function.
8214         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8215         * tui/tui-winsource.c (tui_show_source_line): Use
8216         tui_set_reverse_mode instead of setting A_STANDOUT.
8217         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8218         New setter methods.
8219
8220 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8221
8222         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8223         Handle tabs.
8224
8225 2019-03-18  Tom Tromey  <tromey@adacore.com>
8226
8227         * ada-lang.c (empty_array): Add "high" parameter.
8228         (ada_evaluate_subexp): Update.
8229
8230 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8231
8232         * unittests/string_view-selftests.c: Define
8233         _initialize_string_view_selftests unconditionally.
8234
8235 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8236
8237         PR gdb/24350
8238         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8239
8240 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8241
8242         PR gdb/24351
8243         * windows-nat.c (display_selector): Fix format specifiers.
8244
8245 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8246
8247         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8248         tui_refill_source_window instead of tui_refresh_win, to update the
8249         current execution line.  This fixes redisplay of the current line
8250         when stepping through the code with "next" or "step".
8251
8252 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8253
8254         * source-cache.c (source_cache::get_source_lines): Call
8255         find_source_lines to initialize s->nlines.  This fixes vertical
8256         scrolling of TUI source window when the DOWN arrow is pressed.
8257
8258 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8259
8260         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8261         linux-thread-db.c (_initialize_thread_db): Likewise.
8262
8263 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8264
8265         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8266         wclrtoeol in tui_show_source_line".  This reverts changes made in
8267         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8268
8269 2019-03-15  Tom Tromey  <tom@tromey.com>
8270
8271         * symtab.h (struct minimal_symbol): Derive from
8272         general_symbol_info.
8273         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8274         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8275         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8276         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8277         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8278         (MSYMBOL_SEARCH_NAME): Update.
8279         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8280         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8281         * minsyms.c (minimal_symbol_reader::record_full): Update.
8282
8283 2019-03-15  Tom Tromey  <tom@tromey.com>
8284
8285         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8286
8287 2019-03-15  Tom Tromey  <tom@tromey.com>
8288
8289         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8290         unique_xmalloc_ptr.
8291         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8292         Update.
8293         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8294         (build_minimal_symbol_hash_tables)
8295         (minimal_symbol_reader::install): Update.
8296
8297 2019-03-15  Tom Tromey  <tom@tromey.com>
8298
8299         * symtab.c (create_demangled_names_hash): Update.
8300         (symbol_set_names): Update.
8301         * objfiles.h (struct objfile_per_bfd_storage)
8302         <demangled_names_hash>: Now an htab_up.
8303         * objfiles.c (objfile_per_bfd_storage): Simplify.
8304
8305 2019-03-15  Tom Tromey  <tom@tromey.com>
8306
8307         * objfiles.h (struct objfile_per_bfd_storage): Declare
8308         destructor.
8309         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8310         New.
8311         (get_objfile_bfd_data): Use new.  Don't initialize
8312         language_of_main.
8313         (free_objfile_per_bfd_storage): Remove.
8314         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8315
8316 2019-03-15  Tom Tromey  <tom@tromey.com>
8317
8318         * symfile.c (reread_symbols): Update.
8319         * objfiles.c (objfile::objfile): Update.
8320         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8321         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8322         comment.
8323         (minimal_symbol_reader::install): Update.
8324         (terminate_minimal_symbol_table): Remove.
8325         * jit.c (jit_object_close_impl): Update.
8326
8327 2019-03-15  Tom Tromey  <tom@tromey.com>
8328
8329         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8330         initializations.
8331
8332 2019-03-15  Tom Tromey  <tom@tromey.com>
8333
8334         * objfiles.h (struct objfile_per_bfd_storage)
8335         <demangled_hash_languages>: Now a bitset.
8336         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8337         (lookup_minimal_symbol): Update.
8338
8339 2019-03-15  Tom Tromey  <tom@tromey.com>
8340
8341         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8342         Don't return the symbol.
8343         * coffread.c (record_minimal_symbol): Use record_full.
8344
8345 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8346
8347         The MS-Windows port of ncurses fails to switch to a color pair if
8348         one or both of the colors are the implicit default colors.  This
8349         change records the default colors when TUI is initialized, and
8350         then specifies them explicitly when a color pair uses the default
8351         colors.  This allows color styling in TUI mode on MS-Windows.
8352
8353         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8354         ncurses_norm_attr.
8355         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8356         colors in ncurses_norm_attr.
8357         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8358         "none", replace it with the default color recorded in
8359         ncurses_norm_attr.
8360
8361 2019-03-14  Tom Tromey  <tromey@adacore.com>
8362
8363         * source-cache.h (class source_cache) <get_source_lines>: Return
8364         std::string.
8365         * source-cache.c (source_cache::extract_lines): Handle case where
8366         first_pos==npos.  Return std::string.
8367         (source_cache::get_source_lines): Update.
8368
8369 2019-03-14  Tom Tromey  <tromey@adacore.com>
8370
8371         * NEWS: Add item for "style sources" commands.
8372         * source-cache.c (source_cache::get_source_lines): Check
8373         source_styling.
8374         * cli/cli-style.c (source_styling): New global.
8375         (_initialize_cli_style): Add "style sources" commands.
8376         (show_style_sources): New function.
8377         * cli/cli-style.h (source_styling): Declare.
8378
8379 2019-03-14  Pedro Alves  <palves@redhat.com>
8380             Tom Tromey  <tromey@adacore.com>
8381
8382         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8383         * tui/tui-winsource.c (tui_refill_source_window): New function,
8384         from...
8385         (tui_horizontal_source_scroll): ... here.  Move some logic.
8386         * cli/cli-style.c (set_style_enabled): Notify new observable.
8387         * tui/tui-hooks.c (tui_redisplay_source): New function.
8388         (tui_attach_detach_observers): Attach or detach
8389         tui_redisplay_source.
8390         * observable.h (source_styling_changed): New observable.
8391         * observable.c: Define source_styling_changed observable.
8392
8393 2019-03-13  Tom Tromey  <tromey@adacore.com>
8394
8395         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8396         (i386_gnu_nat_target::store_registers): Update.
8397         * target-debug.h (target_debug_print_std_string): New macro.
8398         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8399         * windows-tdep.c (display_one_tib): Update.
8400         * tui/tui-stack.c (tui_make_status_line): Update.
8401         * top.c (print_inferior_quit_action): Update.
8402         * thread.c (thr_try_catch_cmd): Update.
8403         (add_thread_with_info): Update.
8404         (thread_target_id_str): Update.
8405         (thr_try_catch_cmd): Update.
8406         (thread_command): Update.
8407         (thread_find_command): Update.
8408         * record-btrace.c (record_btrace_target::info_record)
8409         (record_btrace_resume_thread, record_btrace_target::resume)
8410         (record_btrace_cancel_resume, record_btrace_step_thread)
8411         (record_btrace_target::wait, record_btrace_target::wait)
8412         (record_btrace_target::wait, record_btrace_target::stop): Update.
8413         * progspace.c (print_program_space): Update.
8414         * process-stratum-target.c
8415         (process_stratum_target::thread_address_space): Update.
8416         * linux-fork.c (linux_fork_mourn_inferior)
8417         (detach_checkpoint_command, info_checkpoints_command)
8418         (linux_fork_context): Update.
8419         (linux_fork_detach): Update.
8420         (class scoped_switch_fork_info): Update.
8421         (delete_checkpoint_command): Update.
8422         * infrun.c (follow_fork_inferior): Update.
8423         (follow_fork_inferior): Update.
8424         (proceed_after_vfork_done): Update.
8425         (handle_vfork_child_exec_or_exit): Update.
8426         (follow_exec): Update.
8427         (displaced_step_prepare_throw): Update.
8428         (displaced_step_restore): Update.
8429         (start_step_over): Update.
8430         (resume_1): Update.
8431         (clear_proceed_status_thread): Update.
8432         (proceed): Update.
8433         (print_target_wait_results): Update.
8434         (do_target_wait): Update.
8435         (context_switch): Update.
8436         (stop_all_threads): Update.
8437         (restart_threads): Update.
8438         (finish_step_over): Update.
8439         (handle_signal_stop): Update.
8440         (switch_back_to_stepped_thread): Update.
8441         (keep_going_pass_signal): Update.
8442         (print_exited_reason): Update.
8443         (normal_stop): Update.
8444         * inferior.c (inferior_pid_to_str): Change return type.
8445         (print_selected_inferior): Update.
8446         (add_inferior): Update.
8447         (detach_inferior): Update.
8448         * dummy-frame.c (fprint_dummy_frames): Update.
8449         * dcache.c (dcache_info_1): Update.
8450         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8451         (btrace_fetch, btrace_clear): Update.
8452         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8453         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8454         type.
8455         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8456         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8457         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8458         * gdbarch.c, gdbarch.h: Rebuild.
8459         * gdbarch.sh (core_pid_to_str): Change return type.
8460         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8461         return type.
8462         (windows_nat_target::pid_to_str): Change return type.
8463         (windows_delete_thread): Update.
8464         (windows_nat_target::attach): Update.
8465         (windows_nat_target::files_info): Update.
8466         * target-delegates.c: Rebuild.
8467         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8468         return type.
8469         (sol_thread_target::pid_to_str): Change return type.
8470         * remote.c (class remote_target) <pid_to_str>: Change return
8471         type.
8472         (remote_target::pid_to_str): Change return type.
8473         (extended_remote_target::attach, remote_target::remote_stop_ns)
8474         (remote_target::remote_notif_remove_queued_reply)
8475         (remote_target::push_stop_reply, remote_target::disable_btrace):
8476         Update.
8477         (extended_remote_target::attach): Update.
8478         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8479         type.
8480         (gdbsim_target::pid_to_str): Change return type.
8481         * ravenscar-thread.c (struct ravenscar_thread_target)
8482         <pid_to_str>: Change return type.
8483         (ravenscar_thread_target::pid_to_str): Change return type.
8484         * procfs.c (class procfs_target) <pid_to_str>: Change return
8485         type.
8486         (procfs_target::pid_to_str): Change return type.
8487         (procfs_target::attach): Update.
8488         (procfs_target::detach): Update.
8489         (procfs_target::fetch_registers): Update.
8490         (procfs_target::store_registers): Update.
8491         (procfs_target::wait): Update.
8492         (procfs_target::files_info): Update.
8493         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8494         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8495         return type.
8496         (nto_procfs_target::pid_to_str): Change return type.
8497         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8498         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8499         return type.
8500         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8501         (exit_lwp): Update.
8502         (attach_proc_task_lwp_callback, get_detach_signal)
8503         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8504         (linux_nat_target::resume, wait_lwp, stop_callback)
8505         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8506         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8507         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8508         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8509         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8510         type.
8511         (inf_ptrace_target::attach): Update.
8512         (inf_ptrace_target::files_info): Update.
8513         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8514         type.
8515         (go32_nat_target::pid_to_str): Change return type.
8516         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8517         (gnu_nat_target::wait): Update.
8518         (gnu_nat_target::wait): Update.
8519         (gnu_nat_target::resume): Update.
8520         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8521         (fbsd_nat_target::wait): Update.
8522         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8523         type.
8524         (darwin_nat_target::attach): Update.
8525         * corelow.c (class core_target) <pid_to_str>: Change return type.
8526         (core_target::pid_to_str): Change return type.
8527         * target.c (normal_pid_to_str): Change return type.
8528         (default_pid_to_str): Likewise.
8529         (target_pid_to_str): Change return type.
8530         (target_translate_tls_address): Update.
8531         (target_announce_detach): Update.
8532         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8533         return type.
8534         (bsd_uthread_target::pid_to_str): Change return type.
8535         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8536         type.
8537         (bsd_kvm_target::pid_to_str): Change return type.
8538         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8539         return type.
8540         (aix_thread_target::pid_to_str): Change return type.
8541         * target.h (struct target_ops) <pid_to_str>: Change return type.
8542         (target_pid_to_str, normal_pid_to_str): Likewise.
8543         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8544         type.
8545         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8546         type.
8547         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8548         return type.
8549         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8550         type.
8551         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8552         type.
8553         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8554         return type.
8555
8556 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8557
8558         * NEWS: Mention that the new default MI version is 3.  Mention
8559         changes to the output of commands and events that deal with
8560         multi-location breakpoints.
8561         * breakpoint.c: Include "mi/mi-out.h".
8562         (print_one_breakpoint): Change output syntax if using MI version
8563         >= 3.
8564         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8565         New.
8566         (mi_multi_location_breakpoint_output_fixed): New.
8567         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8568         (mi_cmd_fix_multi_location_breakpoint_output): New.
8569         (mi_multi_location_breakpoint_output_fixed): New.
8570         * mi/mi-cmds.c (mi_cmds): Register command
8571         -fix-multi-location-breakpoint-output.
8572         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8573         interpreter "mi".
8574
8575 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8576
8577         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8578         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8579         instantiate mi_ui_out based on interpreter name.
8580         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8581         * mi/mi-main.c (mi_load_progress): Likewise.
8582
8583 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8584
8585         * NEWS: Combine separate "New targets" sections for 8.3.
8586
8587 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8588
8589         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8590         (ppcfbsd_init_abi): Install gdbarch
8591         "fetch_tls_load_module_address" and "get_thread_local_address"
8592         methods.
8593
8594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8595
8596         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8597         (riscv_fbsd_init_abi): Install gdbarch
8598         "fetch_tls_load_module_address" and "get_thread_local_address"
8599         methods.
8600
8601 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8602
8603         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8604         (i386fbsd_init_abi): Install gdbarch
8605         "fetch_tls_load_module_address" and "get_thread_local_address"
8606         methods.
8607
8608 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8609
8610         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8611         (amd64fbsd_init_abi): Install gdbarch
8612         "fetch_tls_load_module_address" and "get_thread_local_address"
8613         methods.
8614
8615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8616
8617         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8618         (struct fbsd_pspace_data): New type.
8619         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8620         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8621         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8622         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8623         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8624
8625 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8626
8627         * gdbtypes.c (lookup_struct_elt): New function.
8628         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8629         * gdbtypes.h (struct struct_elt): New type.
8630         (lookup_struct_elt): New prototype.
8631
8632 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8633
8634         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8635         remove disabled code block.
8636
8637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8638
8639         * gdbarch.sh (get_thread_local_address): New method.
8640         * gdbarch.h, gdbarch.c: Regenerate.
8641         * target.c (target_translate_tls_address): Use
8642         gdbarch_get_thread_local_address if present instead of
8643         target::get_thread_local_address.
8644
8645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8646
8647         * target.h (target::get_thread_local_address): Update comment.
8648
8649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8650
8651         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8652         objfile->separate_debug_objfile_backlink if not NULL.
8653
8654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8655
8656         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8657         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8658         (amd64bsd_store_inferior_registers): Likewise.
8659         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8660         Enable segment base registers.
8661         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8662         PT_GETFSBASE and PT_GETGSBASE.
8663         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8664         PT_SETGSBASE.
8665         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8666         segment base registers.
8667         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8668
8669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8670
8671         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8672         Update calls to i386_target_description to add 'segments'
8673         parameter.
8674         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8675         add segment base registers.
8676         * arch/i386.c (i386_create_target_description): Add 'segments'
8677         parameter to enable segment base registers.
8678         * arch/i386.h (i386_create_target_description): Likewise.
8679         * features/i386/32bit-segments.xml: New file.
8680         * features/i386/32bit-segments.c: Generate.
8681         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8682         call to i386_target_description to add 'segments' parameter.
8683         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8684         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8685         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8686         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8687         if feature is present.
8688         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8689         Add 'segments' parameter to call to i386_target_description.
8690         (i386_target_description): Add 'segments' parameter to enable
8691         segment base registers.
8692         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8693         to call to i386_target_description.
8694         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8695         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8696         Define I386_NUM_REGS.
8697         (i386_target_description): Add 'segments' parameter to enable
8698         segment base registers.
8699
8700 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8701
8702         PR/24325
8703         * source-cache.c: #undef open and close, to avoid unresolved
8704         externals during linking.
8705
8706 2019-03-12  Tom Tromey  <tromey@adacore.com>
8707
8708         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8709         const.  Add initializers.
8710         (_initialize_remote): Don't initialize ptid globals.
8711
8712 2019-03-12  Pedro Alves  <palves@redhat.com>
8713
8714         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8715
8716 2019-03-12  Pedro Alves  <palves@redhat.com>
8717
8718         * cp-name-parser.y (main): Remove unused 'len' variable.
8719
8720 2019-03-12  Tom Tromey  <tromey@adacore.com>
8721
8722         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8723         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8724
8725 2019-03-12  Tom Tromey  <tromey@adacore.com>
8726
8727         * linux-nat.c (iterate_over_lwps): Update.
8728         (stop_callback): Remove parameter.
8729         (stop_wait_callback, detach_callback, resume_set_callback)
8730         (select_singlestep_lwp_callback, set_ignore_sigint)
8731         (status_callback, resumed_callback, resume_clear_callback)
8732         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8733         data parameter.
8734         (linux_nat_target::detach, linux_nat_target::resume)
8735         (linux_stop_and_wait_all_lwps, select_event_lwp)
8736         (linux_nat_filter_event, linux_nat_wait_1)
8737         (linux_nat_target::kill, linux_nat_target::stop)
8738         (linux_nat_target::stop): Update.
8739         (linux_nat_resume_callback): Change type.
8740         (resume_stopped_resumed_lwps, count_events_callback)
8741         (select_event_lwp_callback): Likewise.
8742         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8743         * arm-linux-nat.c (struct update_registers_data): Remove.
8744         (update_registers_callback): Change type.
8745         (arm_linux_insert_hw_breakpoint1): Update.
8746         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8747         parameter.
8748         (x86_linux_dr_set_addr): Update.
8749         (x86_linux_dr_set_control): Update.
8750         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8751         (iterate_over_lwps): Use gdb::function_view.
8752         * nat/aarch64-linux-hw-point.c (struct
8753         aarch64_dr_update_callback_param): Remove.
8754         (debug_reg_change_callback): Change type.
8755         (aarch64_notify_debug_reg_change): Update.
8756         * s390-linux-nat.c (s390_refresh_per_info): Update.
8757
8758 2019-03-11  Tom Tromey  <tromey@adacore.com>
8759
8760         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8761         redundant assignment to "this_cu".
8762
8763 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8764
8765         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8766
8767 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8768
8769         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8770         from...
8771         (rank_one_type): ... this.
8772
8773 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8774
8775         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8776         from...
8777         (rank_one_type): ... this.
8778
8779 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8780
8781         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8782         from...
8783         (rank_one_type): ... this.
8784
8785 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8786
8787         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8788         from...
8789         (rank_one_type): ... this.
8790
8791 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8792
8793         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8794         from...
8795         (rank_one_type): ... this.
8796
8797 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8798
8799         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8800         from...
8801         (rank_one_type): ... this.
8802
8803 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8804
8805         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8806         from...
8807         (rank_one_type): ... this.
8808
8809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8810
8811         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8812         from...
8813         (rank_one_type): ... this.
8814
8815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8816
8817         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8818         from...
8819         (rank_one_type): ... this.
8820
8821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8822
8823         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8824         from...
8825         (rank_one_type): ... this.
8826
8827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8828
8829         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8830         from...
8831         (rank_one_type): ... this.
8832
8833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8834
8835         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8836         from...
8837         (rank_one_type): ... this.
8838
8839 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8840
8841         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8842         inferior-events' shows the example events.
8843
8844 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8845
8846         Support styling on native MS-Windows console
8847
8848         PR/24315
8849         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8850         on MS-Windows if $TERM is not defined.
8851
8852         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8853
8854         * posix-hdep.c (gdb_console_fputs):
8855         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8856         functions.
8857         * ui-file.h (gdb_console_fputs): Add prototype.
8858
8859         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8860         back to fputs only if the former returns zero.
8861
8862 2019-03-07  Tom Tromey  <tom@tromey.com>
8863
8864         * symmisc.c (print_symbol_bcache_statistics): Update.
8865         (print_objfile_statistics): Update.
8866         * symfile.c (allocate_symtab): Update.
8867         * stabsread.c: Don't include bcache.h.
8868         * psymtab.h (struct psymbol_bcache): Don't declare.
8869         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8870         (psymbol_bcache_init, psymbol_bcache_free)
8871         (psymbol_bcache_get_bcache): Don't declare.
8872         * psymtab.c (struct psymbol_bcache): Remove.
8873         (psymtab_storage::psymtab_storage): Update.
8874         (psymtab_storage::~psymtab_storage): Update.
8875         (psymbol_bcache_init, psymbol_bcache_free)
8876         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8877         (add_psymbol_to_bcache): Update.
8878         (allocate_psymtab): Update.
8879         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8880         macro_cache>: No longer pointers.
8881         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8882         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8883         * macrotab.c (macro_bcache): Update.
8884         * macroexp.c: Don't include bcache.h.
8885         * gdbtypes.c (check_types_worklist): Update.
8886         (types_deeply_equal): Remove TRY/CATCH.  Update.
8887         * elfread.c (elf_symtab_read): Update.
8888         * dwarf2read.c: Don't include bcache.h.
8889         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8890         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8891         (print_bcache_statistics, bcache_memory_used): Don't declare.
8892         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8893         methods.  Rename all data members.
8894         * bcache.c (struct bcache): Move to bcache.h.
8895         (bcache::expand_hash_table): Rename from expand_hash_table.
8896         (bcache): Remove.
8897         (bcache::insert): Rename from bcache_full.
8898         (bcache::compare): Rename from bcache_compare.
8899         (bcache_xmalloc): Remove.
8900         (bcache::~bcache): Rename from bcache_xfree.
8901         (bcache::print_statistics): Rename from print_bcache_statistics.
8902         (bcache::memory_used): Rename from bcache_memory_used.
8903
8904 2019-03-07  Pedro Alves  <palves@redhat.com>
8905
8906         * infrun.c (normal_stop): Also check for
8907         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8908
8909 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8910
8911         * f-lang.c (value_from_host_double): Moved to...
8912         * value.c (value_from_host_double): ...here.
8913         * value.h (value_from_host_double): Declare.
8914         * guile/scm-math.c (vlscm_convert_typed_number): Use
8915         value_from_host_double.
8916         (vlscm_convert_number): Likewise.
8917         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8918         * python/py-value.c (convert_value_from_python): Likewise.
8919
8920 2019-03-06  Tom Tromey  <tom@tromey.com>
8921
8922         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8923
8924 2019-03-06  Tom Tromey  <tom@tromey.com>
8925
8926         * utils.h (free_current_contents): Don't declare.
8927         * utils.c (free_current_contents): Remove.
8928
8929 2019-03-06  Tom Tromey  <tom@tromey.com>
8930
8931         * top.c (quit_force): Update.
8932         * main.c (captured_command_loop): Update.
8933         * common/new-op.c (operator new): Update.
8934         * common/common-exceptions.c (struct catcher)
8935         <save_cleanup_chain>: Remove member.
8936         (exceptions_state_mc_init): Update.
8937         (exception_try_scope_entry): Return nullptr.
8938         (exception_try_scope_exit, exception_rethrow)
8939         (throw_exception_sjlj, throw_exception_cxx): Update.
8940         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8941         (all_cleanups, do_cleanups, discard_cleanups)
8942         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8943         (restore_cleanups, restore_final_cleanups): Don't declare.
8944         (do_final_cleanups): Remove parameter.
8945         * common/cleanups.c (cleanup_chain, make_cleanup)
8946         (make_cleanup_dtor, all_cleanups, do_cleanups)
8947         (discard_my_cleanups, discard_cleanups)
8948         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8949         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8950         (null_cleanup): Remove.
8951         (do_final_cleanups): Remove parameter.
8952
8953 2019-03-06  Tom Tromey  <tom@tromey.com>
8954
8955         * remote.c (remote_target::remote_parse_stop_reply): Use
8956         unique_xmalloc_ptr.
8957
8958 2019-03-06  Tom Tromey  <tom@tromey.com>
8959
8960         * stabsread.c (struct stabs_field_info): Rename from field_info.
8961         <list, fnlist>: Add initializers.
8962         <obstack>: New member.
8963         (read_member_functions, read_struct_fields, read_baseclasses):
8964         Allocate on obstack.  Don't use cleanups.
8965         (read_one_struct_field, read_member_functions, read_struct_fields)
8966         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8967         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8968         (read_struct_type): Update.
8969
8970 2019-03-06  Tom Tromey  <tom@tromey.com>
8971
8972         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8973         * common/filestuff.h (make_cleanup_close): Don't declare.
8974         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8975         Remove.
8976
8977 2019-03-06  Tom Tromey  <tom@tromey.com>
8978
8979         * solib-aix.c: Use make_scope_exit.
8980
8981 2019-03-06  Tom Tromey  <tom@tromey.com>
8982
8983         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8984         Use make_scope_exit.
8985
8986 2019-03-06  Tom Tromey  <tom@tromey.com>
8987
8988         * solib-svr4.c (disable_probes_interface): Remove parameter.
8989         (svr4_handle_solib_event): Use make_scope_exit.
8990
8991 2019-03-06  Tom Tromey  <tom@tromey.com>
8992
8993         * remote.c (struct stop_reply_deleter): Remove.
8994         (stop_reply_up): Update.
8995         (struct stop_reply): Derive from notif_event.  Don't typedef.
8996         <regcache>: Now a std::vector.
8997         (stop_reply_xfree): Remove.
8998         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8999         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9000         (remote_target::discard_pending_stop_replies): Use delete.
9001         (remote_target::remote_parse_stop_reply): Update.
9002         (remote_target::process_stop_reply): Update.
9003         * remote-notif.h (struct notif_event): Add virtual destructor.
9004         Remove "dtr" member.
9005         (struct notif_client) <alloc_event>: Return a unique_ptr.
9006         (notif_event_xfree): Don't declare.
9007         (notif_event_up): New typedef.
9008         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9009         (notif_event_xfree, do_notif_event_xfree): Remove.
9010         (remote_notif_state_xfree): Update.
9011
9012 2019-03-06  Tom Tromey  <tom@tromey.com>
9013
9014         * infrun.c (displaced_step_clear_cleanup): Now a
9015         forward_scope_exit type.
9016         (displaced_step_prepare_throw): Update.
9017         (displaced_step_fixup): Update.
9018
9019 2019-03-06  Tom Tromey  <tom@tromey.com>
9020
9021         * inferior.h (class inferior): Update comment.
9022         * gdbthread.h (class thread_info): Update comment.
9023
9024 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9025             Tom Tromey  <tom@tromey.com>
9026
9027         * stabsread.h (struct stab_section_list): Remove.
9028         (coffstab_build_psymtabs): Update.
9029         * dbxread.c (symbuf_sections): Now a std::vector.
9030         (sect_idx): New global.
9031         (fill_symbuf): Update.
9032         (coffstab_build_psymtabs): Change type of stabsects parameter.
9033         Update.
9034         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9035         std::vector.
9036         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9037         (coff_locate_sections): Update.
9038         (coff_symfile_read): Remove cleanups.  Update.
9039         (init_stringtab): Add storage parameter.
9040         (free_stringtab, free_stringtab_cleanup): Remove.
9041         (init_lineno): Add storage parameter.
9042         (free_linetab, free_linetab_cleanup): Remove.
9043
9044 2019-03-06  Pedro Alves  <palves@redhat.com>
9045
9046         * linux-fork.c (fork_info::clobber_regs): Delete.
9047         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9048         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9049         comment.  Adjust.
9050         (scoped_switch_fork_info::scoped_switch_fork_info)
9051         (checkpoint_command, linux_fork_context): Adjust
9052         fork_save_infrun_state calls.
9053
9054 2019-03-06  Pedro Alves  <palves@redhat.com>
9055
9056         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9057         (inf_has_multiple_threads): Return 'bool' and rewrite using
9058         inferior_info::threads().
9059
9060 2019-03-06  Pedro Alves  <palves@redhat.com>
9061
9062         * linux-fork.c: Include <list>.
9063         (fork_list): Now a std::list instance.
9064         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9065         (forks_exist_p, find_last_fork): Adjust.
9066         (new_fork): Delete.
9067         (one_fork_p): New.
9068         (add_fork): Adjust.
9069         (free_fork): Delete, folded into fork_info::~fork_info().
9070         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9071         Adjust.
9072         (init_fork_list): Delete.
9073         (linux_fork_killall, linux_fork_mourn_inferior)
9074         (linux_fork_detach, info_checkpoints_command): Adjust.
9075         (_initialize_linux_fork): No longer call init_fork_list.
9076
9077 2019-03-06  Pedro Alves  <palves@redhat.com>
9078
9079         * linux-fork.c (new_fork): New, split out of ...
9080         (add_fork): ... this.  Return void.  Move "first fork" special
9081         case from here, to ...
9082         (checkpoint_command): ... here.
9083         * linux-linux.h (add_fork): Return void.
9084
9085 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9086
9087         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9088
9089 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9090             Chris January  <chris.january@arm.com>
9091             David Lecomber  <david.lecomber@arm.com>
9092
9093         * f-exp.y: New token, UNOP_INTRINSIC.
9094         (exp): New pattern using UNOP_INTRINSIC token.
9095         (f77_keywords): Add 'abs' keyword.
9096         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9097         (value_from_host_double): New function.
9098         (evaluate_subexp_f): Support UNOP_ABS.
9099
9100 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9101
9102         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9103         types.
9104
9105 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9106
9107         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9108         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9109         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9110
9111 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9112
9113         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9114
9115 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9116             Chris January  <chris.january@arm.com>
9117
9118         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9119         * f-exp.y: Define 'KIND' token.
9120         (exp): New pattern for KIND expressions.
9121         (ptype): Handle types with a kind extension.
9122         (direct_abs_decl): Extend to spot kind extensions.
9123         (f77_keywords): Add 'kind' to the list.
9124         (push_kind_type): New function.
9125         (convert_to_kind_type): New function.
9126         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9127         * parse.c (operator_length_standard): Likewise.
9128         * parser-defs.h (enum type_pieces): Add tp_kind.
9129         * std-operator.def: Add UNOP_KIND.
9130
9131 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9132
9133         * f-exp.y (f_parse): Set yydebug.
9134
9135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9136
9137         * f-lang.c (evaluate_subexp_f): New function.
9138         (exp_descriptor_f): New global.
9139         (f_language_defn): Use exp_descriptor_f instead of
9140         exp_descriptor_standard.
9141
9142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9143
9144         * f-exp.y (struct token): Add comments.
9145         (dot_ops): Remove uppercase versions and the end marker.
9146         (f77_keywords): Likewise.
9147         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9148         entries in the dot_ops array are case insensitive, and use
9149         strncasecmp to compare strings.  Also some whitespace cleanup in
9150         this area.  Similar for the f77_keywords array, except entries in
9151         this list might be case sensitive.
9152
9153 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9154
9155         * f-exp.y (struct f77_boolean_val): Add comments.
9156         (boolean_values): Remove uppercase versions, and end marker.
9157         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9158         and use strncasecmp to achieve case insensitivity.  Additionally,
9159         perform whitespace cleanup around this code.
9160
9161 2019-03-06  Tom Tromey  <tromey@adacore.com>
9162
9163         * remote-sim.c (gdbsim_target_open): Use result of
9164         gdb_argv::release.
9165
9166 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9167         Dirk Schubert  <dirk.schubert@arm.com>
9168         Chris January  <chris.january@arm.com>
9169
9170         * eval.c (evaluate_subexp_standard): Call Fortran argument
9171         wrapping logic.
9172         * f-lang.c (struct value): A value which can be passed into a
9173         Fortran function call.
9174         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9175         where appropriate.
9176         (struct type): Value ready for a Fortran function call.
9177         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9178         is needed.
9179         * f-lang.h (fortran_argument_convert): Declaration.
9180         (fortran_preserve_arg_pointer): Declaration.
9181         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9182
9183 2019-03-05  Tom Tromey  <tromey@adacore.com>
9184
9185         * python/py-prettyprint.c (print_string_repr): Remove #if.
9186         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9187
9188 2019-03-05  Tom Tromey  <tromey@adacore.com>
9189
9190         * target.c (the_dummy_target): Move later.  Change type to
9191         "dummy_target".
9192         (initialize_targets): Don't initialize the_dummy_target.
9193
9194 2019-03-05  Tom Tromey  <tromey@adacore.com>
9195
9196         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9197         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9198
9199 2019-03-05  Tom Tromey  <tromey@adacore.com>
9200
9201         * windows-nat.c (windows_nat_target::attach)
9202         (windows_nat_target::detach): Don't call gdb_flush.
9203         * valprint.c (generic_val_print, val_print, val_print_string):
9204         Don't call gdb_flush.
9205         * utils.c (defaulted_query): Don't call gdb_flush.
9206         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9207         * target.c (target_announce_detach): Don't call gdb_flush.
9208         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9209         * remote.c (extended_remote_target::attach): Don't call
9210         gdb_flush.
9211         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9212         * printcmd.c (do_examine): Don't call gdb_flush.
9213         (info_display_command): Don't call gdb_flush.
9214         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9215         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9216         * memattr.c (info_mem_command): Don't call gdb_flush.
9217         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9218         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9219         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9220         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9221         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9222         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9223         (gnu_nat_target::detach): Don't call gdb_flush.
9224         * f-valprint.c (f_val_print): Don't call gdb_flush.
9225         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9226         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9227         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9228         gdb_flush.
9229         * c-valprint.c (c_val_print): Don't call gdb_flush.
9230         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9231
9232 2019-03-05  Tom Tromey  <tromey@adacore.com>
9233
9234         * varobj.c (update_dynamic_varobj_children): Update.
9235         (install_default_visualizer): Use reset, not release.
9236         * value.c (set_internalvar): Update.
9237         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9238         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9239         ATTRIBUTE_UNUSED_RESULT.
9240
9241 2019-03-05  Tom Tromey  <tromey@adacore.com>
9242
9243         * remote.c (class scoped_remote_fd) <release>: Add
9244         ATTRIBUTE_UNUSED_RESULT.
9245
9246 2019-03-05  Tom Tromey  <tromey@adacore.com>
9247
9248         * macroexp.c (struct macro_buffer) <release>: Add
9249         ATTRIBUTE_UNUSED_RESULT.
9250
9251 2019-03-05  Tom Tromey  <tromey@adacore.com>
9252
9253         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9254         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9255         ATTRIBUTE_UNUSED_RESULT.
9256
9257 2019-03-05  Tom Tromey  <tromey@adacore.com>
9258
9259         * common/scoped_fd.h (class scoped_fd) <release>: Add
9260         ATTRIBUTE_UNUSED_RESULT.
9261
9262 2019-03-05  Tom Tromey  <tromey@adacore.com>
9263
9264         * parser-defs.h (struct parser_state) <release>: Add
9265         ATTRIBUTE_UNUSED_RESULT.
9266
9267 2019-03-05  Tom Tromey  <tromey@adacore.com>
9268
9269         * utils.h (class gdb_argv) <release>: Add
9270         ATTRIBUTE_UNUSED_RESULT.
9271         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9272
9273 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9274
9275         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9276         for-loop range, to avoid compiler warnings.
9277
9278         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9279         avoid compiler warnings about unused variables.
9280
9281         * NEWS: Mention end of support for native debugging on MS-Windows
9282         before XP.
9283
9284         PR gdb/24292
9285         * common/netstuff.c:
9286         * gdbserver/gdbreplay.c
9287         * gdbserver/remote-utils.c:
9288         * ser-tcp.c:
9289         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9290         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9291         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9292         'getaddrinfo' and 'freeaddrinfo' were not available before
9293         Windows XP, and mingw.org's MinGW headers by default define
9294         _WIN32_WINNT to 0x500.
9295
9296 2019-03-01  Gary Benson <gbenson@redhat.com>
9297
9298         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9299
9300 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9301             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9302
9303         PR gdb/8527
9304         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9305         set_sigint_trap, clear_sigint_trap.
9306
9307 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9308
9309         * target.c (target_detach): Clear the regcache and the
9310         frame cache.
9311
9312 2019-02-27  Pedro Alves  <palves@redhat.com>
9313
9314         * utils.c (set_screen_size): When we cap the height/width sizes,
9315         tweak the corresponding command variable to show "unlimited":
9316
9317 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9318             Pedro Alves  <palves@redhat.com>
9319
9320         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9321         before calling rl_set_screen_size.
9322
9323 2019-02-27  Tom Tromey  <tromey@adacore.com>
9324
9325         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9326         define.
9327         * python/py-value.c: Remove Python 2.4 workaround.
9328         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9329         workaround.
9330         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9331         Python 2.4 workaround.
9332         * python/python-internal.h: Remove Python 2.4 comment.
9333         (Py_ssize_t): Don't define.
9334         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9335         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9336         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9337         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9338         * python/python.c (do_start_initialization): Remove Python 2.4
9339         workaround.
9340         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9341         (print_children): Remove Python 2.4 workaround.
9342         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9343         workaround.
9344         (CHARBUFFERPROC_NAME): Remove.
9345         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9346         Python 2.4 workaround.
9347
9348 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9349
9350         * NEWS: Note minimum Python version.
9351
9352 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9353
9354         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9355         code from these functions.  Remove corresponding ifdefs.  Use
9356         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9357         Remove gotos and target of gotos.
9358         (infpy_search_memory): Likewise.
9359
9360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9361
9362         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9363         (hppa_gdbarch_init): Don't register deleted functions with
9364         gdbarch.
9365
9366 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9367
9368         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9369         (h8300_unwind_sp): Delete.
9370         (h8300_dummy_id): Delete.
9371         (h8300_gdbarch_init): Don't register deleted functions with
9372         gdbarch.
9373
9374 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9375
9376         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9377         (ft32_unwind_pc): Delete.
9378         (ft32_unwind_sp): Delete.
9379         (ft32_gdbarch_init): Don't register deleted functions with
9380         gdbarch.
9381
9382 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9383
9384         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9385         (frv_unwind_pc): Delete.
9386         (frv_unwind_sp): Delete.
9387         (frv_gdbarch_init): Don't register deleted functions with
9388         gdbarch.
9389
9390 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9391
9392         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9393         (riscv_unwind_pc): Delete.
9394         (riscv_unwind_sp): Delete.
9395         (riscv_gdbarch_init): Don't register deleted functions with
9396         gdbarch.
9397
9398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9399
9400         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9401         (csky_unwind_pc): Delete.
9402         (csky_unwind_sp): Delete.
9403         (csky_gdbarch_init): Don't register deleted functions with
9404         gdbarch.
9405
9406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9407
9408         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9409         (cris_unwind_pc): Delete.
9410         (cris_unwind_sp): Delete.
9411         (cris_gdbarch_init): Don't register deleted functions with
9412         gdbarch.
9413
9414 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9415
9416         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9417         (bfin_unwind_pc): Delete.
9418         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9419
9420 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9421
9422         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9423         (arm_unwind_pc): Delete.
9424         (arm_unwind_sp): Delete.
9425         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9426
9427 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9430         (arc_unwind_pc): Delete.
9431         (arc_unwind_sp): Delete.
9432         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9433
9434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9435
9436         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9437         (alpha_unwind_pc): Delete.
9438         (alpha_gdbarch_init): Don't register deleted functions with
9439         gdbarch.
9440
9441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9442
9443         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9444         (aarch64_unwind_pc): Delete.
9445         (aarch64_unwind_sp): Delete.
9446         (aarch64_gdbarch_init): Don't register deleted functions with
9447         gdbarch.
9448
9449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9450
9451         * gdbtypes.c (type_align): Don't consider static members when
9452         computing structure alignment.
9453
9454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9455
9456         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9457         return 0 for other types.
9458         * arch-utils.c (default_type_align): Always return 0.
9459         * gdbarch.h: Regenerate.
9460         * gdbarch.sh (type_align): Extend comment.
9461         * gdbtypes.c (type_align): Add additional comments, always call
9462         gdbarch_type_align before applying the default rules.
9463         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9464         generic code will then apply a suitable default.
9465         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9466         types, return 0 for other types.
9467
9468 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9469
9470         * NEWS: Create a new section for the next release branch.
9471         Rename the section of the current branch, now that it has
9472         been cut.
9473
9474 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9475
9476         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9477         * version.in: Bump version to 8.3.50.DATE-git.
9478
9479 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9480
9481         * aix-thread.c (ptid_cmp): Remove unused variable.
9482         (get_signaled_thread): Likewise.
9483         (store_regs_user_thread): Likewise.
9484         (store_regs_kernel_thread): Likewise.
9485         (fetch_regs_kernel_thread): Remove shadowed variable.
9486
9487 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9488
9489         * features/riscv/32bit-cpu.xml: Add register numbers.
9490         * features/riscv/32bit-fpu.c: Regenerate.
9491         * features/riscv/32bit-fpu.xml: Add register numbers.
9492         * features/riscv/64bit-cpu.xml: Add register numbers.
9493         * features/riscv/64bit-fpu.c: Regenerate.
9494         * features/riscv/64bit-fpu.xml: Add register numbers.
9495
9496 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9497
9498         * NEWS: Mention two argument form of gdb.Value constructor.
9499         * python/py-value.c (convert_buffer_and_type_to_value): New
9500         function.
9501         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9502         Add support for handling an optional second argument.  Call
9503         convert_buffer_and_type_to_value as appropriate.
9504         * python/python-internal.h (Py_buffer_deleter): New struct.
9505         (Py_buffer_up): New typedef.
9506
9507 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9508
9509         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9510         instead of releasing ownership.
9511
9512 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9513
9514         * dwarf2read.c (open_and_init_dwp_file): Call
9515         elf_numsections instead of bfd_count_sections to initialize
9516         dwp_file->num_sections.
9517
9518 2019-02-25  Tom Tromey  <tromey@adacore.com>
9519
9520         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9521
9522 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9523
9524         * gcore.in: Add '--readnever' option when invoking GDB.
9525
9526 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9527
9528         * MAINTAINERS: Update my email address.
9529
9530 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9531
9532         * build-id.c (build_id_to_debug_bfd_1): New function.
9533         (build_id_to_debug_bfd): Look for separate debug file in
9534         sysroot.
9535
9536 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9537
9538         * gdbarch.sh: Update the copyright year range that is placed into
9539         generated files.
9540
9541 2019-02-22  Keith Seitz  <keiths@redhat.com>
9542
9543         PR symtab/23853
9544         * linespec.c (create_sals_line_offset): Search for the default
9545         symtab's filename instead of its fullname.
9546
9547 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9548
9549         * NEWS: Update style defaults.
9550
9551 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9552
9553         * main.c (captured_main_1): Disable styling in batch mode.
9554
9555 2019-02-20  Tom Tromey  <tom@tromey.com>
9556
9557         * symtab.c (symtab_symbol_info): Fix typos.
9558
9559 2019-02-20  Tom Tromey  <tromey@adacore.com>
9560
9561         * findcmd.c (_initialize_mem_search): Use upper case for
9562         metasyntactic variables.
9563
9564 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9565
9566         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9567         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9568
9569 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9570
9571         * top.h (source_file_name): Change to std::string.
9572         * top.c (source_file_name): Likewise.
9573         (command_line_input): Adjust.
9574         * cli/cli-script.c (script_from_file): Adjust.
9575
9576 2019-02-19  Tom Tromey  <tromey@adacore.com>
9577
9578         * ravenscar-thread.c
9579         (ravenscar_thread_target::update_thread_list): Don't call
9580         ada_build_task_list.
9581         * ada-lang.h (ada_build_task_list): Don't declare.
9582         * ada-tasks.c (struct ada_tasks_inferior_data)
9583         <task_list_valid_p>: Now bool.
9584         (read_known_tasks, ada_task_list_changed)
9585         (ada_tasks_invalidate_inferior_data): Update.
9586         (read_known_tasks_array): Return bool.
9587         (read_known_tasks_list): Likewise.
9588         (read_known_tasks): Return void.
9589         (ada_build_task_list): Now static.
9590
9591 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9592
9593         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9594         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9595
9596 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9597
9598         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9599         variant for ada_tasks_pspace_data_handle and
9600         ada_tasks_inferior_data_handle.
9601         (ada_tasks_pspace_data_cleanup): New function.
9602         (ada_tasks_inferior_data_cleanup): New function.
9603
9604 2019-02-17  Tom Tromey  <tom@tromey.com>
9605
9606         * macrotab.h (macro_source_fullname): Return a std::string.
9607         * macrotab.c (macro_include, check_for_redefinition)
9608         (macro_undef, macro_lookup_definition, foreach_macro)
9609         (foreach_macro_in_scope): Update.
9610         (macro_source_fullname): Return a std::string.
9611         * macrocmd.c (show_pp_source_pos): Update.
9612
9613 2019-02-17  Tom Tromey  <tom@tromey.com>
9614
9615         * macrocmd.c (show_pp_source_pos): Style the file names.
9616
9617 2019-02-17  Tom Tromey  <tom@tromey.com>
9618
9619         PR tui/24197:
9620         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9621
9622 2019-02-17  Tom Tromey  <tom@tromey.com>
9623
9624         * ada-lang.c (user_select_syms): Use filtered printing.
9625         * utils.c (wrap_style): New global.
9626         (desired_style): Remove.
9627         (emit_style_escape): Add stream parameter.
9628         (set_output_style, reset_terminal_style, prompt_for_continue):
9629         Update.
9630         (flush_wrap_buffer): Only flush gdb_stdout.
9631         (wrap_here): Set wrap_style.
9632         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9633         treat escape sequences as a character.  Change when wrap buffer is
9634         flushed.
9635         (fputs_styled): Do not set the output style when the default is
9636         requested.
9637         * ui-style.h (struct ui_file_style) <is_default>: New method.
9638         * source.c (print_source_lines_base): Emit escape sequences in one
9639         piece.
9640
9641 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9642
9643         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9644         integers and enumeration types.
9645
9646 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9647
9648         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9649         instead of lookup_symbol_in_language
9650         (do_exact_match): New function.
9651         (ada_get_symbol_name_matcher): Return do_exact_match when
9652         doing a verbatim match.
9653
9654 2019-02-15  Tom Tromey  <tromey@adacore.com>
9655
9656         * ravenscar-thread.c (ravenscar_thread_target::resume)
9657         (ravenscar_thread_target::wait): Special case wildcard requests.
9658
9659 2019-02-15  Tom Tromey  <tromey@adacore.com>
9660
9661         * ravenscar-thread.c (base_ptid): Remove.
9662         (struct ravenscar_thread_target) <close>: New method.
9663         <m_base_ptid>: New member.
9664         <update_inferior_ptid, active_task, task_is_currently_active,
9665         runtime_initialized>: Declare methods.
9666         <ravenscar_thread_target>: Add constructor.
9667         (ravenscar_thread_target::task_is_currently_active)
9668         (ravenscar_thread_target::update_inferior_ptid)
9669         (ravenscar_runtime_initialized): Rename.  Now methods.
9670         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9671         (ravenscar_thread_target::update_thread_list): Update.
9672         (ravenscar_thread_target::active_task): Now method.
9673         (ravenscar_thread_target::store_registers)
9674         (ravenscar_thread_target::prepare_to_store)
9675         (ravenscar_thread_target::prepare_to_store)
9676         (ravenscar_thread_target::mourn_inferior): Update.
9677         (ravenscar_inferior_created): Use "new" to create target.
9678         (ravenscar_thread_target::get_ada_task_ptid): Update.
9679         (_initialize_ravenscar): Don't initialize base_ptid.
9680         (ravenscar_ops): Remove global.
9681
9682 2019-02-15  Tom Tromey  <tromey@adacore.com>
9683
9684         * target.h (push_target): Declare new overload.
9685         * target.c (push_target): New overload, taking an rvalue reference.
9686         * remote.c (remote_target::open_1): Use push_target overload.
9687         * corelow.c (core_target_open): Use push_target overload.
9688
9689 2019-02-15  Tom Tromey  <tromey@adacore.com>
9690
9691         * ravenscar-thread.c (is_ravenscar_task)
9692         (ravenscar_task_is_currently_active): Return bool.
9693         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9694         (_initialize_ravenscar): Remove "(void)".
9695         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9696         Return bool.
9697
9698 2019-02-15  Tom Tromey  <tromey@adacore.com>
9699
9700         * ravenscar-thread.c (ravenscar_runtime_initializer)
9701         (has_ravenscar_runtime, get_running_thread_id)
9702         (ravenscar_thread_target::resume): Fix indentation.
9703
9704 2019-02-15  Tom Tromey  <tromey@adacore.com>
9705
9706         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9707         from ravenscar_arch_ops.
9708         (sparc_ravenscar_ops::fetch_registers)
9709         (sparc_ravenscar_ops::store_registers): Now methods.
9710         (sparc_ravenscar_prepare_to_store): Remove.
9711         (sparc_ravenscar_ops): Redefine.
9712         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9713         methods and destructor.  Remove members.
9714         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9715         (ravenscar_thread_target::store_registers)
9716         (ravenscar_thread_target::prepare_to_store): Update.
9717         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9718         Remove.
9719         (struct ppc_ravenscar_powerpc_ops): Derive from
9720         ravenscar_arch_ops.
9721         (ppc_ravenscar_powerpc_ops::fetch_registers)
9722         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9723         (ppc_ravenscar_powerpc_ops): Redefine.
9724         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9725         (ppc_ravenscar_e500_ops::fetch_registers)
9726         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9727         (ppc_ravenscar_e500_ops): Redefine.
9728         * aarch64-ravenscar-thread.c
9729         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9730         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9731         (aarch64_ravenscar_fetch_registers)
9732         (aarch64_ravenscar_store_registers): Now methods.
9733         (aarch64_ravenscar_ops): Redefine.
9734
9735 2019-02-15  Tom Tromey  <tromey@adacore.com>
9736
9737         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9738         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9739         (ravenscar_thread_target::stopped_by_watchpoint)
9740         (ravenscar_thread_target::stopped_data_address)
9741         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9742
9743 2019-02-15  Tom Tromey  <tromey@adacore.com>
9744
9745         * ravenscar-thread.c: Fix some typos.
9746
9747 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9748             Tom Tromey  <tromey@adacore.com>
9749
9750         * ada-lang.c (ada_exception_sal): Change addr_string to a
9751         std::string.
9752         (create_ada_exception_catchpoint): Update.
9753
9754 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9755             Tom Tromey  <tromey@adacore.com>
9756
9757         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9758         (bp_location_ops): Remove.
9759         (base_breakpoint_allocate_location): Update.
9760         (free_bp_location): Update.
9761         * ada-lang.c (class ada_catchpoint_location)
9762         <ada_catchpoint_location>: Remove ops parameter.
9763         (ada_catchpoint_location_dtor): Remove.
9764         (ada_catchpoint_location_ops): Remove.
9765         (allocate_location_exception): Update.
9766         * breakpoint.h (struct bp_location_ops): Remove.
9767         (class bp_location) <bp_location>: Remove bp_location_ops
9768         parameter.
9769         <~bp_location>: Add destructor.
9770         <ops>: Remove.
9771
9772 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9773             Pedro Alves  <palves@redhat.com>
9774
9775         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9776         'PATH_MAX'.
9777
9778 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9779             Samuel Thibault  <samuel.thibault@gnu.org>
9780             Thomas Schwinge  <thomas@codesourcery.com>
9781
9782         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9783         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9784
9785 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9786
9787         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9788         (check_empty): Use "const char *".
9789
9790         * gnu-nat.c (gnu_nat_target::detach): Instead of
9791         'detach_inferior (pid)' call
9792         'detach_inferior (find_inferior_pid (pid))'.
9793
9794         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9795         'nat/fork-inferior.o'.
9796         * gnu-nat.c: #include "nat/fork-inferior.h".
9797
9798         * gnu-nat.c (gnu_nat_target::detach): Instead of
9799         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9800         * gnu-nat.h: #include "inf-child.h".
9801         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9802         'i386_gnu_nat_target::fetch_registers'.
9803         (gnu_store_registers): Rename/move to
9804         'i386_gnu_nat_target::store_registers'.
9805
9806         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9807         * gnu-nat.h (mach_thread_info): New function.
9808         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9809
9810         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9811
9812 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9813
9814         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9815
9816 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9817
9818         * windows-nat.c (windows_add_thread): Add new parameter
9819         "main_thread_p" with default value set to false.  Update
9820         function documentation as well as all callers.
9821         (windows_delete_thread): Likewise.
9822         (fake_create_process): Update call to windows_add_thread.
9823         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9824         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9825         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9826         call to windows_delete_thread.
9827
9828 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9829
9830         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9831
9832 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9833
9834         * symfile.c (find_separate_debug_file): Use canonical path of
9835         sysroot with child_path instead of gdb_sysroot if it is valid.
9836
9837 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9838
9839         * symfile.c (find_separate_debug_file): Use child_path to
9840         determine if an object file is under a sysroot.
9841
9842 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9843
9844         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9845         unittests/child-path-selftests.c.
9846         * common/pathstuff.c (child_path): New function.
9847         * common/pathstuff.h (child_path): New prototype.
9848         * unittests/child-path-selftests.c: New file.
9849
9850 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9851
9852         * symfile.c (find_separate_debug_file): Look for separate debug
9853         files in debug directories under the sysroot.
9854
9855 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9856
9857         * symtab.h (struct minimal_symbol data_p): New const method.
9858         (struct minimal_symbol text_p): Likewise.
9859         * symtab.c (output_source_filename): Use file name style
9860         to print file name.
9861         (print_symbol_info): Likewise.
9862         (print_msymbol_info): Use address style to print addresses.
9863         Use function name style to print executable text symbols.
9864         (expand_symtab_containing_pc): Use data_p.
9865         (find_pc_sect_compunit_symtab): Likewise.
9866
9867 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9868
9869         * breakpoint.c (describe_other_breakpoints): Use address style
9870         to print addresses.
9871         (say_where): Likewise.
9872
9873 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9874
9875         * ada-typeprint.c (print_func_type): Print function name
9876         style to print function name.
9877         * c-typeprint.c (c_print_type_1): Likewise.
9878
9879 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9880
9881         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9882         for execve.
9883
9884 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9885
9886         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9887         type_stack.
9888
9889 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9890
9891         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9892         TYPE_CODE_REF types.
9893
9894 2019-02-08  Jim Wilson  <jimw@sifive.com>
9895
9896         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9897         (riscv_linux_fregset): New.
9898         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9899
9900 2019-02-07  Tom Tromey  <tom@tromey.com>
9901
9902         * thread.c (thread_cancel_execution_command): Update.
9903         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9904         methods.
9905         (struct thread_fsm_ops): Remove.
9906         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9907         (thread_fsm_should_stop, thread_fsm_return_value)
9908         (thread_fsm_set_finished, thread_fsm_finished_p)
9909         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9910         Don't declare.
9911         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9912         * infrun.c (clear_proceed_status_thread)
9913         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9914         (print_stop_event): Update.
9915         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9916         Add constructor.
9917         (step_command_fsm_ops): Remove.
9918         (new_step_command_fsm): Remove.
9919         (step_1): Update.
9920         (step_command_fsm::should_stop): Rename from
9921         step_command_fsm_should_stop.
9922         (step_command_fsm::clean_up): Rename from
9923         step_command_fsm_clean_up.
9924         (step_command_fsm::do_async_reply_reason): Rename from
9925         step_command_fsm_async_reply_reason.
9926         (struct until_next_fsm): Inherit from thread_fsm.  Add
9927         constructor.
9928         (until_next_fsm_ops): Remove.
9929         (new_until_next_fsm): Remove.
9930         (until_next_fsm::should_stop): Rename from
9931         until_next_fsm_should_stop.
9932         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9933         (until_next_fsm::do_async_reply_reason): Rename from
9934         until_next_fsm_async_reply_reason.
9935         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9936         constructor.  Change type of breakpoint.
9937         (finish_command_fsm_ops): Remove.
9938         (new_finish_command_fsm): Remove.
9939         (finish_command_fsm::should_stop): Rename from
9940         finish_command_fsm_should_stop.
9941         (finish_command_fsm::clean_up): Rename from
9942         finish_command_fsm_clean_up.
9943         (finish_command_fsm::return_value): Rename from
9944         finish_command_fsm_return_value.
9945         (finish_command_fsm::do_async_reply_reason): Rename from
9946         finish_command_fsm_async_reply_reason.
9947         (finish_command): Update.
9948         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9949         Add constructor.
9950         (call_thread_fsm_ops): Remove.
9951         (call_thread_fsm::call_thread_fsm): Rename from
9952         new_call_thread_fsm.
9953         (call_thread_fsm::should_stop): Rename from
9954         call_thread_fsm_should_stop.
9955         (call_thread_fsm::should_notify_stop): Rename from
9956         call_thread_fsm_should_notify_stop.
9957         (run_inferior_call, call_function_by_hand_dummy): Update.
9958         * cli/cli-interp.c (should_print_stop_to_console): Update.
9959         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9960         Add constructor.  Change type of location_breakpoint,
9961         caller_breakpoint.
9962         (until_break_fsm_ops): Remove.
9963         (new_until_break_fsm): Remove.
9964         (until_break_fsm::should_stop): Rename from
9965         until_break_fsm_should_stop.
9966         (until_break_fsm::clean_up): Rename from
9967         until_break_fsm_clean_up.
9968         (until_break_fsm::do_async_reply_reason): Rename from
9969         until_break_fsm_async_reply_reason.
9970         (until_break_command): Update.
9971         * thread-fsm.c: Remove.
9972         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9973
9974 2019-02-07  Tom Tromey  <tom@tromey.com>
9975
9976         * yy-remap.h: Add include guard.
9977         * xtensa-tdep.h: Add include guard.
9978         * xcoffread.h: Rename include guard.
9979         * varobj-iter.h: Add include guard.
9980         * tui/tui.h: Rename include guard.
9981         * tui/tui-winsource.h: Rename include guard.
9982         * tui/tui-wingeneral.h: Rename include guard.
9983         * tui/tui-windata.h: Rename include guard.
9984         * tui/tui-win.h: Rename include guard.
9985         * tui/tui-stack.h: Rename include guard.
9986         * tui/tui-source.h: Rename include guard.
9987         * tui/tui-regs.h: Rename include guard.
9988         * tui/tui-out.h: Rename include guard.
9989         * tui/tui-layout.h: Rename include guard.
9990         * tui/tui-io.h: Rename include guard.
9991         * tui/tui-hooks.h: Rename include guard.
9992         * tui/tui-file.h: Rename include guard.
9993         * tui/tui-disasm.h: Rename include guard.
9994         * tui/tui-data.h: Rename include guard.
9995         * tui/tui-command.h: Rename include guard.
9996         * tic6x-tdep.h: Add include guard.
9997         * target/waitstatus.h: Rename include guard.
9998         * target/wait.h: Rename include guard.
9999         * target/target.h: Rename include guard.
10000         * target/resume.h: Rename include guard.
10001         * target-float.h: Rename include guard.
10002         * stabsread.h: Add include guard.
10003         * rs6000-tdep.h: Add include guard.
10004         * riscv-fbsd-tdep.h: Add include guard.
10005         * regformats/regdef.h: Rename include guard.
10006         * record.h: Rename include guard.
10007         * python/python.h: Rename include guard.
10008         * python/python-internal.h: Rename include guard.
10009         * python/py-stopevent.h: Rename include guard.
10010         * python/py-ref.h: Rename include guard.
10011         * python/py-record.h: Rename include guard.
10012         * python/py-record-full.h: Rename include guard.
10013         * python/py-record-btrace.h: Rename include guard.
10014         * python/py-instruction.h: Rename include guard.
10015         * python/py-events.h: Rename include guard.
10016         * python/py-event.h: Rename include guard.
10017         * procfs.h: Add include guard.
10018         * proc-utils.h: Add include guard.
10019         * p-lang.h: Add include guard.
10020         * or1k-tdep.h: Rename include guard.
10021         * observable.h: Rename include guard.
10022         * nto-tdep.h: Rename include guard.
10023         * nat/x86-linux.h: Rename include guard.
10024         * nat/x86-linux-dregs.h: Rename include guard.
10025         * nat/x86-gcc-cpuid.h: Add include guard.
10026         * nat/x86-dregs.h: Rename include guard.
10027         * nat/x86-cpuid.h: Rename include guard.
10028         * nat/ppc-linux.h: Rename include guard.
10029         * nat/mips-linux-watch.h: Rename include guard.
10030         * nat/linux-waitpid.h: Rename include guard.
10031         * nat/linux-ptrace.h: Rename include guard.
10032         * nat/linux-procfs.h: Rename include guard.
10033         * nat/linux-osdata.h: Rename include guard.
10034         * nat/linux-nat.h: Rename include guard.
10035         * nat/linux-namespaces.h: Rename include guard.
10036         * nat/linux-btrace.h: Rename include guard.
10037         * nat/glibc_thread_db.h: Rename include guard.
10038         * nat/gdb_thread_db.h: Rename include guard.
10039         * nat/gdb_ptrace.h: Rename include guard.
10040         * nat/fork-inferior.h: Rename include guard.
10041         * nat/amd64-linux-siginfo.h: Rename include guard.
10042         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10043         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10044         * nat/aarch64-linux.h: Rename include guard.
10045         * nat/aarch64-linux-hw-point.h: Rename include guard.
10046         * mn10300-tdep.h: Add include guard.
10047         * mips-linux-tdep.h: Add include guard.
10048         * mi/mi-parse.h: Rename include guard.
10049         * mi/mi-out.h: Rename include guard.
10050         * mi/mi-main.h: Rename include guard.
10051         * mi/mi-interp.h: Rename include guard.
10052         * mi/mi-getopt.h: Rename include guard.
10053         * mi/mi-console.h: Rename include guard.
10054         * mi/mi-common.h: Rename include guard.
10055         * mi/mi-cmds.h: Rename include guard.
10056         * mi/mi-cmd-break.h: Rename include guard.
10057         * m2-lang.h: Add include guard.
10058         * location.h: Rename include guard.
10059         * linux-record.h: Rename include guard.
10060         * linux-nat.h: Add include guard.
10061         * linux-fork.h: Add include guard.
10062         * i386-darwin-tdep.h: Rename include guard.
10063         * hppa-linux-offsets.h: Add include guard.
10064         * guile/guile.h: Rename include guard.
10065         * guile/guile-internal.h: Rename include guard.
10066         * gnu-nat.h: Rename include guard.
10067         * gdb-stabs.h: Rename include guard.
10068         * frv-tdep.h: Add include guard.
10069         * f-lang.h: Add include guard.
10070         * event-loop.h: Add include guard.
10071         * darwin-nat.h: Rename include guard.
10072         * cp-abi.h: Rename include guard.
10073         * config/sparc/nm-sol2.h: Rename include guard.
10074         * config/nm-nto.h: Rename include guard.
10075         * config/nm-linux.h: Add include guard.
10076         * config/i386/nm-i386gnu.h: Rename include guard.
10077         * config/djgpp/nl_types.h: Rename include guard.
10078         * config/djgpp/langinfo.h: Rename include guard.
10079         * compile/gcc-cp-plugin.h: Add include guard.
10080         * compile/gcc-c-plugin.h: Add include guard.
10081         * compile/compile.h: Rename include guard.
10082         * compile/compile-object-run.h: Rename include guard.
10083         * compile/compile-object-load.h: Rename include guard.
10084         * compile/compile-internal.h: Rename include guard.
10085         * compile/compile-cplus.h: Rename include guard.
10086         * compile/compile-c.h: Rename include guard.
10087         * common/xml-utils.h: Rename include guard.
10088         * common/x86-xstate.h: Rename include guard.
10089         * common/version.h: Rename include guard.
10090         * common/vec.h: Rename include guard.
10091         * common/tdesc.h: Rename include guard.
10092         * common/selftest.h: Rename include guard.
10093         * common/scoped_restore.h: Rename include guard.
10094         * common/scoped_mmap.h: Rename include guard.
10095         * common/scoped_fd.h: Rename include guard.
10096         * common/safe-iterator.h: Rename include guard.
10097         * common/run-time-clock.h: Rename include guard.
10098         * common/refcounted-object.h: Rename include guard.
10099         * common/queue.h: Rename include guard.
10100         * common/ptid.h: Rename include guard.
10101         * common/print-utils.h: Rename include guard.
10102         * common/preprocessor.h: Rename include guard.
10103         * common/pathstuff.h: Rename include guard.
10104         * common/observable.h: Rename include guard.
10105         * common/netstuff.h: Rename include guard.
10106         * common/job-control.h: Rename include guard.
10107         * common/host-defs.h: Rename include guard.
10108         * common/gdb_wait.h: Rename include guard.
10109         * common/gdb_vecs.h: Rename include guard.
10110         * common/gdb_unlinker.h: Rename include guard.
10111         * common/gdb_unique_ptr.h: Rename include guard.
10112         * common/gdb_tilde_expand.h: Rename include guard.
10113         * common/gdb_sys_time.h: Rename include guard.
10114         * common/gdb_string_view.h: Rename include guard.
10115         * common/gdb_splay_tree.h: Rename include guard.
10116         * common/gdb_setjmp.h: Rename include guard.
10117         * common/gdb_ref_ptr.h: Rename include guard.
10118         * common/gdb_optional.h: Rename include guard.
10119         * common/gdb_locale.h: Rename include guard.
10120         * common/gdb_assert.h: Rename include guard.
10121         * common/filtered-iterator.h: Rename include guard.
10122         * common/filestuff.h: Rename include guard.
10123         * common/fileio.h: Rename include guard.
10124         * common/environ.h: Rename include guard.
10125         * common/common-utils.h: Rename include guard.
10126         * common/common-types.h: Rename include guard.
10127         * common/common-regcache.h: Rename include guard.
10128         * common/common-inferior.h: Rename include guard.
10129         * common/common-gdbthread.h: Rename include guard.
10130         * common/common-exceptions.h: Rename include guard.
10131         * common/common-defs.h: Rename include guard.
10132         * common/common-debug.h: Rename include guard.
10133         * common/cleanups.h: Rename include guard.
10134         * common/buffer.h: Rename include guard.
10135         * common/btrace-common.h: Rename include guard.
10136         * common/break-common.h: Rename include guard.
10137         * cli/cli-utils.h: Rename include guard.
10138         * cli/cli-style.h: Rename include guard.
10139         * cli/cli-setshow.h: Rename include guard.
10140         * cli/cli-script.h: Rename include guard.
10141         * cli/cli-interp.h: Rename include guard.
10142         * cli/cli-decode.h: Rename include guard.
10143         * cli/cli-cmds.h: Rename include guard.
10144         * charset-list.h: Add include guard.
10145         * buildsym-legacy.h: Rename include guard.
10146         * bfin-tdep.h: Add include guard.
10147         * ax.h: Rename include guard.
10148         * arm-linux-tdep.h: Add include guard.
10149         * arm-fbsd-tdep.h: Add include guard.
10150         * arch/xtensa.h: Rename include guard.
10151         * arch/tic6x.h: Add include guard.
10152         * arch/i386.h: Add include guard.
10153         * arch/arm.h: Rename include guard.
10154         * arch/arm-linux.h: Rename include guard.
10155         * arch/arm-get-next-pcs.h: Rename include guard.
10156         * arch/amd64.h: Add include guard.
10157         * arch/aarch64-insn.h: Rename include guard.
10158         * arch-utils.h: Rename include guard.
10159         * annotate.h: Add include guard.
10160         * amd64-darwin-tdep.h: Rename include guard.
10161         * aarch64-linux-tdep.h: Add include guard.
10162         * aarch64-fbsd-tdep.h: Add include guard.
10163         * aarch32-linux-nat.h: Add include guard.
10164
10165 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10166
10167         * macrotab.c (macro_define_internal): New function that
10168         factorizes macro_define_object_internal and macro_define_function
10169         code.
10170         (macro_define_object_internal): Use macro_define_internal.
10171         (macro_define_function): Likewise.
10172
10173 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10174
10175         * macrocmd.c (extract_identifier): Return
10176         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10177         callers.
10178
10179 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10180
10181         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10182
10183 2019-02-05  Tom Tromey  <tom@tromey.com>
10184
10185         * target.c (target_stack::unpush): Move assertion earlier.
10186
10187 2019-01-30  Tom Tromey  <tom@tromey.com>
10188
10189         PR python/23615:
10190         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10191         (gdbpy_parse_and_eval): Likewise.
10192         * python/python-internal.h (gdbpy_allow_threads): New class.
10193
10194 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10195
10196         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10197         (aarch64_fbsd_fpregmap): Move earlier.
10198         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10199         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10200         instead of individual calls to trad_frame_set_reg_addr.
10201         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10202         earlier.
10203         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10204         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10205         instead of individual calls to trad_frame_set_reg_addr.
10206
10207 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10208
10209         * CONTRIBUTE: Replace contribution list with wiki link.
10210
10211 2019-01-25  Tom Tromey  <tom@tromey.com>
10212
10213         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10214
10215 2019-01-25  Tom Tromey  <tom@tromey.com>
10216
10217         * xtensa-linux-nat.c: Fix common/ includes.
10218         * xml-support.h: Fix common/ includes.
10219         * xml-support.c: Fix common/ includes.
10220         * x86-linux-nat.c: Fix common/ includes.
10221         * windows-nat.c: Fix common/ includes.
10222         * varobj.h: Fix common/ includes.
10223         * varobj.c: Fix common/ includes.
10224         * value.c: Fix common/ includes.
10225         * valops.c: Fix common/ includes.
10226         * utils.c: Fix common/ includes.
10227         * unittests/xml-utils-selftests.c: Fix common/ includes.
10228         * unittests/utils-selftests.c: Fix common/ includes.
10229         * unittests/unpack-selftests.c: Fix common/ includes.
10230         * unittests/tracepoint-selftests.c: Fix common/ includes.
10231         * unittests/style-selftests.c: Fix common/ includes.
10232         * unittests/string_view-selftests.c: Fix common/ includes.
10233         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10234         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10235         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10236         * unittests/rsp-low-selftests.c: Fix common/ includes.
10237         * unittests/parse-connection-spec-selftests.c: Fix common/
10238         includes.
10239         * unittests/optional-selftests.c: Fix common/ includes.
10240         * unittests/offset-type-selftests.c: Fix common/ includes.
10241         * unittests/observable-selftests.c: Fix common/ includes.
10242         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10243         * unittests/memrange-selftests.c: Fix common/ includes.
10244         * unittests/memory-map-selftests.c: Fix common/ includes.
10245         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10246         * unittests/function-view-selftests.c: Fix common/ includes.
10247         * unittests/environ-selftests.c: Fix common/ includes.
10248         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10249         * unittests/common-utils-selftests.c: Fix common/ includes.
10250         * unittests/cli-utils-selftests.c: Fix common/ includes.
10251         * unittests/array-view-selftests.c: Fix common/ includes.
10252         * ui-file.c: Fix common/ includes.
10253         * tui/tui-io.c: Fix common/ includes.
10254         * tracepoint.h: Fix common/ includes.
10255         * tracepoint.c: Fix common/ includes.
10256         * tracefile-tfile.c: Fix common/ includes.
10257         * top.h: Fix common/ includes.
10258         * top.c: Fix common/ includes.
10259         * thread.c: Fix common/ includes.
10260         * target/waitstatus.h: Fix common/ includes.
10261         * target/waitstatus.c: Fix common/ includes.
10262         * target.h: Fix common/ includes.
10263         * target.c: Fix common/ includes.
10264         * target-memory.c: Fix common/ includes.
10265         * target-descriptions.c: Fix common/ includes.
10266         * symtab.h: Fix common/ includes.
10267         * symfile.c: Fix common/ includes.
10268         * stap-probe.c: Fix common/ includes.
10269         * spu-linux-nat.c: Fix common/ includes.
10270         * sparc-nat.c: Fix common/ includes.
10271         * source.c: Fix common/ includes.
10272         * solib.c: Fix common/ includes.
10273         * solib-target.c: Fix common/ includes.
10274         * ser-unix.c: Fix common/ includes.
10275         * ser-tcp.c: Fix common/ includes.
10276         * ser-pipe.c: Fix common/ includes.
10277         * ser-base.c: Fix common/ includes.
10278         * selftest-arch.c: Fix common/ includes.
10279         * s12z-tdep.c: Fix common/ includes.
10280         * rust-exp.y: Fix common/ includes.
10281         * rs6000-aix-tdep.c: Fix common/ includes.
10282         * riscv-tdep.c: Fix common/ includes.
10283         * remote.c: Fix common/ includes.
10284         * remote-notif.h: Fix common/ includes.
10285         * remote-fileio.h: Fix common/ includes.
10286         * remote-fileio.c: Fix common/ includes.
10287         * regcache.h: Fix common/ includes.
10288         * regcache.c: Fix common/ includes.
10289         * record-btrace.c: Fix common/ includes.
10290         * python/python.c: Fix common/ includes.
10291         * python/py-type.c: Fix common/ includes.
10292         * python/py-inferior.c: Fix common/ includes.
10293         * progspace.h: Fix common/ includes.
10294         * producer.c: Fix common/ includes.
10295         * procfs.c: Fix common/ includes.
10296         * proc-api.c: Fix common/ includes.
10297         * printcmd.c: Fix common/ includes.
10298         * ppc-linux-nat.c: Fix common/ includes.
10299         * parser-defs.h: Fix common/ includes.
10300         * osdata.c: Fix common/ includes.
10301         * obsd-nat.c: Fix common/ includes.
10302         * nat/x86-linux.c: Fix common/ includes.
10303         * nat/x86-linux-dregs.c: Fix common/ includes.
10304         * nat/x86-dregs.h: Fix common/ includes.
10305         * nat/x86-dregs.c: Fix common/ includes.
10306         * nat/ppc-linux.c: Fix common/ includes.
10307         * nat/mips-linux-watch.h: Fix common/ includes.
10308         * nat/mips-linux-watch.c: Fix common/ includes.
10309         * nat/linux-waitpid.c: Fix common/ includes.
10310         * nat/linux-ptrace.h: Fix common/ includes.
10311         * nat/linux-ptrace.c: Fix common/ includes.
10312         * nat/linux-procfs.c: Fix common/ includes.
10313         * nat/linux-personality.c: Fix common/ includes.
10314         * nat/linux-osdata.c: Fix common/ includes.
10315         * nat/linux-namespaces.c: Fix common/ includes.
10316         * nat/linux-btrace.h: Fix common/ includes.
10317         * nat/linux-btrace.c: Fix common/ includes.
10318         * nat/fork-inferior.c: Fix common/ includes.
10319         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10320         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10321         * nat/aarch64-linux.c: Fix common/ includes.
10322         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10323         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10324         * namespace.h: Fix common/ includes.
10325         * mips-linux-tdep.c: Fix common/ includes.
10326         * minsyms.c: Fix common/ includes.
10327         * mi/mi-parse.h: Fix common/ includes.
10328         * mi/mi-main.c: Fix common/ includes.
10329         * mi/mi-cmd-env.c: Fix common/ includes.
10330         * memrange.h: Fix common/ includes.
10331         * memattr.c: Fix common/ includes.
10332         * maint.h: Fix common/ includes.
10333         * maint.c: Fix common/ includes.
10334         * main.c: Fix common/ includes.
10335         * machoread.c: Fix common/ includes.
10336         * location.c: Fix common/ includes.
10337         * linux-thread-db.c: Fix common/ includes.
10338         * linux-nat.c: Fix common/ includes.
10339         * linux-fork.c: Fix common/ includes.
10340         * inline-frame.c: Fix common/ includes.
10341         * infrun.c: Fix common/ includes.
10342         * inflow.c: Fix common/ includes.
10343         * inferior.h: Fix common/ includes.
10344         * inferior.c: Fix common/ includes.
10345         * infcmd.c: Fix common/ includes.
10346         * inf-ptrace.c: Fix common/ includes.
10347         * inf-child.c: Fix common/ includes.
10348         * ia64-linux-nat.c: Fix common/ includes.
10349         * i387-tdep.c: Fix common/ includes.
10350         * i386-tdep.c: Fix common/ includes.
10351         * i386-linux-tdep.c: Fix common/ includes.
10352         * i386-linux-nat.c: Fix common/ includes.
10353         * i386-go32-tdep.c: Fix common/ includes.
10354         * i386-fbsd-tdep.c: Fix common/ includes.
10355         * i386-fbsd-nat.c: Fix common/ includes.
10356         * guile/scm-type.c: Fix common/ includes.
10357         * guile/guile.c: Fix common/ includes.
10358         * go32-nat.c: Fix common/ includes.
10359         * gnu-nat.c: Fix common/ includes.
10360         * gdbthread.h: Fix common/ includes.
10361         * gdbarch-selftests.c: Fix common/ includes.
10362         * gdb_usleep.c: Fix common/ includes.
10363         * gdb_select.h: Fix common/ includes.
10364         * gdb_bfd.c: Fix common/ includes.
10365         * gcore.c: Fix common/ includes.
10366         * fork-child.c: Fix common/ includes.
10367         * findvar.c: Fix common/ includes.
10368         * fbsd-nat.c: Fix common/ includes.
10369         * event-top.c: Fix common/ includes.
10370         * event-loop.c: Fix common/ includes.
10371         * dwarf2read.c: Fix common/ includes.
10372         * dwarf2loc.c: Fix common/ includes.
10373         * dwarf2-frame.c: Fix common/ includes.
10374         * dwarf-index-cache.c: Fix common/ includes.
10375         * dtrace-probe.c: Fix common/ includes.
10376         * disasm-selftests.c: Fix common/ includes.
10377         * defs.h: Fix common/ includes.
10378         * csky-tdep.c: Fix common/ includes.
10379         * cp-valprint.c: Fix common/ includes.
10380         * cp-support.h: Fix common/ includes.
10381         * cp-support.c: Fix common/ includes.
10382         * corelow.c: Fix common/ includes.
10383         * completer.h: Fix common/ includes.
10384         * completer.c: Fix common/ includes.
10385         * compile/compile.c: Fix common/ includes.
10386         * compile/compile-loc2c.c: Fix common/ includes.
10387         * compile/compile-cplus-types.c: Fix common/ includes.
10388         * compile/compile-cplus-symbols.c: Fix common/ includes.
10389         * command.h: Fix common/ includes.
10390         * cli/cli-dump.c: Fix common/ includes.
10391         * cli/cli-cmds.c: Fix common/ includes.
10392         * charset.c: Fix common/ includes.
10393         * build-id.c: Fix common/ includes.
10394         * btrace.h: Fix common/ includes.
10395         * btrace.c: Fix common/ includes.
10396         * breakpoint.h: Fix common/ includes.
10397         * breakpoint.c: Fix common/ includes.
10398         * ax.h:
10399         (enum agent_op): Fix common/ includes.
10400         * ax-general.c (struct aop_map): Fix common/ includes.
10401         * ax-gdb.c: Fix common/ includes.
10402         * auxv.c: Fix common/ includes.
10403         * auto-load.c: Fix common/ includes.
10404         * arm-tdep.c: Fix common/ includes.
10405         * arch/riscv.c: Fix common/ includes.
10406         * arch/ppc-linux-common.c: Fix common/ includes.
10407         * arch/i386.c: Fix common/ includes.
10408         * arch/arm.c: Fix common/ includes.
10409         * arch/arm-linux.c: Fix common/ includes.
10410         * arch/arm-get-next-pcs.c: Fix common/ includes.
10411         * arch/amd64.c: Fix common/ includes.
10412         * arch/aarch64.c: Fix common/ includes.
10413         * arch/aarch64-insn.c: Fix common/ includes.
10414         * arch-utils.c: Fix common/ includes.
10415         * amd64-windows-tdep.c: Fix common/ includes.
10416         * amd64-tdep.c: Fix common/ includes.
10417         * amd64-sol2-tdep.c: Fix common/ includes.
10418         * amd64-obsd-tdep.c: Fix common/ includes.
10419         * amd64-nbsd-tdep.c: Fix common/ includes.
10420         * amd64-linux-tdep.c: Fix common/ includes.
10421         * amd64-linux-nat.c: Fix common/ includes.
10422         * amd64-fbsd-tdep.c: Fix common/ includes.
10423         * amd64-fbsd-nat.c: Fix common/ includes.
10424         * amd64-dicos-tdep.c: Fix common/ includes.
10425         * amd64-darwin-tdep.c: Fix common/ includes.
10426         * agent.c: Fix common/ includes.
10427         * ada-lang.h: Fix common/ includes.
10428         * ada-lang.c: Fix common/ includes.
10429         * aarch64-tdep.c: Fix common/ includes.
10430
10431 2019-01-25  Tom Tromey  <tom@tromey.com>
10432
10433         * common/create-version.sh: Use common/version.h.
10434
10435 2019-01-24  Pedro Alves  <palves@redhat.com>
10436
10437         * infrun.c (signal_stop, signal_print, signal_program)
10438         (signal_catch, signal_pass): Now arrays instead of pointers.
10439         (update_signals_program_target, do_target_resume)
10440         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10441         * linux-nat.c (linux_nat_target::pass_signals)
10442         (linux_nat_target::create_inferior, linux_nat_target::attach):
10443         Adjust.
10444         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10445         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10446         * procfs.c (procfs_target::pass_signals): Adjust.
10447         * record-full.c (record_full_target::resume): Adjust.
10448         * remote.c (remote_target::pass_signals)
10449         (remote_target::program_signals): Adjust.
10450         * target-debug.h (target_debug_print_signals): Now takes a
10451         gdb::array_view as parameter.  Adjust.
10452         * target.h (target_ops) <pass_signals, program_signals>: Replace
10453         pointer and length parameters with gdb::array_view.
10454         (target_pass_signals, target_program_signals): Likewise.
10455         * target-delegates.c: Regenerate.
10456
10457 2019-01-24  Pedro Alves  <palves@redhat.com>
10458
10459         * common/forward-scope-exit.h
10460         (forward_scope_exit::forward_scope_exit): Pass arguments to
10461         m_bind_function directly, instead of creating a std::bind and
10462         copying that.
10463
10464 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10465
10466         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10467         for static members.
10468         (pass_in_v_vfp_candidate): Likewise.
10469
10470 2019-01-23  Tom Tromey  <tom@tromey.com>
10471             Pedro Alves  <palves@redhat.com>
10472
10473         * regcache.c (class regcache_invalidator): Remove.
10474         (regcache::raw_write): Use make_scope_exit.
10475
10476 2019-01-23  Tom Tromey  <tom@tromey.com>
10477
10478         * ui-out.h (class ui_out_emit_type): Update comment.
10479
10480 2019-01-23  Tom Tromey  <tom@tromey.com>
10481
10482         * infrun.c (fetch_inferior_event): Update comment.
10483
10484 2019-01-23  Tom Tromey  <tom@tromey.com>
10485             Pedro Alves  <palves@redhat.com>
10486
10487         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10488         parameter.
10489         (fetch_inferior_event): Use SCOPE_EXIT.
10490
10491
10492 2019-01-23  Tom Tromey  <tom@tromey.com>
10493             Pedro Alves  <palves@redhat.com>
10494
10495         * infrun.c (disable_thread_events): Delete.
10496         (stop_all_threads): Use SCOPE_EXIT.
10497
10498 2019-01-23  Tom Tromey  <tom@tromey.com>
10499             Pedro Alves  <palves@redhat.com>
10500
10501         * symfile.c: Include forward-scope-exit.h.
10502         (clear_symtab_users_cleanup): Replace forward declaration with
10503         a FORWARD_SCOPE_EXIT.
10504         (syms_from_objfile_1): Use the forward_scope_exit and
10505         gdb::optional instead of cleanup_function.
10506         (reread_symbols): Use the forward_scope_exit instead of
10507         cleanup_function.
10508         (clear_symtab_users_cleanup): Remove function.
10509
10510 2019-01-23  Tom Tromey  <tom@tromey.com>
10511             Pedro Alves  <palves@redhat.com>
10512
10513         * linux-nat.c: Include scope-exit.h.
10514         (cleanup_target_stop): Remove.
10515         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10516         SCOPE_EXIT.
10517
10518 2019-01-23  Tom Tromey  <tom@tromey.com>
10519             Pedro Alves  <palves@redhat.com>
10520
10521         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10522         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10523
10524 2019-01-23  Tom Tromey  <tom@tromey.com>
10525             Andrew Burgess  <andrew.burgess@embecosm.com>
10526             Pedro Alves  <palves@redhat.com>
10527
10528         * infrun.c (fetch_inferior_event): Use scope_exit.
10529         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10530         * top.c (execute_command): Use scope_exit.
10531         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10532         * utils.c (do_bpstat_clear_actions_cleanup)
10533         (make_bpstat_clear_actions_cleanup): Remove.
10534
10535 2019-01-23  Tom Tromey  <tom@tromey.com>
10536             Pedro Alves  <palves@redhat.com>
10537
10538         * infrun.c: Include "common/scope-exit.h"
10539         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10540         (wait_for_inferior): Use SCOPE_EXIT.
10541         (fetch_inferior_event): Use scope_exit.
10542
10543 2019-01-23  Tom Tromey  <tom@tromey.com>
10544             Pedro Alves  <palves@redhat.com>
10545
10546         * breakpoint.c (create_breakpoint): Remove cleanup.
10547
10548 2019-01-23  Tom Tromey  <tom@tromey.com>
10549             Andrew Burgess  <andrew.burgess@embecosm.com>
10550             Pedro Alves  <palves@redhat.com>
10551
10552 2019-01-23  Pedro Alves  <palves@redhat.com>
10553
10554         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10555
10556 2019-01-23  Pedro Alves  <palves@redhat.com>
10557             Andrew Burgess  <andrew.burgess@embecosm.com>
10558
10559         * gdbthread.h: Include "common/forward-scope-exit.h".
10560         (scoped_finish_thread_state): Redefine custom class in terms of
10561         forward_scope_exit.
10562
10563 2019-01-23  Pedro Alves  <palves@redhat.com>
10564             Andrew Burgess  <andrew.burgess@embecosm.com>
10565
10566         * common/forward-scope-exit.h: New file.
10567
10568 2019-01-23  Pedro Alves  <palves@redhat.com>
10569             Andrew Burgess  <andrew.burgess@embecosm.com>
10570             Tom Tromey  <tom@tromey.com>
10571
10572         * common/scope-exit.h: New file.
10573
10574 2019-01-23  Pedro Alves  <palves@redhat.com>
10575
10576         * common/preprocessor.h (ESC): Rename to ...
10577         (ESC_PARENS): ... this.
10578         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10579         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10580
10581 2019-01-23  Tom Tromey  <tom@tromey.com>
10582
10583         * language.h (class scoped_switch_to_sym_language_if_auto):
10584         Initialize m_lang in both cases.
10585
10586 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10587
10588         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10589         with XCNEW.
10590
10591 2019-01-22  Tom Tromey  <tom@tromey.com>
10592
10593         * corelow.c: Do not include sys/file.h.
10594
10595 2019-01-22  Tom Tromey  <tom@tromey.com>
10596
10597         * tui/tui-wingeneral.h: Include gdb_curses.h.
10598
10599 2019-01-22  Tom Tromey  <tom@tromey.com>
10600
10601         * source-cache.h (class source_cache) <get_source_lines,
10602         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10603
10604 2019-01-22  Tom Tromey  <tom@tromey.com>
10605
10606         * remote-fileio.h (struct remote_target): Declare.
10607
10608 2019-01-22  Tom Tromey  <tom@tromey.com>
10609
10610         * python/py-arch.c: Do not include py-ref.h.
10611         * python/py-bpevent.c: Do not include py-ref.h.
10612         * python/py-cmd.c: Do not include py-ref.h.
10613         * python/py-continueevent.c: Do not include py-ref.h.
10614         * python/py-event.h: Do not include py-ref.h.
10615         * python/py-evtregistry.c: Do not include py-ref.h.
10616         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10617         * python/py-frame.c: Do not include py-ref.h.
10618         * python/py-framefilter.c: Do not include py-ref.h.
10619         * python/py-function.c: Do not include py-ref.h.
10620         * python/py-infevents.c: Do not include py-ref.h.
10621         * python/py-linetable.c: Do not include py-ref.h.
10622         * python/py-objfile.c: Do not include py-ref.h.
10623         * python/py-param.c: Do not include py-ref.h.
10624         * python/py-prettyprint.c: Do not include py-ref.h.
10625         * python/py-progspace.c: Do not include py-ref.h.
10626         * python/py-symbol.c: Do not include py-ref.h.
10627         * python/py-symtab.c: Do not include py-ref.h.
10628         * python/py-type.c: Do not include py-ref.h.
10629         * python/py-unwind.c: Do not include py-ref.h.
10630         * python/py-utils.c: Do not include py-ref.h.
10631         * python/py-value.c: Do not include py-ref.h.
10632         * python/py-varobj.c: Do not include py-ref.h.
10633         * python/py-xmethods.c: Do not include py-ref.h.
10634         * python/python.c: Do not include py-ref.h.
10635         * varobj.c: Do not include py-ref.h.
10636
10637 2019-01-22  Tom Tromey  <tom@tromey.com>
10638
10639         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10640         keyword for bcache.
10641
10642 2019-01-22  Tom Tromey  <tom@tromey.com>
10643
10644         * compile/compile-cplus-types.c: Remove a comment by #include.
10645
10646 2019-01-22  Tom Tromey  <tom@tromey.com>
10647
10648         * compile/gcc-c-plugin.h: Include compile-internal.h.
10649
10650 2019-01-22  Tom Tromey  <tom@tromey.com>
10651
10652         * stabsread.c (EXTERN): Do not define.
10653         (symnum, next_symbol_text_func, processing_gcc_compilation)
10654         (within_function, global_sym_chain, global_stabs)
10655         (previous_stab_code, this_object_header_files)
10656         (n_this_object_header_files)
10657         (n_allocated_this_object_header_files): Define.
10658         * stabsread.h (EXTERN): Never define.  Use "extern".
10659
10660 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10661
10662         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10663         history_value.
10664
10665 2019-01-21  Tom Tromey  <tom@tromey.com>
10666
10667         * ui-out.c: Fix includes.
10668         * tui/tui-source.c: Fix includes.
10669         * target.c: Fix includes.
10670         * remote.c: Fix includes.
10671         * regcache.c: Fix includes.
10672         * python/py-block.c: Fix includes.
10673         * printcmd.c: Fix includes.
10674         * or1k-tdep.c: Fix includes.
10675         * mi/mi-main.c: Fix includes.
10676         * m32r-tdep.c: Fix includes.
10677         * csky-tdep.c: Fix includes.
10678         * compile/compile-cplus-types.c: Fix includes.
10679         * cli/cli-interp.c: Fix includes.
10680
10681 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10682
10683         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10684         for padding.
10685
10686 2019-01-16  Tom Tromey  <tom@tromey.com>
10687
10688         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10689         earlier.
10690         (struct objfile) <msymbols_range>: Move from top level.
10691         <msymbols>: New method.
10692         (class objfile_msymbols): Remove.
10693         * symtab.c (default_collect_symbol_completion_matches_break_on):
10694         Update.
10695         * symmisc.c (dump_msymbols): Update.
10696         * stabsread.c (scan_file_globals): Update.
10697         * objc-lang.c (info_selectors_command, info_classes_command)
10698         (find_methods): Update.
10699         * minsyms.c (find_solib_trampoline_target): Update.
10700         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10701         * coffread.c (coff_symfile_read): Update.
10702         * ada-lang.c (ada_lookup_simple_minsym)
10703         (ada_collect_symbol_completion_matches): Update.
10704
10705 2019-01-16  Tom Tromey  <tom@tromey.com>
10706
10707         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10708         type.  Remove no-argument constructor.
10709         <iterator::operator++>: Simplify.
10710         <begin>: Update.
10711         <end>: Use minimal_symbol_count.
10712
10713 2019-01-16  Tom Tromey  <tom@tromey.com>
10714
10715         * objfiles.h (struct objfile) <psymtabs>: New method.
10716         (class objfile_psymtabs): Remove.
10717         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10718         typedef.
10719         <range>: New method.
10720         (require_partial_symbols): Change return type.
10721         * psymtab.c (require_partial_symbols)
10722         (psym_expand_symtabs_matching): Update.
10723         * mdebugread.c (parse_partial_symbols): Update.
10724         * dbxread.c (dbx_end_psymtab): Update.
10725
10726 2019-01-15  Tom Tromey  <tom@tromey.com>
10727
10728         * symtab.c (lookup_objfile_from_block)
10729         (lookup_symbol_in_objfile_symtabs)
10730         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10731         (find_line_symtab, info_sources_command)
10732         (default_collect_symbol_completion_matches_break_on)
10733         (make_source_files_completion_list): Update.
10734         * symmisc.c (print_objfile_statistics, dump_objfile)
10735         (maintenance_print_symbols, maintenance_info_symtabs)
10736         (maintenance_check_symtabs, maintenance_info_line_tables):
10737         Update.
10738         * source.c (select_source_symtab)
10739         (forget_cached_source_info_for_objfile): Update.
10740         * objfiles.h (class objfile_compunits): Remove.
10741         (struct objfile) <compunits_range>: New typedef.
10742         (compunits): New method.
10743         * objfiles.c (objfile_relocate1): Update.
10744         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10745         * maint.c (count_symtabs_and_blocks): Update.
10746         * linespec.c (iterate_over_all_matching_symtabs): Update.
10747         * cp-support.c (add_symbol_overload_list_qualified): Update.
10748         * coffread.c (coff_symtab_read): Update.
10749         * ada-lang.c (add_nonlocal_symbols)
10750         (ada_collect_symbol_completion_matches)
10751         (ada_add_global_exceptions): Update.
10752
10753 2019-01-15  Tom Tromey  <tom@tromey.com>
10754
10755         * progspace.h (program_space) <objfiles_safe_range>: New
10756         typedef.
10757         <objfiles_safe>: New method.
10758         * objfiles.h (class all_objfiles_safe): Remove.
10759         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10760         * jit.c (jit_inferior_exit_hook): Update.
10761
10762 2019-01-17  Tom Tromey  <tom@tromey.com>
10763
10764         * progspace.h (program_space) <objfiles_range>: New typedef.
10765         <objfiles>: New method.
10766         <objfiles_head>: Rename from objfiles.
10767         (object_files): Update.
10768         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10769         * guile/scm-pretty-print.c
10770         (ppscm_find_pretty_printer_from_objfiles): Update.
10771         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10772         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10773         Update.
10774         * python/py-progspace.c (pspy_get_objfiles): Update.
10775         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10776         Update.
10777         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10778         (objfpy_lookup_objfile_by_build_id): Update.
10779         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10780         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10781         Update.
10782         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10783         (expand_symtab_containing_pc, lookup_objfile_from_block)
10784         (lookup_static_symbol, basic_lookup_transparent_type)
10785         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10786         (find_line_symtab, info_sources_command)
10787         (default_collect_symbol_completion_matches_break_on)
10788         (make_source_files_completion_list, find_main_name): Update.
10789         * symmisc.c (print_symbol_bcache_statistics)
10790         (print_objfile_statistics, maintenance_print_symbols)
10791         (maintenance_print_msymbols, maintenance_print_objfiles)
10792         (maintenance_info_symtabs, maintenance_check_symtabs)
10793         (maintenance_expand_symtabs, maintenance_info_line_tables):
10794         Update.
10795         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10796         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10797         (map_overlay_command, unmap_overlay_command)
10798         (simple_overlay_update, expand_symtabs_matching)
10799         (map_symbol_filenames): Update.
10800         * symfile-debug.c (set_debug_symfile): Update.
10801         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10802         Update.
10803         * source.c (select_source_symtab, forget_cached_source_info):
10804         Update.
10805         * solib.c (solib_read_symbols): Update.
10806         * solib-spu.c (append_ocl_sos): Update.
10807         * psymtab.c (maintenance_print_psymbols)
10808         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10809         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10810         * printcmd.c (info_symbol_command): Update.
10811         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10812         Update.
10813         * objfiles.h (class all_objfiles): Remove.
10814         * objfiles.c (have_partial_symbols, have_full_symbols)
10815         (have_minimal_symbols, qsort_cmp, update_section_map)
10816         (shared_objfile_contains_address_p)
10817         (default_iterate_over_objfiles_in_search_order): Update.
10818         * objc-lang.c (info_selectors_command, info_classes_command)
10819         (find_methods): Update.
10820         * minsyms.c (find_solib_trampoline_target): Update.
10821         * maint.c (maintenance_info_sections)
10822         (maintenance_translate_address, count_symtabs_and_blocks):
10823         Update.
10824         * main.c (captured_main_1): Update.
10825         * linux-thread-db.c (try_thread_db_load_from_pdir)
10826         (has_libpthread): Update.
10827         * linespec.c (iterate_over_all_matching_symtabs)
10828         (search_minsyms_for_name): Update.
10829         * jit.c (jit_find_objf_with_entry_addr): Update.
10830         * hppa-tdep.c (find_unwind_entry)
10831         (hppa_lookup_stub_minimal_symbol): Update.
10832         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10833         Update.
10834         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10835         (elf_gnu_ifunc_resolve_by_got): Update.
10836         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10837         * dwarf-index-write.c (save_gdb_index_command): Update.
10838         * cp-support.c (add_symbol_overload_list_qualified): Update.
10839         * breakpoint.c (create_overlay_event_breakpoint)
10840         (create_longjmp_master_breakpoint)
10841         (create_std_terminate_master_breakpoint)
10842         (create_exception_master_breakpoint): Update.
10843         * blockframe.c (find_pc_partial_function): Update.
10844         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10845         (ada_collect_symbol_completion_matches)
10846         (ada_add_global_exceptions): Update.
10847
10848 2019-01-17  Tom Tromey  <tom@tromey.com>
10849
10850         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10851         declare VEC.
10852         (solib_target_parse_libraries): Change return type.
10853         (library_list_start_segment, library_list_start_section)
10854         (library_list_end_library, library_list_start_library); Update.
10855         (solib_target_free_library_list): Remove.
10856         (solib_target_parse_libraries): Remove cleanup.  Change return
10857         type.
10858         (solib_target_current_sos): Update.
10859
10860 2019-01-17  Tom Tromey  <tromey@bapiya>
10861
10862         * valprint.c: Replace "the the" with "the".
10863         * symtab.c: Replace "the the" with "the".
10864         * solib.c: Replace "the the" with "the".
10865         * solib-dsbt.c: Replace "the the" with "the".
10866         * linespec.c: Replace "the the" with "the".
10867         * dwarf2loc.h: Replace "the the" with "the".
10868         * amd64-windows-tdep.c: Replace "the the" with "the".
10869         * aarch64-tdep.c: Replace "the the" with "the".
10870
10871 2019-01-16  Keith Seitz  <keiths@redhat.com>
10872
10873         PR gdb/23773
10874         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10875         <builder>: Rename to ..
10876         <m_builder>: ... this and make private.
10877         (dwarf2_cu::get_builder): New method.  Change all users of
10878         `builder' to use this method.
10879         (dwarf2_start_symtab): Move to ...
10880         (dwarf2_cu::start_symtab): ... here.  Update all callers
10881         (setup_type_unit_groups): Move to ...
10882         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10883         callers.
10884         (dwarf2_cu::reset_builder): New method.
10885         (process_full_compunit, process_full_type_unit): Use
10886         dwarf2_cu::reset_builder.
10887         (follow_die_offset): Record the ancestor CU if it is different
10888         from the followed DIE's CU.
10889         (follow_die_sig_1): Likewise.
10890
10891 2019-01-15  Tom Tromey  <tom@tromey.com>
10892
10893         * remote.c (class remote_state) <buf>: Now a char_vector.
10894         <buf_size>: Remove.
10895         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10896         parameter.
10897         (remote_target::getpkt_or_notif_sane_1)
10898         (remote_target::getpkt_sane)
10899         (remote_target::getpkt_or_notif_sane): Likewise.
10900         (class remote_target) <putpkt>: New overload.
10901         (remote_target::read_frame): Change type of "buf_p".  Remove
10902         sizeof_p parameter.
10903         (packet_ok): New overload.
10904         (packet_check_result): New overload.
10905         Update all uses.
10906
10907 2019-01-14  Tom Tromey  <tom@tromey.com>
10908
10909         * remote-notif.c (handle_notification, remote_notif_ack)
10910         (remote_notif_parse): Make "buf" const.
10911         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10912         const.
10913         (remote_notif_parse, remote_notif_ack, handle_notification):
10914         Likewise.
10915         * remote.c (remote_notif_stop_parse): Make "buf" const.
10916         (remote_target::remote_parse_stop_reply): Make "buf" const.
10917         (remote_notif_stop_ack): Make "buf" const.
10918
10919 2019-01-14  Tom Tromey  <tom@tromey.com>
10920
10921         * remote.c (remote_console_output): Make parameter const.
10922
10923 2019-01-14  Tom Tromey  <tom@tromey.com>
10924
10925         * target-debug.h (target_debug_print_signals): Constify.
10926         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10927         * procfs.c (procfs_target::pass_signals): Update.
10928         * linux-nat.c (linux_nat_target::pass_signals): Update.
10929         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10930         * target-delegates.c: Rebuild.
10931         * remote.c (remote_target::program_signals): Update.
10932         (remote_target::pass_signals): Update.
10933         * target.c (target_pass_signals): Constify argument.
10934         (target_program_signals): Likewise.
10935         * target.h (struct target_ops) <pass_signals, program_signals>:
10936         Constify argument.
10937         (target_pass_signals, target_program_signals): Constify argument.
10938
10939 2019-01-14  Tom Tromey  <tom@tromey.com>
10940
10941         PR tui/28819:
10942         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10943
10944 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10945
10946         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10947         field.
10948         * rs6000-tdep.c: Include reggroups.h.
10949         (IS_V_ALIAS_PSEUDOREG): Define.
10950         (rs6000_register_name): Return names for the "vX" aliases.
10951         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10952         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10953         aliases.  Call default_register_reggroup_p for all other
10954         pseudo-registers.
10955         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10956         New functions.
10957         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10958         Handle "vX" aliases.
10959         (v_alias_pseudo_register_collect): New function.
10960         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10961         (rs6000_gdbarch_init): Initialize "vX" aliases as
10962         pseudo-registers.  Restore registration of
10963         rs6000_pseudo_register_reggroup_p with
10964         set_tdesc_pseudo_register_reggroup_p.
10965
10966 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10967
10968         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10969         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10970         set_gdbarch_num_pseudo_regs.
10971
10972 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10973
10974         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10975         Remove arg prefixname, add do_set and do_show.
10976         Add member functions set_list and show_list.
10977         * cli/cli-style.c (class cli_style_option): Update accordingly.
10978         (style_set_list): Move to file scope.
10979         (style_show_list): Likewise.
10980         (set_style): Call help_list.
10981         (show_style): Call cmd_show_list.
10982         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10983         Update to use the new macro.
10984
10985 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10986
10987         * ada-lang.c (_initialize_ada_language): Expand the help text
10988         for the "catch exception" command.
10989
10990 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10991
10992         * symtab.c (matching_obj_sections): Initialize obj,
10993         declare it closer to its usage.
10994
10995 2019-01-10  Tom Tromey  <tom@tromey.com>
10996
10997         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10998         (basic_inf_threads_range): Remove.
10999         (inf_threads_range, inf_non_exited_threads_range)
11000         (safe_inf_threads_range): Use next_adapter.
11001
11002 2019-01-10  Keith Seitz  <keiths@redhat.com>
11003
11004         PR gdb/23712
11005         PR symtab/23010
11006         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11007         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11008
11009 2019-01-10  Keith Seitz  <keiths@redhat.com>
11010
11011         PR gdb/23712
11012         PR symtab/23010
11013         * dictionary.c (pending_to_vector): Remove.
11014         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11015         Remove _1 suffix, replacing functions of the same name.  Update
11016         all callers.
11017         (dict_create_hashed, dict_create_hashed_expandable)
11018         (dict_create_linear, dict_create_linear_expandable, dict_free)
11019         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11020         Make functions static.
11021
11022 2019-01-10  Keith Seitz  <keiths@redhat.com>
11023
11024         PR gdb/23712
11025         PR symtab/23010
11026         * dictionary.h (struct dictionary): Replace declaration with
11027         multidictionary.
11028         (dict_create_hashed, dict_create_hashed_expandable)
11029         (dict_create_linear, dict_create_linear_expandable)
11030         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11031         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11032         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11033         taking multidictionary argument.
11034         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11035         * block.h (struct block) <dict>: Change to multidictionary
11036         and rename `multidict'.
11037         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11038         symmisc.c: Update all dictionary references to multidictionary.
11039
11040 2019-01-10  Keith Seitz  <keiths@redhat.com>
11041
11042         PR gdb/23712
11043         PR symtab/23010
11044         * dictionary.c: Include unordered_map.
11045         (pending_to_vector): New function.
11046         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11047         Rewrite the non-"_1" functions to take vector instead
11048         of linked list.
11049         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11050         "new" _1 versions of the same name.
11051         (multidictionary): Define.
11052         (std::hash<enum language): New definition.
11053         (collate_pending_symbols_by_language, mdict_create_hashed)
11054         (mdict_create_hashed_expandable, mdict_create_linear)
11055         (mdict_create_linear_expandable, mdict_free)
11056         (find_language_dictionary, create_new_language_dictionary)
11057         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11058         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11059         (mdict_size, mdict_empty): New functions.
11060         * dictionary.h (mdict_iterator): Define.
11061
11062 2019-01-10  Pedro Alves  <palves@redhat.com>
11063
11064         * breakpoint.c (read_uploaded_action)
11065         (create_tracepoint_from_upload): Adjust to use
11066         gdb::unique_xmalloc_ptr.
11067         * ctf.c (ctf_write_uploaded_tp):
11068         (SET_ARRAY_FIELD): Use emplace_back.
11069         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11070         * tracefile-tfile.c (tfile_write_uploaded_tp):
11071         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11072         gdb::unique_xmalloc_ptr.
11073         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11074         at_string, cond_string, cmd_strings>: Replace char pointers
11075         with gdb::unique_xmalloc_ptr.
11076
11077 2019-01-10  Pedro Alves  <palves@redhat.com>
11078
11079         * solib-target.c (library_list_start_library): Don't xstrdup name.
11080
11081 2019-01-10  Pedro Alves  <palves@redhat.com>
11082
11083         * mdebugread.c (parse_partial_symbols): Use
11084         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11085
11086 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11087
11088         * linux-fork.c (scoped_switch_fork_info)
11089         <~scoped_switch_fork_info>: Fix incorrect variable name.
11090
11091 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11092
11093         * linux-fork.c (scoped_switch_fork_info)
11094         <scoped_switch_fork_info>: Make explicit.
11095         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11096
11097 2019-01-10  Tom Tromey  <tom@tromey.com>
11098
11099         * objfiles.h (objfile::reset_psymtabs): Update.
11100         * objfiles.c (objfile::objfile): Update.
11101         * psymtab.h (psymtab_storage::obstack): Update.
11102         (psymtab_storage::m_obstack): Use gdb::optional.
11103         (class psymtab_storage): Update comment.  Remove objfile
11104         parameter.
11105         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11106
11107 2019-01-10  Tom Tromey  <tom@tromey.com>
11108
11109         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11110         <free_psymtabs>: Now private.
11111         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11112         (allocate_psymtab): Use new method.
11113
11114 2019-01-10  Tom Tromey  <tom@tromey.com>
11115
11116         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11117         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11118         * mdebugread.c (parse_partial_symbols): Use
11119         allocate_dependencies.
11120         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11121         allocate_dependencies.
11122         (process_psymtab_comp_unit_reader)
11123         (build_type_psymtab_dependencies): Likewise.
11124         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11125
11126 2019-01-10  Tom Tromey  <tom@tromey.com>
11127
11128         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11129         PSYMBOL_SET_LANGUAGE.
11130         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11131
11132 2019-01-10  Tom Tromey  <tom@tromey.com>
11133
11134         * psymtab.h (psymtab_storage::obstack): New method.
11135         <m_obstack>: Rename from obstack; now private.
11136         * psymtab.c (psymtab_storage): Update.
11137         * dwarf2read.c (create_addrmap_from_index)
11138         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11139         Update.
11140
11141 2019-01-10  Tom Tromey  <tom@tromey.com>
11142
11143         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11144         * objfiles.h (objfile::reset_psymtabs): New method.
11145
11146 2019-01-10  Tom Tromey  <tom@tromey.com>
11147
11148         * symmisc.c (print_symbol_bcache_statistics): Update.
11149         (print_objfile_statistics): Update.
11150         * symfile.c (reread_symbols): Update.
11151         * psymtab.h (class psymtab_storage): New.
11152         * psymtab.c (psymtab_storage): New constructor.
11153         (~psymtab_storage): New destructor.
11154         (require_partial_symbols): Update.
11155         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11156         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11157         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11158         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11159         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11160         (start_psymtab_common, end_psymtab_common)
11161         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11162         (allocate_psymtab): Update.
11163         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11164         Update.
11165         (dump_psymtab_addrmap, maintenance_print_psymbols)
11166         (maintenance_check_psymtabs): Update.
11167         (class objfile_psymtabs): Move to objfiles.h.
11168         * psympriv.h (discard_psymtab): Now inline.
11169         (psymtab_discarder::psymtab_discarder): Update.
11170         (psymtab_discarder::~psymtab_discarder): Update.
11171         (ALL_OBJFILE_PSYMTABS): Rewrite.
11172         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11173         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11174         Remove fields.
11175         <partial_symtabs>: New field.
11176         (class objfile_psymtabs): Move from psymtab.h.  Update.
11177         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11178         psymbol_cache.
11179         (objfile::~objfile): Don't destroy psymbol_cache.
11180         * mdebugread.c (parse_partial_symbols): Update.
11181         * dwarf2read.c (create_addrmap_from_index)
11182         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11183         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11184         (add_partial_subprogram, dwarf2_ranges_read): Update.
11185         * dwarf-index-write.c (write_address_map)
11186         (write_one_signatured_type, recursively_write_psymbols)
11187         (class debug_names, class debug_names, write_psymtabs_to_index):
11188         Update.
11189
11190 2019-01-10  Tom Tromey  <tom@tromey.com>
11191
11192         * symtab.h (SYMBOL_SET_NAMES): Update.
11193         (symbol_set_names): Update.
11194         (MSYMBOL_SET_NAMES): Update.
11195         * symtab.c (symbol_set_names): Change argument to be an
11196         objfile_per_bfd_storage.
11197         * psymtab.c (add_psymbol_to_bcache): Update.
11198         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11199
11200 2019-01-10  Tom Tromey  <tom@tromey.com>
11201
11202         * symtab.c (create_demangled_names_hash): Change argument to be an
11203         objfile_per_bfd_storage.
11204         (symbol_set_names): Update.
11205
11206 2019-01-10  Tom Tromey  <tom@tromey.com>
11207
11208         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11209         init_psymbol_list.
11210         * psymtab.c (init_psymbol_list): Do nothing if already called.
11211         * psympriv.h (init_psymbol_list): Add comment.
11212         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11213         init_psymbol_list.
11214         * dbxread.c (dbx_symfile_read): Unconditionally call
11215         init_psymbol_list.
11216
11217 2019-01-10  Tom Tromey  <tom@tromey.com>
11218
11219         * xcoffread.c (scan_xcoff_symtab): Update.
11220         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11221         "where".
11222         * mdebugread.c (parse_partial_symbols)
11223         (handle_psymbol_enumerators): Update.
11224         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11225         * dbxread.c (read_dbx_symtab): Update.
11226         * psympriv.h (psymbol_placement): New enum.
11227         (add_psymbol_to_list): Update.
11228
11229 2019-01-10  Tom Tromey  <tom@tromey.com>
11230
11231         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11232         static_psymbols parameters.
11233         (scan_xcoff_symtab): Update.
11234         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11235         static_psymbols parameters.
11236         * psympriv.h (start_psymtab_common): Update.
11237         * mdebugread.c (parse_partial_symbols): Update.
11238         * dwarf2read.c (create_partial_symtab): Update.
11239         * dbxread.c (read_dbx_symtab): Update.
11240         (start_psymtab): Remove global_psymbols and static_psymbols
11241         parameters.
11242
11243 2019-01-10  Tom Tromey  <tom@tromey.com>
11244
11245         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11246         * psymtab.c (allocate_psymtab): Add comment.
11247         * psympriv.h (allocate_psymtab): Add comment.
11248         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11249         initializations.
11250         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11251
11252 2019-01-10  Tom Tromey  <tom@tromey.com>
11253
11254         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11255         Don't declare.
11256         * mipsread.c: Include mdebugread.h.
11257         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11258         Declare.
11259         * elfread.c: Include mdebugread.h.
11260
11261 2019-01-09  Tom Tromey  <tom@tromey.com>
11262
11263         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11264         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11265         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11266         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11267         (psym_lookup_symbol, psym_find_last_source_symtab)
11268         (psym_forget_cached_source_info, psym_print_stats)
11269         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11270         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11271         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11272         (psym_find_compunit_symtab_by_address)
11273         (maintenance_print_psymbols, maintenance_info_psymtabs)
11274         (maintenance_check_psymtabs): Use ranged for.
11275         * psymtab.h (class objfile_psymtabs): New.
11276         (require_partial_symbols): Return objfile_psymtabs.
11277         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11278
11279 2019-01-09  Tom Tromey  <tom@tromey.com>
11280
11281         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11282         (find_pc_mapped_section, list_overlays_command)
11283         (map_overlay_command, unmap_overlay_command)
11284         (simple_overlay_update): Use all_objfiles.
11285         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11286         * printcmd.c (info_symbol_command): Use all_objfiles.
11287         * objfiles.h (ALL_OBJSECTIONS): Remove.
11288         * maint.c (maintenance_translate_address): Use all_objfiles.
11289         * gcore.c (gcore_create_callback): Use all_objfiles.
11290         (objfile_find_memory_regions): Likewise.
11291
11292 2019-01-09  Tom Tromey  <tom@tromey.com>
11293
11294         * symtab.c (find_line_symtab, info_sources_command)
11295         (make_source_files_completion_list): Use objfile_compunits.
11296         * source.c (select_source_symtab): Use objfile_compunits.
11297         * objfiles.h (struct objfile): Update comment.
11298         (ALL_OBJFILES): Remove.
11299         (ALL_FILETABS): Remove.
11300         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11301         objfile_compunits.
11302
11303 2019-01-09  Tom Tromey  <tom@tromey.com>
11304
11305         * symmisc.c (print_objfile_statistics, dump_objfile)
11306         (maintenance_print_symbols): Use compunit_filetabs.
11307         * source.c (forget_cached_source_info_for_objfile): Use
11308         compunit_filetabs.
11309         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11310         (ALL_FILETABS): Use compunit_filetabs.
11311         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11312         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11313
11314 2019-01-09  Tom Tromey  <tom@tromey.com>
11315
11316         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11317         (compunit_filetabs): New.
11318         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11319         compunit_filetabs.
11320         (info_sources_command, make_source_files_completion_list): Remove
11321         declaration.
11322         * symmisc.c (print_objfile_statistics, dump_objfile)
11323         (maintenance_print_symbols): Remove declaration.
11324         (maintenance_info_symtabs): Use compunit_filetabs.
11325         (maintenance_info_line_tables): Likewise.
11326         * source.c (select_source_symtab): Change local variable name.
11327         (forget_cached_source_info_for_objfile): Remove declaration.
11328         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11329         * objfiles.c (objfile_relocate1): Remove declaration.
11330         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11331         declaration.
11332         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11333         * coffread.c (coff_symtab_read): Remove declaration.
11334         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11335         compunit_filetabs.
11336
11337 2019-01-09  Tom Tromey  <tom@tromey.com>
11338
11339         * symtab.c (lookup_objfile_from_block)
11340         (find_pc_sect_compunit_symtab, search_symbols)
11341         (default_collect_symbol_completion_matches_break_on): Use
11342         objfile_compunits.
11343         * objfiles.h (ALL_COMPUNITS): Remove.
11344         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11345         * cp-support.c (add_symbol_overload_list_qualified): Use
11346         objfile_compunits.
11347         * ada-lang.c (ada_collect_symbol_completion_matches)
11348         (ada_add_global_exceptions): Use objfile_compunits.
11349
11350 2019-01-09  Tom Tromey  <tom@tromey.com>
11351
11352         * source.c (select_source_symtab)
11353         (forget_cached_source_info_for_objfile): Remove declaration.
11354         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11355         declaration.
11356         * maint.c (count_symtabs_and_blocks): Remove declaration.
11357         * cp-support.c (add_symbol_overload_list_qualified): Remove
11358         declaration.
11359         * coffread.c (coff_symtab_read): Remove declaration.
11360         * symtab.c (lookup_symbol_in_objfile_symtabs)
11361         (basic_lookup_transparent_type_1): Use objfile_compunits.
11362         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11363         (info_sources_command, search_symbols)
11364         (default_collect_symbol_completion_matches_break_on)
11365         (make_source_files_completion_list): Remove declaration.
11366         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11367         (ada_collect_symbol_completion_matches)
11368         (ada_add_global_exceptions): Remove declaration.
11369         * linespec.c (iterate_over_all_matching_symtabs): Use
11370         objfile_compunits.
11371         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11372         (class objfile_compunits): New.
11373         (ALL_COMPUNITS): Use objfile_compunits.
11374         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11375         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11376         objfile_compunits.
11377         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11378
11379 2019-01-09  Tom Tromey  <tom@tromey.com>
11380
11381         * symtab.c (search_symbols)
11382         (default_collect_symbol_completion_matches_break_on): Use
11383         objfile_msymbols.
11384         * ada-lang.c (ada_lookup_simple_minsym)
11385         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11386         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11387         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11388         objfile_msymbols.
11389         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11390         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11391         * objc-lang.c (find_methods): Use objfile_msymbols.
11392         (info_selectors_command, info_classes_command): Likewise.
11393         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11394         * objfiles.h (class objfile_msymbols): New.
11395         (ALL_OBJFILE_MSYMBOLS): Remove.
11396         (ALL_MSYMBOLS): Remove.
11397
11398 2019-01-09  Tom Tromey  <tom@tromey.com>
11399
11400         * common/next-iterator.h (next_adapter): Add Iterator template
11401         parameter.
11402         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11403         (class all_objfiles_safe): New.
11404         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11405         * objfiles.c (put_objfile_before): Update comment.
11406         (add_separate_debug_objfile): Likewise.
11407         (free_all_objfiles): Use all_objfiles_safe.
11408         (objfile_purge_solibs): Likewise.
11409
11410 2019-01-09  Tom Tromey  <tom@tromey.com>
11411
11412         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11413         (expand_symtab_containing_pc, lookup_static_symbol)
11414         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11415         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11416         all_objfiles.
11417         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11418         * breakpoint.c (create_overlay_event_breakpoint)
11419         (create_longjmp_master_breakpoint)
11420         (create_std_terminate_master_breakpoint)
11421         (create_exception_master_breakpoint): Use all_objfiles.
11422         * linux-thread-db.c (try_thread_db_load_from_pdir)
11423         (has_libpthread): Use all_objfiles.
11424         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11425         * linespec.c (iterate_over_all_matching_symtabs)
11426         (search_minsyms_for_name): Use all_objfiles.
11427         * maint.c (maintenance_info_sections): Use all_objfiles.
11428         * main.c (captured_main_1): Use all_objfiles.
11429         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11430         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11431         * guile/scm-pretty-print.c
11432         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11433         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11434         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11435         (maintenance_print_msymbols): Use all_objfiles.
11436         * source.c (select_source_symtab): Use all_objfiles.
11437         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11438         * symfile.c (remove_symbol_file_command)
11439         (expand_symtabs_matching, map_symbol_filenames): Use
11440         all_objfiles.
11441         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11442         all_objfiles.
11443         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11444         * objc-lang.c (find_methods): Use all_objfiles.
11445         * objfiles.c (have_partial_symbols, have_full_symbols)
11446         (have_minimal_symbols, qsort_cmp)
11447         (default_iterate_over_objfiles_in_search_order): Use
11448         all_objfiles.
11449         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11450         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11451         (maintenance_check_psymtabs): Use all_objfiles.
11452         (ALL_PSYMTABS): Remove.
11453         * compile/compile-object-run.c (do_module_cleanup): Use
11454         all_objfiles.
11455         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11456         * cp-support.c (add_symbol_overload_list_qualified): Use
11457         all_objfiles.
11458         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11459         Use all_objfiles.
11460         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11461         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11462         all_objfiles.
11463         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11464         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11465         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11466         Uses all_objfiles.
11467         * solib.c (solib_read_symbols): Use all_objfiles
11468
11469 2019-01-09  Tom Tromey  <tom@tromey.com>
11470
11471         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11472         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11473         all_objfiles.
11474         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11475         * symmisc.c (print_symbol_bcache_statistics)
11476         (print_objfile_statistics, maintenance_print_objfiles)
11477         (maintenance_info_symtabs, maintenance_check_symtabs)
11478         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11479         all_objfiles.
11480         * source.c (forget_cached_source_info): Use all_objfiles.
11481         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11482         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11483         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11484         * objfiles.c (update_section_map): Use all_objfiles.
11485         (shared_objfile_contains_address_p): Likewise.
11486         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11487         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11488
11489 2019-01-09  Tom Tromey  <tom@tromey.com>
11490
11491         * common/next-iterator.h: New file.
11492         * objfiles.h (class all_objfiles): New.
11493         (struct objfile_iterator): New.
11494
11495 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11496
11497         * NEWS: Move the description of the changed "frame", "select-frame",
11498          and "info frame" commands to the Changed commands section.
11499
11500 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11501
11502         * gdbtypes.c (check_stub_method_group): Remove handling of old
11503         mangling schemes.
11504         * linespec.c (find_methods): Likewise.
11505         * stabsread.c (read_member_functions): Likewise.
11506         * valops.c (search_struct_method): Likewise.
11507         (value_struct_elt_for_reference): Likewise.
11508         * NEWS: Mention this change.
11509
11510 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11511
11512         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11513         print_source_lines.
11514         * source.c (print_source_lines_base): Update line number check.
11515         (print_source_lines): New function.
11516         (source_lines_range::source_lines_range): New function.
11517         * source.h (class source_lines_range): New class.
11518         (print_source_lines): New declaration.
11519
11520 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11521
11522         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11523
11524 2019-01-08  Tom Tromey  <tom@tromey.com>
11525             Simon Marchi  <simon.marchi@ericsson.com>
11526
11527         PR gdb/24060
11528         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11529         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11530         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11531         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11532         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11533         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11534
11535 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11536
11537         * source.c (select_source_symtab): Move header comment to
11538         declaration in source.h.
11539         (forget_cached_source_info_for_objfile): Likewise.
11540         (forget_cached_source_info): Likewise.
11541         (identify_source_line): Likewise.
11542         * source.h (identify_source_line): Move declaration from symtab.h
11543         and add comment from source.c
11544         (print_source_lines): Likewise.
11545         (forget_cached_source_info_for_objfile): Likewise.
11546         (forget_cached_source_info): Likewise.
11547         (select_source_symtab): Likewise.
11548         (enum print_source_lines_flag): Move definition from symtab.h.
11549         * symtab.h (identify_source_line): Move declaration to source.h.
11550         (print_source_lines): Likewise.
11551         (forget_cached_source_info_for_objfile): Likewise.
11552         (forget_cached_source_info): Likewise.
11553         (select_source_symtab): Likewise.
11554         (enum print_source_lines_flag): Move definition to source.h.
11555         * tui/tui-hooks.c: Add 'source.h' include.
11556
11557 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11558
11559         * source.c (print_source_lines_base): Handle requests to print
11560         reverse line number sequences, and guard against empty lines
11561         string.
11562
11563 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11564
11565         * source.c (print_source_lines_base): Fix skip of '\r' if next
11566         character is '\n'.
11567
11568 2019-01-06  Tom Tromey  <tom@tromey.com>
11569
11570         * c-exp.y (struct c_parse_state) <macro_original_text,
11571         expansion_obstack>: New member.
11572         (macro_original_text, expansion_obstack): Remove globals.
11573         (scan_macro_expansion, scanning_macro_expansion)
11574         (finished_macro_expansion): Update.
11575         (scan_macro_cleanup): Remove.
11576         (yylex, c_parse): Update.
11577
11578 2019-01-06  Tom Tromey  <tom@tromey.com>
11579
11580         * c-exp.y (struct c_parse_state) <strings>: New member.
11581         (operator_stoken): Update.
11582
11583 2019-01-06  Tom Tromey  <tom@tromey.com>
11584
11585         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11586         (union type_stack_elt) <typelist_val>: Now a pointer to
11587         std::vector.
11588         (type_stack_cleanup): Don't declare.
11589         (push_typelist): Update.
11590         * parse.c (pop_typelist): Return a std::vector.
11591         (push_typelist): Take a std::vector.
11592         (follow_types): Update.  Do not free args.
11593         (type_stack_cleanup): Remove.
11594         * c-exp.y (struct c_parse_state): New.
11595         (cpstate): New global.
11596         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11597         (nonempty_typelist): Update.
11598         (func_mod): Create a new vector.
11599         (c_parse): Create a c_parse_state.
11600         (check_parameter_typelist): Do not delete params.
11601         (function_method): Update.  Do not delete type_list.
11602
11603 2019-01-06  Tom Tromey  <tom@tromey.com>
11604
11605         PR gdb/28155:
11606         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11607         check_typedef.
11608         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11609         (print_return_value): Likewise.
11610
11611 2019-01-05  Tom Tromey  <tom@tromey.com>
11612
11613         * contrib/cleanup_check.py: Remove.
11614         * contrib/gcc-with-excheck: Remove.
11615         * contrib/exsummary.py: Remove.
11616         * contrib/excheck.py: Remove.
11617
11618 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11619
11620         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11621         NULL. Initialize tpprev to NULL instead of assigning it
11622         to NULL on the next statement.
11623         * windows-nat.c (windows_delete_thread): Remove check for
11624         main_thread_id before printing thread exit notifications.
11625         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11626         Remove thread ID check against main_thread_id.
11627         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11628         windows_delete_thread.
11629         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11630
11631 2019-01-04  Tom Tromey  <tom@tromey.com>
11632
11633         * compile/compile.c (_initialize_compile): Use upper case for
11634         metasyntactic variables.
11635         * symmisc.c (_initialize_symmisc): Use upper case for
11636         metasyntactic variables.
11637         * psymtab.c (_initialize_psymtab): Use upper case for
11638         metasyntactic variables.
11639         * demangle.c (demangle_command): Use upper case for metasyntactic
11640         variables.
11641         (_initialize_demangler): Likewise.
11642         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11643         variables.
11644
11645 2019-01-03  Tom Tromey  <tom@tromey.com>
11646
11647         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11648
11649 2019-01-03  Tom Tromey  <tom@tromey.com>
11650
11651         * python/py-symtab.c (salpy_str): Update.
11652         (struct salpy_sal_object) <symtab>: Now a PyObject.
11653         (salpy_dealloc): Update.
11654         (del_objfile_sal): Use gdbpy_ref.
11655
11656 2019-01-03  Tom Tromey  <tom@tromey.com>
11657
11658         * python/py-type.c (convert_field): Use new_reference.  Return
11659         gdbpy_ref.
11660         (make_fielditem): Return gdbpy_ref.
11661         (typy_fields): Update.
11662         (typy_getitem): Update.
11663         (field_name): Return gdbpy_ref.  Use new_reference.
11664         (typy_iterator_iternext): Update.
11665
11666 2019-01-03  Tom Tromey  <tom@tromey.com>
11667
11668         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11669
11670 2019-01-03  Tom Tromey  <tom@tromey.com>
11671
11672         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11673         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11674         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11675         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11676         (pspy_set_type_printers): Likewise.
11677         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11678         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11679         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11680         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11681         (objfpy_set_type_printers): Likewise.
11682
11683 2019-01-03  Tom Tromey  <tom@tromey.com>
11684
11685         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11686         (gdbpy_print_stack): Use gdbpy_err_fetch.
11687         * python/python-internal.h (class gdbpy_err_fetch): New class.
11688         (class gdbpy_enter) <m_error_type, m_error_value,
11689         m_error_traceback>: Remove.
11690         <m_error>: New member.
11691         (gdbpy_exception_to_string): Don't declare.
11692         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11693         * python/py-value.c (convert_value_from_python): Use
11694         gdbpy_err_fetch.
11695         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11696         gdbpy_exception_to_string.
11697         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11698         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11699         gdbpy_err_fetch.
11700
11701 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11702
11703         * linux-nat.c (delete_lwp_cleanup): Delete.
11704         (struct lwp_deleter): New struct.
11705         (lwp_info_up): New typedef.
11706         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11707         lwp_info_up.
11708
11709 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11710
11711         * linux-fork.c (class scoped_switch_fork_info): New class.
11712         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11713
11714 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11715
11716         * valops.c (find_overload_match): Remove use of null_cleanup, and
11717         calls to do_cleanups.
11718
11719 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11720
11721         * compile/compile-cplus-types.c
11722         (compile_cplus_instance::decl_name): Handle changes to
11723         cp_func_name.
11724         * cp-support.c (cp_func_name): Update header comment, update
11725         return type.
11726         * cp-support.h (cp_func_name): Update return type in declaration.
11727         * valops.c (find_overload_match): Move temp_func local to top
11728         level of function and change its type.  Use temp_func to hold and
11729         delete temporary string obtained from cp_func_name.
11730
11731 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11732
11733         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11734         gdb::char_vector, remove cleanup, and update uses of `msg`.
11735
11736 2019-01-03  Jim Wilson  <jimw@sifive.com>
11737
11738         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11739
11740 2019-01-02  Tom Tromey  <tom@tromey.com>
11741
11742         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11743         (tdesc_parse_xml): Remove cleanups.
11744         * target-descriptions.h (make_cleanup_free_target_description):
11745         Don't declare.
11746         (target_desc_deleter): New struct.
11747         (target_desc_up): New typedef.
11748         * target-descriptions.c (target_desc_deleter::operator()): Rename
11749         from free_target_description.
11750         (make_cleanup_free_target_description): Remove.
11751
11752 2019-01-02  Tom Tromey  <tom@tromey.com>
11753
11754         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11755         constructor, destructor.
11756         (linespec_parser): Remove typedef.
11757         (~linespec_parser): Rename from linespec_parser_delete.
11758         (linespec_lex_to_end, linespec_complete_label)
11759         (linespec_complete): Update.
11760         (decode_line_full): Remove cleanups.
11761         (decode_line_1): Update.
11762
11763 2019-01-02  Tom Tromey  <tom@tromey.com>
11764
11765         * python/python-internal.h (inferior_to_inferior_object): Change
11766         return type.
11767         * python/py-exitedevent.c (create_exited_event_object): Update.
11768         * python/py-inferior.c (inferior_to_inferior_object): Return
11769         gdbpy_ref.
11770         (python_new_inferior, python_inferior_deleted)
11771         (thread_to_thread_object, delete_thread_object)
11772         (build_inferior_list, gdbpy_selected_inferior): Update.
11773         * python/py-infthread.c (create_thread_object): Update.  Also fail
11774         if inferior_to_inferior_object fails.
11775
11776 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11777
11778         * inferior.h (class inferior) <displaced_step_state>: New field.
11779         * infrun.h (struct displaced_step_state): Move here from
11780         infrun.c.  Initialize fields, add constructor.
11781         <inf>: Remove field.
11782         <reset>: New method.
11783         * infrun.c (struct displaced_step_inferior_state): Move to
11784         infrun.h.
11785         (displaced_step_inferior_states): Remove.
11786         (get_displaced_stepping_state): Adust.
11787         (displaced_step_in_progress_any_inferior): Adjust.
11788         (displaced_step_in_progress_thread): Adjust.
11789         (displaced_step_in_progress): Adjust.
11790         (add_displaced_stepping_state): Remove.
11791         (get_displaced_step_closure_by_addr): Adjust.
11792         (remove_displaced_stepping_state): Remove.
11793         (infrun_inferior_exit): Call displaced_step_state.reset.
11794         (use_displaced_stepping): Don't check for NULL.
11795         (displaced_step_prepare_throw): Call
11796         get_displaced_stepping_state.
11797         (displaced_step_fixup): Don't check for NULL.
11798         (prepare_for_detach): Don't check for NULL.
11799
11800 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11801
11802         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11803          in case of call that did not complete.
11804
11805 2019-01-02  Andrey Utkin  <autkin@undo.io>
11806
11807         * symfile.c (find_separate_debug_file): Fix search of debug files for
11808         remote debuggee.
11809
11810 2019-01-02  Tom Tromey  <tom@tromey.com>
11811
11812         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11813         indentation.
11814         * python/py-frame.c (frapy_older): Remove cast.
11815         (frapy_newer): Likewise.
11816         * python/py-breakpoint.c (local_setattro): Remove cast.
11817         * python/py-arch.c (archpy_name): Remove local variable.
11818         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11819
11820 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11821
11822         * unittests/basic_string_view/element_access/char/empty.cc:
11823         Fix year range in copyright header.
11824
11825 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11826
11827         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11828         Delete.
11829         <operator==>: Update with for removed field.
11830         <hash>: Likewise.
11831         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11832         <isa_features>: ...this.
11833         <abi_features>: New field.
11834         (riscv_isa_flen): Update comment.
11835         (riscv_abi_xlen): New declaration.
11836         (riscv_abi_flen): New declaration.
11837         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11838         isa_features.
11839         (riscv_abi_xlen): New function.
11840         (riscv_isa_flen): Update to get answer from isa_features.
11841         (riscv_abi_flen): New function.
11842         (riscv_has_fp_abi): Update to get answer from abi_features.
11843         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11844         xlen and flen.
11845         (riscv_call_info) <xlen, flen>: Update comment.
11846         (riscv_call_arg_struct): Remove invalid assertions
11847         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11848         is removed.
11849         (riscv_gdbarch_init): Gather isa features and abi features
11850         separately, ensure both match on the gdbarch when reusing an old
11851         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11852         a target with 64-bit float hardware.
11853
11854 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11855
11856         * source.c (search_command_helper): Stop reverse search
11857         when line 1 has been searched.
11858
11859 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11860
11861         * record-full.c (record_full_base_target::close): Rewrite
11862         record_full_core_buf_list free logic.
11863
11864 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11865
11866         * break-catch-syscall.c (print_one_catch_syscall): xfree
11867         the last text.
11868
11869 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11870
11871         * top.c (print_gdb_version): Update Copyright year in version
11872         message.
11873
11874 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11875
11876         Update copyright year range in all GDB files.
11877
11878 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11879
11880         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11881
11882 For older changes see ChangeLog-2018.
11883 \f
11884 Local Variables:
11885 mode: change-log
11886 left-margin: 8
11887 fill-column: 74
11888 version-control: never
11889 coding: utf-8
11890 End:
11891