gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * auto-load.c (struct auto_load_pspace_info): Add destructor and
   4         initializers.
   5         <unsupported_script_warning_printed,
   6         script_not_found_warning_printed>: Now bool.
   7         (auto_load_pspace_data): Change type.
   8         (~auto_load_pspace_info): Rename from
   9         auto_load_pspace_data_cleanup.
  10         (get_auto_load_pspace_data, init_loaded_scripts_info)
  11         (clear_section_scripts, maybe_print_unsupported_script_warning)
  12         (maybe_print_script_not_found_warning, _initialize_auto_load):
  13         Update.
  14
  15 2019-05-08  Tom Tromey  <tom@tromey.com>
  16
  17         * objfiles.c (objfile_pspace_info): Add destructor and
  18         initializers.
  19         (objfiles_pspace_data): Change type.
  20         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
  21         (get_objfile_pspace_data): Update.
  22         (objfiles_bfd_data): Change type.
  23         (get_objfile_bfd_data): Update.
  24         (objfile_bfd_data_free, _initialize_objfiles): Remove.
  25
  26 2019-05-08  Tom Tromey  <tom@tromey.com>
  27
  28         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
  29         Change type.
  30         (get_catch_syscall_inferior_data): Update.
  31         (catch_syscall_inferior_data_cleanup): Remove.
  32         (_initialize_break_catch_syscall): Update.
  33
  34 2019-05-08  Tom Tromey  <tom@tromey.com>
  35
  36         * inflow.c (struct terminal_info): Add destructor and
  37         initializers.
  38         (inflow_inferior_data): Change type.
  39         (~terminal_info): Rename from inflow_inferior_data_cleanup.
  40         (get_inflow_inferior_data, inflow_inferior_exit)
  41         (swap_terminal_info, _initialize_inflow): Update.
  42
  43 2019-05-08  Tom Tromey  <tom@tromey.com>
  44
  45         * target-dcache.c (target_dcache_cleanup): Remove.
  46         (target_dcache_aspace_key): Change type.
  47         (target_dcache_init_p, target_dcache_invalidate)
  48         (target_dcache_get, target_dcache_get_or_init)
  49         (_initialize_target_dcache): Update.
  50         * dcache.h (struct dcache_deleter): New.
  51
  52 2019-05-08  Tom Tromey  <tom@tromey.com>
  53
  54         * symtab.c (struct symbol_cache): Add destructor and
  55         initializers.
  56         (symbol_cache_key): Move.  Change type.
  57         (make_symbol_cache, free_symbol_cache): Remove.
  58         (get_symbol_cache): Update.
  59         (symbol_cache_cleanup): Remove.
  60         (ALL_PSPACES, symbol_cache_flush)
  61         (maintenance_print_symbol_cache)
  62         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
  63         Update.
  64
  65 2019-05-08  Tom Tromey  <tom@tromey.com>
  66
  67         * symtab.c (struct main_info): Add destructor and initializers.
  68         (main_progspace_key): Move.  Change type.
  69         (get_main_info): Update.
  70         (main_info_cleanup): Remove.
  71         (_initialize_symtab): Update.
  72
  73 2019-05-08  Tom Tromey  <tom@tromey.com>
  74
  75         * registry.h (DECLARE_REGISTRY): Define the _key class.
  76
  77 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
  78
  79         * NEWS: Merge two 'New commands' sections.
  80
  81 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
  82
  83         * ada-valprint.c (ada_val_print_gnat_array): Remove language
  84         parameter and use Ada language definition instead.
  85         (ada_val_print_ptr): Remove unused language parameter.
  86         (ada_val_print_num): Remove language parameter and use Ada language
  87         definition instead.
  88         (ada_val_print_enum, ada_val_print_flt): Remove unused language
  89         parameter.
  90         (ada_val_print_struct_union, ada_val_print_ref): Remove language
  91         parameter and use Ada language definition instead.
  92         (ada_val_print_1): Update all ada_val_print_xxx calls.
  93         Remove language parameter.
  94         (ada_val_print): Update ada_val_print_1 call.
  95
  96 2019-05-08  Tom Tromey  <tromey@adacore.com>
  97
  98         * remote.c (remote_hw_watchpoint_limit)
  99         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 100         Now static.
 101
 102 2019-05-08  Tom Tromey  <tromey@adacore.com>
 103
 104         * maint.c (_initialize_maint_cmds): Move initialization code to
 105         remote.c.
 106         (watchdog, show_watchdog): Move to remote.c.
 107         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 108         "watchdog" static.
 109         (_initialize_remote): Move initialization code from maint.c.
 110         * defs.h (watchdog): Don't declare.
 111
 112 2019-05-08  Tom Tromey  <tromey@adacore.com>
 113
 114         * tui/tui-interp.c: Include main.h.
 115         * interps.c: Include main.h.
 116         * main.h (interpreter_p): Declare.
 117         * defs.h (interpreter_p): Don't declare.
 118
 119 2019-05-08  Tom Tromey  <tromey@adacore.com>
 120
 121         * dwarf2loc.c: Include dwarf2read.h.
 122         * defs.h (read_unsigned_leb128): Don't declare.
 123         * dwarf2read.h (read_unsigned_leb128): Declare.
 124
 125 2019-05-08  Tom Tromey  <tromey@adacore.com>
 126
 127         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 128         method.
 129
 130 2019-05-08  Tom Tromey  <tromey@adacore.com>
 131
 132         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 133         when no wrap column is set.
 134
 135 2019-05-08  Tom Tromey  <tromey@adacore.com>
 136
 137         * c-lang.c (c_get_string): Handle non-C-style arrays.
 138
 139 2019-05-08  Tom Tromey  <tromey@adacore.com>
 140
 141         * typeprint.c (print_offset_data::update): Print the bit offset,
 142         not the number of bits remaining.
 143
 144 2019-05-08  Tom Tromey  <tromey@adacore.com>
 145
 146         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 147         padding at end of comment.
 148
 149 2019-05-08  Tom Tromey  <tromey@adacore.com>
 150
 151         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 152         Compare main types.
 153
 154 2019-05-06  Tom Tromey  <tom@tromey.com>
 155
 156         * common/scoped_mmap.c: Include common-defs.h.
 157         * common/scoped_mmap.h: Don't include config.h.
 158
 159 2019-05-04  Tom Tromey  <tom@tromey.com>
 160
 161         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 162         (struct aarch64_call_info): Add initializers.
 163         <si>: Now a std::vector.
 164         (pass_on_stack, aarch64_push_dummy_call): Update.
 165
 166 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 167             Tom Tromey  <tom@tromey.com>
 168
 169         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 170         (ppc_threads): Now a std::vector.  Now static.
 171         (hwdebug_find_thread_points_by_tid)
 172         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 173         Update.
 174
 175 2019-05-04  Tom Tromey  <tom@tromey.com>
 176
 177         * arc-tdep.c (arc_tdesc_init): Return bool.
 178
 179 2019-05-04  Tom Tromey  <tom@tromey.com>
 180
 181         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 182         Use gdb_assert_not_reached.
 183
 184 2019-05-04  Tom Tromey  <tom@tromey.com>
 185
 186         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 187         "false".
 188
 189 2019-05-04  Tom Tromey  <tom@tromey.com>
 190
 191         * arc-tdep.c (arc_tdesc_init): Use bool.
 192
 193 2019-05-04  Tom Tromey  <tom@tromey.com>
 194
 195         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 196
 197 2019-05-04  Tom Tromey  <tom@tromey.com>
 198
 199         * cli/cli-cmds.c (valid_command_p): Return bool.
 200
 201 2019-05-04  Tom Tromey  <tom@tromey.com>
 202
 203         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 204         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 205
 206 2019-05-04  Raul Tambre  <raul@tambre.ee>
 207
 208         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 209         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 210         operator for comparison.
 211
 212 2019-05-04  Tom Tromey  <tom@tromey.com>
 213
 214         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 215         (lookup_partial_symbol, print_partial_symbols)
 216         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 217         (psymbol_compare): Update.
 218         (add_psymbol_to_bcache): Clear the entire psymbol.
 219         (maintenance_check_psymtabs): Update.
 220         * psympriv.h (struct partial_symbol): Don't derive from
 221         general_symbol_info.
 222         <obj_section, unrelocated_address, address,
 223         set_unrelocated_address>: Update.
 224         <ginfo>: New member.
 225         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 226         (debug_names::write_psymbols): Update.
 227
 228 2019-05-04  Tom de Vries  <tdevries@suse.de>
 229
 230         * contrib/cc-with-tweaks.sh: Support -n arg.
 231
 232 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 233
 234         * corelow.c (core_target::detach): Ensure frame cache and
 235         register caches are cleared.
 236         inferior.c (exit_inferior_1): Likewise.
 237
 238 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 239             Tom Tromey  <tom@tromey.com>
 240
 241         * dictionary.c (collate_pending_symbols_by_language): Remove
 242         "struct" from foreach.
 243         * symtab.c (lookup_global_symbol_from_objfile)
 244         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 245         foreach.
 246         * ser-tcp.c (net_open): Remove "struct" from foreach.
 247         * objfiles.c (objfile_relocate, objfile_rebase)
 248         (objfile_has_symbols): Remove "struct" from foreach.
 249         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 250         from foreach.
 251         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 252         foreach.
 253         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 254         "struct" from foreach.
 255         * ada-lang.c (create_excep_cond_exprs)
 256         (ada_exception_catchpoint_cond_string): Remove "struct" from
 257         foreach.
 258
 259 2019-05-03  Tom Tromey  <tromey@adacore.com>
 260
 261         * ada-exp.y (convert_char_literal): Check suffix of each
 262         enumerator.
 263
 264 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 265
 266         PR ada/21406:
 267         * ada-exp.y (yywrap): Don't define.
 268         * ada-lex.l (%option): Add noyywrap
 269         (yywrap): Remove.
 270
 271 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 272
 273         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 274         _WIN32_WINNT to the XP level, unless already defined to a higher
 275         level.
 276
 277         * unittests/parse-connection-spec-selftests.c:
 278         * ser-tcp.c:
 279         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 280         override.
 281
 282         * symfile.c (find_separate_debug_file): Remove colon from the
 283         drive spec of DOS/Windows file names of the target, so that the
 284         file name produced from DEBUGDIR and the target's directory will
 285         be valid on DOS/Windows systems.
 286
 287 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 288
 289         * rust-lang.c (val_print_struct): Handle printing structures
 290         containing strings.
 291
 292 2019-05-02  Tom Tromey  <tromey@adacore.com>
 293
 294         * valarith.c (_initialize_valarith): Remove.
 295
 296 2019-05-01  Tom Tromey  <tromey@adacore.com>
 297
 298         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 299         bitfields.
 300
 301 2019-05-01  Tom Tromey  <tromey@adacore.com>
 302
 303         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 304         for big-endian copies.
 305
 306 2019-04-30  Ali Tamur  <tamur@google.com>
 307         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 308         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 309         (read_3_bytes): New function.
 310
 311 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 312
 313         * windows-nat.c (main_thread_id): Delete.
 314         (handle_output_debug_string): Replace main_thread_id by
 315         current_event.dwThreadId.
 316         (fake_create_process): Likewise.
 317         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 318         Do not set main_thread_id.
 319         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 320         current_event.dwThreadId.
 321         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 322
 323 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 324
 325         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 326         Use current_event.dwThreadId instead of main_thread_id.
 327
 328 2019-04-30  Tom Tromey  <tromey@adacore.com>
 329
 330         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 331         (create_excep_cond_exprs): Iterate over program spaces.
 332         (ada_exception_catchpoint_cond_string): Examine all minimal
 333         symbols for exception types.
 334
 335 2019-04-30  Tom Tromey  <tromey@adacore.com>
 336
 337         PR c++/24470:
 338         * dwarf2read.c (process_structure_scope): Handle case where type
 339         has template parameters but no symbol was created.
 340
 341 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 342             Chris January  <chris.january@arm.com>
 343
 344         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 345         qualifier.
 346         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 347
 348 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 349
 350         * f-typeprint.c (f_print_type): Update rules for printing
 351         whitespace.
 352         (f_type_print_varspec_suffix): Likewise.
 353
 354 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 355             Chris January  <chris.january@arm.com>
 356
 357         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 358         function arguments.
 359
 360 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 361
 362         * f-lang.c (build_fortran_types): Change name of void type to
 363         lower case.
 364         * f-typeprint.c (f_type_print_base): Print the name of the void
 365         type, rather than a fixed string.
 366         * f-valprint.c (f_decorations): Use lower case void string.
 367
 368 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 369             Chris January  <chris.january@arm.com>
 370
 371         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 372         types for Fortran.
 373
 374 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 375             Chris January  <chris.january@arm.com>
 376             David Lecomber  <david.lecomber@arm.com>
 377
 378         * f-exp.y (BINOP_INTRINSIC): New token.
 379         (exp): New parser rule handling BINOP_INTRINSIC.
 380         (f77_keywords): Add new builtin procedures.
 381         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 382         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 383         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 384         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 385         (print_unop_subexp_f): New function.
 386         (print_binop_subexp_f): New function.
 387         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 388         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 389         (dump_subexp_body_f): Likewise.
 390         (operator_check_f): Likewise.
 391         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 392         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 393
 394 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 395
 396         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 397         UNOP_KIND.
 398         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 399         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 400         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 401         (operator_length_f): New fuction.
 402         (print_subexp_f): New function.
 403         (op_name_f): New function.
 404         (dump_subexp_body_f): New function.
 405         (operator_check_f): New function.
 406         (exp_descriptor_f): Replace standard expression handling functions
 407         with new functions.
 408         * gdb/fortran-operator.def: New file.
 409         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 410         * gdb/std-operator.def: Remove UNOP_KIND.
 411
 412 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * std-operator.def: Remove unbalanced, stray double quote
 415         character.
 416
 417 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 418             Chris January  <chris.january@arm.com>
 419             Daniel Everett  <daniel.everett@arm.com>
 420             Nick Forrington  <nick.forrington@arm.com>
 421             Richard Bunt  <richard.bunt@arm.com>
 422
 423         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 424         of depth when printing anonymous structs or unions.
 425         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 426         Don't print either the top-level value, or the children if the
 427         max-depth is exceeded.
 428         (ppscm_print_children): When printing the key of a map, allow one
 429         extra level of depth.
 430         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 431         print either the top-level value, or the children if the max-depth
 432         is exceeded.
 433         (print_children): When printing the key of a map, allow one extra
 434         level of depth.
 435         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 436         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 437         (user_print_options): Initialise max_depth field.
 438         (val_print_scalar_or_string_type_p): New function.
 439         (val_print): Check to see if the max depth has been reached.
 440         (val_print_check_max_depth): Define new function.
 441         (show_print_max_depth): New function.
 442         (_initialize_valprint): Add 'print max-depth' option.
 443         * valprint.h (struct value_print_options) <max_depth>: New field.
 444         (val_print_check_max_depth): Declare new function.
 445         * NEWS: Document new feature.
 446
 447 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 448
 449         * ada-lang.c (ada_language_defn): Initialise new field.
 450         * c-lang.c (c_is_string_type_p): New function.
 451         (c_language_defn): Initialise new field.
 452         (cplus_language_defn): Initialise new field.
 453         (asm_language_defn): Initialise new field.
 454         (minimal_language_defn): Initialise new field.
 455         * c-lang.h (c_is_string_type_p): Declare new function.
 456         * d-lang.c (d_language_defn): Initialise new field.
 457         * f-lang.c (f_is_string_type_p): New function.
 458         (f_language_defn): Initialise new field.
 459         * go-lang.c (go_is_string_type_p): New function.
 460         (go_language_defn): Initialise new field.
 461         * language.c (default_is_string_type_p): New function.
 462         (unknown_language_defn): Initialise new field.
 463         (auto_language_defn): Initialise new field.
 464         * language.h (struct language_defn) <la_is_string_type_p>: New
 465         member variable.
 466         (default_is_string_type_p): Declare new function.
 467         * m2-lang.c (m2_language_defn): Initialise new field.
 468         * objc-lang.c (objc_language_defn): Initialise new field.
 469         * opencl-lang.c (opencl_language_defn): Initialise new field.
 470         * p-lang.c (pascal_is_string_type_p): New function.
 471         (pascal_language_defn): Initialise new field.
 472         * rust-lang.c (rust_is_string_type_p): New function.
 473         (rust_language_defn): Initialise new field.
 474
 475 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 476
 477         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 478         New field.
 479         * ada-lang.c (ada_language_defn): Initialise new field.
 480         * c-lang.c (c_language_defn): Likewise.
 481         (cplus_language_defn): Likewise.
 482         (asm_language_defn): Likewise.
 483         (minimal_language_defn): Likewise.
 484         * d-lang.c (d_language_defn): Likewise.
 485         * f-lang.c (f_language_defn): Likewise.
 486         * go-lang.c (go_language_defn): Likewise.
 487         * language.c (unknown_language_defn): Likewise.
 488         (auto_language_defn): Likewise.
 489         * m2-lang.c (m2_language_defn): Likewise.
 490         * objc-lang.c (objc_language_defn): Likewise.
 491         * opencl-lang.c (opencl_language_defn): Likewise.
 492         * p-lang.c (pascal_language_defn): Likewise.
 493         * rust-lang.c (rust_language_defn): Likewise.
 494
 495 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 496
 497         * ada-lang.c (ada_is_character_type): Change return type to bool.
 498         (ada_is_string_type): Likewise.
 499         * ada-lang.h (ada_is_character_type): Update declaration
 500         (ada_is_string_type): Likewise.
 501
 502 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 503
 504         Support style in 'frame|thread apply'
 505
 506         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 507         * record.c (record_start, record_stop): Update callers of
 508         execute_command_to_string with false.
 509         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 510         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 511         methods.
 512         (class string_file): New constructor with term_out parameter.
 513         Override methods term_out and can_emit_style_escape.  New member
 514         term_out.
 515         (class stdio_file): Override can_emit_style_escape.
 516         (class tee_file): Override term_out and can_emit_style_escape.
 517         * utils.h (can_emit_style_escape): Remove.
 518         * utils.c (can_emit_style_escape): Likewise.
 519         Update all callers of can_emit_style_escape (SOMESTREAM) to
 520         SOMESTREAM->can_emit_style_escape.
 521         * source-cache.c (source_cache::get_source_lines): Likewise.
 522         * stack.c (frame_apply_command_count): Call execute_command_to_string
 523         passing the term_out characteristic of the current gdb_stdout.
 524         * thread.c (thr_try_catch_cmd): Likewise.
 525         * top.c (execute_command_to_string): pass term_out parameter
 526         to construct the string_file for the command output.
 527         * ui-file.c (term_cli_styling): New function (most code moved
 528         from utils.c can_emit_style_escape).
 529         (string_file::string_file, string_file::can_emit_style_escape,
 530         stdio_file::can_emit_style_escape, tee_file::term_out,
 531         tee_file::can_emit_style_escape): New functions.
 532
 533 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 534
 535         * NEWS: Mention the new set|show may-call-functions.
 536         * infcall.c (may_call_functions_p): New variable.
 537         (show_may_call_functions_p): New function.
 538         (call_function_by_hand_dummy): Throws an error if not
 539         may-call-functions.
 540         (_initialize_infcall): Call add_setshow_boolean_cmd for
 541         may-call-functions.
 542
 543 2019-04-25  Keith Seitz  <keiths@redhat.com>
 544
 545         PR c++/24367
 546         * cp-support.c (inspect_type): Don't attempt substitutions
 547         of symbol with the same name.
 548
 549 2019-04-25  Tom Tromey  <tromey@adacore.com>
 550
 551         PR gdb/24475:
 552         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 553         static.
 554
 555 2019-04-25  Tom Tromey  <tromey@adacore.com>
 556
 557         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 558         rvalue reference.
 559         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 560         (gdb_xml_parser::parse): Use std::move.
 561         * python/python-internal.h (gdbpy_convert_exception): Take a const
 562         reference.
 563         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 564         std::move.
 565         * python/py-utils.c (gdbpy_convert_exception): Take a const
 566         reference.
 567         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 568         Use std::move.
 569         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 570         Use std::move.
 571         * mi/mi-main.c (mi_print_exception): Take a const reference.
 572         * main.c (handle_command_errors): Take a const reference.
 573         * linespec.c (parse_linespec): Use std::move.
 574         * infcall.c (run_inferior_call): Use std::move.
 575         (call_function_by_hand_dummy): Use std::move.
 576         * exec.c (try_open_exec_file): Use std::move.
 577         * exceptions.h (exception_print, exception_fprintf)
 578         (exception_print_same): Update.
 579         * exceptions.c (print_exception, exception_print)
 580         (exception_fprintf, exception_print_same): Change parameters to
 581         const reference.
 582         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 583         * common/new-op.c: Use std::move.
 584         * common/common-exceptions.h (struct gdb_exception): Add move
 585         constructor.
 586         (struct gdb_exception_error, struct gdb_exception_quit, struct
 587         gdb_quit_bad_alloc): Change constructor to move constructor.
 588         (throw_exception): Change parameter to rvalue reference.
 589         * common/common-exceptions.c (throw_exception): Take rvalue
 590         reference.
 591         * cli/cli-interp.c (safe_execute_command): Use std::move.
 592         * breakpoint.c (insert_bp_location, location_to_sals): Use
 593         std::move.
 594
 595 2019-04-25  Tom Tromey  <tromey@adacore.com>
 596
 597         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 598         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 599         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 600         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 601         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 602         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 603         guile/scm-value.c: Use unpack.
 604         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 605         gdbscm_gdb_exception.
 606         (gdbscm_throw_gdb_exception): Likewise.
 607         (struct gdbscm_gdb_exception): New.
 608         (unpack): New function.
 609         (gdbscm_wrap): Use unpack.
 610
 611 2019-04-25  Tom Tromey  <tromey@adacore.com>
 612
 613         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 614         (gdb_rl_callback_handler): Use std::move.
 615         * common/common-exceptions.h (struct gdb_exception): Add move
 616         assignment operator.
 617         (throw_exception_sjlj): Change "exception" to const reference.
 618         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 619         (throw_exception_sjlj): Change "exception" to const reference.
 620
 621 2019-04-25  Tom Tromey  <tromey@adacore.com>
 622
 623         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 624         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 625         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 626         Update.
 627         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 628         Update.
 629         * mi/mi-interp.c (mi_interp::exec): Update.
 630         * linespec.c (parse_linespec): Update.
 631         * infcall.c (run_inferior_call): Update.
 632         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 633         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 634         (gdbscm_lookup_global_symbol): Update.
 635         * guile/scm-param.c (gdbscm_parameter_value): Update.
 636         * guile/scm-frame.c (gdbscm_frame_read_register)
 637         (gdbscm_frame_read_var): Update.
 638         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 639         * exec.c (try_open_exec_file): Update.
 640         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 641         (gdb_rl_callback_handler): Update.
 642         * common/common-exceptions.h (exception_none): Don't declare.
 643         * common/common-exceptions.c (exception_none): Don't define.
 644         (struct catcher) <exception>: Update.
 645         * cli/cli-interp.c (safe_execute_command): Update.
 646         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 647
 648 2019-04-25  Ali Tamur  <tamur@google.com>
 649
 650         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 651         (read_attribute_value): Likewise.
 652         (dwarf2_read_addr_index): Update comment.
 653         (read_str_index): Add DW_FORM_strx.
 654         (dwarf2_string_attr): Likewise.
 655         (dwarf2_const_value_attr): Likewise.
 656         (dump_die_shallow): Likewise.
 657         (dwarf2_fetch_constant_bytes): Likewise.
 658         (skip_form_bytes): Likewise.
 659         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 660
 661 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 662
 663         PR corefiles/11608
 664         PR corefiles/18187
 665         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 666         OFFSET.  Verify if current mapping contains an ELF header.
 667         (linux_find_memory_regions_full): Adjust call to
 668         dump_mapping_p.
 669
 670 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 671             Kang Li <kanglictf@gmail.com>
 672
 673         PR gdb/21600
 674
 675         * dwarf2-frame.c (read_initial_length): Be consistent about using
 676         unsigned representation of length.
 677         (decode_frame_entry_1): Likewise.  Check for wraparound of
 678         end pointer as well as buffer overflow.
 679
 680 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 681
 682         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 683         "vq".
 684
 685 2019-04-24  Tom Tromey  <tromey@adacore.com>
 686
 687         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 688
 689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * s12z-tdep.c (s12z_unwind_pc): Delete.
 692         (s12z_unwind_sp): Delete.
 693         (s12z_gdbarch_init): Don't register deleted functions with
 694         gdbarch.
 695
 696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 697
 698         * rl78-tdep.c (rl78_unwind_sp): Delete.
 699         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 700
 701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 702
 703         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 704         (xstormy16_unwind_pc): Delete.
 705         (xstormy16_dummy_id): Delete.
 706         (xstormy16_gdbarch_init): Don't register deleted functions with
 707         gdbarch.
 708
 709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * vax-tdep.c (vax_unwind_pc): Delete.
 712         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 713
 714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * v850-tdep.c (v850_unwind_sp): Delete.
 717         (v850_unwind_pc): Delete.
 718         (v850_dummy_id): Delete.
 719         (v850_gdbarch_init): Don't register deleted functions with
 720         gdbarch.
 721
 722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 723
 724         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 725         (tilegx_unwind_pc): Delete.
 726         (tilegx_unwind_dummy_id): Delete.
 727         (tilegx_gdbarch_init): Don't register deleted functions with
 728         gdbarch.
 729
 730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 733         (tic6x_dummy_id): Delete.
 734         (tic6x_gdbarch_init): Don't register deleted functions with
 735         gdbarch.
 736
 737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * sparc-tdep.c (sparc_unwind_pc): Delete.
 740         (sparc32_gdbarch_init): Don't register deleted function with
 741         gdbarch.
 742
 743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * sh-tdep.c (sh_unwind_sp): Delete.
 746         (sh_unwind_pc): Delete.
 747         (sh_dummy_id): Delete.
 748         (sh_gdbarch_init): Don't register deleted functions with
 749         gdbarch.
 750
 751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * score-tdep.c (score_unwind_sp): Delete.
 754         (score_unwind_pc): Delete.
 755         (score_dummy_id): Delete.
 756         (score_gdbarch_init): Don't register deleted functions with
 757         gdbarch.
 758
 759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 760
 761         * rx-tdep.c (rx_unwind_pc): Delete.
 762         (rx_unwind_sp): Delete.
 763         (rx_dummy_id): Delete.
 764         (rx_gdbarch_init): Don't register deleted functions with
 765         gdbarch.  Update comment.
 766
 767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 770         (rs6000_dummy_id): Delete.
 771         (rs6000_gdbarch_init): Don't register deleted functions with
 772         gdbarch.
 773
 774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 775
 776         * or1k-tdep.c (or1k_dummy_id): Delete.
 777         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 778
 779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * nios2-tdep.c (nios2_dummy_id): Delete.
 782         (nios2_unwind_sp): Delete.
 783         (nios2_gdbarch_init): Don't register deleted functions with
 784         gdbarch.
 785
 786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * nds32-tdep.c (nds32_dummy_id): Delete.
 789         (nds32_unwind_pc): Delete.
 790         (nds32_unwind_sp): Delete.
 791         (nds32_gdbarch_init): Don't register deleted functions with
 792         gdbarch.
 793
 794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * msp430-tdep.c (msp430_unwind_pc): Delete.
 797         (msp430_unwind_sp): Delete.
 798         (msp430_dummy_id): Delete.
 799         (msp430_gdbarch_init): Don't register deleted functions with
 800         gdbarch.
 801
 802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 803
 804         * moxie-tdep.c (moxie_unwind_sp): Delete.
 805         (moxie_unwind_pc): Delete.
 806         (moxie_dummy_id): Delete.
 807         (moxie_gdbarch_init): Don't register deleted functions with
 808         gdbarch.
 809
 810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 813         (mn10300_unwind_pc): Delete.
 814         (mn10300_unwind_sp): Delete.
 815         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 816         mn10300_unwind_sp.
 817         (mn10300_frame_unwind_init): Don't register deleted functions with
 818         gdbarch.
 819
 820 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 821
 822         * mep-tdep.c (mep_unwind_pc): Delete.
 823         (mep_unwind_sp): Delete.
 824         (mep_dummy_id): Delete.
 825         (mep_gdbarch_init): Don't register deleted functions with
 826         gdbarch.
 827
 828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 831         (m68hc11_unwind_sp): Delete.
 832         (m68hc11_gdbarch_init): Don't register deleted functions with
 833         gdbarch.
 834
 835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 836
 837         * m32r-tdep.c (m32r_unwind_sp): Delete.
 838         (m32r_unwind_pc): Delete.
 839         (m32r_dummy_id): Delete.
 840         (m32r_gdbarch_init): Don't register deleted functions with
 841         gdbarch.
 842
 843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * m32c-tdep.c (m32c_unwind_pc): Delete.
 846         (m32c_unwind_sp): Delete.
 847         (m32c_dummy_id): Delete.
 848         (m32c_gdbarch_init): Don't register deleted functions with
 849         gdbarch.
 850
 851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 854         (lm32_unwind_pc): Delete.
 855         (lm32_dummy_id): Delete.
 856         (lm32_gdbarch_init): Don't register deleted functions with
 857         gdbarch.
 858
 859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 862         (iq2000_unwind_pc): Delete.
 863         (iq2000_dummy_id): Delete.
 864         (iq2000_gdbarch_init): Don't register deleted functions with
 865         gdbarch.
 866
 867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * nds32-tdep.c (nds32_type_align): Delete.
 870         (nds32_push_dummy_call): Use type_align instead.
 871
 872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * arm-tdep.c (arm_type_align): Only handle vector override case.
 875         (arm_push_dummy_call): Use type_align.
 876         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 877
 878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 881         case.
 882         (pass_on_stack): Use type_align.
 883         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 884         function.
 885
 886 2019-04-23  Tom Tromey  <tromey@adacore.com>
 887
 888         * dwarf2read.c (line_header::file_name_at): Remove unused
 889         overload.
 890
 891 2019-04-23  Tom de Vries  <tdevries@suse.de>
 892
 893         PR gdb/24438
 894         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 895         invocation.
 896
 897
 898 2019-03-27  Ali Tamur  <tamur@google.com>
 899
 900         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 901         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 902         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 903         (dwarf_expr_context::get_addr_index): Likewise
 904         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 905         (symbol_needs_eval_context::get_addr_index): Likewise
 906         (disassemble_dwarf_expression): Add DW_OP_addrx
 907         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 908         (read_cutu_die_from_dwo): Update comment
 909         (skip_one_die): Add DW_FORM_addrx
 910         (read_attribute_value): Likewise
 911         (var_decode_location): Add DW_OP_addrx
 912         (dwarf2_const_value_attr): Add DW_FORM_addrx
 913         (dump_die_shallow): Likewise
 914         (dwarf2_fetch_constant_bytes): Likewise
 915         (decode_locdesc): Add DW_OP_addrx
 916         (skip_form_bytes): Add DW_FORM_addrx
 917
 918 2019-04-22  Ali Tamur  <tamur@google.com>
 919
 920         * MAINTAINERS (Write After Approval): Add self.
 921
 922 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 923
 924         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 925         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 926         (open_symbol_file_object): Likewise.
 927         (svr4_default_sos): Add info parameter.
 928         (svr4_read_so_list): Likewise.
 929         (svr4_current_sos_direct): Adjust functions calls to pass down
 930         info.
 931         (svr4_current_sos_1): Add info parameter.
 932         (svr4_current_sos): Call get_svr4_info, pass info down to
 933         svr4_current_sos_1.
 934         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 935         get_svr4_info.
 936         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 937         get_svr4_info.
 938         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 939         to get_svr4_info.
 940         (probes_table_remove_objfile_probes): Likewise.
 941         (register_solib_event_probe): Add info parameter.
 942         (solist_update_incremental): Pass info parameter down to
 943         svr4_read_so_list.
 944         (disable_probes_interface): Add info parameter.
 945         (svr4_handle_solib_event): Pass current_program_space to
 946         get_svr4_info.  Adjust disable_probes_interface cleanup.
 947         (svr4_create_probe_breakpoints): Add info parameter, pass it
 948         down to register_solib_event_probe.
 949         (svr4_create_solib_event_breakpoints): Add info parameter,
 950         pass it down to svr4_create_probe_breakpoints.
 951         (enable_break): Pass info down to
 952         svr4_create_solib_event_breakpoints.
 953         (svr4_solib_create_inferior_hook): Pass current_program_space to
 954         get_svr4_info.
 955         (svr4_clear_solib): Likewise.
 956
 957 2019-04-22  Pedro Alves  <palves@redhat.com>
 958
 959         * solib-svr4.c (svr4_free_objfile_observer): New.
 960         (probe_and_action::objfile): New field.
 961         (probes_table_htab_remove_objfile_probes)
 962         (probes_table_remove_objfile_probes): New functions.
 963         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 964         in the new probe_and_action.  Don't store the probe in 'lookup'.
 965         (svr4_create_probe_breakpoints): Pass objfile to
 966         register_solib_event_probe.
 967         (_initialize_svr4_solib): Register a free_objfile observer.
 968
 969 2019-04-19  Tom Tromey  <tom@tromey.com>
 970
 971         * common/queue.h: Remove.
 972
 973 2019-04-19  Tom Tromey  <tom@tromey.com>
 974
 975         * event-loop.c: Don't include "common/queue.h".
 976
 977 2019-04-19  Tom Tromey  <tom@tromey.com>
 978
 979         * remote.c (remote_target): Use delete.
 980         * remote-notif.h: Include <list>, not "common/queue.h".
 981         (notif_client_p): Remove typedef.
 982         (remote_notif_state): Add constructor, destructor, initializer.
 983         <notif_queue>: Now a std::list.
 984         (remote_notif_state_xfree): Don't declare.
 985         * remote-notif.c (remote_notif_process, handle_notification)
 986         (remote_notif_state_allocate): Update.
 987         (~remote_notif_state): Rename from remote_notif_state_xfree.
 988
 989 2019-04-19  Tom Tromey  <tom@tromey.com>
 990
 991         * symfile.c (reread_symbols): Update.
 992         * objfiles.c (objfile_register_static_link)
 993         (objfile_lookup_static_link): Update
 994         (~objfile) Don't delete static_links.
 995         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 996
 997 2019-04-19  Tom Tromey  <tom@tromey.com>
 998
 999         * type-stack.h (struct type_stack) <insert>: Constify string.
1000         * type-stack.c (type_stack::insert): Constify string.
1001         * gdbtypes.h (lookup_template_type): Update.
1002         (address_space_name_to_int): Update.
1003         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1004         const.
1005         (lookup_template_type): Make name const.
1006         * c-exp.y: Update rules.
1007         (lex_one_token, classify_name, classify_inner_name)
1008         (c_print_token): Update.
1009         * p-exp.y: Update rules.
1010         (yylex): Update.
1011         * f-exp.y: Update rules.
1012         (yylex): Update.
1013         * d-exp.y: Update rules.
1014         (lex_one_token, classify_name, classify_inner_name): Update.
1015         * parse.c (write_dollar_variable, copy_name): Return std::string.
1016         * parser-defs.h (copy_name): Change return type.
1017         * m2-exp.y: Update rules.
1018         (yylex): Update.
1019         * go-exp.y (lex_one_token): Update.
1020         Update rules.
1021         (classify_unsafe_function, classify_packaged_name)
1022         (classify_name, yylex): Update.
1023
1024 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1025
1026         * configure.ac: add --enable-source-highlight switch.
1027         * configure: Regenerate.
1028         * top.c (print_gdb_version): plumb --enable-source-highlight
1029         status to "show configuration".
1030
1031 2019-04-19  Tom Tromey  <tromey@adacore.com>
1032
1033         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1034         Check ADA_TYPE_P.
1035         (empty_record, ada_template_to_fixed_record_type_1)
1036         (template_to_static_fixed_type)
1037         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1038         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1039         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1040         macros.
1041
1042 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1043
1044         PR symtab/24423:
1045         * source.c (print_source_lines_base): Advance "iter" when a
1046         control character is seen.
1047
1048 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1049
1050         * inferior.h (struct infcall_suspend_state_deleter):
1051         Catch exception in destructor to avoid crash.
1052
1053 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1054
1055         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1056         close to the add_com "shell".
1057
1058 2019-04-18  Tom Tromey  <tromey@adacore.com>
1059
1060         * process-stratum-target.h (class process_stratum_target)
1061         <stratum>: Add "final".
1062
1063 2019-04-17  Tom Tromey  <tromey@adacore.com>
1064
1065         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1066         against nullptr before use.
1067
1068 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1069
1070         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1071
1072 2019-04-17  Jim Wilson  <jimw@sifive.com>
1073             Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1076         code read might fail, assume 4-byte breakpoint in that case.
1077
1078 2019-04-15  Leszek Swirski  <leszeks@google.com>
1079
1080         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1081         rather than a hand-rolled POD check when checking for forced MEMORY
1082         classification.
1083
1084 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1085
1086         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1087         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1088         function.
1089         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1090         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1091         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1092         declaration.
1093
1094 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1095
1096         * aarch64-linux-nat.c
1097         (aarch64_linux_nat_target::thread_architecture): Add override.
1098         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1099         each VQ.
1100
1101 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1102
1103         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1104
1105 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1108         target types of size 96-bits, add some additional comments, and
1109         check that the builtin type we found was the correct size.
1110
1111 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1112
1113         * utils.c (prompt_for_continue): Don't restore the styling at the
1114         end, as applied_style has the wrong value.  This fixes styling in
1115         long lists of file names that are interrupted by the "Continue?"
1116         prompt.
1117
1118 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1119
1120         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1121         * c-lang.c (c_language_defn): Likewise.
1122         (cplus_language_defn): Likewise.
1123         (asm_language_defn): Likewise.
1124         (minimal_language_defn): Likewise.
1125         * d-lang.c (d_language_defn): Likewise.
1126         * f-lang.c (f_language_defn): Likewise.
1127         * go-lang.c (go_language_defn): Likewise.
1128         * language.c (unknown_language_defn): Likewise.
1129         (auto_language_defn): Likewise.
1130         * language.h (struct language_defn): Remove la_magic field.
1131         (LANG_MAGIC): Delete.
1132         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1133         * objc-lang.c (objc_language_defn): Likewise.
1134         * opencl-lang.c (opencl_language_defn): Likewise.
1135         * p-lang.c (pascal_language_defn): Likewise.
1136         * rust-lang.c (rust_language_defn): Likewise.
1137
1138 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * riscv-tdep.c (riscv_type_align): New function.
1141         (riscv_type_alignment): Delete.
1142         (riscv_arg_location): Use 'type_align'.
1143         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1144
1145 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * gdbtypes.c (type_align): A struct with no non-static fields also
1148         has alignment of 1.
1149
1150 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1153         component to 0.
1154         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1155         member.
1156         (riscv_struct_info::analyse): New implementation using new
1157         analyse_inner member function.
1158         (riscv_struct_info::field_offset): New member function.
1159         (riscv_struct_info::m_offsets): New member variable.
1160         (riscv_struct_info::analyse_inner): New private member function,
1161         takes the old implementation of riscv_struct_info::analyse but
1162         extended to track field offsets.
1163         (riscv_call_arg_struct): Update the struct folding special cases
1164         to handle cases where empty C++ structs, which are non-zero
1165         length, are found.
1166         (riscv_arg_location): Initialise the length of each location, a
1167         non-zero length now indicates the location is in use.
1168         (riscv_push_dummy_call): Allow for the first location having a
1169         non-zero offset when setting up arguments.
1170         (riscv_return_value): Likewise, but for return values.
1171
1172 2019-04-11  Tom Tromey  <tromey@adacore.com>
1173
1174         * utils.c (internal_vproblem): Make "msg" const.
1175
1176 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1177
1178         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1179         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1180         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1181         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1182
1183 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1184
1185         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1186         function.
1187         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1188         of amd64_collect_native_gregset.
1189         (amd64_linux_nat_target::store_registers): Likewise.
1190
1191 2019-04-10  Tom Tromey  <tom@tromey.com>
1192
1193         * symtab.c (lookup_global_symbol_from_objfile)
1194         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1195         * objfiles.h (class separate_debug_iterator): New.
1196         (class separate_debug_range): New.
1197         (struct objfile) <separate_debug_objfiles>: New method.
1198         (objfile_separate_debug_iterate): Don't declare.
1199         * objfiles.c (separate_debug_iterator::operator++): Rename from
1200         objfile_separate_debug_iterate.
1201         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1202         iterator.
1203         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1204         iterator.
1205
1206 2019-04-10  Tom Tromey  <tom@tromey.com>
1207
1208         * symfile.c (reread_symbols): Remove old comment.
1209         * objfiles.c (free_all_objfiles): Fix a typo.
1210
1211 2019-04-10  Tom Tromey  <tom@tromey.com>
1212
1213         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1214         * minsyms.c (lookup_minimal_symbol): Use foreach.
1215         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1216         (lookup_minimal_symbol_solib_trampoline): Likewise.
1217         * symfile.c (reread_symbols): Use foreach.
1218
1219 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1220             Tom Tromey  <tromey@adacore.com>
1221
1222         PR rust/24414:
1223         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1224         (rust_lex_int_test): Change "value" to be LONGEST.
1225         (rust_lex_tests): Add test for long integer literal.
1226
1227 2019-04-09  Tom Tromey  <tromey@adacore.com>
1228
1229         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1230         to bool.
1231         (extended_remote_target::attach): Update.
1232         (remote_target::remote_notice_new_inferior): Update.
1233         (remote_target::add_current_inferior_and_thread): Update.
1234         * inferior.c (exit_inferior_1): Use "false".
1235         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1236
1237 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1238
1239         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1240         the "start" command.
1241
1242 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1243
1244         * python/py-inferior.c (infpy_thread_from_thread_handle):
1245         Adjust comments to reflect renaming of thread_from_thread_handle
1246         to thread_from_handle.  Adjust keywords.  Fix type error message.
1247         (inferior_object_methods): Add thread_from_handle.  Retain
1248         thread_from_thread_handle, but mark it as deprecated.
1249
1250 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1251
1252         * gdbthread.h (find_thread_by_handle): Revise declaration.
1253         * thread.c (find_thread_by_handle): Likewise.  Adjust
1254         implementation too.
1255         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1256         support for buffer objects as handles.
1257
1258 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1259
1260         * python/py-infthread.c (thpy_thread_handle): New function.
1261         (thread_object_methods): Register thpy_thread_handle.
1262
1263 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1264
1265         * gdbthread.h (thread_to_thread_handle): Declare.
1266         * thread.c (gdbtypes.h): Include.
1267         (thread_to_thread_handle): New function.
1268
1269         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1270         (target_thread_info_to_thread_handle): Declare.
1271         * target.c (target_thread_info_to_thread_handle): New function.
1272         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1273         * target-delegates.c: Regenerate.
1274
1275         * linux-thread-db.c (class thread_db_target): Add method
1276         thread_info_to_thread_handle.
1277         (thread_db_target::thread_info_to_thread_handle): Define.
1278         * remote.c (class remote_target): Add new method
1279         thread_info_to_thread_handle.
1280         (remote_target::thread_info_to_thread_handle): Define.
1281
1282 2019-04-08  Pedro Alves  <palves@redhat.com>
1283
1284         * common/common-exceptions.c (throw_exception): Don't create
1285         named object to throw; throw directly.
1286         (throw_it): Likewise.  Don't initialize gdb_exception::message
1287         here, with new; pass FMT and AP to the ctor instead.
1288         * common/common-exceptions.h: Include <string>.
1289         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1290         const char *, va_list)): New ctor.  Use std::make_shared.
1291         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1292         errors)): Delete.
1293         (gdb_exception_error::gdb_exception_error(enum errors, const char
1294         *, va_list)): New.
1295         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1296         Add assertion.
1297         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1298         errors)): Delete.
1299         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1300         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1301         Add assertion.
1302
1303 2019-04-08  Tom Tromey  <tom@tromey.com>
1304
1305         * valops.c (value_rtti_indirect_type): Replace throw_exception
1306         with throw.
1307         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1308         with throw.
1309         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1310         throw.
1311         * target.c (target_translate_tls_address): Replace throw_exception
1312         with throw.
1313         * stack.c (frame_apply_command_count): Replace throw_exception
1314         with throw.
1315         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1316         throw.
1317         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1318         with throw.
1319         * rs6000-tdep.c (rs6000_frame_cache)
1320         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1321         * remote.c: Replace throw_exception with throw.
1322         * record-full.c (record_full_message, record_full_wait_1)
1323         (record_full_restore): Replace throw_exception with throw.
1324         * record-btrace.c:
1325         (get_thread_current_frame_id, record_btrace_start_replaying)
1326         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1327         (cmd_record_btrace_start): Replace throw_exception with throw.
1328         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1329         throw.
1330         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1331         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1332         * linespec.c:
1333         (find_linespec_symbols): Replace throw_exception with throw.
1334         * infrun.c (displaced_step_prepare, resume): Replace
1335         throw_exception with throw.
1336         * infcmd.c (post_create_inferior): Replace throw_exception with
1337         throw.
1338         * inf-loop.c (inferior_event_handler): Replace throw_exception
1339         with throw.
1340         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1341         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1342         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1343         (get_prev_frame_always, get_frame_pc_if_available)
1344         (get_frame_address_in_block_if_available, get_frame_language):
1345         Replace throw_exception with throw.
1346         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1347         throw_exception with throw.
1348         * eval.c (fetch_subexp_value, evaluate_var_value)
1349         (evaluate_funcall, evaluate_subexp_standard): Replace
1350         throw_exception with throw.
1351         * dwarf2loc.c (call_site_find_chain)
1352         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1353         Replace throw_exception with throw.
1354         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1355         with throw.
1356         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1357         throw.
1358         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1359         * completer.c (complete_line_internal): Replace throw_exception
1360         with throw.
1361         * compile/compile-object-run.c (compile_object_run): Replace
1362         throw_exception with throw.
1363         * cli/cli-script.c (process_next_line): Replace throw_exception
1364         with throw.
1365         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1366         (btrace_enable, btrace_maint_update_pt_packets): Replace
1367         throw_exception with throw.
1368         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1369         throw_exception with throw.
1370         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1371         throw_exception with throw.
1372         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1373         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1374         * aarch64-tdep.c (aarch64_make_prologue_cache)
1375         (aarch64_make_stub_cache): Replace throw_exception with throw.
1376
1377 2019-04-08  Tom Tromey  <tom@tromey.com>
1378
1379         * common/common-exceptions.c (throw_exception): Rename from
1380         throw_exception_cxx.  Remove old copy.  Make argument const.
1381         (throw_it): Create and throw exception objects directly.
1382         * common/common-exceptions.h (throw_exception): Make argument
1383         const.
1384         (struct gdb_exception_error): Add constructor.
1385         (struct gdb_exception_quit): Add constructor.
1386
1387 2019-04-08  Tom Tromey  <tom@tromey.com>
1388
1389         * common/common-exceptions.h (exception_rethrow): Don't declare.
1390         (TRY_SJLJ): Update comment.
1391         (TRY, CATCH, END_CATCH): Remove.
1392         * common/common-exceptions.c (exception_rethrow): Remove.
1393
1394 2019-04-08  Tom Tromey  <tom@tromey.com>
1395
1396         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1397         Remove.
1398         (gdb_exception_error): Rename from
1399         gdb_exception_RETURN_MASK_ERROR.
1400         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1401         (gdb_quit_bad_alloc): Update.
1402         * aarch64-tdep.c: Update.
1403         * ada-lang.c: Update.
1404         * ada-typeprint.c: Update.
1405         * ada-valprint.c: Update.
1406         * amd64-tdep.c: Update.
1407         * arch-utils.c: Update.
1408         * break-catch-throw.c: Update.
1409         * breakpoint.c: Update.
1410         * btrace.c: Update.
1411         * c-varobj.c: Update.
1412         * cli/cli-cmds.c: Update.
1413         * cli/cli-interp.c: Update.
1414         * cli/cli-script.c: Update.
1415         * common/common-exceptions.c: Update.
1416         * common/new-op.c: Update.
1417         * common/selftest.c: Update.
1418         * compile/compile-c-symbols.c: Update.
1419         * compile/compile-cplus-symbols.c: Update.
1420         * compile/compile-object-load.c: Update.
1421         * compile/compile-object-run.c: Update.
1422         * completer.c: Update.
1423         * corelow.c: Update.
1424         * cp-abi.c: Update.
1425         * cp-support.c: Update.
1426         * cp-valprint.c: Update.
1427         * darwin-nat.c: Update.
1428         * disasm-selftests.c: Update.
1429         * dtrace-probe.c: Update.
1430         * dwarf-index-cache.c: Update.
1431         * dwarf-index-write.c: Update.
1432         * dwarf2-frame-tailcall.c: Update.
1433         * dwarf2-frame.c: Update.
1434         * dwarf2loc.c: Update.
1435         * dwarf2read.c: Update.
1436         * eval.c: Update.
1437         * event-loop.c: Update.
1438         * event-top.c: Update.
1439         * exec.c: Update.
1440         * f-valprint.c: Update.
1441         * fbsd-tdep.c: Update.
1442         * frame-unwind.c: Update.
1443         * frame.c: Update.
1444         * gdbtypes.c: Update.
1445         * gnu-v3-abi.c: Update.
1446         * guile/guile-internal.h: Update.
1447         * guile/scm-block.c: Update.
1448         * guile/scm-breakpoint.c: Update.
1449         * guile/scm-cmd.c: Update.
1450         * guile/scm-disasm.c: Update.
1451         * guile/scm-frame.c: Update.
1452         * guile/scm-lazy-string.c: Update.
1453         * guile/scm-math.c: Update.
1454         * guile/scm-param.c: Update.
1455         * guile/scm-ports.c: Update.
1456         * guile/scm-pretty-print.c: Update.
1457         * guile/scm-symbol.c: Update.
1458         * guile/scm-symtab.c: Update.
1459         * guile/scm-type.c: Update.
1460         * guile/scm-value.c: Update.
1461         * i386-linux-tdep.c: Update.
1462         * i386-tdep.c: Update.
1463         * inf-loop.c: Update.
1464         * infcall.c: Update.
1465         * infcmd.c: Update.
1466         * infrun.c: Update.
1467         * jit.c: Update.
1468         * language.c: Update.
1469         * linespec.c: Update.
1470         * linux-fork.c: Update.
1471         * linux-nat.c: Update.
1472         * linux-tdep.c: Update.
1473         * linux-thread-db.c: Update.
1474         * main.c: Update.
1475         * mi/mi-cmd-break.c: Update.
1476         * mi/mi-cmd-stack.c: Update.
1477         * mi/mi-interp.c: Update.
1478         * mi/mi-main.c: Update.
1479         * objc-lang.c: Update.
1480         * p-valprint.c: Update.
1481         * parse.c: Update.
1482         * ppc-linux-tdep.c: Update.
1483         * printcmd.c: Update.
1484         * python/py-arch.c: Update.
1485         * python/py-breakpoint.c: Update.
1486         * python/py-cmd.c: Update.
1487         * python/py-finishbreakpoint.c: Update.
1488         * python/py-frame.c: Update.
1489         * python/py-framefilter.c: Update.
1490         * python/py-gdb-readline.c: Update.
1491         * python/py-inferior.c: Update.
1492         * python/py-infthread.c: Update.
1493         * python/py-lazy-string.c: Update.
1494         * python/py-linetable.c: Update.
1495         * python/py-objfile.c: Update.
1496         * python/py-param.c: Update.
1497         * python/py-prettyprint.c: Update.
1498         * python/py-progspace.c: Update.
1499         * python/py-record-btrace.c: Update.
1500         * python/py-record.c: Update.
1501         * python/py-symbol.c: Update.
1502         * python/py-type.c: Update.
1503         * python/py-unwind.c: Update.
1504         * python/py-utils.c: Update.
1505         * python/py-value.c: Update.
1506         * python/python.c: Update.
1507         * record-btrace.c: Update.
1508         * record-full.c: Update.
1509         * remote-fileio.c: Update.
1510         * remote.c: Update.
1511         * riscv-tdep.c: Update.
1512         * rs6000-aix-tdep.c: Update.
1513         * rs6000-tdep.c: Update.
1514         * rust-exp.y: Update.
1515         * rust-lang.c: Update.
1516         * s390-tdep.c: Update.
1517         * selftest-arch.c: Update.
1518         * solib-dsbt.c: Update.
1519         * solib-frv.c: Update.
1520         * solib-spu.c: Update.
1521         * solib-svr4.c: Update.
1522         * solib.c: Update.
1523         * sparc64-linux-tdep.c: Update.
1524         * stack.c: Update.
1525         * symfile-mem.c: Update.
1526         * symmisc.c: Update.
1527         * target.c: Update.
1528         * thread.c: Update.
1529         * top.c: Update.
1530         * tracefile-tfile.c: Update.
1531         * tui/tui.c: Update.
1532         * typeprint.c: Update.
1533         * unittests/cli-utils-selftests.c: Update.
1534         * unittests/parse-connection-spec-selftests.c: Update.
1535         * valops.c: Update.
1536         * valprint.c: Update.
1537         * value.c: Update.
1538         * varobj.c: Update.
1539         * windows-nat.c: Update.
1540         * x86-linux-nat.c: Update.
1541         * xml-support.c: Update.
1542
1543 2019-04-08  Tom Tromey  <tom@tromey.com>
1544
1545         * xml-support.c: Use C++ exception handling.
1546         * x86-linux-nat.c: Use C++ exception handling.
1547         * windows-nat.c: Use C++ exception handling.
1548         * varobj.c: Use C++ exception handling.
1549         * value.c: Use C++ exception handling.
1550         * valprint.c: Use C++ exception handling.
1551         * valops.c: Use C++ exception handling.
1552         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1553         handling.
1554         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1555         * typeprint.c: Use C++ exception handling.
1556         * tui/tui.c: Use C++ exception handling.
1557         * tracefile-tfile.c: Use C++ exception handling.
1558         * top.c: Use C++ exception handling.
1559         * thread.c: Use C++ exception handling.
1560         * target.c: Use C++ exception handling.
1561         * symmisc.c: Use C++ exception handling.
1562         * symfile-mem.c: Use C++ exception handling.
1563         * stack.c: Use C++ exception handling.
1564         * sparc64-linux-tdep.c: Use C++ exception handling.
1565         * solib.c: Use C++ exception handling.
1566         * solib-svr4.c: Use C++ exception handling.
1567         * solib-spu.c: Use C++ exception handling.
1568         * solib-frv.c: Use C++ exception handling.
1569         * solib-dsbt.c: Use C++ exception handling.
1570         * selftest-arch.c: Use C++ exception handling.
1571         * s390-tdep.c: Use C++ exception handling.
1572         * rust-lang.c: Use C++ exception handling.
1573         * rust-exp.y: Use C++ exception handling.
1574         * rs6000-tdep.c: Use C++ exception handling.
1575         * rs6000-aix-tdep.c: Use C++ exception handling.
1576         * riscv-tdep.c: Use C++ exception handling.
1577         * remote.c: Use C++ exception handling.
1578         * remote-fileio.c: Use C++ exception handling.
1579         * record-full.c: Use C++ exception handling.
1580         * record-btrace.c: Use C++ exception handling.
1581         * python/python.c: Use C++ exception handling.
1582         * python/py-value.c: Use C++ exception handling.
1583         * python/py-utils.c: Use C++ exception handling.
1584         * python/py-unwind.c: Use C++ exception handling.
1585         * python/py-type.c: Use C++ exception handling.
1586         * python/py-symbol.c: Use C++ exception handling.
1587         * python/py-record.c: Use C++ exception handling.
1588         * python/py-record-btrace.c: Use C++ exception handling.
1589         * python/py-progspace.c: Use C++ exception handling.
1590         * python/py-prettyprint.c: Use C++ exception handling.
1591         * python/py-param.c: Use C++ exception handling.
1592         * python/py-objfile.c: Use C++ exception handling.
1593         * python/py-linetable.c: Use C++ exception handling.
1594         * python/py-lazy-string.c: Use C++ exception handling.
1595         * python/py-infthread.c: Use C++ exception handling.
1596         * python/py-inferior.c: Use C++ exception handling.
1597         * python/py-gdb-readline.c: Use C++ exception handling.
1598         * python/py-framefilter.c: Use C++ exception handling.
1599         * python/py-frame.c: Use C++ exception handling.
1600         * python/py-finishbreakpoint.c: Use C++ exception handling.
1601         * python/py-cmd.c: Use C++ exception handling.
1602         * python/py-breakpoint.c: Use C++ exception handling.
1603         * python/py-arch.c: Use C++ exception handling.
1604         * printcmd.c: Use C++ exception handling.
1605         * ppc-linux-tdep.c: Use C++ exception handling.
1606         * parse.c: Use C++ exception handling.
1607         * p-valprint.c: Use C++ exception handling.
1608         * objc-lang.c: Use C++ exception handling.
1609         * mi/mi-main.c: Use C++ exception handling.
1610         * mi/mi-interp.c: Use C++ exception handling.
1611         * mi/mi-cmd-stack.c: Use C++ exception handling.
1612         * mi/mi-cmd-break.c: Use C++ exception handling.
1613         * main.c: Use C++ exception handling.
1614         * linux-thread-db.c: Use C++ exception handling.
1615         * linux-tdep.c: Use C++ exception handling.
1616         * linux-nat.c: Use C++ exception handling.
1617         * linux-fork.c: Use C++ exception handling.
1618         * linespec.c: Use C++ exception handling.
1619         * language.c: Use C++ exception handling.
1620         * jit.c: Use C++ exception handling.
1621         * infrun.c: Use C++ exception handling.
1622         * infcmd.c: Use C++ exception handling.
1623         * infcall.c: Use C++ exception handling.
1624         * inf-loop.c: Use C++ exception handling.
1625         * i386-tdep.c: Use C++ exception handling.
1626         * i386-linux-tdep.c: Use C++ exception handling.
1627         * guile/scm-value.c: Use C++ exception handling.
1628         * guile/scm-type.c: Use C++ exception handling.
1629         * guile/scm-symtab.c: Use C++ exception handling.
1630         * guile/scm-symbol.c: Use C++ exception handling.
1631         * guile/scm-pretty-print.c: Use C++ exception handling.
1632         * guile/scm-ports.c: Use C++ exception handling.
1633         * guile/scm-param.c: Use C++ exception handling.
1634         * guile/scm-math.c: Use C++ exception handling.
1635         * guile/scm-lazy-string.c: Use C++ exception handling.
1636         * guile/scm-frame.c: Use C++ exception handling.
1637         * guile/scm-disasm.c: Use C++ exception handling.
1638         * guile/scm-cmd.c: Use C++ exception handling.
1639         * guile/scm-breakpoint.c: Use C++ exception handling.
1640         * guile/scm-block.c: Use C++ exception handling.
1641         * guile/guile-internal.h: Use C++ exception handling.
1642         * gnu-v3-abi.c: Use C++ exception handling.
1643         * gdbtypes.c: Use C++ exception handling.
1644         * frame.c: Use C++ exception handling.
1645         * frame-unwind.c: Use C++ exception handling.
1646         * fbsd-tdep.c: Use C++ exception handling.
1647         * f-valprint.c: Use C++ exception handling.
1648         * exec.c: Use C++ exception handling.
1649         * event-top.c: Use C++ exception handling.
1650         * event-loop.c: Use C++ exception handling.
1651         * eval.c: Use C++ exception handling.
1652         * dwarf2read.c: Use C++ exception handling.
1653         * dwarf2loc.c: Use C++ exception handling.
1654         * dwarf2-frame.c: Use C++ exception handling.
1655         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1656         * dwarf-index-write.c: Use C++ exception handling.
1657         * dwarf-index-cache.c: Use C++ exception handling.
1658         * dtrace-probe.c: Use C++ exception handling.
1659         * disasm-selftests.c: Use C++ exception handling.
1660         * darwin-nat.c: Use C++ exception handling.
1661         * cp-valprint.c: Use C++ exception handling.
1662         * cp-support.c: Use C++ exception handling.
1663         * cp-abi.c: Use C++ exception handling.
1664         * corelow.c: Use C++ exception handling.
1665         * completer.c: Use C++ exception handling.
1666         * compile/compile-object-run.c: Use C++ exception handling.
1667         * compile/compile-object-load.c: Use C++ exception handling.
1668         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1669         * compile/compile-c-symbols.c: Use C++ exception handling.
1670         * common/selftest.c: Use C++ exception handling.
1671         * common/new-op.c: Use C++ exception handling.
1672         * cli/cli-script.c: Use C++ exception handling.
1673         * cli/cli-interp.c: Use C++ exception handling.
1674         * cli/cli-cmds.c: Use C++ exception handling.
1675         * c-varobj.c: Use C++ exception handling.
1676         * btrace.c: Use C++ exception handling.
1677         * breakpoint.c: Use C++ exception handling.
1678         * break-catch-throw.c: Use C++ exception handling.
1679         * arch-utils.c: Use C++ exception handling.
1680         * amd64-tdep.c: Use C++ exception handling.
1681         * ada-valprint.c: Use C++ exception handling.
1682         * ada-typeprint.c: Use C++ exception handling.
1683         * ada-lang.c: Use C++ exception handling.
1684         * aarch64-tdep.c: Use C++ exception handling.
1685
1686 2019-04-08  Tom Tromey  <tom@tromey.com>
1687
1688         * xml-support.c (gdb_xml_parser::parse): Update.
1689         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1690         * value.c (show_convenience): Update.
1691         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1692         (test_parse_flags_qcs): Update.
1693         * thread.c (thr_try_catch_cmd): Update.
1694         * target.c (target_translate_tls_address): Update.
1695         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1696         (info_frame_command_core, frame_apply_command_count): Update.
1697         * rust-exp.y (rust_lex_exception_test): Update.
1698         * riscv-tdep.c (riscv_print_one_register_info): Update.
1699         * remote.c (remote_target::enable_btrace): Update.
1700         * record-btrace.c (record_btrace_enable_warn): Update.
1701         * python/py-utils.c (gdbpy_convert_exception): Update.
1702         * printcmd.c (do_one_display, print_variable_and_value): Update.
1703         * mi/mi-main.c (mi_print_exception): Update.
1704         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1705         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1706         * linux-nat.c (linux_nat_target::attach): Update.
1707         * linux-fork.c (class scoped_switch_fork_info): Update.
1708         * infrun.c (displaced_step_prepare): Update.
1709         * infcall.c (call_function_by_hand_dummy): Update.
1710         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1711         * gnu-v3-abi.c (print_one_vtable): Update.
1712         * frame.c (get_prev_frame_always): Update.
1713         * f-valprint.c (info_common_command_for_block): Update.
1714         * exec.c (try_open_exec_file): Update.
1715         * exceptions.c (print_exception, exception_print)
1716         (exception_fprintf, exception_print_same): Update.
1717         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1718         * dwarf-index-cache.c (index_cache::store)
1719         (index_cache::lookup_gdb_index): Update.
1720         * darwin-nat.c (maybe_cache_shell): Update.
1721         * cp-valprint.c (cp_print_value_fields): Update.
1722         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1723         (gcc_cplus_symbol_address): Update.
1724         * compile/compile-c-symbols.c (gcc_convert_symbol)
1725         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1726         * common/selftest.c: Update.
1727         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1728         a std::string.
1729         (exception_try_scope_entry, exception_try_scope_exit): Don't
1730         declare.
1731         (struct exception_try_scope): Remove.
1732         (TRY): Don't use exception_try_scope.
1733         (struct gdb_exception): Add constructor, operator=.
1734         <what>: New method.
1735         (struct gdb_exception_RETURN_MASK_ALL)
1736         (struct gdb_exception_RETURN_MASK_ERROR)
1737         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1738         (struct gdb_quit_bad_alloc): Update.
1739         * common/common-exceptions.c (exception_none): Change
1740         initializer.
1741         (struct catcher) <state, exception>: Initialize inline.
1742         <prev>: Remove member.
1743         (current_catcher): Remove.
1744         (catchers): New global.
1745         (exceptions_state_mc_init): Simplify.
1746         (catcher_pop): Remove.
1747         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1748         (try_scope_depth, exception_try_scope_entry)
1749         (exception_try_scope_exit): Remove.
1750         (throw_exception_sjlj): Update.
1751         (exception_messages, exception_messages_size): Remove.
1752         (throw_it): Simplify.
1753         (gdb_exception_sliced_copy): Remove.
1754         (throw_exception_cxx): Update.
1755         * cli/cli-script.c (script_from_file): Update.
1756         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1757         Update.
1758         * ada-valprint.c (ada_val_print): Update.
1759         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1760         (create_excep_cond_exprs): Update.
1761
1762 2019-04-08  Tom Tromey  <tom@tromey.com>
1763
1764         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1765         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1766         (TRY, CATCH, END_CATCH): Remove some definitions.
1767         * common/common-exceptions.c: Don't use GDB_XCPT.
1768         (catcher_list_size): Remove.
1769         (throw_exception, throw_it): Simplify.
1770
1771 2019-04-05  Tom Tromey  <tom@tromey.com>
1772
1773         Revert the header-sorting patch.
1774         * ft32-tdep.c: Revert.
1775         * frv-tdep.c: Revert.
1776         * frv-linux-tdep.c: Revert.
1777         * frame.c: Revert.
1778         * frame-unwind.c: Revert.
1779         * frame-base.c: Revert.
1780         * fork-child.c: Revert.
1781         * findvar.c: Revert.
1782         * findcmd.c: Revert.
1783         * filesystem.c: Revert.
1784         * filename-seen-cache.h: Revert.
1785         * filename-seen-cache.c: Revert.
1786         * fbsd-tdep.c: Revert.
1787         * fbsd-nat.h: Revert.
1788         * fbsd-nat.c: Revert.
1789         * f-valprint.c: Revert.
1790         * f-typeprint.c: Revert.
1791         * f-lang.c: Revert.
1792         * extension.h: Revert.
1793         * extension.c: Revert.
1794         * extension-priv.h: Revert.
1795         * expprint.c: Revert.
1796         * exec.h: Revert.
1797         * exec.c: Revert.
1798         * exceptions.c: Revert.
1799         * event-top.c: Revert.
1800         * event-loop.c: Revert.
1801         * eval.c: Revert.
1802         * elfread.c: Revert.
1803         * dwarf2read.h: Revert.
1804         * dwarf2read.c: Revert.
1805         * dwarf2loc.c: Revert.
1806         * dwarf2expr.h: Revert.
1807         * dwarf2expr.c: Revert.
1808         * dwarf2-frame.c: Revert.
1809         * dwarf2-frame-tailcall.c: Revert.
1810         * dwarf-index-write.h: Revert.
1811         * dwarf-index-write.c: Revert.
1812         * dwarf-index-common.c: Revert.
1813         * dwarf-index-cache.h: Revert.
1814         * dwarf-index-cache.c: Revert.
1815         * dummy-frame.c: Revert.
1816         * dtrace-probe.c: Revert.
1817         * disasm.h: Revert.
1818         * disasm.c: Revert.
1819         * disasm-selftests.c: Revert.
1820         * dictionary.c: Revert.
1821         * dicos-tdep.c: Revert.
1822         * demangle.c: Revert.
1823         * dcache.h: Revert.
1824         * dcache.c: Revert.
1825         * darwin-nat.h: Revert.
1826         * darwin-nat.c: Revert.
1827         * darwin-nat-info.c: Revert.
1828         * d-valprint.c: Revert.
1829         * d-namespace.c: Revert.
1830         * d-lang.c: Revert.
1831         * ctf.c: Revert.
1832         * csky-tdep.c: Revert.
1833         * csky-linux-tdep.c: Revert.
1834         * cris-tdep.c: Revert.
1835         * cris-linux-tdep.c: Revert.
1836         * cp-valprint.c: Revert.
1837         * cp-support.c: Revert.
1838         * cp-namespace.c: Revert.
1839         * cp-abi.c: Revert.
1840         * corelow.c: Revert.
1841         * corefile.c: Revert.
1842         * continuations.c: Revert.
1843         * completer.h: Revert.
1844         * completer.c: Revert.
1845         * complaints.c: Revert.
1846         * coffread.c: Revert.
1847         * coff-pe-read.c: Revert.
1848         * cli-out.h: Revert.
1849         * cli-out.c: Revert.
1850         * charset.c: Revert.
1851         * c-varobj.c: Revert.
1852         * c-valprint.c: Revert.
1853         * c-typeprint.c: Revert.
1854         * c-lang.c: Revert.
1855         * buildsym.c: Revert.
1856         * buildsym-legacy.c: Revert.
1857         * build-id.h: Revert.
1858         * build-id.c: Revert.
1859         * btrace.c: Revert.
1860         * bsd-uthread.c: Revert.
1861         * breakpoint.h: Revert.
1862         * breakpoint.c: Revert.
1863         * break-catch-throw.c: Revert.
1864         * break-catch-syscall.c: Revert.
1865         * break-catch-sig.c: Revert.
1866         * blockframe.c: Revert.
1867         * block.c: Revert.
1868         * bfin-tdep.c: Revert.
1869         * bfin-linux-tdep.c: Revert.
1870         * bfd-target.c: Revert.
1871         * bcache.c: Revert.
1872         * ax-general.c: Revert.
1873         * ax-gdb.h: Revert.
1874         * ax-gdb.c: Revert.
1875         * avr-tdep.c: Revert.
1876         * auxv.c: Revert.
1877         * auto-load.c: Revert.
1878         * arm-wince-tdep.c: Revert.
1879         * arm-tdep.c: Revert.
1880         * arm-symbian-tdep.c: Revert.
1881         * arm-pikeos-tdep.c: Revert.
1882         * arm-obsd-tdep.c: Revert.
1883         * arm-nbsd-tdep.c: Revert.
1884         * arm-nbsd-nat.c: Revert.
1885         * arm-linux-tdep.c: Revert.
1886         * arm-linux-nat.c: Revert.
1887         * arm-fbsd-tdep.c: Revert.
1888         * arm-fbsd-nat.c: Revert.
1889         * arm-bsd-tdep.c: Revert.
1890         * arch-utils.c: Revert.
1891         * arc-tdep.c: Revert.
1892         * arc-newlib-tdep.c: Revert.
1893         * annotate.h: Revert.
1894         * annotate.c: Revert.
1895         * amd64-windows-tdep.c: Revert.
1896         * amd64-windows-nat.c: Revert.
1897         * amd64-tdep.c: Revert.
1898         * amd64-sol2-tdep.c: Revert.
1899         * amd64-obsd-tdep.c: Revert.
1900         * amd64-obsd-nat.c: Revert.
1901         * amd64-nbsd-tdep.c: Revert.
1902         * amd64-nbsd-nat.c: Revert.
1903         * amd64-nat.c: Revert.
1904         * amd64-linux-tdep.c: Revert.
1905         * amd64-linux-nat.c: Revert.
1906         * amd64-fbsd-tdep.c: Revert.
1907         * amd64-fbsd-nat.c: Revert.
1908         * amd64-dicos-tdep.c: Revert.
1909         * amd64-darwin-tdep.c: Revert.
1910         * amd64-bsd-nat.c: Revert.
1911         * alpha-tdep.c: Revert.
1912         * alpha-obsd-tdep.c: Revert.
1913         * alpha-nbsd-tdep.c: Revert.
1914         * alpha-mdebug-tdep.c: Revert.
1915         * alpha-linux-tdep.c: Revert.
1916         * alpha-linux-nat.c: Revert.
1917         * alpha-bsd-tdep.c: Revert.
1918         * alpha-bsd-nat.c: Revert.
1919         * aix-thread.c: Revert.
1920         * agent.c: Revert.
1921         * addrmap.c: Revert.
1922         * ada-varobj.c: Revert.
1923         * ada-valprint.c: Revert.
1924         * ada-typeprint.c: Revert.
1925         * ada-tasks.c: Revert.
1926         * ada-lang.c: Revert.
1927         * aarch64-tdep.c: Revert.
1928         * aarch64-ravenscar-thread.c: Revert.
1929         * aarch64-newlib-tdep.c: Revert.
1930         * aarch64-linux-tdep.c: Revert.
1931         * aarch64-linux-nat.c: Revert.
1932         * aarch64-fbsd-tdep.c: Revert.
1933         * aarch64-fbsd-nat.c: Revert.
1934         * aarch32-linux-nat.c: Revert.
1935
1936 2019-04-05  Tom Tromey  <tom@tromey.com>
1937
1938         * ft32-tdep.c: Sort headers.
1939         * frv-tdep.c: Sort headers.
1940         * frv-linux-tdep.c: Sort headers.
1941         * frame.c: Sort headers.
1942         * frame-unwind.c: Sort headers.
1943         * frame-base.c: Sort headers.
1944         * fork-child.c: Sort headers.
1945         * findvar.c: Sort headers.
1946         * findcmd.c: Sort headers.
1947         * filesystem.c: Sort headers.
1948         * filename-seen-cache.h: Sort headers.
1949         * filename-seen-cache.c: Sort headers.
1950         * fbsd-tdep.c: Sort headers.
1951         * fbsd-nat.h: Sort headers.
1952         * fbsd-nat.c: Sort headers.
1953         * f-valprint.c: Sort headers.
1954         * f-typeprint.c: Sort headers.
1955         * f-lang.c: Sort headers.
1956         * extension.h: Sort headers.
1957         * extension.c: Sort headers.
1958         * extension-priv.h: Sort headers.
1959         * expprint.c: Sort headers.
1960         * exec.h: Sort headers.
1961         * exec.c: Sort headers.
1962         * exceptions.c: Sort headers.
1963         * event-top.c: Sort headers.
1964         * event-loop.c: Sort headers.
1965         * eval.c: Sort headers.
1966         * elfread.c: Sort headers.
1967         * dwarf2read.h: Sort headers.
1968         * dwarf2read.c: Sort headers.
1969         * dwarf2loc.c: Sort headers.
1970         * dwarf2expr.h: Sort headers.
1971         * dwarf2expr.c: Sort headers.
1972         * dwarf2-frame.c: Sort headers.
1973         * dwarf2-frame-tailcall.c: Sort headers.
1974         * dwarf-index-write.h: Sort headers.
1975         * dwarf-index-write.c: Sort headers.
1976         * dwarf-index-common.c: Sort headers.
1977         * dwarf-index-cache.h: Sort headers.
1978         * dwarf-index-cache.c: Sort headers.
1979         * dummy-frame.c: Sort headers.
1980         * dtrace-probe.c: Sort headers.
1981         * disasm.h: Sort headers.
1982         * disasm.c: Sort headers.
1983         * disasm-selftests.c: Sort headers.
1984         * dictionary.c: Sort headers.
1985         * dicos-tdep.c: Sort headers.
1986         * demangle.c: Sort headers.
1987         * dcache.h: Sort headers.
1988         * dcache.c: Sort headers.
1989         * darwin-nat.h: Sort headers.
1990         * darwin-nat.c: Sort headers.
1991         * darwin-nat-info.c: Sort headers.
1992         * d-valprint.c: Sort headers.
1993         * d-namespace.c: Sort headers.
1994         * d-lang.c: Sort headers.
1995         * ctf.c: Sort headers.
1996         * csky-tdep.c: Sort headers.
1997         * csky-linux-tdep.c: Sort headers.
1998         * cris-tdep.c: Sort headers.
1999         * cris-linux-tdep.c: Sort headers.
2000         * cp-valprint.c: Sort headers.
2001         * cp-support.c: Sort headers.
2002         * cp-namespace.c: Sort headers.
2003         * cp-abi.c: Sort headers.
2004         * corelow.c: Sort headers.
2005         * corefile.c: Sort headers.
2006         * continuations.c: Sort headers.
2007         * completer.h: Sort headers.
2008         * completer.c: Sort headers.
2009         * complaints.c: Sort headers.
2010         * coffread.c: Sort headers.
2011         * coff-pe-read.c: Sort headers.
2012         * cli-out.h: Sort headers.
2013         * cli-out.c: Sort headers.
2014         * charset.c: Sort headers.
2015         * c-varobj.c: Sort headers.
2016         * c-valprint.c: Sort headers.
2017         * c-typeprint.c: Sort headers.
2018         * c-lang.c: Sort headers.
2019         * buildsym.c: Sort headers.
2020         * buildsym-legacy.c: Sort headers.
2021         * build-id.h: Sort headers.
2022         * build-id.c: Sort headers.
2023         * btrace.c: Sort headers.
2024         * bsd-uthread.c: Sort headers.
2025         * breakpoint.h: Sort headers.
2026         * breakpoint.c: Sort headers.
2027         * break-catch-throw.c: Sort headers.
2028         * break-catch-syscall.c: Sort headers.
2029         * break-catch-sig.c: Sort headers.
2030         * blockframe.c: Sort headers.
2031         * block.c: Sort headers.
2032         * bfin-tdep.c: Sort headers.
2033         * bfin-linux-tdep.c: Sort headers.
2034         * bfd-target.c: Sort headers.
2035         * bcache.c: Sort headers.
2036         * ax-general.c: Sort headers.
2037         * ax-gdb.h: Sort headers.
2038         * ax-gdb.c: Sort headers.
2039         * avr-tdep.c: Sort headers.
2040         * auxv.c: Sort headers.
2041         * auto-load.c: Sort headers.
2042         * arm-wince-tdep.c: Sort headers.
2043         * arm-tdep.c: Sort headers.
2044         * arm-symbian-tdep.c: Sort headers.
2045         * arm-pikeos-tdep.c: Sort headers.
2046         * arm-obsd-tdep.c: Sort headers.
2047         * arm-nbsd-tdep.c: Sort headers.
2048         * arm-nbsd-nat.c: Sort headers.
2049         * arm-linux-tdep.c: Sort headers.
2050         * arm-linux-nat.c: Sort headers.
2051         * arm-fbsd-tdep.c: Sort headers.
2052         * arm-fbsd-nat.c: Sort headers.
2053         * arm-bsd-tdep.c: Sort headers.
2054         * arch-utils.c: Sort headers.
2055         * arc-tdep.c: Sort headers.
2056         * arc-newlib-tdep.c: Sort headers.
2057         * annotate.h: Sort headers.
2058         * annotate.c: Sort headers.
2059         * amd64-windows-tdep.c: Sort headers.
2060         * amd64-windows-nat.c: Sort headers.
2061         * amd64-tdep.c: Sort headers.
2062         * amd64-sol2-tdep.c: Sort headers.
2063         * amd64-obsd-tdep.c: Sort headers.
2064         * amd64-obsd-nat.c: Sort headers.
2065         * amd64-nbsd-tdep.c: Sort headers.
2066         * amd64-nbsd-nat.c: Sort headers.
2067         * amd64-nat.c: Sort headers.
2068         * amd64-linux-tdep.c: Sort headers.
2069         * amd64-linux-nat.c: Sort headers.
2070         * amd64-fbsd-tdep.c: Sort headers.
2071         * amd64-fbsd-nat.c: Sort headers.
2072         * amd64-dicos-tdep.c: Sort headers.
2073         * amd64-darwin-tdep.c: Sort headers.
2074         * amd64-bsd-nat.c: Sort headers.
2075         * alpha-tdep.c: Sort headers.
2076         * alpha-obsd-tdep.c: Sort headers.
2077         * alpha-nbsd-tdep.c: Sort headers.
2078         * alpha-mdebug-tdep.c: Sort headers.
2079         * alpha-linux-tdep.c: Sort headers.
2080         * alpha-linux-nat.c: Sort headers.
2081         * alpha-bsd-tdep.c: Sort headers.
2082         * alpha-bsd-nat.c: Sort headers.
2083         * aix-thread.c: Sort headers.
2084         * agent.c: Sort headers.
2085         * addrmap.c: Sort headers.
2086         * ada-varobj.c: Sort headers.
2087         * ada-valprint.c: Sort headers.
2088         * ada-typeprint.c: Sort headers.
2089         * ada-tasks.c: Sort headers.
2090         * ada-lang.c: Sort headers.
2091         * aarch64-tdep.c: Sort headers.
2092         * aarch64-ravenscar-thread.c: Sort headers.
2093         * aarch64-newlib-tdep.c: Sort headers.
2094         * aarch64-linux-tdep.c: Sort headers.
2095         * aarch64-linux-nat.c: Sort headers.
2096         * aarch64-fbsd-tdep.c: Sort headers.
2097         * aarch64-fbsd-nat.c: Sort headers.
2098         * aarch32-linux-nat.c: Sort headers.
2099
2100 2019-04-04  Tom Tromey  <tom@tromey.com>
2101
2102         * varobj.c (varobj_create): Update.
2103         * rust-exp.y (struct rust_parser) <update_innermost_block,
2104         lookup_symbol>: New methods.
2105         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2106         Rename.
2107         (rust_parser::rust_lookup_type)
2108         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2109         * printcmd.c (display_command, do_one_display): Update.
2110         * parser-defs.h (struct parser_state) <parser_state>: Add
2111         "tracker" parameter.
2112         (block_tracker): New member.
2113         (class innermost_block_tracker) <innermost_block_tracker>: Add
2114         "types" parameter.
2115         <reset>: Remove method.
2116         (innermost_block): Don't declare.
2117         (null_post_parser): Update.
2118         * parse.c (innermost_block): Remove global.
2119         (write_dollar_variable): Update.
2120         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2121         Remove "tracker_types" parameter.
2122         (parse_expression): Add "tracker" parameter.
2123         (parse_expression_for_completion): Update.
2124         (null_post_parser): Add "tracker" parameter.
2125         * p-exp.y: Update rules.
2126         * m2-exp.y: Update rules.
2127         * language.h (struct language_defn) <la_post_parser>: Add
2128         "tracker" parameter.
2129         * go-exp.y: Update rules.
2130         * f-exp.y: Update rules.
2131         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2132         parameter.
2133         * d-exp.y: Update rules.
2134         * c-exp.y: Update rules.
2135         * breakpoint.c (set_breakpoint_condition): Create an
2136         innermost_block_tracker.
2137         (watch_command_1): Likewise.
2138         * ada-lang.c (resolve): Add "tracker" parameter.
2139         (resolve_subexp): Likewise.
2140         * ada-exp.y (write_var_from_sym): Update.
2141
2142 2019-04-04  Tom Tromey  <tom@tromey.com>
2143
2144         * type-stack.h: New file.
2145         * type-stack.c: New file.
2146         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2147         type-stack.h.
2148         (insert_into_type_stack, insert_type, push_type, push_type_int)
2149         (insert_type_address_space, pop_type, pop_type_int)
2150         (pop_typelist, pop_type_stack, append_type_stack)
2151         (push_type_stack, get_type_stack, push_typelist)
2152         (follow_type_instance_flags, follow_types): Don't declare.
2153         * parse.c (type_stack): Remove global.
2154         (parse_exp_in_context): Update.
2155         (insert_into_type_stack, insert_type, push_type, push_type_int)
2156         (insert_type_address_space, pop_type, pop_type_int)
2157         (pop_typelist, pop_type_stack, append_type_stack)
2158         (push_type_stack, get_type_stack, push_typelist)
2159         (follow_type_instance_flags, follow_types): Remove (moved to
2160         type-stack.c).
2161         * f-exp.y (type_stack): New global.
2162         Update rules.
2163         (push_kind_type, f_parse): Update.
2164         * d-exp.y (type_stack): New global.
2165         Update rules.
2166         (d_parse): Update.
2167         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2168         Update rules.
2169         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2170         (HFILES_NO_SRCDIR): Add type-stack.h.
2171
2172 2019-04-04  Tom Tromey  <tom@tromey.com>
2173
2174         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2175         (rust_parser::convert_ast_to_expression, rust_parse)
2176         (rust_lex_test_completion, rust_lex_tests): Update.
2177         * parser-defs.h (struct expr_completion_state): New.
2178         (struct parser_state) <parser_state>: Add completion parameter.
2179         <mark_struct_expression, mark_completion_tag>: New methods.
2180         <parse_completion, m_completion_state>: New members.
2181         (prefixify_expression, null_post_parser): Update.
2182         (mark_struct_expression, mark_completion_tag): Don't declare.
2183         * parse.c (parse_completion, expout_last_struct)
2184         (expout_tag_completion_type, expout_completion_name): Remove
2185         globals.
2186         (parser_state::mark_struct_expression)
2187         (parser_state::mark_completion_tag): Now methods.
2188         (prefixify_expression): Add last_struct parameter.
2189         (prefixify_subexp): Likewise.
2190         (parse_exp_1): Update.
2191         (parse_exp_in_context): Add cstate parameter.  Update.
2192         (parse_expression_for_completion): Create an
2193         expr_completion_state.
2194         (null_post_parser): Add "completion" parameter.
2195         * p-exp.y: Update rules.
2196         (yylex): Update.
2197         * language.h (struct language_defn) <la_post_parser>: Add
2198         "completing" parameter.
2199         * go-exp.y: Update rules.
2200         (lex_one_token): Update.
2201         * expression.h (parse_completion): Don't declare.
2202         * d-exp.y: Update rules.
2203         (lex_one_token): Update rules.
2204         * c-exp.y: Update rules.
2205         (lex_one_token): Update.
2206         * ada-lang.c (resolve): Add "parse_completion" parameter.
2207         (resolve_subexp): Likewise.
2208         (ada_resolve_function): Likewise.
2209
2210 2019-04-04  Tom Tromey  <tom@tromey.com>
2211
2212         * parser-defs.h (struct parser_state) <start_arglist,
2213         end_arglist>: New methods.
2214         <arglist_len, m_funcall_chain>: New members.
2215         (arglist_len, start_arglist, end_arglist): Don't declare.
2216         * parse.c (arglist_len, funcall_chain): Remove global.
2217         (start_arglist, end_arglist): Remove functions.
2218         (parse_exp_in_context): Update.
2219         * p-exp.y: Update rules.
2220         * m2-exp.y: Update rules.
2221         * go-exp.y: Update rules.
2222         * f-exp.y: Update rules.
2223         * d-exp.y: Update rules.
2224         * c-exp.y: Update rules.
2225
2226 2019-04-04  Tom Tromey  <tom@tromey.com>
2227
2228         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2229         lex_operator, push_back>: New methods.
2230         Update all rules.
2231         (rust_parser::lex_hex, lex_escape): Rename and update.
2232         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2233         (rust_parser::lex_operator): Rename and update.
2234         (rust_parser::lex_number, rustyylex, rustyyerror)
2235         (rust_lex_test_init, rust_lex_test_sequence)
2236         (rust_lex_test_push_back, rust_lex_tests): Update.
2237         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2238         parameter.
2239         <lexptr, prev_lexptr>: New members.
2240         (lexptr, prev_lexptr): Don't declare.
2241         * parse.c (lexptr, prev_lexptr): Remove globals.
2242         (parse_exp_in_context): Update.
2243         * p-exp.y (yylex, yyerror): Update.
2244         * m2-exp.y (parse_number, yylex, yyerror): Update.
2245         * go-exp.y (lex_one_token, yyerror): Update.
2246         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2247         * d-exp.y (lex_one_token, yyerror): Update.
2248         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2249         (lex_one_token, yyerror): Update.
2250         * ada-lex.l (YY_INPUT): Update.
2251         (rewind_to_char): Update.
2252         * ada-exp.y (yyerror): Update.
2253
2254 2019-04-04  Tom Tromey  <tom@tromey.com>
2255
2256         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2257         * parser-defs.h (struct parser_state) <parser_state>: Add new
2258         parameter.
2259         <comma_terminates>: New member.
2260         (comma_terminates): Don't declare global.
2261         * parse.c (comma_terminates): Remove global.
2262         (parse_exp_in_context): Update.
2263         * p-exp.y (yylex): Update.
2264         * m2-exp.y (yylex): Update.
2265         * go-exp.y (lex_one_token): Update.
2266         * f-exp.y (yylex): Update.
2267         * d-exp.y (lex_one_token): Update.
2268         * c-exp.y (lex_one_token): Update.
2269         * ada-lex.l: Update.
2270
2271 2019-04-04  Tom Tromey  <tom@tromey.com>
2272
2273         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2274         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2275         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2276         * parser-defs.h (paren_depth): Don't declare.
2277         * parse.c (paren_depth): Remove global.
2278         (parse_exp_in_context): Update.
2279         * p-exp.y (paren_depth): New global.
2280         (pascal_parse): Initialize it.
2281         * m2-exp.y (paren_depth): New global.
2282         (m2_parse): Initialize it.
2283         * go-exp.y (paren_depth): New global.
2284         (go_parse): Initialize it.
2285         * f-exp.y (paren_depth): New global.
2286         (f_parse): Initialize it.
2287         * d-exp.y (paren_depth): New global.
2288         (d_parse): Initialize it.
2289         * c-exp.y (paren_depth): New global.
2290         (c_parse): Initialize it.
2291         * ada-lex.l (paren_depth): New global.
2292         (lexer_init): Initialize it.
2293
2294 2019-04-04  Tom Tromey  <tom@tromey.com>
2295
2296         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2297         (rust_parser::convert_ast_to_type)
2298         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2299         * parser-defs.h (struct parser_state) <parser_state>: Add
2300         parameters.  Initialize new members.
2301         <expression_context_block, expression_context_pc>: New members.
2302         * parse.c (expression_context_block, expression_context_pc):
2303         Remove globals.
2304         (parse_exp_in_context): Update.
2305         * p-exp.y: Update all rules.
2306         (yylex): Update.
2307         * m2-exp.y: Update all rules.
2308         (yylex): Update.
2309         * go-exp.y (yylex): Update.
2310         * f-exp.y (yylex): Update.
2311         * d-exp.y: Update all rules.
2312         (yylex): Update.
2313         * c-exp.y: Update all rules.
2314         (lex_one_token, classify_name, yylex, c_parse): Update.
2315         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2316
2317 2019-04-04  Tom Tromey  <tom@tromey.com>
2318
2319         * gdbarch.h, gdbarch.c: Rebuild.
2320         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2321         * stap-probe.h:
2322         (struct stap_parse_info): Replace "parser_state" with
2323         "expr_builder".
2324         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2325         (parser_state): New class.
2326         * parse.c (expr_builder): Rename.
2327         (expr_builder::release): Rename.
2328         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2329         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2330         (write_exp_elt_longcst, write_exp_elt_floatcst)
2331         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2332         (write_exp_string_vector, write_exp_bitstring)
2333         (write_exp_msymbol, mark_struct_expression)
2334         (write_dollar_variable)
2335         (insert_type_address_space, increase_expout_size): Replace
2336         "parser_state" with "expr_builder".
2337         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2338         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2339         "parser_state" with "expr_builder".
2340
2341 2019-04-04  Tom Tromey  <tom@tromey.com>
2342
2343         * rust-exp.y: Replace "parse_language" with method call.
2344         * p-exp.y:
2345         (yylex): Replace "parse_language" with method call.
2346         * m2-exp.y:
2347         (yylex): Replace "parse_language" with method call.
2348         * go-exp.y (classify_name): Replace "parse_language" with method
2349         call.
2350         * f-exp.y (yylex): Replace "parse_language" with method call.
2351         * d-exp.y (lex_one_token): Replace "parse_language" with method
2352         call.
2353         * c-exp.y:
2354         (lex_one_token, classify_name, yylex): Replace "parse_language"
2355         with method call.
2356         * ada-exp.y (find_primitive_type, type_char)
2357         (type_system_address): Replace "parse_language" with method call.
2358
2359 2019-04-04  Tom Tromey  <tom@tromey.com>
2360
2361         * rust-exp.y: Replace "parse_gdbarch" with method call.
2362         * parse.c (write_dollar_variable, insert_type_address_space):
2363         Replace "parse_gdbarch" with method call.
2364         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2365         call.
2366         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2367         call.
2368         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2369         "parse_gdbarch" with method call.
2370         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2371         with method call.
2372         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2373         "parse_gdbarch" with method call.
2374         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2375         "parse_gdbarch" with method call.
2376         * c-exp.y (parse_type, parse_number, classify_name): Replace
2377         "parse_gdbarch" with method call.
2378         * ada-lex.l: Replace "parse_gdbarch" with method call.
2379         * ada-exp.y (parse_type, find_primitive_type, type_char)
2380         (type_system_address): Replace "parse_gdbarch" with method call.
2381
2382 2019-04-04  Tom Tromey  <tom@tromey.com>
2383
2384         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2385         * stap-probe.c (stap_parse_argument): Update.
2386         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2387         initial_size parameter.
2388         * rust-exp.y (rust_lex_tests): Update.
2389         * parse.c (parser_state): Update.
2390         (parse_exp_in_context): Update.
2391         * parser-defs.h (struct parser_state) <parser_state>: Remove
2392         "initial_size" parameter.
2393
2394 2019-04-04  Tom Tromey  <tom@tromey.com>
2395
2396         * parser-defs.h (increase_expout_size): Don't declare.
2397         * parse.c (increase_expout_size): Now static.
2398
2399 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2400
2401         * gnu-nat.c (gnu_nat_target::wait): Fix
2402         target_waitstatus_to_string call.
2403
2404 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * eval.c (evaluate_subexp_standard): Handle internal functions
2407         during Fortran function call handling.
2408
2409 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2410
2411         * NEWS: Mention new internal functions.
2412         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2413         (read_base_type): Use dwarf2_init_complex_target_type.
2414         * value.c (creal_internal_fn): New function.
2415         (cimag_internal_fn): New function.
2416         (_initialize_values): Register new internal functions.
2417
2418 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2419
2420         * infrun.c (stop_all_threads): If debug_infrun, always
2421         trace the wait status after wait_one, using
2422         target_waitstatus_to_string and target_pid_to_str.
2423         (handle_inferior_event): Replace various trace of
2424         wait status kind by a single trace.
2425         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2426         wait status kind image by target_waitstatus_to_string.
2427         * target/waitstatus.c (target_waitstatus_to_string): Fix
2428         obsolete comment.
2429
2430 2019-04-01  Tom Tromey  <tromey@adacore.com>
2431
2432         PR symtab/23331:
2433         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2434
2435 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2436             Pedro Alves  <palves@redhat.com>
2437
2438         * top.c (quit_force): Call 'finalize_values'.
2439         * value.c (finalize_values): New function.
2440         * value.h (finalize_values): Declare.
2441
2442 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2443
2444         * NEWS: Announce $_gdb_major and $_gdb_minor.
2445
2446         * top.c (init_gdb_version_vars): New function.
2447         (gdb_init): Call init_gdb_version_vars.
2448
2449 2019-03-29  Tom Tromey  <tromey@adacore.com>
2450
2451         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2452         help text.  Remove dead code.
2453
2454 2019-03-29  Keith Seitz  <keiths@redhat.com>
2455
2456         From Siddhesh Poyarekar:
2457         * f-lang.h (f77_get_upperbound): Return LONGEST.
2458         (f77_get_lowerbound): Likewise.
2459         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2460         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2461         print them.
2462         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2463         plongest to format print it.
2464         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2465         (f77_get_upperbound): Likewise.
2466         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2467         LOWER_BOUND to LONGEST.
2468         (f77_create_arrayprint_offset_tbl): Likewise.
2469
2470 2019-03-29  Keith Seitz  <keiths@redhat.com>
2471
2472         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2473         %s/pulongest for TYPE_LENGTH instead of %d in format
2474         strings.
2475         * ada-typerint.c (ada_print_type): Likewise.
2476         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2477         * compile/compile-c-support.c (generate_register_struct): Likewise.
2478         * gdbtypes.c (recursive_dump_type): Likewise.
2479         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2480         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2481         instead of %d in format strings.
2482         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2483         to std::min to ULONGEST.
2484         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2485         instead of %d in format strings.
2486         * tracepoint.c (info_scope_command): Likewise.
2487         * typeprint.c (print_offset_data::update)
2488         (print_offset_data::finish): Likewise.
2489         * xtensa-tdep.c (xtensa_store_return_value)
2490         (xtensa_push_dummy_call): Likewise.
2491
2492 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2493
2494         * windows-nat.c (display_selector): Fixed format specifications
2495         for 64-bit Cygwin.
2496
2497 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2498
2499         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2500
2501 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2502
2503         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2504         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2505         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2506         (nios2_linux_init_abi): Install it.
2507
2508 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2509
2510         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2511
2512 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2513
2514         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2515
2516 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2517             Tom Tromey  <tromey@adacore.com>
2518
2519         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2520
2521 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2522
2523         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2524         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2525         method to compute the bounds of range types. Also print "[evaluated]"
2526         if the bounds' values come from a dynamic evaluation.
2527
2528 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2531         whitespace when pretty printing is on.
2532
2533 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2534
2535         * ppc-linux-nat.c: Add include.
2536
2537 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2538
2539         * NEWS: Mention AArch64 Pointer Authentication.
2540
2541 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2542
2543         * arm-linux-nat.c: Add include.
2544
2545 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2546
2547         * source-cache.c (source_cache::get_source_lines): Re-read
2548         fullname after calling open_source_file.
2549
2550 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2551
2552         * NEWS: Mention TLS support for FreeBSD.
2553
2554 2019-03-25  Tom Tromey  <tromey@adacore.com>
2555
2556         * minsyms.c (BUNCH_SIZE): Update comment.
2557         (~minimal_symbol_reader): Remove old comment.
2558         (compact_minimal_symbols): Update comment.
2559         (minimal_symbol_reader::install): Remove old comment.  Update
2560         other comments.
2561
2562 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2563
2564         * s390-linux-nat.c: Add include.
2565
2566 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2567
2568         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2569         Call linux_get_hwcap.
2570         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2571         Likewise.
2572         (aarch64_linux_get_hwcap): Remove function.
2573         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2574         declaration.
2575         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2576         linux_get_hwcap.
2577         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2578         * linux-tdep.c (linux_get_hwcap): Add function.
2579         (linux_get_hwcap2): Likewise.
2580         * linux-tdep.h (linux_get_hwcap): Add declaration.
2581         (linux_get_hwcap2): Likewise.
2582         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2583         (ppc_linux_get_hwcap2): Likewise.
2584         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2585         linux_get_hwcap.
2586         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2587         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2588         (ppc_linux_nat_target::read_description): Likewise.
2589         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2590         * s390-linux-nat.c: Likewise.
2591         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2592
2593 2019-03-24  Tom Tromey  <tom@tromey.com>
2594
2595         * ada-lang.c (standard_lookup): Simplify initialization.
2596         (ada_lookup_symbol_nonlocal): Simplify return.
2597         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2598         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2599         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2600         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2601         initialization.
2602         * solib.c (solib_global_lookup): Simplify.
2603         * symtab.c (null_block_symbol): Remove.
2604         (symbol_cache_lookup): Simplify returns.
2605         (lookup_language_this): Simplify returns.
2606         (lookup_symbol_aux): Simplify return.
2607         (lookup_local_symbol): Simplify returns.
2608         (lookup_global_symbol_from_objfile): Simplify return.
2609         (lookup_symbol_in_objfile_symtabs)
2610         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2611         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2612         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2613         * cp-namespace.c (cp_lookup_bare_symbol)
2614         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2615         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2616         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2617         (cp_lookup_symbol_via_imports): Simplify initialization.
2618         (find_symbol_in_baseclass): Likewise.
2619         * symtab.h (null_block_symbol): Remove.
2620         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2621         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2622         (d_lookup_symbol_module): Likewise.
2623         (find_symbol_in_baseclass): Simplify initialization.
2624
2625 2019-03-24  Tom Tromey  <tom@tromey.com>
2626
2627         * expression.h: Don't include symtab.h.
2628         (struct block): Forward declare.
2629
2630 2019-03-24  Tom Tromey  <tom@tromey.com>
2631
2632         * c-exp.y (typebase): Remove casts.
2633         * gdbtypes.c (lookup_unsigned_typename, )
2634         (lookup_signed_typename): Remove cast.
2635         * eval.c (parse_to_comma_and_eval): Remove cast.
2636         * parse.c (write_dollar_variable): Remove cast.
2637         * block.h (struct block) <superblock>: Now const.
2638         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2639         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2640         (map_block): Make "block" const.
2641         * symfile.h (struct quick_symbol_functions)
2642         <map_matching_symbols>: Constify block argument to "callback".
2643         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2644         const.
2645         (find_pc_sect_compunit_symtab): Make "b" const.
2646         (find_symbol_at_address): Likewise.
2647         (search_symbols): Likewise.
2648         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2649         (dw2_debug_names_lookup_symbol): Likewise.
2650         (dw2_map_matching_symbols): Update.
2651         * p-valprint.c (pascal_val_print): Remove "block".
2652         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2653         (aux_add_nonlocal_symbols): Make "block" const.
2654         (resolve_subexp): Remove cast.
2655         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2656         const.
2657         (iterate_over_file_blocks): Likewise.
2658         * f-exp.y (%union) <bval>: Remove.
2659         * coffread.c (patch_opaque_types): Make "b" const.
2660         * spu-tdep.c (spu_catch_start): Make "block" const.
2661         * c-valprint.c (print_unpacked_pointer): Remove "block".
2662         * symmisc.c (dump_symtab_1): Make "b" const.
2663         (block_depth): Make "block" const.
2664         * d-exp.y (%union) <bval>: Remove.
2665         * cp-support.h (cp_lookup_rtti_type): Update.
2666         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2667         * psymtab.c (psym_lookup_symbol): Make "block" const.
2668         (maintenance_check_psymtabs): Make "b" const.
2669         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2670         (enumerate_locals, enumerate_args): Update.
2671         * python/py-symtab.c (stpy_global_block): Make "block" const.
2672         (stpy_static_block): Likewise.
2673         * inline-frame.c (block_starting_point_at): Make "new_block"
2674         const.
2675         * block.c (find_block_in_blockvector): Make return type const.
2676         (blockvector_for_pc_sect): Make "b" const.
2677         (find_block_in_blockvector): Make "b" const.
2678
2679 2019-03-23  Tom Tromey  <tom@tromey.com>
2680
2681         * varobj.c (varobj_create): Update.
2682         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2683         * printcmd.c (display_command, do_one_display): Don't reset
2684         innermost_block.
2685         * parser-defs.h (enum innermost_block_tracker_type): Move to
2686         expression.h.
2687         (innermost_block): Update comment.
2688         * parse.c (parse_exp_1): Add tracker_types parameter.
2689         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2690         tracker_types parameter.  Reset innermost_block.
2691         (parse_exp_in_context): Remove.
2692         (parse_expression_for_completion): Update.
2693         * objfiles.c (~objfile): Don't reset expression_context_block or
2694         innermost_block.
2695         * expression.h (enum innermost_block_tracker_type): Move from
2696         parser-defs.h.
2697         (parse_exp_1): Add tracker_types parameter.
2698         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2699         reset innermost_block.
2700
2701 2019-03-23  Tom Tromey  <tom@tromey.com>
2702
2703         * objfiles.h: Include bcache.h.
2704
2705 2019-03-23  Tom Tromey  <tom@tromey.com>
2706
2707         * linespec.c (get_current_search_block): Use
2708         scoped_restore_current_language.
2709         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2710
2711 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2712             Jiong Wang  <jiong.wang@arm.com>
2713
2714         * aarch64-linux-tdep.c
2715         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2716         section.
2717         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2718
2719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2720             Jiong Wang  <jiong.wang@arm.com>
2721
2722         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2723         instructions.
2724         (aarch64_analyze_prologue_test): Add PACIASP test.
2725         (aarch64_prologue_prev_register): Unmask PC value.
2726
2727 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2728             Jiong Wang  <jiong.wang@arm.com>
2729
2730         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2731         (aarch64_dwarf2_prev_register): Unmask PC value.
2732         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2733         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2734         DW_CFA_AARCH64_negate_ra_state.
2735         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2736
2737 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2738             Jiong Wang  <jiong.wang@arm.com>
2739
2740         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2741         registers.
2742         (aarch64_pseudo_register_name): Likewise.
2743         (aarch64_pseudo_register_type): Likewise.
2744         (aarch64_pseudo_register_reggroup_p): Likewise.
2745         (aarch64_gdbarch_init): Add pauth registers.
2746         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2747         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2748         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2749         (struct gdbarch_tdep): Add regnum for ra_state.
2750
2751 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2752             Jiong Wang  <jiong.wang@arm.com>
2753
2754         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2755
2756 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2757             Jiong Wang  <jiong.wang@arm.com>
2758
2759         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2760         function.
2761         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2762         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2763         (aarch64_gdbarch_init): Add puth registers.
2764         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2765         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2766         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2767
2768 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2769             Jiong Wang  <jiong.wang@arm.com>
2770
2771         * aarch64-linux-nat.c
2772         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2773         * aarch64-linux-tdep.c
2774         (aarch64_linux_core_read_description): Likewise.
2775         (aarch64_linux_get_hwcap): New function.
2776         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2777         (aarch64_linux_get_hwcap): New declaration.
2778
2779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2780             Jiong Wang  <jiong.wang@arm.com>
2781
2782         * aarch64-linux-nat.c
2783         (aarch64_linux_nat_target::read_description): Add pauth param.
2784         * aarch64-linux-tdep.c
2785         (aarch64_linux_core_read_description): Likewise.
2786         * aarch64-tdep.c (struct target_desc): Add in pauth.
2787         (aarch64_read_description): Add pauth param.
2788         (aarch64_gdbarch_init): Likewise.
2789         * aarch64-tdep.h (aarch64_read_description): Likewise.
2790         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2791         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2792         * features/Makefile: Add new files.
2793         * features/aarch64-pauth.c: New file.
2794         * features/aarch64-pauth.xml: New file.
2795
2796 2019-03-20  Tom Tromey  <tromey@adacore.com>
2797
2798         * infrun.c (handle_inferior_event): Rename from
2799         handle_inferior_event_1.  Create a scoped_value_mark.
2800         (handle_inferior_event): Remove.
2801
2802 2019-03-19  Tom Tromey  <tromey@adacore.com>
2803
2804         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2805         * infrun.h (print_stop_event): Add "displays" parameter.
2806         * infrun.c (print_stop_event): Add "displays" parameter.
2807
2808 2019-03-19  Pedro Alves  <palves@redhat.com>
2809
2810         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2811         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2812         to -1.  Fix TABs vs spaces.
2813         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2814         * tui/tui-out.h (tui_ui_out) Add intro comments.
2815         <m_line, m_start_of_line>: In-class initialize, and add describing
2816         comment.
2817
2818 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2819
2820         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2821         variable names.
2822         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2823
2824 2019-03-18  Pedro Alves  <palves@redhat.com>
2825             Eli Zaretskii <eliz@gnu.org>
2826
2827         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2828         m_line and m_start_of_line.
2829
2830 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2831
2832         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2833         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2834         it returns a newline.  This fixes a regression in TU mode, whereby
2835         the next line is output on the same screen line as the user input.
2836
2837 2019-03-18  Tom Tromey  <tromey@adacore.com>
2838
2839         * minsyms.c (minimal_symbol_reader::install): Remove call to
2840         obstack_blank.
2841
2842 2019-03-18  Pedro Alves  <palves@redhat.com>
2843
2844         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2845         New globals.
2846         (apply_style): New, factored out from ...
2847         (apply_ansi_escape): ... this.  Handle reverse video mode.
2848         (tui_set_reverse_mode): New function.
2849         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2850         * tui/tui-winsource.c (tui_show_source_line): Use
2851         tui_set_reverse_mode instead of setting A_STANDOUT.
2852         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2853         New setter methods.
2854
2855 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2856
2857         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2858         Handle tabs.
2859
2860 2019-03-18  Tom Tromey  <tromey@adacore.com>
2861
2862         * ada-lang.c (empty_array): Add "high" parameter.
2863         (ada_evaluate_subexp): Update.
2864
2865 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2866
2867         * unittests/string_view-selftests.c: Define
2868         _initialize_string_view_selftests unconditionally.
2869
2870 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2871
2872         PR gdb/24350
2873         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2874
2875 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2876
2877         PR gdb/24351
2878         * windows-nat.c (display_selector): Fix format specifiers.
2879
2880 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2881
2882         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2883         tui_refill_source_window instead of tui_refresh_win, to update the
2884         current execution line.  This fixes redisplay of the current line
2885         when stepping through the code with "next" or "step".
2886
2887 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2888
2889         * source-cache.c (source_cache::get_source_lines): Call
2890         find_source_lines to initialize s->nlines.  This fixes vertical
2891         scrolling of TUI source window when the DOWN arrow is pressed.
2892
2893 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2894
2895         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2896         linux-thread-db.c (_initialize_thread_db): Likewise.
2897
2898 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2899
2900         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2901         wclrtoeol in tui_show_source_line".  This reverts changes made in
2902         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2903
2904 2019-03-15  Tom Tromey  <tom@tromey.com>
2905
2906         * symtab.h (struct minimal_symbol): Derive from
2907         general_symbol_info.
2908         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2909         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2910         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2911         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2912         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2913         (MSYMBOL_SEARCH_NAME): Update.
2914         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2915         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2916         * minsyms.c (minimal_symbol_reader::record_full): Update.
2917
2918 2019-03-15  Tom Tromey  <tom@tromey.com>
2919
2920         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2921
2922 2019-03-15  Tom Tromey  <tom@tromey.com>
2923
2924         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2925         unique_xmalloc_ptr.
2926         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2927         Update.
2928         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2929         (build_minimal_symbol_hash_tables)
2930         (minimal_symbol_reader::install): Update.
2931
2932 2019-03-15  Tom Tromey  <tom@tromey.com>
2933
2934         * symtab.c (create_demangled_names_hash): Update.
2935         (symbol_set_names): Update.
2936         * objfiles.h (struct objfile_per_bfd_storage)
2937         <demangled_names_hash>: Now an htab_up.
2938         * objfiles.c (objfile_per_bfd_storage): Simplify.
2939
2940 2019-03-15  Tom Tromey  <tom@tromey.com>
2941
2942         * objfiles.h (struct objfile_per_bfd_storage): Declare
2943         destructor.
2944         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2945         New.
2946         (get_objfile_bfd_data): Use new.  Don't initialize
2947         language_of_main.
2948         (free_objfile_per_bfd_storage): Remove.
2949         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2950
2951 2019-03-15  Tom Tromey  <tom@tromey.com>
2952
2953         * symfile.c (reread_symbols): Update.
2954         * objfiles.c (objfile::objfile): Update.
2955         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2956         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2957         comment.
2958         (minimal_symbol_reader::install): Update.
2959         (terminate_minimal_symbol_table): Remove.
2960         * jit.c (jit_object_close_impl): Update.
2961
2962 2019-03-15  Tom Tromey  <tom@tromey.com>
2963
2964         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2965         initializations.
2966
2967 2019-03-15  Tom Tromey  <tom@tromey.com>
2968
2969         * objfiles.h (struct objfile_per_bfd_storage)
2970         <demangled_hash_languages>: Now a bitset.
2971         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2972         (lookup_minimal_symbol): Update.
2973
2974 2019-03-15  Tom Tromey  <tom@tromey.com>
2975
2976         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2977         Don't return the symbol.
2978         * coffread.c (record_minimal_symbol): Use record_full.
2979
2980 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2981
2982         The MS-Windows port of ncurses fails to switch to a color pair if
2983         one or both of the colors are the implicit default colors.  This
2984         change records the default colors when TUI is initialized, and
2985         then specifies them explicitly when a color pair uses the default
2986         colors.  This allows color styling in TUI mode on MS-Windows.
2987
2988         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2989         ncurses_norm_attr.
2990         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2991         colors in ncurses_norm_attr.
2992         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2993         "none", replace it with the default color recorded in
2994         ncurses_norm_attr.
2995
2996 2019-03-14  Tom Tromey  <tromey@adacore.com>
2997
2998         * source-cache.h (class source_cache) <get_source_lines>: Return
2999         std::string.
3000         * source-cache.c (source_cache::extract_lines): Handle case where
3001         first_pos==npos.  Return std::string.
3002         (source_cache::get_source_lines): Update.
3003
3004 2019-03-14  Tom Tromey  <tromey@adacore.com>
3005
3006         * NEWS: Add item for "style sources" commands.
3007         * source-cache.c (source_cache::get_source_lines): Check
3008         source_styling.
3009         * cli/cli-style.c (source_styling): New global.
3010         (_initialize_cli_style): Add "style sources" commands.
3011         (show_style_sources): New function.
3012         * cli/cli-style.h (source_styling): Declare.
3013
3014 2019-03-14  Pedro Alves  <palves@redhat.com>
3015             Tom Tromey  <tromey@adacore.com>
3016
3017         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3018         * tui/tui-winsource.c (tui_refill_source_window): New function,
3019         from...
3020         (tui_horizontal_source_scroll): ... here.  Move some logic.
3021         * cli/cli-style.c (set_style_enabled): Notify new observable.
3022         * tui/tui-hooks.c (tui_redisplay_source): New function.
3023         (tui_attach_detach_observers): Attach or detach
3024         tui_redisplay_source.
3025         * observable.h (source_styling_changed): New observable.
3026         * observable.c: Define source_styling_changed observable.
3027
3028 2019-03-13  Tom Tromey  <tromey@adacore.com>
3029
3030         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3031         (i386_gnu_nat_target::store_registers): Update.
3032         * target-debug.h (target_debug_print_std_string): New macro.
3033         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3034         * windows-tdep.c (display_one_tib): Update.
3035         * tui/tui-stack.c (tui_make_status_line): Update.
3036         * top.c (print_inferior_quit_action): Update.
3037         * thread.c (thr_try_catch_cmd): Update.
3038         (add_thread_with_info): Update.
3039         (thread_target_id_str): Update.
3040         (thr_try_catch_cmd): Update.
3041         (thread_command): Update.
3042         (thread_find_command): Update.
3043         * record-btrace.c (record_btrace_target::info_record)
3044         (record_btrace_resume_thread, record_btrace_target::resume)
3045         (record_btrace_cancel_resume, record_btrace_step_thread)
3046         (record_btrace_target::wait, record_btrace_target::wait)
3047         (record_btrace_target::wait, record_btrace_target::stop): Update.
3048         * progspace.c (print_program_space): Update.
3049         * process-stratum-target.c
3050         (process_stratum_target::thread_address_space): Update.
3051         * linux-fork.c (linux_fork_mourn_inferior)
3052         (detach_checkpoint_command, info_checkpoints_command)
3053         (linux_fork_context): Update.
3054         (linux_fork_detach): Update.
3055         (class scoped_switch_fork_info): Update.
3056         (delete_checkpoint_command): Update.
3057         * infrun.c (follow_fork_inferior): Update.
3058         (follow_fork_inferior): Update.
3059         (proceed_after_vfork_done): Update.
3060         (handle_vfork_child_exec_or_exit): Update.
3061         (follow_exec): Update.
3062         (displaced_step_prepare_throw): Update.
3063         (displaced_step_restore): Update.
3064         (start_step_over): Update.
3065         (resume_1): Update.
3066         (clear_proceed_status_thread): Update.
3067         (proceed): Update.
3068         (print_target_wait_results): Update.
3069         (do_target_wait): Update.
3070         (context_switch): Update.
3071         (stop_all_threads): Update.
3072         (restart_threads): Update.
3073         (finish_step_over): Update.
3074         (handle_signal_stop): Update.
3075         (switch_back_to_stepped_thread): Update.
3076         (keep_going_pass_signal): Update.
3077         (print_exited_reason): Update.
3078         (normal_stop): Update.
3079         * inferior.c (inferior_pid_to_str): Change return type.
3080         (print_selected_inferior): Update.
3081         (add_inferior): Update.
3082         (detach_inferior): Update.
3083         * dummy-frame.c (fprint_dummy_frames): Update.
3084         * dcache.c (dcache_info_1): Update.
3085         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3086         (btrace_fetch, btrace_clear): Update.
3087         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3088         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3089         type.
3090         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3091         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3092         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3093         * gdbarch.c, gdbarch.h: Rebuild.
3094         * gdbarch.sh (core_pid_to_str): Change return type.
3095         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3096         return type.
3097         (windows_nat_target::pid_to_str): Change return type.
3098         (windows_delete_thread): Update.
3099         (windows_nat_target::attach): Update.
3100         (windows_nat_target::files_info): Update.
3101         * target-delegates.c: Rebuild.
3102         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3103         return type.
3104         (sol_thread_target::pid_to_str): Change return type.
3105         * remote.c (class remote_target) <pid_to_str>: Change return
3106         type.
3107         (remote_target::pid_to_str): Change return type.
3108         (extended_remote_target::attach, remote_target::remote_stop_ns)
3109         (remote_target::remote_notif_remove_queued_reply)
3110         (remote_target::push_stop_reply, remote_target::disable_btrace):
3111         Update.
3112         (extended_remote_target::attach): Update.
3113         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3114         type.
3115         (gdbsim_target::pid_to_str): Change return type.
3116         * ravenscar-thread.c (struct ravenscar_thread_target)
3117         <pid_to_str>: Change return type.
3118         (ravenscar_thread_target::pid_to_str): Change return type.
3119         * procfs.c (class procfs_target) <pid_to_str>: Change return
3120         type.
3121         (procfs_target::pid_to_str): Change return type.
3122         (procfs_target::attach): Update.
3123         (procfs_target::detach): Update.
3124         (procfs_target::fetch_registers): Update.
3125         (procfs_target::store_registers): Update.
3126         (procfs_target::wait): Update.
3127         (procfs_target::files_info): Update.
3128         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3129         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3130         return type.
3131         (nto_procfs_target::pid_to_str): Change return type.
3132         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3133         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3134         return type.
3135         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3136         (exit_lwp): Update.
3137         (attach_proc_task_lwp_callback, get_detach_signal)
3138         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3139         (linux_nat_target::resume, wait_lwp, stop_callback)
3140         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3141         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3142         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3143         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3144         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3145         type.
3146         (inf_ptrace_target::attach): Update.
3147         (inf_ptrace_target::files_info): Update.
3148         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3149         type.
3150         (go32_nat_target::pid_to_str): Change return type.
3151         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3152         (gnu_nat_target::wait): Update.
3153         (gnu_nat_target::wait): Update.
3154         (gnu_nat_target::resume): Update.
3155         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3156         (fbsd_nat_target::wait): Update.
3157         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3158         type.
3159         (darwin_nat_target::attach): Update.
3160         * corelow.c (class core_target) <pid_to_str>: Change return type.
3161         (core_target::pid_to_str): Change return type.
3162         * target.c (normal_pid_to_str): Change return type.
3163         (default_pid_to_str): Likewise.
3164         (target_pid_to_str): Change return type.
3165         (target_translate_tls_address): Update.
3166         (target_announce_detach): Update.
3167         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3168         return type.
3169         (bsd_uthread_target::pid_to_str): Change return type.
3170         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3171         type.
3172         (bsd_kvm_target::pid_to_str): Change return type.
3173         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3174         return type.
3175         (aix_thread_target::pid_to_str): Change return type.
3176         * target.h (struct target_ops) <pid_to_str>: Change return type.
3177         (target_pid_to_str, normal_pid_to_str): Likewise.
3178         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3179         type.
3180         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3181         type.
3182         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3183         return type.
3184         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3185         type.
3186         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3187         type.
3188         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3189         return type.
3190
3191 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3192
3193         * NEWS: Mention that the new default MI version is 3.  Mention
3194         changes to the output of commands and events that deal with
3195         multi-location breakpoints.
3196         * breakpoint.c: Include "mi/mi-out.h".
3197         (print_one_breakpoint): Change output syntax if using MI version
3198         >= 3.
3199         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3200         New.
3201         (mi_multi_location_breakpoint_output_fixed): New.
3202         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3203         (mi_cmd_fix_multi_location_breakpoint_output): New.
3204         (mi_multi_location_breakpoint_output_fixed): New.
3205         * mi/mi-cmds.c (mi_cmds): Register command
3206         -fix-multi-location-breakpoint-output.
3207         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3208         interpreter "mi".
3209
3210 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3211
3212         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3213         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3214         instantiate mi_ui_out based on interpreter name.
3215         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3216         * mi/mi-main.c (mi_load_progress): Likewise.
3217
3218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3219
3220         * NEWS: Combine separate "New targets" sections for 8.3.
3221
3222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3223
3224         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3225         (ppcfbsd_init_abi): Install gdbarch
3226         "fetch_tls_load_module_address" and "get_thread_local_address"
3227         methods.
3228
3229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3230
3231         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3232         (riscv_fbsd_init_abi): Install gdbarch
3233         "fetch_tls_load_module_address" and "get_thread_local_address"
3234         methods.
3235
3236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3237
3238         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3239         (i386fbsd_init_abi): Install gdbarch
3240         "fetch_tls_load_module_address" and "get_thread_local_address"
3241         methods.
3242
3243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3244
3245         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3246         (amd64fbsd_init_abi): Install gdbarch
3247         "fetch_tls_load_module_address" and "get_thread_local_address"
3248         methods.
3249
3250 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3251
3252         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3253         (struct fbsd_pspace_data): New type.
3254         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3255         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3256         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3257         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3258         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3259
3260 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3261
3262         * gdbtypes.c (lookup_struct_elt): New function.
3263         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3264         * gdbtypes.h (struct struct_elt): New type.
3265         (lookup_struct_elt): New prototype.
3266
3267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3268
3269         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3270         remove disabled code block.
3271
3272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3273
3274         * gdbarch.sh (get_thread_local_address): New method.
3275         * gdbarch.h, gdbarch.c: Regenerate.
3276         * target.c (target_translate_tls_address): Use
3277         gdbarch_get_thread_local_address if present instead of
3278         target::get_thread_local_address.
3279
3280 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3281
3282         * target.h (target::get_thread_local_address): Update comment.
3283
3284 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3285
3286         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3287         objfile->separate_debug_objfile_backlink if not NULL.
3288
3289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3290
3291         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3292         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3293         (amd64bsd_store_inferior_registers): Likewise.
3294         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3295         Enable segment base registers.
3296         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3297         PT_GETFSBASE and PT_GETGSBASE.
3298         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3299         PT_SETGSBASE.
3300         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3301         segment base registers.
3302         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3303
3304 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3305
3306         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3307         Update calls to i386_target_description to add 'segments'
3308         parameter.
3309         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3310         add segment base registers.
3311         * arch/i386.c (i386_create_target_description): Add 'segments'
3312         parameter to enable segment base registers.
3313         * arch/i386.h (i386_create_target_description): Likewise.
3314         * features/i386/32bit-segments.xml: New file.
3315         * features/i386/32bit-segments.c: Generate.
3316         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3317         call to i386_target_description to add 'segments' parameter.
3318         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3319         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3320         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3321         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3322         if feature is present.
3323         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3324         Add 'segments' parameter to call to i386_target_description.
3325         (i386_target_description): Add 'segments' parameter to enable
3326         segment base registers.
3327         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3328         to call to i386_target_description.
3329         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3330         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3331         Define I386_NUM_REGS.
3332         (i386_target_description): Add 'segments' parameter to enable
3333         segment base registers.
3334
3335 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3336
3337         PR/24325
3338         * source-cache.c: #undef open and close, to avoid unresolved
3339         externals during linking.
3340
3341 2019-03-12  Tom Tromey  <tromey@adacore.com>
3342
3343         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3344         const.  Add initializers.
3345         (_initialize_remote): Don't initialize ptid globals.
3346
3347 2019-03-12  Pedro Alves  <palves@redhat.com>
3348
3349         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3350
3351 2019-03-12  Pedro Alves  <palves@redhat.com>
3352
3353         * cp-name-parser.y (main): Remove unused 'len' variable.
3354
3355 2019-03-12  Tom Tromey  <tromey@adacore.com>
3356
3357         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3358         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3359
3360 2019-03-12  Tom Tromey  <tromey@adacore.com>
3361
3362         * linux-nat.c (iterate_over_lwps): Update.
3363         (stop_callback): Remove parameter.
3364         (stop_wait_callback, detach_callback, resume_set_callback)
3365         (select_singlestep_lwp_callback, set_ignore_sigint)
3366         (status_callback, resumed_callback, resume_clear_callback)
3367         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3368         data parameter.
3369         (linux_nat_target::detach, linux_nat_target::resume)
3370         (linux_stop_and_wait_all_lwps, select_event_lwp)
3371         (linux_nat_filter_event, linux_nat_wait_1)
3372         (linux_nat_target::kill, linux_nat_target::stop)
3373         (linux_nat_target::stop): Update.
3374         (linux_nat_resume_callback): Change type.
3375         (resume_stopped_resumed_lwps, count_events_callback)
3376         (select_event_lwp_callback): Likewise.
3377         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3378         * arm-linux-nat.c (struct update_registers_data): Remove.
3379         (update_registers_callback): Change type.
3380         (arm_linux_insert_hw_breakpoint1): Update.
3381         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3382         parameter.
3383         (x86_linux_dr_set_addr): Update.
3384         (x86_linux_dr_set_control): Update.
3385         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3386         (iterate_over_lwps): Use gdb::function_view.
3387         * nat/aarch64-linux-hw-point.c (struct
3388         aarch64_dr_update_callback_param): Remove.
3389         (debug_reg_change_callback): Change type.
3390         (aarch64_notify_debug_reg_change): Update.
3391         * s390-linux-nat.c (s390_refresh_per_info): Update.
3392
3393 2019-03-11  Tom Tromey  <tromey@adacore.com>
3394
3395         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3396         redundant assignment to "this_cu".
3397
3398 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3399
3400         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3401
3402 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3403
3404         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3405         from...
3406         (rank_one_type): ... this.
3407
3408 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3409
3410         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3411         from...
3412         (rank_one_type): ... this.
3413
3414 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3415
3416         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3417         from...
3418         (rank_one_type): ... this.
3419
3420 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3421
3422         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3423         from...
3424         (rank_one_type): ... this.
3425
3426 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3427
3428         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3429         from...
3430         (rank_one_type): ... this.
3431
3432 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3433
3434         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3435         from...
3436         (rank_one_type): ... this.
3437
3438 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3439
3440         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3441         from...
3442         (rank_one_type): ... this.
3443
3444 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3445
3446         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3447         from...
3448         (rank_one_type): ... this.
3449
3450 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3451
3452         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3453         from...
3454         (rank_one_type): ... this.
3455
3456 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3457
3458         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3459         from...
3460         (rank_one_type): ... this.
3461
3462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3463
3464         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3465         from...
3466         (rank_one_type): ... this.
3467
3468 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3469
3470         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3471         from...
3472         (rank_one_type): ... this.
3473
3474 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3475
3476         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3477         inferior-events' shows the example events.
3478
3479 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3480
3481         Support styling on native MS-Windows console
3482
3483         PR/24315
3484         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3485         on MS-Windows if $TERM is not defined.
3486
3487         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3488
3489         * posix-hdep.c (gdb_console_fputs):
3490         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3491         functions.
3492         * ui-file.h (gdb_console_fputs): Add prototype.
3493
3494         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3495         back to fputs only if the former returns zero.
3496
3497 2019-03-07  Tom Tromey  <tom@tromey.com>
3498
3499         * symmisc.c (print_symbol_bcache_statistics): Update.
3500         (print_objfile_statistics): Update.
3501         * symfile.c (allocate_symtab): Update.
3502         * stabsread.c: Don't include bcache.h.
3503         * psymtab.h (struct psymbol_bcache): Don't declare.
3504         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3505         (psymbol_bcache_init, psymbol_bcache_free)
3506         (psymbol_bcache_get_bcache): Don't declare.
3507         * psymtab.c (struct psymbol_bcache): Remove.
3508         (psymtab_storage::psymtab_storage): Update.
3509         (psymtab_storage::~psymtab_storage): Update.
3510         (psymbol_bcache_init, psymbol_bcache_free)
3511         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3512         (add_psymbol_to_bcache): Update.
3513         (allocate_psymtab): Update.
3514         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3515         macro_cache>: No longer pointers.
3516         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3517         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3518         * macrotab.c (macro_bcache): Update.
3519         * macroexp.c: Don't include bcache.h.
3520         * gdbtypes.c (check_types_worklist): Update.
3521         (types_deeply_equal): Remove TRY/CATCH.  Update.
3522         * elfread.c (elf_symtab_read): Update.
3523         * dwarf2read.c: Don't include bcache.h.
3524         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3525         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3526         (print_bcache_statistics, bcache_memory_used): Don't declare.
3527         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3528         methods.  Rename all data members.
3529         * bcache.c (struct bcache): Move to bcache.h.
3530         (bcache::expand_hash_table): Rename from expand_hash_table.
3531         (bcache): Remove.
3532         (bcache::insert): Rename from bcache_full.
3533         (bcache::compare): Rename from bcache_compare.
3534         (bcache_xmalloc): Remove.
3535         (bcache::~bcache): Rename from bcache_xfree.
3536         (bcache::print_statistics): Rename from print_bcache_statistics.
3537         (bcache::memory_used): Rename from bcache_memory_used.
3538
3539 2019-03-07  Pedro Alves  <palves@redhat.com>
3540
3541         * infrun.c (normal_stop): Also check for
3542         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3543
3544 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * f-lang.c (value_from_host_double): Moved to...
3547         * value.c (value_from_host_double): ...here.
3548         * value.h (value_from_host_double): Declare.
3549         * guile/scm-math.c (vlscm_convert_typed_number): Use
3550         value_from_host_double.
3551         (vlscm_convert_number): Likewise.
3552         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3553         * python/py-value.c (convert_value_from_python): Likewise.
3554
3555 2019-03-06  Tom Tromey  <tom@tromey.com>
3556
3557         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3558
3559 2019-03-06  Tom Tromey  <tom@tromey.com>
3560
3561         * utils.h (free_current_contents): Don't declare.
3562         * utils.c (free_current_contents): Remove.
3563
3564 2019-03-06  Tom Tromey  <tom@tromey.com>
3565
3566         * top.c (quit_force): Update.
3567         * main.c (captured_command_loop): Update.
3568         * common/new-op.c (operator new): Update.
3569         * common/common-exceptions.c (struct catcher)
3570         <save_cleanup_chain>: Remove member.
3571         (exceptions_state_mc_init): Update.
3572         (exception_try_scope_entry): Return nullptr.
3573         (exception_try_scope_exit, exception_rethrow)
3574         (throw_exception_sjlj, throw_exception_cxx): Update.
3575         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3576         (all_cleanups, do_cleanups, discard_cleanups)
3577         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3578         (restore_cleanups, restore_final_cleanups): Don't declare.
3579         (do_final_cleanups): Remove parameter.
3580         * common/cleanups.c (cleanup_chain, make_cleanup)
3581         (make_cleanup_dtor, all_cleanups, do_cleanups)
3582         (discard_my_cleanups, discard_cleanups)
3583         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3584         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3585         (null_cleanup): Remove.
3586         (do_final_cleanups): Remove parameter.
3587
3588 2019-03-06  Tom Tromey  <tom@tromey.com>
3589
3590         * remote.c (remote_target::remote_parse_stop_reply): Use
3591         unique_xmalloc_ptr.
3592
3593 2019-03-06  Tom Tromey  <tom@tromey.com>
3594
3595         * stabsread.c (struct stabs_field_info): Rename from field_info.
3596         <list, fnlist>: Add initializers.
3597         <obstack>: New member.
3598         (read_member_functions, read_struct_fields, read_baseclasses):
3599         Allocate on obstack.  Don't use cleanups.
3600         (read_one_struct_field, read_member_functions, read_struct_fields)
3601         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3602         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3603         (read_struct_type): Update.
3604
3605 2019-03-06  Tom Tromey  <tom@tromey.com>
3606
3607         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3608         * common/filestuff.h (make_cleanup_close): Don't declare.
3609         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3610         Remove.
3611
3612 2019-03-06  Tom Tromey  <tom@tromey.com>
3613
3614         * solib-aix.c: Use make_scope_exit.
3615
3616 2019-03-06  Tom Tromey  <tom@tromey.com>
3617
3618         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3619         Use make_scope_exit.
3620
3621 2019-03-06  Tom Tromey  <tom@tromey.com>
3622
3623         * solib-svr4.c (disable_probes_interface): Remove parameter.
3624         (svr4_handle_solib_event): Use make_scope_exit.
3625
3626 2019-03-06  Tom Tromey  <tom@tromey.com>
3627
3628         * remote.c (struct stop_reply_deleter): Remove.
3629         (stop_reply_up): Update.
3630         (struct stop_reply): Derive from notif_event.  Don't typedef.
3631         <regcache>: Now a std::vector.
3632         (stop_reply_xfree): Remove.
3633         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3634         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3635         (remote_target::discard_pending_stop_replies): Use delete.
3636         (remote_target::remote_parse_stop_reply): Update.
3637         (remote_target::process_stop_reply): Update.
3638         * remote-notif.h (struct notif_event): Add virtual destructor.
3639         Remove "dtr" member.
3640         (struct notif_client) <alloc_event>: Return a unique_ptr.
3641         (notif_event_xfree): Don't declare.
3642         (notif_event_up): New typedef.
3643         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3644         (notif_event_xfree, do_notif_event_xfree): Remove.
3645         (remote_notif_state_xfree): Update.
3646
3647 2019-03-06  Tom Tromey  <tom@tromey.com>
3648
3649         * infrun.c (displaced_step_clear_cleanup): Now a
3650         forward_scope_exit type.
3651         (displaced_step_prepare_throw): Update.
3652         (displaced_step_fixup): Update.
3653
3654 2019-03-06  Tom Tromey  <tom@tromey.com>
3655
3656         * inferior.h (class inferior): Update comment.
3657         * gdbthread.h (class thread_info): Update comment.
3658
3659 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3660             Tom Tromey  <tom@tromey.com>
3661
3662         * stabsread.h (struct stab_section_list): Remove.
3663         (coffstab_build_psymtabs): Update.
3664         * dbxread.c (symbuf_sections): Now a std::vector.
3665         (sect_idx): New global.
3666         (fill_symbuf): Update.
3667         (coffstab_build_psymtabs): Change type of stabsects parameter.
3668         Update.
3669         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3670         std::vector.
3671         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3672         (coff_locate_sections): Update.
3673         (coff_symfile_read): Remove cleanups.  Update.
3674         (init_stringtab): Add storage parameter.
3675         (free_stringtab, free_stringtab_cleanup): Remove.
3676         (init_lineno): Add storage parameter.
3677         (free_linetab, free_linetab_cleanup): Remove.
3678
3679 2019-03-06  Pedro Alves  <palves@redhat.com>
3680
3681         * linux-fork.c (fork_info::clobber_regs): Delete.
3682         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3683         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3684         comment.  Adjust.
3685         (scoped_switch_fork_info::scoped_switch_fork_info)
3686         (checkpoint_command, linux_fork_context): Adjust
3687         fork_save_infrun_state calls.
3688
3689 2019-03-06  Pedro Alves  <palves@redhat.com>
3690
3691         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3692         (inf_has_multiple_threads): Return 'bool' and rewrite using
3693         inferior_info::threads().
3694
3695 2019-03-06  Pedro Alves  <palves@redhat.com>
3696
3697         * linux-fork.c: Include <list>.
3698         (fork_list): Now a std::list instance.
3699         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3700         (forks_exist_p, find_last_fork): Adjust.
3701         (new_fork): Delete.
3702         (one_fork_p): New.
3703         (add_fork): Adjust.
3704         (free_fork): Delete, folded into fork_info::~fork_info().
3705         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3706         Adjust.
3707         (init_fork_list): Delete.
3708         (linux_fork_killall, linux_fork_mourn_inferior)
3709         (linux_fork_detach, info_checkpoints_command): Adjust.
3710         (_initialize_linux_fork): No longer call init_fork_list.
3711
3712 2019-03-06  Pedro Alves  <palves@redhat.com>
3713
3714         * linux-fork.c (new_fork): New, split out of ...
3715         (add_fork): ... this.  Return void.  Move "first fork" special
3716         case from here, to ...
3717         (checkpoint_command): ... here.
3718         * linux-linux.h (add_fork): Return void.
3719
3720 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3721
3722         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3723
3724 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3725             Chris January  <chris.january@arm.com>
3726             David Lecomber  <david.lecomber@arm.com>
3727
3728         * f-exp.y: New token, UNOP_INTRINSIC.
3729         (exp): New pattern using UNOP_INTRINSIC token.
3730         (f77_keywords): Add 'abs' keyword.
3731         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3732         (value_from_host_double): New function.
3733         (evaluate_subexp_f): Support UNOP_ABS.
3734
3735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3736
3737         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3738         types.
3739
3740 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3741
3742         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3743         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3744         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3745
3746 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3749
3750 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3751             Chris January  <chris.january@arm.com>
3752
3753         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3754         * f-exp.y: Define 'KIND' token.
3755         (exp): New pattern for KIND expressions.
3756         (ptype): Handle types with a kind extension.
3757         (direct_abs_decl): Extend to spot kind extensions.
3758         (f77_keywords): Add 'kind' to the list.
3759         (push_kind_type): New function.
3760         (convert_to_kind_type): New function.
3761         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3762         * parse.c (operator_length_standard): Likewise.
3763         * parser-defs.h (enum type_pieces): Add tp_kind.
3764         * std-operator.def: Add UNOP_KIND.
3765
3766 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         * f-exp.y (f_parse): Set yydebug.
3769
3770 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * f-lang.c (evaluate_subexp_f): New function.
3773         (exp_descriptor_f): New global.
3774         (f_language_defn): Use exp_descriptor_f instead of
3775         exp_descriptor_standard.
3776
3777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * f-exp.y (struct token): Add comments.
3780         (dot_ops): Remove uppercase versions and the end marker.
3781         (f77_keywords): Likewise.
3782         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3783         entries in the dot_ops array are case insensitive, and use
3784         strncasecmp to compare strings.  Also some whitespace cleanup in
3785         this area.  Similar for the f77_keywords array, except entries in
3786         this list might be case sensitive.
3787
3788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * f-exp.y (struct f77_boolean_val): Add comments.
3791         (boolean_values): Remove uppercase versions, and end marker.
3792         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3793         and use strncasecmp to achieve case insensitivity.  Additionally,
3794         perform whitespace cleanup around this code.
3795
3796 2019-03-06  Tom Tromey  <tromey@adacore.com>
3797
3798         * remote-sim.c (gdbsim_target_open): Use result of
3799         gdb_argv::release.
3800
3801 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3802         Dirk Schubert  <dirk.schubert@arm.com>
3803         Chris January  <chris.january@arm.com>
3804
3805         * eval.c (evaluate_subexp_standard): Call Fortran argument
3806         wrapping logic.
3807         * f-lang.c (struct value): A value which can be passed into a
3808         Fortran function call.
3809         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3810         where appropriate.
3811         (struct type): Value ready for a Fortran function call.
3812         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3813         is needed.
3814         * f-lang.h (fortran_argument_convert): Declaration.
3815         (fortran_preserve_arg_pointer): Declaration.
3816         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3817
3818 2019-03-05  Tom Tromey  <tromey@adacore.com>
3819
3820         * python/py-prettyprint.c (print_string_repr): Remove #if.
3821         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3822
3823 2019-03-05  Tom Tromey  <tromey@adacore.com>
3824
3825         * target.c (the_dummy_target): Move later.  Change type to
3826         "dummy_target".
3827         (initialize_targets): Don't initialize the_dummy_target.
3828
3829 2019-03-05  Tom Tromey  <tromey@adacore.com>
3830
3831         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3832         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3833
3834 2019-03-05  Tom Tromey  <tromey@adacore.com>
3835
3836         * windows-nat.c (windows_nat_target::attach)
3837         (windows_nat_target::detach): Don't call gdb_flush.
3838         * valprint.c (generic_val_print, val_print, val_print_string):
3839         Don't call gdb_flush.
3840         * utils.c (defaulted_query): Don't call gdb_flush.
3841         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3842         * target.c (target_announce_detach): Don't call gdb_flush.
3843         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3844         * remote.c (extended_remote_target::attach): Don't call
3845         gdb_flush.
3846         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3847         * printcmd.c (do_examine): Don't call gdb_flush.
3848         (info_display_command): Don't call gdb_flush.
3849         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3850         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3851         * memattr.c (info_mem_command): Don't call gdb_flush.
3852         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3853         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3854         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3855         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3856         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3857         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3858         (gnu_nat_target::detach): Don't call gdb_flush.
3859         * f-valprint.c (f_val_print): Don't call gdb_flush.
3860         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3861         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3862         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3863         gdb_flush.
3864         * c-valprint.c (c_val_print): Don't call gdb_flush.
3865         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3866
3867 2019-03-05  Tom Tromey  <tromey@adacore.com>
3868
3869         * varobj.c (update_dynamic_varobj_children): Update.
3870         (install_default_visualizer): Use reset, not release.
3871         * value.c (set_internalvar): Update.
3872         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3873         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3874         ATTRIBUTE_UNUSED_RESULT.
3875
3876 2019-03-05  Tom Tromey  <tromey@adacore.com>
3877
3878         * remote.c (class scoped_remote_fd) <release>: Add
3879         ATTRIBUTE_UNUSED_RESULT.
3880
3881 2019-03-05  Tom Tromey  <tromey@adacore.com>
3882
3883         * macroexp.c (struct macro_buffer) <release>: Add
3884         ATTRIBUTE_UNUSED_RESULT.
3885
3886 2019-03-05  Tom Tromey  <tromey@adacore.com>
3887
3888         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3889         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3890         ATTRIBUTE_UNUSED_RESULT.
3891
3892 2019-03-05  Tom Tromey  <tromey@adacore.com>
3893
3894         * common/scoped_fd.h (class scoped_fd) <release>: Add
3895         ATTRIBUTE_UNUSED_RESULT.
3896
3897 2019-03-05  Tom Tromey  <tromey@adacore.com>
3898
3899         * parser-defs.h (struct parser_state) <release>: Add
3900         ATTRIBUTE_UNUSED_RESULT.
3901
3902 2019-03-05  Tom Tromey  <tromey@adacore.com>
3903
3904         * utils.h (class gdb_argv) <release>: Add
3905         ATTRIBUTE_UNUSED_RESULT.
3906         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3907
3908 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3909
3910         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3911         for-loop range, to avoid compiler warnings.
3912
3913         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3914         avoid compiler warnings about unused variables.
3915
3916         * NEWS: Mention end of support for native debugging on MS-Windows
3917         before XP.
3918
3919         PR gdb/24292
3920         * common/netstuff.c:
3921         * gdbserver/gdbreplay.c
3922         * gdbserver/remote-utils.c:
3923         * ser-tcp.c:
3924         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3925         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3926         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3927         'getaddrinfo' and 'freeaddrinfo' were not available before
3928         Windows XP, and mingw.org's MinGW headers by default define
3929         _WIN32_WINNT to 0x500.
3930
3931 2019-03-01  Gary Benson <gbenson@redhat.com>
3932
3933         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3934
3935 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3936             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3937
3938         PR gdb/8527
3939         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3940         set_sigint_trap, clear_sigint_trap.
3941
3942 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3943
3944         * target.c (target_detach): Clear the regcache and the
3945         frame cache.
3946
3947 2019-02-27  Pedro Alves  <palves@redhat.com>
3948
3949         * utils.c (set_screen_size): When we cap the height/width sizes,
3950         tweak the corresponding command variable to show "unlimited":
3951
3952 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3953             Pedro Alves  <palves@redhat.com>
3954
3955         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3956         before calling rl_set_screen_size.
3957
3958 2019-02-27  Tom Tromey  <tromey@adacore.com>
3959
3960         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3961         define.
3962         * python/py-value.c: Remove Python 2.4 workaround.
3963         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3964         workaround.
3965         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3966         Python 2.4 workaround.
3967         * python/python-internal.h: Remove Python 2.4 comment.
3968         (Py_ssize_t): Don't define.
3969         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3970         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3971         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3972         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3973         * python/python.c (do_start_initialization): Remove Python 2.4
3974         workaround.
3975         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3976         (print_children): Remove Python 2.4 workaround.
3977         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3978         workaround.
3979         (CHARBUFFERPROC_NAME): Remove.
3980         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3981         Python 2.4 workaround.
3982
3983 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3984
3985         * NEWS: Note minimum Python version.
3986
3987 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3988
3989         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3990         code from these functions.  Remove corresponding ifdefs.  Use
3991         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3992         Remove gotos and target of gotos.
3993         (infpy_search_memory): Likewise.
3994
3995 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3998         (hppa_gdbarch_init): Don't register deleted functions with
3999         gdbarch.
4000
4001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4004         (h8300_unwind_sp): Delete.
4005         (h8300_dummy_id): Delete.
4006         (h8300_gdbarch_init): Don't register deleted functions with
4007         gdbarch.
4008
4009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4010
4011         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4012         (ft32_unwind_pc): Delete.
4013         (ft32_unwind_sp): Delete.
4014         (ft32_gdbarch_init): Don't register deleted functions with
4015         gdbarch.
4016
4017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4018
4019         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4020         (frv_unwind_pc): Delete.
4021         (frv_unwind_sp): Delete.
4022         (frv_gdbarch_init): Don't register deleted functions with
4023         gdbarch.
4024
4025 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4026
4027         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4028         (riscv_unwind_pc): Delete.
4029         (riscv_unwind_sp): Delete.
4030         (riscv_gdbarch_init): Don't register deleted functions with
4031         gdbarch.
4032
4033 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4036         (csky_unwind_pc): Delete.
4037         (csky_unwind_sp): Delete.
4038         (csky_gdbarch_init): Don't register deleted functions with
4039         gdbarch.
4040
4041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4042
4043         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4044         (cris_unwind_pc): Delete.
4045         (cris_unwind_sp): Delete.
4046         (cris_gdbarch_init): Don't register deleted functions with
4047         gdbarch.
4048
4049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4050
4051         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4052         (bfin_unwind_pc): Delete.
4053         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4054
4055 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4058         (arm_unwind_pc): Delete.
4059         (arm_unwind_sp): Delete.
4060         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4061
4062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4063
4064         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4065         (arc_unwind_pc): Delete.
4066         (arc_unwind_sp): Delete.
4067         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4068
4069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4072         (alpha_unwind_pc): Delete.
4073         (alpha_gdbarch_init): Don't register deleted functions with
4074         gdbarch.
4075
4076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4077
4078         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4079         (aarch64_unwind_pc): Delete.
4080         (aarch64_unwind_sp): Delete.
4081         (aarch64_gdbarch_init): Don't register deleted functions with
4082         gdbarch.
4083
4084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * gdbtypes.c (type_align): Don't consider static members when
4087         computing structure alignment.
4088
4089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4090
4091         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4092         return 0 for other types.
4093         * arch-utils.c (default_type_align): Always return 0.
4094         * gdbarch.h: Regenerate.
4095         * gdbarch.sh (type_align): Extend comment.
4096         * gdbtypes.c (type_align): Add additional comments, always call
4097         gdbarch_type_align before applying the default rules.
4098         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4099         generic code will then apply a suitable default.
4100         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4101         types, return 0 for other types.
4102
4103 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4104
4105         * NEWS: Create a new section for the next release branch.
4106         Rename the section of the current branch, now that it has
4107         been cut.
4108
4109 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4110
4111         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4112         * version.in: Bump version to 8.3.50.DATE-git.
4113
4114 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4115
4116         * aix-thread.c (ptid_cmp): Remove unused variable.
4117         (get_signaled_thread): Likewise.
4118         (store_regs_user_thread): Likewise.
4119         (store_regs_kernel_thread): Likewise.
4120         (fetch_regs_kernel_thread): Remove shadowed variable.
4121
4122 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4123
4124         * features/riscv/32bit-cpu.xml: Add register numbers.
4125         * features/riscv/32bit-fpu.c: Regenerate.
4126         * features/riscv/32bit-fpu.xml: Add register numbers.
4127         * features/riscv/64bit-cpu.xml: Add register numbers.
4128         * features/riscv/64bit-fpu.c: Regenerate.
4129         * features/riscv/64bit-fpu.xml: Add register numbers.
4130
4131 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4132
4133         * NEWS: Mention two argument form of gdb.Value constructor.
4134         * python/py-value.c (convert_buffer_and_type_to_value): New
4135         function.
4136         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4137         Add support for handling an optional second argument.  Call
4138         convert_buffer_and_type_to_value as appropriate.
4139         * python/python-internal.h (Py_buffer_deleter): New struct.
4140         (Py_buffer_up): New typedef.
4141
4142 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4143
4144         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4145         instead of releasing ownership.
4146
4147 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4148
4149         * dwarf2read.c (open_and_init_dwp_file): Call
4150         elf_numsections instead of bfd_count_sections to initialize
4151         dwp_file->num_sections.
4152
4153 2019-02-25  Tom Tromey  <tromey@adacore.com>
4154
4155         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4156
4157 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4158
4159         * gcore.in: Add '--readnever' option when invoking GDB.
4160
4161 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4162
4163         * MAINTAINERS: Update my email address.
4164
4165 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4166
4167         * build-id.c (build_id_to_debug_bfd_1): New function.
4168         (build_id_to_debug_bfd): Look for separate debug file in
4169         sysroot.
4170
4171 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4172
4173         * gdbarch.sh: Update the copyright year range that is placed into
4174         generated files.
4175
4176 2019-02-22  Keith Seitz  <keiths@redhat.com>
4177
4178         PR symtab/23853
4179         * linespec.c (create_sals_line_offset): Search for the default
4180         symtab's filename instead of its fullname.
4181
4182 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4183
4184         * NEWS: Update style defaults.
4185
4186 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4187
4188         * main.c (captured_main_1): Disable styling in batch mode.
4189
4190 2019-02-20  Tom Tromey  <tom@tromey.com>
4191
4192         * symtab.c (symtab_symbol_info): Fix typos.
4193
4194 2019-02-20  Tom Tromey  <tromey@adacore.com>
4195
4196         * findcmd.c (_initialize_mem_search): Use upper case for
4197         metasyntactic variables.
4198
4199 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4200
4201         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4202         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4203
4204 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4205
4206         * top.h (source_file_name): Change to std::string.
4207         * top.c (source_file_name): Likewise.
4208         (command_line_input): Adjust.
4209         * cli/cli-script.c (script_from_file): Adjust.
4210
4211 2019-02-19  Tom Tromey  <tromey@adacore.com>
4212
4213         * ravenscar-thread.c
4214         (ravenscar_thread_target::update_thread_list): Don't call
4215         ada_build_task_list.
4216         * ada-lang.h (ada_build_task_list): Don't declare.
4217         * ada-tasks.c (struct ada_tasks_inferior_data)
4218         <task_list_valid_p>: Now bool.
4219         (read_known_tasks, ada_task_list_changed)
4220         (ada_tasks_invalidate_inferior_data): Update.
4221         (read_known_tasks_array): Return bool.
4222         (read_known_tasks_list): Likewise.
4223         (read_known_tasks): Return void.
4224         (ada_build_task_list): Now static.
4225
4226 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4227
4228         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4229         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4230
4231 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4232
4233         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4234         variant for ada_tasks_pspace_data_handle and
4235         ada_tasks_inferior_data_handle.
4236         (ada_tasks_pspace_data_cleanup): New function.
4237         (ada_tasks_inferior_data_cleanup): New function.
4238
4239 2019-02-17  Tom Tromey  <tom@tromey.com>
4240
4241         * macrotab.h (macro_source_fullname): Return a std::string.
4242         * macrotab.c (macro_include, check_for_redefinition)
4243         (macro_undef, macro_lookup_definition, foreach_macro)
4244         (foreach_macro_in_scope): Update.
4245         (macro_source_fullname): Return a std::string.
4246         * macrocmd.c (show_pp_source_pos): Update.
4247
4248 2019-02-17  Tom Tromey  <tom@tromey.com>
4249
4250         * macrocmd.c (show_pp_source_pos): Style the file names.
4251
4252 2019-02-17  Tom Tromey  <tom@tromey.com>
4253
4254         PR tui/24197:
4255         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4256
4257 2019-02-17  Tom Tromey  <tom@tromey.com>
4258
4259         * ada-lang.c (user_select_syms): Use filtered printing.
4260         * utils.c (wrap_style): New global.
4261         (desired_style): Remove.
4262         (emit_style_escape): Add stream parameter.
4263         (set_output_style, reset_terminal_style, prompt_for_continue):
4264         Update.
4265         (flush_wrap_buffer): Only flush gdb_stdout.
4266         (wrap_here): Set wrap_style.
4267         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4268         treat escape sequences as a character.  Change when wrap buffer is
4269         flushed.
4270         (fputs_styled): Do not set the output style when the default is
4271         requested.
4272         * ui-style.h (struct ui_file_style) <is_default>: New method.
4273         * source.c (print_source_lines_base): Emit escape sequences in one
4274         piece.
4275
4276 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4277
4278         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4279         integers and enumeration types.
4280
4281 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4282
4283         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4284         instead of lookup_symbol_in_language
4285         (do_exact_match): New function.
4286         (ada_get_symbol_name_matcher): Return do_exact_match when
4287         doing a verbatim match.
4288
4289 2019-02-15  Tom Tromey  <tromey@adacore.com>
4290
4291         * ravenscar-thread.c (ravenscar_thread_target::resume)
4292         (ravenscar_thread_target::wait): Special case wildcard requests.
4293
4294 2019-02-15  Tom Tromey  <tromey@adacore.com>
4295
4296         * ravenscar-thread.c (base_ptid): Remove.
4297         (struct ravenscar_thread_target) <close>: New method.
4298         <m_base_ptid>: New member.
4299         <update_inferior_ptid, active_task, task_is_currently_active,
4300         runtime_initialized>: Declare methods.
4301         <ravenscar_thread_target>: Add constructor.
4302         (ravenscar_thread_target::task_is_currently_active)
4303         (ravenscar_thread_target::update_inferior_ptid)
4304         (ravenscar_runtime_initialized): Rename.  Now methods.
4305         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4306         (ravenscar_thread_target::update_thread_list): Update.
4307         (ravenscar_thread_target::active_task): Now method.
4308         (ravenscar_thread_target::store_registers)
4309         (ravenscar_thread_target::prepare_to_store)
4310         (ravenscar_thread_target::prepare_to_store)
4311         (ravenscar_thread_target::mourn_inferior): Update.
4312         (ravenscar_inferior_created): Use "new" to create target.
4313         (ravenscar_thread_target::get_ada_task_ptid): Update.
4314         (_initialize_ravenscar): Don't initialize base_ptid.
4315         (ravenscar_ops): Remove global.
4316
4317 2019-02-15  Tom Tromey  <tromey@adacore.com>
4318
4319         * target.h (push_target): Declare new overload.
4320         * target.c (push_target): New overload, taking an rvalue reference.
4321         * remote.c (remote_target::open_1): Use push_target overload.
4322         * corelow.c (core_target_open): Use push_target overload.
4323
4324 2019-02-15  Tom Tromey  <tromey@adacore.com>
4325
4326         * ravenscar-thread.c (is_ravenscar_task)
4327         (ravenscar_task_is_currently_active): Return bool.
4328         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4329         (_initialize_ravenscar): Remove "(void)".
4330         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4331         Return bool.
4332
4333 2019-02-15  Tom Tromey  <tromey@adacore.com>
4334
4335         * ravenscar-thread.c (ravenscar_runtime_initializer)
4336         (has_ravenscar_runtime, get_running_thread_id)
4337         (ravenscar_thread_target::resume): Fix indentation.
4338
4339 2019-02-15  Tom Tromey  <tromey@adacore.com>
4340
4341         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4342         from ravenscar_arch_ops.
4343         (sparc_ravenscar_ops::fetch_registers)
4344         (sparc_ravenscar_ops::store_registers): Now methods.
4345         (sparc_ravenscar_prepare_to_store): Remove.
4346         (sparc_ravenscar_ops): Redefine.
4347         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4348         methods and destructor.  Remove members.
4349         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4350         (ravenscar_thread_target::store_registers)
4351         (ravenscar_thread_target::prepare_to_store): Update.
4352         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4353         Remove.
4354         (struct ppc_ravenscar_powerpc_ops): Derive from
4355         ravenscar_arch_ops.
4356         (ppc_ravenscar_powerpc_ops::fetch_registers)
4357         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4358         (ppc_ravenscar_powerpc_ops): Redefine.
4359         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4360         (ppc_ravenscar_e500_ops::fetch_registers)
4361         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4362         (ppc_ravenscar_e500_ops): Redefine.
4363         * aarch64-ravenscar-thread.c
4364         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4365         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4366         (aarch64_ravenscar_fetch_registers)
4367         (aarch64_ravenscar_store_registers): Now methods.
4368         (aarch64_ravenscar_ops): Redefine.
4369
4370 2019-02-15  Tom Tromey  <tromey@adacore.com>
4371
4372         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4373         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4374         (ravenscar_thread_target::stopped_by_watchpoint)
4375         (ravenscar_thread_target::stopped_data_address)
4376         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4377
4378 2019-02-15  Tom Tromey  <tromey@adacore.com>
4379
4380         * ravenscar-thread.c: Fix some typos.
4381
4382 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4383             Tom Tromey  <tromey@adacore.com>
4384
4385         * ada-lang.c (ada_exception_sal): Change addr_string to a
4386         std::string.
4387         (create_ada_exception_catchpoint): Update.
4388
4389 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4390             Tom Tromey  <tromey@adacore.com>
4391
4392         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4393         (bp_location_ops): Remove.
4394         (base_breakpoint_allocate_location): Update.
4395         (free_bp_location): Update.
4396         * ada-lang.c (class ada_catchpoint_location)
4397         <ada_catchpoint_location>: Remove ops parameter.
4398         (ada_catchpoint_location_dtor): Remove.
4399         (ada_catchpoint_location_ops): Remove.
4400         (allocate_location_exception): Update.
4401         * breakpoint.h (struct bp_location_ops): Remove.
4402         (class bp_location) <bp_location>: Remove bp_location_ops
4403         parameter.
4404         <~bp_location>: Add destructor.
4405         <ops>: Remove.
4406
4407 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4408             Pedro Alves  <palves@redhat.com>
4409
4410         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4411         'PATH_MAX'.
4412
4413 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4414             Samuel Thibault  <samuel.thibault@gnu.org>
4415             Thomas Schwinge  <thomas@codesourcery.com>
4416
4417         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4418         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4419
4420 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4421
4422         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4423         (check_empty): Use "const char *".
4424
4425         * gnu-nat.c (gnu_nat_target::detach): Instead of
4426         'detach_inferior (pid)' call
4427         'detach_inferior (find_inferior_pid (pid))'.
4428
4429         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4430         'nat/fork-inferior.o'.
4431         * gnu-nat.c: #include "nat/fork-inferior.h".
4432
4433         * gnu-nat.c (gnu_nat_target::detach): Instead of
4434         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4435         * gnu-nat.h: #include "inf-child.h".
4436         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4437         'i386_gnu_nat_target::fetch_registers'.
4438         (gnu_store_registers): Rename/move to
4439         'i386_gnu_nat_target::store_registers'.
4440
4441         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4442         * gnu-nat.h (mach_thread_info): New function.
4443         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4444
4445         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4446
4447 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4448
4449         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4450
4451 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4452
4453         * windows-nat.c (windows_add_thread): Add new parameter
4454         "main_thread_p" with default value set to false.  Update
4455         function documentation as well as all callers.
4456         (windows_delete_thread): Likewise.
4457         (fake_create_process): Update call to windows_add_thread.
4458         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4459         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4460         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4461         call to windows_delete_thread.
4462
4463 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4464
4465         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4466
4467 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4468
4469         * symfile.c (find_separate_debug_file): Use canonical path of
4470         sysroot with child_path instead of gdb_sysroot if it is valid.
4471
4472 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4473
4474         * symfile.c (find_separate_debug_file): Use child_path to
4475         determine if an object file is under a sysroot.
4476
4477 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4478
4479         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4480         unittests/child-path-selftests.c.
4481         * common/pathstuff.c (child_path): New function.
4482         * common/pathstuff.h (child_path): New prototype.
4483         * unittests/child-path-selftests.c: New file.
4484
4485 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4486
4487         * symfile.c (find_separate_debug_file): Look for separate debug
4488         files in debug directories under the sysroot.
4489
4490 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4491
4492         * symtab.h (struct minimal_symbol data_p): New const method.
4493         (struct minimal_symbol text_p): Likewise.
4494         * symtab.c (output_source_filename): Use file name style
4495         to print file name.
4496         (print_symbol_info): Likewise.
4497         (print_msymbol_info): Use address style to print addresses.
4498         Use function name style to print executable text symbols.
4499         (expand_symtab_containing_pc): Use data_p.
4500         (find_pc_sect_compunit_symtab): Likewise.
4501
4502 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4503
4504         * breakpoint.c (describe_other_breakpoints): Use address style
4505         to print addresses.
4506         (say_where): Likewise.
4507
4508 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4509
4510         * ada-typeprint.c (print_func_type): Print function name
4511         style to print function name.
4512         * c-typeprint.c (c_print_type_1): Likewise.
4513
4514 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4515
4516         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4517         for execve.
4518
4519 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4520
4521         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4522         type_stack.
4523
4524 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4525
4526         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4527         TYPE_CODE_REF types.
4528
4529 2019-02-08  Jim Wilson  <jimw@sifive.com>
4530
4531         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4532         (riscv_linux_fregset): New.
4533         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4534
4535 2019-02-07  Tom Tromey  <tom@tromey.com>
4536
4537         * thread.c (thread_cancel_execution_command): Update.
4538         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4539         methods.
4540         (struct thread_fsm_ops): Remove.
4541         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4542         (thread_fsm_should_stop, thread_fsm_return_value)
4543         (thread_fsm_set_finished, thread_fsm_finished_p)
4544         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4545         Don't declare.
4546         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4547         * infrun.c (clear_proceed_status_thread)
4548         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4549         (print_stop_event): Update.
4550         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4551         Add constructor.
4552         (step_command_fsm_ops): Remove.
4553         (new_step_command_fsm): Remove.
4554         (step_1): Update.
4555         (step_command_fsm::should_stop): Rename from
4556         step_command_fsm_should_stop.
4557         (step_command_fsm::clean_up): Rename from
4558         step_command_fsm_clean_up.
4559         (step_command_fsm::do_async_reply_reason): Rename from
4560         step_command_fsm_async_reply_reason.
4561         (struct until_next_fsm): Inherit from thread_fsm.  Add
4562         constructor.
4563         (until_next_fsm_ops): Remove.
4564         (new_until_next_fsm): Remove.
4565         (until_next_fsm::should_stop): Rename from
4566         until_next_fsm_should_stop.
4567         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4568         (until_next_fsm::do_async_reply_reason): Rename from
4569         until_next_fsm_async_reply_reason.
4570         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4571         constructor.  Change type of breakpoint.
4572         (finish_command_fsm_ops): Remove.
4573         (new_finish_command_fsm): Remove.
4574         (finish_command_fsm::should_stop): Rename from
4575         finish_command_fsm_should_stop.
4576         (finish_command_fsm::clean_up): Rename from
4577         finish_command_fsm_clean_up.
4578         (finish_command_fsm::return_value): Rename from
4579         finish_command_fsm_return_value.
4580         (finish_command_fsm::do_async_reply_reason): Rename from
4581         finish_command_fsm_async_reply_reason.
4582         (finish_command): Update.
4583         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4584         Add constructor.
4585         (call_thread_fsm_ops): Remove.
4586         (call_thread_fsm::call_thread_fsm): Rename from
4587         new_call_thread_fsm.
4588         (call_thread_fsm::should_stop): Rename from
4589         call_thread_fsm_should_stop.
4590         (call_thread_fsm::should_notify_stop): Rename from
4591         call_thread_fsm_should_notify_stop.
4592         (run_inferior_call, call_function_by_hand_dummy): Update.
4593         * cli/cli-interp.c (should_print_stop_to_console): Update.
4594         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4595         Add constructor.  Change type of location_breakpoint,
4596         caller_breakpoint.
4597         (until_break_fsm_ops): Remove.
4598         (new_until_break_fsm): Remove.
4599         (until_break_fsm::should_stop): Rename from
4600         until_break_fsm_should_stop.
4601         (until_break_fsm::clean_up): Rename from
4602         until_break_fsm_clean_up.
4603         (until_break_fsm::do_async_reply_reason): Rename from
4604         until_break_fsm_async_reply_reason.
4605         (until_break_command): Update.
4606         * thread-fsm.c: Remove.
4607         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4608
4609 2019-02-07  Tom Tromey  <tom@tromey.com>
4610
4611         * yy-remap.h: Add include guard.
4612         * xtensa-tdep.h: Add include guard.
4613         * xcoffread.h: Rename include guard.
4614         * varobj-iter.h: Add include guard.
4615         * tui/tui.h: Rename include guard.
4616         * tui/tui-winsource.h: Rename include guard.
4617         * tui/tui-wingeneral.h: Rename include guard.
4618         * tui/tui-windata.h: Rename include guard.
4619         * tui/tui-win.h: Rename include guard.
4620         * tui/tui-stack.h: Rename include guard.
4621         * tui/tui-source.h: Rename include guard.
4622         * tui/tui-regs.h: Rename include guard.
4623         * tui/tui-out.h: Rename include guard.
4624         * tui/tui-layout.h: Rename include guard.
4625         * tui/tui-io.h: Rename include guard.
4626         * tui/tui-hooks.h: Rename include guard.
4627         * tui/tui-file.h: Rename include guard.
4628         * tui/tui-disasm.h: Rename include guard.
4629         * tui/tui-data.h: Rename include guard.
4630         * tui/tui-command.h: Rename include guard.
4631         * tic6x-tdep.h: Add include guard.
4632         * target/waitstatus.h: Rename include guard.
4633         * target/wait.h: Rename include guard.
4634         * target/target.h: Rename include guard.
4635         * target/resume.h: Rename include guard.
4636         * target-float.h: Rename include guard.
4637         * stabsread.h: Add include guard.
4638         * rs6000-tdep.h: Add include guard.
4639         * riscv-fbsd-tdep.h: Add include guard.
4640         * regformats/regdef.h: Rename include guard.
4641         * record.h: Rename include guard.
4642         * python/python.h: Rename include guard.
4643         * python/python-internal.h: Rename include guard.
4644         * python/py-stopevent.h: Rename include guard.
4645         * python/py-ref.h: Rename include guard.
4646         * python/py-record.h: Rename include guard.
4647         * python/py-record-full.h: Rename include guard.
4648         * python/py-record-btrace.h: Rename include guard.
4649         * python/py-instruction.h: Rename include guard.
4650         * python/py-events.h: Rename include guard.
4651         * python/py-event.h: Rename include guard.
4652         * procfs.h: Add include guard.
4653         * proc-utils.h: Add include guard.
4654         * p-lang.h: Add include guard.
4655         * or1k-tdep.h: Rename include guard.
4656         * observable.h: Rename include guard.
4657         * nto-tdep.h: Rename include guard.
4658         * nat/x86-linux.h: Rename include guard.
4659         * nat/x86-linux-dregs.h: Rename include guard.
4660         * nat/x86-gcc-cpuid.h: Add include guard.
4661         * nat/x86-dregs.h: Rename include guard.
4662         * nat/x86-cpuid.h: Rename include guard.
4663         * nat/ppc-linux.h: Rename include guard.
4664         * nat/mips-linux-watch.h: Rename include guard.
4665         * nat/linux-waitpid.h: Rename include guard.
4666         * nat/linux-ptrace.h: Rename include guard.
4667         * nat/linux-procfs.h: Rename include guard.
4668         * nat/linux-osdata.h: Rename include guard.
4669         * nat/linux-nat.h: Rename include guard.
4670         * nat/linux-namespaces.h: Rename include guard.
4671         * nat/linux-btrace.h: Rename include guard.
4672         * nat/glibc_thread_db.h: Rename include guard.
4673         * nat/gdb_thread_db.h: Rename include guard.
4674         * nat/gdb_ptrace.h: Rename include guard.
4675         * nat/fork-inferior.h: Rename include guard.
4676         * nat/amd64-linux-siginfo.h: Rename include guard.
4677         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4678         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4679         * nat/aarch64-linux.h: Rename include guard.
4680         * nat/aarch64-linux-hw-point.h: Rename include guard.
4681         * mn10300-tdep.h: Add include guard.
4682         * mips-linux-tdep.h: Add include guard.
4683         * mi/mi-parse.h: Rename include guard.
4684         * mi/mi-out.h: Rename include guard.
4685         * mi/mi-main.h: Rename include guard.
4686         * mi/mi-interp.h: Rename include guard.
4687         * mi/mi-getopt.h: Rename include guard.
4688         * mi/mi-console.h: Rename include guard.
4689         * mi/mi-common.h: Rename include guard.
4690         * mi/mi-cmds.h: Rename include guard.
4691         * mi/mi-cmd-break.h: Rename include guard.
4692         * m2-lang.h: Add include guard.
4693         * location.h: Rename include guard.
4694         * linux-record.h: Rename include guard.
4695         * linux-nat.h: Add include guard.
4696         * linux-fork.h: Add include guard.
4697         * i386-darwin-tdep.h: Rename include guard.
4698         * hppa-linux-offsets.h: Add include guard.
4699         * guile/guile.h: Rename include guard.
4700         * guile/guile-internal.h: Rename include guard.
4701         * gnu-nat.h: Rename include guard.
4702         * gdb-stabs.h: Rename include guard.
4703         * frv-tdep.h: Add include guard.
4704         * f-lang.h: Add include guard.
4705         * event-loop.h: Add include guard.
4706         * darwin-nat.h: Rename include guard.
4707         * cp-abi.h: Rename include guard.
4708         * config/sparc/nm-sol2.h: Rename include guard.
4709         * config/nm-nto.h: Rename include guard.
4710         * config/nm-linux.h: Add include guard.
4711         * config/i386/nm-i386gnu.h: Rename include guard.
4712         * config/djgpp/nl_types.h: Rename include guard.
4713         * config/djgpp/langinfo.h: Rename include guard.
4714         * compile/gcc-cp-plugin.h: Add include guard.
4715         * compile/gcc-c-plugin.h: Add include guard.
4716         * compile/compile.h: Rename include guard.
4717         * compile/compile-object-run.h: Rename include guard.
4718         * compile/compile-object-load.h: Rename include guard.
4719         * compile/compile-internal.h: Rename include guard.
4720         * compile/compile-cplus.h: Rename include guard.
4721         * compile/compile-c.h: Rename include guard.
4722         * common/xml-utils.h: Rename include guard.
4723         * common/x86-xstate.h: Rename include guard.
4724         * common/version.h: Rename include guard.
4725         * common/vec.h: Rename include guard.
4726         * common/tdesc.h: Rename include guard.
4727         * common/selftest.h: Rename include guard.
4728         * common/scoped_restore.h: Rename include guard.
4729         * common/scoped_mmap.h: Rename include guard.
4730         * common/scoped_fd.h: Rename include guard.
4731         * common/safe-iterator.h: Rename include guard.
4732         * common/run-time-clock.h: Rename include guard.
4733         * common/refcounted-object.h: Rename include guard.
4734         * common/queue.h: Rename include guard.
4735         * common/ptid.h: Rename include guard.
4736         * common/print-utils.h: Rename include guard.
4737         * common/preprocessor.h: Rename include guard.
4738         * common/pathstuff.h: Rename include guard.
4739         * common/observable.h: Rename include guard.
4740         * common/netstuff.h: Rename include guard.
4741         * common/job-control.h: Rename include guard.
4742         * common/host-defs.h: Rename include guard.
4743         * common/gdb_wait.h: Rename include guard.
4744         * common/gdb_vecs.h: Rename include guard.
4745         * common/gdb_unlinker.h: Rename include guard.
4746         * common/gdb_unique_ptr.h: Rename include guard.
4747         * common/gdb_tilde_expand.h: Rename include guard.
4748         * common/gdb_sys_time.h: Rename include guard.
4749         * common/gdb_string_view.h: Rename include guard.
4750         * common/gdb_splay_tree.h: Rename include guard.
4751         * common/gdb_setjmp.h: Rename include guard.
4752         * common/gdb_ref_ptr.h: Rename include guard.
4753         * common/gdb_optional.h: Rename include guard.
4754         * common/gdb_locale.h: Rename include guard.
4755         * common/gdb_assert.h: Rename include guard.
4756         * common/filtered-iterator.h: Rename include guard.
4757         * common/filestuff.h: Rename include guard.
4758         * common/fileio.h: Rename include guard.
4759         * common/environ.h: Rename include guard.
4760         * common/common-utils.h: Rename include guard.
4761         * common/common-types.h: Rename include guard.
4762         * common/common-regcache.h: Rename include guard.
4763         * common/common-inferior.h: Rename include guard.
4764         * common/common-gdbthread.h: Rename include guard.
4765         * common/common-exceptions.h: Rename include guard.
4766         * common/common-defs.h: Rename include guard.
4767         * common/common-debug.h: Rename include guard.
4768         * common/cleanups.h: Rename include guard.
4769         * common/buffer.h: Rename include guard.
4770         * common/btrace-common.h: Rename include guard.
4771         * common/break-common.h: Rename include guard.
4772         * cli/cli-utils.h: Rename include guard.
4773         * cli/cli-style.h: Rename include guard.
4774         * cli/cli-setshow.h: Rename include guard.
4775         * cli/cli-script.h: Rename include guard.
4776         * cli/cli-interp.h: Rename include guard.
4777         * cli/cli-decode.h: Rename include guard.
4778         * cli/cli-cmds.h: Rename include guard.
4779         * charset-list.h: Add include guard.
4780         * buildsym-legacy.h: Rename include guard.
4781         * bfin-tdep.h: Add include guard.
4782         * ax.h: Rename include guard.
4783         * arm-linux-tdep.h: Add include guard.
4784         * arm-fbsd-tdep.h: Add include guard.
4785         * arch/xtensa.h: Rename include guard.
4786         * arch/tic6x.h: Add include guard.
4787         * arch/i386.h: Add include guard.
4788         * arch/arm.h: Rename include guard.
4789         * arch/arm-linux.h: Rename include guard.
4790         * arch/arm-get-next-pcs.h: Rename include guard.
4791         * arch/amd64.h: Add include guard.
4792         * arch/aarch64-insn.h: Rename include guard.
4793         * arch-utils.h: Rename include guard.
4794         * annotate.h: Add include guard.
4795         * amd64-darwin-tdep.h: Rename include guard.
4796         * aarch64-linux-tdep.h: Add include guard.
4797         * aarch64-fbsd-tdep.h: Add include guard.
4798         * aarch32-linux-nat.h: Add include guard.
4799
4800 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4801
4802         * macrotab.c (macro_define_internal): New function that
4803         factorizes macro_define_object_internal and macro_define_function
4804         code.
4805         (macro_define_object_internal): Use macro_define_internal.
4806         (macro_define_function): Likewise.
4807
4808 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4809
4810         * macrocmd.c (extract_identifier): Return
4811         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4812         callers.
4813
4814 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4815
4816         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4817
4818 2019-02-05  Tom Tromey  <tom@tromey.com>
4819
4820         * target.c (target_stack::unpush): Move assertion earlier.
4821
4822 2019-01-30  Tom Tromey  <tom@tromey.com>
4823
4824         PR python/23615:
4825         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4826         (gdbpy_parse_and_eval): Likewise.
4827         * python/python-internal.h (gdbpy_allow_threads): New class.
4828
4829 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4830
4831         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4832         (aarch64_fbsd_fpregmap): Move earlier.
4833         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4834         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4835         instead of individual calls to trad_frame_set_reg_addr.
4836         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4837         earlier.
4838         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4839         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4840         instead of individual calls to trad_frame_set_reg_addr.
4841
4842 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4843
4844         * CONTRIBUTE: Replace contribution list with wiki link.
4845
4846 2019-01-25  Tom Tromey  <tom@tromey.com>
4847
4848         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4849
4850 2019-01-25  Tom Tromey  <tom@tromey.com>
4851
4852         * xtensa-linux-nat.c: Fix common/ includes.
4853         * xml-support.h: Fix common/ includes.
4854         * xml-support.c: Fix common/ includes.
4855         * x86-linux-nat.c: Fix common/ includes.
4856         * windows-nat.c: Fix common/ includes.
4857         * varobj.h: Fix common/ includes.
4858         * varobj.c: Fix common/ includes.
4859         * value.c: Fix common/ includes.
4860         * valops.c: Fix common/ includes.
4861         * utils.c: Fix common/ includes.
4862         * unittests/xml-utils-selftests.c: Fix common/ includes.
4863         * unittests/utils-selftests.c: Fix common/ includes.
4864         * unittests/unpack-selftests.c: Fix common/ includes.
4865         * unittests/tracepoint-selftests.c: Fix common/ includes.
4866         * unittests/style-selftests.c: Fix common/ includes.
4867         * unittests/string_view-selftests.c: Fix common/ includes.
4868         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4869         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4870         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4871         * unittests/rsp-low-selftests.c: Fix common/ includes.
4872         * unittests/parse-connection-spec-selftests.c: Fix common/
4873         includes.
4874         * unittests/optional-selftests.c: Fix common/ includes.
4875         * unittests/offset-type-selftests.c: Fix common/ includes.
4876         * unittests/observable-selftests.c: Fix common/ includes.
4877         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4878         * unittests/memrange-selftests.c: Fix common/ includes.
4879         * unittests/memory-map-selftests.c: Fix common/ includes.
4880         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4881         * unittests/function-view-selftests.c: Fix common/ includes.
4882         * unittests/environ-selftests.c: Fix common/ includes.
4883         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4884         * unittests/common-utils-selftests.c: Fix common/ includes.
4885         * unittests/cli-utils-selftests.c: Fix common/ includes.
4886         * unittests/array-view-selftests.c: Fix common/ includes.
4887         * ui-file.c: Fix common/ includes.
4888         * tui/tui-io.c: Fix common/ includes.
4889         * tracepoint.h: Fix common/ includes.
4890         * tracepoint.c: Fix common/ includes.
4891         * tracefile-tfile.c: Fix common/ includes.
4892         * top.h: Fix common/ includes.
4893         * top.c: Fix common/ includes.
4894         * thread.c: Fix common/ includes.
4895         * target/waitstatus.h: Fix common/ includes.
4896         * target/waitstatus.c: Fix common/ includes.
4897         * target.h: Fix common/ includes.
4898         * target.c: Fix common/ includes.
4899         * target-memory.c: Fix common/ includes.
4900         * target-descriptions.c: Fix common/ includes.
4901         * symtab.h: Fix common/ includes.
4902         * symfile.c: Fix common/ includes.
4903         * stap-probe.c: Fix common/ includes.
4904         * spu-linux-nat.c: Fix common/ includes.
4905         * sparc-nat.c: Fix common/ includes.
4906         * source.c: Fix common/ includes.
4907         * solib.c: Fix common/ includes.
4908         * solib-target.c: Fix common/ includes.
4909         * ser-unix.c: Fix common/ includes.
4910         * ser-tcp.c: Fix common/ includes.
4911         * ser-pipe.c: Fix common/ includes.
4912         * ser-base.c: Fix common/ includes.
4913         * selftest-arch.c: Fix common/ includes.
4914         * s12z-tdep.c: Fix common/ includes.
4915         * rust-exp.y: Fix common/ includes.
4916         * rs6000-aix-tdep.c: Fix common/ includes.
4917         * riscv-tdep.c: Fix common/ includes.
4918         * remote.c: Fix common/ includes.
4919         * remote-notif.h: Fix common/ includes.
4920         * remote-fileio.h: Fix common/ includes.
4921         * remote-fileio.c: Fix common/ includes.
4922         * regcache.h: Fix common/ includes.
4923         * regcache.c: Fix common/ includes.
4924         * record-btrace.c: Fix common/ includes.
4925         * python/python.c: Fix common/ includes.
4926         * python/py-type.c: Fix common/ includes.
4927         * python/py-inferior.c: Fix common/ includes.
4928         * progspace.h: Fix common/ includes.
4929         * producer.c: Fix common/ includes.
4930         * procfs.c: Fix common/ includes.
4931         * proc-api.c: Fix common/ includes.
4932         * printcmd.c: Fix common/ includes.
4933         * ppc-linux-nat.c: Fix common/ includes.
4934         * parser-defs.h: Fix common/ includes.
4935         * osdata.c: Fix common/ includes.
4936         * obsd-nat.c: Fix common/ includes.
4937         * nat/x86-linux.c: Fix common/ includes.
4938         * nat/x86-linux-dregs.c: Fix common/ includes.
4939         * nat/x86-dregs.h: Fix common/ includes.
4940         * nat/x86-dregs.c: Fix common/ includes.
4941         * nat/ppc-linux.c: Fix common/ includes.
4942         * nat/mips-linux-watch.h: Fix common/ includes.
4943         * nat/mips-linux-watch.c: Fix common/ includes.
4944         * nat/linux-waitpid.c: Fix common/ includes.
4945         * nat/linux-ptrace.h: Fix common/ includes.
4946         * nat/linux-ptrace.c: Fix common/ includes.
4947         * nat/linux-procfs.c: Fix common/ includes.
4948         * nat/linux-personality.c: Fix common/ includes.
4949         * nat/linux-osdata.c: Fix common/ includes.
4950         * nat/linux-namespaces.c: Fix common/ includes.
4951         * nat/linux-btrace.h: Fix common/ includes.
4952         * nat/linux-btrace.c: Fix common/ includes.
4953         * nat/fork-inferior.c: Fix common/ includes.
4954         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4955         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4956         * nat/aarch64-linux.c: Fix common/ includes.
4957         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4958         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4959         * namespace.h: Fix common/ includes.
4960         * mips-linux-tdep.c: Fix common/ includes.
4961         * minsyms.c: Fix common/ includes.
4962         * mi/mi-parse.h: Fix common/ includes.
4963         * mi/mi-main.c: Fix common/ includes.
4964         * mi/mi-cmd-env.c: Fix common/ includes.
4965         * memrange.h: Fix common/ includes.
4966         * memattr.c: Fix common/ includes.
4967         * maint.h: Fix common/ includes.
4968         * maint.c: Fix common/ includes.
4969         * main.c: Fix common/ includes.
4970         * machoread.c: Fix common/ includes.
4971         * location.c: Fix common/ includes.
4972         * linux-thread-db.c: Fix common/ includes.
4973         * linux-nat.c: Fix common/ includes.
4974         * linux-fork.c: Fix common/ includes.
4975         * inline-frame.c: Fix common/ includes.
4976         * infrun.c: Fix common/ includes.
4977         * inflow.c: Fix common/ includes.
4978         * inferior.h: Fix common/ includes.
4979         * inferior.c: Fix common/ includes.
4980         * infcmd.c: Fix common/ includes.
4981         * inf-ptrace.c: Fix common/ includes.
4982         * inf-child.c: Fix common/ includes.
4983         * ia64-linux-nat.c: Fix common/ includes.
4984         * i387-tdep.c: Fix common/ includes.
4985         * i386-tdep.c: Fix common/ includes.
4986         * i386-linux-tdep.c: Fix common/ includes.
4987         * i386-linux-nat.c: Fix common/ includes.
4988         * i386-go32-tdep.c: Fix common/ includes.
4989         * i386-fbsd-tdep.c: Fix common/ includes.
4990         * i386-fbsd-nat.c: Fix common/ includes.
4991         * guile/scm-type.c: Fix common/ includes.
4992         * guile/guile.c: Fix common/ includes.
4993         * go32-nat.c: Fix common/ includes.
4994         * gnu-nat.c: Fix common/ includes.
4995         * gdbthread.h: Fix common/ includes.
4996         * gdbarch-selftests.c: Fix common/ includes.
4997         * gdb_usleep.c: Fix common/ includes.
4998         * gdb_select.h: Fix common/ includes.
4999         * gdb_bfd.c: Fix common/ includes.
5000         * gcore.c: Fix common/ includes.
5001         * fork-child.c: Fix common/ includes.
5002         * findvar.c: Fix common/ includes.
5003         * fbsd-nat.c: Fix common/ includes.
5004         * event-top.c: Fix common/ includes.
5005         * event-loop.c: Fix common/ includes.
5006         * dwarf2read.c: Fix common/ includes.
5007         * dwarf2loc.c: Fix common/ includes.
5008         * dwarf2-frame.c: Fix common/ includes.
5009         * dwarf-index-cache.c: Fix common/ includes.
5010         * dtrace-probe.c: Fix common/ includes.
5011         * disasm-selftests.c: Fix common/ includes.
5012         * defs.h: Fix common/ includes.
5013         * csky-tdep.c: Fix common/ includes.
5014         * cp-valprint.c: Fix common/ includes.
5015         * cp-support.h: Fix common/ includes.
5016         * cp-support.c: Fix common/ includes.
5017         * corelow.c: Fix common/ includes.
5018         * completer.h: Fix common/ includes.
5019         * completer.c: Fix common/ includes.
5020         * compile/compile.c: Fix common/ includes.
5021         * compile/compile-loc2c.c: Fix common/ includes.
5022         * compile/compile-cplus-types.c: Fix common/ includes.
5023         * compile/compile-cplus-symbols.c: Fix common/ includes.
5024         * command.h: Fix common/ includes.
5025         * cli/cli-dump.c: Fix common/ includes.
5026         * cli/cli-cmds.c: Fix common/ includes.
5027         * charset.c: Fix common/ includes.
5028         * build-id.c: Fix common/ includes.
5029         * btrace.h: Fix common/ includes.
5030         * btrace.c: Fix common/ includes.
5031         * breakpoint.h: Fix common/ includes.
5032         * breakpoint.c: Fix common/ includes.
5033         * ax.h:
5034         (enum agent_op): Fix common/ includes.
5035         * ax-general.c (struct aop_map): Fix common/ includes.
5036         * ax-gdb.c: Fix common/ includes.
5037         * auxv.c: Fix common/ includes.
5038         * auto-load.c: Fix common/ includes.
5039         * arm-tdep.c: Fix common/ includes.
5040         * arch/riscv.c: Fix common/ includes.
5041         * arch/ppc-linux-common.c: Fix common/ includes.
5042         * arch/i386.c: Fix common/ includes.
5043         * arch/arm.c: Fix common/ includes.
5044         * arch/arm-linux.c: Fix common/ includes.
5045         * arch/arm-get-next-pcs.c: Fix common/ includes.
5046         * arch/amd64.c: Fix common/ includes.
5047         * arch/aarch64.c: Fix common/ includes.
5048         * arch/aarch64-insn.c: Fix common/ includes.
5049         * arch-utils.c: Fix common/ includes.
5050         * amd64-windows-tdep.c: Fix common/ includes.
5051         * amd64-tdep.c: Fix common/ includes.
5052         * amd64-sol2-tdep.c: Fix common/ includes.
5053         * amd64-obsd-tdep.c: Fix common/ includes.
5054         * amd64-nbsd-tdep.c: Fix common/ includes.
5055         * amd64-linux-tdep.c: Fix common/ includes.
5056         * amd64-linux-nat.c: Fix common/ includes.
5057         * amd64-fbsd-tdep.c: Fix common/ includes.
5058         * amd64-fbsd-nat.c: Fix common/ includes.
5059         * amd64-dicos-tdep.c: Fix common/ includes.
5060         * amd64-darwin-tdep.c: Fix common/ includes.
5061         * agent.c: Fix common/ includes.
5062         * ada-lang.h: Fix common/ includes.
5063         * ada-lang.c: Fix common/ includes.
5064         * aarch64-tdep.c: Fix common/ includes.
5065
5066 2019-01-25  Tom Tromey  <tom@tromey.com>
5067
5068         * common/create-version.sh: Use common/version.h.
5069
5070 2019-01-24  Pedro Alves  <palves@redhat.com>
5071
5072         * infrun.c (signal_stop, signal_print, signal_program)
5073         (signal_catch, signal_pass): Now arrays instead of pointers.
5074         (update_signals_program_target, do_target_resume)
5075         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5076         * linux-nat.c (linux_nat_target::pass_signals)
5077         (linux_nat_target::create_inferior, linux_nat_target::attach):
5078         Adjust.
5079         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5080         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5081         * procfs.c (procfs_target::pass_signals): Adjust.
5082         * record-full.c (record_full_target::resume): Adjust.
5083         * remote.c (remote_target::pass_signals)
5084         (remote_target::program_signals): Adjust.
5085         * target-debug.h (target_debug_print_signals): Now takes a
5086         gdb::array_view as parameter.  Adjust.
5087         * target.h (target_ops) <pass_signals, program_signals>: Replace
5088         pointer and length parameters with gdb::array_view.
5089         (target_pass_signals, target_program_signals): Likewise.
5090         * target-delegates.c: Regenerate.
5091
5092 2019-01-24  Pedro Alves  <palves@redhat.com>
5093
5094         * common/forward-scope-exit.h
5095         (forward_scope_exit::forward_scope_exit): Pass arguments to
5096         m_bind_function directly, instead of creating a std::bind and
5097         copying that.
5098
5099 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5100
5101         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5102         for static members.
5103         (pass_in_v_vfp_candidate): Likewise.
5104
5105 2019-01-23  Tom Tromey  <tom@tromey.com>
5106             Pedro Alves  <palves@redhat.com>
5107
5108         * regcache.c (class regcache_invalidator): Remove.
5109         (regcache::raw_write): Use make_scope_exit.
5110
5111 2019-01-23  Tom Tromey  <tom@tromey.com>
5112
5113         * ui-out.h (class ui_out_emit_type): Update comment.
5114
5115 2019-01-23  Tom Tromey  <tom@tromey.com>
5116
5117         * infrun.c (fetch_inferior_event): Update comment.
5118
5119 2019-01-23  Tom Tromey  <tom@tromey.com>
5120             Pedro Alves  <palves@redhat.com>
5121
5122         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5123         parameter.
5124         (fetch_inferior_event): Use SCOPE_EXIT.
5125
5126
5127 2019-01-23  Tom Tromey  <tom@tromey.com>
5128             Pedro Alves  <palves@redhat.com>
5129
5130         * infrun.c (disable_thread_events): Delete.
5131         (stop_all_threads): Use SCOPE_EXIT.
5132
5133 2019-01-23  Tom Tromey  <tom@tromey.com>
5134             Pedro Alves  <palves@redhat.com>
5135
5136         * symfile.c: Include forward-scope-exit.h.
5137         (clear_symtab_users_cleanup): Replace forward declaration with
5138         a FORWARD_SCOPE_EXIT.
5139         (syms_from_objfile_1): Use the forward_scope_exit and
5140         gdb::optional instead of cleanup_function.
5141         (reread_symbols): Use the forward_scope_exit instead of
5142         cleanup_function.
5143         (clear_symtab_users_cleanup): Remove function.
5144
5145 2019-01-23  Tom Tromey  <tom@tromey.com>
5146             Pedro Alves  <palves@redhat.com>
5147
5148         * linux-nat.c: Include scope-exit.h.
5149         (cleanup_target_stop): Remove.
5150         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5151         SCOPE_EXIT.
5152
5153 2019-01-23  Tom Tromey  <tom@tromey.com>
5154             Pedro Alves  <palves@redhat.com>
5155
5156         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5157         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5158
5159 2019-01-23  Tom Tromey  <tom@tromey.com>
5160             Andrew Burgess  <andrew.burgess@embecosm.com>
5161             Pedro Alves  <palves@redhat.com>
5162
5163         * infrun.c (fetch_inferior_event): Use scope_exit.
5164         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5165         * top.c (execute_command): Use scope_exit.
5166         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5167         * utils.c (do_bpstat_clear_actions_cleanup)
5168         (make_bpstat_clear_actions_cleanup): Remove.
5169
5170 2019-01-23  Tom Tromey  <tom@tromey.com>
5171             Pedro Alves  <palves@redhat.com>
5172
5173         * infrun.c: Include "common/scope-exit.h"
5174         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5175         (wait_for_inferior): Use SCOPE_EXIT.
5176         (fetch_inferior_event): Use scope_exit.
5177
5178 2019-01-23  Tom Tromey  <tom@tromey.com>
5179             Pedro Alves  <palves@redhat.com>
5180
5181         * breakpoint.c (create_breakpoint): Remove cleanup.
5182
5183 2019-01-23  Tom Tromey  <tom@tromey.com>
5184             Andrew Burgess  <andrew.burgess@embecosm.com>
5185             Pedro Alves  <palves@redhat.com>
5186
5187 2019-01-23  Pedro Alves  <palves@redhat.com>
5188
5189         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5190
5191 2019-01-23  Pedro Alves  <palves@redhat.com>
5192             Andrew Burgess  <andrew.burgess@embecosm.com>
5193
5194         * gdbthread.h: Include "common/forward-scope-exit.h".
5195         (scoped_finish_thread_state): Redefine custom class in terms of
5196         forward_scope_exit.
5197
5198 2019-01-23  Pedro Alves  <palves@redhat.com>
5199             Andrew Burgess  <andrew.burgess@embecosm.com>
5200
5201         * common/forward-scope-exit.h: New file.
5202
5203 2019-01-23  Pedro Alves  <palves@redhat.com>
5204             Andrew Burgess  <andrew.burgess@embecosm.com>
5205             Tom Tromey  <tom@tromey.com>
5206
5207         * common/scope-exit.h: New file.
5208
5209 2019-01-23  Pedro Alves  <palves@redhat.com>
5210
5211         * common/preprocessor.h (ESC): Rename to ...
5212         (ESC_PARENS): ... this.
5213         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5214         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5215
5216 2019-01-23  Tom Tromey  <tom@tromey.com>
5217
5218         * language.h (class scoped_switch_to_sym_language_if_auto):
5219         Initialize m_lang in both cases.
5220
5221 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5222
5223         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5224         with XCNEW.
5225
5226 2019-01-22  Tom Tromey  <tom@tromey.com>
5227
5228         * corelow.c: Do not include sys/file.h.
5229
5230 2019-01-22  Tom Tromey  <tom@tromey.com>
5231
5232         * tui/tui-wingeneral.h: Include gdb_curses.h.
5233
5234 2019-01-22  Tom Tromey  <tom@tromey.com>
5235
5236         * source-cache.h (class source_cache) <get_source_lines,
5237         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5238
5239 2019-01-22  Tom Tromey  <tom@tromey.com>
5240
5241         * remote-fileio.h (struct remote_target): Declare.
5242
5243 2019-01-22  Tom Tromey  <tom@tromey.com>
5244
5245         * python/py-arch.c: Do not include py-ref.h.
5246         * python/py-bpevent.c: Do not include py-ref.h.
5247         * python/py-cmd.c: Do not include py-ref.h.
5248         * python/py-continueevent.c: Do not include py-ref.h.
5249         * python/py-event.h: Do not include py-ref.h.
5250         * python/py-evtregistry.c: Do not include py-ref.h.
5251         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5252         * python/py-frame.c: Do not include py-ref.h.
5253         * python/py-framefilter.c: Do not include py-ref.h.
5254         * python/py-function.c: Do not include py-ref.h.
5255         * python/py-infevents.c: Do not include py-ref.h.
5256         * python/py-linetable.c: Do not include py-ref.h.
5257         * python/py-objfile.c: Do not include py-ref.h.
5258         * python/py-param.c: Do not include py-ref.h.
5259         * python/py-prettyprint.c: Do not include py-ref.h.
5260         * python/py-progspace.c: Do not include py-ref.h.
5261         * python/py-symbol.c: Do not include py-ref.h.
5262         * python/py-symtab.c: Do not include py-ref.h.
5263         * python/py-type.c: Do not include py-ref.h.
5264         * python/py-unwind.c: Do not include py-ref.h.
5265         * python/py-utils.c: Do not include py-ref.h.
5266         * python/py-value.c: Do not include py-ref.h.
5267         * python/py-varobj.c: Do not include py-ref.h.
5268         * python/py-xmethods.c: Do not include py-ref.h.
5269         * python/python.c: Do not include py-ref.h.
5270         * varobj.c: Do not include py-ref.h.
5271
5272 2019-01-22  Tom Tromey  <tom@tromey.com>
5273
5274         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5275         keyword for bcache.
5276
5277 2019-01-22  Tom Tromey  <tom@tromey.com>
5278
5279         * compile/compile-cplus-types.c: Remove a comment by #include.
5280
5281 2019-01-22  Tom Tromey  <tom@tromey.com>
5282
5283         * compile/gcc-c-plugin.h: Include compile-internal.h.
5284
5285 2019-01-22  Tom Tromey  <tom@tromey.com>
5286
5287         * stabsread.c (EXTERN): Do not define.
5288         (symnum, next_symbol_text_func, processing_gcc_compilation)
5289         (within_function, global_sym_chain, global_stabs)
5290         (previous_stab_code, this_object_header_files)
5291         (n_this_object_header_files)
5292         (n_allocated_this_object_header_files): Define.
5293         * stabsread.h (EXTERN): Never define.  Use "extern".
5294
5295 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5296
5297         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5298         history_value.
5299
5300 2019-01-21  Tom Tromey  <tom@tromey.com>
5301
5302         * ui-out.c: Fix includes.
5303         * tui/tui-source.c: Fix includes.
5304         * target.c: Fix includes.
5305         * remote.c: Fix includes.
5306         * regcache.c: Fix includes.
5307         * python/py-block.c: Fix includes.
5308         * printcmd.c: Fix includes.
5309         * or1k-tdep.c: Fix includes.
5310         * mi/mi-main.c: Fix includes.
5311         * m32r-tdep.c: Fix includes.
5312         * csky-tdep.c: Fix includes.
5313         * compile/compile-cplus-types.c: Fix includes.
5314         * cli/cli-interp.c: Fix includes.
5315
5316 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5317
5318         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5319         for padding.
5320
5321 2019-01-16  Tom Tromey  <tom@tromey.com>
5322
5323         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5324         earlier.
5325         (struct objfile) <msymbols_range>: Move from top level.
5326         <msymbols>: New method.
5327         (class objfile_msymbols): Remove.
5328         * symtab.c (default_collect_symbol_completion_matches_break_on):
5329         Update.
5330         * symmisc.c (dump_msymbols): Update.
5331         * stabsread.c (scan_file_globals): Update.
5332         * objc-lang.c (info_selectors_command, info_classes_command)
5333         (find_methods): Update.
5334         * minsyms.c (find_solib_trampoline_target): Update.
5335         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5336         * coffread.c (coff_symfile_read): Update.
5337         * ada-lang.c (ada_lookup_simple_minsym)
5338         (ada_collect_symbol_completion_matches): Update.
5339
5340 2019-01-16  Tom Tromey  <tom@tromey.com>
5341
5342         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5343         type.  Remove no-argument constructor.
5344         <iterator::operator++>: Simplify.
5345         <begin>: Update.
5346         <end>: Use minimal_symbol_count.
5347
5348 2019-01-16  Tom Tromey  <tom@tromey.com>
5349
5350         * objfiles.h (struct objfile) <psymtabs>: New method.
5351         (class objfile_psymtabs): Remove.
5352         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5353         typedef.
5354         <range>: New method.
5355         (require_partial_symbols): Change return type.
5356         * psymtab.c (require_partial_symbols)
5357         (psym_expand_symtabs_matching): Update.
5358         * mdebugread.c (parse_partial_symbols): Update.
5359         * dbxread.c (dbx_end_psymtab): Update.
5360
5361 2019-01-15  Tom Tromey  <tom@tromey.com>
5362
5363         * symtab.c (lookup_objfile_from_block)
5364         (lookup_symbol_in_objfile_symtabs)
5365         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5366         (find_line_symtab, info_sources_command)
5367         (default_collect_symbol_completion_matches_break_on)
5368         (make_source_files_completion_list): Update.
5369         * symmisc.c (print_objfile_statistics, dump_objfile)
5370         (maintenance_print_symbols, maintenance_info_symtabs)
5371         (maintenance_check_symtabs, maintenance_info_line_tables):
5372         Update.
5373         * source.c (select_source_symtab)
5374         (forget_cached_source_info_for_objfile): Update.
5375         * objfiles.h (class objfile_compunits): Remove.
5376         (struct objfile) <compunits_range>: New typedef.
5377         (compunits): New method.
5378         * objfiles.c (objfile_relocate1): Update.
5379         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5380         * maint.c (count_symtabs_and_blocks): Update.
5381         * linespec.c (iterate_over_all_matching_symtabs): Update.
5382         * cp-support.c (add_symbol_overload_list_qualified): Update.
5383         * coffread.c (coff_symtab_read): Update.
5384         * ada-lang.c (add_nonlocal_symbols)
5385         (ada_collect_symbol_completion_matches)
5386         (ada_add_global_exceptions): Update.
5387
5388 2019-01-15  Tom Tromey  <tom@tromey.com>
5389
5390         * progspace.h (program_space) <objfiles_safe_range>: New
5391         typedef.
5392         <objfiles_safe>: New method.
5393         * objfiles.h (class all_objfiles_safe): Remove.
5394         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5395         * jit.c (jit_inferior_exit_hook): Update.
5396
5397 2019-01-17  Tom Tromey  <tom@tromey.com>
5398
5399         * progspace.h (program_space) <objfiles_range>: New typedef.
5400         <objfiles>: New method.
5401         <objfiles_head>: Rename from objfiles.
5402         (object_files): Update.
5403         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5404         * guile/scm-pretty-print.c
5405         (ppscm_find_pretty_printer_from_objfiles): Update.
5406         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5407         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5408         Update.
5409         * python/py-progspace.c (pspy_get_objfiles): Update.
5410         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5411         Update.
5412         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5413         (objfpy_lookup_objfile_by_build_id): Update.
5414         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5415         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5416         Update.
5417         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5418         (expand_symtab_containing_pc, lookup_objfile_from_block)
5419         (lookup_static_symbol, basic_lookup_transparent_type)
5420         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5421         (find_line_symtab, info_sources_command)
5422         (default_collect_symbol_completion_matches_break_on)
5423         (make_source_files_completion_list, find_main_name): Update.
5424         * symmisc.c (print_symbol_bcache_statistics)
5425         (print_objfile_statistics, maintenance_print_symbols)
5426         (maintenance_print_msymbols, maintenance_print_objfiles)
5427         (maintenance_info_symtabs, maintenance_check_symtabs)
5428         (maintenance_expand_symtabs, maintenance_info_line_tables):
5429         Update.
5430         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5431         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5432         (map_overlay_command, unmap_overlay_command)
5433         (simple_overlay_update, expand_symtabs_matching)
5434         (map_symbol_filenames): Update.
5435         * symfile-debug.c (set_debug_symfile): Update.
5436         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5437         Update.
5438         * source.c (select_source_symtab, forget_cached_source_info):
5439         Update.
5440         * solib.c (solib_read_symbols): Update.
5441         * solib-spu.c (append_ocl_sos): Update.
5442         * psymtab.c (maintenance_print_psymbols)
5443         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5444         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5445         * printcmd.c (info_symbol_command): Update.
5446         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5447         Update.
5448         * objfiles.h (class all_objfiles): Remove.
5449         * objfiles.c (have_partial_symbols, have_full_symbols)
5450         (have_minimal_symbols, qsort_cmp, update_section_map)
5451         (shared_objfile_contains_address_p)
5452         (default_iterate_over_objfiles_in_search_order): Update.
5453         * objc-lang.c (info_selectors_command, info_classes_command)
5454         (find_methods): Update.
5455         * minsyms.c (find_solib_trampoline_target): Update.
5456         * maint.c (maintenance_info_sections)
5457         (maintenance_translate_address, count_symtabs_and_blocks):
5458         Update.
5459         * main.c (captured_main_1): Update.
5460         * linux-thread-db.c (try_thread_db_load_from_pdir)
5461         (has_libpthread): Update.
5462         * linespec.c (iterate_over_all_matching_symtabs)
5463         (search_minsyms_for_name): Update.
5464         * jit.c (jit_find_objf_with_entry_addr): Update.
5465         * hppa-tdep.c (find_unwind_entry)
5466         (hppa_lookup_stub_minimal_symbol): Update.
5467         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5468         Update.
5469         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5470         (elf_gnu_ifunc_resolve_by_got): Update.
5471         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5472         * dwarf-index-write.c (save_gdb_index_command): Update.
5473         * cp-support.c (add_symbol_overload_list_qualified): Update.
5474         * breakpoint.c (create_overlay_event_breakpoint)
5475         (create_longjmp_master_breakpoint)
5476         (create_std_terminate_master_breakpoint)
5477         (create_exception_master_breakpoint): Update.
5478         * blockframe.c (find_pc_partial_function): Update.
5479         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5480         (ada_collect_symbol_completion_matches)
5481         (ada_add_global_exceptions): Update.
5482
5483 2019-01-17  Tom Tromey  <tom@tromey.com>
5484
5485         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5486         declare VEC.
5487         (solib_target_parse_libraries): Change return type.
5488         (library_list_start_segment, library_list_start_section)
5489         (library_list_end_library, library_list_start_library); Update.
5490         (solib_target_free_library_list): Remove.
5491         (solib_target_parse_libraries): Remove cleanup.  Change return
5492         type.
5493         (solib_target_current_sos): Update.
5494
5495 2019-01-17  Tom Tromey  <tromey@bapiya>
5496
5497         * valprint.c: Replace "the the" with "the".
5498         * symtab.c: Replace "the the" with "the".
5499         * solib.c: Replace "the the" with "the".
5500         * solib-dsbt.c: Replace "the the" with "the".
5501         * linespec.c: Replace "the the" with "the".
5502         * dwarf2loc.h: Replace "the the" with "the".
5503         * amd64-windows-tdep.c: Replace "the the" with "the".
5504         * aarch64-tdep.c: Replace "the the" with "the".
5505
5506 2019-01-16  Keith Seitz  <keiths@redhat.com>
5507
5508         PR gdb/23773
5509         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5510         <builder>: Rename to ..
5511         <m_builder>: ... this and make private.
5512         (dwarf2_cu::get_builder): New method.  Change all users of
5513         `builder' to use this method.
5514         (dwarf2_start_symtab): Move to ...
5515         (dwarf2_cu::start_symtab): ... here.  Update all callers
5516         (setup_type_unit_groups): Move to ...
5517         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5518         callers.
5519         (dwarf2_cu::reset_builder): New method.
5520         (process_full_compunit, process_full_type_unit): Use
5521         dwarf2_cu::reset_builder.
5522         (follow_die_offset): Record the ancestor CU if it is different
5523         from the followed DIE's CU.
5524         (follow_die_sig_1): Likewise.
5525
5526 2019-01-15  Tom Tromey  <tom@tromey.com>
5527
5528         * remote.c (class remote_state) <buf>: Now a char_vector.
5529         <buf_size>: Remove.
5530         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5531         parameter.
5532         (remote_target::getpkt_or_notif_sane_1)
5533         (remote_target::getpkt_sane)
5534         (remote_target::getpkt_or_notif_sane): Likewise.
5535         (class remote_target) <putpkt>: New overload.
5536         (remote_target::read_frame): Change type of "buf_p".  Remove
5537         sizeof_p parameter.
5538         (packet_ok): New overload.
5539         (packet_check_result): New overload.
5540         Update all uses.
5541
5542 2019-01-14  Tom Tromey  <tom@tromey.com>
5543
5544         * remote-notif.c (handle_notification, remote_notif_ack)
5545         (remote_notif_parse): Make "buf" const.
5546         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5547         const.
5548         (remote_notif_parse, remote_notif_ack, handle_notification):
5549         Likewise.
5550         * remote.c (remote_notif_stop_parse): Make "buf" const.
5551         (remote_target::remote_parse_stop_reply): Make "buf" const.
5552         (remote_notif_stop_ack): Make "buf" const.
5553
5554 2019-01-14  Tom Tromey  <tom@tromey.com>
5555
5556         * remote.c (remote_console_output): Make parameter const.
5557
5558 2019-01-14  Tom Tromey  <tom@tromey.com>
5559
5560         * target-debug.h (target_debug_print_signals): Constify.
5561         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5562         * procfs.c (procfs_target::pass_signals): Update.
5563         * linux-nat.c (linux_nat_target::pass_signals): Update.
5564         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5565         * target-delegates.c: Rebuild.
5566         * remote.c (remote_target::program_signals): Update.
5567         (remote_target::pass_signals): Update.
5568         * target.c (target_pass_signals): Constify argument.
5569         (target_program_signals): Likewise.
5570         * target.h (struct target_ops) <pass_signals, program_signals>:
5571         Constify argument.
5572         (target_pass_signals, target_program_signals): Constify argument.
5573
5574 2019-01-14  Tom Tromey  <tom@tromey.com>
5575
5576         PR tui/28819:
5577         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5578
5579 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5580
5581         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5582         field.
5583         * rs6000-tdep.c: Include reggroups.h.
5584         (IS_V_ALIAS_PSEUDOREG): Define.
5585         (rs6000_register_name): Return names for the "vX" aliases.
5586         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5587         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5588         aliases.  Call default_register_reggroup_p for all other
5589         pseudo-registers.
5590         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5591         New functions.
5592         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5593         Handle "vX" aliases.
5594         (v_alias_pseudo_register_collect): New function.
5595         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5596         (rs6000_gdbarch_init): Initialize "vX" aliases as
5597         pseudo-registers.  Restore registration of
5598         rs6000_pseudo_register_reggroup_p with
5599         set_tdesc_pseudo_register_reggroup_p.
5600
5601 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5602
5603         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5604         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5605         set_gdbarch_num_pseudo_regs.
5606
5607 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5608
5609         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5610         Remove arg prefixname, add do_set and do_show.
5611         Add member functions set_list and show_list.
5612         * cli/cli-style.c (class cli_style_option): Update accordingly.
5613         (style_set_list): Move to file scope.
5614         (style_show_list): Likewise.
5615         (set_style): Call help_list.
5616         (show_style): Call cmd_show_list.
5617         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5618         Update to use the new macro.
5619
5620 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5621
5622         * ada-lang.c (_initialize_ada_language): Expand the help text
5623         for the "catch exception" command.
5624
5625 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5626
5627         * symtab.c (matching_obj_sections): Initialize obj,
5628         declare it closer to its usage.
5629
5630 2019-01-10  Tom Tromey  <tom@tromey.com>
5631
5632         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5633         (basic_inf_threads_range): Remove.
5634         (inf_threads_range, inf_non_exited_threads_range)
5635         (safe_inf_threads_range): Use next_adapter.
5636
5637 2019-01-10  Keith Seitz  <keiths@redhat.com>
5638
5639         PR gdb/23712
5640         PR symtab/23010
5641         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5642         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5643
5644 2019-01-10  Keith Seitz  <keiths@redhat.com>
5645
5646         PR gdb/23712
5647         PR symtab/23010
5648         * dictionary.c (pending_to_vector): Remove.
5649         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5650         Remove _1 suffix, replacing functions of the same name.  Update
5651         all callers.
5652         (dict_create_hashed, dict_create_hashed_expandable)
5653         (dict_create_linear, dict_create_linear_expandable, dict_free)
5654         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5655         Make functions static.
5656
5657 2019-01-10  Keith Seitz  <keiths@redhat.com>
5658
5659         PR gdb/23712
5660         PR symtab/23010
5661         * dictionary.h (struct dictionary): Replace declaration with
5662         multidictionary.
5663         (dict_create_hashed, dict_create_hashed_expandable)
5664         (dict_create_linear, dict_create_linear_expandable)
5665         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5666         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5667         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5668         taking multidictionary argument.
5669         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5670         * block.h (struct block) <dict>: Change to multidictionary
5671         and rename `multidict'.
5672         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5673         symmisc.c: Update all dictionary references to multidictionary.
5674
5675 2019-01-10  Keith Seitz  <keiths@redhat.com>
5676
5677         PR gdb/23712
5678         PR symtab/23010
5679         * dictionary.c: Include unordered_map.
5680         (pending_to_vector): New function.
5681         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5682         Rewrite the non-"_1" functions to take vector instead
5683         of linked list.
5684         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5685         "new" _1 versions of the same name.
5686         (multidictionary): Define.
5687         (std::hash<enum language): New definition.
5688         (collate_pending_symbols_by_language, mdict_create_hashed)
5689         (mdict_create_hashed_expandable, mdict_create_linear)
5690         (mdict_create_linear_expandable, mdict_free)
5691         (find_language_dictionary, create_new_language_dictionary)
5692         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5693         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5694         (mdict_size, mdict_empty): New functions.
5695         * dictionary.h (mdict_iterator): Define.
5696
5697 2019-01-10  Pedro Alves  <palves@redhat.com>
5698
5699         * breakpoint.c (read_uploaded_action)
5700         (create_tracepoint_from_upload): Adjust to use
5701         gdb::unique_xmalloc_ptr.
5702         * ctf.c (ctf_write_uploaded_tp):
5703         (SET_ARRAY_FIELD): Use emplace_back.
5704         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5705         * tracefile-tfile.c (tfile_write_uploaded_tp):
5706         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5707         gdb::unique_xmalloc_ptr.
5708         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5709         at_string, cond_string, cmd_strings>: Replace char pointers
5710         with gdb::unique_xmalloc_ptr.
5711
5712 2019-01-10  Pedro Alves  <palves@redhat.com>
5713
5714         * solib-target.c (library_list_start_library): Don't xstrdup name.
5715
5716 2019-01-10  Pedro Alves  <palves@redhat.com>
5717
5718         * mdebugread.c (parse_partial_symbols): Use
5719         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5720
5721 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5722
5723         * linux-fork.c (scoped_switch_fork_info)
5724         <~scoped_switch_fork_info>: Fix incorrect variable name.
5725
5726 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * linux-fork.c (scoped_switch_fork_info)
5729         <scoped_switch_fork_info>: Make explicit.
5730         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5731
5732 2019-01-10  Tom Tromey  <tom@tromey.com>
5733
5734         * objfiles.h (objfile::reset_psymtabs): Update.
5735         * objfiles.c (objfile::objfile): Update.
5736         * psymtab.h (psymtab_storage::obstack): Update.
5737         (psymtab_storage::m_obstack): Use gdb::optional.
5738         (class psymtab_storage): Update comment.  Remove objfile
5739         parameter.
5740         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5741
5742 2019-01-10  Tom Tromey  <tom@tromey.com>
5743
5744         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5745         <free_psymtabs>: Now private.
5746         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5747         (allocate_psymtab): Use new method.
5748
5749 2019-01-10  Tom Tromey  <tom@tromey.com>
5750
5751         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5752         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5753         * mdebugread.c (parse_partial_symbols): Use
5754         allocate_dependencies.
5755         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5756         allocate_dependencies.
5757         (process_psymtab_comp_unit_reader)
5758         (build_type_psymtab_dependencies): Likewise.
5759         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5760
5761 2019-01-10  Tom Tromey  <tom@tromey.com>
5762
5763         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5764         PSYMBOL_SET_LANGUAGE.
5765         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5766
5767 2019-01-10  Tom Tromey  <tom@tromey.com>
5768
5769         * psymtab.h (psymtab_storage::obstack): New method.
5770         <m_obstack>: Rename from obstack; now private.
5771         * psymtab.c (psymtab_storage): Update.
5772         * dwarf2read.c (create_addrmap_from_index)
5773         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5774         Update.
5775
5776 2019-01-10  Tom Tromey  <tom@tromey.com>
5777
5778         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5779         * objfiles.h (objfile::reset_psymtabs): New method.
5780
5781 2019-01-10  Tom Tromey  <tom@tromey.com>
5782
5783         * symmisc.c (print_symbol_bcache_statistics): Update.
5784         (print_objfile_statistics): Update.
5785         * symfile.c (reread_symbols): Update.
5786         * psymtab.h (class psymtab_storage): New.
5787         * psymtab.c (psymtab_storage): New constructor.
5788         (~psymtab_storage): New destructor.
5789         (require_partial_symbols): Update.
5790         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5791         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5792         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5793         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5794         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5795         (start_psymtab_common, end_psymtab_common)
5796         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5797         (allocate_psymtab): Update.
5798         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5799         Update.
5800         (dump_psymtab_addrmap, maintenance_print_psymbols)
5801         (maintenance_check_psymtabs): Update.
5802         (class objfile_psymtabs): Move to objfiles.h.
5803         * psympriv.h (discard_psymtab): Now inline.
5804         (psymtab_discarder::psymtab_discarder): Update.
5805         (psymtab_discarder::~psymtab_discarder): Update.
5806         (ALL_OBJFILE_PSYMTABS): Rewrite.
5807         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5808         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5809         Remove fields.
5810         <partial_symtabs>: New field.
5811         (class objfile_psymtabs): Move from psymtab.h.  Update.
5812         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5813         psymbol_cache.
5814         (objfile::~objfile): Don't destroy psymbol_cache.
5815         * mdebugread.c (parse_partial_symbols): Update.
5816         * dwarf2read.c (create_addrmap_from_index)
5817         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5818         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5819         (add_partial_subprogram, dwarf2_ranges_read): Update.
5820         * dwarf-index-write.c (write_address_map)
5821         (write_one_signatured_type, recursively_write_psymbols)
5822         (class debug_names, class debug_names, write_psymtabs_to_index):
5823         Update.
5824
5825 2019-01-10  Tom Tromey  <tom@tromey.com>
5826
5827         * symtab.h (SYMBOL_SET_NAMES): Update.
5828         (symbol_set_names): Update.
5829         (MSYMBOL_SET_NAMES): Update.
5830         * symtab.c (symbol_set_names): Change argument to be an
5831         objfile_per_bfd_storage.
5832         * psymtab.c (add_psymbol_to_bcache): Update.
5833         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5834
5835 2019-01-10  Tom Tromey  <tom@tromey.com>
5836
5837         * symtab.c (create_demangled_names_hash): Change argument to be an
5838         objfile_per_bfd_storage.
5839         (symbol_set_names): Update.
5840
5841 2019-01-10  Tom Tromey  <tom@tromey.com>
5842
5843         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5844         init_psymbol_list.
5845         * psymtab.c (init_psymbol_list): Do nothing if already called.
5846         * psympriv.h (init_psymbol_list): Add comment.
5847         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5848         init_psymbol_list.
5849         * dbxread.c (dbx_symfile_read): Unconditionally call
5850         init_psymbol_list.
5851
5852 2019-01-10  Tom Tromey  <tom@tromey.com>
5853
5854         * xcoffread.c (scan_xcoff_symtab): Update.
5855         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5856         "where".
5857         * mdebugread.c (parse_partial_symbols)
5858         (handle_psymbol_enumerators): Update.
5859         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5860         * dbxread.c (read_dbx_symtab): Update.
5861         * psympriv.h (psymbol_placement): New enum.
5862         (add_psymbol_to_list): Update.
5863
5864 2019-01-10  Tom Tromey  <tom@tromey.com>
5865
5866         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5867         static_psymbols parameters.
5868         (scan_xcoff_symtab): Update.
5869         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5870         static_psymbols parameters.
5871         * psympriv.h (start_psymtab_common): Update.
5872         * mdebugread.c (parse_partial_symbols): Update.
5873         * dwarf2read.c (create_partial_symtab): Update.
5874         * dbxread.c (read_dbx_symtab): Update.
5875         (start_psymtab): Remove global_psymbols and static_psymbols
5876         parameters.
5877
5878 2019-01-10  Tom Tromey  <tom@tromey.com>
5879
5880         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5881         * psymtab.c (allocate_psymtab): Add comment.
5882         * psympriv.h (allocate_psymtab): Add comment.
5883         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5884         initializations.
5885         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5886
5887 2019-01-10  Tom Tromey  <tom@tromey.com>
5888
5889         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5890         Don't declare.
5891         * mipsread.c: Include mdebugread.h.
5892         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5893         Declare.
5894         * elfread.c: Include mdebugread.h.
5895
5896 2019-01-09  Tom Tromey  <tom@tromey.com>
5897
5898         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5899         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5900         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5901         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5902         (psym_lookup_symbol, psym_find_last_source_symtab)
5903         (psym_forget_cached_source_info, psym_print_stats)
5904         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5905         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5906         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5907         (psym_find_compunit_symtab_by_address)
5908         (maintenance_print_psymbols, maintenance_info_psymtabs)
5909         (maintenance_check_psymtabs): Use ranged for.
5910         * psymtab.h (class objfile_psymtabs): New.
5911         (require_partial_symbols): Return objfile_psymtabs.
5912         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5913
5914 2019-01-09  Tom Tromey  <tom@tromey.com>
5915
5916         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5917         (find_pc_mapped_section, list_overlays_command)
5918         (map_overlay_command, unmap_overlay_command)
5919         (simple_overlay_update): Use all_objfiles.
5920         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5921         * printcmd.c (info_symbol_command): Use all_objfiles.
5922         * objfiles.h (ALL_OBJSECTIONS): Remove.
5923         * maint.c (maintenance_translate_address): Use all_objfiles.
5924         * gcore.c (gcore_create_callback): Use all_objfiles.
5925         (objfile_find_memory_regions): Likewise.
5926
5927 2019-01-09  Tom Tromey  <tom@tromey.com>
5928
5929         * symtab.c (find_line_symtab, info_sources_command)
5930         (make_source_files_completion_list): Use objfile_compunits.
5931         * source.c (select_source_symtab): Use objfile_compunits.
5932         * objfiles.h (struct objfile): Update comment.
5933         (ALL_OBJFILES): Remove.
5934         (ALL_FILETABS): Remove.
5935         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5936         objfile_compunits.
5937
5938 2019-01-09  Tom Tromey  <tom@tromey.com>
5939
5940         * symmisc.c (print_objfile_statistics, dump_objfile)
5941         (maintenance_print_symbols): Use compunit_filetabs.
5942         * source.c (forget_cached_source_info_for_objfile): Use
5943         compunit_filetabs.
5944         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5945         (ALL_FILETABS): Use compunit_filetabs.
5946         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5947         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5948
5949 2019-01-09  Tom Tromey  <tom@tromey.com>
5950
5951         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5952         (compunit_filetabs): New.
5953         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5954         compunit_filetabs.
5955         (info_sources_command, make_source_files_completion_list): Remove
5956         declaration.
5957         * symmisc.c (print_objfile_statistics, dump_objfile)
5958         (maintenance_print_symbols): Remove declaration.
5959         (maintenance_info_symtabs): Use compunit_filetabs.
5960         (maintenance_info_line_tables): Likewise.
5961         * source.c (select_source_symtab): Change local variable name.
5962         (forget_cached_source_info_for_objfile): Remove declaration.
5963         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5964         * objfiles.c (objfile_relocate1): Remove declaration.
5965         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5966         declaration.
5967         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5968         * coffread.c (coff_symtab_read): Remove declaration.
5969         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5970         compunit_filetabs.
5971
5972 2019-01-09  Tom Tromey  <tom@tromey.com>
5973
5974         * symtab.c (lookup_objfile_from_block)
5975         (find_pc_sect_compunit_symtab, search_symbols)
5976         (default_collect_symbol_completion_matches_break_on): Use
5977         objfile_compunits.
5978         * objfiles.h (ALL_COMPUNITS): Remove.
5979         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5980         * cp-support.c (add_symbol_overload_list_qualified): Use
5981         objfile_compunits.
5982         * ada-lang.c (ada_collect_symbol_completion_matches)
5983         (ada_add_global_exceptions): Use objfile_compunits.
5984
5985 2019-01-09  Tom Tromey  <tom@tromey.com>
5986
5987         * source.c (select_source_symtab)
5988         (forget_cached_source_info_for_objfile): Remove declaration.
5989         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5990         declaration.
5991         * maint.c (count_symtabs_and_blocks): Remove declaration.
5992         * cp-support.c (add_symbol_overload_list_qualified): Remove
5993         declaration.
5994         * coffread.c (coff_symtab_read): Remove declaration.
5995         * symtab.c (lookup_symbol_in_objfile_symtabs)
5996         (basic_lookup_transparent_type_1): Use objfile_compunits.
5997         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5998         (info_sources_command, search_symbols)
5999         (default_collect_symbol_completion_matches_break_on)
6000         (make_source_files_completion_list): Remove declaration.
6001         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6002         (ada_collect_symbol_completion_matches)
6003         (ada_add_global_exceptions): Remove declaration.
6004         * linespec.c (iterate_over_all_matching_symtabs): Use
6005         objfile_compunits.
6006         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6007         (class objfile_compunits): New.
6008         (ALL_COMPUNITS): Use objfile_compunits.
6009         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6010         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6011         objfile_compunits.
6012         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6013
6014 2019-01-09  Tom Tromey  <tom@tromey.com>
6015
6016         * symtab.c (search_symbols)
6017         (default_collect_symbol_completion_matches_break_on): Use
6018         objfile_msymbols.
6019         * ada-lang.c (ada_lookup_simple_minsym)
6020         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6021         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6022         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6023         objfile_msymbols.
6024         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6025         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6026         * objc-lang.c (find_methods): Use objfile_msymbols.
6027         (info_selectors_command, info_classes_command): Likewise.
6028         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6029         * objfiles.h (class objfile_msymbols): New.
6030         (ALL_OBJFILE_MSYMBOLS): Remove.
6031         (ALL_MSYMBOLS): Remove.
6032
6033 2019-01-09  Tom Tromey  <tom@tromey.com>
6034
6035         * common/next-iterator.h (next_adapter): Add Iterator template
6036         parameter.
6037         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6038         (class all_objfiles_safe): New.
6039         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6040         * objfiles.c (put_objfile_before): Update comment.
6041         (add_separate_debug_objfile): Likewise.
6042         (free_all_objfiles): Use all_objfiles_safe.
6043         (objfile_purge_solibs): Likewise.
6044
6045 2019-01-09  Tom Tromey  <tom@tromey.com>
6046
6047         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6048         (expand_symtab_containing_pc, lookup_static_symbol)
6049         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6050         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6051         all_objfiles.
6052         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6053         * breakpoint.c (create_overlay_event_breakpoint)
6054         (create_longjmp_master_breakpoint)
6055         (create_std_terminate_master_breakpoint)
6056         (create_exception_master_breakpoint): Use all_objfiles.
6057         * linux-thread-db.c (try_thread_db_load_from_pdir)
6058         (has_libpthread): Use all_objfiles.
6059         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6060         * linespec.c (iterate_over_all_matching_symtabs)
6061         (search_minsyms_for_name): Use all_objfiles.
6062         * maint.c (maintenance_info_sections): Use all_objfiles.
6063         * main.c (captured_main_1): Use all_objfiles.
6064         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6065         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6066         * guile/scm-pretty-print.c
6067         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6068         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6069         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6070         (maintenance_print_msymbols): Use all_objfiles.
6071         * source.c (select_source_symtab): Use all_objfiles.
6072         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6073         * symfile.c (remove_symbol_file_command)
6074         (expand_symtabs_matching, map_symbol_filenames): Use
6075         all_objfiles.
6076         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6077         all_objfiles.
6078         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6079         * objc-lang.c (find_methods): Use all_objfiles.
6080         * objfiles.c (have_partial_symbols, have_full_symbols)
6081         (have_minimal_symbols, qsort_cmp)
6082         (default_iterate_over_objfiles_in_search_order): Use
6083         all_objfiles.
6084         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6085         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6086         (maintenance_check_psymtabs): Use all_objfiles.
6087         (ALL_PSYMTABS): Remove.
6088         * compile/compile-object-run.c (do_module_cleanup): Use
6089         all_objfiles.
6090         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6091         * cp-support.c (add_symbol_overload_list_qualified): Use
6092         all_objfiles.
6093         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6094         Use all_objfiles.
6095         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6096         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6097         all_objfiles.
6098         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6099         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6100         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6101         Uses all_objfiles.
6102         * solib.c (solib_read_symbols): Use all_objfiles
6103
6104 2019-01-09  Tom Tromey  <tom@tromey.com>
6105
6106         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6107         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6108         all_objfiles.
6109         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6110         * symmisc.c (print_symbol_bcache_statistics)
6111         (print_objfile_statistics, maintenance_print_objfiles)
6112         (maintenance_info_symtabs, maintenance_check_symtabs)
6113         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6114         all_objfiles.
6115         * source.c (forget_cached_source_info): Use all_objfiles.
6116         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6117         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6118         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6119         * objfiles.c (update_section_map): Use all_objfiles.
6120         (shared_objfile_contains_address_p): Likewise.
6121         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6122         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6123
6124 2019-01-09  Tom Tromey  <tom@tromey.com>
6125
6126         * common/next-iterator.h: New file.
6127         * objfiles.h (class all_objfiles): New.
6128         (struct objfile_iterator): New.
6129
6130 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6131
6132         * NEWS: Move the description of the changed "frame", "select-frame",
6133          and "info frame" commands to the Changed commands section.
6134
6135 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6136
6137         * gdbtypes.c (check_stub_method_group): Remove handling of old
6138         mangling schemes.
6139         * linespec.c (find_methods): Likewise.
6140         * stabsread.c (read_member_functions): Likewise.
6141         * valops.c (search_struct_method): Likewise.
6142         (value_struct_elt_for_reference): Likewise.
6143         * NEWS: Mention this change.
6144
6145 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6146
6147         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6148         print_source_lines.
6149         * source.c (print_source_lines_base): Update line number check.
6150         (print_source_lines): New function.
6151         (source_lines_range::source_lines_range): New function.
6152         * source.h (class source_lines_range): New class.
6153         (print_source_lines): New declaration.
6154
6155 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6156
6157         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6158
6159 2019-01-08  Tom Tromey  <tom@tromey.com>
6160             Simon Marchi  <simon.marchi@ericsson.com>
6161
6162         PR gdb/24060
6163         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6164         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6165         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6166         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6167         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6168         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6169
6170 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6171
6172         * source.c (select_source_symtab): Move header comment to
6173         declaration in source.h.
6174         (forget_cached_source_info_for_objfile): Likewise.
6175         (forget_cached_source_info): Likewise.
6176         (identify_source_line): Likewise.
6177         * source.h (identify_source_line): Move declaration from symtab.h
6178         and add comment from source.c
6179         (print_source_lines): Likewise.
6180         (forget_cached_source_info_for_objfile): Likewise.
6181         (forget_cached_source_info): Likewise.
6182         (select_source_symtab): Likewise.
6183         (enum print_source_lines_flag): Move definition from symtab.h.
6184         * symtab.h (identify_source_line): Move declaration to source.h.
6185         (print_source_lines): Likewise.
6186         (forget_cached_source_info_for_objfile): Likewise.
6187         (forget_cached_source_info): Likewise.
6188         (select_source_symtab): Likewise.
6189         (enum print_source_lines_flag): Move definition to source.h.
6190         * tui/tui-hooks.c: Add 'source.h' include.
6191
6192 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6193
6194         * source.c (print_source_lines_base): Handle requests to print
6195         reverse line number sequences, and guard against empty lines
6196         string.
6197
6198 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6199
6200         * source.c (print_source_lines_base): Fix skip of '\r' if next
6201         character is '\n'.
6202
6203 2019-01-06  Tom Tromey  <tom@tromey.com>
6204
6205         * c-exp.y (struct c_parse_state) <macro_original_text,
6206         expansion_obstack>: New member.
6207         (macro_original_text, expansion_obstack): Remove globals.
6208         (scan_macro_expansion, scanning_macro_expansion)
6209         (finished_macro_expansion): Update.
6210         (scan_macro_cleanup): Remove.
6211         (yylex, c_parse): Update.
6212
6213 2019-01-06  Tom Tromey  <tom@tromey.com>
6214
6215         * c-exp.y (struct c_parse_state) <strings>: New member.
6216         (operator_stoken): Update.
6217
6218 2019-01-06  Tom Tromey  <tom@tromey.com>
6219
6220         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6221         (union type_stack_elt) <typelist_val>: Now a pointer to
6222         std::vector.
6223         (type_stack_cleanup): Don't declare.
6224         (push_typelist): Update.
6225         * parse.c (pop_typelist): Return a std::vector.
6226         (push_typelist): Take a std::vector.
6227         (follow_types): Update.  Do not free args.
6228         (type_stack_cleanup): Remove.
6229         * c-exp.y (struct c_parse_state): New.
6230         (cpstate): New global.
6231         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6232         (nonempty_typelist): Update.
6233         (func_mod): Create a new vector.
6234         (c_parse): Create a c_parse_state.
6235         (check_parameter_typelist): Do not delete params.
6236         (function_method): Update.  Do not delete type_list.
6237
6238 2019-01-06  Tom Tromey  <tom@tromey.com>
6239
6240         PR gdb/28155:
6241         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6242         check_typedef.
6243         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6244         (print_return_value): Likewise.
6245
6246 2019-01-05  Tom Tromey  <tom@tromey.com>
6247
6248         * contrib/cleanup_check.py: Remove.
6249         * contrib/gcc-with-excheck: Remove.
6250         * contrib/exsummary.py: Remove.
6251         * contrib/excheck.py: Remove.
6252
6253 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6254
6255         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6256         NULL. Initialize tpprev to NULL instead of assigning it
6257         to NULL on the next statement.
6258         * windows-nat.c (windows_delete_thread): Remove check for
6259         main_thread_id before printing thread exit notifications.
6260         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6261         Remove thread ID check against main_thread_id.
6262         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6263         windows_delete_thread.
6264         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6265
6266 2019-01-04  Tom Tromey  <tom@tromey.com>
6267
6268         * compile/compile.c (_initialize_compile): Use upper case for
6269         metasyntactic variables.
6270         * symmisc.c (_initialize_symmisc): Use upper case for
6271         metasyntactic variables.
6272         * psymtab.c (_initialize_psymtab): Use upper case for
6273         metasyntactic variables.
6274         * demangle.c (demangle_command): Use upper case for metasyntactic
6275         variables.
6276         (_initialize_demangler): Likewise.
6277         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6278         variables.
6279
6280 2019-01-03  Tom Tromey  <tom@tromey.com>
6281
6282         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6283
6284 2019-01-03  Tom Tromey  <tom@tromey.com>
6285
6286         * python/py-symtab.c (salpy_str): Update.
6287         (struct salpy_sal_object) <symtab>: Now a PyObject.
6288         (salpy_dealloc): Update.
6289         (del_objfile_sal): Use gdbpy_ref.
6290
6291 2019-01-03  Tom Tromey  <tom@tromey.com>
6292
6293         * python/py-type.c (convert_field): Use new_reference.  Return
6294         gdbpy_ref.
6295         (make_fielditem): Return gdbpy_ref.
6296         (typy_fields): Update.
6297         (typy_getitem): Update.
6298         (field_name): Return gdbpy_ref.  Use new_reference.
6299         (typy_iterator_iternext): Update.
6300
6301 2019-01-03  Tom Tromey  <tom@tromey.com>
6302
6303         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6304
6305 2019-01-03  Tom Tromey  <tom@tromey.com>
6306
6307         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6308         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6309         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6310         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6311         (pspy_set_type_printers): Likewise.
6312         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6313         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6314         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6315         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6316         (objfpy_set_type_printers): Likewise.
6317
6318 2019-01-03  Tom Tromey  <tom@tromey.com>
6319
6320         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6321         (gdbpy_print_stack): Use gdbpy_err_fetch.
6322         * python/python-internal.h (class gdbpy_err_fetch): New class.
6323         (class gdbpy_enter) <m_error_type, m_error_value,
6324         m_error_traceback>: Remove.
6325         <m_error>: New member.
6326         (gdbpy_exception_to_string): Don't declare.
6327         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6328         * python/py-value.c (convert_value_from_python): Use
6329         gdbpy_err_fetch.
6330         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6331         gdbpy_exception_to_string.
6332         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6333         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6334         gdbpy_err_fetch.
6335
6336 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6337
6338         * linux-nat.c (delete_lwp_cleanup): Delete.
6339         (struct lwp_deleter): New struct.
6340         (lwp_info_up): New typedef.
6341         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6342         lwp_info_up.
6343
6344 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6345
6346         * linux-fork.c (class scoped_switch_fork_info): New class.
6347         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6348
6349 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * valops.c (find_overload_match): Remove use of null_cleanup, and
6352         calls to do_cleanups.
6353
6354 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * compile/compile-cplus-types.c
6357         (compile_cplus_instance::decl_name): Handle changes to
6358         cp_func_name.
6359         * cp-support.c (cp_func_name): Update header comment, update
6360         return type.
6361         * cp-support.h (cp_func_name): Update return type in declaration.
6362         * valops.c (find_overload_match): Move temp_func local to top
6363         level of function and change its type.  Use temp_func to hold and
6364         delete temporary string obtained from cp_func_name.
6365
6366 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6369         gdb::char_vector, remove cleanup, and update uses of `msg`.
6370
6371 2019-01-03  Jim Wilson  <jimw@sifive.com>
6372
6373         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6374
6375 2019-01-02  Tom Tromey  <tom@tromey.com>
6376
6377         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6378         (tdesc_parse_xml): Remove cleanups.
6379         * target-descriptions.h (make_cleanup_free_target_description):
6380         Don't declare.
6381         (target_desc_deleter): New struct.
6382         (target_desc_up): New typedef.
6383         * target-descriptions.c (target_desc_deleter::operator()): Rename
6384         from free_target_description.
6385         (make_cleanup_free_target_description): Remove.
6386
6387 2019-01-02  Tom Tromey  <tom@tromey.com>
6388
6389         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6390         constructor, destructor.
6391         (linespec_parser): Remove typedef.
6392         (~linespec_parser): Rename from linespec_parser_delete.
6393         (linespec_lex_to_end, linespec_complete_label)
6394         (linespec_complete): Update.
6395         (decode_line_full): Remove cleanups.
6396         (decode_line_1): Update.
6397
6398 2019-01-02  Tom Tromey  <tom@tromey.com>
6399
6400         * python/python-internal.h (inferior_to_inferior_object): Change
6401         return type.
6402         * python/py-exitedevent.c (create_exited_event_object): Update.
6403         * python/py-inferior.c (inferior_to_inferior_object): Return
6404         gdbpy_ref.
6405         (python_new_inferior, python_inferior_deleted)
6406         (thread_to_thread_object, delete_thread_object)
6407         (build_inferior_list, gdbpy_selected_inferior): Update.
6408         * python/py-infthread.c (create_thread_object): Update.  Also fail
6409         if inferior_to_inferior_object fails.
6410
6411 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6412
6413         * inferior.h (class inferior) <displaced_step_state>: New field.
6414         * infrun.h (struct displaced_step_state): Move here from
6415         infrun.c.  Initialize fields, add constructor.
6416         <inf>: Remove field.
6417         <reset>: New method.
6418         * infrun.c (struct displaced_step_inferior_state): Move to
6419         infrun.h.
6420         (displaced_step_inferior_states): Remove.
6421         (get_displaced_stepping_state): Adust.
6422         (displaced_step_in_progress_any_inferior): Adjust.
6423         (displaced_step_in_progress_thread): Adjust.
6424         (displaced_step_in_progress): Adjust.
6425         (add_displaced_stepping_state): Remove.
6426         (get_displaced_step_closure_by_addr): Adjust.
6427         (remove_displaced_stepping_state): Remove.
6428         (infrun_inferior_exit): Call displaced_step_state.reset.
6429         (use_displaced_stepping): Don't check for NULL.
6430         (displaced_step_prepare_throw): Call
6431         get_displaced_stepping_state.
6432         (displaced_step_fixup): Don't check for NULL.
6433         (prepare_for_detach): Don't check for NULL.
6434
6435 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6436
6437         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6438          in case of call that did not complete.
6439
6440 2019-01-02  Andrey Utkin  <autkin@undo.io>
6441
6442         * symfile.c (find_separate_debug_file): Fix search of debug files for
6443         remote debuggee.
6444
6445 2019-01-02  Tom Tromey  <tom@tromey.com>
6446
6447         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6448         indentation.
6449         * python/py-frame.c (frapy_older): Remove cast.
6450         (frapy_newer): Likewise.
6451         * python/py-breakpoint.c (local_setattro): Remove cast.
6452         * python/py-arch.c (archpy_name): Remove local variable.
6453         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6454
6455 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6456
6457         * unittests/basic_string_view/element_access/char/empty.cc:
6458         Fix year range in copyright header.
6459
6460 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6461
6462         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6463         Delete.
6464         <operator==>: Update with for removed field.
6465         <hash>: Likewise.
6466         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6467         <isa_features>: ...this.
6468         <abi_features>: New field.
6469         (riscv_isa_flen): Update comment.
6470         (riscv_abi_xlen): New declaration.
6471         (riscv_abi_flen): New declaration.
6472         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6473         isa_features.
6474         (riscv_abi_xlen): New function.
6475         (riscv_isa_flen): Update to get answer from isa_features.
6476         (riscv_abi_flen): New function.
6477         (riscv_has_fp_abi): Update to get answer from abi_features.
6478         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6479         xlen and flen.
6480         (riscv_call_info) <xlen, flen>: Update comment.
6481         (riscv_call_arg_struct): Remove invalid assertions
6482         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6483         is removed.
6484         (riscv_gdbarch_init): Gather isa features and abi features
6485         separately, ensure both match on the gdbarch when reusing an old
6486         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6487         a target with 64-bit float hardware.
6488
6489 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6490
6491         * source.c (search_command_helper): Stop reverse search
6492         when line 1 has been searched.
6493
6494 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6495
6496         * record-full.c (record_full_base_target::close): Rewrite
6497         record_full_core_buf_list free logic.
6498
6499 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6500
6501         * break-catch-syscall.c (print_one_catch_syscall): xfree
6502         the last text.
6503
6504 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6505
6506         * top.c (print_gdb_version): Update Copyright year in version
6507         message.
6508
6509 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6510
6511         Update copyright year range in all GDB files.
6512
6513 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6514
6515         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6516
6517 For older changes see ChangeLog-2018.
6518 \f
6519 Local Variables:
6520 mode: change-log
6521 left-margin: 8
6522 fill-column: 74
6523 version-control: never
6524 coding: utf-8
6525 End:
6526