gdb/ChangeLog

   1 2020-07-01  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
   4
   5 2020-07-01  Fangrui Song  <maskray@google.com>
   6
   7         * dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.
   8
   9 2020-07-01  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
  10
  11         * dwarf2/read.c (set_die_type): Removed conditions to restrict
  12         forms for DW_AT_associated and DW_AT_allocated attributes,
  13         which is already checked in function attr_to_dynamic_prop.
  14
  15 2020-06-30  Tom Tromey  <tromey@adacore.com>
  16
  17         * dwarf2/read.c (quirk_rust_enum): Correctly call
  18         alloc_rust_variant for default-less enum.
  19
  20 2020-06-30  Tom Tromey  <tromey@adacore.com>
  21
  22         PR build/26183:
  23         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
  24         gdb::to_string.
  25
  26 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
  27
  28         * gdbarch.sh (displaced_step_copy_insn): Update doc.
  29         * gdbarch.h: Re-generate.
  30
  31 2020-06-28  Tom Tromey  <tom@tromey.com>
  32
  33         * command.h (cmd_types): Remove.
  34         (cmd_type): Don't declare.
  35         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
  36         typedef.
  37         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
  38         * cli/cli-decode.c (cmd_type): Remove.
  39
  40 2020-06-27  Pedro Alves  <palves@redhat.com>
  41
  42         * fork-child.c (prefork_hook): Adjust.
  43         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
  44         Delete.
  45         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
  46         * inferior.c (inferior::set_tty, inferior::tty): New methods.
  47         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
  48         Remove declarations.
  49         (struct inferior) <set_tty, tty>: New methods.
  50         (struct inferior) <terminal>: Rename to ...
  51         (struct inferior) <m_terminal>: ... this and make private.
  52         * main.c (captured_main_1): Adjust.
  53         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
  54         (mi_cmd_inferior_tty_show): Adjust.
  55         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
  56         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
  57
  58 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
  59
  60         * configure.ac: Add --enable-libctf: handle --disable-static
  61         properly.
  62         * acinclude.m4: sinclude ../config/enable.m4.
  63         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
  64         (LIBCTF): Substitute in.
  65         (CTF_DEPS): New, likewise.
  66         (CLIBS): libctf needs symbols from libbfd: move earlier.
  67         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
  68         flags.
  69         * ctfread.c: Surround in ENABLE_LIBCTF.
  70         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
  71         * configure: Regenerate.
  72         * config.in: Likewise.
  73
  74 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
  75
  76         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
  77
  78 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
  79
  80         * inferior.h (struct inferior) <terminal>: Change type to
  81         gdb::unique_xmalloc_ptr<char>.
  82         * inferior.c (inferior::~inferior): Don't free inf->terminal.
  83         * infcmd.c (set_inferior_io_terminal): Don't free terminal
  84         field, adjust to unique pointer.
  85         (get_inferior_io_terminal): Adjust to unique pointer.
  86
  87 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * riscv-tdep.c (riscv_print_registers_info): Loop over all
  90         registers, not just the known core set of registers.
  91
  92 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  93
  94         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
  95         fflags, frm, and fcsr registers.
  96         (riscv_register_reggroup_p): Remove unknown CSRs from save and
  97         restore groups.
  98         (riscv_tdesc_unknown_reg): New function.
  99         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
 100         tdesc_use_registers.
 101         * riscv-tdep.h (struct gdbarch_tdep): Add
 102         unknown_csrs_first_regnum, unknown_csrs_count,
 103         duplicate_fflags_regnum, duplicate_frm_regnum, and
 104         duplicate_fcsr_regnum fields.
 105
 106 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 107
 108         * target-descriptions.c (tdesc_use_registers): Add new parameter a
 109         callback, use the callback (when not null) to help number unknown
 110         registers.
 111         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
 112         (tdesc_use_registers): Add extra parameter to declaration.
 113
 114 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 115
 116         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
 117         in the file.
 118         (class riscv_pending_register_alias): Likewise.
 119         (riscv_register_feature::register_info): Change 'required_p' field
 120         to 'required', and change its type.  Add 'check' member function.
 121         (riscv_register_feature::register_info::check): Define new member
 122         function.
 123         (riscv_xreg_feature): Change initialisation of 'required' field.
 124         (riscv_freg_feature): Likewise.
 125         (riscv_virtual_feature): Likewise.
 126         (riscv_csr_feature): Likewise.
 127         (riscv_check_tdesc_feature): Take extra parameter, the csr
 128         tdesc_feature, rewrite the function to use the new
 129         riscv_register_feature::register_info::check function.
 130         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
 131
 132 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 133
 134         * features/Makefile: Remove all references to the deleted files
 135         below.
 136         * features/riscv/32bit-csr.c: Deleted.
 137         * features/riscv/32bit-csr.xml: Deleted.
 138         * features/riscv/64bit-csr.c: Deleted.
 139         * features/riscv/64bit-csr.xml: Deleted.
 140         * features/riscv/rebuild-csr-xml.sh: Deleted.
 141
 142 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 143
 144         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
 145         whitespace error for declaration of names member variable.
 146         (struct riscv_register_feature): Add new prefer_first_name member
 147         variable, and fix whitespace error in declaration of registers.
 148         (riscv_xreg_feature): Initialize prefer_first_name field.
 149         (riscv_freg_feature): Likewise.
 150         (riscv_virtual_feature): Likewise.
 151         (riscv_csr_feature): Likewise.
 152         (riscv_register_name): Expand on comments.  Remove register name
 153         modifications for CSR and virtual registers.
 154
 155 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 156
 157         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
 158         errors.
 159
 160 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 161
 162         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
 163         riscv-opc.h.
 164         (class riscv_pending_register_alias): New class.
 165         (riscv_check_tdesc_feature): Take vector of pending aliases and
 166         populate it as appropriate.
 167         (riscv_setup_register_aliases): Delete.
 168         (riscv_gdbarch_init): Create vector of pending aliases and pass it
 169         to riscv_check_tdesc_feature in all cases.  Use the vector to
 170         create the register aliases.
 171
 172 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 173
 174         * sol2-tdep.c (sol2_static_transform_name): Remove.
 175         (sol2_init_abi): Don't register it.
 176         * gdbarch.sh (static_transform_name): Remove.
 177         * gdbarch.c, gdbarch.h: Regenerate.
 178
 179         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
 180         gdbarch_static_transform_name.
 181         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
 182         * stabsread.c (define_symbol) <'X'>: Remove.
 183         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
 184         handling.
 185         <'V'>: Likewise.
 186         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
 187         <'S'>: Remove call to gdbarch_static_transform_name.
 188
 189 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 190
 191         * procfs.c (procfs_pre_trace): New function.
 192         (procfs_target::create_inferior): Pass it to fork_inferior.
 193
 194 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 195
 196         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
 197         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
 198         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
 199         sol2-tdep.o, sparc-sol2-tdep.o.
 200         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
 201         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
 202         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
 203         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
 204
 205 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 206
 207         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
 208         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
 209         Call sol2_init_abi.
 210         Remove calls to set_gdbarch_skip_solib_resolver,
 211         set_gdbarch_core_pid_to_str.
 212         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
 213         (i386_sol2_static_transform_name): Remove.
 214         (i386_sol2_init_abi): Call sol2_init_abi.
 215         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 216         set_gdbarch_static_transform_name,
 217         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 218         Use sol2_sigtramp_p.
 219         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
 220         (sol2_sigtramp_p): New function.
 221         (sol2_static_transform_name): New function.
 222         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
 223         (sol2_init_abi): New function.
 224         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
 225         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
 226         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
 227         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
 228         (sparc_sol2_static_transform_name): Remove.
 229         (sparc32_sol2_init_abi): Call sol2_init_abi.
 230         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 231         set_gdbarch_static_transform_name,
 232         set_gdbarch_skip_solib_resolver,
 233         set_gdbarch_core_pid_to_str.
 234         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
 235         (sparc_sol2_static_transform_name): Remove
 236         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
 237         call sol2_sigtramp_p.
 238         (sparc64_sol2_init_abi): Call sol2_init_abi.
 239         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 240         set_gdbarch_static_transform_name,
 241         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 242
 243 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 244
 245         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
 246         * exec.c (validate_exec_file): If from_tty, set both
 247         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
 248         * symfile.c (symbol_file_add_with_addrs): if always_confirm
 249         and from_tty, unconditionally ask a confirmation.
 250
 251 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 252
 253         * target-descriptions.c (tdesc_architecture_name): Protect against
 254         NULL pointer dereference.
 255         (maint_print_xml_tdesc_cmd): New function.
 256         (_initialize_target_descriptions): Register new 'maint print
 257         xml-tdesc' command and give it the filename completer.
 258         * NEWS: Mention new 'maint print xml-tdesc' command.
 259
 260 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * target-descriptions.c (class tdesc_compatible_info): New class.
 263         (struct target_desc): Change type of compatible vector.
 264         (tdesc_compatible_p): Update for change in type of
 265         target_desc::compatible.
 266         (tdesc_compatible_info_list): New function.
 267         (tdesc_compatible_info_arch_name): New function.
 268         (tdesc_add_compatible): Update for change in type of
 269         target_desc::compatible.
 270         (print_c_tdesc::visit_pre): Likewise.
 271
 272 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 273
 274         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
 275         whitespace to underscore.
 276         (maint_print_c_tdesc_cmd): Use fake filename for target
 277         descriptions that came from the target.
 278         (_initialize_target_descriptions): Add filename command completion
 279         for 'maint print c-tdesc'.
 280
 281 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 282
 283         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
 284         lines.
 285
 286 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 287
 288         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
 289         lines.
 290         (dwarf2_find_location_expression): Likewise.
 291         (call_site_parameter_matches): Likewise.
 292         (dwarf2_compile_expr_to_ax): Likewise.
 293         (disassemble_dwarf_expression): Likewise.
 294         (loclist_describe_location): Likewise.
 295
 296 2020-06-23  Pedro Alves  <palves@redhat.com>
 297
 298         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
 299         progspace-and-thread.h.  Include scoped-mock-context.h instead.
 300         (register_to_value_test): Use scoped_mock_context.
 301         * regcache.c: Include "scoped-mock-context.h".
 302         (cooked_read_test): Don't error out if a target is already pushed.
 303         Use scoped_mock_context.  Adjust.
 304         * scoped-mock-context.h: New file.
 305
 306 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
 309         initializer.
 310         (ada_language::is_string_type_p): New member function.
 311         * c-lang.c (c_language_data): Delete la_is_string_type_p
 312         initializer.
 313         (cplus_language_data): Likewise.
 314         (asm_language_data): Likewise.
 315         (minimal_language_data): Likewise.
 316         * d-lang.c (d_language_data): Likewise.
 317         * f-lang.c (f_is_string_type_p): Delete function, implementation
 318         moved to f_language::is_string_type_p.
 319         (f_language_data): Delete la_is_string_type_p initializer.
 320         (f_language::is_string_type_p): New member function,
 321         implementation from f_is_string_type_p.
 322         * go-lang.c (go_is_string_type_p): Delete function, implementation
 323         moved to go_language::is_string_type_p.
 324         (go_language_data): Delete la_is_string_type_p initializer.
 325         (go_language::is_string_type_p): New member function,
 326         implementation from go_is_string_type_p.
 327         * language.c (language_defn::is_string_type_p): Define new member
 328         function.
 329         (default_is_string_type_p): Make static, add comment copied from
 330         header file.
 331         (unknown_language_data): Delete la_is_string_type_p initializer.
 332         (unknown_language::is_string_type_p): New member function.
 333         (auto_language_data): Delete la_is_string_type_p initializer.
 334         (auto_language::is_string_type_p): New member function.
 335         * language.h (language_data): Delete la_is_string_type_p field.
 336         (language_defn::is_string_type_p): Declare new function.
 337         (default_is_string_type_p): Delete desclaration, move comment to
 338         definition.
 339         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
 340         moved to m2_language::is_string_type_p.
 341         (m2_language_data): Delete la_is_string_type_p initializer.
 342         (m2_language::is_string_type_p): New member function,
 343         implementation from m2_is_string_type_p.
 344         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
 345         initializer.
 346         * opencl-lang.c (opencl_language_data): Likewise.
 347         * p-lang.c (pascal_is_string_type_p): Delete function,
 348         implementation moved to pascal_language::is_string_type_p.
 349         (pascal_language_data): Delete la_is_string_type_p initializer.
 350         (pascal_language::is_string_type_p): New member function,
 351         implementation from pascal_is_string_type_p.
 352         * rust-lang.c (rust_is_string_type_p): Delete function,
 353         implementation moved to rust_language::is_string_type_p.
 354         (rust_language_data): Delete la_is_string_type_p initializer.
 355         (rust_language::is_string_type_p): New member function,
 356         implementation from rust_is_string_type_p.
 357         * valprint.c (val_print_scalar_or_string_type_p): Update call to
 358         is_string_type_p.
 359
 360 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 361
 362         * ada-lang.c (ada_language_data): Delete la_print_typedef
 363         initializer.
 364         (ada_language::print_typedef): New member function.
 365         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
 366         (cplus_language_data): Likewise.
 367         (asm_language_data): Likewise.
 368         (minimal_language_data): Likewise.
 369         * d-lang.c (d_language_data): Likewise.
 370         * f-lang.c (f_language_data): Likewise.
 371         (f_language::print_typedef): New member function.
 372         * go-lang.c (go_language_data): Delete la_print_typedef
 373         initializer.
 374         * language.c (language_defn::print_typedef): Define member
 375         function.
 376         (unknown_language_data): Delete la_print_typedef initializer.
 377         (unknown_language::print_typedef): New member function.
 378         (auto_language_data): Delete la_print_typedef initializer.
 379         (auto_language::print_typedef): New member function.
 380         * language.h (language_data): Delete la_print_typedef field.
 381         (language_defn::print_typedef): Declare new member function.
 382         (LA_PRINT_TYPEDEF): Update call to print_typedef.
 383         (default_print_typedef): Delete declaration.
 384         * m2-lang.c (m2_language_data): Delete la_print_typedef
 385         initializer.
 386         (m2_language::print_typedef): New member function.
 387         * objc-lang.c (objc_language_data): Delete la_print_typedef
 388         initializer.
 389         * opencl-lang.c (opencl_language_data): Likewise.
 390         * p-lang.c (pascal_language_data): Likewise.
 391         (pascal_language::print_typedef): New member function.
 392         * rust-lang.c (rust_print_typedef): Delete function,
 393         implementation moved to rust_language::print_typedef.
 394         (rust_language): Delete la_print_typedef initializer.
 395         (rust_language::print_typedef): New member function,
 396         implementation from rust_print_typedef.
 397         * typeprint.c (default_print_typedef): Delete.
 398
 399 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 400
 401         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
 402         (ada_language::printstr): New member function.
 403         * c-lang.c (c_language_data): Delete la_printstr initializer.
 404         (cplus_language_data): Likewise.
 405         (asm_language_data): Likewise.
 406         (minimal_language_data): Likewise.
 407         * d-lang.c (d_language_data): Likewise.
 408         * f-lang.c (f_printstr): Rename to f_language::printstr.
 409         (f_language_data): Delete la_printstr initializer.
 410         (f_language::printstr): New member function, implementation from
 411         f_printstr.
 412         * go-lang.c (go_language_data): Delete la_printstr initializer.
 413         * language.c (language_defn::printstr): Define new member
 414         function.
 415         (unk_lang_printstr): Delete.
 416         (unknown_language_data): Delete la_printstr initializer.
 417         (unknown_language::printstr): New member function.
 418         (auto_language_data): Delete la_printstr initializer.
 419         (auto_language::printstr): New member function.
 420         * language.h (language_data): Delete la_printstr field.
 421         (language_defn::printstr): Declare new member function.
 422         (LA_PRINT_STRING): Update call to printstr.
 423         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
 424         (m2_language_data): Delete la_printstr initializer.
 425         (m2_language::printstr): New member function, implementation from
 426         m2_printstr.
 427         * objc-lang.c (objc_language_data): Delete la_printstr
 428         initializer.
 429         * opencl-lang.c (opencl_language_data): Likewise.
 430         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
 431         (pascal_language_data): Delete la_printstr initializer.
 432         (pascal_language::printstr): New member function, implementation
 433         from pascal_printstr.
 434         * p-lang.h (pascal_printstr): Delete declaration.
 435         * rust-lang.c (rust_printstr): Update header comment.
 436         (rust_language_data): Delete la_printstr initializer.
 437         (rust_language::printstr): New member function.
 438
 439 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
 442         (ada_language::printchar): New member function.
 443         * c-lang.c (c_language_data): Delete la_printchar initializer.
 444         (cplus_language_data): Likewise.
 445         (asm_language_data): Likewise.
 446         (minimal_language_data): Likewise.
 447         * d-lang.c (d_language_data): Likewise.
 448         * f-lang.c (f_printchar): Rename to f_language::printchar.
 449         (f_language_data): Delete la_printchar initializer.
 450         (f_language::printchar): New member function, implementation from
 451         f_printchar.
 452         * go-lang.c (go_language_data): Delete la_printchar initializer.
 453         * language.c (unk_lang_printchar): Delete.
 454         (language_defn::printchar): Define new member function.
 455         (unknown_language_data): Delete la_printchar initializer.
 456         (unknown_language::printchar): New member function.
 457         (auto_language_data): Delete la_printchar initializer.
 458         (auto_language::printchar): New member function.
 459         * language.h (language_data): Delete la_printchar field.
 460         (language_defn::printchar): Declare new member function.
 461         (LA_PRINT_CHAR): Update call to printchar.
 462         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
 463         (m2_language::printchar): New member function.
 464         * objc-lang.c (objc_language_data): Delete la_printchar
 465         initializer.
 466         * opencl-lang.c (opencl_language_data): Likewise.
 467         * p-lang.c (pascal_language_data): Delete la_printchar
 468         initializer.
 469         (pascal_language::printchar): New member function.
 470         * rust-lang.c (rust_printchar): Rename to
 471         rust_language::printchar.
 472         (rust_language_data): Delete la_printchar initializer.
 473         (rust_language::printchar): New member function, implementation
 474         from rust_printchar.
 475
 476 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
 479         (ada_language_data): Delete la_emitchar initializer.
 480         (ada_language::emitchar): New member function, implementation from
 481         emit_char.
 482         * c-lang.c (c_language_data): Delete la_emitchar initializer.
 483         (cplus_language_data): Likewise.
 484         (asm_language_data): Likewise.
 485         (minimal_language_data): Likewise.
 486         * d-lang.c (d_language_data): Likewise.
 487         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
 488         (f_language_data): Delete la_emitchar initializer.
 489         (f_language::emitchar): New member function, implementation from
 490         f_emit_char.
 491         * go-lang.c (go_language_data): Delete la_emitchar initializer.
 492         * language.c (unk_lang_emit_char): Delete.
 493         (language_defn::emitchar): New member function definition.
 494         (unknown_language_data): Delete la_emitchar initializer.
 495         (unknown_language::emitchar): New member function.
 496         (auto_language_data): Delete la_emitchar initializer.
 497         (auto_language::emitchar): New member function.
 498         * language.h (language_data): Delete la_emitchar field.
 499         (language_defn::emitchar): New member field declaration.
 500         (LA_EMIT_CHAR): Update call to emitchar.
 501         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
 502         (m2_language_data): Delete la_emitchar initializer.
 503         (m2_language::emitchar): New member function, implementation from
 504         m2_emit_char.
 505         * objc-lang.c (objc_language_data): Delete la_emitchar
 506         initializer.
 507         * opencl-lang.c (opencl_language_data): Likewise.
 508         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
 509         (pascal_language_data): Delete la_emitchar initializer.
 510         (pascal_language::emitchar): New member function, implementation
 511         from pascal_emit_char.
 512         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
 513         (rust_language_data): Delete la_emitchar initializer.
 514         (rust_language::emitchar): New member function, implementation
 515         from rust_emitchar.
 516
 517 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * ada-lang.c (resolve): Rename to ada_language::post_parser.
 520         (ada_language_data): Delete la_post_parser initializer.
 521         (ada_language::post_parser): New member function.
 522         * c-lang.c (c_language_data): Delete la_post_parser initializer.
 523         (cplus_language_data): Likewise.
 524         (asm_language_data): Likewise.
 525         (minimal_language_data): Likewise.
 526         * d-lang.c (d_language_data): Likewise.
 527         * f-lang.c (f_language_data): Likewise.
 528         * go-lang.c (go_language_data): Likewise.
 529         * language.c (unknown_language_data): Likewise.
 530         (auto_language_data): Likewise.
 531         * language.h (language_data): Delete la_post_parser field.
 532         (language_defn::post_parser): New member function.
 533         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
 534         * objc-lang.c (objc_language_data): Likewise.
 535         * opencl-lang.c (opencl_language_data): Likewise.
 536         * p-lang.c (pascal_language_data): Likewise.
 537         * parse.c (parse_exp_in_context): Update call to post_parser.
 538         (null_post_parser): Delete definition.
 539         * parser-defs.h (null_post_parser): Delete declaration.
 540         * rust-lang.c (rust_language_data): Delete la_post_parser
 541         initializer.
 542
 543 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 544
 545         * ada-lang.c (parse): Rename to ada_language::parser.
 546         (ada_language_data): Delete la_parser initializer.
 547         (ada_language::parser): New member function, implementation from
 548         parse.
 549         * c-lang.c (c_language_data): Delete la_parser initializer.
 550         (cplus_language_data): Likewise.
 551         (asm_language_data): Likewise.
 552         (minimal_language_data): Likewise.
 553         * d-lang.c (d_language_data): Likewise.
 554         (d_language::parser): New member function.
 555         * f-lang.c (f_language_data): Delete la_parser initializer.
 556         (f_language::parser): New member function.
 557         * go-lang.c (go_language_data): Delete la_parser initializer.
 558         (go_language::parser): New member function.
 559         * language.c (unk_lang_parser): Delete.
 560         (language_defn::parser): Define new member function.
 561         (unknown_language_data): Delete la_parser initializer.
 562         (unknown_language::parser): New member function.
 563         (auto_language_data): Delete la_parser initializer.
 564         (auto_language::parser): New member function.
 565         * language.h (language_data): Delete la_parser field.
 566         (language_defn::parser): Declare new member function.
 567         * m2-lang.c (m2_language_data): Delete la_parser initializer.
 568         (m2_language::parser): New member function.
 569         * objc-lang.c (objc_language_data): Delete la_parser initializer.
 570         * opencl-lang.c (opencl_language_data): Likewise.
 571         * p-lang.c (pascal_language_data): Likewise.
 572         (pascal_language::parser): New member function.
 573         * parse.c (parse_exp_in_context): Update call to parser.
 574         * rust-lang.c (rust_language_data): Delete la_parser initializer.
 575         (rust_language::parser): New member function.
 576
 577 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * top.c (print_gdb_configuration): Print --with-python-libdir
 580         configuration value.
 581
 582 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 583
 584         * NEWS: Mention change to the alias command.
 585
 586 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 587
 588         * cli/cli-cmds.c (lookup_cmd_for_default_args)
 589         (alias_command_completer)
 590         (make_alias_options_def_group): New functions.
 591         (alias_opts, alias_option_defs): New struct and array.
 592         (alias_usage_error): Update usage.
 593         (alias_command): Handles optional DEFAULT-ARGS... arguments.
 594         Use option framework.
 595         (_initialize_cli_cmds): Update alias command help.
 596         Update aliases command help.
 597         (show_user):
 598         Add NULL for new default_args lookup_cmd argument.
 599         (valid_command_p): Rename to validate_aliased_command.
 600         Add NULL for new default_args lookup_cmd argument.  Verify that the
 601         aliased_command has no default args.
 602         * cli/cli-decode.c (help_cmd): Show aliases definitions.
 603         (lookup_cmd_1, lookup_cmd): New argument default_args.
 604         (add_alias_cmd):
 605         Add NULL for new default_args lookup_cmd argument.
 606         (print_help_for_command): Show default args under the layout
 607          alias some_alias = some_aliased_cmd some_alias_default_arg.
 608         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
 609         xfree default_args in destructor.
 610         * cli/cli-script.c (process_next_line, do_define_command):
 611         Add NULL for new default_args lookup_cmd argument.
 612         * command.h: Declare new default_args argument in lookup_cmd
 613         and lookup_cmd_1.
 614         * completer.c (complete_line_internal_1):
 615         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 616         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 617         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
 618         Likewise.
 619         * infcmd.c (_initialize_infcmd): Likewise.
 620         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
 621         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 622         * python/py-param.c (add_setshow_generic): Likewise.
 623         * remote.c (_initialize_remote): Likewise.
 624         * top.c (execute_command): Prepend default_args if command has some.
 625         (set_verbose):
 626         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 627         * tracepoint.c (validate_actionline, encode_actions_1):
 628         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 629
 630 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 631
 632         * jit.c (jit_read_descriptor): Use bool as the return type.
 633         (jit_breakpoint_re_set_internal): Use bool as the return type.
 634         Invert the return value logic; return true if the jit breakpoint
 635         has been successfully initialized.
 636         (jit_inferior_init): Update the call to
 637         jit_breakpoint_re_set_internal.
 638
 639 2020-06-22  Pedro Alves  <palves@redhat.com>
 640
 641         PR gdb/25939
 642         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
 643         Use the current inferior instead.  Don't return
 644         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
 645         wait again.
 646         * sol-thread.c (sol_thread_target::wait): Don't reference
 647         inferior_ptid.
 648         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
 649         (sol_update_thread_list_callback): Use the current inferior's pid
 650         instead of inferior_ptid.
 651
 652 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 653
 654         * procfs.c: Cleanup many comments.
 655
 656         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
 657         (AFTER_WATCHFLAG): Replace by value.
 658
 659         (MAIN_PROC_NAME_FORMAT): Inline ...
 660         (create_procinfo): ... here.
 661
 662         (procfs_debug_inferior): Remove SYS_exec handling.
 663         (syscall_is_exec): Likewise.
 664         (procfs_set_exec_trap): Likewise.
 665
 666         (syscall_is_lwp_exit): Inline in callers.
 667         (syscall_is_exit): Likewise.
 668         (syscall_is_exec): Likewise.
 669         (syscall_is_lwp_create): Likewise.
 670
 671         (invalidate_cache): Remove #if 0 code.
 672
 673         (make_signal_thread_runnable):  Remove.
 674         (procfs_target::resume): Remove #if 0 code.
 675
 676 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 677
 678         PR gdb/25939
 679         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
 680         call ...
 681         (procfs_target::create_inferior): ... here.
 682
 683 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 684
 685         * exec.c (validate_exec_file): Ensure the build-id is up to
 686         date by calling reopen_exec_file (that checks file timestamp
 687         to decide to re-read the file).
 688
 689 2020-06-18  Pedro Alves  <palves@redhat.com>
 690
 691         PR gdb/25412
 692         * gdbthread.h (delete_thread, delete_thread_silent)
 693         (find_thread_ptid): Update comments.
 694         * thread.c (current_thread_): New global.
 695         (is_current_thread): Move higher, and reimplement.
 696         (inferior_thread): Reimplement.
 697         (set_thread_exited): Use bool.  Add assertions.
 698         (add_thread_silent): Simplify thread-reuse handling by always
 699         calling delete_thread.
 700         (delete_thread): Remove intro comment.
 701         (find_thread_ptid): Skip exited threads.
 702         (switch_to_thread_no_regs): Write to current_thread_.
 703         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
 704         INFERIOR_PTID.  Clear current_thread_.
 705
 706 2020-06-18  Pedro Alves  <palves@redhat.com>
 707
 708         * aix-thread.c (pd_update): Use switch_to_thread.
 709
 710 2020-06-18  Pedro Alves  <palves@redhat.com>
 711
 712         * ravenscar-thread.c (ravenscar_thread_target): Update.
 713         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
 714         (ravenscar_thread_target::add_active_thread): ... this.  Don't
 715         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
 716         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
 717
 718 2020-06-18  Pedro Alves  <palves@redhat.com>
 719
 720         * nat/windows-nat.c (current_windows_thread): Remove.
 721         * nat/windows-nat.h (current_windows_thread): Remove.
 722         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
 723         Adjust.
 724         (display_selectors): Adjust to fetch the current
 725         windows_thread_info based on inferior_ptid.
 726         (fake_create_process): No longer write to current_windows_thread.
 727         (windows_nat_target::get_windows_debug_event):
 728         Don't set inferior_ptid or current_windows_thread.
 729         (windows_nat_target::wait): Adjust to not rely on
 730         current_windows_thread.
 731         (do_initial_windows_stuff): Now a method of windows_nat_target.
 732         Switch to the last_ptid thread.
 733         (windows_nat_target::attach): Adjust.
 734         (windows_nat_target::detach): Use switch_to_no_thread instead of
 735         writing to inferior_ptid directly.
 736         (windows_nat_target::create_inferior): Adjust.
 737
 738 2020-06-18  Pedro Alves  <palves@redhat.com>
 739
 740         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
 741
 742 2020-06-18  Pedro Alves  <palves@redhat.com>
 743
 744         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
 745         after creating it, instead of writing to inferior_ptid.  Don't
 746         write to inferior_ptid.
 747
 748 2020-06-18  Pedro Alves  <palves@redhat.com>
 749
 750         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
 751
 752 2020-06-18  Pedro Alves  <palves@redhat.com>
 753
 754         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
 755         it, instead of writing to inferior_ptid.
 756
 757 2020-06-18  Pedro Alves  <palves@redhat.com>
 758
 759         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
 760         to inferior_ptid.
 761
 762 2020-06-18  Pedro Alves  <palves@redhat.com>
 763
 764         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
 765         instead of writing to inferior_ptid directly.
 766
 767 2020-06-18  Pedro Alves  <palves@redhat.com>
 768
 769         * corelow.c (core_target::close): Use switch_to_no_thread instead
 770         of writing to inferior_ptid directly.
 771         (add_to_thread_list, core_target_open): Use switch_to_thread
 772         instead of writing to inferior_ptid directly.
 773
 774 2020-06-18  Pedro Alves  <palves@redhat.com>
 775
 776         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
 777         inferior_ptid.
 778         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
 779         inferior_ptid.
 780         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
 781         inferior_ptid directly.
 782         (darwin_nat_target::init_thread_list): Switch to thread, instead
 783         of writing to inferior_ptid.
 784         (darwin_nat_target::attach): Don't write to inferior_ptid.
 785         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
 786
 787 2020-06-18  Pedro Alves  <palves@redhat.com>
 788
 789         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
 790         thread.
 791         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
 792         Instead use switch_to_thread.
 793         (gnu_nat_target::detach): Use switch_to_no_thread
 794         instead of writing to inferior_ptid directly.  Used passed-in
 795         inferior instead of looking up the inferior by pid.
 796
 797 2020-06-18  Pedro Alves  <palves@redhat.com>
 798
 799         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
 800         inferior_ptid.
 801
 802 2020-06-18  Pedro Alves  <palves@redhat.com>
 803
 804         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
 805         inferior_ptid.
 806         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
 807         thread.
 808         (nto_procfs_target::detach): Avoid referencing
 809         inferior_ptid.  Use switch_to_no_thread instead of writing to
 810         inferior_ptid directly.
 811         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
 812         instead of writing to inferior_ptid directly.
 813         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
 814         to thread.
 815
 816 2020-06-18  Pedro Alves  <palves@redhat.com>
 817
 818         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
 819         after creating it, instead of writing to inferior_ptid.
 820         (gdbsim_target_open): Use switch_to_no_thread instead of writing
 821         to inferior_ptid directly.
 822         (gdbsim_target::wait): Don't write to inferior_ptid.
 823
 824 2020-06-18  Pedro Alves  <palves@redhat.com>
 825
 826         * remote.c (remote_target::remote_notice_new_inferior): Use
 827         switch_to_thread instead of writing to inferior_ptid directly.
 828         (remote_target::add_current_inferior_and_thread): Use
 829         switch_to_no_thread instead of writing to inferior_ptid directly.
 830         (extended_remote_target::attach): Use switch_to_inferior_no_thread
 831         and switch_to_thread instead of using set_current_inferior or
 832         writing to inferior_ptid directly.
 833
 834 2020-06-18  Pedro Alves  <palves@redhat.com>
 835
 836         * tracectf.c (ctf_target_open): Switch to added thread instead of
 837         writing to inferior_ptid directly.
 838         (ctf_target::close): Use switch_to_no_thread instead of writing to
 839         inferior_ptid directly.
 840
 841 2020-06-18  Pedro Alves  <palves@redhat.com>
 842
 843         * tracefile-tfile.c (tfile_target_open): Don't write to
 844         inferior_ptid directly, instead switch to added thread.
 845         (tfile_target::close): Use switch_to_no_thread instead of writing
 846         to inferior_ptid directly.
 847
 848 2020-06-18  Pedro Alves  <palves@redhat.com>
 849
 850         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
 851         (procfs_target::detach): Use switch_to_no_thread
 852         instead of writing to inferior_ptid directly.
 853         (do_attach): Change return type to void.  Switch to the added
 854         thread.
 855         (procfs_target::create_inferior): Switch to the added thread.
 856         (procfs_do_thread_registers): Don't write to inferior_ptid.
 857
 858 2020-06-18  Pedro Alves  <palves@redhat.com>
 859
 860         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
 861         of writing to inferior_ptid.
 862         (scoped_restore_exited_inferior): Delete.
 863         (handle_vfork_child_exec_or_exit): Simplify using
 864         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
 865         instead of writing to inferior_ptid.
 866         (THREAD_STOPPED_BY): Delete.
 867         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
 868         (thread_stopped_by_hw_breakpoint): Delete.
 869         (save_waitstatus): Use
 870         scoped_restore_current_thread+switch_to_thread, and call
 871         target_stopped_by_watchpoint instead of
 872         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
 873         instead of thread_stopped_by_sw_breakpoint, and
 874         target_stopped_by_hw_breakpoint instead of
 875         thread_stopped_by_hw_breakpoint.
 876         (handle_inferior_event)
 877         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
 878         inferior_ptid directly, nor
 879         set_current_inferior/set_current_program_space.  Use
 880         switch_to_thread / switch_to_inferior_no_thread instead.
 881
 882 2020-06-18  Pedro Alves  <palves@redhat.com>
 883
 884         * target.c (generic_mourn_inferior): Use switch_to_no_thread
 885         instead of writing to inferior_ptid.
 886
 887 2020-06-18  Pedro Alves  <palves@redhat.com>
 888
 889         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
 890         added thread.
 891         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
 892         to the added thread.
 893         (inf_ptrace_target::detach_success): Use switch_to_no_thread
 894         instead of writing to inferior_ptid.
 895
 896 2020-06-18  Pedro Alves  <palves@redhat.com>
 897
 898         * gdbarch-selftests.c: Include "progspace-and-thread.h".
 899         (register_to_value_test): Mock a program_space too.  Heap-allocate
 900         the address space.  Don't write to inferior_ptid.  Use
 901         switch_to_thread instead.
 902
 903 2020-06-18  Pedro Alves  <palves@redhat.com>
 904
 905         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
 906         Delete.
 907         (find_signalled_thread()): New, factored out from
 908         linux_make_corefile_notes and adjusted to handle exited threads.
 909         (linux_make_corefile_notes): Adjust to use the new
 910         find_signalled_thread.
 911
 912 2020-06-18  Pedro Alves  <palves@redhat.com>
 913
 914         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
 915         of saving/restoring inferior_ptid.
 916
 917 2020-06-17  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
 920         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
 921         declare.
 922         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
 923
 924 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
 925
 926         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
 927         of partial symtabs.
 928
 929 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 930
 931         * regformats/reg-arm.dat: Remove.
 932         * regformats/reg-bfin.dat: Remove.
 933         * regformats/reg-cris.dat: Remove.
 934         * regformats/reg-crisv32.dat: Remove.
 935         * regformats/reg-m32r.dat: Remove.
 936         * regformats/reg-tilegx.dat: Remove.
 937         * regformats/reg-tilegx32.dat: Remove.
 938
 939 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 940
 941         * features/Makefile (WHICH): Remove arm files.
 942         * regformats/arm/arm-with-iwmmxt.dat: Remove.
 943         * regformats/arm/arm-with-neon.dat: Remove.
 944         * regformats/arm/arm-with-vfpv2.dat: Remove.
 945         * regformats/arm/arm-with-vfpv3.dat: Remove.
 946
 947 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 948
 949         * features/Makefile (XMLTOC): Remove rx.xml.
 950
 951 2020-06-17  Pedro Alves  <palves@redhat.com>
 952
 953         * gdbthread.h (thread_control_state) <trap_expected> Update
 954         comments.
 955
 956 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 957
 958         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
 959         ada_language::lookup_symbol_nonlocal.
 960         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
 961         (ada_language::lookup_symbol_nonlocal): New member function,
 962         implementation from ada_lookup_symbol_nonlocal.
 963         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
 964         initializer.
 965         (cplus_language_data): Delete la_lookup_symbol_nonlocal
 966         initializer.
 967         (cplus_language::lookup_symbol_nonlocal): New member function.
 968         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
 969         (minimal_language_data) Likewise.
 970         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
 971         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
 972         initializer.
 973         (d_language::lookup_symbol_nonlocal): New member function.
 974         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
 975         initializer.
 976         (f_language::lookup_symbol_nonlocal): New member function.
 977         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
 978         initializer.
 979         * language.c (unknown_language_data): Likewise.
 980         (auto_language_data): Likewise.
 981         * language.h (language_data): Delete la_lookup_symbol_nonlocal
 982         field.
 983         (language_defn::lookup_symbol_nonlocal): New member function.
 984         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
 985         initializer.
 986         * objc-lang.c (objc_language_data): Likewise.
 987         * opencl-lang.c (opencl_language_data): Likewise.
 988         * p-lang.c (pascal_language_data): Likewise.
 989         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
 990         rust_language::lookup_symbol_nonlocal.
 991         (rust_language_data): Delete la_lookup_symbol_nonlocal
 992         initializer.
 993         (rust_language::lookup_symbol_nonlocal): New member function,
 994         implementation from rust_lookup_symbol_nonlocal.
 995         * symtab.c (lookup_symbol_aux): Update call to
 996         lookup_symbol_nonlocal.
 997         (basic_lookup_symbol_nonlocal): Rename to...
 998         (language_defn::lookup_symbol_nonlocal): ...this, and update
 999         header comment.  Remove language_defn parameter, and replace with
1000         uses of `this'.
1001         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
1002
1003 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * ada-lang.c (ada_language_data): Delete la_value_print_inner
1006         initializer.
1007         (ada_language::value_print_inner): New member function.
1008         * c-lang.c (c_language_data): Delete la_value_print_inner
1009         initializer.
1010         (cplus_language_data): Likewise.
1011         (asm_language_data): Likewise.
1012         (minimal_language_data): Likewise.
1013         * d-lang.c (d_language_data): Likewise.
1014         (d_language::value_print_inner): New member function.
1015         * f-lang.c (f_language_data): Delete la_value_print_inner
1016         initializer.
1017         (f_language::value_print_inner): New member function.
1018         * f-lang.h (f_value_print_innner): Rename to...
1019         (f_value_print_inner): ...this (note spelling of 'inner').
1020         * f-valprint.c (f_value_print_innner): Rename to...
1021         (f_value_print_inner): ...this (note spelling of 'inner').
1022         * go-lang.c (go_language_data): Delete la_value_print_inner
1023         initializer.
1024         (go_language::value_print_inner): New member function.
1025         * language.c (language_defn::value_print_inner): Define new member
1026         function.
1027         (unk_lang_value_print_inner): Delete.
1028         (unknown_language_data): Delete la_value_print_inner initializer.
1029         (unknown_language::value_print_inner): New member function.
1030         (auto_language_data): Delete la_value_print_inner initializer.
1031         (auto_language::value_print_inner): New member function.
1032         * language.h (language_data): Delete la_value_print_inner field.
1033         (language_defn::value_print_inner): Delcare new member function.
1034         * m2-lang.c (m2_language_data): Delete la_value_print_inner
1035         initializer.
1036         (m2_language::value_print_inner): New member function.
1037         * objc-lang.c (objc_language_data): Delete la_value_print_inner
1038         initializer.
1039         * opencl-lang.c (opencl_language_data): Likewise.
1040         * p-lang.c (pascal_language_data): Likewise.
1041         (pascal_language::value_print_inner): New member function.
1042         * rust-lang.c (rust_language_data): Delete la_value_print_inner
1043         initializer.
1044         (rust_language::value_print_inner): New member function.
1045         * valprint.c (do_val_print): Update call to value_print_inner.
1046
1047 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1048
1049         * ada-lang.c (ada_language_data): Delete la_value_print
1050         initializer.
1051         (ada_language::value_print): New member function.
1052         * c-lang.c (c_language_data): Delete la_value_print initializer.
1053         (cplus_language_data): Likewise.
1054         (asm_language_data): Likewise.
1055         (minimal_language_data): Likewise.
1056         * d-lang.c (d_language_data): Likewise.
1057         * f-lang.c (f_language_data): Likewise.
1058         * go-lang.c (go_language_data): Likewise.
1059         * language.c (unk_lang_value_print): Delete.
1060         (language_defn::value_print): Define new member function.
1061         (unknown_language_data): Delete la_value_print initializer.
1062         (unknown_language::value_print): New member function.
1063         (auto_language_data): Delete la_value_print initializer.
1064         (auto_language::value_print): New member function.
1065         * language.h (language_data): Delete la_value_print field.
1066         (language_defn::value_print): Declare new member function.
1067         (LA_VALUE_PRINT): Update call to value_print.
1068         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
1069         * objc-lang.c (objc_language_data): Likewise.
1070         * opencl-lang.c (opencl_language_data): Likewise.
1071         * p-lang.c (pascal_language_data): Likewise.
1072         (pascal_language::value_print): New member function.
1073         * rust-lang.c (rust_language_data): Delete la_value_print
1074         initializer.
1075
1076 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         * ada-lang.c (ada_watch_location_expression): Rename to
1079         ada_language::watch_location_expression.
1080         (ada_language_data): Delete la_watch_location_expression
1081         initializer.
1082         (ada_language::watch_location_expression): New member function,
1083         implementation from ada_watch_location_expression.
1084         * breakpoint.c (watch_command_1): Update call to
1085         watch_location_expression.
1086         * c-lang.c (c_watch_location_expression): Rename to
1087         language_defn::watch_location_expression.
1088         (c_language_data): Delete la_watch_location_expression
1089         initializer.
1090         (cplus_language_data): Likewise.
1091         (asm_language_data): Likewise.
1092         (minimal_language_data): Likewise.
1093         * c-lang.h (c_watch_location_expression): Delete declaration.
1094         * d-lang.c (d_language_data): Delete la_watch_location_expression
1095         initializer.
1096         * f-lang.c (f_language_data): Likewise.
1097         * go-lang.c (go_language_data): Likewise.
1098         * language.c (language_defn::watch_location_expression): Member
1099         function implementation from c_watch_location_expression.
1100         (unknown_language_data): Delete la_watch_location_expression
1101         initializer.
1102         (auto_language_data): Likewise.
1103         * language.h (language_data): Delete la_watch_location_expression
1104         field.
1105         (language_defn::watch_location_expression): Declare new member
1106         function.
1107         * m2-lang.c (m2_language_data): Delete
1108         la_watch_location_expression initializer.
1109         * objc-lang.c (objc_language_data): Likewise.
1110         * opencl-lang.c (opencl_language_data): Likewise.
1111         * p-lang.c (pascal_language_data): Likewise.
1112         * rust-lang.c (rust_watch_location_expression): Rename to
1113         rust_language::watch_location_expression.
1114         (rust_language_data): Delete la_watch_location_expression
1115         initializer.
1116         (rust_language::watch_location_expression): New member function,
1117         implementation from rust_watch_location_expression.
1118
1119 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
1122         ada_language::collect_symbol_completion_matches.
1123         (ada_language_data): Delete la_collect_symbol_completion_matches
1124         initializer.
1125         (ada_language::collect_symbol_completion_matches): New member
1126         function, implementation from
1127         ada_collect_symbol_completion_matches.
1128         * c-lang.c (c_language_data): Delete
1129         la_collect_symbol_completion_matches initializer.
1130         (cplus_language_data): Likewise.
1131         (asm_language_data): Likewise.
1132         (minimal_language_data): Likewise.
1133         * d-lang.c (d_language_data): Likewise.
1134         * f-lang.c (f_collect_symbol_completion_matches): Rename to
1135         f_language::collect_symbol_completion_matches.
1136         (f_language_data): Delete la_collect_symbol_completion_matches
1137         initializer.
1138         (f_language::collect_symbol_completion_matches) New member
1139         function, implementation from f_collect_symbol_completion_matches.
1140         * go-lang.c (go_language_data): Delete
1141         la_collect_symbol_completion_matches initializer.
1142         * language.c (unknown_language_data): Likewise.
1143         (auto_language_data): Likewise.
1144         * language.h (language_data): Delete
1145         la_collect_symbol_completion_matches field.
1146         (language_defn::collect_symbol_completion_matches): New member
1147         function.
1148         * m2-lang.c (m2_language_data): Delete
1149         la_collect_symbol_completion_matches initializer.
1150         * objc-lang.c (objc_language_data): Likewise.
1151         * opencl-lang.c (opencl_language_data): Likewise.
1152         * p-lang.c (pascal_language_data): Likewise.
1153         * rust-lang.c (rust_language_data): Likewise.
1154         * symtab.c (default_collect_symbol_completion_matches): Delete.
1155         (collect_symbol_completion_matches): Update call to
1156         collect_symbol_completion_matches.
1157         (collect_symbol_completion_matches_type): Likewise.
1158         * symtab.h (default_collect_symbol_completion_matches): Delete
1159         declaration.
1160
1161 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
1164         (ada_language_data): Delete la_word_break_characters initializer.
1165         (ada_language::word_break_characters): New member function.
1166         * c-lang.c (c_language_data): Delete la_word_break_characters
1167         initializer.
1168         (cplus_language_data): Likewise.
1169         (asm_language_data): Likewise.
1170         (minimal_language_data): Likewise.
1171         * completer.c: Update global comment.
1172         (advance_to_expression_complete_word_point): Update call to
1173         word_break_characters.
1174         (complete_files_symbols): Likewise.
1175         (complete_line_internal_1): Likewise.
1176         (default_completer_handle_brkchars): Likewise.
1177         (skip_quoted_chars): Likewise.
1178         * d-lang.c (d_language_data): Delete la_word_break_characters
1179         initializer.
1180         * f-lang.c (f_word_break_characters): Delete.
1181         (f_language_data): Delete la_word_break_characters initializer.
1182         (f_language::word_break_characters): New member function.
1183         * go-lang.c (go_language_data): Delete la_word_break_characters
1184         initializer.
1185         * language.c (unknown_language_data): Likewise.
1186         (auto_language_data): Likewise.
1187         * language.h (default_word_break_characters): Move declaration to
1188         earlier in the file.
1189         (language_data): Delete la_word_break_characters field.
1190         (language_defn::word_break_characters): New member function.
1191         * m2-lang.c (m2_language_data): Delete la_word_break_characters
1192         initializer.
1193         * objc-lang.c (objc_language_data): Likewise.
1194         * opencl-lang.c (opencl_language_data): Likewise.
1195         * p-lang.c (pascal_language_data): Likewise.
1196         * rust-lang.c (rust_language_data): Likewise.
1197
1198 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
1201         (ada_language_data): Delete la_get_symbol_name_matcher
1202         initializer.
1203         (language_defn::get_symbol_name_matcher_inner): New member
1204         function.
1205         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
1206         initializer.
1207         (cplus_language_data): Likewise.
1208         (cplus_language::get_symbol_name_matcher_inner): New member
1209         function.
1210         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
1211         (minimal_language_data): Likewise.
1212         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
1213         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
1214         initializer.
1215         * dictionary.c (iter_match_first_hashed): Update call to
1216         get_symbol_name_matcher.
1217         (iter_match_next_hashed): Likewise.
1218         (iter_match_next_linear): Likewise.
1219         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
1220         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
1221         initializer.
1222         (f_language::get_symbol_name_matcher_inner): New member function.
1223         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
1224         initializer.
1225         * language.c (default_symbol_name_matcher): Update header comment,
1226         make static.
1227         (language_defn::get_symbol_name_matcher): New definition.
1228         (language_defn::get_symbol_name_matcher_inner): Likewise.
1229         (get_symbol_name_matcher): Delete.
1230         (unknown_language_data): Delete la_get_symbol_name_matcher
1231         initializer.
1232         (auto_language_data): Likewise.
1233         * language.h (language_data): Delete la_get_symbol_name_matcher
1234         field.
1235         (language_defn::get_symbol_name_matcher): New member function.
1236         (language_defn::get_symbol_name_matcher_inner): Likewise.
1237         (default_symbol_name_matcher): Delete declaration.
1238         * linespec.c (find_methods): Update call to
1239         get_symbol_name_matcher.
1240         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
1241         initializer.
1242         * minsyms.c (lookup_minimal_symbol): Update call to
1243         get_symbol_name_matcher.
1244         (iterate_over_minimal_symbols): Likewise.
1245         * objc-lang.c (objc_language_data): Delete
1246         la_get_symbol_name_matcher initializer.
1247         * opencl-lang.c (opencl_language_data): Likewise.
1248         * p-lang.c (pascal_language_data): Likewise.
1249         * psymtab.c (psymbol_name_matches): Update call to
1250         get_symbol_name_matcher.
1251         * rust-lang.c (rust_language_data): Delete
1252         la_get_symbol_name_matcher initializer.
1253         * symtab.c (symbol_matches_search_name): Update call to
1254         get_symbol_name_matcher.
1255         (compare_symbol_name): Likewise.
1256
1257 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * ada-lang.c (ada_language_data): Delete la_compute_program
1260         initializer.
1261         * c-lang.c (c_language_data): Likewise.
1262         (c_language::compute_program): New member function.
1263         (cplus_language_data): Delete la_compute_program initializer.
1264         (cplus_language::compute_program): New member function.
1265         (asm_language_data): Delete la_compute_program initializer.
1266         (minimal_language_data): Likewise.
1267         * c-lang.h (c_compute_program): Update comment.
1268         (cplus_compute_program): Likewise.
1269         * compile/compile-c-support.c (c_compute_program): Likewise.
1270         (cplus_compute_program): Likewise.
1271         * compile/compile.c (compile_to_object): Update call to
1272         la_compute_program.
1273         * d-lang.c (d_language_data): Delete la_compute_program
1274         initializer.
1275         * f-lang.c (f_language_data): Likewise.
1276         * go-lang.c (go_language_data): Likewise.
1277         * language.c (unknown_language_data): Likewise.
1278         (auto_language_data): Likewise.
1279         * language.h (language_data): Delete la_compute_program field.
1280         (language_defn::compute_program): New member function.
1281         * m2-lang.c (m2_language_data): Delete la_compute_program
1282         initializer.
1283         * objc-lang.c (objc_language_data): Likewise.
1284         * opencl-lang.c (opencl_language_data): Likewise.
1285         * p-lang.c (pascal_language_data): Likewise.
1286         * rust-lang.c (rust_language_data): Likewise.
1287
1288 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * ada-lang.c (ada_language_data) Delete
1291         la_class_name_from_physname initializer.
1292         * c-lang.c (c_language_data): Likewise.
1293         (cplus_language_data): Likewise.
1294         (cplus_language::class_name_from_physname): New member function.
1295         (asm_language_data): Delete la_class_name_from_physname
1296         initializer.
1297         (minimal_language_data): Likewise.
1298         * d-lang.c (d_language_data): Likewise.
1299         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
1300         method on language_defn class.
1301         (guess_full_die_structure_name): Likewise.
1302         * f-lang.c (f_language_data): Delete la_class_name_from_physname
1303         initializer.
1304         * go-lang.c (go_language_data): Likewise.
1305         * language.c (language_class_name_from_physname): Delete.
1306         (unk_lang_class_name): Delete.
1307         (unknown_language_data): Delete la_class_name_from_physname
1308         initializer.
1309         (auto_language_data): Likewise.
1310         * language.h (language_data): Delete la_class_name_from_physname
1311         field.
1312         (language_defn::class_name_from_physname): New function.
1313         (language_class_name_from_physname): Delete declaration.
1314         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
1315         initializer.
1316         * objc-lang.c (objc_language_data): Likewise.
1317         * opencl-lang.c (opencl_language_data): Likewise.
1318         * p-lang.c (pascal_language_data): Likewise.
1319         * rust-lang.c (rust_language_data): Likewise.
1320
1321 2020-06-16  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-data.h (STATUS_NAME): New macro.
1324         * tui/tui-layout.c (tui_remove_some_windows)
1325         (initialize_known_windows, tui_register_window)
1326         (tui_layout_split::remove_windows, initialize_layouts)
1327         (tui_new_layout_command): Don't use hard-coded window names.
1328
1329 2020-06-16  Tom Tromey  <tom@tromey.com>
1330
1331         PR tui/25348:
1332         * tui/tui.c (tui_ensure_readline_initialized): Rename from
1333         tui_initialize_readline.  Only run once.  Call rl_initialize.
1334         * tui/tui.h (tui_ensure_readline_initialized): Rename from
1335         tui_initialize_readline.
1336         * tui/tui-io.c (tui_setup_io): Call
1337         tui_ensure_readline_initialized.
1338         * tui/tui-interp.c (tui_interp::init): Update.
1339
1340 2020-06-16  Tom Tromey  <tom@tromey.com>
1341
1342         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
1343         Also preserve the status window.
1344
1345 2020-06-16  Tom Tromey  <tom@tromey.com>
1346
1347         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
1348         where m_window==nullptr.
1349
1350 2020-06-15  Tom Tromey  <tromey@adacore.com>
1351
1352         * windows-nat.c (windows_nat::handle_output_debug_string):
1353         Update.
1354         (windows_nat::handle_ms_vc_exception): Update.
1355         * target.h (target_read_string): Change API.
1356         * target.c (target_read_string): Change API.
1357         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
1358         Update.
1359         * solib-frv.c (frv_current_sos): Update.
1360         * solib-dsbt.c (dsbt_current_sos): Update.
1361         * solib-darwin.c (darwin_current_sos): Update.
1362         * linux-thread-db.c (inferior_has_bug): Update.
1363         * expprint.c (print_subexp_standard): Update.
1364         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
1365         (ada_exception_message_1): Update.
1366
1367 2020-06-15  Tom Tromey  <tromey@adacore.com>
1368
1369         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
1370
1371 2020-06-15  Tom Tromey  <tromey@adacore.com>
1372
1373         * valprint.c (read_string): Update comment.
1374         * target.c (MIN): Remove.
1375         (target_read_string): Rewrite.
1376
1377 2020-06-15  Tom Tromey  <tromey@adacore.com>
1378
1379         * corefile.c (read_memory_string): Remove.
1380         * ada-valprint.c (ada_value_print_ptr): Update.
1381         * ada-lang.h (ada_tag_name): Change return type.
1382         * ada-lang.c (type_from_tag): Update.
1383         (ada_tag_name_from_tsd): Change return type.  Use
1384         target_read_string.
1385         (ada_tag_name): Likewise.
1386         * gdbcore.h (read_memory_string): Don't declare.
1387
1388 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
1389
1390         * symtab.c (rbreak_command): Ignore Windows drive colon.
1391
1392 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
1393
1394         * NEWS: Mention removed GDBserver host support.
1395
1396 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
1397
1398         * features/riscv/rebuild-csr-xml.sh: Updated.
1399
1400 2020-06-11  Tom Tromey  <tom@tromey.com>
1401
1402         PR gdb/18318:
1403         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
1404
1405 2020-06-09  Jonny Grant  <jg@jguk.org>
1406 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
1407
1408         * main.c (captured_main_1): Don't print new line after help.
1409         (print_gdb_help): add mailing list and IRC channel information
1410         to --help.  Add new lines between items in the footer.  Remove
1411         quotes around bug url.
1412
1413 2020-06-11  Keith Seitz  <keiths@redhat.com>
1414
1415         PR gdb/21356
1416         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
1417         Resolve typedefs for type length calculations.
1418
1419 2020-06-10  Tom de Vries  <tdevries@suse.de>
1420
1421         PR ada/24713
1422         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
1423         (write_psymbols): Enable .gdb_index for ada.
1424         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
1425         ada.
1426
1427 2020-06-10  Tom de Vries  <tdevries@suse.de>
1428
1429         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
1430         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
1431         namei" instead of "const char *name" argument.
1432         (dw2_map_matching_symbols): Use "offset_type namei" variant of
1433         dw2_symtab_iter_init.
1434
1435 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1436
1437         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
1438         to use type::field and field::type instead.
1439
1440 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1441
1442         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
1443         to use field::type instead.
1444
1445 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1446
1447         * gdbtypes.h (struct field) <type, set_type>: New methods.
1448         Rename `type` field to...
1449         <m_type>: ... this.  Change references throughout to use type or
1450         set_type methods.
1451         (FIELD_TYPE): Use field::type.  Change call sites that modify
1452         the field's type to use field::set_type instead.
1453
1454 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1455
1456         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
1457         to use type::index_type instead.
1458
1459 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1460
1461         * gdbtypes.h (struct type) <index_type, set_index_type>: New
1462         methods.
1463         (TYPE_INDEX_TYPE): Use type::index_type.
1464         * gdbtypes.c (create_array_type_with_stride): Likewise.
1465
1466 2020-06-07  Tom Tromey  <tom@tromey.com>
1467
1468         * valprint.c (generic_val_print_float): Remove "embedded_offset"
1469         parameter.
1470         (generic_value_print): Update.
1471
1472 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         Revert commit 982a38f60b0.
1475         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
1476
1477 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
1480         avoid use after free.
1481
1482 2020-06-05  Tom de Vries  <tdevries@suse.de>
1483
1484         * NEWS: Fix typos.
1485
1486 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
1487
1488         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
1489         the per_bfd object.
1490         (dwarf2_read_debug_names): Likewise.
1491         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
1492         object when re-using a per_bfd object with an index.
1493
1494 2020-06-03  Tom de Vries  <tdevries@suse.de>
1495
1496         PR symtab/26046
1497         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
1498         children for C++.
1499         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
1500         DW_TAG_subprogram.
1501
1502 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1503
1504         * ada-lang.c (ada_language_data): Delete skip_trampoline
1505         initializer.
1506         * c-lang.c (c_language_data): Likewise.
1507         (cplus_language_data): Likewise.
1508         (cplus_language::skip_trampoline): New member function.
1509         (asm_language_data): Delete skip_trampoline initializer.
1510         (minimal_language_data): Likewise.
1511         * d-lang.c (d_language_data): Likewise.
1512         * f-lang.c (f_language_data): Likewise.
1513         * go-lang.c (go_language_data): Likewise.
1514         * language.c (unk_lang_trampoline): Delete function.
1515         (skip_language_trampoline): Update.
1516         (unknown_language_data): Delete skip_trampoline initializer.
1517         (auto_language_data): Likewise.
1518         * language.h (language_data): Delete skip_trampoline field.
1519         (language_defn::skip_trampoline): New function.
1520         * m2-lang.c (m2_language_data): Delete skip_trampoline
1521         initializer.
1522         * objc-lang.c (objc_skip_trampoline): Delete function, move
1523         implementation to objc_language::skip_trampoline.
1524         (objc_language_data): Delete skip_trampoline initializer.
1525         (objc_language::skip_trampoline): New member function with
1526         implementation from objc_skip_trampoline.
1527         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
1528         initializer.
1529         * p-lang.c (pascal_language_data): Likewise.
1530         * rust-lang.c (rust_language_data): Likewise.
1531
1532 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1533
1534         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
1535         (ada_language::demangle): New member function.
1536         * c-lang.c (c_language_data): Delete la_demangle initializer.
1537         (cplus_language_data): Delete la_demangle initializer.
1538         (cplus_language::demangle): New member function.
1539         (asm_language_data): Delete la_demangle initializer.
1540         (minimal_language_data): Delete la_demangle initializer.
1541         * d-lang.c (d_language_data): Delete la_demangle initializer.
1542         (d_language::demangle): New member function.
1543         * f-lang.c (f_language_data): Delete la_demangle initializer.
1544         (f_language::demangle): New member function.
1545         * go-lang.c (go_language_data): Delete la_demangle initializer.
1546         (go_language::demangle): New member function.
1547         * language.c (language_demangle): Update.
1548         (unk_lang_demangle): Delete.
1549         (unknown_language_data): Delete la_demangle initializer.
1550         (unknown_language::demangle): New member function.
1551         (auto_language_data): Delete la_demangle initializer.
1552         (auto_language::demangle): New member function.
1553         * language.h (language_data): Delete la_demangle field.
1554         (language_defn::demangle): New function.
1555         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
1556         * objc-lang.c (objc_language_data): Delete la_demangle
1557         initializer.
1558         (objc_language::demangle): New member function.
1559         * opencl-lang.c (opencl_language_data): Delete la_demangle
1560         initializer.
1561         * p-lang.c (pascal_language_data): Likewise.
1562         * rust-lang.c (rust_language_data): Likewise.
1563         (rust_language::demangle): New member function.
1564
1565 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1566
1567         * ada-lang.c (ada_language_data): Delete la_print_type
1568         initializer.
1569         (ada_language::print_type): New member function.
1570         * c-lang.c (c_language_data): Delete la_print_type initializer.
1571         (c_language::print_type): New member function.
1572         (cplus_language_data): Delete la_print_type initializer.
1573         (cplus_language::print_type): New member function.
1574         (asm_language_data): Delete la_print_type initializer.
1575         (asm_language::print_type): New member function.
1576         (minimal_language_data): Delete la_print_type initializer.
1577         (minimal_language::print_type): New member function.
1578         * d-lang.c (d_language_data): Delete la_print_type initializer.
1579         (d_language::print_type): New member function.
1580         * f-lang.c (f_language_data): Delete la_print_type initializer.
1581         (f_language::print_type): New member function.
1582         * go-lang.c (go_language_data): Delete la_print_type initializer.
1583         (go_language::print_type): New member function.
1584         * language.c (unk_lang_print_type): Delete.
1585         (unknown_language_data): Delete la_print_type initializer.
1586         (unknown_language::print_type): New member function.
1587         (auto_language_data): Delete la_print_type initializer.
1588         (auto_language::print_type): New member function.
1589         * language.h (language_data): Delete la_print_type field.
1590         (language_defn::print_type): New function.
1591         (LA_PRINT_TYPE): Update.
1592         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
1593         (m2_language::print_type): New member function.
1594         * objc-lang.c (objc_language_data): Delete la_print_type
1595         initializer.
1596         (objc_language::print_type): New member function.
1597         * opencl-lang.c (opencl_print_type): Delete, implementation moved
1598         to opencl_language::print_type.
1599         (opencl_language_data): Delete la_print_type initializer.
1600         (opencl_language::print_type): New member function, implementation
1601         from opencl_print_type.
1602         * p-lang.c (pascal_language_data): Delete la_print_type
1603         initializer.
1604         (pascal_language::print_type): New member function.
1605         * rust-lang.c (rust_print_type): Delete, implementation moved to
1606         rust_language::print_type.
1607         (rust_language_data): Delete la_print_type initializer.
1608         (rust_language::print_type): New member function, implementation
1609         from rust_print_type.
1610
1611 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
1614         implementation moves to...
1615         (ada_language::sniff_from_mangled_name): ...here.  Update return
1616         type.
1617         (ada_language_data): Delete la_sniff_from_mangled_name
1618         initializer.
1619         * c-lang.c (c_language_data): Likewise.
1620         (cplus_language_data): Likewise.
1621         (cplus_language::sniff_from_mangled_name): New member function,
1622         implementation taken from gdb_sniff_from_mangled_name.
1623         (asm_language_data): Delete la_sniff_from_mangled_name
1624         initializer.
1625         (minimal_language_data): Likewise.
1626         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
1627         implementation moves to cplus_language::sniff_from_mangled_name.
1628         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
1629         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
1630         moves to...
1631         (d_language::sniff_from_mangled_name): ...here.
1632         (d_language_data): Delete la_sniff_from_mangled_name initializer.
1633         * f-lang.c (f_language_data): Likewise.
1634         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
1635         moves to...
1636         (go_language::sniff_from_mangled_name): ...here.
1637         (go_language_data): Delete la_sniff_from_mangled_name initializer.
1638         * language.c (language_sniff_from_mangled_name): Delete.
1639         (unknown_language_data): Delete la_sniff_from_mangled_name
1640         initializer.
1641         (auto_language_data): Likewise.
1642         * language.h (language_data): Delete la_sniff_from_mangled_name
1643         field.
1644         (language_defn::sniff_from_mangled_name): New function.
1645         (language_sniff_from_mangled_name): Delete declaration.
1646         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
1647         field.
1648         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
1649         implementation moves to...
1650         (objc_language::sniff_from_mangled_name): ...here.
1651         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
1652         * opencl-lang.c (opencl_language_data): Likewise.
1653         * p-lang.c (pascal_language_data): Likewise.
1654         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
1655         implementation moves to...
1656         (rust_language::sniff_from_mangled_name): ...here.
1657         (rust_language_data): Delete la_sniff_from_mangled_name
1658         initializer.
1659         * symtab.c (symbol_find_demangled_name): Call
1660         sniff_from_mangled_name member function.
1661
1662 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * ada-lang.c (ada_language_data): Delete la_search_name_hash
1665         initializer.
1666         * c-lang.c (c_language_data): Likewise.
1667         (cplus_language_data): Likewise.
1668         (cplus_language::search_name_hash): New member function.
1669         (asm_language_data): Delete la_search_name_hash initializer.
1670         (minimal_language_data): Likewise.
1671         * d-lang.c (d_language_data): Likewise.
1672         * dictionary.c (default_search_name_hash): Rename to...
1673         (language_defn::search_name_hash): ...this.
1674         * f-lang.c (f_language_data): Likewise.
1675         (f_language::search_name_hash): New member function.
1676         * go-lang.c (go_language_data): Delete la_search_name_hash
1677         initializer.
1678         * language.c (unknown_language_data): Likewise.
1679         (auto_language_data): Likewise.
1680         * language.h (struct language_data): Delete la_search_name_hash
1681         field.
1682         (language_defn::search_name_hash): Declare new member function.
1683         (default_search_name_hash): Delete declaration.
1684         * m2-lang.c (m2_language_data): Delete la_search_name_hash
1685         initializer.
1686         * objc-lang.c (objc_language_data): Likewise.
1687         * opencl-lang.c (opencl_language_data): Likewise.
1688         * p-lang.c (pascal_language_data): Likewise.
1689         * rust-lang.c (rust_language_data): Likewise.
1690         * symtab.c (search_name_hash): Update call.
1691
1692 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1693
1694         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
1695         initializer.
1696         * c-lang.c (class compile_instance): Declare.
1697         (c_language_data): Delete la_get_compile_instance initializer.
1698         (c_language::get_compile_instance): New member function.
1699         (cplus_language_data): Delete la_get_compile_instance initializer.
1700         (cplus_language::get_compile_instance): New member function.
1701         (asm_language_data): Delete la_get_compile_instance initializer.
1702         (minimal_language_data): Likewise.
1703         * c-lang.h (c_get_compile_context): Update comment.
1704         (cplus_get_compile_context): Update comment.
1705         * compile/compile.c (compile_to_object): Update calls, don't rely
1706         on function pointer being NULL.
1707         * d-lang.c (d_language_data): Delete la_get_compile_instance
1708         initializer.
1709         * f-lang.c (f_language_data): Likewise.
1710         * go-lang.c (go_language_data): Likewise.
1711         * language.c (unknown_language_data): Likewise.
1712         (auto_language_data): Likewise.
1713         * language.h (language_data): Delete la_get_compile_instance field.
1714         (language_defn::get_compile_instance): New member function.
1715         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
1716         initializer.
1717         * objc-lang.c (objc_language_data): Likewise.
1718         * opencl-lang.c (opencl_language_data): Likewise.
1719         * p-lang.c (pascal_language_data): Likewise.
1720         * rust-lang.c (rust_language_data): Likewise.
1721
1722 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1723
1724         * ada-lang.c (ada_add_all_symbols): Update comment.
1725         (ada_iterate_over_symbols): Delete, move implementation to...
1726         (ada_language::iterate_over_symbols): ...here, a new member
1727         function, rewrite to use range based for loop.
1728         (ada_language_data): Delete la_iterate_over_symbols initializer.
1729         * c-lang.c (c_language_data): Likewise.
1730         (cplus_language_data): Likewise.
1731         (asm_language_data): Likewise.
1732         (minimal_language_data): Likewise.
1733         * d-lang.c (d_language_data): Likewise.
1734         * f-lang.c (f_language_data): Likewise.
1735         * go-lang.c (go_language_data): Likewise.
1736         * language.c (unknown_language_data): Likewise.
1737         (auto_language_data): Likewise.
1738         * language.h (language_data): Delete la_iterate_over_symbols field.
1739         (language_defn::iterate_over_symbols): New member function.
1740         (LA_ITERATE_OVER_SYMBOLS): Update.
1741         * linespec.c (iterate_over_all_matching_symtabs): Update.
1742         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
1743         initializer.
1744         * objc-lang.c (objc_language_data): Likewise.
1745         * opencl-lang.c (opencl_language_data): Likewise.
1746         * p-lang.c (pascal_language_data): Likewise.
1747         * rust-lang.c (rust_language_data): Likewise.
1748
1749 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1750
1751         * ada-lang.c (ada_language_data): Delete
1752         la_lookup_transparent_type initializer.
1753         * c-lang.c (c_language_data): Likewise.
1754         (cplus_language_data): Likewise.
1755         (cplus_language::lookup_transparent_type): New member function.
1756         (asm_language_data): Delete la_lookup_transparent_type
1757         initializer.
1758         (minimal_language_data): Likewise.
1759         * d-lang.c (d_language_data): Likewise.
1760         * f-lang.c (f_language_data): Likewise.
1761         * go-lang.c (go_language_data): Likewise.
1762         * language.c (unknown_language_data): Likewise.
1763         (auto_language_data): Likewise.
1764         * language.h (struct language_data): Delete
1765         la_lookup_transparent_type field.
1766         (language_defn::lookup_transparent_type): New member function.
1767         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
1768         initializer.
1769         * objc-lang.c (objc_language_data): Likewise.
1770         * opencl-lang.c (opencl_language_data): Likewise.
1771         * p-lang.c (pascal_language_data): Likewise.
1772         * rust-lang.c (rust_language_data): Likewise.
1773         * symtab.c (symbol_matches_domain): Update call.
1774
1775 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1776
1777         * ada-lang.c (ada_language_arch_info): Delete function, move
1778         implementation to...
1779         (ada_language::language_arch_info): ...here, a new member
1780         function.
1781         (ada_language_data): Delete la_language_arch_info.
1782         * c-lang.c (c_language_data): Likewise.
1783         (c_language::language_arch_info): New member function.
1784         (cplus_language_arch_info): Delete function, move
1785         implementation to...
1786         (cplus_language::language_arch_info): ...here, a new member
1787         function.
1788         (cplus_language_data): Delete la_language_arch_info.
1789         (asm_language_data): Likewise.
1790         (asm_language::language_arch_info): New member function.
1791         (minimal_language_data): Delete la_language_arch_info.
1792         (minimal_language::language_arch_info): New member function.
1793         * d-lang.c (d_language_arch_info): Delete function, move
1794         implementation to...
1795         (d_language::language_arch_info): ...here, a new member
1796         function.
1797         (d_language_data): Delete la_language_arch_info.
1798         * f-lang.c (f_language_arch_info): Delete function, move
1799         implementation to...
1800         (f_language::language_arch_info): ...here, a new member
1801         function.
1802         (f_language_data): Delete la_language_arch_info.
1803         * go-lang.c (go_language_arch_info): Delete function, move
1804         implementation to...
1805         (go_language::language_arch_info): ...here, a new member
1806         function.
1807         (go_language_data): Delete la_language_arch_info.
1808         * language.c (unknown_language_data): Likewise.
1809         (unknown_language::language_arch_info): New member function.
1810         (auto_language_data): Delete la_language_arch_info.
1811         (auto_language::language_arch_info): New member function.
1812         (language_gdbarch_post_init): Update call to
1813         la_language_arch_info.
1814         * language.h (language_data): Delete la_language_arch_info
1815         function pointer.
1816         (language_defn::language_arch_info): New function.
1817         * m2-lang.c (m2_language_arch_info): Delete function, move
1818         implementation to...
1819         (m2_language::language_arch_info): ...here, a new member
1820         function.
1821         (m2_language_data): Delete la_language_arch_info.
1822         * objc-lang.c (objc_language_arch_info): Delete function, move
1823         implementation to...
1824         (objc_language::language_arch_info): ...here, a new member
1825         function.
1826         (objc_language_data): Delete la_language_arch_info.
1827         * opencl-lang.c (opencl_language_arch_info): Delete function, move
1828         implementation to...
1829         (opencl_language::language_arch_info): ...here, a new member
1830         function.
1831         (opencl_language_data): Delete la_language_arch_info.
1832         * p-lang.c (pascal_language_arch_info): Delete function, move
1833         implementation to...
1834         (pascal_language::language_arch_info): ...here, a new member
1835         function.
1836         (pascal_language_data): Delete la_language_arch_info.
1837         * rust-lang.c (rust_language_arch_info): Delete function, move
1838         implementation to...
1839         (rust_language::language_arch_info): ...here, a new member
1840         function.
1841         (rust_language_data): Delete la_language_arch_info.
1842
1843 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
1846         initializer.
1847         * c-lang.c (c_language_data): Likewise.
1848         (cplus_language_data): Likewise.
1849         (cplus_language::pass_by_reference_info): New method.
1850         (asm_language_data): Delete la_pass_by_reference initializer.
1851         (minimal_language_data): Likewise.
1852         * cp-abi.c (cp_pass_by_reference): Remove use of
1853         default_pass_by_reference.
1854         * d-lang.c (d_language_data): Likewise.
1855         * f-lang.c (f_language_data): Likewise.
1856         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
1857         default_pass_by_reference.
1858         * go-lang.c (go_language_data): Likewise.
1859         * language.c (language_pass_by_reference): Update.
1860         (default_pass_by_reference): Delete.
1861         (unknown_language_data): Delete la_pass_by_reference
1862         initializer.
1863         (auto_language_data): Likewise.
1864         * language.h (struct language_data): Delete la_pass_by_reference
1865         field.
1866         (language_defn::pass_by_reference_info): New member function.
1867         (default_pass_by_reference): Delete declaration.
1868         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
1869         initializer.
1870         * objc-lang.c (objc_language_data): Likewise.
1871         * opencl-lang.c (opencl_language_data): Likewise.
1872         * p-lang.c (pascal_language_data): Likewise.
1873         * rust-lang.c (rust_language_data): Likewise.
1874
1875 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1876
1877         * ada-lang.c (ada_read_var_value): Delete function, move
1878         implementation to...
1879         (ada_language::read_var_value): ...here.
1880         (ada_language_data): Delete la_read_var_value initializer.
1881         * c-lang.c (c_language_data): Likewise.
1882         (cplus_language_data): Likewise.
1883         (minimal_language_data): Likewise.
1884         * d-lang.c (d_language_data): Likewise.
1885         * f-lang.c (f_language_data): Likewise.
1886         * findvar.c (default_read_var_value): Rename to...
1887         (language_defn::read_var_value): ...this.
1888         * findvar.c (read_var_value): Update header comment, and change to
1889         call member function instead of function pointer.
1890         * go-lang.c (go_language_data): Likewise.
1891         * language.c (unknown_language_data): Delete la_read_var_value
1892         initializer.
1893         (auto_language_data): Likewise.
1894         * language.h (struct language_data): Delete la_read_var_value
1895         field.
1896         (language_defn::read_var_value): New member function.
1897         (default_read_var_value): Delete declaration.
1898         * m2-lang.c (m2_language_data): Delete la_read_var_value
1899         initializer.
1900         * objc-lang.c (objc_language_data): Likewise.
1901         * opencl-lang.c (opencl_language_data): Likewise.
1902         * p-lang.c (pascal_language_data): Likewise.
1903         * rust-lang.c (rust_language_data): Likewise.
1904         * value.h (default_read_var_value): Delete declaration.
1905
1906 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1907
1908         * ada-lang.c (ada_print_array_index): Delete function, move
1909         implementation to...
1910         (ada_language::print_array_index): ...here.
1911         (ada_language_data): Delete la_print_array_index initializer.
1912         * c-lang.c (c_language_data): Likewise.
1913         (cplus_language_data): Likewise.
1914         (minimal_language_data): Likewise.
1915         * d-lang.c (d_language_data): Likewise.
1916         * f-lang.c (f_language_data): Likewise.
1917         * go-lang.c (go_language_data): Likewise.
1918         * language.c (default_print_array_index): Delete function, move
1919         implementation to...
1920         (language_defn::print_array_index): ...here.
1921         (unknown_language_data): Delete la_print_array_index initializer.
1922         (auto_language_data): Likewise.
1923         * language.h (struct language_data): Delete la_print_array_index
1924         field.
1925         (language_defn::print_array_index): New member function.
1926         (LA_PRINT_ARRAY_INDEX): Update.
1927         (default_print_array_index): Delete declaration.
1928         * m2-lang.c (m2_language_data): Delete la_print_array_index
1929         initializer.
1930         * objc-lang.c (objc_language_data): Likewise.
1931         * opencl-lang.c (opencl_language_data): Likewise.
1932         * p-lang.c (pascal_language_data): Likewise.
1933         * rust-lang.c (rust_language_data): Likewise.
1934
1935 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1936
1937         * gdb/ada-lang.c (ada_language_defn): Convert to...
1938         (ada_language_data): ...this.
1939         (class ada_language): New class.
1940         (ada_language_defn): New static global.
1941         * gdb/c-lang.c (c_language_defn): Convert to...
1942         (c_language_data): ...this.
1943         (class c_language): New class.
1944         (c_language_defn): New static global.
1945         (cplus_language_defn): Convert to...
1946         (cplus_language_data): ...this.
1947         (class cplus_language): New class.
1948         (cplus_language_defn): New static global.
1949         (asm_language_defn): Convert to...
1950         (asm_language_data): ...this.
1951         (class asm_language): New class.
1952         (asm_language_defn): New static global.
1953         (minimal_language_defn): Convert to...
1954         (minimal_language_data): ...this.
1955         (class minimal_language): New class.
1956         (minimal_language_defn): New static global.
1957         * gdb/d-lang.c (d_language_defn): Convert to...
1958         (d_language_data): ...this.
1959         (class d_language): New class.
1960         (d_language_defn): New static global.
1961         * gdb/f-lang.c (f_language_defn): Convert to...
1962         (f_language_data): ...this.
1963         (class f_language): New class.
1964         (f_language_defn): New static global.
1965         * gdb/go-lang.c (go_language_defn): Convert to...
1966         (go_language_data): ...this.
1967         (class go_language): New class.
1968         (go_language_defn): New static global.
1969         * gdb/language.c (unknown_language_defn): Remove declaration.
1970         (current_language): Initialize to nullptr, real initialization is
1971         moved to _initialize_language.
1972         (languages): Delete global.
1973         (language_defn::languages): Define.
1974         (set_language_command): Use language_defn::languages.
1975         (set_language): Likewise.
1976         (range_error): Likewise.
1977         (language_enum): Likewise.
1978         (language_def): Likewise.
1979         (add_set_language_command): Use language_def::languages for the
1980         language list, and language_def to lookup language pointers.
1981         (skip_language_trampoline): Use language_defn::languages.
1982         (unknown_language_defn): Convert to...
1983         (unknown_language_data): ...this.
1984         (class unknown_language): New class.
1985         (unknown_language_defn): New static global.
1986         (auto_language_defn): Convert to...
1987         (auto_language_data): ...this.
1988         (class auto_language): New class.
1989         (auto_language_defn): New static global.
1990         (language_gdbarch_post_init): Use language_defn::languages.
1991         (_initialize_language): Initialize current_language.
1992         * gdb/language.h (struct language_defn): Rename to...
1993         (struct language_data): ...this.
1994         (struct language_defn): New.
1995         (auto_language_defn): Delete.
1996         (unknown_language_defn): Delete.
1997         (minimal_language_defn): Delete.
1998         (ada_language_defn): Delete.
1999         (asm_language_defn): Delete.
2000         (c_language_defn): Delete.
2001         (cplus_language_defn): Delete.
2002         (d_language_defn): Delete.
2003         (f_language_defn): Delete.
2004         (go_language_defn): Delete.
2005         (m2_language_defn): Delete.
2006         (objc_language_defn): Delete.
2007         (opencl_language_defn): Delete.
2008         (pascal_language_defn): Delete.
2009         (rust_language_defn): Delete.
2010         * gdb/m2-lang.c (m2_language_defn): Convert to...
2011         (m2_language_data): ...this.
2012         (class m2_language): New class.
2013         (m2_language_defn): New static global.
2014         * gdb/objc-lang.c (objc_language_defn): Convert to...
2015         (objc_language_data): ...this.
2016         (class objc_language): New class.
2017         (objc_language_defn): New static global.
2018         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
2019         (opencl_language_data): ...this.
2020         (class opencl_language): New class.
2021         (opencl_language_defn): New static global.
2022         * gdb/p-lang.c (pascal_language_defn): Convert to...
2023         (pascal_language_data): ...this.
2024         (class pascal_language): New class.
2025         (pascal_language_defn): New static global.
2026         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
2027         language pointer, update comment format.
2028         * gdb/rust-lang.c (rust_language_defn): Convert to...
2029         (rust_language_data): ...this.
2030         (class rust_language): New class.
2031         (rust_language_defn): New static global.
2032
2033 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2034
2035         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
2036         member variable.
2037         <m_stmt_at_address>: New member variable.
2038         (lnp_state_machine::record_line): Don't record some lines, update
2039         tracking of is_stmt at the same address.
2040         (lnp_state_machine::lnp_state_machine): Initialise new member
2041         variables.
2042
2043 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2044
2045         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
2046         "-include gnu-nat-mig.h".
2047         * gnu-nat-mig.h: New file.
2048         * gnu-nat.c: Include "gnu-nat-mig.h".
2049         (exc_server, msg_reply_server, notify_server,
2050         process_reply_server): Remove declarations.
2051
2052 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2053
2054         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
2055         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
2056         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
2057         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
2058         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
2059         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
2060         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
2061         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
2062         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
2063         to gnu_nat_target class.
2064         * gnu-nat.c: Likewise.
2065         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
2066         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
2067         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
2068         object.
2069         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
2070         instead of `gnu_target'.
2071
2072 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2073
2074         * i386-gnu-tdep.c: Include "gdbcore.h"
2075         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
2076         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
2077         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
2078         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
2079         i386_gnu_sigcontext_addr): New functions
2080         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
2081         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
2082         tdep.
2083
2084 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2085
2086         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
2087         before fork_inferior call. Avoid calling it if target_is_pushed returns
2088         true.
2089
2090 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2091
2092         * gnu-nat.h (gnu_target): New variable declaration.
2093         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
2094         gnu_target.
2095         * gnu-nat.c (gnu_target): New variable.
2096         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
2097         add_thread_silent, and add_thread calls.
2098         (gnu_nat_target::create_inferior): Pass gnu_target to
2099         add_thread_silent, thread_change_ptid call.
2100         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
2101         call.
2102
2103 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2104
2105         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
2106         (gnu_nat_target::find_memory_regions): Remove unused
2107         `old_address' variable.
2108
2109 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2110
2111         * gnu-nat.c: Include "gdbarch.h".
2112
2113 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2114
2115         * reply_mig_hack.awk (Error return): Cast function through
2116         void *, to bypass compiler function call check.
2117
2118 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2119
2120         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
2121         $(srcdir)/reply_mig_hack.awk.
2122
2123 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2124
2125         * gnu-nat.h (gnu_debug_flag): Set type to bool.
2126
2127 2020-05-30  Jonny Grant  <jg@jguk.org>
2128
2129         * configure.ac (ACX_BUGURL): change bug URL to https.
2130
2131 2020-05-30  Pedro Alves  <palves@redhat.com>
2132
2133         * cp-support.c (replace_typedefs_template): New.
2134         (replace_typedefs_qualified_name): Handle
2135         DEMANGLE_COMPONENT_TEMPLATE.
2136
2137 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
2138
2139         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
2140         dwarf2/index-cache.h, dwarf2/index-write.c,
2141         dwarf2/index-write.h, dwarf2/line-header.c,
2142         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
2143         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
2144         variables and fields from `dwarf2_per_objfile` to just
2145         `per_objfile` throughout.
2146
2147 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
2148
2149         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2150         <push_dwarf_reg_entry_value>: Add comment.
2151
2152 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
2153             Keith Seitz  <keiths@redhat.com>
2154
2155         * python/python.c (do_start_initialization): Call PyEval_SaveThread
2156         instead of PyEval_ReleaseLock.
2157         (class gdbpy_gil): Move to earlier in file.
2158         (finalize_python): Set gdb_python_initialized.
2159         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
2160         when not initialized.
2161
2162 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
2163
2164         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2165         <push_dwarf_reg_entry_value>: Remove assert.  Override
2166         per_objfile with caller_per_objfile.
2167
2168 2020-05-28  Tom de Vries  <tdevries@suse.de>
2169
2170         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
2171         PR gold/15646 workaround to symbol kind "type".
2172
2173 2020-05-27  Tom Tromey  <tromey@adacore.com>
2174
2175         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
2176
2177 2020-05-27  Tom Tromey  <tromey@adacore.com>
2178
2179         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
2180         Use htab_find_with_hash.
2181         <add_abbrev>: Remove "abbrev_number" parameter.
2182         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
2183         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
2184         (hash_abbrev): Add comment.
2185         (abbrev_table::lookup_abbrev): Move to header file.
2186         (abbrev_table::read): Update.
2187
2188 2020-05-27  Tom Tromey  <tromey@adacore.com>
2189
2190         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
2191         method.
2192         <canonical_name>: New member.
2193         <raw_name>: Rename from "name".
2194         (partial_die_info): Initialize canonical_name.
2195         (scan_partial_symbols): Check raw_name.
2196         (partial_die_parent_scope, partial_die_full_name)
2197         (add_partial_symbol, add_partial_subprogram)
2198         (add_partial_enumeration, load_partial_dies): Use "name" method.
2199         (partial_die_info::name): New method.
2200         (partial_die_info::read, guess_partial_die_structure_name)
2201         (partial_die_info::fixup): Update.
2202
2203 2020-05-27  Tom Tromey  <tromey@adacore.com>
2204
2205         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
2206         <get_ref_die_offset>: Inline.
2207         <get_ref_die_offset_complaint>: New method.
2208         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
2209         (attribute::get_ref_die_offset_complaint): Rename from
2210         get_ref_die_offset.  Just issue complaint.
2211
2212 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2213
2214         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
2215
2216 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2217
2218         * exec.c (exec_file_attach): Use errno value of first openp failure.
2219
2220 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2221
2222         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
2223         Don't close thread handle.
2224
2225 2020-05-27  Tom Tromey  <tom@tromey.com>
2226             Simon Marchi  <simon.marchi@efficios.com>
2227
2228         * objfiles.h (struct objfile) <partial_symtabs>: Now a
2229         shared_ptr.
2230         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
2231         member.
2232         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
2233         dwarf2_per_bfd_objfile_data_key>: New globals.
2234         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
2235         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
2236         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
2237         shared.
2238         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
2239         short-circuit when sharing.
2240         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
2241         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
2242
2243 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2244
2245         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
2246         to...
2247         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
2248         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
2249
2250 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2251
2252         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
2253         build_name_components, find_name_components_bounds>:
2254         Add per_objfile parameter.
2255         (struct mapped_index) <symbol_name_at>: Likewise.
2256         (struct mapped_debug_names): Remove constructor.
2257         <dwarf2_per_objfile>: Remove field.
2258         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
2259         (mapped_index_base::find_name_components_bounds,
2260         mapped_index_base::build_name_components,
2261         dw2_expand_symtabs_matching_symbol): Likewise.
2262         (class mock_mapped_index) <symbol_name_at>: Likewise.
2263         (check_match): Likewise.
2264         (check_find_bounds_finds): Likewise.
2265         (test_mapped_index_find_name_component_bounds): Update.
2266         (CHECK_MATCH): Update.
2267         (dw2_expand_symtabs_matching): Update.
2268         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
2269         per_objfile parameter.
2270         <find_vec_in_debug_names>: Likewise.
2271         <m_per_objfile>: New field.
2272         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
2273         parameter.
2274         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
2275         (dw2_debug_names_iterator::next): Update.
2276         (dw2_debug_names_lookup_symbol): Update.
2277         (dw2_debug_names_expand_symtabs_for_function): Update.
2278         (dw2_debug_names_map_matching_symbols): Update.
2279         (dw2_debug_names_expand_symtabs_matching): Update.
2280         (dwarf2_read_debug_names): Update.
2281
2282 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2283
2284         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
2285         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
2286         move to dwarf2_per_objfile.
2287         <read_in_chain>: Remove.
2288         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
2289         remove_all_cus, age_comp_units>: New methods.
2290         <m_dwarf2_cus>: New member.
2291         (struct dwarf2_per_cu_data) <cu>: Remove.
2292         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
2293         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
2294         moved to methods of dwarf2_per_objfile.
2295         (dwarf2_clear_marks): Remove.
2296         (dwarf2_queue_item::~dwarf2_queue_item): Update.
2297         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
2298         (dwarf2_per_bfd::free_cached_comp_units): Remove.
2299         (dwarf2_per_objfile::remove_all_cus): New.
2300         (class free_cached_comp_units) <~free_cached_comp_units>:
2301         Update.
2302         (load_cu): Update.
2303         (dw2_do_instantiate_symtab): Adjust.
2304         (fill_in_sig_entry_from_dwo_entry): Adjust.
2305         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2306         (cutu_reader::cutu_reader): Likewise.
2307         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
2308         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
2309         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
2310         and dwarf2_per_objfile::age_comp_units.
2311         (load_partial_comp_unit): Update.
2312         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
2313         (process_queue): Likewise.
2314         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
2315         backlink.
2316         (dwarf2_read_addr_index): Likewise.
2317         (follow_die_offset): Likewise.
2318         (dwarf2_fetch_die_loc_sect_off): Likewise.
2319         (dwarf2_fetch_constant_bytes): Likewise.
2320         (dwarf2_fetch_die_type_sect_off): Likewise.
2321         (follow_die_sig_1): Likewise.
2322         (load_full_type_unit): Likewise.
2323         (read_signatured_type): Likewise.
2324         (dwarf2_cu::dwarf2_cu): Don't set cu field.
2325         (dwarf2_cu::~dwarf2_cu): Remove.
2326         (dwarf2_per_objfile::get_cu): New.
2327         (dwarf2_per_objfile::set_cu): New.
2328         (age_cached_comp_units): Rename to...
2329         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
2330         to std::unordered_map.
2331         (free_one_cached_comp_unit): Rename to...
2332         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
2333         to std::unordered_map.
2334         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
2335         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
2336         a dwarf2_per_objfile in data.
2337         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
2338         (dwarf2_clear_marks): Remove.
2339
2340 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2341
2342         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
2343         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
2344         (init_tu_and_read_dwo_dies): Likewise.
2345         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
2346         (cutu_reader::cutu_reader): Likewise.
2347         (load_partial_comp_unit): Likewise.
2348         (process_psymtab_comp_unit): Update.
2349         (build_type_psymtabs_1): Update.
2350         (process_skeletonless_type_unit): Update.
2351         (load_full_comp_unit): Update.
2352         (find_partial_die): Update.
2353         (dwarf2_read_addr_index): Update.
2354         (read_signatured_type): Update.
2355
2356 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2357
2358         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
2359         m_header_read_in>: New fields.
2360         <get_header>: New method.
2361         * dwarf2/read.c (per_cu_header_read_in): Remove.
2362         (dwarf2_per_cu_data::get_header): New.
2363         (dwarf2_per_cu_data::addr_size): Update.
2364         (dwarf2_per_cu_data::offset_size): Update.
2365         (dwarf2_per_cu_data::ref_addr_size): Update.
2366
2367 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2368
2369         * dwarf2/read.c (load_cu): Return dwarf2_cu.
2370         (dw2_do_instantiate_symtab): Update.
2371         (queue_and_load_all_dwo_tus): Change parameter from
2372         dwarf2_per_cu_data to dwarf2_cu.
2373         (dwarf2_fetch_die_loc_sect_off): Update.
2374         (dwarf2_fetch_constant_bytes): Update.
2375         (dwarf2_fetch_die_type_sect_off): Update.
2376
2377 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2378
2379         * dwarf2/read.c (process_full_comp_unit,
2380         process_full_type_unit): Remove per_cu, per_objfile paramters.
2381         Add dwarf2_cu parameter.
2382         (process_queue): Update.
2383
2384 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2385
2386         * dwarf2/read.c (create_cu_from_index_list): Replace
2387         dwarf2_per_objfile parameter with dwarf2_per_bfd.
2388         (create_cus_from_index_list): Likewise.
2389         (create_cus_from_index): Likewise.
2390         (create_signatured_type_table_from_index): Likewise.
2391         (create_cus_from_debug_names_list): Likewise.
2392         (create_cus_from_debug_names): Likewise.
2393         (dwarf2_read_gdb_index): Update.
2394         (dwarf2_read_debug_names): Update.
2395
2396 2020-05-27  Tom Tromey  <tom@tromey.com>
2397             Simon Marchi  <simon.marchi@efficios.com>
2398
2399         * dwarf2/read.h (struct dwarf2_per_objfile)
2400         <get_type_for_signatured_type, set_type_for_signatured_type>:
2401         New methods.
2402         <m_type_map>: New member.
2403         (struct signatured_type) <type>: Remove.
2404         * dwarf2/read.c
2405         (dwarf2_per_objfile::get_type_for_signatured_type,
2406         dwarf2_per_objfile::set_type_for_signatured_type): New.
2407         (get_signatured_type): Use new methods.
2408
2409 2020-05-27  Tom Tromey  <tom@tromey.com>
2410             Simon Marchi  <simon.marchi@efficios.com>
2411
2412         * dwarf2/read.h (struct type_unit_group_unshareable): New.
2413         (struct dwarf2_per_objfile) <type_units>: New member.
2414         <get_type_unit_group_unshareable>: New method.
2415         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
2416         num_symtabs, symtabs>: Remove; move to
2417         type_unit_group_unshareable.
2418         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
2419         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
2420         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
2421
2422 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2423
2424         * dwarf2/read.h (struct dwarf2_per_cu_data):
2425         <dwarf2_per_objfile>: Remove.
2426         * dwarf2/read.c (create_cu_from_index_list): Don't assign
2427         dwarf2_per_objfile.
2428         (create_signatured_type_table_from_index): Likewise.
2429         (create_signatured_type_table_from_debug_names): Likewise.
2430         (create_debug_type_hash_table): Likewise.
2431         (fill_in_sig_entry_from_dwo_entry): Likewise.
2432         (create_type_unit_group): Likewise.
2433         (read_comp_units_from_section): Likewise.
2434         (create_cus_hash_table): Likewise.
2435
2436 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2437
2438         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
2439         dwarf2_per_cu_data::dwarf2_per_objfile.
2440         (compute_compunit_symtab_includes): Likewise.
2441         (dwarf2_cu::start_symtab): Likewise.
2442
2443 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2444
2445         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
2446         parameter.
2447         * dwarf2/read.c (get_die_type_at_offset): Likewise.
2448         (read_namespace_alias): Update.
2449         (lookup_die_type): Update.
2450         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
2451         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
2452         Update.
2453         (disassemble_dwarf_expression): Update.
2454
2455 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2456
2457         * dwarf2/read.h (struct dwarf2_queue_item): Add
2458         dwarf2_per_objfile parameter, assign new parameter.
2459         <per_objfile>: New field.
2460         * dwarf2/read.c (free_one_cached_comp_unit): Add
2461         dwarf2_per_objfile parameter.
2462         (queue_comp_unit): Likewise.
2463         (dw2_do_instantiate_symtab): Update.
2464         (process_psymtab_comp_unit): Update.
2465         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
2466         (process_imported_unit_die): Update.
2467         (queue_and_load_dwo_tu): Update.
2468         (follow_die_offset): Update.
2469         (follow_die_sig_1): Update.
2470
2471 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2472
2473         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
2474         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
2475         (read_call_site_scope): Assign per_objfile.
2476         (dwarf2_per_cu_data::objfile): Remove.
2477         * gdbtypes.h (struct call_site) <per_objfile>: New member.
2478         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
2479         dwarf2_per_objfile parameter.
2480         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
2481         dwarf2_per_objfile parameter.
2482         (dwarf_expr_reg_to_entry_parameter): Add output
2483         dwarf2_per_objfile parameter.
2484         (locexpr_get_frame_base): Update.
2485         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
2486         <push_dwarf_reg_entry_value>: Update.
2487         <call_site_to_target_addr>: Update.
2488         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
2489         parameter.
2490         (value_of_dwarf_reg_entry): Update.
2491         (rw_pieced_value): Update.
2492         (indirect_synthetic_pointer): Update.
2493         (dwarf2_evaluate_property): Update.
2494         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
2495         parameter.
2496         (locexpr_read_variable): Update.
2497         (locexpr_get_symbol_read_needs): Update.
2498         (loclist_read_variable): Update.
2499
2500 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2501
2502         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2503         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2504         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2505         parameter.
2506         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2507         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2508         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2509         parameter.
2510         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
2511         sect_variable_value): Add dwarf2_per_objfile parameter.
2512         (class dwarf_evaluate_loc_desc) <dwarf_call,
2513         dwarf_variable_value>: Update.
2514         (fetch_const_value_from_synthetic_pointer): Add
2515         dwarf2_per_objfile parameter.
2516         (fetch_const_value_from_synthetic_pointer): Update.
2517         (coerced_pieced_ref): Update.
2518         (class symbol_needs_eval_context) <dwarf_call,
2519         dwarf_variable_value>: Update.
2520         (dwarf2_compile_expr_to_ax): Update.
2521
2522 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2523
2524         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
2525         parameter.
2526         (dwarf2_evaluate_loc_desc_full): Update.
2527
2528 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2529
2530         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
2531         parameter.
2532         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
2533         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
2534         dwarf2_per_objfile parameter.
2535         (decode_debug_loc_dwo_addresses): Likewise.
2536         (dwarf2_find_location_expression): Update.
2537         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
2538         (locexpr_describe_location_piece): Add dwarf2_per_objfile
2539         parameter.
2540         (disassemble_dwarf_expression): Add dwarf2_per_objfile
2541         parameter.
2542         (locexpr_describe_location_1): Likewise.
2543         (locexpr_describe_location): Update.
2544
2545 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2546
2547         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
2548         Remove.
2549         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
2550         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
2551         (dwarf2_compile_property_to_c): Update.
2552         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
2553         use text offset from objfile.
2554         (locexpr_tracepoint_var_ref): Update.
2555         (locexpr_generate_c_location): Update.
2556         (loclist_describe_location): Update.
2557         (loclist_tracepoint_var_ref): Update.
2558         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
2559         dwarf2_per_objfile parameter.
2560         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
2561         use text offset from objfile.
2562         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
2563
2564 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2565
2566         * dwarf2/expr.h (struct dwarf_expr_context)
2567         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
2568         <offset>: Remove.
2569         <per_objfile>: New member.
2570         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
2571         dwarf2_per_objfile parameter.  Don't set offset, set
2572         per_objfile.
2573         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
2574         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
2575         a dwarf2_per_objfile object instead of an offset.
2576         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
2577         constructor.
2578         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
2579         to dwarf2_expr_executor constructor.  Don't set offset.
2580         (dwarf2_fetch_cfa_info): Update.
2581         (struct dwarf2_frame_cache) <text_offset>: Remove.
2582         <per_objfile>: New field.
2583         (dwarf2_frame_cache): Update.
2584         (dwarf2_frame_prev_register): Update.
2585         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2586         <dwarf_evaluate_loc_desc>: Add constructor.
2587         (dwarf2_evaluate_loc_desc_full): Update.
2588         (dwarf2_locexpr_baton_eval): Update.
2589         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
2590         Add constructor.
2591         (dwarf2_loc_desc_get_symbol_read_needs): Update.
2592
2593 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2594
2595         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
2596         addr_sized_int_type>: Move to dwarf2_cu.
2597         <int_type>: Move to dwarf2_per_objfile.
2598         (struct dwarf2_per_objfile) <int_type>: Move here.
2599         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
2600         addr_sized_int_type>: Move here.
2601         (read_func_scope): Update.
2602         (read_array_type): Update.
2603         (read_tag_string_type): Update.
2604         (attr_to_dynamic_prop): Update.
2605         (dwarf2_per_cu_data::int_type): Rename to...
2606         (dwarf2_per_objfile::int_type): ... this.
2607         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
2608         (dwarf2_cu::addr_sized_int_type): ... this.
2609         (read_subrange_type): Update.
2610         (dwarf2_per_cu_data::addr_type): Rename to...
2611         (dwarf2_cu::addr_type): ... this.
2612         (set_die_type): Update.
2613
2614 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2615
2616         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
2617         data through per_cu->cu.
2618
2619 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2620
2621         * dwarf2/read.c (lookup_dwo_comp_unit): Change
2622         dwarf2_per_cu_data parameter fo dwarf2_cu.
2623         (lookup_dwo_type_unit): Likewise.
2624         (read_cutu_die_from_dwo): Likewise.
2625         (lookup_dwo_unit): Likewise.
2626         (open_and_init_dwo_file): Likewise.
2627         (lookup_dwo_cutu): Likewise.
2628         (lookup_dwo_comp_unit): Likewise.
2629         (lookup_dwo_type_unit): Likewise.
2630         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2631         (cutu_reader::cutu_reader): Update.
2632
2633 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2634
2635         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
2636         parameter.
2637         (process_full_type_unit): Likewise.
2638         (process_queue): Update.
2639
2640 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2641
2642         * dwarf2/read.c (recursively_compute_inclusions): Add
2643         dwarf2_per_objfile parameter.
2644         (compute_compunit_symtab_includes): Likewise.
2645         (process_cu_includes): Update.
2646
2647 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2648
2649         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
2650         parameter.
2651         (create_type_unit_group): Update.
2652         (process_psymtab_comp_unit_reader): Update.
2653         (build_type_psymtabs_reader): Update.
2654
2655 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2656
2657         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
2658         object through m_this_cu->cu.
2659
2660 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2661
2662         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
2663         the info parameter.
2664         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
2665
2666 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2667
2668         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
2669         per_objfile parameter.
2670         (load_full_type_unit): Add per_objfile parameter.
2671         (read_signatured_type): Likewise.
2672         (load_full_comp_unit): Likewise.
2673         (load_cu): Likewise.
2674         (dw2_do_instantiate_symtab): Likewise.
2675         (dw2_get_file_names): Likewise.
2676         (dw2_map_symtabs_matching_filename): Update.
2677         (dw_expand_symtabs_matching_file_matcher): Update.
2678         (dw2_map_symbol_filenames): Update.
2679         (process_psymtab_comp_unit): Add per_objfile parameter.
2680         (build_type_psymtabs_1): Update.
2681         (process_skeletonless_type_unit): Update.
2682         (dwarf2_build_psymtabs_hard): Update.
2683         (load_partial_comp_unit): Add per_objfile parameter.
2684         (scan_partial_symbols): Update.
2685         (load_full_comp_unit): Add per_objfile parameter.
2686         (process_imported_unit_die): Update.
2687         (create_cus_hash_table): Update.
2688         (find_partial_die): Update.
2689         (dwarf2_read_addr_index): Update.
2690         (follow_die_offset): Update.
2691         (dwarf2_fetch_die_loc_sect_off): Update.
2692         (dwarf2_fetch_constant_bytes): Update.
2693         (dwarf2_fetch_die_type_sect_off): Update.
2694         (follow_die_sig_1): Update.
2695         (load_full_type_unit): Add per_objfile parameter.
2696         (read_signatured_type): Likewise.
2697
2698 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2699
2700         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
2701         of objfile_name.
2702
2703 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2704
2705         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
2706         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2707         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
2708         field.
2709         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2710         (create_cus_from_index): Update.
2711         (dwarf2_read_gdb_index): Update.
2712         (create_cus_from_debug_names): Update.
2713         (dwarf2_read_debug_names): Update.
2714         (get_abbrev_section_for_cu): Update.
2715         (create_all_comp_units): Update.
2716         (read_attribute_value): Update.
2717         (get_debug_line_section): Update.
2718         * dwarf2/index-cache.c (index_cache::store): Update.
2719         * dwarf2/index-write.c (save_gdb_index_command): Update.
2720         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
2721
2722 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2723
2724         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
2725         member.
2726         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
2727         dwarf2_per_cu_data::per_bfd.
2728         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
2729         (create_type_unit_group): Likewise.
2730         (queue_comp_unit): Remove reference to
2731         per_cu->dwarf2_per_objfile.
2732         (maybe_queue_comp_unit): Likewise.
2733         (fill_in_sig_entry_from_dwo_entry): Assign new field.
2734         (create_cus_hash_table): Assign new field.
2735
2736 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2737
2738         * dwarf2/read.c: Replace
2739         dwarf2_cu->per_cu->dwarf2_per_objfile references with
2740         dwarf2_cu->per_objfile throughout.
2741
2742 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2743
2744         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
2745         parameter, don't use per_cu->dwarf2_per_objfile.
2746         (dw2_instantiate_symtab): Likewise.
2747         (dw2_find_last_source_symtab): Update.
2748         (dw2_map_expand_apply): Update.
2749         (dw2_lookup_symbol): Update.
2750         (dw2_expand_symtabs_for_function): Update.
2751         (dw2_expand_all_symtabs): Update.
2752         (dw2_expand_symtabs_with_fullname): Update.
2753         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
2754         don't use per_cu->dwarf2_per_objfile.
2755         (dw2_expand_marked_cus): Update.
2756         (dw2_find_pc_sect_compunit_symtab): Update.
2757         (dw2_debug_names_lookup_symbol): Update.
2758         (dw2_debug_names_expand_symtabs_for_function): Update.
2759         (dw2_debug_names_map_matching_symbols): Update.
2760         (dwarf2_psymtab::expand_psymtab): Update.
2761
2762 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2763
2764         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
2765         <per_objfile>: New member.
2766         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
2767         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
2768         call to dwarf2_cu.
2769         (cutu_reader::cutu_reader): Update.
2770         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
2771
2772 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2773
2774         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
2775         struct dwarf2_per_objfile.
2776         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
2777         dwarf2_per_bfd.
2778         * dwarf2/read.c (set_die_type): Update.
2779         (get_die_type_at_offset): Update.
2780
2781 2020-05-27  Tom Tromey  <tom@tromey.com>
2782             Simon Marchi  <simon.marchi@efficios.com>
2783
2784         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
2785         method.
2786         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
2787         get_symtab, set_symtab>: New methods.
2788         <m_symtabs>: New field.
2789         (struct dwarf2_psymtab): Derive from partial_symtab.
2790         <readin_p, get_compunit_symtab>: Declare methods.
2791         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
2792         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
2793         New methods.
2794         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
2795         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
2796         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
2797         (dw2_symtab_iter_next, dw2_print_stats)
2798         (dw2_expand_symtabs_with_fullname)
2799         (dw2_expand_symtabs_matching_one)
2800         (dw_expand_symtabs_matching_file_matcher)
2801         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
2802         (dw2_debug_names_iterator::next)
2803         (dw2_debug_names_map_matching_symbols)
2804         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
2805         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
2806         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
2807         New methods.
2808         (get_compunit_symtab, process_full_comp_unit)
2809         (process_full_type_unit): Update.
2810         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
2811
2812 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2813
2814         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
2815         then introduce a new dwarf2_per_objfile type.
2816         <read_line_string>: Move to the new dwarf2_per_objfile type.
2817         <objfile>: Likewise.
2818         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
2819         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
2820         dwarf2_per_objfile->per_bfd.
2821         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
2822         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
2823         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
2824         (dwarf2_per_bfd::free_cached_comp_units): ... this.
2825         (dwarf2_has_info): Allocate dwarf2_per_bfd.
2826         (dwarf2_per_objfile::locate_sections): Rename to...
2827         (dwarf2_per_bfd::locate_sections): ... this.
2828         (dwarf2_per_objfile::get_cutu): Rename to...
2829         (dwarf2_per_bfd::get_cutu): ... this.
2830         (dwarf2_per_objfile::get_cu): Rename to...
2831         (dwarf2_per_bfd::get_cu): ... this.
2832         (dwarf2_per_objfile::get_tu): Rename to...
2833         (dwarf2_per_bfd::get_tu): ... this.
2834         (dwarf2_per_objfile::allocate_per_cu): Rename to...
2835         (dwarf2_per_bfd::allocate_per_cu): ... this.
2836         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
2837         (dwarf2_per_bfd::allocate_signatured_type): ... this.
2838         (get_gdb_index_contents_ftype): Change parameter from
2839         dwarf2_per_objfile to dwarf2_per_bfd.
2840         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
2841         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
2842
2843 2020-05-27  Tom Tromey  <tom@tromey.com>
2844             Simon Marchi  <simon.marchi@efficios.com>
2845
2846         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
2847         (allocate_piece_closure): Set "per_objfile" member.
2848         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
2849         (locexpr_describe_location, loclist_describe_location): Use new
2850         member.
2851         * dwarf2/read.c (read_call_site_scope)
2852         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
2853         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
2854         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
2855         handle_data_member_location): Set per_objfile member.
2856         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
2857         member.
2858         (struct dwarf2_loclist_baton) <per_objfile>: New member.
2859
2860 2020-05-27  Tom Tromey  <tom@tromey.com>
2861
2862         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
2863         allocate_signatured_type>: Declare new methods.
2864         <m_num_psymtabs>: New member.
2865         (struct dwarf2_per_cu_data) <index>: New member.
2866         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
2867         (dwarf2_per_objfile::allocate_signatured_type): New methods.
2868         (create_cu_from_index_list): Use allocate_per_cu.
2869         (create_signatured_type_table_from_index)
2870         (create_signatured_type_table_from_debug_names)
2871         (create_debug_type_hash_table, add_type_unit)
2872         (read_comp_units_from_section): Use allocate_signatured_type.
2873
2874 2020-05-27  Tom Tromey  <tom@tromey.com>
2875
2876         * psymtab.c (partial_map_expand_apply)
2877         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2878         (psym_lookup_global_symbol_language)
2879         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2880         (psym_print_stats, psym_expand_symtabs_for_function)
2881         (psym_map_symbol_filenames, psym_map_matching_symbols)
2882         (psym_expand_symtabs_matching)
2883         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2884         (maintenance_check_psymtabs): Update.
2885         * psympriv.h (struct partial_symtab) <readin_p,
2886         get_compunit_symtab>: Add objfile parameter.
2887         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
2888         Likewise.
2889         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
2890         get_compunit_symtab>: Likewise.
2891         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
2892
2893 2020-05-27  Tom Tromey  <tom@tromey.com>
2894
2895         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
2896         member.
2897         * dwarf2/read.c (delete_file_name_entry): Fix comment.
2898         (create_cu_from_index_list)
2899         (create_signatured_type_table_from_index)
2900         (create_signatured_type_table_from_debug_names)
2901         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
2902         (dwarf2_create_include_psymtab)
2903         (create_debug_type_hash_table, add_type_unit)
2904         (create_type_unit_group, read_comp_units_from_section)
2905         (dwarf2_compute_name, create_cus_hash_table)
2906         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2907         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
2908         obstack.
2909         (dw2_get_real_path): Likewise.  Change argument to
2910         dwarf2_per_objfile.
2911
2912 2020-05-27  Luis Machado  <luis.machado@linaro.org>
2913
2914         PR tdep/26000
2915         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
2916         for ldrd (immediate).
2917
2918 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2919
2920         * command.h: Add comment giving the name of class_tui.
2921         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
2922         create the fake command for the help for class_tui.
2923
2924 2020-05-26  Tom Tromey  <tromey@adacore.com>
2925
2926         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
2927         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2928         (val_atr): New function.
2929         (value_val_atr): Use it.
2930         * ada-valprint.c (print_optional_low_bound): Change low bound
2931         handling for enums.
2932         (val_print_packed_array_elements): Don't call discrete_position.
2933         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2934         discrete_position for enum types.
2935         * language.c (default_print_array_index): Change type.
2936         * language.h (struct language_defn) <la_print_array_index>: Add
2937         index_type parameter, change type of index_value.
2938         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2939         (default_print_array_index): Update.
2940         * valprint.c (maybe_print_array_index): Don't call
2941         value_from_longest.  Update.
2942         (value_print_array_elements): Don't call discrete_position.
2943
2944 2020-05-26  Tom Tromey  <tromey@adacore.com>
2945
2946         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2947         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2948
2949 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2950
2951         PR gdb/13519
2952         * avr-tdep.c (avr_integer_to_address): Return data or code
2953         address accordingly to the second 'type' argument of the
2954         function.
2955
2956 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2957
2958         * infcmd.c, inferior.h: (construct_inferior_arguments):
2959         Moved function from here to gdbsupport/common-inferior.{h,cc}
2960
2961 2020-05-23  Tom Tromey  <tom@tromey.com>
2962
2963         Revert commit eca1f90c:
2964         * NEWS: Remove entry for completion styling.
2965         * completer.c (_rl_completion_prefix_display_length): Move
2966         declaration later.
2967         (gdb_fnprint): Revert.
2968         (gdb_display_match_list_1): Likewise.
2969         * cli/cli-style.c (completion_prefix_style)
2970         (completion_difference_style, completion_suffix_style): Remove.
2971         (_initialize_cli_style): Revert.
2972         * cli/cli-style.h (completion_prefix_style)
2973         (completion_difference_style, completion_suffix_style): Don't
2974         declare.
2975
2976 2020-05-24  Pedro Alves  <palves@redhat.com>
2977
2978         * symtab.c (completion_list_add_name): Return boolean indication
2979         of whether the symbol matched.
2980         (completion_list_add_symbol): Don't try to remove C++ aliases if
2981         the symbol didn't match in the first place.
2982         * symtab.h (completion_list_add_name): Return bool.
2983
2984 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2985
2986         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2987         type::field.
2988
2989 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2990
2991         GDB 9.2 released.
2992
2993 2020-05-23  Tom Tromey  <tom@tromey.com>
2994
2995         * NEWS: Add entry for completion styling.
2996         * completer.c (_rl_completion_prefix_display_length): Move
2997         declaration earlier.
2998         (gdb_fnprint): Use completion_style.
2999         (gdb_display_match_list_1): Likewise.
3000         * cli/cli-style.c (completion_prefix_style)
3001         (completion_difference_style, completion_suffix_style): New
3002         globals.
3003         (_initialize_cli_style): Register new globals.
3004         * cli/cli-style.h (completion_prefix_style)
3005         (completion_difference_style, completion_suffix_style): Declare.
3006
3007 2020-05-23  Pedro Alves  <palves@redhat.com>
3008
3009         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
3010         (parse_escape): Use ISDIGIT instead of isdigit.
3011         (puts_debug): Use gdb_isprint instead of isprint.
3012         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
3013         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
3014         ISSPACE instead of isspace.
3015         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
3016         instead of isspace.
3017         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
3018         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
3019         instead of isxdigit and ISDIGIT instead of isdigit.
3020
3021 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3022
3023         * gdbtypes.h (struct type) <field>: New method.
3024         (TYPE_FIELDS): Remove, replace all uses with either type::fields
3025         or type::field.
3026
3027 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3028
3029         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
3030         (TYPE_FIELDS): Use type::fields.  Change all call sites that
3031         modify the propery to use type::set_fields instead.
3032
3033 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3034
3035         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
3036         type::num_fields instead.
3037
3038 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3039
3040         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
3041         methods.
3042         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
3043         that modify the number of fields to use type::set_num_fields
3044         instead.
3045
3046 2020-05-22  Tom Tromey  <tromey@adacore.com>
3047
3048         * compile/compile-object-load.h (munmap_list_free): Don't
3049         declare.
3050
3051 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * annotate.c (annotate_source_line): Update return type, add call
3054         to update current symtab and line.
3055         * annotate.h (annotate_source_line): Update return type, and
3056         extend header comment.
3057         * source.c (info_line_command): Check annotation_level before
3058         calling annotate_source_line.
3059         * stack.c (print_frame_info): If calling annotate_source_line
3060         returns true, then don't print any other source line information.
3061
3062 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3063
3064         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
3065
3066 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3067
3068         * coffread.c (patch_type): Remove NULL check before xfree.
3069         * corefile.c (set_gnutarget): Likewise.
3070         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
3071         * exec.c (build_section_table): Likewise.
3072         * remote.c (remote_target::pass_signals): Likewise.
3073         * utils.c (n_spaces): Likewise.
3074         * cli/cli-script.c (document_command): Likewise.
3075         * i386-windows-tdep.c (core_process_module_section): Likewise.
3076         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
3077
3078 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
3079
3080         * symfile.c (reread_symbols): Clear objfile's section_offsets
3081         vector and section indices, re-compute them by calling
3082         sym_offsets.
3083
3084 2020-05-20  Tom Tromey  <tromey@adacore.com>
3085
3086         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
3087         (desc_one_bound, desc_index_type): Compute field name.
3088
3089 2020-05-20  Tom de Vries  <tdevries@suse.de>
3090
3091         PR symtab/25833
3092         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
3093
3094 2020-05-20  Alan Modra  <amodra@gmail.com>
3095
3096         PR 25993
3097         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
3098         bfd_set_filename.
3099         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
3100         passed to bfd_set_filename.
3101         * symfile-mem.c (add_vsyscall_page): Likewise for string
3102         passed to symbol_file_add_from_memory.
3103         (symbol_file_add_from_memory): Make name param a const char* and
3104         don't strdup.
3105
3106 2020-05-20  Alan Modra  <amodra@gmail.com>
3107
3108         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
3109         rather than accessing bfd->filename directly.
3110         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
3111         and use bfd_section_name.
3112         * dwarf2/frame.c (decode_frame_entry): Likewise.
3113         * exec.c (exec_set_section_address): Likewise.
3114         * solib-aix.c (solib_aix_bfd_open): Likewise.
3115         * stap-probe.c (get_stap_base_address): Likewise.
3116         * symfile.c (reread_symbols): Likewise.
3117
3118 2020-05-19  Tom Tromey  <tromey@adacore.com>
3119
3120         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
3121
3122 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3123
3124         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
3125
3126 2020-05-19  Pedro Alves  <palves@redhat.com>
3127
3128         * NEWS (set exec-file-mismatch): Adjust entry.
3129         * exec.c: Include "build-id.h".
3130         (validate_exec_file): Try to match build IDs instead of filenames.
3131         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
3132         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
3133         and pass down 'warn_if_slow'.
3134         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
3135         gdb_bfd_open_closure to pass it down.
3136         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
3137
3138 2020-05-19  Pedro Alves  <palves@redhat.com>
3139
3140         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
3141         * target.c (target_fileio_open_1): Rename to target_fileio_open
3142         and make extern.  Use bool.
3143         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
3144         (target_fileio_read_alloc_1): Adjust.
3145         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
3146         (target_fileio_open_warn_if_slow): Delete declaration.
3147
3148 2020-05-19  Pedro Alves  <palves@redhat.com>
3149
3150         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
3151         Adjust all callers.
3152
3153 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
3154
3155         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
3156         whether disp is negative.
3157
3158 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3159
3160         * symfile.h (struct symfile_segment_data)
3161         <~symfile_segment_data>: Remove.
3162         <segment_info>: Change to std::vector.
3163         * symfile.c (default_symfile_segments): Update.
3164         * elfread.c (elf_symfile_segments): Update.
3165
3166 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3167
3168         * symfile.h (struct symfile_segment_data) <struct segment>: New.
3169         <segments>: New.
3170         <segment_bases, segment_sizes>: Remove.
3171         * symfile.c (default_symfile_segments): Update.
3172         * elfread.c (elf_symfile_segments): Update.
3173         * remote.c (remote_target::get_offsets): Update.
3174         * solib-target.c (solib_target_relocate_section_addresses):
3175         Update.
3176
3177 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3178
3179         * symfile.h (struct symfile_segment_data): Initialize fields.
3180         <~symfile_segment_data>: Add.
3181         (symfile_segment_data_up): New.
3182         (struct sym_fns) <sym_segments>: Return a
3183         symfile_segment_data_up.
3184         (default_symfile_segments): Return a symfile_segment_data_up.
3185         (free_symfile_segment_data): Remove.
3186         (get_symfile_segment_data): Return a symfile_segment_data_up.
3187         * symfile.c (default_symfile_segments): Likewise.
3188         (get_symfile_segment_data): Likewise.
3189         (free_symfile_segment_data): Remove.
3190         (symfile_find_segment_sections): Update.
3191         * elfread.c (elf_symfile_segments): Return a
3192         symfile_segment_data_up.
3193         * remote.c (remote_target::get_offsets): Update.
3194         * solib-target.c (solib_target_relocate_section_addresses):
3195         Update.
3196         * symfile-debug.c (debug_sym_segments): Return a
3197         symfile_segment_data_up.
3198
3199 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3200
3201         PR build/25981
3202         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
3203         Hardcode register numbers.
3204
3205         PR build/25981
3206         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
3207         procfs_find_LDT_entry): Remove.
3208         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
3209         procfs_find_LDT_entry): Remove.
3210         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
3211         Remove.
3212
3213 2020-05-17  Pedro Alves  <palves@redhat.com>
3214             Andrew Burgess  <andrew.burgess@embecosm.com>
3215             Keno Fischer  <keno@juliacomputing.com>
3216
3217         PR gdb/25741
3218         * breakpoint.c (build_target_condition_list): Update comments.
3219         (build_target_command_list): Update comments and skip matching
3220         locations.
3221         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
3222         a separate function.  Simplify "set breakpoint auto-hw off"
3223         handling.
3224         (insert_breakpoints): Update comment.
3225         (tracepoint_locations_match): New parameter.  For breakpoints,
3226         compare location types too, if the caller wants to.
3227         (handle_automatic_hardware_breakpoints): New functions.
3228         (bp_location_is_less_than): Also sort by location type and
3229         hardware breakpoint length.
3230         (update_global_location_list): Handle "set breakpoint auto-hw on"
3231         here.
3232         (update_breakpoint_locations): Ask breakpoint_locations_match to
3233         ignore location types.
3234
3235 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3236
3237         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
3238         type::name instead.
3239
3240 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3241
3242         * gdbtypes.h (struct type) <name, set_name>: New methods.
3243         (TYPE_CODE): Use type::name.  Change all call sites used to set
3244         the name to use type::set_name instead.
3245
3246 2020-05-16  Tom Tromey  <tom@tromey.com>
3247
3248         * top.c (quit_force): Update.
3249         * infrun.c (handle_no_resumed): Update.
3250         * top.h (all_uis): New function.
3251         (ALL_UIS): Remove.
3252
3253 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3254
3255         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
3256
3257 2020-05-16  Pedro Alves  <palves@redhat.com>
3258
3259         * ia64-linux-nat.c
3260         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
3261         Declare method.
3262         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
3263
3264 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
3265
3266         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
3267         (sparc64_adi_info): Likewise.
3268
3269 2020-05-15  Tom Tromey  <tom@tromey.com>
3270
3271         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
3272         block_objfile.
3273         (lookup_objfile_from_block): Remove.
3274         (lookup_symbol_in_block, lookup_symbol_in_static_block)
3275         (lookup_global_symbol): Use block_objfile.
3276         * symtab.h (lookup_objfile_from_block): Don't declare.
3277         * printcmd.c (clear_dangling_display_expressions): Use
3278         block_objfile.
3279         * parse.c (operator_check_standard): Use block_objfile.
3280
3281 2020-05-15  Tom Tromey  <tom@tromey.com>
3282
3283         * language.c (language_alloc_type_symbol): Set
3284         SYMBOL_SECTION.
3285         * symtab.c (initialize_objfile_symbol): Remove.
3286         (allocate_symbol): Remove.
3287         (allocate_template_symbol): Remove.
3288         * dwarf2/read.c (fixup_go_packaging): Use "new".
3289         (new_symbol): Use "new".
3290         (read_variable): Don't call initialize_objfile_symbol.  Use
3291         "new".
3292         (read_func_scope): Use "new".
3293         * xcoffread.c (process_xcoff_symbol): Don't call
3294         initialize_objfile_symbol.
3295         (SYMBOL_DUP): Remove.
3296         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
3297         "new".
3298         * symtab.h (allocate_symbol, initialize_objfile_symbol)
3299         (allocate_template_symbol): Don't declare.
3300         (struct symbol): Add copy constructor.  Change defaults.
3301         * jit.c (finalize_symtab): Use "new".
3302         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
3303         Use "new".
3304         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
3305         (common_block_end): Use "new".
3306         * mdebugread.c (parse_symbol): Use "new".
3307         (new_symbol): Likewise.
3308
3309 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3310
3311         * NEWS: Mention changes to help and apropos.
3312
3313 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3314
3315         * command.h (enum command_class): Improve comments, document
3316         that class_alias is for user-defined aliases, give the class
3317         name for each class, remove unused class_xdb.
3318         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
3319         * breakpoint.c (_initialize_breakpoint): Replace class_alias
3320         by a precise class.
3321         * infcmd.c (_initialize_infcmd): Likewise.
3322         * reverse.c (_initialize_reverse): Likewise.
3323         * stack.c (_initialize_stack): Likewise.
3324         * symfile.c (_initialize_symfile): Likewise.
3325         * tracepoint.c (_initialize_tracepoint): Likewise.
3326
3327 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3328
3329         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
3330         when their aliased command is traversed.
3331         (help_cmd): Add fput_command_names_styled call to
3332         output command name and aliases when command has an alias.
3333
3334 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3335
3336         * cli/cli-decode.h (help_cmd_list): Remove declaration.
3337         * cli/cli-decode.c (help_cmd_list): Declare as static,
3338         remove prefix argument, use bool for recurse arg, rework to show the aliases of
3339         a command together with the command.
3340         (fput_command_name_styled, fput_command_names_styled): New functions.
3341         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
3342         fput_command_name_styled.
3343         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
3344         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
3345
3346 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3347
3348         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
3349         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
3350         * command.h (cmd_show_list): Likewise.
3351         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
3352         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
3353
3354 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3355
3356         * unittests/command-def-selftests.c (traverse_command_structure):
3357         Verify all commands of a list have the same prefix command and
3358         that only the top cmdlist commands have a null prefix.
3359
3360 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3361
3362         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
3363         as prefix, not one of its aliases.
3364         (set_cmd_prefix): Remove.
3365         (do_add_cmd): Centralize the setting of the prefix of a command, when
3366         command is defined after its full chain of prefix commands.
3367         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
3368         (add_setshow_cmd_full): Likewise.
3369         (update_prefix_field_of_prefixed_commands): New function.
3370         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
3371         update_prefix_field_of_prefixed_commands.
3372         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
3373         addresses of remote_set_cmdlist and remote_show_cmdlist given
3374         as argument, not the address of an argument.
3375         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
3376         * gdb/remote.c (_initialize_remote): Likewise.
3377
3378 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3379
3380         * cli/cli-cmds.c (alias_command): Check for an existing alias
3381         using lookup_cmd_composition, as valid_command_p is too strict
3382         and forbids aliases that are the prefix of an existing alias
3383         or command.
3384         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
3385         command is properly recognised as a valid command.
3386
3387 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3388
3389         * unittests/help-doc-selftests.c: Rename to
3390         unittests/command-def-selftests.c
3391         * unittests/command-def-selftests.c (help_doc_tests): Update some
3392         comments.
3393         (command_structure_tests, traverse_command_structure): New namespace
3394         and function.
3395         (command_structure_invariants_tests): New function.
3396         (_initialize_command_def_selftests) Renamed from
3397         _initialize_help_doc_selftests, register command_structure_invariants
3398         selftest.
3399
3400 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3401
3402         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
3403         an alias of 'show'.
3404
3405 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
3406
3407         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
3408         ada_is_fixed_point_type.  Update all callers.
3409         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
3410         all callers.
3411         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
3412         Update all callers.
3413         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
3414         print_fixed_point_type.  Update all callers.
3415         * ada-valprint.c (ada_value_print_num): Replace call to
3416         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
3417
3418 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
3419
3420         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
3421         processors.
3422         (cpu_supports_bts): Add CV_AMD case.
3423
3424 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
3425             Simon Marchi  <simon.marchi@efficios.com>
3426
3427         * infrun.c (stop_all_threads): Collect multiple wait events at
3428         each pass.
3429
3430 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3431
3432         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
3433         type::code instead.
3434
3435 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3436
3437         * gdbtypes.h (struct type) <code, set_code>: New methods.
3438         (TYPE_CODE): Use type::code.  Change all call sites used to set
3439         the code to use type::set_code instead.
3440
3441 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3442             Tom de Vries  <tdevries@suse.de>
3443             Pedro Alves  <palves@redhat.com>
3444
3445         PR threads/25478
3446         * infrun.c (stop_all_threads): Do NOT ignore
3447         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
3448         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
3449         received.
3450         (handle_no_resumed): Remove code handling a live inferior with no
3451         threads.
3452         * remote.c (has_single_non_exited_thread): New.
3453         (remote_target::update_thread_list): Do not delete a thread if is
3454         the last thread of the process.
3455         * thread.c (thread_select): Call delete_exited_threads instead of
3456         prune_threads.
3457
3458 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3459
3460         * infrun.c (stop_all_threads): Enable/disable thread events of all
3461         targets.  Move a debug message denoting the end of the function
3462         into the SCOPED_EXIT block.
3463
3464 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3465
3466         * process-stratum-target.h: Include <set>.
3467         (all_non_exited_process_targets, switch_to_target_no_thread): New
3468         function declarations.
3469         * process-stratum-target.c (all_non_exited_process_targets)
3470         (switch_to_target_no_thread): New function implementations.
3471
3472 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3473
3474         * infrun.c (handle_inferior_event): Extract out a piece of code
3475         into...
3476         (mark_non_executing_threads): ...this new function.
3477
3478 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3479
3480         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
3481         use.
3482
3483 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3484
3485         * regcache.c (regcache_read_pc_protected): New function
3486         implementation that returns 0 if the PC cannot read via
3487         'regcache_read_pc'.
3488         * infrun.c (proceed): Call 'regcache_read_pc_protected'
3489         instead of 'regcache_read_pc'.
3490         (keep_going_pass_signal): Ditto.
3491
3492 2020-05-13  Tom Tromey  <tromey@adacore.com>
3493
3494         * ada-lang.c (align_value): Remove.
3495         (ada_template_to_fixed_record_type_1): Use align_up.
3496
3497 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3498
3499         * async-event.c: Update the copyright year.
3500         * async-event.h: Update the copyright year.
3501
3502 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
3503
3504         * objfiles.h (is_addr_in_objfile,
3505         shared_objfile_contains_address_p): Return bool.
3506         * objfile.c (is_addr_in_objfile,
3507         shared_objfile_contains_address_p): Return bool.
3508
3509 2020-05-11  Tom Tromey  <tromey@adacore.com>
3510
3511         * cli/cli-cmds.c (info_command): Restore.
3512         (_initialize_cli_cmds): Use add_prefix_command for "info".
3513         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
3514
3515 2020-05-11  Tom Tromey  <tromey@adacore.com>
3516
3517         * ada-lang.c (ada_value_primitive_field): Now public.
3518         * ada-lang.h (ada_value_primitive_field): Declare.
3519         * ada-valprint.c (print_field_values): Use
3520         ada_value_primitive_field for wrapper fields.
3521
3522 2020-05-11  Tom de Vries  <tdevries@suse.de>
3523
3524         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
3525         MODULE_DOMAIN.
3526
3527 2020-05-11  Tom de Vries  <tdevries@suse.de>
3528
3529         PR symtab/25941
3530         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
3531         with length 0, if not gdb-produced.
3532         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
3533
3534 2020-05-09  Tom de Vries  <tdevries@suse.de>
3535
3536         PR gdb/25955
3537         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
3538         calculation.
3539
3540 2020-05-09  Tom Tromey  <tom@tromey.com>
3541
3542         * top.c (server_command): Now bool.
3543         * top.h (server_command): Now bool.
3544
3545 2020-05-08  Tom Tromey  <tromey@adacore.com>
3546
3547         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
3548         already being processed.
3549
3550 2020-05-08  Tom Tromey  <tom@tromey.com>
3551
3552         * printcmd.c (struct display) <next>: Remove.
3553         <display>: New constructor.
3554         <exp_string>: Now a std::string.
3555         <enabled_p>: Now a bool.
3556         (display_number): Move definition earlier.
3557         (displays): Rename from display_chain.  Now a std::vector.
3558         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
3559         (display_command): Update.
3560         (do_one_display, disable_display)
3561         (enable_disable_display_command, do_enable_disable_display):
3562         Update.
3563         (free_display): Remove.
3564         (clear_displays): Rewrite.
3565         (delete_display): Update.
3566         (map_display_numbers): Use function_view.  Remove "data"
3567         parameter.  Update.
3568         (do_delete_display): Remove.
3569         (undisplay_command): Update.
3570         (do_one_display, do_displays, disable_display)
3571         (info_display_command): Update.
3572         (do_enable_disable_display): Remove.
3573         (enable_disable_display_command)
3574         (clear_dangling_display_expressions): Update.
3575
3576 2020-05-08  Tom Tromey  <tom@tromey.com>
3577
3578         * symtab.c (set_symbol_cache_size)
3579         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
3580         (maintenance_print_symbol_cache_statistics): Update.
3581         * symmisc.c (print_symbol_bcache_statistics)
3582         (print_objfile_statistics, maintenance_print_objfiles)
3583         (maintenance_info_symtabs, maintenance_check_symtabs)
3584         (maintenance_expand_symtabs, maintenance_info_line_tables):
3585         Update.
3586         * symfile-debug.c (set_debug_symfile): Update.
3587         * source.c (forget_cached_source_info): Update.
3588         * python/python.c (gdbpy_progspaces): Update.
3589         * psymtab.c (maintenance_info_psymtabs): Update.
3590         * probe.c (parse_probes): Update.
3591         * linespec.c (iterate_over_all_matching_symtabs)
3592         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
3593         * guile/scm-progspace.c (gdbscm_progspaces): Update.
3594         * exec.c (exec_target::close): Update.
3595         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
3596         * breakpoint.c (print_one_breakpoint_location)
3597         (create_longjmp_master_breakpoint)
3598         (create_std_terminate_master_breakpoint): Update.
3599         * progspace.c (program_spaces): Now a std::vector.
3600         (maybe_new_address_space): Update.
3601         (add_program_space): Remove.
3602         (program_space::program_space): Update.
3603         (remove_program_space): Update.
3604         (number_of_program_spaces): Remove.
3605         (print_program_space, update_address_spaces): Update.
3606         * progspace.h (program_spaces): Change type.
3607         (ALL_PSPACES): Remove.
3608         (number_of_program_spaces): Don't declare.
3609         (struct program_space) <next>: Remove.
3610
3611 2020-05-08  Tom Tromey  <tom@tromey.com>
3612
3613         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
3614         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
3615         (enable_break): Update.
3616         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
3617         (frv_fdpic_find_canonical_descriptor): Update.
3618         (frv_fetch_objfile_link_map): Update.
3619         * progspace.c (program_space::free_all_objfiles): Update.
3620         (program_space::solibs): New method.
3621         * progspace.h (struct program_space) <solibs>: New method.
3622         * solist.h (master_so_list): Don't declare.
3623         (ALL_SO_LIBS): Remove.
3624         * solib.h (so_list_head): Remove.
3625         (update_solib_list): Update comment.
3626         * solib.c (master_so_list): Remove.
3627         (solib_used, update_solib_list, solib_add)
3628         (info_sharedlibrary_command, clear_solib)
3629         (reload_shared_libraries_1, remove_user_added_objfile): Update.
3630
3631 2020-05-08  Tom Tromey  <tom@tromey.com>
3632
3633         * extension.c (extension_languages): Now a std::array.
3634         (ALL_EXTENSION_LANGUAGES): Remove.
3635         (get_ext_lang_defn, get_ext_lang_of_file)
3636         (eval_ext_lang_from_control_command): Update.
3637         (finish_ext_lang_initialization)
3638         (auto_load_ext_lang_scripts_for_objfile)
3639         (ext_lang_type_printers::ext_lang_type_printers)
3640         (apply_ext_lang_type_printers)
3641         (ext_lang_type_printers::~ext_lang_type_printers)
3642         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
3643         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
3644         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
3645         (get_matching_xmethod_workers, ext_lang_colorize)
3646         (ext_lang_before_prompt): Update.
3647         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
3648
3649 2020-05-08  Tom Tromey  <tom@tromey.com>
3650
3651         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
3652         overload.
3653         <swap_string, m_string>: Remove.
3654         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
3655         Update.
3656         * stabsread.c (define_symbol, read_type): Update.
3657         * linespec.c (find_linespec_symbols): Update.
3658         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
3659         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
3660         * dbxread.c (read_dbx_symtab): Update.
3661         * cp-support.h (cp_canonicalize_string_full)
3662         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
3663         Return unique_xmalloc_ptr.
3664         * cp-support.c (inspect_type): Update.
3665         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
3666         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
3667         Likewise.
3668         * c-typeprint.c (print_name_maybe_canonical): Update.
3669         * break-catch-throw.c (check_status_exception_catchpoint):
3670         Update.
3671
3672 2020-05-08  Tom de Vries  <tdevries@suse.de>
3673
3674         * infrun.c (follow_fork): Copy current_line and current_symtab to
3675         child thread.
3676
3677 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3678
3679         * async-event.c (struct async_signal_handler, struct
3680         async_event_handler): Reformat, remove typedef.
3681
3682 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3683
3684         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
3685         access thistype->main_type->dyn_prop_list directly.
3686
3687 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3688
3689         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
3690         (remove_dyn_prop): Remove.  Update all users to use
3691         type::remove_dyn_prop.
3692         * gdbtypes.c (remove_dyn_prop): Rename to...
3693         (type::remove_dyn_prop): ... this.
3694
3695 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
3696
3697         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
3698         (add_dyn_prop): Remove.  Update all users to use
3699         type::add_dyn_prop.
3700         * gdbtypes.c (add_dyn_prop): Rename to...
3701         (type::add_dyn_prop): ... this.
3702
3703 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3704
3705         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
3706         (get_dyn_prop): Remove.  Update all users to use
3707         type::dyn_prop.
3708         * gdbtypes.c (get_dyn_prop): Rename to...
3709         (type::dyn_prop): ... this.
3710
3711 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3712
3713         * gdbtypes.h (struct main_type) <flag_static>: Remove.
3714
3715 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3716
3717         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
3718         instruction, skip it if it's there.
3719
3720 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
3721
3722         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
3723
3724 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
3725
3726         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
3727         * gdbtypes.c (recursive_dump_type): Remove use of
3728         TYPE_INCOMPLETE.
3729
3730 2020-05-03  Tom Tromey  <tom@tromey.com>
3731
3732         * breakpoint.c (catch_command, tcatch_command): Remove.
3733         (_initialize_breakpoint): Use add_basic_prefix_cmd,
3734         add_show_prefix_cmd.
3735         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
3736         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
3737         Remove.
3738         (add_internal_problem_command): Use add_basic_prefix_cmd,
3739         add_show_prefix_cmd.
3740         * mips-tdep.c (set_mipsfpu_command): Remove.
3741         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
3742         * dwarf2/index-cache.c (set_index_cache_command): Remove.
3743         (_initialize_index_cache): Use add_basic_prefix_cmd.
3744         * memattr.c (dummy_cmd): Remove.
3745         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
3746         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
3747         (_initialize_tui_win): Use add_basic_prefix_cmd,
3748         add_show_prefix_cmd.
3749         * cli/cli-logging.c (set_logging_command): Remove.
3750         (_initialize_cli_logging): Use add_basic_prefix_cmd,
3751         add_show_prefix_cmd.
3752         (show_logging_command): Remove.
3753         * target.c (target_command): Remove.
3754         (add_target): Use add_basic_prefix_cmd.
3755
3756 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
3757
3758         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
3759
3760 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3761
3762         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
3763         info_command.
3764
3765 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
3766
3767         * nbsd-nat.c (nbsd_enable_proc_events)
3768         (nbsd_nat_target::post_startup_inferior): Add.
3769         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
3770         (nbsd_nat_target::update_thread_list): Rewrite.
3771         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
3772         "PTRACE_LWP_CREATE".
3773         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
3774
3775 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3776
3777         * stack.c (_initialize_stack): Remove duplicated creation
3778         of "frame" command and "f" alias.
3779
3780 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3781
3782         PR gdb/18706
3783         * gdbtypes.c (check_typedef): Calculate size of array of
3784         stubbed type.
3785
3786 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3787
3788         PR gdb/15559
3789         * i386-tdep.c (i386_push_dummy_call): Call
3790         i386_thiscall_push_dummy_call.
3791         (i386_thiscall_push_dummy_call): New function.
3792         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
3793         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
3794         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
3795
3796 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3797
3798         * gdbarch.sh (do_read): Add shellcheck disable directive for
3799         warning SC2162.
3800
3801 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3802
3803         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
3804         "referenced but not assigned" warning.
3805
3806 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3807
3808         * gdbarch.sh: Remove code that sets fallbackdefault.
3809
3810 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3811
3812         * gdbarch.sh: Use shell operators && and || instead of
3813         -a and -o.
3814
3815 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3816
3817         * gdbarch.sh: Use $(...) instead of `...`.
3818
3819 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3820
3821         * gdbarch.sh: Use double quotes around variables.
3822
3823 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3824
3825         * gdbarch.sh: Use %s with printf, instead of variables in the
3826         format string.
3827
3828 2020-04-29  Tom Tromey  <tromey@adacore.com>
3829
3830         PR ada/25875:
3831         * dwarf2/read.c (update_enumeration_type_from_children): Compute
3832         type fields here.
3833         (read_enumeration_type): Call
3834         update_enumeration_type_from_children later.  Update comments.
3835         (process_enumeration_scope): Don't create type fields.
3836
3837 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3838
3839         * nbsd-tdep.c: Include "xml-syscall.h".
3840         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
3841
3842 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3843
3844         * nbsd-nat.c: Include "sys/wait.h".
3845         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
3846         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
3847         (nbsd_nat_target::remove_exec_catchpoint)
3848         (nbsd_nat_target::set_syscall_catchpoint): Add.
3849         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
3850         (nbsd_nat_target::insert_exec_catchpoint)
3851         (nbsd_nat_target::remove_exec_catchpoint)
3852         (nbsd_nat_target::set_syscall_catchpoint): Add.
3853         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
3854         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
3855         `nbsd_get_syscall_number'.
3856
3857 2020-04-29  Tom Tromey  <tom@tromey.com>
3858
3859         * stack.c (print_block_frame_labels): Remove.
3860
3861 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
3862
3863         PR gdb/17320
3864         * ada-valprint.c (val_print_packed_array_elements): Move array
3865         end bracket to new line.
3866         (ada_val_print_string): Remove extra spaces before first array
3867         element.
3868         * c-valprint.c (c_value_print_array): Likewise.
3869         * m2-valprint.c (m2_print_array_contents): Likewise.
3870         (m2_value_print_inner): Likewise.
3871         * p-valprint.c (pascal_value_print_inner): Likewise.
3872         * valprint.c (generic_val_print_array): Likewise.
3873         (value_print_array_elements): Move first array element and array
3874         end bracket to new line.
3875
3876 2020-04-29  Tom de Vries  <tdevries@suse.de>
3877
3878         PR symtab/25889
3879         * linespec.c (find_method): Fix ix calculation.
3880
3881 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
3882
3883         * syscalls/update-netbsd.sh: New file.
3884         * syscalls/netbsd.xml: Regenerate.
3885         * data-directory/Makefile.in: Register `netbsd.xml' in
3886         `SYSCALLS_FILES'.
3887
3888 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3889
3890         * syscalls/update-freebsd.sh: Add double quotes.
3891
3892 2020-04-28  Tom Tromey  <tom@tromey.com>
3893
3894         * NEWS: Update.
3895         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
3896         (cmdpy_init): Allow class_tui.
3897
3898 2020-04-28 Mark Williams <mark@myosotissp.com>
3899
3900         PR gdb/24480
3901         * dwarf2read.c: Add missing assingments to list_in_scope when
3902         start_symtab was already called.
3903
3904 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3905
3906         PR gdb/25881
3907         * dwarf2/read.c (offset_map_type): Use
3908         gdb:hash_enum<sect_offset> as hash function.
3909
3910 2020-04-28  Tom de Vries  <tdevries@suse.de>
3911
3912         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
3913         with DW_AT_signature.
3914
3915 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
3916
3917         * configure.ac: Remove check for fs_base/gs_base in
3918         user_regs_struct.
3919         * configure: Re-generate.
3920         * config.in: Re-generate.
3921         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
3922         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
3923         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
3924
3925 2020-04-27  Luis Machado  <luis.machado@linaro.org>
3926
3927         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3928         problematic inline frame unwinding situation.
3929         * frame.c (frame_id_computed_p): New function.
3930         * frame.h (frame_id_computed_p): New prototype.
3931
3932 2020-04-26  Tom Tromey  <tom@tromey.com>
3933
3934         * command.h (enum command_class) <class_pseudo>: Remove.
3935
3936 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3937
3938         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3939         and whitespace.
3940
3941 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3942
3943         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3944         `PT_GET_PROCESS_STATE' block.
3945
3946 2020-04-24  Tom Tromey  <tom@tromey.com>
3947
3948         * symtab.h (symbol_get_demangled_name): Don't declare.
3949         * symtab.c (symbol_get_demangled_name): Remove.
3950         (general_symbol_info::natural_name)
3951         (general_symbol_info::demangled_name): Update.
3952
3953 2020-04-24  Tom Tromey  <tom@tromey.com>
3954
3955         PR rust/25025:
3956         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3957
3958 2020-04-24  Tom Tromey  <tom@tromey.com>
3959
3960         PR symtab/12707:
3961         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3962         exists.
3963         (new_symbol): Likewise.
3964         * compile/compile-object-load.c (get_out_value_type): Use
3965         symbol_matches_search_name.
3966
3967 2020-04-24  Tom Tromey  <tom@tromey.com>
3968
3969         * dwarf2/read.c (add_partial_symbol): Do not call
3970         compute_and_set_names.
3971
3972 2020-04-24  Tom Tromey  <tom@tromey.com>
3973
3974         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3975         overload.
3976
3977 2020-04-24  Tom Tromey  <tom@tromey.com>
3978
3979         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3980         (add_psymbol_to_list): New overload.  Make old overload call new
3981         one.
3982         * psympriv.h (add_psymbol_to_list): New overload.
3983
3984 2020-04-24  Tom Tromey  <tom@tromey.com>
3985
3986         * dwarf2/read.c (partial_die_info::read) <case
3987         DW_AT_linkage_name>: Use value_as_string.
3988         (dwarf2_string_attr): Use value_as_string.
3989         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3990         method.
3991         * dwarf2/attribute.c (attribute::value_as_string): New method.
3992
3993 2020-04-24  Tom Tromey  <tom@tromey.com>
3994
3995         * symtab.c (general_symbol_info::natural_name)
3996         (general_symbol_info::demangled_name): Check for language_rust.
3997
3998 2020-04-24  Tom Tromey  <tom@tromey.com>
3999
4000         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
4001         (dwarf2_physname): ... from here.
4002         (partial_die_info::read): Add Rust "{" hack.
4003
4004 2020-04-24  Tom Tromey  <tom@tromey.com>
4005
4006         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
4007         method.
4008         (symbol_set_demangled_name): Don't declare.
4009         * symtab.c (general_symbol_info::set_demangled_name): Rename from
4010         symbol_set_demangled_name.
4011         (general_symbol_info::set_language)
4012         (general_symbol_info::compute_and_set_names): Update.
4013         * minsyms.c (minimal_symbol_reader::install): Update.
4014         * dwarf2/read.c (new_symbol): Update.
4015
4016 2020-04-24  Tom Tromey  <tromey@adacore.com>
4017
4018         PR python/23662:
4019         * python/py-type.c (convert_field): Handle
4020         FIELD_LOC_KIND_DWARF_BLOCK.
4021         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
4022         (typy_get_dynamic): Nw function.
4023         (type_object_getset): Add "dynamic".
4024         * NEWS: Add entry.
4025
4026 2020-04-24  Tom Tromey  <tromey@adacore.com>
4027
4028         * ada-typeprint.c (print_choices, print_variant_part)
4029         (print_record_field_types_dynamic): New functions.
4030         (print_record_field_types): Use print_record_field_types_dynamic.
4031
4032 2020-04-24  Tom Tromey  <tromey@adacore.com>
4033
4034         * dwarf2/read.c (handle_data_member_location): New overload.
4035         (dwarf2_add_field): Use it.
4036         (decode_locdesc): Add "computed" parameter.  Update comment.
4037         * gdbtypes.c (is_dynamic_type_internal): Also look for
4038         FIELD_LOC_KIND_DWARF_BLOCK.
4039         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
4040         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
4041         virtual base classes.
4042         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
4043         FIELD_LOC_KIND_DWARF_BLOCK.
4044
4045 2020-04-24  Tom Tromey  <tromey@adacore.com>
4046
4047         * dwarf2/read.c (read_structure_type): Handle dynamic length.
4048         * gdbtypes.c (is_dynamic_type_internal): Check
4049         TYPE_HAS_DYNAMIC_LENGTH.
4050         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
4051         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
4052         New macros.
4053         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
4054         constant.
4055
4056 2020-04-24  Tom Tromey  <tromey@adacore.com>
4057
4058         * dwarf2/read.c (struct variant_field): Rewrite.
4059         (struct variant_part_builder): New.
4060         (struct nextfield): Remove "variant" field.  Add "offset".
4061         (struct field_info): Add "current_variant_part" and
4062         "variant_parts".
4063         (alloc_discriminant_info): Remove.
4064         (alloc_rust_variant): New function.
4065         (quirk_rust_enum): Update.
4066         (dwarf2_add_field): Set "offset" member.  Don't handle
4067         DW_TAG_variant_part.
4068         (offset_map_type): New typedef.
4069         (convert_variant_range, create_one_variant)
4070         (create_one_variant_part, create_variant_parts)
4071         (add_variant_property): New functions.
4072         (dwarf2_attach_fields_to_type): Call add_variant_property.
4073         (read_structure_type): Don't handle DW_TAG_variant_part.
4074         (handle_variant_part, handle_variant): New functions.
4075         (handle_struct_member_die): Use them.
4076         (process_structure_scope): Don't handle variant parts.
4077         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
4078         (struct discriminant_info): Remove.
4079         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
4080         (struct main_type) <flag_discriminated_union>: Remove.
4081         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
4082         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
4083         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
4084         Update.
4085         * valops.c (value_union_variant): Remove.
4086         * value.h (value_union_variant): Don't declare.
4087
4088 2020-04-24  Tom Tromey  <tromey@adacore.com>
4089
4090         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
4091         (ada_value_primitive_packed_val): Update.
4092         * ada-valprint.c (ada_value_print_1): Update.
4093         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
4094         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
4095         just an address.  Use evaluate_for_locexpr_baton.
4096         (dwarf2_evaluate_property): Update.
4097         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
4098         array_view.
4099         * findvar.c (default_read_var_value): Update.
4100         * gdbtypes.c (compute_variant_fields_inner)
4101         (resolve_dynamic_type_internal): Update.
4102         (resolve_dynamic_type): Change type of valaddr parameter.
4103         * gdbtypes.h (resolve_dynamic_type): Update.
4104         * valarith.c (value_subscripted_rvalue): Update.
4105         * value.c (value_from_contents_and_address): Update.
4106
4107 2020-04-24  Tom Tromey  <tromey@adacore.com>
4108
4109         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
4110         "push_initial_value" parameter.
4111         (dwarf2_evaluate_property): Likewise.
4112         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
4113
4114 2020-04-24  Tom Tromey  <tromey@adacore.com>
4115
4116         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
4117         (variant::matches, compute_variant_fields_recurse)
4118         (compute_variant_fields_inner, compute_variant_fields): New
4119         functions.
4120         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
4121         Use resolved_type after type is made.
4122         (operator==): Add new cases.
4123         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
4124         (struct discriminant_range, struct variant, struct variant_part):
4125         New.
4126         (union dynamic_prop_data) <variant_parts, original_type>: New
4127         members.
4128         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
4129         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
4130         constants.
4131         * value.c (unpack_bits_as_long): Now public.
4132         * value.h (unpack_bits_as_long): Declare.
4133
4134 2020-04-24  Tom Tromey  <tromey@adacore.com>
4135
4136         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
4137         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
4138
4139 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
4140
4141         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
4142
4143 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
4144
4145         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
4146         (remove_fork_catchpoint, post_startup_inferior)
4147         (post_attach): Move...
4148         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
4149         (remove_fork_catchpoint, post_startup_inferior)
4150         (post_attach): ...here.
4151         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
4152         (remove_fork_catchpoint, post_startup_inferior)
4153         (post_attach): Move...
4154         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
4155         (remove_fork_catchpoint, post_startup_inferior)
4156         (post_attach): ...here.
4157
4158 2020-04-24  Tom Tromey  <tromey@adacore.com>
4159
4160         * nat/windows-nat.h (struct windows_thread_info)
4161         <pc_adjusted>: New member.
4162         * windows-nat.c (windows_fetch_one_register): Check
4163         pc_adjusted.
4164         (windows_nat_target::get_windows_debug_event)
4165         (windows_nat_target::wait): Set pc_adjusted.
4166
4167 2020-04-24  Tom de Vries  <tdevries@suse.de>
4168
4169         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
4170         Run gdb-add-index inside temp dir.
4171
4172 2020-04-23  Tom Tromey  <tromey@adacore.com>
4173
4174         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
4175         in loop.
4176
4177 2020-04-23  Luis Machado  <luis.machado@linaro.org>
4178
4179         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
4180         get_frame_register instead of gdbarch_unwind_pc.
4181
4182 2020-04-23  Tom de Vries  <tdevries@suse.de>
4183
4184         * symtab.c (lookup_global_symbol): Prefer def over decl.
4185
4186 2020-04-23  Tom de Vries  <tdevries@suse.de>
4187
4188         PR symtab/25807
4189         * block.c (best_symbol, better_symbol): Promote to external.
4190         * block.h (best_symbol, better_symbol): Declare.
4191         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
4192         decl.
4193
4194 2020-04-23  Tom Tromey  <tromey@adacore.com>
4195
4196         PR ada/25837:
4197         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
4198         "const char *", not a "const std::string &".
4199         <name_and_matcher::operator==>: Update.
4200         * unittests/lookup_name_info-selftests.c: Change type of
4201         "result".
4202
4203 2020-04-23  Tom Tromey  <tom@tromey.com>
4204
4205         * inferior.h (iterate_over_inferiors): Don't declare.
4206         * inferior.c (iterate_over_inferiors): Remove.
4207         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
4208         Remove.
4209         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
4210         use iterate_over_inferiors.
4211         (darwin_resume_inferior_it)
4212         (struct resume_inferior_threads_param)
4213         (darwin_resume_inferior_threads_it): Remove.
4214         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
4215
4216 2020-04-23  Tom de Vries  <tdevries@suse.de>
4217
4218         * blockframe.c (find_pc_partial_function): Use
4219         find_pc_sect_compunit_symtab rather than
4220         objfile->sf->qf->find_pc_sect_compunit_symtab.
4221
4222 2020-04-22  Tom de Vries  <tdevries@suse.de>
4223
4224         PR symtab/25764
4225         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
4226         in psymtabs.
4227
4228 2020-04-22  Tom de Vries  <tdevries@suse.de>
4229
4230         PR symtab/25801
4231         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
4232         symtabs.
4233
4234 2020-04-22  Tom de Vries  <tdevries@suse.de>
4235
4236         PR symtab/25700
4237         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
4238         CU if already created.
4239
4240 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4241
4242         * infrun.c (displaced_step_fixup): Switch to the event_thread
4243         before calling displaced_step_restore, not after.
4244
4245 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4246
4247         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
4248         its inferior is not recorded by us.
4249         (record_btrace_target_open): Replace call to
4250         all_non_exited_threads () with call to current_inferior
4251         ()->non_exited_threads ().
4252         (record_btrace_target::stop_recording): Likewise.
4253         (record_btrace_target::close): Likewise.
4254         (record_btrace_target::wait): Likewise.
4255         (record_btrace_target::record_stop_replaying): Likewise.
4256
4257 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4258
4259         * btrace.c (btrace_enable): Throw an error on double enables and
4260         when enabling recording fails.
4261         (btrace_disable): Throw an error if the thread is not recorded.
4262
4263 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4264
4265         * record-btrace.c (record_btrace_target::fetch_registers): Forward
4266         request if we do not have a thread_info.
4267
4268 2020-04-21  Tom de Vries  <tdevries@suse.de>
4269
4270         PR gdb/25471
4271         * thread.c
4272         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
4273         exception in get_frame_id.
4274
4275 2020-04-20  Tom Tromey  <tromey@adacore.com>
4276
4277         * python/python.c (struct gdbpy_event): Mark move constructor as
4278         noexcept.
4279         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
4280         constructor as noexcept.
4281         * completer.h (struct completion_result): Mark move constructor as
4282         noexcept.
4283         * completer.c (completion_result::completion_result): Use
4284         initialization style.  Don't call reset_match_list.
4285
4286 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
4287
4288         * MAINTAINERS (Write After Approval): Add myself.
4289
4290 2020-04-18  Tom Tromey  <tom@tromey.com>
4291
4292         * windows-tdep.c (init_w32_command_list)
4293         (w32_prefix_command_valid): Restore.
4294         (_initialize_windows_tdep): Call init_w32_command_list.
4295
4296 2020-04-18  Tom Tromey  <tom@tromey.com>
4297
4298         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
4299         * value.c (value_fn_field): Update.
4300         * valops.c (find_function_in_inferior)
4301         (value_allocate_space_in_inferior): Update.
4302         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4303         Update.
4304         * tui/tui-source.c (tui_source_window::set_contents): Update.
4305         * symtab.c (lookup_global_or_static_symbol)
4306         (find_function_start_sal_1, skip_prologue_sal)
4307         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
4308         * symmisc.c (dump_msymbols, dump_symtab_1)
4309         (maintenance_print_one_line_table): Update.
4310         * symfile.c (init_entry_point_info, section_is_mapped)
4311         (list_overlays_command, simple_read_overlay_table)
4312         (simple_overlay_update_1): Update.
4313         * stap-probe.c (handle_stap_probe): Update.
4314         * stabsread.c (dbx_init_float_type, define_symbol)
4315         (read_one_struct_field, read_enum_type, read_range_type): Update.
4316         * source.c (info_line_command): Update.
4317         * python/python.c (gdbpy_source_objfile_script)
4318         (gdbpy_execute_objfile_script): Update.
4319         * python/py-type.c (save_objfile_types): Update.
4320         * python/py-objfile.c (py_free_objfile): Update.
4321         * python/py-inferior.c (python_new_objfile): Update.
4322         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
4323         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
4324         (maintenance_check_psymtabs): Update.
4325         * printcmd.c (info_address_command): Update.
4326         * objfiles.h (struct objfile) <arch>: New method, from
4327         get_objfile_arch.
4328         (get_objfile_arch): Don't declare.
4329         * objfiles.c (get_objfile_arch): Remove.
4330         (filter_overlapping_sections): Update.
4331         * minsyms.c (msymbol_is_function): Update.
4332         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
4333         (output_nondebug_symbol): Update.
4334         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
4335         (mdebug_expand_psymtab): Update.
4336         * machoread.c (macho_add_oso_symfile): Update.
4337         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
4338         Update.
4339         * linux-fork.c (checkpoint_command): Update.
4340         * linespec.c (convert_linespec_to_sals): Update.
4341         * jit.c (finalize_symtab): Update.
4342         * infrun.c (insert_exception_resume_from_probe): Update.
4343         * ia64-tdep.c (ia64_find_unwind_table): Update.
4344         * hppa-tdep.c (internalize_unwinds): Update.
4345         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
4346         Update.
4347         * gcore.c (call_target_sbrk): Update.
4348         * elfread.c (record_minimal_symbol, elf_symtab_read)
4349         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
4350         (elf_gnu_ifunc_resolve_by_got): Update.
4351         * dwarf2/read.c (create_addrmap_from_index)
4352         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4353         (read_debug_names_from_section)
4354         (process_psymtab_comp_unit_reader, add_partial_symbol)
4355         (add_partial_subprogram, process_full_comp_unit)
4356         (read_file_scope, read_func_scope, read_lexical_block_scope)
4357         (read_call_site_scope, dwarf2_ranges_read)
4358         (dwarf2_record_block_ranges, dwarf2_add_field)
4359         (mark_common_block_symbol_computed, read_tag_pointer_type)
4360         (read_tag_string_type, dwarf2_init_float_type)
4361         (dwarf2_init_complex_target_type, read_base_type)
4362         (partial_die_info::read, partial_die_info::read)
4363         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
4364         (dwarf2_fetch_die_loc_sect_off): Update.
4365         * dwarf2/loc.c (dwarf2_find_location_expression)
4366         (class dwarf_evaluate_loc_desc, rw_pieced_value)
4367         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
4368         (dwarf2_loc_desc_get_symbol_read_needs)
4369         (locexpr_describe_location_piece, locexpr_describe_location_1)
4370         (loclist_describe_location): Update.
4371         * dwarf2/index-write.c (write_debug_names): Update.
4372         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
4373         * dtrace-probe.c (dtrace_process_dof): Update.
4374         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
4375         (process_one_symbol): Update.
4376         * ctfread.c (ctf_init_float_type, read_base_type): Update.
4377         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
4378         (coff_read_enum_type): Update.
4379         * cli/cli-cmds.c (edit_command, list_command): Update.
4380         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
4381         * breakpoint.c (create_overlay_event_breakpoint)
4382         (create_longjmp_master_breakpoint)
4383         (create_std_terminate_master_breakpoint)
4384         (create_exception_master_breakpoint, get_sal_arch): Update.
4385         * block.c (block_gdbarch): Update.
4386         * annotate.c (annotate_source_line): Update.
4387
4388 2020-04-17  Tom Tromey  <tromey@adacore.com>
4389
4390         * auto-load.c (show_auto_load_cmd): Remove.
4391         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
4392         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
4393         (maintenance_print_arc_command): Remove.
4394         * tui/tui-win.c (tui_command): Remove.
4395         (tui_get_cmd_list): Use add_basic_prefix_cmd.
4396         * tui/tui-layout.c (tui_layout_command): Remove.
4397         (_initialize_tui_layout): Use add_basic_prefix_cmd.
4398         * python/python.c (user_set_python, user_show_python): Remove.
4399         (_initialize_python): Use add_basic_prefix_cmd,
4400         add_show_prefix_cmd.
4401         * guile/guile.c (set_guile_command, show_guile_command): Remove.
4402         (install_gdb_commands): Use add_basic_prefix_cmd,
4403         add_show_prefix_cmd.
4404         (info_guile_command): Remove.
4405         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
4406         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
4407         add_show_prefix_cmd.
4408         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
4409         Remove do_set and do_show parameters.
4410         * cli/cli-style.c (set_style, show_style): Remove.
4411         (_initialize_cli_style): Use add_basic_prefix_cmd,
4412         add_show_prefix_cmd.
4413         (cli_style_option::add_setshow_commands): Remove do_set and
4414         do_show parameters.
4415         (cli_style_option::add_setshow_commands): Use
4416         add_basic_prefix_cmd, add_show_prefix_cmd.
4417         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
4418         (set_style_name): Remove.
4419         * cli/cli-dump.c (dump_command, append_command): Remove.
4420         (srec_dump_command, ihex_dump_command, verilog_dump_command)
4421         (tekhex_dump_command, binary_dump_command)
4422         (binary_append_command): Remove.
4423         (_initialize_cli_dump): Use add_basic_prefix_cmd.
4424         * windows-tdep.c (w32_prefix_command_valid): Remove global.
4425         (init_w32_command_list): Remove; move into ...
4426         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
4427         * valprint.c (set_print, show_print, set_print_raw)
4428         (show_print_raw): Remove.
4429         (_initialize_valprint): Use add_basic_prefix_cmd,
4430         add_show_prefix_cmd.
4431         * typeprint.c (set_print_type, show_print_type): Remove.
4432         (_initialize_typeprint): Use add_basic_prefix_cmd,
4433         add_show_prefix_cmd.
4434         * record.c (set_record_command, show_record_command): Remove.
4435         (_initialize_record): Use add_basic_prefix_cmd,
4436         add_show_prefix_cmd.
4437         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
4438         add_show_prefix_cmd.
4439         (info_command, show_command, set_debug, show_debug): Remove.
4440         * top.h (set_history, show_history): Don't declare.
4441         * top.c (set_history, show_history): Remove.
4442         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
4443         (unset_tdesc_cmd): Remove.
4444         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
4445         add_show_prefix_cmd.
4446         * symtab.c (info_module_command): Remove.
4447         (_initialize_symtab): Use add_basic_prefix_cmd.
4448         * symfile.c (overlay_command): Remove.
4449         (_initialize_symfile): Use add_basic_prefix_cmd.
4450         * sparc64-tdep.c (info_adi_command): Remove.
4451         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
4452         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
4453         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
4454         add_show_prefix_cmd.
4455         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
4456         (_initialize_serial): Use add_basic_prefix_cmd,
4457         add_show_prefix_cmd.
4458         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
4459         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
4460         add_show_prefix_cmd.
4461         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
4462         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
4463         add_show_prefix_cmd.
4464         * riscv-tdep.c (show_riscv_command, set_riscv_command)
4465         (show_debug_riscv_command, set_debug_riscv_command): Remove.
4466         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
4467         add_show_prefix_cmd.
4468         * remote.c (remote_command, set_remote_cmd): Remove.
4469         (_initialize_remote): Use add_basic_prefix_cmd.
4470         * record-full.c (set_record_full_command)
4471         (show_record_full_command): Remove.
4472         (_initialize_record_full): Use add_basic_prefix_cmd,
4473         add_show_prefix_cmd.
4474         * record-btrace.c (cmd_set_record_btrace)
4475         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
4476         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
4477         (cmd_show_record_btrace_pt): Remove.
4478         (_initialize_record_btrace): Use add_basic_prefix_cmd,
4479         add_show_prefix_cmd.
4480         * ravenscar-thread.c (set_ravenscar_command)
4481         (show_ravenscar_command): Remove.
4482         (_initialize_ravenscar): Use add_basic_prefix_cmd,
4483         add_show_prefix_cmd.
4484         * mips-tdep.c (show_mips_command, set_mips_command)
4485         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
4486         add_show_prefix_cmd.
4487         * maint.c (maintenance_command, maintenance_info_command)
4488         (maintenance_check_command, maintenance_print_command)
4489         (maintenance_set_cmd, maintenance_show_cmd): Remove.
4490         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
4491         add_show_prefix_cmd.
4492         (show_per_command_cmd): Remove.
4493         * maint-test-settings.c (maintenance_set_test_settings_cmd):
4494         Remove.
4495         (maintenance_show_test_settings_cmd): Remove.
4496         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
4497         add_show_prefix_cmd.
4498         * maint-test-options.c (maintenance_test_options_command):
4499         Remove.
4500         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
4501         * macrocmd.c (macro_command): Remove
4502         (_initialize_macrocmd): Use add_basic_prefix_cmd.
4503         * language.c (set_check, show_check): Remove.
4504         (_initialize_language): Use add_basic_prefix_cmd,
4505         add_show_prefix_cmd.
4506         * infcmd.c (unset_command): Remove.
4507         (_initialize_infcmd): Use add_basic_prefix_cmd.
4508         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
4509         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
4510         add_show_prefix_cmd.
4511         * go32-nat.c (go32_info_dos_command): Remove.
4512         (_initialize_go32_nat): Use add_basic_prefix_cmd.
4513         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
4514         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
4515         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
4516         (_initialize_frame): Use add_basic_prefix_cmd,
4517         add_show_prefix_cmd.
4518         * dcache.c (set_dcache_command, show_dcache_command): Remove.
4519         (_initialize_dcache): Use add_basic_prefix_cmd,
4520         add_show_prefix_cmd.
4521         * cp-support.c (maint_cplus_command): Remove.
4522         (_initialize_cp_support): Use add_basic_prefix_cmd.
4523         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
4524         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
4525         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
4526         add_basic_prefix_cmd, add_show_prefix_cmd.
4527         * breakpoint.c (save_command): Remove.
4528         (_initialize_breakpoint): Use add_basic_prefix_cmd.
4529         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
4530         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
4531         add_show_prefix_cmd.
4532         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
4533         (set_ada_command, show_ada_command): Remove.
4534         (_initialize_ada_language): Use add_basic_prefix_cmd,
4535         add_show_prefix_cmd.
4536         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
4537
4538 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
4539
4540         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
4541         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
4542
4543 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4544
4545         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
4546         warning messages.
4547
4548 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4549
4550         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
4551         import table is not at beginning of .idata section.
4552
4553 2020-04-16  Pedro Alves  <palves@redhat.com>
4554
4555         * inferior.c (delete_inferior): Use delete operator directly
4556         instead of delete_program_space.
4557         * progspace.c (add_program_space): New, factored out from
4558         program_space::program_space.
4559         (remove_program_space): New, factored out from
4560         delete_program_space.
4561         (program_space::program_space): Remove intro comment.  Rewrite.
4562         (program_space::~program_space): Remove intro comment.  Call
4563         remove_program_space.
4564         (delete_program_space): Delete.
4565         * progspace.h (program_space::program_space): Make explicit.  Move
4566         intro comment here, adjusted.
4567         (program_space::~program_space): Move intro comment here,
4568         adjusted.
4569         (delete_program_space): Remove.
4570
4571 2020-04-16  Tom Tromey  <tromey@adacore.com>
4572
4573         * windows-nat.c (windows_nat::handle_access_violation): New
4574         function.
4575         * nat/windows-nat.h (handle_access_violation): Declare.
4576         * nat/windows-nat.c (handle_exception): Move Cygwin code to
4577         windows-nat.c.  Call handle_access_violation.
4578
4579 2020-04-16  Tom de Vries  <tdevries@suse.de>
4580
4581         PR symtab/25791
4582         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
4583         CUs without psymtab.
4584
4585 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
4586
4587         * python/python.c (do_start_initialization): Don't call
4588         PyEval_InitThreads for Python 3.9 and beyond.
4589
4590 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
4591
4592         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
4593         thread functions.
4594         (obsd_nat_target::wait): Likewise.
4595
4596 2020-04-15  Tom Tromey  <tromey@adacore.com>
4597
4598         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
4599         (DEBUG_EXCEPT): Use debug_printf.
4600
4601 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * completer.c (class completion_tracker::completion_hash_entry)
4604         <hash_name>: New member function.
4605         (completion_tracker::discard_completions): New callback to hash a
4606         completion_hash_entry, pass this to htab_create_alloc.
4607
4608 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
4609
4610         * windows-nat.c (windows_make_so): Warn rather than stopping with
4611         an error if realpath() fails.
4612
4613 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
4614
4615         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
4616         (nbsd_nat_target::info_proc): Add do_status.
4617
4618 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
4619             Tom de Vries  <tdevries@suse.de>
4620
4621         PR symtab/25718
4622         * psympriv.h (struct partial_symtab::read_symtab)
4623         (struct partial_symtab::expand_psymtab)
4624         (struct partial_symtab::read_dependencies): Update comments.
4625         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
4626         read_symtab for includer.
4627         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
4628         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
4629         (struct dwarf2_include_psymtab::m_readin): Remove.
4630         (struct dwarf2_include_psymtab::includer): New member function.
4631         (dwarf2_psymtab::expand_psymtab): Assert !readin.
4632
4633 2020-04-14  Tom de Vries  <tdevries@suse.de>
4634
4635         PR symtab/25720
4636         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
4637         with NULL symbol_matcher and lookup_name.
4638         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
4639         and lookup_name.
4640         * dwarf2/read.c (dw2_expand_symtabs_matching)
4641         (dw2_debug_names_expand_symtabs_matching): Same.
4642         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
4643         Make lookup_name a pointer.  Update comment.
4644         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
4645         lookup_name being a pointer.
4646         * symfile.c (expand_symtabs_matching): Same.
4647         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
4648         * linespec.c (iterate_over_all_matching_symtabs): Same.
4649
4650 2020-04-13  Tom Tromey  <tom@tromey.com>
4651
4652         * run-on-main-thread.c: Update include.
4653         * unittests/main-thread-selftests.c: Update include.
4654         * tui/tui-win.c: Update include.
4655         * tui/tui-io.c: Update include.
4656         * tui/tui-interp.c: Update include.
4657         * tui/tui-hooks.c: Update include.
4658         * top.h: Update include.
4659         * top.c: Update include.
4660         * ser-base.c: Update include.
4661         * remote.c: Update include.
4662         * remote-notif.c: Update include.
4663         * remote-fileio.c: Update include.
4664         * record-full.c: Update include.
4665         * record-btrace.c: Update include.
4666         * python/python.c: Update include.
4667         * posix-hdep.c: Update include.
4668         * mingw-hdep.c: Update include.
4669         * mi/mi-main.c: Update include.
4670         * mi/mi-interp.c: Update include.
4671         * main.c: Update include.
4672         * linux-nat.c: Update include.
4673         * interps.c: Update include.
4674         * infrun.c: Update include.
4675         * inf-loop.c: Update include.
4676         * event-top.c: Update include.
4677         * event-loop.c: Move to ../gdbsupport/.
4678         * event-loop.h: Move to ../gdbsupport/.
4679         * async-event.h: Update include.
4680         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
4681
4682 2020-04-13  Tom Tromey  <tom@tromey.com>
4683
4684         * tui/tui-win.c: Include async-event.h.
4685         * remote.c: Include async-event.h.
4686         * remote-notif.c: Include async-event.h.
4687         * record-full.c: Include async-event.h.
4688         * record-btrace.c: Include async-event.h.
4689         * infrun.c: Include async-event.h.
4690         * event-top.c: Include async-event.h.
4691         * event-loop.h: Move some declarations to async-event.h.
4692         * event-loop.c: Don't include ser-event.h or top.h.  Move some
4693         code to async-event.c.
4694         * async-event.h: New file.
4695         * async-event.c: New file.
4696         * Makefile.in (COMMON_SFILES): Add async-event.c.
4697         (HFILES_NO_SRCDIR): Add async-event.h.
4698
4699 2020-04-13  Tom Tromey  <tom@tromey.com>
4700
4701         * utils.c (flush_streams): New function.
4702         * event-loop.c (gdb_wait_for_event): Call flush_streams.
4703
4704 2020-04-13  Tom Tromey  <tom@tromey.com>
4705
4706         * event-loop.c (handle_file_event): Use warning, not
4707         printf_unfiltered.
4708
4709 2020-04-13  Tom Tromey  <tom@tromey.com>
4710
4711         * event-loop.c: Include <chrono>.
4712
4713 2020-04-13  Tom Tromey  <tom@tromey.com>
4714
4715         * gdb_select.h: Move to ../gdbsupport/.
4716         * event-loop.c: Update include path.
4717         * top.c: Update include path.
4718         * ser-base.c: Update include path.
4719         * ui-file.c: Update include path.
4720         * ser-tcp.c: Update include path.
4721         * guile/scm-ports.c: Update include path.
4722         * posix-hdep.c: Update include path.
4723         * ser-unix.c: Update include path.
4724         * gdb_usleep.c: Update include path.
4725         * mingw-hdep.c: Update include path.
4726         * inflow.c: Update include path.
4727         * infrun.c: Update include path.
4728         * event-top.c: Update include path.
4729
4730 2020-04-13  Tom Tromey  <tom@tromey.com>
4731
4732         * configure: Rebuild.
4733         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
4734
4735 2020-04-13  Tom Tromey  <tom@tromey.com>
4736
4737         * event-loop.h (start_event_loop): Don't declare.
4738         * event-loop.c (start_event_loop): Move...
4739         * main.c (start_event_loop): ...here.  Now static.
4740
4741 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
4742
4743         * MAINTAINERS: Update my email address.
4744
4745 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4746
4747         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
4748         IP_ALL.
4749
4750 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4751
4752         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
4753         (nbsd_nat_target::info_proc): Add do_cmdline.
4754
4755 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4756
4757         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
4758         (nbsd_nat_target::info_proc): Add do_cwd.
4759
4760 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4761
4762         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
4763
4764 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
4765
4766         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
4767         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
4768         (nbsd_nat_target::info_proc): New functions.
4769         * nbsd-nat.c (kinfo_get_vmmap): New function.
4770         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
4771         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
4772         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
4773         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
4774         functions.
4775         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
4776         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
4777         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
4778         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
4779         (KINFO_VME_FLAG_GROWS_DOWN): New.
4780
4781 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
4782
4783         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
4784         bit shift.
4785
4786 2020-04-10  Tom Tromey  <tromey@adacore.com>
4787
4788         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
4789
4790 2020-04-10  Tom Tromey  <tromey@adacore.com>
4791
4792         * symtab.c (get_symbol_address, get_msymbol_address): Skip
4793         separate debug files.
4794
4795 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
4796
4797         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4798         Move to...
4799         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4800         ... here.
4801         * windows-nat.c (windows_nat_target::get_windows_debug_event):
4802         Check for STATUS_WX86_BREAKPOINT.
4803         (windows_nat_target::wait): Same.
4804
4805 2020-04-10  Tom de Vries  <tdevries@suse.de>
4806
4807         PR cli/25808
4808         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
4809
4810 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4811
4812         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
4813         (Write After Approval): Remove Tom de Vries.
4814
4815 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4816
4817         revert partially:
4818         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4819
4820         * buildsym.c (record_line): Fix undefined behavior and preserve
4821         lines at eof.
4822
4823 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
4824
4825         * auxv.h (svr4_auxv_parse): New.
4826         * auxv.c (default_auxv_parse): Split into default_auxv_parse
4827         and generic_auxv_parse.
4828         (svr4_auxv_parse): Add.
4829         * obsd-tdep.c: Include "auxv.h".
4830         (obsd_auxv_parse): Remove.
4831         (obsd_init_abi): Remove comment.
4832         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
4833         from `obsd_auxv_parse' to `svr4_auxv_parse'.
4834         * nbsd-tdep.c: Include "auxv.h".
4835         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
4836
4837 2020-04-08  Tom Tromey  <tromey@adacore.com>
4838
4839         * nat/windows-nat.h (last_wait_event): Don't declare.
4840         (wait_for_debug_event): Update comment.
4841         * nat/windows-nat.c (last_wait_event): Now static.
4842
4843 2020-04-08  Tom Tromey  <tromey@adacore.com>
4844
4845         * windows-nat.c (wait_for_debug_event): Move to
4846         nat/windows-nat.c.
4847         * nat/windows-nat.h (wait_for_debug_event): Declare.
4848         * nat/windows-nat.c (wait_for_debug_event): Move from
4849         windows-nat.c.  No longer static.
4850
4851 2020-04-08  Tom Tromey  <tromey@adacore.com>
4852
4853         * windows-nat.c (get_windows_debug_event): Use
4854         fetch_pending_stop.
4855         * nat/windows-nat.h (fetch_pending_stop): Declare.
4856         * nat/windows-nat.c (fetch_pending_stop): New function.
4857
4858 2020-04-08  Tom Tromey  <tromey@adacore.com>
4859
4860         * windows-nat.c (windows_continue): Use matching_pending_stop and
4861         continue_last_debug_event.
4862         * nat/windows-nat.h (matching_pending_stop)
4863         (continue_last_debug_event): Declare.
4864         * nat/windows-nat.c (DEBUG_EVENTS): New define.
4865         (matching_pending_stop, continue_last_debug_event): New
4866         functions.
4867
4868 2020-04-08  Tom Tromey  <tromey@adacore.com>
4869
4870         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
4871         (handle_exception_result): Move to nat/windows-nat.h.
4872         (DEBUG_EXCEPTION_SIMPLE): Remove.
4873         (windows_nat::handle_ms_vc_exception): New function.
4874         (handle_exception): Move to nat/windows-nat.c.
4875         (get_windows_debug_event): Update.
4876         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
4877         nat/windows-nat.c.
4878         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
4879         (handle_exception_result): Move from windows-nat.c.
4880         (handle_exception): Declare.
4881         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
4882         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
4883         windows-nat.c.
4884
4885 2020-04-08  Tom Tromey  <tromey@adacore.com>
4886
4887         * windows-nat.c (exception_count, event_count): Remove.
4888         (handle_exception, get_windows_debug_event)
4889         (do_initial_windows_stuff): Update.
4890
4891 2020-04-08  Tom Tromey  <tromey@adacore.com>
4892
4893         * windows-nat.c (windows_nat::handle_load_dll)
4894         (windows_nat::handle_unload_dll): Rename.  No longer static.
4895         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
4896         Declare.
4897
4898 2020-04-08  Tom Tromey  <tromey@adacore.com>
4899
4900         * complaints.h (stop_whining): Declare at top-level.
4901         (complaint): Don't declare stop_whining.
4902
4903 2020-04-08  Tom Tromey  <tromey@adacore.com>
4904
4905         * windows-nat.c (windows_nat::handle_output_debug_string):
4906         Rename.  No longer static.
4907         * nat/windows-nat.h (handle_output_debug_string): Declare.
4908
4909 2020-04-08  Tom Tromey  <tromey@adacore.com>
4910
4911         * windows-nat.c (current_process_handle, current_process_id)
4912         (main_thread_id, last_sig, current_event, last_wait_event)
4913         (current_windows_thread, desired_stop_thread_id, pending_stops)
4914         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
4915         (display_selectors, fake_create_process)
4916         (get_windows_debug_event): Update.
4917         * nat/windows-nat.h (current_process_handle, current_process_id)
4918         (main_thread_id, last_sig, current_event, last_wait_event)
4919         (current_windows_thread, desired_stop_thread_id, pending_stops)
4920         (struct pending_stop, siginfo_er): Move from windows-nat.c.
4921         * nat/windows-nat.c (current_process_handle, current_process_id)
4922         (main_thread_id, last_sig, current_event, last_wait_event)
4923         (current_windows_thread, desired_stop_thread_id, pending_stops)
4924         (siginfo_er): New globals.  Move from windows-nat.c.
4925
4926 2020-04-08  Tom Tromey  <tromey@adacore.com>
4927
4928         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4929         (handle_load_dll): Update.
4930         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4931
4932 2020-04-08  Tom Tromey  <tromey@adacore.com>
4933
4934         * windows-nat.c (enum thread_disposition_type): Move to
4935         nat/windows-nat.h.
4936         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4937         static.
4938         (windows_add_thread, windows_nat_target::fetch_registers)
4939         (windows_nat_target::store_registers, handle_exception)
4940         (windows_nat_target::resume, get_windows_debug_event)
4941         (windows_nat_target::get_tib_address)
4942         (windows_nat_target::thread_name)
4943         (windows_nat_target::thread_alive): Update.
4944         * nat/windows-nat.h (enum thread_disposition_type): Move from
4945         windows-nat.c.
4946         (thread_rec): Declare.
4947
4948 2020-04-08  Tom Tromey  <tromey@adacore.com>
4949
4950         * windows-nat.c: Add "using namespace".
4951         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4952         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4953
4954 2020-04-08  Tom Tromey  <tromey@adacore.com>
4955
4956         * nat/windows-nat.h (struct windows_thread_info): Declare
4957         destructor.
4958         * nat/windows-nat.c (~windows_thread_info): New.
4959
4960 2020-04-08  Tom Tromey  <tromey@adacore.com>
4961
4962         PR gdb/22992
4963         * windows-nat.c (current_event): Update comment.
4964         (last_wait_event, desired_stop_thread_id): New globals.
4965         (struct pending_stop): New.
4966         (pending_stops): New global.
4967         (windows_nat_target) <stopped_by_sw_breakpoint>
4968         <supports_stopped_by_sw_breakpoint>: New methods.
4969         (windows_fetch_one_register): Add assertions.  Adjust PC.
4970         (windows_continue): Handle pending stops.  Suspend other threads
4971         when stepping.  Use last_wait_event
4972         (wait_for_debug_event): New function.
4973         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4974         pending stops.  Queue spurious stops.
4975         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4976         (windows_nat_target::kill): Use wait_for_debug_event.
4977         * nat/windows-nat.h (struct windows_thread_info)
4978         <stopped_at_software_breakpoint>: New field.
4979         * nat/windows-nat.c (windows_thread_info::resume): Clear
4980         stopped_at_software_breakpoint.
4981
4982 2020-04-08  Tom Tromey  <tromey@adacore.com>
4983
4984         * windows-nat.c (enum thread_disposition_type): New.
4985         (thread_rec): Replace "get_context" parameter with "disposition";
4986         change type.
4987         (windows_add_thread, windows_nat_target::fetch_registers)
4988         (windows_nat_target::store_registers, handle_exception)
4989         (windows_nat_target::resume, get_windows_debug_event)
4990         (windows_nat_target::get_tib_address)
4991         (windows_nat_target::thread_name)
4992         (windows_nat_target::thread_alive): Update.
4993
4994 2020-04-08  Tom Tromey  <tromey@adacore.com>
4995
4996         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4997         (windows_continue): Use windows_continue::resume.
4998         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4999         resume>: Declare new methods.
5000         * nat/windows-nat.c: New file.
5001         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
5002
5003 2020-04-08  Tom Tromey  <tromey@adacore.com>
5004
5005         * windows-nat.c (windows_add_thread, windows_delete_thread)
5006         (windows_nat_target::fetch_registers)
5007         (windows_nat_target::store_registers, fake_create_process)
5008         (windows_nat_target::resume, windows_nat_target::resume)
5009         (get_windows_debug_event, windows_nat_target::wait)
5010         (windows_nat_target::pid_to_str)
5011         (windows_nat_target::get_tib_address)
5012         (windows_nat_target::get_ada_task_ptid)
5013         (windows_nat_target::thread_name)
5014         (windows_nat_target::thread_alive): Use lwp, not tid.
5015
5016 2020-04-08  Tom Tromey  <tromey@adacore.com>
5017
5018         * windows-nat.c (handle_exception)
5019         (windows_nat_target::thread_name): Update.
5020         * nat/windows-nat.h (windows_thread_info): Remove destructor.
5021         <name>: Now unique_xmalloc_ptr.
5022
5023 2020-04-08  Tom Tromey  <tromey@adacore.com>
5024
5025         * windows-nat.c (thread_rec)
5026         (windows_nat_target::fetch_registers): Update.
5027         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
5028         Update comment.
5029         <debug_registers_changed, reload_context>: Now bool.
5030
5031 2020-04-08  Tom Tromey  <tromey@adacore.com>
5032
5033         * windows-nat.c (windows_add_thread): Use new.
5034         (windows_init_thread_list, windows_delete_thread): Use delete.
5035         (get_windows_debug_event): Update.
5036         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
5037         destructor, and initializers.
5038
5039 2020-04-08  Tom Tromey  <tromey@adacore.com>
5040
5041         * windows-nat.c (struct windows_thread_info): Remove.
5042         * nat/windows-nat.h: New file.
5043
5044 2020-04-08  Tom Tromey  <tromey@adacore.com>
5045
5046         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
5047         (thread_rec, windows_add_thread, windows_delete_thread)
5048         (windows_continue): Update.
5049
5050 2020-04-08  Tom Tromey  <tromey@adacore.com>
5051
5052         * windows-nat.c (struct windows_thread_info): Remove typedef.
5053         (thread_head): Remove.
5054         (thread_list): New global.
5055         (thread_rec, windows_add_thread, windows_init_thread_list)
5056         (windows_delete_thread, windows_continue): Update.
5057
5058 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5059
5060         * windows-tdep.h (windows_init_abi): Add comment.
5061         (cygwin_init_abi): New declaration.
5062         * windows-tdep.c: Split signal enumeration in two, one for
5063         Windows and one for Cygwin.
5064         (windows_gdb_signal_to_target): Only deal with signal of the
5065         Windows OS ABI.
5066         (cygwin_gdb_signal_to_target): New function.
5067         (windows_init_abi): Rename to windows_init_abi_common, don't set
5068         gdb_signal_to_target gdbarch method.  Add new new function with
5069         this name.
5070         (cygwin_init_abi): New function.
5071         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
5072         comment.  Don't call windows_init_abi.
5073         (amd64_windows_init_abi): Add comment, call windows_init_abi.
5074         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
5075         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
5076         i386_windows_init_abi_common, don't call windows_init_abi.  Add
5077         a new function of this name.
5078         (i386_cygwin_init_abi): New function.
5079         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
5080         OS ABI Cygwin.
5081
5082 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5083
5084         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
5085         parameter.c.
5086         (dwarf2_read_gdb_index): Update.
5087
5088 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
5089
5090         * nbsd-tdep.c: Include "objfiles.h".
5091         (nbsd_skip_solib_resolver): New.
5092         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
5093
5094 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5095
5096         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
5097         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
5098         with DW_LLE_base_addressx are being emitted in DWARFv5.
5099         Add the newly added kind DW_LOC_OFFSET_PAIR also.
5100         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
5101         unsigned integer.
5102
5103 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5104
5105         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
5106         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
5107         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
5108         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
5109         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
5110         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
5111         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
5112
5113
5114 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5115
5116         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
5117         (read_loclist_index): New function definition.
5118         (lookup_loclist_base): New function definition.
5119         (read_loclist_header): New function definition.
5120         (dwarf2_cu): Add loclist_base and loclist_header field.
5121         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
5122         (read_full_die_1): Read the value of DW_AT_loclists_base.
5123         (read_attribute_reprocess): Handle DW_FORM_loclistx.
5124         (read_attribute_value): Handle DW_FORM_loclistx.
5125         (skip_one_die): Handle DW_FORM_loclistx.
5126         (loclist_header): New structure declaration.
5127         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
5128
5129 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
5130
5131         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
5132         constructor.  Remove `addr` parameter from other constructor and
5133         add `per_cu` parameter.
5134         * dwarf2/read.c (create_partial_symtab): Update.
5135
5136 2020-04-07  Tom de Vries  <tdevries@suse.de>
5137
5138         PR symtab/25796
5139         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
5140         (partial_die_info::fixup): Inherit has_const_value.
5141
5142 2020-04-07  Tom de Vries  <tdevries@suse.de>
5143
5144         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
5145         symbols without address.
5146
5147 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5148
5149         * nbsd-nat.h (struct thread_info): Add forward declaration.
5150         (nbsd_nat_target::thread_alive): Add.
5151         (nbsd_nat_target::thread_name): Likewise.
5152         (nbsd_nat_target::update_thread_list): Likewise.
5153         (update_thread_list::post_attach): Likewise.
5154         (post_attach::pid_to_str): Likewise.
5155         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
5156         (nbsd_thread_lister): Add.
5157         (nbsd_nat_target::thread_alive): Likewise.
5158         (nbsd_nat_target::thread_name): Likewise.
5159         (nbsd_add_threads): Likewise.
5160         (update_thread_list::post_attach): Likewise.
5161         (nbsd_nat_target::update_thread_list): Likewise.
5162         (post_attach::pid_to_str): Likewise.
5163
5164 2020-04-06  Tom Tromey  <tromey@adacore.com>
5165
5166         * ada-valprint.c (print_variant_part): Extract the variant field.
5167         (print_field_values): Use the field as the outer value when
5168         recursing.
5169
5170 2020-04-06  Tom Tromey  <tromey@adacore.com>
5171
5172         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
5173         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
5174         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
5175         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
5176         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
5177
5178 2020-04-06  Tom Tromey  <tromey@adacore.com>
5179
5180         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
5181         TYPE_CODE_ERROR.
5182
5183 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5184
5185         * nbsd-tdep.c: Include "gdbarch.h".
5186         Define enum with NetBSD signal numbers.
5187         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
5188         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
5189         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
5190         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
5191         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
5192         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
5193         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
5194         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
5195         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
5196         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
5197         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
5198         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
5199
5200 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
5201
5202         PR gdb/25325
5203         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
5204
5205 2020-04-03  Tom Tromey  <tromey@adacore.com>
5206
5207         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
5208         Read constant block.
5209
5210 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5211
5212         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
5213         (gdb_bfd_get_full_section_contents): New declaration.
5214         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
5215         * windows-tdep.c (is_linked_with_cygwin_dll): Use
5216         gdb_bfd_get_full_section_contents.
5217
5218 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5219
5220         * exec.c (build_section_table): Replace internal_error with
5221         gdb_assert.
5222         (section_table_xfer_memory_partial): Likewise.
5223         * mdebugread.c (parse_partial_symbols): Likewise.
5224         * psymtab.c (lookup_partial_symbol): Likewise.
5225         * utils.c (wrap_here): Likewise.
5226
5227 2020-04-02  Tom Tromey  <tromey@adacore.com>
5228
5229         * f-lang.c (build_fortran_types): Use arch_type to initialize
5230         builtin_complex_s32 in the TYPE_CODE_ERROR case.
5231
5232 2020-04-02  Tom Tromey  <tromey@adacore.com>
5233
5234         * dwarf2/read.c (partial_die_info::read): Do not create a vector
5235         of attributes.
5236
5237 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5238             Bernd Edlinger <bernd.edlinger@hotmail.de>
5239             Tom Tromey  <tromey@adacore.com>
5240
5241         * buildsym.c (buildsym_compunit::record_line): Remove
5242         deduplication code.
5243
5244 2020-04-02  Tom de Vries  <tdevries@suse.de>
5245
5246         PR ada/24671
5247         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
5248
5249 2020-04-02  Tom de Vries  <tdevries@suse.de>
5250
5251         * dwarf2/read.c (dwarf2_gdb_index_functions,
5252         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
5253         NULL.
5254         * psymtab.c (psym_lookup_global_symbol_language): New function.
5255         (psym_functions): Init psym_lookup_global_symbol_language with
5256         psym_lookup_global_symbol_language.
5257         * symfile-debug.c (debug_sym_quick_functions): Init
5258         lookup_global_symbol_language with NULL.
5259         * symfile.c (set_initial_language): Remove fixme comment.
5260         * symfile.h (struct quick_symbol_functions): Add
5261         lookup_global_symbol_language.
5262         * symtab.c (find_quick_global_symbol_language): New function.
5263         (find_main_name): Use find_quick_global_symbol_language.
5264
5265 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
5266
5267         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
5268
5269 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5270
5271         * buildsym.c (record_line): Fix undefined behavior and preserve
5272         lines at eof.
5273
5274 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5275
5276         * buildsym.c (record_line): Fix the resizing condition.
5277
5278 2020-04-01  Tom Tromey  <tom@tromey.com>
5279
5280         * value.h (value_literal_complex): Add comment.
5281         * valops.c (value_literal_complex): Refer to value.h.
5282
5283 2020-04-01  Tom Tromey  <tom@tromey.com>
5284
5285         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
5286         (scalar_type): New rule, from typebase.
5287         (typebase): Use scalar_type.  Recognize complex types.
5288         (field_name): Handle FLOAT_KEYWORD.
5289         (ident_tokens): Add _Complex and __complex__.
5290
5291 2020-04-01  Tom Tromey  <tom@tromey.com>
5292
5293         PR exp/25299:
5294         * valarith.c (promotion_type, complex_binop): New functions.
5295         (scalar_binop): Handle complex numbers.  Use promotion_type.
5296         (value_pos, value_neg, value_complement): Handle complex numbers.
5297
5298 2020-04-01  Tom Tromey  <tom@tromey.com>
5299
5300         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
5301         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
5302         (parse_number): Handle complex numbers.
5303
5304 2020-04-01  Tom Tromey  <tom@tromey.com>
5305
5306         * c-valprint.c (c_decorations): Change complex suffix to "i".
5307
5308 2020-04-01  Tom Tromey  <tom@tromey.com>
5309
5310         * valprint.c (generic_value_print_complex): Use accessors.
5311         * value.h (value_real_part, value_imaginary_part): Declare.
5312         * valops.c (value_real_part, value_imaginary_part): New
5313         functions.
5314         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
5315
5316 2020-04-01  Tom Tromey  <tom@tromey.com>
5317
5318         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
5319         (read_range_type): Update.
5320         * mdebugread.c (basic_type): Update.
5321         * go-lang.c (build_go_types): Use init_complex_type.
5322         * gdbtypes.h (struct main_type) <complex_type>: New member.
5323         (init_complex_type): Update.
5324         (arch_complex_type): Don't declare.
5325         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
5326         Make name if none given.  Use alloc_type_copy.  Look for cached
5327         complex type.
5328         (arch_complex_type): Remove.
5329         (gdbtypes_post_init): Use init_complex_type.
5330         * f-lang.c (build_fortran_types): Use init_complex_type.
5331         * dwarf2/read.c (read_base_type): Update.
5332         * d-lang.c (build_d_types): Use init_complex_type.
5333         * ctfread.c (read_base_type): Update.
5334
5335 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5336
5337         * infrun.c (stop_all_threads): Update assertion, plus when
5338         stopping threads, take into account that we might be trying
5339         to stop an all-stop target.
5340         (stop_waiting): Call 'stop_all_threads' if there exists a
5341         non-stop target.
5342
5343 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5344
5345         * target.h (exists_non_stop_target): New function declaration.
5346         * target.c (exists_non_stop_target): New function.
5347
5348 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
5349
5350         PR gdb/24789
5351         * eval.c (is_integral_or_integral_reference): New function.
5352         (evaluate_subexp_standard): Allow integer references in
5353         pointer arithmetic.
5354
5355 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5356
5357         * remote.c (remote_target::remote_parse_stop_reply): Remove the
5358         check for no ptid in the stop reply when the target is non-stop.
5359
5360 2020-04-01  Tom Tromey  <tromey@adacore.com>
5361
5362         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
5363         "name" parameter to rvalue reference.  Initialize m_name_holder.
5364         <lookup_name_info>: New overloads.
5365         <name>: Return gdb::string_view.
5366         <c_str>: New method.
5367         <make_ignore_params>: Update.
5368         <search_name_hash>: Update.
5369         <language_lookup_name>: Return const char *.
5370         <m_name>: Change type.
5371         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
5372         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
5373         (lookup_name_info::match_any): Update.
5374         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
5375         Update.
5376         * minsyms.c (linkage_name_str): Update.
5377         * language.c (default_symbol_name_matcher): Update.
5378         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
5379         Update.
5380         * ada-lang.c (ada_fold_name): Change parameter to string_view.
5381         (ada_lookup_name_info::ada_lookup_name_info): Update.
5382         (literal_symbol_name_matcher): Update.
5383
5384 2020-04-01  Tom Tromey  <tromey@adacore.com>
5385
5386         * psymtab.c (psymtab_search_name): Remove function.
5387         (psym_lookup_symbol): Create search name and lookup name here.
5388         (lookup_partial_symbol): Remove "name" parameter; add
5389         lookup_name.
5390         (psym_expand_symtabs_for_function): Update.
5391
5392 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
5393
5394         PR tui/25597:
5395         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
5396
5397 2020-03-31  Tom Tromey  <tromey@adacore.com>
5398
5399         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
5400         memcpy.
5401
5402 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
5403
5404         * features/riscv/32bit-csr.xml: Regenerated.
5405         * features/riscv/64bit-csr.xml: Regenerated.
5406
5407 2020-03-30  Tom Tromey  <tromey@adacore.com>
5408
5409         * ada-valprint.c (print_variant_part): Update.
5410         * ada-lang.h (ada_which_variant_applies): Update.
5411         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
5412         outer_valaddr parameters; replace with "outer" value parameter.
5413         (to_fixed_variant_branch_type): Update.
5414
5415 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5416
5417         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
5418         <list>.  Remove inclusion of observable.h.
5419         (PPC_DEBUG_CURRENT_VERSION): Move up define.
5420         (struct arch_lwp_info): New struct.
5421         (class ppc_linux_dreg_interface): New class.
5422         (struct ppc_linux_process_info): New struct.
5423         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
5424         <low_new_clone, low_forget_process, low_prepare_to_resume>
5425         <copy_thread_dreg_state, mark_thread_stale>
5426         <mark_debug_registers_changed, register_hw_breakpoint>
5427         <clear_hw_breakpoint, register_wp, clear_wp>
5428         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
5429         <num_memory_accesses, get_trigger_type>
5430         <create_watchpoint_request, hwdebug_point_cmp>
5431         <init_arch_lwp_info, get_arch_lwp_info>
5432         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
5433         methods.
5434         <struct ptid_hash>: New inner struct.
5435         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
5436         members.
5437         (saved_dabr_value, hwdebug_info, max_slots_number)
5438         (struct hw_break_tuple, struct thread_points, ppc_threads)
5439         (have_ptrace_hwdebug_interface)
5440         (hwdebug_find_thread_points_by_tid)
5441         (hwdebug_insert_point, hwdebug_remove_point): Remove.
5442         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
5443         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
5444         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
5445         use m_dreg_interface.
5446         (hwdebug_point_cmp): Change to...
5447         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
5448         reference arguments instead of pointers.
5449         (ppc_linux_nat_target::ranged_break_num_registers): Use
5450         m_dreg_interface.
5451         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
5452         m_dreg_interface.  Call register_hw_breakpoint.
5453         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
5454         m_dreg_interface.  Call clear_hw_breakpoint.
5455         (get_trigger_type): Change to...
5456         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
5457         comment.
5458         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
5459         use m_dreg_interface.  Call register_hw_breakpoint.
5460         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
5461         use m_dreg_interface.  Call clear_hw_breakpoint.
5462         (can_use_watchpoint_cond_accel): Change to...
5463         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
5464         method.  Update comment, use m_dreg_interface and
5465         m_process_info.
5466         (calculate_dvc): Change to...
5467         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
5468         m_dreg_interface.
5469         (num_memory_accesses): Change to...
5470         (ppc_linux_nat_target::num_memory_accesses): ...this method.
5471         (check_condition): Change to...
5472         (ppc_linux_nat_target::check_condition): ...this method.
5473         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
5474         comment, use m_dreg_interface.
5475         (create_watchpoint_request): Change to...
5476         (ppc_linux_nat_target::create_watchpoint_request): ...this
5477         method.  Use m_dreg_interface.
5478         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
5479         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
5480         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
5481         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
5482         (ppc_linux_nat_target::low_forget_process)
5483         (ppc_linux_nat_target::low_new_fork)
5484         (ppc_linux_nat_target::low_new_clone)
5485         (ppc_linux_nat_target::low_delete_thread)
5486         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
5487         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
5488         only call mark_thread_stale.
5489         (ppc_linux_thread_exit): Remove.
5490         (ppc_linux_nat_target::stopped_data_address): Change to...
5491         (ppc_linux_nat_target::low_stopped_data_address): This. Add
5492         comment, use m_dreg_interface and m_thread_hw_breakpoints.
5493         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
5494         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
5495         comment.  Call low_stopped_data_address.
5496         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
5497         m_dreg_interface.
5498         (ppc_linux_nat_target::masked_watch_num_registers): Use
5499         m_dreg_interface.
5500         (ppc_linux_nat_target::copy_thread_dreg_state)
5501         (ppc_linux_nat_target::mark_thread_stale)
5502         (ppc_linux_nat_target::mark_debug_registers_changed)
5503         (ppc_linux_nat_target::register_hw_breakpoint)
5504         (ppc_linux_nat_target::clear_hw_breakpoint)
5505         (ppc_linux_nat_target::register_wp)
5506         (ppc_linux_nat_target::clear_wp)
5507         (ppc_linux_nat_target::init_arch_lwp_info)
5508         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
5509         (_initialize_ppc_linux_nat): Remove observer callback.
5510
5511 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5512
5513         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
5514         (ppc_linux_nat_target::auxv_parse)
5515         (ppc_linux_nat_target::read_description)
5516         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
5517         Move up.
5518
5519 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5520
5521         * linux-nat.h (low_new_clone): New method.
5522         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
5523
5524 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5525
5526         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
5527         (dbx_expand_psymtab): ... this.
5528         (start_psymtab): Update.
5529         * mdebugread.c (psymtab_to_symtab_1): Rename to...
5530         (mdebug_expand_psymtab): ... this.
5531         (parse_partial_symbols): Update.
5532         (new_psymtab): Update.
5533         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
5534         (xcoff_expand_psymtab): ... this.
5535         (xcoff_start_psymtab): Update.
5536
5537 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5538
5539         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
5540         <expand_dependencies>: ... this.
5541         * psymtab.c (partial_symtab::read_dependencies): Rename to...
5542         (partial_symtab::expand_dependencies): ... this.
5543         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
5544         Update.
5545         (dwarf2_psymtab::expand_psymtab): Update.
5546         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5547         * mdebugread.c (psymtab_to_symtab_1): Update.
5548         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5549
5550 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5551
5552         * psympriv.h (discard_psymtab): Remove.
5553         * dbxread.c (dbx_end_psymtab): Update.
5554         * xcoffread.c (xcoff_end_psymtab): Update.
5555
5556 2020-03-28  Tom Tromey  <tom@tromey.com>
5557
5558         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
5559         comment.
5560
5561 2020-03-28  Tom Tromey  <tom@tromey.com>
5562
5563         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
5564
5565 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
5566
5567         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5568
5569 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
5570
5571         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
5572
5573 2020-03-26  Tom Tromey  <tom@tromey.com>
5574
5575         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
5576         (mark_common_block_symbol_computed, read_tag_string_type)
5577         (attr_to_dynamic_prop, read_subrange_type): Update.
5578         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
5579         to be methods on struct attribute.
5580         (skip_one_die, process_imported_unit_die, read_namespace_alias)
5581         (read_call_site_scope, partial_die_info::read)
5582         (partial_die_info::read, lookup_die_type, follow_die_ref):
5583         Update.
5584         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
5585         from dwarf2_get_ref_die_offset.
5586         (attribute::constant_value): New method, from
5587         dwarf2_get_attr_constant_value.
5588         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
5589         Declare method.
5590         <constant_value>: New method.
5591
5592 2020-03-26  Tom Tromey  <tom@tromey.com>
5593
5594         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
5595         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
5596         (dwarf_type_encoding_name): Move to stringify.c.
5597         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
5598         * dwarf2/stringify.c: New file.
5599         * dwarf2/stringify.h: New file.
5600
5601 2020-03-26  Tom Tromey  <tom@tromey.com>
5602
5603         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
5604         Rewrite.
5605
5606 2020-03-26  Tom Tromey  <tom@tromey.com>
5607
5608         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
5609         methods.
5610         * dwarf2/read.c (lookup_addr_base): Move to die.h.
5611         (lookup_ranges_base): Likewise.
5612         (read_cutu_die_from_dwo, read_full_die_1): Update.
5613
5614 2020-03-26  Tom Tromey  <tom@tromey.com>
5615
5616         * dwarf2/read.c (read_import_statement, read_file_scope)
5617         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
5618         (read_lexical_block_scope, read_call_site_scope)
5619         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
5620         (handle_struct_member_die, process_structure_scope)
5621         (update_enumeration_type_from_children)
5622         (process_enumeration_scope, read_array_type, read_common_block)
5623         (read_namespace, read_module, read_subroutine_type): Update.
5624         (sibling_die): Remove.
5625
5626 2020-03-26  Tom Tromey  <tom@tromey.com>
5627
5628         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
5629         (build_type_psymtabs_reader, read_structure_type)
5630         (read_enumeration_type, read_full_die_1): Update.
5631         (dwarf2_attr_no_follow): Move to die.h.
5632         * dwarf2/die.h (struct die_info) <attr>: New method.
5633
5634 2020-03-26  Tom Tromey  <tom@tromey.com>
5635
5636         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
5637         <base_address>: Now an optional.
5638         (dwarf2_find_base_address, dwarf2_rnglists_process)
5639         (dwarf2_ranges_process, fill_in_loclist_baton)
5640         (dwarf2_symbol_mark_computed): Update.
5641
5642 2020-03-26  Tom Tromey  <tom@tromey.com>
5643
5644         * dwarf2/read.c (struct die_info): Move to die.h.
5645         * dwarf2/die.h: New file.
5646
5647 2020-03-26  Tom Tromey  <tom@tromey.com>
5648
5649         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
5650         * dwarf2/read.c
5651         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5652         Move to line-header.c.
5653         (read_checked_initial_length_and_offset, read_formatted_entries):
5654         Likewise.
5655         (dwarf_decode_line_header): Split into two.
5656         * dwarf2/line-header.c
5657         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5658         Move from read.c.
5659         (read_checked_initial_length_and_offset, read_formatted_entries):
5660         Likewise.
5661         (dwarf_decode_line_header): New function, split from read.c.
5662
5663 2020-03-26  Tom Tromey  <tom@tromey.com>
5664
5665         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
5666         Declare method.
5667         * dwarf2/read.c (read_attribute_value): Update.
5668         (dwarf2_per_objfile::read_line_string): Rename from
5669         read_indirect_line_string.
5670         (read_formatted_entries): Update.
5671
5672 2020-03-26  Tom Tromey  <tom@tromey.com>
5673
5674         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
5675         variable.
5676
5677 2020-03-26  Tom Tromey  <tom@tromey.com>
5678
5679         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
5680         const.
5681         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
5682         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
5683         parameter const.
5684
5685 2020-03-26  Tom Tromey  <tom@tromey.com>
5686
5687         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
5688         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
5689         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
5690         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
5691
5692 2020-03-26  Tom Tromey  <tom@tromey.com>
5693
5694         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
5695         file_names_size, file_full_name, file_file_name>: Use const.
5696         <file_name_at, file_names>: Add const overload.
5697         * dwarf2/line-header.c (line_header::file_file_name)
5698         (line_header::file_full_name): Update.
5699
5700 2020-03-26  Tom Tromey  <tom@tromey.com>
5701
5702         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
5703         (macro_start_file, consume_improper_spaces)
5704         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
5705         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
5706         (dwarf_decode_macros): Move to macro.c.
5707         * dwarf2/macro.c: New file.
5708         * dwarf2/macro.h: New file.
5709         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
5710
5711 2020-03-26  Tom Tromey  <tom@tromey.com>
5712
5713         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
5714         method.
5715         * dwarf2/section.c: New method.  From
5716         read_indirect_string_at_offset_from.
5717         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
5718         (read_indirect_string_at_offset_from): Move to section.c.
5719         (read_indirect_string_at_offset): Rewrite.
5720         (read_indirect_line_string_at_offset): Remove.
5721         (read_indirect_string, read_indirect_line_string)
5722         (dwarf_decode_macro_bytes): Update.
5723
5724 2020-03-26  Tom Tromey  <tom@tromey.com>
5725
5726         * dwarf2/section.h (struct dwarf2_section_info)
5727         <overload_complaint>: Declare.
5728         (dwarf2_section_buffer_overflow_complaint): Don't declare.
5729         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
5730         Rename from dwarf2_section_buffer_overflow_complaint.
5731         * dwarf2/read.c (skip_one_die, partial_die_info::read)
5732         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
5733
5734 2020-03-26  Tom Tromey  <tom@tromey.com>
5735
5736         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
5737         Declare.
5738         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
5739         Move from read.c.
5740         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
5741         to section.c.
5742
5743 2020-03-26  Tom Tromey  <tom@tromey.com>
5744
5745         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
5746
5747 2020-03-26  Tom Tromey  <tom@tromey.com>
5748
5749         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
5750         "builder".
5751         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
5752         parameter.
5753         (dwarf_decode_macros): Update.
5754
5755 2020-03-26  Tom Tromey  <tom@tromey.com>
5756
5757         * dwarf2/read.c (read_attribute_value): Update.
5758         (read_indirect_string_from_dwz): Move to dwz.c; change into
5759         method.
5760         (dwarf_decode_macro_bytes): Update.
5761         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
5762         * dwarf2/dwz.c: New file.
5763         * Makefile.in (COMMON_SFILES): Add dwz.c.
5764
5765 2020-03-26  Tom Tromey  <tom@tromey.com>
5766
5767         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
5768         * dwarf2/read.c: Add include.
5769         * dwarf2/index-write.c: Add include.
5770         * dwarf2/index-cache.c: Add include.
5771         * dwarf2/dwz.h: New file.
5772
5773 2020-03-25  Tom Tromey  <tom@tromey.com>
5774
5775         * compile/compile-object-load.c (get_out_value_type): Mention
5776         correct symbol name in error message.
5777
5778 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
5779
5780         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5781
5782 2020-03-25  Tom de Vries  <tdevries@suse.de>
5783
5784         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
5785         * symmisc.c (dump_symtab_1): Print user and includes fields.
5786         (maintenance_info_symtabs): Same.
5787
5788 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
5789
5790         PR gdb/25534
5791         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
5792         (riscv_regcache_cooked_write): New function.
5793         (riscv_push_dummy_call): Use new function.
5794         (riscv_return_value): Likewise.
5795
5796 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
5797
5798         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
5799         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
5800         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
5801         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
5802         * infrun.c (follow_fork): Likewise.
5803         (follow_fork_inferior): Likewise.
5804         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
5805         * linux-nat.h (class linux_nat_target): Likewise.
5806         * remote.c (class remote_target) <follow_fork>: Likewise.
5807         (remote_target::follow_fork): Likewise.
5808         * target-delegates.c: Re-generate.
5809         * target.c (default_follow_fork): Likewise.
5810         (target_follow_fork): Likewise.
5811         * target.h (struct target_ops) <follow_fork>: Likewise.
5812         (target_follow_fork): Likewise.
5813
5814 2020-03-24  Tom de Vries  <tdevries@suse.de>
5815
5816         * psymtab.c (maintenance_info_psymtabs): Print user field.
5817
5818 2020-03-20  Tom Tromey  <tromey@adacore.com>
5819
5820         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
5821         const.
5822         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
5823         const.
5824
5825 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
5826
5827         * ptrace.m4: Don't check for ptrace declaration.
5828         * config.in: Re-generate.
5829         * configure: Re-generate.
5830         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
5831         not defined.
5832
5833 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5834
5835         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
5836         `PTRACE_TYPE_RET'.
5837         * i386-bsd-nat.c (gdb_ptrace): Likewise.
5838         * sparc-nat.c (gdb_ptrace): Likewise.
5839         * x86-bsd-nat.c (gdb_ptrace): Likewise.
5840
5841 2020-03-20  Tom Tromey  <tromey@adacore.com>
5842
5843         * c-exp.y (lex_one_token): Fix assert.
5844
5845 2020-03-20  Tom Tromey  <tromey@adacore.com>
5846
5847         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
5848         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
5849         strncpy call.
5850
5851 2020-03-20  Tom Tromey  <tromey@adacore.com>
5852
5853         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
5854
5855 2020-03-20  Tom Tromey  <tromey@adacore.com>
5856
5857         * ada-valprint.c (print_variant_part): Remove parameters; switch
5858         to value-based API.
5859         (print_field_values): Likewise.
5860         (ada_val_print_struct_union): Likewise.
5861         (ada_value_print_1): Update.
5862
5863 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5864
5865         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
5866         nbsd_nat_target instead of inf_ptrace_target.
5867         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5868         nbsd_nat_target.
5869
5870 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5871
5872         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
5873         it to the ptrace call.
5874         * (store_registers): Likewise.
5875
5876 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5877
5878         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
5879         it to the ptrace call.
5880         * (store_registers): Likewise.
5881
5882 2020-03-19  Luis Machado  <luis.machado@linaro.org>
5883
5884         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
5885         valid, fetch vg value from ptrace.
5886
5887 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5888         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
5889         * inf-ptrace.c: Likewise.
5890         * (gdb_ptrace): Add.
5891         * (inf_ptrace_target::resume): Update.
5892         * (inf_ptrace_target::xfer_partial): Likewise.
5893         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
5894         * (inf_ptrace_peek_poke): Update.
5895
5896 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5897
5898         * x86-bsd-nat.c (gdb_ptrace): New.
5899         * (x86bsd_dr_set): Add new argument `ptid'.
5900         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
5901         x86bsd_dr_set_addr): Update.
5902
5903 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * remote.c (remote_target::process_stop_reply): Handle events for
5906         all threads differently.
5907
5908 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5909
5910         * completer.c (completion_tracker::remove_completion): Define new
5911         function.
5912         * completer.h (completion_tracker::remove_completion): Declare new
5913         function.
5914         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
5915         when adding a C++ function symbol.
5916
5917 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5918
5919         * completer.c (completion_tracker::completion_hash_entry): Define
5920         new class.
5921         (advance_to_filename_complete_word_point): Call
5922         recompute_lowest_common_denominator.
5923         (completion_tracker::completion_tracker): Call discard_completions
5924         to setup the hash table.
5925         (completion_tracker::discard_completions): Allow for being called
5926         from the constructor, pass new equal function, and element deleter
5927         when constructing the hash table.  Initialise new class member
5928         variables.
5929         (completion_tracker::maybe_add_completion): Remove use of
5930         m_entries_vec, and store more information into m_entries_hash.
5931         (completion_tracker::recompute_lcd_visitor): New function, most
5932         content taken from...
5933         (completion_tracker::recompute_lowest_common_denominator):
5934         ...here, this now just visits each item in the hash calling the
5935         above visitor.
5936         (completion_tracker::build_completion_result): Remove use of
5937         m_entries_vec, call recompute_lowest_common_denominator.
5938         * completer.h (completion_tracker::have_completions): Remove use
5939         of m_entries_vec.
5940         (completion_tracker::completion_hash_entry): Declare new class.
5941         (completion_tracker::recompute_lowest_common_denominator): Change
5942         function signature.
5943         (completion_tracker::recompute_lcd_visitor): Declare new function.
5944         (completion_tracker::m_entries_vec): Delete.
5945         (completion_tracker::m_entries_hash): Initialize to NULL.
5946         (completion_tracker::m_lowest_common_denominator_valid): New
5947         member variable.
5948         (completion_tracker::m_lowest_common_denominator_max_length): New
5949         member variable.
5950
5951 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5952
5953         * regformats/regdef.h: Put reg in gdb namespace.
5954
5955 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5956
5957         * i386-bsd-nat.c (gdb_ptrace): New.
5958         * (i386bsd_fetch_inferior_registers,
5959         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5960         * (i386bsd_fetch_inferior_registers,
5961         i386bsd_store_inferior_registers) Use gdb_ptrace.
5962
5963 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5964
5965         * amd64-bsd-nat.c (gdb_ptrace): New.
5966         * (amd64bsd_fetch_inferior_registers,
5967         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5968         * (amd64bsd_fetch_inferior_registers,
5969         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5970
5971 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5972
5973         * user-regs.c (user_reg::read): Rename to...
5974         (user_reg::xread): ...this.
5975         * (append_user_reg): Rename argument `read' to `xread'.
5976         * (user_reg_add_builtin): Likewise.
5977         * (user_reg_add): Likewise.
5978         * (value_of_user_reg): Likewise.
5979
5980 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5981
5982         * sparc-nat.c (gdb_ptrace): New.
5983         * sparc-nat.c (sparc_fetch_inferior_registers)
5984         (sparc_store_inferior_registers) Remove obsolete comment.
5985         * sparc-nat.c (sparc_fetch_inferior_registers)
5986         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5987         * sparc-nat.c (sparc_fetch_inferior_registers)
5988         (sparc_store_inferior_registers) Use gdb_ptrace.
5989
5990 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5991
5992         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5993         it to the ptrace call.
5994         * sh-nbsd-nat.c (store_registers): Likewise.
5995
5996 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5997
5998         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5999         nbsd_nat_target instead of inf_ptrace_target.
6000         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6001         nbsd_nat_target.
6002
6003 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6004
6005         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
6006
6007 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6008
6009         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
6010         <sys/sysctl.h>.
6011         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
6012
6013 2020-03-17  Tom de Vries  <tdevries@suse.de>
6014
6015         PR gdb/23710
6016         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
6017         fields.
6018         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
6019         fields.
6020         (process_imported_unit_die): Skip import of c++ CUs.
6021
6022 2020-03-16  Tom Tromey  <tom@tromey.com>
6023
6024         * p-valprint.c (pascal_object_print_value): Initialize
6025         base_value.
6026
6027 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
6028             Shahab Vahedi  <shahab@synopsys.com>
6029
6030         * Makefile.in: Add arch/arc.o
6031         * configure.tgt: Likewise.
6032         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
6033         (_initialize_arc_tdep): Don't initialize old target descriptions.
6034         (arc_read_description): New function to cache target descriptions.
6035         * arc-tdep.h (arc_read_description): Add proto type.
6036         * arch/arc.c: New file.
6037         * arch/arc.h: Likewise.
6038         * features/Makefile: Replace old target descriptions with new.
6039         * features/arc-arcompact.c: Remove.
6040         * features/arc-arcompact.xml: Likewise.
6041         * features/arc-v2.c: Likewise
6042         * features/arc-v2.xml: Likewise
6043         * features/arc/aux-arcompact.xml: New file.
6044         * features/arc/aux-v2.xml: Likewise.
6045         * features/arc/core-arcompact.xml: Likewise.
6046         * features/arc/core-v2.xml: Likewise.
6047         * features/arc/aux-arcompact.c: Generate.
6048         * features/arc/aux-v2.c: Likewise.
6049         * features/arc/core-arcompact.c: Likewise.
6050         * features/arc/core-v2.c: Likewise.
6051         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
6052
6053 2020-03-16  Tom Tromey  <tromey@adacore.com>
6054
6055         PR gdb/25663:
6056         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
6057         putting value into bcache.
6058
6059 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6060
6061         PR gdb/21500
6062         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
6063         to...
6064         (amd64_windows_init_abi_common): ... this.  Don't set size of
6065         long type.
6066         (amd64_windows_init_abi): New function.
6067         (amd64_cygwin_init_abi): New function.
6068         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
6069         the Cygwin OS ABI.
6070         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
6071         comment.
6072
6073 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6074
6075         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
6076         * windows-tdep.c (CYGWIN_DLL_NAME): New.
6077         (pe_import_directory_entry): New struct type.
6078         (is_linked_with_cygwin_dll): New function.
6079         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
6080         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
6081         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
6082
6083 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6084
6085         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
6086         i386_cygwin_core_osabi_sniffer.
6087
6088 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6089
6090         * i386-cygwin-tdep.c: Rename to...
6091         * i386-windows-tdep.c: ... this.
6092         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
6093         i386-windows-tdep.c.
6094         * configure.tgt: Likewise.
6095
6096 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6097
6098         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
6099         * osabi.c (gdb_osabi_names): Add "Windows".
6100         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
6101         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
6102         (i386_cygwin_core_osabi_sniffer): New function, extracted from
6103         i386_cygwin_osabi_sniffer.
6104         (_initialize_i386_cygwin_tdep): Register OS ABI
6105         GDB_OSABI_WINDOWS for i386.
6106         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
6107         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
6108         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
6109         for x86-64.
6110         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
6111         when the target matches '*-*-mingw*'.
6112
6113 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6114
6115         * defs.h (enum gdb_osabi): Move to...
6116         * osabi.h (enum gdb_osabi): ... here.
6117         * gdbarch.sh: Include osabi.h in gdbarch.h.
6118         * gdbarch.h: Re-generate.
6119
6120 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6121
6122         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
6123         function.
6124         (_initialize_amd64_windows_tdep): Register osabi sniffer.
6125
6126 2020-03-14  Tom Tromey  <tom@tromey.com>
6127
6128         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
6129         for C++.
6130         (c_type_print_modifier): Likewise.  Add "language" parameter.
6131         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
6132         (c_type_print_base_1): Update.
6133         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
6134         constants.
6135         * type-stack.c (type_stack::insert): Handle tp_atomic and
6136         tp_restrict.
6137         (type_stack::follow_type_instance_flags): Likewise.
6138         (type_stack::follow_types): Likewise.  Merge type-following code.
6139         * c-exp.y (RESTRICT, ATOMIC): New tokens.
6140         (space_identifier, cv_with_space_id)
6141         (const_or_volatile_or_space_identifier_noopt)
6142         (const_or_volatile_or_space_identifier): Remove.
6143         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
6144         rules.
6145         (ptr_operator, typebase): Update.
6146         (enum token_flag) <FLAG_C>: New constant.
6147         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
6148         "_Atomic".
6149         (lex_one_token): Handle FLAG_C.
6150
6151 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6152
6153         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
6154         it to the ptrace call.
6155         * m68k-bsd-nat.c (store_registers): Likewise.
6156
6157 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6158
6159         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
6160         gdb_byte *.
6161         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
6162         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
6163         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
6164
6165 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6166
6167         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
6168         nbsd_nat_target instead of inf_ptrace_target.
6169         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6170         nbsd_nat_target.
6171
6172 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6173
6174         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
6175         register_t.
6176
6177 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6178
6179         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
6180         it to the ptrace call.
6181         * alpha-bsd-nat.c (store_registers): Likewise.
6182
6183 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6184
6185         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
6186         includes.
6187         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
6188         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
6189         fill_fpregset): Likewise.
6190
6191 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6192
6193         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
6194         nbsd_nat_target instead of inf_ptrace_target.
6195         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6196         nbsd_nat_target.
6197
6198 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6199
6200         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
6201         register_t.
6202
6203 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6204
6205         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
6206         it to the ptrace call.
6207         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
6208         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
6209         * arm-nbsd-nat.c (store_register): Likewise.
6210         * arm-nbsd-nat.c (store_regs): Likewise.
6211         * arm-nbsd-nat.c (store_fp_register): Likewise.
6212         * arm-nbsd-nat.c (store_fp_regs): Likewise.
6213
6214 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6215
6216         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
6217         nbsd_nat_target instead of inf_ptrace_target.
6218         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6219         nbsd_nat_target.
6220
6221 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6222
6223         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
6224         it to the ptrace call.
6225         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
6226
6227 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6228
6229         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
6230         it to the ptrace call.
6231         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
6232
6233 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6234
6235         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
6236         gdb_byte *.
6237         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
6238
6239 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6240
6241         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
6242         instead of inf_ptrace_target.
6243         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6244         nbsd_nat_target.
6245
6246 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6247
6248         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6249         register_t.
6250
6251 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6252
6253         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6254         register_t.
6255
6256 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6257
6258         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
6259         register_t.
6260
6261 2020-03-13  Tom Tromey  <tom@tromey.com>
6262
6263         * value.h (val_print): Don't declare.
6264         * valprint.h (val_print_array_elements)
6265         (val_print_scalar_formatted, generic_val_print): Don't declare.
6266         * valprint.c (generic_val_print_array): Take a struct value.
6267         (generic_val_print_ptr, generic_val_print_memberptr)
6268         (generic_val_print_bool, generic_val_print_int)
6269         (generic_val_print_char, generic_val_print_complex)
6270         (generic_val_print): Remove.
6271         (generic_value_print): Update.
6272         (do_val_print): Remove unused parameters.  Don't call
6273         la_val_print.
6274         (val_print): Remove.
6275         (common_val_print): Update.  Don't call value_check_printable.
6276         (val_print_scalar_formatted, val_print_array_elements): Remove.
6277         * rust-lang.c (rust_val_print): Remove.
6278         (rust_language_defn): Update.
6279         * p-valprint.c (pascal_val_print): Remove.
6280         (pascal_value_print_inner): Update.
6281         (pascal_object_print_val_fields, pascal_object_print_val):
6282         Remove.
6283         (pascal_object_print_static_field): Update.
6284         * p-lang.h (pascal_val_print): Don't declare.
6285         * p-lang.c (pascal_language_defn): Update.
6286         * opencl-lang.c (opencl_language_defn): Update.
6287         * objc-lang.c (objc_language_defn): Update.
6288         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
6289         * m2-lang.h (m2_val_print): Don't declare.
6290         * m2-lang.c (m2_language_defn): Update.
6291         * language.h (struct language_defn) <la_val_print>: Remove.
6292         * language.c (unk_lang_value_print_inner): Rename.  Change
6293         argument types.
6294         (unknown_language_defn, auto_language_defn): Update.
6295         * go-valprint.c (go_val_print): Remove.
6296         * go-lang.h (go_val_print): Don't declare.
6297         * go-lang.c (go_language_defn): Update.
6298         * f-valprint.c (f_val_print): Remove.
6299         * f-lang.h (f_value_print): Don't declare.
6300         * f-lang.c (f_language_defn): Update.
6301         * d-valprint.c (d_val_print): Remove.
6302         * d-lang.h (d_value_print): Don't declare.
6303         * d-lang.c (d_language_defn): Update.
6304         * cp-valprint.c (cp_print_value_fields)
6305         (cp_print_value_fields_rtti, cp_print_value): Remove.
6306         (cp_print_static_field): Update.
6307         * c-valprint.c (c_val_print_array, c_val_print_ptr)
6308         (c_val_print_struct, c_val_print_union, c_val_print_int)
6309         (c_val_print_memberptr, c_val_print): Remove.
6310         * c-lang.h (c_val_print_array, cp_print_value_fields)
6311         (cp_print_value_fields_rtti): Don't declare.
6312         * c-lang.c (c_language_defn, cplus_language_defn)
6313         (asm_language_defn, minimal_language_defn): Update.
6314         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
6315         (ada_val_print_enum): Take a struct value.
6316         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
6317         (ada_val_print): Remove.
6318         (ada_value_print_1): Update.
6319         (printable_val_type): Remove.
6320         * ada-lang.h (ada_val_print): Don't declare.
6321         * ada-lang.c (ada_language_defn): Update.
6322
6323 2020-03-13  Tom Tromey  <tom@tromey.com>
6324
6325         * valprint.c (do_val_print): Update.
6326         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
6327         a struct value.
6328         (value_to_value_object_no_release): Declare.
6329         * python/py-value.c (value_to_value_object_no_release): New
6330         function.
6331         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
6332         struct value.
6333         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
6334         function.
6335         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
6336         a struct value.
6337         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
6338         Declare.
6339         (gdbscm_apply_val_pretty_printer): Take a struct value.
6340         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
6341         value.
6342         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
6343         value.
6344         * extension-priv.h (struct extension_language_ops)
6345         <apply_val_pretty_printer>: Take a struct value.
6346         * cp-valprint.c (cp_print_value): Create a struct value.
6347         (cp_print_value): Update.
6348
6349 2020-03-13  Tom Tromey  <tom@tromey.com>
6350
6351         * ada-valprint.c (print_field_values): Call common_val_print.
6352
6353 2020-03-13  Tom Tromey  <tom@tromey.com>
6354
6355         * ada-valprint.c (val_print_packed_array_elements): Remove
6356         bitoffset and val parameters.  Call common_val_print.
6357         (ada_val_print_string): Remove offset, address, and original_value
6358         parameters.
6359         (ada_val_print_array): Update.
6360         (ada_value_print_array): New function.
6361         (ada_value_print_1): Call it.
6362
6363 2020-03-13  Tom Tromey  <tom@tromey.com>
6364
6365         * ada-valprint.c (ada_value_print): Use common_val_print.
6366
6367 2020-03-13  Tom Tromey  <tom@tromey.com>
6368
6369         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
6370
6371 2020-03-13  Tom Tromey  <tom@tromey.com>
6372
6373         * ada-valprint.c (ada_value_print_num): New function.
6374         (ada_value_print_1): Use it.
6375
6376 2020-03-13  Tom Tromey  <tom@tromey.com>
6377
6378         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
6379
6380 2020-03-13  Tom Tromey  <tom@tromey.com>
6381
6382         * ada-valprint.c (ada_value_print_ptr): New function.
6383         (ada_value_print_1): Use it.
6384
6385 2020-03-13  Tom Tromey  <tom@tromey.com>
6386
6387         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
6388         call common_val_print.
6389         (ada_val_print_1): Update.
6390         (ada_value_print_1): New function.
6391         (ada_value_print_inner): Rewrite.
6392
6393 2020-03-13  Tom Tromey  <tom@tromey.com>
6394
6395         * cp-valprint.c (cp_print_value_fields): Update.
6396         (cp_print_value): New function.
6397
6398 2020-03-13  Tom Tromey  <tom@tromey.com>
6399
6400         * m2-valprint.c (m2_value_print_inner): Use
6401         cp_print_value_fields.
6402         * cp-valprint.c (cp_print_value_fields): New function.
6403         * c-valprint.c (c_value_print_struct): New function.
6404         (c_value_print_inner): Use c_value_print_struct.
6405         * c-lang.h (cp_print_value_fields): Declare.
6406
6407 2020-03-13  Tom Tromey  <tom@tromey.com>
6408
6409         * c-valprint.c (c_value_print_array): New function.
6410         (c_value_print_inner): Use it.
6411
6412 2020-03-13  Tom Tromey  <tom@tromey.com>
6413
6414         * c-valprint.c (c_value_print_memberptr): New function.
6415         (c_value_print_inner): Use it.
6416
6417 2020-03-13  Tom Tromey  <tom@tromey.com>
6418
6419         * c-valprint.c (c_value_print_int): New function.
6420         (c_value_print_inner): Use it.
6421
6422 2020-03-13  Tom Tromey  <tom@tromey.com>
6423
6424         * c-valprint.c (c_value_print_ptr): New function.
6425         (c_value_print_inner): Use it.
6426
6427 2020-03-13  Tom Tromey  <tom@tromey.com>
6428
6429         * c-valprint.c (c_value_print_inner): Rewrite.
6430
6431 2020-03-13  Tom Tromey  <tom@tromey.com>
6432
6433         * valprint.c (generic_value_print_complex): New function.
6434         (generic_value_print): Use it.
6435
6436 2020-03-13  Tom Tromey  <tom@tromey.com>
6437
6438         * valprint.c (generic_val_print_float): Don't call
6439         val_print_scalar_formatted.
6440         (generic_val_print, generic_value_print): Update.
6441
6442 2020-03-13  Tom Tromey  <tom@tromey.com>
6443
6444         * valprint.c (generic_value_print_char): New function
6445         (generic_value_print): Use it.
6446
6447 2020-03-13  Tom Tromey  <tom@tromey.com>
6448
6449         * valprint.c (generic_value_print_int): New function.
6450         (generic_value_print): Use it.
6451
6452 2020-03-13  Tom Tromey  <tom@tromey.com>
6453
6454         * valprint.c (generic_value_print_bool): New function.
6455         (generic_value_print): Use it.
6456
6457 2020-03-13  Tom Tromey  <tom@tromey.com>
6458
6459         * valprint.c (generic_val_print_func): Simplify.
6460         (generic_val_print, generic_value_print): Update.
6461
6462 2020-03-13  Tom Tromey  <tom@tromey.com>
6463
6464         * valprint.c (generic_val_print_flags): Remove.
6465         (generic_val_print, generic_value_print): Update.
6466         (val_print_type_code_flags): Add original_value parameter.
6467
6468 2020-03-13  Tom Tromey  <tom@tromey.com>
6469
6470         * valprint.c (generic_val_print): Update.
6471         (generic_value_print): Update.
6472         * valprint.c (generic_val_print_enum): Don't call
6473         val_print_scalar_formatted.
6474
6475 2020-03-13  Tom Tromey  <tom@tromey.com>
6476
6477         * valprint.c (generic_value_print): Call generic_value_print_ptr.
6478         * valprint.c (generic_value_print_ptr): New function.
6479
6480 2020-03-13  Tom Tromey  <tom@tromey.com>
6481
6482         * valprint.c (generic_value_print): Rewrite.
6483
6484 2020-03-13  Tom Tromey  <tom@tromey.com>
6485
6486         * p-valprint.c (pascal_object_print_value_fields)
6487         (pascal_object_print_value): New functions.
6488
6489 2020-03-13  Tom Tromey  <tom@tromey.com>
6490
6491         * p-valprint.c (pascal_value_print_inner): Rewrite.
6492
6493 2020-03-13  Tom Tromey  <tom@tromey.com>
6494
6495         * f-valprint.c (f_value_print_innner): Rewrite.
6496
6497 2020-03-13  Tom Tromey  <tom@tromey.com>
6498
6499         * m2-valprint.c (m2_print_unbounded_array): New overload.
6500         (m2_print_unbounded_array): Update.
6501         (m2_print_array_contents): Take a struct value.
6502         (m2_value_print_inner): Rewrite.
6503
6504 2020-03-13  Tom Tromey  <tom@tromey.com>
6505
6506         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
6507         (d_value_print_inner): New function.
6508         * d-lang.h (d_value_print_inner): Declare.
6509         * d-lang.c (d_language_defn): Use d_value_print_inner.
6510
6511 2020-03-13  Tom Tromey  <tom@tromey.com>
6512
6513         * go-valprint.c (go_value_print_inner): New function.
6514         * go-lang.h (go_value_print_inner): Declare.
6515         * go-lang.c (go_language_defn): Use go_value_print_inner.
6516
6517 2020-03-13  Tom Tromey  <tom@tromey.com>
6518
6519         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
6520         API.
6521         (rust_val_print): Rewrite.
6522         (rust_value_print_inner): New function, from rust_val_print.
6523         (rust_language_defn): Use rust_value_print_inner.
6524
6525 2020-03-13  Tom Tromey  <tom@tromey.com>
6526
6527         * ada-valprint.c (ada_value_print_inner): New function.
6528         * ada-lang.h (ada_value_print_inner): Declare.
6529         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
6530
6531 2020-03-13  Tom Tromey  <tom@tromey.com>
6532
6533         * f-valprint.c (f_value_print_innner): New function.
6534         * f-lang.h (f_value_print_innner): Declare.
6535         * f-lang.c (f_language_defn): Use f_value_print_innner.
6536
6537 2020-03-13  Tom Tromey  <tom@tromey.com>
6538
6539         * p-valprint.c (pascal_value_print_inner): New function.
6540         * p-lang.h (pascal_value_print_inner): Declare.
6541         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
6542
6543 2020-03-13  Tom Tromey  <tom@tromey.com>
6544
6545         * m2-valprint.c (m2_value_print_inner): New function.
6546         * m2-lang.h (m2_value_print_inner): Declare.
6547         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
6548
6549 2020-03-13  Tom Tromey  <tom@tromey.com>
6550
6551         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
6552         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
6553         * c-valprint.c (c_value_print_inner): New function.
6554         * c-lang.h (c_value_print_inner): Declare.
6555         * c-lang.c (c_language_defn, cplus_language_defn)
6556         (asm_language_defn, minimal_language_defn): Use
6557         c_value_print_inner.
6558
6559 2020-03-13  Tom Tromey  <tom@tromey.com>
6560
6561         * p-valprint.c (pascal_object_print_value_fields): Now static.
6562         * p-lang.h (pascal_object_print_value_fields): Don't declare.
6563
6564 2020-03-13  Tom Tromey  <tom@tromey.com>
6565
6566         * c-valprint.c (c_val_print_array): Simplify.
6567
6568 2020-03-13  Tom Tromey  <tom@tromey.com>
6569
6570         * valprint.c (value_print_array_elements): New function.
6571         * valprint.h (value_print_array_elements): Declare.
6572
6573 2020-03-13  Tom Tromey  <tom@tromey.com>
6574
6575         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
6576         * mips-tdep.c (mips_print_register): Use
6577         value_print_scalar_formatted.
6578
6579 2020-03-13  Tom Tromey  <tom@tromey.com>
6580
6581         * valprint.h (value_print_scalar_formatted): Declare.
6582         * valprint.c (value_print_scalar_formatted): New function.
6583
6584 2020-03-13  Tom Tromey  <tom@tromey.com>
6585
6586         * valprint.h (generic_value_print): Declare.
6587         * valprint.c (generic_value_print): New function.
6588
6589 2020-03-13  Tom Tromey  <tom@tromey.com>
6590
6591         * valprint.c (do_val_print): Call la_value_print_inner, if
6592         available.
6593         * rust-lang.c (rust_language_defn): Update.
6594         * p-lang.c (pascal_language_defn): Update.
6595         * opencl-lang.c (opencl_language_defn): Update.
6596         * objc-lang.c (objc_language_defn): Update.
6597         * m2-lang.c (m2_language_defn): Update.
6598         * language.h (struct language_defn) <la_value_print_inner>: New
6599         member.
6600         * language.c (unknown_language_defn, auto_language_defn): Update.
6601         * go-lang.c (go_language_defn): Update.
6602         * f-lang.c (f_language_defn): Update.
6603         * d-lang.c (d_language_defn): Update.
6604         * c-lang.c (c_language_defn, cplus_language_defn)
6605         (asm_language_defn, minimal_language_defn): Update.
6606         * ada-lang.c (ada_language_defn): Update.
6607
6608 2020-03-13  Tom Tromey  <tom@tromey.com>
6609
6610         * c-valprint.c (c_value_print): Use common_val_print.
6611
6612 2020-03-13  Tom Tromey  <tom@tromey.com>
6613
6614         * cp-valprint.c (cp_print_static_field): Use common_val_print.
6615
6616 2020-03-13  Tom Tromey  <tom@tromey.com>
6617
6618         * f-valprint.c (f77_print_array_1, f_val_print): Use
6619         common_val_print.
6620
6621 2020-03-13  Tom Tromey  <tom@tromey.com>
6622
6623         * riscv-tdep.c (riscv_print_one_register_info): Use
6624         common_val_print.
6625
6626 2020-03-13  Tom Tromey  <tom@tromey.com>
6627
6628         * mi/mi-main.c (output_register): Use common_val_print.
6629
6630 2020-03-13  Tom Tromey  <tom@tromey.com>
6631
6632         * infcmd.c (default_print_one_register_info): Use
6633         common_val_print.
6634
6635 2020-03-13  Tom Tromey  <tom@tromey.com>
6636
6637         * valprint.h (common_val_print_checked): Declare.
6638         * valprint.c (common_val_print_checked): New function.
6639         * stack.c (print_frame_arg): Use common_val_print_checked.
6640
6641 2020-03-13  Tom Tromey  <tom@tromey.com>
6642
6643         * valprint.c (do_val_print): New function, from val_print.
6644         (val_print): Use do_val_print.
6645         (common_val_print): Use do_val_print.
6646
6647 2020-03-13  Tom Tromey  <tom@tromey.com>
6648
6649         * valprint.c (value_print): Use scoped_value_mark.
6650
6651 2020-03-13  Tom de Vries  <tdevries@suse.de>
6652
6653         PR symtab/25646
6654         * psymtab.c (partial_symtab::partial_symtab): Don't set
6655         globals_offset and statics_offset.  Push element onto
6656         current_global_psymbols and current_static_psymbols stacks.
6657         (concat): New function.
6658         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
6659         element from current_global_psymbols and current_static_psymbols
6660         stacks.  Concat popped elements to global_psymbols and
6661         static_symbols.
6662         (add_psymbol_to_list): Use current_global_psymbols and
6663         current_static_psymbols stacks.
6664         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
6665         current_static_psymbols fields.
6666
6667 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6668
6669         * corelow.c (sniff_core_bfd): Remove.
6670         (class core_target) <m_core_vec>: Remove.
6671         (core_target::core_target): Update.
6672         (core_file_fns): Remove.
6673         (deprecated_add_core_fns): Remove.
6674         (default_core_sniffer): Remove.
6675         (sniff_core_bfd): Remove.
6676         (default_check_format): Remove.
6677         (gdb_check_format): Remove.
6678         (core_target_open): Update.
6679         (core_target::get_core_register_section): Update.
6680         (get_core_registers_cb): Update.
6681         (core_target::fetch_registers): Update.
6682         * gdbcore.h (struct core_fns): Remove.
6683         (deprecated_add_core_fns): Remove.
6684         (default_core_sniffer): Remove.
6685         (default_check_format): Remove.
6686
6687 2020-03-12  Tom Tromey  <tom@tromey.com>
6688
6689         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
6690         CORE_ADDR.
6691         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
6692
6693 2020-03-12  Tom Tromey  <tom@tromey.com>
6694
6695         * remote.c (remote_target::download_tracepoint)
6696         (remote_target::enable_tracepoint)
6697         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
6698         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
6699         sprintf_vma.
6700
6701 2020-03-12  Tom Tromey  <tom@tromey.com>
6702
6703         * symfile-mem.c: Update CORE_ADDR size assert.
6704
6705 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6706
6707         * selftest.m4: Move to gdbsupport/.
6708         * acinclude.m4: Update path to selftest.m4.
6709
6710 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6711
6712         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
6713         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
6714         gdbarch-selfselftests.c and selftest-arch.c.
6715         (SUBDIR_UNITTESTS_OBS): Rename to...
6716         (SELFTESTS_OBS): ... this.
6717         (COMMON_SFILES): Remove disasm-selftests.c and
6718         gdbarch-selftests.c.
6719         * configure.ac: Don't add selftest-arch.{c,o} to
6720         CONFIG_{SRCS,OBS}.
6721         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
6722         preprocessor conditions.
6723
6724 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6725
6726         * configure.ac: Don't source bfd/development.sh.
6727         * selftest.m4: Modify comment.
6728         * configure: Re-generate.
6729
6730 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6731
6732         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
6733         not "true" or "false".
6734         * configure: Re-generate.
6735
6736 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6737
6738         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
6739         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
6740         renamed to arm_nbsd_supply_gregset.
6741         (fetch_register): Update to call arm_nbsd_supply_gregset.
6742         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
6743         (arm_netbsd_nat_target::fetch_registers): Update.
6744         (fetch_elfcore_registers): Removed.
6745         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
6746         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
6747         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
6748         not require NetBSD system headers.
6749         (arm_nbsd_regset): New struct.
6750         (arm_nbsd_iterate_over_regset_sections): New function.
6751         (arm_netbsd_init_abi_common): Updated to call
6752         set_gdbarch_iterate_over_regset_sections.
6753         * arm-nbsd-tdep.h: New file.
6754
6755 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
6756
6757         * symtab.c (find_pc_sect_line): Add check which prevents infinite
6758         recursion.
6759
6760 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
6761
6762         * configure: Re-generate.
6763
6764 2020-03-11  Tom Tromey  <tromey@adacore.com>
6765
6766         * ada-typeprint.c (print_choices): Fix comment.
6767
6768 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6769
6770         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
6771         previous item in the list, when the list has no items.
6772
6773 2020-03-11  Tom de Vries  <tdevries@suse.de>
6774
6775         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
6776         PROP_LOCLIST handling code.
6777
6778 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6779
6780         * buildsym-legacy.c (record_line): Pass extra parameter to
6781         record_line.
6782         * buildsym.c (buildsym_compunit::record_line): Take an extra
6783         parameter, reduce duplication in the line table, and record the
6784         is_stmt flag in the line table.
6785         * buildsym.h (buildsym_compunit::record_line): Add extra
6786         parameter.
6787         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
6788         non-statement lines.
6789         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
6790         this to the symtab builder.
6791         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
6792         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
6793         through to dwarf_record_line_1.
6794         * infrun.c (process_event_stop_test): When stepping, don't stop at
6795         a non-statement instruction, and only refresh the step info when
6796         we land in the middle of a line's range.  Also add an extra
6797         comment.
6798         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
6799         field.
6800         * record-btrace.c (btrace_find_line_range): Only record lines
6801         marked as is-statement.
6802         * stack.c (frame_show_address): Show the frame address if we are
6803         in a non-statement sal.
6804         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
6805         (maintenance_print_one_line_table): Print a header for the is_stmt
6806         column, and include is_stmt information in the output.
6807         * symtab.c (find_pc_sect_line): Find lines marked as statements in
6808         preference to non-statements.
6809         (find_pcs_for_symtab_line): Prefer is-statement entries.
6810         (find_line_common): Likewise.
6811         * symtab.h (struct linetable_entry): Add is_stmt field.
6812         (struct symtab_and_line): Likewise.
6813         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
6814         arranging the line table.
6815
6816 2020-03-07  Tom de Vries  <tdevries@suse.de>
6817
6818         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
6819         DIE.
6820
6821 2020-03-07  Tom Tromey  <tom@tromey.com>
6822
6823         * valops.c (value_literal_complex): Remove obsolete comment.
6824         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
6825         comment.
6826
6827 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
6828
6829         * infrun.h: Forward-declare thread_info.
6830         (set_step_info): Add thread_info parameter, add doc.
6831         * infrun.c (set_step_info): Add thread_info parameter, move doc
6832         to header.
6833         * infrun.c (process_event_stop_test): Pass thread to
6834         set_step_info call.
6835         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
6836         set_step_info.
6837         (prepare_one_step): Add thread_info parameter, pass it to
6838         set_step_frame and prepare_one_step (recursive) call.
6839         (step_1): Pass thread to prepare_one_step call.
6840         (step_command_fsm::should_stop): Pass thread to
6841         prepare_one_step.
6842         (until_next_fsm): Pass thread to set_step_frame call.
6843         (finish_command): Pass thread to set_step_info call.
6844
6845 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
6846
6847         * windows-tdep.c (windows_solib_create_inferior_hook):
6848         Check if inferior is running.
6849
6850 2020-03-06  Tom de Vries  <tdevries@suse.de>
6851
6852         * NEWS: Fix "the the".
6853         * ctfread.c: Same.
6854
6855 2020-03-06  Tom de Vries  <tdevries@suse.de>
6856
6857         * psymtab.c (psymtab_to_symtab): Don't print "done.".
6858
6859 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6860
6861         * .dir-locals.el: Add a comment referencing the other copies of
6862         this file.
6863
6864 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
6865
6866         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
6867         psargs.
6868
6869 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6870
6871         * .gitattributes: New file.
6872
6873 2020-03-04  Tom Tromey  <tom@tromey.com>
6874
6875         * symmisc.c (print_symbol_bcache_statistics)
6876         (print_objfile_statistics): Update.
6877         * symfile.c (allocate_symtab): Use intern.
6878         * psymtab.c (partial_symtab::partial_symtab): Use intern.
6879         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6880         macro_cache>: Remove.
6881         <string_cache>: New member.
6882         (struct objfile) <intern>: New methods.
6883         * elfread.c (elf_symtab_read): Use intern.
6884         * dwarf2/read.c (fixup_go_packaging): Intern package name.
6885         (dwarf2_compute_name, dwarf2_physname)
6886         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
6887         names.
6888         (guess_partial_die_structure_name): Update.
6889         (partial_die_info::fixup): Intern name.
6890         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
6891         name.
6892         (dwarf2_name): Intern name.  Update.
6893         * buildsym.c (buildsym_compunit::get_macro_table): Use
6894         string_cache.
6895
6896 2020-03-04  Tom Tromey  <tom@tromey.com>
6897
6898         * jit.c (bfd_open_from_target_memory): Make "target" const.
6899         * corefile.c (gnutarget): Now const.
6900         * gdbcore.h (gnutarget): Now const.
6901
6902 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
6903
6904         * NEWS: Mention support for WOW64 processes.
6905         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
6906         (amd64_windows_segment_register_p): Remove static.
6907         (_initialize_amd64_windows_nat): Update.
6908         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
6909         * i386-windows-nat.c (context_offset): Update.
6910         (i386_mappings): Rename and remove static.
6911         (i386_windows_segment_register_p): Remove static.
6912         (_initialize_i386_windows_nat): Update.
6913         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
6914         (STATUS_WX86_SINGLE_STEP): New macro.
6915         (EnumProcessModulesEx): New macro.
6916         (Wow64SuspendThread): New macro.
6917         (Wow64GetThreadContext): New macro.
6918         (Wow64SetThreadContext): New macro.
6919         (Wow64GetThreadSelectorEntry): New macro.
6920         (windows_set_context_register_offsets): Add static.
6921         (windows_set_segment_register_p): Likewise.
6922         (windows_add_thread): Adapt for WOW64 processes.
6923         (windows_fetch_one_register): Likewise.
6924         (windows_nat_target::fetch_registers): Likewise.
6925         (windows_store_one_register): Likewise.
6926         (display_selector): Likewise.
6927         (display_selectors): Likewise.
6928         (handle_exception): Likewise.
6929         (windows_continue): Likewise.
6930         (windows_nat_target::resume): Likewise.
6931         (windows_add_all_dlls): Likewise.
6932         (do_initial_windows_stuff): Likewise.
6933         (windows_nat_target::attach): Likewise.
6934         (windows_get_exec_module_filename): Likewise.
6935         (windows_nat_target::create_inferior): Likewise.
6936         (windows_xfer_siginfo): Likewise.
6937         (_initialize_loadable): Initialize Wow64SuspendThread,
6938         Wow64GetThreadContext, Wow64SetThreadContext,
6939         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6940         * windows-nat.h (windows_set_context_register_offsets):
6941         Remove declaration.
6942         (windows_set_segment_register_p): Likewise.
6943         (i386_windows_segment_register_p): Add declaration.
6944         (amd64_windows_segment_register_p): Likewise.
6945
6946 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6947
6948         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6949         in "info registers" for AArch64/ARM.
6950
6951         The change caused "info registers" to not print GPR's.
6952
6953         gdb/ChangeLog:
6954
6955         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6956
6957         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6958         when reg->group is empty and reggroup is not.
6959
6960 2020-03-03  Tom Tromey  <tromey@adacore.com>
6961
6962         * dwarf2/frame.c (struct dwarf2_frame_cache)
6963         <checked_tailcall_bottom, entry_cfa_sp_offset,
6964         entry_cfa_sp_offset_p>: Remove members.
6965         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6966         (dwarf2_frame_prev_register): Don't call
6967         dwarf2_tailcall_sniffer_first.
6968         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6969         * frame-unwind.c (add_unwinder): New fuction.
6970         (frame_unwind_init): Use it.  Add tailcall unwinder.
6971
6972 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6973             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6974
6975         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6976         value should be printed as true.
6977
6978 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6979
6980         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6981         (windows_init_abi): Set and use windows_so_ops.
6982
6983 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6984
6985         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6986         when verifying if dealing with a convenience variable.
6987
6988 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6989
6990         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6991
6992 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6993
6994         * infrun.c (gdbarch_supports_displaced_stepping): New.
6995         (use_displaced_stepping): Break up conditions in smaller pieces.
6996         Use gdbarch_supports_displaced_stepping.
6997         (displaced_step_prepare_throw): Use
6998         gdbarch_supports_displaced_stepping.
6999
7000 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7001
7002         * NEWS: Mention new behaviour of the history filename.
7003         * top.c (write_history_p): Add comment.
7004         (show_write_history_p): Add header comment, give a different
7005         message when history writing is on, but the history filename is
7006         empty.
7007         (history_filename): Add comment.
7008         (history_filename_empty): New function.
7009         (show_history_filename): Add header comment, give a different
7010         message when the filename is empty.
7011         (init_history): Compare history_filename against nullptr, and only
7012         read history if the filename is not empty.
7013         (set_history_filename): Add header comment, and only make
7014         non-empty filenames absolute.
7015         (init_main): Make the filename argument to 'set history filename'
7016         optional.
7017
7018 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
7019
7020         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
7021         (arm_supply_vfpregset): ...this, and update to use VFP registers.
7022         (fetch_fp_register): Update.
7023         (fetch_fp_regs): Update.
7024         (store_fp_register): Update.
7025         (store_fp_regs): Update.
7026         (arm_netbsd_nat_target::read_description): New function.
7027         (fetch_elfcore_registers): Update.
7028
7029 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
7032         general_thread if the stop reply is missing a thread-id.
7033         (remote_target::process_stop_reply): Use the first non-exited
7034         thread if the target didn't pass a thread-id.
7035         * infrun.c (do_target_wait): Move call to
7036         switch_to_inferior_no_thread to ....
7037         (do_target_wait_1): ... here.
7038
7039 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
7040
7041         * debuginfod-support.c: Include defs.h first.
7042
7043 2020-02-28  Tom de Vries  <tdevries@suse.de>
7044
7045         * symfile.c (set_initial_language): Use default language for lookup.
7046
7047 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
7048
7049         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
7050         reader variable, pass `this` to read_cutu_die_from_dwo.
7051
7052 2020-02-27  Aaron Merey  <amerey@redhat.com>
7053
7054         * source.c (open_source_file): Check for nullptr when computing
7055         srcpath.
7056
7057 2020-02-27  Tom Tromey  <tromey@adacore.com>
7058
7059         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
7060         member.
7061         (dwarf2_add_field): Don't update nfields.
7062         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
7063
7064 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
7067         abs.
7068
7069 2020-02-26  Tom Tromey  <tom@tromey.com>
7070
7071         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
7072         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
7073         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
7074         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
7075         per_cu_data.
7076
7077 2020-02-26  Tom Tromey  <tom@tromey.com>
7078
7079         * dwarf2/index-write.c (psym_index_map): Change type.
7080         (add_address_entry_worker, write_one_signatured_type)
7081         (recursively_count_psymbols, recursively_write_psymbols)
7082         (class debug_names, psyms_seen_size, write_gdbindex)
7083         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
7084
7085 2020-02-26  Aaron Merey  <amerey@redhat.com>
7086
7087         * Makefile.in: Handle optional debuginfod support.
7088         * NEWS: Update.
7089         * README: Add --with-debuginfod summary.
7090         * config.in: Regenerate.
7091         * configure: Regenerate.
7092         * configure.ac: Handle optional debuginfod support.
7093         * debuginfod-support.c: debuginfod helper functions.
7094         * debuginfod-support.h: Ditto.
7095         * doc/gdb.texinfo: Add --with-debuginfod to configure options
7096         summary.
7097         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
7098         when a dwz file cannot be found.
7099         * elfread.c (elf_symfile_read): Query debuginfod servers when a
7100         debuginfo file cannot be found.
7101         * source.c (open_source_file): Query debuginfod servers when a
7102         source file cannot be found.
7103         * top.c (print_gdb_configuration): Include
7104         --{with,without}-debuginfod in the output.
7105
7106 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
7107
7108         * thread.c (thr_try_catch_cmd): Print thread name.
7109
7110 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
7111
7112         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
7113         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7114         dwarf2_fetch_die_type_sect_off): Move to...
7115         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
7116         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7117         dwarf2_fetch_die_type_sect_off): ... here.
7118         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
7119         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7120         dwarf2_fetch_die_type_sect_off): Move doc to header file.
7121
7122 2020-02-26  Tom de Vries  <tdevries@suse.de>
7123
7124         PR gdb/25603
7125         * symfile.c (set_initial_language): Exit-early if
7126         language_mode == language_mode_manual.
7127
7128 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7129
7130         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
7131         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
7132         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
7133
7134 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
7135
7136         * gdbtypes.c (create_array_type_with_stride): Handle negative
7137         array strides.
7138         * valarith.c (value_subscripted_rvalue): Likewise.
7139
7140 2020-02-25  Luis Machado  <luis.machado@linaro.org>
7141
7142         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
7143
7144 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7145
7146         * loc.h (dwarf2_get_die_type): Move to...
7147         * read.h (dwarf2_get_die_type): ... here.
7148         * read.c (dwarf2_get_die_type): Move doc to header.
7149
7150 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
7151
7152         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
7153         'gnulib/Makefile.in' to the list.
7154
7155 2020-02-24  Tom Tromey  <tom@tromey.com>
7156
7157         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
7158         Remove.
7159         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
7160         XOBNEWVEC.
7161
7162 2020-02-24  Tom Tromey  <tom@tromey.com>
7163
7164         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
7165         New method.
7166         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
7167         (dw2_do_instantiate_symtab, dw2_get_file_names)
7168         (build_type_psymtab_dependencies, load_full_type_unit): Update.
7169
7170 2020-02-24  Tom Tromey  <tom@tromey.com>
7171
7172         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
7173         make_scoped_restore.
7174         (dwarf2_psymtab::read_symtab): Don't clear
7175         reading_partial_symbols.
7176
7177 2020-02-24  Tom de Vries  <tdevries@suse.de>
7178
7179         PR gdb/25592
7180         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
7181
7182 2020-02-24  Tom de Vries  <tdevries@suse.de>
7183
7184         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
7185         commands layout next/prev/regs.
7186
7187 2020-02-22  Tom Tromey  <tom@tromey.com>
7188
7189         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
7190         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
7191
7192 2020-02-22  Tom Tromey  <tom@tromey.com>
7193
7194         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
7195
7196 2020-02-22  Tom Tromey  <tom@tromey.com>
7197
7198         * tui/tui-win.c (_initialize_tui_win): Add usage text.
7199         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
7200         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
7201         * tui/tui.c (_initialize_tui): Add usage text.
7202
7203 2020-02-22  Tom Tromey  <tom@tromey.com>
7204
7205         * tui/tui-win.c (tui_set_focus_command)
7206         (tui_set_win_height_command): Use error_no_arg.
7207         (_initialize_tui_win): Update help text.
7208         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
7209
7210 2020-02-22  Tom Tromey  <tom@tromey.com>
7211
7212         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
7213         * tui/tui-disasm.h (struct tui_disasm_window)
7214         <display_start_addr>: Declare.
7215         * tui/tui-source.h (struct tui_source_window)
7216         <display_start_addr>: Declare.
7217         * tui/tui-winsource.h (struct tui_source_window_base)
7218         <show_source_line, display_start_addr>: New methods.
7219         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
7220         Rename and move to protected section.
7221         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
7222         (tui_source_window_base::do_erase_source_content): Update.
7223         (tui_source_window_base::show_source_line): Now a method.
7224         (tui_source_window_base::show_source_content)
7225         (tui_source_window_base::tui_source_window_base)
7226         (tui_source_window_base::rerender)
7227         (tui_source_window_base::refill)
7228         (tui_source_window_base::do_scroll_horizontal)
7229         (tui_source_window_base::set_is_exec_point_at)
7230         (tui_source_window_base::update_breakpoint_info)
7231         (tui_source_window_base::update_exec_info): Update.
7232         * tui/tui-source.c (tui_source_window::set_contents)
7233         (tui_source_window::showing_source_p)
7234         (tui_source_window::do_scroll_vertical)
7235         (tui_source_window::location_matches_p)
7236         (tui_source_window::line_is_displayed): Update.
7237         (tui_source_window::display_start_addr): New method.
7238         * tui/tui-disasm.c (tui_disasm_window::set_contents)
7239         (tui_disasm_window::do_scroll_vertical)
7240         (tui_disasm_window::location_matches_p): Update.
7241         (tui_disasm_window::display_start_addr): New method.
7242
7243 2020-02-22  Tom Tromey  <tom@tromey.com>
7244
7245         * NEWS: Add entry for gdb.register_window_type.
7246         * tui/tui-layout.h (window_factory): New typedef.
7247         (tui_register_window): Declare.
7248         * tui/tui-layout.c (saved_tui_windows): New global.
7249         (tui_apply_current_layout): Use it.
7250         (tui_register_window): New function.
7251         * python/python.c (do_start_initialization): Call
7252         gdbpy_initialize_tui.
7253         (python_GdbMethods): Add "register_window_type" function.
7254         * python/python-internal.h (gdbpy_register_tui_window)
7255         (gdbpy_initialize_tui): Declare.
7256         * python/py-tui.c: New file.
7257         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
7258
7259 2020-02-22  Tom Tromey  <tom@tromey.com>
7260
7261         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
7262
7263 2020-02-22  Tom Tromey  <tom@tromey.com>
7264
7265         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
7266         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
7267         * tui/tui-data.c (tui_set_win_with_focus): Remove.
7268         (tui_set_win_focus_to): Move from tui-win.c.
7269
7270 2020-02-22  Tom Tromey  <tom@tromey.com>
7271
7272         * tui/tui-layout.c (make_standard_window, get_locator_window): New
7273         functions.
7274         (known_window_types): New global.
7275         (tui_get_window_by_name): Reimplement.
7276         (initialize_known_windows): New function.
7277         (validate_window_name): Rewrite.
7278         (_initialize_tui_layout): Call initialize_known_windows.
7279
7280 2020-02-22  Tom Tromey  <tom@tromey.com>
7281
7282         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
7283         Remove constants.
7284         * tui/tui-winsource.h (struct tui_source_window_base)
7285         <tui_source_window_base>: Remove parameter.
7286         * tui/tui-winsource.c
7287         (tui_source_window_base::tui_source_window_base): Remove
7288         parameter.
7289         (tui_source_window_base::refill): Update.
7290         * tui/tui-stack.h (struct tui_locator_window)
7291         <tui_locator_window>: Update.
7292         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
7293         Default the constructor.
7294         * tui/tui-regs.h (struct tui_data_item_window)
7295         <tui_data_item_window>: Default the constructor.
7296         (struct tui_data_window) <tui_data_window>: Likewise.
7297         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
7298         Default the constructor.
7299         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
7300         Default the constructor.
7301         <type>: Remove.
7302         (struct tui_win_info) <tui_win_info>: Default the constructor.
7303         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
7304         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
7305         Default the constructor.
7306
7307 2020-02-22  Tom Tromey  <tom@tromey.com>
7308
7309         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
7310         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
7311         * tui/tui-win.c (tui_resize_all): Don't call
7312         tui_delete_invisible_windows.
7313         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
7314         done.
7315         (tui_set_layout): Update.
7316         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
7317         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
7318         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
7319
7320 2020-02-22  Tom Tromey  <tom@tromey.com>
7321
7322         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
7323         correctly.
7324
7325 2020-02-22  Tom Tromey  <tom@tromey.com>
7326
7327         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
7328
7329 2020-02-22  Tom Tromey  <tom@tromey.com>
7330
7331         * tui/tui-winsource.h (struct tui_source_window_iterator)
7332         <inner_iterator>: New etytypedef.
7333         <tui_source_window_iterator>: Take "end" parameter.
7334         <tui_source_window_iterator>: Take iterator.
7335         <operator*, advance>: Update.
7336         <m_iter>: Change type.
7337         <m_end>: New field.
7338         (struct tui_source_windows) <begin, end>: Update.
7339         * tui/tui-layout.c (tui_windows): New global.
7340         (tui_apply_current_layout): Clear tui_windows.
7341         (tui_layout_window::apply): Update tui_windows.
7342         * tui/tui-data.h (tui_windows): Declare.
7343         (all_tui_windows): Now inline function.
7344         (class tui_window_iterator, struct all_tui_windows): Remove.
7345
7346 2020-02-22  Tom Tromey  <tom@tromey.com>
7347
7348         PR tui/17850:
7349         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
7350         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
7351         "height" argument.
7352         (class tui_layout_window) <get_sizes>: Likewise.
7353         (class tui_layout_split) <tui_layout_split>: Add "vertical"
7354         argument.
7355         <get_sizes>: Add "height" argument.
7356         <m_vertical>: New field.
7357         * tui/tui-layout.c (tui_layout_split::clone): Update.
7358         (tui_layout_split::get_sizes): Add "height" argument.
7359         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
7360         (tui_new_layout_command): Parse "-horizontal".
7361         (_initialize_tui_layout): Update help string.
7362         (tui_layout_split::specification): Add "-horizontal" when needed.
7363         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
7364         argument.
7365         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
7366         New methods.
7367
7368 2020-02-22  Tom Tromey  <tom@tromey.com>
7369
7370         * tui/tui-layout.h (enum tui_adjust_result): New.
7371         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
7372         (class tui_layout_window) <adjust_size>: Return
7373         tui_adjust_result.  Rewrite.
7374         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
7375         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
7376
7377 2020-02-22  Tom Tromey  <tom@tromey.com>
7378
7379         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
7380         parameter and return types.
7381         (class tui_layout_base) <specification>: Add "depth".
7382         (class tui_layout_window) <specification>: Add "depth".
7383         (class tui_layout_split) <specification>: Add "depth".
7384         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
7385         and return types.
7386         (tui_new_layout_command): Parse sub-layouts.
7387         (_initialize_tui_layout): Update help string.
7388         (tui_layout_window::specification): Add "depth".
7389         (add_layout_command): Update.
7390
7391 2020-02-22  Tom Tromey  <tom@tromey.com>
7392
7393         * NEWS: Add "tui new-layout" item.
7394         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
7395         Add new-layout command to help text.
7396         (validate_window_name): New function.
7397         (tui_new_layout_command): New function.
7398         (_initialize_tui_layout): Register "new-layout".
7399         (tui_layout_window::specification): New method.
7400         (tui_layout_window::specification): New method.
7401         * tui/tui-layout.h (class tui_layout_base) <specification>: New
7402         method.
7403         (class tui_layout_window) <specification>: New method.
7404         (class tui_layout_split) <specification>: New method.
7405
7406 2020-02-22  Tom Tromey  <tom@tromey.com>
7407
7408         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
7409         * tui/tui-win.c (window_name_completer): Update comment.
7410         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
7411         Declare method.
7412         (class tui_layout_window) <replace_window>: Likewise.
7413         (class tui_layout_split) <replace_window>: Likewise.
7414         (tui_set_layout): Don't declare.
7415         (tui_set_initial_layout): Declare function.
7416         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
7417         (asm_regs_layout): New globals.
7418         (tui_current_layout, show_layout): Remove.
7419         (tui_set_layout, tui_add_win_to_layout): Rewrite.
7420         (find_layout, tui_apply_layout): New function.
7421         (layout_completer): Remove.
7422         (tui_next_layout): Reimplement.
7423         (tui_next_layout_command): New function.
7424         (tui_set_initial_layout, tui_prev_layout_command): New functions.
7425         (tui_regs_layout): Reimplement.
7426         (tui_regs_layout_command): New function.
7427         (extract_display_start_addr): Rewrite.
7428         (next_layout, prev_layout): Remove.
7429         (tui_layout_window::replace_window): New method.
7430         (tui_layout_split::replace_window): New method.
7431         (destroy_layout): New function.
7432         (layout_list): New global.
7433         (add_layout_command): New function.
7434         (initialize_layouts): Update.
7435         (tui_layout_command): New function.
7436         (_initialize_tui_layout): Install "layout" commands.
7437         * tui/tui-data.h (enum tui_layout_type): Remove.
7438         (tui_current_layout): Don't declare.
7439
7440 2020-02-22  Tom Tromey  <tom@tromey.com>
7441
7442         * tui/tui-regs.c (tui_reg_layout): Remove.
7443         (tui_reg_command): Use tui_regs_layout.
7444         * tui/tui-layout.h (tui_reg_command): Declare.
7445         * tui/tui-layout.c (tui_reg_command): New function.
7446
7447 2020-02-22  Tom Tromey  <tom@tromey.com>
7448
7449         * tui/tui.c (tui_rl_delete_other_windows): Call
7450         tui_remove_some_windows.
7451         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
7452         Declare method.
7453         (class tui_layout_window) <remove_windows>: New method.
7454         (class tui_layout_split) <remove_windows>: Declare.
7455         (tui_remove_some_windows): Declare.
7456         * tui/tui-layout.c (tui_remove_some_windows): New function.
7457         (tui_layout_split::remove_windows): New method.
7458
7459 2020-02-22  Tom Tromey  <tom@tromey.com>
7460
7461         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
7462         * tui/tui-layout.h (tui_next_layout): Declare.
7463         * tui/tui-layout.c (tui_next_layout): New function.
7464
7465 2020-02-22  Tom Tromey  <tom@tromey.com>
7466
7467         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
7468         correct coordinates.
7469
7470 2020-02-22  Tom Tromey  <tom@tromey.com>
7471
7472         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
7473         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
7474         DATA_WIN case.
7475
7476 2020-02-22  Tom Tromey  <tom@tromey.com>
7477
7478         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
7479         TUI_DISASM_WIN, not tui_win_list.
7480
7481 2020-02-22  Tom Tromey  <tom@tromey.com>
7482
7483         * valprint.c (generic_val_print_enum_1)
7484         (val_print_type_code_flags): Style member names.
7485         * rust-lang.c (val_print_struct, rust_print_enum)
7486         (rust_print_struct_def, rust_internal_print_type): Style member
7487         names.
7488         * p-valprint.c (pascal_object_print_value_fields): Style member
7489         names.  Only call fprintf_symbol_filtered for static members.
7490         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
7491         * f-valprint.c (f_val_print): Style member names.
7492         * f-typeprint.c (f_type_print_base): Style member names.
7493         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
7494         call fprintf_symbol_filtered for static members.
7495         (cp_print_class_member): Style member names.
7496         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
7497         member names.
7498         * ada-valprint.c (ada_print_scalar): Style enum names.
7499         (ada_val_print_enum): Likewise.
7500         * ada-typeprint.c (print_enum_type): Style enum names.
7501
7502 2020-02-21  Tom Tromey  <tom@tromey.com>
7503
7504         * psympriv.h (struct partial_symtab): Update comment.
7505
7506 2020-02-21  Tom Tromey  <tromey@adacore.com>
7507
7508         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
7509         type is CORE_ADDR.
7510
7511 2020-02-21  Tom de Vries  <tdevries@suse.de>
7512
7513         PR gdb/25534
7514         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
7515         if dependencies[i]->user != NULL.
7516
7517 2020-02-21  Ali Tamur  <tamur@google.com>
7518
7519         * dwarf2/read.c (dwarf2_name): Add null check.
7520
7521 2020-02-20  Tom Tromey  <tom@tromey.com>
7522
7523         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
7524         ">=", in binary search.
7525         (dwarf2_find_containing_comp_unit): New overload.
7526         (run_test): New self-test.
7527         (_initialize_dwarf2_read): Register new test.
7528
7529 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
7530
7531         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
7532         * riscv-tdep.h: Likewise.
7533         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
7534         rv32-only CSR.
7535         * features/riscv/64bit-csr.xml: Regenerated.
7536
7537 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
7538             Tom Tromey  <tom@tromey.com>
7539
7540         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
7541         of 'fputc_unfiltered'.
7542         (putchar_unfiltered): Call 'fputc_unfiltered'.
7543         (fputc_unfiltered): Call 'fputs_unfiltered'.
7544
7545 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * config.in: Regenerate.
7548         * configure: Regenerate.
7549         * configure.ac: Add --with-python-libdir option.
7550         * main.c: Use WITH_PYTHON_LIBDIR.
7551
7552 2020-02-19  Tom Tromey  <tom@tromey.com>
7553
7554         * symtab.c (general_symbol_info::compute_and_set_names): Use
7555         obstack_strndup.  Simplify call to symbol_set_demangled_name.
7556
7557 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
7558
7559         * dwarf2/read.c (allocate_signatured_type_table,
7560         allocate_dwo_unit_table, allocate_type_unit_groups_table,
7561         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
7562         Remove objfile parameter, update all callers.
7563
7564 2020-02-19  Doug Evans  <dje@google.com>
7565
7566         PR rust/25535
7567         * rust-lang.c (rust_print_enum): Apply embedded_offset to
7568         rust_enum_variant calculation.
7569
7570 2020-02-19  Tom Tromey  <tromey@adacore.com>
7571
7572         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
7573
7574 2020-02-19  Tom Tromey  <tromey@adacore.com>
7575
7576         * ada-lang.c (cache_symbol): Use obstack_strdup.
7577
7578 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7579
7580         * configure: Regenerate.
7581
7582 2020-02-19  Tom Tromey  <tromey@adacore.com>
7583
7584         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
7585         NULL check.
7586
7587 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
7588
7589         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
7590
7591 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7592
7593         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
7594         if GDBSERVER is not defined.
7595         (riscv_tdesc_cache): Likewise, also store const target_desc.
7596         (STATIC_IN_GDB): Define.
7597         (riscv_create_target_description): Update declaration with
7598         STATIC_IN_GDB.
7599         (riscv_lookup_target_description): New function, only define if
7600         GDBSERVER is not defined.
7601         * arch/riscv.h (riscv_create_target_description): Declare only
7602         when GDBSERVER is defined.
7603         (riscv_lookup_target_description): New declaration when GDBSERVER
7604         is not defined.
7605         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
7606         (riscv_linux_read_features): ...this, and return
7607         riscv_gdbarch_features instead of target_desc.
7608         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
7609         (riscv_linux_read_description): Rename to...
7610         (riscv_linux_read_features): ...this.
7611         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7612         Update to use riscv_gdbarch_features and
7613         riscv_lookup_target_description.
7614         * riscv-tdep.c (riscv_find_default_target_description): Use
7615         riscv_lookup_target_description instead of
7616         riscv_create_target_description.
7617
7618 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7619
7620         * valprint.c (generic_val_print_enum_1): When printing a flag
7621         enum with value 0 and there is no enumerator with value 0, print
7622         just "0" instead of "(unknown: 0x0)".
7623
7624 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7625
7626         * valprint.c (generic_val_print_enum_1): Print unknown part of
7627         flag enum in hex.
7628
7629 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7630
7631         * dwarf2/read.c (update_enumeration_type_from_children): Allow
7632         flag enums to contain duplicate enumerators.
7633         * valprint.c (generic_val_print_enum_1): Update comment.
7634
7635 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7636
7637         * dwarf2/read.c: Include "count-one-bits.h".
7638         (update_enumeration_type_from_children): If an enumerator has
7639         multiple bits set, don't treat the enumeration as a "flag enum".
7640         * valprint.c (generic_val_print_enum_1): Assert that enumerators
7641         of flag enums have 0 or 1 bit set.
7642
7643 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7644
7645         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
7646         conversion.
7647         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7648         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7649         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7650         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7651         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7652
7653 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7654
7655         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
7656
7657 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7658
7659         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
7660         displaced_step_closure_up.
7661         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7662         (struct displaced_step_closure_up):
7663         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7664         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7665         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
7666         Likewise.
7667         * gdbarch.sh (displaced_step_copy_insn): Likewise.
7668         * gdbarch.c, gdbarch.h: Re-generate.
7669         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
7670         displaced_step_closure_up.
7671         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7672         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7673         * infrun.h (displaced_step_closure_up): New type alias.
7674         (struct displaced_step_inferior_state) <step_closure>: Change
7675         type to displaced_step_closure_up.
7676         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
7677         displaced_step_closure_up.
7678         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7679
7680 2020-02-14  Tom Tromey  <tom@tromey.com>
7681
7682         * minidebug.c (gnu_debug_key): New global.
7683         (find_separate_debug_file_in_section): Use it.
7684
7685 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7686
7687         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
7688         std::unique_ptr.
7689         * gdbarch.c: Re-generate.
7690         * gdbarch.h: Re-generate.
7691         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
7692         change.
7693         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
7694         type to std::unique_ptr.
7695         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7696         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7697         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7698         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7699         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
7700         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7701         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7702         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7703         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7704
7705 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7706
7707         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
7708         std::unique_ptr.
7709         (displaced_step_clear): Rename to...
7710         (displaced_step_reset): ... this.  Just call displaced->reset ().
7711         (displaced_step_clear_cleanup): Rename to...
7712         (displaced_step_reset_cleanup): ... this.
7713         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
7714         (displaced_step_fixup): Likewise.
7715         (resume_1): Likewise.
7716         (handle_inferior_event): Restore child's memory before calling
7717         displaced_step_fixup on the parent.
7718         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
7719         to std::unique_ptr.
7720         <step_closure>: Change type to std::unique_ptr.
7721
7722 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7723
7724         * arm-tdep.c: Include count-one-bits.h.
7725         (cleanup_block_store_pc): Use count_one_bits.
7726         (cleanup_block_load_pc): Use count_one_bits.
7727         (arm_copy_block_xfer): Use count_one_bits.
7728         (thumb2_copy_block_xfer): Use count_one_bits.
7729         (thumb_copy_pop_pc_16bit): Use count_one_bits.
7730         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
7731         (thumb_get_next_pcs_raw): Use count_one_bits.
7732         (arm_get_next_pcs_raw): Use count_one_bits_l.
7733         * arch/arm.c (bitcount): Remove.
7734         * arch/arm.h (bitcount): Remove.
7735
7736 2020-02-14  Tom Tromey  <tromey@adacore.com>
7737
7738         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
7739         Update.
7740         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
7741         * dwarf2/loc.c (call_site_find_chain_1): Return
7742         unique_xmalloc_ptr.
7743         (call_site_find_chain): Likewise.
7744
7745 2020-02-14  Richard Biener  <rguenther@suse.de>
7746
7747         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
7748         on expression with division operators.
7749
7750 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7751
7752         * MAINTAINERS (Write After Approval): Adding myself.
7753
7754 2020-02-12  Tom Tromey  <tom@tromey.com>
7755
7756         * event-loop.c (event_data, gdb_event, event_handler_func):
7757         Remove.
7758
7759 2020-02-12  Tom Tromey  <tom@tromey.com>
7760
7761         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
7762         (dwarf2_frame_objfile_data): Add comment.
7763         (find_comp_unit, set_comp_unit): New functions.
7764         (dwarf2_frame_find_fde): Use find_comp_unit.
7765         (dwarf2_build_frame_info): Use set_comp_unit.
7766
7767 2020-02-12  Tom Tromey  <tom@tromey.com>
7768
7769         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
7770         (comp_unit): Don't initialize objfile.
7771         (execute_cfa_program): Add text_offset parameter.
7772         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
7773         (dwarf2_frame_cache): Update.
7774         (dwarf2_build_frame_info): Don't set "objfile" member.
7775
7776 2020-02-12  Tom Tromey  <tom@tromey.com>
7777
7778         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
7779         (decode_frame_entry): Likewise.
7780         (dwarf2_build_frame_info): Update.
7781
7782 2020-02-12  Tom Tromey  <tom@tromey.com>
7783
7784         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
7785         (decode_frame_entry_1): Use the comp_unit obstack.
7786
7787 2020-02-12  Tom Tromey  <tom@tromey.com>
7788
7789         * dwarf2/frame.c (struct comp_unit): Add initializers and
7790         constructor.
7791         (dwarf2_frame_objfile_data): Store a comp_unit.
7792         (dwarf2_frame_find_fde): Update.
7793         (dwarf2_build_frame_info): Use "new".
7794
7795 2020-02-12  Tom Tromey  <tom@tromey.com>
7796
7797         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
7798         (dwarf2_fde_table): Typedef for std::vector.
7799         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
7800         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
7801         (decode_frame_entry): Update.
7802         (dwarf2_build_frame_info): Use "new".
7803
7804 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7805
7806         * arm-tdep.c (arm_gdbarch_init): Update.
7807         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
7808         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
7809         have_neon, is_m>: Change to bool.
7810
7811 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7812
7813         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
7814
7815 2020-02-12  Tom Tromey  <tom@tromey.com>
7816
7817         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
7818
7819 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
7820
7821         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
7822         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
7823
7824 2020-02-11  Tom Tromey  <tom@tromey.com>
7825
7826         * psymtab.h: Update comment.
7827
7828 2020-02-11  Tom Tromey  <tom@tromey.com>
7829
7830         * gdb_obstack.h (struct auto_obstack): Use
7831         DISABLE_COPY_AND_ASSIGN.
7832
7833 2020-02-11  Tom Tromey  <tom@tromey.com>
7834
7835         * dwarf2/frame.h (struct objfile): Don't forward declare.
7836
7837 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7838
7839         * cris-tdep.c (cris_supply_gregset): Change signature to match
7840         what struct regset expects.
7841         (cris_regset): New struct.
7842         (fetch_core_registers): Remove.
7843         (cris_iterate_over_regset_sections): New function.
7844         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
7845         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
7846
7847 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7848
7849         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
7850         registers.
7851
7852 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7853
7854         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
7855
7856 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7857
7858         * configure: Re-generate.
7859
7860 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7861
7862         * configure: Re-generate.
7863
7864 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7865
7866         * acinclude: Update warning.m4 path.
7867         * warning.m4: Move to gdbsupport.
7868
7869 2020-02-11  Tom Tromey  <tromey@adacore.com>
7870
7871         * remote.c (remote_console_output): Update.
7872         * printcmd.c (printf_command): Update.
7873         * event-loop.c (gdb_wait_for_event): Update.
7874         * linux-nat.c (sigchld_handler): Update.
7875         * remote-sim.c (gdb_os_write_stdout): Update.
7876         (gdb_os_flush_stdout): Update.
7877         (gdb_os_flush_stderr): Update.
7878         (gdb_os_write_stderr): Update.
7879         * exceptions.c (print_exception): Update.
7880         * remote-fileio.c (remote_fileio_func_read): Update.
7881         (remote_fileio_func_write): Update.
7882         * tui/tui.c (tui_enable): Update.
7883         * tui/tui-interp.c (tui_interp::init): Update.
7884         * utils.c (init_page_info): Update.
7885         (putchar_unfiltered, fputc_unfiltered): Update.
7886         (gdb_flush): Update.
7887         (emit_style_escape): Update.
7888         (flush_wrap_buffer, fputs_maybe_filtered): Update.
7889         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
7890         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
7891         (stderr_file::write): Update.
7892         (stderr_file::puts): Update.
7893         * ui-file.h (ui_file_isatty, ui_file_write)
7894         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
7895         (ui_file_puts): Don't declare.
7896
7897 2020-02-10  Tom de Vries  <tdevries@suse.de>
7898
7899         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
7900         sentinel to char *.
7901
7902 2020-02-09  Tom de Vries  <tdevries@suse.de>
7903
7904         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
7905         filename if it matches "<artificial>".
7906
7907 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7908
7909         * windows-tdep.c (struct enum_value_name): New struct.
7910         (create_enum): New function.
7911         (windows_get_siginfo_type): Create and use enum types.
7912
7913 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7914
7915         * NEWS: Mention $_siginfo support for Windows.
7916         * windows-nat.c (handle_exception): Set siginfo_er.
7917         (windows_nat_target::mourn_inferior): Reset siginfo_er.
7918         (windows_xfer_siginfo): New function.
7919         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
7920         * windows-tdep.c (struct windows_gdbarch_data): New struct.
7921         (init_windows_gdbarch_data): New function.
7922         (get_windows_gdbarch_data): New function.
7923         (windows_get_siginfo_type): New function.
7924         (windows_init_abi): Register windows_get_siginfo_type.
7925         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
7926
7927 2020-02-08  Tom Tromey  <tom@tromey.com>
7928
7929         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7930         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7931         <keep>: Declare method.
7932         <m_keep>: Remove member.
7933         <~cutu_reader>: Remove.
7934         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7935         (cutu_reader::cutu_reader): Update.
7936         (cutu_reader::keep): Rename from ~cutu_reader.
7937         (process_psymtab_comp_unit, build_type_psymtabs_1)
7938         (process_skeletonless_type_unit, load_partial_comp_unit)
7939         (load_full_comp_unit, dwarf2_read_addr_index)
7940         (read_signatured_type): Update.
7941
7942 2020-02-08  Tom Tromey  <tom@tromey.com>
7943
7944         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7945         "want_partial_unit" parameter.
7946         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7947         Inline check for DW_TAG_partial_unit.
7948         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7949
7950 2020-02-08  Tom Tromey  <tom@tromey.com>
7951
7952         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7953         read.c.
7954         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7955         read.c.
7956
7957 2020-02-08  Tom Tromey  <tom@tromey.com>
7958
7959         * dwarf2/read.c (read_address): Move to comp-unit.c.
7960         (dwarf2_rnglists_process, dwarf2_ranges_process)
7961         (read_attribute_value, dwarf_decode_lines_1)
7962         (var_decode_location, decode_locdesc): Update.
7963         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7964         read.c.  Remove "cu" parameter.
7965         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7966         method.
7967
7968 2020-02-08  Tom Tromey  <tom@tromey.com>
7969
7970         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7971         (read_indirect_line_string): Update.
7972         * dwarf2/comp-unit.c (read_offset): Remove.
7973         (read_comp_unit_head): Update.
7974         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7975         method.
7976         (read_offset): Don't declare.
7977
7978 2020-02-08  Tom Tromey  <tom@tromey.com>
7979
7980         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7981         * dwarf2/read.c (struct comp_unit_head): Move to
7982         dwarf2/comp-unit.h.
7983         (enum class rcuh_kind): Move to comp-unit.h.
7984         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7985         (read_comp_unit_head, error_check_comp_unit_head)
7986         (read_and_check_comp_unit_head): Move to comp-unit.c.
7987         (read_offset, dwarf_unit_type_name): Likewise.
7988         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7989         (cutu_reader::cutu_reader, read_call_site_scope)
7990         (find_partial_die, follow_die_offset): Update.
7991         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7992
7993 2020-02-08  Tom Tromey  <tom@tromey.com>
7994
7995         * dwarf2/read.c (read_offset_1): Move to leb.c.
7996         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7997         (dwarf_decode_macro_bytes): Update.
7998         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7999         * dwarf2/leb.h (read_offset): Declare.
8000
8001 2020-02-08  Tom Tromey  <tom@tromey.com>
8002
8003         * dwarf2/read.c (dwarf2_section_size): Remove.
8004         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
8005         Update.
8006         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
8007
8008 2020-02-08  Tom Tromey  <tom@tromey.com>
8009
8010         * dwarf2/read.c (read_initial_length): Move to leb.c.
8011         * dwarf2/leb.h (read_initial_length): Declare.
8012         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
8013         handle_nonstd parameter.
8014         * dwarf2/frame.c (read_initial_length): Remove.
8015         (decode_frame_entry_1): Update.
8016
8017 2020-02-08  Tom Tromey  <tom@tromey.com>
8018
8019         * dwarf2/loc.c (dwarf2_find_location_expression)
8020         (dwarf_evaluate_loc_desc::get_tls_address)
8021         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
8022         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
8023         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
8024         (dwarf2_compile_property_to_c)
8025         (dwarf2_loc_desc_get_symbol_read_needs)
8026         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
8027         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
8028         (loclist_describe_location, loclist_tracepoint_var_ref)
8029         (loclist_generate_c_location): Update.
8030         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
8031         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
8032         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
8033         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
8034         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
8035         (dwarf2_per_cu_data::addr_size)
8036         (dwarf2_per_cu_data::ref_addr_size)
8037         (dwarf2_per_cu_data::text_offset)
8038         (dwarf2_per_cu_data::addr_type): Now methods.
8039         (per_cu_header_read_in): Make per_cu "const".
8040         (dwarf2_version): Remove.
8041         (dwarf2_per_cu_data::int_type): Now a method.
8042         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
8043         (set_die_type, read_array_type, read_subrange_index_type)
8044         (read_tag_string_type, read_subrange_type): Update.
8045         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
8046         offset_size, ref_addr_size, text_offset, addr_type, version,
8047         objfile, int_type, addr_sized_int_type>: Declare methods.
8048
8049 2020-02-08  Tom Tromey  <tom@tromey.com>
8050
8051         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
8052         Move earlier.
8053
8054 2020-02-08  Tom Tromey  <tom@tromey.com>
8055
8056         * dwarf2/read.h (dwarf_line_debug): Declare.
8057         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
8058         * dwarf2/read.c: Move line_header code to new files.
8059         (dwarf_line_debug): No longer static.
8060         * dwarf2/line-header.c: New file.
8061         * dwarf2/line-header.h: New file.
8062
8063 2020-02-08  Tom Tromey  <tom@tromey.com>
8064
8065         * dwarf2/read.c (struct line_header) <file_full_name,
8066         file_file_name>: Return unique_xmalloc_ptr.
8067         (line_header::file_file_name): Update.
8068         (line_header::file_full_name): Update.
8069         (dw2_get_file_names_reader): Update.
8070         (macro_start_file): Update.
8071
8072 2020-02-08  Tom Tromey  <tom@tromey.com>
8073
8074         * dwarf2/read.c (struct line_header) <file_full_name,
8075         file_file_name>: Declare methods.
8076         (dw2_get_file_names_reader): Update.
8077         (file_file_name): Now a method.
8078         (file_full_name): Likewise.
8079         (macro_start_file): Update.
8080
8081 2020-02-08  Tom Tromey  <tom@tromey.com>
8082
8083         * dwarf2/read.c (dwarf_always_disassemble)
8084         (show_dwarf_always_disassemble): Move to loc.c.
8085         (_initialize_dwarf2_read): Move "always-disassemble" registration
8086         to loc.c.
8087         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
8088         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
8089         static.
8090         (show_dwarf_always_disassemble): Move from read.c.
8091         (_initialize_dwarf2loc): Move always-disassemble from read.c.
8092
8093 2020-02-08  Tom Tromey  <tom@tromey.com>
8094
8095         * dwarf2/read.c (~dwarf2_per_objfile): Update.
8096         (create_quick_file_names_table): Return htab_up.
8097         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
8098         Update.
8099         * dwarf2/read.h (struct dwarf2_per_objfile)
8100         <quick_file_names_table>: Now htab_up.
8101
8102 2020-02-08  Tom Tromey  <tom@tromey.com>
8103
8104         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
8105
8106 2020-02-08  Tom Tromey  <tom@tromey.com>
8107
8108         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
8109         Rewrite.
8110         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
8111         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
8112         (abbrev_table::abbrev_table): No longer inline.
8113         (ABBREV_HASH_SIZE): Remove.
8114         (abbrev_table::m_abbrevs): Now an htab_up.
8115
8116 2020-02-08  Tom Tromey  <tom@tromey.com>
8117
8118         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
8119         (cutu_reader): Update.
8120         (build_type_psymtabs_1): Update.
8121         * dwarf2/abbrev.c (abbrev_table::read): Rename.
8122         (abbrev_table::alloc_abbrev): Update.
8123         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
8124         (abbrev_table::read): New static method, renamed from
8125         abbrev_table_read_table.
8126         (abbrev_table::alloc_abbrev)
8127         (abbrev_table::add_abbrev): Now private.
8128         (abbrev_table::abbrev_table): Now private.
8129         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
8130
8131 2020-02-08  Tom Tromey  <tom@tromey.com>
8132
8133         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
8134         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
8135         htab_up.
8136
8137 2020-02-08  Tom Tromey  <tom@tromey.com>
8138
8139         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
8140         htab_up.
8141         (lookup_dwo_unit_in_dwp): Update.
8142         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
8143         on obstack.
8144
8145 2020-02-08  Tom Tromey  <tom@tromey.com>
8146
8147         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
8148         obstack.
8149
8150 2020-02-08  Tom Tromey  <tom@tromey.com>
8151
8152         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
8153         line_header_hash.
8154         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
8155         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
8156         Change type to htab_up.
8157
8158 2020-02-08  Tom Tromey  <tom@tromey.com>
8159
8160         * dwarf2/read.c (allocate_type_unit_groups_table): Return
8161         htab_up.  Don't allocate on obstack.
8162         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
8163         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
8164         Change type to htab_up.
8165
8166 2020-02-08  Tom Tromey  <tom@tromey.com>
8167
8168         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
8169         Change type to htab_up.
8170         * dwarf2/read.c (create_signatured_type_table_from_index)
8171         (create_signatured_type_table_from_debug_names)
8172         (create_all_type_units, add_type_unit)
8173         (lookup_dwo_signatured_type, lookup_signatured_type)
8174         (process_skeletonless_type_unit): Update.
8175         (create_debug_type_hash_table, create_debug_types_hash_table):
8176         Change type of types_htab.
8177         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
8178         htab_up.  Don't allocate on obstack.
8179         (create_cus_hash_table): Change type of cus_htab parameter.
8180         (struct dwo_file) <cus, tus>: Now htab_up.
8181         (lookup_dwo_signatured_type, lookup_dwo_cutu)
8182         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
8183         (queue_and_load_all_dwo_tus): Update.
8184         * dwarf2/index-write.c (write_gdbindex): Update.
8185         (write_debug_names): Update.
8186
8187 2020-02-08  Tom Tromey  <tom@tromey.com>
8188
8189         * dwarf2/read.h (struct dwarf2_queue_item): Move from
8190         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
8191         destructor.
8192         (struct dwarf2_per_objfile) <queue>: New member.
8193         * dwarf2/read.c (struct dwarf2_queue_item): Move to
8194         dwarf2/read.h.
8195         (dwarf2_queue, dwarf2_queue_tail): Remove.
8196         (class dwarf2_queue_guard): Add parameter to constructor.  Use
8197         DISABLE_COPY_AND_ASSIGN.
8198         <m_per_objfile>: New member.
8199         <~dwarf2_queue_guard>: Rewrite.
8200         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
8201         Update.
8202         (~dwarf2_queue_item): New.
8203
8204 2020-02-08  Tom Tromey  <tom@tromey.com>
8205
8206         * dwarf2/read.c (struct die_info) <has_children>: New member.
8207         (dw2_get_file_names_reader): Remove has_children.
8208         (dw2_get_file_names): Update.
8209         (read_cutu_die_from_dwo): Remove has_children.
8210         (cutu_reader::init_tu_and_read_dwo_dies)
8211         (cutu_reader::cutu_reader): Update.
8212         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
8213         Remove has_children.
8214         (build_type_psymtabs_1, process_skeletonless_type_unit)
8215         (load_partial_comp_unit, load_full_comp_unit): Update.
8216         (create_dwo_cu_reader): Remove has_children.
8217         (create_cus_hash_table, read_die_and_children): Update.
8218         (read_full_die_1,read_full_die): Remove has_children.
8219         (read_signatured_type): Update.
8220         (class cutu_reader) <has_children>: Remove.
8221
8222 2020-02-08  Tom Tromey  <tom@tromey.com>
8223
8224         * dwarf2/expr.c: Rename from dwarf2expr.c.
8225         * dwarf2/expr.h: Rename from dwarf2expr.h.
8226         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
8227         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
8228         * dwarf2/frame.c: Rename from dwarf2-frame.c.
8229         * dwarf2/frame.h: Rename from dwarf2-frame.h.
8230         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
8231         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
8232         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
8233         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
8234         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
8235         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
8236         * dwarf2/loc.c: Rename from dwarf2loc.c.
8237         * dwarf2/loc.h: Rename from dwarf2loc.h.
8238         * dwarf2/read.c: Rename from dwarf2read.c.
8239         * dwarf2/read.h: Rename from dwarf2read.h.
8240         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
8241         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
8242         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
8243         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
8244         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
8245         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
8246         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
8247         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
8248         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
8249         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
8250         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
8251         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
8252         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
8253         Update.
8254         * Makefile.in (COMMON_SFILES): Update.
8255         (HFILES_NO_SRCDIR): Update.
8256
8257 2020-02-08  Tom Tromey  <tom@tromey.com>
8258
8259         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
8260         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
8261
8262 2020-02-08  Tom Tromey  <tom@tromey.com>
8263
8264         * dwarf2read.h (struct die_info): Don't declare.
8265
8266 2020-02-08  Tom Tromey  <tom@tromey.com>
8267
8268         * dwarf2read.h (die_info_ptr): Remove typedef.
8269
8270 2020-02-08  Tom Tromey  <tom@tromey.com>
8271
8272         * dwarf2read.c (read_call_site_scope)
8273         (handle_data_member_location, dwarf2_add_member_fn)
8274         (mark_common_block_symbol_computed, read_common_block)
8275         (attr_to_dynamic_prop, partial_die_info::read)
8276         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
8277         (dwarf2_symbol_mark_computed, set_die_type): Update.
8278         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
8279         method.
8280         (attr_form_is_block): Don't declare.
8281         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
8282
8283 2020-02-08  Tom Tromey  <tom@tromey.com>
8284
8285         * dwarf2read.c (dwarf2_find_base_address, )
8286         (read_call_site_scope, rust_containing_type)
8287         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
8288         (handle_data_member_location, dwarf2_add_member_fn)
8289         (get_alignment, read_structure_type, process_structure_scope)
8290         (mark_common_block_symbol_computed, read_common_block)
8291         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
8292         (partial_die_info::read, read_attribute_value, new_symbol)
8293         (lookup_die_type, dwarf2_get_ref_die_offset)
8294         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
8295         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
8296         (dwarf2_symbol_mark_computed): Update.
8297         * dwarf2/attribute.h (struct attribute) <value_as_address,
8298         form_is_section_offset, form_is_constant, form_is_ref>: Declare
8299         methods.
8300         (value_as_address, attr_form_is_section_offset)
8301         (attr_form_is_constant, attr_form_is_ref): Don't declare.
8302         * dwarf2/attribute.c (attribute::value_as_address)
8303         (attribute::form_is_section_offset, attribute::form_is_constant)
8304         (attribute::form_is_ref): Now methods.
8305
8306 2020-02-08  Tom Tromey  <tom@tromey.com>
8307
8308         * dwarf2read.c (struct attribute, DW_STRING)
8309         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
8310         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
8311         (attr_form_is_block, attr_form_is_section_offset)
8312         (attr_form_is_constant, attr_form_is_ref): Move.
8313         * dwarf2/attribute.h: New file.
8314         * dwarf2/attribute.c: New file, from dwarf2read.c.
8315         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
8316
8317 2020-02-08  Tom Tromey  <tom@tromey.com>
8318
8319         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
8320         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
8321         Move.
8322         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
8323         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
8324         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
8325         abbrev.c.
8326         * dwarf2/abbrev.h: New file.
8327         * dwarf2/abbrev.c: New file, from dwarf2read.c.
8328         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
8329
8330 2020-02-08  Tom Tromey  <tom@tromey.com>
8331
8332         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
8333         (dwarf2_section_size, dwarf2_get_section_info)
8334         (create_signatured_type_table_from_debug_names)
8335         (create_addrmap_from_aranges, read_debug_names_from_section)
8336         (get_gdb_index_contents_from_section, read_comp_unit_head)
8337         (error_check_comp_unit_head, read_abbrev_offset)
8338         (create_debug_type_hash_table, init_cu_die_reader)
8339         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
8340         (read_comp_units_from_section, create_cus_hash_table)
8341         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
8342         (create_dwp_v2_section, dwarf2_rnglists_process)
8343         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
8344         (abbrev_table_read_table, read_indirect_string_at_offset_from)
8345         (read_indirect_string_from_dwz, read_addr_index_1)
8346         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
8347         (dwarf_decode_macro_bytes, dwarf_decode_macros)
8348         (fill_in_loclist_baton): Update.
8349         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
8350         get_containing_section, get_bfd_owner, get_bfd_section,
8351         get_file_name, get_id, get_flags, empty, read>: Declare methods.
8352         (dwarf2_read_section, get_section_name, get_section_file_name)
8353         (get_containing_section, get_section_bfd_owner)
8354         (get_section_bfd_section, get_section_name, get_section_file_name)
8355         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
8356         declare.
8357         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
8358         (dwarf2_section_info::get_bfd_owner)
8359         (dwarf2_section_info::get_bfd_section)
8360         (dwarf2_section_info::get_name)
8361         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
8362         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
8363         (dwarf2_section_info::read): Now methods.
8364         * dwarf-index-write.c (class debug_names): Update.
8365
8366 2020-02-08  Tom Tromey  <tom@tromey.com>
8367
8368         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
8369         Move to dwarf2/section.h.
8370         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
8371         (get_section_bfd_section, get_section_name)
8372         (get_section_file_name, get_section_id, get_section_flags)
8373         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
8374         dwarf2/section.c.
8375         * dwarf2/section.h: New file.
8376         * dwarf2/section.c: New file, from dwarf2read.c.
8377         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
8378
8379 2020-02-08  Tom Tromey  <tom@tromey.com>
8380
8381         * dwarf2read.h (read_unsigned_leb128): Don't declare.
8382         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
8383         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
8384         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
8385         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
8386         * dwarf2/leb.h: New file, from dwarf2read.c.
8387         * dwarf2/leb.c: New file, from dwarf2read.c.
8388         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
8389         Remove.
8390         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
8391         (COMMON_SFILES): Add dwarf2/leb.c.
8392
8393 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
8394
8395         GDB 9.1 released.
8396
8397 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8398
8399         PR gdb/25190:
8400         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
8401         * gdb/remote.c (remote_console_output): Update.
8402         * gdb/ui-file.c (fputs_unfiltered): Rename to...
8403         (ui_file_puts): ...this.
8404         * gdb/ui-file.h (ui_file_puts): Add declaration.
8405         * gdb/utils.c (emit_style_escape): Update.
8406         (flush_wrap_buffer): Update.
8407         (fputs_maybe_filtered): Update.
8408         (fputs_unfiltered): Add function.
8409
8410 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8411
8412         * gdb/event-loop.c (gdb_wait_for_event): Update.
8413         * gdb/printcmd.c (printf_command): Update.
8414         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
8415         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
8416         (gdb_os_flush_stderr): Update.
8417         * gdb/remote.c (remote_console_output): Update.
8418         * gdb/ui-file.c (gdb_flush): Rename to...
8419         (ui_file_flush): ...this.
8420         (stderr_file::write): Update.
8421         (stderr_file::puts): Update.
8422         * gdb/ui-file.h (gdb_flush): Rename to...
8423         (ui_file_flush): ...this.
8424         * gdb/utils.c (gdb_flush): Add function.
8425         * gdb/utils.h (gdb_flush): Add declaration.
8426
8427 2020-02-07  Tom Tromey  <tromey@adacore.com>
8428
8429         PR breakpoints/24915:
8430         * source.c (find_and_open_source): Do not check basenames_may_differ.
8431
8432 2020-02-07  Tom Tromey  <tom@tromey.com>
8433
8434         * README: Update gdbserver documentation.
8435         * gdbserver: Move to top level.
8436         * configure.tgt (build_gdbserver): Remove.
8437         * configure.ac: Remove --enable-gdbserver.
8438         * configure: Rebuild.
8439         * Makefile.in (distclean): Don't mention gdbserver.
8440
8441 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8442
8443         * source-cache.c (source_cache::ensure): Surround
8444         get_plain_source_lines with a try/catch.
8445         (source_cache::get_line_charpos): Get rid of try/catch
8446         and only check for the return value of "ensure".
8447         * tui/tui-source.c (tui_source_window::set_contents):
8448         Simplify "nlines" calculation.
8449
8450 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8451
8452         * MAINTAINERS (Write After Approval): Add myself.
8453
8454 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8455
8456         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
8457         function call.
8458
8459 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8460
8461         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
8462
8463 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
8464
8465         * nat/riscv-linux-tdesc.h: New file.
8466         * nat/riscv-linux-tdesc.c: New file, taking code from...
8467         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8468         ... here.
8469         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
8470         NATDEPFILES.
8471
8472 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
8473
8474         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
8475         we don't set the fake simulator ptid to the null_ptid.
8476
8477 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
8478
8479         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
8480         * gdbthread.h (class thread_info) <resumed>: Likewise.
8481         * infrun.c (resume_1): Likewise.
8482         (proceed): Likewise.
8483         (infrun_thread_stop_requested): Likewise.
8484         (stop_all_threads): Likewise.
8485         (handle_inferior_event): Likewise.
8486         (restart_threads): Likewise.
8487         (finish_step_over): Likewise.
8488         (keep_going_stepped_thread): Likewise.
8489         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
8490         (linux_handle_extended_wait): Likewise.
8491         * record-btrace.c (get_thread_current_frame_id): Likewise.
8492         * record-full.c (record_full_wait_1): Likewise.
8493         * remote.c (remote_target::process_initial_stop_replies): Likewise.
8494         * target.c (target_resume): Likewise.
8495         * thread.c (set_running_thread): Likewise.
8496
8497 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8498
8499         * f-valprint.c (f77_print_array_1): Changed datatype of index
8500         variable to LONGEST from int to enable it to contain bound
8501         values correctly.
8502
8503 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
8504
8505         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
8506         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
8507         offsets according to FLEN determined.
8508         (riscv_linux_nat_target::read_description): Determine FLEN
8509         dynamically.
8510         (riscv_linux_nat_target::fetch_registers): Size regset buffer
8511         according to FLEN determined.
8512         (riscv_linux_nat_target::store_registers): Likewise.
8513
8514 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8515
8516         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8517         when reg->group is empty and reggroup is not.
8518
8519 2020-01-31  Tom Tromey  <tromey@adacore.com>
8520
8521         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
8522         Call beneath target's mourn_inferior after unpushing.
8523
8524 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8525
8526         PR tui/9765
8527         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
8528         have enough lines to fill the screen, still return the lowest
8529         address we found.
8530
8531 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8532
8533         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
8534         '-', '<', and '>' commands.
8535
8536 2020-01-29  Pedro Alves  <palves@redhat.com>
8537             Sergio Durigan Junior  <sergiodj@redhat.com>
8538
8539         * infcmd.c (construct_inferior_arguments): Assert that
8540         'argc' is greater than 0.
8541
8542 2020-01-29  Luis Machado  <luis.machado@linaro.org>
8543
8544         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
8545         (BRK_INSN_MASK): Define to 0xd4200000.
8546         (aarch64_program_breakpoint_here_p): New function.
8547         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
8548         * arch-utils.c (default_program_breakpoint_here_p): Moved from
8549         breakpoint.c.
8550         * arch-utils.h (default_program_breakpoint_here_p): Moved from
8551         breakpoint.h
8552         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
8553         call gdbarch_program_breakpoint_here_p.
8554         (program_breakpoint_here): Moved to arch-utils.c, renamed to
8555         default_program_breakpoint_here_p, changed return type to bool and
8556         simplified.
8557         * breakpoint.h (program_breakpoint_here): Moved prototype to
8558         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
8559         return type to bool.
8560         * gdbarch.c: Regenerate.
8561         * gdbarch.h: Regenerate.
8562         * gdbarch.sh (program_breakpoint_here_p): New method.
8563         * infrun.c (handle_signal_stop): Call
8564         gdbarch_program_breakpoint_here_p.
8565
8566 2020-01-26  Tom Tromey  <tom@tromey.com>
8567
8568         * ctfread.c (struct ctf_fp_info): Reindent.
8569         (_initialize_ctfread): Remove.
8570
8571 2020-01-26  Tom Tromey  <tom@tromey.com>
8572
8573         * psymtab.c (partial_map_expand_apply)
8574         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
8575         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
8576         (psym_print_stats, psym_expand_symtabs_for_function)
8577         (psym_map_symbol_filenames, psym_map_matching_symbols)
8578         (psym_expand_symtabs_matching)
8579         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
8580         (maintenance_check_psymtabs): Use new methods.
8581         * psympriv.h (struct partial_symtab) <readin_p,
8582         get_compunit_symtab>: New methods.
8583         <readin, compunit_symtab>: Remove members.
8584         (struct standard_psymtab): New.
8585         (struct legacy_psymtab): Derive from standard_psymtab.
8586         * dwarf2read.h (struct dwarf2_psymtab): Derive from
8587         standard_psymtab.
8588         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
8589
8590 2020-01-26  Tom Tromey  <tom@tromey.com>
8591
8592         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
8593         read_dependencies.  Add assert.
8594         * psymtab.c (partial_symtab::read_dependencies): New method.
8595         * psympriv.h (struct partial_symtab) <read_dependencies>: New
8596         method.
8597         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
8598         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
8599         read_dependencies.
8600         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
8601         Add assert.
8602
8603 2020-01-26  Tom Tromey  <tom@tromey.com>
8604
8605         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
8606         Call expand_psymtab.
8607         (xcoff_read_symtab): Call expand_psymtab.
8608         (xcoff_start_psymtab, xcoff_end_psymtab): Set
8609         legacy_expand_psymtab.
8610         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
8611         method.
8612         (struct legacy_psymtab) <expand_psymtab>: Implement.
8613         <legacy_expand_psymtab>: New member.
8614         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
8615         (parse_partial_symbols): Set legacy_expand_psymtab.
8616         (psymtab_to_symtab_1): Change argument order.  Call
8617         expand_psymtab.
8618         (new_psymtab): Set legacy_expand_psymtab.
8619         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
8620         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
8621         expand_psymtab.
8622         (dwarf2_psymtab::expand_psymtab): Rename from
8623         psymtab_to_symtab_1.  Call expand_psymtab.
8624         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
8625         (dbx_end_psymtab): Likewise.
8626         (dbx_psymtab_to_symtab_1): Change argument order. Call
8627         expand_psymtab.
8628         (dbx_read_symtab): Call expand_psymtab.
8629         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
8630         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
8631         (ctf_psymtab::read_symtab): Call expand_psymtab.
8632
8633 2020-01-26  Tom Tromey  <tom@tromey.com>
8634
8635         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
8636         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
8637         messages.
8638         * mdebugread.c (mdebug_read_symtab): Remove prints.
8639         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
8640         assert.
8641         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
8642
8643 2020-01-26  Tom Tromey  <tom@tromey.com>
8644
8645         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
8646         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
8647         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
8648         legacy_symtab.
8649         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
8650         * psymtab.c (psymtab_to_symtab): Call method.
8651         (dump_psymtab): Update.
8652         * psympriv.h (struct partial_symtab): Add virtual destructor.
8653         <read_symtab>: New method.
8654         (struct legacy_symtab): New.
8655         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
8656         (struct pst_map) <pst>: Now a legacy_psymtab.
8657         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
8658         (new_psymtab): Use legacy_psymtab.
8659         * dwarf2read.h (struct dwarf2_psymtab): New.
8660         (struct dwarf2_per_cu_data) <psymtab>: Use it.
8661         * dwarf2read.c (dwarf2_create_include_psymtab)
8662         (dwarf2_build_include_psymtabs, create_type_unit_group)
8663         (create_partial_symtab, process_psymtab_comp_unit_reader)
8664         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
8665         (set_partial_user): Use dwarf2_psymtab.
8666         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
8667         (psymtab_to_symtab_1, process_full_comp_unit)
8668         (process_full_type_unit, dwarf2_ranges_read)
8669         (dwarf2_get_pc_bounds, psymtab_include_file_name)
8670         (dwarf_decode_lines): Use dwarf2_psymtab.
8671         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
8672         (add_address_entry_worker, write_one_signatured_type)
8673         (recursively_count_psymbols, recursively_write_psymbols)
8674         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
8675         (write_debug_names): Likewise.
8676         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
8677         <pst>: Now a legacy_psymtab.
8678         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
8679         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
8680         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
8681         * ctfread.c (struct ctf_psymtab): New.
8682         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
8683         ctf_psymtab.
8684         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
8685         (create_partial_symtab): Return a ctf_psymtab.
8686         (scan_partial_symbols): Update.
8687
8688 2020-01-26  Tom Tromey  <tom@tromey.com>
8689
8690         * xcoffread.c (xcoff_start_psymtab): Use new.
8691         * psymtab.c (partial_symtab::partial_symtab): New constructor,
8692         renamed from start_psymtab_common.
8693         * psympriv.h (struct partial_symtab): Add new constructor.
8694         (start_psymtab_common): Don't declare.
8695         * mdebugread.c (parse_partial_symbols): Use new.
8696         * dwarf2read.c (create_partial_symtab): Use new.
8697         * dbxread.c (start_psymtab): Use new.
8698         * ctfread.c (create_partial_symtab): Use new.
8699
8700 2020-01-26  Tom Tromey  <tom@tromey.com>
8701
8702         * xcoffread.c (xcoff_end_psymtab): Use new.
8703         * psymtab.c (start_psymtab_common): Use new.
8704         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
8705         Update.
8706         * psympriv.h (struct partial_symtab): Add parameters to
8707         constructor.  Don't inline.
8708         (allocate_psymtab): Don't declare.
8709         * mdebugread.c (new_psymtab): Use new.
8710         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
8711         * dbxread.c (dbx_end_psymtab): Use new.
8712
8713 2020-01-26  Tom Tromey  <tom@tromey.com>
8714
8715         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
8716         allocate_psymtab.  Update documentation.
8717         * psymtab.c (psymtab_storage::install_psymtab): Rename from
8718         allocate_psymtab.  Do not use new.
8719         (allocate_psymtab): Use new.  Update.
8720
8721 2020-01-26  Tom Tromey  <tom@tromey.com>
8722
8723         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
8724         * psymtab.c (psym_print_stats): Update.
8725         * psympriv.h (struct partial_symtab) <readin,
8726         psymtabs_addrmap_supported, anonymous>: Now bool.
8727         * mdebugread.c (psymtab_to_symtab_1): Update.
8728         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
8729         (build_type_psymtabs_reader, psymtab_to_symtab_1)
8730         (process_full_comp_unit, process_full_type_unit): Update.
8731         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
8732         * ctfread.c (psymtab_to_symtab): Update.
8733
8734 2020-01-26  Tom Tromey  <tom@tromey.com>
8735
8736         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
8737         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
8738         * psymtab.c (psymtab_storage): Delete psymtabs.
8739         (psymtab_storage::allocate_psymtab): Use new.
8740         (psymtab_storage::discard_psymtab): Use delete.
8741         * psympriv.h (struct partial_symtab): Add constructor and
8742         initializers.
8743
8744 2020-01-26  Tom Tromey  <tom@tromey.com>
8745
8746         * machoread.c: Do not include psympriv.h.
8747
8748 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8749
8750         * NEWS: Mention the new option and the set/show commands.
8751
8752 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8753
8754         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
8755         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
8756         (validate_exec_file): New variables, enums, functions.
8757         (exec_file_locate_attach, print_section_info): Style the filenames.
8758         (_initialize_exec): Install show_exec_file_mismatch_command and
8759          set_exec_file_mismatch_command.
8760         * gdbcore.h (validate_exec_file): Declare.
8761         * infcmd.c (attach_command): Call validate_exec_file.
8762         * remote.c ( remote_target::remote_add_inferior): Likewise.
8763
8764 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * frame.c (find_frame_sal): Move call to get_next_frame into more
8767         inner scope.
8768         * inline-frame.c (inilne_state) <inline_state>: Update argument
8769         types.
8770         (inilne_state) <skipped_symbol>: Rename to...
8771         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
8772         (skip_inline_frames): Build vector of skipped symbols and use this
8773         to reate the inline_state.
8774         (inline_skipped_symbol): Add a comment and some assertions, fetch
8775         skipped symbol from the list.
8776
8777 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8778
8779         * buildsym.c (lte_is_less_than): Delete.
8780         (buildsym_compunit::end_symtab_with_blockvector): Create local
8781         lambda function to sort line table entries, and use
8782         std::stable_sort instead of std::sort.
8783         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
8784         markers when looking for a previous line.
8785
8786 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * dwarf2read.c (lnp_state_machine::record_line): Include
8789         end_sequence parameter in debug print out.  Record the line if we
8790         are at an end_sequence marker even if it's not the start of a
8791         statement.
8792         * symmisc.c (maintenance_print_one_line_table): Print end of
8793         sequence markers with 'END' not '0'.
8794
8795 2020-01-24  Pedro Alves  <palves@redhat.com>
8796
8797         PR gdb/25410
8798         * thread.c (scoped_restore_current_thread::restore): Use
8799         switch_to_inferior_no_thread.
8800         * exec.c: Include "progspace-and-thread.h".
8801         (add_target_sections, remove_target_sections):
8802         scoped_restore_current_pspace_and_thread instead of
8803         scoped_restore_current_thread.
8804         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
8805         and aspace to the inferior before calling clone_program_space.
8806         Remove stale comment.
8807
8808 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8809
8810         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
8811         (arm_netbsd_nat_target::fetch_registers): ...this.
8812         (arm_nbsd_nat_target::store_registers): Rename to...
8813         (arm_netbsd_nat_target::store_registers): ...this.
8814
8815 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8816
8817         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8818         register_t.
8819
8820 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8821
8822         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
8823         Update comment.
8824         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
8825         Likewise.
8826         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
8827         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
8828         the correct replacement (iterate_over_regset_sections).
8829         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
8830         Update comment.
8831
8832 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
8833
8834         PR gdb/23718
8835         * gdb/python/python.c (execute_gdb_command): Call
8836         async_enable_stdin in catch block.
8837
8838 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
8841         SWITCH_THRU_ALL_UIS.
8842
8843 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         PR tui/9765
8846         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
8847         comment, add extra parameter, and update to store previous symbol
8848         when appropriate.
8849         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
8850         add extra parameter.
8851         * tui/tui-disasm.c (tui_disassemble): Update header comment,
8852         remove unneeded parameter, add try/catch around gdb_print_insn,
8853         rewrite to add items to asm_lines vector.
8854         (tui_find_backward_disassembly_start_address): New function.
8855         (tui_find_disassembly_address): Updated throughout.
8856         (tui_disasm_window::set_contents): Update for changes to
8857         tui_disassemble.
8858         (tui_disasm_window::do_scroll_vertical): No need to adjust the
8859         number of lines to scroll.
8860
8861 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
8862
8863         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
8864         (SECT_OFF_DATA): Likewise.
8865         (SECT_OFF_RODATA): Likewise.
8866         (SECT_OFF_TEXT): Likewise.
8867         (SECT_OFF_BSS): Likewise.
8868         (struct objfile) <text_section_offset, data_section_offset>: New
8869         methods.
8870         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
8871         objfile::text_section_offset.
8872         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
8873         * coffread.c (coff_symtab_read): Likewise.
8874         (enter_linenos): Likewise.
8875         (process_coff_symbol): Likewise.
8876         * ctfread.c (get_objfile_text_range): Likewise.
8877         * dtrace-probe.c (dtrace_probe::get_relocated_address):
8878         Use objfile::data_section_offset.
8879         * dwarf2-frame.c (execute_cfa_program): Use
8880         objfile::text_section_offset.
8881         (dwarf2_frame_find_fde): Likewise.
8882         * dwarf2read.c (create_addrmap_from_index): Likewise.
8883         (create_addrmap_from_aranges): Likewise.
8884         (dw2_find_pc_sect_compunit_symtab): Likewise.
8885         (process_psymtab_comp_unit_reader): Likewise.
8886         (add_partial_symbol): Likewise.
8887         (add_partial_subprogram): Likewise.
8888         (process_full_comp_unit): Likewise.
8889         (read_file_scope): Likewise.
8890         (read_func_scope): Likewise.
8891         (read_lexical_block_scope): Likewise.
8892         (read_call_site_scope): Likewise.
8893         (dwarf2_rnglists_process): Likewise.
8894         (dwarf2_ranges_process): Likewise.
8895         (dwarf2_ranges_read): Likewise.
8896         (dwarf_decode_lines_1): Likewise.
8897         (new_symbol): Likewise.
8898         (dwarf2_fetch_die_loc_sect_off): Likewise.
8899         (dwarf2_per_cu_text_offset): Likewise.
8900         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
8901         * hppa-tdep.c (read_unwind_info): Likewise.
8902         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
8903         * psympriv.h (struct partial_symtab): Likewise.
8904         * psymtab.c (find_pc_sect_psymtab): Likewise.
8905         * solib-svr4.c (enable_break): Likewise.
8906         * stap-probe.c (relocate_address): Use
8907         objfile::data_section_offset.
8908         * xcoffread.c (enter_line_range): Use
8909         objfile::text_section_offset.
8910         (read_xcoff_symtab): Likewise.
8911
8912 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8913
8914         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
8915         declaration to narrower scopes.
8916
8917 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8918
8919         * darwin-nat.h (struct darwin_exception_msg, enum
8920         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
8921         Move up.
8922         (class darwin_nat_target) <wait_1, check_new_threads,
8923         decode_exception_message, decode_message, stop_inferior,
8924         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
8925         * darwin-nat.c (darwin_check_new_threads): Rename to...
8926         (darwin_nat_target::check_new_threads): ... this.
8927         (darwin_suspend_inferior_it): Remove.
8928         (darwin_decode_exception_message): Rename to...
8929         (darwin_nat_target::decode_exception_message): ... this.
8930         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8931         (darwin_decode_message): Rename to...
8932         (darwin_nat_target::decode_message): ... this.
8933         (cancel_breakpoint): Rename to...
8934         (darwin_nat_target::cancel_breakpoint): ... this.
8935         (darwin_wait): Rename to...
8936         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8937         instead of iterate_over_inferiors.
8938         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8939         (darwin_stop_inferior): Rename to...
8940         (darwin_nat_target::stop_inferior): ... this.
8941         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8942         (darwin_init_thread_list): Rename to...
8943         (darwin_nat_target::init_thread_list): ... this.
8944         (darwin_ptrace_him): Rename to...
8945         (darwin_nat_target::ptrace_him): ... this.
8946         (darwin_nat_target::create_inferior): Pass lambda function to
8947         fork_inferior.
8948         (darwin_nat_target::detach): Call stop_inferior instead of
8949         darwin_stop_inferior.
8950         * fork-inferior.h (fork_inferior): Change init_trace_fun
8951         parameter to gdb::function_view.
8952         * fork-inferior.c (fork_inferior): Likewise.
8953
8954 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8955
8956         * i386-cygwin-tdep.c (core_process_module_section): Update.
8957         * windows-nat.c (struct lm_info_windows): Add text_offset.
8958         (windows_xfer_shared_libraries): Update.
8959         * windows-tdep.c (windows_xfer_shared_library):
8960         Add text_offset_cached argument.
8961         * windows-tdep.h (windows_xfer_shared_library): Update.
8962
8963 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8964
8965         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8966
8967 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8968
8969         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8970         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8971         replace with range-based for.
8972         (gdbsim_interrupt_inferior): Remove.
8973         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8974         with a range-based for.  Inline code from
8975         gdbsim_interrupt_inferior.
8976
8977 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8978
8979         * infrun.c (proceed): Fix indentation.
8980
8981 2020-01-21  Tom Tromey  <tromey@adacore.com>
8982
8983         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8984         * python/python.c (python_extension_ops): Update.
8985         (gdbpy_colorize): New function.
8986         * python/lib/gdb/__init__.py (colorize): New function.
8987         * extension.h (ext_lang_colorize): Declare.
8988         * extension.c (ext_lang_colorize): New function.
8989         * extension-priv.h (struct extension_language_ops) <colorize>: New
8990         member.
8991         * cli/cli-style.c (_initialize_cli_style): Update help text.
8992
8993 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8994
8995         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8996         <cond>: Change type to bool.
8997         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8998         (aarch64_displaced_step_cb): Likewise.
8999         (aarch64_displaced_step_tb): Likewise.
9000
9001 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9002
9003         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
9004         output.
9005
9006 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9007
9008         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
9009         <pc_adjust>: Adjust the documentation.
9010         (aarch64_displaced_step_fixup): Check if PC really moved before
9011         adjusting it.
9012
9013 2020-01-19  Tom Tromey  <tom@tromey.com>
9014
9015         * disasm.c (~gdb_disassembler): New destructor.
9016         (gdb_buffered_insn_length): Call disassemble_free_target.
9017         * disasm.h (class gdb_disassembler): Declare destructor.  Use
9018         DISABLE_COPY_AND_ASSIGN.
9019
9020 2020-01-19  Tom Tromey  <tom@tromey.com>
9021
9022         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
9023         (die_reader_func_ftype): Remove.
9024         (cutu_reader): New class.
9025         (dw2_get_file_names_reader): Remove "data" parameter.
9026         (dw2_get_file_names): Use cutu_reader.
9027         (create_debug_type_hash_table): Update.
9028         (read_cutu_die_from_dwo): Update comment.
9029         (lookup_dwo_unit): Add dwo_name parameter.
9030         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
9031         die_reader_func_ftype and data parameters.
9032         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
9033         Remove die_reader_func_ftype and data parameters.
9034         (~cutu_reader): New; from init_cutu_and_read_dies.
9035         (cutu_reader::cutu_reader): Rename from
9036         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
9037         and data parameters.
9038         (init_cutu_and_read_dies_simple): Remove.
9039         (struct process_psymtab_comp_unit_data): Remove.
9040         (process_psymtab_comp_unit_reader): Remove data parameter; add
9041         want_partial_unit and pretend_language parameters.
9042         (process_psymtab_comp_unit): Use cutu_reader.
9043         (build_type_psymtabs_reader): Remove data parameter.
9044         (build_type_psymtabs_1): Use cutu_reader.
9045         (process_skeletonless_type_unit): Likewise.
9046         (load_partial_comp_unit_reader): Remove.
9047         (load_partial_comp_unit): Use cutu_reader.
9048         (load_full_comp_unit_reader): Remove.
9049         (load_full_comp_unit): Use cutu_reader.
9050         (struct create_dwo_cu_data): Remove.
9051         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
9052         dwo_unit parameters.
9053         (create_cus_hash_table): Use cutu_reader.
9054         (struct dwarf2_read_addr_index_data): Remove.
9055         (dwarf2_read_addr_index_reader): Remove.
9056         (dwarf2_read_addr_index): Use cutu_reader.
9057         (read_signatured_type_reader): Remove.
9058         (read_signatured_type): Use cutu_reader.
9059
9060 2020-01-19  Tom Tromey  <tom@tromey.com>
9061
9062         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
9063         * tui/tui-wingeneral.h (class tui_suppress_output): New.
9064         (tui_wrefresh): Declare.
9065         * tui/tui-wingeneral.c (suppress_output): New global.
9066         (tui_suppress_output, ~tui_suppress_output): New constructor and
9067         destructor.
9068         (tui_wrefresh): New function.
9069         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
9070         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
9071         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
9072         method.
9073         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
9074         tui_wrefresh.
9075         (tui_data_window::no_refresh): New method.
9076         (tui_data_item_window::refresh_window): Call tui_wrefresh.
9077         (tui_reg_command): Use tui_suppress_output
9078         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
9079         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
9080         method.
9081         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
9082
9083 2020-01-19  Tom Tromey  <tom@tromey.com>
9084
9085         * tui/tui-winsource.c (tui_update_source_windows_with_line):
9086         Handle case where symtab is null.
9087
9088 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
9089
9090         * linux-fork.c (one_fork_p): Simplify.
9091
9092 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9093
9094         * top.c (struct qt_args): Remove.
9095         (kill_or_detach): Change return type to void, replace `void *`
9096         parameter with a proper one.
9097         (print_inferior_quit_action):  Likewise.
9098         (quit_confirm): Use range-based for loop to iterate over inferiors.
9099         (quit_force): Likewise.
9100
9101 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9102
9103         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
9104         `void *` parameter with proper parameters.
9105         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
9106         (print_one_inferior): Change return type to void, replace `void *`
9107         parameter with proper parameters.
9108         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
9109         inferiors.
9110         (get_other_inferior): Remove.
9111         (mi_cmd_remove_inferior): Use range-based loop to iterate over
9112         inferiors.
9113
9114 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9115
9116         * mi/mi-interp.c (report_initial_inferior): Remove.
9117         (mi_interp::init): Use range-based for to iterate over inferiors.
9118
9119 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9120
9121         * python/py-inferior.c (build_inferior_list): Remove.
9122         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
9123
9124 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
9125
9126         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
9127         (btrace_stitch_trace): Likewise.
9128         * charset.c (intermediate_encoding): Likewise (vaild).
9129         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
9130         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
9131         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
9132
9133 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
9134
9135         * windows-tdep.c (windows_get_tlb_type):
9136         Add rtl_user_process_parameters type.
9137
9138 2020-01-16  Pedro Alves  <palves@redhat.com>
9139             Norbert Lange  <nolange79@gmail.com>
9140
9141         PR build/24805
9142         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
9143         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
9144         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
9145         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
9146         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
9147         (ps_plog): Redeclare exported functions with default visibility.
9148
9149 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
9150
9151         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
9152         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
9153
9154 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
9155
9156         * infcmd.c (post_create_inferior): Use get_thread_regcache
9157         instead of get_current_regcache.
9158
9159 2020-01-14  Tom Tromey  <tom@tromey.com>
9160
9161         PR symtab/12535:
9162         * python/python.c (gdbpy_decode_line): Treat empty string the same
9163         as no argument.
9164
9165 2020-01-14  Tom Tromey  <tom@tromey.com>
9166
9167         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
9168
9169 2020-01-14  Tom Tromey  <tom@tromey.com>
9170
9171         * nat/linux-btrace.c: Don't include <config.h>.
9172         * nat/linux-ptrace.c: Don't include <config.h>.
9173         * nat/x86-linux-dregs.c: Don't include <config.h>.
9174
9175 2020-01-14  Tom Tromey  <tom@tromey.com>
9176
9177         * configure: Rebuild.
9178         * configure.ac: Move many checks to ../gdbsupport/common.m4.
9179
9180 2020-01-14  Tom Tromey  <tom@tromey.com>
9181
9182         * nat/x86-linux-dregs.c: Include configh.h.
9183         * nat/linux-ptrace.c: Include configh.h.
9184         * nat/linux-btrace.c: Include configh.h.
9185         * defs.h: Include config.h, bfd.h.
9186         * configure.ac: Don't source common.host.
9187         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
9188         * configure: Rebuild.
9189         * acinclude.m4: Update path.
9190         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
9191         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
9192         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
9193         (CLIBS): Add LIBSUPPORT.
9194         (CDEPS): Likewise.
9195         (COMMON_SFILES): Remove gdbsupport files.
9196         (HFILES_NO_SRCDIR): Likewise.
9197         (stamp-version): Update path to create-version.sh.
9198         (ALLDEPFILES): Remove gdbsupport files.
9199
9200 2020-01-14  Tom Tromey  <tom@tromey.com>
9201
9202         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
9203         USE_WIN32API when needed.
9204         * configure.ac (USE_WIN32API): Don't define.
9205         (WIN32LIBS): Use WIN32APILIBS.
9206         * configure: Rebuild.
9207
9208 2020-01-14  Tom Tromey  <tom@tromey.com>
9209
9210         * configure: Rebuild.
9211         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
9212
9213 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9214
9215         * skip.c (skip_function_command): Make skip w/o arguments use the
9216         name of the inlined function if pc is inside any inlined function.
9217
9218 2020-01-14  Luis Machado  <luis.machado@linaro.org>
9219
9220         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
9221         * infrun.c (resume_1): Likewise.
9222         (handle_inferior_event): Remove stale comment.
9223         * linux-nat.c (linux_nat_target::resume): Update comments.
9224         (save_stop_reason): Likewise.
9225         (linux_nat_filter_event): Likewise.
9226         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
9227
9228 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * elfread.c (record_minimal_symbol): Set section index to 0 for
9231         non-allocatable sections.
9232
9233
9234 2020-01-13  Ali Tamur <tamur@google.com>
9235
9236         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
9237         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
9238         to gdb::optional.  Update comments.
9239         (dwo_file): Update comments.
9240         (read_attribute): Update API to take an additional out parameter,
9241         need_reprocess.  This is used to mark attributes that need other
9242         attributes (e.g. str_offsets_base) for correct computation which may not
9243         have been read yet.
9244         (read_attribute_reprocess): New function declaration.
9245         (read_addr_index): Likewise.
9246         (read_dwo_str_index): Likewise.
9247         (read_stub_str_index): Likewise.
9248         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
9249         (lookup_addr_base): New function definition.
9250         (lookup_ranges_base): Likewise.
9251         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
9252         lookup_ranges_base.
9253         (init_cutu_and_read_dies): Update comments.
9254         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
9255         unit.  This is used to inherit parent's str_offsets_base and addr_base.
9256         Update comments.
9257         (init_cutu_and_read_dies_simple): Reflect API changes.
9258         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
9259         (create_cus_hash_table): Change API to take parent compile unit.
9260         Reflect API changes.
9261         (open_and_init_dwo_file): Reflect API changes.
9262         (dwarf2_get_pc_bounds): Update comments.
9263         (dwarf2_record_block_ranges): Likewise.
9264         (read_full_die_1): Change implementation to reprocess attributes that
9265         need str_offsets_base and addr_base.
9266         (partial_die_info::read): Likewise.
9267         (read_attribute_reprocess): New function definition.
9268         (read_attribute_value): Change API to take an additional out parameter,
9269         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
9270         when a non-dwo compile unit has index based attributes.
9271         (read_attribute): Reflect API changes.
9272         (read_addr_index_1): Reflect API changes.  Update comments.
9273         (dwarf2_read_addr_index_data): Reflect API changes.
9274         (dwarf2_read_addr_index): Likewise.
9275         (read_str_index): Change API and implementation.  This becomes a helper
9276         to be used by the new string index related methods.  Update error
9277         message and comments.
9278         (read_dwo_str_index): New function definition.
9279         (read_stub_str_index): Likewise.
9280         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
9281         * symfile.h (dwarf2_debug_sections): Likewise.
9282         * xcoffread.c (dwarf2_debug_sections): Likewise.
9283
9284 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9285
9286         * gdbcore.h (struct core_fns) <core_read_registers>: Change
9287         core_reg_sect type to gdb_byte *.
9288         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
9289         * cris-tdep.c (fetch_core_registers): Likewise.
9290         * corelow.c (core_target::get_core_register_section): Change
9291         type of `contents` to gdb::byte_vector.
9292
9293 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9294
9295         * tui/tui-wingeneral.c (box_win): Position the title in the center
9296         of the border.
9297
9298 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9299
9300         * corelow.c (core_target::get_core_register_section): Use
9301           std::vector instead of alloca.
9302
9303 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9304
9305         * warning.m4: Add -Wmissing-declarations to build_warnings.
9306         * configure: Re-generate.
9307
9308 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9309
9310         * python/python.c (init__gdb_module): Add declaration.
9311
9312 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9313
9314         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
9315         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
9316         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
9317         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
9318         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
9319         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
9320         * ada-exp.y (_initialize_ada_exp): Add declaration.
9321         * ada-lang.c (_initialize_ada_language): Add declaration.
9322         * ada-tasks.c (_initialize_tasks): Add declaration.
9323         * agent.c (_initialize_agent): Add declaration.
9324         * aix-thread.c (_initialize_aix_thread): Add declaration.
9325         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
9326         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
9327         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
9328         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
9329         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
9330         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
9331         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
9332         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
9333         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
9334         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
9335         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
9336         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
9337         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
9338         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
9339         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
9340         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
9341         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
9342         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
9343         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
9344         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
9345         * annotate.c (_initialize_annotate): Add declaration.
9346         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
9347         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
9348         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
9349         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
9350         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
9351         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
9352         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
9353         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
9354         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
9355         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
9356         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
9357         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
9358         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
9359         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
9360         * auto-load.c (_initialize_auto_load): Add declaration.
9361         * auxv.c (_initialize_auxv): Add declaration.
9362         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
9363         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
9364         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
9365         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
9366         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
9367         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
9368         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
9369         * breakpoint.c (_initialize_breakpoint): Add declaration.
9370         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
9371         * btrace.c (_initialize_btrace): Add declaration.
9372         * charset.c (_initialize_charset): Add declaration.
9373         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
9374         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
9375         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
9376         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
9377         * cli/cli-script.c (_initialize_cli_script): Add declaration.
9378         * cli/cli-style.c (_initialize_cli_style): Add declaration.
9379         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
9380         * coffread.c (_initialize_coffread): Add declaration.
9381         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
9382         * compile/compile.c (_initialize_compile): Add declaration.
9383         * complaints.c (_initialize_complaints): Add declaration.
9384         * completer.c (_initialize_completer): Add declaration.
9385         * copying.c (_initialize_copying): Add declaration.
9386         * corefile.c (_initialize_core): Add declaration.
9387         * corelow.c (_initialize_corelow): Add declaration.
9388         * cp-abi.c (_initialize_cp_abi): Add declaration.
9389         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
9390         * cp-support.c (_initialize_cp_support): Add declaration.
9391         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
9392         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
9393         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
9394         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
9395         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
9396         * ctfread.c (_initialize_ctfread): Add declaration.
9397         * d-lang.c (_initialize_d_language): Add declaration.
9398         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
9399         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
9400         * dbxread.c (_initialize_dbxread): Add declaration.
9401         * dcache.c (_initialize_dcache): Add declaration.
9402         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
9403         * disasm.c (_initialize_disasm): Add declaration.
9404         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
9405         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
9406         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
9407         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
9408         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
9409         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
9410         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
9411         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
9412         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
9413         * elfread.c (_initialize_elfread): Add declaration.
9414         * exec.c (_initialize_exec): Add declaration.
9415         * extension.c (_initialize_extension): Add declaration.
9416         * f-lang.c (_initialize_f_language): Add declaration.
9417         * f-valprint.c (_initialize_f_valprint): Add declaration.
9418         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
9419         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
9420         * filesystem.c (_initialize_filesystem): Add declaration.
9421         * findcmd.c (_initialize_mem_search): Add declaration.
9422         * findvar.c (_initialize_findvar): Add declaration.
9423         * fork-child.c (_initialize_fork_child): Add declaration.
9424         * frame-base.c (_initialize_frame_base): Add declaration.
9425         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
9426         * frame.c (_initialize_frame): Add declaration.
9427         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
9428         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
9429         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
9430         * gcore.c (_initialize_gcore): Add declaration.
9431         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
9432         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
9433         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
9434         * gdbarch.c (_initialize_gdbarch): Add declaration.
9435         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
9436         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
9437         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
9438         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
9439         * go-lang.c (_initialize_go_language): Add declaration.
9440         * go32-nat.c (_initialize_go32_nat): Add declaration.
9441         * guile/guile.c (_initialize_guile): Add declaration.
9442         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
9443         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
9444         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
9445         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
9446         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
9447         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
9448         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
9449         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
9450         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
9451         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
9452         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
9453         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
9454         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
9455         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
9456         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
9457         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
9458         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
9459         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
9460         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
9461         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
9462         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
9463         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
9464         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
9465         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
9466         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
9467         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
9468         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
9469         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
9470         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
9471         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
9472         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
9473         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
9474         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
9475         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
9476         * infcall.c (_initialize_infcall): Add declaration.
9477         * infcmd.c (_initialize_infcmd): Add declaration.
9478         * inflow.c (_initialize_inflow): Add declaration.
9479         * infrun.c (_initialize_infrun): Add declaration.
9480         * interps.c (_initialize_interpreter): Add declaration.
9481         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
9482         * jit.c (_initialize_jit): Add declaration.
9483         * language.c (_initialize_language): Add declaration.
9484         * linux-fork.c (_initialize_linux_fork): Add declaration.
9485         * linux-nat.c (_initialize_linux_nat): Add declaration.
9486         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
9487         * linux-thread-db.c (_initialize_thread_db): Add declaration.
9488         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
9489         * m2-lang.c (_initialize_m2_language): Add declaration.
9490         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
9491         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
9492         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
9493         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
9494         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
9495         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
9496         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
9497         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
9498         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
9499         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
9500         * machoread.c (_initialize_machoread): Add declaration.
9501         * macrocmd.c (_initialize_macrocmd): Add declaration.
9502         * macroscope.c (_initialize_macroscope): Add declaration.
9503         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
9504         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
9505         * maint.c (_initialize_maint_cmds): Add declaration.
9506         * mdebugread.c (_initialize_mdebugread): Add declaration.
9507         * memattr.c (_initialize_mem): Add declaration.
9508         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
9509         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
9510         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
9511         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
9512         * mi/mi-main.c (_initialize_mi_main): Add declaration.
9513         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
9514         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
9515         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
9516         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
9517         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
9518         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
9519         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
9520         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
9521         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
9522         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
9523         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
9524         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
9525         * mipsread.c (_initialize_mipsread): Add declaration.
9526         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
9527         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
9528         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
9529         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
9530         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
9531         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
9532         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
9533         * nto-procfs.c (_initialize_procfs): Add declaration.
9534         * objc-lang.c (_initialize_objc_language): Add declaration.
9535         * observable.c (_initialize_observer): Add declaration.
9536         * opencl-lang.c (_initialize_opencl_language): Add declaration.
9537         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
9538         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
9539         * osabi.c (_initialize_gdb_osabi): Add declaration.
9540         * osdata.c (_initialize_osdata): Add declaration.
9541         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
9542         * parse.c (_initialize_parse): Add declaration.
9543         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
9544         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
9545         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
9546         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
9547         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
9548         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
9549         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
9550         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
9551         * printcmd.c (_initialize_printcmd): Add declaration.
9552         * probe.c (_initialize_probe): Add declaration.
9553         * proc-api.c (_initialize_proc_api): Add declaration.
9554         * proc-events.c (_initialize_proc_events): Add declaration.
9555         * proc-service.c (_initialize_proc_service): Add declaration.
9556         * procfs.c (_initialize_procfs): Add declaration.
9557         * producer.c (_initialize_producer): Add declaration.
9558         * psymtab.c (_initialize_psymtab): Add declaration.
9559         * python/python.c (_initialize_python): Add declaration.
9560         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
9561         * record-btrace.c (_initialize_record_btrace): Add declaration.
9562         * record-full.c (_initialize_record_full): Add declaration.
9563         * record.c (_initialize_record): Add declaration.
9564         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
9565         * regcache.c (_initialize_regcache): Add declaration.
9566         * reggroups.c (_initialize_reggroup): Add declaration.
9567         * remote-notif.c (_initialize_notif): Add declaration.
9568         * remote-sim.c (_initialize_remote_sim): Add declaration.
9569         * remote.c (_initialize_remote): Add declaration.
9570         * reverse.c (_initialize_reverse): Add declaration.
9571         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
9572         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
9573         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
9574         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
9575         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
9576         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
9577         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
9578         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
9579         Add declaration.
9580         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
9581         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
9582         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
9583         * rust-exp.y (_initialize_rust_exp): Add declaration.
9584         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
9585         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
9586         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
9587         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
9588         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
9589         * score-tdep.c (_initialize_score_tdep): Add declaration.
9590         * ser-go32.c (_initialize_ser_dos): Add declaration.
9591         * ser-mingw.c (_initialize_ser_windows): Add declaration.
9592         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
9593         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
9594         * ser-uds.c (_initialize_ser_socket): Add declaration.
9595         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
9596         * serial.c (_initialize_serial): Add declaration.
9597         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
9598         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
9599         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
9600         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
9601         * skip.c (_initialize_step_skip): Add declaration.
9602         * sol-thread.c (_initialize_sol_thread): Add declaration.
9603         * solib-aix.c (_initialize_solib_aix): Add declaration.
9604         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
9605         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
9606         * solib-frv.c (_initialize_frv_solib): Add declaration.
9607         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
9608         * solib-target.c (_initialize_solib_target): Add declaration.
9609         * solib.c (_initialize_solib): Add declaration.
9610         * source-cache.c (_initialize_source_cache): Add declaration.
9611         * source.c (_initialize_source): Add declaration.
9612         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
9613         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
9614         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
9615         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
9616         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
9617         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
9618         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
9619         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
9620         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
9621         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
9622         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
9623         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
9624         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
9625         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
9626         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
9627         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
9628         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
9629         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
9630         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
9631         * stabsread.c (_initialize_stabsread): Add declaration.
9632         * stack.c (_initialize_stack): Add declaration.
9633         * stap-probe.c (_initialize_stap_probe): Add declaration.
9634         * std-regs.c (_initialize_frame_reg): Add declaration.
9635         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
9636         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
9637         * symfile.c (_initialize_symfile): Add declaration.
9638         * symmisc.c (_initialize_symmisc): Add declaration.
9639         * symtab.c (_initialize_symtab): Add declaration.
9640         * target.c (_initialize_target): Add declaration.
9641         * target-connection.c (_initialize_target_connection): Add
9642         declaration.
9643         * target-dcache.c (_initialize_target_dcache): Add declaration.
9644         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
9645         * thread.c (_initialize_thread): Add declaration.
9646         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
9647         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
9648         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
9649         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
9650         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
9651         * tracectf.c (_initialize_ctf): Add declaration.
9652         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
9653         * tracefile.c (_initialize_tracefile): Add declaration.
9654         * tracepoint.c (_initialize_tracepoint): Add declaration.
9655         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
9656         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
9657         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
9658         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
9659         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
9660         * tui/tui-win.c (_initialize_tui_win): Add declaration.
9661         * tui/tui.c (_initialize_tui): Add declaration.
9662         * typeprint.c (_initialize_typeprint): Add declaration.
9663         * ui-style.c (_initialize_ui_style): Add declaration.
9664         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
9665         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
9666         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
9667         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
9668         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
9669         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
9670         * unittests/filtered_iterator-selftests.c
9671         (_initialize_filtered_iterator_selftests): Add declaration.
9672         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
9673         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
9674         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
9675         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
9676         * unittests/main-thread-selftests.c
9677         (_initialize_main_thread_selftests): Add declaration.
9678         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
9679         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
9680         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
9681         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
9682         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
9683         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
9684         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
9685         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
9686         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
9687         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
9688         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
9689         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
9690         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
9691         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
9692         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
9693         declaration.
9694         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
9695         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
9696         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
9697         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
9698         * user-regs.c (_initialize_user_regs): Add declaration.
9699         * utils.c (_initialize_utils): Add declaration.
9700         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
9701         * valops.c (_initialize_valops): Add declaration.
9702         * valprint.c (_initialize_valprint): Add declaration.
9703         * value.c (_initialize_values): Add declaration.
9704         * varobj.c (_initialize_varobj): Add declaration.
9705         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
9706         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
9707         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
9708         * windows-nat.c (_initialize_windows_nat): Add declaration.
9709         (_initialize_check_for_gdb_ini): Add declaration.
9710         (_initialize_loadable): Add declaration.
9711         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
9712         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
9713         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
9714         * xcoffread.c (_initialize_xcoffread): Add declaration.
9715         * xml-support.c (_initialize_xml_support): Add declaration.
9716         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
9717         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
9718         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
9719         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
9720
9721 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9722
9723         * regformats/regdat.sh: Generate declaration for init function.
9724
9725 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9726
9727         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
9728         up.
9729         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
9730         close_one_inferior>: New methods.
9731         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
9732         pass down target to find_inferior_pid.
9733         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
9734         Pass down target to find_inferior_ptid.
9735         (gdbsim_target::create_inferior): Pass down target to
9736         add_thread_silent.
9737         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
9738         target down to find_inferior_ptid and switch_to_thread.
9739         (gdbsim_target::close): Update to call close_one_inferior.
9740         (struct resume_data): Remove.
9741         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
9742         directly, rather than through a void pointer.
9743         (gdbsim_target::resume): Update to call resume_one_inferior.
9744
9745 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
9746
9747         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
9748
9749 2020-01-12  Pedro Alves  <palves@redhat.com>
9750
9751         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
9752         directly for the current inferior instead of
9753         discard_all_inferiors.
9754         (discard_all_inferiors): Delete.
9755
9756 2020-01-11  Tom Tromey  <tom@tromey.com>
9757
9758         * tui/tui-wingeneral.c (box_win): Check cli_styling.
9759         * tui/tui-winsource.c (tui_source_window_base::refill): Use
9760         deprecated_safe_get_selected_frame.
9761
9762 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9763
9764         * inferior.c (print_inferior): Switch inferior before printing it.
9765
9766 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
9767             Pedro Alves  <palves@redhat.com>
9768
9769         * progspace-and-thread.c (switch_to_program_space_and_thread):
9770         Assert there's an inferior for PSPACE.  Use
9771         switch_to_inferior_no_thread to switch the inferior too.
9772         * progspace.c (program_space::~program_space): Call
9773         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
9774         (program_space::free_all_objfiles): Don't call clear_symtab_users
9775         here.
9776         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
9777
9778 2020-01-10  Pedro Alves  <palves@redhat.com>
9779
9780         * NEWS: Mention multi-target debugging, "info connections", and
9781         "add-inferior -no-connection".
9782
9783 2020-01-10  Pedro Alves  <palves@redhat.com>
9784
9785         * infrun.c: Include "target-connection.h".
9786         (check_multi_target_resumption): New.
9787         (proceed): Call it.
9788         * target-connection.c (make_target_connection_string): Make
9789         extern.
9790         * target-connection.h (make_target_connection_string): Declare.
9791
9792 2020-01-10  Pedro Alves  <palves@redhat.com>
9793
9794         * Makefile.in (COMMON_SFILES): Add target-connection.c.
9795         * inferior.c (uiout_field_connection): New function.
9796         (print_inferior): Add new "connection-id" column.
9797         (add_inferior_command): Show connection number/string of added
9798         inferior.
9799         * process-stratum-target.h
9800         (process_stratum_target::connection_string): New virtual method.
9801         (process_stratum_target::connection_number): New field.
9802         * remote.c (remote_target::connection_string): New override.
9803         * target-connection.c: New file.
9804         * target-connection.h: New file.
9805         * target.c (decref_target): Remove process_stratum targets from
9806         the connection list.
9807         (target_stack::push): Add process_stratum targets to the
9808         connection list.
9809
9810 2020-01-10  Pedro Alves  <palves@redhat.com>
9811
9812         Revert:
9813         2016-04-12  Pedro Alves  <palves@redhat.com>
9814         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
9815         Remove references to name.
9816         * serial.h (struct serial) <name>: Delete.
9817
9818 2020-01-10  Pedro Alves  <palves@redhat.com>
9819
9820         * gdbarch-selftests.c (register_to_value_test): Remove "target
9821         already pushed" check.
9822
9823 2020-01-10  Pedro Alves  <palves@redhat.com>
9824             John Baldwin  <jhb@FreeBSD.org>
9825
9826         * aarch64-linux-nat.c
9827         (aarch64_linux_nat_target::thread_architecture): Adjust.
9828         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
9829         (task_command_1): Likewise.
9830         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
9831         (aix_thread_target::wait, aix_thread_target::fetch_registers)
9832         (aix_thread_target::store_registers)
9833         (aix_thread_target::thread_alive): Adjust.
9834         * amd64-fbsd-tdep.c: Include "inferior.h".
9835         (amd64fbsd_get_thread_local_address): Pass down target.
9836         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
9837         thread's gdbarch instead of target_gdbarch.
9838         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
9839         get_last_target_status.
9840         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
9841         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
9842         inferiors.
9843         (update_inserted_breakpoint_locations): Skip if inferiors with no
9844         execution.
9845         (update_global_location_list): When handling moribund locations,
9846         find representative inferior for location's pspace, and use thread
9847         count of its process_stratum target.
9848         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
9849         * bsd-uthread.c (bsd_uthread_target::wait): Use
9850         as_process_stratum_target and adjust thread_change_ptid and
9851         add_thread calls.
9852         (bsd_uthread_target::update_thread_list): Use
9853         as_process_stratum_target and adjust find_thread_ptid,
9854         thread_change_ptid and add_thread calls.
9855         * btrace.c (maint_btrace_packet_history_cmd): Adjust
9856         find_thread_ptid call.
9857         * corelow.c (add_to_thread_list): Adjust add_thread call.
9858         (core_target_open): Adjust add_thread_silent and thread_count
9859         calls.
9860         (core_target::pid_to_str): Adjust find_inferior_ptid call.
9861         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
9862         * event-top.c (async_disconnect): Pop targets from all inferiors.
9863         * exec.c (add_target_sections): Push exec target on all inferiors
9864         sharing the program space.
9865         (remove_target_sections): Remove the exec target from all
9866         inferiors sharing the program space.
9867         (exec_on_vfork): New.
9868         * exec.h (exec_on_vfork): Declare.
9869         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
9870         Pass it down.
9871         (fbsd_nat_target::update_thread_list): Adjust.
9872         (fbsd_nat_target::resume): Adjust.
9873         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
9874         down.
9875         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
9876         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
9877         get_thread_arch_regcache call.
9878         * fork-child.c (gdb_startup_inferior): Pass target down to
9879         startup_inferior and set_executing.
9880         * gdbthread.h (struct process_stratum_target): Forward declare.
9881         (add_thread, add_thread_silent, add_thread_with_info)
9882         (in_thread_list): Add process_stratum_target parameter.
9883         (find_thread_ptid(inferior*, ptid_t)): New overload.
9884         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
9885         parameter.
9886         (all_threads()): Delete overload.
9887         (all_threads, all_non_exited_threads): Add process_stratum_target
9888         parameter.
9889         (all_threads_safe): Use brace initialization.
9890         (thread_count): Add process_stratum_target parameter.
9891         (set_resumed, set_running, set_stop_requested, set_executing)
9892         (threads_are_executing, finish_thread_state): Add
9893         process_stratum_target parameter.
9894         (switch_to_thread): Use is_current_thread.
9895         * i386-fbsd-tdep.c: Include "inferior.h".
9896         (i386fbsd_get_thread_local_address): Pass down target.
9897         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
9898         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
9899         have_inferiors check.
9900         * inf-ptrace.c (inf_ptrace_target::create_inferior)
9901         (inf_ptrace_target::attach): Adjust.
9902         * infcall.c (run_inferior_call): Adjust.
9903         * infcmd.c (run_command_1): Pass target to
9904         scoped_finish_thread_state.
9905         (proceed_thread_callback): Skip inferiors with no execution.
9906         (continue_command): Rename 'all_threads' local to avoid hiding
9907         'all_threads' function.  Adjust get_last_target_status call.
9908         (prepare_one_step): Adjust set_running call.
9909         (signal_command): Use user_visible_resume_target.  Compare thread
9910         pointers instead of inferior_ptid.
9911         (info_program_command): Adjust to pass down target.
9912         (attach_command): Mark target's 'thread_executing' flag.
9913         (stop_current_target_threads_ns): New, factored out from ...
9914         (interrupt_target_1): ... this.  Switch inferior before making
9915         target calls.
9916         * inferior-iter.h
9917         (struct all_inferiors_iterator, struct all_inferiors_range)
9918         (struct all_inferiors_safe_range)
9919         (struct all_non_exited_inferiors_range): Filter on
9920         process_stratum_target too.  Remove explicit.
9921         * inferior.c (inferior::inferior): Push dummy target on target
9922         stack.
9923         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
9924         Add process_stratum_target parameter, and pass it down.
9925         (have_live_inferiors): Adjust.
9926         (switch_to_inferior_and_push_target): New.
9927         (add_inferior_command, clone_inferior_command): Handle
9928         "-no-connection" parameter.  Use
9929         switch_to_inferior_and_push_target.
9930         (_initialize_inferior): Mention "-no-connection" option in
9931         the help of "add-inferior" and "clone-inferior" commands.
9932         * inferior.h: Include "process-stratum-target.h".
9933         (interrupt_target_1): Use bool.
9934         (struct inferior) <push_target, unpush_target, target_is_pushed,
9935         find_target_beneath, top_target, process_target, target_at,
9936         m_stack>: New.
9937         (discard_all_inferiors): Delete.
9938         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9939         (all_inferiors, all_non_exited_inferiors): Add
9940         process_stratum_target parameter.
9941         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9942         (target_last_proc_target): New global.
9943         (follow_fork_inferior): Push target on new inferior.  Pass target
9944         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9945         reference count.
9946         (follow_fork): Adjust get_last_target_status call.  Also consider
9947         target.
9948         (follow_exec): Push target on new inferior.
9949         (struct execution_control_state) <target>: New field.
9950         (user_visible_resume_target): New.
9951         (do_target_resume): Call target_async.
9952         (resume_1): Set target's threads_executing flag.  Consider resume
9953         target.
9954         (commit_resume_all_targets): New.
9955         (proceed): Also consider resume target.  Skip threads of inferiors
9956         with no execution.  Commit resumtion in all targets.
9957         (start_remote): Pass current inferior to wait_for_inferior.
9958         (infrun_thread_stop_requested): Consider target as well.  Pass
9959         thread_info pointer to clear_inline_frame_state instead of ptid.
9960         (infrun_thread_thread_exit): Consider target as well.
9961         (random_pending_event_thread): New inferior parameter.  Use it.
9962         (do_target_wait): Rename to ...
9963         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9964         down.
9965         (threads_are_resumed_pending_p, do_target_wait): New.
9966         (prepare_for_detach): Adjust calls.
9967         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9968         do_target_wait_1 instead of do_target_wait.
9969         (fetch_inferior_event): Adjust.  Switch to representative
9970         inferior.  Pass target down.
9971         (set_last_target_status): Add process_stratum_target parameter.
9972         Save target in global.
9973         (get_last_target_status): Add process_stratum_target parameter and
9974         handle it.
9975         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9976         (context_switch): Check inferior_ptid == null_ptid before calling
9977         inferior_thread().
9978         (get_inferior_stop_soon): Pass down target.
9979         (wait_one): Rename to ...
9980         (poll_one_curr_target): ... this.
9981         (struct wait_one_event): New.
9982         (wait_one): New.
9983         (stop_all_threads): Adjust.
9984         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9985         event's target.
9986         (switch_back_to_stepped_thread): Also consider target.
9987         (print_stop_event): Update.
9988         (normal_stop): Update.  Also consider the resume target.
9989         * infrun.h (wait_for_inferior): Remove declaration.
9990         (user_visible_resume_target): New declaration.
9991         (get_last_target_status, set_last_target_status): New
9992         process_stratum_target parameter.
9993         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9994         process_stratum_target parameter, and use it.
9995         (clear_inline_frame_state (thread_info*)): New.
9996         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9997         process_stratum_target parameter.
9998         (clear_inline_frame_state (thread_info*)): Declare.
9999         * linux-fork.c (delete_checkpoint_command): Pass target down to
10000         find_thread_ptid.
10001         (checkpoint_command): Adjust.
10002         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
10003         instead of just tweaking inferior_ptid.
10004         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
10005         (exit_lwp): Pass target down to find_thread_ptid.
10006         (attach_proc_task_lwp_callback): Pass target down to
10007         add_thread/set_running/set_executing.
10008         (linux_nat_target::attach): Pass target down to
10009         thread_change_ptid.
10010         (get_detach_signal): Pass target down to find_thread_ptid.
10011         Consider last target status's target.
10012         (linux_resume_one_lwp_throw, resume_lwp)
10013         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
10014         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
10015         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
10016         (linux_nat_target::async_wait_fd): New.
10017         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
10018         target down.
10019         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
10020         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
10021         * linux-thread-db.c (struct thread_db_info::process_target): New
10022         field.
10023         (add_thread_db_info): Save target.
10024         (get_thread_db_info): New process_stratum_target parameter.  Also
10025         match target.
10026         (delete_thread_db_info): New process_stratum_target parameter.
10027         Also match target.
10028         (thread_from_lwp): Adjust to pass down target.
10029         (thread_db_notice_clone): Pass down target.
10030         (check_thread_db_callback): Pass down target.
10031         (try_thread_db_load_1): Always push the thread_db target.
10032         (try_thread_db_load, record_thread): Pass target down.
10033         (thread_db_target::detach): Pass target down.  Always unpush the
10034         thread_db target.
10035         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
10036         target down.  Always unpush the thread_db target.
10037         (find_new_threads_callback, thread_db_find_new_threads_2)
10038         (thread_db_target::update_thread_list): Pass target down.
10039         (thread_db_target::pid_to_str): Pass current inferior down.
10040         (thread_db_target::get_thread_local_address): Pass target down.
10041         (thread_db_target::resume, maintenance_check_libthread_db): Pass
10042         target down.
10043         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
10044         * procfs.c (procfs_target::procfs_init_inferior): Declare.
10045         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
10046         (procfs_init_inferior): Rename to ...
10047         (procfs_target::procfs_init_inferior): ... this and adjust.
10048         (procfs_target::create_inferior, procfs_notice_thread)
10049         (procfs_do_thread_registers): Adjust.
10050         * ppc-fbsd-tdep.c: Include "inferior.h".
10051         (ppcfbsd_get_thread_local_address): Pass down target.
10052         * proc-service.c (ps_xfer_memory): Switch current inferior and
10053         program space as well.
10054         (get_ps_regcache): Pass target down.
10055         * process-stratum-target.c
10056         (process_stratum_target::thread_address_space)
10057         (process_stratum_target::thread_architecture): Pass target down.
10058         * process-stratum-target.h
10059         (process_stratum_target::threads_executing): New field.
10060         (as_process_stratum_target): New.
10061         * ravenscar-thread.c
10062         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
10063         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
10064         down.
10065         * record-btrace.c (record_btrace_target::info_record): Adjust.
10066         (record_btrace_target::record_method)
10067         (record_btrace_target::record_is_replaying)
10068         (record_btrace_target::fetch_registers)
10069         (get_thread_current_frame_id, record_btrace_target::resume)
10070         (record_btrace_target::wait, record_btrace_target::stop): Pass
10071         target down.
10072         * record-full.c (record_full_wait_1): Switch to event thread.
10073         Pass target down.
10074         * regcache.c (regcache::regcache)
10075         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
10076         process_stratum_target parameter and handle it.
10077         (current_thread_target): New global.
10078         (get_thread_regcache): Add process_stratum_target parameter and
10079         handle it.  Switch inferior before calling target method.
10080         (get_thread_regcache): Pass target down.
10081         (get_thread_regcache_for_ptid): Pass target down.
10082         (registers_changed_ptid): Add process_stratum_target parameter and
10083         handle it.
10084         (registers_changed_thread, registers_changed): Pass target down.
10085         (test_get_thread_arch_aspace_regcache): New.
10086         (current_regcache_test): Define a couple local test_target_ops
10087         instances and use them for testing.
10088         (readwrite_regcache): Pass process_stratum_target parameter.
10089         (cooked_read_test, cooked_write_test): Pass mock_target down.
10090         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
10091         (get_thread_arch_aspace_regcache): Add process_stratum_target
10092         parameter.
10093         (regcache::target): New method.
10094         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
10095         (regcache::registers_changed_ptid): Add process_stratum_target
10096         parameter.
10097         (regcache::m_target): New field.
10098         (registers_changed_ptid): Add process_stratum_target parameter.
10099         * remote.c (remote_state::supports_vCont_probed): New field.
10100         (remote_target::async_wait_fd): New method.
10101         (remote_unpush_and_throw): Add remote_target parameter.
10102         (get_current_remote_target): Adjust.
10103         (remote_target::remote_add_inferior): Push target.
10104         (remote_target::remote_add_thread)
10105         (remote_target::remote_notice_new_inferior)
10106         (get_remote_thread_info): Pass target down.
10107         (remote_target::update_thread_list): Skip threads of inferiors
10108         bound to other targets.  (remote_target::close): Don't discard
10109         inferiors.  (remote_target::add_current_inferior_and_thread)
10110         (remote_target::process_initial_stop_replies)
10111         (remote_target::start_remote)
10112         (remote_target::remote_serial_quit_handler): Pass down target.
10113         (remote_target::remote_unpush_target): New remote_target
10114         parameter.  Unpush the target from all inferiors.
10115         (remote_target::remote_unpush_and_throw): New remote_target
10116         parameter.  Pass it down.
10117         (remote_target::open_1): Check whether the current inferior has
10118         execution instead of checking whether any inferior is live.  Pass
10119         target down.
10120         (remote_target::remote_detach_1): Pass down target.  Use
10121         remote_unpush_target.
10122         (extended_remote_target::attach): Pass down target.
10123         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
10124         (remote_target::append_resumption): Pass down target.
10125         (remote_target::append_pending_thread_resumptions)
10126         (remote_target::remote_resume_with_hc, remote_target::resume)
10127         (remote_target::commit_resume): Pass down target.
10128         (remote_target::remote_stop_ns): Check supports_vCont_probed.
10129         (remote_target::interrupt_query)
10130         (remote_target::remove_new_fork_children)
10131         (remote_target::check_pending_events_prevent_wildcard_vcont)
10132         (remote_target::remote_parse_stop_reply)
10133         (remote_target::process_stop_reply): Pass down target.
10134         (first_remote_resumed_thread): New remote_target parameter.  Pass
10135         it down.
10136         (remote_target::wait_as): Pass down target.
10137         (unpush_and_perror): New remote_target parameter.  Pass it down.
10138         (remote_target::readchar, remote_target::remote_serial_write)
10139         (remote_target::getpkt_or_notif_sane_1)
10140         (remote_target::kill_new_fork_children, remote_target::kill): Pass
10141         down target.
10142         (remote_target::mourn_inferior): Pass down target.  Use
10143         remote_unpush_target.
10144         (remote_target::core_of_thread)
10145         (remote_target::remote_btrace_maybe_reopen): Pass down target.
10146         (remote_target::pid_to_exec_file)
10147         (remote_target::thread_handle_to_thread_info): Pass down target.
10148         (remote_target::async_wait_fd): New.
10149         * riscv-fbsd-tdep.c: Include "inferior.h".
10150         (riscv_fbsd_get_thread_local_address): Pass down target.
10151         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
10152         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
10153         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
10154         Adjust.
10155         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
10156         * solib-svr4.c (enable_break): Pass down target.
10157         * spu-multiarch.c (parse_spufs_run): Pass down target.
10158         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
10159         * target-delegates.c: Regenerate.
10160         * target.c (g_target_stack): Delete.
10161         (current_top_target): Return the current inferior's top target.
10162         (target_has_execution_1): Refer to the passed-in inferior's top
10163         target.
10164         (target_supports_terminal_ours): Check whether the initial
10165         inferior was already created.
10166         (decref_target): New.
10167         (target_stack::push): Incref/decref the target.
10168         (push_target, push_target, unpush_target): Adjust.
10169         (target_stack::unpush): Defref target.
10170         (target_is_pushed): Return bool.  Adjust to refer to the current
10171         inferior's target stack.
10172         (dispose_inferior): Delete, and inline parts ...
10173         (target_preopen): ... here.  Only dispose of the current inferior.
10174         (target_detach): Hold strong target reference while detaching.
10175         Pass target down.
10176         (target_thread_name): Add assertion.
10177         (target_resume): Pass down target.
10178         (target_ops::beneath, find_target_at): Adjust to refer to the
10179         current inferior's target stack.
10180         (get_dummy_target): New.
10181         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
10182         has a thread running.
10183         (initialize_targets): Rename to ...
10184         (_initialize_target): ... this.
10185         * target.h: Include "gdbsupport/refcounted-object.h".
10186         (struct target_ops): Inherit refcounted_object.
10187         (target_ops::shortname, target_ops::longname): Make const.
10188         (target_ops::async_wait_fd): New method.
10189         (decref_target): Declare.
10190         (struct target_ops_ref_policy): New.
10191         (target_ops_ref): New typedef.
10192         (get_dummy_target): Declare function.
10193         (target_is_pushed): Return bool.
10194         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
10195         (all_matching_threads_iterator::all_matching_threads_iterator):
10196         Handle filter target.
10197         * thread-iter.h (struct all_matching_threads_iterator, struct
10198         all_matching_threads_range, class all_non_exited_threads_range):
10199         Filter by target too.  Remove explicit.
10200         * thread.c (threads_executing): Delete.
10201         (inferior_thread): Pass down current inferior.
10202         (clear_thread_inferior_resources): Pass down thread pointer
10203         instead of ptid_t.
10204         (add_thread_silent, add_thread_with_info, add_thread): Add
10205         process_stratum_target parameter.  Use it for thread and inferior
10206         searches.
10207         (is_current_thread): New.
10208         (thread_info::deletable): Use it.
10209         (find_thread_ptid, thread_count, in_thread_list)
10210         (thread_change_ptid, set_resumed, set_running): New
10211         process_stratum_target parameter.  Pass it down.
10212         (set_executing): New process_stratum_target parameter.  Pass it
10213         down.  Adjust reference to 'threads_executing'.
10214         (threads_are_executing): New process_stratum_target parameter.
10215         Adjust reference to 'threads_executing'.
10216         (set_stop_requested, finish_thread_state): New
10217         process_stratum_target parameter.  Pass it down.
10218         (switch_to_thread): Also match inferior.
10219         (switch_to_thread): New process_stratum_target parameter.  Pass it
10220         down.
10221         (update_threads_executing): Reimplement.
10222         * top.c (quit_force): Pop targets from all inferior.
10223         (gdb_init): Don't call initialize_targets.
10224         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
10225         Declare.
10226         (windows_add_thread, windows_delete_thread): Adjust.
10227         (get_windows_debug_event): Rename to ...
10228         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
10229         * tracefile-tfile.c (tfile_target_open): Pass down target.
10230         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
10231         Forward declare.
10232         (switch_to_thread): Add process_stratum_target parameter.
10233         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
10234         parameter.  Use it.
10235         (mi_on_resume): Pass target down.
10236         * nat/fork-inferior.c (startup_inferior): Add
10237         process_stratum_target parameter.  Pass it down.
10238         * nat/fork-inferior.h (startup_inferior): Add
10239         process_stratum_target parameter.
10240         * python/py-threadevent.c (py_get_event_thread): Pass target down.
10241
10242 2020-01-10  Pedro Alves  <palves@redhat.com>
10243
10244         * remote.c (remote_target::start_remote): Don't set inferior_ptid
10245         directly.  Instead find the first thread in the thread list and
10246         use switch_to_thread.
10247
10248 2020-01-10  Pedro Alves  <palves@redhat.com>
10249
10250         * remote.c (remote_target::remote_add_inferior): Don't bind a
10251         process to the current inferior if the current inferior is already
10252         bound to a process.
10253
10254 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
10255             Pedro Alves  <palves@redhat.com>
10256
10257         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
10258         If no process is specified, return null_ptid instead of
10259         inferior_ptid.
10260         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
10261         TARGET_WAITKIND_SIGNALLED with no pid.
10262
10263 2020-01-10  Pedro Alves  <palves@redhat.com>
10264
10265         * remote.c (first_remote_resumed_thread): New.
10266         (remote_target::wait_as): Use it as default event_ptid instead of
10267         inferior_ptid.
10268
10269 2020-01-10  Pedro Alves  <palves@redhat.com>
10270
10271         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
10272
10273 2020-01-10  Pedro Alves  <palves@redhat.com>
10274
10275         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
10276         not -1.
10277
10278 2020-01-10  Pedro Alves  <palves@redhat.com>
10279
10280         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
10281         ptid to get_last_target_status.
10282         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
10283         ptid to get_last_target_status.
10284         * infcmd.c (continue_command): Don't pass a target_waitstatus to
10285         get_last_target_status.
10286         (info_program_command): Don't pass a target_waitstatus to
10287         get_last_target_status.
10288         * infrun.c (init_wait_for_inferior): Use
10289         nullify_last_target_wait_ptid.
10290         (get_last_target_status): Handle nullptr arguments.
10291         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
10292         (print_stop_event): Don't pass a ptid to get_last_target_status.
10293         (normal_stop): Don't pass a ptid to get_last_target_status.
10294         * infrun.h (get_last_target_status, set_last_target_status): Move
10295         comments here and update.
10296         (nullify_last_target_wait_ptid): Declare.
10297         * linux-fork.c (fork_load_infrun_state): Remove local extern
10298         declaration of nullify_last_target_wait_ptid.
10299         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
10300         to get_last_target_status.
10301
10302 2020-01-10  Pedro Alves  <palves@redhat.com>
10303
10304         * gdbthread.h (scoped_restore_current_thread)
10305         <dont_restore, restore, m_dont_restore>: Declare.
10306         * thread.c (thread_alive): Add assertion.  Return bool.
10307         (switch_to_thread_if_alive): New.
10308         (prune_threads): Switch inferior/thread.
10309         (print_thread_info_1): Switch thread before calling target methods.
10310         (scoped_restore_current_thread::restore): New, factored out from
10311         ...
10312         (scoped_restore_current_thread::~scoped_restore_current_thread):
10313         ... this.
10314         (scoped_restore_current_thread::scoped_restore_current_thread):
10315         Add assertion.
10316         (thread_apply_all_command, thread_select): Use
10317         switch_to_thread_if_alive.
10318         * infrun.c (proceed, restart_threads, handle_signal_stop)
10319         (switch_back_to_stepped_thread): Switch current thread before
10320         calling target methods.
10321
10322 2020-01-10  Pedro Alves <palves@redhat.com>
10323
10324         * inferior.c (switch_to_inferior_no_thread): New function,
10325         factored out from ...
10326         (inferior_command): ... here.
10327         * inferior.h (switch_to_inferior_no_thread): Declare.
10328         * mi/mi-main.c (run_one_inferior): Use
10329         switch_to_inferior_no_thread.
10330
10331 2020-01-10  Pedro Alves  <palves@redhat.com>
10332
10333         * infcmd.c (kill_command): Remove dead code.
10334
10335 2020-01-10  Pedro Alves  <palves@redhat.com>
10336
10337         * remote.c (remote_target::mourn_inferior): No longer check
10338         whether the target is running.
10339
10340 2020-01-10  Pedro Alves  <palves@redhat.com>
10341
10342         * corelow.c (core_target::has_execution): Change parameter type to
10343         inferior pointer.
10344         * inferior.c (number_of_live_inferiors): Use
10345         inferior::has_execution instead of target_has_execution_1.
10346         * inferior.h (inferior::has_execution): New.
10347         * linux-thread-db.c (thread_db_target::update_thread_list): Use
10348         inferior::has_execution instead of target_has_execution_1.
10349         * process-stratum-target.c
10350         (process_stratum_target::has_execution): Change parameter type to
10351         inferior pointer.  Check the inferior's PID instead of
10352         inferior_ptid.
10353         * process-stratum-target.h
10354         (process_stratum_target::has_execution): Change parameter type to
10355         inferior pointer.
10356         * record-full.c (record_full_core_target::has_execution): Change
10357         parameter type to inferior pointer.
10358         * target.c (target_has_execution_1): Change parameter type to
10359         inferior pointer.
10360         (target_has_execution_current): Adjust.
10361         * target.h (target_ops::has_execution): Change parameter type to
10362         inferior pointer.
10363         (target_has_execution_1): Change parameter type to inferior
10364         pointer.  Change return type to bool.
10365         * tracefile.h (tracefile_target::has_execution): Change parameter
10366         type to inferior pointer.
10367
10368 2020-01-10  Pedro Alves  <palves@redhat.com>
10369
10370         * exceptions.c (print_flush): Remove current_top_target() check.
10371
10372 2020-01-10  Pedro Alves  <palves@redhat.com>
10373
10374         * remote.c (show_remote_exec_file): Show the current inferior's
10375         exec-file instead of the command variable's value.
10376
10377 2020-01-10  Pedro Alves  <palves@redhat.com>
10378
10379         * record-full.c (record_full_resume_ptid): New global.
10380         (record_full_target::resume): Set it.
10381         (record_full_wait_1): Use record_full_resume_ptid instead of
10382         inferior_ptid.
10383
10384 2020-01-10  Pedro Alves  <palves@redhat.com>
10385
10386         * gdbthread.h (scoped_restore_current_thread)
10387         <dont_restore, restore, m_dont_restore>: Declare.
10388         * thread.c (thread_alive): Add assertion.  Return bool.
10389         (switch_to_thread_if_alive): New.
10390         (prune_threads): Switch inferior/thread.
10391         (print_thread_info_1): Switch thread before calling target methods.
10392         (scoped_restore_current_thread::restore): New, factored out from
10393         ...
10394         (scoped_restore_current_thread::~scoped_restore_current_thread):
10395         ... this.
10396         (scoped_restore_current_thread::scoped_restore_current_thread):
10397         Add assertion.
10398         (thread_apply_all_command, thread_select): Use
10399         switch_to_thread_if_alive.
10400
10401 2020-01-10  George Barrett  <bob@bob131.so>
10402
10403         * stap-probe.c (stap_modify_semaphore): Don't check for null
10404         semaphores.
10405         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
10406         for null semaphores.
10407
10408 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10409
10410         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
10411         all source windows, and maintain horizontal scroll status while
10412         doing so.
10413
10414 2020-01-09  Tom Tromey  <tom@tromey.com>
10415
10416         PR tui/18932:
10417         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
10418         update_source_window, not print_source_lines.
10419
10420 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10421
10422         * tui/tui.c (tui_enable): Register tui hooks after calling
10423         tui_display_main.
10424
10425 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10426
10427         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
10428
10429 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
10430
10431         * thread.c (print_thread_info_1): Fix indentation.
10432
10433 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10434
10435         * symtab.c (general_symbol_info::compute_and_set_names): Move the
10436         unique_xmalloc_ptr outside the if to always free the demangled name.
10437
10438 2020-01-08  Tom Tromey  <tromey@adacore.com>
10439
10440         * xcoffread.c (enter_line_range, read_xcoff_symtab)
10441         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
10442         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
10443         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
10444         Remove.
10445         (section_offsets): New typedef.
10446         * symtab.c (fixup_section, get_msymbol_address): Update.
10447         * symmisc.c (dump_msymbols): Update.
10448         * symfile.h (relative_addr_info_to_section_offsets)
10449         (symfile_map_offsets_to_segments): Update.
10450         * symfile.c (build_section_addr_info_from_objfile)
10451         (init_objfile_sect_indices): Update.
10452         (struct place_section_arg): Change type of "offsets".
10453         (place_section): Update.
10454         (relative_addr_info_to_section_offsets): Change type of
10455         "section_offsets".  Remove "num_sections" parameter.
10456         (default_symfile_offsets, syms_from_objfile_1)
10457         (set_objfile_default_section_offset): Update.
10458         (reread_symbols): No need to preserve section offsets by hand.
10459         (symfile_map_offsets_to_segments): Change type of "offsets".
10460         * stap-probe.c (relocate_address): Update.
10461         * stabsread.h (process_one_symbol): Update.
10462         * solib-target.c (struct lm_info_target) <offsets>: Change type.
10463         (solib_target_relocate_section_addresses): Update.
10464         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
10465         Update.
10466         * solib-frv.c (frv_relocate_main_executable): Update.
10467         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
10468         * solib-aix.c (solib_aix_get_section_offsets): Change return
10469         type.
10470         (solib_aix_solib_create_inferior_hook): Update.
10471         * remote.c (remote_target::get_offsets): Update.
10472         * psymtab.c (find_pc_sect_psymtab): Update.
10473         * psympriv.h (struct partial_symbol) <address, text_low,
10474         text_high>: Update.
10475         * objfiles.h (obj_section_offset): Update.
10476         (struct objfile) <section_offsets>: Change type.
10477         <num_sections>: Remove.
10478         (objfile_relocate): Update.
10479         * objfiles.c (entry_point_address_query): Update
10480         (relocate_one_symbol): Change type of "section_offsets".
10481         (objfile_relocate1, objfile_relocate1): Change type of
10482         "new_offsets".
10483         (objfile_rebase1): Update.
10484         * mipsread.c (mipscoff_symfile_read): Update.
10485         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
10486         parameter.
10487         * mdebugread.c (parse_symbol): Change type of "section_offsets".
10488         (parse_external, psymtab_to_symtab_1): Update.
10489         * machoread.c (macho_symfile_offsets): Update.
10490         * ia64-tdep.c (ia64_find_unwind_table): Update.
10491         * hppa-tdep.c (read_unwind_info): Update.
10492         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
10493         * dwarf2read.c (create_addrmap_from_index)
10494         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10495         (process_psymtab_comp_unit_reader, add_partial_symbol)
10496         (add_partial_subprogram, process_full_comp_unit)
10497         (read_file_scope, read_func_scope, read_lexical_block_scope)
10498         (read_call_site_scope, dwarf2_rnglists_process)
10499         (dwarf2_ranges_process, dwarf2_ranges_read)
10500         (dwarf_decode_lines_1, var_decode_location, new_symbol)
10501         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
10502         Update.
10503         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
10504         Update.
10505         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
10506         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
10507         (process_one_symbol): Change type of "section_offsets".
10508         * ctfread.c (get_objfile_text_range): Update.
10509         * coffread.c (coff_symtab_read, enter_linenos)
10510         (process_coff_symbol): Update.
10511         * coff-pe-read.c (add_pe_forwarded_sym): Update.
10512         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
10513
10514 2020-01-08  Tom Tromey  <tromey@adacore.com>
10515
10516         * dwarf2read.c (parse_macro_definition): Use std::string.
10517         (parse_macro_definition): Likewise.
10518
10519 2020-01-08  Tom Tromey  <tromey@adacore.com>
10520
10521         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
10522         (ATTR_ALLOC_CHUNK): Remove.
10523
10524 2020-01-08  Tom Tromey  <tromey@adacore.com>
10525
10526         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
10527
10528 2020-01-08  Tom Tromey  <tromey@adacore.com>
10529
10530         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
10531         (dwarf2_compute_name, open_dwo_file): Likewise.
10532         (process_enumeration_scope): Use std::vector.
10533         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
10534         (partial_die_info::fixup, dwarf2_start_subfile)
10535         (guess_full_die_structure_name, dwarf2_name): Likewise.
10536         (determine_prefix): Update.
10537         (guess_full_die_structure_name): Make return type const.
10538         (partial_die_full_name): Return unique_xmalloc_ptr.
10539         (DW_FIELD_ALLOC_CHUNK): Remove.
10540
10541 2020-01-07  Tom Tromey  <tromey@adacore.com>
10542
10543         PR build/24937:
10544         * stap-probe.c (class stap_static_probe_ops): Add constructor.
10545
10546 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10547
10548         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
10549
10550 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10551
10552         * stack.c (print_frame_info): Move disassemble_next_line code
10553         inside source_print block.
10554
10555 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10556
10557         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
10558         gdb/signals.h, as we are now using native signal symbols.
10559
10560 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10561
10562         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
10563         overflow by an early check of content vs threshold.
10564         * tui/tui-source.c (tui_source_window::line_is_displayed):
10565         Likewise.
10566
10567 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10568
10569         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
10570
10571 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10572
10573         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
10574         export table if no section contains it's RVA.
10575
10576 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10577
10578         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
10579
10580 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
10581
10582         * source.c (print_source_lines_base): Set last_line_listed.
10583
10584 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10585
10586         * tui/tui-disasm.c: Remove trailing spaces.
10587
10588 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10589             Pedro Alves  <palves@redhat.com>
10590
10591         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
10592         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
10593         (windows_gdb_signal_to_target): New function, uses the above
10594         enumeration to convert GDB internal signal codes to equivalent
10595         Windows codes.
10596         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
10597         * windows-nat.c: Include "gdb_wait.h".
10598         (get_windows_debug_event): Extract the fatal exception from the
10599         exit status and convert to the equivalent Posix signal number.
10600         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
10601         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
10602         * gdbsupport/gdb_wait.c: New file, implements
10603         windows_status_to_termsig.
10604         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
10605         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
10606
10607 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10608
10609         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
10610         show_layout.
10611
10612 2020-01-05  Luis Machado  <luis.machado@linaro.org>
10613
10614         * aarch64-linux-nat.c
10615         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
10616         and bfd_mach_aarch64.
10617
10618 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10619
10620         * ui-file.c (stdio_file::can_emit_style_escape)
10621         (tee_file::can_emit_style_escape): Ensure style is used also on
10622         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
10623         to gdb_stdout.
10624         * main.c (set_gdb_data_directory): Use file style to output the
10625         warning that the given pathname is not a directory.
10626         * top.c (show_history_filename, gdb_safe_append_history)
10627         (show_gdb_datadir): Use file style.
10628
10629 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10630
10631         * solib-target.c (struct lm_info_target):
10632         Change offsets to be a unique_xmalloc_ptr.
10633         (solib_target_relocate_section_addresses): Update.
10634
10635 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10636
10637         * windows-nat.c (windows_clear_solib): Free so_list linked list.
10638
10639 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10640
10641         * MAINTAINERS (Write After Approval): Add myself.
10642
10643 2020-01-02  Luis Machado  <luis.machado@linaro.org>
10644
10645         * proc-service.c (get_ps_regcache): Remove reference to obsolete
10646         Cell BE architecture.
10647         * target.h (struct target_ops) <thread_architecture>: Likewise.
10648
10649 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10650
10651         * Makefile.in: Use INSTALL_PROGRAM_ENV.
10652
10653 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10654
10655         * MAINTAINERS (Write After Approval): Add myself.
10656
10657 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10658
10659         * gdbarch.sh: Update copyright year range of generated files.
10660
10661 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10662
10663         Update copyright year range in all GDB files.
10664
10665 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10666
10667         * copyright.py: Convert to Python 3.
10668
10669 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10670
10671         * copyright.py: Adapt after move of gnulib directory from gdb
10672         directory to toplevel directory.
10673
10674 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10675
10676         * copyright.py (main): Exit if run from the wrong directory.
10677
10678 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10679
10680         * top.c (print_gdb_version): Change copyright year to 2020.
10681
10682 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10683
10684         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
10685
10686 For older changes see ChangeLog-2019.
10687 \f
10688 Local Variables:
10689 mode: change-log
10690 left-margin: 8
10691 fill-column: 74
10692 version-control: never
10693 coding: utf-8
10694 End: