gdb/ChangeLog

   1 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
   2             Jiong Wang  <jiong.wang@arm.com>
   3
   4         * aarch64-linux-nat.c
   5         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
   6         * aarch64-linux-tdep.c
   7         (aarch64_linux_core_read_description): Likewise.
   8         (aarch64_linux_get_hwcap): New function.
   9         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
  10         (aarch64_linux_get_hwcap): New declaration.
  11
  12 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  13             Jiong Wang  <jiong.wang@arm.com>
  14
  15         * aarch64-linux-nat.c
  16         (aarch64_linux_nat_target::read_description): Add pauth param.
  17         * aarch64-linux-tdep.c
  18         (aarch64_linux_core_read_description): Likewise.
  19         * aarch64-tdep.c (struct target_desc): Add in pauth.
  20         (aarch64_read_description): Add pauth param.
  21         (aarch64_gdbarch_init): Likewise.
  22         * aarch64-tdep.h (aarch64_read_description): Likewise.
  23         * arch/aarch64.c (aarch64_create_target_description): Likewise.
  24         * arch/aarch64.h (aarch64_create_target_description): Likewise.
  25         * features/Makefile: Add new files.
  26         * features/aarch64-pauth.c: New file.
  27         * features/aarch64-pauth.xml: New file.
  28
  29 2019-03-20  Tom Tromey  <tromey@adacore.com>
  30
  31         * infrun.c (handle_inferior_event): Rename from
  32         handle_inferior_event_1.  Create a scoped_value_mark.
  33         (handle_inferior_event): Remove.
  34
  35 2019-03-19  Tom Tromey  <tromey@adacore.com>
  36
  37         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
  38         * infrun.h (print_stop_event): Add "displays" parameter.
  39         * infrun.c (print_stop_event): Add "displays" parameter.
  40
  41 2019-03-19  Pedro Alves  <palves@redhat.com>
  42
  43         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
  44         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
  45         to -1.  Fix TABs vs spaces.
  46         (tui_ui_out::tui_ui_out): Don't initialize fields here.
  47         * tui/tui-out.h (tui_ui_out) Add intro comments.
  48         <m_line, m_start_of_line>: In-class initialize, and add describing
  49         comment.
  50
  51 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
  52
  53         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
  54         variable names.
  55         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
  56
  57 2019-03-18  Pedro Alves  <palves@redhat.com>
  58             Eli Zaretskii <eliz@gnu.org>
  59
  60         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
  61         m_line and m_start_of_line.
  62
  63 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
  64
  65         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  66         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  67         it returns a newline.  This fixes a regression in TU mode, whereby
  68         the next line is output on the same screen line as the user input.
  69
  70 2019-03-18  Tom Tromey  <tromey@adacore.com>
  71
  72         * minsyms.c (minimal_symbol_reader::install): Remove call to
  73         obstack_blank.
  74
  75 2019-03-18  Pedro Alves  <palves@redhat.com>
  76
  77         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  78         New globals.
  79         (apply_style): New, factored out from ...
  80         (apply_ansi_escape): ... this.  Handle reverse video mode.
  81         (tui_set_reverse_mode): New function.
  82         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  83         * tui/tui-winsource.c (tui_show_source_line): Use
  84         tui_set_reverse_mode instead of setting A_STANDOUT.
  85         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  86         New setter methods.
  87
  88 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  89
  90         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  91         Handle tabs.
  92
  93 2019-03-18  Tom Tromey  <tromey@adacore.com>
  94
  95         * ada-lang.c (empty_array): Add "high" parameter.
  96         (ada_evaluate_subexp): Update.
  97
  98 2019-03-17  Sergei Trofimovich <siarheit@google.com>
  99
 100         * unittests/string_view-selftests.c: Define
 101         _initialize_string_view_selftests unconditionally.
 102
 103 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 104
 105         PR gdb/24350
 106         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 107
 108 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 109
 110         PR gdb/24351
 111         * windows-nat.c (display_selector): Fix format specifiers.
 112
 113 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 114
 115         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 116         tui_refill_source_window instead of tui_refresh_win, to update the
 117         current execution line.  This fixes redisplay of the current line
 118         when stepping through the code with "next" or "step".
 119
 120 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 121
 122         * source-cache.c (source_cache::get_source_lines): Call
 123         find_source_lines to initialize s->nlines.  This fixes vertical
 124         scrolling of TUI source window when the DOWN arrow is pressed.
 125
 126 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 127
 128         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 129         linux-thread-db.c (_initialize_thread_db): Likewise.
 130
 131 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 132
 133         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 134         wclrtoeol in tui_show_source_line".  This reverts changes made in
 135         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 136
 137 2019-03-15  Tom Tromey  <tom@tromey.com>
 138
 139         * symtab.h (struct minimal_symbol): Derive from
 140         general_symbol_info.
 141         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 142         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 143         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 144         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 145         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 146         (MSYMBOL_SEARCH_NAME): Update.
 147         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 148         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 149         * minsyms.c (minimal_symbol_reader::record_full): Update.
 150
 151 2019-03-15  Tom Tromey  <tom@tromey.com>
 152
 153         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 154
 155 2019-03-15  Tom Tromey  <tom@tromey.com>
 156
 157         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 158         unique_xmalloc_ptr.
 159         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 160         Update.
 161         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 162         (build_minimal_symbol_hash_tables)
 163         (minimal_symbol_reader::install): Update.
 164
 165 2019-03-15  Tom Tromey  <tom@tromey.com>
 166
 167         * symtab.c (create_demangled_names_hash): Update.
 168         (symbol_set_names): Update.
 169         * objfiles.h (struct objfile_per_bfd_storage)
 170         <demangled_names_hash>: Now an htab_up.
 171         * objfiles.c (objfile_per_bfd_storage): Simplify.
 172
 173 2019-03-15  Tom Tromey  <tom@tromey.com>
 174
 175         * objfiles.h (struct objfile_per_bfd_storage): Declare
 176         destructor.
 177         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 178         New.
 179         (get_objfile_bfd_data): Use new.  Don't initialize
 180         language_of_main.
 181         (free_objfile_per_bfd_storage): Remove.
 182         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 183
 184 2019-03-15  Tom Tromey  <tom@tromey.com>
 185
 186         * symfile.c (reread_symbols): Update.
 187         * objfiles.c (objfile::objfile): Update.
 188         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 189         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 190         comment.
 191         (minimal_symbol_reader::install): Update.
 192         (terminate_minimal_symbol_table): Remove.
 193         * jit.c (jit_object_close_impl): Update.
 194
 195 2019-03-15  Tom Tromey  <tom@tromey.com>
 196
 197         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 198         initializations.
 199
 200 2019-03-15  Tom Tromey  <tom@tromey.com>
 201
 202         * objfiles.h (struct objfile_per_bfd_storage)
 203         <demangled_hash_languages>: Now a bitset.
 204         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 205         (lookup_minimal_symbol): Update.
 206
 207 2019-03-15  Tom Tromey  <tom@tromey.com>
 208
 209         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 210         Don't return the symbol.
 211         * coffread.c (record_minimal_symbol): Use record_full.
 212
 213 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 214
 215         The MS-Windows port of ncurses fails to switch to a color pair if
 216         one or both of the colors are the implicit default colors.  This
 217         change records the default colors when TUI is initialized, and
 218         then specifies them explicitly when a color pair uses the default
 219         colors.  This allows color styling in TUI mode on MS-Windows.
 220
 221         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 222         ncurses_norm_attr.
 223         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 224         colors in ncurses_norm_attr.
 225         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 226         "none", replace it with the default color recorded in
 227         ncurses_norm_attr.
 228
 229 2019-03-14  Tom Tromey  <tromey@adacore.com>
 230
 231         * source-cache.h (class source_cache) <get_source_lines>: Return
 232         std::string.
 233         * source-cache.c (source_cache::extract_lines): Handle case where
 234         first_pos==npos.  Return std::string.
 235         (source_cache::get_source_lines): Update.
 236
 237 2019-03-14  Tom Tromey  <tromey@adacore.com>
 238
 239         * NEWS: Add item for "style sources" commands.
 240         * source-cache.c (source_cache::get_source_lines): Check
 241         source_styling.
 242         * cli/cli-style.c (source_styling): New global.
 243         (_initialize_cli_style): Add "style sources" commands.
 244         (show_style_sources): New function.
 245         * cli/cli-style.h (source_styling): Declare.
 246
 247 2019-03-14  Pedro Alves  <palves@redhat.com>
 248             Tom Tromey  <tromey@adacore.com>
 249
 250         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 251         * tui/tui-winsource.c (tui_refill_source_window): New function,
 252         from...
 253         (tui_horizontal_source_scroll): ... here.  Move some logic.
 254         * cli/cli-style.c (set_style_enabled): Notify new observable.
 255         * tui/tui-hooks.c (tui_redisplay_source): New function.
 256         (tui_attach_detach_observers): Attach or detach
 257         tui_redisplay_source.
 258         * observable.h (source_styling_changed): New observable.
 259         * observable.c: Define source_styling_changed observable.
 260
 261 2019-03-13  Tom Tromey  <tromey@adacore.com>
 262
 263         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 264         (i386_gnu_nat_target::store_registers): Update.
 265         * target-debug.h (target_debug_print_std_string): New macro.
 266         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 267         * windows-tdep.c (display_one_tib): Update.
 268         * tui/tui-stack.c (tui_make_status_line): Update.
 269         * top.c (print_inferior_quit_action): Update.
 270         * thread.c (thr_try_catch_cmd): Update.
 271         (add_thread_with_info): Update.
 272         (thread_target_id_str): Update.
 273         (thr_try_catch_cmd): Update.
 274         (thread_command): Update.
 275         (thread_find_command): Update.
 276         * record-btrace.c (record_btrace_target::info_record)
 277         (record_btrace_resume_thread, record_btrace_target::resume)
 278         (record_btrace_cancel_resume, record_btrace_step_thread)
 279         (record_btrace_target::wait, record_btrace_target::wait)
 280         (record_btrace_target::wait, record_btrace_target::stop): Update.
 281         * progspace.c (print_program_space): Update.
 282         * process-stratum-target.c
 283         (process_stratum_target::thread_address_space): Update.
 284         * linux-fork.c (linux_fork_mourn_inferior)
 285         (detach_checkpoint_command, info_checkpoints_command)
 286         (linux_fork_context): Update.
 287         (linux_fork_detach): Update.
 288         (class scoped_switch_fork_info): Update.
 289         (delete_checkpoint_command): Update.
 290         * infrun.c (follow_fork_inferior): Update.
 291         (follow_fork_inferior): Update.
 292         (proceed_after_vfork_done): Update.
 293         (handle_vfork_child_exec_or_exit): Update.
 294         (follow_exec): Update.
 295         (displaced_step_prepare_throw): Update.
 296         (displaced_step_restore): Update.
 297         (start_step_over): Update.
 298         (resume_1): Update.
 299         (clear_proceed_status_thread): Update.
 300         (proceed): Update.
 301         (print_target_wait_results): Update.
 302         (do_target_wait): Update.
 303         (context_switch): Update.
 304         (stop_all_threads): Update.
 305         (restart_threads): Update.
 306         (finish_step_over): Update.
 307         (handle_signal_stop): Update.
 308         (switch_back_to_stepped_thread): Update.
 309         (keep_going_pass_signal): Update.
 310         (print_exited_reason): Update.
 311         (normal_stop): Update.
 312         * inferior.c (inferior_pid_to_str): Change return type.
 313         (print_selected_inferior): Update.
 314         (add_inferior): Update.
 315         (detach_inferior): Update.
 316         * dummy-frame.c (fprint_dummy_frames): Update.
 317         * dcache.c (dcache_info_1): Update.
 318         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 319         (btrace_fetch, btrace_clear): Update.
 320         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 321         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 322         type.
 323         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 324         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 325         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 326         * gdbarch.c, gdbarch.h: Rebuild.
 327         * gdbarch.sh (core_pid_to_str): Change return type.
 328         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 329         return type.
 330         (windows_nat_target::pid_to_str): Change return type.
 331         (windows_delete_thread): Update.
 332         (windows_nat_target::attach): Update.
 333         (windows_nat_target::files_info): Update.
 334         * target-delegates.c: Rebuild.
 335         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 336         return type.
 337         (sol_thread_target::pid_to_str): Change return type.
 338         * remote.c (class remote_target) <pid_to_str>: Change return
 339         type.
 340         (remote_target::pid_to_str): Change return type.
 341         (extended_remote_target::attach, remote_target::remote_stop_ns)
 342         (remote_target::remote_notif_remove_queued_reply)
 343         (remote_target::push_stop_reply, remote_target::disable_btrace):
 344         Update.
 345         (extended_remote_target::attach): Update.
 346         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 347         type.
 348         (gdbsim_target::pid_to_str): Change return type.
 349         * ravenscar-thread.c (struct ravenscar_thread_target)
 350         <pid_to_str>: Change return type.
 351         (ravenscar_thread_target::pid_to_str): Change return type.
 352         * procfs.c (class procfs_target) <pid_to_str>: Change return
 353         type.
 354         (procfs_target::pid_to_str): Change return type.
 355         (procfs_target::attach): Update.
 356         (procfs_target::detach): Update.
 357         (procfs_target::fetch_registers): Update.
 358         (procfs_target::store_registers): Update.
 359         (procfs_target::wait): Update.
 360         (procfs_target::files_info): Update.
 361         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 362         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 363         return type.
 364         (nto_procfs_target::pid_to_str): Change return type.
 365         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 366         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 367         return type.
 368         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 369         (exit_lwp): Update.
 370         (attach_proc_task_lwp_callback, get_detach_signal)
 371         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 372         (linux_nat_target::resume, wait_lwp, stop_callback)
 373         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 374         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 375         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 376         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 377         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 378         type.
 379         (inf_ptrace_target::attach): Update.
 380         (inf_ptrace_target::files_info): Update.
 381         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 382         type.
 383         (go32_nat_target::pid_to_str): Change return type.
 384         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 385         (gnu_nat_target::wait): Update.
 386         (gnu_nat_target::wait): Update.
 387         (gnu_nat_target::resume): Update.
 388         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 389         (fbsd_nat_target::wait): Update.
 390         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 391         type.
 392         (darwin_nat_target::attach): Update.
 393         * corelow.c (class core_target) <pid_to_str>: Change return type.
 394         (core_target::pid_to_str): Change return type.
 395         * target.c (normal_pid_to_str): Change return type.
 396         (default_pid_to_str): Likewise.
 397         (target_pid_to_str): Change return type.
 398         (target_translate_tls_address): Update.
 399         (target_announce_detach): Update.
 400         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 401         return type.
 402         (bsd_uthread_target::pid_to_str): Change return type.
 403         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 404         type.
 405         (bsd_kvm_target::pid_to_str): Change return type.
 406         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 407         return type.
 408         (aix_thread_target::pid_to_str): Change return type.
 409         * target.h (struct target_ops) <pid_to_str>: Change return type.
 410         (target_pid_to_str, normal_pid_to_str): Likewise.
 411         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 412         type.
 413         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 414         type.
 415         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 416         return type.
 417         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 418         type.
 419         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 420         type.
 421         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 422         return type.
 423
 424 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 425
 426         * NEWS: Mention that the new default MI version is 3.  Mention
 427         changes to the output of commands and events that deal with
 428         multi-location breakpoints.
 429         * breakpoint.c: Include "mi/mi-out.h".
 430         (print_one_breakpoint): Change output syntax if using MI version
 431         >= 3.
 432         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 433         New.
 434         (mi_multi_location_breakpoint_output_fixed): New.
 435         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 436         (mi_cmd_fix_multi_location_breakpoint_output): New.
 437         (mi_multi_location_breakpoint_output_fixed): New.
 438         * mi/mi-cmds.c (mi_cmds): Register command
 439         -fix-multi-location-breakpoint-output.
 440         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 441         interpreter "mi".
 442
 443 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 444
 445         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 446         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 447         instantiate mi_ui_out based on interpreter name.
 448         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 449         * mi/mi-main.c (mi_load_progress): Likewise.
 450
 451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 452
 453         * NEWS: Combine separate "New targets" sections for 8.3.
 454
 455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 456
 457         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 458         (ppcfbsd_init_abi): Install gdbarch
 459         "fetch_tls_load_module_address" and "get_thread_local_address"
 460         methods.
 461
 462 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 463
 464         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 465         (riscv_fbsd_init_abi): Install gdbarch
 466         "fetch_tls_load_module_address" and "get_thread_local_address"
 467         methods.
 468
 469 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 470
 471         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 472         (i386fbsd_init_abi): Install gdbarch
 473         "fetch_tls_load_module_address" and "get_thread_local_address"
 474         methods.
 475
 476 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 477
 478         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 479         (amd64fbsd_init_abi): Install gdbarch
 480         "fetch_tls_load_module_address" and "get_thread_local_address"
 481         methods.
 482
 483 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 484
 485         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 486         (struct fbsd_pspace_data): New type.
 487         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 488         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 489         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 490         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 491         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 492
 493 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 494
 495         * gdbtypes.c (lookup_struct_elt): New function.
 496         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 497         * gdbtypes.h (struct struct_elt): New type.
 498         (lookup_struct_elt): New prototype.
 499
 500 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 501
 502         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 503         remove disabled code block.
 504
 505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 506
 507         * gdbarch.sh (get_thread_local_address): New method.
 508         * gdbarch.h, gdbarch.c: Regenerate.
 509         * target.c (target_translate_tls_address): Use
 510         gdbarch_get_thread_local_address if present instead of
 511         target::get_thread_local_address.
 512
 513 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 514
 515         * target.h (target::get_thread_local_address): Update comment.
 516
 517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 518
 519         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 520         objfile->separate_debug_objfile_backlink if not NULL.
 521
 522 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 523
 524         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 525         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 526         (amd64bsd_store_inferior_registers): Likewise.
 527         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 528         Enable segment base registers.
 529         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 530         PT_GETFSBASE and PT_GETGSBASE.
 531         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 532         PT_SETGSBASE.
 533         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 534         segment base registers.
 535         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 536
 537 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 538
 539         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 540         Update calls to i386_target_description to add 'segments'
 541         parameter.
 542         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 543         add segment base registers.
 544         * arch/i386.c (i386_create_target_description): Add 'segments'
 545         parameter to enable segment base registers.
 546         * arch/i386.h (i386_create_target_description): Likewise.
 547         * features/i386/32bit-segments.xml: New file.
 548         * features/i386/32bit-segments.c: Generate.
 549         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 550         call to i386_target_description to add 'segments' parameter.
 551         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 552         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 553         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 554         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 555         if feature is present.
 556         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 557         Add 'segments' parameter to call to i386_target_description.
 558         (i386_target_description): Add 'segments' parameter to enable
 559         segment base registers.
 560         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 561         to call to i386_target_description.
 562         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 563         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 564         Define I386_NUM_REGS.
 565         (i386_target_description): Add 'segments' parameter to enable
 566         segment base registers.
 567
 568 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 569
 570         PR/24325
 571         * source-cache.c: #undef open and close, to avoid unresolved
 572         externals during linking.
 573
 574 2019-03-12  Tom Tromey  <tromey@adacore.com>
 575
 576         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 577         const.  Add initializers.
 578         (_initialize_remote): Don't initialize ptid globals.
 579
 580 2019-03-12  Pedro Alves  <palves@redhat.com>
 581
 582         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 583
 584 2019-03-12  Pedro Alves  <palves@redhat.com>
 585
 586         * cp-name-parser.y (main): Remove unused 'len' variable.
 587
 588 2019-03-12  Tom Tromey  <tromey@adacore.com>
 589
 590         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 591         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 592
 593 2019-03-12  Tom Tromey  <tromey@adacore.com>
 594
 595         * linux-nat.c (iterate_over_lwps): Update.
 596         (stop_callback): Remove parameter.
 597         (stop_wait_callback, detach_callback, resume_set_callback)
 598         (select_singlestep_lwp_callback, set_ignore_sigint)
 599         (status_callback, resumed_callback, resume_clear_callback)
 600         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 601         data parameter.
 602         (linux_nat_target::detach, linux_nat_target::resume)
 603         (linux_stop_and_wait_all_lwps, select_event_lwp)
 604         (linux_nat_filter_event, linux_nat_wait_1)
 605         (linux_nat_target::kill, linux_nat_target::stop)
 606         (linux_nat_target::stop): Update.
 607         (linux_nat_resume_callback): Change type.
 608         (resume_stopped_resumed_lwps, count_events_callback)
 609         (select_event_lwp_callback): Likewise.
 610         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 611         * arm-linux-nat.c (struct update_registers_data): Remove.
 612         (update_registers_callback): Change type.
 613         (arm_linux_insert_hw_breakpoint1): Update.
 614         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 615         parameter.
 616         (x86_linux_dr_set_addr): Update.
 617         (x86_linux_dr_set_control): Update.
 618         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 619         (iterate_over_lwps): Use gdb::function_view.
 620         * nat/aarch64-linux-hw-point.c (struct
 621         aarch64_dr_update_callback_param): Remove.
 622         (debug_reg_change_callback): Change type.
 623         (aarch64_notify_debug_reg_change): Update.
 624         * s390-linux-nat.c (s390_refresh_per_info): Update.
 625
 626 2019-03-11  Tom Tromey  <tromey@adacore.com>
 627
 628         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 629         redundant assignment to "this_cu".
 630
 631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 632
 633         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 634
 635 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 636
 637         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 638         from...
 639         (rank_one_type): ... this.
 640
 641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 642
 643         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 644         from...
 645         (rank_one_type): ... this.
 646
 647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 648
 649         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 650         from...
 651         (rank_one_type): ... this.
 652
 653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 654
 655         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 656         from...
 657         (rank_one_type): ... this.
 658
 659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 660
 661         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 662         from...
 663         (rank_one_type): ... this.
 664
 665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 666
 667         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 668         from...
 669         (rank_one_type): ... this.
 670
 671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 672
 673         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 674         from...
 675         (rank_one_type): ... this.
 676
 677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 678
 679         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 680         from...
 681         (rank_one_type): ... this.
 682
 683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 684
 685         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 686         from...
 687         (rank_one_type): ... this.
 688
 689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 690
 691         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 692         from...
 693         (rank_one_type): ... this.
 694
 695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 696
 697         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 698         from...
 699         (rank_one_type): ... this.
 700
 701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 702
 703         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 704         from...
 705         (rank_one_type): ... this.
 706
 707 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 708
 709         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 710         inferior-events' shows the example events.
 711
 712 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 713
 714         Support styling on native MS-Windows console
 715
 716         PR/24315
 717         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 718         on MS-Windows if $TERM is not defined.
 719
 720         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 721
 722         * posix-hdep.c (gdb_console_fputs):
 723         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 724         functions.
 725         * ui-file.h (gdb_console_fputs): Add prototype.
 726
 727         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 728         back to fputs only if the former returns zero.
 729
 730 2019-03-07  Tom Tromey  <tom@tromey.com>
 731
 732         * symmisc.c (print_symbol_bcache_statistics): Update.
 733         (print_objfile_statistics): Update.
 734         * symfile.c (allocate_symtab): Update.
 735         * stabsread.c: Don't include bcache.h.
 736         * psymtab.h (struct psymbol_bcache): Don't declare.
 737         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 738         (psymbol_bcache_init, psymbol_bcache_free)
 739         (psymbol_bcache_get_bcache): Don't declare.
 740         * psymtab.c (struct psymbol_bcache): Remove.
 741         (psymtab_storage::psymtab_storage): Update.
 742         (psymtab_storage::~psymtab_storage): Update.
 743         (psymbol_bcache_init, psymbol_bcache_free)
 744         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 745         (add_psymbol_to_bcache): Update.
 746         (allocate_psymtab): Update.
 747         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 748         macro_cache>: No longer pointers.
 749         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 750         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 751         * macrotab.c (macro_bcache): Update.
 752         * macroexp.c: Don't include bcache.h.
 753         * gdbtypes.c (check_types_worklist): Update.
 754         (types_deeply_equal): Remove TRY/CATCH.  Update.
 755         * elfread.c (elf_symtab_read): Update.
 756         * dwarf2read.c: Don't include bcache.h.
 757         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 758         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 759         (print_bcache_statistics, bcache_memory_used): Don't declare.
 760         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 761         methods.  Rename all data members.
 762         * bcache.c (struct bcache): Move to bcache.h.
 763         (bcache::expand_hash_table): Rename from expand_hash_table.
 764         (bcache): Remove.
 765         (bcache::insert): Rename from bcache_full.
 766         (bcache::compare): Rename from bcache_compare.
 767         (bcache_xmalloc): Remove.
 768         (bcache::~bcache): Rename from bcache_xfree.
 769         (bcache::print_statistics): Rename from print_bcache_statistics.
 770         (bcache::memory_used): Rename from bcache_memory_used.
 771
 772 2019-03-07  Pedro Alves  <palves@redhat.com>
 773
 774         * infrun.c (normal_stop): Also check for
 775         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 776
 777 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * f-lang.c (value_from_host_double): Moved to...
 780         * value.c (value_from_host_double): ...here.
 781         * value.h (value_from_host_double): Declare.
 782         * guile/scm-math.c (vlscm_convert_typed_number): Use
 783         value_from_host_double.
 784         (vlscm_convert_number): Likewise.
 785         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 786         * python/py-value.c (convert_value_from_python): Likewise.
 787
 788 2019-03-06  Tom Tromey  <tom@tromey.com>
 789
 790         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 791
 792 2019-03-06  Tom Tromey  <tom@tromey.com>
 793
 794         * utils.h (free_current_contents): Don't declare.
 795         * utils.c (free_current_contents): Remove.
 796
 797 2019-03-06  Tom Tromey  <tom@tromey.com>
 798
 799         * top.c (quit_force): Update.
 800         * main.c (captured_command_loop): Update.
 801         * common/new-op.c (operator new): Update.
 802         * common/common-exceptions.c (struct catcher)
 803         <save_cleanup_chain>: Remove member.
 804         (exceptions_state_mc_init): Update.
 805         (exception_try_scope_entry): Return nullptr.
 806         (exception_try_scope_exit, exception_rethrow)
 807         (throw_exception_sjlj, throw_exception_cxx): Update.
 808         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 809         (all_cleanups, do_cleanups, discard_cleanups)
 810         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 811         (restore_cleanups, restore_final_cleanups): Don't declare.
 812         (do_final_cleanups): Remove parameter.
 813         * common/cleanups.c (cleanup_chain, make_cleanup)
 814         (make_cleanup_dtor, all_cleanups, do_cleanups)
 815         (discard_my_cleanups, discard_cleanups)
 816         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 817         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 818         (null_cleanup): Remove.
 819         (do_final_cleanups): Remove parameter.
 820
 821 2019-03-06  Tom Tromey  <tom@tromey.com>
 822
 823         * remote.c (remote_target::remote_parse_stop_reply): Use
 824         unique_xmalloc_ptr.
 825
 826 2019-03-06  Tom Tromey  <tom@tromey.com>
 827
 828         * stabsread.c (struct stabs_field_info): Rename from field_info.
 829         <list, fnlist>: Add initializers.
 830         <obstack>: New member.
 831         (read_member_functions, read_struct_fields, read_baseclasses):
 832         Allocate on obstack.  Don't use cleanups.
 833         (read_one_struct_field, read_member_functions, read_struct_fields)
 834         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 835         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 836         (read_struct_type): Update.
 837
 838 2019-03-06  Tom Tromey  <tom@tromey.com>
 839
 840         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 841         * common/filestuff.h (make_cleanup_close): Don't declare.
 842         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 843         Remove.
 844
 845 2019-03-06  Tom Tromey  <tom@tromey.com>
 846
 847         * solib-aix.c: Use make_scope_exit.
 848
 849 2019-03-06  Tom Tromey  <tom@tromey.com>
 850
 851         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 852         Use make_scope_exit.
 853
 854 2019-03-06  Tom Tromey  <tom@tromey.com>
 855
 856         * solib-svr4.c (disable_probes_interface): Remove parameter.
 857         (svr4_handle_solib_event): Use make_scope_exit.
 858
 859 2019-03-06  Tom Tromey  <tom@tromey.com>
 860
 861         * remote.c (struct stop_reply_deleter): Remove.
 862         (stop_reply_up): Update.
 863         (struct stop_reply): Derive from notif_event.  Don't typedef.
 864         <regcache>: Now a std::vector.
 865         (stop_reply_xfree): Remove.
 866         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 867         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 868         (remote_target::discard_pending_stop_replies): Use delete.
 869         (remote_target::remote_parse_stop_reply): Update.
 870         (remote_target::process_stop_reply): Update.
 871         * remote-notif.h (struct notif_event): Add virtual destructor.
 872         Remove "dtr" member.
 873         (struct notif_client) <alloc_event>: Return a unique_ptr.
 874         (notif_event_xfree): Don't declare.
 875         (notif_event_up): New typedef.
 876         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 877         (notif_event_xfree, do_notif_event_xfree): Remove.
 878         (remote_notif_state_xfree): Update.
 879
 880 2019-03-06  Tom Tromey  <tom@tromey.com>
 881
 882         * infrun.c (displaced_step_clear_cleanup): Now a
 883         forward_scope_exit type.
 884         (displaced_step_prepare_throw): Update.
 885         (displaced_step_fixup): Update.
 886
 887 2019-03-06  Tom Tromey  <tom@tromey.com>
 888
 889         * inferior.h (class inferior): Update comment.
 890         * gdbthread.h (class thread_info): Update comment.
 891
 892 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 893             Tom Tromey  <tom@tromey.com>
 894
 895         * stabsread.h (struct stab_section_list): Remove.
 896         (coffstab_build_psymtabs): Update.
 897         * dbxread.c (symbuf_sections): Now a std::vector.
 898         (sect_idx): New global.
 899         (fill_symbuf): Update.
 900         (coffstab_build_psymtabs): Change type of stabsects parameter.
 901         Update.
 902         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 903         std::vector.
 904         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 905         (coff_locate_sections): Update.
 906         (coff_symfile_read): Remove cleanups.  Update.
 907         (init_stringtab): Add storage parameter.
 908         (free_stringtab, free_stringtab_cleanup): Remove.
 909         (init_lineno): Add storage parameter.
 910         (free_linetab, free_linetab_cleanup): Remove.
 911
 912 2019-03-06  Pedro Alves  <palves@redhat.com>
 913
 914         * linux-fork.c (fork_info::clobber_regs): Delete.
 915         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 916         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 917         comment.  Adjust.
 918         (scoped_switch_fork_info::scoped_switch_fork_info)
 919         (checkpoint_command, linux_fork_context): Adjust
 920         fork_save_infrun_state calls.
 921
 922 2019-03-06  Pedro Alves  <palves@redhat.com>
 923
 924         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 925         (inf_has_multiple_threads): Return 'bool' and rewrite using
 926         inferior_info::threads().
 927
 928 2019-03-06  Pedro Alves  <palves@redhat.com>
 929
 930         * linux-fork.c: Include <list>.
 931         (fork_list): Now a std::list instance.
 932         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 933         (forks_exist_p, find_last_fork): Adjust.
 934         (new_fork): Delete.
 935         (one_fork_p): New.
 936         (add_fork): Adjust.
 937         (free_fork): Delete, folded into fork_info::~fork_info().
 938         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 939         Adjust.
 940         (init_fork_list): Delete.
 941         (linux_fork_killall, linux_fork_mourn_inferior)
 942         (linux_fork_detach, info_checkpoints_command): Adjust.
 943         (_initialize_linux_fork): No longer call init_fork_list.
 944
 945 2019-03-06  Pedro Alves  <palves@redhat.com>
 946
 947         * linux-fork.c (new_fork): New, split out of ...
 948         (add_fork): ... this.  Return void.  Move "first fork" special
 949         case from here, to ...
 950         (checkpoint_command): ... here.
 951         * linux-linux.h (add_fork): Return void.
 952
 953 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 956
 957 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 958             Chris January  <chris.january@arm.com>
 959             David Lecomber  <david.lecomber@arm.com>
 960
 961         * f-exp.y: New token, UNOP_INTRINSIC.
 962         (exp): New pattern using UNOP_INTRINSIC token.
 963         (f77_keywords): Add 'abs' keyword.
 964         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 965         (value_from_host_double): New function.
 966         (evaluate_subexp_f): Support UNOP_ABS.
 967
 968 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 971         types.
 972
 973 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 976         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 977         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 978
 979 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 982
 983 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 984             Chris January  <chris.january@arm.com>
 985
 986         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 987         * f-exp.y: Define 'KIND' token.
 988         (exp): New pattern for KIND expressions.
 989         (ptype): Handle types with a kind extension.
 990         (direct_abs_decl): Extend to spot kind extensions.
 991         (f77_keywords): Add 'kind' to the list.
 992         (push_kind_type): New function.
 993         (convert_to_kind_type): New function.
 994         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 995         * parse.c (operator_length_standard): Likewise.
 996         * parser-defs.h (enum type_pieces): Add tp_kind.
 997         * std-operator.def: Add UNOP_KIND.
 998
 999 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * f-exp.y (f_parse): Set yydebug.
1002
1003 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * f-lang.c (evaluate_subexp_f): New function.
1006         (exp_descriptor_f): New global.
1007         (f_language_defn): Use exp_descriptor_f instead of
1008         exp_descriptor_standard.
1009
1010 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * f-exp.y (struct token): Add comments.
1013         (dot_ops): Remove uppercase versions and the end marker.
1014         (f77_keywords): Likewise.
1015         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1016         entries in the dot_ops array are case insensitive, and use
1017         strncasecmp to compare strings.  Also some whitespace cleanup in
1018         this area.  Similar for the f77_keywords array, except entries in
1019         this list might be case sensitive.
1020
1021 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1022
1023         * f-exp.y (struct f77_boolean_val): Add comments.
1024         (boolean_values): Remove uppercase versions, and end marker.
1025         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1026         and use strncasecmp to achieve case insensitivity.  Additionally,
1027         perform whitespace cleanup around this code.
1028
1029 2019-03-06  Tom Tromey  <tromey@adacore.com>
1030
1031         * remote-sim.c (gdbsim_target_open): Use result of
1032         gdb_argv::release.
1033
1034 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1035         Dirk Schubert  <dirk.schubert@arm.com>
1036         Chris January  <chris.january@arm.com>
1037
1038         * eval.c (evaluate_subexp_standard): Call Fortran argument
1039         wrapping logic.
1040         * f-lang.c (struct value): A value which can be passed into a
1041         Fortran function call.
1042         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1043         where appropriate.
1044         (struct type): Value ready for a Fortran function call.
1045         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1046         is needed.
1047         * f-lang.h (fortran_argument_convert): Declaration.
1048         (fortran_preserve_arg_pointer): Declaration.
1049         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1050
1051 2019-03-05  Tom Tromey  <tromey@adacore.com>
1052
1053         * python/py-prettyprint.c (print_string_repr): Remove #if.
1054         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1055
1056 2019-03-05  Tom Tromey  <tromey@adacore.com>
1057
1058         * target.c (the_dummy_target): Move later.  Change type to
1059         "dummy_target".
1060         (initialize_targets): Don't initialize the_dummy_target.
1061
1062 2019-03-05  Tom Tromey  <tromey@adacore.com>
1063
1064         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1065         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1066
1067 2019-03-05  Tom Tromey  <tromey@adacore.com>
1068
1069         * windows-nat.c (windows_nat_target::attach)
1070         (windows_nat_target::detach): Don't call gdb_flush.
1071         * valprint.c (generic_val_print, val_print, val_print_string):
1072         Don't call gdb_flush.
1073         * utils.c (defaulted_query): Don't call gdb_flush.
1074         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1075         * target.c (target_announce_detach): Don't call gdb_flush.
1076         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1077         * remote.c (extended_remote_target::attach): Don't call
1078         gdb_flush.
1079         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1080         * printcmd.c (do_examine): Don't call gdb_flush.
1081         (info_display_command): Don't call gdb_flush.
1082         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1083         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1084         * memattr.c (info_mem_command): Don't call gdb_flush.
1085         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1086         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1087         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1088         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1089         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1090         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1091         (gnu_nat_target::detach): Don't call gdb_flush.
1092         * f-valprint.c (f_val_print): Don't call gdb_flush.
1093         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1094         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1095         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1096         gdb_flush.
1097         * c-valprint.c (c_val_print): Don't call gdb_flush.
1098         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1099
1100 2019-03-05  Tom Tromey  <tromey@adacore.com>
1101
1102         * varobj.c (update_dynamic_varobj_children): Update.
1103         (install_default_visualizer): Use reset, not release.
1104         * value.c (set_internalvar): Update.
1105         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1106         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1107         ATTRIBUTE_UNUSED_RESULT.
1108
1109 2019-03-05  Tom Tromey  <tromey@adacore.com>
1110
1111         * remote.c (class scoped_remote_fd) <release>: Add
1112         ATTRIBUTE_UNUSED_RESULT.
1113
1114 2019-03-05  Tom Tromey  <tromey@adacore.com>
1115
1116         * macroexp.c (struct macro_buffer) <release>: Add
1117         ATTRIBUTE_UNUSED_RESULT.
1118
1119 2019-03-05  Tom Tromey  <tromey@adacore.com>
1120
1121         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1122         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1123         ATTRIBUTE_UNUSED_RESULT.
1124
1125 2019-03-05  Tom Tromey  <tromey@adacore.com>
1126
1127         * common/scoped_fd.h (class scoped_fd) <release>: Add
1128         ATTRIBUTE_UNUSED_RESULT.
1129
1130 2019-03-05  Tom Tromey  <tromey@adacore.com>
1131
1132         * parser-defs.h (struct parser_state) <release>: Add
1133         ATTRIBUTE_UNUSED_RESULT.
1134
1135 2019-03-05  Tom Tromey  <tromey@adacore.com>
1136
1137         * utils.h (class gdb_argv) <release>: Add
1138         ATTRIBUTE_UNUSED_RESULT.
1139         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1140
1141 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1142
1143         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1144         for-loop range, to avoid compiler warnings.
1145
1146         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1147         avoid compiler warnings about unused variables.
1148
1149         * NEWS: Mention end of support for native debugging on MS-Windows
1150         before XP.
1151
1152         PR gdb/24292
1153         * common/netstuff.c:
1154         * gdbserver/gdbreplay.c
1155         * gdbserver/remote-utils.c:
1156         * ser-tcp.c:
1157         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1158         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1159         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1160         'getaddrinfo' and 'freeaddrinfo' were not available before
1161         Windows XP, and mingw.org's MinGW headers by default define
1162         _WIN32_WINNT to 0x500.
1163
1164 2019-03-01  Gary Benson <gbenson@redhat.com>
1165
1166         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1167
1168 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1169             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1170
1171         PR gdb/8527
1172         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1173         set_sigint_trap, clear_sigint_trap.
1174
1175 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1176
1177         * target.c (target_detach): Clear the regcache and the
1178         frame cache.
1179
1180 2019-02-27  Pedro Alves  <palves@redhat.com>
1181
1182         * utils.c (set_screen_size): When we cap the height/width sizes,
1183         tweak the corresponding command variable to show "unlimited":
1184
1185 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1186             Pedro Alves  <palves@redhat.com>
1187
1188         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1189         before calling rl_set_screen_size.
1190
1191 2019-02-27  Tom Tromey  <tromey@adacore.com>
1192
1193         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1194         define.
1195         * python/py-value.c: Remove Python 2.4 workaround.
1196         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1197         workaround.
1198         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1199         Python 2.4 workaround.
1200         * python/python-internal.h: Remove Python 2.4 comment.
1201         (Py_ssize_t): Don't define.
1202         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1203         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1204         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1205         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1206         * python/python.c (do_start_initialization): Remove Python 2.4
1207         workaround.
1208         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1209         (print_children): Remove Python 2.4 workaround.
1210         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1211         workaround.
1212         (CHARBUFFERPROC_NAME): Remove.
1213         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1214         Python 2.4 workaround.
1215
1216 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1217
1218         * NEWS: Note minimum Python version.
1219
1220 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1221
1222         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1223         code from these functions.  Remove corresponding ifdefs.  Use
1224         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1225         Remove gotos and target of gotos.
1226         (infpy_search_memory): Likewise.
1227
1228 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1229
1230         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1231         (hppa_gdbarch_init): Don't register deleted functions with
1232         gdbarch.
1233
1234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1237         (h8300_unwind_sp): Delete.
1238         (h8300_dummy_id): Delete.
1239         (h8300_gdbarch_init): Don't register deleted functions with
1240         gdbarch.
1241
1242 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1245         (ft32_unwind_pc): Delete.
1246         (ft32_unwind_sp): Delete.
1247         (ft32_gdbarch_init): Don't register deleted functions with
1248         gdbarch.
1249
1250 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1253         (frv_unwind_pc): Delete.
1254         (frv_unwind_sp): Delete.
1255         (frv_gdbarch_init): Don't register deleted functions with
1256         gdbarch.
1257
1258 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1261         (riscv_unwind_pc): Delete.
1262         (riscv_unwind_sp): Delete.
1263         (riscv_gdbarch_init): Don't register deleted functions with
1264         gdbarch.
1265
1266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1269         (csky_unwind_pc): Delete.
1270         (csky_unwind_sp): Delete.
1271         (csky_gdbarch_init): Don't register deleted functions with
1272         gdbarch.
1273
1274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1277         (cris_unwind_pc): Delete.
1278         (cris_unwind_sp): Delete.
1279         (cris_gdbarch_init): Don't register deleted functions with
1280         gdbarch.
1281
1282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1285         (bfin_unwind_pc): Delete.
1286         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1287
1288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1291         (arm_unwind_pc): Delete.
1292         (arm_unwind_sp): Delete.
1293         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1294
1295 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1298         (arc_unwind_pc): Delete.
1299         (arc_unwind_sp): Delete.
1300         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1301
1302 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1303
1304         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1305         (alpha_unwind_pc): Delete.
1306         (alpha_gdbarch_init): Don't register deleted functions with
1307         gdbarch.
1308
1309 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1310
1311         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1312         (aarch64_unwind_pc): Delete.
1313         (aarch64_unwind_sp): Delete.
1314         (aarch64_gdbarch_init): Don't register deleted functions with
1315         gdbarch.
1316
1317 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * gdbtypes.c (type_align): Don't consider static members when
1320         computing structure alignment.
1321
1322 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1325         return 0 for other types.
1326         * arch-utils.c (default_type_align): Always return 0.
1327         * gdbarch.h: Regenerate.
1328         * gdbarch.sh (type_align): Extend comment.
1329         * gdbtypes.c (type_align): Add additional comments, always call
1330         gdbarch_type_align before applying the default rules.
1331         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1332         generic code will then apply a suitable default.
1333         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1334         types, return 0 for other types.
1335
1336 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1337
1338         * NEWS: Create a new section for the next release branch.
1339         Rename the section of the current branch, now that it has
1340         been cut.
1341
1342 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1343
1344         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1345         * version.in: Bump version to 8.3.50.DATE-git.
1346
1347 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1348
1349         * aix-thread.c (ptid_cmp): Remove unused variable.
1350         (get_signaled_thread): Likewise.
1351         (store_regs_user_thread): Likewise.
1352         (store_regs_kernel_thread): Likewise.
1353         (fetch_regs_kernel_thread): Remove shadowed variable.
1354
1355 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1356
1357         * features/riscv/32bit-cpu.xml: Add register numbers.
1358         * features/riscv/32bit-fpu.c: Regenerate.
1359         * features/riscv/32bit-fpu.xml: Add register numbers.
1360         * features/riscv/64bit-cpu.xml: Add register numbers.
1361         * features/riscv/64bit-fpu.c: Regenerate.
1362         * features/riscv/64bit-fpu.xml: Add register numbers.
1363
1364 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1365
1366         * NEWS: Mention two argument form of gdb.Value constructor.
1367         * python/py-value.c (convert_buffer_and_type_to_value): New
1368         function.
1369         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1370         Add support for handling an optional second argument.  Call
1371         convert_buffer_and_type_to_value as appropriate.
1372         * python/python-internal.h (Py_buffer_deleter): New struct.
1373         (Py_buffer_up): New typedef.
1374
1375 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1376
1377         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1378         instead of releasing ownership.
1379
1380 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1381
1382         * dwarf2read.c (open_and_init_dwp_file): Call
1383         elf_numsections instead of bfd_count_sections to initialize
1384         dwp_file->num_sections.
1385
1386 2019-02-25  Tom Tromey  <tromey@adacore.com>
1387
1388         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1389
1390 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1391
1392         * gcore.in: Add '--readnever' option when invoking GDB.
1393
1394 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1395
1396         * MAINTAINERS: Update my email address.
1397
1398 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1399
1400         * build-id.c (build_id_to_debug_bfd_1): New function.
1401         (build_id_to_debug_bfd): Look for separate debug file in
1402         sysroot.
1403
1404 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1405
1406         * gdbarch.sh: Update the copyright year range that is placed into
1407         generated files.
1408
1409 2019-02-22  Keith Seitz  <keiths@redhat.com>
1410
1411         PR symtab/23853
1412         * linespec.c (create_sals_line_offset): Search for the default
1413         symtab's filename instead of its fullname.
1414
1415 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1416
1417         * NEWS: Update style defaults.
1418
1419 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1420
1421         * main.c (captured_main_1): Disable styling in batch mode.
1422
1423 2019-02-20  Tom Tromey  <tom@tromey.com>
1424
1425         * symtab.c (symtab_symbol_info): Fix typos.
1426
1427 2019-02-20  Tom Tromey  <tromey@adacore.com>
1428
1429         * findcmd.c (_initialize_mem_search): Use upper case for
1430         metasyntactic variables.
1431
1432 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1433
1434         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1435         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1436
1437 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1438
1439         * top.h (source_file_name): Change to std::string.
1440         * top.c (source_file_name): Likewise.
1441         (command_line_input): Adjust.
1442         * cli/cli-script.c (script_from_file): Adjust.
1443
1444 2019-02-19  Tom Tromey  <tromey@adacore.com>
1445
1446         * ravenscar-thread.c
1447         (ravenscar_thread_target::update_thread_list): Don't call
1448         ada_build_task_list.
1449         * ada-lang.h (ada_build_task_list): Don't declare.
1450         * ada-tasks.c (struct ada_tasks_inferior_data)
1451         <task_list_valid_p>: Now bool.
1452         (read_known_tasks, ada_task_list_changed)
1453         (ada_tasks_invalidate_inferior_data): Update.
1454         (read_known_tasks_array): Return bool.
1455         (read_known_tasks_list): Likewise.
1456         (read_known_tasks): Return void.
1457         (ada_build_task_list): Now static.
1458
1459 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1460
1461         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1462         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1463
1464 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1465
1466         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1467         variant for ada_tasks_pspace_data_handle and
1468         ada_tasks_inferior_data_handle.
1469         (ada_tasks_pspace_data_cleanup): New function.
1470         (ada_tasks_inferior_data_cleanup): New function.
1471
1472 2019-02-17  Tom Tromey  <tom@tromey.com>
1473
1474         * macrotab.h (macro_source_fullname): Return a std::string.
1475         * macrotab.c (macro_include, check_for_redefinition)
1476         (macro_undef, macro_lookup_definition, foreach_macro)
1477         (foreach_macro_in_scope): Update.
1478         (macro_source_fullname): Return a std::string.
1479         * macrocmd.c (show_pp_source_pos): Update.
1480
1481 2019-02-17  Tom Tromey  <tom@tromey.com>
1482
1483         * macrocmd.c (show_pp_source_pos): Style the file names.
1484
1485 2019-02-17  Tom Tromey  <tom@tromey.com>
1486
1487         PR tui/24197:
1488         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1489
1490 2019-02-17  Tom Tromey  <tom@tromey.com>
1491
1492         * ada-lang.c (user_select_syms): Use filtered printing.
1493         * utils.c (wrap_style): New global.
1494         (desired_style): Remove.
1495         (emit_style_escape): Add stream parameter.
1496         (set_output_style, reset_terminal_style, prompt_for_continue):
1497         Update.
1498         (flush_wrap_buffer): Only flush gdb_stdout.
1499         (wrap_here): Set wrap_style.
1500         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1501         treat escape sequences as a character.  Change when wrap buffer is
1502         flushed.
1503         (fputs_styled): Do not set the output style when the default is
1504         requested.
1505         * ui-style.h (struct ui_file_style) <is_default>: New method.
1506         * source.c (print_source_lines_base): Emit escape sequences in one
1507         piece.
1508
1509 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1510
1511         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1512         integers and enumeration types.
1513
1514 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1515
1516         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1517         instead of lookup_symbol_in_language
1518         (do_exact_match): New function.
1519         (ada_get_symbol_name_matcher): Return do_exact_match when
1520         doing a verbatim match.
1521
1522 2019-02-15  Tom Tromey  <tromey@adacore.com>
1523
1524         * ravenscar-thread.c (ravenscar_thread_target::resume)
1525         (ravenscar_thread_target::wait): Special case wildcard requests.
1526
1527 2019-02-15  Tom Tromey  <tromey@adacore.com>
1528
1529         * ravenscar-thread.c (base_ptid): Remove.
1530         (struct ravenscar_thread_target) <close>: New method.
1531         <m_base_ptid>: New member.
1532         <update_inferior_ptid, active_task, task_is_currently_active,
1533         runtime_initialized>: Declare methods.
1534         <ravenscar_thread_target>: Add constructor.
1535         (ravenscar_thread_target::task_is_currently_active)
1536         (ravenscar_thread_target::update_inferior_ptid)
1537         (ravenscar_runtime_initialized): Rename.  Now methods.
1538         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1539         (ravenscar_thread_target::update_thread_list): Update.
1540         (ravenscar_thread_target::active_task): Now method.
1541         (ravenscar_thread_target::store_registers)
1542         (ravenscar_thread_target::prepare_to_store)
1543         (ravenscar_thread_target::prepare_to_store)
1544         (ravenscar_thread_target::mourn_inferior): Update.
1545         (ravenscar_inferior_created): Use "new" to create target.
1546         (ravenscar_thread_target::get_ada_task_ptid): Update.
1547         (_initialize_ravenscar): Don't initialize base_ptid.
1548         (ravenscar_ops): Remove global.
1549
1550 2019-02-15  Tom Tromey  <tromey@adacore.com>
1551
1552         * target.h (push_target): Declare new overload.
1553         * target.c (push_target): New overload, taking an rvalue reference.
1554         * remote.c (remote_target::open_1): Use push_target overload.
1555         * corelow.c (core_target_open): Use push_target overload.
1556
1557 2019-02-15  Tom Tromey  <tromey@adacore.com>
1558
1559         * ravenscar-thread.c (is_ravenscar_task)
1560         (ravenscar_task_is_currently_active): Return bool.
1561         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1562         (_initialize_ravenscar): Remove "(void)".
1563         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1564         Return bool.
1565
1566 2019-02-15  Tom Tromey  <tromey@adacore.com>
1567
1568         * ravenscar-thread.c (ravenscar_runtime_initializer)
1569         (has_ravenscar_runtime, get_running_thread_id)
1570         (ravenscar_thread_target::resume): Fix indentation.
1571
1572 2019-02-15  Tom Tromey  <tromey@adacore.com>
1573
1574         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1575         from ravenscar_arch_ops.
1576         (sparc_ravenscar_ops::fetch_registers)
1577         (sparc_ravenscar_ops::store_registers): Now methods.
1578         (sparc_ravenscar_prepare_to_store): Remove.
1579         (sparc_ravenscar_ops): Redefine.
1580         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1581         methods and destructor.  Remove members.
1582         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1583         (ravenscar_thread_target::store_registers)
1584         (ravenscar_thread_target::prepare_to_store): Update.
1585         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1586         Remove.
1587         (struct ppc_ravenscar_powerpc_ops): Derive from
1588         ravenscar_arch_ops.
1589         (ppc_ravenscar_powerpc_ops::fetch_registers)
1590         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1591         (ppc_ravenscar_powerpc_ops): Redefine.
1592         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1593         (ppc_ravenscar_e500_ops::fetch_registers)
1594         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1595         (ppc_ravenscar_e500_ops): Redefine.
1596         * aarch64-ravenscar-thread.c
1597         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1598         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1599         (aarch64_ravenscar_fetch_registers)
1600         (aarch64_ravenscar_store_registers): Now methods.
1601         (aarch64_ravenscar_ops): Redefine.
1602
1603 2019-02-15  Tom Tromey  <tromey@adacore.com>
1604
1605         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1606         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1607         (ravenscar_thread_target::stopped_by_watchpoint)
1608         (ravenscar_thread_target::stopped_data_address)
1609         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1610
1611 2019-02-15  Tom Tromey  <tromey@adacore.com>
1612
1613         * ravenscar-thread.c: Fix some typos.
1614
1615 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1616             Tom Tromey  <tromey@adacore.com>
1617
1618         * ada-lang.c (ada_exception_sal): Change addr_string to a
1619         std::string.
1620         (create_ada_exception_catchpoint): Update.
1621
1622 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1623             Tom Tromey  <tromey@adacore.com>
1624
1625         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1626         (bp_location_ops): Remove.
1627         (base_breakpoint_allocate_location): Update.
1628         (free_bp_location): Update.
1629         * ada-lang.c (class ada_catchpoint_location)
1630         <ada_catchpoint_location>: Remove ops parameter.
1631         (ada_catchpoint_location_dtor): Remove.
1632         (ada_catchpoint_location_ops): Remove.
1633         (allocate_location_exception): Update.
1634         * breakpoint.h (struct bp_location_ops): Remove.
1635         (class bp_location) <bp_location>: Remove bp_location_ops
1636         parameter.
1637         <~bp_location>: Add destructor.
1638         <ops>: Remove.
1639
1640 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1641             Pedro Alves  <palves@redhat.com>
1642
1643         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1644         'PATH_MAX'.
1645
1646 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1647             Samuel Thibault  <samuel.thibault@gnu.org>
1648             Thomas Schwinge  <thomas@codesourcery.com>
1649
1650         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1651         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1652
1653 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1654
1655         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1656         (check_empty): Use "const char *".
1657
1658         * gnu-nat.c (gnu_nat_target::detach): Instead of
1659         'detach_inferior (pid)' call
1660         'detach_inferior (find_inferior_pid (pid))'.
1661
1662         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1663         'nat/fork-inferior.o'.
1664         * gnu-nat.c: #include "nat/fork-inferior.h".
1665
1666         * gnu-nat.c (gnu_nat_target::detach): Instead of
1667         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1668         * gnu-nat.h: #include "inf-child.h".
1669         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1670         'i386_gnu_nat_target::fetch_registers'.
1671         (gnu_store_registers): Rename/move to
1672         'i386_gnu_nat_target::store_registers'.
1673
1674         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1675         * gnu-nat.h (mach_thread_info): New function.
1676         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1677
1678         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1679
1680 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1681
1682         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1683
1684 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1685
1686         * windows-nat.c (windows_add_thread): Add new parameter
1687         "main_thread_p" with default value set to false.  Update
1688         function documentation as well as all callers.
1689         (windows_delete_thread): Likewise.
1690         (fake_create_process): Update call to windows_add_thread.
1691         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1692         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1693         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1694         call to windows_delete_thread.
1695
1696 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1697
1698         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1699
1700 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1701
1702         * symfile.c (find_separate_debug_file): Use canonical path of
1703         sysroot with child_path instead of gdb_sysroot if it is valid.
1704
1705 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1706
1707         * symfile.c (find_separate_debug_file): Use child_path to
1708         determine if an object file is under a sysroot.
1709
1710 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1711
1712         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1713         unittests/child-path-selftests.c.
1714         * common/pathstuff.c (child_path): New function.
1715         * common/pathstuff.h (child_path): New prototype.
1716         * unittests/child-path-selftests.c: New file.
1717
1718 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1719
1720         * symfile.c (find_separate_debug_file): Look for separate debug
1721         files in debug directories under the sysroot.
1722
1723 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1724
1725         * symtab.h (struct minimal_symbol data_p): New const method.
1726         (struct minimal_symbol text_p): Likewise.
1727         * symtab.c (output_source_filename): Use file name style
1728         to print file name.
1729         (print_symbol_info): Likewise.
1730         (print_msymbol_info): Use address style to print addresses.
1731         Use function name style to print executable text symbols.
1732         (expand_symtab_containing_pc): Use data_p.
1733         (find_pc_sect_compunit_symtab): Likewise.
1734
1735 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1736
1737         * breakpoint.c (describe_other_breakpoints): Use address style
1738         to print addresses.
1739         (say_where): Likewise.
1740
1741 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1742
1743         * ada-typeprint.c (print_func_type): Print function name
1744         style to print function name.
1745         * c-typeprint.c (c_print_type_1): Likewise.
1746
1747 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1748
1749         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1750         for execve.
1751
1752 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1753
1754         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1755         type_stack.
1756
1757 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1758
1759         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1760         TYPE_CODE_REF types.
1761
1762 2019-02-08  Jim Wilson  <jimw@sifive.com>
1763
1764         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1765         (riscv_linux_fregset): New.
1766         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1767
1768 2019-02-07  Tom Tromey  <tom@tromey.com>
1769
1770         * thread.c (thread_cancel_execution_command): Update.
1771         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1772         methods.
1773         (struct thread_fsm_ops): Remove.
1774         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1775         (thread_fsm_should_stop, thread_fsm_return_value)
1776         (thread_fsm_set_finished, thread_fsm_finished_p)
1777         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1778         Don't declare.
1779         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1780         * infrun.c (clear_proceed_status_thread)
1781         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1782         (print_stop_event): Update.
1783         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1784         Add constructor.
1785         (step_command_fsm_ops): Remove.
1786         (new_step_command_fsm): Remove.
1787         (step_1): Update.
1788         (step_command_fsm::should_stop): Rename from
1789         step_command_fsm_should_stop.
1790         (step_command_fsm::clean_up): Rename from
1791         step_command_fsm_clean_up.
1792         (step_command_fsm::do_async_reply_reason): Rename from
1793         step_command_fsm_async_reply_reason.
1794         (struct until_next_fsm): Inherit from thread_fsm.  Add
1795         constructor.
1796         (until_next_fsm_ops): Remove.
1797         (new_until_next_fsm): Remove.
1798         (until_next_fsm::should_stop): Rename from
1799         until_next_fsm_should_stop.
1800         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1801         (until_next_fsm::do_async_reply_reason): Rename from
1802         until_next_fsm_async_reply_reason.
1803         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1804         constructor.  Change type of breakpoint.
1805         (finish_command_fsm_ops): Remove.
1806         (new_finish_command_fsm): Remove.
1807         (finish_command_fsm::should_stop): Rename from
1808         finish_command_fsm_should_stop.
1809         (finish_command_fsm::clean_up): Rename from
1810         finish_command_fsm_clean_up.
1811         (finish_command_fsm::return_value): Rename from
1812         finish_command_fsm_return_value.
1813         (finish_command_fsm::do_async_reply_reason): Rename from
1814         finish_command_fsm_async_reply_reason.
1815         (finish_command): Update.
1816         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1817         Add constructor.
1818         (call_thread_fsm_ops): Remove.
1819         (call_thread_fsm::call_thread_fsm): Rename from
1820         new_call_thread_fsm.
1821         (call_thread_fsm::should_stop): Rename from
1822         call_thread_fsm_should_stop.
1823         (call_thread_fsm::should_notify_stop): Rename from
1824         call_thread_fsm_should_notify_stop.
1825         (run_inferior_call, call_function_by_hand_dummy): Update.
1826         * cli/cli-interp.c (should_print_stop_to_console): Update.
1827         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1828         Add constructor.  Change type of location_breakpoint,
1829         caller_breakpoint.
1830         (until_break_fsm_ops): Remove.
1831         (new_until_break_fsm): Remove.
1832         (until_break_fsm::should_stop): Rename from
1833         until_break_fsm_should_stop.
1834         (until_break_fsm::clean_up): Rename from
1835         until_break_fsm_clean_up.
1836         (until_break_fsm::do_async_reply_reason): Rename from
1837         until_break_fsm_async_reply_reason.
1838         (until_break_command): Update.
1839         * thread-fsm.c: Remove.
1840         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1841
1842 2019-02-07  Tom Tromey  <tom@tromey.com>
1843
1844         * yy-remap.h: Add include guard.
1845         * xtensa-tdep.h: Add include guard.
1846         * xcoffread.h: Rename include guard.
1847         * varobj-iter.h: Add include guard.
1848         * tui/tui.h: Rename include guard.
1849         * tui/tui-winsource.h: Rename include guard.
1850         * tui/tui-wingeneral.h: Rename include guard.
1851         * tui/tui-windata.h: Rename include guard.
1852         * tui/tui-win.h: Rename include guard.
1853         * tui/tui-stack.h: Rename include guard.
1854         * tui/tui-source.h: Rename include guard.
1855         * tui/tui-regs.h: Rename include guard.
1856         * tui/tui-out.h: Rename include guard.
1857         * tui/tui-layout.h: Rename include guard.
1858         * tui/tui-io.h: Rename include guard.
1859         * tui/tui-hooks.h: Rename include guard.
1860         * tui/tui-file.h: Rename include guard.
1861         * tui/tui-disasm.h: Rename include guard.
1862         * tui/tui-data.h: Rename include guard.
1863         * tui/tui-command.h: Rename include guard.
1864         * tic6x-tdep.h: Add include guard.
1865         * target/waitstatus.h: Rename include guard.
1866         * target/wait.h: Rename include guard.
1867         * target/target.h: Rename include guard.
1868         * target/resume.h: Rename include guard.
1869         * target-float.h: Rename include guard.
1870         * stabsread.h: Add include guard.
1871         * rs6000-tdep.h: Add include guard.
1872         * riscv-fbsd-tdep.h: Add include guard.
1873         * regformats/regdef.h: Rename include guard.
1874         * record.h: Rename include guard.
1875         * python/python.h: Rename include guard.
1876         * python/python-internal.h: Rename include guard.
1877         * python/py-stopevent.h: Rename include guard.
1878         * python/py-ref.h: Rename include guard.
1879         * python/py-record.h: Rename include guard.
1880         * python/py-record-full.h: Rename include guard.
1881         * python/py-record-btrace.h: Rename include guard.
1882         * python/py-instruction.h: Rename include guard.
1883         * python/py-events.h: Rename include guard.
1884         * python/py-event.h: Rename include guard.
1885         * procfs.h: Add include guard.
1886         * proc-utils.h: Add include guard.
1887         * p-lang.h: Add include guard.
1888         * or1k-tdep.h: Rename include guard.
1889         * observable.h: Rename include guard.
1890         * nto-tdep.h: Rename include guard.
1891         * nat/x86-linux.h: Rename include guard.
1892         * nat/x86-linux-dregs.h: Rename include guard.
1893         * nat/x86-gcc-cpuid.h: Add include guard.
1894         * nat/x86-dregs.h: Rename include guard.
1895         * nat/x86-cpuid.h: Rename include guard.
1896         * nat/ppc-linux.h: Rename include guard.
1897         * nat/mips-linux-watch.h: Rename include guard.
1898         * nat/linux-waitpid.h: Rename include guard.
1899         * nat/linux-ptrace.h: Rename include guard.
1900         * nat/linux-procfs.h: Rename include guard.
1901         * nat/linux-osdata.h: Rename include guard.
1902         * nat/linux-nat.h: Rename include guard.
1903         * nat/linux-namespaces.h: Rename include guard.
1904         * nat/linux-btrace.h: Rename include guard.
1905         * nat/glibc_thread_db.h: Rename include guard.
1906         * nat/gdb_thread_db.h: Rename include guard.
1907         * nat/gdb_ptrace.h: Rename include guard.
1908         * nat/fork-inferior.h: Rename include guard.
1909         * nat/amd64-linux-siginfo.h: Rename include guard.
1910         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1911         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1912         * nat/aarch64-linux.h: Rename include guard.
1913         * nat/aarch64-linux-hw-point.h: Rename include guard.
1914         * mn10300-tdep.h: Add include guard.
1915         * mips-linux-tdep.h: Add include guard.
1916         * mi/mi-parse.h: Rename include guard.
1917         * mi/mi-out.h: Rename include guard.
1918         * mi/mi-main.h: Rename include guard.
1919         * mi/mi-interp.h: Rename include guard.
1920         * mi/mi-getopt.h: Rename include guard.
1921         * mi/mi-console.h: Rename include guard.
1922         * mi/mi-common.h: Rename include guard.
1923         * mi/mi-cmds.h: Rename include guard.
1924         * mi/mi-cmd-break.h: Rename include guard.
1925         * m2-lang.h: Add include guard.
1926         * location.h: Rename include guard.
1927         * linux-record.h: Rename include guard.
1928         * linux-nat.h: Add include guard.
1929         * linux-fork.h: Add include guard.
1930         * i386-darwin-tdep.h: Rename include guard.
1931         * hppa-linux-offsets.h: Add include guard.
1932         * guile/guile.h: Rename include guard.
1933         * guile/guile-internal.h: Rename include guard.
1934         * gnu-nat.h: Rename include guard.
1935         * gdb-stabs.h: Rename include guard.
1936         * frv-tdep.h: Add include guard.
1937         * f-lang.h: Add include guard.
1938         * event-loop.h: Add include guard.
1939         * darwin-nat.h: Rename include guard.
1940         * cp-abi.h: Rename include guard.
1941         * config/sparc/nm-sol2.h: Rename include guard.
1942         * config/nm-nto.h: Rename include guard.
1943         * config/nm-linux.h: Add include guard.
1944         * config/i386/nm-i386gnu.h: Rename include guard.
1945         * config/djgpp/nl_types.h: Rename include guard.
1946         * config/djgpp/langinfo.h: Rename include guard.
1947         * compile/gcc-cp-plugin.h: Add include guard.
1948         * compile/gcc-c-plugin.h: Add include guard.
1949         * compile/compile.h: Rename include guard.
1950         * compile/compile-object-run.h: Rename include guard.
1951         * compile/compile-object-load.h: Rename include guard.
1952         * compile/compile-internal.h: Rename include guard.
1953         * compile/compile-cplus.h: Rename include guard.
1954         * compile/compile-c.h: Rename include guard.
1955         * common/xml-utils.h: Rename include guard.
1956         * common/x86-xstate.h: Rename include guard.
1957         * common/version.h: Rename include guard.
1958         * common/vec.h: Rename include guard.
1959         * common/tdesc.h: Rename include guard.
1960         * common/selftest.h: Rename include guard.
1961         * common/scoped_restore.h: Rename include guard.
1962         * common/scoped_mmap.h: Rename include guard.
1963         * common/scoped_fd.h: Rename include guard.
1964         * common/safe-iterator.h: Rename include guard.
1965         * common/run-time-clock.h: Rename include guard.
1966         * common/refcounted-object.h: Rename include guard.
1967         * common/queue.h: Rename include guard.
1968         * common/ptid.h: Rename include guard.
1969         * common/print-utils.h: Rename include guard.
1970         * common/preprocessor.h: Rename include guard.
1971         * common/pathstuff.h: Rename include guard.
1972         * common/observable.h: Rename include guard.
1973         * common/netstuff.h: Rename include guard.
1974         * common/job-control.h: Rename include guard.
1975         * common/host-defs.h: Rename include guard.
1976         * common/gdb_wait.h: Rename include guard.
1977         * common/gdb_vecs.h: Rename include guard.
1978         * common/gdb_unlinker.h: Rename include guard.
1979         * common/gdb_unique_ptr.h: Rename include guard.
1980         * common/gdb_tilde_expand.h: Rename include guard.
1981         * common/gdb_sys_time.h: Rename include guard.
1982         * common/gdb_string_view.h: Rename include guard.
1983         * common/gdb_splay_tree.h: Rename include guard.
1984         * common/gdb_setjmp.h: Rename include guard.
1985         * common/gdb_ref_ptr.h: Rename include guard.
1986         * common/gdb_optional.h: Rename include guard.
1987         * common/gdb_locale.h: Rename include guard.
1988         * common/gdb_assert.h: Rename include guard.
1989         * common/filtered-iterator.h: Rename include guard.
1990         * common/filestuff.h: Rename include guard.
1991         * common/fileio.h: Rename include guard.
1992         * common/environ.h: Rename include guard.
1993         * common/common-utils.h: Rename include guard.
1994         * common/common-types.h: Rename include guard.
1995         * common/common-regcache.h: Rename include guard.
1996         * common/common-inferior.h: Rename include guard.
1997         * common/common-gdbthread.h: Rename include guard.
1998         * common/common-exceptions.h: Rename include guard.
1999         * common/common-defs.h: Rename include guard.
2000         * common/common-debug.h: Rename include guard.
2001         * common/cleanups.h: Rename include guard.
2002         * common/buffer.h: Rename include guard.
2003         * common/btrace-common.h: Rename include guard.
2004         * common/break-common.h: Rename include guard.
2005         * cli/cli-utils.h: Rename include guard.
2006         * cli/cli-style.h: Rename include guard.
2007         * cli/cli-setshow.h: Rename include guard.
2008         * cli/cli-script.h: Rename include guard.
2009         * cli/cli-interp.h: Rename include guard.
2010         * cli/cli-decode.h: Rename include guard.
2011         * cli/cli-cmds.h: Rename include guard.
2012         * charset-list.h: Add include guard.
2013         * buildsym-legacy.h: Rename include guard.
2014         * bfin-tdep.h: Add include guard.
2015         * ax.h: Rename include guard.
2016         * arm-linux-tdep.h: Add include guard.
2017         * arm-fbsd-tdep.h: Add include guard.
2018         * arch/xtensa.h: Rename include guard.
2019         * arch/tic6x.h: Add include guard.
2020         * arch/i386.h: Add include guard.
2021         * arch/arm.h: Rename include guard.
2022         * arch/arm-linux.h: Rename include guard.
2023         * arch/arm-get-next-pcs.h: Rename include guard.
2024         * arch/amd64.h: Add include guard.
2025         * arch/aarch64-insn.h: Rename include guard.
2026         * arch-utils.h: Rename include guard.
2027         * annotate.h: Add include guard.
2028         * amd64-darwin-tdep.h: Rename include guard.
2029         * aarch64-linux-tdep.h: Add include guard.
2030         * aarch64-fbsd-tdep.h: Add include guard.
2031         * aarch32-linux-nat.h: Add include guard.
2032
2033 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2034
2035         * macrotab.c (macro_define_internal): New function that
2036         factorizes macro_define_object_internal and macro_define_function
2037         code.
2038         (macro_define_object_internal): Use macro_define_internal.
2039         (macro_define_function): Likewise.
2040
2041 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2042
2043         * macrocmd.c (extract_identifier): Return
2044         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2045         callers.
2046
2047 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2048
2049         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2050
2051 2019-02-05  Tom Tromey  <tom@tromey.com>
2052
2053         * target.c (target_stack::unpush): Move assertion earlier.
2054
2055 2019-01-30  Tom Tromey  <tom@tromey.com>
2056
2057         PR python/23615:
2058         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2059         (gdbpy_parse_and_eval): Likewise.
2060         * python/python-internal.h (gdbpy_allow_threads): New class.
2061
2062 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2063
2064         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2065         (aarch64_fbsd_fpregmap): Move earlier.
2066         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2067         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2068         instead of individual calls to trad_frame_set_reg_addr.
2069         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2070         earlier.
2071         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2072         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2073         instead of individual calls to trad_frame_set_reg_addr.
2074
2075 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2076
2077         * CONTRIBUTE: Replace contribution list with wiki link.
2078
2079 2019-01-25  Tom Tromey  <tom@tromey.com>
2080
2081         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2082
2083 2019-01-25  Tom Tromey  <tom@tromey.com>
2084
2085         * xtensa-linux-nat.c: Fix common/ includes.
2086         * xml-support.h: Fix common/ includes.
2087         * xml-support.c: Fix common/ includes.
2088         * x86-linux-nat.c: Fix common/ includes.
2089         * windows-nat.c: Fix common/ includes.
2090         * varobj.h: Fix common/ includes.
2091         * varobj.c: Fix common/ includes.
2092         * value.c: Fix common/ includes.
2093         * valops.c: Fix common/ includes.
2094         * utils.c: Fix common/ includes.
2095         * unittests/xml-utils-selftests.c: Fix common/ includes.
2096         * unittests/utils-selftests.c: Fix common/ includes.
2097         * unittests/unpack-selftests.c: Fix common/ includes.
2098         * unittests/tracepoint-selftests.c: Fix common/ includes.
2099         * unittests/style-selftests.c: Fix common/ includes.
2100         * unittests/string_view-selftests.c: Fix common/ includes.
2101         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2102         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2103         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2104         * unittests/rsp-low-selftests.c: Fix common/ includes.
2105         * unittests/parse-connection-spec-selftests.c: Fix common/
2106         includes.
2107         * unittests/optional-selftests.c: Fix common/ includes.
2108         * unittests/offset-type-selftests.c: Fix common/ includes.
2109         * unittests/observable-selftests.c: Fix common/ includes.
2110         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2111         * unittests/memrange-selftests.c: Fix common/ includes.
2112         * unittests/memory-map-selftests.c: Fix common/ includes.
2113         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2114         * unittests/function-view-selftests.c: Fix common/ includes.
2115         * unittests/environ-selftests.c: Fix common/ includes.
2116         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2117         * unittests/common-utils-selftests.c: Fix common/ includes.
2118         * unittests/cli-utils-selftests.c: Fix common/ includes.
2119         * unittests/array-view-selftests.c: Fix common/ includes.
2120         * ui-file.c: Fix common/ includes.
2121         * tui/tui-io.c: Fix common/ includes.
2122         * tracepoint.h: Fix common/ includes.
2123         * tracepoint.c: Fix common/ includes.
2124         * tracefile-tfile.c: Fix common/ includes.
2125         * top.h: Fix common/ includes.
2126         * top.c: Fix common/ includes.
2127         * thread.c: Fix common/ includes.
2128         * target/waitstatus.h: Fix common/ includes.
2129         * target/waitstatus.c: Fix common/ includes.
2130         * target.h: Fix common/ includes.
2131         * target.c: Fix common/ includes.
2132         * target-memory.c: Fix common/ includes.
2133         * target-descriptions.c: Fix common/ includes.
2134         * symtab.h: Fix common/ includes.
2135         * symfile.c: Fix common/ includes.
2136         * stap-probe.c: Fix common/ includes.
2137         * spu-linux-nat.c: Fix common/ includes.
2138         * sparc-nat.c: Fix common/ includes.
2139         * source.c: Fix common/ includes.
2140         * solib.c: Fix common/ includes.
2141         * solib-target.c: Fix common/ includes.
2142         * ser-unix.c: Fix common/ includes.
2143         * ser-tcp.c: Fix common/ includes.
2144         * ser-pipe.c: Fix common/ includes.
2145         * ser-base.c: Fix common/ includes.
2146         * selftest-arch.c: Fix common/ includes.
2147         * s12z-tdep.c: Fix common/ includes.
2148         * rust-exp.y: Fix common/ includes.
2149         * rs6000-aix-tdep.c: Fix common/ includes.
2150         * riscv-tdep.c: Fix common/ includes.
2151         * remote.c: Fix common/ includes.
2152         * remote-notif.h: Fix common/ includes.
2153         * remote-fileio.h: Fix common/ includes.
2154         * remote-fileio.c: Fix common/ includes.
2155         * regcache.h: Fix common/ includes.
2156         * regcache.c: Fix common/ includes.
2157         * record-btrace.c: Fix common/ includes.
2158         * python/python.c: Fix common/ includes.
2159         * python/py-type.c: Fix common/ includes.
2160         * python/py-inferior.c: Fix common/ includes.
2161         * progspace.h: Fix common/ includes.
2162         * producer.c: Fix common/ includes.
2163         * procfs.c: Fix common/ includes.
2164         * proc-api.c: Fix common/ includes.
2165         * printcmd.c: Fix common/ includes.
2166         * ppc-linux-nat.c: Fix common/ includes.
2167         * parser-defs.h: Fix common/ includes.
2168         * osdata.c: Fix common/ includes.
2169         * obsd-nat.c: Fix common/ includes.
2170         * nat/x86-linux.c: Fix common/ includes.
2171         * nat/x86-linux-dregs.c: Fix common/ includes.
2172         * nat/x86-dregs.h: Fix common/ includes.
2173         * nat/x86-dregs.c: Fix common/ includes.
2174         * nat/ppc-linux.c: Fix common/ includes.
2175         * nat/mips-linux-watch.h: Fix common/ includes.
2176         * nat/mips-linux-watch.c: Fix common/ includes.
2177         * nat/linux-waitpid.c: Fix common/ includes.
2178         * nat/linux-ptrace.h: Fix common/ includes.
2179         * nat/linux-ptrace.c: Fix common/ includes.
2180         * nat/linux-procfs.c: Fix common/ includes.
2181         * nat/linux-personality.c: Fix common/ includes.
2182         * nat/linux-osdata.c: Fix common/ includes.
2183         * nat/linux-namespaces.c: Fix common/ includes.
2184         * nat/linux-btrace.h: Fix common/ includes.
2185         * nat/linux-btrace.c: Fix common/ includes.
2186         * nat/fork-inferior.c: Fix common/ includes.
2187         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2188         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2189         * nat/aarch64-linux.c: Fix common/ includes.
2190         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2191         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2192         * namespace.h: Fix common/ includes.
2193         * mips-linux-tdep.c: Fix common/ includes.
2194         * minsyms.c: Fix common/ includes.
2195         * mi/mi-parse.h: Fix common/ includes.
2196         * mi/mi-main.c: Fix common/ includes.
2197         * mi/mi-cmd-env.c: Fix common/ includes.
2198         * memrange.h: Fix common/ includes.
2199         * memattr.c: Fix common/ includes.
2200         * maint.h: Fix common/ includes.
2201         * maint.c: Fix common/ includes.
2202         * main.c: Fix common/ includes.
2203         * machoread.c: Fix common/ includes.
2204         * location.c: Fix common/ includes.
2205         * linux-thread-db.c: Fix common/ includes.
2206         * linux-nat.c: Fix common/ includes.
2207         * linux-fork.c: Fix common/ includes.
2208         * inline-frame.c: Fix common/ includes.
2209         * infrun.c: Fix common/ includes.
2210         * inflow.c: Fix common/ includes.
2211         * inferior.h: Fix common/ includes.
2212         * inferior.c: Fix common/ includes.
2213         * infcmd.c: Fix common/ includes.
2214         * inf-ptrace.c: Fix common/ includes.
2215         * inf-child.c: Fix common/ includes.
2216         * ia64-linux-nat.c: Fix common/ includes.
2217         * i387-tdep.c: Fix common/ includes.
2218         * i386-tdep.c: Fix common/ includes.
2219         * i386-linux-tdep.c: Fix common/ includes.
2220         * i386-linux-nat.c: Fix common/ includes.
2221         * i386-go32-tdep.c: Fix common/ includes.
2222         * i386-fbsd-tdep.c: Fix common/ includes.
2223         * i386-fbsd-nat.c: Fix common/ includes.
2224         * guile/scm-type.c: Fix common/ includes.
2225         * guile/guile.c: Fix common/ includes.
2226         * go32-nat.c: Fix common/ includes.
2227         * gnu-nat.c: Fix common/ includes.
2228         * gdbthread.h: Fix common/ includes.
2229         * gdbarch-selftests.c: Fix common/ includes.
2230         * gdb_usleep.c: Fix common/ includes.
2231         * gdb_select.h: Fix common/ includes.
2232         * gdb_bfd.c: Fix common/ includes.
2233         * gcore.c: Fix common/ includes.
2234         * fork-child.c: Fix common/ includes.
2235         * findvar.c: Fix common/ includes.
2236         * fbsd-nat.c: Fix common/ includes.
2237         * event-top.c: Fix common/ includes.
2238         * event-loop.c: Fix common/ includes.
2239         * dwarf2read.c: Fix common/ includes.
2240         * dwarf2loc.c: Fix common/ includes.
2241         * dwarf2-frame.c: Fix common/ includes.
2242         * dwarf-index-cache.c: Fix common/ includes.
2243         * dtrace-probe.c: Fix common/ includes.
2244         * disasm-selftests.c: Fix common/ includes.
2245         * defs.h: Fix common/ includes.
2246         * csky-tdep.c: Fix common/ includes.
2247         * cp-valprint.c: Fix common/ includes.
2248         * cp-support.h: Fix common/ includes.
2249         * cp-support.c: Fix common/ includes.
2250         * corelow.c: Fix common/ includes.
2251         * completer.h: Fix common/ includes.
2252         * completer.c: Fix common/ includes.
2253         * compile/compile.c: Fix common/ includes.
2254         * compile/compile-loc2c.c: Fix common/ includes.
2255         * compile/compile-cplus-types.c: Fix common/ includes.
2256         * compile/compile-cplus-symbols.c: Fix common/ includes.
2257         * command.h: Fix common/ includes.
2258         * cli/cli-dump.c: Fix common/ includes.
2259         * cli/cli-cmds.c: Fix common/ includes.
2260         * charset.c: Fix common/ includes.
2261         * build-id.c: Fix common/ includes.
2262         * btrace.h: Fix common/ includes.
2263         * btrace.c: Fix common/ includes.
2264         * breakpoint.h: Fix common/ includes.
2265         * breakpoint.c: Fix common/ includes.
2266         * ax.h:
2267         (enum agent_op): Fix common/ includes.
2268         * ax-general.c (struct aop_map): Fix common/ includes.
2269         * ax-gdb.c: Fix common/ includes.
2270         * auxv.c: Fix common/ includes.
2271         * auto-load.c: Fix common/ includes.
2272         * arm-tdep.c: Fix common/ includes.
2273         * arch/riscv.c: Fix common/ includes.
2274         * arch/ppc-linux-common.c: Fix common/ includes.
2275         * arch/i386.c: Fix common/ includes.
2276         * arch/arm.c: Fix common/ includes.
2277         * arch/arm-linux.c: Fix common/ includes.
2278         * arch/arm-get-next-pcs.c: Fix common/ includes.
2279         * arch/amd64.c: Fix common/ includes.
2280         * arch/aarch64.c: Fix common/ includes.
2281         * arch/aarch64-insn.c: Fix common/ includes.
2282         * arch-utils.c: Fix common/ includes.
2283         * amd64-windows-tdep.c: Fix common/ includes.
2284         * amd64-tdep.c: Fix common/ includes.
2285         * amd64-sol2-tdep.c: Fix common/ includes.
2286         * amd64-obsd-tdep.c: Fix common/ includes.
2287         * amd64-nbsd-tdep.c: Fix common/ includes.
2288         * amd64-linux-tdep.c: Fix common/ includes.
2289         * amd64-linux-nat.c: Fix common/ includes.
2290         * amd64-fbsd-tdep.c: Fix common/ includes.
2291         * amd64-fbsd-nat.c: Fix common/ includes.
2292         * amd64-dicos-tdep.c: Fix common/ includes.
2293         * amd64-darwin-tdep.c: Fix common/ includes.
2294         * agent.c: Fix common/ includes.
2295         * ada-lang.h: Fix common/ includes.
2296         * ada-lang.c: Fix common/ includes.
2297         * aarch64-tdep.c: Fix common/ includes.
2298
2299 2019-01-25  Tom Tromey  <tom@tromey.com>
2300
2301         * common/create-version.sh: Use common/version.h.
2302
2303 2019-01-24  Pedro Alves  <palves@redhat.com>
2304
2305         * infrun.c (signal_stop, signal_print, signal_program)
2306         (signal_catch, signal_pass): Now arrays instead of pointers.
2307         (update_signals_program_target, do_target_resume)
2308         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2309         * linux-nat.c (linux_nat_target::pass_signals)
2310         (linux_nat_target::create_inferior, linux_nat_target::attach):
2311         Adjust.
2312         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2313         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2314         * procfs.c (procfs_target::pass_signals): Adjust.
2315         * record-full.c (record_full_target::resume): Adjust.
2316         * remote.c (remote_target::pass_signals)
2317         (remote_target::program_signals): Adjust.
2318         * target-debug.h (target_debug_print_signals): Now takes a
2319         gdb::array_view as parameter.  Adjust.
2320         * target.h (target_ops) <pass_signals, program_signals>: Replace
2321         pointer and length parameters with gdb::array_view.
2322         (target_pass_signals, target_program_signals): Likewise.
2323         * target-delegates.c: Regenerate.
2324
2325 2019-01-24  Pedro Alves  <palves@redhat.com>
2326
2327         * common/forward-scope-exit.h
2328         (forward_scope_exit::forward_scope_exit): Pass arguments to
2329         m_bind_function directly, instead of creating a std::bind and
2330         copying that.
2331
2332 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2333
2334         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2335         for static members.
2336         (pass_in_v_vfp_candidate): Likewise.
2337
2338 2019-01-23  Tom Tromey  <tom@tromey.com>
2339             Pedro Alves  <palves@redhat.com>
2340
2341         * regcache.c (class regcache_invalidator): Remove.
2342         (regcache::raw_write): Use make_scope_exit.
2343
2344 2019-01-23  Tom Tromey  <tom@tromey.com>
2345
2346         * ui-out.h (class ui_out_emit_type): Update comment.
2347
2348 2019-01-23  Tom Tromey  <tom@tromey.com>
2349
2350         * infrun.c (fetch_inferior_event): Update comment.
2351
2352 2019-01-23  Tom Tromey  <tom@tromey.com>
2353             Pedro Alves  <palves@redhat.com>
2354
2355         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2356         parameter.
2357         (fetch_inferior_event): Use SCOPE_EXIT.
2358
2359
2360 2019-01-23  Tom Tromey  <tom@tromey.com>
2361             Pedro Alves  <palves@redhat.com>
2362
2363         * infrun.c (disable_thread_events): Delete.
2364         (stop_all_threads): Use SCOPE_EXIT.
2365
2366 2019-01-23  Tom Tromey  <tom@tromey.com>
2367             Pedro Alves  <palves@redhat.com>
2368
2369         * symfile.c: Include forward-scope-exit.h.
2370         (clear_symtab_users_cleanup): Replace forward declaration with
2371         a FORWARD_SCOPE_EXIT.
2372         (syms_from_objfile_1): Use the forward_scope_exit and
2373         gdb::optional instead of cleanup_function.
2374         (reread_symbols): Use the forward_scope_exit instead of
2375         cleanup_function.
2376         (clear_symtab_users_cleanup): Remove function.
2377
2378 2019-01-23  Tom Tromey  <tom@tromey.com>
2379             Pedro Alves  <palves@redhat.com>
2380
2381         * linux-nat.c: Include scope-exit.h.
2382         (cleanup_target_stop): Remove.
2383         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2384         SCOPE_EXIT.
2385
2386 2019-01-23  Tom Tromey  <tom@tromey.com>
2387             Pedro Alves  <palves@redhat.com>
2388
2389         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2390         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2391
2392 2019-01-23  Tom Tromey  <tom@tromey.com>
2393             Andrew Burgess  <andrew.burgess@embecosm.com>
2394             Pedro Alves  <palves@redhat.com>
2395
2396         * infrun.c (fetch_inferior_event): Use scope_exit.
2397         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2398         * top.c (execute_command): Use scope_exit.
2399         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2400         * utils.c (do_bpstat_clear_actions_cleanup)
2401         (make_bpstat_clear_actions_cleanup): Remove.
2402
2403 2019-01-23  Tom Tromey  <tom@tromey.com>
2404             Pedro Alves  <palves@redhat.com>
2405
2406         * infrun.c: Include "common/scope-exit.h"
2407         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2408         (wait_for_inferior): Use SCOPE_EXIT.
2409         (fetch_inferior_event): Use scope_exit.
2410
2411 2019-01-23  Tom Tromey  <tom@tromey.com>
2412             Pedro Alves  <palves@redhat.com>
2413
2414         * breakpoint.c (create_breakpoint): Remove cleanup.
2415
2416 2019-01-23  Tom Tromey  <tom@tromey.com>
2417             Andrew Burgess  <andrew.burgess@embecosm.com>
2418             Pedro Alves  <palves@redhat.com>
2419
2420 2019-01-23  Pedro Alves  <palves@redhat.com>
2421
2422         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2423
2424 2019-01-23  Pedro Alves  <palves@redhat.com>
2425             Andrew Burgess  <andrew.burgess@embecosm.com>
2426
2427         * gdbthread.h: Include "common/forward-scope-exit.h".
2428         (scoped_finish_thread_state): Redefine custom class in terms of
2429         forward_scope_exit.
2430
2431 2019-01-23  Pedro Alves  <palves@redhat.com>
2432             Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * common/forward-scope-exit.h: New file.
2435
2436 2019-01-23  Pedro Alves  <palves@redhat.com>
2437             Andrew Burgess  <andrew.burgess@embecosm.com>
2438             Tom Tromey  <tom@tromey.com>
2439
2440         * common/scope-exit.h: New file.
2441
2442 2019-01-23  Pedro Alves  <palves@redhat.com>
2443
2444         * common/preprocessor.h (ESC): Rename to ...
2445         (ESC_PARENS): ... this.
2446         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2447         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2448
2449 2019-01-23  Tom Tromey  <tom@tromey.com>
2450
2451         * language.h (class scoped_switch_to_sym_language_if_auto):
2452         Initialize m_lang in both cases.
2453
2454 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2455
2456         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2457         with XCNEW.
2458
2459 2019-01-22  Tom Tromey  <tom@tromey.com>
2460
2461         * corelow.c: Do not include sys/file.h.
2462
2463 2019-01-22  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-wingeneral.h: Include gdb_curses.h.
2466
2467 2019-01-22  Tom Tromey  <tom@tromey.com>
2468
2469         * source-cache.h (class source_cache) <get_source_lines,
2470         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2471
2472 2019-01-22  Tom Tromey  <tom@tromey.com>
2473
2474         * remote-fileio.h (struct remote_target): Declare.
2475
2476 2019-01-22  Tom Tromey  <tom@tromey.com>
2477
2478         * python/py-arch.c: Do not include py-ref.h.
2479         * python/py-bpevent.c: Do not include py-ref.h.
2480         * python/py-cmd.c: Do not include py-ref.h.
2481         * python/py-continueevent.c: Do not include py-ref.h.
2482         * python/py-event.h: Do not include py-ref.h.
2483         * python/py-evtregistry.c: Do not include py-ref.h.
2484         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2485         * python/py-frame.c: Do not include py-ref.h.
2486         * python/py-framefilter.c: Do not include py-ref.h.
2487         * python/py-function.c: Do not include py-ref.h.
2488         * python/py-infevents.c: Do not include py-ref.h.
2489         * python/py-linetable.c: Do not include py-ref.h.
2490         * python/py-objfile.c: Do not include py-ref.h.
2491         * python/py-param.c: Do not include py-ref.h.
2492         * python/py-prettyprint.c: Do not include py-ref.h.
2493         * python/py-progspace.c: Do not include py-ref.h.
2494         * python/py-symbol.c: Do not include py-ref.h.
2495         * python/py-symtab.c: Do not include py-ref.h.
2496         * python/py-type.c: Do not include py-ref.h.
2497         * python/py-unwind.c: Do not include py-ref.h.
2498         * python/py-utils.c: Do not include py-ref.h.
2499         * python/py-value.c: Do not include py-ref.h.
2500         * python/py-varobj.c: Do not include py-ref.h.
2501         * python/py-xmethods.c: Do not include py-ref.h.
2502         * python/python.c: Do not include py-ref.h.
2503         * varobj.c: Do not include py-ref.h.
2504
2505 2019-01-22  Tom Tromey  <tom@tromey.com>
2506
2507         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2508         keyword for bcache.
2509
2510 2019-01-22  Tom Tromey  <tom@tromey.com>
2511
2512         * compile/compile-cplus-types.c: Remove a comment by #include.
2513
2514 2019-01-22  Tom Tromey  <tom@tromey.com>
2515
2516         * compile/gcc-c-plugin.h: Include compile-internal.h.
2517
2518 2019-01-22  Tom Tromey  <tom@tromey.com>
2519
2520         * stabsread.c (EXTERN): Do not define.
2521         (symnum, next_symbol_text_func, processing_gcc_compilation)
2522         (within_function, global_sym_chain, global_stabs)
2523         (previous_stab_code, this_object_header_files)
2524         (n_this_object_header_files)
2525         (n_allocated_this_object_header_files): Define.
2526         * stabsread.h (EXTERN): Never define.  Use "extern".
2527
2528 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2529
2530         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2531         history_value.
2532
2533 2019-01-21  Tom Tromey  <tom@tromey.com>
2534
2535         * ui-out.c: Fix includes.
2536         * tui/tui-source.c: Fix includes.
2537         * target.c: Fix includes.
2538         * remote.c: Fix includes.
2539         * regcache.c: Fix includes.
2540         * python/py-block.c: Fix includes.
2541         * printcmd.c: Fix includes.
2542         * or1k-tdep.c: Fix includes.
2543         * mi/mi-main.c: Fix includes.
2544         * m32r-tdep.c: Fix includes.
2545         * csky-tdep.c: Fix includes.
2546         * compile/compile-cplus-types.c: Fix includes.
2547         * cli/cli-interp.c: Fix includes.
2548
2549 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2550
2551         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2552         for padding.
2553
2554 2019-01-16  Tom Tromey  <tom@tromey.com>
2555
2556         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2557         earlier.
2558         (struct objfile) <msymbols_range>: Move from top level.
2559         <msymbols>: New method.
2560         (class objfile_msymbols): Remove.
2561         * symtab.c (default_collect_symbol_completion_matches_break_on):
2562         Update.
2563         * symmisc.c (dump_msymbols): Update.
2564         * stabsread.c (scan_file_globals): Update.
2565         * objc-lang.c (info_selectors_command, info_classes_command)
2566         (find_methods): Update.
2567         * minsyms.c (find_solib_trampoline_target): Update.
2568         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2569         * coffread.c (coff_symfile_read): Update.
2570         * ada-lang.c (ada_lookup_simple_minsym)
2571         (ada_collect_symbol_completion_matches): Update.
2572
2573 2019-01-16  Tom Tromey  <tom@tromey.com>
2574
2575         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2576         type.  Remove no-argument constructor.
2577         <iterator::operator++>: Simplify.
2578         <begin>: Update.
2579         <end>: Use minimal_symbol_count.
2580
2581 2019-01-16  Tom Tromey  <tom@tromey.com>
2582
2583         * objfiles.h (struct objfile) <psymtabs>: New method.
2584         (class objfile_psymtabs): Remove.
2585         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2586         typedef.
2587         <range>: New method.
2588         (require_partial_symbols): Change return type.
2589         * psymtab.c (require_partial_symbols)
2590         (psym_expand_symtabs_matching): Update.
2591         * mdebugread.c (parse_partial_symbols): Update.
2592         * dbxread.c (dbx_end_psymtab): Update.
2593
2594 2019-01-15  Tom Tromey  <tom@tromey.com>
2595
2596         * symtab.c (lookup_objfile_from_block)
2597         (lookup_symbol_in_objfile_symtabs)
2598         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2599         (find_line_symtab, info_sources_command)
2600         (default_collect_symbol_completion_matches_break_on)
2601         (make_source_files_completion_list): Update.
2602         * symmisc.c (print_objfile_statistics, dump_objfile)
2603         (maintenance_print_symbols, maintenance_info_symtabs)
2604         (maintenance_check_symtabs, maintenance_info_line_tables):
2605         Update.
2606         * source.c (select_source_symtab)
2607         (forget_cached_source_info_for_objfile): Update.
2608         * objfiles.h (class objfile_compunits): Remove.
2609         (struct objfile) <compunits_range>: New typedef.
2610         (compunits): New method.
2611         * objfiles.c (objfile_relocate1): Update.
2612         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2613         * maint.c (count_symtabs_and_blocks): Update.
2614         * linespec.c (iterate_over_all_matching_symtabs): Update.
2615         * cp-support.c (add_symbol_overload_list_qualified): Update.
2616         * coffread.c (coff_symtab_read): Update.
2617         * ada-lang.c (add_nonlocal_symbols)
2618         (ada_collect_symbol_completion_matches)
2619         (ada_add_global_exceptions): Update.
2620
2621 2019-01-15  Tom Tromey  <tom@tromey.com>
2622
2623         * progspace.h (program_space) <objfiles_safe_range>: New
2624         typedef.
2625         <objfiles_safe>: New method.
2626         * objfiles.h (class all_objfiles_safe): Remove.
2627         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2628         * jit.c (jit_inferior_exit_hook): Update.
2629
2630 2019-01-17  Tom Tromey  <tom@tromey.com>
2631
2632         * progspace.h (program_space) <objfiles_range>: New typedef.
2633         <objfiles>: New method.
2634         <objfiles_head>: Rename from objfiles.
2635         (object_files): Update.
2636         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2637         * guile/scm-pretty-print.c
2638         (ppscm_find_pretty_printer_from_objfiles): Update.
2639         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2640         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2641         Update.
2642         * python/py-progspace.c (pspy_get_objfiles): Update.
2643         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2644         Update.
2645         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2646         (objfpy_lookup_objfile_by_build_id): Update.
2647         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2648         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2649         Update.
2650         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2651         (expand_symtab_containing_pc, lookup_objfile_from_block)
2652         (lookup_static_symbol, basic_lookup_transparent_type)
2653         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2654         (find_line_symtab, info_sources_command)
2655         (default_collect_symbol_completion_matches_break_on)
2656         (make_source_files_completion_list, find_main_name): Update.
2657         * symmisc.c (print_symbol_bcache_statistics)
2658         (print_objfile_statistics, maintenance_print_symbols)
2659         (maintenance_print_msymbols, maintenance_print_objfiles)
2660         (maintenance_info_symtabs, maintenance_check_symtabs)
2661         (maintenance_expand_symtabs, maintenance_info_line_tables):
2662         Update.
2663         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2664         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2665         (map_overlay_command, unmap_overlay_command)
2666         (simple_overlay_update, expand_symtabs_matching)
2667         (map_symbol_filenames): Update.
2668         * symfile-debug.c (set_debug_symfile): Update.
2669         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2670         Update.
2671         * source.c (select_source_symtab, forget_cached_source_info):
2672         Update.
2673         * solib.c (solib_read_symbols): Update.
2674         * solib-spu.c (append_ocl_sos): Update.
2675         * psymtab.c (maintenance_print_psymbols)
2676         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2677         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2678         * printcmd.c (info_symbol_command): Update.
2679         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2680         Update.
2681         * objfiles.h (class all_objfiles): Remove.
2682         * objfiles.c (have_partial_symbols, have_full_symbols)
2683         (have_minimal_symbols, qsort_cmp, update_section_map)
2684         (shared_objfile_contains_address_p)
2685         (default_iterate_over_objfiles_in_search_order): Update.
2686         * objc-lang.c (info_selectors_command, info_classes_command)
2687         (find_methods): Update.
2688         * minsyms.c (find_solib_trampoline_target): Update.
2689         * maint.c (maintenance_info_sections)
2690         (maintenance_translate_address, count_symtabs_and_blocks):
2691         Update.
2692         * main.c (captured_main_1): Update.
2693         * linux-thread-db.c (try_thread_db_load_from_pdir)
2694         (has_libpthread): Update.
2695         * linespec.c (iterate_over_all_matching_symtabs)
2696         (search_minsyms_for_name): Update.
2697         * jit.c (jit_find_objf_with_entry_addr): Update.
2698         * hppa-tdep.c (find_unwind_entry)
2699         (hppa_lookup_stub_minimal_symbol): Update.
2700         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2701         Update.
2702         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2703         (elf_gnu_ifunc_resolve_by_got): Update.
2704         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2705         * dwarf-index-write.c (save_gdb_index_command): Update.
2706         * cp-support.c (add_symbol_overload_list_qualified): Update.
2707         * breakpoint.c (create_overlay_event_breakpoint)
2708         (create_longjmp_master_breakpoint)
2709         (create_std_terminate_master_breakpoint)
2710         (create_exception_master_breakpoint): Update.
2711         * blockframe.c (find_pc_partial_function): Update.
2712         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2713         (ada_collect_symbol_completion_matches)
2714         (ada_add_global_exceptions): Update.
2715
2716 2019-01-17  Tom Tromey  <tom@tromey.com>
2717
2718         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2719         declare VEC.
2720         (solib_target_parse_libraries): Change return type.
2721         (library_list_start_segment, library_list_start_section)
2722         (library_list_end_library, library_list_start_library); Update.
2723         (solib_target_free_library_list): Remove.
2724         (solib_target_parse_libraries): Remove cleanup.  Change return
2725         type.
2726         (solib_target_current_sos): Update.
2727
2728 2019-01-17  Tom Tromey  <tromey@bapiya>
2729
2730         * valprint.c: Replace "the the" with "the".
2731         * symtab.c: Replace "the the" with "the".
2732         * solib.c: Replace "the the" with "the".
2733         * solib-dsbt.c: Replace "the the" with "the".
2734         * linespec.c: Replace "the the" with "the".
2735         * dwarf2loc.h: Replace "the the" with "the".
2736         * amd64-windows-tdep.c: Replace "the the" with "the".
2737         * aarch64-tdep.c: Replace "the the" with "the".
2738
2739 2019-01-16  Keith Seitz  <keiths@redhat.com>
2740
2741         PR gdb/23773
2742         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2743         <builder>: Rename to ..
2744         <m_builder>: ... this and make private.
2745         (dwarf2_cu::get_builder): New method.  Change all users of
2746         `builder' to use this method.
2747         (dwarf2_start_symtab): Move to ...
2748         (dwarf2_cu::start_symtab): ... here.  Update all callers
2749         (setup_type_unit_groups): Move to ...
2750         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2751         callers.
2752         (dwarf2_cu::reset_builder): New method.
2753         (process_full_compunit, process_full_type_unit): Use
2754         dwarf2_cu::reset_builder.
2755         (follow_die_offset): Record the ancestor CU if it is different
2756         from the followed DIE's CU.
2757         (follow_die_sig_1): Likewise.
2758
2759 2019-01-15  Tom Tromey  <tom@tromey.com>
2760
2761         * remote.c (class remote_state) <buf>: Now a char_vector.
2762         <buf_size>: Remove.
2763         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2764         parameter.
2765         (remote_target::getpkt_or_notif_sane_1)
2766         (remote_target::getpkt_sane)
2767         (remote_target::getpkt_or_notif_sane): Likewise.
2768         (class remote_target) <putpkt>: New overload.
2769         (remote_target::read_frame): Change type of "buf_p".  Remove
2770         sizeof_p parameter.
2771         (packet_ok): New overload.
2772         (packet_check_result): New overload.
2773         Update all uses.
2774
2775 2019-01-14  Tom Tromey  <tom@tromey.com>
2776
2777         * remote-notif.c (handle_notification, remote_notif_ack)
2778         (remote_notif_parse): Make "buf" const.
2779         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2780         const.
2781         (remote_notif_parse, remote_notif_ack, handle_notification):
2782         Likewise.
2783         * remote.c (remote_notif_stop_parse): Make "buf" const.
2784         (remote_target::remote_parse_stop_reply): Make "buf" const.
2785         (remote_notif_stop_ack): Make "buf" const.
2786
2787 2019-01-14  Tom Tromey  <tom@tromey.com>
2788
2789         * remote.c (remote_console_output): Make parameter const.
2790
2791 2019-01-14  Tom Tromey  <tom@tromey.com>
2792
2793         * target-debug.h (target_debug_print_signals): Constify.
2794         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2795         * procfs.c (procfs_target::pass_signals): Update.
2796         * linux-nat.c (linux_nat_target::pass_signals): Update.
2797         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2798         * target-delegates.c: Rebuild.
2799         * remote.c (remote_target::program_signals): Update.
2800         (remote_target::pass_signals): Update.
2801         * target.c (target_pass_signals): Constify argument.
2802         (target_program_signals): Likewise.
2803         * target.h (struct target_ops) <pass_signals, program_signals>:
2804         Constify argument.
2805         (target_pass_signals, target_program_signals): Constify argument.
2806
2807 2019-01-14  Tom Tromey  <tom@tromey.com>
2808
2809         PR tui/28819:
2810         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2811
2812 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2813
2814         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2815         field.
2816         * rs6000-tdep.c: Include reggroups.h.
2817         (IS_V_ALIAS_PSEUDOREG): Define.
2818         (rs6000_register_name): Return names for the "vX" aliases.
2819         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2820         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2821         aliases.  Call default_register_reggroup_p for all other
2822         pseudo-registers.
2823         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2824         New functions.
2825         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2826         Handle "vX" aliases.
2827         (v_alias_pseudo_register_collect): New function.
2828         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2829         (rs6000_gdbarch_init): Initialize "vX" aliases as
2830         pseudo-registers.  Restore registration of
2831         rs6000_pseudo_register_reggroup_p with
2832         set_tdesc_pseudo_register_reggroup_p.
2833
2834 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2835
2836         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2837         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2838         set_gdbarch_num_pseudo_regs.
2839
2840 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2841
2842         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2843         Remove arg prefixname, add do_set and do_show.
2844         Add member functions set_list and show_list.
2845         * cli/cli-style.c (class cli_style_option): Update accordingly.
2846         (style_set_list): Move to file scope.
2847         (style_show_list): Likewise.
2848         (set_style): Call help_list.
2849         (show_style): Call cmd_show_list.
2850         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2851         Update to use the new macro.
2852
2853 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2854
2855         * ada-lang.c (_initialize_ada_language): Expand the help text
2856         for the "catch exception" command.
2857
2858 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2859
2860         * symtab.c (matching_obj_sections): Initialize obj,
2861         declare it closer to its usage.
2862
2863 2019-01-10  Tom Tromey  <tom@tromey.com>
2864
2865         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2866         (basic_inf_threads_range): Remove.
2867         (inf_threads_range, inf_non_exited_threads_range)
2868         (safe_inf_threads_range): Use next_adapter.
2869
2870 2019-01-10  Keith Seitz  <keiths@redhat.com>
2871
2872         PR gdb/23712
2873         PR symtab/23010
2874         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2875         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2876
2877 2019-01-10  Keith Seitz  <keiths@redhat.com>
2878
2879         PR gdb/23712
2880         PR symtab/23010
2881         * dictionary.c (pending_to_vector): Remove.
2882         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2883         Remove _1 suffix, replacing functions of the same name.  Update
2884         all callers.
2885         (dict_create_hashed, dict_create_hashed_expandable)
2886         (dict_create_linear, dict_create_linear_expandable, dict_free)
2887         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2888         Make functions static.
2889
2890 2019-01-10  Keith Seitz  <keiths@redhat.com>
2891
2892         PR gdb/23712
2893         PR symtab/23010
2894         * dictionary.h (struct dictionary): Replace declaration with
2895         multidictionary.
2896         (dict_create_hashed, dict_create_hashed_expandable)
2897         (dict_create_linear, dict_create_linear_expandable)
2898         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2899         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2900         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2901         taking multidictionary argument.
2902         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2903         * block.h (struct block) <dict>: Change to multidictionary
2904         and rename `multidict'.
2905         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2906         symmisc.c: Update all dictionary references to multidictionary.
2907
2908 2019-01-10  Keith Seitz  <keiths@redhat.com>
2909
2910         PR gdb/23712
2911         PR symtab/23010
2912         * dictionary.c: Include unordered_map.
2913         (pending_to_vector): New function.
2914         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2915         Rewrite the non-"_1" functions to take vector instead
2916         of linked list.
2917         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2918         "new" _1 versions of the same name.
2919         (multidictionary): Define.
2920         (std::hash<enum language): New definition.
2921         (collate_pending_symbols_by_language, mdict_create_hashed)
2922         (mdict_create_hashed_expandable, mdict_create_linear)
2923         (mdict_create_linear_expandable, mdict_free)
2924         (find_language_dictionary, create_new_language_dictionary)
2925         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2926         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2927         (mdict_size, mdict_empty): New functions.
2928         * dictionary.h (mdict_iterator): Define.
2929
2930 2019-01-10  Pedro Alves  <palves@redhat.com>
2931
2932         * breakpoint.c (read_uploaded_action)
2933         (create_tracepoint_from_upload): Adjust to use
2934         gdb::unique_xmalloc_ptr.
2935         * ctf.c (ctf_write_uploaded_tp):
2936         (SET_ARRAY_FIELD): Use emplace_back.
2937         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2938         * tracefile-tfile.c (tfile_write_uploaded_tp):
2939         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2940         gdb::unique_xmalloc_ptr.
2941         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2942         at_string, cond_string, cmd_strings>: Replace char pointers
2943         with gdb::unique_xmalloc_ptr.
2944
2945 2019-01-10  Pedro Alves  <palves@redhat.com>
2946
2947         * solib-target.c (library_list_start_library): Don't xstrdup name.
2948
2949 2019-01-10  Pedro Alves  <palves@redhat.com>
2950
2951         * mdebugread.c (parse_partial_symbols): Use
2952         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2953
2954 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * linux-fork.c (scoped_switch_fork_info)
2957         <~scoped_switch_fork_info>: Fix incorrect variable name.
2958
2959 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2960
2961         * linux-fork.c (scoped_switch_fork_info)
2962         <scoped_switch_fork_info>: Make explicit.
2963         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2964
2965 2019-01-10  Tom Tromey  <tom@tromey.com>
2966
2967         * objfiles.h (objfile::reset_psymtabs): Update.
2968         * objfiles.c (objfile::objfile): Update.
2969         * psymtab.h (psymtab_storage::obstack): Update.
2970         (psymtab_storage::m_obstack): Use gdb::optional.
2971         (class psymtab_storage): Update comment.  Remove objfile
2972         parameter.
2973         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2974
2975 2019-01-10  Tom Tromey  <tom@tromey.com>
2976
2977         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2978         <free_psymtabs>: Now private.
2979         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2980         (allocate_psymtab): Use new method.
2981
2982 2019-01-10  Tom Tromey  <tom@tromey.com>
2983
2984         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2985         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2986         * mdebugread.c (parse_partial_symbols): Use
2987         allocate_dependencies.
2988         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2989         allocate_dependencies.
2990         (process_psymtab_comp_unit_reader)
2991         (build_type_psymtab_dependencies): Likewise.
2992         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2993
2994 2019-01-10  Tom Tromey  <tom@tromey.com>
2995
2996         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2997         PSYMBOL_SET_LANGUAGE.
2998         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2999
3000 2019-01-10  Tom Tromey  <tom@tromey.com>
3001
3002         * psymtab.h (psymtab_storage::obstack): New method.
3003         <m_obstack>: Rename from obstack; now private.
3004         * psymtab.c (psymtab_storage): Update.
3005         * dwarf2read.c (create_addrmap_from_index)
3006         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3007         Update.
3008
3009 2019-01-10  Tom Tromey  <tom@tromey.com>
3010
3011         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3012         * objfiles.h (objfile::reset_psymtabs): New method.
3013
3014 2019-01-10  Tom Tromey  <tom@tromey.com>
3015
3016         * symmisc.c (print_symbol_bcache_statistics): Update.
3017         (print_objfile_statistics): Update.
3018         * symfile.c (reread_symbols): Update.
3019         * psymtab.h (class psymtab_storage): New.
3020         * psymtab.c (psymtab_storage): New constructor.
3021         (~psymtab_storage): New destructor.
3022         (require_partial_symbols): Update.
3023         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3024         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3025         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3026         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3027         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3028         (start_psymtab_common, end_psymtab_common)
3029         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3030         (allocate_psymtab): Update.
3031         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3032         Update.
3033         (dump_psymtab_addrmap, maintenance_print_psymbols)
3034         (maintenance_check_psymtabs): Update.
3035         (class objfile_psymtabs): Move to objfiles.h.
3036         * psympriv.h (discard_psymtab): Now inline.
3037         (psymtab_discarder::psymtab_discarder): Update.
3038         (psymtab_discarder::~psymtab_discarder): Update.
3039         (ALL_OBJFILE_PSYMTABS): Rewrite.
3040         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3041         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3042         Remove fields.
3043         <partial_symtabs>: New field.
3044         (class objfile_psymtabs): Move from psymtab.h.  Update.
3045         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3046         psymbol_cache.
3047         (objfile::~objfile): Don't destroy psymbol_cache.
3048         * mdebugread.c (parse_partial_symbols): Update.
3049         * dwarf2read.c (create_addrmap_from_index)
3050         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3051         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3052         (add_partial_subprogram, dwarf2_ranges_read): Update.
3053         * dwarf-index-write.c (write_address_map)
3054         (write_one_signatured_type, recursively_write_psymbols)
3055         (class debug_names, class debug_names, write_psymtabs_to_index):
3056         Update.
3057
3058 2019-01-10  Tom Tromey  <tom@tromey.com>
3059
3060         * symtab.h (SYMBOL_SET_NAMES): Update.
3061         (symbol_set_names): Update.
3062         (MSYMBOL_SET_NAMES): Update.
3063         * symtab.c (symbol_set_names): Change argument to be an
3064         objfile_per_bfd_storage.
3065         * psymtab.c (add_psymbol_to_bcache): Update.
3066         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3067
3068 2019-01-10  Tom Tromey  <tom@tromey.com>
3069
3070         * symtab.c (create_demangled_names_hash): Change argument to be an
3071         objfile_per_bfd_storage.
3072         (symbol_set_names): Update.
3073
3074 2019-01-10  Tom Tromey  <tom@tromey.com>
3075
3076         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3077         init_psymbol_list.
3078         * psymtab.c (init_psymbol_list): Do nothing if already called.
3079         * psympriv.h (init_psymbol_list): Add comment.
3080         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3081         init_psymbol_list.
3082         * dbxread.c (dbx_symfile_read): Unconditionally call
3083         init_psymbol_list.
3084
3085 2019-01-10  Tom Tromey  <tom@tromey.com>
3086
3087         * xcoffread.c (scan_xcoff_symtab): Update.
3088         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3089         "where".
3090         * mdebugread.c (parse_partial_symbols)
3091         (handle_psymbol_enumerators): Update.
3092         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3093         * dbxread.c (read_dbx_symtab): Update.
3094         * psympriv.h (psymbol_placement): New enum.
3095         (add_psymbol_to_list): Update.
3096
3097 2019-01-10  Tom Tromey  <tom@tromey.com>
3098
3099         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3100         static_psymbols parameters.
3101         (scan_xcoff_symtab): Update.
3102         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3103         static_psymbols parameters.
3104         * psympriv.h (start_psymtab_common): Update.
3105         * mdebugread.c (parse_partial_symbols): Update.
3106         * dwarf2read.c (create_partial_symtab): Update.
3107         * dbxread.c (read_dbx_symtab): Update.
3108         (start_psymtab): Remove global_psymbols and static_psymbols
3109         parameters.
3110
3111 2019-01-10  Tom Tromey  <tom@tromey.com>
3112
3113         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3114         * psymtab.c (allocate_psymtab): Add comment.
3115         * psympriv.h (allocate_psymtab): Add comment.
3116         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3117         initializations.
3118         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3119
3120 2019-01-10  Tom Tromey  <tom@tromey.com>
3121
3122         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3123         Don't declare.
3124         * mipsread.c: Include mdebugread.h.
3125         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3126         Declare.
3127         * elfread.c: Include mdebugread.h.
3128
3129 2019-01-09  Tom Tromey  <tom@tromey.com>
3130
3131         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3132         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3133         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3134         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3135         (psym_lookup_symbol, psym_find_last_source_symtab)
3136         (psym_forget_cached_source_info, psym_print_stats)
3137         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3138         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3139         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3140         (psym_find_compunit_symtab_by_address)
3141         (maintenance_print_psymbols, maintenance_info_psymtabs)
3142         (maintenance_check_psymtabs): Use ranged for.
3143         * psymtab.h (class objfile_psymtabs): New.
3144         (require_partial_symbols): Return objfile_psymtabs.
3145         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3146
3147 2019-01-09  Tom Tromey  <tom@tromey.com>
3148
3149         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3150         (find_pc_mapped_section, list_overlays_command)
3151         (map_overlay_command, unmap_overlay_command)
3152         (simple_overlay_update): Use all_objfiles.
3153         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3154         * printcmd.c (info_symbol_command): Use all_objfiles.
3155         * objfiles.h (ALL_OBJSECTIONS): Remove.
3156         * maint.c (maintenance_translate_address): Use all_objfiles.
3157         * gcore.c (gcore_create_callback): Use all_objfiles.
3158         (objfile_find_memory_regions): Likewise.
3159
3160 2019-01-09  Tom Tromey  <tom@tromey.com>
3161
3162         * symtab.c (find_line_symtab, info_sources_command)
3163         (make_source_files_completion_list): Use objfile_compunits.
3164         * source.c (select_source_symtab): Use objfile_compunits.
3165         * objfiles.h (struct objfile): Update comment.
3166         (ALL_OBJFILES): Remove.
3167         (ALL_FILETABS): Remove.
3168         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3169         objfile_compunits.
3170
3171 2019-01-09  Tom Tromey  <tom@tromey.com>
3172
3173         * symmisc.c (print_objfile_statistics, dump_objfile)
3174         (maintenance_print_symbols): Use compunit_filetabs.
3175         * source.c (forget_cached_source_info_for_objfile): Use
3176         compunit_filetabs.
3177         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3178         (ALL_FILETABS): Use compunit_filetabs.
3179         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3180         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3181
3182 2019-01-09  Tom Tromey  <tom@tromey.com>
3183
3184         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3185         (compunit_filetabs): New.
3186         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3187         compunit_filetabs.
3188         (info_sources_command, make_source_files_completion_list): Remove
3189         declaration.
3190         * symmisc.c (print_objfile_statistics, dump_objfile)
3191         (maintenance_print_symbols): Remove declaration.
3192         (maintenance_info_symtabs): Use compunit_filetabs.
3193         (maintenance_info_line_tables): Likewise.
3194         * source.c (select_source_symtab): Change local variable name.
3195         (forget_cached_source_info_for_objfile): Remove declaration.
3196         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3197         * objfiles.c (objfile_relocate1): Remove declaration.
3198         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3199         declaration.
3200         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3201         * coffread.c (coff_symtab_read): Remove declaration.
3202         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3203         compunit_filetabs.
3204
3205 2019-01-09  Tom Tromey  <tom@tromey.com>
3206
3207         * symtab.c (lookup_objfile_from_block)
3208         (find_pc_sect_compunit_symtab, search_symbols)
3209         (default_collect_symbol_completion_matches_break_on): Use
3210         objfile_compunits.
3211         * objfiles.h (ALL_COMPUNITS): Remove.
3212         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3213         * cp-support.c (add_symbol_overload_list_qualified): Use
3214         objfile_compunits.
3215         * ada-lang.c (ada_collect_symbol_completion_matches)
3216         (ada_add_global_exceptions): Use objfile_compunits.
3217
3218 2019-01-09  Tom Tromey  <tom@tromey.com>
3219
3220         * source.c (select_source_symtab)
3221         (forget_cached_source_info_for_objfile): Remove declaration.
3222         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3223         declaration.
3224         * maint.c (count_symtabs_and_blocks): Remove declaration.
3225         * cp-support.c (add_symbol_overload_list_qualified): Remove
3226         declaration.
3227         * coffread.c (coff_symtab_read): Remove declaration.
3228         * symtab.c (lookup_symbol_in_objfile_symtabs)
3229         (basic_lookup_transparent_type_1): Use objfile_compunits.
3230         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3231         (info_sources_command, search_symbols)
3232         (default_collect_symbol_completion_matches_break_on)
3233         (make_source_files_completion_list): Remove declaration.
3234         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3235         (ada_collect_symbol_completion_matches)
3236         (ada_add_global_exceptions): Remove declaration.
3237         * linespec.c (iterate_over_all_matching_symtabs): Use
3238         objfile_compunits.
3239         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3240         (class objfile_compunits): New.
3241         (ALL_COMPUNITS): Use objfile_compunits.
3242         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3243         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3244         objfile_compunits.
3245         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3246
3247 2019-01-09  Tom Tromey  <tom@tromey.com>
3248
3249         * symtab.c (search_symbols)
3250         (default_collect_symbol_completion_matches_break_on): Use
3251         objfile_msymbols.
3252         * ada-lang.c (ada_lookup_simple_minsym)
3253         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3254         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3255         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3256         objfile_msymbols.
3257         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3258         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3259         * objc-lang.c (find_methods): Use objfile_msymbols.
3260         (info_selectors_command, info_classes_command): Likewise.
3261         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3262         * objfiles.h (class objfile_msymbols): New.
3263         (ALL_OBJFILE_MSYMBOLS): Remove.
3264         (ALL_MSYMBOLS): Remove.
3265
3266 2019-01-09  Tom Tromey  <tom@tromey.com>
3267
3268         * common/next-iterator.h (next_adapter): Add Iterator template
3269         parameter.
3270         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3271         (class all_objfiles_safe): New.
3272         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3273         * objfiles.c (put_objfile_before): Update comment.
3274         (add_separate_debug_objfile): Likewise.
3275         (free_all_objfiles): Use all_objfiles_safe.
3276         (objfile_purge_solibs): Likewise.
3277
3278 2019-01-09  Tom Tromey  <tom@tromey.com>
3279
3280         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3281         (expand_symtab_containing_pc, lookup_static_symbol)
3282         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3283         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3284         all_objfiles.
3285         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3286         * breakpoint.c (create_overlay_event_breakpoint)
3287         (create_longjmp_master_breakpoint)
3288         (create_std_terminate_master_breakpoint)
3289         (create_exception_master_breakpoint): Use all_objfiles.
3290         * linux-thread-db.c (try_thread_db_load_from_pdir)
3291         (has_libpthread): Use all_objfiles.
3292         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3293         * linespec.c (iterate_over_all_matching_symtabs)
3294         (search_minsyms_for_name): Use all_objfiles.
3295         * maint.c (maintenance_info_sections): Use all_objfiles.
3296         * main.c (captured_main_1): Use all_objfiles.
3297         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3298         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3299         * guile/scm-pretty-print.c
3300         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3301         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3302         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3303         (maintenance_print_msymbols): Use all_objfiles.
3304         * source.c (select_source_symtab): Use all_objfiles.
3305         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3306         * symfile.c (remove_symbol_file_command)
3307         (expand_symtabs_matching, map_symbol_filenames): Use
3308         all_objfiles.
3309         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3310         all_objfiles.
3311         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3312         * objc-lang.c (find_methods): Use all_objfiles.
3313         * objfiles.c (have_partial_symbols, have_full_symbols)
3314         (have_minimal_symbols, qsort_cmp)
3315         (default_iterate_over_objfiles_in_search_order): Use
3316         all_objfiles.
3317         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3318         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3319         (maintenance_check_psymtabs): Use all_objfiles.
3320         (ALL_PSYMTABS): Remove.
3321         * compile/compile-object-run.c (do_module_cleanup): Use
3322         all_objfiles.
3323         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3324         * cp-support.c (add_symbol_overload_list_qualified): Use
3325         all_objfiles.
3326         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3327         Use all_objfiles.
3328         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3329         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3330         all_objfiles.
3331         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3332         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3333         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3334         Uses all_objfiles.
3335         * solib.c (solib_read_symbols): Use all_objfiles
3336
3337 2019-01-09  Tom Tromey  <tom@tromey.com>
3338
3339         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3340         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3341         all_objfiles.
3342         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3343         * symmisc.c (print_symbol_bcache_statistics)
3344         (print_objfile_statistics, maintenance_print_objfiles)
3345         (maintenance_info_symtabs, maintenance_check_symtabs)
3346         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3347         all_objfiles.
3348         * source.c (forget_cached_source_info): Use all_objfiles.
3349         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3350         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3351         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3352         * objfiles.c (update_section_map): Use all_objfiles.
3353         (shared_objfile_contains_address_p): Likewise.
3354         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3355         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3356
3357 2019-01-09  Tom Tromey  <tom@tromey.com>
3358
3359         * common/next-iterator.h: New file.
3360         * objfiles.h (class all_objfiles): New.
3361         (struct objfile_iterator): New.
3362
3363 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3364
3365         * NEWS: Move the description of the changed "frame", "select-frame",
3366          and "info frame" commands to the Changed commands section.
3367
3368 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3369
3370         * gdbtypes.c (check_stub_method_group): Remove handling of old
3371         mangling schemes.
3372         * linespec.c (find_methods): Likewise.
3373         * stabsread.c (read_member_functions): Likewise.
3374         * valops.c (search_struct_method): Likewise.
3375         (value_struct_elt_for_reference): Likewise.
3376         * NEWS: Mention this change.
3377
3378 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3379
3380         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3381         print_source_lines.
3382         * source.c (print_source_lines_base): Update line number check.
3383         (print_source_lines): New function.
3384         (source_lines_range::source_lines_range): New function.
3385         * source.h (class source_lines_range): New class.
3386         (print_source_lines): New declaration.
3387
3388 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3389
3390         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3391
3392 2019-01-08  Tom Tromey  <tom@tromey.com>
3393             Simon Marchi  <simon.marchi@ericsson.com>
3394
3395         PR gdb/24060
3396         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3397         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3398         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3399         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3400         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3401         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3402
3403 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * source.c (select_source_symtab): Move header comment to
3406         declaration in source.h.
3407         (forget_cached_source_info_for_objfile): Likewise.
3408         (forget_cached_source_info): Likewise.
3409         (identify_source_line): Likewise.
3410         * source.h (identify_source_line): Move declaration from symtab.h
3411         and add comment from source.c
3412         (print_source_lines): Likewise.
3413         (forget_cached_source_info_for_objfile): Likewise.
3414         (forget_cached_source_info): Likewise.
3415         (select_source_symtab): Likewise.
3416         (enum print_source_lines_flag): Move definition from symtab.h.
3417         * symtab.h (identify_source_line): Move declaration to source.h.
3418         (print_source_lines): Likewise.
3419         (forget_cached_source_info_for_objfile): Likewise.
3420         (forget_cached_source_info): Likewise.
3421         (select_source_symtab): Likewise.
3422         (enum print_source_lines_flag): Move definition to source.h.
3423         * tui/tui-hooks.c: Add 'source.h' include.
3424
3425 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3426
3427         * source.c (print_source_lines_base): Handle requests to print
3428         reverse line number sequences, and guard against empty lines
3429         string.
3430
3431 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3432
3433         * source.c (print_source_lines_base): Fix skip of '\r' if next
3434         character is '\n'.
3435
3436 2019-01-06  Tom Tromey  <tom@tromey.com>
3437
3438         * c-exp.y (struct c_parse_state) <macro_original_text,
3439         expansion_obstack>: New member.
3440         (macro_original_text, expansion_obstack): Remove globals.
3441         (scan_macro_expansion, scanning_macro_expansion)
3442         (finished_macro_expansion): Update.
3443         (scan_macro_cleanup): Remove.
3444         (yylex, c_parse): Update.
3445
3446 2019-01-06  Tom Tromey  <tom@tromey.com>
3447
3448         * c-exp.y (struct c_parse_state) <strings>: New member.
3449         (operator_stoken): Update.
3450
3451 2019-01-06  Tom Tromey  <tom@tromey.com>
3452
3453         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3454         (union type_stack_elt) <typelist_val>: Now a pointer to
3455         std::vector.
3456         (type_stack_cleanup): Don't declare.
3457         (push_typelist): Update.
3458         * parse.c (pop_typelist): Return a std::vector.
3459         (push_typelist): Take a std::vector.
3460         (follow_types): Update.  Do not free args.
3461         (type_stack_cleanup): Remove.
3462         * c-exp.y (struct c_parse_state): New.
3463         (cpstate): New global.
3464         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3465         (nonempty_typelist): Update.
3466         (func_mod): Create a new vector.
3467         (c_parse): Create a c_parse_state.
3468         (check_parameter_typelist): Do not delete params.
3469         (function_method): Update.  Do not delete type_list.
3470
3471 2019-01-06  Tom Tromey  <tom@tromey.com>
3472
3473         PR gdb/28155:
3474         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3475         check_typedef.
3476         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3477         (print_return_value): Likewise.
3478
3479 2019-01-05  Tom Tromey  <tom@tromey.com>
3480
3481         * contrib/cleanup_check.py: Remove.
3482         * contrib/gcc-with-excheck: Remove.
3483         * contrib/exsummary.py: Remove.
3484         * contrib/excheck.py: Remove.
3485
3486 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3487
3488         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3489         NULL. Initialize tpprev to NULL instead of assigning it
3490         to NULL on the next statement.
3491         * windows-nat.c (windows_delete_thread): Remove check for
3492         main_thread_id before printing thread exit notifications.
3493         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3494         Remove thread ID check against main_thread_id.
3495         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3496         windows_delete_thread.
3497         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3498
3499 2019-01-04  Tom Tromey  <tom@tromey.com>
3500
3501         * compile/compile.c (_initialize_compile): Use upper case for
3502         metasyntactic variables.
3503         * symmisc.c (_initialize_symmisc): Use upper case for
3504         metasyntactic variables.
3505         * psymtab.c (_initialize_psymtab): Use upper case for
3506         metasyntactic variables.
3507         * demangle.c (demangle_command): Use upper case for metasyntactic
3508         variables.
3509         (_initialize_demangler): Likewise.
3510         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3511         variables.
3512
3513 2019-01-03  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3516
3517 2019-01-03  Tom Tromey  <tom@tromey.com>
3518
3519         * python/py-symtab.c (salpy_str): Update.
3520         (struct salpy_sal_object) <symtab>: Now a PyObject.
3521         (salpy_dealloc): Update.
3522         (del_objfile_sal): Use gdbpy_ref.
3523
3524 2019-01-03  Tom Tromey  <tom@tromey.com>
3525
3526         * python/py-type.c (convert_field): Use new_reference.  Return
3527         gdbpy_ref.
3528         (make_fielditem): Return gdbpy_ref.
3529         (typy_fields): Update.
3530         (typy_getitem): Update.
3531         (field_name): Return gdbpy_ref.  Use new_reference.
3532         (typy_iterator_iternext): Update.
3533
3534 2019-01-03  Tom Tromey  <tom@tromey.com>
3535
3536         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3537
3538 2019-01-03  Tom Tromey  <tom@tromey.com>
3539
3540         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3541         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3542         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3543         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3544         (pspy_set_type_printers): Likewise.
3545         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3546         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3547         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3548         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3549         (objfpy_set_type_printers): Likewise.
3550
3551 2019-01-03  Tom Tromey  <tom@tromey.com>
3552
3553         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3554         (gdbpy_print_stack): Use gdbpy_err_fetch.
3555         * python/python-internal.h (class gdbpy_err_fetch): New class.
3556         (class gdbpy_enter) <m_error_type, m_error_value,
3557         m_error_traceback>: Remove.
3558         <m_error>: New member.
3559         (gdbpy_exception_to_string): Don't declare.
3560         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3561         * python/py-value.c (convert_value_from_python): Use
3562         gdbpy_err_fetch.
3563         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3564         gdbpy_exception_to_string.
3565         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3566         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3567         gdbpy_err_fetch.
3568
3569 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3570
3571         * linux-nat.c (delete_lwp_cleanup): Delete.
3572         (struct lwp_deleter): New struct.
3573         (lwp_info_up): New typedef.
3574         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3575         lwp_info_up.
3576
3577 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * linux-fork.c (class scoped_switch_fork_info): New class.
3580         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3581
3582 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * valops.c (find_overload_match): Remove use of null_cleanup, and
3585         calls to do_cleanups.
3586
3587 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * compile/compile-cplus-types.c
3590         (compile_cplus_instance::decl_name): Handle changes to
3591         cp_func_name.
3592         * cp-support.c (cp_func_name): Update header comment, update
3593         return type.
3594         * cp-support.h (cp_func_name): Update return type in declaration.
3595         * valops.c (find_overload_match): Move temp_func local to top
3596         level of function and change its type.  Use temp_func to hold and
3597         delete temporary string obtained from cp_func_name.
3598
3599 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3600
3601         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3602         gdb::char_vector, remove cleanup, and update uses of `msg`.
3603
3604 2019-01-03  Jim Wilson  <jimw@sifive.com>
3605
3606         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3607
3608 2019-01-02  Tom Tromey  <tom@tromey.com>
3609
3610         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3611         (tdesc_parse_xml): Remove cleanups.
3612         * target-descriptions.h (make_cleanup_free_target_description):
3613         Don't declare.
3614         (target_desc_deleter): New struct.
3615         (target_desc_up): New typedef.
3616         * target-descriptions.c (target_desc_deleter::operator()): Rename
3617         from free_target_description.
3618         (make_cleanup_free_target_description): Remove.
3619
3620 2019-01-02  Tom Tromey  <tom@tromey.com>
3621
3622         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3623         constructor, destructor.
3624         (linespec_parser): Remove typedef.
3625         (~linespec_parser): Rename from linespec_parser_delete.
3626         (linespec_lex_to_end, linespec_complete_label)
3627         (linespec_complete): Update.
3628         (decode_line_full): Remove cleanups.
3629         (decode_line_1): Update.
3630
3631 2019-01-02  Tom Tromey  <tom@tromey.com>
3632
3633         * python/python-internal.h (inferior_to_inferior_object): Change
3634         return type.
3635         * python/py-exitedevent.c (create_exited_event_object): Update.
3636         * python/py-inferior.c (inferior_to_inferior_object): Return
3637         gdbpy_ref.
3638         (python_new_inferior, python_inferior_deleted)
3639         (thread_to_thread_object, delete_thread_object)
3640         (build_inferior_list, gdbpy_selected_inferior): Update.
3641         * python/py-infthread.c (create_thread_object): Update.  Also fail
3642         if inferior_to_inferior_object fails.
3643
3644 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3645
3646         * inferior.h (class inferior) <displaced_step_state>: New field.
3647         * infrun.h (struct displaced_step_state): Move here from
3648         infrun.c.  Initialize fields, add constructor.
3649         <inf>: Remove field.
3650         <reset>: New method.
3651         * infrun.c (struct displaced_step_inferior_state): Move to
3652         infrun.h.
3653         (displaced_step_inferior_states): Remove.
3654         (get_displaced_stepping_state): Adust.
3655         (displaced_step_in_progress_any_inferior): Adjust.
3656         (displaced_step_in_progress_thread): Adjust.
3657         (displaced_step_in_progress): Adjust.
3658         (add_displaced_stepping_state): Remove.
3659         (get_displaced_step_closure_by_addr): Adjust.
3660         (remove_displaced_stepping_state): Remove.
3661         (infrun_inferior_exit): Call displaced_step_state.reset.
3662         (use_displaced_stepping): Don't check for NULL.
3663         (displaced_step_prepare_throw): Call
3664         get_displaced_stepping_state.
3665         (displaced_step_fixup): Don't check for NULL.
3666         (prepare_for_detach): Don't check for NULL.
3667
3668 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3669
3670         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3671          in case of call that did not complete.
3672
3673 2019-01-02  Andrey Utkin  <autkin@undo.io>
3674
3675         * symfile.c (find_separate_debug_file): Fix search of debug files for
3676         remote debuggee.
3677
3678 2019-01-02  Tom Tromey  <tom@tromey.com>
3679
3680         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3681         indentation.
3682         * python/py-frame.c (frapy_older): Remove cast.
3683         (frapy_newer): Likewise.
3684         * python/py-breakpoint.c (local_setattro): Remove cast.
3685         * python/py-arch.c (archpy_name): Remove local variable.
3686         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3687
3688 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3689
3690         * unittests/basic_string_view/element_access/char/empty.cc:
3691         Fix year range in copyright header.
3692
3693 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3694
3695         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3696         Delete.
3697         <operator==>: Update with for removed field.
3698         <hash>: Likewise.
3699         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3700         <isa_features>: ...this.
3701         <abi_features>: New field.
3702         (riscv_isa_flen): Update comment.
3703         (riscv_abi_xlen): New declaration.
3704         (riscv_abi_flen): New declaration.
3705         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3706         isa_features.
3707         (riscv_abi_xlen): New function.
3708         (riscv_isa_flen): Update to get answer from isa_features.
3709         (riscv_abi_flen): New function.
3710         (riscv_has_fp_abi): Update to get answer from abi_features.
3711         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3712         xlen and flen.
3713         (riscv_call_info) <xlen, flen>: Update comment.
3714         (riscv_call_arg_struct): Remove invalid assertions
3715         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3716         is removed.
3717         (riscv_gdbarch_init): Gather isa features and abi features
3718         separately, ensure both match on the gdbarch when reusing an old
3719         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3720         a target with 64-bit float hardware.
3721
3722 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3723
3724         * source.c (search_command_helper): Stop reverse search
3725         when line 1 has been searched.
3726
3727 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3728
3729         * record-full.c (record_full_base_target::close): Rewrite
3730         record_full_core_buf_list free logic.
3731
3732 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3733
3734         * break-catch-syscall.c (print_one_catch_syscall): xfree
3735         the last text.
3736
3737 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3738
3739         * top.c (print_gdb_version): Update Copyright year in version
3740         message.
3741
3742 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3743
3744         Update copyright year range in all GDB files.
3745
3746 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3747
3748         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3749
3750 For older changes see ChangeLog-2018.
3751 \f
3752 Local Variables:
3753 mode: change-log
3754 left-margin: 8
3755 fill-column: 74
3756 version-control: never
3757 coding: utf-8
3758 End:
3759