gdb/ChangeLog

   1 2019-08-06  Tom Tromey  <tom@tromey.com>
   2
   3         * symfile.c (reread_symbols): Use obstack_strdup.
   4         * stabsread.c (read_type): Use obstack_strdup.
   5         * gdb_obstack.h (obstack_strdup): New overload.
   6         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
   7         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
   8         (dwarf2_canonicalize_name): Use obstack_strdup.
   9         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
  10         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
  11         Use obstack_strdup.
  12
  13 2019-08-06  Tom Tromey  <tom@tromey.com>
  14
  15         * gdb_obstack.h (obstack_strdup): Define.
  16         * gdb_obstack.c (obstack_strdup): Don't define.
  17
  18 2019-08-06  Tom Tromey  <tom@tromey.com>
  19
  20         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
  21         obstack_strdup.
  22         * typeprint.c (typedef_hash_table::find_global_typedef): Use
  23         obstack_strdup.
  24         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
  25         * stabsread.c (common_block_start): Use obstack_strdup.
  26         * objfiles.c (set_objfile_main_name, objfile): Use
  27         obstack_strdup.
  28         * namespace.c (add_using_directive): Use obstack_strdup.
  29         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
  30         * jit.c (finalize_symtab): Use obstack_strdup.
  31         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
  32         (guess_partial_die_structure_name, partial_die_info::fixup)
  33         (dwarf2_name): Use obstack_strdup.
  34         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
  35         obstack_strdup.
  36         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
  37         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
  38         obstack_strdup.
  39         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
  40
  41 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  42
  43         * unittests/help-doc-selftests.c: New file.
  44         * Makefile.in: Add the new file.
  45
  46 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  47
  48         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
  49         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
  50         the full first line, except when FOR_VALUE_PREFIX.  In this case,
  51         the trailing '.' is not output, and the first character is uppercased.
  52         (print_help_for_command): Update call to print_doc_line.
  53         (print_doc_of_command): Likewise.
  54         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
  55         * cli/cli-option.c (append_indented_doc): Do not append newline.
  56         (build_help_option): Append newline after first appended_indented_doc
  57         only if a second call is done.
  58         (build_help): Append 2 new lines before each option, except the first
  59         one.
  60         * compile/compile.c (_initialize_compile): Add new lines after
  61         %OPTIONS%, when not at the end of the help.
  62         Change help doc or code
  63         producing the help doc to respect the invariants.
  64         * maint-test-options.c (_initialize_maint_test_options): Likewise.
  65         Also removed the new line after 'Options:', as all other commands
  66         do not put an empty line between 'Options:' and the first option.
  67         * printcmd.c (_initialize_printcmd): Likewise.
  68         * stack.c (_initialize_stack): Likewise.
  69         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
  70         incorrectly telling COMMAND is optional.
  71         * ada-lang.c (_initialize_ada_language): Change help doc or code
  72         producing the help doc to respect the invariants.
  73         * ada-tasks.c (_initialize_ada_tasks): Likewise.
  74         * breakpoint.c (_initialize_breakpoint): Likewise.
  75         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
  76         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
  77         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
  78         * cli/cli-style.c (cli_style_option::add_setshow_commands,
  79         _initialize_cli_style): Likewise.
  80         * corelow.c (core_target_info): Likewise.
  81         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
  82         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
  83         * filesystem.c (_initialize_filesystem): Likewise.
  84         * frame.c (_initialize_frame): Likewise.
  85         * gnu-nat.c (add_task_commands): Likewise.
  86         * infcall.c (_initialize_infcall): Likewise.
  87         * infcmd.c (_initialize_infcmd): Likewise.
  88         * interps.c (_initialize_interpreter): Likewise.
  89         * language.c (_initialize_language): Likewise.
  90         * linux-fork.c (_initialize_linux_fork): Likewise.
  91         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
  92         * maint.c (_initialize_maint_cmds): Likewise.
  93         * memattr.c (_initialize_mem): Likewise.
  94         * printcmd.c (_initialize_printcmd): Likewise.
  95         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
  96         _RegEx): Likewise.
  97         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
  98         * record-btrace.c (_initialize_record_btrace): Likewise.
  99         * record-full.c (_initialize_record_full): Likewise.
 100         * record.c (_initialize_record): Likewise.
 101         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 102         * regcache.c (_initialize_regcache): Likewise.
 103         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 104         _initialize_remote): Likewise.
 105         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 106         * serial.c (_initialize_serial): Likewise.
 107         * skip.c (_initialize_step_skip): Likewise.
 108         * source.c (_initialize_source): Likewise.
 109         * stack.c (_initialize_stack): Likewise.
 110         * symfile.c (_initialize_symfile): Likewise.
 111         * symtab.c (_initialize_symtab): Likewise.
 112         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 113         * top.c (init_main): Likewise.
 114         * tracefile-tfile.c (tfile_target_info): Likewise.
 115         * tracepoint.c (_initialize_tracepoint): Likewise.
 116         * tui/tui-win.c (_initialize_tui_win): Likewise.
 117         * utils.c (add_internal_problem_command): Likewise.
 118         * valprint.c (value_print_option_defs): Likewise.
 119
 120 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 121
 122         PR build/24886
 123         * configure.ac: Drop enable-libmcheck support.
 124         * configure, config.in: Rebuild.
 125         * libmcheck.m4: Remove.
 126         * acinclude.m4: Don't include it.
 127         * Makefile.in: Don't distribute it.
 128         * top.c (print_gdb_configuration): Don't mention it.
 129
 130 2019-08-06  Tom Tromey  <tom@tromey.com>
 131
 132         * utils.c (set_output_style): Sometimes pass stream to
 133         emit_style_escape.
 134         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 135         * record-btrace.c (btrace_insn_history): Update.
 136         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 137         method.
 138         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 139         Update initializers.
 140         <m_uiout>: New field.
 141         <m_di>: Move lower.
 142         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 143         Remove "uiout" parameter.
 144         (dump_insns): Update.
 145         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 146         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 147
 148 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 151         (error_in_psymtab_expansion): Likewise.
 152         (lookup_symbol_via_quick_fns): Likewise.
 153         (basic_lookup_transparent_type_quick): Likewise.
 154         (basic_lookup_transparent_type_1): Likewise.
 155
 156 2019-08-06  Tom Tromey  <tromey@adacore.com>
 157
 158         * source.c (last_source_error): Now bool.
 159         (print_source_lines_base): Make "noprint" bool.  Only open
 160         source file when last_source_visited changes.
 161
 162 2019-08-06  Tom Tromey  <tromey@adacore.com>
 163
 164         * annotate.c (annotate_source_line): Use g_source_cache.
 165         * source-cache.c (source_cache::get_plain_source_lines): Change
 166         parameters.  Populate m_offset_cache.
 167         (source_cache::ensure): New method.
 168         (source_cache::get_line_charpos): New method.
 169         (extract_lines): Move lower.  Change parameters.
 170         (source_cache::get_source_lines): Move lower.
 171         * source-cache.h (class source_cache): Update comment.
 172         <get_line_charpos>: New method.
 173         <get_source_lines>: Update comment.
 174         <clear>: Clear m_offset_cache.
 175         <get_plain_source_lines>: Change parameters.
 176         <ensure>: New method
 177         <m_offset_cache>: New member.
 178         * source.c (forget_cached_source_info_for_objfile): Update.
 179         (info_source_command): Use g_source_cache.
 180         (find_source_lines, open_source_file_with_line_charpos): Remove.
 181         (print_source_lines_base, search_command_helper): Use g_source_cache.
 182         * source.h (open_source_file_with_line_charpos): Don't declare.
 183         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 184         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 185         Use g_source_cache.
 186
 187 2019-08-06  Tom Tromey  <tromey@adacore.com>
 188
 189         * source-cache.c (source_cache::get_plain_source_lines):
 190         Remove "first_line" and "last_line" parameters.
 191         (source_cache::get_source_lines): Cache plain text.
 192         * source-cache.h (class source_cache)
 193         <get_plain_source_lines>: Update.
 194
 195 2019-08-06  Tom Tromey  <tromey@adacore.com>
 196
 197         * source-cache.c (extract_lines): No longer a method.
 198         Changed type of parameter.  Include final newline.
 199         (selftests::extract_lines_test): New function.
 200         (_initialize_source_cache): Likewise.
 201         * source-cache.h (class source_cache)
 202         <extract_lines>: Don't declare.
 203
 204 2019-08-06  Tom Tromey  <tromey@adacore.com>
 205
 206         * breakpoint.c (init_breakpoint_sal): Update.
 207         (breakpoint): Update.
 208         * breakpoint.h (struct breakpoint) <filter>: Now a
 209         unique_xmalloc_ptr.
 210
 211 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 212
 213         * NEWS: Mention dictionary access on blocks.
 214         * python/py-block.c (blpy_getitem): New function.
 215         (block_object_as_mapping): New struct.
 216         (block_object_type): Use new struct for tp_as_mapping field.
 217
 218 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 219
 220         * objfiles.h (objfile): Add a comment describing partial symbols.
 221
 222 2019-08-05  Tom Tromey  <tromey@adacore.com>
 223
 224         * compile/compile.c (_initialize_compile): Use _(), not N_().
 225         * thread.c (_initialize_thread): Use _(), not N_().
 226         * stack.c (_initialize_stack): Use _(), not N_().
 227         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 228
 229 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 230
 231         * dwarf2read.c (struct dw2_symtab_iterator):
 232         <want_specific_block>: Remove.
 233         <block_index>: Change type to gdb::optional.
 234         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 235         change type of BLOCK_INDEX parameter to gdb::optional.
 236         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 237         (dw2_lookup_symbol): Don't pass argument for
 238         WANT_SPECIFIC_BLOCK.
 239         (dw2_expand_symtabs_for_function): Don't pass argument for
 240         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 241         (class dw2_debug_names_iterator)
 242         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 243         parameter, change BLOCK_INDEX type to gdb::optional.
 244         <m_want_specific_block>: Remove.
 245         <m_block_index>: Change type to gdb::optional.
 246         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 247         gdb::optional.  Re-write in function of gdb::optional.
 248         (dw2_debug_names_lookup_symbol): Don't pass argument for
 249         WANT_SPECIFIC_BLOCK.
 250         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 251         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 252         BLOCK_INDEX.
 253
 254 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 255
 256         * NEWS: Mention changes to "info sources" command.
 257
 258 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 259
 260         * symtab.c (filename_partial_match_opts): New struct type.
 261         (struct output_source_filename_data): New members
 262         regexp, c_regexp, partial_match.
 263         (output_source_filename): Use new members to decide to print file.
 264         (info_sources_option_defs): New variable.
 265         (make_info_sources_options_def_group, print_info_sources_header,
 266         info_sources_command_completer):
 267         New functions.
 268         (info_sources_command): Read new optional arguments.
 269         (_initialize_symtab): Update info sources help.
 270
 271 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 272
 273         * ada-lang.c (exception_support_info_v0): Renamed from...
 274         (default_exception_support_info): ... this.  Create new
 275         definition for v1.
 276         (ada_has_this_exception_support): Look up catch_handlers_sym.
 277         (ada_exception_support_info_sniffer): Try v0 after default.
 278
 279 2019-08-01  Tom Tromey  <tromey@adacore.com>
 280
 281         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 282         gdbarch.h.
 283
 284 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 285
 286         * s12z-tdep.c: Fix include path for s12z-opc.h.
 287
 288 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 289
 290         * NEWS: Require GNU make 3.82.
 291
 292 2019-07-16  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 295         declare.
 296
 297 2019-07-30  Tom Tromey  <tromey@adacore.com>
 298
 299         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 300
 301 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 302
 303         * printcmd.c (print_address_symbolic): Print negative offsets.
 304         (build_address_symbolic): Force signed arithmetic when computing
 305         offset.
 306
 307 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 308
 309         PR/24474: Add a function to lookup static variables.
 310         * NEWS: Mention this new function.
 311         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 312         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 313         * python/python.c (python_GdbMethods): Add new function.
 314
 315 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 316
 317         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 318         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 319         (objfpy_lookup_static_symbol): New function.
 320         (objfile_object_methods): Add new functions.
 321
 322 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 323
 324         * NEWS: Mention 'set|show print frame-info'.  Mention new
 325         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 326         backtrace argument.  Mention that python frame filtering code
 327         is now consistent with what 'backtrace' command prints.
 328
 329 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 330
 331         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 332         comments.
 333         (print_frame_info_auto, print_frame_info_source_line,
 334         print_frame_info_location, print_frame_info_source_and_location,
 335         print_frame_info_location_and_address, print_frame_info_short_location):
 336         New declarations.
 337         (struct frame_print_options): New member print_frame_info.
 338         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 339         * stack.h (get_user_print_what_frame_info): New declaration.
 340         (frame_show_address): New declaration.
 341         * stack.c (print_frame_arguments_choices): New value 'presence'.
 342         (print_frame_info_auto, print_frame_info_source_line,
 343         print_frame_info_location, print_frame_info_source_and_location,
 344         print_frame_info_location_and_address, print_frame_info_short_location,
 345         print_frame_info_choices, print_frame_info_print_what): New definitions.
 346         (print_frame_args): Only print dots for args if print frame-arguments
 347         is 'presence'.
 348         (frame_print_option_defs): New element for "frame-info".
 349         (get_user_print_what_frame_info): New function.
 350         (frame_show_address): Make non static.  Move comment to stack.h.
 351         (print_frame_info_to_print_what): New function.
 352         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 353         to decide what to print.
 354         (backtrace_command_1): Handle the new print_frame_arguments_presence
 355         value.
 356         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 357         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 358         (py_print_frame): In non-mi mode, use LOCATION as default for
 359         print_what, similarly to frame information printed directly by
 360         backtrace command. Handle frame-info user option in non MI mode.
 361
 362 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 363
 364         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 365         Add case for debugging 32-bit target on 64-bit host.  Revise
 366         comment.
 367
 368 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 369
 370         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 371         instead of find_function_entry_range_from_pc.
 372
 373 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 374
 375         * stack.c (find_frame_funname): Remove code which preferred
 376         minsym over symtab sym in "certain pathological cases".
 377
 378         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 379         parameter.  Change type of "do_demangle" to bool.
 380         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 381         Pass suitable "prefer_sym_over_minsym" flag to
 382         build_address_symbolic().  Don't output "+" for negative offsets.
 383         * printcmd.c (print_address_symbolic): Update invocation of
 384         build_address_symbolic to include a "prefer_sym_over_minsym"
 385         flag.
 386         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 387         Restrict cases in which use of minimal symbol is preferred to that
 388         of a found symbol.  Update comments.
 389
 390         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 391         for entry pc when entry pc is out of range for that FDE.
 392
 393 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 394
 395         PR gdb/24839:
 396         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 397         type.
 398
 399 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 400
 401         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 402         this function's Python signature.
 403
 404
 405 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 406
 407         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 408         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 409         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 410         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 411         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 412
 413
 414 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 415
 416         * h8300-tdep.c (h8300_register_name_common): New.
 417         h8300_register_name): Use h8300_register_name_common.
 418         (h8300s_register_name): Likewise.
 419         (h8300sx_register_name): Likewise.
 420         (h8300h_register_nam): New.
 421         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 422
 423
 424 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 425
 426         * arm-tdep.c (arm_skip_cmse_entry): New function.
 427         (arm_is_sgstubs_section): New function.
 428         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 429
 430 2019-07-22  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 433         Don't self-assign.
 434
 435 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 438         type_print.
 439
 440 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 441
 442         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 443         so that GDB doesn't match any msymbols when searching in the
 444         TYPES_DOMAIN.
 445         (print_symbol_info): Print using typedef_print or type_print based
 446         on the type of the symbol.  Add updated FIXME comment moved from...
 447         (_initialize_symtab): ... move and update FIXME comment to above.
 448
 449 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 450
 451         * NEWS: Mention adding -q option to "info types".
 452         * symtab.c (struct info_types_options): New struct.
 453         (info_types_options_defs): New variable.
 454         (make_info_types_options_def_group): New function.
 455         (info_types_command): Use gdb::option framework to parse options.
 456         (info_types_command_completer): New function.
 457         (_initialize_symtab): Extend the help text on "info types" and
 458         register command completer.
 459
 460 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 461
 462         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 463         (lookup_symbol_in_objfile): Change int to block_enum and add a
 464         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 465
 466 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 467
 468         * MAINTAINERS (Write After Approval): Add self.
 469
 470 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 473         instruction to the dummy code region.
 474
 475 2019-07-19  Tom Tromey  <tromey@adacore.com>
 476
 477         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 478         (ARGSUSED, PARAMS, __func__): Remove rules.
 479
 480 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 481
 482         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 483         * features/arm/arm-with-iwmmxt.c: Remove.
 484         * features/arm/arm-with-iwmmxt.xml: Remove.
 485         * features/arm/arm-with-m-fpa-layout.c: Remove.
 486         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 487         * features/arm/arm-with-m-vfp-d16.c: Remove.
 488         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 489         * features/arm/arm-with-m.c: Remove.
 490         * features/arm/arm-with-m.xml: Remove.
 491         * features/arm/arm-with-neon.c: Remove.
 492         * features/arm/arm-with-neon.xml: Remove.
 493         * features/arm/arm-with-vfpv2.c: Remove.
 494         * features/arm/arm-with-vfpv2.xml: Remove.
 495         * features/arm/arm-with-vfpv3.c: Remove.
 496         * features/arm/arm-with-vfpv3.xml: Remove.
 497
 498 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 499
 500         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 501
 502 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 503
 504         * arch/aarch32.c (aarch32_create_target_description): Create
 505         target descriptions using features.
 506         * arch/arm.c (arm_create_target_description)
 507         (arm_create_mprofile_target_description): Likewise.
 508         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 509
 510 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 511
 512         * Makefile.in: Add new files.
 513         * aarch32-tdep.c: New file.
 514         * aarch32-tdep.h: New file.
 515         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 516         Call aarch32_read_description.
 517         * arch/aarch32.c: New file.
 518         * arch/aarch32.h: New file.
 519         * arch/arm.c (arm_create_target_description)
 520         (arm_create_mprofile_target_description): New function.
 521         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 522         (arm_create_target_description)
 523         (arm_create_mprofile_target_description): New declaration.
 524         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 525         read_description functions.
 526         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 527         Likewise.
 528         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 529         * arm-tdep.c (tdesc_arm_list): New variable.
 530         (arm_register_g_packet_guesses): Call create description functions.
 531         (arm_read_description) (arm_read_mprofile_description): New
 532         function.
 533         * arm-tdep.h (arm_read_description)
 534         (arm_read_mprofile_description): Add declaration.
 535         * configure.tgt: Add new files.
 536
 537 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 538
 539         * top.c (new_ui_command): Open specified terminal just once.
 540
 541 2019-07-18  Tom Tromey  <tromey@adacore.com>
 542
 543         * symtab.c (main_name): Constify return type.
 544         * symfile.c (set_initial_language): Update.
 545         * symtab.h (main_name): Constify return type.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-winsource.c (tui_update_source_window)
 550         (tui_update_source_window_as_is)
 551         (tui_update_source_windows_with_line): Remove return.
 552         * tui/tui-disasm.c (tui_show_disassem)
 553         (tui_show_disassem_and_update_source): Remove return.
 554         * tui/tui.c (tui_reset): Remove return.
 555         * tui/tui-wingeneral.c
 556         (tui_check_and_display_highlight_if_needed): Remove return.
 557
 558 2019-07-17  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 561
 562 2019-07-17  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-winsource.h (struct tui_exec_info_window)
 565         (struct tui_source_window_base): Move from tui-data.h.
 566         * tui/tui-winsource.c: Move many method definitions from
 567         elsewhere.  Remove "structuring" comments.
 568         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 569         (tui_source_window_base::refresh_window): Move to
 570         tui-winsource.c.
 571         * tui/tui-win.c (tui_source_window_base::refresh_all)
 572         (tui_source_window_base::update_tab_width)
 573         (tui_source_window_base::set_new_height)
 574         (tui_source_window_base::do_make_visible_with_new_height): Move to
 575         tui-winsource.c.
 576         * tui/tui-source.h: Update.
 577         * tui/tui-source.c (tui_source_window_base::reset): Move to
 578         tui-winsource.c.
 579         * tui/tui-disasm.h: Update.
 580         * tui/tui-data.h (struct tui_exec_info_window): Move to
 581         tui-winsource.h.
 582         (struct tui_source_window_base): Likewise.
 583         * tui/tui-data.c (tui_source_window_base::clear_detail)
 584         (tui_source_window_base, ~tui_source_window_base): Move to
 585         tui-winsource.c.
 586
 587 2019-07-17  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-win.c (tui_resize_all)
 590         (tui_source_window_base::update_tab_width)
 591         (tui_adjust_win_heights): Update.
 592         (tui_win_info::make_invisible_and_set_new_height): Rename from
 593         make_invisible_and_set_new_height.
 594         * tui/tui-data.h (struct tui_win_info)
 595         <make_invisible_and_set_new_height>: New method.
 596
 597 2019-07-17  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui.c: Update.
 600         * tui/tui-source.h (struct tui_source_window): Move from
 601         tui-data.h.
 602         * tui/tui-layout.c: Update.
 603         * tui/tui-disasm.c: Update.
 604         * tui/tui-data.h (struct tui_source_window): Move to
 605         tui-source.h.
 606
 607 2019-07-17  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 610         tui-data.h.
 611         * tui/tui-data.h (struct tui_disasm_window): Move to
 612         tui-disasm.h.
 613
 614 2019-07-17  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-regs.h (struct tui_data_item_window): Move from
 617         tui-data.h.
 618         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 619         * tui/tui-data.h (struct tui_data_item_window): Move to
 620         tui-regs.h.
 621         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 622
 623 2019-07-17  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui.c: Update.
 626         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 627         (tui_cmd_window::max_height): Move to tui-command.c.
 628         * tui/tui-layout.c: Update.
 629         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 630         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 631         tui-command.c.
 632         * tui/tui-command.h (struct tui_cmd_window): Move from
 633         tui-data.h.
 634         * tui/tui-command.c: Remove "structuring" comments.
 635         (tui_cmd_window::clear_detail)
 636         (tui_cmd_window::do_make_visible_with_new_height)
 637         (tui_cmd_window::max_height): Move from elsewhere.
 638
 639 2019-07-17  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 642         Now static.
 643         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 644         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 645
 646 2019-07-17  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui.c: Update.
 649         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 650         tui-regs.c.
 651         * tui/tui-windata.h: Remove file.
 652         * tui/tui-windata.c: Remove file.
 653         * tui/tui-win.c (tui_data_window::set_new_height)
 654         (tui_data_window::do_make_visible_with_new_height): Move to
 655         tui-regs.c.
 656         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 657         * tui/tui-regs.c: Remove "structuring" comments.
 658         (tui_data_window::first_data_item_displayed)
 659         (tui_data_window::delete_data_content_windows)
 660         (tui_data_window::erase_data_content)
 661         (tui_data_window::display_all_data)
 662         (tui_data_window::refresh_all)
 663         (tui_data_window::do_scroll_vertical)
 664         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 665         (tui_data_window::do_make_visible_with_new_height)
 666         (tui_data_window::refresh_window): Move from elsewhere.
 667         (_initialize_tui_regs): Move to end of file.
 668         * tui/tui-layout.c: Update.
 669         * tui/tui-hooks.c: Update.
 670         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 671         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 672         tui-regs.c.
 673         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 674
 675 2019-07-17  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 678         seen.
 679
 680 2019-07-17  Tom Tromey  <tom@tromey.com>
 681
 682         * tui/tui-win.c (tui_source_window_base::set_new_height)
 683         (tui_source_window_base::do_make_visible_with_new_height): Use
 684         m_has_locator field directly.
 685         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 686         method.
 687         (struct tui_source_window_base) <has_locator>: Likewise.
 688
 689 2019-07-17  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 692         Don't declare.
 693         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 694         Remove.
 695         * tui/tui-win.c (tui_source_window_base::set_new_height)
 696         (tui_source_window_base::set_new_height)
 697         (make_invisible_and_set_new_height)
 698         (tui_source_window_base::do_make_visible_with_new_height)
 699         (tui_source_window_base::do_make_visible_with_new_height):
 700         Update.
 701         * tui/tui-layout.c (show_source_disasm_command, show_data)
 702         (show_source_or_disasm_and_command): Update.
 703         * tui/tui-layout.c (show_layout): Update.
 704
 705 2019-07-17  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-layout.c (make_data_window): Remove.
 708         (show_data): Unify creation and re-initialization cases.
 709
 710 2019-07-17  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui-layout.c (make_source_window, make_disasm_window):
 713         Remove.
 714         (show_data): Unify creation and re-initialization cases.
 715
 716 2019-07-17  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-layout.c (make_command_window): Remove.
 719         (show_source_disasm_command, show_source_or_disasm_and_command):
 720         Unify creation and re-initialization cases.
 721
 722 2019-07-17  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 725         creation and re-initialization cases.
 726
 727 2019-07-17  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-regs.c (tui_get_register): Return void.
 730
 731 2019-07-17  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 734         Simplify.
 735
 736 2019-07-17  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 739         resetting.
 740
 741 2019-07-17  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 744         * tui/tui-regs.c (tui_reg_layout): New function.
 745         (tui_show_registers, tui_reg_command): Use it.
 746         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 747         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 748         parameters.
 749         (tui_layout_command): Remove.
 750
 751 2019-07-17  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-layout.h (tui/tui-layout): Return void.
 754         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 755
 756 2019-07-17  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-layout.c (show_source_disasm_command, show_data):
 759         Update.
 760         (reset_locator): Remove.
 761         (show_source_or_disasm_and_command): Update.
 762
 763 2019-07-17  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-source.c (tui_source_window_base::reset): Remove
 766         win_type parameter.
 767         * tui/tui-layout.c (make_command_window, make_source_window)
 768         (make_disasm_window, make_data_window)
 769         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 770         (reset_locator, show_source_or_disasm_and_command): Update.
 771         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 772         win_type parameter.
 773         (struct tui_source_window_base) <reset>: Likewise.
 774
 775 2019-07-17  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-layout.c (show_source_disasm_command): Use
 778         reset_locator.
 779         (reset_locator): New function.
 780         (init_and_make_win): Remove.
 781         (show_source_or_disasm_and_command): Use reset_locator.
 782
 783 2019-07-17  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 786         condition.
 787         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 788         Remove condition.
 789         * tui/tui-source.c (tui_source_window_base::reset): New method.
 790         * tui/tui-layout.c (make_command_window): Don't call
 791         init_and_make_win.
 792         (make_source_window, make_disasm_window): Don't call
 793         make_source_or_disasm_window.
 794         (make_data_window): Don't call init_and_make_win.  Change calling
 795         convention.
 796         (show_source_disasm_command, show_data): Simplify.
 797         (make_source_or_disasm_window): Remove.
 798         (show_source_or_disasm_and_command): Simplify.
 799         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 800         (struct tui_source_window_base) <reset>: Likewise.
 801         <execution_info>: Remove initializer.
 802         * tui/tui-data.c (tui_source_window_base): Initialize
 803         execution_info.
 804
 805 2019-07-17  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 808         variable.
 809
 810 2019-07-17  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui.c (tui_rl_other_window): Update.
 813         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 814         superclass method first.  Always iterate over regs_content.
 815         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 816         method.
 817         * tui/tui-win.c (tui_set_focus_command): Update.
 818
 819 2019-07-17  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-win.c (tui_set_focus_command): Rename from
 822         tui_set_focus.  Call tui_enable.
 823         (tui_set_focus_command): Remove.
 824
 825 2019-07-17  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 828         refresh_window.
 829         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 830         touchwin.
 831         (tui_data_window::refresh_window): Call refresh_window on data
 832         items.  Always call superclass refresh_window.
 833         (tui_win_info::refresh): Remove.
 834         (tui_source_window_base::refresh_window): Update.
 835         (tui_refresh_all): Update.
 836         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 837         refresh_window.
 838         (show_source_or_disasm_and_command): Likewise.
 839         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 840         (struct tui_source_window_base) <refresh>: Likewise.
 841
 842 2019-07-17  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-winsource.c (tui_clear_source_content)
 845         (tui_show_source_content): Update.
 846         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 847         whether content is empty.
 848         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 849         Remove.
 850
 851 2019-07-17  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 854         window's contents.
 855         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 856         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 857
 858 2019-07-17  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 861         (struct tui_data_item_window): Update.
 862
 863 2019-07-17  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 866         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 867         defines.
 868
 869 2019-07-17  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-winsource.h (tui_erase_source_content)
 872         (tui_clear_source_content): Remove "display_prompt" parameter.
 873         * tui/tui-winsource.c (tui_update_source_window_as_is)
 874         (tui_update_source_windows_with_addr): Update.
 875         (tui_clear_source_content): Remove "display_prompt" parameter.
 876         (tui_erase_source_content): Likewise.  Simplify.
 877         (tui_show_source_content): Update.
 878         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 879         * tui/tui-stack.c (tui_show_frame_info): Update.
 880         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 881         Remove defines.
 882
 883 2019-07-17  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 886         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 887         parameter.
 888         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 889         parameter.
 890
 891 2019-07-17  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-winsource.c (tui_clear_source_content)
 894         (tui_show_source_content, tui_show_exec_info_content)
 895         (tui_clear_exec_info_content): Update.
 896         * tui/tui-stack.c (tui_show_locator_content): Update.
 897         (tui_show_frame_info): Update.
 898         * tui/tui-source.h (tui_source_window): Don't declare.
 899         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 900         from tui_source_is_displayed.
 901         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 902         Remove field.
 903         (struct tui_source_window_base) <content_in_use>: New field.  Now
 904         bool.
 905         (struct tui_source_window) <showing_source_p>: New method.
 906         (TUI_SRC_WIN): Change cast.
 907         * tui/tui-data.c (tui_initialize_static_data): Update.
 908
 909 2019-07-17  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 912         location_matches_p.
 913         * tui/tui-source.c (tui_source_window::location_matches_p): New
 914         method.
 915         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 916         method.
 917         * tui/tui-data.h (struct tui_source_window_base)
 918         <location_matches_p>: New method.
 919         (struct tui_source_window, struct tui_disasm_window)
 920         <location_matches_p>: Likewise.
 921
 922 2019-07-17  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-win.c (tui_set_win_height_command): Rename from
 925         tui_set_win_height.
 926         (tui_set_win_height_command): Remove.
 927
 928 2019-07-17  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-source.c (tui_source_window): New constructor.  Add
 931         observer.
 932         (~tui_source_window): New destructor.
 933         (tui_source_window::style_changed): New method.
 934         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 935         (tui_attach_detach_observers): Update.
 936         * tui/tui-data.h (struct tui_source_window): Make constructor not
 937         inline.  Add destructor.
 938         (struct tui_source_window) <style_changed>: New method.
 939         <m_observable>: New member.
 940
 941 2019-07-17  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 944         * tui/tui-win.c (tui_resize_all): Fix typo.
 945
 946 2019-07-17  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 949         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 950         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 951         * tui/tui-win.c (window_name_completer): Use foreach.
 952         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 953         (update_tab_width): Likewise.
 954         * tui/tui-layout.c (show_layout): Update.
 955         * tui/tui-data.h (class tui_window_iterator): New.
 956         (struct all_tui_windows): New.
 957         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 958
 959 2019-07-17  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 962         parameter.  Don't reference globals.
 963         (tui_reg_command): Update.
 964
 965 2019-07-17  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-regs.c (tui_show_registers): Simplify.
 968
 969 2019-07-17  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-regs.c (tui_show_registers): Update.
 972         (tui_show_register_group): Add win_info parameter.
 973
 974 2019-07-17  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 977         Rename from tui_display_reg_element_at_line.
 978         (tui_data_window::display_registers_from_line): Update.
 979         * tui/tui-data.h (struct tui_data_window)
 980         <display_reg_element_at_line>: New method.
 981
 982 2019-07-17  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-regs.h (tui_display_registers_from)
 985         (tui_display_registers_from_line): Don't declare.
 986         * tui/tui-windata.c (tui_data_window::display_all_data)
 987         (tui_data_window::refresh_all)
 988         (tui_data_window::do_scroll_vertical): Update.
 989         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 990         from tui_display_registers_from.
 991         (tui_display_reg_element_at_line): Update.
 992         (tui_data_window::display_registers_from_line): Rename from
 993         tui_display_registers_from_line.
 994         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 995         display_registers_from_line>: New methods.
 996
 997 2019-07-17  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1000         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1001         from tui_erase_data_content.
1002         (tui_data_window::display_all_data)
1003         (tui_data_window::refresh_all)
1004         (tui_data_window::do_scroll_vertical): Update.
1005         * tui/tui-regs.c (tui_show_registers): Update.
1006         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1007         New method.
1008
1009 2019-07-17  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1012         declare.
1013         * tui/tui-windata.c
1014         (tui_data_window::delete_data_content_windows): Rename from
1015         tui_delete_data_content_windows.
1016         (tui_data_window::display_all_data)
1017         (tui_data_window::do_scroll_vertical): Update.
1018         * tui/tui-data.h (struct tui_data_window)
1019         <delete_data_content_windows>: New method.
1020
1021 2019-07-17  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1024         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1025
1026 2019-07-17  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1029         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1030         from tui_display_all_data.
1031         * tui/tui-win.c
1032         (tui_data_window::do_make_visible_with_new_height): Update.
1033         * tui/tui-regs.c (tui_show_registers): Update.
1034         * tui/tui-layout.c (tui_set_layout): Update.
1035         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1036         method.
1037
1038 2019-07-17  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1041         * tui/tui-windata.c (tui_display_data_from): Remove.
1042         (tui_data_window::refresh_all): Update.
1043
1044 2019-07-17  Tom Tromey  <tom@tromey.com>
1045
1046         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1047         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1048         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1049         tui_display_registers_from_line.
1050         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1051         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1052         "force_display" parameter.
1053
1054 2019-07-17  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1057         declare.
1058         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1059         Rename from tui_first_reg_element_no_inline.
1060         (tui_display_reg_element_at_line)
1061         (tui_display_registers_from_line): Update.
1062         * tui/tui-data.h (struct tui_data_window)
1063         <first_reg_element_no_inline>: New method.
1064
1065 2019-07-17  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-windata.c (tui_display_data_from)
1068         (tui_data_window::do_scroll_vertical): Update.
1069         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1070         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1071         Rename from tui_line_from_reg_element_no.
1072         (tui_display_registers_from_line): Update.
1073         * tui/tui-data.h (struct tui_data_window)
1074         <line_from_reg_element_no>: New method.
1075
1076 2019-07-17  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1079         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1080         tui_last_regs_line_no.
1081         (tui_display_reg_element_at_line)
1082         (tui_display_registers_from_line): Update.
1083         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1084         method.
1085
1086 2019-07-17  Tom Tromey  <tom@tromey.com>
1087
1088         PR tui/24722:
1089         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1090         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1091         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1092         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1093         (tui_update_breakpoint_info): Likewise.
1094         * tui/tui-hooks.c (tui_event_create_breakpoint)
1095         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1096         Update.
1097
1098 2019-07-17  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1101
1102 2019-07-17  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-winsource.c (tui_update_source_window_as_is)
1105         (tui_update_source_windows_with_addr): Update.
1106         * tui/tui-source.h (tui_set_source_content)
1107         (tui_show_symtab_source): Add "win_info" parameter.
1108         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1109         parameter.
1110         (tui_show_symtab_source): Likewise.
1111
1112 2019-07-17  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-wingeneral.c
1115         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1116
1117 2019-07-17  Tom Tromey  <tom@tromey.com>
1118
1119         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1120         (struct tui_cmd_window) <can_scroll>: New method.
1121         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1122         method.
1123
1124 2019-07-17  Tom Tromey  <tromey@adacore.com>
1125
1126         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1127         do_field_signed>: Rename.  Change type of "value".
1128         * ui-out.c (ui_out::field_signed): Rename from field_int.
1129         Change type of "value".
1130         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1131         type of "value".
1132         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1133         do_field_int.  Change type of "value".
1134         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1135         do_field_int.  Change type of "value".
1136         * tracepoint.c (trace_status_mi, tfind_1)
1137         (print_one_static_tracepoint_marker): Update.
1138         * thread.c (print_thread_info_1, print_selected_thread_frame):
1139         Update.
1140         * stack.c (print_frame, print_frame_info): Update.
1141         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1142         Update.
1143         * source.c (print_source_lines_base): Update.
1144         * skip.c (info_skip_command): Update.
1145         * record-btrace.c (btrace_ui_out_decode_error)
1146         (btrace_call_history_src_line): Update.
1147         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1148         Update.
1149         * progspace.c (print_program_space): Update.
1150         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1151         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1152         do_field_int.  Change type of "value".
1153         * mi/mi-out.c (mi_ui_out::do_table_begin)
1154         (mi_ui_out::do_table_header): Update.
1155         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1156         type of "value".
1157         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1158         (mi_cmd_data_list_changed_registers, output_register)
1159         (mi_cmd_data_read_memory, mi_load_progress)
1160         (mi_cmd_trace_frame_collected): Update.
1161         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1162         Update.
1163         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1164         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1165         (mi_cmd_var_list_children, varobj_update_one): Update.
1166         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1167         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1168         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1169         * inferior.c (print_inferior): Update.
1170         * gdb_bfd.c (print_one_bfd): Update.
1171         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1172         Update.
1173         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1174         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1175         do_field_int.  Change type of "value".
1176         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1177         do_field_int.  Change type of "value".
1178         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1179         (print_one_breakpoint_location, print_it_catch_fork)
1180         (print_one_catch_fork, print_it_catch_vfork)
1181         (print_one_catch_vfork, print_it_catch_solib)
1182         (print_it_catch_exec, print_it_ranged_breakpoint)
1183         (print_mention_watchpoint, print_mention_masked_watchpoint)
1184         (bkpt_print_it, update_static_tracepoint): Update.
1185         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1186         * break-catch-syscall.c (print_it_catch_syscall): Update.
1187         * ada-tasks.c (print_ada_task_info): Update.
1188         * ada-lang.c (print_it_exception, print_mention_exception):
1189         Update.
1190
1191 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         PR breakpoints/24541
1194         * gdbarch.c: Regenerate.
1195         * gdbarch.h: Regenerate.
1196         * gdbarch.sh: Adjust return type and parameter types for
1197         'stap_adjust_register'.
1198         (i386_stap_adjust_register): Adjust signature and return new
1199         register name.
1200         * stap-probe.c (stap_parse_register_operand): Adjust use of
1201         'gdbarch_stap_adjust_register'.
1202
1203 2019-07-17  Tom Tromey  <tromey@adacore.com>
1204
1205         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1206         declare VEC.
1207         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1208         std::vector.
1209         (struct s390_process_info): Add initializers.
1210         (s390_add_process): Use new.
1211         (s390_linux_nat_target::low_forget_process): Use delete.
1212         (s390_linux_nat_target::low_new_fork)
1213         (s390_linux_nat_target::stopped_by_watchpoint)
1214         (s390_linux_nat_target::low_prepare_to_resume)
1215         (s390_linux_nat_target::insert_watchpoint)
1216         (s390_linux_nat_target::insert_hw_breakpoint)
1217         (s390_linux_nat_target::remove_watchpoint)
1218         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1219
1220 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1221
1222         * aarch64-fbsd-nat.c: Include regcache.h.
1223         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1224         argument.
1225         (aarch64_fbsd_nat_target::fetch_registers)
1226         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1227         variable.
1228         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1229
1230 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1231
1232         * fbsd-nat.c: Include gdbarch.h.
1233
1234 2019-07-15  Tom Tromey  <tromey@adacore.com>
1235
1236         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1237
1238 2019-07-15  Tom Tromey  <tromey@adacore.com>
1239
1240         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1241         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1242         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1243         * cli-out.c (cli_ui_out::do_field_int): New method.
1244         * ui-out.c (ui_out::field_unsigned): New method.
1245         * symfile.c (generic_load): Use field_unsigned.
1246         (print_transfer_performance): Likewise.
1247         * record-btrace.c (ui_out_field_uint): Remove.
1248         (btrace_call_history_insn_range, btrace_call_history): Use
1249         field_unsigned.
1250         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1251         field_unsigned.
1252         * ui-out.h (class ui_out) <field_unsigned>: New method.
1253         <do_field_unsigned>: Likewise.
1254
1255 2019-07-15  Tom Tromey  <tromey@adacore.com>
1256
1257         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1258         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1259         * target.c (flash_erase_command): Use field_string.
1260         * infrun.c (print_signal_received_reason): Use field_string.
1261         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1262         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1263         field_string.
1264         * ada-tasks.c (print_ada_task_info): Use field_string.
1265
1266 2019-07-15  Tom Tromey  <tromey@adacore.com>
1267
1268         * target.c (flash_erase_command): Use field_core_addr.
1269         * symfile.c (generic_load): Use field_core_addr.
1270         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1271         Use field_core_addr.
1272         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1273         field_core_addr.
1274
1275 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1278         value if its desired type is smaller than a CORE_ADDR and signed.
1279
1280 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1281
1282         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1283         of changes to field names, and use new is_reference field to
1284         decide if a property is a reference or not.
1285         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1286         field.
1287         (struct dwarf2_property_baton): Update header comment, rename
1288         'referenced_type' to 'property_type' and update comments.
1289         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1290         default property type, store in property baton, update to take
1291         accound of renamed field.
1292         (read_func_scope): Update call to attr_to_dynamic_prop.
1293         (read_array_type): Likewise.
1294         (dwarf2_per_cu_addr_sized_int_type): New function.
1295         (read_subrange_index_type): Move type finding code to
1296         dwarf2_per_cu_addr_sized_int_type.
1297         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1298         (dwarf2_per_cu_addr_type): New function.
1299         (set_die_type): Update calls to attr_to_dynamic_prop.
1300
1301 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * dwarf2read.c (read_subrange_index_type): New function.
1304         (read_subrange_type): Move code into new function and call it.
1305         * gdbtypes.c (create_range_type): Add some asserts.
1306
1307 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1310         update return statements.
1311         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1312         declaration, and update comment to match.
1313         * gdbtypes.c (resolve_dynamic_array): Update call to
1314         dwarf2_evaluate_property to match new return type.
1315
1316 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1317
1318         * valarith.c (value_subscripted_rvalue): Change lowerbound
1319         parameter type from int to LONGEST.
1320         * value.h (value_subscripted_rvalue): Likewise in declaration.
1321
1322 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * cli/cli-utils.c (info_print_command_completer): New function.
1325         * cli/cli-utils.h: Add 'completer.h' include, and forward
1326         declaration for 'struct cmd_list_element'.
1327         (info_print_command_completer): Declare.
1328         * stack.c (_initialize_stack): Add completer for 'info locals' and
1329         'info args'.
1330         * symtab.c (_initialize_symtab): Add completer for 'info
1331         variables' and 'info functions'.
1332         * NEWS: Mention completion for additional info commands.
1333
1334 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * cli/cli-utils.c (extract_info_print_args): Delete.
1337         (extract_arg_maybe_quoted): Delete.
1338         (info_print_options_defs): New variable.
1339         (make_info_print_options_def_group): New function.
1340         (extract_info_print_options): Define new function.
1341         * cli/cli-utils.h (extract_info_print_args): Delete.
1342         (struct info_print_options): New structure.
1343         (extract_info_print_options): Declare new function.
1344         * stack.c (info_locals_command): Update to use new
1345         extract_info_print_options, also add a header comment.
1346         (info_args_command): Likewise.
1347         * symtab.c (info_variables_command): Likewise.
1348         (info_functions_command): Likewise.
1349
1350 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1353         to extract string arguments.
1354         * common/common-utils.c (extract_string_maybe_quoted): New function.
1355         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1356
1357 2019-07-11  Tom Tromey  <tromey@adacore.com>
1358
1359         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1360         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1361         * top.h (gdbinit): Don't declare.
1362         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1363         into...
1364         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1365         * top.c (gdb_init): Don't call init_cli_cmds.
1366         (gdbinit): Remove.
1367         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1368
1369 2019-07-11  Tom Tromey  <tromey@adacore.com>
1370
1371         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1372         after it has been moved.
1373
1374 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1375
1376         * valops.c (value_must_coerce_to_target): Change return type to
1377         bool.
1378         * value.h (value_must_coerce_to_target): Likewise.
1379
1380 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1381
1382         * breakpoint.c (is_hardware_watchpoint): Remove
1383         forward-declaration.
1384         (is_masked_watchpoint): Change return type to bool.
1385         (is_tracepoint): Likewise.
1386         (is_breakpoint): Likewise.
1387         (is_hardware_watchpoint): Likewise.
1388         (is_watchpoint): Likewise.
1389         (is_no_memory_software_watchpoint): Likewise.
1390         (is_catchpoint): Likewise.
1391         (breakpoint_1): Make FILTER parameter's return type bool.
1392         is_masked_watchpoint): Change return type to bool.
1393         (save_breakpoints): Make FILTER parameter's return type bool.
1394         * breakpoint.h (is_breakpoint): Change return type to bool.
1395         (is_watchpoint): Likewise.
1396         (is_catchpoint): Likewise.
1397         (is_tracepoint): Likewise.
1398
1399 2019-07-10  Tom Tromey  <tom@tromey.com>
1400
1401         * defs.h: Don't include gdbarch.h.
1402         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1403         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1404         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1405         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1406         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1407         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1408         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1409         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1410         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1411         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1412         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1413         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1414         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1415         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1416         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1417         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1418         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1419         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1420         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1421         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1422         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1423         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1424         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1425         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1426         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1427         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1428         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1429
1430 2019-07-10  Tom Tromey  <tromey@adacore.com>
1431
1432         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1433         * breakpoint.c (init_ada_exception_breakpoint): Register as
1434         bp_catchpoint.
1435         (print_one_breakpoint_location, print_one_breakpoint): Use
1436         is_ada_exception_catchpoint.
1437         * ada-lang.c (class ada_catchpoint_location): Pass
1438         bp_loc_software_breakpoint to bp_location constructor.
1439         (is_ada_exception_catchpoint): New function.
1440
1441 2019-07-10  Tom Tromey  <tromey@adacore.com>
1442
1443         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1444         VEC.
1445         (struct arm_exidx_entry): New method operator<.
1446         (struct arm_exidx_data) <section_maps>: Change type.
1447         (arm_exidx_data_free): Remove.
1448         (arm_exidx_data_key): Change type.  Move lower.
1449         (arm_exidx_new_objfile): Update.
1450         (arm_compare_exidx_entries): Remove.
1451         (arm_find_exidx_entry, _initialize_arm_tdep)
1452
1453 2019-07-10  Tom Tromey  <tromey@adacore.com>
1454
1455         * solib-spu.c (ocl_program_data_key): Change type.
1456         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1457         Update.
1458
1459 2019-07-10  Tom Tromey  <tromey@adacore.com>
1460
1461         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1462         (struct solib_aix_inferior_data) <library_list>: Change type.
1463         (solib_aix_inferior_data_handle): Change type.
1464         (get_solib_aix_inferior_data): Update.
1465         (solib_aix_free_library_list): Remove.
1466         (library_list_start_library): Update.
1467         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1468         return type.
1469         (solib_aix_get_library_list)
1470         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1471         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1472
1473 2019-07-10  Tom Tromey  <tromey@adacore.com>
1474
1475         * solib-dsbt.c (struct dsbt_info): Add initializers.
1476         (solib_dsbt_pspace_data): Change type.
1477         (dsbt_pspace_data_cleanup): Remove.
1478         (get_dsbt_info, _initialize_dsbt_solib): Update.
1479
1480 2019-07-10  Tom Tromey  <tromey@adacore.com>
1481
1482         * spu-tdep.c (spu_overlay_data): Change type.
1483         (spu_get_overlay_table, spu_overlay_new_objfile)
1484         (_initialize_spu_tdep): Update.
1485
1486 2019-07-10  Tom Tromey  <tromey@adacore.com>
1487
1488         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1489         destructor.
1490         (dbx_objfile_data_key): Change type and declare later.
1491         (DBX_SYMFILE_INFO): Rewrite.
1492         * dbxread.c (dbx_objfile_data_key): Change type.
1493         (dbx_symfile_init): Update.
1494         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1495         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1496         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1497
1498 2019-07-10  Tom Tromey  <tromey@adacore.com>
1499
1500         * jit.c (jit_program_space_key): Change type.  Move lower.
1501         (get_jit_program_space_data): Update.
1502         (jit_program_space_data_cleanup): Remove.
1503         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1504         Update.
1505         (struct jit_program_space_data): Add initializers.
1506
1507 2019-07-10  Tom Tromey  <tromey@adacore.com>
1508
1509         * solib-darwin.c (struct darwin_info): Add initializers.
1510         (solib_darwin_pspace_data): Change type.
1511         (darwin_pspace_data_cleanup): Remove.
1512         (get_darwin_info, _initialize_darwin_solib): Update.
1513
1514 2019-07-10  Tom Tromey  <tromey@adacore.com>
1515
1516         * remote-sim.c (struct sim_inferior_data): Add initializers,
1517         constructor, and destructor.
1518         (sim_inferior_data_key): Change type.  Move lower.
1519         (check_for_duplicate_sim_descriptor): Update.
1520         (get_sim_inferior_data): Use new.  Update.
1521         (~sim_inferior_data_cleanup): Rename from
1522         sim_inferior_data_cleanup.  Simplify.
1523         (gdbsim_close_inferior, simulator_command)
1524         (sim_command_completer, _initialize_remote_sim): Update.
1525         (next_pid, INITIAL_PID): Move earlier.
1526
1527 2019-07-10  Tom Tromey  <tromey@adacore.com>
1528
1529         * python/python-internal.h (create_thread_object): Return
1530         gdbpy_ref.
1531         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1532         * python/py-inferior.c (struct threadlist_entry): Add
1533         constructor.
1534         <thread_obj>: Now a gdbpy_ref.
1535         (thread_to_thread_object): Update.
1536         (add_thread_object): Use new.
1537         (delete_thread_object): Use delete.
1538         (infpy_threads): Update.
1539         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1540         GIL.
1541
1542 2019-07-10  Tom Tromey  <tromey@adacore.com>
1543
1544         * valops.c (value_cast): Specialize error message for Ada.
1545
1546 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1547
1548         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1549
1550 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1551
1552         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1553         bpstat_should_step): Return bool, adjust comments.
1554         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1555         bpstat_should_step): Likewise.
1556
1557 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1558
1559         * features/Makefile: Use feature target descriptions for Arm.
1560         * features/arm/arm-core.c: Generate new file.
1561         * features/arm/arm-fpa.c: Likewise.
1562         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1563         * features/arm/arm-m-profile.c: Likewise.
1564         * features/arm/arm-vfpv2.c: Likewise.
1565         * features/arm/arm-vfpv3.c: Likewise.
1566         * features/arm/xscale-iwmmxt.c: Likewise.
1567         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1568
1569 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1570
1571         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1572         ptrace earlier.
1573
1574 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1575
1576         * features/aarch64-pauth.c: Regenerate.
1577
1578 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1579
1580         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1581         bool.
1582         (bpstat_what): Use false instead of 0.
1583
1584 2019-07-09  Pedro Alves  <palves@redhat.com>
1585
1586         * break-catch-throw.c (is_exception_catchpoint): New.
1587         * breakpoint.c (print_one_breakpoint_location): New parameter
1588         'raw_loc'.  Handle it.  Use
1589         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1590         looking at the breakpoint's type.
1591         (print_one_breakpoint): If handling "maint info breakpoints", also
1592         print locations of exception catchpoints.
1593         * breakpoint.h (is_exception_catchpoint): Declare.
1594
1595 2019-07-09  Pedro Alves  <palves@redhat.com>
1596
1597         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1598         "addr" field.
1599         (allocate_location_exception_catchpoint): New.
1600         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1601         (initialize_throw_catchpoint_ops): Install
1602         allocate_location_exception_catchpoint as allocate_location
1603         method.
1604         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1605         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1606         bp_loc_other.
1607         (breakpoint_address_is_meaningful): Delete.
1608         (bl_address_is_meaningful): New.
1609         (breakpoint_locations_match): Adjust comment.
1610         (bp_location_from_bp_type): New, factored out of...
1611         (bp_location::bp_location(breakpoint *)): ... this.
1612         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1613         factored out of...
1614         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1615         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1616         breakpoint_address_is_meaningful.
1617         (bp_locations_compare): Adjust comment.
1618         (update_global_location_list): Use bl_address_is_meaningful
1619         instead of breakpoint_address_is_meaningful.
1620         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1621         explicit.
1622         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1623         * python/py-breakpoint.c (bppy_get_location): No longer check
1624         whether location is null.
1625
1626 2019-07-09  Pedro Alves  <palves@redhat.com>
1627
1628         PR c++/15468
1629         * breakpoint.c (print_one_breakpoint_location): Remove
1630         single-location assert.
1631
1632 2019-07-09  Tom Tromey  <tom@tromey.com>
1633
1634         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1635         * configure: Rebuild.
1636         * configure.ac: Change common to gdbsupport.
1637         * gdbsupport: Rename from common.
1638         * acinclude.m4: Change common to gdbsupport.
1639         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1640         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1641         gdbsupport.
1642         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1643         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1644         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1645         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1646         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1647         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1648         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1649         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1650         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1651         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1652         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1653         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1654         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1655         coff-pe-read.c, command.h, compile/compile-c-support.c,
1656         compile/compile-c.h, compile/compile-cplus-symbols.c,
1657         compile/compile-cplus-types.c, compile/compile-cplus.h,
1658         compile/compile-loc2c.c, compile/compile.c, completer.c,
1659         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1660         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1661         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1662         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1663         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1664         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1665         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1666         features/aarch64-core.c, features/aarch64-fpu.c,
1667         features/aarch64-pauth.c, features/aarch64-sve.c,
1668         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1669         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1670         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1671         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1672         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1673         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1674         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1675         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1676         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1677         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1678         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1679         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1680         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1681         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1682         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1683         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1684         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1685         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1686         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1687         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1688         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1689         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1690         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1691         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1692         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1693         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1694         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1695         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1696         minsyms.c, mips-linux-tdep.c, namespace.h,
1697         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1698         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1699         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1700         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1701         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1702         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1703         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1704         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1705         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1706         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1707         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1708         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1709         procfs.c, producer.c, progspace.h, psymtab.h,
1710         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1711         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1712         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1713         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1714         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1715         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1716         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1717         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1718         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1719         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1720         target-memory.c, target.c, target.h, target/waitstatus.c,
1721         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1722         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1723         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1724         unittests/array-view-selftests.c,
1725         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1726         unittests/common-utils-selftests.c,
1727         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1728         unittests/format_pieces-selftests.c,
1729         unittests/function-view-selftests.c,
1730         unittests/lookup_name_info-selftests.c,
1731         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1732         unittests/mkdir-recursive-selftests.c,
1733         unittests/observable-selftests.c,
1734         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1735         unittests/parse-connection-spec-selftests.c,
1736         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1737         unittests/scoped_fd-selftests.c,
1738         unittests/scoped_mmap-selftests.c,
1739         unittests/scoped_restore-selftests.c,
1740         unittests/string_view-selftests.c, unittests/style-selftests.c,
1741         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1742         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1743         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1744         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1745         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1746         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1747
1748 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1751         bool value.
1752         (decode_digits_ordinary): Set explicit_line field in sal.
1753         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1754         symtab_and_line that was set on an explicit line number in
1755         assembler code.  Do always update the recorded symtab and line if
1756         we do skip the prologue.
1757
1758 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1759
1760         * breakpoint.c (set_breakpoint_location_function): Remove
1761         explicit_loc parameter.
1762         (momentary_breakpoint_from_master): Update call to
1763         set_breakpoint_location_function.
1764         (add_location_to_breakpoint): Likewise.
1765
1766 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1767
1768         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1769         required features based on default bfd type when no specific bfd
1770         is present.
1771
1772 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1773
1774         * NEWS: Mention that GDB printf and eval commands can now print
1775         C-style and Ada-style convenience var strings without
1776         calling the inferior.
1777         * printcmd.c (printf_c_string): Locally print GDB internal var
1778         instead of transiting via the inferior.
1779         (printf_wide_c_string): Likewise.
1780
1781 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1782
1783         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1784
1785 2019-07-04  Tom Tromey  <tom@tromey.com>
1786
1787         PR tui/24724:
1788         * tui/tui-winsource.c (tui_clear_source_content): Update.
1789         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1790         (tui_update_breakpoint_info): Update.
1791         (tui_set_exec_info_content): Update.
1792         * tui/tui-source.c (tui_set_source_content_nil): Update.
1793         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1794         has_break.
1795         * tui/tui-data.h (enum tui_bp_flag): New.
1796         (tui_bp_flags): New enum flags type.
1797         (struct tui_source_element) <break_mode>: Change type.  Rename
1798         from has_break.
1799         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1800         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1801         constants.
1802         * tui/tui-winsource.h: Fix comment.
1803
1804 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1805
1806         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1807         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1808         (store_fpregs_to_thread)
1809         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1810         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1811         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1812         (IWMMXT_REGS_SIZE): Add define.
1813         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1814         (fetch_vfp_regs, store_vfp_regs)
1815         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1816         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1817
1818 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1819
1820         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1821         defines.
1822         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1823         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1824         (ARM_INT_REGISTER_SIZE): ...to this.
1825         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1826         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1827         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1828         (arm_linux_collect_gregset, supply_nwfpe_register)
1829         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1830         defines.
1831         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1832         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1833         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1834         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1835         (arm_return_in_memory, arm_store_return_value)
1836         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1837         (arm_record_ld_st_multiple): Likewise.
1838         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1839         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1840
1841 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1842
1843         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1844         AARCH64_DISPLACED_MODIFIED_INSNS.
1845         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1846         (aarch64_displaced_step_copy_insn): Likewise.
1847         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1848         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1849         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1850         ARM_DISPLACED_MODIFIED_INSNS.
1851         * arm-tdep.c (arm_gdbarch_init): Likewise.
1852         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1853         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1854         (struct arm_displaced_step_closure): Use
1855         ARM_DISPLACED_MODIFIED_INSNS.
1856
1857 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1858
1859         * features/Makefile: Remove unused xml files.
1860         * features/aarch64.xml: Remove.
1861         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1862         * features/i386/amd64-avx-avx512.xml: Remove.
1863         * features/i386/amd64-avx-linux.xml: Remove.
1864         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1865         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1866         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1867         * features/i386/amd64-avx-mpx.xml: Remove.
1868         * features/i386/amd64-avx.xml: Remove.
1869         * features/i386/amd64-linux.xml: Remove.
1870         * features/i386/amd64-mpx-linux.xml: Remove.
1871         * features/i386/amd64-mpx.xml: Remove.
1872         * features/i386/amd64.xml: Remove.
1873         * features/i386/i386-avx-avx512-linux.xml: Remove.
1874         * features/i386/i386-avx-avx512.xml: Remove.
1875         * features/i386/i386-avx-linux.xml: Remove.
1876         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1877         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1878         * features/i386/i386-avx-mpx-linux.xml: Remove.
1879         * features/i386/i386-avx-mpx.xml: Remove.
1880         * features/i386/i386-avx.xml: Remove.
1881         * features/i386/i386-linux.xml: Remove.
1882         * features/i386/i386-mmx-linux.xml: Remove.
1883         * features/i386/i386-mmx.xml: Remove.
1884         * features/i386/i386-mpx-linux.xml: Remove.
1885         * features/i386/i386-mpx.xml: Remove.
1886         * features/i386/i386.xml: Remove.
1887         * features/i386/x32-avx-avx512-linux.xml: Remove.
1888         * features/i386/x32-avx-linux.xml: Remove.
1889         * features/i386/x32-linux.xml: Remove.
1890
1891 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1892
1893         * regformats/aarch64.dat: Remove.
1894         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1895         * regformats/i386/amd64-avx-linux.dat: Remove.
1896         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1897         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1898         * regformats/i386/amd64-linux.dat: Remove.
1899         * regformats/i386/amd64-mpx-linux.dat: Remove.
1900         * regformats/i386/amd64.dat: Remove.
1901         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1902         * regformats/i386/i386-avx-linux.dat: Remove.
1903         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1904         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1905         * regformats/i386/i386-linux.dat: Remove.
1906         * regformats/i386/i386-mmx-linux.dat: Remove.
1907         * regformats/i386/i386-mpx-linux.dat: Remove.
1908         * regformats/i386/i386.dat: Remove.
1909         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1910         * regformats/i386/x32-avx-linux.dat: Remove.
1911         * regformats/i386/x32-linux.dat: Remove.
1912
1913 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1914
1915         * aarch64-tdep.c: Remove xml self tests.
1916         * amd64-linux-tdep.c: Likewise.
1917         * amd64-tdep.c: Likewise.
1918         * i386-linux-tdep.c: Likewise.
1919         * i386-tdep.c: Likewise.
1920
1921 2019-07-03  Pedro Alves  <palves@redhat.com>
1922
1923         PR cli/24732
1924         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1925         (pipe_cmd_option_defs): New.
1926         (make_pipe_cmd_options_def_group): New.
1927         (pipe_command): Use gdb::option::process_options.
1928         (pipe_command_completer): New function.
1929         (_initialize_cli_cmds): Install completer for "pipe" command.
1930
1931 2019-07-03  Pedro Alves  <palves@redhat.com>
1932
1933         * cli/cli-option.c (union option_value) <string>: New field.
1934         (struct option_def_and_value): Add ctor, move ctor, dtor and
1935         use DISABLE_COPY_AND_ASSIGN.
1936         (option_def_and_value::clear_value): New.
1937         (parse_option, save_option_value_in_ctx, get_val_type_str)
1938         (add_setshow_cmds_for_options): Handle var_string.
1939         * cli-option.h (union option_def::var_address) <string>: New
1940         field.
1941         (struct string_option_def): New.
1942         * maint-test-options.c (struct test_options_opts): Add default
1943         ctor and use DISABLE_COPY_AND_ASSIGN.
1944         <string_opt>: New field.
1945         (test_options_opts::~test_options_opts): New.
1946         (test_options_opts::dump): Also dump "-string".
1947         (test_options_option_defs): Install "string.
1948
1949 2019-07-03  Pedro Alves  <palves@redhat.com>
1950
1951         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1952         option_value with a null enumeration.
1953         (complete_options): Save the option values in the context.
1954         (save_option_value_in_ctx): New, factored out from ...
1955         (process_options): ... here.
1956         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1957         of the function.
1958         * maint-test-options.c (test_options_opts::dump): New, factored
1959         out from ...
1960         (maintenance_test_options_command_mode): ... here.
1961         (maintenance_test_options_command_completion_result): Delete.
1962         (maintenance_test_options_command_completion_text): Update
1963         comment.
1964         (maintenance_show_test_options_completion_result): Change
1965         prototype.  Just print
1966         maintenance_test_options_command_completion_text.
1967         (save_completion_result): New.
1968         (maintenance_test_options_completer_mode): Pass options context to
1969         complete_options, and then save a dump.
1970         (_initialize_maint_test_options): Use add_cmd to install "maint
1971         show test-options-completion-result".
1972
1973 2019-07-03  Pedro Alves  <palves@redhat.com>
1974
1975         * NEWS (New commands): Mention "with" and "maint with".
1976         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1977         (with_command, with_command_completer): New.
1978         (pipe_command): Adjust to new repeat_previous
1979         interface.
1980         (_initialize_cli_cmds): Install the "with" command and its "w"
1981         alias.
1982         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1983         declarations.
1984         * cli/cli-setshow.c (parse_cli_var_uinteger)
1985         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1986         argument strings for all var_types.
1987         (get_setshow_command_value_string): New, factored out from ...
1988         (do_show_command): ... this.
1989         * cli/cli-setshow.h: Include <string>.
1990         (get_setshow_command_value_string): Declare.
1991         * command.h (repeat_previous): Now returns const char *.  Adjust
1992         comment.
1993         * maint.c: Include "cli/cli-cmds.h".
1994         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1995         (_initialize_maint_cmds): Register the "maintenance with" command.
1996         * top.c (repeat_previous): Move bits from pipe_command here:
1997         Return the saved command line, if any; error out if there's no
1998         command to relaunch.
1999
2000 2019-07-03  Pedro Alves  <palves@redhat.com>
2001
2002         * NEWS (New commands): Mention "maint set/show test-settings"
2003         instead of "maint test-settings".
2004         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2005         (maintenance_test_settings_set_list): Rename to ...
2006         (maintenance_set_test_settings_list): ... this.
2007         (maintenance_test_settings_show_list): Rename to  ...
2008         (maintenance_show_test_settings_list): ... this.
2009         (maintenance_test_settings_cmd): Delete.
2010         (maintenance_test_settings_set_cmd): ...
2011         (maintenance_set_test_settings_cmd): ... this.
2012         (maintenance_test_settings_show_cmd): ...
2013         (maintenance_show_test_settings_cmd): ... this.
2014         (maintenance_test_settings_show_value_cmd):
2015         (maintenance_show_test_settings_value_cmd): ... this.
2016         (_initialize_maint_test_settings): No longer install the "maint
2017         test-settings" prefix command.  Rename "maint test-settings set"
2018         to "maint set test-settings", and "maint test-settings show" to
2019         "maint show test-settings".  Adjust all subcommands.
2020
2021 2019-07-03  Pedro Alves  <palves@redhat.com>
2022
2023         * maint-test-settings.c: Fix file's intro comment.  Replace all
2024         references to "test-options" with references to "test-settings",
2025         in comments.
2026
2027 2019-07-03  Pedro Alves  <palves@redhat.com>
2028
2029         * maint-test-settings.c (maintenance_test_settings_xxx)
2030         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2031         New.
2032         (maintenance_test_settings_enums): Use them.
2033         (maintenance_test_settings_enum): Default to
2034         maintenance_test_settings_xxx.
2035         (_initialize_maint_test_settings): Initialize
2036         MAINTENANCE_TEST_SETTINGS_FILENAME.
2037
2038 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2039
2040         * breakpoint.h (remove_breakpoints_inf): Change return type to
2041         void, move function documentation here.
2042         * breakpoint.c (remove_breakpoints_inf): Change return type to
2043         void, move function documentation to header.
2044
2045 2019-07-02  Pedro Alves  <palves@redhat.com>
2046
2047         * NEWS (Completion improvements): Mention "info threads".
2048         * thread.c (struct info_threads_opts, info_threads_option_defs)
2049         (make_info_threads_options_def_group): New.
2050         (info_threads_command): Use gdb::option::process_options.
2051         (info_threads_command_completer): New.
2052         (_initialize_thread): Use gdb::option::build_help to build the
2053         help text for "info threads".
2054
2055 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2056
2057         * defs.h (generic_load): Move from here...
2058         * symfile.h (generic_load): ... to here.  Rename name parameter
2059         to args.
2060         * symfile.c (generic_load): Add comment.
2061
2062 2019-07-01  Tom Tromey  <tromey@adacore.com>
2063
2064         * dwarf2read.c
2065         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2066         declaration of without_params.  Fix formatting.
2067
2068 2019-07-01  Tom Tromey  <tromey@adacore.com>
2069
2070         * ada-exp.y (find_primitive_type): Update.
2071         * ada-lang.h (ada_lookup_symbol): Update.
2072         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2073         parameter.
2074         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2075
2076 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2077
2078         PR breakpoints/24541
2079         * gdbarch.c: Regenerate.
2080         * gdbarch.h: Regenerate.
2081         * gdbarch.sh: Add 'stap_adjust_register'.
2082         * i386-tdep.c: Include '<unordered_set>'.
2083         (i386_stap_adjust_register): New function.
2084         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2085         * stap-probe.c (stap_parse_register_operand): Call
2086         'gdbarch_stap_adjust_register'.
2087
2088 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2089
2090         PR python/24742
2091         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2092         * python/python.c (do_start_initialization): Use 'xmalloc'
2093         instead of 'PyMem_Malloc'.
2094
2095 2019-06-28  Tom Tromey  <tromey@adacore.com>
2096
2097         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2098         for Ada.
2099
2100 2019-06-27  Tom Tromey  <tromey@adacore.com>
2101
2102         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2103         objfile_key.
2104         (arm_find_mapping_symbol, arm_record_special_symbol)
2105         (_initialize_arm_tdep): Update.
2106         (arm_objfile_data_free): Remove.
2107
2108 2019-06-27  Tom Tromey  <tromey@adacore.com>
2109
2110         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2111         to cp_print_static_field.
2112
2113 2019-06-26  Tom Tromey  <tromey@adacore.com>
2114
2115         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2116         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2117         declare.
2118
2119 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2120
2121         * features/aarch64-core.c (create_feature_aarch64_core):
2122         Regenerate.
2123         * features/aarch64-core.xml: Add cpsr flags.
2124
2125 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2126
2127         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2128         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2129
2130 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2131
2132         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2133         field.
2134         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2135         use.
2136         (arm_record_special_symbol): Don't insert new symbol in sorted
2137         position, push it at the end.
2138
2139 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2140
2141         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2142         (arm_mapping_symbol_s): Remove.
2143         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2144         (arm_mapping_symbol_vec): New typedef.
2145         (struct arm_per_objfile): Add constructor.
2146         <section_maps>: Change type to
2147         std::unique_ptr<arm_mapping_symbol_vec[]>.
2148         (arm_compare_mapping_symbols): Remove.
2149         (arm_find_mapping_symbol): Adjust to section_maps type change.
2150         (arm_objfile_data_free): Call delete on arm_per_objfile.
2151         (arm_record_special_symbol): Adjust to section_maps type change.
2152         Allocate arm_per_objfile with new.
2153
2154 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2155
2156         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2157         with the command prefix.
2158
2159 2019-06-25  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2162         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2163
2164 2019-06-25  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2167         type.
2168         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2169         protected.
2170
2171 2019-06-25  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-winsource.c
2174         (tui_source_window_base::set_is_exec_point_at): Add check against
2175         LOA_ADDRESS.
2176
2177 2019-06-25  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-source.c (tui_set_source_content): Don't check before
2180         xfree.
2181         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2182
2183 2019-06-25  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-winsource.h (tui_update_source_window_as_is)
2186         (tui_alloc_source_buffer, tui_line_is_displayed)
2187         (tui_addr_is_displayed): Change type of win_info.
2188         * tui/tui-winsource.c (tui_update_source_window_as_is)
2189         (tui_clear_source_content, tui_show_source_line)
2190         (tui_show_source_content, tui_source_window_base::refill)
2191         (tui_source_window_base::set_is_exec_point_at)
2192         (tui_source_window_base::set_is_exec_point_at)
2193         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2194         (tui_alloc_source_buffer, tui_line_is_displayed)
2195         (tui_addr_is_displayed): Change type of win_info.  Update.
2196         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2197         (tui_source_window_base::do_make_visible_with_new_height):
2198         Update.
2199         * tui/tui-source.c (tui_set_source_content)
2200         (tui_set_source_content_nil)
2201         (tui_source_window::do_scroll_vertical): Update.
2202         * tui/tui-layout.c (show_layout): Update.
2203         * tui/tui-disasm.c (tui_set_disassem_content)
2204         (tui_disasm_window::do_scroll_vertical): Update.
2205         * tui/tui-data.h (tui_win_content): Remove.
2206         (struct tui_gen_win_info) <content, content_size>: Remove.
2207         (struct tui_source_element): Add initializers and destructor.
2208         (union tui_which_element, struct tui_win_element): Remove.
2209         (struct tui_source_window_base) <content>: New field.
2210         (struct tui_data_window): Remove destructor.
2211         (tui_alloc_content, tui_free_win_content)
2212         (tui_free_all_source_wins_content): Don't declare.
2213         * tui/tui-data.c (tui_initialize_static_data): Update.
2214         (init_content_element, tui_alloc_content): Remove.
2215         (~tui_gen_win_info): Update.
2216         (~tui_data_window, tui_free_all_source_wins_content)
2217         (tui_free_win_content, free_content, free_content_elements):
2218         Remove.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-winsource.h (tui_clear_source_content)
2223         (tui_erase_source_content, tui_show_source_content): Change type
2224         of win_info.
2225         * tui/tui-winsource.c (tui_clear_source_content)
2226         (tui_erase_source_content, tui_show_source_content): Change type
2227         of win_info.
2228         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2229         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2230         win_info.
2231         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2232         win_info.
2233         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2234
2235 2019-06-25  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-winsource.c (tui_clear_source_content)
2238         (tui_source_window_base::set_is_exec_point_at): Update.
2239         * tui/tui-source.c (tui_set_source_content_nil): Update.
2240         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2241         a bool.
2242         * tui/tui-data.c (init_content_element): Update.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2247         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2248         * tui/tui-layout.c (init_and_make_win): Update.
2249         * tui/tui.h (enum tui_win_type): Update.
2250         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2251         tui_win_is_auxillary.
2252         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2253         tui_win_is_auxillary.
2254
2255 2019-06-25  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2258         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2259         (tui_delete_data_content_windows, tui_display_all_data)
2260         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2261         Update.
2262         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2263         * tui/tui-regs.c (tui_last_regs_line_no)
2264         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2265         (tui_show_registers): Update.
2266         (tui_show_register_group): Return void.  Update.
2267         (tui_display_registers_from, tui_display_reg_element_at_line)
2268         (tui_display_registers_from_line, tui_check_register_values):
2269         Update.
2270         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2271         member.
2272         (struct tui_data_window) <regs_content>: Now a std::vector.
2273         <regs_content_count>: Remove.
2274         (tui_add_content_elements, tui_free_data_content): Don't declare.
2275         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2276         (init_content_element): Remove DATA_WIN case.  Add assert.
2277         (tui_add_content_elements): Remove.
2278         (tui_data_window): Update.
2279         (tui_free_data_content): Remove.
2280         (free_content_elements): Remove DATA_WIN case.
2281
2282 2019-06-25  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-data.c (tui_data_item_window): Update.
2285         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2286         * tui/tui-windata.c (tui_display_all_data)
2287         (tui_display_data_from_line): Update.
2288         (tui_check_data_values): Remove.
2289         * tui/tui-regs.c (tui_show_register_group)
2290         (tui_display_reg_element_at_line): Update.
2291         * tui/tui-hooks.c (tui_register_changed)
2292         (tui_refresh_frame_and_register_information): Call
2293         tui_check_register_values.
2294         * tui/tui-data.h (struct tui_data_window) <data_content,
2295         data_content_count, data_type>: Remove.
2296         (enum tui_data_type): Remove.
2297
2298         * tui/tui-data.c (tui_data_window::clear_detail)
2299         (~tui_data_window): Update.
2300
2301 2019-06-25  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2304         declare.
2305         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2306         Rename from tui_first_data_item_displayed.  Update.
2307         (tui_data_window::refresh_all)
2308         (tui_data_window::do_scroll_vertical): Update.
2309         * tui/tui-data.h (struct tui_data_window)
2310         <first_data_item_displayed>: Declare new method.
2311
2312 2019-06-25  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2315         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2316         contents...
2317         (tui_initialize_static_data): ...here.
2318
2319 2019-06-25  Tom Tromey  <tom@tromey.com>
2320
2321         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2322         (tui_display_registers_from, tui_check_register_values): Update.
2323         (tui_display_register): Remove win_info parameter; update.
2324         (tui_get_register): Change type of parameters.
2325         * tui/tui-data.h (struct tui_data_element): Remove.
2326         (union tui_which_element) <data>: Remove.
2327         <data_window>: Change type.
2328         (struct tui_data_item_window): New.
2329         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2330         case.  Add assert.
2331         (~tui_data_item_window): New destructor.
2332         (free_content_elements): Remove DATA_ITEM_WIN case.
2333
2334 2019-06-25  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2337         Remove.
2338
2339 2019-06-25  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-data.h (struct tui_command_element): Remove.
2342         (union tui_which_element) <command>: Remove.
2343         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2344         assert.
2345         (free_content_elements): Remove CMD_WIN case.
2346
2347 2019-06-25  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-layout.c (tui_set_layout): Update.
2350         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2351         * tui/tui-data.c (layout_def): Update.
2352
2353 2019-06-25  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2356         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2357         (tui_source_window_base::set_new_height): Update.
2358         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2359         Update.
2360         (tui_set_locator_fullname, tui_set_locator_info)
2361         (tui_show_frame_info): Update.
2362         * tui/tui-source.c (tui_set_source_content)
2363         (tui_source_is_displayed): Update.
2364         * tui/tui-layout.c (show_source_disasm_command, show_data)
2365         (show_source_or_disasm_and_command): Update.
2366         * tui/tui-disasm.c (tui_set_disassem_content)
2367         (tui_get_begin_asm_address): Update.
2368         * tui/tui-data.h (struct tui_locator_element): Remove.
2369         (union tui_which_element) <locator>: Remove.
2370         (struct tui_locator_window): New.
2371         (tui_locator_win_info_ptr): Change return type.
2372         * tui/tui-data.c (_locator): Change type.
2373         (tui_locator_win_info_ptr): Change return type.
2374         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2375         (tui_alloc_content): Add assert.
2376
2377 2019-06-25  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-winsource.c
2380         (tui_exec_info_window::maybe_allocate_content): New method.
2381         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2382         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2383         (make_source_or_disasm_window): Add cast.
2384         * tui/tui-data.h (union tui_which_element) <simple_string>:
2385         Remove.
2386         (struct tui_source_info): New.
2387         (struct tui_source_window_base) <execution_info>: Change type.
2388         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2389         case, and add assert.
2390         (tui_alloc_content): Add assert.
2391
2392 2019-06-25  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2395         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2396         * tui/tui-data.c (tui_alloc_win_info): Remove.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2401         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2402         can_highlight.
2403
2404 2019-06-25  Tom Tromey  <tom@tromey.com>
2405
2406         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2407         make_visible_with_new_height method.
2408         (tui_win_info::make_visible_with_new_height): New method.
2409         (tui_source_window_base::do_make_visible_with_new_height)
2410         (tui_data_window::do_make_visible_with_new_height)
2411         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2412         (make_visible_with_new_height): Remove.
2413         (tui_resize_all, tui_adjust_win_heights): Use
2414         make_visible_with_new_height method.
2415         * tui/tui-data.h (struct tui_win_info)
2416         <do_make_visible_with_new_height, make_visible_with_new_height>:
2417         New methods.
2418         (struct tui_source_window_base, struct tui_data_window)
2419         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2420         methods.
2421
2422 2019-06-25  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2425         method.
2426         (update_tab_width): Call update_tab_width method.
2427         * tui/tui-data.h (struct tui_win_info)
2428         (struct tui_source_window_base) <update_tab_width>: New methods.
2429
2430 2019-06-25  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2433         parameter.
2434         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2435         parameter.
2436         (tui_gen_win_info::make_visible): Update.
2437         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2438         parameter.
2439         * tui/tui-data.h (enum tui_box): New enum.
2440         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2445         init_and_make_win for EXEC_INFO_WIN.
2446         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2447         longer inline.
2448         (struct tui_win_info) <~tui_win_info>: Inline.
2449         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2450         Don't declare.
2451         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2452         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2453         Remove.
2454         (tui_initialize_static_data): Update.
2455         (~tui_gen_win_info): Handle more cleanup here.
2456         (~tui_source_window_base): Delete "execution_info".
2457         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2458
2459 2019-06-25  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-layout.c (make_command_window): Don't set
2462         can_highlight.
2463         (show_source_disasm_command): Call the reset method.
2464         (show_data): Don't set can_highlight.  Call the reset method.
2465         (tui_gen_win_info::reset): Rename from init_gen_win_info
2466         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2467         (show_source_or_disasm_and_command): Call the reset method.
2468         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2469         (struct tui_cmd_window): Set can_highlight.
2470
2471 2019-06-25  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2474         from make_visible.
2475         (tui_make_visible, tui_make_invisible): Rewrite.
2476         (tui_win_info::make_visible): Remove.
2477         (tui_source_window_base::make_visible): Update.
2478         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2479         method.  Moved from...
2480         (struct tui_win_info) <make_visible>: ...here.
2481
2482 2019-06-25  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-winsource.c
2485         (tui_source_window_base::do_scroll_horizontal): Remove direction
2486         parameter.
2487         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2488         direction parameter.
2489         * tui/tui-win.c (tui_win_info::forward_scroll)
2490         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2491         (tui_win_info::right_scroll): Update.
2492         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2493         direction parameter.
2494         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2495         direction parameter.
2496         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2497         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2498         Remove direction parameter.
2499         (struct tui_source_window_base, struct tui_source_window)
2500         (struct tui_disasm_window, struct tui_data_window)
2501         (struct tui_cmd_window): Update.
2502
2503 2019-06-25  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-winsource.h (tui_set_exec_info_content)
2506         (tui_show_exec_info_content, tui_erase_exec_info_content)
2507         (tui_clear_exec_info_content, tui_update_exec_info): Change
2508         argument to tui_source_window_base.
2509         * tui/tui-winsource.c (tui_set_exec_info_content)
2510         (tui_show_exec_info_content, tui_erase_exec_info_content)
2511         (tui_clear_exec_info_content, tui_update_exec_info): Change
2512         argument to tui_source_window_base.
2513
2514 2019-06-25  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2517         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2518
2519 2019-06-25  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2522         check.
2523
2524 2019-06-25  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2527         type to void.
2528         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2529         type to void.
2530         * tui/tui-source.c (tui_set_source_content): Update.
2531         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2532
2533 2019-06-25  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-win.c (window_name_completer, tui_set_focus)
2536         (tui_all_windows_info): Use name method.
2537         * tui/tui-data.h (struct tui_gen_win_info)
2538         (struct tui_source_window, struct tui_disasm_window)
2539         (struct tui_data_window, struct tui_cmd_window) <name>: New
2540         method.
2541         (tui_win_name): Don't declare.
2542         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2543         (tui_win_name): Remove.
2544
2545 2019-06-25  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-winsource.h (tui_update_source_window)
2548         (tui_update_source_window_as_is): Change parameter type.
2549         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2550         to be a tui_source_window_base.
2551         (tui_update_source_window_as_is): Likewise.
2552         * tui/tui-win.c (make_visible_with_new_height): Update.
2553
2554 2019-06-25  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-winsource.c (tui_erase_source_content)
2557         (tui_show_source_content, tui_show_exec_info_content)
2558         (tui_erase_exec_info_content): Use refresh_window method.
2559         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2560         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2561         from tui_refresh_win.
2562         (tui_data_window::refresh_window): New method.
2563         (tui_win_info::refresh, tui_source_window_base::refresh)
2564         (tui_refresh_all): Use refresh_window method.
2565         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2566         method.
2567         * tui/tui-regs.c (tui_display_register): Call refresh_window
2568         method.
2569         * tui/tui-layout.c (show_source_disasm_command)
2570         (show_source_or_disasm_and_command): Call refresh_window method.
2571         * tui/tui-data.h (struct tui_gen_win_info)
2572         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2573         New method.
2574
2575 2019-06-25  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui.c (tui_rl_other_window, tui_enable)
2578         (tui_is_window_visible, tui_get_command_dimension): Update.
2579         * tui/tui-winsource.c (tui_update_source_window_as_is)
2580         (tui_clear_source_content, tui_erase_source_content)
2581         (tui_show_source_line, tui_source_window_base::refill)
2582         (tui_source_window_base::do_scroll_horizontal)
2583         (tui_source_window_base::set_is_exec_point_at)
2584         (tui_update_breakpoint_info, tui_set_exec_info_content)
2585         (tui_alloc_source_buffer, tui_line_is_displayed)
2586         (tui_addr_is_displayed): Update.
2587         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2588         (tui_check_and_display_highlight_if_needed)
2589         (tui_win_info::make_visible, tui_win_info::refresh)
2590         (tui_refresh_all): Update.
2591         * tui/tui-windata.c (tui_first_data_item_displayed)
2592         (tui_delete_data_content_windows, tui_erase_data_content)
2593         (tui_display_all_data, tui_data_window::refresh_all)
2594         (tui_check_data_values): Update.
2595         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2596         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2597         (tui_win_info::backward_scroll, tui_refresh_all_win)
2598         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2599         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2600         (tui_source_window_base::set_new_height)
2601         (tui_data_window::set_new_height)
2602         (make_invisible_and_set_new_height)
2603         (make_visible_with_new_height, new_height_ok)
2604         (parse_scrolling_args): Update.
2605         * tui/tui-stack.c (tui_show_frame_info): Update.
2606         * tui/tui-source.c (tui_set_source_content)
2607         (tui_set_source_content_nil, tui_source_is_displayed)
2608         (tui_source_window::do_scroll_vertical): Update.
2609         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2610         (tui_display_registers_from, tui_display_reg_element_at_line)
2611         (tui_check_register_values, tui_reg_command): Update.
2612         * tui/tui-layout.c (tui_default_win_height)
2613         (show_source_disasm_command, show_data, init_and_make_win)
2614         (show_source_or_disasm_and_command): Update.
2615         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2616         (tui_redisplay_readline, tui_mld_flush)
2617         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2618         (tui_getc): Update.
2619         * tui/tui-disasm.c (tui_set_disassem_content)
2620         (tui_disasm_window::do_scroll_vertical): Update.
2621         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2622         Now virtual.
2623         (struct tui_win_info): Derive from tui_gen_win_info.
2624         <~tui_win_info>: Mark as override.
2625         <generic>: Remove member.
2626         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2627         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2628         (~tui_data_window, ~tui_win_info)
2629         (tui_free_all_source_wins_content): Update.
2630         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2631
2632 2019-06-25  Tom Tromey  <tom@tromey.com>
2633
2634         * tui/tui-layout.c (init_and_make_win): Use new.
2635         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2636         destructor, initializers.
2637         (tui_alloc_generic_win_info): Don't declare.
2638         * tui/tui-data.c (_locator): Add argument to constructor.
2639         (source_win, disasm_win): New globals.
2640         (exec_info): Remove.
2641         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2642         Update.
2643         (tui_alloc_generic_win_info): Remove.
2644         (init_content_element): Use new.
2645         (tui_win_info::tui_win_info): Update.
2646         (free_content_elements) <case DATA_WIN>: Use delete.
2647
2648 2019-06-25  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2651         * tui/tui-windata.c (tui_first_data_item_displayed)
2652         (tui_delete_data_content_windows): Update.
2653         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2654         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2655         (tui_display_registers_from, tui_check_register_values): Update.
2656         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2657         pointer.
2658         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2659         window.
2660         (tui_free_data_content): Update.
2661         (free_content_elements) <case DATA_WIN>: Free the window.
2662
2663 2019-06-25  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2666         Update.
2667         * tui/tui-layout.c (make_command_window)
2668         (show_source_disasm_command, show_data, init_and_make_win)
2669         (show_source_or_disasm_and_command): Update.
2670         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2671         method.
2672         <can_highight, is_highlighted>: Now bool.
2673         (tui_set_win_highlight): Don't declare.
2674         * tui/tui-data.c (tui_set_win_highlight): Remove.
2675
2676 2019-06-25  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-wingeneral.c (make_visible): Remove check of window
2679         type.
2680
2681 2019-06-25  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-win.c (tui_win_info::max_height)
2684         (tui_cmd_window::max_height): New methods.
2685         (new_height_ok): Call max_height.
2686         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2687         <max_height>: New method.
2688
2689 2019-06-25  Tom Tromey  <tom@tromey.com>
2690
2691         * tui/tui-win.c (tui_source_window_base::set_new_height)
2692         (tui_data_window::set_new_height): New methods.
2693         (make_invisible_and_set_new_height): Call set_new_height method.
2694         * tui/tui-data.h (struct tui_win_info)
2695         (struct tui_source_window_base, struct tui_data_window)
2696         <set_new_height>: New method.
2697
2698 2019-06-25  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2701         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2702         tui_refresh_data_win.
2703         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2704         method.
2705         (tui_refresh_all_win): Call the refresh_all method.
2706         (tui_set_focus): Likewise.
2707         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2708         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2709         Likewise.
2710
2711 2019-06-25  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-winsource.h (tui_refill_source_window)
2714         (tui_set_is_exec_point_at): Don't declare.
2715         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2716         (tui_source_window_base::refill): Rename from
2717         tui_refill_source_window.
2718         (tui_source_window_base::do_scroll_horizontal): Update.
2719         (tui_source_window_base::set_is_exec_point_at): Rename from
2720         tui_set_is_exec_point_at.
2721         (tui_update_all_breakpoint_info): Update.
2722         * tui/tui-stack.c (tui_show_frame_info): Update.
2723         * tui/tui-layout.c (show_data): Add cast.
2724         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2725         * tui/tui-data.h (struct tui_source_window_base) <refill,
2726         set_is_exec_point_at>: New methods.
2727         (tui_source_windows, tui_add_to_source_windows): Update types.
2728         (tui_add_to_source_windows): Remove redundant declaration.
2729         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2730         (tui_source_windows): Change return type.
2731         (tui_clear_source_windows_detail): Update.
2732         (tui_add_to_source_windows): Change type of parameter.
2733         (tui_free_all_source_wins_content): Update.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-wingeneral.c (tui_win_info::refresh)
2738         (tui_source_window_base::refresh): New methods.
2739         (tui_refresh_all): Call the refresh method.
2740         * tui/tui-data.h (struct tui_win_info)
2741         (struct tui_source_window_base) <refresh>: New method.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui.h (tui_is_window_visible): Return bool.
2746         * tui/tui.c (tui_is_window_visible): Return bool.
2747         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2748         (tui_make_visible, tui_make_invisible)
2749         (tui_win_info::make_visible)
2750         (tui_source_window_base::make_visible, make_all_visible)
2751         (tui_make_all_visible, tui_make_all_invisible): Update.
2752         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2753         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2754         bool.
2755         (struct tui_win_info, struct tui_source_window_base)
2756         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2757         * tui/tui-data.c (tui_init_generic_part): Update.
2758
2759 2019-06-25  Tom Tromey  <tom@tromey.com>
2760
2761         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2762         (tui_source_window_base::make_visible): New methods.
2763         (make_all_visible): Make method call.
2764         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2765         (struct tui_source_window_base, struct tui_cmd_window): Override
2766         make_visible.
2767         (tui_win_is_source_type): Don't declare.
2768         * tui/tui-data.c (tui_win_is_source_type): Remove.
2769
2770 2019-06-25  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2773         NULL check.
2774
2775 2019-06-25  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2778         Inline constructor.  Add initializers for members.
2779         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2780         constructors; now inline in class.
2781
2782 2019-06-25  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-regs.c (tui_show_registers): Update.
2785         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2786         bool.
2787         * tui/tui-data.c (tui_data_window::clear_detail)
2788         (tui_data_window): Update.
2789
2790 2019-06-25  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-windata.c (tui_display_all_data)
2793         (tui_display_data_from_line, tui_display_data_from)
2794         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2795         Update.
2796         * tui/tui-regs.c (tui_last_regs_line_no)
2797         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2798         (tui_show_registers, tui_show_register_group)
2799         (tui_display_registers_from, tui_display_reg_element_at_line)
2800         (tui_display_registers_from_line, tui_check_register_values)
2801         (tui_reg_next, tui_reg_prev): Update.
2802         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2803         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2804         tui_data_window.
2805         (struct tui_win_info) <detail>: Remove.  Add new fields from
2806         tui_data_info.
2807         (TUI_DATA_WIN): Add cast.
2808         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2809         (~tui_data_window): Simplify.
2810
2811 2019-06-25  Tom Tromey  <tom@tromey.com>
2812
2813         * tui/tui-layout.c (show_source_disasm_command)
2814         (show_source_or_disasm_and_command): Update.
2815         * tui/tui-io.c (update_cmdwin_start_line)
2816         (tui_redisplay_readline): Update.
2817         * tui/tui-data.h (struct tui_command_info): Remove.
2818         (struct tui_win_info) <detail>: Remove command_info member.
2819         (struct tui_data_window) <start_line>: New member, from
2820         tui_command_info.
2821         (TUI_CMD_WIN): Add casts.
2822
2823 2019-06-25  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-winsource.c (tui_update_source_window)
2826         (tui_refill_source_window)
2827         (tui_source_window_base::do_scroll_horizontal)
2828         (tui_update_breakpoint_info, tui_set_exec_info_content)
2829         (tui_show_exec_info_content, tui_erase_exec_info_content)
2830         (tui_clear_exec_info_content): Update.
2831         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2832         Update.
2833         * tui/tui-win.c (make_invisible_and_set_new_height)
2834         (make_visible_with_new_height): Update.
2835         * tui/tui-source.c (tui_set_source_content)
2836         (tui_show_symtab_source): Update.
2837         * tui/tui-layout.c (extract_display_start_addr)
2838         (show_source_disasm_command, show_data)
2839         (make_source_or_disasm_window)
2840         (show_source_or_disasm_and_command): Update.
2841         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2842         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2843         "gdbarch".
2844         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2845         to tui_source_window_base.
2846         (struct tui_win_info) <detail>: Remove source_info member.
2847         (struct tui_source_window_base) <has_locator>: Inline.
2848         Move contents from tui_source_info; rename has_locator member to
2849         m_has_locator.
2850         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2851         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2852         header file.
2853         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2854         Simplify.
2855         (tui_free_all_source_wins_content): Cast to
2856         tui_source_window_base.
2857
2858 2019-06-25  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-win.c (make_invisible_and_set_new_height)
2861         (make_visible_with_new_height): Call has_locator method.
2862         * tui/tui-layout.c (show_source_disasm_command, show_data)
2863         (show_source_or_disasm_and_command): Update for bool change.
2864         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2865         (tui_win_info) <has_locator>: New method.
2866         (struct tui_source_window_base) <has_locator>: New method.
2867         (tui_win_has_locator): Don't declare.
2868         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2869         from tui_win_has_locator.
2870         (tui_source_window_base): Use false, not FALSE.
2871
2872 2019-06-25  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2875         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2876         clear_detail method directly.
2877         (tui_clear_win_detail): Remove.
2878
2879 2019-06-25  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2882         "this", not TUI_DISASM_WIN.
2883
2884 2019-06-25  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2887         declare.
2888         * tui/tui-winsource.c
2889         (tui_source_window_base::do_scroll_horizontal): Rename from
2890         tui_horizontal_source_scroll.
2891         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2892         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2893         from tui_vertical_data_scroll.
2894         * tui/tui-win.h (tui_scroll): Don't declare.
2895         * tui/tui-win.c (tui_win_info::forward_scroll)
2896         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2897         (tui_win_info::right_scroll): Rename and update.
2898         (tui_scroll_forward_command, tui_scroll_backward_command)
2899         (tui_scroll_left_command, tui_scroll_right_command): Update.
2900         (tui_scroll): Remove.
2901         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2902         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2903         from tui_vertical_source_scroll.
2904         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2905         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2906         from tui_vertical_disassem_scroll.
2907         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2908         do_scroll_horizontal>: New methods.
2909         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2910         Likewise.
2911         (struct tui_source_window_base): Add do_scroll_horizontal.
2912         (struct tui_source_window, struct tui_disasm_window): Add
2913         do_scroll_vertical.
2914         (struct tui_data_window, struct tui_cmd_window): Add
2915         do_scroll_horizontal and do_scroll_vertical.
2916         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2917
2918 2019-06-25  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-data.h (struct tui_source_window_base): New struct.
2921         (struct tui_source_window): Derive from tui_source_window_base.
2922         (struct tui_disasm_window): New struct.
2923         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2924         from tui_source_window::clear_detail.
2925         (tui_source_window_base): Rename from tui_source_window.
2926         (~tui_source_window_base): Rename from ~tui_source_window.
2927         (tui_alloc_win_info): Create a tui_disasm_window.
2928
2929 2019-06-25  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-data.h (struct tui_source_window)
2932         (struct tui_data_window): Declare destructors.
2933         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2934         destructors.
2935         (tui_win_info): Simplify.
2936
2937 2019-06-25  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-winsource.c (tui_display_main)
2940         (tui_update_source_windows_with_addr)
2941         (tui_update_all_breakpoint_info): Update.
2942         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2943         (new_height_ok, parse_scrolling_args): Update.
2944         * tui/tui-stack.c (tui_show_frame_info): Update.
2945         * tui/tui-data.h (struct tui_list): Remove.
2946         (tui_source_windows): Return a reference to a std::vector.
2947         * tui/tui-data.c (source_windows): Now a std::vector.
2948         (tui_source_windows): Change return type.
2949         (tui_clear_source_windows): Rewrite.
2950         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2951         (tui_free_all_source_wins_content): Rewrite.
2952
2953 2019-06-25  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2956         (struct tui_data_window, struct tui_cmd_window): Declare
2957         clear_detail method.
2958         * tui/tui-data.c (tui_source_window::clear_detail)
2959         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2960         methods.
2961         (tui_clear_win_detail): Simplify.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-layout.c (make_source_window, make_disasm_window)
2966         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2967         Return the new window.
2968         (show_source_disasm_command, show_data)
2969         (show_source_or_disasm_and_command): Update.
2970
2971 2019-06-25  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2974         parameter.  Return the new window.
2975         (show_source_disasm_command): Update and remove NULL check.
2976         (show_source_or_disasm_and_command): Update.
2977
2978 2019-06-25  Tom Tromey  <tom@tromey.com>
2979
2980         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2981
2982 2019-06-25  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-data.h (struct tui_win_info): Make constructor
2985         protected.  Make destructor virtual.  Add initializers.
2986         (tui_source_window, tui_data_window, tui_cmd_window): New
2987         classes.
2988         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2989         constructor.  Add "type" parameter.
2990         (tui_source_window, tui_data_window, tui_cmd_window): New
2991         constructors.
2992         (tui_alloc_win_info): Instantiate the appropriate subclass.
2993
2994 2019-06-25  Tom Tromey  <tom@tromey.com>
2995
2996         * tui/tui-win.c (tui_resize_all): Use delete.
2997         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2998         destructor.
2999         (tui_free_window): Don't declare.
3000         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3001         Update.
3002
3003 2019-06-25  Tom Tromey  <tom@tromey.com>
3004
3005         * tui/tui-data.h (struct tui_win_info): Add constructor.
3006         * tui/tui-data.c (tui_alloc_win_info): Use new.
3007         (tui_free_window): Use delete.
3008
3009 2019-06-22  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3012         declare.
3013         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3014
3015 2019-06-22  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3018         declare.
3019         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3020
3021 2019-06-22  Tom de Vries  <tdevries@suse.de>
3022
3023         * dwarf2read.c (create_addrmap_from_aranges)
3024         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3025         instead of '%zu'.
3026
3027 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3028
3029         * dwarf2read.h (dwarf2_section_info_def): Remove.
3030         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3031         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3032         std::vector<dwarf2_section_info>.
3033         (struct dwo_file) <~dwo_file>: Remove.
3034         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3035         types field.
3036         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3037         (dwarf2_read_debug_names): Likewise.
3038         (create_debug_types_hash_table): Change parameter type to
3039         array_view, adjust code accordingly.
3040         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3041         (partial_die_info::fixup): Likewise.
3042         (determine_prefix): Likewise.
3043         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3044
3045 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3046
3047         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3048         gdb_bfd_ref_ptr.
3049         <~dwo_file>: Remove call to gdb_bfd_unref.
3050         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3051         gdb_bfd_ref_ptr::get.
3052
3053 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3054
3055         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3056         type to htab_up.
3057         * dwarf2read.c (struct dwo_file): Initialize fields.
3058         <~dwo_file>: New.
3059         (free_dwo_file): Remove, move content to ~dwo_file.
3060         (struct dwo_file_deleter): Remove.
3061         (dwo_file_up>: Remove custom deleter.
3062         (free_dwo_files): Remove.
3063         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3064         dwo_files.
3065         (process_skeletonless_type_units): Call unique_ptr::get.
3066         (allocate_dwo_file_hash_table): Add deleter to created hash
3067         table.  Change return type to htab_up.
3068         (lookup_dwo_file_slot): Don't memset dwo_file, call
3069         unique_ptr::get.
3070         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3071         (create_dwo_unit_in_dwp_v2): Likewise.
3072         (open_and_init_dwo_file): Likewise.
3073         (free_dwo_file_from_slot): Remove.
3074
3075 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3076
3077         * dwarf2read.h (struct dwarf2_section_info) <readin,
3078         is_virtual>: Change type to bool.
3079         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3080         true instead of 1.
3081
3082 2019-06-19  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-data.h (tui_init_content_element): Don't declare.
3085
3086 2019-06-19  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-data.h (tui_init_win_info): Don't declare.
3089
3090 2019-06-19  Tom de Vries  <tdevries@suse.de>
3091
3092         * dwarf2read.h (abstract_to_concrete): Change type to
3093         std::unordered_map<sect_offset, std::vector<sect_offset>,
3094         gdb::hash_enum<sect_offset>>.
3095
3096 2019-06-19  Tom Tromey  <tromey@adacore.com>
3097
3098         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3099         EVAL_AVOID_SIDE_EFFECTS specially.
3100
3101 2019-06-19  Tom Tromey  <tromey@adacore.com>
3102
3103         * source-cache.c (highlighter): New global.
3104         (source_cache::get_source_lines): Create a highlighter on demand.
3105
3106 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3107
3108         * defs.h (deprecated_interactive_hook): Delete declaration.
3109         * interps.c (clear_interpreter_hooks): Remove use of
3110         deprecated_interactive_hook.
3111         * top.c (deprecated_interactive_hook): Delete definition.
3112         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3113
3114 2019-06-18  Tom de Vries  <tdevries@suse.de>
3115
3116         PR gdb/24515
3117         * dwarf2read.h (abstract_to_concrete): Change type from
3118         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3119         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3120         * dwarf2read.c (read_variable): Update.
3121         (dwarf2_fetch_die_loc_sect_off): Update.
3122
3123 2019-06-17  Tom de Vries  <tdevries@suse.de>
3124
3125         PR gdb/24617
3126         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3127         accessing parent[parent_len - 1].
3128
3129 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3130
3131         PR gdb/24364
3132         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3133         call dtrace_process_dof with NULL dof.
3134
3135 2019-06-16  Tom de Vries  <tdevries@suse.de>
3136
3137         PR gdb/24445
3138         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3139
3140 2019-06-16  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3143         (make_all_visible): Use address of member.
3144
3145 2019-06-16  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3148         (tui_free_window, free_content, free_content_elements): Remove
3149         unnecessary cast.
3150         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3151         cast.
3152         * tui/tui-regs.c (tui_show_register_group)
3153         (tui_display_registers_from, tui_display_reg_element_at_line):
3154         Remove unnecessary cast.
3155
3156 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * linux-nat.c (normal_mask): Delete.
3159         (_initialize_linux_nat): Don't initialise normal_mask.
3160
3161 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3162
3163         PR gdb/24445
3164         * dwarf-index-write.h (write_psymtabs_to_index): Add
3165         dwz_basename parameter.
3166         * dwarf-index-write.c (write_gdbindex): Move file writing to
3167         write_gdbindex_1.  Change return type void.
3168         (assert_file_size): Move up, remove filename parameter.
3169         (write_gdbindex_1): New function.
3170         (write_debug_names): Change return type to void, call
3171         assert_file_size.
3172         (struct index_wip_file): New struct.
3173         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3174         file logic to index_wip_file.  Write index for dwz file if
3175         needed.
3176         (save_gdb_index_command): Pass basename of dwz file, if present.
3177         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3178         build-id of dwz file, if present.
3179         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3180         (dwarf2_get_dwz_file): Likewise.
3181         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3182         (dwarf2_get_dwz_file): Likewise.
3183
3184 2019-06-16  Tom Tromey  <tom@tromey.com>
3185
3186         * coffread.c (process_coff_symbol): Use xstrdup.
3187         * value.c (create_internalvar): Use xstrdup.
3188
3189 2019-06-16  Tom Tromey  <tom@tromey.com>
3190
3191         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3192         * breakpoint.c (stopin_command, stopat_command)
3193         (until_break_command, decode_location_default): Remove unnecessary
3194         cast.
3195         * utils.c (subset_compare): Remove unnecessary cast.
3196         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3197         cast.
3198         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3199         cast.
3200         * infcmd.c (path_command): Remove unnecessary cast.
3201         * coffread.c (decode_type): Remove unnecessary cast.
3202         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3203         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3204         * tui/tui-stack.c (tui_show_locator_content)
3205         (tui_show_frame_info): Remove unnecessary cast.
3206         * tui/tui-win.c (tui_scroll_forward_command)
3207         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3208         (parse_scrolling_args): Remove unnecessary cast.
3209         * tui/tui-data.c (init_win_info, tui_del_window)
3210         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3211         (free_content_elements): Remove unnecessary cast.
3212         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3213         unnecessary cast.
3214         * tui/tui-source.c (tui_set_source_content)
3215         (tui_vertical_source_scroll): Remove unnecessary cast.
3216         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3217         cast.
3218         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3219         * tui/tui-regs.c (tui_display_registers_from)
3220         (tui_display_register): Remove unnecessary cast.
3221         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3222         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3223         (make_visible): Remove unnecessary cast.
3224         * tui/tui-winsource.c (tui_erase_source_content)
3225         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3226         unnecessary cast.
3227         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3228         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3229         * stabsread.c (read_type, read_array_type, read_range_type):
3230         Remove unnecessary cast.
3231         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3232         (parse_symbol, parse_type, upgrade_type, parse_external)
3233         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3234         unnecessary cast.
3235         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3236
3237 2019-06-16  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-data.c (tui_alloc_generic_win_info)
3240         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3241         checks.
3242
3243 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3244             Andrew Burgess  <andrew.burgess@embecosm.com>
3245
3246         * f-typeprint.c (f_print_type): Don't return early for not
3247         associated or not allocated types.
3248         (f_type_print_varspec_suffix): Add print_rank parameter and print
3249         ranks of array types in case they dangling.
3250         (f_type_print_base): Add print_rank parameter.
3251
3252 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * NEWS: Mention new MI commands.
3255         * break-catch-throw.c (enum exception_event_kind): Move to
3256         breakpoint.h.
3257         (print_mention_exception_catchpoint): Output text as a single
3258         message.
3259         (catch_exception_command_1): Rename to...
3260         (catch_exception_event): ...this, make non-static, update header
3261         command, and change some parameter types.
3262         (catch_catch_command): Update for changes to
3263         catch_exception_command_1.
3264         (catch_throw_command): Likewise.
3265         (catch_rethrow_command): Likewise.
3266         * breakpoint.c (enum exception_event_kind): Delete.
3267         * breakpoint.h (enum exception_event_kind): Moved here from
3268         break-catch-throw.c.
3269         (catch_exception_event): Declare.
3270         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3271         (mi_cmd_catch_throw): New function.
3272         (mi_cmd_catch_rethrow): New function.
3273         (mi_cmd_catch_catch): New function.
3274         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3275         'catch-catch' entries.
3276         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3277         (mi_cmd_catch_rethrow): Declare.
3278         (mi_cmd_catch_catch): Declare.
3279
3280 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3281
3282         * annotate.c (annotate_source_line): Change return type to void,
3283         update implementation to match.
3284         * annotate.h (annotate_source_line): Change return type to void,
3285         update header comment.
3286         * stack.c (print_frame_info): Don't change what frame information
3287         is printed based on whether annotations are on or not.
3288
3289 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3290
3291         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3292         (annotate_source): Make static.
3293         (annotate_source_line): Moved from source.c and renamed from
3294         identify_source_line.  Update the return type.
3295         * annotate.h (annotate_source): Delete declaration.
3296         (annotate_source_line): Declaration moved from source.h, and
3297         renamed from identify_source_line.  Return type updated.
3298         * source.c (identify_source_line): Moved to annotate.c and renamed
3299         to annotate_source_line.
3300         (info_line_command): Remove check of annotation_level.
3301         * source.h (identify_source_line): Move declaration to annotate.h
3302         and rename to annotate_source_line.
3303         * stack.c: Add 'annotate.h' include.
3304         (print_frame_info): Remove check of annotation_level before
3305         calling annotate_source_line.
3306
3307 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         * source-cache.c (source_cache::get_plain_source_lines): Use
3310         open_source_file_with_line_charpos instead of just
3311         open_source_file, remove call to find_source_lines.
3312         (source_cache::get_source_lines): Likewise.
3313         * source.c (find_source_lines): Make static.
3314         (get_filename_and_charpos): Renamed into...
3315         (open_source_file_with_line_charpos): ..this along with changes to
3316         return a scoped_fd, and some other minor clean ups.
3317         (identify_source_line): Use open_source_file_with_line_charpos.
3318         (search_command_helper): Use open_source_file_with_line_charpos
3319         instead of just open_source_file, remove call to
3320         find_source_lines.
3321         * source.h (open_source_file_with_line_charpos): Declare new
3322         function.
3323         (find_source_lines): Delete declaration.
3324
3325 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3326
3327         * source.c (get_filename_and_charpos): Remove fullname
3328         parameter.
3329         (identify_source_line): Update call to get_filename_and_charpos.
3330
3331 2019-06-14  Tom Tromey  <tromey@adacore.com>
3332
3333         PR gdb/24502:
3334         * ui-style.h (skip_ansi_escape): Update comment.
3335         * ui-file.h (class no_terminal_escape_file): New class.
3336         * ui-file.c (no_terminal_escape_file::write)
3337         (no_terminal_escape_file::puts): New methods.
3338         * cli/cli-logging.c (handle_redirections): Use
3339         no_terminal_escape_file.
3340
3341 2019-06-14  Tom Tromey  <tromey@adacore.com>
3342
3343         * NEWS: Move convenience variable news above Python news.
3344
3345 2019-06-14  Tom Tromey  <tom@tromey.com>
3346
3347         * gnulib: Move directory to top-level.
3348         * configure.ac: Don't configure gnulib.
3349         * configure: Rebuild.
3350         * common/common-defs.h: Use new path to gnulib.
3351         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3352         (GNULIB_H): Remove.
3353         (INCGNU): Look in new gnulib location.
3354         (HFILES_NO_SRCDIR): Remove gnulib files.
3355         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3356         (generated_files): Remove GNULIB_H.
3357         ($(LIBGNU), all-lib): Remove targets.
3358         (distclean): Don't mention GNULIB_BUILDDIR.
3359         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3360
3361 2019-06-14  Tom Tromey  <tromey@adacore.com>
3362
3363         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3364         Warn if symbol file does not provide any symbols.
3365
3366 2019-06-14  Tom Tromey  <tromey@adacore.com>
3367
3368         * source.c (find_and_open_source): Respect basenames_may_differ.
3369
3370 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3371
3372         * annotate.c (annotate_breakpoints_invalid): Make use of
3373         scoped_restore_terminal_state.
3374         (annotate_frames_invalid): Likewise.
3375
3376 2019-06-14  Tom Tromey  <tromey@adacore.com>
3377
3378         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3379         allow assignment to an internalvar.
3380
3381 2019-06-14  Tom Tromey  <tromey@adacore.com>
3382
3383         * ada-lex.l: Allow "_" in attribute names.
3384
3385 2019-06-14  Tom Tromey  <tromey@adacore.com>
3386
3387         PR gdb/24653:
3388         * regcache.c (registers_changed): Don't call alloca.
3389         * top.c (execute_command): Don't call alloca.
3390
3391 2019-06-13  Pedro Alves  <palves@redhat.com>
3392
3393         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3394         'expression'.  When parsing an expression, error out if there's
3395         junk after "unlimited".
3396         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3397         (do_set_command): Adjust calls to is_unlimited_literal.
3398
3399 2019-06-13  Pedro Alves  <palves@redhat.com>
3400
3401         * compile/compile.c (make_compile_options_def_group): Add braces
3402         around array_view initializer.
3403         * thread.c (make_thread_apply_all_options_def_group)
3404         (make_thread_apply_all_options_def_group): Likewise.
3405
3406 2019-06-13  Pedro Alves  <palves@redhat.com>
3407
3408         * NEWS (New commands): Mention "maint test-options
3409         require-delimiter", "maint test-options unknown-is-error", "maint
3410         test-options unknown-is-operand" and "maint show
3411         test-options-completion-result".
3412         (New command options, command completion): New section.
3413         (Completion improvements): New section.
3414         Mention that you can abbreviate "unlimited".
3415
3416 2019-06-13  Pedro Alves  <palves@redhat.com>
3417
3418         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3419         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3420         * unittests/cli-utils-selftests.c (test_parse_flags)
3421         (test_parse_flags_qcs): Delete.
3422         (test_cli_utils): Don't call deleted functions.
3423
3424 2019-06-13  Pedro Alves  <palves@redhat.com>
3425
3426         * thread.c: Include "cli/cli-option.h".
3427         (tp_array_compar_ascending): Global.
3428         (tp_array_compar): Delete function.
3429         (tp_array_compar_ascending, tp_array_compar_descending): New
3430         functions.
3431         (ascending_option_def, qcs_flag_option_def)
3432         (thr_qcs_flags_option_defs)
3433         (make_thread_apply_all_options_def_group)
3434         (make_thread_apply_options_def_group): New.
3435         (thread_apply_all_command): Use gdb::option::process_options.
3436         (thread_apply_command_completer)
3437         (thread_apply_all_command_completer): New.
3438         (thread_apply_command): Use gdb::option::process_options.
3439         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3440         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3441         to generate help text of "thread apply".  Adjust "taas"'s help.
3442         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3443         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3444
3445 2019-06-13  Pedro Alves  <palves@redhat.com>
3446
3447         * thread.c (thread_apply_command): Check for invalid TID with
3448         isdigit instead of !isalpha.
3449
3450 2019-06-13  Pedro Alves  <palves@redhat.com>
3451
3452         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3453         (validate_flags_qcs): New.
3454         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3455         (validate_flags_qcs): Declare.
3456         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3457         (make_frame_apply_options_def_group): New.
3458         (frame_apply_command_count): Process options with
3459         gdb::option::process_options.
3460         (frame_apply_completer): New.
3461         (frame_apply_level_completer, frame_apply_all_completer)
3462         (frame_apply_completer): New.
3463         (_initialize_stack): Update help of "frame apply", "frame apply
3464         level", "frame apply all" and "faas" to mention supported options
3465         and install command completers.
3466         * stack.h (frame_apply_all_completer): Declare.
3467         * thread.c: Include "stack.h".
3468         (tfaas_command): Add "--".
3469         (_initialize_thread): Update help "tfaas" to mention supported
3470         options and install command completer.
3471
3472 2019-06-13  Pedro Alves  <palves@redhat.com>
3473
3474         * completer.c (complete_nested_command_line): New.
3475         (gdb_completion_word_break_characters_throw): Add assertion.
3476         * completer.h (complete_nested_command_line): Declare.
3477
3478 2019-06-13  Pedro Alves  <palves@redhat.com>
3479
3480         * stack.c (parse_backtrace_qualifiers): New.
3481         (backtrace_command): Use it.
3482         (backtrace_command_completer): Complete on qualifiers.
3483
3484 2019-06-13  Pedro Alves  <palves@redhat.com>
3485
3486         * frame.c: Include "cli/cli-option.h.
3487         (user_set_backtrace_options): New.
3488         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3489         Delete.
3490         (get_prev_frame): Adjust.
3491         (boolean_option_def, uinteger_option_def)
3492         (set_backtrace_option_defs): New.
3493         (_initialize_frame): Adjust and use
3494         gdb::option::add_setshow_cmds_for_options to install "set
3495         backtrace past-main" and "set backtrace past-entry".
3496         * frame.h: Include "cli/cli-option.h".
3497         (struct frame_print_options): Forward declare.
3498         (print_frame_arguments_all, print_frame_arguments_scalars)
3499         (print_frame_arguments_none): Declare.
3500         (print_entry_values): Delete declaration.
3501         (struct frame_print_options, user_frame_print_options): New.
3502         (struct set_backtrace_options): New.
3503         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3504         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3505         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3506         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3507         (list_args_or_locals): Add frame_print_options parameter.
3508         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3509         * python/py-framefilter.c (enumerate_args): Pass down
3510         USER_FRAME_PRINT_OPTIONS.
3511         * stack.c: Include "cli/cli-option.h".
3512         (print_frame_arguments_all, print_frame_arguments_scalars)
3513         (print_frame_arguments_none): Declare.
3514         (print_raw_frame_arguments, print_entry_values): Delete.
3515         (user_frame_print_options): New.
3516         (boolean_option_def, enum_option_def, frame_print_option_defs):
3517         New.
3518         (struct backtrace_cmd_options): New.
3519         (bt_flag_option_def): New.
3520         (backtrace_command_option_defs): New.
3521         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3522         (print_frame_arg, read_frame_arg, print_frame_args)
3523         (print_frame_info, print_frame): Add frame_print_options parameter
3524         and use it.
3525         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3526         (backtrace_command_1): Add frame_print_options and
3527         backtrace_cmd_options parameters and use them.
3528         (make_backtrace_options_def_group): New.
3529         (backtrace_command): Process command options with
3530         gdb::option::process_options.
3531         (backtrace_command_completer): New.
3532         (_initialize_stack): Extend "backtrace"'s help to mention
3533         supported options.  Install completer for "backtrace".
3534         Install some settings commands with add_setshow_cmds_for_options.
3535
3536 2019-06-13  Pedro Alves  <palves@redhat.com>
3537
3538         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3539         and that "set/show print raw frame-arguments" are now deprecated.
3540
3541         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3542         command.
3543         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3544         * stack.c (_initialize_stack): Install "set/show print
3545         raw-frame-arguments", and deprecate "set/show print raw
3546         frame-arguments".
3547         * valprint.c (_initialize_valprint): Deprecate "set/show print
3548         raw".
3549
3550 2019-06-13  Pedro Alves  <palves@redhat.com>
3551
3552         * compile/compile.c (struct compile_options): New.
3553         (compile_flag_option_def, compile_command_option_defs)
3554         (make_compile_options_def_group): New.
3555         (compile_file_command): Handle options with
3556         gdb::option::process_options.
3557         (compile_file_command_completer): New function.
3558         (compile_code_command): Handle options with
3559         gdb::option::process_options.
3560         (compile_code_command_completer): New function.
3561         (_initialize_compiler): Install completers for "compile code" and
3562         "compile file".  Mention available options in "compile code" and
3563         "compile code"'s help.
3564         * completer.c (advance_to_completion_word): New, factored out from
3565         ...
3566         (advance_to_expression_complete_word_point): ... this.
3567         (advance_to_filename_complete_word_point): New.
3568         * completer.h (advance_to_filename_complete_word_point): New
3569         declaration.
3570
3571 2019-06-13  Pedro Alves  <palves@redhat.com>
3572
3573         * compile/compile.c: Include "cli/cli-option.h".
3574         (compile_print_value): Scope data pointer is now a
3575         value_print_options pointer; adjust.
3576         (compile_print_command): Process options.  Scope data pointer is
3577         now a value_print_options pointer; adjust.
3578         (_initialize_compile): Update "compile print"'s help to include
3579         supported options.  Install a completer for "compile print".
3580         * cp-valprint.c (show_vtblprint, show_objectprint)
3581         (show_static_field_print): Delete.
3582         (_initialize_cp_valprint): Don't install "set print
3583         static-members", "set print vtbl", "set print object" here.
3584         * printcmd.c: Include "cli/cli-option.h" and
3585         "common/gdb_optional.h".
3586         (print_command_parse_format): Rework to fill in a
3587         value_print_options instead of a format_data.
3588         (print_value): Change parameter type from format_data pointer to
3589         value_print_options reference.  Adjust.
3590         (print_command_1): Process options.  Adjust to pass down a
3591         value_print_options.
3592         (print_command_completer): New.
3593         (_initialize_printcmd): Install print_command_completer as
3594         handle_brkchars completer for the "print" command.  Update
3595         "print"'s help to include supported options.
3596         * valprint.c: Include "cli/cli-option.h".
3597         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3598         here from cp-valprint.c.
3599         (boolean_option_def, uinteger_option_def)
3600         (value_print_option_defs, make_value_print_options_def_group):
3601         New.  Use gdb::option::add_setshow_cmds_for_options to install
3602         "set print elements", "set print null-stop", "set print repeats",
3603         "set print pretty", "set print union", "set print array", "set
3604         print address", "set print symbol", "set print array-indexes".
3605         * valprint.h: Include <string> and "cli/cli-option.h".
3606         (make_value_print_options_def_group): Declare.
3607         (print_value): Change parameter type from format_data pointer to
3608         value_print_options reference.
3609         (print_command_completer): Declare.
3610
3611 2019-06-13  Pedro Alves  <palves@redhat.com>
3612
3613         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3614         (COMMON_SFILES): Add maint-test-settings.c.
3615         * cli/cli-decode.c (boolean_enums): New global, factored out from
3616         ...
3617         (add_setshow_boolean_cmd): ... here.
3618         * cli/cli-decode.h (boolean_enums): Declare.
3619         * cli/cli-option.c: New file.
3620         * cli/cli-option.h: New file.
3621         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3622         factored out from ...
3623         (parse_cli_boolean_value(const char *)): ... this.
3624         (is_unlimited_literal): Change parameter type to pointer to
3625         pointer.  Adjust and advance ARG pointer.
3626         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3627         (parse_cli_var_enum): New, factored out from ...
3628         (do_set_command): ... this.  Adjust.
3629         * cli/cli-setshow.h (parse_cli_boolean_value)
3630         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3631         (parse_cli_var_enum): Declare.
3632         * cli/cli-utils.c: Include "cli/cli-option.h".
3633         (get_ulongest): New.
3634         * cli/cli-utils.h (get_ulongest): Declare.
3635         (check_for_argument): New overloads.
3636         * maint-test-options.c: New file.
3637
3638 2019-06-13  Pedro Alves  <palves@redhat.com>
3639
3640         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3641         parse a range if "-" is at the end of the string.
3642
3643 2019-06-13  Pedro Alves  <palves@redhat.com>
3644
3645         * cli/cli-setshow.c (parse_auto_binary_operation)
3646         (parse_cli_boolean_value): Don't allow "o".
3647
3648 2019-06-13  Pedro Alves  <palves@redhat.com>
3649
3650         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3651         * NEWS: Mention maint test-settings KIND.
3652         * maint-test-settings.c: New file.
3653
3654 2019-06-13  Pedro Alves  <palves@redhat.com>
3655
3656         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3657         completer.
3658         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3659         "set" completers.
3660
3661 2019-06-13  Pedro Alves  <palves@redhat.com>
3662
3663         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3664         after item.
3665
3666 2019-06-13  Pedro Alves  <palves@redhat.com>
3667
3668         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3669
3670 2019-06-13  Pedro Alves <palves@redhat.com>
3671
3672         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3673         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3674         call.
3675         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3676         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3677         calls.
3678         (check_for_argument): Skip spaces after argument.
3679
3680 2019-06-13  Pedro Alves  <palves@redhat.com>
3681
3682         * thread.c (thread_apply_command): Adjust TID parsing.
3683         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3684         detected before end of string.
3685         (tid_is_in_list): Error out if LIST is invalid.
3686
3687 2019-06-13  Pedro Alves  <palves@redhat.com>
3688
3689         * completer.c (complete_line_internal_1): Rewind completion word
3690         point.
3691         (completion_tracker::advance_custom_word_point_by): Change
3692         parameter type to int.
3693         * completer.h (completion_tracker::advance_custom_word_point_by):
3694         Likewise.
3695
3696 2019-06-13  Pedro Alves  <palves@redhat.com>
3697
3698         * completer.c (advance_to_completion_word): Handle delimiters.
3699
3700 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3701
3702         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3703
3704 2019-06-11  Tom Tromey  <tom@tromey.com>
3705
3706         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3707         (xmalloc_failed): Move to alloc.c.
3708         * alloc.c: New file.
3709         * Makefile.in (COMMON_SFILES): Add alloc.c.
3710
3711 2019-06-11  Tom Tromey  <tom@tromey.com>
3712
3713         * nat/linux-waitpid.c: Don't include server.h.
3714         (linux_debug): Remove.
3715         (my_waitpid): Update.
3716
3717 2019-06-11  Tom Tromey  <tromey@adacore.com>
3718
3719         * infcall.c (_initialize_infcall): Remove trailing newline from
3720         help.
3721         * user-regs.c (_initialize_user_regs): Remove trailing newline
3722         from help.
3723         * typeprint.c (_initialize_typeprint): Remove trailing newline
3724         from help.
3725         * reverse.c (_initialize_reverse): Remove trailing newlines from
3726         help.
3727         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3728         from help.
3729         * language.c (add_set_language_command): Remove trailing newline
3730         from help.
3731         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3732         help.
3733         * disasm.c (_initialize_disasm): Remove trailing newline from
3734         help.
3735         * top.c (init_main): Remove trailing newline from help.
3736         * interps.c (_initialize_interpreter): Remove trailing newline
3737         from help.
3738         * btrace.c (_initialize_btrace): Remove trailing newlines from
3739         help.
3740         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3741         from help.
3742         * python/python.c (_initialize_python): Remove trailing newline
3743         from help.
3744         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3745         help.
3746         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3747         from help.  Reformat some text.
3748         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3749         from help.
3750         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3751         newline from help.
3752
3753 2019-06-11  Tom Tromey  <tromey@adacore.com>
3754
3755         * darwin-nat.c (darwin_decode_exception_message)
3756         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3757
3758 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         * valops.c (value_slice): Check for not allocated or not
3761         associated values.
3762
3763 2019-06-10  Tom de Vries  <tdevries@suse.de>
3764
3765         PR gdb/24618
3766         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3767         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3768         invalid.
3769
3770 2019-06-10  Tom de Vries  <tdevries@suse.de>
3771
3772         PR gdb/24611
3773         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3774         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3775
3776 2019-06-10  Tom de Vries  <tdevries@suse.de>
3777
3778         PR symtab/24545
3779         * symtab.c (struct demangled_name_entry): Add language field.
3780         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3781         static minimal symbol".  Set and use language field.
3782
3783 2019-06-10  Tom Tromey  <tromey@adacore.com>
3784
3785         * ada-lang.c (_initialize_ada_language): Update help text.
3786
3787 2019-06-10  Tom Tromey  <tromey@adacore.com>
3788
3789         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3790         with a newline.
3791         * guile/guile.c (handle_boot_error): Don't end warning with a
3792         newline.
3793         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3794         warning with a newline.
3795         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3796         newline.
3797         (s12z_frame_cache): Likewise.
3798         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3799         a newline.
3800         * solib-svr4.c (disable_probes_interface): Don't end warning with
3801         a newline.
3802         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3803         newline.
3804         * python/python.c (do_finish_initialization): Don't end warning
3805         with a newline.
3806
3807 2019-06-10  Tom Tromey  <tom@tromey.com>
3808
3809         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3810         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3811         gdbpy_enter.
3812
3813 2019-06-10  Tom Tromey  <tromey@adacore.com>
3814
3815         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3816         data.
3817         (elf_new_init): Don't call stabsread_new_init.
3818         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3819         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3820         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3821
3822 2019-06-10  Tom de Vries  <tdevries@suse.de>
3823
3824         PR symtab/16264
3825         PR symtab/24517
3826         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3827
3828 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3829
3830         * source.c (find_and_open_source): Also rewrite relative file
3831         names.
3832
3833 2019-04-26  Amos Bird  <amosbird@gmail.com>
3834
3835         * annotate.c (annotate_thread_exited): Add "thread-exited"
3836         annotation.
3837
3838 2019-06-06  Tom Tromey  <tromey@adacore.com>
3839
3840         * maint.h (class scoped_command_stats): Use
3841         DISABLE_COPY_AND_ASSIGN.
3842         <print_time>: New method.
3843         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3844         print_time.
3845         (scoped_command_stats::print_time): New method.
3846
3847 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3850         instructions of lengths 6 or 8 bytes.
3851
3852 2019-06-04  Pedro Alves  <palves@redhat.com>
3853
3854         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3855
3856         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3857         * breakpoint.c (condition_completer): Likewise.
3858         * cli/cli-dump.c (scan_expression): Likewise.
3859         * common/filestuff.c (mkdir_recursive): Likewise.
3860         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3861         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3862         (gdb_abspath): Likewise.
3863         * compile/compile-cplus-types.c
3864         (compile_cplus_instance::decl_name): Likewise.
3865         * completer.c (complete_explicit_location):
3866         (signal_completer, reg_or_group_completer_1): Likewise.
3867         * cp-support.c (cp_remove_params_if_any): Likewise.
3868         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3869         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3870         * infcmd.c (strip_bg_char): Likewise.
3871         * linespec.c (copy_token_string): Likewise.
3872         * mi/mi-main.c (output_cores): Likewise.
3873         * psymtab.c (psymtab_search_name):
3874         * symfile.c (test_set_ext_lang_command): Likewise.
3875         * target.c (target_fileio_read_stralloc): Likewise.
3876         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3877         * value.c (complete_internalvar): Likewise.
3878
3879 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3880
3881         Add objfile property to gdb.Type.
3882         * NEWS: Mention Python API addition.
3883         * python/py-type.c (typy_get_objfile): New method.
3884
3885 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3886
3887         * NEWS: Mention the new set|show style [title|highlight].
3888         Mention changes to "show style", "help" and "apropos".
3889
3890 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3891
3892         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3893         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3894         instead of print_help_for_command.
3895         (print_doc_of_command): New function.
3896         (help_list): Add 'apropos -v word' suggestion.
3897         (print_help_for_command): Style the command name using title style.
3898         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3899         (_initialize_cli_cmds): Describe -v in apropos_command help.
3900
3901 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3902
3903         * cli/cli-style.h (cli_style_option): Add name in constructor,
3904         add m_name class member, add constructor with intensity,
3905         add name class function.
3906         (cli_style_option::add_setshow_commands): Remove name argument.
3907         (highlight_style, title_style): New styles.
3908         * cli/cli-style.c (do_show): New function that shows a style
3909         characteristic styling the style name with itself.
3910         (set_style_name): New function.
3911         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3912         Update all callers according to the changes in cli/cli-style.h.
3913         * utils.h (fputs_highlighted): New function.
3914         * utils.c (fputs_highlighted): Likewise.
3915
3916 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3917
3918         * NEWS: Mention new pipe command and new convenience variables.
3919
3920 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3921
3922         * cli/cli-cmds.c (pipe_command): New function.
3923         (_initialize_cli_cmds): Call add_com for pipe_command.
3924         Define | as an alias for pipe.
3925         (exit_status_set_internal_vars): New function.
3926         (shell_escape): Call exit_status_set_internal_vars.
3927         cli/cli-decode.c (find_command_name_length): Recognize | as
3928         a single character command.
3929
3930 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3931
3932         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3933         top.c (execute_command_to_ui_file): New function, mostly a copy
3934         of execute_command_to_string.
3935         (execute_command_to_string): Implement by calling
3936         execute_command_to_ui_file.
3937
3938 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3939
3940         * top.h (saved_command_line): Remove declaration.
3941         * top.c (previous_saved_command_line, previous_repeat_arguments):
3942         New variables.
3943         (saved_command_line): Make static, define together with other
3944         'repeat variables'.
3945         (dont_repeat): Clear repeat_arguments.
3946         (repeat_previous, get_saved_command_line, save_command_line):
3947         New functions.
3948         (gdb_init): Initialize saved_command_line
3949         and previous_saved_command_line.
3950         * main.c (captured_main_1): Remove saved_command_line initialization.
3951         * event-top.c (handle_line_of_input): Update to use
3952         the new 'repeat' related functions instead of direct access to
3953         saved_command_line.
3954         * command.h (repeat_previous, get_saved_command_line,
3955         save_command_line): New declarations.
3956         (dont_repeat): Add comment.
3957
3958 2019-05-30  Tom Tromey  <tromey@adacore.com>
3959
3960         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3961         Fix comment.
3962         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3963
3964 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3965
3966         PR cli/24587
3967         * completer.c (complete): Initialize variable word.
3968
3969 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3970
3971         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3972         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3973         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3974         'body' is NULL to the outter 'if', protecting the '!is_define'
3975         situation as well.
3976
3977 2019-05-29  Tom Tromey  <tromey@adacore.com>
3978
3979         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3980         (dwarf_unknown): New function.
3981         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3982         (dwarf_type_encoding_name): Use dwarf_unknown.
3983
3984 2019-05-29  Tom Tromey  <tromey@adacore.com>
3985
3986         PR c++/20020:
3987         * cp-valprint.c (cp_print_value_fields): Call
3988         cp_print_static_field inside "try".
3989
3990 2019-05-29  Tom Tromey  <tromey@adacore.com>
3991
3992         * inflow.c (struct terminal_info): Add default operator=.
3993         * configure: Rebuild.
3994         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3995         -Wdeprecated-copy-dtor, -Wredundant-move.
3996
3997 2019-05-29  Tom Tromey  <tromey@adacore.com>
3998
3999         * NEWS: Add entry.
4000         * infcmd.c (print_return_value_1): Handle finish_print
4001         option.
4002         (show_print_finish): New function.
4003         (_initialize_infcmd): Add "set/show print finish" commands.
4004         * valprint.c (user_print_options): Initialize new member.
4005         * valprint.h (struct value_print_options) <finish_print>: New
4006         member.
4007
4008 2019-05-28  Tom Tromey  <tromey@adacore.com>
4009
4010         * ada-lang.c (ada_remove_Xbn_suffix)
4011         (find_old_style_renaming_symbol)
4012         (parse_old_style_renaming): Remove.
4013         (ada_find_renaming_symbol): Don't call
4014         find_old_style_renaming_symbol.
4015         (ada_is_renaming_symbol): Rename from
4016         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4017         bool.  Now static.
4018         (ada_read_var_value): Update and simplify.
4019         * ada-exp.y (write_var_or_type): Remove old code.
4020
4021 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4022
4023         * event-top.c: Remove include comment.
4024         * inflow.c (class scoped_ignore_sigttou): Move from here...
4025         * inflow.h (class scoped_ignore_sigttou): ...to here.
4026         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4027         * top.c:  Remove include comment.
4028
4029 2019-05-27  Tom Tromey  <tom@tromey.com>
4030
4031         * NEWS: Fix typo.
4032
4033 2019-05-22  Tom Tromey  <tromey@adacore.com>
4034
4035         * target.c (target_follow_exec): Constify parameter.
4036         * target-delegates.c: Rebuild.
4037         * remote.c (remote_target::follow_exec): Constify parameter.
4038         * infrun.c (follow_exec): Constify parameter.
4039         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4040         (target_follow_exec): Likewise.
4041
4042 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4043
4044         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4045         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4046
4047 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4048
4049         * NEWS: Add debugredirect and testsuite sections.
4050
4051 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4052
4053         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4054         target descriptions using exclusively floating point register name
4055         aliases.
4056
4057 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4058
4059         PR gdb/18644:
4060         * f-lang.c (build_fortran_types): Handle the case where
4061         gdbarch_floatformat_for_type returns a nullptr.
4062
4063 2019-05-21  Tom de Vries  <tdevries@suse.de>
4064
4065         PR cli/24587
4066         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4067
4068 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4069
4070         PR gdb/18644:
4071         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4072         16-byte floats.
4073         * i386-tdep.c (i386_floatformat_for_type): Use
4074         floatformats_ia64_quad for the 16-byte floating point component
4075         within a fortran 32-byte complex number.
4076
4077 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4078
4079         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4080         delete default constructor.
4081         (find_partial_die): Update to return const struct.
4082         (partial_die_parent_scope): Move variable declaration into scope
4083         of its use and change its type to auto.
4084         (guess_partial_die_structure_name): Likewise.
4085         (partial_die_info::fixup): Likewise.
4086
4087 2019-05-17  Tom Tromey  <tromey@adacore.com>
4088
4089         * source.c (find_and_open_source): Remove cast.
4090
4091 2019-05-17  Tom Tromey  <tromey@adacore.com>
4092
4093         * annotate.c (annotate_source): Make "filename" const.
4094         * annotate.h (annotate_source): Use const.
4095
4096 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4097
4098         * disasm.c (set_disassembler_options): Send errors to stderr.
4099
4100 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4101
4102         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4103         (cli_interp_base::set_logging): Check debug_redirect.
4104         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4105         * cli/cli-logging.c (debug_redirect): Add static variable.
4106         (pop_output_files): Add default param.
4107         (handle_redirections): Print debug setting.
4108         (show_logging_command): Likewise.
4109         (_initialize_cli_logging): Add debugredirect command.
4110         * interps.c (current_interp_set_logging): Add debug_redirect
4111         parameter.
4112         * interps.h (set_logging): Add debug_redirect parameter.
4113         (current_interp_set_logging): Likewise.
4114         * mi/mi-common.h: Likewise.
4115         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4116
4117 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4118             Tom Tromey  <tromey@adacore.com>
4119
4120         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4121         directly.
4122         * cli/cli-interp.h (make_logging_output): Remove declaration.
4123         * cli/cli-logging.c (make_logging_output): Remove function.
4124         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4125         directly.
4126         * ui-file.c (tee_file::tee_file): Remove bools.
4127         (tee_file::~tee_file): Remove deletes.
4128         * ui-file.h (tee_file): Remove bools.
4129
4130 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4131
4132         * mi/mi-cmds.h (mi_cmd_complete): New function.
4133         * mi/mi-main.c (mi_cmd_complete): Likewise.
4134         * mi/mi-cmds.c: Define new MI command -complete.
4135         * NEWS: Mention new -complete command.
4136
4137 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4138
4139         * completer.h (complete): New function.
4140         * completer.c (complete): Likewise.
4141         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4142         function defined in completer.h.
4143
4144 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4145
4146         * MAINTAINERS (Write After Approval): Add myself.
4147
4148 2019-05-17  Tom de Vries  <tdevries@suse.de>
4149
4150         PR gdb/24094
4151         * dwarf2read.c (struct cu_partial_die_info): New struct.
4152         (find_partial_die): Return cu_partial_die_info.
4153         (partial_die_parent_scope, guess_partial_die_structure_name)
4154         (partial_die_info::fixup): Handle new return type of find_partial_die.
4155
4156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4157
4158         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4159         "std::string", simplifying the algorithm.
4160
4161 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4162
4163         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4164         (stap_static_probe_ops::get_probes): Likewise.
4165
4166 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4167
4168         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4169         '-')" and "else if".
4170         (stap_parse_single_operand): Join checks for
4171         "gdbarch_stap_parse_special_token_p" and
4172         "gdbarch_stap_parse_special_token" in the same "if" statement.
4173         Invert check when verifying for operation on register
4174         displacement.
4175
4176 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4177
4178         * stap-probe.c (stap_get_opcode): Update comment.
4179         (stap_get_expected_argument_type): Likewise.
4180         (handle_stap_probe): Likewise.
4181
4182 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4183
4184         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4185         return type to 'bool'.  Adjust comment.  Use 'bool' when
4186         appropriate.
4187         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4188         * stap-probe.c (stap_parse_argument_1): Likewise.
4189         (stap_is_operator): Likewise.
4190         (stap_is_generic_prefix): Likewise.
4191         (stap_is_register_prefix): Likewise.
4192         (stap_is_register_indirection_prefix): Likewise.
4193         (stap_is_integer_prefix): Likewise.
4194         (stap_generic_check_suffix): Likewise.
4195         (stap_check_integer_suffix): Likewise.
4196         (stap_check_register_suffix): Likewise.
4197         (stap_check_register_indirection_suffix): Likewise.
4198         (stap_parse_register_operand): Likewise.
4199         (stap_parse_single_operand): Likewise.
4200         (stap_parse_argument_1): Likewise.
4201         (stap_probe::get_argument_count): Likewise.
4202         (stap_is_operator): Likewise.
4203
4204 2019-05-16  Tom Tromey  <tromey@adacore.com>
4205
4206         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4207         keyword to foreach.
4208
4209 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4210
4211         * linux-thread-db.c (try_thread_db_load_1): Change return type
4212         to bool.
4213         (try_thread_db_load): Likewise.
4214         (try_thread_db_load_from_pdir_1): Likewise.
4215         (try_thread_db_load_from_pdir): Likewise.
4216         (try_thread_db_load_from_sdir): Likewise.
4217         (try_thread_db_load_from_dir): Likewise.
4218         (thread_db_load_search): Likewise.
4219         (has_libpthread): Likewise.
4220         (thread_db_load): Likewise.
4221
4222 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4223
4224         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4225         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4226         NULL, and complain/return if that's the case.
4227
4228 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4229
4230         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4231         (advance, posn, abstract_read_memory): New functions.
4232         [struct mem_read_abstraction]: New struct.
4233         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4234
4235 2019-05-14  Tom Tromey  <tromey@adacore.com>
4236
4237         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4238         value is not lval_memory.
4239
4240 2019-05-14  Tom Tromey  <tromey@adacore.com>
4241
4242         * solib.c (info_sharedlibrary_command): Style the file name.
4243
4244 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4245
4246         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4247         (aarch64_vnv_type): Likewise.
4248         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4249         * common/tdesc.c: Likewise.
4250         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4251         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4252         * features/aarch64-fpu.xml: Add ieee half view.
4253         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4254         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4255         * gdbtypes.h (struct builtin_type): Likewise.
4256         (struct objfile_type): Likewise.
4257
4258 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4259
4260         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4261         typo.
4262         * location.h (string_to_event_location): Likewise.
4263
4264 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4265
4266         GDB 8.3 released.
4267
4268 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4269
4270         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4271         New variable declaration.
4272         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4273         New variable.
4274         (print_one_breakpoint): Use ui_out::test_flags and new global
4275         variable to compute use_fixed_output.
4276         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4277         Remove.
4278         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4279         (mi_multi_location_breakpoint_output_fixed): Remove.
4280         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4281         new variable.
4282         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4283         fix_multi_location_breakpoint_output flag if version >= 3.
4284         * ui-out.h (enum ui_out_flag)
4285         <fix_multi_location_breakpoint_output>: New enumerator.
4286
4287 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4288
4289         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4290
4291 2019-05-10  Tom Tromey  <tromey@adacore.com>
4292
4293         * ada-lang.c (catch_ada_completer): New function.
4294         (_initialize_ada_language): Use it.
4295
4296 2019-05-10  Tom Tromey  <tromey@adacore.com>
4297
4298         * thread.c (print_thread_info): Make "requested_threads" const.
4299         * gdbthread.h (print_thread_info): Make "requested_threads"
4300         const.
4301         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4302         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4303
4304 2019-05-08  Tom Tromey  <tom@tromey.com>
4305
4306         * gdbtypes.c (objfile_type_data): Change type.
4307         (objfile_type, _initialize_gdbtypes): Update.
4308
4309 2019-05-08  Tom Tromey  <tom@tromey.com>
4310
4311         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4312         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4313         (_initialize_dwarf2_frame): Update.
4314
4315 2019-05-08  Tom Tromey  <tom@tromey.com>
4316
4317         * objc-lang.c (objc_objfile_data): Change type.
4318         (find_methods): Update.
4319         (_initialize_objc_lang): Remove.
4320
4321 2019-05-08  Tom Tromey  <tom@tromey.com>
4322
4323         * stabsread.c (rs6000_builtin_type_data): Change type.
4324         (rs6000_builtin_type, _initialize_stabsread): Update.
4325
4326 2019-05-08  Tom Tromey  <tom@tromey.com>
4327
4328         * mips-tdep.c (mips_pdr_data): Remove.
4329         (_initialize_mips_tdep): Update.
4330
4331 2019-05-08  Tom Tromey  <tom@tromey.com>
4332
4333         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4334         (hppa_init_objfile_priv_data, read_unwind_info)
4335         (find_unwind_entry, _initialize_hppa_tdep): Update.
4336
4337 2019-05-08  Tom Tromey  <tom@tromey.com>
4338
4339         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4340         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4341         on obstack.
4342         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4343
4344 2019-05-08  Tom Tromey  <tom@tromey.com>
4345
4346         * mdebugread.c (basic_type_data): Change type.
4347         (basic_type, _initialize_mdebugread): Update.
4348
4349 2019-05-08  Tom Tromey  <tom@tromey.com>
4350
4351         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4352
4353 2019-05-08  Tom Tromey  <tom@tromey.com>
4354
4355         * nto-tdep.c (nto_inferior_data_reg): Change type.
4356         (nto_inferior_data): Update.
4357         (nto_inferior_data_cleanup, nto_new_inferior_data)
4358         (_initialize_nto_tdep): Remove.
4359         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4360
4361 2019-05-08  Tom Tromey  <tom@tromey.com>
4362
4363         * ada-lang.c (struct ada_inferior_data): Add initializers.
4364         (ada_inferior_data): Change type.
4365         (ada_inferior_data_cleanup): Remove.
4366         (get_ada_inferior_data, ada_inferior_exit)
4367         (struct ada_pspace_data): Add initializers, destructor.
4368         (ada_pspace_data_handle): Change type.
4369         (get_ada_pspace_data): Update.
4370         (ada_pspace_data_cleanup): Remove.
4371
4372 2019-05-08  Tom Tromey  <tom@tromey.com>
4373
4374         * coffread.c (struct coff_symfile_info): Add initializers.
4375         (coff_objfile_data_key): Move lower.  Change type.
4376         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4377         Update.
4378         (coff_free_info): Remove.
4379
4380 2019-05-08  Tom Tromey  <tom@tromey.com>
4381
4382         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4383         (fbsd_pspace_data_handle): Move lower.  Change type.
4384         (get_fbsd_pspace_data): Update.
4385         (fbsd_pspace_data_cleanup): Remove.
4386         (_initialize_fbsd_tdep): Update.
4387
4388 2019-05-08  Tom Tromey  <tom@tromey.com>
4389
4390         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4391         (get_ada_tasks_pspace_data): Update.
4392         (ada_tasks_pspace_data_cleanup): Remove.
4393         (_initialize_tasks): Update.
4394         (ada_tasks_inferior_data_handle): Change type.
4395         (get_ada_tasks_inferior_data): Update.
4396         (ada_tasks_inferior_data_cleanup): Remove.
4397         (struct ada_tasks_pspace_data): Add initializers.
4398
4399 2019-05-08  Tom Tromey  <tom@tromey.com>
4400
4401         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4402         * symfile-debug.c (debug_sym_get_probes): Change type.
4403         * stap-probe.c (handle_stap_probe):
4404         (stap_static_probe_ops::get_probes): Change type.
4405         * probe.h (class static_probe_ops) <get_probes>: Change type.
4406         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4407         (parse_probes_in_pspace): Update.
4408         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4409         Update.
4410         (any_static_probe_ops::get_probes): Change type.
4411         * elfread.c (elfread_data): New typedef.
4412         (probe_key): Change type.
4413         (elf_get_probes): Likewise.  Update.
4414         (probe_key_free): Remove.
4415         (_initialize_elfread): Update.
4416         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4417         Change type.
4418         (dtrace_process_dof_probe, dtrace_process_dof)
4419         (dtrace_static_probe_ops::get_probe): Change type.
4420
4421 2019-05-08  Tom Tromey  <tom@tromey.com>
4422
4423         * xcoffread.c (struct xcoff_symfile_info): Rename from
4424         coff_symfile_info.  Add initializers.
4425         (xcoff_objfile_data_key): Move lower.  Change type.
4426         (XCOFF_DATA): Rewrite.
4427         (xcoff_free_info): Remove.
4428         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4429         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4430         (xcoff_initial_scan): Update.
4431
4432 2019-05-08  Tom Tromey  <tom@tromey.com>
4433
4434         * solib-svr4.c (struct svr4_info): Add initializers and
4435         destructor.
4436         <probes_table>: Now an htab_up.
4437         (solib_svr4_pspace_data): Change type.
4438         (free_probes_table): Simplify.
4439         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4440         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4441         (probes_table_remove_objfile_probes, register_solib_event_probe)
4442         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4443         (_initialize_svr4_solib): Update.
4444
4445 2019-05-08  Tom Tromey  <tom@tromey.com>
4446
4447         * remote.c (remote_pspace_data): Change type.
4448         (remote_pspace_data_cleanup): Remove.
4449         (get_remote_exec_file, set_pspace_remote_exec_file)
4450         (_initialize_remote): Update.
4451
4452 2019-05-08  Tom Tromey  <tom@tromey.com>
4453
4454         * breakpoint.c (breakpoint_objfile_key): Change type.
4455         (get_breakpoint_objfile_data): Update.
4456         (free_breakpoint_objfile_data): Remove.
4457         (_initialize_breakpoint): Update.
4458
4459 2019-05-08  Tom Tromey  <tom@tromey.com>
4460
4461         * linux-tdep.c (struct linux_info): Add initializers.
4462         (linux_inferior_data): Move.  Change type.
4463         (invalidate_linux_cache_inf): Update.
4464         (linux_inferior_data_cleanup): Remove.
4465         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4466
4467 2019-05-08  Tom Tromey  <tom@tromey.com>
4468
4469         * auxv.c (auxv_inferior_data): Move.  Change type.
4470         (auxv_inferior_data_cleanup): Remove.
4471         (invalidate_auxv_cache_inf): Rewrite.
4472         (get_auxv_inferior_data, _initialize_auxv): Update.
4473
4474 2019-05-08  Tom Tromey  <tom@tromey.com>
4475
4476         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4477         (symfile_debug_objfile_data_key): Change type.
4478         (symfile_debug_installed, debug_qf_has_symbols)
4479         (debug_qf_find_last_source_symtab)
4480         (debug_qf_forget_cached_source_info)
4481         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4482         (debug_qf_print_stats, debug_qf_dump)
4483         (debug_qf_expand_symtabs_for_function)
4484         (debug_qf_expand_all_symtabs)
4485         (debug_qf_expand_symtabs_with_fullname)
4486         (debug_qf_map_matching_symbols)
4487         (debug_qf_expand_symtabs_matching)
4488         (debug_qf_find_pc_sect_compunit_symtab)
4489         (debug_qf_map_symbol_filenames)
4490         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4491         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4492         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4493         (debug_sym_read_linetable, debug_sym_relocate): Update.
4494         (symfile_debug_free_objfile): Remove.
4495         (install_symfile_debug_logging, _initialize_symfile_debug):
4496         Update.
4497
4498 2019-05-08  Tom Tromey  <tom@tromey.com>
4499
4500         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4501         allocate_on_obstack.
4502         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4503         (get_dwarf2_per_objfile): Update.
4504         (set_dwarf2_per_objfile): Remove.
4505         (dwarf2_has_info, dwarf2_get_section_info): Update.
4506         (dwarf2_free_objfile): Remove.
4507         (_initialize_dwarf2_read): Update.
4508
4509 2019-05-08  Tom Tromey  <tom@tromey.com>
4510
4511         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4512         initializers.
4513         <unsupported_script_warning_printed,
4514         script_not_found_warning_printed>: Now bool.
4515         (auto_load_pspace_data): Change type.
4516         (~auto_load_pspace_info): Rename from
4517         auto_load_pspace_data_cleanup.
4518         (get_auto_load_pspace_data, init_loaded_scripts_info)
4519         (clear_section_scripts, maybe_print_unsupported_script_warning)
4520         (maybe_print_script_not_found_warning, _initialize_auto_load):
4521         Update.
4522
4523 2019-05-08  Tom Tromey  <tom@tromey.com>
4524
4525         * objfiles.c (objfile_pspace_info): Add destructor and
4526         initializers.
4527         (objfiles_pspace_data): Change type.
4528         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4529         (get_objfile_pspace_data): Update.
4530         (objfiles_bfd_data): Change type.
4531         (get_objfile_bfd_data): Update.
4532         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4533
4534 2019-05-08  Tom Tromey  <tom@tromey.com>
4535
4536         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4537         Change type.
4538         (get_catch_syscall_inferior_data): Update.
4539         (catch_syscall_inferior_data_cleanup): Remove.
4540         (_initialize_break_catch_syscall): Update.
4541
4542 2019-05-08  Tom Tromey  <tom@tromey.com>
4543
4544         * inflow.c (struct terminal_info): Add destructor and
4545         initializers.
4546         (inflow_inferior_data): Change type.
4547         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4548         (get_inflow_inferior_data, inflow_inferior_exit)
4549         (swap_terminal_info, _initialize_inflow): Update.
4550
4551 2019-05-08  Tom Tromey  <tom@tromey.com>
4552
4553         * target-dcache.c (target_dcache_cleanup): Remove.
4554         (target_dcache_aspace_key): Change type.
4555         (target_dcache_init_p, target_dcache_invalidate)
4556         (target_dcache_get, target_dcache_get_or_init)
4557         (_initialize_target_dcache): Update.
4558         * dcache.h (struct dcache_deleter): New.
4559
4560 2019-05-08  Tom Tromey  <tom@tromey.com>
4561
4562         * symtab.c (struct symbol_cache): Add destructor and
4563         initializers.
4564         (symbol_cache_key): Move.  Change type.
4565         (make_symbol_cache, free_symbol_cache): Remove.
4566         (get_symbol_cache): Update.
4567         (symbol_cache_cleanup): Remove.
4568         (ALL_PSPACES, symbol_cache_flush)
4569         (maintenance_print_symbol_cache)
4570         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4571         Update.
4572
4573 2019-05-08  Tom Tromey  <tom@tromey.com>
4574
4575         * symtab.c (struct main_info): Add destructor and initializers.
4576         (main_progspace_key): Move.  Change type.
4577         (get_main_info): Update.
4578         (main_info_cleanup): Remove.
4579         (_initialize_symtab): Update.
4580
4581 2019-05-08  Tom Tromey  <tom@tromey.com>
4582
4583         * registry.h (DECLARE_REGISTRY): Define the _key class.
4584
4585 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * NEWS: Merge two 'New commands' sections.
4588
4589 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4590
4591         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4592         parameter and use Ada language definition instead.
4593         (ada_val_print_ptr): Remove unused language parameter.
4594         (ada_val_print_num): Remove language parameter and use Ada language
4595         definition instead.
4596         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4597         parameter.
4598         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4599         parameter and use Ada language definition instead.
4600         (ada_val_print_1): Update all ada_val_print_xxx calls.
4601         Remove language parameter.
4602         (ada_val_print): Update ada_val_print_1 call.
4603
4604 2019-05-08  Tom Tromey  <tromey@adacore.com>
4605
4606         * remote.c (remote_hw_watchpoint_limit)
4607         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4608         Now static.
4609
4610 2019-05-08  Tom Tromey  <tromey@adacore.com>
4611
4612         * maint.c (_initialize_maint_cmds): Move initialization code to
4613         remote.c.
4614         (watchdog, show_watchdog): Move to remote.c.
4615         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4616         "watchdog" static.
4617         (_initialize_remote): Move initialization code from maint.c.
4618         * defs.h (watchdog): Don't declare.
4619
4620 2019-05-08  Tom Tromey  <tromey@adacore.com>
4621
4622         * tui/tui-interp.c: Include main.h.
4623         * interps.c: Include main.h.
4624         * main.h (interpreter_p): Declare.
4625         * defs.h (interpreter_p): Don't declare.
4626
4627 2019-05-08  Tom Tromey  <tromey@adacore.com>
4628
4629         * dwarf2loc.c: Include dwarf2read.h.
4630         * defs.h (read_unsigned_leb128): Don't declare.
4631         * dwarf2read.h (read_unsigned_leb128): Declare.
4632
4633 2019-05-08  Tom Tromey  <tromey@adacore.com>
4634
4635         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4636         method.
4637
4638 2019-05-08  Tom Tromey  <tromey@adacore.com>
4639
4640         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4641         when no wrap column is set.
4642
4643 2019-05-08  Tom Tromey  <tromey@adacore.com>
4644
4645         * c-lang.c (c_get_string): Handle non-C-style arrays.
4646
4647 2019-05-08  Tom Tromey  <tromey@adacore.com>
4648
4649         * typeprint.c (print_offset_data::update): Print the bit offset,
4650         not the number of bits remaining.
4651
4652 2019-05-08  Tom Tromey  <tromey@adacore.com>
4653
4654         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4655         padding at end of comment.
4656
4657 2019-05-08  Tom Tromey  <tromey@adacore.com>
4658
4659         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4660         Compare main types.
4661
4662 2019-05-06  Tom Tromey  <tom@tromey.com>
4663
4664         * common/scoped_mmap.c: Include common-defs.h.
4665         * common/scoped_mmap.h: Don't include config.h.
4666
4667 2019-05-04  Tom Tromey  <tom@tromey.com>
4668
4669         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4670         (struct aarch64_call_info): Add initializers.
4671         <si>: Now a std::vector.
4672         (pass_on_stack, aarch64_push_dummy_call): Update.
4673
4674 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4675             Tom Tromey  <tom@tromey.com>
4676
4677         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4678         (ppc_threads): Now a std::vector.  Now static.
4679         (hwdebug_find_thread_points_by_tid)
4680         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4681         Update.
4682
4683 2019-05-04  Tom Tromey  <tom@tromey.com>
4684
4685         * arc-tdep.c (arc_tdesc_init): Return bool.
4686
4687 2019-05-04  Tom Tromey  <tom@tromey.com>
4688
4689         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4690         Use gdb_assert_not_reached.
4691
4692 2019-05-04  Tom Tromey  <tom@tromey.com>
4693
4694         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4695         "false".
4696
4697 2019-05-04  Tom Tromey  <tom@tromey.com>
4698
4699         * arc-tdep.c (arc_tdesc_init): Use bool.
4700
4701 2019-05-04  Tom Tromey  <tom@tromey.com>
4702
4703         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4704
4705 2019-05-04  Tom Tromey  <tom@tromey.com>
4706
4707         * cli/cli-cmds.c (valid_command_p): Return bool.
4708
4709 2019-05-04  Tom Tromey  <tom@tromey.com>
4710
4711         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4712         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4713
4714 2019-05-04  Raul Tambre  <raul@tambre.ee>
4715
4716         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4717         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4718         operator for comparison.
4719
4720 2019-05-04  Tom Tromey  <tom@tromey.com>
4721
4722         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4723         (lookup_partial_symbol, print_partial_symbols)
4724         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4725         (psymbol_compare): Update.
4726         (add_psymbol_to_bcache): Clear the entire psymbol.
4727         (maintenance_check_psymtabs): Update.
4728         * psympriv.h (struct partial_symbol): Don't derive from
4729         general_symbol_info.
4730         <obj_section, unrelocated_address, address,
4731         set_unrelocated_address>: Update.
4732         <ginfo>: New member.
4733         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4734         (debug_names::write_psymbols): Update.
4735
4736 2019-05-04  Tom de Vries  <tdevries@suse.de>
4737
4738         * contrib/cc-with-tweaks.sh: Support -n arg.
4739
4740 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4741
4742         * corelow.c (core_target::detach): Ensure frame cache and
4743         register caches are cleared.
4744         inferior.c (exit_inferior_1): Likewise.
4745
4746 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4747             Tom Tromey  <tom@tromey.com>
4748
4749         * dictionary.c (collate_pending_symbols_by_language): Remove
4750         "struct" from foreach.
4751         * symtab.c (lookup_global_symbol_from_objfile)
4752         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4753         foreach.
4754         * ser-tcp.c (net_open): Remove "struct" from foreach.
4755         * objfiles.c (objfile_relocate, objfile_rebase)
4756         (objfile_has_symbols): Remove "struct" from foreach.
4757         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4758         from foreach.
4759         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4760         foreach.
4761         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4762         "struct" from foreach.
4763         * ada-lang.c (create_excep_cond_exprs)
4764         (ada_exception_catchpoint_cond_string): Remove "struct" from
4765         foreach.
4766
4767 2019-05-03  Tom Tromey  <tromey@adacore.com>
4768
4769         * ada-exp.y (convert_char_literal): Check suffix of each
4770         enumerator.
4771
4772 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4773
4774         PR ada/21406:
4775         * ada-exp.y (yywrap): Don't define.
4776         * ada-lex.l (%option): Add noyywrap
4777         (yywrap): Remove.
4778
4779 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4780
4781         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4782         _WIN32_WINNT to the XP level, unless already defined to a higher
4783         level.
4784
4785         * unittests/parse-connection-spec-selftests.c:
4786         * ser-tcp.c:
4787         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4788         override.
4789
4790         * symfile.c (find_separate_debug_file): Remove colon from the
4791         drive spec of DOS/Windows file names of the target, so that the
4792         file name produced from DEBUGDIR and the target's directory will
4793         be valid on DOS/Windows systems.
4794
4795 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4796
4797         * rust-lang.c (val_print_struct): Handle printing structures
4798         containing strings.
4799
4800 2019-05-02  Tom Tromey  <tromey@adacore.com>
4801
4802         * valarith.c (_initialize_valarith): Remove.
4803
4804 2019-05-01  Tom Tromey  <tromey@adacore.com>
4805
4806         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4807         bitfields.
4808
4809 2019-05-01  Tom Tromey  <tromey@adacore.com>
4810
4811         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4812         for big-endian copies.
4813
4814 2019-04-30  Ali Tamur  <tamur@google.com>
4815         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4816         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4817         (read_3_bytes): New function.
4818
4819 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4820
4821         * windows-nat.c (main_thread_id): Delete.
4822         (handle_output_debug_string): Replace main_thread_id by
4823         current_event.dwThreadId.
4824         (fake_create_process): Likewise.
4825         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4826         Do not set main_thread_id.
4827         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4828         current_event.dwThreadId.
4829         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4830
4831 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4832
4833         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4834         Use current_event.dwThreadId instead of main_thread_id.
4835
4836 2019-04-30  Tom Tromey  <tromey@adacore.com>
4837
4838         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4839         (create_excep_cond_exprs): Iterate over program spaces.
4840         (ada_exception_catchpoint_cond_string): Examine all minimal
4841         symbols for exception types.
4842
4843 2019-04-30  Tom Tromey  <tromey@adacore.com>
4844
4845         PR c++/24470:
4846         * dwarf2read.c (process_structure_scope): Handle case where type
4847         has template parameters but no symbol was created.
4848
4849 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4850             Chris January  <chris.january@arm.com>
4851
4852         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4853         qualifier.
4854         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4855
4856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4857
4858         * f-typeprint.c (f_print_type): Update rules for printing
4859         whitespace.
4860         (f_type_print_varspec_suffix): Likewise.
4861
4862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4863             Chris January  <chris.january@arm.com>
4864
4865         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4866         function arguments.
4867
4868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4869
4870         * f-lang.c (build_fortran_types): Change name of void type to
4871         lower case.
4872         * f-typeprint.c (f_type_print_base): Print the name of the void
4873         type, rather than a fixed string.
4874         * f-valprint.c (f_decorations): Use lower case void string.
4875
4876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4877             Chris January  <chris.january@arm.com>
4878
4879         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4880         types for Fortran.
4881
4882 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4883             Chris January  <chris.january@arm.com>
4884             David Lecomber  <david.lecomber@arm.com>
4885
4886         * f-exp.y (BINOP_INTRINSIC): New token.
4887         (exp): New parser rule handling BINOP_INTRINSIC.
4888         (f77_keywords): Add new builtin procedures.
4889         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4890         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4891         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4892         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4893         (print_unop_subexp_f): New function.
4894         (print_binop_subexp_f): New function.
4895         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4896         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4897         (dump_subexp_body_f): Likewise.
4898         (operator_check_f): Likewise.
4899         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4900         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4901
4902 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4905         UNOP_KIND.
4906         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4907         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4908         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4909         (operator_length_f): New fuction.
4910         (print_subexp_f): New function.
4911         (op_name_f): New function.
4912         (dump_subexp_body_f): New function.
4913         (operator_check_f): New function.
4914         (exp_descriptor_f): Replace standard expression handling functions
4915         with new functions.
4916         * gdb/fortran-operator.def: New file.
4917         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4918         * gdb/std-operator.def: Remove UNOP_KIND.
4919
4920 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * std-operator.def: Remove unbalanced, stray double quote
4923         character.
4924
4925 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4926             Chris January  <chris.january@arm.com>
4927             Daniel Everett  <daniel.everett@arm.com>
4928             Nick Forrington  <nick.forrington@arm.com>
4929             Richard Bunt  <richard.bunt@arm.com>
4930
4931         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4932         of depth when printing anonymous structs or unions.
4933         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4934         Don't print either the top-level value, or the children if the
4935         max-depth is exceeded.
4936         (ppscm_print_children): When printing the key of a map, allow one
4937         extra level of depth.
4938         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4939         print either the top-level value, or the children if the max-depth
4940         is exceeded.
4941         (print_children): When printing the key of a map, allow one extra
4942         level of depth.
4943         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4944         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4945         (user_print_options): Initialise max_depth field.
4946         (val_print_scalar_or_string_type_p): New function.
4947         (val_print): Check to see if the max depth has been reached.
4948         (val_print_check_max_depth): Define new function.
4949         (show_print_max_depth): New function.
4950         (_initialize_valprint): Add 'print max-depth' option.
4951         * valprint.h (struct value_print_options) <max_depth>: New field.
4952         (val_print_check_max_depth): Declare new function.
4953         * NEWS: Document new feature.
4954
4955 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * ada-lang.c (ada_language_defn): Initialise new field.
4958         * c-lang.c (c_is_string_type_p): New function.
4959         (c_language_defn): Initialise new field.
4960         (cplus_language_defn): Initialise new field.
4961         (asm_language_defn): Initialise new field.
4962         (minimal_language_defn): Initialise new field.
4963         * c-lang.h (c_is_string_type_p): Declare new function.
4964         * d-lang.c (d_language_defn): Initialise new field.
4965         * f-lang.c (f_is_string_type_p): New function.
4966         (f_language_defn): Initialise new field.
4967         * go-lang.c (go_is_string_type_p): New function.
4968         (go_language_defn): Initialise new field.
4969         * language.c (default_is_string_type_p): New function.
4970         (unknown_language_defn): Initialise new field.
4971         (auto_language_defn): Initialise new field.
4972         * language.h (struct language_defn) <la_is_string_type_p>: New
4973         member variable.
4974         (default_is_string_type_p): Declare new function.
4975         * m2-lang.c (m2_language_defn): Initialise new field.
4976         * objc-lang.c (objc_language_defn): Initialise new field.
4977         * opencl-lang.c (opencl_language_defn): Initialise new field.
4978         * p-lang.c (pascal_is_string_type_p): New function.
4979         (pascal_language_defn): Initialise new field.
4980         * rust-lang.c (rust_is_string_type_p): New function.
4981         (rust_language_defn): Initialise new field.
4982
4983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4984
4985         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4986         New field.
4987         * ada-lang.c (ada_language_defn): Initialise new field.
4988         * c-lang.c (c_language_defn): Likewise.
4989         (cplus_language_defn): Likewise.
4990         (asm_language_defn): Likewise.
4991         (minimal_language_defn): Likewise.
4992         * d-lang.c (d_language_defn): Likewise.
4993         * f-lang.c (f_language_defn): Likewise.
4994         * go-lang.c (go_language_defn): Likewise.
4995         * language.c (unknown_language_defn): Likewise.
4996         (auto_language_defn): Likewise.
4997         * m2-lang.c (m2_language_defn): Likewise.
4998         * objc-lang.c (objc_language_defn): Likewise.
4999         * opencl-lang.c (opencl_language_defn): Likewise.
5000         * p-lang.c (pascal_language_defn): Likewise.
5001         * rust-lang.c (rust_language_defn): Likewise.
5002
5003 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5004
5005         * ada-lang.c (ada_is_character_type): Change return type to bool.
5006         (ada_is_string_type): Likewise.
5007         * ada-lang.h (ada_is_character_type): Update declaration
5008         (ada_is_string_type): Likewise.
5009
5010 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5011
5012         Support style in 'frame|thread apply'
5013
5014         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5015         * record.c (record_start, record_stop): Update callers of
5016         execute_command_to_string with false.
5017         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5018         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5019         methods.
5020         (class string_file): New constructor with term_out parameter.
5021         Override methods term_out and can_emit_style_escape.  New member
5022         term_out.
5023         (class stdio_file): Override can_emit_style_escape.
5024         (class tee_file): Override term_out and can_emit_style_escape.
5025         * utils.h (can_emit_style_escape): Remove.
5026         * utils.c (can_emit_style_escape): Likewise.
5027         Update all callers of can_emit_style_escape (SOMESTREAM) to
5028         SOMESTREAM->can_emit_style_escape.
5029         * source-cache.c (source_cache::get_source_lines): Likewise.
5030         * stack.c (frame_apply_command_count): Call execute_command_to_string
5031         passing the term_out characteristic of the current gdb_stdout.
5032         * thread.c (thr_try_catch_cmd): Likewise.
5033         * top.c (execute_command_to_string): pass term_out parameter
5034         to construct the string_file for the command output.
5035         * ui-file.c (term_cli_styling): New function (most code moved
5036         from utils.c can_emit_style_escape).
5037         (string_file::string_file, string_file::can_emit_style_escape,
5038         stdio_file::can_emit_style_escape, tee_file::term_out,
5039         tee_file::can_emit_style_escape): New functions.
5040
5041 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5042
5043         * NEWS: Mention the new set|show may-call-functions.
5044         * infcall.c (may_call_functions_p): New variable.
5045         (show_may_call_functions_p): New function.
5046         (call_function_by_hand_dummy): Throws an error if not
5047         may-call-functions.
5048         (_initialize_infcall): Call add_setshow_boolean_cmd for
5049         may-call-functions.
5050
5051 2019-04-25  Keith Seitz  <keiths@redhat.com>
5052
5053         PR c++/24367
5054         * cp-support.c (inspect_type): Don't attempt substitutions
5055         of symbol with the same name.
5056
5057 2019-04-25  Tom Tromey  <tromey@adacore.com>
5058
5059         PR gdb/24475:
5060         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5061         static.
5062
5063 2019-04-25  Tom Tromey  <tromey@adacore.com>
5064
5065         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5066         rvalue reference.
5067         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5068         (gdb_xml_parser::parse): Use std::move.
5069         * python/python-internal.h (gdbpy_convert_exception): Take a const
5070         reference.
5071         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5072         std::move.
5073         * python/py-utils.c (gdbpy_convert_exception): Take a const
5074         reference.
5075         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5076         Use std::move.
5077         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5078         Use std::move.
5079         * mi/mi-main.c (mi_print_exception): Take a const reference.
5080         * main.c (handle_command_errors): Take a const reference.
5081         * linespec.c (parse_linespec): Use std::move.
5082         * infcall.c (run_inferior_call): Use std::move.
5083         (call_function_by_hand_dummy): Use std::move.
5084         * exec.c (try_open_exec_file): Use std::move.
5085         * exceptions.h (exception_print, exception_fprintf)
5086         (exception_print_same): Update.
5087         * exceptions.c (print_exception, exception_print)
5088         (exception_fprintf, exception_print_same): Change parameters to
5089         const reference.
5090         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5091         * common/new-op.c: Use std::move.
5092         * common/common-exceptions.h (struct gdb_exception): Add move
5093         constructor.
5094         (struct gdb_exception_error, struct gdb_exception_quit, struct
5095         gdb_quit_bad_alloc): Change constructor to move constructor.
5096         (throw_exception): Change parameter to rvalue reference.
5097         * common/common-exceptions.c (throw_exception): Take rvalue
5098         reference.
5099         * cli/cli-interp.c (safe_execute_command): Use std::move.
5100         * breakpoint.c (insert_bp_location, location_to_sals): Use
5101         std::move.
5102
5103 2019-04-25  Tom Tromey  <tromey@adacore.com>
5104
5105         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5106         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5107         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5108         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5109         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5110         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5111         guile/scm-value.c: Use unpack.
5112         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5113         gdbscm_gdb_exception.
5114         (gdbscm_throw_gdb_exception): Likewise.
5115         (struct gdbscm_gdb_exception): New.
5116         (unpack): New function.
5117         (gdbscm_wrap): Use unpack.
5118
5119 2019-04-25  Tom Tromey  <tromey@adacore.com>
5120
5121         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5122         (gdb_rl_callback_handler): Use std::move.
5123         * common/common-exceptions.h (struct gdb_exception): Add move
5124         assignment operator.
5125         (throw_exception_sjlj): Change "exception" to const reference.
5126         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5127         (throw_exception_sjlj): Change "exception" to const reference.
5128
5129 2019-04-25  Tom Tromey  <tromey@adacore.com>
5130
5131         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5132         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5133         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5134         Update.
5135         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5136         Update.
5137         * mi/mi-interp.c (mi_interp::exec): Update.
5138         * linespec.c (parse_linespec): Update.
5139         * infcall.c (run_inferior_call): Update.
5140         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5141         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5142         (gdbscm_lookup_global_symbol): Update.
5143         * guile/scm-param.c (gdbscm_parameter_value): Update.
5144         * guile/scm-frame.c (gdbscm_frame_read_register)
5145         (gdbscm_frame_read_var): Update.
5146         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5147         * exec.c (try_open_exec_file): Update.
5148         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5149         (gdb_rl_callback_handler): Update.
5150         * common/common-exceptions.h (exception_none): Don't declare.
5151         * common/common-exceptions.c (exception_none): Don't define.
5152         (struct catcher) <exception>: Update.
5153         * cli/cli-interp.c (safe_execute_command): Update.
5154         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5155
5156 2019-04-25  Ali Tamur  <tamur@google.com>
5157
5158         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5159         (read_attribute_value): Likewise.
5160         (dwarf2_read_addr_index): Update comment.
5161         (read_str_index): Add DW_FORM_strx.
5162         (dwarf2_string_attr): Likewise.
5163         (dwarf2_const_value_attr): Likewise.
5164         (dump_die_shallow): Likewise.
5165         (dwarf2_fetch_constant_bytes): Likewise.
5166         (skip_form_bytes): Likewise.
5167         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5168
5169 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5170
5171         PR corefiles/11608
5172         PR corefiles/18187
5173         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5174         OFFSET.  Verify if current mapping contains an ELF header.
5175         (linux_find_memory_regions_full): Adjust call to
5176         dump_mapping_p.
5177
5178 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5179             Kang Li <kanglictf@gmail.com>
5180
5181         PR gdb/21600
5182
5183         * dwarf2-frame.c (read_initial_length): Be consistent about using
5184         unsigned representation of length.
5185         (decode_frame_entry_1): Likewise.  Check for wraparound of
5186         end pointer as well as buffer overflow.
5187
5188 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5189
5190         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5191         "vq".
5192
5193 2019-04-24  Tom Tromey  <tromey@adacore.com>
5194
5195         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5196
5197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5198
5199         * s12z-tdep.c (s12z_unwind_pc): Delete.
5200         (s12z_unwind_sp): Delete.
5201         (s12z_gdbarch_init): Don't register deleted functions with
5202         gdbarch.
5203
5204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5205
5206         * rl78-tdep.c (rl78_unwind_sp): Delete.
5207         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5208
5209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5210
5211         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5212         (xstormy16_unwind_pc): Delete.
5213         (xstormy16_dummy_id): Delete.
5214         (xstormy16_gdbarch_init): Don't register deleted functions with
5215         gdbarch.
5216
5217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * vax-tdep.c (vax_unwind_pc): Delete.
5220         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5221
5222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * v850-tdep.c (v850_unwind_sp): Delete.
5225         (v850_unwind_pc): Delete.
5226         (v850_dummy_id): Delete.
5227         (v850_gdbarch_init): Don't register deleted functions with
5228         gdbarch.
5229
5230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5233         (tilegx_unwind_pc): Delete.
5234         (tilegx_unwind_dummy_id): Delete.
5235         (tilegx_gdbarch_init): Don't register deleted functions with
5236         gdbarch.
5237
5238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5239
5240         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5241         (tic6x_dummy_id): Delete.
5242         (tic6x_gdbarch_init): Don't register deleted functions with
5243         gdbarch.
5244
5245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * sparc-tdep.c (sparc_unwind_pc): Delete.
5248         (sparc32_gdbarch_init): Don't register deleted function with
5249         gdbarch.
5250
5251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * sh-tdep.c (sh_unwind_sp): Delete.
5254         (sh_unwind_pc): Delete.
5255         (sh_dummy_id): Delete.
5256         (sh_gdbarch_init): Don't register deleted functions with
5257         gdbarch.
5258
5259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5260
5261         * score-tdep.c (score_unwind_sp): Delete.
5262         (score_unwind_pc): Delete.
5263         (score_dummy_id): Delete.
5264         (score_gdbarch_init): Don't register deleted functions with
5265         gdbarch.
5266
5267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5268
5269         * rx-tdep.c (rx_unwind_pc): Delete.
5270         (rx_unwind_sp): Delete.
5271         (rx_dummy_id): Delete.
5272         (rx_gdbarch_init): Don't register deleted functions with
5273         gdbarch.  Update comment.
5274
5275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5276
5277         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5278         (rs6000_dummy_id): Delete.
5279         (rs6000_gdbarch_init): Don't register deleted functions with
5280         gdbarch.
5281
5282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5283
5284         * or1k-tdep.c (or1k_dummy_id): Delete.
5285         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5286
5287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * nios2-tdep.c (nios2_dummy_id): Delete.
5290         (nios2_unwind_sp): Delete.
5291         (nios2_gdbarch_init): Don't register deleted functions with
5292         gdbarch.
5293
5294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5295
5296         * nds32-tdep.c (nds32_dummy_id): Delete.
5297         (nds32_unwind_pc): Delete.
5298         (nds32_unwind_sp): Delete.
5299         (nds32_gdbarch_init): Don't register deleted functions with
5300         gdbarch.
5301
5302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5303
5304         * msp430-tdep.c (msp430_unwind_pc): Delete.
5305         (msp430_unwind_sp): Delete.
5306         (msp430_dummy_id): Delete.
5307         (msp430_gdbarch_init): Don't register deleted functions with
5308         gdbarch.
5309
5310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5311
5312         * moxie-tdep.c (moxie_unwind_sp): Delete.
5313         (moxie_unwind_pc): Delete.
5314         (moxie_dummy_id): Delete.
5315         (moxie_gdbarch_init): Don't register deleted functions with
5316         gdbarch.
5317
5318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5319
5320         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5321         (mn10300_unwind_pc): Delete.
5322         (mn10300_unwind_sp): Delete.
5323         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5324         mn10300_unwind_sp.
5325         (mn10300_frame_unwind_init): Don't register deleted functions with
5326         gdbarch.
5327
5328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5329
5330         * mep-tdep.c (mep_unwind_pc): Delete.
5331         (mep_unwind_sp): Delete.
5332         (mep_dummy_id): Delete.
5333         (mep_gdbarch_init): Don't register deleted functions with
5334         gdbarch.
5335
5336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5339         (m68hc11_unwind_sp): Delete.
5340         (m68hc11_gdbarch_init): Don't register deleted functions with
5341         gdbarch.
5342
5343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * m32r-tdep.c (m32r_unwind_sp): Delete.
5346         (m32r_unwind_pc): Delete.
5347         (m32r_dummy_id): Delete.
5348         (m32r_gdbarch_init): Don't register deleted functions with
5349         gdbarch.
5350
5351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5352
5353         * m32c-tdep.c (m32c_unwind_pc): Delete.
5354         (m32c_unwind_sp): Delete.
5355         (m32c_dummy_id): Delete.
5356         (m32c_gdbarch_init): Don't register deleted functions with
5357         gdbarch.
5358
5359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5362         (lm32_unwind_pc): Delete.
5363         (lm32_dummy_id): Delete.
5364         (lm32_gdbarch_init): Don't register deleted functions with
5365         gdbarch.
5366
5367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5370         (iq2000_unwind_pc): Delete.
5371         (iq2000_dummy_id): Delete.
5372         (iq2000_gdbarch_init): Don't register deleted functions with
5373         gdbarch.
5374
5375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * nds32-tdep.c (nds32_type_align): Delete.
5378         (nds32_push_dummy_call): Use type_align instead.
5379
5380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5381
5382         * arm-tdep.c (arm_type_align): Only handle vector override case.
5383         (arm_push_dummy_call): Use type_align.
5384         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5385
5386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5387
5388         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5389         case.
5390         (pass_on_stack): Use type_align.
5391         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5392         function.
5393
5394 2019-04-23  Tom Tromey  <tromey@adacore.com>
5395
5396         * dwarf2read.c (line_header::file_name_at): Remove unused
5397         overload.
5398
5399 2019-04-23  Tom de Vries  <tdevries@suse.de>
5400
5401         PR gdb/24438
5402         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5403         invocation.
5404
5405
5406 2019-03-27  Ali Tamur  <tamur@google.com>
5407
5408         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5409         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5410         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5411         (dwarf_expr_context::get_addr_index): Likewise
5412         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5413         (symbol_needs_eval_context::get_addr_index): Likewise
5414         (disassemble_dwarf_expression): Add DW_OP_addrx
5415         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5416         (read_cutu_die_from_dwo): Update comment
5417         (skip_one_die): Add DW_FORM_addrx
5418         (read_attribute_value): Likewise
5419         (var_decode_location): Add DW_OP_addrx
5420         (dwarf2_const_value_attr): Add DW_FORM_addrx
5421         (dump_die_shallow): Likewise
5422         (dwarf2_fetch_constant_bytes): Likewise
5423         (decode_locdesc): Add DW_OP_addrx
5424         (skip_form_bytes): Add DW_FORM_addrx
5425
5426 2019-04-22  Ali Tamur  <tamur@google.com>
5427
5428         * MAINTAINERS (Write After Approval): Add self.
5429
5430 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5431
5432         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5433         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5434         (open_symbol_file_object): Likewise.
5435         (svr4_default_sos): Add info parameter.
5436         (svr4_read_so_list): Likewise.
5437         (svr4_current_sos_direct): Adjust functions calls to pass down
5438         info.
5439         (svr4_current_sos_1): Add info parameter.
5440         (svr4_current_sos): Call get_svr4_info, pass info down to
5441         svr4_current_sos_1.
5442         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5443         get_svr4_info.
5444         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5445         get_svr4_info.
5446         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5447         to get_svr4_info.
5448         (probes_table_remove_objfile_probes): Likewise.
5449         (register_solib_event_probe): Add info parameter.
5450         (solist_update_incremental): Pass info parameter down to
5451         svr4_read_so_list.
5452         (disable_probes_interface): Add info parameter.
5453         (svr4_handle_solib_event): Pass current_program_space to
5454         get_svr4_info.  Adjust disable_probes_interface cleanup.
5455         (svr4_create_probe_breakpoints): Add info parameter, pass it
5456         down to register_solib_event_probe.
5457         (svr4_create_solib_event_breakpoints): Add info parameter,
5458         pass it down to svr4_create_probe_breakpoints.
5459         (enable_break): Pass info down to
5460         svr4_create_solib_event_breakpoints.
5461         (svr4_solib_create_inferior_hook): Pass current_program_space to
5462         get_svr4_info.
5463         (svr4_clear_solib): Likewise.
5464
5465 2019-04-22  Pedro Alves  <palves@redhat.com>
5466
5467         * solib-svr4.c (svr4_free_objfile_observer): New.
5468         (probe_and_action::objfile): New field.
5469         (probes_table_htab_remove_objfile_probes)
5470         (probes_table_remove_objfile_probes): New functions.
5471         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5472         in the new probe_and_action.  Don't store the probe in 'lookup'.
5473         (svr4_create_probe_breakpoints): Pass objfile to
5474         register_solib_event_probe.
5475         (_initialize_svr4_solib): Register a free_objfile observer.
5476
5477 2019-04-19  Tom Tromey  <tom@tromey.com>
5478
5479         * common/queue.h: Remove.
5480
5481 2019-04-19  Tom Tromey  <tom@tromey.com>
5482
5483         * event-loop.c: Don't include "common/queue.h".
5484
5485 2019-04-19  Tom Tromey  <tom@tromey.com>
5486
5487         * remote.c (remote_target): Use delete.
5488         * remote-notif.h: Include <list>, not "common/queue.h".
5489         (notif_client_p): Remove typedef.
5490         (remote_notif_state): Add constructor, destructor, initializer.
5491         <notif_queue>: Now a std::list.
5492         (remote_notif_state_xfree): Don't declare.
5493         * remote-notif.c (remote_notif_process, handle_notification)
5494         (remote_notif_state_allocate): Update.
5495         (~remote_notif_state): Rename from remote_notif_state_xfree.
5496
5497 2019-04-19  Tom Tromey  <tom@tromey.com>
5498
5499         * symfile.c (reread_symbols): Update.
5500         * objfiles.c (objfile_register_static_link)
5501         (objfile_lookup_static_link): Update
5502         (~objfile) Don't delete static_links.
5503         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5504
5505 2019-04-19  Tom Tromey  <tom@tromey.com>
5506
5507         * type-stack.h (struct type_stack) <insert>: Constify string.
5508         * type-stack.c (type_stack::insert): Constify string.
5509         * gdbtypes.h (lookup_template_type): Update.
5510         (address_space_name_to_int): Update.
5511         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5512         const.
5513         (lookup_template_type): Make name const.
5514         * c-exp.y: Update rules.
5515         (lex_one_token, classify_name, classify_inner_name)
5516         (c_print_token): Update.
5517         * p-exp.y: Update rules.
5518         (yylex): Update.
5519         * f-exp.y: Update rules.
5520         (yylex): Update.
5521         * d-exp.y: Update rules.
5522         (lex_one_token, classify_name, classify_inner_name): Update.
5523         * parse.c (write_dollar_variable, copy_name): Return std::string.
5524         * parser-defs.h (copy_name): Change return type.
5525         * m2-exp.y: Update rules.
5526         (yylex): Update.
5527         * go-exp.y (lex_one_token): Update.
5528         Update rules.
5529         (classify_unsafe_function, classify_packaged_name)
5530         (classify_name, yylex): Update.
5531
5532 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5533
5534         * configure.ac: add --enable-source-highlight switch.
5535         * configure: Regenerate.
5536         * top.c (print_gdb_version): plumb --enable-source-highlight
5537         status to "show configuration".
5538
5539 2019-04-19  Tom Tromey  <tromey@adacore.com>
5540
5541         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5542         Check ADA_TYPE_P.
5543         (empty_record, ada_template_to_fixed_record_type_1)
5544         (template_to_static_fixed_type)
5545         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5546         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5547         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5548         macros.
5549
5550 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5551
5552         PR symtab/24423:
5553         * source.c (print_source_lines_base): Advance "iter" when a
5554         control character is seen.
5555
5556 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5557
5558         * inferior.h (struct infcall_suspend_state_deleter):
5559         Catch exception in destructor to avoid crash.
5560
5561 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5562
5563         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5564         close to the add_com "shell".
5565
5566 2019-04-18  Tom Tromey  <tromey@adacore.com>
5567
5568         * process-stratum-target.h (class process_stratum_target)
5569         <stratum>: Add "final".
5570
5571 2019-04-17  Tom Tromey  <tromey@adacore.com>
5572
5573         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5574         against nullptr before use.
5575
5576 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5577
5578         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5579
5580 2019-04-17  Jim Wilson  <jimw@sifive.com>
5581             Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5584         code read might fail, assume 4-byte breakpoint in that case.
5585
5586 2019-04-15  Leszek Swirski  <leszeks@google.com>
5587
5588         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5589         rather than a hand-rolled POD check when checking for forced MEMORY
5590         classification.
5591
5592 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5593
5594         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5595         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5596         function.
5597         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5598         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5599         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5600         declaration.
5601
5602 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5603
5604         * aarch64-linux-nat.c
5605         (aarch64_linux_nat_target::thread_architecture): Add override.
5606         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5607         each VQ.
5608
5609 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5610
5611         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5612
5613 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5616         target types of size 96-bits, add some additional comments, and
5617         check that the builtin type we found was the correct size.
5618
5619 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5620
5621         * utils.c (prompt_for_continue): Don't restore the styling at the
5622         end, as applied_style has the wrong value.  This fixes styling in
5623         long lists of file names that are interrupted by the "Continue?"
5624         prompt.
5625
5626 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5627
5628         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5629         * c-lang.c (c_language_defn): Likewise.
5630         (cplus_language_defn): Likewise.
5631         (asm_language_defn): Likewise.
5632         (minimal_language_defn): Likewise.
5633         * d-lang.c (d_language_defn): Likewise.
5634         * f-lang.c (f_language_defn): Likewise.
5635         * go-lang.c (go_language_defn): Likewise.
5636         * language.c (unknown_language_defn): Likewise.
5637         (auto_language_defn): Likewise.
5638         * language.h (struct language_defn): Remove la_magic field.
5639         (LANG_MAGIC): Delete.
5640         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5641         * objc-lang.c (objc_language_defn): Likewise.
5642         * opencl-lang.c (opencl_language_defn): Likewise.
5643         * p-lang.c (pascal_language_defn): Likewise.
5644         * rust-lang.c (rust_language_defn): Likewise.
5645
5646 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * riscv-tdep.c (riscv_type_align): New function.
5649         (riscv_type_alignment): Delete.
5650         (riscv_arg_location): Use 'type_align'.
5651         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5652
5653 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5654
5655         * gdbtypes.c (type_align): A struct with no non-static fields also
5656         has alignment of 1.
5657
5658 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5659
5660         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5661         component to 0.
5662         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5663         member.
5664         (riscv_struct_info::analyse): New implementation using new
5665         analyse_inner member function.
5666         (riscv_struct_info::field_offset): New member function.
5667         (riscv_struct_info::m_offsets): New member variable.
5668         (riscv_struct_info::analyse_inner): New private member function,
5669         takes the old implementation of riscv_struct_info::analyse but
5670         extended to track field offsets.
5671         (riscv_call_arg_struct): Update the struct folding special cases
5672         to handle cases where empty C++ structs, which are non-zero
5673         length, are found.
5674         (riscv_arg_location): Initialise the length of each location, a
5675         non-zero length now indicates the location is in use.
5676         (riscv_push_dummy_call): Allow for the first location having a
5677         non-zero offset when setting up arguments.
5678         (riscv_return_value): Likewise, but for return values.
5679
5680 2019-04-11  Tom Tromey  <tromey@adacore.com>
5681
5682         * utils.c (internal_vproblem): Make "msg" const.
5683
5684 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5685
5686         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5687         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5688         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5689         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5690
5691 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5692
5693         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5694         function.
5695         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5696         of amd64_collect_native_gregset.
5697         (amd64_linux_nat_target::store_registers): Likewise.
5698
5699 2019-04-10  Tom Tromey  <tom@tromey.com>
5700
5701         * symtab.c (lookup_global_symbol_from_objfile)
5702         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5703         * objfiles.h (class separate_debug_iterator): New.
5704         (class separate_debug_range): New.
5705         (struct objfile) <separate_debug_objfiles>: New method.
5706         (objfile_separate_debug_iterate): Don't declare.
5707         * objfiles.c (separate_debug_iterator::operator++): Rename from
5708         objfile_separate_debug_iterate.
5709         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5710         iterator.
5711         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5712         iterator.
5713
5714 2019-04-10  Tom Tromey  <tom@tromey.com>
5715
5716         * symfile.c (reread_symbols): Remove old comment.
5717         * objfiles.c (free_all_objfiles): Fix a typo.
5718
5719 2019-04-10  Tom Tromey  <tom@tromey.com>
5720
5721         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5722         * minsyms.c (lookup_minimal_symbol): Use foreach.
5723         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5724         (lookup_minimal_symbol_solib_trampoline): Likewise.
5725         * symfile.c (reread_symbols): Use foreach.
5726
5727 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5728             Tom Tromey  <tromey@adacore.com>
5729
5730         PR rust/24414:
5731         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5732         (rust_lex_int_test): Change "value" to be LONGEST.
5733         (rust_lex_tests): Add test for long integer literal.
5734
5735 2019-04-09  Tom Tromey  <tromey@adacore.com>
5736
5737         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5738         to bool.
5739         (extended_remote_target::attach): Update.
5740         (remote_target::remote_notice_new_inferior): Update.
5741         (remote_target::add_current_inferior_and_thread): Update.
5742         * inferior.c (exit_inferior_1): Use "false".
5743         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5744
5745 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5746
5747         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5748         the "start" command.
5749
5750 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5751
5752         * python/py-inferior.c (infpy_thread_from_thread_handle):
5753         Adjust comments to reflect renaming of thread_from_thread_handle
5754         to thread_from_handle.  Adjust keywords.  Fix type error message.
5755         (inferior_object_methods): Add thread_from_handle.  Retain
5756         thread_from_thread_handle, but mark it as deprecated.
5757
5758 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5759
5760         * gdbthread.h (find_thread_by_handle): Revise declaration.
5761         * thread.c (find_thread_by_handle): Likewise.  Adjust
5762         implementation too.
5763         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5764         support for buffer objects as handles.
5765
5766 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5767
5768         * python/py-infthread.c (thpy_thread_handle): New function.
5769         (thread_object_methods): Register thpy_thread_handle.
5770
5771 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5772
5773         * gdbthread.h (thread_to_thread_handle): Declare.
5774         * thread.c (gdbtypes.h): Include.
5775         (thread_to_thread_handle): New function.
5776
5777         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5778         (target_thread_info_to_thread_handle): Declare.
5779         * target.c (target_thread_info_to_thread_handle): New function.
5780         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5781         * target-delegates.c: Regenerate.
5782
5783         * linux-thread-db.c (class thread_db_target): Add method
5784         thread_info_to_thread_handle.
5785         (thread_db_target::thread_info_to_thread_handle): Define.
5786         * remote.c (class remote_target): Add new method
5787         thread_info_to_thread_handle.
5788         (remote_target::thread_info_to_thread_handle): Define.
5789
5790 2019-04-08  Pedro Alves  <palves@redhat.com>
5791
5792         * common/common-exceptions.c (throw_exception): Don't create
5793         named object to throw; throw directly.
5794         (throw_it): Likewise.  Don't initialize gdb_exception::message
5795         here, with new; pass FMT and AP to the ctor instead.
5796         * common/common-exceptions.h: Include <string>.
5797         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5798         const char *, va_list)): New ctor.  Use std::make_shared.
5799         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5800         errors)): Delete.
5801         (gdb_exception_error::gdb_exception_error(enum errors, const char
5802         *, va_list)): New.
5803         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5804         Add assertion.
5805         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5806         errors)): Delete.
5807         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5808         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5809         Add assertion.
5810
5811 2019-04-08  Tom Tromey  <tom@tromey.com>
5812
5813         * valops.c (value_rtti_indirect_type): Replace throw_exception
5814         with throw.
5815         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5816         with throw.
5817         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5818         throw.
5819         * target.c (target_translate_tls_address): Replace throw_exception
5820         with throw.
5821         * stack.c (frame_apply_command_count): Replace throw_exception
5822         with throw.
5823         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5824         throw.
5825         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5826         with throw.
5827         * rs6000-tdep.c (rs6000_frame_cache)
5828         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5829         * remote.c: Replace throw_exception with throw.
5830         * record-full.c (record_full_message, record_full_wait_1)
5831         (record_full_restore): Replace throw_exception with throw.
5832         * record-btrace.c:
5833         (get_thread_current_frame_id, record_btrace_start_replaying)
5834         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5835         (cmd_record_btrace_start): Replace throw_exception with throw.
5836         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5837         throw.
5838         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5839         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5840         * linespec.c:
5841         (find_linespec_symbols): Replace throw_exception with throw.
5842         * infrun.c (displaced_step_prepare, resume): Replace
5843         throw_exception with throw.
5844         * infcmd.c (post_create_inferior): Replace throw_exception with
5845         throw.
5846         * inf-loop.c (inferior_event_handler): Replace throw_exception
5847         with throw.
5848         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5849         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5850         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5851         (get_prev_frame_always, get_frame_pc_if_available)
5852         (get_frame_address_in_block_if_available, get_frame_language):
5853         Replace throw_exception with throw.
5854         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5855         throw_exception with throw.
5856         * eval.c (fetch_subexp_value, evaluate_var_value)
5857         (evaluate_funcall, evaluate_subexp_standard): Replace
5858         throw_exception with throw.
5859         * dwarf2loc.c (call_site_find_chain)
5860         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5861         Replace throw_exception with throw.
5862         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5863         with throw.
5864         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5865         throw.
5866         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5867         * completer.c (complete_line_internal): Replace throw_exception
5868         with throw.
5869         * compile/compile-object-run.c (compile_object_run): Replace
5870         throw_exception with throw.
5871         * cli/cli-script.c (process_next_line): Replace throw_exception
5872         with throw.
5873         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5874         (btrace_enable, btrace_maint_update_pt_packets): Replace
5875         throw_exception with throw.
5876         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5877         throw_exception with throw.
5878         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5879         throw_exception with throw.
5880         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5881         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5882         * aarch64-tdep.c (aarch64_make_prologue_cache)
5883         (aarch64_make_stub_cache): Replace throw_exception with throw.
5884
5885 2019-04-08  Tom Tromey  <tom@tromey.com>
5886
5887         * common/common-exceptions.c (throw_exception): Rename from
5888         throw_exception_cxx.  Remove old copy.  Make argument const.
5889         (throw_it): Create and throw exception objects directly.
5890         * common/common-exceptions.h (throw_exception): Make argument
5891         const.
5892         (struct gdb_exception_error): Add constructor.
5893         (struct gdb_exception_quit): Add constructor.
5894
5895 2019-04-08  Tom Tromey  <tom@tromey.com>
5896
5897         * common/common-exceptions.h (exception_rethrow): Don't declare.
5898         (TRY_SJLJ): Update comment.
5899         (TRY, CATCH, END_CATCH): Remove.
5900         * common/common-exceptions.c (exception_rethrow): Remove.
5901
5902 2019-04-08  Tom Tromey  <tom@tromey.com>
5903
5904         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5905         Remove.
5906         (gdb_exception_error): Rename from
5907         gdb_exception_RETURN_MASK_ERROR.
5908         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5909         (gdb_quit_bad_alloc): Update.
5910         * aarch64-tdep.c: Update.
5911         * ada-lang.c: Update.
5912         * ada-typeprint.c: Update.
5913         * ada-valprint.c: Update.
5914         * amd64-tdep.c: Update.
5915         * arch-utils.c: Update.
5916         * break-catch-throw.c: Update.
5917         * breakpoint.c: Update.
5918         * btrace.c: Update.
5919         * c-varobj.c: Update.
5920         * cli/cli-cmds.c: Update.
5921         * cli/cli-interp.c: Update.
5922         * cli/cli-script.c: Update.
5923         * common/common-exceptions.c: Update.
5924         * common/new-op.c: Update.
5925         * common/selftest.c: Update.
5926         * compile/compile-c-symbols.c: Update.
5927         * compile/compile-cplus-symbols.c: Update.
5928         * compile/compile-object-load.c: Update.
5929         * compile/compile-object-run.c: Update.
5930         * completer.c: Update.
5931         * corelow.c: Update.
5932         * cp-abi.c: Update.
5933         * cp-support.c: Update.
5934         * cp-valprint.c: Update.
5935         * darwin-nat.c: Update.
5936         * disasm-selftests.c: Update.
5937         * dtrace-probe.c: Update.
5938         * dwarf-index-cache.c: Update.
5939         * dwarf-index-write.c: Update.
5940         * dwarf2-frame-tailcall.c: Update.
5941         * dwarf2-frame.c: Update.
5942         * dwarf2loc.c: Update.
5943         * dwarf2read.c: Update.
5944         * eval.c: Update.
5945         * event-loop.c: Update.
5946         * event-top.c: Update.
5947         * exec.c: Update.
5948         * f-valprint.c: Update.
5949         * fbsd-tdep.c: Update.
5950         * frame-unwind.c: Update.
5951         * frame.c: Update.
5952         * gdbtypes.c: Update.
5953         * gnu-v3-abi.c: Update.
5954         * guile/guile-internal.h: Update.
5955         * guile/scm-block.c: Update.
5956         * guile/scm-breakpoint.c: Update.
5957         * guile/scm-cmd.c: Update.
5958         * guile/scm-disasm.c: Update.
5959         * guile/scm-frame.c: Update.
5960         * guile/scm-lazy-string.c: Update.
5961         * guile/scm-math.c: Update.
5962         * guile/scm-param.c: Update.
5963         * guile/scm-ports.c: Update.
5964         * guile/scm-pretty-print.c: Update.
5965         * guile/scm-symbol.c: Update.
5966         * guile/scm-symtab.c: Update.
5967         * guile/scm-type.c: Update.
5968         * guile/scm-value.c: Update.
5969         * i386-linux-tdep.c: Update.
5970         * i386-tdep.c: Update.
5971         * inf-loop.c: Update.
5972         * infcall.c: Update.
5973         * infcmd.c: Update.
5974         * infrun.c: Update.
5975         * jit.c: Update.
5976         * language.c: Update.
5977         * linespec.c: Update.
5978         * linux-fork.c: Update.
5979         * linux-nat.c: Update.
5980         * linux-tdep.c: Update.
5981         * linux-thread-db.c: Update.
5982         * main.c: Update.
5983         * mi/mi-cmd-break.c: Update.
5984         * mi/mi-cmd-stack.c: Update.
5985         * mi/mi-interp.c: Update.
5986         * mi/mi-main.c: Update.
5987         * objc-lang.c: Update.
5988         * p-valprint.c: Update.
5989         * parse.c: Update.
5990         * ppc-linux-tdep.c: Update.
5991         * printcmd.c: Update.
5992         * python/py-arch.c: Update.
5993         * python/py-breakpoint.c: Update.
5994         * python/py-cmd.c: Update.
5995         * python/py-finishbreakpoint.c: Update.
5996         * python/py-frame.c: Update.
5997         * python/py-framefilter.c: Update.
5998         * python/py-gdb-readline.c: Update.
5999         * python/py-inferior.c: Update.
6000         * python/py-infthread.c: Update.
6001         * python/py-lazy-string.c: Update.
6002         * python/py-linetable.c: Update.
6003         * python/py-objfile.c: Update.
6004         * python/py-param.c: Update.
6005         * python/py-prettyprint.c: Update.
6006         * python/py-progspace.c: Update.
6007         * python/py-record-btrace.c: Update.
6008         * python/py-record.c: Update.
6009         * python/py-symbol.c: Update.
6010         * python/py-type.c: Update.
6011         * python/py-unwind.c: Update.
6012         * python/py-utils.c: Update.
6013         * python/py-value.c: Update.
6014         * python/python.c: Update.
6015         * record-btrace.c: Update.
6016         * record-full.c: Update.
6017         * remote-fileio.c: Update.
6018         * remote.c: Update.
6019         * riscv-tdep.c: Update.
6020         * rs6000-aix-tdep.c: Update.
6021         * rs6000-tdep.c: Update.
6022         * rust-exp.y: Update.
6023         * rust-lang.c: Update.
6024         * s390-tdep.c: Update.
6025         * selftest-arch.c: Update.
6026         * solib-dsbt.c: Update.
6027         * solib-frv.c: Update.
6028         * solib-spu.c: Update.
6029         * solib-svr4.c: Update.
6030         * solib.c: Update.
6031         * sparc64-linux-tdep.c: Update.
6032         * stack.c: Update.
6033         * symfile-mem.c: Update.
6034         * symmisc.c: Update.
6035         * target.c: Update.
6036         * thread.c: Update.
6037         * top.c: Update.
6038         * tracefile-tfile.c: Update.
6039         * tui/tui.c: Update.
6040         * typeprint.c: Update.
6041         * unittests/cli-utils-selftests.c: Update.
6042         * unittests/parse-connection-spec-selftests.c: Update.
6043         * valops.c: Update.
6044         * valprint.c: Update.
6045         * value.c: Update.
6046         * varobj.c: Update.
6047         * windows-nat.c: Update.
6048         * x86-linux-nat.c: Update.
6049         * xml-support.c: Update.
6050
6051 2019-04-08  Tom Tromey  <tom@tromey.com>
6052
6053         * xml-support.c: Use C++ exception handling.
6054         * x86-linux-nat.c: Use C++ exception handling.
6055         * windows-nat.c: Use C++ exception handling.
6056         * varobj.c: Use C++ exception handling.
6057         * value.c: Use C++ exception handling.
6058         * valprint.c: Use C++ exception handling.
6059         * valops.c: Use C++ exception handling.
6060         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6061         handling.
6062         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6063         * typeprint.c: Use C++ exception handling.
6064         * tui/tui.c: Use C++ exception handling.
6065         * tracefile-tfile.c: Use C++ exception handling.
6066         * top.c: Use C++ exception handling.
6067         * thread.c: Use C++ exception handling.
6068         * target.c: Use C++ exception handling.
6069         * symmisc.c: Use C++ exception handling.
6070         * symfile-mem.c: Use C++ exception handling.
6071         * stack.c: Use C++ exception handling.
6072         * sparc64-linux-tdep.c: Use C++ exception handling.
6073         * solib.c: Use C++ exception handling.
6074         * solib-svr4.c: Use C++ exception handling.
6075         * solib-spu.c: Use C++ exception handling.
6076         * solib-frv.c: Use C++ exception handling.
6077         * solib-dsbt.c: Use C++ exception handling.
6078         * selftest-arch.c: Use C++ exception handling.
6079         * s390-tdep.c: Use C++ exception handling.
6080         * rust-lang.c: Use C++ exception handling.
6081         * rust-exp.y: Use C++ exception handling.
6082         * rs6000-tdep.c: Use C++ exception handling.
6083         * rs6000-aix-tdep.c: Use C++ exception handling.
6084         * riscv-tdep.c: Use C++ exception handling.
6085         * remote.c: Use C++ exception handling.
6086         * remote-fileio.c: Use C++ exception handling.
6087         * record-full.c: Use C++ exception handling.
6088         * record-btrace.c: Use C++ exception handling.
6089         * python/python.c: Use C++ exception handling.
6090         * python/py-value.c: Use C++ exception handling.
6091         * python/py-utils.c: Use C++ exception handling.
6092         * python/py-unwind.c: Use C++ exception handling.
6093         * python/py-type.c: Use C++ exception handling.
6094         * python/py-symbol.c: Use C++ exception handling.
6095         * python/py-record.c: Use C++ exception handling.
6096         * python/py-record-btrace.c: Use C++ exception handling.
6097         * python/py-progspace.c: Use C++ exception handling.
6098         * python/py-prettyprint.c: Use C++ exception handling.
6099         * python/py-param.c: Use C++ exception handling.
6100         * python/py-objfile.c: Use C++ exception handling.
6101         * python/py-linetable.c: Use C++ exception handling.
6102         * python/py-lazy-string.c: Use C++ exception handling.
6103         * python/py-infthread.c: Use C++ exception handling.
6104         * python/py-inferior.c: Use C++ exception handling.
6105         * python/py-gdb-readline.c: Use C++ exception handling.
6106         * python/py-framefilter.c: Use C++ exception handling.
6107         * python/py-frame.c: Use C++ exception handling.
6108         * python/py-finishbreakpoint.c: Use C++ exception handling.
6109         * python/py-cmd.c: Use C++ exception handling.
6110         * python/py-breakpoint.c: Use C++ exception handling.
6111         * python/py-arch.c: Use C++ exception handling.
6112         * printcmd.c: Use C++ exception handling.
6113         * ppc-linux-tdep.c: Use C++ exception handling.
6114         * parse.c: Use C++ exception handling.
6115         * p-valprint.c: Use C++ exception handling.
6116         * objc-lang.c: Use C++ exception handling.
6117         * mi/mi-main.c: Use C++ exception handling.
6118         * mi/mi-interp.c: Use C++ exception handling.
6119         * mi/mi-cmd-stack.c: Use C++ exception handling.
6120         * mi/mi-cmd-break.c: Use C++ exception handling.
6121         * main.c: Use C++ exception handling.
6122         * linux-thread-db.c: Use C++ exception handling.
6123         * linux-tdep.c: Use C++ exception handling.
6124         * linux-nat.c: Use C++ exception handling.
6125         * linux-fork.c: Use C++ exception handling.
6126         * linespec.c: Use C++ exception handling.
6127         * language.c: Use C++ exception handling.
6128         * jit.c: Use C++ exception handling.
6129         * infrun.c: Use C++ exception handling.
6130         * infcmd.c: Use C++ exception handling.
6131         * infcall.c: Use C++ exception handling.
6132         * inf-loop.c: Use C++ exception handling.
6133         * i386-tdep.c: Use C++ exception handling.
6134         * i386-linux-tdep.c: Use C++ exception handling.
6135         * guile/scm-value.c: Use C++ exception handling.
6136         * guile/scm-type.c: Use C++ exception handling.
6137         * guile/scm-symtab.c: Use C++ exception handling.
6138         * guile/scm-symbol.c: Use C++ exception handling.
6139         * guile/scm-pretty-print.c: Use C++ exception handling.
6140         * guile/scm-ports.c: Use C++ exception handling.
6141         * guile/scm-param.c: Use C++ exception handling.
6142         * guile/scm-math.c: Use C++ exception handling.
6143         * guile/scm-lazy-string.c: Use C++ exception handling.
6144         * guile/scm-frame.c: Use C++ exception handling.
6145         * guile/scm-disasm.c: Use C++ exception handling.
6146         * guile/scm-cmd.c: Use C++ exception handling.
6147         * guile/scm-breakpoint.c: Use C++ exception handling.
6148         * guile/scm-block.c: Use C++ exception handling.
6149         * guile/guile-internal.h: Use C++ exception handling.
6150         * gnu-v3-abi.c: Use C++ exception handling.
6151         * gdbtypes.c: Use C++ exception handling.
6152         * frame.c: Use C++ exception handling.
6153         * frame-unwind.c: Use C++ exception handling.
6154         * fbsd-tdep.c: Use C++ exception handling.
6155         * f-valprint.c: Use C++ exception handling.
6156         * exec.c: Use C++ exception handling.
6157         * event-top.c: Use C++ exception handling.
6158         * event-loop.c: Use C++ exception handling.
6159         * eval.c: Use C++ exception handling.
6160         * dwarf2read.c: Use C++ exception handling.
6161         * dwarf2loc.c: Use C++ exception handling.
6162         * dwarf2-frame.c: Use C++ exception handling.
6163         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6164         * dwarf-index-write.c: Use C++ exception handling.
6165         * dwarf-index-cache.c: Use C++ exception handling.
6166         * dtrace-probe.c: Use C++ exception handling.
6167         * disasm-selftests.c: Use C++ exception handling.
6168         * darwin-nat.c: Use C++ exception handling.
6169         * cp-valprint.c: Use C++ exception handling.
6170         * cp-support.c: Use C++ exception handling.
6171         * cp-abi.c: Use C++ exception handling.
6172         * corelow.c: Use C++ exception handling.
6173         * completer.c: Use C++ exception handling.
6174         * compile/compile-object-run.c: Use C++ exception handling.
6175         * compile/compile-object-load.c: Use C++ exception handling.
6176         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6177         * compile/compile-c-symbols.c: Use C++ exception handling.
6178         * common/selftest.c: Use C++ exception handling.
6179         * common/new-op.c: Use C++ exception handling.
6180         * cli/cli-script.c: Use C++ exception handling.
6181         * cli/cli-interp.c: Use C++ exception handling.
6182         * cli/cli-cmds.c: Use C++ exception handling.
6183         * c-varobj.c: Use C++ exception handling.
6184         * btrace.c: Use C++ exception handling.
6185         * breakpoint.c: Use C++ exception handling.
6186         * break-catch-throw.c: Use C++ exception handling.
6187         * arch-utils.c: Use C++ exception handling.
6188         * amd64-tdep.c: Use C++ exception handling.
6189         * ada-valprint.c: Use C++ exception handling.
6190         * ada-typeprint.c: Use C++ exception handling.
6191         * ada-lang.c: Use C++ exception handling.
6192         * aarch64-tdep.c: Use C++ exception handling.
6193
6194 2019-04-08  Tom Tromey  <tom@tromey.com>
6195
6196         * xml-support.c (gdb_xml_parser::parse): Update.
6197         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6198         * value.c (show_convenience): Update.
6199         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6200         (test_parse_flags_qcs): Update.
6201         * thread.c (thr_try_catch_cmd): Update.
6202         * target.c (target_translate_tls_address): Update.
6203         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6204         (info_frame_command_core, frame_apply_command_count): Update.
6205         * rust-exp.y (rust_lex_exception_test): Update.
6206         * riscv-tdep.c (riscv_print_one_register_info): Update.
6207         * remote.c (remote_target::enable_btrace): Update.
6208         * record-btrace.c (record_btrace_enable_warn): Update.
6209         * python/py-utils.c (gdbpy_convert_exception): Update.
6210         * printcmd.c (do_one_display, print_variable_and_value): Update.
6211         * mi/mi-main.c (mi_print_exception): Update.
6212         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6213         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6214         * linux-nat.c (linux_nat_target::attach): Update.
6215         * linux-fork.c (class scoped_switch_fork_info): Update.
6216         * infrun.c (displaced_step_prepare): Update.
6217         * infcall.c (call_function_by_hand_dummy): Update.
6218         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6219         * gnu-v3-abi.c (print_one_vtable): Update.
6220         * frame.c (get_prev_frame_always): Update.
6221         * f-valprint.c (info_common_command_for_block): Update.
6222         * exec.c (try_open_exec_file): Update.
6223         * exceptions.c (print_exception, exception_print)
6224         (exception_fprintf, exception_print_same): Update.
6225         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6226         * dwarf-index-cache.c (index_cache::store)
6227         (index_cache::lookup_gdb_index): Update.
6228         * darwin-nat.c (maybe_cache_shell): Update.
6229         * cp-valprint.c (cp_print_value_fields): Update.
6230         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6231         (gcc_cplus_symbol_address): Update.
6232         * compile/compile-c-symbols.c (gcc_convert_symbol)
6233         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6234         * common/selftest.c: Update.
6235         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6236         a std::string.
6237         (exception_try_scope_entry, exception_try_scope_exit): Don't
6238         declare.
6239         (struct exception_try_scope): Remove.
6240         (TRY): Don't use exception_try_scope.
6241         (struct gdb_exception): Add constructor, operator=.
6242         <what>: New method.
6243         (struct gdb_exception_RETURN_MASK_ALL)
6244         (struct gdb_exception_RETURN_MASK_ERROR)
6245         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6246         (struct gdb_quit_bad_alloc): Update.
6247         * common/common-exceptions.c (exception_none): Change
6248         initializer.
6249         (struct catcher) <state, exception>: Initialize inline.
6250         <prev>: Remove member.
6251         (current_catcher): Remove.
6252         (catchers): New global.
6253         (exceptions_state_mc_init): Simplify.
6254         (catcher_pop): Remove.
6255         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6256         (try_scope_depth, exception_try_scope_entry)
6257         (exception_try_scope_exit): Remove.
6258         (throw_exception_sjlj): Update.
6259         (exception_messages, exception_messages_size): Remove.
6260         (throw_it): Simplify.
6261         (gdb_exception_sliced_copy): Remove.
6262         (throw_exception_cxx): Update.
6263         * cli/cli-script.c (script_from_file): Update.
6264         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6265         Update.
6266         * ada-valprint.c (ada_val_print): Update.
6267         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6268         (create_excep_cond_exprs): Update.
6269
6270 2019-04-08  Tom Tromey  <tom@tromey.com>
6271
6272         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6273         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6274         (TRY, CATCH, END_CATCH): Remove some definitions.
6275         * common/common-exceptions.c: Don't use GDB_XCPT.
6276         (catcher_list_size): Remove.
6277         (throw_exception, throw_it): Simplify.
6278
6279 2019-04-05  Tom Tromey  <tom@tromey.com>
6280
6281         Revert the header-sorting patch.
6282         * ft32-tdep.c: Revert.
6283         * frv-tdep.c: Revert.
6284         * frv-linux-tdep.c: Revert.
6285         * frame.c: Revert.
6286         * frame-unwind.c: Revert.
6287         * frame-base.c: Revert.
6288         * fork-child.c: Revert.
6289         * findvar.c: Revert.
6290         * findcmd.c: Revert.
6291         * filesystem.c: Revert.
6292         * filename-seen-cache.h: Revert.
6293         * filename-seen-cache.c: Revert.
6294         * fbsd-tdep.c: Revert.
6295         * fbsd-nat.h: Revert.
6296         * fbsd-nat.c: Revert.
6297         * f-valprint.c: Revert.
6298         * f-typeprint.c: Revert.
6299         * f-lang.c: Revert.
6300         * extension.h: Revert.
6301         * extension.c: Revert.
6302         * extension-priv.h: Revert.
6303         * expprint.c: Revert.
6304         * exec.h: Revert.
6305         * exec.c: Revert.
6306         * exceptions.c: Revert.
6307         * event-top.c: Revert.
6308         * event-loop.c: Revert.
6309         * eval.c: Revert.
6310         * elfread.c: Revert.
6311         * dwarf2read.h: Revert.
6312         * dwarf2read.c: Revert.
6313         * dwarf2loc.c: Revert.
6314         * dwarf2expr.h: Revert.
6315         * dwarf2expr.c: Revert.
6316         * dwarf2-frame.c: Revert.
6317         * dwarf2-frame-tailcall.c: Revert.
6318         * dwarf-index-write.h: Revert.
6319         * dwarf-index-write.c: Revert.
6320         * dwarf-index-common.c: Revert.
6321         * dwarf-index-cache.h: Revert.
6322         * dwarf-index-cache.c: Revert.
6323         * dummy-frame.c: Revert.
6324         * dtrace-probe.c: Revert.
6325         * disasm.h: Revert.
6326         * disasm.c: Revert.
6327         * disasm-selftests.c: Revert.
6328         * dictionary.c: Revert.
6329         * dicos-tdep.c: Revert.
6330         * demangle.c: Revert.
6331         * dcache.h: Revert.
6332         * dcache.c: Revert.
6333         * darwin-nat.h: Revert.
6334         * darwin-nat.c: Revert.
6335         * darwin-nat-info.c: Revert.
6336         * d-valprint.c: Revert.
6337         * d-namespace.c: Revert.
6338         * d-lang.c: Revert.
6339         * ctf.c: Revert.
6340         * csky-tdep.c: Revert.
6341         * csky-linux-tdep.c: Revert.
6342         * cris-tdep.c: Revert.
6343         * cris-linux-tdep.c: Revert.
6344         * cp-valprint.c: Revert.
6345         * cp-support.c: Revert.
6346         * cp-namespace.c: Revert.
6347         * cp-abi.c: Revert.
6348         * corelow.c: Revert.
6349         * corefile.c: Revert.
6350         * continuations.c: Revert.
6351         * completer.h: Revert.
6352         * completer.c: Revert.
6353         * complaints.c: Revert.
6354         * coffread.c: Revert.
6355         * coff-pe-read.c: Revert.
6356         * cli-out.h: Revert.
6357         * cli-out.c: Revert.
6358         * charset.c: Revert.
6359         * c-varobj.c: Revert.
6360         * c-valprint.c: Revert.
6361         * c-typeprint.c: Revert.
6362         * c-lang.c: Revert.
6363         * buildsym.c: Revert.
6364         * buildsym-legacy.c: Revert.
6365         * build-id.h: Revert.
6366         * build-id.c: Revert.
6367         * btrace.c: Revert.
6368         * bsd-uthread.c: Revert.
6369         * breakpoint.h: Revert.
6370         * breakpoint.c: Revert.
6371         * break-catch-throw.c: Revert.
6372         * break-catch-syscall.c: Revert.
6373         * break-catch-sig.c: Revert.
6374         * blockframe.c: Revert.
6375         * block.c: Revert.
6376         * bfin-tdep.c: Revert.
6377         * bfin-linux-tdep.c: Revert.
6378         * bfd-target.c: Revert.
6379         * bcache.c: Revert.
6380         * ax-general.c: Revert.
6381         * ax-gdb.h: Revert.
6382         * ax-gdb.c: Revert.
6383         * avr-tdep.c: Revert.
6384         * auxv.c: Revert.
6385         * auto-load.c: Revert.
6386         * arm-wince-tdep.c: Revert.
6387         * arm-tdep.c: Revert.
6388         * arm-symbian-tdep.c: Revert.
6389         * arm-pikeos-tdep.c: Revert.
6390         * arm-obsd-tdep.c: Revert.
6391         * arm-nbsd-tdep.c: Revert.
6392         * arm-nbsd-nat.c: Revert.
6393         * arm-linux-tdep.c: Revert.
6394         * arm-linux-nat.c: Revert.
6395         * arm-fbsd-tdep.c: Revert.
6396         * arm-fbsd-nat.c: Revert.
6397         * arm-bsd-tdep.c: Revert.
6398         * arch-utils.c: Revert.
6399         * arc-tdep.c: Revert.
6400         * arc-newlib-tdep.c: Revert.
6401         * annotate.h: Revert.
6402         * annotate.c: Revert.
6403         * amd64-windows-tdep.c: Revert.
6404         * amd64-windows-nat.c: Revert.
6405         * amd64-tdep.c: Revert.
6406         * amd64-sol2-tdep.c: Revert.
6407         * amd64-obsd-tdep.c: Revert.
6408         * amd64-obsd-nat.c: Revert.
6409         * amd64-nbsd-tdep.c: Revert.
6410         * amd64-nbsd-nat.c: Revert.
6411         * amd64-nat.c: Revert.
6412         * amd64-linux-tdep.c: Revert.
6413         * amd64-linux-nat.c: Revert.
6414         * amd64-fbsd-tdep.c: Revert.
6415         * amd64-fbsd-nat.c: Revert.
6416         * amd64-dicos-tdep.c: Revert.
6417         * amd64-darwin-tdep.c: Revert.
6418         * amd64-bsd-nat.c: Revert.
6419         * alpha-tdep.c: Revert.
6420         * alpha-obsd-tdep.c: Revert.
6421         * alpha-nbsd-tdep.c: Revert.
6422         * alpha-mdebug-tdep.c: Revert.
6423         * alpha-linux-tdep.c: Revert.
6424         * alpha-linux-nat.c: Revert.
6425         * alpha-bsd-tdep.c: Revert.
6426         * alpha-bsd-nat.c: Revert.
6427         * aix-thread.c: Revert.
6428         * agent.c: Revert.
6429         * addrmap.c: Revert.
6430         * ada-varobj.c: Revert.
6431         * ada-valprint.c: Revert.
6432         * ada-typeprint.c: Revert.
6433         * ada-tasks.c: Revert.
6434         * ada-lang.c: Revert.
6435         * aarch64-tdep.c: Revert.
6436         * aarch64-ravenscar-thread.c: Revert.
6437         * aarch64-newlib-tdep.c: Revert.
6438         * aarch64-linux-tdep.c: Revert.
6439         * aarch64-linux-nat.c: Revert.
6440         * aarch64-fbsd-tdep.c: Revert.
6441         * aarch64-fbsd-nat.c: Revert.
6442         * aarch32-linux-nat.c: Revert.
6443
6444 2019-04-05  Tom Tromey  <tom@tromey.com>
6445
6446         * ft32-tdep.c: Sort headers.
6447         * frv-tdep.c: Sort headers.
6448         * frv-linux-tdep.c: Sort headers.
6449         * frame.c: Sort headers.
6450         * frame-unwind.c: Sort headers.
6451         * frame-base.c: Sort headers.
6452         * fork-child.c: Sort headers.
6453         * findvar.c: Sort headers.
6454         * findcmd.c: Sort headers.
6455         * filesystem.c: Sort headers.
6456         * filename-seen-cache.h: Sort headers.
6457         * filename-seen-cache.c: Sort headers.
6458         * fbsd-tdep.c: Sort headers.
6459         * fbsd-nat.h: Sort headers.
6460         * fbsd-nat.c: Sort headers.
6461         * f-valprint.c: Sort headers.
6462         * f-typeprint.c: Sort headers.
6463         * f-lang.c: Sort headers.
6464         * extension.h: Sort headers.
6465         * extension.c: Sort headers.
6466         * extension-priv.h: Sort headers.
6467         * expprint.c: Sort headers.
6468         * exec.h: Sort headers.
6469         * exec.c: Sort headers.
6470         * exceptions.c: Sort headers.
6471         * event-top.c: Sort headers.
6472         * event-loop.c: Sort headers.
6473         * eval.c: Sort headers.
6474         * elfread.c: Sort headers.
6475         * dwarf2read.h: Sort headers.
6476         * dwarf2read.c: Sort headers.
6477         * dwarf2loc.c: Sort headers.
6478         * dwarf2expr.h: Sort headers.
6479         * dwarf2expr.c: Sort headers.
6480         * dwarf2-frame.c: Sort headers.
6481         * dwarf2-frame-tailcall.c: Sort headers.
6482         * dwarf-index-write.h: Sort headers.
6483         * dwarf-index-write.c: Sort headers.
6484         * dwarf-index-common.c: Sort headers.
6485         * dwarf-index-cache.h: Sort headers.
6486         * dwarf-index-cache.c: Sort headers.
6487         * dummy-frame.c: Sort headers.
6488         * dtrace-probe.c: Sort headers.
6489         * disasm.h: Sort headers.
6490         * disasm.c: Sort headers.
6491         * disasm-selftests.c: Sort headers.
6492         * dictionary.c: Sort headers.
6493         * dicos-tdep.c: Sort headers.
6494         * demangle.c: Sort headers.
6495         * dcache.h: Sort headers.
6496         * dcache.c: Sort headers.
6497         * darwin-nat.h: Sort headers.
6498         * darwin-nat.c: Sort headers.
6499         * darwin-nat-info.c: Sort headers.
6500         * d-valprint.c: Sort headers.
6501         * d-namespace.c: Sort headers.
6502         * d-lang.c: Sort headers.
6503         * ctf.c: Sort headers.
6504         * csky-tdep.c: Sort headers.
6505         * csky-linux-tdep.c: Sort headers.
6506         * cris-tdep.c: Sort headers.
6507         * cris-linux-tdep.c: Sort headers.
6508         * cp-valprint.c: Sort headers.
6509         * cp-support.c: Sort headers.
6510         * cp-namespace.c: Sort headers.
6511         * cp-abi.c: Sort headers.
6512         * corelow.c: Sort headers.
6513         * corefile.c: Sort headers.
6514         * continuations.c: Sort headers.
6515         * completer.h: Sort headers.
6516         * completer.c: Sort headers.
6517         * complaints.c: Sort headers.
6518         * coffread.c: Sort headers.
6519         * coff-pe-read.c: Sort headers.
6520         * cli-out.h: Sort headers.
6521         * cli-out.c: Sort headers.
6522         * charset.c: Sort headers.
6523         * c-varobj.c: Sort headers.
6524         * c-valprint.c: Sort headers.
6525         * c-typeprint.c: Sort headers.
6526         * c-lang.c: Sort headers.
6527         * buildsym.c: Sort headers.
6528         * buildsym-legacy.c: Sort headers.
6529         * build-id.h: Sort headers.
6530         * build-id.c: Sort headers.
6531         * btrace.c: Sort headers.
6532         * bsd-uthread.c: Sort headers.
6533         * breakpoint.h: Sort headers.
6534         * breakpoint.c: Sort headers.
6535         * break-catch-throw.c: Sort headers.
6536         * break-catch-syscall.c: Sort headers.
6537         * break-catch-sig.c: Sort headers.
6538         * blockframe.c: Sort headers.
6539         * block.c: Sort headers.
6540         * bfin-tdep.c: Sort headers.
6541         * bfin-linux-tdep.c: Sort headers.
6542         * bfd-target.c: Sort headers.
6543         * bcache.c: Sort headers.
6544         * ax-general.c: Sort headers.
6545         * ax-gdb.h: Sort headers.
6546         * ax-gdb.c: Sort headers.
6547         * avr-tdep.c: Sort headers.
6548         * auxv.c: Sort headers.
6549         * auto-load.c: Sort headers.
6550         * arm-wince-tdep.c: Sort headers.
6551         * arm-tdep.c: Sort headers.
6552         * arm-symbian-tdep.c: Sort headers.
6553         * arm-pikeos-tdep.c: Sort headers.
6554         * arm-obsd-tdep.c: Sort headers.
6555         * arm-nbsd-tdep.c: Sort headers.
6556         * arm-nbsd-nat.c: Sort headers.
6557         * arm-linux-tdep.c: Sort headers.
6558         * arm-linux-nat.c: Sort headers.
6559         * arm-fbsd-tdep.c: Sort headers.
6560         * arm-fbsd-nat.c: Sort headers.
6561         * arm-bsd-tdep.c: Sort headers.
6562         * arch-utils.c: Sort headers.
6563         * arc-tdep.c: Sort headers.
6564         * arc-newlib-tdep.c: Sort headers.
6565         * annotate.h: Sort headers.
6566         * annotate.c: Sort headers.
6567         * amd64-windows-tdep.c: Sort headers.
6568         * amd64-windows-nat.c: Sort headers.
6569         * amd64-tdep.c: Sort headers.
6570         * amd64-sol2-tdep.c: Sort headers.
6571         * amd64-obsd-tdep.c: Sort headers.
6572         * amd64-obsd-nat.c: Sort headers.
6573         * amd64-nbsd-tdep.c: Sort headers.
6574         * amd64-nbsd-nat.c: Sort headers.
6575         * amd64-nat.c: Sort headers.
6576         * amd64-linux-tdep.c: Sort headers.
6577         * amd64-linux-nat.c: Sort headers.
6578         * amd64-fbsd-tdep.c: Sort headers.
6579         * amd64-fbsd-nat.c: Sort headers.
6580         * amd64-dicos-tdep.c: Sort headers.
6581         * amd64-darwin-tdep.c: Sort headers.
6582         * amd64-bsd-nat.c: Sort headers.
6583         * alpha-tdep.c: Sort headers.
6584         * alpha-obsd-tdep.c: Sort headers.
6585         * alpha-nbsd-tdep.c: Sort headers.
6586         * alpha-mdebug-tdep.c: Sort headers.
6587         * alpha-linux-tdep.c: Sort headers.
6588         * alpha-linux-nat.c: Sort headers.
6589         * alpha-bsd-tdep.c: Sort headers.
6590         * alpha-bsd-nat.c: Sort headers.
6591         * aix-thread.c: Sort headers.
6592         * agent.c: Sort headers.
6593         * addrmap.c: Sort headers.
6594         * ada-varobj.c: Sort headers.
6595         * ada-valprint.c: Sort headers.
6596         * ada-typeprint.c: Sort headers.
6597         * ada-tasks.c: Sort headers.
6598         * ada-lang.c: Sort headers.
6599         * aarch64-tdep.c: Sort headers.
6600         * aarch64-ravenscar-thread.c: Sort headers.
6601         * aarch64-newlib-tdep.c: Sort headers.
6602         * aarch64-linux-tdep.c: Sort headers.
6603         * aarch64-linux-nat.c: Sort headers.
6604         * aarch64-fbsd-tdep.c: Sort headers.
6605         * aarch64-fbsd-nat.c: Sort headers.
6606         * aarch32-linux-nat.c: Sort headers.
6607
6608 2019-04-04  Tom Tromey  <tom@tromey.com>
6609
6610         * varobj.c (varobj_create): Update.
6611         * rust-exp.y (struct rust_parser) <update_innermost_block,
6612         lookup_symbol>: New methods.
6613         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6614         Rename.
6615         (rust_parser::rust_lookup_type)
6616         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6617         * printcmd.c (display_command, do_one_display): Update.
6618         * parser-defs.h (struct parser_state) <parser_state>: Add
6619         "tracker" parameter.
6620         (block_tracker): New member.
6621         (class innermost_block_tracker) <innermost_block_tracker>: Add
6622         "types" parameter.
6623         <reset>: Remove method.
6624         (innermost_block): Don't declare.
6625         (null_post_parser): Update.
6626         * parse.c (innermost_block): Remove global.
6627         (write_dollar_variable): Update.
6628         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6629         Remove "tracker_types" parameter.
6630         (parse_expression): Add "tracker" parameter.
6631         (parse_expression_for_completion): Update.
6632         (null_post_parser): Add "tracker" parameter.
6633         * p-exp.y: Update rules.
6634         * m2-exp.y: Update rules.
6635         * language.h (struct language_defn) <la_post_parser>: Add
6636         "tracker" parameter.
6637         * go-exp.y: Update rules.
6638         * f-exp.y: Update rules.
6639         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6640         parameter.
6641         * d-exp.y: Update rules.
6642         * c-exp.y: Update rules.
6643         * breakpoint.c (set_breakpoint_condition): Create an
6644         innermost_block_tracker.
6645         (watch_command_1): Likewise.
6646         * ada-lang.c (resolve): Add "tracker" parameter.
6647         (resolve_subexp): Likewise.
6648         * ada-exp.y (write_var_from_sym): Update.
6649
6650 2019-04-04  Tom Tromey  <tom@tromey.com>
6651
6652         * type-stack.h: New file.
6653         * type-stack.c: New file.
6654         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6655         type-stack.h.
6656         (insert_into_type_stack, insert_type, push_type, push_type_int)
6657         (insert_type_address_space, pop_type, pop_type_int)
6658         (pop_typelist, pop_type_stack, append_type_stack)
6659         (push_type_stack, get_type_stack, push_typelist)
6660         (follow_type_instance_flags, follow_types): Don't declare.
6661         * parse.c (type_stack): Remove global.
6662         (parse_exp_in_context): Update.
6663         (insert_into_type_stack, insert_type, push_type, push_type_int)
6664         (insert_type_address_space, pop_type, pop_type_int)
6665         (pop_typelist, pop_type_stack, append_type_stack)
6666         (push_type_stack, get_type_stack, push_typelist)
6667         (follow_type_instance_flags, follow_types): Remove (moved to
6668         type-stack.c).
6669         * f-exp.y (type_stack): New global.
6670         Update rules.
6671         (push_kind_type, f_parse): Update.
6672         * d-exp.y (type_stack): New global.
6673         Update rules.
6674         (d_parse): Update.
6675         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6676         Update rules.
6677         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6678         (HFILES_NO_SRCDIR): Add type-stack.h.
6679
6680 2019-04-04  Tom Tromey  <tom@tromey.com>
6681
6682         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6683         (rust_parser::convert_ast_to_expression, rust_parse)
6684         (rust_lex_test_completion, rust_lex_tests): Update.
6685         * parser-defs.h (struct expr_completion_state): New.
6686         (struct parser_state) <parser_state>: Add completion parameter.
6687         <mark_struct_expression, mark_completion_tag>: New methods.
6688         <parse_completion, m_completion_state>: New members.
6689         (prefixify_expression, null_post_parser): Update.
6690         (mark_struct_expression, mark_completion_tag): Don't declare.
6691         * parse.c (parse_completion, expout_last_struct)
6692         (expout_tag_completion_type, expout_completion_name): Remove
6693         globals.
6694         (parser_state::mark_struct_expression)
6695         (parser_state::mark_completion_tag): Now methods.
6696         (prefixify_expression): Add last_struct parameter.
6697         (prefixify_subexp): Likewise.
6698         (parse_exp_1): Update.
6699         (parse_exp_in_context): Add cstate parameter.  Update.
6700         (parse_expression_for_completion): Create an
6701         expr_completion_state.
6702         (null_post_parser): Add "completion" parameter.
6703         * p-exp.y: Update rules.
6704         (yylex): Update.
6705         * language.h (struct language_defn) <la_post_parser>: Add
6706         "completing" parameter.
6707         * go-exp.y: Update rules.
6708         (lex_one_token): Update.
6709         * expression.h (parse_completion): Don't declare.
6710         * d-exp.y: Update rules.
6711         (lex_one_token): Update rules.
6712         * c-exp.y: Update rules.
6713         (lex_one_token): Update.
6714         * ada-lang.c (resolve): Add "parse_completion" parameter.
6715         (resolve_subexp): Likewise.
6716         (ada_resolve_function): Likewise.
6717
6718 2019-04-04  Tom Tromey  <tom@tromey.com>
6719
6720         * parser-defs.h (struct parser_state) <start_arglist,
6721         end_arglist>: New methods.
6722         <arglist_len, m_funcall_chain>: New members.
6723         (arglist_len, start_arglist, end_arglist): Don't declare.
6724         * parse.c (arglist_len, funcall_chain): Remove global.
6725         (start_arglist, end_arglist): Remove functions.
6726         (parse_exp_in_context): Update.
6727         * p-exp.y: Update rules.
6728         * m2-exp.y: Update rules.
6729         * go-exp.y: Update rules.
6730         * f-exp.y: Update rules.
6731         * d-exp.y: Update rules.
6732         * c-exp.y: Update rules.
6733
6734 2019-04-04  Tom Tromey  <tom@tromey.com>
6735
6736         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6737         lex_operator, push_back>: New methods.
6738         Update all rules.
6739         (rust_parser::lex_hex, lex_escape): Rename and update.
6740         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6741         (rust_parser::lex_operator): Rename and update.
6742         (rust_parser::lex_number, rustyylex, rustyyerror)
6743         (rust_lex_test_init, rust_lex_test_sequence)
6744         (rust_lex_test_push_back, rust_lex_tests): Update.
6745         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6746         parameter.
6747         <lexptr, prev_lexptr>: New members.
6748         (lexptr, prev_lexptr): Don't declare.
6749         * parse.c (lexptr, prev_lexptr): Remove globals.
6750         (parse_exp_in_context): Update.
6751         * p-exp.y (yylex, yyerror): Update.
6752         * m2-exp.y (parse_number, yylex, yyerror): Update.
6753         * go-exp.y (lex_one_token, yyerror): Update.
6754         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6755         * d-exp.y (lex_one_token, yyerror): Update.
6756         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6757         (lex_one_token, yyerror): Update.
6758         * ada-lex.l (YY_INPUT): Update.
6759         (rewind_to_char): Update.
6760         * ada-exp.y (yyerror): Update.
6761
6762 2019-04-04  Tom Tromey  <tom@tromey.com>
6763
6764         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6765         * parser-defs.h (struct parser_state) <parser_state>: Add new
6766         parameter.
6767         <comma_terminates>: New member.
6768         (comma_terminates): Don't declare global.
6769         * parse.c (comma_terminates): Remove global.
6770         (parse_exp_in_context): Update.
6771         * p-exp.y (yylex): Update.
6772         * m2-exp.y (yylex): Update.
6773         * go-exp.y (lex_one_token): Update.
6774         * f-exp.y (yylex): Update.
6775         * d-exp.y (lex_one_token): Update.
6776         * c-exp.y (lex_one_token): Update.
6777         * ada-lex.l: Update.
6778
6779 2019-04-04  Tom Tromey  <tom@tromey.com>
6780
6781         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6782         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6783         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6784         * parser-defs.h (paren_depth): Don't declare.
6785         * parse.c (paren_depth): Remove global.
6786         (parse_exp_in_context): Update.
6787         * p-exp.y (paren_depth): New global.
6788         (pascal_parse): Initialize it.
6789         * m2-exp.y (paren_depth): New global.
6790         (m2_parse): Initialize it.
6791         * go-exp.y (paren_depth): New global.
6792         (go_parse): Initialize it.
6793         * f-exp.y (paren_depth): New global.
6794         (f_parse): Initialize it.
6795         * d-exp.y (paren_depth): New global.
6796         (d_parse): Initialize it.
6797         * c-exp.y (paren_depth): New global.
6798         (c_parse): Initialize it.
6799         * ada-lex.l (paren_depth): New global.
6800         (lexer_init): Initialize it.
6801
6802 2019-04-04  Tom Tromey  <tom@tromey.com>
6803
6804         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6805         (rust_parser::convert_ast_to_type)
6806         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6807         * parser-defs.h (struct parser_state) <parser_state>: Add
6808         parameters.  Initialize new members.
6809         <expression_context_block, expression_context_pc>: New members.
6810         * parse.c (expression_context_block, expression_context_pc):
6811         Remove globals.
6812         (parse_exp_in_context): Update.
6813         * p-exp.y: Update all rules.
6814         (yylex): Update.
6815         * m2-exp.y: Update all rules.
6816         (yylex): Update.
6817         * go-exp.y (yylex): Update.
6818         * f-exp.y (yylex): Update.
6819         * d-exp.y: Update all rules.
6820         (yylex): Update.
6821         * c-exp.y: Update all rules.
6822         (lex_one_token, classify_name, yylex, c_parse): Update.
6823         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6824
6825 2019-04-04  Tom Tromey  <tom@tromey.com>
6826
6827         * gdbarch.h, gdbarch.c: Rebuild.
6828         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6829         * stap-probe.h:
6830         (struct stap_parse_info): Replace "parser_state" with
6831         "expr_builder".
6832         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6833         (parser_state): New class.
6834         * parse.c (expr_builder): Rename.
6835         (expr_builder::release): Rename.
6836         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6837         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6838         (write_exp_elt_longcst, write_exp_elt_floatcst)
6839         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6840         (write_exp_string_vector, write_exp_bitstring)
6841         (write_exp_msymbol, mark_struct_expression)
6842         (write_dollar_variable)
6843         (insert_type_address_space, increase_expout_size): Replace
6844         "parser_state" with "expr_builder".
6845         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6846         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6847         "parser_state" with "expr_builder".
6848
6849 2019-04-04  Tom Tromey  <tom@tromey.com>
6850
6851         * rust-exp.y: Replace "parse_language" with method call.
6852         * p-exp.y:
6853         (yylex): Replace "parse_language" with method call.
6854         * m2-exp.y:
6855         (yylex): Replace "parse_language" with method call.
6856         * go-exp.y (classify_name): Replace "parse_language" with method
6857         call.
6858         * f-exp.y (yylex): Replace "parse_language" with method call.
6859         * d-exp.y (lex_one_token): Replace "parse_language" with method
6860         call.
6861         * c-exp.y:
6862         (lex_one_token, classify_name, yylex): Replace "parse_language"
6863         with method call.
6864         * ada-exp.y (find_primitive_type, type_char)
6865         (type_system_address): Replace "parse_language" with method call.
6866
6867 2019-04-04  Tom Tromey  <tom@tromey.com>
6868
6869         * rust-exp.y: Replace "parse_gdbarch" with method call.
6870         * parse.c (write_dollar_variable, insert_type_address_space):
6871         Replace "parse_gdbarch" with method call.
6872         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6873         call.
6874         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6875         call.
6876         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6877         "parse_gdbarch" with method call.
6878         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6879         with method call.
6880         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6881         "parse_gdbarch" with method call.
6882         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6883         "parse_gdbarch" with method call.
6884         * c-exp.y (parse_type, parse_number, classify_name): Replace
6885         "parse_gdbarch" with method call.
6886         * ada-lex.l: Replace "parse_gdbarch" with method call.
6887         * ada-exp.y (parse_type, find_primitive_type, type_char)
6888         (type_system_address): Replace "parse_gdbarch" with method call.
6889
6890 2019-04-04  Tom Tromey  <tom@tromey.com>
6891
6892         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6893         * stap-probe.c (stap_parse_argument): Update.
6894         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6895         initial_size parameter.
6896         * rust-exp.y (rust_lex_tests): Update.
6897         * parse.c (parser_state): Update.
6898         (parse_exp_in_context): Update.
6899         * parser-defs.h (struct parser_state) <parser_state>: Remove
6900         "initial_size" parameter.
6901
6902 2019-04-04  Tom Tromey  <tom@tromey.com>
6903
6904         * parser-defs.h (increase_expout_size): Don't declare.
6905         * parse.c (increase_expout_size): Now static.
6906
6907 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6908
6909         * gnu-nat.c (gnu_nat_target::wait): Fix
6910         target_waitstatus_to_string call.
6911
6912 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6913
6914         * eval.c (evaluate_subexp_standard): Handle internal functions
6915         during Fortran function call handling.
6916
6917 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6918
6919         * NEWS: Mention new internal functions.
6920         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6921         (read_base_type): Use dwarf2_init_complex_target_type.
6922         * value.c (creal_internal_fn): New function.
6923         (cimag_internal_fn): New function.
6924         (_initialize_values): Register new internal functions.
6925
6926 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6927
6928         * infrun.c (stop_all_threads): If debug_infrun, always
6929         trace the wait status after wait_one, using
6930         target_waitstatus_to_string and target_pid_to_str.
6931         (handle_inferior_event): Replace various trace of
6932         wait status kind by a single trace.
6933         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6934         wait status kind image by target_waitstatus_to_string.
6935         * target/waitstatus.c (target_waitstatus_to_string): Fix
6936         obsolete comment.
6937
6938 2019-04-01  Tom Tromey  <tromey@adacore.com>
6939
6940         PR symtab/23331:
6941         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6942
6943 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6944             Pedro Alves  <palves@redhat.com>
6945
6946         * top.c (quit_force): Call 'finalize_values'.
6947         * value.c (finalize_values): New function.
6948         * value.h (finalize_values): Declare.
6949
6950 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6951
6952         * NEWS: Announce $_gdb_major and $_gdb_minor.
6953
6954         * top.c (init_gdb_version_vars): New function.
6955         (gdb_init): Call init_gdb_version_vars.
6956
6957 2019-03-29  Tom Tromey  <tromey@adacore.com>
6958
6959         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6960         help text.  Remove dead code.
6961
6962 2019-03-29  Keith Seitz  <keiths@redhat.com>
6963
6964         From Siddhesh Poyarekar:
6965         * f-lang.h (f77_get_upperbound): Return LONGEST.
6966         (f77_get_lowerbound): Likewise.
6967         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6968         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6969         print them.
6970         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6971         plongest to format print it.
6972         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6973         (f77_get_upperbound): Likewise.
6974         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6975         LOWER_BOUND to LONGEST.
6976         (f77_create_arrayprint_offset_tbl): Likewise.
6977
6978 2019-03-29  Keith Seitz  <keiths@redhat.com>
6979
6980         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6981         %s/pulongest for TYPE_LENGTH instead of %d in format
6982         strings.
6983         * ada-typerint.c (ada_print_type): Likewise.
6984         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6985         * compile/compile-c-support.c (generate_register_struct): Likewise.
6986         * gdbtypes.c (recursive_dump_type): Likewise.
6987         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6988         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6989         instead of %d in format strings.
6990         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6991         to std::min to ULONGEST.
6992         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6993         instead of %d in format strings.
6994         * tracepoint.c (info_scope_command): Likewise.
6995         * typeprint.c (print_offset_data::update)
6996         (print_offset_data::finish): Likewise.
6997         * xtensa-tdep.c (xtensa_store_return_value)
6998         (xtensa_push_dummy_call): Likewise.
6999
7000 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7001
7002         * windows-nat.c (display_selector): Fixed format specifications
7003         for 64-bit Cygwin.
7004
7005 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7006
7007         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7008
7009 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7010
7011         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7012         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7013         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7014         (nios2_linux_init_abi): Install it.
7015
7016 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7017
7018         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7019
7020 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7021
7022         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7023
7024 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7025             Tom Tromey  <tromey@adacore.com>
7026
7027         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7028
7029 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7030
7031         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7032         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7033         method to compute the bounds of range types. Also print "[evaluated]"
7034         if the bounds' values come from a dynamic evaluation.
7035
7036 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7037
7038         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7039         whitespace when pretty printing is on.
7040
7041 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7042
7043         * ppc-linux-nat.c: Add include.
7044
7045 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7046
7047         * NEWS: Mention AArch64 Pointer Authentication.
7048
7049 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7050
7051         * arm-linux-nat.c: Add include.
7052
7053 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7054
7055         * source-cache.c (source_cache::get_source_lines): Re-read
7056         fullname after calling open_source_file.
7057
7058 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7059
7060         * NEWS: Mention TLS support for FreeBSD.
7061
7062 2019-03-25  Tom Tromey  <tromey@adacore.com>
7063
7064         * minsyms.c (BUNCH_SIZE): Update comment.
7065         (~minimal_symbol_reader): Remove old comment.
7066         (compact_minimal_symbols): Update comment.
7067         (minimal_symbol_reader::install): Remove old comment.  Update
7068         other comments.
7069
7070 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7071
7072         * s390-linux-nat.c: Add include.
7073
7074 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7075
7076         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7077         Call linux_get_hwcap.
7078         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7079         Likewise.
7080         (aarch64_linux_get_hwcap): Remove function.
7081         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7082         declaration.
7083         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7084         linux_get_hwcap.
7085         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7086         * linux-tdep.c (linux_get_hwcap): Add function.
7087         (linux_get_hwcap2): Likewise.
7088         * linux-tdep.h (linux_get_hwcap): Add declaration.
7089         (linux_get_hwcap2): Likewise.
7090         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7091         (ppc_linux_get_hwcap2): Likewise.
7092         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7093         linux_get_hwcap.
7094         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7095         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7096         (ppc_linux_nat_target::read_description): Likewise.
7097         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7098         * s390-linux-nat.c: Likewise.
7099         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7100
7101 2019-03-24  Tom Tromey  <tom@tromey.com>
7102
7103         * ada-lang.c (standard_lookup): Simplify initialization.
7104         (ada_lookup_symbol_nonlocal): Simplify return.
7105         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7106         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7107         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7108         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7109         initialization.
7110         * solib.c (solib_global_lookup): Simplify.
7111         * symtab.c (null_block_symbol): Remove.
7112         (symbol_cache_lookup): Simplify returns.
7113         (lookup_language_this): Simplify returns.
7114         (lookup_symbol_aux): Simplify return.
7115         (lookup_local_symbol): Simplify returns.
7116         (lookup_global_symbol_from_objfile): Simplify return.
7117         (lookup_symbol_in_objfile_symtabs)
7118         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7119         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7120         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7121         * cp-namespace.c (cp_lookup_bare_symbol)
7122         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7123         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7124         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7125         (cp_lookup_symbol_via_imports): Simplify initialization.
7126         (find_symbol_in_baseclass): Likewise.
7127         * symtab.h (null_block_symbol): Remove.
7128         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7129         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7130         (d_lookup_symbol_module): Likewise.
7131         (find_symbol_in_baseclass): Simplify initialization.
7132
7133 2019-03-24  Tom Tromey  <tom@tromey.com>
7134
7135         * expression.h: Don't include symtab.h.
7136         (struct block): Forward declare.
7137
7138 2019-03-24  Tom Tromey  <tom@tromey.com>
7139
7140         * c-exp.y (typebase): Remove casts.
7141         * gdbtypes.c (lookup_unsigned_typename, )
7142         (lookup_signed_typename): Remove cast.
7143         * eval.c (parse_to_comma_and_eval): Remove cast.
7144         * parse.c (write_dollar_variable): Remove cast.
7145         * block.h (struct block) <superblock>: Now const.
7146         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7147         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7148         (map_block): Make "block" const.
7149         * symfile.h (struct quick_symbol_functions)
7150         <map_matching_symbols>: Constify block argument to "callback".
7151         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7152         const.
7153         (find_pc_sect_compunit_symtab): Make "b" const.
7154         (find_symbol_at_address): Likewise.
7155         (search_symbols): Likewise.
7156         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7157         (dw2_debug_names_lookup_symbol): Likewise.
7158         (dw2_map_matching_symbols): Update.
7159         * p-valprint.c (pascal_val_print): Remove "block".
7160         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7161         (aux_add_nonlocal_symbols): Make "block" const.
7162         (resolve_subexp): Remove cast.
7163         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7164         const.
7165         (iterate_over_file_blocks): Likewise.
7166         * f-exp.y (%union) <bval>: Remove.
7167         * coffread.c (patch_opaque_types): Make "b" const.
7168         * spu-tdep.c (spu_catch_start): Make "block" const.
7169         * c-valprint.c (print_unpacked_pointer): Remove "block".
7170         * symmisc.c (dump_symtab_1): Make "b" const.
7171         (block_depth): Make "block" const.
7172         * d-exp.y (%union) <bval>: Remove.
7173         * cp-support.h (cp_lookup_rtti_type): Update.
7174         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7175         * psymtab.c (psym_lookup_symbol): Make "block" const.
7176         (maintenance_check_psymtabs): Make "b" const.
7177         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7178         (enumerate_locals, enumerate_args): Update.
7179         * python/py-symtab.c (stpy_global_block): Make "block" const.
7180         (stpy_static_block): Likewise.
7181         * inline-frame.c (block_starting_point_at): Make "new_block"
7182         const.
7183         * block.c (find_block_in_blockvector): Make return type const.
7184         (blockvector_for_pc_sect): Make "b" const.
7185         (find_block_in_blockvector): Make "b" const.
7186
7187 2019-03-23  Tom Tromey  <tom@tromey.com>
7188
7189         * varobj.c (varobj_create): Update.
7190         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7191         * printcmd.c (display_command, do_one_display): Don't reset
7192         innermost_block.
7193         * parser-defs.h (enum innermost_block_tracker_type): Move to
7194         expression.h.
7195         (innermost_block): Update comment.
7196         * parse.c (parse_exp_1): Add tracker_types parameter.
7197         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7198         tracker_types parameter.  Reset innermost_block.
7199         (parse_exp_in_context): Remove.
7200         (parse_expression_for_completion): Update.
7201         * objfiles.c (~objfile): Don't reset expression_context_block or
7202         innermost_block.
7203         * expression.h (enum innermost_block_tracker_type): Move from
7204         parser-defs.h.
7205         (parse_exp_1): Add tracker_types parameter.
7206         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7207         reset innermost_block.
7208
7209 2019-03-23  Tom Tromey  <tom@tromey.com>
7210
7211         * objfiles.h: Include bcache.h.
7212
7213 2019-03-23  Tom Tromey  <tom@tromey.com>
7214
7215         * linespec.c (get_current_search_block): Use
7216         scoped_restore_current_language.
7217         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7218
7219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7220             Jiong Wang  <jiong.wang@arm.com>
7221
7222         * aarch64-linux-tdep.c
7223         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7224         section.
7225         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7226
7227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7228             Jiong Wang  <jiong.wang@arm.com>
7229
7230         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7231         instructions.
7232         (aarch64_analyze_prologue_test): Add PACIASP test.
7233         (aarch64_prologue_prev_register): Unmask PC value.
7234
7235 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7236             Jiong Wang  <jiong.wang@arm.com>
7237
7238         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7239         (aarch64_dwarf2_prev_register): Unmask PC value.
7240         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7241         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7242         DW_CFA_AARCH64_negate_ra_state.
7243         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7244
7245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7246             Jiong Wang  <jiong.wang@arm.com>
7247
7248         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7249         registers.
7250         (aarch64_pseudo_register_name): Likewise.
7251         (aarch64_pseudo_register_type): Likewise.
7252         (aarch64_pseudo_register_reggroup_p): Likewise.
7253         (aarch64_gdbarch_init): Add pauth registers.
7254         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7255         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7256         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7257         (struct gdbarch_tdep): Add regnum for ra_state.
7258
7259 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7260             Jiong Wang  <jiong.wang@arm.com>
7261
7262         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7263
7264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7265             Jiong Wang  <jiong.wang@arm.com>
7266
7267         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7268         function.
7269         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7270         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7271         (aarch64_gdbarch_init): Add puth registers.
7272         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7273         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7274         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7275
7276 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7277             Jiong Wang  <jiong.wang@arm.com>
7278
7279         * aarch64-linux-nat.c
7280         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7281         * aarch64-linux-tdep.c
7282         (aarch64_linux_core_read_description): Likewise.
7283         (aarch64_linux_get_hwcap): New function.
7284         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7285         (aarch64_linux_get_hwcap): New declaration.
7286
7287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7288             Jiong Wang  <jiong.wang@arm.com>
7289
7290         * aarch64-linux-nat.c
7291         (aarch64_linux_nat_target::read_description): Add pauth param.
7292         * aarch64-linux-tdep.c
7293         (aarch64_linux_core_read_description): Likewise.
7294         * aarch64-tdep.c (struct target_desc): Add in pauth.
7295         (aarch64_read_description): Add pauth param.
7296         (aarch64_gdbarch_init): Likewise.
7297         * aarch64-tdep.h (aarch64_read_description): Likewise.
7298         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7299         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7300         * features/Makefile: Add new files.
7301         * features/aarch64-pauth.c: New file.
7302         * features/aarch64-pauth.xml: New file.
7303
7304 2019-03-20  Tom Tromey  <tromey@adacore.com>
7305
7306         * infrun.c (handle_inferior_event): Rename from
7307         handle_inferior_event_1.  Create a scoped_value_mark.
7308         (handle_inferior_event): Remove.
7309
7310 2019-03-19  Tom Tromey  <tromey@adacore.com>
7311
7312         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7313         * infrun.h (print_stop_event): Add "displays" parameter.
7314         * infrun.c (print_stop_event): Add "displays" parameter.
7315
7316 2019-03-19  Pedro Alves  <palves@redhat.com>
7317
7318         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7319         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7320         to -1.  Fix TABs vs spaces.
7321         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7322         * tui/tui-out.h (tui_ui_out) Add intro comments.
7323         <m_line, m_start_of_line>: In-class initialize, and add describing
7324         comment.
7325
7326 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7327
7328         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7329         variable names.
7330         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7331
7332 2019-03-18  Pedro Alves  <palves@redhat.com>
7333             Eli Zaretskii <eliz@gnu.org>
7334
7335         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7336         m_line and m_start_of_line.
7337
7338 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7339
7340         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7341         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7342         it returns a newline.  This fixes a regression in TU mode, whereby
7343         the next line is output on the same screen line as the user input.
7344
7345 2019-03-18  Tom Tromey  <tromey@adacore.com>
7346
7347         * minsyms.c (minimal_symbol_reader::install): Remove call to
7348         obstack_blank.
7349
7350 2019-03-18  Pedro Alves  <palves@redhat.com>
7351
7352         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7353         New globals.
7354         (apply_style): New, factored out from ...
7355         (apply_ansi_escape): ... this.  Handle reverse video mode.
7356         (tui_set_reverse_mode): New function.
7357         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7358         * tui/tui-winsource.c (tui_show_source_line): Use
7359         tui_set_reverse_mode instead of setting A_STANDOUT.
7360         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7361         New setter methods.
7362
7363 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7364
7365         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7366         Handle tabs.
7367
7368 2019-03-18  Tom Tromey  <tromey@adacore.com>
7369
7370         * ada-lang.c (empty_array): Add "high" parameter.
7371         (ada_evaluate_subexp): Update.
7372
7373 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7374
7375         * unittests/string_view-selftests.c: Define
7376         _initialize_string_view_selftests unconditionally.
7377
7378 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7379
7380         PR gdb/24350
7381         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7382
7383 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7384
7385         PR gdb/24351
7386         * windows-nat.c (display_selector): Fix format specifiers.
7387
7388 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7389
7390         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7391         tui_refill_source_window instead of tui_refresh_win, to update the
7392         current execution line.  This fixes redisplay of the current line
7393         when stepping through the code with "next" or "step".
7394
7395 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7396
7397         * source-cache.c (source_cache::get_source_lines): Call
7398         find_source_lines to initialize s->nlines.  This fixes vertical
7399         scrolling of TUI source window when the DOWN arrow is pressed.
7400
7401 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7402
7403         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7404         linux-thread-db.c (_initialize_thread_db): Likewise.
7405
7406 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7407
7408         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7409         wclrtoeol in tui_show_source_line".  This reverts changes made in
7410         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7411
7412 2019-03-15  Tom Tromey  <tom@tromey.com>
7413
7414         * symtab.h (struct minimal_symbol): Derive from
7415         general_symbol_info.
7416         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7417         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7418         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7419         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7420         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7421         (MSYMBOL_SEARCH_NAME): Update.
7422         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7423         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7424         * minsyms.c (minimal_symbol_reader::record_full): Update.
7425
7426 2019-03-15  Tom Tromey  <tom@tromey.com>
7427
7428         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7429
7430 2019-03-15  Tom Tromey  <tom@tromey.com>
7431
7432         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7433         unique_xmalloc_ptr.
7434         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7435         Update.
7436         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7437         (build_minimal_symbol_hash_tables)
7438         (minimal_symbol_reader::install): Update.
7439
7440 2019-03-15  Tom Tromey  <tom@tromey.com>
7441
7442         * symtab.c (create_demangled_names_hash): Update.
7443         (symbol_set_names): Update.
7444         * objfiles.h (struct objfile_per_bfd_storage)
7445         <demangled_names_hash>: Now an htab_up.
7446         * objfiles.c (objfile_per_bfd_storage): Simplify.
7447
7448 2019-03-15  Tom Tromey  <tom@tromey.com>
7449
7450         * objfiles.h (struct objfile_per_bfd_storage): Declare
7451         destructor.
7452         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7453         New.
7454         (get_objfile_bfd_data): Use new.  Don't initialize
7455         language_of_main.
7456         (free_objfile_per_bfd_storage): Remove.
7457         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7458
7459 2019-03-15  Tom Tromey  <tom@tromey.com>
7460
7461         * symfile.c (reread_symbols): Update.
7462         * objfiles.c (objfile::objfile): Update.
7463         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7464         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7465         comment.
7466         (minimal_symbol_reader::install): Update.
7467         (terminate_minimal_symbol_table): Remove.
7468         * jit.c (jit_object_close_impl): Update.
7469
7470 2019-03-15  Tom Tromey  <tom@tromey.com>
7471
7472         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7473         initializations.
7474
7475 2019-03-15  Tom Tromey  <tom@tromey.com>
7476
7477         * objfiles.h (struct objfile_per_bfd_storage)
7478         <demangled_hash_languages>: Now a bitset.
7479         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7480         (lookup_minimal_symbol): Update.
7481
7482 2019-03-15  Tom Tromey  <tom@tromey.com>
7483
7484         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7485         Don't return the symbol.
7486         * coffread.c (record_minimal_symbol): Use record_full.
7487
7488 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7489
7490         The MS-Windows port of ncurses fails to switch to a color pair if
7491         one or both of the colors are the implicit default colors.  This
7492         change records the default colors when TUI is initialized, and
7493         then specifies them explicitly when a color pair uses the default
7494         colors.  This allows color styling in TUI mode on MS-Windows.
7495
7496         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7497         ncurses_norm_attr.
7498         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7499         colors in ncurses_norm_attr.
7500         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7501         "none", replace it with the default color recorded in
7502         ncurses_norm_attr.
7503
7504 2019-03-14  Tom Tromey  <tromey@adacore.com>
7505
7506         * source-cache.h (class source_cache) <get_source_lines>: Return
7507         std::string.
7508         * source-cache.c (source_cache::extract_lines): Handle case where
7509         first_pos==npos.  Return std::string.
7510         (source_cache::get_source_lines): Update.
7511
7512 2019-03-14  Tom Tromey  <tromey@adacore.com>
7513
7514         * NEWS: Add item for "style sources" commands.
7515         * source-cache.c (source_cache::get_source_lines): Check
7516         source_styling.
7517         * cli/cli-style.c (source_styling): New global.
7518         (_initialize_cli_style): Add "style sources" commands.
7519         (show_style_sources): New function.
7520         * cli/cli-style.h (source_styling): Declare.
7521
7522 2019-03-14  Pedro Alves  <palves@redhat.com>
7523             Tom Tromey  <tromey@adacore.com>
7524
7525         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7526         * tui/tui-winsource.c (tui_refill_source_window): New function,
7527         from...
7528         (tui_horizontal_source_scroll): ... here.  Move some logic.
7529         * cli/cli-style.c (set_style_enabled): Notify new observable.
7530         * tui/tui-hooks.c (tui_redisplay_source): New function.
7531         (tui_attach_detach_observers): Attach or detach
7532         tui_redisplay_source.
7533         * observable.h (source_styling_changed): New observable.
7534         * observable.c: Define source_styling_changed observable.
7535
7536 2019-03-13  Tom Tromey  <tromey@adacore.com>
7537
7538         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7539         (i386_gnu_nat_target::store_registers): Update.
7540         * target-debug.h (target_debug_print_std_string): New macro.
7541         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7542         * windows-tdep.c (display_one_tib): Update.
7543         * tui/tui-stack.c (tui_make_status_line): Update.
7544         * top.c (print_inferior_quit_action): Update.
7545         * thread.c (thr_try_catch_cmd): Update.
7546         (add_thread_with_info): Update.
7547         (thread_target_id_str): Update.
7548         (thr_try_catch_cmd): Update.
7549         (thread_command): Update.
7550         (thread_find_command): Update.
7551         * record-btrace.c (record_btrace_target::info_record)
7552         (record_btrace_resume_thread, record_btrace_target::resume)
7553         (record_btrace_cancel_resume, record_btrace_step_thread)
7554         (record_btrace_target::wait, record_btrace_target::wait)
7555         (record_btrace_target::wait, record_btrace_target::stop): Update.
7556         * progspace.c (print_program_space): Update.
7557         * process-stratum-target.c
7558         (process_stratum_target::thread_address_space): Update.
7559         * linux-fork.c (linux_fork_mourn_inferior)
7560         (detach_checkpoint_command, info_checkpoints_command)
7561         (linux_fork_context): Update.
7562         (linux_fork_detach): Update.
7563         (class scoped_switch_fork_info): Update.
7564         (delete_checkpoint_command): Update.
7565         * infrun.c (follow_fork_inferior): Update.
7566         (follow_fork_inferior): Update.
7567         (proceed_after_vfork_done): Update.
7568         (handle_vfork_child_exec_or_exit): Update.
7569         (follow_exec): Update.
7570         (displaced_step_prepare_throw): Update.
7571         (displaced_step_restore): Update.
7572         (start_step_over): Update.
7573         (resume_1): Update.
7574         (clear_proceed_status_thread): Update.
7575         (proceed): Update.
7576         (print_target_wait_results): Update.
7577         (do_target_wait): Update.
7578         (context_switch): Update.
7579         (stop_all_threads): Update.
7580         (restart_threads): Update.
7581         (finish_step_over): Update.
7582         (handle_signal_stop): Update.
7583         (switch_back_to_stepped_thread): Update.
7584         (keep_going_pass_signal): Update.
7585         (print_exited_reason): Update.
7586         (normal_stop): Update.
7587         * inferior.c (inferior_pid_to_str): Change return type.
7588         (print_selected_inferior): Update.
7589         (add_inferior): Update.
7590         (detach_inferior): Update.
7591         * dummy-frame.c (fprint_dummy_frames): Update.
7592         * dcache.c (dcache_info_1): Update.
7593         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7594         (btrace_fetch, btrace_clear): Update.
7595         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7596         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7597         type.
7598         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7599         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7600         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7601         * gdbarch.c, gdbarch.h: Rebuild.
7602         * gdbarch.sh (core_pid_to_str): Change return type.
7603         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7604         return type.
7605         (windows_nat_target::pid_to_str): Change return type.
7606         (windows_delete_thread): Update.
7607         (windows_nat_target::attach): Update.
7608         (windows_nat_target::files_info): Update.
7609         * target-delegates.c: Rebuild.
7610         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7611         return type.
7612         (sol_thread_target::pid_to_str): Change return type.
7613         * remote.c (class remote_target) <pid_to_str>: Change return
7614         type.
7615         (remote_target::pid_to_str): Change return type.
7616         (extended_remote_target::attach, remote_target::remote_stop_ns)
7617         (remote_target::remote_notif_remove_queued_reply)
7618         (remote_target::push_stop_reply, remote_target::disable_btrace):
7619         Update.
7620         (extended_remote_target::attach): Update.
7621         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7622         type.
7623         (gdbsim_target::pid_to_str): Change return type.
7624         * ravenscar-thread.c (struct ravenscar_thread_target)
7625         <pid_to_str>: Change return type.
7626         (ravenscar_thread_target::pid_to_str): Change return type.
7627         * procfs.c (class procfs_target) <pid_to_str>: Change return
7628         type.
7629         (procfs_target::pid_to_str): Change return type.
7630         (procfs_target::attach): Update.
7631         (procfs_target::detach): Update.
7632         (procfs_target::fetch_registers): Update.
7633         (procfs_target::store_registers): Update.
7634         (procfs_target::wait): Update.
7635         (procfs_target::files_info): Update.
7636         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7637         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7638         return type.
7639         (nto_procfs_target::pid_to_str): Change return type.
7640         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7641         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7642         return type.
7643         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7644         (exit_lwp): Update.
7645         (attach_proc_task_lwp_callback, get_detach_signal)
7646         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7647         (linux_nat_target::resume, wait_lwp, stop_callback)
7648         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7649         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7650         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7651         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7652         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7653         type.
7654         (inf_ptrace_target::attach): Update.
7655         (inf_ptrace_target::files_info): Update.
7656         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7657         type.
7658         (go32_nat_target::pid_to_str): Change return type.
7659         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7660         (gnu_nat_target::wait): Update.
7661         (gnu_nat_target::wait): Update.
7662         (gnu_nat_target::resume): Update.
7663         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7664         (fbsd_nat_target::wait): Update.
7665         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7666         type.
7667         (darwin_nat_target::attach): Update.
7668         * corelow.c (class core_target) <pid_to_str>: Change return type.
7669         (core_target::pid_to_str): Change return type.
7670         * target.c (normal_pid_to_str): Change return type.
7671         (default_pid_to_str): Likewise.
7672         (target_pid_to_str): Change return type.
7673         (target_translate_tls_address): Update.
7674         (target_announce_detach): Update.
7675         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7676         return type.
7677         (bsd_uthread_target::pid_to_str): Change return type.
7678         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7679         type.
7680         (bsd_kvm_target::pid_to_str): Change return type.
7681         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7682         return type.
7683         (aix_thread_target::pid_to_str): Change return type.
7684         * target.h (struct target_ops) <pid_to_str>: Change return type.
7685         (target_pid_to_str, normal_pid_to_str): Likewise.
7686         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7687         type.
7688         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7689         type.
7690         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7691         return type.
7692         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7693         type.
7694         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7695         type.
7696         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7697         return type.
7698
7699 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7700
7701         * NEWS: Mention that the new default MI version is 3.  Mention
7702         changes to the output of commands and events that deal with
7703         multi-location breakpoints.
7704         * breakpoint.c: Include "mi/mi-out.h".
7705         (print_one_breakpoint): Change output syntax if using MI version
7706         >= 3.
7707         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7708         New.
7709         (mi_multi_location_breakpoint_output_fixed): New.
7710         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7711         (mi_cmd_fix_multi_location_breakpoint_output): New.
7712         (mi_multi_location_breakpoint_output_fixed): New.
7713         * mi/mi-cmds.c (mi_cmds): Register command
7714         -fix-multi-location-breakpoint-output.
7715         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7716         interpreter "mi".
7717
7718 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7719
7720         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7721         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7722         instantiate mi_ui_out based on interpreter name.
7723         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7724         * mi/mi-main.c (mi_load_progress): Likewise.
7725
7726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7727
7728         * NEWS: Combine separate "New targets" sections for 8.3.
7729
7730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7731
7732         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7733         (ppcfbsd_init_abi): Install gdbarch
7734         "fetch_tls_load_module_address" and "get_thread_local_address"
7735         methods.
7736
7737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7738
7739         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7740         (riscv_fbsd_init_abi): Install gdbarch
7741         "fetch_tls_load_module_address" and "get_thread_local_address"
7742         methods.
7743
7744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7745
7746         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7747         (i386fbsd_init_abi): Install gdbarch
7748         "fetch_tls_load_module_address" and "get_thread_local_address"
7749         methods.
7750
7751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7752
7753         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7754         (amd64fbsd_init_abi): Install gdbarch
7755         "fetch_tls_load_module_address" and "get_thread_local_address"
7756         methods.
7757
7758 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7759
7760         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7761         (struct fbsd_pspace_data): New type.
7762         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7763         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7764         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7765         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7766         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7767
7768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7769
7770         * gdbtypes.c (lookup_struct_elt): New function.
7771         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7772         * gdbtypes.h (struct struct_elt): New type.
7773         (lookup_struct_elt): New prototype.
7774
7775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7776
7777         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7778         remove disabled code block.
7779
7780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7781
7782         * gdbarch.sh (get_thread_local_address): New method.
7783         * gdbarch.h, gdbarch.c: Regenerate.
7784         * target.c (target_translate_tls_address): Use
7785         gdbarch_get_thread_local_address if present instead of
7786         target::get_thread_local_address.
7787
7788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7789
7790         * target.h (target::get_thread_local_address): Update comment.
7791
7792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7793
7794         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7795         objfile->separate_debug_objfile_backlink if not NULL.
7796
7797 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7798
7799         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7800         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7801         (amd64bsd_store_inferior_registers): Likewise.
7802         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7803         Enable segment base registers.
7804         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7805         PT_GETFSBASE and PT_GETGSBASE.
7806         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7807         PT_SETGSBASE.
7808         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7809         segment base registers.
7810         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7811
7812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7813
7814         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7815         Update calls to i386_target_description to add 'segments'
7816         parameter.
7817         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7818         add segment base registers.
7819         * arch/i386.c (i386_create_target_description): Add 'segments'
7820         parameter to enable segment base registers.
7821         * arch/i386.h (i386_create_target_description): Likewise.
7822         * features/i386/32bit-segments.xml: New file.
7823         * features/i386/32bit-segments.c: Generate.
7824         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7825         call to i386_target_description to add 'segments' parameter.
7826         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7827         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7828         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7829         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7830         if feature is present.
7831         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7832         Add 'segments' parameter to call to i386_target_description.
7833         (i386_target_description): Add 'segments' parameter to enable
7834         segment base registers.
7835         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7836         to call to i386_target_description.
7837         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7838         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7839         Define I386_NUM_REGS.
7840         (i386_target_description): Add 'segments' parameter to enable
7841         segment base registers.
7842
7843 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7844
7845         PR/24325
7846         * source-cache.c: #undef open and close, to avoid unresolved
7847         externals during linking.
7848
7849 2019-03-12  Tom Tromey  <tromey@adacore.com>
7850
7851         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7852         const.  Add initializers.
7853         (_initialize_remote): Don't initialize ptid globals.
7854
7855 2019-03-12  Pedro Alves  <palves@redhat.com>
7856
7857         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7858
7859 2019-03-12  Pedro Alves  <palves@redhat.com>
7860
7861         * cp-name-parser.y (main): Remove unused 'len' variable.
7862
7863 2019-03-12  Tom Tromey  <tromey@adacore.com>
7864
7865         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7866         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7867
7868 2019-03-12  Tom Tromey  <tromey@adacore.com>
7869
7870         * linux-nat.c (iterate_over_lwps): Update.
7871         (stop_callback): Remove parameter.
7872         (stop_wait_callback, detach_callback, resume_set_callback)
7873         (select_singlestep_lwp_callback, set_ignore_sigint)
7874         (status_callback, resumed_callback, resume_clear_callback)
7875         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7876         data parameter.
7877         (linux_nat_target::detach, linux_nat_target::resume)
7878         (linux_stop_and_wait_all_lwps, select_event_lwp)
7879         (linux_nat_filter_event, linux_nat_wait_1)
7880         (linux_nat_target::kill, linux_nat_target::stop)
7881         (linux_nat_target::stop): Update.
7882         (linux_nat_resume_callback): Change type.
7883         (resume_stopped_resumed_lwps, count_events_callback)
7884         (select_event_lwp_callback): Likewise.
7885         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7886         * arm-linux-nat.c (struct update_registers_data): Remove.
7887         (update_registers_callback): Change type.
7888         (arm_linux_insert_hw_breakpoint1): Update.
7889         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7890         parameter.
7891         (x86_linux_dr_set_addr): Update.
7892         (x86_linux_dr_set_control): Update.
7893         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7894         (iterate_over_lwps): Use gdb::function_view.
7895         * nat/aarch64-linux-hw-point.c (struct
7896         aarch64_dr_update_callback_param): Remove.
7897         (debug_reg_change_callback): Change type.
7898         (aarch64_notify_debug_reg_change): Update.
7899         * s390-linux-nat.c (s390_refresh_per_info): Update.
7900
7901 2019-03-11  Tom Tromey  <tromey@adacore.com>
7902
7903         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7904         redundant assignment to "this_cu".
7905
7906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7907
7908         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7909
7910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7911
7912         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7913         from...
7914         (rank_one_type): ... this.
7915
7916 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7917
7918         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7919         from...
7920         (rank_one_type): ... this.
7921
7922 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7923
7924         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7925         from...
7926         (rank_one_type): ... this.
7927
7928 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7929
7930         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7931         from...
7932         (rank_one_type): ... this.
7933
7934 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7935
7936         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7937         from...
7938         (rank_one_type): ... this.
7939
7940 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7941
7942         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7943         from...
7944         (rank_one_type): ... this.
7945
7946 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7947
7948         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7949         from...
7950         (rank_one_type): ... this.
7951
7952 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7953
7954         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7955         from...
7956         (rank_one_type): ... this.
7957
7958 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7959
7960         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7961         from...
7962         (rank_one_type): ... this.
7963
7964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7965
7966         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7967         from...
7968         (rank_one_type): ... this.
7969
7970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7971
7972         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7973         from...
7974         (rank_one_type): ... this.
7975
7976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7977
7978         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7979         from...
7980         (rank_one_type): ... this.
7981
7982 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7983
7984         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7985         inferior-events' shows the example events.
7986
7987 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7988
7989         Support styling on native MS-Windows console
7990
7991         PR/24315
7992         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7993         on MS-Windows if $TERM is not defined.
7994
7995         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7996
7997         * posix-hdep.c (gdb_console_fputs):
7998         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7999         functions.
8000         * ui-file.h (gdb_console_fputs): Add prototype.
8001
8002         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8003         back to fputs only if the former returns zero.
8004
8005 2019-03-07  Tom Tromey  <tom@tromey.com>
8006
8007         * symmisc.c (print_symbol_bcache_statistics): Update.
8008         (print_objfile_statistics): Update.
8009         * symfile.c (allocate_symtab): Update.
8010         * stabsread.c: Don't include bcache.h.
8011         * psymtab.h (struct psymbol_bcache): Don't declare.
8012         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8013         (psymbol_bcache_init, psymbol_bcache_free)
8014         (psymbol_bcache_get_bcache): Don't declare.
8015         * psymtab.c (struct psymbol_bcache): Remove.
8016         (psymtab_storage::psymtab_storage): Update.
8017         (psymtab_storage::~psymtab_storage): Update.
8018         (psymbol_bcache_init, psymbol_bcache_free)
8019         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8020         (add_psymbol_to_bcache): Update.
8021         (allocate_psymtab): Update.
8022         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8023         macro_cache>: No longer pointers.
8024         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8025         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8026         * macrotab.c (macro_bcache): Update.
8027         * macroexp.c: Don't include bcache.h.
8028         * gdbtypes.c (check_types_worklist): Update.
8029         (types_deeply_equal): Remove TRY/CATCH.  Update.
8030         * elfread.c (elf_symtab_read): Update.
8031         * dwarf2read.c: Don't include bcache.h.
8032         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8033         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8034         (print_bcache_statistics, bcache_memory_used): Don't declare.
8035         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8036         methods.  Rename all data members.
8037         * bcache.c (struct bcache): Move to bcache.h.
8038         (bcache::expand_hash_table): Rename from expand_hash_table.
8039         (bcache): Remove.
8040         (bcache::insert): Rename from bcache_full.
8041         (bcache::compare): Rename from bcache_compare.
8042         (bcache_xmalloc): Remove.
8043         (bcache::~bcache): Rename from bcache_xfree.
8044         (bcache::print_statistics): Rename from print_bcache_statistics.
8045         (bcache::memory_used): Rename from bcache_memory_used.
8046
8047 2019-03-07  Pedro Alves  <palves@redhat.com>
8048
8049         * infrun.c (normal_stop): Also check for
8050         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8051
8052 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * f-lang.c (value_from_host_double): Moved to...
8055         * value.c (value_from_host_double): ...here.
8056         * value.h (value_from_host_double): Declare.
8057         * guile/scm-math.c (vlscm_convert_typed_number): Use
8058         value_from_host_double.
8059         (vlscm_convert_number): Likewise.
8060         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8061         * python/py-value.c (convert_value_from_python): Likewise.
8062
8063 2019-03-06  Tom Tromey  <tom@tromey.com>
8064
8065         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8066
8067 2019-03-06  Tom Tromey  <tom@tromey.com>
8068
8069         * utils.h (free_current_contents): Don't declare.
8070         * utils.c (free_current_contents): Remove.
8071
8072 2019-03-06  Tom Tromey  <tom@tromey.com>
8073
8074         * top.c (quit_force): Update.
8075         * main.c (captured_command_loop): Update.
8076         * common/new-op.c (operator new): Update.
8077         * common/common-exceptions.c (struct catcher)
8078         <save_cleanup_chain>: Remove member.
8079         (exceptions_state_mc_init): Update.
8080         (exception_try_scope_entry): Return nullptr.
8081         (exception_try_scope_exit, exception_rethrow)
8082         (throw_exception_sjlj, throw_exception_cxx): Update.
8083         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8084         (all_cleanups, do_cleanups, discard_cleanups)
8085         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8086         (restore_cleanups, restore_final_cleanups): Don't declare.
8087         (do_final_cleanups): Remove parameter.
8088         * common/cleanups.c (cleanup_chain, make_cleanup)
8089         (make_cleanup_dtor, all_cleanups, do_cleanups)
8090         (discard_my_cleanups, discard_cleanups)
8091         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8092         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8093         (null_cleanup): Remove.
8094         (do_final_cleanups): Remove parameter.
8095
8096 2019-03-06  Tom Tromey  <tom@tromey.com>
8097
8098         * remote.c (remote_target::remote_parse_stop_reply): Use
8099         unique_xmalloc_ptr.
8100
8101 2019-03-06  Tom Tromey  <tom@tromey.com>
8102
8103         * stabsread.c (struct stabs_field_info): Rename from field_info.
8104         <list, fnlist>: Add initializers.
8105         <obstack>: New member.
8106         (read_member_functions, read_struct_fields, read_baseclasses):
8107         Allocate on obstack.  Don't use cleanups.
8108         (read_one_struct_field, read_member_functions, read_struct_fields)
8109         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8110         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8111         (read_struct_type): Update.
8112
8113 2019-03-06  Tom Tromey  <tom@tromey.com>
8114
8115         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8116         * common/filestuff.h (make_cleanup_close): Don't declare.
8117         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8118         Remove.
8119
8120 2019-03-06  Tom Tromey  <tom@tromey.com>
8121
8122         * solib-aix.c: Use make_scope_exit.
8123
8124 2019-03-06  Tom Tromey  <tom@tromey.com>
8125
8126         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8127         Use make_scope_exit.
8128
8129 2019-03-06  Tom Tromey  <tom@tromey.com>
8130
8131         * solib-svr4.c (disable_probes_interface): Remove parameter.
8132         (svr4_handle_solib_event): Use make_scope_exit.
8133
8134 2019-03-06  Tom Tromey  <tom@tromey.com>
8135
8136         * remote.c (struct stop_reply_deleter): Remove.
8137         (stop_reply_up): Update.
8138         (struct stop_reply): Derive from notif_event.  Don't typedef.
8139         <regcache>: Now a std::vector.
8140         (stop_reply_xfree): Remove.
8141         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8142         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8143         (remote_target::discard_pending_stop_replies): Use delete.
8144         (remote_target::remote_parse_stop_reply): Update.
8145         (remote_target::process_stop_reply): Update.
8146         * remote-notif.h (struct notif_event): Add virtual destructor.
8147         Remove "dtr" member.
8148         (struct notif_client) <alloc_event>: Return a unique_ptr.
8149         (notif_event_xfree): Don't declare.
8150         (notif_event_up): New typedef.
8151         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8152         (notif_event_xfree, do_notif_event_xfree): Remove.
8153         (remote_notif_state_xfree): Update.
8154
8155 2019-03-06  Tom Tromey  <tom@tromey.com>
8156
8157         * infrun.c (displaced_step_clear_cleanup): Now a
8158         forward_scope_exit type.
8159         (displaced_step_prepare_throw): Update.
8160         (displaced_step_fixup): Update.
8161
8162 2019-03-06  Tom Tromey  <tom@tromey.com>
8163
8164         * inferior.h (class inferior): Update comment.
8165         * gdbthread.h (class thread_info): Update comment.
8166
8167 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8168             Tom Tromey  <tom@tromey.com>
8169
8170         * stabsread.h (struct stab_section_list): Remove.
8171         (coffstab_build_psymtabs): Update.
8172         * dbxread.c (symbuf_sections): Now a std::vector.
8173         (sect_idx): New global.
8174         (fill_symbuf): Update.
8175         (coffstab_build_psymtabs): Change type of stabsects parameter.
8176         Update.
8177         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8178         std::vector.
8179         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8180         (coff_locate_sections): Update.
8181         (coff_symfile_read): Remove cleanups.  Update.
8182         (init_stringtab): Add storage parameter.
8183         (free_stringtab, free_stringtab_cleanup): Remove.
8184         (init_lineno): Add storage parameter.
8185         (free_linetab, free_linetab_cleanup): Remove.
8186
8187 2019-03-06  Pedro Alves  <palves@redhat.com>
8188
8189         * linux-fork.c (fork_info::clobber_regs): Delete.
8190         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8191         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8192         comment.  Adjust.
8193         (scoped_switch_fork_info::scoped_switch_fork_info)
8194         (checkpoint_command, linux_fork_context): Adjust
8195         fork_save_infrun_state calls.
8196
8197 2019-03-06  Pedro Alves  <palves@redhat.com>
8198
8199         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8200         (inf_has_multiple_threads): Return 'bool' and rewrite using
8201         inferior_info::threads().
8202
8203 2019-03-06  Pedro Alves  <palves@redhat.com>
8204
8205         * linux-fork.c: Include <list>.
8206         (fork_list): Now a std::list instance.
8207         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8208         (forks_exist_p, find_last_fork): Adjust.
8209         (new_fork): Delete.
8210         (one_fork_p): New.
8211         (add_fork): Adjust.
8212         (free_fork): Delete, folded into fork_info::~fork_info().
8213         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8214         Adjust.
8215         (init_fork_list): Delete.
8216         (linux_fork_killall, linux_fork_mourn_inferior)
8217         (linux_fork_detach, info_checkpoints_command): Adjust.
8218         (_initialize_linux_fork): No longer call init_fork_list.
8219
8220 2019-03-06  Pedro Alves  <palves@redhat.com>
8221
8222         * linux-fork.c (new_fork): New, split out of ...
8223         (add_fork): ... this.  Return void.  Move "first fork" special
8224         case from here, to ...
8225         (checkpoint_command): ... here.
8226         * linux-linux.h (add_fork): Return void.
8227
8228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8229
8230         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8231
8232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8233             Chris January  <chris.january@arm.com>
8234             David Lecomber  <david.lecomber@arm.com>
8235
8236         * f-exp.y: New token, UNOP_INTRINSIC.
8237         (exp): New pattern using UNOP_INTRINSIC token.
8238         (f77_keywords): Add 'abs' keyword.
8239         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8240         (value_from_host_double): New function.
8241         (evaluate_subexp_f): Support UNOP_ABS.
8242
8243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8244
8245         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8246         types.
8247
8248 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8249
8250         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8251         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8252         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8253
8254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8255
8256         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8257
8258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8259             Chris January  <chris.january@arm.com>
8260
8261         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8262         * f-exp.y: Define 'KIND' token.
8263         (exp): New pattern for KIND expressions.
8264         (ptype): Handle types with a kind extension.
8265         (direct_abs_decl): Extend to spot kind extensions.
8266         (f77_keywords): Add 'kind' to the list.
8267         (push_kind_type): New function.
8268         (convert_to_kind_type): New function.
8269         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8270         * parse.c (operator_length_standard): Likewise.
8271         * parser-defs.h (enum type_pieces): Add tp_kind.
8272         * std-operator.def: Add UNOP_KIND.
8273
8274 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8275
8276         * f-exp.y (f_parse): Set yydebug.
8277
8278 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8279
8280         * f-lang.c (evaluate_subexp_f): New function.
8281         (exp_descriptor_f): New global.
8282         (f_language_defn): Use exp_descriptor_f instead of
8283         exp_descriptor_standard.
8284
8285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8286
8287         * f-exp.y (struct token): Add comments.
8288         (dot_ops): Remove uppercase versions and the end marker.
8289         (f77_keywords): Likewise.
8290         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8291         entries in the dot_ops array are case insensitive, and use
8292         strncasecmp to compare strings.  Also some whitespace cleanup in
8293         this area.  Similar for the f77_keywords array, except entries in
8294         this list might be case sensitive.
8295
8296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8297
8298         * f-exp.y (struct f77_boolean_val): Add comments.
8299         (boolean_values): Remove uppercase versions, and end marker.
8300         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8301         and use strncasecmp to achieve case insensitivity.  Additionally,
8302         perform whitespace cleanup around this code.
8303
8304 2019-03-06  Tom Tromey  <tromey@adacore.com>
8305
8306         * remote-sim.c (gdbsim_target_open): Use result of
8307         gdb_argv::release.
8308
8309 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8310         Dirk Schubert  <dirk.schubert@arm.com>
8311         Chris January  <chris.january@arm.com>
8312
8313         * eval.c (evaluate_subexp_standard): Call Fortran argument
8314         wrapping logic.
8315         * f-lang.c (struct value): A value which can be passed into a
8316         Fortran function call.
8317         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8318         where appropriate.
8319         (struct type): Value ready for a Fortran function call.
8320         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8321         is needed.
8322         * f-lang.h (fortran_argument_convert): Declaration.
8323         (fortran_preserve_arg_pointer): Declaration.
8324         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8325
8326 2019-03-05  Tom Tromey  <tromey@adacore.com>
8327
8328         * python/py-prettyprint.c (print_string_repr): Remove #if.
8329         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8330
8331 2019-03-05  Tom Tromey  <tromey@adacore.com>
8332
8333         * target.c (the_dummy_target): Move later.  Change type to
8334         "dummy_target".
8335         (initialize_targets): Don't initialize the_dummy_target.
8336
8337 2019-03-05  Tom Tromey  <tromey@adacore.com>
8338
8339         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8340         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8341
8342 2019-03-05  Tom Tromey  <tromey@adacore.com>
8343
8344         * windows-nat.c (windows_nat_target::attach)
8345         (windows_nat_target::detach): Don't call gdb_flush.
8346         * valprint.c (generic_val_print, val_print, val_print_string):
8347         Don't call gdb_flush.
8348         * utils.c (defaulted_query): Don't call gdb_flush.
8349         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8350         * target.c (target_announce_detach): Don't call gdb_flush.
8351         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8352         * remote.c (extended_remote_target::attach): Don't call
8353         gdb_flush.
8354         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8355         * printcmd.c (do_examine): Don't call gdb_flush.
8356         (info_display_command): Don't call gdb_flush.
8357         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8358         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8359         * memattr.c (info_mem_command): Don't call gdb_flush.
8360         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8361         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8362         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8363         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8364         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8365         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8366         (gnu_nat_target::detach): Don't call gdb_flush.
8367         * f-valprint.c (f_val_print): Don't call gdb_flush.
8368         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8369         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8370         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8371         gdb_flush.
8372         * c-valprint.c (c_val_print): Don't call gdb_flush.
8373         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8374
8375 2019-03-05  Tom Tromey  <tromey@adacore.com>
8376
8377         * varobj.c (update_dynamic_varobj_children): Update.
8378         (install_default_visualizer): Use reset, not release.
8379         * value.c (set_internalvar): Update.
8380         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8381         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8382         ATTRIBUTE_UNUSED_RESULT.
8383
8384 2019-03-05  Tom Tromey  <tromey@adacore.com>
8385
8386         * remote.c (class scoped_remote_fd) <release>: Add
8387         ATTRIBUTE_UNUSED_RESULT.
8388
8389 2019-03-05  Tom Tromey  <tromey@adacore.com>
8390
8391         * macroexp.c (struct macro_buffer) <release>: Add
8392         ATTRIBUTE_UNUSED_RESULT.
8393
8394 2019-03-05  Tom Tromey  <tromey@adacore.com>
8395
8396         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8397         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8398         ATTRIBUTE_UNUSED_RESULT.
8399
8400 2019-03-05  Tom Tromey  <tromey@adacore.com>
8401
8402         * common/scoped_fd.h (class scoped_fd) <release>: Add
8403         ATTRIBUTE_UNUSED_RESULT.
8404
8405 2019-03-05  Tom Tromey  <tromey@adacore.com>
8406
8407         * parser-defs.h (struct parser_state) <release>: Add
8408         ATTRIBUTE_UNUSED_RESULT.
8409
8410 2019-03-05  Tom Tromey  <tromey@adacore.com>
8411
8412         * utils.h (class gdb_argv) <release>: Add
8413         ATTRIBUTE_UNUSED_RESULT.
8414         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8415
8416 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8417
8418         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8419         for-loop range, to avoid compiler warnings.
8420
8421         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8422         avoid compiler warnings about unused variables.
8423
8424         * NEWS: Mention end of support for native debugging on MS-Windows
8425         before XP.
8426
8427         PR gdb/24292
8428         * common/netstuff.c:
8429         * gdbserver/gdbreplay.c
8430         * gdbserver/remote-utils.c:
8431         * ser-tcp.c:
8432         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8433         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8434         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8435         'getaddrinfo' and 'freeaddrinfo' were not available before
8436         Windows XP, and mingw.org's MinGW headers by default define
8437         _WIN32_WINNT to 0x500.
8438
8439 2019-03-01  Gary Benson <gbenson@redhat.com>
8440
8441         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8442
8443 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8444             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8445
8446         PR gdb/8527
8447         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8448         set_sigint_trap, clear_sigint_trap.
8449
8450 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8451
8452         * target.c (target_detach): Clear the regcache and the
8453         frame cache.
8454
8455 2019-02-27  Pedro Alves  <palves@redhat.com>
8456
8457         * utils.c (set_screen_size): When we cap the height/width sizes,
8458         tweak the corresponding command variable to show "unlimited":
8459
8460 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8461             Pedro Alves  <palves@redhat.com>
8462
8463         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8464         before calling rl_set_screen_size.
8465
8466 2019-02-27  Tom Tromey  <tromey@adacore.com>
8467
8468         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8469         define.
8470         * python/py-value.c: Remove Python 2.4 workaround.
8471         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8472         workaround.
8473         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8474         Python 2.4 workaround.
8475         * python/python-internal.h: Remove Python 2.4 comment.
8476         (Py_ssize_t): Don't define.
8477         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8478         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8479         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8480         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8481         * python/python.c (do_start_initialization): Remove Python 2.4
8482         workaround.
8483         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8484         (print_children): Remove Python 2.4 workaround.
8485         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8486         workaround.
8487         (CHARBUFFERPROC_NAME): Remove.
8488         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8489         Python 2.4 workaround.
8490
8491 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8492
8493         * NEWS: Note minimum Python version.
8494
8495 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8496
8497         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8498         code from these functions.  Remove corresponding ifdefs.  Use
8499         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8500         Remove gotos and target of gotos.
8501         (infpy_search_memory): Likewise.
8502
8503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8504
8505         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8506         (hppa_gdbarch_init): Don't register deleted functions with
8507         gdbarch.
8508
8509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8510
8511         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8512         (h8300_unwind_sp): Delete.
8513         (h8300_dummy_id): Delete.
8514         (h8300_gdbarch_init): Don't register deleted functions with
8515         gdbarch.
8516
8517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8518
8519         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8520         (ft32_unwind_pc): Delete.
8521         (ft32_unwind_sp): Delete.
8522         (ft32_gdbarch_init): Don't register deleted functions with
8523         gdbarch.
8524
8525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8526
8527         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8528         (frv_unwind_pc): Delete.
8529         (frv_unwind_sp): Delete.
8530         (frv_gdbarch_init): Don't register deleted functions with
8531         gdbarch.
8532
8533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8534
8535         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8536         (riscv_unwind_pc): Delete.
8537         (riscv_unwind_sp): Delete.
8538         (riscv_gdbarch_init): Don't register deleted functions with
8539         gdbarch.
8540
8541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8542
8543         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8544         (csky_unwind_pc): Delete.
8545         (csky_unwind_sp): Delete.
8546         (csky_gdbarch_init): Don't register deleted functions with
8547         gdbarch.
8548
8549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8550
8551         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8552         (cris_unwind_pc): Delete.
8553         (cris_unwind_sp): Delete.
8554         (cris_gdbarch_init): Don't register deleted functions with
8555         gdbarch.
8556
8557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8558
8559         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8560         (bfin_unwind_pc): Delete.
8561         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8562
8563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8564
8565         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8566         (arm_unwind_pc): Delete.
8567         (arm_unwind_sp): Delete.
8568         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8569
8570 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8571
8572         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8573         (arc_unwind_pc): Delete.
8574         (arc_unwind_sp): Delete.
8575         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8576
8577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8580         (alpha_unwind_pc): Delete.
8581         (alpha_gdbarch_init): Don't register deleted functions with
8582         gdbarch.
8583
8584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8585
8586         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8587         (aarch64_unwind_pc): Delete.
8588         (aarch64_unwind_sp): Delete.
8589         (aarch64_gdbarch_init): Don't register deleted functions with
8590         gdbarch.
8591
8592 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8593
8594         * gdbtypes.c (type_align): Don't consider static members when
8595         computing structure alignment.
8596
8597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8598
8599         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8600         return 0 for other types.
8601         * arch-utils.c (default_type_align): Always return 0.
8602         * gdbarch.h: Regenerate.
8603         * gdbarch.sh (type_align): Extend comment.
8604         * gdbtypes.c (type_align): Add additional comments, always call
8605         gdbarch_type_align before applying the default rules.
8606         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8607         generic code will then apply a suitable default.
8608         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8609         types, return 0 for other types.
8610
8611 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8612
8613         * NEWS: Create a new section for the next release branch.
8614         Rename the section of the current branch, now that it has
8615         been cut.
8616
8617 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8618
8619         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8620         * version.in: Bump version to 8.3.50.DATE-git.
8621
8622 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8623
8624         * aix-thread.c (ptid_cmp): Remove unused variable.
8625         (get_signaled_thread): Likewise.
8626         (store_regs_user_thread): Likewise.
8627         (store_regs_kernel_thread): Likewise.
8628         (fetch_regs_kernel_thread): Remove shadowed variable.
8629
8630 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8631
8632         * features/riscv/32bit-cpu.xml: Add register numbers.
8633         * features/riscv/32bit-fpu.c: Regenerate.
8634         * features/riscv/32bit-fpu.xml: Add register numbers.
8635         * features/riscv/64bit-cpu.xml: Add register numbers.
8636         * features/riscv/64bit-fpu.c: Regenerate.
8637         * features/riscv/64bit-fpu.xml: Add register numbers.
8638
8639 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8640
8641         * NEWS: Mention two argument form of gdb.Value constructor.
8642         * python/py-value.c (convert_buffer_and_type_to_value): New
8643         function.
8644         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8645         Add support for handling an optional second argument.  Call
8646         convert_buffer_and_type_to_value as appropriate.
8647         * python/python-internal.h (Py_buffer_deleter): New struct.
8648         (Py_buffer_up): New typedef.
8649
8650 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8651
8652         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8653         instead of releasing ownership.
8654
8655 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8656
8657         * dwarf2read.c (open_and_init_dwp_file): Call
8658         elf_numsections instead of bfd_count_sections to initialize
8659         dwp_file->num_sections.
8660
8661 2019-02-25  Tom Tromey  <tromey@adacore.com>
8662
8663         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8664
8665 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8666
8667         * gcore.in: Add '--readnever' option when invoking GDB.
8668
8669 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8670
8671         * MAINTAINERS: Update my email address.
8672
8673 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8674
8675         * build-id.c (build_id_to_debug_bfd_1): New function.
8676         (build_id_to_debug_bfd): Look for separate debug file in
8677         sysroot.
8678
8679 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8680
8681         * gdbarch.sh: Update the copyright year range that is placed into
8682         generated files.
8683
8684 2019-02-22  Keith Seitz  <keiths@redhat.com>
8685
8686         PR symtab/23853
8687         * linespec.c (create_sals_line_offset): Search for the default
8688         symtab's filename instead of its fullname.
8689
8690 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8691
8692         * NEWS: Update style defaults.
8693
8694 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8695
8696         * main.c (captured_main_1): Disable styling in batch mode.
8697
8698 2019-02-20  Tom Tromey  <tom@tromey.com>
8699
8700         * symtab.c (symtab_symbol_info): Fix typos.
8701
8702 2019-02-20  Tom Tromey  <tromey@adacore.com>
8703
8704         * findcmd.c (_initialize_mem_search): Use upper case for
8705         metasyntactic variables.
8706
8707 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8708
8709         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8710         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8711
8712 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8713
8714         * top.h (source_file_name): Change to std::string.
8715         * top.c (source_file_name): Likewise.
8716         (command_line_input): Adjust.
8717         * cli/cli-script.c (script_from_file): Adjust.
8718
8719 2019-02-19  Tom Tromey  <tromey@adacore.com>
8720
8721         * ravenscar-thread.c
8722         (ravenscar_thread_target::update_thread_list): Don't call
8723         ada_build_task_list.
8724         * ada-lang.h (ada_build_task_list): Don't declare.
8725         * ada-tasks.c (struct ada_tasks_inferior_data)
8726         <task_list_valid_p>: Now bool.
8727         (read_known_tasks, ada_task_list_changed)
8728         (ada_tasks_invalidate_inferior_data): Update.
8729         (read_known_tasks_array): Return bool.
8730         (read_known_tasks_list): Likewise.
8731         (read_known_tasks): Return void.
8732         (ada_build_task_list): Now static.
8733
8734 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8735
8736         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8737         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8738
8739 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8740
8741         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8742         variant for ada_tasks_pspace_data_handle and
8743         ada_tasks_inferior_data_handle.
8744         (ada_tasks_pspace_data_cleanup): New function.
8745         (ada_tasks_inferior_data_cleanup): New function.
8746
8747 2019-02-17  Tom Tromey  <tom@tromey.com>
8748
8749         * macrotab.h (macro_source_fullname): Return a std::string.
8750         * macrotab.c (macro_include, check_for_redefinition)
8751         (macro_undef, macro_lookup_definition, foreach_macro)
8752         (foreach_macro_in_scope): Update.
8753         (macro_source_fullname): Return a std::string.
8754         * macrocmd.c (show_pp_source_pos): Update.
8755
8756 2019-02-17  Tom Tromey  <tom@tromey.com>
8757
8758         * macrocmd.c (show_pp_source_pos): Style the file names.
8759
8760 2019-02-17  Tom Tromey  <tom@tromey.com>
8761
8762         PR tui/24197:
8763         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8764
8765 2019-02-17  Tom Tromey  <tom@tromey.com>
8766
8767         * ada-lang.c (user_select_syms): Use filtered printing.
8768         * utils.c (wrap_style): New global.
8769         (desired_style): Remove.
8770         (emit_style_escape): Add stream parameter.
8771         (set_output_style, reset_terminal_style, prompt_for_continue):
8772         Update.
8773         (flush_wrap_buffer): Only flush gdb_stdout.
8774         (wrap_here): Set wrap_style.
8775         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8776         treat escape sequences as a character.  Change when wrap buffer is
8777         flushed.
8778         (fputs_styled): Do not set the output style when the default is
8779         requested.
8780         * ui-style.h (struct ui_file_style) <is_default>: New method.
8781         * source.c (print_source_lines_base): Emit escape sequences in one
8782         piece.
8783
8784 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8785
8786         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8787         integers and enumeration types.
8788
8789 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8790
8791         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8792         instead of lookup_symbol_in_language
8793         (do_exact_match): New function.
8794         (ada_get_symbol_name_matcher): Return do_exact_match when
8795         doing a verbatim match.
8796
8797 2019-02-15  Tom Tromey  <tromey@adacore.com>
8798
8799         * ravenscar-thread.c (ravenscar_thread_target::resume)
8800         (ravenscar_thread_target::wait): Special case wildcard requests.
8801
8802 2019-02-15  Tom Tromey  <tromey@adacore.com>
8803
8804         * ravenscar-thread.c (base_ptid): Remove.
8805         (struct ravenscar_thread_target) <close>: New method.
8806         <m_base_ptid>: New member.
8807         <update_inferior_ptid, active_task, task_is_currently_active,
8808         runtime_initialized>: Declare methods.
8809         <ravenscar_thread_target>: Add constructor.
8810         (ravenscar_thread_target::task_is_currently_active)
8811         (ravenscar_thread_target::update_inferior_ptid)
8812         (ravenscar_runtime_initialized): Rename.  Now methods.
8813         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8814         (ravenscar_thread_target::update_thread_list): Update.
8815         (ravenscar_thread_target::active_task): Now method.
8816         (ravenscar_thread_target::store_registers)
8817         (ravenscar_thread_target::prepare_to_store)
8818         (ravenscar_thread_target::prepare_to_store)
8819         (ravenscar_thread_target::mourn_inferior): Update.
8820         (ravenscar_inferior_created): Use "new" to create target.
8821         (ravenscar_thread_target::get_ada_task_ptid): Update.
8822         (_initialize_ravenscar): Don't initialize base_ptid.
8823         (ravenscar_ops): Remove global.
8824
8825 2019-02-15  Tom Tromey  <tromey@adacore.com>
8826
8827         * target.h (push_target): Declare new overload.
8828         * target.c (push_target): New overload, taking an rvalue reference.
8829         * remote.c (remote_target::open_1): Use push_target overload.
8830         * corelow.c (core_target_open): Use push_target overload.
8831
8832 2019-02-15  Tom Tromey  <tromey@adacore.com>
8833
8834         * ravenscar-thread.c (is_ravenscar_task)
8835         (ravenscar_task_is_currently_active): Return bool.
8836         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8837         (_initialize_ravenscar): Remove "(void)".
8838         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8839         Return bool.
8840
8841 2019-02-15  Tom Tromey  <tromey@adacore.com>
8842
8843         * ravenscar-thread.c (ravenscar_runtime_initializer)
8844         (has_ravenscar_runtime, get_running_thread_id)
8845         (ravenscar_thread_target::resume): Fix indentation.
8846
8847 2019-02-15  Tom Tromey  <tromey@adacore.com>
8848
8849         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8850         from ravenscar_arch_ops.
8851         (sparc_ravenscar_ops::fetch_registers)
8852         (sparc_ravenscar_ops::store_registers): Now methods.
8853         (sparc_ravenscar_prepare_to_store): Remove.
8854         (sparc_ravenscar_ops): Redefine.
8855         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8856         methods and destructor.  Remove members.
8857         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8858         (ravenscar_thread_target::store_registers)
8859         (ravenscar_thread_target::prepare_to_store): Update.
8860         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8861         Remove.
8862         (struct ppc_ravenscar_powerpc_ops): Derive from
8863         ravenscar_arch_ops.
8864         (ppc_ravenscar_powerpc_ops::fetch_registers)
8865         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8866         (ppc_ravenscar_powerpc_ops): Redefine.
8867         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8868         (ppc_ravenscar_e500_ops::fetch_registers)
8869         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8870         (ppc_ravenscar_e500_ops): Redefine.
8871         * aarch64-ravenscar-thread.c
8872         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8873         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8874         (aarch64_ravenscar_fetch_registers)
8875         (aarch64_ravenscar_store_registers): Now methods.
8876         (aarch64_ravenscar_ops): Redefine.
8877
8878 2019-02-15  Tom Tromey  <tromey@adacore.com>
8879
8880         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8881         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8882         (ravenscar_thread_target::stopped_by_watchpoint)
8883         (ravenscar_thread_target::stopped_data_address)
8884         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8885
8886 2019-02-15  Tom Tromey  <tromey@adacore.com>
8887
8888         * ravenscar-thread.c: Fix some typos.
8889
8890 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8891             Tom Tromey  <tromey@adacore.com>
8892
8893         * ada-lang.c (ada_exception_sal): Change addr_string to a
8894         std::string.
8895         (create_ada_exception_catchpoint): Update.
8896
8897 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8898             Tom Tromey  <tromey@adacore.com>
8899
8900         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8901         (bp_location_ops): Remove.
8902         (base_breakpoint_allocate_location): Update.
8903         (free_bp_location): Update.
8904         * ada-lang.c (class ada_catchpoint_location)
8905         <ada_catchpoint_location>: Remove ops parameter.
8906         (ada_catchpoint_location_dtor): Remove.
8907         (ada_catchpoint_location_ops): Remove.
8908         (allocate_location_exception): Update.
8909         * breakpoint.h (struct bp_location_ops): Remove.
8910         (class bp_location) <bp_location>: Remove bp_location_ops
8911         parameter.
8912         <~bp_location>: Add destructor.
8913         <ops>: Remove.
8914
8915 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8916             Pedro Alves  <palves@redhat.com>
8917
8918         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8919         'PATH_MAX'.
8920
8921 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8922             Samuel Thibault  <samuel.thibault@gnu.org>
8923             Thomas Schwinge  <thomas@codesourcery.com>
8924
8925         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8926         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8927
8928 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8929
8930         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8931         (check_empty): Use "const char *".
8932
8933         * gnu-nat.c (gnu_nat_target::detach): Instead of
8934         'detach_inferior (pid)' call
8935         'detach_inferior (find_inferior_pid (pid))'.
8936
8937         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8938         'nat/fork-inferior.o'.
8939         * gnu-nat.c: #include "nat/fork-inferior.h".
8940
8941         * gnu-nat.c (gnu_nat_target::detach): Instead of
8942         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8943         * gnu-nat.h: #include "inf-child.h".
8944         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8945         'i386_gnu_nat_target::fetch_registers'.
8946         (gnu_store_registers): Rename/move to
8947         'i386_gnu_nat_target::store_registers'.
8948
8949         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8950         * gnu-nat.h (mach_thread_info): New function.
8951         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8952
8953         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8954
8955 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8956
8957         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8958
8959 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8960
8961         * windows-nat.c (windows_add_thread): Add new parameter
8962         "main_thread_p" with default value set to false.  Update
8963         function documentation as well as all callers.
8964         (windows_delete_thread): Likewise.
8965         (fake_create_process): Update call to windows_add_thread.
8966         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8967         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8968         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8969         call to windows_delete_thread.
8970
8971 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8972
8973         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8974
8975 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8976
8977         * symfile.c (find_separate_debug_file): Use canonical path of
8978         sysroot with child_path instead of gdb_sysroot if it is valid.
8979
8980 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8981
8982         * symfile.c (find_separate_debug_file): Use child_path to
8983         determine if an object file is under a sysroot.
8984
8985 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8986
8987         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8988         unittests/child-path-selftests.c.
8989         * common/pathstuff.c (child_path): New function.
8990         * common/pathstuff.h (child_path): New prototype.
8991         * unittests/child-path-selftests.c: New file.
8992
8993 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8994
8995         * symfile.c (find_separate_debug_file): Look for separate debug
8996         files in debug directories under the sysroot.
8997
8998 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8999
9000         * symtab.h (struct minimal_symbol data_p): New const method.
9001         (struct minimal_symbol text_p): Likewise.
9002         * symtab.c (output_source_filename): Use file name style
9003         to print file name.
9004         (print_symbol_info): Likewise.
9005         (print_msymbol_info): Use address style to print addresses.
9006         Use function name style to print executable text symbols.
9007         (expand_symtab_containing_pc): Use data_p.
9008         (find_pc_sect_compunit_symtab): Likewise.
9009
9010 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9011
9012         * breakpoint.c (describe_other_breakpoints): Use address style
9013         to print addresses.
9014         (say_where): Likewise.
9015
9016 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9017
9018         * ada-typeprint.c (print_func_type): Print function name
9019         style to print function name.
9020         * c-typeprint.c (c_print_type_1): Likewise.
9021
9022 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9023
9024         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9025         for execve.
9026
9027 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9028
9029         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9030         type_stack.
9031
9032 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9033
9034         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9035         TYPE_CODE_REF types.
9036
9037 2019-02-08  Jim Wilson  <jimw@sifive.com>
9038
9039         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9040         (riscv_linux_fregset): New.
9041         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9042
9043 2019-02-07  Tom Tromey  <tom@tromey.com>
9044
9045         * thread.c (thread_cancel_execution_command): Update.
9046         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9047         methods.
9048         (struct thread_fsm_ops): Remove.
9049         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9050         (thread_fsm_should_stop, thread_fsm_return_value)
9051         (thread_fsm_set_finished, thread_fsm_finished_p)
9052         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9053         Don't declare.
9054         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9055         * infrun.c (clear_proceed_status_thread)
9056         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9057         (print_stop_event): Update.
9058         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9059         Add constructor.
9060         (step_command_fsm_ops): Remove.
9061         (new_step_command_fsm): Remove.
9062         (step_1): Update.
9063         (step_command_fsm::should_stop): Rename from
9064         step_command_fsm_should_stop.
9065         (step_command_fsm::clean_up): Rename from
9066         step_command_fsm_clean_up.
9067         (step_command_fsm::do_async_reply_reason): Rename from
9068         step_command_fsm_async_reply_reason.
9069         (struct until_next_fsm): Inherit from thread_fsm.  Add
9070         constructor.
9071         (until_next_fsm_ops): Remove.
9072         (new_until_next_fsm): Remove.
9073         (until_next_fsm::should_stop): Rename from
9074         until_next_fsm_should_stop.
9075         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9076         (until_next_fsm::do_async_reply_reason): Rename from
9077         until_next_fsm_async_reply_reason.
9078         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9079         constructor.  Change type of breakpoint.
9080         (finish_command_fsm_ops): Remove.
9081         (new_finish_command_fsm): Remove.
9082         (finish_command_fsm::should_stop): Rename from
9083         finish_command_fsm_should_stop.
9084         (finish_command_fsm::clean_up): Rename from
9085         finish_command_fsm_clean_up.
9086         (finish_command_fsm::return_value): Rename from
9087         finish_command_fsm_return_value.
9088         (finish_command_fsm::do_async_reply_reason): Rename from
9089         finish_command_fsm_async_reply_reason.
9090         (finish_command): Update.
9091         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9092         Add constructor.
9093         (call_thread_fsm_ops): Remove.
9094         (call_thread_fsm::call_thread_fsm): Rename from
9095         new_call_thread_fsm.
9096         (call_thread_fsm::should_stop): Rename from
9097         call_thread_fsm_should_stop.
9098         (call_thread_fsm::should_notify_stop): Rename from
9099         call_thread_fsm_should_notify_stop.
9100         (run_inferior_call, call_function_by_hand_dummy): Update.
9101         * cli/cli-interp.c (should_print_stop_to_console): Update.
9102         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9103         Add constructor.  Change type of location_breakpoint,
9104         caller_breakpoint.
9105         (until_break_fsm_ops): Remove.
9106         (new_until_break_fsm): Remove.
9107         (until_break_fsm::should_stop): Rename from
9108         until_break_fsm_should_stop.
9109         (until_break_fsm::clean_up): Rename from
9110         until_break_fsm_clean_up.
9111         (until_break_fsm::do_async_reply_reason): Rename from
9112         until_break_fsm_async_reply_reason.
9113         (until_break_command): Update.
9114         * thread-fsm.c: Remove.
9115         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9116
9117 2019-02-07  Tom Tromey  <tom@tromey.com>
9118
9119         * yy-remap.h: Add include guard.
9120         * xtensa-tdep.h: Add include guard.
9121         * xcoffread.h: Rename include guard.
9122         * varobj-iter.h: Add include guard.
9123         * tui/tui.h: Rename include guard.
9124         * tui/tui-winsource.h: Rename include guard.
9125         * tui/tui-wingeneral.h: Rename include guard.
9126         * tui/tui-windata.h: Rename include guard.
9127         * tui/tui-win.h: Rename include guard.
9128         * tui/tui-stack.h: Rename include guard.
9129         * tui/tui-source.h: Rename include guard.
9130         * tui/tui-regs.h: Rename include guard.
9131         * tui/tui-out.h: Rename include guard.
9132         * tui/tui-layout.h: Rename include guard.
9133         * tui/tui-io.h: Rename include guard.
9134         * tui/tui-hooks.h: Rename include guard.
9135         * tui/tui-file.h: Rename include guard.
9136         * tui/tui-disasm.h: Rename include guard.
9137         * tui/tui-data.h: Rename include guard.
9138         * tui/tui-command.h: Rename include guard.
9139         * tic6x-tdep.h: Add include guard.
9140         * target/waitstatus.h: Rename include guard.
9141         * target/wait.h: Rename include guard.
9142         * target/target.h: Rename include guard.
9143         * target/resume.h: Rename include guard.
9144         * target-float.h: Rename include guard.
9145         * stabsread.h: Add include guard.
9146         * rs6000-tdep.h: Add include guard.
9147         * riscv-fbsd-tdep.h: Add include guard.
9148         * regformats/regdef.h: Rename include guard.
9149         * record.h: Rename include guard.
9150         * python/python.h: Rename include guard.
9151         * python/python-internal.h: Rename include guard.
9152         * python/py-stopevent.h: Rename include guard.
9153         * python/py-ref.h: Rename include guard.
9154         * python/py-record.h: Rename include guard.
9155         * python/py-record-full.h: Rename include guard.
9156         * python/py-record-btrace.h: Rename include guard.
9157         * python/py-instruction.h: Rename include guard.
9158         * python/py-events.h: Rename include guard.
9159         * python/py-event.h: Rename include guard.
9160         * procfs.h: Add include guard.
9161         * proc-utils.h: Add include guard.
9162         * p-lang.h: Add include guard.
9163         * or1k-tdep.h: Rename include guard.
9164         * observable.h: Rename include guard.
9165         * nto-tdep.h: Rename include guard.
9166         * nat/x86-linux.h: Rename include guard.
9167         * nat/x86-linux-dregs.h: Rename include guard.
9168         * nat/x86-gcc-cpuid.h: Add include guard.
9169         * nat/x86-dregs.h: Rename include guard.
9170         * nat/x86-cpuid.h: Rename include guard.
9171         * nat/ppc-linux.h: Rename include guard.
9172         * nat/mips-linux-watch.h: Rename include guard.
9173         * nat/linux-waitpid.h: Rename include guard.
9174         * nat/linux-ptrace.h: Rename include guard.
9175         * nat/linux-procfs.h: Rename include guard.
9176         * nat/linux-osdata.h: Rename include guard.
9177         * nat/linux-nat.h: Rename include guard.
9178         * nat/linux-namespaces.h: Rename include guard.
9179         * nat/linux-btrace.h: Rename include guard.
9180         * nat/glibc_thread_db.h: Rename include guard.
9181         * nat/gdb_thread_db.h: Rename include guard.
9182         * nat/gdb_ptrace.h: Rename include guard.
9183         * nat/fork-inferior.h: Rename include guard.
9184         * nat/amd64-linux-siginfo.h: Rename include guard.
9185         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9186         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9187         * nat/aarch64-linux.h: Rename include guard.
9188         * nat/aarch64-linux-hw-point.h: Rename include guard.
9189         * mn10300-tdep.h: Add include guard.
9190         * mips-linux-tdep.h: Add include guard.
9191         * mi/mi-parse.h: Rename include guard.
9192         * mi/mi-out.h: Rename include guard.
9193         * mi/mi-main.h: Rename include guard.
9194         * mi/mi-interp.h: Rename include guard.
9195         * mi/mi-getopt.h: Rename include guard.
9196         * mi/mi-console.h: Rename include guard.
9197         * mi/mi-common.h: Rename include guard.
9198         * mi/mi-cmds.h: Rename include guard.
9199         * mi/mi-cmd-break.h: Rename include guard.
9200         * m2-lang.h: Add include guard.
9201         * location.h: Rename include guard.
9202         * linux-record.h: Rename include guard.
9203         * linux-nat.h: Add include guard.
9204         * linux-fork.h: Add include guard.
9205         * i386-darwin-tdep.h: Rename include guard.
9206         * hppa-linux-offsets.h: Add include guard.
9207         * guile/guile.h: Rename include guard.
9208         * guile/guile-internal.h: Rename include guard.
9209         * gnu-nat.h: Rename include guard.
9210         * gdb-stabs.h: Rename include guard.
9211         * frv-tdep.h: Add include guard.
9212         * f-lang.h: Add include guard.
9213         * event-loop.h: Add include guard.
9214         * darwin-nat.h: Rename include guard.
9215         * cp-abi.h: Rename include guard.
9216         * config/sparc/nm-sol2.h: Rename include guard.
9217         * config/nm-nto.h: Rename include guard.
9218         * config/nm-linux.h: Add include guard.
9219         * config/i386/nm-i386gnu.h: Rename include guard.
9220         * config/djgpp/nl_types.h: Rename include guard.
9221         * config/djgpp/langinfo.h: Rename include guard.
9222         * compile/gcc-cp-plugin.h: Add include guard.
9223         * compile/gcc-c-plugin.h: Add include guard.
9224         * compile/compile.h: Rename include guard.
9225         * compile/compile-object-run.h: Rename include guard.
9226         * compile/compile-object-load.h: Rename include guard.
9227         * compile/compile-internal.h: Rename include guard.
9228         * compile/compile-cplus.h: Rename include guard.
9229         * compile/compile-c.h: Rename include guard.
9230         * common/xml-utils.h: Rename include guard.
9231         * common/x86-xstate.h: Rename include guard.
9232         * common/version.h: Rename include guard.
9233         * common/vec.h: Rename include guard.
9234         * common/tdesc.h: Rename include guard.
9235         * common/selftest.h: Rename include guard.
9236         * common/scoped_restore.h: Rename include guard.
9237         * common/scoped_mmap.h: Rename include guard.
9238         * common/scoped_fd.h: Rename include guard.
9239         * common/safe-iterator.h: Rename include guard.
9240         * common/run-time-clock.h: Rename include guard.
9241         * common/refcounted-object.h: Rename include guard.
9242         * common/queue.h: Rename include guard.
9243         * common/ptid.h: Rename include guard.
9244         * common/print-utils.h: Rename include guard.
9245         * common/preprocessor.h: Rename include guard.
9246         * common/pathstuff.h: Rename include guard.
9247         * common/observable.h: Rename include guard.
9248         * common/netstuff.h: Rename include guard.
9249         * common/job-control.h: Rename include guard.
9250         * common/host-defs.h: Rename include guard.
9251         * common/gdb_wait.h: Rename include guard.
9252         * common/gdb_vecs.h: Rename include guard.
9253         * common/gdb_unlinker.h: Rename include guard.
9254         * common/gdb_unique_ptr.h: Rename include guard.
9255         * common/gdb_tilde_expand.h: Rename include guard.
9256         * common/gdb_sys_time.h: Rename include guard.
9257         * common/gdb_string_view.h: Rename include guard.
9258         * common/gdb_splay_tree.h: Rename include guard.
9259         * common/gdb_setjmp.h: Rename include guard.
9260         * common/gdb_ref_ptr.h: Rename include guard.
9261         * common/gdb_optional.h: Rename include guard.
9262         * common/gdb_locale.h: Rename include guard.
9263         * common/gdb_assert.h: Rename include guard.
9264         * common/filtered-iterator.h: Rename include guard.
9265         * common/filestuff.h: Rename include guard.
9266         * common/fileio.h: Rename include guard.
9267         * common/environ.h: Rename include guard.
9268         * common/common-utils.h: Rename include guard.
9269         * common/common-types.h: Rename include guard.
9270         * common/common-regcache.h: Rename include guard.
9271         * common/common-inferior.h: Rename include guard.
9272         * common/common-gdbthread.h: Rename include guard.
9273         * common/common-exceptions.h: Rename include guard.
9274         * common/common-defs.h: Rename include guard.
9275         * common/common-debug.h: Rename include guard.
9276         * common/cleanups.h: Rename include guard.
9277         * common/buffer.h: Rename include guard.
9278         * common/btrace-common.h: Rename include guard.
9279         * common/break-common.h: Rename include guard.
9280         * cli/cli-utils.h: Rename include guard.
9281         * cli/cli-style.h: Rename include guard.
9282         * cli/cli-setshow.h: Rename include guard.
9283         * cli/cli-script.h: Rename include guard.
9284         * cli/cli-interp.h: Rename include guard.
9285         * cli/cli-decode.h: Rename include guard.
9286         * cli/cli-cmds.h: Rename include guard.
9287         * charset-list.h: Add include guard.
9288         * buildsym-legacy.h: Rename include guard.
9289         * bfin-tdep.h: Add include guard.
9290         * ax.h: Rename include guard.
9291         * arm-linux-tdep.h: Add include guard.
9292         * arm-fbsd-tdep.h: Add include guard.
9293         * arch/xtensa.h: Rename include guard.
9294         * arch/tic6x.h: Add include guard.
9295         * arch/i386.h: Add include guard.
9296         * arch/arm.h: Rename include guard.
9297         * arch/arm-linux.h: Rename include guard.
9298         * arch/arm-get-next-pcs.h: Rename include guard.
9299         * arch/amd64.h: Add include guard.
9300         * arch/aarch64-insn.h: Rename include guard.
9301         * arch-utils.h: Rename include guard.
9302         * annotate.h: Add include guard.
9303         * amd64-darwin-tdep.h: Rename include guard.
9304         * aarch64-linux-tdep.h: Add include guard.
9305         * aarch64-fbsd-tdep.h: Add include guard.
9306         * aarch32-linux-nat.h: Add include guard.
9307
9308 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9309
9310         * macrotab.c (macro_define_internal): New function that
9311         factorizes macro_define_object_internal and macro_define_function
9312         code.
9313         (macro_define_object_internal): Use macro_define_internal.
9314         (macro_define_function): Likewise.
9315
9316 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9317
9318         * macrocmd.c (extract_identifier): Return
9319         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9320         callers.
9321
9322 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9323
9324         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9325
9326 2019-02-05  Tom Tromey  <tom@tromey.com>
9327
9328         * target.c (target_stack::unpush): Move assertion earlier.
9329
9330 2019-01-30  Tom Tromey  <tom@tromey.com>
9331
9332         PR python/23615:
9333         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9334         (gdbpy_parse_and_eval): Likewise.
9335         * python/python-internal.h (gdbpy_allow_threads): New class.
9336
9337 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9338
9339         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9340         (aarch64_fbsd_fpregmap): Move earlier.
9341         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9342         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9343         instead of individual calls to trad_frame_set_reg_addr.
9344         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9345         earlier.
9346         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9347         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9348         instead of individual calls to trad_frame_set_reg_addr.
9349
9350 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9351
9352         * CONTRIBUTE: Replace contribution list with wiki link.
9353
9354 2019-01-25  Tom Tromey  <tom@tromey.com>
9355
9356         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9357
9358 2019-01-25  Tom Tromey  <tom@tromey.com>
9359
9360         * xtensa-linux-nat.c: Fix common/ includes.
9361         * xml-support.h: Fix common/ includes.
9362         * xml-support.c: Fix common/ includes.
9363         * x86-linux-nat.c: Fix common/ includes.
9364         * windows-nat.c: Fix common/ includes.
9365         * varobj.h: Fix common/ includes.
9366         * varobj.c: Fix common/ includes.
9367         * value.c: Fix common/ includes.
9368         * valops.c: Fix common/ includes.
9369         * utils.c: Fix common/ includes.
9370         * unittests/xml-utils-selftests.c: Fix common/ includes.
9371         * unittests/utils-selftests.c: Fix common/ includes.
9372         * unittests/unpack-selftests.c: Fix common/ includes.
9373         * unittests/tracepoint-selftests.c: Fix common/ includes.
9374         * unittests/style-selftests.c: Fix common/ includes.
9375         * unittests/string_view-selftests.c: Fix common/ includes.
9376         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9377         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9378         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9379         * unittests/rsp-low-selftests.c: Fix common/ includes.
9380         * unittests/parse-connection-spec-selftests.c: Fix common/
9381         includes.
9382         * unittests/optional-selftests.c: Fix common/ includes.
9383         * unittests/offset-type-selftests.c: Fix common/ includes.
9384         * unittests/observable-selftests.c: Fix common/ includes.
9385         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9386         * unittests/memrange-selftests.c: Fix common/ includes.
9387         * unittests/memory-map-selftests.c: Fix common/ includes.
9388         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9389         * unittests/function-view-selftests.c: Fix common/ includes.
9390         * unittests/environ-selftests.c: Fix common/ includes.
9391         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9392         * unittests/common-utils-selftests.c: Fix common/ includes.
9393         * unittests/cli-utils-selftests.c: Fix common/ includes.
9394         * unittests/array-view-selftests.c: Fix common/ includes.
9395         * ui-file.c: Fix common/ includes.
9396         * tui/tui-io.c: Fix common/ includes.
9397         * tracepoint.h: Fix common/ includes.
9398         * tracepoint.c: Fix common/ includes.
9399         * tracefile-tfile.c: Fix common/ includes.
9400         * top.h: Fix common/ includes.
9401         * top.c: Fix common/ includes.
9402         * thread.c: Fix common/ includes.
9403         * target/waitstatus.h: Fix common/ includes.
9404         * target/waitstatus.c: Fix common/ includes.
9405         * target.h: Fix common/ includes.
9406         * target.c: Fix common/ includes.
9407         * target-memory.c: Fix common/ includes.
9408         * target-descriptions.c: Fix common/ includes.
9409         * symtab.h: Fix common/ includes.
9410         * symfile.c: Fix common/ includes.
9411         * stap-probe.c: Fix common/ includes.
9412         * spu-linux-nat.c: Fix common/ includes.
9413         * sparc-nat.c: Fix common/ includes.
9414         * source.c: Fix common/ includes.
9415         * solib.c: Fix common/ includes.
9416         * solib-target.c: Fix common/ includes.
9417         * ser-unix.c: Fix common/ includes.
9418         * ser-tcp.c: Fix common/ includes.
9419         * ser-pipe.c: Fix common/ includes.
9420         * ser-base.c: Fix common/ includes.
9421         * selftest-arch.c: Fix common/ includes.
9422         * s12z-tdep.c: Fix common/ includes.
9423         * rust-exp.y: Fix common/ includes.
9424         * rs6000-aix-tdep.c: Fix common/ includes.
9425         * riscv-tdep.c: Fix common/ includes.
9426         * remote.c: Fix common/ includes.
9427         * remote-notif.h: Fix common/ includes.
9428         * remote-fileio.h: Fix common/ includes.
9429         * remote-fileio.c: Fix common/ includes.
9430         * regcache.h: Fix common/ includes.
9431         * regcache.c: Fix common/ includes.
9432         * record-btrace.c: Fix common/ includes.
9433         * python/python.c: Fix common/ includes.
9434         * python/py-type.c: Fix common/ includes.
9435         * python/py-inferior.c: Fix common/ includes.
9436         * progspace.h: Fix common/ includes.
9437         * producer.c: Fix common/ includes.
9438         * procfs.c: Fix common/ includes.
9439         * proc-api.c: Fix common/ includes.
9440         * printcmd.c: Fix common/ includes.
9441         * ppc-linux-nat.c: Fix common/ includes.
9442         * parser-defs.h: Fix common/ includes.
9443         * osdata.c: Fix common/ includes.
9444         * obsd-nat.c: Fix common/ includes.
9445         * nat/x86-linux.c: Fix common/ includes.
9446         * nat/x86-linux-dregs.c: Fix common/ includes.
9447         * nat/x86-dregs.h: Fix common/ includes.
9448         * nat/x86-dregs.c: Fix common/ includes.
9449         * nat/ppc-linux.c: Fix common/ includes.
9450         * nat/mips-linux-watch.h: Fix common/ includes.
9451         * nat/mips-linux-watch.c: Fix common/ includes.
9452         * nat/linux-waitpid.c: Fix common/ includes.
9453         * nat/linux-ptrace.h: Fix common/ includes.
9454         * nat/linux-ptrace.c: Fix common/ includes.
9455         * nat/linux-procfs.c: Fix common/ includes.
9456         * nat/linux-personality.c: Fix common/ includes.
9457         * nat/linux-osdata.c: Fix common/ includes.
9458         * nat/linux-namespaces.c: Fix common/ includes.
9459         * nat/linux-btrace.h: Fix common/ includes.
9460         * nat/linux-btrace.c: Fix common/ includes.
9461         * nat/fork-inferior.c: Fix common/ includes.
9462         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9463         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9464         * nat/aarch64-linux.c: Fix common/ includes.
9465         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9466         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9467         * namespace.h: Fix common/ includes.
9468         * mips-linux-tdep.c: Fix common/ includes.
9469         * minsyms.c: Fix common/ includes.
9470         * mi/mi-parse.h: Fix common/ includes.
9471         * mi/mi-main.c: Fix common/ includes.
9472         * mi/mi-cmd-env.c: Fix common/ includes.
9473         * memrange.h: Fix common/ includes.
9474         * memattr.c: Fix common/ includes.
9475         * maint.h: Fix common/ includes.
9476         * maint.c: Fix common/ includes.
9477         * main.c: Fix common/ includes.
9478         * machoread.c: Fix common/ includes.
9479         * location.c: Fix common/ includes.
9480         * linux-thread-db.c: Fix common/ includes.
9481         * linux-nat.c: Fix common/ includes.
9482         * linux-fork.c: Fix common/ includes.
9483         * inline-frame.c: Fix common/ includes.
9484         * infrun.c: Fix common/ includes.
9485         * inflow.c: Fix common/ includes.
9486         * inferior.h: Fix common/ includes.
9487         * inferior.c: Fix common/ includes.
9488         * infcmd.c: Fix common/ includes.
9489         * inf-ptrace.c: Fix common/ includes.
9490         * inf-child.c: Fix common/ includes.
9491         * ia64-linux-nat.c: Fix common/ includes.
9492         * i387-tdep.c: Fix common/ includes.
9493         * i386-tdep.c: Fix common/ includes.
9494         * i386-linux-tdep.c: Fix common/ includes.
9495         * i386-linux-nat.c: Fix common/ includes.
9496         * i386-go32-tdep.c: Fix common/ includes.
9497         * i386-fbsd-tdep.c: Fix common/ includes.
9498         * i386-fbsd-nat.c: Fix common/ includes.
9499         * guile/scm-type.c: Fix common/ includes.
9500         * guile/guile.c: Fix common/ includes.
9501         * go32-nat.c: Fix common/ includes.
9502         * gnu-nat.c: Fix common/ includes.
9503         * gdbthread.h: Fix common/ includes.
9504         * gdbarch-selftests.c: Fix common/ includes.
9505         * gdb_usleep.c: Fix common/ includes.
9506         * gdb_select.h: Fix common/ includes.
9507         * gdb_bfd.c: Fix common/ includes.
9508         * gcore.c: Fix common/ includes.
9509         * fork-child.c: Fix common/ includes.
9510         * findvar.c: Fix common/ includes.
9511         * fbsd-nat.c: Fix common/ includes.
9512         * event-top.c: Fix common/ includes.
9513         * event-loop.c: Fix common/ includes.
9514         * dwarf2read.c: Fix common/ includes.
9515         * dwarf2loc.c: Fix common/ includes.
9516         * dwarf2-frame.c: Fix common/ includes.
9517         * dwarf-index-cache.c: Fix common/ includes.
9518         * dtrace-probe.c: Fix common/ includes.
9519         * disasm-selftests.c: Fix common/ includes.
9520         * defs.h: Fix common/ includes.
9521         * csky-tdep.c: Fix common/ includes.
9522         * cp-valprint.c: Fix common/ includes.
9523         * cp-support.h: Fix common/ includes.
9524         * cp-support.c: Fix common/ includes.
9525         * corelow.c: Fix common/ includes.
9526         * completer.h: Fix common/ includes.
9527         * completer.c: Fix common/ includes.
9528         * compile/compile.c: Fix common/ includes.
9529         * compile/compile-loc2c.c: Fix common/ includes.
9530         * compile/compile-cplus-types.c: Fix common/ includes.
9531         * compile/compile-cplus-symbols.c: Fix common/ includes.
9532         * command.h: Fix common/ includes.
9533         * cli/cli-dump.c: Fix common/ includes.
9534         * cli/cli-cmds.c: Fix common/ includes.
9535         * charset.c: Fix common/ includes.
9536         * build-id.c: Fix common/ includes.
9537         * btrace.h: Fix common/ includes.
9538         * btrace.c: Fix common/ includes.
9539         * breakpoint.h: Fix common/ includes.
9540         * breakpoint.c: Fix common/ includes.
9541         * ax.h:
9542         (enum agent_op): Fix common/ includes.
9543         * ax-general.c (struct aop_map): Fix common/ includes.
9544         * ax-gdb.c: Fix common/ includes.
9545         * auxv.c: Fix common/ includes.
9546         * auto-load.c: Fix common/ includes.
9547         * arm-tdep.c: Fix common/ includes.
9548         * arch/riscv.c: Fix common/ includes.
9549         * arch/ppc-linux-common.c: Fix common/ includes.
9550         * arch/i386.c: Fix common/ includes.
9551         * arch/arm.c: Fix common/ includes.
9552         * arch/arm-linux.c: Fix common/ includes.
9553         * arch/arm-get-next-pcs.c: Fix common/ includes.
9554         * arch/amd64.c: Fix common/ includes.
9555         * arch/aarch64.c: Fix common/ includes.
9556         * arch/aarch64-insn.c: Fix common/ includes.
9557         * arch-utils.c: Fix common/ includes.
9558         * amd64-windows-tdep.c: Fix common/ includes.
9559         * amd64-tdep.c: Fix common/ includes.
9560         * amd64-sol2-tdep.c: Fix common/ includes.
9561         * amd64-obsd-tdep.c: Fix common/ includes.
9562         * amd64-nbsd-tdep.c: Fix common/ includes.
9563         * amd64-linux-tdep.c: Fix common/ includes.
9564         * amd64-linux-nat.c: Fix common/ includes.
9565         * amd64-fbsd-tdep.c: Fix common/ includes.
9566         * amd64-fbsd-nat.c: Fix common/ includes.
9567         * amd64-dicos-tdep.c: Fix common/ includes.
9568         * amd64-darwin-tdep.c: Fix common/ includes.
9569         * agent.c: Fix common/ includes.
9570         * ada-lang.h: Fix common/ includes.
9571         * ada-lang.c: Fix common/ includes.
9572         * aarch64-tdep.c: Fix common/ includes.
9573
9574 2019-01-25  Tom Tromey  <tom@tromey.com>
9575
9576         * common/create-version.sh: Use common/version.h.
9577
9578 2019-01-24  Pedro Alves  <palves@redhat.com>
9579
9580         * infrun.c (signal_stop, signal_print, signal_program)
9581         (signal_catch, signal_pass): Now arrays instead of pointers.
9582         (update_signals_program_target, do_target_resume)
9583         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9584         * linux-nat.c (linux_nat_target::pass_signals)
9585         (linux_nat_target::create_inferior, linux_nat_target::attach):
9586         Adjust.
9587         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9588         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9589         * procfs.c (procfs_target::pass_signals): Adjust.
9590         * record-full.c (record_full_target::resume): Adjust.
9591         * remote.c (remote_target::pass_signals)
9592         (remote_target::program_signals): Adjust.
9593         * target-debug.h (target_debug_print_signals): Now takes a
9594         gdb::array_view as parameter.  Adjust.
9595         * target.h (target_ops) <pass_signals, program_signals>: Replace
9596         pointer and length parameters with gdb::array_view.
9597         (target_pass_signals, target_program_signals): Likewise.
9598         * target-delegates.c: Regenerate.
9599
9600 2019-01-24  Pedro Alves  <palves@redhat.com>
9601
9602         * common/forward-scope-exit.h
9603         (forward_scope_exit::forward_scope_exit): Pass arguments to
9604         m_bind_function directly, instead of creating a std::bind and
9605         copying that.
9606
9607 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9608
9609         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9610         for static members.
9611         (pass_in_v_vfp_candidate): Likewise.
9612
9613 2019-01-23  Tom Tromey  <tom@tromey.com>
9614             Pedro Alves  <palves@redhat.com>
9615
9616         * regcache.c (class regcache_invalidator): Remove.
9617         (regcache::raw_write): Use make_scope_exit.
9618
9619 2019-01-23  Tom Tromey  <tom@tromey.com>
9620
9621         * ui-out.h (class ui_out_emit_type): Update comment.
9622
9623 2019-01-23  Tom Tromey  <tom@tromey.com>
9624
9625         * infrun.c (fetch_inferior_event): Update comment.
9626
9627 2019-01-23  Tom Tromey  <tom@tromey.com>
9628             Pedro Alves  <palves@redhat.com>
9629
9630         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9631         parameter.
9632         (fetch_inferior_event): Use SCOPE_EXIT.
9633
9634
9635 2019-01-23  Tom Tromey  <tom@tromey.com>
9636             Pedro Alves  <palves@redhat.com>
9637
9638         * infrun.c (disable_thread_events): Delete.
9639         (stop_all_threads): Use SCOPE_EXIT.
9640
9641 2019-01-23  Tom Tromey  <tom@tromey.com>
9642             Pedro Alves  <palves@redhat.com>
9643
9644         * symfile.c: Include forward-scope-exit.h.
9645         (clear_symtab_users_cleanup): Replace forward declaration with
9646         a FORWARD_SCOPE_EXIT.
9647         (syms_from_objfile_1): Use the forward_scope_exit and
9648         gdb::optional instead of cleanup_function.
9649         (reread_symbols): Use the forward_scope_exit instead of
9650         cleanup_function.
9651         (clear_symtab_users_cleanup): Remove function.
9652
9653 2019-01-23  Tom Tromey  <tom@tromey.com>
9654             Pedro Alves  <palves@redhat.com>
9655
9656         * linux-nat.c: Include scope-exit.h.
9657         (cleanup_target_stop): Remove.
9658         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9659         SCOPE_EXIT.
9660
9661 2019-01-23  Tom Tromey  <tom@tromey.com>
9662             Pedro Alves  <palves@redhat.com>
9663
9664         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9665         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9666
9667 2019-01-23  Tom Tromey  <tom@tromey.com>
9668             Andrew Burgess  <andrew.burgess@embecosm.com>
9669             Pedro Alves  <palves@redhat.com>
9670
9671         * infrun.c (fetch_inferior_event): Use scope_exit.
9672         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9673         * top.c (execute_command): Use scope_exit.
9674         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9675         * utils.c (do_bpstat_clear_actions_cleanup)
9676         (make_bpstat_clear_actions_cleanup): Remove.
9677
9678 2019-01-23  Tom Tromey  <tom@tromey.com>
9679             Pedro Alves  <palves@redhat.com>
9680
9681         * infrun.c: Include "common/scope-exit.h"
9682         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9683         (wait_for_inferior): Use SCOPE_EXIT.
9684         (fetch_inferior_event): Use scope_exit.
9685
9686 2019-01-23  Tom Tromey  <tom@tromey.com>
9687             Pedro Alves  <palves@redhat.com>
9688
9689         * breakpoint.c (create_breakpoint): Remove cleanup.
9690
9691 2019-01-23  Tom Tromey  <tom@tromey.com>
9692             Andrew Burgess  <andrew.burgess@embecosm.com>
9693             Pedro Alves  <palves@redhat.com>
9694
9695 2019-01-23  Pedro Alves  <palves@redhat.com>
9696
9697         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9698
9699 2019-01-23  Pedro Alves  <palves@redhat.com>
9700             Andrew Burgess  <andrew.burgess@embecosm.com>
9701
9702         * gdbthread.h: Include "common/forward-scope-exit.h".
9703         (scoped_finish_thread_state): Redefine custom class in terms of
9704         forward_scope_exit.
9705
9706 2019-01-23  Pedro Alves  <palves@redhat.com>
9707             Andrew Burgess  <andrew.burgess@embecosm.com>
9708
9709         * common/forward-scope-exit.h: New file.
9710
9711 2019-01-23  Pedro Alves  <palves@redhat.com>
9712             Andrew Burgess  <andrew.burgess@embecosm.com>
9713             Tom Tromey  <tom@tromey.com>
9714
9715         * common/scope-exit.h: New file.
9716
9717 2019-01-23  Pedro Alves  <palves@redhat.com>
9718
9719         * common/preprocessor.h (ESC): Rename to ...
9720         (ESC_PARENS): ... this.
9721         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9722         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9723
9724 2019-01-23  Tom Tromey  <tom@tromey.com>
9725
9726         * language.h (class scoped_switch_to_sym_language_if_auto):
9727         Initialize m_lang in both cases.
9728
9729 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9730
9731         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9732         with XCNEW.
9733
9734 2019-01-22  Tom Tromey  <tom@tromey.com>
9735
9736         * corelow.c: Do not include sys/file.h.
9737
9738 2019-01-22  Tom Tromey  <tom@tromey.com>
9739
9740         * tui/tui-wingeneral.h: Include gdb_curses.h.
9741
9742 2019-01-22  Tom Tromey  <tom@tromey.com>
9743
9744         * source-cache.h (class source_cache) <get_source_lines,
9745         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9746
9747 2019-01-22  Tom Tromey  <tom@tromey.com>
9748
9749         * remote-fileio.h (struct remote_target): Declare.
9750
9751 2019-01-22  Tom Tromey  <tom@tromey.com>
9752
9753         * python/py-arch.c: Do not include py-ref.h.
9754         * python/py-bpevent.c: Do not include py-ref.h.
9755         * python/py-cmd.c: Do not include py-ref.h.
9756         * python/py-continueevent.c: Do not include py-ref.h.
9757         * python/py-event.h: Do not include py-ref.h.
9758         * python/py-evtregistry.c: Do not include py-ref.h.
9759         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9760         * python/py-frame.c: Do not include py-ref.h.
9761         * python/py-framefilter.c: Do not include py-ref.h.
9762         * python/py-function.c: Do not include py-ref.h.
9763         * python/py-infevents.c: Do not include py-ref.h.
9764         * python/py-linetable.c: Do not include py-ref.h.
9765         * python/py-objfile.c: Do not include py-ref.h.
9766         * python/py-param.c: Do not include py-ref.h.
9767         * python/py-prettyprint.c: Do not include py-ref.h.
9768         * python/py-progspace.c: Do not include py-ref.h.
9769         * python/py-symbol.c: Do not include py-ref.h.
9770         * python/py-symtab.c: Do not include py-ref.h.
9771         * python/py-type.c: Do not include py-ref.h.
9772         * python/py-unwind.c: Do not include py-ref.h.
9773         * python/py-utils.c: Do not include py-ref.h.
9774         * python/py-value.c: Do not include py-ref.h.
9775         * python/py-varobj.c: Do not include py-ref.h.
9776         * python/py-xmethods.c: Do not include py-ref.h.
9777         * python/python.c: Do not include py-ref.h.
9778         * varobj.c: Do not include py-ref.h.
9779
9780 2019-01-22  Tom Tromey  <tom@tromey.com>
9781
9782         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9783         keyword for bcache.
9784
9785 2019-01-22  Tom Tromey  <tom@tromey.com>
9786
9787         * compile/compile-cplus-types.c: Remove a comment by #include.
9788
9789 2019-01-22  Tom Tromey  <tom@tromey.com>
9790
9791         * compile/gcc-c-plugin.h: Include compile-internal.h.
9792
9793 2019-01-22  Tom Tromey  <tom@tromey.com>
9794
9795         * stabsread.c (EXTERN): Do not define.
9796         (symnum, next_symbol_text_func, processing_gcc_compilation)
9797         (within_function, global_sym_chain, global_stabs)
9798         (previous_stab_code, this_object_header_files)
9799         (n_this_object_header_files)
9800         (n_allocated_this_object_header_files): Define.
9801         * stabsread.h (EXTERN): Never define.  Use "extern".
9802
9803 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9804
9805         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9806         history_value.
9807
9808 2019-01-21  Tom Tromey  <tom@tromey.com>
9809
9810         * ui-out.c: Fix includes.
9811         * tui/tui-source.c: Fix includes.
9812         * target.c: Fix includes.
9813         * remote.c: Fix includes.
9814         * regcache.c: Fix includes.
9815         * python/py-block.c: Fix includes.
9816         * printcmd.c: Fix includes.
9817         * or1k-tdep.c: Fix includes.
9818         * mi/mi-main.c: Fix includes.
9819         * m32r-tdep.c: Fix includes.
9820         * csky-tdep.c: Fix includes.
9821         * compile/compile-cplus-types.c: Fix includes.
9822         * cli/cli-interp.c: Fix includes.
9823
9824 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9825
9826         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9827         for padding.
9828
9829 2019-01-16  Tom Tromey  <tom@tromey.com>
9830
9831         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9832         earlier.
9833         (struct objfile) <msymbols_range>: Move from top level.
9834         <msymbols>: New method.
9835         (class objfile_msymbols): Remove.
9836         * symtab.c (default_collect_symbol_completion_matches_break_on):
9837         Update.
9838         * symmisc.c (dump_msymbols): Update.
9839         * stabsread.c (scan_file_globals): Update.
9840         * objc-lang.c (info_selectors_command, info_classes_command)
9841         (find_methods): Update.
9842         * minsyms.c (find_solib_trampoline_target): Update.
9843         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9844         * coffread.c (coff_symfile_read): Update.
9845         * ada-lang.c (ada_lookup_simple_minsym)
9846         (ada_collect_symbol_completion_matches): Update.
9847
9848 2019-01-16  Tom Tromey  <tom@tromey.com>
9849
9850         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9851         type.  Remove no-argument constructor.
9852         <iterator::operator++>: Simplify.
9853         <begin>: Update.
9854         <end>: Use minimal_symbol_count.
9855
9856 2019-01-16  Tom Tromey  <tom@tromey.com>
9857
9858         * objfiles.h (struct objfile) <psymtabs>: New method.
9859         (class objfile_psymtabs): Remove.
9860         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9861         typedef.
9862         <range>: New method.
9863         (require_partial_symbols): Change return type.
9864         * psymtab.c (require_partial_symbols)
9865         (psym_expand_symtabs_matching): Update.
9866         * mdebugread.c (parse_partial_symbols): Update.
9867         * dbxread.c (dbx_end_psymtab): Update.
9868
9869 2019-01-15  Tom Tromey  <tom@tromey.com>
9870
9871         * symtab.c (lookup_objfile_from_block)
9872         (lookup_symbol_in_objfile_symtabs)
9873         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9874         (find_line_symtab, info_sources_command)
9875         (default_collect_symbol_completion_matches_break_on)
9876         (make_source_files_completion_list): Update.
9877         * symmisc.c (print_objfile_statistics, dump_objfile)
9878         (maintenance_print_symbols, maintenance_info_symtabs)
9879         (maintenance_check_symtabs, maintenance_info_line_tables):
9880         Update.
9881         * source.c (select_source_symtab)
9882         (forget_cached_source_info_for_objfile): Update.
9883         * objfiles.h (class objfile_compunits): Remove.
9884         (struct objfile) <compunits_range>: New typedef.
9885         (compunits): New method.
9886         * objfiles.c (objfile_relocate1): Update.
9887         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9888         * maint.c (count_symtabs_and_blocks): Update.
9889         * linespec.c (iterate_over_all_matching_symtabs): Update.
9890         * cp-support.c (add_symbol_overload_list_qualified): Update.
9891         * coffread.c (coff_symtab_read): Update.
9892         * ada-lang.c (add_nonlocal_symbols)
9893         (ada_collect_symbol_completion_matches)
9894         (ada_add_global_exceptions): Update.
9895
9896 2019-01-15  Tom Tromey  <tom@tromey.com>
9897
9898         * progspace.h (program_space) <objfiles_safe_range>: New
9899         typedef.
9900         <objfiles_safe>: New method.
9901         * objfiles.h (class all_objfiles_safe): Remove.
9902         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9903         * jit.c (jit_inferior_exit_hook): Update.
9904
9905 2019-01-17  Tom Tromey  <tom@tromey.com>
9906
9907         * progspace.h (program_space) <objfiles_range>: New typedef.
9908         <objfiles>: New method.
9909         <objfiles_head>: Rename from objfiles.
9910         (object_files): Update.
9911         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9912         * guile/scm-pretty-print.c
9913         (ppscm_find_pretty_printer_from_objfiles): Update.
9914         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9915         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9916         Update.
9917         * python/py-progspace.c (pspy_get_objfiles): Update.
9918         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9919         Update.
9920         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9921         (objfpy_lookup_objfile_by_build_id): Update.
9922         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9923         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9924         Update.
9925         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9926         (expand_symtab_containing_pc, lookup_objfile_from_block)
9927         (lookup_static_symbol, basic_lookup_transparent_type)
9928         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9929         (find_line_symtab, info_sources_command)
9930         (default_collect_symbol_completion_matches_break_on)
9931         (make_source_files_completion_list, find_main_name): Update.
9932         * symmisc.c (print_symbol_bcache_statistics)
9933         (print_objfile_statistics, maintenance_print_symbols)
9934         (maintenance_print_msymbols, maintenance_print_objfiles)
9935         (maintenance_info_symtabs, maintenance_check_symtabs)
9936         (maintenance_expand_symtabs, maintenance_info_line_tables):
9937         Update.
9938         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9939         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9940         (map_overlay_command, unmap_overlay_command)
9941         (simple_overlay_update, expand_symtabs_matching)
9942         (map_symbol_filenames): Update.
9943         * symfile-debug.c (set_debug_symfile): Update.
9944         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9945         Update.
9946         * source.c (select_source_symtab, forget_cached_source_info):
9947         Update.
9948         * solib.c (solib_read_symbols): Update.
9949         * solib-spu.c (append_ocl_sos): Update.
9950         * psymtab.c (maintenance_print_psymbols)
9951         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9952         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9953         * printcmd.c (info_symbol_command): Update.
9954         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9955         Update.
9956         * objfiles.h (class all_objfiles): Remove.
9957         * objfiles.c (have_partial_symbols, have_full_symbols)
9958         (have_minimal_symbols, qsort_cmp, update_section_map)
9959         (shared_objfile_contains_address_p)
9960         (default_iterate_over_objfiles_in_search_order): Update.
9961         * objc-lang.c (info_selectors_command, info_classes_command)
9962         (find_methods): Update.
9963         * minsyms.c (find_solib_trampoline_target): Update.
9964         * maint.c (maintenance_info_sections)
9965         (maintenance_translate_address, count_symtabs_and_blocks):
9966         Update.
9967         * main.c (captured_main_1): Update.
9968         * linux-thread-db.c (try_thread_db_load_from_pdir)
9969         (has_libpthread): Update.
9970         * linespec.c (iterate_over_all_matching_symtabs)
9971         (search_minsyms_for_name): Update.
9972         * jit.c (jit_find_objf_with_entry_addr): Update.
9973         * hppa-tdep.c (find_unwind_entry)
9974         (hppa_lookup_stub_minimal_symbol): Update.
9975         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9976         Update.
9977         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9978         (elf_gnu_ifunc_resolve_by_got): Update.
9979         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9980         * dwarf-index-write.c (save_gdb_index_command): Update.
9981         * cp-support.c (add_symbol_overload_list_qualified): Update.
9982         * breakpoint.c (create_overlay_event_breakpoint)
9983         (create_longjmp_master_breakpoint)
9984         (create_std_terminate_master_breakpoint)
9985         (create_exception_master_breakpoint): Update.
9986         * blockframe.c (find_pc_partial_function): Update.
9987         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9988         (ada_collect_symbol_completion_matches)
9989         (ada_add_global_exceptions): Update.
9990
9991 2019-01-17  Tom Tromey  <tom@tromey.com>
9992
9993         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9994         declare VEC.
9995         (solib_target_parse_libraries): Change return type.
9996         (library_list_start_segment, library_list_start_section)
9997         (library_list_end_library, library_list_start_library); Update.
9998         (solib_target_free_library_list): Remove.
9999         (solib_target_parse_libraries): Remove cleanup.  Change return
10000         type.
10001         (solib_target_current_sos): Update.
10002
10003 2019-01-17  Tom Tromey  <tromey@bapiya>
10004
10005         * valprint.c: Replace "the the" with "the".
10006         * symtab.c: Replace "the the" with "the".
10007         * solib.c: Replace "the the" with "the".
10008         * solib-dsbt.c: Replace "the the" with "the".
10009         * linespec.c: Replace "the the" with "the".
10010         * dwarf2loc.h: Replace "the the" with "the".
10011         * amd64-windows-tdep.c: Replace "the the" with "the".
10012         * aarch64-tdep.c: Replace "the the" with "the".
10013
10014 2019-01-16  Keith Seitz  <keiths@redhat.com>
10015
10016         PR gdb/23773
10017         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10018         <builder>: Rename to ..
10019         <m_builder>: ... this and make private.
10020         (dwarf2_cu::get_builder): New method.  Change all users of
10021         `builder' to use this method.
10022         (dwarf2_start_symtab): Move to ...
10023         (dwarf2_cu::start_symtab): ... here.  Update all callers
10024         (setup_type_unit_groups): Move to ...
10025         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10026         callers.
10027         (dwarf2_cu::reset_builder): New method.
10028         (process_full_compunit, process_full_type_unit): Use
10029         dwarf2_cu::reset_builder.
10030         (follow_die_offset): Record the ancestor CU if it is different
10031         from the followed DIE's CU.
10032         (follow_die_sig_1): Likewise.
10033
10034 2019-01-15  Tom Tromey  <tom@tromey.com>
10035
10036         * remote.c (class remote_state) <buf>: Now a char_vector.
10037         <buf_size>: Remove.
10038         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10039         parameter.
10040         (remote_target::getpkt_or_notif_sane_1)
10041         (remote_target::getpkt_sane)
10042         (remote_target::getpkt_or_notif_sane): Likewise.
10043         (class remote_target) <putpkt>: New overload.
10044         (remote_target::read_frame): Change type of "buf_p".  Remove
10045         sizeof_p parameter.
10046         (packet_ok): New overload.
10047         (packet_check_result): New overload.
10048         Update all uses.
10049
10050 2019-01-14  Tom Tromey  <tom@tromey.com>
10051
10052         * remote-notif.c (handle_notification, remote_notif_ack)
10053         (remote_notif_parse): Make "buf" const.
10054         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10055         const.
10056         (remote_notif_parse, remote_notif_ack, handle_notification):
10057         Likewise.
10058         * remote.c (remote_notif_stop_parse): Make "buf" const.
10059         (remote_target::remote_parse_stop_reply): Make "buf" const.
10060         (remote_notif_stop_ack): Make "buf" const.
10061
10062 2019-01-14  Tom Tromey  <tom@tromey.com>
10063
10064         * remote.c (remote_console_output): Make parameter const.
10065
10066 2019-01-14  Tom Tromey  <tom@tromey.com>
10067
10068         * target-debug.h (target_debug_print_signals): Constify.
10069         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10070         * procfs.c (procfs_target::pass_signals): Update.
10071         * linux-nat.c (linux_nat_target::pass_signals): Update.
10072         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10073         * target-delegates.c: Rebuild.
10074         * remote.c (remote_target::program_signals): Update.
10075         (remote_target::pass_signals): Update.
10076         * target.c (target_pass_signals): Constify argument.
10077         (target_program_signals): Likewise.
10078         * target.h (struct target_ops) <pass_signals, program_signals>:
10079         Constify argument.
10080         (target_pass_signals, target_program_signals): Constify argument.
10081
10082 2019-01-14  Tom Tromey  <tom@tromey.com>
10083
10084         PR tui/28819:
10085         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10086
10087 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10088
10089         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10090         field.
10091         * rs6000-tdep.c: Include reggroups.h.
10092         (IS_V_ALIAS_PSEUDOREG): Define.
10093         (rs6000_register_name): Return names for the "vX" aliases.
10094         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10095         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10096         aliases.  Call default_register_reggroup_p for all other
10097         pseudo-registers.
10098         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10099         New functions.
10100         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10101         Handle "vX" aliases.
10102         (v_alias_pseudo_register_collect): New function.
10103         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10104         (rs6000_gdbarch_init): Initialize "vX" aliases as
10105         pseudo-registers.  Restore registration of
10106         rs6000_pseudo_register_reggroup_p with
10107         set_tdesc_pseudo_register_reggroup_p.
10108
10109 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10110
10111         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10112         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10113         set_gdbarch_num_pseudo_regs.
10114
10115 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10116
10117         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10118         Remove arg prefixname, add do_set and do_show.
10119         Add member functions set_list and show_list.
10120         * cli/cli-style.c (class cli_style_option): Update accordingly.
10121         (style_set_list): Move to file scope.
10122         (style_show_list): Likewise.
10123         (set_style): Call help_list.
10124         (show_style): Call cmd_show_list.
10125         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10126         Update to use the new macro.
10127
10128 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10129
10130         * ada-lang.c (_initialize_ada_language): Expand the help text
10131         for the "catch exception" command.
10132
10133 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10134
10135         * symtab.c (matching_obj_sections): Initialize obj,
10136         declare it closer to its usage.
10137
10138 2019-01-10  Tom Tromey  <tom@tromey.com>
10139
10140         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10141         (basic_inf_threads_range): Remove.
10142         (inf_threads_range, inf_non_exited_threads_range)
10143         (safe_inf_threads_range): Use next_adapter.
10144
10145 2019-01-10  Keith Seitz  <keiths@redhat.com>
10146
10147         PR gdb/23712
10148         PR symtab/23010
10149         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10150         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10151
10152 2019-01-10  Keith Seitz  <keiths@redhat.com>
10153
10154         PR gdb/23712
10155         PR symtab/23010
10156         * dictionary.c (pending_to_vector): Remove.
10157         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10158         Remove _1 suffix, replacing functions of the same name.  Update
10159         all callers.
10160         (dict_create_hashed, dict_create_hashed_expandable)
10161         (dict_create_linear, dict_create_linear_expandable, dict_free)
10162         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10163         Make functions static.
10164
10165 2019-01-10  Keith Seitz  <keiths@redhat.com>
10166
10167         PR gdb/23712
10168         PR symtab/23010
10169         * dictionary.h (struct dictionary): Replace declaration with
10170         multidictionary.
10171         (dict_create_hashed, dict_create_hashed_expandable)
10172         (dict_create_linear, dict_create_linear_expandable)
10173         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10174         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10175         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10176         taking multidictionary argument.
10177         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10178         * block.h (struct block) <dict>: Change to multidictionary
10179         and rename `multidict'.
10180         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10181         symmisc.c: Update all dictionary references to multidictionary.
10182
10183 2019-01-10  Keith Seitz  <keiths@redhat.com>
10184
10185         PR gdb/23712
10186         PR symtab/23010
10187         * dictionary.c: Include unordered_map.
10188         (pending_to_vector): New function.
10189         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10190         Rewrite the non-"_1" functions to take vector instead
10191         of linked list.
10192         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10193         "new" _1 versions of the same name.
10194         (multidictionary): Define.
10195         (std::hash<enum language): New definition.
10196         (collate_pending_symbols_by_language, mdict_create_hashed)
10197         (mdict_create_hashed_expandable, mdict_create_linear)
10198         (mdict_create_linear_expandable, mdict_free)
10199         (find_language_dictionary, create_new_language_dictionary)
10200         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10201         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10202         (mdict_size, mdict_empty): New functions.
10203         * dictionary.h (mdict_iterator): Define.
10204
10205 2019-01-10  Pedro Alves  <palves@redhat.com>
10206
10207         * breakpoint.c (read_uploaded_action)
10208         (create_tracepoint_from_upload): Adjust to use
10209         gdb::unique_xmalloc_ptr.
10210         * ctf.c (ctf_write_uploaded_tp):
10211         (SET_ARRAY_FIELD): Use emplace_back.
10212         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10213         * tracefile-tfile.c (tfile_write_uploaded_tp):
10214         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10215         gdb::unique_xmalloc_ptr.
10216         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10217         at_string, cond_string, cmd_strings>: Replace char pointers
10218         with gdb::unique_xmalloc_ptr.
10219
10220 2019-01-10  Pedro Alves  <palves@redhat.com>
10221
10222         * solib-target.c (library_list_start_library): Don't xstrdup name.
10223
10224 2019-01-10  Pedro Alves  <palves@redhat.com>
10225
10226         * mdebugread.c (parse_partial_symbols): Use
10227         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10228
10229 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10230
10231         * linux-fork.c (scoped_switch_fork_info)
10232         <~scoped_switch_fork_info>: Fix incorrect variable name.
10233
10234 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10235
10236         * linux-fork.c (scoped_switch_fork_info)
10237         <scoped_switch_fork_info>: Make explicit.
10238         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10239
10240 2019-01-10  Tom Tromey  <tom@tromey.com>
10241
10242         * objfiles.h (objfile::reset_psymtabs): Update.
10243         * objfiles.c (objfile::objfile): Update.
10244         * psymtab.h (psymtab_storage::obstack): Update.
10245         (psymtab_storage::m_obstack): Use gdb::optional.
10246         (class psymtab_storage): Update comment.  Remove objfile
10247         parameter.
10248         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10249
10250 2019-01-10  Tom Tromey  <tom@tromey.com>
10251
10252         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10253         <free_psymtabs>: Now private.
10254         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10255         (allocate_psymtab): Use new method.
10256
10257 2019-01-10  Tom Tromey  <tom@tromey.com>
10258
10259         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10260         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10261         * mdebugread.c (parse_partial_symbols): Use
10262         allocate_dependencies.
10263         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10264         allocate_dependencies.
10265         (process_psymtab_comp_unit_reader)
10266         (build_type_psymtab_dependencies): Likewise.
10267         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10268
10269 2019-01-10  Tom Tromey  <tom@tromey.com>
10270
10271         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10272         PSYMBOL_SET_LANGUAGE.
10273         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10274
10275 2019-01-10  Tom Tromey  <tom@tromey.com>
10276
10277         * psymtab.h (psymtab_storage::obstack): New method.
10278         <m_obstack>: Rename from obstack; now private.
10279         * psymtab.c (psymtab_storage): Update.
10280         * dwarf2read.c (create_addrmap_from_index)
10281         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10282         Update.
10283
10284 2019-01-10  Tom Tromey  <tom@tromey.com>
10285
10286         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10287         * objfiles.h (objfile::reset_psymtabs): New method.
10288
10289 2019-01-10  Tom Tromey  <tom@tromey.com>
10290
10291         * symmisc.c (print_symbol_bcache_statistics): Update.
10292         (print_objfile_statistics): Update.
10293         * symfile.c (reread_symbols): Update.
10294         * psymtab.h (class psymtab_storage): New.
10295         * psymtab.c (psymtab_storage): New constructor.
10296         (~psymtab_storage): New destructor.
10297         (require_partial_symbols): Update.
10298         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10299         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10300         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10301         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10302         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10303         (start_psymtab_common, end_psymtab_common)
10304         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10305         (allocate_psymtab): Update.
10306         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10307         Update.
10308         (dump_psymtab_addrmap, maintenance_print_psymbols)
10309         (maintenance_check_psymtabs): Update.
10310         (class objfile_psymtabs): Move to objfiles.h.
10311         * psympriv.h (discard_psymtab): Now inline.
10312         (psymtab_discarder::psymtab_discarder): Update.
10313         (psymtab_discarder::~psymtab_discarder): Update.
10314         (ALL_OBJFILE_PSYMTABS): Rewrite.
10315         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10316         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10317         Remove fields.
10318         <partial_symtabs>: New field.
10319         (class objfile_psymtabs): Move from psymtab.h.  Update.
10320         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10321         psymbol_cache.
10322         (objfile::~objfile): Don't destroy psymbol_cache.
10323         * mdebugread.c (parse_partial_symbols): Update.
10324         * dwarf2read.c (create_addrmap_from_index)
10325         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10326         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10327         (add_partial_subprogram, dwarf2_ranges_read): Update.
10328         * dwarf-index-write.c (write_address_map)
10329         (write_one_signatured_type, recursively_write_psymbols)
10330         (class debug_names, class debug_names, write_psymtabs_to_index):
10331         Update.
10332
10333 2019-01-10  Tom Tromey  <tom@tromey.com>
10334
10335         * symtab.h (SYMBOL_SET_NAMES): Update.
10336         (symbol_set_names): Update.
10337         (MSYMBOL_SET_NAMES): Update.
10338         * symtab.c (symbol_set_names): Change argument to be an
10339         objfile_per_bfd_storage.
10340         * psymtab.c (add_psymbol_to_bcache): Update.
10341         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10342
10343 2019-01-10  Tom Tromey  <tom@tromey.com>
10344
10345         * symtab.c (create_demangled_names_hash): Change argument to be an
10346         objfile_per_bfd_storage.
10347         (symbol_set_names): Update.
10348
10349 2019-01-10  Tom Tromey  <tom@tromey.com>
10350
10351         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10352         init_psymbol_list.
10353         * psymtab.c (init_psymbol_list): Do nothing if already called.
10354         * psympriv.h (init_psymbol_list): Add comment.
10355         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10356         init_psymbol_list.
10357         * dbxread.c (dbx_symfile_read): Unconditionally call
10358         init_psymbol_list.
10359
10360 2019-01-10  Tom Tromey  <tom@tromey.com>
10361
10362         * xcoffread.c (scan_xcoff_symtab): Update.
10363         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10364         "where".
10365         * mdebugread.c (parse_partial_symbols)
10366         (handle_psymbol_enumerators): Update.
10367         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10368         * dbxread.c (read_dbx_symtab): Update.
10369         * psympriv.h (psymbol_placement): New enum.
10370         (add_psymbol_to_list): Update.
10371
10372 2019-01-10  Tom Tromey  <tom@tromey.com>
10373
10374         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10375         static_psymbols parameters.
10376         (scan_xcoff_symtab): Update.
10377         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10378         static_psymbols parameters.
10379         * psympriv.h (start_psymtab_common): Update.
10380         * mdebugread.c (parse_partial_symbols): Update.
10381         * dwarf2read.c (create_partial_symtab): Update.
10382         * dbxread.c (read_dbx_symtab): Update.
10383         (start_psymtab): Remove global_psymbols and static_psymbols
10384         parameters.
10385
10386 2019-01-10  Tom Tromey  <tom@tromey.com>
10387
10388         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10389         * psymtab.c (allocate_psymtab): Add comment.
10390         * psympriv.h (allocate_psymtab): Add comment.
10391         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10392         initializations.
10393         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10394
10395 2019-01-10  Tom Tromey  <tom@tromey.com>
10396
10397         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10398         Don't declare.
10399         * mipsread.c: Include mdebugread.h.
10400         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10401         Declare.
10402         * elfread.c: Include mdebugread.h.
10403
10404 2019-01-09  Tom Tromey  <tom@tromey.com>
10405
10406         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10407         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10408         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10409         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10410         (psym_lookup_symbol, psym_find_last_source_symtab)
10411         (psym_forget_cached_source_info, psym_print_stats)
10412         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10413         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10414         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10415         (psym_find_compunit_symtab_by_address)
10416         (maintenance_print_psymbols, maintenance_info_psymtabs)
10417         (maintenance_check_psymtabs): Use ranged for.
10418         * psymtab.h (class objfile_psymtabs): New.
10419         (require_partial_symbols): Return objfile_psymtabs.
10420         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10421
10422 2019-01-09  Tom Tromey  <tom@tromey.com>
10423
10424         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10425         (find_pc_mapped_section, list_overlays_command)
10426         (map_overlay_command, unmap_overlay_command)
10427         (simple_overlay_update): Use all_objfiles.
10428         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10429         * printcmd.c (info_symbol_command): Use all_objfiles.
10430         * objfiles.h (ALL_OBJSECTIONS): Remove.
10431         * maint.c (maintenance_translate_address): Use all_objfiles.
10432         * gcore.c (gcore_create_callback): Use all_objfiles.
10433         (objfile_find_memory_regions): Likewise.
10434
10435 2019-01-09  Tom Tromey  <tom@tromey.com>
10436
10437         * symtab.c (find_line_symtab, info_sources_command)
10438         (make_source_files_completion_list): Use objfile_compunits.
10439         * source.c (select_source_symtab): Use objfile_compunits.
10440         * objfiles.h (struct objfile): Update comment.
10441         (ALL_OBJFILES): Remove.
10442         (ALL_FILETABS): Remove.
10443         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10444         objfile_compunits.
10445
10446 2019-01-09  Tom Tromey  <tom@tromey.com>
10447
10448         * symmisc.c (print_objfile_statistics, dump_objfile)
10449         (maintenance_print_symbols): Use compunit_filetabs.
10450         * source.c (forget_cached_source_info_for_objfile): Use
10451         compunit_filetabs.
10452         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10453         (ALL_FILETABS): Use compunit_filetabs.
10454         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10455         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10456
10457 2019-01-09  Tom Tromey  <tom@tromey.com>
10458
10459         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10460         (compunit_filetabs): New.
10461         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10462         compunit_filetabs.
10463         (info_sources_command, make_source_files_completion_list): Remove
10464         declaration.
10465         * symmisc.c (print_objfile_statistics, dump_objfile)
10466         (maintenance_print_symbols): Remove declaration.
10467         (maintenance_info_symtabs): Use compunit_filetabs.
10468         (maintenance_info_line_tables): Likewise.
10469         * source.c (select_source_symtab): Change local variable name.
10470         (forget_cached_source_info_for_objfile): Remove declaration.
10471         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10472         * objfiles.c (objfile_relocate1): Remove declaration.
10473         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10474         declaration.
10475         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10476         * coffread.c (coff_symtab_read): Remove declaration.
10477         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10478         compunit_filetabs.
10479
10480 2019-01-09  Tom Tromey  <tom@tromey.com>
10481
10482         * symtab.c (lookup_objfile_from_block)
10483         (find_pc_sect_compunit_symtab, search_symbols)
10484         (default_collect_symbol_completion_matches_break_on): Use
10485         objfile_compunits.
10486         * objfiles.h (ALL_COMPUNITS): Remove.
10487         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10488         * cp-support.c (add_symbol_overload_list_qualified): Use
10489         objfile_compunits.
10490         * ada-lang.c (ada_collect_symbol_completion_matches)
10491         (ada_add_global_exceptions): Use objfile_compunits.
10492
10493 2019-01-09  Tom Tromey  <tom@tromey.com>
10494
10495         * source.c (select_source_symtab)
10496         (forget_cached_source_info_for_objfile): Remove declaration.
10497         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10498         declaration.
10499         * maint.c (count_symtabs_and_blocks): Remove declaration.
10500         * cp-support.c (add_symbol_overload_list_qualified): Remove
10501         declaration.
10502         * coffread.c (coff_symtab_read): Remove declaration.
10503         * symtab.c (lookup_symbol_in_objfile_symtabs)
10504         (basic_lookup_transparent_type_1): Use objfile_compunits.
10505         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10506         (info_sources_command, search_symbols)
10507         (default_collect_symbol_completion_matches_break_on)
10508         (make_source_files_completion_list): Remove declaration.
10509         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10510         (ada_collect_symbol_completion_matches)
10511         (ada_add_global_exceptions): Remove declaration.
10512         * linespec.c (iterate_over_all_matching_symtabs): Use
10513         objfile_compunits.
10514         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10515         (class objfile_compunits): New.
10516         (ALL_COMPUNITS): Use objfile_compunits.
10517         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10518         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10519         objfile_compunits.
10520         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10521
10522 2019-01-09  Tom Tromey  <tom@tromey.com>
10523
10524         * symtab.c (search_symbols)
10525         (default_collect_symbol_completion_matches_break_on): Use
10526         objfile_msymbols.
10527         * ada-lang.c (ada_lookup_simple_minsym)
10528         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10529         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10530         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10531         objfile_msymbols.
10532         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10533         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10534         * objc-lang.c (find_methods): Use objfile_msymbols.
10535         (info_selectors_command, info_classes_command): Likewise.
10536         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10537         * objfiles.h (class objfile_msymbols): New.
10538         (ALL_OBJFILE_MSYMBOLS): Remove.
10539         (ALL_MSYMBOLS): Remove.
10540
10541 2019-01-09  Tom Tromey  <tom@tromey.com>
10542
10543         * common/next-iterator.h (next_adapter): Add Iterator template
10544         parameter.
10545         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10546         (class all_objfiles_safe): New.
10547         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10548         * objfiles.c (put_objfile_before): Update comment.
10549         (add_separate_debug_objfile): Likewise.
10550         (free_all_objfiles): Use all_objfiles_safe.
10551         (objfile_purge_solibs): Likewise.
10552
10553 2019-01-09  Tom Tromey  <tom@tromey.com>
10554
10555         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10556         (expand_symtab_containing_pc, lookup_static_symbol)
10557         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10558         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10559         all_objfiles.
10560         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10561         * breakpoint.c (create_overlay_event_breakpoint)
10562         (create_longjmp_master_breakpoint)
10563         (create_std_terminate_master_breakpoint)
10564         (create_exception_master_breakpoint): Use all_objfiles.
10565         * linux-thread-db.c (try_thread_db_load_from_pdir)
10566         (has_libpthread): Use all_objfiles.
10567         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10568         * linespec.c (iterate_over_all_matching_symtabs)
10569         (search_minsyms_for_name): Use all_objfiles.
10570         * maint.c (maintenance_info_sections): Use all_objfiles.
10571         * main.c (captured_main_1): Use all_objfiles.
10572         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10573         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10574         * guile/scm-pretty-print.c
10575         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10576         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10577         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10578         (maintenance_print_msymbols): Use all_objfiles.
10579         * source.c (select_source_symtab): Use all_objfiles.
10580         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10581         * symfile.c (remove_symbol_file_command)
10582         (expand_symtabs_matching, map_symbol_filenames): Use
10583         all_objfiles.
10584         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10585         all_objfiles.
10586         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10587         * objc-lang.c (find_methods): Use all_objfiles.
10588         * objfiles.c (have_partial_symbols, have_full_symbols)
10589         (have_minimal_symbols, qsort_cmp)
10590         (default_iterate_over_objfiles_in_search_order): Use
10591         all_objfiles.
10592         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10593         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10594         (maintenance_check_psymtabs): Use all_objfiles.
10595         (ALL_PSYMTABS): Remove.
10596         * compile/compile-object-run.c (do_module_cleanup): Use
10597         all_objfiles.
10598         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10599         * cp-support.c (add_symbol_overload_list_qualified): Use
10600         all_objfiles.
10601         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10602         Use all_objfiles.
10603         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10604         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10605         all_objfiles.
10606         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10607         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10608         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10609         Uses all_objfiles.
10610         * solib.c (solib_read_symbols): Use all_objfiles
10611
10612 2019-01-09  Tom Tromey  <tom@tromey.com>
10613
10614         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10615         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10616         all_objfiles.
10617         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10618         * symmisc.c (print_symbol_bcache_statistics)
10619         (print_objfile_statistics, maintenance_print_objfiles)
10620         (maintenance_info_symtabs, maintenance_check_symtabs)
10621         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10622         all_objfiles.
10623         * source.c (forget_cached_source_info): Use all_objfiles.
10624         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10625         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10626         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10627         * objfiles.c (update_section_map): Use all_objfiles.
10628         (shared_objfile_contains_address_p): Likewise.
10629         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10630         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10631
10632 2019-01-09  Tom Tromey  <tom@tromey.com>
10633
10634         * common/next-iterator.h: New file.
10635         * objfiles.h (class all_objfiles): New.
10636         (struct objfile_iterator): New.
10637
10638 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10639
10640         * NEWS: Move the description of the changed "frame", "select-frame",
10641          and "info frame" commands to the Changed commands section.
10642
10643 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10644
10645         * gdbtypes.c (check_stub_method_group): Remove handling of old
10646         mangling schemes.
10647         * linespec.c (find_methods): Likewise.
10648         * stabsread.c (read_member_functions): Likewise.
10649         * valops.c (search_struct_method): Likewise.
10650         (value_struct_elt_for_reference): Likewise.
10651         * NEWS: Mention this change.
10652
10653 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10654
10655         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10656         print_source_lines.
10657         * source.c (print_source_lines_base): Update line number check.
10658         (print_source_lines): New function.
10659         (source_lines_range::source_lines_range): New function.
10660         * source.h (class source_lines_range): New class.
10661         (print_source_lines): New declaration.
10662
10663 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10664
10665         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10666
10667 2019-01-08  Tom Tromey  <tom@tromey.com>
10668             Simon Marchi  <simon.marchi@ericsson.com>
10669
10670         PR gdb/24060
10671         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10672         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10673         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10674         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10675         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10676         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10677
10678 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10679
10680         * source.c (select_source_symtab): Move header comment to
10681         declaration in source.h.
10682         (forget_cached_source_info_for_objfile): Likewise.
10683         (forget_cached_source_info): Likewise.
10684         (identify_source_line): Likewise.
10685         * source.h (identify_source_line): Move declaration from symtab.h
10686         and add comment from source.c
10687         (print_source_lines): Likewise.
10688         (forget_cached_source_info_for_objfile): Likewise.
10689         (forget_cached_source_info): Likewise.
10690         (select_source_symtab): Likewise.
10691         (enum print_source_lines_flag): Move definition from symtab.h.
10692         * symtab.h (identify_source_line): Move declaration to source.h.
10693         (print_source_lines): Likewise.
10694         (forget_cached_source_info_for_objfile): Likewise.
10695         (forget_cached_source_info): Likewise.
10696         (select_source_symtab): Likewise.
10697         (enum print_source_lines_flag): Move definition to source.h.
10698         * tui/tui-hooks.c: Add 'source.h' include.
10699
10700 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10701
10702         * source.c (print_source_lines_base): Handle requests to print
10703         reverse line number sequences, and guard against empty lines
10704         string.
10705
10706 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10707
10708         * source.c (print_source_lines_base): Fix skip of '\r' if next
10709         character is '\n'.
10710
10711 2019-01-06  Tom Tromey  <tom@tromey.com>
10712
10713         * c-exp.y (struct c_parse_state) <macro_original_text,
10714         expansion_obstack>: New member.
10715         (macro_original_text, expansion_obstack): Remove globals.
10716         (scan_macro_expansion, scanning_macro_expansion)
10717         (finished_macro_expansion): Update.
10718         (scan_macro_cleanup): Remove.
10719         (yylex, c_parse): Update.
10720
10721 2019-01-06  Tom Tromey  <tom@tromey.com>
10722
10723         * c-exp.y (struct c_parse_state) <strings>: New member.
10724         (operator_stoken): Update.
10725
10726 2019-01-06  Tom Tromey  <tom@tromey.com>
10727
10728         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10729         (union type_stack_elt) <typelist_val>: Now a pointer to
10730         std::vector.
10731         (type_stack_cleanup): Don't declare.
10732         (push_typelist): Update.
10733         * parse.c (pop_typelist): Return a std::vector.
10734         (push_typelist): Take a std::vector.
10735         (follow_types): Update.  Do not free args.
10736         (type_stack_cleanup): Remove.
10737         * c-exp.y (struct c_parse_state): New.
10738         (cpstate): New global.
10739         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10740         (nonempty_typelist): Update.
10741         (func_mod): Create a new vector.
10742         (c_parse): Create a c_parse_state.
10743         (check_parameter_typelist): Do not delete params.
10744         (function_method): Update.  Do not delete type_list.
10745
10746 2019-01-06  Tom Tromey  <tom@tromey.com>
10747
10748         PR gdb/28155:
10749         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10750         check_typedef.
10751         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10752         (print_return_value): Likewise.
10753
10754 2019-01-05  Tom Tromey  <tom@tromey.com>
10755
10756         * contrib/cleanup_check.py: Remove.
10757         * contrib/gcc-with-excheck: Remove.
10758         * contrib/exsummary.py: Remove.
10759         * contrib/excheck.py: Remove.
10760
10761 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10762
10763         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10764         NULL. Initialize tpprev to NULL instead of assigning it
10765         to NULL on the next statement.
10766         * windows-nat.c (windows_delete_thread): Remove check for
10767         main_thread_id before printing thread exit notifications.
10768         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10769         Remove thread ID check against main_thread_id.
10770         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10771         windows_delete_thread.
10772         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10773
10774 2019-01-04  Tom Tromey  <tom@tromey.com>
10775
10776         * compile/compile.c (_initialize_compile): Use upper case for
10777         metasyntactic variables.
10778         * symmisc.c (_initialize_symmisc): Use upper case for
10779         metasyntactic variables.
10780         * psymtab.c (_initialize_psymtab): Use upper case for
10781         metasyntactic variables.
10782         * demangle.c (demangle_command): Use upper case for metasyntactic
10783         variables.
10784         (_initialize_demangler): Likewise.
10785         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10786         variables.
10787
10788 2019-01-03  Tom Tromey  <tom@tromey.com>
10789
10790         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10791
10792 2019-01-03  Tom Tromey  <tom@tromey.com>
10793
10794         * python/py-symtab.c (salpy_str): Update.
10795         (struct salpy_sal_object) <symtab>: Now a PyObject.
10796         (salpy_dealloc): Update.
10797         (del_objfile_sal): Use gdbpy_ref.
10798
10799 2019-01-03  Tom Tromey  <tom@tromey.com>
10800
10801         * python/py-type.c (convert_field): Use new_reference.  Return
10802         gdbpy_ref.
10803         (make_fielditem): Return gdbpy_ref.
10804         (typy_fields): Update.
10805         (typy_getitem): Update.
10806         (field_name): Return gdbpy_ref.  Use new_reference.
10807         (typy_iterator_iternext): Update.
10808
10809 2019-01-03  Tom Tromey  <tom@tromey.com>
10810
10811         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10812
10813 2019-01-03  Tom Tromey  <tom@tromey.com>
10814
10815         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10816         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10817         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10818         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10819         (pspy_set_type_printers): Likewise.
10820         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10821         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10822         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10823         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10824         (objfpy_set_type_printers): Likewise.
10825
10826 2019-01-03  Tom Tromey  <tom@tromey.com>
10827
10828         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10829         (gdbpy_print_stack): Use gdbpy_err_fetch.
10830         * python/python-internal.h (class gdbpy_err_fetch): New class.
10831         (class gdbpy_enter) <m_error_type, m_error_value,
10832         m_error_traceback>: Remove.
10833         <m_error>: New member.
10834         (gdbpy_exception_to_string): Don't declare.
10835         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10836         * python/py-value.c (convert_value_from_python): Use
10837         gdbpy_err_fetch.
10838         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10839         gdbpy_exception_to_string.
10840         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10841         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10842         gdbpy_err_fetch.
10843
10844 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10845
10846         * linux-nat.c (delete_lwp_cleanup): Delete.
10847         (struct lwp_deleter): New struct.
10848         (lwp_info_up): New typedef.
10849         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10850         lwp_info_up.
10851
10852 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10853
10854         * linux-fork.c (class scoped_switch_fork_info): New class.
10855         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10856
10857 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10858
10859         * valops.c (find_overload_match): Remove use of null_cleanup, and
10860         calls to do_cleanups.
10861
10862 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10863
10864         * compile/compile-cplus-types.c
10865         (compile_cplus_instance::decl_name): Handle changes to
10866         cp_func_name.
10867         * cp-support.c (cp_func_name): Update header comment, update
10868         return type.
10869         * cp-support.h (cp_func_name): Update return type in declaration.
10870         * valops.c (find_overload_match): Move temp_func local to top
10871         level of function and change its type.  Use temp_func to hold and
10872         delete temporary string obtained from cp_func_name.
10873
10874 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10875
10876         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10877         gdb::char_vector, remove cleanup, and update uses of `msg`.
10878
10879 2019-01-03  Jim Wilson  <jimw@sifive.com>
10880
10881         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10882
10883 2019-01-02  Tom Tromey  <tom@tromey.com>
10884
10885         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10886         (tdesc_parse_xml): Remove cleanups.
10887         * target-descriptions.h (make_cleanup_free_target_description):
10888         Don't declare.
10889         (target_desc_deleter): New struct.
10890         (target_desc_up): New typedef.
10891         * target-descriptions.c (target_desc_deleter::operator()): Rename
10892         from free_target_description.
10893         (make_cleanup_free_target_description): Remove.
10894
10895 2019-01-02  Tom Tromey  <tom@tromey.com>
10896
10897         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10898         constructor, destructor.
10899         (linespec_parser): Remove typedef.
10900         (~linespec_parser): Rename from linespec_parser_delete.
10901         (linespec_lex_to_end, linespec_complete_label)
10902         (linespec_complete): Update.
10903         (decode_line_full): Remove cleanups.
10904         (decode_line_1): Update.
10905
10906 2019-01-02  Tom Tromey  <tom@tromey.com>
10907
10908         * python/python-internal.h (inferior_to_inferior_object): Change
10909         return type.
10910         * python/py-exitedevent.c (create_exited_event_object): Update.
10911         * python/py-inferior.c (inferior_to_inferior_object): Return
10912         gdbpy_ref.
10913         (python_new_inferior, python_inferior_deleted)
10914         (thread_to_thread_object, delete_thread_object)
10915         (build_inferior_list, gdbpy_selected_inferior): Update.
10916         * python/py-infthread.c (create_thread_object): Update.  Also fail
10917         if inferior_to_inferior_object fails.
10918
10919 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10920
10921         * inferior.h (class inferior) <displaced_step_state>: New field.
10922         * infrun.h (struct displaced_step_state): Move here from
10923         infrun.c.  Initialize fields, add constructor.
10924         <inf>: Remove field.
10925         <reset>: New method.
10926         * infrun.c (struct displaced_step_inferior_state): Move to
10927         infrun.h.
10928         (displaced_step_inferior_states): Remove.
10929         (get_displaced_stepping_state): Adust.
10930         (displaced_step_in_progress_any_inferior): Adjust.
10931         (displaced_step_in_progress_thread): Adjust.
10932         (displaced_step_in_progress): Adjust.
10933         (add_displaced_stepping_state): Remove.
10934         (get_displaced_step_closure_by_addr): Adjust.
10935         (remove_displaced_stepping_state): Remove.
10936         (infrun_inferior_exit): Call displaced_step_state.reset.
10937         (use_displaced_stepping): Don't check for NULL.
10938         (displaced_step_prepare_throw): Call
10939         get_displaced_stepping_state.
10940         (displaced_step_fixup): Don't check for NULL.
10941         (prepare_for_detach): Don't check for NULL.
10942
10943 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10944
10945         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10946          in case of call that did not complete.
10947
10948 2019-01-02  Andrey Utkin  <autkin@undo.io>
10949
10950         * symfile.c (find_separate_debug_file): Fix search of debug files for
10951         remote debuggee.
10952
10953 2019-01-02  Tom Tromey  <tom@tromey.com>
10954
10955         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10956         indentation.
10957         * python/py-frame.c (frapy_older): Remove cast.
10958         (frapy_newer): Likewise.
10959         * python/py-breakpoint.c (local_setattro): Remove cast.
10960         * python/py-arch.c (archpy_name): Remove local variable.
10961         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10962
10963 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10964
10965         * unittests/basic_string_view/element_access/char/empty.cc:
10966         Fix year range in copyright header.
10967
10968 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10969
10970         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10971         Delete.
10972         <operator==>: Update with for removed field.
10973         <hash>: Likewise.
10974         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10975         <isa_features>: ...this.
10976         <abi_features>: New field.
10977         (riscv_isa_flen): Update comment.
10978         (riscv_abi_xlen): New declaration.
10979         (riscv_abi_flen): New declaration.
10980         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10981         isa_features.
10982         (riscv_abi_xlen): New function.
10983         (riscv_isa_flen): Update to get answer from isa_features.
10984         (riscv_abi_flen): New function.
10985         (riscv_has_fp_abi): Update to get answer from abi_features.
10986         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10987         xlen and flen.
10988         (riscv_call_info) <xlen, flen>: Update comment.
10989         (riscv_call_arg_struct): Remove invalid assertions
10990         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10991         is removed.
10992         (riscv_gdbarch_init): Gather isa features and abi features
10993         separately, ensure both match on the gdbarch when reusing an old
10994         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10995         a target with 64-bit float hardware.
10996
10997 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10998
10999         * source.c (search_command_helper): Stop reverse search
11000         when line 1 has been searched.
11001
11002 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11003
11004         * record-full.c (record_full_base_target::close): Rewrite
11005         record_full_core_buf_list free logic.
11006
11007 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11008
11009         * break-catch-syscall.c (print_one_catch_syscall): xfree
11010         the last text.
11011
11012 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11013
11014         * top.c (print_gdb_version): Update Copyright year in version
11015         message.
11016
11017 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11018
11019         Update copyright year range in all GDB files.
11020
11021 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11022
11023         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11024
11025 For older changes see ChangeLog-2018.
11026 \f
11027 Local Variables:
11028 mode: change-log
11029 left-margin: 8
11030 fill-column: 74
11031 version-control: never
11032 coding: utf-8
11033 End:
11034